{"action":"created","comment":{"url":"https://api.github.com/repos/videojs/video.js/pulls/comments/34932607","id":34932607,"diff_hunk":"@@ -141,3 +145,35 @@ test('seekable', function() {\n   result = seekable.call(mockFlash);\n   equal(result.length, mockFlash.duration_, 'seekable is empty with a zero duration');\n });\n+\n+// fake out the <object> interaction but leave all the other logic intact","path":"test/unit/tech/flash.test.js","position":32,"original_position":32,"commit_id":"a5ef4bb0b08cd958abefdcd41ba6d89e08b7e1ee","original_commit_id":"a5ef4bb0b08cd958abefdcd41ba6d89e08b7e1ee","user":{"login":"dmlap","id":56667,"avatar_url":"https://avatars.githubusercontent.com/u/56667?v=3","gravatar_id":"","url":"https://api.github.com/users/dmlap","html_url":"https://github.com/dmlap","followers_url":"https://api.github.com/users/dmlap/followers","following_url":"https://api.github.com/users/dmlap/following{/other_user}","gists_url":"https://api.github.com/users/dmlap/gists{/gist_id}","starred_url":"https://api.github.com/users/dmlap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmlap/subscriptions","organizations_url":"https://api.github.com/users/dmlap/orgs","repos_url":"https://api.github.com/users/dmlap/repos","events_url":"https://api.github.com/users/dmlap/events{/privacy}","received_events_url":"https://api.github.com/users/dmlap/received_events","type":"User","site_admin":false},"body":"This was an experiment. It implicitly pulls in more logic from the Flash tech than the `mockFlash` mechanism used elsewhere which could be a pro or a con. I can try to convert the rest of the tests over and see if it results in less setup in the individual tests if you think it's worth considering.","created_at":"2015-07-17T21:27:14Z","updated_at":"2015-07-17T21:27:14Z","html_url":"https://github.com/videojs/video.js/pull/2376#discussion_r34932607","pull_request_url":"https://api.github.com/repos/videojs/video.js/pulls/2376","_links":{"self":{"href":"https://api.github.com/repos/videojs/video.js/pulls/comments/34932607"},"html":{"href":"https://github.com/videojs/video.js/pull/2376#discussion_r34932607"},"pull_request":{"href":"https://api.github.com/repos/videojs/video.js/pulls/2376"}}},"pull_request":{"url":"https://api.github.com/repos/videojs/video.js/pulls/2376","id":40267350,"html_url":"https://github.com/videojs/video.js/pull/2376","diff_url":"https://github.com/videojs/video.js/pull/2376.diff","patch_url":"https://github.com/videojs/video.js/pull/2376.patch","issue_url":"https://api.github.com/repos/videojs/video.js/issues/2376","number":2376,"state":"open","locked":false,"title":"Seekable from source handlers","user":{"login":"dmlap","id":56667,"avatar_url":"https://avatars.githubusercontent.com/u/56667?v=3","gravatar_id":"","url":"https://api.github.com/users/dmlap","html_url":"https://github.com/dmlap","followers_url":"https://api.github.com/users/dmlap/followers","following_url":"https://api.github.com/users/dmlap/following{/other_user}","gists_url":"https://api.github.com/users/dmlap/gists{/gist_id}","starred_url":"https://api.github.com/users/dmlap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmlap/subscriptions","organizations_url":"https://api.github.com/users/dmlap/orgs","repos_url":"https://api.github.com/users/dmlap/repos","events_url":"https://api.github.com/users/dmlap/events{/privacy}","received_events_url":"https://api.github.com/users/dmlap/received_events","type":"User","site_admin":false},"body":"- Defer to the source handler for seekable(). For #2323\r\n- Clamp seeks to seekable ranges in the Flash tech","created_at":"2015-07-17T20:15:32Z","updated_at":"2015-07-17T21:27:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d54837671b2991aa69fe1322951988ff4028c407","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/videojs/video.js/pulls/2376/commits","review_comments_url":"https://api.github.com/repos/videojs/video.js/pulls/2376/comments","review_comment_url":"https://api.github.com/repos/videojs/video.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/videojs/video.js/issues/2376/comments","statuses_url":"https://api.github.com/repos/videojs/video.js/statuses/a5ef4bb0b08cd958abefdcd41ba6d89e08b7e1ee","head":{"label":"dmlap:seekable-from-source-handlers","ref":"seekable-from-source-handlers","sha":"a5ef4bb0b08cd958abefdcd41ba6d89e08b7e1ee","user":{"login":"dmlap","id":56667,"avatar_url":"https://avatars.githubusercontent.com/u/56667?v=3","gravatar_id":"","url":"https://api.github.com/users/dmlap","html_url":"https://github.com/dmlap","followers_url":"https://api.github.com/users/dmlap/followers","following_url":"https://api.github.com/users/dmlap/following{/other_user}","gists_url":"https://api.github.com/users/dmlap/gists{/gist_id}","starred_url":"https://api.github.com/users/dmlap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmlap/subscriptions","organizations_url":"https://api.github.com/users/dmlap/orgs","repos_url":"https://api.github.com/users/dmlap/repos","events_url":"https://api.github.com/users/dmlap/events{/privacy}","received_events_url":"https://api.github.com/users/dmlap/received_events","type":"User","site_admin":false},"repo":{"id":7782368,"name":"video.js","full_name":"dmlap/video.js","owner":{"login":"dmlap","id":56667,"avatar_url":"https://avatars.githubusercontent.com/u/56667?v=3","gravatar_id":"","url":"https://api.github.com/users/dmlap","html_url":"https://github.com/dmlap","followers_url":"https://api.github.com/users/dmlap/followers","following_url":"https://api.github.com/users/dmlap/following{/other_user}","gists_url":"https://api.github.com/users/dmlap/gists{/gist_id}","starred_url":"https://api.github.com/users/dmlap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmlap/subscriptions","organizations_url":"https://api.github.com/users/dmlap/orgs","repos_url":"https://api.github.com/users/dmlap/repos","events_url":"https://api.github.com/users/dmlap/events{/privacy}","received_events_url":"https://api.github.com/users/dmlap/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dmlap/video.js","description":"Universal video embed.","fork":true,"url":"https://api.github.com/repos/dmlap/video.js","forks_url":"https://api.github.com/repos/dmlap/video.js/forks","keys_url":"https://api.github.com/repos/dmlap/video.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dmlap/video.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dmlap/video.js/teams","hooks_url":"https://api.github.com/repos/dmlap/video.js/hooks","issue_events_url":"https://api.github.com/repos/dmlap/video.js/issues/events{/number}","events_url":"https://api.github.com/repos/dmlap/video.js/events","assignees_url":"https://api.github.com/repos/dmlap/video.js/assignees{/user}","branches_url":"https://api.github.com/repos/dmlap/video.js/branches{/branch}","tags_url":"https://api.github.com/repos/dmlap/video.js/tags","blobs_url":"https://api.github.com/repos/dmlap/video.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dmlap/video.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dmlap/video.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/dmlap/video.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dmlap/video.js/statuses/{sha}","languages_url":"https://api.github.com/repos/dmlap/video.js/languages","stargazers_url":"https://api.github.com/repos/dmlap/video.js/stargazers","contributors_url":"https://api.github.com/repos/dmlap/video.js/contributors","subscribers_url":"https://api.github.com/repos/dmlap/video.js/subscribers","subscription_url":"https://api.github.com/repos/dmlap/video.js/subscription","commits_url":"https://api.github.com/repos/dmlap/video.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/dmlap/video.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/dmlap/video.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/dmlap/video.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/dmlap/video.js/contents/{+path}","compare_url":"https://api.github.com/repos/dmlap/video.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dmlap/video.js/merges","archive_url":"https://api.github.com/repos/dmlap/video.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dmlap/video.js/downloads","issues_url":"https://api.github.com/repos/dmlap/video.js/issues{/number}","pulls_url":"https://api.github.com/repos/dmlap/video.js/pulls{/number}","milestones_url":"https://api.github.com/repos/dmlap/video.js/milestones{/number}","notifications_url":"https://api.github.com/repos/dmlap/video.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dmlap/video.js/labels{/name}","releases_url":"https://api.github.com/repos/dmlap/video.js/releases{/id}","created_at":"2013-01-23T19:48:25Z","updated_at":"2015-04-29T21:07:18Z","pushed_at":"2015-07-17T20:46:52Z","git_url":"git://github.com/dmlap/video.js.git","ssh_url":"git@github.com:dmlap/video.js.git","clone_url":"https://github.com/dmlap/video.js.git","svn_url":"https://github.com/dmlap/video.js","homepage":"videojs.com","size":16053,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"videojs:master","ref":"master","sha":"ca5103befea5b6ddbe83a538734f4f44c8e9d405","user":{"login":"videojs","id":3287189,"avatar_url":"https://avatars.githubusercontent.com/u/3287189?v=3","gravatar_id":"","url":"https://api.github.com/users/videojs","html_url":"https://github.com/videojs","followers_url":"https://api.github.com/users/videojs/followers","following_url":"https://api.github.com/users/videojs/following{/other_user}","gists_url":"https://api.github.com/users/videojs/gists{/gist_id}","starred_url":"https://api.github.com/users/videojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/videojs/subscriptions","organizations_url":"https://api.github.com/users/videojs/orgs","repos_url":"https://api.github.com/users/videojs/repos","events_url":"https://api.github.com/users/videojs/events{/privacy}","received_events_url":"https://api.github.com/users/videojs/received_events","type":"Organization","site_admin":false},"repo":{"id":667006,"name":"video.js","full_name":"videojs/video.js","owner":{"login":"videojs","id":3287189,"avatar_url":"https://avatars.githubusercontent.com/u/3287189?v=3","gravatar_id":"","url":"https://api.github.com/users/videojs","html_url":"https://github.com/videojs","followers_url":"https://api.github.com/users/videojs/followers","following_url":"https://api.github.com/users/videojs/following{/other_user}","gists_url":"https://api.github.com/users/videojs/gists{/gist_id}","starred_url":"https://api.github.com/users/videojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/videojs/subscriptions","organizations_url":"https://api.github.com/users/videojs/orgs","repos_url":"https://api.github.com/users/videojs/repos","events_url":"https://api.github.com/users/videojs/events{/privacy}","received_events_url":"https://api.github.com/users/videojs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/videojs/video.js","description":"Video.js - open source HTML5 & Flash video player","fork":false,"url":"https://api.github.com/repos/videojs/video.js","forks_url":"https://api.github.com/repos/videojs/video.js/forks","keys_url":"https://api.github.com/repos/videojs/video.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/videojs/video.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/videojs/video.js/teams","hooks_url":"https://api.github.com/repos/videojs/video.js/hooks","issue_events_url":"https://api.github.com/repos/videojs/video.js/issues/events{/number}","events_url":"https://api.github.com/repos/videojs/video.js/events","assignees_url":"https://api.github.com/repos/videojs/video.js/assignees{/user}","branches_url":"https://api.github.com/repos/videojs/video.js/branches{/branch}","tags_url":"https://api.github.com/repos/videojs/video.js/tags","blobs_url":"https://api.github.com/repos/videojs/video.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/videojs/video.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/videojs/video.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/videojs/video.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/videojs/video.js/statuses/{sha}","languages_url":"https://api.github.com/repos/videojs/video.js/languages","stargazers_url":"https://api.github.com/repos/videojs/video.js/stargazers","contributors_url":"https://api.github.com/repos/videojs/video.js/contributors","subscribers_url":"https://api.github.com/repos/videojs/video.js/subscribers","subscription_url":"https://api.github.com/repos/videojs/video.js/subscription","commits_url":"https://api.github.com/repos/videojs/video.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/videojs/video.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/videojs/video.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/videojs/video.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/videojs/video.js/contents/{+path}","compare_url":"https://api.github.com/repos/videojs/video.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/videojs/video.js/merges","archive_url":"https://api.github.com/repos/videojs/video.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/videojs/video.js/downloads","issues_url":"https://api.github.com/repos/videojs/video.js/issues{/number}","pulls_url":"https://api.github.com/repos/videojs/video.js/pulls{/number}","milestones_url":"https://api.github.com/repos/videojs/video.js/milestones{/number}","notifications_url":"https://api.github.com/repos/videojs/video.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/videojs/video.js/labels{/name}","releases_url":"https://api.github.com/repos/videojs/video.js/releases{/id}","created_at":"2010-05-14T18:45:10Z","updated_at":"2015-07-17T19:29:19Z","pushed_at":"2015-07-17T20:46:53Z","git_url":"git://github.com/videojs/video.js.git","ssh_url":"git@github.com:videojs/video.js.git","clone_url":"https://github.com/videojs/video.js.git","svn_url":"https://github.com/videojs/video.js","homepage":"www.videojs.com","size":52008,"stargazers_count":9602,"watchers_count":9602,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":2744,"mirror_url":null,"open_issues_count":211,"forks":2744,"open_issues":211,"watchers":9602,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/videojs/video.js/pulls/2376"},"html":{"href":"https://github.com/videojs/video.js/pull/2376"},"issue":{"href":"https://api.github.com/repos/videojs/video.js/issues/2376"},"comments":{"href":"https://api.github.com/repos/videojs/video.js/issues/2376/comments"},"review_comments":{"href":"https://api.github.com/repos/videojs/video.js/pulls/2376/comments"},"review_comment":{"href":"https://api.github.com/repos/videojs/video.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/videojs/video.js/pulls/2376/commits"},"statuses":{"href":"https://api.github.com/repos/videojs/video.js/statuses/a5ef4bb0b08cd958abefdcd41ba6d89e08b7e1ee"}}}}