{"action":"closed","number":12,"pull_request":{"url":"https://api.github.com/repos/umn-asr/peoplesoft_course_class_data/pulls/12","id":37717661,"html_url":"https://github.com/umn-asr/peoplesoft_course_class_data/pull/12","diff_url":"https://github.com/umn-asr/peoplesoft_course_class_data/pull/12.diff","patch_url":"https://github.com/umn-asr/peoplesoft_course_class_data/pull/12.patch","issue_url":"https://api.github.com/repos/umn-asr/peoplesoft_course_class_data/issues/12","number":12,"state":"closed","locked":false,"title":"Add tests for Row ","user":{"login":"davinlagerroos","id":2103414,"avatar_url":"https://avatars.githubusercontent.com/u/2103414?v=3","gravatar_id":"","url":"https://api.github.com/users/davinlagerroos","html_url":"https://github.com/davinlagerroos","followers_url":"https://api.github.com/users/davinlagerroos/followers","following_url":"https://api.github.com/users/davinlagerroos/following{/other_user}","gists_url":"https://api.github.com/users/davinlagerroos/gists{/gist_id}","starred_url":"https://api.github.com/users/davinlagerroos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davinlagerroos/subscriptions","organizations_url":"https://api.github.com/users/davinlagerroos/orgs","repos_url":"https://api.github.com/users/davinlagerroos/repos","events_url":"https://api.github.com/users/davinlagerroos/events{/privacy}","received_events_url":"https://api.github.com/users/davinlagerroos/received_events","type":"User","site_admin":false},"body":"Adds a spec for the Row class.\r\n\r\nRow uses a supplied config hash to autogenerate methods that map to values in xml nodes. This was tested indirectly by an integration style test. The existing code works but it certainly can be more elegant, so this pull request adds unit level tests to facilitate a refactor. \r\n\r\nMost of the tests exercise the basic functionality of how the methods are configured. \r\n\r\nThe \"when the row is from a document with multiple rows\" context covers some unexpected (to me at least) behavior around searching the node set that the Row class receives. Although the Row class receives a `<row></row>` to parse, using `//` in xpath searches will return results from the entire containing document, i.e. all the rows.\r\n\r\nUpdated 6/16 to use NodeSet to parse xml string with nokogiri","created_at":"2015-06-15T17:53:44Z","updated_at":"2015-06-16T14:20:37Z","closed_at":"2015-06-16T14:20:37Z","merged_at":"2015-06-16T14:20:37Z","merge_commit_sha":"8127010a5bda9fd4dd87d1e4437124f5e6a90180","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/umn-asr/peoplesoft_course_class_data/pulls/12/commits","review_comments_url":"https://api.github.com/repos/umn-asr/peoplesoft_course_class_data/pulls/12/comments","review_comment_url":"https://api.github.com/repos/umn-asr/peoplesoft_course_class_data/pulls/comments{/number}","comments_url":"https://api.github.com/repos/umn-asr/peoplesoft_course_class_data/issues/12/comments","statuses_url":"https://api.github.com/repos/umn-asr/peoplesoft_course_class_data/statuses/9042b438d4f6f729d2bc82b1dad4e783cafd1130","head":{"label":"umn-asr:row_tests","ref":"row_tests","sha":"9042b438d4f6f729d2bc82b1dad4e783cafd1130","user":{"login":"umn-asr","id":1200743,"avatar_url":"https://avatars.githubusercontent.com/u/1200743?v=3","gravatar_id":"","url":"https://api.github.com/users/umn-asr","html_url":"https://github.com/umn-asr","followers_url":"https://api.github.com/users/umn-asr/followers","following_url":"https://api.github.com/users/umn-asr/following{/other_user}","gists_url":"https://api.github.com/users/umn-asr/gists{/gist_id}","starred_url":"https://api.github.com/users/umn-asr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/umn-asr/subscriptions","organizations_url":"https://api.github.com/users/umn-asr/orgs","repos_url":"https://api.github.com/users/umn-asr/repos","events_url":"https://api.github.com/users/umn-asr/events{/privacy}","received_events_url":"https://api.github.com/users/umn-asr/received_events","type":"Organization","site_admin":false},"repo":{"id":33933972,"name":"peoplesoft_course_class_data","full_name":"umn-asr/peoplesoft_course_class_data","owner":{"login":"umn-asr","id":1200743,"avatar_url":"https://avatars.githubusercontent.com/u/1200743?v=3","gravatar_id":"","url":"https://api.github.com/users/umn-asr","html_url":"https://github.com/umn-asr","followers_url":"https://api.github.com/users/umn-asr/followers","following_url":"https://api.github.com/users/umn-asr/following{/other_user}","gists_url":"https://api.github.com/users/umn-asr/gists{/gist_id}","starred_url":"https://api.github.com/users/umn-asr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/umn-asr/subscriptions","organizations_url":"https://api.github.com/users/umn-asr/orgs","repos_url":"https://api.github.com/users/umn-asr/repos","events_url":"https://api.github.com/users/umn-asr/events{/privacy}","received_events_url":"https://api.github.com/users/umn-asr/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/umn-asr/peoplesoft_course_class_data","description":"","fork":false,"url":"https://api.github.com/repos/umn-asr/peoplesoft_course_class_data","forks_url":"https://api.github.com/repos/umn-asr/peoplesoft_course_class_data/forks","keys_url":"https://api.github.com/repos/umn-asr/peoplesoft_course_class_data/keys{/key_id}","collaborators_url":"https://api.github.com/repos/umn-asr/peoplesoft_course_class_data/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/umn-asr/peoplesoft_course_class_data/teams","hooks_url":"https://api.github.com/repos/umn-asr/peoplesoft_course_class_data/hooks","issue_events_url":"https://api.github.com/repos/umn-asr/peoplesoft_course_class_data/issues/events{/number}","events_url":"https://api.github.com/repos/umn-asr/peoplesoft_course_class_data/events","assignees_url":"https://api.github.com/repos/umn-asr/peoplesoft_course_class_data/assignees{/user}","branches_url":"https://api.github.com/repos/umn-asr/peoplesoft_course_class_data/branches{/branch}","tags_url":"https://api.github.com/repos/umn-asr/peoplesoft_course_class_data/tags","blobs_url":"https://api.github.com/repos/umn-asr/peoplesoft_course_class_data/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/umn-asr/peoplesoft_course_class_data/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/umn-asr/peoplesoft_course_class_data/git/refs{/sha}","trees_url":"https://api.github.com/repos/umn-asr/peoplesoft_course_class_data/git/trees{/sha}","statuses_url":"https://api.github.com/repos/umn-asr/peoplesoft_course_class_data/statuses/{sha}","languages_url":"https://api.github.com/repos/umn-asr/peoplesoft_course_class_data/languages","stargazers_url":"https://api.github.com/repos/umn-asr/peoplesoft_course_class_data/stargazers","contributors_url":"https://api.github.com/repos/umn-asr/peoplesoft_course_class_data/contributors","subscribers_url":"https://api.github.com/repos/umn-asr/peoplesoft_course_class_data/subscribers","subscription_url":"https://api.github.com/repos/umn-asr/peoplesoft_course_class_data/subscription","commits_url":"https://api.github.com/repos/umn-asr/peoplesoft_course_class_data/commits{/sha}","git_commits_url":"https://api.github.com/repos/umn-asr/peoplesoft_course_class_data/git/commits{/sha}","comments_url":"https://api.github.com/repos/umn-asr/peoplesoft_course_class_data/comments{/number}","issue_comment_url":"https://api.github.com/repos/umn-asr/peoplesoft_course_class_data/issues/comments{/number}","contents_url":"https://api.github.com/repos/umn-asr/peoplesoft_course_class_data/contents/{+path}","compare_url":"https://api.github.com/repos/umn-asr/peoplesoft_course_class_data/compare/{base}...{head}","merges_url":"https://api.github.com/repos/umn-asr/peoplesoft_course_class_data/merges","archive_url":"https://api.github.com/repos/umn-asr/peoplesoft_course_class_data/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/umn-asr/peoplesoft_course_class_data/downloads","issues_url":"https://api.github.com/repos/umn-asr/peoplesoft_course_class_data/issues{/number}","pulls_url":"https://api.github.com/repos/umn-asr/peoplesoft_course_class_data/pulls{/number}","milestones_url":"https://api.github.com/repos/umn-asr/peoplesoft_course_class_data/milestones{/number}","notifications_url":"https://api.github.com/repos/umn-asr/peoplesoft_course_class_data/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/umn-asr/peoplesoft_course_class_data/labels{/name}","releases_url":"https://api.github.com/repos/umn-asr/peoplesoft_course_class_data/releases{/id}","created_at":"2015-04-14T13:40:24Z","updated_at":"2015-05-06T14:27:33Z","pushed_at":"2015-06-16T14:20:37Z","git_url":"git://github.com/umn-asr/peoplesoft_course_class_data.git","ssh_url":"git@github.com:umn-asr/peoplesoft_course_class_data.git","clone_url":"https://github.com/umn-asr/peoplesoft_course_class_data.git","svn_url":"https://github.com/umn-asr/peoplesoft_course_class_data","homepage":null,"size":608,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":0,"default_branch":"master"}},"base":{"label":"umn-asr:import_course_extract","ref":"import_course_extract","sha":"bba9f9d470c56b209f5a165f4e0011203ee14416","user":{"login":"umn-asr","id":1200743,"avatar_url":"https://avatars.githubusercontent.com/u/1200743?v=3","gravatar_id":"","url":"https://api.github.com/users/umn-asr","html_url":"https://github.com/umn-asr","followers_url":"https://api.github.com/users/umn-asr/followers","following_url":"https://api.github.com/users/umn-asr/following{/other_user}","gists_url":"https://api.github.com/users/umn-asr/gists{/gist_id}","starred_url":"https://api.github.com/users/umn-asr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/umn-asr/subscriptions","organizations_url":"https://api.github.com/users/umn-asr/orgs","repos_url":"https://api.github.com/users/umn-asr/repos","events_url":"https://api.github.com/users/umn-asr/events{/privacy}","received_events_url":"https://api.github.com/users/umn-asr/received_events","type":"Organization","site_admin":false},"repo":{"id":33933972,"name":"peoplesoft_course_class_data","full_name":"umn-asr/peoplesoft_course_class_data","owner":{"login":"umn-asr","id":1200743,"avatar_url":"https://avatars.githubusercontent.com/u/1200743?v=3","gravatar_id":"","url":"https://api.github.com/users/umn-asr","html_url":"https://github.com/umn-asr","followers_url":"https://api.github.com/users/umn-asr/followers","following_url":"https://api.github.com/users/umn-asr/following{/other_user}","gists_url":"https://api.github.com/users/umn-asr/gists{/gist_id}","starred_url":"https://api.github.com/users/umn-asr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/umn-asr/subscriptions","organizations_url":"https://api.github.com/users/umn-asr/orgs","repos_url":"https://api.github.com/users/umn-asr/repos","events_url":"https://api.github.com/users/umn-asr/events{/privacy}","received_events_url":"https://api.github.com/users/umn-asr/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/umn-asr/peoplesoft_course_class_data","description":"","fork":false,"url":"https://api.github.com/repos/umn-asr/peoplesoft_course_class_data","forks_url":"https://api.github.com/repos/umn-asr/peoplesoft_course_class_data/forks","keys_url":"https://api.github.com/repos/umn-asr/peoplesoft_course_class_data/keys{/key_id}","collaborators_url":"https://api.github.com/repos/umn-asr/peoplesoft_course_class_data/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/umn-asr/peoplesoft_course_class_data/teams","hooks_url":"https://api.github.com/repos/umn-asr/peoplesoft_course_class_data/hooks","issue_events_url":"https://api.github.com/repos/umn-asr/peoplesoft_course_class_data/issues/events{/number}","events_url":"https://api.github.com/repos/umn-asr/peoplesoft_course_class_data/events","assignees_url":"https://api.github.com/repos/umn-asr/peoplesoft_course_class_data/assignees{/user}","branches_url":"https://api.github.com/repos/umn-asr/peoplesoft_course_class_data/branches{/branch}","tags_url":"https://api.github.com/repos/umn-asr/peoplesoft_course_class_data/tags","blobs_url":"https://api.github.com/repos/umn-asr/peoplesoft_course_class_data/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/umn-asr/peoplesoft_course_class_data/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/umn-asr/peoplesoft_course_class_data/git/refs{/sha}","trees_url":"https://api.github.com/repos/umn-asr/peoplesoft_course_class_data/git/trees{/sha}","statuses_url":"https://api.github.com/repos/umn-asr/peoplesoft_course_class_data/statuses/{sha}","languages_url":"https://api.github.com/repos/umn-asr/peoplesoft_course_class_data/languages","stargazers_url":"https://api.github.com/repos/umn-asr/peoplesoft_course_class_data/stargazers","contributors_url":"https://api.github.com/repos/umn-asr/peoplesoft_course_class_data/contributors","subscribers_url":"https://api.github.com/repos/umn-asr/peoplesoft_course_class_data/subscribers","subscription_url":"https://api.github.com/repos/umn-asr/peoplesoft_course_class_data/subscription","commits_url":"https://api.github.com/repos/umn-asr/peoplesoft_course_class_data/commits{/sha}","git_commits_url":"https://api.github.com/repos/umn-asr/peoplesoft_course_class_data/git/commits{/sha}","comments_url":"https://api.github.com/repos/umn-asr/peoplesoft_course_class_data/comments{/number}","issue_comment_url":"https://api.github.com/repos/umn-asr/peoplesoft_course_class_data/issues/comments{/number}","contents_url":"https://api.github.com/repos/umn-asr/peoplesoft_course_class_data/contents/{+path}","compare_url":"https://api.github.com/repos/umn-asr/peoplesoft_course_class_data/compare/{base}...{head}","merges_url":"https://api.github.com/repos/umn-asr/peoplesoft_course_class_data/merges","archive_url":"https://api.github.com/repos/umn-asr/peoplesoft_course_class_data/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/umn-asr/peoplesoft_course_class_data/downloads","issues_url":"https://api.github.com/repos/umn-asr/peoplesoft_course_class_data/issues{/number}","pulls_url":"https://api.github.com/repos/umn-asr/peoplesoft_course_class_data/pulls{/number}","milestones_url":"https://api.github.com/repos/umn-asr/peoplesoft_course_class_data/milestones{/number}","notifications_url":"https://api.github.com/repos/umn-asr/peoplesoft_course_class_data/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/umn-asr/peoplesoft_course_class_data/labels{/name}","releases_url":"https://api.github.com/repos/umn-asr/peoplesoft_course_class_data/releases{/id}","created_at":"2015-04-14T13:40:24Z","updated_at":"2015-05-06T14:27:33Z","pushed_at":"2015-06-16T14:20:37Z","git_url":"git://github.com/umn-asr/peoplesoft_course_class_data.git","ssh_url":"git@github.com:umn-asr/peoplesoft_course_class_data.git","clone_url":"https://github.com/umn-asr/peoplesoft_course_class_data.git","svn_url":"https://github.com/umn-asr/peoplesoft_course_class_data","homepage":null,"size":608,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/umn-asr/peoplesoft_course_class_data/pulls/12"},"html":{"href":"https://github.com/umn-asr/peoplesoft_course_class_data/pull/12"},"issue":{"href":"https://api.github.com/repos/umn-asr/peoplesoft_course_class_data/issues/12"},"comments":{"href":"https://api.github.com/repos/umn-asr/peoplesoft_course_class_data/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/umn-asr/peoplesoft_course_class_data/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/umn-asr/peoplesoft_course_class_data/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/umn-asr/peoplesoft_course_class_data/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/umn-asr/peoplesoft_course_class_data/statuses/9042b438d4f6f729d2bc82b1dad4e783cafd1130"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"davinlagerroos","id":2103414,"avatar_url":"https://avatars.githubusercontent.com/u/2103414?v=3","gravatar_id":"","url":"https://api.github.com/users/davinlagerroos","html_url":"https://github.com/davinlagerroos","followers_url":"https://api.github.com/users/davinlagerroos/followers","following_url":"https://api.github.com/users/davinlagerroos/following{/other_user}","gists_url":"https://api.github.com/users/davinlagerroos/gists{/gist_id}","starred_url":"https://api.github.com/users/davinlagerroos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davinlagerroos/subscriptions","organizations_url":"https://api.github.com/users/davinlagerroos/orgs","repos_url":"https://api.github.com/users/davinlagerroos/repos","events_url":"https://api.github.com/users/davinlagerroos/events{/privacy}","received_events_url":"https://api.github.com/users/davinlagerroos/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":4,"additions":118,"deletions":0,"changed_files":1}}