{"action":"created","issue":{"url":"https://api.github.com/repos/probcomp/bayeslite/issues/248","labels_url":"https://api.github.com/repos/probcomp/bayeslite/issues/248/labels{/name}","comments_url":"https://api.github.com/repos/probcomp/bayeslite/issues/248/comments","events_url":"https://api.github.com/repos/probcomp/bayeslite/issues/248/events","html_url":"https://github.com/probcomp/bayeslite/pull/248","id":110480484,"number":248,"title":"Axch articulated tracing","user":{"login":"axch","id":233710,"avatar_url":"https://avatars.githubusercontent.com/u/233710?v=3","gravatar_id":"","url":"https://api.github.com/users/axch","html_url":"https://github.com/axch","followers_url":"https://api.github.com/users/axch/followers","following_url":"https://api.github.com/users/axch/following{/other_user}","gists_url":"https://api.github.com/users/axch/gists{/gist_id}","starred_url":"https://api.github.com/users/axch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/axch/subscriptions","organizations_url":"https://api.github.com/users/axch/orgs","repos_url":"https://api.github.com/users/axch/repos","events_url":"https://api.github.com/users/axch/events{/privacy}","received_events_url":"https://api.github.com/users/axch/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-10-08T15:50:07Z","updated_at":"2015-10-09T20:36:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/probcomp/bayeslite/pulls/248","html_url":"https://github.com/probcomp/bayeslite/pull/248","diff_url":"https://github.com/probcomp/bayeslite/pull/248.diff","patch_url":"https://github.com/probcomp/bayeslite/pull/248.patch"},"body":"Outstanding (potential) problems:\r\n- Could add a test that an unread empty cursor calls finish early\r\n- sql_execute of a query for which results are not expected may leave\r\n  an open tracer for a while (until gc gets the cursor)\r\n- {sql_,}execute of a query from which only one result is requested,\r\n  without fetchall checking that only one is provided, same\r\n- Do we want to permit or suppress multiple calls to \"finished\" on a\r\n  tracer for a given query? e.g. from multiple calls to fetchone at\r\n  the end, or multiple attempts to iterate?\r\n- Code location: where should the tracing-related classes live?\r\n  Fresh module?\r\n\r\nFor my part, I am satisfied with status quo, but amenable to changing it.\r\n"},"comment":{"url":"https://api.github.com/repos/probcomp/bayeslite/issues/comments/146980524","html_url":"https://github.com/probcomp/bayeslite/pull/248#issuecomment-146980524","issue_url":"https://api.github.com/repos/probcomp/bayeslite/issues/248","id":146980524,"user":{"login":"axch","id":233710,"avatar_url":"https://avatars.githubusercontent.com/u/233710?v=3","gravatar_id":"","url":"https://api.github.com/users/axch","html_url":"https://github.com/axch","followers_url":"https://api.github.com/users/axch/followers","following_url":"https://api.github.com/users/axch/following{/other_user}","gists_url":"https://api.github.com/users/axch/gists{/gist_id}","starred_url":"https://api.github.com/users/axch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/axch/subscriptions","organizations_url":"https://api.github.com/users/axch/orgs","repos_url":"https://api.github.com/users/axch/repos","events_url":"https://api.github.com/users/axch/events{/privacy}","received_events_url":"https://api.github.com/users/axch/received_events","type":"User","site_admin":false},"created_at":"2015-10-09T20:36:54Z","updated_at":"2015-10-09T20:36:54Z","body":"Re: discrimination on types: This kind of interface is quite common in the Python community.  In the context of Python, I feel two reasons to keep it:\r\n- I expect clients to be surprised by needing to apply a trivial transformer when they know we could have done this\r\n- It reads to me as offering less cognitive overhead (again, for the Python community): if you just want standard at-start tracing, there is a cognitive fast-path; otherwise, go read the docs of this other thing.\r\n\r\nFor my part, I prefer e.g., Haskell, where an explicit tag has the community's approval (in addition to being pretty much forced by the type system).\r\n\r\nThat said, I can change it if you feel strongly."}}