{"action":"created","issue":{"url":"https://api.github.com/repos/docker/libnetwork/issues/756","labels_url":"https://api.github.com/repos/docker/libnetwork/issues/756/labels{/name}","comments_url":"https://api.github.com/repos/docker/libnetwork/issues/756/comments","events_url":"https://api.github.com/repos/docker/libnetwork/issues/756/events","html_url":"https://github.com/docker/libnetwork/pull/756","id":117006795,"number":756,"title":"Use documentation IPv6 addresses (RFC 3849) in tests","user":{"login":"TimWolla","id":209270,"avatar_url":"https://avatars.githubusercontent.com/u/209270?v=3","gravatar_id":"","url":"https://api.github.com/users/TimWolla","html_url":"https://github.com/TimWolla","followers_url":"https://api.github.com/users/TimWolla/followers","following_url":"https://api.github.com/users/TimWolla/following{/other_user}","gists_url":"https://api.github.com/users/TimWolla/gists{/gist_id}","starred_url":"https://api.github.com/users/TimWolla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TimWolla/subscriptions","organizations_url":"https://api.github.com/users/TimWolla/orgs","repos_url":"https://api.github.com/users/TimWolla/repos","events_url":"https://api.github.com/users/TimWolla/events{/privacy}","received_events_url":"https://api.github.com/users/TimWolla/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-11-15T17:35:44Z","updated_at":"2015-11-20T00:01:36Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/docker/libnetwork/pulls/756","html_url":"https://github.com/docker/libnetwork/pull/756","diff_url":"https://github.com/docker/libnetwork/pull/756.diff","patch_url":"https://github.com/docker/libnetwork/pull/756.patch"},"body":"As discussed here: https://github.com/docker/libnetwork/pull/741/files#r44872866\r\n\r\nI searched for potentially affected files with: `grep  -ER '200.:' . |grep -iv '2001:db8'`, so maybe some places slipped through.\r\n\r\nTests still seem to pass, but I am not entirely sure whether I ran them correctly on my local box.\r\n\r\nYou also might want to take a look at these lines: https://github.com/docker/libnetwork/blob/e8ebc0bf6510343c88d162db08b3d855cbbe75b9/libnetwork_test.go#L1839-L1843\r\nThe IPv6 is Google Public DNS, so this might be correct. The IPv4 addresses belong to some Chinese Company and the domain is currently unassigned. You might want to replace the domain by `example.com` and the IPv4 addresses by addresses in some private network.\r\n\r\n/cc @aboch "},"comment":{"url":"https://api.github.com/repos/docker/libnetwork/issues/comments/158238605","html_url":"https://github.com/docker/libnetwork/pull/756#issuecomment-158238605","issue_url":"https://api.github.com/repos/docker/libnetwork/issues/756","id":158238605,"user":{"login":"aboch","id":10080882,"avatar_url":"https://avatars.githubusercontent.com/u/10080882?v=3","gravatar_id":"","url":"https://api.github.com/users/aboch","html_url":"https://github.com/aboch","followers_url":"https://api.github.com/users/aboch/followers","following_url":"https://api.github.com/users/aboch/following{/other_user}","gists_url":"https://api.github.com/users/aboch/gists{/gist_id}","starred_url":"https://api.github.com/users/aboch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aboch/subscriptions","organizations_url":"https://api.github.com/users/aboch/orgs","repos_url":"https://api.github.com/users/aboch/repos","events_url":"https://api.github.com/users/aboch/events{/privacy}","received_events_url":"https://api.github.com/users/aboch/received_events","type":"User","site_admin":false},"created_at":"2015-11-20T00:01:36Z","updated_at":"2015-11-20T00:01:36Z","body":"LGTM"}}