{"action":"created","issue":{"url":"https://api.github.com/repos/docker/docker/issues/11320","labels_url":"https://api.github.com/repos/docker/docker/issues/11320/labels{/name}","comments_url":"https://api.github.com/repos/docker/docker/issues/11320/comments","events_url":"https://api.github.com/repos/docker/docker/issues/11320/events","html_url":"https://github.com/docker/docker/pull/11320","id":60667757,"number":11320,"title":"Fix daemon shutdown on error after rework of daemon startup","user":{"login":"estesp","id":1397980,"avatar_url":"https://avatars.githubusercontent.com/u/1397980?v=3","gravatar_id":"","url":"https://api.github.com/users/estesp","html_url":"https://github.com/estesp","followers_url":"https://api.github.com/users/estesp/followers","following_url":"https://api.github.com/users/estesp/following{/other_user}","gists_url":"https://api.github.com/users/estesp/gists{/gist_id}","starred_url":"https://api.github.com/users/estesp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/estesp/subscriptions","organizations_url":"https://api.github.com/users/estesp/orgs","repos_url":"https://api.github.com/users/estesp/repos","events_url":"https://api.github.com/users/estesp/events{/privacy}","received_events_url":"https://api.github.com/users/estesp/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/docker/docker/labels/2-code-review","name":"2-code-review","color":"f7c6c7"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-03-11T14:35:46Z","updated_at":"2015-03-11T14:45:47Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/11320","html_url":"https://github.com/docker/docker/pull/11320","diff_url":"https://github.com/docker/docker/pull/11320.diff","patch_url":"https://github.com/docker/docker/pull/11320.patch"},"body":"Currently the daemon will not stop on error because the serve API job is\r\nblocking the channel wait for daemon init.  A better way is to run the\r\nblocking serve API job as a goroutine and make sure that error\r\nnotification gets back to the main daemon thread (using the already\r\nexisting channel) so that clean shutdown can occur on error.\r\n\r\nDocker-DCO-1.1-Signed-off-by: Phil Estes <estesp@linux.vnet.ibm.com> (github: estesp)"},"comment":{"url":"https://api.github.com/repos/docker/docker/issues/comments/78276929","html_url":"https://github.com/docker/docker/pull/11320#issuecomment-78276929","issue_url":"https://api.github.com/repos/docker/docker/issues/11320","id":78276929,"user":{"login":"LK4D4","id":101445,"avatar_url":"https://avatars.githubusercontent.com/u/101445?v=3","gravatar_id":"","url":"https://api.github.com/users/LK4D4","html_url":"https://github.com/LK4D4","followers_url":"https://api.github.com/users/LK4D4/followers","following_url":"https://api.github.com/users/LK4D4/following{/other_user}","gists_url":"https://api.github.com/users/LK4D4/gists{/gist_id}","starred_url":"https://api.github.com/users/LK4D4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LK4D4/subscriptions","organizations_url":"https://api.github.com/users/LK4D4/orgs","repos_url":"https://api.github.com/users/LK4D4/repos","events_url":"https://api.github.com/users/LK4D4/events{/privacy}","received_events_url":"https://api.github.com/users/LK4D4/received_events","type":"User","site_admin":false},"created_at":"2015-03-11T14:45:47Z","updated_at":"2015-03-11T14:45:47Z","body":"@estesp Is it possible to write test for this. It is pretty severe bug which wasn't caught by tests :/"}}