{"action":"opened","number":13,"pull_request":{"url":"https://api.github.com/repos/crowbar/crowbar-ha/pulls/13","id":44250408,"html_url":"https://github.com/crowbar/crowbar-ha/pull/13","diff_url":"https://github.com/crowbar/crowbar-ha/pull/13.diff","patch_url":"https://github.com/crowbar/crowbar-ha/pull/13.patch","issue_url":"https://api.github.com/repos/crowbar/crowbar-ha/issues/13","number":13,"state":"open","locked":false,"title":"[UNTESTED] immediately abort chef-client if maintenance mode is set","user":{"login":"aspiers","id":100738,"avatar_url":"https://avatars.githubusercontent.com/u/100738?v=3","gravatar_id":"","url":"https://api.github.com/users/aspiers","html_url":"https://github.com/aspiers","followers_url":"https://api.github.com/users/aspiers/followers","following_url":"https://api.github.com/users/aspiers/following{/other_user}","gists_url":"https://api.github.com/users/aspiers/gists{/gist_id}","starred_url":"https://api.github.com/users/aspiers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspiers/subscriptions","organizations_url":"https://api.github.com/users/aspiers/orgs","repos_url":"https://api.github.com/users/aspiers/repos","events_url":"https://api.github.com/users/aspiers/events{/privacy}","received_events_url":"https://api.github.com/users/aspiers/received_events","type":"User","site_admin":false},"body":"The reasoning is explained in the comments.  I'm not sure why I ever thought it was a good idea to allow a chef-client run to proceed if maintenance mode is set.  It's not even as if that approach could ever restore an ill node to full health, because we were deliberately checking whether the maintenance mode was set prior to the chef-client run, and if so, leaving it set.  This way, if a node is left in maintenance mode, it will be discovered sooner, resulting in the cloud operator being alerted to a degraded cluster sooner.","created_at":"2015-09-04T18:55:59Z","updated_at":"2015-09-04T18:55:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/crowbar/crowbar-ha/pulls/13/commits","review_comments_url":"https://api.github.com/repos/crowbar/crowbar-ha/pulls/13/comments","review_comment_url":"https://api.github.com/repos/crowbar/crowbar-ha/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crowbar/crowbar-ha/issues/13/comments","statuses_url":"https://api.github.com/repos/crowbar/crowbar-ha/statuses/2cc0c353ce5e771763546b207092b754b1d85ca5","head":{"label":"aspiers:abort-on-maintenance-mode","ref":"abort-on-maintenance-mode","sha":"2cc0c353ce5e771763546b207092b754b1d85ca5","user":{"login":"aspiers","id":100738,"avatar_url":"https://avatars.githubusercontent.com/u/100738?v=3","gravatar_id":"","url":"https://api.github.com/users/aspiers","html_url":"https://github.com/aspiers","followers_url":"https://api.github.com/users/aspiers/followers","following_url":"https://api.github.com/users/aspiers/following{/other_user}","gists_url":"https://api.github.com/users/aspiers/gists{/gist_id}","starred_url":"https://api.github.com/users/aspiers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspiers/subscriptions","organizations_url":"https://api.github.com/users/aspiers/orgs","repos_url":"https://api.github.com/users/aspiers/repos","events_url":"https://api.github.com/users/aspiers/events{/privacy}","received_events_url":"https://api.github.com/users/aspiers/received_events","type":"User","site_admin":false},"repo":{"id":41430282,"name":"crowbar-ha","full_name":"aspiers/crowbar-ha","owner":{"login":"aspiers","id":100738,"avatar_url":"https://avatars.githubusercontent.com/u/100738?v=3","gravatar_id":"","url":"https://api.github.com/users/aspiers","html_url":"https://github.com/aspiers","followers_url":"https://api.github.com/users/aspiers/followers","following_url":"https://api.github.com/users/aspiers/following{/other_user}","gists_url":"https://api.github.com/users/aspiers/gists{/gist_id}","starred_url":"https://api.github.com/users/aspiers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspiers/subscriptions","organizations_url":"https://api.github.com/users/aspiers/orgs","repos_url":"https://api.github.com/users/aspiers/repos","events_url":"https://api.github.com/users/aspiers/events{/privacy}","received_events_url":"https://api.github.com/users/aspiers/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aspiers/crowbar-ha","description":"HA deployment for Crowbar","fork":true,"url":"https://api.github.com/repos/aspiers/crowbar-ha","forks_url":"https://api.github.com/repos/aspiers/crowbar-ha/forks","keys_url":"https://api.github.com/repos/aspiers/crowbar-ha/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspiers/crowbar-ha/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspiers/crowbar-ha/teams","hooks_url":"https://api.github.com/repos/aspiers/crowbar-ha/hooks","issue_events_url":"https://api.github.com/repos/aspiers/crowbar-ha/issues/events{/number}","events_url":"https://api.github.com/repos/aspiers/crowbar-ha/events","assignees_url":"https://api.github.com/repos/aspiers/crowbar-ha/assignees{/user}","branches_url":"https://api.github.com/repos/aspiers/crowbar-ha/branches{/branch}","tags_url":"https://api.github.com/repos/aspiers/crowbar-ha/tags","blobs_url":"https://api.github.com/repos/aspiers/crowbar-ha/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspiers/crowbar-ha/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspiers/crowbar-ha/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspiers/crowbar-ha/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspiers/crowbar-ha/statuses/{sha}","languages_url":"https://api.github.com/repos/aspiers/crowbar-ha/languages","stargazers_url":"https://api.github.com/repos/aspiers/crowbar-ha/stargazers","contributors_url":"https://api.github.com/repos/aspiers/crowbar-ha/contributors","subscribers_url":"https://api.github.com/repos/aspiers/crowbar-ha/subscribers","subscription_url":"https://api.github.com/repos/aspiers/crowbar-ha/subscription","commits_url":"https://api.github.com/repos/aspiers/crowbar-ha/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspiers/crowbar-ha/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspiers/crowbar-ha/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspiers/crowbar-ha/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspiers/crowbar-ha/contents/{+path}","compare_url":"https://api.github.com/repos/aspiers/crowbar-ha/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspiers/crowbar-ha/merges","archive_url":"https://api.github.com/repos/aspiers/crowbar-ha/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspiers/crowbar-ha/downloads","issues_url":"https://api.github.com/repos/aspiers/crowbar-ha/issues{/number}","pulls_url":"https://api.github.com/repos/aspiers/crowbar-ha/pulls{/number}","milestones_url":"https://api.github.com/repos/aspiers/crowbar-ha/milestones{/number}","notifications_url":"https://api.github.com/repos/aspiers/crowbar-ha/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspiers/crowbar-ha/labels{/name}","releases_url":"https://api.github.com/repos/aspiers/crowbar-ha/releases{/id}","created_at":"2015-08-26T14:26:14Z","updated_at":"2015-08-26T14:26:15Z","pushed_at":"2015-09-04T18:55:31Z","git_url":"git://github.com/aspiers/crowbar-ha.git","ssh_url":"git@github.com:aspiers/crowbar-ha.git","clone_url":"https://github.com/aspiers/crowbar-ha.git","svn_url":"https://github.com/aspiers/crowbar-ha","homepage":"","size":1016,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"crowbar:master","ref":"master","sha":"ab982ad707e2a046337d477942e4d857344bc3cf","user":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars.githubusercontent.com/u/2910205?v=3","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"repo":{"id":39006836,"name":"crowbar-ha","full_name":"crowbar/crowbar-ha","owner":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars.githubusercontent.com/u/2910205?v=3","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crowbar/crowbar-ha","description":"HA deployment for Crowbar","fork":false,"url":"https://api.github.com/repos/crowbar/crowbar-ha","forks_url":"https://api.github.com/repos/crowbar/crowbar-ha/forks","keys_url":"https://api.github.com/repos/crowbar/crowbar-ha/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crowbar/crowbar-ha/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crowbar/crowbar-ha/teams","hooks_url":"https://api.github.com/repos/crowbar/crowbar-ha/hooks","issue_events_url":"https://api.github.com/repos/crowbar/crowbar-ha/issues/events{/number}","events_url":"https://api.github.com/repos/crowbar/crowbar-ha/events","assignees_url":"https://api.github.com/repos/crowbar/crowbar-ha/assignees{/user}","branches_url":"https://api.github.com/repos/crowbar/crowbar-ha/branches{/branch}","tags_url":"https://api.github.com/repos/crowbar/crowbar-ha/tags","blobs_url":"https://api.github.com/repos/crowbar/crowbar-ha/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crowbar/crowbar-ha/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crowbar/crowbar-ha/git/refs{/sha}","trees_url":"https://api.github.com/repos/crowbar/crowbar-ha/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crowbar/crowbar-ha/statuses/{sha}","languages_url":"https://api.github.com/repos/crowbar/crowbar-ha/languages","stargazers_url":"https://api.github.com/repos/crowbar/crowbar-ha/stargazers","contributors_url":"https://api.github.com/repos/crowbar/crowbar-ha/contributors","subscribers_url":"https://api.github.com/repos/crowbar/crowbar-ha/subscribers","subscription_url":"https://api.github.com/repos/crowbar/crowbar-ha/subscription","commits_url":"https://api.github.com/repos/crowbar/crowbar-ha/commits{/sha}","git_commits_url":"https://api.github.com/repos/crowbar/crowbar-ha/git/commits{/sha}","comments_url":"https://api.github.com/repos/crowbar/crowbar-ha/comments{/number}","issue_comment_url":"https://api.github.com/repos/crowbar/crowbar-ha/issues/comments{/number}","contents_url":"https://api.github.com/repos/crowbar/crowbar-ha/contents/{+path}","compare_url":"https://api.github.com/repos/crowbar/crowbar-ha/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crowbar/crowbar-ha/merges","archive_url":"https://api.github.com/repos/crowbar/crowbar-ha/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crowbar/crowbar-ha/downloads","issues_url":"https://api.github.com/repos/crowbar/crowbar-ha/issues{/number}","pulls_url":"https://api.github.com/repos/crowbar/crowbar-ha/pulls{/number}","milestones_url":"https://api.github.com/repos/crowbar/crowbar-ha/milestones{/number}","notifications_url":"https://api.github.com/repos/crowbar/crowbar-ha/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crowbar/crowbar-ha/labels{/name}","releases_url":"https://api.github.com/repos/crowbar/crowbar-ha/releases{/id}","created_at":"2015-07-13T10:53:43Z","updated_at":"2015-08-26T19:58:29Z","pushed_at":"2015-09-04T18:55:59Z","git_url":"git://github.com/crowbar/crowbar-ha.git","ssh_url":"git@github.com:crowbar/crowbar-ha.git","clone_url":"https://github.com/crowbar/crowbar-ha.git","svn_url":"https://github.com/crowbar/crowbar-ha","homepage":"","size":1332,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":6,"forks":10,"open_issues":6,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crowbar/crowbar-ha/pulls/13"},"html":{"href":"https://github.com/crowbar/crowbar-ha/pull/13"},"issue":{"href":"https://api.github.com/repos/crowbar/crowbar-ha/issues/13"},"comments":{"href":"https://api.github.com/repos/crowbar/crowbar-ha/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/crowbar/crowbar-ha/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/crowbar/crowbar-ha/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crowbar/crowbar-ha/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/crowbar/crowbar-ha/statuses/2cc0c353ce5e771763546b207092b754b1d85ca5"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":24,"deletions":31,"changed_files":2}}