{"action":"created","issue":{"url":"https://api.github.com/repos/zslayton/lifeguard/issues/4","labels_url":"https://api.github.com/repos/zslayton/lifeguard/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/zslayton/lifeguard/issues/4/comments","events_url":"https://api.github.com/repos/zslayton/lifeguard/issues/4/events","html_url":"https://github.com/zslayton/lifeguard/pull/4","id":81890608,"number":4,"title":"Allow scoped allocation","user":{"login":"Marwes","id":957312,"avatar_url":"https://avatars.githubusercontent.com/u/957312?v=3","gravatar_id":"","url":"https://api.github.com/users/Marwes","html_url":"https://github.com/Marwes","followers_url":"https://api.github.com/users/Marwes/followers","following_url":"https://api.github.com/users/Marwes/following{/other_user}","gists_url":"https://api.github.com/users/Marwes/gists{/gist_id}","starred_url":"https://api.github.com/users/Marwes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Marwes/subscriptions","organizations_url":"https://api.github.com/users/Marwes/orgs","repos_url":"https://api.github.com/users/Marwes/repos","events_url":"https://api.github.com/users/Marwes/events{/privacy}","received_events_url":"https://api.github.com/users/Marwes/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2015-05-28T11:38:58Z","updated_at":"2015-05-29T15:58:01Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/zslayton/lifeguard/pulls/4","html_url":"https://github.com/zslayton/lifeguard/pull/4","diff_url":"https://github.com/zslayton/lifeguard/pull/4.diff","patch_url":"https://github.com/zslayton/lifeguard/pull/4.patch"},"body":"I gave implementing scoped allocation a shot since I had an idea about how allow Recycled objects with both & and Rc without duplicating any code. I think it turned other rather good but I wanted to get some feedback before proceeding. One nice thing of this implementation is how the Rc based pool can allocate both Recycled and ScopedRecycled.\r\n\r\nThe code will still need some cleanup, some tests and benchmarks added, and I think it may be a good idea to make ScopedPool etc newtypes as well to avoid their internal implementation leaking out."},"comment":{"url":"https://api.github.com/repos/zslayton/lifeguard/issues/comments/106855972","html_url":"https://github.com/zslayton/lifeguard/pull/4#issuecomment-106855972","issue_url":"https://api.github.com/repos/zslayton/lifeguard/issues/4","id":106855972,"user":{"login":"zslayton","id":611616,"avatar_url":"https://avatars.githubusercontent.com/u/611616?v=3","gravatar_id":"","url":"https://api.github.com/users/zslayton","html_url":"https://github.com/zslayton","followers_url":"https://api.github.com/users/zslayton/followers","following_url":"https://api.github.com/users/zslayton/following{/other_user}","gists_url":"https://api.github.com/users/zslayton/gists{/gist_id}","starred_url":"https://api.github.com/users/zslayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zslayton/subscriptions","organizations_url":"https://api.github.com/users/zslayton/orgs","repos_url":"https://api.github.com/users/zslayton/repos","events_url":"https://api.github.com/users/zslayton/events{/privacy}","received_events_url":"https://api.github.com/users/zslayton/received_events","type":"User","site_admin":false},"created_at":"2015-05-29T15:58:01Z","updated_at":"2015-05-29T15:58:01Z","body":"Ah, thanks for running the benchmark. It does seem to be a pretty small difference. I'd say let's promote `RcPool` to being the only kind of `Pool` for now. It may be possible to store a reference to the un-`Rc`'ed `RefCell` using `unsafe` if we need to get that extra speed boost. I'll have to do some research."}}