{"action":"created","issue":{"url":"https://api.github.com/repos/Mashape/kong/issues/630","labels_url":"https://api.github.com/repos/Mashape/kong/issues/630/labels{/name}","comments_url":"https://api.github.com/repos/Mashape/kong/issues/630/comments","events_url":"https://api.github.com/repos/Mashape/kong/issues/630/events","html_url":"https://github.com/Mashape/kong/issues/630","id":111557580,"number":630,"title":"Immutable properties in plugins","user":{"login":"thefosk","id":964813,"avatar_url":"https://avatars.githubusercontent.com/u/964813?v=3","gravatar_id":"","url":"https://api.github.com/users/thefosk","html_url":"https://github.com/thefosk","followers_url":"https://api.github.com/users/thefosk/followers","following_url":"https://api.github.com/users/thefosk/following{/other_user}","gists_url":"https://api.github.com/users/thefosk/gists{/gist_id}","starred_url":"https://api.github.com/users/thefosk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thefosk/subscriptions","organizations_url":"https://api.github.com/users/thefosk/orgs","repos_url":"https://api.github.com/users/thefosk/repos","events_url":"https://api.github.com/users/thefosk/events{/privacy}","received_events_url":"https://api.github.com/users/thefosk/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Mashape/kong/labels/area/DAO","name":"area/DAO","color":"d4c5f9"},{"url":"https://api.github.com/repos/Mashape/kong/labels/area/plugins","name":"area/plugins","color":"d4c5f9"},{"url":"https://api.github.com/repos/Mashape/kong/labels/task/enhancement","name":"task/enhancement","color":"bfdadc"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":14,"created_at":"2015-10-15T07:07:18Z","updated_at":"2015-10-28T21:11:53Z","closed_at":null,"body":"We need to review all the plugins, their schemas and DAOs, because certain fields should be `immutable`.\r\n\r\nLast time when we did this we encountered many problems."},"comment":{"url":"https://api.github.com/repos/Mashape/kong/issues/comments/151991388","html_url":"https://github.com/Mashape/kong/issues/630#issuecomment-151991388","issue_url":"https://api.github.com/repos/Mashape/kong/issues/630","id":151991388,"user":{"login":"thefosk","id":964813,"avatar_url":"https://avatars.githubusercontent.com/u/964813?v=3","gravatar_id":"","url":"https://api.github.com/users/thefosk","html_url":"https://github.com/thefosk","followers_url":"https://api.github.com/users/thefosk/followers","following_url":"https://api.github.com/users/thefosk/following{/other_user}","gists_url":"https://api.github.com/users/thefosk/gists{/gist_id}","starred_url":"https://api.github.com/users/thefosk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thefosk/subscriptions","organizations_url":"https://api.github.com/users/thefosk/orgs","repos_url":"https://api.github.com/users/thefosk/repos","events_url":"https://api.github.com/users/thefosk/events{/privacy}","received_events_url":"https://api.github.com/users/thefosk/received_events","type":"User","site_admin":false},"created_at":"2015-10-28T21:11:53Z","updated_at":"2015-10-28T21:11:53Z","body":"> They are bound to the consumer_id correct?\r\n\r\nBound to the `credential_id`, since a token is being generated from a specific set of `client_id` and `client_secret`.\r\n\r\n> If your major concern is that they update one but not the other, that's their concern not yours.\r\n\r\nWell I think we should enforce best practices that avoid errors.\r\n\r\n> That's how it should be, you don't want to delete them every time you update your client_id and client_secret these are two separate actions.\r\n\r\nUpdating the `client_id` and `client_secret` means changing the credential that generated that token in the first place. If a user feels like updating the credential because it was stolen, we want him to delete the credential and all the associated tokens. Not doing so creates a security issue.\r\n\r\n> Why? There is no reason for this\r\nFor all the reasons above.\r\n"}}