{"action":"opened","number":1185,"pull_request":{"url":"https://api.github.com/repos/processing/p5.js/pulls/1185","id":54739333,"html_url":"https://github.com/processing/p5.js/pull/1185","diff_url":"https://github.com/processing/p5.js/pull/1185.diff","patch_url":"https://github.com/processing/p5.js/pull/1185.patch","issue_url":"https://api.github.com/repos/processing/p5.js/issues/1185","number":1185,"state":"open","locked":false,"title":"Issue #906","user":{"login":"parsoyaarihant","id":15258498,"avatar_url":"https://avatars.githubusercontent.com/u/15258498?v=3","gravatar_id":"","url":"https://api.github.com/users/parsoyaarihant","html_url":"https://github.com/parsoyaarihant","followers_url":"https://api.github.com/users/parsoyaarihant/followers","following_url":"https://api.github.com/users/parsoyaarihant/following{/other_user}","gists_url":"https://api.github.com/users/parsoyaarihant/gists{/gist_id}","starred_url":"https://api.github.com/users/parsoyaarihant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parsoyaarihant/subscriptions","organizations_url":"https://api.github.com/users/parsoyaarihant/orgs","repos_url":"https://api.github.com/users/parsoyaarihant/repos","events_url":"https://api.github.com/users/parsoyaarihant/events{/privacy}","received_events_url":"https://api.github.com/users/parsoyaarihant/received_events","type":"User","site_admin":false},"body":"The current code is written such that if the variable isCurve is true, the endShape function (in Renderer2D.js) will not distinguish between the vertex and curveVertex since both the coordinates of vertex and curveVertex are stored in the same array i.e. vertices. So, I created another array(curveVertices) which stores the index of curveVertices in 'vertices' array and changed the code in Renderer2D.js such that it accounts for all test cases. ","created_at":"2015-12-29T16:33:40Z","updated_at":"2015-12-29T16:33:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/processing/p5.js/pulls/1185/commits","review_comments_url":"https://api.github.com/repos/processing/p5.js/pulls/1185/comments","review_comment_url":"https://api.github.com/repos/processing/p5.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/processing/p5.js/issues/1185/comments","statuses_url":"https://api.github.com/repos/processing/p5.js/statuses/baea77220c0c2e91ff35a8f2b91ea54d39a688ef","head":{"label":"parsoyaarihant:issue-#906","ref":"issue-#906","sha":"baea77220c0c2e91ff35a8f2b91ea54d39a688ef","user":{"login":"parsoyaarihant","id":15258498,"avatar_url":"https://avatars.githubusercontent.com/u/15258498?v=3","gravatar_id":"","url":"https://api.github.com/users/parsoyaarihant","html_url":"https://github.com/parsoyaarihant","followers_url":"https://api.github.com/users/parsoyaarihant/followers","following_url":"https://api.github.com/users/parsoyaarihant/following{/other_user}","gists_url":"https://api.github.com/users/parsoyaarihant/gists{/gist_id}","starred_url":"https://api.github.com/users/parsoyaarihant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parsoyaarihant/subscriptions","organizations_url":"https://api.github.com/users/parsoyaarihant/orgs","repos_url":"https://api.github.com/users/parsoyaarihant/repos","events_url":"https://api.github.com/users/parsoyaarihant/events{/privacy}","received_events_url":"https://api.github.com/users/parsoyaarihant/received_events","type":"User","site_admin":false},"repo":{"id":48487452,"name":"p5.js","full_name":"parsoyaarihant/p5.js","owner":{"login":"parsoyaarihant","id":15258498,"avatar_url":"https://avatars.githubusercontent.com/u/15258498?v=3","gravatar_id":"","url":"https://api.github.com/users/parsoyaarihant","html_url":"https://github.com/parsoyaarihant","followers_url":"https://api.github.com/users/parsoyaarihant/followers","following_url":"https://api.github.com/users/parsoyaarihant/following{/other_user}","gists_url":"https://api.github.com/users/parsoyaarihant/gists{/gist_id}","starred_url":"https://api.github.com/users/parsoyaarihant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parsoyaarihant/subscriptions","organizations_url":"https://api.github.com/users/parsoyaarihant/orgs","repos_url":"https://api.github.com/users/parsoyaarihant/repos","events_url":"https://api.github.com/users/parsoyaarihant/events{/privacy}","received_events_url":"https://api.github.com/users/parsoyaarihant/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/parsoyaarihant/p5.js","description":"p5.js is a JS client-side library for creating graphic and interactive experiences, based on the core principles of Processing. http://twitter.com/p5xjs —","fork":true,"url":"https://api.github.com/repos/parsoyaarihant/p5.js","forks_url":"https://api.github.com/repos/parsoyaarihant/p5.js/forks","keys_url":"https://api.github.com/repos/parsoyaarihant/p5.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/parsoyaarihant/p5.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/parsoyaarihant/p5.js/teams","hooks_url":"https://api.github.com/repos/parsoyaarihant/p5.js/hooks","issue_events_url":"https://api.github.com/repos/parsoyaarihant/p5.js/issues/events{/number}","events_url":"https://api.github.com/repos/parsoyaarihant/p5.js/events","assignees_url":"https://api.github.com/repos/parsoyaarihant/p5.js/assignees{/user}","branches_url":"https://api.github.com/repos/parsoyaarihant/p5.js/branches{/branch}","tags_url":"https://api.github.com/repos/parsoyaarihant/p5.js/tags","blobs_url":"https://api.github.com/repos/parsoyaarihant/p5.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/parsoyaarihant/p5.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/parsoyaarihant/p5.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/parsoyaarihant/p5.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/parsoyaarihant/p5.js/statuses/{sha}","languages_url":"https://api.github.com/repos/parsoyaarihant/p5.js/languages","stargazers_url":"https://api.github.com/repos/parsoyaarihant/p5.js/stargazers","contributors_url":"https://api.github.com/repos/parsoyaarihant/p5.js/contributors","subscribers_url":"https://api.github.com/repos/parsoyaarihant/p5.js/subscribers","subscription_url":"https://api.github.com/repos/parsoyaarihant/p5.js/subscription","commits_url":"https://api.github.com/repos/parsoyaarihant/p5.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/parsoyaarihant/p5.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/parsoyaarihant/p5.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/parsoyaarihant/p5.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/parsoyaarihant/p5.js/contents/{+path}","compare_url":"https://api.github.com/repos/parsoyaarihant/p5.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/parsoyaarihant/p5.js/merges","archive_url":"https://api.github.com/repos/parsoyaarihant/p5.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/parsoyaarihant/p5.js/downloads","issues_url":"https://api.github.com/repos/parsoyaarihant/p5.js/issues{/number}","pulls_url":"https://api.github.com/repos/parsoyaarihant/p5.js/pulls{/number}","milestones_url":"https://api.github.com/repos/parsoyaarihant/p5.js/milestones{/number}","notifications_url":"https://api.github.com/repos/parsoyaarihant/p5.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/parsoyaarihant/p5.js/labels{/name}","releases_url":"https://api.github.com/repos/parsoyaarihant/p5.js/releases{/id}","created_at":"2015-12-23T11:37:36Z","updated_at":"2015-12-23T11:37:37Z","pushed_at":"2015-12-29T16:17:08Z","git_url":"git://github.com/parsoyaarihant/p5.js.git","ssh_url":"git@github.com:parsoyaarihant/p5.js.git","clone_url":"https://github.com/parsoyaarihant/p5.js.git","svn_url":"https://github.com/parsoyaarihant/p5.js","homepage":"http://p5js.org/","size":59861,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"processing:master","ref":"master","sha":"a385d1ca7a1232b0e4d20066a395706ef88d0e7c","user":{"login":"processing","id":1617169,"avatar_url":"https://avatars.githubusercontent.com/u/1617169?v=3","gravatar_id":"","url":"https://api.github.com/users/processing","html_url":"https://github.com/processing","followers_url":"https://api.github.com/users/processing/followers","following_url":"https://api.github.com/users/processing/following{/other_user}","gists_url":"https://api.github.com/users/processing/gists{/gist_id}","starred_url":"https://api.github.com/users/processing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/processing/subscriptions","organizations_url":"https://api.github.com/users/processing/orgs","repos_url":"https://api.github.com/users/processing/repos","events_url":"https://api.github.com/users/processing/events{/privacy}","received_events_url":"https://api.github.com/users/processing/received_events","type":"Organization","site_admin":false},"repo":{"id":8424040,"name":"p5.js","full_name":"processing/p5.js","owner":{"login":"processing","id":1617169,"avatar_url":"https://avatars.githubusercontent.com/u/1617169?v=3","gravatar_id":"","url":"https://api.github.com/users/processing","html_url":"https://github.com/processing","followers_url":"https://api.github.com/users/processing/followers","following_url":"https://api.github.com/users/processing/following{/other_user}","gists_url":"https://api.github.com/users/processing/gists{/gist_id}","starred_url":"https://api.github.com/users/processing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/processing/subscriptions","organizations_url":"https://api.github.com/users/processing/orgs","repos_url":"https://api.github.com/users/processing/repos","events_url":"https://api.github.com/users/processing/events{/privacy}","received_events_url":"https://api.github.com/users/processing/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/processing/p5.js","description":"p5.js is a JS client-side library for creating graphic and interactive experiences, based on the core principles of Processing. http://twitter.com/p5xjs —","fork":false,"url":"https://api.github.com/repos/processing/p5.js","forks_url":"https://api.github.com/repos/processing/p5.js/forks","keys_url":"https://api.github.com/repos/processing/p5.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/processing/p5.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/processing/p5.js/teams","hooks_url":"https://api.github.com/repos/processing/p5.js/hooks","issue_events_url":"https://api.github.com/repos/processing/p5.js/issues/events{/number}","events_url":"https://api.github.com/repos/processing/p5.js/events","assignees_url":"https://api.github.com/repos/processing/p5.js/assignees{/user}","branches_url":"https://api.github.com/repos/processing/p5.js/branches{/branch}","tags_url":"https://api.github.com/repos/processing/p5.js/tags","blobs_url":"https://api.github.com/repos/processing/p5.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/processing/p5.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/processing/p5.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/processing/p5.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/processing/p5.js/statuses/{sha}","languages_url":"https://api.github.com/repos/processing/p5.js/languages","stargazers_url":"https://api.github.com/repos/processing/p5.js/stargazers","contributors_url":"https://api.github.com/repos/processing/p5.js/contributors","subscribers_url":"https://api.github.com/repos/processing/p5.js/subscribers","subscription_url":"https://api.github.com/repos/processing/p5.js/subscription","commits_url":"https://api.github.com/repos/processing/p5.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/processing/p5.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/processing/p5.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/processing/p5.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/processing/p5.js/contents/{+path}","compare_url":"https://api.github.com/repos/processing/p5.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/processing/p5.js/merges","archive_url":"https://api.github.com/repos/processing/p5.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/processing/p5.js/downloads","issues_url":"https://api.github.com/repos/processing/p5.js/issues{/number}","pulls_url":"https://api.github.com/repos/processing/p5.js/pulls{/number}","milestones_url":"https://api.github.com/repos/processing/p5.js/milestones{/number}","notifications_url":"https://api.github.com/repos/processing/p5.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/processing/p5.js/labels{/name}","releases_url":"https://api.github.com/repos/processing/p5.js/releases{/id}","created_at":"2013-02-26T03:14:47Z","updated_at":"2015-12-29T07:44:29Z","pushed_at":"2015-12-16T13:29:59Z","git_url":"git://github.com/processing/p5.js.git","ssh_url":"git@github.com:processing/p5.js.git","clone_url":"https://github.com/processing/p5.js.git","svn_url":"https://github.com/processing/p5.js","homepage":"http://p5js.org/","size":62972,"stargazers_count":3297,"watchers_count":3297,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":431,"mirror_url":null,"open_issues_count":66,"forks":431,"open_issues":66,"watchers":3297,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/processing/p5.js/pulls/1185"},"html":{"href":"https://github.com/processing/p5.js/pull/1185"},"issue":{"href":"https://api.github.com/repos/processing/p5.js/issues/1185"},"comments":{"href":"https://api.github.com/repos/processing/p5.js/issues/1185/comments"},"review_comments":{"href":"https://api.github.com/repos/processing/p5.js/pulls/1185/comments"},"review_comment":{"href":"https://api.github.com/repos/processing/p5.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/processing/p5.js/pulls/1185/commits"},"statuses":{"href":"https://api.github.com/repos/processing/p5.js/statuses/baea77220c0c2e91ff35a8f2b91ea54d39a688ef"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":3,"additions":85,"deletions":6,"changed_files":2}}