{"action":"created","comment":{"url":"https://api.github.com/repos/cf-lms/lms/pulls/comments/47966451","id":47966451,"diff_hunk":"@@ -4,15 +4,38 @@ $color-scheme1: #18ce76; // light green\n $color-scheme2: #2185c5; // sky blue\n $color-scheme3: #3e454c; // dark grey\n $color-scheme4: #767d84; // light grey\n+$color-scheme5: #ffffff; // white - page background\n+$color-scheme6: #F0F00E; // yellow - shit button\n+$color-scheme7: #F00E0E; // red - fuck button\n \n //Typography\n \n-#Fira Mono\n-https://www.google.com/fonts/specimen/Fira+Mono\n+//Fira Mono\n+$primary-mono: 'Fira', mono;\n \n-#Fira Sans\n-https://www.google.com/fonts/specimen/Fira+Sans\n+//Fira Sans\n+$primary-sans-serif: 'Fira', sans-serif;\n \n-#Proxima Nova Soft\n-<script src=\"https://use.typekit.net/epm4awk.js\"></script>\n-<script>try{Typekit.load({ async: true });}catch(e){}</script>\n\\ No newline at end of file\n+//Proxima Nova Soft\n+$heading-san-serif: 'Proxima', sans-serif;\n+\n+//Heading\n+$heading-bg: $color-scheme1;\n+\n+//Container\n+$container: {","path":"app/sass/_config.scss","position":31,"original_position":31,"commit_id":"040acdbdae7e007f94d3a70a5c9d97a40bc709fc","original_commit_id":"040acdbdae7e007f94d3a70a5c9d97a40bc709fc","user":{"login":"dlesaca","id":5091822,"avatar_url":"https://avatars.githubusercontent.com/u/5091822?v=3","gravatar_id":"","url":"https://api.github.com/users/dlesaca","html_url":"https://github.com/dlesaca","followers_url":"https://api.github.com/users/dlesaca/followers","following_url":"https://api.github.com/users/dlesaca/following{/other_user}","gists_url":"https://api.github.com/users/dlesaca/gists{/gist_id}","starred_url":"https://api.github.com/users/dlesaca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlesaca/subscriptions","organizations_url":"https://api.github.com/users/dlesaca/orgs","repos_url":"https://api.github.com/users/dlesaca/repos","events_url":"https://api.github.com/users/dlesaca/events{/privacy}","received_events_url":"https://api.github.com/users/dlesaca/received_events","type":"User","site_admin":false},"body":"I wouldn't consider lines 26 - 41 config styles. Although they are variables which is what should comprise a config file. Two problems here 1) the formatting is incorrect.\r\n\r\n### improper (broken?)\r\n```\r\n$button-ok: {\r\n  @include blah;\r\n}\r\n```\r\n\r\nvs.\r\n\r\n### Proper\r\n```\r\n$button-ok: @include blah;\r\n```\r\n\r\n2) There should be no actual element declarations in the config file.","created_at":"2015-12-17T21:52:06Z","updated_at":"2015-12-17T21:52:06Z","html_url":"https://github.com/cf-lms/lms/pull/20#discussion_r47966451","pull_request_url":"https://api.github.com/repos/cf-lms/lms/pulls/20","_links":{"self":{"href":"https://api.github.com/repos/cf-lms/lms/pulls/comments/47966451"},"html":{"href":"https://github.com/cf-lms/lms/pull/20#discussion_r47966451"},"pull_request":{"href":"https://api.github.com/repos/cf-lms/lms/pulls/20"}}},"pull_request":{"url":"https://api.github.com/repos/cf-lms/lms/pulls/20","id":54033067,"html_url":"https://github.com/cf-lms/lms/pull/20","diff_url":"https://github.com/cf-lms/lms/pull/20.diff","patch_url":"https://github.com/cf-lms/lms/pull/20.patch","issue_url":"https://api.github.com/repos/cf-lms/lms/issues/20","number":20,"state":"closed","locked":false,"title":"Day2 pm","user":{"login":"isabellaorgan","id":10999935,"avatar_url":"https://avatars.githubusercontent.com/u/10999935?v=3","gravatar_id":"","url":"https://api.github.com/users/isabellaorgan","html_url":"https://github.com/isabellaorgan","followers_url":"https://api.github.com/users/isabellaorgan/followers","following_url":"https://api.github.com/users/isabellaorgan/following{/other_user}","gists_url":"https://api.github.com/users/isabellaorgan/gists{/gist_id}","starred_url":"https://api.github.com/users/isabellaorgan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isabellaorgan/subscriptions","organizations_url":"https://api.github.com/users/isabellaorgan/orgs","repos_url":"https://api.github.com/users/isabellaorgan/repos","events_url":"https://api.github.com/users/isabellaorgan/events{/privacy}","received_events_url":"https://api.github.com/users/isabellaorgan/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-12-17T21:19:13Z","updated_at":"2015-12-17T21:52:06Z","closed_at":"2015-12-17T21:20:56Z","merged_at":"2015-12-17T21:20:56Z","merge_commit_sha":"c3f45ef21c84ee5a318b4315a3ddb1e598272502","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cf-lms/lms/pulls/20/commits","review_comments_url":"https://api.github.com/repos/cf-lms/lms/pulls/20/comments","review_comment_url":"https://api.github.com/repos/cf-lms/lms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cf-lms/lms/issues/20/comments","statuses_url":"https://api.github.com/repos/cf-lms/lms/statuses/040acdbdae7e007f94d3a70a5c9d97a40bc709fc","head":{"label":"isabellaorgan:day2_pm","ref":"day2_pm","sha":"040acdbdae7e007f94d3a70a5c9d97a40bc709fc","user":{"login":"isabellaorgan","id":10999935,"avatar_url":"https://avatars.githubusercontent.com/u/10999935?v=3","gravatar_id":"","url":"https://api.github.com/users/isabellaorgan","html_url":"https://github.com/isabellaorgan","followers_url":"https://api.github.com/users/isabellaorgan/followers","following_url":"https://api.github.com/users/isabellaorgan/following{/other_user}","gists_url":"https://api.github.com/users/isabellaorgan/gists{/gist_id}","starred_url":"https://api.github.com/users/isabellaorgan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isabellaorgan/subscriptions","organizations_url":"https://api.github.com/users/isabellaorgan/orgs","repos_url":"https://api.github.com/users/isabellaorgan/repos","events_url":"https://api.github.com/users/isabellaorgan/events{/privacy}","received_events_url":"https://api.github.com/users/isabellaorgan/received_events","type":"User","site_admin":false},"repo":{"id":48062234,"name":"lms","full_name":"isabellaorgan/lms","owner":{"login":"isabellaorgan","id":10999935,"avatar_url":"https://avatars.githubusercontent.com/u/10999935?v=3","gravatar_id":"","url":"https://api.github.com/users/isabellaorgan","html_url":"https://github.com/isabellaorgan","followers_url":"https://api.github.com/users/isabellaorgan/followers","following_url":"https://api.github.com/users/isabellaorgan/following{/other_user}","gists_url":"https://api.github.com/users/isabellaorgan/gists{/gist_id}","starred_url":"https://api.github.com/users/isabellaorgan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isabellaorgan/subscriptions","organizations_url":"https://api.github.com/users/isabellaorgan/orgs","repos_url":"https://api.github.com/users/isabellaorgan/repos","events_url":"https://api.github.com/users/isabellaorgan/events{/privacy}","received_events_url":"https://api.github.com/users/isabellaorgan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/isabellaorgan/lms","description":"","fork":true,"url":"https://api.github.com/repos/isabellaorgan/lms","forks_url":"https://api.github.com/repos/isabellaorgan/lms/forks","keys_url":"https://api.github.com/repos/isabellaorgan/lms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/isabellaorgan/lms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/isabellaorgan/lms/teams","hooks_url":"https://api.github.com/repos/isabellaorgan/lms/hooks","issue_events_url":"https://api.github.com/repos/isabellaorgan/lms/issues/events{/number}","events_url":"https://api.github.com/repos/isabellaorgan/lms/events","assignees_url":"https://api.github.com/repos/isabellaorgan/lms/assignees{/user}","branches_url":"https://api.github.com/repos/isabellaorgan/lms/branches{/branch}","tags_url":"https://api.github.com/repos/isabellaorgan/lms/tags","blobs_url":"https://api.github.com/repos/isabellaorgan/lms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/isabellaorgan/lms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/isabellaorgan/lms/git/refs{/sha}","trees_url":"https://api.github.com/repos/isabellaorgan/lms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/isabellaorgan/lms/statuses/{sha}","languages_url":"https://api.github.com/repos/isabellaorgan/lms/languages","stargazers_url":"https://api.github.com/repos/isabellaorgan/lms/stargazers","contributors_url":"https://api.github.com/repos/isabellaorgan/lms/contributors","subscribers_url":"https://api.github.com/repos/isabellaorgan/lms/subscribers","subscription_url":"https://api.github.com/repos/isabellaorgan/lms/subscription","commits_url":"https://api.github.com/repos/isabellaorgan/lms/commits{/sha}","git_commits_url":"https://api.github.com/repos/isabellaorgan/lms/git/commits{/sha}","comments_url":"https://api.github.com/repos/isabellaorgan/lms/comments{/number}","issue_comment_url":"https://api.github.com/repos/isabellaorgan/lms/issues/comments{/number}","contents_url":"https://api.github.com/repos/isabellaorgan/lms/contents/{+path}","compare_url":"https://api.github.com/repos/isabellaorgan/lms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/isabellaorgan/lms/merges","archive_url":"https://api.github.com/repos/isabellaorgan/lms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/isabellaorgan/lms/downloads","issues_url":"https://api.github.com/repos/isabellaorgan/lms/issues{/number}","pulls_url":"https://api.github.com/repos/isabellaorgan/lms/pulls{/number}","milestones_url":"https://api.github.com/repos/isabellaorgan/lms/milestones{/number}","notifications_url":"https://api.github.com/repos/isabellaorgan/lms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/isabellaorgan/lms/labels{/name}","releases_url":"https://api.github.com/repos/isabellaorgan/lms/releases{/id}","created_at":"2015-12-15T18:46:19Z","updated_at":"2015-12-17T20:14:49Z","pushed_at":"2015-12-17T21:39:36Z","git_url":"git://github.com/isabellaorgan/lms.git","ssh_url":"git@github.com:isabellaorgan/lms.git","clone_url":"https://github.com/isabellaorgan/lms.git","svn_url":"https://github.com/isabellaorgan/lms","homepage":null,"size":280,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cf-lms:master","ref":"master","sha":"31ca71dbe62e175bc064966b4dbcf689c03bb68a","user":{"login":"cf-lms","id":16294045,"avatar_url":"https://avatars.githubusercontent.com/u/16294045?v=3","gravatar_id":"","url":"https://api.github.com/users/cf-lms","html_url":"https://github.com/cf-lms","followers_url":"https://api.github.com/users/cf-lms/followers","following_url":"https://api.github.com/users/cf-lms/following{/other_user}","gists_url":"https://api.github.com/users/cf-lms/gists{/gist_id}","starred_url":"https://api.github.com/users/cf-lms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cf-lms/subscriptions","organizations_url":"https://api.github.com/users/cf-lms/orgs","repos_url":"https://api.github.com/users/cf-lms/repos","events_url":"https://api.github.com/users/cf-lms/events{/privacy}","received_events_url":"https://api.github.com/users/cf-lms/received_events","type":"Organization","site_admin":false},"repo":{"id":47993476,"name":"lms","full_name":"cf-lms/lms","owner":{"login":"cf-lms","id":16294045,"avatar_url":"https://avatars.githubusercontent.com/u/16294045?v=3","gravatar_id":"","url":"https://api.github.com/users/cf-lms","html_url":"https://github.com/cf-lms","followers_url":"https://api.github.com/users/cf-lms/followers","following_url":"https://api.github.com/users/cf-lms/following{/other_user}","gists_url":"https://api.github.com/users/cf-lms/gists{/gist_id}","starred_url":"https://api.github.com/users/cf-lms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cf-lms/subscriptions","organizations_url":"https://api.github.com/users/cf-lms/orgs","repos_url":"https://api.github.com/users/cf-lms/repos","events_url":"https://api.github.com/users/cf-lms/events{/privacy}","received_events_url":"https://api.github.com/users/cf-lms/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cf-lms/lms","description":"","fork":false,"url":"https://api.github.com/repos/cf-lms/lms","forks_url":"https://api.github.com/repos/cf-lms/lms/forks","keys_url":"https://api.github.com/repos/cf-lms/lms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cf-lms/lms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cf-lms/lms/teams","hooks_url":"https://api.github.com/repos/cf-lms/lms/hooks","issue_events_url":"https://api.github.com/repos/cf-lms/lms/issues/events{/number}","events_url":"https://api.github.com/repos/cf-lms/lms/events","assignees_url":"https://api.github.com/repos/cf-lms/lms/assignees{/user}","branches_url":"https://api.github.com/repos/cf-lms/lms/branches{/branch}","tags_url":"https://api.github.com/repos/cf-lms/lms/tags","blobs_url":"https://api.github.com/repos/cf-lms/lms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cf-lms/lms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cf-lms/lms/git/refs{/sha}","trees_url":"https://api.github.com/repos/cf-lms/lms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cf-lms/lms/statuses/{sha}","languages_url":"https://api.github.com/repos/cf-lms/lms/languages","stargazers_url":"https://api.github.com/repos/cf-lms/lms/stargazers","contributors_url":"https://api.github.com/repos/cf-lms/lms/contributors","subscribers_url":"https://api.github.com/repos/cf-lms/lms/subscribers","subscription_url":"https://api.github.com/repos/cf-lms/lms/subscription","commits_url":"https://api.github.com/repos/cf-lms/lms/commits{/sha}","git_commits_url":"https://api.github.com/repos/cf-lms/lms/git/commits{/sha}","comments_url":"https://api.github.com/repos/cf-lms/lms/comments{/number}","issue_comment_url":"https://api.github.com/repos/cf-lms/lms/issues/comments{/number}","contents_url":"https://api.github.com/repos/cf-lms/lms/contents/{+path}","compare_url":"https://api.github.com/repos/cf-lms/lms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cf-lms/lms/merges","archive_url":"https://api.github.com/repos/cf-lms/lms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cf-lms/lms/downloads","issues_url":"https://api.github.com/repos/cf-lms/lms/issues{/number}","pulls_url":"https://api.github.com/repos/cf-lms/lms/pulls{/number}","milestones_url":"https://api.github.com/repos/cf-lms/lms/milestones{/number}","notifications_url":"https://api.github.com/repos/cf-lms/lms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cf-lms/lms/labels{/name}","releases_url":"https://api.github.com/repos/cf-lms/lms/releases{/id}","created_at":"2015-12-14T18:30:13Z","updated_at":"2015-12-17T20:13:04Z","pushed_at":"2015-12-17T21:41:57Z","git_url":"git://github.com/cf-lms/lms.git","ssh_url":"git@github.com:cf-lms/lms.git","clone_url":"https://github.com/cf-lms/lms.git","svn_url":"https://github.com/cf-lms/lms","homepage":null,"size":293,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":1,"forks":4,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cf-lms/lms/pulls/20"},"html":{"href":"https://github.com/cf-lms/lms/pull/20"},"issue":{"href":"https://api.github.com/repos/cf-lms/lms/issues/20"},"comments":{"href":"https://api.github.com/repos/cf-lms/lms/issues/20/comments"},"review_comments":{"href":"https://api.github.com/repos/cf-lms/lms/pulls/20/comments"},"review_comment":{"href":"https://api.github.com/repos/cf-lms/lms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cf-lms/lms/pulls/20/commits"},"statuses":{"href":"https://api.github.com/repos/cf-lms/lms/statuses/040acdbdae7e007f94d3a70a5c9d97a40bc709fc"}}}}