{"action":"closed","number":14,"pull_request":{"url":"https://api.github.com/repos/instructure/ic-modal/pulls/14","id":16301069,"html_url":"https://github.com/instructure/ic-modal/pull/14","diff_url":"https://github.com/instructure/ic-modal/pull/14.diff","patch_url":"https://github.com/instructure/ic-modal/pull/14.patch","issue_url":"https://api.github.com/repos/instructure/ic-modal/issues/14","number":14,"state":"closed","locked":false,"title":"Add `close-on-click` and `close-on-escape` options","user":{"login":"charlesdemers","id":425073,"avatar_url":"https://avatars.githubusercontent.com/u/425073?v=3","gravatar_id":"","url":"https://api.github.com/users/charlesdemers","html_url":"https://github.com/charlesdemers","followers_url":"https://api.github.com/users/charlesdemers/followers","following_url":"https://api.github.com/users/charlesdemers/following{/other_user}","gists_url":"https://api.github.com/users/charlesdemers/gists{/gist_id}","starred_url":"https://api.github.com/users/charlesdemers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charlesdemers/subscriptions","organizations_url":"https://api.github.com/users/charlesdemers/orgs","repos_url":"https://api.github.com/users/charlesdemers/repos","events_url":"https://api.github.com/users/charlesdemers/events{/privacy}","received_events_url":"https://api.github.com/users/charlesdemers/received_events","type":"User","site_admin":false},"body":"I wanted to use `ic-modal` to do confirmation dialogs in my app and closing the modal without using the actual buttons wasn’t working, so I added options to configure it. The default is still to close when clicking the overlay or pressing escape.\r\n\r\nPS. I also fixed the build to be able to do this PR, tell me if you ever merge https://github.com/instructure/ic-modal/pull/12 so I can rebase master.","created_at":"2014-05-24T00:54:06Z","updated_at":"2015-04-29T21:10:02Z","closed_at":"2015-04-29T21:10:02Z","merged_at":null,"merge_commit_sha":"4c7d02783f09843953594d4dc9d1610e49274f2b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/instructure/ic-modal/pulls/14/commits","review_comments_url":"https://api.github.com/repos/instructure/ic-modal/pulls/14/comments","review_comment_url":"https://api.github.com/repos/instructure/ic-modal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/instructure/ic-modal/issues/14/comments","statuses_url":"https://api.github.com/repos/instructure/ic-modal/statuses/3da9b9b3e7c40cee3f1d661462877a7b682c6d48","head":{"label":"charlesdemers:feature/add-overlay-close-option","ref":"feature/add-overlay-close-option","sha":"3da9b9b3e7c40cee3f1d661462877a7b682c6d48","user":{"login":"charlesdemers","id":425073,"avatar_url":"https://avatars.githubusercontent.com/u/425073?v=3","gravatar_id":"","url":"https://api.github.com/users/charlesdemers","html_url":"https://github.com/charlesdemers","followers_url":"https://api.github.com/users/charlesdemers/followers","following_url":"https://api.github.com/users/charlesdemers/following{/other_user}","gists_url":"https://api.github.com/users/charlesdemers/gists{/gist_id}","starred_url":"https://api.github.com/users/charlesdemers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charlesdemers/subscriptions","organizations_url":"https://api.github.com/users/charlesdemers/orgs","repos_url":"https://api.github.com/users/charlesdemers/repos","events_url":"https://api.github.com/users/charlesdemers/events{/privacy}","received_events_url":"https://api.github.com/users/charlesdemers/received_events","type":"User","site_admin":false},"repo":{"id":20107894,"name":"ic-modal","full_name":"charlesdemers/ic-modal","owner":{"login":"charlesdemers","id":425073,"avatar_url":"https://avatars.githubusercontent.com/u/425073?v=3","gravatar_id":"","url":"https://api.github.com/users/charlesdemers","html_url":"https://github.com/charlesdemers","followers_url":"https://api.github.com/users/charlesdemers/followers","following_url":"https://api.github.com/users/charlesdemers/following{/other_user}","gists_url":"https://api.github.com/users/charlesdemers/gists{/gist_id}","starred_url":"https://api.github.com/users/charlesdemers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charlesdemers/subscriptions","organizations_url":"https://api.github.com/users/charlesdemers/orgs","repos_url":"https://api.github.com/users/charlesdemers/repos","events_url":"https://api.github.com/users/charlesdemers/events{/privacy}","received_events_url":"https://api.github.com/users/charlesdemers/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/charlesdemers/ic-modal","description":"Ember component for modal dialog","fork":true,"url":"https://api.github.com/repos/charlesdemers/ic-modal","forks_url":"https://api.github.com/repos/charlesdemers/ic-modal/forks","keys_url":"https://api.github.com/repos/charlesdemers/ic-modal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/charlesdemers/ic-modal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/charlesdemers/ic-modal/teams","hooks_url":"https://api.github.com/repos/charlesdemers/ic-modal/hooks","issue_events_url":"https://api.github.com/repos/charlesdemers/ic-modal/issues/events{/number}","events_url":"https://api.github.com/repos/charlesdemers/ic-modal/events","assignees_url":"https://api.github.com/repos/charlesdemers/ic-modal/assignees{/user}","branches_url":"https://api.github.com/repos/charlesdemers/ic-modal/branches{/branch}","tags_url":"https://api.github.com/repos/charlesdemers/ic-modal/tags","blobs_url":"https://api.github.com/repos/charlesdemers/ic-modal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/charlesdemers/ic-modal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/charlesdemers/ic-modal/git/refs{/sha}","trees_url":"https://api.github.com/repos/charlesdemers/ic-modal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/charlesdemers/ic-modal/statuses/{sha}","languages_url":"https://api.github.com/repos/charlesdemers/ic-modal/languages","stargazers_url":"https://api.github.com/repos/charlesdemers/ic-modal/stargazers","contributors_url":"https://api.github.com/repos/charlesdemers/ic-modal/contributors","subscribers_url":"https://api.github.com/repos/charlesdemers/ic-modal/subscribers","subscription_url":"https://api.github.com/repos/charlesdemers/ic-modal/subscription","commits_url":"https://api.github.com/repos/charlesdemers/ic-modal/commits{/sha}","git_commits_url":"https://api.github.com/repos/charlesdemers/ic-modal/git/commits{/sha}","comments_url":"https://api.github.com/repos/charlesdemers/ic-modal/comments{/number}","issue_comment_url":"https://api.github.com/repos/charlesdemers/ic-modal/issues/comments{/number}","contents_url":"https://api.github.com/repos/charlesdemers/ic-modal/contents/{+path}","compare_url":"https://api.github.com/repos/charlesdemers/ic-modal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/charlesdemers/ic-modal/merges","archive_url":"https://api.github.com/repos/charlesdemers/ic-modal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/charlesdemers/ic-modal/downloads","issues_url":"https://api.github.com/repos/charlesdemers/ic-modal/issues{/number}","pulls_url":"https://api.github.com/repos/charlesdemers/ic-modal/pulls{/number}","milestones_url":"https://api.github.com/repos/charlesdemers/ic-modal/milestones{/number}","notifications_url":"https://api.github.com/repos/charlesdemers/ic-modal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/charlesdemers/ic-modal/labels{/name}","releases_url":"https://api.github.com/repos/charlesdemers/ic-modal/releases{/id}","created_at":"2014-05-23T17:22:56Z","updated_at":"2014-05-26T14:06:46Z","pushed_at":"2014-07-21T13:45:17Z","git_url":"git://github.com/charlesdemers/ic-modal.git","ssh_url":"git@github.com:charlesdemers/ic-modal.git","clone_url":"https://github.com/charlesdemers/ic-modal.git","svn_url":"https://github.com/charlesdemers/ic-modal","homepage":null,"size":1576,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"instructure:master","ref":"master","sha":"24f6e36f3a1928c0ad351d8c79a8befcd4a24707","user":{"login":"instructure","id":515326,"avatar_url":"https://avatars.githubusercontent.com/u/515326?v=3","gravatar_id":"","url":"https://api.github.com/users/instructure","html_url":"https://github.com/instructure","followers_url":"https://api.github.com/users/instructure/followers","following_url":"https://api.github.com/users/instructure/following{/other_user}","gists_url":"https://api.github.com/users/instructure/gists{/gist_id}","starred_url":"https://api.github.com/users/instructure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/instructure/subscriptions","organizations_url":"https://api.github.com/users/instructure/orgs","repos_url":"https://api.github.com/users/instructure/repos","events_url":"https://api.github.com/users/instructure/events{/privacy}","received_events_url":"https://api.github.com/users/instructure/received_events","type":"Organization","site_admin":false},"repo":{"id":14753958,"name":"ic-modal","full_name":"instructure/ic-modal","owner":{"login":"instructure","id":515326,"avatar_url":"https://avatars.githubusercontent.com/u/515326?v=3","gravatar_id":"","url":"https://api.github.com/users/instructure","html_url":"https://github.com/instructure","followers_url":"https://api.github.com/users/instructure/followers","following_url":"https://api.github.com/users/instructure/following{/other_user}","gists_url":"https://api.github.com/users/instructure/gists{/gist_id}","starred_url":"https://api.github.com/users/instructure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/instructure/subscriptions","organizations_url":"https://api.github.com/users/instructure/orgs","repos_url":"https://api.github.com/users/instructure/repos","events_url":"https://api.github.com/users/instructure/events{/privacy}","received_events_url":"https://api.github.com/users/instructure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/instructure/ic-modal","description":"Ember component for modal dialog","fork":false,"url":"https://api.github.com/repos/instructure/ic-modal","forks_url":"https://api.github.com/repos/instructure/ic-modal/forks","keys_url":"https://api.github.com/repos/instructure/ic-modal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/instructure/ic-modal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/instructure/ic-modal/teams","hooks_url":"https://api.github.com/repos/instructure/ic-modal/hooks","issue_events_url":"https://api.github.com/repos/instructure/ic-modal/issues/events{/number}","events_url":"https://api.github.com/repos/instructure/ic-modal/events","assignees_url":"https://api.github.com/repos/instructure/ic-modal/assignees{/user}","branches_url":"https://api.github.com/repos/instructure/ic-modal/branches{/branch}","tags_url":"https://api.github.com/repos/instructure/ic-modal/tags","blobs_url":"https://api.github.com/repos/instructure/ic-modal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/instructure/ic-modal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/instructure/ic-modal/git/refs{/sha}","trees_url":"https://api.github.com/repos/instructure/ic-modal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/instructure/ic-modal/statuses/{sha}","languages_url":"https://api.github.com/repos/instructure/ic-modal/languages","stargazers_url":"https://api.github.com/repos/instructure/ic-modal/stargazers","contributors_url":"https://api.github.com/repos/instructure/ic-modal/contributors","subscribers_url":"https://api.github.com/repos/instructure/ic-modal/subscribers","subscription_url":"https://api.github.com/repos/instructure/ic-modal/subscription","commits_url":"https://api.github.com/repos/instructure/ic-modal/commits{/sha}","git_commits_url":"https://api.github.com/repos/instructure/ic-modal/git/commits{/sha}","comments_url":"https://api.github.com/repos/instructure/ic-modal/comments{/number}","issue_comment_url":"https://api.github.com/repos/instructure/ic-modal/issues/comments{/number}","contents_url":"https://api.github.com/repos/instructure/ic-modal/contents/{+path}","compare_url":"https://api.github.com/repos/instructure/ic-modal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/instructure/ic-modal/merges","archive_url":"https://api.github.com/repos/instructure/ic-modal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/instructure/ic-modal/downloads","issues_url":"https://api.github.com/repos/instructure/ic-modal/issues{/number}","pulls_url":"https://api.github.com/repos/instructure/ic-modal/pulls{/number}","milestones_url":"https://api.github.com/repos/instructure/ic-modal/milestones{/number}","notifications_url":"https://api.github.com/repos/instructure/ic-modal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/instructure/ic-modal/labels{/name}","releases_url":"https://api.github.com/repos/instructure/ic-modal/releases{/id}","created_at":"2013-11-27T17:27:13Z","updated_at":"2015-04-14T03:17:52Z","pushed_at":"2014-09-05T19:58:20Z","git_url":"git://github.com/instructure/ic-modal.git","ssh_url":"git@github.com:instructure/ic-modal.git","clone_url":"https://github.com/instructure/ic-modal.git","svn_url":"https://github.com/instructure/ic-modal","homepage":null,"size":1960,"stargazers_count":62,"watchers_count":62,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":16,"mirror_url":null,"open_issues_count":15,"forks":16,"open_issues":15,"watchers":62,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/instructure/ic-modal/pulls/14"},"html":{"href":"https://github.com/instructure/ic-modal/pull/14"},"issue":{"href":"https://api.github.com/repos/instructure/ic-modal/issues/14"},"comments":{"href":"https://api.github.com/repos/instructure/ic-modal/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/instructure/ic-modal/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/instructure/ic-modal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/instructure/ic-modal/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/instructure/ic-modal/statuses/3da9b9b3e7c40cee3f1d661462877a7b682c6d48"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":1,"review_comments":0,"commits":3,"additions":113,"deletions":11,"changed_files":7}}