{"action":"created","comment":{"url":"https://api.github.com/repos/telefonicaid/fiware-cygnus/pulls/comments/30229201","id":30229201,"diff_hunk":"@@ -23,7 +23,7 @@\n import static org.junit.Assert.*; // this is required by \"fail\" like assertions","path":"src/test/java/com/telefonica/iot/cygnus/sinks/OrionHDFSSinkTest.java","position":1,"original_position":1,"commit_id":"d7e35445d95d55f2c31c2dc1715ad9cab8bb796d","original_commit_id":"d7e35445d95d55f2c31c2dc1715ad9cab8bb796d","user":{"login":"gtorodelvalle","id":667284,"avatar_url":"https://avatars.githubusercontent.com/u/667284?v=3","gravatar_id":"","url":"https://api.github.com/users/gtorodelvalle","html_url":"https://github.com/gtorodelvalle","followers_url":"https://api.github.com/users/gtorodelvalle/followers","following_url":"https://api.github.com/users/gtorodelvalle/following{/other_user}","gists_url":"https://api.github.com/users/gtorodelvalle/gists{/gist_id}","starred_url":"https://api.github.com/users/gtorodelvalle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gtorodelvalle/subscriptions","organizations_url":"https://api.github.com/users/gtorodelvalle/orgs","repos_url":"https://api.github.com/users/gtorodelvalle/repos","events_url":"https://api.github.com/users/gtorodelvalle/events{/privacy}","received_events_url":"https://api.github.com/users/gtorodelvalle/received_events","type":"User","site_admin":false},"body":"Not to be solved in this PR but shouldn't this class be named OrionHdfsSinkTest? :)","created_at":"2015-05-13T13:21:24Z","updated_at":"2015-05-13T13:21:24Z","html_url":"https://github.com/telefonicaid/fiware-cygnus/pull/398#discussion_r30229201","pull_request_url":"https://api.github.com/repos/telefonicaid/fiware-cygnus/pulls/398","_links":{"self":{"href":"https://api.github.com/repos/telefonicaid/fiware-cygnus/pulls/comments/30229201"},"html":{"href":"https://github.com/telefonicaid/fiware-cygnus/pull/398#discussion_r30229201"},"pull_request":{"href":"https://api.github.com/repos/telefonicaid/fiware-cygnus/pulls/398"}}},"pull_request":{"url":"https://api.github.com/repos/telefonicaid/fiware-cygnus/pulls/398","id":35307279,"html_url":"https://github.com/telefonicaid/fiware-cygnus/pull/398","diff_url":"https://github.com/telefonicaid/fiware-cygnus/pull/398.diff","patch_url":"https://github.com/telefonicaid/fiware-cygnus/pull/398.patch","issue_url":"https://api.github.com/repos/telefonicaid/fiware-cygnus/issues/398","number":398,"state":"open","locked":false,"title":"hardening/306_http_backend","user":{"login":"frbattid","id":3865056,"avatar_url":"https://avatars.githubusercontent.com/u/3865056?v=3","gravatar_id":"","url":"https://api.github.com/users/frbattid","html_url":"https://github.com/frbattid","followers_url":"https://api.github.com/users/frbattid/followers","following_url":"https://api.github.com/users/frbattid/following{/other_user}","gists_url":"https://api.github.com/users/frbattid/gists{/gist_id}","starred_url":"https://api.github.com/users/frbattid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frbattid/subscriptions","organizations_url":"https://api.github.com/users/frbattid/orgs","repos_url":"https://api.github.com/users/frbattid/repos","events_url":"https://api.github.com/users/frbattid/events{/privacy}","received_events_url":"https://api.github.com/users/frbattid/received_events","type":"User","site_admin":false},"body":"* Implements issue #306 \r\n* 100% unit tests passed\r\n```\r\nResults :\r\nTests run: 49, Failures: 0, Errors: 0, Skipped: 0\r\n```\r\n* (unofficial) e2e tests passed\r\n```\r\n2015-05-13T10:54:14.165CEST | lvl=DEBUG | trans=1431507251-348-0000000000 | function=insert | comp=Cygnus | msg=com.telefonica.iot.cygnus.backends.ckan.CKANBackendImpl[210] : Successful insert (resource/datastore id=3adb2962-5b4c-48c6-abe0-07f485c85810)\r\n2015-05-13T10:54:14.166CEST | lvl=INFO | trans=1431507251-348-0000000000 | function=process | comp=Cygnus | msg=com.telefonica.iot.cygnus.sinks.OrionSink[190] : Finishing transaction (1431507251-348-0000000000)\r\n...\r\n$ curl -X GET \"http://130.206.80.46:14000/webhdfs/v1/user/frb/zzz_serv/null/other_rooms/other_rooms.txt?op=open&user.name=frb\"\r\n{\"recvTimeTs\":\"1431507301\",\"recvTime\":\"2015-05-13T08:55:01.863Z\",\"entityId\":\"Room1\",\"entityType\":\"Room\",\"attrName\":\"temperature\",\"attrType\":\"centigrade\",\"attrValue\":\"26.5\",\"attrMd\":[]}\r\n```\r\n* Assignee @fgalan but LGTM from @gtorodelvalle and @iariasleon is also required. Regarding @iariasleon , a complete regression on the HDFS and CKAN e2e tests is required.\r\n* **UNDERSTANDING THE PR**:\r\n    * Mainly, this PR creates a `HttpBackend` class that is the base for `HDFSBackendImpl` and `CKANBackendImpl` (and `CKANCache` since it performs Http requests as well). This was necessary since both backend implementation contained common code regarding the creation of Http clients, requests, responses management, etc. `HttpBackend` is now under `com.telefonica.iot.cygnus.backends.http` package together with `JsonResponse` (see below), `HttpClientFactory` (see below) and `KerberosCallbackHandler` (see below).\r\n    * A `JsonResponse` has been created, which is returned by the `HttpBackend` classes. This was inspired by `CKANResponse` (which has been deleted in favor of `JsonResponse`).\r\n    * `HttpClientFactory` was moved from `com.telefonica.iot.cygnus.http` package to `com.telefonica.iot.cygnus.backends.http`, since it makes more sense.\r\n    * `KerberosCallbackHandler` is now under `com.telefonica.iot.cygnus.backends.http` package since it is no more a class related to HDFS but to Http (any Http connection may be secured by means of Kerberos protocol, not only WebHDFS ones).\r\n    * In addition, the `HDFSBackend` class has been changed from abstract class to interface, as was initialy desgined (but, somehow, changed to abstract class in any old PR).","created_at":"2015-05-13T09:11:48Z","updated_at":"2015-05-13T13:21:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ee2a9ea8677a13f54a7be992b275b23b79835aa5","assignee":{"login":"fgalan","id":1534240,"avatar_url":"https://avatars.githubusercontent.com/u/1534240?v=3","gravatar_id":"","url":"https://api.github.com/users/fgalan","html_url":"https://github.com/fgalan","followers_url":"https://api.github.com/users/fgalan/followers","following_url":"https://api.github.com/users/fgalan/following{/other_user}","gists_url":"https://api.github.com/users/fgalan/gists{/gist_id}","starred_url":"https://api.github.com/users/fgalan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fgalan/subscriptions","organizations_url":"https://api.github.com/users/fgalan/orgs","repos_url":"https://api.github.com/users/fgalan/repos","events_url":"https://api.github.com/users/fgalan/events{/privacy}","received_events_url":"https://api.github.com/users/fgalan/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/telefonicaid/fiware-cygnus/pulls/398/commits","review_comments_url":"https://api.github.com/repos/telefonicaid/fiware-cygnus/pulls/398/comments","review_comment_url":"https://api.github.com/repos/telefonicaid/fiware-cygnus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/telefonicaid/fiware-cygnus/issues/398/comments","statuses_url":"https://api.github.com/repos/telefonicaid/fiware-cygnus/statuses/d7e35445d95d55f2c31c2dc1715ad9cab8bb796d","head":{"label":"telefonicaid:hardening/306_http_backend","ref":"hardening/306_http_backend","sha":"d7e35445d95d55f2c31c2dc1715ad9cab8bb796d","user":{"login":"telefonicaid","id":968363,"avatar_url":"https://avatars.githubusercontent.com/u/968363?v=3","gravatar_id":"","url":"https://api.github.com/users/telefonicaid","html_url":"https://github.com/telefonicaid","followers_url":"https://api.github.com/users/telefonicaid/followers","following_url":"https://api.github.com/users/telefonicaid/following{/other_user}","gists_url":"https://api.github.com/users/telefonicaid/gists{/gist_id}","starred_url":"https://api.github.com/users/telefonicaid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/telefonicaid/subscriptions","organizations_url":"https://api.github.com/users/telefonicaid/orgs","repos_url":"https://api.github.com/users/telefonicaid/repos","events_url":"https://api.github.com/users/telefonicaid/events{/privacy}","received_events_url":"https://api.github.com/users/telefonicaid/received_events","type":"Organization","site_admin":false},"repo":{"id":16607947,"name":"fiware-cygnus","full_name":"telefonicaid/fiware-cygnus","owner":{"login":"telefonicaid","id":968363,"avatar_url":"https://avatars.githubusercontent.com/u/968363?v=3","gravatar_id":"","url":"https://api.github.com/users/telefonicaid","html_url":"https://github.com/telefonicaid","followers_url":"https://api.github.com/users/telefonicaid/followers","following_url":"https://api.github.com/users/telefonicaid/following{/other_user}","gists_url":"https://api.github.com/users/telefonicaid/gists{/gist_id}","starred_url":"https://api.github.com/users/telefonicaid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/telefonicaid/subscriptions","organizations_url":"https://api.github.com/users/telefonicaid/orgs","repos_url":"https://api.github.com/users/telefonicaid/repos","events_url":"https://api.github.com/users/telefonicaid/events{/privacy}","received_events_url":"https://api.github.com/users/telefonicaid/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/telefonicaid/fiware-cygnus","description":"FI-WARE connectors","fork":false,"url":"https://api.github.com/repos/telefonicaid/fiware-cygnus","forks_url":"https://api.github.com/repos/telefonicaid/fiware-cygnus/forks","keys_url":"https://api.github.com/repos/telefonicaid/fiware-cygnus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/telefonicaid/fiware-cygnus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/telefonicaid/fiware-cygnus/teams","hooks_url":"https://api.github.com/repos/telefonicaid/fiware-cygnus/hooks","issue_events_url":"https://api.github.com/repos/telefonicaid/fiware-cygnus/issues/events{/number}","events_url":"https://api.github.com/repos/telefonicaid/fiware-cygnus/events","assignees_url":"https://api.github.com/repos/telefonicaid/fiware-cygnus/assignees{/user}","branches_url":"https://api.github.com/repos/telefonicaid/fiware-cygnus/branches{/branch}","tags_url":"https://api.github.com/repos/telefonicaid/fiware-cygnus/tags","blobs_url":"https://api.github.com/repos/telefonicaid/fiware-cygnus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/telefonicaid/fiware-cygnus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/telefonicaid/fiware-cygnus/git/refs{/sha}","trees_url":"https://api.github.com/repos/telefonicaid/fiware-cygnus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/telefonicaid/fiware-cygnus/statuses/{sha}","languages_url":"https://api.github.com/repos/telefonicaid/fiware-cygnus/languages","stargazers_url":"https://api.github.com/repos/telefonicaid/fiware-cygnus/stargazers","contributors_url":"https://api.github.com/repos/telefonicaid/fiware-cygnus/contributors","subscribers_url":"https://api.github.com/repos/telefonicaid/fiware-cygnus/subscribers","subscription_url":"https://api.github.com/repos/telefonicaid/fiware-cygnus/subscription","commits_url":"https://api.github.com/repos/telefonicaid/fiware-cygnus/commits{/sha}","git_commits_url":"https://api.github.com/repos/telefonicaid/fiware-cygnus/git/commits{/sha}","comments_url":"https://api.github.com/repos/telefonicaid/fiware-cygnus/comments{/number}","issue_comment_url":"https://api.github.com/repos/telefonicaid/fiware-cygnus/issues/comments{/number}","contents_url":"https://api.github.com/repos/telefonicaid/fiware-cygnus/contents/{+path}","compare_url":"https://api.github.com/repos/telefonicaid/fiware-cygnus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/telefonicaid/fiware-cygnus/merges","archive_url":"https://api.github.com/repos/telefonicaid/fiware-cygnus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/telefonicaid/fiware-cygnus/downloads","issues_url":"https://api.github.com/repos/telefonicaid/fiware-cygnus/issues{/number}","pulls_url":"https://api.github.com/repos/telefonicaid/fiware-cygnus/pulls{/number}","milestones_url":"https://api.github.com/repos/telefonicaid/fiware-cygnus/milestones{/number}","notifications_url":"https://api.github.com/repos/telefonicaid/fiware-cygnus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/telefonicaid/fiware-cygnus/labels{/name}","releases_url":"https://api.github.com/repos/telefonicaid/fiware-cygnus/releases{/id}","created_at":"2014-02-07T07:57:41Z","updated_at":"2015-05-08T09:59:00Z","pushed_at":"2015-05-13T12:03:41Z","git_url":"git://github.com/telefonicaid/fiware-cygnus.git","ssh_url":"git@github.com:telefonicaid/fiware-cygnus.git","clone_url":"https://github.com/telefonicaid/fiware-cygnus.git","svn_url":"https://github.com/telefonicaid/fiware-cygnus","homepage":"","size":95180,"stargazers_count":13,"watchers_count":13,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":36,"forks":9,"open_issues":36,"watchers":13,"default_branch":"master"}},"base":{"label":"telefonicaid:develop","ref":"develop","sha":"fa7a488102ca2b1143a1a79c81d7ed5b02854370","user":{"login":"telefonicaid","id":968363,"avatar_url":"https://avatars.githubusercontent.com/u/968363?v=3","gravatar_id":"","url":"https://api.github.com/users/telefonicaid","html_url":"https://github.com/telefonicaid","followers_url":"https://api.github.com/users/telefonicaid/followers","following_url":"https://api.github.com/users/telefonicaid/following{/other_user}","gists_url":"https://api.github.com/users/telefonicaid/gists{/gist_id}","starred_url":"https://api.github.com/users/telefonicaid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/telefonicaid/subscriptions","organizations_url":"https://api.github.com/users/telefonicaid/orgs","repos_url":"https://api.github.com/users/telefonicaid/repos","events_url":"https://api.github.com/users/telefonicaid/events{/privacy}","received_events_url":"https://api.github.com/users/telefonicaid/received_events","type":"Organization","site_admin":false},"repo":{"id":16607947,"name":"fiware-cygnus","full_name":"telefonicaid/fiware-cygnus","owner":{"login":"telefonicaid","id":968363,"avatar_url":"https://avatars.githubusercontent.com/u/968363?v=3","gravatar_id":"","url":"https://api.github.com/users/telefonicaid","html_url":"https://github.com/telefonicaid","followers_url":"https://api.github.com/users/telefonicaid/followers","following_url":"https://api.github.com/users/telefonicaid/following{/other_user}","gists_url":"https://api.github.com/users/telefonicaid/gists{/gist_id}","starred_url":"https://api.github.com/users/telefonicaid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/telefonicaid/subscriptions","organizations_url":"https://api.github.com/users/telefonicaid/orgs","repos_url":"https://api.github.com/users/telefonicaid/repos","events_url":"https://api.github.com/users/telefonicaid/events{/privacy}","received_events_url":"https://api.github.com/users/telefonicaid/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/telefonicaid/fiware-cygnus","description":"FI-WARE connectors","fork":false,"url":"https://api.github.com/repos/telefonicaid/fiware-cygnus","forks_url":"https://api.github.com/repos/telefonicaid/fiware-cygnus/forks","keys_url":"https://api.github.com/repos/telefonicaid/fiware-cygnus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/telefonicaid/fiware-cygnus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/telefonicaid/fiware-cygnus/teams","hooks_url":"https://api.github.com/repos/telefonicaid/fiware-cygnus/hooks","issue_events_url":"https://api.github.com/repos/telefonicaid/fiware-cygnus/issues/events{/number}","events_url":"https://api.github.com/repos/telefonicaid/fiware-cygnus/events","assignees_url":"https://api.github.com/repos/telefonicaid/fiware-cygnus/assignees{/user}","branches_url":"https://api.github.com/repos/telefonicaid/fiware-cygnus/branches{/branch}","tags_url":"https://api.github.com/repos/telefonicaid/fiware-cygnus/tags","blobs_url":"https://api.github.com/repos/telefonicaid/fiware-cygnus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/telefonicaid/fiware-cygnus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/telefonicaid/fiware-cygnus/git/refs{/sha}","trees_url":"https://api.github.com/repos/telefonicaid/fiware-cygnus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/telefonicaid/fiware-cygnus/statuses/{sha}","languages_url":"https://api.github.com/repos/telefonicaid/fiware-cygnus/languages","stargazers_url":"https://api.github.com/repos/telefonicaid/fiware-cygnus/stargazers","contributors_url":"https://api.github.com/repos/telefonicaid/fiware-cygnus/contributors","subscribers_url":"https://api.github.com/repos/telefonicaid/fiware-cygnus/subscribers","subscription_url":"https://api.github.com/repos/telefonicaid/fiware-cygnus/subscription","commits_url":"https://api.github.com/repos/telefonicaid/fiware-cygnus/commits{/sha}","git_commits_url":"https://api.github.com/repos/telefonicaid/fiware-cygnus/git/commits{/sha}","comments_url":"https://api.github.com/repos/telefonicaid/fiware-cygnus/comments{/number}","issue_comment_url":"https://api.github.com/repos/telefonicaid/fiware-cygnus/issues/comments{/number}","contents_url":"https://api.github.com/repos/telefonicaid/fiware-cygnus/contents/{+path}","compare_url":"https://api.github.com/repos/telefonicaid/fiware-cygnus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/telefonicaid/fiware-cygnus/merges","archive_url":"https://api.github.com/repos/telefonicaid/fiware-cygnus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/telefonicaid/fiware-cygnus/downloads","issues_url":"https://api.github.com/repos/telefonicaid/fiware-cygnus/issues{/number}","pulls_url":"https://api.github.com/repos/telefonicaid/fiware-cygnus/pulls{/number}","milestones_url":"https://api.github.com/repos/telefonicaid/fiware-cygnus/milestones{/number}","notifications_url":"https://api.github.com/repos/telefonicaid/fiware-cygnus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/telefonicaid/fiware-cygnus/labels{/name}","releases_url":"https://api.github.com/repos/telefonicaid/fiware-cygnus/releases{/id}","created_at":"2014-02-07T07:57:41Z","updated_at":"2015-05-08T09:59:00Z","pushed_at":"2015-05-13T12:03:41Z","git_url":"git://github.com/telefonicaid/fiware-cygnus.git","ssh_url":"git@github.com:telefonicaid/fiware-cygnus.git","clone_url":"https://github.com/telefonicaid/fiware-cygnus.git","svn_url":"https://github.com/telefonicaid/fiware-cygnus","homepage":"","size":95180,"stargazers_count":13,"watchers_count":13,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":36,"forks":9,"open_issues":36,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/telefonicaid/fiware-cygnus/pulls/398"},"html":{"href":"https://github.com/telefonicaid/fiware-cygnus/pull/398"},"issue":{"href":"https://api.github.com/repos/telefonicaid/fiware-cygnus/issues/398"},"comments":{"href":"https://api.github.com/repos/telefonicaid/fiware-cygnus/issues/398/comments"},"review_comments":{"href":"https://api.github.com/repos/telefonicaid/fiware-cygnus/pulls/398/comments"},"review_comment":{"href":"https://api.github.com/repos/telefonicaid/fiware-cygnus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/telefonicaid/fiware-cygnus/pulls/398/commits"},"statuses":{"href":"https://api.github.com/repos/telefonicaid/fiware-cygnus/statuses/d7e35445d95d55f2c31c2dc1715ad9cab8bb796d"}}}}