{"action":"created","comment":{"url":"https://api.github.com/repos/apache/storm/pulls/comments/41064149","id":41064149,"diff_hunk":"@@ -39,6 +39,8 @@\n     public double retryDelayMultiplier = 1.0;\n     public long retryDelayMaxMs = 60 * 1000;","path":"external/storm-kafka/src/jvm/storm/kafka/SpoutConfig.java","position":2,"original_position":2,"commit_id":"b7282b3a44ead4b20f9a5f2151ca1eba96f3abc8","original_commit_id":"b7282b3a44ead4b20f9a5f2151ca1eba96f3abc8","user":{"login":"ptgoetz","id":260896,"avatar_url":"https://avatars.githubusercontent.com/u/260896?v=3","gravatar_id":"","url":"https://api.github.com/users/ptgoetz","html_url":"https://github.com/ptgoetz","followers_url":"https://api.github.com/users/ptgoetz/followers","following_url":"https://api.github.com/users/ptgoetz/following{/other_user}","gists_url":"https://api.github.com/users/ptgoetz/gists{/gist_id}","starred_url":"https://api.github.com/users/ptgoetz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ptgoetz/subscriptions","organizations_url":"https://api.github.com/users/ptgoetz/orgs","repos_url":"https://api.github.com/users/ptgoetz/repos","events_url":"https://api.github.com/users/ptgoetz/events{/privacy}","received_events_url":"https://api.github.com/users/ptgoetz/received_events","type":"User","site_admin":false},"body":"Since the above values only apply to the ExponentialBackoff implementation, it would be nice if we could factor them out of this class. They could probably just be moved to `ExponentialBackoffMsgRetryManagerFactory`, and in that case we could probably eliminate the factory pattern altogether.","created_at":"2015-10-02T20:28:34Z","updated_at":"2015-10-02T20:28:34Z","html_url":"https://github.com/apache/storm/pull/780#discussion_r41064149","pull_request_url":"https://api.github.com/repos/apache/storm/pulls/780","_links":{"self":{"href":"https://api.github.com/repos/apache/storm/pulls/comments/41064149"},"html":{"href":"https://github.com/apache/storm/pull/780#discussion_r41064149"},"pull_request":{"href":"https://api.github.com/repos/apache/storm/pulls/780"}}},"pull_request":{"url":"https://api.github.com/repos/apache/storm/pulls/780","id":46672900,"html_url":"https://github.com/apache/storm/pull/780","diff_url":"https://github.com/apache/storm/pull/780.diff","patch_url":"https://github.com/apache/storm/pull/780.patch","issue_url":"https://api.github.com/repos/apache/storm/issues/780","number":780,"state":"open","locked":false,"title":"STORM-1086. Make FailedMsgRetryManager configurable when setting up KafkaSpout","user":{"login":"kleinsch","id":234464,"avatar_url":"https://avatars.githubusercontent.com/u/234464?v=3","gravatar_id":"","url":"https://api.github.com/users/kleinsch","html_url":"https://github.com/kleinsch","followers_url":"https://api.github.com/users/kleinsch/followers","following_url":"https://api.github.com/users/kleinsch/following{/other_user}","gists_url":"https://api.github.com/users/kleinsch/gists{/gist_id}","starred_url":"https://api.github.com/users/kleinsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kleinsch/subscriptions","organizations_url":"https://api.github.com/users/kleinsch/orgs","repos_url":"https://api.github.com/users/kleinsch/repos","events_url":"https://api.github.com/users/kleinsch/events{/privacy}","received_events_url":"https://api.github.com/users/kleinsch/received_events","type":"User","site_admin":false},"body":"We'd like to be able to drop messages when they've been replayed N times. Seems easy to do if we could extend ExponentialBackoffMsgRetryManager, but there's no way to inject a custom FailedMsgRetryManager without changing the Kafka codebase. This PR allows users to specify the FailedMsgRetryManager as part of SpoutConfig.","created_at":"2015-10-02T19:30:19Z","updated_at":"2015-10-02T20:28:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9d6aa50b8ed0c36372757477ee275dde6a7ea387","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/storm/pulls/780/commits","review_comments_url":"https://api.github.com/repos/apache/storm/pulls/780/comments","review_comment_url":"https://api.github.com/repos/apache/storm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/storm/issues/780/comments","statuses_url":"https://api.github.com/repos/apache/storm/statuses/b7282b3a44ead4b20f9a5f2151ca1eba96f3abc8","head":{"label":"kleinsch:STORM-1086","ref":"STORM-1086","sha":"b7282b3a44ead4b20f9a5f2151ca1eba96f3abc8","user":{"login":"kleinsch","id":234464,"avatar_url":"https://avatars.githubusercontent.com/u/234464?v=3","gravatar_id":"","url":"https://api.github.com/users/kleinsch","html_url":"https://github.com/kleinsch","followers_url":"https://api.github.com/users/kleinsch/followers","following_url":"https://api.github.com/users/kleinsch/following{/other_user}","gists_url":"https://api.github.com/users/kleinsch/gists{/gist_id}","starred_url":"https://api.github.com/users/kleinsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kleinsch/subscriptions","organizations_url":"https://api.github.com/users/kleinsch/orgs","repos_url":"https://api.github.com/users/kleinsch/repos","events_url":"https://api.github.com/users/kleinsch/events{/privacy}","received_events_url":"https://api.github.com/users/kleinsch/received_events","type":"User","site_admin":false},"repo":{"id":43566289,"name":"storm","full_name":"kleinsch/storm","owner":{"login":"kleinsch","id":234464,"avatar_url":"https://avatars.githubusercontent.com/u/234464?v=3","gravatar_id":"","url":"https://api.github.com/users/kleinsch","html_url":"https://github.com/kleinsch","followers_url":"https://api.github.com/users/kleinsch/followers","following_url":"https://api.github.com/users/kleinsch/following{/other_user}","gists_url":"https://api.github.com/users/kleinsch/gists{/gist_id}","starred_url":"https://api.github.com/users/kleinsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kleinsch/subscriptions","organizations_url":"https://api.github.com/users/kleinsch/orgs","repos_url":"https://api.github.com/users/kleinsch/repos","events_url":"https://api.github.com/users/kleinsch/events{/privacy}","received_events_url":"https://api.github.com/users/kleinsch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kleinsch/storm","description":"Mirror of Apache Storm","fork":true,"url":"https://api.github.com/repos/kleinsch/storm","forks_url":"https://api.github.com/repos/kleinsch/storm/forks","keys_url":"https://api.github.com/repos/kleinsch/storm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kleinsch/storm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kleinsch/storm/teams","hooks_url":"https://api.github.com/repos/kleinsch/storm/hooks","issue_events_url":"https://api.github.com/repos/kleinsch/storm/issues/events{/number}","events_url":"https://api.github.com/repos/kleinsch/storm/events","assignees_url":"https://api.github.com/repos/kleinsch/storm/assignees{/user}","branches_url":"https://api.github.com/repos/kleinsch/storm/branches{/branch}","tags_url":"https://api.github.com/repos/kleinsch/storm/tags","blobs_url":"https://api.github.com/repos/kleinsch/storm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kleinsch/storm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kleinsch/storm/git/refs{/sha}","trees_url":"https://api.github.com/repos/kleinsch/storm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kleinsch/storm/statuses/{sha}","languages_url":"https://api.github.com/repos/kleinsch/storm/languages","stargazers_url":"https://api.github.com/repos/kleinsch/storm/stargazers","contributors_url":"https://api.github.com/repos/kleinsch/storm/contributors","subscribers_url":"https://api.github.com/repos/kleinsch/storm/subscribers","subscription_url":"https://api.github.com/repos/kleinsch/storm/subscription","commits_url":"https://api.github.com/repos/kleinsch/storm/commits{/sha}","git_commits_url":"https://api.github.com/repos/kleinsch/storm/git/commits{/sha}","comments_url":"https://api.github.com/repos/kleinsch/storm/comments{/number}","issue_comment_url":"https://api.github.com/repos/kleinsch/storm/issues/comments{/number}","contents_url":"https://api.github.com/repos/kleinsch/storm/contents/{+path}","compare_url":"https://api.github.com/repos/kleinsch/storm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kleinsch/storm/merges","archive_url":"https://api.github.com/repos/kleinsch/storm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kleinsch/storm/downloads","issues_url":"https://api.github.com/repos/kleinsch/storm/issues{/number}","pulls_url":"https://api.github.com/repos/kleinsch/storm/pulls{/number}","milestones_url":"https://api.github.com/repos/kleinsch/storm/milestones{/number}","notifications_url":"https://api.github.com/repos/kleinsch/storm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kleinsch/storm/labels{/name}","releases_url":"https://api.github.com/repos/kleinsch/storm/releases{/id}","created_at":"2015-10-02T17:22:52Z","updated_at":"2015-10-02T17:22:59Z","pushed_at":"2015-10-02T19:29:01Z","git_url":"git://github.com/kleinsch/storm.git","ssh_url":"git@github.com:kleinsch/storm.git","clone_url":"https://github.com/kleinsch/storm.git","svn_url":"https://github.com/kleinsch/storm","homepage":null,"size":20722,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"768a85926373355c15cc139fd86268916abc6850","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":14135470,"name":"storm","full_name":"apache/storm","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/storm","description":"Mirror of Apache Storm","fork":false,"url":"https://api.github.com/repos/apache/storm","forks_url":"https://api.github.com/repos/apache/storm/forks","keys_url":"https://api.github.com/repos/apache/storm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/storm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/storm/teams","hooks_url":"https://api.github.com/repos/apache/storm/hooks","issue_events_url":"https://api.github.com/repos/apache/storm/issues/events{/number}","events_url":"https://api.github.com/repos/apache/storm/events","assignees_url":"https://api.github.com/repos/apache/storm/assignees{/user}","branches_url":"https://api.github.com/repos/apache/storm/branches{/branch}","tags_url":"https://api.github.com/repos/apache/storm/tags","blobs_url":"https://api.github.com/repos/apache/storm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/storm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/storm/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/storm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/storm/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/storm/languages","stargazers_url":"https://api.github.com/repos/apache/storm/stargazers","contributors_url":"https://api.github.com/repos/apache/storm/contributors","subscribers_url":"https://api.github.com/repos/apache/storm/subscribers","subscription_url":"https://api.github.com/repos/apache/storm/subscription","commits_url":"https://api.github.com/repos/apache/storm/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/storm/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/storm/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/storm/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/storm/contents/{+path}","compare_url":"https://api.github.com/repos/apache/storm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/storm/merges","archive_url":"https://api.github.com/repos/apache/storm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/storm/downloads","issues_url":"https://api.github.com/repos/apache/storm/issues{/number}","pulls_url":"https://api.github.com/repos/apache/storm/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/storm/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/storm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/storm/labels{/name}","releases_url":"https://api.github.com/repos/apache/storm/releases{/id}","created_at":"2013-11-05T08:00:14Z","updated_at":"2015-10-02T19:28:57Z","pushed_at":"2015-10-02T20:22:07Z","git_url":"git://github.com/apache/storm.git","ssh_url":"git@github.com:apache/storm.git","clone_url":"https://github.com/apache/storm.git","svn_url":"https://github.com/apache/storm","homepage":null,"size":838877,"stargazers_count":2407,"watchers_count":2407,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1739,"mirror_url":"git://git.apache.org/incubator-storm.git","open_issues_count":92,"forks":1739,"open_issues":92,"watchers":2407,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/storm/pulls/780"},"html":{"href":"https://github.com/apache/storm/pull/780"},"issue":{"href":"https://api.github.com/repos/apache/storm/issues/780"},"comments":{"href":"https://api.github.com/repos/apache/storm/issues/780/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/storm/pulls/780/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/storm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/storm/pulls/780/commits"},"statuses":{"href":"https://api.github.com/repos/apache/storm/statuses/b7282b3a44ead4b20f9a5f2151ca1eba96f3abc8"}}}}