{"action":"created","issue":{"url":"https://api.github.com/repos/kaldi-asr/kaldi/issues/174","labels_url":"https://api.github.com/repos/kaldi-asr/kaldi/issues/174/labels{/name}","comments_url":"https://api.github.com/repos/kaldi-asr/kaldi/issues/174/comments","events_url":"https://api.github.com/repos/kaldi-asr/kaldi/issues/174/events","html_url":"https://github.com/kaldi-asr/kaldi/pull/174","id":107842446,"number":174,"title":"Removed AddNnet(delta_nnet_) call in NnetTrainer destructor. This was…","user":{"login":"vijayaditya","id":3895456,"avatar_url":"https://avatars.githubusercontent.com/u/3895456?v=3","gravatar_id":"","url":"https://api.github.com/users/vijayaditya","html_url":"https://github.com/vijayaditya","followers_url":"https://api.github.com/users/vijayaditya/followers","following_url":"https://api.github.com/users/vijayaditya/following{/other_user}","gists_url":"https://api.github.com/users/vijayaditya/gists{/gist_id}","starred_url":"https://api.github.com/users/vijayaditya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vijayaditya/subscriptions","organizations_url":"https://api.github.com/users/vijayaditya/orgs","repos_url":"https://api.github.com/users/vijayaditya/repos","events_url":"https://api.github.com/users/vijayaditya/events{/privacy}","received_events_url":"https://api.github.com/users/vijayaditya/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-09-23T03:20:09Z","updated_at":"2015-09-23T03:22:44Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kaldi-asr/kaldi/pulls/174","html_url":"https://github.com/kaldi-asr/kaldi/pull/174","diff_url":"https://github.com/kaldi-asr/kaldi/pull/174.diff","patch_url":"https://github.com/kaldi-asr/kaldi/pull/174.patch"},"body":"… critical for making momentum work."},"comment":{"url":"https://api.github.com/repos/kaldi-asr/kaldi/issues/comments/142479826","html_url":"https://github.com/kaldi-asr/kaldi/pull/174#issuecomment-142479826","issue_url":"https://api.github.com/repos/kaldi-asr/kaldi/issues/174","id":142479826,"user":{"login":"danpovey","id":3298747,"avatar_url":"https://avatars.githubusercontent.com/u/3298747?v=3","gravatar_id":"","url":"https://api.github.com/users/danpovey","html_url":"https://github.com/danpovey","followers_url":"https://api.github.com/users/danpovey/followers","following_url":"https://api.github.com/users/danpovey/following{/other_user}","gists_url":"https://api.github.com/users/danpovey/gists{/gist_id}","starred_url":"https://api.github.com/users/danpovey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danpovey/subscriptions","organizations_url":"https://api.github.com/users/danpovey/orgs","repos_url":"https://api.github.com/users/danpovey/repos","events_url":"https://api.github.com/users/danpovey/events{/privacy}","received_events_url":"https://api.github.com/users/danpovey/received_events","type":"User","site_admin":false},"created_at":"2015-09-23T03:22:44Z","updated_at":"2015-09-23T03:22:44Z","body":"would you mind removing the if-statement?\nrecently I had Ke remove all the if's before deletes, as C++ does that for\nyou.\nDan\n\n\nOn Tue, Sep 22, 2015 at 11:20 PM, Vijayaditya Peddinti <\nnotifications@github.com> wrote:\n\n> … critical for making momentum work.\n> ------------------------------\n> You can view, comment on, or merge this pull request online at:\n>\n>   https://github.com/kaldi-asr/kaldi/pull/174\n> Commit Summary\n>\n>    - Removed AddNnet(delta_nnet_) call in NnetTrainer destructor. This\n>    was critical for making momentum work.\n>\n> File Changes\n>\n>    - *M* src/nnet3/nnet-training.cc\n>    <https://github.com/kaldi-asr/kaldi/pull/174/files#diff-0> (7)\n>\n> Patch Links:\n>\n>    - https://github.com/kaldi-asr/kaldi/pull/174.patch\n>    - https://github.com/kaldi-asr/kaldi/pull/174.diff\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/kaldi-asr/kaldi/pull/174>.\n>\n"}}