{"action":"created","comment":{"url":"https://api.github.com/repos/hashicorp/terraform/pulls/comments/30132293","id":30132293,"diff_hunk":"@@ -38,13 +38,22 @@ func resourceAwsS3Bucket() *schema.Resource {\n \t\t\t\t\tSchema: map[string]*schema.Schema{\n \t\t\t\t\t\t\"index_document\": &schema.Schema{\n \t\t\t\t\t\t\tType:     schema.TypeString,\n-\t\t\t\t\t\t\tRequired: true,\n+\t\t\t\t\t\t\tOptional: true,\n \t\t\t\t\t\t},\n \n \t\t\t\t\t\t\"error_document\": &schema.Schema{\n \t\t\t\t\t\t\tType:     schema.TypeString,\n \t\t\t\t\t\t\tOptional: true,\n \t\t\t\t\t\t},\n+\n+\t\t\t\t\t\t\"redirect_all_requests_to\": &schema.Schema{\n+\t\t\t\t\t\t\tType: schema.TypeString,\n+\t\t\t\t\t\t\tConflictsWith: []string{\n+\t\t\t\t\t\t\t\t\"website.0.index_document\",\n+\t\t\t\t\t\t\t\t\"website.0.error_document\",\n+\t\t\t\t\t\t\t},","path":"builtin/providers/aws/resource_aws_s3_bucket.go","position":18,"original_position":18,"commit_id":"bbe00125f96b473193804e1fb21d6e67f2b0f1d8","original_commit_id":"bbe00125f96b473193804e1fb21d6e67f2b0f1d8","user":{"login":"justincampbell","id":246978,"avatar_url":"https://avatars.githubusercontent.com/u/246978?v=3","gravatar_id":"","url":"https://api.github.com/users/justincampbell","html_url":"https://github.com/justincampbell","followers_url":"https://api.github.com/users/justincampbell/followers","following_url":"https://api.github.com/users/justincampbell/following{/other_user}","gists_url":"https://api.github.com/users/justincampbell/gists{/gist_id}","starred_url":"https://api.github.com/users/justincampbell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justincampbell/subscriptions","organizations_url":"https://api.github.com/users/justincampbell/orgs","repos_url":"https://api.github.com/users/justincampbell/repos","events_url":"https://api.github.com/users/justincampbell/events{/privacy}","received_events_url":"https://api.github.com/users/justincampbell/received_events","type":"User","site_admin":false},"body":"The build is failing because `InternalValidate` in `helper/schema/schema.go` doesn't support this nested notation for `ConflictsWith`, even though in usage it seems to work correctly.","created_at":"2015-05-12T13:21:59Z","updated_at":"2015-05-12T13:21:59Z","html_url":"https://github.com/hashicorp/terraform/pull/1909#discussion_r30132293","pull_request_url":"https://api.github.com/repos/hashicorp/terraform/pulls/1909","_links":{"self":{"href":"https://api.github.com/repos/hashicorp/terraform/pulls/comments/30132293"},"html":{"href":"https://github.com/hashicorp/terraform/pull/1909#discussion_r30132293"},"pull_request":{"href":"https://api.github.com/repos/hashicorp/terraform/pulls/1909"}}},"pull_request":{"url":"https://api.github.com/repos/hashicorp/terraform/pulls/1909","id":35135272,"html_url":"https://github.com/hashicorp/terraform/pull/1909","diff_url":"https://github.com/hashicorp/terraform/pull/1909.diff","patch_url":"https://github.com/hashicorp/terraform/pull/1909.patch","issue_url":"https://api.github.com/repos/hashicorp/terraform/issues/1909","number":1909,"state":"open","locked":false,"title":"providers/aws: Add support for S3 website redirect","user":{"login":"justincampbell","id":246978,"avatar_url":"https://avatars.githubusercontent.com/u/246978?v=3","gravatar_id":"","url":"https://api.github.com/users/justincampbell","html_url":"https://github.com/justincampbell","followers_url":"https://api.github.com/users/justincampbell/followers","following_url":"https://api.github.com/users/justincampbell/following{/other_user}","gists_url":"https://api.github.com/users/justincampbell/gists{/gist_id}","starred_url":"https://api.github.com/users/justincampbell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justincampbell/subscriptions","organizations_url":"https://api.github.com/users/justincampbell/orgs","repos_url":"https://api.github.com/users/justincampbell/repos","events_url":"https://api.github.com/users/justincampbell/events{/privacy}","received_events_url":"https://api.github.com/users/justincampbell/received_events","type":"User","site_admin":false},"body":"This adds support for redirecting all requests for an S3 website endpoint to another hostname.\n\nThe API supports both a hostname and protocol, but this only adds the hostname field.","created_at":"2015-05-11T14:56:53Z","updated_at":"2015-05-12T13:21:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cee3a40e5405b15920ec7b612a8a13dcbe85f9b6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hashicorp/terraform/pulls/1909/commits","review_comments_url":"https://api.github.com/repos/hashicorp/terraform/pulls/1909/comments","review_comment_url":"https://api.github.com/repos/hashicorp/terraform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hashicorp/terraform/issues/1909/comments","statuses_url":"https://api.github.com/repos/hashicorp/terraform/statuses/bbe00125f96b473193804e1fb21d6e67f2b0f1d8","head":{"label":"justincampbell:s3-redirect","ref":"s3-redirect","sha":"bbe00125f96b473193804e1fb21d6e67f2b0f1d8","user":{"login":"justincampbell","id":246978,"avatar_url":"https://avatars.githubusercontent.com/u/246978?v=3","gravatar_id":"","url":"https://api.github.com/users/justincampbell","html_url":"https://github.com/justincampbell","followers_url":"https://api.github.com/users/justincampbell/followers","following_url":"https://api.github.com/users/justincampbell/following{/other_user}","gists_url":"https://api.github.com/users/justincampbell/gists{/gist_id}","starred_url":"https://api.github.com/users/justincampbell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justincampbell/subscriptions","organizations_url":"https://api.github.com/users/justincampbell/orgs","repos_url":"https://api.github.com/users/justincampbell/repos","events_url":"https://api.github.com/users/justincampbell/events{/privacy}","received_events_url":"https://api.github.com/users/justincampbell/received_events","type":"User","site_admin":false},"repo":{"id":34474877,"name":"terraform","full_name":"justincampbell/terraform","owner":{"login":"justincampbell","id":246978,"avatar_url":"https://avatars.githubusercontent.com/u/246978?v=3","gravatar_id":"","url":"https://api.github.com/users/justincampbell","html_url":"https://github.com/justincampbell","followers_url":"https://api.github.com/users/justincampbell/followers","following_url":"https://api.github.com/users/justincampbell/following{/other_user}","gists_url":"https://api.github.com/users/justincampbell/gists{/gist_id}","starred_url":"https://api.github.com/users/justincampbell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justincampbell/subscriptions","organizations_url":"https://api.github.com/users/justincampbell/orgs","repos_url":"https://api.github.com/users/justincampbell/repos","events_url":"https://api.github.com/users/justincampbell/events{/privacy}","received_events_url":"https://api.github.com/users/justincampbell/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/justincampbell/terraform","description":"Terraform is a tool for building, changing, and combining infrastructure safely and efficiently.","fork":true,"url":"https://api.github.com/repos/justincampbell/terraform","forks_url":"https://api.github.com/repos/justincampbell/terraform/forks","keys_url":"https://api.github.com/repos/justincampbell/terraform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/justincampbell/terraform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/justincampbell/terraform/teams","hooks_url":"https://api.github.com/repos/justincampbell/terraform/hooks","issue_events_url":"https://api.github.com/repos/justincampbell/terraform/issues/events{/number}","events_url":"https://api.github.com/repos/justincampbell/terraform/events","assignees_url":"https://api.github.com/repos/justincampbell/terraform/assignees{/user}","branches_url":"https://api.github.com/repos/justincampbell/terraform/branches{/branch}","tags_url":"https://api.github.com/repos/justincampbell/terraform/tags","blobs_url":"https://api.github.com/repos/justincampbell/terraform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/justincampbell/terraform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/justincampbell/terraform/git/refs{/sha}","trees_url":"https://api.github.com/repos/justincampbell/terraform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/justincampbell/terraform/statuses/{sha}","languages_url":"https://api.github.com/repos/justincampbell/terraform/languages","stargazers_url":"https://api.github.com/repos/justincampbell/terraform/stargazers","contributors_url":"https://api.github.com/repos/justincampbell/terraform/contributors","subscribers_url":"https://api.github.com/repos/justincampbell/terraform/subscribers","subscription_url":"https://api.github.com/repos/justincampbell/terraform/subscription","commits_url":"https://api.github.com/repos/justincampbell/terraform/commits{/sha}","git_commits_url":"https://api.github.com/repos/justincampbell/terraform/git/commits{/sha}","comments_url":"https://api.github.com/repos/justincampbell/terraform/comments{/number}","issue_comment_url":"https://api.github.com/repos/justincampbell/terraform/issues/comments{/number}","contents_url":"https://api.github.com/repos/justincampbell/terraform/contents/{+path}","compare_url":"https://api.github.com/repos/justincampbell/terraform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/justincampbell/terraform/merges","archive_url":"https://api.github.com/repos/justincampbell/terraform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/justincampbell/terraform/downloads","issues_url":"https://api.github.com/repos/justincampbell/terraform/issues{/number}","pulls_url":"https://api.github.com/repos/justincampbell/terraform/pulls{/number}","milestones_url":"https://api.github.com/repos/justincampbell/terraform/milestones{/number}","notifications_url":"https://api.github.com/repos/justincampbell/terraform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/justincampbell/terraform/labels{/name}","releases_url":"https://api.github.com/repos/justincampbell/terraform/releases{/id}","created_at":"2015-04-23T18:44:18Z","updated_at":"2015-05-07T14:51:56Z","pushed_at":"2015-05-11T19:22:32Z","git_url":"git://github.com/justincampbell/terraform.git","ssh_url":"git@github.com:justincampbell/terraform.git","clone_url":"https://github.com/justincampbell/terraform.git","svn_url":"https://github.com/justincampbell/terraform","homepage":"http://www.terraform.io","size":22557,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hashicorp:master","ref":"master","sha":"72afc6b31fc1834cd79e43bad50e8ab9df9f3498","user":{"login":"hashicorp","id":761456,"avatar_url":"https://avatars.githubusercontent.com/u/761456?v=3","gravatar_id":"","url":"https://api.github.com/users/hashicorp","html_url":"https://github.com/hashicorp","followers_url":"https://api.github.com/users/hashicorp/followers","following_url":"https://api.github.com/users/hashicorp/following{/other_user}","gists_url":"https://api.github.com/users/hashicorp/gists{/gist_id}","starred_url":"https://api.github.com/users/hashicorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hashicorp/subscriptions","organizations_url":"https://api.github.com/users/hashicorp/orgs","repos_url":"https://api.github.com/users/hashicorp/repos","events_url":"https://api.github.com/users/hashicorp/events{/privacy}","received_events_url":"https://api.github.com/users/hashicorp/received_events","type":"Organization","site_admin":false},"repo":{"id":17728164,"name":"terraform","full_name":"hashicorp/terraform","owner":{"login":"hashicorp","id":761456,"avatar_url":"https://avatars.githubusercontent.com/u/761456?v=3","gravatar_id":"","url":"https://api.github.com/users/hashicorp","html_url":"https://github.com/hashicorp","followers_url":"https://api.github.com/users/hashicorp/followers","following_url":"https://api.github.com/users/hashicorp/following{/other_user}","gists_url":"https://api.github.com/users/hashicorp/gists{/gist_id}","starred_url":"https://api.github.com/users/hashicorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hashicorp/subscriptions","organizations_url":"https://api.github.com/users/hashicorp/orgs","repos_url":"https://api.github.com/users/hashicorp/repos","events_url":"https://api.github.com/users/hashicorp/events{/privacy}","received_events_url":"https://api.github.com/users/hashicorp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hashicorp/terraform","description":"Terraform is a tool for building, changing, and combining infrastructure safely and efficiently.","fork":false,"url":"https://api.github.com/repos/hashicorp/terraform","forks_url":"https://api.github.com/repos/hashicorp/terraform/forks","keys_url":"https://api.github.com/repos/hashicorp/terraform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hashicorp/terraform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hashicorp/terraform/teams","hooks_url":"https://api.github.com/repos/hashicorp/terraform/hooks","issue_events_url":"https://api.github.com/repos/hashicorp/terraform/issues/events{/number}","events_url":"https://api.github.com/repos/hashicorp/terraform/events","assignees_url":"https://api.github.com/repos/hashicorp/terraform/assignees{/user}","branches_url":"https://api.github.com/repos/hashicorp/terraform/branches{/branch}","tags_url":"https://api.github.com/repos/hashicorp/terraform/tags","blobs_url":"https://api.github.com/repos/hashicorp/terraform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hashicorp/terraform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hashicorp/terraform/git/refs{/sha}","trees_url":"https://api.github.com/repos/hashicorp/terraform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hashicorp/terraform/statuses/{sha}","languages_url":"https://api.github.com/repos/hashicorp/terraform/languages","stargazers_url":"https://api.github.com/repos/hashicorp/terraform/stargazers","contributors_url":"https://api.github.com/repos/hashicorp/terraform/contributors","subscribers_url":"https://api.github.com/repos/hashicorp/terraform/subscribers","subscription_url":"https://api.github.com/repos/hashicorp/terraform/subscription","commits_url":"https://api.github.com/repos/hashicorp/terraform/commits{/sha}","git_commits_url":"https://api.github.com/repos/hashicorp/terraform/git/commits{/sha}","comments_url":"https://api.github.com/repos/hashicorp/terraform/comments{/number}","issue_comment_url":"https://api.github.com/repos/hashicorp/terraform/issues/comments{/number}","contents_url":"https://api.github.com/repos/hashicorp/terraform/contents/{+path}","compare_url":"https://api.github.com/repos/hashicorp/terraform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hashicorp/terraform/merges","archive_url":"https://api.github.com/repos/hashicorp/terraform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hashicorp/terraform/downloads","issues_url":"https://api.github.com/repos/hashicorp/terraform/issues{/number}","pulls_url":"https://api.github.com/repos/hashicorp/terraform/pulls{/number}","milestones_url":"https://api.github.com/repos/hashicorp/terraform/milestones{/number}","notifications_url":"https://api.github.com/repos/hashicorp/terraform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hashicorp/terraform/labels{/name}","releases_url":"https://api.github.com/repos/hashicorp/terraform/releases{/id}","created_at":"2014-03-13T22:25:48Z","updated_at":"2015-05-12T09:28:20Z","pushed_at":"2015-05-12T08:37:43Z","git_url":"git://github.com/hashicorp/terraform.git","ssh_url":"git@github.com:hashicorp/terraform.git","clone_url":"https://github.com/hashicorp/terraform.git","svn_url":"https://github.com/hashicorp/terraform","homepage":"http://www.terraform.io","size":47618,"stargazers_count":2377,"watchers_count":2377,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":421,"mirror_url":null,"open_issues_count":265,"forks":421,"open_issues":265,"watchers":2377,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hashicorp/terraform/pulls/1909"},"html":{"href":"https://github.com/hashicorp/terraform/pull/1909"},"issue":{"href":"https://api.github.com/repos/hashicorp/terraform/issues/1909"},"comments":{"href":"https://api.github.com/repos/hashicorp/terraform/issues/1909/comments"},"review_comments":{"href":"https://api.github.com/repos/hashicorp/terraform/pulls/1909/comments"},"review_comment":{"href":"https://api.github.com/repos/hashicorp/terraform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hashicorp/terraform/pulls/1909/commits"},"statuses":{"href":"https://api.github.com/repos/hashicorp/terraform/statuses/bbe00125f96b473193804e1fb21d6e67f2b0f1d8"}}}}