{"action":"closed","number":4,"pull_request":{"url":"https://api.github.com/repos/portablejim/curseDownloader/pulls/4","id":38891418,"html_url":"https://github.com/portablejim/curseDownloader/pull/4","diff_url":"https://github.com/portablejim/curseDownloader/pull/4.diff","patch_url":"https://github.com/portablejim/curseDownloader/pull/4.patch","issue_url":"https://api.github.com/repos/portablejim/curseDownloader/issues/4","number":4,"state":"closed","locked":false,"title":"Use urllib.parse.unquote for unquoting url. And attempt to fix some dependency issue.","user":{"login":"Holi0317","id":6838982,"avatar_url":"https://avatars.githubusercontent.com/u/6838982?v=3","gravatar_id":"","url":"https://api.github.com/users/Holi0317","html_url":"https://github.com/Holi0317","followers_url":"https://api.github.com/users/Holi0317/followers","following_url":"https://api.github.com/users/Holi0317/following{/other_user}","gists_url":"https://api.github.com/users/Holi0317/gists{/gist_id}","starred_url":"https://api.github.com/users/Holi0317/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Holi0317/subscriptions","organizations_url":"https://api.github.com/users/Holi0317/orgs","repos_url":"https://api.github.com/users/Holi0317/repos","events_url":"https://api.github.com/users/Holi0317/events{/privacy}","received_events_url":"https://api.github.com/users/Holi0317/received_events","type":"User","site_admin":false},"body":"In this pull requests, I have done the following.\r\n\r\n1. Use urllib.parse.unquote to unquote file name in variable fileName. Originally, only `%20` can be converted. After this change, all quoted url can be unquoted. Although it is not common to see any special character in Minecraft mods file name, this is the right way to unquote paths.\r\n2. Add .gitignore. I found out git is tracking my env file when I was testing. I think you should take a look at [this](http://www.dabapps.com/blog/introduction-to-pip-and-virtualenv-python/)\r\n3. Added dependency to setup.py. There are four depending packages but they were not listed. This does NOT add cx_freeze to dependency as adding it requires changing setup.py a lot.","created_at":"2015-06-30T15:33:51Z","updated_at":"2015-07-01T11:47:40Z","closed_at":"2015-07-01T11:47:40Z","merged_at":"2015-07-01T11:47:40Z","merge_commit_sha":"efee7dbca8547ad45b3eba4ad3efc46c6e1a79bf","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/portablejim/curseDownloader/pulls/4/commits","review_comments_url":"https://api.github.com/repos/portablejim/curseDownloader/pulls/4/comments","review_comment_url":"https://api.github.com/repos/portablejim/curseDownloader/pulls/comments{/number}","comments_url":"https://api.github.com/repos/portablejim/curseDownloader/issues/4/comments","statuses_url":"https://api.github.com/repos/portablejim/curseDownloader/statuses/071916a85d64b5322c2ceefae8eb34f1d494a94f","head":{"label":"Holi0317:master","ref":"master","sha":"071916a85d64b5322c2ceefae8eb34f1d494a94f","user":{"login":"Holi0317","id":6838982,"avatar_url":"https://avatars.githubusercontent.com/u/6838982?v=3","gravatar_id":"","url":"https://api.github.com/users/Holi0317","html_url":"https://github.com/Holi0317","followers_url":"https://api.github.com/users/Holi0317/followers","following_url":"https://api.github.com/users/Holi0317/following{/other_user}","gists_url":"https://api.github.com/users/Holi0317/gists{/gist_id}","starred_url":"https://api.github.com/users/Holi0317/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Holi0317/subscriptions","organizations_url":"https://api.github.com/users/Holi0317/orgs","repos_url":"https://api.github.com/users/Holi0317/repos","events_url":"https://api.github.com/users/Holi0317/events{/privacy}","received_events_url":"https://api.github.com/users/Holi0317/received_events","type":"User","site_admin":false},"repo":{"id":38315169,"name":"curseDownloader","full_name":"Holi0317/curseDownloader","owner":{"login":"Holi0317","id":6838982,"avatar_url":"https://avatars.githubusercontent.com/u/6838982?v=3","gravatar_id":"","url":"https://api.github.com/users/Holi0317","html_url":"https://github.com/Holi0317","followers_url":"https://api.github.com/users/Holi0317/followers","following_url":"https://api.github.com/users/Holi0317/following{/other_user}","gists_url":"https://api.github.com/users/Holi0317/gists{/gist_id}","starred_url":"https://api.github.com/users/Holi0317/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Holi0317/subscriptions","organizations_url":"https://api.github.com/users/Holi0317/orgs","repos_url":"https://api.github.com/users/Holi0317/repos","events_url":"https://api.github.com/users/Holi0317/events{/privacy}","received_events_url":"https://api.github.com/users/Holi0317/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Holi0317/curseDownloader","description":"Curse Modpack downloader","fork":true,"url":"https://api.github.com/repos/Holi0317/curseDownloader","forks_url":"https://api.github.com/repos/Holi0317/curseDownloader/forks","keys_url":"https://api.github.com/repos/Holi0317/curseDownloader/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Holi0317/curseDownloader/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Holi0317/curseDownloader/teams","hooks_url":"https://api.github.com/repos/Holi0317/curseDownloader/hooks","issue_events_url":"https://api.github.com/repos/Holi0317/curseDownloader/issues/events{/number}","events_url":"https://api.github.com/repos/Holi0317/curseDownloader/events","assignees_url":"https://api.github.com/repos/Holi0317/curseDownloader/assignees{/user}","branches_url":"https://api.github.com/repos/Holi0317/curseDownloader/branches{/branch}","tags_url":"https://api.github.com/repos/Holi0317/curseDownloader/tags","blobs_url":"https://api.github.com/repos/Holi0317/curseDownloader/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Holi0317/curseDownloader/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Holi0317/curseDownloader/git/refs{/sha}","trees_url":"https://api.github.com/repos/Holi0317/curseDownloader/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Holi0317/curseDownloader/statuses/{sha}","languages_url":"https://api.github.com/repos/Holi0317/curseDownloader/languages","stargazers_url":"https://api.github.com/repos/Holi0317/curseDownloader/stargazers","contributors_url":"https://api.github.com/repos/Holi0317/curseDownloader/contributors","subscribers_url":"https://api.github.com/repos/Holi0317/curseDownloader/subscribers","subscription_url":"https://api.github.com/repos/Holi0317/curseDownloader/subscription","commits_url":"https://api.github.com/repos/Holi0317/curseDownloader/commits{/sha}","git_commits_url":"https://api.github.com/repos/Holi0317/curseDownloader/git/commits{/sha}","comments_url":"https://api.github.com/repos/Holi0317/curseDownloader/comments{/number}","issue_comment_url":"https://api.github.com/repos/Holi0317/curseDownloader/issues/comments{/number}","contents_url":"https://api.github.com/repos/Holi0317/curseDownloader/contents/{+path}","compare_url":"https://api.github.com/repos/Holi0317/curseDownloader/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Holi0317/curseDownloader/merges","archive_url":"https://api.github.com/repos/Holi0317/curseDownloader/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Holi0317/curseDownloader/downloads","issues_url":"https://api.github.com/repos/Holi0317/curseDownloader/issues{/number}","pulls_url":"https://api.github.com/repos/Holi0317/curseDownloader/pulls{/number}","milestones_url":"https://api.github.com/repos/Holi0317/curseDownloader/milestones{/number}","notifications_url":"https://api.github.com/repos/Holi0317/curseDownloader/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Holi0317/curseDownloader/labels{/name}","releases_url":"https://api.github.com/repos/Holi0317/curseDownloader/releases{/id}","created_at":"2015-06-30T14:50:14Z","updated_at":"2015-06-30T14:50:14Z","pushed_at":"2015-06-30T15:23:37Z","git_url":"git://github.com/Holi0317/curseDownloader.git","ssh_url":"git@github.com:Holi0317/curseDownloader.git","clone_url":"https://github.com/Holi0317/curseDownloader.git","svn_url":"https://github.com/Holi0317/curseDownloader","homepage":null,"size":232,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"portablejim:master","ref":"master","sha":"0bcacd430a5bb6398175f8356c13e04e59ba4313","user":{"login":"portablejim","id":339225,"avatar_url":"https://avatars.githubusercontent.com/u/339225?v=3","gravatar_id":"","url":"https://api.github.com/users/portablejim","html_url":"https://github.com/portablejim","followers_url":"https://api.github.com/users/portablejim/followers","following_url":"https://api.github.com/users/portablejim/following{/other_user}","gists_url":"https://api.github.com/users/portablejim/gists{/gist_id}","starred_url":"https://api.github.com/users/portablejim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/portablejim/subscriptions","organizations_url":"https://api.github.com/users/portablejim/orgs","repos_url":"https://api.github.com/users/portablejim/repos","events_url":"https://api.github.com/users/portablejim/events{/privacy}","received_events_url":"https://api.github.com/users/portablejim/received_events","type":"User","site_admin":false},"repo":{"id":32616964,"name":"curseDownloader","full_name":"portablejim/curseDownloader","owner":{"login":"portablejim","id":339225,"avatar_url":"https://avatars.githubusercontent.com/u/339225?v=3","gravatar_id":"","url":"https://api.github.com/users/portablejim","html_url":"https://github.com/portablejim","followers_url":"https://api.github.com/users/portablejim/followers","following_url":"https://api.github.com/users/portablejim/following{/other_user}","gists_url":"https://api.github.com/users/portablejim/gists{/gist_id}","starred_url":"https://api.github.com/users/portablejim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/portablejim/subscriptions","organizations_url":"https://api.github.com/users/portablejim/orgs","repos_url":"https://api.github.com/users/portablejim/repos","events_url":"https://api.github.com/users/portablejim/events{/privacy}","received_events_url":"https://api.github.com/users/portablejim/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/portablejim/curseDownloader","description":"Curse Modpack downloader","fork":false,"url":"https://api.github.com/repos/portablejim/curseDownloader","forks_url":"https://api.github.com/repos/portablejim/curseDownloader/forks","keys_url":"https://api.github.com/repos/portablejim/curseDownloader/keys{/key_id}","collaborators_url":"https://api.github.com/repos/portablejim/curseDownloader/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/portablejim/curseDownloader/teams","hooks_url":"https://api.github.com/repos/portablejim/curseDownloader/hooks","issue_events_url":"https://api.github.com/repos/portablejim/curseDownloader/issues/events{/number}","events_url":"https://api.github.com/repos/portablejim/curseDownloader/events","assignees_url":"https://api.github.com/repos/portablejim/curseDownloader/assignees{/user}","branches_url":"https://api.github.com/repos/portablejim/curseDownloader/branches{/branch}","tags_url":"https://api.github.com/repos/portablejim/curseDownloader/tags","blobs_url":"https://api.github.com/repos/portablejim/curseDownloader/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/portablejim/curseDownloader/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/portablejim/curseDownloader/git/refs{/sha}","trees_url":"https://api.github.com/repos/portablejim/curseDownloader/git/trees{/sha}","statuses_url":"https://api.github.com/repos/portablejim/curseDownloader/statuses/{sha}","languages_url":"https://api.github.com/repos/portablejim/curseDownloader/languages","stargazers_url":"https://api.github.com/repos/portablejim/curseDownloader/stargazers","contributors_url":"https://api.github.com/repos/portablejim/curseDownloader/contributors","subscribers_url":"https://api.github.com/repos/portablejim/curseDownloader/subscribers","subscription_url":"https://api.github.com/repos/portablejim/curseDownloader/subscription","commits_url":"https://api.github.com/repos/portablejim/curseDownloader/commits{/sha}","git_commits_url":"https://api.github.com/repos/portablejim/curseDownloader/git/commits{/sha}","comments_url":"https://api.github.com/repos/portablejim/curseDownloader/comments{/number}","issue_comment_url":"https://api.github.com/repos/portablejim/curseDownloader/issues/comments{/number}","contents_url":"https://api.github.com/repos/portablejim/curseDownloader/contents/{+path}","compare_url":"https://api.github.com/repos/portablejim/curseDownloader/compare/{base}...{head}","merges_url":"https://api.github.com/repos/portablejim/curseDownloader/merges","archive_url":"https://api.github.com/repos/portablejim/curseDownloader/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/portablejim/curseDownloader/downloads","issues_url":"https://api.github.com/repos/portablejim/curseDownloader/issues{/number}","pulls_url":"https://api.github.com/repos/portablejim/curseDownloader/pulls{/number}","milestones_url":"https://api.github.com/repos/portablejim/curseDownloader/milestones{/number}","notifications_url":"https://api.github.com/repos/portablejim/curseDownloader/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/portablejim/curseDownloader/labels{/name}","releases_url":"https://api.github.com/repos/portablejim/curseDownloader/releases{/id}","created_at":"2015-03-21T02:29:08Z","updated_at":"2015-05-31T21:26:51Z","pushed_at":"2015-07-01T11:47:40Z","git_url":"git://github.com/portablejim/curseDownloader.git","ssh_url":"git@github.com:portablejim/curseDownloader.git","clone_url":"https://github.com/portablejim/curseDownloader.git","svn_url":"https://github.com/portablejim/curseDownloader","homepage":null,"size":298,"stargazers_count":29,"watchers_count":29,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":1,"forks":6,"open_issues":1,"watchers":29,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/portablejim/curseDownloader/pulls/4"},"html":{"href":"https://github.com/portablejim/curseDownloader/pull/4"},"issue":{"href":"https://api.github.com/repos/portablejim/curseDownloader/issues/4"},"comments":{"href":"https://api.github.com/repos/portablejim/curseDownloader/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/portablejim/curseDownloader/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/portablejim/curseDownloader/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/portablejim/curseDownloader/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/portablejim/curseDownloader/statuses/071916a85d64b5322c2ceefae8eb34f1d494a94f"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"portablejim","id":339225,"avatar_url":"https://avatars.githubusercontent.com/u/339225?v=3","gravatar_id":"","url":"https://api.github.com/users/portablejim","html_url":"https://github.com/portablejim","followers_url":"https://api.github.com/users/portablejim/followers","following_url":"https://api.github.com/users/portablejim/following{/other_user}","gists_url":"https://api.github.com/users/portablejim/gists{/gist_id}","starred_url":"https://api.github.com/users/portablejim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/portablejim/subscriptions","organizations_url":"https://api.github.com/users/portablejim/orgs","repos_url":"https://api.github.com/users/portablejim/repos","events_url":"https://api.github.com/users/portablejim/events{/privacy}","received_events_url":"https://api.github.com/users/portablejim/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":4,"additions":70,"deletions":8,"changed_files":3}}