{"action":"created","comment":{"url":"https://api.github.com/repos/spring-projects/spring-xd/pulls/comments/28854765","id":28854765,"diff_hunk":"@@ -139,10 +151,35 @@ public NettyHttpInboundChannelAdapter(int port) {\n \t}\n \n \tpublic NettyHttpInboundChannelAdapter(int port, boolean ssl) {\n+\t\t/* begin whu */\n+\t\tthis(port, \"/\", ssl);\n+\t\t/* end whu */\n+\t}\n+\n+\t/* begin whu */\n+\tpublic NettyHttpInboundChannelAdapter(int port, String path) {\n+\t\tthis(port, path, false);\n+\t}\n+\n+\tpublic NettyHttpInboundChannelAdapter(int port, String path, boolean ssl) {\n \t\tthis.port = port;\n \t\tthis.ssl = ssl;\n+\t\tthis.path = path;\n+\t\tputToChannelAdapter();\n \t}\n \n+\tprivate void putToChannelAdapter() {","path":"extensions/spring-xd-extension-http/src/main/java/org/springframework/integration/x/http/NettyHttpInboundChannelAdapter.java","position":49,"original_position":49,"commit_id":"4ad1618b1ca4ee01641a29d8b24590e51bbf0e5c","original_commit_id":"4ad1618b1ca4ee01641a29d8b24590e51bbf0e5c","user":{"login":"garyrussell","id":483832,"avatar_url":"https://avatars.githubusercontent.com/u/483832?v=3","gravatar_id":"","url":"https://api.github.com/users/garyrussell","html_url":"https://github.com/garyrussell","followers_url":"https://api.github.com/users/garyrussell/followers","following_url":"https://api.github.com/users/garyrussell/following{/other_user}","gists_url":"https://api.github.com/users/garyrussell/gists{/gist_id}","starred_url":"https://api.github.com/users/garyrussell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garyrussell/subscriptions","organizations_url":"https://api.github.com/users/garyrussell/orgs","repos_url":"https://api.github.com/users/garyrussell/repos","events_url":"https://api.github.com/users/garyrussell/events{/privacy}","received_events_url":"https://api.github.com/users/garyrussell/received_events","type":"User","site_admin":false},"body":"Although deployments are currently single-threaded, it would be safer to synchronize this method.\r\n\r\nAlso, perhaps something like `ensurePathIsUnique()` would be a more suitable method name.","created_at":"2015-04-22T09:00:03Z","updated_at":"2015-04-22T09:00:03Z","html_url":"https://github.com/spring-projects/spring-xd/pull/1538#discussion_r28854765","pull_request_url":"https://api.github.com/repos/spring-projects/spring-xd/pulls/1538","_links":{"self":{"href":"https://api.github.com/repos/spring-projects/spring-xd/pulls/comments/28854765"},"html":{"href":"https://github.com/spring-projects/spring-xd/pull/1538#discussion_r28854765"},"pull_request":{"href":"https://api.github.com/repos/spring-projects/spring-xd/pulls/1538"}}},"pull_request":{"url":"https://api.github.com/repos/spring-projects/spring-xd/pulls/1538","id":32548623,"html_url":"https://github.com/spring-projects/spring-xd/pull/1538","diff_url":"https://github.com/spring-projects/spring-xd/pull/1538.diff","patch_url":"https://github.com/spring-projects/spring-xd/pull/1538.patch","issue_url":"https://api.github.com/repos/spring-projects/spring-xd/issues/1538","number":1538,"state":"open","locked":false,"title":"Allow \"--path=...\" configuration in HTTP channel adapter","user":{"login":"whummer","id":2807888,"avatar_url":"https://avatars.githubusercontent.com/u/2807888?v=3","gravatar_id":"","url":"https://api.github.com/users/whummer","html_url":"https://github.com/whummer","followers_url":"https://api.github.com/users/whummer/followers","following_url":"https://api.github.com/users/whummer/following{/other_user}","gists_url":"https://api.github.com/users/whummer/gists{/gist_id}","starred_url":"https://api.github.com/users/whummer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whummer/subscriptions","organizations_url":"https://api.github.com/users/whummer/orgs","repos_url":"https://api.github.com/users/whummer/repos","events_url":"https://api.github.com/users/whummer/events{/privacy}","received_events_url":"https://api.github.com/users/whummer/received_events","type":"User","site_admin":false},"body":"Currently, each HTTP stream channel uses its own port, which is a limitation if we want to use large numbers of HTTP streams with fine granularity. It would be nice to (additionally) use URI paths to identify HTTP channels, allowing to re-use a single HTTP port for multiple channels in XD. \r\n\r\nExample usage:\r\n```\r\nstream create --name s1 --definition \"http --port=9495 --path=/foo  | log\" --deploy\r\n```\r\n\r\nThis pull request contains a working proof-of-concept implementation, including a set of simple integration tests. \r\n\r\nAny comments/suggestions welcome! Thanks","created_at":"2015-04-02T20:46:03Z","updated_at":"2015-04-22T09:00:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"288d212d2f3de978c85380bb2e286ef41a0cf0d6","assignee":{"login":"garyrussell","id":483832,"avatar_url":"https://avatars.githubusercontent.com/u/483832?v=3","gravatar_id":"","url":"https://api.github.com/users/garyrussell","html_url":"https://github.com/garyrussell","followers_url":"https://api.github.com/users/garyrussell/followers","following_url":"https://api.github.com/users/garyrussell/following{/other_user}","gists_url":"https://api.github.com/users/garyrussell/gists{/gist_id}","starred_url":"https://api.github.com/users/garyrussell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garyrussell/subscriptions","organizations_url":"https://api.github.com/users/garyrussell/orgs","repos_url":"https://api.github.com/users/garyrussell/repos","events_url":"https://api.github.com/users/garyrussell/events{/privacy}","received_events_url":"https://api.github.com/users/garyrussell/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/spring-projects/spring-xd/pulls/1538/commits","review_comments_url":"https://api.github.com/repos/spring-projects/spring-xd/pulls/1538/comments","review_comment_url":"https://api.github.com/repos/spring-projects/spring-xd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spring-projects/spring-xd/issues/1538/comments","statuses_url":"https://api.github.com/repos/spring-projects/spring-xd/statuses/4ad1618b1ca4ee01641a29d8b24590e51bbf0e5c","head":{"label":"whummer:master","ref":"master","sha":"4ad1618b1ca4ee01641a29d8b24590e51bbf0e5c","user":{"login":"whummer","id":2807888,"avatar_url":"https://avatars.githubusercontent.com/u/2807888?v=3","gravatar_id":"","url":"https://api.github.com/users/whummer","html_url":"https://github.com/whummer","followers_url":"https://api.github.com/users/whummer/followers","following_url":"https://api.github.com/users/whummer/following{/other_user}","gists_url":"https://api.github.com/users/whummer/gists{/gist_id}","starred_url":"https://api.github.com/users/whummer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whummer/subscriptions","organizations_url":"https://api.github.com/users/whummer/orgs","repos_url":"https://api.github.com/users/whummer/repos","events_url":"https://api.github.com/users/whummer/events{/privacy}","received_events_url":"https://api.github.com/users/whummer/received_events","type":"User","site_admin":false},"repo":{"id":33273680,"name":"spring-xd","full_name":"whummer/spring-xd","owner":{"login":"whummer","id":2807888,"avatar_url":"https://avatars.githubusercontent.com/u/2807888?v=3","gravatar_id":"","url":"https://api.github.com/users/whummer","html_url":"https://github.com/whummer","followers_url":"https://api.github.com/users/whummer/followers","following_url":"https://api.github.com/users/whummer/following{/other_user}","gists_url":"https://api.github.com/users/whummer/gists{/gist_id}","starred_url":"https://api.github.com/users/whummer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whummer/subscriptions","organizations_url":"https://api.github.com/users/whummer/orgs","repos_url":"https://api.github.com/users/whummer/repos","events_url":"https://api.github.com/users/whummer/events{/privacy}","received_events_url":"https://api.github.com/users/whummer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/whummer/spring-xd","description":"Spring XD makes it easy to solve common big data problems such as data ingestion and export, real-time analytics, and batch workflow orchestration","fork":true,"url":"https://api.github.com/repos/whummer/spring-xd","forks_url":"https://api.github.com/repos/whummer/spring-xd/forks","keys_url":"https://api.github.com/repos/whummer/spring-xd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/whummer/spring-xd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/whummer/spring-xd/teams","hooks_url":"https://api.github.com/repos/whummer/spring-xd/hooks","issue_events_url":"https://api.github.com/repos/whummer/spring-xd/issues/events{/number}","events_url":"https://api.github.com/repos/whummer/spring-xd/events","assignees_url":"https://api.github.com/repos/whummer/spring-xd/assignees{/user}","branches_url":"https://api.github.com/repos/whummer/spring-xd/branches{/branch}","tags_url":"https://api.github.com/repos/whummer/spring-xd/tags","blobs_url":"https://api.github.com/repos/whummer/spring-xd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/whummer/spring-xd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/whummer/spring-xd/git/refs{/sha}","trees_url":"https://api.github.com/repos/whummer/spring-xd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/whummer/spring-xd/statuses/{sha}","languages_url":"https://api.github.com/repos/whummer/spring-xd/languages","stargazers_url":"https://api.github.com/repos/whummer/spring-xd/stargazers","contributors_url":"https://api.github.com/repos/whummer/spring-xd/contributors","subscribers_url":"https://api.github.com/repos/whummer/spring-xd/subscribers","subscription_url":"https://api.github.com/repos/whummer/spring-xd/subscription","commits_url":"https://api.github.com/repos/whummer/spring-xd/commits{/sha}","git_commits_url":"https://api.github.com/repos/whummer/spring-xd/git/commits{/sha}","comments_url":"https://api.github.com/repos/whummer/spring-xd/comments{/number}","issue_comment_url":"https://api.github.com/repos/whummer/spring-xd/issues/comments{/number}","contents_url":"https://api.github.com/repos/whummer/spring-xd/contents/{+path}","compare_url":"https://api.github.com/repos/whummer/spring-xd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/whummer/spring-xd/merges","archive_url":"https://api.github.com/repos/whummer/spring-xd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/whummer/spring-xd/downloads","issues_url":"https://api.github.com/repos/whummer/spring-xd/issues{/number}","pulls_url":"https://api.github.com/repos/whummer/spring-xd/pulls{/number}","milestones_url":"https://api.github.com/repos/whummer/spring-xd/milestones{/number}","notifications_url":"https://api.github.com/repos/whummer/spring-xd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/whummer/spring-xd/labels{/name}","releases_url":"https://api.github.com/repos/whummer/spring-xd/releases{/id}","created_at":"2015-04-01T21:21:49Z","updated_at":"2015-04-02T20:43:54Z","pushed_at":"2015-04-02T20:43:52Z","git_url":"git://github.com/whummer/spring-xd.git","ssh_url":"git@github.com:whummer/spring-xd.git","clone_url":"https://github.com/whummer/spring-xd.git","svn_url":"https://github.com/whummer/spring-xd","homepage":"http://projects.spring.io/spring-xd","size":22285,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spring-projects:master","ref":"master","sha":"8c2c0216e848e8d6278118d8094871f22bca8392","user":{"login":"spring-projects","id":317776,"avatar_url":"https://avatars.githubusercontent.com/u/317776?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-projects","html_url":"https://github.com/spring-projects","followers_url":"https://api.github.com/users/spring-projects/followers","following_url":"https://api.github.com/users/spring-projects/following{/other_user}","gists_url":"https://api.github.com/users/spring-projects/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-projects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-projects/subscriptions","organizations_url":"https://api.github.com/users/spring-projects/orgs","repos_url":"https://api.github.com/users/spring-projects/repos","events_url":"https://api.github.com/users/spring-projects/events{/privacy}","received_events_url":"https://api.github.com/users/spring-projects/received_events","type":"Organization","site_admin":false},"repo":{"id":9349347,"name":"spring-xd","full_name":"spring-projects/spring-xd","owner":{"login":"spring-projects","id":317776,"avatar_url":"https://avatars.githubusercontent.com/u/317776?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-projects","html_url":"https://github.com/spring-projects","followers_url":"https://api.github.com/users/spring-projects/followers","following_url":"https://api.github.com/users/spring-projects/following{/other_user}","gists_url":"https://api.github.com/users/spring-projects/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-projects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-projects/subscriptions","organizations_url":"https://api.github.com/users/spring-projects/orgs","repos_url":"https://api.github.com/users/spring-projects/repos","events_url":"https://api.github.com/users/spring-projects/events{/privacy}","received_events_url":"https://api.github.com/users/spring-projects/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spring-projects/spring-xd","description":"Spring XD makes it easy to solve common big data problems such as data ingestion and export, real-time analytics, and batch workflow orchestration","fork":false,"url":"https://api.github.com/repos/spring-projects/spring-xd","forks_url":"https://api.github.com/repos/spring-projects/spring-xd/forks","keys_url":"https://api.github.com/repos/spring-projects/spring-xd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spring-projects/spring-xd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spring-projects/spring-xd/teams","hooks_url":"https://api.github.com/repos/spring-projects/spring-xd/hooks","issue_events_url":"https://api.github.com/repos/spring-projects/spring-xd/issues/events{/number}","events_url":"https://api.github.com/repos/spring-projects/spring-xd/events","assignees_url":"https://api.github.com/repos/spring-projects/spring-xd/assignees{/user}","branches_url":"https://api.github.com/repos/spring-projects/spring-xd/branches{/branch}","tags_url":"https://api.github.com/repos/spring-projects/spring-xd/tags","blobs_url":"https://api.github.com/repos/spring-projects/spring-xd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spring-projects/spring-xd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spring-projects/spring-xd/git/refs{/sha}","trees_url":"https://api.github.com/repos/spring-projects/spring-xd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spring-projects/spring-xd/statuses/{sha}","languages_url":"https://api.github.com/repos/spring-projects/spring-xd/languages","stargazers_url":"https://api.github.com/repos/spring-projects/spring-xd/stargazers","contributors_url":"https://api.github.com/repos/spring-projects/spring-xd/contributors","subscribers_url":"https://api.github.com/repos/spring-projects/spring-xd/subscribers","subscription_url":"https://api.github.com/repos/spring-projects/spring-xd/subscription","commits_url":"https://api.github.com/repos/spring-projects/spring-xd/commits{/sha}","git_commits_url":"https://api.github.com/repos/spring-projects/spring-xd/git/commits{/sha}","comments_url":"https://api.github.com/repos/spring-projects/spring-xd/comments{/number}","issue_comment_url":"https://api.github.com/repos/spring-projects/spring-xd/issues/comments{/number}","contents_url":"https://api.github.com/repos/spring-projects/spring-xd/contents/{+path}","compare_url":"https://api.github.com/repos/spring-projects/spring-xd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spring-projects/spring-xd/merges","archive_url":"https://api.github.com/repos/spring-projects/spring-xd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spring-projects/spring-xd/downloads","issues_url":"https://api.github.com/repos/spring-projects/spring-xd/issues{/number}","pulls_url":"https://api.github.com/repos/spring-projects/spring-xd/pulls{/number}","milestones_url":"https://api.github.com/repos/spring-projects/spring-xd/milestones{/number}","notifications_url":"https://api.github.com/repos/spring-projects/spring-xd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spring-projects/spring-xd/labels{/name}","releases_url":"https://api.github.com/repos/spring-projects/spring-xd/releases{/id}","created_at":"2013-04-10T15:31:44Z","updated_at":"2015-04-22T08:35:43Z","pushed_at":"2015-04-21T23:52:09Z","git_url":"git://github.com/spring-projects/spring-xd.git","ssh_url":"git@github.com:spring-projects/spring-xd.git","clone_url":"https://github.com/spring-projects/spring-xd.git","svn_url":"https://github.com/spring-projects/spring-xd","homepage":"http://projects.spring.io/spring-xd","size":59347,"stargazers_count":251,"watchers_count":251,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":195,"mirror_url":null,"open_issues_count":36,"forks":195,"open_issues":36,"watchers":251,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spring-projects/spring-xd/pulls/1538"},"html":{"href":"https://github.com/spring-projects/spring-xd/pull/1538"},"issue":{"href":"https://api.github.com/repos/spring-projects/spring-xd/issues/1538"},"comments":{"href":"https://api.github.com/repos/spring-projects/spring-xd/issues/1538/comments"},"review_comments":{"href":"https://api.github.com/repos/spring-projects/spring-xd/pulls/1538/comments"},"review_comment":{"href":"https://api.github.com/repos/spring-projects/spring-xd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spring-projects/spring-xd/pulls/1538/commits"},"statuses":{"href":"https://api.github.com/repos/spring-projects/spring-xd/statuses/4ad1618b1ca4ee01641a29d8b24590e51bbf0e5c"}}}}