{"action":"created","comment":{"url":"https://api.github.com/repos/ciaa/Firmware/pulls/comments/39931666","id":39931666,"diff_hunk":"@@ -174,15 +201,20 @@ static void ciaaDriverAio_txConfirmation(ciaaDevices_deviceType const * const de\n \n static void ciaaDriverAio_adcIRQHandler(ciaaDevices_deviceType const * const device)\n {\n+    uint32_t readValue;\n+    ciaaDriverAdcControlType * adc = device->layer;\n \n+    /*This must be improved*/\n+    readValue = ADC16_HAL_GetChnConvValue(adc->port.base, 0);\n+    adc->hwbuf[0] = (uint8_t)readValue;\n+    adc->hwbuf[1] = (uint8_t)(readValue>>8);\n+    adc->cnt = 2;\n+\n+    ciaaDriverAio_rxIndication(device, adc->cnt);","path":"modules/drivers/cortexM4/k60_120/src/ciaaDriverAio.c","position":173,"original_position":173,"commit_id":"8441a732b410edf85be1ad0ba79e8689cf988294","original_commit_id":"8441a732b410edf85be1ad0ba79e8689cf988294","user":{"login":"mcerdeiro","id":7267483,"avatar_url":"https://avatars.githubusercontent.com/u/7267483?v=3","gravatar_id":"","url":"https://api.github.com/users/mcerdeiro","html_url":"https://github.com/mcerdeiro","followers_url":"https://api.github.com/users/mcerdeiro/followers","following_url":"https://api.github.com/users/mcerdeiro/following{/other_user}","gists_url":"https://api.github.com/users/mcerdeiro/gists{/gist_id}","starred_url":"https://api.github.com/users/mcerdeiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcerdeiro/subscriptions","organizations_url":"https://api.github.com/users/mcerdeiro/orgs","repos_url":"https://api.github.com/users/mcerdeiro/repos","events_url":"https://api.github.com/users/mcerdeiro/events{/privacy}","received_events_url":"https://api.github.com/users/mcerdeiro/received_events","type":"User","site_admin":false},"body":"se estan leyendo los datos dos veces, primero aca y luego cuando el device hace read desde el contexto del rxIndication. esto es un error... :(","created_at":"2015-09-20T16:36:34Z","updated_at":"2015-09-20T16:36:34Z","html_url":"https://github.com/ciaa/Firmware/pull/346#discussion_r39931666","pull_request_url":"https://api.github.com/repos/ciaa/Firmware/pulls/346","_links":{"self":{"href":"https://api.github.com/repos/ciaa/Firmware/pulls/comments/39931666"},"html":{"href":"https://github.com/ciaa/Firmware/pull/346#discussion_r39931666"},"pull_request":{"href":"https://api.github.com/repos/ciaa/Firmware/pulls/346"}}},"pull_request":{"url":"https://api.github.com/repos/ciaa/Firmware/pulls/346","id":45497853,"html_url":"https://github.com/ciaa/Firmware/pull/346","diff_url":"https://github.com/ciaa/Firmware/pull/346.diff","patch_url":"https://github.com/ciaa/Firmware/pull/346.patch","issue_url":"https://api.github.com/repos/ciaa/Firmware/issues/346","number":346,"state":"open","locked":false,"title":"Features/fsl drivers","user":{"login":"mcerdeiro","id":7267483,"avatar_url":"https://avatars.githubusercontent.com/u/7267483?v=3","gravatar_id":"","url":"https://api.github.com/users/mcerdeiro","html_url":"https://github.com/mcerdeiro","followers_url":"https://api.github.com/users/mcerdeiro/followers","following_url":"https://api.github.com/users/mcerdeiro/following{/other_user}","gists_url":"https://api.github.com/users/mcerdeiro/gists{/gist_id}","starred_url":"https://api.github.com/users/mcerdeiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcerdeiro/subscriptions","organizations_url":"https://api.github.com/users/mcerdeiro/orgs","repos_url":"https://api.github.com/users/mcerdeiro/repos","events_url":"https://api.github.com/users/mcerdeiro/events{/privacy}","received_events_url":"https://api.github.com/users/mcerdeiro/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-09-20T15:05:17Z","updated_at":"2015-09-20T16:36:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fed82f13783f3f5dbbbab380c848f4f108c0df7c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ciaa/Firmware/pulls/346/commits","review_comments_url":"https://api.github.com/repos/ciaa/Firmware/pulls/346/comments","review_comment_url":"https://api.github.com/repos/ciaa/Firmware/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ciaa/Firmware/issues/346/comments","statuses_url":"https://api.github.com/repos/ciaa/Firmware/statuses/8441a732b410edf85be1ad0ba79e8689cf988294","head":{"label":"ciaa:features/fsl_drivers","ref":"features/fsl_drivers","sha":"8441a732b410edf85be1ad0ba79e8689cf988294","user":{"login":"ciaa","id":6998305,"avatar_url":"https://avatars.githubusercontent.com/u/6998305?v=3","gravatar_id":"","url":"https://api.github.com/users/ciaa","html_url":"https://github.com/ciaa","followers_url":"https://api.github.com/users/ciaa/followers","following_url":"https://api.github.com/users/ciaa/following{/other_user}","gists_url":"https://api.github.com/users/ciaa/gists{/gist_id}","starred_url":"https://api.github.com/users/ciaa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ciaa/subscriptions","organizations_url":"https://api.github.com/users/ciaa/orgs","repos_url":"https://api.github.com/users/ciaa/repos","events_url":"https://api.github.com/users/ciaa/events{/privacy}","received_events_url":"https://api.github.com/users/ciaa/received_events","type":"Organization","site_admin":false},"repo":{"id":18946763,"name":"Firmware","full_name":"ciaa/Firmware","owner":{"login":"ciaa","id":6998305,"avatar_url":"https://avatars.githubusercontent.com/u/6998305?v=3","gravatar_id":"","url":"https://api.github.com/users/ciaa","html_url":"https://github.com/ciaa","followers_url":"https://api.github.com/users/ciaa/followers","following_url":"https://api.github.com/users/ciaa/following{/other_user}","gists_url":"https://api.github.com/users/ciaa/gists{/gist_id}","starred_url":"https://api.github.com/users/ciaa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ciaa/subscriptions","organizations_url":"https://api.github.com/users/ciaa/orgs","repos_url":"https://api.github.com/users/ciaa/repos","events_url":"https://api.github.com/users/ciaa/events{/privacy}","received_events_url":"https://api.github.com/users/ciaa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ciaa/Firmware","description":"Firmware de la CIAA","fork":false,"url":"https://api.github.com/repos/ciaa/Firmware","forks_url":"https://api.github.com/repos/ciaa/Firmware/forks","keys_url":"https://api.github.com/repos/ciaa/Firmware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ciaa/Firmware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ciaa/Firmware/teams","hooks_url":"https://api.github.com/repos/ciaa/Firmware/hooks","issue_events_url":"https://api.github.com/repos/ciaa/Firmware/issues/events{/number}","events_url":"https://api.github.com/repos/ciaa/Firmware/events","assignees_url":"https://api.github.com/repos/ciaa/Firmware/assignees{/user}","branches_url":"https://api.github.com/repos/ciaa/Firmware/branches{/branch}","tags_url":"https://api.github.com/repos/ciaa/Firmware/tags","blobs_url":"https://api.github.com/repos/ciaa/Firmware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ciaa/Firmware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ciaa/Firmware/git/refs{/sha}","trees_url":"https://api.github.com/repos/ciaa/Firmware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ciaa/Firmware/statuses/{sha}","languages_url":"https://api.github.com/repos/ciaa/Firmware/languages","stargazers_url":"https://api.github.com/repos/ciaa/Firmware/stargazers","contributors_url":"https://api.github.com/repos/ciaa/Firmware/contributors","subscribers_url":"https://api.github.com/repos/ciaa/Firmware/subscribers","subscription_url":"https://api.github.com/repos/ciaa/Firmware/subscription","commits_url":"https://api.github.com/repos/ciaa/Firmware/commits{/sha}","git_commits_url":"https://api.github.com/repos/ciaa/Firmware/git/commits{/sha}","comments_url":"https://api.github.com/repos/ciaa/Firmware/comments{/number}","issue_comment_url":"https://api.github.com/repos/ciaa/Firmware/issues/comments{/number}","contents_url":"https://api.github.com/repos/ciaa/Firmware/contents/{+path}","compare_url":"https://api.github.com/repos/ciaa/Firmware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ciaa/Firmware/merges","archive_url":"https://api.github.com/repos/ciaa/Firmware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ciaa/Firmware/downloads","issues_url":"https://api.github.com/repos/ciaa/Firmware/issues{/number}","pulls_url":"https://api.github.com/repos/ciaa/Firmware/pulls{/number}","milestones_url":"https://api.github.com/repos/ciaa/Firmware/milestones{/number}","notifications_url":"https://api.github.com/repos/ciaa/Firmware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ciaa/Firmware/labels{/name}","releases_url":"https://api.github.com/repos/ciaa/Firmware/releases{/id}","created_at":"2014-04-19T17:33:43Z","updated_at":"2015-08-13T00:42:57Z","pushed_at":"2015-09-20T15:05:17Z","git_url":"git://github.com/ciaa/Firmware.git","ssh_url":"git@github.com:ciaa/Firmware.git","clone_url":"https://github.com/ciaa/Firmware.git","svn_url":"https://github.com/ciaa/Firmware","homepage":"http://www.proyecto-ciaa.com.ar","size":39126,"stargazers_count":19,"watchers_count":19,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":26,"mirror_url":null,"open_issues_count":92,"forks":26,"open_issues":92,"watchers":19,"default_branch":"master"}},"base":{"label":"ciaa:master","ref":"master","sha":"1ecb809aac626beb3b5cb887dc51bb0aabd71e19","user":{"login":"ciaa","id":6998305,"avatar_url":"https://avatars.githubusercontent.com/u/6998305?v=3","gravatar_id":"","url":"https://api.github.com/users/ciaa","html_url":"https://github.com/ciaa","followers_url":"https://api.github.com/users/ciaa/followers","following_url":"https://api.github.com/users/ciaa/following{/other_user}","gists_url":"https://api.github.com/users/ciaa/gists{/gist_id}","starred_url":"https://api.github.com/users/ciaa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ciaa/subscriptions","organizations_url":"https://api.github.com/users/ciaa/orgs","repos_url":"https://api.github.com/users/ciaa/repos","events_url":"https://api.github.com/users/ciaa/events{/privacy}","received_events_url":"https://api.github.com/users/ciaa/received_events","type":"Organization","site_admin":false},"repo":{"id":18946763,"name":"Firmware","full_name":"ciaa/Firmware","owner":{"login":"ciaa","id":6998305,"avatar_url":"https://avatars.githubusercontent.com/u/6998305?v=3","gravatar_id":"","url":"https://api.github.com/users/ciaa","html_url":"https://github.com/ciaa","followers_url":"https://api.github.com/users/ciaa/followers","following_url":"https://api.github.com/users/ciaa/following{/other_user}","gists_url":"https://api.github.com/users/ciaa/gists{/gist_id}","starred_url":"https://api.github.com/users/ciaa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ciaa/subscriptions","organizations_url":"https://api.github.com/users/ciaa/orgs","repos_url":"https://api.github.com/users/ciaa/repos","events_url":"https://api.github.com/users/ciaa/events{/privacy}","received_events_url":"https://api.github.com/users/ciaa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ciaa/Firmware","description":"Firmware de la CIAA","fork":false,"url":"https://api.github.com/repos/ciaa/Firmware","forks_url":"https://api.github.com/repos/ciaa/Firmware/forks","keys_url":"https://api.github.com/repos/ciaa/Firmware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ciaa/Firmware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ciaa/Firmware/teams","hooks_url":"https://api.github.com/repos/ciaa/Firmware/hooks","issue_events_url":"https://api.github.com/repos/ciaa/Firmware/issues/events{/number}","events_url":"https://api.github.com/repos/ciaa/Firmware/events","assignees_url":"https://api.github.com/repos/ciaa/Firmware/assignees{/user}","branches_url":"https://api.github.com/repos/ciaa/Firmware/branches{/branch}","tags_url":"https://api.github.com/repos/ciaa/Firmware/tags","blobs_url":"https://api.github.com/repos/ciaa/Firmware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ciaa/Firmware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ciaa/Firmware/git/refs{/sha}","trees_url":"https://api.github.com/repos/ciaa/Firmware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ciaa/Firmware/statuses/{sha}","languages_url":"https://api.github.com/repos/ciaa/Firmware/languages","stargazers_url":"https://api.github.com/repos/ciaa/Firmware/stargazers","contributors_url":"https://api.github.com/repos/ciaa/Firmware/contributors","subscribers_url":"https://api.github.com/repos/ciaa/Firmware/subscribers","subscription_url":"https://api.github.com/repos/ciaa/Firmware/subscription","commits_url":"https://api.github.com/repos/ciaa/Firmware/commits{/sha}","git_commits_url":"https://api.github.com/repos/ciaa/Firmware/git/commits{/sha}","comments_url":"https://api.github.com/repos/ciaa/Firmware/comments{/number}","issue_comment_url":"https://api.github.com/repos/ciaa/Firmware/issues/comments{/number}","contents_url":"https://api.github.com/repos/ciaa/Firmware/contents/{+path}","compare_url":"https://api.github.com/repos/ciaa/Firmware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ciaa/Firmware/merges","archive_url":"https://api.github.com/repos/ciaa/Firmware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ciaa/Firmware/downloads","issues_url":"https://api.github.com/repos/ciaa/Firmware/issues{/number}","pulls_url":"https://api.github.com/repos/ciaa/Firmware/pulls{/number}","milestones_url":"https://api.github.com/repos/ciaa/Firmware/milestones{/number}","notifications_url":"https://api.github.com/repos/ciaa/Firmware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ciaa/Firmware/labels{/name}","releases_url":"https://api.github.com/repos/ciaa/Firmware/releases{/id}","created_at":"2014-04-19T17:33:43Z","updated_at":"2015-08-13T00:42:57Z","pushed_at":"2015-09-20T15:05:17Z","git_url":"git://github.com/ciaa/Firmware.git","ssh_url":"git@github.com:ciaa/Firmware.git","clone_url":"https://github.com/ciaa/Firmware.git","svn_url":"https://github.com/ciaa/Firmware","homepage":"http://www.proyecto-ciaa.com.ar","size":39126,"stargazers_count":19,"watchers_count":19,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":26,"mirror_url":null,"open_issues_count":92,"forks":26,"open_issues":92,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ciaa/Firmware/pulls/346"},"html":{"href":"https://github.com/ciaa/Firmware/pull/346"},"issue":{"href":"https://api.github.com/repos/ciaa/Firmware/issues/346"},"comments":{"href":"https://api.github.com/repos/ciaa/Firmware/issues/346/comments"},"review_comments":{"href":"https://api.github.com/repos/ciaa/Firmware/pulls/346/comments"},"review_comment":{"href":"https://api.github.com/repos/ciaa/Firmware/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ciaa/Firmware/pulls/346/commits"},"statuses":{"href":"https://api.github.com/repos/ciaa/Firmware/statuses/8441a732b410edf85be1ad0ba79e8689cf988294"}}}}