{"action":"created","issue":{"url":"https://api.github.com/repos/elastic/ruby-lumberjack/issues/9","labels_url":"https://api.github.com/repos/elastic/ruby-lumberjack/issues/9/labels{/name}","comments_url":"https://api.github.com/repos/elastic/ruby-lumberjack/issues/9/comments","events_url":"https://api.github.com/repos/elastic/ruby-lumberjack/issues/9/events","html_url":"https://github.com/elastic/ruby-lumberjack/pull/9","id":100098540,"number":9,"title":"Change how we calculate the window size.","user":{"login":"ph","id":640,"avatar_url":"https://avatars.githubusercontent.com/u/640?v=3","gravatar_id":"","url":"https://api.github.com/users/ph","html_url":"https://github.com/ph","followers_url":"https://api.github.com/users/ph/followers","following_url":"https://api.github.com/users/ph/following{/other_user}","gists_url":"https://api.github.com/users/ph/gists{/gist_id}","starred_url":"https://api.github.com/users/ph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ph/subscriptions","organizations_url":"https://api.github.com/users/ph/orgs","repos_url":"https://api.github.com/users/ph/repos","events_url":"https://api.github.com/users/ph/events{/privacy}","received_events_url":"https://api.github.com/users/ph/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-08-10T15:46:12Z","updated_at":"2015-08-11T00:47:29Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/elastic/ruby-lumberjack/pulls/9","html_url":"https://github.com/elastic/ruby-lumberjack/pull/9","diff_url":"https://github.com/elastic/ruby-lumberjack/pull/9.diff","patch_url":"https://github.com/elastic/ruby-lumberjack/pull/9.patch"},"body":"Window size was incorrectly caculated on the server side.\r\nCausing the sequence number to be out of sync with the LSF, we were\r\nusing the first sequence number of a transmission to actually ack\r\na whole transmission.\r\n\r\nAlso removed the `window_size` option in the ruby client, because it\r\ndoesn't reflect the actual behavior of the ruby client. The client\r\ndoesn't do any buffering before transmitting the payload, so the client\r\nshould ack every send to not lose events."},"comment":{"url":"https://api.github.com/repos/elastic/ruby-lumberjack/issues/comments/129659178","html_url":"https://github.com/elastic/ruby-lumberjack/pull/9#issuecomment-129659178","issue_url":"https://api.github.com/repos/elastic/ruby-lumberjack/issues/9","id":129659178,"user":{"login":"ph","id":640,"avatar_url":"https://avatars.githubusercontent.com/u/640?v=3","gravatar_id":"","url":"https://api.github.com/users/ph","html_url":"https://github.com/ph","followers_url":"https://api.github.com/users/ph/followers","following_url":"https://api.github.com/users/ph/following{/other_user}","gists_url":"https://api.github.com/users/ph/gists{/gist_id}","starred_url":"https://api.github.com/users/ph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ph/subscriptions","organizations_url":"https://api.github.com/users/ph/orgs","repos_url":"https://api.github.com/users/ph/repos","events_url":"https://api.github.com/users/ph/events{/privacy}","received_events_url":"https://api.github.com/users/ph/received_events","type":"User","site_admin":false},"created_at":"2015-08-11T00:47:29Z","updated_at":"2015-08-11T00:47:29Z","body":"@jordansissel Added a `#write` bulk for the ruby client, also added a few examples concerning the for out of sync sequences."}}