{"action":"created","comment":{"url":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/pulls/comments/27032980","id":27032980,"diff_hunk":"@@ -32,53 +32,65 @@ The TCK is provided as binary artifact on [Maven Central](http://search.maven.or\n \n Please refer to the [Reactive Streams Specification](https://github.com/reactive-streams/reactive-streams) for the current latest version number. Make sure that the API and TCK dependency versions are equal.\n \n-### Types of tests\n+### Test method naming convention\n \n Since the TCK is aimed at Reactive Stream implementers, looking into the sources of the TCK is well expected,\n and should help during a libraries implementation cycle.\n \n In order to make mapping between test cases and Specification rules easier, each test case covering a specific\n-Specification rule abides the following naming convention: `spec###_DESC` where:\n+Specification rule abides the following naming convention: `TYPE_spec###_DESC` where:\n \n+* `TYPE` is one of: [#type-required](required), [#type-optional](optional), [#type-stochastic](stochastic) or [#type-untested](untested) which describe if this test is covering a Rule that MUST or SHOULD be implemented. The specific words are explained in detail below.\n * `###` is the Rule number (`1.xx` Rules are about Publishers, `2.xx` Rules are about Subscribers etc.)\n * `DESC` is a short explanation of what exactly is being tested in this test case, as sometimes one Rule may have multiple test cases in order to cover the entire Rule.\n \n+Here is an example test method signature:\n+\n ```java\n   // Verifies rule: https://github.com/reactive-streams/reactive-streams#1.1","path":"tck/README.md","position":35,"original_position":35,"commit_id":"7030855a143925d99e78e473693d919a0c1d873c","original_commit_id":"7030855a143925d99e78e473693d919a0c1d873c","user":{"login":"viktorklang","id":10871,"avatar_url":"https://avatars.githubusercontent.com/u/10871?v=3","gravatar_id":"","url":"https://api.github.com/users/viktorklang","html_url":"https://github.com/viktorklang","followers_url":"https://api.github.com/users/viktorklang/followers","following_url":"https://api.github.com/users/viktorklang/following{/other_user}","gists_url":"https://api.github.com/users/viktorklang/gists{/gist_id}","starred_url":"https://api.github.com/users/viktorklang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/viktorklang/subscriptions","organizations_url":"https://api.github.com/users/viktorklang/orgs","repos_url":"https://api.github.com/users/viktorklang/repos","events_url":"https://api.github.com/users/viktorklang/events{/privacy}","received_events_url":"https://api.github.com/users/viktorklang/received_events","type":"User","site_admin":false},"body":"These links are dead now with the move to `reactive-streams-jvm`?","created_at":"2015-03-24T14:35:42Z","updated_at":"2015-03-24T14:35:42Z","html_url":"https://github.com/reactive-streams/reactive-streams-jvm/pull/246#discussion_r27032980","pull_request_url":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/pulls/246","_links":{"self":{"href":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/pulls/comments/27032980"},"html":{"href":"https://github.com/reactive-streams/reactive-streams-jvm/pull/246#discussion_r27032980"},"pull_request":{"href":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/pulls/246"}}},"pull_request":{"url":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/pulls/246","id":31584805,"html_url":"https://github.com/reactive-streams/reactive-streams-jvm/pull/246","diff_url":"https://github.com/reactive-streams/reactive-streams-jvm/pull/246.diff","patch_url":"https://github.com/reactive-streams/reactive-streams-jvm/pull/246.patch","issue_url":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/issues/246","number":246,"state":"open","locked":false,"title":"=tck general tck/readme.md cleanup so it matches current code / spec","user":{"login":"ktoso","id":120979,"avatar_url":"https://avatars.githubusercontent.com/u/120979?v=3","gravatar_id":"","url":"https://api.github.com/users/ktoso","html_url":"https://github.com/ktoso","followers_url":"https://api.github.com/users/ktoso/followers","following_url":"https://api.github.com/users/ktoso/following{/other_user}","gists_url":"https://api.github.com/users/ktoso/gists{/gist_id}","starred_url":"https://api.github.com/users/ktoso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ktoso/subscriptions","organizations_url":"https://api.github.com/users/ktoso/orgs","repos_url":"https://api.github.com/users/ktoso/repos","events_url":"https://api.github.com/users/ktoso/events{/privacy}","received_events_url":"https://api.github.com/users/ktoso/received_events","type":"User","site_admin":false},"body":"Readme updates so that it shows up to date code as well as explains the TCK upgrade story.\r\n\r\nResolves #99\r\nDepends on #241\r\n\r\n:airplane:","created_at":"2015-03-20T02:58:46Z","updated_at":"2015-03-24T14:35:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cdf0ca8f54f4cbfab7816815a9f972ea8a9f9e49","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/pulls/246/commits","review_comments_url":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/pulls/246/comments","review_comment_url":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/issues/246/comments","statuses_url":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/statuses/7030855a143925d99e78e473693d919a0c1d873c","head":{"label":"ktoso:wip-readme-fixups-ktoso","ref":"wip-readme-fixups-ktoso","sha":"7030855a143925d99e78e473693d919a0c1d873c","user":{"login":"ktoso","id":120979,"avatar_url":"https://avatars.githubusercontent.com/u/120979?v=3","gravatar_id":"","url":"https://api.github.com/users/ktoso","html_url":"https://github.com/ktoso","followers_url":"https://api.github.com/users/ktoso/followers","following_url":"https://api.github.com/users/ktoso/following{/other_user}","gists_url":"https://api.github.com/users/ktoso/gists{/gist_id}","starred_url":"https://api.github.com/users/ktoso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ktoso/subscriptions","organizations_url":"https://api.github.com/users/ktoso/orgs","repos_url":"https://api.github.com/users/ktoso/repos","events_url":"https://api.github.com/users/ktoso/events{/privacy}","received_events_url":"https://api.github.com/users/ktoso/received_events","type":"User","site_admin":false},"repo":{"id":18751443,"name":"reactive-streams","full_name":"ktoso/reactive-streams","owner":{"login":"ktoso","id":120979,"avatar_url":"https://avatars.githubusercontent.com/u/120979?v=3","gravatar_id":"","url":"https://api.github.com/users/ktoso","html_url":"https://github.com/ktoso","followers_url":"https://api.github.com/users/ktoso/followers","following_url":"https://api.github.com/users/ktoso/following{/other_user}","gists_url":"https://api.github.com/users/ktoso/gists{/gist_id}","starred_url":"https://api.github.com/users/ktoso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ktoso/subscriptions","organizations_url":"https://api.github.com/users/ktoso/orgs","repos_url":"https://api.github.com/users/ktoso/repos","events_url":"https://api.github.com/users/ktoso/events{/privacy}","received_events_url":"https://api.github.com/users/ktoso/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ktoso/reactive-streams","description":"","fork":true,"url":"https://api.github.com/repos/ktoso/reactive-streams","forks_url":"https://api.github.com/repos/ktoso/reactive-streams/forks","keys_url":"https://api.github.com/repos/ktoso/reactive-streams/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ktoso/reactive-streams/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ktoso/reactive-streams/teams","hooks_url":"https://api.github.com/repos/ktoso/reactive-streams/hooks","issue_events_url":"https://api.github.com/repos/ktoso/reactive-streams/issues/events{/number}","events_url":"https://api.github.com/repos/ktoso/reactive-streams/events","assignees_url":"https://api.github.com/repos/ktoso/reactive-streams/assignees{/user}","branches_url":"https://api.github.com/repos/ktoso/reactive-streams/branches{/branch}","tags_url":"https://api.github.com/repos/ktoso/reactive-streams/tags","blobs_url":"https://api.github.com/repos/ktoso/reactive-streams/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ktoso/reactive-streams/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ktoso/reactive-streams/git/refs{/sha}","trees_url":"https://api.github.com/repos/ktoso/reactive-streams/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ktoso/reactive-streams/statuses/{sha}","languages_url":"https://api.github.com/repos/ktoso/reactive-streams/languages","stargazers_url":"https://api.github.com/repos/ktoso/reactive-streams/stargazers","contributors_url":"https://api.github.com/repos/ktoso/reactive-streams/contributors","subscribers_url":"https://api.github.com/repos/ktoso/reactive-streams/subscribers","subscription_url":"https://api.github.com/repos/ktoso/reactive-streams/subscription","commits_url":"https://api.github.com/repos/ktoso/reactive-streams/commits{/sha}","git_commits_url":"https://api.github.com/repos/ktoso/reactive-streams/git/commits{/sha}","comments_url":"https://api.github.com/repos/ktoso/reactive-streams/comments{/number}","issue_comment_url":"https://api.github.com/repos/ktoso/reactive-streams/issues/comments{/number}","contents_url":"https://api.github.com/repos/ktoso/reactive-streams/contents/{+path}","compare_url":"https://api.github.com/repos/ktoso/reactive-streams/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ktoso/reactive-streams/merges","archive_url":"https://api.github.com/repos/ktoso/reactive-streams/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ktoso/reactive-streams/downloads","issues_url":"https://api.github.com/repos/ktoso/reactive-streams/issues{/number}","pulls_url":"https://api.github.com/repos/ktoso/reactive-streams/pulls{/number}","milestones_url":"https://api.github.com/repos/ktoso/reactive-streams/milestones{/number}","notifications_url":"https://api.github.com/repos/ktoso/reactive-streams/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ktoso/reactive-streams/labels{/name}","releases_url":"https://api.github.com/repos/ktoso/reactive-streams/releases{/id}","created_at":"2014-04-14T07:02:32Z","updated_at":"2015-03-03T10:08:52Z","pushed_at":"2015-03-23T08:21:39Z","git_url":"git://github.com/ktoso/reactive-streams.git","ssh_url":"git@github.com:ktoso/reactive-streams.git","clone_url":"https://github.com/ktoso/reactive-streams.git","svn_url":"https://github.com/ktoso/reactive-streams","homepage":"reactive-streams.org","size":2113,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"reactive-streams:master","ref":"master","sha":"bca27f5ce58ee3c9a45f5445b383e8788e600fd6","user":{"login":"reactive-streams","id":7080130,"avatar_url":"https://avatars.githubusercontent.com/u/7080130?v=3","gravatar_id":"","url":"https://api.github.com/users/reactive-streams","html_url":"https://github.com/reactive-streams","followers_url":"https://api.github.com/users/reactive-streams/followers","following_url":"https://api.github.com/users/reactive-streams/following{/other_user}","gists_url":"https://api.github.com/users/reactive-streams/gists{/gist_id}","starred_url":"https://api.github.com/users/reactive-streams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reactive-streams/subscriptions","organizations_url":"https://api.github.com/users/reactive-streams/orgs","repos_url":"https://api.github.com/users/reactive-streams/repos","events_url":"https://api.github.com/users/reactive-streams/events{/privacy}","received_events_url":"https://api.github.com/users/reactive-streams/received_events","type":"Organization","site_admin":false},"repo":{"id":17286587,"name":"reactive-streams-jvm","full_name":"reactive-streams/reactive-streams-jvm","owner":{"login":"reactive-streams","id":7080130,"avatar_url":"https://avatars.githubusercontent.com/u/7080130?v=3","gravatar_id":"","url":"https://api.github.com/users/reactive-streams","html_url":"https://github.com/reactive-streams","followers_url":"https://api.github.com/users/reactive-streams/followers","following_url":"https://api.github.com/users/reactive-streams/following{/other_user}","gists_url":"https://api.github.com/users/reactive-streams/gists{/gist_id}","starred_url":"https://api.github.com/users/reactive-streams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reactive-streams/subscriptions","organizations_url":"https://api.github.com/users/reactive-streams/orgs","repos_url":"https://api.github.com/users/reactive-streams/repos","events_url":"https://api.github.com/users/reactive-streams/events{/privacy}","received_events_url":"https://api.github.com/users/reactive-streams/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/reactive-streams/reactive-streams-jvm","description":"Reactive Streams Specification for the JVM","fork":false,"url":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm","forks_url":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/forks","keys_url":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/teams","hooks_url":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/hooks","issue_events_url":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/issues/events{/number}","events_url":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/events","assignees_url":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/assignees{/user}","branches_url":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/branches{/branch}","tags_url":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/tags","blobs_url":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/git/refs{/sha}","trees_url":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/statuses/{sha}","languages_url":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/languages","stargazers_url":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/stargazers","contributors_url":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/contributors","subscribers_url":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/subscribers","subscription_url":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/subscription","commits_url":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/commits{/sha}","git_commits_url":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/git/commits{/sha}","comments_url":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/comments{/number}","issue_comment_url":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/issues/comments{/number}","contents_url":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/contents/{+path}","compare_url":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/merges","archive_url":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/downloads","issues_url":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/issues{/number}","pulls_url":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/pulls{/number}","milestones_url":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/milestones{/number}","notifications_url":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/labels{/name}","releases_url":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/releases{/id}","created_at":"2014-02-28T13:16:15Z","updated_at":"2015-03-24T04:29:07Z","pushed_at":"2015-03-23T08:21:40Z","git_url":"git://github.com/reactive-streams/reactive-streams-jvm.git","ssh_url":"git@github.com:reactive-streams/reactive-streams-jvm.git","clone_url":"https://github.com/reactive-streams/reactive-streams-jvm.git","svn_url":"https://github.com/reactive-streams/reactive-streams-jvm","homepage":"http://www.reactive-streams.org/","size":3677,"stargazers_count":578,"watchers_count":578,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":52,"mirror_url":null,"open_issues_count":23,"forks":52,"open_issues":23,"watchers":578,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/pulls/246"},"html":{"href":"https://github.com/reactive-streams/reactive-streams-jvm/pull/246"},"issue":{"href":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/issues/246"},"comments":{"href":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/issues/246/comments"},"review_comments":{"href":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/pulls/246/comments"},"review_comment":{"href":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/pulls/246/commits"},"statuses":{"href":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/statuses/7030855a143925d99e78e473693d919a0c1d873c"}}}}