{"action":"created","comment":{"url":"https://api.github.com/repos/KhronosGroup/glslang/pulls/comments/39713720","id":39713720,"diff_hunk":"@@ -639,7 +639,7 @@ class TIntermOperator : public TIntermTyped {\n     bool isImage()   const { return op > EOpImageGuardBegin   && op < EOpImageGuardEnd; }\n \n     // Crack the op into the individual dimensions of texturing operation.\n-    void crackTexture(TCrackedTextureOp& cracked) const\n+    void crackTexture(TSampler sampler, TCrackedTextureOp& cracked) const","path":"glslang/Include/intermediate.h","position":5,"original_position":5,"commit_id":"6b86d496c28db137bbe3fa990d0485ec0d5ae551","original_commit_id":"6b86d496c28db137bbe3fa990d0485ec0d5ae551","user":{"login":"amdrexu","id":13959852,"avatar_url":"https://avatars.githubusercontent.com/u/13959852?v=3","gravatar_id":"","url":"https://api.github.com/users/amdrexu","html_url":"https://github.com/amdrexu","followers_url":"https://api.github.com/users/amdrexu/followers","following_url":"https://api.github.com/users/amdrexu/following{/other_user}","gists_url":"https://api.github.com/users/amdrexu/gists{/gist_id}","starred_url":"https://api.github.com/users/amdrexu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amdrexu/subscriptions","organizations_url":"https://api.github.com/users/amdrexu/orgs","repos_url":"https://api.github.com/users/amdrexu/repos","events_url":"https://api.github.com/users/amdrexu/events{/privacy}","received_events_url":"https://api.github.com/users/amdrexu/received_events","type":"User","site_admin":false},"body":"Yes, I understand your intention. We could modify the result of \"cracked\" outside this method. If you think it is better and want to keep the conciseness of \"crackTexture\", I will modify the codes. It is OK.","created_at":"2015-09-17T06:07:07Z","updated_at":"2015-09-17T06:07:07Z","html_url":"https://github.com/KhronosGroup/glslang/pull/71#discussion_r39713720","pull_request_url":"https://api.github.com/repos/KhronosGroup/glslang/pulls/71","_links":{"self":{"href":"https://api.github.com/repos/KhronosGroup/glslang/pulls/comments/39713720"},"html":{"href":"https://github.com/KhronosGroup/glslang/pull/71#discussion_r39713720"},"pull_request":{"href":"https://api.github.com/repos/KhronosGroup/glslang/pulls/71"}}},"pull_request":{"url":"https://api.github.com/repos/KhronosGroup/glslang/pulls/71","id":44298395,"html_url":"https://github.com/KhronosGroup/glslang/pull/71","diff_url":"https://github.com/KhronosGroup/glslang/pull/71.diff","patch_url":"https://github.com/KhronosGroup/glslang/pull/71.patch","issue_url":"https://api.github.com/repos/KhronosGroup/glslang/issues/71","number":71,"state":"closed","locked":false,"title":"SPIRV: Refine implementation of OpAtomicXXX instructions","user":{"login":"amdrexu","id":13959852,"avatar_url":"https://avatars.githubusercontent.com/u/13959852?v=3","gravatar_id":"","url":"https://api.github.com/users/amdrexu","html_url":"https://github.com/amdrexu","followers_url":"https://api.github.com/users/amdrexu/followers","following_url":"https://api.github.com/users/amdrexu/following{/other_user}","gists_url":"https://api.github.com/users/amdrexu/gists{/gist_id}","starred_url":"https://api.github.com/users/amdrexu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amdrexu/subscriptions","organizations_url":"https://api.github.com/users/amdrexu/orgs","repos_url":"https://api.github.com/users/amdrexu/repos","events_url":"https://api.github.com/users/amdrexu/events{/privacy}","received_events_url":"https://api.github.com/users/amdrexu/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-09-06T08:35:36Z","updated_at":"2015-09-17T06:07:07Z","closed_at":"2015-09-16T16:51:33Z","merged_at":"2015-09-16T16:51:33Z","merge_commit_sha":"e81dea0c99a8614c38894ff11cace771cd21c1b3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/KhronosGroup/glslang/pulls/71/commits","review_comments_url":"https://api.github.com/repos/KhronosGroup/glslang/pulls/71/comments","review_comment_url":"https://api.github.com/repos/KhronosGroup/glslang/pulls/comments{/number}","comments_url":"https://api.github.com/repos/KhronosGroup/glslang/issues/71/comments","statuses_url":"https://api.github.com/repos/KhronosGroup/glslang/statuses/6b86d496c28db137bbe3fa990d0485ec0d5ae551","head":{"label":"amdrexu:mywork","ref":"mywork","sha":"6b86d496c28db137bbe3fa990d0485ec0d5ae551","user":{"login":"amdrexu","id":13959852,"avatar_url":"https://avatars.githubusercontent.com/u/13959852?v=3","gravatar_id":"","url":"https://api.github.com/users/amdrexu","html_url":"https://github.com/amdrexu","followers_url":"https://api.github.com/users/amdrexu/followers","following_url":"https://api.github.com/users/amdrexu/following{/other_user}","gists_url":"https://api.github.com/users/amdrexu/gists{/gist_id}","starred_url":"https://api.github.com/users/amdrexu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amdrexu/subscriptions","organizations_url":"https://api.github.com/users/amdrexu/orgs","repos_url":"https://api.github.com/users/amdrexu/repos","events_url":"https://api.github.com/users/amdrexu/events{/privacy}","received_events_url":"https://api.github.com/users/amdrexu/received_events","type":"User","site_admin":false},"repo":{"id":41791541,"name":"glslang","full_name":"amdrexu/glslang","owner":{"login":"amdrexu","id":13959852,"avatar_url":"https://avatars.githubusercontent.com/u/13959852?v=3","gravatar_id":"","url":"https://api.github.com/users/amdrexu","html_url":"https://github.com/amdrexu","followers_url":"https://api.github.com/users/amdrexu/followers","following_url":"https://api.github.com/users/amdrexu/following{/other_user}","gists_url":"https://api.github.com/users/amdrexu/gists{/gist_id}","starred_url":"https://api.github.com/users/amdrexu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amdrexu/subscriptions","organizations_url":"https://api.github.com/users/amdrexu/orgs","repos_url":"https://api.github.com/users/amdrexu/repos","events_url":"https://api.github.com/users/amdrexu/events{/privacy}","received_events_url":"https://api.github.com/users/amdrexu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/amdrexu/glslang","description":"Khronos reference front-end for GLSL and ESSL","fork":true,"url":"https://api.github.com/repos/amdrexu/glslang","forks_url":"https://api.github.com/repos/amdrexu/glslang/forks","keys_url":"https://api.github.com/repos/amdrexu/glslang/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amdrexu/glslang/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amdrexu/glslang/teams","hooks_url":"https://api.github.com/repos/amdrexu/glslang/hooks","issue_events_url":"https://api.github.com/repos/amdrexu/glslang/issues/events{/number}","events_url":"https://api.github.com/repos/amdrexu/glslang/events","assignees_url":"https://api.github.com/repos/amdrexu/glslang/assignees{/user}","branches_url":"https://api.github.com/repos/amdrexu/glslang/branches{/branch}","tags_url":"https://api.github.com/repos/amdrexu/glslang/tags","blobs_url":"https://api.github.com/repos/amdrexu/glslang/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amdrexu/glslang/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amdrexu/glslang/git/refs{/sha}","trees_url":"https://api.github.com/repos/amdrexu/glslang/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amdrexu/glslang/statuses/{sha}","languages_url":"https://api.github.com/repos/amdrexu/glslang/languages","stargazers_url":"https://api.github.com/repos/amdrexu/glslang/stargazers","contributors_url":"https://api.github.com/repos/amdrexu/glslang/contributors","subscribers_url":"https://api.github.com/repos/amdrexu/glslang/subscribers","subscription_url":"https://api.github.com/repos/amdrexu/glslang/subscription","commits_url":"https://api.github.com/repos/amdrexu/glslang/commits{/sha}","git_commits_url":"https://api.github.com/repos/amdrexu/glslang/git/commits{/sha}","comments_url":"https://api.github.com/repos/amdrexu/glslang/comments{/number}","issue_comment_url":"https://api.github.com/repos/amdrexu/glslang/issues/comments{/number}","contents_url":"https://api.github.com/repos/amdrexu/glslang/contents/{+path}","compare_url":"https://api.github.com/repos/amdrexu/glslang/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amdrexu/glslang/merges","archive_url":"https://api.github.com/repos/amdrexu/glslang/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amdrexu/glslang/downloads","issues_url":"https://api.github.com/repos/amdrexu/glslang/issues{/number}","pulls_url":"https://api.github.com/repos/amdrexu/glslang/pulls{/number}","milestones_url":"https://api.github.com/repos/amdrexu/glslang/milestones{/number}","notifications_url":"https://api.github.com/repos/amdrexu/glslang/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amdrexu/glslang/labels{/name}","releases_url":"https://api.github.com/repos/amdrexu/glslang/releases{/id}","created_at":"2015-09-02T09:11:00Z","updated_at":"2015-09-02T09:11:04Z","pushed_at":"2015-09-17T05:57:01Z","git_url":"git://github.com/amdrexu/glslang.git","ssh_url":"git@github.com:amdrexu/glslang.git","clone_url":"https://github.com/amdrexu/glslang.git","svn_url":"https://github.com/amdrexu/glslang","homepage":null,"size":22603,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"KhronosGroup:master","ref":"master","sha":"2398b3a458c98fe3be9e8a276837dd19f0907968","user":{"login":"KhronosGroup","id":1608701,"avatar_url":"https://avatars.githubusercontent.com/u/1608701?v=3","gravatar_id":"","url":"https://api.github.com/users/KhronosGroup","html_url":"https://github.com/KhronosGroup","followers_url":"https://api.github.com/users/KhronosGroup/followers","following_url":"https://api.github.com/users/KhronosGroup/following{/other_user}","gists_url":"https://api.github.com/users/KhronosGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/KhronosGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KhronosGroup/subscriptions","organizations_url":"https://api.github.com/users/KhronosGroup/orgs","repos_url":"https://api.github.com/users/KhronosGroup/repos","events_url":"https://api.github.com/users/KhronosGroup/events{/privacy}","received_events_url":"https://api.github.com/users/KhronosGroup/received_events","type":"Organization","site_admin":false},"repo":{"id":38064932,"name":"glslang","full_name":"KhronosGroup/glslang","owner":{"login":"KhronosGroup","id":1608701,"avatar_url":"https://avatars.githubusercontent.com/u/1608701?v=3","gravatar_id":"","url":"https://api.github.com/users/KhronosGroup","html_url":"https://github.com/KhronosGroup","followers_url":"https://api.github.com/users/KhronosGroup/followers","following_url":"https://api.github.com/users/KhronosGroup/following{/other_user}","gists_url":"https://api.github.com/users/KhronosGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/KhronosGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KhronosGroup/subscriptions","organizations_url":"https://api.github.com/users/KhronosGroup/orgs","repos_url":"https://api.github.com/users/KhronosGroup/repos","events_url":"https://api.github.com/users/KhronosGroup/events{/privacy}","received_events_url":"https://api.github.com/users/KhronosGroup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/KhronosGroup/glslang","description":"Khronos reference front-end for GLSL and ESSL","fork":false,"url":"https://api.github.com/repos/KhronosGroup/glslang","forks_url":"https://api.github.com/repos/KhronosGroup/glslang/forks","keys_url":"https://api.github.com/repos/KhronosGroup/glslang/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KhronosGroup/glslang/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KhronosGroup/glslang/teams","hooks_url":"https://api.github.com/repos/KhronosGroup/glslang/hooks","issue_events_url":"https://api.github.com/repos/KhronosGroup/glslang/issues/events{/number}","events_url":"https://api.github.com/repos/KhronosGroup/glslang/events","assignees_url":"https://api.github.com/repos/KhronosGroup/glslang/assignees{/user}","branches_url":"https://api.github.com/repos/KhronosGroup/glslang/branches{/branch}","tags_url":"https://api.github.com/repos/KhronosGroup/glslang/tags","blobs_url":"https://api.github.com/repos/KhronosGroup/glslang/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KhronosGroup/glslang/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KhronosGroup/glslang/git/refs{/sha}","trees_url":"https://api.github.com/repos/KhronosGroup/glslang/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KhronosGroup/glslang/statuses/{sha}","languages_url":"https://api.github.com/repos/KhronosGroup/glslang/languages","stargazers_url":"https://api.github.com/repos/KhronosGroup/glslang/stargazers","contributors_url":"https://api.github.com/repos/KhronosGroup/glslang/contributors","subscribers_url":"https://api.github.com/repos/KhronosGroup/glslang/subscribers","subscription_url":"https://api.github.com/repos/KhronosGroup/glslang/subscription","commits_url":"https://api.github.com/repos/KhronosGroup/glslang/commits{/sha}","git_commits_url":"https://api.github.com/repos/KhronosGroup/glslang/git/commits{/sha}","comments_url":"https://api.github.com/repos/KhronosGroup/glslang/comments{/number}","issue_comment_url":"https://api.github.com/repos/KhronosGroup/glslang/issues/comments{/number}","contents_url":"https://api.github.com/repos/KhronosGroup/glslang/contents/{+path}","compare_url":"https://api.github.com/repos/KhronosGroup/glslang/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KhronosGroup/glslang/merges","archive_url":"https://api.github.com/repos/KhronosGroup/glslang/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KhronosGroup/glslang/downloads","issues_url":"https://api.github.com/repos/KhronosGroup/glslang/issues{/number}","pulls_url":"https://api.github.com/repos/KhronosGroup/glslang/pulls{/number}","milestones_url":"https://api.github.com/repos/KhronosGroup/glslang/milestones{/number}","notifications_url":"https://api.github.com/repos/KhronosGroup/glslang/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KhronosGroup/glslang/labels{/name}","releases_url":"https://api.github.com/repos/KhronosGroup/glslang/releases{/id}","created_at":"2015-06-25T17:54:39Z","updated_at":"2015-09-14T13:31:29Z","pushed_at":"2015-09-17T00:24:32Z","git_url":"git://github.com/KhronosGroup/glslang.git","ssh_url":"git@github.com:KhronosGroup/glslang.git","clone_url":"https://github.com/KhronosGroup/glslang.git","svn_url":"https://github.com/KhronosGroup/glslang","homepage":null,"size":23093,"stargazers_count":112,"watchers_count":112,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"open_issues_count":19,"forks":25,"open_issues":19,"watchers":112,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/KhronosGroup/glslang/pulls/71"},"html":{"href":"https://github.com/KhronosGroup/glslang/pull/71"},"issue":{"href":"https://api.github.com/repos/KhronosGroup/glslang/issues/71"},"comments":{"href":"https://api.github.com/repos/KhronosGroup/glslang/issues/71/comments"},"review_comments":{"href":"https://api.github.com/repos/KhronosGroup/glslang/pulls/71/comments"},"review_comment":{"href":"https://api.github.com/repos/KhronosGroup/glslang/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/KhronosGroup/glslang/pulls/71/commits"},"statuses":{"href":"https://api.github.com/repos/KhronosGroup/glslang/statuses/6b86d496c28db137bbe3fa990d0485ec0d5ae551"}}}}