{"action":"created","issue":{"url":"https://api.github.com/repos/symfony-cmf/CoreBundle/issues/160","labels_url":"https://api.github.com/repos/symfony-cmf/CoreBundle/issues/160/labels{/name}","comments_url":"https://api.github.com/repos/symfony-cmf/CoreBundle/issues/160/comments","events_url":"https://api.github.com/repos/symfony-cmf/CoreBundle/issues/160/events","html_url":"https://github.com/symfony-cmf/CoreBundle/pull/160","id":57162409,"number":160,"title":"Make lots of services private","user":{"login":"WouterJ","id":749025,"avatar_url":"https://avatars.githubusercontent.com/u/749025?v=3","gravatar_id":"","url":"https://api.github.com/users/WouterJ","html_url":"https://github.com/WouterJ","followers_url":"https://api.github.com/users/WouterJ/followers","following_url":"https://api.github.com/users/WouterJ/following{/other_user}","gists_url":"https://api.github.com/users/WouterJ/gists{/gist_id}","starred_url":"https://api.github.com/users/WouterJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WouterJ/subscriptions","organizations_url":"https://api.github.com/users/WouterJ/orgs","repos_url":"https://api.github.com/users/WouterJ/repos","events_url":"https://api.github.com/users/WouterJ/events{/privacy}","received_events_url":"https://api.github.com/users/WouterJ/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/symfony-cmf/CoreBundle/labels/in%20progress","name":"in progress","color":"ededed"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-02-10T11:27:00Z","updated_at":"2015-02-12T12:21:53Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/symfony-cmf/CoreBundle/pulls/160","html_url":"https://github.com/symfony-cmf/CoreBundle/pull/160","diff_url":"https://github.com/symfony-cmf/CoreBundle/pull/160.diff","patch_url":"https://github.com/symfony-cmf/CoreBundle/pull/160.patch"},"body":"All these services aren't created for public usage. By making them private, they'll be removed during compilation time once no other service depends on it and if only one service depends on it, initialization will be inlined. Both improve the container performance.\r\n\r\nBesides this, it has also become a best practice."},"comment":{"url":"https://api.github.com/repos/symfony-cmf/CoreBundle/issues/comments/74062331","html_url":"https://github.com/symfony-cmf/CoreBundle/pull/160#issuecomment-74062331","issue_url":"https://api.github.com/repos/symfony-cmf/CoreBundle/issues/160","id":74062331,"user":{"login":"lsmith77","id":300279,"avatar_url":"https://avatars.githubusercontent.com/u/300279?v=3","gravatar_id":"","url":"https://api.github.com/users/lsmith77","html_url":"https://github.com/lsmith77","followers_url":"https://api.github.com/users/lsmith77/followers","following_url":"https://api.github.com/users/lsmith77/following{/other_user}","gists_url":"https://api.github.com/users/lsmith77/gists{/gist_id}","starred_url":"https://api.github.com/users/lsmith77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsmith77/subscriptions","organizations_url":"https://api.github.com/users/lsmith77/orgs","repos_url":"https://api.github.com/users/lsmith77/repos","events_url":"https://api.github.com/users/lsmith77/events{/privacy}","received_events_url":"https://api.github.com/users/lsmith77/received_events","type":"User","site_admin":false},"created_at":"2015-02-12T12:21:53Z","updated_at":"2015-02-12T12:21:53Z","body":"@dbu: master branch is for the next minor release"}}