{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/25597111","id":25597111,"diff_hunk":"@@ -205,16 +205,97 @@ function L10nManager(gaiaDir,\n \n       var doc = utils.getDocument(content);\n \n-      buildL10nMeta(htmlFile, doc);\n+      return buildL10nMeta(htmlFile, doc).then(function() {\n+        if (self.localeBasedir) {\n+          // Copy resource files into build_stage directory\n+          getL10nResources(htmlFile, webapp, doc);\n+        }\n+      });\n+    });\n+\n+    return Promise.all(localizeHtmlFiles);","path":"build/multilocale.js","position":22,"original_position":22,"commit_id":"4c4f8adf8f70936b81ccce5dd4a537e995b01abe","original_commit_id":"4c4f8adf8f70936b81ccce5dd4a537e995b01abe","user":{"login":"ochameau","id":199907,"avatar_url":"https://avatars.githubusercontent.com/u/199907?v=3","gravatar_id":"","url":"https://api.github.com/users/ochameau","html_url":"https://github.com/ochameau","followers_url":"https://api.github.com/users/ochameau/followers","following_url":"https://api.github.com/users/ochameau/following{/other_user}","gists_url":"https://api.github.com/users/ochameau/gists{/gist_id}","starred_url":"https://api.github.com/users/ochameau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ochameau/subscriptions","organizations_url":"https://api.github.com/users/ochameau/orgs","repos_url":"https://api.github.com/users/ochameau/repos","events_url":"https://api.github.com/users/ochameau/events{/privacy}","received_events_url":"https://api.github.com/users/ochameau/received_events","type":"User","site_admin":false},"body":"Note that Promise.all is often misleading... If any of the promises in the fail refects, it will immediately resolve, no matter if the next ones are still running and still not resolved!\r\nHere, if we resolve too quickly and don't have processEvent call, we may easily have broken localization!","created_at":"2015-03-02T13:17:48Z","updated_at":"2015-03-02T13:17:48Z","html_url":"https://github.com/mozilla-b2g/gaia/pull/28475#discussion_r25597111","pull_request_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/28475","_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/25597111"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/28475#discussion_r25597111"},"pull_request":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/28475"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/28475","id":30028198,"html_url":"https://github.com/mozilla-b2g/gaia/pull/28475","diff_url":"https://github.com/mozilla-b2g/gaia/pull/28475.diff","patch_url":"https://github.com/mozilla-b2g/gaia/pull/28475.patch","issue_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/28475","number":28475,"state":"open","locked":false,"title":"Bug 1116613 - Develop a smart strategy for building language timestamps at build time","user":{"login":"zbraniecki","id":449986,"avatar_url":"https://avatars.githubusercontent.com/u/449986?v=3","gravatar_id":"","url":"https://api.github.com/users/zbraniecki","html_url":"https://github.com/zbraniecki","followers_url":"https://api.github.com/users/zbraniecki/followers","following_url":"https://api.github.com/users/zbraniecki/following{/other_user}","gists_url":"https://api.github.com/users/zbraniecki/gists{/gist_id}","starred_url":"https://api.github.com/users/zbraniecki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zbraniecki/subscriptions","organizations_url":"https://api.github.com/users/zbraniecki/orgs","repos_url":"https://api.github.com/users/zbraniecki/repos","events_url":"https://api.github.com/users/zbraniecki/events{/privacy}","received_events_url":"https://api.github.com/users/zbraniecki/received_events","type":"User","site_admin":false},"body":"https://bugzilla.mozilla.org/show_bug.cgi?id=1116613","created_at":"2015-02-25T21:42:17Z","updated_at":"2015-03-02T13:17:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"75eea2db810e715ac5ba7f58683dcf5331d80840","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/28475/commits","review_comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/28475/comments","review_comment_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/28475/comments","statuses_url":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/4c4f8adf8f70936b81ccce5dd4a537e995b01abe","head":{"label":"zbraniecki:1116613-smart-strategy-for-l10n-timestamps","ref":"1116613-smart-strategy-for-l10n-timestamps","sha":"4c4f8adf8f70936b81ccce5dd4a537e995b01abe","user":{"login":"zbraniecki","id":449986,"avatar_url":"https://avatars.githubusercontent.com/u/449986?v=3","gravatar_id":"","url":"https://api.github.com/users/zbraniecki","html_url":"https://github.com/zbraniecki","followers_url":"https://api.github.com/users/zbraniecki/followers","following_url":"https://api.github.com/users/zbraniecki/following{/other_user}","gists_url":"https://api.github.com/users/zbraniecki/gists{/gist_id}","starred_url":"https://api.github.com/users/zbraniecki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zbraniecki/subscriptions","organizations_url":"https://api.github.com/users/zbraniecki/orgs","repos_url":"https://api.github.com/users/zbraniecki/repos","events_url":"https://api.github.com/users/zbraniecki/events{/privacy}","received_events_url":"https://api.github.com/users/zbraniecki/received_events","type":"User","site_admin":false},"repo":{"id":3201939,"name":"gaia","full_name":"zbraniecki/gaia","owner":{"login":"zbraniecki","id":449986,"avatar_url":"https://avatars.githubusercontent.com/u/449986?v=3","gravatar_id":"","url":"https://api.github.com/users/zbraniecki","html_url":"https://github.com/zbraniecki","followers_url":"https://api.github.com/users/zbraniecki/followers","following_url":"https://api.github.com/users/zbraniecki/following{/other_user}","gists_url":"https://api.github.com/users/zbraniecki/gists{/gist_id}","starred_url":"https://api.github.com/users/zbraniecki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zbraniecki/subscriptions","organizations_url":"https://api.github.com/users/zbraniecki/orgs","repos_url":"https://api.github.com/users/zbraniecki/repos","events_url":"https://api.github.com/users/zbraniecki/events{/privacy}","received_events_url":"https://api.github.com/users/zbraniecki/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zbraniecki/gaia","description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project","fork":true,"url":"https://api.github.com/repos/zbraniecki/gaia","forks_url":"https://api.github.com/repos/zbraniecki/gaia/forks","keys_url":"https://api.github.com/repos/zbraniecki/gaia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zbraniecki/gaia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zbraniecki/gaia/teams","hooks_url":"https://api.github.com/repos/zbraniecki/gaia/hooks","issue_events_url":"https://api.github.com/repos/zbraniecki/gaia/issues/events{/number}","events_url":"https://api.github.com/repos/zbraniecki/gaia/events","assignees_url":"https://api.github.com/repos/zbraniecki/gaia/assignees{/user}","branches_url":"https://api.github.com/repos/zbraniecki/gaia/branches{/branch}","tags_url":"https://api.github.com/repos/zbraniecki/gaia/tags","blobs_url":"https://api.github.com/repos/zbraniecki/gaia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zbraniecki/gaia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zbraniecki/gaia/git/refs{/sha}","trees_url":"https://api.github.com/repos/zbraniecki/gaia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zbraniecki/gaia/statuses/{sha}","languages_url":"https://api.github.com/repos/zbraniecki/gaia/languages","stargazers_url":"https://api.github.com/repos/zbraniecki/gaia/stargazers","contributors_url":"https://api.github.com/repos/zbraniecki/gaia/contributors","subscribers_url":"https://api.github.com/repos/zbraniecki/gaia/subscribers","subscription_url":"https://api.github.com/repos/zbraniecki/gaia/subscription","commits_url":"https://api.github.com/repos/zbraniecki/gaia/commits{/sha}","git_commits_url":"https://api.github.com/repos/zbraniecki/gaia/git/commits{/sha}","comments_url":"https://api.github.com/repos/zbraniecki/gaia/comments{/number}","issue_comment_url":"https://api.github.com/repos/zbraniecki/gaia/issues/comments{/number}","contents_url":"https://api.github.com/repos/zbraniecki/gaia/contents/{+path}","compare_url":"https://api.github.com/repos/zbraniecki/gaia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zbraniecki/gaia/merges","archive_url":"https://api.github.com/repos/zbraniecki/gaia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zbraniecki/gaia/downloads","issues_url":"https://api.github.com/repos/zbraniecki/gaia/issues{/number}","pulls_url":"https://api.github.com/repos/zbraniecki/gaia/pulls{/number}","milestones_url":"https://api.github.com/repos/zbraniecki/gaia/milestones{/number}","notifications_url":"https://api.github.com/repos/zbraniecki/gaia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zbraniecki/gaia/labels{/name}","releases_url":"https://api.github.com/repos/zbraniecki/gaia/releases{/id}","created_at":"2012-01-17T18:30:26Z","updated_at":"2014-12-29T23:00:20Z","pushed_at":"2015-02-26T22:36:46Z","git_url":"git://github.com/zbraniecki/gaia.git","ssh_url":"git@github.com:zbraniecki/gaia.git","clone_url":"https://github.com/zbraniecki/gaia.git","svn_url":"https://github.com/zbraniecki/gaia","homepage":"https://wiki.mozilla.org/B2G","size":865531,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"mozilla-b2g:master","ref":"master","sha":"5693ecba5e54062700b77e3d4e5a0a12f969edcc","user":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"repo":{"id":2317369,"name":"gaia","full_name":"mozilla-b2g/gaia","owner":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-b2g/gaia","description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see","fork":false,"url":"https://api.github.com/repos/mozilla-b2g/gaia","forks_url":"https://api.github.com/repos/mozilla-b2g/gaia/forks","keys_url":"https://api.github.com/repos/mozilla-b2g/gaia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-b2g/gaia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-b2g/gaia/teams","hooks_url":"https://api.github.com/repos/mozilla-b2g/gaia/hooks","issue_events_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-b2g/gaia/events","assignees_url":"https://api.github.com/repos/mozilla-b2g/gaia/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-b2g/gaia/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-b2g/gaia/tags","blobs_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-b2g/gaia/languages","stargazers_url":"https://api.github.com/repos/mozilla-b2g/gaia/stargazers","contributors_url":"https://api.github.com/repos/mozilla-b2g/gaia/contributors","subscribers_url":"https://api.github.com/repos/mozilla-b2g/gaia/subscribers","subscription_url":"https://api.github.com/repos/mozilla-b2g/gaia/subscription","commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla-b2g/gaia/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-b2g/gaia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-b2g/gaia/merges","archive_url":"https://api.github.com/repos/mozilla-b2g/gaia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-b2g/gaia/downloads","issues_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-b2g/gaia/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-b2g/gaia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-b2g/gaia/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-b2g/gaia/releases{/id}","created_at":"2011-09-03T01:38:46Z","updated_at":"2015-03-02T12:25:33Z","pushed_at":"2015-03-02T12:25:43Z","git_url":"git://github.com/mozilla-b2g/gaia.git","ssh_url":"git@github.com:mozilla-b2g/gaia.git","clone_url":"https://github.com/mozilla-b2g/gaia.git","svn_url":"https://github.com/mozilla-b2g/gaia","homepage":"https://wiki.mozilla.org/B2G","size":1436936,"stargazers_count":1881,"watchers_count":1881,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2233,"mirror_url":null,"open_issues_count":888,"forks":2233,"open_issues":888,"watchers":1881,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/28475"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/28475"},"issue":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/issues/28475"},"comments":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/issues/28475/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/28475/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/28475/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/4c4f8adf8f70936b81ccce5dd4a537e995b01abe"}}}}