{"action":"created","comment":{"url":"https://api.github.com/repos/inveniosoftware/invenio/pulls/comments/29690451","id":29690451,"diff_hunk":"@@ -243,14 +243,14 @@ def perform_request_editsource(oai_src_id=None, oai_src_name='',\n                 oai_src_post = []\n \n             oai_src = OaiHARVEST.query.get(oai_src_id)\n-            oai_src.setspecs = \" \".join(oai_src_sets)\n-            oai_src.baseurl = oai_src_baseurl\n-            oai_src.name = oai_src_name\n-            oai_src.metadataprefix = oai_src_prefix\n-            oai_src.postprocess = \"-\".join(oai_src_post)\n+            oai_src.setspecs = \" \".join(oai_src_sets).strip()","path":"invenio/legacy/oaiharvest/admin.py","position":9,"original_position":9,"commit_id":"c09606712677178df081684c5da587385ae8ad74","original_commit_id":"c09606712677178df081684c5da587385ae8ad74","user":{"login":"jirikuncar","id":189798,"avatar_url":"https://avatars.githubusercontent.com/u/189798?v=3","gravatar_id":"","url":"https://api.github.com/users/jirikuncar","html_url":"https://github.com/jirikuncar","followers_url":"https://api.github.com/users/jirikuncar/followers","following_url":"https://api.github.com/users/jirikuncar/following{/other_user}","gists_url":"https://api.github.com/users/jirikuncar/gists{/gist_id}","starred_url":"https://api.github.com/users/jirikuncar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jirikuncar/subscriptions","organizations_url":"https://api.github.com/users/jirikuncar/orgs","repos_url":"https://api.github.com/users/jirikuncar/repos","events_url":"https://api.github.com/users/jirikuncar/events{/privacy}","received_events_url":"https://api.github.com/users/jirikuncar/received_events","type":"User","site_admin":false},"body":"maybe it would be better to create validators/setters for the fields in model, wdyt?","created_at":"2015-05-05T17:14:02Z","updated_at":"2015-05-05T17:14:02Z","html_url":"https://github.com/inveniosoftware/invenio/pull/3090#discussion_r29690451","pull_request_url":"https://api.github.com/repos/inveniosoftware/invenio/pulls/3090","_links":{"self":{"href":"https://api.github.com/repos/inveniosoftware/invenio/pulls/comments/29690451"},"html":{"href":"https://github.com/inveniosoftware/invenio/pull/3090#discussion_r29690451"},"pull_request":{"href":"https://api.github.com/repos/inveniosoftware/invenio/pulls/3090"}}},"pull_request":{"url":"https://api.github.com/repos/inveniosoftware/invenio/pulls/3090","id":34743812,"html_url":"https://github.com/inveniosoftware/invenio/pull/3090","diff_url":"https://github.com/inveniosoftware/invenio/pull/3090.diff","patch_url":"https://github.com/inveniosoftware/invenio/pull/3090.patch","issue_url":"https://api.github.com/repos/inveniosoftware/invenio/issues/3090","number":3090,"state":"open","locked":false,"title":"legacy: OAI Harvest admin input stripping","user":{"login":"jalavik","id":633680,"avatar_url":"https://avatars.githubusercontent.com/u/633680?v=3","gravatar_id":"","url":"https://api.github.com/users/jalavik","html_url":"https://github.com/jalavik","followers_url":"https://api.github.com/users/jalavik/followers","following_url":"https://api.github.com/users/jalavik/following{/other_user}","gists_url":"https://api.github.com/users/jalavik/gists{/gist_id}","starred_url":"https://api.github.com/users/jalavik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jalavik/subscriptions","organizations_url":"https://api.github.com/users/jalavik/orgs","repos_url":"https://api.github.com/users/jalavik/repos","events_url":"https://api.github.com/users/jalavik/events{/privacy}","received_events_url":"https://api.github.com/users/jalavik/received_events","type":"User","site_admin":false},"body":"* Strips the input of certain fields when adding and editing\r\n  OAI harvest source configurations.\r\n\r\nSigned-off-by: Jan Aage Lavik <jan.age.lavik@cern.ch>","created_at":"2015-05-05T16:46:59Z","updated_at":"2015-05-05T17:14:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"83008d99d285c46c3d819a277c72b4dd8c4a924a","assignee":{"login":"jirikuncar","id":189798,"avatar_url":"https://avatars.githubusercontent.com/u/189798?v=3","gravatar_id":"","url":"https://api.github.com/users/jirikuncar","html_url":"https://github.com/jirikuncar","followers_url":"https://api.github.com/users/jirikuncar/followers","following_url":"https://api.github.com/users/jirikuncar/following{/other_user}","gists_url":"https://api.github.com/users/jirikuncar/gists{/gist_id}","starred_url":"https://api.github.com/users/jirikuncar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jirikuncar/subscriptions","organizations_url":"https://api.github.com/users/jirikuncar/orgs","repos_url":"https://api.github.com/users/jirikuncar/repos","events_url":"https://api.github.com/users/jirikuncar/events{/privacy}","received_events_url":"https://api.github.com/users/jirikuncar/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/inveniosoftware/invenio/milestones/13","html_url":"https://github.com/inveniosoftware/invenio/milestones/v2.1.0","labels_url":"https://api.github.com/repos/inveniosoftware/invenio/milestones/13/labels","id":857114,"number":13,"title":"v2.1.0","description":"","creator":{"login":"tiborsimko","id":517546,"avatar_url":"https://avatars.githubusercontent.com/u/517546?v=3","gravatar_id":"","url":"https://api.github.com/users/tiborsimko","html_url":"https://github.com/tiborsimko","followers_url":"https://api.github.com/users/tiborsimko/followers","following_url":"https://api.github.com/users/tiborsimko/following{/other_user}","gists_url":"https://api.github.com/users/tiborsimko/gists{/gist_id}","starred_url":"https://api.github.com/users/tiborsimko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiborsimko/subscriptions","organizations_url":"https://api.github.com/users/tiborsimko/orgs","repos_url":"https://api.github.com/users/tiborsimko/repos","events_url":"https://api.github.com/users/tiborsimko/events{/privacy}","received_events_url":"https://api.github.com/users/tiborsimko/received_events","type":"User","site_admin":false},"open_issues":21,"closed_issues":138,"state":"open","created_at":"2014-11-07T09:21:23Z","updated_at":"2015-05-05T16:56:57Z","due_on":"2015-05-07T22:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/inveniosoftware/invenio/pulls/3090/commits","review_comments_url":"https://api.github.com/repos/inveniosoftware/invenio/pulls/3090/comments","review_comment_url":"https://api.github.com/repos/inveniosoftware/invenio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/inveniosoftware/invenio/issues/3090/comments","statuses_url":"https://api.github.com/repos/inveniosoftware/invenio/statuses/c09606712677178df081684c5da587385ae8ad74","head":{"label":"jalavik:oaiharvest-admin-strip-input","ref":"oaiharvest-admin-strip-input","sha":"c09606712677178df081684c5da587385ae8ad74","user":{"login":"jalavik","id":633680,"avatar_url":"https://avatars.githubusercontent.com/u/633680?v=3","gravatar_id":"","url":"https://api.github.com/users/jalavik","html_url":"https://github.com/jalavik","followers_url":"https://api.github.com/users/jalavik/followers","following_url":"https://api.github.com/users/jalavik/following{/other_user}","gists_url":"https://api.github.com/users/jalavik/gists{/gist_id}","starred_url":"https://api.github.com/users/jalavik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jalavik/subscriptions","organizations_url":"https://api.github.com/users/jalavik/orgs","repos_url":"https://api.github.com/users/jalavik/repos","events_url":"https://api.github.com/users/jalavik/events{/privacy}","received_events_url":"https://api.github.com/users/jalavik/received_events","type":"User","site_admin":false},"repo":{"id":16108151,"name":"invenio","full_name":"jalavik/invenio","owner":{"login":"jalavik","id":633680,"avatar_url":"https://avatars.githubusercontent.com/u/633680?v=3","gravatar_id":"","url":"https://api.github.com/users/jalavik","html_url":"https://github.com/jalavik","followers_url":"https://api.github.com/users/jalavik/followers","following_url":"https://api.github.com/users/jalavik/following{/other_user}","gists_url":"https://api.github.com/users/jalavik/gists{/gist_id}","starred_url":"https://api.github.com/users/jalavik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jalavik/subscriptions","organizations_url":"https://api.github.com/users/jalavik/orgs","repos_url":"https://api.github.com/users/jalavik/repos","events_url":"https://api.github.com/users/jalavik/events{/privacy}","received_events_url":"https://api.github.com/users/jalavik/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jalavik/invenio","description":"Invenio source code mirror.  Please use Trac for collaborating.","fork":true,"url":"https://api.github.com/repos/jalavik/invenio","forks_url":"https://api.github.com/repos/jalavik/invenio/forks","keys_url":"https://api.github.com/repos/jalavik/invenio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jalavik/invenio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jalavik/invenio/teams","hooks_url":"https://api.github.com/repos/jalavik/invenio/hooks","issue_events_url":"https://api.github.com/repos/jalavik/invenio/issues/events{/number}","events_url":"https://api.github.com/repos/jalavik/invenio/events","assignees_url":"https://api.github.com/repos/jalavik/invenio/assignees{/user}","branches_url":"https://api.github.com/repos/jalavik/invenio/branches{/branch}","tags_url":"https://api.github.com/repos/jalavik/invenio/tags","blobs_url":"https://api.github.com/repos/jalavik/invenio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jalavik/invenio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jalavik/invenio/git/refs{/sha}","trees_url":"https://api.github.com/repos/jalavik/invenio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jalavik/invenio/statuses/{sha}","languages_url":"https://api.github.com/repos/jalavik/invenio/languages","stargazers_url":"https://api.github.com/repos/jalavik/invenio/stargazers","contributors_url":"https://api.github.com/repos/jalavik/invenio/contributors","subscribers_url":"https://api.github.com/repos/jalavik/invenio/subscribers","subscription_url":"https://api.github.com/repos/jalavik/invenio/subscription","commits_url":"https://api.github.com/repos/jalavik/invenio/commits{/sha}","git_commits_url":"https://api.github.com/repos/jalavik/invenio/git/commits{/sha}","comments_url":"https://api.github.com/repos/jalavik/invenio/comments{/number}","issue_comment_url":"https://api.github.com/repos/jalavik/invenio/issues/comments{/number}","contents_url":"https://api.github.com/repos/jalavik/invenio/contents/{+path}","compare_url":"https://api.github.com/repos/jalavik/invenio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jalavik/invenio/merges","archive_url":"https://api.github.com/repos/jalavik/invenio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jalavik/invenio/downloads","issues_url":"https://api.github.com/repos/jalavik/invenio/issues{/number}","pulls_url":"https://api.github.com/repos/jalavik/invenio/pulls{/number}","milestones_url":"https://api.github.com/repos/jalavik/invenio/milestones{/number}","notifications_url":"https://api.github.com/repos/jalavik/invenio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jalavik/invenio/labels{/name}","releases_url":"https://api.github.com/repos/jalavik/invenio/releases{/id}","created_at":"2014-01-21T16:12:18Z","updated_at":"2014-08-15T07:38:00Z","pushed_at":"2015-05-05T17:02:07Z","git_url":"git://github.com/jalavik/invenio.git","ssh_url":"git@github.com:jalavik/invenio.git","clone_url":"https://github.com/jalavik/invenio.git","svn_url":"https://github.com/jalavik/invenio","homepage":"http://invenio-software.org/","size":89790,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"inveniosoftware:master","ref":"master","sha":"8030c0c3f3d8adeb7b192ca9b4e0a9e091ba5d10","user":{"login":"inveniosoftware","id":1157480,"avatar_url":"https://avatars.githubusercontent.com/u/1157480?v=3","gravatar_id":"","url":"https://api.github.com/users/inveniosoftware","html_url":"https://github.com/inveniosoftware","followers_url":"https://api.github.com/users/inveniosoftware/followers","following_url":"https://api.github.com/users/inveniosoftware/following{/other_user}","gists_url":"https://api.github.com/users/inveniosoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/inveniosoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inveniosoftware/subscriptions","organizations_url":"https://api.github.com/users/inveniosoftware/orgs","repos_url":"https://api.github.com/users/inveniosoftware/repos","events_url":"https://api.github.com/users/inveniosoftware/events{/privacy}","received_events_url":"https://api.github.com/users/inveniosoftware/received_events","type":"Organization","site_admin":false},"repo":{"id":2665618,"name":"invenio","full_name":"inveniosoftware/invenio","owner":{"login":"inveniosoftware","id":1157480,"avatar_url":"https://avatars.githubusercontent.com/u/1157480?v=3","gravatar_id":"","url":"https://api.github.com/users/inveniosoftware","html_url":"https://github.com/inveniosoftware","followers_url":"https://api.github.com/users/inveniosoftware/followers","following_url":"https://api.github.com/users/inveniosoftware/following{/other_user}","gists_url":"https://api.github.com/users/inveniosoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/inveniosoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inveniosoftware/subscriptions","organizations_url":"https://api.github.com/users/inveniosoftware/orgs","repos_url":"https://api.github.com/users/inveniosoftware/repos","events_url":"https://api.github.com/users/inveniosoftware/events{/privacy}","received_events_url":"https://api.github.com/users/inveniosoftware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/inveniosoftware/invenio","description":"Invenio digital library software","fork":false,"url":"https://api.github.com/repos/inveniosoftware/invenio","forks_url":"https://api.github.com/repos/inveniosoftware/invenio/forks","keys_url":"https://api.github.com/repos/inveniosoftware/invenio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/inveniosoftware/invenio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/inveniosoftware/invenio/teams","hooks_url":"https://api.github.com/repos/inveniosoftware/invenio/hooks","issue_events_url":"https://api.github.com/repos/inveniosoftware/invenio/issues/events{/number}","events_url":"https://api.github.com/repos/inveniosoftware/invenio/events","assignees_url":"https://api.github.com/repos/inveniosoftware/invenio/assignees{/user}","branches_url":"https://api.github.com/repos/inveniosoftware/invenio/branches{/branch}","tags_url":"https://api.github.com/repos/inveniosoftware/invenio/tags","blobs_url":"https://api.github.com/repos/inveniosoftware/invenio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/inveniosoftware/invenio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/inveniosoftware/invenio/git/refs{/sha}","trees_url":"https://api.github.com/repos/inveniosoftware/invenio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/inveniosoftware/invenio/statuses/{sha}","languages_url":"https://api.github.com/repos/inveniosoftware/invenio/languages","stargazers_url":"https://api.github.com/repos/inveniosoftware/invenio/stargazers","contributors_url":"https://api.github.com/repos/inveniosoftware/invenio/contributors","subscribers_url":"https://api.github.com/repos/inveniosoftware/invenio/subscribers","subscription_url":"https://api.github.com/repos/inveniosoftware/invenio/subscription","commits_url":"https://api.github.com/repos/inveniosoftware/invenio/commits{/sha}","git_commits_url":"https://api.github.com/repos/inveniosoftware/invenio/git/commits{/sha}","comments_url":"https://api.github.com/repos/inveniosoftware/invenio/comments{/number}","issue_comment_url":"https://api.github.com/repos/inveniosoftware/invenio/issues/comments{/number}","contents_url":"https://api.github.com/repos/inveniosoftware/invenio/contents/{+path}","compare_url":"https://api.github.com/repos/inveniosoftware/invenio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/inveniosoftware/invenio/merges","archive_url":"https://api.github.com/repos/inveniosoftware/invenio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/inveniosoftware/invenio/downloads","issues_url":"https://api.github.com/repos/inveniosoftware/invenio/issues{/number}","pulls_url":"https://api.github.com/repos/inveniosoftware/invenio/pulls{/number}","milestones_url":"https://api.github.com/repos/inveniosoftware/invenio/milestones{/number}","notifications_url":"https://api.github.com/repos/inveniosoftware/invenio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/inveniosoftware/invenio/labels{/name}","releases_url":"https://api.github.com/repos/inveniosoftware/invenio/releases{/id}","created_at":"2011-10-28T14:33:51Z","updated_at":"2015-05-05T14:04:33Z","pushed_at":"2015-05-05T17:02:07Z","git_url":"git://github.com/inveniosoftware/invenio.git","ssh_url":"git@github.com:inveniosoftware/invenio.git","clone_url":"https://github.com/inveniosoftware/invenio.git","svn_url":"https://github.com/inveniosoftware/invenio","homepage":"http://invenio-software.org/","size":108451,"stargazers_count":61,"watchers_count":61,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":122,"mirror_url":null,"open_issues_count":764,"forks":122,"open_issues":764,"watchers":61,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/inveniosoftware/invenio/pulls/3090"},"html":{"href":"https://github.com/inveniosoftware/invenio/pull/3090"},"issue":{"href":"https://api.github.com/repos/inveniosoftware/invenio/issues/3090"},"comments":{"href":"https://api.github.com/repos/inveniosoftware/invenio/issues/3090/comments"},"review_comments":{"href":"https://api.github.com/repos/inveniosoftware/invenio/pulls/3090/comments"},"review_comment":{"href":"https://api.github.com/repos/inveniosoftware/invenio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/inveniosoftware/invenio/pulls/3090/commits"},"statuses":{"href":"https://api.github.com/repos/inveniosoftware/invenio/statuses/c09606712677178df081684c5da587385ae8ad74"}}}}