{"action":"created","issue":{"url":"https://api.github.com/repos/apache/incubator-zeppelin/issues/245","labels_url":"https://api.github.com/repos/apache/incubator-zeppelin/issues/245/labels{/name}","comments_url":"https://api.github.com/repos/apache/incubator-zeppelin/issues/245/comments","events_url":"https://api.github.com/repos/apache/incubator-zeppelin/issues/245/events","html_url":"https://github.com/apache/incubator-zeppelin/pull/245","id":102507584,"number":245,"title":"Fix NotebookList Ordering","user":{"login":"corneadoug","id":710411,"avatar_url":"https://avatars.githubusercontent.com/u/710411?v=3","gravatar_id":"","url":"https://api.github.com/users/corneadoug","html_url":"https://github.com/corneadoug","followers_url":"https://api.github.com/users/corneadoug/followers","following_url":"https://api.github.com/users/corneadoug/following{/other_user}","gists_url":"https://api.github.com/users/corneadoug/gists{/gist_id}","starred_url":"https://api.github.com/users/corneadoug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corneadoug/subscriptions","organizations_url":"https://api.github.com/users/corneadoug/orgs","repos_url":"https://api.github.com/users/corneadoug/repos","events_url":"https://api.github.com/users/corneadoug/events{/privacy}","received_events_url":"https://api.github.com/users/corneadoug/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-08-22T06:04:05Z","updated_at":"2015-08-25T05:06:12Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/incubator-zeppelin/pulls/245","html_url":"https://github.com/apache/incubator-zeppelin/pull/245","diff_url":"https://github.com/apache/incubator-zeppelin/pull/245.diff","patch_url":"https://github.com/apache/incubator-zeppelin/pull/245.patch"},"body":"In the notebook list, the notebooks that have been created without name (empty name) and prefixed with 'Note' are not ordered correctly with the others.\r\n\r\nThe reason behind it, is that when notebook doesn't have a name, we use the notebook id and prefix it by 'Note'. At that time the list was already ordered and therefore the Name shown doesn't match the position in the list.\r\n\r\nBefore:\r\n![screen shot 2015-08-22 at 2 48 56 pm](https://cloud.githubusercontent.com/assets/710411/9422740/f9d7a496-48dc-11e5-9326-bfddd16dd66d.png)\r\n\r\nAfter:\r\n![screen shot 2015-08-22 at 2 30 26 pm](https://cloud.githubusercontent.com/assets/710411/9422688/6fdc69f4-48da-11e5-8f39-5752369942ab.png)\r\n\r\nThe Fix I have is to have an ordering function at the place we prefix the 'Note' on the front side.\r\nAnother solution could be to just to have by default the notebook name as 'Note ' + note.id when we create a note. The second option could probably be better performance wise, however it wouldn't be backward compatible."},"comment":{"url":"https://api.github.com/repos/apache/incubator-zeppelin/issues/comments/134476049","html_url":"https://github.com/apache/incubator-zeppelin/pull/245#issuecomment-134476049","issue_url":"https://api.github.com/repos/apache/incubator-zeppelin/issues/245","id":134476049,"user":{"login":"Madhuka","id":1180128,"avatar_url":"https://avatars.githubusercontent.com/u/1180128?v=3","gravatar_id":"","url":"https://api.github.com/users/Madhuka","html_url":"https://github.com/Madhuka","followers_url":"https://api.github.com/users/Madhuka/followers","following_url":"https://api.github.com/users/Madhuka/following{/other_user}","gists_url":"https://api.github.com/users/Madhuka/gists{/gist_id}","starred_url":"https://api.github.com/users/Madhuka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Madhuka/subscriptions","organizations_url":"https://api.github.com/users/Madhuka/orgs","repos_url":"https://api.github.com/users/Madhuka/repos","events_url":"https://api.github.com/users/Madhuka/events{/privacy}","received_events_url":"https://api.github.com/users/Madhuka/received_events","type":"User","site_admin":false},"created_at":"2015-08-25T05:06:12Z","updated_at":"2015-08-25T05:06:12Z","body":"+1 for \r\n"}}