{"action":"created","issue":{"url":"https://api.github.com/repos/weaveworks/weave/issues/991","labels_url":"https://api.github.com/repos/weaveworks/weave/issues/991/labels{/name}","comments_url":"https://api.github.com/repos/weaveworks/weave/issues/991/comments","events_url":"https://api.github.com/repos/weaveworks/weave/issues/991/events","html_url":"https://github.com/weaveworks/weave/pull/991","id":90422683,"number":991,"title":"Fast datapath preparations","user":{"login":"dpw","id":15074,"avatar_url":"https://avatars.githubusercontent.com/u/15074?v=3","gravatar_id":"","url":"https://api.github.com/users/dpw","html_url":"https://github.com/dpw","followers_url":"https://api.github.com/users/dpw/followers","following_url":"https://api.github.com/users/dpw/following{/other_user}","gists_url":"https://api.github.com/users/dpw/gists{/gist_id}","starred_url":"https://api.github.com/users/dpw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpw/subscriptions","organizations_url":"https://api.github.com/users/dpw/orgs","repos_url":"https://api.github.com/users/dpw/repos","events_url":"https://api.github.com/users/dpw/events{/privacy}","received_events_url":"https://api.github.com/users/dpw/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"awh","id":1504438,"avatar_url":"https://avatars.githubusercontent.com/u/1504438?v=3","gravatar_id":"","url":"https://api.github.com/users/awh","html_url":"https://github.com/awh","followers_url":"https://api.github.com/users/awh/followers","following_url":"https://api.github.com/users/awh/following{/other_user}","gists_url":"https://api.github.com/users/awh/gists{/gist_id}","starred_url":"https://api.github.com/users/awh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awh/subscriptions","organizations_url":"https://api.github.com/users/awh/orgs","repos_url":"https://api.github.com/users/awh/repos","events_url":"https://api.github.com/users/awh/events{/privacy}","received_events_url":"https://api.github.com/users/awh/received_events","type":"User","site_admin":false},"milestone":null,"comments":51,"created_at":"2015-06-23T15:41:47Z","updated_at":"2015-08-13T09:44:17Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/weaveworks/weave/pulls/991","html_url":"https://github.com/weaveworks/weave/pull/991","diff_url":"https://github.com/weaveworks/weave/pull/991.diff","patch_url":"https://github.com/weaveworks/weave/pull/991.patch"},"body":"These are the changes to the existing router code to prepare the way for fast datapath.  I didn't include the short peer ID changes, as they are much more tailored to ODP specifics, and so they make more sense as part of the fast datapath PR.\r\n\r\nI think this is clean enough for a review pass.  There is still one point I'm not quite happy with yet:  The names \"IntraHost\" and \"InterHost\" were intended as stand-ins, until I came up with better names.  But I still haven't come up with replacements that seem obviously better (the best so far is PacketCapture and PacketTransport but they are longer, and PacketCapture isn't right because that interface includes sending, plus PacketCapture has too much affinity with pcap).  I'm hoping inspiration will strike by the time this is merge-ready, and welcome any suggestions."},"comment":{"url":"https://api.github.com/repos/weaveworks/weave/issues/comments/130593185","html_url":"https://github.com/weaveworks/weave/pull/991#issuecomment-130593185","issue_url":"https://api.github.com/repos/weaveworks/weave/issues/991","id":130593185,"user":{"login":"awh","id":1504438,"avatar_url":"https://avatars.githubusercontent.com/u/1504438?v=3","gravatar_id":"","url":"https://api.github.com/users/awh","html_url":"https://github.com/awh","followers_url":"https://api.github.com/users/awh/followers","following_url":"https://api.github.com/users/awh/following{/other_user}","gists_url":"https://api.github.com/users/awh/gists{/gist_id}","starred_url":"https://api.github.com/users/awh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awh/subscriptions","organizations_url":"https://api.github.com/users/awh/orgs","repos_url":"https://api.github.com/users/awh/repos","events_url":"https://api.github.com/users/awh/events{/privacy}","received_events_url":"https://api.github.com/users/awh/received_events","type":"User","site_admin":false},"created_at":"2015-08-13T09:44:17Z","updated_at":"2015-08-13T09:44:17Z","body":"I've just run the smoke tests again for the first time after the most recent rebase, and there are some things that no longer pass:\r\n\r\n````\r\n>>> Ran 34 tests, 5 failed\r\n>>> Fail ./250_dns_lookup_2_test.sh\r\n>>> Fail ./160_claim_3_test.sh\r\n>>> Fail ./210_dns_cross_hosts_3_test.sh\r\n>>> Fail ./660_proxy_ipam_2_test.sh\r\n>>> Fail ./120_discovery_3_test.sh\r\n````\r\n\r\nThe coverage report is interesting - `sleeve.go` is pretty well covered, except for the manual fragmentation path. Interestingly that *is* covered on current master due to @rade's new `105_frag_2_test.sh` so we should get some coverage there post upcoming rebase..."}}