{"comment":{"url":"https://api.github.com/repos/dtaht/sch_cake/comments/13715163","html_url":"https://github.com/dtaht/sch_cake/commit/55412714b3d0db929c2c7d3f84d881fb6db93ca1#commitcomment-13715163","id":13715163,"user":{"login":"moeller0","id":6169243,"avatar_url":"https://avatars.githubusercontent.com/u/6169243?v=3","gravatar_id":"","url":"https://api.github.com/users/moeller0","html_url":"https://github.com/moeller0","followers_url":"https://api.github.com/users/moeller0/followers","following_url":"https://api.github.com/users/moeller0/following{/other_user}","gists_url":"https://api.github.com/users/moeller0/gists{/gist_id}","starred_url":"https://api.github.com/users/moeller0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moeller0/subscriptions","organizations_url":"https://api.github.com/users/moeller0/orgs","repos_url":"https://api.github.com/users/moeller0/repos","events_url":"https://api.github.com/users/moeller0/events{/privacy}","received_events_url":"https://api.github.com/users/moeller0/received_events","type":"User","site_admin":false},"position":null,"line":null,"path":"","commit_id":"55412714b3d0db929c2c7d3f84d881fb6db93ca1","created_at":"2015-10-12T12:04:22Z","updated_at":"2015-10-12T12:04:22Z","body":"sigh.\n\nIn looking this code over again, interval is a 64 bit value in nsec in\nour version of codel, and needs no conversion into usec. It also seems\nto imply that all the conversion values are wrong throughout the code,\nand the api should expose a 64 bit value.\n\nOn Mon, Oct 12, 2015 at 1:49 PM, Sebastian Moeller <moeller0@gmx.de> wrote:\n> Hi Dave,\n>\n>\n> On Oct 12, 2015, at 13:16 , Dave Taht <dave.taht@gmail.com> wrote:\n>\n>> um, no, interval needs to be kept in usec, and converted more like I did.\n>\n>         I have not looked at your code yet. In tc (tc_utils.h or so) there is get_time() that knows how to deal with the default time specifiers like sec ms us… I believe from the tc side this should be used to parse the user input, just like Kevin’s code does. Now this needs to be passed to sch_cake.c, where I believe Kevin’s version expects milliseconds (MS2TIME(q->interval)), which does not do the right thing if the user specified “rtf 123usecs” on tic’s cli… So just getting rid of the MS2TIME called should do the trick, no?\n>\n> Best Regards\n>         Sebastian\n>\n>>\n>> On Mon, Oct 12, 2015 at 2:36 AM, Dave Taht <dave.taht@gmail.com> wrote:\n>>> On Mon, Oct 12, 2015 at 11:28 AM, Jonathan Morton <chromatix99@gmail.com> wrote:\n>>>>\n>>>>> On 12 Oct, 2015, at 12:24, Dave Taht <dave.taht@gmail.com> wrote:\n>>>>>\n>>>>> This is incorrect for the DC use case. We should be able to have the\n>>>>> target fall below at least 250us.\n>>>>\n>>>> Hey, I’m trying to work on this myself, but the code keeps changing under me.\n>>>\n>>> Tough. Deal with it. :) Once the rtt option works right toke and I can\n>>> finally go test the\n>>> count/2 idea out properly in the testbed, like, today. You otherwise\n>>> have the pen,\n>>> as far as I am concerned.\n>>>\n>>>>\n>>>> - Jonathan Morton\n>>>>\n>>>\n>>>\n>>>\n>>> --\n>>> Dave Täht\n>>> Do you want faster, better, wifi? https://www.patreon.com/dtaht\n>>\n>>\n>>\n>> --\n>> Dave Täht\n>> Do you want faster, better, wifi? https://www.patreon.com/dtaht\n>\n\n\n\n-- \nDave Täht\nDo you want faster, better, wifi? https://www.patreon.com/dtaht\n"}}