{"action":"created","comment":{"url":"https://api.github.com/repos/jpardogo/GoogleProgressBar/pulls/comments/30820085","id":30820085,"diff_hunk":"@@ -55,6 +56,14 @@ private void initObjectAnimator() {\n         final ObjectAnimator objectAnimator = ObjectAnimator.ofInt(this, \"rotationAngle\", 0, 180);\n         objectAnimator.setInterpolator(LINEAR_INTERPOLATOR);\n         objectAnimator.setDuration(ANIMATION_DURATION);\n+\n+        objectAnimator.addUpdateListener(new ValueAnimator.AnimatorUpdateListener() {\n+            @Override\n+            public void onAnimationUpdate(ValueAnimator animation) {\n+                int v = (Integer)animation.getAnimatedValue();\n+            }\n+        });\n+","path":"library/src/main/java/com/jpardogo/android/googleprogressbar/library/NexusRotationCrossDrawable.java","position":19,"original_position":19,"commit_id":"470fae016d00db7c4329478ea5f34c7c38944c2d","original_commit_id":"470fae016d00db7c4329478ea5f34c7c38944c2d","user":{"login":"jpardogo","id":1172221,"avatar_url":"https://avatars.githubusercontent.com/u/1172221?v=3","gravatar_id":"","url":"https://api.github.com/users/jpardogo","html_url":"https://github.com/jpardogo","followers_url":"https://api.github.com/users/jpardogo/followers","following_url":"https://api.github.com/users/jpardogo/following{/other_user}","gists_url":"https://api.github.com/users/jpardogo/gists{/gist_id}","starred_url":"https://api.github.com/users/jpardogo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpardogo/subscriptions","organizations_url":"https://api.github.com/users/jpardogo/orgs","repos_url":"https://api.github.com/users/jpardogo/repos","events_url":"https://api.github.com/users/jpardogo/events{/privacy}","received_events_url":"https://api.github.com/users/jpardogo/received_events","type":"User","site_admin":false},"body":"Unneccesary addUpdateListener","created_at":"2015-05-21T16:32:18Z","updated_at":"2015-05-21T16:32:18Z","html_url":"https://github.com/jpardogo/GoogleProgressBar/pull/20#discussion_r30820085","pull_request_url":"https://api.github.com/repos/jpardogo/GoogleProgressBar/pulls/20","_links":{"self":{"href":"https://api.github.com/repos/jpardogo/GoogleProgressBar/pulls/comments/30820085"},"html":{"href":"https://github.com/jpardogo/GoogleProgressBar/pull/20#discussion_r30820085"},"pull_request":{"href":"https://api.github.com/repos/jpardogo/GoogleProgressBar/pulls/20"}}},"pull_request":{"url":"https://api.github.com/repos/jpardogo/GoogleProgressBar/pulls/20","id":27922620,"html_url":"https://github.com/jpardogo/GoogleProgressBar/pull/20","diff_url":"https://github.com/jpardogo/GoogleProgressBar/pull/20.diff","patch_url":"https://github.com/jpardogo/GoogleProgressBar/pull/20.patch","issue_url":"https://api.github.com/repos/jpardogo/GoogleProgressBar/issues/20","number":20,"state":"open","locked":false,"title":"Fix visual problem and add new style","user":{"login":"MewX","id":5752560,"avatar_url":"https://avatars.githubusercontent.com/u/5752560?v=3","gravatar_id":"","url":"https://api.github.com/users/MewX","html_url":"https://github.com/MewX","followers_url":"https://api.github.com/users/MewX/followers","following_url":"https://api.github.com/users/MewX/following{/other_user}","gists_url":"https://api.github.com/users/MewX/gists{/gist_id}","starred_url":"https://api.github.com/users/MewX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MewX/subscriptions","organizations_url":"https://api.github.com/users/MewX/orgs","repos_url":"https://api.github.com/users/MewX/repos","events_url":"https://api.github.com/users/MewX/events{/privacy}","received_events_url":"https://api.github.com/users/MewX/received_events","type":"User","site_admin":false},"body":"The bug shows like this in low resolution screen:\r\n\r\n![device-2015-01-23-203704](https://cloud.githubusercontent.com/assets/5752560/5874877/93330b54-a341-11e4-8af8-a22e09062921.png)\r\n\r\nI fix it by drawing twice, which likes adding it a \"thickness\" attribute. It's the easiest way to fix, I guess because of the transition from \"dp\" to \"px\".\r\nAnd I've tried to draw only once by adding 1 or 0.5f on \"mHalf\", problem still exists.\r\n\r\nHere is the performance after drawing twice:\r\n![device-2015-01-23-203740](https://cloud.githubusercontent.com/assets/5752560/5874938/3590ee2a-a342-11e4-93e4-88ebdb660d72.png)\r\n","created_at":"2015-01-23T13:14:58Z","updated_at":"2015-05-21T16:32:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ed924a8655e0973e4fbe92fa40ea3fe5fc62632d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jpardogo/GoogleProgressBar/pulls/20/commits","review_comments_url":"https://api.github.com/repos/jpardogo/GoogleProgressBar/pulls/20/comments","review_comment_url":"https://api.github.com/repos/jpardogo/GoogleProgressBar/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jpardogo/GoogleProgressBar/issues/20/comments","statuses_url":"https://api.github.com/repos/jpardogo/GoogleProgressBar/statuses/470fae016d00db7c4329478ea5f34c7c38944c2d","head":{"label":"MewX:master","ref":"master","sha":"470fae016d00db7c4329478ea5f34c7c38944c2d","user":{"login":"MewX","id":5752560,"avatar_url":"https://avatars.githubusercontent.com/u/5752560?v=3","gravatar_id":"","url":"https://api.github.com/users/MewX","html_url":"https://github.com/MewX","followers_url":"https://api.github.com/users/MewX/followers","following_url":"https://api.github.com/users/MewX/following{/other_user}","gists_url":"https://api.github.com/users/MewX/gists{/gist_id}","starred_url":"https://api.github.com/users/MewX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MewX/subscriptions","organizations_url":"https://api.github.com/users/MewX/orgs","repos_url":"https://api.github.com/users/MewX/repos","events_url":"https://api.github.com/users/MewX/events{/privacy}","received_events_url":"https://api.github.com/users/MewX/received_events","type":"User","site_admin":false},"repo":{"id":29566524,"name":"google-progress-bar","full_name":"MewX/google-progress-bar","owner":{"login":"MewX","id":5752560,"avatar_url":"https://avatars.githubusercontent.com/u/5752560?v=3","gravatar_id":"","url":"https://api.github.com/users/MewX","html_url":"https://github.com/MewX","followers_url":"https://api.github.com/users/MewX/followers","following_url":"https://api.github.com/users/MewX/following{/other_user}","gists_url":"https://api.github.com/users/MewX/gists{/gist_id}","starred_url":"https://api.github.com/users/MewX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MewX/subscriptions","organizations_url":"https://api.github.com/users/MewX/orgs","repos_url":"https://api.github.com/users/MewX/repos","events_url":"https://api.github.com/users/MewX/events{/privacy}","received_events_url":"https://api.github.com/users/MewX/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MewX/google-progress-bar","description":"Android library to display progress like google does in some of his services.","fork":true,"url":"https://api.github.com/repos/MewX/google-progress-bar","forks_url":"https://api.github.com/repos/MewX/google-progress-bar/forks","keys_url":"https://api.github.com/repos/MewX/google-progress-bar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MewX/google-progress-bar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MewX/google-progress-bar/teams","hooks_url":"https://api.github.com/repos/MewX/google-progress-bar/hooks","issue_events_url":"https://api.github.com/repos/MewX/google-progress-bar/issues/events{/number}","events_url":"https://api.github.com/repos/MewX/google-progress-bar/events","assignees_url":"https://api.github.com/repos/MewX/google-progress-bar/assignees{/user}","branches_url":"https://api.github.com/repos/MewX/google-progress-bar/branches{/branch}","tags_url":"https://api.github.com/repos/MewX/google-progress-bar/tags","blobs_url":"https://api.github.com/repos/MewX/google-progress-bar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MewX/google-progress-bar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MewX/google-progress-bar/git/refs{/sha}","trees_url":"https://api.github.com/repos/MewX/google-progress-bar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MewX/google-progress-bar/statuses/{sha}","languages_url":"https://api.github.com/repos/MewX/google-progress-bar/languages","stargazers_url":"https://api.github.com/repos/MewX/google-progress-bar/stargazers","contributors_url":"https://api.github.com/repos/MewX/google-progress-bar/contributors","subscribers_url":"https://api.github.com/repos/MewX/google-progress-bar/subscribers","subscription_url":"https://api.github.com/repos/MewX/google-progress-bar/subscription","commits_url":"https://api.github.com/repos/MewX/google-progress-bar/commits{/sha}","git_commits_url":"https://api.github.com/repos/MewX/google-progress-bar/git/commits{/sha}","comments_url":"https://api.github.com/repos/MewX/google-progress-bar/comments{/number}","issue_comment_url":"https://api.github.com/repos/MewX/google-progress-bar/issues/comments{/number}","contents_url":"https://api.github.com/repos/MewX/google-progress-bar/contents/{+path}","compare_url":"https://api.github.com/repos/MewX/google-progress-bar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MewX/google-progress-bar/merges","archive_url":"https://api.github.com/repos/MewX/google-progress-bar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MewX/google-progress-bar/downloads","issues_url":"https://api.github.com/repos/MewX/google-progress-bar/issues{/number}","pulls_url":"https://api.github.com/repos/MewX/google-progress-bar/pulls{/number}","milestones_url":"https://api.github.com/repos/MewX/google-progress-bar/milestones{/number}","notifications_url":"https://api.github.com/repos/MewX/google-progress-bar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MewX/google-progress-bar/labels{/name}","releases_url":"https://api.github.com/repos/MewX/google-progress-bar/releases{/id}","created_at":"2015-01-21T02:17:54Z","updated_at":"2015-02-14T09:34:14Z","pushed_at":"2015-02-14T14:01:05Z","git_url":"git://github.com/MewX/google-progress-bar.git","ssh_url":"git@github.com:MewX/google-progress-bar.git","clone_url":"https://github.com/MewX/google-progress-bar.git","svn_url":"https://github.com/MewX/google-progress-bar","homepage":null,"size":1441,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jpardogo:master","ref":"master","sha":"febfc532663ca24c34f285400268cc45f644ba69","user":{"login":"jpardogo","id":1172221,"avatar_url":"https://avatars.githubusercontent.com/u/1172221?v=3","gravatar_id":"","url":"https://api.github.com/users/jpardogo","html_url":"https://github.com/jpardogo","followers_url":"https://api.github.com/users/jpardogo/followers","following_url":"https://api.github.com/users/jpardogo/following{/other_user}","gists_url":"https://api.github.com/users/jpardogo/gists{/gist_id}","starred_url":"https://api.github.com/users/jpardogo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpardogo/subscriptions","organizations_url":"https://api.github.com/users/jpardogo/orgs","repos_url":"https://api.github.com/users/jpardogo/repos","events_url":"https://api.github.com/users/jpardogo/events{/privacy}","received_events_url":"https://api.github.com/users/jpardogo/received_events","type":"User","site_admin":false},"repo":{"id":18154271,"name":"GoogleProgressBar","full_name":"jpardogo/GoogleProgressBar","owner":{"login":"jpardogo","id":1172221,"avatar_url":"https://avatars.githubusercontent.com/u/1172221?v=3","gravatar_id":"","url":"https://api.github.com/users/jpardogo","html_url":"https://github.com/jpardogo","followers_url":"https://api.github.com/users/jpardogo/followers","following_url":"https://api.github.com/users/jpardogo/following{/other_user}","gists_url":"https://api.github.com/users/jpardogo/gists{/gist_id}","starred_url":"https://api.github.com/users/jpardogo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpardogo/subscriptions","organizations_url":"https://api.github.com/users/jpardogo/orgs","repos_url":"https://api.github.com/users/jpardogo/repos","events_url":"https://api.github.com/users/jpardogo/events{/privacy}","received_events_url":"https://api.github.com/users/jpardogo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jpardogo/GoogleProgressBar","description":"Android library to display progress like google does in some of his services.","fork":false,"url":"https://api.github.com/repos/jpardogo/GoogleProgressBar","forks_url":"https://api.github.com/repos/jpardogo/GoogleProgressBar/forks","keys_url":"https://api.github.com/repos/jpardogo/GoogleProgressBar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jpardogo/GoogleProgressBar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jpardogo/GoogleProgressBar/teams","hooks_url":"https://api.github.com/repos/jpardogo/GoogleProgressBar/hooks","issue_events_url":"https://api.github.com/repos/jpardogo/GoogleProgressBar/issues/events{/number}","events_url":"https://api.github.com/repos/jpardogo/GoogleProgressBar/events","assignees_url":"https://api.github.com/repos/jpardogo/GoogleProgressBar/assignees{/user}","branches_url":"https://api.github.com/repos/jpardogo/GoogleProgressBar/branches{/branch}","tags_url":"https://api.github.com/repos/jpardogo/GoogleProgressBar/tags","blobs_url":"https://api.github.com/repos/jpardogo/GoogleProgressBar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jpardogo/GoogleProgressBar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jpardogo/GoogleProgressBar/git/refs{/sha}","trees_url":"https://api.github.com/repos/jpardogo/GoogleProgressBar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jpardogo/GoogleProgressBar/statuses/{sha}","languages_url":"https://api.github.com/repos/jpardogo/GoogleProgressBar/languages","stargazers_url":"https://api.github.com/repos/jpardogo/GoogleProgressBar/stargazers","contributors_url":"https://api.github.com/repos/jpardogo/GoogleProgressBar/contributors","subscribers_url":"https://api.github.com/repos/jpardogo/GoogleProgressBar/subscribers","subscription_url":"https://api.github.com/repos/jpardogo/GoogleProgressBar/subscription","commits_url":"https://api.github.com/repos/jpardogo/GoogleProgressBar/commits{/sha}","git_commits_url":"https://api.github.com/repos/jpardogo/GoogleProgressBar/git/commits{/sha}","comments_url":"https://api.github.com/repos/jpardogo/GoogleProgressBar/comments{/number}","issue_comment_url":"https://api.github.com/repos/jpardogo/GoogleProgressBar/issues/comments{/number}","contents_url":"https://api.github.com/repos/jpardogo/GoogleProgressBar/contents/{+path}","compare_url":"https://api.github.com/repos/jpardogo/GoogleProgressBar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jpardogo/GoogleProgressBar/merges","archive_url":"https://api.github.com/repos/jpardogo/GoogleProgressBar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jpardogo/GoogleProgressBar/downloads","issues_url":"https://api.github.com/repos/jpardogo/GoogleProgressBar/issues{/number}","pulls_url":"https://api.github.com/repos/jpardogo/GoogleProgressBar/pulls{/number}","milestones_url":"https://api.github.com/repos/jpardogo/GoogleProgressBar/milestones{/number}","notifications_url":"https://api.github.com/repos/jpardogo/GoogleProgressBar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jpardogo/GoogleProgressBar/labels{/name}","releases_url":"https://api.github.com/repos/jpardogo/GoogleProgressBar/releases{/id}","created_at":"2014-03-26T21:19:29Z","updated_at":"2015-05-21T12:11:25Z","pushed_at":"2015-05-21T16:10:58Z","git_url":"git://github.com/jpardogo/GoogleProgressBar.git","ssh_url":"git@github.com:jpardogo/GoogleProgressBar.git","clone_url":"https://github.com/jpardogo/GoogleProgressBar.git","svn_url":"https://github.com/jpardogo/GoogleProgressBar","homepage":null,"size":1667,"stargazers_count":648,"watchers_count":648,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":167,"mirror_url":null,"open_issues_count":1,"forks":167,"open_issues":1,"watchers":648,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jpardogo/GoogleProgressBar/pulls/20"},"html":{"href":"https://github.com/jpardogo/GoogleProgressBar/pull/20"},"issue":{"href":"https://api.github.com/repos/jpardogo/GoogleProgressBar/issues/20"},"comments":{"href":"https://api.github.com/repos/jpardogo/GoogleProgressBar/issues/20/comments"},"review_comments":{"href":"https://api.github.com/repos/jpardogo/GoogleProgressBar/pulls/20/comments"},"review_comment":{"href":"https://api.github.com/repos/jpardogo/GoogleProgressBar/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jpardogo/GoogleProgressBar/pulls/20/commits"},"statuses":{"href":"https://api.github.com/repos/jpardogo/GoogleProgressBar/statuses/470fae016d00db7c4329478ea5f34c7c38944c2d"}}}}