{"action":"created","comment":{"url":"https://api.github.com/repos/bitcoinj/bitcoinj/pulls/comments/27880180","id":27880180,"diff_hunk":"@@ -171,9 +171,15 @@ public void encryptedDerivation() throws Exception {\n     @Test\n     public void pubOnlyDerivation() throws Exception {\n         DeterministicKey key1 = HDKeyDerivation.createMasterPrivateKey(\"satoshi lives!\".getBytes());\n+        assertFalse(key1.isPubKeyOnly());\n         DeterministicKey key2 = HDKeyDerivation.deriveChildKey(key1, ChildNumber.ZERO_HARDENED);\n+        assertFalse(key2.isPubKeyOnly());\n         DeterministicKey key3 = HDKeyDerivation.deriveChildKey(key2, ChildNumber.ZERO);\n-        DeterministicKey pubkey3 = HDKeyDerivation.deriveChildKey(key2.getPubOnly(), ChildNumber.ZERO);\n+        assertFalse(key3.isPubKeyOnly());\n+        DeterministicKey pubkey2 = key2.getPubOnly();\n+        assertFalse(pubkey2.isPubKeyOnly());","path":"core/src/test/java/org/bitcoinj/crypto/ChildKeyDerivationTest.java","position":null,"original_position":11,"commit_id":"7468e571127770e7fd83a222199738f71df0e3e0","original_commit_id":"a139a8cb4c18e40b0d38bf073566a5ffca94fc61","user":{"login":"schildbach","id":743306,"avatar_url":"https://avatars.githubusercontent.com/u/743306?v=3","gravatar_id":"","url":"https://api.github.com/users/schildbach","html_url":"https://github.com/schildbach","followers_url":"https://api.github.com/users/schildbach/followers","following_url":"https://api.github.com/users/schildbach/following{/other_user}","gists_url":"https://api.github.com/users/schildbach/gists{/gist_id}","starred_url":"https://api.github.com/users/schildbach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schildbach/subscriptions","organizations_url":"https://api.github.com/users/schildbach/orgs","repos_url":"https://api.github.com/users/schildbach/repos","events_url":"https://api.github.com/users/schildbach/events{/privacy}","received_events_url":"https://api.github.com/users/schildbach/received_events","type":"User","site_admin":false},"body":"Maybe the .getPubOnly() method needs to recursively clone the entire branch of the hierarchy.","created_at":"2015-04-07T14:04:07Z","updated_at":"2015-04-07T14:04:07Z","html_url":"https://github.com/bitcoinj/bitcoinj/pull/328#discussion_r27880180","pull_request_url":"https://api.github.com/repos/bitcoinj/bitcoinj/pulls/328","_links":{"self":{"href":"https://api.github.com/repos/bitcoinj/bitcoinj/pulls/comments/27880180"},"html":{"href":"https://github.com/bitcoinj/bitcoinj/pull/328#discussion_r27880180"},"pull_request":{"href":"https://api.github.com/repos/bitcoinj/bitcoinj/pulls/328"}}},"pull_request":{"url":"https://api.github.com/repos/bitcoinj/bitcoinj/pulls/328","id":30810418,"html_url":"https://github.com/bitcoinj/bitcoinj/pull/328","diff_url":"https://github.com/bitcoinj/bitcoinj/pull/328.diff","patch_url":"https://github.com/bitcoinj/bitcoinj/pull/328.patch","issue_url":"https://api.github.com/repos/bitcoinj/bitcoinj/issues/328","number":328,"state":"open","locked":false,"title":"Implement DeterministicKey.isPubKeyOnly().","user":{"login":"schildbach","id":743306,"avatar_url":"https://avatars.githubusercontent.com/u/743306?v=3","gravatar_id":"","url":"https://api.github.com/users/schildbach","html_url":"https://github.com/schildbach","followers_url":"https://api.github.com/users/schildbach/followers","following_url":"https://api.github.com/users/schildbach/following{/other_user}","gists_url":"https://api.github.com/users/schildbach/gists{/gist_id}","starred_url":"https://api.github.com/users/schildbach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schildbach/subscriptions","organizations_url":"https://api.github.com/users/schildbach/orgs","repos_url":"https://api.github.com/users/schildbach/repos","events_url":"https://api.github.com/users/schildbach/events{/privacy}","received_events_url":"https://api.github.com/users/schildbach/received_events","type":"User","site_admin":false},"body":"The super-implementation in ECKey doesn't take possible rederivation into account.","created_at":"2015-03-09T23:33:10Z","updated_at":"2015-04-07T14:04:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a09cad710d414a19da13c01341c2d5d28fa93887","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bitcoinj/bitcoinj/pulls/328/commits","review_comments_url":"https://api.github.com/repos/bitcoinj/bitcoinj/pulls/328/comments","review_comment_url":"https://api.github.com/repos/bitcoinj/bitcoinj/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitcoinj/bitcoinj/issues/328/comments","statuses_url":"https://api.github.com/repos/bitcoinj/bitcoinj/statuses/7468e571127770e7fd83a222199738f71df0e3e0","head":{"label":"schildbach:deterministickey-ispubkeyonly","ref":"deterministickey-ispubkeyonly","sha":"7468e571127770e7fd83a222199738f71df0e3e0","user":{"login":"schildbach","id":743306,"avatar_url":"https://avatars.githubusercontent.com/u/743306?v=3","gravatar_id":"","url":"https://api.github.com/users/schildbach","html_url":"https://github.com/schildbach","followers_url":"https://api.github.com/users/schildbach/followers","following_url":"https://api.github.com/users/schildbach/following{/other_user}","gists_url":"https://api.github.com/users/schildbach/gists{/gist_id}","starred_url":"https://api.github.com/users/schildbach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schildbach/subscriptions","organizations_url":"https://api.github.com/users/schildbach/orgs","repos_url":"https://api.github.com/users/schildbach/repos","events_url":"https://api.github.com/users/schildbach/events{/privacy}","received_events_url":"https://api.github.com/users/schildbach/received_events","type":"User","site_admin":false},"repo":{"id":16644238,"name":"bitcoinj","full_name":"schildbach/bitcoinj","owner":{"login":"schildbach","id":743306,"avatar_url":"https://avatars.githubusercontent.com/u/743306?v=3","gravatar_id":"","url":"https://api.github.com/users/schildbach","html_url":"https://github.com/schildbach","followers_url":"https://api.github.com/users/schildbach/followers","following_url":"https://api.github.com/users/schildbach/following{/other_user}","gists_url":"https://api.github.com/users/schildbach/gists{/gist_id}","starred_url":"https://api.github.com/users/schildbach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schildbach/subscriptions","organizations_url":"https://api.github.com/users/schildbach/orgs","repos_url":"https://api.github.com/users/schildbach/repos","events_url":"https://api.github.com/users/schildbach/events{/privacy}","received_events_url":"https://api.github.com/users/schildbach/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/schildbach/bitcoinj","description":"My personal bitcoinj fork. This is not the official repo!","fork":true,"url":"https://api.github.com/repos/schildbach/bitcoinj","forks_url":"https://api.github.com/repos/schildbach/bitcoinj/forks","keys_url":"https://api.github.com/repos/schildbach/bitcoinj/keys{/key_id}","collaborators_url":"https://api.github.com/repos/schildbach/bitcoinj/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/schildbach/bitcoinj/teams","hooks_url":"https://api.github.com/repos/schildbach/bitcoinj/hooks","issue_events_url":"https://api.github.com/repos/schildbach/bitcoinj/issues/events{/number}","events_url":"https://api.github.com/repos/schildbach/bitcoinj/events","assignees_url":"https://api.github.com/repos/schildbach/bitcoinj/assignees{/user}","branches_url":"https://api.github.com/repos/schildbach/bitcoinj/branches{/branch}","tags_url":"https://api.github.com/repos/schildbach/bitcoinj/tags","blobs_url":"https://api.github.com/repos/schildbach/bitcoinj/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/schildbach/bitcoinj/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/schildbach/bitcoinj/git/refs{/sha}","trees_url":"https://api.github.com/repos/schildbach/bitcoinj/git/trees{/sha}","statuses_url":"https://api.github.com/repos/schildbach/bitcoinj/statuses/{sha}","languages_url":"https://api.github.com/repos/schildbach/bitcoinj/languages","stargazers_url":"https://api.github.com/repos/schildbach/bitcoinj/stargazers","contributors_url":"https://api.github.com/repos/schildbach/bitcoinj/contributors","subscribers_url":"https://api.github.com/repos/schildbach/bitcoinj/subscribers","subscription_url":"https://api.github.com/repos/schildbach/bitcoinj/subscription","commits_url":"https://api.github.com/repos/schildbach/bitcoinj/commits{/sha}","git_commits_url":"https://api.github.com/repos/schildbach/bitcoinj/git/commits{/sha}","comments_url":"https://api.github.com/repos/schildbach/bitcoinj/comments{/number}","issue_comment_url":"https://api.github.com/repos/schildbach/bitcoinj/issues/comments{/number}","contents_url":"https://api.github.com/repos/schildbach/bitcoinj/contents/{+path}","compare_url":"https://api.github.com/repos/schildbach/bitcoinj/compare/{base}...{head}","merges_url":"https://api.github.com/repos/schildbach/bitcoinj/merges","archive_url":"https://api.github.com/repos/schildbach/bitcoinj/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/schildbach/bitcoinj/downloads","issues_url":"https://api.github.com/repos/schildbach/bitcoinj/issues{/number}","pulls_url":"https://api.github.com/repos/schildbach/bitcoinj/pulls{/number}","milestones_url":"https://api.github.com/repos/schildbach/bitcoinj/milestones{/number}","notifications_url":"https://api.github.com/repos/schildbach/bitcoinj/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/schildbach/bitcoinj/labels{/name}","releases_url":"https://api.github.com/repos/schildbach/bitcoinj/releases{/id}","created_at":"2014-02-08T13:55:05Z","updated_at":"2015-03-23T15:22:33Z","pushed_at":"2015-04-07T13:52:59Z","git_url":"git://github.com/schildbach/bitcoinj.git","ssh_url":"git@github.com:schildbach/bitcoinj.git","clone_url":"https://github.com/schildbach/bitcoinj.git","svn_url":"https://github.com/schildbach/bitcoinj","homepage":"","size":15905,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"bitcoinj:master","ref":"master","sha":"c426e34646f448d36fe1ab2dd60667a00773a406","user":{"login":"bitcoinj","id":5951625,"avatar_url":"https://avatars.githubusercontent.com/u/5951625?v=3","gravatar_id":"","url":"https://api.github.com/users/bitcoinj","html_url":"https://github.com/bitcoinj","followers_url":"https://api.github.com/users/bitcoinj/followers","following_url":"https://api.github.com/users/bitcoinj/following{/other_user}","gists_url":"https://api.github.com/users/bitcoinj/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoinj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoinj/subscriptions","organizations_url":"https://api.github.com/users/bitcoinj/orgs","repos_url":"https://api.github.com/users/bitcoinj/repos","events_url":"https://api.github.com/users/bitcoinj/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoinj/received_events","type":"Organization","site_admin":false},"repo":{"id":14514251,"name":"bitcoinj","full_name":"bitcoinj/bitcoinj","owner":{"login":"bitcoinj","id":5951625,"avatar_url":"https://avatars.githubusercontent.com/u/5951625?v=3","gravatar_id":"","url":"https://api.github.com/users/bitcoinj","html_url":"https://github.com/bitcoinj","followers_url":"https://api.github.com/users/bitcoinj/followers","following_url":"https://api.github.com/users/bitcoinj/following{/other_user}","gists_url":"https://api.github.com/users/bitcoinj/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoinj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoinj/subscriptions","organizations_url":"https://api.github.com/users/bitcoinj/orgs","repos_url":"https://api.github.com/users/bitcoinj/repos","events_url":"https://api.github.com/users/bitcoinj/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoinj/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bitcoinj/bitcoinj","description":"A library for working with Bitcoin","fork":false,"url":"https://api.github.com/repos/bitcoinj/bitcoinj","forks_url":"https://api.github.com/repos/bitcoinj/bitcoinj/forks","keys_url":"https://api.github.com/repos/bitcoinj/bitcoinj/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoinj/bitcoinj/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoinj/bitcoinj/teams","hooks_url":"https://api.github.com/repos/bitcoinj/bitcoinj/hooks","issue_events_url":"https://api.github.com/repos/bitcoinj/bitcoinj/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoinj/bitcoinj/events","assignees_url":"https://api.github.com/repos/bitcoinj/bitcoinj/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoinj/bitcoinj/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoinj/bitcoinj/tags","blobs_url":"https://api.github.com/repos/bitcoinj/bitcoinj/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoinj/bitcoinj/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoinj/bitcoinj/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoinj/bitcoinj/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoinj/bitcoinj/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoinj/bitcoinj/languages","stargazers_url":"https://api.github.com/repos/bitcoinj/bitcoinj/stargazers","contributors_url":"https://api.github.com/repos/bitcoinj/bitcoinj/contributors","subscribers_url":"https://api.github.com/repos/bitcoinj/bitcoinj/subscribers","subscription_url":"https://api.github.com/repos/bitcoinj/bitcoinj/subscription","commits_url":"https://api.github.com/repos/bitcoinj/bitcoinj/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoinj/bitcoinj/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoinj/bitcoinj/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoinj/bitcoinj/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoinj/bitcoinj/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoinj/bitcoinj/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoinj/bitcoinj/merges","archive_url":"https://api.github.com/repos/bitcoinj/bitcoinj/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoinj/bitcoinj/downloads","issues_url":"https://api.github.com/repos/bitcoinj/bitcoinj/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoinj/bitcoinj/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoinj/bitcoinj/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoinj/bitcoinj/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoinj/bitcoinj/labels{/name}","releases_url":"https://api.github.com/repos/bitcoinj/bitcoinj/releases{/id}","created_at":"2013-11-19T04:33:23Z","updated_at":"2015-04-07T13:38:19Z","pushed_at":"2015-04-07T13:53:00Z","git_url":"git://github.com/bitcoinj/bitcoinj.git","ssh_url":"git@github.com:bitcoinj/bitcoinj.git","clone_url":"https://github.com/bitcoinj/bitcoinj.git","svn_url":"https://github.com/bitcoinj/bitcoinj","homepage":"http://www.bitcoinj.org","size":28413,"stargazers_count":371,"watchers_count":371,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":384,"mirror_url":null,"open_issues_count":12,"forks":384,"open_issues":12,"watchers":371,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoinj/bitcoinj/pulls/328"},"html":{"href":"https://github.com/bitcoinj/bitcoinj/pull/328"},"issue":{"href":"https://api.github.com/repos/bitcoinj/bitcoinj/issues/328"},"comments":{"href":"https://api.github.com/repos/bitcoinj/bitcoinj/issues/328/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoinj/bitcoinj/pulls/328/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoinj/bitcoinj/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitcoinj/bitcoinj/pulls/328/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoinj/bitcoinj/statuses/7468e571127770e7fd83a222199738f71df0e3e0"}}}}