{"push_id":550283294,"size":23,"distinct_size":0,"ref":"refs/heads/master","head":"16f600f7f08e69f7110c8e41893d71876d411fd3","before":"564e8841008bd0e2bf9a87a87f66d53c5bb91f2c","commits":[{"sha":"27d51ceee2905112be3309719c7620ba270e2e16","author":{"email":"0e528190e12911c0001cd13934cb550f905f02b8@fb.com","name":"Michael Bolin"},"message":"On Travis, run `buck test --all` before `ant test`.\n\nSummary:\nAs noted in `.travis.yml`, we want to run `buck test --all` first\nbecause its test output lists which tests failed whereas Ant's does not.\nAs a result, the Buck way makes it easier to debug tests.\n\nTest Plan:\nVerify that we see test failures from Buck's testrunner rather than Ant's.","distinct":false,"url":"https://api.github.com/repos/dakkad/buck/commits/27d51ceee2905112be3309719c7620ba270e2e16"},{"sha":"8ad7292462a524139c95d6082ed07ed28c74456f","author":{"email":"6aa1be71730a75c9811f6a0b6ac5054f69a50c3f@fb.com","name":"Andrew Gallagher"},"message":"Use `filterInputsToCompareToOutput` in C/C++ build rules\n\nSummary:\nPreviously, these C/C++ build rules were resolving paths even for\n`BuildRuleSourcePath` objects and returning them from\n`getInputsToCompareToOutput`.\n\nTest Plan: buck test --all","distinct":false,"url":"https://api.github.com/repos/dakkad/buck/commits/8ad7292462a524139c95d6082ed07ed28c74456f"},{"sha":"3791cda8ae30789be111333f31697d3179bc12b0","author":{"email":"6aa1be71730a75c9811f6a0b6ac5054f69a50c3f@fb.com","name":"Andrew Gallagher"},"message":"Allow android_instrumentation_apk rules to depend on C/C++ libs\n\nSummary:\nThis diff threads the NDK C/C++ platforms into the android instrumentation\nAPK description so that it can pull in the shared libs built by C/C++\ndependencies.\n\nTest Plan: Added test to verify C/C++ libs get pulled into instrumentation APK.","distinct":false,"url":"https://api.github.com/repos/dakkad/buck/commits/3791cda8ae30789be111333f31697d3179bc12b0"},{"sha":"453ffbb5389f0023f03ecfcf42e9bbd532406299","author":{"email":"0eacd3f62da61bf475a16286f0a7936f16b95b89@fb.com","name":"Daniel Colascione"},"message":"Suppress useless SEVERE-level message from Guava","distinct":false,"url":"https://api.github.com/repos/dakkad/buck/commits/453ffbb5389f0023f03ecfcf42e9bbd532406299"},{"sha":"9a3fe962388bb9d4fa4e5518fb0ffe2127ffe065","author":{"email":"a1166ad1633243ec0ce1c24d3875f36521f50a72@fb.com","name":"Jakub Zika"},"message":"Show an error message when a target does not belong to any project\n\nSummary:\nShow a human readable error message instead of a stack trace when generating an\nXcode project and one of the targets included in the workspace does not have a\nxcode_project_config that specifies it in its rules.\n\nTest Plan: A new unit test.","distinct":false,"url":"https://api.github.com/repos/dakkad/buck/commits/9a3fe962388bb9d4fa4e5518fb0ffe2127ffe065"},{"sha":"cee8647a681402f14f8c9de558d60a3384a3e362","author":{"email":"c946aa019eb2e105c27e9ffc6f0113f198a67a0e@fb.com","name":"Uri Baghin"},"message":"Correct a spelling mistake.\n\nTest Plan: CI","distinct":false,"url":"https://api.github.com/repos/dakkad/buck/commits/cee8647a681402f14f8c9de558d60a3384a3e362"},{"sha":"98bff7d3bd9afc28ac375e51969bda2899c8a872","author":{"email":"17901b818c97112c2510dae12d1c7c05a02a9491@fb.com","name":"Brian Cheung"},"message":"fix android_prebuilt_aar bug in caching empty directories\n\nSummary:\n`android_prebuilt_aar` may fail when its using cache dir. The problem is dir `res/` is mandatory, but it may be empty somehow. In such case, the caching is not able to cache the empty directories and cause aapt build fail.\nFor fixing that, I force `BuildInfoRecorder::getEntries` to include empty directories when its calling walkFileTree. This fixing will allow ALL empty directories to be cached.\n\nCloses https://github.com/facebook/buck/issues/234\n\nTest Plan:\n1. build quickstart project `buck build app`, nothing wrong;\n2. `buck test --all`, nothing wrong;\n3. before fixing, when running build with cache, `#aar_unzip__/res/` can't be found, after fixing, an empty is found.\n\n```\n1. Before\n[chcheung@chcheung-mbp1 (res)  ~/devtools/buck]$ buck clean && buck build app && ls -d buck-out/bin/apps/myapp/__unpack_support-v4#aar_unzip__/res/\nShutting down nailgun server...\nUsing watchman.\nUsing buckd.\nUsing buckd.\n[-] PROCESSING BUCK FILES...FINISHED 0.6s\n[-] BUILDING...FINISHED 5.2s (13/13 JOBS)\nLog:\nbuilt APK for //apps/myapp:app at buck-out/gen/apps/myapp/app.apk\nbuck-out/bin/apps/myapp/__unpack_support-v4#aar_unzip__/res/\n[chcheung@chcheung-mbp1 (res)  ~/devtools/buck]$ buck clean && buck build app && ls -d buck-out/bin/apps/myapp/__unpack_support-v4#aar_unzip__/res/\nShutting down nailgun server...\nUsing watchman.\nUsing buckd.\nUsing buckd.\n[-] PROCESSING BUCK FILES...FINISHED 0.6s\n[-] BUILDING...FINISHED 0.4s (13/13 JOBS)\nls: buck-out/bin/apps/myapp/__unpack_support-v4#aar_unzip__/res/: No such file or directory\n\n2. After\n[chcheung@chcheung-mbp1 (res)  ~/devtools/buck]$ buck clean && buck build app && ls -d buck-out/bin/apps/myapp/__unpack_support-v4#aar_unzip__/res/\nShutting down nailgun server...\nUsing watchman.\nUsing buckd.\nUsing buckd.\n[-] PROCESSING BUCK FILES...FINISHED 0.6s\n[-] BUILDING...FINISHED 5.6s (13/13 JOBS)\nLog:\nbuilt APK for //apps/myapp:app at buck-out/gen/apps/myapp/app.apk\nbuck-out/bin/apps/myapp/__unpack_support-v4#aar_unzip__/res/\n[chcheung@chcheung-mbp1 (res)  ~/devtools/buck]$ buck clean && buck build app && ls -d buck-out/bin/apps/myapp/__unpack_support-v4#aar_unzip__/res/\nShutting down nailgun server...\nUsing watchman.\nUsing buckd.\nUsing buckd.\n[-] PROCESSING BUCK FILES...FINISHED 0.7s\n[-] BUILDING...FINISHED 0.3s (13/13 JOBS)\nbuck-out/bin/apps/myapp/__unpack_support-v4#aar_unzip__/res/\n```","distinct":false,"url":"https://api.github.com/repos/dakkad/buck/commits/98bff7d3bd9afc28ac375e51969bda2899c8a872"},{"sha":"44e71ffdc01e27a9f7233853d755d4d284a1dc2d","author":{"email":"0eacd3f62da61bf475a16286f0a7936f16b95b89@fb.com","name":"Daniel Colascione"},"message":"Use buck or buckd as argv[0]\n\nSummary: Make ps properly report buck processes as \"buck\" or \"buckd\"\n\nTest Plan:\nRun on Linux\nRan on Mac OSX 10.9.5","distinct":false,"url":"https://api.github.com/repos/dakkad/buck/commits/44e71ffdc01e27a9f7233853d755d4d284a1dc2d"},{"sha":"5d61ca75b9605ad9ceabd625da1f18fc1f34bf05","author":{"email":"0eacd3f62da61bf475a16286f0a7936f16b95b89@fb.com","name":"Daniel Colascione"},"message":"Use /dev/null for standard file descriptors\n\nSummary: This diff replaces stdin, stdout, and stderr for buckd instead of just closing them.  This way, anything hardcoded to write to one of these standard file descriptors will write to nothingness rather than to some random internal buck stream.\n\nTest Plan: unset NO_BUCKD and built a target with buck","distinct":false,"url":"https://api.github.com/repos/dakkad/buck/commits/5d61ca75b9605ad9ceabd625da1f18fc1f34bf05"},{"sha":"2eab4f46cd70bdc4f557140696279cea1ec6aa04","author":{"email":"0eacd3f62da61bf475a16286f0a7936f16b95b89@fb.com","name":"Daniel Colascione"},"message":"Shorten buck command lines\n\nSummary:\nPass the bootstrap and regular class paths in the environment instead of on the command line. This way, the remainder of the command line fits under the Linux 4k /proc/pid/cmdline limit, making it possible to actually see what a given process is doing.\n\nWe filter our classpath environment variables out of the environment we use for subprocesses. (Java, amazingly, has `getenv`, but not `setenv` or `unsetenv`.)\n\nTest Plan: buck build buck","distinct":false,"url":"https://api.github.com/repos/dakkad/buck/commits/2eab4f46cd70bdc4f557140696279cea1ec6aa04"},{"sha":"12c16cb1fb7b7d39bb24f8a4e29dfaf11fca734b","author":{"email":"1ca927701737ca3bccd1b9d94599b445695358b6@fb.com","name":"Shawn Wilsher"},"message":"Fix ordering of deps modified in 000aca10393d9a0fc133715650b9baa84fd5457a","distinct":false,"url":"https://api.github.com/repos/dakkad/buck/commits/12c16cb1fb7b7d39bb24f8a4e29dfaf11fca734b"},{"sha":"a73f7e40cbe920084e6bc1f6c36bc9f4236ad293","author":{"email":"ad43cbb5221b6345bda609d802b0ccf431721b6b@fb.com","name":"Rob Arnold"},"message":"Test environments also need to include PATHEXT on Windows\n\nSummary:\nPATHEXT is normally empty on unixy platforms and the code defaults to\nthe empty string when the environment variable isn't found. On Windows though,\nwe need to have this or else we can't find the Python interpreter.\n\nTest Plan:\n'ant test' and testOrigFileIsIgnoredByAapt no longer fails due to\nnot being able to find a python binary when Python is on the path.","distinct":false,"url":"https://api.github.com/repos/dakkad/buck/commits/a73f7e40cbe920084e6bc1f6c36bc9f4236ad293"},{"sha":"3bb5f1ccda503960235be5fccaa67286d6c3571d","author":{"email":"0e528190e12911c0001cd13934cb550f905f02b8@fb.com","name":"Michael Bolin"},"message":"Fix .travis.yml: use `./bin/buck` instead of `buck` and fail right away.\n\nSummary: This was causing Travis to break.\n\nTest Plan: Travis","distinct":false,"url":"https://api.github.com/repos/dakkad/buck/commits/3bb5f1ccda503960235be5fccaa67286d6c3571d"},{"sha":"82ec8ffe602c8ae9f6e705191c7a50949e542070","author":{"email":"99e6b749acbfbe2a596df99e91d24d6e1fdbee00@sitemorph.net","name":"Damien Allison"},"message":"Merge remote-tracking branch 'upstream/master'","distinct":false,"url":"https://api.github.com/repos/dakkad/buck/commits/82ec8ffe602c8ae9f6e705191c7a50949e542070"},{"sha":"2c46368cf9bf8f9a2bcf4cfa564390cc9a804980","author":{"email":"0eacd3f62da61bf475a16286f0a7936f16b95b89@fb.com","name":"Daniel Colascione"},"message":"Do not claim to be Android-specific\n\nTest Plan: None","distinct":false,"url":"https://api.github.com/repos/dakkad/buck/commits/2c46368cf9bf8f9a2bcf4cfa564390cc9a804980"},{"sha":"d8918650beb4602aff19f41f375a8a25a47ccffb","author":{"email":"c946aa019eb2e105c27e9ffc6f0113f198a67a0e@fb.com","name":"Uri Baghin"},"message":"Fix AndroidExopackageBinaryIntegrationTest to mirror AndroidBinaryIntegrationTest.\n\nSummary:\nAndroidExopackageBinaryIntegrationTest#testNativeExopackageHasNoNativeLibraries\nhas an incorrect assertion. This fixes it to mirror\nAndroidBinaryIntegrationTest#testRawSplitDexHasSecondary.\n\nTest Plan: travis","distinct":false,"url":"https://api.github.com/repos/dakkad/buck/commits/d8918650beb4602aff19f41f375a8a25a47ccffb"},{"sha":"35cdcdf993415825a6cf39c10acf20f7ddb94409","author":{"email":"0e528190e12911c0001cd13934cb550f905f02b8@fb.com","name":"Michael Bolin"},"message":"Hide SuperConsole output on Travis.\n\nSummary:\nTravis's portrayal of the SuperConsole generates over 10000 lines\nof output, so any failure that occurs after that is not displayed\nin the output, making it impossible to debug.\n\nTest Plan: testinprod","distinct":false,"url":"https://api.github.com/repos/dakkad/buck/commits/35cdcdf993415825a6cf39c10acf20f7ddb94409"},{"sha":"5365e5c45e3eae5e17101ba57ca253b4621c424d","author":{"email":"c946aa019eb2e105c27e9ffc6f0113f198a67a0e@fb.com","name":"Uri Baghin"},"message":"Pull EnhancementResult out of AndroidBinaryGraphEnhancer.\n\nSummary:\nImmutables doesn't support inner classes / interfaces properly: the generated\njavadoc references them by name only, and the generated immutable class is an\nouter class, not an inner one. It is unclear at the moment whether those are\nbugs or if it's not supposed to work at all.\nFor now we can work around this by pulling the inner interface out.\n\nTest Plan: CI","distinct":false,"url":"https://api.github.com/repos/dakkad/buck/commits/5365e5c45e3eae5e17101ba57ca253b4621c424d"},{"sha":"0543702f3edbf84625cede289dd2aeb717af6814","author":{"email":"c946aa019eb2e105c27e9ffc6f0113f198a67a0e@fb.com","name":"Uri Baghin"},"message":"Rename getShortNameOnly and getShortName.\n\nSummary:\nHaving `getShortName` not return the short name makes it difficult\nto implement BuildTarget with immutables. This renames the two\nmethods related to the short name to make that easier.\n\nTest Plan: CI","distinct":false,"url":"https://api.github.com/repos/dakkad/buck/commits/0543702f3edbf84625cede289dd2aeb717af6814"},{"sha":"a0881f0801ad2961cebcd78f44964183de4256d3","author":{"email":"c946aa019eb2e105c27e9ffc6f0113f198a67a0e@fb.com","name":"Uri Baghin"},"message":"Remove Flavor.DEFAULT.\n\nSummary:\nFlavor.DEFAULT is a leftover from when build targets had only one\nflavour. The code now already treats an empty set of flavours as\nequivalent to a set containing only the default flavour in some\nplaces. This extends this equivalence to all the code base and\nremoves Flavor.DEFAULT.\n\nTest Plan: CI","distinct":false,"url":"https://api.github.com/repos/dakkad/buck/commits/a0881f0801ad2961cebcd78f44964183de4256d3"}]}