{"action":"created","comment":{"url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/pulls/comments/28432222","id":28432222,"diff_hunk":"@@ -1211,3 +1188,78 @@ span.gh-agenda-view-middot {\n     margin: 0 3px;\n     vertical-align: sub;\n }\n+\n+\n+/*********************/\n+/* SERIES INFO MODAL */\n+/*********************/\n+\n+#gh-series-info-modal .modal-header {\n+    padding: 25px 25px 0 !important;\n+}\n+\n+\n+#gh-series-info-modal .modal-body {\n+    padding: 20px;\n+}\n+\n+#gh-series-info-modal .gh-series-info-list {\n+    margin-top: 15px;\n+    max-height: 250px;\n+    overflow: scroll;\n+}\n+\n+/* Term */\n+\n+#gh-series-info-modal .gh-series-info-list .gh-series-info-list-term {\n+    position: relative;\n+}\n+\n+#gh-series-info-modal .gh-series-info-list > div {\n+    padding-left: 10px;\n+}\n+\n+#gh-series-info-modal .gh-series-info-list > div:not(:first-child) {\n+    padding-top: 20px;\n+}\n+\n+#gh-series-info-modal .gh-series-info-list .gh-series-info-list-no-events {\n+    padding: 10px;\n+}\n+\n+#gh-series-info-modal .gh-series-info-list .gh-series-info-list-term strong {\n+    border-bottom-style: solid;\n+    border-bottom-width: 1px;","path":"shared/gh/css/gh.components.css","position":75,"original_position":75,"commit_id":"79e22ce32777ecfad1a0e4fce2944f2ac47b211d","original_commit_id":"79e22ce32777ecfad1a0e4fce2944f2ac47b211d","user":{"login":"bp323","id":218391,"avatar_url":"https://avatars.githubusercontent.com/u/218391?v=3","gravatar_id":"","url":"https://api.github.com/users/bp323","html_url":"https://github.com/bp323","followers_url":"https://api.github.com/users/bp323/followers","following_url":"https://api.github.com/users/bp323/following{/other_user}","gists_url":"https://api.github.com/users/bp323/gists{/gist_id}","starred_url":"https://api.github.com/users/bp323/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bp323/subscriptions","organizations_url":"https://api.github.com/users/bp323/orgs","repos_url":"https://api.github.com/users/bp323/repos","events_url":"https://api.github.com/users/bp323/events{/privacy}","received_events_url":"https://api.github.com/users/bp323/received_events","type":"User","site_admin":false},"body":"Feel free to ignore this if it doesn't look as good","created_at":"2015-04-15T15:42:41Z","updated_at":"2015-04-15T15:42:41Z","html_url":"https://github.com/CUL-DigitalServices/grasshopper-ui/pull/340#discussion_r28432222","pull_request_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/pulls/340","_links":{"self":{"href":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/pulls/comments/28432222"},"html":{"href":"https://github.com/CUL-DigitalServices/grasshopper-ui/pull/340#discussion_r28432222"},"pull_request":{"href":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/pulls/340"}}},"pull_request":{"url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/pulls/340","id":33358964,"html_url":"https://github.com/CUL-DigitalServices/grasshopper-ui/pull/340","diff_url":"https://github.com/CUL-DigitalServices/grasshopper-ui/pull/340.diff","patch_url":"https://github.com/CUL-DigitalServices/grasshopper-ui/pull/340.patch","issue_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/issues/340","number":340,"state":"open","locked":false,"title":"Student UI: Improve lecture series info","user":{"login":"Coenego","id":2194396,"avatar_url":"https://avatars.githubusercontent.com/u/2194396?v=3","gravatar_id":"","url":"https://api.github.com/users/Coenego","html_url":"https://github.com/Coenego","followers_url":"https://api.github.com/users/Coenego/followers","following_url":"https://api.github.com/users/Coenego/following{/other_user}","gists_url":"https://api.github.com/users/Coenego/gists{/gist_id}","starred_url":"https://api.github.com/users/Coenego/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Coenego/subscriptions","organizations_url":"https://api.github.com/users/Coenego/orgs","repos_url":"https://api.github.com/users/Coenego/repos","events_url":"https://api.github.com/users/Coenego/events{/privacy}","received_events_url":"https://api.github.com/users/Coenego/received_events","type":"User","site_admin":false},"body":"I know the original design specified a tooltip, but now having actually used the info icon / info popup in the student UI, I think the comprehensive info should be lifted into a modal. This approach would also give a better handling of OT events than the column based approach.\r\n\r\nItems:\r\n* [x] Lift content into a modal. Invoke the modal when the info icon in the list is clicked or tapped.\r\n* [x] Add scrollable event list with date info, in date order which would take care of OT event handling\r\n* [x] Style dates as we do in the admin UI \r\n* [x] Add minimal series type info for each event, with tooltip explanation on hover (just basic)\r\n* [x] Include tripos and part in the modal title\r\n* [x] Concatenate all lecturers and venues at the bottom of the modal\r\n\r\n![adj-student-series-info](https://cloud.githubusercontent.com/assets/117483/6997554/545d0840-dbb7-11e4-9e3b-5695b94fd654.png)\r\n\r\n\r\n","created_at":"2015-04-15T14:19:49Z","updated_at":"2015-04-15T15:42:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"06554d325bd94af9367732334160956e55384b0f","assignee":{"login":"bp323","id":218391,"avatar_url":"https://avatars.githubusercontent.com/u/218391?v=3","gravatar_id":"","url":"https://api.github.com/users/bp323","html_url":"https://github.com/bp323","followers_url":"https://api.github.com/users/bp323/followers","following_url":"https://api.github.com/users/bp323/following{/other_user}","gists_url":"https://api.github.com/users/bp323/gists{/gist_id}","starred_url":"https://api.github.com/users/bp323/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bp323/subscriptions","organizations_url":"https://api.github.com/users/bp323/orgs","repos_url":"https://api.github.com/users/bp323/repos","events_url":"https://api.github.com/users/bp323/events{/privacy}","received_events_url":"https://api.github.com/users/bp323/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/milestones/1","html_url":"https://github.com/CUL-DigitalServices/grasshopper-ui/milestones/Beta%20release","labels_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/milestones/1/labels","id":1007640,"number":1,"title":"Beta release","description":"This should be a feature complete release with only minor and visual issues, publicly accessible and testable by end users. Hosted by CARET controlled cloud infrastructure, on the current QA server instance.","creator":{"login":"oszkarnagy","id":117483,"avatar_url":"https://avatars.githubusercontent.com/u/117483?v=3","gravatar_id":"","url":"https://api.github.com/users/oszkarnagy","html_url":"https://github.com/oszkarnagy","followers_url":"https://api.github.com/users/oszkarnagy/followers","following_url":"https://api.github.com/users/oszkarnagy/following{/other_user}","gists_url":"https://api.github.com/users/oszkarnagy/gists{/gist_id}","starred_url":"https://api.github.com/users/oszkarnagy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oszkarnagy/subscriptions","organizations_url":"https://api.github.com/users/oszkarnagy/orgs","repos_url":"https://api.github.com/users/oszkarnagy/repos","events_url":"https://api.github.com/users/oszkarnagy/events{/privacy}","received_events_url":"https://api.github.com/users/oszkarnagy/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":57,"state":"open","created_at":"2015-03-05T14:32:49Z","updated_at":"2015-04-15T15:17:01Z","due_on":"2015-04-27T23:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/pulls/340/commits","review_comments_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/pulls/340/comments","review_comment_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/issues/340/comments","statuses_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/statuses/79e22ce32777ecfad1a0e4fce2944f2ac47b211d","head":{"label":"Coenego:issue-340-series-info","ref":"issue-340-series-info","sha":"79e22ce32777ecfad1a0e4fce2944f2ac47b211d","user":{"login":"Coenego","id":2194396,"avatar_url":"https://avatars.githubusercontent.com/u/2194396?v=3","gravatar_id":"","url":"https://api.github.com/users/Coenego","html_url":"https://github.com/Coenego","followers_url":"https://api.github.com/users/Coenego/followers","following_url":"https://api.github.com/users/Coenego/following{/other_user}","gists_url":"https://api.github.com/users/Coenego/gists{/gist_id}","starred_url":"https://api.github.com/users/Coenego/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Coenego/subscriptions","organizations_url":"https://api.github.com/users/Coenego/orgs","repos_url":"https://api.github.com/users/Coenego/repos","events_url":"https://api.github.com/users/Coenego/events{/privacy}","received_events_url":"https://api.github.com/users/Coenego/received_events","type":"User","site_admin":false},"repo":{"id":26270317,"name":"grasshopper-ui","full_name":"Coenego/grasshopper-ui","owner":{"login":"Coenego","id":2194396,"avatar_url":"https://avatars.githubusercontent.com/u/2194396?v=3","gravatar_id":"","url":"https://api.github.com/users/Coenego","html_url":"https://github.com/Coenego","followers_url":"https://api.github.com/users/Coenego/followers","following_url":"https://api.github.com/users/Coenego/following{/other_user}","gists_url":"https://api.github.com/users/Coenego/gists{/gist_id}","starred_url":"https://api.github.com/users/Coenego/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Coenego/subscriptions","organizations_url":"https://api.github.com/users/Coenego/orgs","repos_url":"https://api.github.com/users/Coenego/repos","events_url":"https://api.github.com/users/Coenego/events{/privacy}","received_events_url":"https://api.github.com/users/Coenego/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Coenego/grasshopper-ui","description":"Grasshopper UI","fork":true,"url":"https://api.github.com/repos/Coenego/grasshopper-ui","forks_url":"https://api.github.com/repos/Coenego/grasshopper-ui/forks","keys_url":"https://api.github.com/repos/Coenego/grasshopper-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Coenego/grasshopper-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Coenego/grasshopper-ui/teams","hooks_url":"https://api.github.com/repos/Coenego/grasshopper-ui/hooks","issue_events_url":"https://api.github.com/repos/Coenego/grasshopper-ui/issues/events{/number}","events_url":"https://api.github.com/repos/Coenego/grasshopper-ui/events","assignees_url":"https://api.github.com/repos/Coenego/grasshopper-ui/assignees{/user}","branches_url":"https://api.github.com/repos/Coenego/grasshopper-ui/branches{/branch}","tags_url":"https://api.github.com/repos/Coenego/grasshopper-ui/tags","blobs_url":"https://api.github.com/repos/Coenego/grasshopper-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Coenego/grasshopper-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Coenego/grasshopper-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/Coenego/grasshopper-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Coenego/grasshopper-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/Coenego/grasshopper-ui/languages","stargazers_url":"https://api.github.com/repos/Coenego/grasshopper-ui/stargazers","contributors_url":"https://api.github.com/repos/Coenego/grasshopper-ui/contributors","subscribers_url":"https://api.github.com/repos/Coenego/grasshopper-ui/subscribers","subscription_url":"https://api.github.com/repos/Coenego/grasshopper-ui/subscription","commits_url":"https://api.github.com/repos/Coenego/grasshopper-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/Coenego/grasshopper-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/Coenego/grasshopper-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/Coenego/grasshopper-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/Coenego/grasshopper-ui/contents/{+path}","compare_url":"https://api.github.com/repos/Coenego/grasshopper-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Coenego/grasshopper-ui/merges","archive_url":"https://api.github.com/repos/Coenego/grasshopper-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Coenego/grasshopper-ui/downloads","issues_url":"https://api.github.com/repos/Coenego/grasshopper-ui/issues{/number}","pulls_url":"https://api.github.com/repos/Coenego/grasshopper-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/Coenego/grasshopper-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/Coenego/grasshopper-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Coenego/grasshopper-ui/labels{/name}","releases_url":"https://api.github.com/repos/Coenego/grasshopper-ui/releases{/id}","created_at":"2014-11-06T13:08:06Z","updated_at":"2015-04-02T11:24:47Z","pushed_at":"2015-04-15T14:39:03Z","git_url":"git://github.com/Coenego/grasshopper-ui.git","ssh_url":"git@github.com:Coenego/grasshopper-ui.git","clone_url":"https://github.com/Coenego/grasshopper-ui.git","svn_url":"https://github.com/Coenego/grasshopper-ui","homepage":null,"size":9623,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CUL-DigitalServices:master","ref":"master","sha":"29f892376eaa169635bfdc599adc40722d784120","user":{"login":"CUL-DigitalServices","id":5594563,"avatar_url":"https://avatars.githubusercontent.com/u/5594563?v=3","gravatar_id":"","url":"https://api.github.com/users/CUL-DigitalServices","html_url":"https://github.com/CUL-DigitalServices","followers_url":"https://api.github.com/users/CUL-DigitalServices/followers","following_url":"https://api.github.com/users/CUL-DigitalServices/following{/other_user}","gists_url":"https://api.github.com/users/CUL-DigitalServices/gists{/gist_id}","starred_url":"https://api.github.com/users/CUL-DigitalServices/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CUL-DigitalServices/subscriptions","organizations_url":"https://api.github.com/users/CUL-DigitalServices/orgs","repos_url":"https://api.github.com/users/CUL-DigitalServices/repos","events_url":"https://api.github.com/users/CUL-DigitalServices/events{/privacy}","received_events_url":"https://api.github.com/users/CUL-DigitalServices/received_events","type":"Organization","site_admin":false},"repo":{"id":26270238,"name":"grasshopper-ui","full_name":"CUL-DigitalServices/grasshopper-ui","owner":{"login":"CUL-DigitalServices","id":5594563,"avatar_url":"https://avatars.githubusercontent.com/u/5594563?v=3","gravatar_id":"","url":"https://api.github.com/users/CUL-DigitalServices","html_url":"https://github.com/CUL-DigitalServices","followers_url":"https://api.github.com/users/CUL-DigitalServices/followers","following_url":"https://api.github.com/users/CUL-DigitalServices/following{/other_user}","gists_url":"https://api.github.com/users/CUL-DigitalServices/gists{/gist_id}","starred_url":"https://api.github.com/users/CUL-DigitalServices/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CUL-DigitalServices/subscriptions","organizations_url":"https://api.github.com/users/CUL-DigitalServices/orgs","repos_url":"https://api.github.com/users/CUL-DigitalServices/repos","events_url":"https://api.github.com/users/CUL-DigitalServices/events{/privacy}","received_events_url":"https://api.github.com/users/CUL-DigitalServices/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CUL-DigitalServices/grasshopper-ui","description":"Grasshopper UI","fork":true,"url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui","forks_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/forks","keys_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/teams","hooks_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/hooks","issue_events_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/issues/events{/number}","events_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/events","assignees_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/assignees{/user}","branches_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/branches{/branch}","tags_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/tags","blobs_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/languages","stargazers_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/stargazers","contributors_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/contributors","subscribers_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/subscribers","subscription_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/subscription","commits_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/contents/{+path}","compare_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/merges","archive_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/downloads","issues_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/issues{/number}","pulls_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/labels{/name}","releases_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/releases{/id}","created_at":"2014-11-06T13:06:00Z","updated_at":"2015-04-15T14:32:51Z","pushed_at":"2015-04-15T15:16:38Z","git_url":"git://github.com/CUL-DigitalServices/grasshopper-ui.git","ssh_url":"git@github.com:CUL-DigitalServices/grasshopper-ui.git","clone_url":"https://github.com/CUL-DigitalServices/grasshopper-ui.git","svn_url":"https://github.com/CUL-DigitalServices/grasshopper-ui","homepage":null,"size":11018,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":8,"forks":3,"open_issues":8,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/pulls/340"},"html":{"href":"https://github.com/CUL-DigitalServices/grasshopper-ui/pull/340"},"issue":{"href":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/issues/340"},"comments":{"href":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/issues/340/comments"},"review_comments":{"href":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/pulls/340/comments"},"review_comment":{"href":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/pulls/340/commits"},"statuses":{"href":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-ui/statuses/79e22ce32777ecfad1a0e4fce2944f2ac47b211d"}}}}