{"action":"created","comment":{"url":"https://api.github.com/repos/flynn/flynn/pulls/comments/30007666","id":30007666,"diff_hunk":"@@ -137,49 +130,76 @@ func (api *httpAPI) AssetManifest() (*assetManifest, error) {\n }\n \n func (api *httpAPI) LaunchCluster(w http.ResponseWriter, req *http.Request, params httprouter.Params) {\n-\tvar input *jsonInput\n-\tif err := httphelper.DecodeJSON(req, &input); err != nil {\n+\n+\tvar inputJSON bytes.Buffer\n+\tif _, err := io.Copy(&inputJSON, req.Body); err != nil {\n \t\thttphelper.Error(w, err)\n \t\treturn\n \t}\n \n-\tvar creds aws.CredentialsProvider\n-\tvar credentialID string\n-\tvar credentialSecret string\n-\tif input.Creds.AccessKeyID != \"\" && input.Creds.SecretAccessKey != \"\" {\n-\t\tcreds = aws.Creds(input.Creds.AccessKeyID, input.Creds.SecretAccessKey, \"\")\n-\t\tcredentialID = input.Creds.AccessKeyID\n-\t\tcredentialSecret = input.Creds.SecretAccessKey\n+\tdecodeJSON := func(dst interface{}) error {\n+\t\tin := bytes.NewBuffer(inputJSON.Bytes())\n+\t\tdec := json.NewDecoder(in)\n+\t\treturn dec.Decode(dst)","path":"installer/http.go","position":80,"original_position":80,"commit_id":"e5970a8cd6d1b751288046b6b41c99e6f58211ce","original_commit_id":"e5970a8cd6d1b751288046b6b41c99e6f58211ce","user":{"login":"titanous","id":13026,"avatar_url":"https://avatars.githubusercontent.com/u/13026?v=3","gravatar_id":"","url":"https://api.github.com/users/titanous","html_url":"https://github.com/titanous","followers_url":"https://api.github.com/users/titanous/followers","following_url":"https://api.github.com/users/titanous/following{/other_user}","gists_url":"https://api.github.com/users/titanous/gists{/gist_id}","starred_url":"https://api.github.com/users/titanous/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/titanous/subscriptions","organizations_url":"https://api.github.com/users/titanous/orgs","repos_url":"https://api.github.com/users/titanous/repos","events_url":"https://api.github.com/users/titanous/events{/privacy}","received_events_url":"https://api.github.com/users/titanous/received_events","type":"User","site_admin":false},"body":"```go\r\nreturn json.Unmarshal(inputJSON.Bytes(), in)\r\n```","created_at":"2015-05-10T23:43:37Z","updated_at":"2015-05-10T23:43:37Z","html_url":"https://github.com/flynn/flynn/pull/1506#discussion_r30007666","pull_request_url":"https://api.github.com/repos/flynn/flynn/pulls/1506","_links":{"self":{"href":"https://api.github.com/repos/flynn/flynn/pulls/comments/30007666"},"html":{"href":"https://github.com/flynn/flynn/pull/1506#discussion_r30007666"},"pull_request":{"href":"https://api.github.com/repos/flynn/flynn/pulls/1506"}}},"pull_request":{"url":"https://api.github.com/repos/flynn/flynn/pulls/1506","id":35013990,"html_url":"https://github.com/flynn/flynn/pull/1506","diff_url":"https://github.com/flynn/flynn/pull/1506.diff","patch_url":"https://github.com/flynn/flynn/pull/1506.patch","issue_url":"https://api.github.com/repos/flynn/flynn/issues/1506","number":1506,"state":"open","locked":false,"title":"installer: DigitalOcean","user":{"login":"jvatic","id":171040,"avatar_url":"https://avatars.githubusercontent.com/u/171040?v=3","gravatar_id":"","url":"https://api.github.com/users/jvatic","html_url":"https://github.com/jvatic","followers_url":"https://api.github.com/users/jvatic/followers","following_url":"https://api.github.com/users/jvatic/following{/other_user}","gists_url":"https://api.github.com/users/jvatic/gists{/gist_id}","starred_url":"https://api.github.com/users/jvatic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jvatic/subscriptions","organizations_url":"https://api.github.com/users/jvatic/orgs","repos_url":"https://api.github.com/users/jvatic/repos","events_url":"https://api.github.com/users/jvatic/events{/privacy}","received_events_url":"https://api.github.com/users/jvatic/received_events","type":"User","site_admin":false},"body":"ping @titanous \r\n\r\n![screen shot 2015-05-10 at 08 56 31](https://cloud.githubusercontent.com/assets/171040/7554333/a5d8a516-f6f2-11e4-8740-8b869ea32eab.png)\r\n![screen shot 2015-05-10 at 08 57 10](https://cloud.githubusercontent.com/assets/171040/7554337/b5bdb6b0-f6f2-11e4-907b-87ce9eae16e1.png)\r\n![screen shot 2015-05-10 at 08 57 23](https://cloud.githubusercontent.com/assets/171040/7554335/ad2dd87c-f6f2-11e4-872f-aab049e800e3.png)\r\n![screen shot 2015-05-10 at 08 57 00](https://cloud.githubusercontent.com/assets/171040/7554338/b8a48192-f6f2-11e4-8c8e-26c0b3b245c8.png)\r\n![screen shot 2015-05-10 at 08 56 35](https://cloud.githubusercontent.com/assets/171040/7554339/bc29b49a-f6f2-11e4-8415-c3de8c788287.png)\r\n\r\n\r\nThere are still a few pending TODOs on the UX side of things:\r\n\r\n- [x] Handle SSE events in batches (prevents page from locking up)\r\n- [x] Fix CSS for install log (long lines break the layout)\r\n- [x] Fix DO configuration page when coming from creating the first DO credential\r\n- [x] The \"New\" nav item should reflect the current target cloud selection in URL\r\n- [x] Error handling for credential management (create / delete)\r\n- [x] Reloading page ","created_at":"2015-05-08T14:32:18Z","updated_at":"2015-05-10T23:43:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0385c795e7f53d42b1f9cc3894dcf61c5c999922","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/flynn/flynn/pulls/1506/commits","review_comments_url":"https://api.github.com/repos/flynn/flynn/pulls/1506/comments","review_comment_url":"https://api.github.com/repos/flynn/flynn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flynn/flynn/issues/1506/comments","statuses_url":"https://api.github.com/repos/flynn/flynn/statuses/e5970a8cd6d1b751288046b6b41c99e6f58211ce","head":{"label":"flynn:installer-digital-ocean","ref":"installer-digital-ocean","sha":"e5970a8cd6d1b751288046b6b41c99e6f58211ce","user":{"login":"flynn","id":4973613,"avatar_url":"https://avatars.githubusercontent.com/u/4973613?v=3","gravatar_id":"","url":"https://api.github.com/users/flynn","html_url":"https://github.com/flynn","followers_url":"https://api.github.com/users/flynn/followers","following_url":"https://api.github.com/users/flynn/following{/other_user}","gists_url":"https://api.github.com/users/flynn/gists{/gist_id}","starred_url":"https://api.github.com/users/flynn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flynn/subscriptions","organizations_url":"https://api.github.com/users/flynn/orgs","repos_url":"https://api.github.com/users/flynn/repos","events_url":"https://api.github.com/users/flynn/events{/privacy}","received_events_url":"https://api.github.com/users/flynn/received_events","type":"Organization","site_admin":false},"repo":{"id":11290232,"name":"flynn","full_name":"flynn/flynn","owner":{"login":"flynn","id":4973613,"avatar_url":"https://avatars.githubusercontent.com/u/4973613?v=3","gravatar_id":"","url":"https://api.github.com/users/flynn","html_url":"https://github.com/flynn","followers_url":"https://api.github.com/users/flynn/followers","following_url":"https://api.github.com/users/flynn/following{/other_user}","gists_url":"https://api.github.com/users/flynn/gists{/gist_id}","starred_url":"https://api.github.com/users/flynn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flynn/subscriptions","organizations_url":"https://api.github.com/users/flynn/orgs","repos_url":"https://api.github.com/users/flynn/repos","events_url":"https://api.github.com/users/flynn/events{/privacy}","received_events_url":"https://api.github.com/users/flynn/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/flynn/flynn","description":"A next generation open source platform as a service (PaaS)","fork":false,"url":"https://api.github.com/repos/flynn/flynn","forks_url":"https://api.github.com/repos/flynn/flynn/forks","keys_url":"https://api.github.com/repos/flynn/flynn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flynn/flynn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flynn/flynn/teams","hooks_url":"https://api.github.com/repos/flynn/flynn/hooks","issue_events_url":"https://api.github.com/repos/flynn/flynn/issues/events{/number}","events_url":"https://api.github.com/repos/flynn/flynn/events","assignees_url":"https://api.github.com/repos/flynn/flynn/assignees{/user}","branches_url":"https://api.github.com/repos/flynn/flynn/branches{/branch}","tags_url":"https://api.github.com/repos/flynn/flynn/tags","blobs_url":"https://api.github.com/repos/flynn/flynn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flynn/flynn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flynn/flynn/git/refs{/sha}","trees_url":"https://api.github.com/repos/flynn/flynn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flynn/flynn/statuses/{sha}","languages_url":"https://api.github.com/repos/flynn/flynn/languages","stargazers_url":"https://api.github.com/repos/flynn/flynn/stargazers","contributors_url":"https://api.github.com/repos/flynn/flynn/contributors","subscribers_url":"https://api.github.com/repos/flynn/flynn/subscribers","subscription_url":"https://api.github.com/repos/flynn/flynn/subscription","commits_url":"https://api.github.com/repos/flynn/flynn/commits{/sha}","git_commits_url":"https://api.github.com/repos/flynn/flynn/git/commits{/sha}","comments_url":"https://api.github.com/repos/flynn/flynn/comments{/number}","issue_comment_url":"https://api.github.com/repos/flynn/flynn/issues/comments{/number}","contents_url":"https://api.github.com/repos/flynn/flynn/contents/{+path}","compare_url":"https://api.github.com/repos/flynn/flynn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flynn/flynn/merges","archive_url":"https://api.github.com/repos/flynn/flynn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flynn/flynn/downloads","issues_url":"https://api.github.com/repos/flynn/flynn/issues{/number}","pulls_url":"https://api.github.com/repos/flynn/flynn/pulls{/number}","milestones_url":"https://api.github.com/repos/flynn/flynn/milestones{/number}","notifications_url":"https://api.github.com/repos/flynn/flynn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flynn/flynn/labels{/name}","releases_url":"https://api.github.com/repos/flynn/flynn/releases{/id}","created_at":"2013-07-09T18:22:06Z","updated_at":"2015-05-10T21:33:55Z","pushed_at":"2015-05-10T22:09:55Z","git_url":"git://github.com/flynn/flynn.git","ssh_url":"git@github.com:flynn/flynn.git","clone_url":"https://github.com/flynn/flynn.git","svn_url":"https://github.com/flynn/flynn","homepage":"https://flynn.io","size":52768,"stargazers_count":3531,"watchers_count":3531,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":246,"mirror_url":null,"open_issues_count":192,"forks":246,"open_issues":192,"watchers":3531,"default_branch":"master"}},"base":{"label":"flynn:master","ref":"master","sha":"5bc677d8f0e7eb8be16069b758e51079d9c58a95","user":{"login":"flynn","id":4973613,"avatar_url":"https://avatars.githubusercontent.com/u/4973613?v=3","gravatar_id":"","url":"https://api.github.com/users/flynn","html_url":"https://github.com/flynn","followers_url":"https://api.github.com/users/flynn/followers","following_url":"https://api.github.com/users/flynn/following{/other_user}","gists_url":"https://api.github.com/users/flynn/gists{/gist_id}","starred_url":"https://api.github.com/users/flynn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flynn/subscriptions","organizations_url":"https://api.github.com/users/flynn/orgs","repos_url":"https://api.github.com/users/flynn/repos","events_url":"https://api.github.com/users/flynn/events{/privacy}","received_events_url":"https://api.github.com/users/flynn/received_events","type":"Organization","site_admin":false},"repo":{"id":11290232,"name":"flynn","full_name":"flynn/flynn","owner":{"login":"flynn","id":4973613,"avatar_url":"https://avatars.githubusercontent.com/u/4973613?v=3","gravatar_id":"","url":"https://api.github.com/users/flynn","html_url":"https://github.com/flynn","followers_url":"https://api.github.com/users/flynn/followers","following_url":"https://api.github.com/users/flynn/following{/other_user}","gists_url":"https://api.github.com/users/flynn/gists{/gist_id}","starred_url":"https://api.github.com/users/flynn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flynn/subscriptions","organizations_url":"https://api.github.com/users/flynn/orgs","repos_url":"https://api.github.com/users/flynn/repos","events_url":"https://api.github.com/users/flynn/events{/privacy}","received_events_url":"https://api.github.com/users/flynn/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/flynn/flynn","description":"A next generation open source platform as a service (PaaS)","fork":false,"url":"https://api.github.com/repos/flynn/flynn","forks_url":"https://api.github.com/repos/flynn/flynn/forks","keys_url":"https://api.github.com/repos/flynn/flynn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flynn/flynn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flynn/flynn/teams","hooks_url":"https://api.github.com/repos/flynn/flynn/hooks","issue_events_url":"https://api.github.com/repos/flynn/flynn/issues/events{/number}","events_url":"https://api.github.com/repos/flynn/flynn/events","assignees_url":"https://api.github.com/repos/flynn/flynn/assignees{/user}","branches_url":"https://api.github.com/repos/flynn/flynn/branches{/branch}","tags_url":"https://api.github.com/repos/flynn/flynn/tags","blobs_url":"https://api.github.com/repos/flynn/flynn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flynn/flynn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flynn/flynn/git/refs{/sha}","trees_url":"https://api.github.com/repos/flynn/flynn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flynn/flynn/statuses/{sha}","languages_url":"https://api.github.com/repos/flynn/flynn/languages","stargazers_url":"https://api.github.com/repos/flynn/flynn/stargazers","contributors_url":"https://api.github.com/repos/flynn/flynn/contributors","subscribers_url":"https://api.github.com/repos/flynn/flynn/subscribers","subscription_url":"https://api.github.com/repos/flynn/flynn/subscription","commits_url":"https://api.github.com/repos/flynn/flynn/commits{/sha}","git_commits_url":"https://api.github.com/repos/flynn/flynn/git/commits{/sha}","comments_url":"https://api.github.com/repos/flynn/flynn/comments{/number}","issue_comment_url":"https://api.github.com/repos/flynn/flynn/issues/comments{/number}","contents_url":"https://api.github.com/repos/flynn/flynn/contents/{+path}","compare_url":"https://api.github.com/repos/flynn/flynn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flynn/flynn/merges","archive_url":"https://api.github.com/repos/flynn/flynn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flynn/flynn/downloads","issues_url":"https://api.github.com/repos/flynn/flynn/issues{/number}","pulls_url":"https://api.github.com/repos/flynn/flynn/pulls{/number}","milestones_url":"https://api.github.com/repos/flynn/flynn/milestones{/number}","notifications_url":"https://api.github.com/repos/flynn/flynn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flynn/flynn/labels{/name}","releases_url":"https://api.github.com/repos/flynn/flynn/releases{/id}","created_at":"2013-07-09T18:22:06Z","updated_at":"2015-05-10T21:33:55Z","pushed_at":"2015-05-10T22:09:55Z","git_url":"git://github.com/flynn/flynn.git","ssh_url":"git@github.com:flynn/flynn.git","clone_url":"https://github.com/flynn/flynn.git","svn_url":"https://github.com/flynn/flynn","homepage":"https://flynn.io","size":52768,"stargazers_count":3531,"watchers_count":3531,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":246,"mirror_url":null,"open_issues_count":192,"forks":246,"open_issues":192,"watchers":3531,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flynn/flynn/pulls/1506"},"html":{"href":"https://github.com/flynn/flynn/pull/1506"},"issue":{"href":"https://api.github.com/repos/flynn/flynn/issues/1506"},"comments":{"href":"https://api.github.com/repos/flynn/flynn/issues/1506/comments"},"review_comments":{"href":"https://api.github.com/repos/flynn/flynn/pulls/1506/comments"},"review_comment":{"href":"https://api.github.com/repos/flynn/flynn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flynn/flynn/pulls/1506/commits"},"statuses":{"href":"https://api.github.com/repos/flynn/flynn/statuses/e5970a8cd6d1b751288046b6b41c99e6f58211ce"}}}}