{"action":"created","comment":{"url":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/pulls/comments/28656351","id":28656351,"diff_hunk":"@@ -66,4 +66,22 @@ let read ?demangle ~filename arch base  : string table =\n             let mem = Memory.view ~from ~words base |> ok_exn in\n             let name = demangle name in\n             Table.add syms mem name |> ok_exn\n-          with exn -> syms))\n+          with _exn -> syms))\n+\n+let read_addrset filename : Addr.Hash_set.t =\n+  let ic = In_channel.create filename in\n+  let set_string = In_channel.input_all ic in\n+  Addr.Hash_set.t_of_sexp @@ Sexp.of_string set_string\n+\n+let write_addrset ?filename (addr_set : Addr.Hash_set.t) : unit =\n+  let oc = match filename with\n+    | None -> Out_channel.stdout\n+    | Some f -> Out_channel.create f in\n+  Out_channel.output_string oc @@ Sexp.to_string (Addr.Hash_set.sexp_of_t addr_set);\n+  Out_channel.close oc\n+\n+let write ?filename (syms : symbol table) : unit =\n+  let fs_l = Table.foldi syms ~init:[] ~f:(fun mem _sym fs_list ->","path":"src/readbin/symbols.ml","position":null,"original_position":20,"commit_id":"4c8e26ecfae7eeb8b1585cb8617e97c15b017183","original_commit_id":"825832597234ec4a15fca77af396b7346f0f8717","user":{"login":"ivg","id":2336698,"avatar_url":"https://avatars.githubusercontent.com/u/2336698?v=3","gravatar_id":"","url":"https://api.github.com/users/ivg","html_url":"https://github.com/ivg","followers_url":"https://api.github.com/users/ivg/followers","following_url":"https://api.github.com/users/ivg/following{/other_user}","gists_url":"https://api.github.com/users/ivg/gists{/gist_id}","starred_url":"https://api.github.com/users/ivg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivg/subscriptions","organizations_url":"https://api.github.com/users/ivg/orgs","repos_url":"https://api.github.com/users/ivg/repos","events_url":"https://api.github.com/users/ivg/events{/privacy}","received_events_url":"https://api.github.com/users/ivg/received_events","type":"User","site_admin":false},"body":"That's ok, but if you want set, why you're using list? ;)","created_at":"2015-04-19T20:24:04Z","updated_at":"2015-04-19T20:24:04Z","html_url":"https://github.com/BinaryAnalysisPlatform/bap/pull/182#discussion_r28656351","pull_request_url":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/pulls/182","_links":{"self":{"href":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/pulls/comments/28656351"},"html":{"href":"https://github.com/BinaryAnalysisPlatform/bap/pull/182#discussion_r28656351"},"pull_request":{"href":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/pulls/182"}}},"pull_request":{"url":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/pulls/182","id":33315080,"html_url":"https://github.com/BinaryAnalysisPlatform/bap/pull/182","diff_url":"https://github.com/BinaryAnalysisPlatform/bap/pull/182.diff","patch_url":"https://github.com/BinaryAnalysisPlatform/bap/pull/182.patch","issue_url":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/issues/182","number":182,"state":"open","locked":false,"title":"bap-compare implementation","user":{"login":"tiffanyb","id":4591194,"avatar_url":"https://avatars.githubusercontent.com/u/4591194?v=3","gravatar_id":"","url":"https://api.github.com/users/tiffanyb","html_url":"https://github.com/tiffanyb","followers_url":"https://api.github.com/users/tiffanyb/followers","following_url":"https://api.github.com/users/tiffanyb/following{/other_user}","gists_url":"https://api.github.com/users/tiffanyb/gists{/gist_id}","starred_url":"https://api.github.com/users/tiffanyb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiffanyb/subscriptions","organizations_url":"https://api.github.com/users/tiffanyb/orgs","repos_url":"https://api.github.com/users/tiffanyb/repos","events_url":"https://api.github.com/users/tiffanyb/events{/privacy}","received_events_url":"https://api.github.com/users/tiffanyb/received_events","type":"User","site_admin":false},"body":"This pr is to implement the `bap-compare` command, which evaluates tools (IDA and ByteWeight) on function start identification against known ground truth.","created_at":"2015-04-15T01:15:52Z","updated_at":"2015-04-19T20:24:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"24b2af6ecfa8c978cce5a33fd17923ac4b7debe2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/pulls/182/commits","review_comments_url":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/pulls/182/comments","review_comment_url":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/pulls/comments{/number}","comments_url":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/issues/182/comments","statuses_url":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/statuses/4c8e26ecfae7eeb8b1585cb8617e97c15b017183","head":{"label":"tiffanyb:bw_eval_pr","ref":"bw_eval_pr","sha":"4c8e26ecfae7eeb8b1585cb8617e97c15b017183","user":{"login":"tiffanyb","id":4591194,"avatar_url":"https://avatars.githubusercontent.com/u/4591194?v=3","gravatar_id":"","url":"https://api.github.com/users/tiffanyb","html_url":"https://github.com/tiffanyb","followers_url":"https://api.github.com/users/tiffanyb/followers","following_url":"https://api.github.com/users/tiffanyb/following{/other_user}","gists_url":"https://api.github.com/users/tiffanyb/gists{/gist_id}","starred_url":"https://api.github.com/users/tiffanyb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiffanyb/subscriptions","organizations_url":"https://api.github.com/users/tiffanyb/orgs","repos_url":"https://api.github.com/users/tiffanyb/repos","events_url":"https://api.github.com/users/tiffanyb/events{/privacy}","received_events_url":"https://api.github.com/users/tiffanyb/received_events","type":"User","site_admin":false},"repo":{"id":26604858,"name":"bap","full_name":"tiffanyb/bap","owner":{"login":"tiffanyb","id":4591194,"avatar_url":"https://avatars.githubusercontent.com/u/4591194?v=3","gravatar_id":"","url":"https://api.github.com/users/tiffanyb","html_url":"https://github.com/tiffanyb","followers_url":"https://api.github.com/users/tiffanyb/followers","following_url":"https://api.github.com/users/tiffanyb/following{/other_user}","gists_url":"https://api.github.com/users/tiffanyb/gists{/gist_id}","starred_url":"https://api.github.com/users/tiffanyb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiffanyb/subscriptions","organizations_url":"https://api.github.com/users/tiffanyb/orgs","repos_url":"https://api.github.com/users/tiffanyb/repos","events_url":"https://api.github.com/users/tiffanyb/events{/privacy}","received_events_url":"https://api.github.com/users/tiffanyb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tiffanyb/bap","description":"BAP Core Library","fork":true,"url":"https://api.github.com/repos/tiffanyb/bap","forks_url":"https://api.github.com/repos/tiffanyb/bap/forks","keys_url":"https://api.github.com/repos/tiffanyb/bap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tiffanyb/bap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tiffanyb/bap/teams","hooks_url":"https://api.github.com/repos/tiffanyb/bap/hooks","issue_events_url":"https://api.github.com/repos/tiffanyb/bap/issues/events{/number}","events_url":"https://api.github.com/repos/tiffanyb/bap/events","assignees_url":"https://api.github.com/repos/tiffanyb/bap/assignees{/user}","branches_url":"https://api.github.com/repos/tiffanyb/bap/branches{/branch}","tags_url":"https://api.github.com/repos/tiffanyb/bap/tags","blobs_url":"https://api.github.com/repos/tiffanyb/bap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tiffanyb/bap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tiffanyb/bap/git/refs{/sha}","trees_url":"https://api.github.com/repos/tiffanyb/bap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tiffanyb/bap/statuses/{sha}","languages_url":"https://api.github.com/repos/tiffanyb/bap/languages","stargazers_url":"https://api.github.com/repos/tiffanyb/bap/stargazers","contributors_url":"https://api.github.com/repos/tiffanyb/bap/contributors","subscribers_url":"https://api.github.com/repos/tiffanyb/bap/subscribers","subscription_url":"https://api.github.com/repos/tiffanyb/bap/subscription","commits_url":"https://api.github.com/repos/tiffanyb/bap/commits{/sha}","git_commits_url":"https://api.github.com/repos/tiffanyb/bap/git/commits{/sha}","comments_url":"https://api.github.com/repos/tiffanyb/bap/comments{/number}","issue_comment_url":"https://api.github.com/repos/tiffanyb/bap/issues/comments{/number}","contents_url":"https://api.github.com/repos/tiffanyb/bap/contents/{+path}","compare_url":"https://api.github.com/repos/tiffanyb/bap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tiffanyb/bap/merges","archive_url":"https://api.github.com/repos/tiffanyb/bap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tiffanyb/bap/downloads","issues_url":"https://api.github.com/repos/tiffanyb/bap/issues{/number}","pulls_url":"https://api.github.com/repos/tiffanyb/bap/pulls{/number}","milestones_url":"https://api.github.com/repos/tiffanyb/bap/milestones{/number}","notifications_url":"https://api.github.com/repos/tiffanyb/bap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tiffanyb/bap/labels{/name}","releases_url":"https://api.github.com/repos/tiffanyb/bap/releases{/id}","created_at":"2014-11-13T19:47:31Z","updated_at":"2015-04-18T21:13:36Z","pushed_at":"2015-04-19T03:38:09Z","git_url":"git://github.com/tiffanyb/bap.git","ssh_url":"git@github.com:tiffanyb/bap.git","clone_url":"https://github.com/tiffanyb/bap.git","svn_url":"https://github.com/tiffanyb/bap","homepage":null,"size":974,"stargazers_count":0,"watchers_count":0,"language":"OCaml","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"BinaryAnalysisPlatform:master","ref":"master","sha":"53f8a88092ffd85753e75f510b39b2e9b14ba028","user":{"login":"BinaryAnalysisPlatform","id":8669375,"avatar_url":"https://avatars.githubusercontent.com/u/8669375?v=3","gravatar_id":"","url":"https://api.github.com/users/BinaryAnalysisPlatform","html_url":"https://github.com/BinaryAnalysisPlatform","followers_url":"https://api.github.com/users/BinaryAnalysisPlatform/followers","following_url":"https://api.github.com/users/BinaryAnalysisPlatform/following{/other_user}","gists_url":"https://api.github.com/users/BinaryAnalysisPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/BinaryAnalysisPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BinaryAnalysisPlatform/subscriptions","organizations_url":"https://api.github.com/users/BinaryAnalysisPlatform/orgs","repos_url":"https://api.github.com/users/BinaryAnalysisPlatform/repos","events_url":"https://api.github.com/users/BinaryAnalysisPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/BinaryAnalysisPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":25968851,"name":"bap","full_name":"BinaryAnalysisPlatform/bap","owner":{"login":"BinaryAnalysisPlatform","id":8669375,"avatar_url":"https://avatars.githubusercontent.com/u/8669375?v=3","gravatar_id":"","url":"https://api.github.com/users/BinaryAnalysisPlatform","html_url":"https://github.com/BinaryAnalysisPlatform","followers_url":"https://api.github.com/users/BinaryAnalysisPlatform/followers","following_url":"https://api.github.com/users/BinaryAnalysisPlatform/following{/other_user}","gists_url":"https://api.github.com/users/BinaryAnalysisPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/BinaryAnalysisPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BinaryAnalysisPlatform/subscriptions","organizations_url":"https://api.github.com/users/BinaryAnalysisPlatform/orgs","repos_url":"https://api.github.com/users/BinaryAnalysisPlatform/repos","events_url":"https://api.github.com/users/BinaryAnalysisPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/BinaryAnalysisPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/BinaryAnalysisPlatform/bap","description":"BAP Core Library","fork":false,"url":"https://api.github.com/repos/BinaryAnalysisPlatform/bap","forks_url":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/forks","keys_url":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/teams","hooks_url":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/hooks","issue_events_url":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/issues/events{/number}","events_url":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/events","assignees_url":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/assignees{/user}","branches_url":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/branches{/branch}","tags_url":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/tags","blobs_url":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/git/refs{/sha}","trees_url":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/statuses/{sha}","languages_url":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/languages","stargazers_url":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/stargazers","contributors_url":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/contributors","subscribers_url":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/subscribers","subscription_url":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/subscription","commits_url":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/commits{/sha}","git_commits_url":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/git/commits{/sha}","comments_url":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/comments{/number}","issue_comment_url":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/issues/comments{/number}","contents_url":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/contents/{+path}","compare_url":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/merges","archive_url":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/downloads","issues_url":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/issues{/number}","pulls_url":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/pulls{/number}","milestones_url":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/milestones{/number}","notifications_url":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/labels{/name}","releases_url":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/releases{/id}","created_at":"2014-10-30T11:59:43Z","updated_at":"2015-04-16T15:01:52Z","pushed_at":"2015-04-19T03:38:09Z","git_url":"git://github.com/BinaryAnalysisPlatform/bap.git","ssh_url":"git@github.com:BinaryAnalysisPlatform/bap.git","clone_url":"https://github.com/BinaryAnalysisPlatform/bap.git","svn_url":"https://github.com/BinaryAnalysisPlatform/bap","homepage":null,"size":3960,"stargazers_count":102,"watchers_count":102,"language":"OCaml","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":30,"mirror_url":null,"open_issues_count":26,"forks":30,"open_issues":26,"watchers":102,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/pulls/182"},"html":{"href":"https://github.com/BinaryAnalysisPlatform/bap/pull/182"},"issue":{"href":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/issues/182"},"comments":{"href":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/issues/182/comments"},"review_comments":{"href":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/pulls/182/comments"},"review_comment":{"href":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/pulls/182/commits"},"statuses":{"href":"https://api.github.com/repos/BinaryAnalysisPlatform/bap/statuses/4c8e26ecfae7eeb8b1585cb8617e97c15b017183"}}}}