{"action":"closed","number":111,"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppetlabs-java/pulls/111","id":29903381,"html_url":"https://github.com/puppetlabs/puppetlabs-java/pull/111","diff_url":"https://github.com/puppetlabs/puppetlabs-java/pull/111.diff","patch_url":"https://github.com/puppetlabs/puppetlabs-java/pull/111.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppetlabs-java/issues/111","number":111,"state":"closed","locked":false,"title":"Check the key exists before blindly looking up a hash","user":{"login":"PierreR","id":93115,"avatar_url":"https://avatars.githubusercontent.com/u/93115?v=3","gravatar_id":"","url":"https://api.github.com/users/PierreR","html_url":"https://github.com/PierreR","followers_url":"https://api.github.com/users/PierreR/followers","following_url":"https://api.github.com/users/PierreR/following{/other_user}","gists_url":"https://api.github.com/users/PierreR/gists{/gist_id}","starred_url":"https://api.github.com/users/PierreR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PierreR/subscriptions","organizations_url":"https://api.github.com/users/PierreR/orgs","repos_url":"https://api.github.com/users/PierreR/repos","events_url":"https://api.github.com/users/PierreR/events{/privacy}","received_events_url":"https://api.github.com/users/PierreR/received_events","type":"User","site_admin":false},"body":"[Language puppet](https://github.com/bartavelle/language-puppet) (rightly) produces an error when looking up a hash with an unknown key.\r\n\r\nThis PR explicitly checks if the key exists before the lookup following the best practices.\r\n\r\nThanks for merging it as soon as possible.\r\n\r\nCheers\r\n","created_at":"2015-02-24T14:53:31Z","updated_at":"2015-02-28T20:31:20Z","closed_at":"2015-02-28T20:31:20Z","merged_at":null,"merge_commit_sha":"7464aa46e36e28bb14448ad85a9a0be6e4cbcbfc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/puppetlabs-java/pulls/111/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-java/pulls/111/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppetlabs-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-java/issues/111/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppetlabs-java/statuses/912d67492e13f4c0eda79b0adf4b29b302a9cdfc","head":{"label":"PierreR:master","ref":"master","sha":"912d67492e13f4c0eda79b0adf4b29b302a9cdfc","user":{"login":"PierreR","id":93115,"avatar_url":"https://avatars.githubusercontent.com/u/93115?v=3","gravatar_id":"","url":"https://api.github.com/users/PierreR","html_url":"https://github.com/PierreR","followers_url":"https://api.github.com/users/PierreR/followers","following_url":"https://api.github.com/users/PierreR/following{/other_user}","gists_url":"https://api.github.com/users/PierreR/gists{/gist_id}","starred_url":"https://api.github.com/users/PierreR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PierreR/subscriptions","organizations_url":"https://api.github.com/users/PierreR/orgs","repos_url":"https://api.github.com/users/PierreR/repos","events_url":"https://api.github.com/users/PierreR/events{/privacy}","received_events_url":"https://api.github.com/users/PierreR/received_events","type":"User","site_admin":false},"repo":{"id":23540653,"name":"puppetlabs-java","full_name":"PierreR/puppetlabs-java","owner":{"login":"PierreR","id":93115,"avatar_url":"https://avatars.githubusercontent.com/u/93115?v=3","gravatar_id":"","url":"https://api.github.com/users/PierreR","html_url":"https://github.com/PierreR","followers_url":"https://api.github.com/users/PierreR/followers","following_url":"https://api.github.com/users/PierreR/following{/other_user}","gists_url":"https://api.github.com/users/PierreR/gists{/gist_id}","starred_url":"https://api.github.com/users/PierreR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PierreR/subscriptions","organizations_url":"https://api.github.com/users/PierreR/orgs","repos_url":"https://api.github.com/users/PierreR/repos","events_url":"https://api.github.com/users/PierreR/events{/privacy}","received_events_url":"https://api.github.com/users/PierreR/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/PierreR/puppetlabs-java","description":"Puppet Module to manage Java","fork":true,"url":"https://api.github.com/repos/PierreR/puppetlabs-java","forks_url":"https://api.github.com/repos/PierreR/puppetlabs-java/forks","keys_url":"https://api.github.com/repos/PierreR/puppetlabs-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PierreR/puppetlabs-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PierreR/puppetlabs-java/teams","hooks_url":"https://api.github.com/repos/PierreR/puppetlabs-java/hooks","issue_events_url":"https://api.github.com/repos/PierreR/puppetlabs-java/issues/events{/number}","events_url":"https://api.github.com/repos/PierreR/puppetlabs-java/events","assignees_url":"https://api.github.com/repos/PierreR/puppetlabs-java/assignees{/user}","branches_url":"https://api.github.com/repos/PierreR/puppetlabs-java/branches{/branch}","tags_url":"https://api.github.com/repos/PierreR/puppetlabs-java/tags","blobs_url":"https://api.github.com/repos/PierreR/puppetlabs-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PierreR/puppetlabs-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PierreR/puppetlabs-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/PierreR/puppetlabs-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PierreR/puppetlabs-java/statuses/{sha}","languages_url":"https://api.github.com/repos/PierreR/puppetlabs-java/languages","stargazers_url":"https://api.github.com/repos/PierreR/puppetlabs-java/stargazers","contributors_url":"https://api.github.com/repos/PierreR/puppetlabs-java/contributors","subscribers_url":"https://api.github.com/repos/PierreR/puppetlabs-java/subscribers","subscription_url":"https://api.github.com/repos/PierreR/puppetlabs-java/subscription","commits_url":"https://api.github.com/repos/PierreR/puppetlabs-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/PierreR/puppetlabs-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/PierreR/puppetlabs-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/PierreR/puppetlabs-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/PierreR/puppetlabs-java/contents/{+path}","compare_url":"https://api.github.com/repos/PierreR/puppetlabs-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PierreR/puppetlabs-java/merges","archive_url":"https://api.github.com/repos/PierreR/puppetlabs-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PierreR/puppetlabs-java/downloads","issues_url":"https://api.github.com/repos/PierreR/puppetlabs-java/issues{/number}","pulls_url":"https://api.github.com/repos/PierreR/puppetlabs-java/pulls{/number}","milestones_url":"https://api.github.com/repos/PierreR/puppetlabs-java/milestones{/number}","notifications_url":"https://api.github.com/repos/PierreR/puppetlabs-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PierreR/puppetlabs-java/labels{/name}","releases_url":"https://api.github.com/repos/PierreR/puppetlabs-java/releases{/id}","created_at":"2014-09-01T11:47:06Z","updated_at":"2015-02-24T14:47:35Z","pushed_at":"2015-02-24T14:47:35Z","git_url":"git://github.com/PierreR/puppetlabs-java.git","ssh_url":"git@github.com:PierreR/puppetlabs-java.git","clone_url":"https://github.com/PierreR/puppetlabs-java.git","svn_url":"https://github.com/PierreR/puppetlabs-java","homepage":"https://forge.puppetlabs.com/puppetlabs/java","size":255,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"9861651c026c2d42cd076582d7f41d4afd894613","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":1795089,"name":"puppetlabs-java","full_name":"puppetlabs/puppetlabs-java","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/puppetlabs-java","description":"Puppet Module to manage Java","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppetlabs-java","forks_url":"https://api.github.com/repos/puppetlabs/puppetlabs-java/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppetlabs-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppetlabs-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppetlabs-java/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppetlabs-java/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppetlabs-java/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppetlabs-java/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppetlabs-java/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppetlabs-java/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppetlabs-java/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppetlabs-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppetlabs-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppetlabs-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppetlabs-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppetlabs-java/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppetlabs-java/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppetlabs-java/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppetlabs-java/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppetlabs-java/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppetlabs-java/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppetlabs-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppetlabs-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppetlabs-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/puppetlabs-java/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppetlabs-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppetlabs-java/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppetlabs-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppetlabs-java/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppetlabs-java/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppetlabs-java/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppetlabs-java/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppetlabs-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppetlabs-java/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppetlabs-java/releases{/id}","created_at":"2011-05-24T18:58:57Z","updated_at":"2015-02-26T10:36:35Z","pushed_at":"2015-02-26T10:36:35Z","git_url":"git://github.com/puppetlabs/puppetlabs-java.git","ssh_url":"git@github.com:puppetlabs/puppetlabs-java.git","clone_url":"https://github.com/puppetlabs/puppetlabs-java.git","svn_url":"https://github.com/puppetlabs/puppetlabs-java","homepage":"https://forge.puppetlabs.com/puppetlabs/java","size":1065,"stargazers_count":73,"watchers_count":73,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":120,"mirror_url":null,"open_issues_count":9,"forks":120,"open_issues":9,"watchers":73,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-java/pulls/111"},"html":{"href":"https://github.com/puppetlabs/puppetlabs-java/pull/111"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-java/issues/111"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-java/issues/111/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-java/pulls/111/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-java/pulls/111/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-java/statuses/912d67492e13f4c0eda79b0adf4b29b302a9cdfc"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":4,"review_comments":4,"commits":1,"additions":9,"deletions":3,"changed_files":1}}