{"action":"created","comment":{"url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments/33338933","id":33338933,"diff_hunk":"@@ -130,15 +132,15 @@ public boolean addAll(int index, Collection<? extends E> c) {\n \n     @Override\n     public List<E> subList(int fromIndex, int toIndex) {\n-        final ListSubOperation operation = new ListSubOperation(name, fromIndex, toIndex);\n-        final SerializableCollection result = invoke(operation);\n-        final Collection<Data> collection = result.getCollection();\n-        final List<E> list = new ArrayList<E>(collection.size());\n+        ListSubOperation operation = new ListSubOperation(name, fromIndex, toIndex);\n+        SerializableCollection result = invoke(operation);\n+        Collection<Data> collection = result.getCollection();","path":"hazelcast/src/main/java/com/hazelcast/collection/impl/list/ListProxyImpl.java","position":21,"original_position":21,"commit_id":"d88b026fba2bf927bfa884633e68eb8fa9cacab8","original_commit_id":"d88b026fba2bf927bfa884633e68eb8fa9cacab8","user":{"login":"pveentjer","id":105243,"avatar_url":"https://avatars.githubusercontent.com/u/105243?v=3","gravatar_id":"","url":"https://api.github.com/users/pveentjer","html_url":"https://github.com/pveentjer","followers_url":"https://api.github.com/users/pveentjer/followers","following_url":"https://api.github.com/users/pveentjer/following{/other_user}","gists_url":"https://api.github.com/users/pveentjer/gists{/gist_id}","starred_url":"https://api.github.com/users/pveentjer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pveentjer/subscriptions","organizations_url":"https://api.github.com/users/pveentjer/orgs","repos_url":"https://api.github.com/users/pveentjer/repos","events_url":"https://api.github.com/users/pveentjer/events{/privacy}","received_events_url":"https://api.github.com/users/pveentjer/received_events","type":"User","site_admin":false},"body":"Isn't this a bit wastful? For you get back a collection, then you copied it into an ArrayList.\r\n\r\nThis generates a lot of waste.\r\n","created_at":"2015-06-26T08:54:34Z","updated_at":"2015-06-26T08:54:34Z","html_url":"https://github.com/hazelcast/hazelcast/pull/5599#discussion_r33338933","pull_request_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/5599","_links":{"self":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments/33338933"},"html":{"href":"https://github.com/hazelcast/hazelcast/pull/5599#discussion_r33338933"},"pull_request":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/5599"}}},"pull_request":{"url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/5599","id":38626546,"html_url":"https://github.com/hazelcast/hazelcast/pull/5599","diff_url":"https://github.com/hazelcast/hazelcast/pull/5599.diff","patch_url":"https://github.com/hazelcast/hazelcast/pull/5599.patch","issue_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/5599","number":5599,"state":"open","locked":false,"title":"subList method now returns an unmodifiable list","user":{"login":"gurbuzali","id":1741680,"avatar_url":"https://avatars.githubusercontent.com/u/1741680?v=3","gravatar_id":"","url":"https://api.github.com/users/gurbuzali","html_url":"https://github.com/gurbuzali","followers_url":"https://api.github.com/users/gurbuzali/followers","following_url":"https://api.github.com/users/gurbuzali/following{/other_user}","gists_url":"https://api.github.com/users/gurbuzali/gists{/gist_id}","starred_url":"https://api.github.com/users/gurbuzali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gurbuzali/subscriptions","organizations_url":"https://api.github.com/users/gurbuzali/orgs","repos_url":"https://api.github.com/users/gurbuzali/repos","events_url":"https://api.github.com/users/gurbuzali/events{/privacy}","received_events_url":"https://api.github.com/users/gurbuzali/received_events","type":"User","site_admin":false},"body":"fixes #5508 ","created_at":"2015-06-26T08:16:51Z","updated_at":"2015-06-26T08:54:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"01df63510c96f63d69948628fe2d1bf611f1340a","assignee":null,"milestone":{"url":"https://api.github.com/repos/hazelcast/hazelcast/milestones/64","html_url":"https://github.com/hazelcast/hazelcast/milestones/3.5.1","labels_url":"https://api.github.com/repos/hazelcast/hazelcast/milestones/64/labels","id":1066688,"number":64,"title":"3.5.1","description":null,"creator":{"login":"alparslanavci","id":7557235,"avatar_url":"https://avatars.githubusercontent.com/u/7557235?v=3","gravatar_id":"","url":"https://api.github.com/users/alparslanavci","html_url":"https://github.com/alparslanavci","followers_url":"https://api.github.com/users/alparslanavci/followers","following_url":"https://api.github.com/users/alparslanavci/following{/other_user}","gists_url":"https://api.github.com/users/alparslanavci/gists{/gist_id}","starred_url":"https://api.github.com/users/alparslanavci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alparslanavci/subscriptions","organizations_url":"https://api.github.com/users/alparslanavci/orgs","repos_url":"https://api.github.com/users/alparslanavci/repos","events_url":"https://api.github.com/users/alparslanavci/events{/privacy}","received_events_url":"https://api.github.com/users/alparslanavci/received_events","type":"User","site_admin":false},"open_issues":41,"closed_issues":22,"state":"open","created_at":"2015-04-14T11:16:23Z","updated_at":"2015-06-26T08:16:51Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/5599/commits","review_comments_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/5599/comments","review_comment_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/5599/comments","statuses_url":"https://api.github.com/repos/hazelcast/hazelcast/statuses/d88b026fba2bf927bfa884633e68eb8fa9cacab8","head":{"label":"gurbuzali:list-iterator-remove","ref":"list-iterator-remove","sha":"d88b026fba2bf927bfa884633e68eb8fa9cacab8","user":{"login":"gurbuzali","id":1741680,"avatar_url":"https://avatars.githubusercontent.com/u/1741680?v=3","gravatar_id":"","url":"https://api.github.com/users/gurbuzali","html_url":"https://github.com/gurbuzali","followers_url":"https://api.github.com/users/gurbuzali/followers","following_url":"https://api.github.com/users/gurbuzali/following{/other_user}","gists_url":"https://api.github.com/users/gurbuzali/gists{/gist_id}","starred_url":"https://api.github.com/users/gurbuzali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gurbuzali/subscriptions","organizations_url":"https://api.github.com/users/gurbuzali/orgs","repos_url":"https://api.github.com/users/gurbuzali/repos","events_url":"https://api.github.com/users/gurbuzali/events{/privacy}","received_events_url":"https://api.github.com/users/gurbuzali/received_events","type":"User","site_admin":false},"repo":{"id":12157261,"name":"hazelcast","full_name":"gurbuzali/hazelcast","owner":{"login":"gurbuzali","id":1741680,"avatar_url":"https://avatars.githubusercontent.com/u/1741680?v=3","gravatar_id":"","url":"https://api.github.com/users/gurbuzali","html_url":"https://github.com/gurbuzali","followers_url":"https://api.github.com/users/gurbuzali/followers","following_url":"https://api.github.com/users/gurbuzali/following{/other_user}","gists_url":"https://api.github.com/users/gurbuzali/gists{/gist_id}","starred_url":"https://api.github.com/users/gurbuzali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gurbuzali/subscriptions","organizations_url":"https://api.github.com/users/gurbuzali/orgs","repos_url":"https://api.github.com/users/gurbuzali/repos","events_url":"https://api.github.com/users/gurbuzali/events{/privacy}","received_events_url":"https://api.github.com/users/gurbuzali/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gurbuzali/hazelcast","description":"Open Source In-Memory Data Grid","fork":true,"url":"https://api.github.com/repos/gurbuzali/hazelcast","forks_url":"https://api.github.com/repos/gurbuzali/hazelcast/forks","keys_url":"https://api.github.com/repos/gurbuzali/hazelcast/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gurbuzali/hazelcast/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gurbuzali/hazelcast/teams","hooks_url":"https://api.github.com/repos/gurbuzali/hazelcast/hooks","issue_events_url":"https://api.github.com/repos/gurbuzali/hazelcast/issues/events{/number}","events_url":"https://api.github.com/repos/gurbuzali/hazelcast/events","assignees_url":"https://api.github.com/repos/gurbuzali/hazelcast/assignees{/user}","branches_url":"https://api.github.com/repos/gurbuzali/hazelcast/branches{/branch}","tags_url":"https://api.github.com/repos/gurbuzali/hazelcast/tags","blobs_url":"https://api.github.com/repos/gurbuzali/hazelcast/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gurbuzali/hazelcast/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gurbuzali/hazelcast/git/refs{/sha}","trees_url":"https://api.github.com/repos/gurbuzali/hazelcast/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gurbuzali/hazelcast/statuses/{sha}","languages_url":"https://api.github.com/repos/gurbuzali/hazelcast/languages","stargazers_url":"https://api.github.com/repos/gurbuzali/hazelcast/stargazers","contributors_url":"https://api.github.com/repos/gurbuzali/hazelcast/contributors","subscribers_url":"https://api.github.com/repos/gurbuzali/hazelcast/subscribers","subscription_url":"https://api.github.com/repos/gurbuzali/hazelcast/subscription","commits_url":"https://api.github.com/repos/gurbuzali/hazelcast/commits{/sha}","git_commits_url":"https://api.github.com/repos/gurbuzali/hazelcast/git/commits{/sha}","comments_url":"https://api.github.com/repos/gurbuzali/hazelcast/comments{/number}","issue_comment_url":"https://api.github.com/repos/gurbuzali/hazelcast/issues/comments{/number}","contents_url":"https://api.github.com/repos/gurbuzali/hazelcast/contents/{+path}","compare_url":"https://api.github.com/repos/gurbuzali/hazelcast/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gurbuzali/hazelcast/merges","archive_url":"https://api.github.com/repos/gurbuzali/hazelcast/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gurbuzali/hazelcast/downloads","issues_url":"https://api.github.com/repos/gurbuzali/hazelcast/issues{/number}","pulls_url":"https://api.github.com/repos/gurbuzali/hazelcast/pulls{/number}","milestones_url":"https://api.github.com/repos/gurbuzali/hazelcast/milestones{/number}","notifications_url":"https://api.github.com/repos/gurbuzali/hazelcast/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gurbuzali/hazelcast/labels{/name}","releases_url":"https://api.github.com/repos/gurbuzali/hazelcast/releases{/id}","created_at":"2013-08-16T11:27:45Z","updated_at":"2015-05-22T07:27:36Z","pushed_at":"2015-06-26T08:15:50Z","git_url":"git://github.com/gurbuzali/hazelcast.git","ssh_url":"git@github.com:gurbuzali/hazelcast.git","clone_url":"https://github.com/gurbuzali/hazelcast.git","svn_url":"https://github.com/gurbuzali/hazelcast","homepage":"www.hazelcast.com","size":71244,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hazelcast:maintenance-3.x","ref":"maintenance-3.x","sha":"5f5c8e78a2658b73c79f55d2127d23f2e6caf03c","user":{"login":"hazelcast","id":1453152,"avatar_url":"https://avatars.githubusercontent.com/u/1453152?v=3","gravatar_id":"","url":"https://api.github.com/users/hazelcast","html_url":"https://github.com/hazelcast","followers_url":"https://api.github.com/users/hazelcast/followers","following_url":"https://api.github.com/users/hazelcast/following{/other_user}","gists_url":"https://api.github.com/users/hazelcast/gists{/gist_id}","starred_url":"https://api.github.com/users/hazelcast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hazelcast/subscriptions","organizations_url":"https://api.github.com/users/hazelcast/orgs","repos_url":"https://api.github.com/users/hazelcast/repos","events_url":"https://api.github.com/users/hazelcast/events{/privacy}","received_events_url":"https://api.github.com/users/hazelcast/received_events","type":"Organization","site_admin":false},"repo":{"id":3786237,"name":"hazelcast","full_name":"hazelcast/hazelcast","owner":{"login":"hazelcast","id":1453152,"avatar_url":"https://avatars.githubusercontent.com/u/1453152?v=3","gravatar_id":"","url":"https://api.github.com/users/hazelcast","html_url":"https://github.com/hazelcast","followers_url":"https://api.github.com/users/hazelcast/followers","following_url":"https://api.github.com/users/hazelcast/following{/other_user}","gists_url":"https://api.github.com/users/hazelcast/gists{/gist_id}","starred_url":"https://api.github.com/users/hazelcast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hazelcast/subscriptions","organizations_url":"https://api.github.com/users/hazelcast/orgs","repos_url":"https://api.github.com/users/hazelcast/repos","events_url":"https://api.github.com/users/hazelcast/events{/privacy}","received_events_url":"https://api.github.com/users/hazelcast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hazelcast/hazelcast","description":"Open Source In-Memory Data Grid","fork":false,"url":"https://api.github.com/repos/hazelcast/hazelcast","forks_url":"https://api.github.com/repos/hazelcast/hazelcast/forks","keys_url":"https://api.github.com/repos/hazelcast/hazelcast/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hazelcast/hazelcast/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hazelcast/hazelcast/teams","hooks_url":"https://api.github.com/repos/hazelcast/hazelcast/hooks","issue_events_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/events{/number}","events_url":"https://api.github.com/repos/hazelcast/hazelcast/events","assignees_url":"https://api.github.com/repos/hazelcast/hazelcast/assignees{/user}","branches_url":"https://api.github.com/repos/hazelcast/hazelcast/branches{/branch}","tags_url":"https://api.github.com/repos/hazelcast/hazelcast/tags","blobs_url":"https://api.github.com/repos/hazelcast/hazelcast/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hazelcast/hazelcast/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hazelcast/hazelcast/git/refs{/sha}","trees_url":"https://api.github.com/repos/hazelcast/hazelcast/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hazelcast/hazelcast/statuses/{sha}","languages_url":"https://api.github.com/repos/hazelcast/hazelcast/languages","stargazers_url":"https://api.github.com/repos/hazelcast/hazelcast/stargazers","contributors_url":"https://api.github.com/repos/hazelcast/hazelcast/contributors","subscribers_url":"https://api.github.com/repos/hazelcast/hazelcast/subscribers","subscription_url":"https://api.github.com/repos/hazelcast/hazelcast/subscription","commits_url":"https://api.github.com/repos/hazelcast/hazelcast/commits{/sha}","git_commits_url":"https://api.github.com/repos/hazelcast/hazelcast/git/commits{/sha}","comments_url":"https://api.github.com/repos/hazelcast/hazelcast/comments{/number}","issue_comment_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/comments{/number}","contents_url":"https://api.github.com/repos/hazelcast/hazelcast/contents/{+path}","compare_url":"https://api.github.com/repos/hazelcast/hazelcast/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hazelcast/hazelcast/merges","archive_url":"https://api.github.com/repos/hazelcast/hazelcast/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hazelcast/hazelcast/downloads","issues_url":"https://api.github.com/repos/hazelcast/hazelcast/issues{/number}","pulls_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls{/number}","milestones_url":"https://api.github.com/repos/hazelcast/hazelcast/milestones{/number}","notifications_url":"https://api.github.com/repos/hazelcast/hazelcast/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hazelcast/hazelcast/labels{/name}","releases_url":"https://api.github.com/repos/hazelcast/hazelcast/releases{/id}","created_at":"2012-03-21T12:25:18Z","updated_at":"2015-06-26T06:30:47Z","pushed_at":"2015-06-26T08:52:30Z","git_url":"git://github.com/hazelcast/hazelcast.git","ssh_url":"git@github.com:hazelcast/hazelcast.git","clone_url":"https://github.com/hazelcast/hazelcast.git","svn_url":"https://github.com/hazelcast/hazelcast","homepage":"www.hazelcast.com","size":141818,"stargazers_count":1162,"watchers_count":1162,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":561,"mirror_url":null,"open_issues_count":454,"forks":561,"open_issues":454,"watchers":1162,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/5599"},"html":{"href":"https://github.com/hazelcast/hazelcast/pull/5599"},"issue":{"href":"https://api.github.com/repos/hazelcast/hazelcast/issues/5599"},"comments":{"href":"https://api.github.com/repos/hazelcast/hazelcast/issues/5599/comments"},"review_comments":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/5599/comments"},"review_comment":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/5599/commits"},"statuses":{"href":"https://api.github.com/repos/hazelcast/hazelcast/statuses/d88b026fba2bf927bfa884633e68eb8fa9cacab8"}}}}