{"action":"created","issue":{"url":"https://api.github.com/repos/music-encoding/music-encoding/issues/261","labels_url":"https://api.github.com/repos/music-encoding/music-encoding/issues/261/labels{/name}","comments_url":"https://api.github.com/repos/music-encoding/music-encoding/issues/261/comments","events_url":"https://api.github.com/repos/music-encoding/music-encoding/issues/261/events","html_url":"https://github.com/music-encoding/music-encoding/pull/261","id":108570897,"number":261,"title":"Fixed: Allow @visible on <accid>","user":{"login":"ahankinson","id":163183,"avatar_url":"https://avatars.githubusercontent.com/u/163183?v=3","gravatar_id":"","url":"https://api.github.com/users/ahankinson","html_url":"https://github.com/ahankinson","followers_url":"https://api.github.com/users/ahankinson/followers","following_url":"https://api.github.com/users/ahankinson/following{/other_user}","gists_url":"https://api.github.com/users/ahankinson/gists{/gist_id}","starred_url":"https://api.github.com/users/ahankinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahankinson/subscriptions","organizations_url":"https://api.github.com/users/ahankinson/orgs","repos_url":"https://api.github.com/users/ahankinson/repos","events_url":"https://api.github.com/users/ahankinson/events{/privacy}","received_events_url":"https://api.github.com/users/ahankinson/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/music-encoding/music-encoding/labels/Component:%20Core%20Schema","name":"Component: Core Schema","color":"c7def8"},{"url":"https://api.github.com/repos/music-encoding/music-encoding/labels/Priority:%20Medium","name":"Priority: Medium","color":"fbca04"},{"url":"https://api.github.com/repos/music-encoding/music-encoding/labels/Status:%20Needs%20Discussion","name":"Status: Needs Discussion","color":"fad8c7"},{"url":"https://api.github.com/repos/music-encoding/music-encoding/labels/Type:%20Enhancement","name":"Type: Enhancement","color":"0052cc"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":56,"created_at":"2015-09-28T00:43:39Z","updated_at":"2015-10-01T16:02:22Z","closed_at":"2015-09-29T18:00:47Z","pull_request":{"url":"https://api.github.com/repos/music-encoding/music-encoding/pulls/261","html_url":"https://github.com/music-encoding/music-encoding/pull/261","diff_url":"https://github.com/music-encoding/music-encoding/pull/261.diff","patch_url":"https://github.com/music-encoding/music-encoding/pull/261.patch"},"body":"This commit adds the @visible parameter to `<accid>`, providing a way to record an accidental that is present, but hidden. Note that this is not to be confused with the function of cautionary accidentals (i.e., accidentals that would normally be shown but for the convention that they were already shown in the bar.\r\n\r\nAlso included in this commit is a test case to check that `<accid>` takes @visible.\r\n\r\nNote that this pull request is based on the latest from the `develop-perry` branch and, if accepted, should be merged into this branch before being merged into `develop.`"},"comment":{"url":"https://api.github.com/repos/music-encoding/music-encoding/issues/comments/144772518","html_url":"https://github.com/music-encoding/music-encoding/pull/261#issuecomment-144772518","issue_url":"https://api.github.com/repos/music-encoding/music-encoding/issues/261","id":144772518,"user":{"login":"lpugin","id":689412,"avatar_url":"https://avatars.githubusercontent.com/u/689412?v=3","gravatar_id":"","url":"https://api.github.com/users/lpugin","html_url":"https://github.com/lpugin","followers_url":"https://api.github.com/users/lpugin/followers","following_url":"https://api.github.com/users/lpugin/following{/other_user}","gists_url":"https://api.github.com/users/lpugin/gists{/gist_id}","starred_url":"https://api.github.com/users/lpugin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lpugin/subscriptions","organizations_url":"https://api.github.com/users/lpugin/orgs","repos_url":"https://api.github.com/users/lpugin/repos","events_url":"https://api.github.com/users/lpugin/events{/privacy}","received_events_url":"https://api.github.com/users/lpugin/received_events","type":"User","site_admin":false},"created_at":"2015-10-01T16:02:22Z","updated_at":"2015-10-01T16:02:22Z","body":"If in the end you expect readers to use the value of accid when accid.ges is not provided, then this is indeed the prima pratica and what is currently recommended by MEI. Now if we start to have some MEI data sets where we have accid.ges on every note (including when duplicating accid) it probably means that we are going to see projects and tools relying on accid.ges only for generating sound. And these tools will inadequately play files that from the prima pratica (if not I do not see the goal of the seconda practica). And I don't think this would be a good situation. So I am not against the seconda pratica, but we should either have a way to indicate if accid.ges is provided at all, and if yes how it should be interpreted (prima or seconda pratica). Alternatively, we can switch to the seconda practica, but this needs to be a clear change with an update of the guidelines and of all our encoding examples."}}