{"action":"created","issue":{"url":"https://api.github.com/repos/swaroopch/edn_format/issues/27","labels_url":"https://api.github.com/repos/swaroopch/edn_format/issues/27/labels{/name}","comments_url":"https://api.github.com/repos/swaroopch/edn_format/issues/27/comments","events_url":"https://api.github.com/repos/swaroopch/edn_format/issues/27/events","html_url":"https://github.com/swaroopch/edn_format/pull/27","id":79097220,"number":27,"title":"Several fixes","user":{"login":"exilef","id":2277243,"avatar_url":"https://avatars.githubusercontent.com/u/2277243?v=3","gravatar_id":"","url":"https://api.github.com/users/exilef","html_url":"https://github.com/exilef","followers_url":"https://api.github.com/users/exilef/followers","following_url":"https://api.github.com/users/exilef/following{/other_user}","gists_url":"https://api.github.com/users/exilef/gists{/gist_id}","starred_url":"https://api.github.com/users/exilef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exilef/subscriptions","organizations_url":"https://api.github.com/users/exilef/orgs","repos_url":"https://api.github.com/users/exilef/repos","events_url":"https://api.github.com/users/exilef/events{/privacy}","received_events_url":"https://api.github.com/users/exilef/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-05-21T17:45:39Z","updated_at":"2015-05-25T19:25:33Z","closed_at":"2015-05-25T19:16:44Z","pull_request":{"url":"https://api.github.com/repos/swaroopch/edn_format/pulls/27","html_url":"https://github.com/swaroopch/edn_format/pull/27","diff_url":"https://github.com/swaroopch/edn_format/pull/27.diff","patch_url":"https://github.com/swaroopch/edn_format/pull/27.patch"},"body":"Fixes #26 and makes package unicode-aware\r\n\r\n* Fixed string parsing and escaping\r\n* Unicode now consistently used internally\r\n* New method dumpu added that returns unicode\r\n* dumps method now takes optional encoding arguments,\r\n  output_encoding (specifies encoding of output string) and\r\n  string_encoding (specifies encoding of non-unicode strings\r\n  in object to be serialized), both default to 'utf-8'\r\n* loads now takes optional argument input_encoding, defaults\r\n  to 'utf-8'\r\n* New method loadu added that assumes unicode input\r\n* Tests updated"},"comment":{"url":"https://api.github.com/repos/swaroopch/edn_format/issues/comments/105293173","html_url":"https://github.com/swaroopch/edn_format/pull/27#issuecomment-105293173","issue_url":"https://api.github.com/repos/swaroopch/edn_format/issues/27","id":105293173,"user":{"login":"petrounias","id":107629,"avatar_url":"https://avatars.githubusercontent.com/u/107629?v=3","gravatar_id":"","url":"https://api.github.com/users/petrounias","html_url":"https://github.com/petrounias","followers_url":"https://api.github.com/users/petrounias/followers","following_url":"https://api.github.com/users/petrounias/following{/other_user}","gists_url":"https://api.github.com/users/petrounias/gists{/gist_id}","starred_url":"https://api.github.com/users/petrounias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petrounias/subscriptions","organizations_url":"https://api.github.com/users/petrounias/orgs","repos_url":"https://api.github.com/users/petrounias/repos","events_url":"https://api.github.com/users/petrounias/events{/privacy}","received_events_url":"https://api.github.com/users/petrounias/received_events","type":"User","site_admin":false},"created_at":"2015-05-25T19:25:33Z","updated_at":"2015-05-25T19:25:33Z","body":"@swaroopch it would be safe to expect that almost all edn encoding and decoding will be in unicode (most likely for interacting with Clojure services), so we probably don't need both dump and dumpu and corresponding parsers. The default case can be unicode, and the user can encode as a special case outside this library."}}