{"action":"created","comment":{"url":"https://api.github.com/repos/skidding/dragdealer/pulls/comments/30946930","id":30946930,"diff_hunk":"@@ -74,5 +88,12 @@ module.exports = function(grunt) {\n   }\n \n   grunt.registerTask(\"dev\", [\"connect\", \"watch\"]);\n-  grunt.registerTask(\"test\", [\"connect\", \"saucelabs-custom\"]);\n+  grunt.registerTask(\"test-locally\", [\"connect\", \"jasmine\"]);","path":"Gruntfile.js","position":26,"original_position":26,"commit_id":"464713e3bab60524c0603ee4a08fc5629fd5b085","original_commit_id":"464713e3bab60524c0603ee4a08fc5629fd5b085","user":{"login":"skidding","id":250750,"avatar_url":"https://avatars.githubusercontent.com/u/250750?v=3","gravatar_id":"","url":"https://api.github.com/users/skidding","html_url":"https://github.com/skidding","followers_url":"https://api.github.com/users/skidding/followers","following_url":"https://api.github.com/users/skidding/following{/other_user}","gists_url":"https://api.github.com/users/skidding/gists{/gist_id}","starred_url":"https://api.github.com/users/skidding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skidding/subscriptions","organizations_url":"https://api.github.com/users/skidding/orgs","repos_url":"https://api.github.com/users/skidding/repos","events_url":"https://api.github.com/users/skidding/events{/privacy}","received_events_url":"https://api.github.com/users/skidding/received_events","type":"User","site_admin":false},"body":"It's a bit odd that you have a separate task for testing locally, but not for saucelabs as well. I would restructure the tasks as follows:\r\n\r\n```js\r\ngrunt.registerTask(\"test-phantomjs\", [\"connect\", \"jasmine\"]);\r\ngrunt.registerTask(\"test-saucelabs\", [\"connect\", \"saucelabs-custom\"]);\r\n```\r\n\r\nAnd then just have the `if` below register `\"test\"` for either `\"test-phantomjs\"` or `\"test-saucelabs\"`","created_at":"2015-05-23T18:19:29Z","updated_at":"2015-05-23T18:19:29Z","html_url":"https://github.com/skidding/dragdealer/pull/86#discussion_r30946930","pull_request_url":"https://api.github.com/repos/skidding/dragdealer/pulls/86","_links":{"self":{"href":"https://api.github.com/repos/skidding/dragdealer/pulls/comments/30946930"},"html":{"href":"https://github.com/skidding/dragdealer/pull/86#discussion_r30946930"},"pull_request":{"href":"https://api.github.com/repos/skidding/dragdealer/pulls/86"}}},"pull_request":{"url":"https://api.github.com/repos/skidding/dragdealer/pulls/86","id":35673189,"html_url":"https://github.com/skidding/dragdealer/pull/86","diff_url":"https://github.com/skidding/dragdealer/pull/86.diff","patch_url":"https://github.com/skidding/dragdealer/pull/86.patch","issue_url":"https://api.github.com/repos/skidding/dragdealer/issues/86","number":86,"state":"open","locked":false,"title":"Tests without sauce labs on pull requests","user":{"login":"flosell","id":540525,"avatar_url":"https://avatars.githubusercontent.com/u/540525?v=3","gravatar_id":"","url":"https://api.github.com/users/flosell","html_url":"https://github.com/flosell","followers_url":"https://api.github.com/users/flosell/followers","following_url":"https://api.github.com/users/flosell/following{/other_user}","gists_url":"https://api.github.com/users/flosell/gists{/gist_id}","starred_url":"https://api.github.com/users/flosell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flosell/subscriptions","organizations_url":"https://api.github.com/users/flosell/orgs","repos_url":"https://api.github.com/users/flosell/repos","events_url":"https://api.github.com/users/flosell/events{/privacy}","received_events_url":"https://api.github.com/users/flosell/received_events","type":"User","site_admin":false},"body":"Adds a way to run tests headless without Sauce Labs (`grunt test-locally`) and \r\nuse this method to run tests in situations where travis can't use Sauce Labs (e.g. in pull requests: http://docs.travis-ci.com/user/pull-requests/#Security-Restrictions-when-testing-Pull-Requests).\r\n\r\nPhantomJS is used to run the tests without SauceLabs, leading to one failing test (\"should translate handle position after window resize\"). This test is now skipped in these situations (`exceptInPhantomJsIt`) until we find a way to fix it. ","created_at":"2015-05-18T21:02:11Z","updated_at":"2015-05-23T18:19:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e961a1c91402eb3bac589aaf851a36b4f62831ca","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/skidding/dragdealer/pulls/86/commits","review_comments_url":"https://api.github.com/repos/skidding/dragdealer/pulls/86/comments","review_comment_url":"https://api.github.com/repos/skidding/dragdealer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/skidding/dragdealer/issues/86/comments","statuses_url":"https://api.github.com/repos/skidding/dragdealer/statuses/464713e3bab60524c0603ee4a08fc5629fd5b085","head":{"label":"flosell:tests-without-sauce-labs-on-pull-requests","ref":"tests-without-sauce-labs-on-pull-requests","sha":"464713e3bab60524c0603ee4a08fc5629fd5b085","user":{"login":"flosell","id":540525,"avatar_url":"https://avatars.githubusercontent.com/u/540525?v=3","gravatar_id":"","url":"https://api.github.com/users/flosell","html_url":"https://github.com/flosell","followers_url":"https://api.github.com/users/flosell/followers","following_url":"https://api.github.com/users/flosell/following{/other_user}","gists_url":"https://api.github.com/users/flosell/gists{/gist_id}","starred_url":"https://api.github.com/users/flosell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flosell/subscriptions","organizations_url":"https://api.github.com/users/flosell/orgs","repos_url":"https://api.github.com/users/flosell/repos","events_url":"https://api.github.com/users/flosell/events{/privacy}","received_events_url":"https://api.github.com/users/flosell/received_events","type":"User","site_admin":false},"repo":{"id":28089615,"name":"dragdealer","full_name":"flosell/dragdealer","owner":{"login":"flosell","id":540525,"avatar_url":"https://avatars.githubusercontent.com/u/540525?v=3","gravatar_id":"","url":"https://api.github.com/users/flosell","html_url":"https://github.com/flosell","followers_url":"https://api.github.com/users/flosell/followers","following_url":"https://api.github.com/users/flosell/following{/other_user}","gists_url":"https://api.github.com/users/flosell/gists{/gist_id}","starred_url":"https://api.github.com/users/flosell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flosell/subscriptions","organizations_url":"https://api.github.com/users/flosell/orgs","repos_url":"https://api.github.com/users/flosell/repos","events_url":"https://api.github.com/users/flosell/events{/privacy}","received_events_url":"https://api.github.com/users/flosell/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/flosell/dragdealer","description":"Drag-based JavaScript component, embracing endless UI solutions","fork":true,"url":"https://api.github.com/repos/flosell/dragdealer","forks_url":"https://api.github.com/repos/flosell/dragdealer/forks","keys_url":"https://api.github.com/repos/flosell/dragdealer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flosell/dragdealer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flosell/dragdealer/teams","hooks_url":"https://api.github.com/repos/flosell/dragdealer/hooks","issue_events_url":"https://api.github.com/repos/flosell/dragdealer/issues/events{/number}","events_url":"https://api.github.com/repos/flosell/dragdealer/events","assignees_url":"https://api.github.com/repos/flosell/dragdealer/assignees{/user}","branches_url":"https://api.github.com/repos/flosell/dragdealer/branches{/branch}","tags_url":"https://api.github.com/repos/flosell/dragdealer/tags","blobs_url":"https://api.github.com/repos/flosell/dragdealer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flosell/dragdealer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flosell/dragdealer/git/refs{/sha}","trees_url":"https://api.github.com/repos/flosell/dragdealer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flosell/dragdealer/statuses/{sha}","languages_url":"https://api.github.com/repos/flosell/dragdealer/languages","stargazers_url":"https://api.github.com/repos/flosell/dragdealer/stargazers","contributors_url":"https://api.github.com/repos/flosell/dragdealer/contributors","subscribers_url":"https://api.github.com/repos/flosell/dragdealer/subscribers","subscription_url":"https://api.github.com/repos/flosell/dragdealer/subscription","commits_url":"https://api.github.com/repos/flosell/dragdealer/commits{/sha}","git_commits_url":"https://api.github.com/repos/flosell/dragdealer/git/commits{/sha}","comments_url":"https://api.github.com/repos/flosell/dragdealer/comments{/number}","issue_comment_url":"https://api.github.com/repos/flosell/dragdealer/issues/comments{/number}","contents_url":"https://api.github.com/repos/flosell/dragdealer/contents/{+path}","compare_url":"https://api.github.com/repos/flosell/dragdealer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flosell/dragdealer/merges","archive_url":"https://api.github.com/repos/flosell/dragdealer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flosell/dragdealer/downloads","issues_url":"https://api.github.com/repos/flosell/dragdealer/issues{/number}","pulls_url":"https://api.github.com/repos/flosell/dragdealer/pulls{/number}","milestones_url":"https://api.github.com/repos/flosell/dragdealer/milestones{/number}","notifications_url":"https://api.github.com/repos/flosell/dragdealer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flosell/dragdealer/labels{/name}","releases_url":"https://api.github.com/repos/flosell/dragdealer/releases{/id}","created_at":"2014-12-16T14:06:18Z","updated_at":"2015-02-02T17:39:30Z","pushed_at":"2015-05-18T20:56:28Z","git_url":"git://github.com/flosell/dragdealer.git","ssh_url":"git@github.com:flosell/dragdealer.git","clone_url":"https://github.com/flosell/dragdealer.git","svn_url":"https://github.com/flosell/dragdealer","homepage":"http://skidding.github.io/dragdealer","size":1626,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"skidding:master","ref":"master","sha":"660048252f7d60dd35a50e6c86afeea9d0b82364","user":{"login":"skidding","id":250750,"avatar_url":"https://avatars.githubusercontent.com/u/250750?v=3","gravatar_id":"","url":"https://api.github.com/users/skidding","html_url":"https://github.com/skidding","followers_url":"https://api.github.com/users/skidding/followers","following_url":"https://api.github.com/users/skidding/following{/other_user}","gists_url":"https://api.github.com/users/skidding/gists{/gist_id}","starred_url":"https://api.github.com/users/skidding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skidding/subscriptions","organizations_url":"https://api.github.com/users/skidding/orgs","repos_url":"https://api.github.com/users/skidding/repos","events_url":"https://api.github.com/users/skidding/events{/privacy}","received_events_url":"https://api.github.com/users/skidding/received_events","type":"User","site_admin":false},"repo":{"id":9576493,"name":"dragdealer","full_name":"skidding/dragdealer","owner":{"login":"skidding","id":250750,"avatar_url":"https://avatars.githubusercontent.com/u/250750?v=3","gravatar_id":"","url":"https://api.github.com/users/skidding","html_url":"https://github.com/skidding","followers_url":"https://api.github.com/users/skidding/followers","following_url":"https://api.github.com/users/skidding/following{/other_user}","gists_url":"https://api.github.com/users/skidding/gists{/gist_id}","starred_url":"https://api.github.com/users/skidding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skidding/subscriptions","organizations_url":"https://api.github.com/users/skidding/orgs","repos_url":"https://api.github.com/users/skidding/repos","events_url":"https://api.github.com/users/skidding/events{/privacy}","received_events_url":"https://api.github.com/users/skidding/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/skidding/dragdealer","description":"Drag-based JavaScript component, embracing endless UI solutions","fork":false,"url":"https://api.github.com/repos/skidding/dragdealer","forks_url":"https://api.github.com/repos/skidding/dragdealer/forks","keys_url":"https://api.github.com/repos/skidding/dragdealer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/skidding/dragdealer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/skidding/dragdealer/teams","hooks_url":"https://api.github.com/repos/skidding/dragdealer/hooks","issue_events_url":"https://api.github.com/repos/skidding/dragdealer/issues/events{/number}","events_url":"https://api.github.com/repos/skidding/dragdealer/events","assignees_url":"https://api.github.com/repos/skidding/dragdealer/assignees{/user}","branches_url":"https://api.github.com/repos/skidding/dragdealer/branches{/branch}","tags_url":"https://api.github.com/repos/skidding/dragdealer/tags","blobs_url":"https://api.github.com/repos/skidding/dragdealer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/skidding/dragdealer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/skidding/dragdealer/git/refs{/sha}","trees_url":"https://api.github.com/repos/skidding/dragdealer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/skidding/dragdealer/statuses/{sha}","languages_url":"https://api.github.com/repos/skidding/dragdealer/languages","stargazers_url":"https://api.github.com/repos/skidding/dragdealer/stargazers","contributors_url":"https://api.github.com/repos/skidding/dragdealer/contributors","subscribers_url":"https://api.github.com/repos/skidding/dragdealer/subscribers","subscription_url":"https://api.github.com/repos/skidding/dragdealer/subscription","commits_url":"https://api.github.com/repos/skidding/dragdealer/commits{/sha}","git_commits_url":"https://api.github.com/repos/skidding/dragdealer/git/commits{/sha}","comments_url":"https://api.github.com/repos/skidding/dragdealer/comments{/number}","issue_comment_url":"https://api.github.com/repos/skidding/dragdealer/issues/comments{/number}","contents_url":"https://api.github.com/repos/skidding/dragdealer/contents/{+path}","compare_url":"https://api.github.com/repos/skidding/dragdealer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/skidding/dragdealer/merges","archive_url":"https://api.github.com/repos/skidding/dragdealer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/skidding/dragdealer/downloads","issues_url":"https://api.github.com/repos/skidding/dragdealer/issues{/number}","pulls_url":"https://api.github.com/repos/skidding/dragdealer/pulls{/number}","milestones_url":"https://api.github.com/repos/skidding/dragdealer/milestones{/number}","notifications_url":"https://api.github.com/repos/skidding/dragdealer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/skidding/dragdealer/labels{/name}","releases_url":"https://api.github.com/repos/skidding/dragdealer/releases{/id}","created_at":"2013-04-21T08:02:40Z","updated_at":"2015-05-23T08:12:33Z","pushed_at":"2015-05-18T21:02:11Z","git_url":"git://github.com/skidding/dragdealer.git","ssh_url":"git@github.com:skidding/dragdealer.git","clone_url":"https://github.com/skidding/dragdealer.git","svn_url":"https://github.com/skidding/dragdealer","homepage":"http://skidding.github.io/dragdealer","size":2362,"stargazers_count":479,"watchers_count":479,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":74,"mirror_url":null,"open_issues_count":10,"forks":74,"open_issues":10,"watchers":479,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/skidding/dragdealer/pulls/86"},"html":{"href":"https://github.com/skidding/dragdealer/pull/86"},"issue":{"href":"https://api.github.com/repos/skidding/dragdealer/issues/86"},"comments":{"href":"https://api.github.com/repos/skidding/dragdealer/issues/86/comments"},"review_comments":{"href":"https://api.github.com/repos/skidding/dragdealer/pulls/86/comments"},"review_comment":{"href":"https://api.github.com/repos/skidding/dragdealer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/skidding/dragdealer/pulls/86/commits"},"statuses":{"href":"https://api.github.com/repos/skidding/dragdealer/statuses/464713e3bab60524c0603ee4a08fc5629fd5b085"}}}}