{"action":"created","comment":{"url":"https://api.github.com/repos/HubSpot/Singularity/pulls/comments/22498240","id":22498240,"diff_hunk":"@@ -135,6 +135,10 @@\n \n   private long zookeeperAsyncTimeout = 5000;\n \n+  private int coreThreadpoolSize = 8;","path":"SingularityService/src/main/java/com/hubspot/singularity/config/SingularityConfiguration.java","position":4,"original_position":4,"commit_id":"807ab54f6d80af44cc38fef6e5956f995cf85b11","original_commit_id":"807ab54f6d80af44cc38fef6e5956f995cf85b11","user":{"login":"hgschmie","id":39495,"avatar_url":"https://avatars.githubusercontent.com/u/39495?v=3","gravatar_id":"","url":"https://api.github.com/users/hgschmie","html_url":"https://github.com/hgschmie","followers_url":"https://api.github.com/users/hgschmie/followers","following_url":"https://api.github.com/users/hgschmie/following{/other_user}","gists_url":"https://api.github.com/users/hgschmie/gists{/gist_id}","starred_url":"https://api.github.com/users/hgschmie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hgschmie/subscriptions","organizations_url":"https://api.github.com/users/hgschmie/orgs","repos_url":"https://api.github.com/users/hgschmie/repos","events_url":"https://api.github.com/users/hgschmie/events{/privacy}","received_events_url":"https://api.github.com/users/hgschmie/received_events","type":"User","site_admin":false},"body":"Sharing them allows to factor the thread pool management out of a lot of components which in turn no longer need to be managed (only managed thing was the threadpool shutdown). The \"8\" is a magic number based on the number of thread pools in existence. We have a metric which tracks the number of threads actually used and I may adjust later.","created_at":"2015-01-05T23:30:19Z","updated_at":"2015-01-05T23:30:19Z","html_url":"https://github.com/HubSpot/Singularity/pull/368#discussion_r22498240","pull_request_url":"https://api.github.com/repos/HubSpot/Singularity/pulls/368","_links":{"self":{"href":"https://api.github.com/repos/HubSpot/Singularity/pulls/comments/22498240"},"html":{"href":"https://github.com/HubSpot/Singularity/pull/368#discussion_r22498240"},"pull_request":{"href":"https://api.github.com/repos/HubSpot/Singularity/pulls/368"}}},"pull_request":{"url":"https://api.github.com/repos/HubSpot/Singularity/pulls/368","id":26011275,"html_url":"https://github.com/HubSpot/Singularity/pull/368","diff_url":"https://github.com/HubSpot/Singularity/pull/368.diff","patch_url":"https://github.com/HubSpot/Singularity/pull/368.patch","issue_url":"https://api.github.com/repos/HubSpot/Singularity/issues/368","number":368,"state":"open","locked":false,"title":"Factor out all the little thread pools.","user":{"login":"hgschmie","id":39495,"avatar_url":"https://avatars.githubusercontent.com/u/39495?v=3","gravatar_id":"","url":"https://api.github.com/users/hgschmie","html_url":"https://github.com/hgschmie","followers_url":"https://api.github.com/users/hgschmie/followers","following_url":"https://api.github.com/users/hgschmie/following{/other_user}","gists_url":"https://api.github.com/users/hgschmie/gists{/gist_id}","starred_url":"https://api.github.com/users/hgschmie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hgschmie/subscriptions","organizations_url":"https://api.github.com/users/hgschmie/orgs","repos_url":"https://api.github.com/users/hgschmie/repos","events_url":"https://api.github.com/users/hgschmie/events{/privacy}","received_events_url":"https://api.github.com/users/hgschmie/received_events","type":"User","site_admin":false},"body":"Factor thread pool management and control into guice injected, managed pools.","created_at":"2014-12-12T23:41:58Z","updated_at":"2015-01-05T23:30:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c4a9333437b5540b5e346b083a2d4ac6d00f2101","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/HubSpot/Singularity/pulls/368/commits","review_comments_url":"https://api.github.com/repos/HubSpot/Singularity/pulls/368/comments","review_comment_url":"https://api.github.com/repos/HubSpot/Singularity/pulls/comments/{number}","comments_url":"https://api.github.com/repos/HubSpot/Singularity/issues/368/comments","statuses_url":"https://api.github.com/repos/HubSpot/Singularity/statuses/807ab54f6d80af44cc38fef6e5956f995cf85b11","head":{"label":"hgschmie:thread-pools","ref":"thread-pools","sha":"807ab54f6d80af44cc38fef6e5956f995cf85b11","user":{"login":"hgschmie","id":39495,"avatar_url":"https://avatars.githubusercontent.com/u/39495?v=3","gravatar_id":"","url":"https://api.github.com/users/hgschmie","html_url":"https://github.com/hgschmie","followers_url":"https://api.github.com/users/hgschmie/followers","following_url":"https://api.github.com/users/hgschmie/following{/other_user}","gists_url":"https://api.github.com/users/hgschmie/gists{/gist_id}","starred_url":"https://api.github.com/users/hgschmie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hgschmie/subscriptions","organizations_url":"https://api.github.com/users/hgschmie/orgs","repos_url":"https://api.github.com/users/hgschmie/repos","events_url":"https://api.github.com/users/hgschmie/events{/privacy}","received_events_url":"https://api.github.com/users/hgschmie/received_events","type":"User","site_admin":false},"repo":{"id":21994993,"name":"Singularity","full_name":"hgschmie/Singularity","owner":{"login":"hgschmie","id":39495,"avatar_url":"https://avatars.githubusercontent.com/u/39495?v=3","gravatar_id":"","url":"https://api.github.com/users/hgschmie","html_url":"https://github.com/hgschmie","followers_url":"https://api.github.com/users/hgschmie/followers","following_url":"https://api.github.com/users/hgschmie/following{/other_user}","gists_url":"https://api.github.com/users/hgschmie/gists{/gist_id}","starred_url":"https://api.github.com/users/hgschmie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hgschmie/subscriptions","organizations_url":"https://api.github.com/users/hgschmie/orgs","repos_url":"https://api.github.com/users/hgschmie/repos","events_url":"https://api.github.com/users/hgschmie/events{/privacy}","received_events_url":"https://api.github.com/users/hgschmie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hgschmie/Singularity","description":"Scheduler (HTTP API and webapp) for running mesos tasks—long running processes, one-off tasks, and scheduled jobs. #hubspot-open-source","fork":true,"url":"https://api.github.com/repos/hgschmie/Singularity","forks_url":"https://api.github.com/repos/hgschmie/Singularity/forks","keys_url":"https://api.github.com/repos/hgschmie/Singularity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hgschmie/Singularity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hgschmie/Singularity/teams","hooks_url":"https://api.github.com/repos/hgschmie/Singularity/hooks","issue_events_url":"https://api.github.com/repos/hgschmie/Singularity/issues/events{/number}","events_url":"https://api.github.com/repos/hgschmie/Singularity/events","assignees_url":"https://api.github.com/repos/hgschmie/Singularity/assignees{/user}","branches_url":"https://api.github.com/repos/hgschmie/Singularity/branches{/branch}","tags_url":"https://api.github.com/repos/hgschmie/Singularity/tags","blobs_url":"https://api.github.com/repos/hgschmie/Singularity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hgschmie/Singularity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hgschmie/Singularity/git/refs{/sha}","trees_url":"https://api.github.com/repos/hgschmie/Singularity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hgschmie/Singularity/statuses/{sha}","languages_url":"https://api.github.com/repos/hgschmie/Singularity/languages","stargazers_url":"https://api.github.com/repos/hgschmie/Singularity/stargazers","contributors_url":"https://api.github.com/repos/hgschmie/Singularity/contributors","subscribers_url":"https://api.github.com/repos/hgschmie/Singularity/subscribers","subscription_url":"https://api.github.com/repos/hgschmie/Singularity/subscription","commits_url":"https://api.github.com/repos/hgschmie/Singularity/commits{/sha}","git_commits_url":"https://api.github.com/repos/hgschmie/Singularity/git/commits{/sha}","comments_url":"https://api.github.com/repos/hgschmie/Singularity/comments{/number}","issue_comment_url":"https://api.github.com/repos/hgschmie/Singularity/issues/comments/{number}","contents_url":"https://api.github.com/repos/hgschmie/Singularity/contents/{+path}","compare_url":"https://api.github.com/repos/hgschmie/Singularity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hgschmie/Singularity/merges","archive_url":"https://api.github.com/repos/hgschmie/Singularity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hgschmie/Singularity/downloads","issues_url":"https://api.github.com/repos/hgschmie/Singularity/issues{/number}","pulls_url":"https://api.github.com/repos/hgschmie/Singularity/pulls{/number}","milestones_url":"https://api.github.com/repos/hgschmie/Singularity/milestones{/number}","notifications_url":"https://api.github.com/repos/hgschmie/Singularity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hgschmie/Singularity/labels{/name}","releases_url":"https://api.github.com/repos/hgschmie/Singularity/releases{/id}","created_at":"2014-07-18T21:29:08Z","updated_at":"2014-12-12T17:59:28Z","pushed_at":"2015-01-05T23:05:14Z","git_url":"git://github.com/hgschmie/Singularity.git","ssh_url":"git@github.com:hgschmie/Singularity.git","clone_url":"https://github.com/hgschmie/Singularity.git","svn_url":"https://github.com/hgschmie/Singularity","homepage":"https://github.com/HubSpot/Singularity","size":9101,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"HubSpot:master","ref":"master","sha":"41c5cbf1d8627afa972a13e08b7f536dc5ecf324","user":{"login":"HubSpot","id":326419,"avatar_url":"https://avatars.githubusercontent.com/u/326419?v=3","gravatar_id":"","url":"https://api.github.com/users/HubSpot","html_url":"https://github.com/HubSpot","followers_url":"https://api.github.com/users/HubSpot/followers","following_url":"https://api.github.com/users/HubSpot/following{/other_user}","gists_url":"https://api.github.com/users/HubSpot/gists{/gist_id}","starred_url":"https://api.github.com/users/HubSpot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HubSpot/subscriptions","organizations_url":"https://api.github.com/users/HubSpot/orgs","repos_url":"https://api.github.com/users/HubSpot/repos","events_url":"https://api.github.com/users/HubSpot/events{/privacy}","received_events_url":"https://api.github.com/users/HubSpot/received_events","type":"Organization","site_admin":false},"repo":{"id":13631804,"name":"Singularity","full_name":"HubSpot/Singularity","owner":{"login":"HubSpot","id":326419,"avatar_url":"https://avatars.githubusercontent.com/u/326419?v=3","gravatar_id":"","url":"https://api.github.com/users/HubSpot","html_url":"https://github.com/HubSpot","followers_url":"https://api.github.com/users/HubSpot/followers","following_url":"https://api.github.com/users/HubSpot/following{/other_user}","gists_url":"https://api.github.com/users/HubSpot/gists{/gist_id}","starred_url":"https://api.github.com/users/HubSpot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HubSpot/subscriptions","organizations_url":"https://api.github.com/users/HubSpot/orgs","repos_url":"https://api.github.com/users/HubSpot/repos","events_url":"https://api.github.com/users/HubSpot/events{/privacy}","received_events_url":"https://api.github.com/users/HubSpot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HubSpot/Singularity","description":"Scheduler (HTTP API and webapp) for running mesos tasks—long running processes, one-off tasks, and scheduled jobs. #hubspot-open-source","fork":false,"url":"https://api.github.com/repos/HubSpot/Singularity","forks_url":"https://api.github.com/repos/HubSpot/Singularity/forks","keys_url":"https://api.github.com/repos/HubSpot/Singularity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HubSpot/Singularity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HubSpot/Singularity/teams","hooks_url":"https://api.github.com/repos/HubSpot/Singularity/hooks","issue_events_url":"https://api.github.com/repos/HubSpot/Singularity/issues/events{/number}","events_url":"https://api.github.com/repos/HubSpot/Singularity/events","assignees_url":"https://api.github.com/repos/HubSpot/Singularity/assignees{/user}","branches_url":"https://api.github.com/repos/HubSpot/Singularity/branches{/branch}","tags_url":"https://api.github.com/repos/HubSpot/Singularity/tags","blobs_url":"https://api.github.com/repos/HubSpot/Singularity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HubSpot/Singularity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HubSpot/Singularity/git/refs{/sha}","trees_url":"https://api.github.com/repos/HubSpot/Singularity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HubSpot/Singularity/statuses/{sha}","languages_url":"https://api.github.com/repos/HubSpot/Singularity/languages","stargazers_url":"https://api.github.com/repos/HubSpot/Singularity/stargazers","contributors_url":"https://api.github.com/repos/HubSpot/Singularity/contributors","subscribers_url":"https://api.github.com/repos/HubSpot/Singularity/subscribers","subscription_url":"https://api.github.com/repos/HubSpot/Singularity/subscription","commits_url":"https://api.github.com/repos/HubSpot/Singularity/commits{/sha}","git_commits_url":"https://api.github.com/repos/HubSpot/Singularity/git/commits{/sha}","comments_url":"https://api.github.com/repos/HubSpot/Singularity/comments{/number}","issue_comment_url":"https://api.github.com/repos/HubSpot/Singularity/issues/comments/{number}","contents_url":"https://api.github.com/repos/HubSpot/Singularity/contents/{+path}","compare_url":"https://api.github.com/repos/HubSpot/Singularity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HubSpot/Singularity/merges","archive_url":"https://api.github.com/repos/HubSpot/Singularity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HubSpot/Singularity/downloads","issues_url":"https://api.github.com/repos/HubSpot/Singularity/issues{/number}","pulls_url":"https://api.github.com/repos/HubSpot/Singularity/pulls{/number}","milestones_url":"https://api.github.com/repos/HubSpot/Singularity/milestones{/number}","notifications_url":"https://api.github.com/repos/HubSpot/Singularity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HubSpot/Singularity/labels{/name}","releases_url":"https://api.github.com/repos/HubSpot/Singularity/releases{/id}","created_at":"2013-10-16T21:28:49Z","updated_at":"2015-01-05T19:30:12Z","pushed_at":"2015-01-05T19:30:15Z","git_url":"git://github.com/HubSpot/Singularity.git","ssh_url":"git@github.com:HubSpot/Singularity.git","clone_url":"https://github.com/HubSpot/Singularity.git","svn_url":"https://github.com/HubSpot/Singularity","homepage":"https://github.com/HubSpot/Singularity","size":19996,"stargazers_count":213,"watchers_count":213,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":31,"mirror_url":null,"open_issues_count":38,"forks":31,"open_issues":38,"watchers":213,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/HubSpot/Singularity/pulls/368"},"html":{"href":"https://github.com/HubSpot/Singularity/pull/368"},"issue":{"href":"https://api.github.com/repos/HubSpot/Singularity/issues/368"},"comments":{"href":"https://api.github.com/repos/HubSpot/Singularity/issues/368/comments"},"review_comments":{"href":"https://api.github.com/repos/HubSpot/Singularity/pulls/368/comments"},"review_comment":{"href":"https://api.github.com/repos/HubSpot/Singularity/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/HubSpot/Singularity/pulls/368/commits"},"statuses":{"href":"https://api.github.com/repos/HubSpot/Singularity/statuses/807ab54f6d80af44cc38fef6e5956f995cf85b11"}}}}