{"action":"created","comment":{"url":"https://api.github.com/repos/theforeman/smart-proxy/pulls/comments/45474746","id":45474746,"diff_hunk":"@@ -146,31 +146,34 @@ def loadSubnetData subnet\n       initialize_memory_store_with_dhcp_records(parse_config_and_leases_for_records)\n     end\n \n+    SUBNET_BLOCK_REGEX = /subnet\\s+([\\d\\.]+)\\s+netmask\\s+([\\d\\.]+)\\s*\\{([\\w-]+\\{[^{}]*\\}|[\\w-][^{}]*;)*\\}/","path":"modules/dhcp/providers/server/isc.rb","position":4,"original_position":4,"commit_id":"6726a8d24132d653166604f08d554f1079998ef3","original_commit_id":"6726a8d24132d653166604f08d554f1079998ef3","user":{"login":"domcleal","id":482089,"avatar_url":"https://avatars.githubusercontent.com/u/482089?v=3","gravatar_id":"","url":"https://api.github.com/users/domcleal","html_url":"https://github.com/domcleal","followers_url":"https://api.github.com/users/domcleal/followers","following_url":"https://api.github.com/users/domcleal/following{/other_user}","gists_url":"https://api.github.com/users/domcleal/gists{/gist_id}","starred_url":"https://api.github.com/users/domcleal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/domcleal/subscriptions","organizations_url":"https://api.github.com/users/domcleal/orgs","repos_url":"https://api.github.com/users/domcleal/repos","events_url":"https://api.github.com/users/domcleal/events{/privacy}","received_events_url":"https://api.github.com/users/domcleal/received_events","type":"User","site_admin":false},"body":"https://github.com/theforeman/puppet-dhcp/blob/master/templates/dhcpd.pool.erb is an example of just how messy a subnet definition can be.","created_at":"2015-11-20T14:39:19Z","updated_at":"2015-11-20T14:39:19Z","html_url":"https://github.com/theforeman/smart-proxy/pull/340#discussion_r45474746","pull_request_url":"https://api.github.com/repos/theforeman/smart-proxy/pulls/340","_links":{"self":{"href":"https://api.github.com/repos/theforeman/smart-proxy/pulls/comments/45474746"},"html":{"href":"https://github.com/theforeman/smart-proxy/pull/340#discussion_r45474746"},"pull_request":{"href":"https://api.github.com/repos/theforeman/smart-proxy/pulls/340"}}},"pull_request":{"url":"https://api.github.com/repos/theforeman/smart-proxy/pulls/340","id":50845180,"html_url":"https://github.com/theforeman/smart-proxy/pull/340","diff_url":"https://github.com/theforeman/smart-proxy/pull/340.diff","patch_url":"https://github.com/theforeman/smart-proxy/pull/340.patch","issue_url":"https://api.github.com/repos/theforeman/smart-proxy/issues/340","number":340,"state":"open","locked":false,"title":"Fixes #12466: isc dhcp provider handles subnet block declarations correctly now.","user":{"login":"witlessbird","id":8957,"avatar_url":"https://avatars.githubusercontent.com/u/8957?v=3","gravatar_id":"","url":"https://api.github.com/users/witlessbird","html_url":"https://github.com/witlessbird","followers_url":"https://api.github.com/users/witlessbird/followers","following_url":"https://api.github.com/users/witlessbird/following{/other_user}","gists_url":"https://api.github.com/users/witlessbird/gists{/gist_id}","starred_url":"https://api.github.com/users/witlessbird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/witlessbird/subscriptions","organizations_url":"https://api.github.com/users/witlessbird/orgs","repos_url":"https://api.github.com/users/witlessbird/repos","events_url":"https://api.github.com/users/witlessbird/events{/privacy}","received_events_url":"https://api.github.com/users/witlessbird/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-11-16T18:13:02Z","updated_at":"2015-11-20T14:39:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eb20dbb96f4f91aad78b81d1f2bba6d50d6990f4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/theforeman/smart-proxy/pulls/340/commits","review_comments_url":"https://api.github.com/repos/theforeman/smart-proxy/pulls/340/comments","review_comment_url":"https://api.github.com/repos/theforeman/smart-proxy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/theforeman/smart-proxy/issues/340/comments","statuses_url":"https://api.github.com/repos/theforeman/smart-proxy/statuses/6726a8d24132d653166604f08d554f1079998ef3","head":{"label":"witlessbird:12466-dhcp-subnet-parsing","ref":"12466-dhcp-subnet-parsing","sha":"6726a8d24132d653166604f08d554f1079998ef3","user":{"login":"witlessbird","id":8957,"avatar_url":"https://avatars.githubusercontent.com/u/8957?v=3","gravatar_id":"","url":"https://api.github.com/users/witlessbird","html_url":"https://github.com/witlessbird","followers_url":"https://api.github.com/users/witlessbird/followers","following_url":"https://api.github.com/users/witlessbird/following{/other_user}","gists_url":"https://api.github.com/users/witlessbird/gists{/gist_id}","starred_url":"https://api.github.com/users/witlessbird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/witlessbird/subscriptions","organizations_url":"https://api.github.com/users/witlessbird/orgs","repos_url":"https://api.github.com/users/witlessbird/repos","events_url":"https://api.github.com/users/witlessbird/events{/privacy}","received_events_url":"https://api.github.com/users/witlessbird/received_events","type":"User","site_admin":false},"repo":{"id":9788543,"name":"smart-proxy","full_name":"witlessbird/smart-proxy","owner":{"login":"witlessbird","id":8957,"avatar_url":"https://avatars.githubusercontent.com/u/8957?v=3","gravatar_id":"","url":"https://api.github.com/users/witlessbird","html_url":"https://github.com/witlessbird","followers_url":"https://api.github.com/users/witlessbird/followers","following_url":"https://api.github.com/users/witlessbird/following{/other_user}","gists_url":"https://api.github.com/users/witlessbird/gists{/gist_id}","starred_url":"https://api.github.com/users/witlessbird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/witlessbird/subscriptions","organizations_url":"https://api.github.com/users/witlessbird/orgs","repos_url":"https://api.github.com/users/witlessbird/repos","events_url":"https://api.github.com/users/witlessbird/events{/privacy}","received_events_url":"https://api.github.com/users/witlessbird/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/witlessbird/smart-proxy","description":"RESTful proxies for DNS, DHCP, TFTP and Puppet","fork":true,"url":"https://api.github.com/repos/witlessbird/smart-proxy","forks_url":"https://api.github.com/repos/witlessbird/smart-proxy/forks","keys_url":"https://api.github.com/repos/witlessbird/smart-proxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/witlessbird/smart-proxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/witlessbird/smart-proxy/teams","hooks_url":"https://api.github.com/repos/witlessbird/smart-proxy/hooks","issue_events_url":"https://api.github.com/repos/witlessbird/smart-proxy/issues/events{/number}","events_url":"https://api.github.com/repos/witlessbird/smart-proxy/events","assignees_url":"https://api.github.com/repos/witlessbird/smart-proxy/assignees{/user}","branches_url":"https://api.github.com/repos/witlessbird/smart-proxy/branches{/branch}","tags_url":"https://api.github.com/repos/witlessbird/smart-proxy/tags","blobs_url":"https://api.github.com/repos/witlessbird/smart-proxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/witlessbird/smart-proxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/witlessbird/smart-proxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/witlessbird/smart-proxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/witlessbird/smart-proxy/statuses/{sha}","languages_url":"https://api.github.com/repos/witlessbird/smart-proxy/languages","stargazers_url":"https://api.github.com/repos/witlessbird/smart-proxy/stargazers","contributors_url":"https://api.github.com/repos/witlessbird/smart-proxy/contributors","subscribers_url":"https://api.github.com/repos/witlessbird/smart-proxy/subscribers","subscription_url":"https://api.github.com/repos/witlessbird/smart-proxy/subscription","commits_url":"https://api.github.com/repos/witlessbird/smart-proxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/witlessbird/smart-proxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/witlessbird/smart-proxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/witlessbird/smart-proxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/witlessbird/smart-proxy/contents/{+path}","compare_url":"https://api.github.com/repos/witlessbird/smart-proxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/witlessbird/smart-proxy/merges","archive_url":"https://api.github.com/repos/witlessbird/smart-proxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/witlessbird/smart-proxy/downloads","issues_url":"https://api.github.com/repos/witlessbird/smart-proxy/issues{/number}","pulls_url":"https://api.github.com/repos/witlessbird/smart-proxy/pulls{/number}","milestones_url":"https://api.github.com/repos/witlessbird/smart-proxy/milestones{/number}","notifications_url":"https://api.github.com/repos/witlessbird/smart-proxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/witlessbird/smart-proxy/labels{/name}","releases_url":"https://api.github.com/repos/witlessbird/smart-proxy/releases{/id}","created_at":"2013-05-01T09:05:41Z","updated_at":"2015-05-05T11:14:30Z","pushed_at":"2015-11-20T12:22:22Z","git_url":"git://github.com/witlessbird/smart-proxy.git","ssh_url":"git@github.com:witlessbird/smart-proxy.git","clone_url":"https://github.com/witlessbird/smart-proxy.git","svn_url":"https://github.com/witlessbird/smart-proxy","homepage":"http://theforeman.org/projects/smart-proxy","size":1097,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"theforeman:develop","ref":"develop","sha":"f24be74d8f51f44aa8730769d2e468683804254c","user":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars.githubusercontent.com/u/1439844?v=3","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"repo":{"id":986551,"name":"smart-proxy","full_name":"theforeman/smart-proxy","owner":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars.githubusercontent.com/u/1439844?v=3","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/theforeman/smart-proxy","description":"RESTful proxies for DNS, DHCP, TFTP, BMC and Puppet","fork":false,"url":"https://api.github.com/repos/theforeman/smart-proxy","forks_url":"https://api.github.com/repos/theforeman/smart-proxy/forks","keys_url":"https://api.github.com/repos/theforeman/smart-proxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theforeman/smart-proxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theforeman/smart-proxy/teams","hooks_url":"https://api.github.com/repos/theforeman/smart-proxy/hooks","issue_events_url":"https://api.github.com/repos/theforeman/smart-proxy/issues/events{/number}","events_url":"https://api.github.com/repos/theforeman/smart-proxy/events","assignees_url":"https://api.github.com/repos/theforeman/smart-proxy/assignees{/user}","branches_url":"https://api.github.com/repos/theforeman/smart-proxy/branches{/branch}","tags_url":"https://api.github.com/repos/theforeman/smart-proxy/tags","blobs_url":"https://api.github.com/repos/theforeman/smart-proxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theforeman/smart-proxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theforeman/smart-proxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/theforeman/smart-proxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theforeman/smart-proxy/statuses/{sha}","languages_url":"https://api.github.com/repos/theforeman/smart-proxy/languages","stargazers_url":"https://api.github.com/repos/theforeman/smart-proxy/stargazers","contributors_url":"https://api.github.com/repos/theforeman/smart-proxy/contributors","subscribers_url":"https://api.github.com/repos/theforeman/smart-proxy/subscribers","subscription_url":"https://api.github.com/repos/theforeman/smart-proxy/subscription","commits_url":"https://api.github.com/repos/theforeman/smart-proxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/theforeman/smart-proxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/theforeman/smart-proxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/theforeman/smart-proxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/theforeman/smart-proxy/contents/{+path}","compare_url":"https://api.github.com/repos/theforeman/smart-proxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theforeman/smart-proxy/merges","archive_url":"https://api.github.com/repos/theforeman/smart-proxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theforeman/smart-proxy/downloads","issues_url":"https://api.github.com/repos/theforeman/smart-proxy/issues{/number}","pulls_url":"https://api.github.com/repos/theforeman/smart-proxy/pulls{/number}","milestones_url":"https://api.github.com/repos/theforeman/smart-proxy/milestones{/number}","notifications_url":"https://api.github.com/repos/theforeman/smart-proxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theforeman/smart-proxy/labels{/name}","releases_url":"https://api.github.com/repos/theforeman/smart-proxy/releases{/id}","created_at":"2010-10-14T10:00:51Z","updated_at":"2015-11-20T03:23:35Z","pushed_at":"2015-11-20T14:19:39Z","git_url":"git://github.com/theforeman/smart-proxy.git","ssh_url":"git@github.com:theforeman/smart-proxy.git","clone_url":"https://github.com/theforeman/smart-proxy.git","svn_url":"https://github.com/theforeman/smart-proxy","homepage":"http://theforeman.org/projects/smart-proxy","size":1614,"stargazers_count":116,"watchers_count":116,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":142,"mirror_url":null,"open_issues_count":19,"forks":142,"open_issues":19,"watchers":116,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/theforeman/smart-proxy/pulls/340"},"html":{"href":"https://github.com/theforeman/smart-proxy/pull/340"},"issue":{"href":"https://api.github.com/repos/theforeman/smart-proxy/issues/340"},"comments":{"href":"https://api.github.com/repos/theforeman/smart-proxy/issues/340/comments"},"review_comments":{"href":"https://api.github.com/repos/theforeman/smart-proxy/pulls/340/comments"},"review_comment":{"href":"https://api.github.com/repos/theforeman/smart-proxy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/theforeman/smart-proxy/pulls/340/commits"},"statuses":{"href":"https://api.github.com/repos/theforeman/smart-proxy/statuses/6726a8d24132d653166604f08d554f1079998ef3"}}}}