{"action":"created","comment":{"url":"https://api.github.com/repos/ckeditor/ckeditor5/pulls/comments/23152520","id":23152520,"diff_hunk":"@@ -0,0 +1,36 @@\n+/*","path":"lib/requirejs/require.js","position":null,"original_position":1,"commit_id":"49b17a2f5bba9d0ce42c4eaf312016046127b0d8","original_commit_id":"76d64c6b3eb2dc431c6d1083753bea59b7af2240","user":{"login":"fredck","id":630060,"avatar_url":"https://avatars.githubusercontent.com/u/630060?v=3","gravatar_id":"","url":"https://api.github.com/users/fredck","html_url":"https://github.com/fredck","followers_url":"https://api.github.com/users/fredck/followers","following_url":"https://api.github.com/users/fredck/following{/other_user}","gists_url":"https://api.github.com/users/fredck/gists{/gist_id}","starred_url":"https://api.github.com/users/fredck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fredck/subscriptions","organizations_url":"https://api.github.com/users/fredck/orgs","repos_url":"https://api.github.com/users/fredck/repos","events_url":"https://api.github.com/users/fredck/events{/privacy}","received_events_url":"https://api.github.com/users/fredck/received_events","type":"User","site_admin":false},"body":"You’re totally right. I said something stupid.\r\n\r\nI’ve remove the RequireJS code with 49b17a2, getting rid of the lib directory (hurray!).","created_at":"2015-01-19T10:41:30Z","updated_at":"2015-01-19T10:41:30Z","html_url":"https://github.com/ckeditor/ckeditor5/pull/6#discussion_r23152520","pull_request_url":"https://api.github.com/repos/ckeditor/ckeditor5/pulls/6","_links":{"self":{"href":"https://api.github.com/repos/ckeditor/ckeditor5/pulls/comments/23152520"},"html":{"href":"https://github.com/ckeditor/ckeditor5/pull/6#discussion_r23152520"},"pull_request":{"href":"https://api.github.com/repos/ckeditor/ckeditor5/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/ckeditor/ckeditor5/pulls/6","id":27419075,"html_url":"https://github.com/ckeditor/ckeditor5/pull/6","diff_url":"https://github.com/ckeditor/ckeditor5/pull/6.diff","patch_url":"https://github.com/ckeditor/ckeditor5/pull/6.patch","issue_url":"https://api.github.com/repos/ckeditor/ckeditor5/issues/6","number":6,"state":"open","locked":false,"title":"t/5: Introducing the CKEDITOR namespace, the AMD API and the Builder.","user":{"login":"fredck","id":630060,"avatar_url":"https://avatars.githubusercontent.com/u/630060?v=3","gravatar_id":"","url":"https://api.github.com/users/fredck","html_url":"https://github.com/fredck","followers_url":"https://api.github.com/users/fredck/followers","following_url":"https://api.github.com/users/fredck/following{/other_user}","gists_url":"https://api.github.com/users/fredck/gists{/gist_id}","starred_url":"https://api.github.com/users/fredck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fredck/subscriptions","organizations_url":"https://api.github.com/users/fredck/orgs","repos_url":"https://api.github.com/users/fredck/repos","events_url":"https://api.github.com/users/fredck/events{/privacy}","received_events_url":"https://api.github.com/users/fredck/received_events","type":"User","site_admin":false},"body":"The proposed code means to close #2, #4 and #5.\r\n\r\nI've pushed t/2 and t/4 as well, but I'm putting t/5 only under review because all those features are extremely related. They're actually defining the basics for our AMD approach. So it is simpler to review t/5 only and close all those issues at once.\r\n\r\nThere is a cross-requirement for this PR in ckeditor5-core:\r\nhttps://github.com/ckeditor/ckeditor5-core/issues/1\r\n\r\nTherefore to review this one, ckeditor5-core must be at t/1.\r\n\r\nThe builder is simply merging the main scripts for now. Other features are to be added in the future so a complete and real distribution version will be created. For now, the focus is creating an interchangeable build version of the root `ckeditor.js`.\r\n\r\nNo tests are included because it was not possible to bring the infrastructure necessary for the test environment (#1) without any API to get tested. Therefore, tests will be added later once this PR is masterised and #1 gets closed. A ticket will be opened as a followup to this PR.\r\n\r\nThe builder can be executed by simply running `grunt build`.","created_at":"2015-01-15T10:38:40Z","updated_at":"2015-01-19T10:41:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8e3af1e01ebece9bd683d219802e9a322aa4d24f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ckeditor/ckeditor5/pulls/6/commits","review_comments_url":"https://api.github.com/repos/ckeditor/ckeditor5/pulls/6/comments","review_comment_url":"https://api.github.com/repos/ckeditor/ckeditor5/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ckeditor/ckeditor5/issues/6/comments","statuses_url":"https://api.github.com/repos/ckeditor/ckeditor5/statuses/49b17a2f5bba9d0ce42c4eaf312016046127b0d8","head":{"label":"cksource:t/5","ref":"t/5","sha":"49b17a2f5bba9d0ce42c4eaf312016046127b0d8","user":{"login":"cksource","id":825698,"avatar_url":"https://avatars.githubusercontent.com/u/825698?v=3","gravatar_id":"","url":"https://api.github.com/users/cksource","html_url":"https://github.com/cksource","followers_url":"https://api.github.com/users/cksource/followers","following_url":"https://api.github.com/users/cksource/following{/other_user}","gists_url":"https://api.github.com/users/cksource/gists{/gist_id}","starred_url":"https://api.github.com/users/cksource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cksource/subscriptions","organizations_url":"https://api.github.com/users/cksource/orgs","repos_url":"https://api.github.com/users/cksource/repos","events_url":"https://api.github.com/users/cksource/events{/privacy}","received_events_url":"https://api.github.com/users/cksource/received_events","type":"Organization","site_admin":false},"repo":{"id":29017627,"name":"ckeditor5","full_name":"cksource/ckeditor5","owner":{"login":"cksource","id":825698,"avatar_url":"https://avatars.githubusercontent.com/u/825698?v=3","gravatar_id":"","url":"https://api.github.com/users/cksource","html_url":"https://github.com/cksource","followers_url":"https://api.github.com/users/cksource/followers","following_url":"https://api.github.com/users/cksource/following{/other_user}","gists_url":"https://api.github.com/users/cksource/gists{/gist_id}","starred_url":"https://api.github.com/users/cksource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cksource/subscriptions","organizations_url":"https://api.github.com/users/cksource/orgs","repos_url":"https://api.github.com/users/cksource/repos","events_url":"https://api.github.com/users/cksource/events{/privacy}","received_events_url":"https://api.github.com/users/cksource/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cksource/ckeditor5","description":"The developer version of CKEditor 5; the best browser-based WYSIWYG editor.","fork":true,"url":"https://api.github.com/repos/cksource/ckeditor5","forks_url":"https://api.github.com/repos/cksource/ckeditor5/forks","keys_url":"https://api.github.com/repos/cksource/ckeditor5/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cksource/ckeditor5/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cksource/ckeditor5/teams","hooks_url":"https://api.github.com/repos/cksource/ckeditor5/hooks","issue_events_url":"https://api.github.com/repos/cksource/ckeditor5/issues/events{/number}","events_url":"https://api.github.com/repos/cksource/ckeditor5/events","assignees_url":"https://api.github.com/repos/cksource/ckeditor5/assignees{/user}","branches_url":"https://api.github.com/repos/cksource/ckeditor5/branches{/branch}","tags_url":"https://api.github.com/repos/cksource/ckeditor5/tags","blobs_url":"https://api.github.com/repos/cksource/ckeditor5/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cksource/ckeditor5/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cksource/ckeditor5/git/refs{/sha}","trees_url":"https://api.github.com/repos/cksource/ckeditor5/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cksource/ckeditor5/statuses/{sha}","languages_url":"https://api.github.com/repos/cksource/ckeditor5/languages","stargazers_url":"https://api.github.com/repos/cksource/ckeditor5/stargazers","contributors_url":"https://api.github.com/repos/cksource/ckeditor5/contributors","subscribers_url":"https://api.github.com/repos/cksource/ckeditor5/subscribers","subscription_url":"https://api.github.com/repos/cksource/ckeditor5/subscription","commits_url":"https://api.github.com/repos/cksource/ckeditor5/commits{/sha}","git_commits_url":"https://api.github.com/repos/cksource/ckeditor5/git/commits{/sha}","comments_url":"https://api.github.com/repos/cksource/ckeditor5/comments{/number}","issue_comment_url":"https://api.github.com/repos/cksource/ckeditor5/issues/comments/{number}","contents_url":"https://api.github.com/repos/cksource/ckeditor5/contents/{+path}","compare_url":"https://api.github.com/repos/cksource/ckeditor5/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cksource/ckeditor5/merges","archive_url":"https://api.github.com/repos/cksource/ckeditor5/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cksource/ckeditor5/downloads","issues_url":"https://api.github.com/repos/cksource/ckeditor5/issues{/number}","pulls_url":"https://api.github.com/repos/cksource/ckeditor5/pulls{/number}","milestones_url":"https://api.github.com/repos/cksource/ckeditor5/milestones{/number}","notifications_url":"https://api.github.com/repos/cksource/ckeditor5/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cksource/ckeditor5/labels{/name}","releases_url":"https://api.github.com/repos/cksource/ckeditor5/releases{/id}","created_at":"2015-01-09T13:33:31Z","updated_at":"2015-01-09T13:33:31Z","pushed_at":"2015-01-19T10:37:12Z","git_url":"git://github.com/cksource/ckeditor5.git","ssh_url":"git@github.com:cksource/ckeditor5.git","clone_url":"https://github.com/cksource/ckeditor5.git","svn_url":"https://github.com/cksource/ckeditor5","homepage":"","size":180,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ckeditor:master","ref":"master","sha":"3e3433ebebda9aede592a129a0c2ebaaf9111832","user":{"login":"ckeditor","id":825710,"avatar_url":"https://avatars.githubusercontent.com/u/825710?v=3","gravatar_id":"","url":"https://api.github.com/users/ckeditor","html_url":"https://github.com/ckeditor","followers_url":"https://api.github.com/users/ckeditor/followers","following_url":"https://api.github.com/users/ckeditor/following{/other_user}","gists_url":"https://api.github.com/users/ckeditor/gists{/gist_id}","starred_url":"https://api.github.com/users/ckeditor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckeditor/subscriptions","organizations_url":"https://api.github.com/users/ckeditor/orgs","repos_url":"https://api.github.com/users/ckeditor/repos","events_url":"https://api.github.com/users/ckeditor/events{/privacy}","received_events_url":"https://api.github.com/users/ckeditor/received_events","type":"Organization","site_admin":false},"repo":{"id":28964450,"name":"ckeditor5","full_name":"ckeditor/ckeditor5","owner":{"login":"ckeditor","id":825710,"avatar_url":"https://avatars.githubusercontent.com/u/825710?v=3","gravatar_id":"","url":"https://api.github.com/users/ckeditor","html_url":"https://github.com/ckeditor","followers_url":"https://api.github.com/users/ckeditor/followers","following_url":"https://api.github.com/users/ckeditor/following{/other_user}","gists_url":"https://api.github.com/users/ckeditor/gists{/gist_id}","starred_url":"https://api.github.com/users/ckeditor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckeditor/subscriptions","organizations_url":"https://api.github.com/users/ckeditor/orgs","repos_url":"https://api.github.com/users/ckeditor/repos","events_url":"https://api.github.com/users/ckeditor/events{/privacy}","received_events_url":"https://api.github.com/users/ckeditor/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ckeditor/ckeditor5","description":"The developer version of CKEditor 5; the best browser-based WYSIWYG editor.","fork":false,"url":"https://api.github.com/repos/ckeditor/ckeditor5","forks_url":"https://api.github.com/repos/ckeditor/ckeditor5/forks","keys_url":"https://api.github.com/repos/ckeditor/ckeditor5/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ckeditor/ckeditor5/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ckeditor/ckeditor5/teams","hooks_url":"https://api.github.com/repos/ckeditor/ckeditor5/hooks","issue_events_url":"https://api.github.com/repos/ckeditor/ckeditor5/issues/events{/number}","events_url":"https://api.github.com/repos/ckeditor/ckeditor5/events","assignees_url":"https://api.github.com/repos/ckeditor/ckeditor5/assignees{/user}","branches_url":"https://api.github.com/repos/ckeditor/ckeditor5/branches{/branch}","tags_url":"https://api.github.com/repos/ckeditor/ckeditor5/tags","blobs_url":"https://api.github.com/repos/ckeditor/ckeditor5/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ckeditor/ckeditor5/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ckeditor/ckeditor5/git/refs{/sha}","trees_url":"https://api.github.com/repos/ckeditor/ckeditor5/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ckeditor/ckeditor5/statuses/{sha}","languages_url":"https://api.github.com/repos/ckeditor/ckeditor5/languages","stargazers_url":"https://api.github.com/repos/ckeditor/ckeditor5/stargazers","contributors_url":"https://api.github.com/repos/ckeditor/ckeditor5/contributors","subscribers_url":"https://api.github.com/repos/ckeditor/ckeditor5/subscribers","subscription_url":"https://api.github.com/repos/ckeditor/ckeditor5/subscription","commits_url":"https://api.github.com/repos/ckeditor/ckeditor5/commits{/sha}","git_commits_url":"https://api.github.com/repos/ckeditor/ckeditor5/git/commits{/sha}","comments_url":"https://api.github.com/repos/ckeditor/ckeditor5/comments{/number}","issue_comment_url":"https://api.github.com/repos/ckeditor/ckeditor5/issues/comments/{number}","contents_url":"https://api.github.com/repos/ckeditor/ckeditor5/contents/{+path}","compare_url":"https://api.github.com/repos/ckeditor/ckeditor5/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ckeditor/ckeditor5/merges","archive_url":"https://api.github.com/repos/ckeditor/ckeditor5/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ckeditor/ckeditor5/downloads","issues_url":"https://api.github.com/repos/ckeditor/ckeditor5/issues{/number}","pulls_url":"https://api.github.com/repos/ckeditor/ckeditor5/pulls{/number}","milestones_url":"https://api.github.com/repos/ckeditor/ckeditor5/milestones{/number}","notifications_url":"https://api.github.com/repos/ckeditor/ckeditor5/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ckeditor/ckeditor5/labels{/name}","releases_url":"https://api.github.com/repos/ckeditor/ckeditor5/releases{/id}","created_at":"2015-01-08T12:13:59Z","updated_at":"2015-01-09T08:19:35Z","pushed_at":"2015-01-08T12:26:22Z","git_url":"git://github.com/ckeditor/ckeditor5.git","ssh_url":"git@github.com:ckeditor/ckeditor5.git","clone_url":"https://github.com/ckeditor/ckeditor5.git","svn_url":"https://github.com/ckeditor/ckeditor5","homepage":"","size":164,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":6,"forks":1,"open_issues":6,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ckeditor/ckeditor5/pulls/6"},"html":{"href":"https://github.com/ckeditor/ckeditor5/pull/6"},"issue":{"href":"https://api.github.com/repos/ckeditor/ckeditor5/issues/6"},"comments":{"href":"https://api.github.com/repos/ckeditor/ckeditor5/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/ckeditor/ckeditor5/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/ckeditor/ckeditor5/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ckeditor/ckeditor5/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/ckeditor/ckeditor5/statuses/49b17a2f5bba9d0ce42c4eaf312016046127b0d8"}}}}