{"action":"created","comment":{"url":"https://api.github.com/repos/lsst-pst/syseng_throughputs/pulls/comments/40832410","id":40832410,"diff_hunk":"@@ -0,0 +1,251 @@\n+import os\n+import numpy as np\n+import matplotlib.pyplot as plt\n+from glob import glob\n+from lsst.sims.photUtils import Bandpass\n+\n+# Input components:\n+\n+# $SYSENG_THROUGHPUTS_DIR / components\n+#   camera /\n+#      detector /   vendor[1,2] / ven[1,2]QE.dat, ven[1,2]Losses.dat  (multiply for a particular vendor, use min between vendors for 'average')\n+#      lens[1,2,3] / l[1,2,3]Glass.dat, l[1,2,3]SBBAR.dat, l[1,2,3]S2BBAR.dat  (pass Glass through savitzky_golay and multiply by BBARs)\n+#              l[1,2,3]Losses   / l[1,2,3]S(1,2)(Condensation,Contamination).dat   (multiply all)\n+#      filters / [u,g,r,i,z,y]-bandResponse.dat\n+#              filterLosses/    filterS(1,2)(Condensation,Contamination).dat (multiply all, for all filters)\n+#   telescope /\n+#       mirror[1,2,3] / m[1,2,3]Losses.dat, m[1,2,3]ProtAlIdeal.dat   (multiply ideal and loss for each mirror, multiply all mirrors)\n+\n+def setDefaultDirs(rootDir=None):\n+    \"\"\"\n+    Returns a dictionary with the default directory locations of each component of the system throughput.\n+    \"\"\"\n+    # Set SYSENG_THROUGHPUTS_DIR to the root dir for syseng_throughputs ('setup syseng_throughputs' will do this automatically)\n+    defaultDirs = {}\n+    if rootDir is None:\n+        rootDir = os.getenv('SYSENG_THROUGHPUTS_DIR')","path":"python/bandpassUtils.py","position":26,"original_position":26,"commit_id":"a4cf159a220fecc898a5b0f964f0f0c9bf384cc0","original_commit_id":"a4cf159a220fecc898a5b0f964f0f0c9bf384cc0","user":{"login":"danielsf","id":1682854,"avatar_url":"https://avatars.githubusercontent.com/u/1682854?v=3","gravatar_id":"","url":"https://api.github.com/users/danielsf","html_url":"https://github.com/danielsf","followers_url":"https://api.github.com/users/danielsf/followers","following_url":"https://api.github.com/users/danielsf/following{/other_user}","gists_url":"https://api.github.com/users/danielsf/gists{/gist_id}","starred_url":"https://api.github.com/users/danielsf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielsf/subscriptions","organizations_url":"https://api.github.com/users/danielsf/orgs","repos_url":"https://api.github.com/users/danielsf/repos","events_url":"https://api.github.com/users/danielsf/events{/privacy}","received_events_url":"https://api.github.com/users/danielsf/received_events","type":"User","site_admin":false},"body":"Do you want to support people who have not use eups to setup the stack?  If not, should this be\r\n\r\nrootDir = lsst.utils.getPackageDir('sysengh_throughputs')\r\n\r\n?","created_at":"2015-09-30T18:32:50Z","updated_at":"2015-09-30T18:32:50Z","html_url":"https://github.com/lsst-pst/syseng_throughputs/pull/1#discussion_r40832410","pull_request_url":"https://api.github.com/repos/lsst-pst/syseng_throughputs/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/lsst-pst/syseng_throughputs/pulls/comments/40832410"},"html":{"href":"https://github.com/lsst-pst/syseng_throughputs/pull/1#discussion_r40832410"},"pull_request":{"href":"https://api.github.com/repos/lsst-pst/syseng_throughputs/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/lsst-pst/syseng_throughputs/pulls/1","id":45949811,"html_url":"https://github.com/lsst-pst/syseng_throughputs/pull/1","diff_url":"https://github.com/lsst-pst/syseng_throughputs/pull/1.diff","patch_url":"https://github.com/lsst-pst/syseng_throughputs/pull/1.patch","issue_url":"https://api.github.com/repos/lsst-pst/syseng_throughputs/issues/1","number":1,"state":"open","locked":false,"title":"Mixed detector","user":{"login":"rhiannonlynne","id":1855711,"avatar_url":"https://avatars.githubusercontent.com/u/1855711?v=3","gravatar_id":"","url":"https://api.github.com/users/rhiannonlynne","html_url":"https://github.com/rhiannonlynne","followers_url":"https://api.github.com/users/rhiannonlynne/followers","following_url":"https://api.github.com/users/rhiannonlynne/following{/other_user}","gists_url":"https://api.github.com/users/rhiannonlynne/gists{/gist_id}","starred_url":"https://api.github.com/users/rhiannonlynne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhiannonlynne/subscriptions","organizations_url":"https://api.github.com/users/rhiannonlynne/orgs","repos_url":"https://api.github.com/users/rhiannonlynne/repos","events_url":"https://api.github.com/users/rhiannonlynne/events{/privacy}","received_events_url":"https://api.github.com/users/rhiannonlynne/received_events","type":"User","site_admin":false},"body":"Fixed m2throughput.dat file and ipython notebook to generate this file.\r\n\r\nAdded SEDs. \r\n\r\nAdded sedUtils and bandpassUtils - note bandpassUtils will let you build throughput curves from base components! (ie.. they duplicate some of the functionality of the ipython notebooks and we should probably think about what to do with that). \r\n\r\nAdded mixedDetector analysis (uses bandpassUtils and sedUtils, requires sims_photUtils). ","created_at":"2015-09-24T21:05:30Z","updated_at":"2015-09-30T18:32:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fd4127b2df0a23270c6bdf84197c9ec229f543f3","assignee":{"login":"cclaver","id":7738450,"avatar_url":"https://avatars.githubusercontent.com/u/7738450?v=3","gravatar_id":"","url":"https://api.github.com/users/cclaver","html_url":"https://github.com/cclaver","followers_url":"https://api.github.com/users/cclaver/followers","following_url":"https://api.github.com/users/cclaver/following{/other_user}","gists_url":"https://api.github.com/users/cclaver/gists{/gist_id}","starred_url":"https://api.github.com/users/cclaver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cclaver/subscriptions","organizations_url":"https://api.github.com/users/cclaver/orgs","repos_url":"https://api.github.com/users/cclaver/repos","events_url":"https://api.github.com/users/cclaver/events{/privacy}","received_events_url":"https://api.github.com/users/cclaver/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/lsst-pst/syseng_throughputs/pulls/1/commits","review_comments_url":"https://api.github.com/repos/lsst-pst/syseng_throughputs/pulls/1/comments","review_comment_url":"https://api.github.com/repos/lsst-pst/syseng_throughputs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lsst-pst/syseng_throughputs/issues/1/comments","statuses_url":"https://api.github.com/repos/lsst-pst/syseng_throughputs/statuses/a4cf159a220fecc898a5b0f964f0f0c9bf384cc0","head":{"label":"lsst-pst:mixedDetector","ref":"mixedDetector","sha":"a4cf159a220fecc898a5b0f964f0f0c9bf384cc0","user":{"login":"lsst-pst","id":13230144,"avatar_url":"https://avatars.githubusercontent.com/u/13230144?v=3","gravatar_id":"","url":"https://api.github.com/users/lsst-pst","html_url":"https://github.com/lsst-pst","followers_url":"https://api.github.com/users/lsst-pst/followers","following_url":"https://api.github.com/users/lsst-pst/following{/other_user}","gists_url":"https://api.github.com/users/lsst-pst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst-pst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst-pst/subscriptions","organizations_url":"https://api.github.com/users/lsst-pst/orgs","repos_url":"https://api.github.com/users/lsst-pst/repos","events_url":"https://api.github.com/users/lsst-pst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst-pst/received_events","type":"Organization","site_admin":false},"repo":{"id":38785425,"name":"syseng_throughputs","full_name":"lsst-pst/syseng_throughputs","owner":{"login":"lsst-pst","id":13230144,"avatar_url":"https://avatars.githubusercontent.com/u/13230144?v=3","gravatar_id":"","url":"https://api.github.com/users/lsst-pst","html_url":"https://github.com/lsst-pst","followers_url":"https://api.github.com/users/lsst-pst/followers","following_url":"https://api.github.com/users/lsst-pst/following{/other_user}","gists_url":"https://api.github.com/users/lsst-pst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst-pst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst-pst/subscriptions","organizations_url":"https://api.github.com/users/lsst-pst/orgs","repos_url":"https://api.github.com/users/lsst-pst/repos","events_url":"https://api.github.com/users/lsst-pst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst-pst/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lsst-pst/syseng_throughputs","description":"SysEng-approved LSST throughput information","fork":false,"url":"https://api.github.com/repos/lsst-pst/syseng_throughputs","forks_url":"https://api.github.com/repos/lsst-pst/syseng_throughputs/forks","keys_url":"https://api.github.com/repos/lsst-pst/syseng_throughputs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lsst-pst/syseng_throughputs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lsst-pst/syseng_throughputs/teams","hooks_url":"https://api.github.com/repos/lsst-pst/syseng_throughputs/hooks","issue_events_url":"https://api.github.com/repos/lsst-pst/syseng_throughputs/issues/events{/number}","events_url":"https://api.github.com/repos/lsst-pst/syseng_throughputs/events","assignees_url":"https://api.github.com/repos/lsst-pst/syseng_throughputs/assignees{/user}","branches_url":"https://api.github.com/repos/lsst-pst/syseng_throughputs/branches{/branch}","tags_url":"https://api.github.com/repos/lsst-pst/syseng_throughputs/tags","blobs_url":"https://api.github.com/repos/lsst-pst/syseng_throughputs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lsst-pst/syseng_throughputs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lsst-pst/syseng_throughputs/git/refs{/sha}","trees_url":"https://api.github.com/repos/lsst-pst/syseng_throughputs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lsst-pst/syseng_throughputs/statuses/{sha}","languages_url":"https://api.github.com/repos/lsst-pst/syseng_throughputs/languages","stargazers_url":"https://api.github.com/repos/lsst-pst/syseng_throughputs/stargazers","contributors_url":"https://api.github.com/repos/lsst-pst/syseng_throughputs/contributors","subscribers_url":"https://api.github.com/repos/lsst-pst/syseng_throughputs/subscribers","subscription_url":"https://api.github.com/repos/lsst-pst/syseng_throughputs/subscription","commits_url":"https://api.github.com/repos/lsst-pst/syseng_throughputs/commits{/sha}","git_commits_url":"https://api.github.com/repos/lsst-pst/syseng_throughputs/git/commits{/sha}","comments_url":"https://api.github.com/repos/lsst-pst/syseng_throughputs/comments{/number}","issue_comment_url":"https://api.github.com/repos/lsst-pst/syseng_throughputs/issues/comments{/number}","contents_url":"https://api.github.com/repos/lsst-pst/syseng_throughputs/contents/{+path}","compare_url":"https://api.github.com/repos/lsst-pst/syseng_throughputs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lsst-pst/syseng_throughputs/merges","archive_url":"https://api.github.com/repos/lsst-pst/syseng_throughputs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lsst-pst/syseng_throughputs/downloads","issues_url":"https://api.github.com/repos/lsst-pst/syseng_throughputs/issues{/number}","pulls_url":"https://api.github.com/repos/lsst-pst/syseng_throughputs/pulls{/number}","milestones_url":"https://api.github.com/repos/lsst-pst/syseng_throughputs/milestones{/number}","notifications_url":"https://api.github.com/repos/lsst-pst/syseng_throughputs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lsst-pst/syseng_throughputs/labels{/name}","releases_url":"https://api.github.com/repos/lsst-pst/syseng_throughputs/releases{/id}","created_at":"2015-07-08T23:30:11Z","updated_at":"2015-07-09T17:35:02Z","pushed_at":"2015-09-24T21:05:30Z","git_url":"git://github.com/lsst-pst/syseng_throughputs.git","ssh_url":"git@github.com:lsst-pst/syseng_throughputs.git","clone_url":"https://github.com/lsst-pst/syseng_throughputs.git","svn_url":"https://github.com/lsst-pst/syseng_throughputs","homepage":null,"size":2644,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"lsst-pst:master","ref":"master","sha":"03d72ed45724b10f6dd6f9ae0eeb0283299183ac","user":{"login":"lsst-pst","id":13230144,"avatar_url":"https://avatars.githubusercontent.com/u/13230144?v=3","gravatar_id":"","url":"https://api.github.com/users/lsst-pst","html_url":"https://github.com/lsst-pst","followers_url":"https://api.github.com/users/lsst-pst/followers","following_url":"https://api.github.com/users/lsst-pst/following{/other_user}","gists_url":"https://api.github.com/users/lsst-pst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst-pst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst-pst/subscriptions","organizations_url":"https://api.github.com/users/lsst-pst/orgs","repos_url":"https://api.github.com/users/lsst-pst/repos","events_url":"https://api.github.com/users/lsst-pst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst-pst/received_events","type":"Organization","site_admin":false},"repo":{"id":38785425,"name":"syseng_throughputs","full_name":"lsst-pst/syseng_throughputs","owner":{"login":"lsst-pst","id":13230144,"avatar_url":"https://avatars.githubusercontent.com/u/13230144?v=3","gravatar_id":"","url":"https://api.github.com/users/lsst-pst","html_url":"https://github.com/lsst-pst","followers_url":"https://api.github.com/users/lsst-pst/followers","following_url":"https://api.github.com/users/lsst-pst/following{/other_user}","gists_url":"https://api.github.com/users/lsst-pst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst-pst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst-pst/subscriptions","organizations_url":"https://api.github.com/users/lsst-pst/orgs","repos_url":"https://api.github.com/users/lsst-pst/repos","events_url":"https://api.github.com/users/lsst-pst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst-pst/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lsst-pst/syseng_throughputs","description":"SysEng-approved LSST throughput information","fork":false,"url":"https://api.github.com/repos/lsst-pst/syseng_throughputs","forks_url":"https://api.github.com/repos/lsst-pst/syseng_throughputs/forks","keys_url":"https://api.github.com/repos/lsst-pst/syseng_throughputs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lsst-pst/syseng_throughputs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lsst-pst/syseng_throughputs/teams","hooks_url":"https://api.github.com/repos/lsst-pst/syseng_throughputs/hooks","issue_events_url":"https://api.github.com/repos/lsst-pst/syseng_throughputs/issues/events{/number}","events_url":"https://api.github.com/repos/lsst-pst/syseng_throughputs/events","assignees_url":"https://api.github.com/repos/lsst-pst/syseng_throughputs/assignees{/user}","branches_url":"https://api.github.com/repos/lsst-pst/syseng_throughputs/branches{/branch}","tags_url":"https://api.github.com/repos/lsst-pst/syseng_throughputs/tags","blobs_url":"https://api.github.com/repos/lsst-pst/syseng_throughputs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lsst-pst/syseng_throughputs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lsst-pst/syseng_throughputs/git/refs{/sha}","trees_url":"https://api.github.com/repos/lsst-pst/syseng_throughputs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lsst-pst/syseng_throughputs/statuses/{sha}","languages_url":"https://api.github.com/repos/lsst-pst/syseng_throughputs/languages","stargazers_url":"https://api.github.com/repos/lsst-pst/syseng_throughputs/stargazers","contributors_url":"https://api.github.com/repos/lsst-pst/syseng_throughputs/contributors","subscribers_url":"https://api.github.com/repos/lsst-pst/syseng_throughputs/subscribers","subscription_url":"https://api.github.com/repos/lsst-pst/syseng_throughputs/subscription","commits_url":"https://api.github.com/repos/lsst-pst/syseng_throughputs/commits{/sha}","git_commits_url":"https://api.github.com/repos/lsst-pst/syseng_throughputs/git/commits{/sha}","comments_url":"https://api.github.com/repos/lsst-pst/syseng_throughputs/comments{/number}","issue_comment_url":"https://api.github.com/repos/lsst-pst/syseng_throughputs/issues/comments{/number}","contents_url":"https://api.github.com/repos/lsst-pst/syseng_throughputs/contents/{+path}","compare_url":"https://api.github.com/repos/lsst-pst/syseng_throughputs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lsst-pst/syseng_throughputs/merges","archive_url":"https://api.github.com/repos/lsst-pst/syseng_throughputs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lsst-pst/syseng_throughputs/downloads","issues_url":"https://api.github.com/repos/lsst-pst/syseng_throughputs/issues{/number}","pulls_url":"https://api.github.com/repos/lsst-pst/syseng_throughputs/pulls{/number}","milestones_url":"https://api.github.com/repos/lsst-pst/syseng_throughputs/milestones{/number}","notifications_url":"https://api.github.com/repos/lsst-pst/syseng_throughputs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lsst-pst/syseng_throughputs/labels{/name}","releases_url":"https://api.github.com/repos/lsst-pst/syseng_throughputs/releases{/id}","created_at":"2015-07-08T23:30:11Z","updated_at":"2015-07-09T17:35:02Z","pushed_at":"2015-09-24T21:05:30Z","git_url":"git://github.com/lsst-pst/syseng_throughputs.git","ssh_url":"git@github.com:lsst-pst/syseng_throughputs.git","clone_url":"https://github.com/lsst-pst/syseng_throughputs.git","svn_url":"https://github.com/lsst-pst/syseng_throughputs","homepage":null,"size":2644,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lsst-pst/syseng_throughputs/pulls/1"},"html":{"href":"https://github.com/lsst-pst/syseng_throughputs/pull/1"},"issue":{"href":"https://api.github.com/repos/lsst-pst/syseng_throughputs/issues/1"},"comments":{"href":"https://api.github.com/repos/lsst-pst/syseng_throughputs/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/lsst-pst/syseng_throughputs/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/lsst-pst/syseng_throughputs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lsst-pst/syseng_throughputs/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/lsst-pst/syseng_throughputs/statuses/a4cf159a220fecc898a5b0f964f0f0c9bf384cc0"}}}}