{"action":"created","issue":{"url":"https://api.github.com/repos/angular-ui/ng-grid/issues/3138","labels_url":"https://api.github.com/repos/angular-ui/ng-grid/issues/3138/labels{/name}","comments_url":"https://api.github.com/repos/angular-ui/ng-grid/issues/3138/comments","events_url":"https://api.github.com/repos/angular-ui/ng-grid/issues/3138/events","html_url":"https://github.com/angular-ui/ng-grid/issues/3138","id":64875082,"number":3138,"title":"Filter widgets (controls) do not show up if filtering is enabled dynamically","user":{"login":"yurigenin","id":11202960,"avatar_url":"https://avatars.githubusercontent.com/u/11202960?v=3","gravatar_id":"","url":"https://api.github.com/users/yurigenin","html_url":"https://github.com/yurigenin","followers_url":"https://api.github.com/users/yurigenin/followers","following_url":"https://api.github.com/users/yurigenin/following{/other_user}","gists_url":"https://api.github.com/users/yurigenin/gists{/gist_id}","starred_url":"https://api.github.com/users/yurigenin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yurigenin/subscriptions","organizations_url":"https://api.github.com/users/yurigenin/orgs","repos_url":"https://api.github.com/users/yurigenin/repos","events_url":"https://api.github.com/users/yurigenin/events{/privacy}","received_events_url":"https://api.github.com/users/yurigenin/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/angular-ui/ng-grid/labels/bug","name":"bug","color":"fc2929"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/angular-ui/ng-grid/milestones/12","html_url":"https://github.com/angular-ui/ng-grid/milestones/3.0","labels_url":"https://api.github.com/repos/angular-ui/ng-grid/milestones/12/labels","id":435248,"number":12,"title":"3.0","description":"","creator":{"login":"timothyswt","id":1736223,"avatar_url":"https://avatars.githubusercontent.com/u/1736223?v=3","gravatar_id":"","url":"https://api.github.com/users/timothyswt","html_url":"https://github.com/timothyswt","followers_url":"https://api.github.com/users/timothyswt/followers","following_url":"https://api.github.com/users/timothyswt/following{/other_user}","gists_url":"https://api.github.com/users/timothyswt/gists{/gist_id}","starred_url":"https://api.github.com/users/timothyswt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timothyswt/subscriptions","organizations_url":"https://api.github.com/users/timothyswt/orgs","repos_url":"https://api.github.com/users/timothyswt/repos","events_url":"https://api.github.com/users/timothyswt/events{/privacy}","received_events_url":"https://api.github.com/users/timothyswt/received_events","type":"User","site_admin":false},"open_issues":52,"closed_issues":599,"state":"open","created_at":"2013-09-24T04:48:10Z","updated_at":"2015-03-30T17:52:27Z","due_on":null,"closed_at":null},"comments":7,"created_at":"2015-03-28T00:00:16Z","updated_at":"2015-03-30T18:40:49Z","closed_at":null,"body":"Here's a plunker based on the filtering tutorial [(click here)](http://plnkr.co/edit/3rY4J0GjVCuouuwFske0?p=preview). Press 'Toggle Filtering' button and nothing happens.\r\n\r\nBasically, if you have selection header present and filtering is disabled initially and you get all the column definitions asynchronously and then enabled filtering it does not recalculate the header heights correctly even though the elements are there in the DOM with right heights but its container has a normal (non-filter) height.\r\n\r\nThis is pretty major for us since we always load column definitions from the db."},"comment":{"url":"https://api.github.com/repos/angular-ui/ng-grid/issues/comments/87785761","html_url":"https://github.com/angular-ui/ng-grid/issues/3138#issuecomment-87785761","issue_url":"https://api.github.com/repos/angular-ui/ng-grid/issues/3138","id":87785761,"user":{"login":"PaulL1","id":5248789,"avatar_url":"https://avatars.githubusercontent.com/u/5248789?v=3","gravatar_id":"","url":"https://api.github.com/users/PaulL1","html_url":"https://github.com/PaulL1","followers_url":"https://api.github.com/users/PaulL1/followers","following_url":"https://api.github.com/users/PaulL1/following{/other_user}","gists_url":"https://api.github.com/users/PaulL1/gists{/gist_id}","starred_url":"https://api.github.com/users/PaulL1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PaulL1/subscriptions","organizations_url":"https://api.github.com/users/PaulL1/orgs","repos_url":"https://api.github.com/users/PaulL1/repos","events_url":"https://api.github.com/users/PaulL1/events{/privacy}","received_events_url":"https://api.github.com/users/PaulL1/received_events","type":"User","site_admin":false},"created_at":"2015-03-30T18:40:49Z","updated_at":"2015-03-30T18:40:49Z","body":"The explicit header height had a bit of a smell about it for me. It felt like we dynamically calculate then store on the header, next time we calculate we can then only go up not down. If we're going to ignore the stored value then why store it at all?\n\nSent from my iPhone\n\n> On 31 Mar 2015, at 7:06 am, Brian Hann <notifications@github.com> wrote:\n> \n> @yurigenin Ah, thanks for the diagnosis.\n> \n> I think what needs to happen is have the header recalculation ignore any header heights that are set explicitly when calculating the \"minimum\" required height. That lets any non-explicit headers set the height and any explicit ones can shrink.\n> \n> —\n> Reply to this email directly or view it on GitHub.\n> \n"}}