{"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/26303694","id":26303694,"diff_hunk":"@@ -749,9 +749,12 @@ def addDisk(backingFile, sizeInMB, label=nil, summary=nil, thinProvisioned=false\n \t\t\t\t\t\t    con.startConnected\t\t= \"true\"\n \t\t\t\t\t\t    con.connected\t\t\t= \"true\"\n \t\t\t\t\t\tend\n+\t\t\t\t\t\tmode = (dependent ? \n+\t\t\t\t\t\t\t  (persistent ? VirtualDiskMode::Persistent : VirtualDiskMode::Nonpersistent ) \n+\t\t\t\t\t\t\t: (persistent ? VirtualDiskMode::Independent_persistent : VirtualDiskMode::Independent_nonpersistent )\n+\t\t\t\t\t\t)","path":"lib/VMwareWebService/MiqVimVm.rb","position":16,"original_position":16,"commit_id":"b26d8825f617f8c9db40a2dbb468d8148c3b153f","original_commit_id":"b26d8825f617f8c9db40a2dbb468d8148c3b153f","user":{"login":"Fryguy","id":52120,"avatar_url":"https://avatars.githubusercontent.com/u/52120?v=3","gravatar_id":"","url":"https://api.github.com/users/Fryguy","html_url":"https://github.com/Fryguy","followers_url":"https://api.github.com/users/Fryguy/followers","following_url":"https://api.github.com/users/Fryguy/following{/other_user}","gists_url":"https://api.github.com/users/Fryguy/gists{/gist_id}","starred_url":"https://api.github.com/users/Fryguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fryguy/subscriptions","organizations_url":"https://api.github.com/users/Fryguy/orgs","repos_url":"https://api.github.com/users/Fryguy/repos","events_url":"https://api.github.com/users/Fryguy/events{/privacy}","received_events_url":"https://api.github.com/users/Fryguy/received_events","type":"User","site_admin":false},"body":"This nesting of ternarys is pretty nasty, and nesting of them is generally avoided (rubocop picked it out too).  Can you make the outer case a normal if/else?\r\n","created_at":"2015-03-12T14:10:59Z","updated_at":"2015-03-12T14:10:59Z","html_url":"https://github.com/ManageIQ/manageiq/pull/2111#discussion_r26303694","pull_request_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/2111","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/26303694"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/2111#discussion_r26303694"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/2111"}}},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/2111","id":31020299,"html_url":"https://github.com/ManageIQ/manageiq/pull/2111","diff_url":"https://github.com/ManageIQ/manageiq/pull/2111.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/2111.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/2111","number":2111,"state":"open","locked":false,"title":"Add dependent and persistent options into vm_add_disk method","user":{"login":"avasyukov","id":520257,"avatar_url":"https://avatars.githubusercontent.com/u/520257?v=3","gravatar_id":"","url":"https://api.github.com/users/avasyukov","html_url":"https://github.com/avasyukov","followers_url":"https://api.github.com/users/avasyukov/followers","following_url":"https://api.github.com/users/avasyukov/following{/other_user}","gists_url":"https://api.github.com/users/avasyukov/gists{/gist_id}","starred_url":"https://api.github.com/users/avasyukov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avasyukov/subscriptions","organizations_url":"https://api.github.com/users/avasyukov/orgs","repos_url":"https://api.github.com/users/avasyukov/repos","events_url":"https://api.github.com/users/avasyukov/events{/privacy}","received_events_url":"https://api.github.com/users/avasyukov/received_events","type":"User","site_admin":false},"body":"Hello Team. One more pull request related to disks on VMware.\r\n\r\nCurrent addDisk method creates new disk as VirtualDiskMode::Independent_persistent, and it's not always good.\r\n\r\nThe major issue is that independent disks can not be shapshoted live. So, if one attaches such disk to VM, this VM can not be cloned anymore without powering it off. VMware error looks like this:\r\n<pre>\r\nVirtual machine is configured to use a device that prevents the operation: \r\ncom.vmware.vim.binding.vmodl.fault.SystemError: reason = This operation is not supported with virtual disks \r\nin independent mode or raw disk mappings in physical compatibility mode inherited from \r\ncom.vmware.vim.binding.vmodl.fault.SystemError: A general system error occurred: This operation is not supported \r\nwith virtual disks in independent mode or raw disk mappings in physical compatibility mode\r\n</pre>\r\n\r\nNew parameters allow to choose disk provisioning mode in custom scripts. Default behaviour left unchanged - without new params disk is added as VirtualDiskMode::Independent_persistent.","created_at":"2015-03-12T09:45:45Z","updated_at":"2015-03-12T14:10:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7c8a86f5b1db3829cb1a349cdb608ca9ccef8b83","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/2111/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/2111/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/2111/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/b26d8825f617f8c9db40a2dbb468d8148c3b153f","head":{"label":"ITDSystems:add_dependent_and_persistent_options_into_vm_add_disk_method","ref":"add_dependent_and_persistent_options_into_vm_add_disk_method","sha":"b26d8825f617f8c9db40a2dbb468d8148c3b153f","user":{"login":"ITDSystems","id":1713846,"avatar_url":"https://avatars.githubusercontent.com/u/1713846?v=3","gravatar_id":"","url":"https://api.github.com/users/ITDSystems","html_url":"https://github.com/ITDSystems","followers_url":"https://api.github.com/users/ITDSystems/followers","following_url":"https://api.github.com/users/ITDSystems/following{/other_user}","gists_url":"https://api.github.com/users/ITDSystems/gists{/gist_id}","starred_url":"https://api.github.com/users/ITDSystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ITDSystems/subscriptions","organizations_url":"https://api.github.com/users/ITDSystems/orgs","repos_url":"https://api.github.com/users/ITDSystems/repos","events_url":"https://api.github.com/users/ITDSystems/events{/privacy}","received_events_url":"https://api.github.com/users/ITDSystems/received_events","type":"Organization","site_admin":false},"repo":{"id":30655102,"name":"manageiq","full_name":"ITDSystems/manageiq","owner":{"login":"ITDSystems","id":1713846,"avatar_url":"https://avatars.githubusercontent.com/u/1713846?v=3","gravatar_id":"","url":"https://api.github.com/users/ITDSystems","html_url":"https://github.com/ITDSystems","followers_url":"https://api.github.com/users/ITDSystems/followers","following_url":"https://api.github.com/users/ITDSystems/following{/other_user}","gists_url":"https://api.github.com/users/ITDSystems/gists{/gist_id}","starred_url":"https://api.github.com/users/ITDSystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ITDSystems/subscriptions","organizations_url":"https://api.github.com/users/ITDSystems/orgs","repos_url":"https://api.github.com/users/ITDSystems/repos","events_url":"https://api.github.com/users/ITDSystems/events{/privacy}","received_events_url":"https://api.github.com/users/ITDSystems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ITDSystems/manageiq","description":"ManageIQ Cloud Management Platform","fork":true,"url":"https://api.github.com/repos/ITDSystems/manageiq","forks_url":"https://api.github.com/repos/ITDSystems/manageiq/forks","keys_url":"https://api.github.com/repos/ITDSystems/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ITDSystems/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ITDSystems/manageiq/teams","hooks_url":"https://api.github.com/repos/ITDSystems/manageiq/hooks","issue_events_url":"https://api.github.com/repos/ITDSystems/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/ITDSystems/manageiq/events","assignees_url":"https://api.github.com/repos/ITDSystems/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/ITDSystems/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/ITDSystems/manageiq/tags","blobs_url":"https://api.github.com/repos/ITDSystems/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ITDSystems/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ITDSystems/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/ITDSystems/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ITDSystems/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/ITDSystems/manageiq/languages","stargazers_url":"https://api.github.com/repos/ITDSystems/manageiq/stargazers","contributors_url":"https://api.github.com/repos/ITDSystems/manageiq/contributors","subscribers_url":"https://api.github.com/repos/ITDSystems/manageiq/subscribers","subscription_url":"https://api.github.com/repos/ITDSystems/manageiq/subscription","commits_url":"https://api.github.com/repos/ITDSystems/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/ITDSystems/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/ITDSystems/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/ITDSystems/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/ITDSystems/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/ITDSystems/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ITDSystems/manageiq/merges","archive_url":"https://api.github.com/repos/ITDSystems/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ITDSystems/manageiq/downloads","issues_url":"https://api.github.com/repos/ITDSystems/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/ITDSystems/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/ITDSystems/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/ITDSystems/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ITDSystems/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/ITDSystems/manageiq/releases{/id}","created_at":"2015-02-11T15:44:37Z","updated_at":"2015-03-12T09:07:08Z","pushed_at":"2015-03-12T09:36:02Z","git_url":"git://github.com/ITDSystems/manageiq.git","ssh_url":"git@github.com:ITDSystems/manageiq.git","clone_url":"https://github.com/ITDSystems/manageiq.git","svn_url":"https://github.com/ITDSystems/manageiq","homepage":"manageiq.org","size":65562,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"23366fc1c84cc5d18c8f70f3023f7538d17894b1","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":20789757,"name":"manageiq","full_name":"ManageIQ/manageiq","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq","description":"ManageIQ Cloud Management Platform","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq","forks_url":"https://api.github.com/repos/ManageIQ/manageiq/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq/releases{/id}","created_at":"2014-06-13T02:31:26Z","updated_at":"2015-03-12T13:44:41Z","pushed_at":"2015-03-12T13:44:41Z","git_url":"git://github.com/ManageIQ/manageiq.git","ssh_url":"git@github.com:ManageIQ/manageiq.git","clone_url":"https://github.com/ManageIQ/manageiq.git","svn_url":"https://github.com/ManageIQ/manageiq","homepage":"manageiq.org","size":105173,"stargazers_count":96,"watchers_count":96,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":92,"mirror_url":null,"open_issues_count":303,"forks":92,"open_issues":303,"watchers":96,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/2111"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/2111"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/2111"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/2111/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/2111/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/2111/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq/statuses/b26d8825f617f8c9db40a2dbb468d8148c3b153f"}}}}