{"action":"created","comment":{"url":"https://api.github.com/repos/neo4j/neo4j/pulls/comments/24800676","id":24800676,"diff_hunk":"@@ -69,10 +69,7 @@ case class ExecuteUpdateCommandsPipe(source: Pipe, commands: Seq[UpdateAction])(\n \n   def sourceSymbols: SymbolTable = source.symbols\n \n-  override def localEffects = source match {\n-    case pipe: ExecuteUpdateCommandsPipe => pipe.source.localEffects\n-    case _ => commands.effects(source.symbols)\n-  }\n+  override def localEffects = commands.effects(sourceSymbols)","path":"community/cypher/cypher-compiler-2.2/src/main/scala/org/neo4j/cypher/internal/compiler/v2_2/pipes/ExecuteUpdateCommandsPipe.scala","position":21,"original_position":21,"commit_id":"e72924f21e86074e65e34d317fe4e276c369654b","original_commit_id":"e72924f21e86074e65e34d317fe4e276c369654b","user":{"login":"pontusmelke","id":88000,"avatar_url":"https://avatars.githubusercontent.com/u/88000?v=3","gravatar_id":"","url":"https://api.github.com/users/pontusmelke","html_url":"https://github.com/pontusmelke","followers_url":"https://api.github.com/users/pontusmelke/followers","following_url":"https://api.github.com/users/pontusmelke/following{/other_user}","gists_url":"https://api.github.com/users/pontusmelke/gists{/gist_id}","starred_url":"https://api.github.com/users/pontusmelke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pontusmelke/subscriptions","organizations_url":"https://api.github.com/users/pontusmelke/orgs","repos_url":"https://api.github.com/users/pontusmelke/repos","events_url":"https://api.github.com/users/pontusmelke/events{/privacy}","received_events_url":"https://api.github.com/users/pontusmelke/received_events","type":"User","site_admin":false},"body":"I remember fixing this once, there were failures when you had a `ExecuteCommandsPipe` on top of a `ExecuteCommandsPipe`, in that case it was wrong to just look at the commands. Have these refactorings removed that problem?","created_at":"2015-02-17T08:54:01Z","updated_at":"2015-02-17T08:54:01Z","html_url":"https://github.com/neo4j/neo4j/pull/4024#discussion_r24800676","pull_request_url":"https://api.github.com/repos/neo4j/neo4j/pulls/4024","_links":{"self":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/comments/24800676"},"html":{"href":"https://github.com/neo4j/neo4j/pull/4024#discussion_r24800676"},"pull_request":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/4024"}}},"pull_request":{"url":"https://api.github.com/repos/neo4j/neo4j/pulls/4024","id":29382987,"html_url":"https://github.com/neo4j/neo4j/pull/4024","diff_url":"https://github.com/neo4j/neo4j/pull/4024.diff","patch_url":"https://github.com/neo4j/neo4j/pull/4024.patch","issue_url":"https://api.github.com/repos/neo4j/neo4j/issues/4024","number":4024,"state":"open","locked":false,"title":"Fix wrong `localEffects` definitions in several pipes","user":{"login":"davidegrohmann","id":6573166,"avatar_url":"https://avatars.githubusercontent.com/u/6573166?v=3","gravatar_id":"","url":"https://api.github.com/users/davidegrohmann","html_url":"https://github.com/davidegrohmann","followers_url":"https://api.github.com/users/davidegrohmann/followers","following_url":"https://api.github.com/users/davidegrohmann/following{/other_user}","gists_url":"https://api.github.com/users/davidegrohmann/gists{/gist_id}","starred_url":"https://api.github.com/users/davidegrohmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidegrohmann/subscriptions","organizations_url":"https://api.github.com/users/davidegrohmann/orgs","repos_url":"https://api.github.com/users/davidegrohmann/repos","events_url":"https://api.github.com/users/davidegrohmann/events{/privacy}","received_events_url":"https://api.github.com/users/davidegrohmann/received_events","type":"User","site_admin":false},"body":"In particular `ArgumentPipe` was missing to override `localEffects` and the default implementation in `Pipe` was declaring `Effects.ALL` which is wrong for a read-only pipe.\r\n\r\nIn order to force correct definitions of `localEffects` in pipes, the default implementation has been removed from the Pipe trait.","created_at":"2015-02-16T15:59:40Z","updated_at":"2015-02-17T08:54:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fe68ed66a87d8c6f27df2a6083e072b9057442d9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/neo4j/neo4j/pulls/4024/commits","review_comments_url":"https://api.github.com/repos/neo4j/neo4j/pulls/4024/comments","review_comment_url":"https://api.github.com/repos/neo4j/neo4j/pulls/comments/{number}","comments_url":"https://api.github.com/repos/neo4j/neo4j/issues/4024/comments","statuses_url":"https://api.github.com/repos/neo4j/neo4j/statuses/e72924f21e86074e65e34d317fe4e276c369654b","head":{"label":"davidegrohmann:2.2-resolve-problems-with-effects","ref":"2.2-resolve-problems-with-effects","sha":"e72924f21e86074e65e34d317fe4e276c369654b","user":{"login":"davidegrohmann","id":6573166,"avatar_url":"https://avatars.githubusercontent.com/u/6573166?v=3","gravatar_id":"","url":"https://api.github.com/users/davidegrohmann","html_url":"https://github.com/davidegrohmann","followers_url":"https://api.github.com/users/davidegrohmann/followers","following_url":"https://api.github.com/users/davidegrohmann/following{/other_user}","gists_url":"https://api.github.com/users/davidegrohmann/gists{/gist_id}","starred_url":"https://api.github.com/users/davidegrohmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidegrohmann/subscriptions","organizations_url":"https://api.github.com/users/davidegrohmann/orgs","repos_url":"https://api.github.com/users/davidegrohmann/repos","events_url":"https://api.github.com/users/davidegrohmann/events{/privacy}","received_events_url":"https://api.github.com/users/davidegrohmann/received_events","type":"User","site_admin":false},"repo":{"id":16693960,"name":"neo4j","full_name":"davidegrohmann/neo4j","owner":{"login":"davidegrohmann","id":6573166,"avatar_url":"https://avatars.githubusercontent.com/u/6573166?v=3","gravatar_id":"","url":"https://api.github.com/users/davidegrohmann","html_url":"https://github.com/davidegrohmann","followers_url":"https://api.github.com/users/davidegrohmann/followers","following_url":"https://api.github.com/users/davidegrohmann/following{/other_user}","gists_url":"https://api.github.com/users/davidegrohmann/gists{/gist_id}","starred_url":"https://api.github.com/users/davidegrohmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidegrohmann/subscriptions","organizations_url":"https://api.github.com/users/davidegrohmann/orgs","repos_url":"https://api.github.com/users/davidegrohmann/repos","events_url":"https://api.github.com/users/davidegrohmann/events{/privacy}","received_events_url":"https://api.github.com/users/davidegrohmann/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/davidegrohmann/neo4j","description":"The World's Leading Graph Database","fork":true,"url":"https://api.github.com/repos/davidegrohmann/neo4j","forks_url":"https://api.github.com/repos/davidegrohmann/neo4j/forks","keys_url":"https://api.github.com/repos/davidegrohmann/neo4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/davidegrohmann/neo4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/davidegrohmann/neo4j/teams","hooks_url":"https://api.github.com/repos/davidegrohmann/neo4j/hooks","issue_events_url":"https://api.github.com/repos/davidegrohmann/neo4j/issues/events{/number}","events_url":"https://api.github.com/repos/davidegrohmann/neo4j/events","assignees_url":"https://api.github.com/repos/davidegrohmann/neo4j/assignees{/user}","branches_url":"https://api.github.com/repos/davidegrohmann/neo4j/branches{/branch}","tags_url":"https://api.github.com/repos/davidegrohmann/neo4j/tags","blobs_url":"https://api.github.com/repos/davidegrohmann/neo4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/davidegrohmann/neo4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/davidegrohmann/neo4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/davidegrohmann/neo4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/davidegrohmann/neo4j/statuses/{sha}","languages_url":"https://api.github.com/repos/davidegrohmann/neo4j/languages","stargazers_url":"https://api.github.com/repos/davidegrohmann/neo4j/stargazers","contributors_url":"https://api.github.com/repos/davidegrohmann/neo4j/contributors","subscribers_url":"https://api.github.com/repos/davidegrohmann/neo4j/subscribers","subscription_url":"https://api.github.com/repos/davidegrohmann/neo4j/subscription","commits_url":"https://api.github.com/repos/davidegrohmann/neo4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/davidegrohmann/neo4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/davidegrohmann/neo4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/davidegrohmann/neo4j/issues/comments/{number}","contents_url":"https://api.github.com/repos/davidegrohmann/neo4j/contents/{+path}","compare_url":"https://api.github.com/repos/davidegrohmann/neo4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/davidegrohmann/neo4j/merges","archive_url":"https://api.github.com/repos/davidegrohmann/neo4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/davidegrohmann/neo4j/downloads","issues_url":"https://api.github.com/repos/davidegrohmann/neo4j/issues{/number}","pulls_url":"https://api.github.com/repos/davidegrohmann/neo4j/pulls{/number}","milestones_url":"https://api.github.com/repos/davidegrohmann/neo4j/milestones{/number}","notifications_url":"https://api.github.com/repos/davidegrohmann/neo4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/davidegrohmann/neo4j/labels{/name}","releases_url":"https://api.github.com/repos/davidegrohmann/neo4j/releases{/id}","created_at":"2014-02-10T11:59:43Z","updated_at":"2014-06-19T09:04:32Z","pushed_at":"2015-02-16T15:57:59Z","git_url":"git://github.com/davidegrohmann/neo4j.git","ssh_url":"git@github.com:davidegrohmann/neo4j.git","clone_url":"https://github.com/davidegrohmann/neo4j.git","svn_url":"https://github.com/davidegrohmann/neo4j","homepage":"http://neo4j.org","size":174094,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"neo4j:master","ref":"master","sha":"18d9ce22c26cb53e8c7a737b73d515c0c4c4a0fe","user":{"login":"neo4j","id":201120,"avatar_url":"https://avatars.githubusercontent.com/u/201120?v=3","gravatar_id":"","url":"https://api.github.com/users/neo4j","html_url":"https://github.com/neo4j","followers_url":"https://api.github.com/users/neo4j/followers","following_url":"https://api.github.com/users/neo4j/following{/other_user}","gists_url":"https://api.github.com/users/neo4j/gists{/gist_id}","starred_url":"https://api.github.com/users/neo4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo4j/subscriptions","organizations_url":"https://api.github.com/users/neo4j/orgs","repos_url":"https://api.github.com/users/neo4j/repos","events_url":"https://api.github.com/users/neo4j/events{/privacy}","received_events_url":"https://api.github.com/users/neo4j/received_events","type":"Organization","site_admin":false},"repo":{"id":6650539,"name":"neo4j","full_name":"neo4j/neo4j","owner":{"login":"neo4j","id":201120,"avatar_url":"https://avatars.githubusercontent.com/u/201120?v=3","gravatar_id":"","url":"https://api.github.com/users/neo4j","html_url":"https://github.com/neo4j","followers_url":"https://api.github.com/users/neo4j/followers","following_url":"https://api.github.com/users/neo4j/following{/other_user}","gists_url":"https://api.github.com/users/neo4j/gists{/gist_id}","starred_url":"https://api.github.com/users/neo4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo4j/subscriptions","organizations_url":"https://api.github.com/users/neo4j/orgs","repos_url":"https://api.github.com/users/neo4j/repos","events_url":"https://api.github.com/users/neo4j/events{/privacy}","received_events_url":"https://api.github.com/users/neo4j/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neo4j/neo4j","description":"Graphs for Everyone","fork":false,"url":"https://api.github.com/repos/neo4j/neo4j","forks_url":"https://api.github.com/repos/neo4j/neo4j/forks","keys_url":"https://api.github.com/repos/neo4j/neo4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neo4j/neo4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neo4j/neo4j/teams","hooks_url":"https://api.github.com/repos/neo4j/neo4j/hooks","issue_events_url":"https://api.github.com/repos/neo4j/neo4j/issues/events{/number}","events_url":"https://api.github.com/repos/neo4j/neo4j/events","assignees_url":"https://api.github.com/repos/neo4j/neo4j/assignees{/user}","branches_url":"https://api.github.com/repos/neo4j/neo4j/branches{/branch}","tags_url":"https://api.github.com/repos/neo4j/neo4j/tags","blobs_url":"https://api.github.com/repos/neo4j/neo4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neo4j/neo4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neo4j/neo4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/neo4j/neo4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neo4j/neo4j/statuses/{sha}","languages_url":"https://api.github.com/repos/neo4j/neo4j/languages","stargazers_url":"https://api.github.com/repos/neo4j/neo4j/stargazers","contributors_url":"https://api.github.com/repos/neo4j/neo4j/contributors","subscribers_url":"https://api.github.com/repos/neo4j/neo4j/subscribers","subscription_url":"https://api.github.com/repos/neo4j/neo4j/subscription","commits_url":"https://api.github.com/repos/neo4j/neo4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/neo4j/neo4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/neo4j/neo4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/neo4j/neo4j/issues/comments/{number}","contents_url":"https://api.github.com/repos/neo4j/neo4j/contents/{+path}","compare_url":"https://api.github.com/repos/neo4j/neo4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neo4j/neo4j/merges","archive_url":"https://api.github.com/repos/neo4j/neo4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neo4j/neo4j/downloads","issues_url":"https://api.github.com/repos/neo4j/neo4j/issues{/number}","pulls_url":"https://api.github.com/repos/neo4j/neo4j/pulls{/number}","milestones_url":"https://api.github.com/repos/neo4j/neo4j/milestones{/number}","notifications_url":"https://api.github.com/repos/neo4j/neo4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neo4j/neo4j/labels{/name}","releases_url":"https://api.github.com/repos/neo4j/neo4j/releases{/id}","created_at":"2012-11-12T08:46:15Z","updated_at":"2015-02-17T08:45:31Z","pushed_at":"2015-02-17T08:45:30Z","git_url":"git://github.com/neo4j/neo4j.git","ssh_url":"git@github.com:neo4j/neo4j.git","clone_url":"https://github.com/neo4j/neo4j.git","svn_url":"https://github.com/neo4j/neo4j","homepage":"http://neo4j.com","size":382149,"stargazers_count":1475,"watchers_count":1475,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":613,"mirror_url":null,"open_issues_count":409,"forks":613,"open_issues":409,"watchers":1475,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/4024"},"html":{"href":"https://github.com/neo4j/neo4j/pull/4024"},"issue":{"href":"https://api.github.com/repos/neo4j/neo4j/issues/4024"},"comments":{"href":"https://api.github.com/repos/neo4j/neo4j/issues/4024/comments"},"review_comments":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/4024/comments"},"review_comment":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/4024/commits"},"statuses":{"href":"https://api.github.com/repos/neo4j/neo4j/statuses/e72924f21e86074e65e34d317fe4e276c369654b"}}}}