{"action":"closed","number":23747,"pull_request":{"url":"https://api.github.com/repos/saltstack/salt/pulls/23747","id":35464976,"html_url":"https://github.com/saltstack/salt/pull/23747","diff_url":"https://github.com/saltstack/salt/pull/23747.diff","patch_url":"https://github.com/saltstack/salt/pull/23747.patch","issue_url":"https://api.github.com/repos/saltstack/salt/issues/23747","number":23747,"state":"closed","locked":false,"title":"x509 extension handling fix #23696","user":{"login":"gladiatr72","id":999016,"avatar_url":"https://avatars.githubusercontent.com/u/999016?v=3","gravatar_id":"","url":"https://api.github.com/users/gladiatr72","html_url":"https://github.com/gladiatr72","followers_url":"https://api.github.com/users/gladiatr72/followers","following_url":"https://api.github.com/users/gladiatr72/following{/other_user}","gists_url":"https://api.github.com/users/gladiatr72/gists{/gist_id}","starred_url":"https://api.github.com/users/gladiatr72/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gladiatr72/subscriptions","organizations_url":"https://api.github.com/users/gladiatr72/orgs","repos_url":"https://api.github.com/users/gladiatr72/repos","events_url":"https://api.github.com/users/gladiatr72/events{/privacy}","received_events_url":"https://api.github.com/users/gladiatr72/received_events","type":"User","site_admin":false},"body":". ``__virtual__()``\r\n    - now with a version-specific check and log message\r\n\r\n. ``tls.get_extensions()``\r\n    - new.  given 'server' or 'client' as an argument, returns a dict\r\n      with use-appropriate extension strings\r\n\r\n. ``tls.create_csr()``\r\n    - collects user-defined or common extensions (from above), adds the\r\n      subjectAltName extension if subjectAltName is set\r\n    - a little type checking in case a single subjectAltName value is\r\n      passed (str not list)\r\n\r\n. ``tls.create_ca_signed_cert()``\r\n    - try req.get_extensions() before the Dark Magic\r\n    - emit version-specific error message about pyOpenSSL version wrt extensions\r\n\r\n. Profit!","created_at":"2015-05-14T21:37:59Z","updated_at":"2015-05-15T18:12:59Z","closed_at":"2015-05-15T18:12:59Z","merged_at":"2015-05-15T18:12:59Z","merge_commit_sha":"8de9e67bde9d850dba05dd6b081727b18543accb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/saltstack/salt/pulls/23747/commits","review_comments_url":"https://api.github.com/repos/saltstack/salt/pulls/23747/comments","review_comment_url":"https://api.github.com/repos/saltstack/salt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/saltstack/salt/issues/23747/comments","statuses_url":"https://api.github.com/repos/saltstack/salt/statuses/ddc759eeedd47240a42a95abfd0c538db2bab2e6","head":{"label":"gladiatr72:tls_extension_work","ref":"tls_extension_work","sha":"ddc759eeedd47240a42a95abfd0c538db2bab2e6","user":{"login":"gladiatr72","id":999016,"avatar_url":"https://avatars.githubusercontent.com/u/999016?v=3","gravatar_id":"","url":"https://api.github.com/users/gladiatr72","html_url":"https://github.com/gladiatr72","followers_url":"https://api.github.com/users/gladiatr72/followers","following_url":"https://api.github.com/users/gladiatr72/following{/other_user}","gists_url":"https://api.github.com/users/gladiatr72/gists{/gist_id}","starred_url":"https://api.github.com/users/gladiatr72/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gladiatr72/subscriptions","organizations_url":"https://api.github.com/users/gladiatr72/orgs","repos_url":"https://api.github.com/users/gladiatr72/repos","events_url":"https://api.github.com/users/gladiatr72/events{/privacy}","received_events_url":"https://api.github.com/users/gladiatr72/received_events","type":"User","site_admin":false},"repo":{"id":12731075,"name":"salt","full_name":"gladiatr72/salt","owner":{"login":"gladiatr72","id":999016,"avatar_url":"https://avatars.githubusercontent.com/u/999016?v=3","gravatar_id":"","url":"https://api.github.com/users/gladiatr72","html_url":"https://github.com/gladiatr72","followers_url":"https://api.github.com/users/gladiatr72/followers","following_url":"https://api.github.com/users/gladiatr72/following{/other_user}","gists_url":"https://api.github.com/users/gladiatr72/gists{/gist_id}","starred_url":"https://api.github.com/users/gladiatr72/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gladiatr72/subscriptions","organizations_url":"https://api.github.com/users/gladiatr72/orgs","repos_url":"https://api.github.com/users/gladiatr72/repos","events_url":"https://api.github.com/users/gladiatr72/events{/privacy}","received_events_url":"https://api.github.com/users/gladiatr72/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gladiatr72/salt","description":"Central system and configuration manager ","fork":true,"url":"https://api.github.com/repos/gladiatr72/salt","forks_url":"https://api.github.com/repos/gladiatr72/salt/forks","keys_url":"https://api.github.com/repos/gladiatr72/salt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gladiatr72/salt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gladiatr72/salt/teams","hooks_url":"https://api.github.com/repos/gladiatr72/salt/hooks","issue_events_url":"https://api.github.com/repos/gladiatr72/salt/issues/events{/number}","events_url":"https://api.github.com/repos/gladiatr72/salt/events","assignees_url":"https://api.github.com/repos/gladiatr72/salt/assignees{/user}","branches_url":"https://api.github.com/repos/gladiatr72/salt/branches{/branch}","tags_url":"https://api.github.com/repos/gladiatr72/salt/tags","blobs_url":"https://api.github.com/repos/gladiatr72/salt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gladiatr72/salt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gladiatr72/salt/git/refs{/sha}","trees_url":"https://api.github.com/repos/gladiatr72/salt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gladiatr72/salt/statuses/{sha}","languages_url":"https://api.github.com/repos/gladiatr72/salt/languages","stargazers_url":"https://api.github.com/repos/gladiatr72/salt/stargazers","contributors_url":"https://api.github.com/repos/gladiatr72/salt/contributors","subscribers_url":"https://api.github.com/repos/gladiatr72/salt/subscribers","subscription_url":"https://api.github.com/repos/gladiatr72/salt/subscription","commits_url":"https://api.github.com/repos/gladiatr72/salt/commits{/sha}","git_commits_url":"https://api.github.com/repos/gladiatr72/salt/git/commits{/sha}","comments_url":"https://api.github.com/repos/gladiatr72/salt/comments{/number}","issue_comment_url":"https://api.github.com/repos/gladiatr72/salt/issues/comments{/number}","contents_url":"https://api.github.com/repos/gladiatr72/salt/contents/{+path}","compare_url":"https://api.github.com/repos/gladiatr72/salt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gladiatr72/salt/merges","archive_url":"https://api.github.com/repos/gladiatr72/salt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gladiatr72/salt/downloads","issues_url":"https://api.github.com/repos/gladiatr72/salt/issues{/number}","pulls_url":"https://api.github.com/repos/gladiatr72/salt/pulls{/number}","milestones_url":"https://api.github.com/repos/gladiatr72/salt/milestones{/number}","notifications_url":"https://api.github.com/repos/gladiatr72/salt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gladiatr72/salt/labels{/name}","releases_url":"https://api.github.com/repos/gladiatr72/salt/releases{/id}","created_at":"2013-09-10T13:59:30Z","updated_at":"2015-03-27T18:14:06Z","pushed_at":"2015-05-15T04:28:30Z","git_url":"git://github.com/gladiatr72/salt.git","ssh_url":"git@github.com:gladiatr72/salt.git","clone_url":"https://github.com/gladiatr72/salt.git","svn_url":"https://github.com/gladiatr72/salt","homepage":"saltstack.org","size":101630,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"saltstack:develop","ref":"develop","sha":"675a3748c72ebdbd029bb6be96ebf2bfe8828b52","user":{"login":"saltstack","id":1147473,"avatar_url":"https://avatars.githubusercontent.com/u/1147473?v=3","gravatar_id":"","url":"https://api.github.com/users/saltstack","html_url":"https://github.com/saltstack","followers_url":"https://api.github.com/users/saltstack/followers","following_url":"https://api.github.com/users/saltstack/following{/other_user}","gists_url":"https://api.github.com/users/saltstack/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack/subscriptions","organizations_url":"https://api.github.com/users/saltstack/orgs","repos_url":"https://api.github.com/users/saltstack/repos","events_url":"https://api.github.com/users/saltstack/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack/received_events","type":"Organization","site_admin":false},"repo":{"id":1390248,"name":"salt","full_name":"saltstack/salt","owner":{"login":"saltstack","id":1147473,"avatar_url":"https://avatars.githubusercontent.com/u/1147473?v=3","gravatar_id":"","url":"https://api.github.com/users/saltstack","html_url":"https://github.com/saltstack","followers_url":"https://api.github.com/users/saltstack/followers","following_url":"https://api.github.com/users/saltstack/following{/other_user}","gists_url":"https://api.github.com/users/saltstack/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack/subscriptions","organizations_url":"https://api.github.com/users/saltstack/orgs","repos_url":"https://api.github.com/users/saltstack/repos","events_url":"https://api.github.com/users/saltstack/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/saltstack/salt","description":"Infrastructure automation and management system","fork":false,"url":"https://api.github.com/repos/saltstack/salt","forks_url":"https://api.github.com/repos/saltstack/salt/forks","keys_url":"https://api.github.com/repos/saltstack/salt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saltstack/salt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saltstack/salt/teams","hooks_url":"https://api.github.com/repos/saltstack/salt/hooks","issue_events_url":"https://api.github.com/repos/saltstack/salt/issues/events{/number}","events_url":"https://api.github.com/repos/saltstack/salt/events","assignees_url":"https://api.github.com/repos/saltstack/salt/assignees{/user}","branches_url":"https://api.github.com/repos/saltstack/salt/branches{/branch}","tags_url":"https://api.github.com/repos/saltstack/salt/tags","blobs_url":"https://api.github.com/repos/saltstack/salt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saltstack/salt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saltstack/salt/git/refs{/sha}","trees_url":"https://api.github.com/repos/saltstack/salt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saltstack/salt/statuses/{sha}","languages_url":"https://api.github.com/repos/saltstack/salt/languages","stargazers_url":"https://api.github.com/repos/saltstack/salt/stargazers","contributors_url":"https://api.github.com/repos/saltstack/salt/contributors","subscribers_url":"https://api.github.com/repos/saltstack/salt/subscribers","subscription_url":"https://api.github.com/repos/saltstack/salt/subscription","commits_url":"https://api.github.com/repos/saltstack/salt/commits{/sha}","git_commits_url":"https://api.github.com/repos/saltstack/salt/git/commits{/sha}","comments_url":"https://api.github.com/repos/saltstack/salt/comments{/number}","issue_comment_url":"https://api.github.com/repos/saltstack/salt/issues/comments{/number}","contents_url":"https://api.github.com/repos/saltstack/salt/contents/{+path}","compare_url":"https://api.github.com/repos/saltstack/salt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saltstack/salt/merges","archive_url":"https://api.github.com/repos/saltstack/salt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saltstack/salt/downloads","issues_url":"https://api.github.com/repos/saltstack/salt/issues{/number}","pulls_url":"https://api.github.com/repos/saltstack/salt/pulls{/number}","milestones_url":"https://api.github.com/repos/saltstack/salt/milestones{/number}","notifications_url":"https://api.github.com/repos/saltstack/salt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saltstack/salt/labels{/name}","releases_url":"https://api.github.com/repos/saltstack/salt/releases{/id}","created_at":"2011-02-20T20:16:56Z","updated_at":"2015-05-15T11:42:34Z","pushed_at":"2015-05-15T18:12:59Z","git_url":"git://github.com/saltstack/salt.git","ssh_url":"git@github.com:saltstack/salt.git","clone_url":"https://github.com/saltstack/salt.git","svn_url":"https://github.com/saltstack/salt","homepage":"saltstack.com","size":228099,"stargazers_count":5136,"watchers_count":5136,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2143,"mirror_url":null,"open_issues_count":2569,"forks":2143,"open_issues":2569,"watchers":5136,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/saltstack/salt/pulls/23747"},"html":{"href":"https://github.com/saltstack/salt/pull/23747"},"issue":{"href":"https://api.github.com/repos/saltstack/salt/issues/23747"},"comments":{"href":"https://api.github.com/repos/saltstack/salt/issues/23747/comments"},"review_comments":{"href":"https://api.github.com/repos/saltstack/salt/pulls/23747/comments"},"review_comment":{"href":"https://api.github.com/repos/saltstack/salt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/saltstack/salt/pulls/23747/commits"},"statuses":{"href":"https://api.github.com/repos/saltstack/salt/statuses/ddc759eeedd47240a42a95abfd0c538db2bab2e6"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"thatch45","id":507599,"avatar_url":"https://avatars.githubusercontent.com/u/507599?v=3","gravatar_id":"","url":"https://api.github.com/users/thatch45","html_url":"https://github.com/thatch45","followers_url":"https://api.github.com/users/thatch45/followers","following_url":"https://api.github.com/users/thatch45/following{/other_user}","gists_url":"https://api.github.com/users/thatch45/gists{/gist_id}","starred_url":"https://api.github.com/users/thatch45/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thatch45/subscriptions","organizations_url":"https://api.github.com/users/thatch45/orgs","repos_url":"https://api.github.com/users/thatch45/repos","events_url":"https://api.github.com/users/thatch45/events{/privacy}","received_events_url":"https://api.github.com/users/thatch45/received_events","type":"User","site_admin":false},"comments":4,"review_comments":1,"commits":18,"additions":342,"deletions":27,"changed_files":4}}