{"action":"created","comment":{"url":"https://api.github.com/repos/aspnet/Mvc/pulls/comments/47305233","id":47305233,"diff_hunk":"@@ -19,20 +19,22 @@ public void ConfigureServices(IServiceCollection services)\n \n             services.Configure<RazorViewEngineOptions>(options =>\n             {\n-                options.FileProvider = new EmbeddedFileProvider(GetType().GetTypeInfo().Assembly, \"RazorEmbeddedViewsWebSite.EmbeddedResources\");\n+                // Base namespace matches the resources added to the assembly from the EmbeddedResources folder.\n+                options.FileProvider = new EmbeddedFileProvider(\n+                    GetType().GetTypeInfo().Assembly,\n+                    baseNamespace: \"EmbeddedViewSample.Web.EmbeddedResources\");\n             });\n         }\n \n         public void Configure(IApplicationBuilder app)\n         {\n-            app.UseCultureReplacer();\n-\n             app.UseMvc(routes =>\n             {\n                 routes.MapRoute(\"areaRoute\", \"{area:exists}/{controller}/{action}\");\n-                routes.MapRoute(\"default\",\n-                                \"{controller}/{action}/{id?}\",\n-                                new { controller = \"Home\", action = \"Index\" });\n+                routes.MapRoute(\n+                    \"default\",\n+                    \"{controller}/{action}/{id?}\",\n+                    new { controller = \"Home\", action = \"Index\" });","path":"samples/EmbeddedViewSample.Web/Startup.cs","position":34,"original_position":34,"commit_id":"6693b04bc2bea6fb0cc41304d4fb65bcb747e163","original_commit_id":"6693b04bc2bea6fb0cc41304d4fb65bcb747e163","user":{"login":"dougbu","id":6431421,"avatar_url":"https://avatars.githubusercontent.com/u/6431421?v=3","gravatar_id":"","url":"https://api.github.com/users/dougbu","html_url":"https://github.com/dougbu","followers_url":"https://api.github.com/users/dougbu/followers","following_url":"https://api.github.com/users/dougbu/following{/other_user}","gists_url":"https://api.github.com/users/dougbu/gists{/gist_id}","starred_url":"https://api.github.com/users/dougbu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dougbu/subscriptions","organizations_url":"https://api.github.com/users/dougbu/orgs","repos_url":"https://api.github.com/users/dougbu/repos","events_url":"https://api.github.com/users/dougbu/events{/privacy}","received_events_url":"https://api.github.com/users/dougbu/received_events","type":"User","site_admin":false},"body":"With the controller renames, `@Url.Action()` generates just `\"/\"` in `Index.cshtml`. @rynowak what is your opinion on the slightly-ambiguous expected results (`\"Hello test-user, this is /\"`) in the associated tests? See https://github.com/aspnet/Mvc/pull/3713/files#diff-2f8f009c117b95d88d3ea7fe56e0032eR23 for example.","created_at":"2015-12-10T23:58:36Z","updated_at":"2015-12-10T23:58:36Z","html_url":"https://github.com/aspnet/Mvc/pull/3713#discussion_r47305233","pull_request_url":"https://api.github.com/repos/aspnet/Mvc/pulls/3713","_links":{"self":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/comments/47305233"},"html":{"href":"https://github.com/aspnet/Mvc/pull/3713#discussion_r47305233"},"pull_request":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/3713"}}},"pull_request":{"url":"https://api.github.com/repos/aspnet/Mvc/pulls/3713","id":53164503,"html_url":"https://github.com/aspnet/Mvc/pull/3713","diff_url":"https://github.com/aspnet/Mvc/pull/3713.diff","patch_url":"https://github.com/aspnet/Mvc/pull/3713.patch","issue_url":"https://api.github.com/repos/aspnet/Mvc/issues/3713","number":3713,"state":"open","locked":false,"title":"MVC functional test cleanup part 1","user":{"login":"dougbu","id":6431421,"avatar_url":"https://avatars.githubusercontent.com/u/6431421?v=3","gravatar_id":"","url":"https://api.github.com/users/dougbu","html_url":"https://github.com/dougbu","followers_url":"https://api.github.com/users/dougbu/followers","following_url":"https://api.github.com/users/dougbu/following{/other_user}","gists_url":"https://api.github.com/users/dougbu/gists{/gist_id}","starred_url":"https://api.github.com/users/dougbu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dougbu/subscriptions","organizations_url":"https://api.github.com/users/dougbu/orgs","repos_url":"https://api.github.com/users/dougbu/repos","events_url":"https://api.github.com/users/dougbu/events{/privacy}","received_events_url":"https://api.github.com/users/dougbu/received_events","type":"User","site_admin":false},"body":"- #3612 (subpart 1 of 2)\r\n- delete six test web sites and associated tests entirely\r\n  - `ActionResultsWebSite`\r\n  - `ActivatorWebSite`\r\n  - `ControllerDiscoveryConventionsWebSite`\r\n  - `LoggingWebSite`\r\n  - `LowercaseUrlsWebSite`\r\n  - `ModelBindingWebSite`, now covered in integration tests\r\n  - remove now-unused `FilteredDefaultAssemblyProviderFixture`, `LoggingAssert` or `LoggingExtensions`\r\n- move six sites into `./samples`\r\n  - `CustomRouteWebSite` -> `CustomRouteSample.Web`\r\n  - `FormatFilterWebSite` -> `FormatFilterSample.Web`\r\n  - `InlineConstraintsWebSite` -> `InlineConstraintSample.Web` (now singular)\r\n  - `JsonPatchWebSite` -> `JsonPatchSample.Web`\r\n  - `LocalizationWebSite` -> `LocalizationSample.Web`\r\n  - `RazorEmbeddedViewsWebSite` -> `EmbeddedViewSample.Web` (no longer \"Razor\" and now singular)\r\n  - some cleanup e.g. removing `wwwroot`, test dependencies, etc.\r\n- correct \"license\" spelling in `ApplicationModelWebSite`","created_at":"2015-12-09T19:16:38Z","updated_at":"2015-12-10T23:58:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8a637b77090ca25c1fec57085e90d75cfc30d7c7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/aspnet/Mvc/pulls/3713/commits","review_comments_url":"https://api.github.com/repos/aspnet/Mvc/pulls/3713/comments","review_comment_url":"https://api.github.com/repos/aspnet/Mvc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aspnet/Mvc/issues/3713/comments","statuses_url":"https://api.github.com/repos/aspnet/Mvc/statuses/6693b04bc2bea6fb0cc41304d4fb65bcb747e163","head":{"label":"aspnet:dougbu/prune.functional.3612","ref":"dougbu/prune.functional.3612","sha":"6693b04bc2bea6fb0cc41304d4fb65bcb747e163","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":15126429,"name":"Mvc","full_name":"aspnet/Mvc","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/Mvc","description":"Model view controller framework for building dynamic web sites with clean separation of concerns, including the merged MVC, Web API, and Web Pages w/ Razor.","fork":false,"url":"https://api.github.com/repos/aspnet/Mvc","forks_url":"https://api.github.com/repos/aspnet/Mvc/forks","keys_url":"https://api.github.com/repos/aspnet/Mvc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/Mvc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/Mvc/teams","hooks_url":"https://api.github.com/repos/aspnet/Mvc/hooks","issue_events_url":"https://api.github.com/repos/aspnet/Mvc/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/Mvc/events","assignees_url":"https://api.github.com/repos/aspnet/Mvc/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/Mvc/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/Mvc/tags","blobs_url":"https://api.github.com/repos/aspnet/Mvc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/Mvc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/Mvc/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/Mvc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/Mvc/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/Mvc/languages","stargazers_url":"https://api.github.com/repos/aspnet/Mvc/stargazers","contributors_url":"https://api.github.com/repos/aspnet/Mvc/contributors","subscribers_url":"https://api.github.com/repos/aspnet/Mvc/subscribers","subscription_url":"https://api.github.com/repos/aspnet/Mvc/subscription","commits_url":"https://api.github.com/repos/aspnet/Mvc/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/Mvc/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/Mvc/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/Mvc/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/Mvc/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/Mvc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/Mvc/merges","archive_url":"https://api.github.com/repos/aspnet/Mvc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/Mvc/downloads","issues_url":"https://api.github.com/repos/aspnet/Mvc/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/Mvc/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/Mvc/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/Mvc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/Mvc/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/Mvc/releases{/id}","created_at":"2013-12-12T03:54:00Z","updated_at":"2015-12-10T22:21:23Z","pushed_at":"2015-12-10T23:40:09Z","git_url":"git://github.com/aspnet/Mvc.git","ssh_url":"git@github.com:aspnet/Mvc.git","clone_url":"https://github.com/aspnet/Mvc.git","svn_url":"https://github.com/aspnet/Mvc","homepage":"","size":25880,"stargazers_count":2497,"watchers_count":2497,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":969,"mirror_url":null,"open_issues_count":275,"forks":969,"open_issues":275,"watchers":2497,"default_branch":"dev"}},"base":{"label":"aspnet:dev","ref":"dev","sha":"3a7c9c73ed136508d06f4e935830ccceb708933f","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":15126429,"name":"Mvc","full_name":"aspnet/Mvc","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/Mvc","description":"Model view controller framework for building dynamic web sites with clean separation of concerns, including the merged MVC, Web API, and Web Pages w/ Razor.","fork":false,"url":"https://api.github.com/repos/aspnet/Mvc","forks_url":"https://api.github.com/repos/aspnet/Mvc/forks","keys_url":"https://api.github.com/repos/aspnet/Mvc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/Mvc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/Mvc/teams","hooks_url":"https://api.github.com/repos/aspnet/Mvc/hooks","issue_events_url":"https://api.github.com/repos/aspnet/Mvc/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/Mvc/events","assignees_url":"https://api.github.com/repos/aspnet/Mvc/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/Mvc/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/Mvc/tags","blobs_url":"https://api.github.com/repos/aspnet/Mvc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/Mvc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/Mvc/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/Mvc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/Mvc/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/Mvc/languages","stargazers_url":"https://api.github.com/repos/aspnet/Mvc/stargazers","contributors_url":"https://api.github.com/repos/aspnet/Mvc/contributors","subscribers_url":"https://api.github.com/repos/aspnet/Mvc/subscribers","subscription_url":"https://api.github.com/repos/aspnet/Mvc/subscription","commits_url":"https://api.github.com/repos/aspnet/Mvc/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/Mvc/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/Mvc/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/Mvc/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/Mvc/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/Mvc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/Mvc/merges","archive_url":"https://api.github.com/repos/aspnet/Mvc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/Mvc/downloads","issues_url":"https://api.github.com/repos/aspnet/Mvc/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/Mvc/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/Mvc/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/Mvc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/Mvc/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/Mvc/releases{/id}","created_at":"2013-12-12T03:54:00Z","updated_at":"2015-12-10T22:21:23Z","pushed_at":"2015-12-10T23:40:09Z","git_url":"git://github.com/aspnet/Mvc.git","ssh_url":"git@github.com:aspnet/Mvc.git","clone_url":"https://github.com/aspnet/Mvc.git","svn_url":"https://github.com/aspnet/Mvc","homepage":"","size":25880,"stargazers_count":2497,"watchers_count":2497,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":969,"mirror_url":null,"open_issues_count":275,"forks":969,"open_issues":275,"watchers":2497,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/3713"},"html":{"href":"https://github.com/aspnet/Mvc/pull/3713"},"issue":{"href":"https://api.github.com/repos/aspnet/Mvc/issues/3713"},"comments":{"href":"https://api.github.com/repos/aspnet/Mvc/issues/3713/comments"},"review_comments":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/3713/comments"},"review_comment":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/3713/commits"},"statuses":{"href":"https://api.github.com/repos/aspnet/Mvc/statuses/6693b04bc2bea6fb0cc41304d4fb65bcb747e163"}}}}