{"action":"opened","number":17945,"pull_request":{"url":"https://api.github.com/repos/twbs/bootstrap/pulls/17945","id":47857330,"html_url":"https://github.com/twbs/bootstrap/pull/17945","diff_url":"https://github.com/twbs/bootstrap/pull/17945.diff","patch_url":"https://github.com/twbs/bootstrap/pull/17945.patch","issue_url":"https://api.github.com/repos/twbs/bootstrap/issues/17945","number":17945,"state":"open","locked":false,"title":"Remove redundant `<span class=\"sr-only\">...</span>` for close buttons","user":{"login":"patrickhlauke","id":895831,"avatar_url":"https://avatars.githubusercontent.com/u/895831?v=3","gravatar_id":"","url":"https://api.github.com/users/patrickhlauke","html_url":"https://github.com/patrickhlauke","followers_url":"https://api.github.com/users/patrickhlauke/followers","following_url":"https://api.github.com/users/patrickhlauke/following{/other_user}","gists_url":"https://api.github.com/users/patrickhlauke/gists{/gist_id}","starred_url":"https://api.github.com/users/patrickhlauke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patrickhlauke/subscriptions","organizations_url":"https://api.github.com/users/patrickhlauke/orgs","repos_url":"https://api.github.com/users/patrickhlauke/repos","events_url":"https://api.github.com/users/patrickhlauke/events{/privacy}","received_events_url":"https://api.github.com/users/patrickhlauke/received_events","type":"User","site_admin":false},"body":"(plus minor heading/prose tweak). See https://twitter.com/thierrykoblentz/status/654707875869122560 for context (though discussion there suggest a different solution - doubling up `aria-label` and `title` - which I'm not sure would fly).\r\n\r\nreason for removing the `<span>` (rather than removing the `aria-label`) is that we seem to be favoring the latter in other parts of the docs.\r\n\r\n/cc @cvrebert @mdo ","created_at":"2015-10-16T00:01:31Z","updated_at":"2015-10-16T00:01:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":{"url":"https://api.github.com/repos/twbs/bootstrap/milestones/33","html_url":"https://github.com/twbs/bootstrap/milestones/v4.0.0-alpha.2","labels_url":"https://api.github.com/repos/twbs/bootstrap/milestones/33/labels","id":1263350,"number":33,"title":"v4.0.0-alpha.2","description":"","creator":{"login":"cvrebert","id":419884,"avatar_url":"https://avatars.githubusercontent.com/u/419884?v=3","gravatar_id":"","url":"https://api.github.com/users/cvrebert","html_url":"https://github.com/cvrebert","followers_url":"https://api.github.com/users/cvrebert/followers","following_url":"https://api.github.com/users/cvrebert/following{/other_user}","gists_url":"https://api.github.com/users/cvrebert/gists{/gist_id}","starred_url":"https://api.github.com/users/cvrebert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cvrebert/subscriptions","organizations_url":"https://api.github.com/users/cvrebert/orgs","repos_url":"https://api.github.com/users/cvrebert/repos","events_url":"https://api.github.com/users/cvrebert/events{/privacy}","received_events_url":"https://api.github.com/users/cvrebert/received_events","type":"User","site_admin":false},"open_issues":51,"closed_issues":238,"state":"open","created_at":"2015-08-19T20:07:07Z","updated_at":"2015-10-16T00:01:31Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/twbs/bootstrap/pulls/17945/commits","review_comments_url":"https://api.github.com/repos/twbs/bootstrap/pulls/17945/comments","review_comment_url":"https://api.github.com/repos/twbs/bootstrap/pulls/comments{/number}","comments_url":"https://api.github.com/repos/twbs/bootstrap/issues/17945/comments","statuses_url":"https://api.github.com/repos/twbs/bootstrap/statuses/68189e226921d0cfaec4922b723d030baa11a25c","head":{"label":"patrickhlauke:docs-redundant-sr","ref":"docs-redundant-sr","sha":"68189e226921d0cfaec4922b723d030baa11a25c","user":{"login":"patrickhlauke","id":895831,"avatar_url":"https://avatars.githubusercontent.com/u/895831?v=3","gravatar_id":"","url":"https://api.github.com/users/patrickhlauke","html_url":"https://github.com/patrickhlauke","followers_url":"https://api.github.com/users/patrickhlauke/followers","following_url":"https://api.github.com/users/patrickhlauke/following{/other_user}","gists_url":"https://api.github.com/users/patrickhlauke/gists{/gist_id}","starred_url":"https://api.github.com/users/patrickhlauke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patrickhlauke/subscriptions","organizations_url":"https://api.github.com/users/patrickhlauke/orgs","repos_url":"https://api.github.com/users/patrickhlauke/repos","events_url":"https://api.github.com/users/patrickhlauke/events{/privacy}","received_events_url":"https://api.github.com/users/patrickhlauke/received_events","type":"User","site_admin":false},"repo":{"id":7403377,"name":"bootstrap","full_name":"patrickhlauke/bootstrap","owner":{"login":"patrickhlauke","id":895831,"avatar_url":"https://avatars.githubusercontent.com/u/895831?v=3","gravatar_id":"","url":"https://api.github.com/users/patrickhlauke","html_url":"https://github.com/patrickhlauke","followers_url":"https://api.github.com/users/patrickhlauke/followers","following_url":"https://api.github.com/users/patrickhlauke/following{/other_user}","gists_url":"https://api.github.com/users/patrickhlauke/gists{/gist_id}","starred_url":"https://api.github.com/users/patrickhlauke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patrickhlauke/subscriptions","organizations_url":"https://api.github.com/users/patrickhlauke/orgs","repos_url":"https://api.github.com/users/patrickhlauke/repos","events_url":"https://api.github.com/users/patrickhlauke/events{/privacy}","received_events_url":"https://api.github.com/users/patrickhlauke/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/patrickhlauke/bootstrap","description":"The most popular HTML, CSS, and JavaScript framework for developing responsive, mobile first projects on the web.","fork":true,"url":"https://api.github.com/repos/patrickhlauke/bootstrap","forks_url":"https://api.github.com/repos/patrickhlauke/bootstrap/forks","keys_url":"https://api.github.com/repos/patrickhlauke/bootstrap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/patrickhlauke/bootstrap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/patrickhlauke/bootstrap/teams","hooks_url":"https://api.github.com/repos/patrickhlauke/bootstrap/hooks","issue_events_url":"https://api.github.com/repos/patrickhlauke/bootstrap/issues/events{/number}","events_url":"https://api.github.com/repos/patrickhlauke/bootstrap/events","assignees_url":"https://api.github.com/repos/patrickhlauke/bootstrap/assignees{/user}","branches_url":"https://api.github.com/repos/patrickhlauke/bootstrap/branches{/branch}","tags_url":"https://api.github.com/repos/patrickhlauke/bootstrap/tags","blobs_url":"https://api.github.com/repos/patrickhlauke/bootstrap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/patrickhlauke/bootstrap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/patrickhlauke/bootstrap/git/refs{/sha}","trees_url":"https://api.github.com/repos/patrickhlauke/bootstrap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/patrickhlauke/bootstrap/statuses/{sha}","languages_url":"https://api.github.com/repos/patrickhlauke/bootstrap/languages","stargazers_url":"https://api.github.com/repos/patrickhlauke/bootstrap/stargazers","contributors_url":"https://api.github.com/repos/patrickhlauke/bootstrap/contributors","subscribers_url":"https://api.github.com/repos/patrickhlauke/bootstrap/subscribers","subscription_url":"https://api.github.com/repos/patrickhlauke/bootstrap/subscription","commits_url":"https://api.github.com/repos/patrickhlauke/bootstrap/commits{/sha}","git_commits_url":"https://api.github.com/repos/patrickhlauke/bootstrap/git/commits{/sha}","comments_url":"https://api.github.com/repos/patrickhlauke/bootstrap/comments{/number}","issue_comment_url":"https://api.github.com/repos/patrickhlauke/bootstrap/issues/comments{/number}","contents_url":"https://api.github.com/repos/patrickhlauke/bootstrap/contents/{+path}","compare_url":"https://api.github.com/repos/patrickhlauke/bootstrap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/patrickhlauke/bootstrap/merges","archive_url":"https://api.github.com/repos/patrickhlauke/bootstrap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/patrickhlauke/bootstrap/downloads","issues_url":"https://api.github.com/repos/patrickhlauke/bootstrap/issues{/number}","pulls_url":"https://api.github.com/repos/patrickhlauke/bootstrap/pulls{/number}","milestones_url":"https://api.github.com/repos/patrickhlauke/bootstrap/milestones{/number}","notifications_url":"https://api.github.com/repos/patrickhlauke/bootstrap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/patrickhlauke/bootstrap/labels{/name}","releases_url":"https://api.github.com/repos/patrickhlauke/bootstrap/releases{/id}","created_at":"2013-01-02T07:08:51Z","updated_at":"2015-05-04T09:05:44Z","pushed_at":"2015-10-15T23:57:56Z","git_url":"git://github.com/patrickhlauke/bootstrap.git","ssh_url":"git@github.com:patrickhlauke/bootstrap.git","clone_url":"https://github.com/patrickhlauke/bootstrap.git","svn_url":"https://github.com/patrickhlauke/bootstrap","homepage":"http://getbootstrap.com","size":92238,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"twbs:v4-dev","ref":"v4-dev","sha":"724bf862885f57383f3a19ed46a6deab0f2322a6","user":{"login":"twbs","id":2918581,"avatar_url":"https://avatars.githubusercontent.com/u/2918581?v=3","gravatar_id":"","url":"https://api.github.com/users/twbs","html_url":"https://github.com/twbs","followers_url":"https://api.github.com/users/twbs/followers","following_url":"https://api.github.com/users/twbs/following{/other_user}","gists_url":"https://api.github.com/users/twbs/gists{/gist_id}","starred_url":"https://api.github.com/users/twbs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twbs/subscriptions","organizations_url":"https://api.github.com/users/twbs/orgs","repos_url":"https://api.github.com/users/twbs/repos","events_url":"https://api.github.com/users/twbs/events{/privacy}","received_events_url":"https://api.github.com/users/twbs/received_events","type":"Organization","site_admin":false},"repo":{"id":2126244,"name":"bootstrap","full_name":"twbs/bootstrap","owner":{"login":"twbs","id":2918581,"avatar_url":"https://avatars.githubusercontent.com/u/2918581?v=3","gravatar_id":"","url":"https://api.github.com/users/twbs","html_url":"https://github.com/twbs","followers_url":"https://api.github.com/users/twbs/followers","following_url":"https://api.github.com/users/twbs/following{/other_user}","gists_url":"https://api.github.com/users/twbs/gists{/gist_id}","starred_url":"https://api.github.com/users/twbs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twbs/subscriptions","organizations_url":"https://api.github.com/users/twbs/orgs","repos_url":"https://api.github.com/users/twbs/repos","events_url":"https://api.github.com/users/twbs/events{/privacy}","received_events_url":"https://api.github.com/users/twbs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/twbs/bootstrap","description":"The most popular HTML, CSS, and JavaScript framework for developing responsive, mobile first projects on the web.","fork":false,"url":"https://api.github.com/repos/twbs/bootstrap","forks_url":"https://api.github.com/repos/twbs/bootstrap/forks","keys_url":"https://api.github.com/repos/twbs/bootstrap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twbs/bootstrap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twbs/bootstrap/teams","hooks_url":"https://api.github.com/repos/twbs/bootstrap/hooks","issue_events_url":"https://api.github.com/repos/twbs/bootstrap/issues/events{/number}","events_url":"https://api.github.com/repos/twbs/bootstrap/events","assignees_url":"https://api.github.com/repos/twbs/bootstrap/assignees{/user}","branches_url":"https://api.github.com/repos/twbs/bootstrap/branches{/branch}","tags_url":"https://api.github.com/repos/twbs/bootstrap/tags","blobs_url":"https://api.github.com/repos/twbs/bootstrap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twbs/bootstrap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twbs/bootstrap/git/refs{/sha}","trees_url":"https://api.github.com/repos/twbs/bootstrap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twbs/bootstrap/statuses/{sha}","languages_url":"https://api.github.com/repos/twbs/bootstrap/languages","stargazers_url":"https://api.github.com/repos/twbs/bootstrap/stargazers","contributors_url":"https://api.github.com/repos/twbs/bootstrap/contributors","subscribers_url":"https://api.github.com/repos/twbs/bootstrap/subscribers","subscription_url":"https://api.github.com/repos/twbs/bootstrap/subscription","commits_url":"https://api.github.com/repos/twbs/bootstrap/commits{/sha}","git_commits_url":"https://api.github.com/repos/twbs/bootstrap/git/commits{/sha}","comments_url":"https://api.github.com/repos/twbs/bootstrap/comments{/number}","issue_comment_url":"https://api.github.com/repos/twbs/bootstrap/issues/comments{/number}","contents_url":"https://api.github.com/repos/twbs/bootstrap/contents/{+path}","compare_url":"https://api.github.com/repos/twbs/bootstrap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twbs/bootstrap/merges","archive_url":"https://api.github.com/repos/twbs/bootstrap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twbs/bootstrap/downloads","issues_url":"https://api.github.com/repos/twbs/bootstrap/issues{/number}","pulls_url":"https://api.github.com/repos/twbs/bootstrap/pulls{/number}","milestones_url":"https://api.github.com/repos/twbs/bootstrap/milestones{/number}","notifications_url":"https://api.github.com/repos/twbs/bootstrap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twbs/bootstrap/labels{/name}","releases_url":"https://api.github.com/repos/twbs/bootstrap/releases{/id}","created_at":"2011-07-29T21:19:00Z","updated_at":"2015-10-15T23:20:49Z","pushed_at":"2015-10-15T23:58:11Z","git_url":"git://github.com/twbs/bootstrap.git","ssh_url":"git@github.com:twbs/bootstrap.git","clone_url":"https://github.com/twbs/bootstrap.git","svn_url":"https://github.com/twbs/bootstrap","homepage":"http://getbootstrap.com","size":217861,"stargazers_count":87783,"watchers_count":87783,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":36528,"mirror_url":null,"open_issues_count":380,"forks":36528,"open_issues":380,"watchers":87783,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/twbs/bootstrap/pulls/17945"},"html":{"href":"https://github.com/twbs/bootstrap/pull/17945"},"issue":{"href":"https://api.github.com/repos/twbs/bootstrap/issues/17945"},"comments":{"href":"https://api.github.com/repos/twbs/bootstrap/issues/17945/comments"},"review_comments":{"href":"https://api.github.com/repos/twbs/bootstrap/pulls/17945/comments"},"review_comment":{"href":"https://api.github.com/repos/twbs/bootstrap/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/twbs/bootstrap/pulls/17945/commits"},"statuses":{"href":"https://api.github.com/repos/twbs/bootstrap/statuses/68189e226921d0cfaec4922b723d030baa11a25c"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":2,"deletions":12,"changed_files":3}}