{"action":"created","comment":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/22596659","id":22596659,"diff_hunk":"@@ -10,6 +10,7 @@\n \n #include <stdio.h>\n #include <string.h>\n+#include \"crypto/common.h\"","path":"src/arith_uint256.cpp","position":4,"original_position":4,"commit_id":"289706e9e526b8eb447a5de35e1e46f9b04142aa","original_commit_id":"289706e9e526b8eb447a5de35e1e46f9b04142aa","user":{"login":"sipa","id":548488,"avatar_url":"https://avatars.githubusercontent.com/u/548488?v=3","gravatar_id":"","url":"https://api.github.com/users/sipa","html_url":"https://github.com/sipa","followers_url":"https://api.github.com/users/sipa/followers","following_url":"https://api.github.com/users/sipa/following{/other_user}","gists_url":"https://api.github.com/users/sipa/gists{/gist_id}","starred_url":"https://api.github.com/users/sipa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sipa/subscriptions","organizations_url":"https://api.github.com/users/sipa/orgs","repos_url":"https://api.github.com/users/sipa/repos","events_url":"https://api.github.com/users/sipa/events{/privacy}","received_events_url":"https://api.github.com/users/sipa/received_events","type":"User","site_admin":false},"body":"I'm sorry to hear that you don't find fun in many of the much more interesting things you've been doing before, but no - we removed this from the policy because the cost is just not worth the benefits. It requires too much time from maintainers and people writing patches for a very tiny (but non-zero) benefit, so we reverted it for that reason.\r\n","created_at":"2015-01-07T16:30:33Z","updated_at":"2015-01-07T16:30:33Z","html_url":"https://github.com/bitcoin/bitcoin/pull/5510#discussion_r22596659","pull_request_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/5510","_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/22596659"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/5510#discussion_r22596659"},"pull_request":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/5510"}}},"pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/5510","id":26369921,"html_url":"https://github.com/bitcoin/bitcoin/pull/5510","diff_url":"https://github.com/bitcoin/bitcoin/pull/5510.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/5510.patch","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/5510","number":5510,"state":"open","locked":false,"title":"WIP: Big endian support","user":{"login":"laanwj","id":126646,"avatar_url":"https://avatars.githubusercontent.com/u/126646?v=3","gravatar_id":"","url":"https://api.github.com/users/laanwj","html_url":"https://github.com/laanwj","followers_url":"https://api.github.com/users/laanwj/followers","following_url":"https://api.github.com/users/laanwj/following{/other_user}","gists_url":"https://api.github.com/users/laanwj/gists{/gist_id}","starred_url":"https://api.github.com/users/laanwj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laanwj/subscriptions","organizations_url":"https://api.github.com/users/laanwj/orgs","repos_url":"https://api.github.com/users/laanwj/repos","events_url":"https://api.github.com/users/laanwj/events{/privacy}","received_events_url":"https://api.github.com/users/laanwj/received_events","type":"User","site_admin":false},"body":"Fix issue #888.\r\n\r\nThis has been structured so that each compatibility change is one commit that touches only one file. After the initial build change, they are independent.\r\n\r\nMost extensive changes are in **'src/serialize.h: base serialization level endianness neutrality'**. I had to replace READDATA and WRITEDATA with functions that take sized integer types to make use of the proper `endian.h` functions. I'm confident that the end result is the same, although this may require more tests.\r\n\r\nI've tested this on mipsbe32. \r\n\r\n- All tests pass\r\n- Testnet syncs correctly\r\n- Node can successfully function on P2P mainnet\r\n- Checked that data directory can be copied between endians with no adverse results (only peers.dat required special attention here)\r\n\r\nKnown issues (to be fixed before merge):\r\n\r\n- DNS seeding always comes with 0 results on BE\r\n","created_at":"2014-12-19T13:02:51Z","updated_at":"2015-01-07T16:30:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"09db201bd469611855546e7727da8ee924db3ef4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/5510/commits","review_comments_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/5510/comments","review_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/{number}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/5510/comments","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/289706e9e526b8eb447a5de35e1e46f9b04142aa","head":{"label":"laanwj:2014_12_bigendian","ref":"2014_12_bigendian","sha":"289706e9e526b8eb447a5de35e1e46f9b04142aa","user":{"login":"laanwj","id":126646,"avatar_url":"https://avatars.githubusercontent.com/u/126646?v=3","gravatar_id":"","url":"https://api.github.com/users/laanwj","html_url":"https://github.com/laanwj","followers_url":"https://api.github.com/users/laanwj/followers","following_url":"https://api.github.com/users/laanwj/following{/other_user}","gists_url":"https://api.github.com/users/laanwj/gists{/gist_id}","starred_url":"https://api.github.com/users/laanwj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laanwj/subscriptions","organizations_url":"https://api.github.com/users/laanwj/orgs","repos_url":"https://api.github.com/users/laanwj/repos","events_url":"https://api.github.com/users/laanwj/events{/privacy}","received_events_url":"https://api.github.com/users/laanwj/received_events","type":"User","site_admin":false},"repo":{"id":1750308,"name":"bitcoin","full_name":"laanwj/bitcoin","owner":{"login":"laanwj","id":126646,"avatar_url":"https://avatars.githubusercontent.com/u/126646?v=3","gravatar_id":"","url":"https://api.github.com/users/laanwj","html_url":"https://github.com/laanwj","followers_url":"https://api.github.com/users/laanwj/followers","following_url":"https://api.github.com/users/laanwj/following{/other_user}","gists_url":"https://api.github.com/users/laanwj/gists{/gist_id}","starred_url":"https://api.github.com/users/laanwj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laanwj/subscriptions","organizations_url":"https://api.github.com/users/laanwj/orgs","repos_url":"https://api.github.com/users/laanwj/repos","events_url":"https://api.github.com/users/laanwj/events{/privacy}","received_events_url":"https://api.github.com/users/laanwj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/laanwj/bitcoin","description":"Bitcoin integration/staging tree","fork":true,"url":"https://api.github.com/repos/laanwj/bitcoin","forks_url":"https://api.github.com/repos/laanwj/bitcoin/forks","keys_url":"https://api.github.com/repos/laanwj/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/laanwj/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/laanwj/bitcoin/teams","hooks_url":"https://api.github.com/repos/laanwj/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/laanwj/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/laanwj/bitcoin/events","assignees_url":"https://api.github.com/repos/laanwj/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/laanwj/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/laanwj/bitcoin/tags","blobs_url":"https://api.github.com/repos/laanwj/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/laanwj/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/laanwj/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/laanwj/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/laanwj/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/laanwj/bitcoin/languages","stargazers_url":"https://api.github.com/repos/laanwj/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/laanwj/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/laanwj/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/laanwj/bitcoin/subscription","commits_url":"https://api.github.com/repos/laanwj/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/laanwj/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/laanwj/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/laanwj/bitcoin/issues/comments/{number}","contents_url":"https://api.github.com/repos/laanwj/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/laanwj/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/laanwj/bitcoin/merges","archive_url":"https://api.github.com/repos/laanwj/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/laanwj/bitcoin/downloads","issues_url":"https://api.github.com/repos/laanwj/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/laanwj/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/laanwj/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/laanwj/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/laanwj/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/laanwj/bitcoin/releases{/id}","created_at":"2011-05-15T07:09:54Z","updated_at":"2014-11-19T15:29:28Z","pushed_at":"2015-01-05T16:39:14Z","git_url":"git://github.com/laanwj/bitcoin.git","ssh_url":"git@github.com:laanwj/bitcoin.git","clone_url":"https://github.com/laanwj/bitcoin.git","svn_url":"https://github.com/laanwj/bitcoin","homepage":"http://www.bitcoin.org","size":41648,"stargazers_count":8,"watchers_count":8,"language":"TypeScript","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":0,"forks":3,"open_issues":0,"watchers":8,"default_branch":"master"}},"base":{"label":"bitcoin:master","ref":"master","sha":"ec20fd74b89272a4f53337ccdf7683a7f52bab11","user":{"login":"bitcoin","id":528860,"avatar_url":"https://avatars.githubusercontent.com/u/528860?v=3","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"repo":{"id":1181927,"name":"bitcoin","full_name":"bitcoin/bitcoin","owner":{"login":"bitcoin","id":528860,"avatar_url":"https://avatars.githubusercontent.com/u/528860?v=3","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bitcoin/bitcoin","description":"Bitcoin Core integration/staging tree","fork":false,"url":"https://api.github.com/repos/bitcoin/bitcoin","forks_url":"https://api.github.com/repos/bitcoin/bitcoin/forks","keys_url":"https://api.github.com/repos/bitcoin/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoin/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoin/bitcoin/teams","hooks_url":"https://api.github.com/repos/bitcoin/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoin/bitcoin/events","assignees_url":"https://api.github.com/repos/bitcoin/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoin/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoin/bitcoin/tags","blobs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoin/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoin/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoin/bitcoin/languages","stargazers_url":"https://api.github.com/repos/bitcoin/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/bitcoin/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/bitcoin/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/bitcoin/bitcoin/subscription","commits_url":"https://api.github.com/repos/bitcoin/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoin/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments/{number}","contents_url":"https://api.github.com/repos/bitcoin/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoin/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoin/bitcoin/merges","archive_url":"https://api.github.com/repos/bitcoin/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoin/bitcoin/downloads","issues_url":"https://api.github.com/repos/bitcoin/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoin/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/bitcoin/bitcoin/releases{/id}","created_at":"2010-12-19T15:16:43Z","updated_at":"2015-01-07T16:14:49Z","pushed_at":"2015-01-07T15:27:36Z","git_url":"git://github.com/bitcoin/bitcoin.git","ssh_url":"git@github.com:bitcoin/bitcoin.git","clone_url":"https://github.com/bitcoin/bitcoin.git","svn_url":"https://github.com/bitcoin/bitcoin","homepage":"https://bitcoin.org/en/download","size":103832,"stargazers_count":6303,"watchers_count":6303,"language":"C++","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":4559,"mirror_url":null,"open_issues_count":432,"forks":4559,"open_issues":432,"watchers":6303,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/5510"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/5510"},"issue":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/5510"},"comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/5510/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/5510/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/5510/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoin/bitcoin/statuses/289706e9e526b8eb447a5de35e1e46f9b04142aa"}}}}