{"action":"created","comment":{"url":"https://api.github.com/repos/lookout/borderpatrol/pulls/comments/40969429","id":40969429,"diff_hunk":"@@ -31,7 +31,7 @@ case object EmptyIdentity extends Identity[Nothing]\n case class Id[+A](id: A) extends Identity[A]\n \n object Identity {\n-  def apply[A](a: A): Identity[A] =\n+  def apply[A](a: A): Id[A] =\n     Id(a)\n }","path":"core/src/main/scala/com/lookout/borderpatrol/auth/Identity.scala","position":7,"original_position":7,"commit_id":"3fb28638eada813562acbdf212ad53983344675f","original_commit_id":"3fb28638eada813562acbdf212ad53983344675f","user":{"login":"trane","id":36095,"avatar_url":"https://avatars.githubusercontent.com/u/36095?v=3","gravatar_id":"","url":"https://api.github.com/users/trane","html_url":"https://github.com/trane","followers_url":"https://api.github.com/users/trane/followers","following_url":"https://api.github.com/users/trane/following{/other_user}","gists_url":"https://api.github.com/users/trane/gists{/gist_id}","starred_url":"https://api.github.com/users/trane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trane/subscriptions","organizations_url":"https://api.github.com/users/trane/orgs","repos_url":"https://api.github.com/users/trane/repos","events_url":"https://api.github.com/users/trane/events{/privacy}","received_events_url":"https://api.github.com/users/trane/received_events","type":"User","site_admin":false},"body":"It's just a constructor for the `Identity` type. Since the non-empty version takes a parameter, it returns the non-empty type -- I was thinking of it like the constructor for `Option[A]` in scala:\r\n\r\n```\r\nOption(null) == None\r\nOption(1) == Some(1)\r\n```","created_at":"2015-10-01T21:36:01Z","updated_at":"2015-10-01T21:36:01Z","html_url":"https://github.com/lookout/borderpatrol/pull/73#discussion_r40969429","pull_request_url":"https://api.github.com/repos/lookout/borderpatrol/pulls/73","_links":{"self":{"href":"https://api.github.com/repos/lookout/borderpatrol/pulls/comments/40969429"},"html":{"href":"https://github.com/lookout/borderpatrol/pull/73#discussion_r40969429"},"pull_request":{"href":"https://api.github.com/repos/lookout/borderpatrol/pulls/73"}}},"pull_request":{"url":"https://api.github.com/repos/lookout/borderpatrol/pulls/73","id":46561962,"html_url":"https://github.com/lookout/borderpatrol/pull/73","diff_url":"https://github.com/lookout/borderpatrol/pull/73.diff","patch_url":"https://github.com/lookout/borderpatrol/pull/73.patch","issue_url":"https://api.github.com/repos/lookout/borderpatrol/issues/73","number":73,"state":"open","locked":false,"title":"Add LoginFilter for Keymaster","user":{"login":"trane","id":36095,"avatar_url":"https://avatars.githubusercontent.com/u/36095?v=3","gravatar_id":"","url":"https://api.github.com/users/trane","html_url":"https://github.com/trane","followers_url":"https://api.github.com/users/trane/followers","following_url":"https://api.github.com/users/trane/following{/other_user}","gists_url":"https://api.github.com/users/trane/gists{/gist_id}","starred_url":"https://api.github.com/users/trane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trane/subscriptions","organizations_url":"https://api.github.com/users/trane/orgs","repos_url":"https://api.github.com/users/trane/repos","events_url":"https://api.github.com/users/trane/events{/privacy}","received_events_url":"https://api.github.com/users/trane/received_events","type":"User","site_admin":false},"body":"This login filter will listen to the login service's POST and transform\r\nthe request into a IndentifyRequest[Credential] that Keymaster can\r\nunderstand. Once Keymaster has succesfully provided the identity, that\r\nidentity is saved to a new session pointer and the user is redirected to\r\ntheir original request location with a new cookie\r\n\r\nIt will also remove the old session, as it is no longer valid","created_at":"2015-10-01T18:52:57Z","updated_at":"2015-10-01T21:36:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d9d0d7a51eb542f8c2ed8196b71aa7225317d0eb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/lookout/borderpatrol/pulls/73/commits","review_comments_url":"https://api.github.com/repos/lookout/borderpatrol/pulls/73/comments","review_comment_url":"https://api.github.com/repos/lookout/borderpatrol/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lookout/borderpatrol/issues/73/comments","statuses_url":"https://api.github.com/repos/lookout/borderpatrol/statuses/3fb28638eada813562acbdf212ad53983344675f","head":{"label":"trane:moar_auth","ref":"moar_auth","sha":"3fb28638eada813562acbdf212ad53983344675f","user":{"login":"trane","id":36095,"avatar_url":"https://avatars.githubusercontent.com/u/36095?v=3","gravatar_id":"","url":"https://api.github.com/users/trane","html_url":"https://github.com/trane","followers_url":"https://api.github.com/users/trane/followers","following_url":"https://api.github.com/users/trane/following{/other_user}","gists_url":"https://api.github.com/users/trane/gists{/gist_id}","starred_url":"https://api.github.com/users/trane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trane/subscriptions","organizations_url":"https://api.github.com/users/trane/orgs","repos_url":"https://api.github.com/users/trane/repos","events_url":"https://api.github.com/users/trane/events{/privacy}","received_events_url":"https://api.github.com/users/trane/received_events","type":"User","site_admin":false},"repo":{"id":27352256,"name":"borderpatrol","full_name":"trane/borderpatrol","owner":{"login":"trane","id":36095,"avatar_url":"https://avatars.githubusercontent.com/u/36095?v=3","gravatar_id":"","url":"https://api.github.com/users/trane","html_url":"https://github.com/trane","followers_url":"https://api.github.com/users/trane/followers","following_url":"https://api.github.com/users/trane/following{/other_user}","gists_url":"https://api.github.com/users/trane/gists{/gist_id}","starred_url":"https://api.github.com/users/trane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trane/subscriptions","organizations_url":"https://api.github.com/users/trane/orgs","repos_url":"https://api.github.com/users/trane/repos","events_url":"https://api.github.com/users/trane/events{/privacy}","received_events_url":"https://api.github.com/users/trane/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/trane/borderpatrol","description":"Netty-version of Border Patrol service","fork":true,"url":"https://api.github.com/repos/trane/borderpatrol","forks_url":"https://api.github.com/repos/trane/borderpatrol/forks","keys_url":"https://api.github.com/repos/trane/borderpatrol/keys{/key_id}","collaborators_url":"https://api.github.com/repos/trane/borderpatrol/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/trane/borderpatrol/teams","hooks_url":"https://api.github.com/repos/trane/borderpatrol/hooks","issue_events_url":"https://api.github.com/repos/trane/borderpatrol/issues/events{/number}","events_url":"https://api.github.com/repos/trane/borderpatrol/events","assignees_url":"https://api.github.com/repos/trane/borderpatrol/assignees{/user}","branches_url":"https://api.github.com/repos/trane/borderpatrol/branches{/branch}","tags_url":"https://api.github.com/repos/trane/borderpatrol/tags","blobs_url":"https://api.github.com/repos/trane/borderpatrol/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/trane/borderpatrol/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/trane/borderpatrol/git/refs{/sha}","trees_url":"https://api.github.com/repos/trane/borderpatrol/git/trees{/sha}","statuses_url":"https://api.github.com/repos/trane/borderpatrol/statuses/{sha}","languages_url":"https://api.github.com/repos/trane/borderpatrol/languages","stargazers_url":"https://api.github.com/repos/trane/borderpatrol/stargazers","contributors_url":"https://api.github.com/repos/trane/borderpatrol/contributors","subscribers_url":"https://api.github.com/repos/trane/borderpatrol/subscribers","subscription_url":"https://api.github.com/repos/trane/borderpatrol/subscription","commits_url":"https://api.github.com/repos/trane/borderpatrol/commits{/sha}","git_commits_url":"https://api.github.com/repos/trane/borderpatrol/git/commits{/sha}","comments_url":"https://api.github.com/repos/trane/borderpatrol/comments{/number}","issue_comment_url":"https://api.github.com/repos/trane/borderpatrol/issues/comments{/number}","contents_url":"https://api.github.com/repos/trane/borderpatrol/contents/{+path}","compare_url":"https://api.github.com/repos/trane/borderpatrol/compare/{base}...{head}","merges_url":"https://api.github.com/repos/trane/borderpatrol/merges","archive_url":"https://api.github.com/repos/trane/borderpatrol/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/trane/borderpatrol/downloads","issues_url":"https://api.github.com/repos/trane/borderpatrol/issues{/number}","pulls_url":"https://api.github.com/repos/trane/borderpatrol/pulls{/number}","milestones_url":"https://api.github.com/repos/trane/borderpatrol/milestones{/number}","notifications_url":"https://api.github.com/repos/trane/borderpatrol/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/trane/borderpatrol/labels{/name}","releases_url":"https://api.github.com/repos/trane/borderpatrol/releases{/id}","created_at":"2014-11-30T22:24:22Z","updated_at":"2015-02-03T00:44:44Z","pushed_at":"2015-10-01T18:52:37Z","git_url":"git://github.com/trane/borderpatrol.git","ssh_url":"git@github.com:trane/borderpatrol.git","clone_url":"https://github.com/trane/borderpatrol.git","svn_url":"https://github.com/trane/borderpatrol","homepage":null,"size":697,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"lookout:master","ref":"master","sha":"40043d2c74d0883a71f8a91ec3f30fb4d4e7cf4c","user":{"login":"lookout","id":47237,"avatar_url":"https://avatars.githubusercontent.com/u/47237?v=3","gravatar_id":"","url":"https://api.github.com/users/lookout","html_url":"https://github.com/lookout","followers_url":"https://api.github.com/users/lookout/followers","following_url":"https://api.github.com/users/lookout/following{/other_user}","gists_url":"https://api.github.com/users/lookout/gists{/gist_id}","starred_url":"https://api.github.com/users/lookout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lookout/subscriptions","organizations_url":"https://api.github.com/users/lookout/orgs","repos_url":"https://api.github.com/users/lookout/repos","events_url":"https://api.github.com/users/lookout/events{/privacy}","received_events_url":"https://api.github.com/users/lookout/received_events","type":"Organization","site_admin":false},"repo":{"id":20500575,"name":"borderpatrol","full_name":"lookout/borderpatrol","owner":{"login":"lookout","id":47237,"avatar_url":"https://avatars.githubusercontent.com/u/47237?v=3","gravatar_id":"","url":"https://api.github.com/users/lookout","html_url":"https://github.com/lookout","followers_url":"https://api.github.com/users/lookout/followers","following_url":"https://api.github.com/users/lookout/following{/other_user}","gists_url":"https://api.github.com/users/lookout/gists{/gist_id}","starred_url":"https://api.github.com/users/lookout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lookout/subscriptions","organizations_url":"https://api.github.com/users/lookout/orgs","repos_url":"https://api.github.com/users/lookout/repos","events_url":"https://api.github.com/users/lookout/events{/privacy}","received_events_url":"https://api.github.com/users/lookout/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lookout/borderpatrol","description":"Functional library for web sessions and authentication in an SOA","fork":false,"url":"https://api.github.com/repos/lookout/borderpatrol","forks_url":"https://api.github.com/repos/lookout/borderpatrol/forks","keys_url":"https://api.github.com/repos/lookout/borderpatrol/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lookout/borderpatrol/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lookout/borderpatrol/teams","hooks_url":"https://api.github.com/repos/lookout/borderpatrol/hooks","issue_events_url":"https://api.github.com/repos/lookout/borderpatrol/issues/events{/number}","events_url":"https://api.github.com/repos/lookout/borderpatrol/events","assignees_url":"https://api.github.com/repos/lookout/borderpatrol/assignees{/user}","branches_url":"https://api.github.com/repos/lookout/borderpatrol/branches{/branch}","tags_url":"https://api.github.com/repos/lookout/borderpatrol/tags","blobs_url":"https://api.github.com/repos/lookout/borderpatrol/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lookout/borderpatrol/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lookout/borderpatrol/git/refs{/sha}","trees_url":"https://api.github.com/repos/lookout/borderpatrol/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lookout/borderpatrol/statuses/{sha}","languages_url":"https://api.github.com/repos/lookout/borderpatrol/languages","stargazers_url":"https://api.github.com/repos/lookout/borderpatrol/stargazers","contributors_url":"https://api.github.com/repos/lookout/borderpatrol/contributors","subscribers_url":"https://api.github.com/repos/lookout/borderpatrol/subscribers","subscription_url":"https://api.github.com/repos/lookout/borderpatrol/subscription","commits_url":"https://api.github.com/repos/lookout/borderpatrol/commits{/sha}","git_commits_url":"https://api.github.com/repos/lookout/borderpatrol/git/commits{/sha}","comments_url":"https://api.github.com/repos/lookout/borderpatrol/comments{/number}","issue_comment_url":"https://api.github.com/repos/lookout/borderpatrol/issues/comments{/number}","contents_url":"https://api.github.com/repos/lookout/borderpatrol/contents/{+path}","compare_url":"https://api.github.com/repos/lookout/borderpatrol/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lookout/borderpatrol/merges","archive_url":"https://api.github.com/repos/lookout/borderpatrol/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lookout/borderpatrol/downloads","issues_url":"https://api.github.com/repos/lookout/borderpatrol/issues{/number}","pulls_url":"https://api.github.com/repos/lookout/borderpatrol/pulls{/number}","milestones_url":"https://api.github.com/repos/lookout/borderpatrol/milestones{/number}","notifications_url":"https://api.github.com/repos/lookout/borderpatrol/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lookout/borderpatrol/labels{/name}","releases_url":"https://api.github.com/repos/lookout/borderpatrol/releases{/id}","created_at":"2014-06-04T21:00:49Z","updated_at":"2015-10-01T14:12:52Z","pushed_at":"2015-10-01T18:52:58Z","git_url":"git://github.com/lookout/borderpatrol.git","ssh_url":"git@github.com:lookout/borderpatrol.git","clone_url":"https://github.com/lookout/borderpatrol.git","svn_url":"https://github.com/lookout/borderpatrol","homepage":"http://hackers.lookout.com/2014/06/introducing-borderpatrol/","size":1589,"stargazers_count":15,"watchers_count":15,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":11,"mirror_url":null,"open_issues_count":28,"forks":11,"open_issues":28,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lookout/borderpatrol/pulls/73"},"html":{"href":"https://github.com/lookout/borderpatrol/pull/73"},"issue":{"href":"https://api.github.com/repos/lookout/borderpatrol/issues/73"},"comments":{"href":"https://api.github.com/repos/lookout/borderpatrol/issues/73/comments"},"review_comments":{"href":"https://api.github.com/repos/lookout/borderpatrol/pulls/73/comments"},"review_comment":{"href":"https://api.github.com/repos/lookout/borderpatrol/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lookout/borderpatrol/pulls/73/commits"},"statuses":{"href":"https://api.github.com/repos/lookout/borderpatrol/statuses/3fb28638eada813562acbdf212ad53983344675f"}}}}