{"action":"created","issue":{"url":"https://api.github.com/repos/balderdashy/waterline/issues/1070","labels_url":"https://api.github.com/repos/balderdashy/waterline/issues/1070/labels{/name}","comments_url":"https://api.github.com/repos/balderdashy/waterline/issues/1070/comments","events_url":"https://api.github.com/repos/balderdashy/waterline/issues/1070/events","html_url":"https://github.com/balderdashy/waterline/pull/1070","id":91545563,"number":1070,"title":"Add eslint for source code","user":{"login":"IanVS","id":4616705,"avatar_url":"https://avatars.githubusercontent.com/u/4616705?v=3","gravatar_id":"","url":"https://api.github.com/users/IanVS","html_url":"https://github.com/IanVS","followers_url":"https://api.github.com/users/IanVS/followers","following_url":"https://api.github.com/users/IanVS/following{/other_user}","gists_url":"https://api.github.com/users/IanVS/gists{/gist_id}","starred_url":"https://api.github.com/users/IanVS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IanVS/subscriptions","organizations_url":"https://api.github.com/users/IanVS/orgs","repos_url":"https://api.github.com/users/IanVS/repos","events_url":"https://api.github.com/users/IanVS/events{/privacy}","received_events_url":"https://api.github.com/users/IanVS/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":9,"created_at":"2015-06-28T02:56:25Z","updated_at":"2015-07-07T14:55:46Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/balderdashy/waterline/pulls/1070","html_url":"https://github.com/balderdashy/waterline/pull/1070","diff_url":"https://github.com/balderdashy/waterline/pull/1070.diff","patch_url":"https://github.com/balderdashy/waterline/pull/1070.patch"},"body":"I think @Globegitter has been pretty busy lately, so this is an offer to implement just the linting part of https://github.com/balderdashy/waterline/pull/935.  I am willing to go through and try to fix failing rules, but I would like to get consensus on what the rules should be prior to spending the effort.  With the rules from https://github.com/balderdashy/waterline/pull/935 (currently in this PR), I get the following results:\r\n\r\n![screenshot from 2015-06-27 22 28 28](https://cloud.githubusercontent.com/assets/4616705/8394930/ae6ac2a4-1d1c-11e5-826f-3a9317fd0519.png)\r\n\r\n(Note that all these screenshots are cropped on the right, a few bars are much longer)\r\n\r\nAnother strategy to avoid bikeshedding and arguing over rules, would be to use [eslint-config-standard](https://github.com/feross/eslint-config-standard). With that set of rules, these are the results:\r\n\r\n![screenshot from 2015-06-27 22 38 18](https://cloud.githubusercontent.com/assets/4616705/8394940/5900e108-1d1d-11e5-828c-4682c1637bc3.png)\r\n\r\nMy suggestion would be to override the following rules to more closely align with the existing codebase:\r\n\r\n```json\r\n\"rules\": {\r\n  \"space-before-function-paren\":  [2, \"never\"],\r\n  \"space-after-keywords\":         [2, \"never\"],\r\n  \"semi\":                         [2, \"always\"]\r\n}\r\n```\r\n\r\nThe results of these three changes results in something pretty manageable:\r\n\r\n![modified-standard](https://cloud.githubusercontent.com/assets/4616705/8394959/0e4025b4-1d1f-11e5-9b40-2c6c4e01a837.png)\r\n\r\nWhat say ye?  "},"comment":{"url":"https://api.github.com/repos/balderdashy/waterline/issues/comments/119228343","html_url":"https://github.com/balderdashy/waterline/pull/1070#issuecomment-119228343","issue_url":"https://api.github.com/repos/balderdashy/waterline/issues/1070","id":119228343,"user":{"login":"dmarcelino","id":1280446,"avatar_url":"https://avatars.githubusercontent.com/u/1280446?v=3","gravatar_id":"","url":"https://api.github.com/users/dmarcelino","html_url":"https://github.com/dmarcelino","followers_url":"https://api.github.com/users/dmarcelino/followers","following_url":"https://api.github.com/users/dmarcelino/following{/other_user}","gists_url":"https://api.github.com/users/dmarcelino/gists{/gist_id}","starred_url":"https://api.github.com/users/dmarcelino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmarcelino/subscriptions","organizations_url":"https://api.github.com/users/dmarcelino/orgs","repos_url":"https://api.github.com/users/dmarcelino/repos","events_url":"https://api.github.com/users/dmarcelino/events{/privacy}","received_events_url":"https://api.github.com/users/dmarcelino/received_events","type":"User","site_admin":false},"created_at":"2015-07-07T14:55:46Z","updated_at":"2015-07-07T14:55:46Z","body":"@IanVS, the PR is good for now. Lets see if we can get some feedback from @particlebanana or @tjwebb."}}