{"push_id":818398116,"size":1,"distinct_size":1,"ref":"refs/heads/master","head":"e27d3127de721206017b018d8e850e00b9496442","before":"6e7e49b10e31814b9671bd8945a1a169c7d3a07b","commits":[{"sha":"e27d3127de721206017b018d8e850e00b9496442","author":{"email":"eaa1fee310960fbd4ea077a3e7f8534caffa945f@igalia.com","name":"svillar@igalia.com"},"message":"[css-grid] Implement grid gutters\nhttps://bugs.webkit.org/show_bug.cgi?id=149800\n\nReviewed by Darin Adler.\n\nSource/WebCore:\n\nAuthors can now specify the gutters between grid lines, i.e.,\nthe space between two consecutive grid lines. This can be done\nusing the new '-webkit-grid-column-gap 'and\n'-webkit-grid-row-gap' properties (or the '-webkit-grid-gap'\nshorthand).\n\nFrom the track sizing algorithm POV, gutters are treated as\nfixed size columns. The primary consequence is that grids are\nenlarged (depending on the number of tracks). Gutters also\naffect the sizing of content-sized tracks and fr tracks as\nlong as the grid have spanning items. Those tracks will become\nsmaller as gutters will consume part of the item's size, so\nthe tracks won't need to grow as much as they used to.\n\nTests: fast/css-grid-layout/grid-gutters-and-alignment.html\n       fast/css-grid-layout/grid-gutters-and-flex-content.html\n       fast/css-grid-layout/grid-gutters-and-tracks.html\n       fast/css-grid-layout/grid-gutters-get-set.html\n\n* css/CSSComputedStyleDeclaration.cpp:\n(WebCore::valueForGridTrackList):\n(WebCore::ComputedStyleExtractor::propertyValue):\n* css/CSSParser.cpp:\n(WebCore::isSimpleLengthPropertyID):\n(WebCore::CSSParser::parseValue):\n(WebCore::CSSParser::parseGridGapShorthand):\n* css/CSSParser.h:\n* css/CSSPropertyNames.in:\n* rendering/RenderGrid.cpp:\n(WebCore::RenderGrid::guttersSize):\n(WebCore::RenderGrid::computeIntrinsicLogicalWidths):\n(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctionsForItems):\n(WebCore::RenderGrid::layoutGridItems):\n(WebCore::RenderGrid::gridAreaBreadthForChild):\n(WebCore::RenderGrid::populateGridPositions):\n(WebCore::RenderGrid::columnAxisOffsetForChild):\n(WebCore::RenderGrid::rowAxisOffsetForChild):\n* rendering/RenderGrid.h:\n* rendering/style/RenderStyle.h:\n* rendering/style/StyleGridData.cpp:\n(WebCore::StyleGridData::StyleGridData):\n* rendering/style/StyleGridData.h:\n(WebCore::StyleGridData::operator==):\n\nLayoutTests:\n\nAdded several new test cases to verify that gutters are\nproperly considered when sizing and also to check that they do\nnot modify the current behavior. As many existing tests were\nreused I took the chance to refactor some testing code related\nto alignment so that it could be reused by many different\ntests.\n\n* fast/css-grid-layout/grid-align-content.html:\n* fast/css-grid-layout/grid-align-justify-margin-border-padding-vertical-lr.html:\n* fast/css-grid-layout/grid-align-justify-margin-border-padding-vertical-rl.html:\n* fast/css-grid-layout/grid-align-justify-margin-border-padding.html:\n* fast/css-grid-layout/grid-align.html:\n* fast/css-grid-layout/grid-gutters-and-alignment-expected.txt: Added.\n* fast/css-grid-layout/grid-gutters-and-alignment.html: Added.\n* fast/css-grid-layout/grid-gutters-and-flex-content-expected.txt: Added.\n* fast/css-grid-layout/grid-gutters-and-flex-content.html: Added.\n* fast/css-grid-layout/grid-gutters-and-tracks-expected.txt: Added.\n* fast/css-grid-layout/grid-gutters-and-tracks.html: Added.\n* fast/css-grid-layout/grid-gutters-get-set-expected.txt: Added.\n* fast/css-grid-layout/grid-gutters-get-set.html: Added.\n* fast/css-grid-layout/grid-justify-content-distribution-vertical-lr.html:\n* fast/css-grid-layout/grid-justify-content-distribution-vertical-rl.html:\n* fast/css-grid-layout/grid-justify-content.html:\n* fast/css-grid-layout/resources/grid-alignment.css: Added.\n(.alignSelfAuto):\n(.alignSelfStretch):\n(.alignSelfStart):\n(.alignSelfEnd):\n(.alignSelfCenter):\n(.alignSelfRight):\n(.alignSelfLeft):\n(.alignSelfFlexStart):\n(.alignSelfFlexEnd):\n(.alignSelfSelfStart):\n(.alignSelfSelfEnd):\n(.alignItemsCenter):\n(.alignContentBaseline):\n(.alignContentLastBaseline):\n(.alignContentStart):\n(.alignContentEnd):\n(.alignContentCenter):\n(.alignContentLeft):\n(.alignContentRight):\n(.alignContentFlexStart):\n(.alignContentFlexEnd):\n(.justifyContentBaseline):\n(.justifyContentLastBaseline):\n(.justifyContentStart):\n(.justifyContentEnd):\n(.justifyContentCenter):\n(.justifyContentLeft):\n(.justifyContentRight):\n(.justifyContentFlexStart):\n(.justifyContentFlexEnd):\n(.justifyContentSpaceBetween):\n(.justifyContentSpaceAround):\n(.justifyContentSpaceEvenly):\n(.justifyContentStretch):\n(.itemsCenter):\n(.itemsEnd):\n(.itemsLeft):\n(.itemsRight):\n(.itemsSelfStart):\n(.itemsSelfEnd):\n* fast/css-grid-layout/resources/grid-definitions-parsing-utils.js:\n(testGridGapDefinitionsValues):\n* fast/css-grid-layout/resources/grid.css:\n(.firstRowThirdColumn):\n(.secondRowThirdColumn):\n(.firstRowFourthColumn):\n(.secondRowFourthColumn):\n\ngit-svn-id: http://svn.webkit.org/repository/webkit/trunk@190663 268f45cc-cd09-0410-ab3c-d52691b4dbfc","distinct":true,"url":"https://api.github.com/repos/paul99/webkit-mips/commits/e27d3127de721206017b018d8e850e00b9496442"}]}