{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/puppet-elasticsearch/pulls/comments/48233212","id":48233212,"diff_hunk":"@@ -90,7 +98,12 @@ def destroy\n   def es_version\n     return @es_version if @es_version\n     begin\n-      version = es('-v') # ES 1.x\n+      os = Facter['osfamily'].value\n+      if os == 'OpenBSD'\n+        version = pkg_info('elasticsearch').lines.first","path":"lib/puppet/provider/elasticsearch_plugin/plugin.rb","position":26,"original_position":26,"commit_id":"954aeff08056d51f2e8468b822c449b662134500","original_commit_id":"728a61ef9b36e8a8360500c9c18b320af67ce7a8","user":{"login":"electrical","id":271677,"avatar_url":"https://avatars.githubusercontent.com/u/271677?v=3","gravatar_id":"","url":"https://api.github.com/users/electrical","html_url":"https://github.com/electrical","followers_url":"https://api.github.com/users/electrical/followers","following_url":"https://api.github.com/users/electrical/following{/other_user}","gists_url":"https://api.github.com/users/electrical/gists{/gist_id}","starred_url":"https://api.github.com/users/electrical/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electrical/subscriptions","organizations_url":"https://api.github.com/users/electrical/orgs","repos_url":"https://api.github.com/users/electrical/repos","events_url":"https://api.github.com/users/electrical/events{/privacy}","received_events_url":"https://api.github.com/users/electrical/received_events","type":"User","site_admin":false},"body":"That's weird it doesn't happen on the debian/ubuntu/centos based machines.\r\nelasticsearch binary should be handling the elasticsearch.in.sh automatically.","created_at":"2015-12-22T08:59:01Z","updated_at":"2015-12-22T08:59:01Z","html_url":"https://github.com/elastic/puppet-elasticsearch/pull/491#discussion_r48233212","pull_request_url":"https://api.github.com/repos/elastic/puppet-elasticsearch/pulls/491","_links":{"self":{"href":"https://api.github.com/repos/elastic/puppet-elasticsearch/pulls/comments/48233212"},"html":{"href":"https://github.com/elastic/puppet-elasticsearch/pull/491#discussion_r48233212"},"pull_request":{"href":"https://api.github.com/repos/elastic/puppet-elasticsearch/pulls/491"}}},"pull_request":{"url":"https://api.github.com/repos/elastic/puppet-elasticsearch/pulls/491","id":50632464,"html_url":"https://github.com/elastic/puppet-elasticsearch/pull/491","diff_url":"https://github.com/elastic/puppet-elasticsearch/pull/491.diff","patch_url":"https://github.com/elastic/puppet-elasticsearch/pull/491.patch","issue_url":"https://api.github.com/repos/elastic/puppet-elasticsearch/issues/491","number":491,"state":"open","locked":false,"title":"Some changes to support OpenBSD:","user":{"login":"buzzdeee","id":8383396,"avatar_url":"https://avatars.githubusercontent.com/u/8383396?v=3","gravatar_id":"","url":"https://api.github.com/users/buzzdeee","html_url":"https://github.com/buzzdeee","followers_url":"https://api.github.com/users/buzzdeee/followers","following_url":"https://api.github.com/users/buzzdeee/following{/other_user}","gists_url":"https://api.github.com/users/buzzdeee/gists{/gist_id}","starred_url":"https://api.github.com/users/buzzdeee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buzzdeee/subscriptions","organizations_url":"https://api.github.com/users/buzzdeee/orgs","repos_url":"https://api.github.com/users/buzzdeee/repos","events_url":"https://api.github.com/users/buzzdeee/events{/privacy}","received_events_url":"https://api.github.com/users/buzzdeee/received_events","type":"User","site_admin":false},"body":" * a couple of OpenBSD specific additions to params.pp, i.e. user,\r\n   download tool, paths, service provider, etc.\r\n * add a $service_flags parameter to instance.pp, since the OpenBSD\r\n   service type supports flags, and those should be settable.\r\n * add a $service_flags parameter to service.pp, that gets passed\r\n   in from instance.pp, and handed over to openbsd.pp service.\r\n * add an easy openbsd service provider, that only knows about\r\n   status, ensure, pid_dir, service_flags and init_template\r\n   parameters. There is no \"standard\" defaults file on OpenBSD.\r\n * because the defaults_location on OpenBSD is not set, guard\r\n   the augeas call in config.pp to manage the defaults file.\r\n * added a template for the openbsd service, based on the\r\n   rc script, that comes with the package.\r\n\r\n\r\ntested with elasticsearch-1.7.2, configured and fired up an instance as well as plugin installation works.\r\n\r\nLet me know if there is something that needs change/enhancement to get merged.\r\n\r\nthanks,\r\nSebastian","created_at":"2015-11-13T11:48:23Z","updated_at":"2015-12-22T08:59:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"df53511a56d258ca2579ffcad3d3a5d144a7009c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/elastic/puppet-elasticsearch/pulls/491/commits","review_comments_url":"https://api.github.com/repos/elastic/puppet-elasticsearch/pulls/491/comments","review_comment_url":"https://api.github.com/repos/elastic/puppet-elasticsearch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/puppet-elasticsearch/issues/491/comments","statuses_url":"https://api.github.com/repos/elastic/puppet-elasticsearch/statuses/954aeff08056d51f2e8468b822c449b662134500","head":{"label":"buzzdeee:OpenBSD","ref":"OpenBSD","sha":"954aeff08056d51f2e8468b822c449b662134500","user":{"login":"buzzdeee","id":8383396,"avatar_url":"https://avatars.githubusercontent.com/u/8383396?v=3","gravatar_id":"","url":"https://api.github.com/users/buzzdeee","html_url":"https://github.com/buzzdeee","followers_url":"https://api.github.com/users/buzzdeee/followers","following_url":"https://api.github.com/users/buzzdeee/following{/other_user}","gists_url":"https://api.github.com/users/buzzdeee/gists{/gist_id}","starred_url":"https://api.github.com/users/buzzdeee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buzzdeee/subscriptions","organizations_url":"https://api.github.com/users/buzzdeee/orgs","repos_url":"https://api.github.com/users/buzzdeee/repos","events_url":"https://api.github.com/users/buzzdeee/events{/privacy}","received_events_url":"https://api.github.com/users/buzzdeee/received_events","type":"User","site_admin":false},"repo":{"id":37263338,"name":"puppet-elasticsearch","full_name":"buzzdeee/puppet-elasticsearch","owner":{"login":"buzzdeee","id":8383396,"avatar_url":"https://avatars.githubusercontent.com/u/8383396?v=3","gravatar_id":"","url":"https://api.github.com/users/buzzdeee","html_url":"https://github.com/buzzdeee","followers_url":"https://api.github.com/users/buzzdeee/followers","following_url":"https://api.github.com/users/buzzdeee/following{/other_user}","gists_url":"https://api.github.com/users/buzzdeee/gists{/gist_id}","starred_url":"https://api.github.com/users/buzzdeee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buzzdeee/subscriptions","organizations_url":"https://api.github.com/users/buzzdeee/orgs","repos_url":"https://api.github.com/users/buzzdeee/repos","events_url":"https://api.github.com/users/buzzdeee/events{/privacy}","received_events_url":"https://api.github.com/users/buzzdeee/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/buzzdeee/puppet-elasticsearch","description":"Elasticsearch Puppet module","fork":true,"url":"https://api.github.com/repos/buzzdeee/puppet-elasticsearch","forks_url":"https://api.github.com/repos/buzzdeee/puppet-elasticsearch/forks","keys_url":"https://api.github.com/repos/buzzdeee/puppet-elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/buzzdeee/puppet-elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/buzzdeee/puppet-elasticsearch/teams","hooks_url":"https://api.github.com/repos/buzzdeee/puppet-elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/buzzdeee/puppet-elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/buzzdeee/puppet-elasticsearch/events","assignees_url":"https://api.github.com/repos/buzzdeee/puppet-elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/buzzdeee/puppet-elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/buzzdeee/puppet-elasticsearch/tags","blobs_url":"https://api.github.com/repos/buzzdeee/puppet-elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/buzzdeee/puppet-elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/buzzdeee/puppet-elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/buzzdeee/puppet-elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/buzzdeee/puppet-elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/buzzdeee/puppet-elasticsearch/languages","stargazers_url":"https://api.github.com/repos/buzzdeee/puppet-elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/buzzdeee/puppet-elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/buzzdeee/puppet-elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/buzzdeee/puppet-elasticsearch/subscription","commits_url":"https://api.github.com/repos/buzzdeee/puppet-elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/buzzdeee/puppet-elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/buzzdeee/puppet-elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/buzzdeee/puppet-elasticsearch/issues/comments{/number}","contents_url":"https://api.github.com/repos/buzzdeee/puppet-elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/buzzdeee/puppet-elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/buzzdeee/puppet-elasticsearch/merges","archive_url":"https://api.github.com/repos/buzzdeee/puppet-elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/buzzdeee/puppet-elasticsearch/downloads","issues_url":"https://api.github.com/repos/buzzdeee/puppet-elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/buzzdeee/puppet-elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/buzzdeee/puppet-elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/buzzdeee/puppet-elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/buzzdeee/puppet-elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/buzzdeee/puppet-elasticsearch/releases{/id}","created_at":"2015-06-11T13:41:02Z","updated_at":"2015-06-11T13:41:03Z","pushed_at":"2015-12-22T07:33:01Z","git_url":"git://github.com/buzzdeee/puppet-elasticsearch.git","ssh_url":"git@github.com:buzzdeee/puppet-elasticsearch.git","clone_url":"https://github.com/buzzdeee/puppet-elasticsearch.git","svn_url":"https://github.com/buzzdeee/puppet-elasticsearch","homepage":"","size":794,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"785afdc9783a2d4e79584514b1b6fb6c223a32ba","user":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":6968490,"name":"puppet-elasticsearch","full_name":"elastic/puppet-elasticsearch","owner":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/puppet-elasticsearch","description":"Elasticsearch Puppet module","fork":false,"url":"https://api.github.com/repos/elastic/puppet-elasticsearch","forks_url":"https://api.github.com/repos/elastic/puppet-elasticsearch/forks","keys_url":"https://api.github.com/repos/elastic/puppet-elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/puppet-elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/puppet-elasticsearch/teams","hooks_url":"https://api.github.com/repos/elastic/puppet-elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/elastic/puppet-elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/puppet-elasticsearch/events","assignees_url":"https://api.github.com/repos/elastic/puppet-elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/puppet-elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/puppet-elasticsearch/tags","blobs_url":"https://api.github.com/repos/elastic/puppet-elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/puppet-elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/puppet-elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/puppet-elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/puppet-elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/puppet-elasticsearch/languages","stargazers_url":"https://api.github.com/repos/elastic/puppet-elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/elastic/puppet-elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/elastic/puppet-elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/elastic/puppet-elasticsearch/subscription","commits_url":"https://api.github.com/repos/elastic/puppet-elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/puppet-elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/puppet-elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/puppet-elasticsearch/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/puppet-elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/puppet-elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/puppet-elasticsearch/merges","archive_url":"https://api.github.com/repos/elastic/puppet-elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/puppet-elasticsearch/downloads","issues_url":"https://api.github.com/repos/elastic/puppet-elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/puppet-elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/puppet-elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/puppet-elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/puppet-elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/elastic/puppet-elasticsearch/releases{/id}","created_at":"2012-12-02T15:09:34Z","updated_at":"2015-12-22T07:25:57Z","pushed_at":"2015-12-22T07:33:01Z","git_url":"git://github.com/elastic/puppet-elasticsearch.git","ssh_url":"git@github.com:elastic/puppet-elasticsearch.git","clone_url":"https://github.com/elastic/puppet-elasticsearch.git","svn_url":"https://github.com/elastic/puppet-elasticsearch","homepage":"","size":922,"stargazers_count":229,"watchers_count":229,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":259,"mirror_url":null,"open_issues_count":42,"forks":259,"open_issues":42,"watchers":229,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/puppet-elasticsearch/pulls/491"},"html":{"href":"https://github.com/elastic/puppet-elasticsearch/pull/491"},"issue":{"href":"https://api.github.com/repos/elastic/puppet-elasticsearch/issues/491"},"comments":{"href":"https://api.github.com/repos/elastic/puppet-elasticsearch/issues/491/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/puppet-elasticsearch/pulls/491/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/puppet-elasticsearch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/puppet-elasticsearch/pulls/491/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/puppet-elasticsearch/statuses/954aeff08056d51f2e8468b822c449b662134500"}}}}