{"action":"opened","issue":{"url":"https://api.github.com/repos/alexbarton/ngircd_bugs/issues/151","labels_url":"https://api.github.com/repos/alexbarton/ngircd_bugs/issues/151/labels{/name}","comments_url":"https://api.github.com/repos/alexbarton/ngircd_bugs/issues/151/comments","events_url":"https://api.github.com/repos/alexbarton/ngircd_bugs/issues/151/events","html_url":"https://github.com/alexbarton/ngircd_bugs/issues/151","id":55435470,"number":151,"title":"--with-iconv fails (Bugzilla #151)","user":{"login":"alexbarton","id":174961,"avatar_url":"https://avatars.githubusercontent.com/u/174961?v=3","gravatar_id":"","url":"https://api.github.com/users/alexbarton","html_url":"https://github.com/alexbarton","followers_url":"https://api.github.com/users/alexbarton/followers","following_url":"https://api.github.com/users/alexbarton/following{/other_user}","gists_url":"https://api.github.com/users/alexbarton/gists{/gist_id}","starred_url":"https://api.github.com/users/alexbarton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexbarton/subscriptions","organizations_url":"https://api.github.com/users/alexbarton/orgs","repos_url":"https://api.github.com/users/alexbarton/repos","events_url":"https://api.github.com/users/alexbarton/events{/privacy}","received_events_url":"https://api.github.com/users/alexbarton/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2015-01-25T23:38:06Z","updated_at":"2015-01-25T23:38:06Z","closed_at":null,"body":"status CLOSED severity *normal* in component *Daemon* for *---*\nReported in version *20* on platform *All*\nAssigned to: Alexander Barton\n\nOriginal attachment names and IDs:\n- _[Use-AM_ICONV-to-test-for-the-iconv-library.patch](https://arthur.barton.de/bugzilla//attachment.cgi?id=82)_ (ID 82)\n- _[configure-search-for-iconv_open-libiconv_open.patch](https://arthur.barton.de/bugzilla//attachment.cgi?id=83)_ (ID 83)\n\nOn 2013-01-20 01:14:22 +0100, Federico G. Schwindt wrote:\n\n> On some installations iconv_open is actually libiconv_open.\n> iconv_open is the glibc version while libiconv_open is the libiconv version.\n> \n> The iconv.h header has all the magic required to properly detect iconv support and to deal with the iconv_xxx vs libiconv_xxx mess.\n> For example a m4 to do the correct checking is at https://github.com/mirrors/gcc/blob/master/config/iconv.m4.\n> \n> Please consider using that or some other encarnation that make --with-iconv work with both glibc and libiconv symbols.\n\nOn 2013-02-11 20:49:12 +0100, Alexander Barton wrote:\n\n> Anhang 82 angelegt (attachment 82)\n> Use AM_ICONV to test for the iconv library\n> \n> (In reply to comment # 0)\n> \n> > https://github.com/mirrors/gcc/blob/master/config/iconv.m4.\n> > \n> > Please consider using that or some other encarnation that make --with-iconv\n> > work with both glibc and libiconv symbols.\n> \n> I wrote a patch that uses this macro file, and two other (\"lib-link.m4\", \"lib.prefix.m4\"), that seem to be required by that \"iconv.m4\" ...\n> \n> Could you please test if this fixes this bug for you?\n\nOn 2013-02-11 20:52:07 +0100, Alexander Barton wrote:\n\n> (In reply to comment # 1)\n> \n> > Could you please test if this fixes this bug for you?\n> \n> You can find the patch in the \"bug151-iconv-m4\" branch in my ngIRCd GIT repository and on GitWeb, too:\n> \n> - git://arthur.barton.de/ngircd-alex.git bug151-iconv-m4\n> - http://arthur.barton.de/cgi-bin/gitweb.cgi?p=ngircd-alex.git;a=shortlog;h=refs/heads/bug151-iconv-m4\n\nOn 2013-02-15 21:41:55 +0100, Alexander Barton wrote:\n\n> Anhang 83 angelegt (attachment 83)\n> configure: search for iconv_open as well as libiconv_open\n> \n> (In reply to comment # 2)\n> \n> > > Could you please test if this fixes this bug for you?\n> > \n> > You can find the patch in the \"bug151-iconv-m4\" branch in my ngIRCd GIT\n> > repository and on GitWeb, too:\n> \n> Okay, the patch is ugly as hell, has unexpected semantics (when passing in path names), very BIG, and probably unnecessarily complex – to sum it up: I don't like it.\n> \n> Here is a much smaller and nicer patch that fixes the problem for me. Tested on OpenBSD 5.1.\n> \n> Please, can you verify that it solves this issue for you?\n\nOn 2013-02-17 15:52:42 +0100, Federico G. Schwindt wrote:\n\n> Works for me in 5.3 and -current. Thanks!\n\nOn 2013-02-24 15:18:27 +0100, Alexander Barton wrote:\n\n> (In reply to comment # 4)\n> \n> > Works for me in 5.3 and -current. Thanks!\n> \n> I merged it into our master branch, commit ID #d0c9f4a6.\n> Thanks for testing!\n\nOn 2013-10-10 10:20:17 +0200, Alexander Barton wrote:\n\n> The fix is in our current release candidate 21~rc1, so closing this report. Thanks!\n\n"}}