{"action":"closed","number":5,"pull_request":{"url":"https://api.github.com/repos/amplience/amplience-sdk-client/pulls/5","id":35434022,"html_url":"https://github.com/amplience/amplience-sdk-client/pull/5","diff_url":"https://github.com/amplience/amplience-sdk-client/pull/5.diff","patch_url":"https://github.com/amplience/amplience-sdk-client/pull/5.patch","issue_url":"https://api.github.com/repos/amplience/amplience-sdk-client/issues/5","number":5,"state":"closed","locked":false,"title":"Feature/bugfix video states","user":{"login":"stephen-james","id":2278558,"avatar_url":"https://avatars.githubusercontent.com/u/2278558?v=3","gravatar_id":"","url":"https://api.github.com/users/stephen-james","html_url":"https://github.com/stephen-james","followers_url":"https://api.github.com/users/stephen-james/followers","following_url":"https://api.github.com/users/stephen-james/following{/other_user}","gists_url":"https://api.github.com/users/stephen-james/gists{/gist_id}","starred_url":"https://api.github.com/users/stephen-james/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephen-james/subscriptions","organizations_url":"https://api.github.com/users/stephen-james/orgs","repos_url":"https://api.github.com/users/stephen-james/repos","events_url":"https://api.github.com/users/stephen-james/events{/privacy}","received_events_url":"https://api.github.com/users/stephen-james/received_events","type":"User","site_admin":false},"body":"# Bug: state is not initialized\r\n\r\nGiven a video widget rendered on the page\r\nWhen I call the `ampVideo('state')` method\r\nThen I get a jQuery object returned \r\n\r\n## Expected:\r\n\r\nTo receive a number representing the state of the video\r\n\r\n## Fix:\r\n\r\nDefault the video state to `0` (stopped) because the video otherwise has no state until it is first played and any call to `ampVideo('state')` will return the jQuery object result for the element, because current state is undefined (ie. it resorts to jQuery chaining behaviour).\r\n\r\n\r\n# Bug: video does not change state once video has finished playing\r\n\r\nGiven a video widget rendered on the page\r\nWhen I a user plays the video\r\nAnd the video has finished playing all the way through\r\nWhen I call `ampVideo('state')`\r\nThen I get a status 3 (playing)\r\n\r\n## Expected:\r\n\r\nTo receive a status that indicates the video is no longer playing\r\n\r\n## Fix:\r\n\r\nIn the VideoJS event handler for `ended`, if we are not looping the video, set the state to `0` (stopped)\r\n","created_at":"2015-05-14T15:51:37Z","updated_at":"2015-08-20T16:08:16Z","closed_at":"2015-08-20T16:08:15Z","merged_at":"2015-08-20T16:08:15Z","merge_commit_sha":"2654bbda927c50c3b1bd6efd1a6b17ba7c355935","assignee":null,"milestone":{"url":"https://api.github.com/repos/amplience/amplience-sdk-client/milestones/1","html_url":"https://github.com/amplience/amplience-sdk-client/milestones/v0.1.2","labels_url":"https://api.github.com/repos/amplience/amplience-sdk-client/milestones/1/labels","id":1235308,"number":1,"title":"v0.1.2","description":"release v0.1.2","creator":{"login":"stephen-james","id":2278558,"avatar_url":"https://avatars.githubusercontent.com/u/2278558?v=3","gravatar_id":"","url":"https://api.github.com/users/stephen-james","html_url":"https://github.com/stephen-james","followers_url":"https://api.github.com/users/stephen-james/followers","following_url":"https://api.github.com/users/stephen-james/following{/other_user}","gists_url":"https://api.github.com/users/stephen-james/gists{/gist_id}","starred_url":"https://api.github.com/users/stephen-james/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephen-james/subscriptions","organizations_url":"https://api.github.com/users/stephen-james/orgs","repos_url":"https://api.github.com/users/stephen-james/repos","events_url":"https://api.github.com/users/stephen-james/events{/privacy}","received_events_url":"https://api.github.com/users/stephen-james/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":8,"state":"open","created_at":"2015-07-31T15:07:12Z","updated_at":"2015-08-20T16:08:15Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/amplience/amplience-sdk-client/pulls/5/commits","review_comments_url":"https://api.github.com/repos/amplience/amplience-sdk-client/pulls/5/comments","review_comment_url":"https://api.github.com/repos/amplience/amplience-sdk-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/amplience/amplience-sdk-client/issues/5/comments","statuses_url":"https://api.github.com/repos/amplience/amplience-sdk-client/statuses/9bf4f04ad33952655e4e2828e7084963e31b9a93","head":{"label":"stephen-james:feature/bugfix-video-states","ref":"feature/bugfix-video-states","sha":"9bf4f04ad33952655e4e2828e7084963e31b9a93","user":{"login":"stephen-james","id":2278558,"avatar_url":"https://avatars.githubusercontent.com/u/2278558?v=3","gravatar_id":"","url":"https://api.github.com/users/stephen-james","html_url":"https://github.com/stephen-james","followers_url":"https://api.github.com/users/stephen-james/followers","following_url":"https://api.github.com/users/stephen-james/following{/other_user}","gists_url":"https://api.github.com/users/stephen-james/gists{/gist_id}","starred_url":"https://api.github.com/users/stephen-james/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephen-james/subscriptions","organizations_url":"https://api.github.com/users/stephen-james/orgs","repos_url":"https://api.github.com/users/stephen-james/repos","events_url":"https://api.github.com/users/stephen-james/events{/privacy}","received_events_url":"https://api.github.com/users/stephen-james/received_events","type":"User","site_admin":false},"repo":{"id":33738300,"name":"amplience-sdk-client","full_name":"stephen-james/amplience-sdk-client","owner":{"login":"stephen-james","id":2278558,"avatar_url":"https://avatars.githubusercontent.com/u/2278558?v=3","gravatar_id":"","url":"https://api.github.com/users/stephen-james","html_url":"https://github.com/stephen-james","followers_url":"https://api.github.com/users/stephen-james/followers","following_url":"https://api.github.com/users/stephen-james/following{/other_user}","gists_url":"https://api.github.com/users/stephen-james/gists{/gist_id}","starred_url":"https://api.github.com/users/stephen-james/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephen-james/subscriptions","organizations_url":"https://api.github.com/users/stephen-james/orgs","repos_url":"https://api.github.com/users/stephen-james/repos","events_url":"https://api.github.com/users/stephen-james/events{/privacy}","received_events_url":"https://api.github.com/users/stephen-james/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stephen-james/amplience-sdk-client","description":"Amplience Client SDK is a library built to make the consumption of the Amplience platform easier for developers. As well as providing interfaces to our APIs it contains platform agnostic widgets for generating carousels, 360 product rotations, zoom viewers and more.","fork":true,"url":"https://api.github.com/repos/stephen-james/amplience-sdk-client","forks_url":"https://api.github.com/repos/stephen-james/amplience-sdk-client/forks","keys_url":"https://api.github.com/repos/stephen-james/amplience-sdk-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stephen-james/amplience-sdk-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stephen-james/amplience-sdk-client/teams","hooks_url":"https://api.github.com/repos/stephen-james/amplience-sdk-client/hooks","issue_events_url":"https://api.github.com/repos/stephen-james/amplience-sdk-client/issues/events{/number}","events_url":"https://api.github.com/repos/stephen-james/amplience-sdk-client/events","assignees_url":"https://api.github.com/repos/stephen-james/amplience-sdk-client/assignees{/user}","branches_url":"https://api.github.com/repos/stephen-james/amplience-sdk-client/branches{/branch}","tags_url":"https://api.github.com/repos/stephen-james/amplience-sdk-client/tags","blobs_url":"https://api.github.com/repos/stephen-james/amplience-sdk-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stephen-james/amplience-sdk-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stephen-james/amplience-sdk-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/stephen-james/amplience-sdk-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stephen-james/amplience-sdk-client/statuses/{sha}","languages_url":"https://api.github.com/repos/stephen-james/amplience-sdk-client/languages","stargazers_url":"https://api.github.com/repos/stephen-james/amplience-sdk-client/stargazers","contributors_url":"https://api.github.com/repos/stephen-james/amplience-sdk-client/contributors","subscribers_url":"https://api.github.com/repos/stephen-james/amplience-sdk-client/subscribers","subscription_url":"https://api.github.com/repos/stephen-james/amplience-sdk-client/subscription","commits_url":"https://api.github.com/repos/stephen-james/amplience-sdk-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/stephen-james/amplience-sdk-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/stephen-james/amplience-sdk-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/stephen-james/amplience-sdk-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/stephen-james/amplience-sdk-client/contents/{+path}","compare_url":"https://api.github.com/repos/stephen-james/amplience-sdk-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stephen-james/amplience-sdk-client/merges","archive_url":"https://api.github.com/repos/stephen-james/amplience-sdk-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stephen-james/amplience-sdk-client/downloads","issues_url":"https://api.github.com/repos/stephen-james/amplience-sdk-client/issues{/number}","pulls_url":"https://api.github.com/repos/stephen-james/amplience-sdk-client/pulls{/number}","milestones_url":"https://api.github.com/repos/stephen-james/amplience-sdk-client/milestones{/number}","notifications_url":"https://api.github.com/repos/stephen-james/amplience-sdk-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stephen-james/amplience-sdk-client/labels{/name}","releases_url":"https://api.github.com/repos/stephen-james/amplience-sdk-client/releases{/id}","created_at":"2015-04-10T16:18:23Z","updated_at":"2015-04-10T16:18:24Z","pushed_at":"2015-05-28T08:03:59Z","git_url":"git://github.com/stephen-james/amplience-sdk-client.git","ssh_url":"git@github.com:stephen-james/amplience-sdk-client.git","clone_url":"https://github.com/stephen-james/amplience-sdk-client.git","svn_url":"https://github.com/stephen-james/amplience-sdk-client","homepage":"http://playground.amplience.com/sdk/docs/","size":560,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"amplience:develop","ref":"develop","sha":"deef897c8b9028995c7c8ca278046e9ba7c06fac","user":{"login":"amplience","id":4487692,"avatar_url":"https://avatars.githubusercontent.com/u/4487692?v=3","gravatar_id":"","url":"https://api.github.com/users/amplience","html_url":"https://github.com/amplience","followers_url":"https://api.github.com/users/amplience/followers","following_url":"https://api.github.com/users/amplience/following{/other_user}","gists_url":"https://api.github.com/users/amplience/gists{/gist_id}","starred_url":"https://api.github.com/users/amplience/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amplience/subscriptions","organizations_url":"https://api.github.com/users/amplience/orgs","repos_url":"https://api.github.com/users/amplience/repos","events_url":"https://api.github.com/users/amplience/events{/privacy}","received_events_url":"https://api.github.com/users/amplience/received_events","type":"Organization","site_admin":false},"repo":{"id":31726755,"name":"amplience-sdk-client","full_name":"amplience/amplience-sdk-client","owner":{"login":"amplience","id":4487692,"avatar_url":"https://avatars.githubusercontent.com/u/4487692?v=3","gravatar_id":"","url":"https://api.github.com/users/amplience","html_url":"https://github.com/amplience","followers_url":"https://api.github.com/users/amplience/followers","following_url":"https://api.github.com/users/amplience/following{/other_user}","gists_url":"https://api.github.com/users/amplience/gists{/gist_id}","starred_url":"https://api.github.com/users/amplience/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amplience/subscriptions","organizations_url":"https://api.github.com/users/amplience/orgs","repos_url":"https://api.github.com/users/amplience/repos","events_url":"https://api.github.com/users/amplience/events{/privacy}","received_events_url":"https://api.github.com/users/amplience/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/amplience/amplience-sdk-client","description":"Amplience Client SDK is a library built to make the consumption of the Amplience platform easier for developers. As well as providing interfaces to our APIs it contains platform agnostic widgets for generating carousels, 360 product rotations, zoom viewers and more.","fork":false,"url":"https://api.github.com/repos/amplience/amplience-sdk-client","forks_url":"https://api.github.com/repos/amplience/amplience-sdk-client/forks","keys_url":"https://api.github.com/repos/amplience/amplience-sdk-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amplience/amplience-sdk-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amplience/amplience-sdk-client/teams","hooks_url":"https://api.github.com/repos/amplience/amplience-sdk-client/hooks","issue_events_url":"https://api.github.com/repos/amplience/amplience-sdk-client/issues/events{/number}","events_url":"https://api.github.com/repos/amplience/amplience-sdk-client/events","assignees_url":"https://api.github.com/repos/amplience/amplience-sdk-client/assignees{/user}","branches_url":"https://api.github.com/repos/amplience/amplience-sdk-client/branches{/branch}","tags_url":"https://api.github.com/repos/amplience/amplience-sdk-client/tags","blobs_url":"https://api.github.com/repos/amplience/amplience-sdk-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amplience/amplience-sdk-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amplience/amplience-sdk-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/amplience/amplience-sdk-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amplience/amplience-sdk-client/statuses/{sha}","languages_url":"https://api.github.com/repos/amplience/amplience-sdk-client/languages","stargazers_url":"https://api.github.com/repos/amplience/amplience-sdk-client/stargazers","contributors_url":"https://api.github.com/repos/amplience/amplience-sdk-client/contributors","subscribers_url":"https://api.github.com/repos/amplience/amplience-sdk-client/subscribers","subscription_url":"https://api.github.com/repos/amplience/amplience-sdk-client/subscription","commits_url":"https://api.github.com/repos/amplience/amplience-sdk-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/amplience/amplience-sdk-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/amplience/amplience-sdk-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/amplience/amplience-sdk-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/amplience/amplience-sdk-client/contents/{+path}","compare_url":"https://api.github.com/repos/amplience/amplience-sdk-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amplience/amplience-sdk-client/merges","archive_url":"https://api.github.com/repos/amplience/amplience-sdk-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amplience/amplience-sdk-client/downloads","issues_url":"https://api.github.com/repos/amplience/amplience-sdk-client/issues{/number}","pulls_url":"https://api.github.com/repos/amplience/amplience-sdk-client/pulls{/number}","milestones_url":"https://api.github.com/repos/amplience/amplience-sdk-client/milestones{/number}","notifications_url":"https://api.github.com/repos/amplience/amplience-sdk-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amplience/amplience-sdk-client/labels{/name}","releases_url":"https://api.github.com/repos/amplience/amplience-sdk-client/releases{/id}","created_at":"2015-03-05T17:37:53Z","updated_at":"2015-04-29T16:25:16Z","pushed_at":"2015-08-20T16:08:15Z","git_url":"git://github.com/amplience/amplience-sdk-client.git","ssh_url":"git@github.com:amplience/amplience-sdk-client.git","clone_url":"https://github.com/amplience/amplience-sdk-client.git","svn_url":"https://github.com/amplience/amplience-sdk-client","homepage":"http://playground.amplience.com/sdk/docs/","size":1070,"stargazers_count":9,"watchers_count":9,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":3,"forks":3,"open_issues":3,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/amplience/amplience-sdk-client/pulls/5"},"html":{"href":"https://github.com/amplience/amplience-sdk-client/pull/5"},"issue":{"href":"https://api.github.com/repos/amplience/amplience-sdk-client/issues/5"},"comments":{"href":"https://api.github.com/repos/amplience/amplience-sdk-client/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/amplience/amplience-sdk-client/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/amplience/amplience-sdk-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/amplience/amplience-sdk-client/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/amplience/amplience-sdk-client/statuses/9bf4f04ad33952655e4e2828e7084963e31b9a93"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"pixelscript","id":468889,"avatar_url":"https://avatars.githubusercontent.com/u/468889?v=3","gravatar_id":"","url":"https://api.github.com/users/pixelscript","html_url":"https://github.com/pixelscript","followers_url":"https://api.github.com/users/pixelscript/followers","following_url":"https://api.github.com/users/pixelscript/following{/other_user}","gists_url":"https://api.github.com/users/pixelscript/gists{/gist_id}","starred_url":"https://api.github.com/users/pixelscript/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pixelscript/subscriptions","organizations_url":"https://api.github.com/users/pixelscript/orgs","repos_url":"https://api.github.com/users/pixelscript/repos","events_url":"https://api.github.com/users/pixelscript/events{/privacy}","received_events_url":"https://api.github.com/users/pixelscript/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":4,"additions":18,"deletions":28,"changed_files":9}}