{"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/37861996","id":37861996,"diff_hunk":"@@ -22,12 +22,12 @@\n                        :registry   => nil},\n \n                       {:image_name => \"host/subname/example\",\n-                       :image      => {:name => \"subname/example\", :tag => nil, :image_ref => example_ref},\n-                       :registry   => {:name => \"host\", :host => \"host\", :port => nil}},\n+                       :image      => {:name => \"host/subname/example\", :tag => nil, :image_ref => example_ref},","path":"spec/models/ems_refresh/parsers/kubernetes_spec.rb","position":null,"original_position":6,"commit_id":"84a144c199dd67210357c619bc30dba07802ef9e","original_commit_id":"b2bacdd145f847333c012da8d154b6a59e63f880","user":{"login":"zeari","id":11256940,"avatar_url":"https://avatars.githubusercontent.com/u/11256940?v=3","gravatar_id":"","url":"https://api.github.com/users/zeari","html_url":"https://github.com/zeari","followers_url":"https://api.github.com/users/zeari/followers","following_url":"https://api.github.com/users/zeari/following{/other_user}","gists_url":"https://api.github.com/users/zeari/gists{/gist_id}","starred_url":"https://api.github.com/users/zeari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeari/subscriptions","organizations_url":"https://api.github.com/users/zeari/orgs","repos_url":"https://api.github.com/users/zeari/repos","events_url":"https://api.github.com/users/zeari/events{/privacy}","received_events_url":"https://api.github.com/users/zeari/received_events","type":"User","site_admin":false},"body":"> Keeping host here is confusing because I'd expect it to appear in the registry (as :name). It should be renamed to something else.\r\n\r\nFixed","created_at":"2015-08-25T13:07:13Z","updated_at":"2015-08-25T13:07:13Z","html_url":"https://github.com/ManageIQ/manageiq/pull/3856#discussion_r37861996","pull_request_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/3856","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/37861996"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/3856#discussion_r37861996"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/3856"}}},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/3856","id":42349455,"html_url":"https://github.com/ManageIQ/manageiq/pull/3856","diff_url":"https://github.com/ManageIQ/manageiq/pull/3856.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/3856.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/3856","number":3856,"state":"open","locked":false,"title":"Fixed parsing of docker image names issue - #3820","user":{"login":"zeari","id":11256940,"avatar_url":"https://avatars.githubusercontent.com/u/11256940?v=3","gravatar_id":"","url":"https://api.github.com/users/zeari","html_url":"https://github.com/zeari","followers_url":"https://api.github.com/users/zeari/followers","following_url":"https://api.github.com/users/zeari/following{/other_user}","gists_url":"https://api.github.com/users/zeari/gists{/gist_id}","starred_url":"https://api.github.com/users/zeari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeari/subscriptions","organizations_url":"https://api.github.com/users/zeari/orgs","repos_url":"https://api.github.com/users/zeari/repos","events_url":"https://api.github.com/users/zeari/events{/privacy}","received_events_url":"https://api.github.com/users/zeari/received_events","type":"User","site_admin":false},"body":"fixes #3820 \r\n\r\nThere are a few assumptions about docker image names in this fix:\r\n1) Registries must contain with ```.``` or ```:``` i.e. ```localhost:5000```, ```site.com``` or with both: ```192.168.1.2:1234``` but not ```server``` or ```localhost``` since theres no way I could think of to differentiate between a registry and an image name. in the example ```server/image:tag``` its unknown if ```server``` is a registry or a subrepo\r\n2) Image names in the system can be anything after registry i.e. ```aaaa/bbbb/cccc/user/example``` would be the image name from ```localhost:5000/aaaa/bbbb/cccc/user/example```\r\n\r\n@abonas @simon3z ","created_at":"2015-08-13T13:22:46Z","updated_at":"2015-08-25T13:07:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"30757013bc5881bca51860e6882f088c49885b7f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/3856/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/3856/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/3856/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/84a144c199dd67210357c619bc30dba07802ef9e","head":{"label":"zeari:fix_reg_parse","ref":"fix_reg_parse","sha":"84a144c199dd67210357c619bc30dba07802ef9e","user":{"login":"zeari","id":11256940,"avatar_url":"https://avatars.githubusercontent.com/u/11256940?v=3","gravatar_id":"","url":"https://api.github.com/users/zeari","html_url":"https://github.com/zeari","followers_url":"https://api.github.com/users/zeari/followers","following_url":"https://api.github.com/users/zeari/following{/other_user}","gists_url":"https://api.github.com/users/zeari/gists{/gist_id}","starred_url":"https://api.github.com/users/zeari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeari/subscriptions","organizations_url":"https://api.github.com/users/zeari/orgs","repos_url":"https://api.github.com/users/zeari/repos","events_url":"https://api.github.com/users/zeari/events{/privacy}","received_events_url":"https://api.github.com/users/zeari/received_events","type":"User","site_admin":false},"repo":{"id":32809554,"name":"manageiq","full_name":"zeari/manageiq","owner":{"login":"zeari","id":11256940,"avatar_url":"https://avatars.githubusercontent.com/u/11256940?v=3","gravatar_id":"","url":"https://api.github.com/users/zeari","html_url":"https://github.com/zeari","followers_url":"https://api.github.com/users/zeari/followers","following_url":"https://api.github.com/users/zeari/following{/other_user}","gists_url":"https://api.github.com/users/zeari/gists{/gist_id}","starred_url":"https://api.github.com/users/zeari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeari/subscriptions","organizations_url":"https://api.github.com/users/zeari/orgs","repos_url":"https://api.github.com/users/zeari/repos","events_url":"https://api.github.com/users/zeari/events{/privacy}","received_events_url":"https://api.github.com/users/zeari/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zeari/manageiq","description":"ManageIQ Cloud Management Platform","fork":true,"url":"https://api.github.com/repos/zeari/manageiq","forks_url":"https://api.github.com/repos/zeari/manageiq/forks","keys_url":"https://api.github.com/repos/zeari/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zeari/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zeari/manageiq/teams","hooks_url":"https://api.github.com/repos/zeari/manageiq/hooks","issue_events_url":"https://api.github.com/repos/zeari/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/zeari/manageiq/events","assignees_url":"https://api.github.com/repos/zeari/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/zeari/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/zeari/manageiq/tags","blobs_url":"https://api.github.com/repos/zeari/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zeari/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zeari/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/zeari/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zeari/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/zeari/manageiq/languages","stargazers_url":"https://api.github.com/repos/zeari/manageiq/stargazers","contributors_url":"https://api.github.com/repos/zeari/manageiq/contributors","subscribers_url":"https://api.github.com/repos/zeari/manageiq/subscribers","subscription_url":"https://api.github.com/repos/zeari/manageiq/subscription","commits_url":"https://api.github.com/repos/zeari/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/zeari/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/zeari/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/zeari/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/zeari/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/zeari/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zeari/manageiq/merges","archive_url":"https://api.github.com/repos/zeari/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zeari/manageiq/downloads","issues_url":"https://api.github.com/repos/zeari/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/zeari/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/zeari/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/zeari/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zeari/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/zeari/manageiq/releases{/id}","created_at":"2015-03-24T16:05:33Z","updated_at":"2015-04-19T08:03:20Z","pushed_at":"2015-08-25T13:03:06Z","git_url":"git://github.com/zeari/manageiq.git","ssh_url":"git@github.com:zeari/manageiq.git","clone_url":"https://github.com/zeari/manageiq.git","svn_url":"https://github.com/zeari/manageiq","homepage":"manageiq.org","size":81137,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"81fb227e5b2b655fa7b5b83f098ef2c8ded18d84","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":20789757,"name":"manageiq","full_name":"ManageIQ/manageiq","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq","description":"ManageIQ Cloud Management Platform","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq","forks_url":"https://api.github.com/repos/ManageIQ/manageiq/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq/releases{/id}","created_at":"2014-06-13T02:31:26Z","updated_at":"2015-08-20T09:13:01Z","pushed_at":"2015-08-25T13:06:15Z","git_url":"git://github.com/ManageIQ/manageiq.git","ssh_url":"git@github.com:ManageIQ/manageiq.git","clone_url":"https://github.com/ManageIQ/manageiq.git","svn_url":"https://github.com/ManageIQ/manageiq","homepage":"manageiq.org","size":151576,"stargazers_count":132,"watchers_count":132,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":142,"mirror_url":null,"open_issues_count":396,"forks":142,"open_issues":396,"watchers":132,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/3856"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/3856"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/3856"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/3856/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/3856/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/3856/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq/statuses/84a144c199dd67210357c619bc30dba07802ef9e"}}}}