{"action":"created","issue":{"url":"https://api.github.com/repos/simplabs/ember-simple-auth/issues/726","labels_url":"https://api.github.com/repos/simplabs/ember-simple-auth/issues/726/labels{/name}","comments_url":"https://api.github.com/repos/simplabs/ember-simple-auth/issues/726/comments","events_url":"https://api.github.com/repos/simplabs/ember-simple-auth/issues/726/events","html_url":"https://github.com/simplabs/ember-simple-auth/pull/726","id":111984069,"number":726,"title":"make clientSecret work","user":{"login":"ServiceTo","id":4366064,"avatar_url":"https://avatars.githubusercontent.com/u/4366064?v=3","gravatar_id":"","url":"https://api.github.com/users/ServiceTo","html_url":"https://github.com/ServiceTo","followers_url":"https://api.github.com/users/ServiceTo/followers","following_url":"https://api.github.com/users/ServiceTo/following{/other_user}","gists_url":"https://api.github.com/users/ServiceTo/gists{/gist_id}","starred_url":"https://api.github.com/users/ServiceTo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ServiceTo/subscriptions","organizations_url":"https://api.github.com/users/ServiceTo/orgs","repos_url":"https://api.github.com/users/ServiceTo/repos","events_url":"https://api.github.com/users/ServiceTo/events{/privacy}","received_events_url":"https://api.github.com/users/ServiceTo/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-10-17T20:51:19Z","updated_at":"2015-10-18T06:45:18Z","closed_at":"2015-10-18T06:45:18Z","pull_request":{"url":"https://api.github.com/repos/simplabs/ember-simple-auth/pulls/726","html_url":"https://github.com/simplabs/ember-simple-auth/pull/726","diff_url":"https://github.com/simplabs/ember-simple-auth/pull/726.diff","patch_url":"https://github.com/simplabs/ember-simple-auth/pull/726.patch"},"body":"I wasn't able to update my simple-auth implementation to ember-simple-auth without this little modification.\r\n\r\nMy `app/authenticators/oauth2.js` changed to:\r\n```\r\nimport OAuth2PasswordGrant from 'ember-simple-auth/authenticators/oauth2-password-grant';\r\nimport ENV from 'appname/config/environment';\r\n \r\nexport default OAuth2PasswordGrant.extend({\r\n       serverTokenEndpoint: ENV.oauth2.serverTokenEndpoint,\r\n       serverTokenRevocationEndpoint: ENV.oauth2.serverTokenRevocationEndpoint,\r\n       clientId: ENV.APP.client_id,\r\n       clientSecret: ENV.APP.client_secret\r\n});\r\n```"},"comment":{"url":"https://api.github.com/repos/simplabs/ember-simple-auth/issues/comments/148985431","html_url":"https://github.com/simplabs/ember-simple-auth/pull/726#issuecomment-148985431","issue_url":"https://api.github.com/repos/simplabs/ember-simple-auth/issues/726","id":148985431,"user":{"login":"marcoow","id":1510,"avatar_url":"https://avatars.githubusercontent.com/u/1510?v=3","gravatar_id":"","url":"https://api.github.com/users/marcoow","html_url":"https://github.com/marcoow","followers_url":"https://api.github.com/users/marcoow/followers","following_url":"https://api.github.com/users/marcoow/following{/other_user}","gists_url":"https://api.github.com/users/marcoow/gists{/gist_id}","starred_url":"https://api.github.com/users/marcoow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcoow/subscriptions","organizations_url":"https://api.github.com/users/marcoow/orgs","repos_url":"https://api.github.com/users/marcoow/repos","events_url":"https://api.github.com/users/marcoow/events{/privacy}","received_events_url":"https://api.github.com/users/marcoow/received_events","type":"User","site_admin":false},"created_at":"2015-10-18T06:45:18Z","updated_at":"2015-10-18T06:45:18Z","body":"You should not use `clienr_secret` in an Ember app as i iss not a secret anymore when it is included in your app's source. "}}