{"action":"created","comment":{"url":"https://api.github.com/repos/slimphp/Slim/pulls/comments/34332242","id":34332242,"diff_hunk":"@@ -371,9 +371,12 @@ public function __invoke(ServerRequestInterface $request, ResponseInterface $res\n     {\n         $routeInfo = $this->container->get('router')->dispatch($request);\n         if ($routeInfo[0] === Dispatcher::FOUND) {\n-            /** @var InvocationStrategyInterface $handler */\n-            $handler = $this->container->get('foundHandler');\n-            return $handler->invoke($this->container, $routeInfo, $request, $response);\n+            $routeArguments = [];\n+            foreach ($routeInfo[2] as $k => $v) {\n+                $routeArguments[$k] = urldecode($v);\n+            }\n+            $request = $request->withAttribute('routeArguments', $routeArguments);","path":"Slim/App.php","position":11,"original_position":11,"commit_id":"a52054e28c89e36b24c9c7610a84112e3eb15927","original_commit_id":"a52054e28c89e36b24c9c7610a84112e3eb15927","user":{"login":"akrabat","id":33135,"avatar_url":"https://avatars.githubusercontent.com/u/33135?v=3","gravatar_id":"","url":"https://api.github.com/users/akrabat","html_url":"https://github.com/akrabat","followers_url":"https://api.github.com/users/akrabat/followers","following_url":"https://api.github.com/users/akrabat/following{/other_user}","gists_url":"https://api.github.com/users/akrabat/gists{/gist_id}","starred_url":"https://api.github.com/users/akrabat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akrabat/subscriptions","organizations_url":"https://api.github.com/users/akrabat/orgs","repos_url":"https://api.github.com/users/akrabat/repos","events_url":"https://api.github.com/users/akrabat/events{/privacy}","received_events_url":"https://api.github.com/users/akrabat/received_events","type":"User","site_admin":false},"body":"Why have a sub-array for these arguments? It now means that you can no longer add an attribute in app middleware and have it available in the callback's `$args`.","created_at":"2015-07-10T07:16:16Z","updated_at":"2015-07-10T07:16:16Z","html_url":"https://github.com/slimphp/Slim/pull/1346#discussion_r34332242","pull_request_url":"https://api.github.com/repos/slimphp/Slim/pulls/1346","_links":{"self":{"href":"https://api.github.com/repos/slimphp/Slim/pulls/comments/34332242"},"html":{"href":"https://github.com/slimphp/Slim/pull/1346#discussion_r34332242"},"pull_request":{"href":"https://api.github.com/repos/slimphp/Slim/pulls/1346"}}},"pull_request":{"url":"https://api.github.com/repos/slimphp/Slim/pulls/1346","id":39609427,"html_url":"https://github.com/slimphp/Slim/pull/1346","diff_url":"https://github.com/slimphp/Slim/pull/1346.diff","patch_url":"https://github.com/slimphp/Slim/pull/1346.patch","issue_url":"https://api.github.com/repos/slimphp/Slim/issues/1346","number":1346,"state":"closed","locked":false,"title":"Use __invoke for InvocationStrategyInterface and remove container","user":{"login":"opengeek","id":232812,"avatar_url":"https://avatars.githubusercontent.com/u/232812?v=3","gravatar_id":"","url":"https://api.github.com/users/opengeek","html_url":"https://github.com/opengeek","followers_url":"https://api.github.com/users/opengeek/followers","following_url":"https://api.github.com/users/opengeek/following{/other_user}","gists_url":"https://api.github.com/users/opengeek/gists{/gist_id}","starred_url":"https://api.github.com/users/opengeek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opengeek/subscriptions","organizations_url":"https://api.github.com/users/opengeek/orgs","repos_url":"https://api.github.com/users/opengeek/repos","events_url":"https://api.github.com/users/opengeek/events{/privacy}","received_events_url":"https://api.github.com/users/opengeek/received_events","type":"User","site_admin":false},"body":"Refactored InvocationStrategyInterface and implementation; now with working code and tests to prove it for both included strategies!","created_at":"2015-07-09T17:44:55Z","updated_at":"2015-07-10T07:16:16Z","closed_at":"2015-07-09T17:46:57Z","merged_at":"2015-07-09T17:46:57Z","merge_commit_sha":"69351619a698b7eb9c2edc7ed48370cb74c9c0b8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/slimphp/Slim/pulls/1346/commits","review_comments_url":"https://api.github.com/repos/slimphp/Slim/pulls/1346/comments","review_comment_url":"https://api.github.com/repos/slimphp/Slim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/slimphp/Slim/issues/1346/comments","statuses_url":"https://api.github.com/repos/slimphp/Slim/statuses/a52054e28c89e36b24c9c7610a84112e3eb15927","head":{"label":"opengeek:refineFoundHandler","ref":"refineFoundHandler","sha":"a52054e28c89e36b24c9c7610a84112e3eb15927","user":{"login":"opengeek","id":232812,"avatar_url":"https://avatars.githubusercontent.com/u/232812?v=3","gravatar_id":"","url":"https://api.github.com/users/opengeek","html_url":"https://github.com/opengeek","followers_url":"https://api.github.com/users/opengeek/followers","following_url":"https://api.github.com/users/opengeek/following{/other_user}","gists_url":"https://api.github.com/users/opengeek/gists{/gist_id}","starred_url":"https://api.github.com/users/opengeek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opengeek/subscriptions","organizations_url":"https://api.github.com/users/opengeek/orgs","repos_url":"https://api.github.com/users/opengeek/repos","events_url":"https://api.github.com/users/opengeek/events{/privacy}","received_events_url":"https://api.github.com/users/opengeek/received_events","type":"User","site_admin":false},"repo":{"id":30900534,"name":"Slim","full_name":"opengeek/Slim","owner":{"login":"opengeek","id":232812,"avatar_url":"https://avatars.githubusercontent.com/u/232812?v=3","gravatar_id":"","url":"https://api.github.com/users/opengeek","html_url":"https://github.com/opengeek","followers_url":"https://api.github.com/users/opengeek/followers","following_url":"https://api.github.com/users/opengeek/following{/other_user}","gists_url":"https://api.github.com/users/opengeek/gists{/gist_id}","starred_url":"https://api.github.com/users/opengeek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opengeek/subscriptions","organizations_url":"https://api.github.com/users/opengeek/orgs","repos_url":"https://api.github.com/users/opengeek/repos","events_url":"https://api.github.com/users/opengeek/events{/privacy}","received_events_url":"https://api.github.com/users/opengeek/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/opengeek/Slim","description":"A PHP micro framework","fork":true,"url":"https://api.github.com/repos/opengeek/Slim","forks_url":"https://api.github.com/repos/opengeek/Slim/forks","keys_url":"https://api.github.com/repos/opengeek/Slim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opengeek/Slim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opengeek/Slim/teams","hooks_url":"https://api.github.com/repos/opengeek/Slim/hooks","issue_events_url":"https://api.github.com/repos/opengeek/Slim/issues/events{/number}","events_url":"https://api.github.com/repos/opengeek/Slim/events","assignees_url":"https://api.github.com/repos/opengeek/Slim/assignees{/user}","branches_url":"https://api.github.com/repos/opengeek/Slim/branches{/branch}","tags_url":"https://api.github.com/repos/opengeek/Slim/tags","blobs_url":"https://api.github.com/repos/opengeek/Slim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opengeek/Slim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opengeek/Slim/git/refs{/sha}","trees_url":"https://api.github.com/repos/opengeek/Slim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opengeek/Slim/statuses/{sha}","languages_url":"https://api.github.com/repos/opengeek/Slim/languages","stargazers_url":"https://api.github.com/repos/opengeek/Slim/stargazers","contributors_url":"https://api.github.com/repos/opengeek/Slim/contributors","subscribers_url":"https://api.github.com/repos/opengeek/Slim/subscribers","subscription_url":"https://api.github.com/repos/opengeek/Slim/subscription","commits_url":"https://api.github.com/repos/opengeek/Slim/commits{/sha}","git_commits_url":"https://api.github.com/repos/opengeek/Slim/git/commits{/sha}","comments_url":"https://api.github.com/repos/opengeek/Slim/comments{/number}","issue_comment_url":"https://api.github.com/repos/opengeek/Slim/issues/comments{/number}","contents_url":"https://api.github.com/repos/opengeek/Slim/contents/{+path}","compare_url":"https://api.github.com/repos/opengeek/Slim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opengeek/Slim/merges","archive_url":"https://api.github.com/repos/opengeek/Slim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opengeek/Slim/downloads","issues_url":"https://api.github.com/repos/opengeek/Slim/issues{/number}","pulls_url":"https://api.github.com/repos/opengeek/Slim/pulls{/number}","milestones_url":"https://api.github.com/repos/opengeek/Slim/milestones{/number}","notifications_url":"https://api.github.com/repos/opengeek/Slim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opengeek/Slim/labels{/name}","releases_url":"https://api.github.com/repos/opengeek/Slim/releases{/id}","created_at":"2015-02-17T03:13:27Z","updated_at":"2015-03-19T13:56:26Z","pushed_at":"2015-07-09T17:41:01Z","git_url":"git://github.com/opengeek/Slim.git","ssh_url":"git@github.com:opengeek/Slim.git","clone_url":"https://github.com/opengeek/Slim.git","svn_url":"https://github.com/opengeek/Slim","homepage":"http://www.slimframework.com","size":4530,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"3.x"}},"base":{"label":"slimphp:3.x","ref":"3.x","sha":"66afb557b51ca98793cfcdf74d557a15cb8b5ace","user":{"login":"slimphp","id":11195762,"avatar_url":"https://avatars.githubusercontent.com/u/11195762?v=3","gravatar_id":"","url":"https://api.github.com/users/slimphp","html_url":"https://github.com/slimphp","followers_url":"https://api.github.com/users/slimphp/followers","following_url":"https://api.github.com/users/slimphp/following{/other_user}","gists_url":"https://api.github.com/users/slimphp/gists{/gist_id}","starred_url":"https://api.github.com/users/slimphp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slimphp/subscriptions","organizations_url":"https://api.github.com/users/slimphp/orgs","repos_url":"https://api.github.com/users/slimphp/repos","events_url":"https://api.github.com/users/slimphp/events{/privacy}","received_events_url":"https://api.github.com/users/slimphp/received_events","type":"Organization","site_admin":false},"repo":{"id":926544,"name":"Slim","full_name":"slimphp/Slim","owner":{"login":"slimphp","id":11195762,"avatar_url":"https://avatars.githubusercontent.com/u/11195762?v=3","gravatar_id":"","url":"https://api.github.com/users/slimphp","html_url":"https://github.com/slimphp","followers_url":"https://api.github.com/users/slimphp/followers","following_url":"https://api.github.com/users/slimphp/following{/other_user}","gists_url":"https://api.github.com/users/slimphp/gists{/gist_id}","starred_url":"https://api.github.com/users/slimphp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slimphp/subscriptions","organizations_url":"https://api.github.com/users/slimphp/orgs","repos_url":"https://api.github.com/users/slimphp/repos","events_url":"https://api.github.com/users/slimphp/events{/privacy}","received_events_url":"https://api.github.com/users/slimphp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/slimphp/Slim","description":"Slim Framework source code","fork":false,"url":"https://api.github.com/repos/slimphp/Slim","forks_url":"https://api.github.com/repos/slimphp/Slim/forks","keys_url":"https://api.github.com/repos/slimphp/Slim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/slimphp/Slim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/slimphp/Slim/teams","hooks_url":"https://api.github.com/repos/slimphp/Slim/hooks","issue_events_url":"https://api.github.com/repos/slimphp/Slim/issues/events{/number}","events_url":"https://api.github.com/repos/slimphp/Slim/events","assignees_url":"https://api.github.com/repos/slimphp/Slim/assignees{/user}","branches_url":"https://api.github.com/repos/slimphp/Slim/branches{/branch}","tags_url":"https://api.github.com/repos/slimphp/Slim/tags","blobs_url":"https://api.github.com/repos/slimphp/Slim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/slimphp/Slim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/slimphp/Slim/git/refs{/sha}","trees_url":"https://api.github.com/repos/slimphp/Slim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/slimphp/Slim/statuses/{sha}","languages_url":"https://api.github.com/repos/slimphp/Slim/languages","stargazers_url":"https://api.github.com/repos/slimphp/Slim/stargazers","contributors_url":"https://api.github.com/repos/slimphp/Slim/contributors","subscribers_url":"https://api.github.com/repos/slimphp/Slim/subscribers","subscription_url":"https://api.github.com/repos/slimphp/Slim/subscription","commits_url":"https://api.github.com/repos/slimphp/Slim/commits{/sha}","git_commits_url":"https://api.github.com/repos/slimphp/Slim/git/commits{/sha}","comments_url":"https://api.github.com/repos/slimphp/Slim/comments{/number}","issue_comment_url":"https://api.github.com/repos/slimphp/Slim/issues/comments{/number}","contents_url":"https://api.github.com/repos/slimphp/Slim/contents/{+path}","compare_url":"https://api.github.com/repos/slimphp/Slim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/slimphp/Slim/merges","archive_url":"https://api.github.com/repos/slimphp/Slim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/slimphp/Slim/downloads","issues_url":"https://api.github.com/repos/slimphp/Slim/issues{/number}","pulls_url":"https://api.github.com/repos/slimphp/Slim/pulls{/number}","milestones_url":"https://api.github.com/repos/slimphp/Slim/milestones{/number}","notifications_url":"https://api.github.com/repos/slimphp/Slim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/slimphp/Slim/labels{/name}","releases_url":"https://api.github.com/repos/slimphp/Slim/releases{/id}","created_at":"2010-09-21T01:17:06Z","updated_at":"2015-07-10T01:06:10Z","pushed_at":"2015-07-10T03:35:52Z","git_url":"git://github.com/slimphp/Slim.git","ssh_url":"git@github.com:slimphp/Slim.git","clone_url":"https://github.com/slimphp/Slim.git","svn_url":"https://github.com/slimphp/Slim","homepage":"http://slimframework.com","size":356372,"stargazers_count":5431,"watchers_count":5431,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":982,"mirror_url":null,"open_issues_count":21,"forks":982,"open_issues":21,"watchers":5431,"default_branch":"2.x"}},"_links":{"self":{"href":"https://api.github.com/repos/slimphp/Slim/pulls/1346"},"html":{"href":"https://github.com/slimphp/Slim/pull/1346"},"issue":{"href":"https://api.github.com/repos/slimphp/Slim/issues/1346"},"comments":{"href":"https://api.github.com/repos/slimphp/Slim/issues/1346/comments"},"review_comments":{"href":"https://api.github.com/repos/slimphp/Slim/pulls/1346/comments"},"review_comment":{"href":"https://api.github.com/repos/slimphp/Slim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/slimphp/Slim/pulls/1346/commits"},"statuses":{"href":"https://api.github.com/repos/slimphp/Slim/statuses/a52054e28c89e36b24c9c7610a84112e3eb15927"}}}}