{"action":"created","comment":{"url":"https://api.github.com/repos/grpc/grpc/pulls/comments/29078479","id":29078479,"diff_hunk":"@@ -303,12 +271,7 @@ - (void)didReceiveValue:(id)value {\n // Only called from the call queue. The error handler will be called from the\n // network queue if the requests stream couldn't be closed successfully.\n - (void)finishRequestWithErrorHandler:(void (^)())errorHandler {\n-  GRPCEventHandler handler = ^(grpc_event *event) {\n-    if (event->data.finish_accepted != GRPC_OP_OK) {\n-      errorHandler();\n-    }\n-  };\n-  AssertNoErrorInCall(grpc_call_writes_done_old(_gRPCCall, (__bridge_retained void *)handler));\n+  [_wrappedCall startBatch:@{@(GRPC_OP_SEND_CLOSE_FROM_CLIENT): @YES} handleCompletion:^(NSDictionary *event){}];","path":"src/objective-c/GRPCClient/GRPCCall.m","position":160,"original_position":160,"commit_id":"463a7a86ba297a8165060d1289533ca33d1a52f2","original_commit_id":"463a7a86ba297a8165060d1289533ca33d1a52f2","user":{"login":"jcanizales","id":5120183,"avatar_url":"https://avatars.githubusercontent.com/u/5120183?v=3","gravatar_id":"","url":"https://api.github.com/users/jcanizales","html_url":"https://github.com/jcanizales","followers_url":"https://api.github.com/users/jcanizales/followers","following_url":"https://api.github.com/users/jcanizales/following{/other_user}","gists_url":"https://api.github.com/users/jcanizales/gists{/gist_id}","starred_url":"https://api.github.com/users/jcanizales/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcanizales/subscriptions","organizations_url":"https://api.github.com/users/jcanizales/orgs","repos_url":"https://api.github.com/users/jcanizales/repos","events_url":"https://api.github.com/users/jcanizales/events{/privacy}","received_events_url":"https://api.github.com/users/jcanizales/received_events","type":"User","site_admin":false},"body":"(nil for noop blocks, as above)","created_at":"2015-04-24T19:31:12Z","updated_at":"2015-04-24T19:31:12Z","html_url":"https://github.com/grpc/grpc/pull/1363#discussion_r29078479","pull_request_url":"https://api.github.com/repos/grpc/grpc/pulls/1363","_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc/pulls/comments/29078479"},"html":{"href":"https://github.com/grpc/grpc/pull/1363#discussion_r29078479"},"pull_request":{"href":"https://api.github.com/repos/grpc/grpc/pulls/1363"}}},"pull_request":{"url":"https://api.github.com/repos/grpc/grpc/pulls/1363","id":34070136,"html_url":"https://github.com/grpc/grpc/pull/1363","diff_url":"https://github.com/grpc/grpc/pull/1363.diff","patch_url":"https://github.com/grpc/grpc/pull/1363.patch","issue_url":"https://api.github.com/repos/grpc/grpc/issues/1363","number":1363,"state":"open","locked":false,"title":"Migrated Objective C library to C batch API","user":{"login":"murgatroid99","id":961599,"avatar_url":"https://avatars.githubusercontent.com/u/961599?v=3","gravatar_id":"","url":"https://api.github.com/users/murgatroid99","html_url":"https://github.com/murgatroid99","followers_url":"https://api.github.com/users/murgatroid99/followers","following_url":"https://api.github.com/users/murgatroid99/following{/other_user}","gists_url":"https://api.github.com/users/murgatroid99/gists{/gist_id}","starred_url":"https://api.github.com/users/murgatroid99/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/murgatroid99/subscriptions","organizations_url":"https://api.github.com/users/murgatroid99/orgs","repos_url":"https://api.github.com/users/murgatroid99/repos","events_url":"https://api.github.com/users/murgatroid99/events{/privacy}","received_events_url":"https://api.github.com/users/murgatroid99/received_events","type":"User","site_admin":false},"body":"This closes #1345. A later pull request should modify the higher-level interface to make better use of batches.","created_at":"2015-04-24T17:43:39Z","updated_at":"2015-04-24T19:31:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"24038435fcb53ded053311ecdd6c542e16ee6ef7","assignee":{"login":"jcanizales","id":5120183,"avatar_url":"https://avatars.githubusercontent.com/u/5120183?v=3","gravatar_id":"","url":"https://api.github.com/users/jcanizales","html_url":"https://github.com/jcanizales","followers_url":"https://api.github.com/users/jcanizales/followers","following_url":"https://api.github.com/users/jcanizales/following{/other_user}","gists_url":"https://api.github.com/users/jcanizales/gists{/gist_id}","starred_url":"https://api.github.com/users/jcanizales/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcanizales/subscriptions","organizations_url":"https://api.github.com/users/jcanizales/orgs","repos_url":"https://api.github.com/users/jcanizales/repos","events_url":"https://api.github.com/users/jcanizales/events{/privacy}","received_events_url":"https://api.github.com/users/jcanizales/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/grpc/grpc/milestones/5","html_url":"https://github.com/grpc/grpc/milestones/Core%20Batch%20API%20Changeover","labels_url":"https://api.github.com/repos/grpc/grpc/milestones/5/labels","id":958509,"number":5,"title":"Core Batch API Changeover","description":"Move all wrappings to the new batch oriented core APIs, delete references to the old APIs.","creator":{"login":"ctiller","id":10120821,"avatar_url":"https://avatars.githubusercontent.com/u/10120821?v=3","gravatar_id":"","url":"https://api.github.com/users/ctiller","html_url":"https://github.com/ctiller","followers_url":"https://api.github.com/users/ctiller/followers","following_url":"https://api.github.com/users/ctiller/following{/other_user}","gists_url":"https://api.github.com/users/ctiller/gists{/gist_id}","starred_url":"https://api.github.com/users/ctiller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctiller/subscriptions","organizations_url":"https://api.github.com/users/ctiller/orgs","repos_url":"https://api.github.com/users/ctiller/repos","events_url":"https://api.github.com/users/ctiller/events{/privacy}","received_events_url":"https://api.github.com/users/ctiller/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":4,"state":"open","created_at":"2015-01-30T16:25:33Z","updated_at":"2015-04-24T17:43:39Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/grpc/grpc/pulls/1363/commits","review_comments_url":"https://api.github.com/repos/grpc/grpc/pulls/1363/comments","review_comment_url":"https://api.github.com/repos/grpc/grpc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/grpc/grpc/issues/1363/comments","statuses_url":"https://api.github.com/repos/grpc/grpc/statuses/463a7a86ba297a8165060d1289533ca33d1a52f2","head":{"label":"murgatroid99:objective_c_batch_migration","ref":"objective_c_batch_migration","sha":"463a7a86ba297a8165060d1289533ca33d1a52f2","user":{"login":"murgatroid99","id":961599,"avatar_url":"https://avatars.githubusercontent.com/u/961599?v=3","gravatar_id":"","url":"https://api.github.com/users/murgatroid99","html_url":"https://github.com/murgatroid99","followers_url":"https://api.github.com/users/murgatroid99/followers","following_url":"https://api.github.com/users/murgatroid99/following{/other_user}","gists_url":"https://api.github.com/users/murgatroid99/gists{/gist_id}","starred_url":"https://api.github.com/users/murgatroid99/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/murgatroid99/subscriptions","organizations_url":"https://api.github.com/users/murgatroid99/orgs","repos_url":"https://api.github.com/users/murgatroid99/repos","events_url":"https://api.github.com/users/murgatroid99/events{/privacy}","received_events_url":"https://api.github.com/users/murgatroid99/received_events","type":"User","site_admin":false},"repo":{"id":31379612,"name":"grpc","full_name":"murgatroid99/grpc","owner":{"login":"murgatroid99","id":961599,"avatar_url":"https://avatars.githubusercontent.com/u/961599?v=3","gravatar_id":"","url":"https://api.github.com/users/murgatroid99","html_url":"https://github.com/murgatroid99","followers_url":"https://api.github.com/users/murgatroid99/followers","following_url":"https://api.github.com/users/murgatroid99/following{/other_user}","gists_url":"https://api.github.com/users/murgatroid99/gists{/gist_id}","starred_url":"https://api.github.com/users/murgatroid99/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/murgatroid99/subscriptions","organizations_url":"https://api.github.com/users/murgatroid99/orgs","repos_url":"https://api.github.com/users/murgatroid99/repos","events_url":"https://api.github.com/users/murgatroid99/events{/privacy}","received_events_url":"https://api.github.com/users/murgatroid99/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/murgatroid99/grpc","description":"The C based gRPC (C++, Node.js, Python, Ruby, Objective-C, PHP, C#)","fork":true,"url":"https://api.github.com/repos/murgatroid99/grpc","forks_url":"https://api.github.com/repos/murgatroid99/grpc/forks","keys_url":"https://api.github.com/repos/murgatroid99/grpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/murgatroid99/grpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/murgatroid99/grpc/teams","hooks_url":"https://api.github.com/repos/murgatroid99/grpc/hooks","issue_events_url":"https://api.github.com/repos/murgatroid99/grpc/issues/events{/number}","events_url":"https://api.github.com/repos/murgatroid99/grpc/events","assignees_url":"https://api.github.com/repos/murgatroid99/grpc/assignees{/user}","branches_url":"https://api.github.com/repos/murgatroid99/grpc/branches{/branch}","tags_url":"https://api.github.com/repos/murgatroid99/grpc/tags","blobs_url":"https://api.github.com/repos/murgatroid99/grpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/murgatroid99/grpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/murgatroid99/grpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/murgatroid99/grpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/murgatroid99/grpc/statuses/{sha}","languages_url":"https://api.github.com/repos/murgatroid99/grpc/languages","stargazers_url":"https://api.github.com/repos/murgatroid99/grpc/stargazers","contributors_url":"https://api.github.com/repos/murgatroid99/grpc/contributors","subscribers_url":"https://api.github.com/repos/murgatroid99/grpc/subscribers","subscription_url":"https://api.github.com/repos/murgatroid99/grpc/subscription","commits_url":"https://api.github.com/repos/murgatroid99/grpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/murgatroid99/grpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/murgatroid99/grpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/murgatroid99/grpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/murgatroid99/grpc/contents/{+path}","compare_url":"https://api.github.com/repos/murgatroid99/grpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/murgatroid99/grpc/merges","archive_url":"https://api.github.com/repos/murgatroid99/grpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/murgatroid99/grpc/downloads","issues_url":"https://api.github.com/repos/murgatroid99/grpc/issues{/number}","pulls_url":"https://api.github.com/repos/murgatroid99/grpc/pulls{/number}","milestones_url":"https://api.github.com/repos/murgatroid99/grpc/milestones{/number}","notifications_url":"https://api.github.com/repos/murgatroid99/grpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/murgatroid99/grpc/labels{/name}","releases_url":"https://api.github.com/repos/murgatroid99/grpc/releases{/id}","created_at":"2015-02-26T17:35:55Z","updated_at":"2015-04-23T20:47:37Z","pushed_at":"2015-04-24T18:41:47Z","git_url":"git://github.com/murgatroid99/grpc.git","ssh_url":"git@github.com:murgatroid99/grpc.git","clone_url":"https://github.com/murgatroid99/grpc.git","svn_url":"https://github.com/murgatroid99/grpc","homepage":"","size":19771,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"grpc:master","ref":"master","sha":"884f4dad58891a119c53af664680c134c73723b3","user":{"login":"grpc","id":7802525,"avatar_url":"https://avatars.githubusercontent.com/u/7802525?v=3","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"repo":{"id":27729880,"name":"grpc","full_name":"grpc/grpc","owner":{"login":"grpc","id":7802525,"avatar_url":"https://avatars.githubusercontent.com/u/7802525?v=3","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/grpc/grpc","description":"The C based gRPC (C++, Node.js, Python, Ruby, Objective-C, PHP, C#)","fork":false,"url":"https://api.github.com/repos/grpc/grpc","forks_url":"https://api.github.com/repos/grpc/grpc/forks","keys_url":"https://api.github.com/repos/grpc/grpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grpc/grpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grpc/grpc/teams","hooks_url":"https://api.github.com/repos/grpc/grpc/hooks","issue_events_url":"https://api.github.com/repos/grpc/grpc/issues/events{/number}","events_url":"https://api.github.com/repos/grpc/grpc/events","assignees_url":"https://api.github.com/repos/grpc/grpc/assignees{/user}","branches_url":"https://api.github.com/repos/grpc/grpc/branches{/branch}","tags_url":"https://api.github.com/repos/grpc/grpc/tags","blobs_url":"https://api.github.com/repos/grpc/grpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grpc/grpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grpc/grpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/grpc/grpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grpc/grpc/statuses/{sha}","languages_url":"https://api.github.com/repos/grpc/grpc/languages","stargazers_url":"https://api.github.com/repos/grpc/grpc/stargazers","contributors_url":"https://api.github.com/repos/grpc/grpc/contributors","subscribers_url":"https://api.github.com/repos/grpc/grpc/subscribers","subscription_url":"https://api.github.com/repos/grpc/grpc/subscription","commits_url":"https://api.github.com/repos/grpc/grpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/grpc/grpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/grpc/grpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/grpc/grpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/grpc/grpc/contents/{+path}","compare_url":"https://api.github.com/repos/grpc/grpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grpc/grpc/merges","archive_url":"https://api.github.com/repos/grpc/grpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grpc/grpc/downloads","issues_url":"https://api.github.com/repos/grpc/grpc/issues{/number}","pulls_url":"https://api.github.com/repos/grpc/grpc/pulls{/number}","milestones_url":"https://api.github.com/repos/grpc/grpc/milestones{/number}","notifications_url":"https://api.github.com/repos/grpc/grpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grpc/grpc/labels{/name}","releases_url":"https://api.github.com/repos/grpc/grpc/releases{/id}","created_at":"2014-12-08T18:58:53Z","updated_at":"2015-04-24T16:05:50Z","pushed_at":"2015-04-24T18:41:47Z","git_url":"git://github.com/grpc/grpc.git","ssh_url":"git@github.com:grpc/grpc.git","clone_url":"https://github.com/grpc/grpc.git","svn_url":"https://github.com/grpc/grpc","homepage":"","size":41596,"stargazers_count":2477,"watchers_count":2477,"language":"C","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":323,"mirror_url":null,"open_issues_count":190,"forks":323,"open_issues":190,"watchers":2477,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc/pulls/1363"},"html":{"href":"https://github.com/grpc/grpc/pull/1363"},"issue":{"href":"https://api.github.com/repos/grpc/grpc/issues/1363"},"comments":{"href":"https://api.github.com/repos/grpc/grpc/issues/1363/comments"},"review_comments":{"href":"https://api.github.com/repos/grpc/grpc/pulls/1363/comments"},"review_comment":{"href":"https://api.github.com/repos/grpc/grpc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/grpc/grpc/pulls/1363/commits"},"statuses":{"href":"https://api.github.com/repos/grpc/grpc/statuses/463a7a86ba297a8165060d1289533ca33d1a52f2"}}}}