{"action":"closed","issue":{"url":"https://api.github.com/repos/HabitRPG/habitrpg/issues/4507","labels_url":"https://api.github.com/repos/HabitRPG/habitrpg/issues/4507/labels{/name}","comments_url":"https://api.github.com/repos/HabitRPG/habitrpg/issues/4507/comments","events_url":"https://api.github.com/repos/HabitRPG/habitrpg/issues/4507/events","html_url":"https://github.com/HabitRPG/habitrpg/issues/4507","id":54014226,"number":4507,"title":"Snowballing a user before they've logged in that day prevents them from seeing it","user":{"login":"Feriority","id":1574494,"avatar_url":"https://avatars.githubusercontent.com/u/1574494?v=3","gravatar_id":"","url":"https://api.github.com/users/Feriority","html_url":"https://github.com/Feriority","followers_url":"https://api.github.com/users/Feriority/followers","following_url":"https://api.github.com/users/Feriority/following{/other_user}","gists_url":"https://api.github.com/users/Feriority/gists{/gist_id}","starred_url":"https://api.github.com/users/Feriority/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Feriority/subscriptions","organizations_url":"https://api.github.com/users/Feriority/orgs","repos_url":"https://api.github.com/users/Feriority/repos","events_url":"https://api.github.com/users/Feriority/events{/privacy}","received_events_url":"https://api.github.com/users/Feriority/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/HabitRPG/habitrpg/labels/cron","name":"cron","color":"bfd4f2"},{"url":"https://api.github.com/repos/HabitRPG/habitrpg/labels/priority%20-%20minor","name":"priority - minor","color":"DDDDDD"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-01-12T01:57:59Z","updated_at":"2015-05-18T04:29:30Z","closed_at":"2015-05-18T04:29:29Z","body":"A friend snowballed me, but when I logged in I couldn't see the effect (and neither could he, any more).  My best theory is that, since the snowball is reset by cron, and I hadn't logged in yet that day, when I did log in, it immediately triggered cron, which cleared my snowball state even though it hadn't been a full 24 hours.\r\n\r\nI don't see anything explicitly setting snowball in cron, but we set buffs to an object without snowball.  My proposed change would set snowball (and I guess the ghost equivalent?) explicitly based on whether the user has been snowballed since their last change of day (IE if my day changes at midnight and I was snowballed at 12:01, logging in at 12:02 shouldn't reset it; if I was snowballed at 11:59 the previous night, then logging in after 12 should).  This is made a little more complicated by needing to store the time of the most recent snowball somewhere on the user, so there's a data change involved.\r\n\r\nDoes that seem reasonable?\r\n\r\n<bountysource-plugin>\r\n---\r\nWant to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/7663636-snowballing-a-user-before-they-ve-logged-in-that-day-prevents-them-from-seeing-it?utm_campaign=plugin&utm_content=tracker%2F68393&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F68393&utm_medium=issues&utm_source=github).\r\n</bountysource-plugin>"}}