{"action":"created","comment":{"url":"https://api.github.com/repos/apache/cordova-plugin-file/pulls/comments/43965498","id":43965498,"diff_hunk":"@@ -168,6 +168,15 @@ WinFS.prototype.__format__ = function(fullPath) {\n     return 'cdvfile://localhost' + path;\n };\n \n+var windowsPaths = {\n+    dataDirectory: \"ms-appdata:///local/\",\n+    cacheDirectory: \"ms-appdata:///temp/\",\n+    tempDirectory: \"ms-appdata:///temp/\",\n+    syncedDataDirectory: \"ms-appdata:///roaming/\",\n+    applicationDirectory: \"ms-appdata:///\",","path":"src/windows/FileProxy.js","position":9,"original_position":9,"commit_id":"60f5394cd2589d2a73b1c2263ff0ddd397eb3022","original_commit_id":"60f5394cd2589d2a73b1c2263ff0ddd397eb3022","user":{"login":"jasongin","id":13093042,"avatar_url":"https://avatars.githubusercontent.com/u/13093042?v=3","gravatar_id":"","url":"https://api.github.com/users/jasongin","html_url":"https://github.com/jasongin","followers_url":"https://api.github.com/users/jasongin/followers","following_url":"https://api.github.com/users/jasongin/following{/other_user}","gists_url":"https://api.github.com/users/jasongin/gists{/gist_id}","starred_url":"https://api.github.com/users/jasongin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasongin/subscriptions","organizations_url":"https://api.github.com/users/jasongin/orgs","repos_url":"https://api.github.com/users/jasongin/repos","events_url":"https://api.github.com/users/jasongin/events{/privacy}","received_events_url":"https://api.github.com/users/jasongin/received_events","type":"User","site_admin":false},"body":"I think applicationDirectory and applicationStorageDirectory should point to ms-appx:/// rather than ms-appdata:///","created_at":"2015-11-05T01:12:46Z","updated_at":"2015-11-05T01:12:46Z","html_url":"https://github.com/apache/cordova-plugin-file/pull/143#discussion_r43965498","pull_request_url":"https://api.github.com/repos/apache/cordova-plugin-file/pulls/143","_links":{"self":{"href":"https://api.github.com/repos/apache/cordova-plugin-file/pulls/comments/43965498"},"html":{"href":"https://github.com/apache/cordova-plugin-file/pull/143#discussion_r43965498"},"pull_request":{"href":"https://api.github.com/repos/apache/cordova-plugin-file/pulls/143"}}},"pull_request":{"url":"https://api.github.com/repos/apache/cordova-plugin-file/pulls/143","id":48967639,"html_url":"https://github.com/apache/cordova-plugin-file/pull/143","diff_url":"https://github.com/apache/cordova-plugin-file/pull/143.diff","patch_url":"https://github.com/apache/cordova-plugin-file/pull/143.patch","issue_url":"https://api.github.com/repos/apache/cordova-plugin-file/issues/143","number":143,"state":"open","locked":false,"title":"CB-9887 cordova.file.* paths for windows platform","user":{"login":"ghenry22","id":7463213,"avatar_url":"https://avatars.githubusercontent.com/u/7463213?v=3","gravatar_id":"","url":"https://api.github.com/users/ghenry22","html_url":"https://github.com/ghenry22","followers_url":"https://api.github.com/users/ghenry22/followers","following_url":"https://api.github.com/users/ghenry22/following{/other_user}","gists_url":"https://api.github.com/users/ghenry22/gists{/gist_id}","starred_url":"https://api.github.com/users/ghenry22/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghenry22/subscriptions","organizations_url":"https://api.github.com/users/ghenry22/orgs","repos_url":"https://api.github.com/users/ghenry22/repos","events_url":"https://api.github.com/users/ghenry22/events{/privacy}","received_events_url":"https://api.github.com/users/ghenry22/received_events","type":"User","site_admin":false},"body":"Update the plugin to define cordova.file.* paths for windows platform as appropriate.\r\n\r\nDocumentation updated to show where to store things.\r\n\r\nHave tested this in my own app and the paths are detected as file plugin works as expected now.\r\n\r\nMeans you can use cordova.file.dataDirectory in your app and then run that app on ios, android, windows with consistent behaviour without requiring platform specific code.","created_at":"2015-10-28T05:59:35Z","updated_at":"2015-11-05T01:12:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4a1a1c6574301500acc9be16d7e481876e61f621","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/cordova-plugin-file/pulls/143/commits","review_comments_url":"https://api.github.com/repos/apache/cordova-plugin-file/pulls/143/comments","review_comment_url":"https://api.github.com/repos/apache/cordova-plugin-file/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/cordova-plugin-file/issues/143/comments","statuses_url":"https://api.github.com/repos/apache/cordova-plugin-file/statuses/60f5394cd2589d2a73b1c2263ff0ddd397eb3022","head":{"label":"ghenry22:windows_paths","ref":"windows_paths","sha":"60f5394cd2589d2a73b1c2263ff0ddd397eb3022","user":{"login":"ghenry22","id":7463213,"avatar_url":"https://avatars.githubusercontent.com/u/7463213?v=3","gravatar_id":"","url":"https://api.github.com/users/ghenry22","html_url":"https://github.com/ghenry22","followers_url":"https://api.github.com/users/ghenry22/followers","following_url":"https://api.github.com/users/ghenry22/following{/other_user}","gists_url":"https://api.github.com/users/ghenry22/gists{/gist_id}","starred_url":"https://api.github.com/users/ghenry22/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghenry22/subscriptions","organizations_url":"https://api.github.com/users/ghenry22/orgs","repos_url":"https://api.github.com/users/ghenry22/repos","events_url":"https://api.github.com/users/ghenry22/events{/privacy}","received_events_url":"https://api.github.com/users/ghenry22/received_events","type":"User","site_admin":false},"repo":{"id":45086744,"name":"cordova-plugin-file","full_name":"ghenry22/cordova-plugin-file","owner":{"login":"ghenry22","id":7463213,"avatar_url":"https://avatars.githubusercontent.com/u/7463213?v=3","gravatar_id":"","url":"https://api.github.com/users/ghenry22","html_url":"https://github.com/ghenry22","followers_url":"https://api.github.com/users/ghenry22/followers","following_url":"https://api.github.com/users/ghenry22/following{/other_user}","gists_url":"https://api.github.com/users/ghenry22/gists{/gist_id}","starred_url":"https://api.github.com/users/ghenry22/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghenry22/subscriptions","organizations_url":"https://api.github.com/users/ghenry22/orgs","repos_url":"https://api.github.com/users/ghenry22/repos","events_url":"https://api.github.com/users/ghenry22/events{/privacy}","received_events_url":"https://api.github.com/users/ghenry22/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ghenry22/cordova-plugin-file","description":"Mirror of Apache Cordova Plugin file","fork":true,"url":"https://api.github.com/repos/ghenry22/cordova-plugin-file","forks_url":"https://api.github.com/repos/ghenry22/cordova-plugin-file/forks","keys_url":"https://api.github.com/repos/ghenry22/cordova-plugin-file/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ghenry22/cordova-plugin-file/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ghenry22/cordova-plugin-file/teams","hooks_url":"https://api.github.com/repos/ghenry22/cordova-plugin-file/hooks","issue_events_url":"https://api.github.com/repos/ghenry22/cordova-plugin-file/issues/events{/number}","events_url":"https://api.github.com/repos/ghenry22/cordova-plugin-file/events","assignees_url":"https://api.github.com/repos/ghenry22/cordova-plugin-file/assignees{/user}","branches_url":"https://api.github.com/repos/ghenry22/cordova-plugin-file/branches{/branch}","tags_url":"https://api.github.com/repos/ghenry22/cordova-plugin-file/tags","blobs_url":"https://api.github.com/repos/ghenry22/cordova-plugin-file/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ghenry22/cordova-plugin-file/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ghenry22/cordova-plugin-file/git/refs{/sha}","trees_url":"https://api.github.com/repos/ghenry22/cordova-plugin-file/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ghenry22/cordova-plugin-file/statuses/{sha}","languages_url":"https://api.github.com/repos/ghenry22/cordova-plugin-file/languages","stargazers_url":"https://api.github.com/repos/ghenry22/cordova-plugin-file/stargazers","contributors_url":"https://api.github.com/repos/ghenry22/cordova-plugin-file/contributors","subscribers_url":"https://api.github.com/repos/ghenry22/cordova-plugin-file/subscribers","subscription_url":"https://api.github.com/repos/ghenry22/cordova-plugin-file/subscription","commits_url":"https://api.github.com/repos/ghenry22/cordova-plugin-file/commits{/sha}","git_commits_url":"https://api.github.com/repos/ghenry22/cordova-plugin-file/git/commits{/sha}","comments_url":"https://api.github.com/repos/ghenry22/cordova-plugin-file/comments{/number}","issue_comment_url":"https://api.github.com/repos/ghenry22/cordova-plugin-file/issues/comments{/number}","contents_url":"https://api.github.com/repos/ghenry22/cordova-plugin-file/contents/{+path}","compare_url":"https://api.github.com/repos/ghenry22/cordova-plugin-file/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ghenry22/cordova-plugin-file/merges","archive_url":"https://api.github.com/repos/ghenry22/cordova-plugin-file/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ghenry22/cordova-plugin-file/downloads","issues_url":"https://api.github.com/repos/ghenry22/cordova-plugin-file/issues{/number}","pulls_url":"https://api.github.com/repos/ghenry22/cordova-plugin-file/pulls{/number}","milestones_url":"https://api.github.com/repos/ghenry22/cordova-plugin-file/milestones{/number}","notifications_url":"https://api.github.com/repos/ghenry22/cordova-plugin-file/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ghenry22/cordova-plugin-file/labels{/name}","releases_url":"https://api.github.com/repos/ghenry22/cordova-plugin-file/releases{/id}","created_at":"2015-10-28T03:34:29Z","updated_at":"2015-10-28T03:34:31Z","pushed_at":"2015-11-03T02:25:58Z","git_url":"git://github.com/ghenry22/cordova-plugin-file.git","ssh_url":"git@github.com:ghenry22/cordova-plugin-file.git","clone_url":"https://github.com/ghenry22/cordova-plugin-file.git","svn_url":"https://github.com/ghenry22/cordova-plugin-file","homepage":null,"size":1709,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"e093e8de3b305b7f462f415e20706c5e0b95979b","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":10860599,"name":"cordova-plugin-file","full_name":"apache/cordova-plugin-file","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/cordova-plugin-file","description":"Mirror of Apache Cordova Plugin file","fork":false,"url":"https://api.github.com/repos/apache/cordova-plugin-file","forks_url":"https://api.github.com/repos/apache/cordova-plugin-file/forks","keys_url":"https://api.github.com/repos/apache/cordova-plugin-file/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/cordova-plugin-file/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/cordova-plugin-file/teams","hooks_url":"https://api.github.com/repos/apache/cordova-plugin-file/hooks","issue_events_url":"https://api.github.com/repos/apache/cordova-plugin-file/issues/events{/number}","events_url":"https://api.github.com/repos/apache/cordova-plugin-file/events","assignees_url":"https://api.github.com/repos/apache/cordova-plugin-file/assignees{/user}","branches_url":"https://api.github.com/repos/apache/cordova-plugin-file/branches{/branch}","tags_url":"https://api.github.com/repos/apache/cordova-plugin-file/tags","blobs_url":"https://api.github.com/repos/apache/cordova-plugin-file/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/cordova-plugin-file/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/cordova-plugin-file/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/cordova-plugin-file/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/cordova-plugin-file/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/cordova-plugin-file/languages","stargazers_url":"https://api.github.com/repos/apache/cordova-plugin-file/stargazers","contributors_url":"https://api.github.com/repos/apache/cordova-plugin-file/contributors","subscribers_url":"https://api.github.com/repos/apache/cordova-plugin-file/subscribers","subscription_url":"https://api.github.com/repos/apache/cordova-plugin-file/subscription","commits_url":"https://api.github.com/repos/apache/cordova-plugin-file/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/cordova-plugin-file/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/cordova-plugin-file/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/cordova-plugin-file/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/cordova-plugin-file/contents/{+path}","compare_url":"https://api.github.com/repos/apache/cordova-plugin-file/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/cordova-plugin-file/merges","archive_url":"https://api.github.com/repos/apache/cordova-plugin-file/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/cordova-plugin-file/downloads","issues_url":"https://api.github.com/repos/apache/cordova-plugin-file/issues{/number}","pulls_url":"https://api.github.com/repos/apache/cordova-plugin-file/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/cordova-plugin-file/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/cordova-plugin-file/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/cordova-plugin-file/labels{/name}","releases_url":"https://api.github.com/repos/apache/cordova-plugin-file/releases{/id}","created_at":"2013-06-22T07:00:16Z","updated_at":"2015-11-03T03:09:20Z","pushed_at":"2015-11-04T18:30:18Z","git_url":"git://github.com/apache/cordova-plugin-file.git","ssh_url":"git@github.com:apache/cordova-plugin-file.git","clone_url":"https://github.com/apache/cordova-plugin-file.git","svn_url":"https://github.com/apache/cordova-plugin-file","homepage":null,"size":4475,"stargazers_count":195,"watchers_count":195,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":244,"mirror_url":"git://git.apache.org/cordova-plugin-file.git","open_issues_count":15,"forks":244,"open_issues":15,"watchers":195,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/cordova-plugin-file/pulls/143"},"html":{"href":"https://github.com/apache/cordova-plugin-file/pull/143"},"issue":{"href":"https://api.github.com/repos/apache/cordova-plugin-file/issues/143"},"comments":{"href":"https://api.github.com/repos/apache/cordova-plugin-file/issues/143/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/cordova-plugin-file/pulls/143/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/cordova-plugin-file/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/cordova-plugin-file/pulls/143/commits"},"statuses":{"href":"https://api.github.com/repos/apache/cordova-plugin-file/statuses/60f5394cd2589d2a73b1c2263ff0ddd397eb3022"}}}}