{"action":"closed","number":77,"pull_request":{"url":"https://api.github.com/repos/lipusz/liferay-portal/pulls/77","id":38237055,"html_url":"https://github.com/lipusz/liferay-portal/pull/77","diff_url":"https://github.com/lipusz/liferay-portal/pull/77.diff","patch_url":"https://github.com/lipusz/liferay-portal/pull/77.patch","issue_url":"https://api.github.com/repos/lipusz/liferay-portal/issues/77","number":77,"state":"closed","locked":false,"title":"LPS-56446 Email message sent from Invitation portlet exposes the sender host's user name in the Message-ID header","user":{"login":"IstvanD","id":6039187,"avatar_url":"https://avatars.githubusercontent.com/u/6039187?v=3","gravatar_id":"","url":"https://api.github.com/users/IstvanD","html_url":"https://github.com/IstvanD","followers_url":"https://api.github.com/users/IstvanD/followers","following_url":"https://api.github.com/users/IstvanD/following{/other_user}","gists_url":"https://api.github.com/users/IstvanD/gists{/gist_id}","starred_url":"https://api.github.com/users/IstvanD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IstvanD/subscriptions","organizations_url":"https://api.github.com/users/IstvanD/orgs","repos_url":"https://api.github.com/users/IstvanD/repos","events_url":"https://api.github.com/users/IstvanD/events{/privacy}","received_events_url":"https://api.github.com/users/IstvanD/received_events","type":"User","site_admin":false},"body":"Hi Tibor,\r\n\r\nBased on your comments in https://github.com/lipusz/liferay-portal/pull/76 and your modifications in https://github.com/IstvanD/liferay-portal/pull/15 I resend the solution which includes a unique ID for the message.\r\nThere are patterns of usage of setMailId() throughout in the code, however the IDs given as arguments are all belonging to the entries in whose service layer setMailId() is called upon.\r\nFor example, for Blogs Entry the ID is entry.getEntryId(), for MBMessages, it is message.getMessageId(), for KBArticle it is kbArticle.getKbArticleId() and so on.\r\nFor InternetAddresses there is no such ID, and for MailMessage it is our task to set it.\r\n\r\nI chose the timestamp as ID for differentiate between the messages. With this approach, each MailMessage will have a unique ID, and each of them will be sent.\r\n\r\nBest regards,\r\nIstván","created_at":"2015-06-22T14:26:38Z","updated_at":"2015-06-23T12:16:28Z","closed_at":"2015-06-23T12:16:28Z","merged_at":null,"merge_commit_sha":"a497cfa9643ad502ee496fa069c7b5489247e7f0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/lipusz/liferay-portal/pulls/77/commits","review_comments_url":"https://api.github.com/repos/lipusz/liferay-portal/pulls/77/comments","review_comment_url":"https://api.github.com/repos/lipusz/liferay-portal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lipusz/liferay-portal/issues/77/comments","statuses_url":"https://api.github.com/repos/lipusz/liferay-portal/statuses/fa8a954f410e23b32fb9b61af98d5bfb99d6a5fd","head":{"label":"IstvanD:LPS-56446","ref":"LPS-56446","sha":"fa8a954f410e23b32fb9b61af98d5bfb99d6a5fd","user":{"login":"IstvanD","id":6039187,"avatar_url":"https://avatars.githubusercontent.com/u/6039187?v=3","gravatar_id":"","url":"https://api.github.com/users/IstvanD","html_url":"https://github.com/IstvanD","followers_url":"https://api.github.com/users/IstvanD/followers","following_url":"https://api.github.com/users/IstvanD/following{/other_user}","gists_url":"https://api.github.com/users/IstvanD/gists{/gist_id}","starred_url":"https://api.github.com/users/IstvanD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IstvanD/subscriptions","organizations_url":"https://api.github.com/users/IstvanD/orgs","repos_url":"https://api.github.com/users/IstvanD/repos","events_url":"https://api.github.com/users/IstvanD/events{/privacy}","received_events_url":"https://api.github.com/users/IstvanD/received_events","type":"User","site_admin":false},"repo":{"id":15391852,"name":"liferay-portal","full_name":"IstvanD/liferay-portal","owner":{"login":"IstvanD","id":6039187,"avatar_url":"https://avatars.githubusercontent.com/u/6039187?v=3","gravatar_id":"","url":"https://api.github.com/users/IstvanD","html_url":"https://github.com/IstvanD","followers_url":"https://api.github.com/users/IstvanD/followers","following_url":"https://api.github.com/users/IstvanD/following{/other_user}","gists_url":"https://api.github.com/users/IstvanD/gists{/gist_id}","starred_url":"https://api.github.com/users/IstvanD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IstvanD/subscriptions","organizations_url":"https://api.github.com/users/IstvanD/orgs","repos_url":"https://api.github.com/users/IstvanD/repos","events_url":"https://api.github.com/users/IstvanD/events{/privacy}","received_events_url":"https://api.github.com/users/IstvanD/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/IstvanD/liferay-portal","description":"","fork":true,"url":"https://api.github.com/repos/IstvanD/liferay-portal","forks_url":"https://api.github.com/repos/IstvanD/liferay-portal/forks","keys_url":"https://api.github.com/repos/IstvanD/liferay-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/IstvanD/liferay-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/IstvanD/liferay-portal/teams","hooks_url":"https://api.github.com/repos/IstvanD/liferay-portal/hooks","issue_events_url":"https://api.github.com/repos/IstvanD/liferay-portal/issues/events{/number}","events_url":"https://api.github.com/repos/IstvanD/liferay-portal/events","assignees_url":"https://api.github.com/repos/IstvanD/liferay-portal/assignees{/user}","branches_url":"https://api.github.com/repos/IstvanD/liferay-portal/branches{/branch}","tags_url":"https://api.github.com/repos/IstvanD/liferay-portal/tags","blobs_url":"https://api.github.com/repos/IstvanD/liferay-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/IstvanD/liferay-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/IstvanD/liferay-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/IstvanD/liferay-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/IstvanD/liferay-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/IstvanD/liferay-portal/languages","stargazers_url":"https://api.github.com/repos/IstvanD/liferay-portal/stargazers","contributors_url":"https://api.github.com/repos/IstvanD/liferay-portal/contributors","subscribers_url":"https://api.github.com/repos/IstvanD/liferay-portal/subscribers","subscription_url":"https://api.github.com/repos/IstvanD/liferay-portal/subscription","commits_url":"https://api.github.com/repos/IstvanD/liferay-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/IstvanD/liferay-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/IstvanD/liferay-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/IstvanD/liferay-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/IstvanD/liferay-portal/contents/{+path}","compare_url":"https://api.github.com/repos/IstvanD/liferay-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/IstvanD/liferay-portal/merges","archive_url":"https://api.github.com/repos/IstvanD/liferay-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/IstvanD/liferay-portal/downloads","issues_url":"https://api.github.com/repos/IstvanD/liferay-portal/issues{/number}","pulls_url":"https://api.github.com/repos/IstvanD/liferay-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/IstvanD/liferay-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/IstvanD/liferay-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/IstvanD/liferay-portal/labels{/name}","releases_url":"https://api.github.com/repos/IstvanD/liferay-portal/releases{/id}","created_at":"2013-12-23T09:20:35Z","updated_at":"2015-05-08T07:10:22Z","pushed_at":"2015-06-23T08:56:54Z","git_url":"git://github.com/IstvanD/liferay-portal.git","ssh_url":"git@github.com:IstvanD/liferay-portal.git","clone_url":"https://github.com/IstvanD/liferay-portal.git","svn_url":"https://github.com/IstvanD/liferay-portal","homepage":"http://liferay.com","size":4598605,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"lipusz:master","ref":"master","sha":"0b11cc297dc24071ecd270122f594d63f94802eb","user":{"login":"lipusz","id":1556706,"avatar_url":"https://avatars.githubusercontent.com/u/1556706?v=3","gravatar_id":"","url":"https://api.github.com/users/lipusz","html_url":"https://github.com/lipusz","followers_url":"https://api.github.com/users/lipusz/followers","following_url":"https://api.github.com/users/lipusz/following{/other_user}","gists_url":"https://api.github.com/users/lipusz/gists{/gist_id}","starred_url":"https://api.github.com/users/lipusz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lipusz/subscriptions","organizations_url":"https://api.github.com/users/lipusz/orgs","repos_url":"https://api.github.com/users/lipusz/repos","events_url":"https://api.github.com/users/lipusz/events{/privacy}","received_events_url":"https://api.github.com/users/lipusz/received_events","type":"User","site_admin":false},"repo":{"id":3776081,"name":"liferay-portal","full_name":"lipusz/liferay-portal","owner":{"login":"lipusz","id":1556706,"avatar_url":"https://avatars.githubusercontent.com/u/1556706?v=3","gravatar_id":"","url":"https://api.github.com/users/lipusz","html_url":"https://github.com/lipusz","followers_url":"https://api.github.com/users/lipusz/followers","following_url":"https://api.github.com/users/lipusz/following{/other_user}","gists_url":"https://api.github.com/users/lipusz/gists{/gist_id}","starred_url":"https://api.github.com/users/lipusz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lipusz/subscriptions","organizations_url":"https://api.github.com/users/lipusz/orgs","repos_url":"https://api.github.com/users/lipusz/repos","events_url":"https://api.github.com/users/lipusz/events{/privacy}","received_events_url":"https://api.github.com/users/lipusz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lipusz/liferay-portal","description":"","fork":true,"url":"https://api.github.com/repos/lipusz/liferay-portal","forks_url":"https://api.github.com/repos/lipusz/liferay-portal/forks","keys_url":"https://api.github.com/repos/lipusz/liferay-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lipusz/liferay-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lipusz/liferay-portal/teams","hooks_url":"https://api.github.com/repos/lipusz/liferay-portal/hooks","issue_events_url":"https://api.github.com/repos/lipusz/liferay-portal/issues/events{/number}","events_url":"https://api.github.com/repos/lipusz/liferay-portal/events","assignees_url":"https://api.github.com/repos/lipusz/liferay-portal/assignees{/user}","branches_url":"https://api.github.com/repos/lipusz/liferay-portal/branches{/branch}","tags_url":"https://api.github.com/repos/lipusz/liferay-portal/tags","blobs_url":"https://api.github.com/repos/lipusz/liferay-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lipusz/liferay-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lipusz/liferay-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/lipusz/liferay-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lipusz/liferay-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/lipusz/liferay-portal/languages","stargazers_url":"https://api.github.com/repos/lipusz/liferay-portal/stargazers","contributors_url":"https://api.github.com/repos/lipusz/liferay-portal/contributors","subscribers_url":"https://api.github.com/repos/lipusz/liferay-portal/subscribers","subscription_url":"https://api.github.com/repos/lipusz/liferay-portal/subscription","commits_url":"https://api.github.com/repos/lipusz/liferay-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/lipusz/liferay-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/lipusz/liferay-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/lipusz/liferay-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/lipusz/liferay-portal/contents/{+path}","compare_url":"https://api.github.com/repos/lipusz/liferay-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lipusz/liferay-portal/merges","archive_url":"https://api.github.com/repos/lipusz/liferay-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lipusz/liferay-portal/downloads","issues_url":"https://api.github.com/repos/lipusz/liferay-portal/issues{/number}","pulls_url":"https://api.github.com/repos/lipusz/liferay-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/lipusz/liferay-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/lipusz/liferay-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lipusz/liferay-portal/labels{/name}","releases_url":"https://api.github.com/repos/lipusz/liferay-portal/releases{/id}","created_at":"2012-03-20T14:31:44Z","updated_at":"2015-05-08T07:11:46Z","pushed_at":"2015-06-23T12:10:11Z","git_url":"git://github.com/lipusz/liferay-portal.git","ssh_url":"git@github.com:lipusz/liferay-portal.git","clone_url":"https://github.com/lipusz/liferay-portal.git","svn_url":"https://github.com/lipusz/liferay-portal","homepage":"http://liferay.com","size":4671991,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lipusz/liferay-portal/pulls/77"},"html":{"href":"https://github.com/lipusz/liferay-portal/pull/77"},"issue":{"href":"https://api.github.com/repos/lipusz/liferay-portal/issues/77"},"comments":{"href":"https://api.github.com/repos/lipusz/liferay-portal/issues/77/comments"},"review_comments":{"href":"https://api.github.com/repos/lipusz/liferay-portal/pulls/77/comments"},"review_comment":{"href":"https://api.github.com/repos/lipusz/liferay-portal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lipusz/liferay-portal/pulls/77/commits"},"statuses":{"href":"https://api.github.com/repos/lipusz/liferay-portal/statuses/fa8a954f410e23b32fb9b61af98d5bfb99d6a5fd"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":5,"review_comments":0,"commits":4,"additions":11,"deletions":0,"changed_files":1}}