{"action":"created","comment":{"url":"https://api.github.com/repos/pandegroup/openmm/pulls/comments/30173221","id":30173221,"diff_hunk":"@@ -473,14 +473,11 @@ void CpuNonbondedForce::getDeltaR(const fvec4& posI, const fvec4& posJ, fvec4& d\n }\n \n float CpuNonbondedForce::erfcApprox(float x) {\n-    // This approximation for erfc is from Abramowitz and Stegun (1964) p. 299.  They cite the following as\n+    // This approximation for erfc is from Abramowitz and Stegun (1964) p. 299 Section 7.1.26.  They cite the following as\n     // the original source: C. Hastings, Jr., Approximations for Digital Computers (1955).  It has a maximum\n-    // error of 3e-7.\n+    // absolute error of 1.5e-7.\n \n-    float t = 1.0f+(0.0705230784f+(0.0422820123f+(0.0092705272f+(0.0001520143f+(0.0002765672f+0.0000430638f*x)*x)*x)*x)*x)*x;\n-    t *= t;\n-    t *= t;\n-    t *= t;\n-    return 1.0f/(t*t);\n+    float t = RECIP(1.0f+0.3275911f*x);","path":"platforms/cpu/src/CpuNonbondedForce.cpp","position":15,"original_position":15,"commit_id":"381f3981d4d907e4936ee755b2d8e8c9d51995fd","original_commit_id":"381f3981d4d907e4936ee755b2d8e8c9d51995fd","user":{"login":"jchodera","id":3656088,"avatar_url":"https://avatars.githubusercontent.com/u/3656088?v=3","gravatar_id":"","url":"https://api.github.com/users/jchodera","html_url":"https://github.com/jchodera","followers_url":"https://api.github.com/users/jchodera/followers","following_url":"https://api.github.com/users/jchodera/following{/other_user}","gists_url":"https://api.github.com/users/jchodera/gists{/gist_id}","starred_url":"https://api.github.com/users/jchodera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jchodera/subscriptions","organizations_url":"https://api.github.com/users/jchodera/orgs","repos_url":"https://api.github.com/users/jchodera/repos","events_url":"https://api.github.com/users/jchodera/events{/privacy}","received_events_url":"https://api.github.com/users/jchodera/received_events","type":"User","site_admin":false},"body":"Whoops!","created_at":"2015-05-12T19:53:56Z","updated_at":"2015-05-12T19:53:56Z","html_url":"https://github.com/pandegroup/openmm/pull/912#discussion_r30173221","pull_request_url":"https://api.github.com/repos/pandegroup/openmm/pulls/912","_links":{"self":{"href":"https://api.github.com/repos/pandegroup/openmm/pulls/comments/30173221"},"html":{"href":"https://github.com/pandegroup/openmm/pull/912#discussion_r30173221"},"pull_request":{"href":"https://api.github.com/repos/pandegroup/openmm/pulls/912"}}},"pull_request":{"url":"https://api.github.com/repos/pandegroup/openmm/pulls/912","id":35263721,"html_url":"https://github.com/pandegroup/openmm/pull/912","diff_url":"https://github.com/pandegroup/openmm/pull/912.diff","patch_url":"https://github.com/pandegroup/openmm/pull/912.patch","issue_url":"https://api.github.com/repos/pandegroup/openmm/issues/912","number":912,"state":"open","locked":false,"title":"[WIP] Change erfc approximation of CPU platform to match OpenCL implementation","user":{"login":"jchodera","id":3656088,"avatar_url":"https://avatars.githubusercontent.com/u/3656088?v=3","gravatar_id":"","url":"https://api.github.com/users/jchodera","html_url":"https://github.com/jchodera","followers_url":"https://api.github.com/users/jchodera/followers","following_url":"https://api.github.com/users/jchodera/following{/other_user}","gists_url":"https://api.github.com/users/jchodera/gists{/gist_id}","starred_url":"https://api.github.com/users/jchodera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jchodera/subscriptions","organizations_url":"https://api.github.com/users/jchodera/orgs","repos_url":"https://api.github.com/users/jchodera/repos","events_url":"https://api.github.com/users/jchodera/events{/privacy}","received_events_url":"https://api.github.com/users/jchodera/received_events","type":"User","site_admin":false},"body":"This change attempts to reduce the error in the erfc approximation utilized by the CPU platform (noted to be significant in #907) to match the OpenCL platform.\r\n\r\nStill testing.","created_at":"2015-05-12T19:52:18Z","updated_at":"2015-05-12T19:53:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fa7ad28a82566e864d3462476519a33465d03d6b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/pandegroup/openmm/pulls/912/commits","review_comments_url":"https://api.github.com/repos/pandegroup/openmm/pulls/912/comments","review_comment_url":"https://api.github.com/repos/pandegroup/openmm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pandegroup/openmm/issues/912/comments","statuses_url":"https://api.github.com/repos/pandegroup/openmm/statuses/381f3981d4d907e4936ee755b2d8e8c9d51995fd","head":{"label":"jchodera:fix-cpu-erfc-approx","ref":"fix-cpu-erfc-approx","sha":"381f3981d4d907e4936ee755b2d8e8c9d51995fd","user":{"login":"jchodera","id":3656088,"avatar_url":"https://avatars.githubusercontent.com/u/3656088?v=3","gravatar_id":"","url":"https://api.github.com/users/jchodera","html_url":"https://github.com/jchodera","followers_url":"https://api.github.com/users/jchodera/followers","following_url":"https://api.github.com/users/jchodera/following{/other_user}","gists_url":"https://api.github.com/users/jchodera/gists{/gist_id}","starred_url":"https://api.github.com/users/jchodera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jchodera/subscriptions","organizations_url":"https://api.github.com/users/jchodera/orgs","repos_url":"https://api.github.com/users/jchodera/repos","events_url":"https://api.github.com/users/jchodera/events{/privacy}","received_events_url":"https://api.github.com/users/jchodera/received_events","type":"User","site_admin":false},"repo":{"id":18042175,"name":"openmm","full_name":"jchodera/openmm","owner":{"login":"jchodera","id":3656088,"avatar_url":"https://avatars.githubusercontent.com/u/3656088?v=3","gravatar_id":"","url":"https://api.github.com/users/jchodera","html_url":"https://github.com/jchodera","followers_url":"https://api.github.com/users/jchodera/followers","following_url":"https://api.github.com/users/jchodera/following{/other_user}","gists_url":"https://api.github.com/users/jchodera/gists{/gist_id}","starred_url":"https://api.github.com/users/jchodera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jchodera/subscriptions","organizations_url":"https://api.github.com/users/jchodera/orgs","repos_url":"https://api.github.com/users/jchodera/repos","events_url":"https://api.github.com/users/jchodera/events{/privacy}","received_events_url":"https://api.github.com/users/jchodera/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jchodera/openmm","description":"OpenMM is a toolkit for molecular simulation using high performance GPU code. ","fork":true,"url":"https://api.github.com/repos/jchodera/openmm","forks_url":"https://api.github.com/repos/jchodera/openmm/forks","keys_url":"https://api.github.com/repos/jchodera/openmm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jchodera/openmm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jchodera/openmm/teams","hooks_url":"https://api.github.com/repos/jchodera/openmm/hooks","issue_events_url":"https://api.github.com/repos/jchodera/openmm/issues/events{/number}","events_url":"https://api.github.com/repos/jchodera/openmm/events","assignees_url":"https://api.github.com/repos/jchodera/openmm/assignees{/user}","branches_url":"https://api.github.com/repos/jchodera/openmm/branches{/branch}","tags_url":"https://api.github.com/repos/jchodera/openmm/tags","blobs_url":"https://api.github.com/repos/jchodera/openmm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jchodera/openmm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jchodera/openmm/git/refs{/sha}","trees_url":"https://api.github.com/repos/jchodera/openmm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jchodera/openmm/statuses/{sha}","languages_url":"https://api.github.com/repos/jchodera/openmm/languages","stargazers_url":"https://api.github.com/repos/jchodera/openmm/stargazers","contributors_url":"https://api.github.com/repos/jchodera/openmm/contributors","subscribers_url":"https://api.github.com/repos/jchodera/openmm/subscribers","subscription_url":"https://api.github.com/repos/jchodera/openmm/subscription","commits_url":"https://api.github.com/repos/jchodera/openmm/commits{/sha}","git_commits_url":"https://api.github.com/repos/jchodera/openmm/git/commits{/sha}","comments_url":"https://api.github.com/repos/jchodera/openmm/comments{/number}","issue_comment_url":"https://api.github.com/repos/jchodera/openmm/issues/comments{/number}","contents_url":"https://api.github.com/repos/jchodera/openmm/contents/{+path}","compare_url":"https://api.github.com/repos/jchodera/openmm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jchodera/openmm/merges","archive_url":"https://api.github.com/repos/jchodera/openmm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jchodera/openmm/downloads","issues_url":"https://api.github.com/repos/jchodera/openmm/issues{/number}","pulls_url":"https://api.github.com/repos/jchodera/openmm/pulls{/number}","milestones_url":"https://api.github.com/repos/jchodera/openmm/milestones{/number}","notifications_url":"https://api.github.com/repos/jchodera/openmm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jchodera/openmm/labels{/name}","releases_url":"https://api.github.com/repos/jchodera/openmm/releases{/id}","created_at":"2014-03-23T19:56:31Z","updated_at":"2015-04-24T04:01:28Z","pushed_at":"2015-05-12T19:51:15Z","git_url":"git://github.com/jchodera/openmm.git","ssh_url":"git@github.com:jchodera/openmm.git","clone_url":"https://github.com/jchodera/openmm.git","svn_url":"https://github.com/jchodera/openmm","homepage":null,"size":99532,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pandegroup:master","ref":"master","sha":"62f167ccc307066f27397e10b3e330c0cd5b965b","user":{"login":"pandegroup","id":2250873,"avatar_url":"https://avatars.githubusercontent.com/u/2250873?v=3","gravatar_id":"","url":"https://api.github.com/users/pandegroup","html_url":"https://github.com/pandegroup","followers_url":"https://api.github.com/users/pandegroup/followers","following_url":"https://api.github.com/users/pandegroup/following{/other_user}","gists_url":"https://api.github.com/users/pandegroup/gists{/gist_id}","starred_url":"https://api.github.com/users/pandegroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandegroup/subscriptions","organizations_url":"https://api.github.com/users/pandegroup/orgs","repos_url":"https://api.github.com/users/pandegroup/repos","events_url":"https://api.github.com/users/pandegroup/events{/privacy}","received_events_url":"https://api.github.com/users/pandegroup/received_events","type":"Organization","site_admin":false},"repo":{"id":10178188,"name":"openmm","full_name":"pandegroup/openmm","owner":{"login":"pandegroup","id":2250873,"avatar_url":"https://avatars.githubusercontent.com/u/2250873?v=3","gravatar_id":"","url":"https://api.github.com/users/pandegroup","html_url":"https://github.com/pandegroup","followers_url":"https://api.github.com/users/pandegroup/followers","following_url":"https://api.github.com/users/pandegroup/following{/other_user}","gists_url":"https://api.github.com/users/pandegroup/gists{/gist_id}","starred_url":"https://api.github.com/users/pandegroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandegroup/subscriptions","organizations_url":"https://api.github.com/users/pandegroup/orgs","repos_url":"https://api.github.com/users/pandegroup/repos","events_url":"https://api.github.com/users/pandegroup/events{/privacy}","received_events_url":"https://api.github.com/users/pandegroup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pandegroup/openmm","description":"OpenMM is a toolkit for molecular simulation using high performance GPU code. ","fork":false,"url":"https://api.github.com/repos/pandegroup/openmm","forks_url":"https://api.github.com/repos/pandegroup/openmm/forks","keys_url":"https://api.github.com/repos/pandegroup/openmm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pandegroup/openmm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pandegroup/openmm/teams","hooks_url":"https://api.github.com/repos/pandegroup/openmm/hooks","issue_events_url":"https://api.github.com/repos/pandegroup/openmm/issues/events{/number}","events_url":"https://api.github.com/repos/pandegroup/openmm/events","assignees_url":"https://api.github.com/repos/pandegroup/openmm/assignees{/user}","branches_url":"https://api.github.com/repos/pandegroup/openmm/branches{/branch}","tags_url":"https://api.github.com/repos/pandegroup/openmm/tags","blobs_url":"https://api.github.com/repos/pandegroup/openmm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pandegroup/openmm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pandegroup/openmm/git/refs{/sha}","trees_url":"https://api.github.com/repos/pandegroup/openmm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pandegroup/openmm/statuses/{sha}","languages_url":"https://api.github.com/repos/pandegroup/openmm/languages","stargazers_url":"https://api.github.com/repos/pandegroup/openmm/stargazers","contributors_url":"https://api.github.com/repos/pandegroup/openmm/contributors","subscribers_url":"https://api.github.com/repos/pandegroup/openmm/subscribers","subscription_url":"https://api.github.com/repos/pandegroup/openmm/subscription","commits_url":"https://api.github.com/repos/pandegroup/openmm/commits{/sha}","git_commits_url":"https://api.github.com/repos/pandegroup/openmm/git/commits{/sha}","comments_url":"https://api.github.com/repos/pandegroup/openmm/comments{/number}","issue_comment_url":"https://api.github.com/repos/pandegroup/openmm/issues/comments{/number}","contents_url":"https://api.github.com/repos/pandegroup/openmm/contents/{+path}","compare_url":"https://api.github.com/repos/pandegroup/openmm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pandegroup/openmm/merges","archive_url":"https://api.github.com/repos/pandegroup/openmm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pandegroup/openmm/downloads","issues_url":"https://api.github.com/repos/pandegroup/openmm/issues{/number}","pulls_url":"https://api.github.com/repos/pandegroup/openmm/pulls{/number}","milestones_url":"https://api.github.com/repos/pandegroup/openmm/milestones{/number}","notifications_url":"https://api.github.com/repos/pandegroup/openmm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pandegroup/openmm/labels{/name}","releases_url":"https://api.github.com/repos/pandegroup/openmm/releases{/id}","created_at":"2013-05-20T17:42:52Z","updated_at":"2015-05-10T23:56:05Z","pushed_at":"2015-05-12T19:52:18Z","git_url":"git://github.com/pandegroup/openmm.git","ssh_url":"git@github.com:pandegroup/openmm.git","clone_url":"https://github.com/pandegroup/openmm.git","svn_url":"https://github.com/pandegroup/openmm","homepage":null,"size":104771,"stargazers_count":80,"watchers_count":80,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":48,"mirror_url":null,"open_issues_count":129,"forks":48,"open_issues":129,"watchers":80,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pandegroup/openmm/pulls/912"},"html":{"href":"https://github.com/pandegroup/openmm/pull/912"},"issue":{"href":"https://api.github.com/repos/pandegroup/openmm/issues/912"},"comments":{"href":"https://api.github.com/repos/pandegroup/openmm/issues/912/comments"},"review_comments":{"href":"https://api.github.com/repos/pandegroup/openmm/pulls/912/comments"},"review_comment":{"href":"https://api.github.com/repos/pandegroup/openmm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pandegroup/openmm/pulls/912/commits"},"statuses":{"href":"https://api.github.com/repos/pandegroup/openmm/statuses/381f3981d4d907e4936ee755b2d8e8c9d51995fd"}}}}