{"action":"created","issue":{"url":"https://api.github.com/repos/The-Compiler/qutebrowser/issues/962","labels_url":"https://api.github.com/repos/The-Compiler/qutebrowser/issues/962/labels{/name}","comments_url":"https://api.github.com/repos/The-Compiler/qutebrowser/issues/962/comments","events_url":"https://api.github.com/repos/The-Compiler/qutebrowser/issues/962/events","html_url":"https://github.com/The-Compiler/qutebrowser/pull/962","id":107394864,"number":962,"title":"[WIP] Download complete pages as .mhtml file","user":{"login":"Kingdread","id":739796,"avatar_url":"https://avatars.githubusercontent.com/u/739796?v=3","gravatar_id":"","url":"https://api.github.com/users/Kingdread","html_url":"https://github.com/Kingdread","followers_url":"https://api.github.com/users/Kingdread/followers","following_url":"https://api.github.com/users/Kingdread/following{/other_user}","gists_url":"https://api.github.com/users/Kingdread/gists{/gist_id}","starred_url":"https://api.github.com/users/Kingdread/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kingdread/subscriptions","organizations_url":"https://api.github.com/users/Kingdread/orgs","repos_url":"https://api.github.com/users/Kingdread/repos","events_url":"https://api.github.com/users/Kingdread/events{/privacy}","received_events_url":"https://api.github.com/users/Kingdread/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"The-Compiler","id":625793,"avatar_url":"https://avatars.githubusercontent.com/u/625793?v=3","gravatar_id":"","url":"https://api.github.com/users/The-Compiler","html_url":"https://github.com/The-Compiler","followers_url":"https://api.github.com/users/The-Compiler/followers","following_url":"https://api.github.com/users/The-Compiler/following{/other_user}","gists_url":"https://api.github.com/users/The-Compiler/gists{/gist_id}","starred_url":"https://api.github.com/users/The-Compiler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/The-Compiler/subscriptions","organizations_url":"https://api.github.com/users/The-Compiler/orgs","repos_url":"https://api.github.com/users/The-Compiler/repos","events_url":"https://api.github.com/users/The-Compiler/events{/privacy}","received_events_url":"https://api.github.com/users/The-Compiler/received_events","type":"User","site_admin":false},"milestone":null,"comments":51,"created_at":"2015-09-20T14:17:05Z","updated_at":"2015-11-19T09:47:27Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls/962","html_url":"https://github.com/The-Compiler/qutebrowser/pull/962","diff_url":"https://github.com/The-Compiler/qutebrowser/pull/962.diff","patch_url":"https://github.com/The-Compiler/qutebrowser/pull/962.patch"},"body":"Issue #953.\r\n\r\nDownloads the current page and each referenced asset (currently stylesheets, scripts and images) into a .mhtml file. The file can be opened natively by qutebrowser and Opera, and with [unMHT](https://addons.mozilla.org/en-US/firefox/addon/unmht/) also by Firefox.\r\n\r\nI've focused on the logic so far, integration in the UI and code quality is yet to come."},"comment":{"url":"https://api.github.com/repos/The-Compiler/qutebrowser/issues/comments/158006222","html_url":"https://github.com/The-Compiler/qutebrowser/pull/962#issuecomment-158006222","issue_url":"https://api.github.com/repos/The-Compiler/qutebrowser/issues/962","id":158006222,"user":{"login":"Kingdread","id":739796,"avatar_url":"https://avatars.githubusercontent.com/u/739796?v=3","gravatar_id":"","url":"https://api.github.com/users/Kingdread","html_url":"https://github.com/Kingdread","followers_url":"https://api.github.com/users/Kingdread/followers","following_url":"https://api.github.com/users/Kingdread/following{/other_user}","gists_url":"https://api.github.com/users/Kingdread/gists{/gist_id}","starred_url":"https://api.github.com/users/Kingdread/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kingdread/subscriptions","organizations_url":"https://api.github.com/users/Kingdread/orgs","repos_url":"https://api.github.com/users/Kingdread/repos","events_url":"https://api.github.com/users/Kingdread/events{/privacy}","received_events_url":"https://api.github.com/users/Kingdread/received_events","type":"User","site_admin":false},"created_at":"2015-11-19T09:47:27Z","updated_at":"2015-11-19T09:47:27Z","body":"Do two negatives make a positive? :wink:\r\n\r\nYeah, sorry about the push/CI/backlog spam, I currently don't have a Windows machine available to test this myself and was relying on AppVeyor to provide the logs (though I will have one on the weekend when I'm home)...\r\n\r\nI first thought the Qt error message was the cause of the failing test, but then I saw the timeout. Looking at the logs it seems like `div-image` is requested (`DEBUG    downloads  mhtml:fetch_url:320 loading asset at PyQt5.QtCore.QUrl('http://localhost:1048/data/downloads/mhtml/complex/div-image.png')`, `DEBUG    downloads  downloads:fetch:843 fetch: PyQt5.QtCore.QUrl('http://localhost:1048/data/downloads/mhtml/complex/div-image.png') -> div-image.png`), but it somehow never even is requested (no log line from httpbin) and thus not finished (`DEBUG    downloads  mhtml:finished:358 Finished ..., remaining downloads: {(PyQt5.QtCore.QUrl('http://localhost:1048/data/downloads/mhtml/complex/div-image.png'), <qutebrowser.browser.downloads.DownloadItem basename='div-image.png'>)}`). That doesn't seem to be an issue with httpbin either, since requesting the file works fine if I embed it into the HTML (which the last commit did).\r\n\r\nI will see if I can add more test cases and track this down, otherwise I hope that being able to test faster and more often will help me too."}}