{"action":"created","comment":{"url":"https://api.github.com/repos/laravel/framework/pulls/comments/48428736","id":48428736,"diff_hunk":"@@ -1545,9 +1546,15 @@ protected function restoreFieldsForCount()\n      * @param  int  $count\n      * @param  callable  $callback\n      * @return bool\n+     *\n+     * @throws RuntimeException","path":"src/Illuminate/Database/Query/Builder.php","position":13,"original_position":13,"commit_id":"d13d59683e42d735b89770ae7fe3caf56909ad6f","original_commit_id":"d13d59683e42d735b89770ae7fe3caf56909ad6f","user":{"login":"GrahamCampbell","id":2829600,"avatar_url":"https://avatars.githubusercontent.com/u/2829600?v=3","gravatar_id":"","url":"https://api.github.com/users/GrahamCampbell","html_url":"https://github.com/GrahamCampbell","followers_url":"https://api.github.com/users/GrahamCampbell/followers","following_url":"https://api.github.com/users/GrahamCampbell/following{/other_user}","gists_url":"https://api.github.com/users/GrahamCampbell/gists{/gist_id}","starred_url":"https://api.github.com/users/GrahamCampbell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GrahamCampbell/subscriptions","organizations_url":"https://api.github.com/users/GrahamCampbell/orgs","repos_url":"https://api.github.com/users/GrahamCampbell/repos","events_url":"https://api.github.com/users/GrahamCampbell/events{/privacy}","received_events_url":"https://api.github.com/users/GrahamCampbell/received_events","type":"User","site_admin":false},"body":"Same","created_at":"2015-12-25T01:35:44Z","updated_at":"2015-12-25T01:35:44Z","html_url":"https://github.com/laravel/framework/pull/11510#discussion_r48428736","pull_request_url":"https://api.github.com/repos/laravel/framework/pulls/11510","_links":{"self":{"href":"https://api.github.com/repos/laravel/framework/pulls/comments/48428736"},"html":{"href":"https://github.com/laravel/framework/pull/11510#discussion_r48428736"},"pull_request":{"href":"https://api.github.com/repos/laravel/framework/pulls/11510"}}},"pull_request":{"url":"https://api.github.com/repos/laravel/framework/pulls/11510","id":54551427,"html_url":"https://github.com/laravel/framework/pull/11510","diff_url":"https://github.com/laravel/framework/pull/11510.diff","patch_url":"https://github.com/laravel/framework/pull/11510.patch","issue_url":"https://api.github.com/repos/laravel/framework/issues/11510","number":11510,"state":"open","locked":false,"title":"[5.3] [WIP] Chunk should require orderBy","user":{"login":"EspadaV8","id":115825,"avatar_url":"https://avatars.githubusercontent.com/u/115825?v=3","gravatar_id":"","url":"https://api.github.com/users/EspadaV8","html_url":"https://github.com/EspadaV8","followers_url":"https://api.github.com/users/EspadaV8/followers","following_url":"https://api.github.com/users/EspadaV8/following{/other_user}","gists_url":"https://api.github.com/users/EspadaV8/gists{/gist_id}","starred_url":"https://api.github.com/users/EspadaV8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EspadaV8/subscriptions","organizations_url":"https://api.github.com/users/EspadaV8/orgs","repos_url":"https://api.github.com/users/EspadaV8/repos","events_url":"https://api.github.com/users/EspadaV8/events{/privacy}","received_events_url":"https://api.github.com/users/EspadaV8/received_events","type":"User","site_admin":false},"body":"This is in reference to #11302 \r\n\r\nThis change makes sure that before chunking the results an `orderBy` has been set. If nothing was set by the user then the function will default to setting it to `id`. This can cause issues if a table doesn't have an `id` field.\r\n\r\nThe alternative would be to throw an exception if no `orderBy` has been set, but that would possibly be a huge breaking change.\r\n\r\nI've added some tests to make sure that an `order by` statement is added to the SQL that's generated, but I'm not sure if the tests cover enough (there currently aren't any tests at all for the `chunk` method).\r\n\r\nI'm open to all suggestions as to better/different ways to fix this.\r\n\r\nRelated to: #11490, #11489 ","created_at":"2015-12-24T13:34:21Z","updated_at":"2015-12-25T01:35:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d780807ee8f3b5b12f720978ee9e582d43143465","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/laravel/framework/pulls/11510/commits","review_comments_url":"https://api.github.com/repos/laravel/framework/pulls/11510/comments","review_comment_url":"https://api.github.com/repos/laravel/framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/laravel/framework/issues/11510/comments","statuses_url":"https://api.github.com/repos/laravel/framework/statuses/d13d59683e42d735b89770ae7fe3caf56909ad6f","head":{"label":"EspadaV8:feature/chunk-requires-orderby-5.3","ref":"feature/chunk-requires-orderby-5.3","sha":"d13d59683e42d735b89770ae7fe3caf56909ad6f","user":{"login":"EspadaV8","id":115825,"avatar_url":"https://avatars.githubusercontent.com/u/115825?v=3","gravatar_id":"","url":"https://api.github.com/users/EspadaV8","html_url":"https://github.com/EspadaV8","followers_url":"https://api.github.com/users/EspadaV8/followers","following_url":"https://api.github.com/users/EspadaV8/following{/other_user}","gists_url":"https://api.github.com/users/EspadaV8/gists{/gist_id}","starred_url":"https://api.github.com/users/EspadaV8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EspadaV8/subscriptions","organizations_url":"https://api.github.com/users/EspadaV8/orgs","repos_url":"https://api.github.com/users/EspadaV8/repos","events_url":"https://api.github.com/users/EspadaV8/events{/privacy}","received_events_url":"https://api.github.com/users/EspadaV8/received_events","type":"User","site_admin":false},"repo":{"id":15576604,"name":"framework","full_name":"EspadaV8/framework","owner":{"login":"EspadaV8","id":115825,"avatar_url":"https://avatars.githubusercontent.com/u/115825?v=3","gravatar_id":"","url":"https://api.github.com/users/EspadaV8","html_url":"https://github.com/EspadaV8","followers_url":"https://api.github.com/users/EspadaV8/followers","following_url":"https://api.github.com/users/EspadaV8/following{/other_user}","gists_url":"https://api.github.com/users/EspadaV8/gists{/gist_id}","starred_url":"https://api.github.com/users/EspadaV8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EspadaV8/subscriptions","organizations_url":"https://api.github.com/users/EspadaV8/orgs","repos_url":"https://api.github.com/users/EspadaV8/repos","events_url":"https://api.github.com/users/EspadaV8/events{/privacy}","received_events_url":"https://api.github.com/users/EspadaV8/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/EspadaV8/framework","description":"","fork":true,"url":"https://api.github.com/repos/EspadaV8/framework","forks_url":"https://api.github.com/repos/EspadaV8/framework/forks","keys_url":"https://api.github.com/repos/EspadaV8/framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/EspadaV8/framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/EspadaV8/framework/teams","hooks_url":"https://api.github.com/repos/EspadaV8/framework/hooks","issue_events_url":"https://api.github.com/repos/EspadaV8/framework/issues/events{/number}","events_url":"https://api.github.com/repos/EspadaV8/framework/events","assignees_url":"https://api.github.com/repos/EspadaV8/framework/assignees{/user}","branches_url":"https://api.github.com/repos/EspadaV8/framework/branches{/branch}","tags_url":"https://api.github.com/repos/EspadaV8/framework/tags","blobs_url":"https://api.github.com/repos/EspadaV8/framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/EspadaV8/framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/EspadaV8/framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/EspadaV8/framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/EspadaV8/framework/statuses/{sha}","languages_url":"https://api.github.com/repos/EspadaV8/framework/languages","stargazers_url":"https://api.github.com/repos/EspadaV8/framework/stargazers","contributors_url":"https://api.github.com/repos/EspadaV8/framework/contributors","subscribers_url":"https://api.github.com/repos/EspadaV8/framework/subscribers","subscription_url":"https://api.github.com/repos/EspadaV8/framework/subscription","commits_url":"https://api.github.com/repos/EspadaV8/framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/EspadaV8/framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/EspadaV8/framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/EspadaV8/framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/EspadaV8/framework/contents/{+path}","compare_url":"https://api.github.com/repos/EspadaV8/framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/EspadaV8/framework/merges","archive_url":"https://api.github.com/repos/EspadaV8/framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/EspadaV8/framework/downloads","issues_url":"https://api.github.com/repos/EspadaV8/framework/issues{/number}","pulls_url":"https://api.github.com/repos/EspadaV8/framework/pulls{/number}","milestones_url":"https://api.github.com/repos/EspadaV8/framework/milestones{/number}","notifications_url":"https://api.github.com/repos/EspadaV8/framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/EspadaV8/framework/labels{/name}","releases_url":"https://api.github.com/repos/EspadaV8/framework/releases{/id}","created_at":"2014-01-02T05:29:52Z","updated_at":"2015-12-23T11:26:58Z","pushed_at":"2015-12-24T21:50:43Z","git_url":"git://github.com/EspadaV8/framework.git","ssh_url":"git@github.com:EspadaV8/framework.git","clone_url":"https://github.com/EspadaV8/framework.git","svn_url":"https://github.com/EspadaV8/framework","homepage":"http://laravel.com","size":20774,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"laravel:master","ref":"master","sha":"24e844908d3961025912be54905f1041de6d6680","user":{"login":"laravel","id":958072,"avatar_url":"https://avatars.githubusercontent.com/u/958072?v=3","gravatar_id":"","url":"https://api.github.com/users/laravel","html_url":"https://github.com/laravel","followers_url":"https://api.github.com/users/laravel/followers","following_url":"https://api.github.com/users/laravel/following{/other_user}","gists_url":"https://api.github.com/users/laravel/gists{/gist_id}","starred_url":"https://api.github.com/users/laravel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laravel/subscriptions","organizations_url":"https://api.github.com/users/laravel/orgs","repos_url":"https://api.github.com/users/laravel/repos","events_url":"https://api.github.com/users/laravel/events{/privacy}","received_events_url":"https://api.github.com/users/laravel/received_events","type":"Organization","site_admin":false},"repo":{"id":7548986,"name":"framework","full_name":"laravel/framework","owner":{"login":"laravel","id":958072,"avatar_url":"https://avatars.githubusercontent.com/u/958072?v=3","gravatar_id":"","url":"https://api.github.com/users/laravel","html_url":"https://github.com/laravel","followers_url":"https://api.github.com/users/laravel/followers","following_url":"https://api.github.com/users/laravel/following{/other_user}","gists_url":"https://api.github.com/users/laravel/gists{/gist_id}","starred_url":"https://api.github.com/users/laravel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laravel/subscriptions","organizations_url":"https://api.github.com/users/laravel/orgs","repos_url":"https://api.github.com/users/laravel/repos","events_url":"https://api.github.com/users/laravel/events{/privacy}","received_events_url":"https://api.github.com/users/laravel/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/laravel/framework","description":"","fork":false,"url":"https://api.github.com/repos/laravel/framework","forks_url":"https://api.github.com/repos/laravel/framework/forks","keys_url":"https://api.github.com/repos/laravel/framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/laravel/framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/laravel/framework/teams","hooks_url":"https://api.github.com/repos/laravel/framework/hooks","issue_events_url":"https://api.github.com/repos/laravel/framework/issues/events{/number}","events_url":"https://api.github.com/repos/laravel/framework/events","assignees_url":"https://api.github.com/repos/laravel/framework/assignees{/user}","branches_url":"https://api.github.com/repos/laravel/framework/branches{/branch}","tags_url":"https://api.github.com/repos/laravel/framework/tags","blobs_url":"https://api.github.com/repos/laravel/framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/laravel/framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/laravel/framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/laravel/framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/laravel/framework/statuses/{sha}","languages_url":"https://api.github.com/repos/laravel/framework/languages","stargazers_url":"https://api.github.com/repos/laravel/framework/stargazers","contributors_url":"https://api.github.com/repos/laravel/framework/contributors","subscribers_url":"https://api.github.com/repos/laravel/framework/subscribers","subscription_url":"https://api.github.com/repos/laravel/framework/subscription","commits_url":"https://api.github.com/repos/laravel/framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/laravel/framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/laravel/framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/laravel/framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/laravel/framework/contents/{+path}","compare_url":"https://api.github.com/repos/laravel/framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/laravel/framework/merges","archive_url":"https://api.github.com/repos/laravel/framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/laravel/framework/downloads","issues_url":"https://api.github.com/repos/laravel/framework/issues{/number}","pulls_url":"https://api.github.com/repos/laravel/framework/pulls{/number}","milestones_url":"https://api.github.com/repos/laravel/framework/milestones{/number}","notifications_url":"https://api.github.com/repos/laravel/framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/laravel/framework/labels{/name}","releases_url":"https://api.github.com/repos/laravel/framework/releases{/id}","created_at":"2013-01-10T21:27:28Z","updated_at":"2015-12-24T14:56:45Z","pushed_at":"2015-12-24T21:50:44Z","git_url":"git://github.com/laravel/framework.git","ssh_url":"git@github.com:laravel/framework.git","clone_url":"https://github.com/laravel/framework.git","svn_url":"https://github.com/laravel/framework","homepage":"http://laravel.com","size":33290,"stargazers_count":4527,"watchers_count":4527,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2626,"mirror_url":null,"open_issues_count":31,"forks":2626,"open_issues":31,"watchers":4527,"default_branch":"5.2"}},"_links":{"self":{"href":"https://api.github.com/repos/laravel/framework/pulls/11510"},"html":{"href":"https://github.com/laravel/framework/pull/11510"},"issue":{"href":"https://api.github.com/repos/laravel/framework/issues/11510"},"comments":{"href":"https://api.github.com/repos/laravel/framework/issues/11510/comments"},"review_comments":{"href":"https://api.github.com/repos/laravel/framework/pulls/11510/comments"},"review_comment":{"href":"https://api.github.com/repos/laravel/framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/laravel/framework/pulls/11510/commits"},"statuses":{"href":"https://api.github.com/repos/laravel/framework/statuses/d13d59683e42d735b89770ae7fe3caf56909ad6f"}}}}