{"action":"created","comment":{"url":"https://api.github.com/repos/es-shims/es5-shim/pulls/comments/47157814","id":47157814,"diff_hunk":"@@ -1596,4 +1596,385 @@ describe('Array', function () {\n             expect(result).toEqual(['2', '3']);\n         });\n     });\n+\n+    describe('#sort()', function () {\n+        describe('usage', function () {\n+            it('requires a function or undefined as first argument', function () {\n+                var actual = [];\n+                expect(actual.sort()).toBe(actual);\n+                expect(actual.sort(undefined)).toBe(actual);\n+\n+                // http://ecma-international.org/ecma-262/5.1/#sec-15.4.4.11\n+                // If comparefn is not undefined and is not a consistent comparison\n+                // function for the elements of this array (see below), the behaviour\n+                // of sort is implementation-defined.\n+                // Some consitency would good here. Throw or not to throw.","path":"tests/spec/s-array.js","position":16,"original_position":16,"commit_id":"53c3ffc17e0a0a928f9886f77d4a00778b324f4c","original_commit_id":"53c3ffc17e0a0a928f9886f77d4a00778b324f4c","user":{"login":"ljharb","id":45469,"avatar_url":"https://avatars.githubusercontent.com/u/45469?v=3","gravatar_id":"","url":"https://api.github.com/users/ljharb","html_url":"https://github.com/ljharb","followers_url":"https://api.github.com/users/ljharb/followers","following_url":"https://api.github.com/users/ljharb/following{/other_user}","gists_url":"https://api.github.com/users/ljharb/gists{/gist_id}","starred_url":"https://api.github.com/users/ljharb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ljharb/subscriptions","organizations_url":"https://api.github.com/users/ljharb/orgs","repos_url":"https://api.github.com/users/ljharb/repos","events_url":"https://api.github.com/users/ljharb/events{/privacy}","received_events_url":"https://api.github.com/users/ljharb/received_events","type":"User","site_admin":false},"body":"consistency","created_at":"2015-12-09T21:53:29Z","updated_at":"2015-12-09T21:53:29Z","html_url":"https://github.com/es-shims/es5-shim/pull/354#discussion_r47157814","pull_request_url":"https://api.github.com/repos/es-shims/es5-shim/pulls/354","_links":{"self":{"href":"https://api.github.com/repos/es-shims/es5-shim/pulls/comments/47157814"},"html":{"href":"https://github.com/es-shims/es5-shim/pull/354#discussion_r47157814"},"pull_request":{"href":"https://api.github.com/repos/es-shims/es5-shim/pulls/354"}}},"pull_request":{"url":"https://api.github.com/repos/es-shims/es5-shim/pulls/354","id":51237688,"html_url":"https://github.com/es-shims/es5-shim/pull/354","diff_url":"https://github.com/es-shims/es5-shim/pull/354.diff","patch_url":"https://github.com/es-shims/es5-shim/pull/354.patch","issue_url":"https://api.github.com/repos/es-shims/es5-shim/issues/354","number":354,"state":"open","locked":false,"title":"Add tests for `Array#sort`","user":{"login":"Xotic750","id":216041,"avatar_url":"https://avatars.githubusercontent.com/u/216041?v=3","gravatar_id":"","url":"https://api.github.com/users/Xotic750","html_url":"https://github.com/Xotic750","followers_url":"https://api.github.com/users/Xotic750/followers","following_url":"https://api.github.com/users/Xotic750/following{/other_user}","gists_url":"https://api.github.com/users/Xotic750/gists{/gist_id}","starred_url":"https://api.github.com/users/Xotic750/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Xotic750/subscriptions","organizations_url":"https://api.github.com/users/Xotic750/orgs","repos_url":"https://api.github.com/users/Xotic750/repos","events_url":"https://api.github.com/users/Xotic750/events{/privacy}","received_events_url":"https://api.github.com/users/Xotic750/received_events","type":"User","site_admin":false},"body":"Throws on all versions of IE, and some other environments.","created_at":"2015-11-19T15:34:57Z","updated_at":"2015-12-09T21:53:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e86af98f958b34811779d7361cb793decc639ad9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/es-shims/es5-shim/pulls/354/commits","review_comments_url":"https://api.github.com/repos/es-shims/es5-shim/pulls/354/comments","review_comment_url":"https://api.github.com/repos/es-shims/es5-shim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/es-shims/es5-shim/issues/354/comments","statuses_url":"https://api.github.com/repos/es-shims/es5-shim/statuses/53c3ffc17e0a0a928f9886f77d4a00778b324f4c","head":{"label":"Xotic750:sort","ref":"sort","sha":"53c3ffc17e0a0a928f9886f77d4a00778b324f4c","user":{"login":"Xotic750","id":216041,"avatar_url":"https://avatars.githubusercontent.com/u/216041?v=3","gravatar_id":"","url":"https://api.github.com/users/Xotic750","html_url":"https://github.com/Xotic750","followers_url":"https://api.github.com/users/Xotic750/followers","following_url":"https://api.github.com/users/Xotic750/following{/other_user}","gists_url":"https://api.github.com/users/Xotic750/gists{/gist_id}","starred_url":"https://api.github.com/users/Xotic750/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Xotic750/subscriptions","organizations_url":"https://api.github.com/users/Xotic750/orgs","repos_url":"https://api.github.com/users/Xotic750/repos","events_url":"https://api.github.com/users/Xotic750/events{/privacy}","received_events_url":"https://api.github.com/users/Xotic750/received_events","type":"User","site_admin":false},"repo":{"id":16054066,"name":"es5-shim","full_name":"Xotic750/es5-shim","owner":{"login":"Xotic750","id":216041,"avatar_url":"https://avatars.githubusercontent.com/u/216041?v=3","gravatar_id":"","url":"https://api.github.com/users/Xotic750","html_url":"https://github.com/Xotic750","followers_url":"https://api.github.com/users/Xotic750/followers","following_url":"https://api.github.com/users/Xotic750/following{/other_user}","gists_url":"https://api.github.com/users/Xotic750/gists{/gist_id}","starred_url":"https://api.github.com/users/Xotic750/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Xotic750/subscriptions","organizations_url":"https://api.github.com/users/Xotic750/orgs","repos_url":"https://api.github.com/users/Xotic750/repos","events_url":"https://api.github.com/users/Xotic750/events{/privacy}","received_events_url":"https://api.github.com/users/Xotic750/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Xotic750/es5-shim","description":"ECMAScript 5 compatibility shims for legacy JavaScript engines","fork":true,"url":"https://api.github.com/repos/Xotic750/es5-shim","forks_url":"https://api.github.com/repos/Xotic750/es5-shim/forks","keys_url":"https://api.github.com/repos/Xotic750/es5-shim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Xotic750/es5-shim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Xotic750/es5-shim/teams","hooks_url":"https://api.github.com/repos/Xotic750/es5-shim/hooks","issue_events_url":"https://api.github.com/repos/Xotic750/es5-shim/issues/events{/number}","events_url":"https://api.github.com/repos/Xotic750/es5-shim/events","assignees_url":"https://api.github.com/repos/Xotic750/es5-shim/assignees{/user}","branches_url":"https://api.github.com/repos/Xotic750/es5-shim/branches{/branch}","tags_url":"https://api.github.com/repos/Xotic750/es5-shim/tags","blobs_url":"https://api.github.com/repos/Xotic750/es5-shim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Xotic750/es5-shim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Xotic750/es5-shim/git/refs{/sha}","trees_url":"https://api.github.com/repos/Xotic750/es5-shim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Xotic750/es5-shim/statuses/{sha}","languages_url":"https://api.github.com/repos/Xotic750/es5-shim/languages","stargazers_url":"https://api.github.com/repos/Xotic750/es5-shim/stargazers","contributors_url":"https://api.github.com/repos/Xotic750/es5-shim/contributors","subscribers_url":"https://api.github.com/repos/Xotic750/es5-shim/subscribers","subscription_url":"https://api.github.com/repos/Xotic750/es5-shim/subscription","commits_url":"https://api.github.com/repos/Xotic750/es5-shim/commits{/sha}","git_commits_url":"https://api.github.com/repos/Xotic750/es5-shim/git/commits{/sha}","comments_url":"https://api.github.com/repos/Xotic750/es5-shim/comments{/number}","issue_comment_url":"https://api.github.com/repos/Xotic750/es5-shim/issues/comments{/number}","contents_url":"https://api.github.com/repos/Xotic750/es5-shim/contents/{+path}","compare_url":"https://api.github.com/repos/Xotic750/es5-shim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Xotic750/es5-shim/merges","archive_url":"https://api.github.com/repos/Xotic750/es5-shim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Xotic750/es5-shim/downloads","issues_url":"https://api.github.com/repos/Xotic750/es5-shim/issues{/number}","pulls_url":"https://api.github.com/repos/Xotic750/es5-shim/pulls{/number}","milestones_url":"https://api.github.com/repos/Xotic750/es5-shim/milestones{/number}","notifications_url":"https://api.github.com/repos/Xotic750/es5-shim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Xotic750/es5-shim/labels{/name}","releases_url":"https://api.github.com/repos/Xotic750/es5-shim/releases{/id}","created_at":"2014-01-19T20:49:27Z","updated_at":"2015-11-15T15:18:02Z","pushed_at":"2015-12-09T21:47:51Z","git_url":"git://github.com/Xotic750/es5-shim.git","ssh_url":"git@github.com:Xotic750/es5-shim.git","clone_url":"https://github.com/Xotic750/es5-shim.git","svn_url":"https://github.com/Xotic750/es5-shim","homepage":"","size":1570,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"es-shims:master","ref":"master","sha":"568c3e39a3f876945aaef4dc765f7214aa928ee8","user":{"login":"es-shims","id":6288429,"avatar_url":"https://avatars.githubusercontent.com/u/6288429?v=3","gravatar_id":"","url":"https://api.github.com/users/es-shims","html_url":"https://github.com/es-shims","followers_url":"https://api.github.com/users/es-shims/followers","following_url":"https://api.github.com/users/es-shims/following{/other_user}","gists_url":"https://api.github.com/users/es-shims/gists{/gist_id}","starred_url":"https://api.github.com/users/es-shims/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/es-shims/subscriptions","organizations_url":"https://api.github.com/users/es-shims/orgs","repos_url":"https://api.github.com/users/es-shims/repos","events_url":"https://api.github.com/users/es-shims/events{/privacy}","received_events_url":"https://api.github.com/users/es-shims/received_events","type":"Organization","site_admin":false},"repo":{"id":914603,"name":"es5-shim","full_name":"es-shims/es5-shim","owner":{"login":"es-shims","id":6288429,"avatar_url":"https://avatars.githubusercontent.com/u/6288429?v=3","gravatar_id":"","url":"https://api.github.com/users/es-shims","html_url":"https://github.com/es-shims","followers_url":"https://api.github.com/users/es-shims/followers","following_url":"https://api.github.com/users/es-shims/following{/other_user}","gists_url":"https://api.github.com/users/es-shims/gists{/gist_id}","starred_url":"https://api.github.com/users/es-shims/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/es-shims/subscriptions","organizations_url":"https://api.github.com/users/es-shims/orgs","repos_url":"https://api.github.com/users/es-shims/repos","events_url":"https://api.github.com/users/es-shims/events{/privacy}","received_events_url":"https://api.github.com/users/es-shims/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/es-shims/es5-shim","description":"ECMAScript 5 compatibility shims for legacy JavaScript engines","fork":false,"url":"https://api.github.com/repos/es-shims/es5-shim","forks_url":"https://api.github.com/repos/es-shims/es5-shim/forks","keys_url":"https://api.github.com/repos/es-shims/es5-shim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/es-shims/es5-shim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/es-shims/es5-shim/teams","hooks_url":"https://api.github.com/repos/es-shims/es5-shim/hooks","issue_events_url":"https://api.github.com/repos/es-shims/es5-shim/issues/events{/number}","events_url":"https://api.github.com/repos/es-shims/es5-shim/events","assignees_url":"https://api.github.com/repos/es-shims/es5-shim/assignees{/user}","branches_url":"https://api.github.com/repos/es-shims/es5-shim/branches{/branch}","tags_url":"https://api.github.com/repos/es-shims/es5-shim/tags","blobs_url":"https://api.github.com/repos/es-shims/es5-shim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/es-shims/es5-shim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/es-shims/es5-shim/git/refs{/sha}","trees_url":"https://api.github.com/repos/es-shims/es5-shim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/es-shims/es5-shim/statuses/{sha}","languages_url":"https://api.github.com/repos/es-shims/es5-shim/languages","stargazers_url":"https://api.github.com/repos/es-shims/es5-shim/stargazers","contributors_url":"https://api.github.com/repos/es-shims/es5-shim/contributors","subscribers_url":"https://api.github.com/repos/es-shims/es5-shim/subscribers","subscription_url":"https://api.github.com/repos/es-shims/es5-shim/subscription","commits_url":"https://api.github.com/repos/es-shims/es5-shim/commits{/sha}","git_commits_url":"https://api.github.com/repos/es-shims/es5-shim/git/commits{/sha}","comments_url":"https://api.github.com/repos/es-shims/es5-shim/comments{/number}","issue_comment_url":"https://api.github.com/repos/es-shims/es5-shim/issues/comments{/number}","contents_url":"https://api.github.com/repos/es-shims/es5-shim/contents/{+path}","compare_url":"https://api.github.com/repos/es-shims/es5-shim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/es-shims/es5-shim/merges","archive_url":"https://api.github.com/repos/es-shims/es5-shim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/es-shims/es5-shim/downloads","issues_url":"https://api.github.com/repos/es-shims/es5-shim/issues{/number}","pulls_url":"https://api.github.com/repos/es-shims/es5-shim/pulls{/number}","milestones_url":"https://api.github.com/repos/es-shims/es5-shim/milestones{/number}","notifications_url":"https://api.github.com/repos/es-shims/es5-shim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/es-shims/es5-shim/labels{/name}","releases_url":"https://api.github.com/repos/es-shims/es5-shim/releases{/id}","created_at":"2010-09-16T05:54:16Z","updated_at":"2015-12-08T17:45:31Z","pushed_at":"2015-12-09T21:47:52Z","git_url":"git://github.com/es-shims/es5-shim.git","ssh_url":"git@github.com:es-shims/es5-shim.git","clone_url":"https://github.com/es-shims/es5-shim.git","svn_url":"https://github.com/es-shims/es5-shim","homepage":"","size":1784,"stargazers_count":4418,"watchers_count":4418,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":595,"mirror_url":null,"open_issues_count":28,"forks":595,"open_issues":28,"watchers":4418,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/es-shims/es5-shim/pulls/354"},"html":{"href":"https://github.com/es-shims/es5-shim/pull/354"},"issue":{"href":"https://api.github.com/repos/es-shims/es5-shim/issues/354"},"comments":{"href":"https://api.github.com/repos/es-shims/es5-shim/issues/354/comments"},"review_comments":{"href":"https://api.github.com/repos/es-shims/es5-shim/pulls/354/comments"},"review_comment":{"href":"https://api.github.com/repos/es-shims/es5-shim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/es-shims/es5-shim/pulls/354/commits"},"statuses":{"href":"https://api.github.com/repos/es-shims/es5-shim/statuses/53c3ffc17e0a0a928f9886f77d4a00778b324f4c"}}}}