{"action":"created","comment":{"url":"https://api.github.com/repos/guardian/membership-frontend/pulls/comments/24491389","id":24491389,"diff_hunk":"@@ -150,6 +151,60 @@ $global-nav-height: 36px;\n     }\n }\n \n+.nav--global--subnav {\n+    background-color: $c-neutral5;\n+    .nav__scroll {\n+        background-color: $c-neutral6;\n+        @include mq($until: tablet) {\n+            display: block;\n+        }\n+    }\n+}\n+\n+.nav__list--breadcrumbs,\n+.nav__list--subnav {\n+    height: $global-nav-height;\n+    float: left;\n+\n+    .nav__link {\n+        padding-top: rem($gs-baseline / 2);\n+        padding-bottom: rem($gs-baseline);\n+    }\n+}\n+\n+.nav__list--breadcrumbs {\n+    border-right: 2px solid $white;\n+\n+    .nav__link {\n+        display: inline-block;\n+        vertical-align: middle;\n+        margin-right: rem($gs-gutter / 2);\n+    }\n+\n+    .nav__item:after {\n+        content: \">\";\n+        display: inline-block;\n+        margin-right: rem($gs-gutter / 2);\n+    }\n+\n+    .nav__item:last-child {\n+        .nav__link {\n+            margin-right: rem($gs-gutter);\n+        }\n+        &:after {\n+            display: none;\n+        }\n+    }\n+}\n+\n+.nav__list--subnav {\n+    margin-left: rem($gs-gutter);\n+}\n+\n+.nav--global.nav--global--subnav.is-active {","path":"frontend/assets/stylesheets/components/nav/_nav.scss","position":71,"original_position":71,"commit_id":"5f3f42b03d3f26a5111cfc11f42c2720d9d9600b","original_commit_id":"5f3f42b03d3f26a5111cfc11f42c2720d9d9600b","user":{"login":"davidrapson","id":123386,"avatar_url":"https://avatars.githubusercontent.com/u/123386?v=3","gravatar_id":"","url":"https://api.github.com/users/davidrapson","html_url":"https://github.com/davidrapson","followers_url":"https://api.github.com/users/davidrapson/followers","following_url":"https://api.github.com/users/davidrapson/following{/other_user}","gists_url":"https://api.github.com/users/davidrapson/gists{/gist_id}","starred_url":"https://api.github.com/users/davidrapson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidrapson/subscriptions","organizations_url":"https://api.github.com/users/davidrapson/orgs","repos_url":"https://api.github.com/users/davidrapson/repos","events_url":"https://api.github.com/users/davidrapson/events{/privacy}","received_events_url":"https://api.github.com/users/davidrapson/received_events","type":"User","site_admin":false},"body":"Is this level of specificity needed?","created_at":"2015-02-11T12:29:47Z","updated_at":"2015-02-11T12:29:47Z","html_url":"https://github.com/guardian/membership-frontend/pull/178#discussion_r24491389","pull_request_url":"https://api.github.com/repos/guardian/membership-frontend/pulls/178","_links":{"self":{"href":"https://api.github.com/repos/guardian/membership-frontend/pulls/comments/24491389"},"html":{"href":"https://github.com/guardian/membership-frontend/pull/178#discussion_r24491389"},"pull_request":{"href":"https://api.github.com/repos/guardian/membership-frontend/pulls/178"}}},"pull_request":{"url":"https://api.github.com/repos/guardian/membership-frontend/pulls/178","id":29084823,"html_url":"https://github.com/guardian/membership-frontend/pull/178","diff_url":"https://github.com/guardian/membership-frontend/pull/178.diff","patch_url":"https://github.com/guardian/membership-frontend/pull/178.patch","issue_url":"https://api.github.com/repos/guardian/membership-frontend/issues/178","number":178,"state":"open","locked":false,"title":"Add subnav  [DO NOT MERGE]","user":{"login":"mattandrews","id":394376,"avatar_url":"https://avatars.githubusercontent.com/u/394376?v=3","gravatar_id":"","url":"https://api.github.com/users/mattandrews","html_url":"https://github.com/mattandrews","followers_url":"https://api.github.com/users/mattandrews/followers","following_url":"https://api.github.com/users/mattandrews/following{/other_user}","gists_url":"https://api.github.com/users/mattandrews/gists{/gist_id}","starred_url":"https://api.github.com/users/mattandrews/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattandrews/subscriptions","organizations_url":"https://api.github.com/users/mattandrews/orgs","repos_url":"https://api.github.com/users/mattandrews/repos","events_url":"https://api.github.com/users/mattandrews/events{/privacy}","received_events_url":"https://api.github.com/users/mattandrews/received_events","type":"User","site_admin":false},"body":"This isn't quite ready to go yet until we finalise some of the other work going on, but still ready for code review.\r\n\r\nAt its most simple, this gives us the ability to add subnavigation to pages, like this:\r\n\r\n![screen shot 2015-02-11 at 11 39 53](https://cloud.githubusercontent.com/assets/394376/6146251/a4e7ac7e-b1e2-11e4-9698-d9b9568eafbb.png)\r\n\r\nAt the same time it also fixes a possible regression in the existing nav:\r\n\r\n#### Before:\r\n![screen shot 2015-02-11 at 11 40 54](https://cloud.githubusercontent.com/assets/394376/6146272/eed5ead0-b1e2-11e4-8a10-6b1c496f7d08.png)\r\n\r\n#### After:\r\n![screen shot 2015-02-11 at 11 41 09](https://cloud.githubusercontent.com/assets/394376/6146267/e22ffe42-b1e2-11e4-8013-33788bac0701.png)\r\n\r\nAlso, this PR removes some of the nav options and adds them to a new, extended nav bar at the footer of the page:\r\n\r\n![screen shot 2015-02-11 at 11 41 27](https://cloud.githubusercontent.com/assets/394376/6146285/0a7caf58-b1e3-11e4-834b-9c9f458665a1.png)\r\n\r\n#### Caveats / concerns\r\n\r\nThe mobile view of this subnav isn't beautiful:\r\n![screen shot 2015-02-11 at 11 45 02](https://cloud.githubusercontent.com/assets/394376/6146328/68246ed4-b1e3-11e4-8bcf-b009870e7de5.png)\r\n\r\n... but on NGW, the subnav covers the main menu, which I don't think we'd want to do, so there's no clear path:\r\n\r\n![screen shot 2015-02-11 at 11 45 47](https://cloud.githubusercontent.com/assets/394376/6146343/87388cd8-b1e3-11e4-9c93-555b74740a8e.png)\r\n\r\nFinally, the CSS here isn't very beautiful either – the existing nav CSS is overly specific and not that modular and I didn't think it was worth a full-on refactor given that this work isn't even ready to deploy yet.\r\n\r\n--\r\n\r\nThoughts and feedback encouraged.\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n","created_at":"2015-02-11T11:47:18Z","updated_at":"2015-02-11T12:29:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6896ced6599e9f319e621150f0c145b9d504535c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/guardian/membership-frontend/pulls/178/commits","review_comments_url":"https://api.github.com/repos/guardian/membership-frontend/pulls/178/comments","review_comment_url":"https://api.github.com/repos/guardian/membership-frontend/pulls/comments/{number}","comments_url":"https://api.github.com/repos/guardian/membership-frontend/issues/178/comments","statuses_url":"https://api.github.com/repos/guardian/membership-frontend/statuses/5f3f42b03d3f26a5111cfc11f42c2720d9d9600b","head":{"label":"guardian:ma-subnav","ref":"ma-subnav","sha":"5f3f42b03d3f26a5111cfc11f42c2720d9d9600b","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":28401521,"name":"membership-frontend","full_name":"guardian/membership-frontend","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/membership-frontend","description":"Bringing the Guardian to life through live events and meet-ups","fork":false,"url":"https://api.github.com/repos/guardian/membership-frontend","forks_url":"https://api.github.com/repos/guardian/membership-frontend/forks","keys_url":"https://api.github.com/repos/guardian/membership-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/membership-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/membership-frontend/teams","hooks_url":"https://api.github.com/repos/guardian/membership-frontend/hooks","issue_events_url":"https://api.github.com/repos/guardian/membership-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/membership-frontend/events","assignees_url":"https://api.github.com/repos/guardian/membership-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/membership-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/membership-frontend/tags","blobs_url":"https://api.github.com/repos/guardian/membership-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/membership-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/membership-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/membership-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/membership-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/membership-frontend/languages","stargazers_url":"https://api.github.com/repos/guardian/membership-frontend/stargazers","contributors_url":"https://api.github.com/repos/guardian/membership-frontend/contributors","subscribers_url":"https://api.github.com/repos/guardian/membership-frontend/subscribers","subscription_url":"https://api.github.com/repos/guardian/membership-frontend/subscription","commits_url":"https://api.github.com/repos/guardian/membership-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/membership-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/membership-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/membership-frontend/issues/comments/{number}","contents_url":"https://api.github.com/repos/guardian/membership-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/membership-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/membership-frontend/merges","archive_url":"https://api.github.com/repos/guardian/membership-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/membership-frontend/downloads","issues_url":"https://api.github.com/repos/guardian/membership-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/membership-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/membership-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/membership-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/membership-frontend/labels{/name}","releases_url":"https://api.github.com/repos/guardian/membership-frontend/releases{/id}","created_at":"2014-12-23T14:14:38Z","updated_at":"2015-02-11T12:16:57Z","pushed_at":"2015-02-11T12:16:58Z","git_url":"git://github.com/guardian/membership-frontend.git","ssh_url":"git@github.com:guardian/membership-frontend.git","clone_url":"https://github.com/guardian/membership-frontend.git","svn_url":"https://github.com/guardian/membership-frontend","homepage":"https://membership.theguardian.com/","size":24579,"stargazers_count":4,"watchers_count":4,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":3,"forks":2,"open_issues":3,"watchers":4,"default_branch":"master"}},"base":{"label":"guardian:master","ref":"master","sha":"b2e91d940d76d60c79a83a24220f1140aa73ef77","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":28401521,"name":"membership-frontend","full_name":"guardian/membership-frontend","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/membership-frontend","description":"Bringing the Guardian to life through live events and meet-ups","fork":false,"url":"https://api.github.com/repos/guardian/membership-frontend","forks_url":"https://api.github.com/repos/guardian/membership-frontend/forks","keys_url":"https://api.github.com/repos/guardian/membership-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/membership-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/membership-frontend/teams","hooks_url":"https://api.github.com/repos/guardian/membership-frontend/hooks","issue_events_url":"https://api.github.com/repos/guardian/membership-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/membership-frontend/events","assignees_url":"https://api.github.com/repos/guardian/membership-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/membership-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/membership-frontend/tags","blobs_url":"https://api.github.com/repos/guardian/membership-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/membership-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/membership-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/membership-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/membership-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/membership-frontend/languages","stargazers_url":"https://api.github.com/repos/guardian/membership-frontend/stargazers","contributors_url":"https://api.github.com/repos/guardian/membership-frontend/contributors","subscribers_url":"https://api.github.com/repos/guardian/membership-frontend/subscribers","subscription_url":"https://api.github.com/repos/guardian/membership-frontend/subscription","commits_url":"https://api.github.com/repos/guardian/membership-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/membership-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/membership-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/membership-frontend/issues/comments/{number}","contents_url":"https://api.github.com/repos/guardian/membership-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/membership-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/membership-frontend/merges","archive_url":"https://api.github.com/repos/guardian/membership-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/membership-frontend/downloads","issues_url":"https://api.github.com/repos/guardian/membership-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/membership-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/membership-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/membership-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/membership-frontend/labels{/name}","releases_url":"https://api.github.com/repos/guardian/membership-frontend/releases{/id}","created_at":"2014-12-23T14:14:38Z","updated_at":"2015-02-11T12:16:57Z","pushed_at":"2015-02-11T12:16:58Z","git_url":"git://github.com/guardian/membership-frontend.git","ssh_url":"git@github.com:guardian/membership-frontend.git","clone_url":"https://github.com/guardian/membership-frontend.git","svn_url":"https://github.com/guardian/membership-frontend","homepage":"https://membership.theguardian.com/","size":24579,"stargazers_count":4,"watchers_count":4,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":3,"forks":2,"open_issues":3,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/guardian/membership-frontend/pulls/178"},"html":{"href":"https://github.com/guardian/membership-frontend/pull/178"},"issue":{"href":"https://api.github.com/repos/guardian/membership-frontend/issues/178"},"comments":{"href":"https://api.github.com/repos/guardian/membership-frontend/issues/178/comments"},"review_comments":{"href":"https://api.github.com/repos/guardian/membership-frontend/pulls/178/comments"},"review_comment":{"href":"https://api.github.com/repos/guardian/membership-frontend/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/guardian/membership-frontend/pulls/178/commits"},"statuses":{"href":"https://api.github.com/repos/guardian/membership-frontend/statuses/5f3f42b03d3f26a5111cfc11f42c2720d9d9600b"}}}}