{"action":"created","comment":{"url":"https://api.github.com/repos/kbase/transform/pulls/comments/28369170","id":28369170,"diff_hunk":"@@ -172,28 +166,28 @@ public static void main(String[] args) throws Exception {\n         final String filename = \"Pseudomonas_stutzeri_DSM_10701.gb\";\r\n         BufferedReader br = new BufferedReader(new FileReader(new File(\"test/\" + filename)));\r\n         parse(br, new GbkParsingParams(false), filename, new GbkCallback() {\r\n-            @Override\r\n-            public void setGenomeTrackFile(String contigName, String genomeName, int taxId, String plasmid, String filename) throws Exception {\r\n-                pw.println(\"setGenome: contigName=\" + contigName + \", genomeName=\" + genomeName + \", taxId=\" + taxId + \", plasmid=\" + plasmid);\r\n-            }\r\n+\t\t@Override\r","path":"src/us/kbase/genbank/GbkParser.java","position":66,"original_position":66,"commit_id":"f9289a312ff10583f64dcf1e5e77f58c5a0e44bc","original_commit_id":"f9289a312ff10583f64dcf1e5e77f58c5a0e44bc","user":{"login":"mlhenderson","id":2807085,"avatar_url":"https://avatars.githubusercontent.com/u/2807085?v=3","gravatar_id":"","url":"https://api.github.com/users/mlhenderson","html_url":"https://github.com/mlhenderson","followers_url":"https://api.github.com/users/mlhenderson/followers","following_url":"https://api.github.com/users/mlhenderson/following{/other_user}","gists_url":"https://api.github.com/users/mlhenderson/gists{/gist_id}","starred_url":"https://api.github.com/users/mlhenderson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlhenderson/subscriptions","organizations_url":"https://api.github.com/users/mlhenderson/orgs","repos_url":"https://api.github.com/users/mlhenderson/repos","events_url":"https://api.github.com/users/mlhenderson/events{/privacy}","received_events_url":"https://api.github.com/users/mlhenderson/received_events","type":"User","site_admin":false},"body":"Lines 169-190, what happened here?","created_at":"2015-04-14T20:51:07Z","updated_at":"2015-04-14T20:51:07Z","html_url":"https://github.com/kbase/transform/pull/146#discussion_r28369170","pull_request_url":"https://api.github.com/repos/kbase/transform/pulls/146","_links":{"self":{"href":"https://api.github.com/repos/kbase/transform/pulls/comments/28369170"},"html":{"href":"https://github.com/kbase/transform/pull/146#discussion_r28369170"},"pull_request":{"href":"https://api.github.com/repos/kbase/transform/pulls/146"}}},"pull_request":{"url":"https://api.github.com/repos/kbase/transform/pulls/146","id":32145579,"html_url":"https://github.com/kbase/transform/pull/146","diff_url":"https://github.com/kbase/transform/pull/146.diff","patch_url":"https://github.com/kbase/transform/pull/146.patch","issue_url":"https://api.github.com/repos/kbase/transform/issues/146","number":146,"state":"open","locked":false,"title":"check for null fields when exporting Genome to Genbank, add unit tests for Genbank to Genome","user":{"login":"jmchandonia","id":2856136,"avatar_url":"https://avatars.githubusercontent.com/u/2856136?v=3","gravatar_id":"","url":"https://api.github.com/users/jmchandonia","html_url":"https://github.com/jmchandonia","followers_url":"https://api.github.com/users/jmchandonia/followers","following_url":"https://api.github.com/users/jmchandonia/following{/other_user}","gists_url":"https://api.github.com/users/jmchandonia/gists{/gist_id}","starred_url":"https://api.github.com/users/jmchandonia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmchandonia/subscriptions","organizations_url":"https://api.github.com/users/jmchandonia/orgs","repos_url":"https://api.github.com/users/jmchandonia/repos","events_url":"https://api.github.com/users/jmchandonia/events{/privacy}","received_events_url":"https://api.github.com/users/jmchandonia/received_events","type":"User","site_admin":false},"body":"This fixes the genbank exporter to check for null return values on optional fields in a Genome typed object.  Some of those fields are null for genomes created within KBase, which prevents them from exporting (https://atlassian.kbase.us/browse/KBASE-1721).  This should fix that issue, or at least it does for my test cases.","created_at":"2015-03-27T21:14:11Z","updated_at":"2015-04-14T20:51:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"28993522f0e027060ad48d2e348dd9433498a96e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/kbase/transform/pulls/146/commits","review_comments_url":"https://api.github.com/repos/kbase/transform/pulls/146/comments","review_comment_url":"https://api.github.com/repos/kbase/transform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kbase/transform/issues/146/comments","statuses_url":"https://api.github.com/repos/kbase/transform/statuses/f9289a312ff10583f64dcf1e5e77f58c5a0e44bc","head":{"label":"jmchandonia:develop","ref":"develop","sha":"f9289a312ff10583f64dcf1e5e77f58c5a0e44bc","user":{"login":"jmchandonia","id":2856136,"avatar_url":"https://avatars.githubusercontent.com/u/2856136?v=3","gravatar_id":"","url":"https://api.github.com/users/jmchandonia","html_url":"https://github.com/jmchandonia","followers_url":"https://api.github.com/users/jmchandonia/followers","following_url":"https://api.github.com/users/jmchandonia/following{/other_user}","gists_url":"https://api.github.com/users/jmchandonia/gists{/gist_id}","starred_url":"https://api.github.com/users/jmchandonia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmchandonia/subscriptions","organizations_url":"https://api.github.com/users/jmchandonia/orgs","repos_url":"https://api.github.com/users/jmchandonia/repos","events_url":"https://api.github.com/users/jmchandonia/events{/privacy}","received_events_url":"https://api.github.com/users/jmchandonia/received_events","type":"User","site_admin":false},"repo":{"id":30436699,"name":"transform","full_name":"jmchandonia/transform","owner":{"login":"jmchandonia","id":2856136,"avatar_url":"https://avatars.githubusercontent.com/u/2856136?v=3","gravatar_id":"","url":"https://api.github.com/users/jmchandonia","html_url":"https://github.com/jmchandonia","followers_url":"https://api.github.com/users/jmchandonia/followers","following_url":"https://api.github.com/users/jmchandonia/following{/other_user}","gists_url":"https://api.github.com/users/jmchandonia/gists{/gist_id}","starred_url":"https://api.github.com/users/jmchandonia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmchandonia/subscriptions","organizations_url":"https://api.github.com/users/jmchandonia/orgs","repos_url":"https://api.github.com/users/jmchandonia/repos","events_url":"https://api.github.com/users/jmchandonia/events{/privacy}","received_events_url":"https://api.github.com/users/jmchandonia/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jmchandonia/transform","description":"A service that provides import, upload, and download capabilities as well as tools for validating and converting between data types, both internal and external to KBase.","fork":true,"url":"https://api.github.com/repos/jmchandonia/transform","forks_url":"https://api.github.com/repos/jmchandonia/transform/forks","keys_url":"https://api.github.com/repos/jmchandonia/transform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jmchandonia/transform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jmchandonia/transform/teams","hooks_url":"https://api.github.com/repos/jmchandonia/transform/hooks","issue_events_url":"https://api.github.com/repos/jmchandonia/transform/issues/events{/number}","events_url":"https://api.github.com/repos/jmchandonia/transform/events","assignees_url":"https://api.github.com/repos/jmchandonia/transform/assignees{/user}","branches_url":"https://api.github.com/repos/jmchandonia/transform/branches{/branch}","tags_url":"https://api.github.com/repos/jmchandonia/transform/tags","blobs_url":"https://api.github.com/repos/jmchandonia/transform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jmchandonia/transform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jmchandonia/transform/git/refs{/sha}","trees_url":"https://api.github.com/repos/jmchandonia/transform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jmchandonia/transform/statuses/{sha}","languages_url":"https://api.github.com/repos/jmchandonia/transform/languages","stargazers_url":"https://api.github.com/repos/jmchandonia/transform/stargazers","contributors_url":"https://api.github.com/repos/jmchandonia/transform/contributors","subscribers_url":"https://api.github.com/repos/jmchandonia/transform/subscribers","subscription_url":"https://api.github.com/repos/jmchandonia/transform/subscription","commits_url":"https://api.github.com/repos/jmchandonia/transform/commits{/sha}","git_commits_url":"https://api.github.com/repos/jmchandonia/transform/git/commits{/sha}","comments_url":"https://api.github.com/repos/jmchandonia/transform/comments{/number}","issue_comment_url":"https://api.github.com/repos/jmchandonia/transform/issues/comments{/number}","contents_url":"https://api.github.com/repos/jmchandonia/transform/contents/{+path}","compare_url":"https://api.github.com/repos/jmchandonia/transform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jmchandonia/transform/merges","archive_url":"https://api.github.com/repos/jmchandonia/transform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jmchandonia/transform/downloads","issues_url":"https://api.github.com/repos/jmchandonia/transform/issues{/number}","pulls_url":"https://api.github.com/repos/jmchandonia/transform/pulls{/number}","milestones_url":"https://api.github.com/repos/jmchandonia/transform/milestones{/number}","notifications_url":"https://api.github.com/repos/jmchandonia/transform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jmchandonia/transform/labels{/name}","releases_url":"https://api.github.com/repos/jmchandonia/transform/releases{/id}","created_at":"2015-02-06T22:51:08Z","updated_at":"2015-03-23T19:06:58Z","pushed_at":"2015-04-13T23:43:29Z","git_url":"git://github.com/jmchandonia/transform.git","ssh_url":"git@github.com:jmchandonia/transform.git","clone_url":"https://github.com/jmchandonia/transform.git","svn_url":"https://github.com/jmchandonia/transform","homepage":null,"size":28611,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kbase:develop","ref":"develop","sha":"7833bde94003de827df66ff5ab56d166d646d8ba","user":{"login":"kbase","id":1263946,"avatar_url":"https://avatars.githubusercontent.com/u/1263946?v=3","gravatar_id":"","url":"https://api.github.com/users/kbase","html_url":"https://github.com/kbase","followers_url":"https://api.github.com/users/kbase/followers","following_url":"https://api.github.com/users/kbase/following{/other_user}","gists_url":"https://api.github.com/users/kbase/gists{/gist_id}","starred_url":"https://api.github.com/users/kbase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbase/subscriptions","organizations_url":"https://api.github.com/users/kbase/orgs","repos_url":"https://api.github.com/users/kbase/repos","events_url":"https://api.github.com/users/kbase/events{/privacy}","received_events_url":"https://api.github.com/users/kbase/received_events","type":"Organization","site_admin":false},"repo":{"id":25796340,"name":"transform","full_name":"kbase/transform","owner":{"login":"kbase","id":1263946,"avatar_url":"https://avatars.githubusercontent.com/u/1263946?v=3","gravatar_id":"","url":"https://api.github.com/users/kbase","html_url":"https://github.com/kbase","followers_url":"https://api.github.com/users/kbase/followers","following_url":"https://api.github.com/users/kbase/following{/other_user}","gists_url":"https://api.github.com/users/kbase/gists{/gist_id}","starred_url":"https://api.github.com/users/kbase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbase/subscriptions","organizations_url":"https://api.github.com/users/kbase/orgs","repos_url":"https://api.github.com/users/kbase/repos","events_url":"https://api.github.com/users/kbase/events{/privacy}","received_events_url":"https://api.github.com/users/kbase/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kbase/transform","description":"A service that provides import, upload, and download capabilities as well as tools for validating and converting between data types, both internal and external to KBase.","fork":false,"url":"https://api.github.com/repos/kbase/transform","forks_url":"https://api.github.com/repos/kbase/transform/forks","keys_url":"https://api.github.com/repos/kbase/transform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kbase/transform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kbase/transform/teams","hooks_url":"https://api.github.com/repos/kbase/transform/hooks","issue_events_url":"https://api.github.com/repos/kbase/transform/issues/events{/number}","events_url":"https://api.github.com/repos/kbase/transform/events","assignees_url":"https://api.github.com/repos/kbase/transform/assignees{/user}","branches_url":"https://api.github.com/repos/kbase/transform/branches{/branch}","tags_url":"https://api.github.com/repos/kbase/transform/tags","blobs_url":"https://api.github.com/repos/kbase/transform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kbase/transform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kbase/transform/git/refs{/sha}","trees_url":"https://api.github.com/repos/kbase/transform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kbase/transform/statuses/{sha}","languages_url":"https://api.github.com/repos/kbase/transform/languages","stargazers_url":"https://api.github.com/repos/kbase/transform/stargazers","contributors_url":"https://api.github.com/repos/kbase/transform/contributors","subscribers_url":"https://api.github.com/repos/kbase/transform/subscribers","subscription_url":"https://api.github.com/repos/kbase/transform/subscription","commits_url":"https://api.github.com/repos/kbase/transform/commits{/sha}","git_commits_url":"https://api.github.com/repos/kbase/transform/git/commits{/sha}","comments_url":"https://api.github.com/repos/kbase/transform/comments{/number}","issue_comment_url":"https://api.github.com/repos/kbase/transform/issues/comments{/number}","contents_url":"https://api.github.com/repos/kbase/transform/contents/{+path}","compare_url":"https://api.github.com/repos/kbase/transform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kbase/transform/merges","archive_url":"https://api.github.com/repos/kbase/transform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kbase/transform/downloads","issues_url":"https://api.github.com/repos/kbase/transform/issues{/number}","pulls_url":"https://api.github.com/repos/kbase/transform/pulls{/number}","milestones_url":"https://api.github.com/repos/kbase/transform/milestones{/number}","notifications_url":"https://api.github.com/repos/kbase/transform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kbase/transform/labels{/name}","releases_url":"https://api.github.com/repos/kbase/transform/releases{/id}","created_at":"2014-10-27T00:08:53Z","updated_at":"2015-02-10T19:03:17Z","pushed_at":"2015-04-13T23:43:30Z","git_url":"git://github.com/kbase/transform.git","ssh_url":"git@github.com:kbase/transform.git","clone_url":"https://github.com/kbase/transform.git","svn_url":"https://github.com/kbase/transform","homepage":null,"size":31273,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":3,"forks":16,"open_issues":3,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kbase/transform/pulls/146"},"html":{"href":"https://github.com/kbase/transform/pull/146"},"issue":{"href":"https://api.github.com/repos/kbase/transform/issues/146"},"comments":{"href":"https://api.github.com/repos/kbase/transform/issues/146/comments"},"review_comments":{"href":"https://api.github.com/repos/kbase/transform/pulls/146/comments"},"review_comment":{"href":"https://api.github.com/repos/kbase/transform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kbase/transform/pulls/146/commits"},"statuses":{"href":"https://api.github.com/repos/kbase/transform/statuses/f9289a312ff10583f64dcf1e5e77f58c5a0e44bc"}}}}