{"comment":{"url":"https://api.github.com/repos/jirikuncar/invenio/comments/11655278","html_url":"https://github.com/jirikuncar/invenio/commit/04899d6a1bda31ef628566c2385b31e27d03645c#commitcomment-11655278","id":11655278,"user":{"login":"jirikuncar","id":189798,"avatar_url":"https://avatars.githubusercontent.com/u/189798?v=3","gravatar_id":"","url":"https://api.github.com/users/jirikuncar","html_url":"https://github.com/jirikuncar","followers_url":"https://api.github.com/users/jirikuncar/followers","following_url":"https://api.github.com/users/jirikuncar/following{/other_user}","gists_url":"https://api.github.com/users/jirikuncar/gists{/gist_id}","starred_url":"https://api.github.com/users/jirikuncar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jirikuncar/subscriptions","organizations_url":"https://api.github.com/users/jirikuncar/orgs","repos_url":"https://api.github.com/users/jirikuncar/repos","events_url":"https://api.github.com/users/jirikuncar/events{/privacy}","received_events_url":"https://api.github.com/users/jirikuncar/received_events","type":"User","site_admin":false},"position":0,"line":null,"path":"invenio/legacy/bibedit/engine.py","commit_id":"04899d6a1bda31ef628566c2385b31e27d03645c","created_at":"2015-06-12T14:36:37Z","updated_at":"2015-06-12T14:36:37Z","body":"23:1: E402 module level import not at top of file\n25:1: I100 Imports statements are in the wrong order. import re should be before from datetime\n25:1: E402 module level import not at top of file\n26:1: E402 module level import not at top of file\n27:1: I100 Imports statements are in the wrong order. import copy should be before import zlib\n27:1: E402 module level import not at top of file\n28:1: E402 module level import not at top of file\n29:1: E402 module level import not at top of file\n30:1: I100 Imports statements are in the wrong order. import cookielib should be before import urllib2\n30:1: E402 module level import not at top of file\n31:1: E402 module level import not at top of file\n32:1: E402 module level import not at top of file\n34:1: E402 module level import not at top of file\n35:1: I201 Missing newline before sections or imports.\n35:1: E402 module level import not at top of file\n37:1: I100 Imports statements are in the wrong order. from invenio.ext.logging should be before from invenio.modules\n37:1: E402 module level import not at top of file\n38:1: E402 module level import not at top of file\n39:1: F401 'auto_version_url' imported but unused\n39:1: E402 module level import not at top of file\n40:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibrecord.xmlmarc2textmarc should be before from invenio.utils.url\n40:1: E402 module level import not at top of file\n42:1: I101 Imported names are in the wrong order. Should be CFG_BIBCATALOG_SYSTEM, CFG_BIBCATALOG_SYSTEM_RT_URL, CFG_BIBEDIT_AJAX_RESULT_CODES_REV, CFG_BIBEDIT_AUTOCOMPLETE, CFG_BIBEDIT_SHOW_HOLDING_PEN_REMOVED_FIELDS, CFG_SITE_LANG\n42:1: I100 Imports statements are in the wrong order. from invenio.config should be before from invenio.legacy.bibrecord.xmlmarc2textmarc\n42:1: E402 module level import not at top of file\n48:1: I101 Imported names are in the wrong order. Should be deactivate_cache, delete_hp_change, delete_related_holdingpen_changes, get_hp_update_xml, get_info_of_record_revision, get_marcxml_of_record_revision, get_name_tags_all, get_record_last_modification_date, get_record_revision_author, get_record_revisions, get_related_hp_changesets, reserve_record_id\n48:1: E402 module level import not at top of file\n55:1: I101 Imported names are in the wrong order. Should be InvalidCache, add_record_cnum, cache_exists, cache_expired, can_record_have_physical_copies, create_cache, crossref_process_template, delete_cache, extend_record_with_template, get_affiliation_for_paper, get_bibrecord, get_cache_contents, get_cache_mtime, get_field_templates, get_marcxml_of_revision, get_new_ticket_RT_info, get_record_revision_authors, get_record_revision_timestamps, get_record_template, get_record_templates, get_xml_from_textmarc, latest_record_revision, merge_record_with_template, modify_record_timestamp, record_is_conference, record_locked_by_other_user, record_locked_by_queue, record_locked_by_user_details, record_revision_exists, record_xml_output, replace_references, revision_to_timestamp, save_xml_record, timestamp_to_revision, touch_cache, update_cache_contents\n55:1: E402 module level import not at top of file\n70:1: I101 Imported names are in the wrong order. Should be create_field, create_record, field_add_subfield, field_get_subfield_values, print_rec, record_add_field, record_add_fields, record_add_subfield_into, record_delete_field, record_delete_subfield_from, record_extract_dois, record_get_field_instances, record_get_field_values, record_get_subfields, record_modify_controlfield, record_modify_subfield, record_move_fields, record_move_subfield, record_order_subfields, record_replace_field, record_strip_controlfields, record_strip_empty_fields, record_strip_empty_volatile_subfields\n70:1: E402 module level import not at top of file\n81:1: I101 Imported names are in the wrong order. Should be CFG_BIBEDIT_INTERNAL_DOI_PROTECTION_LEVEL, CFG_BIBEDIT_KB_SUBJECTS, CFG_BIBEDIT_PROTECTED_FIELDS, CFG_BIBUPLOAD_INTERNAL_DOI_PATTERN, CFG_CERN_SITE, CFG_INSPIRE_SITE, CFG_SITE_RECORD, CFG_SITE_URL\n81:1: I100 Imports statements are in the wrong order. from invenio.config should be before from invenio.legacy.bibrecord\n81:1: F401 'CFG_BIBEDIT_PROTECTED_FIELDS' imported but unused\n81:1: E402 module level import not at top of file\n85:1: I101 Imported names are in the wrong order. Should be guess_primary_collection_of_a_record, perform_request_search, record_exists\n85:1: E402 module level import not at top of file\n87:1: E402 module level import not at top of file\n88:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibcatalog.api should be before from invenio.legacy.webuser\n88:1: E402 module level import not at top of file\n89:1: E402 module level import not at top of file\n90:1: E402 module level import not at top of file\n91:1: E402 module level import not at top of file\n92:1: I101 Imported names are in the wrong order. Should be show_diff, wash_for_xml\n92:1: E402 module level import not at top of file\n93:1: I100 Imports statements are in the wrong order. from invenio.modules.knowledge.api should be before from invenio.utils.text\n93:1: E402 module level import not at top of file\n94:6: E126 continuation line over-indented for hanging indent\n96:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibcirculation.db_layer should be before from invenio.modules.knowledge.api\n96:1: E402 module level import not at top of file\n97:1: E402 module level import not at top of file\n99:1: E402 module level import not at top of file\n100:36: E126 continuation line over-indented for hanging indent\n103:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibrecord should be before from invenio.legacy.refextract.api\n103:1: E402 module level import not at top of file\n104:1: I101 Imported names are in the wrong order. Should be CrossrefError, get_marcxml_for_doi\n104:1: E402 module level import not at top of file\n106:1: I100 Imports statements are in the wrong order. from invenio.base.globals should be before from invenio.utils.crossref\n106:1: E402 module level import not at top of file\n117: D103 Missing docstring in public function\n122: D400 First line should end with a period (not ':')\n122: D205 1 blank line required between summary line and description (found 0)\n129:17: E126 continuation line over-indented for hanging indent\n132:22: E203 whitespace before ':'\n133:23: E203 whitespace before ':'\n134:23: E203 whitespace before ':'\n135:28: E203 whitespace before ':'\n136:33: E203 whitespace before ':'\n137:13: E126 continuation line over-indented for hanging indent\n138:23: E203 whitespace before ':'\n139:30: E203 whitespace before ':'\n141:33: E203 whitespace before ':'\n142:22: E203 whitespace before ':'\n143:24: E203 whitespace before ':'\n144:13: E126 continuation line over-indented for hanging indent\n146:1: E302 expected 2 blank lines, found 1\n146: D400 First line should end with a period (not 's')\n146: D205 1 blank line required between summary line and description (found 0)\n160:9: E115 expected an indented block (comment)\n162:21: E126 continuation line over-indented for hanging indent\n162:27: E203 whitespace before ':'\n163:34: E203 whitespace before ':'\n164:37: E203 whitespace before ':'\n165:26: E203 whitespace before ':'\n166:28: E203 whitespace before ':'\n167:17: E121 continuation line under-indented for hanging indent\n170:21: E126 continuation line over-indented for hanging indent\n172:26: E203 whitespace before ':'\n173:27: E203 whitespace before ':'\n174:27: E203 whitespace before ':'\n175:32: E203 whitespace before ':'\n176:37: E203 whitespace before ':'\n180:1: E302 expected 2 blank lines, found 1\n182:11: E221 multiple spaces before operator\n199:26: E251 unexpected spaces around keyword / parameter equals\n199:34: E251 unexpected spaces around keyword / parameter equals\n199:26: E221 multiple spaces before operator\n200:25: E251 unexpected spaces around keyword / parameter equals\n200:34: E251 unexpected spaces around keyword / parameter equals\n200:25: E221 multiple spaces before operator\n201:27: E251 unexpected spaces around keyword / parameter equals\n201:34: E251 unexpected spaces around keyword / parameter equals\n201:27: E221 multiple spaces before operator\n202:29: E251 unexpected spaces around keyword / parameter equals\n202:34: E251 unexpected spaces around keyword / parameter equals\n202:29: E221 multiple spaces before operator\n203:24: E251 unexpected spaces around keyword / parameter equals\n203:34: E251 unexpected spaces around keyword / parameter equals\n203:24: E221 multiple spaces before operator\n204:29: E251 unexpected spaces around keyword / parameter equals\n204:34: E251 unexpected spaces around keyword / parameter equals\n204:29: E221 multiple spaces before operator\n205:29: E251 unexpected spaces around keyword / parameter equals\n205:34: E251 unexpected spaces around keyword / parameter equals\n205:29: E221 multiple spaces before operator\n206:32: E251 unexpected spaces around keyword / parameter equals\n206:34: E251 unexpected spaces around keyword / parameter equals\n207:24: E251 unexpected spaces around keyword / parameter equals\n207:34: E251 unexpected spaces around keyword / parameter equals\n207:24: E221 multiple spaces before operator\n210:5: E303 too many blank lines (2)\n244:32: E203 whitespace before ':'\n245:33: E203 whitespace before ':'\n246:27: E203 whitespace before ':'\n246:66: E221 multiple spaces before operator\n247:35: E203 whitespace before ':'\n258: D210 No whitespaces allowed surrounding docstring text\n308:13: F821 undefined name 'bibedit_templates'\n309:13: F821 undefined name 'bibedit_templates'\n320: D400 First line should end with a period (not 'h')\n320: D205 1 blank line required between summary line and description (found 0)\n330: D400 First line should end with a period (not 'D')\n330: D205 1 blank line required between summary line and description (found 0)\n350: D202 No blank lines allowed after function docstring (found 1)\n350: D400 First line should end with a period (not 's')\n384:17: F821 undefined name 'bibedit_templates'\n385:49: E128 continuation line under-indented for visual indent\n388:1: E302 expected 2 blank lines, found 1\n388: D400 First line should end with a period (not 'r')\n388: D205 1 blank line required between summary line and description (found 0)\n409: D103 Missing docstring in public function\n412:5: B901 blind except: statement\n434:9: E128 continuation line under-indented for visual indent\n435:9: E128 continuation line under-indented for visual indent\n435:9: E129 visually indented line with same indent as next logical line\n460:84: E231 missing whitespace after ','\n502:1: E302 expected 2 blank lines, found 1\n502: D210 No whitespaces allowed surrounding docstring text\n502: D400 First line should end with a period (not 's')\n552: D400 First line should end with a period (not 'f')\n552: D205 1 blank line required between summary line and description (found 0)\n585:13: E303 too many blank lines (2)\n597: D400 First line should end with a period (not 'r')\n597: D205 1 blank line required between summary line and description (found 0)\n777:75: E502 the backslash is redundant between brackets\n884:25: E127 continuation line over-indented for visual indent\n900:53: E261 at least two spaces before inline comment\n901:52: E114 indentation is not a multiple of four (comment)\n901:52: E116 unexpected indentation (comment)\n909:61: E126 continuation line over-indented for hanging indent\n916:25: E126 continuation line over-indented for hanging indent\n971:17: E128 continuation line under-indented for visual indent\n1022: D210 No whitespaces allowed surrounding docstring text\n1022: D401 First line should be in imperative mood ('Perform', not 'Performs')\n1022: D400 First line should end with a period (not 'h')\n1022: D205 1 blank line required between summary line and description (found 0)\n1041: D202 No blank lines allowed after function docstring (found 1)\n1041: D400 First line should end with a period (not 'g')\n1041: D205 1 blank line required between summary line and description (found 0)\n1089:13: B901 blind except: statement\n1097:13: B901 blind except: statement\n1146:21: E128 continuation line under-indented for visual indent\n1179:67: E114 indentation is not a multiple of four (comment)\n1181:44: E126 continuation line over-indented for hanging indent\n1192:44: E261 at least two spaces before inline comment\n1194:42: E261 at least two spaces before inline comment\n1195:43: E114 indentation is not a multiple of four (comment)\n1195:43: E116 unexpected indentation (comment)\n1199:17: E128 continuation line under-indented for visual indent\n1205:21: E128 continuation line under-indented for visual indent\n1210:19: E128 continuation line under-indented for visual indent\n1215:13: E128 continuation line under-indented for visual indent\n1215:46: E251 unexpected spaces around keyword / parameter equals\n1216:13: E122 continuation line missing indentation or outdented\n1219:13: E128 continuation line under-indented for visual indent\n1225:13: E128 continuation line under-indented for visual indent\n1228:42: E203 whitespace before ','\n1236:17: E128 continuation line under-indented for visual indent\n1243:18: E261 at least two spaces before inline comment\n1246:17: E128 continuation line under-indented for visual indent\n1261:29: E128 continuation line under-indented for visual indent\n1269:33: E128 continuation line under-indented for visual indent\n1295: D400 First line should end with a period (not 'e')\n1295: D205 1 blank line required between summary line and description (found 0)\n1309:9: E116 unexpected indentation (comment)\n1382: D200 One-line docstring should fit on one line with quotes (found 3)\n1396:21: E128 continuation line under-indented for visual indent\n1411:25: E122 continuation line missing indentation or outdented\n1412:25: E122 continuation line missing indentation or outdented\n1413:25: E122 continuation line missing indentation or outdented\n1486:38: E128 continuation line under-indented for visual indent\n1506: D401 First line should be in imperative mood ('Add', not 'Adds')\n1506: D400 First line should end with a period (not ')')\n1506: D205 1 blank line required between summary line and description (found 0)\n1522:36: E127 continuation line over-indented for visual indent\n1523:36: E127 continuation line over-indented for visual indent\n1528: D400 First line should end with a period (not 's')\n1545:9: E128 continuation line under-indented for visual indent\n1546:13: E128 continuation line under-indented for visual indent\n1547:9: E128 continuation line under-indented for visual indent\n1552: D400 First line should end with a period (not 'l')\n1552: D205 1 blank line required between summary line and description (found 0)\n1570:5: B901 blind except: statement\n1593: D210 No whitespaces allowed surrounding docstring text\n1593: D202 No blank lines allowed after function docstring (found 1)\n1593: D400 First line should end with a period (not 'd')\n1635:5: B901 blind except: statement\n1655: D210 No whitespaces allowed surrounding docstring text\n1655: D400 First line should end with a period (not 'g')\n1655: D200 One-line docstring should fit on one line with quotes (found 3)\n1687: D210 No whitespaces allowed surrounding docstring text\n1687: D400 First line should end with a period (not 'F')\n1687: D200 One-line docstring should fit on one line with quotes (found 2)\n1699: D210 No whitespaces allowed surrounding docstring text\n1699: D400 First line should end with a period (not 't')\n1699: D200 One-line docstring should fit on one line with quotes (found 2)\n1711:13: E126 continuation line over-indented for hanging indent\n1716: D210 No whitespaces allowed surrounding docstring text\n1716: D400 First line should end with a period (not 'o')\n1716: D205 1 blank line required between summary line and description (found 0)\n1731:13: E128 continuation line under-indented for visual indent\n1732:29: E127 continuation line over-indented for visual indent\n1738: D401 First line should be in imperative mood ('Return', not 'Returns')\n1738: D400 First line should end with a period (not 't')\n1755:26: E128 continuation line under-indented for visual indent\n1756:26: E124 closing bracket does not match visual indentation\n1771:38: E128 continuation line under-indented for visual indent\n1783:5: E303 too many blank lines (2)\n1785:1: E266 too many leading '#' for block comment\n1787:1: E302 expected 2 blank lines, found 1\n1787: D400 First line should end with a period (not 's')\n1839: D210 No whitespaces allowed surrounding docstring text\n1839: D400 First line should end with a period (not 'e')\n1852: D209 Multi-line docstring closing quotes should be on a separate line\n1852: D400 First line should end with a period (not 'e')\n1852: D205 1 blank line required between summary line and description (found 0)\n1865:5: B901 blind except: statement\n1872: D210 No whitespaces allowed surrounding docstring text\n1872: D400 First line should end with a period (not 'e')\n1877: D103 Missing docstring in public function\n1914: D103 Missing docstring in public function\n1927:45: E131 continuation line unaligned for hanging indent"}}