{"action":"created","issue":{"url":"https://api.github.com/repos/docker/docker/issues/10596","labels_url":"https://api.github.com/repos/docker/docker/issues/10596/labels{/name}","comments_url":"https://api.github.com/repos/docker/docker/issues/10596/comments","events_url":"https://api.github.com/repos/docker/docker/issues/10596/events","html_url":"https://github.com/docker/docker/pull/10596","id":56705294,"number":10596,"title":"manifest: Close archive once done to umount the device backing the layer","user":{"login":"rhvgoyal","id":9487534,"avatar_url":"https://avatars.githubusercontent.com/u/9487534?v=3","gravatar_id":"","url":"https://api.github.com/users/rhvgoyal","html_url":"https://github.com/rhvgoyal","followers_url":"https://api.github.com/users/rhvgoyal/followers","following_url":"https://api.github.com/users/rhvgoyal/following{/other_user}","gists_url":"https://api.github.com/users/rhvgoyal/gists{/gist_id}","starred_url":"https://api.github.com/users/rhvgoyal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhvgoyal/subscriptions","organizations_url":"https://api.github.com/users/rhvgoyal/orgs","repos_url":"https://api.github.com/users/rhvgoyal/repos","events_url":"https://api.github.com/users/rhvgoyal/events{/privacy}","received_events_url":"https://api.github.com/users/rhvgoyal/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-02-05T17:56:37Z","updated_at":"2015-02-06T18:40:47Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/10596","html_url":"https://github.com/docker/docker/pull/10596","diff_url":"https://github.com/docker/docker/pull/10596.diff","patch_url":"https://github.com/docker/docker/pull/10596.patch"},"body":"This fixes issue #10593 \r\n\r\nCurrently newManifest() code can call TarLayer() which returns the archive.\r\nThis archive can have some devices mounted (which are backing the layer)\r\nso one needs to call Close() on archive to release those resources once\r\ncaller is done with archive.\r\n\r\nLooks like newManifest() is not calling Close() on archive and that leads\r\nto some devices not being unmounted when using devicemapper graph drvier.\r\nThat also means that if one deletes the image/device later, that deletion\r\nfails as device is still in use (due to previous mount).\r\n\r\nSo call archive.Close() once archive is not needed anymore to release the\r\nresources backing the archive.\r\n\r\nSigned-off-by: Vivek Goyal <vgoyal@redhat.com>"},"comment":{"url":"https://api.github.com/repos/docker/docker/issues/comments/73289537","html_url":"https://github.com/docker/docker/pull/10596#issuecomment-73289537","issue_url":"https://api.github.com/repos/docker/docker/issues/10596","id":73289537,"user":{"login":"unclejack","id":1409668,"avatar_url":"https://avatars.githubusercontent.com/u/1409668?v=3","gravatar_id":"","url":"https://api.github.com/users/unclejack","html_url":"https://github.com/unclejack","followers_url":"https://api.github.com/users/unclejack/followers","following_url":"https://api.github.com/users/unclejack/following{/other_user}","gists_url":"https://api.github.com/users/unclejack/gists{/gist_id}","starred_url":"https://api.github.com/users/unclejack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unclejack/subscriptions","organizations_url":"https://api.github.com/users/unclejack/orgs","repos_url":"https://api.github.com/users/unclejack/repos","events_url":"https://api.github.com/users/unclejack/events{/privacy}","received_events_url":"https://api.github.com/users/unclejack/received_events","type":"User","site_admin":false},"created_at":"2015-02-06T18:40:47Z","updated_at":"2015-02-06T18:40:47Z","body":"@rhvgoyal Perhaps @dmcgowan and @jlhawn might have some ideas?"}}