{"action":"created","comment":{"url":"https://api.github.com/repos/nemomobile-packages/messagingframework/pulls/comments/25121080","id":25121080,"diff_hunk":"@@ -94,20 +94,22 @@ QMap<QString, QList<QByteArray> > SSOPasswordPlugin::getIMAPAuthentication(const\n     QMap<QString, QList<QByteArray> > result;\n \n     // Add PLAIN auth\n-    QByteArray user(username.toLatin1());\n-    QByteArray pass(password.toLatin1());\n+    QByteArray user(username.toUtf8());","path":"qmf/src/plugins/ssoauth/password/passwordplugin.cpp","position":6,"original_position":6,"commit_id":"815bf24bb935fc77b6bffafd24fced31e7d2c945","original_commit_id":"815bf24bb935fc77b6bffafd24fced31e7d2c945","user":{"login":"VDVsx","id":157582,"avatar_url":"https://avatars.githubusercontent.com/u/157582?v=3","gravatar_id":"","url":"https://api.github.com/users/VDVsx","html_url":"https://github.com/VDVsx","followers_url":"https://api.github.com/users/VDVsx/followers","following_url":"https://api.github.com/users/VDVsx/following{/other_user}","gists_url":"https://api.github.com/users/VDVsx/gists{/gist_id}","starred_url":"https://api.github.com/users/VDVsx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VDVsx/subscriptions","organizations_url":"https://api.github.com/users/VDVsx/orgs","repos_url":"https://api.github.com/users/VDVsx/repos","events_url":"https://api.github.com/users/VDVsx/events{/privacy}","received_events_url":"https://api.github.com/users/VDVsx/received_events","type":"User","site_admin":false},"body":"They are base64 encoded once send over the channel","created_at":"2015-02-21T09:38:59Z","updated_at":"2015-02-21T09:38:59Z","html_url":"https://github.com/nemomobile-packages/messagingframework/pull/72#discussion_r25121080","pull_request_url":"https://api.github.com/repos/nemomobile-packages/messagingframework/pulls/72","_links":{"self":{"href":"https://api.github.com/repos/nemomobile-packages/messagingframework/pulls/comments/25121080"},"html":{"href":"https://github.com/nemomobile-packages/messagingframework/pull/72#discussion_r25121080"},"pull_request":{"href":"https://api.github.com/repos/nemomobile-packages/messagingframework/pulls/72"}}},"pull_request":{"url":"https://api.github.com/repos/nemomobile-packages/messagingframework/pulls/72","id":29694440,"html_url":"https://github.com/nemomobile-packages/messagingframework/pull/72","diff_url":"https://github.com/nemomobile-packages/messagingframework/pull/72.diff","patch_url":"https://github.com/nemomobile-packages/messagingframework/pull/72.patch","issue_url":"https://api.github.com/repos/nemomobile-packages/messagingframework/issues/72","number":72,"state":"open","locked":false,"title":"[IMAP] Do AUTHENTICATE PLAIN in two stages","user":{"login":"VDVsx","id":157582,"avatar_url":"https://avatars.githubusercontent.com/u/157582?v=3","gravatar_id":"","url":"https://api.github.com/users/VDVsx","html_url":"https://github.com/VDVsx","followers_url":"https://api.github.com/users/VDVsx/followers","following_url":"https://api.github.com/users/VDVsx/following{/other_user}","gists_url":"https://api.github.com/users/VDVsx/gists{/gist_id}","starred_url":"https://api.github.com/users/VDVsx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VDVsx/subscriptions","organizations_url":"https://api.github.com/users/VDVsx/orgs","repos_url":"https://api.github.com/users/VDVsx/repos","events_url":"https://api.github.com/users/VDVsx/events{/privacy}","received_events_url":"https://api.github.com/users/VDVsx/received_events","type":"User","site_admin":false},"body":"Some servers(e.g yandex.ru) do not support AUTHENTICATE PLAIN in a\r\nsingle command, according to RFC4616 this way is optional, so we allways\r\nperform the authentication in two stages that is gurantee to be supported\r\nby all implementations of the protocol.","created_at":"2015-02-20T13:10:09Z","updated_at":"2015-02-21T09:38:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b25b82b8df73e89196f8e2f342c784b7072b3d54","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nemomobile-packages/messagingframework/pulls/72/commits","review_comments_url":"https://api.github.com/repos/nemomobile-packages/messagingframework/pulls/72/comments","review_comment_url":"https://api.github.com/repos/nemomobile-packages/messagingframework/pulls/comments/{number}","comments_url":"https://api.github.com/repos/nemomobile-packages/messagingframework/issues/72/comments","statuses_url":"https://api.github.com/repos/nemomobile-packages/messagingframework/statuses/815bf24bb935fc77b6bffafd24fced31e7d2c945","head":{"label":"nemomobile-packages:update11","ref":"update11","sha":"815bf24bb935fc77b6bffafd24fced31e7d2c945","user":{"login":"nemomobile-packages","id":4255887,"avatar_url":"https://avatars.githubusercontent.com/u/4255887?v=3","gravatar_id":"","url":"https://api.github.com/users/nemomobile-packages","html_url":"https://github.com/nemomobile-packages","followers_url":"https://api.github.com/users/nemomobile-packages/followers","following_url":"https://api.github.com/users/nemomobile-packages/following{/other_user}","gists_url":"https://api.github.com/users/nemomobile-packages/gists{/gist_id}","starred_url":"https://api.github.com/users/nemomobile-packages/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nemomobile-packages/subscriptions","organizations_url":"https://api.github.com/users/nemomobile-packages/orgs","repos_url":"https://api.github.com/users/nemomobile-packages/repos","events_url":"https://api.github.com/users/nemomobile-packages/events{/privacy}","received_events_url":"https://api.github.com/users/nemomobile-packages/received_events","type":"Organization","site_admin":false},"repo":{"id":10455124,"name":"messagingframework","full_name":"nemomobile-packages/messagingframework","owner":{"login":"nemomobile-packages","id":4255887,"avatar_url":"https://avatars.githubusercontent.com/u/4255887?v=3","gravatar_id":"","url":"https://api.github.com/users/nemomobile-packages","html_url":"https://github.com/nemomobile-packages","followers_url":"https://api.github.com/users/nemomobile-packages/followers","following_url":"https://api.github.com/users/nemomobile-packages/following{/other_user}","gists_url":"https://api.github.com/users/nemomobile-packages/gists{/gist_id}","starred_url":"https://api.github.com/users/nemomobile-packages/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nemomobile-packages/subscriptions","organizations_url":"https://api.github.com/users/nemomobile-packages/orgs","repos_url":"https://api.github.com/users/nemomobile-packages/repos","events_url":"https://api.github.com/users/nemomobile-packages/events{/privacy}","received_events_url":"https://api.github.com/users/nemomobile-packages/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nemomobile-packages/messagingframework","description":null,"fork":false,"url":"https://api.github.com/repos/nemomobile-packages/messagingframework","forks_url":"https://api.github.com/repos/nemomobile-packages/messagingframework/forks","keys_url":"https://api.github.com/repos/nemomobile-packages/messagingframework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nemomobile-packages/messagingframework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nemomobile-packages/messagingframework/teams","hooks_url":"https://api.github.com/repos/nemomobile-packages/messagingframework/hooks","issue_events_url":"https://api.github.com/repos/nemomobile-packages/messagingframework/issues/events{/number}","events_url":"https://api.github.com/repos/nemomobile-packages/messagingframework/events","assignees_url":"https://api.github.com/repos/nemomobile-packages/messagingframework/assignees{/user}","branches_url":"https://api.github.com/repos/nemomobile-packages/messagingframework/branches{/branch}","tags_url":"https://api.github.com/repos/nemomobile-packages/messagingframework/tags","blobs_url":"https://api.github.com/repos/nemomobile-packages/messagingframework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nemomobile-packages/messagingframework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nemomobile-packages/messagingframework/git/refs{/sha}","trees_url":"https://api.github.com/repos/nemomobile-packages/messagingframework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nemomobile-packages/messagingframework/statuses/{sha}","languages_url":"https://api.github.com/repos/nemomobile-packages/messagingframework/languages","stargazers_url":"https://api.github.com/repos/nemomobile-packages/messagingframework/stargazers","contributors_url":"https://api.github.com/repos/nemomobile-packages/messagingframework/contributors","subscribers_url":"https://api.github.com/repos/nemomobile-packages/messagingframework/subscribers","subscription_url":"https://api.github.com/repos/nemomobile-packages/messagingframework/subscription","commits_url":"https://api.github.com/repos/nemomobile-packages/messagingframework/commits{/sha}","git_commits_url":"https://api.github.com/repos/nemomobile-packages/messagingframework/git/commits{/sha}","comments_url":"https://api.github.com/repos/nemomobile-packages/messagingframework/comments{/number}","issue_comment_url":"https://api.github.com/repos/nemomobile-packages/messagingframework/issues/comments/{number}","contents_url":"https://api.github.com/repos/nemomobile-packages/messagingframework/contents/{+path}","compare_url":"https://api.github.com/repos/nemomobile-packages/messagingframework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nemomobile-packages/messagingframework/merges","archive_url":"https://api.github.com/repos/nemomobile-packages/messagingframework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nemomobile-packages/messagingframework/downloads","issues_url":"https://api.github.com/repos/nemomobile-packages/messagingframework/issues{/number}","pulls_url":"https://api.github.com/repos/nemomobile-packages/messagingframework/pulls{/number}","milestones_url":"https://api.github.com/repos/nemomobile-packages/messagingframework/milestones{/number}","notifications_url":"https://api.github.com/repos/nemomobile-packages/messagingframework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nemomobile-packages/messagingframework/labels{/name}","releases_url":"https://api.github.com/repos/nemomobile-packages/messagingframework/releases{/id}","created_at":"2013-06-03T13:33:19Z","updated_at":"2015-02-17T08:04:45Z","pushed_at":"2015-02-20T17:03:34Z","git_url":"git://github.com/nemomobile-packages/messagingframework.git","ssh_url":"git@github.com:nemomobile-packages/messagingframework.git","clone_url":"https://github.com/nemomobile-packages/messagingframework.git","svn_url":"https://github.com/nemomobile-packages/messagingframework","homepage":null,"size":3792,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":1,"forks":13,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"nemomobile-packages:master","ref":"master","sha":"f7a9d6fa09d03ac9b491029004ad0a769a5529d5","user":{"login":"nemomobile-packages","id":4255887,"avatar_url":"https://avatars.githubusercontent.com/u/4255887?v=3","gravatar_id":"","url":"https://api.github.com/users/nemomobile-packages","html_url":"https://github.com/nemomobile-packages","followers_url":"https://api.github.com/users/nemomobile-packages/followers","following_url":"https://api.github.com/users/nemomobile-packages/following{/other_user}","gists_url":"https://api.github.com/users/nemomobile-packages/gists{/gist_id}","starred_url":"https://api.github.com/users/nemomobile-packages/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nemomobile-packages/subscriptions","organizations_url":"https://api.github.com/users/nemomobile-packages/orgs","repos_url":"https://api.github.com/users/nemomobile-packages/repos","events_url":"https://api.github.com/users/nemomobile-packages/events{/privacy}","received_events_url":"https://api.github.com/users/nemomobile-packages/received_events","type":"Organization","site_admin":false},"repo":{"id":10455124,"name":"messagingframework","full_name":"nemomobile-packages/messagingframework","owner":{"login":"nemomobile-packages","id":4255887,"avatar_url":"https://avatars.githubusercontent.com/u/4255887?v=3","gravatar_id":"","url":"https://api.github.com/users/nemomobile-packages","html_url":"https://github.com/nemomobile-packages","followers_url":"https://api.github.com/users/nemomobile-packages/followers","following_url":"https://api.github.com/users/nemomobile-packages/following{/other_user}","gists_url":"https://api.github.com/users/nemomobile-packages/gists{/gist_id}","starred_url":"https://api.github.com/users/nemomobile-packages/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nemomobile-packages/subscriptions","organizations_url":"https://api.github.com/users/nemomobile-packages/orgs","repos_url":"https://api.github.com/users/nemomobile-packages/repos","events_url":"https://api.github.com/users/nemomobile-packages/events{/privacy}","received_events_url":"https://api.github.com/users/nemomobile-packages/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nemomobile-packages/messagingframework","description":null,"fork":false,"url":"https://api.github.com/repos/nemomobile-packages/messagingframework","forks_url":"https://api.github.com/repos/nemomobile-packages/messagingframework/forks","keys_url":"https://api.github.com/repos/nemomobile-packages/messagingframework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nemomobile-packages/messagingframework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nemomobile-packages/messagingframework/teams","hooks_url":"https://api.github.com/repos/nemomobile-packages/messagingframework/hooks","issue_events_url":"https://api.github.com/repos/nemomobile-packages/messagingframework/issues/events{/number}","events_url":"https://api.github.com/repos/nemomobile-packages/messagingframework/events","assignees_url":"https://api.github.com/repos/nemomobile-packages/messagingframework/assignees{/user}","branches_url":"https://api.github.com/repos/nemomobile-packages/messagingframework/branches{/branch}","tags_url":"https://api.github.com/repos/nemomobile-packages/messagingframework/tags","blobs_url":"https://api.github.com/repos/nemomobile-packages/messagingframework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nemomobile-packages/messagingframework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nemomobile-packages/messagingframework/git/refs{/sha}","trees_url":"https://api.github.com/repos/nemomobile-packages/messagingframework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nemomobile-packages/messagingframework/statuses/{sha}","languages_url":"https://api.github.com/repos/nemomobile-packages/messagingframework/languages","stargazers_url":"https://api.github.com/repos/nemomobile-packages/messagingframework/stargazers","contributors_url":"https://api.github.com/repos/nemomobile-packages/messagingframework/contributors","subscribers_url":"https://api.github.com/repos/nemomobile-packages/messagingframework/subscribers","subscription_url":"https://api.github.com/repos/nemomobile-packages/messagingframework/subscription","commits_url":"https://api.github.com/repos/nemomobile-packages/messagingframework/commits{/sha}","git_commits_url":"https://api.github.com/repos/nemomobile-packages/messagingframework/git/commits{/sha}","comments_url":"https://api.github.com/repos/nemomobile-packages/messagingframework/comments{/number}","issue_comment_url":"https://api.github.com/repos/nemomobile-packages/messagingframework/issues/comments/{number}","contents_url":"https://api.github.com/repos/nemomobile-packages/messagingframework/contents/{+path}","compare_url":"https://api.github.com/repos/nemomobile-packages/messagingframework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nemomobile-packages/messagingframework/merges","archive_url":"https://api.github.com/repos/nemomobile-packages/messagingframework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nemomobile-packages/messagingframework/downloads","issues_url":"https://api.github.com/repos/nemomobile-packages/messagingframework/issues{/number}","pulls_url":"https://api.github.com/repos/nemomobile-packages/messagingframework/pulls{/number}","milestones_url":"https://api.github.com/repos/nemomobile-packages/messagingframework/milestones{/number}","notifications_url":"https://api.github.com/repos/nemomobile-packages/messagingframework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nemomobile-packages/messagingframework/labels{/name}","releases_url":"https://api.github.com/repos/nemomobile-packages/messagingframework/releases{/id}","created_at":"2013-06-03T13:33:19Z","updated_at":"2015-02-17T08:04:45Z","pushed_at":"2015-02-20T17:03:34Z","git_url":"git://github.com/nemomobile-packages/messagingframework.git","ssh_url":"git@github.com:nemomobile-packages/messagingframework.git","clone_url":"https://github.com/nemomobile-packages/messagingframework.git","svn_url":"https://github.com/nemomobile-packages/messagingframework","homepage":null,"size":3792,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":1,"forks":13,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nemomobile-packages/messagingframework/pulls/72"},"html":{"href":"https://github.com/nemomobile-packages/messagingframework/pull/72"},"issue":{"href":"https://api.github.com/repos/nemomobile-packages/messagingframework/issues/72"},"comments":{"href":"https://api.github.com/repos/nemomobile-packages/messagingframework/issues/72/comments"},"review_comments":{"href":"https://api.github.com/repos/nemomobile-packages/messagingframework/pulls/72/comments"},"review_comment":{"href":"https://api.github.com/repos/nemomobile-packages/messagingframework/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/nemomobile-packages/messagingframework/pulls/72/commits"},"statuses":{"href":"https://api.github.com/repos/nemomobile-packages/messagingframework/statuses/815bf24bb935fc77b6bffafd24fced31e7d2c945"}}}}