{"action":"created","comment":{"url":"https://api.github.com/repos/aspnet/Razor/pulls/comments/24708764","id":24708764,"diff_hunk":"@@ -456,6 +457,21 @@ private void RenderTagOutput(string tagOutputMethodName)\n                    .WriteEndMethodInvocation();\n         }\n \n+        private void RenderSelfClosing(bool selfClosing)\n+        {\n+            if (_designTimeMode)\n+            {\n+                return;\n+            }\n+\n+            _writer.Write(ExecutionContextVariableName)\n+                   .Write(\".\")\n+                   .Write(_tagHelperContext.ExecutionContextSelfClosingPropertyName)\n+                   .Write(\" = \")","path":"src/Microsoft.AspNet.Razor/Generator/Compiler/CodeBuilder/CSharp/CSharpTagHelperCodeRenderer.cs","position":22,"original_position":22,"commit_id":"6419030fcaa8322d6132ccf1242300f4600b7bb7","original_commit_id":"6419030fcaa8322d6132ccf1242300f4600b7bb7","user":{"login":"ianhong","id":2746184,"avatar_url":"https://avatars.githubusercontent.com/u/2746184?v=3","gravatar_id":"","url":"https://api.github.com/users/ianhong","html_url":"https://github.com/ianhong","followers_url":"https://api.github.com/users/ianhong/followers","following_url":"https://api.github.com/users/ianhong/following{/other_user}","gists_url":"https://api.github.com/users/ianhong/gists{/gist_id}","starred_url":"https://api.github.com/users/ianhong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianhong/subscriptions","organizations_url":"https://api.github.com/users/ianhong/orgs","repos_url":"https://api.github.com/users/ianhong/repos","events_url":"https://api.github.com/users/ianhong/events{/privacy}","received_events_url":"https://api.github.com/users/ianhong/received_events","type":"User","site_admin":false},"body":"I copied that codes from a different method in the same class I'll update the original one too when I do the actual PR. :-) ","created_at":"2015-02-14T00:35:15Z","updated_at":"2015-02-14T00:35:15Z","html_url":"https://github.com/aspnet/Razor/pull/298#discussion_r24708764","pull_request_url":"https://api.github.com/repos/aspnet/Razor/pulls/298","_links":{"self":{"href":"https://api.github.com/repos/aspnet/Razor/pulls/comments/24708764"},"html":{"href":"https://github.com/aspnet/Razor/pull/298#discussion_r24708764"},"pull_request":{"href":"https://api.github.com/repos/aspnet/Razor/pulls/298"}}},"pull_request":{"url":"https://api.github.com/repos/aspnet/Razor/pulls/298","id":29066196,"html_url":"https://github.com/aspnet/Razor/pull/298","diff_url":"https://github.com/aspnet/Razor/pull/298.diff","patch_url":"https://github.com/aspnet/Razor/pull/298.patch","issue_url":"https://api.github.com/repos/aspnet/Razor/issues/298","number":298,"state":"open","locked":false,"title":"[DesignPR] Fix1571 - Supporting self-closing tags for taghelpers","user":{"login":"ianhong","id":2746184,"avatar_url":"https://avatars.githubusercontent.com/u/2746184?v=3","gravatar_id":"","url":"https://api.github.com/users/ianhong","html_url":"https://github.com/ianhong","followers_url":"https://api.github.com/users/ianhong/followers","following_url":"https://api.github.com/users/ianhong/following{/other_user}","gists_url":"https://api.github.com/users/ianhong/gists{/gist_id}","starred_url":"https://api.github.com/users/ianhong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianhong/subscriptions","organizations_url":"https://api.github.com/users/ianhong/orgs","repos_url":"https://api.github.com/users/ianhong/repos","events_url":"https://api.github.com/users/ianhong/events{/privacy}","received_events_url":"https://api.github.com/users/ianhong/received_events","type":"User","site_admin":false},"body":"@yishaigalatzer, @NTaylorMullen and @dougbu \r\n\r\nThis is the design PR for supporting the self closing tags for TagHelpers. It doesn't contain any unit tests, but I already ran all the MVC functional tests, which contains many samples of self-closing tags. \r\nOnce this design PR is signed-off, I'll add unit tests. ","created_at":"2015-02-11T03:33:19Z","updated_at":"2015-02-14T00:35:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9bda762a9d18f039674f1543ee06abb4b16f8e9f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/aspnet/Razor/pulls/298/commits","review_comments_url":"https://api.github.com/repos/aspnet/Razor/pulls/298/comments","review_comment_url":"https://api.github.com/repos/aspnet/Razor/pulls/comments/{number}","comments_url":"https://api.github.com/repos/aspnet/Razor/issues/298/comments","statuses_url":"https://api.github.com/repos/aspnet/Razor/statuses/6419030fcaa8322d6132ccf1242300f4600b7bb7","head":{"label":"aspnet:fix1571","ref":"fix1571","sha":"6419030fcaa8322d6132ccf1242300f4600b7bb7","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":15835991,"name":"Razor","full_name":"aspnet/Razor","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/Razor","description":"Parser and code generator for CSHTML files used in view pages for MVC web apps.","fork":false,"url":"https://api.github.com/repos/aspnet/Razor","forks_url":"https://api.github.com/repos/aspnet/Razor/forks","keys_url":"https://api.github.com/repos/aspnet/Razor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/Razor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/Razor/teams","hooks_url":"https://api.github.com/repos/aspnet/Razor/hooks","issue_events_url":"https://api.github.com/repos/aspnet/Razor/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/Razor/events","assignees_url":"https://api.github.com/repos/aspnet/Razor/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/Razor/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/Razor/tags","blobs_url":"https://api.github.com/repos/aspnet/Razor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/Razor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/Razor/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/Razor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/Razor/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/Razor/languages","stargazers_url":"https://api.github.com/repos/aspnet/Razor/stargazers","contributors_url":"https://api.github.com/repos/aspnet/Razor/contributors","subscribers_url":"https://api.github.com/repos/aspnet/Razor/subscribers","subscription_url":"https://api.github.com/repos/aspnet/Razor/subscription","commits_url":"https://api.github.com/repos/aspnet/Razor/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/Razor/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/Razor/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/Razor/issues/comments/{number}","contents_url":"https://api.github.com/repos/aspnet/Razor/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/Razor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/Razor/merges","archive_url":"https://api.github.com/repos/aspnet/Razor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/Razor/downloads","issues_url":"https://api.github.com/repos/aspnet/Razor/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/Razor/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/Razor/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/Razor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/Razor/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/Razor/releases{/id}","created_at":"2014-01-12T03:52:46Z","updated_at":"2015-02-13T23:12:08Z","pushed_at":"2015-02-13T23:47:46Z","git_url":"git://github.com/aspnet/Razor.git","ssh_url":"git@github.com:aspnet/Razor.git","clone_url":"https://github.com/aspnet/Razor.git","svn_url":"https://github.com/aspnet/Razor","homepage":"","size":6221,"stargazers_count":288,"watchers_count":288,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":65,"mirror_url":null,"open_issues_count":78,"forks":65,"open_issues":78,"watchers":288,"default_branch":"dev"}},"base":{"label":"aspnet:dev","ref":"dev","sha":"fbe331c1abcf840acab6c7f95e898f3e0ec37f66","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":15835991,"name":"Razor","full_name":"aspnet/Razor","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/Razor","description":"Parser and code generator for CSHTML files used in view pages for MVC web apps.","fork":false,"url":"https://api.github.com/repos/aspnet/Razor","forks_url":"https://api.github.com/repos/aspnet/Razor/forks","keys_url":"https://api.github.com/repos/aspnet/Razor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/Razor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/Razor/teams","hooks_url":"https://api.github.com/repos/aspnet/Razor/hooks","issue_events_url":"https://api.github.com/repos/aspnet/Razor/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/Razor/events","assignees_url":"https://api.github.com/repos/aspnet/Razor/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/Razor/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/Razor/tags","blobs_url":"https://api.github.com/repos/aspnet/Razor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/Razor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/Razor/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/Razor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/Razor/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/Razor/languages","stargazers_url":"https://api.github.com/repos/aspnet/Razor/stargazers","contributors_url":"https://api.github.com/repos/aspnet/Razor/contributors","subscribers_url":"https://api.github.com/repos/aspnet/Razor/subscribers","subscription_url":"https://api.github.com/repos/aspnet/Razor/subscription","commits_url":"https://api.github.com/repos/aspnet/Razor/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/Razor/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/Razor/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/Razor/issues/comments/{number}","contents_url":"https://api.github.com/repos/aspnet/Razor/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/Razor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/Razor/merges","archive_url":"https://api.github.com/repos/aspnet/Razor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/Razor/downloads","issues_url":"https://api.github.com/repos/aspnet/Razor/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/Razor/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/Razor/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/Razor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/Razor/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/Razor/releases{/id}","created_at":"2014-01-12T03:52:46Z","updated_at":"2015-02-13T23:12:08Z","pushed_at":"2015-02-13T23:47:46Z","git_url":"git://github.com/aspnet/Razor.git","ssh_url":"git@github.com:aspnet/Razor.git","clone_url":"https://github.com/aspnet/Razor.git","svn_url":"https://github.com/aspnet/Razor","homepage":"","size":6221,"stargazers_count":288,"watchers_count":288,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":65,"mirror_url":null,"open_issues_count":78,"forks":65,"open_issues":78,"watchers":288,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/aspnet/Razor/pulls/298"},"html":{"href":"https://github.com/aspnet/Razor/pull/298"},"issue":{"href":"https://api.github.com/repos/aspnet/Razor/issues/298"},"comments":{"href":"https://api.github.com/repos/aspnet/Razor/issues/298/comments"},"review_comments":{"href":"https://api.github.com/repos/aspnet/Razor/pulls/298/comments"},"review_comment":{"href":"https://api.github.com/repos/aspnet/Razor/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/aspnet/Razor/pulls/298/commits"},"statuses":{"href":"https://api.github.com/repos/aspnet/Razor/statuses/6419030fcaa8322d6132ccf1242300f4600b7bb7"}}}}