{"action":"created","comment":{"url":"https://api.github.com/repos/Inspirato/SwiftPhotoGallery/pulls/comments/39884093","id":39884093,"diff_hunk":"@@ -191,6 +206,7 @@ public class SwiftPhotoGallery: UIViewController, UICollectionViewDataSource, UI\n         imageCollectionView.dataSource = self\n         imageCollectionView.delegate = self\n         imageCollectionView.pagingEnabled = true\n+        imageCollectionView.backgroundColor = backgroundColor","path":"Pod/Classes/SwiftPhotoGallery.swift","position":66,"original_position":66,"commit_id":"cc9ca8a844d43a857c93cd4d42ece0b81cc56273","original_commit_id":"cc9ca8a844d43a857c93cd4d42ece0b81cc56273","user":{"login":"Spencevail","id":880083,"avatar_url":"https://avatars.githubusercontent.com/u/880083?v=3","gravatar_id":"","url":"https://api.github.com/users/Spencevail","html_url":"https://github.com/Spencevail","followers_url":"https://api.github.com/users/Spencevail/followers","following_url":"https://api.github.com/users/Spencevail/following{/other_user}","gists_url":"https://api.github.com/users/Spencevail/gists{/gist_id}","starred_url":"https://api.github.com/users/Spencevail/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Spencevail/subscriptions","organizations_url":"https://api.github.com/users/Spencevail/orgs","repos_url":"https://api.github.com/users/Spencevail/repos","events_url":"https://api.github.com/users/Spencevail/events{/privacy}","received_events_url":"https://api.github.com/users/Spencevail/received_events","type":"User","site_admin":false},"body":"Try to remove [temporal coupling](http://blog.ploeh.dk/2011/05/24/DesignSmellTemporalCoupling/) as much as possible from your code. If someone changes the background color *after* `setupCollectionView` has been called this won't work. On top of that there is no test to demonstrate this and there's no indication in the variable name or anything that this must be set before the view is actually instantiated. Look at [my other comment](https://github.com/Inspirato/SwiftPhotoGallery/pull/3/files#r39881436) on how to address this.","created_at":"2015-09-18T18:10:45Z","updated_at":"2015-09-18T18:10:45Z","html_url":"https://github.com/Inspirato/SwiftPhotoGallery/pull/3#discussion_r39884093","pull_request_url":"https://api.github.com/repos/Inspirato/SwiftPhotoGallery/pulls/3","_links":{"self":{"href":"https://api.github.com/repos/Inspirato/SwiftPhotoGallery/pulls/comments/39884093"},"html":{"href":"https://github.com/Inspirato/SwiftPhotoGallery/pull/3#discussion_r39884093"},"pull_request":{"href":"https://api.github.com/repos/Inspirato/SwiftPhotoGallery/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/Inspirato/SwiftPhotoGallery/pulls/3","id":45184570,"html_url":"https://github.com/Inspirato/SwiftPhotoGallery/pull/3","diff_url":"https://github.com/Inspirato/SwiftPhotoGallery/pull/3.diff","patch_url":"https://github.com/Inspirato/SwiftPhotoGallery/pull/3.patch","issue_url":"https://api.github.com/repos/Inspirato/SwiftPhotoGallery/issues/3","number":3,"state":"open","locked":false,"title":"Animation to auto-hide the page control","user":{"login":"justinvallely","id":11352698,"avatar_url":"https://avatars.githubusercontent.com/u/11352698?v=3","gravatar_id":"","url":"https://api.github.com/users/justinvallely","html_url":"https://github.com/justinvallely","followers_url":"https://api.github.com/users/justinvallely/followers","following_url":"https://api.github.com/users/justinvallely/following{/other_user}","gists_url":"https://api.github.com/users/justinvallely/gists{/gist_id}","starred_url":"https://api.github.com/users/justinvallely/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinvallely/subscriptions","organizations_url":"https://api.github.com/users/justinvallely/orgs","repos_url":"https://api.github.com/users/justinvallely/repos","events_url":"https://api.github.com/users/justinvallely/events{/privacy}","received_events_url":"https://api.github.com/users/justinvallely/received_events","type":"User","site_admin":false},"body":"Page control alpha fades to 0 after 2 seconds. Instantly set alpha back to 1 when swiping between images.","created_at":"2015-09-16T15:14:30Z","updated_at":"2015-09-18T18:10:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9004473d565e5e466430b32477d45020a002ae97","assignee":{"login":"Spencevail","id":880083,"avatar_url":"https://avatars.githubusercontent.com/u/880083?v=3","gravatar_id":"","url":"https://api.github.com/users/Spencevail","html_url":"https://github.com/Spencevail","followers_url":"https://api.github.com/users/Spencevail/followers","following_url":"https://api.github.com/users/Spencevail/following{/other_user}","gists_url":"https://api.github.com/users/Spencevail/gists{/gist_id}","starred_url":"https://api.github.com/users/Spencevail/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Spencevail/subscriptions","organizations_url":"https://api.github.com/users/Spencevail/orgs","repos_url":"https://api.github.com/users/Spencevail/repos","events_url":"https://api.github.com/users/Spencevail/events{/privacy}","received_events_url":"https://api.github.com/users/Spencevail/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/Inspirato/SwiftPhotoGallery/pulls/3/commits","review_comments_url":"https://api.github.com/repos/Inspirato/SwiftPhotoGallery/pulls/3/comments","review_comment_url":"https://api.github.com/repos/Inspirato/SwiftPhotoGallery/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Inspirato/SwiftPhotoGallery/issues/3/comments","statuses_url":"https://api.github.com/repos/Inspirato/SwiftPhotoGallery/statuses/cc9ca8a844d43a857c93cd4d42ece0b81cc56273","head":{"label":"Inspirato:feature/JMV-3-auto_hide_page_control","ref":"feature/JMV-3-auto_hide_page_control","sha":"cc9ca8a844d43a857c93cd4d42ece0b81cc56273","user":{"login":"Inspirato","id":1399110,"avatar_url":"https://avatars.githubusercontent.com/u/1399110?v=3","gravatar_id":"","url":"https://api.github.com/users/Inspirato","html_url":"https://github.com/Inspirato","followers_url":"https://api.github.com/users/Inspirato/followers","following_url":"https://api.github.com/users/Inspirato/following{/other_user}","gists_url":"https://api.github.com/users/Inspirato/gists{/gist_id}","starred_url":"https://api.github.com/users/Inspirato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Inspirato/subscriptions","organizations_url":"https://api.github.com/users/Inspirato/orgs","repos_url":"https://api.github.com/users/Inspirato/repos","events_url":"https://api.github.com/users/Inspirato/events{/privacy}","received_events_url":"https://api.github.com/users/Inspirato/received_events","type":"Organization","site_admin":false},"repo":{"id":42273429,"name":"SwiftPhotoGallery","full_name":"Inspirato/SwiftPhotoGallery","owner":{"login":"Inspirato","id":1399110,"avatar_url":"https://avatars.githubusercontent.com/u/1399110?v=3","gravatar_id":"","url":"https://api.github.com/users/Inspirato","html_url":"https://github.com/Inspirato","followers_url":"https://api.github.com/users/Inspirato/followers","following_url":"https://api.github.com/users/Inspirato/following{/other_user}","gists_url":"https://api.github.com/users/Inspirato/gists{/gist_id}","starred_url":"https://api.github.com/users/Inspirato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Inspirato/subscriptions","organizations_url":"https://api.github.com/users/Inspirato/orgs","repos_url":"https://api.github.com/users/Inspirato/repos","events_url":"https://api.github.com/users/Inspirato/events{/privacy}","received_events_url":"https://api.github.com/users/Inspirato/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Inspirato/SwiftPhotoGallery","description":"iOS photo gallery written in Swift","fork":false,"url":"https://api.github.com/repos/Inspirato/SwiftPhotoGallery","forks_url":"https://api.github.com/repos/Inspirato/SwiftPhotoGallery/forks","keys_url":"https://api.github.com/repos/Inspirato/SwiftPhotoGallery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Inspirato/SwiftPhotoGallery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Inspirato/SwiftPhotoGallery/teams","hooks_url":"https://api.github.com/repos/Inspirato/SwiftPhotoGallery/hooks","issue_events_url":"https://api.github.com/repos/Inspirato/SwiftPhotoGallery/issues/events{/number}","events_url":"https://api.github.com/repos/Inspirato/SwiftPhotoGallery/events","assignees_url":"https://api.github.com/repos/Inspirato/SwiftPhotoGallery/assignees{/user}","branches_url":"https://api.github.com/repos/Inspirato/SwiftPhotoGallery/branches{/branch}","tags_url":"https://api.github.com/repos/Inspirato/SwiftPhotoGallery/tags","blobs_url":"https://api.github.com/repos/Inspirato/SwiftPhotoGallery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Inspirato/SwiftPhotoGallery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Inspirato/SwiftPhotoGallery/git/refs{/sha}","trees_url":"https://api.github.com/repos/Inspirato/SwiftPhotoGallery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Inspirato/SwiftPhotoGallery/statuses/{sha}","languages_url":"https://api.github.com/repos/Inspirato/SwiftPhotoGallery/languages","stargazers_url":"https://api.github.com/repos/Inspirato/SwiftPhotoGallery/stargazers","contributors_url":"https://api.github.com/repos/Inspirato/SwiftPhotoGallery/contributors","subscribers_url":"https://api.github.com/repos/Inspirato/SwiftPhotoGallery/subscribers","subscription_url":"https://api.github.com/repos/Inspirato/SwiftPhotoGallery/subscription","commits_url":"https://api.github.com/repos/Inspirato/SwiftPhotoGallery/commits{/sha}","git_commits_url":"https://api.github.com/repos/Inspirato/SwiftPhotoGallery/git/commits{/sha}","comments_url":"https://api.github.com/repos/Inspirato/SwiftPhotoGallery/comments{/number}","issue_comment_url":"https://api.github.com/repos/Inspirato/SwiftPhotoGallery/issues/comments{/number}","contents_url":"https://api.github.com/repos/Inspirato/SwiftPhotoGallery/contents/{+path}","compare_url":"https://api.github.com/repos/Inspirato/SwiftPhotoGallery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Inspirato/SwiftPhotoGallery/merges","archive_url":"https://api.github.com/repos/Inspirato/SwiftPhotoGallery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Inspirato/SwiftPhotoGallery/downloads","issues_url":"https://api.github.com/repos/Inspirato/SwiftPhotoGallery/issues{/number}","pulls_url":"https://api.github.com/repos/Inspirato/SwiftPhotoGallery/pulls{/number}","milestones_url":"https://api.github.com/repos/Inspirato/SwiftPhotoGallery/milestones{/number}","notifications_url":"https://api.github.com/repos/Inspirato/SwiftPhotoGallery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Inspirato/SwiftPhotoGallery/labels{/name}","releases_url":"https://api.github.com/repos/Inspirato/SwiftPhotoGallery/releases{/id}","created_at":"2015-09-10T22:12:20Z","updated_at":"2015-09-11T16:01:44Z","pushed_at":"2015-09-17T21:29:12Z","git_url":"git://github.com/Inspirato/SwiftPhotoGallery.git","ssh_url":"git@github.com:Inspirato/SwiftPhotoGallery.git","clone_url":"https://github.com/Inspirato/SwiftPhotoGallery.git","svn_url":"https://github.com/Inspirato/SwiftPhotoGallery","homepage":null,"size":24280,"stargazers_count":2,"watchers_count":2,"language":"Swift","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":2,"default_branch":"master"}},"base":{"label":"Inspirato:master","ref":"master","sha":"c66b735cd6371388a8abf1a291f7b11a18d4c6fb","user":{"login":"Inspirato","id":1399110,"avatar_url":"https://avatars.githubusercontent.com/u/1399110?v=3","gravatar_id":"","url":"https://api.github.com/users/Inspirato","html_url":"https://github.com/Inspirato","followers_url":"https://api.github.com/users/Inspirato/followers","following_url":"https://api.github.com/users/Inspirato/following{/other_user}","gists_url":"https://api.github.com/users/Inspirato/gists{/gist_id}","starred_url":"https://api.github.com/users/Inspirato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Inspirato/subscriptions","organizations_url":"https://api.github.com/users/Inspirato/orgs","repos_url":"https://api.github.com/users/Inspirato/repos","events_url":"https://api.github.com/users/Inspirato/events{/privacy}","received_events_url":"https://api.github.com/users/Inspirato/received_events","type":"Organization","site_admin":false},"repo":{"id":42273429,"name":"SwiftPhotoGallery","full_name":"Inspirato/SwiftPhotoGallery","owner":{"login":"Inspirato","id":1399110,"avatar_url":"https://avatars.githubusercontent.com/u/1399110?v=3","gravatar_id":"","url":"https://api.github.com/users/Inspirato","html_url":"https://github.com/Inspirato","followers_url":"https://api.github.com/users/Inspirato/followers","following_url":"https://api.github.com/users/Inspirato/following{/other_user}","gists_url":"https://api.github.com/users/Inspirato/gists{/gist_id}","starred_url":"https://api.github.com/users/Inspirato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Inspirato/subscriptions","organizations_url":"https://api.github.com/users/Inspirato/orgs","repos_url":"https://api.github.com/users/Inspirato/repos","events_url":"https://api.github.com/users/Inspirato/events{/privacy}","received_events_url":"https://api.github.com/users/Inspirato/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Inspirato/SwiftPhotoGallery","description":"iOS photo gallery written in Swift","fork":false,"url":"https://api.github.com/repos/Inspirato/SwiftPhotoGallery","forks_url":"https://api.github.com/repos/Inspirato/SwiftPhotoGallery/forks","keys_url":"https://api.github.com/repos/Inspirato/SwiftPhotoGallery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Inspirato/SwiftPhotoGallery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Inspirato/SwiftPhotoGallery/teams","hooks_url":"https://api.github.com/repos/Inspirato/SwiftPhotoGallery/hooks","issue_events_url":"https://api.github.com/repos/Inspirato/SwiftPhotoGallery/issues/events{/number}","events_url":"https://api.github.com/repos/Inspirato/SwiftPhotoGallery/events","assignees_url":"https://api.github.com/repos/Inspirato/SwiftPhotoGallery/assignees{/user}","branches_url":"https://api.github.com/repos/Inspirato/SwiftPhotoGallery/branches{/branch}","tags_url":"https://api.github.com/repos/Inspirato/SwiftPhotoGallery/tags","blobs_url":"https://api.github.com/repos/Inspirato/SwiftPhotoGallery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Inspirato/SwiftPhotoGallery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Inspirato/SwiftPhotoGallery/git/refs{/sha}","trees_url":"https://api.github.com/repos/Inspirato/SwiftPhotoGallery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Inspirato/SwiftPhotoGallery/statuses/{sha}","languages_url":"https://api.github.com/repos/Inspirato/SwiftPhotoGallery/languages","stargazers_url":"https://api.github.com/repos/Inspirato/SwiftPhotoGallery/stargazers","contributors_url":"https://api.github.com/repos/Inspirato/SwiftPhotoGallery/contributors","subscribers_url":"https://api.github.com/repos/Inspirato/SwiftPhotoGallery/subscribers","subscription_url":"https://api.github.com/repos/Inspirato/SwiftPhotoGallery/subscription","commits_url":"https://api.github.com/repos/Inspirato/SwiftPhotoGallery/commits{/sha}","git_commits_url":"https://api.github.com/repos/Inspirato/SwiftPhotoGallery/git/commits{/sha}","comments_url":"https://api.github.com/repos/Inspirato/SwiftPhotoGallery/comments{/number}","issue_comment_url":"https://api.github.com/repos/Inspirato/SwiftPhotoGallery/issues/comments{/number}","contents_url":"https://api.github.com/repos/Inspirato/SwiftPhotoGallery/contents/{+path}","compare_url":"https://api.github.com/repos/Inspirato/SwiftPhotoGallery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Inspirato/SwiftPhotoGallery/merges","archive_url":"https://api.github.com/repos/Inspirato/SwiftPhotoGallery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Inspirato/SwiftPhotoGallery/downloads","issues_url":"https://api.github.com/repos/Inspirato/SwiftPhotoGallery/issues{/number}","pulls_url":"https://api.github.com/repos/Inspirato/SwiftPhotoGallery/pulls{/number}","milestones_url":"https://api.github.com/repos/Inspirato/SwiftPhotoGallery/milestones{/number}","notifications_url":"https://api.github.com/repos/Inspirato/SwiftPhotoGallery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Inspirato/SwiftPhotoGallery/labels{/name}","releases_url":"https://api.github.com/repos/Inspirato/SwiftPhotoGallery/releases{/id}","created_at":"2015-09-10T22:12:20Z","updated_at":"2015-09-11T16:01:44Z","pushed_at":"2015-09-17T21:29:12Z","git_url":"git://github.com/Inspirato/SwiftPhotoGallery.git","ssh_url":"git@github.com:Inspirato/SwiftPhotoGallery.git","clone_url":"https://github.com/Inspirato/SwiftPhotoGallery.git","svn_url":"https://github.com/Inspirato/SwiftPhotoGallery","homepage":null,"size":24280,"stargazers_count":2,"watchers_count":2,"language":"Swift","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Inspirato/SwiftPhotoGallery/pulls/3"},"html":{"href":"https://github.com/Inspirato/SwiftPhotoGallery/pull/3"},"issue":{"href":"https://api.github.com/repos/Inspirato/SwiftPhotoGallery/issues/3"},"comments":{"href":"https://api.github.com/repos/Inspirato/SwiftPhotoGallery/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/Inspirato/SwiftPhotoGallery/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/Inspirato/SwiftPhotoGallery/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Inspirato/SwiftPhotoGallery/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/Inspirato/SwiftPhotoGallery/statuses/cc9ca8a844d43a857c93cd4d42ece0b81cc56273"}}}}