{"action":"created","issue":{"url":"https://api.github.com/repos/collective/covertile.cycle2/issues/7","labels_url":"https://api.github.com/repos/collective/covertile.cycle2/issues/7/labels{/name}","comments_url":"https://api.github.com/repos/collective/covertile.cycle2/issues/7/comments","events_url":"https://api.github.com/repos/collective/covertile.cycle2/issues/7/events","html_url":"https://github.com/collective/covertile.cycle2/issues/7","id":76710664,"number":7,"title":"Remove inline script","user":{"login":"rodfersou","id":131209,"avatar_url":"https://avatars.githubusercontent.com/u/131209?v=3","gravatar_id":"","url":"https://api.github.com/users/rodfersou","html_url":"https://github.com/rodfersou","followers_url":"https://api.github.com/users/rodfersou/followers","following_url":"https://api.github.com/users/rodfersou/following{/other_user}","gists_url":"https://api.github.com/users/rodfersou/gists{/gist_id}","starred_url":"https://api.github.com/users/rodfersou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rodfersou/subscriptions","organizations_url":"https://api.github.com/users/rodfersou/orgs","repos_url":"https://api.github.com/users/rodfersou/repos","events_url":"https://api.github.com/users/rodfersou/events{/privacy}","received_events_url":"https://api.github.com/users/rodfersou/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/collective/covertile.cycle2/labels/question","name":"question","color":"cc317c"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2015-05-15T12:20:20Z","updated_at":"2015-05-20T12:04:47Z","closed_at":null,"body":"If you add the cycle-slideshow class here https://github.com/collective/covertile.cycle2/blob/master/src/covertile/cycle2/tiles/templates/carousel.pt#L68 you will not need to add the inline script here https://github.com/collective/covertile.cycle2/blob/master/src/covertile/cycle2/tiles/templates/carousel.pt#L68\r\n\r\nit just don't work if the html is loaded by some ajax call.. in this case you need to make the `$( '.covertile-cycle2' ).cycle();` call when the ajax finish\r\n\r\nInline scripts are a PITA when you need to make a code that pass into acessibility checkers..\r\n\r\nIf this case really need to have this javascript, I suggest to move it into a registered separated javascript file."},"comment":{"url":"https://api.github.com/repos/collective/covertile.cycle2/issues/comments/103859190","html_url":"https://github.com/collective/covertile.cycle2/issues/7#issuecomment-103859190","issue_url":"https://api.github.com/repos/collective/covertile.cycle2/issues/7","id":103859190,"user":{"login":"rodfersou","id":131209,"avatar_url":"https://avatars.githubusercontent.com/u/131209?v=3","gravatar_id":"","url":"https://api.github.com/users/rodfersou","html_url":"https://github.com/rodfersou","followers_url":"https://api.github.com/users/rodfersou/followers","following_url":"https://api.github.com/users/rodfersou/following{/other_user}","gists_url":"https://api.github.com/users/rodfersou/gists{/gist_id}","starred_url":"https://api.github.com/users/rodfersou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rodfersou/subscriptions","organizations_url":"https://api.github.com/users/rodfersou/orgs","repos_url":"https://api.github.com/users/rodfersou/repos","events_url":"https://api.github.com/users/rodfersou/events{/privacy}","received_events_url":"https://api.github.com/users/rodfersou/received_events","type":"User","site_admin":false},"created_at":"2015-05-20T12:04:47Z","updated_at":"2015-05-20T12:04:47Z","body":"@djowett @polyester @hvelarde in fact, inline scripts could be harmless and we (people) know when it is and when it is not.\r\n\r\nBut automated accessibility checkers are not as intelligent as we are, so I prefer to keep the layout without inline scripts when possible."}}