{"push_id":906103612,"size":7,"distinct_size":7,"ref":"refs/heads/v1.1.1-maint","head":"692ce509efa0a07f2811d0fe3b7202b020c874e0","before":"2c6fc46d987911e310d30621cd6fc195af102fee","commits":[{"sha":"09585f7cb118017af6dd90943c736d0f904ff754","author":{"email":"a9da18479c871fe903d9590822cfe2629c6a4d11@redhat.com","name":"Eric Blake"},"message":"build: add configure option to disable gnulib tests\n\nThe gnulib testsuite is relatively stable - the only times it is\nlikely to have a test change from pass to fail is on a gnulib\nsubmodule update or a major system change (such as moving from\nFedora 18 to 19, or other large change to libc).  While it is an\nimportant test for end users on arbitrary machines (to make sure\nthat the portability glue works for their machine), it mostly\nwastes time for development testing (as most developers aren't\nmaking any of the major changes that would cause gnulib tests\nto alter behavior).  Thus, it pays to make the tests optional\nat configure time, defaulting to off for development, on for\ntarballs, with autobuilders requesting it to be on.  It also\nhelps to allow a make-time override, via VIR_TEST_EXPENSIVE=[01]\n(much the way automake sets up V=[01] for overriding the configure\ntime default of how verbose to be).\n\nAutomake has some pretty hard-coded magic with regards to the\nTESTS variable; I had quite a job figuring out how to keep\n'make distcheck' passing regardless of the configure option\nsetting in use, while still disabling the tests at runtime\nwhen I did not configure them on and did not use the override\nvariable.  Thankfully, we require GNU make, which lets me\nhide some information from Automake's magic handling of TESTS.\n\n* bootstrap.conf (bootstrap_epilogue): Munge gnulib test variable.\n* configure.ac (--enable-expensive-tests): Add new enable switch.\n(VIR_TEST_EXPENSIVE_DEFAULT, WITH_EXPENSIVE_TESTS): Set new\nwitnesses.\n* gnulib/tests/Makefile.am (TESTS): Make tests conditional on\nconfigure settings and the VIR_TEST_EXPENSIVE variable.\n* tests/Makefile.am (TESTS_ENVIRONMENT): Expose VIR_TEST_EXPENSIVE\nto all tests.\n* autobuild.sh: Enable all tests during autobuilds.\n* libvirt.spec.in (%configure): Likewise.\n* mingw-libvirt.spec.in (%mingw_configure): Likewise.\n* docs/hacking.html.in: Document the option.\n* HACKING: Regenerate.\n\nSigned-off-by: Eric Blake <eblake@redhat.com>\n(cherry picked from commit 70363ea9ff953d34d240c60723554e63c5a5fb39)\n\nConflicts:\n\tlibvirt.spec.in - no backport of d5cd5bf","distinct":true,"url":"https://api.github.com/repos/libvirt/libvirt/commits/09585f7cb118017af6dd90943c736d0f904ff754"},{"sha":"7227fbbabf8a26f68114070cc5390f5e6d920a88","author":{"email":"a9da18479c871fe903d9590822cfe2629c6a4d11@redhat.com","name":"Eric Blake"},"message":"qemu: endjob returns a bool\n\nOsier Yang pointed out that ever since commit 31cb030, the\nsignature of qemuDomainObjEndJob was changed to return a bool.\nWhile comparison against 0 or > 0 still gives the right results,\nit looks fishy; we also had one place that was comparing < 0\nwhich is effectively dead code.\n\n* src/qemu/qemu_migration.c (qemuMigrationPrepareAny): Fix dead\ncode bug.\n(qemuMigrationBegin): Use more canonical form of bool check.\n* src/qemu/qemu_driver.c (qemuAutostartDomain)\n(qemuDomainCreateXML, qemuDomainSuspend, qemuDomainResume)\n(qemuDomainShutdownFlags, qemuDomainReboot, qemuDomainReset)\n(qemuDomainDestroyFlags, qemuDomainSetMemoryFlags)\n(qemuDomainSetMemoryStatsPeriod, qemuDomainInjectNMI)\n(qemuDomainSendKey, qemuDomainGetInfo, qemuDomainScreenshot)\n(qemuDomainSetVcpusFlags, qemuDomainGetVcpusFlags)\n(qemuDomainRestoreFlags, qemuDomainGetXMLDesc)\n(qemuDomainCreateWithFlags, qemuDomainAttachDeviceFlags)\n(qemuDomainUpdateDeviceFlags, qemuDomainDetachDeviceFlags)\n(qemuDomainBlockResize, qemuDomainBlockStats)\n(qemuDomainBlockStatsFlags, qemuDomainMemoryStats)\n(qemuDomainMemoryPeek, qemuDomainGetBlockInfo)\n(qemuDomainAbortJob, qemuDomainMigrateSetMaxDowntime)\n(qemuDomainMigrateGetCompressionCache)\n(qemuDomainMigrateSetCompressionCache)\n(qemuDomainMigrateSetMaxSpeed)\n(qemuDomainSnapshotCreateActiveInternal)\n(qemuDomainRevertToSnapshot, qemuDomainSnapshotDelete)\n(qemuDomainQemuMonitorCommand, qemuDomainQemuAttach)\n(qemuDomainBlockJobImpl, qemuDomainBlockCopy)\n(qemuDomainBlockCommit, qemuDomainOpenGraphics)\n(qemuDomainGetBlockIoTune, qemuDomainGetDiskErrors)\n(qemuDomainPMSuspendForDuration, qemuDomainPMWakeup)\n(qemuDomainQemuAgentCommand, qemuDomainFSTrim): Likewise.\n\nSigned-off-by: Eric Blake <eblake@redhat.com>\n(cherry picked from commit 6cd15482586334a822d248dd8b94cee0635d3e64)\n\nConflicts:\n\tsrc/qemu/qemu_driver.c - some intermediate patches not backported","distinct":true,"url":"https://api.github.com/repos/libvirt/libvirt/commits/7227fbbabf8a26f68114070cc5390f5e6d920a88"},{"sha":"7ceeb5e4a1a8ddefd454ba4e092e8ddf4e05f186","author":{"email":"3bc232effbfb0bd9cdda6a741d96b74d3322f99c@citrix.com","name":"Dario Faggioli"},"message":"libxl: don't break the build on Xen>=4.5 because of libxl_vcpu_setaffinity()\n\nlibxl interface for vcpu pinning is changing in Xen 4.5. Basically,\nlibxl_set_vcpuaffinity() now wants one more parameter. That is\nrepresentative of 'VCPU soft affinity', which libvirt does not use.\n\nTo mark such change, the macro LIBXL_HAVE_VCPUINFO_SOFT_AFFINITY is\ndefined. Use it as a gate and, if present, re-#define the calls from\nthe old to the new interface, to avoid breaking the build.\n\nSigned-off-by: Dario Faggioli <dario.faggioli@citrix.com>\nCc: Jim Fehlig <jfehlig@suse.com>\nCc: Ian Campbell <Ian.Campbell@citrix.com>\nCc: Ian Jackson <Ian.Jackson@eu.citrix.com>\n(cherry picked from commit bfc72e99920215c9b004a5380ca61fe6ff81ea6b)","distinct":true,"url":"https://api.github.com/repos/libvirt/libvirt/commits/7ceeb5e4a1a8ddefd454ba4e092e8ddf4e05f186"},{"sha":"9602ae2260185b51619e34f823ac357087e1f3ee","author":{"email":"4cab11cfb98d3c937327354a78eb07dbb6ee2bc6@redhat.com","name":"Ján Tomko"},"message":"Properly check the return value of CCWAddressAsString\n\nIt returns NULL on failure. Checking if the negation of it\nis less than zero makes no sense. (Found by coverity after moving\nthe code)\n\nIn another case, the return value wasn't checked at all.\n\n(cherry picked from commit 3fe9d75ab641f5b676845980a0ee7aef8148da9b)\n\nConflicts:\n\tsrc/conf/domain_addr.c - no code movement from commit b2626755","distinct":true,"url":"https://api.github.com/repos/libvirt/libvirt/commits/9602ae2260185b51619e34f823ac357087e1f3ee"},{"sha":"72d349e8d72928a76cc5712945160d855fd366e6","author":{"email":"bb938cf255e055ff3507f2627d214e8e62118fcf@redhat.com","name":"Daniel P. Berrange"},"message":"avoid using deprecated udev logging functions\n\nIn systemd >= 218, the udev_set_log_fn method has been marked\ndeprecated and turned into a no-op. Nothing in the udev client\nlibrary will print to stderr by default anymore, so we can\njust stop installing a logging hook for new enough udev.\n\n(cherry picked from commit a93a3b975cd0bad37ccae508d9b7a69aa72b6181)","distinct":true,"url":"https://api.github.com/repos/libvirt/libvirt/commits/72d349e8d72928a76cc5712945160d855fd366e6"},{"sha":"d6552bc1398c409646a79f72d03fc33bc4015fa1","author":{"email":"e82f23e74d43760279ebcc505dac4ae70d5627d0@redhat.com","name":"Martin Kletzander"},"message":"util: Prepare URI formatting for libxml2 >= 2.9.2\n\nSince commit 8eb55d782a2b9afacc7938694891cc6fad7b42a5 libxml2 removes\ntwo slashes from the URI when there is no server part.  This is fixed\nwith beb7281055dbf0ed4d041022a67c6c5cfd126f25, but only if the calling\napplication calls xmlSaveUri() on URI that xmlURIParse() parsed.  And\nthat is not the case in virURIFormat().  virURIFormat() accepts\nvirURIPtr that can be created without parsing it and we do that when we\nformat network storage paths for gluster for example.  Even though\nvirStorageSourceParseBackingURI() uses virURIParse(), it throws that data\nstructure right away.\n\nSince we want to format URIs as URIs and not absolute URIs or opaque\nURIs (see RFC 3986), we can specify that with a special hack thanks to\ncommit beb7281055dbf0ed4d041022a67c6c5cfd126f25, by setting port to -1.\n\nThis fixes qemuxml2argvtest test where the disk-drive-network-gluster\ncase was failing.\n\nSigned-off-by: Martin Kletzander <mkletzan@redhat.com>\n(cherry picked from commit 8f17d0eaae7ee2fa3e214b79b188fc14ed5aa1eb)","distinct":true,"url":"https://api.github.com/repos/libvirt/libvirt/commits/d6552bc1398c409646a79f72d03fc33bc4015fa1"},{"sha":"692ce509efa0a07f2811d0fe3b7202b020c874e0","author":{"email":"a9da18479c871fe903d9590822cfe2629c6a4d11@redhat.com","name":"Eric Blake"},"message":"CVE-2015-5313: storage: don't allow '/' in filesystem volume names\n\nThe libvirt file system storage driver determines what file to\nact on by concatenating the pool location with the volume name.\nIf a user is able to pick names like \"../../../etc/passwd\", then\nthey can escape the bounds of the pool.  For that matter,\nvirStoragePoolListVolumes() doesn't descend into subdirectories,\nso a user really shouldn't use a name with a slash.\n\nNormally, only privileged users can coerce libvirt into creating\nor opening existing files using the virStorageVol APIs; and such\nusers already have full privilege to create any domain XML (so it\nis not an escalation of privilege).  But in the case of\nfine-grained ACLs, it is feasible that a user can be granted\nstorage_vol:create but not domain:write, and it violates\nassumptions if such a user can abuse libvirt to access files\noutside of the storage pool.\n\nTherefore, prevent all use of volume names that contain \"/\",\nwhether or not such a name is actually attempting to escape the\npool.\n\nThis changes things from:\n\n$ virsh vol-create-as default ../../../../../../etc/haha --capacity 128\nVol ../../../../../../etc/haha created\n$ rm /etc/haha\n\nto:\n\n$ virsh vol-create-as default ../../../../../../etc/haha --capacity 128\nerror: Failed to create vol ../../../../../../etc/haha\nerror: Requested operation is not valid: volume name '../../../../../../etc/haha' cannot contain '/'\n\nSigned-off-by: Eric Blake <eblake@redhat.com>\n(cherry picked from commit 034e47c338b13a95cf02106a3af912c1c5f818d7)\n\nConflicts:\n\tsrc/storage/storage_backend_fs.c - trivial copyright date collision","distinct":true,"url":"https://api.github.com/repos/libvirt/libvirt/commits/692ce509efa0a07f2811d0fe3b7202b020c874e0"}]}