{"action":"created","issue":{"url":"https://api.github.com/repos/saltstack/salt/issues/28911","labels_url":"https://api.github.com/repos/saltstack/salt/issues/28911/labels{/name}","comments_url":"https://api.github.com/repos/saltstack/salt/issues/28911/comments","events_url":"https://api.github.com/repos/saltstack/salt/issues/28911/events","html_url":"https://github.com/saltstack/salt/issues/28911","id":117038407,"number":28911,"title":"GitFS numeric tags cause errors with environments","user":{"login":"ccmills","id":3967441,"avatar_url":"https://avatars.githubusercontent.com/u/3967441?v=3","gravatar_id":"","url":"https://api.github.com/users/ccmills","html_url":"https://github.com/ccmills","followers_url":"https://api.github.com/users/ccmills/followers","following_url":"https://api.github.com/users/ccmills/following{/other_user}","gists_url":"https://api.github.com/users/ccmills/gists{/gist_id}","starred_url":"https://api.github.com/users/ccmills/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ccmills/subscriptions","organizations_url":"https://api.github.com/users/ccmills/orgs","repos_url":"https://api.github.com/users/ccmills/repos","events_url":"https://api.github.com/users/ccmills/events{/privacy}","received_events_url":"https://api.github.com/users/ccmills/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/saltstack/salt/labels/Bug","name":"Bug","color":"e11d21"},{"url":"https://api.github.com/repos/saltstack/salt/labels/Core","name":"Core","color":"fef2c0"},{"url":"https://api.github.com/repos/saltstack/salt/labels/File%20Servers","name":"File Servers","color":"006b75"},{"url":"https://api.github.com/repos/saltstack/salt/labels/Fixed%20Pending%20Verification","name":"Fixed Pending Verification","color":"d4c5f9"},{"url":"https://api.github.com/repos/saltstack/salt/labels/High%20Severity","name":"High Severity","color":"ff9143"},{"url":"https://api.github.com/repos/saltstack/salt/labels/P2","name":"P2","color":"155fb5"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/saltstack/salt/milestones/13","html_url":"https://github.com/saltstack/salt/milestones/Approved","labels_url":"https://api.github.com/repos/saltstack/salt/milestones/13/labels","id":9265,"number":13,"title":"Approved","description":"All issues that are ready to be worked on, both bugs and features.","creator":{"login":"thatch45","id":507599,"avatar_url":"https://avatars.githubusercontent.com/u/507599?v=3","gravatar_id":"","url":"https://api.github.com/users/thatch45","html_url":"https://github.com/thatch45","followers_url":"https://api.github.com/users/thatch45/followers","following_url":"https://api.github.com/users/thatch45/following{/other_user}","gists_url":"https://api.github.com/users/thatch45/gists{/gist_id}","starred_url":"https://api.github.com/users/thatch45/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thatch45/subscriptions","organizations_url":"https://api.github.com/users/thatch45/orgs","repos_url":"https://api.github.com/users/thatch45/repos","events_url":"https://api.github.com/users/thatch45/events{/privacy}","received_events_url":"https://api.github.com/users/thatch45/received_events","type":"User","site_admin":false},"open_issues":2723,"closed_issues":2927,"state":"open","created_at":"2011-05-14T04:00:56Z","updated_at":"2015-11-17T18:16:38Z","due_on":null,"closed_at":null},"comments":2,"created_at":"2015-11-16T02:35:37Z","updated_at":"2015-11-17T18:16:37Z","closed_at":null,"body":"using the git fileserver repo, if your repo has branches `master` and `develop`, and tag `1.0`; then they will all be listed as available environments via `salt-run fileserver.envs`:\r\n\r\n    # salt-run fileserver.envs\r\n    - develop\r\n    - base\r\n    - 1.0\r\n\r\nhowever, passing in the numeric tag to set the environment for a command causes an exception, because it's being read in as a float:\r\n\r\n    # salt-run fileserver.file_list saltenv=1.0\r\n      Exception occurred in runner fileserver.file_list: Traceback (most recent call last):\r\n        File \"/usr/lib/python2.7/dist-packages/salt/client/mixins.py\", line 337, in low\r\n          data['return'] = self.functions[fun](*args, **kwargs)\r\n        File \"/usr/lib/python2.7/dist-packages/salt/runners/fileserver.py\", line 83, in file_list\r\n          output = fileserver.file_list(load=load)\r\n        File \"/usr/lib/python2.7/dist-packages/salt/fileserver/__init__.py\", line 555, in file_list\r\n          ret.update(self.servers[fstr](load))\r\n        File \"/usr/lib/python2.7/dist-packages/salt/fileserver/gitfs.py\", line 180, in file_list\r\n          return gitfs.file_list(load)\r\n        File \"/usr/lib/python2.7/dist-packages/salt/utils/gitfs.py\", line 2255, in file_list\r\n          return self._file_lists(load, 'files')\r\n        File \"/usr/lib/python2.7/dist-packages/salt/utils/gitfs.py\", line 2216, in _file_lists\r\n          '{0}.p'.format(load['saltenv'].replace(os.path.sep, '_|-'))\r\n      AttributeError: 'float' object has no attribute 'replace'\r\n"},"comment":{"url":"https://api.github.com/repos/saltstack/salt/issues/comments/157457856","html_url":"https://github.com/saltstack/salt/issues/28911#issuecomment-157457856","issue_url":"https://api.github.com/repos/saltstack/salt/issues/28911","id":157457856,"user":{"login":"terminalmage","id":328598,"avatar_url":"https://avatars.githubusercontent.com/u/328598?v=3","gravatar_id":"","url":"https://api.github.com/users/terminalmage","html_url":"https://github.com/terminalmage","followers_url":"https://api.github.com/users/terminalmage/followers","following_url":"https://api.github.com/users/terminalmage/following{/other_user}","gists_url":"https://api.github.com/users/terminalmage/gists{/gist_id}","starred_url":"https://api.github.com/users/terminalmage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terminalmage/subscriptions","organizations_url":"https://api.github.com/users/terminalmage/orgs","repos_url":"https://api.github.com/users/terminalmage/repos","events_url":"https://api.github.com/users/terminalmage/events{/privacy}","received_events_url":"https://api.github.com/users/terminalmage/received_events","type":"User","site_admin":false},"created_at":"2015-11-17T18:16:37Z","updated_at":"2015-11-17T18:16:37Z","body":"@ccmills This looks like it just affects the fileserver runner, have you reproduced this with a file state, or with ``salt minionid cp.list_master``?"}}