{"action":"opened","issue":{"url":"https://api.github.com/repos/prometheus/node_exporter/issues/112","labels_url":"https://api.github.com/repos/prometheus/node_exporter/issues/112/labels{/name}","comments_url":"https://api.github.com/repos/prometheus/node_exporter/issues/112/comments","events_url":"https://api.github.com/repos/prometheus/node_exporter/issues/112/events","html_url":"https://github.com/prometheus/node_exporter/issues/112","id":105669325,"number":112,"title":"Test Cases on OSX will always pass when test case should fail","user":{"login":"chosenken","id":91260,"avatar_url":"https://avatars.githubusercontent.com/u/91260?v=3","gravatar_id":"","url":"https://api.github.com/users/chosenken","html_url":"https://github.com/chosenken","followers_url":"https://api.github.com/users/chosenken/followers","following_url":"https://api.github.com/users/chosenken/following{/other_user}","gists_url":"https://api.github.com/users/chosenken/gists{/gist_id}","starred_url":"https://api.github.com/users/chosenken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chosenken/subscriptions","organizations_url":"https://api.github.com/users/chosenken/orgs","repos_url":"https://api.github.com/users/chosenken/repos","events_url":"https://api.github.com/users/chosenken/events{/privacy}","received_events_url":"https://api.github.com/users/chosenken/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2015-09-09T19:36:08Z","updated_at":"2015-09-09T19:36:08Z","closed_at":null,"body":"When ever I run `make test` on node_exporter on OSX, the test cases will always pass, even if I purposely break a test case.\r\n\r\n### Example ###\r\n```\r\n$ cd /tmp\r\n$ git clone https://github.com/prometheus/node_exporter.git\r\n$ cd node_exporter\r\n```\r\nChange the test case loadavg_linux_test.go from 0.21 to 0.25\r\n```go\r\nfunc TestLoad(t *testing.T) {\r\n\tload, err := parseLoad(\"0.21 0.37 0.39 1/719 19737\")\r\n\tif err != nil {\r\n\t\tt.Fatal(err)\r\n\t}\r\n\tif want := 0.25; want != load {\r\n\t\tt.Fatalf(\"want load %f, got %f\", want, load)\r\n\t}\r\n}\r\n```\r\nRun the test cases using make:\r\n```\r\n$ make test\r\nmkdir -p /private/tmp/node_exporter/.build/gopath/src/github.com/prometheus/\r\nln -s /private/tmp/node_exporter /private/tmp/node_exporter/.build/gopath/src/github.com/prometheus/node_exporter\r\nGOPATH=/private/tmp/node_exporter/.build/gopath /usr/local/go/bin/go get -d\r\ntouch dependencies-stamp\r\nGOPATH=/private/tmp/node_exporter/.build/gopath /usr/local/go/bin/go test ./...\r\n?   \t_/tmp/node_exporter\t[no test files]\r\nok  \t_/tmp/node_exporter/collector\t0.082s\r\n?   \t_/tmp/node_exporter/collector/ganglia\t[no test files]\r\n```\r\n\r\n### My System Settings ###\r\n```\r\n$ which go\r\n/usr/local/go/bin/go\r\n\r\n$ go version\r\ngo version go1.4.2 darwin/amd64\r\n\r\n$ uname -a\r\nDarwin XXX.local 14.5.0 Darwin Kernel Version 14.5.0: Wed Jul 29 02:26:53 PDT 2015; root:xnu-2782.40.9~1/RELEASE_X86_64 x86_64\r\n```"}}