{"action":"created","issue":{"url":"https://api.github.com/repos/chevah/chevah-keycert/issues/10","labels_url":"https://api.github.com/repos/chevah/chevah-keycert/issues/10/labels{/name}","comments_url":"https://api.github.com/repos/chevah/chevah-keycert/issues/10/comments","events_url":"https://api.github.com/repos/chevah/chevah-keycert/issues/10/events","html_url":"https://github.com/chevah/chevah-keycert/pull/10","id":66123552,"number":10,"title":"Create a SSL CSR","user":{"login":"adiroiban","id":204609,"avatar_url":"https://avatars.githubusercontent.com/u/204609?v=3","gravatar_id":"","url":"https://api.github.com/users/adiroiban","html_url":"https://github.com/adiroiban","followers_url":"https://api.github.com/users/adiroiban/followers","following_url":"https://api.github.com/users/adiroiban/following{/other_user}","gists_url":"https://api.github.com/users/adiroiban/gists{/gist_id}","starred_url":"https://api.github.com/users/adiroiban/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adiroiban/subscriptions","organizations_url":"https://api.github.com/users/adiroiban/orgs","repos_url":"https://api.github.com/users/adiroiban/repos","events_url":"https://api.github.com/users/adiroiban/events{/privacy}","received_events_url":"https://api.github.com/users/adiroiban/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/chevah/chevah-keycert/labels/reviewer-alibotean","name":"reviewer-alibotean","color":"eb6420"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-04-03T10:38:41Z","updated_at":"2015-04-07T10:17:47Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/chevah/chevah-keycert/pulls/10","html_url":"https://github.com/chevah/chevah-keycert/pull/10","diff_url":"https://github.com/chevah/chevah-keycert/pull/10.diff","patch_url":"https://github.com/chevah/chevah-keycert/pull/10.patch"},"body":"Problem\r\n======\r\n\r\nWe want to create CSR + key from command line but also from Python API\r\n\r\nChanges\r\n=======\r\n\r\nCreated 3 new methods. one to generate the commnad line options, another one to to generate the key/csr and another one to take care of writing to disk.\r\n\r\n\r\nAs a drive by I have updated the test runner to print speed reports and wrote a test for self signed certificate so that we have 100% coverage for ssl module.\r\n\r\nHow to test\r\n========\r\n\r\nreviewers: @alibotean \r\n\r\ncheck that changes make sense\r\n\r\nUse the demo tool to generate a csr"},"comment":{"url":"https://api.github.com/repos/chevah/chevah-keycert/issues/comments/90496665","html_url":"https://github.com/chevah/chevah-keycert/pull/10#issuecomment-90496665","issue_url":"https://api.github.com/repos/chevah/chevah-keycert/issues/10","id":90496665,"user":{"login":"alibotean","id":465539,"avatar_url":"https://avatars.githubusercontent.com/u/465539?v=3","gravatar_id":"","url":"https://api.github.com/users/alibotean","html_url":"https://github.com/alibotean","followers_url":"https://api.github.com/users/alibotean/followers","following_url":"https://api.github.com/users/alibotean/following{/other_user}","gists_url":"https://api.github.com/users/alibotean/gists{/gist_id}","starred_url":"https://api.github.com/users/alibotean/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alibotean/subscriptions","organizations_url":"https://api.github.com/users/alibotean/orgs","repos_url":"https://api.github.com/users/alibotean/repos","events_url":"https://api.github.com/users/alibotean/events{/privacy}","received_events_url":"https://api.github.com/users/alibotean/received_events","type":"User","site_admin":false},"created_at":"2015-04-07T10:17:47Z","updated_at":"2015-04-07T10:17:47Z","body":"Just some minor comments.\r\n\r\nchanges-approved"}}