{"action":"created","comment":{"url":"https://api.github.com/repos/idaholab/moose/pulls/comments/27836736","id":27836736,"diff_hunk":"@@ -510,44 +510,40 @@ NonlinearSystem::addScalarKernel(const  std::string & kernel_name, const std::st\n void\n NonlinearSystem::addBoundaryCondition(const std::string & bc_name, const std::string & name, InputParameters parameters)\n {\n-  std::vector<BoundaryName> boundaries = parameters.get<std::vector<BoundaryName> >(\"boundary\");\n+  // Create a set of boundary ids\n+  std::set<BoundaryID> boundary_ids;\n+  const std::vector<BoundaryName> & boundary_names = parameters.get<std::vector<BoundaryName> >(\"boundary\");\n+  for (std::vector<BoundaryName>::const_iterator it = boundary_names.begin(); it != boundary_names.end(); ++it)\n+    boundary_ids.insert(_mesh.getBoundaryID(*it));","path":"framework/src/base/NonlinearSystem.C","position":9,"original_position":9,"commit_id":"13e126848f66473ceb8f5c94c50d32fe7e851ef5","original_commit_id":"13e126848f66473ceb8f5c94c50d32fe7e851ef5","user":{"login":"aeslaughter","id":341333,"avatar_url":"https://avatars.githubusercontent.com/u/341333?v=3","gravatar_id":"","url":"https://api.github.com/users/aeslaughter","html_url":"https://github.com/aeslaughter","followers_url":"https://api.github.com/users/aeslaughter/followers","following_url":"https://api.github.com/users/aeslaughter/following{/other_user}","gists_url":"https://api.github.com/users/aeslaughter/gists{/gist_id}","starred_url":"https://api.github.com/users/aeslaughter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aeslaughter/subscriptions","organizations_url":"https://api.github.com/users/aeslaughter/orgs","repos_url":"https://api.github.com/users/aeslaughter/repos","events_url":"https://api.github.com/users/aeslaughter/events{/privacy}","received_events_url":"https://api.github.com/users/aeslaughter/received_events","type":"User","site_admin":false},"body":"Yes, but we are given names and we need the IDs, 517 calls getBoundaryID.","created_at":"2015-04-06T22:26:21Z","updated_at":"2015-04-06T22:26:21Z","html_url":"https://github.com/idaholab/moose/pull/4889#discussion_r27836736","pull_request_url":"https://api.github.com/repos/idaholab/moose/pulls/4889","_links":{"self":{"href":"https://api.github.com/repos/idaholab/moose/pulls/comments/27836736"},"html":{"href":"https://github.com/idaholab/moose/pull/4889#discussion_r27836736"},"pull_request":{"href":"https://api.github.com/repos/idaholab/moose/pulls/4889"}}},"pull_request":{"url":"https://api.github.com/repos/idaholab/moose/pulls/4889","id":32707326,"html_url":"https://github.com/idaholab/moose/pull/4889","diff_url":"https://github.com/idaholab/moose/pull/4889.diff","patch_url":"https://github.com/idaholab/moose/pull/4889.patch","issue_url":"https://api.github.com/repos/idaholab/moose/issues/4889","number":4889,"state":"open","locked":false,"title":"Only create a single BoundaryCondition object per id","user":{"login":"aeslaughter","id":341333,"avatar_url":"https://avatars.githubusercontent.com/u/341333?v=3","gravatar_id":"","url":"https://api.github.com/users/aeslaughter","html_url":"https://github.com/aeslaughter","followers_url":"https://api.github.com/users/aeslaughter/followers","following_url":"https://api.github.com/users/aeslaughter/following{/other_user}","gists_url":"https://api.github.com/users/aeslaughter/gists{/gist_id}","starred_url":"https://api.github.com/users/aeslaughter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aeslaughter/subscriptions","organizations_url":"https://api.github.com/users/aeslaughter/orgs","repos_url":"https://api.github.com/users/aeslaughter/repos","events_url":"https://api.github.com/users/aeslaughter/events{/privacy}","received_events_url":"https://api.github.com/users/aeslaughter/received_events","type":"User","site_admin":false},"body":"(refs #1022)","created_at":"2015-04-06T20:18:32Z","updated_at":"2015-04-06T22:26:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"16a8e8cd7331ce27c0def312373118d96527ef32","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/idaholab/moose/pulls/4889/commits","review_comments_url":"https://api.github.com/repos/idaholab/moose/pulls/4889/comments","review_comment_url":"https://api.github.com/repos/idaholab/moose/pulls/comments{/number}","comments_url":"https://api.github.com/repos/idaholab/moose/issues/4889/comments","statuses_url":"https://api.github.com/repos/idaholab/moose/statuses/13e126848f66473ceb8f5c94c50d32fe7e851ef5","head":{"label":"aeslaughter:bcs-1022","ref":"bcs-1022","sha":"13e126848f66473ceb8f5c94c50d32fe7e851ef5","user":{"login":"aeslaughter","id":341333,"avatar_url":"https://avatars.githubusercontent.com/u/341333?v=3","gravatar_id":"","url":"https://api.github.com/users/aeslaughter","html_url":"https://github.com/aeslaughter","followers_url":"https://api.github.com/users/aeslaughter/followers","following_url":"https://api.github.com/users/aeslaughter/following{/other_user}","gists_url":"https://api.github.com/users/aeslaughter/gists{/gist_id}","starred_url":"https://api.github.com/users/aeslaughter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aeslaughter/subscriptions","organizations_url":"https://api.github.com/users/aeslaughter/orgs","repos_url":"https://api.github.com/users/aeslaughter/repos","events_url":"https://api.github.com/users/aeslaughter/events{/privacy}","received_events_url":"https://api.github.com/users/aeslaughter/received_events","type":"User","site_admin":false},"repo":{"id":17844840,"name":"moose","full_name":"aeslaughter/moose","owner":{"login":"aeslaughter","id":341333,"avatar_url":"https://avatars.githubusercontent.com/u/341333?v=3","gravatar_id":"","url":"https://api.github.com/users/aeslaughter","html_url":"https://github.com/aeslaughter","followers_url":"https://api.github.com/users/aeslaughter/followers","following_url":"https://api.github.com/users/aeslaughter/following{/other_user}","gists_url":"https://api.github.com/users/aeslaughter/gists{/gist_id}","starred_url":"https://api.github.com/users/aeslaughter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aeslaughter/subscriptions","organizations_url":"https://api.github.com/users/aeslaughter/orgs","repos_url":"https://api.github.com/users/aeslaughter/repos","events_url":"https://api.github.com/users/aeslaughter/events{/privacy}","received_events_url":"https://api.github.com/users/aeslaughter/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aeslaughter/moose","description":"Multiphysics Object Oriented Simulation Environment","fork":true,"url":"https://api.github.com/repos/aeslaughter/moose","forks_url":"https://api.github.com/repos/aeslaughter/moose/forks","keys_url":"https://api.github.com/repos/aeslaughter/moose/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aeslaughter/moose/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aeslaughter/moose/teams","hooks_url":"https://api.github.com/repos/aeslaughter/moose/hooks","issue_events_url":"https://api.github.com/repos/aeslaughter/moose/issues/events{/number}","events_url":"https://api.github.com/repos/aeslaughter/moose/events","assignees_url":"https://api.github.com/repos/aeslaughter/moose/assignees{/user}","branches_url":"https://api.github.com/repos/aeslaughter/moose/branches{/branch}","tags_url":"https://api.github.com/repos/aeslaughter/moose/tags","blobs_url":"https://api.github.com/repos/aeslaughter/moose/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aeslaughter/moose/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aeslaughter/moose/git/refs{/sha}","trees_url":"https://api.github.com/repos/aeslaughter/moose/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aeslaughter/moose/statuses/{sha}","languages_url":"https://api.github.com/repos/aeslaughter/moose/languages","stargazers_url":"https://api.github.com/repos/aeslaughter/moose/stargazers","contributors_url":"https://api.github.com/repos/aeslaughter/moose/contributors","subscribers_url":"https://api.github.com/repos/aeslaughter/moose/subscribers","subscription_url":"https://api.github.com/repos/aeslaughter/moose/subscription","commits_url":"https://api.github.com/repos/aeslaughter/moose/commits{/sha}","git_commits_url":"https://api.github.com/repos/aeslaughter/moose/git/commits{/sha}","comments_url":"https://api.github.com/repos/aeslaughter/moose/comments{/number}","issue_comment_url":"https://api.github.com/repos/aeslaughter/moose/issues/comments{/number}","contents_url":"https://api.github.com/repos/aeslaughter/moose/contents/{+path}","compare_url":"https://api.github.com/repos/aeslaughter/moose/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aeslaughter/moose/merges","archive_url":"https://api.github.com/repos/aeslaughter/moose/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aeslaughter/moose/downloads","issues_url":"https://api.github.com/repos/aeslaughter/moose/issues{/number}","pulls_url":"https://api.github.com/repos/aeslaughter/moose/pulls{/number}","milestones_url":"https://api.github.com/repos/aeslaughter/moose/milestones{/number}","notifications_url":"https://api.github.com/repos/aeslaughter/moose/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aeslaughter/moose/labels{/name}","releases_url":"https://api.github.com/repos/aeslaughter/moose/releases{/id}","created_at":"2014-03-17T21:59:32Z","updated_at":"2015-04-06T19:17:40Z","pushed_at":"2015-04-06T22:13:27Z","git_url":"git://github.com/aeslaughter/moose.git","ssh_url":"git@github.com:aeslaughter/moose.git","clone_url":"https://github.com/aeslaughter/moose.git","svn_url":"https://github.com/aeslaughter/moose","homepage":null,"size":104198,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"devel"}},"base":{"label":"idaholab:devel","ref":"devel","sha":"a81e80c9bdc8819c2694e33c930b79e5edbce7a8","user":{"login":"idaholab","id":3855370,"avatar_url":"https://avatars.githubusercontent.com/u/3855370?v=3","gravatar_id":"","url":"https://api.github.com/users/idaholab","html_url":"https://github.com/idaholab","followers_url":"https://api.github.com/users/idaholab/followers","following_url":"https://api.github.com/users/idaholab/following{/other_user}","gists_url":"https://api.github.com/users/idaholab/gists{/gist_id}","starred_url":"https://api.github.com/users/idaholab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/idaholab/subscriptions","organizations_url":"https://api.github.com/users/idaholab/orgs","repos_url":"https://api.github.com/users/idaholab/repos","events_url":"https://api.github.com/users/idaholab/events{/privacy}","received_events_url":"https://api.github.com/users/idaholab/received_events","type":"Organization","site_admin":false},"repo":{"id":16851223,"name":"moose","full_name":"idaholab/moose","owner":{"login":"idaholab","id":3855370,"avatar_url":"https://avatars.githubusercontent.com/u/3855370?v=3","gravatar_id":"","url":"https://api.github.com/users/idaholab","html_url":"https://github.com/idaholab","followers_url":"https://api.github.com/users/idaholab/followers","following_url":"https://api.github.com/users/idaholab/following{/other_user}","gists_url":"https://api.github.com/users/idaholab/gists{/gist_id}","starred_url":"https://api.github.com/users/idaholab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/idaholab/subscriptions","organizations_url":"https://api.github.com/users/idaholab/orgs","repos_url":"https://api.github.com/users/idaholab/repos","events_url":"https://api.github.com/users/idaholab/events{/privacy}","received_events_url":"https://api.github.com/users/idaholab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/idaholab/moose","description":"Multiphysics Object Oriented Simulation Environment","fork":false,"url":"https://api.github.com/repos/idaholab/moose","forks_url":"https://api.github.com/repos/idaholab/moose/forks","keys_url":"https://api.github.com/repos/idaholab/moose/keys{/key_id}","collaborators_url":"https://api.github.com/repos/idaholab/moose/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/idaholab/moose/teams","hooks_url":"https://api.github.com/repos/idaholab/moose/hooks","issue_events_url":"https://api.github.com/repos/idaholab/moose/issues/events{/number}","events_url":"https://api.github.com/repos/idaholab/moose/events","assignees_url":"https://api.github.com/repos/idaholab/moose/assignees{/user}","branches_url":"https://api.github.com/repos/idaholab/moose/branches{/branch}","tags_url":"https://api.github.com/repos/idaholab/moose/tags","blobs_url":"https://api.github.com/repos/idaholab/moose/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/idaholab/moose/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/idaholab/moose/git/refs{/sha}","trees_url":"https://api.github.com/repos/idaholab/moose/git/trees{/sha}","statuses_url":"https://api.github.com/repos/idaholab/moose/statuses/{sha}","languages_url":"https://api.github.com/repos/idaholab/moose/languages","stargazers_url":"https://api.github.com/repos/idaholab/moose/stargazers","contributors_url":"https://api.github.com/repos/idaholab/moose/contributors","subscribers_url":"https://api.github.com/repos/idaholab/moose/subscribers","subscription_url":"https://api.github.com/repos/idaholab/moose/subscription","commits_url":"https://api.github.com/repos/idaholab/moose/commits{/sha}","git_commits_url":"https://api.github.com/repos/idaholab/moose/git/commits{/sha}","comments_url":"https://api.github.com/repos/idaholab/moose/comments{/number}","issue_comment_url":"https://api.github.com/repos/idaholab/moose/issues/comments{/number}","contents_url":"https://api.github.com/repos/idaholab/moose/contents/{+path}","compare_url":"https://api.github.com/repos/idaholab/moose/compare/{base}...{head}","merges_url":"https://api.github.com/repos/idaholab/moose/merges","archive_url":"https://api.github.com/repos/idaholab/moose/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/idaholab/moose/downloads","issues_url":"https://api.github.com/repos/idaholab/moose/issues{/number}","pulls_url":"https://api.github.com/repos/idaholab/moose/pulls{/number}","milestones_url":"https://api.github.com/repos/idaholab/moose/milestones{/number}","notifications_url":"https://api.github.com/repos/idaholab/moose/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/idaholab/moose/labels{/name}","releases_url":"https://api.github.com/repos/idaholab/moose/releases{/id}","created_at":"2014-02-14T22:26:15Z","updated_at":"2015-04-06T22:09:27Z","pushed_at":"2015-04-06T22:09:27Z","git_url":"git://github.com/idaholab/moose.git","ssh_url":"git@github.com:idaholab/moose.git","clone_url":"https://github.com/idaholab/moose.git","svn_url":"https://github.com/idaholab/moose","homepage":"http://www.mooseframework.org","size":117616,"stargazers_count":78,"watchers_count":78,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":123,"mirror_url":null,"open_issues_count":435,"forks":123,"open_issues":435,"watchers":78,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/idaholab/moose/pulls/4889"},"html":{"href":"https://github.com/idaholab/moose/pull/4889"},"issue":{"href":"https://api.github.com/repos/idaholab/moose/issues/4889"},"comments":{"href":"https://api.github.com/repos/idaholab/moose/issues/4889/comments"},"review_comments":{"href":"https://api.github.com/repos/idaholab/moose/pulls/4889/comments"},"review_comment":{"href":"https://api.github.com/repos/idaholab/moose/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/idaholab/moose/pulls/4889/commits"},"statuses":{"href":"https://api.github.com/repos/idaholab/moose/statuses/13e126848f66473ceb8f5c94c50d32fe7e851ef5"}}}}