{"action":"created","issue":{"url":"https://api.github.com/repos/4finance/uptodate-gradle-plugin/issues/23","labels_url":"https://api.github.com/repos/4finance/uptodate-gradle-plugin/issues/23/labels{/name}","comments_url":"https://api.github.com/repos/4finance/uptodate-gradle-plugin/issues/23/comments","events_url":"https://api.github.com/repos/4finance/uptodate-gradle-plugin/issues/23/events","html_url":"https://github.com/4finance/uptodate-gradle-plugin/pull/23","id":59340155,"number":23,"title":"[#21] Reduce code duplication","user":{"login":"cbuleandra","id":8832176,"avatar_url":"https://avatars.githubusercontent.com/u/8832176?v=3","gravatar_id":"","url":"https://api.github.com/users/cbuleandra","html_url":"https://github.com/cbuleandra","followers_url":"https://api.github.com/users/cbuleandra/followers","following_url":"https://api.github.com/users/cbuleandra/following{/other_user}","gists_url":"https://api.github.com/users/cbuleandra/gists{/gist_id}","starred_url":"https://api.github.com/users/cbuleandra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbuleandra/subscriptions","organizations_url":"https://api.github.com/users/cbuleandra/orgs","repos_url":"https://api.github.com/users/cbuleandra/repos","events_url":"https://api.github.com/users/cbuleandra/events{/privacy}","received_events_url":"https://api.github.com/users/cbuleandra/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-02-28T12:31:26Z","updated_at":"2015-03-01T15:23:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/4finance/uptodate-gradle-plugin/pulls/23","html_url":"https://github.com/4finance/uptodate-gradle-plugin/pull/23","diff_url":"https://github.com/4finance/uptodate-gradle-plugin/pull/23.diff","patch_url":"https://github.com/4finance/uptodate-gradle-plugin/pull/23.patch"},"body":"Hi guys, can you please have a look and share your thoughts on my attempt of reducing the code duplication?"},"comment":{"url":"https://api.github.com/repos/4finance/uptodate-gradle-plugin/issues/comments/76601251","html_url":"https://github.com/4finance/uptodate-gradle-plugin/pull/23#issuecomment-76601251","issue_url":"https://api.github.com/repos/4finance/uptodate-gradle-plugin/issues/23","id":76601251,"user":{"login":"marcingrzejszczak","id":3297437,"avatar_url":"https://avatars.githubusercontent.com/u/3297437?v=3","gravatar_id":"","url":"https://api.github.com/users/marcingrzejszczak","html_url":"https://github.com/marcingrzejszczak","followers_url":"https://api.github.com/users/marcingrzejszczak/followers","following_url":"https://api.github.com/users/marcingrzejszczak/following{/other_user}","gists_url":"https://api.github.com/users/marcingrzejszczak/gists{/gist_id}","starred_url":"https://api.github.com/users/marcingrzejszczak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcingrzejszczak/subscriptions","organizations_url":"https://api.github.com/users/marcingrzejszczak/orgs","repos_url":"https://api.github.com/users/marcingrzejszczak/repos","events_url":"https://api.github.com/users/marcingrzejszczak/events{/privacy}","received_events_url":"https://api.github.com/users/marcingrzejszczak/received_events","type":"User","site_admin":false},"created_at":"2015-03-01T15:23:20Z","updated_at":"2015-03-01T15:23:20Z","body":"We're almost there ;)\r\n\r\ncom.ofg.uptodate.http.WireMockSpec - should be abstract\r\nThe if/else can be simplified to an OR statment can it? com/ofg/uptodate/finder/NewVersionFinder.groovy:25\r\nThis is bullshit but could you please format this propelry com/ofg/uptodate/UptodatePlugin.groovy:37 :P I mean like without those new lines in the beggining and end of the array\r\n```\r\n([MavenNewVersionFinderFactory(loggerProxy).build(uptodatePluginExtension),\r\nnew JCenterNewVersionFinderFactory(loggerProxy).build(uptodatePluginExtension)])\r\n```\r\n\r\n@cbuleandra I really like your changes! @kamilszymanski can you take a look at this too since you were also commiting to uptodate and you know the idea behind it?"}}