{"action":"created","issue":{"url":"https://api.github.com/repos/svaarala/duktape/issues/483","labels_url":"https://api.github.com/repos/svaarala/duktape/issues/483/labels{/name}","comments_url":"https://api.github.com/repos/svaarala/duktape/issues/483/comments","events_url":"https://api.github.com/repos/svaarala/duktape/issues/483/events","html_url":"https://github.com/svaarala/duktape/pull/483","id":120893495,"number":483,"title":"Accept buffer objects as duk_push_buffer_object() base values","user":{"login":"svaarala","id":6377415,"avatar_url":"https://avatars.githubusercontent.com/u/6377415?v=3","gravatar_id":"","url":"https://api.github.com/users/svaarala","html_url":"https://github.com/svaarala","followers_url":"https://api.github.com/users/svaarala/followers","following_url":"https://api.github.com/users/svaarala/following{/other_user}","gists_url":"https://api.github.com/users/svaarala/gists{/gist_id}","starred_url":"https://api.github.com/users/svaarala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/svaarala/subscriptions","organizations_url":"https://api.github.com/users/svaarala/orgs","repos_url":"https://api.github.com/users/svaarala/repos","events_url":"https://api.github.com/users/svaarala/events{/privacy}","received_events_url":"https://api.github.com/users/svaarala/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/svaarala/duktape/labels/api","name":"api","color":"bfd4f2"},{"url":"https://api.github.com/repos/svaarala/duktape/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/svaarala/duktape/milestones/13","html_url":"https://github.com/svaarala/duktape/milestones/v1.4.0","labels_url":"https://api.github.com/repos/svaarala/duktape/milestones/13/labels","id":1225990,"number":13,"title":"v1.4.0","description":"Performance improvements, error verbosity, debugger improvements","creator":{"login":"svaarala","id":6377415,"avatar_url":"https://avatars.githubusercontent.com/u/6377415?v=3","gravatar_id":"","url":"https://api.github.com/users/svaarala","html_url":"https://github.com/svaarala","followers_url":"https://api.github.com/users/svaarala/followers","following_url":"https://api.github.com/users/svaarala/following{/other_user}","gists_url":"https://api.github.com/users/svaarala/gists{/gist_id}","starred_url":"https://api.github.com/users/svaarala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/svaarala/subscriptions","organizations_url":"https://api.github.com/users/svaarala/orgs","repos_url":"https://api.github.com/users/svaarala/repos","events_url":"https://api.github.com/users/svaarala/events{/privacy}","received_events_url":"https://api.github.com/users/svaarala/received_events","type":"User","site_admin":false},"open_issues":14,"closed_issues":102,"state":"open","created_at":"2015-07-26T04:06:08Z","updated_at":"2015-12-11T10:27:37Z","due_on":null,"closed_at":null},"comments":14,"created_at":"2015-12-07T23:26:06Z","updated_at":"2015-12-11T18:30:17Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/svaarala/duktape/pulls/483","html_url":"https://github.com/svaarala/duktape/pull/483","diff_url":"https://github.com/svaarala/duktape/pull/483.diff","patch_url":"https://github.com/svaarala/duktape/pull/483.patch"},"body":"- [ ] Accept any buffer object as a duk_push_buffer_object() base value; new buffer object will a previous offset into account so that it effectively creates a slice against the existing buffer object.\r\n- [ ] When creating typed arrays and the base value is `ArrayBuffer`, should the result `.buffer` be the argument ArrayBuffer, or a fresh ArrayBuffer with the same backing buffer? In other words, should ArrayBuffer be the only special argument which doesn't trigger creation of a fresh ArrayBuffer?\r\n- [ ] Behavior for plain buffer arguments: as is\r\n- [ ] Behavior for ArrayBuffer arguments\r\n- [ ] Behavior for Node.js Buffer and Duktape.Buffer arguments\r\n- [ ] Behavior for typed array arguments\r\n- [ ] Behavior for DataView arguments\r\n- [ ] Behavior of offset clamping when the argument is a slice: should original slight length be respected (clamped or otherwise)?\r\n- [ ] API testcase updates: basic cases\r\n- [ ] API testcase updates: range/wrap checks\r\n- [ ] Website update\r\n- [ ] Internal document update\r\n- [ ] Wiki update\r\n- [ ] Releases"},"comment":{"url":"https://api.github.com/repos/svaarala/duktape/issues/comments/164010666","html_url":"https://github.com/svaarala/duktape/pull/483#issuecomment-164010666","issue_url":"https://api.github.com/repos/svaarala/duktape/issues/483","id":164010666,"user":{"login":"fatcerberus","id":4097841,"avatar_url":"https://avatars.githubusercontent.com/u/4097841?v=3","gravatar_id":"","url":"https://api.github.com/users/fatcerberus","html_url":"https://github.com/fatcerberus","followers_url":"https://api.github.com/users/fatcerberus/followers","following_url":"https://api.github.com/users/fatcerberus/following{/other_user}","gists_url":"https://api.github.com/users/fatcerberus/gists{/gist_id}","starred_url":"https://api.github.com/users/fatcerberus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fatcerberus/subscriptions","organizations_url":"https://api.github.com/users/fatcerberus/orgs","repos_url":"https://api.github.com/users/fatcerberus/repos","events_url":"https://api.github.com/users/fatcerberus/events{/privacy}","received_events_url":"https://api.github.com/users/fatcerberus/received_events","type":"User","site_admin":false},"created_at":"2015-12-11T18:30:17Z","updated_at":"2015-12-11T18:30:17Z","body":"On the other hand, having taken a look at the specified behavior, it's not mandated that `.buffer` be a valid ArrayBuffer, just that it's \"the value of the [[ViewedArrayBuffer]] internal slot\".  So it seems entirely acceptable that a typed array originating in C code doesn't have a meaningful value for this."}}