{"action":"created","issue":{"url":"https://api.github.com/repos/rpless/cover-coveralls/issues/4","labels_url":"https://api.github.com/repos/rpless/cover-coveralls/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/rpless/cover-coveralls/issues/4/comments","events_url":"https://api.github.com/repos/rpless/cover-coveralls/issues/4/events","html_url":"https://github.com/rpless/cover-coveralls/issues/4","id":103958189,"number":4,"title":"Coverage submission failing counts as a test failure","user":{"login":"jackfirth","id":8175575,"avatar_url":"https://avatars.githubusercontent.com/u/8175575?v=3","gravatar_id":"","url":"https://api.github.com/users/jackfirth","html_url":"https://github.com/jackfirth","followers_url":"https://api.github.com/users/jackfirth/followers","following_url":"https://api.github.com/users/jackfirth/following{/other_user}","gists_url":"https://api.github.com/users/jackfirth/gists{/gist_id}","starred_url":"https://api.github.com/users/jackfirth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackfirth/subscriptions","organizations_url":"https://api.github.com/users/jackfirth/orgs","repos_url":"https://api.github.com/users/jackfirth/repos","events_url":"https://api.github.com/users/jackfirth/events{/privacy}","received_events_url":"https://api.github.com/users/jackfirth/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-08-30T22:19:33Z","updated_at":"2015-08-30T23:35:25Z","closed_at":null,"body":"With the current example Travis script, submitting test coverage counts as part of the testing commands. This means if the tests pass but coverage submission fails (for example due to network issues or Coveralls setup issues), the build fails with a test failure state.\r\n\r\nI think most would prefer if the coverage process was independent of the testing process, but submitted only when tests pass. This can be done in travis by moving the coverage command from the `script:` block to an `after_success:` block (see the [Travis Build Lifecycle docs](http://docs.travis-ci.com/user/customizing-the-build/#The-Build-Lifecycle) for details):\r\n\r\n```yml\r\nscript:\r\n - raco test $TRAVIS_BUILD_DIR # run tests. you wrote tests, right?\r\n\r\nafter_success:\r\n - raco cover -f coveralls -d $TRAVIS_BUILD_DIR/coverage . # generate coverage information for coveralls\r\n```\r\n\r\nSome people *want* coverage submission failing to fail the build, but I think most don't and thus this makes for a better default."},"comment":{"url":"https://api.github.com/repos/rpless/cover-coveralls/issues/comments/136217240","html_url":"https://github.com/rpless/cover-coveralls/issues/4#issuecomment-136217240","issue_url":"https://api.github.com/repos/rpless/cover-coveralls/issues/4","id":136217240,"user":{"login":"florence","id":1413610,"avatar_url":"https://avatars.githubusercontent.com/u/1413610?v=3","gravatar_id":"","url":"https://api.github.com/users/florence","html_url":"https://github.com/florence","followers_url":"https://api.github.com/users/florence/followers","following_url":"https://api.github.com/users/florence/following{/other_user}","gists_url":"https://api.github.com/users/florence/gists{/gist_id}","starred_url":"https://api.github.com/users/florence/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/florence/subscriptions","organizations_url":"https://api.github.com/users/florence/orgs","repos_url":"https://api.github.com/users/florence/repos","events_url":"https://api.github.com/users/florence/events{/privacy}","received_events_url":"https://api.github.com/users/florence/received_events","type":"User","site_admin":false},"created_at":"2015-08-30T23:35:25Z","updated_at":"2015-08-30T23:35:25Z","body":"@rpless seems reasonable. Do you agree?"}}