{"action":"created","issue":{"url":"https://api.github.com/repos/videojs/videojs-contrib-hls/issues/209","labels_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/issues/209/labels{/name}","comments_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/issues/209/comments","events_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/issues/209/events","html_url":"https://github.com/videojs/videojs-contrib-hls/issues/209","id":56835606,"number":209,"title":"Add support for MP3 audio","user":{"login":"rdgRmCore","id":1521834,"avatar_url":"https://avatars.githubusercontent.com/u/1521834?v=3","gravatar_id":"","url":"https://api.github.com/users/rdgRmCore","html_url":"https://github.com/rdgRmCore","followers_url":"https://api.github.com/users/rdgRmCore/followers","following_url":"https://api.github.com/users/rdgRmCore/following{/other_user}","gists_url":"https://api.github.com/users/rdgRmCore/gists{/gist_id}","starred_url":"https://api.github.com/users/rdgRmCore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdgRmCore/subscriptions","organizations_url":"https://api.github.com/users/rdgRmCore/orgs","repos_url":"https://api.github.com/users/rdgRmCore/repos","events_url":"https://api.github.com/users/rdgRmCore/events{/privacy}","received_events_url":"https://api.github.com/users/rdgRmCore/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/videojs/videojs-contrib-hls/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-02-06T16:44:11Z","updated_at":"2015-02-12T16:41:52Z","closed_at":null,"body":"There is a todo in the segment parser to add MP3 support. Can this be added?\r\n\r\nI can see that videojs can play back .mp4 files that have mp3 audio. So, it should be able to play back the transport streams that contain mp3 audio. \r\n\r\nI would like this support to be added.\r\nI have been reading through the code and it looks like what is needed is to add a window.videojs.Hls.Mp3Stream\r\nsimilar to what exists for AacStream. Or is there another approach that should be used?\r\nOne question I have is about the audiocodecid. In the aac-stream.js there is this line:\r\n\r\n          // AAC is always 10\r\n          aacFrame.writeMetaDataDouble(\"audiocodecid\", 10);\r\n\r\nWhat should the audiocodecid be set to for MP3 audio?"},"comment":{"url":"https://api.github.com/repos/videojs/videojs-contrib-hls/issues/comments/74104443","html_url":"https://github.com/videojs/videojs-contrib-hls/issues/209#issuecomment-74104443","issue_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/issues/209","id":74104443,"user":{"login":"rdgRmCore","id":1521834,"avatar_url":"https://avatars.githubusercontent.com/u/1521834?v=3","gravatar_id":"","url":"https://api.github.com/users/rdgRmCore","html_url":"https://github.com/rdgRmCore","followers_url":"https://api.github.com/users/rdgRmCore/followers","following_url":"https://api.github.com/users/rdgRmCore/following{/other_user}","gists_url":"https://api.github.com/users/rdgRmCore/gists{/gist_id}","starred_url":"https://api.github.com/users/rdgRmCore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdgRmCore/subscriptions","organizations_url":"https://api.github.com/users/rdgRmCore/orgs","repos_url":"https://api.github.com/users/rdgRmCore/repos","events_url":"https://api.github.com/users/rdgRmCore/events{/privacy}","received_events_url":"https://api.github.com/users/rdgRmCore/received_events","type":"User","site_admin":false},"created_at":"2015-02-12T16:41:52Z","updated_at":"2015-02-12T16:41:52Z","body":"@gkatsev \r\n\r\nI tried to create the pull request.\r\nThe Travis CI is failing.\r\nIt looks like some tests are failing on the new Mp3 class.\r\nI am not sure how to proceed.\r\nI am not sure what exactly is failing.\r\nI don't know how to run the tests locally."}}