{"action":"created","issue":{"url":"https://api.github.com/repos/IBM-IoT/node-red-contrib-timeseries/issues/1","labels_url":"https://api.github.com/repos/IBM-IoT/node-red-contrib-timeseries/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/IBM-IoT/node-red-contrib-timeseries/issues/1/comments","events_url":"https://api.github.com/repos/IBM-IoT/node-red-contrib-timeseries/issues/1/events","html_url":"https://github.com/IBM-IoT/node-red-contrib-timeseries/pull/1","id":96917491,"number":1,"title":"New timeseries node + fixes&updates","user":{"login":"cristian-t","id":8492948,"avatar_url":"https://avatars.githubusercontent.com/u/8492948?v=3","gravatar_id":"","url":"https://api.github.com/users/cristian-t","html_url":"https://github.com/cristian-t","followers_url":"https://api.github.com/users/cristian-t/followers","following_url":"https://api.github.com/users/cristian-t/following{/other_user}","gists_url":"https://api.github.com/users/cristian-t/gists{/gist_id}","starred_url":"https://api.github.com/users/cristian-t/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cristian-t/subscriptions","organizations_url":"https://api.github.com/users/cristian-t/orgs","repos_url":"https://api.github.com/users/cristian-t/repos","events_url":"https://api.github.com/users/cristian-t/events{/privacy}","received_events_url":"https://api.github.com/users/cristian-t/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-07-23T22:24:08Z","updated_at":"2015-07-29T20:12:18Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/IBM-IoT/node-red-contrib-timeseries/pulls/1","html_url":"https://github.com/IBM-IoT/node-red-contrib-timeseries/pull/1","diff_url":"https://github.com/IBM-IoT/node-red-contrib-timeseries/pull/1.diff","patch_url":"https://github.com/IBM-IoT/node-red-contrib-timeseries/pull/1.patch"},"body":"Added the simple timeseries query node.\r\nAdded a configurable ID to the aggregate timeseries in node.\r\nAdded missing dependency \"request\" to package.json"},"comment":{"url":"https://api.github.com/repos/IBM-IoT/node-red-contrib-timeseries/issues/comments/126082570","html_url":"https://github.com/IBM-IoT/node-red-contrib-timeseries/pull/1#issuecomment-126082570","issue_url":"https://api.github.com/repos/IBM-IoT/node-red-contrib-timeseries/issues/1","id":126082570,"user":{"login":"kennethmyers","id":601538,"avatar_url":"https://avatars.githubusercontent.com/u/601538?v=3","gravatar_id":"","url":"https://api.github.com/users/kennethmyers","html_url":"https://github.com/kennethmyers","followers_url":"https://api.github.com/users/kennethmyers/followers","following_url":"https://api.github.com/users/kennethmyers/following{/other_user}","gists_url":"https://api.github.com/users/kennethmyers/gists{/gist_id}","starred_url":"https://api.github.com/users/kennethmyers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kennethmyers/subscriptions","organizations_url":"https://api.github.com/users/kennethmyers/orgs","repos_url":"https://api.github.com/users/kennethmyers/repos","events_url":"https://api.github.com/users/kennethmyers/events{/privacy}","received_events_url":"https://api.github.com/users/kennethmyers/received_events","type":"User","site_admin":false},"created_at":"2015-07-29T20:12:18Z","updated_at":"2015-07-29T20:12:18Z","body":"First, sorry for the delay in reviewing this pull request. I try to complete them within 24 hours (or sooner) when possible.\r\n\r\nGood job limiting each commit to a single \"idea\". That makes it much easier to review.\r\n\r\nChanges I would like to see:\r\n\r\n1. On 9e05fb4 make sure this information is also added to the README.\r\nThe info panel is meant to be a subset of the README and any changes to the info panel should typically be reflected in the README (and vice versa). \r\n2. Modify the \"Name of Unique Key Field in Incoming JSON\" section of the README/Info tab to specify that this field will be providing the column name if the \"ID\" field is used. Consider changing the name of that field as well to better describe its new role.\r\n3. cce5489 Add documentation in the \"Info\" tab describing the purpose of the node and how to use. Following the format and style I used for my nodes. Put this info in the README as well and add some content to the README explaining the reasoning behind having the two nodes and when to use which one.\r\n\r\nI still need to run some more tests on these and dive into the code further so expect more comments. In the meantime you can add some more commits addressing the above items.\r\n\r\nOverall things look good! Nice work!\r\n"}}