{"action":"created","issue":{"url":"https://api.github.com/repos/apache/flink/issues/569","labels_url":"https://api.github.com/repos/apache/flink/issues/569/labels{/name}","comments_url":"https://api.github.com/repos/apache/flink/issues/569/comments","events_url":"https://api.github.com/repos/apache/flink/issues/569/events","html_url":"https://github.com/apache/flink/pull/569","id":66277111,"number":569,"title":"[FLINK-1826]Remove the redundant codes never be executed in function getNumPages","user":{"login":"matadorhong","id":4719277,"avatar_url":"https://avatars.githubusercontent.com/u/4719277?v=3","gravatar_id":"","url":"https://api.github.com/users/matadorhong","html_url":"https://github.com/matadorhong","followers_url":"https://api.github.com/users/matadorhong/followers","following_url":"https://api.github.com/users/matadorhong/following{/other_user}","gists_url":"https://api.github.com/users/matadorhong/gists{/gist_id}","starred_url":"https://api.github.com/users/matadorhong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matadorhong/subscriptions","organizations_url":"https://api.github.com/users/matadorhong/orgs","repos_url":"https://api.github.com/users/matadorhong/repos","events_url":"https://api.github.com/users/matadorhong/events{/privacy}","received_events_url":"https://api.github.com/users/matadorhong/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-04-04T05:04:39Z","updated_at":"2015-04-04T17:18:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/flink/pulls/569","html_url":"https://github.com/apache/flink/pull/569","diff_url":"https://github.com/apache/flink/pull/569.diff","patch_url":"https://github.com/apache/flink/pull/569.patch"},"body":"Remove the code never be executed in function getNumPages, because the input of numBytes has be validataion by its caller of DefaultMemoryManager(long memorySize, int numberOfSlots, int pageSize)."},"comment":{"url":"https://api.github.com/repos/apache/flink/issues/comments/89617988","html_url":"https://github.com/apache/flink/pull/569#issuecomment-89617988","issue_url":"https://api.github.com/repos/apache/flink/issues/569","id":89617988,"user":{"login":"mbalassi","id":5990983,"avatar_url":"https://avatars.githubusercontent.com/u/5990983?v=3","gravatar_id":"","url":"https://api.github.com/users/mbalassi","html_url":"https://github.com/mbalassi","followers_url":"https://api.github.com/users/mbalassi/followers","following_url":"https://api.github.com/users/mbalassi/following{/other_user}","gists_url":"https://api.github.com/users/mbalassi/gists{/gist_id}","starred_url":"https://api.github.com/users/mbalassi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbalassi/subscriptions","organizations_url":"https://api.github.com/users/mbalassi/orgs","repos_url":"https://api.github.com/users/mbalassi/repos","events_url":"https://api.github.com/users/mbalassi/events{/privacy}","received_events_url":"https://api.github.com/users/mbalassi/received_events","type":"User","site_admin":false},"created_at":"2015-04-04T17:18:00Z","updated_at":"2015-04-04T17:18:00Z","body":"Hey, I personally like that the check is performed there even though it is currently redundant. It is true that the `DefaultMemoryManager` is for internal usage, but I think it is generally better be safe than sorry with these checks."}}