{"action":"created","issue":{"url":"https://api.github.com/repos/whitlockjc/json-refs/issues/41","labels_url":"https://api.github.com/repos/whitlockjc/json-refs/issues/41/labels{/name}","comments_url":"https://api.github.com/repos/whitlockjc/json-refs/issues/41/comments","events_url":"https://api.github.com/repos/whitlockjc/json-refs/issues/41/events","html_url":"https://github.com/whitlockjc/json-refs/pull/41","id":116373285,"number":41,"title":"Issue 27 resolve specific refs","user":{"login":"HyperBrain","id":5524702,"avatar_url":"https://avatars.githubusercontent.com/u/5524702?v=3","gravatar_id":"","url":"https://api.github.com/users/HyperBrain","html_url":"https://github.com/HyperBrain","followers_url":"https://api.github.com/users/HyperBrain/followers","following_url":"https://api.github.com/users/HyperBrain/following{/other_user}","gists_url":"https://api.github.com/users/HyperBrain/gists{/gist_id}","starred_url":"https://api.github.com/users/HyperBrain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HyperBrain/subscriptions","organizations_url":"https://api.github.com/users/HyperBrain/orgs","repos_url":"https://api.github.com/users/HyperBrain/repos","events_url":"https://api.github.com/users/HyperBrain/events{/privacy}","received_events_url":"https://api.github.com/users/HyperBrain/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2015-11-11T16:42:43Z","updated_at":"2015-11-11T21:13:01Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/whitlockjc/json-refs/pulls/41","html_url":"https://github.com/whitlockjc/json-refs/pull/41","diff_url":"https://github.com/whitlockjc/json-refs/pull/41.diff","patch_url":"https://github.com/whitlockjc/json-refs/pull/41.patch"},"body":"Hi Jeremy,\r\nI solved issue-27: Selective enable/disable of dereferencing. With that change our Swagger AWS import successfully can create models now.\r\nI added 3 new boolean options for the resolveRefs function (all default to true so that existing configurations will behave as is):\r\n- resolveLocalRefs: false => Disables inlining of local references and keeps the $ref in there.\r\n- resolveFileRefs: false => Disables file references.\r\n- resolveRemoteRefs: false => Disables remote references.\r\nAdditionally I updates the unit tests to include wrong type checks for these.\r\nCould you please check if this would be fine for you to merge?\r\nThanks,\r\nFrank"},"comment":{"url":"https://api.github.com/repos/whitlockjc/json-refs/issues/comments/155912146","html_url":"https://github.com/whitlockjc/json-refs/pull/41#issuecomment-155912146","issue_url":"https://api.github.com/repos/whitlockjc/json-refs/issues/41","id":155912146,"user":{"login":"HyperBrain","id":5524702,"avatar_url":"https://avatars.githubusercontent.com/u/5524702?v=3","gravatar_id":"","url":"https://api.github.com/users/HyperBrain","html_url":"https://github.com/HyperBrain","followers_url":"https://api.github.com/users/HyperBrain/followers","following_url":"https://api.github.com/users/HyperBrain/following{/other_user}","gists_url":"https://api.github.com/users/HyperBrain/gists{/gist_id}","starred_url":"https://api.github.com/users/HyperBrain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HyperBrain/subscriptions","organizations_url":"https://api.github.com/users/HyperBrain/orgs","repos_url":"https://api.github.com/users/HyperBrain/repos","events_url":"https://api.github.com/users/HyperBrain/events{/privacy}","received_events_url":"https://api.github.com/users/HyperBrain/received_events","type":"User","site_admin":false},"created_at":"2015-11-11T21:13:01Z","updated_at":"2015-11-11T21:13:01Z","body":"you mean the isRemotePointer? That only checks for local (#) references but not explicitly for file references (like $ref: './a_file.json'). I needed to have files included, but url references not dereferenced. As they are only a subset of remote pointers the new function is an extension of the old one. "}}