{"action":"created","issue":{"url":"https://api.github.com/repos/rmarquis/pacaur/issues/315","labels_url":"https://api.github.com/repos/rmarquis/pacaur/issues/315/labels{/name}","comments_url":"https://api.github.com/repos/rmarquis/pacaur/issues/315/comments","events_url":"https://api.github.com/repos/rmarquis/pacaur/issues/315/events","html_url":"https://github.com/rmarquis/pacaur/issues/315","id":59347360,"number":315,"title":"Safer pacaur script (shellcheck analysis)","user":{"login":"Zopieux","id":81353,"avatar_url":"https://avatars.githubusercontent.com/u/81353?v=3","gravatar_id":"","url":"https://api.github.com/users/Zopieux","html_url":"https://github.com/Zopieux","followers_url":"https://api.github.com/users/Zopieux/followers","following_url":"https://api.github.com/users/Zopieux/following{/other_user}","gists_url":"https://api.github.com/users/Zopieux/gists{/gist_id}","starred_url":"https://api.github.com/users/Zopieux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zopieux/subscriptions","organizations_url":"https://api.github.com/users/Zopieux/orgs","repos_url":"https://api.github.com/users/Zopieux/repos","events_url":"https://api.github.com/users/Zopieux/events{/privacy}","received_events_url":"https://api.github.com/users/Zopieux/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/rmarquis/pacaur/labels/todo","name":"todo","color":"207de5"}],"state":"closed","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/rmarquis/pacaur/milestones/15","html_url":"https://github.com/rmarquis/pacaur/milestones/4.2.x%20-%20maintenance","labels_url":"https://api.github.com/repos/rmarquis/pacaur/milestones/15/labels","id":299707,"number":15,"title":"4.2.x - maintenance","description":"","creator":{"login":"rmarquis","id":162442,"avatar_url":"https://avatars.githubusercontent.com/u/162442?v=3","gravatar_id":"","url":"https://api.github.com/users/rmarquis","html_url":"https://github.com/rmarquis","followers_url":"https://api.github.com/users/rmarquis/followers","following_url":"https://api.github.com/users/rmarquis/following{/other_user}","gists_url":"https://api.github.com/users/rmarquis/gists{/gist_id}","starred_url":"https://api.github.com/users/rmarquis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmarquis/subscriptions","organizations_url":"https://api.github.com/users/rmarquis/orgs","repos_url":"https://api.github.com/users/rmarquis/repos","events_url":"https://api.github.com/users/rmarquis/events{/privacy}","received_events_url":"https://api.github.com/users/rmarquis/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":102,"state":"open","created_at":"2013-03-30T21:09:16Z","updated_at":"2015-03-28T10:40:38Z","due_on":null,"closed_at":null},"comments":8,"created_at":"2015-02-28T16:26:42Z","updated_at":"2015-03-28T10:40:38Z","closed_at":"2015-03-28T10:40:38Z","body":"Hello,\r\n\r\nThis is somehow related to #175. I ran `pacaur` through ShellCheck and it found quite a few hints to make the script safer (mainly quote escapes). Because ShellCheck is not right about everything, it will need some fine tuning to actually extract the useful advises.\r\n\r\nHere is the analysis result from master/HEAD (cbac3dd9a96b9cb99ce421782e74dbe3a9c20200): https://gist.github.com/Zopieux/80e810f99b3fbd7160c7\r\n\r\nI suggest progressively implementing the useful advises in future releases."},"comment":{"url":"https://api.github.com/repos/rmarquis/pacaur/issues/comments/87203974","html_url":"https://github.com/rmarquis/pacaur/issues/315#issuecomment-87203974","issue_url":"https://api.github.com/repos/rmarquis/pacaur/issues/315","id":87203974,"user":{"login":"rmarquis","id":162442,"avatar_url":"https://avatars.githubusercontent.com/u/162442?v=3","gravatar_id":"","url":"https://api.github.com/users/rmarquis","html_url":"https://github.com/rmarquis","followers_url":"https://api.github.com/users/rmarquis/followers","following_url":"https://api.github.com/users/rmarquis/following{/other_user}","gists_url":"https://api.github.com/users/rmarquis/gists{/gist_id}","starred_url":"https://api.github.com/users/rmarquis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmarquis/subscriptions","organizations_url":"https://api.github.com/users/rmarquis/orgs","repos_url":"https://api.github.com/users/rmarquis/repos","events_url":"https://api.github.com/users/rmarquis/events{/privacy}","received_events_url":"https://api.github.com/users/rmarquis/received_events","type":"User","site_admin":false},"created_at":"2015-03-28T10:40:38Z","updated_at":"2015-03-28T10:40:38Z","body":"Closing now. The important bits are now included in the code, and the others bits are either false-positive or not worth including. In particular, \"fixing\" the space in package names (which will never occur) is error prone, and I even needed to remove some of these parenthesis in 055352bfcc97e54ba9a6763693218e4c9b817008 to fix a bug. I've cleaned up some of these in 6ed7364890d1e2ad785f925adec446da29eb2e32."}}