{"action":"created","issue":{"url":"https://api.github.com/repos/berndbischl/mlr/issues/318","labels_url":"https://api.github.com/repos/berndbischl/mlr/issues/318/labels{/name}","comments_url":"https://api.github.com/repos/berndbischl/mlr/issues/318/comments","events_url":"https://api.github.com/repos/berndbischl/mlr/issues/318/events","html_url":"https://github.com/berndbischl/mlr/pull/318","id":85615445,"number":318,"title":"multiple filter methods for plot/getFilterValues","user":{"login":"zmjones","id":1114501,"avatar_url":"https://avatars.githubusercontent.com/u/1114501?v=3","gravatar_id":"","url":"https://api.github.com/users/zmjones","html_url":"https://github.com/zmjones","followers_url":"https://api.github.com/users/zmjones/followers","following_url":"https://api.github.com/users/zmjones/following{/other_user}","gists_url":"https://api.github.com/users/zmjones/gists{/gist_id}","starred_url":"https://api.github.com/users/zmjones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zmjones/subscriptions","organizations_url":"https://api.github.com/users/zmjones/orgs","repos_url":"https://api.github.com/users/zmjones/repos","events_url":"https://api.github.com/users/zmjones/events{/privacy}","received_events_url":"https://api.github.com/users/zmjones/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-06-05T19:31:02Z","updated_at":"2015-06-08T15:18:43Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/berndbischl/mlr/pulls/318","html_url":"https://github.com/berndbischl/mlr/pull/318","diff_url":"https://github.com/berndbischl/mlr/pull/318.diff","patch_url":"https://github.com/berndbischl/mlr/pull/318.patch"},"body":" - getFilterValues can now take a vector of methods\r\n - plotFilterValues can use facetting\r\n - plotFilterValuesGGVIS can use a Shiny app to interactively\r\n   show different filter methods\r\n - minor modifications to class 'FilterValues'\r\n - minor modifications to function 'FilterFeatures'\r\n\r\nThis passed the feature selection tests and check. I can't write tests for the Shiny app though."},"comment":{"url":"https://api.github.com/repos/berndbischl/mlr/issues/comments/110036357","html_url":"https://github.com/berndbischl/mlr/pull/318#issuecomment-110036357","issue_url":"https://api.github.com/repos/berndbischl/mlr/issues/318","id":110036357,"user":{"login":"zmjones","id":1114501,"avatar_url":"https://avatars.githubusercontent.com/u/1114501?v=3","gravatar_id":"","url":"https://api.github.com/users/zmjones","html_url":"https://github.com/zmjones","followers_url":"https://api.github.com/users/zmjones/followers","following_url":"https://api.github.com/users/zmjones/following{/other_user}","gists_url":"https://api.github.com/users/zmjones/gists{/gist_id}","starred_url":"https://api.github.com/users/zmjones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zmjones/subscriptions","organizations_url":"https://api.github.com/users/zmjones/orgs","repos_url":"https://api.github.com/users/zmjones/repos","events_url":"https://api.github.com/users/zmjones/events{/privacy}","received_events_url":"https://api.github.com/users/zmjones/received_events","type":"User","site_admin":false},"created_at":"2015-06-08T15:18:43Z","updated_at":"2015-06-08T15:18:43Z","body":"So I implemented the latter suggestion. Now in `filterFeatures` the default method is `NULL`. If `fval` is passed and the `data` element has length 1 then I just extract the name of this element (i.e. that becomes the default method`. If there are multiple filters in `fval` then the user has to set one as `method` which is then extracted. I avoided the side effect of not having a default filter when calling `filterFeatures` by substituting the default filter (by removing the method argument) when no `fval` is passed and `method` is still `NULL`. I am not sure I documented it correctly though."}}