{"action":"created","issue":{"url":"https://api.github.com/repos/mapsme/omim/issues/448","labels_url":"https://api.github.com/repos/mapsme/omim/issues/448/labels{/name}","comments_url":"https://api.github.com/repos/mapsme/omim/issues/448/comments","events_url":"https://api.github.com/repos/mapsme/omim/issues/448/events","html_url":"https://github.com/mapsme/omim/pull/448","id":115048617,"number":448,"title":"[routing] Cross mwm border cross caching fix.","user":{"login":"gardster","id":1862559,"avatar_url":"https://avatars.githubusercontent.com/u/1862559?v=3","gravatar_id":"","url":"https://api.github.com/users/gardster","html_url":"https://github.com/gardster","followers_url":"https://api.github.com/users/gardster/followers","following_url":"https://api.github.com/users/gardster/following{/other_user}","gists_url":"https://api.github.com/users/gardster/gists{/gist_id}","starred_url":"https://api.github.com/users/gardster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gardster/subscriptions","organizations_url":"https://api.github.com/users/gardster/orgs","repos_url":"https://api.github.com/users/gardster/repos","events_url":"https://api.github.com/users/gardster/events{/privacy}","received_events_url":"https://api.github.com/users/gardster/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2015-11-04T13:07:47Z","updated_at":"2015-11-05T09:09:30Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mapsme/omim/pulls/448","html_url":"https://github.com/mapsme/omim/pull/448","diff_url":"https://github.com/mapsme/omim/pull/448.diff","patch_url":"https://github.com/mapsme/omim/pull/448.patch"},"body":"https://trello.com/c/3XJBszfT/2023-151102-moscowtoparis\r\n\r\nФикс и рефакторинг метода поиска перехода через границу. В старом коде была ошибка, которая вызывала срабатывание юнит теста. Ошибка заключалась в том, что в кэш переходов сохранение шло по точке перехода. Так как на простой дороге в каждой точке на самом деле 2 перехода (в одну сторону и в другую), из кэша мог прийти переход не с той карты. Эта ситуация ловилась дальнейшим CHECK но никак не обрабатывалась.\r\nИз-за сильной связности метода и всего класса, затруднительно написать юнит тест для этой ошибки."},"comment":{"url":"https://api.github.com/repos/mapsme/omim/issues/comments/153998157","html_url":"https://github.com/mapsme/omim/pull/448#issuecomment-153998157","issue_url":"https://api.github.com/repos/mapsme/omim/issues/448","id":153998157,"user":{"login":"Zverik","id":766031,"avatar_url":"https://avatars.githubusercontent.com/u/766031?v=3","gravatar_id":"","url":"https://api.github.com/users/Zverik","html_url":"https://github.com/Zverik","followers_url":"https://api.github.com/users/Zverik/followers","following_url":"https://api.github.com/users/Zverik/following{/other_user}","gists_url":"https://api.github.com/users/Zverik/gists{/gist_id}","starred_url":"https://api.github.com/users/Zverik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zverik/subscriptions","organizations_url":"https://api.github.com/users/Zverik/orgs","repos_url":"https://api.github.com/users/Zverik/repos","events_url":"https://api.github.com/users/Zverik/events{/privacy}","received_events_url":"https://api.github.com/users/Zverik/received_events","type":"User","site_admin":false},"created_at":"2015-11-05T09:09:30Z","updated_at":"2015-11-05T09:09:30Z","body":"LGTM"}}