{"action":"opened","number":38,"pull_request":{"url":"https://api.github.com/repos/kenichi/angelo/pulls/38","id":28049999,"html_url":"https://github.com/kenichi/angelo/pull/38","diff_url":"https://github.com/kenichi/angelo/pull/38.diff","patch_url":"https://github.com/kenichi/angelo/pull/38.patch","issue_url":"https://api.github.com/repos/kenichi/angelo/issues/38","number":38,"state":"open","locked":false,"title":"Filters","user":{"login":"tommay","id":104477,"avatar_url":"https://avatars.githubusercontent.com/u/104477?v=3","gravatar_id":"","url":"https://api.github.com/users/tommay","html_url":"https://github.com/tommay","followers_url":"https://api.github.com/users/tommay/followers","following_url":"https://api.github.com/users/tommay/following{/other_user}","gists_url":"https://api.github.com/users/tommay/gists{/gist_id}","starred_url":"https://api.github.com/users/tommay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tommay/subscriptions","organizations_url":"https://api.github.com/users/tommay/orgs","repos_url":"https://api.github.com/users/tommay/repos","events_url":"https://api.github.com/users/tommay/events{/privacy}","received_events_url":"https://api.github.com/users/tommay/received_events","type":"User","site_admin":false},"body":"I was trying to figure out what compile! was good for.  It converts a block to an UnboundMethod that can be bound to an Angelo::Base instance and called.  But why bother.  It seems more ruby to keep it as a block and call it with instance_eval, or instance_exec if it needs arguments.\r\n\r\nThis PR is strictly a refactoring with three somewhat related commits.  Take them or leave them.\r\n* Filters are just blocks that are instance_evalled.\r\n* compile! is removed and everything else it was used for just stays as a block.\r\n* The filter invocation code is cleaned up.\r\n\r\nSorry to be kind of hyperactive.  I've actually got any number of small tweaks to suggest that I've come across while going through the code.","created_at":"2015-01-26T18:48:16Z","updated_at":"2015-01-26T18:48:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/kenichi/angelo/pulls/38/commits","review_comments_url":"https://api.github.com/repos/kenichi/angelo/pulls/38/comments","review_comment_url":"https://api.github.com/repos/kenichi/angelo/pulls/comments/{number}","comments_url":"https://api.github.com/repos/kenichi/angelo/issues/38/comments","statuses_url":"https://api.github.com/repos/kenichi/angelo/statuses/a5bd0a09470aee73171399852d12a437f8472251","head":{"label":"tommay:filters","ref":"filters","sha":"a5bd0a09470aee73171399852d12a437f8472251","user":{"login":"tommay","id":104477,"avatar_url":"https://avatars.githubusercontent.com/u/104477?v=3","gravatar_id":"","url":"https://api.github.com/users/tommay","html_url":"https://github.com/tommay","followers_url":"https://api.github.com/users/tommay/followers","following_url":"https://api.github.com/users/tommay/following{/other_user}","gists_url":"https://api.github.com/users/tommay/gists{/gist_id}","starred_url":"https://api.github.com/users/tommay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tommay/subscriptions","organizations_url":"https://api.github.com/users/tommay/orgs","repos_url":"https://api.github.com/users/tommay/repos","events_url":"https://api.github.com/users/tommay/events{/privacy}","received_events_url":"https://api.github.com/users/tommay/received_events","type":"User","site_admin":false},"repo":{"id":29025655,"name":"angelo","full_name":"tommay/angelo","owner":{"login":"tommay","id":104477,"avatar_url":"https://avatars.githubusercontent.com/u/104477?v=3","gravatar_id":"","url":"https://api.github.com/users/tommay","html_url":"https://github.com/tommay","followers_url":"https://api.github.com/users/tommay/followers","following_url":"https://api.github.com/users/tommay/following{/other_user}","gists_url":"https://api.github.com/users/tommay/gists{/gist_id}","starred_url":"https://api.github.com/users/tommay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tommay/subscriptions","organizations_url":"https://api.github.com/users/tommay/orgs","repos_url":"https://api.github.com/users/tommay/repos","events_url":"https://api.github.com/users/tommay/events{/privacy}","received_events_url":"https://api.github.com/users/tommay/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tommay/angelo","description":"Sinatra-like DSL for Reel that supports WebSockets and SSE","fork":true,"url":"https://api.github.com/repos/tommay/angelo","forks_url":"https://api.github.com/repos/tommay/angelo/forks","keys_url":"https://api.github.com/repos/tommay/angelo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tommay/angelo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tommay/angelo/teams","hooks_url":"https://api.github.com/repos/tommay/angelo/hooks","issue_events_url":"https://api.github.com/repos/tommay/angelo/issues/events{/number}","events_url":"https://api.github.com/repos/tommay/angelo/events","assignees_url":"https://api.github.com/repos/tommay/angelo/assignees{/user}","branches_url":"https://api.github.com/repos/tommay/angelo/branches{/branch}","tags_url":"https://api.github.com/repos/tommay/angelo/tags","blobs_url":"https://api.github.com/repos/tommay/angelo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tommay/angelo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tommay/angelo/git/refs{/sha}","trees_url":"https://api.github.com/repos/tommay/angelo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tommay/angelo/statuses/{sha}","languages_url":"https://api.github.com/repos/tommay/angelo/languages","stargazers_url":"https://api.github.com/repos/tommay/angelo/stargazers","contributors_url":"https://api.github.com/repos/tommay/angelo/contributors","subscribers_url":"https://api.github.com/repos/tommay/angelo/subscribers","subscription_url":"https://api.github.com/repos/tommay/angelo/subscription","commits_url":"https://api.github.com/repos/tommay/angelo/commits{/sha}","git_commits_url":"https://api.github.com/repos/tommay/angelo/git/commits{/sha}","comments_url":"https://api.github.com/repos/tommay/angelo/comments{/number}","issue_comment_url":"https://api.github.com/repos/tommay/angelo/issues/comments/{number}","contents_url":"https://api.github.com/repos/tommay/angelo/contents/{+path}","compare_url":"https://api.github.com/repos/tommay/angelo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tommay/angelo/merges","archive_url":"https://api.github.com/repos/tommay/angelo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tommay/angelo/downloads","issues_url":"https://api.github.com/repos/tommay/angelo/issues{/number}","pulls_url":"https://api.github.com/repos/tommay/angelo/pulls{/number}","milestones_url":"https://api.github.com/repos/tommay/angelo/milestones{/number}","notifications_url":"https://api.github.com/repos/tommay/angelo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tommay/angelo/labels{/name}","releases_url":"https://api.github.com/repos/tommay/angelo/releases{/id}","created_at":"2015-01-09T16:50:26Z","updated_at":"2015-01-21T01:34:18Z","pushed_at":"2015-01-26T18:32:17Z","git_url":"git://github.com/tommay/angelo.git","ssh_url":"git@github.com:tommay/angelo.git","clone_url":"https://github.com/tommay/angelo.git","svn_url":"https://github.com/tommay/angelo","homepage":"","size":1018,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kenichi:master","ref":"master","sha":"b84d4a630279a70f5d2d17c560f706318f64b882","user":{"login":"kenichi","id":933055,"avatar_url":"https://avatars.githubusercontent.com/u/933055?v=3","gravatar_id":"","url":"https://api.github.com/users/kenichi","html_url":"https://github.com/kenichi","followers_url":"https://api.github.com/users/kenichi/followers","following_url":"https://api.github.com/users/kenichi/following{/other_user}","gists_url":"https://api.github.com/users/kenichi/gists{/gist_id}","starred_url":"https://api.github.com/users/kenichi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kenichi/subscriptions","organizations_url":"https://api.github.com/users/kenichi/orgs","repos_url":"https://api.github.com/users/kenichi/repos","events_url":"https://api.github.com/users/kenichi/events{/privacy}","received_events_url":"https://api.github.com/users/kenichi/received_events","type":"User","site_admin":false},"repo":{"id":13941428,"name":"angelo","full_name":"kenichi/angelo","owner":{"login":"kenichi","id":933055,"avatar_url":"https://avatars.githubusercontent.com/u/933055?v=3","gravatar_id":"","url":"https://api.github.com/users/kenichi","html_url":"https://github.com/kenichi","followers_url":"https://api.github.com/users/kenichi/followers","following_url":"https://api.github.com/users/kenichi/following{/other_user}","gists_url":"https://api.github.com/users/kenichi/gists{/gist_id}","starred_url":"https://api.github.com/users/kenichi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kenichi/subscriptions","organizations_url":"https://api.github.com/users/kenichi/orgs","repos_url":"https://api.github.com/users/kenichi/repos","events_url":"https://api.github.com/users/kenichi/events{/privacy}","received_events_url":"https://api.github.com/users/kenichi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kenichi/angelo","description":"Sinatra-like DSL for Reel that supports WebSockets and SSE","fork":false,"url":"https://api.github.com/repos/kenichi/angelo","forks_url":"https://api.github.com/repos/kenichi/angelo/forks","keys_url":"https://api.github.com/repos/kenichi/angelo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kenichi/angelo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kenichi/angelo/teams","hooks_url":"https://api.github.com/repos/kenichi/angelo/hooks","issue_events_url":"https://api.github.com/repos/kenichi/angelo/issues/events{/number}","events_url":"https://api.github.com/repos/kenichi/angelo/events","assignees_url":"https://api.github.com/repos/kenichi/angelo/assignees{/user}","branches_url":"https://api.github.com/repos/kenichi/angelo/branches{/branch}","tags_url":"https://api.github.com/repos/kenichi/angelo/tags","blobs_url":"https://api.github.com/repos/kenichi/angelo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kenichi/angelo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kenichi/angelo/git/refs{/sha}","trees_url":"https://api.github.com/repos/kenichi/angelo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kenichi/angelo/statuses/{sha}","languages_url":"https://api.github.com/repos/kenichi/angelo/languages","stargazers_url":"https://api.github.com/repos/kenichi/angelo/stargazers","contributors_url":"https://api.github.com/repos/kenichi/angelo/contributors","subscribers_url":"https://api.github.com/repos/kenichi/angelo/subscribers","subscription_url":"https://api.github.com/repos/kenichi/angelo/subscription","commits_url":"https://api.github.com/repos/kenichi/angelo/commits{/sha}","git_commits_url":"https://api.github.com/repos/kenichi/angelo/git/commits{/sha}","comments_url":"https://api.github.com/repos/kenichi/angelo/comments{/number}","issue_comment_url":"https://api.github.com/repos/kenichi/angelo/issues/comments/{number}","contents_url":"https://api.github.com/repos/kenichi/angelo/contents/{+path}","compare_url":"https://api.github.com/repos/kenichi/angelo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kenichi/angelo/merges","archive_url":"https://api.github.com/repos/kenichi/angelo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kenichi/angelo/downloads","issues_url":"https://api.github.com/repos/kenichi/angelo/issues{/number}","pulls_url":"https://api.github.com/repos/kenichi/angelo/pulls{/number}","milestones_url":"https://api.github.com/repos/kenichi/angelo/milestones{/number}","notifications_url":"https://api.github.com/repos/kenichi/angelo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kenichi/angelo/labels{/name}","releases_url":"https://api.github.com/repos/kenichi/angelo/releases{/id}","created_at":"2013-10-28T23:21:56Z","updated_at":"2015-01-26T08:42:27Z","pushed_at":"2015-01-24T00:40:10Z","git_url":"git://github.com/kenichi/angelo.git","ssh_url":"git@github.com:kenichi/angelo.git","clone_url":"https://github.com/kenichi/angelo.git","svn_url":"https://github.com/kenichi/angelo","homepage":"","size":1650,"stargazers_count":194,"watchers_count":194,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":4,"forks":12,"open_issues":4,"watchers":194,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kenichi/angelo/pulls/38"},"html":{"href":"https://github.com/kenichi/angelo/pull/38"},"issue":{"href":"https://api.github.com/repos/kenichi/angelo/issues/38"},"comments":{"href":"https://api.github.com/repos/kenichi/angelo/issues/38/comments"},"review_comments":{"href":"https://api.github.com/repos/kenichi/angelo/pulls/38/comments"},"review_comment":{"href":"https://api.github.com/repos/kenichi/angelo/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/kenichi/angelo/pulls/38/commits"},"statuses":{"href":"https://api.github.com/repos/kenichi/angelo/statuses/a5bd0a09470aee73171399852d12a437f8472251"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":3,"additions":40,"deletions":52,"changed_files":4}}