{"action":"created","comment":{"url":"https://api.github.com/repos/psieg/Lightpack/pulls/comments/35568452","id":35568452,"diff_hunk":"@@ -57,18 +57,13 @@ Source: \"content/Qt5Network.dll\"; DestDir: \"{app}\"; Flags: ignoreversion\n Source: \"content/Qt5SerialPort.dll\"; DestDir: \"{app}\"; Flags: ignoreversion\n Source: \"content/Qt5Widgets.dll\"; DestDir: \"{app}\"; Flags: ignoreversion\n Source: \"gpl-3.0.txt\"; DestDir: \"{app}\"; Flags: ignoreversion\n-Source: \"content/icudt54.dll\"; DestDir: \"{app}\"; Flags: ignoreversion\n-Source: \"content/icuin54.dll\"; DestDir: \"{app}\"; Flags: ignoreversion\n-Source: \"content/icuuc54.dll\"; DestDir: \"{app}\"; Flags: ignoreversion","path":"Software/dist_windows/script32.iss","position":15,"original_position":15,"commit_id":"5499b215a0aed5617cda7e56e970b22b0160f75f","original_commit_id":"35a4abd050d3e30ee0ceaaa99bcece19227df9ac","user":{"login":"Archomeda","id":1467127,"avatar_url":"https://avatars.githubusercontent.com/u/1467127?v=3","gravatar_id":"","url":"https://api.github.com/users/Archomeda","html_url":"https://github.com/Archomeda","followers_url":"https://api.github.com/users/Archomeda/followers","following_url":"https://api.github.com/users/Archomeda/following{/other_user}","gists_url":"https://api.github.com/users/Archomeda/gists{/gist_id}","starred_url":"https://api.github.com/users/Archomeda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Archomeda/subscriptions","organizations_url":"https://api.github.com/users/Archomeda/orgs","repos_url":"https://api.github.com/users/Archomeda/repos","events_url":"https://api.github.com/users/Archomeda/events{/privacy}","received_events_url":"https://api.github.com/users/Archomeda/received_events","type":"User","site_admin":false},"body":"Oh derp, now that you mention it :sweat:","created_at":"2015-07-27T18:22:24Z","updated_at":"2015-07-27T18:22:24Z","html_url":"https://github.com/psieg/Lightpack/pull/8#discussion_r35568452","pull_request_url":"https://api.github.com/repos/psieg/Lightpack/pulls/8","_links":{"self":{"href":"https://api.github.com/repos/psieg/Lightpack/pulls/comments/35568452"},"html":{"href":"https://github.com/psieg/Lightpack/pull/8#discussion_r35568452"},"pull_request":{"href":"https://api.github.com/repos/psieg/Lightpack/pulls/8"}}},"pull_request":{"url":"https://api.github.com/repos/psieg/Lightpack/pulls/8","id":40905615,"html_url":"https://github.com/psieg/Lightpack/pull/8","diff_url":"https://github.com/psieg/Lightpack/pull/8.diff","patch_url":"https://github.com/psieg/Lightpack/pull/8.patch","issue_url":"https://api.github.com/repos/psieg/Lightpack/issues/8","number":8,"state":"open","locked":false,"title":"Improve Windows builds","user":{"login":"Archomeda","id":1467127,"avatar_url":"https://avatars.githubusercontent.com/u/1467127?v=3","gravatar_id":"","url":"https://api.github.com/users/Archomeda","html_url":"https://github.com/Archomeda","followers_url":"https://api.github.com/users/Archomeda/followers","following_url":"https://api.github.com/users/Archomeda/following{/other_user}","gists_url":"https://api.github.com/users/Archomeda/gists{/gist_id}","starred_url":"https://api.github.com/users/Archomeda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Archomeda/subscriptions","organizations_url":"https://api.github.com/users/Archomeda/orgs","repos_url":"https://api.github.com/users/Archomeda/repos","events_url":"https://api.github.com/users/Archomeda/events{/privacy}","received_events_url":"https://api.github.com/users/Archomeda/received_events","type":"User","site_admin":false},"body":"As I've mentioned in #1, I've been playing around with windeployqt. Not only have I applied that command, but also some other things:\r\n\r\n- Automatic generation of the compiled translation files (it currently happens when running `qmake`). Sadly I can't seem to make it better than to include it as a `system` command within `src.pro`. I tried using `QMAKE_EXTRA_COMPILERS`, but for some reason qmake adds duplicate filters that Visual Studio doesn't like. Also, I still believe that the language files are compiled within the executable as a resource. This is the reason why I removed the translations folder from the output completely.\r\n- I also removed the precompiled `*.qm` files as they are no longer needed.\r\n- With the usage of windeployqt, vcredist_x64.exe or vcredist_x86.exe should be copied automatically as well. This removes the need of copying msvcr120.dll and msvcp120.dll manually. I've added an additional installation step in the installer to support it.\r\n- I changed the `QMAKE_POST_LINK` to also support windeployqt. Apparently, windeployqt doesn't add the ICU DLLs if I don't specify it explicitly. It still runs fine on my pc, and also on my laptop that doesn't have Qt installed.\r\n\r\nCan you test it? I hope it builds and works correctly on your end. If it doesn't, I'll see what I can do.","created_at":"2015-07-27T13:56:55Z","updated_at":"2015-07-27T18:22:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"57ad50ada7b01338528bf9b1dd8f38f02ba3a43c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/psieg/Lightpack/pulls/8/commits","review_comments_url":"https://api.github.com/repos/psieg/Lightpack/pulls/8/comments","review_comment_url":"https://api.github.com/repos/psieg/Lightpack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/psieg/Lightpack/issues/8/comments","statuses_url":"https://api.github.com/repos/psieg/Lightpack/statuses/5499b215a0aed5617cda7e56e970b22b0160f75f","head":{"label":"Archomeda:windeployqt","ref":"windeployqt","sha":"5499b215a0aed5617cda7e56e970b22b0160f75f","user":{"login":"Archomeda","id":1467127,"avatar_url":"https://avatars.githubusercontent.com/u/1467127?v=3","gravatar_id":"","url":"https://api.github.com/users/Archomeda","html_url":"https://github.com/Archomeda","followers_url":"https://api.github.com/users/Archomeda/followers","following_url":"https://api.github.com/users/Archomeda/following{/other_user}","gists_url":"https://api.github.com/users/Archomeda/gists{/gist_id}","starred_url":"https://api.github.com/users/Archomeda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Archomeda/subscriptions","organizations_url":"https://api.github.com/users/Archomeda/orgs","repos_url":"https://api.github.com/users/Archomeda/repos","events_url":"https://api.github.com/users/Archomeda/events{/privacy}","received_events_url":"https://api.github.com/users/Archomeda/received_events","type":"User","site_admin":false},"repo":{"id":39301005,"name":"Lightpack","full_name":"Archomeda/Lightpack","owner":{"login":"Archomeda","id":1467127,"avatar_url":"https://avatars.githubusercontent.com/u/1467127?v=3","gravatar_id":"","url":"https://api.github.com/users/Archomeda","html_url":"https://github.com/Archomeda","followers_url":"https://api.github.com/users/Archomeda/followers","following_url":"https://api.github.com/users/Archomeda/following{/other_user}","gists_url":"https://api.github.com/users/Archomeda/gists{/gist_id}","starred_url":"https://api.github.com/users/Archomeda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Archomeda/subscriptions","organizations_url":"https://api.github.com/users/Archomeda/orgs","repos_url":"https://api.github.com/users/Archomeda/repos","events_url":"https://api.github.com/users/Archomeda/events{/privacy}","received_events_url":"https://api.github.com/users/Archomeda/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Archomeda/Lightpack","description":"Lightpack and Prismatik open repository","fork":true,"url":"https://api.github.com/repos/Archomeda/Lightpack","forks_url":"https://api.github.com/repos/Archomeda/Lightpack/forks","keys_url":"https://api.github.com/repos/Archomeda/Lightpack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Archomeda/Lightpack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Archomeda/Lightpack/teams","hooks_url":"https://api.github.com/repos/Archomeda/Lightpack/hooks","issue_events_url":"https://api.github.com/repos/Archomeda/Lightpack/issues/events{/number}","events_url":"https://api.github.com/repos/Archomeda/Lightpack/events","assignees_url":"https://api.github.com/repos/Archomeda/Lightpack/assignees{/user}","branches_url":"https://api.github.com/repos/Archomeda/Lightpack/branches{/branch}","tags_url":"https://api.github.com/repos/Archomeda/Lightpack/tags","blobs_url":"https://api.github.com/repos/Archomeda/Lightpack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Archomeda/Lightpack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Archomeda/Lightpack/git/refs{/sha}","trees_url":"https://api.github.com/repos/Archomeda/Lightpack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Archomeda/Lightpack/statuses/{sha}","languages_url":"https://api.github.com/repos/Archomeda/Lightpack/languages","stargazers_url":"https://api.github.com/repos/Archomeda/Lightpack/stargazers","contributors_url":"https://api.github.com/repos/Archomeda/Lightpack/contributors","subscribers_url":"https://api.github.com/repos/Archomeda/Lightpack/subscribers","subscription_url":"https://api.github.com/repos/Archomeda/Lightpack/subscription","commits_url":"https://api.github.com/repos/Archomeda/Lightpack/commits{/sha}","git_commits_url":"https://api.github.com/repos/Archomeda/Lightpack/git/commits{/sha}","comments_url":"https://api.github.com/repos/Archomeda/Lightpack/comments{/number}","issue_comment_url":"https://api.github.com/repos/Archomeda/Lightpack/issues/comments{/number}","contents_url":"https://api.github.com/repos/Archomeda/Lightpack/contents/{+path}","compare_url":"https://api.github.com/repos/Archomeda/Lightpack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Archomeda/Lightpack/merges","archive_url":"https://api.github.com/repos/Archomeda/Lightpack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Archomeda/Lightpack/downloads","issues_url":"https://api.github.com/repos/Archomeda/Lightpack/issues{/number}","pulls_url":"https://api.github.com/repos/Archomeda/Lightpack/pulls{/number}","milestones_url":"https://api.github.com/repos/Archomeda/Lightpack/milestones{/number}","notifications_url":"https://api.github.com/repos/Archomeda/Lightpack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Archomeda/Lightpack/labels{/name}","releases_url":"https://api.github.com/repos/Archomeda/Lightpack/releases{/id}","created_at":"2015-07-18T14:33:55Z","updated_at":"2015-07-18T16:45:30Z","pushed_at":"2015-07-27T18:17:28Z","git_url":"git://github.com/Archomeda/Lightpack.git","ssh_url":"git@github.com:Archomeda/Lightpack.git","clone_url":"https://github.com/Archomeda/Lightpack.git","svn_url":"https://github.com/Archomeda/Lightpack","homepage":null,"size":25193,"stargazers_count":0,"watchers_count":0,"language":"Pascal","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"psieg:master","ref":"master","sha":"cb1391d70fea545d059fa17af1d87f3f9325f719","user":{"login":"psieg","id":5766601,"avatar_url":"https://avatars.githubusercontent.com/u/5766601?v=3","gravatar_id":"","url":"https://api.github.com/users/psieg","html_url":"https://github.com/psieg","followers_url":"https://api.github.com/users/psieg/followers","following_url":"https://api.github.com/users/psieg/following{/other_user}","gists_url":"https://api.github.com/users/psieg/gists{/gist_id}","starred_url":"https://api.github.com/users/psieg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psieg/subscriptions","organizations_url":"https://api.github.com/users/psieg/orgs","repos_url":"https://api.github.com/users/psieg/repos","events_url":"https://api.github.com/users/psieg/events{/privacy}","received_events_url":"https://api.github.com/users/psieg/received_events","type":"User","site_admin":false},"repo":{"id":28306829,"name":"Lightpack","full_name":"psieg/Lightpack","owner":{"login":"psieg","id":5766601,"avatar_url":"https://avatars.githubusercontent.com/u/5766601?v=3","gravatar_id":"","url":"https://api.github.com/users/psieg","html_url":"https://github.com/psieg","followers_url":"https://api.github.com/users/psieg/followers","following_url":"https://api.github.com/users/psieg/following{/other_user}","gists_url":"https://api.github.com/users/psieg/gists{/gist_id}","starred_url":"https://api.github.com/users/psieg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psieg/subscriptions","organizations_url":"https://api.github.com/users/psieg/orgs","repos_url":"https://api.github.com/users/psieg/repos","events_url":"https://api.github.com/users/psieg/events{/privacy}","received_events_url":"https://api.github.com/users/psieg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/psieg/Lightpack","description":"Lightpack and Prismatik open repository","fork":true,"url":"https://api.github.com/repos/psieg/Lightpack","forks_url":"https://api.github.com/repos/psieg/Lightpack/forks","keys_url":"https://api.github.com/repos/psieg/Lightpack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/psieg/Lightpack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/psieg/Lightpack/teams","hooks_url":"https://api.github.com/repos/psieg/Lightpack/hooks","issue_events_url":"https://api.github.com/repos/psieg/Lightpack/issues/events{/number}","events_url":"https://api.github.com/repos/psieg/Lightpack/events","assignees_url":"https://api.github.com/repos/psieg/Lightpack/assignees{/user}","branches_url":"https://api.github.com/repos/psieg/Lightpack/branches{/branch}","tags_url":"https://api.github.com/repos/psieg/Lightpack/tags","blobs_url":"https://api.github.com/repos/psieg/Lightpack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/psieg/Lightpack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/psieg/Lightpack/git/refs{/sha}","trees_url":"https://api.github.com/repos/psieg/Lightpack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/psieg/Lightpack/statuses/{sha}","languages_url":"https://api.github.com/repos/psieg/Lightpack/languages","stargazers_url":"https://api.github.com/repos/psieg/Lightpack/stargazers","contributors_url":"https://api.github.com/repos/psieg/Lightpack/contributors","subscribers_url":"https://api.github.com/repos/psieg/Lightpack/subscribers","subscription_url":"https://api.github.com/repos/psieg/Lightpack/subscription","commits_url":"https://api.github.com/repos/psieg/Lightpack/commits{/sha}","git_commits_url":"https://api.github.com/repos/psieg/Lightpack/git/commits{/sha}","comments_url":"https://api.github.com/repos/psieg/Lightpack/comments{/number}","issue_comment_url":"https://api.github.com/repos/psieg/Lightpack/issues/comments{/number}","contents_url":"https://api.github.com/repos/psieg/Lightpack/contents/{+path}","compare_url":"https://api.github.com/repos/psieg/Lightpack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/psieg/Lightpack/merges","archive_url":"https://api.github.com/repos/psieg/Lightpack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/psieg/Lightpack/downloads","issues_url":"https://api.github.com/repos/psieg/Lightpack/issues{/number}","pulls_url":"https://api.github.com/repos/psieg/Lightpack/pulls{/number}","milestones_url":"https://api.github.com/repos/psieg/Lightpack/milestones{/number}","notifications_url":"https://api.github.com/repos/psieg/Lightpack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/psieg/Lightpack/labels{/name}","releases_url":"https://api.github.com/repos/psieg/Lightpack/releases{/id}","created_at":"2014-12-21T17:23:49Z","updated_at":"2015-07-23T21:41:26Z","pushed_at":"2015-07-27T18:17:28Z","git_url":"git://github.com/psieg/Lightpack.git","ssh_url":"git@github.com:psieg/Lightpack.git","clone_url":"https://github.com/psieg/Lightpack.git","svn_url":"https://github.com/psieg/Lightpack","homepage":null,"size":25646,"stargazers_count":2,"watchers_count":2,"language":"Pascal","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/psieg/Lightpack/pulls/8"},"html":{"href":"https://github.com/psieg/Lightpack/pull/8"},"issue":{"href":"https://api.github.com/repos/psieg/Lightpack/issues/8"},"comments":{"href":"https://api.github.com/repos/psieg/Lightpack/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/psieg/Lightpack/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/psieg/Lightpack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/psieg/Lightpack/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/psieg/Lightpack/statuses/5499b215a0aed5617cda7e56e970b22b0160f75f"}}}}