{"action":"created","issue":{"url":"https://api.github.com/repos/shazow/urllib3/issues/751","labels_url":"https://api.github.com/repos/shazow/urllib3/issues/751/labels{/name}","comments_url":"https://api.github.com/repos/shazow/urllib3/issues/751/comments","events_url":"https://api.github.com/repos/shazow/urllib3/issues/751/events","html_url":"https://github.com/shazow/urllib3/pull/751","id":119018230,"number":751,"title":"Start keying connection pools off SSL arguments as well.","user":{"login":"Lukasa","id":1382556,"avatar_url":"https://avatars.githubusercontent.com/u/1382556?v=3","gravatar_id":"","url":"https://api.github.com/users/Lukasa","html_url":"https://github.com/Lukasa","followers_url":"https://api.github.com/users/Lukasa/followers","following_url":"https://api.github.com/users/Lukasa/following{/other_user}","gists_url":"https://api.github.com/users/Lukasa/gists{/gist_id}","starred_url":"https://api.github.com/users/Lukasa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lukasa/subscriptions","organizations_url":"https://api.github.com/users/Lukasa/orgs","repos_url":"https://api.github.com/users/Lukasa/repos","events_url":"https://api.github.com/users/Lukasa/events{/privacy}","received_events_url":"https://api.github.com/users/Lukasa/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":12,"created_at":"2015-11-26T10:47:31Z","updated_at":"2015-12-03T20:43:57Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/shazow/urllib3/pulls/751","html_url":"https://github.com/shazow/urllib3/pull/751","diff_url":"https://github.com/shazow/urllib3/pull/751.diff","patch_url":"https://github.com/shazow/urllib3/pull/751.patch"},"body":"This is a proposed patch that begins to implement the requirements for kennethreitz/requests#2863. In particular, it adds hooks to provide additional keyword arguments as part of the key for the connection pool.\r\n\r\nThere are some outstanding questions. For example:\r\n\r\n- should we actually just use all the connection pool keyword arguments as part of the key? Why are `headers` et al exempt?\r\n- Are we happy with this API, where `connection_from_host` picks up the new argument but `connection_from_url` does not?\r\n\r\nCode review encouraged, please. :custard:"},"comment":{"url":"https://api.github.com/repos/shazow/urllib3/issues/comments/161779280","html_url":"https://github.com/shazow/urllib3/pull/751#issuecomment-161779280","issue_url":"https://api.github.com/repos/shazow/urllib3/issues/751","id":161779280,"user":{"login":"Lukasa","id":1382556,"avatar_url":"https://avatars.githubusercontent.com/u/1382556?v=3","gravatar_id":"","url":"https://api.github.com/users/Lukasa","html_url":"https://github.com/Lukasa","followers_url":"https://api.github.com/users/Lukasa/followers","following_url":"https://api.github.com/users/Lukasa/following{/other_user}","gists_url":"https://api.github.com/users/Lukasa/gists{/gist_id}","starred_url":"https://api.github.com/users/Lukasa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lukasa/subscriptions","organizations_url":"https://api.github.com/users/Lukasa/orgs","repos_url":"https://api.github.com/users/Lukasa/repos","events_url":"https://api.github.com/users/Lukasa/events{/privacy}","received_events_url":"https://api.github.com/users/Lukasa/received_events","type":"User","site_admin":false},"created_at":"2015-12-03T20:43:57Z","updated_at":"2015-12-03T20:43:57Z","body":"@shazow So, can you look back at the commit prior to the HEAD of this branch and confirm whether that looks closer to what you wanted?"}}