{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/3987","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/3987/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/3987/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/3987/events","html_url":"https://github.com/ManageIQ/manageiq/pull/3987","id":102409445,"number":3987,"title":"[WIP] Fix for RBAC to deny modification of catalog items, when user has view permission only","user":{"login":"jzigmund","id":2270962,"avatar_url":"https://avatars.githubusercontent.com/u/2270962?v=3","gravatar_id":"","url":"https://api.github.com/users/jzigmund","html_url":"https://github.com/jzigmund","followers_url":"https://api.github.com/users/jzigmund/followers","following_url":"https://api.github.com/users/jzigmund/following{/other_user}","gists_url":"https://api.github.com/users/jzigmund/gists{/gist_id}","starred_url":"https://api.github.com/users/jzigmund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jzigmund/subscriptions","organizations_url":"https://api.github.com/users/jzigmund/orgs","repos_url":"https://api.github.com/users/jzigmund/repos","events_url":"https://api.github.com/users/jzigmund/events{/privacy}","received_events_url":"https://api.github.com/users/jzigmund/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/bug","name":"bug","color":"fc2929"},{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/ui","name":"ui","color":"5319e7"},{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/wip","name":"wip","color":"eeeeee"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-08-21T15:55:58Z","updated_at":"2015-09-10T18:46:16Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/3987","html_url":"https://github.com/ManageIQ/manageiq/pull/3987","diff_url":"https://github.com/ManageIQ/manageiq/pull/3987.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/3987.patch"},"body":"The basics of the PR is the same as https://github.com/ManageIQ/manageiq/pull/3114 but contains also merged product features according to Dan's comment.\r\n\r\nMy intension with the create new PR is that I'm removing the before_filter call from catalog_controller and I'm not sure if this action is wanted.\r\n\r\nAnyway I found also other features could be merged (i.e. edit Button/Button Group, remove Button/Button Group). And I also found that some of the hash items of the CATALOG_X_BUTTON_ALLOWED_ACTIONS could be removed as they're not used."},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments/139340707","html_url":"https://github.com/ManageIQ/manageiq/pull/3987#issuecomment-139340707","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/3987","id":139340707,"user":{"login":"miq-bot","id":7806257,"avatar_url":"https://avatars.githubusercontent.com/u/7806257?v=3","gravatar_id":"","url":"https://api.github.com/users/miq-bot","html_url":"https://github.com/miq-bot","followers_url":"https://api.github.com/users/miq-bot/followers","following_url":"https://api.github.com/users/miq-bot/following{/other_user}","gists_url":"https://api.github.com/users/miq-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/miq-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miq-bot/subscriptions","organizations_url":"https://api.github.com/users/miq-bot/orgs","repos_url":"https://api.github.com/users/miq-bot/repos","events_url":"https://api.github.com/users/miq-bot/events{/privacy}","received_events_url":"https://api.github.com/users/miq-bot/received_events","type":"User","site_admin":false},"created_at":"2015-09-10T18:46:16Z","updated_at":"2015-09-10T18:46:16Z","body":"<rubocop />Checked commits https://github.com/jzigmund/manageiq/compare/d1865ed3e09e28c59088687cc553783fcbeddcd5~...5b172425cad53f4514a22d13c6c69e0a07ce9012 with ruby 1.9.3, rubocop 0.33.0, and haml-lint 0.13.0\n6 files checked, 1 offense detected\n\n**app/views/shared/buttons/_ab_list.html.haml**\n- [ ] :red_circle: **Warn** - [Line 124](https://github.com/jzigmund/manageiq/blob/5b172425cad53f4514a22d13c6c69e0a07ce9012/app/views/shared/buttons/_ab_list.html.haml#L124), Col  -  - Line is too long. [183/120]\n"}}