{"action":"closed","number":1187,"pull_request":{"url":"https://api.github.com/repos/oppia/oppia/pulls/1187","id":52176361,"html_url":"https://github.com/oppia/oppia/pull/1187","diff_url":"https://github.com/oppia/oppia/pull/1187.diff","patch_url":"https://github.com/oppia/oppia/pull/1187.patch","issue_url":"https://api.github.com/repos/oppia/oppia/issues/1187","number":1187,"state":"closed","locked":false,"title":"Oppia js minification","user":{"login":"MAKOSCAFEE","id":6409210,"avatar_url":"https://avatars.githubusercontent.com/u/6409210?v=3","gravatar_id":"","url":"https://api.github.com/users/MAKOSCAFEE","html_url":"https://github.com/MAKOSCAFEE","followers_url":"https://api.github.com/users/MAKOSCAFEE/followers","following_url":"https://api.github.com/users/MAKOSCAFEE/following{/other_user}","gists_url":"https://api.github.com/users/MAKOSCAFEE/gists{/gist_id}","starred_url":"https://api.github.com/users/MAKOSCAFEE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MAKOSCAFEE/subscriptions","organizations_url":"https://api.github.com/users/MAKOSCAFEE/orgs","repos_url":"https://api.github.com/users/MAKOSCAFEE/repos","events_url":"https://api.github.com/users/MAKOSCAFEE/events{/privacy}","received_events_url":"https://api.github.com/users/MAKOSCAFEE/received_events","type":"User","site_admin":false},"body":"if we include angular in concatenated file. we had to position third_paty.js at the header of the page and this will block rendering . so i removed angular and placed at the header and leaving the rest at the footer.","created_at":"2015-11-30T20:42:36Z","updated_at":"2015-12-04T01:45:56Z","closed_at":"2015-12-04T01:45:56Z","merged_at":"2015-12-04T01:45:56Z","merge_commit_sha":"e1ca0896b89560d383be33b568f1158a006fe3fc","assignee":{"login":"seanlip","id":10575562,"avatar_url":"https://avatars.githubusercontent.com/u/10575562?v=3","gravatar_id":"","url":"https://api.github.com/users/seanlip","html_url":"https://github.com/seanlip","followers_url":"https://api.github.com/users/seanlip/followers","following_url":"https://api.github.com/users/seanlip/following{/other_user}","gists_url":"https://api.github.com/users/seanlip/gists{/gist_id}","starred_url":"https://api.github.com/users/seanlip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanlip/subscriptions","organizations_url":"https://api.github.com/users/seanlip/orgs","repos_url":"https://api.github.com/users/seanlip/repos","events_url":"https://api.github.com/users/seanlip/events{/privacy}","received_events_url":"https://api.github.com/users/seanlip/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/oppia/oppia/pulls/1187/commits","review_comments_url":"https://api.github.com/repos/oppia/oppia/pulls/1187/comments","review_comment_url":"https://api.github.com/repos/oppia/oppia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/oppia/oppia/issues/1187/comments","statuses_url":"https://api.github.com/repos/oppia/oppia/statuses/3608d5b3b41f6723938e452a39b53f7eb5642ca1","head":{"label":"MAKOSCAFEE:oppia-js-minification","ref":"oppia-js-minification","sha":"3608d5b3b41f6723938e452a39b53f7eb5642ca1","user":{"login":"MAKOSCAFEE","id":6409210,"avatar_url":"https://avatars.githubusercontent.com/u/6409210?v=3","gravatar_id":"","url":"https://api.github.com/users/MAKOSCAFEE","html_url":"https://github.com/MAKOSCAFEE","followers_url":"https://api.github.com/users/MAKOSCAFEE/followers","following_url":"https://api.github.com/users/MAKOSCAFEE/following{/other_user}","gists_url":"https://api.github.com/users/MAKOSCAFEE/gists{/gist_id}","starred_url":"https://api.github.com/users/MAKOSCAFEE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MAKOSCAFEE/subscriptions","organizations_url":"https://api.github.com/users/MAKOSCAFEE/orgs","repos_url":"https://api.github.com/users/MAKOSCAFEE/repos","events_url":"https://api.github.com/users/MAKOSCAFEE/events{/privacy}","received_events_url":"https://api.github.com/users/MAKOSCAFEE/received_events","type":"User","site_admin":false},"repo":{"id":40843161,"name":"oppia","full_name":"MAKOSCAFEE/oppia","owner":{"login":"MAKOSCAFEE","id":6409210,"avatar_url":"https://avatars.githubusercontent.com/u/6409210?v=3","gravatar_id":"","url":"https://api.github.com/users/MAKOSCAFEE","html_url":"https://github.com/MAKOSCAFEE","followers_url":"https://api.github.com/users/MAKOSCAFEE/followers","following_url":"https://api.github.com/users/MAKOSCAFEE/following{/other_user}","gists_url":"https://api.github.com/users/MAKOSCAFEE/gists{/gist_id}","starred_url":"https://api.github.com/users/MAKOSCAFEE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MAKOSCAFEE/subscriptions","organizations_url":"https://api.github.com/users/MAKOSCAFEE/orgs","repos_url":"https://api.github.com/users/MAKOSCAFEE/repos","events_url":"https://api.github.com/users/MAKOSCAFEE/events{/privacy}","received_events_url":"https://api.github.com/users/MAKOSCAFEE/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MAKOSCAFEE/oppia","description":"Tool for creating interactive tutors.","fork":true,"url":"https://api.github.com/repos/MAKOSCAFEE/oppia","forks_url":"https://api.github.com/repos/MAKOSCAFEE/oppia/forks","keys_url":"https://api.github.com/repos/MAKOSCAFEE/oppia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MAKOSCAFEE/oppia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MAKOSCAFEE/oppia/teams","hooks_url":"https://api.github.com/repos/MAKOSCAFEE/oppia/hooks","issue_events_url":"https://api.github.com/repos/MAKOSCAFEE/oppia/issues/events{/number}","events_url":"https://api.github.com/repos/MAKOSCAFEE/oppia/events","assignees_url":"https://api.github.com/repos/MAKOSCAFEE/oppia/assignees{/user}","branches_url":"https://api.github.com/repos/MAKOSCAFEE/oppia/branches{/branch}","tags_url":"https://api.github.com/repos/MAKOSCAFEE/oppia/tags","blobs_url":"https://api.github.com/repos/MAKOSCAFEE/oppia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MAKOSCAFEE/oppia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MAKOSCAFEE/oppia/git/refs{/sha}","trees_url":"https://api.github.com/repos/MAKOSCAFEE/oppia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MAKOSCAFEE/oppia/statuses/{sha}","languages_url":"https://api.github.com/repos/MAKOSCAFEE/oppia/languages","stargazers_url":"https://api.github.com/repos/MAKOSCAFEE/oppia/stargazers","contributors_url":"https://api.github.com/repos/MAKOSCAFEE/oppia/contributors","subscribers_url":"https://api.github.com/repos/MAKOSCAFEE/oppia/subscribers","subscription_url":"https://api.github.com/repos/MAKOSCAFEE/oppia/subscription","commits_url":"https://api.github.com/repos/MAKOSCAFEE/oppia/commits{/sha}","git_commits_url":"https://api.github.com/repos/MAKOSCAFEE/oppia/git/commits{/sha}","comments_url":"https://api.github.com/repos/MAKOSCAFEE/oppia/comments{/number}","issue_comment_url":"https://api.github.com/repos/MAKOSCAFEE/oppia/issues/comments{/number}","contents_url":"https://api.github.com/repos/MAKOSCAFEE/oppia/contents/{+path}","compare_url":"https://api.github.com/repos/MAKOSCAFEE/oppia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MAKOSCAFEE/oppia/merges","archive_url":"https://api.github.com/repos/MAKOSCAFEE/oppia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MAKOSCAFEE/oppia/downloads","issues_url":"https://api.github.com/repos/MAKOSCAFEE/oppia/issues{/number}","pulls_url":"https://api.github.com/repos/MAKOSCAFEE/oppia/pulls{/number}","milestones_url":"https://api.github.com/repos/MAKOSCAFEE/oppia/milestones{/number}","notifications_url":"https://api.github.com/repos/MAKOSCAFEE/oppia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MAKOSCAFEE/oppia/labels{/name}","releases_url":"https://api.github.com/repos/MAKOSCAFEE/oppia/releases{/id}","created_at":"2015-08-16T21:49:10Z","updated_at":"2015-08-16T21:49:11Z","pushed_at":"2015-12-03T19:11:18Z","git_url":"git://github.com/MAKOSCAFEE/oppia.git","ssh_url":"git@github.com:MAKOSCAFEE/oppia.git","clone_url":"https://github.com/MAKOSCAFEE/oppia.git","svn_url":"https://github.com/MAKOSCAFEE/oppia","homepage":"https://www.oppia.org","size":42983,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"oppia:develop","ref":"develop","sha":"db799bdc5db459e7f0b694510390cc1e5b420d66","user":{"login":"oppia","id":11620230,"avatar_url":"https://avatars.githubusercontent.com/u/11620230?v=3","gravatar_id":"","url":"https://api.github.com/users/oppia","html_url":"https://github.com/oppia","followers_url":"https://api.github.com/users/oppia/followers","following_url":"https://api.github.com/users/oppia/following{/other_user}","gists_url":"https://api.github.com/users/oppia/gists{/gist_id}","starred_url":"https://api.github.com/users/oppia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oppia/subscriptions","organizations_url":"https://api.github.com/users/oppia/orgs","repos_url":"https://api.github.com/users/oppia/repos","events_url":"https://api.github.com/users/oppia/events{/privacy}","received_events_url":"https://api.github.com/users/oppia/received_events","type":"Organization","site_admin":false},"repo":{"id":40687563,"name":"oppia","full_name":"oppia/oppia","owner":{"login":"oppia","id":11620230,"avatar_url":"https://avatars.githubusercontent.com/u/11620230?v=3","gravatar_id":"","url":"https://api.github.com/users/oppia","html_url":"https://github.com/oppia","followers_url":"https://api.github.com/users/oppia/followers","following_url":"https://api.github.com/users/oppia/following{/other_user}","gists_url":"https://api.github.com/users/oppia/gists{/gist_id}","starred_url":"https://api.github.com/users/oppia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oppia/subscriptions","organizations_url":"https://api.github.com/users/oppia/orgs","repos_url":"https://api.github.com/users/oppia/repos","events_url":"https://api.github.com/users/oppia/events{/privacy}","received_events_url":"https://api.github.com/users/oppia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/oppia/oppia","description":"Tool for collaboratively building interactive tutors.","fork":false,"url":"https://api.github.com/repos/oppia/oppia","forks_url":"https://api.github.com/repos/oppia/oppia/forks","keys_url":"https://api.github.com/repos/oppia/oppia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oppia/oppia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oppia/oppia/teams","hooks_url":"https://api.github.com/repos/oppia/oppia/hooks","issue_events_url":"https://api.github.com/repos/oppia/oppia/issues/events{/number}","events_url":"https://api.github.com/repos/oppia/oppia/events","assignees_url":"https://api.github.com/repos/oppia/oppia/assignees{/user}","branches_url":"https://api.github.com/repos/oppia/oppia/branches{/branch}","tags_url":"https://api.github.com/repos/oppia/oppia/tags","blobs_url":"https://api.github.com/repos/oppia/oppia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oppia/oppia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oppia/oppia/git/refs{/sha}","trees_url":"https://api.github.com/repos/oppia/oppia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oppia/oppia/statuses/{sha}","languages_url":"https://api.github.com/repos/oppia/oppia/languages","stargazers_url":"https://api.github.com/repos/oppia/oppia/stargazers","contributors_url":"https://api.github.com/repos/oppia/oppia/contributors","subscribers_url":"https://api.github.com/repos/oppia/oppia/subscribers","subscription_url":"https://api.github.com/repos/oppia/oppia/subscription","commits_url":"https://api.github.com/repos/oppia/oppia/commits{/sha}","git_commits_url":"https://api.github.com/repos/oppia/oppia/git/commits{/sha}","comments_url":"https://api.github.com/repos/oppia/oppia/comments{/number}","issue_comment_url":"https://api.github.com/repos/oppia/oppia/issues/comments{/number}","contents_url":"https://api.github.com/repos/oppia/oppia/contents/{+path}","compare_url":"https://api.github.com/repos/oppia/oppia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oppia/oppia/merges","archive_url":"https://api.github.com/repos/oppia/oppia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oppia/oppia/downloads","issues_url":"https://api.github.com/repos/oppia/oppia/issues{/number}","pulls_url":"https://api.github.com/repos/oppia/oppia/pulls{/number}","milestones_url":"https://api.github.com/repos/oppia/oppia/milestones{/number}","notifications_url":"https://api.github.com/repos/oppia/oppia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oppia/oppia/labels{/name}","releases_url":"https://api.github.com/repos/oppia/oppia/releases{/id}","created_at":"2015-08-14T00:16:14Z","updated_at":"2015-12-02T10:06:03Z","pushed_at":"2015-12-04T01:45:56Z","git_url":"git://github.com/oppia/oppia.git","ssh_url":"git@github.com:oppia/oppia.git","clone_url":"https://github.com/oppia/oppia.git","svn_url":"https://github.com/oppia/oppia","homepage":"https://www.oppia.org","size":44016,"stargazers_count":61,"watchers_count":61,"language":"Python","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":81,"mirror_url":null,"open_issues_count":232,"forks":81,"open_issues":232,"watchers":61,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/oppia/oppia/pulls/1187"},"html":{"href":"https://github.com/oppia/oppia/pull/1187"},"issue":{"href":"https://api.github.com/repos/oppia/oppia/issues/1187"},"comments":{"href":"https://api.github.com/repos/oppia/oppia/issues/1187/comments"},"review_comments":{"href":"https://api.github.com/repos/oppia/oppia/pulls/1187/comments"},"review_comment":{"href":"https://api.github.com/repos/oppia/oppia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/oppia/oppia/pulls/1187/commits"},"statuses":{"href":"https://api.github.com/repos/oppia/oppia/statuses/3608d5b3b41f6723938e452a39b53f7eb5642ca1"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"seanlip","id":10575562,"avatar_url":"https://avatars.githubusercontent.com/u/10575562?v=3","gravatar_id":"","url":"https://api.github.com/users/seanlip","html_url":"https://github.com/seanlip","followers_url":"https://api.github.com/users/seanlip/followers","following_url":"https://api.github.com/users/seanlip/following{/other_user}","gists_url":"https://api.github.com/users/seanlip/gists{/gist_id}","starred_url":"https://api.github.com/users/seanlip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanlip/subscriptions","organizations_url":"https://api.github.com/users/seanlip/orgs","repos_url":"https://api.github.com/users/seanlip/repos","events_url":"https://api.github.com/users/seanlip/events{/privacy}","received_events_url":"https://api.github.com/users/seanlip/received_events","type":"User","site_admin":false},"comments":11,"review_comments":14,"commits":7,"additions":134,"deletions":89,"changed_files":5}}