{"action":"created","comment":{"url":"https://api.github.com/repos/wix/wix-embedded-mysql/pulls/comments/34614314","id":34614314,"diff_hunk":"@@ -86,7 +77,13 @@\n             <groupId>mysql</groupId>\n             <artifactId>mysql-connector-java</artifactId>\n             <version>${mysql.connector.version}</version>\n-            <scope>provided</scope>\n+            <scope>test</scope>\n+        </dependency>\n+\n+        <dependency>\n+            <groupId>org.apache.commons</groupId>\n+            <artifactId>commons-dbcp2</artifactId>","path":"wix-embedded-mysql/pom.xml","position":60,"original_position":60,"commit_id":"47b8690fc92bf7a3f6e8f5e0921b4bad344da813","original_commit_id":"47b8690fc92bf7a3f6e8f5e0921b4bad344da813","user":{"login":"noam-almog","id":4091923,"avatar_url":"https://avatars.githubusercontent.com/u/4091923?v=3","gravatar_id":"","url":"https://api.github.com/users/noam-almog","html_url":"https://github.com/noam-almog","followers_url":"https://api.github.com/users/noam-almog/followers","following_url":"https://api.github.com/users/noam-almog/following{/other_user}","gists_url":"https://api.github.com/users/noam-almog/gists{/gist_id}","starred_url":"https://api.github.com/users/noam-almog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noam-almog/subscriptions","organizations_url":"https://api.github.com/users/noam-almog/orgs","repos_url":"https://api.github.com/users/noam-almog/repos","events_url":"https://api.github.com/users/noam-almog/events{/privacy}","received_events_url":"https://api.github.com/users/noam-almog/received_events","type":"User","site_admin":false},"body":"why do we need this library ?","created_at":"2015-07-14T20:20:29Z","updated_at":"2015-07-14T20:20:29Z","html_url":"https://github.com/wix/wix-embedded-mysql/pull/23#discussion_r34614314","pull_request_url":"https://api.github.com/repos/wix/wix-embedded-mysql/pulls/23","_links":{"self":{"href":"https://api.github.com/repos/wix/wix-embedded-mysql/pulls/comments/34614314"},"html":{"href":"https://github.com/wix/wix-embedded-mysql/pull/23#discussion_r34614314"},"pull_request":{"href":"https://api.github.com/repos/wix/wix-embedded-mysql/pulls/23"}}},"pull_request":{"url":"https://api.github.com/repos/wix/wix-embedded-mysql/pulls/23","id":39177906,"html_url":"https://github.com/wix/wix-embedded-mysql/pull/23","diff_url":"https://github.com/wix/wix-embedded-mysql/pull/23.diff","patch_url":"https://github.com/wix/wix-embedded-mysql/pull/23.patch","issue_url":"https://api.github.com/repos/wix/wix-embedded-mysql/issues/23","number":23,"state":"open","locked":false,"title":"Version 1.1.0","user":{"login":"viliusl","id":871778,"avatar_url":"https://avatars.githubusercontent.com/u/871778?v=3","gravatar_id":"","url":"https://api.github.com/users/viliusl","html_url":"https://github.com/viliusl","followers_url":"https://api.github.com/users/viliusl/followers","following_url":"https://api.github.com/users/viliusl/following{/other_user}","gists_url":"https://api.github.com/users/viliusl/gists{/gist_id}","starred_url":"https://api.github.com/users/viliusl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/viliusl/subscriptions","organizations_url":"https://api.github.com/users/viliusl/orgs","repos_url":"https://api.github.com/users/viliusl/repos","events_url":"https://api.github.com/users/viliusl/events{/privacy}","received_events_url":"https://api.github.com/users/viliusl/received_events","type":"User","site_admin":false},"body":"@noam-almog \r\n\r\nSo this is my proposal - I adopted some of ideas you provided after our discussion, but I kept some of mine.\r\n\r\nPlease see:\r\n- UsageExamplesTest for supported use cases/variations;\r\n- TODO.md for some motivation + ideas on possible extensions and how I see them done;\r\n- https://github.com/wix/action-triggers-server/commit/b6d32229168b40ca02f3a1fa9881d34f1b40827a for a example of how client code looks like after migration.\r\n\r\nOtherwise I see this as mostly ready for mainstream. Maybe I would add some more tests, come javadocs, move some stuff, etc. but otherwise I think it's ok now.\r\n\r\nAlso please behave - review and not commit:)","created_at":"2015-07-03T14:05:14Z","updated_at":"2015-07-14T20:20:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ad2c1f1b259d20a416ea05e2b1fa808bc2f246d9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/wix/wix-embedded-mysql/pulls/23/commits","review_comments_url":"https://api.github.com/repos/wix/wix-embedded-mysql/pulls/23/comments","review_comment_url":"https://api.github.com/repos/wix/wix-embedded-mysql/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wix/wix-embedded-mysql/issues/23/comments","statuses_url":"https://api.github.com/repos/wix/wix-embedded-mysql/statuses/47b8690fc92bf7a3f6e8f5e0921b4bad344da813","head":{"label":"wix:version-1.1.0","ref":"version-1.1.0","sha":"47b8690fc92bf7a3f6e8f5e0921b4bad344da813","user":{"login":"wix","id":686511,"avatar_url":"https://avatars.githubusercontent.com/u/686511?v=3","gravatar_id":"","url":"https://api.github.com/users/wix","html_url":"https://github.com/wix","followers_url":"https://api.github.com/users/wix/followers","following_url":"https://api.github.com/users/wix/following{/other_user}","gists_url":"https://api.github.com/users/wix/gists{/gist_id}","starred_url":"https://api.github.com/users/wix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wix/subscriptions","organizations_url":"https://api.github.com/users/wix/orgs","repos_url":"https://api.github.com/users/wix/repos","events_url":"https://api.github.com/users/wix/events{/privacy}","received_events_url":"https://api.github.com/users/wix/received_events","type":"Organization","site_admin":false},"repo":{"id":24411771,"name":"wix-embedded-mysql","full_name":"wix/wix-embedded-mysql","owner":{"login":"wix","id":686511,"avatar_url":"https://avatars.githubusercontent.com/u/686511?v=3","gravatar_id":"","url":"https://api.github.com/users/wix","html_url":"https://github.com/wix","followers_url":"https://api.github.com/users/wix/followers","following_url":"https://api.github.com/users/wix/following{/other_user}","gists_url":"https://api.github.com/users/wix/gists{/gist_id}","starred_url":"https://api.github.com/users/wix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wix/subscriptions","organizations_url":"https://api.github.com/users/wix/orgs","repos_url":"https://api.github.com/users/wix/repos","events_url":"https://api.github.com/users/wix/events{/privacy}","received_events_url":"https://api.github.com/users/wix/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wix/wix-embedded-mysql","description":"embedded mysql based on https://github.com/flapdoodle-oss/de.flapdoodle.embed.process","fork":false,"url":"https://api.github.com/repos/wix/wix-embedded-mysql","forks_url":"https://api.github.com/repos/wix/wix-embedded-mysql/forks","keys_url":"https://api.github.com/repos/wix/wix-embedded-mysql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wix/wix-embedded-mysql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wix/wix-embedded-mysql/teams","hooks_url":"https://api.github.com/repos/wix/wix-embedded-mysql/hooks","issue_events_url":"https://api.github.com/repos/wix/wix-embedded-mysql/issues/events{/number}","events_url":"https://api.github.com/repos/wix/wix-embedded-mysql/events","assignees_url":"https://api.github.com/repos/wix/wix-embedded-mysql/assignees{/user}","branches_url":"https://api.github.com/repos/wix/wix-embedded-mysql/branches{/branch}","tags_url":"https://api.github.com/repos/wix/wix-embedded-mysql/tags","blobs_url":"https://api.github.com/repos/wix/wix-embedded-mysql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wix/wix-embedded-mysql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wix/wix-embedded-mysql/git/refs{/sha}","trees_url":"https://api.github.com/repos/wix/wix-embedded-mysql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wix/wix-embedded-mysql/statuses/{sha}","languages_url":"https://api.github.com/repos/wix/wix-embedded-mysql/languages","stargazers_url":"https://api.github.com/repos/wix/wix-embedded-mysql/stargazers","contributors_url":"https://api.github.com/repos/wix/wix-embedded-mysql/contributors","subscribers_url":"https://api.github.com/repos/wix/wix-embedded-mysql/subscribers","subscription_url":"https://api.github.com/repos/wix/wix-embedded-mysql/subscription","commits_url":"https://api.github.com/repos/wix/wix-embedded-mysql/commits{/sha}","git_commits_url":"https://api.github.com/repos/wix/wix-embedded-mysql/git/commits{/sha}","comments_url":"https://api.github.com/repos/wix/wix-embedded-mysql/comments{/number}","issue_comment_url":"https://api.github.com/repos/wix/wix-embedded-mysql/issues/comments{/number}","contents_url":"https://api.github.com/repos/wix/wix-embedded-mysql/contents/{+path}","compare_url":"https://api.github.com/repos/wix/wix-embedded-mysql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wix/wix-embedded-mysql/merges","archive_url":"https://api.github.com/repos/wix/wix-embedded-mysql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wix/wix-embedded-mysql/downloads","issues_url":"https://api.github.com/repos/wix/wix-embedded-mysql/issues{/number}","pulls_url":"https://api.github.com/repos/wix/wix-embedded-mysql/pulls{/number}","milestones_url":"https://api.github.com/repos/wix/wix-embedded-mysql/milestones{/number}","notifications_url":"https://api.github.com/repos/wix/wix-embedded-mysql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wix/wix-embedded-mysql/labels{/name}","releases_url":"https://api.github.com/repos/wix/wix-embedded-mysql/releases{/id}","created_at":"2014-09-24T11:07:38Z","updated_at":"2015-05-04T22:20:06Z","pushed_at":"2015-07-08T13:41:13Z","git_url":"git://github.com/wix/wix-embedded-mysql.git","ssh_url":"git@github.com:wix/wix-embedded-mysql.git","clone_url":"https://github.com/wix/wix-embedded-mysql.git","svn_url":"https://github.com/wix/wix-embedded-mysql","homepage":null,"size":1302,"stargazers_count":4,"watchers_count":4,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":5,"forks":1,"open_issues":5,"watchers":4,"default_branch":"master"}},"base":{"label":"wix:master","ref":"master","sha":"1dba317f0110c681fb0e2fca2f88e4e9dc59f6ae","user":{"login":"wix","id":686511,"avatar_url":"https://avatars.githubusercontent.com/u/686511?v=3","gravatar_id":"","url":"https://api.github.com/users/wix","html_url":"https://github.com/wix","followers_url":"https://api.github.com/users/wix/followers","following_url":"https://api.github.com/users/wix/following{/other_user}","gists_url":"https://api.github.com/users/wix/gists{/gist_id}","starred_url":"https://api.github.com/users/wix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wix/subscriptions","organizations_url":"https://api.github.com/users/wix/orgs","repos_url":"https://api.github.com/users/wix/repos","events_url":"https://api.github.com/users/wix/events{/privacy}","received_events_url":"https://api.github.com/users/wix/received_events","type":"Organization","site_admin":false},"repo":{"id":24411771,"name":"wix-embedded-mysql","full_name":"wix/wix-embedded-mysql","owner":{"login":"wix","id":686511,"avatar_url":"https://avatars.githubusercontent.com/u/686511?v=3","gravatar_id":"","url":"https://api.github.com/users/wix","html_url":"https://github.com/wix","followers_url":"https://api.github.com/users/wix/followers","following_url":"https://api.github.com/users/wix/following{/other_user}","gists_url":"https://api.github.com/users/wix/gists{/gist_id}","starred_url":"https://api.github.com/users/wix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wix/subscriptions","organizations_url":"https://api.github.com/users/wix/orgs","repos_url":"https://api.github.com/users/wix/repos","events_url":"https://api.github.com/users/wix/events{/privacy}","received_events_url":"https://api.github.com/users/wix/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wix/wix-embedded-mysql","description":"embedded mysql based on https://github.com/flapdoodle-oss/de.flapdoodle.embed.process","fork":false,"url":"https://api.github.com/repos/wix/wix-embedded-mysql","forks_url":"https://api.github.com/repos/wix/wix-embedded-mysql/forks","keys_url":"https://api.github.com/repos/wix/wix-embedded-mysql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wix/wix-embedded-mysql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wix/wix-embedded-mysql/teams","hooks_url":"https://api.github.com/repos/wix/wix-embedded-mysql/hooks","issue_events_url":"https://api.github.com/repos/wix/wix-embedded-mysql/issues/events{/number}","events_url":"https://api.github.com/repos/wix/wix-embedded-mysql/events","assignees_url":"https://api.github.com/repos/wix/wix-embedded-mysql/assignees{/user}","branches_url":"https://api.github.com/repos/wix/wix-embedded-mysql/branches{/branch}","tags_url":"https://api.github.com/repos/wix/wix-embedded-mysql/tags","blobs_url":"https://api.github.com/repos/wix/wix-embedded-mysql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wix/wix-embedded-mysql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wix/wix-embedded-mysql/git/refs{/sha}","trees_url":"https://api.github.com/repos/wix/wix-embedded-mysql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wix/wix-embedded-mysql/statuses/{sha}","languages_url":"https://api.github.com/repos/wix/wix-embedded-mysql/languages","stargazers_url":"https://api.github.com/repos/wix/wix-embedded-mysql/stargazers","contributors_url":"https://api.github.com/repos/wix/wix-embedded-mysql/contributors","subscribers_url":"https://api.github.com/repos/wix/wix-embedded-mysql/subscribers","subscription_url":"https://api.github.com/repos/wix/wix-embedded-mysql/subscription","commits_url":"https://api.github.com/repos/wix/wix-embedded-mysql/commits{/sha}","git_commits_url":"https://api.github.com/repos/wix/wix-embedded-mysql/git/commits{/sha}","comments_url":"https://api.github.com/repos/wix/wix-embedded-mysql/comments{/number}","issue_comment_url":"https://api.github.com/repos/wix/wix-embedded-mysql/issues/comments{/number}","contents_url":"https://api.github.com/repos/wix/wix-embedded-mysql/contents/{+path}","compare_url":"https://api.github.com/repos/wix/wix-embedded-mysql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wix/wix-embedded-mysql/merges","archive_url":"https://api.github.com/repos/wix/wix-embedded-mysql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wix/wix-embedded-mysql/downloads","issues_url":"https://api.github.com/repos/wix/wix-embedded-mysql/issues{/number}","pulls_url":"https://api.github.com/repos/wix/wix-embedded-mysql/pulls{/number}","milestones_url":"https://api.github.com/repos/wix/wix-embedded-mysql/milestones{/number}","notifications_url":"https://api.github.com/repos/wix/wix-embedded-mysql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wix/wix-embedded-mysql/labels{/name}","releases_url":"https://api.github.com/repos/wix/wix-embedded-mysql/releases{/id}","created_at":"2014-09-24T11:07:38Z","updated_at":"2015-05-04T22:20:06Z","pushed_at":"2015-07-08T13:41:13Z","git_url":"git://github.com/wix/wix-embedded-mysql.git","ssh_url":"git@github.com:wix/wix-embedded-mysql.git","clone_url":"https://github.com/wix/wix-embedded-mysql.git","svn_url":"https://github.com/wix/wix-embedded-mysql","homepage":null,"size":1302,"stargazers_count":4,"watchers_count":4,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":5,"forks":1,"open_issues":5,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wix/wix-embedded-mysql/pulls/23"},"html":{"href":"https://github.com/wix/wix-embedded-mysql/pull/23"},"issue":{"href":"https://api.github.com/repos/wix/wix-embedded-mysql/issues/23"},"comments":{"href":"https://api.github.com/repos/wix/wix-embedded-mysql/issues/23/comments"},"review_comments":{"href":"https://api.github.com/repos/wix/wix-embedded-mysql/pulls/23/comments"},"review_comment":{"href":"https://api.github.com/repos/wix/wix-embedded-mysql/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wix/wix-embedded-mysql/pulls/23/commits"},"statuses":{"href":"https://api.github.com/repos/wix/wix-embedded-mysql/statuses/47b8690fc92bf7a3f6e8f5e0921b4bad344da813"}}}}