{"action":"created","comment":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/47218414","id":47218414,"diff_hunk":"@@ -104,7 +108,7 @@ BitcoinGUI::BitcoinGUI(const PlatformStyle *platformStyle, const NetworkStyle *n\n {\n     GUIUtil::restoreWindowGeometry(\"nWindow\", QSize(850, 550), this);\n \n-    QString windowTitle = tr(\"Bitcoin Core\") + \" - \";\n+    QString windowTitle = tr(PACKAGE_NAME) + \" - \";","path":"src/qt/bitcoingui.cpp","position":16,"original_position":16,"commit_id":"648e9649caf81218470706a66044b528adb589b0","original_commit_id":"648e9649caf81218470706a66044b528adb589b0","user":{"login":"laanwj","id":126646,"avatar_url":"https://avatars.githubusercontent.com/u/126646?v=3","gravatar_id":"","url":"https://api.github.com/users/laanwj","html_url":"https://github.com/laanwj","followers_url":"https://api.github.com/users/laanwj/followers","following_url":"https://api.github.com/users/laanwj/following{/other_user}","gists_url":"https://api.github.com/users/laanwj/gists{/gist_id}","starred_url":"https://api.github.com/users/laanwj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laanwj/subscriptions","organizations_url":"https://api.github.com/users/laanwj/orgs","repos_url":"https://api.github.com/users/laanwj/repos","events_url":"https://api.github.com/users/laanwj/events{/privacy}","received_events_url":"https://api.github.com/users/laanwj/received_events","type":"User","site_admin":false},"body":"Oh, right, does this work then? Does qtranslate pick up the string out of `tr(PACKAGE_NAME)`, even though it's a macro? Same for `_(PACKAGE_NAME)` in gettext? \r\n","created_at":"2015-12-10T12:06:36Z","updated_at":"2015-12-10T12:06:36Z","html_url":"https://github.com/bitcoin/bitcoin/pull/7192#discussion_r47218414","pull_request_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/7192","_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/47218414"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/7192#discussion_r47218414"},"pull_request":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/7192"}}},"pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/7192","id":53108907,"html_url":"https://github.com/bitcoin/bitcoin/pull/7192","diff_url":"https://github.com/bitcoin/bitcoin/pull/7192.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/7192.patch","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/7192","number":7192,"state":"open","locked":false,"title":"Unify product name to as few places as possible without major changes","user":{"login":"luke-jr","id":1095675,"avatar_url":"https://avatars.githubusercontent.com/u/1095675?v=3","gravatar_id":"","url":"https://api.github.com/users/luke-jr","html_url":"https://github.com/luke-jr","followers_url":"https://api.github.com/users/luke-jr/followers","following_url":"https://api.github.com/users/luke-jr/following{/other_user}","gists_url":"https://api.github.com/users/luke-jr/gists{/gist_id}","starred_url":"https://api.github.com/users/luke-jr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luke-jr/subscriptions","organizations_url":"https://api.github.com/users/luke-jr/orgs","repos_url":"https://api.github.com/users/luke-jr/repos","events_url":"https://api.github.com/users/luke-jr/events{/privacy}","received_events_url":"https://api.github.com/users/luke-jr/received_events","type":"User","site_admin":false},"body":"This should help keep the software name consistent within translations (Bitcoin Kern, Nucleul Bitcoin, etc) or forks (Bitcoin LJR, etc).","created_at":"2015-12-09T11:50:29Z","updated_at":"2015-12-10T12:06:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9f9c0b94d84a6b6ade1006492fd8dbd61ad42510","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/7192/commits","review_comments_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/7192/comments","review_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/7192/comments","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/648e9649caf81218470706a66044b528adb589b0","head":{"label":"luke-jr:single_prodname","ref":"single_prodname","sha":"648e9649caf81218470706a66044b528adb589b0","user":{"login":"luke-jr","id":1095675,"avatar_url":"https://avatars.githubusercontent.com/u/1095675?v=3","gravatar_id":"","url":"https://api.github.com/users/luke-jr","html_url":"https://github.com/luke-jr","followers_url":"https://api.github.com/users/luke-jr/followers","following_url":"https://api.github.com/users/luke-jr/following{/other_user}","gists_url":"https://api.github.com/users/luke-jr/gists{/gist_id}","starred_url":"https://api.github.com/users/luke-jr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luke-jr/subscriptions","organizations_url":"https://api.github.com/users/luke-jr/orgs","repos_url":"https://api.github.com/users/luke-jr/repos","events_url":"https://api.github.com/users/luke-jr/events{/privacy}","received_events_url":"https://api.github.com/users/luke-jr/received_events","type":"User","site_admin":false},"repo":{"id":2514537,"name":"bitcoin","full_name":"luke-jr/bitcoin","owner":{"login":"luke-jr","id":1095675,"avatar_url":"https://avatars.githubusercontent.com/u/1095675?v=3","gravatar_id":"","url":"https://api.github.com/users/luke-jr","html_url":"https://github.com/luke-jr","followers_url":"https://api.github.com/users/luke-jr/followers","following_url":"https://api.github.com/users/luke-jr/following{/other_user}","gists_url":"https://api.github.com/users/luke-jr/gists{/gist_id}","starred_url":"https://api.github.com/users/luke-jr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luke-jr/subscriptions","organizations_url":"https://api.github.com/users/luke-jr/orgs","repos_url":"https://api.github.com/users/luke-jr/repos","events_url":"https://api.github.com/users/luke-jr/events{/privacy}","received_events_url":"https://api.github.com/users/luke-jr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/luke-jr/bitcoin","description":"Bitcoin integration/staging tree","fork":true,"url":"https://api.github.com/repos/luke-jr/bitcoin","forks_url":"https://api.github.com/repos/luke-jr/bitcoin/forks","keys_url":"https://api.github.com/repos/luke-jr/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/luke-jr/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/luke-jr/bitcoin/teams","hooks_url":"https://api.github.com/repos/luke-jr/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/luke-jr/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/luke-jr/bitcoin/events","assignees_url":"https://api.github.com/repos/luke-jr/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/luke-jr/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/luke-jr/bitcoin/tags","blobs_url":"https://api.github.com/repos/luke-jr/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/luke-jr/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/luke-jr/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/luke-jr/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/luke-jr/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/luke-jr/bitcoin/languages","stargazers_url":"https://api.github.com/repos/luke-jr/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/luke-jr/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/luke-jr/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/luke-jr/bitcoin/subscription","commits_url":"https://api.github.com/repos/luke-jr/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/luke-jr/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/luke-jr/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/luke-jr/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/luke-jr/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/luke-jr/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/luke-jr/bitcoin/merges","archive_url":"https://api.github.com/repos/luke-jr/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/luke-jr/bitcoin/downloads","issues_url":"https://api.github.com/repos/luke-jr/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/luke-jr/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/luke-jr/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/luke-jr/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/luke-jr/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/luke-jr/bitcoin/releases{/id}","created_at":"2011-10-04T20:22:23Z","updated_at":"2015-11-27T06:13:32Z","pushed_at":"2015-12-10T09:24:48Z","git_url":"git://github.com/luke-jr/bitcoin.git","ssh_url":"git@github.com:luke-jr/bitcoin.git","clone_url":"https://github.com/luke-jr/bitcoin.git","svn_url":"https://github.com/luke-jr/bitcoin","homepage":"http://www.bitcoin.org","size":73113,"stargazers_count":6,"watchers_count":6,"language":"C++","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":6,"default_branch":"0.11.x-ljrP"}},"base":{"label":"bitcoin:master","ref":"master","sha":"00b4b8d1c47a2189d085140cfb45be492de16db5","user":{"login":"bitcoin","id":528860,"avatar_url":"https://avatars.githubusercontent.com/u/528860?v=3","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"repo":{"id":1181927,"name":"bitcoin","full_name":"bitcoin/bitcoin","owner":{"login":"bitcoin","id":528860,"avatar_url":"https://avatars.githubusercontent.com/u/528860?v=3","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bitcoin/bitcoin","description":"Bitcoin Core integration/staging tree","fork":false,"url":"https://api.github.com/repos/bitcoin/bitcoin","forks_url":"https://api.github.com/repos/bitcoin/bitcoin/forks","keys_url":"https://api.github.com/repos/bitcoin/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoin/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoin/bitcoin/teams","hooks_url":"https://api.github.com/repos/bitcoin/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoin/bitcoin/events","assignees_url":"https://api.github.com/repos/bitcoin/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoin/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoin/bitcoin/tags","blobs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoin/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoin/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoin/bitcoin/languages","stargazers_url":"https://api.github.com/repos/bitcoin/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/bitcoin/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/bitcoin/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/bitcoin/bitcoin/subscription","commits_url":"https://api.github.com/repos/bitcoin/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoin/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoin/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoin/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoin/bitcoin/merges","archive_url":"https://api.github.com/repos/bitcoin/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoin/bitcoin/downloads","issues_url":"https://api.github.com/repos/bitcoin/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoin/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/bitcoin/bitcoin/releases{/id}","created_at":"2010-12-19T15:16:43Z","updated_at":"2015-12-10T11:56:54Z","pushed_at":"2015-12-10T11:15:08Z","git_url":"git://github.com/bitcoin/bitcoin.git","ssh_url":"git@github.com:bitcoin/bitcoin.git","clone_url":"https://github.com/bitcoin/bitcoin.git","svn_url":"https://github.com/bitcoin/bitcoin","homepage":"https://bitcoin.org/en/download","size":100257,"stargazers_count":7957,"watchers_count":7957,"language":"C++","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":5473,"mirror_url":null,"open_issues_count":416,"forks":5473,"open_issues":416,"watchers":7957,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/7192"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/7192"},"issue":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/7192"},"comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/7192/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/7192/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/7192/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoin/bitcoin/statuses/648e9649caf81218470706a66044b528adb589b0"}}}}