{"action":"closed","number":2356,"pull_request":{"url":"https://api.github.com/repos/radare/radare2/pulls/2356","id":33109508,"html_url":"https://github.com/radare/radare2/pull/2356","diff_url":"https://github.com/radare/radare2/pull/2356.diff","patch_url":"https://github.com/radare/radare2/pull/2356.patch","issue_url":"https://api.github.com/repos/radare/radare2/issues/2356","number":2356,"state":"closed","locked":false,"title":"Two bugfixes for register hooks","user":{"login":"dkreuter","id":15789,"avatar_url":"https://avatars.githubusercontent.com/u/15789?v=3","gravatar_id":"","url":"https://api.github.com/users/dkreuter","html_url":"https://github.com/dkreuter","followers_url":"https://api.github.com/users/dkreuter/followers","following_url":"https://api.github.com/users/dkreuter/following{/other_user}","gists_url":"https://api.github.com/users/dkreuter/gists{/gist_id}","starred_url":"https://api.github.com/users/dkreuter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkreuter/subscriptions","organizations_url":"https://api.github.com/users/dkreuter/orgs","repos_url":"https://api.github.com/users/dkreuter/repos","events_url":"https://api.github.com/users/dkreuter/events{/privacy}","received_events_url":"https://api.github.com/users/dkreuter/received_events","type":"User","site_admin":false},"body":"r_anal_esil_reg_write swallowed writes when a write hook was present, but returned zero which should signal that the hook was passive.\r\ntrace_hook_reg_read logged the values before considering the effects of other hooks. Also, failure of reg_read was ignored.\r\n\r\nAlso added a local variable in r_anal_esil_reg_read to remove the burden of null-check on third argument from [hook_]reg_read implementations.","created_at":"2015-04-11T20:32:24Z","updated_at":"2015-04-11T23:14:45Z","closed_at":"2015-04-11T23:14:45Z","merged_at":null,"merge_commit_sha":"dff852cd819b7e553debe4268661bf05e48fcca9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/radare/radare2/pulls/2356/commits","review_comments_url":"https://api.github.com/repos/radare/radare2/pulls/2356/comments","review_comment_url":"https://api.github.com/repos/radare/radare2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/radare/radare2/issues/2356/comments","statuses_url":"https://api.github.com/repos/radare/radare2/statuses/4f4200373344bb657482b4233df07dfbe7a1febc","head":{"label":"dkreuter:reg-hook-fix","ref":"reg-hook-fix","sha":"4f4200373344bb657482b4233df07dfbe7a1febc","user":{"login":"dkreuter","id":15789,"avatar_url":"https://avatars.githubusercontent.com/u/15789?v=3","gravatar_id":"","url":"https://api.github.com/users/dkreuter","html_url":"https://github.com/dkreuter","followers_url":"https://api.github.com/users/dkreuter/followers","following_url":"https://api.github.com/users/dkreuter/following{/other_user}","gists_url":"https://api.github.com/users/dkreuter/gists{/gist_id}","starred_url":"https://api.github.com/users/dkreuter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkreuter/subscriptions","organizations_url":"https://api.github.com/users/dkreuter/orgs","repos_url":"https://api.github.com/users/dkreuter/repos","events_url":"https://api.github.com/users/dkreuter/events{/privacy}","received_events_url":"https://api.github.com/users/dkreuter/received_events","type":"User","site_admin":false},"repo":{"id":32796030,"name":"radare2","full_name":"dkreuter/radare2","owner":{"login":"dkreuter","id":15789,"avatar_url":"https://avatars.githubusercontent.com/u/15789?v=3","gravatar_id":"","url":"https://api.github.com/users/dkreuter","html_url":"https://github.com/dkreuter","followers_url":"https://api.github.com/users/dkreuter/followers","following_url":"https://api.github.com/users/dkreuter/following{/other_user}","gists_url":"https://api.github.com/users/dkreuter/gists{/gist_id}","starred_url":"https://api.github.com/users/dkreuter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkreuter/subscriptions","organizations_url":"https://api.github.com/users/dkreuter/orgs","repos_url":"https://api.github.com/users/dkreuter/repos","events_url":"https://api.github.com/users/dkreuter/events{/privacy}","received_events_url":"https://api.github.com/users/dkreuter/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dkreuter/radare2","description":"unix-like reverse engineering framework and commandline tools","fork":true,"url":"https://api.github.com/repos/dkreuter/radare2","forks_url":"https://api.github.com/repos/dkreuter/radare2/forks","keys_url":"https://api.github.com/repos/dkreuter/radare2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dkreuter/radare2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dkreuter/radare2/teams","hooks_url":"https://api.github.com/repos/dkreuter/radare2/hooks","issue_events_url":"https://api.github.com/repos/dkreuter/radare2/issues/events{/number}","events_url":"https://api.github.com/repos/dkreuter/radare2/events","assignees_url":"https://api.github.com/repos/dkreuter/radare2/assignees{/user}","branches_url":"https://api.github.com/repos/dkreuter/radare2/branches{/branch}","tags_url":"https://api.github.com/repos/dkreuter/radare2/tags","blobs_url":"https://api.github.com/repos/dkreuter/radare2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dkreuter/radare2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dkreuter/radare2/git/refs{/sha}","trees_url":"https://api.github.com/repos/dkreuter/radare2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dkreuter/radare2/statuses/{sha}","languages_url":"https://api.github.com/repos/dkreuter/radare2/languages","stargazers_url":"https://api.github.com/repos/dkreuter/radare2/stargazers","contributors_url":"https://api.github.com/repos/dkreuter/radare2/contributors","subscribers_url":"https://api.github.com/repos/dkreuter/radare2/subscribers","subscription_url":"https://api.github.com/repos/dkreuter/radare2/subscription","commits_url":"https://api.github.com/repos/dkreuter/radare2/commits{/sha}","git_commits_url":"https://api.github.com/repos/dkreuter/radare2/git/commits{/sha}","comments_url":"https://api.github.com/repos/dkreuter/radare2/comments{/number}","issue_comment_url":"https://api.github.com/repos/dkreuter/radare2/issues/comments{/number}","contents_url":"https://api.github.com/repos/dkreuter/radare2/contents/{+path}","compare_url":"https://api.github.com/repos/dkreuter/radare2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dkreuter/radare2/merges","archive_url":"https://api.github.com/repos/dkreuter/radare2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dkreuter/radare2/downloads","issues_url":"https://api.github.com/repos/dkreuter/radare2/issues{/number}","pulls_url":"https://api.github.com/repos/dkreuter/radare2/pulls{/number}","milestones_url":"https://api.github.com/repos/dkreuter/radare2/milestones{/number}","notifications_url":"https://api.github.com/repos/dkreuter/radare2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dkreuter/radare2/labels{/name}","releases_url":"https://api.github.com/repos/dkreuter/radare2/releases{/id}","created_at":"2015-03-24T12:05:33Z","updated_at":"2015-04-11T22:51:26Z","pushed_at":"2015-04-11T22:51:26Z","git_url":"git://github.com/dkreuter/radare2.git","ssh_url":"git@github.com:dkreuter/radare2.git","clone_url":"https://github.com/dkreuter/radare2.git","svn_url":"https://github.com/dkreuter/radare2","homepage":"http://www.radare.org/","size":45610,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"radare:master","ref":"master","sha":"882a43994c8ed5987f843a84e1289ae1bd9651f4","user":{"login":"radare","id":917142,"avatar_url":"https://avatars.githubusercontent.com/u/917142?v=3","gravatar_id":"","url":"https://api.github.com/users/radare","html_url":"https://github.com/radare","followers_url":"https://api.github.com/users/radare/followers","following_url":"https://api.github.com/users/radare/following{/other_user}","gists_url":"https://api.github.com/users/radare/gists{/gist_id}","starred_url":"https://api.github.com/users/radare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radare/subscriptions","organizations_url":"https://api.github.com/users/radare/orgs","repos_url":"https://api.github.com/users/radare/repos","events_url":"https://api.github.com/users/radare/events{/privacy}","received_events_url":"https://api.github.com/users/radare/received_events","type":"User","site_admin":false},"repo":{"id":4869294,"name":"radare2","full_name":"radare/radare2","owner":{"login":"radare","id":917142,"avatar_url":"https://avatars.githubusercontent.com/u/917142?v=3","gravatar_id":"","url":"https://api.github.com/users/radare","html_url":"https://github.com/radare","followers_url":"https://api.github.com/users/radare/followers","following_url":"https://api.github.com/users/radare/following{/other_user}","gists_url":"https://api.github.com/users/radare/gists{/gist_id}","starred_url":"https://api.github.com/users/radare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radare/subscriptions","organizations_url":"https://api.github.com/users/radare/orgs","repos_url":"https://api.github.com/users/radare/repos","events_url":"https://api.github.com/users/radare/events{/privacy}","received_events_url":"https://api.github.com/users/radare/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/radare/radare2","description":"unix-like reverse engineering framework and commandline tools","fork":false,"url":"https://api.github.com/repos/radare/radare2","forks_url":"https://api.github.com/repos/radare/radare2/forks","keys_url":"https://api.github.com/repos/radare/radare2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/radare/radare2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/radare/radare2/teams","hooks_url":"https://api.github.com/repos/radare/radare2/hooks","issue_events_url":"https://api.github.com/repos/radare/radare2/issues/events{/number}","events_url":"https://api.github.com/repos/radare/radare2/events","assignees_url":"https://api.github.com/repos/radare/radare2/assignees{/user}","branches_url":"https://api.github.com/repos/radare/radare2/branches{/branch}","tags_url":"https://api.github.com/repos/radare/radare2/tags","blobs_url":"https://api.github.com/repos/radare/radare2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/radare/radare2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/radare/radare2/git/refs{/sha}","trees_url":"https://api.github.com/repos/radare/radare2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/radare/radare2/statuses/{sha}","languages_url":"https://api.github.com/repos/radare/radare2/languages","stargazers_url":"https://api.github.com/repos/radare/radare2/stargazers","contributors_url":"https://api.github.com/repos/radare/radare2/contributors","subscribers_url":"https://api.github.com/repos/radare/radare2/subscribers","subscription_url":"https://api.github.com/repos/radare/radare2/subscription","commits_url":"https://api.github.com/repos/radare/radare2/commits{/sha}","git_commits_url":"https://api.github.com/repos/radare/radare2/git/commits{/sha}","comments_url":"https://api.github.com/repos/radare/radare2/comments{/number}","issue_comment_url":"https://api.github.com/repos/radare/radare2/issues/comments{/number}","contents_url":"https://api.github.com/repos/radare/radare2/contents/{+path}","compare_url":"https://api.github.com/repos/radare/radare2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/radare/radare2/merges","archive_url":"https://api.github.com/repos/radare/radare2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/radare/radare2/downloads","issues_url":"https://api.github.com/repos/radare/radare2/issues{/number}","pulls_url":"https://api.github.com/repos/radare/radare2/pulls{/number}","milestones_url":"https://api.github.com/repos/radare/radare2/milestones{/number}","notifications_url":"https://api.github.com/repos/radare/radare2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/radare/radare2/labels{/name}","releases_url":"https://api.github.com/repos/radare/radare2/releases{/id}","created_at":"2012-07-03T07:42:26Z","updated_at":"2015-04-11T23:14:41Z","pushed_at":"2015-04-11T23:14:40Z","git_url":"git://github.com/radare/radare2.git","ssh_url":"git@github.com:radare/radare2.git","clone_url":"https://github.com/radare/radare2.git","svn_url":"https://github.com/radare/radare2","homepage":"http://www.radare.org/","size":70293,"stargazers_count":1092,"watchers_count":1092,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":242,"mirror_url":null,"open_issues_count":363,"forks":242,"open_issues":363,"watchers":1092,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/radare/radare2/pulls/2356"},"html":{"href":"https://github.com/radare/radare2/pull/2356"},"issue":{"href":"https://api.github.com/repos/radare/radare2/issues/2356"},"comments":{"href":"https://api.github.com/repos/radare/radare2/issues/2356/comments"},"review_comments":{"href":"https://api.github.com/repos/radare/radare2/pulls/2356/comments"},"review_comment":{"href":"https://api.github.com/repos/radare/radare2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/radare/radare2/pulls/2356/commits"},"statuses":{"href":"https://api.github.com/repos/radare/radare2/statuses/4f4200373344bb657482b4233df07dfbe7a1febc"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"commits":1,"additions":18,"deletions":14,"changed_files":2}}