{"action":"closed","number":388,"pull_request":{"url":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/388","id":25637791,"html_url":"https://github.com/nhibernate/nhibernate-core/pull/388","diff_url":"https://github.com/nhibernate/nhibernate-core/pull/388.diff","patch_url":"https://github.com/nhibernate/nhibernate-core/pull/388.patch","issue_url":"https://api.github.com/repos/nhibernate/nhibernate-core/issues/388","number":388,"state":"closed","locked":false,"title":"NH-2504 - Can't use Cacheable with Group By","user":{"login":"gliljas","id":290294,"avatar_url":"https://avatars.githubusercontent.com/u/290294?v=3","gravatar_id":"","url":"https://api.github.com/users/gliljas","html_url":"https://github.com/gliljas","followers_url":"https://api.github.com/users/gliljas/followers","following_url":"https://api.github.com/users/gliljas/following{/other_user}","gists_url":"https://api.github.com/users/gliljas/gists{/gist_id}","starred_url":"https://api.github.com/users/gliljas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gliljas/subscriptions","organizations_url":"https://api.github.com/users/gliljas/orgs","repos_url":"https://api.github.com/users/gliljas/repos","events_url":"https://api.github.com/users/gliljas/events{/privacy}","received_events_url":"https://api.github.com/users/gliljas/received_events","type":"User","site_admin":false},"body":"This fixes the second case mentioned in the JIRA issue (and the one I needed to fix). Applying Cacheble earlier in the query still throws an exception. That is of course fixable, but IMHO I think the problems are caused by treating Cacheable as ResultOperator. Both Cacheable and Timeout are environmental query settings, and letting them pollute and complicate the expression tree and the handling of this tree is really unnecessary. I think we could reduce complexity and solve a couple of outstanding issues by investingating and removing MethodCallExpressions to Cacheable and Timeout, before all the other tree parsing commences.","created_at":"2014-12-07T21:39:02Z","updated_at":"2015-01-20T19:47:45Z","closed_at":"2015-01-20T19:47:45Z","merged_at":"2015-01-20T19:47:45Z","merge_commit_sha":"098e4008c6894e00813f840d6072ebf8ef5fc449","assignee":null,"milestone":{"url":"https://api.github.com/repos/nhibernate/nhibernate-core/milestones/4","labels_url":"https://api.github.com/repos/nhibernate/nhibernate-core/milestones/4/labels","id":870743,"number":4,"title":"4.0.3","description":null,"creator":{"login":"hazzik","id":144791,"avatar_url":"https://avatars.githubusercontent.com/u/144791?v=3","gravatar_id":"","url":"https://api.github.com/users/hazzik","html_url":"https://github.com/hazzik","followers_url":"https://api.github.com/users/hazzik/followers","following_url":"https://api.github.com/users/hazzik/following{/other_user}","gists_url":"https://api.github.com/users/hazzik/gists{/gist_id}","starred_url":"https://api.github.com/users/hazzik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hazzik/subscriptions","organizations_url":"https://api.github.com/users/hazzik/orgs","repos_url":"https://api.github.com/users/hazzik/repos","events_url":"https://api.github.com/users/hazzik/events{/privacy}","received_events_url":"https://api.github.com/users/hazzik/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":3,"state":"open","created_at":"2014-11-18T07:18:59Z","updated_at":"2015-01-20T19:47:45Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/388/commits","review_comments_url":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/388/comments","review_comment_url":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/comments/{number}","comments_url":"https://api.github.com/repos/nhibernate/nhibernate-core/issues/388/comments","statuses_url":"https://api.github.com/repos/nhibernate/nhibernate-core/statuses/76ca563de945b553b355cfb4724d860139bf42ca","head":{"label":"gliljas:CachedGroupBy","ref":"CachedGroupBy","sha":"76ca563de945b553b355cfb4724d860139bf42ca","user":{"login":"gliljas","id":290294,"avatar_url":"https://avatars.githubusercontent.com/u/290294?v=3","gravatar_id":"","url":"https://api.github.com/users/gliljas","html_url":"https://github.com/gliljas","followers_url":"https://api.github.com/users/gliljas/followers","following_url":"https://api.github.com/users/gliljas/following{/other_user}","gists_url":"https://api.github.com/users/gliljas/gists{/gist_id}","starred_url":"https://api.github.com/users/gliljas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gliljas/subscriptions","organizations_url":"https://api.github.com/users/gliljas/orgs","repos_url":"https://api.github.com/users/gliljas/repos","events_url":"https://api.github.com/users/gliljas/events{/privacy}","received_events_url":"https://api.github.com/users/gliljas/received_events","type":"User","site_admin":false},"repo":{"id":2325113,"name":"nhibernate-core","full_name":"gliljas/nhibernate-core","owner":{"login":"gliljas","id":290294,"avatar_url":"https://avatars.githubusercontent.com/u/290294?v=3","gravatar_id":"","url":"https://api.github.com/users/gliljas","html_url":"https://github.com/gliljas","followers_url":"https://api.github.com/users/gliljas/followers","following_url":"https://api.github.com/users/gliljas/following{/other_user}","gists_url":"https://api.github.com/users/gliljas/gists{/gist_id}","starred_url":"https://api.github.com/users/gliljas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gliljas/subscriptions","organizations_url":"https://api.github.com/users/gliljas/orgs","repos_url":"https://api.github.com/users/gliljas/repos","events_url":"https://api.github.com/users/gliljas/events{/privacy}","received_events_url":"https://api.github.com/users/gliljas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gliljas/nhibernate-core","description":"NHibernate Object Relational Mapper","fork":true,"url":"https://api.github.com/repos/gliljas/nhibernate-core","forks_url":"https://api.github.com/repos/gliljas/nhibernate-core/forks","keys_url":"https://api.github.com/repos/gliljas/nhibernate-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gliljas/nhibernate-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gliljas/nhibernate-core/teams","hooks_url":"https://api.github.com/repos/gliljas/nhibernate-core/hooks","issue_events_url":"https://api.github.com/repos/gliljas/nhibernate-core/issues/events{/number}","events_url":"https://api.github.com/repos/gliljas/nhibernate-core/events","assignees_url":"https://api.github.com/repos/gliljas/nhibernate-core/assignees{/user}","branches_url":"https://api.github.com/repos/gliljas/nhibernate-core/branches{/branch}","tags_url":"https://api.github.com/repos/gliljas/nhibernate-core/tags","blobs_url":"https://api.github.com/repos/gliljas/nhibernate-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gliljas/nhibernate-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gliljas/nhibernate-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/gliljas/nhibernate-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gliljas/nhibernate-core/statuses/{sha}","languages_url":"https://api.github.com/repos/gliljas/nhibernate-core/languages","stargazers_url":"https://api.github.com/repos/gliljas/nhibernate-core/stargazers","contributors_url":"https://api.github.com/repos/gliljas/nhibernate-core/contributors","subscribers_url":"https://api.github.com/repos/gliljas/nhibernate-core/subscribers","subscription_url":"https://api.github.com/repos/gliljas/nhibernate-core/subscription","commits_url":"https://api.github.com/repos/gliljas/nhibernate-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/gliljas/nhibernate-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/gliljas/nhibernate-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/gliljas/nhibernate-core/issues/comments/{number}","contents_url":"https://api.github.com/repos/gliljas/nhibernate-core/contents/{+path}","compare_url":"https://api.github.com/repos/gliljas/nhibernate-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gliljas/nhibernate-core/merges","archive_url":"https://api.github.com/repos/gliljas/nhibernate-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gliljas/nhibernate-core/downloads","issues_url":"https://api.github.com/repos/gliljas/nhibernate-core/issues{/number}","pulls_url":"https://api.github.com/repos/gliljas/nhibernate-core/pulls{/number}","milestones_url":"https://api.github.com/repos/gliljas/nhibernate-core/milestones{/number}","notifications_url":"https://api.github.com/repos/gliljas/nhibernate-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gliljas/nhibernate-core/labels{/name}","releases_url":"https://api.github.com/repos/gliljas/nhibernate-core/releases{/id}","created_at":"2011-09-04T21:51:00Z","updated_at":"2014-12-08T23:21:30Z","pushed_at":"2015-01-07T23:55:02Z","git_url":"git://github.com/gliljas/nhibernate-core.git","ssh_url":"git@github.com:gliljas/nhibernate-core.git","clone_url":"https://github.com/gliljas/nhibernate-core.git","svn_url":"https://github.com/gliljas/nhibernate-core","homepage":"http://nhforge.org/","size":65105,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"nhibernate:master","ref":"master","sha":"fac75a20b14232325e3b1cb122aa9ed0808e9dca","user":{"login":"nhibernate","id":961041,"avatar_url":"https://avatars.githubusercontent.com/u/961041?v=3","gravatar_id":"","url":"https://api.github.com/users/nhibernate","html_url":"https://github.com/nhibernate","followers_url":"https://api.github.com/users/nhibernate/followers","following_url":"https://api.github.com/users/nhibernate/following{/other_user}","gists_url":"https://api.github.com/users/nhibernate/gists{/gist_id}","starred_url":"https://api.github.com/users/nhibernate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nhibernate/subscriptions","organizations_url":"https://api.github.com/users/nhibernate/orgs","repos_url":"https://api.github.com/users/nhibernate/repos","events_url":"https://api.github.com/users/nhibernate/events{/privacy}","received_events_url":"https://api.github.com/users/nhibernate/received_events","type":"Organization","site_admin":false},"repo":{"id":2206199,"name":"nhibernate-core","full_name":"nhibernate/nhibernate-core","owner":{"login":"nhibernate","id":961041,"avatar_url":"https://avatars.githubusercontent.com/u/961041?v=3","gravatar_id":"","url":"https://api.github.com/users/nhibernate","html_url":"https://github.com/nhibernate","followers_url":"https://api.github.com/users/nhibernate/followers","following_url":"https://api.github.com/users/nhibernate/following{/other_user}","gists_url":"https://api.github.com/users/nhibernate/gists{/gist_id}","starred_url":"https://api.github.com/users/nhibernate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nhibernate/subscriptions","organizations_url":"https://api.github.com/users/nhibernate/orgs","repos_url":"https://api.github.com/users/nhibernate/repos","events_url":"https://api.github.com/users/nhibernate/events{/privacy}","received_events_url":"https://api.github.com/users/nhibernate/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nhibernate/nhibernate-core","description":"NHibernate Object Relational Mapper","fork":false,"url":"https://api.github.com/repos/nhibernate/nhibernate-core","forks_url":"https://api.github.com/repos/nhibernate/nhibernate-core/forks","keys_url":"https://api.github.com/repos/nhibernate/nhibernate-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nhibernate/nhibernate-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nhibernate/nhibernate-core/teams","hooks_url":"https://api.github.com/repos/nhibernate/nhibernate-core/hooks","issue_events_url":"https://api.github.com/repos/nhibernate/nhibernate-core/issues/events{/number}","events_url":"https://api.github.com/repos/nhibernate/nhibernate-core/events","assignees_url":"https://api.github.com/repos/nhibernate/nhibernate-core/assignees{/user}","branches_url":"https://api.github.com/repos/nhibernate/nhibernate-core/branches{/branch}","tags_url":"https://api.github.com/repos/nhibernate/nhibernate-core/tags","blobs_url":"https://api.github.com/repos/nhibernate/nhibernate-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nhibernate/nhibernate-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nhibernate/nhibernate-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/nhibernate/nhibernate-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nhibernate/nhibernate-core/statuses/{sha}","languages_url":"https://api.github.com/repos/nhibernate/nhibernate-core/languages","stargazers_url":"https://api.github.com/repos/nhibernate/nhibernate-core/stargazers","contributors_url":"https://api.github.com/repos/nhibernate/nhibernate-core/contributors","subscribers_url":"https://api.github.com/repos/nhibernate/nhibernate-core/subscribers","subscription_url":"https://api.github.com/repos/nhibernate/nhibernate-core/subscription","commits_url":"https://api.github.com/repos/nhibernate/nhibernate-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/nhibernate/nhibernate-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/nhibernate/nhibernate-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/nhibernate/nhibernate-core/issues/comments/{number}","contents_url":"https://api.github.com/repos/nhibernate/nhibernate-core/contents/{+path}","compare_url":"https://api.github.com/repos/nhibernate/nhibernate-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nhibernate/nhibernate-core/merges","archive_url":"https://api.github.com/repos/nhibernate/nhibernate-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nhibernate/nhibernate-core/downloads","issues_url":"https://api.github.com/repos/nhibernate/nhibernate-core/issues{/number}","pulls_url":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls{/number}","milestones_url":"https://api.github.com/repos/nhibernate/nhibernate-core/milestones{/number}","notifications_url":"https://api.github.com/repos/nhibernate/nhibernate-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nhibernate/nhibernate-core/labels{/name}","releases_url":"https://api.github.com/repos/nhibernate/nhibernate-core/releases{/id}","created_at":"2011-08-14T17:51:09Z","updated_at":"2015-01-19T03:30:06Z","pushed_at":"2015-01-20T19:47:41Z","git_url":"git://github.com/nhibernate/nhibernate-core.git","ssh_url":"git@github.com:nhibernate/nhibernate-core.git","clone_url":"https://github.com/nhibernate/nhibernate-core.git","svn_url":"https://github.com/nhibernate/nhibernate-core","homepage":"http://nhibernate.info","size":95824,"stargazers_count":734,"watchers_count":734,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":492,"mirror_url":null,"open_issues_count":78,"forks":492,"open_issues":78,"watchers":734,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/388"},"html":{"href":"https://github.com/nhibernate/nhibernate-core/pull/388"},"issue":{"href":"https://api.github.com/repos/nhibernate/nhibernate-core/issues/388"},"comments":{"href":"https://api.github.com/repos/nhibernate/nhibernate-core/issues/388/comments"},"review_comments":{"href":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/388/comments"},"review_comment":{"href":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/388/commits"},"statuses":{"href":"https://api.github.com/repos/nhibernate/nhibernate-core/statuses/76ca563de945b553b355cfb4724d860139bf42ca"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"hazzik","id":144791,"avatar_url":"https://avatars.githubusercontent.com/u/144791?v=3","gravatar_id":"","url":"https://api.github.com/users/hazzik","html_url":"https://github.com/hazzik","followers_url":"https://api.github.com/users/hazzik/followers","following_url":"https://api.github.com/users/hazzik/following{/other_user}","gists_url":"https://api.github.com/users/hazzik/gists{/gist_id}","starred_url":"https://api.github.com/users/hazzik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hazzik/subscriptions","organizations_url":"https://api.github.com/users/hazzik/orgs","repos_url":"https://api.github.com/users/hazzik/repos","events_url":"https://api.github.com/users/hazzik/events{/privacy}","received_events_url":"https://api.github.com/users/hazzik/received_events","type":"User","site_admin":false},"comments":11,"review_comments":2,"commits":1,"additions":32,"deletions":0,"changed_files":2}}