{"action":"created","comment":{"url":"https://api.github.com/repos/ripple/ripple-lib/pulls/comments/38250820","id":38250820,"diff_hunk":"@@ -5,6 +5,16 @@ const validate = utils.common.validate;\n const Request = utils.common.core.Request;\n const convertErrors = utils.common.convertErrors;\n \n+function convertSubmitErrors(callback) {\n+  return function(error, data) {\n+    if (data.engineResult !== 'tesSUCCESS') {","path":"src/api/transaction/submit.js","position":6,"original_position":6,"commit_id":"a6c27474b5becd416ae1dfe7995cf72bb7e6cc60","original_commit_id":"a6c27474b5becd416ae1dfe7995cf72bb7e6cc60","user":{"login":"clark800","id":1238722,"avatar_url":"https://avatars.githubusercontent.com/u/1238722?v=3","gravatar_id":"","url":"https://api.github.com/users/clark800","html_url":"https://github.com/clark800","followers_url":"https://api.github.com/users/clark800/followers","following_url":"https://api.github.com/users/clark800/following{/other_user}","gists_url":"https://api.github.com/users/clark800/gists{/gist_id}","starred_url":"https://api.github.com/users/clark800/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clark800/subscriptions","organizations_url":"https://api.github.com/users/clark800/orgs","repos_url":"https://api.github.com/users/clark800/repos","events_url":"https://api.github.com/users/clark800/events{/privacy}","received_events_url":"https://api.github.com/users/clark800/received_events","type":"User","site_admin":false},"body":"What's an example of a code that is not tesSUCCESS that could be a successfully submitted transaction?","created_at":"2015-08-28T22:31:04Z","updated_at":"2015-08-28T22:31:04Z","html_url":"https://github.com/ripple/ripple-lib/pull/535#discussion_r38250820","pull_request_url":"https://api.github.com/repos/ripple/ripple-lib/pulls/535","_links":{"self":{"href":"https://api.github.com/repos/ripple/ripple-lib/pulls/comments/38250820"},"html":{"href":"https://github.com/ripple/ripple-lib/pull/535#discussion_r38250820"},"pull_request":{"href":"https://api.github.com/repos/ripple/ripple-lib/pulls/535"}}},"pull_request":{"url":"https://api.github.com/repos/ripple/ripple-lib/pulls/535","id":43675578,"html_url":"https://github.com/ripple/ripple-lib/pull/535","diff_url":"https://github.com/ripple/ripple-lib/pull/535.diff","patch_url":"https://github.com/ripple/ripple-lib/pull/535.patch","issue_url":"https://api.github.com/repos/ripple/ripple-lib/issues/535","number":535,"state":"open","locked":false,"title":"Return promise error if submit result is not tesSUCCESS","user":{"login":"clark800","id":1238722,"avatar_url":"https://avatars.githubusercontent.com/u/1238722?v=3","gravatar_id":"","url":"https://api.github.com/users/clark800","html_url":"https://github.com/clark800","followers_url":"https://api.github.com/users/clark800/followers","following_url":"https://api.github.com/users/clark800/following{/other_user}","gists_url":"https://api.github.com/users/clark800/gists{/gist_id}","starred_url":"https://api.github.com/users/clark800/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clark800/subscriptions","organizations_url":"https://api.github.com/users/clark800/orgs","repos_url":"https://api.github.com/users/clark800/repos","events_url":"https://api.github.com/users/clark800/events{/privacy}","received_events_url":"https://api.github.com/users/clark800/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-08-28T21:48:20Z","updated_at":"2015-08-28T22:31:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7a269ec75aa809e7605e3c4dde87c6ec1edbf42d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ripple/ripple-lib/pulls/535/commits","review_comments_url":"https://api.github.com/repos/ripple/ripple-lib/pulls/535/comments","review_comment_url":"https://api.github.com/repos/ripple/ripple-lib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ripple/ripple-lib/issues/535/comments","statuses_url":"https://api.github.com/repos/ripple/ripple-lib/statuses/a6c27474b5becd416ae1dfe7995cf72bb7e6cc60","head":{"label":"clark800:submit-error","ref":"submit-error","sha":"a6c27474b5becd416ae1dfe7995cf72bb7e6cc60","user":{"login":"clark800","id":1238722,"avatar_url":"https://avatars.githubusercontent.com/u/1238722?v=3","gravatar_id":"","url":"https://api.github.com/users/clark800","html_url":"https://github.com/clark800","followers_url":"https://api.github.com/users/clark800/followers","following_url":"https://api.github.com/users/clark800/following{/other_user}","gists_url":"https://api.github.com/users/clark800/gists{/gist_id}","starred_url":"https://api.github.com/users/clark800/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clark800/subscriptions","organizations_url":"https://api.github.com/users/clark800/orgs","repos_url":"https://api.github.com/users/clark800/repos","events_url":"https://api.github.com/users/clark800/events{/privacy}","received_events_url":"https://api.github.com/users/clark800/received_events","type":"User","site_admin":false},"repo":{"id":27850085,"name":"ripple-lib","full_name":"clark800/ripple-lib","owner":{"login":"clark800","id":1238722,"avatar_url":"https://avatars.githubusercontent.com/u/1238722?v=3","gravatar_id":"","url":"https://api.github.com/users/clark800","html_url":"https://github.com/clark800","followers_url":"https://api.github.com/users/clark800/followers","following_url":"https://api.github.com/users/clark800/following{/other_user}","gists_url":"https://api.github.com/users/clark800/gists{/gist_id}","starred_url":"https://api.github.com/users/clark800/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clark800/subscriptions","organizations_url":"https://api.github.com/users/clark800/orgs","repos_url":"https://api.github.com/users/clark800/repos","events_url":"https://api.github.com/users/clark800/events{/privacy}","received_events_url":"https://api.github.com/users/clark800/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/clark800/ripple-lib","description":"A JavaScript API for interacting with Ripple in Node.js and the browser","fork":true,"url":"https://api.github.com/repos/clark800/ripple-lib","forks_url":"https://api.github.com/repos/clark800/ripple-lib/forks","keys_url":"https://api.github.com/repos/clark800/ripple-lib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/clark800/ripple-lib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/clark800/ripple-lib/teams","hooks_url":"https://api.github.com/repos/clark800/ripple-lib/hooks","issue_events_url":"https://api.github.com/repos/clark800/ripple-lib/issues/events{/number}","events_url":"https://api.github.com/repos/clark800/ripple-lib/events","assignees_url":"https://api.github.com/repos/clark800/ripple-lib/assignees{/user}","branches_url":"https://api.github.com/repos/clark800/ripple-lib/branches{/branch}","tags_url":"https://api.github.com/repos/clark800/ripple-lib/tags","blobs_url":"https://api.github.com/repos/clark800/ripple-lib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/clark800/ripple-lib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/clark800/ripple-lib/git/refs{/sha}","trees_url":"https://api.github.com/repos/clark800/ripple-lib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/clark800/ripple-lib/statuses/{sha}","languages_url":"https://api.github.com/repos/clark800/ripple-lib/languages","stargazers_url":"https://api.github.com/repos/clark800/ripple-lib/stargazers","contributors_url":"https://api.github.com/repos/clark800/ripple-lib/contributors","subscribers_url":"https://api.github.com/repos/clark800/ripple-lib/subscribers","subscription_url":"https://api.github.com/repos/clark800/ripple-lib/subscription","commits_url":"https://api.github.com/repos/clark800/ripple-lib/commits{/sha}","git_commits_url":"https://api.github.com/repos/clark800/ripple-lib/git/commits{/sha}","comments_url":"https://api.github.com/repos/clark800/ripple-lib/comments{/number}","issue_comment_url":"https://api.github.com/repos/clark800/ripple-lib/issues/comments{/number}","contents_url":"https://api.github.com/repos/clark800/ripple-lib/contents/{+path}","compare_url":"https://api.github.com/repos/clark800/ripple-lib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/clark800/ripple-lib/merges","archive_url":"https://api.github.com/repos/clark800/ripple-lib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/clark800/ripple-lib/downloads","issues_url":"https://api.github.com/repos/clark800/ripple-lib/issues{/number}","pulls_url":"https://api.github.com/repos/clark800/ripple-lib/pulls{/number}","milestones_url":"https://api.github.com/repos/clark800/ripple-lib/milestones{/number}","notifications_url":"https://api.github.com/repos/clark800/ripple-lib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/clark800/ripple-lib/labels{/name}","releases_url":"https://api.github.com/repos/clark800/ripple-lib/releases{/id}","created_at":"2014-12-11T02:21:32Z","updated_at":"2015-04-10T19:57:06Z","pushed_at":"2015-08-28T21:47:34Z","git_url":"git://github.com/clark800/ripple-lib.git","ssh_url":"git@github.com:clark800/ripple-lib.git","clone_url":"https://github.com/clark800/ripple-lib.git","svn_url":"https://github.com/clark800/ripple-lib","homepage":"","size":13160,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"ripple:develop","ref":"develop","sha":"a13bfae714aad91558e29506f495b78647650fa1","user":{"login":"ripple","id":3165523,"avatar_url":"https://avatars.githubusercontent.com/u/3165523?v=3","gravatar_id":"","url":"https://api.github.com/users/ripple","html_url":"https://github.com/ripple","followers_url":"https://api.github.com/users/ripple/followers","following_url":"https://api.github.com/users/ripple/following{/other_user}","gists_url":"https://api.github.com/users/ripple/gists{/gist_id}","starred_url":"https://api.github.com/users/ripple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ripple/subscriptions","organizations_url":"https://api.github.com/users/ripple/orgs","repos_url":"https://api.github.com/users/ripple/repos","events_url":"https://api.github.com/users/ripple/events{/privacy}","received_events_url":"https://api.github.com/users/ripple/received_events","type":"Organization","site_admin":false},"repo":{"id":9681561,"name":"ripple-lib","full_name":"ripple/ripple-lib","owner":{"login":"ripple","id":3165523,"avatar_url":"https://avatars.githubusercontent.com/u/3165523?v=3","gravatar_id":"","url":"https://api.github.com/users/ripple","html_url":"https://github.com/ripple","followers_url":"https://api.github.com/users/ripple/followers","following_url":"https://api.github.com/users/ripple/following{/other_user}","gists_url":"https://api.github.com/users/ripple/gists{/gist_id}","starred_url":"https://api.github.com/users/ripple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ripple/subscriptions","organizations_url":"https://api.github.com/users/ripple/orgs","repos_url":"https://api.github.com/users/ripple/repos","events_url":"https://api.github.com/users/ripple/events{/privacy}","received_events_url":"https://api.github.com/users/ripple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ripple/ripple-lib","description":"A JavaScript API for interacting with Ripple in Node.js and the browser","fork":false,"url":"https://api.github.com/repos/ripple/ripple-lib","forks_url":"https://api.github.com/repos/ripple/ripple-lib/forks","keys_url":"https://api.github.com/repos/ripple/ripple-lib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ripple/ripple-lib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ripple/ripple-lib/teams","hooks_url":"https://api.github.com/repos/ripple/ripple-lib/hooks","issue_events_url":"https://api.github.com/repos/ripple/ripple-lib/issues/events{/number}","events_url":"https://api.github.com/repos/ripple/ripple-lib/events","assignees_url":"https://api.github.com/repos/ripple/ripple-lib/assignees{/user}","branches_url":"https://api.github.com/repos/ripple/ripple-lib/branches{/branch}","tags_url":"https://api.github.com/repos/ripple/ripple-lib/tags","blobs_url":"https://api.github.com/repos/ripple/ripple-lib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ripple/ripple-lib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ripple/ripple-lib/git/refs{/sha}","trees_url":"https://api.github.com/repos/ripple/ripple-lib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ripple/ripple-lib/statuses/{sha}","languages_url":"https://api.github.com/repos/ripple/ripple-lib/languages","stargazers_url":"https://api.github.com/repos/ripple/ripple-lib/stargazers","contributors_url":"https://api.github.com/repos/ripple/ripple-lib/contributors","subscribers_url":"https://api.github.com/repos/ripple/ripple-lib/subscribers","subscription_url":"https://api.github.com/repos/ripple/ripple-lib/subscription","commits_url":"https://api.github.com/repos/ripple/ripple-lib/commits{/sha}","git_commits_url":"https://api.github.com/repos/ripple/ripple-lib/git/commits{/sha}","comments_url":"https://api.github.com/repos/ripple/ripple-lib/comments{/number}","issue_comment_url":"https://api.github.com/repos/ripple/ripple-lib/issues/comments{/number}","contents_url":"https://api.github.com/repos/ripple/ripple-lib/contents/{+path}","compare_url":"https://api.github.com/repos/ripple/ripple-lib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ripple/ripple-lib/merges","archive_url":"https://api.github.com/repos/ripple/ripple-lib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ripple/ripple-lib/downloads","issues_url":"https://api.github.com/repos/ripple/ripple-lib/issues{/number}","pulls_url":"https://api.github.com/repos/ripple/ripple-lib/pulls{/number}","milestones_url":"https://api.github.com/repos/ripple/ripple-lib/milestones{/number}","notifications_url":"https://api.github.com/repos/ripple/ripple-lib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ripple/ripple-lib/labels{/name}","releases_url":"https://api.github.com/repos/ripple/ripple-lib/releases{/id}","created_at":"2013-04-25T21:17:19Z","updated_at":"2015-08-27T08:09:53Z","pushed_at":"2015-08-28T21:48:20Z","git_url":"git://github.com/ripple/ripple-lib.git","ssh_url":"git@github.com:ripple/ripple-lib.git","clone_url":"https://github.com/ripple/ripple-lib.git","svn_url":"https://github.com/ripple/ripple-lib","homepage":"","size":18967,"stargazers_count":421,"watchers_count":421,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":150,"mirror_url":null,"open_issues_count":23,"forks":150,"open_issues":23,"watchers":421,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ripple/ripple-lib/pulls/535"},"html":{"href":"https://github.com/ripple/ripple-lib/pull/535"},"issue":{"href":"https://api.github.com/repos/ripple/ripple-lib/issues/535"},"comments":{"href":"https://api.github.com/repos/ripple/ripple-lib/issues/535/comments"},"review_comments":{"href":"https://api.github.com/repos/ripple/ripple-lib/pulls/535/comments"},"review_comment":{"href":"https://api.github.com/repos/ripple/ripple-lib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ripple/ripple-lib/pulls/535/commits"},"statuses":{"href":"https://api.github.com/repos/ripple/ripple-lib/statuses/a6c27474b5becd416ae1dfe7995cf72bb7e6cc60"}}}}