{"action":"closed","number":81,"pull_request":{"url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/pulls/81","id":29457830,"html_url":"https://github.com/Particular/NServiceBus.NHibernate/pull/81","diff_url":"https://github.com/Particular/NServiceBus.NHibernate/pull/81.diff","patch_url":"https://github.com/Particular/NServiceBus.NHibernate/pull/81.patch","issue_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/issues/81","number":81,"state":"closed","locked":false,"title":"Removing Task.StartNew inside SetAsDispatched","user":{"login":"danielmarbach","id":174258,"avatar_url":"https://avatars.githubusercontent.com/u/174258?v=3","gravatar_id":"","url":"https://api.github.com/users/danielmarbach","html_url":"https://github.com/danielmarbach","followers_url":"https://api.github.com/users/danielmarbach/followers","following_url":"https://api.github.com/users/danielmarbach/following{/other_user}","gists_url":"https://api.github.com/users/danielmarbach/gists{/gist_id}","starred_url":"https://api.github.com/users/danielmarbach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielmarbach/subscriptions","organizations_url":"https://api.github.com/users/danielmarbach/orgs","repos_url":"https://api.github.com/users/danielmarbach/repos","events_url":"https://api.github.com/users/danielmarbach/events{/privacy}","received_events_url":"https://api.github.com/users/danielmarbach/received_events","type":"User","site_admin":false},"body":"@SzymonPobiega and @johnsimons I ran a few tests on my machine and there is no noticable difference in the performance. Also having a task started in the background which could fail and then lead to an unobserved task exception is not really a good design. Please review and merge if OK","created_at":"2015-02-17T16:51:25Z","updated_at":"2015-02-17T23:45:22Z","closed_at":"2015-02-17T23:45:22Z","merged_at":"2015-02-17T23:45:22Z","merge_commit_sha":"1da1face25c7d9dd578864716f0e58dbc6c9fb0d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/pulls/81/commits","review_comments_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/pulls/81/comments","review_comment_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/issues/81/comments","statuses_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/statuses/e9cb67660060132d87af030b372fa7f72dca4bef","head":{"label":"Particular:RemovingTask","ref":"RemovingTask","sha":"e9cb67660060132d87af030b372fa7f72dca4bef","user":{"login":"Particular","id":5038441,"avatar_url":"https://avatars.githubusercontent.com/u/5038441?v=3","gravatar_id":"","url":"https://api.github.com/users/Particular","html_url":"https://github.com/Particular","followers_url":"https://api.github.com/users/Particular/followers","following_url":"https://api.github.com/users/Particular/following{/other_user}","gists_url":"https://api.github.com/users/Particular/gists{/gist_id}","starred_url":"https://api.github.com/users/Particular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Particular/subscriptions","organizations_url":"https://api.github.com/users/Particular/orgs","repos_url":"https://api.github.com/users/Particular/repos","events_url":"https://api.github.com/users/Particular/events{/privacy}","received_events_url":"https://api.github.com/users/Particular/received_events","type":"Organization","site_admin":false},"repo":{"id":14360139,"name":"NServiceBus.NHibernate","full_name":"Particular/NServiceBus.NHibernate","owner":{"login":"Particular","id":5038441,"avatar_url":"https://avatars.githubusercontent.com/u/5038441?v=3","gravatar_id":"","url":"https://api.github.com/users/Particular","html_url":"https://github.com/Particular","followers_url":"https://api.github.com/users/Particular/followers","following_url":"https://api.github.com/users/Particular/following{/other_user}","gists_url":"https://api.github.com/users/Particular/gists{/gist_id}","starred_url":"https://api.github.com/users/Particular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Particular/subscriptions","organizations_url":"https://api.github.com/users/Particular/orgs","repos_url":"https://api.github.com/users/Particular/repos","events_url":"https://api.github.com/users/Particular/events{/privacy}","received_events_url":"https://api.github.com/users/Particular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Particular/NServiceBus.NHibernate","description":"Persistence support for NServiceBus using NHibernate","fork":false,"url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate","forks_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/forks","keys_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/teams","hooks_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/hooks","issue_events_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/issues/events{/number}","events_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/events","assignees_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/assignees{/user}","branches_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/branches{/branch}","tags_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/tags","blobs_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/git/refs{/sha}","trees_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/statuses/{sha}","languages_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/languages","stargazers_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/stargazers","contributors_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/contributors","subscribers_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/subscribers","subscription_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/subscription","commits_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/commits{/sha}","git_commits_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/git/commits{/sha}","comments_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/comments{/number}","issue_comment_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/issues/comments/{number}","contents_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/contents/{+path}","compare_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/merges","archive_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/downloads","issues_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/issues{/number}","pulls_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/pulls{/number}","milestones_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/milestones{/number}","notifications_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/labels{/name}","releases_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/releases{/id}","created_at":"2013-11-13T09:47:27Z","updated_at":"2014-11-26T23:33:19Z","pushed_at":"2015-02-17T23:45:22Z","git_url":"git://github.com/Particular/NServiceBus.NHibernate.git","ssh_url":"git@github.com:Particular/NServiceBus.NHibernate.git","clone_url":"https://github.com/Particular/NServiceBus.NHibernate.git","svn_url":"https://github.com/Particular/NServiceBus.NHibernate","homepage":"","size":6903,"stargazers_count":3,"watchers_count":3,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":6,"forks":11,"open_issues":6,"watchers":3,"default_branch":"develop"}},"base":{"label":"Particular:develop","ref":"develop","sha":"aa7d86a6bef7a09bfb1c679378deb973e8b4e082","user":{"login":"Particular","id":5038441,"avatar_url":"https://avatars.githubusercontent.com/u/5038441?v=3","gravatar_id":"","url":"https://api.github.com/users/Particular","html_url":"https://github.com/Particular","followers_url":"https://api.github.com/users/Particular/followers","following_url":"https://api.github.com/users/Particular/following{/other_user}","gists_url":"https://api.github.com/users/Particular/gists{/gist_id}","starred_url":"https://api.github.com/users/Particular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Particular/subscriptions","organizations_url":"https://api.github.com/users/Particular/orgs","repos_url":"https://api.github.com/users/Particular/repos","events_url":"https://api.github.com/users/Particular/events{/privacy}","received_events_url":"https://api.github.com/users/Particular/received_events","type":"Organization","site_admin":false},"repo":{"id":14360139,"name":"NServiceBus.NHibernate","full_name":"Particular/NServiceBus.NHibernate","owner":{"login":"Particular","id":5038441,"avatar_url":"https://avatars.githubusercontent.com/u/5038441?v=3","gravatar_id":"","url":"https://api.github.com/users/Particular","html_url":"https://github.com/Particular","followers_url":"https://api.github.com/users/Particular/followers","following_url":"https://api.github.com/users/Particular/following{/other_user}","gists_url":"https://api.github.com/users/Particular/gists{/gist_id}","starred_url":"https://api.github.com/users/Particular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Particular/subscriptions","organizations_url":"https://api.github.com/users/Particular/orgs","repos_url":"https://api.github.com/users/Particular/repos","events_url":"https://api.github.com/users/Particular/events{/privacy}","received_events_url":"https://api.github.com/users/Particular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Particular/NServiceBus.NHibernate","description":"Persistence support for NServiceBus using NHibernate","fork":false,"url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate","forks_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/forks","keys_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/teams","hooks_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/hooks","issue_events_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/issues/events{/number}","events_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/events","assignees_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/assignees{/user}","branches_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/branches{/branch}","tags_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/tags","blobs_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/git/refs{/sha}","trees_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/statuses/{sha}","languages_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/languages","stargazers_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/stargazers","contributors_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/contributors","subscribers_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/subscribers","subscription_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/subscription","commits_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/commits{/sha}","git_commits_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/git/commits{/sha}","comments_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/comments{/number}","issue_comment_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/issues/comments/{number}","contents_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/contents/{+path}","compare_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/merges","archive_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/downloads","issues_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/issues{/number}","pulls_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/pulls{/number}","milestones_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/milestones{/number}","notifications_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/labels{/name}","releases_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/releases{/id}","created_at":"2013-11-13T09:47:27Z","updated_at":"2014-11-26T23:33:19Z","pushed_at":"2015-02-17T23:45:22Z","git_url":"git://github.com/Particular/NServiceBus.NHibernate.git","ssh_url":"git@github.com:Particular/NServiceBus.NHibernate.git","clone_url":"https://github.com/Particular/NServiceBus.NHibernate.git","svn_url":"https://github.com/Particular/NServiceBus.NHibernate","homepage":"","size":6903,"stargazers_count":3,"watchers_count":3,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":6,"forks":11,"open_issues":6,"watchers":3,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/pulls/81"},"html":{"href":"https://github.com/Particular/NServiceBus.NHibernate/pull/81"},"issue":{"href":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/issues/81"},"comments":{"href":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/issues/81/comments"},"review_comments":{"href":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/pulls/81/comments"},"review_comment":{"href":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/pulls/81/commits"},"statuses":{"href":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/statuses/e9cb67660060132d87af030b372fa7f72dca4bef"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"johnsimons","id":122651,"avatar_url":"https://avatars.githubusercontent.com/u/122651?v=3","gravatar_id":"","url":"https://api.github.com/users/johnsimons","html_url":"https://github.com/johnsimons","followers_url":"https://api.github.com/users/johnsimons/followers","following_url":"https://api.github.com/users/johnsimons/following{/other_user}","gists_url":"https://api.github.com/users/johnsimons/gists{/gist_id}","starred_url":"https://api.github.com/users/johnsimons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnsimons/subscriptions","organizations_url":"https://api.github.com/users/johnsimons/orgs","repos_url":"https://api.github.com/users/johnsimons/repos","events_url":"https://api.github.com/users/johnsimons/events{/privacy}","received_events_url":"https://api.github.com/users/johnsimons/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":11,"deletions":15,"changed_files":1}}