{"action":"closed","number":390,"pull_request":{"url":"https://api.github.com/repos/bpinto/oh-my-fish/pulls/390","id":29768599,"html_url":"https://github.com/bpinto/oh-my-fish/pull/390","diff_url":"https://github.com/bpinto/oh-my-fish/pull/390.diff","patch_url":"https://github.com/bpinto/oh-my-fish/pull/390.patch","issue_url":"https://api.github.com/repos/bpinto/oh-my-fish/issues/390","number":390,"state":"closed","locked":false,"title":"Fix python version detection in theme bobthefish","user":{"login":"ccwang002","id":1544283,"avatar_url":"https://avatars.githubusercontent.com/u/1544283?v=3","gravatar_id":"","url":"https://api.github.com/users/ccwang002","html_url":"https://github.com/ccwang002","followers_url":"https://api.github.com/users/ccwang002/followers","following_url":"https://api.github.com/users/ccwang002/following{/other_user}","gists_url":"https://api.github.com/users/ccwang002/gists{/gist_id}","starred_url":"https://api.github.com/users/ccwang002/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ccwang002/subscriptions","organizations_url":"https://api.github.com/users/ccwang002/orgs","repos_url":"https://api.github.com/users/ccwang002/repos","events_url":"https://api.github.com/users/ccwang002/events{/privacy}","received_events_url":"https://api.github.com/users/ccwang002/received_events","type":"User","site_admin":false},"body":"Relax the python version matching, so `python` that symlinks to either major versions (e.g. 2, 3) or minor versions (e.g. 2.7, 3.4) can be properly detected.\r\n\r\nOn OSX it is easy to reproduce,\r\n```fish\r\n$ vf tmp -p python3\r\n(tempenv) $ readlink (which python)\r\n# python3.4\r\n```\r\nSame case for python 2.7.\r\n\r\nNote that currently both pypy and pypy3 have same display glyph. I simply relaxed their case pattern to be `pypy*`, but we could consider explicitly distinguish them in future (maybe having `p2` and `p3` superscript?)\r\n\r\n","created_at":"2015-02-22T10:29:14Z","updated_at":"2015-02-23T22:12:42Z","closed_at":"2015-02-23T22:12:42Z","merged_at":"2015-02-23T22:12:42Z","merge_commit_sha":"7a1352d73c33b8c54107b685a3ffb60e2f96bd27","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bpinto/oh-my-fish/pulls/390/commits","review_comments_url":"https://api.github.com/repos/bpinto/oh-my-fish/pulls/390/comments","review_comment_url":"https://api.github.com/repos/bpinto/oh-my-fish/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bpinto/oh-my-fish/issues/390/comments","statuses_url":"https://api.github.com/repos/bpinto/oh-my-fish/statuses/681d02b05aa4e307920b771b8a5117773637e88d","head":{"label":"ccwang002:fix_bobthefish_pyver","ref":"fix_bobthefish_pyver","sha":"681d02b05aa4e307920b771b8a5117773637e88d","user":{"login":"ccwang002","id":1544283,"avatar_url":"https://avatars.githubusercontent.com/u/1544283?v=3","gravatar_id":"","url":"https://api.github.com/users/ccwang002","html_url":"https://github.com/ccwang002","followers_url":"https://api.github.com/users/ccwang002/followers","following_url":"https://api.github.com/users/ccwang002/following{/other_user}","gists_url":"https://api.github.com/users/ccwang002/gists{/gist_id}","starred_url":"https://api.github.com/users/ccwang002/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ccwang002/subscriptions","organizations_url":"https://api.github.com/users/ccwang002/orgs","repos_url":"https://api.github.com/users/ccwang002/repos","events_url":"https://api.github.com/users/ccwang002/events{/privacy}","received_events_url":"https://api.github.com/users/ccwang002/received_events","type":"User","site_admin":false},"repo":{"id":31159147,"name":"oh-my-fish","full_name":"ccwang002/oh-my-fish","owner":{"login":"ccwang002","id":1544283,"avatar_url":"https://avatars.githubusercontent.com/u/1544283?v=3","gravatar_id":"","url":"https://api.github.com/users/ccwang002","html_url":"https://github.com/ccwang002","followers_url":"https://api.github.com/users/ccwang002/followers","following_url":"https://api.github.com/users/ccwang002/following{/other_user}","gists_url":"https://api.github.com/users/ccwang002/gists{/gist_id}","starred_url":"https://api.github.com/users/ccwang002/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ccwang002/subscriptions","organizations_url":"https://api.github.com/users/ccwang002/orgs","repos_url":"https://api.github.com/users/ccwang002/repos","events_url":"https://api.github.com/users/ccwang002/events{/privacy}","received_events_url":"https://api.github.com/users/ccwang002/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ccwang002/oh-my-fish","description":"Framework for managing your fish shell configuration inspired by Oh My ZSH.","fork":true,"url":"https://api.github.com/repos/ccwang002/oh-my-fish","forks_url":"https://api.github.com/repos/ccwang002/oh-my-fish/forks","keys_url":"https://api.github.com/repos/ccwang002/oh-my-fish/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ccwang002/oh-my-fish/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ccwang002/oh-my-fish/teams","hooks_url":"https://api.github.com/repos/ccwang002/oh-my-fish/hooks","issue_events_url":"https://api.github.com/repos/ccwang002/oh-my-fish/issues/events{/number}","events_url":"https://api.github.com/repos/ccwang002/oh-my-fish/events","assignees_url":"https://api.github.com/repos/ccwang002/oh-my-fish/assignees{/user}","branches_url":"https://api.github.com/repos/ccwang002/oh-my-fish/branches{/branch}","tags_url":"https://api.github.com/repos/ccwang002/oh-my-fish/tags","blobs_url":"https://api.github.com/repos/ccwang002/oh-my-fish/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ccwang002/oh-my-fish/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ccwang002/oh-my-fish/git/refs{/sha}","trees_url":"https://api.github.com/repos/ccwang002/oh-my-fish/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ccwang002/oh-my-fish/statuses/{sha}","languages_url":"https://api.github.com/repos/ccwang002/oh-my-fish/languages","stargazers_url":"https://api.github.com/repos/ccwang002/oh-my-fish/stargazers","contributors_url":"https://api.github.com/repos/ccwang002/oh-my-fish/contributors","subscribers_url":"https://api.github.com/repos/ccwang002/oh-my-fish/subscribers","subscription_url":"https://api.github.com/repos/ccwang002/oh-my-fish/subscription","commits_url":"https://api.github.com/repos/ccwang002/oh-my-fish/commits{/sha}","git_commits_url":"https://api.github.com/repos/ccwang002/oh-my-fish/git/commits{/sha}","comments_url":"https://api.github.com/repos/ccwang002/oh-my-fish/comments{/number}","issue_comment_url":"https://api.github.com/repos/ccwang002/oh-my-fish/issues/comments{/number}","contents_url":"https://api.github.com/repos/ccwang002/oh-my-fish/contents/{+path}","compare_url":"https://api.github.com/repos/ccwang002/oh-my-fish/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ccwang002/oh-my-fish/merges","archive_url":"https://api.github.com/repos/ccwang002/oh-my-fish/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ccwang002/oh-my-fish/downloads","issues_url":"https://api.github.com/repos/ccwang002/oh-my-fish/issues{/number}","pulls_url":"https://api.github.com/repos/ccwang002/oh-my-fish/pulls{/number}","milestones_url":"https://api.github.com/repos/ccwang002/oh-my-fish/milestones{/number}","notifications_url":"https://api.github.com/repos/ccwang002/oh-my-fish/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ccwang002/oh-my-fish/labels{/name}","releases_url":"https://api.github.com/repos/ccwang002/oh-my-fish/releases{/id}","created_at":"2015-02-22T10:07:49Z","updated_at":"2015-02-22T10:07:50Z","pushed_at":"2015-02-22T10:19:31Z","git_url":"git://github.com/ccwang002/oh-my-fish.git","ssh_url":"git@github.com:ccwang002/oh-my-fish.git","clone_url":"https://github.com/ccwang002/oh-my-fish.git","svn_url":"https://github.com/ccwang002/oh-my-fish","homepage":null,"size":5113,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bpinto:master","ref":"master","sha":"d8077b31c725120f6124160a8231b827477c6d7e","user":{"login":"bpinto","id":526122,"avatar_url":"https://avatars.githubusercontent.com/u/526122?v=3","gravatar_id":"","url":"https://api.github.com/users/bpinto","html_url":"https://github.com/bpinto","followers_url":"https://api.github.com/users/bpinto/followers","following_url":"https://api.github.com/users/bpinto/following{/other_user}","gists_url":"https://api.github.com/users/bpinto/gists{/gist_id}","starred_url":"https://api.github.com/users/bpinto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bpinto/subscriptions","organizations_url":"https://api.github.com/users/bpinto/orgs","repos_url":"https://api.github.com/users/bpinto/repos","events_url":"https://api.github.com/users/bpinto/events{/privacy}","received_events_url":"https://api.github.com/users/bpinto/received_events","type":"User","site_admin":false},"repo":{"id":5152538,"name":"oh-my-fish","full_name":"bpinto/oh-my-fish","owner":{"login":"bpinto","id":526122,"avatar_url":"https://avatars.githubusercontent.com/u/526122?v=3","gravatar_id":"","url":"https://api.github.com/users/bpinto","html_url":"https://github.com/bpinto","followers_url":"https://api.github.com/users/bpinto/followers","following_url":"https://api.github.com/users/bpinto/following{/other_user}","gists_url":"https://api.github.com/users/bpinto/gists{/gist_id}","starred_url":"https://api.github.com/users/bpinto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bpinto/subscriptions","organizations_url":"https://api.github.com/users/bpinto/orgs","repos_url":"https://api.github.com/users/bpinto/repos","events_url":"https://api.github.com/users/bpinto/events{/privacy}","received_events_url":"https://api.github.com/users/bpinto/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bpinto/oh-my-fish","description":"Framework for managing your fish shell configuration inspired by Oh My ZSH.","fork":false,"url":"https://api.github.com/repos/bpinto/oh-my-fish","forks_url":"https://api.github.com/repos/bpinto/oh-my-fish/forks","keys_url":"https://api.github.com/repos/bpinto/oh-my-fish/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bpinto/oh-my-fish/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bpinto/oh-my-fish/teams","hooks_url":"https://api.github.com/repos/bpinto/oh-my-fish/hooks","issue_events_url":"https://api.github.com/repos/bpinto/oh-my-fish/issues/events{/number}","events_url":"https://api.github.com/repos/bpinto/oh-my-fish/events","assignees_url":"https://api.github.com/repos/bpinto/oh-my-fish/assignees{/user}","branches_url":"https://api.github.com/repos/bpinto/oh-my-fish/branches{/branch}","tags_url":"https://api.github.com/repos/bpinto/oh-my-fish/tags","blobs_url":"https://api.github.com/repos/bpinto/oh-my-fish/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bpinto/oh-my-fish/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bpinto/oh-my-fish/git/refs{/sha}","trees_url":"https://api.github.com/repos/bpinto/oh-my-fish/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bpinto/oh-my-fish/statuses/{sha}","languages_url":"https://api.github.com/repos/bpinto/oh-my-fish/languages","stargazers_url":"https://api.github.com/repos/bpinto/oh-my-fish/stargazers","contributors_url":"https://api.github.com/repos/bpinto/oh-my-fish/contributors","subscribers_url":"https://api.github.com/repos/bpinto/oh-my-fish/subscribers","subscription_url":"https://api.github.com/repos/bpinto/oh-my-fish/subscription","commits_url":"https://api.github.com/repos/bpinto/oh-my-fish/commits{/sha}","git_commits_url":"https://api.github.com/repos/bpinto/oh-my-fish/git/commits{/sha}","comments_url":"https://api.github.com/repos/bpinto/oh-my-fish/comments{/number}","issue_comment_url":"https://api.github.com/repos/bpinto/oh-my-fish/issues/comments{/number}","contents_url":"https://api.github.com/repos/bpinto/oh-my-fish/contents/{+path}","compare_url":"https://api.github.com/repos/bpinto/oh-my-fish/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bpinto/oh-my-fish/merges","archive_url":"https://api.github.com/repos/bpinto/oh-my-fish/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bpinto/oh-my-fish/downloads","issues_url":"https://api.github.com/repos/bpinto/oh-my-fish/issues{/number}","pulls_url":"https://api.github.com/repos/bpinto/oh-my-fish/pulls{/number}","milestones_url":"https://api.github.com/repos/bpinto/oh-my-fish/milestones{/number}","notifications_url":"https://api.github.com/repos/bpinto/oh-my-fish/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bpinto/oh-my-fish/labels{/name}","releases_url":"https://api.github.com/repos/bpinto/oh-my-fish/releases{/id}","created_at":"2012-07-23T14:03:47Z","updated_at":"2015-02-23T16:46:20Z","pushed_at":"2015-02-23T22:12:42Z","git_url":"git://github.com/bpinto/oh-my-fish.git","ssh_url":"git@github.com:bpinto/oh-my-fish.git","clone_url":"https://github.com/bpinto/oh-my-fish.git","svn_url":"https://github.com/bpinto/oh-my-fish","homepage":null,"size":5113,"stargazers_count":1092,"watchers_count":1092,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":233,"mirror_url":null,"open_issues_count":15,"forks":233,"open_issues":15,"watchers":1092,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bpinto/oh-my-fish/pulls/390"},"html":{"href":"https://github.com/bpinto/oh-my-fish/pull/390"},"issue":{"href":"https://api.github.com/repos/bpinto/oh-my-fish/issues/390"},"comments":{"href":"https://api.github.com/repos/bpinto/oh-my-fish/issues/390/comments"},"review_comments":{"href":"https://api.github.com/repos/bpinto/oh-my-fish/pulls/390/comments"},"review_comment":{"href":"https://api.github.com/repos/bpinto/oh-my-fish/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bpinto/oh-my-fish/pulls/390/commits"},"statuses":{"href":"https://api.github.com/repos/bpinto/oh-my-fish/statuses/681d02b05aa4e307920b771b8a5117773637e88d"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"bpinto","id":526122,"avatar_url":"https://avatars.githubusercontent.com/u/526122?v=3","gravatar_id":"","url":"https://api.github.com/users/bpinto","html_url":"https://github.com/bpinto","followers_url":"https://api.github.com/users/bpinto/followers","following_url":"https://api.github.com/users/bpinto/following{/other_user}","gists_url":"https://api.github.com/users/bpinto/gists{/gist_id}","starred_url":"https://api.github.com/users/bpinto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bpinto/subscriptions","organizations_url":"https://api.github.com/users/bpinto/orgs","repos_url":"https://api.github.com/users/bpinto/repos","events_url":"https://api.github.com/users/bpinto/events{/privacy}","received_events_url":"https://api.github.com/users/bpinto/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":1,"additions":3,"deletions":3,"changed_files":1}}