{"action":"closed","number":12,"pull_request":{"url":"https://api.github.com/repos/YOURLS/antispam/pulls/12","id":30626798,"html_url":"https://github.com/YOURLS/antispam/pull/12","diff_url":"https://github.com/YOURLS/antispam/pull/12.diff","patch_url":"https://github.com/YOURLS/antispam/pull/12.patch","issue_url":"https://api.github.com/repos/YOURLS/antispam/issues/12","number":12,"state":"closed","locked":false,"title":"Bugfix: confusion about spamhaus' ZEN vs. DBL","user":{"login":"BstName","id":11042889,"avatar_url":"https://avatars.githubusercontent.com/u/11042889?v=3","gravatar_id":"","url":"https://api.github.com/users/BstName","html_url":"https://github.com/BstName","followers_url":"https://api.github.com/users/BstName/followers","following_url":"https://api.github.com/users/BstName/following{/other_user}","gists_url":"https://api.github.com/users/BstName/gists{/gist_id}","starred_url":"https://api.github.com/users/BstName/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BstName/subscriptions","organizations_url":"https://api.github.com/users/BstName/orgs","repos_url":"https://api.github.com/users/BstName/repos","events_url":"https://api.github.com/users/BstName/events{/privacy}","received_events_url":"https://api.github.com/users/BstName/received_events","type":"User","site_admin":false},"body":"Quoting http://www.spamhaus.org/zen/: \"ZEN is the combination of all Spamhaus IP-based DNSBLs into one single powerful and comprehensive blocklist to make querying faster and simpler. It contains the SBL, SBLCSS, XBL and PBL blocklists.\"\r\n\r\nThese are all IP-based block (or black) lists, i.e. they do not cover domain names. Your code however tests whether a hostname is blacklisted. Spamhaus has a separate list for this purpose, called the DBL. This is the list you should use here. For instance, on a Unix machine\r\n\r\nhost dbltest.com.zen.spamhaus.org \r\n\r\nwill report a non-existent domain, while \r\n\r\nhost dbltest.com.dbl.spamhaus.org\r\n\r\nwill result in the address 127.0.1.2, indicating a spam domain (in this case, this is just a permanent test point for the list). You can also use the unix 'dig' command instead of 'host', or 'nslookup' in a shell under MS Windows(tm).\r\n\r\nA perhaps more convincing example with a real spam domain (BE AWARE, DON'T VISIT IT):\r\n\r\nhost controlins.com.zen.spamhaus.org \r\n\r\nwill yield a non-existing domain, while \r\n\r\nhost controlins.com.dbl.spamhaus.org\r\n\r\nyields 127.0.1.2 (thus detecting the spam domain). You can also try shortening 'http://controlins.com-MUNGED' (without the '-MUNGED' part) in a YOURLS shortener, where the current version of the antispam plugin is activated. Since, unfortunately, neither SURBL nor URIBL, ATTOW, know the aforementioned spam domain, it will pass the check, and a short URL is created, duh. With the bug fix applied however (zen -> dbl), this filthy URI is rejected. \r\n\r\n(Again, this hold ATTOW, as you know things can change quickly, as the lists are being updated continuously).","created_at":"2015-03-06T07:56:02Z","updated_at":"2015-03-06T18:39:51Z","closed_at":"2015-03-06T18:39:51Z","merged_at":"2015-03-06T18:39:51Z","merge_commit_sha":"d55afd15945132be906831b24d7af22cb4b8ae17","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/YOURLS/antispam/pulls/12/commits","review_comments_url":"https://api.github.com/repos/YOURLS/antispam/pulls/12/comments","review_comment_url":"https://api.github.com/repos/YOURLS/antispam/pulls/comments{/number}","comments_url":"https://api.github.com/repos/YOURLS/antispam/issues/12/comments","statuses_url":"https://api.github.com/repos/YOURLS/antispam/statuses/022450a641258d71fd6c1f7ec21839095e005275","head":{"label":"BstName:bugfix","ref":"bugfix","sha":"022450a641258d71fd6c1f7ec21839095e005275","user":{"login":"BstName","id":11042889,"avatar_url":"https://avatars.githubusercontent.com/u/11042889?v=3","gravatar_id":"","url":"https://api.github.com/users/BstName","html_url":"https://github.com/BstName","followers_url":"https://api.github.com/users/BstName/followers","following_url":"https://api.github.com/users/BstName/following{/other_user}","gists_url":"https://api.github.com/users/BstName/gists{/gist_id}","starred_url":"https://api.github.com/users/BstName/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BstName/subscriptions","organizations_url":"https://api.github.com/users/BstName/orgs","repos_url":"https://api.github.com/users/BstName/repos","events_url":"https://api.github.com/users/BstName/events{/privacy}","received_events_url":"https://api.github.com/users/BstName/received_events","type":"User","site_admin":false},"repo":{"id":31757524,"name":"antispam","full_name":"BstName/antispam","owner":{"login":"BstName","id":11042889,"avatar_url":"https://avatars.githubusercontent.com/u/11042889?v=3","gravatar_id":"","url":"https://api.github.com/users/BstName","html_url":"https://github.com/BstName","followers_url":"https://api.github.com/users/BstName/followers","following_url":"https://api.github.com/users/BstName/following{/other_user}","gists_url":"https://api.github.com/users/BstName/gists{/gist_id}","starred_url":"https://api.github.com/users/BstName/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BstName/subscriptions","organizations_url":"https://api.github.com/users/BstName/orgs","repos_url":"https://api.github.com/users/BstName/repos","events_url":"https://api.github.com/users/BstName/events{/privacy}","received_events_url":"https://api.github.com/users/BstName/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/BstName/antispam","description":"YOURLS plugin: absolute anti-spam plugin. Checks URL against major black lists and removes all crap","fork":true,"url":"https://api.github.com/repos/BstName/antispam","forks_url":"https://api.github.com/repos/BstName/antispam/forks","keys_url":"https://api.github.com/repos/BstName/antispam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BstName/antispam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BstName/antispam/teams","hooks_url":"https://api.github.com/repos/BstName/antispam/hooks","issue_events_url":"https://api.github.com/repos/BstName/antispam/issues/events{/number}","events_url":"https://api.github.com/repos/BstName/antispam/events","assignees_url":"https://api.github.com/repos/BstName/antispam/assignees{/user}","branches_url":"https://api.github.com/repos/BstName/antispam/branches{/branch}","tags_url":"https://api.github.com/repos/BstName/antispam/tags","blobs_url":"https://api.github.com/repos/BstName/antispam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BstName/antispam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BstName/antispam/git/refs{/sha}","trees_url":"https://api.github.com/repos/BstName/antispam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BstName/antispam/statuses/{sha}","languages_url":"https://api.github.com/repos/BstName/antispam/languages","stargazers_url":"https://api.github.com/repos/BstName/antispam/stargazers","contributors_url":"https://api.github.com/repos/BstName/antispam/contributors","subscribers_url":"https://api.github.com/repos/BstName/antispam/subscribers","subscription_url":"https://api.github.com/repos/BstName/antispam/subscription","commits_url":"https://api.github.com/repos/BstName/antispam/commits{/sha}","git_commits_url":"https://api.github.com/repos/BstName/antispam/git/commits{/sha}","comments_url":"https://api.github.com/repos/BstName/antispam/comments{/number}","issue_comment_url":"https://api.github.com/repos/BstName/antispam/issues/comments{/number}","contents_url":"https://api.github.com/repos/BstName/antispam/contents/{+path}","compare_url":"https://api.github.com/repos/BstName/antispam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BstName/antispam/merges","archive_url":"https://api.github.com/repos/BstName/antispam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BstName/antispam/downloads","issues_url":"https://api.github.com/repos/BstName/antispam/issues{/number}","pulls_url":"https://api.github.com/repos/BstName/antispam/pulls{/number}","milestones_url":"https://api.github.com/repos/BstName/antispam/milestones{/number}","notifications_url":"https://api.github.com/repos/BstName/antispam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BstName/antispam/labels{/name}","releases_url":"https://api.github.com/repos/BstName/antispam/releases{/id}","created_at":"2015-03-06T07:23:02Z","updated_at":"2015-03-06T07:23:03Z","pushed_at":"2015-03-06T07:53:34Z","git_url":"git://github.com/BstName/antispam.git","ssh_url":"git@github.com:BstName/antispam.git","clone_url":"https://github.com/BstName/antispam.git","svn_url":"https://github.com/BstName/antispam","homepage":null,"size":83,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"YOURLS:master","ref":"master","sha":"57248220e037c5457532d0e6501795f033585417","user":{"login":"YOURLS","id":2106111,"avatar_url":"https://avatars.githubusercontent.com/u/2106111?v=3","gravatar_id":"","url":"https://api.github.com/users/YOURLS","html_url":"https://github.com/YOURLS","followers_url":"https://api.github.com/users/YOURLS/followers","following_url":"https://api.github.com/users/YOURLS/following{/other_user}","gists_url":"https://api.github.com/users/YOURLS/gists{/gist_id}","starred_url":"https://api.github.com/users/YOURLS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YOURLS/subscriptions","organizations_url":"https://api.github.com/users/YOURLS/orgs","repos_url":"https://api.github.com/users/YOURLS/repos","events_url":"https://api.github.com/users/YOURLS/events{/privacy}","received_events_url":"https://api.github.com/users/YOURLS/received_events","type":"Organization","site_admin":false},"repo":{"id":6838706,"name":"antispam","full_name":"YOURLS/antispam","owner":{"login":"YOURLS","id":2106111,"avatar_url":"https://avatars.githubusercontent.com/u/2106111?v=3","gravatar_id":"","url":"https://api.github.com/users/YOURLS","html_url":"https://github.com/YOURLS","followers_url":"https://api.github.com/users/YOURLS/followers","following_url":"https://api.github.com/users/YOURLS/following{/other_user}","gists_url":"https://api.github.com/users/YOURLS/gists{/gist_id}","starred_url":"https://api.github.com/users/YOURLS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YOURLS/subscriptions","organizations_url":"https://api.github.com/users/YOURLS/orgs","repos_url":"https://api.github.com/users/YOURLS/repos","events_url":"https://api.github.com/users/YOURLS/events{/privacy}","received_events_url":"https://api.github.com/users/YOURLS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/YOURLS/antispam","description":"YOURLS plugin: absolute anti-spam plugin. Checks URL against major black lists and removes all crap","fork":false,"url":"https://api.github.com/repos/YOURLS/antispam","forks_url":"https://api.github.com/repos/YOURLS/antispam/forks","keys_url":"https://api.github.com/repos/YOURLS/antispam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/YOURLS/antispam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/YOURLS/antispam/teams","hooks_url":"https://api.github.com/repos/YOURLS/antispam/hooks","issue_events_url":"https://api.github.com/repos/YOURLS/antispam/issues/events{/number}","events_url":"https://api.github.com/repos/YOURLS/antispam/events","assignees_url":"https://api.github.com/repos/YOURLS/antispam/assignees{/user}","branches_url":"https://api.github.com/repos/YOURLS/antispam/branches{/branch}","tags_url":"https://api.github.com/repos/YOURLS/antispam/tags","blobs_url":"https://api.github.com/repos/YOURLS/antispam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/YOURLS/antispam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/YOURLS/antispam/git/refs{/sha}","trees_url":"https://api.github.com/repos/YOURLS/antispam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/YOURLS/antispam/statuses/{sha}","languages_url":"https://api.github.com/repos/YOURLS/antispam/languages","stargazers_url":"https://api.github.com/repos/YOURLS/antispam/stargazers","contributors_url":"https://api.github.com/repos/YOURLS/antispam/contributors","subscribers_url":"https://api.github.com/repos/YOURLS/antispam/subscribers","subscription_url":"https://api.github.com/repos/YOURLS/antispam/subscription","commits_url":"https://api.github.com/repos/YOURLS/antispam/commits{/sha}","git_commits_url":"https://api.github.com/repos/YOURLS/antispam/git/commits{/sha}","comments_url":"https://api.github.com/repos/YOURLS/antispam/comments{/number}","issue_comment_url":"https://api.github.com/repos/YOURLS/antispam/issues/comments{/number}","contents_url":"https://api.github.com/repos/YOURLS/antispam/contents/{+path}","compare_url":"https://api.github.com/repos/YOURLS/antispam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/YOURLS/antispam/merges","archive_url":"https://api.github.com/repos/YOURLS/antispam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/YOURLS/antispam/downloads","issues_url":"https://api.github.com/repos/YOURLS/antispam/issues{/number}","pulls_url":"https://api.github.com/repos/YOURLS/antispam/pulls{/number}","milestones_url":"https://api.github.com/repos/YOURLS/antispam/milestones{/number}","notifications_url":"https://api.github.com/repos/YOURLS/antispam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/YOURLS/antispam/labels{/name}","releases_url":"https://api.github.com/repos/YOURLS/antispam/releases{/id}","created_at":"2012-11-24T10:39:07Z","updated_at":"2015-01-19T15:00:09Z","pushed_at":"2015-03-06T18:39:51Z","git_url":"git://github.com/YOURLS/antispam.git","ssh_url":"git@github.com:YOURLS/antispam.git","clone_url":"https://github.com/YOURLS/antispam.git","svn_url":"https://github.com/YOURLS/antispam","homepage":null,"size":208,"stargazers_count":13,"watchers_count":13,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":0,"forks":13,"open_issues":0,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/YOURLS/antispam/pulls/12"},"html":{"href":"https://github.com/YOURLS/antispam/pull/12"},"issue":{"href":"https://api.github.com/repos/YOURLS/antispam/issues/12"},"comments":{"href":"https://api.github.com/repos/YOURLS/antispam/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/YOURLS/antispam/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/YOURLS/antispam/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/YOURLS/antispam/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/YOURLS/antispam/statuses/022450a641258d71fd6c1f7ec21839095e005275"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"ozh","id":223647,"avatar_url":"https://avatars.githubusercontent.com/u/223647?v=3","gravatar_id":"","url":"https://api.github.com/users/ozh","html_url":"https://github.com/ozh","followers_url":"https://api.github.com/users/ozh/followers","following_url":"https://api.github.com/users/ozh/following{/other_user}","gists_url":"https://api.github.com/users/ozh/gists{/gist_id}","starred_url":"https://api.github.com/users/ozh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ozh/subscriptions","organizations_url":"https://api.github.com/users/ozh/orgs","repos_url":"https://api.github.com/users/ozh/repos","events_url":"https://api.github.com/users/ozh/events{/privacy}","received_events_url":"https://api.github.com/users/ozh/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}