{"action":"closed","number":358,"pull_request":{"url":"https://api.github.com/repos/mariocesar/sorl-thumbnail/pulls/358","id":30130617,"html_url":"https://github.com/mariocesar/sorl-thumbnail/pull/358","diff_url":"https://github.com/mariocesar/sorl-thumbnail/pull/358.diff","patch_url":"https://github.com/mariocesar/sorl-thumbnail/pull/358.patch","issue_url":"https://api.github.com/repos/mariocesar/sorl-thumbnail/issues/358","number":358,"state":"closed","locked":false,"title":"Fix convert_engine under Windows","user":{"login":"leture","id":288004,"avatar_url":"https://avatars.githubusercontent.com/u/288004?v=3","gravatar_id":"","url":"https://api.github.com/users/leture","html_url":"https://github.com/leture","followers_url":"https://api.github.com/users/leture/followers","following_url":"https://api.github.com/users/leture/following{/other_user}","gists_url":"https://api.github.com/users/leture/gists{/gist_id}","starred_url":"https://api.github.com/users/leture/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leture/subscriptions","organizations_url":"https://api.github.com/users/leture/orgs","repos_url":"https://api.github.com/users/leture/repos","events_url":"https://api.github.com/users/leture/events{/privacy}","received_events_url":"https://api.github.com/users/leture/received_events","type":"User","site_admin":false},"body":"According to\r\nhttps://docs.python.org/2/library/tempfile.html#tempfile.NamedTemporaryFile\r\nit is not possible under Windows that a temporary file, which is opened\r\nby the python process via NamedTemporaryFile, is used by another process\r\nat the same time. Therefore starting the subprocess inside the with\r\nNamedTemporaryFile block fails because the started process can not\r\naccess the created temporary file. The usage of tempfile.mkstemp allows\r\nthat the temporary file is not opened when the subprocess is started.","created_at":"2015-02-27T00:14:56Z","updated_at":"2015-08-03T14:07:20Z","closed_at":"2015-08-03T14:07:20Z","merged_at":null,"merge_commit_sha":"199eb709d766bbe785da2288a04319f74dda7446","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mariocesar/sorl-thumbnail/pulls/358/commits","review_comments_url":"https://api.github.com/repos/mariocesar/sorl-thumbnail/pulls/358/comments","review_comment_url":"https://api.github.com/repos/mariocesar/sorl-thumbnail/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mariocesar/sorl-thumbnail/issues/358/comments","statuses_url":"https://api.github.com/repos/mariocesar/sorl-thumbnail/statuses/4606a5ce19b5568e99e19dd14128eb594017fd86","head":{"label":"leture:master","ref":"master","sha":"4606a5ce19b5568e99e19dd14128eb594017fd86","user":{"login":"leture","id":288004,"avatar_url":"https://avatars.githubusercontent.com/u/288004?v=3","gravatar_id":"","url":"https://api.github.com/users/leture","html_url":"https://github.com/leture","followers_url":"https://api.github.com/users/leture/followers","following_url":"https://api.github.com/users/leture/following{/other_user}","gists_url":"https://api.github.com/users/leture/gists{/gist_id}","starred_url":"https://api.github.com/users/leture/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leture/subscriptions","organizations_url":"https://api.github.com/users/leture/orgs","repos_url":"https://api.github.com/users/leture/repos","events_url":"https://api.github.com/users/leture/events{/privacy}","received_events_url":"https://api.github.com/users/leture/received_events","type":"User","site_admin":false},"repo":{"id":31395304,"name":"sorl-thumbnail","full_name":"leture/sorl-thumbnail","owner":{"login":"leture","id":288004,"avatar_url":"https://avatars.githubusercontent.com/u/288004?v=3","gravatar_id":"","url":"https://api.github.com/users/leture","html_url":"https://github.com/leture","followers_url":"https://api.github.com/users/leture/followers","following_url":"https://api.github.com/users/leture/following{/other_user}","gists_url":"https://api.github.com/users/leture/gists{/gist_id}","starred_url":"https://api.github.com/users/leture/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leture/subscriptions","organizations_url":"https://api.github.com/users/leture/orgs","repos_url":"https://api.github.com/users/leture/repos","events_url":"https://api.github.com/users/leture/events{/privacy}","received_events_url":"https://api.github.com/users/leture/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/leture/sorl-thumbnail","description":"Thumbnails for Django","fork":true,"url":"https://api.github.com/repos/leture/sorl-thumbnail","forks_url":"https://api.github.com/repos/leture/sorl-thumbnail/forks","keys_url":"https://api.github.com/repos/leture/sorl-thumbnail/keys{/key_id}","collaborators_url":"https://api.github.com/repos/leture/sorl-thumbnail/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/leture/sorl-thumbnail/teams","hooks_url":"https://api.github.com/repos/leture/sorl-thumbnail/hooks","issue_events_url":"https://api.github.com/repos/leture/sorl-thumbnail/issues/events{/number}","events_url":"https://api.github.com/repos/leture/sorl-thumbnail/events","assignees_url":"https://api.github.com/repos/leture/sorl-thumbnail/assignees{/user}","branches_url":"https://api.github.com/repos/leture/sorl-thumbnail/branches{/branch}","tags_url":"https://api.github.com/repos/leture/sorl-thumbnail/tags","blobs_url":"https://api.github.com/repos/leture/sorl-thumbnail/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/leture/sorl-thumbnail/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/leture/sorl-thumbnail/git/refs{/sha}","trees_url":"https://api.github.com/repos/leture/sorl-thumbnail/git/trees{/sha}","statuses_url":"https://api.github.com/repos/leture/sorl-thumbnail/statuses/{sha}","languages_url":"https://api.github.com/repos/leture/sorl-thumbnail/languages","stargazers_url":"https://api.github.com/repos/leture/sorl-thumbnail/stargazers","contributors_url":"https://api.github.com/repos/leture/sorl-thumbnail/contributors","subscribers_url":"https://api.github.com/repos/leture/sorl-thumbnail/subscribers","subscription_url":"https://api.github.com/repos/leture/sorl-thumbnail/subscription","commits_url":"https://api.github.com/repos/leture/sorl-thumbnail/commits{/sha}","git_commits_url":"https://api.github.com/repos/leture/sorl-thumbnail/git/commits{/sha}","comments_url":"https://api.github.com/repos/leture/sorl-thumbnail/comments{/number}","issue_comment_url":"https://api.github.com/repos/leture/sorl-thumbnail/issues/comments{/number}","contents_url":"https://api.github.com/repos/leture/sorl-thumbnail/contents/{+path}","compare_url":"https://api.github.com/repos/leture/sorl-thumbnail/compare/{base}...{head}","merges_url":"https://api.github.com/repos/leture/sorl-thumbnail/merges","archive_url":"https://api.github.com/repos/leture/sorl-thumbnail/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/leture/sorl-thumbnail/downloads","issues_url":"https://api.github.com/repos/leture/sorl-thumbnail/issues{/number}","pulls_url":"https://api.github.com/repos/leture/sorl-thumbnail/pulls{/number}","milestones_url":"https://api.github.com/repos/leture/sorl-thumbnail/milestones{/number}","notifications_url":"https://api.github.com/repos/leture/sorl-thumbnail/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/leture/sorl-thumbnail/labels{/name}","releases_url":"https://api.github.com/repos/leture/sorl-thumbnail/releases{/id}","created_at":"2015-02-27T00:01:14Z","updated_at":"2015-03-05T14:11:29Z","pushed_at":"2015-03-05T14:11:28Z","git_url":"git://github.com/leture/sorl-thumbnail.git","ssh_url":"git@github.com:leture/sorl-thumbnail.git","clone_url":"https://github.com/leture/sorl-thumbnail.git","svn_url":"https://github.com/leture/sorl-thumbnail","homepage":"http://sorl-thumbnail.readthedocs.org/en/latest/","size":1784,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mariocesar:master","ref":"master","sha":"5568c79fe29d011a876ef6e7453794079dc4f0aa","user":{"login":"mariocesar","id":25034,"avatar_url":"https://avatars.githubusercontent.com/u/25034?v=3","gravatar_id":"","url":"https://api.github.com/users/mariocesar","html_url":"https://github.com/mariocesar","followers_url":"https://api.github.com/users/mariocesar/followers","following_url":"https://api.github.com/users/mariocesar/following{/other_user}","gists_url":"https://api.github.com/users/mariocesar/gists{/gist_id}","starred_url":"https://api.github.com/users/mariocesar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mariocesar/subscriptions","organizations_url":"https://api.github.com/users/mariocesar/orgs","repos_url":"https://api.github.com/users/mariocesar/repos","events_url":"https://api.github.com/users/mariocesar/events{/privacy}","received_events_url":"https://api.github.com/users/mariocesar/received_events","type":"User","site_admin":false},"repo":{"id":1073323,"name":"sorl-thumbnail","full_name":"mariocesar/sorl-thumbnail","owner":{"login":"mariocesar","id":25034,"avatar_url":"https://avatars.githubusercontent.com/u/25034?v=3","gravatar_id":"","url":"https://api.github.com/users/mariocesar","html_url":"https://github.com/mariocesar","followers_url":"https://api.github.com/users/mariocesar/followers","following_url":"https://api.github.com/users/mariocesar/following{/other_user}","gists_url":"https://api.github.com/users/mariocesar/gists{/gist_id}","starred_url":"https://api.github.com/users/mariocesar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mariocesar/subscriptions","organizations_url":"https://api.github.com/users/mariocesar/orgs","repos_url":"https://api.github.com/users/mariocesar/repos","events_url":"https://api.github.com/users/mariocesar/events{/privacy}","received_events_url":"https://api.github.com/users/mariocesar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mariocesar/sorl-thumbnail","description":"Thumbnails for Django","fork":false,"url":"https://api.github.com/repos/mariocesar/sorl-thumbnail","forks_url":"https://api.github.com/repos/mariocesar/sorl-thumbnail/forks","keys_url":"https://api.github.com/repos/mariocesar/sorl-thumbnail/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mariocesar/sorl-thumbnail/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mariocesar/sorl-thumbnail/teams","hooks_url":"https://api.github.com/repos/mariocesar/sorl-thumbnail/hooks","issue_events_url":"https://api.github.com/repos/mariocesar/sorl-thumbnail/issues/events{/number}","events_url":"https://api.github.com/repos/mariocesar/sorl-thumbnail/events","assignees_url":"https://api.github.com/repos/mariocesar/sorl-thumbnail/assignees{/user}","branches_url":"https://api.github.com/repos/mariocesar/sorl-thumbnail/branches{/branch}","tags_url":"https://api.github.com/repos/mariocesar/sorl-thumbnail/tags","blobs_url":"https://api.github.com/repos/mariocesar/sorl-thumbnail/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mariocesar/sorl-thumbnail/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mariocesar/sorl-thumbnail/git/refs{/sha}","trees_url":"https://api.github.com/repos/mariocesar/sorl-thumbnail/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mariocesar/sorl-thumbnail/statuses/{sha}","languages_url":"https://api.github.com/repos/mariocesar/sorl-thumbnail/languages","stargazers_url":"https://api.github.com/repos/mariocesar/sorl-thumbnail/stargazers","contributors_url":"https://api.github.com/repos/mariocesar/sorl-thumbnail/contributors","subscribers_url":"https://api.github.com/repos/mariocesar/sorl-thumbnail/subscribers","subscription_url":"https://api.github.com/repos/mariocesar/sorl-thumbnail/subscription","commits_url":"https://api.github.com/repos/mariocesar/sorl-thumbnail/commits{/sha}","git_commits_url":"https://api.github.com/repos/mariocesar/sorl-thumbnail/git/commits{/sha}","comments_url":"https://api.github.com/repos/mariocesar/sorl-thumbnail/comments{/number}","issue_comment_url":"https://api.github.com/repos/mariocesar/sorl-thumbnail/issues/comments{/number}","contents_url":"https://api.github.com/repos/mariocesar/sorl-thumbnail/contents/{+path}","compare_url":"https://api.github.com/repos/mariocesar/sorl-thumbnail/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mariocesar/sorl-thumbnail/merges","archive_url":"https://api.github.com/repos/mariocesar/sorl-thumbnail/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mariocesar/sorl-thumbnail/downloads","issues_url":"https://api.github.com/repos/mariocesar/sorl-thumbnail/issues{/number}","pulls_url":"https://api.github.com/repos/mariocesar/sorl-thumbnail/pulls{/number}","milestones_url":"https://api.github.com/repos/mariocesar/sorl-thumbnail/milestones{/number}","notifications_url":"https://api.github.com/repos/mariocesar/sorl-thumbnail/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mariocesar/sorl-thumbnail/labels{/name}","releases_url":"https://api.github.com/repos/mariocesar/sorl-thumbnail/releases{/id}","created_at":"2010-11-12T00:46:35Z","updated_at":"2015-08-01T04:42:50Z","pushed_at":"2015-08-03T14:01:04Z","git_url":"git://github.com/mariocesar/sorl-thumbnail.git","ssh_url":"git@github.com:mariocesar/sorl-thumbnail.git","clone_url":"https://github.com/mariocesar/sorl-thumbnail.git","svn_url":"https://github.com/mariocesar/sorl-thumbnail","homepage":"http://sorl-thumbnail.readthedocs.org/en/latest/","size":3270,"stargazers_count":843,"watchers_count":843,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":301,"mirror_url":null,"open_issues_count":40,"forks":301,"open_issues":40,"watchers":843,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mariocesar/sorl-thumbnail/pulls/358"},"html":{"href":"https://github.com/mariocesar/sorl-thumbnail/pull/358"},"issue":{"href":"https://api.github.com/repos/mariocesar/sorl-thumbnail/issues/358"},"comments":{"href":"https://api.github.com/repos/mariocesar/sorl-thumbnail/issues/358/comments"},"review_comments":{"href":"https://api.github.com/repos/mariocesar/sorl-thumbnail/pulls/358/comments"},"review_comment":{"href":"https://api.github.com/repos/mariocesar/sorl-thumbnail/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mariocesar/sorl-thumbnail/pulls/358/commits"},"statuses":{"href":"https://api.github.com/repos/mariocesar/sorl-thumbnail/statuses/4606a5ce19b5568e99e19dd14128eb594017fd86"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":6,"review_comments":0,"commits":5,"additions":40,"deletions":6,"changed_files":1}}