{"action":"created","comment":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/25847401","id":25847401,"diff_hunk":"@@ -32,7 +32,7 @@\n using namespace std;\n \n CVideoLibraryQueue::CVideoLibraryQueue()\n-  : CJobQueue(false, 1, CJob::PRIORITY_LOW_PAUSABLE),","path":"xbmc/video/VideoLibraryQueue.cpp","position":4,"original_position":4,"commit_id":"56f4790df7c00fb84a850412708ea5f7cd03cf9e","original_commit_id":"56f4790df7c00fb84a850412708ea5f7cd03cf9e","user":{"login":"arnova","id":544531,"avatar_url":"https://avatars.githubusercontent.com/u/544531?v=3","gravatar_id":"","url":"https://api.github.com/users/arnova","html_url":"https://github.com/arnova","followers_url":"https://api.github.com/users/arnova/followers","following_url":"https://api.github.com/users/arnova/following{/other_user}","gists_url":"https://api.github.com/users/arnova/gists{/gist_id}","starred_url":"https://api.github.com/users/arnova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arnova/subscriptions","organizations_url":"https://api.github.com/users/arnova/orgs","repos_url":"https://api.github.com/users/arnova/repos","events_url":"https://api.github.com/users/arnova/events{/privacy}","received_events_url":"https://api.github.com/users/arnova/received_events","type":"User","site_admin":false},"body":"Why not keep the _PAUSABLE here? Seems like you want these paused during e.g. video playback (to prevent stuttering etc.), right?","created_at":"2015-03-05T08:41:32Z","updated_at":"2015-03-05T08:41:32Z","html_url":"https://github.com/xbmc/xbmc/pull/6598#discussion_r25847401","pull_request_url":"https://api.github.com/repos/xbmc/xbmc/pulls/6598","_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/25847401"},"html":{"href":"https://github.com/xbmc/xbmc/pull/6598#discussion_r25847401"},"pull_request":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/6598"}}},"pull_request":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/6598","id":30445933,"html_url":"https://github.com/xbmc/xbmc/pull/6598","diff_url":"https://github.com/xbmc/xbmc/pull/6598.diff","patch_url":"https://github.com/xbmc/xbmc/pull/6598.patch","issue_url":"https://api.github.com/repos/xbmc/xbmc/issues/6598","number":6598,"state":"closed","locked":false,"title":"fix video library cleaning not initiated by a user blocking the main thread","user":{"login":"Montellese","id":75864,"avatar_url":"https://avatars.githubusercontent.com/u/75864?v=3","gravatar_id":"","url":"https://api.github.com/users/Montellese","html_url":"https://github.com/Montellese","followers_url":"https://api.github.com/users/Montellese/followers","following_url":"https://api.github.com/users/Montellese/following{/other_user}","gists_url":"https://api.github.com/users/Montellese/gists{/gist_id}","starred_url":"https://api.github.com/users/Montellese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Montellese/subscriptions","organizations_url":"https://api.github.com/users/Montellese/orgs","repos_url":"https://api.github.com/users/Montellese/repos","events_url":"https://api.github.com/users/Montellese/events{/privacy}","received_events_url":"https://api.github.com/users/Montellese/received_events","type":"User","site_admin":false},"body":"This should fix an issue reported by @MilhouseVH in #6406 that initiating a video library cleaning through JSON-RPC makes the GUI unresponsive and blocks input events from being handled.\r\nThe issue is that if the library cleaning initiated through JSON-RPC and without a dialog is performed in the main thread and not as a job. Therefore anything handled by the main thread (including input processing) is blocked by the video library cleaning task.\r\n\r\n@MilhouseVH: Please let me know if this solves the issue(s) for you. And thanks again for the detailed analysis.","created_at":"2015-03-04T08:22:59Z","updated_at":"2015-03-05T08:41:32Z","closed_at":"2015-03-04T17:21:48Z","merged_at":"2015-03-04T17:21:48Z","merge_commit_sha":"20a7bacdbb61ffb303914bca45deb70c086aac06","assignee":null,"milestone":{"url":"https://api.github.com/repos/xbmc/xbmc/milestones/58","html_url":"https://github.com/xbmc/xbmc/milestones/I*******%2015.0-alpha2","labels_url":"https://api.github.com/repos/xbmc/xbmc/milestones/58/labels","id":946522,"number":58,"title":"I******* 15.0-alpha2","description":"","creator":{"login":"Montellese","id":75864,"avatar_url":"https://avatars.githubusercontent.com/u/75864?v=3","gravatar_id":"","url":"https://api.github.com/users/Montellese","html_url":"https://github.com/Montellese","followers_url":"https://api.github.com/users/Montellese/followers","following_url":"https://api.github.com/users/Montellese/following{/other_user}","gists_url":"https://api.github.com/users/Montellese/gists{/gist_id}","starred_url":"https://api.github.com/users/Montellese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Montellese/subscriptions","organizations_url":"https://api.github.com/users/Montellese/orgs","repos_url":"https://api.github.com/users/Montellese/repos","events_url":"https://api.github.com/users/Montellese/events{/privacy}","received_events_url":"https://api.github.com/users/Montellese/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":51,"state":"open","created_at":"2015-01-22T07:34:16Z","updated_at":"2015-03-05T08:21:24Z","due_on":"2015-03-30T22:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/xbmc/xbmc/pulls/6598/commits","review_comments_url":"https://api.github.com/repos/xbmc/xbmc/pulls/6598/comments","review_comment_url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xbmc/xbmc/issues/6598/comments","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/56f4790df7c00fb84a850412708ea5f7cd03cf9e","head":{"label":"Montellese:fix_jsonrpc_clean_videolibrary","ref":"fix_jsonrpc_clean_videolibrary","sha":"56f4790df7c00fb84a850412708ea5f7cd03cf9e","user":{"login":"Montellese","id":75864,"avatar_url":"https://avatars.githubusercontent.com/u/75864?v=3","gravatar_id":"","url":"https://api.github.com/users/Montellese","html_url":"https://github.com/Montellese","followers_url":"https://api.github.com/users/Montellese/followers","following_url":"https://api.github.com/users/Montellese/following{/other_user}","gists_url":"https://api.github.com/users/Montellese/gists{/gist_id}","starred_url":"https://api.github.com/users/Montellese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Montellese/subscriptions","organizations_url":"https://api.github.com/users/Montellese/orgs","repos_url":"https://api.github.com/users/Montellese/repos","events_url":"https://api.github.com/users/Montellese/events{/privacy}","received_events_url":"https://api.github.com/users/Montellese/received_events","type":"User","site_admin":false},"repo":{"id":1287028,"name":"xbmc","full_name":"Montellese/xbmc","owner":{"login":"Montellese","id":75864,"avatar_url":"https://avatars.githubusercontent.com/u/75864?v=3","gravatar_id":"","url":"https://api.github.com/users/Montellese","html_url":"https://github.com/Montellese","followers_url":"https://api.github.com/users/Montellese/followers","following_url":"https://api.github.com/users/Montellese/following{/other_user}","gists_url":"https://api.github.com/users/Montellese/gists{/gist_id}","starred_url":"https://api.github.com/users/Montellese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Montellese/subscriptions","organizations_url":"https://api.github.com/users/Montellese/orgs","repos_url":"https://api.github.com/users/Montellese/repos","events_url":"https://api.github.com/users/Montellese/events{/privacy}","received_events_url":"https://api.github.com/users/Montellese/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Montellese/xbmc","description":"Montellese's fork of XBMC ","fork":true,"url":"https://api.github.com/repos/Montellese/xbmc","forks_url":"https://api.github.com/repos/Montellese/xbmc/forks","keys_url":"https://api.github.com/repos/Montellese/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Montellese/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Montellese/xbmc/teams","hooks_url":"https://api.github.com/repos/Montellese/xbmc/hooks","issue_events_url":"https://api.github.com/repos/Montellese/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/Montellese/xbmc/events","assignees_url":"https://api.github.com/repos/Montellese/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/Montellese/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/Montellese/xbmc/tags","blobs_url":"https://api.github.com/repos/Montellese/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Montellese/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Montellese/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/Montellese/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Montellese/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/Montellese/xbmc/languages","stargazers_url":"https://api.github.com/repos/Montellese/xbmc/stargazers","contributors_url":"https://api.github.com/repos/Montellese/xbmc/contributors","subscribers_url":"https://api.github.com/repos/Montellese/xbmc/subscribers","subscription_url":"https://api.github.com/repos/Montellese/xbmc/subscription","commits_url":"https://api.github.com/repos/Montellese/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/Montellese/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/Montellese/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/Montellese/xbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/Montellese/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/Montellese/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Montellese/xbmc/merges","archive_url":"https://api.github.com/repos/Montellese/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Montellese/xbmc/downloads","issues_url":"https://api.github.com/repos/Montellese/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/Montellese/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/Montellese/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/Montellese/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Montellese/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/Montellese/xbmc/releases{/id}","created_at":"2011-01-24T08:36:12Z","updated_at":"2015-03-04T21:21:20Z","pushed_at":"2015-03-04T21:21:20Z","git_url":"git://github.com/Montellese/xbmc.git","ssh_url":"git@github.com:Montellese/xbmc.git","clone_url":"https://github.com/Montellese/xbmc.git","svn_url":"https://github.com/Montellese/xbmc","homepage":"http://xbmc.org","size":502551,"stargazers_count":4,"watchers_count":4,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":4,"default_branch":"master"}},"base":{"label":"xbmc:master","ref":"master","sha":"15a408b01002db69c6497114d41d04ba5560a05d","user":{"login":"xbmc","id":199122,"avatar_url":"https://avatars.githubusercontent.com/u/199122?v=3","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"repo":{"id":1217614,"name":"xbmc","full_name":"xbmc/xbmc","owner":{"login":"xbmc","id":199122,"avatar_url":"https://avatars.githubusercontent.com/u/199122?v=3","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xbmc/xbmc","description":"Kodi Main Repository - By using this code you agree with our policy and will follow the GPLv2 license as included","fork":false,"url":"https://api.github.com/repos/xbmc/xbmc","forks_url":"https://api.github.com/repos/xbmc/xbmc/forks","keys_url":"https://api.github.com/repos/xbmc/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xbmc/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xbmc/xbmc/teams","hooks_url":"https://api.github.com/repos/xbmc/xbmc/hooks","issue_events_url":"https://api.github.com/repos/xbmc/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/xbmc/xbmc/events","assignees_url":"https://api.github.com/repos/xbmc/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/xbmc/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/xbmc/xbmc/tags","blobs_url":"https://api.github.com/repos/xbmc/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xbmc/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xbmc/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/xbmc/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/xbmc/xbmc/languages","stargazers_url":"https://api.github.com/repos/xbmc/xbmc/stargazers","contributors_url":"https://api.github.com/repos/xbmc/xbmc/contributors","subscribers_url":"https://api.github.com/repos/xbmc/xbmc/subscribers","subscription_url":"https://api.github.com/repos/xbmc/xbmc/subscription","commits_url":"https://api.github.com/repos/xbmc/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/xbmc/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/xbmc/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/xbmc/xbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/xbmc/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/xbmc/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xbmc/xbmc/merges","archive_url":"https://api.github.com/repos/xbmc/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xbmc/xbmc/downloads","issues_url":"https://api.github.com/repos/xbmc/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/xbmc/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/xbmc/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/xbmc/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xbmc/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/xbmc/xbmc/releases{/id}","created_at":"2011-01-03T21:18:51Z","updated_at":"2015-03-05T05:46:52Z","pushed_at":"2015-03-05T05:41:55Z","git_url":"git://github.com/xbmc/xbmc.git","ssh_url":"git@github.com:xbmc/xbmc.git","clone_url":"https://github.com/xbmc/xbmc.git","svn_url":"https://github.com/xbmc/xbmc","homepage":"http://kodi.wiki/view/Official:Trademark_Policy","size":1823734,"stargazers_count":3745,"watchers_count":3745,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2709,"mirror_url":null,"open_issues_count":234,"forks":2709,"open_issues":234,"watchers":3745,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/6598"},"html":{"href":"https://github.com/xbmc/xbmc/pull/6598"},"issue":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/6598"},"comments":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/6598/comments"},"review_comments":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/6598/comments"},"review_comment":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/6598/commits"},"statuses":{"href":"https://api.github.com/repos/xbmc/xbmc/statuses/56f4790df7c00fb84a850412708ea5f7cd03cf9e"}}}}