{"action":"closed","number":331,"pull_request":{"url":"https://api.github.com/repos/mozilla/teach.webmaker.org/pulls/331","id":31544336,"html_url":"https://github.com/mozilla/teach.webmaker.org/pull/331","diff_url":"https://github.com/mozilla/teach.webmaker.org/pull/331.diff","patch_url":"https://github.com/mozilla/teach.webmaker.org/pull/331.patch","issue_url":"https://api.github.com/repos/mozilla/teach.webmaker.org/issues/331","number":331,"state":"closed","locked":false,"title":"Manually set heights for each device and improve display","user":{"login":"k88hudson","id":1455535,"avatar_url":"https://avatars.githubusercontent.com/u/1455535?v=3","gravatar_id":"","url":"https://api.github.com/users/k88hudson","html_url":"https://github.com/k88hudson","followers_url":"https://api.github.com/users/k88hudson/followers","following_url":"https://api.github.com/users/k88hudson/following{/other_user}","gists_url":"https://api.github.com/users/k88hudson/gists{/gist_id}","starred_url":"https://api.github.com/users/k88hudson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k88hudson/subscriptions","organizations_url":"https://api.github.com/users/k88hudson/orgs","repos_url":"https://api.github.com/users/k88hudson/repos","events_url":"https://api.github.com/users/k88hudson/events{/privacy}","received_events_url":"https://api.github.com/users/k88hudson/received_events","type":"User","site_admin":false},"body":"I love the manual tests page! It's pretty awesome.\r\n\r\nJust a few things here:\r\n\r\n* changed the device widths to match up with more common devices\r\n* move the devices object up to the top so it's easier to maintain/add to etc.\r\n* manually set height since it will be more useful for testing actual device sizes, above the fold, etc.\r\n* do actual sizes + scroll x instead of scaling -- i think especially for checking visual details, it's preferable to check the actual size and just scroll horizontally\r\n* show mobile first in the queue since it's the most different/most likely to be overlooked \r\n* move the labels to the top of the manual test iframes so they're easier to see/read\r\n* add a bit more emphasis to the route links to distinguish the sections\r\n\r\nWhat do you think @toolness @gvn?","created_at":"2015-03-19T17:08:35Z","updated_at":"2015-03-19T18:10:04Z","closed_at":"2015-03-19T18:10:04Z","merged_at":"2015-03-19T18:10:04Z","merge_commit_sha":"76a66c83bc15fe3bc699a3d3c3c6e156f876a6f1","assignee":{"login":"toolness","id":124687,"avatar_url":"https://avatars.githubusercontent.com/u/124687?v=3","gravatar_id":"","url":"https://api.github.com/users/toolness","html_url":"https://github.com/toolness","followers_url":"https://api.github.com/users/toolness/followers","following_url":"https://api.github.com/users/toolness/following{/other_user}","gists_url":"https://api.github.com/users/toolness/gists{/gist_id}","starred_url":"https://api.github.com/users/toolness/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toolness/subscriptions","organizations_url":"https://api.github.com/users/toolness/orgs","repos_url":"https://api.github.com/users/toolness/repos","events_url":"https://api.github.com/users/toolness/events{/privacy}","received_events_url":"https://api.github.com/users/toolness/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/teach.webmaker.org/pulls/331/commits","review_comments_url":"https://api.github.com/repos/mozilla/teach.webmaker.org/pulls/331/comments","review_comment_url":"https://api.github.com/repos/mozilla/teach.webmaker.org/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/teach.webmaker.org/issues/331/comments","statuses_url":"https://api.github.com/repos/mozilla/teach.webmaker.org/statuses/fe40a45c161bb0c1cac965dd84102751a77993fc","head":{"label":"k88hudson:manual","ref":"manual","sha":"fe40a45c161bb0c1cac965dd84102751a77993fc","user":{"login":"k88hudson","id":1455535,"avatar_url":"https://avatars.githubusercontent.com/u/1455535?v=3","gravatar_id":"","url":"https://api.github.com/users/k88hudson","html_url":"https://github.com/k88hudson","followers_url":"https://api.github.com/users/k88hudson/followers","following_url":"https://api.github.com/users/k88hudson/following{/other_user}","gists_url":"https://api.github.com/users/k88hudson/gists{/gist_id}","starred_url":"https://api.github.com/users/k88hudson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k88hudson/subscriptions","organizations_url":"https://api.github.com/users/k88hudson/orgs","repos_url":"https://api.github.com/users/k88hudson/repos","events_url":"https://api.github.com/users/k88hudson/events{/privacy}","received_events_url":"https://api.github.com/users/k88hudson/received_events","type":"User","site_admin":false},"repo":{"id":32468507,"name":"teach.webmaker.org","full_name":"k88hudson/teach.webmaker.org","owner":{"login":"k88hudson","id":1455535,"avatar_url":"https://avatars.githubusercontent.com/u/1455535?v=3","gravatar_id":"","url":"https://api.github.com/users/k88hudson","html_url":"https://github.com/k88hudson","followers_url":"https://api.github.com/users/k88hudson/followers","following_url":"https://api.github.com/users/k88hudson/following{/other_user}","gists_url":"https://api.github.com/users/k88hudson/gists{/gist_id}","starred_url":"https://api.github.com/users/k88hudson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k88hudson/subscriptions","organizations_url":"https://api.github.com/users/k88hudson/orgs","repos_url":"https://api.github.com/users/k88hudson/repos","events_url":"https://api.github.com/users/k88hudson/events{/privacy}","received_events_url":"https://api.github.com/users/k88hudson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/k88hudson/teach.webmaker.org","description":"This repo is for tracking initiatives of the Mozilla Learning Networks team.","fork":true,"url":"https://api.github.com/repos/k88hudson/teach.webmaker.org","forks_url":"https://api.github.com/repos/k88hudson/teach.webmaker.org/forks","keys_url":"https://api.github.com/repos/k88hudson/teach.webmaker.org/keys{/key_id}","collaborators_url":"https://api.github.com/repos/k88hudson/teach.webmaker.org/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/k88hudson/teach.webmaker.org/teams","hooks_url":"https://api.github.com/repos/k88hudson/teach.webmaker.org/hooks","issue_events_url":"https://api.github.com/repos/k88hudson/teach.webmaker.org/issues/events{/number}","events_url":"https://api.github.com/repos/k88hudson/teach.webmaker.org/events","assignees_url":"https://api.github.com/repos/k88hudson/teach.webmaker.org/assignees{/user}","branches_url":"https://api.github.com/repos/k88hudson/teach.webmaker.org/branches{/branch}","tags_url":"https://api.github.com/repos/k88hudson/teach.webmaker.org/tags","blobs_url":"https://api.github.com/repos/k88hudson/teach.webmaker.org/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/k88hudson/teach.webmaker.org/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/k88hudson/teach.webmaker.org/git/refs{/sha}","trees_url":"https://api.github.com/repos/k88hudson/teach.webmaker.org/git/trees{/sha}","statuses_url":"https://api.github.com/repos/k88hudson/teach.webmaker.org/statuses/{sha}","languages_url":"https://api.github.com/repos/k88hudson/teach.webmaker.org/languages","stargazers_url":"https://api.github.com/repos/k88hudson/teach.webmaker.org/stargazers","contributors_url":"https://api.github.com/repos/k88hudson/teach.webmaker.org/contributors","subscribers_url":"https://api.github.com/repos/k88hudson/teach.webmaker.org/subscribers","subscription_url":"https://api.github.com/repos/k88hudson/teach.webmaker.org/subscription","commits_url":"https://api.github.com/repos/k88hudson/teach.webmaker.org/commits{/sha}","git_commits_url":"https://api.github.com/repos/k88hudson/teach.webmaker.org/git/commits{/sha}","comments_url":"https://api.github.com/repos/k88hudson/teach.webmaker.org/comments{/number}","issue_comment_url":"https://api.github.com/repos/k88hudson/teach.webmaker.org/issues/comments{/number}","contents_url":"https://api.github.com/repos/k88hudson/teach.webmaker.org/contents/{+path}","compare_url":"https://api.github.com/repos/k88hudson/teach.webmaker.org/compare/{base}...{head}","merges_url":"https://api.github.com/repos/k88hudson/teach.webmaker.org/merges","archive_url":"https://api.github.com/repos/k88hudson/teach.webmaker.org/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/k88hudson/teach.webmaker.org/downloads","issues_url":"https://api.github.com/repos/k88hudson/teach.webmaker.org/issues{/number}","pulls_url":"https://api.github.com/repos/k88hudson/teach.webmaker.org/pulls{/number}","milestones_url":"https://api.github.com/repos/k88hudson/teach.webmaker.org/milestones{/number}","notifications_url":"https://api.github.com/repos/k88hudson/teach.webmaker.org/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/k88hudson/teach.webmaker.org/labels{/name}","releases_url":"https://api.github.com/repos/k88hudson/teach.webmaker.org/releases{/id}","created_at":"2015-03-18T15:52:03Z","updated_at":"2015-03-18T15:52:05Z","pushed_at":"2015-03-19T17:05:15Z","git_url":"git://github.com/k88hudson/teach.webmaker.org.git","ssh_url":"git@github.com:k88hudson/teach.webmaker.org.git","clone_url":"https://github.com/k88hudson/teach.webmaker.org.git","svn_url":"https://github.com/k88hudson/teach.webmaker.org","homepage":"http://teach.mofostaging.net/","size":10121,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"mozilla:develop","ref":"develop","sha":"e212762372af586d5a43e41a2e483ca7e73b13b1","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":30430269,"name":"teach.webmaker.org","full_name":"mozilla/teach.webmaker.org","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/teach.webmaker.org","description":"This repo is for tracking initiatives of the Mozilla Learning Networks team.","fork":false,"url":"https://api.github.com/repos/mozilla/teach.webmaker.org","forks_url":"https://api.github.com/repos/mozilla/teach.webmaker.org/forks","keys_url":"https://api.github.com/repos/mozilla/teach.webmaker.org/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/teach.webmaker.org/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/teach.webmaker.org/teams","hooks_url":"https://api.github.com/repos/mozilla/teach.webmaker.org/hooks","issue_events_url":"https://api.github.com/repos/mozilla/teach.webmaker.org/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/teach.webmaker.org/events","assignees_url":"https://api.github.com/repos/mozilla/teach.webmaker.org/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/teach.webmaker.org/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/teach.webmaker.org/tags","blobs_url":"https://api.github.com/repos/mozilla/teach.webmaker.org/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/teach.webmaker.org/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/teach.webmaker.org/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/teach.webmaker.org/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/teach.webmaker.org/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/teach.webmaker.org/languages","stargazers_url":"https://api.github.com/repos/mozilla/teach.webmaker.org/stargazers","contributors_url":"https://api.github.com/repos/mozilla/teach.webmaker.org/contributors","subscribers_url":"https://api.github.com/repos/mozilla/teach.webmaker.org/subscribers","subscription_url":"https://api.github.com/repos/mozilla/teach.webmaker.org/subscription","commits_url":"https://api.github.com/repos/mozilla/teach.webmaker.org/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/teach.webmaker.org/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/teach.webmaker.org/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/teach.webmaker.org/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/teach.webmaker.org/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/teach.webmaker.org/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/teach.webmaker.org/merges","archive_url":"https://api.github.com/repos/mozilla/teach.webmaker.org/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/teach.webmaker.org/downloads","issues_url":"https://api.github.com/repos/mozilla/teach.webmaker.org/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/teach.webmaker.org/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/teach.webmaker.org/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/teach.webmaker.org/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/teach.webmaker.org/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/teach.webmaker.org/releases{/id}","created_at":"2015-02-06T19:54:24Z","updated_at":"2015-03-19T17:43:07Z","pushed_at":"2015-03-19T18:10:04Z","git_url":"git://github.com/mozilla/teach.webmaker.org.git","ssh_url":"git@github.com:mozilla/teach.webmaker.org.git","clone_url":"https://github.com/mozilla/teach.webmaker.org.git","svn_url":"https://github.com/mozilla/teach.webmaker.org","homepage":"http://teach.mofostaging.net/","size":10121,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":106,"forks":9,"open_issues":106,"watchers":2,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/teach.webmaker.org/pulls/331"},"html":{"href":"https://github.com/mozilla/teach.webmaker.org/pull/331"},"issue":{"href":"https://api.github.com/repos/mozilla/teach.webmaker.org/issues/331"},"comments":{"href":"https://api.github.com/repos/mozilla/teach.webmaker.org/issues/331/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/teach.webmaker.org/pulls/331/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/teach.webmaker.org/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/teach.webmaker.org/pulls/331/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/teach.webmaker.org/statuses/fe40a45c161bb0c1cac965dd84102751a77993fc"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"toolness","id":124687,"avatar_url":"https://avatars.githubusercontent.com/u/124687?v=3","gravatar_id":"","url":"https://api.github.com/users/toolness","html_url":"https://github.com/toolness","followers_url":"https://api.github.com/users/toolness/followers","following_url":"https://api.github.com/users/toolness/following{/other_user}","gists_url":"https://api.github.com/users/toolness/gists{/gist_id}","starred_url":"https://api.github.com/users/toolness/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toolness/subscriptions","organizations_url":"https://api.github.com/users/toolness/orgs","repos_url":"https://api.github.com/users/toolness/repos","events_url":"https://api.github.com/users/toolness/events{/privacy}","received_events_url":"https://api.github.com/users/toolness/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":1,"additions":75,"deletions":70,"changed_files":2}}