{"action":"created","issue":{"url":"https://api.github.com/repos/JamesNK/Newtonsoft.Json/issues/648","labels_url":"https://api.github.com/repos/JamesNK/Newtonsoft.Json/issues/648/labels{/name}","comments_url":"https://api.github.com/repos/JamesNK/Newtonsoft.Json/issues/648/comments","events_url":"https://api.github.com/repos/JamesNK/Newtonsoft.Json/issues/648/events","html_url":"https://github.com/JamesNK/Newtonsoft.Json/pull/648","id":106188954,"number":648,"title":"Use yield in GetFieldsAndProperties","user":{"login":"jamesqo","id":9159214,"avatar_url":"https://avatars.githubusercontent.com/u/9159214?v=3","gravatar_id":"","url":"https://api.github.com/users/jamesqo","html_url":"https://github.com/jamesqo","followers_url":"https://api.github.com/users/jamesqo/followers","following_url":"https://api.github.com/users/jamesqo/following{/other_user}","gists_url":"https://api.github.com/users/jamesqo/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesqo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesqo/subscriptions","organizations_url":"https://api.github.com/users/jamesqo/orgs","repos_url":"https://api.github.com/users/jamesqo/repos","events_url":"https://api.github.com/users/jamesqo/events{/privacy}","received_events_url":"https://api.github.com/users/jamesqo/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-09-12T22:49:59Z","updated_at":"2015-10-03T01:38:32Z","closed_at":"2015-10-03T01:38:32Z","pull_request":{"url":"https://api.github.com/repos/JamesNK/Newtonsoft.Json/pulls/648","html_url":"https://github.com/JamesNK/Newtonsoft.Json/pull/648","diff_url":"https://github.com/JamesNK/Newtonsoft.Json/pull/648.diff","patch_url":"https://github.com/JamesNK/Newtonsoft.Json/pull/648.patch"},"body":"By using yield instead of `List<T>`, we avoid the overhead of newing several new Lists and don't enumerate through the collection when we don't have to.\r\n\r\nAssociated caller has been fixed in `DefaultContractResolver`."},"comment":{"url":"https://api.github.com/repos/JamesNK/Newtonsoft.Json/issues/comments/145192070","html_url":"https://github.com/JamesNK/Newtonsoft.Json/pull/648#issuecomment-145192070","issue_url":"https://api.github.com/repos/JamesNK/Newtonsoft.Json/issues/648","id":145192070,"user":{"login":"JamesNK","id":303201,"avatar_url":"https://avatars.githubusercontent.com/u/303201?v=3","gravatar_id":"","url":"https://api.github.com/users/JamesNK","html_url":"https://github.com/JamesNK","followers_url":"https://api.github.com/users/JamesNK/followers","following_url":"https://api.github.com/users/JamesNK/following{/other_user}","gists_url":"https://api.github.com/users/JamesNK/gists{/gist_id}","starred_url":"https://api.github.com/users/JamesNK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JamesNK/subscriptions","organizations_url":"https://api.github.com/users/JamesNK/orgs","repos_url":"https://api.github.com/users/JamesNK/repos","events_url":"https://api.github.com/users/JamesNK/events{/privacy}","received_events_url":"https://api.github.com/users/JamesNK/received_events","type":"User","site_admin":false},"created_at":"2015-10-03T01:38:32Z","updated_at":"2015-10-03T01:38:32Z","body":"I don't want to merge this. I know it is more efficient but GetFieldsAndProperties is only called when an object is serialized for the first time so its performance isn't important. And yield produces a lot more IL for the state machine and I don't want the DLL size to grow too large."}}