{"action":"closed","number":7,"pull_request":{"url":"https://api.github.com/repos/prismicio/csharp-kit/pulls/7","id":43096599,"html_url":"https://github.com/prismicio/csharp-kit/pull/7","diff_url":"https://github.com/prismicio/csharp-kit/pull/7.diff","patch_url":"https://github.com/prismicio/csharp-kit/pull/7.patch","issue_url":"https://api.github.com/repos/prismicio/csharp-kit/issues/7","number":7,"state":"closed","locked":false,"title":"Changing Number fragment from Double to Decimal and fixing issues with culture","user":{"login":"tucaz","id":111954,"avatar_url":"https://avatars.githubusercontent.com/u/111954?v=3","gravatar_id":"","url":"https://api.github.com/users/tucaz","html_url":"https://github.com/tucaz","followers_url":"https://api.github.com/users/tucaz/followers","following_url":"https://api.github.com/users/tucaz/following{/other_user}","gists_url":"https://api.github.com/users/tucaz/gists{/gist_id}","starred_url":"https://api.github.com/users/tucaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tucaz/subscriptions","organizations_url":"https://api.github.com/users/tucaz/orgs","repos_url":"https://api.github.com/users/tucaz/repos","events_url":"https://api.github.com/users/tucaz/events{/privacy}","received_events_url":"https://api.github.com/users/tucaz/received_events","type":"User","site_admin":false},"body":"This pull request is a follow up on my previous request regarding the choice of Double instead of Decimal to represent non integer numbers inside the API. Decimal is much more common, widely used and precise when dealing with decimal point number such as money. As recommended I changed the Number fragment to return Decimal.\r\n\r\nIt also addresses a problem where GeoPoint, Number and Date parsing were failing and behaving in a non consistent way depending on the client's default machine CultureInfo because the API didn't use a default CultureInfo (en-US). This could cause a number to return 25 instead of 2.5 and status 400 responses in the server API when the date was not in mm-dd-yyyy format (which is pretty much all of the world except the US and a few other countries).","created_at":"2015-08-22T03:18:45Z","updated_at":"2015-09-03T09:51:35Z","closed_at":"2015-09-03T09:51:35Z","merged_at":"2015-09-03T09:51:35Z","merge_commit_sha":"75a900034c997f2b536c6bacb51a3b8a6f4c28fc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/prismicio/csharp-kit/pulls/7/commits","review_comments_url":"https://api.github.com/repos/prismicio/csharp-kit/pulls/7/comments","review_comment_url":"https://api.github.com/repos/prismicio/csharp-kit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/prismicio/csharp-kit/issues/7/comments","statuses_url":"https://api.github.com/repos/prismicio/csharp-kit/statuses/9a700b06d31d983e5d6f4cbb50d5147000578b88","head":{"label":"tucaz:master","ref":"master","sha":"9a700b06d31d983e5d6f4cbb50d5147000578b88","user":{"login":"tucaz","id":111954,"avatar_url":"https://avatars.githubusercontent.com/u/111954?v=3","gravatar_id":"","url":"https://api.github.com/users/tucaz","html_url":"https://github.com/tucaz","followers_url":"https://api.github.com/users/tucaz/followers","following_url":"https://api.github.com/users/tucaz/following{/other_user}","gists_url":"https://api.github.com/users/tucaz/gists{/gist_id}","starred_url":"https://api.github.com/users/tucaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tucaz/subscriptions","organizations_url":"https://api.github.com/users/tucaz/orgs","repos_url":"https://api.github.com/users/tucaz/repos","events_url":"https://api.github.com/users/tucaz/events{/privacy}","received_events_url":"https://api.github.com/users/tucaz/received_events","type":"User","site_admin":false},"repo":{"id":41186576,"name":"csharp-kit","full_name":"tucaz/csharp-kit","owner":{"login":"tucaz","id":111954,"avatar_url":"https://avatars.githubusercontent.com/u/111954?v=3","gravatar_id":"","url":"https://api.github.com/users/tucaz","html_url":"https://github.com/tucaz","followers_url":"https://api.github.com/users/tucaz/followers","following_url":"https://api.github.com/users/tucaz/following{/other_user}","gists_url":"https://api.github.com/users/tucaz/gists{/gist_id}","starred_url":"https://api.github.com/users/tucaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tucaz/subscriptions","organizations_url":"https://api.github.com/users/tucaz/orgs","repos_url":"https://api.github.com/users/tucaz/repos","events_url":"https://api.github.com/users/tucaz/events{/privacy}","received_events_url":"https://api.github.com/users/tucaz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tucaz/csharp-kit","description":"Development kit for the C# language","fork":true,"url":"https://api.github.com/repos/tucaz/csharp-kit","forks_url":"https://api.github.com/repos/tucaz/csharp-kit/forks","keys_url":"https://api.github.com/repos/tucaz/csharp-kit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tucaz/csharp-kit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tucaz/csharp-kit/teams","hooks_url":"https://api.github.com/repos/tucaz/csharp-kit/hooks","issue_events_url":"https://api.github.com/repos/tucaz/csharp-kit/issues/events{/number}","events_url":"https://api.github.com/repos/tucaz/csharp-kit/events","assignees_url":"https://api.github.com/repos/tucaz/csharp-kit/assignees{/user}","branches_url":"https://api.github.com/repos/tucaz/csharp-kit/branches{/branch}","tags_url":"https://api.github.com/repos/tucaz/csharp-kit/tags","blobs_url":"https://api.github.com/repos/tucaz/csharp-kit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tucaz/csharp-kit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tucaz/csharp-kit/git/refs{/sha}","trees_url":"https://api.github.com/repos/tucaz/csharp-kit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tucaz/csharp-kit/statuses/{sha}","languages_url":"https://api.github.com/repos/tucaz/csharp-kit/languages","stargazers_url":"https://api.github.com/repos/tucaz/csharp-kit/stargazers","contributors_url":"https://api.github.com/repos/tucaz/csharp-kit/contributors","subscribers_url":"https://api.github.com/repos/tucaz/csharp-kit/subscribers","subscription_url":"https://api.github.com/repos/tucaz/csharp-kit/subscription","commits_url":"https://api.github.com/repos/tucaz/csharp-kit/commits{/sha}","git_commits_url":"https://api.github.com/repos/tucaz/csharp-kit/git/commits{/sha}","comments_url":"https://api.github.com/repos/tucaz/csharp-kit/comments{/number}","issue_comment_url":"https://api.github.com/repos/tucaz/csharp-kit/issues/comments{/number}","contents_url":"https://api.github.com/repos/tucaz/csharp-kit/contents/{+path}","compare_url":"https://api.github.com/repos/tucaz/csharp-kit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tucaz/csharp-kit/merges","archive_url":"https://api.github.com/repos/tucaz/csharp-kit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tucaz/csharp-kit/downloads","issues_url":"https://api.github.com/repos/tucaz/csharp-kit/issues{/number}","pulls_url":"https://api.github.com/repos/tucaz/csharp-kit/pulls{/number}","milestones_url":"https://api.github.com/repos/tucaz/csharp-kit/milestones{/number}","notifications_url":"https://api.github.com/repos/tucaz/csharp-kit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tucaz/csharp-kit/labels{/name}","releases_url":"https://api.github.com/repos/tucaz/csharp-kit/releases{/id}","created_at":"2015-08-22T02:35:19Z","updated_at":"2015-08-22T02:35:20Z","pushed_at":"2015-08-22T03:10:47Z","git_url":"git://github.com/tucaz/csharp-kit.git","ssh_url":"git@github.com:tucaz/csharp-kit.git","clone_url":"https://github.com/tucaz/csharp-kit.git","svn_url":"https://github.com/tucaz/csharp-kit","homepage":null,"size":6254,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"prismicio:master","ref":"master","sha":"fafa3f35098317a4fde286e9181ecad1f9e7b51b","user":{"login":"prismicio","id":4621061,"avatar_url":"https://avatars.githubusercontent.com/u/4621061?v=3","gravatar_id":"","url":"https://api.github.com/users/prismicio","html_url":"https://github.com/prismicio","followers_url":"https://api.github.com/users/prismicio/followers","following_url":"https://api.github.com/users/prismicio/following{/other_user}","gists_url":"https://api.github.com/users/prismicio/gists{/gist_id}","starred_url":"https://api.github.com/users/prismicio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prismicio/subscriptions","organizations_url":"https://api.github.com/users/prismicio/orgs","repos_url":"https://api.github.com/users/prismicio/repos","events_url":"https://api.github.com/users/prismicio/events{/privacy}","received_events_url":"https://api.github.com/users/prismicio/received_events","type":"Organization","site_admin":false},"repo":{"id":26229393,"name":"csharp-kit","full_name":"prismicio/csharp-kit","owner":{"login":"prismicio","id":4621061,"avatar_url":"https://avatars.githubusercontent.com/u/4621061?v=3","gravatar_id":"","url":"https://api.github.com/users/prismicio","html_url":"https://github.com/prismicio","followers_url":"https://api.github.com/users/prismicio/followers","following_url":"https://api.github.com/users/prismicio/following{/other_user}","gists_url":"https://api.github.com/users/prismicio/gists{/gist_id}","starred_url":"https://api.github.com/users/prismicio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prismicio/subscriptions","organizations_url":"https://api.github.com/users/prismicio/orgs","repos_url":"https://api.github.com/users/prismicio/repos","events_url":"https://api.github.com/users/prismicio/events{/privacy}","received_events_url":"https://api.github.com/users/prismicio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/prismicio/csharp-kit","description":"Development kit for the C# language","fork":false,"url":"https://api.github.com/repos/prismicio/csharp-kit","forks_url":"https://api.github.com/repos/prismicio/csharp-kit/forks","keys_url":"https://api.github.com/repos/prismicio/csharp-kit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prismicio/csharp-kit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prismicio/csharp-kit/teams","hooks_url":"https://api.github.com/repos/prismicio/csharp-kit/hooks","issue_events_url":"https://api.github.com/repos/prismicio/csharp-kit/issues/events{/number}","events_url":"https://api.github.com/repos/prismicio/csharp-kit/events","assignees_url":"https://api.github.com/repos/prismicio/csharp-kit/assignees{/user}","branches_url":"https://api.github.com/repos/prismicio/csharp-kit/branches{/branch}","tags_url":"https://api.github.com/repos/prismicio/csharp-kit/tags","blobs_url":"https://api.github.com/repos/prismicio/csharp-kit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prismicio/csharp-kit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prismicio/csharp-kit/git/refs{/sha}","trees_url":"https://api.github.com/repos/prismicio/csharp-kit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prismicio/csharp-kit/statuses/{sha}","languages_url":"https://api.github.com/repos/prismicio/csharp-kit/languages","stargazers_url":"https://api.github.com/repos/prismicio/csharp-kit/stargazers","contributors_url":"https://api.github.com/repos/prismicio/csharp-kit/contributors","subscribers_url":"https://api.github.com/repos/prismicio/csharp-kit/subscribers","subscription_url":"https://api.github.com/repos/prismicio/csharp-kit/subscription","commits_url":"https://api.github.com/repos/prismicio/csharp-kit/commits{/sha}","git_commits_url":"https://api.github.com/repos/prismicio/csharp-kit/git/commits{/sha}","comments_url":"https://api.github.com/repos/prismicio/csharp-kit/comments{/number}","issue_comment_url":"https://api.github.com/repos/prismicio/csharp-kit/issues/comments{/number}","contents_url":"https://api.github.com/repos/prismicio/csharp-kit/contents/{+path}","compare_url":"https://api.github.com/repos/prismicio/csharp-kit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prismicio/csharp-kit/merges","archive_url":"https://api.github.com/repos/prismicio/csharp-kit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prismicio/csharp-kit/downloads","issues_url":"https://api.github.com/repos/prismicio/csharp-kit/issues{/number}","pulls_url":"https://api.github.com/repos/prismicio/csharp-kit/pulls{/number}","milestones_url":"https://api.github.com/repos/prismicio/csharp-kit/milestones{/number}","notifications_url":"https://api.github.com/repos/prismicio/csharp-kit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prismicio/csharp-kit/labels{/name}","releases_url":"https://api.github.com/repos/prismicio/csharp-kit/releases{/id}","created_at":"2014-11-05T16:48:47Z","updated_at":"2015-03-31T09:21:43Z","pushed_at":"2015-09-03T09:51:35Z","git_url":"git://github.com/prismicio/csharp-kit.git","ssh_url":"git@github.com:prismicio/csharp-kit.git","clone_url":"https://github.com/prismicio/csharp-kit.git","svn_url":"https://github.com/prismicio/csharp-kit","homepage":null,"size":6447,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":3,"forks":2,"open_issues":3,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/prismicio/csharp-kit/pulls/7"},"html":{"href":"https://github.com/prismicio/csharp-kit/pull/7"},"issue":{"href":"https://api.github.com/repos/prismicio/csharp-kit/issues/7"},"comments":{"href":"https://api.github.com/repos/prismicio/csharp-kit/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/prismicio/csharp-kit/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/prismicio/csharp-kit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/prismicio/csharp-kit/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/prismicio/csharp-kit/statuses/9a700b06d31d983e5d6f4cbb50d5147000578b88"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"erwan","id":16061,"avatar_url":"https://avatars.githubusercontent.com/u/16061?v=3","gravatar_id":"","url":"https://api.github.com/users/erwan","html_url":"https://github.com/erwan","followers_url":"https://api.github.com/users/erwan/followers","following_url":"https://api.github.com/users/erwan/following{/other_user}","gists_url":"https://api.github.com/users/erwan/gists{/gist_id}","starred_url":"https://api.github.com/users/erwan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erwan/subscriptions","organizations_url":"https://api.github.com/users/erwan/orgs","repos_url":"https://api.github.com/users/erwan/repos","events_url":"https://api.github.com/users/erwan/events{/privacy}","received_events_url":"https://api.github.com/users/erwan/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":3,"additions":34,"deletions":13,"changed_files":3}}