{"action":"created","comment":{"url":"https://api.github.com/repos/sensiolabs/SensioGeneratorBundle/pulls/comments/35333677","id":35333677,"diff_hunk":"@@ -45,7 +45,7 @@ protected function configure()\n                 new InputOption('entity', '', InputOption::VALUE_REQUIRED, 'The entity class name to initialize (shortcut notation)'),\n                 new InputOption('route-prefix', '', InputOption::VALUE_REQUIRED, 'The route prefix'),\n                 new InputOption('with-write', '', InputOption::VALUE_NONE, 'Whether or not to generate create, new and delete actions'),\n-                new InputOption('format', '', InputOption::VALUE_REQUIRED, 'Use the format for configuration files (php, xml, yml, or annotation)', 'annotation'),\n+                new InputOption('format', '', InputOption::VALUE_REQUIRED, 'Use the format for routing (php, xml, yml, or annotation)', 'annotation'),","path":"Command/GenerateDoctrineCrudCommand.php","position":5,"original_position":5,"commit_id":"5009311a480db446a3cc119c3a2d0a8852184b2c","original_commit_id":"5009311a480db446a3cc119c3a2d0a8852184b2c","user":{"login":"maidmaid","id":4578773,"avatar_url":"https://avatars.githubusercontent.com/u/4578773?v=3","gravatar_id":"","url":"https://api.github.com/users/maidmaid","html_url":"https://github.com/maidmaid","followers_url":"https://api.github.com/users/maidmaid/followers","following_url":"https://api.github.com/users/maidmaid/following{/other_user}","gists_url":"https://api.github.com/users/maidmaid/gists{/gist_id}","starred_url":"https://api.github.com/users/maidmaid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maidmaid/subscriptions","organizations_url":"https://api.github.com/users/maidmaid/orgs","repos_url":"https://api.github.com/users/maidmaid/repos","events_url":"https://api.github.com/users/maidmaid/events{/privacy}","received_events_url":"https://api.github.com/users/maidmaid/received_events","type":"User","site_admin":false},"body":"Yes you are right. I say maiby a stupidity but changing the name of an option is not considered as BC break ? ","created_at":"2015-07-23T15:24:33Z","updated_at":"2015-07-23T15:24:33Z","html_url":"https://github.com/sensiolabs/SensioGeneratorBundle/pull/377#discussion_r35333677","pull_request_url":"https://api.github.com/repos/sensiolabs/SensioGeneratorBundle/pulls/377","_links":{"self":{"href":"https://api.github.com/repos/sensiolabs/SensioGeneratorBundle/pulls/comments/35333677"},"html":{"href":"https://github.com/sensiolabs/SensioGeneratorBundle/pull/377#discussion_r35333677"},"pull_request":{"href":"https://api.github.com/repos/sensiolabs/SensioGeneratorBundle/pulls/377"}}},"pull_request":{"url":"https://api.github.com/repos/sensiolabs/SensioGeneratorBundle/pulls/377","id":39626255,"html_url":"https://github.com/sensiolabs/SensioGeneratorBundle/pull/377","diff_url":"https://github.com/sensiolabs/SensioGeneratorBundle/pull/377.diff","patch_url":"https://github.com/sensiolabs/SensioGeneratorBundle/pull/377.patch","issue_url":"https://api.github.com/repos/sensiolabs/SensioGeneratorBundle/issues/377","number":377,"state":"open","locked":false,"title":"CRUD-generator follows symfony best practices","user":{"login":"maidmaid","id":4578773,"avatar_url":"https://avatars.githubusercontent.com/u/4578773?v=3","gravatar_id":"","url":"https://api.github.com/users/maidmaid","html_url":"https://github.com/maidmaid","followers_url":"https://api.github.com/users/maidmaid/followers","following_url":"https://api.github.com/users/maidmaid/following{/other_user}","gists_url":"https://api.github.com/users/maidmaid/gists{/gist_id}","starred_url":"https://api.github.com/users/maidmaid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maidmaid/subscriptions","organizations_url":"https://api.github.com/users/maidmaid/orgs","repos_url":"https://api.github.com/users/maidmaid/repos","events_url":"https://api.github.com/users/maidmaid/events{/privacy}","received_events_url":"https://api.github.com/users/maidmaid/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Bug fix?      | no\r\n| New feature?  | no\r\n| BC breaks?    | no\r\n| Deprecations? | no\r\n| Tests pass?   | yes\r\n| Fixed tickets | #344\r\n| License       | MIT\r\n| Doc PR        |\r\n\r\nFollow best practices :\r\n- [x] [So it's much simpler to let newAction handle everything.](http://symfony.com/doc/current/best_practices/forms.html#handling-form-submits)\r\n- [x] [Add buttons in the templates, not in the form classes or the controllers.](http://symfony.com/doc/current/best_practices/forms.html#form-button-configuration)\r\n- [x] [Store all your application's templates in ``app/Resources/views/ directory``.](http://symfony.com/doc/current/best_practices/templates.html#template-locations)\r\n- [x] [Rendering the Form](http://symfony.com/doc/current/best_practices/forms.html#rendering-the-form)\r\n- [x] [We recommend using ``$form->isSubmitted()`` in the if statement for clarity.](http://symfony.com/doc/current/best_practices/forms.html#handling-form-submits)\r\n- [x] [Use the ``ParamConverter`` trick to automatically query for Doctrine entities when it's simple and convenient.](http://symfony.com/doc/current/best_practices/controllers.html#using-the-paramconverter)\r\n- [x]  [Use lowercased snake_case for directory and template names.](http://symfony.com/doc/current/best_practices/templates.html#template-locations)\r\n\r\nOthers :\r\n- [x] Use ``redirectToRoute()`` shortcut notation for routing.\r\n\r\nFor see quickly the generated result, click on [this repo](https://github.com/maidmaid/sf-crud) ([controller](https://github.com/maidmaid/sf-crud/blob/master/src/AppBundle/Controller/ArticleController.php), [views](https://github.com/maidmaid/sf-crud/tree/master/app/Resources/views/article), [routing](https://github.com/maidmaid/sf-crud/tree/master/src/AppBundle/Resources/config/routing)).","created_at":"2015-07-09T20:44:21Z","updated_at":"2015-07-23T15:24:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"07c92be98caac9f70fe133b42372cb60a229e85a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sensiolabs/SensioGeneratorBundle/pulls/377/commits","review_comments_url":"https://api.github.com/repos/sensiolabs/SensioGeneratorBundle/pulls/377/comments","review_comment_url":"https://api.github.com/repos/sensiolabs/SensioGeneratorBundle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sensiolabs/SensioGeneratorBundle/issues/377/comments","statuses_url":"https://api.github.com/repos/sensiolabs/SensioGeneratorBundle/statuses/5009311a480db446a3cc119c3a2d0a8852184b2c","head":{"label":"maidmaid:crud","ref":"crud","sha":"5009311a480db446a3cc119c3a2d0a8852184b2c","user":{"login":"maidmaid","id":4578773,"avatar_url":"https://avatars.githubusercontent.com/u/4578773?v=3","gravatar_id":"","url":"https://api.github.com/users/maidmaid","html_url":"https://github.com/maidmaid","followers_url":"https://api.github.com/users/maidmaid/followers","following_url":"https://api.github.com/users/maidmaid/following{/other_user}","gists_url":"https://api.github.com/users/maidmaid/gists{/gist_id}","starred_url":"https://api.github.com/users/maidmaid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maidmaid/subscriptions","organizations_url":"https://api.github.com/users/maidmaid/orgs","repos_url":"https://api.github.com/users/maidmaid/repos","events_url":"https://api.github.com/users/maidmaid/events{/privacy}","received_events_url":"https://api.github.com/users/maidmaid/received_events","type":"User","site_admin":false},"repo":{"id":38643662,"name":"SensioGeneratorBundle","full_name":"maidmaid/SensioGeneratorBundle","owner":{"login":"maidmaid","id":4578773,"avatar_url":"https://avatars.githubusercontent.com/u/4578773?v=3","gravatar_id":"","url":"https://api.github.com/users/maidmaid","html_url":"https://github.com/maidmaid","followers_url":"https://api.github.com/users/maidmaid/followers","following_url":"https://api.github.com/users/maidmaid/following{/other_user}","gists_url":"https://api.github.com/users/maidmaid/gists{/gist_id}","starred_url":"https://api.github.com/users/maidmaid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maidmaid/subscriptions","organizations_url":"https://api.github.com/users/maidmaid/orgs","repos_url":"https://api.github.com/users/maidmaid/repos","events_url":"https://api.github.com/users/maidmaid/events{/privacy}","received_events_url":"https://api.github.com/users/maidmaid/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/maidmaid/SensioGeneratorBundle","description":"Generates Symfony2 bundles, entities, forms, CRUD, and more...","fork":true,"url":"https://api.github.com/repos/maidmaid/SensioGeneratorBundle","forks_url":"https://api.github.com/repos/maidmaid/SensioGeneratorBundle/forks","keys_url":"https://api.github.com/repos/maidmaid/SensioGeneratorBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maidmaid/SensioGeneratorBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maidmaid/SensioGeneratorBundle/teams","hooks_url":"https://api.github.com/repos/maidmaid/SensioGeneratorBundle/hooks","issue_events_url":"https://api.github.com/repos/maidmaid/SensioGeneratorBundle/issues/events{/number}","events_url":"https://api.github.com/repos/maidmaid/SensioGeneratorBundle/events","assignees_url":"https://api.github.com/repos/maidmaid/SensioGeneratorBundle/assignees{/user}","branches_url":"https://api.github.com/repos/maidmaid/SensioGeneratorBundle/branches{/branch}","tags_url":"https://api.github.com/repos/maidmaid/SensioGeneratorBundle/tags","blobs_url":"https://api.github.com/repos/maidmaid/SensioGeneratorBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maidmaid/SensioGeneratorBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maidmaid/SensioGeneratorBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/maidmaid/SensioGeneratorBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maidmaid/SensioGeneratorBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/maidmaid/SensioGeneratorBundle/languages","stargazers_url":"https://api.github.com/repos/maidmaid/SensioGeneratorBundle/stargazers","contributors_url":"https://api.github.com/repos/maidmaid/SensioGeneratorBundle/contributors","subscribers_url":"https://api.github.com/repos/maidmaid/SensioGeneratorBundle/subscribers","subscription_url":"https://api.github.com/repos/maidmaid/SensioGeneratorBundle/subscription","commits_url":"https://api.github.com/repos/maidmaid/SensioGeneratorBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/maidmaid/SensioGeneratorBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/maidmaid/SensioGeneratorBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/maidmaid/SensioGeneratorBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/maidmaid/SensioGeneratorBundle/contents/{+path}","compare_url":"https://api.github.com/repos/maidmaid/SensioGeneratorBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maidmaid/SensioGeneratorBundle/merges","archive_url":"https://api.github.com/repos/maidmaid/SensioGeneratorBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maidmaid/SensioGeneratorBundle/downloads","issues_url":"https://api.github.com/repos/maidmaid/SensioGeneratorBundle/issues{/number}","pulls_url":"https://api.github.com/repos/maidmaid/SensioGeneratorBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/maidmaid/SensioGeneratorBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/maidmaid/SensioGeneratorBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maidmaid/SensioGeneratorBundle/labels{/name}","releases_url":"https://api.github.com/repos/maidmaid/SensioGeneratorBundle/releases{/id}","created_at":"2015-07-06T20:19:11Z","updated_at":"2015-07-06T20:19:12Z","pushed_at":"2015-07-21T15:32:39Z","git_url":"git://github.com/maidmaid/SensioGeneratorBundle.git","ssh_url":"git@github.com:maidmaid/SensioGeneratorBundle.git","clone_url":"https://github.com/maidmaid/SensioGeneratorBundle.git","svn_url":"https://github.com/maidmaid/SensioGeneratorBundle","homepage":"symfony.com","size":594,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sensiolabs:master","ref":"master","sha":"559f47750ea484f70b9b9bbfd7bffe078fc4c453","user":{"login":"sensiolabs","id":1780787,"avatar_url":"https://avatars.githubusercontent.com/u/1780787?v=3","gravatar_id":"","url":"https://api.github.com/users/sensiolabs","html_url":"https://github.com/sensiolabs","followers_url":"https://api.github.com/users/sensiolabs/followers","following_url":"https://api.github.com/users/sensiolabs/following{/other_user}","gists_url":"https://api.github.com/users/sensiolabs/gists{/gist_id}","starred_url":"https://api.github.com/users/sensiolabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sensiolabs/subscriptions","organizations_url":"https://api.github.com/users/sensiolabs/orgs","repos_url":"https://api.github.com/users/sensiolabs/repos","events_url":"https://api.github.com/users/sensiolabs/events{/privacy}","received_events_url":"https://api.github.com/users/sensiolabs/received_events","type":"Organization","site_admin":false},"repo":{"id":1826487,"name":"SensioGeneratorBundle","full_name":"sensiolabs/SensioGeneratorBundle","owner":{"login":"sensiolabs","id":1780787,"avatar_url":"https://avatars.githubusercontent.com/u/1780787?v=3","gravatar_id":"","url":"https://api.github.com/users/sensiolabs","html_url":"https://github.com/sensiolabs","followers_url":"https://api.github.com/users/sensiolabs/followers","following_url":"https://api.github.com/users/sensiolabs/following{/other_user}","gists_url":"https://api.github.com/users/sensiolabs/gists{/gist_id}","starred_url":"https://api.github.com/users/sensiolabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sensiolabs/subscriptions","organizations_url":"https://api.github.com/users/sensiolabs/orgs","repos_url":"https://api.github.com/users/sensiolabs/repos","events_url":"https://api.github.com/users/sensiolabs/events{/privacy}","received_events_url":"https://api.github.com/users/sensiolabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sensiolabs/SensioGeneratorBundle","description":"Generates Symfony2 bundles, entities, forms, CRUD, and more...","fork":false,"url":"https://api.github.com/repos/sensiolabs/SensioGeneratorBundle","forks_url":"https://api.github.com/repos/sensiolabs/SensioGeneratorBundle/forks","keys_url":"https://api.github.com/repos/sensiolabs/SensioGeneratorBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sensiolabs/SensioGeneratorBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sensiolabs/SensioGeneratorBundle/teams","hooks_url":"https://api.github.com/repos/sensiolabs/SensioGeneratorBundle/hooks","issue_events_url":"https://api.github.com/repos/sensiolabs/SensioGeneratorBundle/issues/events{/number}","events_url":"https://api.github.com/repos/sensiolabs/SensioGeneratorBundle/events","assignees_url":"https://api.github.com/repos/sensiolabs/SensioGeneratorBundle/assignees{/user}","branches_url":"https://api.github.com/repos/sensiolabs/SensioGeneratorBundle/branches{/branch}","tags_url":"https://api.github.com/repos/sensiolabs/SensioGeneratorBundle/tags","blobs_url":"https://api.github.com/repos/sensiolabs/SensioGeneratorBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sensiolabs/SensioGeneratorBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sensiolabs/SensioGeneratorBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/sensiolabs/SensioGeneratorBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sensiolabs/SensioGeneratorBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/sensiolabs/SensioGeneratorBundle/languages","stargazers_url":"https://api.github.com/repos/sensiolabs/SensioGeneratorBundle/stargazers","contributors_url":"https://api.github.com/repos/sensiolabs/SensioGeneratorBundle/contributors","subscribers_url":"https://api.github.com/repos/sensiolabs/SensioGeneratorBundle/subscribers","subscription_url":"https://api.github.com/repos/sensiolabs/SensioGeneratorBundle/subscription","commits_url":"https://api.github.com/repos/sensiolabs/SensioGeneratorBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/sensiolabs/SensioGeneratorBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/sensiolabs/SensioGeneratorBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/sensiolabs/SensioGeneratorBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/sensiolabs/SensioGeneratorBundle/contents/{+path}","compare_url":"https://api.github.com/repos/sensiolabs/SensioGeneratorBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sensiolabs/SensioGeneratorBundle/merges","archive_url":"https://api.github.com/repos/sensiolabs/SensioGeneratorBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sensiolabs/SensioGeneratorBundle/downloads","issues_url":"https://api.github.com/repos/sensiolabs/SensioGeneratorBundle/issues{/number}","pulls_url":"https://api.github.com/repos/sensiolabs/SensioGeneratorBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/sensiolabs/SensioGeneratorBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/sensiolabs/SensioGeneratorBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sensiolabs/SensioGeneratorBundle/labels{/name}","releases_url":"https://api.github.com/repos/sensiolabs/SensioGeneratorBundle/releases{/id}","created_at":"2011-05-31T13:54:51Z","updated_at":"2015-07-17T20:39:58Z","pushed_at":"2015-07-22T15:15:53Z","git_url":"git://github.com/sensiolabs/SensioGeneratorBundle.git","ssh_url":"git@github.com:sensiolabs/SensioGeneratorBundle.git","clone_url":"https://github.com/sensiolabs/SensioGeneratorBundle.git","svn_url":"https://github.com/sensiolabs/SensioGeneratorBundle","homepage":"symfony.com","size":2960,"stargazers_count":237,"watchers_count":237,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":204,"mirror_url":null,"open_issues_count":47,"forks":204,"open_issues":47,"watchers":237,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sensiolabs/SensioGeneratorBundle/pulls/377"},"html":{"href":"https://github.com/sensiolabs/SensioGeneratorBundle/pull/377"},"issue":{"href":"https://api.github.com/repos/sensiolabs/SensioGeneratorBundle/issues/377"},"comments":{"href":"https://api.github.com/repos/sensiolabs/SensioGeneratorBundle/issues/377/comments"},"review_comments":{"href":"https://api.github.com/repos/sensiolabs/SensioGeneratorBundle/pulls/377/comments"},"review_comment":{"href":"https://api.github.com/repos/sensiolabs/SensioGeneratorBundle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sensiolabs/SensioGeneratorBundle/pulls/377/commits"},"statuses":{"href":"https://api.github.com/repos/sensiolabs/SensioGeneratorBundle/statuses/5009311a480db446a3cc119c3a2d0a8852184b2c"}}}}