{"action":"created","comment":{"url":"https://api.github.com/repos/nlf/dhyve-os/pulls/comments/36211258","id":36211258,"diff_hunk":"@@ -1,23 +1,46 @@\n-all: output/rootfs.cpio.xz output/bzImage\n+TARGETS := output/rootfs.cpio.xz output/bzImage\n+SOURCES := Dockerfile config/buildroot config/kernel config/user bin/build_dhyve\n \n-output/rootfs.cpio.xz output/bzImage: | output\n-\t@docker inspect dhyve-os-built >/dev/null 2>&1 || ${MAKE} build\n-\tdocker cp dhyve-os-built:/build/buildroot/output/images/$(@F) output/\n+BUILD_IMAGE     := dhyve-os-builder\n+BUILD_CONTAINER := dhyve-os-built\n \n-build: | ccache dl\n-\tdocker build --no-cache -t dhyve-os-build .\n-\t-docker rm dhyve-os-built\n-\tdocker run -v ${PWD}/ccache:/build/buildroot/ccache -v ${PWD}/dl:/build/buildroot/dl --name=dhyve-os-built dhyve-os-build\n+BUILT := `docker ps -aq -f name=$(BUILD_CONTAINER) -f exited=0`\n+\n+all: $(TARGETS)\n+\n+$(TARGETS): build | output\n+\t@if [ \"$(BUILT)\" != \"\" ]; then \\\n+\t\techo docker cp $(BUILD_CONTAINER):/build/buildroot/output/images/$(@F) output/; \\","path":"Makefile","position":21,"original_position":21,"commit_id":"8dc801b0aa8842e7a5527abd103e3e464133d77a","original_commit_id":"8dc801b0aa8842e7a5527abd103e3e464133d77a","user":{"login":"nlf","id":424045,"avatar_url":"https://avatars.githubusercontent.com/u/424045?v=3","gravatar_id":"","url":"https://api.github.com/users/nlf","html_url":"https://github.com/nlf","followers_url":"https://api.github.com/users/nlf/followers","following_url":"https://api.github.com/users/nlf/following{/other_user}","gists_url":"https://api.github.com/users/nlf/gists{/gist_id}","starred_url":"https://api.github.com/users/nlf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nlf/subscriptions","organizations_url":"https://api.github.com/users/nlf/orgs","repos_url":"https://api.github.com/users/nlf/repos","events_url":"https://api.github.com/users/nlf/events{/privacy}","received_events_url":"https://api.github.com/users/nlf/received_events","type":"User","site_admin":false},"body":"why the echo?","created_at":"2015-08-04T16:44:25Z","updated_at":"2015-08-04T16:44:25Z","html_url":"https://github.com/nlf/dhyve-os/pull/5#discussion_r36211258","pull_request_url":"https://api.github.com/repos/nlf/dhyve-os/pulls/5","_links":{"self":{"href":"https://api.github.com/repos/nlf/dhyve-os/pulls/comments/36211258"},"html":{"href":"https://github.com/nlf/dhyve-os/pull/5#discussion_r36211258"},"pull_request":{"href":"https://api.github.com/repos/nlf/dhyve-os/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/nlf/dhyve-os/pulls/5","id":41529816,"html_url":"https://github.com/nlf/dhyve-os/pull/5","diff_url":"https://github.com/nlf/dhyve-os/pull/5.diff","patch_url":"https://github.com/nlf/dhyve-os/pull/5.patch","issue_url":"https://api.github.com/repos/nlf/dhyve-os/issues/5","number":5,"state":"open","locked":false,"title":"Docker-oriented Makefile","user":{"login":"ailispaw","id":10327896,"avatar_url":"https://avatars.githubusercontent.com/u/10327896?v=3","gravatar_id":"","url":"https://api.github.com/users/ailispaw","html_url":"https://github.com/ailispaw","followers_url":"https://api.github.com/users/ailispaw/followers","following_url":"https://api.github.com/users/ailispaw/following{/other_user}","gists_url":"https://api.github.com/users/ailispaw/gists{/gist_id}","starred_url":"https://api.github.com/users/ailispaw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ailispaw/subscriptions","organizations_url":"https://api.github.com/users/ailispaw/orgs","repos_url":"https://api.github.com/users/ailispaw/repos","events_url":"https://api.github.com/users/ailispaw/events{/privacy}","received_events_url":"https://api.github.com/users/ailispaw/received_events","type":"User","site_admin":false},"body":"I gave up my previous idea with two Dockerfiles.\r\n\r\nI made something Docker-oriented Makefile.\r\nIt's ugly, but it works.\r\nI hope it's helpful for #3 .","created_at":"2015-08-04T02:46:47Z","updated_at":"2015-08-04T16:44:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d26fd7e009083ee16db8b2bbc1a76d44f861daf4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nlf/dhyve-os/pulls/5/commits","review_comments_url":"https://api.github.com/repos/nlf/dhyve-os/pulls/5/comments","review_comment_url":"https://api.github.com/repos/nlf/dhyve-os/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nlf/dhyve-os/issues/5/comments","statuses_url":"https://api.github.com/repos/nlf/dhyve-os/statuses/8dc801b0aa8842e7a5527abd103e3e464133d77a","head":{"label":"nlf:topic","ref":"topic","sha":"8dc801b0aa8842e7a5527abd103e3e464133d77a","user":{"login":"nlf","id":424045,"avatar_url":"https://avatars.githubusercontent.com/u/424045?v=3","gravatar_id":"","url":"https://api.github.com/users/nlf","html_url":"https://github.com/nlf","followers_url":"https://api.github.com/users/nlf/followers","following_url":"https://api.github.com/users/nlf/following{/other_user}","gists_url":"https://api.github.com/users/nlf/gists{/gist_id}","starred_url":"https://api.github.com/users/nlf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nlf/subscriptions","organizations_url":"https://api.github.com/users/nlf/orgs","repos_url":"https://api.github.com/users/nlf/repos","events_url":"https://api.github.com/users/nlf/events{/privacy}","received_events_url":"https://api.github.com/users/nlf/received_events","type":"User","site_admin":false},"repo":{"id":39976014,"name":"dhyve-os","full_name":"nlf/dhyve-os","owner":{"login":"nlf","id":424045,"avatar_url":"https://avatars.githubusercontent.com/u/424045?v=3","gravatar_id":"","url":"https://api.github.com/users/nlf","html_url":"https://github.com/nlf","followers_url":"https://api.github.com/users/nlf/followers","following_url":"https://api.github.com/users/nlf/following{/other_user}","gists_url":"https://api.github.com/users/nlf/gists{/gist_id}","starred_url":"https://api.github.com/users/nlf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nlf/subscriptions","organizations_url":"https://api.github.com/users/nlf/orgs","repos_url":"https://api.github.com/users/nlf/repos","events_url":"https://api.github.com/users/nlf/events{/privacy}","received_events_url":"https://api.github.com/users/nlf/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nlf/dhyve-os","description":"a tiny OS for running docker in xhyve","fork":false,"url":"https://api.github.com/repos/nlf/dhyve-os","forks_url":"https://api.github.com/repos/nlf/dhyve-os/forks","keys_url":"https://api.github.com/repos/nlf/dhyve-os/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nlf/dhyve-os/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nlf/dhyve-os/teams","hooks_url":"https://api.github.com/repos/nlf/dhyve-os/hooks","issue_events_url":"https://api.github.com/repos/nlf/dhyve-os/issues/events{/number}","events_url":"https://api.github.com/repos/nlf/dhyve-os/events","assignees_url":"https://api.github.com/repos/nlf/dhyve-os/assignees{/user}","branches_url":"https://api.github.com/repos/nlf/dhyve-os/branches{/branch}","tags_url":"https://api.github.com/repos/nlf/dhyve-os/tags","blobs_url":"https://api.github.com/repos/nlf/dhyve-os/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nlf/dhyve-os/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nlf/dhyve-os/git/refs{/sha}","trees_url":"https://api.github.com/repos/nlf/dhyve-os/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nlf/dhyve-os/statuses/{sha}","languages_url":"https://api.github.com/repos/nlf/dhyve-os/languages","stargazers_url":"https://api.github.com/repos/nlf/dhyve-os/stargazers","contributors_url":"https://api.github.com/repos/nlf/dhyve-os/contributors","subscribers_url":"https://api.github.com/repos/nlf/dhyve-os/subscribers","subscription_url":"https://api.github.com/repos/nlf/dhyve-os/subscription","commits_url":"https://api.github.com/repos/nlf/dhyve-os/commits{/sha}","git_commits_url":"https://api.github.com/repos/nlf/dhyve-os/git/commits{/sha}","comments_url":"https://api.github.com/repos/nlf/dhyve-os/comments{/number}","issue_comment_url":"https://api.github.com/repos/nlf/dhyve-os/issues/comments{/number}","contents_url":"https://api.github.com/repos/nlf/dhyve-os/contents/{+path}","compare_url":"https://api.github.com/repos/nlf/dhyve-os/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nlf/dhyve-os/merges","archive_url":"https://api.github.com/repos/nlf/dhyve-os/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nlf/dhyve-os/downloads","issues_url":"https://api.github.com/repos/nlf/dhyve-os/issues{/number}","pulls_url":"https://api.github.com/repos/nlf/dhyve-os/pulls{/number}","milestones_url":"https://api.github.com/repos/nlf/dhyve-os/milestones{/number}","notifications_url":"https://api.github.com/repos/nlf/dhyve-os/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nlf/dhyve-os/labels{/name}","releases_url":"https://api.github.com/repos/nlf/dhyve-os/releases{/id}","created_at":"2015-07-30T23:00:23Z","updated_at":"2015-07-30T23:32:54Z","pushed_at":"2015-08-04T16:09:43Z","git_url":"git://github.com/nlf/dhyve-os.git","ssh_url":"git@github.com:nlf/dhyve-os.git","clone_url":"https://github.com/nlf/dhyve-os.git","svn_url":"https://github.com/nlf/dhyve-os","homepage":"","size":0,"stargazers_count":1,"watchers_count":1,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":1,"default_branch":"master"}},"base":{"label":"nlf:master","ref":"master","sha":"ea3f85854bbaca7eafe3c744f1b1099e065d030c","user":{"login":"nlf","id":424045,"avatar_url":"https://avatars.githubusercontent.com/u/424045?v=3","gravatar_id":"","url":"https://api.github.com/users/nlf","html_url":"https://github.com/nlf","followers_url":"https://api.github.com/users/nlf/followers","following_url":"https://api.github.com/users/nlf/following{/other_user}","gists_url":"https://api.github.com/users/nlf/gists{/gist_id}","starred_url":"https://api.github.com/users/nlf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nlf/subscriptions","organizations_url":"https://api.github.com/users/nlf/orgs","repos_url":"https://api.github.com/users/nlf/repos","events_url":"https://api.github.com/users/nlf/events{/privacy}","received_events_url":"https://api.github.com/users/nlf/received_events","type":"User","site_admin":false},"repo":{"id":39976014,"name":"dhyve-os","full_name":"nlf/dhyve-os","owner":{"login":"nlf","id":424045,"avatar_url":"https://avatars.githubusercontent.com/u/424045?v=3","gravatar_id":"","url":"https://api.github.com/users/nlf","html_url":"https://github.com/nlf","followers_url":"https://api.github.com/users/nlf/followers","following_url":"https://api.github.com/users/nlf/following{/other_user}","gists_url":"https://api.github.com/users/nlf/gists{/gist_id}","starred_url":"https://api.github.com/users/nlf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nlf/subscriptions","organizations_url":"https://api.github.com/users/nlf/orgs","repos_url":"https://api.github.com/users/nlf/repos","events_url":"https://api.github.com/users/nlf/events{/privacy}","received_events_url":"https://api.github.com/users/nlf/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nlf/dhyve-os","description":"a tiny OS for running docker in xhyve","fork":false,"url":"https://api.github.com/repos/nlf/dhyve-os","forks_url":"https://api.github.com/repos/nlf/dhyve-os/forks","keys_url":"https://api.github.com/repos/nlf/dhyve-os/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nlf/dhyve-os/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nlf/dhyve-os/teams","hooks_url":"https://api.github.com/repos/nlf/dhyve-os/hooks","issue_events_url":"https://api.github.com/repos/nlf/dhyve-os/issues/events{/number}","events_url":"https://api.github.com/repos/nlf/dhyve-os/events","assignees_url":"https://api.github.com/repos/nlf/dhyve-os/assignees{/user}","branches_url":"https://api.github.com/repos/nlf/dhyve-os/branches{/branch}","tags_url":"https://api.github.com/repos/nlf/dhyve-os/tags","blobs_url":"https://api.github.com/repos/nlf/dhyve-os/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nlf/dhyve-os/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nlf/dhyve-os/git/refs{/sha}","trees_url":"https://api.github.com/repos/nlf/dhyve-os/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nlf/dhyve-os/statuses/{sha}","languages_url":"https://api.github.com/repos/nlf/dhyve-os/languages","stargazers_url":"https://api.github.com/repos/nlf/dhyve-os/stargazers","contributors_url":"https://api.github.com/repos/nlf/dhyve-os/contributors","subscribers_url":"https://api.github.com/repos/nlf/dhyve-os/subscribers","subscription_url":"https://api.github.com/repos/nlf/dhyve-os/subscription","commits_url":"https://api.github.com/repos/nlf/dhyve-os/commits{/sha}","git_commits_url":"https://api.github.com/repos/nlf/dhyve-os/git/commits{/sha}","comments_url":"https://api.github.com/repos/nlf/dhyve-os/comments{/number}","issue_comment_url":"https://api.github.com/repos/nlf/dhyve-os/issues/comments{/number}","contents_url":"https://api.github.com/repos/nlf/dhyve-os/contents/{+path}","compare_url":"https://api.github.com/repos/nlf/dhyve-os/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nlf/dhyve-os/merges","archive_url":"https://api.github.com/repos/nlf/dhyve-os/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nlf/dhyve-os/downloads","issues_url":"https://api.github.com/repos/nlf/dhyve-os/issues{/number}","pulls_url":"https://api.github.com/repos/nlf/dhyve-os/pulls{/number}","milestones_url":"https://api.github.com/repos/nlf/dhyve-os/milestones{/number}","notifications_url":"https://api.github.com/repos/nlf/dhyve-os/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nlf/dhyve-os/labels{/name}","releases_url":"https://api.github.com/repos/nlf/dhyve-os/releases{/id}","created_at":"2015-07-30T23:00:23Z","updated_at":"2015-07-30T23:32:54Z","pushed_at":"2015-08-04T16:09:43Z","git_url":"git://github.com/nlf/dhyve-os.git","ssh_url":"git@github.com:nlf/dhyve-os.git","clone_url":"https://github.com/nlf/dhyve-os.git","svn_url":"https://github.com/nlf/dhyve-os","homepage":"","size":0,"stargazers_count":1,"watchers_count":1,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nlf/dhyve-os/pulls/5"},"html":{"href":"https://github.com/nlf/dhyve-os/pull/5"},"issue":{"href":"https://api.github.com/repos/nlf/dhyve-os/issues/5"},"comments":{"href":"https://api.github.com/repos/nlf/dhyve-os/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/nlf/dhyve-os/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/nlf/dhyve-os/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nlf/dhyve-os/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/nlf/dhyve-os/statuses/8dc801b0aa8842e7a5527abd103e3e464133d77a"}}}}