{"action":"created","issue":{"url":"https://api.github.com/repos/rvalkass/GenericSmallMOKE/issues/3","labels_url":"https://api.github.com/repos/rvalkass/GenericSmallMOKE/issues/3/labels{/name}","comments_url":"https://api.github.com/repos/rvalkass/GenericSmallMOKE/issues/3/comments","events_url":"https://api.github.com/repos/rvalkass/GenericSmallMOKE/issues/3/events","html_url":"https://github.com/rvalkass/GenericSmallMOKE/issues/3","id":56034273,"number":3,"title":"All front panel inputs should be validated against potential user error","user":{"login":"rvalkass","id":1591118,"avatar_url":"https://avatars.githubusercontent.com/u/1591118?v=3","gravatar_id":"","url":"https://api.github.com/users/rvalkass","html_url":"https://github.com/rvalkass","followers_url":"https://api.github.com/users/rvalkass/followers","following_url":"https://api.github.com/users/rvalkass/following{/other_user}","gists_url":"https://api.github.com/users/rvalkass/gists{/gist_id}","starred_url":"https://api.github.com/users/rvalkass/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rvalkass/subscriptions","organizations_url":"https://api.github.com/users/rvalkass/orgs","repos_url":"https://api.github.com/users/rvalkass/repos","events_url":"https://api.github.com/users/rvalkass/events{/privacy}","received_events_url":"https://api.github.com/users/rvalkass/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/rvalkass/GenericSmallMOKE/labels/bug","name":"bug","color":"fc2929"}],"state":"open","locked":false,"assignee":{"login":"rvalkass","id":1591118,"avatar_url":"https://avatars.githubusercontent.com/u/1591118?v=3","gravatar_id":"","url":"https://api.github.com/users/rvalkass","html_url":"https://github.com/rvalkass","followers_url":"https://api.github.com/users/rvalkass/followers","following_url":"https://api.github.com/users/rvalkass/following{/other_user}","gists_url":"https://api.github.com/users/rvalkass/gists{/gist_id}","starred_url":"https://api.github.com/users/rvalkass/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rvalkass/subscriptions","organizations_url":"https://api.github.com/users/rvalkass/orgs","repos_url":"https://api.github.com/users/rvalkass/repos","events_url":"https://api.github.com/users/rvalkass/events{/privacy}","received_events_url":"https://api.github.com/users/rvalkass/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/rvalkass/GenericSmallMOKE/milestones/1","labels_url":"https://api.github.com/repos/rvalkass/GenericSmallMOKE/milestones/1/labels","id":958494,"number":1,"title":"Version 1.0","description":"First stable release with all reported bugs fixed and features implemented.","creator":{"login":"rvalkass","id":1591118,"avatar_url":"https://avatars.githubusercontent.com/u/1591118?v=3","gravatar_id":"","url":"https://api.github.com/users/rvalkass","html_url":"https://github.com/rvalkass","followers_url":"https://api.github.com/users/rvalkass/followers","following_url":"https://api.github.com/users/rvalkass/following{/other_user}","gists_url":"https://api.github.com/users/rvalkass/gists{/gist_id}","starred_url":"https://api.github.com/users/rvalkass/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rvalkass/subscriptions","organizations_url":"https://api.github.com/users/rvalkass/orgs","repos_url":"https://api.github.com/users/rvalkass/repos","events_url":"https://api.github.com/users/rvalkass/events{/privacy}","received_events_url":"https://api.github.com/users/rvalkass/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":1,"state":"open","created_at":"2015-01-30T16:14:37Z","updated_at":"2015-02-04T11:54:10Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2015-01-30T13:40:15Z","updated_at":"2015-02-06T14:48:13Z","closed_at":null,"body":"Not all front panel controls are validated to ensure no errors have been made by users. All inputs should be validated to ensure inputs fall within sensible/expected/safe limits."},"comment":{"url":"https://api.github.com/repos/rvalkass/GenericSmallMOKE/issues/comments/73246983","html_url":"https://github.com/rvalkass/GenericSmallMOKE/issues/3#issuecomment-73246983","issue_url":"https://api.github.com/repos/rvalkass/GenericSmallMOKE/issues/3","id":73246983,"user":{"login":"rvalkass","id":1591118,"avatar_url":"https://avatars.githubusercontent.com/u/1591118?v=3","gravatar_id":"","url":"https://api.github.com/users/rvalkass","html_url":"https://github.com/rvalkass","followers_url":"https://api.github.com/users/rvalkass/followers","following_url":"https://api.github.com/users/rvalkass/following{/other_user}","gists_url":"https://api.github.com/users/rvalkass/gists{/gist_id}","starred_url":"https://api.github.com/users/rvalkass/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rvalkass/subscriptions","organizations_url":"https://api.github.com/users/rvalkass/orgs","repos_url":"https://api.github.com/users/rvalkass/repos","events_url":"https://api.github.com/users/rvalkass/events{/privacy}","received_events_url":"https://api.github.com/users/rvalkass/received_events","type":"User","site_admin":false},"created_at":"2015-02-06T14:48:13Z","updated_at":"2015-02-06T14:48:13Z","body":"Going through the front panel:\r\n\r\n * There's no way to check whether the DAQ channels selected are sensible; they vary from lab to lab\r\n * The input voltage limit, again, cannot be checked against anything. Nothing bad will happen by setting it too low or high, either a waste of time or a loss of accuracy, respectively. It should, however, be a positive floating point value between 0 and 10.\r\n  * Could even be limited to the values specified in the docs from NI\r\n * The output voltage *can* be validated in some fashion. If the magnet voltages requested exceed the output voltage limit, inform the user (as there's no way of knowing which they made a mistake with) and abort the measurement process so they can fix it\r\n * Field settle time can only be validated as a positive integer\r\n * Number of loops can also only be validated as a positive integer\r\n * Magnet ramp segments can be validated, or partially eliminated to remove the potential for keying errors\r\n  * End points are unnecessary; the end of one segment is, by definition, the start of the next\r\n\r\nThe above validations will be added."}}