{"action":"created","issue":{"url":"https://api.github.com/repos/mapnik/python-mapnik/issues/5","labels_url":"https://api.github.com/repos/mapnik/python-mapnik/issues/5/labels{/name}","comments_url":"https://api.github.com/repos/mapnik/python-mapnik/issues/5/comments","events_url":"https://api.github.com/repos/mapnik/python-mapnik/issues/5/events","html_url":"https://github.com/mapnik/python-mapnik/issues/5","id":70297800,"number":5,"title":"Migrate out visual tests","user":{"login":"flippmoke","id":1794907,"avatar_url":"https://avatars.githubusercontent.com/u/1794907?v=3","gravatar_id":"","url":"https://api.github.com/users/flippmoke","html_url":"https://github.com/flippmoke","followers_url":"https://api.github.com/users/flippmoke/followers","following_url":"https://api.github.com/users/flippmoke/following{/other_user}","gists_url":"https://api.github.com/users/flippmoke/gists{/gist_id}","starred_url":"https://api.github.com/users/flippmoke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flippmoke/subscriptions","organizations_url":"https://api.github.com/users/flippmoke/orgs","repos_url":"https://api.github.com/users/flippmoke/repos","events_url":"https://api.github.com/users/flippmoke/events{/privacy}","received_events_url":"https://api.github.com/users/flippmoke/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-04-23T03:47:26Z","updated_at":"2015-04-27T16:35:19Z","closed_at":null,"body":"Visual tests are currently left in but should probably be in a dependant repository that relies on `python-mapnik` the reasoning behind this is that I want to keep the python package as small as possible. Possible it could also be moved into C++ code, but I still think it has value in python bindings as well.\r\n\r\n/cc @springmeyer "},"comment":{"url":"https://api.github.com/repos/mapnik/python-mapnik/issues/comments/96733192","html_url":"https://github.com/mapnik/python-mapnik/issues/5#issuecomment-96733192","issue_url":"https://api.github.com/repos/mapnik/python-mapnik/issues/5","id":96733192,"user":{"login":"springmeyer","id":20300,"avatar_url":"https://avatars.githubusercontent.com/u/20300?v=3","gravatar_id":"","url":"https://api.github.com/users/springmeyer","html_url":"https://github.com/springmeyer","followers_url":"https://api.github.com/users/springmeyer/followers","following_url":"https://api.github.com/users/springmeyer/following{/other_user}","gists_url":"https://api.github.com/users/springmeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/springmeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/springmeyer/subscriptions","organizations_url":"https://api.github.com/users/springmeyer/orgs","repos_url":"https://api.github.com/users/springmeyer/repos","events_url":"https://api.github.com/users/springmeyer/events{/privacy}","received_events_url":"https://api.github.com/users/springmeyer/received_events","type":"User","site_admin":false},"created_at":"2015-04-27T16:35:19Z","updated_at":"2015-04-27T16:35:19Z","body":"I've removed visual tests and data in ea41147.\r\n\r\nMy thinking is that they can now be pulled in dynamically via separate repos:\r\n\r\n - https://github.com/mapnik/test-data\r\n - https://github.com/mapnik/visual-tests\r\n\r\nI left the `python_tests` in place atm: Ideally they can be split into two types of tests: one set that do not depend on any external data from `test-data` (and are very pure unit tests) and other tests that only should be run if `test-data` are present."}}