{"action":"created","issue":{"url":"https://api.github.com/repos/dankelley/oce/issues/703","labels_url":"https://api.github.com/repos/dankelley/oce/issues/703/labels{/name}","comments_url":"https://api.github.com/repos/dankelley/oce/issues/703/comments","events_url":"https://api.github.com/repos/dankelley/oce/issues/703/events","html_url":"https://github.com/dankelley/oce/issues/703","id":95541483,"number":703,"title":"docs on read.adp should be more explicit on value (e.g. nav)","user":{"login":"dankelley","id":99469,"avatar_url":"https://avatars.githubusercontent.com/u/99469?v=3","gravatar_id":"","url":"https://api.github.com/users/dankelley","html_url":"https://github.com/dankelley","followers_url":"https://api.github.com/users/dankelley/followers","following_url":"https://api.github.com/users/dankelley/following{/other_user}","gists_url":"https://api.github.com/users/dankelley/gists{/gist_id}","starred_url":"https://api.github.com/users/dankelley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dankelley/subscriptions","organizations_url":"https://api.github.com/users/dankelley/orgs","repos_url":"https://api.github.com/users/dankelley/repos","events_url":"https://api.github.com/users/dankelley/events{/privacy}","received_events_url":"https://api.github.com/users/dankelley/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/dankelley/oce/labels/adp","name":"adp","color":"eb6420"}],"state":"closed","locked":false,"assignee":{"login":"dankelley","id":99469,"avatar_url":"https://avatars.githubusercontent.com/u/99469?v=3","gravatar_id":"","url":"https://api.github.com/users/dankelley","html_url":"https://github.com/dankelley","followers_url":"https://api.github.com/users/dankelley/followers","following_url":"https://api.github.com/users/dankelley/following{/other_user}","gists_url":"https://api.github.com/users/dankelley/gists{/gist_id}","starred_url":"https://api.github.com/users/dankelley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dankelley/subscriptions","organizations_url":"https://api.github.com/users/dankelley/orgs","repos_url":"https://api.github.com/users/dankelley/repos","events_url":"https://api.github.com/users/dankelley/events{/privacy}","received_events_url":"https://api.github.com/users/dankelley/received_events","type":"User","site_admin":false},"milestone":null,"comments":3,"created_at":"2015-07-16T22:06:50Z","updated_at":"2015-07-20T19:41:42Z","closed_at":"2015-07-17T13:57:33Z","body":"As I was coding a solution for #696, I realized that the docs should list the details of the value more precisely. For example, it should say that ``slongitude`` means such-and-such, and that it is named so-and-so on page blab-blah of the document name who-who etc. That way, users are encouraged to go to the RDI manual, which is where they should be looking to see what their instrument is doing."},"comment":{"url":"https://api.github.com/repos/dankelley/oce/issues/comments/123003075","html_url":"https://github.com/dankelley/oce/issues/703#issuecomment-123003075","issue_url":"https://api.github.com/repos/dankelley/oce/issues/703","id":123003075,"user":{"login":"richardsc","id":233584,"avatar_url":"https://avatars.githubusercontent.com/u/233584?v=3","gravatar_id":"","url":"https://api.github.com/users/richardsc","html_url":"https://github.com/richardsc","followers_url":"https://api.github.com/users/richardsc/followers","following_url":"https://api.github.com/users/richardsc/following{/other_user}","gists_url":"https://api.github.com/users/richardsc/gists{/gist_id}","starred_url":"https://api.github.com/users/richardsc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardsc/subscriptions","organizations_url":"https://api.github.com/users/richardsc/orgs","repos_url":"https://api.github.com/users/richardsc/repos","events_url":"https://api.github.com/users/richardsc/events{/privacy}","received_events_url":"https://api.github.com/users/richardsc/received_events","type":"User","site_admin":false},"created_at":"2015-07-20T19:41:42Z","updated_at":"2015-07-20T19:41:42Z","body":"I'm just having a look at the changes now. I'm going to put my responses to your \"in code\" comments from the `adp-class` man page here. I'll let you edit your comments as you make any changes.\r\n\r\n1. Re: `slatitude` and `elatitude` etc names. In principle I actually think I would prefer `startLatitude` and `endLatitude`, since it's more explicit. There is the problem of breaking old things, but I don't think too many people have been using the VMDAS capabilities yet (except for me and @gbennett02) so it shouldn't be catastrophic. The only reason I called them `slatitude` etc is because those are the names Rich P uses in is Matlab `rdradcp.m` code.\r\n\r\n2. From the `?'adp-class'` help page FIXME 1: I can't tell what `avgTrackTrue` really means relative to the GUI. I'll try poking around in it some more, but my guess is that it is \"True\".\r\n\r\n3. From the `?'adp-class'` help page FIXME 2: `navTime` or \"ADCP Ensemble time\" is displayed in the GUI as the title in the \"Data Quality\" box. Note that the `navTime` field should be exactly the same as the regular \"ADCP time\", i.e. `d[['time']]`. Using `testthat` to check should work -- it did for me, though it doesn't like that the order of the classes are different:\r\n```\r\n> expect_equal(d[['navTime']], d[['time']])\r\nError: d[[\"navTime\"]] not equal to d[[\"time\"]]\r\nAttributes: < Component “class”: 2 string mismatches >\r\ntarget is POSIXt, current is POSIXct\r\n> d[['navTime']][1]\r\n[1] \"2012-11-14 09:20:10.17 UTC\"\r\n> d[['time']][1]\r\n[1] \"2012-11-14 09:20:10.17 UTC\"\r\n> class(d[['navTime']][1])\r\n[1] \"POSIXct\" \"POSIXt\" \r\n> class(d[['time']][1])\r\n[1] \"POSIXt\"  \"POSIXct\"\r\n```\r\n\r\n4. From the `?'adp-class'` help page FIXME 3: Given that the `navTime` field is redundant, I don't think there's a high priority to rename it. I would consider renaming all the `s*`/`e*` things to be `start*`/`end*`, though, depending on what you think.\r\n"}}