{"action":"opened","number":2584,"pull_request":{"url":"https://api.github.com/repos/pantsbuild/pants/pulls/2584","id":50973428,"html_url":"https://github.com/pantsbuild/pants/pull/2584","diff_url":"https://github.com/pantsbuild/pants/pull/2584.diff","patch_url":"https://github.com/pantsbuild/pants/pull/2584.patch","issue_url":"https://api.github.com/repos/pantsbuild/pants/issues/2584","number":2584,"state":"open","locked":false,"title":"Fix a bug preventing re-upload artifacts that encountered read-errors","user":{"login":"peiyuwang","id":2474428,"avatar_url":"https://avatars.githubusercontent.com/u/2474428?v=3","gravatar_id":"","url":"https://api.github.com/users/peiyuwang","html_url":"https://github.com/peiyuwang","followers_url":"https://api.github.com/users/peiyuwang/followers","following_url":"https://api.github.com/users/peiyuwang/following{/other_user}","gists_url":"https://api.github.com/users/peiyuwang/gists{/gist_id}","starred_url":"https://api.github.com/users/peiyuwang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peiyuwang/subscriptions","organizations_url":"https://api.github.com/users/peiyuwang/orgs","repos_url":"https://api.github.com/users/peiyuwang/repos","events_url":"https://api.github.com/users/peiyuwang/events{/privacy}","received_events_url":"https://api.github.com/users/peiyuwang/received_events","type":"User","site_admin":false},"body":"We have this function from [rb/1361](https://rbcommons.com/s/twitter/r/1361) to write generated artifacts back to cache for artifacts encountered read errors. Unfortunately this probably never worked.\r\n\r\n```\r\n      elif isinstance(was_in_cache, UnreadableArtifact):\r\n        self._cache_key_errors.update(was_in_cache.key)\r\n```\r\n`set.update` takes `iterable`, since `was_in_cache.key` is a namedtuple of three elements, we get a set of these three elements instead of the cacheKey, and subsequent check when it comes to write generated artifact back will fail.\r\n\r\nChange `update` to `add` fixes this.\r\n","created_at":"2015-11-17T16:57:46Z","updated_at":"2015-11-17T16:57:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/pantsbuild/pants/pulls/2584/commits","review_comments_url":"https://api.github.com/repos/pantsbuild/pants/pulls/2584/comments","review_comment_url":"https://api.github.com/repos/pantsbuild/pants/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pantsbuild/pants/issues/2584/comments","statuses_url":"https://api.github.com/repos/pantsbuild/pants/statuses/8aaa7b145c7651906efa35bc0bddf484a880a577","head":{"label":"peiyuwang:peiyu/fix-write-artifact-in-error-back","ref":"peiyu/fix-write-artifact-in-error-back","sha":"8aaa7b145c7651906efa35bc0bddf484a880a577","user":{"login":"peiyuwang","id":2474428,"avatar_url":"https://avatars.githubusercontent.com/u/2474428?v=3","gravatar_id":"","url":"https://api.github.com/users/peiyuwang","html_url":"https://github.com/peiyuwang","followers_url":"https://api.github.com/users/peiyuwang/followers","following_url":"https://api.github.com/users/peiyuwang/following{/other_user}","gists_url":"https://api.github.com/users/peiyuwang/gists{/gist_id}","starred_url":"https://api.github.com/users/peiyuwang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peiyuwang/subscriptions","organizations_url":"https://api.github.com/users/peiyuwang/orgs","repos_url":"https://api.github.com/users/peiyuwang/repos","events_url":"https://api.github.com/users/peiyuwang/events{/privacy}","received_events_url":"https://api.github.com/users/peiyuwang/received_events","type":"User","site_admin":false},"repo":{"id":27841884,"name":"pants","full_name":"peiyuwang/pants","owner":{"login":"peiyuwang","id":2474428,"avatar_url":"https://avatars.githubusercontent.com/u/2474428?v=3","gravatar_id":"","url":"https://api.github.com/users/peiyuwang","html_url":"https://github.com/peiyuwang","followers_url":"https://api.github.com/users/peiyuwang/followers","following_url":"https://api.github.com/users/peiyuwang/following{/other_user}","gists_url":"https://api.github.com/users/peiyuwang/gists{/gist_id}","starred_url":"https://api.github.com/users/peiyuwang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peiyuwang/subscriptions","organizations_url":"https://api.github.com/users/peiyuwang/orgs","repos_url":"https://api.github.com/users/peiyuwang/repos","events_url":"https://api.github.com/users/peiyuwang/events{/privacy}","received_events_url":"https://api.github.com/users/peiyuwang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/peiyuwang/pants","description":"Pants Build System","fork":true,"url":"https://api.github.com/repos/peiyuwang/pants","forks_url":"https://api.github.com/repos/peiyuwang/pants/forks","keys_url":"https://api.github.com/repos/peiyuwang/pants/keys{/key_id}","collaborators_url":"https://api.github.com/repos/peiyuwang/pants/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/peiyuwang/pants/teams","hooks_url":"https://api.github.com/repos/peiyuwang/pants/hooks","issue_events_url":"https://api.github.com/repos/peiyuwang/pants/issues/events{/number}","events_url":"https://api.github.com/repos/peiyuwang/pants/events","assignees_url":"https://api.github.com/repos/peiyuwang/pants/assignees{/user}","branches_url":"https://api.github.com/repos/peiyuwang/pants/branches{/branch}","tags_url":"https://api.github.com/repos/peiyuwang/pants/tags","blobs_url":"https://api.github.com/repos/peiyuwang/pants/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/peiyuwang/pants/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/peiyuwang/pants/git/refs{/sha}","trees_url":"https://api.github.com/repos/peiyuwang/pants/git/trees{/sha}","statuses_url":"https://api.github.com/repos/peiyuwang/pants/statuses/{sha}","languages_url":"https://api.github.com/repos/peiyuwang/pants/languages","stargazers_url":"https://api.github.com/repos/peiyuwang/pants/stargazers","contributors_url":"https://api.github.com/repos/peiyuwang/pants/contributors","subscribers_url":"https://api.github.com/repos/peiyuwang/pants/subscribers","subscription_url":"https://api.github.com/repos/peiyuwang/pants/subscription","commits_url":"https://api.github.com/repos/peiyuwang/pants/commits{/sha}","git_commits_url":"https://api.github.com/repos/peiyuwang/pants/git/commits{/sha}","comments_url":"https://api.github.com/repos/peiyuwang/pants/comments{/number}","issue_comment_url":"https://api.github.com/repos/peiyuwang/pants/issues/comments{/number}","contents_url":"https://api.github.com/repos/peiyuwang/pants/contents/{+path}","compare_url":"https://api.github.com/repos/peiyuwang/pants/compare/{base}...{head}","merges_url":"https://api.github.com/repos/peiyuwang/pants/merges","archive_url":"https://api.github.com/repos/peiyuwang/pants/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/peiyuwang/pants/downloads","issues_url":"https://api.github.com/repos/peiyuwang/pants/issues{/number}","pulls_url":"https://api.github.com/repos/peiyuwang/pants/pulls{/number}","milestones_url":"https://api.github.com/repos/peiyuwang/pants/milestones{/number}","notifications_url":"https://api.github.com/repos/peiyuwang/pants/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/peiyuwang/pants/labels{/name}","releases_url":"https://api.github.com/repos/peiyuwang/pants/releases{/id}","created_at":"2014-12-10T22:02:15Z","updated_at":"2014-12-15T20:25:33Z","pushed_at":"2015-11-17T07:24:17Z","git_url":"git://github.com/peiyuwang/pants.git","ssh_url":"git@github.com:peiyuwang/pants.git","clone_url":"https://github.com/peiyuwang/pants.git","svn_url":"https://github.com/peiyuwang/pants","homepage":"http://pantsbuild.github.io/","size":57164,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pantsbuild:master","ref":"master","sha":"c764b94695bea1d4476a919b096894f8f6c6b73d","user":{"login":"pantsbuild","id":3065172,"avatar_url":"https://avatars.githubusercontent.com/u/3065172?v=3","gravatar_id":"","url":"https://api.github.com/users/pantsbuild","html_url":"https://github.com/pantsbuild","followers_url":"https://api.github.com/users/pantsbuild/followers","following_url":"https://api.github.com/users/pantsbuild/following{/other_user}","gists_url":"https://api.github.com/users/pantsbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/pantsbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pantsbuild/subscriptions","organizations_url":"https://api.github.com/users/pantsbuild/orgs","repos_url":"https://api.github.com/users/pantsbuild/repos","events_url":"https://api.github.com/users/pantsbuild/events{/privacy}","received_events_url":"https://api.github.com/users/pantsbuild/received_events","type":"Organization","site_admin":false},"repo":{"id":7209075,"name":"pants","full_name":"pantsbuild/pants","owner":{"login":"pantsbuild","id":3065172,"avatar_url":"https://avatars.githubusercontent.com/u/3065172?v=3","gravatar_id":"","url":"https://api.github.com/users/pantsbuild","html_url":"https://github.com/pantsbuild","followers_url":"https://api.github.com/users/pantsbuild/followers","following_url":"https://api.github.com/users/pantsbuild/following{/other_user}","gists_url":"https://api.github.com/users/pantsbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/pantsbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pantsbuild/subscriptions","organizations_url":"https://api.github.com/users/pantsbuild/orgs","repos_url":"https://api.github.com/users/pantsbuild/repos","events_url":"https://api.github.com/users/pantsbuild/events{/privacy}","received_events_url":"https://api.github.com/users/pantsbuild/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pantsbuild/pants","description":"Pants Build System","fork":false,"url":"https://api.github.com/repos/pantsbuild/pants","forks_url":"https://api.github.com/repos/pantsbuild/pants/forks","keys_url":"https://api.github.com/repos/pantsbuild/pants/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pantsbuild/pants/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pantsbuild/pants/teams","hooks_url":"https://api.github.com/repos/pantsbuild/pants/hooks","issue_events_url":"https://api.github.com/repos/pantsbuild/pants/issues/events{/number}","events_url":"https://api.github.com/repos/pantsbuild/pants/events","assignees_url":"https://api.github.com/repos/pantsbuild/pants/assignees{/user}","branches_url":"https://api.github.com/repos/pantsbuild/pants/branches{/branch}","tags_url":"https://api.github.com/repos/pantsbuild/pants/tags","blobs_url":"https://api.github.com/repos/pantsbuild/pants/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pantsbuild/pants/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pantsbuild/pants/git/refs{/sha}","trees_url":"https://api.github.com/repos/pantsbuild/pants/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pantsbuild/pants/statuses/{sha}","languages_url":"https://api.github.com/repos/pantsbuild/pants/languages","stargazers_url":"https://api.github.com/repos/pantsbuild/pants/stargazers","contributors_url":"https://api.github.com/repos/pantsbuild/pants/contributors","subscribers_url":"https://api.github.com/repos/pantsbuild/pants/subscribers","subscription_url":"https://api.github.com/repos/pantsbuild/pants/subscription","commits_url":"https://api.github.com/repos/pantsbuild/pants/commits{/sha}","git_commits_url":"https://api.github.com/repos/pantsbuild/pants/git/commits{/sha}","comments_url":"https://api.github.com/repos/pantsbuild/pants/comments{/number}","issue_comment_url":"https://api.github.com/repos/pantsbuild/pants/issues/comments{/number}","contents_url":"https://api.github.com/repos/pantsbuild/pants/contents/{+path}","compare_url":"https://api.github.com/repos/pantsbuild/pants/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pantsbuild/pants/merges","archive_url":"https://api.github.com/repos/pantsbuild/pants/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pantsbuild/pants/downloads","issues_url":"https://api.github.com/repos/pantsbuild/pants/issues{/number}","pulls_url":"https://api.github.com/repos/pantsbuild/pants/pulls{/number}","milestones_url":"https://api.github.com/repos/pantsbuild/pants/milestones{/number}","notifications_url":"https://api.github.com/repos/pantsbuild/pants/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pantsbuild/pants/labels{/name}","releases_url":"https://api.github.com/repos/pantsbuild/pants/releases{/id}","created_at":"2012-12-17T17:39:04Z","updated_at":"2015-11-17T15:46:19Z","pushed_at":"2015-11-17T15:04:58Z","git_url":"git://github.com/pantsbuild/pants.git","ssh_url":"git@github.com:pantsbuild/pants.git","clone_url":"https://github.com/pantsbuild/pants.git","svn_url":"https://github.com/pantsbuild/pants","homepage":"http://pantsbuild.github.io/","size":69883,"stargazers_count":440,"watchers_count":440,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":131,"mirror_url":null,"open_issues_count":364,"forks":131,"open_issues":364,"watchers":440,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pantsbuild/pants/pulls/2584"},"html":{"href":"https://github.com/pantsbuild/pants/pull/2584"},"issue":{"href":"https://api.github.com/repos/pantsbuild/pants/issues/2584"},"comments":{"href":"https://api.github.com/repos/pantsbuild/pants/issues/2584/comments"},"review_comments":{"href":"https://api.github.com/repos/pantsbuild/pants/pulls/2584/comments"},"review_comment":{"href":"https://api.github.com/repos/pantsbuild/pants/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pantsbuild/pants/pulls/2584/commits"},"statuses":{"href":"https://api.github.com/repos/pantsbuild/pants/statuses/8aaa7b145c7651906efa35bc0bddf484a880a577"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}