{"push_id":899053188,"size":9,"distinct_size":9,"ref":"refs/heads/master","head":"0097b42b87feec5b99b56577c355114f33438739","before":"38704a7457d5aba2172ecb251606d4752d7bc160","commits":[{"sha":"3a1c8784577bce4663df9b5e6c2498ce3ad7e3cc","author":{"email":"366634280b879ce3c6c984f83d5675d046b04925@gmail.com","name":"William Chargin"},"message":"Rename ChordView -> ChordEngraving","distinct":true,"url":"https://api.github.com/repos/WChargin/varese/commits/3a1c8784577bce4663df9b5e6c2498ce3ad7e3cc"},{"sha":"3b2f33b54c6dd0746d8aed092a13d7be007b5c93","author":{"email":"366634280b879ce3c6c984f83d5675d046b04925@gmail.com","name":"William Chargin"},"message":"Move \"Infold\" button into a little ad-hoc toolbar","distinct":true,"url":"https://api.github.com/repos/WChargin/varese/commits/3b2f33b54c6dd0746d8aed092a13d7be007b5c93"},{"sha":"7bfefad174e43e7bc7b931a3262cd00791ec6e18","author":{"email":"366634280b879ce3c6c984f83d5675d046b04925@gmail.com","name":"William Chargin"},"message":"Add a function to invert intervals\n\nTest Plan:\nUnit tests included. Run `npm test`.","distinct":true,"url":"https://api.github.com/repos/WChargin/varese/commits/7bfefad174e43e7bc7b931a3262cd00791ec6e18"},{"sha":"aea1f7ca4a6d334f4637b1c1cc0c6fe67c4dc28e","author":{"email":"366634280b879ce3c6c984f83d5675d046b04925@gmail.com","name":"William Chargin"},"message":"Add an `arraysEqual` helper function\n\nSummary:\n…and have fun with fixed points at the same time!\n\nTest Plan:\nUnit tests included. Run `npm test`.","distinct":true,"url":"https://api.github.com/repos/WChargin/varese/commits/aea1f7ca4a6d334f4637b1c1cc0c6fe67c4dc28e"},{"sha":"2acf46f70b4dffb97a4cb14c18f0f3a77c32dff7","author":{"email":"366634280b879ce3c6c984f83d5675d046b04925@gmail.com","name":"William Chargin"},"message":"Use new `arrayEquals` function\n\nSummary:\nGets rid of a TODO!","distinct":true,"url":"https://api.github.com/repos/WChargin/varese/commits/2acf46f70b4dffb97a4cb14c18f0f3a77c32dff7"},{"sha":"8609eb40630c71cb3f82676c57d5dbabe8046292","author":{"email":"366634280b879ce3c6c984f83d5675d046b04925@gmail.com","name":"William Chargin"},"message":"Add an inversion button to the tree view","distinct":true,"url":"https://api.github.com/repos/WChargin/varese/commits/8609eb40630c71cb3f82676c57d5dbabe8046292"},{"sha":"f390e4a0925b1d0444d06957e0065c037c50905a","author":{"email":"366634280b879ce3c6c984f83d5675d046b04925@gmail.com","name":"William Chargin"},"message":"Don't render chords that are way off the piano\n\nSummary:\nBefore this patch, you could go really far down the tree\nand get to chords like \"A1000, B1100, C1200.\"\nThese would take a while for VexFlow to render.\n(More specifically, they would crash the page.)\nSo we nip that in the bud.","distinct":true,"url":"https://api.github.com/repos/WChargin/varese/commits/f390e4a0925b1d0444d06957e0065c037c50905a"},{"sha":"50727d099de1c95025ac3ec67e5e320aed4e3519","author":{"email":"366634280b879ce3c6c984f83d5675d046b04925@gmail.com","name":"William Chargin"},"message":"Fix engraving padding problem!\n\nSummary:\nThe issue, as mentioned in 66425a52a653891ad107e0757d4e2b7581328de0,\nwas that the bounding box returned by `FormatAndDraw`\nonly accounted for the noteheads themselves,\nso if they all appeared below the staff but were spaced closely together\nthe height of the bounding box would be grossly underestimated.\nThis obviously made the spacing all wrong.\n\nThe solution is to use the built-in `getBBox` method of SVG elements.\nI was hesitant to use this previously because\nfor it to work properly (i.e., not return `(0, 0, 0, 0)`),\nthe SVG node must be already mounted in the DOM,\nso I was concerned that there would be some \"flickering\"\nbetween the time we mount the SVG and the time we set all the margins.\nBut that doesn't appear to be the case at all.\nPresumably this is due to the \"JavaScript blocks the DOM\" effect:\nthe browser needs the SVG to be in the DOM\nso that it can compute the styles (e.g., font sizes)\nand any transformations (e.g., scales, skews, translations),\nbut it doesn't actually render it to the user until the JS is all done.\n\nYay; it's the best of both worlds!\n\nTest Plan:\nSet the tree explorer root to `-60, -55, -50`\nand note that it renders just dandy.","distinct":true,"url":"https://api.github.com/repos/WChargin/varese/commits/50727d099de1c95025ac3ec67e5e320aed4e3519"},{"sha":"0097b42b87feec5b99b56577c355114f33438739","author":{"email":"366634280b879ce3c6c984f83d5675d046b04925@gmail.com","name":"William Chargin"},"message":"Remove the \"experimental\" warning about engravings\n\nSummary:\nSee f390e4a for details.","distinct":true,"url":"https://api.github.com/repos/WChargin/varese/commits/0097b42b87feec5b99b56577c355114f33438739"}]}