{"action":"created","issue":{"url":"https://api.github.com/repos/JuliaLang/julia/issues/12812","labels_url":"https://api.github.com/repos/JuliaLang/julia/issues/12812/labels{/name}","comments_url":"https://api.github.com/repos/JuliaLang/julia/issues/12812/comments","events_url":"https://api.github.com/repos/JuliaLang/julia/issues/12812/events","html_url":"https://github.com/JuliaLang/julia/pull/12812","id":103171447,"number":12812,"title":"Add missing three-parameter methods for A[tc]_mul_B!(::Triangular)","user":{"login":"jiahao","id":1732,"avatar_url":"https://avatars.githubusercontent.com/u/1732?v=3","gravatar_id":"","url":"https://api.github.com/users/jiahao","html_url":"https://github.com/jiahao","followers_url":"https://api.github.com/users/jiahao/followers","following_url":"https://api.github.com/users/jiahao/following{/other_user}","gists_url":"https://api.github.com/users/jiahao/gists{/gist_id}","starred_url":"https://api.github.com/users/jiahao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jiahao/subscriptions","organizations_url":"https://api.github.com/users/jiahao/orgs","repos_url":"https://api.github.com/users/jiahao/repos","events_url":"https://api.github.com/users/jiahao/events{/privacy}","received_events_url":"https://api.github.com/users/jiahao/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/JuliaLang/julia/labels/linear%20algebra","name":"linear algebra","color":"aa8800"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-08-26T04:25:50Z","updated_at":"2015-08-26T05:38:18Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/JuliaLang/julia/pulls/12812","html_url":"https://github.com/JuliaLang/julia/pull/12812","diff_url":"https://github.com/JuliaLang/julia/pull/12812.diff","patch_url":"https://github.com/JuliaLang/julia/pull/12812.patch"},"body":"These methods are needed for compatibility with ordinary dense matrices,\nwhich have the three-parameter forms."},"comment":{"url":"https://api.github.com/repos/JuliaLang/julia/issues/comments/134836229","html_url":"https://github.com/JuliaLang/julia/pull/12812#issuecomment-134836229","issue_url":"https://api.github.com/repos/JuliaLang/julia/issues/12812","id":134836229,"user":{"login":"kshyatt","id":828643,"avatar_url":"https://avatars.githubusercontent.com/u/828643?v=3","gravatar_id":"","url":"https://api.github.com/users/kshyatt","html_url":"https://github.com/kshyatt","followers_url":"https://api.github.com/users/kshyatt/followers","following_url":"https://api.github.com/users/kshyatt/following{/other_user}","gists_url":"https://api.github.com/users/kshyatt/gists{/gist_id}","starred_url":"https://api.github.com/users/kshyatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kshyatt/subscriptions","organizations_url":"https://api.github.com/users/kshyatt/orgs","repos_url":"https://api.github.com/users/kshyatt/repos","events_url":"https://api.github.com/users/kshyatt/events{/privacy}","received_events_url":"https://api.github.com/users/kshyatt/received_events","type":"User","site_admin":false},"created_at":"2015-08-26T05:38:18Z","updated_at":"2015-08-26T05:38:18Z","body":"So the `A_mul_Bc!` method right above these is broken. @jiahao, want to fix?\r\n```julia\r\njulia> A = UpperTriangular(triu(rand(5,5)))\r\n5x5 Base.LinAlg.UpperTriangular{Float64,Array{Float64,2}}:\r\n 0.16164  0.0451913  0.923648   0.530059   0.309064\r\n 0.0      0.795496   0.076705   0.804428   0.026893\r\n 0.0      0.0        0.0587068  0.577333   0.543837\r\n 0.0      0.0        0.0        0.0345792  0.0707721\r\n 0.0      0.0        0.0        0.0        0.341353\r\n\r\njulia> Base.LinAlg.A_mul_Bc!(zeros(5,5),A,ones(5,5))\r\nERROR: MethodError: `A_mul_Bc!` has no method matching A_mul_Bc!(::Base.LinAlg.UpperTriangular{Float64,Array{Float64,2}}, ::Array{Float64,2})\r\nClosest candidates are:\r\n  A_mul_Bc!{T<:Union{Complex{Float32},Complex{Float64},Float32,Float64},S<:Union{Float32,Float64}}(::Union{DenseArray{T<:Union{Complex{Float32},Complex{Float64},Float32,Float64},2},SubArray{T<:Union{Complex{Float32},Complex{Float64},Float32,Float64},2,A<:DenseArray{T,N},I<:Tuple{Vararg{Union{Colon,Int64,Range{Int64}}}},LD}}, ::Union{DenseArray{T<:Union{Complex{Float32},Complex{Float64},Float32,Float64},1},DenseArray{T<:Union{Complex{Float32},Complex{Float64},Float32,Float64},2},SubArray{T<:Union{Complex{Float32},Complex{Float64},Float32,Float64},1,A<:DenseArray{T,N},I<:Tuple{Vararg{Union{Colon,Int64,Range{Int64}}}},LD},SubArray{T<:Union{Complex{Float32},Complex{Float64},Float32,Float64},2,A<:DenseArray{T,N},I<:Tuple{Vararg{Union{Colon,Int64,Range{Int64}}}},LD}}, ::Union{DenseArray{S<:Union{Float32,Float64},1},DenseArray{S<:Union{Float32,Float64},2},SubArray{S<:Union{Float32,Float64},1,A<:DenseArray{T,N},I<:Tuple{Vararg{Union{Colon,Int64,Range{Int64}}}},LD},SubArray{S<:Union{Float32,Float64},2,A<:DenseArray{T,N},I<:Tuple{Vararg{Union{Colon,Int64,Range{Int64}}}},LD}})\r\n  A_mul_Bc!(::Union{DenseArray{T,2},SubArray{T,2,A<:DenseArray{T,N},I<:Tuple{Vararg{Union{Colon,Int64,Range{Int64}}}},LD}}, ::Union{DenseArray{T,1},DenseArray{T,2},SubArray{T,1,A<:DenseArray{T,N},I<:Tuple{Vararg{Union{Colon,Int64,Range{Int64}}}},LD},SubArray{T,2,A<:DenseArray{T,N},I<:Tuple{Vararg{Union{Colon,Int64,Range{Int64}}}},LD}}, ::Union{DenseArray{T,1},DenseArray{T,2},SubArray{T,1,A<:DenseArray{T,N},I<:Tuple{Vararg{Union{Colon,Int64,Range{Int64}}}},LD},SubArray{T,2,A<:DenseArray{T,N},I<:Tuple{Vararg{Union{Colon,Int64,Range{Int64}}}},LD}})\r\n  A_mul_Bc!(::Union{AbstractArray{T,1},AbstractArray{T,2}}, ::Base.LinAlg.AbstractTriangular{T,S<:AbstractArray{T,2}}, ::Union{AbstractArray{T,1},AbstractArray{T,2}})\r\n  ...\r\n in A_mul_Bc! at linalg/triangular.jl:313\r\n```"}}