{"action":"closed","number":164,"pull_request":{"url":"https://api.github.com/repos/apache/cordova-lib/pulls/164","id":29061503,"html_url":"https://github.com/apache/cordova-lib/pull/164","diff_url":"https://github.com/apache/cordova-lib/pull/164.diff","patch_url":"https://github.com/apache/cordova-lib/pull/164.patch","issue_url":"https://api.github.com/repos/apache/cordova-lib/issues/164","number":164,"state":"closed","locked":false,"title":"CB-8123 Plugin references can target specific windows platforms.","user":{"login":"TimBarham","id":9665847,"avatar_url":"https://avatars.githubusercontent.com/u/9665847?v=3","gravatar_id":"","url":"https://api.github.com/users/TimBarham","html_url":"https://github.com/TimBarham","followers_url":"https://api.github.com/users/TimBarham/followers","following_url":"https://api.github.com/users/TimBarham/following{/other_user}","gists_url":"https://api.github.com/users/TimBarham/gists{/gist_id}","starred_url":"https://api.github.com/users/TimBarham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TimBarham/subscriptions","organizations_url":"https://api.github.com/users/TimBarham/orgs","repos_url":"https://api.github.com/users/TimBarham/repos","events_url":"https://api.github.com/users/TimBarham/events{/privacy}","received_events_url":"https://api.github.com/users/TimBarham/received_events","type":"User","site_admin":false},"body":"Adds support for `target`, `versions` and `arch` attributes on `<lib-file>` and `<framework>` elements in the windows platform of plugin.xml. This allows plugin authors to target different references to different target platforms.\r\n\r\nAlso adds support for `src` attribute as an alias for the `Include` attribute on the `\r\n<lib-file>` element (since `src` is documented, but `Include` is used by existing plugins).\r\n\r\nAdds some tests to cover the new attributes. Updates existing plugin tests for windows8 platform to also test windows platform (left in windows8 tests to help verify backward compatibility with old windows8 platform).\r\n\r\nAs part of this change, refactored `jsproj` to `jsprojManager` to reflect the fact that, with the windows platform, this class now manages multiple jsproj files.\r\n\r\nBroken into three commits to separate file renames from changes, so that git can successfully track the changes.","created_at":"2015-02-11T01:18:36Z","updated_at":"2015-02-18T02:29:46Z","closed_at":"2015-02-18T02:29:46Z","merged_at":null,"merge_commit_sha":"3e83b3840104883f1e3b8aaf6206eae3fd1fc642","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/cordova-lib/pulls/164/commits","review_comments_url":"https://api.github.com/repos/apache/cordova-lib/pulls/164/comments","review_comment_url":"https://api.github.com/repos/apache/cordova-lib/pulls/comments/{number}","comments_url":"https://api.github.com/repos/apache/cordova-lib/issues/164/comments","statuses_url":"https://api.github.com/repos/apache/cordova-lib/statuses/5b31cecf7677a53279ded52158dd3a6ea57d379c","head":{"label":"MSOpenTech:CB-8123","ref":"CB-8123","sha":"5b31cecf7677a53279ded52158dd3a6ea57d379c","user":{"login":"MSOpenTech","id":1638184,"avatar_url":"https://avatars.githubusercontent.com/u/1638184?v=3","gravatar_id":"","url":"https://api.github.com/users/MSOpenTech","html_url":"https://github.com/MSOpenTech","followers_url":"https://api.github.com/users/MSOpenTech/followers","following_url":"https://api.github.com/users/MSOpenTech/following{/other_user}","gists_url":"https://api.github.com/users/MSOpenTech/gists{/gist_id}","starred_url":"https://api.github.com/users/MSOpenTech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MSOpenTech/subscriptions","organizations_url":"https://api.github.com/users/MSOpenTech/orgs","repos_url":"https://api.github.com/users/MSOpenTech/repos","events_url":"https://api.github.com/users/MSOpenTech/events{/privacy}","received_events_url":"https://api.github.com/users/MSOpenTech/received_events","type":"Organization","site_admin":false},"repo":{"id":19624574,"name":"cordova-lib","full_name":"MSOpenTech/cordova-lib","owner":{"login":"MSOpenTech","id":1638184,"avatar_url":"https://avatars.githubusercontent.com/u/1638184?v=3","gravatar_id":"","url":"https://api.github.com/users/MSOpenTech","html_url":"https://github.com/MSOpenTech","followers_url":"https://api.github.com/users/MSOpenTech/followers","following_url":"https://api.github.com/users/MSOpenTech/following{/other_user}","gists_url":"https://api.github.com/users/MSOpenTech/gists{/gist_id}","starred_url":"https://api.github.com/users/MSOpenTech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MSOpenTech/subscriptions","organizations_url":"https://api.github.com/users/MSOpenTech/orgs","repos_url":"https://api.github.com/users/MSOpenTech/repos","events_url":"https://api.github.com/users/MSOpenTech/events{/privacy}","received_events_url":"https://api.github.com/users/MSOpenTech/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MSOpenTech/cordova-lib","description":"Mirror of Apache Cordova","fork":true,"url":"https://api.github.com/repos/MSOpenTech/cordova-lib","forks_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/forks","keys_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/teams","hooks_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/hooks","issue_events_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/issues/events{/number}","events_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/events","assignees_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/assignees{/user}","branches_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/branches{/branch}","tags_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/tags","blobs_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/git/refs{/sha}","trees_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/statuses/{sha}","languages_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/languages","stargazers_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/stargazers","contributors_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/contributors","subscribers_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/subscribers","subscription_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/subscription","commits_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/commits{/sha}","git_commits_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/git/commits{/sha}","comments_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/comments{/number}","issue_comment_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/issues/comments/{number}","contents_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/contents/{+path}","compare_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/merges","archive_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/downloads","issues_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/issues{/number}","pulls_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/pulls{/number}","milestones_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/milestones{/number}","notifications_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/labels{/name}","releases_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/releases{/id}","created_at":"2014-05-09T20:30:32Z","updated_at":"2015-02-02T08:02:41Z","pushed_at":"2015-02-18T02:29:46Z","git_url":"git://github.com/MSOpenTech/cordova-lib.git","ssh_url":"git@github.com:MSOpenTech/cordova-lib.git","clone_url":"https://github.com/MSOpenTech/cordova-lib.git","svn_url":"https://github.com/MSOpenTech/cordova-lib","homepage":null,"size":44147,"stargazers_count":6,"watchers_count":6,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":0,"forks":3,"open_issues":0,"watchers":6,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"36194fa6e7e0480bc4b8e390cc9b742116dbe420","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":19524397,"name":"cordova-lib","full_name":"apache/cordova-lib","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/cordova-lib","description":"Mirror of Apache Cordova","fork":false,"url":"https://api.github.com/repos/apache/cordova-lib","forks_url":"https://api.github.com/repos/apache/cordova-lib/forks","keys_url":"https://api.github.com/repos/apache/cordova-lib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/cordova-lib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/cordova-lib/teams","hooks_url":"https://api.github.com/repos/apache/cordova-lib/hooks","issue_events_url":"https://api.github.com/repos/apache/cordova-lib/issues/events{/number}","events_url":"https://api.github.com/repos/apache/cordova-lib/events","assignees_url":"https://api.github.com/repos/apache/cordova-lib/assignees{/user}","branches_url":"https://api.github.com/repos/apache/cordova-lib/branches{/branch}","tags_url":"https://api.github.com/repos/apache/cordova-lib/tags","blobs_url":"https://api.github.com/repos/apache/cordova-lib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/cordova-lib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/cordova-lib/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/cordova-lib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/cordova-lib/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/cordova-lib/languages","stargazers_url":"https://api.github.com/repos/apache/cordova-lib/stargazers","contributors_url":"https://api.github.com/repos/apache/cordova-lib/contributors","subscribers_url":"https://api.github.com/repos/apache/cordova-lib/subscribers","subscription_url":"https://api.github.com/repos/apache/cordova-lib/subscription","commits_url":"https://api.github.com/repos/apache/cordova-lib/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/cordova-lib/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/cordova-lib/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/cordova-lib/issues/comments/{number}","contents_url":"https://api.github.com/repos/apache/cordova-lib/contents/{+path}","compare_url":"https://api.github.com/repos/apache/cordova-lib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/cordova-lib/merges","archive_url":"https://api.github.com/repos/apache/cordova-lib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/cordova-lib/downloads","issues_url":"https://api.github.com/repos/apache/cordova-lib/issues{/number}","pulls_url":"https://api.github.com/repos/apache/cordova-lib/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/cordova-lib/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/cordova-lib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/cordova-lib/labels{/name}","releases_url":"https://api.github.com/repos/apache/cordova-lib/releases{/id}","created_at":"2014-05-07T07:00:06Z","updated_at":"2015-02-18T02:17:04Z","pushed_at":"2015-02-18T02:17:03Z","git_url":"git://github.com/apache/cordova-lib.git","ssh_url":"git@github.com:apache/cordova-lib.git","clone_url":"https://github.com/apache/cordova-lib.git","svn_url":"https://github.com/apache/cordova-lib","homepage":null,"size":45593,"stargazers_count":39,"watchers_count":39,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":97,"mirror_url":"git://git.apache.org/cordova-lib.git","open_issues_count":12,"forks":97,"open_issues":12,"watchers":39,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/cordova-lib/pulls/164"},"html":{"href":"https://github.com/apache/cordova-lib/pull/164"},"issue":{"href":"https://api.github.com/repos/apache/cordova-lib/issues/164"},"comments":{"href":"https://api.github.com/repos/apache/cordova-lib/issues/164/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/cordova-lib/pulls/164/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/cordova-lib/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/apache/cordova-lib/pulls/164/commits"},"statuses":{"href":"https://api.github.com/repos/apache/cordova-lib/statuses/5b31cecf7677a53279ded52158dd3a6ea57d379c"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":4,"review_comments":0,"commits":3,"additions":1788,"deletions":478,"changed_files":31}}