{"action":"closed","number":8602,"pull_request":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/8602","id":53834524,"html_url":"https://github.com/xbmc/xbmc/pull/8602","diff_url":"https://github.com/xbmc/xbmc/pull/8602.diff","patch_url":"https://github.com/xbmc/xbmc/pull/8602.patch","issue_url":"https://api.github.com/repos/xbmc/xbmc/issues/8602","number":8602,"state":"closed","locked":false,"title":"[pvr][fix] wrong selected channel item in PVR windows","user":{"login":"xhaggi","id":1878991,"avatar_url":"https://avatars.githubusercontent.com/u/1878991?v=3","gravatar_id":"","url":"https://api.github.com/users/xhaggi","html_url":"https://github.com/xhaggi","followers_url":"https://api.github.com/users/xhaggi/followers","following_url":"https://api.github.com/users/xhaggi/following{/other_user}","gists_url":"https://api.github.com/users/xhaggi/gists{/gist_id}","starred_url":"https://api.github.com/users/xhaggi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xhaggi/subscriptions","organizations_url":"https://api.github.com/users/xhaggi/orgs","repos_url":"https://api.github.com/users/xhaggi/repos","events_url":"https://api.github.com/users/xhaggi/events{/privacy}","received_events_url":"https://api.github.com/users/xhaggi/received_events","type":"User","site_admin":false},"body":"This is a follow-up for #8582 and will fix the root cause of the issue reported by @MartijnKaijser.\r\n\r\n@ksooo after your refactoring of the guide window, where you moved all the stuff from `Update()` to `GetDirectory()`, you forget to check which stuff needs to be executed after the items are assigned to the view control. This is the reason why the first channel is selected at the first access because `epgGridContainer->SetChannel()` has no effect if called before the items are populated to the control. This will be fixed by the second commit.\r\n\r\nI've also moved the `SET_CONTROL_LABEL` stuff from `GetDirectory()` to `UpdateButtons()` where this stuff should be life in.\r\n\r\n","created_at":"2015-12-16T12:24:28Z","updated_at":"2015-12-16T16:59:43Z","closed_at":"2015-12-16T16:59:43Z","merged_at":"2015-12-16T16:59:43Z","merge_commit_sha":"2f42d5321f7566bf370e1fba17c09d745849cf1c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/xbmc/xbmc/pulls/8602/commits","review_comments_url":"https://api.github.com/repos/xbmc/xbmc/pulls/8602/comments","review_comment_url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xbmc/xbmc/issues/8602/comments","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/4a63af2e64ea7a628492cc9db6aaf372c941b7ce","head":{"label":"xhaggi:fix-channel-selection","ref":"fix-channel-selection","sha":"4a63af2e64ea7a628492cc9db6aaf372c941b7ce","user":{"login":"xhaggi","id":1878991,"avatar_url":"https://avatars.githubusercontent.com/u/1878991?v=3","gravatar_id":"","url":"https://api.github.com/users/xhaggi","html_url":"https://github.com/xhaggi","followers_url":"https://api.github.com/users/xhaggi/followers","following_url":"https://api.github.com/users/xhaggi/following{/other_user}","gists_url":"https://api.github.com/users/xhaggi/gists{/gist_id}","starred_url":"https://api.github.com/users/xhaggi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xhaggi/subscriptions","organizations_url":"https://api.github.com/users/xhaggi/orgs","repos_url":"https://api.github.com/users/xhaggi/repos","events_url":"https://api.github.com/users/xhaggi/events{/privacy}","received_events_url":"https://api.github.com/users/xhaggi/received_events","type":"User","site_admin":false},"repo":{"id":5698705,"name":"xbmc","full_name":"xhaggi/xbmc","owner":{"login":"xhaggi","id":1878991,"avatar_url":"https://avatars.githubusercontent.com/u/1878991?v=3","gravatar_id":"","url":"https://api.github.com/users/xhaggi","html_url":"https://github.com/xhaggi","followers_url":"https://api.github.com/users/xhaggi/followers","following_url":"https://api.github.com/users/xhaggi/following{/other_user}","gists_url":"https://api.github.com/users/xhaggi/gists{/gist_id}","starred_url":"https://api.github.com/users/xhaggi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xhaggi/subscriptions","organizations_url":"https://api.github.com/users/xhaggi/orgs","repos_url":"https://api.github.com/users/xhaggi/repos","events_url":"https://api.github.com/users/xhaggi/events{/privacy}","received_events_url":"https://api.github.com/users/xhaggi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xhaggi/xbmc","description":"XBMC Main Repository","fork":true,"url":"https://api.github.com/repos/xhaggi/xbmc","forks_url":"https://api.github.com/repos/xhaggi/xbmc/forks","keys_url":"https://api.github.com/repos/xhaggi/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xhaggi/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xhaggi/xbmc/teams","hooks_url":"https://api.github.com/repos/xhaggi/xbmc/hooks","issue_events_url":"https://api.github.com/repos/xhaggi/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/xhaggi/xbmc/events","assignees_url":"https://api.github.com/repos/xhaggi/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/xhaggi/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/xhaggi/xbmc/tags","blobs_url":"https://api.github.com/repos/xhaggi/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xhaggi/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xhaggi/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/xhaggi/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xhaggi/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/xhaggi/xbmc/languages","stargazers_url":"https://api.github.com/repos/xhaggi/xbmc/stargazers","contributors_url":"https://api.github.com/repos/xhaggi/xbmc/contributors","subscribers_url":"https://api.github.com/repos/xhaggi/xbmc/subscribers","subscription_url":"https://api.github.com/repos/xhaggi/xbmc/subscription","commits_url":"https://api.github.com/repos/xhaggi/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/xhaggi/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/xhaggi/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/xhaggi/xbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/xhaggi/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/xhaggi/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xhaggi/xbmc/merges","archive_url":"https://api.github.com/repos/xhaggi/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xhaggi/xbmc/downloads","issues_url":"https://api.github.com/repos/xhaggi/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/xhaggi/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/xhaggi/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/xhaggi/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xhaggi/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/xhaggi/xbmc/releases{/id}","created_at":"2012-09-06T07:06:44Z","updated_at":"2015-04-20T10:44:49Z","pushed_at":"2015-12-16T12:43:49Z","git_url":"git://github.com/xhaggi/xbmc.git","ssh_url":"git@github.com:xhaggi/xbmc.git","clone_url":"https://github.com/xhaggi/xbmc.git","svn_url":"https://github.com/xhaggi/xbmc","homepage":"http://xbmc.org","size":537447,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xbmc:master","ref":"master","sha":"2f8f76cb57778b5f92971e9908f4585e60433fb4","user":{"login":"xbmc","id":199122,"avatar_url":"https://avatars.githubusercontent.com/u/199122?v=3","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"repo":{"id":1217614,"name":"xbmc","full_name":"xbmc/xbmc","owner":{"login":"xbmc","id":199122,"avatar_url":"https://avatars.githubusercontent.com/u/199122?v=3","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xbmc/xbmc","description":"Kodi Main Repository - By using this code you agree with our policy and will follow the GPLv2 license as included","fork":false,"url":"https://api.github.com/repos/xbmc/xbmc","forks_url":"https://api.github.com/repos/xbmc/xbmc/forks","keys_url":"https://api.github.com/repos/xbmc/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xbmc/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xbmc/xbmc/teams","hooks_url":"https://api.github.com/repos/xbmc/xbmc/hooks","issue_events_url":"https://api.github.com/repos/xbmc/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/xbmc/xbmc/events","assignees_url":"https://api.github.com/repos/xbmc/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/xbmc/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/xbmc/xbmc/tags","blobs_url":"https://api.github.com/repos/xbmc/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xbmc/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xbmc/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/xbmc/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/xbmc/xbmc/languages","stargazers_url":"https://api.github.com/repos/xbmc/xbmc/stargazers","contributors_url":"https://api.github.com/repos/xbmc/xbmc/contributors","subscribers_url":"https://api.github.com/repos/xbmc/xbmc/subscribers","subscription_url":"https://api.github.com/repos/xbmc/xbmc/subscription","commits_url":"https://api.github.com/repos/xbmc/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/xbmc/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/xbmc/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/xbmc/xbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/xbmc/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/xbmc/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xbmc/xbmc/merges","archive_url":"https://api.github.com/repos/xbmc/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xbmc/xbmc/downloads","issues_url":"https://api.github.com/repos/xbmc/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/xbmc/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/xbmc/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/xbmc/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xbmc/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/xbmc/xbmc/releases{/id}","created_at":"2011-01-03T21:18:51Z","updated_at":"2015-12-16T14:15:04Z","pushed_at":"2015-12-16T16:59:43Z","git_url":"git://github.com/xbmc/xbmc.git","ssh_url":"git@github.com:xbmc/xbmc.git","clone_url":"https://github.com/xbmc/xbmc.git","svn_url":"https://github.com/xbmc/xbmc","homepage":"http://kodi.wiki/view/Official:Trademark_Policy","size":1721687,"stargazers_count":4333,"watchers_count":4333,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3188,"mirror_url":null,"open_issues_count":229,"forks":3188,"open_issues":229,"watchers":4333,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/8602"},"html":{"href":"https://github.com/xbmc/xbmc/pull/8602"},"issue":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/8602"},"comments":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/8602/comments"},"review_comments":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/8602/comments"},"review_comment":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/8602/commits"},"statuses":{"href":"https://api.github.com/repos/xbmc/xbmc/statuses/4a63af2e64ea7a628492cc9db6aaf372c941b7ce"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"xhaggi","id":1878991,"avatar_url":"https://avatars.githubusercontent.com/u/1878991?v=3","gravatar_id":"","url":"https://api.github.com/users/xhaggi","html_url":"https://github.com/xhaggi","followers_url":"https://api.github.com/users/xhaggi/followers","following_url":"https://api.github.com/users/xhaggi/following{/other_user}","gists_url":"https://api.github.com/users/xhaggi/gists{/gist_id}","starred_url":"https://api.github.com/users/xhaggi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xhaggi/subscriptions","organizations_url":"https://api.github.com/users/xhaggi/orgs","repos_url":"https://api.github.com/users/xhaggi/repos","events_url":"https://api.github.com/users/xhaggi/events{/privacy}","received_events_url":"https://api.github.com/users/xhaggi/received_events","type":"User","site_admin":false},"comments":5,"review_comments":2,"commits":2,"additions":54,"deletions":23,"changed_files":3}}