{"action":"created","comment":{"url":"https://api.github.com/repos/strongloop/strong-build/pulls/comments/34095873","id":34095873,"diff_hunk":"@@ -286,8 +287,8 @@ exports.build = function build(argv, callback) {\n     runWait('npm --quiet pack', function(er, output) {\n       if (er) return callback(er);\n \n-      // npm pack output is a single line with the pack file name\n-      var src = output.split('\\n')[0];\n+      var pkg = require(path.resolve('package.json'));","path":"index.js","position":19,"original_position":19,"commit_id":"5d851b5caad1fa8fb0e65c2f7540087c0a633706","original_commit_id":"5d851b5caad1fa8fb0e65c2f7540087c0a633706","user":{"login":"rmg","id":17978,"avatar_url":"https://avatars.githubusercontent.com/u/17978?v=3","gravatar_id":"","url":"https://api.github.com/users/rmg","html_url":"https://github.com/rmg","followers_url":"https://api.github.com/users/rmg/followers","following_url":"https://api.github.com/users/rmg/following{/other_user}","gists_url":"https://api.github.com/users/rmg/gists{/gist_id}","starred_url":"https://api.github.com/users/rmg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmg/subscriptions","organizations_url":"https://api.github.com/users/rmg/orgs","repos_url":"https://api.github.com/users/rmg/repos","events_url":"https://api.github.com/users/rmg/events{/privacy}","received_events_url":"https://api.github.com/users/rmg/received_events","type":"User","site_admin":false},"body":"Do we make any modifications to package.json? I don't think so.. but there should be a comment here pointing out that it this line will add it as-is to the `require.cache` just so there's a clue for future us when we're trying to figure out why it's not \"loading the right file\".","created_at":"2015-07-07T21:55:28Z","updated_at":"2015-07-07T21:55:28Z","html_url":"https://github.com/strongloop/strong-build/pull/31#discussion_r34095873","pull_request_url":"https://api.github.com/repos/strongloop/strong-build/pulls/31","_links":{"self":{"href":"https://api.github.com/repos/strongloop/strong-build/pulls/comments/34095873"},"html":{"href":"https://github.com/strongloop/strong-build/pull/31#discussion_r34095873"},"pull_request":{"href":"https://api.github.com/repos/strongloop/strong-build/pulls/31"}}},"pull_request":{"url":"https://api.github.com/repos/strongloop/strong-build/pulls/31","id":39333816,"html_url":"https://github.com/strongloop/strong-build/pull/31","diff_url":"https://github.com/strongloop/strong-build/pull/31.diff","patch_url":"https://github.com/strongloop/strong-build/pull/31.patch","issue_url":"https://api.github.com/repos/strongloop/strong-build/issues/31","number":31,"state":"open","locked":false,"title":"Construct packfile name from package","user":{"login":"sam-github","id":17607,"avatar_url":"https://avatars.githubusercontent.com/u/17607?v=3","gravatar_id":"","url":"https://api.github.com/users/sam-github","html_url":"https://github.com/sam-github","followers_url":"https://api.github.com/users/sam-github/followers","following_url":"https://api.github.com/users/sam-github/following{/other_user}","gists_url":"https://api.github.com/users/sam-github/gists{/gist_id}","starred_url":"https://api.github.com/users/sam-github/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sam-github/subscriptions","organizations_url":"https://api.github.com/users/sam-github/orgs","repos_url":"https://api.github.com/users/sam-github/repos","events_url":"https://api.github.com/users/sam-github/events{/privacy}","received_events_url":"https://api.github.com/users/sam-github/received_events","type":"User","site_admin":false},"body":"The approach of using the `npm pack` output assumes that there is no\r\nother output from npm, which isn't true when there are build scripts.\r\n\r\nconnected to strongloop-internal/scrum-nodeops#766\r\n\r\nreplaces https://github.com/strongloop/strong-build/pull/30","created_at":"2015-07-07T04:16:37Z","updated_at":"2015-07-07T21:55:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e1a88321e377b82beff7116095510d4236f50132","assignee":{"login":"rmg","id":17978,"avatar_url":"https://avatars.githubusercontent.com/u/17978?v=3","gravatar_id":"","url":"https://api.github.com/users/rmg","html_url":"https://github.com/rmg","followers_url":"https://api.github.com/users/rmg/followers","following_url":"https://api.github.com/users/rmg/following{/other_user}","gists_url":"https://api.github.com/users/rmg/gists{/gist_id}","starred_url":"https://api.github.com/users/rmg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmg/subscriptions","organizations_url":"https://api.github.com/users/rmg/orgs","repos_url":"https://api.github.com/users/rmg/repos","events_url":"https://api.github.com/users/rmg/events{/privacy}","received_events_url":"https://api.github.com/users/rmg/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/strongloop/strong-build/pulls/31/commits","review_comments_url":"https://api.github.com/repos/strongloop/strong-build/pulls/31/comments","review_comment_url":"https://api.github.com/repos/strongloop/strong-build/pulls/comments{/number}","comments_url":"https://api.github.com/repos/strongloop/strong-build/issues/31/comments","statuses_url":"https://api.github.com/repos/strongloop/strong-build/statuses/5d851b5caad1fa8fb0e65c2f7540087c0a633706","head":{"label":"strongloop:fix-finding-packfile-name","ref":"fix-finding-packfile-name","sha":"5d851b5caad1fa8fb0e65c2f7540087c0a633706","user":{"login":"strongloop","id":3020012,"avatar_url":"https://avatars.githubusercontent.com/u/3020012?v=3","gravatar_id":"","url":"https://api.github.com/users/strongloop","html_url":"https://github.com/strongloop","followers_url":"https://api.github.com/users/strongloop/followers","following_url":"https://api.github.com/users/strongloop/following{/other_user}","gists_url":"https://api.github.com/users/strongloop/gists{/gist_id}","starred_url":"https://api.github.com/users/strongloop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strongloop/subscriptions","organizations_url":"https://api.github.com/users/strongloop/orgs","repos_url":"https://api.github.com/users/strongloop/repos","events_url":"https://api.github.com/users/strongloop/events{/privacy}","received_events_url":"https://api.github.com/users/strongloop/received_events","type":"Organization","site_admin":false},"repo":{"id":20115200,"name":"strong-build","full_name":"strongloop/strong-build","owner":{"login":"strongloop","id":3020012,"avatar_url":"https://avatars.githubusercontent.com/u/3020012?v=3","gravatar_id":"","url":"https://api.github.com/users/strongloop","html_url":"https://github.com/strongloop","followers_url":"https://api.github.com/users/strongloop/followers","following_url":"https://api.github.com/users/strongloop/following{/other_user}","gists_url":"https://api.github.com/users/strongloop/gists{/gist_id}","starred_url":"https://api.github.com/users/strongloop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strongloop/subscriptions","organizations_url":"https://api.github.com/users/strongloop/orgs","repos_url":"https://api.github.com/users/strongloop/repos","events_url":"https://api.github.com/users/strongloop/events{/privacy}","received_events_url":"https://api.github.com/users/strongloop/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/strongloop/strong-build","description":"Build node packages into deployable applications","fork":false,"url":"https://api.github.com/repos/strongloop/strong-build","forks_url":"https://api.github.com/repos/strongloop/strong-build/forks","keys_url":"https://api.github.com/repos/strongloop/strong-build/keys{/key_id}","collaborators_url":"https://api.github.com/repos/strongloop/strong-build/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/strongloop/strong-build/teams","hooks_url":"https://api.github.com/repos/strongloop/strong-build/hooks","issue_events_url":"https://api.github.com/repos/strongloop/strong-build/issues/events{/number}","events_url":"https://api.github.com/repos/strongloop/strong-build/events","assignees_url":"https://api.github.com/repos/strongloop/strong-build/assignees{/user}","branches_url":"https://api.github.com/repos/strongloop/strong-build/branches{/branch}","tags_url":"https://api.github.com/repos/strongloop/strong-build/tags","blobs_url":"https://api.github.com/repos/strongloop/strong-build/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/strongloop/strong-build/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/strongloop/strong-build/git/refs{/sha}","trees_url":"https://api.github.com/repos/strongloop/strong-build/git/trees{/sha}","statuses_url":"https://api.github.com/repos/strongloop/strong-build/statuses/{sha}","languages_url":"https://api.github.com/repos/strongloop/strong-build/languages","stargazers_url":"https://api.github.com/repos/strongloop/strong-build/stargazers","contributors_url":"https://api.github.com/repos/strongloop/strong-build/contributors","subscribers_url":"https://api.github.com/repos/strongloop/strong-build/subscribers","subscription_url":"https://api.github.com/repos/strongloop/strong-build/subscription","commits_url":"https://api.github.com/repos/strongloop/strong-build/commits{/sha}","git_commits_url":"https://api.github.com/repos/strongloop/strong-build/git/commits{/sha}","comments_url":"https://api.github.com/repos/strongloop/strong-build/comments{/number}","issue_comment_url":"https://api.github.com/repos/strongloop/strong-build/issues/comments{/number}","contents_url":"https://api.github.com/repos/strongloop/strong-build/contents/{+path}","compare_url":"https://api.github.com/repos/strongloop/strong-build/compare/{base}...{head}","merges_url":"https://api.github.com/repos/strongloop/strong-build/merges","archive_url":"https://api.github.com/repos/strongloop/strong-build/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/strongloop/strong-build/downloads","issues_url":"https://api.github.com/repos/strongloop/strong-build/issues{/number}","pulls_url":"https://api.github.com/repos/strongloop/strong-build/pulls{/number}","milestones_url":"https://api.github.com/repos/strongloop/strong-build/milestones{/number}","notifications_url":"https://api.github.com/repos/strongloop/strong-build/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/strongloop/strong-build/labels{/name}","releases_url":"https://api.github.com/repos/strongloop/strong-build/releases{/id}","created_at":"2014-05-23T21:50:27Z","updated_at":"2015-06-25T01:56:27Z","pushed_at":"2015-07-07T04:18:07Z","git_url":"git://github.com/strongloop/strong-build.git","ssh_url":"git@github.com:strongloop/strong-build.git","clone_url":"https://github.com/strongloop/strong-build.git","svn_url":"https://github.com/strongloop/strong-build","homepage":null,"size":919,"stargazers_count":19,"watchers_count":19,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":8,"forks":4,"open_issues":8,"watchers":19,"default_branch":"master"}},"base":{"label":"strongloop:master","ref":"master","sha":"3221b91d398013cc9389d43581db505ef8c08151","user":{"login":"strongloop","id":3020012,"avatar_url":"https://avatars.githubusercontent.com/u/3020012?v=3","gravatar_id":"","url":"https://api.github.com/users/strongloop","html_url":"https://github.com/strongloop","followers_url":"https://api.github.com/users/strongloop/followers","following_url":"https://api.github.com/users/strongloop/following{/other_user}","gists_url":"https://api.github.com/users/strongloop/gists{/gist_id}","starred_url":"https://api.github.com/users/strongloop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strongloop/subscriptions","organizations_url":"https://api.github.com/users/strongloop/orgs","repos_url":"https://api.github.com/users/strongloop/repos","events_url":"https://api.github.com/users/strongloop/events{/privacy}","received_events_url":"https://api.github.com/users/strongloop/received_events","type":"Organization","site_admin":false},"repo":{"id":20115200,"name":"strong-build","full_name":"strongloop/strong-build","owner":{"login":"strongloop","id":3020012,"avatar_url":"https://avatars.githubusercontent.com/u/3020012?v=3","gravatar_id":"","url":"https://api.github.com/users/strongloop","html_url":"https://github.com/strongloop","followers_url":"https://api.github.com/users/strongloop/followers","following_url":"https://api.github.com/users/strongloop/following{/other_user}","gists_url":"https://api.github.com/users/strongloop/gists{/gist_id}","starred_url":"https://api.github.com/users/strongloop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strongloop/subscriptions","organizations_url":"https://api.github.com/users/strongloop/orgs","repos_url":"https://api.github.com/users/strongloop/repos","events_url":"https://api.github.com/users/strongloop/events{/privacy}","received_events_url":"https://api.github.com/users/strongloop/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/strongloop/strong-build","description":"Build node packages into deployable applications","fork":false,"url":"https://api.github.com/repos/strongloop/strong-build","forks_url":"https://api.github.com/repos/strongloop/strong-build/forks","keys_url":"https://api.github.com/repos/strongloop/strong-build/keys{/key_id}","collaborators_url":"https://api.github.com/repos/strongloop/strong-build/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/strongloop/strong-build/teams","hooks_url":"https://api.github.com/repos/strongloop/strong-build/hooks","issue_events_url":"https://api.github.com/repos/strongloop/strong-build/issues/events{/number}","events_url":"https://api.github.com/repos/strongloop/strong-build/events","assignees_url":"https://api.github.com/repos/strongloop/strong-build/assignees{/user}","branches_url":"https://api.github.com/repos/strongloop/strong-build/branches{/branch}","tags_url":"https://api.github.com/repos/strongloop/strong-build/tags","blobs_url":"https://api.github.com/repos/strongloop/strong-build/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/strongloop/strong-build/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/strongloop/strong-build/git/refs{/sha}","trees_url":"https://api.github.com/repos/strongloop/strong-build/git/trees{/sha}","statuses_url":"https://api.github.com/repos/strongloop/strong-build/statuses/{sha}","languages_url":"https://api.github.com/repos/strongloop/strong-build/languages","stargazers_url":"https://api.github.com/repos/strongloop/strong-build/stargazers","contributors_url":"https://api.github.com/repos/strongloop/strong-build/contributors","subscribers_url":"https://api.github.com/repos/strongloop/strong-build/subscribers","subscription_url":"https://api.github.com/repos/strongloop/strong-build/subscription","commits_url":"https://api.github.com/repos/strongloop/strong-build/commits{/sha}","git_commits_url":"https://api.github.com/repos/strongloop/strong-build/git/commits{/sha}","comments_url":"https://api.github.com/repos/strongloop/strong-build/comments{/number}","issue_comment_url":"https://api.github.com/repos/strongloop/strong-build/issues/comments{/number}","contents_url":"https://api.github.com/repos/strongloop/strong-build/contents/{+path}","compare_url":"https://api.github.com/repos/strongloop/strong-build/compare/{base}...{head}","merges_url":"https://api.github.com/repos/strongloop/strong-build/merges","archive_url":"https://api.github.com/repos/strongloop/strong-build/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/strongloop/strong-build/downloads","issues_url":"https://api.github.com/repos/strongloop/strong-build/issues{/number}","pulls_url":"https://api.github.com/repos/strongloop/strong-build/pulls{/number}","milestones_url":"https://api.github.com/repos/strongloop/strong-build/milestones{/number}","notifications_url":"https://api.github.com/repos/strongloop/strong-build/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/strongloop/strong-build/labels{/name}","releases_url":"https://api.github.com/repos/strongloop/strong-build/releases{/id}","created_at":"2014-05-23T21:50:27Z","updated_at":"2015-06-25T01:56:27Z","pushed_at":"2015-07-07T04:18:07Z","git_url":"git://github.com/strongloop/strong-build.git","ssh_url":"git@github.com:strongloop/strong-build.git","clone_url":"https://github.com/strongloop/strong-build.git","svn_url":"https://github.com/strongloop/strong-build","homepage":null,"size":919,"stargazers_count":19,"watchers_count":19,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":8,"forks":4,"open_issues":8,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/strongloop/strong-build/pulls/31"},"html":{"href":"https://github.com/strongloop/strong-build/pull/31"},"issue":{"href":"https://api.github.com/repos/strongloop/strong-build/issues/31"},"comments":{"href":"https://api.github.com/repos/strongloop/strong-build/issues/31/comments"},"review_comments":{"href":"https://api.github.com/repos/strongloop/strong-build/pulls/31/comments"},"review_comment":{"href":"https://api.github.com/repos/strongloop/strong-build/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/strongloop/strong-build/pulls/31/commits"},"statuses":{"href":"https://api.github.com/repos/strongloop/strong-build/statuses/5d851b5caad1fa8fb0e65c2f7540087c0a633706"}}}}