{"action":"created","issue":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/4288","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/4288/labels{/name}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/4288/comments","events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/4288/events","html_url":"https://github.com/scikit-learn/scikit-learn/pull/4288","id":58737123,"number":4288,"title":"[MRG] Allow nan for userdefined metric in dbscan et al","user":{"login":"ragv","id":9487348,"avatar_url":"https://avatars.githubusercontent.com/u/9487348?v=3","gravatar_id":"","url":"https://api.github.com/users/ragv","html_url":"https://github.com/ragv","followers_url":"https://api.github.com/users/ragv/followers","following_url":"https://api.github.com/users/ragv/following{/other_user}","gists_url":"https://api.github.com/users/ragv/gists{/gist_id}","starred_url":"https://api.github.com/users/ragv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ragv/subscriptions","organizations_url":"https://api.github.com/users/ragv/orgs","repos_url":"https://api.github.com/users/ragv/repos","events_url":"https://api.github.com/users/ragv/events{/privacy}","received_events_url":"https://api.github.com/users/ragv/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2015-02-24T13:21:34Z","updated_at":"2015-03-23T14:39:08Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/4288","html_url":"https://github.com/scikit-learn/scikit-learn/pull/4288","diff_url":"https://github.com/scikit-learn/scikit-learn/pull/4288.diff","patch_url":"https://github.com/scikit-learn/scikit-learn/pull/4288.patch"},"body":"fixes #4283"},"comment":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/comments/85028736","html_url":"https://github.com/scikit-learn/scikit-learn/pull/4288#issuecomment-85028736","issue_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/4288","id":85028736,"user":{"login":"amueller","id":449558,"avatar_url":"https://avatars.githubusercontent.com/u/449558?v=3","gravatar_id":"","url":"https://api.github.com/users/amueller","html_url":"https://github.com/amueller","followers_url":"https://api.github.com/users/amueller/followers","following_url":"https://api.github.com/users/amueller/following{/other_user}","gists_url":"https://api.github.com/users/amueller/gists{/gist_id}","starred_url":"https://api.github.com/users/amueller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amueller/subscriptions","organizations_url":"https://api.github.com/users/amueller/orgs","repos_url":"https://api.github.com/users/amueller/repos","events_url":"https://api.github.com/users/amueller/events{/privacy}","received_events_url":"https://api.github.com/users/amueller/received_events","type":"User","site_admin":false},"created_at":"2015-03-23T14:39:08Z","updated_at":"2015-03-23T14:39:08Z","body":"I don't understand why there are changes in ``BinaryTree``. That doesn't support user-defined metrics, right?\r\nAlso, I'm now a bit doubtful if this fix goes far enough. How about user-defined metrics on non-numeric arrays? Should we cover these, too (like string-edit distances on strings).\r\n\r\nAlso: how can we make sure this is fixed everywhere where a user-defined distance / similarity can be passed? (all kernel methods, for example)."}}