{"action":"created","issue":{"url":"https://api.github.com/repos/rust-lang/rust/issues/26018","labels_url":"https://api.github.com/repos/rust-lang/rust/issues/26018/labels{/name}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/26018/comments","events_url":"https://api.github.com/repos/rust-lang/rust/issues/26018/events","html_url":"https://github.com/rust-lang/rust/pull/26018","id":85316498,"number":26018,"title":"Fix type and linkage errors with parallel codegen","user":{"login":"nrc","id":762626,"avatar_url":"https://avatars.githubusercontent.com/u/762626?v=3","gravatar_id":"","url":"https://api.github.com/users/nrc","html_url":"https://github.com/nrc","followers_url":"https://api.github.com/users/nrc/followers","following_url":"https://api.github.com/users/nrc/following{/other_user}","gists_url":"https://api.github.com/users/nrc/gists{/gist_id}","starred_url":"https://api.github.com/users/nrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nrc/subscriptions","organizations_url":"https://api.github.com/users/nrc/orgs","repos_url":"https://api.github.com/users/nrc/repos","events_url":"https://api.github.com/users/nrc/events{/privacy}","received_events_url":"https://api.github.com/users/nrc/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"nikomatsakis","id":155238,"avatar_url":"https://avatars.githubusercontent.com/u/155238?v=3","gravatar_id":"","url":"https://api.github.com/users/nikomatsakis","html_url":"https://github.com/nikomatsakis","followers_url":"https://api.github.com/users/nikomatsakis/followers","following_url":"https://api.github.com/users/nikomatsakis/following{/other_user}","gists_url":"https://api.github.com/users/nikomatsakis/gists{/gist_id}","starred_url":"https://api.github.com/users/nikomatsakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikomatsakis/subscriptions","organizations_url":"https://api.github.com/users/nikomatsakis/orgs","repos_url":"https://api.github.com/users/nikomatsakis/repos","events_url":"https://api.github.com/users/nikomatsakis/events{/privacy}","received_events_url":"https://api.github.com/users/nikomatsakis/received_events","type":"User","site_admin":false},"milestone":null,"comments":16,"created_at":"2015-06-04T22:59:02Z","updated_at":"2015-06-08T02:50:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/26018","html_url":"https://github.com/rust-lang/rust/pull/26018","diff_url":"https://github.com/rust-lang/rust/pull/26018.diff","patch_url":"https://github.com/rust-lang/rust/pull/26018.patch"},"body":"Closes #19826\r\n\r\nr? @nikomatsakis \r\n\r\nThere is still some work to do until parallel codegen is perfect - we don't pass make check due to missing the symbol for registering a macro. But we do bootstrap with codegen_units=4 and pass make check without codegen_units, so I think it should land.\r\n\r\nFor the curious, make rustc-stage2 -j8:\r\n\r\n```\r\ncodegen_units=1:\r\n\r\nreal  9m18.074s\r\nuser  11m59.858s\r\nsys 0m13.281s\r\n\r\n\r\ncodegen_units=4:\r\n\r\nreal  6m3.672s\r\nuser  13m5.474s\r\nsys 0m12.146s\r\n```\r\n\r\nWhich is a 33% speedup :-)"},"comment":{"url":"https://api.github.com/repos/rust-lang/rust/issues/comments/109843734","html_url":"https://github.com/rust-lang/rust/pull/26018#issuecomment-109843734","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/26018","id":109843734,"user":{"login":"nrc","id":762626,"avatar_url":"https://avatars.githubusercontent.com/u/762626?v=3","gravatar_id":"","url":"https://api.github.com/users/nrc","html_url":"https://github.com/nrc","followers_url":"https://api.github.com/users/nrc/followers","following_url":"https://api.github.com/users/nrc/following{/other_user}","gists_url":"https://api.github.com/users/nrc/gists{/gist_id}","starred_url":"https://api.github.com/users/nrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nrc/subscriptions","organizations_url":"https://api.github.com/users/nrc/orgs","repos_url":"https://api.github.com/users/nrc/repos","events_url":"https://api.github.com/users/nrc/events{/privacy}","received_events_url":"https://api.github.com/users/nrc/received_events","type":"User","site_admin":false},"created_at":"2015-06-08T02:50:00Z","updated_at":"2015-06-08T02:50:00Z","body":"@bors: retry"}}