{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/pontoon/pulls/comments/43330883","id":43330883,"diff_hunk":"@@ -841,13 +908,11 @@ def __unicode__(self):\n         return str(int(round(percent)))\n \n \n+@receiver(post_save, sender=User)","path":"pontoon/base/models.py","position":74,"original_position":119,"commit_id":"46ff53502e36bcc45cf5d7779ba64fb6d1e23732","original_commit_id":"8c27d6d107c393736f688af2d1e616760e74fb8b","user":{"login":"Osmose","id":193106,"avatar_url":"https://avatars.githubusercontent.com/u/193106?v=3","gravatar_id":"","url":"https://api.github.com/users/Osmose","html_url":"https://github.com/Osmose","followers_url":"https://api.github.com/users/Osmose/followers","following_url":"https://api.github.com/users/Osmose/following{/other_user}","gists_url":"https://api.github.com/users/Osmose/gists{/gist_id}","starred_url":"https://api.github.com/users/Osmose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Osmose/subscriptions","organizations_url":"https://api.github.com/users/Osmose/orgs","repos_url":"https://api.github.com/users/Osmose/repos","events_url":"https://api.github.com/users/Osmose/events{/privacy}","received_events_url":"https://api.github.com/users/Osmose/received_events","type":"User","site_admin":false},"body":"I believe this is called \"leaving the place cleaner than how you found it\"","created_at":"2015-10-28T23:08:19Z","updated_at":"2015-10-28T23:08:19Z","html_url":"https://github.com/mozilla/pontoon/pull/219#discussion_r43330883","pull_request_url":"https://api.github.com/repos/mozilla/pontoon/pulls/219","_links":{"self":{"href":"https://api.github.com/repos/mozilla/pontoon/pulls/comments/43330883"},"html":{"href":"https://github.com/mozilla/pontoon/pull/219#discussion_r43330883"},"pull_request":{"href":"https://api.github.com/repos/mozilla/pontoon/pulls/219"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/pontoon/pulls/219","id":48148751,"html_url":"https://github.com/mozilla/pontoon/pull/219","diff_url":"https://github.com/mozilla/pontoon/pull/219.diff","patch_url":"https://github.com/mozilla/pontoon/pull/219.patch","issue_url":"https://api.github.com/repos/mozilla/pontoon/issues/219","number":219,"state":"open","locked":false,"title":"Fix bug 952488 - Added locale managers","user":{"login":"jotes","id":8784972,"avatar_url":"https://avatars.githubusercontent.com/u/8784972?v=3","gravatar_id":"","url":"https://api.github.com/users/jotes","html_url":"https://github.com/jotes","followers_url":"https://api.github.com/users/jotes/followers","following_url":"https://api.github.com/users/jotes/following{/other_user}","gists_url":"https://api.github.com/users/jotes/gists{/gist_id}","starred_url":"https://api.github.com/users/jotes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jotes/subscriptions","organizations_url":"https://api.github.com/users/jotes/orgs","repos_url":"https://api.github.com/users/jotes/repos","events_url":"https://api.github.com/users/jotes/events{/privacy}","received_events_url":"https://api.github.com/users/jotes/received_events","type":"User","site_admin":false},"body":"@Osmose @mathjazz Hi,\r\n\r\nI would say it's an alpha version of migrations. There's a lot to discuss because i wasn't sure about some things. Hopefully every change should be relatively easy.\r\nMy questions and doubts:\r\n- i'm assigning groups to locale because it's a lot easier to assign users. I think it will benefit in future, however i don't want to over-engineer anything.\r\n- i'm not sure if goods idea to have signals which create these permission groups associated with locale. I mean, i don't now how often locale are added, maybe it's a rare case so this isn't so important feat. I could add separate bootstrap function for locale groups. It would speedup tests and object creation.\r\n- I've added some tests for models, i'm not sure if views require them as they use has_perm functions.","created_at":"2015-10-20T01:59:34Z","updated_at":"2015-10-28T23:08:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"db738708c5c6a0cb0050ae05e63a5f9c258f59f3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/pontoon/pulls/219/commits","review_comments_url":"https://api.github.com/repos/mozilla/pontoon/pulls/219/comments","review_comment_url":"https://api.github.com/repos/mozilla/pontoon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/pontoon/issues/219/comments","statuses_url":"https://api.github.com/repos/mozilla/pontoon/statuses/46ff53502e36bcc45cf5d7779ba64fb6d1e23732","head":{"label":"jotes:locale_managers","ref":"locale_managers","sha":"46ff53502e36bcc45cf5d7779ba64fb6d1e23732","user":{"login":"jotes","id":8784972,"avatar_url":"https://avatars.githubusercontent.com/u/8784972?v=3","gravatar_id":"","url":"https://api.github.com/users/jotes","html_url":"https://github.com/jotes","followers_url":"https://api.github.com/users/jotes/followers","following_url":"https://api.github.com/users/jotes/following{/other_user}","gists_url":"https://api.github.com/users/jotes/gists{/gist_id}","starred_url":"https://api.github.com/users/jotes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jotes/subscriptions","organizations_url":"https://api.github.com/users/jotes/orgs","repos_url":"https://api.github.com/users/jotes/repos","events_url":"https://api.github.com/users/jotes/events{/privacy}","received_events_url":"https://api.github.com/users/jotes/received_events","type":"User","site_admin":false},"repo":{"id":40921914,"name":"pontoon","full_name":"jotes/pontoon","owner":{"login":"jotes","id":8784972,"avatar_url":"https://avatars.githubusercontent.com/u/8784972?v=3","gravatar_id":"","url":"https://api.github.com/users/jotes","html_url":"https://github.com/jotes","followers_url":"https://api.github.com/users/jotes/followers","following_url":"https://api.github.com/users/jotes/following{/other_user}","gists_url":"https://api.github.com/users/jotes/gists{/gist_id}","starred_url":"https://api.github.com/users/jotes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jotes/subscriptions","organizations_url":"https://api.github.com/users/jotes/orgs","repos_url":"https://api.github.com/users/jotes/repos","events_url":"https://api.github.com/users/jotes/events{/privacy}","received_events_url":"https://api.github.com/users/jotes/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jotes/pontoon","description":"In-place localization tool","fork":true,"url":"https://api.github.com/repos/jotes/pontoon","forks_url":"https://api.github.com/repos/jotes/pontoon/forks","keys_url":"https://api.github.com/repos/jotes/pontoon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jotes/pontoon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jotes/pontoon/teams","hooks_url":"https://api.github.com/repos/jotes/pontoon/hooks","issue_events_url":"https://api.github.com/repos/jotes/pontoon/issues/events{/number}","events_url":"https://api.github.com/repos/jotes/pontoon/events","assignees_url":"https://api.github.com/repos/jotes/pontoon/assignees{/user}","branches_url":"https://api.github.com/repos/jotes/pontoon/branches{/branch}","tags_url":"https://api.github.com/repos/jotes/pontoon/tags","blobs_url":"https://api.github.com/repos/jotes/pontoon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jotes/pontoon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jotes/pontoon/git/refs{/sha}","trees_url":"https://api.github.com/repos/jotes/pontoon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jotes/pontoon/statuses/{sha}","languages_url":"https://api.github.com/repos/jotes/pontoon/languages","stargazers_url":"https://api.github.com/repos/jotes/pontoon/stargazers","contributors_url":"https://api.github.com/repos/jotes/pontoon/contributors","subscribers_url":"https://api.github.com/repos/jotes/pontoon/subscribers","subscription_url":"https://api.github.com/repos/jotes/pontoon/subscription","commits_url":"https://api.github.com/repos/jotes/pontoon/commits{/sha}","git_commits_url":"https://api.github.com/repos/jotes/pontoon/git/commits{/sha}","comments_url":"https://api.github.com/repos/jotes/pontoon/comments{/number}","issue_comment_url":"https://api.github.com/repos/jotes/pontoon/issues/comments{/number}","contents_url":"https://api.github.com/repos/jotes/pontoon/contents/{+path}","compare_url":"https://api.github.com/repos/jotes/pontoon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jotes/pontoon/merges","archive_url":"https://api.github.com/repos/jotes/pontoon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jotes/pontoon/downloads","issues_url":"https://api.github.com/repos/jotes/pontoon/issues{/number}","pulls_url":"https://api.github.com/repos/jotes/pontoon/pulls{/number}","milestones_url":"https://api.github.com/repos/jotes/pontoon/milestones{/number}","notifications_url":"https://api.github.com/repos/jotes/pontoon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jotes/pontoon/labels{/name}","releases_url":"https://api.github.com/repos/jotes/pontoon/releases{/id}","created_at":"2015-08-17T19:18:45Z","updated_at":"2015-08-17T19:18:46Z","pushed_at":"2015-10-27T15:03:45Z","git_url":"git://github.com/jotes/pontoon.git","ssh_url":"git@github.com:jotes/pontoon.git","clone_url":"https://github.com/jotes/pontoon.git","svn_url":"https://github.com/jotes/pontoon","homepage":"https://pontoon.mozilla.org/","size":18526,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"f4024269b2e2973fb8b493b66c236998b123bb87","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":1385890,"name":"pontoon","full_name":"mozilla/pontoon","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/pontoon","description":"In-place localization tool","fork":false,"url":"https://api.github.com/repos/mozilla/pontoon","forks_url":"https://api.github.com/repos/mozilla/pontoon/forks","keys_url":"https://api.github.com/repos/mozilla/pontoon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/pontoon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/pontoon/teams","hooks_url":"https://api.github.com/repos/mozilla/pontoon/hooks","issue_events_url":"https://api.github.com/repos/mozilla/pontoon/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/pontoon/events","assignees_url":"https://api.github.com/repos/mozilla/pontoon/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/pontoon/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/pontoon/tags","blobs_url":"https://api.github.com/repos/mozilla/pontoon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/pontoon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/pontoon/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/pontoon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/pontoon/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/pontoon/languages","stargazers_url":"https://api.github.com/repos/mozilla/pontoon/stargazers","contributors_url":"https://api.github.com/repos/mozilla/pontoon/contributors","subscribers_url":"https://api.github.com/repos/mozilla/pontoon/subscribers","subscription_url":"https://api.github.com/repos/mozilla/pontoon/subscription","commits_url":"https://api.github.com/repos/mozilla/pontoon/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/pontoon/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/pontoon/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/pontoon/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/pontoon/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/pontoon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/pontoon/merges","archive_url":"https://api.github.com/repos/mozilla/pontoon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/pontoon/downloads","issues_url":"https://api.github.com/repos/mozilla/pontoon/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/pontoon/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/pontoon/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/pontoon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/pontoon/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/pontoon/releases{/id}","created_at":"2011-02-19T11:25:51Z","updated_at":"2015-10-25T09:55:43Z","pushed_at":"2015-10-28T23:00:55Z","git_url":"git://github.com/mozilla/pontoon.git","ssh_url":"git@github.com:mozilla/pontoon.git","clone_url":"https://github.com/mozilla/pontoon.git","svn_url":"https://github.com/mozilla/pontoon","homepage":"https://pontoon.mozilla.org/","size":23747,"stargazers_count":78,"watchers_count":78,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":30,"mirror_url":null,"open_issues_count":5,"forks":30,"open_issues":5,"watchers":78,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/pontoon/pulls/219"},"html":{"href":"https://github.com/mozilla/pontoon/pull/219"},"issue":{"href":"https://api.github.com/repos/mozilla/pontoon/issues/219"},"comments":{"href":"https://api.github.com/repos/mozilla/pontoon/issues/219/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/pontoon/pulls/219/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/pontoon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/pontoon/pulls/219/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/pontoon/statuses/46ff53502e36bcc45cf5d7779ba64fb6d1e23732"}}}}