{"action":"created","comment":{"url":"https://api.github.com/repos/hawkular/hawkular-inventory/pulls/comments/28520885","id":28520885,"diff_hunk":"@@ -112,8 +113,9 @@ public ResourceType get(@PathParam(\"tenantId\") String tenantId,\n     public Set<Resource> getResources(@PathParam(\"tenantId\") String tenantId,\n                                       @PathParam(\"resourceTypeId\") String resourceTypeId) {\n \n-        return inventory.tenants().get(tenantId).resourceTypes().get(resourceTypeId)\n-                .resources().getAll().entities();\n+        ResourceTypes.Single single = inventory.tenants().get(tenantId).resourceTypes().get(resourceTypeId);","path":"rest-servlet/src/main/java/org/hawkular/inventory/rest/RestResourceTypes.java","position":14,"original_position":14,"commit_id":"b4e50e7e0f8e48d7b55f750eac9866325e495322","original_commit_id":"b4e50e7e0f8e48d7b55f750eac9866325e495322","user":{"login":"metlos","id":19999,"avatar_url":"https://avatars.githubusercontent.com/u/19999?v=3","gravatar_id":"","url":"https://api.github.com/users/metlos","html_url":"https://github.com/metlos","followers_url":"https://api.github.com/users/metlos/followers","following_url":"https://api.github.com/users/metlos/following{/other_user}","gists_url":"https://api.github.com/users/metlos/gists{/gist_id}","starred_url":"https://api.github.com/users/metlos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metlos/subscriptions","organizations_url":"https://api.github.com/users/metlos/orgs","repos_url":"https://api.github.com/users/metlos/repos","events_url":"https://api.github.com/users/metlos/events{/privacy}","received_events_url":"https://api.github.com/users/metlos/received_events","type":"User","site_admin":false},"body":"This is a more general problem, IMHO, with the way we resolve `entities()` method in the tinkerpop impl. I am not sure we should resolve to one-off fixups like this, because the same issue is still present for all other entity types.","created_at":"2015-04-16T15:37:41Z","updated_at":"2015-04-16T15:37:41Z","html_url":"https://github.com/hawkular/hawkular-inventory/pull/53#discussion_r28520885","pull_request_url":"https://api.github.com/repos/hawkular/hawkular-inventory/pulls/53","_links":{"self":{"href":"https://api.github.com/repos/hawkular/hawkular-inventory/pulls/comments/28520885"},"html":{"href":"https://github.com/hawkular/hawkular-inventory/pull/53#discussion_r28520885"},"pull_request":{"href":"https://api.github.com/repos/hawkular/hawkular-inventory/pulls/53"}}},"pull_request":{"url":"https://api.github.com/repos/hawkular/hawkular-inventory/pulls/53","id":33462394,"html_url":"https://github.com/hawkular/hawkular-inventory/pull/53","diff_url":"https://github.com/hawkular/hawkular-inventory/pull/53.diff","patch_url":"https://github.com/hawkular/hawkular-inventory/pull/53.patch","issue_url":"https://api.github.com/repos/hawkular/hawkular-inventory/issues/53","number":53,"state":"open","locked":false,"title":"HWKINVENT-30 - some REST improvements","user":{"login":"Jiri-Kremser","id":535866,"avatar_url":"https://avatars.githubusercontent.com/u/535866?v=3","gravatar_id":"","url":"https://api.github.com/users/Jiri-Kremser","html_url":"https://github.com/Jiri-Kremser","followers_url":"https://api.github.com/users/Jiri-Kremser/followers","following_url":"https://api.github.com/users/Jiri-Kremser/following{/other_user}","gists_url":"https://api.github.com/users/Jiri-Kremser/gists{/gist_id}","starred_url":"https://api.github.com/users/Jiri-Kremser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jiri-Kremser/subscriptions","organizations_url":"https://api.github.com/users/Jiri-Kremser/orgs","repos_url":"https://api.github.com/users/Jiri-Kremser/repos","events_url":"https://api.github.com/users/Jiri-Kremser/events{/privacy}","received_events_url":"https://api.github.com/users/Jiri-Kremser/received_events","type":"User","site_admin":false},"body":"retrieving a single tenant and retrieving the resources of non-existent resource type now works properly","created_at":"2015-04-16T15:26:44Z","updated_at":"2015-04-16T15:37:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3c7bd5e2a46b6e166c8187446d921fd250635230","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hawkular/hawkular-inventory/pulls/53/commits","review_comments_url":"https://api.github.com/repos/hawkular/hawkular-inventory/pulls/53/comments","review_comment_url":"https://api.github.com/repos/hawkular/hawkular-inventory/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hawkular/hawkular-inventory/issues/53/comments","statuses_url":"https://api.github.com/repos/hawkular/hawkular-inventory/statuses/b4e50e7e0f8e48d7b55f750eac9866325e495322","head":{"label":"Jiri-Kremser:HWKINVENT-30","ref":"HWKINVENT-30","sha":"b4e50e7e0f8e48d7b55f750eac9866325e495322","user":{"login":"Jiri-Kremser","id":535866,"avatar_url":"https://avatars.githubusercontent.com/u/535866?v=3","gravatar_id":"","url":"https://api.github.com/users/Jiri-Kremser","html_url":"https://github.com/Jiri-Kremser","followers_url":"https://api.github.com/users/Jiri-Kremser/followers","following_url":"https://api.github.com/users/Jiri-Kremser/following{/other_user}","gists_url":"https://api.github.com/users/Jiri-Kremser/gists{/gist_id}","starred_url":"https://api.github.com/users/Jiri-Kremser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jiri-Kremser/subscriptions","organizations_url":"https://api.github.com/users/Jiri-Kremser/orgs","repos_url":"https://api.github.com/users/Jiri-Kremser/repos","events_url":"https://api.github.com/users/Jiri-Kremser/events{/privacy}","received_events_url":"https://api.github.com/users/Jiri-Kremser/received_events","type":"User","site_admin":false},"repo":{"id":31206398,"name":"hawkular-inventory","full_name":"Jiri-Kremser/hawkular-inventory","owner":{"login":"Jiri-Kremser","id":535866,"avatar_url":"https://avatars.githubusercontent.com/u/535866?v=3","gravatar_id":"","url":"https://api.github.com/users/Jiri-Kremser","html_url":"https://github.com/Jiri-Kremser","followers_url":"https://api.github.com/users/Jiri-Kremser/followers","following_url":"https://api.github.com/users/Jiri-Kremser/following{/other_user}","gists_url":"https://api.github.com/users/Jiri-Kremser/gists{/gist_id}","starred_url":"https://api.github.com/users/Jiri-Kremser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jiri-Kremser/subscriptions","organizations_url":"https://api.github.com/users/Jiri-Kremser/orgs","repos_url":"https://api.github.com/users/Jiri-Kremser/repos","events_url":"https://api.github.com/users/Jiri-Kremser/events{/privacy}","received_events_url":"https://api.github.com/users/Jiri-Kremser/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Jiri-Kremser/hawkular-inventory","description":"Inventory part of Hawkular - basically a registry for all the things","fork":true,"url":"https://api.github.com/repos/Jiri-Kremser/hawkular-inventory","forks_url":"https://api.github.com/repos/Jiri-Kremser/hawkular-inventory/forks","keys_url":"https://api.github.com/repos/Jiri-Kremser/hawkular-inventory/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Jiri-Kremser/hawkular-inventory/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Jiri-Kremser/hawkular-inventory/teams","hooks_url":"https://api.github.com/repos/Jiri-Kremser/hawkular-inventory/hooks","issue_events_url":"https://api.github.com/repos/Jiri-Kremser/hawkular-inventory/issues/events{/number}","events_url":"https://api.github.com/repos/Jiri-Kremser/hawkular-inventory/events","assignees_url":"https://api.github.com/repos/Jiri-Kremser/hawkular-inventory/assignees{/user}","branches_url":"https://api.github.com/repos/Jiri-Kremser/hawkular-inventory/branches{/branch}","tags_url":"https://api.github.com/repos/Jiri-Kremser/hawkular-inventory/tags","blobs_url":"https://api.github.com/repos/Jiri-Kremser/hawkular-inventory/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Jiri-Kremser/hawkular-inventory/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Jiri-Kremser/hawkular-inventory/git/refs{/sha}","trees_url":"https://api.github.com/repos/Jiri-Kremser/hawkular-inventory/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Jiri-Kremser/hawkular-inventory/statuses/{sha}","languages_url":"https://api.github.com/repos/Jiri-Kremser/hawkular-inventory/languages","stargazers_url":"https://api.github.com/repos/Jiri-Kremser/hawkular-inventory/stargazers","contributors_url":"https://api.github.com/repos/Jiri-Kremser/hawkular-inventory/contributors","subscribers_url":"https://api.github.com/repos/Jiri-Kremser/hawkular-inventory/subscribers","subscription_url":"https://api.github.com/repos/Jiri-Kremser/hawkular-inventory/subscription","commits_url":"https://api.github.com/repos/Jiri-Kremser/hawkular-inventory/commits{/sha}","git_commits_url":"https://api.github.com/repos/Jiri-Kremser/hawkular-inventory/git/commits{/sha}","comments_url":"https://api.github.com/repos/Jiri-Kremser/hawkular-inventory/comments{/number}","issue_comment_url":"https://api.github.com/repos/Jiri-Kremser/hawkular-inventory/issues/comments{/number}","contents_url":"https://api.github.com/repos/Jiri-Kremser/hawkular-inventory/contents/{+path}","compare_url":"https://api.github.com/repos/Jiri-Kremser/hawkular-inventory/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Jiri-Kremser/hawkular-inventory/merges","archive_url":"https://api.github.com/repos/Jiri-Kremser/hawkular-inventory/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Jiri-Kremser/hawkular-inventory/downloads","issues_url":"https://api.github.com/repos/Jiri-Kremser/hawkular-inventory/issues{/number}","pulls_url":"https://api.github.com/repos/Jiri-Kremser/hawkular-inventory/pulls{/number}","milestones_url":"https://api.github.com/repos/Jiri-Kremser/hawkular-inventory/milestones{/number}","notifications_url":"https://api.github.com/repos/Jiri-Kremser/hawkular-inventory/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Jiri-Kremser/hawkular-inventory/labels{/name}","releases_url":"https://api.github.com/repos/Jiri-Kremser/hawkular-inventory/releases{/id}","created_at":"2015-02-23T12:03:05Z","updated_at":"2015-02-23T12:03:05Z","pushed_at":"2015-04-16T15:24:55Z","git_url":"git://github.com/Jiri-Kremser/hawkular-inventory.git","ssh_url":"git@github.com:Jiri-Kremser/hawkular-inventory.git","clone_url":"https://github.com/Jiri-Kremser/hawkular-inventory.git","svn_url":"https://github.com/Jiri-Kremser/hawkular-inventory","homepage":null,"size":708,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hawkular:master","ref":"master","sha":"ec4ed68bb5ad86a25b9592e49786c75fe990e17e","user":{"login":"hawkular","id":10179627,"avatar_url":"https://avatars.githubusercontent.com/u/10179627?v=3","gravatar_id":"","url":"https://api.github.com/users/hawkular","html_url":"https://github.com/hawkular","followers_url":"https://api.github.com/users/hawkular/followers","following_url":"https://api.github.com/users/hawkular/following{/other_user}","gists_url":"https://api.github.com/users/hawkular/gists{/gist_id}","starred_url":"https://api.github.com/users/hawkular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hawkular/subscriptions","organizations_url":"https://api.github.com/users/hawkular/orgs","repos_url":"https://api.github.com/users/hawkular/repos","events_url":"https://api.github.com/users/hawkular/events{/privacy}","received_events_url":"https://api.github.com/users/hawkular/received_events","type":"Organization","site_admin":false},"repo":{"id":29915222,"name":"hawkular-inventory","full_name":"hawkular/hawkular-inventory","owner":{"login":"hawkular","id":10179627,"avatar_url":"https://avatars.githubusercontent.com/u/10179627?v=3","gravatar_id":"","url":"https://api.github.com/users/hawkular","html_url":"https://github.com/hawkular","followers_url":"https://api.github.com/users/hawkular/followers","following_url":"https://api.github.com/users/hawkular/following{/other_user}","gists_url":"https://api.github.com/users/hawkular/gists{/gist_id}","starred_url":"https://api.github.com/users/hawkular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hawkular/subscriptions","organizations_url":"https://api.github.com/users/hawkular/orgs","repos_url":"https://api.github.com/users/hawkular/repos","events_url":"https://api.github.com/users/hawkular/events{/privacy}","received_events_url":"https://api.github.com/users/hawkular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hawkular/hawkular-inventory","description":"Inventory part of Hawkular - basically a registry for all the things","fork":false,"url":"https://api.github.com/repos/hawkular/hawkular-inventory","forks_url":"https://api.github.com/repos/hawkular/hawkular-inventory/forks","keys_url":"https://api.github.com/repos/hawkular/hawkular-inventory/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hawkular/hawkular-inventory/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hawkular/hawkular-inventory/teams","hooks_url":"https://api.github.com/repos/hawkular/hawkular-inventory/hooks","issue_events_url":"https://api.github.com/repos/hawkular/hawkular-inventory/issues/events{/number}","events_url":"https://api.github.com/repos/hawkular/hawkular-inventory/events","assignees_url":"https://api.github.com/repos/hawkular/hawkular-inventory/assignees{/user}","branches_url":"https://api.github.com/repos/hawkular/hawkular-inventory/branches{/branch}","tags_url":"https://api.github.com/repos/hawkular/hawkular-inventory/tags","blobs_url":"https://api.github.com/repos/hawkular/hawkular-inventory/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hawkular/hawkular-inventory/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hawkular/hawkular-inventory/git/refs{/sha}","trees_url":"https://api.github.com/repos/hawkular/hawkular-inventory/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hawkular/hawkular-inventory/statuses/{sha}","languages_url":"https://api.github.com/repos/hawkular/hawkular-inventory/languages","stargazers_url":"https://api.github.com/repos/hawkular/hawkular-inventory/stargazers","contributors_url":"https://api.github.com/repos/hawkular/hawkular-inventory/contributors","subscribers_url":"https://api.github.com/repos/hawkular/hawkular-inventory/subscribers","subscription_url":"https://api.github.com/repos/hawkular/hawkular-inventory/subscription","commits_url":"https://api.github.com/repos/hawkular/hawkular-inventory/commits{/sha}","git_commits_url":"https://api.github.com/repos/hawkular/hawkular-inventory/git/commits{/sha}","comments_url":"https://api.github.com/repos/hawkular/hawkular-inventory/comments{/number}","issue_comment_url":"https://api.github.com/repos/hawkular/hawkular-inventory/issues/comments{/number}","contents_url":"https://api.github.com/repos/hawkular/hawkular-inventory/contents/{+path}","compare_url":"https://api.github.com/repos/hawkular/hawkular-inventory/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hawkular/hawkular-inventory/merges","archive_url":"https://api.github.com/repos/hawkular/hawkular-inventory/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hawkular/hawkular-inventory/downloads","issues_url":"https://api.github.com/repos/hawkular/hawkular-inventory/issues{/number}","pulls_url":"https://api.github.com/repos/hawkular/hawkular-inventory/pulls{/number}","milestones_url":"https://api.github.com/repos/hawkular/hawkular-inventory/milestones{/number}","notifications_url":"https://api.github.com/repos/hawkular/hawkular-inventory/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hawkular/hawkular-inventory/labels{/name}","releases_url":"https://api.github.com/repos/hawkular/hawkular-inventory/releases{/id}","created_at":"2015-01-27T13:27:01Z","updated_at":"2015-04-16T11:04:33Z","pushed_at":"2015-04-16T15:26:44Z","git_url":"git://github.com/hawkular/hawkular-inventory.git","ssh_url":"git@github.com:hawkular/hawkular-inventory.git","clone_url":"https://github.com/hawkular/hawkular-inventory.git","svn_url":"https://github.com/hawkular/hawkular-inventory","homepage":null,"size":1456,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":2,"forks":9,"open_issues":2,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hawkular/hawkular-inventory/pulls/53"},"html":{"href":"https://github.com/hawkular/hawkular-inventory/pull/53"},"issue":{"href":"https://api.github.com/repos/hawkular/hawkular-inventory/issues/53"},"comments":{"href":"https://api.github.com/repos/hawkular/hawkular-inventory/issues/53/comments"},"review_comments":{"href":"https://api.github.com/repos/hawkular/hawkular-inventory/pulls/53/comments"},"review_comment":{"href":"https://api.github.com/repos/hawkular/hawkular-inventory/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hawkular/hawkular-inventory/pulls/53/commits"},"statuses":{"href":"https://api.github.com/repos/hawkular/hawkular-inventory/statuses/b4e50e7e0f8e48d7b55f750eac9866325e495322"}}}}