{"action":"created","issue":{"url":"https://api.github.com/repos/mlalic/solicit/issues/3","labels_url":"https://api.github.com/repos/mlalic/solicit/issues/3/labels{/name}","comments_url":"https://api.github.com/repos/mlalic/solicit/issues/3/comments","events_url":"https://api.github.com/repos/mlalic/solicit/issues/3/events","html_url":"https://github.com/mlalic/solicit/issues/3","id":88173502,"number":3,"title":"SimpleClient::with_connection panics on unwrap","user":{"login":"AKST","id":2638789,"avatar_url":"https://avatars.githubusercontent.com/u/2638789?v=3","gravatar_id":"","url":"https://api.github.com/users/AKST","html_url":"https://github.com/AKST","followers_url":"https://api.github.com/users/AKST/followers","following_url":"https://api.github.com/users/AKST/following{/other_user}","gists_url":"https://api.github.com/users/AKST/gists{/gist_id}","starred_url":"https://api.github.com/users/AKST/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AKST/subscriptions","organizations_url":"https://api.github.com/users/AKST/orgs","repos_url":"https://api.github.com/users/AKST/repos","events_url":"https://api.github.com/users/AKST/events{/privacy}","received_events_url":"https://api.github.com/users/AKST/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-06-14T12:00:26Z","updated_at":"2015-06-14T18:39:34Z","closed_at":null,"body":"[`SimpleClient::with_connection`][1] fails by [unwrap on None][2] instead of just returning an [`HttpError`][3] in a [`HttpResult`][4], this defeats the purpose of the result type. In my situation it could be happening because I'm testing with a server with a self signed certificate which I've done for testing purposes.\r\n\r\nFailing without explicitly specifying this exception is probably a good thing for security reasons, but it would be great if it was an error that didn't panic.\r\n\r\n\r\n[1]: https://mlalic.github.io/solicit/solicit/client/struct.SimpleClient.html#panics\r\n[2]: https://github.com/mlalic/solicit/blob/master/src/client/simple.rs#L140\r\n[3]: https://mlalic.github.io/solicit/solicit/http/enum.HttpError.html\r\n[4]: https://mlalic.github.io/solicit/solicit/http/type.HttpResult.html"},"comment":{"url":"https://api.github.com/repos/mlalic/solicit/issues/comments/111863244","html_url":"https://github.com/mlalic/solicit/issues/3#issuecomment-111863244","issue_url":"https://api.github.com/repos/mlalic/solicit/issues/3","id":111863244,"user":{"login":"mlalic","id":229614,"avatar_url":"https://avatars.githubusercontent.com/u/229614?v=3","gravatar_id":"","url":"https://api.github.com/users/mlalic","html_url":"https://github.com/mlalic","followers_url":"https://api.github.com/users/mlalic/followers","following_url":"https://api.github.com/users/mlalic/following{/other_user}","gists_url":"https://api.github.com/users/mlalic/gists{/gist_id}","starred_url":"https://api.github.com/users/mlalic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlalic/subscriptions","organizations_url":"https://api.github.com/users/mlalic/orgs","repos_url":"https://api.github.com/users/mlalic/repos","events_url":"https://api.github.com/users/mlalic/events{/privacy}","received_events_url":"https://api.github.com/users/mlalic/received_events","type":"User","site_admin":false},"created_at":"2015-06-14T18:39:34Z","updated_at":"2015-06-14T18:39:34Z","body":"Thanks for the report!\r\n\r\nJust to make sure: you mean the `SimpleClient::with_connector`, rather than `SimpleClient::with_connection` -- your links and text are a bit mismatched on that :)\r\n\r\nRegardless, I agree that `with_connector` should not panic."}}