{"action":"created","comment":{"url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/comments/22530057","id":22530057,"diff_hunk":"@@ -897,6 +904,11 @@ public function buildDatagrid()\n         foreach ($this->getExtensions() as $extension) {\n             $extension->configureDatagridFilters($mapper);\n         }\n+\n+        // set template for SimplePager if it's not already overloaded\n+        if ($this->getPagerType() === 'simple' && $this->templates['pager_results'] === 'SonataAdminBundle:Pager:results.html.twig') {","path":"Admin/Admin.php","position":20,"original_position":20,"commit_id":"3008d3a08d4c8a178297005d04fd0effb145e61b","original_commit_id":"3008d3a08d4c8a178297005d04fd0effb145e61b","user":{"login":"pulzarraider","id":960844,"avatar_url":"https://avatars.githubusercontent.com/u/960844?v=3","gravatar_id":"","url":"https://api.github.com/users/pulzarraider","html_url":"https://github.com/pulzarraider","followers_url":"https://api.github.com/users/pulzarraider/followers","following_url":"https://api.github.com/users/pulzarraider/following{/other_user}","gists_url":"https://api.github.com/users/pulzarraider/gists{/gist_id}","starred_url":"https://api.github.com/users/pulzarraider/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pulzarraider/subscriptions","organizations_url":"https://api.github.com/users/pulzarraider/orgs","repos_url":"https://api.github.com/users/pulzarraider/repos","events_url":"https://api.github.com/users/pulzarraider/events{/privacy}","received_events_url":"https://api.github.com/users/pulzarraider/received_events","type":"User","site_admin":false},"body":"On second thought I will try to define this using the dependency injection as the prefered way to changing pager type.\r\n","created_at":"2015-01-06T15:56:28Z","updated_at":"2015-01-06T15:56:28Z","html_url":"https://github.com/sonata-project/SonataAdminBundle/pull/2656#discussion_r22530057","pull_request_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/2656","_links":{"self":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/comments/22530057"},"html":{"href":"https://github.com/sonata-project/SonataAdminBundle/pull/2656#discussion_r22530057"},"pull_request":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/2656"}}},"pull_request":{"url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/2656","id":26643930,"html_url":"https://github.com/sonata-project/SonataAdminBundle/pull/2656","diff_url":"https://github.com/sonata-project/SonataAdminBundle/pull/2656.diff","patch_url":"https://github.com/sonata-project/SonataAdminBundle/pull/2656.patch","issue_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/2656","number":2656,"state":"open","locked":false,"title":"Added SimplePager from SonataDoctrinePhpcrAdminBundle","user":{"login":"pulzarraider","id":960844,"avatar_url":"https://avatars.githubusercontent.com/u/960844?v=3","gravatar_id":"","url":"https://api.github.com/users/pulzarraider","html_url":"https://github.com/pulzarraider","followers_url":"https://api.github.com/users/pulzarraider/followers","following_url":"https://api.github.com/users/pulzarraider/following{/other_user}","gists_url":"https://api.github.com/users/pulzarraider/gists{/gist_id}","starred_url":"https://api.github.com/users/pulzarraider/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pulzarraider/subscriptions","organizations_url":"https://api.github.com/users/pulzarraider/orgs","repos_url":"https://api.github.com/users/pulzarraider/repos","events_url":"https://api.github.com/users/pulzarraider/events{/privacy}","received_events_url":"https://api.github.com/users/pulzarraider/received_events","type":"User","site_admin":false},"body":"Added SimplePager from SonataDoctrinePhpcrAdminBundle to improve performance of large datasets\r\n\r\n| Q             | A\r\n| ------------- | ---\r\n| Bug fix?      | no\r\n| New feature?  | yes\r\n| BC breaks?    | no\r\n| Deprecations? | no\r\n| Tests pass?   | yes\r\n| Fixed tickets | #649, sonata-project/SonataDoctrineORMAdminBundle#297\r\n| License       | MIT\r\n| SonataDoctrineORMAdminBundle PR        | sonata-project/SonataDoctrineORMAdminBundle#415","created_at":"2014-12-29T13:28:11Z","updated_at":"2015-01-06T15:56:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bbf9e9d5e72a2aa0777b07511b5ef7b77d6c0c0f","assignee":{"login":"pulzarraider","id":960844,"avatar_url":"https://avatars.githubusercontent.com/u/960844?v=3","gravatar_id":"","url":"https://api.github.com/users/pulzarraider","html_url":"https://github.com/pulzarraider","followers_url":"https://api.github.com/users/pulzarraider/followers","following_url":"https://api.github.com/users/pulzarraider/following{/other_user}","gists_url":"https://api.github.com/users/pulzarraider/gists{/gist_id}","starred_url":"https://api.github.com/users/pulzarraider/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pulzarraider/subscriptions","organizations_url":"https://api.github.com/users/pulzarraider/orgs","repos_url":"https://api.github.com/users/pulzarraider/repos","events_url":"https://api.github.com/users/pulzarraider/events{/privacy}","received_events_url":"https://api.github.com/users/pulzarraider/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/milestones/3","labels_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/milestones/3/labels","id":917408,"number":3,"title":"2.4","description":"","creator":{"login":"pulzarraider","id":960844,"avatar_url":"https://avatars.githubusercontent.com/u/960844?v=3","gravatar_id":"","url":"https://api.github.com/users/pulzarraider","html_url":"https://github.com/pulzarraider","followers_url":"https://api.github.com/users/pulzarraider/followers","following_url":"https://api.github.com/users/pulzarraider/following{/other_user}","gists_url":"https://api.github.com/users/pulzarraider/gists{/gist_id}","starred_url":"https://api.github.com/users/pulzarraider/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pulzarraider/subscriptions","organizations_url":"https://api.github.com/users/pulzarraider/orgs","repos_url":"https://api.github.com/users/pulzarraider/repos","events_url":"https://api.github.com/users/pulzarraider/events{/privacy}","received_events_url":"https://api.github.com/users/pulzarraider/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":2,"state":"open","created_at":"2014-12-30T06:46:15Z","updated_at":"2015-01-05T14:50:54Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/2656/commits","review_comments_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/2656/comments","review_comment_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/comments/{number}","comments_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/2656/comments","statuses_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/statuses/3008d3a08d4c8a178297005d04fd0effb145e61b","head":{"label":"pulzarraider:simplepager","ref":"simplepager","sha":"3008d3a08d4c8a178297005d04fd0effb145e61b","user":{"login":"pulzarraider","id":960844,"avatar_url":"https://avatars.githubusercontent.com/u/960844?v=3","gravatar_id":"","url":"https://api.github.com/users/pulzarraider","html_url":"https://github.com/pulzarraider","followers_url":"https://api.github.com/users/pulzarraider/followers","following_url":"https://api.github.com/users/pulzarraider/following{/other_user}","gists_url":"https://api.github.com/users/pulzarraider/gists{/gist_id}","starred_url":"https://api.github.com/users/pulzarraider/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pulzarraider/subscriptions","organizations_url":"https://api.github.com/users/pulzarraider/orgs","repos_url":"https://api.github.com/users/pulzarraider/repos","events_url":"https://api.github.com/users/pulzarraider/events{/privacy}","received_events_url":"https://api.github.com/users/pulzarraider/received_events","type":"User","site_admin":false},"repo":{"id":7369272,"name":"SonataAdminBundle","full_name":"pulzarraider/SonataAdminBundle","owner":{"login":"pulzarraider","id":960844,"avatar_url":"https://avatars.githubusercontent.com/u/960844?v=3","gravatar_id":"","url":"https://api.github.com/users/pulzarraider","html_url":"https://github.com/pulzarraider","followers_url":"https://api.github.com/users/pulzarraider/followers","following_url":"https://api.github.com/users/pulzarraider/following{/other_user}","gists_url":"https://api.github.com/users/pulzarraider/gists{/gist_id}","starred_url":"https://api.github.com/users/pulzarraider/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pulzarraider/subscriptions","organizations_url":"https://api.github.com/users/pulzarraider/orgs","repos_url":"https://api.github.com/users/pulzarraider/repos","events_url":"https://api.github.com/users/pulzarraider/events{/privacy}","received_events_url":"https://api.github.com/users/pulzarraider/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pulzarraider/SonataAdminBundle","description":"AdminBundle - The missing Symfony2 Admin Generator","fork":true,"url":"https://api.github.com/repos/pulzarraider/SonataAdminBundle","forks_url":"https://api.github.com/repos/pulzarraider/SonataAdminBundle/forks","keys_url":"https://api.github.com/repos/pulzarraider/SonataAdminBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pulzarraider/SonataAdminBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pulzarraider/SonataAdminBundle/teams","hooks_url":"https://api.github.com/repos/pulzarraider/SonataAdminBundle/hooks","issue_events_url":"https://api.github.com/repos/pulzarraider/SonataAdminBundle/issues/events{/number}","events_url":"https://api.github.com/repos/pulzarraider/SonataAdminBundle/events","assignees_url":"https://api.github.com/repos/pulzarraider/SonataAdminBundle/assignees{/user}","branches_url":"https://api.github.com/repos/pulzarraider/SonataAdminBundle/branches{/branch}","tags_url":"https://api.github.com/repos/pulzarraider/SonataAdminBundle/tags","blobs_url":"https://api.github.com/repos/pulzarraider/SonataAdminBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pulzarraider/SonataAdminBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pulzarraider/SonataAdminBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/pulzarraider/SonataAdminBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pulzarraider/SonataAdminBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/pulzarraider/SonataAdminBundle/languages","stargazers_url":"https://api.github.com/repos/pulzarraider/SonataAdminBundle/stargazers","contributors_url":"https://api.github.com/repos/pulzarraider/SonataAdminBundle/contributors","subscribers_url":"https://api.github.com/repos/pulzarraider/SonataAdminBundle/subscribers","subscription_url":"https://api.github.com/repos/pulzarraider/SonataAdminBundle/subscription","commits_url":"https://api.github.com/repos/pulzarraider/SonataAdminBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/pulzarraider/SonataAdminBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/pulzarraider/SonataAdminBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/pulzarraider/SonataAdminBundle/issues/comments/{number}","contents_url":"https://api.github.com/repos/pulzarraider/SonataAdminBundle/contents/{+path}","compare_url":"https://api.github.com/repos/pulzarraider/SonataAdminBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pulzarraider/SonataAdminBundle/merges","archive_url":"https://api.github.com/repos/pulzarraider/SonataAdminBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pulzarraider/SonataAdminBundle/downloads","issues_url":"https://api.github.com/repos/pulzarraider/SonataAdminBundle/issues{/number}","pulls_url":"https://api.github.com/repos/pulzarraider/SonataAdminBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/pulzarraider/SonataAdminBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/pulzarraider/SonataAdminBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pulzarraider/SonataAdminBundle/labels{/name}","releases_url":"https://api.github.com/repos/pulzarraider/SonataAdminBundle/releases{/id}","created_at":"2012-12-29T18:44:17Z","updated_at":"2015-01-04T13:15:35Z","pushed_at":"2015-01-06T13:47:56Z","git_url":"git://github.com/pulzarraider/SonataAdminBundle.git","ssh_url":"git@github.com:pulzarraider/SonataAdminBundle.git","clone_url":"https://github.com/pulzarraider/SonataAdminBundle.git","svn_url":"https://github.com/pulzarraider/SonataAdminBundle","homepage":"http://sonata-project.org/bundles/admin","size":15237,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sonata-project:master","ref":"master","sha":"24cb39c357e5e056b78d6dce1bdf9f79bb43e2b7","user":{"login":"sonata-project","id":404157,"avatar_url":"https://avatars.githubusercontent.com/u/404157?v=3","gravatar_id":"","url":"https://api.github.com/users/sonata-project","html_url":"https://github.com/sonata-project","followers_url":"https://api.github.com/users/sonata-project/followers","following_url":"https://api.github.com/users/sonata-project/following{/other_user}","gists_url":"https://api.github.com/users/sonata-project/gists{/gist_id}","starred_url":"https://api.github.com/users/sonata-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonata-project/subscriptions","organizations_url":"https://api.github.com/users/sonata-project/orgs","repos_url":"https://api.github.com/users/sonata-project/repos","events_url":"https://api.github.com/users/sonata-project/events{/privacy}","received_events_url":"https://api.github.com/users/sonata-project/received_events","type":"Organization","site_admin":false},"repo":{"id":1095228,"name":"SonataAdminBundle","full_name":"sonata-project/SonataAdminBundle","owner":{"login":"sonata-project","id":404157,"avatar_url":"https://avatars.githubusercontent.com/u/404157?v=3","gravatar_id":"","url":"https://api.github.com/users/sonata-project","html_url":"https://github.com/sonata-project","followers_url":"https://api.github.com/users/sonata-project/followers","following_url":"https://api.github.com/users/sonata-project/following{/other_user}","gists_url":"https://api.github.com/users/sonata-project/gists{/gist_id}","starred_url":"https://api.github.com/users/sonata-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonata-project/subscriptions","organizations_url":"https://api.github.com/users/sonata-project/orgs","repos_url":"https://api.github.com/users/sonata-project/repos","events_url":"https://api.github.com/users/sonata-project/events{/privacy}","received_events_url":"https://api.github.com/users/sonata-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sonata-project/SonataAdminBundle","description":"AdminBundle - The missing Symfony2 Admin Generator","fork":false,"url":"https://api.github.com/repos/sonata-project/SonataAdminBundle","forks_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/forks","keys_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/teams","hooks_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/hooks","issue_events_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/events{/number}","events_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/events","assignees_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/assignees{/user}","branches_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/branches{/branch}","tags_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/tags","blobs_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/languages","stargazers_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/stargazers","contributors_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/contributors","subscribers_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/subscribers","subscription_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/subscription","commits_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/comments/{number}","contents_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/contents/{+path}","compare_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/merges","archive_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/downloads","issues_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues{/number}","pulls_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/labels{/name}","releases_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/releases{/id}","created_at":"2010-11-19T17:08:52Z","updated_at":"2015-01-06T10:19:10Z","pushed_at":"2015-01-06T10:19:10Z","git_url":"git://github.com/sonata-project/SonataAdminBundle.git","ssh_url":"git@github.com:sonata-project/SonataAdminBundle.git","clone_url":"https://github.com/sonata-project/SonataAdminBundle.git","svn_url":"https://github.com/sonata-project/SonataAdminBundle","homepage":"http://sonata-project.org/bundles/admin","size":22297,"stargazers_count":1098,"watchers_count":1098,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":752,"mirror_url":null,"open_issues_count":356,"forks":752,"open_issues":356,"watchers":1098,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/2656"},"html":{"href":"https://github.com/sonata-project/SonataAdminBundle/pull/2656"},"issue":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/2656"},"comments":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/2656/comments"},"review_comments":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/2656/comments"},"review_comment":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/2656/commits"},"statuses":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/statuses/3008d3a08d4c8a178297005d04fd0effb145e61b"}}}}