{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/nodejstools/pulls/comments/41888512","id":41888512,"diff_hunk":"@@ -87,17 +87,19 @@ struct LogItem {\n             int max = MaxItems;\n \n             if (max != 0) {\n-                if (LogItems.Count >= max) {\n-                    while (LogItems.Count > max) {\n-                        // if the queue was set to shrink remove any old items.\n-                        LogItems.PopLeft();\n+                lock (LogItems) {","path":"Nodejs/Product/Analysis/Analysis/AnalysisLog.cs","position":8,"original_position":8,"commit_id":"1107227351bfe2052008413409067f03b28d9057","original_commit_id":"1107227351bfe2052008413409067f03b28d9057","user":{"login":"mousetraps","id":762848,"avatar_url":"https://avatars.githubusercontent.com/u/762848?v=3","gravatar_id":"","url":"https://api.github.com/users/mousetraps","html_url":"https://github.com/mousetraps","followers_url":"https://api.github.com/users/mousetraps/followers","following_url":"https://api.github.com/users/mousetraps/following{/other_user}","gists_url":"https://api.github.com/users/mousetraps/gists{/gist_id}","starred_url":"https://api.github.com/users/mousetraps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mousetraps/subscriptions","organizations_url":"https://api.github.com/users/mousetraps/orgs","repos_url":"https://api.github.com/users/mousetraps/repos","events_url":"https://api.github.com/users/mousetraps/events{/privacy}","received_events_url":"https://api.github.com/users/mousetraps/received_events","type":"User","site_admin":false},"body":"I'll find a way to do this without locking, so it doesn't reduce performance","created_at":"2015-10-13T16:14:15Z","updated_at":"2015-10-13T16:14:15Z","html_url":"https://github.com/Microsoft/nodejstools/pull/524#discussion_r41888512","pull_request_url":"https://api.github.com/repos/Microsoft/nodejstools/pulls/524","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/nodejstools/pulls/comments/41888512"},"html":{"href":"https://github.com/Microsoft/nodejstools/pull/524#discussion_r41888512"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/nodejstools/pulls/524"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/nodejstools/pulls/524","id":47379153,"html_url":"https://github.com/Microsoft/nodejstools/pull/524","diff_url":"https://github.com/Microsoft/nodejstools/pull/524.diff","patch_url":"https://github.com/Microsoft/nodejstools/pull/524.patch","issue_url":"https://api.github.com/repos/Microsoft/nodejstools/issues/524","number":524,"state":"open","locked":false,"title":"#508 Unhandled System.ArgumentException and","user":{"login":"mousetraps","id":762848,"avatar_url":"https://avatars.githubusercontent.com/u/762848?v=3","gravatar_id":"","url":"https://api.github.com/users/mousetraps","html_url":"https://github.com/mousetraps","followers_url":"https://api.github.com/users/mousetraps/followers","following_url":"https://api.github.com/users/mousetraps/following{/other_user}","gists_url":"https://api.github.com/users/mousetraps/gists{/gist_id}","starred_url":"https://api.github.com/users/mousetraps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mousetraps/subscriptions","organizations_url":"https://api.github.com/users/mousetraps/orgs","repos_url":"https://api.github.com/users/mousetraps/repos","events_url":"https://api.github.com/users/mousetraps/events{/privacy}","received_events_url":"https://api.github.com/users/mousetraps/received_events","type":"User","site_admin":false},"body":"System.IndexOutOfRangeException during LoadCachedAnalysis\r\n- We were simultaneously mutating the AnalysisLog from two threads. This\r\n  caused various Deque properties like _data, _tail, etc. to get out of\r\n  sync with one another. The fix is to lock LogItems whenever adding new\r\n  events to the log.\r\n\r\nfix #508","created_at":"2015-10-12T00:21:15Z","updated_at":"2015-10-13T16:14:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"177801474d51c1119f78066c4f318d679a019304","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/nodejstools/pulls/524/commits","review_comments_url":"https://api.github.com/repos/Microsoft/nodejstools/pulls/524/comments","review_comment_url":"https://api.github.com/repos/Microsoft/nodejstools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/nodejstools/issues/524/comments","statuses_url":"https://api.github.com/repos/Microsoft/nodejstools/statuses/1107227351bfe2052008413409067f03b28d9057","head":{"label":"mousetraps:i508","ref":"i508","sha":"1107227351bfe2052008413409067f03b28d9057","user":{"login":"mousetraps","id":762848,"avatar_url":"https://avatars.githubusercontent.com/u/762848?v=3","gravatar_id":"","url":"https://api.github.com/users/mousetraps","html_url":"https://github.com/mousetraps","followers_url":"https://api.github.com/users/mousetraps/followers","following_url":"https://api.github.com/users/mousetraps/following{/other_user}","gists_url":"https://api.github.com/users/mousetraps/gists{/gist_id}","starred_url":"https://api.github.com/users/mousetraps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mousetraps/subscriptions","organizations_url":"https://api.github.com/users/mousetraps/orgs","repos_url":"https://api.github.com/users/mousetraps/repos","events_url":"https://api.github.com/users/mousetraps/events{/privacy}","received_events_url":"https://api.github.com/users/mousetraps/received_events","type":"User","site_admin":false},"repo":{"id":33297642,"name":"nodejstools","full_name":"mousetraps/nodejstools","owner":{"login":"mousetraps","id":762848,"avatar_url":"https://avatars.githubusercontent.com/u/762848?v=3","gravatar_id":"","url":"https://api.github.com/users/mousetraps","html_url":"https://github.com/mousetraps","followers_url":"https://api.github.com/users/mousetraps/followers","following_url":"https://api.github.com/users/mousetraps/following{/other_user}","gists_url":"https://api.github.com/users/mousetraps/gists{/gist_id}","starred_url":"https://api.github.com/users/mousetraps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mousetraps/subscriptions","organizations_url":"https://api.github.com/users/mousetraps/orgs","repos_url":"https://api.github.com/users/mousetraps/repos","events_url":"https://api.github.com/users/mousetraps/events{/privacy}","received_events_url":"https://api.github.com/users/mousetraps/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mousetraps/nodejstools","description":"","fork":true,"url":"https://api.github.com/repos/mousetraps/nodejstools","forks_url":"https://api.github.com/repos/mousetraps/nodejstools/forks","keys_url":"https://api.github.com/repos/mousetraps/nodejstools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mousetraps/nodejstools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mousetraps/nodejstools/teams","hooks_url":"https://api.github.com/repos/mousetraps/nodejstools/hooks","issue_events_url":"https://api.github.com/repos/mousetraps/nodejstools/issues/events{/number}","events_url":"https://api.github.com/repos/mousetraps/nodejstools/events","assignees_url":"https://api.github.com/repos/mousetraps/nodejstools/assignees{/user}","branches_url":"https://api.github.com/repos/mousetraps/nodejstools/branches{/branch}","tags_url":"https://api.github.com/repos/mousetraps/nodejstools/tags","blobs_url":"https://api.github.com/repos/mousetraps/nodejstools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mousetraps/nodejstools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mousetraps/nodejstools/git/refs{/sha}","trees_url":"https://api.github.com/repos/mousetraps/nodejstools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mousetraps/nodejstools/statuses/{sha}","languages_url":"https://api.github.com/repos/mousetraps/nodejstools/languages","stargazers_url":"https://api.github.com/repos/mousetraps/nodejstools/stargazers","contributors_url":"https://api.github.com/repos/mousetraps/nodejstools/contributors","subscribers_url":"https://api.github.com/repos/mousetraps/nodejstools/subscribers","subscription_url":"https://api.github.com/repos/mousetraps/nodejstools/subscription","commits_url":"https://api.github.com/repos/mousetraps/nodejstools/commits{/sha}","git_commits_url":"https://api.github.com/repos/mousetraps/nodejstools/git/commits{/sha}","comments_url":"https://api.github.com/repos/mousetraps/nodejstools/comments{/number}","issue_comment_url":"https://api.github.com/repos/mousetraps/nodejstools/issues/comments{/number}","contents_url":"https://api.github.com/repos/mousetraps/nodejstools/contents/{+path}","compare_url":"https://api.github.com/repos/mousetraps/nodejstools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mousetraps/nodejstools/merges","archive_url":"https://api.github.com/repos/mousetraps/nodejstools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mousetraps/nodejstools/downloads","issues_url":"https://api.github.com/repos/mousetraps/nodejstools/issues{/number}","pulls_url":"https://api.github.com/repos/mousetraps/nodejstools/pulls{/number}","milestones_url":"https://api.github.com/repos/mousetraps/nodejstools/milestones{/number}","notifications_url":"https://api.github.com/repos/mousetraps/nodejstools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mousetraps/nodejstools/labels{/name}","releases_url":"https://api.github.com/repos/mousetraps/nodejstools/releases{/id}","created_at":"2015-04-02T08:18:40Z","updated_at":"2015-05-05T19:02:03Z","pushed_at":"2015-10-12T21:44:20Z","git_url":"git://github.com/mousetraps/nodejstools.git","ssh_url":"git@github.com:mousetraps/nodejstools.git","clone_url":"https://github.com/mousetraps/nodejstools.git","svn_url":"https://github.com/mousetraps/nodejstools","homepage":null,"size":91725,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"fb1e511e040d1be3d7d764ea9a4c7ce0f98eb6e9","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":33017149,"name":"nodejstools","full_name":"Microsoft/nodejstools","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/nodejstools","description":"Node.js Tools for Visual Studio","fork":false,"url":"https://api.github.com/repos/Microsoft/nodejstools","forks_url":"https://api.github.com/repos/Microsoft/nodejstools/forks","keys_url":"https://api.github.com/repos/Microsoft/nodejstools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/nodejstools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/nodejstools/teams","hooks_url":"https://api.github.com/repos/Microsoft/nodejstools/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/nodejstools/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/nodejstools/events","assignees_url":"https://api.github.com/repos/Microsoft/nodejstools/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/nodejstools/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/nodejstools/tags","blobs_url":"https://api.github.com/repos/Microsoft/nodejstools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/nodejstools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/nodejstools/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/nodejstools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/nodejstools/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/nodejstools/languages","stargazers_url":"https://api.github.com/repos/Microsoft/nodejstools/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/nodejstools/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/nodejstools/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/nodejstools/subscription","commits_url":"https://api.github.com/repos/Microsoft/nodejstools/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/nodejstools/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/nodejstools/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/nodejstools/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/nodejstools/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/nodejstools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/nodejstools/merges","archive_url":"https://api.github.com/repos/Microsoft/nodejstools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/nodejstools/downloads","issues_url":"https://api.github.com/repos/Microsoft/nodejstools/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/nodejstools/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/nodejstools/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/nodejstools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/nodejstools/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/nodejstools/releases{/id}","created_at":"2015-03-28T01:37:20Z","updated_at":"2015-10-13T09:11:07Z","pushed_at":"2015-10-12T21:45:41Z","git_url":"git://github.com/Microsoft/nodejstools.git","ssh_url":"git@github.com:Microsoft/nodejstools.git","clone_url":"https://github.com/Microsoft/nodejstools.git","svn_url":"https://github.com/Microsoft/nodejstools","homepage":"http://aka.ms/explorentvs","size":100410,"stargazers_count":753,"watchers_count":753,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":110,"mirror_url":null,"open_issues_count":218,"forks":110,"open_issues":218,"watchers":753,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/nodejstools/pulls/524"},"html":{"href":"https://github.com/Microsoft/nodejstools/pull/524"},"issue":{"href":"https://api.github.com/repos/Microsoft/nodejstools/issues/524"},"comments":{"href":"https://api.github.com/repos/Microsoft/nodejstools/issues/524/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/nodejstools/pulls/524/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/nodejstools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/nodejstools/pulls/524/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/nodejstools/statuses/1107227351bfe2052008413409067f03b28d9057"}}}}