{"action":"closed","number":192,"pull_request":{"url":"https://api.github.com/repos/leapcode/leap_mail/pulls/192","id":41516770,"html_url":"https://github.com/leapcode/leap_mail/pull/192","diff_url":"https://github.com/leapcode/leap_mail/pull/192.diff","patch_url":"https://github.com/leapcode/leap_mail/pull/192.patch","issue_url":"https://api.github.com/repos/leapcode/leap_mail/issues/192","number":192,"state":"closed","locked":false,"title":"Skip instead of fail on not implemented behavior","user":{"login":"bwagnerr","id":332069,"avatar_url":"https://avatars.githubusercontent.com/u/332069?v=3","gravatar_id":"","url":"https://api.github.com/users/bwagnerr","html_url":"https://github.com/bwagnerr","followers_url":"https://api.github.com/users/bwagnerr/followers","following_url":"https://api.github.com/users/bwagnerr/following{/other_user}","gists_url":"https://api.github.com/users/bwagnerr/gists{/gist_id}","starred_url":"https://api.github.com/users/bwagnerr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bwagnerr/subscriptions","organizations_url":"https://api.github.com/users/bwagnerr/orgs","repos_url":"https://api.github.com/users/bwagnerr/repos","events_url":"https://api.github.com/users/bwagnerr/events{/privacy}","received_events_url":"https://api.github.com/users/bwagnerr/received_events","type":"User","site_admin":false},"body":"Hey, I changed the leap mail tests to make sure it skips not implemented behavior instead of calling .fail() . This way you still have a reminder that you have to implement that, but it doesn't break the tests.\r\n\r\nIMAP Mixin was being initialized without handling, but it returns a deferred, the deferred was being collected before it was run, and that was breaking the imap tests (that depended on the result of that deferred). The IMAP fetch tests still need to be fixed because they are outdated and they can't handle callbacks (some of the class methods changed and the part of the test still expects synchronous code)","created_at":"2015-08-03T22:27:23Z","updated_at":"2015-08-04T00:15:00Z","closed_at":"2015-08-04T00:15:00Z","merged_at":"2015-08-04T00:15:00Z","merge_commit_sha":"a4a07d049a68167d075c417f1237691d4cac48a8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/leapcode/leap_mail/pulls/192/commits","review_comments_url":"https://api.github.com/repos/leapcode/leap_mail/pulls/192/comments","review_comment_url":"https://api.github.com/repos/leapcode/leap_mail/pulls/comments{/number}","comments_url":"https://api.github.com/repos/leapcode/leap_mail/issues/192/comments","statuses_url":"https://api.github.com/repos/leapcode/leap_mail/statuses/4777ad0d3ec5378de8b0c7ffbcecf2e19ad9c180","head":{"label":"pixelated:develop","ref":"develop","sha":"4777ad0d3ec5378de8b0c7ffbcecf2e19ad9c180","user":{"login":"pixelated","id":8321323,"avatar_url":"https://avatars.githubusercontent.com/u/8321323?v=3","gravatar_id":"","url":"https://api.github.com/users/pixelated","html_url":"https://github.com/pixelated","followers_url":"https://api.github.com/users/pixelated/followers","following_url":"https://api.github.com/users/pixelated/following{/other_user}","gists_url":"https://api.github.com/users/pixelated/gists{/gist_id}","starred_url":"https://api.github.com/users/pixelated/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pixelated/subscriptions","organizations_url":"https://api.github.com/users/pixelated/orgs","repos_url":"https://api.github.com/users/pixelated/repos","events_url":"https://api.github.com/users/pixelated/events{/privacy}","received_events_url":"https://api.github.com/users/pixelated/received_events","type":"Organization","site_admin":false},"repo":{"id":39256228,"name":"leap_mail","full_name":"pixelated/leap_mail","owner":{"login":"pixelated","id":8321323,"avatar_url":"https://avatars.githubusercontent.com/u/8321323?v=3","gravatar_id":"","url":"https://api.github.com/users/pixelated","html_url":"https://github.com/pixelated","followers_url":"https://api.github.com/users/pixelated/followers","following_url":"https://api.github.com/users/pixelated/following{/other_user}","gists_url":"https://api.github.com/users/pixelated/gists{/gist_id}","starred_url":"https://api.github.com/users/pixelated/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pixelated/subscriptions","organizations_url":"https://api.github.com/users/pixelated/orgs","repos_url":"https://api.github.com/users/pixelated/repos","events_url":"https://api.github.com/users/pixelated/events{/privacy}","received_events_url":"https://api.github.com/users/pixelated/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pixelated/leap_mail","description":"The magick sauce for leap encrypted email!","fork":true,"url":"https://api.github.com/repos/pixelated/leap_mail","forks_url":"https://api.github.com/repos/pixelated/leap_mail/forks","keys_url":"https://api.github.com/repos/pixelated/leap_mail/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pixelated/leap_mail/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pixelated/leap_mail/teams","hooks_url":"https://api.github.com/repos/pixelated/leap_mail/hooks","issue_events_url":"https://api.github.com/repos/pixelated/leap_mail/issues/events{/number}","events_url":"https://api.github.com/repos/pixelated/leap_mail/events","assignees_url":"https://api.github.com/repos/pixelated/leap_mail/assignees{/user}","branches_url":"https://api.github.com/repos/pixelated/leap_mail/branches{/branch}","tags_url":"https://api.github.com/repos/pixelated/leap_mail/tags","blobs_url":"https://api.github.com/repos/pixelated/leap_mail/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pixelated/leap_mail/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pixelated/leap_mail/git/refs{/sha}","trees_url":"https://api.github.com/repos/pixelated/leap_mail/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pixelated/leap_mail/statuses/{sha}","languages_url":"https://api.github.com/repos/pixelated/leap_mail/languages","stargazers_url":"https://api.github.com/repos/pixelated/leap_mail/stargazers","contributors_url":"https://api.github.com/repos/pixelated/leap_mail/contributors","subscribers_url":"https://api.github.com/repos/pixelated/leap_mail/subscribers","subscription_url":"https://api.github.com/repos/pixelated/leap_mail/subscription","commits_url":"https://api.github.com/repos/pixelated/leap_mail/commits{/sha}","git_commits_url":"https://api.github.com/repos/pixelated/leap_mail/git/commits{/sha}","comments_url":"https://api.github.com/repos/pixelated/leap_mail/comments{/number}","issue_comment_url":"https://api.github.com/repos/pixelated/leap_mail/issues/comments{/number}","contents_url":"https://api.github.com/repos/pixelated/leap_mail/contents/{+path}","compare_url":"https://api.github.com/repos/pixelated/leap_mail/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pixelated/leap_mail/merges","archive_url":"https://api.github.com/repos/pixelated/leap_mail/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pixelated/leap_mail/downloads","issues_url":"https://api.github.com/repos/pixelated/leap_mail/issues{/number}","pulls_url":"https://api.github.com/repos/pixelated/leap_mail/pulls{/number}","milestones_url":"https://api.github.com/repos/pixelated/leap_mail/milestones{/number}","notifications_url":"https://api.github.com/repos/pixelated/leap_mail/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pixelated/leap_mail/labels{/name}","releases_url":"https://api.github.com/repos/pixelated/leap_mail/releases{/id}","created_at":"2015-07-17T13:47:12Z","updated_at":"2015-07-17T13:47:12Z","pushed_at":"2015-08-03T22:20:21Z","git_url":"git://github.com/pixelated/leap_mail.git","ssh_url":"git@github.com:pixelated/leap_mail.git","clone_url":"https://github.com/pixelated/leap_mail.git","svn_url":"https://github.com/pixelated/leap_mail","homepage":"","size":1490,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"leapcode:develop","ref":"develop","sha":"34f8a5999ef024a3c1004a5bc9ff62201b4c5faa","user":{"login":"leapcode","id":1700464,"avatar_url":"https://avatars.githubusercontent.com/u/1700464?v=3","gravatar_id":"","url":"https://api.github.com/users/leapcode","html_url":"https://github.com/leapcode","followers_url":"https://api.github.com/users/leapcode/followers","following_url":"https://api.github.com/users/leapcode/following{/other_user}","gists_url":"https://api.github.com/users/leapcode/gists{/gist_id}","starred_url":"https://api.github.com/users/leapcode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leapcode/subscriptions","organizations_url":"https://api.github.com/users/leapcode/orgs","repos_url":"https://api.github.com/users/leapcode/repos","events_url":"https://api.github.com/users/leapcode/events{/privacy}","received_events_url":"https://api.github.com/users/leapcode/received_events","type":"Organization","site_admin":false},"repo":{"id":8909626,"name":"leap_mail","full_name":"leapcode/leap_mail","owner":{"login":"leapcode","id":1700464,"avatar_url":"https://avatars.githubusercontent.com/u/1700464?v=3","gravatar_id":"","url":"https://api.github.com/users/leapcode","html_url":"https://github.com/leapcode","followers_url":"https://api.github.com/users/leapcode/followers","following_url":"https://api.github.com/users/leapcode/following{/other_user}","gists_url":"https://api.github.com/users/leapcode/gists{/gist_id}","starred_url":"https://api.github.com/users/leapcode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leapcode/subscriptions","organizations_url":"https://api.github.com/users/leapcode/orgs","repos_url":"https://api.github.com/users/leapcode/repos","events_url":"https://api.github.com/users/leapcode/events{/privacy}","received_events_url":"https://api.github.com/users/leapcode/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/leapcode/leap_mail","description":"The magick sauce for leap encrypted email!","fork":false,"url":"https://api.github.com/repos/leapcode/leap_mail","forks_url":"https://api.github.com/repos/leapcode/leap_mail/forks","keys_url":"https://api.github.com/repos/leapcode/leap_mail/keys{/key_id}","collaborators_url":"https://api.github.com/repos/leapcode/leap_mail/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/leapcode/leap_mail/teams","hooks_url":"https://api.github.com/repos/leapcode/leap_mail/hooks","issue_events_url":"https://api.github.com/repos/leapcode/leap_mail/issues/events{/number}","events_url":"https://api.github.com/repos/leapcode/leap_mail/events","assignees_url":"https://api.github.com/repos/leapcode/leap_mail/assignees{/user}","branches_url":"https://api.github.com/repos/leapcode/leap_mail/branches{/branch}","tags_url":"https://api.github.com/repos/leapcode/leap_mail/tags","blobs_url":"https://api.github.com/repos/leapcode/leap_mail/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/leapcode/leap_mail/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/leapcode/leap_mail/git/refs{/sha}","trees_url":"https://api.github.com/repos/leapcode/leap_mail/git/trees{/sha}","statuses_url":"https://api.github.com/repos/leapcode/leap_mail/statuses/{sha}","languages_url":"https://api.github.com/repos/leapcode/leap_mail/languages","stargazers_url":"https://api.github.com/repos/leapcode/leap_mail/stargazers","contributors_url":"https://api.github.com/repos/leapcode/leap_mail/contributors","subscribers_url":"https://api.github.com/repos/leapcode/leap_mail/subscribers","subscription_url":"https://api.github.com/repos/leapcode/leap_mail/subscription","commits_url":"https://api.github.com/repos/leapcode/leap_mail/commits{/sha}","git_commits_url":"https://api.github.com/repos/leapcode/leap_mail/git/commits{/sha}","comments_url":"https://api.github.com/repos/leapcode/leap_mail/comments{/number}","issue_comment_url":"https://api.github.com/repos/leapcode/leap_mail/issues/comments{/number}","contents_url":"https://api.github.com/repos/leapcode/leap_mail/contents/{+path}","compare_url":"https://api.github.com/repos/leapcode/leap_mail/compare/{base}...{head}","merges_url":"https://api.github.com/repos/leapcode/leap_mail/merges","archive_url":"https://api.github.com/repos/leapcode/leap_mail/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/leapcode/leap_mail/downloads","issues_url":"https://api.github.com/repos/leapcode/leap_mail/issues{/number}","pulls_url":"https://api.github.com/repos/leapcode/leap_mail/pulls{/number}","milestones_url":"https://api.github.com/repos/leapcode/leap_mail/milestones{/number}","notifications_url":"https://api.github.com/repos/leapcode/leap_mail/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/leapcode/leap_mail/labels{/name}","releases_url":"https://api.github.com/repos/leapcode/leap_mail/releases{/id}","created_at":"2013-03-20T17:00:41Z","updated_at":"2015-07-15T18:26:51Z","pushed_at":"2015-08-04T00:15:00Z","git_url":"git://github.com/leapcode/leap_mail.git","ssh_url":"git@github.com:leapcode/leap_mail.git","clone_url":"https://github.com/leapcode/leap_mail.git","svn_url":"https://github.com/leapcode/leap_mail","homepage":"","size":2768,"stargazers_count":17,"watchers_count":17,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":1,"forks":14,"open_issues":1,"watchers":17,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/leapcode/leap_mail/pulls/192"},"html":{"href":"https://github.com/leapcode/leap_mail/pull/192"},"issue":{"href":"https://api.github.com/repos/leapcode/leap_mail/issues/192"},"comments":{"href":"https://api.github.com/repos/leapcode/leap_mail/issues/192/comments"},"review_comments":{"href":"https://api.github.com/repos/leapcode/leap_mail/pulls/192/comments"},"review_comment":{"href":"https://api.github.com/repos/leapcode/leap_mail/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/leapcode/leap_mail/pulls/192/commits"},"statuses":{"href":"https://api.github.com/repos/leapcode/leap_mail/statuses/4777ad0d3ec5378de8b0c7ffbcecf2e19ad9c180"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"leap-code-o-matic","id":3003406,"avatar_url":"https://avatars.githubusercontent.com/u/3003406?v=3","gravatar_id":"","url":"https://api.github.com/users/leap-code-o-matic","html_url":"https://github.com/leap-code-o-matic","followers_url":"https://api.github.com/users/leap-code-o-matic/followers","following_url":"https://api.github.com/users/leap-code-o-matic/following{/other_user}","gists_url":"https://api.github.com/users/leap-code-o-matic/gists{/gist_id}","starred_url":"https://api.github.com/users/leap-code-o-matic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leap-code-o-matic/subscriptions","organizations_url":"https://api.github.com/users/leap-code-o-matic/orgs","repos_url":"https://api.github.com/users/leap-code-o-matic/repos","events_url":"https://api.github.com/users/leap-code-o-matic/events{/privacy}","received_events_url":"https://api.github.com/users/leap-code-o-matic/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":2,"additions":14,"deletions":5,"changed_files":4}}