{"action":"created","comment":{"url":"https://api.github.com/repos/tawalton/mimic/pulls/comments/37920978","id":37920978,"diff_hunk":"@@ -927,6 +940,67 @@ def request_action(self, http_action_request, server_id, absolutize_url):\n         else:\n             return dumps(bad_request(\"There is no such action currently supported\", http_action_request))\n \n+    def _create_list_of_flavors(self):\n+        \"\"\"\n+        Creates a list of flavors and stores them in the flavors store\n+        \"\"\"\n+        flavors = [StandardFlavor, ComputeFlavor, Performance1Flavor, OnMetalFlavor,\n+                   Performance2Flavor, MemoryFlavor, IOFlavor, GeneralFlavor]","path":"mimic/model/nova_objects.py","position":44,"original_position":44,"commit_id":"de576a92cc659aefeb2041e86f88e01db906122d","original_commit_id":"de576a92cc659aefeb2041e86f88e01db906122d","user":{"login":"tawalton","id":5943782,"avatar_url":"https://avatars.githubusercontent.com/u/5943782?v=3","gravatar_id":"","url":"https://api.github.com/users/tawalton","html_url":"https://github.com/tawalton","followers_url":"https://api.github.com/users/tawalton/followers","following_url":"https://api.github.com/users/tawalton/following{/other_user}","gists_url":"https://api.github.com/users/tawalton/gists{/gist_id}","starred_url":"https://api.github.com/users/tawalton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tawalton/subscriptions","organizations_url":"https://api.github.com/users/tawalton/orgs","repos_url":"https://api.github.com/users/tawalton/repos","events_url":"https://api.github.com/users/tawalton/events{/privacy}","received_events_url":"https://api.github.com/users/tawalton/received_events","type":"User","site_admin":false},"body":"Creating an array of classes and passing them to the _generate_flavors_info method seems clumsy to me.  Any suggestion for a more elegant solution?\r\n@glyph ","created_at":"2015-08-25T21:17:55Z","updated_at":"2015-08-25T21:17:55Z","html_url":"https://github.com/tawalton/mimic/pull/28#discussion_r37920978","pull_request_url":"https://api.github.com/repos/tawalton/mimic/pulls/28","_links":{"self":{"href":"https://api.github.com/repos/tawalton/mimic/pulls/comments/37920978"},"html":{"href":"https://github.com/tawalton/mimic/pull/28#discussion_r37920978"},"pull_request":{"href":"https://api.github.com/repos/tawalton/mimic/pulls/28"}}},"pull_request":{"url":"https://api.github.com/repos/tawalton/mimic/pulls/28","id":43332153,"html_url":"https://github.com/tawalton/mimic/pull/28","diff_url":"https://github.com/tawalton/mimic/pull/28.diff","patch_url":"https://github.com/tawalton/mimic/pull/28.patch","issue_url":"https://api.github.com/repos/tawalton/mimic/issues/28","number":28,"state":"open","locked":false,"title":"Nova flavors","user":{"login":"tawalton","id":5943782,"avatar_url":"https://avatars.githubusercontent.com/u/5943782?v=3","gravatar_id":"","url":"https://api.github.com/users/tawalton","html_url":"https://github.com/tawalton","followers_url":"https://api.github.com/users/tawalton/followers","following_url":"https://api.github.com/users/tawalton/following{/other_user}","gists_url":"https://api.github.com/users/tawalton/gists{/gist_id}","starred_url":"https://api.github.com/users/tawalton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tawalton/subscriptions","organizations_url":"https://api.github.com/users/tawalton/orgs","repos_url":"https://api.github.com/users/tawalton/repos","events_url":"https://api.github.com/users/tawalton/events{/privacy}","received_events_url":"https://api.github.com/users/tawalton/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-08-25T20:25:44Z","updated_at":"2015-08-25T21:17:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0179f2982884947524455ebe08132d784ff67f9a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/tawalton/mimic/pulls/28/commits","review_comments_url":"https://api.github.com/repos/tawalton/mimic/pulls/28/comments","review_comment_url":"https://api.github.com/repos/tawalton/mimic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tawalton/mimic/issues/28/comments","statuses_url":"https://api.github.com/repos/tawalton/mimic/statuses/de576a92cc659aefeb2041e86f88e01db906122d","head":{"label":"tawalton:nova_flavors","ref":"nova_flavors","sha":"de576a92cc659aefeb2041e86f88e01db906122d","user":{"login":"tawalton","id":5943782,"avatar_url":"https://avatars.githubusercontent.com/u/5943782?v=3","gravatar_id":"","url":"https://api.github.com/users/tawalton","html_url":"https://github.com/tawalton","followers_url":"https://api.github.com/users/tawalton/followers","following_url":"https://api.github.com/users/tawalton/following{/other_user}","gists_url":"https://api.github.com/users/tawalton/gists{/gist_id}","starred_url":"https://api.github.com/users/tawalton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tawalton/subscriptions","organizations_url":"https://api.github.com/users/tawalton/orgs","repos_url":"https://api.github.com/users/tawalton/repos","events_url":"https://api.github.com/users/tawalton/events{/privacy}","received_events_url":"https://api.github.com/users/tawalton/received_events","type":"User","site_admin":false},"repo":{"id":40102376,"name":"mimic","full_name":"tawalton/mimic","owner":{"login":"tawalton","id":5943782,"avatar_url":"https://avatars.githubusercontent.com/u/5943782?v=3","gravatar_id":"","url":"https://api.github.com/users/tawalton","html_url":"https://github.com/tawalton","followers_url":"https://api.github.com/users/tawalton/followers","following_url":"https://api.github.com/users/tawalton/following{/other_user}","gists_url":"https://api.github.com/users/tawalton/gists{/gist_id}","starred_url":"https://api.github.com/users/tawalton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tawalton/subscriptions","organizations_url":"https://api.github.com/users/tawalton/orgs","repos_url":"https://api.github.com/users/tawalton/repos","events_url":"https://api.github.com/users/tawalton/events{/privacy}","received_events_url":"https://api.github.com/users/tawalton/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tawalton/mimic","description":"An API mock service","fork":true,"url":"https://api.github.com/repos/tawalton/mimic","forks_url":"https://api.github.com/repos/tawalton/mimic/forks","keys_url":"https://api.github.com/repos/tawalton/mimic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tawalton/mimic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tawalton/mimic/teams","hooks_url":"https://api.github.com/repos/tawalton/mimic/hooks","issue_events_url":"https://api.github.com/repos/tawalton/mimic/issues/events{/number}","events_url":"https://api.github.com/repos/tawalton/mimic/events","assignees_url":"https://api.github.com/repos/tawalton/mimic/assignees{/user}","branches_url":"https://api.github.com/repos/tawalton/mimic/branches{/branch}","tags_url":"https://api.github.com/repos/tawalton/mimic/tags","blobs_url":"https://api.github.com/repos/tawalton/mimic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tawalton/mimic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tawalton/mimic/git/refs{/sha}","trees_url":"https://api.github.com/repos/tawalton/mimic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tawalton/mimic/statuses/{sha}","languages_url":"https://api.github.com/repos/tawalton/mimic/languages","stargazers_url":"https://api.github.com/repos/tawalton/mimic/stargazers","contributors_url":"https://api.github.com/repos/tawalton/mimic/contributors","subscribers_url":"https://api.github.com/repos/tawalton/mimic/subscribers","subscription_url":"https://api.github.com/repos/tawalton/mimic/subscription","commits_url":"https://api.github.com/repos/tawalton/mimic/commits{/sha}","git_commits_url":"https://api.github.com/repos/tawalton/mimic/git/commits{/sha}","comments_url":"https://api.github.com/repos/tawalton/mimic/comments{/number}","issue_comment_url":"https://api.github.com/repos/tawalton/mimic/issues/comments{/number}","contents_url":"https://api.github.com/repos/tawalton/mimic/contents/{+path}","compare_url":"https://api.github.com/repos/tawalton/mimic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tawalton/mimic/merges","archive_url":"https://api.github.com/repos/tawalton/mimic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tawalton/mimic/downloads","issues_url":"https://api.github.com/repos/tawalton/mimic/issues{/number}","pulls_url":"https://api.github.com/repos/tawalton/mimic/pulls{/number}","milestones_url":"https://api.github.com/repos/tawalton/mimic/milestones{/number}","notifications_url":"https://api.github.com/repos/tawalton/mimic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tawalton/mimic/labels{/name}","releases_url":"https://api.github.com/repos/tawalton/mimic/releases{/id}","created_at":"2015-08-03T03:01:56Z","updated_at":"2015-08-03T03:01:59Z","pushed_at":"2015-08-25T21:05:40Z","git_url":"git://github.com/tawalton/mimic.git","ssh_url":"git@github.com:tawalton/mimic.git","clone_url":"https://github.com/tawalton/mimic.git","svn_url":"https://github.com/tawalton/mimic","homepage":"","size":2239,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"base":{"label":"tawalton:master","ref":"master","sha":"e62c3d5f6afd3a9e46960a287c8561e9f47d7e3c","user":{"login":"tawalton","id":5943782,"avatar_url":"https://avatars.githubusercontent.com/u/5943782?v=3","gravatar_id":"","url":"https://api.github.com/users/tawalton","html_url":"https://github.com/tawalton","followers_url":"https://api.github.com/users/tawalton/followers","following_url":"https://api.github.com/users/tawalton/following{/other_user}","gists_url":"https://api.github.com/users/tawalton/gists{/gist_id}","starred_url":"https://api.github.com/users/tawalton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tawalton/subscriptions","organizations_url":"https://api.github.com/users/tawalton/orgs","repos_url":"https://api.github.com/users/tawalton/repos","events_url":"https://api.github.com/users/tawalton/events{/privacy}","received_events_url":"https://api.github.com/users/tawalton/received_events","type":"User","site_admin":false},"repo":{"id":40102376,"name":"mimic","full_name":"tawalton/mimic","owner":{"login":"tawalton","id":5943782,"avatar_url":"https://avatars.githubusercontent.com/u/5943782?v=3","gravatar_id":"","url":"https://api.github.com/users/tawalton","html_url":"https://github.com/tawalton","followers_url":"https://api.github.com/users/tawalton/followers","following_url":"https://api.github.com/users/tawalton/following{/other_user}","gists_url":"https://api.github.com/users/tawalton/gists{/gist_id}","starred_url":"https://api.github.com/users/tawalton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tawalton/subscriptions","organizations_url":"https://api.github.com/users/tawalton/orgs","repos_url":"https://api.github.com/users/tawalton/repos","events_url":"https://api.github.com/users/tawalton/events{/privacy}","received_events_url":"https://api.github.com/users/tawalton/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tawalton/mimic","description":"An API mock service","fork":true,"url":"https://api.github.com/repos/tawalton/mimic","forks_url":"https://api.github.com/repos/tawalton/mimic/forks","keys_url":"https://api.github.com/repos/tawalton/mimic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tawalton/mimic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tawalton/mimic/teams","hooks_url":"https://api.github.com/repos/tawalton/mimic/hooks","issue_events_url":"https://api.github.com/repos/tawalton/mimic/issues/events{/number}","events_url":"https://api.github.com/repos/tawalton/mimic/events","assignees_url":"https://api.github.com/repos/tawalton/mimic/assignees{/user}","branches_url":"https://api.github.com/repos/tawalton/mimic/branches{/branch}","tags_url":"https://api.github.com/repos/tawalton/mimic/tags","blobs_url":"https://api.github.com/repos/tawalton/mimic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tawalton/mimic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tawalton/mimic/git/refs{/sha}","trees_url":"https://api.github.com/repos/tawalton/mimic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tawalton/mimic/statuses/{sha}","languages_url":"https://api.github.com/repos/tawalton/mimic/languages","stargazers_url":"https://api.github.com/repos/tawalton/mimic/stargazers","contributors_url":"https://api.github.com/repos/tawalton/mimic/contributors","subscribers_url":"https://api.github.com/repos/tawalton/mimic/subscribers","subscription_url":"https://api.github.com/repos/tawalton/mimic/subscription","commits_url":"https://api.github.com/repos/tawalton/mimic/commits{/sha}","git_commits_url":"https://api.github.com/repos/tawalton/mimic/git/commits{/sha}","comments_url":"https://api.github.com/repos/tawalton/mimic/comments{/number}","issue_comment_url":"https://api.github.com/repos/tawalton/mimic/issues/comments{/number}","contents_url":"https://api.github.com/repos/tawalton/mimic/contents/{+path}","compare_url":"https://api.github.com/repos/tawalton/mimic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tawalton/mimic/merges","archive_url":"https://api.github.com/repos/tawalton/mimic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tawalton/mimic/downloads","issues_url":"https://api.github.com/repos/tawalton/mimic/issues{/number}","pulls_url":"https://api.github.com/repos/tawalton/mimic/pulls{/number}","milestones_url":"https://api.github.com/repos/tawalton/mimic/milestones{/number}","notifications_url":"https://api.github.com/repos/tawalton/mimic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tawalton/mimic/labels{/name}","releases_url":"https://api.github.com/repos/tawalton/mimic/releases{/id}","created_at":"2015-08-03T03:01:56Z","updated_at":"2015-08-03T03:01:59Z","pushed_at":"2015-08-25T21:05:40Z","git_url":"git://github.com/tawalton/mimic.git","ssh_url":"git@github.com:tawalton/mimic.git","clone_url":"https://github.com/tawalton/mimic.git","svn_url":"https://github.com/tawalton/mimic","homepage":"","size":2239,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tawalton/mimic/pulls/28"},"html":{"href":"https://github.com/tawalton/mimic/pull/28"},"issue":{"href":"https://api.github.com/repos/tawalton/mimic/issues/28"},"comments":{"href":"https://api.github.com/repos/tawalton/mimic/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/tawalton/mimic/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/tawalton/mimic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tawalton/mimic/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/tawalton/mimic/statuses/de576a92cc659aefeb2041e86f88e01db906122d"}}}}