{"action":"created","comment":{"url":"https://api.github.com/repos/cpputest/cpputest/pulls/comments/25681176","id":25681176,"diff_hunk":"@@ -49,16 +49,65 @@ TEST_GROUP(SetPointerPluginTest)\n     }\n };\n \n+class defaultTestBodyUtest : public Utest\n+{\n+public:\n+    void setup() _override \n+    {\n+        CHECK(true);\n+    }\n+    void teardown() _override\n+    {\n+        CHECK(true);\n+    }\n+};\n+\n+class defaultTestBodyUtestUtestShell: public UtestShell\n+{\n+public:\n+   virtual Utest* createTest() _override\n+   {\n+      return new defaultTestBodyUtest();\n+   }\n+};\n+\n+TEST(SetPointerPluginTest, testUnoverridden_testBody)\n+{\n+    defaultTestBodyUtestUtestShell *tst = new defaultTestBodyUtestUtestShell();\n+    ;\n+    myRegistry_->addTest(tst);\n+    myRegistry_->runAllTests(*result_);\n+    LONGS_EQUAL(0, result_->getFailureCount());\n+    LONGS_EQUAL(2, result_->getCheckCount());","path":"tests/SetPluginTest.cpp","position":33,"original_position":33,"commit_id":"23756a07777a44b10fd185b556a2df94c306a0bc","original_commit_id":"23756a07777a44b10fd185b556a2df94c306a0bc","user":{"login":"basvodde","id":509919,"avatar_url":"https://avatars.githubusercontent.com/u/509919?v=3","gravatar_id":"","url":"https://api.github.com/users/basvodde","html_url":"https://github.com/basvodde","followers_url":"https://api.github.com/users/basvodde/followers","following_url":"https://api.github.com/users/basvodde/following{/other_user}","gists_url":"https://api.github.com/users/basvodde/gists{/gist_id}","starred_url":"https://api.github.com/users/basvodde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basvodde/subscriptions","organizations_url":"https://api.github.com/users/basvodde/orgs","repos_url":"https://api.github.com/users/basvodde/repos","events_url":"https://api.github.com/users/basvodde/events{/privacy}","received_events_url":"https://api.github.com/users/basvodde/received_events","type":"User","site_admin":false},"body":"Ah, never mind above question :)","created_at":"2015-03-03T11:54:46Z","updated_at":"2015-03-03T11:54:46Z","html_url":"https://github.com/cpputest/cpputest/pull/489#discussion_r25681176","pull_request_url":"https://api.github.com/repos/cpputest/cpputest/pulls/489","_links":{"self":{"href":"https://api.github.com/repos/cpputest/cpputest/pulls/comments/25681176"},"html":{"href":"https://github.com/cpputest/cpputest/pull/489#discussion_r25681176"},"pull_request":{"href":"https://api.github.com/repos/cpputest/cpputest/pulls/489"}}},"pull_request":{"url":"https://api.github.com/repos/cpputest/cpputest/pulls/489","id":30289629,"html_url":"https://github.com/cpputest/cpputest/pull/489","diff_url":"https://github.com/cpputest/cpputest/pull/489.diff","patch_url":"https://github.com/cpputest/cpputest/pull/489.patch","issue_url":"https://api.github.com/repos/cpputest/cpputest/issues/489","number":489,"state":"open","locked":false,"title":"Coverage","user":{"login":"arstrube","id":4686469,"avatar_url":"https://avatars.githubusercontent.com/u/4686469?v=3","gravatar_id":"","url":"https://api.github.com/users/arstrube","html_url":"https://github.com/arstrube","followers_url":"https://api.github.com/users/arstrube/followers","following_url":"https://api.github.com/users/arstrube/following{/other_user}","gists_url":"https://api.github.com/users/arstrube/gists{/gist_id}","starred_url":"https://api.github.com/users/arstrube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arstrube/subscriptions","organizations_url":"https://api.github.com/users/arstrube/orgs","repos_url":"https://api.github.com/users/arstrube/repos","events_url":"https://api.github.com/users/arstrube/events{/privacy}","received_events_url":"https://api.github.com/users/arstrube/received_events","type":"User","site_admin":false},"body":"Bring up statement coverage to 95+ % by adding missing tests and removing some dead code.\r\n\r\nAnother small improvement will be achieved when I add tests for running tests in a separate process.\r\n\r\nHowever, 100% cannot be reached because of some methods failing unconditionally.\r\n\r\nAlso, defaultCrashMethod cannot be exercised without, well, crashing ;-).","created_at":"2015-03-02T15:01:19Z","updated_at":"2015-03-03T11:54:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"73fdc83007ce169d9794f992317332c928b5ae9a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cpputest/cpputest/pulls/489/commits","review_comments_url":"https://api.github.com/repos/cpputest/cpputest/pulls/489/comments","review_comment_url":"https://api.github.com/repos/cpputest/cpputest/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cpputest/cpputest/issues/489/comments","statuses_url":"https://api.github.com/repos/cpputest/cpputest/statuses/23756a07777a44b10fd185b556a2df94c306a0bc","head":{"label":"arstrube:coverage","ref":"coverage","sha":"23756a07777a44b10fd185b556a2df94c306a0bc","user":{"login":"arstrube","id":4686469,"avatar_url":"https://avatars.githubusercontent.com/u/4686469?v=3","gravatar_id":"","url":"https://api.github.com/users/arstrube","html_url":"https://github.com/arstrube","followers_url":"https://api.github.com/users/arstrube/followers","following_url":"https://api.github.com/users/arstrube/following{/other_user}","gists_url":"https://api.github.com/users/arstrube/gists{/gist_id}","starred_url":"https://api.github.com/users/arstrube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arstrube/subscriptions","organizations_url":"https://api.github.com/users/arstrube/orgs","repos_url":"https://api.github.com/users/arstrube/repos","events_url":"https://api.github.com/users/arstrube/events{/privacy}","received_events_url":"https://api.github.com/users/arstrube/received_events","type":"User","site_admin":false},"repo":{"id":15760766,"name":"cpputest","full_name":"arstrube/cpputest","owner":{"login":"arstrube","id":4686469,"avatar_url":"https://avatars.githubusercontent.com/u/4686469?v=3","gravatar_id":"","url":"https://api.github.com/users/arstrube","html_url":"https://github.com/arstrube","followers_url":"https://api.github.com/users/arstrube/followers","following_url":"https://api.github.com/users/arstrube/following{/other_user}","gists_url":"https://api.github.com/users/arstrube/gists{/gist_id}","starred_url":"https://api.github.com/users/arstrube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arstrube/subscriptions","organizations_url":"https://api.github.com/users/arstrube/orgs","repos_url":"https://api.github.com/users/arstrube/repos","events_url":"https://api.github.com/users/arstrube/events{/privacy}","received_events_url":"https://api.github.com/users/arstrube/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/arstrube/cpputest","description":"CppUTest unit testing and mocking framework for C/C++","fork":true,"url":"https://api.github.com/repos/arstrube/cpputest","forks_url":"https://api.github.com/repos/arstrube/cpputest/forks","keys_url":"https://api.github.com/repos/arstrube/cpputest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arstrube/cpputest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arstrube/cpputest/teams","hooks_url":"https://api.github.com/repos/arstrube/cpputest/hooks","issue_events_url":"https://api.github.com/repos/arstrube/cpputest/issues/events{/number}","events_url":"https://api.github.com/repos/arstrube/cpputest/events","assignees_url":"https://api.github.com/repos/arstrube/cpputest/assignees{/user}","branches_url":"https://api.github.com/repos/arstrube/cpputest/branches{/branch}","tags_url":"https://api.github.com/repos/arstrube/cpputest/tags","blobs_url":"https://api.github.com/repos/arstrube/cpputest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arstrube/cpputest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arstrube/cpputest/git/refs{/sha}","trees_url":"https://api.github.com/repos/arstrube/cpputest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arstrube/cpputest/statuses/{sha}","languages_url":"https://api.github.com/repos/arstrube/cpputest/languages","stargazers_url":"https://api.github.com/repos/arstrube/cpputest/stargazers","contributors_url":"https://api.github.com/repos/arstrube/cpputest/contributors","subscribers_url":"https://api.github.com/repos/arstrube/cpputest/subscribers","subscription_url":"https://api.github.com/repos/arstrube/cpputest/subscription","commits_url":"https://api.github.com/repos/arstrube/cpputest/commits{/sha}","git_commits_url":"https://api.github.com/repos/arstrube/cpputest/git/commits{/sha}","comments_url":"https://api.github.com/repos/arstrube/cpputest/comments{/number}","issue_comment_url":"https://api.github.com/repos/arstrube/cpputest/issues/comments{/number}","contents_url":"https://api.github.com/repos/arstrube/cpputest/contents/{+path}","compare_url":"https://api.github.com/repos/arstrube/cpputest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arstrube/cpputest/merges","archive_url":"https://api.github.com/repos/arstrube/cpputest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arstrube/cpputest/downloads","issues_url":"https://api.github.com/repos/arstrube/cpputest/issues{/number}","pulls_url":"https://api.github.com/repos/arstrube/cpputest/pulls{/number}","milestones_url":"https://api.github.com/repos/arstrube/cpputest/milestones{/number}","notifications_url":"https://api.github.com/repos/arstrube/cpputest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arstrube/cpputest/labels{/name}","releases_url":"https://api.github.com/repos/arstrube/cpputest/releases{/id}","created_at":"2014-01-09T08:22:21Z","updated_at":"2015-02-17T08:12:13Z","pushed_at":"2015-03-03T10:23:07Z","git_url":"git://github.com/arstrube/cpputest.git","ssh_url":"git@github.com:arstrube/cpputest.git","clone_url":"https://github.com/arstrube/cpputest.git","svn_url":"https://github.com/arstrube/cpputest","homepage":"http://cpputest.github.com","size":10280,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cpputest:master","ref":"master","sha":"1345e8a2d6d87c114e07e35ed04f83ecb465027a","user":{"login":"cpputest","id":2120339,"avatar_url":"https://avatars.githubusercontent.com/u/2120339?v=3","gravatar_id":"","url":"https://api.github.com/users/cpputest","html_url":"https://github.com/cpputest","followers_url":"https://api.github.com/users/cpputest/followers","following_url":"https://api.github.com/users/cpputest/following{/other_user}","gists_url":"https://api.github.com/users/cpputest/gists{/gist_id}","starred_url":"https://api.github.com/users/cpputest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpputest/subscriptions","organizations_url":"https://api.github.com/users/cpputest/orgs","repos_url":"https://api.github.com/users/cpputest/repos","events_url":"https://api.github.com/users/cpputest/events{/privacy}","received_events_url":"https://api.github.com/users/cpputest/received_events","type":"Organization","site_admin":false},"repo":{"id":5269602,"name":"cpputest","full_name":"cpputest/cpputest","owner":{"login":"cpputest","id":2120339,"avatar_url":"https://avatars.githubusercontent.com/u/2120339?v=3","gravatar_id":"","url":"https://api.github.com/users/cpputest","html_url":"https://github.com/cpputest","followers_url":"https://api.github.com/users/cpputest/followers","following_url":"https://api.github.com/users/cpputest/following{/other_user}","gists_url":"https://api.github.com/users/cpputest/gists{/gist_id}","starred_url":"https://api.github.com/users/cpputest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpputest/subscriptions","organizations_url":"https://api.github.com/users/cpputest/orgs","repos_url":"https://api.github.com/users/cpputest/repos","events_url":"https://api.github.com/users/cpputest/events{/privacy}","received_events_url":"https://api.github.com/users/cpputest/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cpputest/cpputest","description":"CppUTest unit testing and mocking framework for C/C++","fork":false,"url":"https://api.github.com/repos/cpputest/cpputest","forks_url":"https://api.github.com/repos/cpputest/cpputest/forks","keys_url":"https://api.github.com/repos/cpputest/cpputest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cpputest/cpputest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cpputest/cpputest/teams","hooks_url":"https://api.github.com/repos/cpputest/cpputest/hooks","issue_events_url":"https://api.github.com/repos/cpputest/cpputest/issues/events{/number}","events_url":"https://api.github.com/repos/cpputest/cpputest/events","assignees_url":"https://api.github.com/repos/cpputest/cpputest/assignees{/user}","branches_url":"https://api.github.com/repos/cpputest/cpputest/branches{/branch}","tags_url":"https://api.github.com/repos/cpputest/cpputest/tags","blobs_url":"https://api.github.com/repos/cpputest/cpputest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cpputest/cpputest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cpputest/cpputest/git/refs{/sha}","trees_url":"https://api.github.com/repos/cpputest/cpputest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cpputest/cpputest/statuses/{sha}","languages_url":"https://api.github.com/repos/cpputest/cpputest/languages","stargazers_url":"https://api.github.com/repos/cpputest/cpputest/stargazers","contributors_url":"https://api.github.com/repos/cpputest/cpputest/contributors","subscribers_url":"https://api.github.com/repos/cpputest/cpputest/subscribers","subscription_url":"https://api.github.com/repos/cpputest/cpputest/subscription","commits_url":"https://api.github.com/repos/cpputest/cpputest/commits{/sha}","git_commits_url":"https://api.github.com/repos/cpputest/cpputest/git/commits{/sha}","comments_url":"https://api.github.com/repos/cpputest/cpputest/comments{/number}","issue_comment_url":"https://api.github.com/repos/cpputest/cpputest/issues/comments{/number}","contents_url":"https://api.github.com/repos/cpputest/cpputest/contents/{+path}","compare_url":"https://api.github.com/repos/cpputest/cpputest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cpputest/cpputest/merges","archive_url":"https://api.github.com/repos/cpputest/cpputest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cpputest/cpputest/downloads","issues_url":"https://api.github.com/repos/cpputest/cpputest/issues{/number}","pulls_url":"https://api.github.com/repos/cpputest/cpputest/pulls{/number}","milestones_url":"https://api.github.com/repos/cpputest/cpputest/milestones{/number}","notifications_url":"https://api.github.com/repos/cpputest/cpputest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cpputest/cpputest/labels{/name}","releases_url":"https://api.github.com/repos/cpputest/cpputest/releases{/id}","created_at":"2012-08-02T07:32:25Z","updated_at":"2015-03-01T21:19:29Z","pushed_at":"2015-02-12T12:38:46Z","git_url":"git://github.com/cpputest/cpputest.git","ssh_url":"git@github.com:cpputest/cpputest.git","clone_url":"https://github.com/cpputest/cpputest.git","svn_url":"https://github.com/cpputest/cpputest","homepage":"http://cpputest.github.com","size":11949,"stargazers_count":195,"watchers_count":195,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":105,"mirror_url":null,"open_issues_count":99,"forks":105,"open_issues":99,"watchers":195,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cpputest/cpputest/pulls/489"},"html":{"href":"https://github.com/cpputest/cpputest/pull/489"},"issue":{"href":"https://api.github.com/repos/cpputest/cpputest/issues/489"},"comments":{"href":"https://api.github.com/repos/cpputest/cpputest/issues/489/comments"},"review_comments":{"href":"https://api.github.com/repos/cpputest/cpputest/pulls/489/comments"},"review_comment":{"href":"https://api.github.com/repos/cpputest/cpputest/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cpputest/cpputest/pulls/489/commits"},"statuses":{"href":"https://api.github.com/repos/cpputest/cpputest/statuses/23756a07777a44b10fd185b556a2df94c306a0bc"}}}}