{"action":"created","issue":{"url":"https://api.github.com/repos/sentora/sentora-core/issues/92","labels_url":"https://api.github.com/repos/sentora/sentora-core/issues/92/labels{/name}","comments_url":"https://api.github.com/repos/sentora/sentora-core/issues/92/comments","events_url":"https://api.github.com/repos/sentora/sentora-core/issues/92/events","html_url":"https://github.com/sentora/sentora-core/issues/92","id":50453297,"number":92,"title":"FTP Usernames (and Passwords) unexpectedly and silently truncated","user":{"login":"trs998","id":8804816,"avatar_url":"https://avatars.githubusercontent.com/u/8804816?v=3","gravatar_id":"","url":"https://api.github.com/users/trs998","html_url":"https://github.com/trs998","followers_url":"https://api.github.com/users/trs998/followers","following_url":"https://api.github.com/users/trs998/following{/other_user}","gists_url":"https://api.github.com/users/trs998/gists{/gist_id}","starred_url":"https://api.github.com/users/trs998/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trs998/subscriptions","organizations_url":"https://api.github.com/users/trs998/orgs","repos_url":"https://api.github.com/users/trs998/repos","events_url":"https://api.github.com/users/trs998/events{/privacy}","received_events_url":"https://api.github.com/users/trs998/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2014-11-30T10:12:40Z","updated_at":"2015-01-20T14:43:19Z","closed_at":null,"body":"When a ftp username is entered, the entry is accepted but when inserted into the database the database has a varchar(20) field for both username and password(!) - so truncates the entry. This is quite short, particularly if, for example, the domain name is used.\r\n\r\nSimply changing the FTP username and password fields in the database to varchar(100) would sort this out, and for bonus points restrict the entry on the php side using a maxlength=\"100\" tag on the fields (and php verification so the user knows if for some reason they or their browser ignores that)"},"comment":{"url":"https://api.github.com/repos/sentora/sentora-core/issues/comments/70663339","html_url":"https://github.com/sentora/sentora-core/issues/92#issuecomment-70663339","issue_url":"https://api.github.com/repos/sentora/sentora-core/issues/92","id":70663339,"user":{"login":"trs998","id":8804816,"avatar_url":"https://avatars.githubusercontent.com/u/8804816?v=3","gravatar_id":"","url":"https://api.github.com/users/trs998","html_url":"https://github.com/trs998","followers_url":"https://api.github.com/users/trs998/followers","following_url":"https://api.github.com/users/trs998/following{/other_user}","gists_url":"https://api.github.com/users/trs998/gists{/gist_id}","starred_url":"https://api.github.com/users/trs998/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trs998/subscriptions","organizations_url":"https://api.github.com/users/trs998/orgs","repos_url":"https://api.github.com/users/trs998/repos","events_url":"https://api.github.com/users/trs998/events{/privacy}","received_events_url":"https://api.github.com/users/trs998/received_events","type":"User","site_admin":false},"created_at":"2015-01-20T14:43:19Z","updated_at":"2015-01-20T14:43:19Z","body":"You have a point in terms of ui display - I was thinking in terms of flexibility - why cap it when nothing needs that cap?\r\nHowever, wrapping a username or password is visually confusing so ideally avoided.\r\n\r\nChanging ui and DB limits to 50 sounds like a reasonable compromise. Need to edit form validation to block username and passwords of greater than can be stored in the db - otherwise the user never knows their username or password has been stored incorrectly so it just mysteriously doesn't work."}}