{"action":"created","issue":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/8663","labels_url":"https://api.github.com/repos/cms-sw/cmssw/issues/8663/labels{/name}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/8663/comments","events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/8663/events","html_url":"https://github.com/cms-sw/cmssw/pull/8663","id":66236707,"number":8663,"title":"fix memory leaks in FastTSGFromPropagation","user":{"login":"wmtan","id":4268350,"avatar_url":"https://avatars.githubusercontent.com/u/4268350?v=3","gravatar_id":"","url":"https://api.github.com/users/wmtan","html_url":"https://github.com/wmtan","followers_url":"https://api.github.com/users/wmtan/followers","following_url":"https://api.github.com/users/wmtan/following{/other_user}","gists_url":"https://api.github.com/users/wmtan/gists{/gist_id}","starred_url":"https://api.github.com/users/wmtan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmtan/subscriptions","organizations_url":"https://api.github.com/users/wmtan/orgs","repos_url":"https://api.github.com/users/wmtan/repos","events_url":"https://api.github.com/users/wmtan/events{/privacy}","received_events_url":"https://api.github.com/users/wmtan/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-available","name":"comparison-available","color":"009800"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/fastsim-approved","name":"fastsim-approved","color":"009800"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/fully-signed","name":"fully-signed","color":"009800"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-approved","name":"tests-approved","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/50","html_url":"https://github.com/cms-sw/cmssw/milestones/Next%20CMSSW_7_4_X","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/50/labels","id":875803,"number":50,"title":"Next CMSSW_7_4_X","description":"","creator":{"login":"nclopezo","id":1944922,"avatar_url":"https://avatars.githubusercontent.com/u/1944922?v=3","gravatar_id":"","url":"https://api.github.com/users/nclopezo","html_url":"https://github.com/nclopezo","followers_url":"https://api.github.com/users/nclopezo/followers","following_url":"https://api.github.com/users/nclopezo/following{/other_user}","gists_url":"https://api.github.com/users/nclopezo/gists{/gist_id}","starred_url":"https://api.github.com/users/nclopezo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nclopezo/subscriptions","organizations_url":"https://api.github.com/users/nclopezo/orgs","repos_url":"https://api.github.com/users/nclopezo/repos","events_url":"https://api.github.com/users/nclopezo/events{/privacy}","received_events_url":"https://api.github.com/users/nclopezo/received_events","type":"User","site_admin":false},"open_issues":15,"closed_issues":998,"state":"open","created_at":"2014-11-21T15:23:58Z","updated_at":"2015-04-03T22:05:58Z","due_on":"2015-01-26T08:00:00Z","closed_at":null},"comments":7,"created_at":"2015-04-03T22:03:19Z","updated_at":"2015-04-07T06:51:51Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/8663","html_url":"https://github.com/cms-sw/cmssw/pull/8663","diff_url":"https://github.com/cms-sw/cmssw/pull/8663.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/8663.patch"},"body":"While adding the consumes interface in 7_5_X to class FastTSGFromPropagation, I noticed memory leaks due to allocating products at begin run time (function init()) and not always deleting the previous products first.  These need to be fixed in 7_4_X\r\nRather than deciphering the mess and adding deletes where needed, it was much better and safer just to use smart pointers, rather than bare pointers, for the data members owned by this class.\r\nWhile I was at it, it was much easier and safer also add the consumes interface, so this PR also includes it.\r\nThe justifications are:\r\n1) This class already had the consumes interface partially implemented in 7_4_X.\r\n2) This keeps the files  similar or identical in 7_4_X and 7_5_X.\r\n3) The fixes for the memory leaks touched many more lines of code than those for the consumes interface.\r\n"},"comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments/90402109","html_url":"https://github.com/cms-sw/cmssw/pull/8663#issuecomment-90402109","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/8663","id":90402109,"user":{"login":"cmsbuild","id":4170616,"avatar_url":"https://avatars.githubusercontent.com/u/4170616?v=3","gravatar_id":"","url":"https://api.github.com/users/cmsbuild","html_url":"https://github.com/cmsbuild","followers_url":"https://api.github.com/users/cmsbuild/followers","following_url":"https://api.github.com/users/cmsbuild/following{/other_user}","gists_url":"https://api.github.com/users/cmsbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/cmsbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmsbuild/subscriptions","organizations_url":"https://api.github.com/users/cmsbuild/orgs","repos_url":"https://api.github.com/users/cmsbuild/repos","events_url":"https://api.github.com/users/cmsbuild/events{/privacy}","received_events_url":"https://api.github.com/users/cmsbuild/received_events","type":"User","site_admin":false},"created_at":"2015-04-07T06:51:51Z","updated_at":"2015-04-07T06:51:51Z","body":"This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @degano, @ktf, @smuzaffar"}}