{"action":"created","comment":{"url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS-Editor/pulls/comments/23253862","id":23253862,"diff_hunk":"@@ -1147,18 +1160,27 @@ - (void)alignFull\n - (void)setBold\n {\n     [self.editorView setBold];\n+    if (!self.editorView.isInVisualMode) {","path":"Classes/WPEditorViewController.m","position":28,"original_position":28,"commit_id":"19465793a232a29356528057bab84bf820f63f24","original_commit_id":"19465793a232a29356528057bab84bf820f63f24","user":{"login":"bummytime","id":154014,"avatar_url":"https://avatars.githubusercontent.com/u/154014?v=3","gravatar_id":"","url":"https://api.github.com/users/bummytime","html_url":"https://github.com/bummytime","followers_url":"https://api.github.com/users/bummytime/followers","following_url":"https://api.github.com/users/bummytime/following{/other_user}","gists_url":"https://api.github.com/users/bummytime/gists{/gist_id}","starred_url":"https://api.github.com/users/bummytime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bummytime/subscriptions","organizations_url":"https://api.github.com/users/bummytime/orgs","repos_url":"https://api.github.com/users/bummytime/repos","events_url":"https://api.github.com/users/bummytime/events{/privacy}","received_events_url":"https://api.github.com/users/bummytime/received_events","type":"User","site_admin":false},"body":":+1: ","created_at":"2015-01-20T20:42:24Z","updated_at":"2015-01-20T20:42:24Z","html_url":"https://github.com/wordpress-mobile/WordPress-iOS-Editor/pull/489#discussion_r23253862","pull_request_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS-Editor/pulls/489","_links":{"self":{"href":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS-Editor/pulls/comments/23253862"},"html":{"href":"https://github.com/wordpress-mobile/WordPress-iOS-Editor/pull/489#discussion_r23253862"},"pull_request":{"href":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS-Editor/pulls/489"}}},"pull_request":{"url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS-Editor/pulls/489","id":27706597,"html_url":"https://github.com/wordpress-mobile/WordPress-iOS-Editor/pull/489","diff_url":"https://github.com/wordpress-mobile/WordPress-iOS-Editor/pull/489.diff","patch_url":"https://github.com/wordpress-mobile/WordPress-iOS-Editor/pull/489.patch","issue_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS-Editor/issues/489","number":489,"state":"open","locked":false,"title":"Allow format bar usage in HTML mode","user":{"login":"bummytime","id":154014,"avatar_url":"https://avatars.githubusercontent.com/u/154014?v=3","gravatar_id":"","url":"https://api.github.com/users/bummytime","html_url":"https://github.com/bummytime","followers_url":"https://api.github.com/users/bummytime/followers","following_url":"https://api.github.com/users/bummytime/following{/other_user}","gists_url":"https://api.github.com/users/bummytime/gists{/gist_id}","starred_url":"https://api.github.com/users/bummytime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bummytime/subscriptions","organizations_url":"https://api.github.com/users/bummytime/orgs","repos_url":"https://api.github.com/users/bummytime/repos","events_url":"https://api.github.com/users/bummytime/events{/privacy}","received_events_url":"https://api.github.com/users/bummytime/received_events","type":"User","site_admin":false},"body":"Fixes https://github.com/wordpress-mobile/WordPress-iOS-Editor/issues/155\r\n\r\nThis PR allows the user to use the format bar while in HTML mode in the new editor. It behaves in a similar way as the legacy editor where the format bar buttons simply insert predefined text (vs. toggling it like in visual mode).\r\n\r\nWhat it does do:\r\n1. Insert the appropriate tag at the cursor position when button is pressed\r\n2. Wrap any selected text with the appropriate tags\r\n3. Display the link dialog when inserting a link (and pre-fill the title field in the dialog)\r\n\r\nWhat it doesn't do:\r\n1. Toggle tags on/off\r\n2. Highlight buttons when cursor is inside related tag\r\n3. Insert media while in HTML mode (an alert will show asking the user to switch to Visual mode)\r\n4. Update any existing media \r\n5. Update any existing links \r\n\r\n/cc @diegoreymendez ","created_at":"2015-01-20T19:52:25Z","updated_at":"2015-01-20T20:42:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f93a55c63071094a30c374cc1af206e0cd9d8363","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS-Editor/pulls/489/commits","review_comments_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS-Editor/pulls/489/comments","review_comment_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS-Editor/pulls/comments/{number}","comments_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS-Editor/issues/489/comments","statuses_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS-Editor/statuses/19465793a232a29356528057bab84bf820f63f24","head":{"label":"wordpress-mobile:issue/155-html-toolbar","ref":"issue/155-html-toolbar","sha":"19465793a232a29356528057bab84bf820f63f24","user":{"login":"wordpress-mobile","id":1306301,"avatar_url":"https://avatars.githubusercontent.com/u/1306301?v=3","gravatar_id":"","url":"https://api.github.com/users/wordpress-mobile","html_url":"https://github.com/wordpress-mobile","followers_url":"https://api.github.com/users/wordpress-mobile/followers","following_url":"https://api.github.com/users/wordpress-mobile/following{/other_user}","gists_url":"https://api.github.com/users/wordpress-mobile/gists{/gist_id}","starred_url":"https://api.github.com/users/wordpress-mobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wordpress-mobile/subscriptions","organizations_url":"https://api.github.com/users/wordpress-mobile/orgs","repos_url":"https://api.github.com/users/wordpress-mobile/repos","events_url":"https://api.github.com/users/wordpress-mobile/events{/privacy}","received_events_url":"https://api.github.com/users/wordpress-mobile/received_events","type":"Organization","site_admin":false},"repo":{"id":19703913,"name":"WordPress-iOS-Editor","full_name":"wordpress-mobile/WordPress-iOS-Editor","owner":{"login":"wordpress-mobile","id":1306301,"avatar_url":"https://avatars.githubusercontent.com/u/1306301?v=3","gravatar_id":"","url":"https://api.github.com/users/wordpress-mobile","html_url":"https://github.com/wordpress-mobile","followers_url":"https://api.github.com/users/wordpress-mobile/followers","following_url":"https://api.github.com/users/wordpress-mobile/following{/other_user}","gists_url":"https://api.github.com/users/wordpress-mobile/gists{/gist_id}","starred_url":"https://api.github.com/users/wordpress-mobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wordpress-mobile/subscriptions","organizations_url":"https://api.github.com/users/wordpress-mobile/orgs","repos_url":"https://api.github.com/users/wordpress-mobile/repos","events_url":"https://api.github.com/users/wordpress-mobile/events{/privacy}","received_events_url":"https://api.github.com/users/wordpress-mobile/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wordpress-mobile/WordPress-iOS-Editor","description":"A reusable iOS rich text editor component.","fork":false,"url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS-Editor","forks_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS-Editor/forks","keys_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS-Editor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS-Editor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS-Editor/teams","hooks_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS-Editor/hooks","issue_events_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS-Editor/issues/events{/number}","events_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS-Editor/events","assignees_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS-Editor/assignees{/user}","branches_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS-Editor/branches{/branch}","tags_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS-Editor/tags","blobs_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS-Editor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS-Editor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS-Editor/git/refs{/sha}","trees_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS-Editor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS-Editor/statuses/{sha}","languages_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS-Editor/languages","stargazers_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS-Editor/stargazers","contributors_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS-Editor/contributors","subscribers_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS-Editor/subscribers","subscription_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS-Editor/subscription","commits_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS-Editor/commits{/sha}","git_commits_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS-Editor/git/commits{/sha}","comments_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS-Editor/comments{/number}","issue_comment_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS-Editor/issues/comments/{number}","contents_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS-Editor/contents/{+path}","compare_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS-Editor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS-Editor/merges","archive_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS-Editor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS-Editor/downloads","issues_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS-Editor/issues{/number}","pulls_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS-Editor/pulls{/number}","milestones_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS-Editor/milestones{/number}","notifications_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS-Editor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS-Editor/labels{/name}","releases_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS-Editor/releases{/id}","created_at":"2014-05-12T15:22:29Z","updated_at":"2015-01-15T22:22:10Z","pushed_at":"2015-01-20T20:39:44Z","git_url":"git://github.com/wordpress-mobile/WordPress-iOS-Editor.git","ssh_url":"git@github.com:wordpress-mobile/WordPress-iOS-Editor.git","clone_url":"https://github.com/wordpress-mobile/WordPress-iOS-Editor.git","svn_url":"https://github.com/wordpress-mobile/WordPress-iOS-Editor","homepage":"","size":7196,"stargazers_count":152,"watchers_count":152,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":133,"forks":14,"open_issues":133,"watchers":152,"default_branch":"develop"}},"base":{"label":"wordpress-mobile:release/0.4","ref":"release/0.4","sha":"01859592e6e2faafd2fa3ac1c909c59d9e908ccd","user":{"login":"wordpress-mobile","id":1306301,"avatar_url":"https://avatars.githubusercontent.com/u/1306301?v=3","gravatar_id":"","url":"https://api.github.com/users/wordpress-mobile","html_url":"https://github.com/wordpress-mobile","followers_url":"https://api.github.com/users/wordpress-mobile/followers","following_url":"https://api.github.com/users/wordpress-mobile/following{/other_user}","gists_url":"https://api.github.com/users/wordpress-mobile/gists{/gist_id}","starred_url":"https://api.github.com/users/wordpress-mobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wordpress-mobile/subscriptions","organizations_url":"https://api.github.com/users/wordpress-mobile/orgs","repos_url":"https://api.github.com/users/wordpress-mobile/repos","events_url":"https://api.github.com/users/wordpress-mobile/events{/privacy}","received_events_url":"https://api.github.com/users/wordpress-mobile/received_events","type":"Organization","site_admin":false},"repo":{"id":19703913,"name":"WordPress-iOS-Editor","full_name":"wordpress-mobile/WordPress-iOS-Editor","owner":{"login":"wordpress-mobile","id":1306301,"avatar_url":"https://avatars.githubusercontent.com/u/1306301?v=3","gravatar_id":"","url":"https://api.github.com/users/wordpress-mobile","html_url":"https://github.com/wordpress-mobile","followers_url":"https://api.github.com/users/wordpress-mobile/followers","following_url":"https://api.github.com/users/wordpress-mobile/following{/other_user}","gists_url":"https://api.github.com/users/wordpress-mobile/gists{/gist_id}","starred_url":"https://api.github.com/users/wordpress-mobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wordpress-mobile/subscriptions","organizations_url":"https://api.github.com/users/wordpress-mobile/orgs","repos_url":"https://api.github.com/users/wordpress-mobile/repos","events_url":"https://api.github.com/users/wordpress-mobile/events{/privacy}","received_events_url":"https://api.github.com/users/wordpress-mobile/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wordpress-mobile/WordPress-iOS-Editor","description":"A reusable iOS rich text editor component.","fork":false,"url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS-Editor","forks_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS-Editor/forks","keys_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS-Editor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS-Editor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS-Editor/teams","hooks_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS-Editor/hooks","issue_events_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS-Editor/issues/events{/number}","events_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS-Editor/events","assignees_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS-Editor/assignees{/user}","branches_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS-Editor/branches{/branch}","tags_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS-Editor/tags","blobs_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS-Editor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS-Editor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS-Editor/git/refs{/sha}","trees_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS-Editor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS-Editor/statuses/{sha}","languages_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS-Editor/languages","stargazers_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS-Editor/stargazers","contributors_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS-Editor/contributors","subscribers_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS-Editor/subscribers","subscription_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS-Editor/subscription","commits_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS-Editor/commits{/sha}","git_commits_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS-Editor/git/commits{/sha}","comments_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS-Editor/comments{/number}","issue_comment_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS-Editor/issues/comments/{number}","contents_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS-Editor/contents/{+path}","compare_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS-Editor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS-Editor/merges","archive_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS-Editor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS-Editor/downloads","issues_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS-Editor/issues{/number}","pulls_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS-Editor/pulls{/number}","milestones_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS-Editor/milestones{/number}","notifications_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS-Editor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS-Editor/labels{/name}","releases_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS-Editor/releases{/id}","created_at":"2014-05-12T15:22:29Z","updated_at":"2015-01-15T22:22:10Z","pushed_at":"2015-01-20T20:39:44Z","git_url":"git://github.com/wordpress-mobile/WordPress-iOS-Editor.git","ssh_url":"git@github.com:wordpress-mobile/WordPress-iOS-Editor.git","clone_url":"https://github.com/wordpress-mobile/WordPress-iOS-Editor.git","svn_url":"https://github.com/wordpress-mobile/WordPress-iOS-Editor","homepage":"","size":7196,"stargazers_count":152,"watchers_count":152,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":133,"forks":14,"open_issues":133,"watchers":152,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS-Editor/pulls/489"},"html":{"href":"https://github.com/wordpress-mobile/WordPress-iOS-Editor/pull/489"},"issue":{"href":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS-Editor/issues/489"},"comments":{"href":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS-Editor/issues/489/comments"},"review_comments":{"href":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS-Editor/pulls/489/comments"},"review_comment":{"href":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS-Editor/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS-Editor/pulls/489/commits"},"statuses":{"href":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS-Editor/statuses/19465793a232a29356528057bab84bf820f63f24"}}}}