{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/41466714","id":41466714,"diff_hunk":"@@ -118,23 +118,21 @@ internal static int Encrypt(SafeSslHandle context, IntPtr buffer, int offset, in\n                         break;\n \n                     default:\n-                        throw CreateSslException(\"OpenSsl::Encrypt failed\");\n+                        throw CreateSslException(SR.net_ssl_encrypt_failed, errorCode);\n                 }\n             }\n             else\n             {\n-                int capacityNeeded = libssl.BIO_ctrl_pending(context.OutputBio);      \n+                int capacityNeeded = libssl.BIO_ctrl_pending(context.OutputBio);\n \n-                if (capacityNeeded > bufferCapacity)\n-                {\n-                    throw CreateSslException(\"OpenSsl::Encrypt capacity needed is more than buffer capacity. capacityNeeded = \" + capacityNeeded + \",\" + \"bufferCapacity = \" + bufferCapacity);\n-                }             \n+                Debug.Assert(bufferCapacity >= capacityNeeded, \"Input buffer of size \" + bufferCapacity +\n+                                                              \" bytes is insufficient since encryption needs \" + capacityNeeded + \" bytes.\");","path":"src/Common/src/Interop/Unix/libssl/Interop.OpenSsl.cs","position":72,"original_position":56,"commit_id":"aef6a036a38a8cf46c954f89f948aec1dc5acea9","original_commit_id":"33eb896746d903116c914deed0f22628fa962e4d","user":{"login":"stephentoub","id":2642209,"avatar_url":"https://avatars.githubusercontent.com/u/2642209?v=3","gravatar_id":"","url":"https://api.github.com/users/stephentoub","html_url":"https://github.com/stephentoub","followers_url":"https://api.github.com/users/stephentoub/followers","following_url":"https://api.github.com/users/stephentoub/following{/other_user}","gists_url":"https://api.github.com/users/stephentoub/gists{/gist_id}","starred_url":"https://api.github.com/users/stephentoub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephentoub/subscriptions","organizations_url":"https://api.github.com/users/stephentoub/orgs","repos_url":"https://api.github.com/users/stephentoub/repos","events_url":"https://api.github.com/users/stephentoub/events{/privacy}","received_events_url":"https://api.github.com/users/stephentoub/received_events","type":"User","site_admin":false},"body":"Ok, thanks.","created_at":"2015-10-08T00:59:07Z","updated_at":"2015-10-08T00:59:07Z","html_url":"https://github.com/dotnet/corefx/pull/3696#discussion_r41466714","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/3696","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/41466714"},"html":{"href":"https://github.com/dotnet/corefx/pull/3696#discussion_r41466714"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/3696"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/3696","id":47055992,"html_url":"https://github.com/dotnet/corefx/pull/3696","diff_url":"https://github.com/dotnet/corefx/pull/3696.diff","patch_url":"https://github.com/dotnet/corefx/pull/3696.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/3696","number":3696,"state":"open","locked":false,"title":"Added exception messages to *.resx file. using Debug.Fail wherever ap…","user":{"login":"rajansingh10","id":13608570,"avatar_url":"https://avatars.githubusercontent.com/u/13608570?v=3","gravatar_id":"","url":"https://api.github.com/users/rajansingh10","html_url":"https://github.com/rajansingh10","followers_url":"https://api.github.com/users/rajansingh10/followers","following_url":"https://api.github.com/users/rajansingh10/following{/other_user}","gists_url":"https://api.github.com/users/rajansingh10/gists{/gist_id}","starred_url":"https://api.github.com/users/rajansingh10/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rajansingh10/subscriptions","organizations_url":"https://api.github.com/users/rajansingh10/orgs","repos_url":"https://api.github.com/users/rajansingh10/repos","events_url":"https://api.github.com/users/rajansingh10/events{/privacy}","received_events_url":"https://api.github.com/users/rajansingh10/received_events","type":"User","site_admin":false},"body":"1. Added exception messages to *.resx. Using the SR now.\r\n2. using Debug.Fail/Assert wherever deemed fit.\r\n3. Fixed GetException() method.\r\n","created_at":"2015-10-07T17:20:05Z","updated_at":"2015-10-08T00:59:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"40f4d104537ad8bd909ac5e25721fd6dced06a45","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/3696/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/3696/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/3696/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/aef6a036a38a8cf46c954f89f948aec1dc5acea9","head":{"label":"rajansingh10:Netfeature","ref":"Netfeature","sha":"aef6a036a38a8cf46c954f89f948aec1dc5acea9","user":{"login":"rajansingh10","id":13608570,"avatar_url":"https://avatars.githubusercontent.com/u/13608570?v=3","gravatar_id":"","url":"https://api.github.com/users/rajansingh10","html_url":"https://github.com/rajansingh10","followers_url":"https://api.github.com/users/rajansingh10/followers","following_url":"https://api.github.com/users/rajansingh10/following{/other_user}","gists_url":"https://api.github.com/users/rajansingh10/gists{/gist_id}","starred_url":"https://api.github.com/users/rajansingh10/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rajansingh10/subscriptions","organizations_url":"https://api.github.com/users/rajansingh10/orgs","repos_url":"https://api.github.com/users/rajansingh10/repos","events_url":"https://api.github.com/users/rajansingh10/events{/privacy}","received_events_url":"https://api.github.com/users/rajansingh10/received_events","type":"User","site_admin":false},"repo":{"id":40076943,"name":"corefx","full_name":"rajansingh10/corefx","owner":{"login":"rajansingh10","id":13608570,"avatar_url":"https://avatars.githubusercontent.com/u/13608570?v=3","gravatar_id":"","url":"https://api.github.com/users/rajansingh10","html_url":"https://github.com/rajansingh10","followers_url":"https://api.github.com/users/rajansingh10/followers","following_url":"https://api.github.com/users/rajansingh10/following{/other_user}","gists_url":"https://api.github.com/users/rajansingh10/gists{/gist_id}","starred_url":"https://api.github.com/users/rajansingh10/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rajansingh10/subscriptions","organizations_url":"https://api.github.com/users/rajansingh10/orgs","repos_url":"https://api.github.com/users/rajansingh10/repos","events_url":"https://api.github.com/users/rajansingh10/events{/privacy}","received_events_url":"https://api.github.com/users/rajansingh10/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rajansingh10/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":true,"url":"https://api.github.com/repos/rajansingh10/corefx","forks_url":"https://api.github.com/repos/rajansingh10/corefx/forks","keys_url":"https://api.github.com/repos/rajansingh10/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rajansingh10/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rajansingh10/corefx/teams","hooks_url":"https://api.github.com/repos/rajansingh10/corefx/hooks","issue_events_url":"https://api.github.com/repos/rajansingh10/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/rajansingh10/corefx/events","assignees_url":"https://api.github.com/repos/rajansingh10/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/rajansingh10/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/rajansingh10/corefx/tags","blobs_url":"https://api.github.com/repos/rajansingh10/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rajansingh10/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rajansingh10/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/rajansingh10/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rajansingh10/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/rajansingh10/corefx/languages","stargazers_url":"https://api.github.com/repos/rajansingh10/corefx/stargazers","contributors_url":"https://api.github.com/repos/rajansingh10/corefx/contributors","subscribers_url":"https://api.github.com/repos/rajansingh10/corefx/subscribers","subscription_url":"https://api.github.com/repos/rajansingh10/corefx/subscription","commits_url":"https://api.github.com/repos/rajansingh10/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/rajansingh10/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/rajansingh10/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/rajansingh10/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/rajansingh10/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/rajansingh10/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rajansingh10/corefx/merges","archive_url":"https://api.github.com/repos/rajansingh10/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rajansingh10/corefx/downloads","issues_url":"https://api.github.com/repos/rajansingh10/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/rajansingh10/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/rajansingh10/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/rajansingh10/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rajansingh10/corefx/labels{/name}","releases_url":"https://api.github.com/repos/rajansingh10/corefx/releases{/id}","created_at":"2015-08-02T11:08:04Z","updated_at":"2015-08-02T11:08:22Z","pushed_at":"2015-10-07T19:11:54Z","git_url":"git://github.com/rajansingh10/corefx.git","ssh_url":"git@github.com:rajansingh10/corefx.git","clone_url":"https://github.com/rajansingh10/corefx.git","svn_url":"https://github.com/rajansingh10/corefx","homepage":"http://dotnet.github.io/core/","size":34673,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"2d368892638bdd97dd06fe20a10d4bc5a7c6afc6","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","created_at":"2014-11-06T23:42:48Z","updated_at":"2015-10-07T22:47:55Z","pushed_at":"2015-10-08T00:53:29Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"http://dotnet.github.io/core/","size":76593,"stargazers_count":8422,"watchers_count":8422,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1841,"mirror_url":null,"open_issues_count":646,"forks":1841,"open_issues":646,"watchers":8422,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/3696"},"html":{"href":"https://github.com/dotnet/corefx/pull/3696"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/3696"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/3696/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/3696/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/3696/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/aef6a036a38a8cf46c954f89f948aec1dc5acea9"}}}}