{"push_id":877436755,"size":501,"distinct_size":0,"ref":"refs/heads/deployed-to-staging","head":"71253f6c11c679229f0f967ea794580a33709c40","before":"f60052e23c91bd95646bbeec5e06235e075aeb10","commits":[{"sha":"0ef8a823aad1e43e04fbbbc0346d8349dbf4604a","author":{"email":"474ba67bdb289c6263b36dfd8a7bed6c85b04943@floehopper.org","name":"James Mead"},"message":"Extract SmartAnswersControllerSampleFlow class","distinct":false,"url":"https://api.github.com/repos/alphagov/smart-answers/commits/0ef8a823aad1e43e04fbbbc0346d8349dbf4604a"},{"sha":"f1c65f3d2e03733731e3fbbf32da19550fb7757c","author":{"email":"474ba67bdb289c6263b36dfd8a7bed6c85b04943@floehopper.org","name":"James Mead"},"message":"Remove unnecessary i18n setup in controller test\n\nThis fixture file has already been added as a translation file in the main\nsetup block.","distinct":false,"url":"https://api.github.com/repos/alphagov/smart-answers/commits/f1c65f3d2e03733731e3fbbf32da19550fb7757c"},{"sha":"2cd76157d7f8232e3df6294aac2fb828d94b20ff","author":{"email":"474ba67bdb289c6263b36dfd8a7bed6c85b04943@floehopper.org","name":"James Mead"},"message":"Extract methods into SmartAnswersControllerTestHelper\n\nI want to split up `SmartAnswersControllerTest` and this will make that easier.","distinct":false,"url":"https://api.github.com/repos/alphagov/smart-answers/commits/2cd76157d7f8232e3df6294aac2fb828d94b20ff"},{"sha":"d343723ca0de7f7f169c08c954da228514316a36","author":{"email":"474ba67bdb289c6263b36dfd8a7bed6c85b04943@floehopper.org","name":"James Mead"},"message":"Extract SmartAnswersControllerDateQuestionTest","distinct":false,"url":"https://api.github.com/repos/alphagov/smart-answers/commits/d343723ca0de7f7f169c08c954da228514316a36"},{"sha":"65664fcab3cd806ced9b2cfee3aaa1f3969f6997","author":{"email":"474ba67bdb289c6263b36dfd8a7bed6c85b04943@floehopper.org","name":"James Mead"},"message":"Extract SmartAnswersControllerValueQuestionTest","distinct":false,"url":"https://api.github.com/repos/alphagov/smart-answers/commits/65664fcab3cd806ced9b2cfee3aaa1f3969f6997"},{"sha":"515926046d2817068ef82e6cb4a8490d1e1a17db","author":{"email":"474ba67bdb289c6263b36dfd8a7bed6c85b04943@floehopper.org","name":"James Mead"},"message":"Extract SmartAnswersControllerMoneyQuestionTest","distinct":false,"url":"https://api.github.com/repos/alphagov/smart-answers/commits/515926046d2817068ef82e6cb4a8490d1e1a17db"},{"sha":"fdba96c5f0ab1c80fe0934318008cfef71feaca9","author":{"email":"474ba67bdb289c6263b36dfd8a7bed6c85b04943@floehopper.org","name":"James Mead"},"message":"Extract SmartAnswersControllerSalaryQuestionTest","distinct":false,"url":"https://api.github.com/repos/alphagov/smart-answers/commits/fdba96c5f0ab1c80fe0934318008cfef71feaca9"},{"sha":"c28ddce40cd64d26ae14d9386cf37dfe1de6de40","author":{"email":"474ba67bdb289c6263b36dfd8a7bed6c85b04943@floehopper.org","name":"James Mead"},"message":"Extract SmartAnswersControllerMultipleChoiceQuestionTest","distinct":false,"url":"https://api.github.com/repos/alphagov/smart-answers/commits/c28ddce40cd64d26ae14d9386cf37dfe1de6de40"},{"sha":"2381521039d2a39205bb52e5f398707113f9dc02","author":{"email":"474ba67bdb289c6263b36dfd8a7bed6c85b04943@floehopper.org","name":"James Mead"},"message":"Extract SmartAnswersControllerSampleWithDateQuestionFlow\n\nDefine an explicit flow class just for this test case to avoid sharing setup\nwith other tests i.e. make this test less brittle at the expense of more\nverbosity.\n\nNote that although it wasn't strictly necessary for this commit (because of the\n`SmartAnswer::FlowRegistry.find`), I've changed the `id` parameter for all\nrequests to match the name of the new flow. In order to do this, I also had to\noverride `SmartAnswersControllerTestHelper#submit_response` and\n`#submit_json_response`.","distinct":false,"url":"https://api.github.com/repos/alphagov/smart-answers/commits/2381521039d2a39205bb52e5f398707113f9dc02"},{"sha":"0642a0ffdde4ab567607d849d867813d6d4dddae","author":{"email":"474ba67bdb289c6263b36dfd8a7bed6c85b04943@floehopper.org","name":"James Mead"},"message":"Extract SmartAnswersControllerSampleWithValueQuestionFlow\n\nDefine an explicit flow class just for this test case to avoid sharing setup\nwith other tests i.e. make this test less brittle at the expense of more\nverbosity.\n\nNote that although it wasn't strictly necessary for this commit (because of the\n`SmartAnswer::FlowRegistry.find`), I've changed the `id` parameter for all\nrequests to match the name of the new flow. In order to do this, I also had to\noverride `SmartAnswersControllerTestHelper#submit_response` and\n`#submit_json_response`.","distinct":false,"url":"https://api.github.com/repos/alphagov/smart-answers/commits/0642a0ffdde4ab567607d849d867813d6d4dddae"},{"sha":"732161859da26ff0b31af3ce7bcbb8f681b283f0","author":{"email":"474ba67bdb289c6263b36dfd8a7bed6c85b04943@floehopper.org","name":"James Mead"},"message":"Extract SmartAnswersControllerSampleWithMoneyQuestionFlow\n\nDefine an explicit flow class just for this test case to avoid sharing setup\nwith other tests i.e. make this test less brittle at the expense of more\nverbosity.\n\nNote that although it wasn't strictly necessary for this commit (because of the\n`SmartAnswer::FlowRegistry.find`), I've changed the `id` parameter for all\nrequests to match the name of the new flow. In order to do this, I also had to\noverride `SmartAnswersControllerTestHelper#submit_response` and\n`#submit_json_response`.","distinct":false,"url":"https://api.github.com/repos/alphagov/smart-answers/commits/732161859da26ff0b31af3ce7bcbb8f681b283f0"},{"sha":"6a0f38a60bb38fddf6368f80cabd0171e0257d39","author":{"email":"474ba67bdb289c6263b36dfd8a7bed6c85b04943@floehopper.org","name":"James Mead"},"message":"Extract SmartAnswersControllerSampleWithSalaryQuestionFlow\n\nDefine an explicit flow class just for this test case to avoid sharing setup\nwith other tests i.e. make this test less brittle at the expense of more\nverbosity.\n\nNote that although it wasn't strictly necessary for this commit (because of the\n`SmartAnswer::FlowRegistry.find`), I've changed the `id` parameter for all\nrequests to match the name of the new flow. In order to do this, I also had to\noverride `SmartAnswersControllerTestHelper#submit_response` and\n`#submit_json_response`.","distinct":false,"url":"https://api.github.com/repos/alphagov/smart-answers/commits/6a0f38a60bb38fddf6368f80cabd0171e0257d39"},{"sha":"256fb72b8f45129fff88ffebe0d9ace4dd1ecc8a","author":{"email":"474ba67bdb289c6263b36dfd8a7bed6c85b04943@floehopper.org","name":"James Mead"},"message":"Extract SmartAnswersControllerSampleWithMultipleChoiceQuestionFlow\n\nDefine an explicit flow class just for this test case to avoid sharing setup\nwith other tests i.e. make this test less brittle at the expense of more\nverbosity.\n\nNote that although it wasn't strictly necessary for this commit (because of the\n`SmartAnswer::FlowRegistry.find`), I've changed the `id` parameter for all\nrequests to match the name of the new flow. In order to do this, I also had to\noverride `SmartAnswersControllerTestHelper#submit_response` and\n`#submit_json_response`.","distinct":false,"url":"https://api.github.com/repos/alphagov/smart-answers/commits/256fb72b8f45129fff88ffebe0d9ace4dd1ecc8a"},{"sha":"19d28a260720a72bd83f6c307e605f28156d7790","author":{"email":"474ba67bdb289c6263b36dfd8a7bed6c85b04943@floehopper.org","name":"James Mead"},"message":"Remove unused fixture files","distinct":false,"url":"https://api.github.com/repos/alphagov/smart-answers/commits/19d28a260720a72bd83f6c307e605f28156d7790"},{"sha":"c58868dee22d63198a1f57703678219bb908ac1d","author":{"email":"474ba67bdb289c6263b36dfd8a7bed6c85b04943@floehopper.org","name":"James Mead"},"message":"Extract FixtureFlowsHelper","distinct":false,"url":"https://api.github.com/repos/alphagov/smart-answers/commits/c58868dee22d63198a1f57703678219bb908ac1d"},{"sha":"721fb302a671bf67d795fe7feed066d05f7e4e3f","author":{"email":"474ba67bdb289c6263b36dfd8a7bed6c85b04943@floehopper.org","name":"James Mead"},"message":"Avoid stubbing FlowRegistry in SmartAnswersControllerTest\n\nIt seems simpler and more realistic to use the real `SmartAnswer::FlowRegistry`\nrather than stubbing everything. By using the methods in `FixtureFlowsHelper`\nwe can ensure that preloading of flows is disabled, thus only the flow under\ntest should be loaded.\n\nUnfortunately we still need to setup the translation file\nexplicitly, because this is normally done globally and not by each flow.","distinct":false,"url":"https://api.github.com/repos/alphagov/smart-answers/commits/721fb302a671bf67d795fe7feed066d05f7e4e3f"},{"sha":"15fbcd91d544ebc8a555830bc75ab02d06c33b6c","author":{"email":"474ba67bdb289c6263b36dfd8a7bed6c85b04943@floehopper.org","name":"James Mead"},"message":"Avoid stubbing FlowRegistry in SmartAnswersControllerDateQuestionTest\n\nIt seems simpler and more realistic to use the real `SmartAnswer::FlowRegistry`\nrather than stubbing everything. By using the methods in `FixtureFlowsHelper`\nwe can ensure that preloading of flows is disabled, thus only the flow under\ntest should be loaded.\n\nUnfortunately we still need to setup the translation file\nexplicitly, because this is normally done globally and not by each flow.","distinct":false,"url":"https://api.github.com/repos/alphagov/smart-answers/commits/15fbcd91d544ebc8a555830bc75ab02d06c33b6c"},{"sha":"b7addfdff3cef79c00d6fae619c6dba45f95d3cc","author":{"email":"474ba67bdb289c6263b36dfd8a7bed6c85b04943@floehopper.org","name":"James Mead"},"message":"Avoid stubbing FlowRegistry in SmartAnswersControllerValueQuestionTest\n\nIt seems simpler and more realistic to use the real `SmartAnswer::FlowRegistry`\nrather than stubbing everything. By using the methods in `FixtureFlowsHelper`\nwe can ensure that preloading of flows is disabled, thus only the flow under\ntest should be loaded.\n\nUnfortunately we still need to setup the translation file\nexplicitly, because this is normally done globally and not by each flow.","distinct":false,"url":"https://api.github.com/repos/alphagov/smart-answers/commits/b7addfdff3cef79c00d6fae619c6dba45f95d3cc"},{"sha":"dbb49e89449452a0056b5312e5edf056031f79a6","author":{"email":"474ba67bdb289c6263b36dfd8a7bed6c85b04943@floehopper.org","name":"James Mead"},"message":"Avoid stubbing FlowRegistry in SmartAnswersControllerMoneyQuestionTest\n\nIt seems simpler and more realistic to use the real `SmartAnswer::FlowRegistry`\nrather than stubbing everything. By using the methods in `FixtureFlowsHelper`\nwe can ensure that preloading of flows is disabled, thus only the flow under\ntest should be loaded.\n\nUnfortunately we still need to setup the translation file\nexplicitly, because this is normally done globally and not by each flow.","distinct":false,"url":"https://api.github.com/repos/alphagov/smart-answers/commits/dbb49e89449452a0056b5312e5edf056031f79a6"},{"sha":"662d98670b45ee25895ef92ee28361fcda45c7a8","author":{"email":"474ba67bdb289c6263b36dfd8a7bed6c85b04943@floehopper.org","name":"James Mead"},"message":"Avoid stubbing FlowRegistry in SmartAnswersControllerSalaryQuestionTest\n\nIt seems simpler and more realistic to use the real `SmartAnswer::FlowRegistry`\nrather than stubbing everything. By using the methods in `FixtureFlowsHelper`\nwe can ensure that preloading of flows is disabled, thus only the flow under\ntest should be loaded.\n\nUnfortunately we still need to setup the translation file\nexplicitly, because this is normally done globally and not by each flow.","distinct":false,"url":"https://api.github.com/repos/alphagov/smart-answers/commits/662d98670b45ee25895ef92ee28361fcda45c7a8"}]}