{"action":"created","comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/26584583","id":26584583,"diff_hunk":"@@ -211,6 +211,21 @@ std::vector<HFShowerLibrary::Hit> HFShowerLibrary::getHits(G4Step * aStep,\n   G4String      partType = track->GetDefinition()->GetParticleName();\n   int           parCode  = track->GetDefinition()->GetPDGEncoding();\n \n+#ifdef DebugLog\n+  G4ThreeVector localPos = preStepPoint->GetTouchable()->GetHistory()->GetTopTransform().TransformPoint(hitPoint);\n+  double zoff   = localPos.z() + 0.5*gpar[1];\n+  //  if (zoff < 0) zoff = 0;\n+  edm::LogInfo(\"HFShower\") << \"HFShowerLibrary: getHits \" << partType\n+                           << \" of energy \" << pin/GeV << \" GeV\"\n+                           << \"  dir.orts \" << momDir.x() << \", \" <<momDir.y()\n+                           << \", \" << momDir.z() << \"  Pos x,y,z = \"\n+                           << hitPoint.x() << \",\" << hitPoint.y() << \",\"\n+                           << hitPoint.z() << \" (\" << zoff\n+                           << \")   sphi,cphi,stheta,ctheta  = \" << sin(momDir.phi())\n+                           << \",\"  << cos(momDir.phi()) << \", \" << sin(momDir.theta()) \n+                           << \",\" << cos(momDir.theta());\n+#endif\n+\n   std::vector<HFShowerLibrary::Hit> hit;\n   ok = false;\n   if (parCode == pi0PDG || parCode == etaPDG || parCode == nuePDG ||","path":"SimG4CMS/Calo/src/HFShowerLibrary.cc","position":21,"original_position":21,"commit_id":"e77e48c44e9716bf9b6530edd6bfe0b9dc7a6ca2","original_commit_id":"e77e48c44e9716bf9b6530edd6bfe0b9dc7a6ca2","user":{"login":"lveldere","id":5065551,"avatar_url":"https://avatars.githubusercontent.com/u/5065551?v=3","gravatar_id":"","url":"https://api.github.com/users/lveldere","html_url":"https://github.com/lveldere","followers_url":"https://api.github.com/users/lveldere/followers","following_url":"https://api.github.com/users/lveldere/following{/other_user}","gists_url":"https://api.github.com/users/lveldere/gists{/gist_id}","starred_url":"https://api.github.com/users/lveldere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lveldere/subscriptions","organizations_url":"https://api.github.com/users/lveldere/orgs","repos_url":"https://api.github.com/users/lveldere/repos","events_url":"https://api.github.com/users/lveldere/events{/privacy}","received_events_url":"https://api.github.com/users/lveldere/received_events","type":"User","site_admin":false},"body":"@Vlandr57 \r\n\r\nmove the parCode condition to the fillHits function,\r\nthis allows you to remove the parCode condition from\r\nFastHFShowerLibrary","created_at":"2015-03-17T15:43:33Z","updated_at":"2015-03-17T15:43:33Z","html_url":"https://github.com/cms-sw/cmssw/pull/8358#discussion_r26584583","pull_request_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/8358","_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/26584583"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/8358#discussion_r26584583"},"pull_request":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/8358"}}},"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/8358","id":31347110,"html_url":"https://github.com/cms-sw/cmssw/pull/8358","diff_url":"https://github.com/cms-sw/cmssw/pull/8358.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/8358.patch","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/8358","number":8358,"state":"open","locked":false,"title":"HF shower library interface vers03","user":{"login":"lveldere","id":5065551,"avatar_url":"https://avatars.githubusercontent.com/u/5065551?v=3","gravatar_id":"","url":"https://api.github.com/users/lveldere","html_url":"https://github.com/lveldere","followers_url":"https://api.github.com/users/lveldere/followers","following_url":"https://api.github.com/users/lveldere/following{/other_user}","gists_url":"https://api.github.com/users/lveldere/gists{/gist_id}","starred_url":"https://api.github.com/users/lveldere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lveldere/subscriptions","organizations_url":"https://api.github.com/users/lveldere/orgs","repos_url":"https://api.github.com/users/lveldere/repos","events_url":"https://api.github.com/users/lveldere/events{/privacy}","received_events_url":"https://api.github.com/users/lveldere/received_events","type":"User","site_admin":false},"body":"I open this pr to enable a discussion.\r\nA proper description will follow later.","created_at":"2015-03-17T15:40:57Z","updated_at":"2015-03-17T15:43:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"efa7d1bbe3d9941c5ed9bc88f687b460abd5f36c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/8358/commits","review_comments_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/8358/comments","review_comment_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/8358/comments","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/e77e48c44e9716bf9b6530edd6bfe0b9dc7a6ca2","head":{"label":"Vlandr57:ShowLibHF_vres03","ref":"ShowLibHF_vres03","sha":"e77e48c44e9716bf9b6530edd6bfe0b9dc7a6ca2","user":{"login":"Vlandr57","id":5694963,"avatar_url":"https://avatars.githubusercontent.com/u/5694963?v=3","gravatar_id":"","url":"https://api.github.com/users/Vlandr57","html_url":"https://github.com/Vlandr57","followers_url":"https://api.github.com/users/Vlandr57/followers","following_url":"https://api.github.com/users/Vlandr57/following{/other_user}","gists_url":"https://api.github.com/users/Vlandr57/gists{/gist_id}","starred_url":"https://api.github.com/users/Vlandr57/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vlandr57/subscriptions","organizations_url":"https://api.github.com/users/Vlandr57/orgs","repos_url":"https://api.github.com/users/Vlandr57/repos","events_url":"https://api.github.com/users/Vlandr57/events{/privacy}","received_events_url":"https://api.github.com/users/Vlandr57/received_events","type":"User","site_admin":false},"repo":{"id":13602168,"name":"cmssw","full_name":"Vlandr57/cmssw","owner":{"login":"Vlandr57","id":5694963,"avatar_url":"https://avatars.githubusercontent.com/u/5694963?v=3","gravatar_id":"","url":"https://api.github.com/users/Vlandr57","html_url":"https://github.com/Vlandr57","followers_url":"https://api.github.com/users/Vlandr57/followers","following_url":"https://api.github.com/users/Vlandr57/following{/other_user}","gists_url":"https://api.github.com/users/Vlandr57/gists{/gist_id}","starred_url":"https://api.github.com/users/Vlandr57/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vlandr57/subscriptions","organizations_url":"https://api.github.com/users/Vlandr57/orgs","repos_url":"https://api.github.com/users/Vlandr57/repos","events_url":"https://api.github.com/users/Vlandr57/events{/privacy}","received_events_url":"https://api.github.com/users/Vlandr57/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Vlandr57/cmssw","description":"CMS Offline Software","fork":true,"url":"https://api.github.com/repos/Vlandr57/cmssw","forks_url":"https://api.github.com/repos/Vlandr57/cmssw/forks","keys_url":"https://api.github.com/repos/Vlandr57/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Vlandr57/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Vlandr57/cmssw/teams","hooks_url":"https://api.github.com/repos/Vlandr57/cmssw/hooks","issue_events_url":"https://api.github.com/repos/Vlandr57/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/Vlandr57/cmssw/events","assignees_url":"https://api.github.com/repos/Vlandr57/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/Vlandr57/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/Vlandr57/cmssw/tags","blobs_url":"https://api.github.com/repos/Vlandr57/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Vlandr57/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Vlandr57/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/Vlandr57/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Vlandr57/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/Vlandr57/cmssw/languages","stargazers_url":"https://api.github.com/repos/Vlandr57/cmssw/stargazers","contributors_url":"https://api.github.com/repos/Vlandr57/cmssw/contributors","subscribers_url":"https://api.github.com/repos/Vlandr57/cmssw/subscribers","subscription_url":"https://api.github.com/repos/Vlandr57/cmssw/subscription","commits_url":"https://api.github.com/repos/Vlandr57/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/Vlandr57/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/Vlandr57/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/Vlandr57/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/Vlandr57/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/Vlandr57/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Vlandr57/cmssw/merges","archive_url":"https://api.github.com/repos/Vlandr57/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Vlandr57/cmssw/downloads","issues_url":"https://api.github.com/repos/Vlandr57/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/Vlandr57/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/Vlandr57/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/Vlandr57/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Vlandr57/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/Vlandr57/cmssw/releases{/id}","created_at":"2013-10-15T21:01:50Z","updated_at":"2014-04-19T02:52:40Z","pushed_at":"2015-03-12T11:29:59Z","git_url":"git://github.com/Vlandr57/cmssw.git","ssh_url":"git@github.com:Vlandr57/cmssw.git","clone_url":"https://github.com/Vlandr57/cmssw.git","svn_url":"https://github.com/Vlandr57/cmssw","homepage":"cms-sw.github.io/cmssw","size":696188,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"CMSSW_7_0_X"}},"base":{"label":"cms-sw:CMSSW_7_5_X","ref":"CMSSW_7_5_X","sha":"a31f9e895542ca01e7054f3bb7f953d79c9a3b73","user":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars.githubusercontent.com/u/3863500?v=3","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"repo":{"id":10969551,"name":"cmssw","full_name":"cms-sw/cmssw","owner":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars.githubusercontent.com/u/3863500?v=3","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cms-sw/cmssw","description":"CMS Offline Software","fork":false,"url":"https://api.github.com/repos/cms-sw/cmssw","forks_url":"https://api.github.com/repos/cms-sw/cmssw/forks","keys_url":"https://api.github.com/repos/cms-sw/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cms-sw/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cms-sw/cmssw/teams","hooks_url":"https://api.github.com/repos/cms-sw/cmssw/hooks","issue_events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/cms-sw/cmssw/events","assignees_url":"https://api.github.com/repos/cms-sw/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/cms-sw/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/cms-sw/cmssw/tags","blobs_url":"https://api.github.com/repos/cms-sw/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cms-sw/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cms-sw/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/cms-sw/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/cms-sw/cmssw/languages","stargazers_url":"https://api.github.com/repos/cms-sw/cmssw/stargazers","contributors_url":"https://api.github.com/repos/cms-sw/cmssw/contributors","subscribers_url":"https://api.github.com/repos/cms-sw/cmssw/subscribers","subscription_url":"https://api.github.com/repos/cms-sw/cmssw/subscription","commits_url":"https://api.github.com/repos/cms-sw/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/cms-sw/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/cms-sw/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/cms-sw/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cms-sw/cmssw/merges","archive_url":"https://api.github.com/repos/cms-sw/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cms-sw/cmssw/downloads","issues_url":"https://api.github.com/repos/cms-sw/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/cms-sw/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/cms-sw/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/cms-sw/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cms-sw/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/cms-sw/cmssw/releases{/id}","created_at":"2013-06-26T14:09:07Z","updated_at":"2015-03-17T15:34:17Z","pushed_at":"2015-03-17T15:34:16Z","git_url":"git://github.com/cms-sw/cmssw.git","ssh_url":"git@github.com:cms-sw/cmssw.git","clone_url":"https://github.com/cms-sw/cmssw.git","svn_url":"https://github.com/cms-sw/cmssw","homepage":"http://cms-sw.github.io/","size":896016,"stargazers_count":214,"watchers_count":214,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1303,"mirror_url":null,"open_issues_count":143,"forks":1303,"open_issues":143,"watchers":214,"default_branch":"CMSSW_7_5_X"}},"_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/8358"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/8358"},"issue":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/8358"},"comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/8358/comments"},"review_comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/8358/comments"},"review_comment":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/8358/commits"},"statuses":{"href":"https://api.github.com/repos/cms-sw/cmssw/statuses/e77e48c44e9716bf9b6530edd6bfe0b9dc7a6ca2"}}}}