{"action":"created","issue":{"url":"https://api.github.com/repos/ghoneycutt/puppet-module-pam/issues/75","labels_url":"https://api.github.com/repos/ghoneycutt/puppet-module-pam/issues/75/labels{/name}","comments_url":"https://api.github.com/repos/ghoneycutt/puppet-module-pam/issues/75/comments","events_url":"https://api.github.com/repos/ghoneycutt/puppet-module-pam/issues/75/events","html_url":"https://github.com/ghoneycutt/puppet-module-pam/pull/75","id":43276849,"number":75,"title":"Add login_pam_access and sshd_pam_access parameters","user":{"login":"treydock","id":739622,"avatar_url":"https://avatars.githubusercontent.com/u/739622?v=3","gravatar_id":"","url":"https://api.github.com/users/treydock","html_url":"https://github.com/treydock","followers_url":"https://api.github.com/users/treydock/followers","following_url":"https://api.github.com/users/treydock/following{/other_user}","gists_url":"https://api.github.com/users/treydock/gists{/gist_id}","starred_url":"https://api.github.com/users/treydock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/treydock/subscriptions","organizations_url":"https://api.github.com/users/treydock/orgs","repos_url":"https://api.github.com/users/treydock/repos","events_url":"https://api.github.com/users/treydock/events{/privacy}","received_events_url":"https://api.github.com/users/treydock/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2014-09-19T20:06:02Z","updated_at":"2015-01-28T19:41:25Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ghoneycutt/puppet-module-pam/pulls/75","html_url":"https://github.com/ghoneycutt/puppet-module-pam/pull/75","diff_url":"https://github.com/ghoneycutt/puppet-module-pam/pull/75.diff","patch_url":"https://github.com/ghoneycutt/puppet-module-pam/pull/75.patch"},"body":"Add login_pam_access and sshd_pam_access parameters to override the control flag for pam_access.so when used in sshd.conf or login.conf templates (EL5, EL6 and SUSE 11)\r\n\r\nThis is particularly useful as I need to have pam_access set to \"sufficient\" in some cases when another PAM module is in charge of access control (pam_slurm.so).\r\n\r\nI moved the tests for File[pam_d_login] and File[pam_d_sshd] resource to separate files for the sake of reducing the size of init_spec.rb.  Even with a good IDE it's sometimes hard to find things in a file over 1500 lines long."},"comment":{"url":"https://api.github.com/repos/ghoneycutt/puppet-module-pam/issues/comments/71901147","html_url":"https://github.com/ghoneycutt/puppet-module-pam/pull/75#issuecomment-71901147","issue_url":"https://api.github.com/repos/ghoneycutt/puppet-module-pam/issues/75","id":71901147,"user":{"login":"ghoneycutt","id":313891,"avatar_url":"https://avatars.githubusercontent.com/u/313891?v=3","gravatar_id":"","url":"https://api.github.com/users/ghoneycutt","html_url":"https://github.com/ghoneycutt","followers_url":"https://api.github.com/users/ghoneycutt/followers","following_url":"https://api.github.com/users/ghoneycutt/following{/other_user}","gists_url":"https://api.github.com/users/ghoneycutt/gists{/gist_id}","starred_url":"https://api.github.com/users/ghoneycutt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghoneycutt/subscriptions","organizations_url":"https://api.github.com/users/ghoneycutt/orgs","repos_url":"https://api.github.com/users/ghoneycutt/repos","events_url":"https://api.github.com/users/ghoneycutt/events{/privacy}","received_events_url":"https://api.github.com/users/ghoneycutt/received_events","type":"User","site_admin":false},"created_at":"2015-01-28T19:41:25Z","updated_at":"2015-01-28T19:41:25Z","body":"Thanks for coming back and taking a look at this, I really appreciate it!\r\n\r\n\r\nrspec-puppet-facts looks pretty cool. There is a similar approach here[1] that is used in some of the modules. As a bit of history, this module's rspec tests were solely written by people who were learning rspec-puppet at the time and the module just kept growing and growing to support more OS's. Definitely in agreement that the spec file could be condensed quite a bit.\r\n\r\nI think I prefer the platforms hash method from the vim module because there is less magic on what is going on, you can supply other data such as package names, and because rspec-puppet-facts does not support the Solaris and Suse versions that this module supports.\r\n\r\n[1] - https://github.com/ghoneycutt/puppet-module-vim/blob/master/spec/classes/init_spec.rb#L4-148"}}