{"action":"created","comment":{"url":"https://api.github.com/repos/openchange/openchange/pulls/comments/28488625","id":28488625,"diff_hunk":"@@ -1270,44 +1296,48 @@ static void dcesrv_NspiResolveNames(struct dcesrv_call_state *dce_call,\n \t}\n \n \t/* Allocate output MIds */\n-\tpaStr = r->in.paStr;\n+\tpaWStr = r->in.paWStr;\n \tpMIds = talloc(mem_ctx, struct PropertyTagArray_r);\n \tDCESRV_NSP_RETURN_IF(!pMIds, r, MAPI_E_NOT_ENOUGH_MEMORY, NULL);\n-\tpMIds->cValues = paStr->Count;\n-\tpMIds->aulPropTag = (uint32_t *) talloc_array(pMIds, uint32_t, pMIds->cValues);\n+\tpMIds->cValues = paWStr->Count;\n+\tpMIds->aulPropTag = talloc_array(pMIds, uint32_t, pMIds->cValues);","path":"mapiproxy/servers/default/nspi/dcesrv_exchange_nsp.c","position":103,"original_position":103,"commit_id":"2537d590ccae069631e816734b619debdf2313cf","original_commit_id":"2537d590ccae069631e816734b619debdf2313cf","user":{"login":"sixstone-qq","id":440508,"avatar_url":"https://avatars.githubusercontent.com/u/440508?v=3","gravatar_id":"","url":"https://api.github.com/users/sixstone-qq","html_url":"https://github.com/sixstone-qq","followers_url":"https://api.github.com/users/sixstone-qq/followers","following_url":"https://api.github.com/users/sixstone-qq/following{/other_user}","gists_url":"https://api.github.com/users/sixstone-qq/gists{/gist_id}","starred_url":"https://api.github.com/users/sixstone-qq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sixstone-qq/subscriptions","organizations_url":"https://api.github.com/users/sixstone-qq/orgs","repos_url":"https://api.github.com/users/sixstone-qq/repos","events_url":"https://api.github.com/users/sixstone-qq/events{/privacy}","received_events_url":"https://api.github.com/users/sixstone-qq/received_events","type":"User","site_admin":false},"body":"I'd use `talloc_zero_array`.","created_at":"2015-04-16T07:22:55Z","updated_at":"2015-04-16T07:22:55Z","html_url":"https://github.com/openchange/openchange/pull/278#discussion_r28488625","pull_request_url":"https://api.github.com/repos/openchange/openchange/pulls/278","_links":{"self":{"href":"https://api.github.com/repos/openchange/openchange/pulls/comments/28488625"},"html":{"href":"https://github.com/openchange/openchange/pull/278#discussion_r28488625"},"pull_request":{"href":"https://api.github.com/repos/openchange/openchange/pulls/278"}}},"pull_request":{"url":"https://api.github.com/repos/openchange/openchange/pulls/278","id":33361576,"html_url":"https://github.com/openchange/openchange/pull/278","diff_url":"https://github.com/openchange/openchange/pull/278.diff","patch_url":"https://github.com/openchange/openchange/pull/278.patch","issue_url":"https://api.github.com/repos/openchange/openchange/issues/278","number":278,"state":"open","locked":false,"title":"[nspi] Better ResolveName(W) search","user":{"login":"javierag","id":2778038,"avatar_url":"https://avatars.githubusercontent.com/u/2778038?v=3","gravatar_id":"","url":"https://api.github.com/users/javierag","html_url":"https://github.com/javierag","followers_url":"https://api.github.com/users/javierag/followers","following_url":"https://api.github.com/users/javierag/following{/other_user}","gists_url":"https://api.github.com/users/javierag/gists{/gist_id}","starred_url":"https://api.github.com/users/javierag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javierag/subscriptions","organizations_url":"https://api.github.com/users/javierag/orgs","repos_url":"https://api.github.com/users/javierag/repos","events_url":"https://api.github.com/users/javierag/events{/privacy}","received_events_url":"https://api.github.com/users/javierag/received_events","type":"User","site_admin":false},"body":"- Improve ANR search to look on more fields and match at the beginning of the string\r\n- Use common code for both ResolveName and ResolveNameW functions\r\n- Added some missing sanity checks","created_at":"2015-04-15T14:44:22Z","updated_at":"2015-04-16T07:22:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cd3d8b5f1555d017151926805a780f1691eea5b0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openchange/openchange/pulls/278/commits","review_comments_url":"https://api.github.com/repos/openchange/openchange/pulls/278/comments","review_comment_url":"https://api.github.com/repos/openchange/openchange/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openchange/openchange/issues/278/comments","statuses_url":"https://api.github.com/repos/openchange/openchange/statuses/2537d590ccae069631e816734b619debdf2313cf","head":{"label":"javierag:jag/fix-nspi-resolvenames","ref":"jag/fix-nspi-resolvenames","sha":"2537d590ccae069631e816734b619debdf2313cf","user":{"login":"javierag","id":2778038,"avatar_url":"https://avatars.githubusercontent.com/u/2778038?v=3","gravatar_id":"","url":"https://api.github.com/users/javierag","html_url":"https://github.com/javierag","followers_url":"https://api.github.com/users/javierag/followers","following_url":"https://api.github.com/users/javierag/following{/other_user}","gists_url":"https://api.github.com/users/javierag/gists{/gist_id}","starred_url":"https://api.github.com/users/javierag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javierag/subscriptions","organizations_url":"https://api.github.com/users/javierag/orgs","repos_url":"https://api.github.com/users/javierag/repos","events_url":"https://api.github.com/users/javierag/events{/privacy}","received_events_url":"https://api.github.com/users/javierag/received_events","type":"User","site_admin":false},"repo":{"id":25157623,"name":"openchange","full_name":"javierag/openchange","owner":{"login":"javierag","id":2778038,"avatar_url":"https://avatars.githubusercontent.com/u/2778038?v=3","gravatar_id":"","url":"https://api.github.com/users/javierag","html_url":"https://github.com/javierag","followers_url":"https://api.github.com/users/javierag/followers","following_url":"https://api.github.com/users/javierag/following{/other_user}","gists_url":"https://api.github.com/users/javierag/gists{/gist_id}","starred_url":"https://api.github.com/users/javierag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javierag/subscriptions","organizations_url":"https://api.github.com/users/javierag/orgs","repos_url":"https://api.github.com/users/javierag/repos","events_url":"https://api.github.com/users/javierag/events{/privacy}","received_events_url":"https://api.github.com/users/javierag/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/javierag/openchange","description":"OpenChange Project","fork":true,"url":"https://api.github.com/repos/javierag/openchange","forks_url":"https://api.github.com/repos/javierag/openchange/forks","keys_url":"https://api.github.com/repos/javierag/openchange/keys{/key_id}","collaborators_url":"https://api.github.com/repos/javierag/openchange/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/javierag/openchange/teams","hooks_url":"https://api.github.com/repos/javierag/openchange/hooks","issue_events_url":"https://api.github.com/repos/javierag/openchange/issues/events{/number}","events_url":"https://api.github.com/repos/javierag/openchange/events","assignees_url":"https://api.github.com/repos/javierag/openchange/assignees{/user}","branches_url":"https://api.github.com/repos/javierag/openchange/branches{/branch}","tags_url":"https://api.github.com/repos/javierag/openchange/tags","blobs_url":"https://api.github.com/repos/javierag/openchange/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/javierag/openchange/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/javierag/openchange/git/refs{/sha}","trees_url":"https://api.github.com/repos/javierag/openchange/git/trees{/sha}","statuses_url":"https://api.github.com/repos/javierag/openchange/statuses/{sha}","languages_url":"https://api.github.com/repos/javierag/openchange/languages","stargazers_url":"https://api.github.com/repos/javierag/openchange/stargazers","contributors_url":"https://api.github.com/repos/javierag/openchange/contributors","subscribers_url":"https://api.github.com/repos/javierag/openchange/subscribers","subscription_url":"https://api.github.com/repos/javierag/openchange/subscription","commits_url":"https://api.github.com/repos/javierag/openchange/commits{/sha}","git_commits_url":"https://api.github.com/repos/javierag/openchange/git/commits{/sha}","comments_url":"https://api.github.com/repos/javierag/openchange/comments{/number}","issue_comment_url":"https://api.github.com/repos/javierag/openchange/issues/comments{/number}","contents_url":"https://api.github.com/repos/javierag/openchange/contents/{+path}","compare_url":"https://api.github.com/repos/javierag/openchange/compare/{base}...{head}","merges_url":"https://api.github.com/repos/javierag/openchange/merges","archive_url":"https://api.github.com/repos/javierag/openchange/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/javierag/openchange/downloads","issues_url":"https://api.github.com/repos/javierag/openchange/issues{/number}","pulls_url":"https://api.github.com/repos/javierag/openchange/pulls{/number}","milestones_url":"https://api.github.com/repos/javierag/openchange/milestones{/number}","notifications_url":"https://api.github.com/repos/javierag/openchange/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/javierag/openchange/labels{/name}","releases_url":"https://api.github.com/repos/javierag/openchange/releases{/id}","created_at":"2014-10-13T12:25:54Z","updated_at":"2015-04-09T15:04:11Z","pushed_at":"2015-04-15T15:18:23Z","git_url":"git://github.com/javierag/openchange.git","ssh_url":"git@github.com:javierag/openchange.git","clone_url":"https://github.com/javierag/openchange.git","svn_url":"https://github.com/javierag/openchange","homepage":null,"size":21286,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openchange:master","ref":"master","sha":"073005651bdac6f1a2b8e536cee4877984ed052e","user":{"login":"openchange","id":5413705,"avatar_url":"https://avatars.githubusercontent.com/u/5413705?v=3","gravatar_id":"","url":"https://api.github.com/users/openchange","html_url":"https://github.com/openchange","followers_url":"https://api.github.com/users/openchange/followers","following_url":"https://api.github.com/users/openchange/following{/other_user}","gists_url":"https://api.github.com/users/openchange/gists{/gist_id}","starred_url":"https://api.github.com/users/openchange/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openchange/subscriptions","organizations_url":"https://api.github.com/users/openchange/orgs","repos_url":"https://api.github.com/users/openchange/repos","events_url":"https://api.github.com/users/openchange/events{/privacy}","received_events_url":"https://api.github.com/users/openchange/received_events","type":"Organization","site_admin":false},"repo":{"id":12688822,"name":"openchange","full_name":"openchange/openchange","owner":{"login":"openchange","id":5413705,"avatar_url":"https://avatars.githubusercontent.com/u/5413705?v=3","gravatar_id":"","url":"https://api.github.com/users/openchange","html_url":"https://github.com/openchange","followers_url":"https://api.github.com/users/openchange/followers","following_url":"https://api.github.com/users/openchange/following{/other_user}","gists_url":"https://api.github.com/users/openchange/gists{/gist_id}","starred_url":"https://api.github.com/users/openchange/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openchange/subscriptions","organizations_url":"https://api.github.com/users/openchange/orgs","repos_url":"https://api.github.com/users/openchange/repos","events_url":"https://api.github.com/users/openchange/events{/privacy}","received_events_url":"https://api.github.com/users/openchange/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openchange/openchange","description":"OpenChange Project","fork":false,"url":"https://api.github.com/repos/openchange/openchange","forks_url":"https://api.github.com/repos/openchange/openchange/forks","keys_url":"https://api.github.com/repos/openchange/openchange/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openchange/openchange/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openchange/openchange/teams","hooks_url":"https://api.github.com/repos/openchange/openchange/hooks","issue_events_url":"https://api.github.com/repos/openchange/openchange/issues/events{/number}","events_url":"https://api.github.com/repos/openchange/openchange/events","assignees_url":"https://api.github.com/repos/openchange/openchange/assignees{/user}","branches_url":"https://api.github.com/repos/openchange/openchange/branches{/branch}","tags_url":"https://api.github.com/repos/openchange/openchange/tags","blobs_url":"https://api.github.com/repos/openchange/openchange/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openchange/openchange/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openchange/openchange/git/refs{/sha}","trees_url":"https://api.github.com/repos/openchange/openchange/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openchange/openchange/statuses/{sha}","languages_url":"https://api.github.com/repos/openchange/openchange/languages","stargazers_url":"https://api.github.com/repos/openchange/openchange/stargazers","contributors_url":"https://api.github.com/repos/openchange/openchange/contributors","subscribers_url":"https://api.github.com/repos/openchange/openchange/subscribers","subscription_url":"https://api.github.com/repos/openchange/openchange/subscription","commits_url":"https://api.github.com/repos/openchange/openchange/commits{/sha}","git_commits_url":"https://api.github.com/repos/openchange/openchange/git/commits{/sha}","comments_url":"https://api.github.com/repos/openchange/openchange/comments{/number}","issue_comment_url":"https://api.github.com/repos/openchange/openchange/issues/comments{/number}","contents_url":"https://api.github.com/repos/openchange/openchange/contents/{+path}","compare_url":"https://api.github.com/repos/openchange/openchange/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openchange/openchange/merges","archive_url":"https://api.github.com/repos/openchange/openchange/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openchange/openchange/downloads","issues_url":"https://api.github.com/repos/openchange/openchange/issues{/number}","pulls_url":"https://api.github.com/repos/openchange/openchange/pulls{/number}","milestones_url":"https://api.github.com/repos/openchange/openchange/milestones{/number}","notifications_url":"https://api.github.com/repos/openchange/openchange/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openchange/openchange/labels{/name}","releases_url":"https://api.github.com/repos/openchange/openchange/releases{/id}","created_at":"2013-09-08T22:39:00Z","updated_at":"2015-04-14T08:32:30Z","pushed_at":"2015-04-15T23:36:51Z","git_url":"git://github.com/openchange/openchange.git","ssh_url":"git@github.com:openchange/openchange.git","clone_url":"https://github.com/openchange/openchange.git","svn_url":"https://github.com/openchange/openchange","homepage":null,"size":26583,"stargazers_count":51,"watchers_count":51,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"open_issues_count":24,"forks":28,"open_issues":24,"watchers":51,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openchange/openchange/pulls/278"},"html":{"href":"https://github.com/openchange/openchange/pull/278"},"issue":{"href":"https://api.github.com/repos/openchange/openchange/issues/278"},"comments":{"href":"https://api.github.com/repos/openchange/openchange/issues/278/comments"},"review_comments":{"href":"https://api.github.com/repos/openchange/openchange/pulls/278/comments"},"review_comment":{"href":"https://api.github.com/repos/openchange/openchange/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openchange/openchange/pulls/278/commits"},"statuses":{"href":"https://api.github.com/repos/openchange/openchange/statuses/2537d590ccae069631e816734b619debdf2313cf"}}}}