{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/3254","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/3254/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/3254/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/3254/events","html_url":"https://github.com/ManageIQ/manageiq/pull/3254","id":90673224,"number":3254,"title":"[WIP] Refactoring javascript files","user":{"login":"romanblanco","id":1187051,"avatar_url":"https://avatars.githubusercontent.com/u/1187051?v=3","gravatar_id":"","url":"https://api.github.com/users/romanblanco","html_url":"https://github.com/romanblanco","followers_url":"https://api.github.com/users/romanblanco/followers","following_url":"https://api.github.com/users/romanblanco/following{/other_user}","gists_url":"https://api.github.com/users/romanblanco/gists{/gist_id}","starred_url":"https://api.github.com/users/romanblanco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romanblanco/subscriptions","organizations_url":"https://api.github.com/users/romanblanco/orgs","repos_url":"https://api.github.com/users/romanblanco/repos","events_url":"https://api.github.com/users/romanblanco/events{/privacy}","received_events_url":"https://api.github.com/users/romanblanco/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/refactoring","name":"refactoring","color":"fbca04"},{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/ui","name":"ui","color":"5319e7"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-06-24T13:19:20Z","updated_at":"2015-06-26T07:54:28Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/3254","html_url":"https://github.com/ManageIQ/manageiq/pull/3254","diff_url":"https://github.com/ManageIQ/manageiq/pull/3254.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/3254.patch"},"body":"Parent issue: #2389"},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments/115566019","html_url":"https://github.com/ManageIQ/manageiq/pull/3254#issuecomment-115566019","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/3254","id":115566019,"user":{"login":"miq-bot","id":7806257,"avatar_url":"https://avatars.githubusercontent.com/u/7806257?v=3","gravatar_id":"","url":"https://api.github.com/users/miq-bot","html_url":"https://github.com/miq-bot","followers_url":"https://api.github.com/users/miq-bot/followers","following_url":"https://api.github.com/users/miq-bot/following{/other_user}","gists_url":"https://api.github.com/users/miq-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/miq-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miq-bot/subscriptions","organizations_url":"https://api.github.com/users/miq-bot/orgs","repos_url":"https://api.github.com/users/miq-bot/repos","events_url":"https://api.github.com/users/miq-bot/events{/privacy}","received_events_url":"https://api.github.com/users/miq-bot/received_events","type":"User","site_admin":false},"created_at":"2015-06-26T07:54:28Z","updated_at":"2015-06-26T07:54:28Z","body":"<rubocop />Checked commits https://github.com/romanblanco/manageiq/commit/165c3556d4fe2f9da9c143526e37cad44da4cca4 .. https://github.com/romanblanco/manageiq/commit/6ddb558ecb19c1e41493df51b5ed6fd02eb64851 with rubocop 0.32.0\n56 files checked, 43 offenses detected\n\n**vmdb/app/controllers/application_controller/performance.rb**\n- [ ] :small_blue_diamond: - [Line 69](https://github.com/romanblanco/manageiq/blob/6ddb558ecb19c1e41493df51b5ed6fd02eb64851/vmdb/app/controllers/application_controller/performance.rb#L69), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.32.0/RuboCop/Cop/Metrics/LineLength) - Line is too long. [121/120]\n- [ ] :small_blue_diamond: - [Line 83](https://github.com/romanblanco/manageiq/blob/6ddb558ecb19c1e41493df51b5ed6fd02eb64851/vmdb/app/controllers/application_controller/performance.rb#L83), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.32.0/RuboCop/Cop/Metrics/LineLength) - Line is too long. [147/120]\n- [ ] :small_blue_diamond: - [Line 84](https://github.com/romanblanco/manageiq/blob/6ddb558ecb19c1e41493df51b5ed6fd02eb64851/vmdb/app/controllers/application_controller/performance.rb#L84), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.32.0/RuboCop/Cop/Metrics/LineLength) - Line is too long. [147/120]\n- [ ] :small_blue_diamond: - [Line 86](https://github.com/romanblanco/manageiq/blob/6ddb558ecb19c1e41493df51b5ed6fd02eb64851/vmdb/app/controllers/application_controller/performance.rb#L86), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.32.0/RuboCop/Cop/Metrics/LineLength) - Line is too long. [165/120]\n- [ ] :small_blue_diamond: - [Line 87](https://github.com/romanblanco/manageiq/blob/6ddb558ecb19c1e41493df51b5ed6fd02eb64851/vmdb/app/controllers/application_controller/performance.rb#L87), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.32.0/RuboCop/Cop/Metrics/LineLength) - Line is too long. [165/120]\n- [ ] :small_blue_diamond: - [Line 396](https://github.com/romanblanco/manageiq/blob/6ddb558ecb19c1e41493df51b5ed6fd02eb64851/vmdb/app/controllers/application_controller/performance.rb#L396), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.32.0/RuboCop/Cop/Metrics/LineLength) - Line is too long. [122/120]\n- [ ] :small_blue_diamond: - [Line 402](https://github.com/romanblanco/manageiq/blob/6ddb558ecb19c1e41493df51b5ed6fd02eb64851/vmdb/app/controllers/application_controller/performance.rb#L402), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.32.0/RuboCop/Cop/Metrics/LineLength) - Line is too long. [145/120]\n- [ ] :small_blue_diamond: - [Line 403](https://github.com/romanblanco/manageiq/blob/6ddb558ecb19c1e41493df51b5ed6fd02eb64851/vmdb/app/controllers/application_controller/performance.rb#L403), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.32.0/RuboCop/Cop/Metrics/LineLength) - Line is too long. [143/120]\n- [ ] :small_blue_diamond: - [Line 432](https://github.com/romanblanco/manageiq/blob/6ddb558ecb19c1e41493df51b5ed6fd02eb64851/vmdb/app/controllers/application_controller/performance.rb#L432), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.32.0/RuboCop/Cop/Metrics/LineLength) - Line is too long. [163/120]\n- [ ] :small_blue_diamond: - [Line 433](https://github.com/romanblanco/manageiq/blob/6ddb558ecb19c1e41493df51b5ed6fd02eb64851/vmdb/app/controllers/application_controller/performance.rb#L433), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.32.0/RuboCop/Cop/Metrics/LineLength) - Line is too long. [161/120]\n\n**vmdb/app/controllers/dashboard_controller.rb**\n- [ ] :small_blue_diamond: - [Line 665](https://github.com/romanblanco/manageiq/blob/6ddb558ecb19c1e41493df51b5ed6fd02eb64851/vmdb/app/controllers/dashboard_controller.rb#L665), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.32.0/RuboCop/Cop/Metrics/LineLength) - Line is too long. [145/120]\n- [ ] :small_blue_diamond: - [Line 668](https://github.com/romanblanco/manageiq/blob/6ddb558ecb19c1e41493df51b5ed6fd02eb64851/vmdb/app/controllers/dashboard_controller.rb#L668), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.32.0/RuboCop/Cop/Metrics/LineLength) - Line is too long. [146/120]\n\n**vmdb/app/controllers/miq_ae_customization_controller.rb**\n- [ ] :small_blue_diamond: - [Line 465](https://github.com/romanblanco/manageiq/blob/6ddb558ecb19c1e41493df51b5ed6fd02eb64851/vmdb/app/controllers/miq_ae_customization_controller.rb#L465), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.32.0/RuboCop/Cop/Metrics/LineLength) - Line is too long. [123/120]\n- [ ] :small_blue_diamond: - [Line 483](https://github.com/romanblanco/manageiq/blob/6ddb558ecb19c1e41493df51b5ed6fd02eb64851/vmdb/app/controllers/miq_ae_customization_controller.rb#L483), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.32.0/RuboCop/Cop/Metrics/LineLength) - Line is too long. [125/120]\n\n**vmdb/app/controllers/ops_controller.rb**\n- [ ] :small_blue_diamond: - [Line 614](https://github.com/romanblanco/manageiq/blob/6ddb558ecb19c1e41493df51b5ed6fd02eb64851/vmdb/app/controllers/ops_controller.rb#L614), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.32.0/RuboCop/Cop/Metrics/LineLength) - Line is too long. [132/120]\n- [ ] :small_blue_diamond: - [Line 664](https://github.com/romanblanco/manageiq/blob/6ddb558ecb19c1e41493df51b5ed6fd02eb64851/vmdb/app/controllers/ops_controller.rb#L664), Col 17 - [Metrics/BlockNesting](http://rubydoc.info/gems/rubocop/0.32.0/RuboCop/Cop/Metrics/BlockNesting) - Avoid more than 3 levels of block nesting.\n- [ ] :small_blue_diamond: - [Line 736](https://github.com/romanblanco/manageiq/blob/6ddb558ecb19c1e41493df51b5ed6fd02eb64851/vmdb/app/controllers/ops_controller.rb#L736), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.32.0/RuboCop/Cop/Metrics/LineLength) - Line is too long. [138/120]\n- [ ] :small_blue_diamond: - [Line 738](https://github.com/romanblanco/manageiq/blob/6ddb558ecb19c1e41493df51b5ed6fd02eb64851/vmdb/app/controllers/ops_controller.rb#L738), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.32.0/RuboCop/Cop/Metrics/LineLength) - Line is too long. [164/120]\n\n**vmdb/app/controllers/pxe_controller.rb**\n- [ ] :small_blue_diamond: - [Line 219](https://github.com/romanblanco/manageiq/blob/6ddb558ecb19c1e41493df51b5ed6fd02eb64851/vmdb/app/controllers/pxe_controller.rb#L219), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.32.0/RuboCop/Cop/Metrics/LineLength) - Line is too long. [126/120]\n\n**vmdb/app/controllers/report_controller/schedules.rb**\n- [ ] :small_blue_diamond: - [Line 181](https://github.com/romanblanco/manageiq/blob/6ddb558ecb19c1e41493df51b5ed6fd02eb64851/vmdb/app/controllers/report_controller/schedules.rb#L181), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.32.0/RuboCop/Cop/Metrics/LineLength) - Line is too long. [126/120]\n\n**vmdb/app/controllers/report_controller/widgets.rb**\n- [ ] :small_blue_diamond: - [Line 164](https://github.com/romanblanco/manageiq/blob/6ddb558ecb19c1e41493df51b5ed6fd02eb64851/vmdb/app/controllers/report_controller/widgets.rb#L164), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.32.0/RuboCop/Cop/Metrics/LineLength) - Line is too long. [126/120]\n\n**vmdb/app/presenters/explorer_presenter.rb**\n- [ ] :small_blue_diamond: - [Line 189](https://github.com/romanblanco/manageiq/blob/6ddb558ecb19c1e41493df51b5ed6fd02eb64851/vmdb/app/presenters/explorer_presenter.rb#L189), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.32.0/RuboCop/Cop/Metrics/LineLength) - Line is too long. [124/120]\n- [ ] :small_blue_diamond: - [Line 190](https://github.com/romanblanco/manageiq/blob/6ddb558ecb19c1e41493df51b5ed6fd02eb64851/vmdb/app/presenters/explorer_presenter.rb#L190), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.32.0/RuboCop/Cop/Metrics/LineLength) - Line is too long. [122/120]\n\n**vmdb/app/views/layouts/_dhtmlxgrid.html.haml**\n- [ ] :red_circle: **Warn** - [Line 20](https://github.com/romanblanco/manageiq/blob/6ddb558ecb19c1e41493df51b5ed6fd02eb64851/vmdb/app/views/layouts/_dhtmlxgrid.html.haml#L20), Col  -  - `= \"...\"` should be rewritten as `...`\n- [ ] :red_circle: **Warn** - [Line 21](https://github.com/romanblanco/manageiq/blob/6ddb558ecb19c1e41493df51b5ed6fd02eb64851/vmdb/app/views/layouts/_dhtmlxgrid.html.haml#L21), Col  -  - `= \"...\"` should be rewritten as `...`\n- [ ] :red_circle: **Warn** - [Line 23](https://github.com/romanblanco/manageiq/blob/6ddb558ecb19c1e41493df51b5ed6fd02eb64851/vmdb/app/views/layouts/_dhtmlxgrid.html.haml#L23), Col  -  - `= \"...\"` should be rewritten as `...`\n- [ ] :red_circle: **Warn** - [Line 25](https://github.com/romanblanco/manageiq/blob/6ddb558ecb19c1e41493df51b5ed6fd02eb64851/vmdb/app/views/layouts/_dhtmlxgrid.html.haml#L25), Col  -  - `= \"...\"` should be rewritten as `...`\n- [ ] :red_circle: **Warn** - [Line 26](https://github.com/romanblanco/manageiq/blob/6ddb558ecb19c1e41493df51b5ed6fd02eb64851/vmdb/app/views/layouts/_dhtmlxgrid.html.haml#L26), Col  -  - `= \"...\"` should be rewritten as `...`\n- [ ] :red_circle: **Warn** - [Line 26](https://github.com/romanblanco/manageiq/blob/6ddb558ecb19c1e41493df51b5ed6fd02eb64851/vmdb/app/views/layouts/_dhtmlxgrid.html.haml#L26), Col  -  - Line is too long. [188/120]\n\n**vmdb/app/views/layouts/_dhtmlxtoolbar.html.haml**\n- [ ] :red_circle: **Warn** - [Line 13](https://github.com/romanblanco/manageiq/blob/6ddb558ecb19c1e41493df51b5ed6fd02eb64851/vmdb/app/views/layouts/_dhtmlxtoolbar.html.haml#L13), Col  -  - `= \"...\"` should be rewritten as `...`\n- [ ] :red_circle: **Warn** - [Line 13](https://github.com/romanblanco/manageiq/blob/6ddb558ecb19c1e41493df51b5ed6fd02eb64851/vmdb/app/views/layouts/_dhtmlxtoolbar.html.haml#L13), Col  -  - Line is too long. [127/120]\n- [ ] :red_circle: **Warn** - [Line 16](https://github.com/romanblanco/manageiq/blob/6ddb558ecb19c1e41493df51b5ed6fd02eb64851/vmdb/app/views/layouts/_dhtmlxtoolbar.html.haml#L16), Col  -  - `= \"...\"` should be rewritten as `...`\n\n**vmdb/app/views/layouts/_global_footer.html.haml**\n- [ ] :red_circle: **Warn** - [Line 3](https://github.com/romanblanco/manageiq/blob/6ddb558ecb19c1e41493df51b5ed6fd02eb64851/vmdb/app/views/layouts/_global_footer.html.haml#L3), Col  -  - `= \"...\"` should be rewritten as `...`\n- [ ] :red_circle: **Warn** - [Line 4](https://github.com/romanblanco/manageiq/blob/6ddb558ecb19c1e41493df51b5ed6fd02eb64851/vmdb/app/views/layouts/_global_footer.html.haml#L4), Col  -  - `= \"...\"` should be rewritten as `...`\n\n**vmdb/app/views/layouts/_my_code_mirror.html.haml**\n- [ ] :red_circle: **Warn** - [Line 26](https://github.com/romanblanco/manageiq/blob/6ddb558ecb19c1e41493df51b5ed6fd02eb64851/vmdb/app/views/layouts/_my_code_mirror.html.haml#L26), Col  -  - `= \"...\"` should be rewritten as `...`\n\n**vmdb/app/views/layouts/_performance_summary.html.haml**\n- [ ] :red_circle: **Warn** - [Line 7](https://github.com/romanblanco/manageiq/blob/6ddb558ecb19c1e41493df51b5ed6fd02eb64851/vmdb/app/views/layouts/_performance_summary.html.haml#L7), Col  -  - `= \"...\"` should be rewritten as `...`\n- [ ] :red_circle: **Warn** - [Line 8](https://github.com/romanblanco/manageiq/blob/6ddb558ecb19c1e41493df51b5ed6fd02eb64851/vmdb/app/views/layouts/_performance_summary.html.haml#L8), Col  -  - `= \"...\"` should be rewritten as `...`\n- [ ] :red_circle: **Warn** - [Line 10](https://github.com/romanblanco/manageiq/blob/6ddb558ecb19c1e41493df51b5ed6fd02eb64851/vmdb/app/views/layouts/_performance_summary.html.haml#L10), Col  -  - `= \"...\"` should be rewritten as `...`\n\n**vmdb/app/views/layouts/_timeline.html.haml**\n- [ ] :red_circle: **Warn** - [Line 6](https://github.com/romanblanco/manageiq/blob/6ddb558ecb19c1e41493df51b5ed6fd02eb64851/vmdb/app/views/layouts/_timeline.html.haml#L6), Col  -  - Style/DoubleNegation: Avoid the use of double negation (`!!`).\n- [ ] :red_circle: **Warn** - [Line 6](https://github.com/romanblanco/manageiq/blob/6ddb558ecb19c1e41493df51b5ed6fd02eb64851/vmdb/app/views/layouts/_timeline.html.haml#L6), Col  -  - `= \"...\"` should be rewritten as `...`\n\n**vmdb/app/views/miq_ae_customization/_dialog_sample.html.haml**\n- [ ] :red_circle: **Warn** - [Line 47](https://github.com/romanblanco/manageiq/blob/6ddb558ecb19c1e41493df51b5ed6fd02eb64851/vmdb/app/views/miq_ae_customization/_dialog_sample.html.haml#L47), Col  -  - Line is too long. [132/120]\n\n**vmdb/app/views/ops/_schedule_form.html.haml**\n- [ ] :red_circle: **Warn** - [Line 38](https://github.com/romanblanco/manageiq/blob/6ddb558ecb19c1e41493df51b5ed6fd02eb64851/vmdb/app/views/ops/_schedule_form.html.haml#L38), Col  -  - Line is too long. [157/120]\n\n**vmdb/app/views/ops/explorer.html.haml**\n- [ ] :red_circle: **Warn** - [Line 32](https://github.com/romanblanco/manageiq/blob/6ddb558ecb19c1e41493df51b5ed6fd02eb64851/vmdb/app/views/ops/explorer.html.haml#L32), Col  -  - `= \"...\"` should be rewritten as `...`\n"}}