{"action":"created","issue":{"url":"https://api.github.com/repos/OTRS/otrs/issues/557","labels_url":"https://api.github.com/repos/OTRS/otrs/issues/557/labels{/name}","comments_url":"https://api.github.com/repos/OTRS/otrs/issues/557/comments","events_url":"https://api.github.com/repos/OTRS/otrs/issues/557/events","html_url":"https://github.com/OTRS/otrs/pull/557","id":71569192,"number":557,"title":"Master port to OM  - Kernel/Output/Article","user":{"login":"s7design","id":6348760,"avatar_url":"https://avatars.githubusercontent.com/u/6348760?v=3","gravatar_id":"","url":"https://api.github.com/users/s7design","html_url":"https://github.com/s7design","followers_url":"https://api.github.com/users/s7design/followers","following_url":"https://api.github.com/users/s7design/following{/other_user}","gists_url":"https://api.github.com/users/s7design/gists{/gist_id}","starred_url":"https://api.github.com/users/s7design/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s7design/subscriptions","organizations_url":"https://api.github.com/users/s7design/orgs","repos_url":"https://api.github.com/users/s7design/repos","events_url":"https://api.github.com/users/s7design/events{/privacy}","received_events_url":"https://api.github.com/users/s7design/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-04-28T12:01:58Z","updated_at":"2015-05-05T13:16:34Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/OTRS/otrs/pulls/557","html_url":"https://github.com/OTRS/otrs/pull/557","diff_url":"https://github.com/OTRS/otrs/pull/557.diff","patch_url":"https://github.com/OTRS/otrs/pull/557.patch"},"body":"Hi,\r\n\r\nThere are ported Article modules from Kernel/Output/HTML.\r\nWe added only one Selenium test, to be honest I don't know how to test these modules for SMIME/PGP/Sign/Crypt with Selenium, and I think that test for ArticleAttachmentDownload is not needed here, because there is test for AgentTicketAttachment. Here is test for ArticleAttachmentHTMLViewer. There is checked how  MIME-Viwer works, if it is enabled. \r\n\r\nIn some modules is used EmailParser.pm (ArticleCheckPGP and ArticleCheckSMIME), and I am not sure if we used it well. We had such dilemma only in this PR https://github.com/OTRS/otrs/pull/521 (line 3053 - AgentTicketZoom.pm). I saw that in  Kernel::System::EmailParser there is  $ObjectManagerDisabled = 1;, maybe because of that we cannot use it with OM.\r\nAlso, I delete %{$Self}, from constructor for EmailParser. I think it is not necessary anymore.\r\n\r\nAnd one more thing, I saw that in some modules is used for checking needed prams the flowing\r\n    # check needed stuff\r\n     for (qw(File Article)) { \r\n... and then in body of for loop is used $_\r\n\r\nand in the others also is used \r\n    # check needed stuff\r\n    for my $Needed (qw(File Article)) {\r\n\r\nIn my opinion the second one is better and I feel free to fix it in these ported modules. \r\nAs I said it is my opinion, and your follow up is welcome in any of these question and dilemmas.\r\n\r\nRegards\r\nZoran \r\n\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/OTRS/otrs/issues/comments/99075234","html_url":"https://github.com/OTRS/otrs/pull/557#issuecomment-99075234","issue_url":"https://api.github.com/repos/OTRS/otrs/issues/557","id":99075234,"user":{"login":"s7design","id":6348760,"avatar_url":"https://avatars.githubusercontent.com/u/6348760?v=3","gravatar_id":"","url":"https://api.github.com/users/s7design","html_url":"https://github.com/s7design","followers_url":"https://api.github.com/users/s7design/followers","following_url":"https://api.github.com/users/s7design/following{/other_user}","gists_url":"https://api.github.com/users/s7design/gists{/gist_id}","starred_url":"https://api.github.com/users/s7design/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s7design/subscriptions","organizations_url":"https://api.github.com/users/s7design/orgs","repos_url":"https://api.github.com/users/s7design/repos","events_url":"https://api.github.com/users/s7design/events{/privacy}","received_events_url":"https://api.github.com/users/s7design/received_events","type":"User","site_admin":false},"created_at":"2015-05-05T13:16:34Z","updated_at":"2015-05-05T13:16:34Z","body":"Hi @mgruner,\r\n\r\nSelenium test is now updated to check if pdftohtml is installed on start of the test. \r\nTicket, article and attachments are added through backend, which results in cleaner and faster test.\r\n\r\nRegards,\r\nSanjin"}}