{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin/pulls/comments/31558435","id":31558435,"diff_hunk":"@@ -146,7 +150,26 @@ func GetBootstrapClusterRoles() []authorizationapi.ClusterRole {\n \t\t\tRules: []authorizationapi.PolicyRule{\n \t\t\t\t{\n \t\t\t\t\tVerbs:     util.NewStringSet(\"get\", \"update\"),\n-\t\t\t\t\tResources: util.NewStringSet(\"imagestreams\"),\n+\t\t\t\t\tResources: util.NewStringSet(\"imagestreams/layers\"),\n+\t\t\t\t},\n+\t\t\t},\n+\t\t},\n+\t\t{\n+\t\t\tObjectMeta: kapi.ObjectMeta{\n+\t\t\t\tName: ImagePrunerRoleName,\n+\t\t\t},\n+\t\t\tRules: []authorizationapi.PolicyRule{\n+\t\t\t\t{\n+\t\t\t\t\tVerbs:     util.NewStringSet(\"delete\"),\n+\t\t\t\t\tResources: util.NewStringSet(\"images\"),\n+\t\t\t\t},\n+\t\t\t\t{\n+\t\t\t\t\tVerbs:     util.NewStringSet(\"get\", \"list\"),\n+\t\t\t\t\tResources: util.NewStringSet(\"images\", \"imagestreams\", \"pods\", \"replicationcontrollers\", \"buildconfigs\", \"builds\", \"deploymentconfigs\"),","path":"pkg/cmd/server/bootstrappolicy/policy.go","position":40,"original_position":40,"commit_id":"b478d4a785a08ea693cb2a8d6f27a801981b9c33","original_commit_id":"ac902e8656696ff428cfbd9b89841ff0ad32979d","user":{"login":"ncdc","id":354,"avatar_url":"https://avatars.githubusercontent.com/u/354?v=3","gravatar_id":"","url":"https://api.github.com/users/ncdc","html_url":"https://github.com/ncdc","followers_url":"https://api.github.com/users/ncdc/followers","following_url":"https://api.github.com/users/ncdc/following{/other_user}","gists_url":"https://api.github.com/users/ncdc/gists{/gist_id}","starred_url":"https://api.github.com/users/ncdc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ncdc/subscriptions","organizations_url":"https://api.github.com/users/ncdc/orgs","repos_url":"https://api.github.com/users/ncdc/repos","events_url":"https://api.github.com/users/ncdc/events{/privacy}","received_events_url":"https://api.github.com/users/ncdc/received_events","type":"User","site_admin":false},"body":"The pruner isn't coded to examine them","created_at":"2015-06-02T18:59:57Z","updated_at":"2015-06-02T18:59:57Z","html_url":"https://github.com/openshift/origin/pull/2703#discussion_r31558435","pull_request_url":"https://api.github.com/repos/openshift/origin/pulls/2703","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments/31558435"},"html":{"href":"https://github.com/openshift/origin/pull/2703#discussion_r31558435"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin/pulls/2703"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/2703","id":36758266,"html_url":"https://github.com/openshift/origin/pull/2703","diff_url":"https://github.com/openshift/origin/pull/2703.diff","patch_url":"https://github.com/openshift/origin/pull/2703.patch","issue_url":"https://api.github.com/repos/openshift/origin/issues/2703","number":2703,"state":"open","locked":false,"title":"Enable and require registry authentication","user":{"login":"ncdc","id":354,"avatar_url":"https://avatars.githubusercontent.com/u/354?v=3","gravatar_id":"","url":"https://api.github.com/users/ncdc","html_url":"https://github.com/ncdc","followers_url":"https://api.github.com/users/ncdc/followers","following_url":"https://api.github.com/users/ncdc/following{/other_user}","gists_url":"https://api.github.com/users/ncdc/gists{/gist_id}","starred_url":"https://api.github.com/users/ncdc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ncdc/subscriptions","organizations_url":"https://api.github.com/users/ncdc/orgs","repos_url":"https://api.github.com/users/ncdc/repos","events_url":"https://api.github.com/users/ncdc/events{/privacy}","received_events_url":"https://api.github.com/users/ncdc/received_events","type":"User","site_admin":false},"body":"Remove DISABLE_USER_AUTH setting the registry used to disable authentication. Auth is now on by default and can't be disabled any more.\r\n\r\nModify the bootstrap policy to\r\n\r\n- add a new subresource `imagestreams/layers` for pushing/pulling images.\r\n- add a new system:image-pruner role\r\n\r\nUpdate `osadm prune images` to require the client either use a config with a token, or specify a service account to use. With either option, the user must be able to do everything that system:image-pruner can do.\r\n\r\n@smarterclayton @liggitt @deads2k PTAL","created_at":"2015-06-02T18:20:18Z","updated_at":"2015-06-02T18:59:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2ca6e7f76776bb85528d901212271eaaf464a9b8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin/pulls/2703/commits","review_comments_url":"https://api.github.com/repos/openshift/origin/pulls/2703/comments","review_comment_url":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin/issues/2703/comments","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/b478d4a785a08ea693cb2a8d6f27a801981b9c33","head":{"label":"ncdc:fix-registry-auth","ref":"fix-registry-auth","sha":"b478d4a785a08ea693cb2a8d6f27a801981b9c33","user":{"login":"ncdc","id":354,"avatar_url":"https://avatars.githubusercontent.com/u/354?v=3","gravatar_id":"","url":"https://api.github.com/users/ncdc","html_url":"https://github.com/ncdc","followers_url":"https://api.github.com/users/ncdc/followers","following_url":"https://api.github.com/users/ncdc/following{/other_user}","gists_url":"https://api.github.com/users/ncdc/gists{/gist_id}","starred_url":"https://api.github.com/users/ncdc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ncdc/subscriptions","organizations_url":"https://api.github.com/users/ncdc/orgs","repos_url":"https://api.github.com/users/ncdc/repos","events_url":"https://api.github.com/users/ncdc/events{/privacy}","received_events_url":"https://api.github.com/users/ncdc/received_events","type":"User","site_admin":false},"repo":{"id":23624564,"name":"origin","full_name":"ncdc/origin","owner":{"login":"ncdc","id":354,"avatar_url":"https://avatars.githubusercontent.com/u/354?v=3","gravatar_id":"","url":"https://api.github.com/users/ncdc","html_url":"https://github.com/ncdc","followers_url":"https://api.github.com/users/ncdc/followers","following_url":"https://api.github.com/users/ncdc/following{/other_user}","gists_url":"https://api.github.com/users/ncdc/gists{/gist_id}","starred_url":"https://api.github.com/users/ncdc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ncdc/subscriptions","organizations_url":"https://api.github.com/users/ncdc/orgs","repos_url":"https://api.github.com/users/ncdc/repos","events_url":"https://api.github.com/users/ncdc/events{/privacy}","received_events_url":"https://api.github.com/users/ncdc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ncdc/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":true,"url":"https://api.github.com/repos/ncdc/origin","forks_url":"https://api.github.com/repos/ncdc/origin/forks","keys_url":"https://api.github.com/repos/ncdc/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ncdc/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ncdc/origin/teams","hooks_url":"https://api.github.com/repos/ncdc/origin/hooks","issue_events_url":"https://api.github.com/repos/ncdc/origin/issues/events{/number}","events_url":"https://api.github.com/repos/ncdc/origin/events","assignees_url":"https://api.github.com/repos/ncdc/origin/assignees{/user}","branches_url":"https://api.github.com/repos/ncdc/origin/branches{/branch}","tags_url":"https://api.github.com/repos/ncdc/origin/tags","blobs_url":"https://api.github.com/repos/ncdc/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ncdc/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ncdc/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/ncdc/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ncdc/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/ncdc/origin/languages","stargazers_url":"https://api.github.com/repos/ncdc/origin/stargazers","contributors_url":"https://api.github.com/repos/ncdc/origin/contributors","subscribers_url":"https://api.github.com/repos/ncdc/origin/subscribers","subscription_url":"https://api.github.com/repos/ncdc/origin/subscription","commits_url":"https://api.github.com/repos/ncdc/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/ncdc/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/ncdc/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/ncdc/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/ncdc/origin/contents/{+path}","compare_url":"https://api.github.com/repos/ncdc/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ncdc/origin/merges","archive_url":"https://api.github.com/repos/ncdc/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ncdc/origin/downloads","issues_url":"https://api.github.com/repos/ncdc/origin/issues{/number}","pulls_url":"https://api.github.com/repos/ncdc/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/ncdc/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/ncdc/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ncdc/origin/labels{/name}","releases_url":"https://api.github.com/repos/ncdc/origin/releases{/id}","created_at":"2014-09-03T14:51:59Z","updated_at":"2015-04-30T17:07:19Z","pushed_at":"2015-06-02T18:30:17Z","git_url":"git://github.com/ncdc/origin.git","ssh_url":"git@github.com:ncdc/origin.git","clone_url":"https://github.com/ncdc/origin.git","svn_url":"https://github.com/ncdc/origin","homepage":"https://openshift.github.io","size":110122,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"01722f708a38dbdf1adcf1d4faac6b3578a4255c","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":22442668,"name":"origin","full_name":"openshift/origin","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":false,"url":"https://api.github.com/repos/openshift/origin","forks_url":"https://api.github.com/repos/openshift/origin/forks","keys_url":"https://api.github.com/repos/openshift/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin/teams","hooks_url":"https://api.github.com/repos/openshift/origin/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin/events","assignees_url":"https://api.github.com/repos/openshift/origin/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin/tags","blobs_url":"https://api.github.com/repos/openshift/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin/languages","stargazers_url":"https://api.github.com/repos/openshift/origin/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin/subscription","commits_url":"https://api.github.com/repos/openshift/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin/merges","archive_url":"https://api.github.com/repos/openshift/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin/downloads","issues_url":"https://api.github.com/repos/openshift/origin/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin/releases{/id}","created_at":"2014-07-30T20:04:05Z","updated_at":"2015-06-01T17:36:20Z","pushed_at":"2015-06-02T18:55:36Z","git_url":"git://github.com/openshift/origin.git","ssh_url":"git@github.com:openshift/origin.git","clone_url":"https://github.com/openshift/origin.git","svn_url":"https://github.com/openshift/origin","homepage":"http://www.openshift.org","size":227101,"stargazers_count":451,"watchers_count":451,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":225,"mirror_url":null,"open_issues_count":285,"forks":225,"open_issues":285,"watchers":451,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/2703"},"html":{"href":"https://github.com/openshift/origin/pull/2703"},"issue":{"href":"https://api.github.com/repos/openshift/origin/issues/2703"},"comments":{"href":"https://api.github.com/repos/openshift/origin/issues/2703/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin/pulls/2703/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin/pulls/2703/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin/statuses/b478d4a785a08ea693cb2a8d6f27a801981b9c33"}}}}