{"action":"created","comment":{"url":"https://api.github.com/repos/harvard-cs205/cs205-homework/pulls/comments/44952486","id":44952486,"diff_hunk":"@@ -113,18 +160,36 @@ cpdef update(FLOAT[:, ::1] XY,\n         #\n         # SUBPROBLEM 1: parallelize this loop over 4 threads, with static\n         # scheduling.\n-        for i in range(count):\n-            sub_update(XY, V, R, i, count, Grid, grid_spacing)\n+        # for i in range(count):\n+        for i in prange(count, schedule='static', chunksize=count/4, num_threads=4):\n+            sub_update(XY, V, R, i, count, Grid, grid_spacing, grid_size, locks)\n \n         # update positions\n         #\n         # SUBPROBLEM 1: parallelize this loop over 4 threads (with static\n         #    scheduling).\n         # SUBPROBLEM 2: update the grid values.\n-        for i in range(count):\n+        \n+        # Reinitialize the grid with no balls\n+        Grid[:,:] = -1\n+\n+        # for i in range(count):\n+        for i in prange(count, schedule='static', chunksize=count/4, num_threads=4):\n+            \n             for dim in range(2):\n                 XY[i, dim] += V[i, dim] * t\n-\n+                \n+                # After updating, check to see if any positions are greater than [0,1]\n+                if XY[i, dim] < 0:\n+                    XY[i, dim] = 0\n+                if XY[i,0] > 1:\n+                    XY[i, dim] = 1\n+\n+            # Update the ball positions in the Grid\n+            grid_pos_x = <int> (XY[i, 0]/grid_spacing)\n+            grid_pos_y = <int> (XY[i, 1]/grid_spacing)\n+            Grid[grid_pos_x , grid_pos_y] = i\n+            \n ","path":"HW2/P5/physics.pyx","position":189,"original_position":189,"commit_id":"5a5fd6b04aeeebea21f9707f3add445b92d2c89a","original_commit_id":"5a5fd6b04aeeebea21f9707f3add445b92d2c89a","user":{"login":"chengchengqin","id":14117322,"avatar_url":"https://avatars.githubusercontent.com/u/14117322?v=3","gravatar_id":"","url":"https://api.github.com/users/chengchengqin","html_url":"https://github.com/chengchengqin","followers_url":"https://api.github.com/users/chengchengqin/followers","following_url":"https://api.github.com/users/chengchengqin/following{/other_user}","gists_url":"https://api.github.com/users/chengchengqin/gists{/gist_id}","starred_url":"https://api.github.com/users/chengchengqin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chengchengqin/subscriptions","organizations_url":"https://api.github.com/users/chengchengqin/orgs","repos_url":"https://api.github.com/users/chengchengqin/repos","events_url":"https://api.github.com/users/chengchengqin/events{/privacy}","received_events_url":"https://api.github.com/users/chengchengqin/received_events","type":"User","site_admin":false},"body":"Your codes are written in a clear logic and brief style. It's enjoyable to review your work and I learned a lot from it.","created_at":"2015-11-16T17:17:15Z","updated_at":"2015-11-16T17:17:15Z","html_url":"https://github.com/harvard-cs205/cs205-homework/pull/338#discussion_r44952486","pull_request_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/pulls/338","_links":{"self":{"href":"https://api.github.com/repos/harvard-cs205/cs205-homework/pulls/comments/44952486"},"html":{"href":"https://github.com/harvard-cs205/cs205-homework/pull/338#discussion_r44952486"},"pull_request":{"href":"https://api.github.com/repos/harvard-cs205/cs205-homework/pulls/338"}}},"pull_request":{"url":"https://api.github.com/repos/harvard-cs205/cs205-homework/pulls/338","id":49763620,"html_url":"https://github.com/harvard-cs205/cs205-homework/pull/338","diff_url":"https://github.com/harvard-cs205/cs205-homework/pull/338.diff","patch_url":"https://github.com/harvard-cs205/cs205-homework/pull/338.patch","issue_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/issues/338","number":338,"state":"open","locked":false,"title":"Completed HW2","user":{"login":"patrickday9","id":9629702,"avatar_url":"https://avatars.githubusercontent.com/u/9629702?v=3","gravatar_id":"","url":"https://api.github.com/users/patrickday9","html_url":"https://github.com/patrickday9","followers_url":"https://api.github.com/users/patrickday9/followers","following_url":"https://api.github.com/users/patrickday9/following{/other_user}","gists_url":"https://api.github.com/users/patrickday9/gists{/gist_id}","starred_url":"https://api.github.com/users/patrickday9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patrickday9/subscriptions","organizations_url":"https://api.github.com/users/patrickday9/orgs","repos_url":"https://api.github.com/users/patrickday9/repos","events_url":"https://api.github.com/users/patrickday9/events{/privacy}","received_events_url":"https://api.github.com/users/patrickday9/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-11-04T23:47:18Z","updated_at":"2015-11-16T17:17:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"518c04e990618d49bad46e7cddceff5d0732ad53","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/pulls/338/commits","review_comments_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/pulls/338/comments","review_comment_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/issues/338/comments","statuses_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/statuses/5a5fd6b04aeeebea21f9707f3add445b92d2c89a","head":{"label":"patrickday9:HW2","ref":"HW2","sha":"5a5fd6b04aeeebea21f9707f3add445b92d2c89a","user":{"login":"patrickday9","id":9629702,"avatar_url":"https://avatars.githubusercontent.com/u/9629702?v=3","gravatar_id":"","url":"https://api.github.com/users/patrickday9","html_url":"https://github.com/patrickday9","followers_url":"https://api.github.com/users/patrickday9/followers","following_url":"https://api.github.com/users/patrickday9/following{/other_user}","gists_url":"https://api.github.com/users/patrickday9/gists{/gist_id}","starred_url":"https://api.github.com/users/patrickday9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patrickday9/subscriptions","organizations_url":"https://api.github.com/users/patrickday9/orgs","repos_url":"https://api.github.com/users/patrickday9/repos","events_url":"https://api.github.com/users/patrickday9/events{/privacy}","received_events_url":"https://api.github.com/users/patrickday9/received_events","type":"User","site_admin":false},"repo":{"id":42079088,"name":"cs205-homework","full_name":"patrickday9/cs205-homework","owner":{"login":"patrickday9","id":9629702,"avatar_url":"https://avatars.githubusercontent.com/u/9629702?v=3","gravatar_id":"","url":"https://api.github.com/users/patrickday9","html_url":"https://github.com/patrickday9","followers_url":"https://api.github.com/users/patrickday9/followers","following_url":"https://api.github.com/users/patrickday9/following{/other_user}","gists_url":"https://api.github.com/users/patrickday9/gists{/gist_id}","starred_url":"https://api.github.com/users/patrickday9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patrickday9/subscriptions","organizations_url":"https://api.github.com/users/patrickday9/orgs","repos_url":"https://api.github.com/users/patrickday9/repos","events_url":"https://api.github.com/users/patrickday9/events{/privacy}","received_events_url":"https://api.github.com/users/patrickday9/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/patrickday9/cs205-homework","description":"Part B of HW0","fork":true,"url":"https://api.github.com/repos/patrickday9/cs205-homework","forks_url":"https://api.github.com/repos/patrickday9/cs205-homework/forks","keys_url":"https://api.github.com/repos/patrickday9/cs205-homework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/patrickday9/cs205-homework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/patrickday9/cs205-homework/teams","hooks_url":"https://api.github.com/repos/patrickday9/cs205-homework/hooks","issue_events_url":"https://api.github.com/repos/patrickday9/cs205-homework/issues/events{/number}","events_url":"https://api.github.com/repos/patrickday9/cs205-homework/events","assignees_url":"https://api.github.com/repos/patrickday9/cs205-homework/assignees{/user}","branches_url":"https://api.github.com/repos/patrickday9/cs205-homework/branches{/branch}","tags_url":"https://api.github.com/repos/patrickday9/cs205-homework/tags","blobs_url":"https://api.github.com/repos/patrickday9/cs205-homework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/patrickday9/cs205-homework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/patrickday9/cs205-homework/git/refs{/sha}","trees_url":"https://api.github.com/repos/patrickday9/cs205-homework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/patrickday9/cs205-homework/statuses/{sha}","languages_url":"https://api.github.com/repos/patrickday9/cs205-homework/languages","stargazers_url":"https://api.github.com/repos/patrickday9/cs205-homework/stargazers","contributors_url":"https://api.github.com/repos/patrickday9/cs205-homework/contributors","subscribers_url":"https://api.github.com/repos/patrickday9/cs205-homework/subscribers","subscription_url":"https://api.github.com/repos/patrickday9/cs205-homework/subscription","commits_url":"https://api.github.com/repos/patrickday9/cs205-homework/commits{/sha}","git_commits_url":"https://api.github.com/repos/patrickday9/cs205-homework/git/commits{/sha}","comments_url":"https://api.github.com/repos/patrickday9/cs205-homework/comments{/number}","issue_comment_url":"https://api.github.com/repos/patrickday9/cs205-homework/issues/comments{/number}","contents_url":"https://api.github.com/repos/patrickday9/cs205-homework/contents/{+path}","compare_url":"https://api.github.com/repos/patrickday9/cs205-homework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/patrickday9/cs205-homework/merges","archive_url":"https://api.github.com/repos/patrickday9/cs205-homework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/patrickday9/cs205-homework/downloads","issues_url":"https://api.github.com/repos/patrickday9/cs205-homework/issues{/number}","pulls_url":"https://api.github.com/repos/patrickday9/cs205-homework/pulls{/number}","milestones_url":"https://api.github.com/repos/patrickday9/cs205-homework/milestones{/number}","notifications_url":"https://api.github.com/repos/patrickday9/cs205-homework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/patrickday9/cs205-homework/labels{/name}","releases_url":"https://api.github.com/repos/patrickday9/cs205-homework/releases{/id}","created_at":"2015-09-07T23:27:59Z","updated_at":"2015-09-08T14:04:50Z","pushed_at":"2015-11-04T23:43:19Z","git_url":"git://github.com/patrickday9/cs205-homework.git","ssh_url":"git@github.com:patrickday9/cs205-homework.git","clone_url":"https://github.com/patrickday9/cs205-homework.git","svn_url":"https://github.com/patrickday9/cs205-homework","homepage":"","size":408,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"harvard-cs205:master","ref":"master","sha":"ed6f0167fd1f6097ce9e454c2950c5db00a0c513","user":{"login":"harvard-cs205","id":13456002,"avatar_url":"https://avatars.githubusercontent.com/u/13456002?v=3","gravatar_id":"","url":"https://api.github.com/users/harvard-cs205","html_url":"https://github.com/harvard-cs205","followers_url":"https://api.github.com/users/harvard-cs205/followers","following_url":"https://api.github.com/users/harvard-cs205/following{/other_user}","gists_url":"https://api.github.com/users/harvard-cs205/gists{/gist_id}","starred_url":"https://api.github.com/users/harvard-cs205/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harvard-cs205/subscriptions","organizations_url":"https://api.github.com/users/harvard-cs205/orgs","repos_url":"https://api.github.com/users/harvard-cs205/repos","events_url":"https://api.github.com/users/harvard-cs205/events{/privacy}","received_events_url":"https://api.github.com/users/harvard-cs205/received_events","type":"Organization","site_admin":false},"repo":{"id":40614104,"name":"cs205-homework","full_name":"harvard-cs205/cs205-homework","owner":{"login":"harvard-cs205","id":13456002,"avatar_url":"https://avatars.githubusercontent.com/u/13456002?v=3","gravatar_id":"","url":"https://api.github.com/users/harvard-cs205","html_url":"https://github.com/harvard-cs205","followers_url":"https://api.github.com/users/harvard-cs205/followers","following_url":"https://api.github.com/users/harvard-cs205/following{/other_user}","gists_url":"https://api.github.com/users/harvard-cs205/gists{/gist_id}","starred_url":"https://api.github.com/users/harvard-cs205/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harvard-cs205/subscriptions","organizations_url":"https://api.github.com/users/harvard-cs205/orgs","repos_url":"https://api.github.com/users/harvard-cs205/repos","events_url":"https://api.github.com/users/harvard-cs205/events{/privacy}","received_events_url":"https://api.github.com/users/harvard-cs205/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/harvard-cs205/cs205-homework","description":"","fork":false,"url":"https://api.github.com/repos/harvard-cs205/cs205-homework","forks_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/forks","keys_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/teams","hooks_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/hooks","issue_events_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/issues/events{/number}","events_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/events","assignees_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/assignees{/user}","branches_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/branches{/branch}","tags_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/tags","blobs_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/git/refs{/sha}","trees_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/statuses/{sha}","languages_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/languages","stargazers_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/stargazers","contributors_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/contributors","subscribers_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/subscribers","subscription_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/subscription","commits_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/commits{/sha}","git_commits_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/git/commits{/sha}","comments_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/comments{/number}","issue_comment_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/issues/comments{/number}","contents_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/contents/{+path}","compare_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/merges","archive_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/downloads","issues_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/issues{/number}","pulls_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/pulls{/number}","milestones_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/milestones{/number}","notifications_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/labels{/name}","releases_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/releases{/id}","created_at":"2015-08-12T17:18:15Z","updated_at":"2015-10-21T19:21:28Z","pushed_at":"2015-11-16T16:55:16Z","git_url":"git://github.com/harvard-cs205/cs205-homework.git","ssh_url":"git@github.com:harvard-cs205/cs205-homework.git","clone_url":"https://github.com/harvard-cs205/cs205-homework.git","svn_url":"https://github.com/harvard-cs205/cs205-homework","homepage":null,"size":162893,"stargazers_count":5,"watchers_count":5,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":99,"mirror_url":null,"open_issues_count":353,"forks":99,"open_issues":353,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/harvard-cs205/cs205-homework/pulls/338"},"html":{"href":"https://github.com/harvard-cs205/cs205-homework/pull/338"},"issue":{"href":"https://api.github.com/repos/harvard-cs205/cs205-homework/issues/338"},"comments":{"href":"https://api.github.com/repos/harvard-cs205/cs205-homework/issues/338/comments"},"review_comments":{"href":"https://api.github.com/repos/harvard-cs205/cs205-homework/pulls/338/comments"},"review_comment":{"href":"https://api.github.com/repos/harvard-cs205/cs205-homework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/harvard-cs205/cs205-homework/pulls/338/commits"},"statuses":{"href":"https://api.github.com/repos/harvard-cs205/cs205-homework/statuses/5a5fd6b04aeeebea21f9707f3add445b92d2c89a"}}}}