{"action":"opened","number":4419,"pull_request":{"url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/4419","id":48521144,"html_url":"https://github.com/ets-berkeley-edu/calcentral/pull/4419","diff_url":"https://github.com/ets-berkeley-edu/calcentral/pull/4419.diff","patch_url":"https://github.com/ets-berkeley-edu/calcentral/pull/4419.patch","issue_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/issues/4419","number":4419,"state":"open","locked":false,"title":"CLC-5916 OEC: group cross-listings together; otherwise sort by course code","user":{"login":"paulkerschen","id":2413467,"avatar_url":"https://avatars.githubusercontent.com/u/2413467?v=3","gravatar_id":"","url":"https://api.github.com/users/paulkerschen","html_url":"https://github.com/paulkerschen","followers_url":"https://api.github.com/users/paulkerschen/followers","following_url":"https://api.github.com/users/paulkerschen/following{/other_user}","gists_url":"https://api.github.com/users/paulkerschen/gists{/gist_id}","starred_url":"https://api.github.com/users/paulkerschen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulkerschen/subscriptions","organizations_url":"https://api.github.com/users/paulkerschen/orgs","repos_url":"https://api.github.com/users/paulkerschen/repos","events_url":"https://api.github.com/users/paulkerschen/events{/privacy}","received_events_url":"https://api.github.com/users/paulkerschen/received_events","type":"User","site_admin":false},"body":"https://jira.ets.berkeley.edu/jira/browse/CLC-5916\r\n\r\nThis task was bigger than expected, both because Oec::Worksheet has had no real concept of row order to date, and because the requirement for an intuitive sort on course code was tricky to square with the requirement that cross-listings remain grouped together. `Oec::SisImportSheet#sorted_rows` contains the solution I arrived at, I hope comprehensibly expressed.\r\n\r\nNote that the `@rows` instance variable in Oec::Worksheet has changed from a vanilla Hash to an ActiveSupport::OrderedHash, guaranteeing that rows will come out in the same order they went in. I don't think this will actually change behavior under Ruby 1.9, but it's a safety harness.","created_at":"2015-10-22T22:22:41Z","updated_at":"2015-10-22T22:22:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/4419/commits","review_comments_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/4419/comments","review_comment_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/issues/4419/comments","statuses_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/statuses/a9dae1bbefc582d1e65d0fb1a832fdb848301f5f","head":{"label":"paulkerschen:clc-5916","ref":"clc-5916","sha":"a9dae1bbefc582d1e65d0fb1a832fdb848301f5f","user":{"login":"paulkerschen","id":2413467,"avatar_url":"https://avatars.githubusercontent.com/u/2413467?v=3","gravatar_id":"","url":"https://api.github.com/users/paulkerschen","html_url":"https://github.com/paulkerschen","followers_url":"https://api.github.com/users/paulkerschen/followers","following_url":"https://api.github.com/users/paulkerschen/following{/other_user}","gists_url":"https://api.github.com/users/paulkerschen/gists{/gist_id}","starred_url":"https://api.github.com/users/paulkerschen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulkerschen/subscriptions","organizations_url":"https://api.github.com/users/paulkerschen/orgs","repos_url":"https://api.github.com/users/paulkerschen/repos","events_url":"https://api.github.com/users/paulkerschen/events{/privacy}","received_events_url":"https://api.github.com/users/paulkerschen/received_events","type":"User","site_admin":false},"repo":{"id":26028641,"name":"calcentral","full_name":"paulkerschen/calcentral","owner":{"login":"paulkerschen","id":2413467,"avatar_url":"https://avatars.githubusercontent.com/u/2413467?v=3","gravatar_id":"","url":"https://api.github.com/users/paulkerschen","html_url":"https://github.com/paulkerschen","followers_url":"https://api.github.com/users/paulkerschen/followers","following_url":"https://api.github.com/users/paulkerschen/following{/other_user}","gists_url":"https://api.github.com/users/paulkerschen/gists{/gist_id}","starred_url":"https://api.github.com/users/paulkerschen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulkerschen/subscriptions","organizations_url":"https://api.github.com/users/paulkerschen/orgs","repos_url":"https://api.github.com/users/paulkerschen/repos","events_url":"https://api.github.com/users/paulkerschen/events{/privacy}","received_events_url":"https://api.github.com/users/paulkerschen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/paulkerschen/calcentral","description":"","fork":true,"url":"https://api.github.com/repos/paulkerschen/calcentral","forks_url":"https://api.github.com/repos/paulkerschen/calcentral/forks","keys_url":"https://api.github.com/repos/paulkerschen/calcentral/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paulkerschen/calcentral/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paulkerschen/calcentral/teams","hooks_url":"https://api.github.com/repos/paulkerschen/calcentral/hooks","issue_events_url":"https://api.github.com/repos/paulkerschen/calcentral/issues/events{/number}","events_url":"https://api.github.com/repos/paulkerschen/calcentral/events","assignees_url":"https://api.github.com/repos/paulkerschen/calcentral/assignees{/user}","branches_url":"https://api.github.com/repos/paulkerschen/calcentral/branches{/branch}","tags_url":"https://api.github.com/repos/paulkerschen/calcentral/tags","blobs_url":"https://api.github.com/repos/paulkerschen/calcentral/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paulkerschen/calcentral/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paulkerschen/calcentral/git/refs{/sha}","trees_url":"https://api.github.com/repos/paulkerschen/calcentral/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paulkerschen/calcentral/statuses/{sha}","languages_url":"https://api.github.com/repos/paulkerschen/calcentral/languages","stargazers_url":"https://api.github.com/repos/paulkerschen/calcentral/stargazers","contributors_url":"https://api.github.com/repos/paulkerschen/calcentral/contributors","subscribers_url":"https://api.github.com/repos/paulkerschen/calcentral/subscribers","subscription_url":"https://api.github.com/repos/paulkerschen/calcentral/subscription","commits_url":"https://api.github.com/repos/paulkerschen/calcentral/commits{/sha}","git_commits_url":"https://api.github.com/repos/paulkerschen/calcentral/git/commits{/sha}","comments_url":"https://api.github.com/repos/paulkerschen/calcentral/comments{/number}","issue_comment_url":"https://api.github.com/repos/paulkerschen/calcentral/issues/comments{/number}","contents_url":"https://api.github.com/repos/paulkerschen/calcentral/contents/{+path}","compare_url":"https://api.github.com/repos/paulkerschen/calcentral/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paulkerschen/calcentral/merges","archive_url":"https://api.github.com/repos/paulkerschen/calcentral/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paulkerschen/calcentral/downloads","issues_url":"https://api.github.com/repos/paulkerschen/calcentral/issues{/number}","pulls_url":"https://api.github.com/repos/paulkerschen/calcentral/pulls{/number}","milestones_url":"https://api.github.com/repos/paulkerschen/calcentral/milestones{/number}","notifications_url":"https://api.github.com/repos/paulkerschen/calcentral/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paulkerschen/calcentral/labels{/name}","releases_url":"https://api.github.com/repos/paulkerschen/calcentral/releases{/id}","created_at":"2014-10-31T18:41:02Z","updated_at":"2015-04-27T23:33:22Z","pushed_at":"2015-10-22T22:09:18Z","git_url":"git://github.com/paulkerschen/calcentral.git","ssh_url":"git@github.com:paulkerschen/calcentral.git","clone_url":"https://github.com/paulkerschen/calcentral.git","svn_url":"https://github.com/paulkerschen/calcentral","homepage":"https://calcentral.berkeley.edu","size":19387,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"mirror"}},"base":{"label":"ets-berkeley-edu:master","ref":"master","sha":"be67f47d981d67b1bb12cf7818a422f8c101f15a","user":{"login":"ets-berkeley-edu","id":283538,"avatar_url":"https://avatars.githubusercontent.com/u/283538?v=3","gravatar_id":"","url":"https://api.github.com/users/ets-berkeley-edu","html_url":"https://github.com/ets-berkeley-edu","followers_url":"https://api.github.com/users/ets-berkeley-edu/followers","following_url":"https://api.github.com/users/ets-berkeley-edu/following{/other_user}","gists_url":"https://api.github.com/users/ets-berkeley-edu/gists{/gist_id}","starred_url":"https://api.github.com/users/ets-berkeley-edu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ets-berkeley-edu/subscriptions","organizations_url":"https://api.github.com/users/ets-berkeley-edu/orgs","repos_url":"https://api.github.com/users/ets-berkeley-edu/repos","events_url":"https://api.github.com/users/ets-berkeley-edu/events{/privacy}","received_events_url":"https://api.github.com/users/ets-berkeley-edu/received_events","type":"Organization","site_admin":false},"repo":{"id":5483921,"name":"calcentral","full_name":"ets-berkeley-edu/calcentral","owner":{"login":"ets-berkeley-edu","id":283538,"avatar_url":"https://avatars.githubusercontent.com/u/283538?v=3","gravatar_id":"","url":"https://api.github.com/users/ets-berkeley-edu","html_url":"https://github.com/ets-berkeley-edu","followers_url":"https://api.github.com/users/ets-berkeley-edu/followers","following_url":"https://api.github.com/users/ets-berkeley-edu/following{/other_user}","gists_url":"https://api.github.com/users/ets-berkeley-edu/gists{/gist_id}","starred_url":"https://api.github.com/users/ets-berkeley-edu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ets-berkeley-edu/subscriptions","organizations_url":"https://api.github.com/users/ets-berkeley-edu/orgs","repos_url":"https://api.github.com/users/ets-berkeley-edu/repos","events_url":"https://api.github.com/users/ets-berkeley-edu/events{/privacy}","received_events_url":"https://api.github.com/users/ets-berkeley-edu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ets-berkeley-edu/calcentral","description":"","fork":false,"url":"https://api.github.com/repos/ets-berkeley-edu/calcentral","forks_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/forks","keys_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/teams","hooks_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/hooks","issue_events_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/issues/events{/number}","events_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/events","assignees_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/assignees{/user}","branches_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/branches{/branch}","tags_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/tags","blobs_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/git/refs{/sha}","trees_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/statuses/{sha}","languages_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/languages","stargazers_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/stargazers","contributors_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/contributors","subscribers_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/subscribers","subscription_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/subscription","commits_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/commits{/sha}","git_commits_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/git/commits{/sha}","comments_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/comments{/number}","issue_comment_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/issues/comments{/number}","contents_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/contents/{+path}","compare_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/merges","archive_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/downloads","issues_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/issues{/number}","pulls_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls{/number}","milestones_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/milestones{/number}","notifications_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/labels{/name}","releases_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/releases{/id}","created_at":"2012-08-20T16:45:39Z","updated_at":"2015-10-20T05:59:30Z","pushed_at":"2015-10-22T20:10:31Z","git_url":"git://github.com/ets-berkeley-edu/calcentral.git","ssh_url":"git@github.com:ets-berkeley-edu/calcentral.git","clone_url":"https://github.com/ets-berkeley-edu/calcentral.git","svn_url":"https://github.com/ets-berkeley-edu/calcentral","homepage":"https://calcentral.berkeley.edu","size":38846,"stargazers_count":50,"watchers_count":50,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":56,"mirror_url":null,"open_issues_count":2,"forks":56,"open_issues":2,"watchers":50,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/4419"},"html":{"href":"https://github.com/ets-berkeley-edu/calcentral/pull/4419"},"issue":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/issues/4419"},"comments":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/issues/4419/comments"},"review_comments":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/4419/comments"},"review_comment":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/4419/commits"},"statuses":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/statuses/a9dae1bbefc582d1e65d0fb1a832fdb848301f5f"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":106,"deletions":22,"changed_files":11}}