{"action":"opened","number":1,"pull_request":{"url":"https://api.github.com/repos/genebean/genebean-firewalld2iptables/pulls/1","id":50366463,"html_url":"https://github.com/genebean/genebean-firewalld2iptables/pull/1","diff_url":"https://github.com/genebean/genebean-firewalld2iptables/pull/1.diff","patch_url":"https://github.com/genebean/genebean-firewalld2iptables/pull/1.patch","issue_url":"https://api.github.com/repos/genebean/genebean-firewalld2iptables/issues/1","number":1,"state":"open","locked":false,"title":"Fixes to support Puppet 4","user":{"login":"mattock","id":1554045,"avatar_url":"https://avatars.githubusercontent.com/u/1554045?v=3","gravatar_id":"","url":"https://api.github.com/users/mattock","html_url":"https://github.com/mattock","followers_url":"https://api.github.com/users/mattock/followers","following_url":"https://api.github.com/users/mattock/following{/other_user}","gists_url":"https://api.github.com/users/mattock/gists{/gist_id}","starred_url":"https://api.github.com/users/mattock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattock/subscriptions","organizations_url":"https://api.github.com/users/mattock/orgs","repos_url":"https://api.github.com/users/mattock/repos","events_url":"https://api.github.com/users/mattock/events{/privacy}","received_events_url":"https://api.github.com/users/mattock/received_events","type":"User","site_admin":false},"body":"Without these changes both of the tests fail silently. In Puppet 4 quoting is needed to make sure that comparisons are done between string values.","created_at":"2015-11-11T10:06:52Z","updated_at":"2015-11-11T10:06:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/genebean/genebean-firewalld2iptables/pulls/1/commits","review_comments_url":"https://api.github.com/repos/genebean/genebean-firewalld2iptables/pulls/1/comments","review_comment_url":"https://api.github.com/repos/genebean/genebean-firewalld2iptables/pulls/comments{/number}","comments_url":"https://api.github.com/repos/genebean/genebean-firewalld2iptables/issues/1/comments","statuses_url":"https://api.github.com/repos/genebean/genebean-firewalld2iptables/statuses/bf968634e83534db382ad8c06d5a9a6aec7b91d4","head":{"label":"Puppet-Finland:master","ref":"master","sha":"bf968634e83534db382ad8c06d5a9a6aec7b91d4","user":{"login":"Puppet-Finland","id":3041665,"avatar_url":"https://avatars.githubusercontent.com/u/3041665?v=3","gravatar_id":"","url":"https://api.github.com/users/Puppet-Finland","html_url":"https://github.com/Puppet-Finland","followers_url":"https://api.github.com/users/Puppet-Finland/followers","following_url":"https://api.github.com/users/Puppet-Finland/following{/other_user}","gists_url":"https://api.github.com/users/Puppet-Finland/gists{/gist_id}","starred_url":"https://api.github.com/users/Puppet-Finland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Puppet-Finland/subscriptions","organizations_url":"https://api.github.com/users/Puppet-Finland/orgs","repos_url":"https://api.github.com/users/Puppet-Finland/repos","events_url":"https://api.github.com/users/Puppet-Finland/events{/privacy}","received_events_url":"https://api.github.com/users/Puppet-Finland/received_events","type":"Organization","site_admin":false},"repo":{"id":36056823,"name":"genebean-firewalld2iptables","full_name":"Puppet-Finland/genebean-firewalld2iptables","owner":{"login":"Puppet-Finland","id":3041665,"avatar_url":"https://avatars.githubusercontent.com/u/3041665?v=3","gravatar_id":"","url":"https://api.github.com/users/Puppet-Finland","html_url":"https://github.com/Puppet-Finland","followers_url":"https://api.github.com/users/Puppet-Finland/followers","following_url":"https://api.github.com/users/Puppet-Finland/following{/other_user}","gists_url":"https://api.github.com/users/Puppet-Finland/gists{/gist_id}","starred_url":"https://api.github.com/users/Puppet-Finland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Puppet-Finland/subscriptions","organizations_url":"https://api.github.com/users/Puppet-Finland/orgs","repos_url":"https://api.github.com/users/Puppet-Finland/repos","events_url":"https://api.github.com/users/Puppet-Finland/events{/privacy}","received_events_url":"https://api.github.com/users/Puppet-Finland/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Puppet-Finland/genebean-firewalld2iptables","description":"This module takes care of performing the conversion described at https://access.redhat.com/documentation/en-US/Red_Hat_Enterprise_Linux/7/html/Security_Guide/sec-Using_Firewalls.html#sec-Using_iptables","fork":true,"url":"https://api.github.com/repos/Puppet-Finland/genebean-firewalld2iptables","forks_url":"https://api.github.com/repos/Puppet-Finland/genebean-firewalld2iptables/forks","keys_url":"https://api.github.com/repos/Puppet-Finland/genebean-firewalld2iptables/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Puppet-Finland/genebean-firewalld2iptables/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Puppet-Finland/genebean-firewalld2iptables/teams","hooks_url":"https://api.github.com/repos/Puppet-Finland/genebean-firewalld2iptables/hooks","issue_events_url":"https://api.github.com/repos/Puppet-Finland/genebean-firewalld2iptables/issues/events{/number}","events_url":"https://api.github.com/repos/Puppet-Finland/genebean-firewalld2iptables/events","assignees_url":"https://api.github.com/repos/Puppet-Finland/genebean-firewalld2iptables/assignees{/user}","branches_url":"https://api.github.com/repos/Puppet-Finland/genebean-firewalld2iptables/branches{/branch}","tags_url":"https://api.github.com/repos/Puppet-Finland/genebean-firewalld2iptables/tags","blobs_url":"https://api.github.com/repos/Puppet-Finland/genebean-firewalld2iptables/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Puppet-Finland/genebean-firewalld2iptables/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Puppet-Finland/genebean-firewalld2iptables/git/refs{/sha}","trees_url":"https://api.github.com/repos/Puppet-Finland/genebean-firewalld2iptables/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Puppet-Finland/genebean-firewalld2iptables/statuses/{sha}","languages_url":"https://api.github.com/repos/Puppet-Finland/genebean-firewalld2iptables/languages","stargazers_url":"https://api.github.com/repos/Puppet-Finland/genebean-firewalld2iptables/stargazers","contributors_url":"https://api.github.com/repos/Puppet-Finland/genebean-firewalld2iptables/contributors","subscribers_url":"https://api.github.com/repos/Puppet-Finland/genebean-firewalld2iptables/subscribers","subscription_url":"https://api.github.com/repos/Puppet-Finland/genebean-firewalld2iptables/subscription","commits_url":"https://api.github.com/repos/Puppet-Finland/genebean-firewalld2iptables/commits{/sha}","git_commits_url":"https://api.github.com/repos/Puppet-Finland/genebean-firewalld2iptables/git/commits{/sha}","comments_url":"https://api.github.com/repos/Puppet-Finland/genebean-firewalld2iptables/comments{/number}","issue_comment_url":"https://api.github.com/repos/Puppet-Finland/genebean-firewalld2iptables/issues/comments{/number}","contents_url":"https://api.github.com/repos/Puppet-Finland/genebean-firewalld2iptables/contents/{+path}","compare_url":"https://api.github.com/repos/Puppet-Finland/genebean-firewalld2iptables/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Puppet-Finland/genebean-firewalld2iptables/merges","archive_url":"https://api.github.com/repos/Puppet-Finland/genebean-firewalld2iptables/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Puppet-Finland/genebean-firewalld2iptables/downloads","issues_url":"https://api.github.com/repos/Puppet-Finland/genebean-firewalld2iptables/issues{/number}","pulls_url":"https://api.github.com/repos/Puppet-Finland/genebean-firewalld2iptables/pulls{/number}","milestones_url":"https://api.github.com/repos/Puppet-Finland/genebean-firewalld2iptables/milestones{/number}","notifications_url":"https://api.github.com/repos/Puppet-Finland/genebean-firewalld2iptables/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Puppet-Finland/genebean-firewalld2iptables/labels{/name}","releases_url":"https://api.github.com/repos/Puppet-Finland/genebean-firewalld2iptables/releases{/id}","created_at":"2015-05-22T06:48:14Z","updated_at":"2015-05-22T06:48:14Z","pushed_at":"2015-11-11T10:03:02Z","git_url":"git://github.com/Puppet-Finland/genebean-firewalld2iptables.git","ssh_url":"git@github.com:Puppet-Finland/genebean-firewalld2iptables.git","clone_url":"https://github.com/Puppet-Finland/genebean-firewalld2iptables.git","svn_url":"https://github.com/Puppet-Finland/genebean-firewalld2iptables","homepage":null,"size":91,"stargazers_count":0,"watchers_count":0,"language":"Puppet","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"genebean:master","ref":"master","sha":"db106bb9759d492466b45e4509e3d26e1aefd4f2","user":{"login":"genebean","id":966789,"avatar_url":"https://avatars.githubusercontent.com/u/966789?v=3","gravatar_id":"","url":"https://api.github.com/users/genebean","html_url":"https://github.com/genebean","followers_url":"https://api.github.com/users/genebean/followers","following_url":"https://api.github.com/users/genebean/following{/other_user}","gists_url":"https://api.github.com/users/genebean/gists{/gist_id}","starred_url":"https://api.github.com/users/genebean/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/genebean/subscriptions","organizations_url":"https://api.github.com/users/genebean/orgs","repos_url":"https://api.github.com/users/genebean/repos","events_url":"https://api.github.com/users/genebean/events{/privacy}","received_events_url":"https://api.github.com/users/genebean/received_events","type":"User","site_admin":false},"repo":{"id":29166202,"name":"genebean-firewalld2iptables","full_name":"genebean/genebean-firewalld2iptables","owner":{"login":"genebean","id":966789,"avatar_url":"https://avatars.githubusercontent.com/u/966789?v=3","gravatar_id":"","url":"https://api.github.com/users/genebean","html_url":"https://github.com/genebean","followers_url":"https://api.github.com/users/genebean/followers","following_url":"https://api.github.com/users/genebean/following{/other_user}","gists_url":"https://api.github.com/users/genebean/gists{/gist_id}","starred_url":"https://api.github.com/users/genebean/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/genebean/subscriptions","organizations_url":"https://api.github.com/users/genebean/orgs","repos_url":"https://api.github.com/users/genebean/repos","events_url":"https://api.github.com/users/genebean/events{/privacy}","received_events_url":"https://api.github.com/users/genebean/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/genebean/genebean-firewalld2iptables","description":"This module takes care of performing the conversion described at https://access.redhat.com/documentation/en-US/Red_Hat_Enterprise_Linux/7/html/Security_Guide/sec-Using_Firewalls.html#sec-Using_iptables","fork":false,"url":"https://api.github.com/repos/genebean/genebean-firewalld2iptables","forks_url":"https://api.github.com/repos/genebean/genebean-firewalld2iptables/forks","keys_url":"https://api.github.com/repos/genebean/genebean-firewalld2iptables/keys{/key_id}","collaborators_url":"https://api.github.com/repos/genebean/genebean-firewalld2iptables/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/genebean/genebean-firewalld2iptables/teams","hooks_url":"https://api.github.com/repos/genebean/genebean-firewalld2iptables/hooks","issue_events_url":"https://api.github.com/repos/genebean/genebean-firewalld2iptables/issues/events{/number}","events_url":"https://api.github.com/repos/genebean/genebean-firewalld2iptables/events","assignees_url":"https://api.github.com/repos/genebean/genebean-firewalld2iptables/assignees{/user}","branches_url":"https://api.github.com/repos/genebean/genebean-firewalld2iptables/branches{/branch}","tags_url":"https://api.github.com/repos/genebean/genebean-firewalld2iptables/tags","blobs_url":"https://api.github.com/repos/genebean/genebean-firewalld2iptables/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/genebean/genebean-firewalld2iptables/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/genebean/genebean-firewalld2iptables/git/refs{/sha}","trees_url":"https://api.github.com/repos/genebean/genebean-firewalld2iptables/git/trees{/sha}","statuses_url":"https://api.github.com/repos/genebean/genebean-firewalld2iptables/statuses/{sha}","languages_url":"https://api.github.com/repos/genebean/genebean-firewalld2iptables/languages","stargazers_url":"https://api.github.com/repos/genebean/genebean-firewalld2iptables/stargazers","contributors_url":"https://api.github.com/repos/genebean/genebean-firewalld2iptables/contributors","subscribers_url":"https://api.github.com/repos/genebean/genebean-firewalld2iptables/subscribers","subscription_url":"https://api.github.com/repos/genebean/genebean-firewalld2iptables/subscription","commits_url":"https://api.github.com/repos/genebean/genebean-firewalld2iptables/commits{/sha}","git_commits_url":"https://api.github.com/repos/genebean/genebean-firewalld2iptables/git/commits{/sha}","comments_url":"https://api.github.com/repos/genebean/genebean-firewalld2iptables/comments{/number}","issue_comment_url":"https://api.github.com/repos/genebean/genebean-firewalld2iptables/issues/comments{/number}","contents_url":"https://api.github.com/repos/genebean/genebean-firewalld2iptables/contents/{+path}","compare_url":"https://api.github.com/repos/genebean/genebean-firewalld2iptables/compare/{base}...{head}","merges_url":"https://api.github.com/repos/genebean/genebean-firewalld2iptables/merges","archive_url":"https://api.github.com/repos/genebean/genebean-firewalld2iptables/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/genebean/genebean-firewalld2iptables/downloads","issues_url":"https://api.github.com/repos/genebean/genebean-firewalld2iptables/issues{/number}","pulls_url":"https://api.github.com/repos/genebean/genebean-firewalld2iptables/pulls{/number}","milestones_url":"https://api.github.com/repos/genebean/genebean-firewalld2iptables/milestones{/number}","notifications_url":"https://api.github.com/repos/genebean/genebean-firewalld2iptables/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/genebean/genebean-firewalld2iptables/labels{/name}","releases_url":"https://api.github.com/repos/genebean/genebean-firewalld2iptables/releases{/id}","created_at":"2015-01-13T01:22:59Z","updated_at":"2015-04-23T18:28:32Z","pushed_at":"2015-01-13T02:24:34Z","git_url":"git://github.com/genebean/genebean-firewalld2iptables.git","ssh_url":"git@github.com:genebean/genebean-firewalld2iptables.git","clone_url":"https://github.com/genebean/genebean-firewalld2iptables.git","svn_url":"https://github.com/genebean/genebean-firewalld2iptables","homepage":null,"size":160,"stargazers_count":1,"watchers_count":1,"language":"Puppet","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/genebean/genebean-firewalld2iptables/pulls/1"},"html":{"href":"https://github.com/genebean/genebean-firewalld2iptables/pull/1"},"issue":{"href":"https://api.github.com/repos/genebean/genebean-firewalld2iptables/issues/1"},"comments":{"href":"https://api.github.com/repos/genebean/genebean-firewalld2iptables/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/genebean/genebean-firewalld2iptables/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/genebean/genebean-firewalld2iptables/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/genebean/genebean-firewalld2iptables/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/genebean/genebean-firewalld2iptables/statuses/bf968634e83534db382ad8c06d5a9a6aec7b91d4"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":2,"deletions":2,"changed_files":1}}