{"action":"created","issue":{"url":"https://api.github.com/repos/docker/machine/issues/528","labels_url":"https://api.github.com/repos/docker/machine/issues/528/labels{/name}","comments_url":"https://api.github.com/repos/docker/machine/issues/528/comments","events_url":"https://api.github.com/repos/docker/machine/issues/528/events","html_url":"https://github.com/docker/machine/pull/528","id":57307937,"number":528,"title":"Detect vboxmanage error conditions and pass those on as errors","user":{"login":"SvenDowideit","id":28492,"avatar_url":"https://avatars.githubusercontent.com/u/28492?v=3","gravatar_id":"","url":"https://api.github.com/users/SvenDowideit","html_url":"https://github.com/SvenDowideit","followers_url":"https://api.github.com/users/SvenDowideit/followers","following_url":"https://api.github.com/users/SvenDowideit/following{/other_user}","gists_url":"https://api.github.com/users/SvenDowideit/gists{/gist_id}","starred_url":"https://api.github.com/users/SvenDowideit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SvenDowideit/subscriptions","organizations_url":"https://api.github.com/users/SvenDowideit/orgs","repos_url":"https://api.github.com/users/SvenDowideit/repos","events_url":"https://api.github.com/users/SvenDowideit/events{/privacy}","received_events_url":"https://api.github.com/users/SvenDowideit/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/docker/machine/labels/driver:virtualbox","name":"driver:virtualbox","color":"bfdadc"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-02-11T12:08:03Z","updated_at":"2015-02-11T22:47:18Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/docker/machine/pulls/528","html_url":"https://github.com/docker/machine/pull/528","diff_url":"https://github.com/docker/machine/pull/528.diff","patch_url":"https://github.com/docker/machine/pull/528.patch"},"body":"This is a follow on from #527 (and so contains it, and will need rebasing after)\r\n\r\nVboxManage does not set its return code for all error conditions. The biggest example is if VT-x is off, or worse, if Hyper-V is on, and this vbox can't work.\r\n\r\nbefore this patch:\r\n\r\n```\r\nsvend_000@BIG ~\r\n$ ./docker-machine_windows-amd64.exe --debug start finder\r\n←[34mDEBU←[0m[0000] executing: C:\\Program Files\\Oracle\\VirtualBox\\VBoxManage.exe\r\n startvm finder --type headless\r\nWaiting for VM \"finder\" to power on...\r\nVBoxManage.exe: error: VT-x is not available. (VERR_VMX_NO_VMX)\r\nVBoxManage.exe: error: Details: code E_FAIL (0x80004005), component Console, int\r\nerface IConsole\r\n←[34mINFO←[0m[0003] Waiting for VM to start...\r\n```\r\nwill wait forever - this doesn't happen in boot2docker-cli, because we recheck the vm status after ever operation - ie, we don't trust what vbox tells us. \r\n\r\nafter this patch:\r\n\r\n```\r\nsvend_000@BIG ~\r\n$ ./docker-machine_windows-amd64.exe --debug start finder\r\n←[34mDEBU←[0m[0000] executing: C:\\Program Files\\Oracle\\VirtualBox\\VBoxManage.exe\r\n startvm finder --type headless\r\n←[34mDEBU←[0m[0003] STDOUT: Waiting for VM \"finder\" to power on...\r\n\r\n←[34mDEBU←[0m[0003] STDERR: VBoxManage.exe: error: VT-x is not available. (VERR_\r\nVMX_NO_VMX)\r\nVBoxManage.exe: error: Details: code E_FAIL (0x80004005), component Console, int\r\nerface IConsole\r\n\r\n←[31mFATA←[0m[0003] C:\\Program Files\\Oracle\\VirtualBox\\VBoxManage.exe startvm fi\r\nnder --type headless failed: VBoxManage.exe: error: VT-x is not available. (VERR\r\n_VMX_NO_VMX)\r\nVBoxManage.exe: error: Details: code E_FAIL (0x80004005), component Console, int\r\nerface IConsole\r\n\r\n\r\nsvend_000@BIG ~\r\n$ ./docker-machine_windows-amd64.exe start finder\r\n←[31mFATA←[0m[0003] C:\\Program Files\\Oracle\\VirtualBox\\VBoxManage.exe startvm fi\r\nnder --type headless failed: VBoxManage.exe: error: VT-x is not available. (VERR\r\n_VMX_NO_VMX)\r\nVBoxManage.exe: error: Details: code E_FAIL (0x80004005), component Console, int\r\nerface IConsole\r\n\r\n\r\nsvend_000@BIG ~\r\n$\r\n```\r\nso now machine knows there's a problem, exits and reports the problem to the user.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/docker/machine/issues/comments/73981826","html_url":"https://github.com/docker/machine/pull/528#issuecomment-73981826","issue_url":"https://api.github.com/repos/docker/machine/issues/528","id":73981826,"user":{"login":"SvenDowideit","id":28492,"avatar_url":"https://avatars.githubusercontent.com/u/28492?v=3","gravatar_id":"","url":"https://api.github.com/users/SvenDowideit","html_url":"https://github.com/SvenDowideit","followers_url":"https://api.github.com/users/SvenDowideit/followers","following_url":"https://api.github.com/users/SvenDowideit/following{/other_user}","gists_url":"https://api.github.com/users/SvenDowideit/gists{/gist_id}","starred_url":"https://api.github.com/users/SvenDowideit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SvenDowideit/subscriptions","organizations_url":"https://api.github.com/users/SvenDowideit/orgs","repos_url":"https://api.github.com/users/SvenDowideit/repos","events_url":"https://api.github.com/users/SvenDowideit/events{/privacy}","received_events_url":"https://api.github.com/users/SvenDowideit/received_events","type":"User","site_admin":false},"created_at":"2015-02-11T22:47:18Z","updated_at":"2015-02-11T22:47:18Z","body":"@ehazlett p'TAL"}}