{"action":"created","comment":{"url":"https://api.github.com/repos/kframework/k/pulls/comments/47651511","id":47651511,"diff_hunk":"@@ -89,7 +89,7 @@ public InitializeRewriter(\n \n     @Override\n     public synchronized Rewriter apply(Module module) {\n-        TermContext initializingContext = TermContext.builder(new GlobalContext(fs, javaOptions, globalOptions, krunOptions, kem, smtOptions, hookProvider, files, Stage.INITIALIZING))","path":"java-backend/src/main/java/org/kframework/backend/java/symbolic/InitializeRewriter.java","position":4,"original_position":4,"commit_id":"0f611c83c23300f18dce336ec3272347b8b984c7","original_commit_id":"0f611c83c23300f18dce336ec3272347b8b984c7","user":{"login":"dwightguth","id":5104541,"avatar_url":"https://avatars.githubusercontent.com/u/5104541?v=3","gravatar_id":"","url":"https://api.github.com/users/dwightguth","html_url":"https://github.com/dwightguth","followers_url":"https://api.github.com/users/dwightguth/followers","following_url":"https://api.github.com/users/dwightguth/following{/other_user}","gists_url":"https://api.github.com/users/dwightguth/gists{/gist_id}","starred_url":"https://api.github.com/users/dwightguth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwightguth/subscriptions","organizations_url":"https://api.github.com/users/dwightguth/orgs","repos_url":"https://api.github.com/users/dwightguth/repos","events_url":"https://api.github.com/users/dwightguth/events{/privacy}","received_events_url":"https://api.github.com/users/dwightguth/received_events","type":"User","site_admin":false},"body":"This is actually not safe though. We do partial evaluation during the initialization pass which is why the handling for impure functions was done in the first place. There was a bug wherein impure functions with ground arguments applied statically instead of at every rule application. Unless you can persuade me that this case is handled somehow, this is not harmless at all and will in fact break the C semantics.","created_at":"2015-12-15T15:34:52Z","updated_at":"2015-12-15T15:34:52Z","html_url":"https://github.com/kframework/k/pull/1906#discussion_r47651511","pull_request_url":"https://api.github.com/repos/kframework/k/pulls/1906","_links":{"self":{"href":"https://api.github.com/repos/kframework/k/pulls/comments/47651511"},"html":{"href":"https://github.com/kframework/k/pull/1906#discussion_r47651511"},"pull_request":{"href":"https://api.github.com/repos/kframework/k/pulls/1906"}}},"pull_request":{"url":"https://api.github.com/repos/kframework/k/pulls/1906","id":53503383,"html_url":"https://github.com/kframework/k/pull/1906","diff_url":"https://github.com/kframework/k/pull/1906.diff","patch_url":"https://github.com/kframework/k/pull/1906.patch","issue_url":"https://api.github.com/repos/kframework/k/issues/1906","number":1906,"state":"open","locked":false,"title":"unification with kore","user":{"login":"cos","id":37514,"avatar_url":"https://avatars.githubusercontent.com/u/37514?v=3","gravatar_id":"","url":"https://api.github.com/users/cos","html_url":"https://github.com/cos","followers_url":"https://api.github.com/users/cos/followers","following_url":"https://api.github.com/users/cos/following{/other_user}","gists_url":"https://api.github.com/users/cos/gists{/gist_id}","starred_url":"https://api.github.com/users/cos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cos/subscriptions","organizations_url":"https://api.github.com/users/cos/orgs","repos_url":"https://api.github.com/users/cos/repos","events_url":"https://api.github.com/users/cos/events{/privacy}","received_events_url":"https://api.github.com/users/cos/received_events","type":"User","site_admin":false},"body":"this is a clone of @andreistefanescu's code in #1887 -- moved here so @laurayuwen and I can commit as well","created_at":"2015-12-13T16:24:25Z","updated_at":"2015-12-15T15:34:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7b15287d4f59ecab9194c06739be1142aa16d56f","assignee":{"login":"laurayuwen","id":3274406,"avatar_url":"https://avatars.githubusercontent.com/u/3274406?v=3","gravatar_id":"","url":"https://api.github.com/users/laurayuwen","html_url":"https://github.com/laurayuwen","followers_url":"https://api.github.com/users/laurayuwen/followers","following_url":"https://api.github.com/users/laurayuwen/following{/other_user}","gists_url":"https://api.github.com/users/laurayuwen/gists{/gist_id}","starred_url":"https://api.github.com/users/laurayuwen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laurayuwen/subscriptions","organizations_url":"https://api.github.com/users/laurayuwen/orgs","repos_url":"https://api.github.com/users/laurayuwen/repos","events_url":"https://api.github.com/users/laurayuwen/events{/privacy}","received_events_url":"https://api.github.com/users/laurayuwen/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/kframework/k/pulls/1906/commits","review_comments_url":"https://api.github.com/repos/kframework/k/pulls/1906/comments","review_comment_url":"https://api.github.com/repos/kframework/k/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kframework/k/issues/1906/comments","statuses_url":"https://api.github.com/repos/kframework/k/statuses/0f611c83c23300f18dce336ec3272347b8b984c7","head":{"label":"kframework:feature/unification-with-kore","ref":"feature/unification-with-kore","sha":"0f611c83c23300f18dce336ec3272347b8b984c7","user":{"login":"kframework","id":5104335,"avatar_url":"https://avatars.githubusercontent.com/u/5104335?v=3","gravatar_id":"","url":"https://api.github.com/users/kframework","html_url":"https://github.com/kframework","followers_url":"https://api.github.com/users/kframework/followers","following_url":"https://api.github.com/users/kframework/following{/other_user}","gists_url":"https://api.github.com/users/kframework/gists{/gist_id}","starred_url":"https://api.github.com/users/kframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kframework/subscriptions","organizations_url":"https://api.github.com/users/kframework/orgs","repos_url":"https://api.github.com/users/kframework/repos","events_url":"https://api.github.com/users/kframework/events{/privacy}","received_events_url":"https://api.github.com/users/kframework/received_events","type":"Organization","site_admin":false},"repo":{"id":11711223,"name":"k","full_name":"kframework/k","owner":{"login":"kframework","id":5104335,"avatar_url":"https://avatars.githubusercontent.com/u/5104335?v=3","gravatar_id":"","url":"https://api.github.com/users/kframework","html_url":"https://github.com/kframework","followers_url":"https://api.github.com/users/kframework/followers","following_url":"https://api.github.com/users/kframework/following{/other_user}","gists_url":"https://api.github.com/users/kframework/gists{/gist_id}","starred_url":"https://api.github.com/users/kframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kframework/subscriptions","organizations_url":"https://api.github.com/users/kframework/orgs","repos_url":"https://api.github.com/users/kframework/repos","events_url":"https://api.github.com/users/kframework/events{/privacy}","received_events_url":"https://api.github.com/users/kframework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kframework/k","description":"The K tools","fork":false,"url":"https://api.github.com/repos/kframework/k","forks_url":"https://api.github.com/repos/kframework/k/forks","keys_url":"https://api.github.com/repos/kframework/k/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kframework/k/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kframework/k/teams","hooks_url":"https://api.github.com/repos/kframework/k/hooks","issue_events_url":"https://api.github.com/repos/kframework/k/issues/events{/number}","events_url":"https://api.github.com/repos/kframework/k/events","assignees_url":"https://api.github.com/repos/kframework/k/assignees{/user}","branches_url":"https://api.github.com/repos/kframework/k/branches{/branch}","tags_url":"https://api.github.com/repos/kframework/k/tags","blobs_url":"https://api.github.com/repos/kframework/k/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kframework/k/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kframework/k/git/refs{/sha}","trees_url":"https://api.github.com/repos/kframework/k/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kframework/k/statuses/{sha}","languages_url":"https://api.github.com/repos/kframework/k/languages","stargazers_url":"https://api.github.com/repos/kframework/k/stargazers","contributors_url":"https://api.github.com/repos/kframework/k/contributors","subscribers_url":"https://api.github.com/repos/kframework/k/subscribers","subscription_url":"https://api.github.com/repos/kframework/k/subscription","commits_url":"https://api.github.com/repos/kframework/k/commits{/sha}","git_commits_url":"https://api.github.com/repos/kframework/k/git/commits{/sha}","comments_url":"https://api.github.com/repos/kframework/k/comments{/number}","issue_comment_url":"https://api.github.com/repos/kframework/k/issues/comments{/number}","contents_url":"https://api.github.com/repos/kframework/k/contents/{+path}","compare_url":"https://api.github.com/repos/kframework/k/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kframework/k/merges","archive_url":"https://api.github.com/repos/kframework/k/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kframework/k/downloads","issues_url":"https://api.github.com/repos/kframework/k/issues{/number}","pulls_url":"https://api.github.com/repos/kframework/k/pulls{/number}","milestones_url":"https://api.github.com/repos/kframework/k/milestones{/number}","notifications_url":"https://api.github.com/repos/kframework/k/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kframework/k/labels{/name}","releases_url":"https://api.github.com/repos/kframework/k/releases{/id}","created_at":"2013-07-27T21:22:53Z","updated_at":"2015-12-13T10:54:50Z","pushed_at":"2015-12-15T15:00:49Z","git_url":"git://github.com/kframework/k.git","ssh_url":"git@github.com:kframework/k.git","clone_url":"https://github.com/kframework/k.git","svn_url":"https://github.com/kframework/k","homepage":"kframework.org","size":272045,"stargazers_count":73,"watchers_count":73,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":55,"mirror_url":null,"open_issues_count":263,"forks":55,"open_issues":263,"watchers":73,"default_branch":"master"}},"base":{"label":"kframework:master","ref":"master","sha":"3c3543de013532d6e2fd5f919796e896b0f1823f","user":{"login":"kframework","id":5104335,"avatar_url":"https://avatars.githubusercontent.com/u/5104335?v=3","gravatar_id":"","url":"https://api.github.com/users/kframework","html_url":"https://github.com/kframework","followers_url":"https://api.github.com/users/kframework/followers","following_url":"https://api.github.com/users/kframework/following{/other_user}","gists_url":"https://api.github.com/users/kframework/gists{/gist_id}","starred_url":"https://api.github.com/users/kframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kframework/subscriptions","organizations_url":"https://api.github.com/users/kframework/orgs","repos_url":"https://api.github.com/users/kframework/repos","events_url":"https://api.github.com/users/kframework/events{/privacy}","received_events_url":"https://api.github.com/users/kframework/received_events","type":"Organization","site_admin":false},"repo":{"id":11711223,"name":"k","full_name":"kframework/k","owner":{"login":"kframework","id":5104335,"avatar_url":"https://avatars.githubusercontent.com/u/5104335?v=3","gravatar_id":"","url":"https://api.github.com/users/kframework","html_url":"https://github.com/kframework","followers_url":"https://api.github.com/users/kframework/followers","following_url":"https://api.github.com/users/kframework/following{/other_user}","gists_url":"https://api.github.com/users/kframework/gists{/gist_id}","starred_url":"https://api.github.com/users/kframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kframework/subscriptions","organizations_url":"https://api.github.com/users/kframework/orgs","repos_url":"https://api.github.com/users/kframework/repos","events_url":"https://api.github.com/users/kframework/events{/privacy}","received_events_url":"https://api.github.com/users/kframework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kframework/k","description":"The K tools","fork":false,"url":"https://api.github.com/repos/kframework/k","forks_url":"https://api.github.com/repos/kframework/k/forks","keys_url":"https://api.github.com/repos/kframework/k/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kframework/k/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kframework/k/teams","hooks_url":"https://api.github.com/repos/kframework/k/hooks","issue_events_url":"https://api.github.com/repos/kframework/k/issues/events{/number}","events_url":"https://api.github.com/repos/kframework/k/events","assignees_url":"https://api.github.com/repos/kframework/k/assignees{/user}","branches_url":"https://api.github.com/repos/kframework/k/branches{/branch}","tags_url":"https://api.github.com/repos/kframework/k/tags","blobs_url":"https://api.github.com/repos/kframework/k/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kframework/k/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kframework/k/git/refs{/sha}","trees_url":"https://api.github.com/repos/kframework/k/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kframework/k/statuses/{sha}","languages_url":"https://api.github.com/repos/kframework/k/languages","stargazers_url":"https://api.github.com/repos/kframework/k/stargazers","contributors_url":"https://api.github.com/repos/kframework/k/contributors","subscribers_url":"https://api.github.com/repos/kframework/k/subscribers","subscription_url":"https://api.github.com/repos/kframework/k/subscription","commits_url":"https://api.github.com/repos/kframework/k/commits{/sha}","git_commits_url":"https://api.github.com/repos/kframework/k/git/commits{/sha}","comments_url":"https://api.github.com/repos/kframework/k/comments{/number}","issue_comment_url":"https://api.github.com/repos/kframework/k/issues/comments{/number}","contents_url":"https://api.github.com/repos/kframework/k/contents/{+path}","compare_url":"https://api.github.com/repos/kframework/k/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kframework/k/merges","archive_url":"https://api.github.com/repos/kframework/k/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kframework/k/downloads","issues_url":"https://api.github.com/repos/kframework/k/issues{/number}","pulls_url":"https://api.github.com/repos/kframework/k/pulls{/number}","milestones_url":"https://api.github.com/repos/kframework/k/milestones{/number}","notifications_url":"https://api.github.com/repos/kframework/k/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kframework/k/labels{/name}","releases_url":"https://api.github.com/repos/kframework/k/releases{/id}","created_at":"2013-07-27T21:22:53Z","updated_at":"2015-12-13T10:54:50Z","pushed_at":"2015-12-15T15:00:49Z","git_url":"git://github.com/kframework/k.git","ssh_url":"git@github.com:kframework/k.git","clone_url":"https://github.com/kframework/k.git","svn_url":"https://github.com/kframework/k","homepage":"kframework.org","size":272045,"stargazers_count":73,"watchers_count":73,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":55,"mirror_url":null,"open_issues_count":263,"forks":55,"open_issues":263,"watchers":73,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kframework/k/pulls/1906"},"html":{"href":"https://github.com/kframework/k/pull/1906"},"issue":{"href":"https://api.github.com/repos/kframework/k/issues/1906"},"comments":{"href":"https://api.github.com/repos/kframework/k/issues/1906/comments"},"review_comments":{"href":"https://api.github.com/repos/kframework/k/pulls/1906/comments"},"review_comment":{"href":"https://api.github.com/repos/kframework/k/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kframework/k/pulls/1906/commits"},"statuses":{"href":"https://api.github.com/repos/kframework/k/statuses/0f611c83c23300f18dce336ec3272347b8b984c7"}}}}