{"action":"created","issue":{"url":"https://api.github.com/repos/miekg/dns/issues/281","labels_url":"https://api.github.com/repos/miekg/dns/issues/281/labels{/name}","comments_url":"https://api.github.com/repos/miekg/dns/issues/281/comments","events_url":"https://api.github.com/repos/miekg/dns/issues/281/events","html_url":"https://github.com/miekg/dns/pull/281","id":114189847,"number":281,"title":"Instead of removing all RRs on Truncated, attempt to unpack","user":{"login":"fastest963","id":112555,"avatar_url":"https://avatars.githubusercontent.com/u/112555?v=3","gravatar_id":"","url":"https://api.github.com/users/fastest963","html_url":"https://github.com/fastest963","followers_url":"https://api.github.com/users/fastest963/followers","following_url":"https://api.github.com/users/fastest963/following{/other_user}","gists_url":"https://api.github.com/users/fastest963/gists{/gist_id}","starred_url":"https://api.github.com/users/fastest963/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fastest963/subscriptions","organizations_url":"https://api.github.com/users/fastest963/orgs","repos_url":"https://api.github.com/users/fastest963/repos","events_url":"https://api.github.com/users/fastest963/events{/privacy}","received_events_url":"https://api.github.com/users/fastest963/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":10,"created_at":"2015-10-30T03:00:21Z","updated_at":"2015-11-02T21:44:29Z","closed_at":"2015-11-02T11:51:50Z","pull_request":{"url":"https://api.github.com/repos/miekg/dns/pulls/281","html_url":"https://github.com/miekg/dns/pull/281","diff_url":"https://github.com/miekg/dns/pull/281.diff","patch_url":"https://github.com/miekg/dns/pull/281.patch"},"body":"This Pull Request fixes the `TODO(miek): this isn't the best strategy!` regarding `Truncated` messages received. Instead of just returning no RRs it's now attempting to do as many RRs as possible until it gets an error then returning `ErrTruncated` along with the partial response. This allows someone to naively just check `err != nil` if they didn't know about truncated messages or someone could check if `err == ErrTruncated` additionally and proceed with the truncated response if they're okay with a truncated response.\r\n\r\nMore realistically, I don't think servers will be returning partial responses (like how skydns removes the `Extra` first), but it supports that. If a non-partial response is returned (that was truncated) then no error is returned. I can make it still return a `ErrTruncated` but since there was no error unpacking the message, I didn't think it made sense to return an error."},"comment":{"url":"https://api.github.com/repos/miekg/dns/issues/comments/153166798","html_url":"https://github.com/miekg/dns/pull/281#issuecomment-153166798","issue_url":"https://api.github.com/repos/miekg/dns/issues/281","id":153166798,"user":{"login":"rade","id":109109,"avatar_url":"https://avatars.githubusercontent.com/u/109109?v=3","gravatar_id":"","url":"https://api.github.com/users/rade","html_url":"https://github.com/rade","followers_url":"https://api.github.com/users/rade/followers","following_url":"https://api.github.com/users/rade/following{/other_user}","gists_url":"https://api.github.com/users/rade/gists{/gist_id}","starred_url":"https://api.github.com/users/rade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rade/subscriptions","organizations_url":"https://api.github.com/users/rade/orgs","repos_url":"https://api.github.com/users/rade/repos","events_url":"https://api.github.com/users/rade/events{/privacy}","received_events_url":"https://api.github.com/users/rade/received_events","type":"User","site_admin":false},"created_at":"2015-11-02T21:44:29Z","updated_at":"2015-11-02T21:44:29Z","body":"> A partial RRset means the packet should be completely valid.\r\n\r\nsays who?"}}