{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/27336036","id":27336036,"diff_hunk":"@@ -112,11 +122,47 @@ class LogisticRegressionModel(LinearBinaryClassificationModel):\n     ...    os.removedirs(path)\n     ... except:\n     ...    pass\n+    >>> multi_class_data = [\n+    ...     LabeledPoint(0.0, [0.0, 1.0, 0.0]),\n+    ...     LabeledPoint(1.0, [1.0, 0.0, 0.0]),\n+    ...     LabeledPoint(2.0, [0.0, 0.0, 1.0])\n+    ... ]\n+    >>> mcm = LogisticRegressionWithLBFGS.train(data=sc.parallelize(multi_class_data), numClasses=3)\n+    >>> mcm.predict([0.0, 0.5, 0.0])\n+    0\n+    >>> mcm.predict([0.8, 0.0, 0.0])\n+    1\n+    >>> mcm.predict([0.0, 0.0, 0.3])\n+    2\n     \"\"\"\n-    def __init__(self, weights, intercept):\n+    def __init__(self, weights, intercept, numFeatures, numClasses):\n         super(LogisticRegressionModel, self).__init__(weights, intercept)\n+        self._numFeatures = int(numFeatures)\n+        self._numClasses = int(numClasses)\n         self._threshold = 0.5\n \n+    @property\n+    def numFeatures(self):\n+        return self._numFeatures\n+\n+    @property\n+    def numClasses(self):\n+        return self._numClasses\n+\n+    @property\n+    def dataWithBiasSize(self):\n+        return self.weights.size / (self.numClasses - 1)\n+\n+    @property\n+    def weightsMatrix(self):\n+        if self.numClasses == 2:\n+            return None\n+        else:\n+            if not isinstance(self.weights, DenseVector):","path":"python/pyspark/mllib/classification.py","position":94,"original_position":94,"commit_id":"fc7990b94445f0de09367f9834f52418e4756e54","original_commit_id":"fc7990b94445f0de09367f9834f52418e4756e54","user":{"login":"jkbradley","id":5084283,"avatar_url":"https://avatars.githubusercontent.com/u/5084283?v=3","gravatar_id":"","url":"https://api.github.com/users/jkbradley","html_url":"https://github.com/jkbradley","followers_url":"https://api.github.com/users/jkbradley/followers","following_url":"https://api.github.com/users/jkbradley/following{/other_user}","gists_url":"https://api.github.com/users/jkbradley/gists{/gist_id}","starred_url":"https://api.github.com/users/jkbradley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkbradley/subscriptions","organizations_url":"https://api.github.com/users/jkbradley/orgs","repos_url":"https://api.github.com/users/jkbradley/repos","events_url":"https://api.github.com/users/jkbradley/events{/privacy}","received_events_url":"https://api.github.com/users/jkbradley/received_events","type":"User","site_admin":false},"body":"Please use _convert_to_vector as in LinearModel.  That will check types and support Python types beyond DenseVector.","created_at":"2015-03-27T22:35:47Z","updated_at":"2015-03-27T22:35:47Z","html_url":"https://github.com/apache/spark/pull/5137#discussion_r27336036","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/5137","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/27336036"},"html":{"href":"https://github.com/apache/spark/pull/5137#discussion_r27336036"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/5137"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/5137","id":31738715,"html_url":"https://github.com/apache/spark/pull/5137","diff_url":"https://github.com/apache/spark/pull/5137.diff","patch_url":"https://github.com/apache/spark/pull/5137.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/5137","number":5137,"state":"open","locked":false,"title":"[SPARK-6255] [MLLIB] Support multiclass classification in Python API","user":{"login":"yanboliang","id":1962026,"avatar_url":"https://avatars.githubusercontent.com/u/1962026?v=3","gravatar_id":"","url":"https://api.github.com/users/yanboliang","html_url":"https://github.com/yanboliang","followers_url":"https://api.github.com/users/yanboliang/followers","following_url":"https://api.github.com/users/yanboliang/following{/other_user}","gists_url":"https://api.github.com/users/yanboliang/gists{/gist_id}","starred_url":"https://api.github.com/users/yanboliang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yanboliang/subscriptions","organizations_url":"https://api.github.com/users/yanboliang/orgs","repos_url":"https://api.github.com/users/yanboliang/repos","events_url":"https://api.github.com/users/yanboliang/events{/privacy}","received_events_url":"https://api.github.com/users/yanboliang/received_events","type":"User","site_admin":false},"body":"Python API parity check for classification and multiclass classification support, major disparities need to be added for Python:\r\n```scala\r\nLogisticRegressionWithLBFGS\r\n    setNumClasses\r\n    setValidateData\r\nLogisticRegressionModel\r\n    getThreshold\r\n    numClasses\r\n    numFeatures\r\nSVMWithSGD\r\n    setValidateData\r\nSVMModel\r\n    getThreshold\r\n```\r\nFor users the greatest benefit in this PR is multiclass classification was supported by Python API.\r\nUsers can train multiclass classification model and use it to predict in pyspark.","created_at":"2015-03-23T14:49:53Z","updated_at":"2015-03-27T22:35:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9e0ccc0f6428ff3cee2bb9d875accb540cef53d8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/5137/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/5137/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/5137/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/fc7990b94445f0de09367f9834f52418e4756e54","head":{"label":"yanboliang:spark-6255","ref":"spark-6255","sha":"fc7990b94445f0de09367f9834f52418e4756e54","user":{"login":"yanboliang","id":1962026,"avatar_url":"https://avatars.githubusercontent.com/u/1962026?v=3","gravatar_id":"","url":"https://api.github.com/users/yanboliang","html_url":"https://github.com/yanboliang","followers_url":"https://api.github.com/users/yanboliang/followers","following_url":"https://api.github.com/users/yanboliang/following{/other_user}","gists_url":"https://api.github.com/users/yanboliang/gists{/gist_id}","starred_url":"https://api.github.com/users/yanboliang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yanboliang/subscriptions","organizations_url":"https://api.github.com/users/yanboliang/orgs","repos_url":"https://api.github.com/users/yanboliang/repos","events_url":"https://api.github.com/users/yanboliang/events{/privacy}","received_events_url":"https://api.github.com/users/yanboliang/received_events","type":"User","site_admin":false},"repo":{"id":21890948,"name":"spark","full_name":"yanboliang/spark","owner":{"login":"yanboliang","id":1962026,"avatar_url":"https://avatars.githubusercontent.com/u/1962026?v=3","gravatar_id":"","url":"https://api.github.com/users/yanboliang","html_url":"https://github.com/yanboliang","followers_url":"https://api.github.com/users/yanboliang/followers","following_url":"https://api.github.com/users/yanboliang/following{/other_user}","gists_url":"https://api.github.com/users/yanboliang/gists{/gist_id}","starred_url":"https://api.github.com/users/yanboliang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yanboliang/subscriptions","organizations_url":"https://api.github.com/users/yanboliang/orgs","repos_url":"https://api.github.com/users/yanboliang/repos","events_url":"https://api.github.com/users/yanboliang/events{/privacy}","received_events_url":"https://api.github.com/users/yanboliang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yanboliang/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/yanboliang/spark","forks_url":"https://api.github.com/repos/yanboliang/spark/forks","keys_url":"https://api.github.com/repos/yanboliang/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yanboliang/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yanboliang/spark/teams","hooks_url":"https://api.github.com/repos/yanboliang/spark/hooks","issue_events_url":"https://api.github.com/repos/yanboliang/spark/issues/events{/number}","events_url":"https://api.github.com/repos/yanboliang/spark/events","assignees_url":"https://api.github.com/repos/yanboliang/spark/assignees{/user}","branches_url":"https://api.github.com/repos/yanboliang/spark/branches{/branch}","tags_url":"https://api.github.com/repos/yanboliang/spark/tags","blobs_url":"https://api.github.com/repos/yanboliang/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yanboliang/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yanboliang/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/yanboliang/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yanboliang/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/yanboliang/spark/languages","stargazers_url":"https://api.github.com/repos/yanboliang/spark/stargazers","contributors_url":"https://api.github.com/repos/yanboliang/spark/contributors","subscribers_url":"https://api.github.com/repos/yanboliang/spark/subscribers","subscription_url":"https://api.github.com/repos/yanboliang/spark/subscription","commits_url":"https://api.github.com/repos/yanboliang/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/yanboliang/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/yanboliang/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/yanboliang/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/yanboliang/spark/contents/{+path}","compare_url":"https://api.github.com/repos/yanboliang/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yanboliang/spark/merges","archive_url":"https://api.github.com/repos/yanboliang/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yanboliang/spark/downloads","issues_url":"https://api.github.com/repos/yanboliang/spark/issues{/number}","pulls_url":"https://api.github.com/repos/yanboliang/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/yanboliang/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/yanboliang/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yanboliang/spark/labels{/name}","releases_url":"https://api.github.com/repos/yanboliang/spark/releases{/id}","created_at":"2014-07-16T07:24:13Z","updated_at":"2015-03-23T12:53:44Z","pushed_at":"2015-03-27T09:51:18Z","git_url":"git://github.com/yanboliang/spark.git","ssh_url":"git@github.com:yanboliang/spark.git","clone_url":"https://github.com/yanboliang/spark.git","svn_url":"https://github.com/yanboliang/spark","homepage":null,"size":93085,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"9f3273bd9c919f6c48a95383b3d5be357c89998c","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","created_at":"2014-02-25T08:00:08Z","updated_at":"2015-03-27T22:14:21Z","pushed_at":"2015-03-27T22:28:38Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":1426979,"stargazers_count":3384,"watchers_count":3384,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2928,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":297,"forks":2928,"open_issues":297,"watchers":3384,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/5137"},"html":{"href":"https://github.com/apache/spark/pull/5137"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/5137"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/5137/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/5137/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/5137/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/fc7990b94445f0de09367f9834f52418e4756e54"}}}}