{"action":"created","issue":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/7672","labels_url":"https://api.github.com/repos/cms-sw/cmssw/issues/7672/labels{/name}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/7672/comments","events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/7672/events","html_url":"https://github.com/cms-sw/cmssw/pull/7672","id":57314684,"number":7672,"title":"Add FastSim changes to the run2 era","user":{"login":"mark-grimes","id":6480160,"avatar_url":"https://avatars.githubusercontent.com/u/6480160?v=3","gravatar_id":"","url":"https://api.github.com/users/mark-grimes","html_url":"https://github.com/mark-grimes","followers_url":"https://api.github.com/users/mark-grimes/followers","following_url":"https://api.github.com/users/mark-grimes/following{/other_user}","gists_url":"https://api.github.com/users/mark-grimes/gists{/gist_id}","starred_url":"https://api.github.com/users/mark-grimes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mark-grimes/subscriptions","organizations_url":"https://api.github.com/users/mark-grimes/orgs","repos_url":"https://api.github.com/users/mark-grimes/repos","events_url":"https://api.github.com/users/mark-grimes/events{/privacy}","received_events_url":"https://api.github.com/users/mark-grimes/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-pending","name":"comparison-pending","color":"fef2c0"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/fastsim-pending","name":"fastsim-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/pending-signatures","name":"pending-signatures","color":"eb6420"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-pending","name":"tests-pending","color":"fbca04"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/50","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/50/labels","id":875803,"number":50,"title":"Next CMSSW_7_4_X","description":"","creator":{"login":"nclopezo","id":1944922,"avatar_url":"https://avatars.githubusercontent.com/u/1944922?v=3","gravatar_id":"","url":"https://api.github.com/users/nclopezo","html_url":"https://github.com/nclopezo","followers_url":"https://api.github.com/users/nclopezo/followers","following_url":"https://api.github.com/users/nclopezo/following{/other_user}","gists_url":"https://api.github.com/users/nclopezo/gists{/gist_id}","starred_url":"https://api.github.com/users/nclopezo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nclopezo/subscriptions","organizations_url":"https://api.github.com/users/nclopezo/orgs","repos_url":"https://api.github.com/users/nclopezo/repos","events_url":"https://api.github.com/users/nclopezo/events{/privacy}","received_events_url":"https://api.github.com/users/nclopezo/received_events","type":"User","site_admin":false},"open_issues":42,"closed_issues":647,"state":"open","created_at":"2014-11-21T15:23:58Z","updated_at":"2015-02-12T07:08:01Z","due_on":"2015-01-26T08:00:00Z","closed_at":null},"comments":9,"created_at":"2015-02-11T13:21:18Z","updated_at":"2015-02-12T07:08:55Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/7672","html_url":"https://github.com/cms-sw/cmssw/pull/7672","diff_url":"https://github.com/cms-sw/cmssw/pull/7672.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/7672.patch"},"body":"This adds the customisations present in `SLHCUpgradeSimulations.Configuration.fastSimCustoms.customise_fastSimPostLS1` to the `run2` era.  Nothing is changed unless the `run2` era is explicitly activated.\r\n\r\nTwo points:\r\n * [EDIT - this point no longer relevant] `process.genMixPileUpFiles` is not created. It's not easy to create brand new parameters with an era and I couldn't see it used anywhere.  Is it definitely required?\r\n * I think there's a bug in the original customisation.  The line [SLHCUpgradeSimulations/Configuration/python/fastSimCustoms.py#L11](https://github.com/cms-sw/cmssw/blob/CMSSW_7_4_X/SLHCUpgradeSimulations/Configuration/python/fastSimCustoms.py#L11) doesn't do anything.  The correct path is `famosPileUp.PileUpSimulatorBlock.PileUpSimulator` not `famosPileUp.PileUpSimulator` (see [PileUpProducer_cff.py](https://github.com/cms-sw/cmssw/blob/CMSSW_7_4_X/FastSimulation/PileUpProducer/python/PileUpProducer_cff.py)).  The (what I consider) correct path is used here.\r\n\r\nTesting has been limited.  I just made sure the files can be parsed properly since nothing is changed if the era is not active.  I'll worry about ensuring identity between the two methods (customisation versus era) once all the pull requests are in.\r\n\r\nAlso, I haven't taken the customisations out of the run2 helper function [customiseRun2EraExtras](https://github.com/cms-sw/cmssw/blob/CMSSW_7_4_X/SLHCUpgradeSimulations/Configuration/python/postLS1Customs.py#L233). The postLS1Customs.py file is being heavily modified by #7579, and this would likely cause a conflict.  Applying the modification twice has no harm so I'll remove those lines in a later pull request."},"comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments/74027113","html_url":"https://github.com/cms-sw/cmssw/pull/7672#issuecomment-74027113","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/7672","id":74027113,"user":{"login":"davidlange6","id":5042883,"avatar_url":"https://avatars.githubusercontent.com/u/5042883?v=3","gravatar_id":"","url":"https://api.github.com/users/davidlange6","html_url":"https://github.com/davidlange6","followers_url":"https://api.github.com/users/davidlange6/followers","following_url":"https://api.github.com/users/davidlange6/following{/other_user}","gists_url":"https://api.github.com/users/davidlange6/gists{/gist_id}","starred_url":"https://api.github.com/users/davidlange6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidlange6/subscriptions","organizations_url":"https://api.github.com/users/davidlange6/orgs","repos_url":"https://api.github.com/users/davidlange6/repos","events_url":"https://api.github.com/users/davidlange6/events{/privacy}","received_events_url":"https://api.github.com/users/davidlange6/received_events","type":"User","site_admin":false},"created_at":"2015-02-12T07:08:55Z","updated_at":"2015-02-12T07:08:55Z","body":"bypassing era PRs - lets discuss once Mark has the full set implemented - currently they have no effect"}}