{"action":"created","issue":{"url":"https://api.github.com/repos/lvml/mpv-plugin-xrandr/issues/1","labels_url":"https://api.github.com/repos/lvml/mpv-plugin-xrandr/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/lvml/mpv-plugin-xrandr/issues/1/comments","events_url":"https://api.github.com/repos/lvml/mpv-plugin-xrandr/issues/1/events","html_url":"https://github.com/lvml/mpv-plugin-xrandr/issues/1","id":66235221,"number":1,"title":"High refresh rate support","user":{"login":"Druneau","id":2328428,"avatar_url":"https://avatars.githubusercontent.com/u/2328428?v=3","gravatar_id":"","url":"https://api.github.com/users/Druneau","html_url":"https://github.com/Druneau","followers_url":"https://api.github.com/users/Druneau/followers","following_url":"https://api.github.com/users/Druneau/following{/other_user}","gists_url":"https://api.github.com/users/Druneau/gists{/gist_id}","starred_url":"https://api.github.com/users/Druneau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Druneau/subscriptions","organizations_url":"https://api.github.com/users/Druneau/orgs","repos_url":"https://api.github.com/users/Druneau/repos","events_url":"https://api.github.com/users/Druneau/events{/privacy}","received_events_url":"https://api.github.com/users/Druneau/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-04-03T21:51:31Z","updated_at":"2015-04-04T17:30:55Z","closed_at":null,"body":"With the script as is it wouldn't select some of my higher refresh rates.  My current refresh rate setup consists of:\r\n\r\n* 100Hz for 25/50fps\r\n* 96Hz for 24fps\r\n* 95.904Hz for 23.976fps\r\n* 90Hz for 30fps\r\n* 89.991Hz for 29.997fps\r\n* 60Hz for 60fps\r\n* 59.994Hz for 59.994fps\r\n\r\nFirst problem I had was that the script only tries matching with a 3x multiplier.  Because of this it was never able to choose the highest refresh rates.  Then I realized the for loop was testing \"1 x fps\" before 2x.. which made it return the lowest matching refresh rate.\r\n\r\nSo I changed it from:\r\n```lua\r\nfor m=1, 3 do\r\n```\r\nto;\r\n```lua\r\nfor m=4, 1, -1 do\r\n```\r\nThis allows your script to work beautifully with high refresh rates.\r\n\r\nThanks for posting it."},"comment":{"url":"https://api.github.com/repos/lvml/mpv-plugin-xrandr/issues/comments/89622714","html_url":"https://github.com/lvml/mpv-plugin-xrandr/issues/1#issuecomment-89622714","issue_url":"https://api.github.com/repos/lvml/mpv-plugin-xrandr/issues/1","id":89622714,"user":{"login":"lvml","id":9969397,"avatar_url":"https://avatars.githubusercontent.com/u/9969397?v=3","gravatar_id":"","url":"https://api.github.com/users/lvml","html_url":"https://github.com/lvml","followers_url":"https://api.github.com/users/lvml/followers","following_url":"https://api.github.com/users/lvml/following{/other_user}","gists_url":"https://api.github.com/users/lvml/gists{/gist_id}","starred_url":"https://api.github.com/users/lvml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lvml/subscriptions","organizations_url":"https://api.github.com/users/lvml/orgs","repos_url":"https://api.github.com/users/lvml/repos","events_url":"https://api.github.com/users/lvml/events{/privacy}","received_events_url":"https://api.github.com/users/lvml/received_events","type":"User","site_admin":false},"created_at":"2015-04-04T17:30:55Z","updated_at":"2015-04-04T17:30:55Z","body":"I would like to understand why you want the script to prefer higher refresh rates in general. As long as two refresh rates are both even multipliers of the video frame rate, I can only see disadvantages with using the higher frame rate:\r\n\r\n* If your display is a TV capable of computing \"in-between\" frames to achieve smoother movements, it will do so much better if you don't give it the same image multiple times, but provide only differing frames with the original rate.\r\n\r\n* If your player is operating on battery - like a notebook - it will use up more power when using a higher refresh rate. (Which is why many notebooks support a lower-than-60Hz rate to save power.)\r\n\r\nWhat benefit do you see from higher-than-original refresh rates?"}}