{"action":"created","comment":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/comments/47668389","id":47668389,"diff_hunk":"@@ -1123,7 +1123,9 @@ def _block_matches_all(block_data):\n             settings['children'] = qualifiers.pop('children')\n         for block_id, value in course.structure['blocks'].iteritems():\n             if _block_matches_all(value):\n-                items.append(block_id)\n+                # Check if the block is in the course tree\n+                if self.has_path_to_root(block_id, course):","path":"common/lib/xmodule/xmodule/modulestore/split_mongo/split.py","position":6,"original_position":6,"commit_id":"0ddf6e43c5f69451c4f64d1a6be3c9b2ba320ab8","original_commit_id":"0ddf6e43c5f69451c4f64d1a6be3c9b2ba320ab8","user":{"login":"mushtaqak","id":6991154,"avatar_url":"https://avatars.githubusercontent.com/u/6991154?v=3","gravatar_id":"","url":"https://api.github.com/users/mushtaqak","html_url":"https://github.com/mushtaqak","followers_url":"https://api.github.com/users/mushtaqak/followers","following_url":"https://api.github.com/users/mushtaqak/following{/other_user}","gists_url":"https://api.github.com/users/mushtaqak/gists{/gist_id}","starred_url":"https://api.github.com/users/mushtaqak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mushtaqak/subscriptions","organizations_url":"https://api.github.com/users/mushtaqak/orgs","repos_url":"https://api.github.com/users/mushtaqak/repos","events_url":"https://api.github.com/users/mushtaqak/events{/privacy}","received_events_url":"https://api.github.com/users/mushtaqak/received_events","type":"User","site_admin":false},"body":"@adampalay I was just testing this on sandbox for cohort orphans issue.\r\nYes you are right, it should be behind a kwarg if that is argument is present then we should check if item is present in the course tree.","created_at":"2015-12-15T17:23:29Z","updated_at":"2015-12-15T17:23:29Z","html_url":"https://github.com/edx/edx-platform/pull/10994#discussion_r47668389","pull_request_url":"https://api.github.com/repos/edx/edx-platform/pulls/10994","_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments/47668389"},"html":{"href":"https://github.com/edx/edx-platform/pull/10994#discussion_r47668389"},"pull_request":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/10994"}}},"pull_request":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/10994","id":53698226,"html_url":"https://github.com/edx/edx-platform/pull/10994","diff_url":"https://github.com/edx/edx-platform/pull/10994.diff","patch_url":"https://github.com/edx/edx-platform/pull/10994.patch","issue_url":"https://api.github.com/repos/edx/edx-platform/issues/10994","number":10994,"state":"open","locked":false,"title":"[WIP] Append block item only if it has path to root","user":{"login":"mushtaqak","id":6991154,"avatar_url":"https://avatars.githubusercontent.com/u/6991154?v=3","gravatar_id":"","url":"https://api.github.com/users/mushtaqak","html_url":"https://github.com/mushtaqak","followers_url":"https://api.github.com/users/mushtaqak/followers","following_url":"https://api.github.com/users/mushtaqak/following{/other_user}","gists_url":"https://api.github.com/users/mushtaqak/gists{/gist_id}","starred_url":"https://api.github.com/users/mushtaqak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mushtaqak/subscriptions","organizations_url":"https://api.github.com/users/mushtaqak/orgs","repos_url":"https://api.github.com/users/mushtaqak/repos","events_url":"https://api.github.com/users/mushtaqak/events{/privacy}","received_events_url":"https://api.github.com/users/mushtaqak/received_events","type":"User","site_admin":false},"body":"[Optionally have `get_items` only return items in course tree in split mongo](https://openedx.atlassian.net/browse/SUST-20)\r\n\r\n\r\nAppend block only if it has path to root","created_at":"2015-12-15T12:43:41Z","updated_at":"2015-12-15T17:23:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"41d2725b5bc90ecb9d5a87191a228bcb96daf171","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/edx/edx-platform/pulls/10994/commits","review_comments_url":"https://api.github.com/repos/edx/edx-platform/pulls/10994/comments","review_comment_url":"https://api.github.com/repos/edx/edx-platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/edx/edx-platform/issues/10994/comments","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/0ddf6e43c5f69451c4f64d1a6be3c9b2ba320ab8","head":{"label":"edx:mushtaq/improve_get_item","ref":"mushtaq/improve_get_item","sha":"0ddf6e43c5f69451c4f64d1a6be3c9b2ba320ab8","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":10391073,"name":"edx-platform","full_name":"edx/edx-platform","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-platform","description":"The Open edX platform, the software that powers edX!","fork":false,"url":"https://api.github.com/repos/edx/edx-platform","forks_url":"https://api.github.com/repos/edx/edx-platform/forks","keys_url":"https://api.github.com/repos/edx/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-platform/events","assignees_url":"https://api.github.com/repos/edx/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-platform/merges","archive_url":"https://api.github.com/repos/edx/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-platform/releases{/id}","created_at":"2013-05-30T20:20:38Z","updated_at":"2015-12-14T12:06:16Z","pushed_at":"2015-12-15T17:14:56Z","git_url":"git://github.com/edx/edx-platform.git","ssh_url":"git@github.com:edx/edx-platform.git","clone_url":"https://github.com/edx/edx-platform.git","svn_url":"https://github.com/edx/edx-platform","homepage":"http://open.edx.org/","size":633786,"stargazers_count":2305,"watchers_count":2305,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1401,"mirror_url":null,"open_issues_count":141,"forks":1401,"open_issues":141,"watchers":2305,"default_branch":"master"}},"base":{"label":"edx:master","ref":"master","sha":"920fc0e7dece28c69e5564a5de83176759123d8a","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":10391073,"name":"edx-platform","full_name":"edx/edx-platform","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-platform","description":"The Open edX platform, the software that powers edX!","fork":false,"url":"https://api.github.com/repos/edx/edx-platform","forks_url":"https://api.github.com/repos/edx/edx-platform/forks","keys_url":"https://api.github.com/repos/edx/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-platform/events","assignees_url":"https://api.github.com/repos/edx/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-platform/merges","archive_url":"https://api.github.com/repos/edx/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-platform/releases{/id}","created_at":"2013-05-30T20:20:38Z","updated_at":"2015-12-14T12:06:16Z","pushed_at":"2015-12-15T17:14:56Z","git_url":"git://github.com/edx/edx-platform.git","ssh_url":"git@github.com:edx/edx-platform.git","clone_url":"https://github.com/edx/edx-platform.git","svn_url":"https://github.com/edx/edx-platform","homepage":"http://open.edx.org/","size":633786,"stargazers_count":2305,"watchers_count":2305,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1401,"mirror_url":null,"open_issues_count":141,"forks":1401,"open_issues":141,"watchers":2305,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/10994"},"html":{"href":"https://github.com/edx/edx-platform/pull/10994"},"issue":{"href":"https://api.github.com/repos/edx/edx-platform/issues/10994"},"comments":{"href":"https://api.github.com/repos/edx/edx-platform/issues/10994/comments"},"review_comments":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/10994/comments"},"review_comment":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/10994/commits"},"statuses":{"href":"https://api.github.com/repos/edx/edx-platform/statuses/0ddf6e43c5f69451c4f64d1a6be3c9b2ba320ab8"}}}}