{"action":"created","comment":{"url":"https://api.github.com/repos/fluent/fluentd-docker-image/pulls/comments/42094345","id":42094345,"diff_hunk":"@@ -52,4 +52,4 @@ ENV FLUENTD_CONF=\"fluent.conf\"\n EXPOSE 24224\n \n ### docker run -p 24224 -v `pwd`/log: -v `pwd`/log:/home/ubuntu/log fluent/fluentd:latest\n-CMD fluentd -c /fluentd/etc/$FLUENTD_CONF -p /fluentd/plugins $FLUENTD_OPT\n+CMD exec fluentd -c /fluentd/etc/$FLUENTD_CONF -p /fluentd/plugins $FLUENTD_OPT","path":"Dockerfile","position":5,"original_position":5,"commit_id":"ca8ef5c80c041344ec2d56d5ca360da53b594089","original_commit_id":"ca8ef5c80c041344ec2d56d5ca360da53b594089","user":{"login":"repeatedly","id":16928,"avatar_url":"https://avatars.githubusercontent.com/u/16928?v=3","gravatar_id":"","url":"https://api.github.com/users/repeatedly","html_url":"https://github.com/repeatedly","followers_url":"https://api.github.com/users/repeatedly/followers","following_url":"https://api.github.com/users/repeatedly/following{/other_user}","gists_url":"https://api.github.com/users/repeatedly/gists{/gist_id}","starred_url":"https://api.github.com/users/repeatedly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/repeatedly/subscriptions","organizations_url":"https://api.github.com/users/repeatedly/orgs","repos_url":"https://api.github.com/users/repeatedly/repos","events_url":"https://api.github.com/users/repeatedly/events{/privacy}","received_events_url":"https://api.github.com/users/repeatedly/received_events","type":"User","site_admin":false},"body":"From docker document, @c0b 's way is recommended.\r\n\r\nhttps://docs.docker.com/reference/builder/#cmd\r\n\r\n@cpuguy83 Could you update the patch?","created_at":"2015-10-15T08:17:11Z","updated_at":"2015-10-15T08:17:11Z","html_url":"https://github.com/fluent/fluentd-docker-image/pull/5#discussion_r42094345","pull_request_url":"https://api.github.com/repos/fluent/fluentd-docker-image/pulls/5","_links":{"self":{"href":"https://api.github.com/repos/fluent/fluentd-docker-image/pulls/comments/42094345"},"html":{"href":"https://github.com/fluent/fluentd-docker-image/pull/5#discussion_r42094345"},"pull_request":{"href":"https://api.github.com/repos/fluent/fluentd-docker-image/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/fluent/fluentd-docker-image/pulls/5","id":47158637,"html_url":"https://github.com/fluent/fluentd-docker-image/pull/5","diff_url":"https://github.com/fluent/fluentd-docker-image/pull/5.diff","patch_url":"https://github.com/fluent/fluentd-docker-image/pull/5.patch","issue_url":"https://api.github.com/repos/fluent/fluentd-docker-image/issues/5","number":5,"state":"open","locked":false,"title":"Make sure fluentd is pid1, not sh","user":{"login":"cpuguy83","id":799078,"avatar_url":"https://avatars.githubusercontent.com/u/799078?v=3","gravatar_id":"","url":"https://api.github.com/users/cpuguy83","html_url":"https://github.com/cpuguy83","followers_url":"https://api.github.com/users/cpuguy83/followers","following_url":"https://api.github.com/users/cpuguy83/following{/other_user}","gists_url":"https://api.github.com/users/cpuguy83/gists{/gist_id}","starred_url":"https://api.github.com/users/cpuguy83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpuguy83/subscriptions","organizations_url":"https://api.github.com/users/cpuguy83/orgs","repos_url":"https://api.github.com/users/cpuguy83/repos","events_url":"https://api.github.com/users/cpuguy83/events{/privacy}","received_events_url":"https://api.github.com/users/cpuguy83/received_events","type":"User","site_admin":false},"body":"Currently fluentd runs in a `/bin/sh -c \"fluentd ...\"`, and signals are not being handled properly since they are going to /bin/sh and not fluent.\r\nThis should make fluentd pid1 in the container and properly handle signals.","created_at":"2015-10-08T14:21:36Z","updated_at":"2015-10-15T08:17:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fd94b4f165f8de8bc1e60be4985ed1588818c8a5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/fluent/fluentd-docker-image/pulls/5/commits","review_comments_url":"https://api.github.com/repos/fluent/fluentd-docker-image/pulls/5/comments","review_comment_url":"https://api.github.com/repos/fluent/fluentd-docker-image/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fluent/fluentd-docker-image/issues/5/comments","statuses_url":"https://api.github.com/repos/fluent/fluentd-docker-image/statuses/ca8ef5c80c041344ec2d56d5ca360da53b594089","head":{"label":"cpuguy83:patch-1","ref":"patch-1","sha":"ca8ef5c80c041344ec2d56d5ca360da53b594089","user":{"login":"cpuguy83","id":799078,"avatar_url":"https://avatars.githubusercontent.com/u/799078?v=3","gravatar_id":"","url":"https://api.github.com/users/cpuguy83","html_url":"https://github.com/cpuguy83","followers_url":"https://api.github.com/users/cpuguy83/followers","following_url":"https://api.github.com/users/cpuguy83/following{/other_user}","gists_url":"https://api.github.com/users/cpuguy83/gists{/gist_id}","starred_url":"https://api.github.com/users/cpuguy83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpuguy83/subscriptions","organizations_url":"https://api.github.com/users/cpuguy83/orgs","repos_url":"https://api.github.com/users/cpuguy83/repos","events_url":"https://api.github.com/users/cpuguy83/events{/privacy}","received_events_url":"https://api.github.com/users/cpuguy83/received_events","type":"User","site_admin":false},"repo":{"id":43893054,"name":"fluentd-docker-image","full_name":"cpuguy83/fluentd-docker-image","owner":{"login":"cpuguy83","id":799078,"avatar_url":"https://avatars.githubusercontent.com/u/799078?v=3","gravatar_id":"","url":"https://api.github.com/users/cpuguy83","html_url":"https://github.com/cpuguy83","followers_url":"https://api.github.com/users/cpuguy83/followers","following_url":"https://api.github.com/users/cpuguy83/following{/other_user}","gists_url":"https://api.github.com/users/cpuguy83/gists{/gist_id}","starred_url":"https://api.github.com/users/cpuguy83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpuguy83/subscriptions","organizations_url":"https://api.github.com/users/cpuguy83/orgs","repos_url":"https://api.github.com/users/cpuguy83/repos","events_url":"https://api.github.com/users/cpuguy83/events{/privacy}","received_events_url":"https://api.github.com/users/cpuguy83/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cpuguy83/fluentd-docker-image","description":"Docker image for Fluentd","fork":true,"url":"https://api.github.com/repos/cpuguy83/fluentd-docker-image","forks_url":"https://api.github.com/repos/cpuguy83/fluentd-docker-image/forks","keys_url":"https://api.github.com/repos/cpuguy83/fluentd-docker-image/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cpuguy83/fluentd-docker-image/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cpuguy83/fluentd-docker-image/teams","hooks_url":"https://api.github.com/repos/cpuguy83/fluentd-docker-image/hooks","issue_events_url":"https://api.github.com/repos/cpuguy83/fluentd-docker-image/issues/events{/number}","events_url":"https://api.github.com/repos/cpuguy83/fluentd-docker-image/events","assignees_url":"https://api.github.com/repos/cpuguy83/fluentd-docker-image/assignees{/user}","branches_url":"https://api.github.com/repos/cpuguy83/fluentd-docker-image/branches{/branch}","tags_url":"https://api.github.com/repos/cpuguy83/fluentd-docker-image/tags","blobs_url":"https://api.github.com/repos/cpuguy83/fluentd-docker-image/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cpuguy83/fluentd-docker-image/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cpuguy83/fluentd-docker-image/git/refs{/sha}","trees_url":"https://api.github.com/repos/cpuguy83/fluentd-docker-image/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cpuguy83/fluentd-docker-image/statuses/{sha}","languages_url":"https://api.github.com/repos/cpuguy83/fluentd-docker-image/languages","stargazers_url":"https://api.github.com/repos/cpuguy83/fluentd-docker-image/stargazers","contributors_url":"https://api.github.com/repos/cpuguy83/fluentd-docker-image/contributors","subscribers_url":"https://api.github.com/repos/cpuguy83/fluentd-docker-image/subscribers","subscription_url":"https://api.github.com/repos/cpuguy83/fluentd-docker-image/subscription","commits_url":"https://api.github.com/repos/cpuguy83/fluentd-docker-image/commits{/sha}","git_commits_url":"https://api.github.com/repos/cpuguy83/fluentd-docker-image/git/commits{/sha}","comments_url":"https://api.github.com/repos/cpuguy83/fluentd-docker-image/comments{/number}","issue_comment_url":"https://api.github.com/repos/cpuguy83/fluentd-docker-image/issues/comments{/number}","contents_url":"https://api.github.com/repos/cpuguy83/fluentd-docker-image/contents/{+path}","compare_url":"https://api.github.com/repos/cpuguy83/fluentd-docker-image/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cpuguy83/fluentd-docker-image/merges","archive_url":"https://api.github.com/repos/cpuguy83/fluentd-docker-image/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cpuguy83/fluentd-docker-image/downloads","issues_url":"https://api.github.com/repos/cpuguy83/fluentd-docker-image/issues{/number}","pulls_url":"https://api.github.com/repos/cpuguy83/fluentd-docker-image/pulls{/number}","milestones_url":"https://api.github.com/repos/cpuguy83/fluentd-docker-image/milestones{/number}","notifications_url":"https://api.github.com/repos/cpuguy83/fluentd-docker-image/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cpuguy83/fluentd-docker-image/labels{/name}","releases_url":"https://api.github.com/repos/cpuguy83/fluentd-docker-image/releases{/id}","created_at":"2015-10-08T14:12:14Z","updated_at":"2015-10-04T04:24:01Z","pushed_at":"2015-10-08T14:21:29Z","git_url":"git://github.com/cpuguy83/fluentd-docker-image.git","ssh_url":"git@github.com:cpuguy83/fluentd-docker-image.git","clone_url":"https://github.com/cpuguy83/fluentd-docker-image.git","svn_url":"https://github.com/cpuguy83/fluentd-docker-image","homepage":null,"size":96,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fluent:master","ref":"master","sha":"3be028a5396594bdd2c7f69f5faa6fddbe4b0a68","user":{"login":"fluent","id":859518,"avatar_url":"https://avatars.githubusercontent.com/u/859518?v=3","gravatar_id":"","url":"https://api.github.com/users/fluent","html_url":"https://github.com/fluent","followers_url":"https://api.github.com/users/fluent/followers","following_url":"https://api.github.com/users/fluent/following{/other_user}","gists_url":"https://api.github.com/users/fluent/gists{/gist_id}","starred_url":"https://api.github.com/users/fluent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fluent/subscriptions","organizations_url":"https://api.github.com/users/fluent/orgs","repos_url":"https://api.github.com/users/fluent/repos","events_url":"https://api.github.com/users/fluent/events{/privacy}","received_events_url":"https://api.github.com/users/fluent/received_events","type":"Organization","site_admin":false},"repo":{"id":35991061,"name":"fluentd-docker-image","full_name":"fluent/fluentd-docker-image","owner":{"login":"fluent","id":859518,"avatar_url":"https://avatars.githubusercontent.com/u/859518?v=3","gravatar_id":"","url":"https://api.github.com/users/fluent","html_url":"https://github.com/fluent","followers_url":"https://api.github.com/users/fluent/followers","following_url":"https://api.github.com/users/fluent/following{/other_user}","gists_url":"https://api.github.com/users/fluent/gists{/gist_id}","starred_url":"https://api.github.com/users/fluent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fluent/subscriptions","organizations_url":"https://api.github.com/users/fluent/orgs","repos_url":"https://api.github.com/users/fluent/repos","events_url":"https://api.github.com/users/fluent/events{/privacy}","received_events_url":"https://api.github.com/users/fluent/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fluent/fluentd-docker-image","description":"Docker image for Fluentd","fork":false,"url":"https://api.github.com/repos/fluent/fluentd-docker-image","forks_url":"https://api.github.com/repos/fluent/fluentd-docker-image/forks","keys_url":"https://api.github.com/repos/fluent/fluentd-docker-image/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fluent/fluentd-docker-image/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fluent/fluentd-docker-image/teams","hooks_url":"https://api.github.com/repos/fluent/fluentd-docker-image/hooks","issue_events_url":"https://api.github.com/repos/fluent/fluentd-docker-image/issues/events{/number}","events_url":"https://api.github.com/repos/fluent/fluentd-docker-image/events","assignees_url":"https://api.github.com/repos/fluent/fluentd-docker-image/assignees{/user}","branches_url":"https://api.github.com/repos/fluent/fluentd-docker-image/branches{/branch}","tags_url":"https://api.github.com/repos/fluent/fluentd-docker-image/tags","blobs_url":"https://api.github.com/repos/fluent/fluentd-docker-image/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fluent/fluentd-docker-image/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fluent/fluentd-docker-image/git/refs{/sha}","trees_url":"https://api.github.com/repos/fluent/fluentd-docker-image/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fluent/fluentd-docker-image/statuses/{sha}","languages_url":"https://api.github.com/repos/fluent/fluentd-docker-image/languages","stargazers_url":"https://api.github.com/repos/fluent/fluentd-docker-image/stargazers","contributors_url":"https://api.github.com/repos/fluent/fluentd-docker-image/contributors","subscribers_url":"https://api.github.com/repos/fluent/fluentd-docker-image/subscribers","subscription_url":"https://api.github.com/repos/fluent/fluentd-docker-image/subscription","commits_url":"https://api.github.com/repos/fluent/fluentd-docker-image/commits{/sha}","git_commits_url":"https://api.github.com/repos/fluent/fluentd-docker-image/git/commits{/sha}","comments_url":"https://api.github.com/repos/fluent/fluentd-docker-image/comments{/number}","issue_comment_url":"https://api.github.com/repos/fluent/fluentd-docker-image/issues/comments{/number}","contents_url":"https://api.github.com/repos/fluent/fluentd-docker-image/contents/{+path}","compare_url":"https://api.github.com/repos/fluent/fluentd-docker-image/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fluent/fluentd-docker-image/merges","archive_url":"https://api.github.com/repos/fluent/fluentd-docker-image/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fluent/fluentd-docker-image/downloads","issues_url":"https://api.github.com/repos/fluent/fluentd-docker-image/issues{/number}","pulls_url":"https://api.github.com/repos/fluent/fluentd-docker-image/pulls{/number}","milestones_url":"https://api.github.com/repos/fluent/fluentd-docker-image/milestones{/number}","notifications_url":"https://api.github.com/repos/fluent/fluentd-docker-image/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fluent/fluentd-docker-image/labels{/name}","releases_url":"https://api.github.com/repos/fluent/fluentd-docker-image/releases{/id}","created_at":"2015-05-21T04:31:36Z","updated_at":"2015-10-15T02:34:07Z","pushed_at":"2015-10-08T14:21:36Z","git_url":"git://github.com/fluent/fluentd-docker-image.git","ssh_url":"git@github.com:fluent/fluentd-docker-image.git","clone_url":"https://github.com/fluent/fluentd-docker-image.git","svn_url":"https://github.com/fluent/fluentd-docker-image","homepage":null,"size":156,"stargazers_count":29,"watchers_count":29,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":2,"forks":15,"open_issues":2,"watchers":29,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fluent/fluentd-docker-image/pulls/5"},"html":{"href":"https://github.com/fluent/fluentd-docker-image/pull/5"},"issue":{"href":"https://api.github.com/repos/fluent/fluentd-docker-image/issues/5"},"comments":{"href":"https://api.github.com/repos/fluent/fluentd-docker-image/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/fluent/fluentd-docker-image/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/fluent/fluentd-docker-image/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fluent/fluentd-docker-image/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/fluent/fluentd-docker-image/statuses/ca8ef5c80c041344ec2d56d5ca360da53b594089"}}}}