{"action":"closed","number":2828,"pull_request":{"url":"https://api.github.com/repos/deis/deis/pulls/2828","id":26748583,"html_url":"https://github.com/deis/deis/pull/2828","diff_url":"https://github.com/deis/deis/pull/2828.diff","patch_url":"https://github.com/deis/deis/pull/2828.patch","issue_url":"https://api.github.com/repos/deis/deis/issues/2828","number":2828,"state":"closed","locked":false,"title":"fix(controller): adds migration to get rid of dockerfile's u'False' valu...","user":{"login":"romansergey","id":1127845,"avatar_url":"https://avatars.githubusercontent.com/u/1127845?v=3","gravatar_id":"","url":"https://api.github.com/users/romansergey","html_url":"https://github.com/romansergey","followers_url":"https://api.github.com/users/romansergey/followers","following_url":"https://api.github.com/users/romansergey/following{/other_user}","gists_url":"https://api.github.com/users/romansergey/gists{/gist_id}","starred_url":"https://api.github.com/users/romansergey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romansergey/subscriptions","organizations_url":"https://api.github.com/users/romansergey/orgs","repos_url":"https://api.github.com/users/romansergey/repos","events_url":"https://api.github.com/users/romansergey/events{/privacy}","received_events_url":"https://api.github.com/users/romansergey/received_events","type":"User","site_admin":false},"body":"When upgrading from 1.0.x to 1.1.x, builds with dockerfile's u'False'\r\nare treated as Dockerfile based ones, because u'False' is not a falsy value.\r\nThis commit adds a migration to rectify that.\r\n\r\nThe story started here: https://github.com/deis/deis/issues/2733","created_at":"2015-01-02T01:55:51Z","updated_at":"2015-01-05T15:55:28Z","closed_at":"2015-01-05T15:55:28Z","merged_at":"2015-01-05T15:55:28Z","merge_commit_sha":"67fbf2857e9ce363cfa2e07c1f54738f21932473","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/deis/deis/pulls/2828/commits","review_comments_url":"https://api.github.com/repos/deis/deis/pulls/2828/comments","review_comment_url":"https://api.github.com/repos/deis/deis/pulls/comments/{number}","comments_url":"https://api.github.com/repos/deis/deis/issues/2828/comments","statuses_url":"https://api.github.com/repos/deis/deis/statuses/96e67e727c13af69fd948f2ea33eb9b38f04e12f","head":{"label":"romansergey:dockerfile_empty_value","ref":"dockerfile_empty_value","sha":"96e67e727c13af69fd948f2ea33eb9b38f04e12f","user":{"login":"romansergey","id":1127845,"avatar_url":"https://avatars.githubusercontent.com/u/1127845?v=3","gravatar_id":"","url":"https://api.github.com/users/romansergey","html_url":"https://github.com/romansergey","followers_url":"https://api.github.com/users/romansergey/followers","following_url":"https://api.github.com/users/romansergey/following{/other_user}","gists_url":"https://api.github.com/users/romansergey/gists{/gist_id}","starred_url":"https://api.github.com/users/romansergey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romansergey/subscriptions","organizations_url":"https://api.github.com/users/romansergey/orgs","repos_url":"https://api.github.com/users/romansergey/repos","events_url":"https://api.github.com/users/romansergey/events{/privacy}","received_events_url":"https://api.github.com/users/romansergey/received_events","type":"User","site_admin":false},"repo":{"id":25817971,"name":"deis","full_name":"romansergey/deis","owner":{"login":"romansergey","id":1127845,"avatar_url":"https://avatars.githubusercontent.com/u/1127845?v=3","gravatar_id":"","url":"https://api.github.com/users/romansergey","html_url":"https://github.com/romansergey","followers_url":"https://api.github.com/users/romansergey/followers","following_url":"https://api.github.com/users/romansergey/following{/other_user}","gists_url":"https://api.github.com/users/romansergey/gists{/gist_id}","starred_url":"https://api.github.com/users/romansergey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romansergey/subscriptions","organizations_url":"https://api.github.com/users/romansergey/orgs","repos_url":"https://api.github.com/users/romansergey/repos","events_url":"https://api.github.com/users/romansergey/events{/privacy}","received_events_url":"https://api.github.com/users/romansergey/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/romansergey/deis","description":"Your PaaS. Your Rules. ","fork":true,"url":"https://api.github.com/repos/romansergey/deis","forks_url":"https://api.github.com/repos/romansergey/deis/forks","keys_url":"https://api.github.com/repos/romansergey/deis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/romansergey/deis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/romansergey/deis/teams","hooks_url":"https://api.github.com/repos/romansergey/deis/hooks","issue_events_url":"https://api.github.com/repos/romansergey/deis/issues/events{/number}","events_url":"https://api.github.com/repos/romansergey/deis/events","assignees_url":"https://api.github.com/repos/romansergey/deis/assignees{/user}","branches_url":"https://api.github.com/repos/romansergey/deis/branches{/branch}","tags_url":"https://api.github.com/repos/romansergey/deis/tags","blobs_url":"https://api.github.com/repos/romansergey/deis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/romansergey/deis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/romansergey/deis/git/refs{/sha}","trees_url":"https://api.github.com/repos/romansergey/deis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/romansergey/deis/statuses/{sha}","languages_url":"https://api.github.com/repos/romansergey/deis/languages","stargazers_url":"https://api.github.com/repos/romansergey/deis/stargazers","contributors_url":"https://api.github.com/repos/romansergey/deis/contributors","subscribers_url":"https://api.github.com/repos/romansergey/deis/subscribers","subscription_url":"https://api.github.com/repos/romansergey/deis/subscription","commits_url":"https://api.github.com/repos/romansergey/deis/commits{/sha}","git_commits_url":"https://api.github.com/repos/romansergey/deis/git/commits{/sha}","comments_url":"https://api.github.com/repos/romansergey/deis/comments{/number}","issue_comment_url":"https://api.github.com/repos/romansergey/deis/issues/comments/{number}","contents_url":"https://api.github.com/repos/romansergey/deis/contents/{+path}","compare_url":"https://api.github.com/repos/romansergey/deis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/romansergey/deis/merges","archive_url":"https://api.github.com/repos/romansergey/deis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/romansergey/deis/downloads","issues_url":"https://api.github.com/repos/romansergey/deis/issues{/number}","pulls_url":"https://api.github.com/repos/romansergey/deis/pulls{/number}","milestones_url":"https://api.github.com/repos/romansergey/deis/milestones{/number}","notifications_url":"https://api.github.com/repos/romansergey/deis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/romansergey/deis/labels{/name}","releases_url":"https://api.github.com/repos/romansergey/deis/releases{/id}","created_at":"2014-10-27T12:29:38Z","updated_at":"2015-01-02T01:45:18Z","pushed_at":"2015-01-03T15:19:41Z","git_url":"git://github.com/romansergey/deis.git","ssh_url":"git@github.com:romansergey/deis.git","clone_url":"https://github.com/romansergey/deis.git","svn_url":"https://github.com/romansergey/deis","homepage":"http://deis.io","size":15117,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"deis:master","ref":"master","sha":"6f00ed544d8d008ae8f5769b2581e7e1897f9249","user":{"login":"deis","id":6117407,"avatar_url":"https://avatars.githubusercontent.com/u/6117407?v=3","gravatar_id":"","url":"https://api.github.com/users/deis","html_url":"https://github.com/deis","followers_url":"https://api.github.com/users/deis/followers","following_url":"https://api.github.com/users/deis/following{/other_user}","gists_url":"https://api.github.com/users/deis/gists{/gist_id}","starred_url":"https://api.github.com/users/deis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deis/subscriptions","organizations_url":"https://api.github.com/users/deis/orgs","repos_url":"https://api.github.com/users/deis/repos","events_url":"https://api.github.com/users/deis/events{/privacy}","received_events_url":"https://api.github.com/users/deis/received_events","type":"Organization","site_admin":false},"repo":{"id":11589713,"name":"deis","full_name":"deis/deis","owner":{"login":"deis","id":6117407,"avatar_url":"https://avatars.githubusercontent.com/u/6117407?v=3","gravatar_id":"","url":"https://api.github.com/users/deis","html_url":"https://github.com/deis","followers_url":"https://api.github.com/users/deis/followers","following_url":"https://api.github.com/users/deis/following{/other_user}","gists_url":"https://api.github.com/users/deis/gists{/gist_id}","starred_url":"https://api.github.com/users/deis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deis/subscriptions","organizations_url":"https://api.github.com/users/deis/orgs","repos_url":"https://api.github.com/users/deis/repos","events_url":"https://api.github.com/users/deis/events{/privacy}","received_events_url":"https://api.github.com/users/deis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/deis/deis","description":"Your PaaS. Your Rules. ","fork":false,"url":"https://api.github.com/repos/deis/deis","forks_url":"https://api.github.com/repos/deis/deis/forks","keys_url":"https://api.github.com/repos/deis/deis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/deis/deis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/deis/deis/teams","hooks_url":"https://api.github.com/repos/deis/deis/hooks","issue_events_url":"https://api.github.com/repos/deis/deis/issues/events{/number}","events_url":"https://api.github.com/repos/deis/deis/events","assignees_url":"https://api.github.com/repos/deis/deis/assignees{/user}","branches_url":"https://api.github.com/repos/deis/deis/branches{/branch}","tags_url":"https://api.github.com/repos/deis/deis/tags","blobs_url":"https://api.github.com/repos/deis/deis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/deis/deis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/deis/deis/git/refs{/sha}","trees_url":"https://api.github.com/repos/deis/deis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/deis/deis/statuses/{sha}","languages_url":"https://api.github.com/repos/deis/deis/languages","stargazers_url":"https://api.github.com/repos/deis/deis/stargazers","contributors_url":"https://api.github.com/repos/deis/deis/contributors","subscribers_url":"https://api.github.com/repos/deis/deis/subscribers","subscription_url":"https://api.github.com/repos/deis/deis/subscription","commits_url":"https://api.github.com/repos/deis/deis/commits{/sha}","git_commits_url":"https://api.github.com/repos/deis/deis/git/commits{/sha}","comments_url":"https://api.github.com/repos/deis/deis/comments{/number}","issue_comment_url":"https://api.github.com/repos/deis/deis/issues/comments/{number}","contents_url":"https://api.github.com/repos/deis/deis/contents/{+path}","compare_url":"https://api.github.com/repos/deis/deis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/deis/deis/merges","archive_url":"https://api.github.com/repos/deis/deis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/deis/deis/downloads","issues_url":"https://api.github.com/repos/deis/deis/issues{/number}","pulls_url":"https://api.github.com/repos/deis/deis/pulls{/number}","milestones_url":"https://api.github.com/repos/deis/deis/milestones{/number}","notifications_url":"https://api.github.com/repos/deis/deis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/deis/deis/labels{/name}","releases_url":"https://api.github.com/repos/deis/deis/releases{/id}","created_at":"2013-07-22T19:02:40Z","updated_at":"2015-01-05T15:24:15Z","pushed_at":"2015-01-05T15:55:28Z","git_url":"git://github.com/deis/deis.git","ssh_url":"git@github.com:deis/deis.git","clone_url":"https://github.com/deis/deis.git","svn_url":"https://github.com/deis/deis","homepage":"http://deis.io","size":31305,"stargazers_count":3603,"watchers_count":3603,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":494,"mirror_url":null,"open_issues_count":162,"forks":494,"open_issues":162,"watchers":3603,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/deis/deis/pulls/2828"},"html":{"href":"https://github.com/deis/deis/pull/2828"},"issue":{"href":"https://api.github.com/repos/deis/deis/issues/2828"},"comments":{"href":"https://api.github.com/repos/deis/deis/issues/2828/comments"},"review_comments":{"href":"https://api.github.com/repos/deis/deis/pulls/2828/comments"},"review_comment":{"href":"https://api.github.com/repos/deis/deis/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/deis/deis/pulls/2828/commits"},"statuses":{"href":"https://api.github.com/repos/deis/deis/statuses/96e67e727c13af69fd948f2ea33eb9b38f04e12f"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"bacongobbler","id":1360539,"avatar_url":"https://avatars.githubusercontent.com/u/1360539?v=3","gravatar_id":"","url":"https://api.github.com/users/bacongobbler","html_url":"https://github.com/bacongobbler","followers_url":"https://api.github.com/users/bacongobbler/followers","following_url":"https://api.github.com/users/bacongobbler/following{/other_user}","gists_url":"https://api.github.com/users/bacongobbler/gists{/gist_id}","starred_url":"https://api.github.com/users/bacongobbler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bacongobbler/subscriptions","organizations_url":"https://api.github.com/users/bacongobbler/orgs","repos_url":"https://api.github.com/users/bacongobbler/repos","events_url":"https://api.github.com/users/bacongobbler/events{/privacy}","received_events_url":"https://api.github.com/users/bacongobbler/received_events","type":"User","site_admin":false},"comments":7,"review_comments":0,"commits":2,"additions":147,"deletions":1,"changed_files":2}}