{"action":"created","issue":{"url":"https://api.github.com/repos/intel-hadoop/gearpump/issues/1092","labels_url":"https://api.github.com/repos/intel-hadoop/gearpump/issues/1092/labels{/name}","comments_url":"https://api.github.com/repos/intel-hadoop/gearpump/issues/1092/comments","events_url":"https://api.github.com/repos/intel-hadoop/gearpump/issues/1092/events","html_url":"https://github.com/intel-hadoop/gearpump/pull/1092","id":92373904,"number":1092,"title":"fix # 1053, allow user to config Kafka through API","user":{"login":"manuzhang","id":1191767,"avatar_url":"https://avatars.githubusercontent.com/u/1191767?v=3","gravatar_id":"","url":"https://api.github.com/users/manuzhang","html_url":"https://github.com/manuzhang","followers_url":"https://api.github.com/users/manuzhang/followers","following_url":"https://api.github.com/users/manuzhang/following{/other_user}","gists_url":"https://api.github.com/users/manuzhang/gists{/gist_id}","starred_url":"https://api.github.com/users/manuzhang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manuzhang/subscriptions","organizations_url":"https://api.github.com/users/manuzhang/orgs","repos_url":"https://api.github.com/users/manuzhang/repos","events_url":"https://api.github.com/users/manuzhang/events{/privacy}","received_events_url":"https://api.github.com/users/manuzhang/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2015-07-01T12:50:45Z","updated_at":"2015-07-02T03:19:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/intel-hadoop/gearpump/pulls/1092","html_url":"https://github.com/intel-hadoop/gearpump/pull/1092","diff_url":"https://github.com/intel-hadoop/gearpump/pull/1092.diff","patch_url":"https://github.com/intel-hadoop/gearpump/pull/1092.patch"},"body":"\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/intel-hadoop/gearpump/1092)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/intel-hadoop/gearpump/issues/comments/117890335","html_url":"https://github.com/intel-hadoop/gearpump/pull/1092#issuecomment-117890335","issue_url":"https://api.github.com/repos/intel-hadoop/gearpump/issues/1092","id":117890335,"user":{"login":"whjiang","id":5162753,"avatar_url":"https://avatars.githubusercontent.com/u/5162753?v=3","gravatar_id":"","url":"https://api.github.com/users/whjiang","html_url":"https://github.com/whjiang","followers_url":"https://api.github.com/users/whjiang/followers","following_url":"https://api.github.com/users/whjiang/following{/other_user}","gists_url":"https://api.github.com/users/whjiang/gists{/gist_id}","starred_url":"https://api.github.com/users/whjiang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whjiang/subscriptions","organizations_url":"https://api.github.com/users/whjiang/orgs","repos_url":"https://api.github.com/users/whjiang/repos","events_url":"https://api.github.com/users/whjiang/events{/privacy}","received_events_url":"https://api.github.com/users/whjiang/received_events","type":"User","site_admin":false},"created_at":"2015-07-02T03:19:20Z","updated_at":"2015-07-02T03:19:20Z","body":"@manuzhang several comments:\r\n1. better rename ```KafkaConsumerConfig``` to ```KafkaSourceConfig``` and ```KafkaProducerConfig``` to ```KafkaSinkConfig``` as they are used with KafkaSource and KafkaSink in Gearpump.\r\n2. for sink, ```KakfaProducerConfig``` seems OK to me.\r\n3. for source, why we need producer config here? For offset management? If so, I suggest you to put offset into another central place. And why we need ```GearpumpKafkaConfig```? Can we ONLY use ```KafkaConsumerConfig``` for data source?"}}