{"action":"created","comment":{"url":"https://api.github.com/repos/lightblue-platform/lightblue-mongo/pulls/comments/34290665","id":34290665,"diff_hunk":"@@ -349,11 +347,10 @@ public CRUDFindResponse find(CRUDOperationContext ctx,\n                 ctx.addError(Error.get(MongoCrudConstants.ERR_NO_ACCESS, \"find:\" + ctx.getEntityName()));\n             }\n         } catch (Error e) {\n-            // rethrow lightblue error\n-            throw e;\n+            ctx.addError(e);","path":"crud/src/main/java/com/redhat/lightblue/crud/mongo/MongoCRUDController.java","position":100,"original_position":100,"commit_id":"6dd0fbb221202ea5eb87e91306127f42b97a4903","original_commit_id":"6dd0fbb221202ea5eb87e91306127f42b97a4903","user":{"login":"paterczm","id":4681035,"avatar_url":"https://avatars.githubusercontent.com/u/4681035?v=3","gravatar_id":"","url":"https://api.github.com/users/paterczm","html_url":"https://github.com/paterczm","followers_url":"https://api.github.com/users/paterczm/followers","following_url":"https://api.github.com/users/paterczm/following{/other_user}","gists_url":"https://api.github.com/users/paterczm/gists{/gist_id}","starred_url":"https://api.github.com/users/paterczm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paterczm/subscriptions","organizations_url":"https://api.github.com/users/paterczm/orgs","repos_url":"https://api.github.com/users/paterczm/repos","events_url":"https://api.github.com/users/paterczm/events{/privacy}","received_events_url":"https://api.github.com/users/paterczm/received_events","type":"User","site_admin":false},"body":"Why isn't the error logged (LOGGER.error) here? It's very helpful to have all errors logged lightblue side, clients may not log them.","created_at":"2015-07-09T18:59:54Z","updated_at":"2015-07-09T18:59:54Z","html_url":"https://github.com/lightblue-platform/lightblue-mongo/pull/130#discussion_r34290665","pull_request_url":"https://api.github.com/repos/lightblue-platform/lightblue-mongo/pulls/130","_links":{"self":{"href":"https://api.github.com/repos/lightblue-platform/lightblue-mongo/pulls/comments/34290665"},"html":{"href":"https://github.com/lightblue-platform/lightblue-mongo/pull/130#discussion_r34290665"},"pull_request":{"href":"https://api.github.com/repos/lightblue-platform/lightblue-mongo/pulls/130"}}},"pull_request":{"url":"https://api.github.com/repos/lightblue-platform/lightblue-mongo/pulls/130","id":39616086,"html_url":"https://github.com/lightblue-platform/lightblue-mongo/pull/130","diff_url":"https://github.com/lightblue-platform/lightblue-mongo/pull/130.diff","patch_url":"https://github.com/lightblue-platform/lightblue-mongo/pull/130.patch","issue_url":"https://api.github.com/repos/lightblue-platform/lightblue-mongo/issues/130","number":130,"state":"open","locked":false,"title":"Put all errors into the context instead of throwing them, so they won…","user":{"login":"bserdar","id":3670797,"avatar_url":"https://avatars.githubusercontent.com/u/3670797?v=3","gravatar_id":"","url":"https://api.github.com/users/bserdar","html_url":"https://github.com/bserdar","followers_url":"https://api.github.com/users/bserdar/followers","following_url":"https://api.github.com/users/bserdar/following{/other_user}","gists_url":"https://api.github.com/users/bserdar/gists{/gist_id}","starred_url":"https://api.github.com/users/bserdar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bserdar/subscriptions","organizations_url":"https://api.github.com/users/bserdar/orgs","repos_url":"https://api.github.com/users/bserdar/repos","events_url":"https://api.github.com/users/bserdar/events{/privacy}","received_events_url":"https://api.github.com/users/bserdar/received_events","type":"User","site_admin":false},"body":"…'t be lost","created_at":"2015-07-09T18:55:45Z","updated_at":"2015-07-09T18:59:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9bcc33165a45e147fbb2537f54c8d378802eda63","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/lightblue-platform/lightblue-mongo/pulls/130/commits","review_comments_url":"https://api.github.com/repos/lightblue-platform/lightblue-mongo/pulls/130/comments","review_comment_url":"https://api.github.com/repos/lightblue-platform/lightblue-mongo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lightblue-platform/lightblue-mongo/issues/130/comments","statuses_url":"https://api.github.com/repos/lightblue-platform/lightblue-mongo/statuses/6dd0fbb221202ea5eb87e91306127f42b97a4903","head":{"label":"bserdar:pass-errors-in-ctx","ref":"pass-errors-in-ctx","sha":"6dd0fbb221202ea5eb87e91306127f42b97a4903","user":{"login":"bserdar","id":3670797,"avatar_url":"https://avatars.githubusercontent.com/u/3670797?v=3","gravatar_id":"","url":"https://api.github.com/users/bserdar","html_url":"https://github.com/bserdar","followers_url":"https://api.github.com/users/bserdar/followers","following_url":"https://api.github.com/users/bserdar/following{/other_user}","gists_url":"https://api.github.com/users/bserdar/gists{/gist_id}","starred_url":"https://api.github.com/users/bserdar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bserdar/subscriptions","organizations_url":"https://api.github.com/users/bserdar/orgs","repos_url":"https://api.github.com/users/bserdar/repos","events_url":"https://api.github.com/users/bserdar/events{/privacy}","received_events_url":"https://api.github.com/users/bserdar/received_events","type":"User","site_admin":false},"repo":{"id":26286468,"name":"lightblue-mongo","full_name":"bserdar/lightblue-mongo","owner":{"login":"bserdar","id":3670797,"avatar_url":"https://avatars.githubusercontent.com/u/3670797?v=3","gravatar_id":"","url":"https://api.github.com/users/bserdar","html_url":"https://github.com/bserdar","followers_url":"https://api.github.com/users/bserdar/followers","following_url":"https://api.github.com/users/bserdar/following{/other_user}","gists_url":"https://api.github.com/users/bserdar/gists{/gist_id}","starred_url":"https://api.github.com/users/bserdar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bserdar/subscriptions","organizations_url":"https://api.github.com/users/bserdar/orgs","repos_url":"https://api.github.com/users/bserdar/repos","events_url":"https://api.github.com/users/bserdar/events{/privacy}","received_events_url":"https://api.github.com/users/bserdar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bserdar/lightblue-mongo","description":"","fork":true,"url":"https://api.github.com/repos/bserdar/lightblue-mongo","forks_url":"https://api.github.com/repos/bserdar/lightblue-mongo/forks","keys_url":"https://api.github.com/repos/bserdar/lightblue-mongo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bserdar/lightblue-mongo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bserdar/lightblue-mongo/teams","hooks_url":"https://api.github.com/repos/bserdar/lightblue-mongo/hooks","issue_events_url":"https://api.github.com/repos/bserdar/lightblue-mongo/issues/events{/number}","events_url":"https://api.github.com/repos/bserdar/lightblue-mongo/events","assignees_url":"https://api.github.com/repos/bserdar/lightblue-mongo/assignees{/user}","branches_url":"https://api.github.com/repos/bserdar/lightblue-mongo/branches{/branch}","tags_url":"https://api.github.com/repos/bserdar/lightblue-mongo/tags","blobs_url":"https://api.github.com/repos/bserdar/lightblue-mongo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bserdar/lightblue-mongo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bserdar/lightblue-mongo/git/refs{/sha}","trees_url":"https://api.github.com/repos/bserdar/lightblue-mongo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bserdar/lightblue-mongo/statuses/{sha}","languages_url":"https://api.github.com/repos/bserdar/lightblue-mongo/languages","stargazers_url":"https://api.github.com/repos/bserdar/lightblue-mongo/stargazers","contributors_url":"https://api.github.com/repos/bserdar/lightblue-mongo/contributors","subscribers_url":"https://api.github.com/repos/bserdar/lightblue-mongo/subscribers","subscription_url":"https://api.github.com/repos/bserdar/lightblue-mongo/subscription","commits_url":"https://api.github.com/repos/bserdar/lightblue-mongo/commits{/sha}","git_commits_url":"https://api.github.com/repos/bserdar/lightblue-mongo/git/commits{/sha}","comments_url":"https://api.github.com/repos/bserdar/lightblue-mongo/comments{/number}","issue_comment_url":"https://api.github.com/repos/bserdar/lightblue-mongo/issues/comments{/number}","contents_url":"https://api.github.com/repos/bserdar/lightblue-mongo/contents/{+path}","compare_url":"https://api.github.com/repos/bserdar/lightblue-mongo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bserdar/lightblue-mongo/merges","archive_url":"https://api.github.com/repos/bserdar/lightblue-mongo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bserdar/lightblue-mongo/downloads","issues_url":"https://api.github.com/repos/bserdar/lightblue-mongo/issues{/number}","pulls_url":"https://api.github.com/repos/bserdar/lightblue-mongo/pulls{/number}","milestones_url":"https://api.github.com/repos/bserdar/lightblue-mongo/milestones{/number}","notifications_url":"https://api.github.com/repos/bserdar/lightblue-mongo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bserdar/lightblue-mongo/labels{/name}","releases_url":"https://api.github.com/repos/bserdar/lightblue-mongo/releases{/id}","created_at":"2014-11-06T19:38:35Z","updated_at":"2015-04-27T19:32:59Z","pushed_at":"2015-07-09T18:55:02Z","git_url":"git://github.com/bserdar/lightblue-mongo.git","ssh_url":"git@github.com:bserdar/lightblue-mongo.git","clone_url":"https://github.com/bserdar/lightblue-mongo.git","svn_url":"https://github.com/bserdar/lightblue-mongo","homepage":null,"size":1190,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"lightblue-platform:master","ref":"master","sha":"d1c01446116de5558fd4fb9aeef10e68e5001a1a","user":{"login":"lightblue-platform","id":7061725,"avatar_url":"https://avatars.githubusercontent.com/u/7061725?v=3","gravatar_id":"","url":"https://api.github.com/users/lightblue-platform","html_url":"https://github.com/lightblue-platform","followers_url":"https://api.github.com/users/lightblue-platform/followers","following_url":"https://api.github.com/users/lightblue-platform/following{/other_user}","gists_url":"https://api.github.com/users/lightblue-platform/gists{/gist_id}","starred_url":"https://api.github.com/users/lightblue-platform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lightblue-platform/subscriptions","organizations_url":"https://api.github.com/users/lightblue-platform/orgs","repos_url":"https://api.github.com/users/lightblue-platform/repos","events_url":"https://api.github.com/users/lightblue-platform/events{/privacy}","received_events_url":"https://api.github.com/users/lightblue-platform/received_events","type":"Organization","site_admin":false},"repo":{"id":23001350,"name":"lightblue-mongo","full_name":"lightblue-platform/lightblue-mongo","owner":{"login":"lightblue-platform","id":7061725,"avatar_url":"https://avatars.githubusercontent.com/u/7061725?v=3","gravatar_id":"","url":"https://api.github.com/users/lightblue-platform","html_url":"https://github.com/lightblue-platform","followers_url":"https://api.github.com/users/lightblue-platform/followers","following_url":"https://api.github.com/users/lightblue-platform/following{/other_user}","gists_url":"https://api.github.com/users/lightblue-platform/gists{/gist_id}","starred_url":"https://api.github.com/users/lightblue-platform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lightblue-platform/subscriptions","organizations_url":"https://api.github.com/users/lightblue-platform/orgs","repos_url":"https://api.github.com/users/lightblue-platform/repos","events_url":"https://api.github.com/users/lightblue-platform/events{/privacy}","received_events_url":"https://api.github.com/users/lightblue-platform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lightblue-platform/lightblue-mongo","description":"","fork":false,"url":"https://api.github.com/repos/lightblue-platform/lightblue-mongo","forks_url":"https://api.github.com/repos/lightblue-platform/lightblue-mongo/forks","keys_url":"https://api.github.com/repos/lightblue-platform/lightblue-mongo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lightblue-platform/lightblue-mongo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lightblue-platform/lightblue-mongo/teams","hooks_url":"https://api.github.com/repos/lightblue-platform/lightblue-mongo/hooks","issue_events_url":"https://api.github.com/repos/lightblue-platform/lightblue-mongo/issues/events{/number}","events_url":"https://api.github.com/repos/lightblue-platform/lightblue-mongo/events","assignees_url":"https://api.github.com/repos/lightblue-platform/lightblue-mongo/assignees{/user}","branches_url":"https://api.github.com/repos/lightblue-platform/lightblue-mongo/branches{/branch}","tags_url":"https://api.github.com/repos/lightblue-platform/lightblue-mongo/tags","blobs_url":"https://api.github.com/repos/lightblue-platform/lightblue-mongo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lightblue-platform/lightblue-mongo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lightblue-platform/lightblue-mongo/git/refs{/sha}","trees_url":"https://api.github.com/repos/lightblue-platform/lightblue-mongo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lightblue-platform/lightblue-mongo/statuses/{sha}","languages_url":"https://api.github.com/repos/lightblue-platform/lightblue-mongo/languages","stargazers_url":"https://api.github.com/repos/lightblue-platform/lightblue-mongo/stargazers","contributors_url":"https://api.github.com/repos/lightblue-platform/lightblue-mongo/contributors","subscribers_url":"https://api.github.com/repos/lightblue-platform/lightblue-mongo/subscribers","subscription_url":"https://api.github.com/repos/lightblue-platform/lightblue-mongo/subscription","commits_url":"https://api.github.com/repos/lightblue-platform/lightblue-mongo/commits{/sha}","git_commits_url":"https://api.github.com/repos/lightblue-platform/lightblue-mongo/git/commits{/sha}","comments_url":"https://api.github.com/repos/lightblue-platform/lightblue-mongo/comments{/number}","issue_comment_url":"https://api.github.com/repos/lightblue-platform/lightblue-mongo/issues/comments{/number}","contents_url":"https://api.github.com/repos/lightblue-platform/lightblue-mongo/contents/{+path}","compare_url":"https://api.github.com/repos/lightblue-platform/lightblue-mongo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lightblue-platform/lightblue-mongo/merges","archive_url":"https://api.github.com/repos/lightblue-platform/lightblue-mongo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lightblue-platform/lightblue-mongo/downloads","issues_url":"https://api.github.com/repos/lightblue-platform/lightblue-mongo/issues{/number}","pulls_url":"https://api.github.com/repos/lightblue-platform/lightblue-mongo/pulls{/number}","milestones_url":"https://api.github.com/repos/lightblue-platform/lightblue-mongo/milestones{/number}","notifications_url":"https://api.github.com/repos/lightblue-platform/lightblue-mongo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lightblue-platform/lightblue-mongo/labels{/name}","releases_url":"https://api.github.com/repos/lightblue-platform/lightblue-mongo/releases{/id}","created_at":"2014-08-15T19:57:37Z","updated_at":"2015-05-07T13:25:28Z","pushed_at":"2015-07-09T18:55:45Z","git_url":"git://github.com/lightblue-platform/lightblue-mongo.git","ssh_url":"git@github.com:lightblue-platform/lightblue-mongo.git","clone_url":"https://github.com/lightblue-platform/lightblue-mongo.git","svn_url":"https://github.com/lightblue-platform/lightblue-mongo","homepage":null,"size":1449,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":19,"forks":6,"open_issues":19,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lightblue-platform/lightblue-mongo/pulls/130"},"html":{"href":"https://github.com/lightblue-platform/lightblue-mongo/pull/130"},"issue":{"href":"https://api.github.com/repos/lightblue-platform/lightblue-mongo/issues/130"},"comments":{"href":"https://api.github.com/repos/lightblue-platform/lightblue-mongo/issues/130/comments"},"review_comments":{"href":"https://api.github.com/repos/lightblue-platform/lightblue-mongo/pulls/130/comments"},"review_comment":{"href":"https://api.github.com/repos/lightblue-platform/lightblue-mongo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lightblue-platform/lightblue-mongo/pulls/130/commits"},"statuses":{"href":"https://api.github.com/repos/lightblue-platform/lightblue-mongo/statuses/6dd0fbb221202ea5eb87e91306127f42b97a4903"}}}}