{"action":"created","issue":{"url":"https://api.github.com/repos/mavlink/qgroundcontrol/issues/2330","labels_url":"https://api.github.com/repos/mavlink/qgroundcontrol/issues/2330/labels{/name}","comments_url":"https://api.github.com/repos/mavlink/qgroundcontrol/issues/2330/comments","events_url":"https://api.github.com/repos/mavlink/qgroundcontrol/issues/2330/events","html_url":"https://github.com/mavlink/qgroundcontrol/pull/2330","id":119990879,"number":2330,"title":"Add the initial stub for the AirFrame configuration for APM","user":{"login":"tcanabrava","id":4027216,"avatar_url":"https://avatars.githubusercontent.com/u/4027216?v=3","gravatar_id":"","url":"https://api.github.com/users/tcanabrava","html_url":"https://github.com/tcanabrava","followers_url":"https://api.github.com/users/tcanabrava/followers","following_url":"https://api.github.com/users/tcanabrava/following{/other_user}","gists_url":"https://api.github.com/users/tcanabrava/gists{/gist_id}","starred_url":"https://api.github.com/users/tcanabrava/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tcanabrava/subscriptions","organizations_url":"https://api.github.com/users/tcanabrava/orgs","repos_url":"https://api.github.com/users/tcanabrava/repos","events_url":"https://api.github.com/users/tcanabrava/events{/privacy}","received_events_url":"https://api.github.com/users/tcanabrava/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":10,"created_at":"2015-12-02T17:11:54Z","updated_at":"2015-12-06T01:16:46Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mavlink/qgroundcontrol/pulls/2330","html_url":"https://github.com/mavlink/qgroundcontrol/pull/2330","diff_url":"https://github.com/mavlink/qgroundcontrol/pull/2330.diff","patch_url":"https://github.com/mavlink/qgroundcontrol/pull/2330.patch"},"body":"This commit introduces the APM Airframe configuration. The interface\r\nis the same as the PX4 one, but the way we deal with the uas is a bit different\r\n\r\nSince the APM stack doesn't provide a xml with airframe definitions a\r\nnew one was created by hand with only the values that we need, wich will\r\ntrigger a download of the parameters file from the mavlink github\r\n\r\nNow it correctly handles the FRAME variable and it's faster\r\nregarding the download of the parameters for each type of Frame.\r\n\r\nSigned-off-by: Tomaz Canabrava <tomaz.canabrava@intel.com>"},"comment":{"url":"https://api.github.com/repos/mavlink/qgroundcontrol/issues/comments/162261697","html_url":"https://github.com/mavlink/qgroundcontrol/pull/2330#issuecomment-162261697","issue_url":"https://api.github.com/repos/mavlink/qgroundcontrol/issues/2330","id":162261697,"user":{"login":"tcanabrava","id":4027216,"avatar_url":"https://avatars.githubusercontent.com/u/4027216?v=3","gravatar_id":"","url":"https://api.github.com/users/tcanabrava","html_url":"https://github.com/tcanabrava","followers_url":"https://api.github.com/users/tcanabrava/followers","following_url":"https://api.github.com/users/tcanabrava/following{/other_user}","gists_url":"https://api.github.com/users/tcanabrava/gists{/gist_id}","starred_url":"https://api.github.com/users/tcanabrava/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tcanabrava/subscriptions","organizations_url":"https://api.github.com/users/tcanabrava/orgs","repos_url":"https://api.github.com/users/tcanabrava/repos","events_url":"https://api.github.com/users/tcanabrava/events{/privacy}","received_events_url":"https://api.github.com/users/tcanabrava/received_events","type":"User","site_admin":false},"created_at":"2015-12-06T01:16:46Z","updated_at":"2015-12-06T01:16:46Z","body":"Okay,\n\nWill redo the configuration screen tomorrow and send a v4. Thanks for your\ntime on this as I have never worked with drones before.\n\nI think I figured out a good solution that can use qgroundcontrol visuals\nI'm a two step way.\n\nTomaz\nEm 5 de dez de 2015 20:46, \"Don Gagne\" <notifications@github.com> escreveu:\n\n> I don't think two different configuration views for airframes in the same\n> software is a good thing,\n>\n> Not for APM users, they are only family with APM Planner and Mission\n> Planner. So in reality trying to stay consistent only makes sense if the\n> user model really is the same. The issue is that PX4 Stack keep track of a\n> very specific vehicle that you have selecting using the SYS_AUTOSTART\n> parameter. The values essentially stores both frame type and a default\n> parameter set in a single value. The APM stack only store Frame type. It\n> does not store the specific vehicle type. APM users are used to a two step\n> process to work around this. They select frame type and then they\n> optionally select a parameter set they can load.\n>\n> Your implementation will end up being confusing. More detailed example:\n>\n>    - Select Frame type X\n>    - Select Parameter set 3DR QUAD X4 RTF\n>    - Click apply\n>    - Move away from Airframe Config\n>    - Go back, X Frame will still be selected but 3DR X8-M RTF will be\n>    selected in the dropdown.\n>    - User is confused, thinks something is wrong. Selects 3DR QUAD X4 RTF\n>    yet again.\n>    - Repeat...\n>\n> There is no way to fix this problem since the selected parameter set is\n> not saved with the vehicle. The UI you are using gives the illusion that\n> this value should be saved, but it is not. It also differs from the PX4\n> implementation which does save the setting. That just doesn't pass my\n> usability bar.\n>\n> Similarity is good, but not when it is only slightly similar and the\n> actual differences will cause confusion. In that case you are much better\n> off with something different.\n>\n> This needs to be a two step process like it is in APMP and MP. This makes\n> it clear to the user what is actually happening.\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/mavlink/qgroundcontrol/pull/2330#issuecomment-162257604>\n> .\n>\n"}}