{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/pulls/comments/41475615","id":41475615,"diff_hunk":"@@ -0,0 +1,199 @@\n+\n+CREATE TABLE devices (\n+  uid BINARY(16) NOT NULL,\n+  id INT UNSIGNED NOT NULL,","path":"lib/db/schema/patch-018-019.sql","position":4,"original_position":4,"commit_id":"aec406661ed8bceacee53d5b1c83d12376a8e567","original_commit_id":"aec406661ed8bceacee53d5b1c83d12376a8e567","user":{"login":"dannycoates","id":87619,"avatar_url":"https://avatars.githubusercontent.com/u/87619?v=3","gravatar_id":"","url":"https://api.github.com/users/dannycoates","html_url":"https://github.com/dannycoates","followers_url":"https://api.github.com/users/dannycoates/followers","following_url":"https://api.github.com/users/dannycoates/following{/other_user}","gists_url":"https://api.github.com/users/dannycoates/gists{/gist_id}","starred_url":"https://api.github.com/users/dannycoates/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dannycoates/subscriptions","organizations_url":"https://api.github.com/users/dannycoates/orgs","repos_url":"https://api.github.com/users/dannycoates/repos","events_url":"https://api.github.com/users/dannycoates/events{/privacy}","received_events_url":"https://api.github.com/users/dannycoates/received_events","type":"User","site_admin":false},"body":"I had it as `SMALLINT`but changed it because we *may* want a device id for web sessions at some point and I'd rather never reuse an id (attach detach attach detach) *just in case*. 65k is a lot but not well beyond my imagination for strange user behavior.","created_at":"2015-10-08T04:39:02Z","updated_at":"2015-10-08T04:39:02Z","html_url":"https://github.com/mozilla/fxa-auth-db-mysql/pull/110#discussion_r41475615","pull_request_url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/pulls/110","_links":{"self":{"href":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/pulls/comments/41475615"},"html":{"href":"https://github.com/mozilla/fxa-auth-db-mysql/pull/110#discussion_r41475615"},"pull_request":{"href":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/pulls/110"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/pulls/110","id":46839288,"html_url":"https://github.com/mozilla/fxa-auth-db-mysql/pull/110","diff_url":"https://github.com/mozilla/fxa-auth-db-mysql/pull/110.diff","patch_url":"https://github.com/mozilla/fxa-auth-db-mysql/pull/110.patch","issue_url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/issues/110","number":110,"state":"open","locked":false,"title":"device api endpoints","user":{"login":"dannycoates","id":87619,"avatar_url":"https://avatars.githubusercontent.com/u/87619?v=3","gravatar_id":"","url":"https://api.github.com/users/dannycoates","html_url":"https://github.com/dannycoates","followers_url":"https://api.github.com/users/dannycoates/followers","following_url":"https://api.github.com/users/dannycoates/following{/other_user}","gists_url":"https://api.github.com/users/dannycoates/gists{/gist_id}","starred_url":"https://api.github.com/users/dannycoates/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dannycoates/subscriptions","organizations_url":"https://api.github.com/users/dannycoates/orgs","repos_url":"https://api.github.com/users/dannycoates/repos","events_url":"https://api.github.com/users/dannycoates/events{/privacy}","received_events_url":"https://api.github.com/users/dannycoates/received_events","type":"User","site_admin":false},"body":"new endpoints for the device api","created_at":"2015-10-05T21:55:51Z","updated_at":"2015-10-08T04:39:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4bfcc187a5337e96858d385f1a045df812a80ee3","assignee":null,"milestone":{"url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/milestones/16","html_url":"https://github.com/mozilla/fxa-auth-db-mysql/milestones/FxA-45:%20device%20registration","labels_url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/milestones/16/labels","id":1289567,"number":16,"title":"FxA-45: device registration","description":"https://mozilla.aha.io/features/FXA-45","creator":{"login":"rfk","id":34695,"avatar_url":"https://avatars.githubusercontent.com/u/34695?v=3","gravatar_id":"","url":"https://api.github.com/users/rfk","html_url":"https://github.com/rfk","followers_url":"https://api.github.com/users/rfk/followers","following_url":"https://api.github.com/users/rfk/following{/other_user}","gists_url":"https://api.github.com/users/rfk/gists{/gist_id}","starred_url":"https://api.github.com/users/rfk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rfk/subscriptions","organizations_url":"https://api.github.com/users/rfk/orgs","repos_url":"https://api.github.com/users/rfk/repos","events_url":"https://api.github.com/users/rfk/events{/privacy}","received_events_url":"https://api.github.com/users/rfk/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":0,"state":"open","created_at":"2015-09-04T06:09:06Z","updated_at":"2015-10-08T03:42:18Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/pulls/110/commits","review_comments_url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/pulls/110/comments","review_comment_url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/issues/110/comments","statuses_url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/statuses/aec406661ed8bceacee53d5b1c83d12376a8e567","head":{"label":"dannycoates:i104","ref":"i104","sha":"aec406661ed8bceacee53d5b1c83d12376a8e567","user":{"login":"dannycoates","id":87619,"avatar_url":"https://avatars.githubusercontent.com/u/87619?v=3","gravatar_id":"","url":"https://api.github.com/users/dannycoates","html_url":"https://github.com/dannycoates","followers_url":"https://api.github.com/users/dannycoates/followers","following_url":"https://api.github.com/users/dannycoates/following{/other_user}","gists_url":"https://api.github.com/users/dannycoates/gists{/gist_id}","starred_url":"https://api.github.com/users/dannycoates/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dannycoates/subscriptions","organizations_url":"https://api.github.com/users/dannycoates/orgs","repos_url":"https://api.github.com/users/dannycoates/repos","events_url":"https://api.github.com/users/dannycoates/events{/privacy}","received_events_url":"https://api.github.com/users/dannycoates/received_events","type":"User","site_admin":false},"repo":{"id":39918760,"name":"fxa-auth-db-mysql","full_name":"dannycoates/fxa-auth-db-mysql","owner":{"login":"dannycoates","id":87619,"avatar_url":"https://avatars.githubusercontent.com/u/87619?v=3","gravatar_id":"","url":"https://api.github.com/users/dannycoates","html_url":"https://github.com/dannycoates","followers_url":"https://api.github.com/users/dannycoates/followers","following_url":"https://api.github.com/users/dannycoates/following{/other_user}","gists_url":"https://api.github.com/users/dannycoates/gists{/gist_id}","starred_url":"https://api.github.com/users/dannycoates/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dannycoates/subscriptions","organizations_url":"https://api.github.com/users/dannycoates/orgs","repos_url":"https://api.github.com/users/dannycoates/repos","events_url":"https://api.github.com/users/dannycoates/events{/privacy}","received_events_url":"https://api.github.com/users/dannycoates/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dannycoates/fxa-auth-db-mysql","description":"MySql backend for the fxa-auth-db-server","fork":true,"url":"https://api.github.com/repos/dannycoates/fxa-auth-db-mysql","forks_url":"https://api.github.com/repos/dannycoates/fxa-auth-db-mysql/forks","keys_url":"https://api.github.com/repos/dannycoates/fxa-auth-db-mysql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dannycoates/fxa-auth-db-mysql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dannycoates/fxa-auth-db-mysql/teams","hooks_url":"https://api.github.com/repos/dannycoates/fxa-auth-db-mysql/hooks","issue_events_url":"https://api.github.com/repos/dannycoates/fxa-auth-db-mysql/issues/events{/number}","events_url":"https://api.github.com/repos/dannycoates/fxa-auth-db-mysql/events","assignees_url":"https://api.github.com/repos/dannycoates/fxa-auth-db-mysql/assignees{/user}","branches_url":"https://api.github.com/repos/dannycoates/fxa-auth-db-mysql/branches{/branch}","tags_url":"https://api.github.com/repos/dannycoates/fxa-auth-db-mysql/tags","blobs_url":"https://api.github.com/repos/dannycoates/fxa-auth-db-mysql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dannycoates/fxa-auth-db-mysql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dannycoates/fxa-auth-db-mysql/git/refs{/sha}","trees_url":"https://api.github.com/repos/dannycoates/fxa-auth-db-mysql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dannycoates/fxa-auth-db-mysql/statuses/{sha}","languages_url":"https://api.github.com/repos/dannycoates/fxa-auth-db-mysql/languages","stargazers_url":"https://api.github.com/repos/dannycoates/fxa-auth-db-mysql/stargazers","contributors_url":"https://api.github.com/repos/dannycoates/fxa-auth-db-mysql/contributors","subscribers_url":"https://api.github.com/repos/dannycoates/fxa-auth-db-mysql/subscribers","subscription_url":"https://api.github.com/repos/dannycoates/fxa-auth-db-mysql/subscription","commits_url":"https://api.github.com/repos/dannycoates/fxa-auth-db-mysql/commits{/sha}","git_commits_url":"https://api.github.com/repos/dannycoates/fxa-auth-db-mysql/git/commits{/sha}","comments_url":"https://api.github.com/repos/dannycoates/fxa-auth-db-mysql/comments{/number}","issue_comment_url":"https://api.github.com/repos/dannycoates/fxa-auth-db-mysql/issues/comments{/number}","contents_url":"https://api.github.com/repos/dannycoates/fxa-auth-db-mysql/contents/{+path}","compare_url":"https://api.github.com/repos/dannycoates/fxa-auth-db-mysql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dannycoates/fxa-auth-db-mysql/merges","archive_url":"https://api.github.com/repos/dannycoates/fxa-auth-db-mysql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dannycoates/fxa-auth-db-mysql/downloads","issues_url":"https://api.github.com/repos/dannycoates/fxa-auth-db-mysql/issues{/number}","pulls_url":"https://api.github.com/repos/dannycoates/fxa-auth-db-mysql/pulls{/number}","milestones_url":"https://api.github.com/repos/dannycoates/fxa-auth-db-mysql/milestones{/number}","notifications_url":"https://api.github.com/repos/dannycoates/fxa-auth-db-mysql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dannycoates/fxa-auth-db-mysql/labels{/name}","releases_url":"https://api.github.com/repos/dannycoates/fxa-auth-db-mysql/releases{/id}","created_at":"2015-07-29T22:10:58Z","updated_at":"2015-07-29T22:10:59Z","pushed_at":"2015-10-08T00:12:59Z","git_url":"git://github.com/dannycoates/fxa-auth-db-mysql.git","ssh_url":"git@github.com:dannycoates/fxa-auth-db-mysql.git","clone_url":"https://github.com/dannycoates/fxa-auth-db-mysql.git","svn_url":"https://github.com/dannycoates/fxa-auth-db-mysql","homepage":"","size":505,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"462981acb897fedbae0f6527abc7e30a30ba0faf","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":23937466,"name":"fxa-auth-db-mysql","full_name":"mozilla/fxa-auth-db-mysql","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/fxa-auth-db-mysql","description":"MySql backend for the fxa-auth-db-server","fork":false,"url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql","forks_url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/forks","keys_url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/teams","hooks_url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/hooks","issue_events_url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/events","assignees_url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/tags","blobs_url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/languages","stargazers_url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/stargazers","contributors_url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/contributors","subscribers_url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/subscribers","subscription_url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/subscription","commits_url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/merges","archive_url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/downloads","issues_url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/releases{/id}","created_at":"2014-09-11T22:06:52Z","updated_at":"2015-06-25T04:52:09Z","pushed_at":"2015-10-08T00:13:00Z","git_url":"git://github.com/mozilla/fxa-auth-db-mysql.git","ssh_url":"git@github.com:mozilla/fxa-auth-db-mysql.git","clone_url":"https://github.com/mozilla/fxa-auth-db-mysql.git","svn_url":"https://github.com/mozilla/fxa-auth-db-mysql","homepage":"","size":1280,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":7,"forks":10,"open_issues":7,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/pulls/110"},"html":{"href":"https://github.com/mozilla/fxa-auth-db-mysql/pull/110"},"issue":{"href":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/issues/110"},"comments":{"href":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/issues/110/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/pulls/110/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/pulls/110/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/fxa-auth-db-mysql/statuses/aec406661ed8bceacee53d5b1c83d12376a8e567"}}}}