{"action":"created","comment":{"url":"https://api.github.com/repos/openssl/openssl/pulls/comments/40950032","id":40950032,"diff_hunk":"@@ -3770,6 +3769,34 @@ OPENSSL_GLOBAL const SSL_CIPHER ssl3_ciphers[] = {\n      256,\n      },\n \n+    {\n+     1,\n+     \"GOST2012-GOST8912-GOST8912\",\n+     0x0300ff85,\n+     SSL_kGOST,\n+     SSL_aGOST12 | SSL_aGOST01,\n+     SSL_eGOST2814789CNT12,\n+     SSL_GOST89MAC12,\n+     SSL_TLSV1,\n+     SSL_NOT_EXP | SSL_HIGH,\n+     SSL_HANDSHAKE_MAC_GOST12_256 | TLS1_PRF_GOST12_256 | TLS1_STREAM_MAC,","path":"ssl/s3_lib.c","position":22,"original_position":22,"commit_id":"647b78a8ee012129275559dabcae0b016d39ff93","original_commit_id":"f6628508016a4e67123e273121d85ac5c562b4b2","user":{"login":"beldmit","id":13785747,"avatar_url":"https://avatars.githubusercontent.com/u/13785747?v=3","gravatar_id":"","url":"https://api.github.com/users/beldmit","html_url":"https://github.com/beldmit","followers_url":"https://api.github.com/users/beldmit/followers","following_url":"https://api.github.com/users/beldmit/following{/other_user}","gists_url":"https://api.github.com/users/beldmit/gists{/gist_id}","starred_url":"https://api.github.com/users/beldmit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beldmit/subscriptions","organizations_url":"https://api.github.com/users/beldmit/orgs","repos_url":"https://api.github.com/users/beldmit/repos","events_url":"https://api.github.com/users/beldmit/events{/privacy}","received_events_url":"https://api.github.com/users/beldmit/received_events","type":"User","site_admin":false},"body":"I got it!\r\n\r\nThe problem is in the tls1_final_finish_mac function. It calls the ssl_handshake_hash function calling the ssl_get_handshake_digest.\r\n\r\nIn the variant you suggest all the GOST hashes are calculated and concatenated. In the variant I suggest we calculate only the necessary one. ","created_at":"2015-10-01T18:38:39Z","updated_at":"2015-10-01T18:38:39Z","html_url":"https://github.com/openssl/openssl/pull/407#discussion_r40950032","pull_request_url":"https://api.github.com/repos/openssl/openssl/pulls/407","_links":{"self":{"href":"https://api.github.com/repos/openssl/openssl/pulls/comments/40950032"},"html":{"href":"https://github.com/openssl/openssl/pull/407#discussion_r40950032"},"pull_request":{"href":"https://api.github.com/repos/openssl/openssl/pulls/407"}}},"pull_request":{"url":"https://api.github.com/repos/openssl/openssl/pulls/407","id":45586994,"html_url":"https://github.com/openssl/openssl/pull/407","diff_url":"https://github.com/openssl/openssl/pull/407.diff","patch_url":"https://github.com/openssl/openssl/pull/407.patch","issue_url":"https://api.github.com/repos/openssl/openssl/issues/407","number":407,"state":"open","locked":false,"title":"Patch containing TLS implementation for GOST 2012","user":{"login":"beldmit","id":13785747,"avatar_url":"https://avatars.githubusercontent.com/u/13785747?v=3","gravatar_id":"","url":"https://api.github.com/users/beldmit","html_url":"https://github.com/beldmit","followers_url":"https://api.github.com/users/beldmit/followers","following_url":"https://api.github.com/users/beldmit/following{/other_user}","gists_url":"https://api.github.com/users/beldmit/gists{/gist_id}","starred_url":"https://api.github.com/users/beldmit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beldmit/subscriptions","organizations_url":"https://api.github.com/users/beldmit/orgs","repos_url":"https://api.github.com/users/beldmit/repos","events_url":"https://api.github.com/users/beldmit/events{/privacy}","received_events_url":"https://api.github.com/users/beldmit/received_events","type":"User","site_admin":false},"body":"This is a preliminary patch containing necessary changes providing GOST 2012 ciphersuites in TLS.","created_at":"2015-09-21T19:08:51Z","updated_at":"2015-10-01T18:38:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bcb4a2cc2d759909fa9167d4ee6f770bf89df4b2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openssl/openssl/pulls/407/commits","review_comments_url":"https://api.github.com/repos/openssl/openssl/pulls/407/comments","review_comment_url":"https://api.github.com/repos/openssl/openssl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openssl/openssl/issues/407/comments","statuses_url":"https://api.github.com/repos/openssl/openssl/statuses/647b78a8ee012129275559dabcae0b016d39ff93","head":{"label":"beldmit:tls_gost_2012","ref":"tls_gost_2012","sha":"647b78a8ee012129275559dabcae0b016d39ff93","user":{"login":"beldmit","id":13785747,"avatar_url":"https://avatars.githubusercontent.com/u/13785747?v=3","gravatar_id":"","url":"https://api.github.com/users/beldmit","html_url":"https://github.com/beldmit","followers_url":"https://api.github.com/users/beldmit/followers","following_url":"https://api.github.com/users/beldmit/following{/other_user}","gists_url":"https://api.github.com/users/beldmit/gists{/gist_id}","starred_url":"https://api.github.com/users/beldmit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beldmit/subscriptions","organizations_url":"https://api.github.com/users/beldmit/orgs","repos_url":"https://api.github.com/users/beldmit/repos","events_url":"https://api.github.com/users/beldmit/events{/privacy}","received_events_url":"https://api.github.com/users/beldmit/received_events","type":"User","site_admin":false},"repo":{"id":42886943,"name":"openssl","full_name":"beldmit/openssl","owner":{"login":"beldmit","id":13785747,"avatar_url":"https://avatars.githubusercontent.com/u/13785747?v=3","gravatar_id":"","url":"https://api.github.com/users/beldmit","html_url":"https://github.com/beldmit","followers_url":"https://api.github.com/users/beldmit/followers","following_url":"https://api.github.com/users/beldmit/following{/other_user}","gists_url":"https://api.github.com/users/beldmit/gists{/gist_id}","starred_url":"https://api.github.com/users/beldmit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beldmit/subscriptions","organizations_url":"https://api.github.com/users/beldmit/orgs","repos_url":"https://api.github.com/users/beldmit/repos","events_url":"https://api.github.com/users/beldmit/events{/privacy}","received_events_url":"https://api.github.com/users/beldmit/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/beldmit/openssl","description":"","fork":true,"url":"https://api.github.com/repos/beldmit/openssl","forks_url":"https://api.github.com/repos/beldmit/openssl/forks","keys_url":"https://api.github.com/repos/beldmit/openssl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/beldmit/openssl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/beldmit/openssl/teams","hooks_url":"https://api.github.com/repos/beldmit/openssl/hooks","issue_events_url":"https://api.github.com/repos/beldmit/openssl/issues/events{/number}","events_url":"https://api.github.com/repos/beldmit/openssl/events","assignees_url":"https://api.github.com/repos/beldmit/openssl/assignees{/user}","branches_url":"https://api.github.com/repos/beldmit/openssl/branches{/branch}","tags_url":"https://api.github.com/repos/beldmit/openssl/tags","blobs_url":"https://api.github.com/repos/beldmit/openssl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/beldmit/openssl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/beldmit/openssl/git/refs{/sha}","trees_url":"https://api.github.com/repos/beldmit/openssl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/beldmit/openssl/statuses/{sha}","languages_url":"https://api.github.com/repos/beldmit/openssl/languages","stargazers_url":"https://api.github.com/repos/beldmit/openssl/stargazers","contributors_url":"https://api.github.com/repos/beldmit/openssl/contributors","subscribers_url":"https://api.github.com/repos/beldmit/openssl/subscribers","subscription_url":"https://api.github.com/repos/beldmit/openssl/subscription","commits_url":"https://api.github.com/repos/beldmit/openssl/commits{/sha}","git_commits_url":"https://api.github.com/repos/beldmit/openssl/git/commits{/sha}","comments_url":"https://api.github.com/repos/beldmit/openssl/comments{/number}","issue_comment_url":"https://api.github.com/repos/beldmit/openssl/issues/comments{/number}","contents_url":"https://api.github.com/repos/beldmit/openssl/contents/{+path}","compare_url":"https://api.github.com/repos/beldmit/openssl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/beldmit/openssl/merges","archive_url":"https://api.github.com/repos/beldmit/openssl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/beldmit/openssl/downloads","issues_url":"https://api.github.com/repos/beldmit/openssl/issues{/number}","pulls_url":"https://api.github.com/repos/beldmit/openssl/pulls{/number}","milestones_url":"https://api.github.com/repos/beldmit/openssl/milestones{/number}","notifications_url":"https://api.github.com/repos/beldmit/openssl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/beldmit/openssl/labels{/name}","releases_url":"https://api.github.com/repos/beldmit/openssl/releases{/id}","created_at":"2015-09-21T18:50:11Z","updated_at":"2015-09-21T18:50:22Z","pushed_at":"2015-10-01T17:49:55Z","git_url":"git://github.com/beldmit/openssl.git","ssh_url":"git@github.com:beldmit/openssl.git","clone_url":"https://github.com/beldmit/openssl.git","svn_url":"https://github.com/beldmit/openssl","homepage":null,"size":70004,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openssl:master","ref":"master","sha":"721c2ac0f427da7ac3c96c8996c8d4b7aeaa9912","user":{"login":"openssl","id":3279138,"avatar_url":"https://avatars.githubusercontent.com/u/3279138?v=3","gravatar_id":"","url":"https://api.github.com/users/openssl","html_url":"https://github.com/openssl","followers_url":"https://api.github.com/users/openssl/followers","following_url":"https://api.github.com/users/openssl/following{/other_user}","gists_url":"https://api.github.com/users/openssl/gists{/gist_id}","starred_url":"https://api.github.com/users/openssl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openssl/subscriptions","organizations_url":"https://api.github.com/users/openssl/orgs","repos_url":"https://api.github.com/users/openssl/repos","events_url":"https://api.github.com/users/openssl/events{/privacy}","received_events_url":"https://api.github.com/users/openssl/received_events","type":"Organization","site_admin":false},"repo":{"id":7634677,"name":"openssl","full_name":"openssl/openssl","owner":{"login":"openssl","id":3279138,"avatar_url":"https://avatars.githubusercontent.com/u/3279138?v=3","gravatar_id":"","url":"https://api.github.com/users/openssl","html_url":"https://github.com/openssl","followers_url":"https://api.github.com/users/openssl/followers","following_url":"https://api.github.com/users/openssl/following{/other_user}","gists_url":"https://api.github.com/users/openssl/gists{/gist_id}","starred_url":"https://api.github.com/users/openssl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openssl/subscriptions","organizations_url":"https://api.github.com/users/openssl/orgs","repos_url":"https://api.github.com/users/openssl/repos","events_url":"https://api.github.com/users/openssl/events{/privacy}","received_events_url":"https://api.github.com/users/openssl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openssl/openssl","description":"","fork":false,"url":"https://api.github.com/repos/openssl/openssl","forks_url":"https://api.github.com/repos/openssl/openssl/forks","keys_url":"https://api.github.com/repos/openssl/openssl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openssl/openssl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openssl/openssl/teams","hooks_url":"https://api.github.com/repos/openssl/openssl/hooks","issue_events_url":"https://api.github.com/repos/openssl/openssl/issues/events{/number}","events_url":"https://api.github.com/repos/openssl/openssl/events","assignees_url":"https://api.github.com/repos/openssl/openssl/assignees{/user}","branches_url":"https://api.github.com/repos/openssl/openssl/branches{/branch}","tags_url":"https://api.github.com/repos/openssl/openssl/tags","blobs_url":"https://api.github.com/repos/openssl/openssl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openssl/openssl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openssl/openssl/git/refs{/sha}","trees_url":"https://api.github.com/repos/openssl/openssl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openssl/openssl/statuses/{sha}","languages_url":"https://api.github.com/repos/openssl/openssl/languages","stargazers_url":"https://api.github.com/repos/openssl/openssl/stargazers","contributors_url":"https://api.github.com/repos/openssl/openssl/contributors","subscribers_url":"https://api.github.com/repos/openssl/openssl/subscribers","subscription_url":"https://api.github.com/repos/openssl/openssl/subscription","commits_url":"https://api.github.com/repos/openssl/openssl/commits{/sha}","git_commits_url":"https://api.github.com/repos/openssl/openssl/git/commits{/sha}","comments_url":"https://api.github.com/repos/openssl/openssl/comments{/number}","issue_comment_url":"https://api.github.com/repos/openssl/openssl/issues/comments{/number}","contents_url":"https://api.github.com/repos/openssl/openssl/contents/{+path}","compare_url":"https://api.github.com/repos/openssl/openssl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openssl/openssl/merges","archive_url":"https://api.github.com/repos/openssl/openssl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openssl/openssl/downloads","issues_url":"https://api.github.com/repos/openssl/openssl/issues{/number}","pulls_url":"https://api.github.com/repos/openssl/openssl/pulls{/number}","milestones_url":"https://api.github.com/repos/openssl/openssl/milestones{/number}","notifications_url":"https://api.github.com/repos/openssl/openssl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openssl/openssl/labels{/name}","releases_url":"https://api.github.com/repos/openssl/openssl/releases{/id}","created_at":"2013-01-15T22:34:48Z","updated_at":"2015-10-01T11:45:56Z","pushed_at":"2015-10-01T18:37:47Z","git_url":"git://github.com/openssl/openssl.git","ssh_url":"git@github.com:openssl/openssl.git","clone_url":"https://github.com/openssl/openssl.git","svn_url":"https://github.com/openssl/openssl","homepage":null,"size":104892,"stargazers_count":1484,"watchers_count":1484,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":907,"mirror_url":null,"open_issues_count":135,"forks":907,"open_issues":135,"watchers":1484,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openssl/openssl/pulls/407"},"html":{"href":"https://github.com/openssl/openssl/pull/407"},"issue":{"href":"https://api.github.com/repos/openssl/openssl/issues/407"},"comments":{"href":"https://api.github.com/repos/openssl/openssl/issues/407/comments"},"review_comments":{"href":"https://api.github.com/repos/openssl/openssl/pulls/407/comments"},"review_comment":{"href":"https://api.github.com/repos/openssl/openssl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openssl/openssl/pulls/407/commits"},"statuses":{"href":"https://api.github.com/repos/openssl/openssl/statuses/647b78a8ee012129275559dabcae0b016d39ff93"}}}}