{"action":"created","issue":{"url":"https://api.github.com/repos/D-Programming-Language/phobos/issues/3310","labels_url":"https://api.github.com/repos/D-Programming-Language/phobos/issues/3310/labels{/name}","comments_url":"https://api.github.com/repos/D-Programming-Language/phobos/issues/3310/comments","events_url":"https://api.github.com/repos/D-Programming-Language/phobos/issues/3310/events","html_url":"https://github.com/D-Programming-Language/phobos/pull/3310","id":79836171,"number":3310,"title":"Remove uses of INLINE_YL2X from std.math","user":{"login":"ibuclaw","id":397929,"avatar_url":"https://avatars.githubusercontent.com/u/397929?v=3","gravatar_id":"","url":"https://api.github.com/users/ibuclaw","html_url":"https://github.com/ibuclaw","followers_url":"https://api.github.com/users/ibuclaw/followers","following_url":"https://api.github.com/users/ibuclaw/following{/other_user}","gists_url":"https://api.github.com/users/ibuclaw/gists{/gist_id}","starred_url":"https://api.github.com/users/ibuclaw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibuclaw/subscriptions","organizations_url":"https://api.github.com/users/ibuclaw/orgs","repos_url":"https://api.github.com/users/ibuclaw/repos","events_url":"https://api.github.com/users/ibuclaw/events{/privacy}","received_events_url":"https://api.github.com/users/ibuclaw/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-05-23T12:41:08Z","updated_at":"2015-05-24T20:17:50Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/3310","html_url":"https://github.com/D-Programming-Language/phobos/pull/3310","diff_url":"https://github.com/D-Programming-Language/phobos/pull/3310.diff","patch_url":"https://github.com/D-Programming-Language/phobos/pull/3310.patch"},"body":"To initially get std.math bootstrapped onto being ``pure @trusted nothrow``, yl2x did have a purpose.\r\n\r\nNow though, its role is meaningless as we have long since had proper ``pure @trusted nothrow`` implementations.  And if anything, it's now harmful since the introduction of https://github.com/D-Programming-Language/dmd/pull/4012 as it leaves it open to misuse.\r\n\r\nI'm not against having these functions as CTFE-able.  I'm just against library maintainers leveraging (unwittingly, as it's not actually *their* fault if code seems to work for them) non-portable CTFE builtins."},"comment":{"url":"https://api.github.com/repos/D-Programming-Language/phobos/issues/comments/105058796","html_url":"https://github.com/D-Programming-Language/phobos/pull/3310#issuecomment-105058796","issue_url":"https://api.github.com/repos/D-Programming-Language/phobos/issues/3310","id":105058796,"user":{"login":"yebblies","id":580100,"avatar_url":"https://avatars.githubusercontent.com/u/580100?v=3","gravatar_id":"","url":"https://api.github.com/users/yebblies","html_url":"https://github.com/yebblies","followers_url":"https://api.github.com/users/yebblies/followers","following_url":"https://api.github.com/users/yebblies/following{/other_user}","gists_url":"https://api.github.com/users/yebblies/gists{/gist_id}","starred_url":"https://api.github.com/users/yebblies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yebblies/subscriptions","organizations_url":"https://api.github.com/users/yebblies/orgs","repos_url":"https://api.github.com/users/yebblies/repos","events_url":"https://api.github.com/users/yebblies/events{/privacy}","received_events_url":"https://api.github.com/users/yebblies/received_events","type":"User","site_admin":false},"created_at":"2015-05-24T20:17:50Z","updated_at":"2015-05-24T20:17:50Z","body":"@WalterBright Github can hide the whitespace changes from the diff, making review much easier.  I don't think it's exposed in the UI anywhere, but you can enable it by adding `&w=1` to the url.\r\n\r\nLink for this pull: https://github.com/D-Programming-Language/phobos/pull/3310/files?w=1"}}