{"action":"created","issue":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/12678","labels_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/12678/labels{/name}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/12678/comments","events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/12678/events","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/12678","id":88450722,"number":12678,"title":"Export mapgen of playground/park and the two cabins to JSON","user":{"login":"BevapDin","id":5095435,"avatar_url":"https://avatars.githubusercontent.com/u/5095435?v=3","gravatar_id":"","url":"https://api.github.com/users/BevapDin","html_url":"https://github.com/BevapDin","followers_url":"https://api.github.com/users/BevapDin/followers","following_url":"https://api.github.com/users/BevapDin/following{/other_user}","gists_url":"https://api.github.com/users/BevapDin/gists{/gist_id}","starred_url":"https://api.github.com/users/BevapDin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BevapDin/subscriptions","organizations_url":"https://api.github.com/users/BevapDin/orgs","repos_url":"https://api.github.com/users/BevapDin/repos","events_url":"https://api.github.com/users/BevapDin/events{/privacy}","received_events_url":"https://api.github.com/users/BevapDin/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"Rivet-the-Zombie","id":5084581,"avatar_url":"https://avatars.githubusercontent.com/u/5084581?v=3","gravatar_id":"","url":"https://api.github.com/users/Rivet-the-Zombie","html_url":"https://github.com/Rivet-the-Zombie","followers_url":"https://api.github.com/users/Rivet-the-Zombie/followers","following_url":"https://api.github.com/users/Rivet-the-Zombie/following{/other_user}","gists_url":"https://api.github.com/users/Rivet-the-Zombie/gists{/gist_id}","starred_url":"https://api.github.com/users/Rivet-the-Zombie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rivet-the-Zombie/subscriptions","organizations_url":"https://api.github.com/users/Rivet-the-Zombie/orgs","repos_url":"https://api.github.com/users/Rivet-the-Zombie/repos","events_url":"https://api.github.com/users/Rivet-the-Zombie/events{/privacy}","received_events_url":"https://api.github.com/users/Rivet-the-Zombie/received_events","type":"User","site_admin":false},"milestone":null,"comments":9,"created_at":"2015-06-15T14:57:33Z","updated_at":"2015-06-19T10:00:22Z","closed_at":"2015-06-18T05:13:06Z","pull_request":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/12678","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/12678","diff_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/12678.diff","patch_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/12678.patch"},"body":"One cabin used `map::make_rubble`, but inconsistent: a 2x2 area would be set to `f_rubble` directly, another 2 places adjacent would be set to rubble via the `make_rubble` function. I changed this to set all 6 squares to rubble via `make_rubble`. This means:\r\n- terrain is destroyed (previously the 2x2 area would keep its terrain, leading to rubble embedded in a log wall)\r\n- items (from destroyed terrain) on each of the 6 squares\r\n- it may lead to addition rubble squares because some adjacent floor may collapse\r\n\r\nI also used the monster group GROUP_ZOMBIE, which does contain non-standard zombies, previously only a few standard zombies had been spawned.\r\n\r\n----\r\n\r\nNew mapgen features:\r\n\r\n- rotation (used by the park): one can rotate the generated map, either randomly or by a fixed value. This should be useful for stuff that does not align with the surrounding (it could be added to the cabins), or for things like curved roads (only need one .\r\n\r\n- allow calling `map::make_rubble` from JSON.\r\n"},"comment":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/comments/113455896","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/12678#issuecomment-113455896","issue_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/12678","id":113455896,"user":{"login":"BevapDin","id":5095435,"avatar_url":"https://avatars.githubusercontent.com/u/5095435?v=3","gravatar_id":"","url":"https://api.github.com/users/BevapDin","html_url":"https://github.com/BevapDin","followers_url":"https://api.github.com/users/BevapDin/followers","following_url":"https://api.github.com/users/BevapDin/following{/other_user}","gists_url":"https://api.github.com/users/BevapDin/gists{/gist_id}","starred_url":"https://api.github.com/users/BevapDin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BevapDin/subscriptions","organizations_url":"https://api.github.com/users/BevapDin/orgs","repos_url":"https://api.github.com/users/BevapDin/repos","events_url":"https://api.github.com/users/BevapDin/events{/privacy}","received_events_url":"https://api.github.com/users/BevapDin/received_events","type":"User","site_admin":false},"created_at":"2015-06-19T10:00:22Z","updated_at":"2015-06-19T10:00:22Z","body":"> That leads me to believe that \"rotates\":false, and \"rotation\":[0,3] will do nothing, when that's not what will happen.\r\n\r\n\"rotates\" controls what happens in the overmap, it makes the terrain appear differently on the overmap, does not affect mapgen (nearly). (The generated map is rotated afterward because they share the same mapgen code and the code can simply assume the north side always faces the street.)\r\n\r\n> Also, what is the point of having rotation be a random number on a range? I would think if someone wanted their building to rotate, they would either want it to rotate north-south, east-west, or any direction.\r\n\r\nIt adds ... randomness to an otherwise quite specific (non-random) map. There is no (in-game) reason why a park, a cabin, a mine entry etc. should have the same orientation all the time.\r\n\r\nIf you have a better wording for the description of those settings, I'll gladly apply them, or you can make a PR on your own."}}