{"action":"created","comment":{"url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/comments/38504170","id":38504170,"diff_hunk":"@@ -796,6 +807,333 @@ template EncoderInstance(CharType : Latin1Char)\n }\n \n //=============================================================================\n+//          ISO-8859-2\n+//=============================================================================\n+\n+/// Defines a Latin2-encoded character.\n+enum Latin2Char : ubyte { init }\n+\n+/**\n+ * Defines an Latin2-encoded string (as an array of $(D\n+ * immutable(Latin2Char))).\n+ */\n+alias Latin2String = immutable(Latin2Char)[];\n+\n+template EncoderInstance(CharType : Latin2Char)","path":"std/encoding.d","position":80,"original_position":80,"commit_id":"9fc784a84b9276dfb61e69e298bda59900c2b5ab","original_commit_id":"9fc784a84b9276dfb61e69e298bda59900c2b5ab","user":{"login":"DmitryOlshansky","id":281770,"avatar_url":"https://avatars.githubusercontent.com/u/281770?v=3","gravatar_id":"","url":"https://api.github.com/users/DmitryOlshansky","html_url":"https://github.com/DmitryOlshansky","followers_url":"https://api.github.com/users/DmitryOlshansky/followers","following_url":"https://api.github.com/users/DmitryOlshansky/following{/other_user}","gists_url":"https://api.github.com/users/DmitryOlshansky/gists{/gist_id}","starred_url":"https://api.github.com/users/DmitryOlshansky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DmitryOlshansky/subscriptions","organizations_url":"https://api.github.com/users/DmitryOlshansky/orgs","repos_url":"https://api.github.com/users/DmitryOlshansky/repos","events_url":"https://api.github.com/users/DmitryOlshansky/events{/privacy}","received_events_url":"https://api.github.com/users/DmitryOlshansky/received_events","type":"User","site_admin":false},"body":"deafult visibility is public, please check that internals are private","created_at":"2015-09-02T07:13:30Z","updated_at":"2015-09-02T07:13:30Z","html_url":"https://github.com/D-Programming-Language/phobos/pull/3173#discussion_r38504170","pull_request_url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/3173","_links":{"self":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/comments/38504170"},"html":{"href":"https://github.com/D-Programming-Language/phobos/pull/3173#discussion_r38504170"},"pull_request":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/3173"}}},"pull_request":{"url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/3173","id":33026953,"html_url":"https://github.com/D-Programming-Language/phobos/pull/3173","diff_url":"https://github.com/D-Programming-Language/phobos/pull/3173.diff","patch_url":"https://github.com/D-Programming-Language/phobos/pull/3173.patch","issue_url":"https://api.github.com/repos/D-Programming-Language/phobos/issues/3173","number":3173,"state":"open","locked":false,"title":"Fix issue 14433 - std.encoding does not support Central European ISO-8859-2 and CP1250 encodings","user":{"login":"chalucha","id":5941106,"avatar_url":"https://avatars.githubusercontent.com/u/5941106?v=3","gravatar_id":"","url":"https://api.github.com/users/chalucha","html_url":"https://github.com/chalucha","followers_url":"https://api.github.com/users/chalucha/followers","following_url":"https://api.github.com/users/chalucha/following{/other_user}","gists_url":"https://api.github.com/users/chalucha/gists{/gist_id}","starred_url":"https://api.github.com/users/chalucha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chalucha/subscriptions","organizations_url":"https://api.github.com/users/chalucha/orgs","repos_url":"https://api.github.com/users/chalucha/repos","events_url":"https://api.github.com/users/chalucha/events{/privacy}","received_events_url":"https://api.github.com/users/chalucha/received_events","type":"User","site_admin":false},"body":"This is my first pull so I hope its done right ;-)\r\n\r\nI just added support for both encodings in a same style as current encodings are.\r\nI came across some spacing issues so fixed them too and can't figure what was `cast(string)` for in:\r\n```d\r\nreturn\r\n[\r\n    cast(string)\r\n    \"CP819\",\r\n    \"IBM819\",\r\n    \"ISO-8859-1\"\r\n]\r\n```\r\nso removed it too.\r\n\r\n[Issue 14433](https://issues.dlang.org/show_bug.cgi?id=14433)","created_at":"2015-04-10T08:26:33Z","updated_at":"2015-09-02T07:13:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"23b53a482b9d5ceb65ca187c87257edcc298ffda","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/3173/commits","review_comments_url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/3173/comments","review_comment_url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/comments{/number}","comments_url":"https://api.github.com/repos/D-Programming-Language/phobos/issues/3173/comments","statuses_url":"https://api.github.com/repos/D-Programming-Language/phobos/statuses/9fc784a84b9276dfb61e69e298bda59900c2b5ab","head":{"label":"chalucha:master","ref":"master","sha":"9fc784a84b9276dfb61e69e298bda59900c2b5ab","user":{"login":"chalucha","id":5941106,"avatar_url":"https://avatars.githubusercontent.com/u/5941106?v=3","gravatar_id":"","url":"https://api.github.com/users/chalucha","html_url":"https://github.com/chalucha","followers_url":"https://api.github.com/users/chalucha/followers","following_url":"https://api.github.com/users/chalucha/following{/other_user}","gists_url":"https://api.github.com/users/chalucha/gists{/gist_id}","starred_url":"https://api.github.com/users/chalucha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chalucha/subscriptions","organizations_url":"https://api.github.com/users/chalucha/orgs","repos_url":"https://api.github.com/users/chalucha/repos","events_url":"https://api.github.com/users/chalucha/events{/privacy}","received_events_url":"https://api.github.com/users/chalucha/received_events","type":"User","site_admin":false},"repo":{"id":33687835,"name":"phobos","full_name":"chalucha/phobos","owner":{"login":"chalucha","id":5941106,"avatar_url":"https://avatars.githubusercontent.com/u/5941106?v=3","gravatar_id":"","url":"https://api.github.com/users/chalucha","html_url":"https://github.com/chalucha","followers_url":"https://api.github.com/users/chalucha/followers","following_url":"https://api.github.com/users/chalucha/following{/other_user}","gists_url":"https://api.github.com/users/chalucha/gists{/gist_id}","starred_url":"https://api.github.com/users/chalucha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chalucha/subscriptions","organizations_url":"https://api.github.com/users/chalucha/orgs","repos_url":"https://api.github.com/users/chalucha/repos","events_url":"https://api.github.com/users/chalucha/events{/privacy}","received_events_url":"https://api.github.com/users/chalucha/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chalucha/phobos","description":"The standard library of the D programming language","fork":true,"url":"https://api.github.com/repos/chalucha/phobos","forks_url":"https://api.github.com/repos/chalucha/phobos/forks","keys_url":"https://api.github.com/repos/chalucha/phobos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chalucha/phobos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chalucha/phobos/teams","hooks_url":"https://api.github.com/repos/chalucha/phobos/hooks","issue_events_url":"https://api.github.com/repos/chalucha/phobos/issues/events{/number}","events_url":"https://api.github.com/repos/chalucha/phobos/events","assignees_url":"https://api.github.com/repos/chalucha/phobos/assignees{/user}","branches_url":"https://api.github.com/repos/chalucha/phobos/branches{/branch}","tags_url":"https://api.github.com/repos/chalucha/phobos/tags","blobs_url":"https://api.github.com/repos/chalucha/phobos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chalucha/phobos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chalucha/phobos/git/refs{/sha}","trees_url":"https://api.github.com/repos/chalucha/phobos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chalucha/phobos/statuses/{sha}","languages_url":"https://api.github.com/repos/chalucha/phobos/languages","stargazers_url":"https://api.github.com/repos/chalucha/phobos/stargazers","contributors_url":"https://api.github.com/repos/chalucha/phobos/contributors","subscribers_url":"https://api.github.com/repos/chalucha/phobos/subscribers","subscription_url":"https://api.github.com/repos/chalucha/phobos/subscription","commits_url":"https://api.github.com/repos/chalucha/phobos/commits{/sha}","git_commits_url":"https://api.github.com/repos/chalucha/phobos/git/commits{/sha}","comments_url":"https://api.github.com/repos/chalucha/phobos/comments{/number}","issue_comment_url":"https://api.github.com/repos/chalucha/phobos/issues/comments{/number}","contents_url":"https://api.github.com/repos/chalucha/phobos/contents/{+path}","compare_url":"https://api.github.com/repos/chalucha/phobos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chalucha/phobos/merges","archive_url":"https://api.github.com/repos/chalucha/phobos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chalucha/phobos/downloads","issues_url":"https://api.github.com/repos/chalucha/phobos/issues{/number}","pulls_url":"https://api.github.com/repos/chalucha/phobos/pulls{/number}","milestones_url":"https://api.github.com/repos/chalucha/phobos/milestones{/number}","notifications_url":"https://api.github.com/repos/chalucha/phobos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chalucha/phobos/labels{/name}","releases_url":"https://api.github.com/repos/chalucha/phobos/releases{/id}","created_at":"2015-04-09T19:20:05Z","updated_at":"2015-04-11T06:48:05Z","pushed_at":"2015-07-26T18:51:39Z","git_url":"git://github.com/chalucha/phobos.git","ssh_url":"git@github.com:chalucha/phobos.git","clone_url":"https://github.com/chalucha/phobos.git","svn_url":"https://github.com/chalucha/phobos","homepage":"dlang.org/phobos","size":43591,"stargazers_count":0,"watchers_count":0,"language":"D","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"D-Programming-Language:master","ref":"master","sha":"5ca7ddad6029676b8c9721e29e686ac5e644ca46","user":{"login":"D-Programming-Language","id":565913,"avatar_url":"https://avatars.githubusercontent.com/u/565913?v=3","gravatar_id":"","url":"https://api.github.com/users/D-Programming-Language","html_url":"https://github.com/D-Programming-Language","followers_url":"https://api.github.com/users/D-Programming-Language/followers","following_url":"https://api.github.com/users/D-Programming-Language/following{/other_user}","gists_url":"https://api.github.com/users/D-Programming-Language/gists{/gist_id}","starred_url":"https://api.github.com/users/D-Programming-Language/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/D-Programming-Language/subscriptions","organizations_url":"https://api.github.com/users/D-Programming-Language/orgs","repos_url":"https://api.github.com/users/D-Programming-Language/repos","events_url":"https://api.github.com/users/D-Programming-Language/events{/privacy}","received_events_url":"https://api.github.com/users/D-Programming-Language/received_events","type":"Organization","site_admin":false},"repo":{"id":1257084,"name":"phobos","full_name":"D-Programming-Language/phobos","owner":{"login":"D-Programming-Language","id":565913,"avatar_url":"https://avatars.githubusercontent.com/u/565913?v=3","gravatar_id":"","url":"https://api.github.com/users/D-Programming-Language","html_url":"https://github.com/D-Programming-Language","followers_url":"https://api.github.com/users/D-Programming-Language/followers","following_url":"https://api.github.com/users/D-Programming-Language/following{/other_user}","gists_url":"https://api.github.com/users/D-Programming-Language/gists{/gist_id}","starred_url":"https://api.github.com/users/D-Programming-Language/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/D-Programming-Language/subscriptions","organizations_url":"https://api.github.com/users/D-Programming-Language/orgs","repos_url":"https://api.github.com/users/D-Programming-Language/repos","events_url":"https://api.github.com/users/D-Programming-Language/events{/privacy}","received_events_url":"https://api.github.com/users/D-Programming-Language/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/D-Programming-Language/phobos","description":"The standard library of the D programming language","fork":false,"url":"https://api.github.com/repos/D-Programming-Language/phobos","forks_url":"https://api.github.com/repos/D-Programming-Language/phobos/forks","keys_url":"https://api.github.com/repos/D-Programming-Language/phobos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/D-Programming-Language/phobos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/D-Programming-Language/phobos/teams","hooks_url":"https://api.github.com/repos/D-Programming-Language/phobos/hooks","issue_events_url":"https://api.github.com/repos/D-Programming-Language/phobos/issues/events{/number}","events_url":"https://api.github.com/repos/D-Programming-Language/phobos/events","assignees_url":"https://api.github.com/repos/D-Programming-Language/phobos/assignees{/user}","branches_url":"https://api.github.com/repos/D-Programming-Language/phobos/branches{/branch}","tags_url":"https://api.github.com/repos/D-Programming-Language/phobos/tags","blobs_url":"https://api.github.com/repos/D-Programming-Language/phobos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/D-Programming-Language/phobos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/D-Programming-Language/phobos/git/refs{/sha}","trees_url":"https://api.github.com/repos/D-Programming-Language/phobos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/D-Programming-Language/phobos/statuses/{sha}","languages_url":"https://api.github.com/repos/D-Programming-Language/phobos/languages","stargazers_url":"https://api.github.com/repos/D-Programming-Language/phobos/stargazers","contributors_url":"https://api.github.com/repos/D-Programming-Language/phobos/contributors","subscribers_url":"https://api.github.com/repos/D-Programming-Language/phobos/subscribers","subscription_url":"https://api.github.com/repos/D-Programming-Language/phobos/subscription","commits_url":"https://api.github.com/repos/D-Programming-Language/phobos/commits{/sha}","git_commits_url":"https://api.github.com/repos/D-Programming-Language/phobos/git/commits{/sha}","comments_url":"https://api.github.com/repos/D-Programming-Language/phobos/comments{/number}","issue_comment_url":"https://api.github.com/repos/D-Programming-Language/phobos/issues/comments{/number}","contents_url":"https://api.github.com/repos/D-Programming-Language/phobos/contents/{+path}","compare_url":"https://api.github.com/repos/D-Programming-Language/phobos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/D-Programming-Language/phobos/merges","archive_url":"https://api.github.com/repos/D-Programming-Language/phobos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/D-Programming-Language/phobos/downloads","issues_url":"https://api.github.com/repos/D-Programming-Language/phobos/issues{/number}","pulls_url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls{/number}","milestones_url":"https://api.github.com/repos/D-Programming-Language/phobos/milestones{/number}","notifications_url":"https://api.github.com/repos/D-Programming-Language/phobos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/D-Programming-Language/phobos/labels{/name}","releases_url":"https://api.github.com/repos/D-Programming-Language/phobos/releases{/id}","created_at":"2011-01-15T07:00:06Z","updated_at":"2015-08-31T12:58:34Z","pushed_at":"2015-09-02T07:07:46Z","git_url":"git://github.com/D-Programming-Language/phobos.git","ssh_url":"git@github.com:D-Programming-Language/phobos.git","clone_url":"https://github.com/D-Programming-Language/phobos.git","svn_url":"https://github.com/D-Programming-Language/phobos","homepage":"dlang.org/phobos","size":89583,"stargazers_count":623,"watchers_count":623,"language":"D","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":423,"mirror_url":null,"open_issues_count":76,"forks":423,"open_issues":76,"watchers":623,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/3173"},"html":{"href":"https://github.com/D-Programming-Language/phobos/pull/3173"},"issue":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/issues/3173"},"comments":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/issues/3173/comments"},"review_comments":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/3173/comments"},"review_comment":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/3173/commits"},"statuses":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/statuses/9fc784a84b9276dfb61e69e298bda59900c2b5ab"}}}}