{"action":"created","comment":{"url":"https://api.github.com/repos/theforeman/foreman/pulls/comments/37626034","id":37626034,"diff_hunk":"@@ -0,0 +1,11 @@\n+module HostStatus\n+  def self.status_registry\n+    @status_registry ||= Set.new\n+  end\n+\n+  def self.find_status_by_humanized_name(name)","path":"app/models/host_status.rb","position":6,"original_position":6,"commit_id":"1584d03e9da2386922ed8825820fc5fd84440bb2","original_commit_id":"1584d03e9da2386922ed8825820fc5fd84440bb2","user":{"login":"domcleal","id":482089,"avatar_url":"https://avatars.githubusercontent.com/u/482089?v=3","gravatar_id":"","url":"https://api.github.com/users/domcleal","html_url":"https://github.com/domcleal","followers_url":"https://api.github.com/users/domcleal/followers","following_url":"https://api.github.com/users/domcleal/following{/other_user}","gists_url":"https://api.github.com/users/domcleal/gists{/gist_id}","starred_url":"https://api.github.com/users/domcleal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/domcleal/subscriptions","organizations_url":"https://api.github.com/users/domcleal/orgs","repos_url":"https://api.github.com/users/domcleal/repos","events_url":"https://api.github.com/users/domcleal/events{/privacy}","received_events_url":"https://api.github.com/users/domcleal/received_events","type":"User","site_admin":false},"body":"Missing test coverage I think","created_at":"2015-08-21T11:26:58Z","updated_at":"2015-08-21T11:26:58Z","html_url":"https://github.com/theforeman/foreman/pull/2580#discussion_r37626034","pull_request_url":"https://api.github.com/repos/theforeman/foreman/pulls/2580","_links":{"self":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/comments/37626034"},"html":{"href":"https://github.com/theforeman/foreman/pull/2580#discussion_r37626034"},"pull_request":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/2580"}}},"pull_request":{"url":"https://api.github.com/repos/theforeman/foreman/pulls/2580","id":40986368,"html_url":"https://github.com/theforeman/foreman/pull/2580","diff_url":"https://github.com/theforeman/foreman/pull/2580.diff","patch_url":"https://github.com/theforeman/foreman/pull/2580.patch","issue_url":"https://api.github.com/repos/theforeman/foreman/issues/2580","number":2580,"state":"open","locked":false,"title":"Fixes #10782 - global host status","user":{"login":"ares","id":109773,"avatar_url":"https://avatars.githubusercontent.com/u/109773?v=3","gravatar_id":"","url":"https://api.github.com/users/ares","html_url":"https://github.com/ares","followers_url":"https://api.github.com/users/ares/followers","following_url":"https://api.github.com/users/ares/following{/other_user}","gists_url":"https://api.github.com/users/ares/gists{/gist_id}","starred_url":"https://api.github.com/users/ares/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ares/subscriptions","organizations_url":"https://api.github.com/users/ares/orgs","repos_url":"https://api.github.com/users/ares/repos","events_url":"https://api.github.com/users/ares/events{/privacy}","received_events_url":"https://api.github.com/users/ares/received_events","type":"User","site_admin":false},"body":"Keeping my commits separately for easier reviewing. There are two things I didn't refactor in this PR, if we agree it's a good direction I'll create redmine issues.\r\n\r\napp/models/report.rb line 66\r\nit would be very nice to refactor this behaviour and ensure the status setter always gets integer number from the importer\r\n\r\napp/services/report_status_calculator.rb line 56\r\nreplace dynamic define_method and use something like status_of('applied') everywhere instead (I don't think this is highly important)","created_at":"2015-07-28T08:27:01Z","updated_at":"2015-08-21T11:26:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"804dc569ecb3e2eb075905acf187a08f2d474ed6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/theforeman/foreman/pulls/2580/commits","review_comments_url":"https://api.github.com/repos/theforeman/foreman/pulls/2580/comments","review_comment_url":"https://api.github.com/repos/theforeman/foreman/pulls/comments{/number}","comments_url":"https://api.github.com/repos/theforeman/foreman/issues/2580/comments","statuses_url":"https://api.github.com/repos/theforeman/foreman/statuses/1584d03e9da2386922ed8825820fc5fd84440bb2","head":{"label":"ares:fix/10782_reports","ref":"fix/10782_reports","sha":"1584d03e9da2386922ed8825820fc5fd84440bb2","user":{"login":"ares","id":109773,"avatar_url":"https://avatars.githubusercontent.com/u/109773?v=3","gravatar_id":"","url":"https://api.github.com/users/ares","html_url":"https://github.com/ares","followers_url":"https://api.github.com/users/ares/followers","following_url":"https://api.github.com/users/ares/following{/other_user}","gists_url":"https://api.github.com/users/ares/gists{/gist_id}","starred_url":"https://api.github.com/users/ares/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ares/subscriptions","organizations_url":"https://api.github.com/users/ares/orgs","repos_url":"https://api.github.com/users/ares/repos","events_url":"https://api.github.com/users/ares/events{/privacy}","received_events_url":"https://api.github.com/users/ares/received_events","type":"User","site_admin":false},"repo":{"id":8576886,"name":"foreman","full_name":"ares/foreman","owner":{"login":"ares","id":109773,"avatar_url":"https://avatars.githubusercontent.com/u/109773?v=3","gravatar_id":"","url":"https://api.github.com/users/ares","html_url":"https://github.com/ares","followers_url":"https://api.github.com/users/ares/followers","following_url":"https://api.github.com/users/ares/following{/other_user}","gists_url":"https://api.github.com/users/ares/gists{/gist_id}","starred_url":"https://api.github.com/users/ares/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ares/subscriptions","organizations_url":"https://api.github.com/users/ares/orgs","repos_url":"https://api.github.com/users/ares/repos","events_url":"https://api.github.com/users/ares/events{/privacy}","received_events_url":"https://api.github.com/users/ares/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ares/foreman","description":"an application that automates the lifecycle of servers ","fork":true,"url":"https://api.github.com/repos/ares/foreman","forks_url":"https://api.github.com/repos/ares/foreman/forks","keys_url":"https://api.github.com/repos/ares/foreman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ares/foreman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ares/foreman/teams","hooks_url":"https://api.github.com/repos/ares/foreman/hooks","issue_events_url":"https://api.github.com/repos/ares/foreman/issues/events{/number}","events_url":"https://api.github.com/repos/ares/foreman/events","assignees_url":"https://api.github.com/repos/ares/foreman/assignees{/user}","branches_url":"https://api.github.com/repos/ares/foreman/branches{/branch}","tags_url":"https://api.github.com/repos/ares/foreman/tags","blobs_url":"https://api.github.com/repos/ares/foreman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ares/foreman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ares/foreman/git/refs{/sha}","trees_url":"https://api.github.com/repos/ares/foreman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ares/foreman/statuses/{sha}","languages_url":"https://api.github.com/repos/ares/foreman/languages","stargazers_url":"https://api.github.com/repos/ares/foreman/stargazers","contributors_url":"https://api.github.com/repos/ares/foreman/contributors","subscribers_url":"https://api.github.com/repos/ares/foreman/subscribers","subscription_url":"https://api.github.com/repos/ares/foreman/subscription","commits_url":"https://api.github.com/repos/ares/foreman/commits{/sha}","git_commits_url":"https://api.github.com/repos/ares/foreman/git/commits{/sha}","comments_url":"https://api.github.com/repos/ares/foreman/comments{/number}","issue_comment_url":"https://api.github.com/repos/ares/foreman/issues/comments{/number}","contents_url":"https://api.github.com/repos/ares/foreman/contents/{+path}","compare_url":"https://api.github.com/repos/ares/foreman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ares/foreman/merges","archive_url":"https://api.github.com/repos/ares/foreman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ares/foreman/downloads","issues_url":"https://api.github.com/repos/ares/foreman/issues{/number}","pulls_url":"https://api.github.com/repos/ares/foreman/pulls{/number}","milestones_url":"https://api.github.com/repos/ares/foreman/milestones{/number}","notifications_url":"https://api.github.com/repos/ares/foreman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ares/foreman/labels{/name}","releases_url":"https://api.github.com/repos/ares/foreman/releases{/id}","created_at":"2013-03-05T09:59:59Z","updated_at":"2014-08-19T11:27:01Z","pushed_at":"2015-08-20T14:34:20Z","git_url":"git://github.com/ares/foreman.git","ssh_url":"git@github.com:ares/foreman.git","clone_url":"https://github.com/ares/foreman.git","svn_url":"https://github.com/ares/foreman","homepage":"http://theforeman.org","size":31860,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"base":{"label":"theforeman:develop","ref":"develop","sha":"4ca9215584bf2b81a3291b728d0c436a9a773f41","user":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars.githubusercontent.com/u/1439844?v=3","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"repo":{"id":258750,"name":"foreman","full_name":"theforeman/foreman","owner":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars.githubusercontent.com/u/1439844?v=3","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/theforeman/foreman","description":"an application that automates the lifecycle of servers ","fork":false,"url":"https://api.github.com/repos/theforeman/foreman","forks_url":"https://api.github.com/repos/theforeman/foreman/forks","keys_url":"https://api.github.com/repos/theforeman/foreman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theforeman/foreman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theforeman/foreman/teams","hooks_url":"https://api.github.com/repos/theforeman/foreman/hooks","issue_events_url":"https://api.github.com/repos/theforeman/foreman/issues/events{/number}","events_url":"https://api.github.com/repos/theforeman/foreman/events","assignees_url":"https://api.github.com/repos/theforeman/foreman/assignees{/user}","branches_url":"https://api.github.com/repos/theforeman/foreman/branches{/branch}","tags_url":"https://api.github.com/repos/theforeman/foreman/tags","blobs_url":"https://api.github.com/repos/theforeman/foreman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theforeman/foreman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theforeman/foreman/git/refs{/sha}","trees_url":"https://api.github.com/repos/theforeman/foreman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theforeman/foreman/statuses/{sha}","languages_url":"https://api.github.com/repos/theforeman/foreman/languages","stargazers_url":"https://api.github.com/repos/theforeman/foreman/stargazers","contributors_url":"https://api.github.com/repos/theforeman/foreman/contributors","subscribers_url":"https://api.github.com/repos/theforeman/foreman/subscribers","subscription_url":"https://api.github.com/repos/theforeman/foreman/subscription","commits_url":"https://api.github.com/repos/theforeman/foreman/commits{/sha}","git_commits_url":"https://api.github.com/repos/theforeman/foreman/git/commits{/sha}","comments_url":"https://api.github.com/repos/theforeman/foreman/comments{/number}","issue_comment_url":"https://api.github.com/repos/theforeman/foreman/issues/comments{/number}","contents_url":"https://api.github.com/repos/theforeman/foreman/contents/{+path}","compare_url":"https://api.github.com/repos/theforeman/foreman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theforeman/foreman/merges","archive_url":"https://api.github.com/repos/theforeman/foreman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theforeman/foreman/downloads","issues_url":"https://api.github.com/repos/theforeman/foreman/issues{/number}","pulls_url":"https://api.github.com/repos/theforeman/foreman/pulls{/number}","milestones_url":"https://api.github.com/repos/theforeman/foreman/milestones{/number}","notifications_url":"https://api.github.com/repos/theforeman/foreman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theforeman/foreman/labels{/name}","releases_url":"https://api.github.com/repos/theforeman/foreman/releases{/id}","created_at":"2009-07-23T15:07:00Z","updated_at":"2015-08-20T13:14:21Z","pushed_at":"2015-08-21T10:23:09Z","git_url":"git://github.com/theforeman/foreman.git","ssh_url":"git@github.com:theforeman/foreman.git","clone_url":"https://github.com/theforeman/foreman.git","svn_url":"https://github.com/theforeman/foreman","homepage":"http://theforeman.org","size":86996,"stargazers_count":827,"watchers_count":827,"language":"Ruby","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":425,"mirror_url":null,"open_issues_count":85,"forks":425,"open_issues":85,"watchers":827,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/2580"},"html":{"href":"https://github.com/theforeman/foreman/pull/2580"},"issue":{"href":"https://api.github.com/repos/theforeman/foreman/issues/2580"},"comments":{"href":"https://api.github.com/repos/theforeman/foreman/issues/2580/comments"},"review_comments":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/2580/comments"},"review_comment":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/2580/commits"},"statuses":{"href":"https://api.github.com/repos/theforeman/foreman/statuses/1584d03e9da2386922ed8825820fc5fd84440bb2"}}}}