{"action":"created","comment":{"url":"https://api.github.com/repos/cockpit-project/cockpit/pulls/comments/40534655","id":40534655,"diff_hunk":"@@ -133,17 +152,11 @@ class TestNetworking(MachineCase):\n         # Switching off rp_filter doesn't seem to be enough in the\n         # case of bonds.\n \n-        iface1 = self.get_iface(m, m.add_netiface('f1'));\n-        iface2 = self.get_iface(m, m.add_netiface('f2', vlan=1));\n-        b.wait_in_text(\"#networking-interfaces\", iface1)\n-        b.wait_in_text(\"#networking-interfaces\", iface2)\n-        if m.os == \"rhel-7\":\n-            # Interfaces are not auto-activated on RHEL 7.\n-            b.wait_in_text(\"#networking-interfaces tr:contains('%s')\" % iface1, \"Inactive\")\n-            b.wait_in_text(\"#networking-interfaces tr:contains('%s')\" % iface2, \"Inactive\")\n-        else:\n-            b.wait_in_text(\"#networking-interfaces tr:contains('%s')\" % iface1, \"bps\")\n-            b.wait_in_text(\"#networking-interfaces tr:contains('%s')\" % iface2, \"Configuring IP\")\n+        mac = \"52:54:00:9e:00:F5\"\n+        iface1 = self.get_iface(m, m.add_netiface(mac=mac));\n+        iface2 = self.get_iface(m, m.add_netiface(secondary_network=True));","path":"test/check-networking","position":79,"original_position":79,"commit_id":"c8103f91c0b803e6f6ab503a391a01447e9dc387","original_commit_id":"c8103f91c0b803e6f6ab503a391a01447e9dc387","user":{"login":"stefwalter","id":795070,"avatar_url":"https://avatars.githubusercontent.com/u/795070?v=3","gravatar_id":"","url":"https://api.github.com/users/stefwalter","html_url":"https://github.com/stefwalter","followers_url":"https://api.github.com/users/stefwalter/followers","following_url":"https://api.github.com/users/stefwalter/following{/other_user}","gists_url":"https://api.github.com/users/stefwalter/gists{/gist_id}","starred_url":"https://api.github.com/users/stefwalter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefwalter/subscriptions","organizations_url":"https://api.github.com/users/stefwalter/orgs","repos_url":"https://api.github.com/users/stefwalter/repos","events_url":"https://api.github.com/users/stefwalter/events{/privacy}","received_events_url":"https://api.github.com/users/stefwalter/received_events","type":"User","site_admin":false},"body":"I've pushed a commit that removes the secondary_network stuff and just uses QEMU network monitor defined networks. It has less litter, doesn't need root permissions etc.","created_at":"2015-09-28T09:49:23Z","updated_at":"2015-09-28T09:49:23Z","html_url":"https://github.com/cockpit-project/cockpit/pull/2759#discussion_r40534655","pull_request_url":"https://api.github.com/repos/cockpit-project/cockpit/pulls/2759","_links":{"self":{"href":"https://api.github.com/repos/cockpit-project/cockpit/pulls/comments/40534655"},"html":{"href":"https://github.com/cockpit-project/cockpit/pull/2759#discussion_r40534655"},"pull_request":{"href":"https://api.github.com/repos/cockpit-project/cockpit/pulls/2759"}}},"pull_request":{"url":"https://api.github.com/repos/cockpit-project/cockpit/pulls/2759","id":45020567,"html_url":"https://github.com/cockpit-project/cockpit/pull/2759","diff_url":"https://github.com/cockpit-project/cockpit/pull/2759.diff","patch_url":"https://github.com/cockpit-project/cockpit/pull/2759.patch","issue_url":"https://api.github.com/repos/cockpit-project/cockpit/issues/2759","number":2759,"state":"open","locked":false,"title":"Tests use libvirt instead of qemu","user":{"login":"dperpeet","id":8711649,"avatar_url":"https://avatars.githubusercontent.com/u/8711649?v=3","gravatar_id":"","url":"https://api.github.com/users/dperpeet","html_url":"https://github.com/dperpeet","followers_url":"https://api.github.com/users/dperpeet/followers","following_url":"https://api.github.com/users/dperpeet/following{/other_user}","gists_url":"https://api.github.com/users/dperpeet/gists{/gist_id}","starred_url":"https://api.github.com/users/dperpeet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dperpeet/subscriptions","organizations_url":"https://api.github.com/users/dperpeet/orgs","repos_url":"https://api.github.com/users/dperpeet/repos","events_url":"https://api.github.com/users/dperpeet/events{/privacy}","received_events_url":"https://api.github.com/users/dperpeet/received_events","type":"User","site_admin":false},"body":"still an issue: after vm-install of the selinux-package, the virtual machine won't boot (selinux-error)","created_at":"2015-09-15T08:17:58Z","updated_at":"2015-09-28T09:49:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b68f06bb23da16dd3c40b5b051b473c25b28192f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cockpit-project/cockpit/pulls/2759/commits","review_comments_url":"https://api.github.com/repos/cockpit-project/cockpit/pulls/2759/comments","review_comment_url":"https://api.github.com/repos/cockpit-project/cockpit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cockpit-project/cockpit/issues/2759/comments","statuses_url":"https://api.github.com/repos/cockpit-project/cockpit/statuses/c8103f91c0b803e6f6ab503a391a01447e9dc387","head":{"label":"dperpeet:test_libvirt","ref":"test_libvirt","sha":"c8103f91c0b803e6f6ab503a391a01447e9dc387","user":{"login":"dperpeet","id":8711649,"avatar_url":"https://avatars.githubusercontent.com/u/8711649?v=3","gravatar_id":"","url":"https://api.github.com/users/dperpeet","html_url":"https://github.com/dperpeet","followers_url":"https://api.github.com/users/dperpeet/followers","following_url":"https://api.github.com/users/dperpeet/following{/other_user}","gists_url":"https://api.github.com/users/dperpeet/gists{/gist_id}","starred_url":"https://api.github.com/users/dperpeet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dperpeet/subscriptions","organizations_url":"https://api.github.com/users/dperpeet/orgs","repos_url":"https://api.github.com/users/dperpeet/repos","events_url":"https://api.github.com/users/dperpeet/events{/privacy}","received_events_url":"https://api.github.com/users/dperpeet/received_events","type":"User","site_admin":false},"repo":{"id":23840026,"name":"cockpit","full_name":"dperpeet/cockpit","owner":{"login":"dperpeet","id":8711649,"avatar_url":"https://avatars.githubusercontent.com/u/8711649?v=3","gravatar_id":"","url":"https://api.github.com/users/dperpeet","html_url":"https://github.com/dperpeet","followers_url":"https://api.github.com/users/dperpeet/followers","following_url":"https://api.github.com/users/dperpeet/following{/other_user}","gists_url":"https://api.github.com/users/dperpeet/gists{/gist_id}","starred_url":"https://api.github.com/users/dperpeet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dperpeet/subscriptions","organizations_url":"https://api.github.com/users/dperpeet/orgs","repos_url":"https://api.github.com/users/dperpeet/repos","events_url":"https://api.github.com/users/dperpeet/events{/privacy}","received_events_url":"https://api.github.com/users/dperpeet/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dperpeet/cockpit","description":"Cockpit, a user interface for GNU/Linux servers","fork":true,"url":"https://api.github.com/repos/dperpeet/cockpit","forks_url":"https://api.github.com/repos/dperpeet/cockpit/forks","keys_url":"https://api.github.com/repos/dperpeet/cockpit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dperpeet/cockpit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dperpeet/cockpit/teams","hooks_url":"https://api.github.com/repos/dperpeet/cockpit/hooks","issue_events_url":"https://api.github.com/repos/dperpeet/cockpit/issues/events{/number}","events_url":"https://api.github.com/repos/dperpeet/cockpit/events","assignees_url":"https://api.github.com/repos/dperpeet/cockpit/assignees{/user}","branches_url":"https://api.github.com/repos/dperpeet/cockpit/branches{/branch}","tags_url":"https://api.github.com/repos/dperpeet/cockpit/tags","blobs_url":"https://api.github.com/repos/dperpeet/cockpit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dperpeet/cockpit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dperpeet/cockpit/git/refs{/sha}","trees_url":"https://api.github.com/repos/dperpeet/cockpit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dperpeet/cockpit/statuses/{sha}","languages_url":"https://api.github.com/repos/dperpeet/cockpit/languages","stargazers_url":"https://api.github.com/repos/dperpeet/cockpit/stargazers","contributors_url":"https://api.github.com/repos/dperpeet/cockpit/contributors","subscribers_url":"https://api.github.com/repos/dperpeet/cockpit/subscribers","subscription_url":"https://api.github.com/repos/dperpeet/cockpit/subscription","commits_url":"https://api.github.com/repos/dperpeet/cockpit/commits{/sha}","git_commits_url":"https://api.github.com/repos/dperpeet/cockpit/git/commits{/sha}","comments_url":"https://api.github.com/repos/dperpeet/cockpit/comments{/number}","issue_comment_url":"https://api.github.com/repos/dperpeet/cockpit/issues/comments{/number}","contents_url":"https://api.github.com/repos/dperpeet/cockpit/contents/{+path}","compare_url":"https://api.github.com/repos/dperpeet/cockpit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dperpeet/cockpit/merges","archive_url":"https://api.github.com/repos/dperpeet/cockpit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dperpeet/cockpit/downloads","issues_url":"https://api.github.com/repos/dperpeet/cockpit/issues{/number}","pulls_url":"https://api.github.com/repos/dperpeet/cockpit/pulls{/number}","milestones_url":"https://api.github.com/repos/dperpeet/cockpit/milestones{/number}","notifications_url":"https://api.github.com/repos/dperpeet/cockpit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dperpeet/cockpit/labels{/name}","releases_url":"https://api.github.com/repos/dperpeet/cockpit/releases{/id}","created_at":"2014-09-09T15:48:26Z","updated_at":"2015-08-05T12:05:10Z","pushed_at":"2015-09-25T09:24:27Z","git_url":"git://github.com/dperpeet/cockpit.git","ssh_url":"git@github.com:dperpeet/cockpit.git","clone_url":"https://github.com/dperpeet/cockpit.git","svn_url":"https://github.com/dperpeet/cockpit","homepage":"http://www.cockpit-project.org/","size":19041,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cockpit-project:master","ref":"master","sha":"fd9c18ea5e97f4da4f2b1829ea1483a5ff84fac1","user":{"login":"cockpit-project","id":5765104,"avatar_url":"https://avatars.githubusercontent.com/u/5765104?v=3","gravatar_id":"","url":"https://api.github.com/users/cockpit-project","html_url":"https://github.com/cockpit-project","followers_url":"https://api.github.com/users/cockpit-project/followers","following_url":"https://api.github.com/users/cockpit-project/following{/other_user}","gists_url":"https://api.github.com/users/cockpit-project/gists{/gist_id}","starred_url":"https://api.github.com/users/cockpit-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockpit-project/subscriptions","organizations_url":"https://api.github.com/users/cockpit-project/orgs","repos_url":"https://api.github.com/users/cockpit-project/repos","events_url":"https://api.github.com/users/cockpit-project/events{/privacy}","received_events_url":"https://api.github.com/users/cockpit-project/received_events","type":"Organization","site_admin":false},"repo":{"id":14049216,"name":"cockpit","full_name":"cockpit-project/cockpit","owner":{"login":"cockpit-project","id":5765104,"avatar_url":"https://avatars.githubusercontent.com/u/5765104?v=3","gravatar_id":"","url":"https://api.github.com/users/cockpit-project","html_url":"https://github.com/cockpit-project","followers_url":"https://api.github.com/users/cockpit-project/followers","following_url":"https://api.github.com/users/cockpit-project/following{/other_user}","gists_url":"https://api.github.com/users/cockpit-project/gists{/gist_id}","starred_url":"https://api.github.com/users/cockpit-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockpit-project/subscriptions","organizations_url":"https://api.github.com/users/cockpit-project/orgs","repos_url":"https://api.github.com/users/cockpit-project/repos","events_url":"https://api.github.com/users/cockpit-project/events{/privacy}","received_events_url":"https://api.github.com/users/cockpit-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cockpit-project/cockpit","description":"Cockpit, a user interface for Linux servers","fork":false,"url":"https://api.github.com/repos/cockpit-project/cockpit","forks_url":"https://api.github.com/repos/cockpit-project/cockpit/forks","keys_url":"https://api.github.com/repos/cockpit-project/cockpit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cockpit-project/cockpit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cockpit-project/cockpit/teams","hooks_url":"https://api.github.com/repos/cockpit-project/cockpit/hooks","issue_events_url":"https://api.github.com/repos/cockpit-project/cockpit/issues/events{/number}","events_url":"https://api.github.com/repos/cockpit-project/cockpit/events","assignees_url":"https://api.github.com/repos/cockpit-project/cockpit/assignees{/user}","branches_url":"https://api.github.com/repos/cockpit-project/cockpit/branches{/branch}","tags_url":"https://api.github.com/repos/cockpit-project/cockpit/tags","blobs_url":"https://api.github.com/repos/cockpit-project/cockpit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cockpit-project/cockpit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cockpit-project/cockpit/git/refs{/sha}","trees_url":"https://api.github.com/repos/cockpit-project/cockpit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cockpit-project/cockpit/statuses/{sha}","languages_url":"https://api.github.com/repos/cockpit-project/cockpit/languages","stargazers_url":"https://api.github.com/repos/cockpit-project/cockpit/stargazers","contributors_url":"https://api.github.com/repos/cockpit-project/cockpit/contributors","subscribers_url":"https://api.github.com/repos/cockpit-project/cockpit/subscribers","subscription_url":"https://api.github.com/repos/cockpit-project/cockpit/subscription","commits_url":"https://api.github.com/repos/cockpit-project/cockpit/commits{/sha}","git_commits_url":"https://api.github.com/repos/cockpit-project/cockpit/git/commits{/sha}","comments_url":"https://api.github.com/repos/cockpit-project/cockpit/comments{/number}","issue_comment_url":"https://api.github.com/repos/cockpit-project/cockpit/issues/comments{/number}","contents_url":"https://api.github.com/repos/cockpit-project/cockpit/contents/{+path}","compare_url":"https://api.github.com/repos/cockpit-project/cockpit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cockpit-project/cockpit/merges","archive_url":"https://api.github.com/repos/cockpit-project/cockpit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cockpit-project/cockpit/downloads","issues_url":"https://api.github.com/repos/cockpit-project/cockpit/issues{/number}","pulls_url":"https://api.github.com/repos/cockpit-project/cockpit/pulls{/number}","milestones_url":"https://api.github.com/repos/cockpit-project/cockpit/milestones{/number}","notifications_url":"https://api.github.com/repos/cockpit-project/cockpit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cockpit-project/cockpit/labels{/name}","releases_url":"https://api.github.com/repos/cockpit-project/cockpit/releases{/id}","created_at":"2013-11-01T17:36:46Z","updated_at":"2015-09-26T05:06:49Z","pushed_at":"2015-09-28T09:31:26Z","git_url":"git://github.com/cockpit-project/cockpit.git","ssh_url":"git@github.com:cockpit-project/cockpit.git","clone_url":"https://github.com/cockpit-project/cockpit.git","svn_url":"https://github.com/cockpit-project/cockpit","homepage":"http://www.cockpit-project.org/","size":41173,"stargazers_count":1248,"watchers_count":1248,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":136,"mirror_url":null,"open_issues_count":356,"forks":136,"open_issues":356,"watchers":1248,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cockpit-project/cockpit/pulls/2759"},"html":{"href":"https://github.com/cockpit-project/cockpit/pull/2759"},"issue":{"href":"https://api.github.com/repos/cockpit-project/cockpit/issues/2759"},"comments":{"href":"https://api.github.com/repos/cockpit-project/cockpit/issues/2759/comments"},"review_comments":{"href":"https://api.github.com/repos/cockpit-project/cockpit/pulls/2759/comments"},"review_comment":{"href":"https://api.github.com/repos/cockpit-project/cockpit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cockpit-project/cockpit/pulls/2759/commits"},"statuses":{"href":"https://api.github.com/repos/cockpit-project/cockpit/statuses/c8103f91c0b803e6f6ab503a391a01447e9dc387"}}}}