{"action":"created","comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/23058527","id":23058527,"diff_hunk":"@@ -0,0 +1,113 @@\n+#include \"RecoMET/METPUSubtraction/interface/NoPileUpMEtAuxFunctions.h\"\n+\n+#include \"DataFormats/Math/interface/deltaR.h\"\n+#include \"DataFormats/Common/interface/RefToPtr.h\"\n+\n+#include <math.h>","path":"RecoMET/METPUSubtraction/src/NoPileUpMEtAuxFunctions.cc","position":6,"original_position":6,"commit_id":"5eb24d93091418ba3303951a0e222792f89e5633","original_commit_id":"5eb24d93091418ba3303951a0e222792f89e5633","user":{"login":"slava77","id":4676718,"avatar_url":"https://avatars.githubusercontent.com/u/4676718?v=3","gravatar_id":"","url":"https://api.github.com/users/slava77","html_url":"https://github.com/slava77","followers_url":"https://api.github.com/users/slava77/followers","following_url":"https://api.github.com/users/slava77/following{/other_user}","gists_url":"https://api.github.com/users/slava77/gists{/gist_id}","starred_url":"https://api.github.com/users/slava77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slava77/subscriptions","organizations_url":"https://api.github.com/users/slava77/orgs","repos_url":"https://api.github.com/users/slava77/repos","events_url":"https://api.github.com/users/slava77/events{/privacy}","received_events_url":"https://api.github.com/users/slava77/received_events","type":"User","site_admin":false},"body":"use ```<cmath>`` instead","created_at":"2015-01-16T01:38:06Z","updated_at":"2015-01-16T01:38:06Z","html_url":"https://github.com/cms-sw/cmssw/pull/7085#discussion_r23058527","pull_request_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/7085","_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/23058527"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/7085#discussion_r23058527"},"pull_request":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/7085"}}},"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/7085","id":27041724,"html_url":"https://github.com/cms-sw/cmssw/pull/7085","diff_url":"https://github.com/cms-sw/cmssw/pull/7085.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/7085.patch","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/7085","number":7085,"state":"open","locked":false,"title":"Integration of MvaMET code and tools for miniAOD, cleaning of RecoMET/METPUSubtraction package","user":{"login":"mmarionncern","id":5114248,"avatar_url":"https://avatars.githubusercontent.com/u/5114248?v=3","gravatar_id":"","url":"https://api.github.com/users/mmarionncern","html_url":"https://github.com/mmarionncern","followers_url":"https://api.github.com/users/mmarionncern/followers","following_url":"https://api.github.com/users/mmarionncern/following{/other_user}","gists_url":"https://api.github.com/users/mmarionncern/gists{/gist_id}","starred_url":"https://api.github.com/users/mmarionncern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmarionncern/subscriptions","organizations_url":"https://api.github.com/users/mmarionncern/orgs","repos_url":"https://api.github.com/users/mmarionncern/repos","events_url":"https://api.github.com/users/mmarionncern/events{/privacy}","received_events_url":"https://api.github.com/users/mmarionncern/received_events","type":"User","site_admin":false},"body":"Same as #6922 but rebased on top of CMSSW_7_4_X.\r\n\r\nThis PR modifies the mva mitigated MET code in order to make it able to run in top of miniAODs. Cleaning and restructuration of the associated code is also done.\r\n\r\nPackages involved :\r\n-DataFormats/METReco : auxiliary structure for the pileup mitigated MET algorithm restructuresd for a common approach\r\n\r\nRecoJets/JetProducers : pileup mva jet id now able to work in top of miniAOD, mandatory for the mva MET\r\nRecoMET/METPUSubtraction : rewriting of the NoPU and Mva MET code -> clarity and structure improved, mvaMET able to work in top of miniAOD. NoPU will not due to the limited information available on miniAOD, and it is not planned to go further in that direction.\r\nChanges expected :\r\n\r\nreco sequence : no change expected so far, plugin of default mva/nopu algorithm at the RECO/AOD or miniAOD level for a next PR\r\nevent content : transparent\r\ndifference between the mva MET at AOD and miniAOD level : 1% of events slightly different due to the difference of pfCandidate-vertex matching between both format\r\ndifference between previous version and new version : slight difference of the mvaMET results compared to the current version in the release, due to how JEC are handled in the pileup Jet Id mva algorithm for the mvaMET (before was internal, now pileup Jet ID mva is independent, and in sync with other use of the pileup mva jet id)\r\nmatrix tests are successfull\r\n\r\n","created_at":"2015-01-08T16:51:04Z","updated_at":"2015-01-16T01:38:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2b9be705b889b9fcf55ad945d21a73dd06c50d99","assignee":null,"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/50","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/50/labels","id":875803,"number":50,"title":"Next CMSSW_7_4_X","description":"","creator":{"login":"nclopezo","id":1944922,"avatar_url":"https://avatars.githubusercontent.com/u/1944922?v=3","gravatar_id":"","url":"https://api.github.com/users/nclopezo","html_url":"https://github.com/nclopezo","followers_url":"https://api.github.com/users/nclopezo/followers","following_url":"https://api.github.com/users/nclopezo/following{/other_user}","gists_url":"https://api.github.com/users/nclopezo/gists{/gist_id}","starred_url":"https://api.github.com/users/nclopezo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nclopezo/subscriptions","organizations_url":"https://api.github.com/users/nclopezo/orgs","repos_url":"https://api.github.com/users/nclopezo/repos","events_url":"https://api.github.com/users/nclopezo/events{/privacy}","received_events_url":"https://api.github.com/users/nclopezo/received_events","type":"User","site_admin":false},"open_issues":45,"closed_issues":287,"state":"open","created_at":"2014-11-21T15:23:58Z","updated_at":"2015-01-15T22:20:10Z","due_on":"2015-01-20T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/7085/commits","review_comments_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/7085/comments","review_comment_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/{number}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/7085/comments","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/5eb24d93091418ba3303951a0e222792f89e5633","head":{"label":"cms-met:74X-MVaNoPuMETForMiniAOD","ref":"74X-MVaNoPuMETForMiniAOD","sha":"5eb24d93091418ba3303951a0e222792f89e5633","user":{"login":"cms-met","id":5247643,"avatar_url":"https://avatars.githubusercontent.com/u/5247643?v=3","gravatar_id":"","url":"https://api.github.com/users/cms-met","html_url":"https://github.com/cms-met","followers_url":"https://api.github.com/users/cms-met/followers","following_url":"https://api.github.com/users/cms-met/following{/other_user}","gists_url":"https://api.github.com/users/cms-met/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-met/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-met/subscriptions","organizations_url":"https://api.github.com/users/cms-met/orgs","repos_url":"https://api.github.com/users/cms-met/repos","events_url":"https://api.github.com/users/cms-met/events{/privacy}","received_events_url":"https://api.github.com/users/cms-met/received_events","type":"Organization","site_admin":false},"repo":{"id":12169492,"name":"cmssw","full_name":"cms-met/cmssw","owner":{"login":"cms-met","id":5247643,"avatar_url":"https://avatars.githubusercontent.com/u/5247643?v=3","gravatar_id":"","url":"https://api.github.com/users/cms-met","html_url":"https://github.com/cms-met","followers_url":"https://api.github.com/users/cms-met/followers","following_url":"https://api.github.com/users/cms-met/following{/other_user}","gists_url":"https://api.github.com/users/cms-met/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-met/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-met/subscriptions","organizations_url":"https://api.github.com/users/cms-met/orgs","repos_url":"https://api.github.com/users/cms-met/repos","events_url":"https://api.github.com/users/cms-met/events{/privacy}","received_events_url":"https://api.github.com/users/cms-met/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cms-met/cmssw","description":"CMS Offline Software","fork":true,"url":"https://api.github.com/repos/cms-met/cmssw","forks_url":"https://api.github.com/repos/cms-met/cmssw/forks","keys_url":"https://api.github.com/repos/cms-met/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cms-met/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cms-met/cmssw/teams","hooks_url":"https://api.github.com/repos/cms-met/cmssw/hooks","issue_events_url":"https://api.github.com/repos/cms-met/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/cms-met/cmssw/events","assignees_url":"https://api.github.com/repos/cms-met/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/cms-met/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/cms-met/cmssw/tags","blobs_url":"https://api.github.com/repos/cms-met/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cms-met/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cms-met/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/cms-met/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cms-met/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/cms-met/cmssw/languages","stargazers_url":"https://api.github.com/repos/cms-met/cmssw/stargazers","contributors_url":"https://api.github.com/repos/cms-met/cmssw/contributors","subscribers_url":"https://api.github.com/repos/cms-met/cmssw/subscribers","subscription_url":"https://api.github.com/repos/cms-met/cmssw/subscription","commits_url":"https://api.github.com/repos/cms-met/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/cms-met/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/cms-met/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/cms-met/cmssw/issues/comments/{number}","contents_url":"https://api.github.com/repos/cms-met/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/cms-met/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cms-met/cmssw/merges","archive_url":"https://api.github.com/repos/cms-met/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cms-met/cmssw/downloads","issues_url":"https://api.github.com/repos/cms-met/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/cms-met/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/cms-met/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/cms-met/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cms-met/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/cms-met/cmssw/releases{/id}","created_at":"2013-08-16T22:16:52Z","updated_at":"2014-12-19T15:33:32Z","pushed_at":"2015-01-15T18:44:21Z","git_url":"git://github.com/cms-met/cmssw.git","ssh_url":"git@github.com:cms-met/cmssw.git","clone_url":"https://github.com/cms-met/cmssw.git","svn_url":"https://github.com/cms-met/cmssw","homepage":"cms-sw.github.io/cmssw","size":661143,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":7,"forks":1,"open_issues":7,"watchers":0,"default_branch":"CMSSW_7_2_X"}},"base":{"label":"cms-sw:CMSSW_7_4_X","ref":"CMSSW_7_4_X","sha":"a1746f4e1d8f0c8479dc7ade756e7ac4af6b2421","user":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars.githubusercontent.com/u/3863500?v=3","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"repo":{"id":10969551,"name":"cmssw","full_name":"cms-sw/cmssw","owner":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars.githubusercontent.com/u/3863500?v=3","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cms-sw/cmssw","description":"CMS Offline Software","fork":false,"url":"https://api.github.com/repos/cms-sw/cmssw","forks_url":"https://api.github.com/repos/cms-sw/cmssw/forks","keys_url":"https://api.github.com/repos/cms-sw/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cms-sw/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cms-sw/cmssw/teams","hooks_url":"https://api.github.com/repos/cms-sw/cmssw/hooks","issue_events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/cms-sw/cmssw/events","assignees_url":"https://api.github.com/repos/cms-sw/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/cms-sw/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/cms-sw/cmssw/tags","blobs_url":"https://api.github.com/repos/cms-sw/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cms-sw/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cms-sw/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/cms-sw/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/cms-sw/cmssw/languages","stargazers_url":"https://api.github.com/repos/cms-sw/cmssw/stargazers","contributors_url":"https://api.github.com/repos/cms-sw/cmssw/contributors","subscribers_url":"https://api.github.com/repos/cms-sw/cmssw/subscribers","subscription_url":"https://api.github.com/repos/cms-sw/cmssw/subscription","commits_url":"https://api.github.com/repos/cms-sw/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/cms-sw/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments/{number}","contents_url":"https://api.github.com/repos/cms-sw/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/cms-sw/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cms-sw/cmssw/merges","archive_url":"https://api.github.com/repos/cms-sw/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cms-sw/cmssw/downloads","issues_url":"https://api.github.com/repos/cms-sw/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/cms-sw/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/cms-sw/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/cms-sw/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cms-sw/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/cms-sw/cmssw/releases{/id}","created_at":"2013-06-26T14:09:07Z","updated_at":"2015-01-15T21:44:14Z","pushed_at":"2015-01-16T01:27:28Z","git_url":"git://github.com/cms-sw/cmssw.git","ssh_url":"git@github.com:cms-sw/cmssw.git","clone_url":"https://github.com/cms-sw/cmssw.git","svn_url":"https://github.com/cms-sw/cmssw","homepage":"http://cms-sw.github.io/","size":784077,"stargazers_count":196,"watchers_count":196,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1212,"mirror_url":null,"open_issues_count":119,"forks":1212,"open_issues":119,"watchers":196,"default_branch":"CMSSW_7_4_X"}},"_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/7085"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/7085"},"issue":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/7085"},"comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/7085/comments"},"review_comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/7085/comments"},"review_comment":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/7085/commits"},"statuses":{"href":"https://api.github.com/repos/cms-sw/cmssw/statuses/5eb24d93091418ba3303951a0e222792f89e5633"}}}}