{"action":"created","comment":{"url":"https://api.github.com/repos/SmingHub/Sming/pulls/comments/44910418","id":44910418,"diff_hunk":"@@ -18,7 +18,7 @@ RBOOT_SPIFFS_1   ?= 0x300000\n RBOOT_LD_0 ?= rom0.ld\n RBOOT_LD_1 ?= rom1.ld\n # esptool2 path\n-ESPTOOL2 ?= esptool2\n+ESPTOOL2 ?= c:\\userdata\\esp8266\\esptool2\\esptool2.exe","path":"Sming/Makefile-rboot.mk","position":5,"original_position":5,"commit_id":"2c4f5489d0b0bce56a51b398ded253a55d62c71b","original_commit_id":"2c4f5489d0b0bce56a51b398ded253a55d62c71b","user":{"login":"raburton","id":433543,"avatar_url":"https://avatars.githubusercontent.com/u/433543?v=3","gravatar_id":"","url":"https://api.github.com/users/raburton","html_url":"https://github.com/raburton","followers_url":"https://api.github.com/users/raburton/followers","following_url":"https://api.github.com/users/raburton/following{/other_user}","gists_url":"https://api.github.com/users/raburton/gists{/gist_id}","starred_url":"https://api.github.com/users/raburton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raburton/subscriptions","organizations_url":"https://api.github.com/users/raburton/orgs","repos_url":"https://api.github.com/users/raburton/repos","events_url":"https://api.github.com/users/raburton/events{/privacy}","received_events_url":"https://api.github.com/users/raburton/received_events","type":"User","site_admin":false},"body":"You don't want to commit this change. If you want to change this variable for testing without editing the file just set it as an environment variable.","created_at":"2015-11-16T10:56:00Z","updated_at":"2015-11-16T10:56:00Z","html_url":"https://github.com/SmingHub/Sming/pull/420#discussion_r44910418","pull_request_url":"https://api.github.com/repos/SmingHub/Sming/pulls/420","_links":{"self":{"href":"https://api.github.com/repos/SmingHub/Sming/pulls/comments/44910418"},"html":{"href":"https://github.com/SmingHub/Sming/pull/420#discussion_r44910418"},"pull_request":{"href":"https://api.github.com/repos/SmingHub/Sming/pulls/420"}}},"pull_request":{"url":"https://api.github.com/repos/SmingHub/Sming/pulls/420","id":50415391,"html_url":"https://github.com/SmingHub/Sming/pull/420","diff_url":"https://github.com/SmingHub/Sming/pull/420.diff","patch_url":"https://github.com/SmingHub/Sming/pull/420.patch","issue_url":"https://api.github.com/repos/SmingHub/Sming/issues/420","number":420,"state":"open","locked":false,"title":"Initial V0.1 rBoot Generic","user":{"login":"hreintke","id":4587225,"avatar_url":"https://avatars.githubusercontent.com/u/4587225?v=3","gravatar_id":"","url":"https://api.github.com/users/hreintke","html_url":"https://github.com/hreintke","followers_url":"https://api.github.com/users/hreintke/followers","following_url":"https://api.github.com/users/hreintke/following{/other_user}","gists_url":"https://api.github.com/users/hreintke/gists{/gist_id}","starred_url":"https://api.github.com/users/hreintke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hreintke/subscriptions","organizations_url":"https://api.github.com/users/hreintke/orgs","repos_url":"https://api.github.com/users/hreintke/repos","events_url":"https://api.github.com/users/hreintke/events{/privacy}","received_events_url":"https://api.github.com/users/hreintke/received_events","type":"User","site_admin":false},"body":"@All : \r\nThis is an alpha implementation of a Generic rBoot layer for easing the use of rBoot and provide a rBoot Bios application to support ESP fully remote.\r\n\r\nThis PR includes a \"RBootClass\" which implements :  \r\n- An initial layer around rBoot/rbootHttpUpdate\r\n- An initial way to mount/unmount spiffs filesystems, based on rBoot configuration\r\n- An initial CommandHandler interface to the functionality.\r\n- An example application using the above : rboot_generic\r\n\r\nNot much documentation yet, \r\n- see RBootClass.h for usage & interfaces\r\n- connect with telnet client to esp, rboot commands are then available :\r\n   \"rboot info\" \"rboot load 1 http://10.0.0.201/rom0.bin\" \"rboot ls\" etc\r\ntype \"rboot\" for all options.\r\n\r\nAll command examples have equivalent API's -> available within application\r\n\r\nCurrent V0.1 is only usable/has hardcoded values for use on 4Mb  devices, no other supported yet.\r\n\r\nThe used romconfig is the following :\r\n\r\nROM0 -> 0x002000\t-> number from initial rboot figures, application area\r\nROM1 -> 0x202000\t-> number from initial rboot figures, application area\r\nROM2 -> 0x100000;\t-> number set in application code, spiffs area, size 65536\r\nROM3 -> 0x300000;\t-> number set in application code, spiffs area, size 65536\r\n\r\nRunning the example the functionality can be shown by the following commands :\r\n\r\nrboot info -> shows ROM info\r\nrboot load 0 http://10.0.0.200/rom0.bin -> error, don't allow current rom update\r\nrboot load 1 http://10.0.0.200/rom0.bin -> http update rom0.bin to ROM1\r\nrboot load 2 http://10.0.0.200/spiffs_rom.bin -> http update spiffs to ROM2\r\nrboot load 3 http://10.0.0.200/spiffs_rom2.bin -> http update spiffs2 to ROM3\r\n\r\nrboot start -> start current ROM (= restart)\r\nrboot start 1 -> start ROM1\r\n\r\nrboot mount 2 -> mount ROM2 spiffs\r\nrboot ls -> show files on spiffs\r\nrboot unmount -> unmount spiffs\r\nrboot ls -> error not mounted\r\nrboot mount 3 -> mount ROM3 spiffs\r\nrboot ls -> show files on spiffs\r\n\r\n\r\nNext version to come\r\n\r\nPlease comment ","created_at":"2015-11-11T18:04:25Z","updated_at":"2015-11-16T10:56:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"79d602ce3ce2283077102ff274504245ddc0a1ee","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/SmingHub/Sming/pulls/420/commits","review_comments_url":"https://api.github.com/repos/SmingHub/Sming/pulls/420/comments","review_comment_url":"https://api.github.com/repos/SmingHub/Sming/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SmingHub/Sming/issues/420/comments","statuses_url":"https://api.github.com/repos/SmingHub/Sming/statuses/2c4f5489d0b0bce56a51b398ded253a55d62c71b","head":{"label":"hreintke:rBoot_Generic_implementation","ref":"rBoot_Generic_implementation","sha":"2c4f5489d0b0bce56a51b398ded253a55d62c71b","user":{"login":"hreintke","id":4587225,"avatar_url":"https://avatars.githubusercontent.com/u/4587225?v=3","gravatar_id":"","url":"https://api.github.com/users/hreintke","html_url":"https://github.com/hreintke","followers_url":"https://api.github.com/users/hreintke/followers","following_url":"https://api.github.com/users/hreintke/following{/other_user}","gists_url":"https://api.github.com/users/hreintke/gists{/gist_id}","starred_url":"https://api.github.com/users/hreintke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hreintke/subscriptions","organizations_url":"https://api.github.com/users/hreintke/orgs","repos_url":"https://api.github.com/users/hreintke/repos","events_url":"https://api.github.com/users/hreintke/events{/privacy}","received_events_url":"https://api.github.com/users/hreintke/received_events","type":"User","site_admin":false},"repo":{"id":44747112,"name":"Sming","full_name":"hreintke/Sming","owner":{"login":"hreintke","id":4587225,"avatar_url":"https://avatars.githubusercontent.com/u/4587225?v=3","gravatar_id":"","url":"https://api.github.com/users/hreintke","html_url":"https://github.com/hreintke","followers_url":"https://api.github.com/users/hreintke/followers","following_url":"https://api.github.com/users/hreintke/following{/other_user}","gists_url":"https://api.github.com/users/hreintke/gists{/gist_id}","starred_url":"https://api.github.com/users/hreintke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hreintke/subscriptions","organizations_url":"https://api.github.com/users/hreintke/orgs","repos_url":"https://api.github.com/users/hreintke/repos","events_url":"https://api.github.com/users/hreintke/events{/privacy}","received_events_url":"https://api.github.com/users/hreintke/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hreintke/Sming","description":"Sming - Open Source framework for high efficiency native ESP8266 development","fork":true,"url":"https://api.github.com/repos/hreintke/Sming","forks_url":"https://api.github.com/repos/hreintke/Sming/forks","keys_url":"https://api.github.com/repos/hreintke/Sming/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hreintke/Sming/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hreintke/Sming/teams","hooks_url":"https://api.github.com/repos/hreintke/Sming/hooks","issue_events_url":"https://api.github.com/repos/hreintke/Sming/issues/events{/number}","events_url":"https://api.github.com/repos/hreintke/Sming/events","assignees_url":"https://api.github.com/repos/hreintke/Sming/assignees{/user}","branches_url":"https://api.github.com/repos/hreintke/Sming/branches{/branch}","tags_url":"https://api.github.com/repos/hreintke/Sming/tags","blobs_url":"https://api.github.com/repos/hreintke/Sming/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hreintke/Sming/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hreintke/Sming/git/refs{/sha}","trees_url":"https://api.github.com/repos/hreintke/Sming/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hreintke/Sming/statuses/{sha}","languages_url":"https://api.github.com/repos/hreintke/Sming/languages","stargazers_url":"https://api.github.com/repos/hreintke/Sming/stargazers","contributors_url":"https://api.github.com/repos/hreintke/Sming/contributors","subscribers_url":"https://api.github.com/repos/hreintke/Sming/subscribers","subscription_url":"https://api.github.com/repos/hreintke/Sming/subscription","commits_url":"https://api.github.com/repos/hreintke/Sming/commits{/sha}","git_commits_url":"https://api.github.com/repos/hreintke/Sming/git/commits{/sha}","comments_url":"https://api.github.com/repos/hreintke/Sming/comments{/number}","issue_comment_url":"https://api.github.com/repos/hreintke/Sming/issues/comments{/number}","contents_url":"https://api.github.com/repos/hreintke/Sming/contents/{+path}","compare_url":"https://api.github.com/repos/hreintke/Sming/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hreintke/Sming/merges","archive_url":"https://api.github.com/repos/hreintke/Sming/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hreintke/Sming/downloads","issues_url":"https://api.github.com/repos/hreintke/Sming/issues{/number}","pulls_url":"https://api.github.com/repos/hreintke/Sming/pulls{/number}","milestones_url":"https://api.github.com/repos/hreintke/Sming/milestones{/number}","notifications_url":"https://api.github.com/repos/hreintke/Sming/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hreintke/Sming/labels{/name}","releases_url":"https://api.github.com/repos/hreintke/Sming/releases{/id}","created_at":"2015-10-22T13:32:14Z","updated_at":"2015-10-22T13:32:20Z","pushed_at":"2015-11-11T21:12:15Z","git_url":"git://github.com/hreintke/Sming.git","ssh_url":"git@github.com:hreintke/Sming.git","clone_url":"https://github.com/hreintke/Sming.git","svn_url":"https://github.com/hreintke/Sming","homepage":null,"size":30582,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SmingHub:develop","ref":"develop","sha":"92dea06a72ff341f4a1887cd3193e872f9238786","user":{"login":"SmingHub","id":14863779,"avatar_url":"https://avatars.githubusercontent.com/u/14863779?v=3","gravatar_id":"","url":"https://api.github.com/users/SmingHub","html_url":"https://github.com/SmingHub","followers_url":"https://api.github.com/users/SmingHub/followers","following_url":"https://api.github.com/users/SmingHub/following{/other_user}","gists_url":"https://api.github.com/users/SmingHub/gists{/gist_id}","starred_url":"https://api.github.com/users/SmingHub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SmingHub/subscriptions","organizations_url":"https://api.github.com/users/SmingHub/orgs","repos_url":"https://api.github.com/users/SmingHub/repos","events_url":"https://api.github.com/users/SmingHub/events{/privacy}","received_events_url":"https://api.github.com/users/SmingHub/received_events","type":"Organization","site_admin":false},"repo":{"id":32271212,"name":"Sming","full_name":"SmingHub/Sming","owner":{"login":"SmingHub","id":14863779,"avatar_url":"https://avatars.githubusercontent.com/u/14863779?v=3","gravatar_id":"","url":"https://api.github.com/users/SmingHub","html_url":"https://github.com/SmingHub","followers_url":"https://api.github.com/users/SmingHub/followers","following_url":"https://api.github.com/users/SmingHub/following{/other_user}","gists_url":"https://api.github.com/users/SmingHub/gists{/gist_id}","starred_url":"https://api.github.com/users/SmingHub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SmingHub/subscriptions","organizations_url":"https://api.github.com/users/SmingHub/orgs","repos_url":"https://api.github.com/users/SmingHub/repos","events_url":"https://api.github.com/users/SmingHub/events{/privacy}","received_events_url":"https://api.github.com/users/SmingHub/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SmingHub/Sming","description":"Sming - Open Source framework for high efficiency native ESP8266 development","fork":false,"url":"https://api.github.com/repos/SmingHub/Sming","forks_url":"https://api.github.com/repos/SmingHub/Sming/forks","keys_url":"https://api.github.com/repos/SmingHub/Sming/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SmingHub/Sming/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SmingHub/Sming/teams","hooks_url":"https://api.github.com/repos/SmingHub/Sming/hooks","issue_events_url":"https://api.github.com/repos/SmingHub/Sming/issues/events{/number}","events_url":"https://api.github.com/repos/SmingHub/Sming/events","assignees_url":"https://api.github.com/repos/SmingHub/Sming/assignees{/user}","branches_url":"https://api.github.com/repos/SmingHub/Sming/branches{/branch}","tags_url":"https://api.github.com/repos/SmingHub/Sming/tags","blobs_url":"https://api.github.com/repos/SmingHub/Sming/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SmingHub/Sming/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SmingHub/Sming/git/refs{/sha}","trees_url":"https://api.github.com/repos/SmingHub/Sming/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SmingHub/Sming/statuses/{sha}","languages_url":"https://api.github.com/repos/SmingHub/Sming/languages","stargazers_url":"https://api.github.com/repos/SmingHub/Sming/stargazers","contributors_url":"https://api.github.com/repos/SmingHub/Sming/contributors","subscribers_url":"https://api.github.com/repos/SmingHub/Sming/subscribers","subscription_url":"https://api.github.com/repos/SmingHub/Sming/subscription","commits_url":"https://api.github.com/repos/SmingHub/Sming/commits{/sha}","git_commits_url":"https://api.github.com/repos/SmingHub/Sming/git/commits{/sha}","comments_url":"https://api.github.com/repos/SmingHub/Sming/comments{/number}","issue_comment_url":"https://api.github.com/repos/SmingHub/Sming/issues/comments{/number}","contents_url":"https://api.github.com/repos/SmingHub/Sming/contents/{+path}","compare_url":"https://api.github.com/repos/SmingHub/Sming/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SmingHub/Sming/merges","archive_url":"https://api.github.com/repos/SmingHub/Sming/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SmingHub/Sming/downloads","issues_url":"https://api.github.com/repos/SmingHub/Sming/issues{/number}","pulls_url":"https://api.github.com/repos/SmingHub/Sming/pulls{/number}","milestones_url":"https://api.github.com/repos/SmingHub/Sming/milestones{/number}","notifications_url":"https://api.github.com/repos/SmingHub/Sming/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SmingHub/Sming/labels{/name}","releases_url":"https://api.github.com/repos/SmingHub/Sming/releases{/id}","created_at":"2015-03-15T16:36:22Z","updated_at":"2015-11-16T07:27:13Z","pushed_at":"2015-11-15T20:57:59Z","git_url":"git://github.com/SmingHub/Sming.git","ssh_url":"git@github.com:SmingHub/Sming.git","clone_url":"https://github.com/SmingHub/Sming.git","svn_url":"https://github.com/SmingHub/Sming","homepage":null,"size":55862,"stargazers_count":289,"watchers_count":289,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":120,"mirror_url":null,"open_issues_count":79,"forks":120,"open_issues":79,"watchers":289,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SmingHub/Sming/pulls/420"},"html":{"href":"https://github.com/SmingHub/Sming/pull/420"},"issue":{"href":"https://api.github.com/repos/SmingHub/Sming/issues/420"},"comments":{"href":"https://api.github.com/repos/SmingHub/Sming/issues/420/comments"},"review_comments":{"href":"https://api.github.com/repos/SmingHub/Sming/pulls/420/comments"},"review_comment":{"href":"https://api.github.com/repos/SmingHub/Sming/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SmingHub/Sming/pulls/420/commits"},"statuses":{"href":"https://api.github.com/repos/SmingHub/Sming/statuses/2c4f5489d0b0bce56a51b398ded253a55d62c71b"}}}}