{"action":"closed","number":188,"pull_request":{"url":"https://api.github.com/repos/penzance/ab-testing-tool/pulls/188","id":33316810,"html_url":"https://github.com/penzance/ab-testing-tool/pull/188","diff_url":"https://github.com/penzance/ab-testing-tool/pull/188.diff","patch_url":"https://github.com/penzance/ab-testing-tool/pull/188.patch","issue_url":"https://api.github.com/repos/penzance/ab-testing-tool/issues/188","number":188,"state":"closed","locked":false,"title":"feature/js_testing","user":{"login":"kyfantaz","id":1251540,"avatar_url":"https://avatars.githubusercontent.com/u/1251540?v=3","gravatar_id":"","url":"https://api.github.com/users/kyfantaz","html_url":"https://github.com/kyfantaz","followers_url":"https://api.github.com/users/kyfantaz/followers","following_url":"https://api.github.com/users/kyfantaz/following{/other_user}","gists_url":"https://api.github.com/users/kyfantaz/gists{/gist_id}","starred_url":"https://api.github.com/users/kyfantaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyfantaz/subscriptions","organizations_url":"https://api.github.com/users/kyfantaz/orgs","repos_url":"https://api.github.com/users/kyfantaz/repos","events_url":"https://api.github.com/users/kyfantaz/events{/privacy}","received_events_url":"https://api.github.com/users/kyfantaz/received_events","type":"User","site_admin":false},"body":"-Moves js libraries into sub-directory `js/libraries` and refactors the templates to reference the new location for js assets\r\n-Adds `karma.conf.js` file and `package.json` file\r\n-Moves functions in `experiments_dashboard.js` outside of document.ready block to allow for testing\r\n-Changes method `isValidUrl()` regex to require http(s) in url inputs\r\n-Adds more js tests, renames js tests from naming convention `*_spec.js` to naming convention `test_*.js`, and moves location of js tests into `ab_tool/tests/frontend` from `spec/javascripts`\r\n\r\n","created_at":"2015-04-15T02:01:47Z","updated_at":"2015-04-28T00:50:15Z","closed_at":"2015-04-28T00:50:15Z","merged_at":"2015-04-28T00:50:15Z","merge_commit_sha":"29d55d8e12b63bc68c16ff7883aea3e91699a1e6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/penzance/ab-testing-tool/pulls/188/commits","review_comments_url":"https://api.github.com/repos/penzance/ab-testing-tool/pulls/188/comments","review_comment_url":"https://api.github.com/repos/penzance/ab-testing-tool/pulls/comments{/number}","comments_url":"https://api.github.com/repos/penzance/ab-testing-tool/issues/188/comments","statuses_url":"https://api.github.com/repos/penzance/ab-testing-tool/statuses/12d15573e2777813543aeb380225b031c7c46bca","head":{"label":"penzance:feature/js_testing","ref":"feature/js_testing","sha":"12d15573e2777813543aeb380225b031c7c46bca","user":{"login":"penzance","id":7885127,"avatar_url":"https://avatars.githubusercontent.com/u/7885127?v=3","gravatar_id":"","url":"https://api.github.com/users/penzance","html_url":"https://github.com/penzance","followers_url":"https://api.github.com/users/penzance/followers","following_url":"https://api.github.com/users/penzance/following{/other_user}","gists_url":"https://api.github.com/users/penzance/gists{/gist_id}","starred_url":"https://api.github.com/users/penzance/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/penzance/subscriptions","organizations_url":"https://api.github.com/users/penzance/orgs","repos_url":"https://api.github.com/users/penzance/repos","events_url":"https://api.github.com/users/penzance/events{/privacy}","received_events_url":"https://api.github.com/users/penzance/received_events","type":"Organization","site_admin":false},"repo":{"id":22353530,"name":"ab-testing-tool","full_name":"penzance/ab-testing-tool","owner":{"login":"penzance","id":7885127,"avatar_url":"https://avatars.githubusercontent.com/u/7885127?v=3","gravatar_id":"","url":"https://api.github.com/users/penzance","html_url":"https://github.com/penzance","followers_url":"https://api.github.com/users/penzance/followers","following_url":"https://api.github.com/users/penzance/following{/other_user}","gists_url":"https://api.github.com/users/penzance/gists{/gist_id}","starred_url":"https://api.github.com/users/penzance/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/penzance/subscriptions","organizations_url":"https://api.github.com/users/penzance/orgs","repos_url":"https://api.github.com/users/penzance/repos","events_url":"https://api.github.com/users/penzance/events{/privacy}","received_events_url":"https://api.github.com/users/penzance/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/penzance/ab-testing-tool","description":"stage","fork":false,"url":"https://api.github.com/repos/penzance/ab-testing-tool","forks_url":"https://api.github.com/repos/penzance/ab-testing-tool/forks","keys_url":"https://api.github.com/repos/penzance/ab-testing-tool/keys{/key_id}","collaborators_url":"https://api.github.com/repos/penzance/ab-testing-tool/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/penzance/ab-testing-tool/teams","hooks_url":"https://api.github.com/repos/penzance/ab-testing-tool/hooks","issue_events_url":"https://api.github.com/repos/penzance/ab-testing-tool/issues/events{/number}","events_url":"https://api.github.com/repos/penzance/ab-testing-tool/events","assignees_url":"https://api.github.com/repos/penzance/ab-testing-tool/assignees{/user}","branches_url":"https://api.github.com/repos/penzance/ab-testing-tool/branches{/branch}","tags_url":"https://api.github.com/repos/penzance/ab-testing-tool/tags","blobs_url":"https://api.github.com/repos/penzance/ab-testing-tool/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/penzance/ab-testing-tool/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/penzance/ab-testing-tool/git/refs{/sha}","trees_url":"https://api.github.com/repos/penzance/ab-testing-tool/git/trees{/sha}","statuses_url":"https://api.github.com/repos/penzance/ab-testing-tool/statuses/{sha}","languages_url":"https://api.github.com/repos/penzance/ab-testing-tool/languages","stargazers_url":"https://api.github.com/repos/penzance/ab-testing-tool/stargazers","contributors_url":"https://api.github.com/repos/penzance/ab-testing-tool/contributors","subscribers_url":"https://api.github.com/repos/penzance/ab-testing-tool/subscribers","subscription_url":"https://api.github.com/repos/penzance/ab-testing-tool/subscription","commits_url":"https://api.github.com/repos/penzance/ab-testing-tool/commits{/sha}","git_commits_url":"https://api.github.com/repos/penzance/ab-testing-tool/git/commits{/sha}","comments_url":"https://api.github.com/repos/penzance/ab-testing-tool/comments{/number}","issue_comment_url":"https://api.github.com/repos/penzance/ab-testing-tool/issues/comments{/number}","contents_url":"https://api.github.com/repos/penzance/ab-testing-tool/contents/{+path}","compare_url":"https://api.github.com/repos/penzance/ab-testing-tool/compare/{base}...{head}","merges_url":"https://api.github.com/repos/penzance/ab-testing-tool/merges","archive_url":"https://api.github.com/repos/penzance/ab-testing-tool/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/penzance/ab-testing-tool/downloads","issues_url":"https://api.github.com/repos/penzance/ab-testing-tool/issues{/number}","pulls_url":"https://api.github.com/repos/penzance/ab-testing-tool/pulls{/number}","milestones_url":"https://api.github.com/repos/penzance/ab-testing-tool/milestones{/number}","notifications_url":"https://api.github.com/repos/penzance/ab-testing-tool/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/penzance/ab-testing-tool/labels{/name}","releases_url":"https://api.github.com/repos/penzance/ab-testing-tool/releases{/id}","created_at":"2014-07-28T18:39:09Z","updated_at":"2015-04-24T21:30:10Z","pushed_at":"2015-04-28T00:50:15Z","git_url":"git://github.com/penzance/ab-testing-tool.git","ssh_url":"git@github.com:penzance/ab-testing-tool.git","clone_url":"https://github.com/penzance/ab-testing-tool.git","svn_url":"https://github.com/penzance/ab-testing-tool","homepage":"","size":5184,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":3,"default_branch":"develop"}},"base":{"label":"penzance:develop","ref":"develop","sha":"83f436213b53490a7b0620eac82ee1d8c3a0ff66","user":{"login":"penzance","id":7885127,"avatar_url":"https://avatars.githubusercontent.com/u/7885127?v=3","gravatar_id":"","url":"https://api.github.com/users/penzance","html_url":"https://github.com/penzance","followers_url":"https://api.github.com/users/penzance/followers","following_url":"https://api.github.com/users/penzance/following{/other_user}","gists_url":"https://api.github.com/users/penzance/gists{/gist_id}","starred_url":"https://api.github.com/users/penzance/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/penzance/subscriptions","organizations_url":"https://api.github.com/users/penzance/orgs","repos_url":"https://api.github.com/users/penzance/repos","events_url":"https://api.github.com/users/penzance/events{/privacy}","received_events_url":"https://api.github.com/users/penzance/received_events","type":"Organization","site_admin":false},"repo":{"id":22353530,"name":"ab-testing-tool","full_name":"penzance/ab-testing-tool","owner":{"login":"penzance","id":7885127,"avatar_url":"https://avatars.githubusercontent.com/u/7885127?v=3","gravatar_id":"","url":"https://api.github.com/users/penzance","html_url":"https://github.com/penzance","followers_url":"https://api.github.com/users/penzance/followers","following_url":"https://api.github.com/users/penzance/following{/other_user}","gists_url":"https://api.github.com/users/penzance/gists{/gist_id}","starred_url":"https://api.github.com/users/penzance/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/penzance/subscriptions","organizations_url":"https://api.github.com/users/penzance/orgs","repos_url":"https://api.github.com/users/penzance/repos","events_url":"https://api.github.com/users/penzance/events{/privacy}","received_events_url":"https://api.github.com/users/penzance/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/penzance/ab-testing-tool","description":"stage","fork":false,"url":"https://api.github.com/repos/penzance/ab-testing-tool","forks_url":"https://api.github.com/repos/penzance/ab-testing-tool/forks","keys_url":"https://api.github.com/repos/penzance/ab-testing-tool/keys{/key_id}","collaborators_url":"https://api.github.com/repos/penzance/ab-testing-tool/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/penzance/ab-testing-tool/teams","hooks_url":"https://api.github.com/repos/penzance/ab-testing-tool/hooks","issue_events_url":"https://api.github.com/repos/penzance/ab-testing-tool/issues/events{/number}","events_url":"https://api.github.com/repos/penzance/ab-testing-tool/events","assignees_url":"https://api.github.com/repos/penzance/ab-testing-tool/assignees{/user}","branches_url":"https://api.github.com/repos/penzance/ab-testing-tool/branches{/branch}","tags_url":"https://api.github.com/repos/penzance/ab-testing-tool/tags","blobs_url":"https://api.github.com/repos/penzance/ab-testing-tool/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/penzance/ab-testing-tool/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/penzance/ab-testing-tool/git/refs{/sha}","trees_url":"https://api.github.com/repos/penzance/ab-testing-tool/git/trees{/sha}","statuses_url":"https://api.github.com/repos/penzance/ab-testing-tool/statuses/{sha}","languages_url":"https://api.github.com/repos/penzance/ab-testing-tool/languages","stargazers_url":"https://api.github.com/repos/penzance/ab-testing-tool/stargazers","contributors_url":"https://api.github.com/repos/penzance/ab-testing-tool/contributors","subscribers_url":"https://api.github.com/repos/penzance/ab-testing-tool/subscribers","subscription_url":"https://api.github.com/repos/penzance/ab-testing-tool/subscription","commits_url":"https://api.github.com/repos/penzance/ab-testing-tool/commits{/sha}","git_commits_url":"https://api.github.com/repos/penzance/ab-testing-tool/git/commits{/sha}","comments_url":"https://api.github.com/repos/penzance/ab-testing-tool/comments{/number}","issue_comment_url":"https://api.github.com/repos/penzance/ab-testing-tool/issues/comments{/number}","contents_url":"https://api.github.com/repos/penzance/ab-testing-tool/contents/{+path}","compare_url":"https://api.github.com/repos/penzance/ab-testing-tool/compare/{base}...{head}","merges_url":"https://api.github.com/repos/penzance/ab-testing-tool/merges","archive_url":"https://api.github.com/repos/penzance/ab-testing-tool/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/penzance/ab-testing-tool/downloads","issues_url":"https://api.github.com/repos/penzance/ab-testing-tool/issues{/number}","pulls_url":"https://api.github.com/repos/penzance/ab-testing-tool/pulls{/number}","milestones_url":"https://api.github.com/repos/penzance/ab-testing-tool/milestones{/number}","notifications_url":"https://api.github.com/repos/penzance/ab-testing-tool/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/penzance/ab-testing-tool/labels{/name}","releases_url":"https://api.github.com/repos/penzance/ab-testing-tool/releases{/id}","created_at":"2014-07-28T18:39:09Z","updated_at":"2015-04-24T21:30:10Z","pushed_at":"2015-04-28T00:50:15Z","git_url":"git://github.com/penzance/ab-testing-tool.git","ssh_url":"git@github.com:penzance/ab-testing-tool.git","clone_url":"https://github.com/penzance/ab-testing-tool.git","svn_url":"https://github.com/penzance/ab-testing-tool","homepage":"","size":5184,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":3,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/penzance/ab-testing-tool/pulls/188"},"html":{"href":"https://github.com/penzance/ab-testing-tool/pull/188"},"issue":{"href":"https://api.github.com/repos/penzance/ab-testing-tool/issues/188"},"comments":{"href":"https://api.github.com/repos/penzance/ab-testing-tool/issues/188/comments"},"review_comments":{"href":"https://api.github.com/repos/penzance/ab-testing-tool/pulls/188/comments"},"review_comment":{"href":"https://api.github.com/repos/penzance/ab-testing-tool/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/penzance/ab-testing-tool/pulls/188/commits"},"statuses":{"href":"https://api.github.com/repos/penzance/ab-testing-tool/statuses/12d15573e2777813543aeb380225b031c7c46bca"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"kyfantaz","id":1251540,"avatar_url":"https://avatars.githubusercontent.com/u/1251540?v=3","gravatar_id":"","url":"https://api.github.com/users/kyfantaz","html_url":"https://github.com/kyfantaz","followers_url":"https://api.github.com/users/kyfantaz/followers","following_url":"https://api.github.com/users/kyfantaz/following{/other_user}","gists_url":"https://api.github.com/users/kyfantaz/gists{/gist_id}","starred_url":"https://api.github.com/users/kyfantaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyfantaz/subscriptions","organizations_url":"https://api.github.com/users/kyfantaz/orgs","repos_url":"https://api.github.com/users/kyfantaz/repos","events_url":"https://api.github.com/users/kyfantaz/events{/privacy}","received_events_url":"https://api.github.com/users/kyfantaz/received_events","type":"User","site_admin":false},"comments":4,"review_comments":3,"commits":9,"additions":223,"deletions":76,"changed_files":19}}