{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/24726995","id":24726995,"diff_hunk":"@@ -1,196 +1,90 @@\n # This class is the backing implementation of the Puppet function 'lookup'.\n-# See puppet/parser/functions/lookup.rb for documentation.\n+# See puppet/functions/lookup.rb for documentation.\n #\n class Puppet::Pops::Binder::Lookup\n+  # Performs a lookup in the configured scopes and optionally merges the default.\n+  #\n+  # This is a backing function and all parameters are assumed to have been type checked.\n+  # See puppet/functions/lookup.rb for full documentation and all parameter combinations.\n+  #\n+  # @param scope [Puppet::Parser::Scope] The scope to use for the lookup\n+  # @param name [String|Array<String>] The name or names to lookup\n+  # @param type [String|Puppet::Pops::Types::PAnyType] The expected type of the found value. Can be nil\n+  # @param default_value [Object] The value to use as default when no value is found\n+  # @param accept_undef [Boolean] true if it's accepable to return nil when no value is found. Can be nil\n+  # @param override [Hash<String,Object>] A map to use as override. Values found here are returned immediately. Can be empty.","path":"lib/puppet/pops/binder/lookup.rb","position":16,"original_position":16,"commit_id":"6d68bafb420a37b3615a59af4236a549bbd612c9","original_commit_id":"6d68bafb420a37b3615a59af4236a549bbd612c9","user":{"login":"hlindberg","id":563066,"avatar_url":"https://avatars.githubusercontent.com/u/563066?v=3","gravatar_id":"","url":"https://api.github.com/users/hlindberg","html_url":"https://github.com/hlindberg","followers_url":"https://api.github.com/users/hlindberg/followers","following_url":"https://api.github.com/users/hlindberg/following{/other_user}","gists_url":"https://api.github.com/users/hlindberg/gists{/gist_id}","starred_url":"https://api.github.com/users/hlindberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hlindberg/subscriptions","organizations_url":"https://api.github.com/users/hlindberg/orgs","repos_url":"https://api.github.com/users/hlindberg/repos","events_url":"https://api.github.com/users/hlindberg/events{/privacy}","received_events_url":"https://api.github.com/users/hlindberg/received_events","type":"User","site_admin":false},"body":"When there are values in override, and a merge is performed, does it merge across it and everything else? or is it indeed an \"immediate return\"? If so, that should be spelled out.","created_at":"2015-02-15T22:30:34Z","updated_at":"2015-02-15T22:30:34Z","html_url":"https://github.com/puppetlabs/puppet/pull/3609#discussion_r24726995","pull_request_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/3609","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/24726995"},"html":{"href":"https://github.com/puppetlabs/puppet/pull/3609#discussion_r24726995"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/3609"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppet/pulls/3609","id":29303502,"html_url":"https://github.com/puppetlabs/puppet/pull/3609","diff_url":"https://github.com/puppetlabs/puppet/pull/3609.diff","patch_url":"https://github.com/puppetlabs/puppet/pull/3609.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppet/issues/3609","number":3609,"state":"open","locked":false,"title":"(PUP-3948) Make lookup function the main data lookup function","user":{"login":"thallgren","id":209495,"avatar_url":"https://avatars.githubusercontent.com/u/209495?v=3","gravatar_id":"","url":"https://api.github.com/users/thallgren","html_url":"https://github.com/thallgren","followers_url":"https://api.github.com/users/thallgren/followers","following_url":"https://api.github.com/users/thallgren/following{/other_user}","gists_url":"https://api.github.com/users/thallgren/gists{/gist_id}","starred_url":"https://api.github.com/users/thallgren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thallgren/subscriptions","organizations_url":"https://api.github.com/users/thallgren/orgs","repos_url":"https://api.github.com/users/thallgren/repos","events_url":"https://api.github.com/users/thallgren/events{/privacy}","received_events_url":"https://api.github.com/users/thallgren/received_events","type":"User","site_admin":false},"body":"This repurposes the 4x lookup function to be the agnostic data lookup function working across global/environments and modules with merge behavior being the same as in hiera. hiera_array, and hiera_hash.\r\n\r\nThis PR consist of four commits because they cover separate tasks. See comment in each commit for more detail.","created_at":"2015-02-13T22:08:50Z","updated_at":"2015-02-15T22:30:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3940302913863a7bef961d718beb2a6e1dd92c06","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/3609/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/3609/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/{number}","comments_url":"https://api.github.com/repos/puppetlabs/puppet/issues/3609/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppet/statuses/6d68bafb420a37b3615a59af4236a549bbd612c9","head":{"label":"thallgren:issue/pup-3948/lookup-revamp","ref":"issue/pup-3948/lookup-revamp","sha":"6d68bafb420a37b3615a59af4236a549bbd612c9","user":{"login":"thallgren","id":209495,"avatar_url":"https://avatars.githubusercontent.com/u/209495?v=3","gravatar_id":"","url":"https://api.github.com/users/thallgren","html_url":"https://github.com/thallgren","followers_url":"https://api.github.com/users/thallgren/followers","following_url":"https://api.github.com/users/thallgren/following{/other_user}","gists_url":"https://api.github.com/users/thallgren/gists{/gist_id}","starred_url":"https://api.github.com/users/thallgren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thallgren/subscriptions","organizations_url":"https://api.github.com/users/thallgren/orgs","repos_url":"https://api.github.com/users/thallgren/repos","events_url":"https://api.github.com/users/thallgren/events{/privacy}","received_events_url":"https://api.github.com/users/thallgren/received_events","type":"User","site_admin":false},"repo":{"id":15137589,"name":"puppet","full_name":"thallgren/puppet","owner":{"login":"thallgren","id":209495,"avatar_url":"https://avatars.githubusercontent.com/u/209495?v=3","gravatar_id":"","url":"https://api.github.com/users/thallgren","html_url":"https://github.com/thallgren","followers_url":"https://api.github.com/users/thallgren/followers","following_url":"https://api.github.com/users/thallgren/following{/other_user}","gists_url":"https://api.github.com/users/thallgren/gists{/gist_id}","starred_url":"https://api.github.com/users/thallgren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thallgren/subscriptions","organizations_url":"https://api.github.com/users/thallgren/orgs","repos_url":"https://api.github.com/users/thallgren/repos","events_url":"https://api.github.com/users/thallgren/events{/privacy}","received_events_url":"https://api.github.com/users/thallgren/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/thallgren/puppet","description":"Server automation framework and application","fork":true,"url":"https://api.github.com/repos/thallgren/puppet","forks_url":"https://api.github.com/repos/thallgren/puppet/forks","keys_url":"https://api.github.com/repos/thallgren/puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thallgren/puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thallgren/puppet/teams","hooks_url":"https://api.github.com/repos/thallgren/puppet/hooks","issue_events_url":"https://api.github.com/repos/thallgren/puppet/issues/events{/number}","events_url":"https://api.github.com/repos/thallgren/puppet/events","assignees_url":"https://api.github.com/repos/thallgren/puppet/assignees{/user}","branches_url":"https://api.github.com/repos/thallgren/puppet/branches{/branch}","tags_url":"https://api.github.com/repos/thallgren/puppet/tags","blobs_url":"https://api.github.com/repos/thallgren/puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thallgren/puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thallgren/puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/thallgren/puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thallgren/puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/thallgren/puppet/languages","stargazers_url":"https://api.github.com/repos/thallgren/puppet/stargazers","contributors_url":"https://api.github.com/repos/thallgren/puppet/contributors","subscribers_url":"https://api.github.com/repos/thallgren/puppet/subscribers","subscription_url":"https://api.github.com/repos/thallgren/puppet/subscription","commits_url":"https://api.github.com/repos/thallgren/puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/thallgren/puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/thallgren/puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/thallgren/puppet/issues/comments/{number}","contents_url":"https://api.github.com/repos/thallgren/puppet/contents/{+path}","compare_url":"https://api.github.com/repos/thallgren/puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thallgren/puppet/merges","archive_url":"https://api.github.com/repos/thallgren/puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thallgren/puppet/downloads","issues_url":"https://api.github.com/repos/thallgren/puppet/issues{/number}","pulls_url":"https://api.github.com/repos/thallgren/puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/thallgren/puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/thallgren/puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thallgren/puppet/labels{/name}","releases_url":"https://api.github.com/repos/thallgren/puppet/releases{/id}","created_at":"2013-12-12T14:09:32Z","updated_at":"2015-01-21T18:51:48Z","pushed_at":"2015-02-14T13:34:12Z","git_url":"git://github.com/thallgren/puppet.git","ssh_url":"git@github.com:thallgren/puppet.git","clone_url":"https://github.com/thallgren/puppet.git","svn_url":"https://github.com/thallgren/puppet","homepage":"http://www.puppetlabs.com/puppet/introduction/","size":45735,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"38f9023661667478dc29bb27eaa48e9d11561b59","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":910744,"name":"puppet","full_name":"puppetlabs/puppet","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/puppet","description":"Server automation framework and application","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppet","forks_url":"https://api.github.com/repos/puppetlabs/puppet/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppet/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppet/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppet/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppet/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppet/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppet/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppet/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppet/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppet/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppet/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppet/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppet/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppet/issues/comments/{number}","contents_url":"https://api.github.com/repos/puppetlabs/puppet/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppet/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppet/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppet/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppet/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppet/releases{/id}","created_at":"2010-09-14T19:26:44Z","updated_at":"2015-02-15T21:51:24Z","pushed_at":"2015-02-13T21:00:44Z","git_url":"git://github.com/puppetlabs/puppet.git","ssh_url":"git@github.com:puppetlabs/puppet.git","clone_url":"https://github.com/puppetlabs/puppet.git","svn_url":"https://github.com/puppetlabs/puppet","homepage":"http://www.puppetlabs.com/puppet/introduction/","size":107054,"stargazers_count":2967,"watchers_count":2967,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1268,"mirror_url":null,"open_issues_count":34,"forks":1268,"open_issues":34,"watchers":2967,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/3609"},"html":{"href":"https://github.com/puppetlabs/puppet/pull/3609"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppet/issues/3609"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppet/issues/3609/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/3609/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/3609/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppet/statuses/6d68bafb420a37b3615a59af4236a549bbd612c9"}}}}