{"action":"created","issue":{"url":"https://api.github.com/repos/saltstack/salt/issues/20833","labels_url":"https://api.github.com/repos/saltstack/salt/issues/20833/labels{/name}","comments_url":"https://api.github.com/repos/saltstack/salt/issues/20833/comments","events_url":"https://api.github.com/repos/saltstack/salt/issues/20833/events","html_url":"https://github.com/saltstack/salt/issues/20833","id":58231103,"number":20833,"title":"modules/network.py seem to be broken in 2015.2.0rc1","user":{"login":"ltsampros","id":7254274,"avatar_url":"https://avatars.githubusercontent.com/u/7254274?v=3","gravatar_id":"","url":"https://api.github.com/users/ltsampros","html_url":"https://github.com/ltsampros","followers_url":"https://api.github.com/users/ltsampros/followers","following_url":"https://api.github.com/users/ltsampros/following{/other_user}","gists_url":"https://api.github.com/users/ltsampros/gists{/gist_id}","starred_url":"https://api.github.com/users/ltsampros/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ltsampros/subscriptions","organizations_url":"https://api.github.com/users/ltsampros/orgs","repos_url":"https://api.github.com/users/ltsampros/repos","events_url":"https://api.github.com/users/ltsampros/events{/privacy}","received_events_url":"https://api.github.com/users/ltsampros/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/saltstack/salt/labels/Bug","name":"Bug","color":"e11d21"},{"url":"https://api.github.com/repos/saltstack/salt/labels/Medium%20Severity","name":"Medium Severity","color":"fad8c7"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/saltstack/salt/milestones/47","labels_url":"https://api.github.com/repos/saltstack/salt/milestones/47/labels","id":801874,"number":47,"title":"Lithium","description":"Milestone to track important items that'll be part of the Lithium release.","creator":{"login":"pass-by-value","id":5684871,"avatar_url":"https://avatars.githubusercontent.com/u/5684871?v=3","gravatar_id":"","url":"https://api.github.com/users/pass-by-value","html_url":"https://github.com/pass-by-value","followers_url":"https://api.github.com/users/pass-by-value/followers","following_url":"https://api.github.com/users/pass-by-value/following{/other_user}","gists_url":"https://api.github.com/users/pass-by-value/gists{/gist_id}","starred_url":"https://api.github.com/users/pass-by-value/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pass-by-value/subscriptions","organizations_url":"https://api.github.com/users/pass-by-value/orgs","repos_url":"https://api.github.com/users/pass-by-value/repos","events_url":"https://api.github.com/users/pass-by-value/events{/privacy}","received_events_url":"https://api.github.com/users/pass-by-value/received_events","type":"User","site_admin":false},"open_issues":9,"closed_issues":27,"state":"open","created_at":"2014-09-24T22:36:06Z","updated_at":"2015-02-24T16:11:41Z","due_on":"2015-02-28T07:00:00Z","closed_at":null},"comments":3,"created_at":"2015-02-19T16:26:34Z","updated_at":"2015-02-24T16:13:07Z","closed_at":null,"body":"Hello all,\r\n\r\nI'm trying to get the default routes/netmask of a machine using network.default_route and network.routes calls through salt-ssh. However both fail on version 2015.2.0rc1:\r\n\r\n    ----------\r\n    retcode:\r\n        1\r\n    stderr:\r\n        Traceback (most recent call last):\r\n          File \"/tmp/.root_8ed75c__salt/salt-call\", line 4, in <module>\r\n            salt_call()\r\n          File \"/tmp/.root_8ed75c__salt/salt/scripts.py\", line 220, in salt_call\r\n            client.run()\r\n          File \"/tmp/.root_8ed75c__salt/salt/cli/call.py\", line 69, in run\r\n            caller.run()\r\n          File \"/tmp/.root_8ed75c__salt/salt/cli/caller.py\", line 236, in run\r\n            ret = self.call()\r\n          File \"/tmp/.root_8ed75c__salt/salt/cli/caller.py\", line 138, in call\r\n            ret['return'] = func(*args, **kwargs)\r\n          File \"/tmp/.root_8ed75c__salt/salt/modules/network.py\", line 1087, in default_route\r\n            _routes = routes()\r\n          File \"/tmp/.root_8ed75c__salt/salt/modules/network.py\", line 1058, in routes\r\n            routes_ = _netstat_route_linux()\r\n          File \"/tmp/.root_8ed75c__salt/salt/modules/network.py\", line 309, in _netstat_route_linux\r\n            'destination': comps[0],\r\n        IndexError: list index out of range\r\n    stdout:\r\n        \r\nI tried to debug what's happening by running the command on the minnion. Please see the output here:\r\nhttp://pastebin.com/a1S6571b\r\n\r\nI think something dodgy happens when commands with pipes and other symbols run through cmd.run: netstat -A inet -rn | tail -n+3\r\n\r\nAny input/feedback would be valuable.\r\nThanks"},"comment":{"url":"https://api.github.com/repos/saltstack/salt/issues/comments/75786586","html_url":"https://github.com/saltstack/salt/issues/20833#issuecomment-75786586","issue_url":"https://api.github.com/repos/saltstack/salt/issues/20833","id":75786586,"user":{"login":"jfindlay","id":702905,"avatar_url":"https://avatars.githubusercontent.com/u/702905?v=3","gravatar_id":"","url":"https://api.github.com/users/jfindlay","html_url":"https://github.com/jfindlay","followers_url":"https://api.github.com/users/jfindlay/followers","following_url":"https://api.github.com/users/jfindlay/following{/other_user}","gists_url":"https://api.github.com/users/jfindlay/gists{/gist_id}","starred_url":"https://api.github.com/users/jfindlay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfindlay/subscriptions","organizations_url":"https://api.github.com/users/jfindlay/orgs","repos_url":"https://api.github.com/users/jfindlay/repos","events_url":"https://api.github.com/users/jfindlay/events{/privacy}","received_events_url":"https://api.github.com/users/jfindlay/received_events","type":"User","site_admin":false},"created_at":"2015-02-24T16:13:07Z","updated_at":"2015-02-24T16:13:07Z","body":"The change will be documented in the 2015.2.0 release.  This change was made to protect against shell injection vulnerabilities.  We reviewed all salt modules to update them to the new behavior.  It seems that network.py was overlooked.  Thanks for reporting."}}