{"action":"created","issue":{"url":"https://api.github.com/repos/OPM/opm-parser/issues/649","labels_url":"https://api.github.com/repos/OPM/opm-parser/issues/649/labels{/name}","comments_url":"https://api.github.com/repos/OPM/opm-parser/issues/649/comments","events_url":"https://api.github.com/repos/OPM/opm-parser/issues/649/events","html_url":"https://github.com/OPM/opm-parser/pull/649","id":122713055,"number":649,"title":"Table column","user":{"login":"joakim-hove","id":1321665,"avatar_url":"https://avatars.githubusercontent.com/u/1321665?v=3","gravatar_id":"","url":"https://api.github.com/users/joakim-hove","html_url":"https://github.com/joakim-hove","followers_url":"https://api.github.com/users/joakim-hove/followers","following_url":"https://api.github.com/users/joakim-hove/following{/other_user}","gists_url":"https://api.github.com/users/joakim-hove/gists{/gist_id}","starred_url":"https://api.github.com/users/joakim-hove/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joakim-hove/subscriptions","organizations_url":"https://api.github.com/users/joakim-hove/orgs","repos_url":"https://api.github.com/users/joakim-hove/repos","events_url":"https://api.github.com/users/joakim-hove/events{/privacy}","received_events_url":"https://api.github.com/users/joakim-hove/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-12-17T11:04:09Z","updated_at":"2015-12-17T13:20:28Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/OPM/opm-parser/pulls/649","html_url":"https://github.com/OPM/opm-parser/pull/649","diff_url":"https://github.com/OPM/opm-parser/pull/649.diff","patch_url":"https://github.com/OPM/opm-parser/pull/649.patch"},"body":"[ Not ready for merge - some serious fixups required :-)]\r\n\r\nReworking the table code:\r\n\r\n- Working towards a situation where the tables can be specified in Json; not there yet.\r\n- Reduced use of templates - especially for `PVTO` and `PVTG`\r\n- Reduce the dependency on `xxxTable::init()` - the constructor should create a fully initialized and ready to use table object.\r\n- Added *Schema* classes for table and column metadata.\r\n- Removed special casing of test methods.\r\n- Removed friends and such - `public:` and `private:` should be enough\r\n\r\nIn this PR I have tried to put myself on a `std::shared_ptr<T>` diet; a bit like cod-liver oil  - it is good for you, but it does not taste good. Any comments on management of objects highly appreciated.\r\n\r\n \r\nDownstream PR's are in the works."},"comment":{"url":"https://api.github.com/repos/OPM/opm-parser/issues/comments/165451670","html_url":"https://github.com/OPM/opm-parser/pull/649#issuecomment-165451670","issue_url":"https://api.github.com/repos/OPM/opm-parser/issues/649","id":165451670,"user":{"login":"andlaus","id":1837735,"avatar_url":"https://avatars.githubusercontent.com/u/1837735?v=3","gravatar_id":"","url":"https://api.github.com/users/andlaus","html_url":"https://github.com/andlaus","followers_url":"https://api.github.com/users/andlaus/followers","following_url":"https://api.github.com/users/andlaus/following{/other_user}","gists_url":"https://api.github.com/users/andlaus/gists{/gist_id}","starred_url":"https://api.github.com/users/andlaus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andlaus/subscriptions","organizations_url":"https://api.github.com/users/andlaus/orgs","repos_url":"https://api.github.com/users/andlaus/repos","events_url":"https://api.github.com/users/andlaus/events{/privacy}","received_events_url":"https://api.github.com/users/andlaus/received_events","type":"User","site_admin":false},"created_at":"2015-12-17T13:20:28Z","updated_at":"2015-12-17T13:20:28Z","body":"the patch is mostly fine, before it is merged, you should assure that the downstream modules (opm-material, opm-core, opm-autodiff, ewoms) compile and that `flow` still produces the same results for Norne."}}