{"action":"created","issue":{"url":"https://api.github.com/repos/Financial-Times/next-build-tools/issues/235","labels_url":"https://api.github.com/repos/Financial-Times/next-build-tools/issues/235/labels{/name}","comments_url":"https://api.github.com/repos/Financial-Times/next-build-tools/issues/235/comments","events_url":"https://api.github.com/repos/Financial-Times/next-build-tools/issues/235/events","html_url":"https://github.com/Financial-Times/next-build-tools/pull/235","id":108816307,"number":235,"title":"Fix source maps","user":{"login":"ironsidevsquincy","id":74132,"avatar_url":"https://avatars.githubusercontent.com/u/74132?v=3","gravatar_id":"","url":"https://api.github.com/users/ironsidevsquincy","html_url":"https://github.com/ironsidevsquincy","followers_url":"https://api.github.com/users/ironsidevsquincy/followers","following_url":"https://api.github.com/users/ironsidevsquincy/following{/other_user}","gists_url":"https://api.github.com/users/ironsidevsquincy/gists{/gist_id}","starred_url":"https://api.github.com/users/ironsidevsquincy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ironsidevsquincy/subscriptions","organizations_url":"https://api.github.com/users/ironsidevsquincy/orgs","repos_url":"https://api.github.com/users/ironsidevsquincy/repos","events_url":"https://api.github.com/users/ironsidevsquincy/events{/privacy}","received_events_url":"https://api.github.com/users/ironsidevsquincy/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-09-29T08:13:20Z","updated_at":"2015-10-09T13:42:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Financial-Times/next-build-tools/pulls/235","html_url":"https://github.com/Financial-Times/next-build-tools/pull/235","diff_url":"https://github.com/Financial-Times/next-build-tools/pull/235.diff","patch_url":"https://github.com/Financial-Times/next-build-tools/pull/235.patch"},"body":"Previously we minified the JS within NBT, and pulled the source map out from an inline comment into an external file. This is now broken, e.g. the source map created looks like\r\n\r\n```\r\n{\"version\":3,\"file\":\"main.js\",\"sources\":[],\"names\":[],\"mappings\":\"\",\"sourceRoot\":\"/source/\",\"sourcesContent\":[]}\r\n```\r\n\r\nHowever OBT4 has fixed the issue with minifying and creating a source map, so suggest we let OBT do its thing, inline the source map, and look at pulling it into another file in a future PR"},"comment":{"url":"https://api.github.com/repos/Financial-Times/next-build-tools/issues/comments/146874332","html_url":"https://github.com/Financial-Times/next-build-tools/pull/235#issuecomment-146874332","issue_url":"https://api.github.com/repos/Financial-Times/next-build-tools/issues/235","id":146874332,"user":{"login":"keirog","id":150157,"avatar_url":"https://avatars.githubusercontent.com/u/150157?v=3","gravatar_id":"","url":"https://api.github.com/users/keirog","html_url":"https://github.com/keirog","followers_url":"https://api.github.com/users/keirog/followers","following_url":"https://api.github.com/users/keirog/following{/other_user}","gists_url":"https://api.github.com/users/keirog/gists{/gist_id}","starred_url":"https://api.github.com/users/keirog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keirog/subscriptions","organizations_url":"https://api.github.com/users/keirog/orgs","repos_url":"https://api.github.com/users/keirog/repos","events_url":"https://api.github.com/users/keirog/events{/privacy}","received_events_url":"https://api.github.com/users/keirog/received_events","type":"User","site_admin":false},"created_at":"2015-10-09T13:42:00Z","updated_at":"2015-10-09T13:42:00Z","body":"Was a silly comment really, but I meant a staging environment with inline source maps (+ not included in prod)"}}