{"action":"created","comment":{"url":"https://api.github.com/repos/owncloud/ocdev/pulls/comments/32892125","id":32892125,"diff_hunk":"@@ -167,5 +167,11 @@ def clone_repo(self, url, branch='master', directory=None, no_history=False):\n         if directory:\n             cmd.append(directory)\n \n-\n-        return check_call(cmd)\n\\ No newline at end of file\n+        assert not os.path.exists('{0}/core'.format(os.getcwd())), 'cannot clone, {0}/core already exists'.format(os.getcwd())\n+        assert os.access(os.getcwd(), os.W_OK), 'Insufficient privilege to write to this directory'","path":"ocdev/plugins/setup/setup.py","position":8,"original_position":8,"commit_id":"3fc43978cb296625c4b34e8e156107e142f923bc","original_commit_id":"3fc43978cb296625c4b34e8e156107e142f923bc","user":{"login":"Raydiation","id":195053,"avatar_url":"https://avatars.githubusercontent.com/u/195053?v=3","gravatar_id":"","url":"https://api.github.com/users/Raydiation","html_url":"https://github.com/Raydiation","followers_url":"https://api.github.com/users/Raydiation/followers","following_url":"https://api.github.com/users/Raydiation/following{/other_user}","gists_url":"https://api.github.com/users/Raydiation/gists{/gist_id}","starred_url":"https://api.github.com/users/Raydiation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Raydiation/subscriptions","organizations_url":"https://api.github.com/users/Raydiation/orgs","repos_url":"https://api.github.com/users/Raydiation/repos","events_url":"https://api.github.com/users/Raydiation/events{/privacy}","received_events_url":"https://api.github.com/users/Raydiation/received_events","type":"User","site_admin":false},"body":"Ok, so apparently we already do this check https://github.com/WillBrennan/ocdev/blob/master/ocdev/plugins/setup/setup.py#L111 xD","created_at":"2015-06-21T09:45:46Z","updated_at":"2015-06-21T09:45:46Z","html_url":"https://github.com/owncloud/ocdev/pull/33#discussion_r32892125","pull_request_url":"https://api.github.com/repos/owncloud/ocdev/pulls/33","_links":{"self":{"href":"https://api.github.com/repos/owncloud/ocdev/pulls/comments/32892125"},"html":{"href":"https://github.com/owncloud/ocdev/pull/33#discussion_r32892125"},"pull_request":{"href":"https://api.github.com/repos/owncloud/ocdev/pulls/33"}}},"pull_request":{"url":"https://api.github.com/repos/owncloud/ocdev/pulls/33","id":37888586,"html_url":"https://github.com/owncloud/ocdev/pull/33","diff_url":"https://github.com/owncloud/ocdev/pull/33.diff","patch_url":"https://github.com/owncloud/ocdev/pull/33.patch","issue_url":"https://api.github.com/repos/owncloud/ocdev/issues/33","number":33,"state":"open","locked":false,"title":"Modified clone_repo method in ocdev/plugins/setup/setup.py","user":{"login":"WillBrennan","id":7763205,"avatar_url":"https://avatars.githubusercontent.com/u/7763205?v=3","gravatar_id":"","url":"https://api.github.com/users/WillBrennan","html_url":"https://github.com/WillBrennan","followers_url":"https://api.github.com/users/WillBrennan/followers","following_url":"https://api.github.com/users/WillBrennan/following{/other_user}","gists_url":"https://api.github.com/users/WillBrennan/gists{/gist_id}","starred_url":"https://api.github.com/users/WillBrennan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WillBrennan/subscriptions","organizations_url":"https://api.github.com/users/WillBrennan/orgs","repos_url":"https://api.github.com/users/WillBrennan/repos","events_url":"https://api.github.com/users/WillBrennan/events{/privacy}","received_events_url":"https://api.github.com/users/WillBrennan/received_events","type":"User","site_admin":false},"body":"Modified clone_repo method in ocdev/plugins/setup/setup.py to include better exception handelling and helpful statements on failure. Was trying to install it and it threw a generic error that the subprocess call failed but didn't include why.","created_at":"2015-06-17T11:01:28Z","updated_at":"2015-06-21T09:45:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ace0d466aa243d5a38fcb2569b2f79084b81045a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/owncloud/ocdev/pulls/33/commits","review_comments_url":"https://api.github.com/repos/owncloud/ocdev/pulls/33/comments","review_comment_url":"https://api.github.com/repos/owncloud/ocdev/pulls/comments{/number}","comments_url":"https://api.github.com/repos/owncloud/ocdev/issues/33/comments","statuses_url":"https://api.github.com/repos/owncloud/ocdev/statuses/3fc43978cb296625c4b34e8e156107e142f923bc","head":{"label":"WillBrennan:master","ref":"master","sha":"3fc43978cb296625c4b34e8e156107e142f923bc","user":{"login":"WillBrennan","id":7763205,"avatar_url":"https://avatars.githubusercontent.com/u/7763205?v=3","gravatar_id":"","url":"https://api.github.com/users/WillBrennan","html_url":"https://github.com/WillBrennan","followers_url":"https://api.github.com/users/WillBrennan/followers","following_url":"https://api.github.com/users/WillBrennan/following{/other_user}","gists_url":"https://api.github.com/users/WillBrennan/gists{/gist_id}","starred_url":"https://api.github.com/users/WillBrennan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WillBrennan/subscriptions","organizations_url":"https://api.github.com/users/WillBrennan/orgs","repos_url":"https://api.github.com/users/WillBrennan/repos","events_url":"https://api.github.com/users/WillBrennan/events{/privacy}","received_events_url":"https://api.github.com/users/WillBrennan/received_events","type":"User","site_admin":false},"repo":{"id":37589237,"name":"ocdev","full_name":"WillBrennan/ocdev","owner":{"login":"WillBrennan","id":7763205,"avatar_url":"https://avatars.githubusercontent.com/u/7763205?v=3","gravatar_id":"","url":"https://api.github.com/users/WillBrennan","html_url":"https://github.com/WillBrennan","followers_url":"https://api.github.com/users/WillBrennan/followers","following_url":"https://api.github.com/users/WillBrennan/following{/other_user}","gists_url":"https://api.github.com/users/WillBrennan/gists{/gist_id}","starred_url":"https://api.github.com/users/WillBrennan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WillBrennan/subscriptions","organizations_url":"https://api.github.com/users/WillBrennan/orgs","repos_url":"https://api.github.com/users/WillBrennan/repos","events_url":"https://api.github.com/users/WillBrennan/events{/privacy}","received_events_url":"https://api.github.com/users/WillBrennan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/WillBrennan/ocdev","description":"a tool for creating app templates and setting up installations from git","fork":true,"url":"https://api.github.com/repos/WillBrennan/ocdev","forks_url":"https://api.github.com/repos/WillBrennan/ocdev/forks","keys_url":"https://api.github.com/repos/WillBrennan/ocdev/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WillBrennan/ocdev/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WillBrennan/ocdev/teams","hooks_url":"https://api.github.com/repos/WillBrennan/ocdev/hooks","issue_events_url":"https://api.github.com/repos/WillBrennan/ocdev/issues/events{/number}","events_url":"https://api.github.com/repos/WillBrennan/ocdev/events","assignees_url":"https://api.github.com/repos/WillBrennan/ocdev/assignees{/user}","branches_url":"https://api.github.com/repos/WillBrennan/ocdev/branches{/branch}","tags_url":"https://api.github.com/repos/WillBrennan/ocdev/tags","blobs_url":"https://api.github.com/repos/WillBrennan/ocdev/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WillBrennan/ocdev/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WillBrennan/ocdev/git/refs{/sha}","trees_url":"https://api.github.com/repos/WillBrennan/ocdev/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WillBrennan/ocdev/statuses/{sha}","languages_url":"https://api.github.com/repos/WillBrennan/ocdev/languages","stargazers_url":"https://api.github.com/repos/WillBrennan/ocdev/stargazers","contributors_url":"https://api.github.com/repos/WillBrennan/ocdev/contributors","subscribers_url":"https://api.github.com/repos/WillBrennan/ocdev/subscribers","subscription_url":"https://api.github.com/repos/WillBrennan/ocdev/subscription","commits_url":"https://api.github.com/repos/WillBrennan/ocdev/commits{/sha}","git_commits_url":"https://api.github.com/repos/WillBrennan/ocdev/git/commits{/sha}","comments_url":"https://api.github.com/repos/WillBrennan/ocdev/comments{/number}","issue_comment_url":"https://api.github.com/repos/WillBrennan/ocdev/issues/comments{/number}","contents_url":"https://api.github.com/repos/WillBrennan/ocdev/contents/{+path}","compare_url":"https://api.github.com/repos/WillBrennan/ocdev/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WillBrennan/ocdev/merges","archive_url":"https://api.github.com/repos/WillBrennan/ocdev/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WillBrennan/ocdev/downloads","issues_url":"https://api.github.com/repos/WillBrennan/ocdev/issues{/number}","pulls_url":"https://api.github.com/repos/WillBrennan/ocdev/pulls{/number}","milestones_url":"https://api.github.com/repos/WillBrennan/ocdev/milestones{/number}","notifications_url":"https://api.github.com/repos/WillBrennan/ocdev/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WillBrennan/ocdev/labels{/name}","releases_url":"https://api.github.com/repos/WillBrennan/ocdev/releases{/id}","created_at":"2015-06-17T10:45:19Z","updated_at":"2015-06-17T10:45:20Z","pushed_at":"2015-06-17T23:51:59Z","git_url":"git://github.com/WillBrennan/ocdev.git","ssh_url":"git@github.com:WillBrennan/ocdev.git","clone_url":"https://github.com/WillBrennan/ocdev.git","svn_url":"https://github.com/WillBrennan/ocdev","homepage":null,"size":3068,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"owncloud:master","ref":"master","sha":"5573f2ae9e46d60b310125e707b8dac1017ac648","user":{"login":"owncloud","id":1645051,"avatar_url":"https://avatars.githubusercontent.com/u/1645051?v=3","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"repo":{"id":23668257,"name":"ocdev","full_name":"owncloud/ocdev","owner":{"login":"owncloud","id":1645051,"avatar_url":"https://avatars.githubusercontent.com/u/1645051?v=3","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/owncloud/ocdev","description":"a tool for creating app templates and setting up installations from git","fork":false,"url":"https://api.github.com/repos/owncloud/ocdev","forks_url":"https://api.github.com/repos/owncloud/ocdev/forks","keys_url":"https://api.github.com/repos/owncloud/ocdev/keys{/key_id}","collaborators_url":"https://api.github.com/repos/owncloud/ocdev/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/owncloud/ocdev/teams","hooks_url":"https://api.github.com/repos/owncloud/ocdev/hooks","issue_events_url":"https://api.github.com/repos/owncloud/ocdev/issues/events{/number}","events_url":"https://api.github.com/repos/owncloud/ocdev/events","assignees_url":"https://api.github.com/repos/owncloud/ocdev/assignees{/user}","branches_url":"https://api.github.com/repos/owncloud/ocdev/branches{/branch}","tags_url":"https://api.github.com/repos/owncloud/ocdev/tags","blobs_url":"https://api.github.com/repos/owncloud/ocdev/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/owncloud/ocdev/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/owncloud/ocdev/git/refs{/sha}","trees_url":"https://api.github.com/repos/owncloud/ocdev/git/trees{/sha}","statuses_url":"https://api.github.com/repos/owncloud/ocdev/statuses/{sha}","languages_url":"https://api.github.com/repos/owncloud/ocdev/languages","stargazers_url":"https://api.github.com/repos/owncloud/ocdev/stargazers","contributors_url":"https://api.github.com/repos/owncloud/ocdev/contributors","subscribers_url":"https://api.github.com/repos/owncloud/ocdev/subscribers","subscription_url":"https://api.github.com/repos/owncloud/ocdev/subscription","commits_url":"https://api.github.com/repos/owncloud/ocdev/commits{/sha}","git_commits_url":"https://api.github.com/repos/owncloud/ocdev/git/commits{/sha}","comments_url":"https://api.github.com/repos/owncloud/ocdev/comments{/number}","issue_comment_url":"https://api.github.com/repos/owncloud/ocdev/issues/comments{/number}","contents_url":"https://api.github.com/repos/owncloud/ocdev/contents/{+path}","compare_url":"https://api.github.com/repos/owncloud/ocdev/compare/{base}...{head}","merges_url":"https://api.github.com/repos/owncloud/ocdev/merges","archive_url":"https://api.github.com/repos/owncloud/ocdev/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/owncloud/ocdev/downloads","issues_url":"https://api.github.com/repos/owncloud/ocdev/issues{/number}","pulls_url":"https://api.github.com/repos/owncloud/ocdev/pulls{/number}","milestones_url":"https://api.github.com/repos/owncloud/ocdev/milestones{/number}","notifications_url":"https://api.github.com/repos/owncloud/ocdev/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/owncloud/ocdev/labels{/name}","releases_url":"https://api.github.com/repos/owncloud/ocdev/releases{/id}","created_at":"2014-09-04T15:33:11Z","updated_at":"2015-05-06T14:00:47Z","pushed_at":"2015-06-17T23:51:59Z","git_url":"git://github.com/owncloud/ocdev.git","ssh_url":"git@github.com:owncloud/ocdev.git","clone_url":"https://github.com/owncloud/ocdev.git","svn_url":"https://github.com/owncloud/ocdev","homepage":null,"size":3068,"stargazers_count":6,"watchers_count":6,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":6,"forks":13,"open_issues":6,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/owncloud/ocdev/pulls/33"},"html":{"href":"https://github.com/owncloud/ocdev/pull/33"},"issue":{"href":"https://api.github.com/repos/owncloud/ocdev/issues/33"},"comments":{"href":"https://api.github.com/repos/owncloud/ocdev/issues/33/comments"},"review_comments":{"href":"https://api.github.com/repos/owncloud/ocdev/pulls/33/comments"},"review_comment":{"href":"https://api.github.com/repos/owncloud/ocdev/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/owncloud/ocdev/pulls/33/commits"},"statuses":{"href":"https://api.github.com/repos/owncloud/ocdev/statuses/3fc43978cb296625c4b34e8e156107e142f923bc"}}}}