{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/45164394","id":45164394,"diff_hunk":"@@ -294,20 +294,21 @@ function detect-nodes {\n   done\n \n   if [[ -z \"${KUBE_NODE_IP_ADDRESSES[@]}\" ]]; then\n-    echo \"Could not detect Kubernetes node nodes. Make sure you've launched a cluster with 'kube-up.sh'\" >&2\n+    echo \"Could not detect Kubernetes node nodes.\\\n+    Make sure you've launched a cluster with 'kube-up.sh'\" >&2\n     exit 1\n   fi\n }\n \n # Instantiate a kubernetes cluster on ubuntu\n function kube-up() {\n-  source \"${KUBE_ROOT}/cluster/ubuntu/${KUBE_CONFIG_FILE-\"config-default.sh\"}\"\n+  source \"${KUBE_ROOT}/cluster/ubuntu/${KUBE_CONFIG_FILE:-config-default.sh}\"\n \n-  # ensure the binaries are well prepared\n-  if [ ! -f \"ubuntu/binaries/master/kube-apiserver\" ]; then\n-    echo \"No local binaries for kube-up, downloading... \"\n-    \"${KUBE_ROOT}/cluster/ubuntu/build.sh\"\n+  # downloading tarball release\n+  if [[ -d \"${KUBE_ROOT}/cluster/ubuntu/binaries\" ]]; then","path":"cluster/ubuntu/util.sh","position":300,"original_position":300,"commit_id":"e5a3b07ce5309ce4788c21777e61915f5291f6a9","original_commit_id":"e5a3b07ce5309ce4788c21777e61915f5291f6a9","user":{"login":"dalanlan","id":5979704,"avatar_url":"https://avatars.githubusercontent.com/u/5979704?v=3","gravatar_id":"","url":"https://api.github.com/users/dalanlan","html_url":"https://github.com/dalanlan","followers_url":"https://api.github.com/users/dalanlan/followers","following_url":"https://api.github.com/users/dalanlan/following{/other_user}","gists_url":"https://api.github.com/users/dalanlan/gists{/gist_id}","starred_url":"https://api.github.com/users/dalanlan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dalanlan/subscriptions","organizations_url":"https://api.github.com/users/dalanlan/orgs","repos_url":"https://api.github.com/users/dalanlan/repos","events_url":"https://api.github.com/users/dalanlan/events{/privacy}","received_events_url":"https://api.github.com/users/dalanlan/received_events","type":"User","site_admin":false},"body":"The old one has potential bug (my bad) to bring up a cluster with an unmatched version due to the legacy file.    ","created_at":"2015-11-18T06:36:30Z","updated_at":"2015-11-18T06:36:30Z","html_url":"https://github.com/kubernetes/kubernetes/pull/17055#discussion_r45164394","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/17055","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/45164394"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/17055#discussion_r45164394"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/17055"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/17055","id":50255713,"html_url":"https://github.com/kubernetes/kubernetes/pull/17055","diff_url":"https://github.com/kubernetes/kubernetes/pull/17055.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/17055.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/17055","number":17055,"state":"open","locked":false,"title":"clean up deployment script for ubuntu","user":{"login":"dalanlan","id":5979704,"avatar_url":"https://avatars.githubusercontent.com/u/5979704?v=3","gravatar_id":"","url":"https://api.github.com/users/dalanlan","html_url":"https://github.com/dalanlan","followers_url":"https://api.github.com/users/dalanlan/followers","following_url":"https://api.github.com/users/dalanlan/following{/other_user}","gists_url":"https://api.github.com/users/dalanlan/gists{/gist_id}","starred_url":"https://api.github.com/users/dalanlan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dalanlan/subscriptions","organizations_url":"https://api.github.com/users/dalanlan/orgs","repos_url":"https://api.github.com/users/dalanlan/repos","events_url":"https://api.github.com/users/dalanlan/events{/privacy}","received_events_url":"https://api.github.com/users/dalanlan/received_events","type":"User","site_admin":false},"body":"- Fix #17014.\r\n- Carry clean up work for messy script for deployment on ubuntu. Ref #15060","created_at":"2015-11-10T13:52:17Z","updated_at":"2015-11-18T06:36:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7a44b88aef56ecaca6d74313632020a70477a01a","assignee":{"login":"zmerlynn","id":4942464,"avatar_url":"https://avatars.githubusercontent.com/u/4942464?v=3","gravatar_id":"","url":"https://api.github.com/users/zmerlynn","html_url":"https://github.com/zmerlynn","followers_url":"https://api.github.com/users/zmerlynn/followers","following_url":"https://api.github.com/users/zmerlynn/following{/other_user}","gists_url":"https://api.github.com/users/zmerlynn/gists{/gist_id}","starred_url":"https://api.github.com/users/zmerlynn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zmerlynn/subscriptions","organizations_url":"https://api.github.com/users/zmerlynn/orgs","repos_url":"https://api.github.com/users/zmerlynn/repos","events_url":"https://api.github.com/users/zmerlynn/events{/privacy}","received_events_url":"https://api.github.com/users/zmerlynn/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/17055/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/17055/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/17055/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/e5a3b07ce5309ce4788c21777e61915f5291f6a9","head":{"label":"ZJU-SEL:clean-up-ubuntu-deployment","ref":"clean-up-ubuntu-deployment","sha":"e5a3b07ce5309ce4788c21777e61915f5291f6a9","user":{"login":"ZJU-SEL","id":5188515,"avatar_url":"https://avatars.githubusercontent.com/u/5188515?v=3","gravatar_id":"","url":"https://api.github.com/users/ZJU-SEL","html_url":"https://github.com/ZJU-SEL","followers_url":"https://api.github.com/users/ZJU-SEL/followers","following_url":"https://api.github.com/users/ZJU-SEL/following{/other_user}","gists_url":"https://api.github.com/users/ZJU-SEL/gists{/gist_id}","starred_url":"https://api.github.com/users/ZJU-SEL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZJU-SEL/subscriptions","organizations_url":"https://api.github.com/users/ZJU-SEL/orgs","repos_url":"https://api.github.com/users/ZJU-SEL/repos","events_url":"https://api.github.com/users/ZJU-SEL/events{/privacy}","received_events_url":"https://api.github.com/users/ZJU-SEL/received_events","type":"Organization","site_admin":false},"repo":{"id":29713851,"name":"kubernetes","full_name":"ZJU-SEL/kubernetes","owner":{"login":"ZJU-SEL","id":5188515,"avatar_url":"https://avatars.githubusercontent.com/u/5188515?v=3","gravatar_id":"","url":"https://api.github.com/users/ZJU-SEL","html_url":"https://github.com/ZJU-SEL","followers_url":"https://api.github.com/users/ZJU-SEL/followers","following_url":"https://api.github.com/users/ZJU-SEL/following{/other_user}","gists_url":"https://api.github.com/users/ZJU-SEL/gists{/gist_id}","starred_url":"https://api.github.com/users/ZJU-SEL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZJU-SEL/subscriptions","organizations_url":"https://api.github.com/users/ZJU-SEL/orgs","repos_url":"https://api.github.com/users/ZJU-SEL/repos","events_url":"https://api.github.com/users/ZJU-SEL/events{/privacy}","received_events_url":"https://api.github.com/users/ZJU-SEL/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ZJU-SEL/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/ZJU-SEL/kubernetes","forks_url":"https://api.github.com/repos/ZJU-SEL/kubernetes/forks","keys_url":"https://api.github.com/repos/ZJU-SEL/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ZJU-SEL/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ZJU-SEL/kubernetes/teams","hooks_url":"https://api.github.com/repos/ZJU-SEL/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/ZJU-SEL/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/ZJU-SEL/kubernetes/events","assignees_url":"https://api.github.com/repos/ZJU-SEL/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/ZJU-SEL/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/ZJU-SEL/kubernetes/tags","blobs_url":"https://api.github.com/repos/ZJU-SEL/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ZJU-SEL/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ZJU-SEL/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/ZJU-SEL/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ZJU-SEL/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/ZJU-SEL/kubernetes/languages","stargazers_url":"https://api.github.com/repos/ZJU-SEL/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/ZJU-SEL/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/ZJU-SEL/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/ZJU-SEL/kubernetes/subscription","commits_url":"https://api.github.com/repos/ZJU-SEL/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/ZJU-SEL/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/ZJU-SEL/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/ZJU-SEL/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/ZJU-SEL/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/ZJU-SEL/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ZJU-SEL/kubernetes/merges","archive_url":"https://api.github.com/repos/ZJU-SEL/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ZJU-SEL/kubernetes/downloads","issues_url":"https://api.github.com/repos/ZJU-SEL/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/ZJU-SEL/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/ZJU-SEL/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/ZJU-SEL/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ZJU-SEL/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/ZJU-SEL/kubernetes/releases{/id}","created_at":"2015-01-23T03:02:22Z","updated_at":"2015-11-11T01:26:03Z","pushed_at":"2015-11-18T05:09:32Z","git_url":"git://github.com/ZJU-SEL/kubernetes.git","ssh_url":"git@github.com:ZJU-SEL/kubernetes.git","clone_url":"https://github.com/ZJU-SEL/kubernetes.git","svn_url":"https://github.com/ZJU-SEL/kubernetes","homepage":"http://kubernetes.io","size":134758,"stargazers_count":4,"watchers_count":4,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":4,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"01656fd9a22c8c13fc6d9dc00dddda6389ca5158","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","created_at":"2014-06-06T22:56:04Z","updated_at":"2015-11-18T06:07:14Z","pushed_at":"2015-11-18T06:32:54Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":287532,"stargazers_count":11315,"watchers_count":11315,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2983,"mirror_url":null,"open_issues_count":2334,"forks":2983,"open_issues":2334,"watchers":11315,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/17055"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/17055"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/17055"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/17055/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/17055/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/17055/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/e5a3b07ce5309ce4788c21777e61915f5291f6a9"}}}}