{"action":"created","comment":{"url":"https://api.github.com/repos/lyft/amazon-kinesis-client/pulls/comments/43061731","id":43061731,"diff_hunk":"@@ -466,6 +486,21 @@ public KinesisClientLibConfiguration withKinesisEndpoint(String kinesisEndpoint)\n     }\n \n     /**\n+     * @param dynamoDBEndpoint DynamoDB endpoint\n+     * @return KinesisClientLibConfiguration\n+     */\n+    public KinesisClientLibConfiguration withDynamoDBEndpoint(String dynamoDBEndpoint) {\n+        this.dynamoDBEndpoint = dynamoDBEndpoint;\n+\n+        // call .setEndpoint() on the current dynamoDBClientConfig\n+        ClientConfiguration config = this.dynamoDBClientConfig;\n+        config.setEndpoint(dynamoDBEndpoint);\n+        this.dynamoDBClientConfig = config;\n+\n+        return this;\n+    }\n+\n+    /**","path":"src/main/java/com/amazonaws/services/kinesis/clientlibrary/lib/worker/KinesisClientLibConfiguration.java","position":98,"original_position":98,"commit_id":"beecda4ff839771963062c337b6c29c08b07c281","original_commit_id":"beecda4ff839771963062c337b6c29c08b07c281","user":{"login":"mjchoi","id":1069685,"avatar_url":"https://avatars.githubusercontent.com/u/1069685?v=3","gravatar_id":"","url":"https://api.github.com/users/mjchoi","html_url":"https://github.com/mjchoi","followers_url":"https://api.github.com/users/mjchoi/followers","following_url":"https://api.github.com/users/mjchoi/following{/other_user}","gists_url":"https://api.github.com/users/mjchoi/gists{/gist_id}","starred_url":"https://api.github.com/users/mjchoi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjchoi/subscriptions","organizations_url":"https://api.github.com/users/mjchoi/orgs","repos_url":"https://api.github.com/users/mjchoi/repos","events_url":"https://api.github.com/users/mjchoi/events{/privacy}","received_events_url":"https://api.github.com/users/mjchoi/received_events","type":"User","site_admin":false},"body":"^ This is the only important part:\r\n* https://github.com/lyft/amazon-kinesis-client/blob/lyft-v1.2.1/src/main/java/com/amazonaws/services/kinesis/multilang/MultiLangDaemon.java#L124\r\n* https://github.com/lyft/amazon-kinesis-client/blob/lyft-v1.2.1/src/main/java/com/amazonaws/services/kinesis/clientlibrary/config/KinesisClientLibConfigurator.java#L139\r\n* https://github.com/lyft/amazon-kinesis-client/blob/lyft-v1.2.1/src/main/java/com/amazonaws/services/kinesis/clientlibrary/config/KinesisClientLibConfigurator.java#L172-L173","created_at":"2015-10-26T22:20:43Z","updated_at":"2015-10-26T22:20:43Z","html_url":"https://github.com/lyft/amazon-kinesis-client/pull/1#discussion_r43061731","pull_request_url":"https://api.github.com/repos/lyft/amazon-kinesis-client/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/lyft/amazon-kinesis-client/pulls/comments/43061731"},"html":{"href":"https://github.com/lyft/amazon-kinesis-client/pull/1#discussion_r43061731"},"pull_request":{"href":"https://api.github.com/repos/lyft/amazon-kinesis-client/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/lyft/amazon-kinesis-client/pulls/1","id":48805045,"html_url":"https://github.com/lyft/amazon-kinesis-client/pull/1","diff_url":"https://github.com/lyft/amazon-kinesis-client/pull/1.diff","patch_url":"https://github.com/lyft/amazon-kinesis-client/pull/1.patch","issue_url":"https://api.github.com/repos/lyft/amazon-kinesis-client/issues/1","number":1,"state":"open","locked":false,"title":"KCL 1.2.1: Add support for configuring DynamoDB endpoint","user":{"login":"mjchoi","id":1069685,"avatar_url":"https://avatars.githubusercontent.com/u/1069685?v=3","gravatar_id":"","url":"https://api.github.com/users/mjchoi","html_url":"https://github.com/mjchoi","followers_url":"https://api.github.com/users/mjchoi/followers","following_url":"https://api.github.com/users/mjchoi/following{/other_user}","gists_url":"https://api.github.com/users/mjchoi/gists{/gist_id}","starred_url":"https://api.github.com/users/mjchoi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjchoi/subscriptions","organizations_url":"https://api.github.com/users/mjchoi/orgs","repos_url":"https://api.github.com/users/mjchoi/repos","events_url":"https://api.github.com/users/mjchoi/events{/privacy}","received_events_url":"https://api.github.com/users/mjchoi/received_events","type":"User","site_admin":false},"body":"Adding a new field named `dynamoDBEndpoint` to the .properties file\r\nthat gets passed into the KCL multi-lang daemon. We need this ability\r\nto point the KCL worker at a local instance of DynamoDB rather than in\r\nAWS.","created_at":"2015-10-26T22:16:27Z","updated_at":"2015-10-26T22:20:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9b4ad5e9c8af6134e01f84cfb747b2085ff6a5ea","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/lyft/amazon-kinesis-client/pulls/1/commits","review_comments_url":"https://api.github.com/repos/lyft/amazon-kinesis-client/pulls/1/comments","review_comment_url":"https://api.github.com/repos/lyft/amazon-kinesis-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lyft/amazon-kinesis-client/issues/1/comments","statuses_url":"https://api.github.com/repos/lyft/amazon-kinesis-client/statuses/beecda4ff839771963062c337b6c29c08b07c281","head":{"label":"lyft:add-dynamo-db-endpoint-support","ref":"add-dynamo-db-endpoint-support","sha":"beecda4ff839771963062c337b6c29c08b07c281","user":{"login":"lyft","id":4269340,"avatar_url":"https://avatars.githubusercontent.com/u/4269340?v=3","gravatar_id":"","url":"https://api.github.com/users/lyft","html_url":"https://github.com/lyft","followers_url":"https://api.github.com/users/lyft/followers","following_url":"https://api.github.com/users/lyft/following{/other_user}","gists_url":"https://api.github.com/users/lyft/gists{/gist_id}","starred_url":"https://api.github.com/users/lyft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lyft/subscriptions","organizations_url":"https://api.github.com/users/lyft/orgs","repos_url":"https://api.github.com/users/lyft/repos","events_url":"https://api.github.com/users/lyft/events{/privacy}","received_events_url":"https://api.github.com/users/lyft/received_events","type":"Organization","site_admin":false},"repo":{"id":45000048,"name":"amazon-kinesis-client","full_name":"lyft/amazon-kinesis-client","owner":{"login":"lyft","id":4269340,"avatar_url":"https://avatars.githubusercontent.com/u/4269340?v=3","gravatar_id":"","url":"https://api.github.com/users/lyft","html_url":"https://github.com/lyft","followers_url":"https://api.github.com/users/lyft/followers","following_url":"https://api.github.com/users/lyft/following{/other_user}","gists_url":"https://api.github.com/users/lyft/gists{/gist_id}","starred_url":"https://api.github.com/users/lyft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lyft/subscriptions","organizations_url":"https://api.github.com/users/lyft/orgs","repos_url":"https://api.github.com/users/lyft/repos","events_url":"https://api.github.com/users/lyft/events{/privacy}","received_events_url":"https://api.github.com/users/lyft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lyft/amazon-kinesis-client","description":"Client library for Amazon Kinesis","fork":true,"url":"https://api.github.com/repos/lyft/amazon-kinesis-client","forks_url":"https://api.github.com/repos/lyft/amazon-kinesis-client/forks","keys_url":"https://api.github.com/repos/lyft/amazon-kinesis-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lyft/amazon-kinesis-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lyft/amazon-kinesis-client/teams","hooks_url":"https://api.github.com/repos/lyft/amazon-kinesis-client/hooks","issue_events_url":"https://api.github.com/repos/lyft/amazon-kinesis-client/issues/events{/number}","events_url":"https://api.github.com/repos/lyft/amazon-kinesis-client/events","assignees_url":"https://api.github.com/repos/lyft/amazon-kinesis-client/assignees{/user}","branches_url":"https://api.github.com/repos/lyft/amazon-kinesis-client/branches{/branch}","tags_url":"https://api.github.com/repos/lyft/amazon-kinesis-client/tags","blobs_url":"https://api.github.com/repos/lyft/amazon-kinesis-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lyft/amazon-kinesis-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lyft/amazon-kinesis-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/lyft/amazon-kinesis-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lyft/amazon-kinesis-client/statuses/{sha}","languages_url":"https://api.github.com/repos/lyft/amazon-kinesis-client/languages","stargazers_url":"https://api.github.com/repos/lyft/amazon-kinesis-client/stargazers","contributors_url":"https://api.github.com/repos/lyft/amazon-kinesis-client/contributors","subscribers_url":"https://api.github.com/repos/lyft/amazon-kinesis-client/subscribers","subscription_url":"https://api.github.com/repos/lyft/amazon-kinesis-client/subscription","commits_url":"https://api.github.com/repos/lyft/amazon-kinesis-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/lyft/amazon-kinesis-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/lyft/amazon-kinesis-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/lyft/amazon-kinesis-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/lyft/amazon-kinesis-client/contents/{+path}","compare_url":"https://api.github.com/repos/lyft/amazon-kinesis-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lyft/amazon-kinesis-client/merges","archive_url":"https://api.github.com/repos/lyft/amazon-kinesis-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lyft/amazon-kinesis-client/downloads","issues_url":"https://api.github.com/repos/lyft/amazon-kinesis-client/issues{/number}","pulls_url":"https://api.github.com/repos/lyft/amazon-kinesis-client/pulls{/number}","milestones_url":"https://api.github.com/repos/lyft/amazon-kinesis-client/milestones{/number}","notifications_url":"https://api.github.com/repos/lyft/amazon-kinesis-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lyft/amazon-kinesis-client/labels{/name}","releases_url":"https://api.github.com/repos/lyft/amazon-kinesis-client/releases{/id}","created_at":"2015-10-26T22:00:49Z","updated_at":"2015-10-26T22:00:50Z","pushed_at":"2015-10-26T22:16:30Z","git_url":"git://github.com/lyft/amazon-kinesis-client.git","ssh_url":"git@github.com:lyft/amazon-kinesis-client.git","clone_url":"https://github.com/lyft/amazon-kinesis-client.git","svn_url":"https://github.com/lyft/amazon-kinesis-client","homepage":null,"size":325,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"lyft:lyft-v1.2.1","ref":"lyft-v1.2.1","sha":"0fc90ff7878a19016c2663afdf3b78f007f63d81","user":{"login":"lyft","id":4269340,"avatar_url":"https://avatars.githubusercontent.com/u/4269340?v=3","gravatar_id":"","url":"https://api.github.com/users/lyft","html_url":"https://github.com/lyft","followers_url":"https://api.github.com/users/lyft/followers","following_url":"https://api.github.com/users/lyft/following{/other_user}","gists_url":"https://api.github.com/users/lyft/gists{/gist_id}","starred_url":"https://api.github.com/users/lyft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lyft/subscriptions","organizations_url":"https://api.github.com/users/lyft/orgs","repos_url":"https://api.github.com/users/lyft/repos","events_url":"https://api.github.com/users/lyft/events{/privacy}","received_events_url":"https://api.github.com/users/lyft/received_events","type":"Organization","site_admin":false},"repo":{"id":45000048,"name":"amazon-kinesis-client","full_name":"lyft/amazon-kinesis-client","owner":{"login":"lyft","id":4269340,"avatar_url":"https://avatars.githubusercontent.com/u/4269340?v=3","gravatar_id":"","url":"https://api.github.com/users/lyft","html_url":"https://github.com/lyft","followers_url":"https://api.github.com/users/lyft/followers","following_url":"https://api.github.com/users/lyft/following{/other_user}","gists_url":"https://api.github.com/users/lyft/gists{/gist_id}","starred_url":"https://api.github.com/users/lyft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lyft/subscriptions","organizations_url":"https://api.github.com/users/lyft/orgs","repos_url":"https://api.github.com/users/lyft/repos","events_url":"https://api.github.com/users/lyft/events{/privacy}","received_events_url":"https://api.github.com/users/lyft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lyft/amazon-kinesis-client","description":"Client library for Amazon Kinesis","fork":true,"url":"https://api.github.com/repos/lyft/amazon-kinesis-client","forks_url":"https://api.github.com/repos/lyft/amazon-kinesis-client/forks","keys_url":"https://api.github.com/repos/lyft/amazon-kinesis-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lyft/amazon-kinesis-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lyft/amazon-kinesis-client/teams","hooks_url":"https://api.github.com/repos/lyft/amazon-kinesis-client/hooks","issue_events_url":"https://api.github.com/repos/lyft/amazon-kinesis-client/issues/events{/number}","events_url":"https://api.github.com/repos/lyft/amazon-kinesis-client/events","assignees_url":"https://api.github.com/repos/lyft/amazon-kinesis-client/assignees{/user}","branches_url":"https://api.github.com/repos/lyft/amazon-kinesis-client/branches{/branch}","tags_url":"https://api.github.com/repos/lyft/amazon-kinesis-client/tags","blobs_url":"https://api.github.com/repos/lyft/amazon-kinesis-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lyft/amazon-kinesis-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lyft/amazon-kinesis-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/lyft/amazon-kinesis-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lyft/amazon-kinesis-client/statuses/{sha}","languages_url":"https://api.github.com/repos/lyft/amazon-kinesis-client/languages","stargazers_url":"https://api.github.com/repos/lyft/amazon-kinesis-client/stargazers","contributors_url":"https://api.github.com/repos/lyft/amazon-kinesis-client/contributors","subscribers_url":"https://api.github.com/repos/lyft/amazon-kinesis-client/subscribers","subscription_url":"https://api.github.com/repos/lyft/amazon-kinesis-client/subscription","commits_url":"https://api.github.com/repos/lyft/amazon-kinesis-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/lyft/amazon-kinesis-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/lyft/amazon-kinesis-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/lyft/amazon-kinesis-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/lyft/amazon-kinesis-client/contents/{+path}","compare_url":"https://api.github.com/repos/lyft/amazon-kinesis-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lyft/amazon-kinesis-client/merges","archive_url":"https://api.github.com/repos/lyft/amazon-kinesis-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lyft/amazon-kinesis-client/downloads","issues_url":"https://api.github.com/repos/lyft/amazon-kinesis-client/issues{/number}","pulls_url":"https://api.github.com/repos/lyft/amazon-kinesis-client/pulls{/number}","milestones_url":"https://api.github.com/repos/lyft/amazon-kinesis-client/milestones{/number}","notifications_url":"https://api.github.com/repos/lyft/amazon-kinesis-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lyft/amazon-kinesis-client/labels{/name}","releases_url":"https://api.github.com/repos/lyft/amazon-kinesis-client/releases{/id}","created_at":"2015-10-26T22:00:49Z","updated_at":"2015-10-26T22:00:50Z","pushed_at":"2015-10-26T22:16:30Z","git_url":"git://github.com/lyft/amazon-kinesis-client.git","ssh_url":"git@github.com:lyft/amazon-kinesis-client.git","clone_url":"https://github.com/lyft/amazon-kinesis-client.git","svn_url":"https://github.com/lyft/amazon-kinesis-client","homepage":null,"size":325,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lyft/amazon-kinesis-client/pulls/1"},"html":{"href":"https://github.com/lyft/amazon-kinesis-client/pull/1"},"issue":{"href":"https://api.github.com/repos/lyft/amazon-kinesis-client/issues/1"},"comments":{"href":"https://api.github.com/repos/lyft/amazon-kinesis-client/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/lyft/amazon-kinesis-client/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/lyft/amazon-kinesis-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lyft/amazon-kinesis-client/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/lyft/amazon-kinesis-client/statuses/beecda4ff839771963062c337b6c29c08b07c281"}}}}