{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/28095470","id":28095470,"diff_hunk":"@@ -122,7 +78,54 @@ func LaunchNetTestPodPerNode(nodes *api.NodeList, name string, c *client.Client,\n }\n \n var _ = Describe(\"Networking\", func() {\n-\t//var c *client.Client\n+\n+\tvar svcname = \"nettest\"\n+\tvar c *client.Client = nil\n+\n+\tBeforeEach(func() {\n+\t\t//Assert basic external connectivity.\n+\t\t//Since this is not really a test of kubernetes in any way, we\n+\t\t//leave it as a pre-test assertion, rather than a Ginko test.\n+\t\tBy(\"Executing a successfull http request from the external internet\")\n+\t\tresp, err := http.Get(\"http://google.com\")\n+\t\tif err != nil {\n+\t\t\tFailf(\"Unable to connect/talk to the internet: %v\", err)\n+\t\t}\n+\t\tif resp.StatusCode != http.StatusOK {\n+\t\t\tFailf(\"Unexpected error code, expected 200, got, %v (%v)\", resp.StatusCode, resp)\n+\t\t}\n+\n+\t\tBy(\"Building a namespace api object\")\n+\t\tvar ns = svcname + \"-\" + randomSuffix()\n+\n+\t\tnamespaceObj = &api.Namespace{\n+\t\t\tObjectMeta: api.ObjectMeta{\n+\t\t\t\tName:      ns,\n+\t\t\t\tNamespace: \"\",\n+\t\t\t},\n+\t\t\tStatus: api.NamespaceStatus{},\n+\t\t}\n+\n+\t\tBy(\"Creating a kubernetes client\")\n+\t\tc, err = loadClient()\n+\t\tExpect(err).NotTo(HaveOccurred())\n+\n+\t\tBy(\"Creating a namespace for this test suite\")\n+\t\t_, err = c.Namespaces().Create(namespaceObj)\n+\t\tExpect(err).NotTo(HaveOccurred())\n+\t\tif err != nil {","path":"test/e2e/networking.go","position":102,"original_position":102,"commit_id":"024415f709f261d463f10af68cf3b2d393d40983","original_commit_id":"525064a62b0cee73cd10d24977752794df755e03","user":{"login":"jayunit100","id":826111,"avatar_url":"https://avatars.githubusercontent.com/u/826111?v=3","gravatar_id":"","url":"https://api.github.com/users/jayunit100","html_url":"https://github.com/jayunit100","followers_url":"https://api.github.com/users/jayunit100/followers","following_url":"https://api.github.com/users/jayunit100/following{/other_user}","gists_url":"https://api.github.com/users/jayunit100/gists{/gist_id}","starred_url":"https://api.github.com/users/jayunit100/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jayunit100/subscriptions","organizations_url":"https://api.github.com/users/jayunit100/orgs","repos_url":"https://api.github.com/users/jayunit100/repos","events_url":"https://api.github.com/users/jayunit100/events{/privacy}","received_events_url":"https://api.github.com/users/jayunit100/received_events","type":"User","site_admin":false},"body":"seems to be no good way to reuse err w/o shadowing cli ... :( not sure what the right way to reuse error variable is.  decalring a new one.","created_at":"2015-04-09T19:43:03Z","updated_at":"2015-04-09T19:43:03Z","html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/6643#discussion_r28095470","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/6643","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/28095470"},"html":{"href":"https://github.com/GoogleCloudPlatform/kubernetes/pull/6643#discussion_r28095470"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/6643"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/6643","id":32984804,"html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/6643","diff_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/6643.diff","patch_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/6643.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/6643","number":6643,"state":"open","locked":false,"title":"E2E : Networking.go Implement BeforeEach/AfterEach, and unique namespace...","user":{"login":"jayunit100","id":826111,"avatar_url":"https://avatars.githubusercontent.com/u/826111?v=3","gravatar_id":"","url":"https://api.github.com/users/jayunit100","html_url":"https://github.com/jayunit100","followers_url":"https://api.github.com/users/jayunit100/followers","following_url":"https://api.github.com/users/jayunit100/following{/other_user}","gists_url":"https://api.github.com/users/jayunit100/gists{/gist_id}","starred_url":"https://api.github.com/users/jayunit100/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jayunit100/subscriptions","organizations_url":"https://api.github.com/users/jayunit100/orgs","repos_url":"https://api.github.com/users/jayunit100/repos","events_url":"https://api.github.com/users/jayunit100/events{/privacy}","received_events_url":"https://api.github.com/users/jayunit100/received_events","type":"User","site_admin":false},"body":"Follow up to #6600 , fixes a minor issue created in #6642 and is a better model to follow in the general cleanup we're doing for #6554 ","created_at":"2015-04-09T18:51:59Z","updated_at":"2015-04-09T19:43:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"84ce0bf06bfb6876170557516170b5aa02fad9cd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/6643/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/6643/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/6643/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/024415f709f261d463f10af68cf3b2d393d40983","head":{"label":"jayunit100:networking-ns2","ref":"networking-ns2","sha":"024415f709f261d463f10af68cf3b2d393d40983","user":{"login":"jayunit100","id":826111,"avatar_url":"https://avatars.githubusercontent.com/u/826111?v=3","gravatar_id":"","url":"https://api.github.com/users/jayunit100","html_url":"https://github.com/jayunit100","followers_url":"https://api.github.com/users/jayunit100/followers","following_url":"https://api.github.com/users/jayunit100/following{/other_user}","gists_url":"https://api.github.com/users/jayunit100/gists{/gist_id}","starred_url":"https://api.github.com/users/jayunit100/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jayunit100/subscriptions","organizations_url":"https://api.github.com/users/jayunit100/orgs","repos_url":"https://api.github.com/users/jayunit100/repos","events_url":"https://api.github.com/users/jayunit100/events{/privacy}","received_events_url":"https://api.github.com/users/jayunit100/received_events","type":"User","site_admin":false},"repo":{"id":28862683,"name":"kubernetes","full_name":"jayunit100/kubernetes","owner":{"login":"jayunit100","id":826111,"avatar_url":"https://avatars.githubusercontent.com/u/826111?v=3","gravatar_id":"","url":"https://api.github.com/users/jayunit100","html_url":"https://github.com/jayunit100","followers_url":"https://api.github.com/users/jayunit100/followers","following_url":"https://api.github.com/users/jayunit100/following{/other_user}","gists_url":"https://api.github.com/users/jayunit100/gists{/gist_id}","starred_url":"https://api.github.com/users/jayunit100/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jayunit100/subscriptions","organizations_url":"https://api.github.com/users/jayunit100/orgs","repos_url":"https://api.github.com/users/jayunit100/repos","events_url":"https://api.github.com/users/jayunit100/events{/privacy}","received_events_url":"https://api.github.com/users/jayunit100/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jayunit100/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/jayunit100/kubernetes","forks_url":"https://api.github.com/repos/jayunit100/kubernetes/forks","keys_url":"https://api.github.com/repos/jayunit100/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jayunit100/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jayunit100/kubernetes/teams","hooks_url":"https://api.github.com/repos/jayunit100/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/jayunit100/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/jayunit100/kubernetes/events","assignees_url":"https://api.github.com/repos/jayunit100/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/jayunit100/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/jayunit100/kubernetes/tags","blobs_url":"https://api.github.com/repos/jayunit100/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jayunit100/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jayunit100/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/jayunit100/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jayunit100/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/jayunit100/kubernetes/languages","stargazers_url":"https://api.github.com/repos/jayunit100/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/jayunit100/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/jayunit100/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/jayunit100/kubernetes/subscription","commits_url":"https://api.github.com/repos/jayunit100/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/jayunit100/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/jayunit100/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/jayunit100/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/jayunit100/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/jayunit100/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jayunit100/kubernetes/merges","archive_url":"https://api.github.com/repos/jayunit100/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jayunit100/kubernetes/downloads","issues_url":"https://api.github.com/repos/jayunit100/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/jayunit100/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/jayunit100/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/jayunit100/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jayunit100/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/jayunit100/kubernetes/releases{/id}","created_at":"2015-01-06T12:36:29Z","updated_at":"2015-04-03T20:25:30Z","pushed_at":"2015-04-09T19:04:31Z","git_url":"git://github.com/jayunit100/kubernetes.git","ssh_url":"git@github.com:jayunit100/kubernetes.git","clone_url":"https://github.com/jayunit100/kubernetes.git","svn_url":"https://github.com/jayunit100/kubernetes","homepage":null,"size":42039,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"2215a645673e63529bc1f3a8b32d039a61b7ab77","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"GoogleCloudPlatform/kubernetes","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/releases{/id}","created_at":"2014-06-06T22:56:04Z","updated_at":"2015-04-09T19:28:25Z","pushed_at":"2015-04-09T19:20:55Z","git_url":"git://github.com/GoogleCloudPlatform/kubernetes.git","ssh_url":"git@github.com:GoogleCloudPlatform/kubernetes.git","clone_url":"https://github.com/GoogleCloudPlatform/kubernetes.git","svn_url":"https://github.com/GoogleCloudPlatform/kubernetes","homepage":"http://kubernetes.io","size":136485,"stargazers_count":7018,"watchers_count":7018,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1367,"mirror_url":null,"open_issues_count":878,"forks":1367,"open_issues":878,"watchers":7018,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/6643"},"html":{"href":"https://github.com/GoogleCloudPlatform/kubernetes/pull/6643"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/6643"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/6643/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/6643/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/6643/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/024415f709f261d463f10af68cf3b2d393d40983"}}}}