{"action":"created","comment":{"url":"https://api.github.com/repos/aspnet/Configuration/pulls/comments/27043757","id":27043757,"diff_hunk":"@@ -1,12 +1,37 @@\n // Copyright (c) Microsoft Open Technologies, Inc. All rights reserved.\n // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.\n \n+using System;\n+using System.IO;\n+\n namespace Microsoft.Framework.ConfigurationModel\n {\n     public static class XmlConfigurationExtension\n     {\n         public static IConfigurationSourceRoot AddXmlFile(this IConfigurationSourceRoot configuration, string path)","path":"src/Microsoft.Framework.ConfigurationModel.Xml/XmlConfigurationExtension.cs","position":11,"original_position":11,"commit_id":"e00f96fd2938b94b3ff2698a46f04e9eb51b2ded","original_commit_id":"e00f96fd2938b94b3ff2698a46f04e9eb51b2ded","user":{"login":"dougbu","id":6431421,"avatar_url":"https://avatars.githubusercontent.com/u/6431421?v=3","gravatar_id":"","url":"https://api.github.com/users/dougbu","html_url":"https://github.com/dougbu","followers_url":"https://api.github.com/users/dougbu/followers","following_url":"https://api.github.com/users/dougbu/following{/other_user}","gists_url":"https://api.github.com/users/dougbu/gists{/gist_id}","starred_url":"https://api.github.com/users/dougbu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dougbu/subscriptions","organizations_url":"https://api.github.com/users/dougbu/orgs","repos_url":"https://api.github.com/users/dougbu/repos","events_url":"https://api.github.com/users/dougbu/events{/privacy}","received_events_url":"https://api.github.com/users/dougbu/received_events","type":"User","site_admin":false},"body":"`AddJsonFile()` comments apply here","created_at":"2015-03-24T16:12:05Z","updated_at":"2015-03-24T16:12:05Z","html_url":"https://github.com/aspnet/Configuration/pull/160#discussion_r27043757","pull_request_url":"https://api.github.com/repos/aspnet/Configuration/pulls/160","_links":{"self":{"href":"https://api.github.com/repos/aspnet/Configuration/pulls/comments/27043757"},"html":{"href":"https://github.com/aspnet/Configuration/pull/160#discussion_r27043757"},"pull_request":{"href":"https://api.github.com/repos/aspnet/Configuration/pulls/160"}}},"pull_request":{"url":"https://api.github.com/repos/aspnet/Configuration/pulls/160","id":31575494,"html_url":"https://github.com/aspnet/Configuration/pull/160","diff_url":"https://github.com/aspnet/Configuration/pull/160.diff","patch_url":"https://github.com/aspnet/Configuration/pull/160.patch","issue_url":"https://api.github.com/repos/aspnet/Configuration/issues/160","number":160,"state":"open","locked":false,"title":"Draft: Add BasePath to IConfigurationSourceRoot","user":{"login":"troydai","id":1329240,"avatar_url":"https://avatars.githubusercontent.com/u/1329240?v=3","gravatar_id":"","url":"https://api.github.com/users/troydai","html_url":"https://github.com/troydai","followers_url":"https://api.github.com/users/troydai/followers","following_url":"https://api.github.com/users/troydai/following{/other_user}","gists_url":"https://api.github.com/users/troydai/gists{/gist_id}","starred_url":"https://api.github.com/users/troydai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/troydai/subscriptions","organizations_url":"https://api.github.com/users/troydai/orgs","repos_url":"https://api.github.com/users/troydai/repos","events_url":"https://api.github.com/users/troydai/events{/privacy}","received_events_url":"https://api.github.com/users/troydai/received_events","type":"User","site_admin":false},"body":"This is a draft implementation of the idea in #159. \r\n\r\nA few concerns related to this versions:\r\n1) It immediately breaks all current `Configuration` usage. Consumer codes needs to handle the `BasePath` themselves.\r\n2) However, in those cases a file based configuration is not needed, the requirement of a `basePath` is odd.\r\n\r\nPotential extension:\r\nWe can provide helper class for retrieving `ApplicationBaseDirectory` path.","created_at":"2015-03-19T23:13:23Z","updated_at":"2015-03-24T16:12:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"881fcc8dec84cd2badd8b404f9e77fb6ba9a2882","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/aspnet/Configuration/pulls/160/commits","review_comments_url":"https://api.github.com/repos/aspnet/Configuration/pulls/160/comments","review_comment_url":"https://api.github.com/repos/aspnet/Configuration/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aspnet/Configuration/issues/160/comments","statuses_url":"https://api.github.com/repos/aspnet/Configuration/statuses/e00f96fd2938b94b3ff2698a46f04e9eb51b2ded","head":{"label":"aspnet:trdai/issue159","ref":"trdai/issue159","sha":"e00f96fd2938b94b3ff2698a46f04e9eb51b2ded","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":16329342,"name":"Configuration","full_name":"aspnet/Configuration","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/Configuration","description":"Interfaces and providers for accessing simple config files.","fork":false,"url":"https://api.github.com/repos/aspnet/Configuration","forks_url":"https://api.github.com/repos/aspnet/Configuration/forks","keys_url":"https://api.github.com/repos/aspnet/Configuration/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/Configuration/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/Configuration/teams","hooks_url":"https://api.github.com/repos/aspnet/Configuration/hooks","issue_events_url":"https://api.github.com/repos/aspnet/Configuration/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/Configuration/events","assignees_url":"https://api.github.com/repos/aspnet/Configuration/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/Configuration/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/Configuration/tags","blobs_url":"https://api.github.com/repos/aspnet/Configuration/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/Configuration/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/Configuration/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/Configuration/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/Configuration/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/Configuration/languages","stargazers_url":"https://api.github.com/repos/aspnet/Configuration/stargazers","contributors_url":"https://api.github.com/repos/aspnet/Configuration/contributors","subscribers_url":"https://api.github.com/repos/aspnet/Configuration/subscribers","subscription_url":"https://api.github.com/repos/aspnet/Configuration/subscription","commits_url":"https://api.github.com/repos/aspnet/Configuration/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/Configuration/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/Configuration/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/Configuration/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/Configuration/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/Configuration/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/Configuration/merges","archive_url":"https://api.github.com/repos/aspnet/Configuration/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/Configuration/downloads","issues_url":"https://api.github.com/repos/aspnet/Configuration/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/Configuration/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/Configuration/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/Configuration/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/Configuration/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/Configuration/releases{/id}","created_at":"2014-01-28T23:11:33Z","updated_at":"2015-03-22T11:49:44Z","pushed_at":"2015-03-24T10:51:45Z","git_url":"git://github.com/aspnet/Configuration.git","ssh_url":"git@github.com:aspnet/Configuration.git","clone_url":"https://github.com/aspnet/Configuration.git","svn_url":"https://github.com/aspnet/Configuration","homepage":"","size":2248,"stargazers_count":62,"watchers_count":62,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":31,"mirror_url":null,"open_issues_count":21,"forks":31,"open_issues":21,"watchers":62,"default_branch":"dev"}},"base":{"label":"aspnet:dev","ref":"dev","sha":"e39d2d2d7d3ffff1b26f89fcf48021a9b703ce74","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":16329342,"name":"Configuration","full_name":"aspnet/Configuration","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/Configuration","description":"Interfaces and providers for accessing simple config files.","fork":false,"url":"https://api.github.com/repos/aspnet/Configuration","forks_url":"https://api.github.com/repos/aspnet/Configuration/forks","keys_url":"https://api.github.com/repos/aspnet/Configuration/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/Configuration/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/Configuration/teams","hooks_url":"https://api.github.com/repos/aspnet/Configuration/hooks","issue_events_url":"https://api.github.com/repos/aspnet/Configuration/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/Configuration/events","assignees_url":"https://api.github.com/repos/aspnet/Configuration/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/Configuration/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/Configuration/tags","blobs_url":"https://api.github.com/repos/aspnet/Configuration/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/Configuration/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/Configuration/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/Configuration/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/Configuration/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/Configuration/languages","stargazers_url":"https://api.github.com/repos/aspnet/Configuration/stargazers","contributors_url":"https://api.github.com/repos/aspnet/Configuration/contributors","subscribers_url":"https://api.github.com/repos/aspnet/Configuration/subscribers","subscription_url":"https://api.github.com/repos/aspnet/Configuration/subscription","commits_url":"https://api.github.com/repos/aspnet/Configuration/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/Configuration/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/Configuration/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/Configuration/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/Configuration/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/Configuration/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/Configuration/merges","archive_url":"https://api.github.com/repos/aspnet/Configuration/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/Configuration/downloads","issues_url":"https://api.github.com/repos/aspnet/Configuration/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/Configuration/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/Configuration/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/Configuration/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/Configuration/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/Configuration/releases{/id}","created_at":"2014-01-28T23:11:33Z","updated_at":"2015-03-22T11:49:44Z","pushed_at":"2015-03-24T10:51:45Z","git_url":"git://github.com/aspnet/Configuration.git","ssh_url":"git@github.com:aspnet/Configuration.git","clone_url":"https://github.com/aspnet/Configuration.git","svn_url":"https://github.com/aspnet/Configuration","homepage":"","size":2248,"stargazers_count":62,"watchers_count":62,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":31,"mirror_url":null,"open_issues_count":21,"forks":31,"open_issues":21,"watchers":62,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/aspnet/Configuration/pulls/160"},"html":{"href":"https://github.com/aspnet/Configuration/pull/160"},"issue":{"href":"https://api.github.com/repos/aspnet/Configuration/issues/160"},"comments":{"href":"https://api.github.com/repos/aspnet/Configuration/issues/160/comments"},"review_comments":{"href":"https://api.github.com/repos/aspnet/Configuration/pulls/160/comments"},"review_comment":{"href":"https://api.github.com/repos/aspnet/Configuration/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aspnet/Configuration/pulls/160/commits"},"statuses":{"href":"https://api.github.com/repos/aspnet/Configuration/statuses/e00f96fd2938b94b3ff2698a46f04e9eb51b2ded"}}}}