{"action":"created","issue":{"url":"https://api.github.com/repos/OoliteProject/oolite/issues/146","labels_url":"https://api.github.com/repos/OoliteProject/oolite/issues/146/labels{/name}","comments_url":"https://api.github.com/repos/OoliteProject/oolite/issues/146/comments","events_url":"https://api.github.com/repos/OoliteProject/oolite/issues/146/events","html_url":"https://github.com/OoliteProject/oolite/pull/146","id":78416991,"number":146,"title":"Tumbling ships","user":{"login":"kanthoney","id":5890866,"avatar_url":"https://avatars.githubusercontent.com/u/5890866?v=3","gravatar_id":"","url":"https://api.github.com/users/kanthoney","html_url":"https://github.com/kanthoney","followers_url":"https://api.github.com/users/kanthoney/followers","following_url":"https://api.github.com/users/kanthoney/following{/other_user}","gists_url":"https://api.github.com/users/kanthoney/gists{/gist_id}","starred_url":"https://api.github.com/users/kanthoney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kanthoney/subscriptions","organizations_url":"https://api.github.com/users/kanthoney/orgs","repos_url":"https://api.github.com/users/kanthoney/repos","events_url":"https://api.github.com/users/kanthoney/events{/privacy}","received_events_url":"https://api.github.com/users/kanthoney/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-05-20T07:45:08Z","updated_at":"2015-05-20T17:12:08Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/OoliteProject/oolite/pulls/146","html_url":"https://github.com/OoliteProject/oolite/pull/146","diff_url":"https://github.com/OoliteProject/oolite/pull/146.diff","patch_url":"https://github.com/OoliteProject/oolite/pull/146.patch"},"body":"(I was going to leave this until post 1.82 release, but as it brought up a graphical glitch - and a fix for said glitch - I thought I'd let you look at it before release.)\r\n\r\nI've often thought that the way the spinning ships in Oolite rotated was rather boring compared to the original Elite, where they tumbled in a much more interesting way.  So I thought I'd try and reproduce the Elite style rotation.\r\n\r\nAs it happened, this turned out to be an excellent stress test for the graphics engine, and it threw up a problem (see https://github.com/OoliteProject/oolite/commit/643566280a5f47c7455660ab2bc400f06d59438e).  After staring at this for a while, it looked to me as though any face which was exactly perpendicular to the x-axis wasn't being lit properly - it was either fully lit or fully unlit.  I think I've fixed this in https://github.com/OoliteProject/oolite/commit/e0cf14146b132a8b672b6501dd844d900f43cd7b, but there may be knock-on effects."},"comment":{"url":"https://api.github.com/repos/OoliteProject/oolite/issues/comments/103964571","html_url":"https://github.com/OoliteProject/oolite/pull/146#issuecomment-103964571","issue_url":"https://api.github.com/repos/OoliteProject/oolite/issues/146","id":103964571,"user":{"login":"AnotherCommander","id":623526,"avatar_url":"https://avatars.githubusercontent.com/u/623526?v=3","gravatar_id":"","url":"https://api.github.com/users/AnotherCommander","html_url":"https://github.com/AnotherCommander","followers_url":"https://api.github.com/users/AnotherCommander/followers","following_url":"https://api.github.com/users/AnotherCommander/following{/other_user}","gists_url":"https://api.github.com/users/AnotherCommander/gists{/gist_id}","starred_url":"https://api.github.com/users/AnotherCommander/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnotherCommander/subscriptions","organizations_url":"https://api.github.com/users/AnotherCommander/orgs","repos_url":"https://api.github.com/users/AnotherCommander/repos","events_url":"https://api.github.com/users/AnotherCommander/events{/privacy}","received_events_url":"https://api.github.com/users/AnotherCommander/received_events","type":"User","site_admin":false},"created_at":"2015-05-20T17:12:08Z","updated_at":"2015-05-20T17:12:08Z","body":"I think I can still see the problem targeted by commit e0cf141. It is especially evident at the thruster area of the Fer-de-Lance in the ship library screen."}}