{"action":"opened","issue":{"url":"https://api.github.com/repos/m-lab/ndt/issues/25","labels_url":"https://api.github.com/repos/m-lab/ndt/issues/25/labels{/name}","comments_url":"https://api.github.com/repos/m-lab/ndt/issues/25/comments","events_url":"https://api.github.com/repos/m-lab/ndt/issues/25/events","html_url":"https://github.com/m-lab/ndt/issues/25","id":120880598,"number":25,"title":"Audit of fixed-length strings in NDT","user":{"login":"pboothe","id":143798,"avatar_url":"https://avatars.githubusercontent.com/u/143798?v=3","gravatar_id":"","url":"https://api.github.com/users/pboothe","html_url":"https://github.com/pboothe","followers_url":"https://api.github.com/users/pboothe/followers","following_url":"https://api.github.com/users/pboothe/following{/other_user}","gists_url":"https://api.github.com/users/pboothe/gists{/gist_id}","starred_url":"https://api.github.com/users/pboothe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pboothe/subscriptions","organizations_url":"https://api.github.com/users/pboothe/orgs","repos_url":"https://api.github.com/users/pboothe/repos","events_url":"https://api.github.com/users/pboothe/events{/privacy}","received_events_url":"https://api.github.com/users/pboothe/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2015-12-07T22:14:23Z","updated_at":"2015-12-07T22:14:23Z","closed_at":null,"body":"NDT has too many fixed-length strings, and this has been biting us for a long time. `snprintf()` doesn't actually promise that the resulting string ends up null-terminated, which leaves the door open for all sorts of crashing bugs. We should audit the usage of all strings in the `meta` global struct and `writeMeta()` in `web100srv.c`"}}