{"action":"created","issue":{"url":"https://api.github.com/repos/zikula/core/issues/2648","labels_url":"https://api.github.com/repos/zikula/core/issues/2648/labels{/name}","comments_url":"https://api.github.com/repos/zikula/core/issues/2648/comments","events_url":"https://api.github.com/repos/zikula/core/issues/2648/events","html_url":"https://github.com/zikula/core/pull/2648","id":118280623,"number":2648,"title":"AdminModule AdminInterfaceController - twig","user":{"login":"Kaik","id":966910,"avatar_url":"https://avatars.githubusercontent.com/u/966910?v=3","gravatar_id":"","url":"https://api.github.com/users/Kaik","html_url":"https://github.com/Kaik","followers_url":"https://api.github.com/users/Kaik/followers","following_url":"https://api.github.com/users/Kaik/following{/other_user}","gists_url":"https://api.github.com/users/Kaik/gists{/gist_id}","starred_url":"https://api.github.com/users/Kaik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kaik/subscriptions","organizations_url":"https://api.github.com/users/Kaik/orgs","repos_url":"https://api.github.com/users/Kaik/repos","events_url":"https://api.github.com/users/Kaik/events{/privacy}","received_events_url":"https://api.github.com/users/Kaik/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/zikula/core/labels/Feature","name":"Feature","color":"02e10c"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/zikula/core/milestones/19","html_url":"https://github.com/zikula/core/milestones/1.4.2","labels_url":"https://api.github.com/repos/zikula/core/milestones/19/labels","id":1391003,"number":19,"title":"1.4.2","description":"second service release for 1.4.x series.","creator":{"login":"cmfcmf","id":2145092,"avatar_url":"https://avatars.githubusercontent.com/u/2145092?v=3","gravatar_id":"","url":"https://api.github.com/users/cmfcmf","html_url":"https://github.com/cmfcmf","followers_url":"https://api.github.com/users/cmfcmf/followers","following_url":"https://api.github.com/users/cmfcmf/following{/other_user}","gists_url":"https://api.github.com/users/cmfcmf/gists{/gist_id}","starred_url":"https://api.github.com/users/cmfcmf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmfcmf/subscriptions","organizations_url":"https://api.github.com/users/cmfcmf/orgs","repos_url":"https://api.github.com/users/cmfcmf/repos","events_url":"https://api.github.com/users/cmfcmf/events{/privacy}","received_events_url":"https://api.github.com/users/cmfcmf/received_events","type":"User","site_admin":false},"open_issues":31,"closed_issues":0,"state":"open","created_at":"2015-11-03T10:48:29Z","updated_at":"2015-11-22T21:45:42Z","due_on":"2016-03-20T04:00:00Z","closed_at":null},"comments":3,"created_at":"2015-11-22T18:40:57Z","updated_at":"2015-11-22T21:51:39Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/zikula/core/pulls/2648","html_url":"https://github.com/zikula/core/pull/2648","diff_url":"https://github.com/zikula/core/pull/2648.diff","patch_url":"https://github.com/zikula/core/pull/2648.patch"},"body":"| Q                 | A\r\n| ----------------- | ---\r\n| Bug fix?          | no\r\n| New feature?      | yes\r\n| BC breaks?        | no*\r\n| Deprecations?     | no\r\n| Tests pass?       | no\r\n| Fixed tickets     | \r\n| Refs tickets      | #1753 \r\n| License           | MIT\r\n| Doc PR            | -\r\n| Changelog updated | [no]\r\n\r\nAdminInteraceController for new spec 2.0 modules using AbstractController and Twig.\r\n\r\nPlease take a look on it you can test it with this https://github.com/Kaik/core/tree/admin_settings_multilingual\r\n\r\nUsage\r\n\r\n```{{ render(controller('ZikulaAdminModule:AdminInterface:header')) }} ```\r\n\r\nThis is still not finished do not merge.\r\nTasks\r\n- [ ] Move security etc private functions somewhere?..\r\n- [ ] Split notices into separate functions\r\n- [ ] Move breadcrumbs to separate function\r\n- [ ] Find place for moduleheader and modulelinks Extensions? module ModuleInterfaceController?..\r\n- [ ] AdminTab's breadcrumb's etc css and js improvements\r\n- [ ] Improvements\r\n...?"},"comment":{"url":"https://api.github.com/repos/zikula/core/issues/comments/158805028","html_url":"https://github.com/zikula/core/pull/2648#issuecomment-158805028","issue_url":"https://api.github.com/repos/zikula/core/issues/2648","id":158805028,"user":{"login":"Kaik","id":966910,"avatar_url":"https://avatars.githubusercontent.com/u/966910?v=3","gravatar_id":"","url":"https://api.github.com/users/Kaik","html_url":"https://github.com/Kaik","followers_url":"https://api.github.com/users/Kaik/followers","following_url":"https://api.github.com/users/Kaik/following{/other_user}","gists_url":"https://api.github.com/users/Kaik/gists{/gist_id}","starred_url":"https://api.github.com/users/Kaik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kaik/subscriptions","organizations_url":"https://api.github.com/users/Kaik/orgs","repos_url":"https://api.github.com/users/Kaik/repos","events_url":"https://api.github.com/users/Kaik/events{/privacy}","received_events_url":"https://api.github.com/users/Kaik/received_events","type":"User","site_admin":false},"created_at":"2015-11-22T21:51:39Z","updated_at":"2015-11-22T21:51:39Z","body":"moduleheader and modulelinks function are not only for admin for general purpose, those functions should be moved to other place best place is extension used to be in themes https://github.com/zikula/core/blob/1.4/src/system/ThemeModule/Resources/views/moduleheader.tpl"}}