{"action":"created","comment":{"url":"https://api.github.com/repos/neovim/neovim/pulls/comments/31815273","id":31815273,"diff_hunk":"@@ -37,6 +37,50 @@ typedef struct {\n #endif\n \n \n+/// Process command string with 'shellxescape' (p_sxe) and 'shellxquote'\n+/// (p_sxq)","path":"src/nvim/os/shell.c","position":5,"original_position":5,"commit_id":"edc936ce6831c562dd925cfe155c6b5134ed1300","original_commit_id":"edc936ce6831c562dd925cfe155c6b5134ed1300","user":{"login":"justinmk","id":1359421,"avatar_url":"https://avatars.githubusercontent.com/u/1359421?v=3","gravatar_id":"","url":"https://api.github.com/users/justinmk","html_url":"https://github.com/justinmk","followers_url":"https://api.github.com/users/justinmk/followers","following_url":"https://api.github.com/users/justinmk/following{/other_user}","gists_url":"https://api.github.com/users/justinmk/gists{/gist_id}","starred_url":"https://api.github.com/users/justinmk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinmk/subscriptions","organizations_url":"https://api.github.com/users/justinmk/orgs","repos_url":"https://api.github.com/users/justinmk/repos","events_url":"https://api.github.com/users/justinmk/events{/privacy}","received_events_url":"https://api.github.com/users/justinmk/received_events","type":"User","site_admin":false},"body":"Should describe what happens if cmd is null. ","created_at":"2015-06-05T14:10:53Z","updated_at":"2015-06-05T14:10:53Z","html_url":"https://github.com/neovim/neovim/pull/2789#discussion_r31815273","pull_request_url":"https://api.github.com/repos/neovim/neovim/pulls/2789","_links":{"self":{"href":"https://api.github.com/repos/neovim/neovim/pulls/comments/31815273"},"html":{"href":"https://github.com/neovim/neovim/pull/2789#discussion_r31815273"},"pull_request":{"href":"https://api.github.com/repos/neovim/neovim/pulls/2789"}}},"pull_request":{"url":"https://api.github.com/repos/neovim/neovim/pulls/2789","id":36917802,"html_url":"https://github.com/neovim/neovim/pull/2789","diff_url":"https://github.com/neovim/neovim/pull/2789.diff","patch_url":"https://github.com/neovim/neovim/pull/2789.patch","issue_url":"https://api.github.com/repos/neovim/neovim/issues/2789","number":2789,"state":"open","locked":false,"title":"[RFC] Fix for #2773: 'sxe' and 'sxq' not respected in system() call","user":{"login":"brglng","id":1525226,"avatar_url":"https://avatars.githubusercontent.com/u/1525226?v=3","gravatar_id":"","url":"https://api.github.com/users/brglng","html_url":"https://github.com/brglng","followers_url":"https://api.github.com/users/brglng/followers","following_url":"https://api.github.com/users/brglng/following{/other_user}","gists_url":"https://api.github.com/users/brglng/gists{/gist_id}","starred_url":"https://api.github.com/users/brglng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brglng/subscriptions","organizations_url":"https://api.github.com/users/brglng/orgs","repos_url":"https://api.github.com/users/brglng/repos","events_url":"https://api.github.com/users/brglng/events{/privacy}","received_events_url":"https://api.github.com/users/brglng/received_events","type":"User","site_admin":false},"body":"Previously the 'shellxescape' and 'shellxquote' were only respected in the `!command` call. This PR adds support of 'shellxescape' and 'shellxquote' in the `system()` call. The unit test is added as `test/unit/os/shell_sxe_sxq_spec.lua`.","created_at":"2015-06-04T09:43:01Z","updated_at":"2015-06-05T14:10:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8bf85714d7d4538c604bbcbdcfb834958603794a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/neovim/neovim/pulls/2789/commits","review_comments_url":"https://api.github.com/repos/neovim/neovim/pulls/2789/comments","review_comment_url":"https://api.github.com/repos/neovim/neovim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/neovim/neovim/issues/2789/comments","statuses_url":"https://api.github.com/repos/neovim/neovim/statuses/edc936ce6831c562dd925cfe155c6b5134ed1300","head":{"label":"brglng:fix-sxe-sxq","ref":"fix-sxe-sxq","sha":"edc936ce6831c562dd925cfe155c6b5134ed1300","user":{"login":"brglng","id":1525226,"avatar_url":"https://avatars.githubusercontent.com/u/1525226?v=3","gravatar_id":"","url":"https://api.github.com/users/brglng","html_url":"https://github.com/brglng","followers_url":"https://api.github.com/users/brglng/followers","following_url":"https://api.github.com/users/brglng/following{/other_user}","gists_url":"https://api.github.com/users/brglng/gists{/gist_id}","starred_url":"https://api.github.com/users/brglng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brglng/subscriptions","organizations_url":"https://api.github.com/users/brglng/orgs","repos_url":"https://api.github.com/users/brglng/repos","events_url":"https://api.github.com/users/brglng/events{/privacy}","received_events_url":"https://api.github.com/users/brglng/received_events","type":"User","site_admin":false},"repo":{"id":36798801,"name":"neovim","full_name":"brglng/neovim","owner":{"login":"brglng","id":1525226,"avatar_url":"https://avatars.githubusercontent.com/u/1525226?v=3","gravatar_id":"","url":"https://api.github.com/users/brglng","html_url":"https://github.com/brglng","followers_url":"https://api.github.com/users/brglng/followers","following_url":"https://api.github.com/users/brglng/following{/other_user}","gists_url":"https://api.github.com/users/brglng/gists{/gist_id}","starred_url":"https://api.github.com/users/brglng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brglng/subscriptions","organizations_url":"https://api.github.com/users/brglng/orgs","repos_url":"https://api.github.com/users/brglng/repos","events_url":"https://api.github.com/users/brglng/events{/privacy}","received_events_url":"https://api.github.com/users/brglng/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brglng/neovim","description":"ambitious Vim-fork focused on extensibility and agility. Please consider helping sustain Neovim development! https://salt.bountysource.com/teams/neovim","fork":true,"url":"https://api.github.com/repos/brglng/neovim","forks_url":"https://api.github.com/repos/brglng/neovim/forks","keys_url":"https://api.github.com/repos/brglng/neovim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brglng/neovim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brglng/neovim/teams","hooks_url":"https://api.github.com/repos/brglng/neovim/hooks","issue_events_url":"https://api.github.com/repos/brglng/neovim/issues/events{/number}","events_url":"https://api.github.com/repos/brglng/neovim/events","assignees_url":"https://api.github.com/repos/brglng/neovim/assignees{/user}","branches_url":"https://api.github.com/repos/brglng/neovim/branches{/branch}","tags_url":"https://api.github.com/repos/brglng/neovim/tags","blobs_url":"https://api.github.com/repos/brglng/neovim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brglng/neovim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brglng/neovim/git/refs{/sha}","trees_url":"https://api.github.com/repos/brglng/neovim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brglng/neovim/statuses/{sha}","languages_url":"https://api.github.com/repos/brglng/neovim/languages","stargazers_url":"https://api.github.com/repos/brglng/neovim/stargazers","contributors_url":"https://api.github.com/repos/brglng/neovim/contributors","subscribers_url":"https://api.github.com/repos/brglng/neovim/subscribers","subscription_url":"https://api.github.com/repos/brglng/neovim/subscription","commits_url":"https://api.github.com/repos/brglng/neovim/commits{/sha}","git_commits_url":"https://api.github.com/repos/brglng/neovim/git/commits{/sha}","comments_url":"https://api.github.com/repos/brglng/neovim/comments{/number}","issue_comment_url":"https://api.github.com/repos/brglng/neovim/issues/comments{/number}","contents_url":"https://api.github.com/repos/brglng/neovim/contents/{+path}","compare_url":"https://api.github.com/repos/brglng/neovim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brglng/neovim/merges","archive_url":"https://api.github.com/repos/brglng/neovim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brglng/neovim/downloads","issues_url":"https://api.github.com/repos/brglng/neovim/issues{/number}","pulls_url":"https://api.github.com/repos/brglng/neovim/pulls{/number}","milestones_url":"https://api.github.com/repos/brglng/neovim/milestones{/number}","notifications_url":"https://api.github.com/repos/brglng/neovim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brglng/neovim/labels{/name}","releases_url":"https://api.github.com/repos/brglng/neovim/releases{/id}","created_at":"2015-06-03T11:16:08Z","updated_at":"2015-06-03T11:16:14Z","pushed_at":"2015-06-05T11:06:49Z","git_url":"git://github.com/brglng/neovim.git","ssh_url":"git@github.com:brglng/neovim.git","clone_url":"https://github.com/brglng/neovim.git","svn_url":"https://github.com/brglng/neovim","homepage":"http://neovim.io","size":30963,"stargazers_count":0,"watchers_count":0,"language":"VimL","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"neovim:master","ref":"master","sha":"27dc31597536e527f3d0cf01e67a88d31818b284","user":{"login":"neovim","id":6471485,"avatar_url":"https://avatars.githubusercontent.com/u/6471485?v=3","gravatar_id":"","url":"https://api.github.com/users/neovim","html_url":"https://github.com/neovim","followers_url":"https://api.github.com/users/neovim/followers","following_url":"https://api.github.com/users/neovim/following{/other_user}","gists_url":"https://api.github.com/users/neovim/gists{/gist_id}","starred_url":"https://api.github.com/users/neovim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neovim/subscriptions","organizations_url":"https://api.github.com/users/neovim/orgs","repos_url":"https://api.github.com/users/neovim/repos","events_url":"https://api.github.com/users/neovim/events{/privacy}","received_events_url":"https://api.github.com/users/neovim/received_events","type":"Organization","site_admin":false},"repo":{"id":16408992,"name":"neovim","full_name":"neovim/neovim","owner":{"login":"neovim","id":6471485,"avatar_url":"https://avatars.githubusercontent.com/u/6471485?v=3","gravatar_id":"","url":"https://api.github.com/users/neovim","html_url":"https://github.com/neovim","followers_url":"https://api.github.com/users/neovim/followers","following_url":"https://api.github.com/users/neovim/following{/other_user}","gists_url":"https://api.github.com/users/neovim/gists{/gist_id}","starred_url":"https://api.github.com/users/neovim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neovim/subscriptions","organizations_url":"https://api.github.com/users/neovim/orgs","repos_url":"https://api.github.com/users/neovim/repos","events_url":"https://api.github.com/users/neovim/events{/privacy}","received_events_url":"https://api.github.com/users/neovim/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neovim/neovim","description":"ambitious Vim-fork focused on extensibility and agility. Please consider helping sustain Neovim development! https://salt.bountysource.com/teams/neovim","fork":false,"url":"https://api.github.com/repos/neovim/neovim","forks_url":"https://api.github.com/repos/neovim/neovim/forks","keys_url":"https://api.github.com/repos/neovim/neovim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neovim/neovim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neovim/neovim/teams","hooks_url":"https://api.github.com/repos/neovim/neovim/hooks","issue_events_url":"https://api.github.com/repos/neovim/neovim/issues/events{/number}","events_url":"https://api.github.com/repos/neovim/neovim/events","assignees_url":"https://api.github.com/repos/neovim/neovim/assignees{/user}","branches_url":"https://api.github.com/repos/neovim/neovim/branches{/branch}","tags_url":"https://api.github.com/repos/neovim/neovim/tags","blobs_url":"https://api.github.com/repos/neovim/neovim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neovim/neovim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neovim/neovim/git/refs{/sha}","trees_url":"https://api.github.com/repos/neovim/neovim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neovim/neovim/statuses/{sha}","languages_url":"https://api.github.com/repos/neovim/neovim/languages","stargazers_url":"https://api.github.com/repos/neovim/neovim/stargazers","contributors_url":"https://api.github.com/repos/neovim/neovim/contributors","subscribers_url":"https://api.github.com/repos/neovim/neovim/subscribers","subscription_url":"https://api.github.com/repos/neovim/neovim/subscription","commits_url":"https://api.github.com/repos/neovim/neovim/commits{/sha}","git_commits_url":"https://api.github.com/repos/neovim/neovim/git/commits{/sha}","comments_url":"https://api.github.com/repos/neovim/neovim/comments{/number}","issue_comment_url":"https://api.github.com/repos/neovim/neovim/issues/comments{/number}","contents_url":"https://api.github.com/repos/neovim/neovim/contents/{+path}","compare_url":"https://api.github.com/repos/neovim/neovim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neovim/neovim/merges","archive_url":"https://api.github.com/repos/neovim/neovim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neovim/neovim/downloads","issues_url":"https://api.github.com/repos/neovim/neovim/issues{/number}","pulls_url":"https://api.github.com/repos/neovim/neovim/pulls{/number}","milestones_url":"https://api.github.com/repos/neovim/neovim/milestones{/number}","notifications_url":"https://api.github.com/repos/neovim/neovim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neovim/neovim/labels{/name}","releases_url":"https://api.github.com/repos/neovim/neovim/releases{/id}","created_at":"2014-01-31T13:39:22Z","updated_at":"2015-06-05T14:09:24Z","pushed_at":"2015-06-05T13:42:59Z","git_url":"git://github.com/neovim/neovim.git","ssh_url":"git@github.com:neovim/neovim.git","clone_url":"https://github.com/neovim/neovim.git","svn_url":"https://github.com/neovim/neovim","homepage":"http://neovim.io","size":78722,"stargazers_count":13584,"watchers_count":13584,"language":"VimL","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":931,"mirror_url":null,"open_issues_count":492,"forks":931,"open_issues":492,"watchers":13584,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/neovim/neovim/pulls/2789"},"html":{"href":"https://github.com/neovim/neovim/pull/2789"},"issue":{"href":"https://api.github.com/repos/neovim/neovim/issues/2789"},"comments":{"href":"https://api.github.com/repos/neovim/neovim/issues/2789/comments"},"review_comments":{"href":"https://api.github.com/repos/neovim/neovim/pulls/2789/comments"},"review_comment":{"href":"https://api.github.com/repos/neovim/neovim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/neovim/neovim/pulls/2789/commits"},"statuses":{"href":"https://api.github.com/repos/neovim/neovim/statuses/edc936ce6831c562dd925cfe155c6b5134ed1300"}}}}