{"action":"created","issue":{"url":"https://api.github.com/repos/elastic/elasticsearch/issues/11251","labels_url":"https://api.github.com/repos/elastic/elasticsearch/issues/11251/labels{/name}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/issues/11251/comments","events_url":"https://api.github.com/repos/elastic/elasticsearch/issues/11251/events","html_url":"https://github.com/elastic/elasticsearch/issues/11251","id":78448857,"number":11251,"title":"Response codes for index sealing","user":{"login":"brwe","id":4320215,"avatar_url":"https://avatars.githubusercontent.com/u/4320215?v=3","gravatar_id":"","url":"https://api.github.com/users/brwe","html_url":"https://github.com/brwe","followers_url":"https://api.github.com/users/brwe/followers","following_url":"https://api.github.com/users/brwe/following{/other_user}","gists_url":"https://api.github.com/users/brwe/gists{/gist_id}","starred_url":"https://api.github.com/users/brwe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brwe/subscriptions","organizations_url":"https://api.github.com/users/brwe/orgs","repos_url":"https://api.github.com/users/brwe/repos","events_url":"https://api.github.com/users/brwe/events{/privacy}","received_events_url":"https://api.github.com/users/brwe/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/elastic/elasticsearch/labels/v1.6.0","name":"v1.6.0","color":"dddddd"},{"url":"https://api.github.com/repos/elastic/elasticsearch/labels/v2.0.0","name":"v2.0.0","color":"dddddd"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-05-20T09:28:34Z","updated_at":"2015-05-26T13:13:46Z","closed_at":null,"body":"We still have to decide which response codes to return if index sealing failed. Currently we return PARTIAL_CONTENT(206) for partial success and CONFLICT(409) for complete failure but this is not really right as discussed here: https://github.com/elastic/elasticsearch/pull/11179#discussion_r30437649\r\nSorry @nik9000 with all the excitement I actually forgot to fix that before merging."},"comment":{"url":"https://api.github.com/repos/elastic/elasticsearch/issues/comments/105521202","html_url":"https://github.com/elastic/elasticsearch/issues/11251#issuecomment-105521202","issue_url":"https://api.github.com/repos/elastic/elasticsearch/issues/11251","id":105521202,"user":{"login":"bleskes","id":1006375,"avatar_url":"https://avatars.githubusercontent.com/u/1006375?v=3","gravatar_id":"","url":"https://api.github.com/users/bleskes","html_url":"https://github.com/bleskes","followers_url":"https://api.github.com/users/bleskes/followers","following_url":"https://api.github.com/users/bleskes/following{/other_user}","gists_url":"https://api.github.com/users/bleskes/gists{/gist_id}","starred_url":"https://api.github.com/users/bleskes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bleskes/subscriptions","organizations_url":"https://api.github.com/users/bleskes/orgs","repos_url":"https://api.github.com/users/bleskes/repos","events_url":"https://api.github.com/users/bleskes/events{/privacy}","received_events_url":"https://api.github.com/users/bleskes/received_events","type":"User","site_admin":false},"created_at":"2015-05-26T13:13:46Z","updated_at":"2015-05-26T13:13:46Z","body":"re reading the spec for 409 conflict, it may be actually what we want:\r\n\r\n```\r\nThe request could not be completed due to a conflict with the current state of the resource. This code is only allowed in situations where it is expected that the user might be able to resolve the conflict and resubmit the request. The response body SHOULD include enough ...\r\n```\r\n\r\n99% of failed synced flush (sorry Nik :) ) will be because of concurrent indexing.\r\n\r\nI think @brwe already said she's OK with it (correct me if wrong!) . @clintongormley I think you had some reservations, but I think this is were we gravitate. Any objections left?\r\n\r\n> Sorry for being a pain about this.\r\n\r\nNot at all - These are good discussions! we take good care to choose correctly here, so users in years to come will not be confused.. \r\n"}}