{"action":"created","comment":{"url":"https://api.github.com/repos/minetest/minetest/pulls/comments/43568706","id":43568706,"diff_hunk":"@@ -291,26 +288,18 @@ Server::Server(\n \t}\n \tinfostream << std::endl;\n \t// Load and run \"mod\" scripts\n-\tfor (std::vector<ModSpec>::iterator i = m_mods.begin();\n-\t\t\ti != m_mods.end(); ++i) {\n-\t\tconst ModSpec &mod = *i;\n+\tfor (std::vector<ModSpec>::iterator it = m_mods.begin();\n+\t\t\tit != m_mods.end(); ++it) {\n+\t\tconst ModSpec &mod = *it;","path":"src/server.cpp","position":22,"original_position":22,"commit_id":"101fe547685513f460e9c00c4ecbd57e1c5b4390","original_commit_id":"101fe547685513f460e9c00c4ecbd57e1c5b4390","user":{"login":"Zeno-","id":5899883,"avatar_url":"https://avatars.githubusercontent.com/u/5899883?v=3","gravatar_id":"","url":"https://api.github.com/users/Zeno-","html_url":"https://github.com/Zeno-","followers_url":"https://api.github.com/users/Zeno-/followers","following_url":"https://api.github.com/users/Zeno-/following{/other_user}","gists_url":"https://api.github.com/users/Zeno-/gists{/gist_id}","starred_url":"https://api.github.com/users/Zeno-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zeno-/subscriptions","organizations_url":"https://api.github.com/users/Zeno-/orgs","repos_url":"https://api.github.com/users/Zeno-/repos","events_url":"https://api.github.com/users/Zeno-/events{/privacy}","received_events_url":"https://api.github.com/users/Zeno-/received_events","type":"User","site_admin":false},"body":"i is traditionally an abbreviation for integer? Way back in 1994 we were using 'i' because we believed it was an abbreviation for iterator :/ :)","created_at":"2015-10-31T06:11:26Z","updated_at":"2015-10-31T06:11:26Z","html_url":"https://github.com/minetest/minetest/pull/3305#discussion_r43568706","pull_request_url":"https://api.github.com/repos/minetest/minetest/pulls/3305","_links":{"self":{"href":"https://api.github.com/repos/minetest/minetest/pulls/comments/43568706"},"html":{"href":"https://github.com/minetest/minetest/pull/3305#discussion_r43568706"},"pull_request":{"href":"https://api.github.com/repos/minetest/minetest/pulls/3305"}}},"pull_request":{"url":"https://api.github.com/repos/minetest/minetest/pulls/3305","id":49185544,"html_url":"https://github.com/minetest/minetest/pull/3305","diff_url":"https://github.com/minetest/minetest/pull/3305.diff","patch_url":"https://github.com/minetest/minetest/pull/3305.patch","issue_url":"https://api.github.com/repos/minetest/minetest/issues/3305","number":3305,"state":"open","locked":false,"title":"Fix server crashing on Lua errors","user":{"login":"ShadowNinja","id":3399154,"avatar_url":"https://avatars.githubusercontent.com/u/3399154?v=3","gravatar_id":"","url":"https://api.github.com/users/ShadowNinja","html_url":"https://github.com/ShadowNinja","followers_url":"https://api.github.com/users/ShadowNinja/followers","following_url":"https://api.github.com/users/ShadowNinja/following{/other_user}","gists_url":"https://api.github.com/users/ShadowNinja/gists{/gist_id}","starred_url":"https://api.github.com/users/ShadowNinja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ShadowNinja/subscriptions","organizations_url":"https://api.github.com/users/ShadowNinja/orgs","repos_url":"https://api.github.com/users/ShadowNinja/repos","events_url":"https://api.github.com/users/ShadowNinja/events{/privacy}","received_events_url":"https://api.github.com/users/ShadowNinja/received_events","type":"User","site_admin":false},"body":"Previously, the server called `FATAL_ERROR` when a Lua error occured.\r\nThis caused a (mostly useless) core dump, and, in servers running managed in gdb, a similarly useless and confusing backtrace.\r\nThe server now simply throws an exception, which is caught and printed before exiting with a non-zero return value.\r\nThis also fixes a number of instances where errors were logged multiple times (as many as three times).\r\n\r\nFixes #3213 (which was also reported by VanessaE). \r\n\r\nImplementation note: I changed loadMod and loadScript from returning a bool and taking a error argument to just throwing an exception on error.  This made things easier since the error message was often just turned into an exception and thrown.","created_at":"2015-10-29T19:07:39Z","updated_at":"2015-10-31T06:11:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cab009088dec9d01fc6824b83880f2312a7cba95","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/minetest/minetest/pulls/3305/commits","review_comments_url":"https://api.github.com/repos/minetest/minetest/pulls/3305/comments","review_comment_url":"https://api.github.com/repos/minetest/minetest/pulls/comments{/number}","comments_url":"https://api.github.com/repos/minetest/minetest/issues/3305/comments","statuses_url":"https://api.github.com/repos/minetest/minetest/statuses/101fe547685513f460e9c00c4ecbd57e1c5b4390","head":{"label":"ShadowNinja:fix-lua-err-crash","ref":"fix-lua-err-crash","sha":"101fe547685513f460e9c00c4ecbd57e1c5b4390","user":{"login":"ShadowNinja","id":3399154,"avatar_url":"https://avatars.githubusercontent.com/u/3399154?v=3","gravatar_id":"","url":"https://api.github.com/users/ShadowNinja","html_url":"https://github.com/ShadowNinja","followers_url":"https://api.github.com/users/ShadowNinja/followers","following_url":"https://api.github.com/users/ShadowNinja/following{/other_user}","gists_url":"https://api.github.com/users/ShadowNinja/gists{/gist_id}","starred_url":"https://api.github.com/users/ShadowNinja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ShadowNinja/subscriptions","organizations_url":"https://api.github.com/users/ShadowNinja/orgs","repos_url":"https://api.github.com/users/ShadowNinja/repos","events_url":"https://api.github.com/users/ShadowNinja/events{/privacy}","received_events_url":"https://api.github.com/users/ShadowNinja/received_events","type":"User","site_admin":false},"repo":{"id":8000011,"name":"minetest","full_name":"ShadowNinja/minetest","owner":{"login":"ShadowNinja","id":3399154,"avatar_url":"https://avatars.githubusercontent.com/u/3399154?v=3","gravatar_id":"","url":"https://api.github.com/users/ShadowNinja","html_url":"https://github.com/ShadowNinja","followers_url":"https://api.github.com/users/ShadowNinja/followers","following_url":"https://api.github.com/users/ShadowNinja/following{/other_user}","gists_url":"https://api.github.com/users/ShadowNinja/gists{/gist_id}","starred_url":"https://api.github.com/users/ShadowNinja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ShadowNinja/subscriptions","organizations_url":"https://api.github.com/users/ShadowNinja/orgs","repos_url":"https://api.github.com/users/ShadowNinja/repos","events_url":"https://api.github.com/users/ShadowNinja/events{/privacy}","received_events_url":"https://api.github.com/users/ShadowNinja/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ShadowNinja/minetest","description":"Minetest, an open source infinite-world block sandbox game with survival and crafting. This is a private fork, the official repo is @minetest/minetest","fork":true,"url":"https://api.github.com/repos/ShadowNinja/minetest","forks_url":"https://api.github.com/repos/ShadowNinja/minetest/forks","keys_url":"https://api.github.com/repos/ShadowNinja/minetest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ShadowNinja/minetest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ShadowNinja/minetest/teams","hooks_url":"https://api.github.com/repos/ShadowNinja/minetest/hooks","issue_events_url":"https://api.github.com/repos/ShadowNinja/minetest/issues/events{/number}","events_url":"https://api.github.com/repos/ShadowNinja/minetest/events","assignees_url":"https://api.github.com/repos/ShadowNinja/minetest/assignees{/user}","branches_url":"https://api.github.com/repos/ShadowNinja/minetest/branches{/branch}","tags_url":"https://api.github.com/repos/ShadowNinja/minetest/tags","blobs_url":"https://api.github.com/repos/ShadowNinja/minetest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ShadowNinja/minetest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ShadowNinja/minetest/git/refs{/sha}","trees_url":"https://api.github.com/repos/ShadowNinja/minetest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ShadowNinja/minetest/statuses/{sha}","languages_url":"https://api.github.com/repos/ShadowNinja/minetest/languages","stargazers_url":"https://api.github.com/repos/ShadowNinja/minetest/stargazers","contributors_url":"https://api.github.com/repos/ShadowNinja/minetest/contributors","subscribers_url":"https://api.github.com/repos/ShadowNinja/minetest/subscribers","subscription_url":"https://api.github.com/repos/ShadowNinja/minetest/subscription","commits_url":"https://api.github.com/repos/ShadowNinja/minetest/commits{/sha}","git_commits_url":"https://api.github.com/repos/ShadowNinja/minetest/git/commits{/sha}","comments_url":"https://api.github.com/repos/ShadowNinja/minetest/comments{/number}","issue_comment_url":"https://api.github.com/repos/ShadowNinja/minetest/issues/comments{/number}","contents_url":"https://api.github.com/repos/ShadowNinja/minetest/contents/{+path}","compare_url":"https://api.github.com/repos/ShadowNinja/minetest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ShadowNinja/minetest/merges","archive_url":"https://api.github.com/repos/ShadowNinja/minetest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ShadowNinja/minetest/downloads","issues_url":"https://api.github.com/repos/ShadowNinja/minetest/issues{/number}","pulls_url":"https://api.github.com/repos/ShadowNinja/minetest/pulls{/number}","milestones_url":"https://api.github.com/repos/ShadowNinja/minetest/milestones{/number}","notifications_url":"https://api.github.com/repos/ShadowNinja/minetest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ShadowNinja/minetest/labels{/name}","releases_url":"https://api.github.com/repos/ShadowNinja/minetest/releases{/id}","created_at":"2013-02-04T02:44:10Z","updated_at":"2015-02-21T18:17:05Z","pushed_at":"2015-10-31T04:06:29Z","git_url":"git://github.com/ShadowNinja/minetest.git","ssh_url":"git@github.com:ShadowNinja/minetest.git","clone_url":"https://github.com/ShadowNinja/minetest.git","svn_url":"https://github.com/ShadowNinja/minetest","homepage":"http://minetest.net/","size":42441,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"minetest:master","ref":"master","sha":"688556a5d1910ead2cf06a87af6908110fa9d035","user":{"login":"minetest","id":2624745,"avatar_url":"https://avatars.githubusercontent.com/u/2624745?v=3","gravatar_id":"","url":"https://api.github.com/users/minetest","html_url":"https://github.com/minetest","followers_url":"https://api.github.com/users/minetest/followers","following_url":"https://api.github.com/users/minetest/following{/other_user}","gists_url":"https://api.github.com/users/minetest/gists{/gist_id}","starred_url":"https://api.github.com/users/minetest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minetest/subscriptions","organizations_url":"https://api.github.com/users/minetest/orgs","repos_url":"https://api.github.com/users/minetest/repos","events_url":"https://api.github.com/users/minetest/events{/privacy}","received_events_url":"https://api.github.com/users/minetest/received_events","type":"Organization","site_admin":false},"repo":{"id":2168780,"name":"minetest","full_name":"minetest/minetest","owner":{"login":"minetest","id":2624745,"avatar_url":"https://avatars.githubusercontent.com/u/2624745?v=3","gravatar_id":"","url":"https://api.github.com/users/minetest","html_url":"https://github.com/minetest","followers_url":"https://api.github.com/users/minetest/followers","following_url":"https://api.github.com/users/minetest/following{/other_user}","gists_url":"https://api.github.com/users/minetest/gists{/gist_id}","starred_url":"https://api.github.com/users/minetest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minetest/subscriptions","organizations_url":"https://api.github.com/users/minetest/orgs","repos_url":"https://api.github.com/users/minetest/repos","events_url":"https://api.github.com/users/minetest/events{/privacy}","received_events_url":"https://api.github.com/users/minetest/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/minetest/minetest","description":"Minetest, an open source infinite-world block sandbox game with survival and crafting. [also https://github.com/minetest/minetest_game]","fork":false,"url":"https://api.github.com/repos/minetest/minetest","forks_url":"https://api.github.com/repos/minetest/minetest/forks","keys_url":"https://api.github.com/repos/minetest/minetest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/minetest/minetest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/minetest/minetest/teams","hooks_url":"https://api.github.com/repos/minetest/minetest/hooks","issue_events_url":"https://api.github.com/repos/minetest/minetest/issues/events{/number}","events_url":"https://api.github.com/repos/minetest/minetest/events","assignees_url":"https://api.github.com/repos/minetest/minetest/assignees{/user}","branches_url":"https://api.github.com/repos/minetest/minetest/branches{/branch}","tags_url":"https://api.github.com/repos/minetest/minetest/tags","blobs_url":"https://api.github.com/repos/minetest/minetest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/minetest/minetest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/minetest/minetest/git/refs{/sha}","trees_url":"https://api.github.com/repos/minetest/minetest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/minetest/minetest/statuses/{sha}","languages_url":"https://api.github.com/repos/minetest/minetest/languages","stargazers_url":"https://api.github.com/repos/minetest/minetest/stargazers","contributors_url":"https://api.github.com/repos/minetest/minetest/contributors","subscribers_url":"https://api.github.com/repos/minetest/minetest/subscribers","subscription_url":"https://api.github.com/repos/minetest/minetest/subscription","commits_url":"https://api.github.com/repos/minetest/minetest/commits{/sha}","git_commits_url":"https://api.github.com/repos/minetest/minetest/git/commits{/sha}","comments_url":"https://api.github.com/repos/minetest/minetest/comments{/number}","issue_comment_url":"https://api.github.com/repos/minetest/minetest/issues/comments{/number}","contents_url":"https://api.github.com/repos/minetest/minetest/contents/{+path}","compare_url":"https://api.github.com/repos/minetest/minetest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/minetest/minetest/merges","archive_url":"https://api.github.com/repos/minetest/minetest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/minetest/minetest/downloads","issues_url":"https://api.github.com/repos/minetest/minetest/issues{/number}","pulls_url":"https://api.github.com/repos/minetest/minetest/pulls{/number}","milestones_url":"https://api.github.com/repos/minetest/minetest/milestones{/number}","notifications_url":"https://api.github.com/repos/minetest/minetest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/minetest/minetest/labels{/name}","releases_url":"https://api.github.com/repos/minetest/minetest/releases{/id}","created_at":"2011-08-07T13:48:36Z","updated_at":"2015-10-31T03:01:41Z","pushed_at":"2015-10-31T05:50:07Z","git_url":"git://github.com/minetest/minetest.git","ssh_url":"git@github.com:minetest/minetest.git","clone_url":"https://github.com/minetest/minetest.git","svn_url":"https://github.com/minetest/minetest","homepage":"http://minetest.net/","size":108106,"stargazers_count":1669,"watchers_count":1669,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":557,"mirror_url":null,"open_issues_count":645,"forks":557,"open_issues":645,"watchers":1669,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/minetest/minetest/pulls/3305"},"html":{"href":"https://github.com/minetest/minetest/pull/3305"},"issue":{"href":"https://api.github.com/repos/minetest/minetest/issues/3305"},"comments":{"href":"https://api.github.com/repos/minetest/minetest/issues/3305/comments"},"review_comments":{"href":"https://api.github.com/repos/minetest/minetest/pulls/3305/comments"},"review_comment":{"href":"https://api.github.com/repos/minetest/minetest/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/minetest/minetest/pulls/3305/commits"},"statuses":{"href":"https://api.github.com/repos/minetest/minetest/statuses/101fe547685513f460e9c00c4ecbd57e1c5b4390"}}}}