{"action":"created","issue":{"url":"https://api.github.com/repos/libgeos/libgeos/issues/46","labels_url":"https://api.github.com/repos/libgeos/libgeos/issues/46/labels{/name}","comments_url":"https://api.github.com/repos/libgeos/libgeos/issues/46/comments","events_url":"https://api.github.com/repos/libgeos/libgeos/issues/46/events","html_url":"https://github.com/libgeos/libgeos/pull/46","id":65917126,"number":46,"title":"Syncronize CoordinateArraySequenceFactory::create signatures","user":{"login":"manisandro","id":1298852,"avatar_url":"https://avatars.githubusercontent.com/u/1298852?v=3","gravatar_id":"","url":"https://api.github.com/users/manisandro","html_url":"https://github.com/manisandro","followers_url":"https://api.github.com/users/manisandro/followers","following_url":"https://api.github.com/users/manisandro/following{/other_user}","gists_url":"https://api.github.com/users/manisandro/gists{/gist_id}","starred_url":"https://api.github.com/users/manisandro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manisandro/subscriptions","organizations_url":"https://api.github.com/users/manisandro/orgs","repos_url":"https://api.github.com/users/manisandro/repos","events_url":"https://api.github.com/users/manisandro/events{/privacy}","received_events_url":"https://api.github.com/users/manisandro/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2015-04-02T12:40:19Z","updated_at":"2015-04-20T15:29:21Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/libgeos/libgeos/pulls/46","html_url":"https://github.com/libgeos/libgeos/pull/46","diff_url":"https://github.com/libgeos/libgeos/pull/46.diff","patch_url":"https://github.com/libgeos/libgeos/pull/46.patch"},"body":"The overriding `CoordinateArraySequenceFactory::create` methods have different default parameter values than the `create` methods in the `CoordinateSequenceFactory` base class. This is potentially ambiguous, since\r\n\r\n    ((CoordinateArraySequenceFactory*)factory)->create(0)\r\n\r\nwill fail to compile, while\r\n\r\n    ((CoordinateSequenceFactory*)factory)->create(0)\r\n\r\nwill compile successfully.\r\n\r\nThe patch syncronizes the `create` signatures, and adds necessary\r\n\r\n    reinterpret_cast<std::vector<Coordinate> *>(0)\r\n\r\nthroughout the code to resolve  the ambiguities.\r\n"},"comment":{"url":"https://api.github.com/repos/libgeos/libgeos/issues/comments/94484003","html_url":"https://github.com/libgeos/libgeos/pull/46#issuecomment-94484003","issue_url":"https://api.github.com/repos/libgeos/libgeos/issues/46","id":94484003,"user":{"login":"manisandro","id":1298852,"avatar_url":"https://avatars.githubusercontent.com/u/1298852?v=3","gravatar_id":"","url":"https://api.github.com/users/manisandro","html_url":"https://github.com/manisandro","followers_url":"https://api.github.com/users/manisandro/followers","following_url":"https://api.github.com/users/manisandro/following{/other_user}","gists_url":"https://api.github.com/users/manisandro/gists{/gist_id}","starred_url":"https://api.github.com/users/manisandro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manisandro/subscriptions","organizations_url":"https://api.github.com/users/manisandro/orgs","repos_url":"https://api.github.com/users/manisandro/repos","events_url":"https://api.github.com/users/manisandro/events{/privacy}","received_events_url":"https://api.github.com/users/manisandro/received_events","type":"User","site_admin":false},"created_at":"2015-04-20T15:29:21Z","updated_at":"2015-04-20T15:29:21Z","body":"Yes indeed, good catch. The thing that is slightly ugly is that the implementation of the single-parameter version is\r\n\r\n    return new CoordinateArraySequence(coords,3);\r\n\r\ni.e. as if the default parameter value for the `dims` variable was 3, whereas it is 0 in the two-parameter version. But in my opinion it makes sense to clean this up properly and hence yes, remove the single-parameter version.\r\n\r\n"}}