{"action":"created","issue":{"url":"https://api.github.com/repos/emberjs/data/issues/2468","labels_url":"https://api.github.com/repos/emberjs/data/issues/2468/labels{/name}","comments_url":"https://api.github.com/repos/emberjs/data/issues/2468/comments","events_url":"https://api.github.com/repos/emberjs/data/issues/2468/events","html_url":"https://github.com/emberjs/data/pull/2468","id":48553030,"number":2468,"title":"Support trailing slashes on urls for coalesceFindMany.","user":{"login":"g-cassie","id":4053345,"avatar_url":"https://avatars.githubusercontent.com/u/4053345?v=3","gravatar_id":"","url":"https://api.github.com/users/g-cassie","html_url":"https://github.com/g-cassie","followers_url":"https://api.github.com/users/g-cassie/followers","following_url":"https://api.github.com/users/g-cassie/following{/other_user}","gists_url":"https://api.github.com/users/g-cassie/gists{/gist_id}","starred_url":"https://api.github.com/users/g-cassie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/g-cassie/subscriptions","organizations_url":"https://api.github.com/users/g-cassie/orgs","repos_url":"https://api.github.com/users/g-cassie/repos","events_url":"https://api.github.com/users/g-cassie/events{/privacy}","received_events_url":"https://api.github.com/users/g-cassie/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":10,"created_at":"2014-11-12T19:40:53Z","updated_at":"2015-06-09T10:22:57Z","closed_at":"2015-06-09T10:22:56Z","pull_request":{"url":"https://api.github.com/repos/emberjs/data/pulls/2468","html_url":"https://github.com/emberjs/data/pull/2468","diff_url":"https://github.com/emberjs/data/pull/2468.diff","patch_url":"https://github.com/emberjs/data/pull/2468.patch"},"body":"Currently if you override your adapter as follows, coalesceFindRequests will break (silently).  \r\n```javascript\r\nexport default DS.ActiveModelAdapter.extend({\r\n    buildURL: function(type, id, record){\r\n      return this._super(type, id, record) + '/';\r\n    },\r\n});\r\n```\r\nAs _stripIDFromURL is marked as a private method I do not think it should be expected that users override it.  This provides a simple fix.  Happy to add a test if someone can suggest a simple approach for testing this.\r\n\r\nI've noticed the build is failing. I'll wait to hear whether this would be a merge candidate before fixing. I will also need to make some adjustments to make sure that coalesce uses a trailing slash in the url if a trailing slash url is already being used.\r\n"},"comment":{"url":"https://api.github.com/repos/emberjs/data/issues/comments/110306184","html_url":"https://github.com/emberjs/data/pull/2468#issuecomment-110306184","issue_url":"https://api.github.com/repos/emberjs/data/issues/2468","id":110306184,"user":{"login":"igorT","id":715175,"avatar_url":"https://avatars.githubusercontent.com/u/715175?v=3","gravatar_id":"","url":"https://api.github.com/users/igorT","html_url":"https://github.com/igorT","followers_url":"https://api.github.com/users/igorT/followers","following_url":"https://api.github.com/users/igorT/following{/other_user}","gists_url":"https://api.github.com/users/igorT/gists{/gist_id}","starred_url":"https://api.github.com/users/igorT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/igorT/subscriptions","organizations_url":"https://api.github.com/users/igorT/orgs","repos_url":"https://api.github.com/users/igorT/repos","events_url":"https://api.github.com/users/igorT/events{/privacy}","received_events_url":"https://api.github.com/users/igorT/received_events","type":"User","site_admin":false},"created_at":"2015-06-09T10:22:56Z","updated_at":"2015-06-09T10:22:56Z","body":"@dustinfarris if buildUrl works, i think it's only on accident"}}