{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/orleans/pulls/comments/42457848","id":42457848,"diff_hunk":"@@ -441,7 +441,7 @@ internal static IPAddress ResolveIPAddress(string addrOrHost, byte[] subnet, Add\n                 }\n \n                 var candidates = new List<IPAddress>();\n-                IPAddress[] nodeIps = Dns.GetHostAddresses(addrOrHost);\n+                IPAddress[] nodeIps = Dns.GetHostAddressesAsync(addrOrHost).GetAwaiter().GetResult();","path":"src/Orleans/Configuration/ClusterConfiguration.cs","position":5,"original_position":5,"commit_id":"557d3766aa9ea3222aaf86e62f94e5b28887593f","original_commit_id":"557d3766aa9ea3222aaf86e62f94e5b28887593f","user":{"login":"dVakulen","id":5787619,"avatar_url":"https://avatars.githubusercontent.com/u/5787619?v=3","gravatar_id":"","url":"https://api.github.com/users/dVakulen","html_url":"https://github.com/dVakulen","followers_url":"https://api.github.com/users/dVakulen/followers","following_url":"https://api.github.com/users/dVakulen/following{/other_user}","gists_url":"https://api.github.com/users/dVakulen/gists{/gist_id}","starred_url":"https://api.github.com/users/dVakulen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dVakulen/subscriptions","organizations_url":"https://api.github.com/users/dVakulen/orgs","repos_url":"https://api.github.com/users/dVakulen/repos","events_url":"https://api.github.com/users/dVakulen/events{/privacy}","received_events_url":"https://api.github.com/users/dVakulen/received_events","type":"User","site_admin":false},"body":"Because of https://github.com/aspnet/Security/issues/59, and current callers of ResolveIPAddress wouldn't benefit  much from changing it to async (seems like the is only one who could gain from it is UpdateConfiguration method in SiloControl) so I haven't made such change initially.","created_at":"2015-10-20T05:40:32Z","updated_at":"2015-10-20T05:40:32Z","html_url":"https://github.com/dotnet/orleans/pull/923#discussion_r42457848","pull_request_url":"https://api.github.com/repos/dotnet/orleans/pulls/923","_links":{"self":{"href":"https://api.github.com/repos/dotnet/orleans/pulls/comments/42457848"},"html":{"href":"https://github.com/dotnet/orleans/pull/923#discussion_r42457848"},"pull_request":{"href":"https://api.github.com/repos/dotnet/orleans/pulls/923"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/orleans/pulls/923","id":48033702,"html_url":"https://github.com/dotnet/orleans/pull/923","diff_url":"https://github.com/dotnet/orleans/pull/923.diff","patch_url":"https://github.com/dotnet/orleans/pull/923.patch","issue_url":"https://api.github.com/repos/dotnet/orleans/issues/923","number":923,"state":"open","locked":false,"title":"Coreclr compatibility: Dns.GetHostAddresses -> GetHostAddressesAsync","user":{"login":"dVakulen","id":5787619,"avatar_url":"https://avatars.githubusercontent.com/u/5787619?v=3","gravatar_id":"","url":"https://api.github.com/users/dVakulen","html_url":"https://github.com/dVakulen","followers_url":"https://api.github.com/users/dVakulen/followers","following_url":"https://api.github.com/users/dVakulen/following{/other_user}","gists_url":"https://api.github.com/users/dVakulen/gists{/gist_id}","starred_url":"https://api.github.com/users/dVakulen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dVakulen/subscriptions","organizations_url":"https://api.github.com/users/dVakulen/orgs","repos_url":"https://api.github.com/users/dVakulen/repos","events_url":"https://api.github.com/users/dVakulen/events{/privacy}","received_events_url":"https://api.github.com/users/dVakulen/received_events","type":"User","site_admin":false},"body":"Addresses #368 ","created_at":"2015-10-19T05:57:01Z","updated_at":"2015-10-20T05:40:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0ee993ed2ff7682c5e3078d2ece4eb8070653d2e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/orleans/pulls/923/commits","review_comments_url":"https://api.github.com/repos/dotnet/orleans/pulls/923/comments","review_comment_url":"https://api.github.com/repos/dotnet/orleans/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/orleans/issues/923/comments","statuses_url":"https://api.github.com/repos/dotnet/orleans/statuses/557d3766aa9ea3222aaf86e62f94e5b28887593f","head":{"label":"dVakulen:coreclr-compat","ref":"coreclr-compat","sha":"557d3766aa9ea3222aaf86e62f94e5b28887593f","user":{"login":"dVakulen","id":5787619,"avatar_url":"https://avatars.githubusercontent.com/u/5787619?v=3","gravatar_id":"","url":"https://api.github.com/users/dVakulen","html_url":"https://github.com/dVakulen","followers_url":"https://api.github.com/users/dVakulen/followers","following_url":"https://api.github.com/users/dVakulen/following{/other_user}","gists_url":"https://api.github.com/users/dVakulen/gists{/gist_id}","starred_url":"https://api.github.com/users/dVakulen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dVakulen/subscriptions","organizations_url":"https://api.github.com/users/dVakulen/orgs","repos_url":"https://api.github.com/users/dVakulen/repos","events_url":"https://api.github.com/users/dVakulen/events{/privacy}","received_events_url":"https://api.github.com/users/dVakulen/received_events","type":"User","site_admin":false},"repo":{"id":37816139,"name":"orleans","full_name":"dVakulen/orleans","owner":{"login":"dVakulen","id":5787619,"avatar_url":"https://avatars.githubusercontent.com/u/5787619?v=3","gravatar_id":"","url":"https://api.github.com/users/dVakulen","html_url":"https://github.com/dVakulen","followers_url":"https://api.github.com/users/dVakulen/followers","following_url":"https://api.github.com/users/dVakulen/following{/other_user}","gists_url":"https://api.github.com/users/dVakulen/gists{/gist_id}","starred_url":"https://api.github.com/users/dVakulen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dVakulen/subscriptions","organizations_url":"https://api.github.com/users/dVakulen/orgs","repos_url":"https://api.github.com/users/dVakulen/repos","events_url":"https://api.github.com/users/dVakulen/events{/privacy}","received_events_url":"https://api.github.com/users/dVakulen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dVakulen/orleans","description":"Orleans - Distributed Virtual Actor Model","fork":true,"url":"https://api.github.com/repos/dVakulen/orleans","forks_url":"https://api.github.com/repos/dVakulen/orleans/forks","keys_url":"https://api.github.com/repos/dVakulen/orleans/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dVakulen/orleans/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dVakulen/orleans/teams","hooks_url":"https://api.github.com/repos/dVakulen/orleans/hooks","issue_events_url":"https://api.github.com/repos/dVakulen/orleans/issues/events{/number}","events_url":"https://api.github.com/repos/dVakulen/orleans/events","assignees_url":"https://api.github.com/repos/dVakulen/orleans/assignees{/user}","branches_url":"https://api.github.com/repos/dVakulen/orleans/branches{/branch}","tags_url":"https://api.github.com/repos/dVakulen/orleans/tags","blobs_url":"https://api.github.com/repos/dVakulen/orleans/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dVakulen/orleans/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dVakulen/orleans/git/refs{/sha}","trees_url":"https://api.github.com/repos/dVakulen/orleans/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dVakulen/orleans/statuses/{sha}","languages_url":"https://api.github.com/repos/dVakulen/orleans/languages","stargazers_url":"https://api.github.com/repos/dVakulen/orleans/stargazers","contributors_url":"https://api.github.com/repos/dVakulen/orleans/contributors","subscribers_url":"https://api.github.com/repos/dVakulen/orleans/subscribers","subscription_url":"https://api.github.com/repos/dVakulen/orleans/subscription","commits_url":"https://api.github.com/repos/dVakulen/orleans/commits{/sha}","git_commits_url":"https://api.github.com/repos/dVakulen/orleans/git/commits{/sha}","comments_url":"https://api.github.com/repos/dVakulen/orleans/comments{/number}","issue_comment_url":"https://api.github.com/repos/dVakulen/orleans/issues/comments{/number}","contents_url":"https://api.github.com/repos/dVakulen/orleans/contents/{+path}","compare_url":"https://api.github.com/repos/dVakulen/orleans/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dVakulen/orleans/merges","archive_url":"https://api.github.com/repos/dVakulen/orleans/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dVakulen/orleans/downloads","issues_url":"https://api.github.com/repos/dVakulen/orleans/issues{/number}","pulls_url":"https://api.github.com/repos/dVakulen/orleans/pulls{/number}","milestones_url":"https://api.github.com/repos/dVakulen/orleans/milestones{/number}","notifications_url":"https://api.github.com/repos/dVakulen/orleans/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dVakulen/orleans/labels{/name}","releases_url":"https://api.github.com/repos/dVakulen/orleans/releases{/id}","created_at":"2015-06-21T16:29:25Z","updated_at":"2015-06-21T16:29:28Z","pushed_at":"2015-10-19T05:39:50Z","git_url":"git://github.com/dVakulen/orleans.git","ssh_url":"git@github.com:dVakulen/orleans.git","clone_url":"https://github.com/dVakulen/orleans.git","svn_url":"https://github.com/dVakulen/orleans","homepage":"http://dotnet.github.io/orleans","size":9999,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"58abf68b713a86623b8adb331bea2509bb54918b","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":28232663,"name":"orleans","full_name":"dotnet/orleans","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/orleans","description":"Orleans - Distributed Virtual Actor Model","fork":false,"url":"https://api.github.com/repos/dotnet/orleans","forks_url":"https://api.github.com/repos/dotnet/orleans/forks","keys_url":"https://api.github.com/repos/dotnet/orleans/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/orleans/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/orleans/teams","hooks_url":"https://api.github.com/repos/dotnet/orleans/hooks","issue_events_url":"https://api.github.com/repos/dotnet/orleans/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/orleans/events","assignees_url":"https://api.github.com/repos/dotnet/orleans/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/orleans/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/orleans/tags","blobs_url":"https://api.github.com/repos/dotnet/orleans/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/orleans/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/orleans/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/orleans/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/orleans/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/orleans/languages","stargazers_url":"https://api.github.com/repos/dotnet/orleans/stargazers","contributors_url":"https://api.github.com/repos/dotnet/orleans/contributors","subscribers_url":"https://api.github.com/repos/dotnet/orleans/subscribers","subscription_url":"https://api.github.com/repos/dotnet/orleans/subscription","commits_url":"https://api.github.com/repos/dotnet/orleans/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/orleans/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/orleans/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/orleans/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/orleans/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/orleans/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/orleans/merges","archive_url":"https://api.github.com/repos/dotnet/orleans/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/orleans/downloads","issues_url":"https://api.github.com/repos/dotnet/orleans/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/orleans/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/orleans/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/orleans/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/orleans/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/orleans/releases{/id}","created_at":"2014-12-19T14:32:50Z","updated_at":"2015-10-19T22:08:17Z","pushed_at":"2015-10-20T00:12:12Z","git_url":"git://github.com/dotnet/orleans.git","ssh_url":"git@github.com:dotnet/orleans.git","clone_url":"https://github.com/dotnet/orleans.git","svn_url":"https://github.com/dotnet/orleans","homepage":"http://dotnet.github.io/orleans","size":33343,"stargazers_count":1243,"watchers_count":1243,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":276,"mirror_url":null,"open_issues_count":98,"forks":276,"open_issues":98,"watchers":1243,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/orleans/pulls/923"},"html":{"href":"https://github.com/dotnet/orleans/pull/923"},"issue":{"href":"https://api.github.com/repos/dotnet/orleans/issues/923"},"comments":{"href":"https://api.github.com/repos/dotnet/orleans/issues/923/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/orleans/pulls/923/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/orleans/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/orleans/pulls/923/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/orleans/statuses/557d3766aa9ea3222aaf86e62f94e5b28887593f"}}}}