{"action":"created","issue":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/8559","labels_url":"https://api.github.com/repos/cms-sw/cmssw/issues/8559/labels{/name}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/8559/comments","events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/8559/events","html_url":"https://github.com/cms-sw/cmssw/pull/8559","id":64641181,"number":8559,"title":"Add Support for View of vector of Ptr","user":{"login":"wddgit","id":4295891,"avatar_url":"https://avatars.githubusercontent.com/u/4295891?v=3","gravatar_id":"","url":"https://api.github.com/users/wddgit","html_url":"https://github.com/wddgit","followers_url":"https://api.github.com/users/wddgit/followers","following_url":"https://api.github.com/users/wddgit/following{/other_user}","gists_url":"https://api.github.com/users/wddgit/gists{/gist_id}","starred_url":"https://api.github.com/users/wddgit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wddgit/subscriptions","organizations_url":"https://api.github.com/users/wddgit/orgs","repos_url":"https://api.github.com/users/wddgit/repos","events_url":"https://api.github.com/users/wddgit/events{/privacy}","received_events_url":"https://api.github.com/users/wddgit/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/alca-pending","name":"alca-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/analysis-pending","name":"analysis-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-available","name":"comparison-available","color":"009800"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/core-pending","name":"core-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/dqm-pending","name":"dqm-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/hlt-pending","name":"hlt-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/pending-signatures","name":"pending-signatures","color":"eb6420"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/reconstruction-pending","name":"reconstruction-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/simulation-pending","name":"simulation-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-rejected","name":"tests-rejected","color":"e11d21"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/51","html_url":"https://github.com/cms-sw/cmssw/milestones/Next%20CMSSW_7_5_X","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/51/labels","id":982516,"number":51,"title":"Next CMSSW_7_5_X","description":"","creator":{"login":"nclopezo","id":1944922,"avatar_url":"https://avatars.githubusercontent.com/u/1944922?v=3","gravatar_id":"","url":"https://api.github.com/users/nclopezo","html_url":"https://github.com/nclopezo","followers_url":"https://api.github.com/users/nclopezo/followers","following_url":"https://api.github.com/users/nclopezo/following{/other_user}","gists_url":"https://api.github.com/users/nclopezo/gists{/gist_id}","starred_url":"https://api.github.com/users/nclopezo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nclopezo/subscriptions","organizations_url":"https://api.github.com/users/nclopezo/orgs","repos_url":"https://api.github.com/users/nclopezo/repos","events_url":"https://api.github.com/users/nclopezo/events{/privacy}","received_events_url":"https://api.github.com/users/nclopezo/received_events","type":"User","site_admin":false},"open_issues":53,"closed_issues":316,"state":"open","created_at":"2015-02-17T08:21:25Z","updated_at":"2015-04-01T09:34:33Z","due_on":"2015-03-02T23:00:00Z","closed_at":null},"comments":38,"created_at":"2015-03-26T21:45:07Z","updated_at":"2015-04-01T09:57:05Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/8559","html_url":"https://github.com/cms-sw/cmssw/pull/8559","diff_url":"https://github.com/cms-sw/cmssw/pull/8559.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/8559.patch"},"body":"Add support for View of vector of Ptr. This completes implementation of this new feature. There is a test of its usage in the class ViewAnalyzer in function testStdVectorPtr which is run by ViewTest_cfg.py in the package FWCore/Integration. This does change interfaces. Code in the release was fixed to compile and so that runTheMatrix will pass. But runtime problems could exist in code not run in runThe Matrix and compile time problems for code not in the release. For example, it is no longer possible to get the container product from a Ref which implies many things. For example on cannot construct a RefProd from a Ref. One change in particular that might cause problems. If one inserts into an AssociationMap constructed with the no argument constructor an exception will be thrown at runtime, There is known code like this in the release, although none is called in runTheMatrix tests."},"comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments/88421489","html_url":"https://github.com/cms-sw/cmssw/pull/8559#issuecomment-88421489","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/8559","id":88421489,"user":{"login":"slava77","id":4676718,"avatar_url":"https://avatars.githubusercontent.com/u/4676718?v=3","gravatar_id":"","url":"https://api.github.com/users/slava77","html_url":"https://github.com/slava77","followers_url":"https://api.github.com/users/slava77/followers","following_url":"https://api.github.com/users/slava77/following{/other_user}","gists_url":"https://api.github.com/users/slava77/gists{/gist_id}","starred_url":"https://api.github.com/users/slava77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slava77/subscriptions","organizations_url":"https://api.github.com/users/slava77/orgs","repos_url":"https://api.github.com/users/slava77/repos","events_url":"https://api.github.com/users/slava77/events{/privacy}","received_events_url":"https://api.github.com/users/slava77/received_events","type":"User","site_admin":false},"created_at":"2015-04-01T09:57:05Z","updated_at":"2015-04-01T09:57:05Z","body":"+1\r\n\r\nfor https://github.com/cms-sw/cmssw/pull/8559\t36f7f53\r\ncode changes are in line with expectations at visual inspection.\r\n\r\njenkins tests of RECO workflows pass OK and show no differences in monitored quantities (fwlite or DQM based comparisons).\r\n"}}