{"action":"created","comment":{"url":"https://api.github.com/repos/grpc/grpc-go/pulls/comments/25579821","id":25579821,"diff_hunk":"@@ -193,6 +193,17 @@ func (s *testServer) HalfDuplexCall(stream testpb.TestService_HalfDuplexCallServ\n \n const tlsDir = \"testdata/\"\n \n+func TestDialTimeout(t *testing.T) {\n+\tconn, err := grpc.Dial(\"localhost:0\",\n+\t\tgrpc.WithTimeout(time.Duration(5*time.Microsecond)))\n+\tif err == nil {\n+\t\tconn.Close()\n+\t}\n+\tif err != grpc.ErrTimeout {\n+\t\tt.Fatalf(\"Dial should have returned a timeout error.\")","path":"test/end2end_test.go","position":11,"original_position":11,"commit_id":"c0a98c4d578d0621aa02a065d3f7a94985d26862","original_commit_id":"c0a98c4d578d0621aa02a065d3f7a94985d26862","user":{"login":"gainward","id":705027,"avatar_url":"https://avatars.githubusercontent.com/u/705027?v=3","gravatar_id":"","url":"https://api.github.com/users/gainward","html_url":"https://github.com/gainward","followers_url":"https://api.github.com/users/gainward/followers","following_url":"https://api.github.com/users/gainward/following{/other_user}","gists_url":"https://api.github.com/users/gainward/gists{/gist_id}","starred_url":"https://api.github.com/users/gainward/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gainward/subscriptions","organizations_url":"https://api.github.com/users/gainward/orgs","repos_url":"https://api.github.com/users/gainward/repos","events_url":"https://api.github.com/users/gainward/events{/privacy}","received_events_url":"https://api.github.com/users/gainward/received_events","type":"User","site_admin":false},"body":"ack","created_at":"2015-03-02T06:12:10Z","updated_at":"2015-03-02T06:12:10Z","html_url":"https://github.com/grpc/grpc-go/pull/88#discussion_r25579821","pull_request_url":"https://api.github.com/repos/grpc/grpc-go/pulls/88","_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/comments/25579821"},"html":{"href":"https://github.com/grpc/grpc-go/pull/88#discussion_r25579821"},"pull_request":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/88"}}},"pull_request":{"url":"https://api.github.com/repos/grpc/grpc-go/pulls/88","id":30238620,"html_url":"https://github.com/grpc/grpc-go/pull/88","diff_url":"https://github.com/grpc/grpc-go/pull/88.diff","patch_url":"https://github.com/grpc/grpc-go/pull/88.patch","issue_url":"https://api.github.com/repos/grpc/grpc-go/issues/88","number":88,"state":"open","locked":false,"title":"Add timeout grpcDial option.","user":{"login":"gainward","id":705027,"avatar_url":"https://avatars.githubusercontent.com/u/705027?v=3","gravatar_id":"","url":"https://api.github.com/users/gainward","html_url":"https://github.com/gainward","followers_url":"https://api.github.com/users/gainward/followers","following_url":"https://api.github.com/users/gainward/following{/other_user}","gists_url":"https://api.github.com/users/gainward/gists{/gist_id}","starred_url":"https://api.github.com/users/gainward/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gainward/subscriptions","organizations_url":"https://api.github.com/users/gainward/orgs","repos_url":"https://api.github.com/users/gainward/repos","events_url":"https://api.github.com/users/gainward/events{/privacy}","received_events_url":"https://api.github.com/users/gainward/received_events","type":"User","site_admin":false},"body":"In addition to being triggered normally, the timeout will also be\r\ntriggered if the next backoff cycle would have taken us beyond its\r\nboundry.\r\n\r\nAlso includes limited support for sensing temporary and permanent\r\nnetwork errors. In the case of a permanent error, fail immediately.\r\n\r\nCloses #76 ","created_at":"2015-03-01T07:56:59Z","updated_at":"2015-03-02T06:12:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6672c665bd870e7ed14aebdf68bd235ebab92a40","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/grpc/grpc-go/pulls/88/commits","review_comments_url":"https://api.github.com/repos/grpc/grpc-go/pulls/88/comments","review_comment_url":"https://api.github.com/repos/grpc/grpc-go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/grpc/grpc-go/issues/88/comments","statuses_url":"https://api.github.com/repos/grpc/grpc-go/statuses/c0a98c4d578d0621aa02a065d3f7a94985d26862","head":{"label":"gainward:timeout","ref":"timeout","sha":"c0a98c4d578d0621aa02a065d3f7a94985d26862","user":{"login":"gainward","id":705027,"avatar_url":"https://avatars.githubusercontent.com/u/705027?v=3","gravatar_id":"","url":"https://api.github.com/users/gainward","html_url":"https://github.com/gainward","followers_url":"https://api.github.com/users/gainward/followers","following_url":"https://api.github.com/users/gainward/following{/other_user}","gists_url":"https://api.github.com/users/gainward/gists{/gist_id}","starred_url":"https://api.github.com/users/gainward/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gainward/subscriptions","organizations_url":"https://api.github.com/users/gainward/orgs","repos_url":"https://api.github.com/users/gainward/repos","events_url":"https://api.github.com/users/gainward/events{/privacy}","received_events_url":"https://api.github.com/users/gainward/received_events","type":"User","site_admin":false},"repo":{"id":31475411,"name":"grpc-go","full_name":"gainward/grpc-go","owner":{"login":"gainward","id":705027,"avatar_url":"https://avatars.githubusercontent.com/u/705027?v=3","gravatar_id":"","url":"https://api.github.com/users/gainward","html_url":"https://github.com/gainward","followers_url":"https://api.github.com/users/gainward/followers","following_url":"https://api.github.com/users/gainward/following{/other_user}","gists_url":"https://api.github.com/users/gainward/gists{/gist_id}","starred_url":"https://api.github.com/users/gainward/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gainward/subscriptions","organizations_url":"https://api.github.com/users/gainward/orgs","repos_url":"https://api.github.com/users/gainward/repos","events_url":"https://api.github.com/users/gainward/events{/privacy}","received_events_url":"https://api.github.com/users/gainward/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gainward/grpc-go","description":"The Go language implementation of gRPC. HTTP/2 based RPC","fork":true,"url":"https://api.github.com/repos/gainward/grpc-go","forks_url":"https://api.github.com/repos/gainward/grpc-go/forks","keys_url":"https://api.github.com/repos/gainward/grpc-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gainward/grpc-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gainward/grpc-go/teams","hooks_url":"https://api.github.com/repos/gainward/grpc-go/hooks","issue_events_url":"https://api.github.com/repos/gainward/grpc-go/issues/events{/number}","events_url":"https://api.github.com/repos/gainward/grpc-go/events","assignees_url":"https://api.github.com/repos/gainward/grpc-go/assignees{/user}","branches_url":"https://api.github.com/repos/gainward/grpc-go/branches{/branch}","tags_url":"https://api.github.com/repos/gainward/grpc-go/tags","blobs_url":"https://api.github.com/repos/gainward/grpc-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gainward/grpc-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gainward/grpc-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/gainward/grpc-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gainward/grpc-go/statuses/{sha}","languages_url":"https://api.github.com/repos/gainward/grpc-go/languages","stargazers_url":"https://api.github.com/repos/gainward/grpc-go/stargazers","contributors_url":"https://api.github.com/repos/gainward/grpc-go/contributors","subscribers_url":"https://api.github.com/repos/gainward/grpc-go/subscribers","subscription_url":"https://api.github.com/repos/gainward/grpc-go/subscription","commits_url":"https://api.github.com/repos/gainward/grpc-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/gainward/grpc-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/gainward/grpc-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/gainward/grpc-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/gainward/grpc-go/contents/{+path}","compare_url":"https://api.github.com/repos/gainward/grpc-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gainward/grpc-go/merges","archive_url":"https://api.github.com/repos/gainward/grpc-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gainward/grpc-go/downloads","issues_url":"https://api.github.com/repos/gainward/grpc-go/issues{/number}","pulls_url":"https://api.github.com/repos/gainward/grpc-go/pulls{/number}","milestones_url":"https://api.github.com/repos/gainward/grpc-go/milestones{/number}","notifications_url":"https://api.github.com/repos/gainward/grpc-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gainward/grpc-go/labels{/name}","releases_url":"https://api.github.com/repos/gainward/grpc-go/releases{/id}","created_at":"2015-02-28T20:21:32Z","updated_at":"2015-02-28T20:21:33Z","pushed_at":"2015-03-01T07:55:21Z","git_url":"git://github.com/gainward/grpc-go.git","ssh_url":"git@github.com:gainward/grpc-go.git","clone_url":"https://github.com/gainward/grpc-go.git","svn_url":"https://github.com/gainward/grpc-go","homepage":"","size":522,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"grpc:master","ref":"master","sha":"63953dd7e50d346477452082487955d1339af998","user":{"login":"grpc","id":7802525,"avatar_url":"https://avatars.githubusercontent.com/u/7802525?v=3","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"repo":{"id":27729907,"name":"grpc-go","full_name":"grpc/grpc-go","owner":{"login":"grpc","id":7802525,"avatar_url":"https://avatars.githubusercontent.com/u/7802525?v=3","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/grpc/grpc-go","description":"The Go language implementation of gRPC. HTTP/2 based RPC","fork":false,"url":"https://api.github.com/repos/grpc/grpc-go","forks_url":"https://api.github.com/repos/grpc/grpc-go/forks","keys_url":"https://api.github.com/repos/grpc/grpc-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grpc/grpc-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grpc/grpc-go/teams","hooks_url":"https://api.github.com/repos/grpc/grpc-go/hooks","issue_events_url":"https://api.github.com/repos/grpc/grpc-go/issues/events{/number}","events_url":"https://api.github.com/repos/grpc/grpc-go/events","assignees_url":"https://api.github.com/repos/grpc/grpc-go/assignees{/user}","branches_url":"https://api.github.com/repos/grpc/grpc-go/branches{/branch}","tags_url":"https://api.github.com/repos/grpc/grpc-go/tags","blobs_url":"https://api.github.com/repos/grpc/grpc-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grpc/grpc-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grpc/grpc-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/grpc/grpc-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grpc/grpc-go/statuses/{sha}","languages_url":"https://api.github.com/repos/grpc/grpc-go/languages","stargazers_url":"https://api.github.com/repos/grpc/grpc-go/stargazers","contributors_url":"https://api.github.com/repos/grpc/grpc-go/contributors","subscribers_url":"https://api.github.com/repos/grpc/grpc-go/subscribers","subscription_url":"https://api.github.com/repos/grpc/grpc-go/subscription","commits_url":"https://api.github.com/repos/grpc/grpc-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/grpc/grpc-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/grpc/grpc-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/grpc/grpc-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/grpc/grpc-go/contents/{+path}","compare_url":"https://api.github.com/repos/grpc/grpc-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grpc/grpc-go/merges","archive_url":"https://api.github.com/repos/grpc/grpc-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grpc/grpc-go/downloads","issues_url":"https://api.github.com/repos/grpc/grpc-go/issues{/number}","pulls_url":"https://api.github.com/repos/grpc/grpc-go/pulls{/number}","milestones_url":"https://api.github.com/repos/grpc/grpc-go/milestones{/number}","notifications_url":"https://api.github.com/repos/grpc/grpc-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grpc/grpc-go/labels{/name}","releases_url":"https://api.github.com/repos/grpc/grpc-go/releases{/id}","created_at":"2014-12-08T18:59:34Z","updated_at":"2015-03-02T05:32:25Z","pushed_at":"2015-03-01T20:36:16Z","git_url":"git://github.com/grpc/grpc-go.git","ssh_url":"git@github.com:grpc/grpc-go.git","clone_url":"https://github.com/grpc/grpc-go.git","svn_url":"https://github.com/grpc/grpc-go","homepage":"","size":1775,"stargazers_count":559,"watchers_count":559,"language":"Go","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":34,"mirror_url":null,"open_issues_count":6,"forks":34,"open_issues":6,"watchers":559,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/88"},"html":{"href":"https://github.com/grpc/grpc-go/pull/88"},"issue":{"href":"https://api.github.com/repos/grpc/grpc-go/issues/88"},"comments":{"href":"https://api.github.com/repos/grpc/grpc-go/issues/88/comments"},"review_comments":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/88/comments"},"review_comment":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/88/commits"},"statuses":{"href":"https://api.github.com/repos/grpc/grpc-go/statuses/c0a98c4d578d0621aa02a065d3f7a94985d26862"}}}}