{"action":"created","comment":{"url":"https://api.github.com/repos/srajag/contrail-packaging/pulls/comments/22936705","id":22936705,"diff_hunk":"@@ -74,3 +76,137 @@ function insert_vrouter() {\n     fi\n     return 0\n }\n+\n+#\n+# For kernel vRouter we use instead insert_vrouter() function above\n+#\n+function vrouter_dpdk_start() {","path":"common/control_files/vrouter-functions.sh","position":24,"original_position":24,"commit_id":"0fb40de0a4e1ea4d5675cc564e887647a323d142","original_commit_id":"0fb40de0a4e1ea4d5675cc564e887647a323d142","user":{"login":"semihalf-dubiel-michal","id":2727673,"avatar_url":"https://avatars.githubusercontent.com/u/2727673?v=3","gravatar_id":"","url":"https://api.github.com/users/semihalf-dubiel-michal","html_url":"https://github.com/semihalf-dubiel-michal","followers_url":"https://api.github.com/users/semihalf-dubiel-michal/followers","following_url":"https://api.github.com/users/semihalf-dubiel-michal/following{/other_user}","gists_url":"https://api.github.com/users/semihalf-dubiel-michal/gists{/gist_id}","starred_url":"https://api.github.com/users/semihalf-dubiel-michal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/semihalf-dubiel-michal/subscriptions","organizations_url":"https://api.github.com/users/semihalf-dubiel-michal/orgs","repos_url":"https://api.github.com/users/semihalf-dubiel-michal/repos","events_url":"https://api.github.com/users/semihalf-dubiel-michal/events{/privacy}","received_events_url":"https://api.github.com/users/semihalf-dubiel-michal/received_events","type":"User","site_admin":false},"body":"I understand this is the reason for code duplication in other files like vrouter-dpdk-post-start.sh for example. We could easily eliminate that by introducing common insert_vrouter function that would call routines for DPDK or kernel module here just by looking into the config. I think it is better approach as it eliminates much of code duplication.","created_at":"2015-01-14T13:49:07Z","updated_at":"2015-01-14T13:49:07Z","html_url":"https://github.com/srajag/contrail-packaging/pull/3#discussion_r22936705","pull_request_url":"https://api.github.com/repos/srajag/contrail-packaging/pulls/3","_links":{"self":{"href":"https://api.github.com/repos/srajag/contrail-packaging/pulls/comments/22936705"},"html":{"href":"https://github.com/srajag/contrail-packaging/pull/3#discussion_r22936705"},"pull_request":{"href":"https://api.github.com/repos/srajag/contrail-packaging/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/srajag/contrail-packaging/pulls/3","id":27340435,"html_url":"https://github.com/srajag/contrail-packaging/pull/3","diff_url":"https://github.com/srajag/contrail-packaging/pull/3.diff","patch_url":"https://github.com/srajag/contrail-packaging/pull/3.patch","issue_url":"https://api.github.com/repos/srajag/contrail-packaging/issues/3","number":3,"state":"open","locked":false,"title":"DPDK vhost0 start/stop scripts","user":{"login":"semihalf-berestovskyy-andriy","id":7814397,"avatar_url":"https://avatars.githubusercontent.com/u/7814397?v=3","gravatar_id":"","url":"https://api.github.com/users/semihalf-berestovskyy-andriy","html_url":"https://github.com/semihalf-berestovskyy-andriy","followers_url":"https://api.github.com/users/semihalf-berestovskyy-andriy/followers","following_url":"https://api.github.com/users/semihalf-berestovskyy-andriy/following{/other_user}","gists_url":"https://api.github.com/users/semihalf-berestovskyy-andriy/gists{/gist_id}","starred_url":"https://api.github.com/users/semihalf-berestovskyy-andriy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/semihalf-berestovskyy-andriy/subscriptions","organizations_url":"https://api.github.com/users/semihalf-berestovskyy-andriy/orgs","repos_url":"https://api.github.com/users/semihalf-berestovskyy-andriy/repos","events_url":"https://api.github.com/users/semihalf-berestovskyy-andriy/events{/privacy}","received_events_url":"https://api.github.com/users/semihalf-berestovskyy-andriy/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-01-14T10:40:32Z","updated_at":"2015-01-14T13:49:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"db271464ef442410c2eac00401053e9f6f44ac10","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/srajag/contrail-packaging/pulls/3/commits","review_comments_url":"https://api.github.com/repos/srajag/contrail-packaging/pulls/3/comments","review_comment_url":"https://api.github.com/repos/srajag/contrail-packaging/pulls/comments/{number}","comments_url":"https://api.github.com/repos/srajag/contrail-packaging/issues/3/comments","statuses_url":"https://api.github.com/repos/srajag/contrail-packaging/statuses/0fb40de0a4e1ea4d5675cc564e887647a323d142","head":{"label":"srajag:dpdk-devel-vhost","ref":"dpdk-devel-vhost","sha":"0fb40de0a4e1ea4d5675cc564e887647a323d142","user":{"login":"srajag","id":5890775,"avatar_url":"https://avatars.githubusercontent.com/u/5890775?v=3","gravatar_id":"","url":"https://api.github.com/users/srajag","html_url":"https://github.com/srajag","followers_url":"https://api.github.com/users/srajag/followers","following_url":"https://api.github.com/users/srajag/following{/other_user}","gists_url":"https://api.github.com/users/srajag/gists{/gist_id}","starred_url":"https://api.github.com/users/srajag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srajag/subscriptions","organizations_url":"https://api.github.com/users/srajag/orgs","repos_url":"https://api.github.com/users/srajag/repos","events_url":"https://api.github.com/users/srajag/events{/privacy}","received_events_url":"https://api.github.com/users/srajag/received_events","type":"User","site_admin":false},"repo":{"id":25287910,"name":"contrail-packaging","full_name":"srajag/contrail-packaging","owner":{"login":"srajag","id":5890775,"avatar_url":"https://avatars.githubusercontent.com/u/5890775?v=3","gravatar_id":"","url":"https://api.github.com/users/srajag","html_url":"https://github.com/srajag","followers_url":"https://api.github.com/users/srajag/followers","following_url":"https://api.github.com/users/srajag/following{/other_user}","gists_url":"https://api.github.com/users/srajag/gists{/gist_id}","starred_url":"https://api.github.com/users/srajag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srajag/subscriptions","organizations_url":"https://api.github.com/users/srajag/orgs","repos_url":"https://api.github.com/users/srajag/repos","events_url":"https://api.github.com/users/srajag/events{/privacy}","received_events_url":"https://api.github.com/users/srajag/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/srajag/contrail-packaging","description":"Contrail VNC packaging","fork":true,"url":"https://api.github.com/repos/srajag/contrail-packaging","forks_url":"https://api.github.com/repos/srajag/contrail-packaging/forks","keys_url":"https://api.github.com/repos/srajag/contrail-packaging/keys{/key_id}","collaborators_url":"https://api.github.com/repos/srajag/contrail-packaging/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/srajag/contrail-packaging/teams","hooks_url":"https://api.github.com/repos/srajag/contrail-packaging/hooks","issue_events_url":"https://api.github.com/repos/srajag/contrail-packaging/issues/events{/number}","events_url":"https://api.github.com/repos/srajag/contrail-packaging/events","assignees_url":"https://api.github.com/repos/srajag/contrail-packaging/assignees{/user}","branches_url":"https://api.github.com/repos/srajag/contrail-packaging/branches{/branch}","tags_url":"https://api.github.com/repos/srajag/contrail-packaging/tags","blobs_url":"https://api.github.com/repos/srajag/contrail-packaging/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/srajag/contrail-packaging/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/srajag/contrail-packaging/git/refs{/sha}","trees_url":"https://api.github.com/repos/srajag/contrail-packaging/git/trees{/sha}","statuses_url":"https://api.github.com/repos/srajag/contrail-packaging/statuses/{sha}","languages_url":"https://api.github.com/repos/srajag/contrail-packaging/languages","stargazers_url":"https://api.github.com/repos/srajag/contrail-packaging/stargazers","contributors_url":"https://api.github.com/repos/srajag/contrail-packaging/contributors","subscribers_url":"https://api.github.com/repos/srajag/contrail-packaging/subscribers","subscription_url":"https://api.github.com/repos/srajag/contrail-packaging/subscription","commits_url":"https://api.github.com/repos/srajag/contrail-packaging/commits{/sha}","git_commits_url":"https://api.github.com/repos/srajag/contrail-packaging/git/commits{/sha}","comments_url":"https://api.github.com/repos/srajag/contrail-packaging/comments{/number}","issue_comment_url":"https://api.github.com/repos/srajag/contrail-packaging/issues/comments/{number}","contents_url":"https://api.github.com/repos/srajag/contrail-packaging/contents/{+path}","compare_url":"https://api.github.com/repos/srajag/contrail-packaging/compare/{base}...{head}","merges_url":"https://api.github.com/repos/srajag/contrail-packaging/merges","archive_url":"https://api.github.com/repos/srajag/contrail-packaging/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/srajag/contrail-packaging/downloads","issues_url":"https://api.github.com/repos/srajag/contrail-packaging/issues{/number}","pulls_url":"https://api.github.com/repos/srajag/contrail-packaging/pulls{/number}","milestones_url":"https://api.github.com/repos/srajag/contrail-packaging/milestones{/number}","notifications_url":"https://api.github.com/repos/srajag/contrail-packaging/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/srajag/contrail-packaging/labels{/name}","releases_url":"https://api.github.com/repos/srajag/contrail-packaging/releases{/id}","created_at":"2014-10-16T05:32:17Z","updated_at":"2014-09-03T05:12:52Z","pushed_at":"2015-01-14T09:57:55Z","git_url":"git://github.com/srajag/contrail-packaging.git","ssh_url":"git@github.com:srajag/contrail-packaging.git","clone_url":"https://github.com/srajag/contrail-packaging.git","svn_url":"https://github.com/srajag/contrail-packaging","homepage":null,"size":17716,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"srajag:dpdk-devel","ref":"dpdk-devel","sha":"20d040f1e3c663b48225975423e7ed3ed15a09f2","user":{"login":"srajag","id":5890775,"avatar_url":"https://avatars.githubusercontent.com/u/5890775?v=3","gravatar_id":"","url":"https://api.github.com/users/srajag","html_url":"https://github.com/srajag","followers_url":"https://api.github.com/users/srajag/followers","following_url":"https://api.github.com/users/srajag/following{/other_user}","gists_url":"https://api.github.com/users/srajag/gists{/gist_id}","starred_url":"https://api.github.com/users/srajag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srajag/subscriptions","organizations_url":"https://api.github.com/users/srajag/orgs","repos_url":"https://api.github.com/users/srajag/repos","events_url":"https://api.github.com/users/srajag/events{/privacy}","received_events_url":"https://api.github.com/users/srajag/received_events","type":"User","site_admin":false},"repo":{"id":25287910,"name":"contrail-packaging","full_name":"srajag/contrail-packaging","owner":{"login":"srajag","id":5890775,"avatar_url":"https://avatars.githubusercontent.com/u/5890775?v=3","gravatar_id":"","url":"https://api.github.com/users/srajag","html_url":"https://github.com/srajag","followers_url":"https://api.github.com/users/srajag/followers","following_url":"https://api.github.com/users/srajag/following{/other_user}","gists_url":"https://api.github.com/users/srajag/gists{/gist_id}","starred_url":"https://api.github.com/users/srajag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srajag/subscriptions","organizations_url":"https://api.github.com/users/srajag/orgs","repos_url":"https://api.github.com/users/srajag/repos","events_url":"https://api.github.com/users/srajag/events{/privacy}","received_events_url":"https://api.github.com/users/srajag/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/srajag/contrail-packaging","description":"Contrail VNC packaging","fork":true,"url":"https://api.github.com/repos/srajag/contrail-packaging","forks_url":"https://api.github.com/repos/srajag/contrail-packaging/forks","keys_url":"https://api.github.com/repos/srajag/contrail-packaging/keys{/key_id}","collaborators_url":"https://api.github.com/repos/srajag/contrail-packaging/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/srajag/contrail-packaging/teams","hooks_url":"https://api.github.com/repos/srajag/contrail-packaging/hooks","issue_events_url":"https://api.github.com/repos/srajag/contrail-packaging/issues/events{/number}","events_url":"https://api.github.com/repos/srajag/contrail-packaging/events","assignees_url":"https://api.github.com/repos/srajag/contrail-packaging/assignees{/user}","branches_url":"https://api.github.com/repos/srajag/contrail-packaging/branches{/branch}","tags_url":"https://api.github.com/repos/srajag/contrail-packaging/tags","blobs_url":"https://api.github.com/repos/srajag/contrail-packaging/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/srajag/contrail-packaging/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/srajag/contrail-packaging/git/refs{/sha}","trees_url":"https://api.github.com/repos/srajag/contrail-packaging/git/trees{/sha}","statuses_url":"https://api.github.com/repos/srajag/contrail-packaging/statuses/{sha}","languages_url":"https://api.github.com/repos/srajag/contrail-packaging/languages","stargazers_url":"https://api.github.com/repos/srajag/contrail-packaging/stargazers","contributors_url":"https://api.github.com/repos/srajag/contrail-packaging/contributors","subscribers_url":"https://api.github.com/repos/srajag/contrail-packaging/subscribers","subscription_url":"https://api.github.com/repos/srajag/contrail-packaging/subscription","commits_url":"https://api.github.com/repos/srajag/contrail-packaging/commits{/sha}","git_commits_url":"https://api.github.com/repos/srajag/contrail-packaging/git/commits{/sha}","comments_url":"https://api.github.com/repos/srajag/contrail-packaging/comments{/number}","issue_comment_url":"https://api.github.com/repos/srajag/contrail-packaging/issues/comments/{number}","contents_url":"https://api.github.com/repos/srajag/contrail-packaging/contents/{+path}","compare_url":"https://api.github.com/repos/srajag/contrail-packaging/compare/{base}...{head}","merges_url":"https://api.github.com/repos/srajag/contrail-packaging/merges","archive_url":"https://api.github.com/repos/srajag/contrail-packaging/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/srajag/contrail-packaging/downloads","issues_url":"https://api.github.com/repos/srajag/contrail-packaging/issues{/number}","pulls_url":"https://api.github.com/repos/srajag/contrail-packaging/pulls{/number}","milestones_url":"https://api.github.com/repos/srajag/contrail-packaging/milestones{/number}","notifications_url":"https://api.github.com/repos/srajag/contrail-packaging/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/srajag/contrail-packaging/labels{/name}","releases_url":"https://api.github.com/repos/srajag/contrail-packaging/releases{/id}","created_at":"2014-10-16T05:32:17Z","updated_at":"2014-09-03T05:12:52Z","pushed_at":"2015-01-14T09:57:55Z","git_url":"git://github.com/srajag/contrail-packaging.git","ssh_url":"git@github.com:srajag/contrail-packaging.git","clone_url":"https://github.com/srajag/contrail-packaging.git","svn_url":"https://github.com/srajag/contrail-packaging","homepage":null,"size":17716,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/srajag/contrail-packaging/pulls/3"},"html":{"href":"https://github.com/srajag/contrail-packaging/pull/3"},"issue":{"href":"https://api.github.com/repos/srajag/contrail-packaging/issues/3"},"comments":{"href":"https://api.github.com/repos/srajag/contrail-packaging/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/srajag/contrail-packaging/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/srajag/contrail-packaging/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/srajag/contrail-packaging/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/srajag/contrail-packaging/statuses/0fb40de0a4e1ea4d5675cc564e887647a323d142"}}}}