{"action":"closed","number":188,"pull_request":{"url":"https://api.github.com/repos/cviebrock/eloquent-sluggable/pulls/188","id":47027701,"html_url":"https://github.com/cviebrock/eloquent-sluggable/pull/188","diff_url":"https://github.com/cviebrock/eloquent-sluggable/pull/188.diff","patch_url":"https://github.com/cviebrock/eloquent-sluggable/pull/188.patch","issue_url":"https://api.github.com/repos/cviebrock/eloquent-sluggable/issues/188","number":188,"state":"closed","locked":false,"title":"Bug when using magic getters.","user":{"login":"ChrisReid","id":2385373,"avatar_url":"https://avatars.githubusercontent.com/u/2385373?v=3","gravatar_id":"","url":"https://api.github.com/users/ChrisReid","html_url":"https://github.com/ChrisReid","followers_url":"https://api.github.com/users/ChrisReid/followers","following_url":"https://api.github.com/users/ChrisReid/following{/other_user}","gists_url":"https://api.github.com/users/ChrisReid/gists{/gist_id}","starred_url":"https://api.github.com/users/ChrisReid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChrisReid/subscriptions","organizations_url":"https://api.github.com/users/ChrisReid/orgs","repos_url":"https://api.github.com/users/ChrisReid/repos","events_url":"https://api.github.com/users/ChrisReid/events{/privacy}","received_events_url":"https://api.github.com/users/ChrisReid/received_events","type":"User","site_admin":false},"body":"My model has the create method overridden. The event listener fires the sluggify and it doesn't seem to like empty() being called on the magic getter. However this fixed the issue.\r\n\r\nThe only possible side effect is if someone has created a getSlugAttribute() mutator, but this would be undesirable anyway as the slug should be saved in a queryable / searchable state. Ie processed on save not on retrieval.","created_at":"2015-10-07T13:36:41Z","updated_at":"2015-10-26T16:45:32Z","closed_at":"2015-10-26T16:45:32Z","merged_at":"2015-10-26T16:45:32Z","merge_commit_sha":"6a45518299e55dcee2901512823ecfcd9ed25f19","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cviebrock/eloquent-sluggable/pulls/188/commits","review_comments_url":"https://api.github.com/repos/cviebrock/eloquent-sluggable/pulls/188/comments","review_comment_url":"https://api.github.com/repos/cviebrock/eloquent-sluggable/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cviebrock/eloquent-sluggable/issues/188/comments","statuses_url":"https://api.github.com/repos/cviebrock/eloquent-sluggable/statuses/bbfce4d3c7bf8f345193198be9c21e12734e72c9","head":{"label":"ChrisReid:patch-1","ref":"patch-1","sha":"bbfce4d3c7bf8f345193198be9c21e12734e72c9","user":{"login":"ChrisReid","id":2385373,"avatar_url":"https://avatars.githubusercontent.com/u/2385373?v=3","gravatar_id":"","url":"https://api.github.com/users/ChrisReid","html_url":"https://github.com/ChrisReid","followers_url":"https://api.github.com/users/ChrisReid/followers","following_url":"https://api.github.com/users/ChrisReid/following{/other_user}","gists_url":"https://api.github.com/users/ChrisReid/gists{/gist_id}","starred_url":"https://api.github.com/users/ChrisReid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChrisReid/subscriptions","organizations_url":"https://api.github.com/users/ChrisReid/orgs","repos_url":"https://api.github.com/users/ChrisReid/repos","events_url":"https://api.github.com/users/ChrisReid/events{/privacy}","received_events_url":"https://api.github.com/users/ChrisReid/received_events","type":"User","site_admin":false},"repo":{"id":43817651,"name":"eloquent-sluggable","full_name":"ChrisReid/eloquent-sluggable","owner":{"login":"ChrisReid","id":2385373,"avatar_url":"https://avatars.githubusercontent.com/u/2385373?v=3","gravatar_id":"","url":"https://api.github.com/users/ChrisReid","html_url":"https://github.com/ChrisReid","followers_url":"https://api.github.com/users/ChrisReid/followers","following_url":"https://api.github.com/users/ChrisReid/following{/other_user}","gists_url":"https://api.github.com/users/ChrisReid/gists{/gist_id}","starred_url":"https://api.github.com/users/ChrisReid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChrisReid/subscriptions","organizations_url":"https://api.github.com/users/ChrisReid/orgs","repos_url":"https://api.github.com/users/ChrisReid/repos","events_url":"https://api.github.com/users/ChrisReid/events{/privacy}","received_events_url":"https://api.github.com/users/ChrisReid/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ChrisReid/eloquent-sluggable","description":"Easy creation of slugs for your Eloquent models in Laravel","fork":true,"url":"https://api.github.com/repos/ChrisReid/eloquent-sluggable","forks_url":"https://api.github.com/repos/ChrisReid/eloquent-sluggable/forks","keys_url":"https://api.github.com/repos/ChrisReid/eloquent-sluggable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ChrisReid/eloquent-sluggable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ChrisReid/eloquent-sluggable/teams","hooks_url":"https://api.github.com/repos/ChrisReid/eloquent-sluggable/hooks","issue_events_url":"https://api.github.com/repos/ChrisReid/eloquent-sluggable/issues/events{/number}","events_url":"https://api.github.com/repos/ChrisReid/eloquent-sluggable/events","assignees_url":"https://api.github.com/repos/ChrisReid/eloquent-sluggable/assignees{/user}","branches_url":"https://api.github.com/repos/ChrisReid/eloquent-sluggable/branches{/branch}","tags_url":"https://api.github.com/repos/ChrisReid/eloquent-sluggable/tags","blobs_url":"https://api.github.com/repos/ChrisReid/eloquent-sluggable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ChrisReid/eloquent-sluggable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ChrisReid/eloquent-sluggable/git/refs{/sha}","trees_url":"https://api.github.com/repos/ChrisReid/eloquent-sluggable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ChrisReid/eloquent-sluggable/statuses/{sha}","languages_url":"https://api.github.com/repos/ChrisReid/eloquent-sluggable/languages","stargazers_url":"https://api.github.com/repos/ChrisReid/eloquent-sluggable/stargazers","contributors_url":"https://api.github.com/repos/ChrisReid/eloquent-sluggable/contributors","subscribers_url":"https://api.github.com/repos/ChrisReid/eloquent-sluggable/subscribers","subscription_url":"https://api.github.com/repos/ChrisReid/eloquent-sluggable/subscription","commits_url":"https://api.github.com/repos/ChrisReid/eloquent-sluggable/commits{/sha}","git_commits_url":"https://api.github.com/repos/ChrisReid/eloquent-sluggable/git/commits{/sha}","comments_url":"https://api.github.com/repos/ChrisReid/eloquent-sluggable/comments{/number}","issue_comment_url":"https://api.github.com/repos/ChrisReid/eloquent-sluggable/issues/comments{/number}","contents_url":"https://api.github.com/repos/ChrisReid/eloquent-sluggable/contents/{+path}","compare_url":"https://api.github.com/repos/ChrisReid/eloquent-sluggable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ChrisReid/eloquent-sluggable/merges","archive_url":"https://api.github.com/repos/ChrisReid/eloquent-sluggable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ChrisReid/eloquent-sluggable/downloads","issues_url":"https://api.github.com/repos/ChrisReid/eloquent-sluggable/issues{/number}","pulls_url":"https://api.github.com/repos/ChrisReid/eloquent-sluggable/pulls{/number}","milestones_url":"https://api.github.com/repos/ChrisReid/eloquent-sluggable/milestones{/number}","notifications_url":"https://api.github.com/repos/ChrisReid/eloquent-sluggable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ChrisReid/eloquent-sluggable/labels{/name}","releases_url":"https://api.github.com/repos/ChrisReid/eloquent-sluggable/releases{/id}","created_at":"2015-10-07T13:29:28Z","updated_at":"2015-10-07T13:29:30Z","pushed_at":"2015-10-07T13:36:10Z","git_url":"git://github.com/ChrisReid/eloquent-sluggable.git","ssh_url":"git@github.com:ChrisReid/eloquent-sluggable.git","clone_url":"https://github.com/ChrisReid/eloquent-sluggable.git","svn_url":"https://github.com/ChrisReid/eloquent-sluggable","homepage":"","size":362,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cviebrock:master","ref":"master","sha":"7dec2a45a87cd0fd7dece9a8b93188bc2f864705","user":{"login":"cviebrock","id":166810,"avatar_url":"https://avatars.githubusercontent.com/u/166810?v=3","gravatar_id":"","url":"https://api.github.com/users/cviebrock","html_url":"https://github.com/cviebrock","followers_url":"https://api.github.com/users/cviebrock/followers","following_url":"https://api.github.com/users/cviebrock/following{/other_user}","gists_url":"https://api.github.com/users/cviebrock/gists{/gist_id}","starred_url":"https://api.github.com/users/cviebrock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cviebrock/subscriptions","organizations_url":"https://api.github.com/users/cviebrock/orgs","repos_url":"https://api.github.com/users/cviebrock/repos","events_url":"https://api.github.com/users/cviebrock/events{/privacy}","received_events_url":"https://api.github.com/users/cviebrock/received_events","type":"User","site_admin":false},"repo":{"id":10513456,"name":"eloquent-sluggable","full_name":"cviebrock/eloquent-sluggable","owner":{"login":"cviebrock","id":166810,"avatar_url":"https://avatars.githubusercontent.com/u/166810?v=3","gravatar_id":"","url":"https://api.github.com/users/cviebrock","html_url":"https://github.com/cviebrock","followers_url":"https://api.github.com/users/cviebrock/followers","following_url":"https://api.github.com/users/cviebrock/following{/other_user}","gists_url":"https://api.github.com/users/cviebrock/gists{/gist_id}","starred_url":"https://api.github.com/users/cviebrock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cviebrock/subscriptions","organizations_url":"https://api.github.com/users/cviebrock/orgs","repos_url":"https://api.github.com/users/cviebrock/repos","events_url":"https://api.github.com/users/cviebrock/events{/privacy}","received_events_url":"https://api.github.com/users/cviebrock/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cviebrock/eloquent-sluggable","description":"Easy creation of slugs for your Eloquent models in Laravel","fork":false,"url":"https://api.github.com/repos/cviebrock/eloquent-sluggable","forks_url":"https://api.github.com/repos/cviebrock/eloquent-sluggable/forks","keys_url":"https://api.github.com/repos/cviebrock/eloquent-sluggable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cviebrock/eloquent-sluggable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cviebrock/eloquent-sluggable/teams","hooks_url":"https://api.github.com/repos/cviebrock/eloquent-sluggable/hooks","issue_events_url":"https://api.github.com/repos/cviebrock/eloquent-sluggable/issues/events{/number}","events_url":"https://api.github.com/repos/cviebrock/eloquent-sluggable/events","assignees_url":"https://api.github.com/repos/cviebrock/eloquent-sluggable/assignees{/user}","branches_url":"https://api.github.com/repos/cviebrock/eloquent-sluggable/branches{/branch}","tags_url":"https://api.github.com/repos/cviebrock/eloquent-sluggable/tags","blobs_url":"https://api.github.com/repos/cviebrock/eloquent-sluggable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cviebrock/eloquent-sluggable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cviebrock/eloquent-sluggable/git/refs{/sha}","trees_url":"https://api.github.com/repos/cviebrock/eloquent-sluggable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cviebrock/eloquent-sluggable/statuses/{sha}","languages_url":"https://api.github.com/repos/cviebrock/eloquent-sluggable/languages","stargazers_url":"https://api.github.com/repos/cviebrock/eloquent-sluggable/stargazers","contributors_url":"https://api.github.com/repos/cviebrock/eloquent-sluggable/contributors","subscribers_url":"https://api.github.com/repos/cviebrock/eloquent-sluggable/subscribers","subscription_url":"https://api.github.com/repos/cviebrock/eloquent-sluggable/subscription","commits_url":"https://api.github.com/repos/cviebrock/eloquent-sluggable/commits{/sha}","git_commits_url":"https://api.github.com/repos/cviebrock/eloquent-sluggable/git/commits{/sha}","comments_url":"https://api.github.com/repos/cviebrock/eloquent-sluggable/comments{/number}","issue_comment_url":"https://api.github.com/repos/cviebrock/eloquent-sluggable/issues/comments{/number}","contents_url":"https://api.github.com/repos/cviebrock/eloquent-sluggable/contents/{+path}","compare_url":"https://api.github.com/repos/cviebrock/eloquent-sluggable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cviebrock/eloquent-sluggable/merges","archive_url":"https://api.github.com/repos/cviebrock/eloquent-sluggable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cviebrock/eloquent-sluggable/downloads","issues_url":"https://api.github.com/repos/cviebrock/eloquent-sluggable/issues{/number}","pulls_url":"https://api.github.com/repos/cviebrock/eloquent-sluggable/pulls{/number}","milestones_url":"https://api.github.com/repos/cviebrock/eloquent-sluggable/milestones{/number}","notifications_url":"https://api.github.com/repos/cviebrock/eloquent-sluggable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cviebrock/eloquent-sluggable/labels{/name}","releases_url":"https://api.github.com/repos/cviebrock/eloquent-sluggable/releases{/id}","created_at":"2013-06-05T21:42:39Z","updated_at":"2015-10-26T12:52:58Z","pushed_at":"2015-10-26T16:45:32Z","git_url":"git://github.com/cviebrock/eloquent-sluggable.git","ssh_url":"git@github.com:cviebrock/eloquent-sluggable.git","clone_url":"https://github.com/cviebrock/eloquent-sluggable.git","svn_url":"https://github.com/cviebrock/eloquent-sluggable","homepage":"","size":1166,"stargazers_count":763,"watchers_count":763,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":133,"mirror_url":null,"open_issues_count":6,"forks":133,"open_issues":6,"watchers":763,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cviebrock/eloquent-sluggable/pulls/188"},"html":{"href":"https://github.com/cviebrock/eloquent-sluggable/pull/188"},"issue":{"href":"https://api.github.com/repos/cviebrock/eloquent-sluggable/issues/188"},"comments":{"href":"https://api.github.com/repos/cviebrock/eloquent-sluggable/issues/188/comments"},"review_comments":{"href":"https://api.github.com/repos/cviebrock/eloquent-sluggable/pulls/188/comments"},"review_comment":{"href":"https://api.github.com/repos/cviebrock/eloquent-sluggable/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cviebrock/eloquent-sluggable/pulls/188/commits"},"statuses":{"href":"https://api.github.com/repos/cviebrock/eloquent-sluggable/statuses/bbfce4d3c7bf8f345193198be9c21e12734e72c9"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"cviebrock","id":166810,"avatar_url":"https://avatars.githubusercontent.com/u/166810?v=3","gravatar_id":"","url":"https://api.github.com/users/cviebrock","html_url":"https://github.com/cviebrock","followers_url":"https://api.github.com/users/cviebrock/followers","following_url":"https://api.github.com/users/cviebrock/following{/other_user}","gists_url":"https://api.github.com/users/cviebrock/gists{/gist_id}","starred_url":"https://api.github.com/users/cviebrock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cviebrock/subscriptions","organizations_url":"https://api.github.com/users/cviebrock/orgs","repos_url":"https://api.github.com/users/cviebrock/repos","events_url":"https://api.github.com/users/cviebrock/events{/privacy}","received_events_url":"https://api.github.com/users/cviebrock/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}