{"action":"opened","number":130,"pull_request":{"url":"https://api.github.com/repos/bigboringsystem/bigboringsystem/pulls/130","id":26885695,"html_url":"https://github.com/bigboringsystem/bigboringsystem/pull/130","diff_url":"https://github.com/bigboringsystem/bigboringsystem/pull/130.diff","patch_url":"https://github.com/bigboringsystem/bigboringsystem/pull/130.patch","issue_url":"https://api.github.com/repos/bigboringsystem/bigboringsystem/issues/130","number":130,"state":"open","locked":false,"title":"add client-side phone number validation","user":{"login":"joates","id":490654,"avatar_url":"https://avatars.githubusercontent.com/u/490654?v=3","gravatar_id":"","url":"https://api.github.com/users/joates","html_url":"https://github.com/joates","followers_url":"https://api.github.com/users/joates/followers","following_url":"https://api.github.com/users/joates/following{/other_user}","gists_url":"https://api.github.com/users/joates/gists{/gist_id}","starred_url":"https://api.github.com/users/joates/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joates/subscriptions","organizations_url":"https://api.github.com/users/joates/orgs","repos_url":"https://api.github.com/users/joates/repos","events_url":"https://api.github.com/users/joates/events{/privacy}","received_events_url":"https://api.github.com/users/joates/received_events","type":"User","site_admin":false},"body":"1. please note line [42](https://github.com/joates/bigboringsystem/blob/e47e016ab3c62fbf91438a653bcacf68f9b4cdff/views/layout.jade#L42) of ```layout.jade``` **intentionally** has double-quotes for the pattern attribute (this is so that the regex is properly escaped)\r\n2. this patch also removes the duplicated validation code from the server (any string is accepted), this was done to enable me to properly test the client-side validation and there is a case for that part to be amended, or an alternative solution implemented as discussed in #72 ","created_at":"2015-01-06T12:21:00Z","updated_at":"2015-01-06T12:21:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bigboringsystem/bigboringsystem/pulls/130/commits","review_comments_url":"https://api.github.com/repos/bigboringsystem/bigboringsystem/pulls/130/comments","review_comment_url":"https://api.github.com/repos/bigboringsystem/bigboringsystem/pulls/comments/{number}","comments_url":"https://api.github.com/repos/bigboringsystem/bigboringsystem/issues/130/comments","statuses_url":"https://api.github.com/repos/bigboringsystem/bigboringsystem/statuses/e47e016ab3c62fbf91438a653bcacf68f9b4cdff","head":{"label":"joates:input-type-tel","ref":"input-type-tel","sha":"e47e016ab3c62fbf91438a653bcacf68f9b4cdff","user":{"login":"joates","id":490654,"avatar_url":"https://avatars.githubusercontent.com/u/490654?v=3","gravatar_id":"","url":"https://api.github.com/users/joates","html_url":"https://github.com/joates","followers_url":"https://api.github.com/users/joates/followers","following_url":"https://api.github.com/users/joates/following{/other_user}","gists_url":"https://api.github.com/users/joates/gists{/gist_id}","starred_url":"https://api.github.com/users/joates/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joates/subscriptions","organizations_url":"https://api.github.com/users/joates/orgs","repos_url":"https://api.github.com/users/joates/repos","events_url":"https://api.github.com/users/joates/events{/privacy}","received_events_url":"https://api.github.com/users/joates/received_events","type":"User","site_admin":false},"repo":{"id":28681453,"name":"bigboringsystem","full_name":"joates/bigboringsystem","owner":{"login":"joates","id":490654,"avatar_url":"https://avatars.githubusercontent.com/u/490654?v=3","gravatar_id":"","url":"https://api.github.com/users/joates","html_url":"https://github.com/joates","followers_url":"https://api.github.com/users/joates/followers","following_url":"https://api.github.com/users/joates/following{/other_user}","gists_url":"https://api.github.com/users/joates/gists{/gist_id}","starred_url":"https://api.github.com/users/joates/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joates/subscriptions","organizations_url":"https://api.github.com/users/joates/orgs","repos_url":"https://api.github.com/users/joates/repos","events_url":"https://api.github.com/users/joates/events{/privacy}","received_events_url":"https://api.github.com/users/joates/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/joates/bigboringsystem","description":"BBS - Big Boring System","fork":true,"url":"https://api.github.com/repos/joates/bigboringsystem","forks_url":"https://api.github.com/repos/joates/bigboringsystem/forks","keys_url":"https://api.github.com/repos/joates/bigboringsystem/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joates/bigboringsystem/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joates/bigboringsystem/teams","hooks_url":"https://api.github.com/repos/joates/bigboringsystem/hooks","issue_events_url":"https://api.github.com/repos/joates/bigboringsystem/issues/events{/number}","events_url":"https://api.github.com/repos/joates/bigboringsystem/events","assignees_url":"https://api.github.com/repos/joates/bigboringsystem/assignees{/user}","branches_url":"https://api.github.com/repos/joates/bigboringsystem/branches{/branch}","tags_url":"https://api.github.com/repos/joates/bigboringsystem/tags","blobs_url":"https://api.github.com/repos/joates/bigboringsystem/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joates/bigboringsystem/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joates/bigboringsystem/git/refs{/sha}","trees_url":"https://api.github.com/repos/joates/bigboringsystem/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joates/bigboringsystem/statuses/{sha}","languages_url":"https://api.github.com/repos/joates/bigboringsystem/languages","stargazers_url":"https://api.github.com/repos/joates/bigboringsystem/stargazers","contributors_url":"https://api.github.com/repos/joates/bigboringsystem/contributors","subscribers_url":"https://api.github.com/repos/joates/bigboringsystem/subscribers","subscription_url":"https://api.github.com/repos/joates/bigboringsystem/subscription","commits_url":"https://api.github.com/repos/joates/bigboringsystem/commits{/sha}","git_commits_url":"https://api.github.com/repos/joates/bigboringsystem/git/commits{/sha}","comments_url":"https://api.github.com/repos/joates/bigboringsystem/comments{/number}","issue_comment_url":"https://api.github.com/repos/joates/bigboringsystem/issues/comments/{number}","contents_url":"https://api.github.com/repos/joates/bigboringsystem/contents/{+path}","compare_url":"https://api.github.com/repos/joates/bigboringsystem/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joates/bigboringsystem/merges","archive_url":"https://api.github.com/repos/joates/bigboringsystem/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joates/bigboringsystem/downloads","issues_url":"https://api.github.com/repos/joates/bigboringsystem/issues{/number}","pulls_url":"https://api.github.com/repos/joates/bigboringsystem/pulls{/number}","milestones_url":"https://api.github.com/repos/joates/bigboringsystem/milestones{/number}","notifications_url":"https://api.github.com/repos/joates/bigboringsystem/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joates/bigboringsystem/labels{/name}","releases_url":"https://api.github.com/repos/joates/bigboringsystem/releases{/id}","created_at":"2015-01-01T06:04:09Z","updated_at":"2015-01-06T10:02:20Z","pushed_at":"2015-01-06T12:12:37Z","git_url":"git://github.com/joates/bigboringsystem.git","ssh_url":"git@github.com:joates/bigboringsystem.git","clone_url":"https://github.com/joates/bigboringsystem.git","svn_url":"https://github.com/joates/bigboringsystem","homepage":"http://bigboringsystem.com","size":350,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bigboringsystem:master","ref":"master","sha":"c697197734258b5a5ae35947745ce245f1194752","user":{"login":"bigboringsystem","id":10271504,"avatar_url":"https://avatars.githubusercontent.com/u/10271504?v=3","gravatar_id":"","url":"https://api.github.com/users/bigboringsystem","html_url":"https://github.com/bigboringsystem","followers_url":"https://api.github.com/users/bigboringsystem/followers","following_url":"https://api.github.com/users/bigboringsystem/following{/other_user}","gists_url":"https://api.github.com/users/bigboringsystem/gists{/gist_id}","starred_url":"https://api.github.com/users/bigboringsystem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bigboringsystem/subscriptions","organizations_url":"https://api.github.com/users/bigboringsystem/orgs","repos_url":"https://api.github.com/users/bigboringsystem/repos","events_url":"https://api.github.com/users/bigboringsystem/events{/privacy}","received_events_url":"https://api.github.com/users/bigboringsystem/received_events","type":"Organization","site_admin":false},"repo":{"id":28010924,"name":"bigboringsystem","full_name":"bigboringsystem/bigboringsystem","owner":{"login":"bigboringsystem","id":10271504,"avatar_url":"https://avatars.githubusercontent.com/u/10271504?v=3","gravatar_id":"","url":"https://api.github.com/users/bigboringsystem","html_url":"https://github.com/bigboringsystem","followers_url":"https://api.github.com/users/bigboringsystem/followers","following_url":"https://api.github.com/users/bigboringsystem/following{/other_user}","gists_url":"https://api.github.com/users/bigboringsystem/gists{/gist_id}","starred_url":"https://api.github.com/users/bigboringsystem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bigboringsystem/subscriptions","organizations_url":"https://api.github.com/users/bigboringsystem/orgs","repos_url":"https://api.github.com/users/bigboringsystem/repos","events_url":"https://api.github.com/users/bigboringsystem/events{/privacy}","received_events_url":"https://api.github.com/users/bigboringsystem/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bigboringsystem/bigboringsystem","description":"BBS - Big Boring System","fork":false,"url":"https://api.github.com/repos/bigboringsystem/bigboringsystem","forks_url":"https://api.github.com/repos/bigboringsystem/bigboringsystem/forks","keys_url":"https://api.github.com/repos/bigboringsystem/bigboringsystem/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bigboringsystem/bigboringsystem/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bigboringsystem/bigboringsystem/teams","hooks_url":"https://api.github.com/repos/bigboringsystem/bigboringsystem/hooks","issue_events_url":"https://api.github.com/repos/bigboringsystem/bigboringsystem/issues/events{/number}","events_url":"https://api.github.com/repos/bigboringsystem/bigboringsystem/events","assignees_url":"https://api.github.com/repos/bigboringsystem/bigboringsystem/assignees{/user}","branches_url":"https://api.github.com/repos/bigboringsystem/bigboringsystem/branches{/branch}","tags_url":"https://api.github.com/repos/bigboringsystem/bigboringsystem/tags","blobs_url":"https://api.github.com/repos/bigboringsystem/bigboringsystem/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bigboringsystem/bigboringsystem/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bigboringsystem/bigboringsystem/git/refs{/sha}","trees_url":"https://api.github.com/repos/bigboringsystem/bigboringsystem/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bigboringsystem/bigboringsystem/statuses/{sha}","languages_url":"https://api.github.com/repos/bigboringsystem/bigboringsystem/languages","stargazers_url":"https://api.github.com/repos/bigboringsystem/bigboringsystem/stargazers","contributors_url":"https://api.github.com/repos/bigboringsystem/bigboringsystem/contributors","subscribers_url":"https://api.github.com/repos/bigboringsystem/bigboringsystem/subscribers","subscription_url":"https://api.github.com/repos/bigboringsystem/bigboringsystem/subscription","commits_url":"https://api.github.com/repos/bigboringsystem/bigboringsystem/commits{/sha}","git_commits_url":"https://api.github.com/repos/bigboringsystem/bigboringsystem/git/commits{/sha}","comments_url":"https://api.github.com/repos/bigboringsystem/bigboringsystem/comments{/number}","issue_comment_url":"https://api.github.com/repos/bigboringsystem/bigboringsystem/issues/comments/{number}","contents_url":"https://api.github.com/repos/bigboringsystem/bigboringsystem/contents/{+path}","compare_url":"https://api.github.com/repos/bigboringsystem/bigboringsystem/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bigboringsystem/bigboringsystem/merges","archive_url":"https://api.github.com/repos/bigboringsystem/bigboringsystem/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bigboringsystem/bigboringsystem/downloads","issues_url":"https://api.github.com/repos/bigboringsystem/bigboringsystem/issues{/number}","pulls_url":"https://api.github.com/repos/bigboringsystem/bigboringsystem/pulls{/number}","milestones_url":"https://api.github.com/repos/bigboringsystem/bigboringsystem/milestones{/number}","notifications_url":"https://api.github.com/repos/bigboringsystem/bigboringsystem/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bigboringsystem/bigboringsystem/labels{/name}","releases_url":"https://api.github.com/repos/bigboringsystem/bigboringsystem/releases{/id}","created_at":"2014-12-14T22:46:50Z","updated_at":"2015-01-06T10:05:30Z","pushed_at":"2015-01-06T06:38:43Z","git_url":"git://github.com/bigboringsystem/bigboringsystem.git","ssh_url":"git@github.com:bigboringsystem/bigboringsystem.git","clone_url":"https://github.com/bigboringsystem/bigboringsystem.git","svn_url":"https://github.com/bigboringsystem/bigboringsystem","homepage":"http://bigboringsystem.com","size":1458,"stargazers_count":125,"watchers_count":125,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":32,"mirror_url":null,"open_issues_count":39,"forks":32,"open_issues":39,"watchers":125,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bigboringsystem/bigboringsystem/pulls/130"},"html":{"href":"https://github.com/bigboringsystem/bigboringsystem/pull/130"},"issue":{"href":"https://api.github.com/repos/bigboringsystem/bigboringsystem/issues/130"},"comments":{"href":"https://api.github.com/repos/bigboringsystem/bigboringsystem/issues/130/comments"},"review_comments":{"href":"https://api.github.com/repos/bigboringsystem/bigboringsystem/pulls/130/comments"},"review_comment":{"href":"https://api.github.com/repos/bigboringsystem/bigboringsystem/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/bigboringsystem/bigboringsystem/pulls/130/commits"},"statuses":{"href":"https://api.github.com/repos/bigboringsystem/bigboringsystem/statuses/e47e016ab3c62fbf91438a653bcacf68f9b4cdff"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":5,"deletions":3,"changed_files":2}}