{"action":"created","issue":{"url":"https://api.github.com/repos/castleproject/Core/issues/120","labels_url":"https://api.github.com/repos/castleproject/Core/issues/120/labels{/name}","comments_url":"https://api.github.com/repos/castleproject/Core/issues/120/comments","events_url":"https://api.github.com/repos/castleproject/Core/issues/120/events","html_url":"https://github.com/castleproject/Core/pull/120","id":124241563,"number":120,"title":"Fix build error for NET35.","user":{"login":"jeremymeng","id":7583839,"avatar_url":"https://avatars.githubusercontent.com/u/7583839?v=3","gravatar_id":"","url":"https://api.github.com/users/jeremymeng","html_url":"https://github.com/jeremymeng","followers_url":"https://api.github.com/users/jeremymeng/followers","following_url":"https://api.github.com/users/jeremymeng/following{/other_user}","gists_url":"https://api.github.com/users/jeremymeng/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremymeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremymeng/subscriptions","organizations_url":"https://api.github.com/users/jeremymeng/orgs","repos_url":"https://api.github.com/users/jeremymeng/repos","events_url":"https://api.github.com/users/jeremymeng/events{/privacy}","received_events_url":"https://api.github.com/users/jeremymeng/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-12-29T17:23:05Z","updated_at":"2015-12-30T05:01:25Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/castleproject/Core/pulls/120","html_url":"https://github.com/castleproject/Core/pull/120","diff_url":"https://github.com/castleproject/Core/pull/120.diff","patch_url":"https://github.com/castleproject/Core/pull/120.patch"},"body":"@jonorossi Looks like co/contra-variance in generics is introduced after Net35."},"comment":{"url":"https://api.github.com/repos/castleproject/Core/issues/comments/167937137","html_url":"https://github.com/castleproject/Core/pull/120#issuecomment-167937137","issue_url":"https://api.github.com/repos/castleproject/Core/issues/120","id":167937137,"user":{"login":"jeremymeng","id":7583839,"avatar_url":"https://avatars.githubusercontent.com/u/7583839?v=3","gravatar_id":"","url":"https://api.github.com/users/jeremymeng","html_url":"https://github.com/jeremymeng","followers_url":"https://api.github.com/users/jeremymeng/followers","following_url":"https://api.github.com/users/jeremymeng/following{/other_user}","gists_url":"https://api.github.com/users/jeremymeng/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremymeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremymeng/subscriptions","organizations_url":"https://api.github.com/users/jeremymeng/orgs","repos_url":"https://api.github.com/users/jeremymeng/repos","events_url":"https://api.github.com/users/jeremymeng/events{/privacy}","received_events_url":"https://api.github.com/users/jeremymeng/received_events","type":"User","site_admin":false},"created_at":"2015-12-30T05:01:25Z","updated_at":"2015-12-30T05:01:25Z","body":"```\r\nD:\\github\\jeremymeng\\Core>git diff upstream/master\r\n\r\nD:\\github\\jeremymeng\\Core>\r\n```\r\nIt might be due to difference or possible breaking changes in VS 2015 (Roslyn csc, PEVerify, ...)?  I don't have VS 2013 installed on this machine to check. Will try VS 2013 tomorrow.\r\n\r\nThe failures are\r\n```\r\nErrors and Failures:\r\n1) TearDown Failure : Castle.DynamicProxy.Tests.BasicInterfaceProxyTestCase.ProxyTypeWithMultiDimentionalArrayAsParameter\r\n   System.TypeLoadException : Signature of the body and declaration in a method implementation do not match.  Type: 'Castle.Proxies.IClassWithMultiDimentionalArrayProxy'.  Assembly: 'DynamicProxyGenAssembly2, Version=0.0.0.0, Culture=neutral, PublicKeyToken=a621a9e7e5c32e69'.\r\nTearDown : PeVerify reported error(s):\r\n\r\nMicrosoft (R) .NET Framework PE Verifier.  Version  3.5.30729.1\r\nCopyright (c) Microsoft Corporation.  All rights reserved.\r\n\r\n[MD]: .NET Framework Internal error: 0x801312f4 [token:0x00000002]\r\n[MD]: .NET Framework Internal error: 0x801312f4 [token:0x00000004]\r\n2 Error(s) Verifying D:\\github\\jeremymeng\\Core\\src\\Castle.Core.Tests\\bin\\NET35-Debug\\CastleDynProxy2.dll\r\n\r\nat System.Reflection.Emit.TypeBuilder._TermCreateClass(Int32 handle, Module module)\r\nat System.Reflection.Emit.TypeBuilder.CreateTypeNoLock()\r\nat System.Reflection.Emit.TypeBuilder.CreateType()\r\nat Castle.DynamicProxy.Generators.Emitters.AbstractTypeEmitter.CreateType(TypeBuilder type) in d:\\github\\jeremymeng\\Core\\src\\Castle.Core\\DynamicProxy\\Generators\\Emitters\\AbstractTypeEmitter.cs:line 330\r\nat Castle.DynamicProxy.Generators.Emitters.AbstractTypeEmitter.BuildType() in d:\\github\\jeremymeng\\Core\\src\\Castle.Core\\DynamicProxy\\Generators\\Emitters\\AbstractTypeEmitter.cs:line 112\r\nat Castle.DynamicProxy.Generators.InterfaceProxyWithTargetGenerator.GenerateType(String typeName, Type proxyTargetType, Type[] interfaces, INamingScope namingScope) in d:\\github\\jeremymeng\\Core\\src\\Castle.Core\\DynamicProxy\\Generators\\InterfaceProxyWithTargetGenerator.cs:line 150\r\nat Castle.DynamicProxy.Generators.InterfaceProxyWithTargetGenerator.<>c__DisplayClass1.<GenerateCode>b__0(String n, INamingScope s) in d:\\github\\jeremymeng\\Core\\src\\Castle.Core\\DynamicProxy\\Generators\\InterfaceProxyWithTargetGenerator.cs:line 64\r\nat Castle.DynamicProxy.Generators.BaseProxyGenerator.ObtainProxyType(CacheKey cacheKey, Func`3 factory) in d:\\github\\jeremymeng\\Core\\src\\Castle.Core\\DynamicProxy\\Generators\\BaseProxyGenerator.cs:line 418\r\nat Castle.DynamicProxy.ProxyGenerator.CreateInterfaceProxyWithTarget(Type interfaceToProxy, Type[] additionalInterfacesToProxy, Object target, ProxyGenerationOptions options, IInterceptor[] interceptors) in d:\\github\\jeremymeng\\Core\\src\\Castle.Core\\DynamicProxy\\ProxyGenerator.cs:line 338\r\nat Castle.DynamicProxy.ProxyGenerator.CreateInterfaceProxyWithTarget(Type interfaceToProxy, Object target, ProxyGenerationOptions options, IInterceptor[] interceptors) in d:\\github\\jeremymeng\\Core\\src\\Castle.Core\\DynamicProxy\\ProxyGenerator.cs:line 232\r\nat Castle.DynamicProxy.ProxyGenerator.CreateInterfaceProxyWithTarget[TInterface](TInterface target, IInterceptor[] interceptors) in d:\\github\\jeremymeng\\Core\\src\\Castle.Core\\DynamicProxy\\ProxyGenerator.cs:line 132\r\nat Castle.DynamicProxy.Tests.BasicInterfaceProxyTestCase.ProxyTypeWithMultiDimentionalArrayAsParameter() in d:\\github\\jeremymeng\\Core\\src\\Castle.Core.Tests\\BasicInterfaceProxyTestCase.cs:line 110\r\n--TearDown\r\nat Castle.DynamicProxy.Tests.BasePEVerifyTestCase.RunPEVerifyOnGeneratedAssembly(String assemblyPath) in d:\\github\\jeremymeng\\Core\\src\\Castle.Core.Tests\\BasePEVerifyTestCase.cs:line 143\r\nat Castle.DynamicProxy.Tests.BasePEVerifyTestCase.TearDown() in d:\\github\\jeremymeng\\Core\\src\\Castle.Core.Tests\\BasePEVerifyTestCase.cs:line 113\r\n\r\n2) Test Failure : CastleTests.BasicClassProxyTestCase.ProxyTypeWithMultiDimentionalArrayAsParameters\r\n     Expected string length 11 but was 7. Strings differ at index 5.\r\n  Expected: \"Do Do2 Do3 \"\r\n  But was:  \"Do Do3 \"\r\n  ----------------^\r\n\r\nat CastleTests.BasicClassProxyTestCase.ProxyTypeWithMultiDimentionalArrayAsParameters() in d:\\github\\jeremymeng\\Core\\src\\Castle.Core.Tests\\BasicClassProxyTestCase.cs:line 302```"}}