{"action":"created","comment":{"url":"https://api.github.com/repos/Metaswitch/python-common/pulls/comments/22412119","id":22412119,"diff_hunk":"@@ -0,0 +1,57 @@\n+# @file logging_config.py\n+#\n+# Project Clearwater - IMS in the Cloud\n+# Copyright (C) 2015  Metaswitch Networks Ltd","path":"metaswitch/common/logging_config.py","position":4,"original_position":4,"commit_id":"3fdb162cdd10cffd184ce0f26c0ddfc4c6f03969","original_commit_id":"3fdb162cdd10cffd184ce0f26c0ddfc4c6f03969","user":{"login":"rkd-msw","id":4363492,"avatar_url":"https://avatars.githubusercontent.com/u/4363492?v=3","gravatar_id":"","url":"https://api.github.com/users/rkd-msw","html_url":"https://github.com/rkd-msw","followers_url":"https://api.github.com/users/rkd-msw/followers","following_url":"https://api.github.com/users/rkd-msw/following{/other_user}","gists_url":"https://api.github.com/users/rkd-msw/gists{/gist_id}","starred_url":"https://api.github.com/users/rkd-msw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rkd-msw/subscriptions","organizations_url":"https://api.github.com/users/rkd-msw/orgs","repos_url":"https://api.github.com/users/rkd-msw/repos","events_url":"https://api.github.com/users/rkd-msw/events{/privacy}","received_events_url":"https://api.github.com/users/rkd-msw/received_events","type":"User","site_admin":false},"body":"I think this should stay as 2013, because most of this code dates from 2013 and we conventionally leave copyright years as the earliest year (Mike left me a pull request comment to this effect once).","created_at":"2015-01-02T15:08:00Z","updated_at":"2015-01-02T15:08:00Z","html_url":"https://github.com/Metaswitch/python-common/pull/9#discussion_r22412119","pull_request_url":"https://api.github.com/repos/Metaswitch/python-common/pulls/9","_links":{"self":{"href":"https://api.github.com/repos/Metaswitch/python-common/pulls/comments/22412119"},"html":{"href":"https://github.com/Metaswitch/python-common/pull/9#discussion_r22412119"},"pull_request":{"href":"https://api.github.com/repos/Metaswitch/python-common/pulls/9"}}},"pull_request":{"url":"https://api.github.com/repos/Metaswitch/python-common/pulls/9","id":26759411,"html_url":"https://github.com/Metaswitch/python-common/pull/9","diff_url":"https://github.com/Metaswitch/python-common/pull/9.diff","patch_url":"https://github.com/Metaswitch/python-common/pull/9.patch","issue_url":"https://api.github.com/repos/Metaswitch/python-common/issues/9","number":9,"state":"open","locked":false,"title":"[Reviewer: Rob] Move logging_config to common","user":{"login":"eleanor-merry","id":5425325,"avatar_url":"https://avatars.githubusercontent.com/u/5425325?v=3","gravatar_id":"","url":"https://api.github.com/users/eleanor-merry","html_url":"https://github.com/eleanor-merry","followers_url":"https://api.github.com/users/eleanor-merry/followers","following_url":"https://api.github.com/users/eleanor-merry/following{/other_user}","gists_url":"https://api.github.com/users/eleanor-merry/gists{/gist_id}","starred_url":"https://api.github.com/users/eleanor-merry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eleanor-merry/subscriptions","organizations_url":"https://api.github.com/users/eleanor-merry/orgs","repos_url":"https://api.github.com/users/eleanor-merry/repos","events_url":"https://api.github.com/users/eleanor-merry/events{/privacy}","received_events_url":"https://api.github.com/users/eleanor-merry/received_events","type":"User","site_admin":false},"body":"Rob, can you review this change to move the logging function into python common and use UTC for the logs\r\n\r\nPart of the fix for #8 ","created_at":"2015-01-02T15:03:52Z","updated_at":"2015-01-02T15:08:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c01b3017aeeee98a7795beff0aee9282e2d605ac","assignee":{"login":"rkd-msw","id":4363492,"avatar_url":"https://avatars.githubusercontent.com/u/4363492?v=3","gravatar_id":"","url":"https://api.github.com/users/rkd-msw","html_url":"https://github.com/rkd-msw","followers_url":"https://api.github.com/users/rkd-msw/followers","following_url":"https://api.github.com/users/rkd-msw/following{/other_user}","gists_url":"https://api.github.com/users/rkd-msw/gists{/gist_id}","starred_url":"https://api.github.com/users/rkd-msw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rkd-msw/subscriptions","organizations_url":"https://api.github.com/users/rkd-msw/orgs","repos_url":"https://api.github.com/users/rkd-msw/repos","events_url":"https://api.github.com/users/rkd-msw/events{/privacy}","received_events_url":"https://api.github.com/users/rkd-msw/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/Metaswitch/python-common/pulls/9/commits","review_comments_url":"https://api.github.com/repos/Metaswitch/python-common/pulls/9/comments","review_comment_url":"https://api.github.com/repos/Metaswitch/python-common/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Metaswitch/python-common/issues/9/comments","statuses_url":"https://api.github.com/repos/Metaswitch/python-common/statuses/3fdb162cdd10cffd184ce0f26c0ddfc4c6f03969","head":{"label":"Metaswitch:common_logging","ref":"common_logging","sha":"3fdb162cdd10cffd184ce0f26c0ddfc4c6f03969","user":{"login":"Metaswitch","id":453759,"avatar_url":"https://avatars.githubusercontent.com/u/453759?v=3","gravatar_id":"","url":"https://api.github.com/users/Metaswitch","html_url":"https://github.com/Metaswitch","followers_url":"https://api.github.com/users/Metaswitch/followers","following_url":"https://api.github.com/users/Metaswitch/following{/other_user}","gists_url":"https://api.github.com/users/Metaswitch/gists{/gist_id}","starred_url":"https://api.github.com/users/Metaswitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Metaswitch/subscriptions","organizations_url":"https://api.github.com/users/Metaswitch/orgs","repos_url":"https://api.github.com/users/Metaswitch/repos","events_url":"https://api.github.com/users/Metaswitch/events{/privacy}","received_events_url":"https://api.github.com/users/Metaswitch/received_events","type":"Organization","site_admin":false},"repo":{"id":9885259,"name":"python-common","full_name":"Metaswitch/python-common","owner":{"login":"Metaswitch","id":453759,"avatar_url":"https://avatars.githubusercontent.com/u/453759?v=3","gravatar_id":"","url":"https://api.github.com/users/Metaswitch","html_url":"https://github.com/Metaswitch","followers_url":"https://api.github.com/users/Metaswitch/followers","following_url":"https://api.github.com/users/Metaswitch/following{/other_user}","gists_url":"https://api.github.com/users/Metaswitch/gists{/gist_id}","starred_url":"https://api.github.com/users/Metaswitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Metaswitch/subscriptions","organizations_url":"https://api.github.com/users/Metaswitch/orgs","repos_url":"https://api.github.com/users/Metaswitch/repos","events_url":"https://api.github.com/users/Metaswitch/events{/privacy}","received_events_url":"https://api.github.com/users/Metaswitch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Metaswitch/python-common","description":"Common python utilities and function library.","fork":false,"url":"https://api.github.com/repos/Metaswitch/python-common","forks_url":"https://api.github.com/repos/Metaswitch/python-common/forks","keys_url":"https://api.github.com/repos/Metaswitch/python-common/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Metaswitch/python-common/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Metaswitch/python-common/teams","hooks_url":"https://api.github.com/repos/Metaswitch/python-common/hooks","issue_events_url":"https://api.github.com/repos/Metaswitch/python-common/issues/events{/number}","events_url":"https://api.github.com/repos/Metaswitch/python-common/events","assignees_url":"https://api.github.com/repos/Metaswitch/python-common/assignees{/user}","branches_url":"https://api.github.com/repos/Metaswitch/python-common/branches{/branch}","tags_url":"https://api.github.com/repos/Metaswitch/python-common/tags","blobs_url":"https://api.github.com/repos/Metaswitch/python-common/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Metaswitch/python-common/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Metaswitch/python-common/git/refs{/sha}","trees_url":"https://api.github.com/repos/Metaswitch/python-common/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Metaswitch/python-common/statuses/{sha}","languages_url":"https://api.github.com/repos/Metaswitch/python-common/languages","stargazers_url":"https://api.github.com/repos/Metaswitch/python-common/stargazers","contributors_url":"https://api.github.com/repos/Metaswitch/python-common/contributors","subscribers_url":"https://api.github.com/repos/Metaswitch/python-common/subscribers","subscription_url":"https://api.github.com/repos/Metaswitch/python-common/subscription","commits_url":"https://api.github.com/repos/Metaswitch/python-common/commits{/sha}","git_commits_url":"https://api.github.com/repos/Metaswitch/python-common/git/commits{/sha}","comments_url":"https://api.github.com/repos/Metaswitch/python-common/comments{/number}","issue_comment_url":"https://api.github.com/repos/Metaswitch/python-common/issues/comments/{number}","contents_url":"https://api.github.com/repos/Metaswitch/python-common/contents/{+path}","compare_url":"https://api.github.com/repos/Metaswitch/python-common/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Metaswitch/python-common/merges","archive_url":"https://api.github.com/repos/Metaswitch/python-common/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Metaswitch/python-common/downloads","issues_url":"https://api.github.com/repos/Metaswitch/python-common/issues{/number}","pulls_url":"https://api.github.com/repos/Metaswitch/python-common/pulls{/number}","milestones_url":"https://api.github.com/repos/Metaswitch/python-common/milestones{/number}","notifications_url":"https://api.github.com/repos/Metaswitch/python-common/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Metaswitch/python-common/labels{/name}","releases_url":"https://api.github.com/repos/Metaswitch/python-common/releases{/id}","created_at":"2013-05-06T11:20:46Z","updated_at":"2014-10-27T13:00:24Z","pushed_at":"2015-01-02T14:48:59Z","git_url":"git://github.com/Metaswitch/python-common.git","ssh_url":"git@github.com:Metaswitch/python-common.git","clone_url":"https://github.com/Metaswitch/python-common.git","svn_url":"https://github.com/Metaswitch/python-common","homepage":null,"size":190,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":2,"forks":4,"open_issues":2,"watchers":1,"default_branch":"dev"}},"base":{"label":"Metaswitch:dev","ref":"dev","sha":"97a020f1a560211f98c745842d5b92a1b656b1e7","user":{"login":"Metaswitch","id":453759,"avatar_url":"https://avatars.githubusercontent.com/u/453759?v=3","gravatar_id":"","url":"https://api.github.com/users/Metaswitch","html_url":"https://github.com/Metaswitch","followers_url":"https://api.github.com/users/Metaswitch/followers","following_url":"https://api.github.com/users/Metaswitch/following{/other_user}","gists_url":"https://api.github.com/users/Metaswitch/gists{/gist_id}","starred_url":"https://api.github.com/users/Metaswitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Metaswitch/subscriptions","organizations_url":"https://api.github.com/users/Metaswitch/orgs","repos_url":"https://api.github.com/users/Metaswitch/repos","events_url":"https://api.github.com/users/Metaswitch/events{/privacy}","received_events_url":"https://api.github.com/users/Metaswitch/received_events","type":"Organization","site_admin":false},"repo":{"id":9885259,"name":"python-common","full_name":"Metaswitch/python-common","owner":{"login":"Metaswitch","id":453759,"avatar_url":"https://avatars.githubusercontent.com/u/453759?v=3","gravatar_id":"","url":"https://api.github.com/users/Metaswitch","html_url":"https://github.com/Metaswitch","followers_url":"https://api.github.com/users/Metaswitch/followers","following_url":"https://api.github.com/users/Metaswitch/following{/other_user}","gists_url":"https://api.github.com/users/Metaswitch/gists{/gist_id}","starred_url":"https://api.github.com/users/Metaswitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Metaswitch/subscriptions","organizations_url":"https://api.github.com/users/Metaswitch/orgs","repos_url":"https://api.github.com/users/Metaswitch/repos","events_url":"https://api.github.com/users/Metaswitch/events{/privacy}","received_events_url":"https://api.github.com/users/Metaswitch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Metaswitch/python-common","description":"Common python utilities and function library.","fork":false,"url":"https://api.github.com/repos/Metaswitch/python-common","forks_url":"https://api.github.com/repos/Metaswitch/python-common/forks","keys_url":"https://api.github.com/repos/Metaswitch/python-common/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Metaswitch/python-common/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Metaswitch/python-common/teams","hooks_url":"https://api.github.com/repos/Metaswitch/python-common/hooks","issue_events_url":"https://api.github.com/repos/Metaswitch/python-common/issues/events{/number}","events_url":"https://api.github.com/repos/Metaswitch/python-common/events","assignees_url":"https://api.github.com/repos/Metaswitch/python-common/assignees{/user}","branches_url":"https://api.github.com/repos/Metaswitch/python-common/branches{/branch}","tags_url":"https://api.github.com/repos/Metaswitch/python-common/tags","blobs_url":"https://api.github.com/repos/Metaswitch/python-common/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Metaswitch/python-common/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Metaswitch/python-common/git/refs{/sha}","trees_url":"https://api.github.com/repos/Metaswitch/python-common/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Metaswitch/python-common/statuses/{sha}","languages_url":"https://api.github.com/repos/Metaswitch/python-common/languages","stargazers_url":"https://api.github.com/repos/Metaswitch/python-common/stargazers","contributors_url":"https://api.github.com/repos/Metaswitch/python-common/contributors","subscribers_url":"https://api.github.com/repos/Metaswitch/python-common/subscribers","subscription_url":"https://api.github.com/repos/Metaswitch/python-common/subscription","commits_url":"https://api.github.com/repos/Metaswitch/python-common/commits{/sha}","git_commits_url":"https://api.github.com/repos/Metaswitch/python-common/git/commits{/sha}","comments_url":"https://api.github.com/repos/Metaswitch/python-common/comments{/number}","issue_comment_url":"https://api.github.com/repos/Metaswitch/python-common/issues/comments/{number}","contents_url":"https://api.github.com/repos/Metaswitch/python-common/contents/{+path}","compare_url":"https://api.github.com/repos/Metaswitch/python-common/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Metaswitch/python-common/merges","archive_url":"https://api.github.com/repos/Metaswitch/python-common/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Metaswitch/python-common/downloads","issues_url":"https://api.github.com/repos/Metaswitch/python-common/issues{/number}","pulls_url":"https://api.github.com/repos/Metaswitch/python-common/pulls{/number}","milestones_url":"https://api.github.com/repos/Metaswitch/python-common/milestones{/number}","notifications_url":"https://api.github.com/repos/Metaswitch/python-common/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Metaswitch/python-common/labels{/name}","releases_url":"https://api.github.com/repos/Metaswitch/python-common/releases{/id}","created_at":"2013-05-06T11:20:46Z","updated_at":"2014-10-27T13:00:24Z","pushed_at":"2015-01-02T14:48:59Z","git_url":"git://github.com/Metaswitch/python-common.git","ssh_url":"git@github.com:Metaswitch/python-common.git","clone_url":"https://github.com/Metaswitch/python-common.git","svn_url":"https://github.com/Metaswitch/python-common","homepage":null,"size":190,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":2,"forks":4,"open_issues":2,"watchers":1,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/Metaswitch/python-common/pulls/9"},"html":{"href":"https://github.com/Metaswitch/python-common/pull/9"},"issue":{"href":"https://api.github.com/repos/Metaswitch/python-common/issues/9"},"comments":{"href":"https://api.github.com/repos/Metaswitch/python-common/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/Metaswitch/python-common/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/Metaswitch/python-common/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Metaswitch/python-common/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/Metaswitch/python-common/statuses/3fdb162cdd10cffd184ce0f26c0ddfc4c6f03969"}}}}