{"action":"created","comment":{"url":"https://api.github.com/repos/aspnet/CORS/pulls/comments/26166314","id":26166314,"diff_hunk":"@@ -0,0 +1,179 @@\n+﻿// Copyright (c) Microsoft Open Technologies, Inc. All rights reserved.\n+// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.\n+\n+using System;\n+using System.Collections.Generic;\n+using System.Globalization;\n+using System.Linq;\n+using System.Text;\n+\n+namespace Microsoft.AspNet.Cors.Core\n+{\n+    /// <summary>\n+    /// Results returned by <see cref=\"ICorsEngine\"/>.\n+    /// </summary>\n+    public class CorsResult\n+    {\n+        private long? _preflightMaxAge;\n+\n+        /// <summary>\n+        /// Gets a value indicating whether the result is valid.\n+        /// </summary>\n+        public bool IsValid","path":"src/Microsoft.AspNet.Cors.Core/CorsResult.cs","position":22,"original_position":22,"commit_id":"d0cd8990fa9041b117dd96b3debbc65922308171","original_commit_id":"d0cd8990fa9041b117dd96b3debbc65922308171","user":{"login":"lodejard","id":1693989,"avatar_url":"https://avatars.githubusercontent.com/u/1693989?v=3","gravatar_id":"","url":"https://api.github.com/users/lodejard","html_url":"https://github.com/lodejard","followers_url":"https://api.github.com/users/lodejard/followers","following_url":"https://api.github.com/users/lodejard/following{/other_user}","gists_url":"https://api.github.com/users/lodejard/gists{/gist_id}","starred_url":"https://api.github.com/users/lodejard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lodejard/subscriptions","organizations_url":"https://api.github.com/users/lodejard/orgs","repos_url":"https://api.github.com/users/lodejard/repos","events_url":"https://api.github.com/users/lodejard/events{/privacy}","received_events_url":"https://api.github.com/users/lodejard/received_events","type":"User","site_admin":false},"body":"i'm confused about https://github.com/aspnet/CORS/pull/3 and https://github.com/aspnet/CORS/pull/4 - is one of them out of date? do we still have ErrorMessages on the CorsResult?","created_at":"2015-03-10T21:08:16Z","updated_at":"2015-03-10T21:08:16Z","html_url":"https://github.com/aspnet/CORS/pull/4#discussion_r26166314","pull_request_url":"https://api.github.com/repos/aspnet/CORS/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/aspnet/CORS/pulls/comments/26166314"},"html":{"href":"https://github.com/aspnet/CORS/pull/4#discussion_r26166314"},"pull_request":{"href":"https://api.github.com/repos/aspnet/CORS/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/aspnet/CORS/pulls/4","id":30143905,"html_url":"https://github.com/aspnet/CORS/pull/4","diff_url":"https://github.com/aspnet/CORS/pull/4.diff","patch_url":"https://github.com/aspnet/CORS/pull/4.patch","issue_url":"https://api.github.com/repos/aspnet/CORS/issues/4","number":4,"state":"open","locked":false,"title":"Adding Cors Middleware.","user":{"login":"harshgMSFT","id":6729943,"avatar_url":"https://avatars.githubusercontent.com/u/6729943?v=3","gravatar_id":"","url":"https://api.github.com/users/harshgMSFT","html_url":"https://github.com/harshgMSFT","followers_url":"https://api.github.com/users/harshgMSFT/followers","following_url":"https://api.github.com/users/harshgMSFT/following{/other_user}","gists_url":"https://api.github.com/users/harshgMSFT/gists{/gist_id}","starred_url":"https://api.github.com/users/harshgMSFT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harshgMSFT/subscriptions","organizations_url":"https://api.github.com/users/harshgMSFT/orgs","repos_url":"https://api.github.com/users/harshgMSFT/repos","events_url":"https://api.github.com/users/harshgMSFT/events{/privacy}","received_events_url":"https://api.github.com/users/harshgMSFT/received_events","type":"User","site_admin":false},"body":"cc: @Eilon ,@loudj, @DamianEdwards,@davidfowl, @Praburaj ","created_at":"2015-02-27T06:08:46Z","updated_at":"2015-03-10T21:08:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9063e560a5bc9ced5fe4753f62b52214c2ec06f7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/aspnet/CORS/pulls/4/commits","review_comments_url":"https://api.github.com/repos/aspnet/CORS/pulls/4/comments","review_comment_url":"https://api.github.com/repos/aspnet/CORS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aspnet/CORS/issues/4/comments","statuses_url":"https://api.github.com/repos/aspnet/CORS/statuses/d0cd8990fa9041b117dd96b3debbc65922308171","head":{"label":"aspnet:cors-middleware","ref":"cors-middleware","sha":"d0cd8990fa9041b117dd96b3debbc65922308171","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":30898960,"name":"CORS","full_name":"aspnet/CORS","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/CORS","description":"Implementations of common CORS policy and CORS middleware","fork":false,"url":"https://api.github.com/repos/aspnet/CORS","forks_url":"https://api.github.com/repos/aspnet/CORS/forks","keys_url":"https://api.github.com/repos/aspnet/CORS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/CORS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/CORS/teams","hooks_url":"https://api.github.com/repos/aspnet/CORS/hooks","issue_events_url":"https://api.github.com/repos/aspnet/CORS/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/CORS/events","assignees_url":"https://api.github.com/repos/aspnet/CORS/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/CORS/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/CORS/tags","blobs_url":"https://api.github.com/repos/aspnet/CORS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/CORS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/CORS/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/CORS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/CORS/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/CORS/languages","stargazers_url":"https://api.github.com/repos/aspnet/CORS/stargazers","contributors_url":"https://api.github.com/repos/aspnet/CORS/contributors","subscribers_url":"https://api.github.com/repos/aspnet/CORS/subscribers","subscription_url":"https://api.github.com/repos/aspnet/CORS/subscription","commits_url":"https://api.github.com/repos/aspnet/CORS/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/CORS/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/CORS/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/CORS/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/CORS/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/CORS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/CORS/merges","archive_url":"https://api.github.com/repos/aspnet/CORS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/CORS/downloads","issues_url":"https://api.github.com/repos/aspnet/CORS/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/CORS/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/CORS/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/CORS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/CORS/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/CORS/releases{/id}","created_at":"2015-02-17T02:17:36Z","updated_at":"2015-03-09T21:08:20Z","pushed_at":"2015-03-10T10:59:43Z","git_url":"git://github.com/aspnet/CORS.git","ssh_url":"git@github.com:aspnet/CORS.git","clone_url":"https://github.com/aspnet/CORS.git","svn_url":"https://github.com/aspnet/CORS","homepage":null,"size":552,"stargazers_count":4,"watchers_count":4,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":4,"default_branch":"dev"}},"base":{"label":"aspnet:feature-MVC","ref":"feature-MVC","sha":"addb7b7100361f9a3fd60fe060e609609e98ff06","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":30898960,"name":"CORS","full_name":"aspnet/CORS","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/CORS","description":"Implementations of common CORS policy and CORS middleware","fork":false,"url":"https://api.github.com/repos/aspnet/CORS","forks_url":"https://api.github.com/repos/aspnet/CORS/forks","keys_url":"https://api.github.com/repos/aspnet/CORS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/CORS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/CORS/teams","hooks_url":"https://api.github.com/repos/aspnet/CORS/hooks","issue_events_url":"https://api.github.com/repos/aspnet/CORS/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/CORS/events","assignees_url":"https://api.github.com/repos/aspnet/CORS/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/CORS/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/CORS/tags","blobs_url":"https://api.github.com/repos/aspnet/CORS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/CORS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/CORS/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/CORS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/CORS/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/CORS/languages","stargazers_url":"https://api.github.com/repos/aspnet/CORS/stargazers","contributors_url":"https://api.github.com/repos/aspnet/CORS/contributors","subscribers_url":"https://api.github.com/repos/aspnet/CORS/subscribers","subscription_url":"https://api.github.com/repos/aspnet/CORS/subscription","commits_url":"https://api.github.com/repos/aspnet/CORS/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/CORS/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/CORS/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/CORS/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/CORS/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/CORS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/CORS/merges","archive_url":"https://api.github.com/repos/aspnet/CORS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/CORS/downloads","issues_url":"https://api.github.com/repos/aspnet/CORS/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/CORS/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/CORS/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/CORS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/CORS/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/CORS/releases{/id}","created_at":"2015-02-17T02:17:36Z","updated_at":"2015-03-09T21:08:20Z","pushed_at":"2015-03-10T10:59:43Z","git_url":"git://github.com/aspnet/CORS.git","ssh_url":"git@github.com:aspnet/CORS.git","clone_url":"https://github.com/aspnet/CORS.git","svn_url":"https://github.com/aspnet/CORS","homepage":null,"size":552,"stargazers_count":4,"watchers_count":4,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":4,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/aspnet/CORS/pulls/4"},"html":{"href":"https://github.com/aspnet/CORS/pull/4"},"issue":{"href":"https://api.github.com/repos/aspnet/CORS/issues/4"},"comments":{"href":"https://api.github.com/repos/aspnet/CORS/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/aspnet/CORS/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/aspnet/CORS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aspnet/CORS/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/aspnet/CORS/statuses/d0cd8990fa9041b117dd96b3debbc65922308171"}}}}