{"action":"created","comment":{"url":"https://api.github.com/repos/mLewisLogic/saddle/pulls/comments/33637401","id":33637401,"diff_hunk":"@@ -16,10 +16,10 @@ def initialize(app, key_name='access_token')\n         end\n \n         def call(env)\n-          if env[:request][:client_options][@key_name.to_sym]\n+          if env[:saddle][:client_options][@key_name.to_sym]\n             new_query = []\n             new_query << env[:url].query if env[:url].query\n-            new_query << \"#{@key_name}=#{CGI.escape(env[:request][:client_options][@key_name.to_sym].to_s)}\"\n+            new_query << \"#{@key_name}=#{CGI.escape(env[:saddle][:client_options][@key_name.to_sym].to_s)}\"","path":"lib/saddle/middleware/authentication/oauth2.rb","position":9,"original_position":9,"commit_id":"fd5791b36d8ecb69d590fa8cb886ffcff61b8a6a","original_commit_id":"fd5791b36d8ecb69d590fa8cb886ffcff61b8a6a","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Line is too long. [107/80]","created_at":"2015-06-30T23:58:17Z","updated_at":"2015-06-30T23:58:17Z","html_url":"https://github.com/mLewisLogic/saddle/pull/14#discussion_r33637401","pull_request_url":"https://api.github.com/repos/mLewisLogic/saddle/pulls/14","_links":{"self":{"href":"https://api.github.com/repos/mLewisLogic/saddle/pulls/comments/33637401"},"html":{"href":"https://github.com/mLewisLogic/saddle/pull/14#discussion_r33637401"},"pull_request":{"href":"https://api.github.com/repos/mLewisLogic/saddle/pulls/14"}}},"pull_request":{"url":"https://api.github.com/repos/mLewisLogic/saddle/pulls/14","id":38935786,"html_url":"https://github.com/mLewisLogic/saddle/pull/14","diff_url":"https://github.com/mLewisLogic/saddle/pull/14.diff","patch_url":"https://github.com/mLewisLogic/saddle/pull/14.patch","issue_url":"https://api.github.com/repos/mLewisLogic/saddle/issues/14","number":14,"state":"open","locked":false,"title":"Make Saddle work with Faraday 0.9+.","user":{"login":"BMorearty","id":16927,"avatar_url":"https://avatars.githubusercontent.com/u/16927?v=3","gravatar_id":"","url":"https://api.github.com/users/BMorearty","html_url":"https://github.com/BMorearty","followers_url":"https://api.github.com/users/BMorearty/followers","following_url":"https://api.github.com/users/BMorearty/following{/other_user}","gists_url":"https://api.github.com/users/BMorearty/gists{/gist_id}","starred_url":"https://api.github.com/users/BMorearty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BMorearty/subscriptions","organizations_url":"https://api.github.com/users/BMorearty/orgs","repos_url":"https://api.github.com/users/BMorearty/repos","events_url":"https://api.github.com/users/BMorearty/events{/privacy}","received_events_url":"https://api.github.com/users/BMorearty/received_events","type":"User","site_admin":false},"body":"To: @mLewisLogic \r\n\r\n## What? Why? \r\n\r\nUpgrade Saddle to work with Faraday 0.9+. \r\n\r\nThese changes are not backward-compatible with Faraday 0.8.x.\r\n\r\nI had to monkeypatch `Faraday::Request` because Faraday 0.9 validates the keys used in the request options, but Saddle passes additional options.\r\n\r\n## How was this tested?\r\n\r\nRan the specs and ran the saddle-example specs. \r\n\r\n## Version note\r\n\r\nI bumped the version to 0.1.0.rc1. Once this is tested some more, I can use 0.1.0. The 0.1.xx versions will be compatible with Faraday 0.9.x.\r\n\r\nThe 0.0.xx versions can continue to be used for updates that have to remain compatible with Faraday 0.8.x.","created_at":"2015-06-30T23:37:04Z","updated_at":"2015-06-30T23:58:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eab3b50e5fc471a5c2b78c84b6b12ac624ab3106","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mLewisLogic/saddle/pulls/14/commits","review_comments_url":"https://api.github.com/repos/mLewisLogic/saddle/pulls/14/comments","review_comment_url":"https://api.github.com/repos/mLewisLogic/saddle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mLewisLogic/saddle/issues/14/comments","statuses_url":"https://api.github.com/repos/mLewisLogic/saddle/statuses/fd5791b36d8ecb69d590fa8cb886ffcff61b8a6a","head":{"label":"mLewisLogic:bump-faraday","ref":"bump-faraday","sha":"fd5791b36d8ecb69d590fa8cb886ffcff61b8a6a","user":{"login":"mLewisLogic","id":311322,"avatar_url":"https://avatars.githubusercontent.com/u/311322?v=3","gravatar_id":"","url":"https://api.github.com/users/mLewisLogic","html_url":"https://github.com/mLewisLogic","followers_url":"https://api.github.com/users/mLewisLogic/followers","following_url":"https://api.github.com/users/mLewisLogic/following{/other_user}","gists_url":"https://api.github.com/users/mLewisLogic/gists{/gist_id}","starred_url":"https://api.github.com/users/mLewisLogic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mLewisLogic/subscriptions","organizations_url":"https://api.github.com/users/mLewisLogic/orgs","repos_url":"https://api.github.com/users/mLewisLogic/repos","events_url":"https://api.github.com/users/mLewisLogic/events{/privacy}","received_events_url":"https://api.github.com/users/mLewisLogic/received_events","type":"User","site_admin":false},"repo":{"id":8639481,"name":"saddle","full_name":"mLewisLogic/saddle","owner":{"login":"mLewisLogic","id":311322,"avatar_url":"https://avatars.githubusercontent.com/u/311322?v=3","gravatar_id":"","url":"https://api.github.com/users/mLewisLogic","html_url":"https://github.com/mLewisLogic","followers_url":"https://api.github.com/users/mLewisLogic/followers","following_url":"https://api.github.com/users/mLewisLogic/following{/other_user}","gists_url":"https://api.github.com/users/mLewisLogic/gists{/gist_id}","starred_url":"https://api.github.com/users/mLewisLogic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mLewisLogic/subscriptions","organizations_url":"https://api.github.com/users/mLewisLogic/orgs","repos_url":"https://api.github.com/users/mLewisLogic/repos","events_url":"https://api.github.com/users/mLewisLogic/events{/privacy}","received_events_url":"https://api.github.com/users/mLewisLogic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mLewisLogic/saddle","description":"A Ruby framework for service clients","fork":false,"url":"https://api.github.com/repos/mLewisLogic/saddle","forks_url":"https://api.github.com/repos/mLewisLogic/saddle/forks","keys_url":"https://api.github.com/repos/mLewisLogic/saddle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mLewisLogic/saddle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mLewisLogic/saddle/teams","hooks_url":"https://api.github.com/repos/mLewisLogic/saddle/hooks","issue_events_url":"https://api.github.com/repos/mLewisLogic/saddle/issues/events{/number}","events_url":"https://api.github.com/repos/mLewisLogic/saddle/events","assignees_url":"https://api.github.com/repos/mLewisLogic/saddle/assignees{/user}","branches_url":"https://api.github.com/repos/mLewisLogic/saddle/branches{/branch}","tags_url":"https://api.github.com/repos/mLewisLogic/saddle/tags","blobs_url":"https://api.github.com/repos/mLewisLogic/saddle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mLewisLogic/saddle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mLewisLogic/saddle/git/refs{/sha}","trees_url":"https://api.github.com/repos/mLewisLogic/saddle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mLewisLogic/saddle/statuses/{sha}","languages_url":"https://api.github.com/repos/mLewisLogic/saddle/languages","stargazers_url":"https://api.github.com/repos/mLewisLogic/saddle/stargazers","contributors_url":"https://api.github.com/repos/mLewisLogic/saddle/contributors","subscribers_url":"https://api.github.com/repos/mLewisLogic/saddle/subscribers","subscription_url":"https://api.github.com/repos/mLewisLogic/saddle/subscription","commits_url":"https://api.github.com/repos/mLewisLogic/saddle/commits{/sha}","git_commits_url":"https://api.github.com/repos/mLewisLogic/saddle/git/commits{/sha}","comments_url":"https://api.github.com/repos/mLewisLogic/saddle/comments{/number}","issue_comment_url":"https://api.github.com/repos/mLewisLogic/saddle/issues/comments{/number}","contents_url":"https://api.github.com/repos/mLewisLogic/saddle/contents/{+path}","compare_url":"https://api.github.com/repos/mLewisLogic/saddle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mLewisLogic/saddle/merges","archive_url":"https://api.github.com/repos/mLewisLogic/saddle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mLewisLogic/saddle/downloads","issues_url":"https://api.github.com/repos/mLewisLogic/saddle/issues{/number}","pulls_url":"https://api.github.com/repos/mLewisLogic/saddle/pulls{/number}","milestones_url":"https://api.github.com/repos/mLewisLogic/saddle/milestones{/number}","notifications_url":"https://api.github.com/repos/mLewisLogic/saddle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mLewisLogic/saddle/labels{/name}","releases_url":"https://api.github.com/repos/mLewisLogic/saddle/releases{/id}","created_at":"2013-03-08T00:04:42Z","updated_at":"2015-02-09T00:53:30Z","pushed_at":"2015-06-30T23:58:09Z","git_url":"git://github.com/mLewisLogic/saddle.git","ssh_url":"git@github.com:mLewisLogic/saddle.git","clone_url":"https://github.com/mLewisLogic/saddle.git","svn_url":"https://github.com/mLewisLogic/saddle","homepage":"","size":719,"stargazers_count":40,"watchers_count":40,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":40,"default_branch":"master"}},"base":{"label":"mLewisLogic:master","ref":"master","sha":"676a029709b757ac670219c2b88ce25e084a4b38","user":{"login":"mLewisLogic","id":311322,"avatar_url":"https://avatars.githubusercontent.com/u/311322?v=3","gravatar_id":"","url":"https://api.github.com/users/mLewisLogic","html_url":"https://github.com/mLewisLogic","followers_url":"https://api.github.com/users/mLewisLogic/followers","following_url":"https://api.github.com/users/mLewisLogic/following{/other_user}","gists_url":"https://api.github.com/users/mLewisLogic/gists{/gist_id}","starred_url":"https://api.github.com/users/mLewisLogic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mLewisLogic/subscriptions","organizations_url":"https://api.github.com/users/mLewisLogic/orgs","repos_url":"https://api.github.com/users/mLewisLogic/repos","events_url":"https://api.github.com/users/mLewisLogic/events{/privacy}","received_events_url":"https://api.github.com/users/mLewisLogic/received_events","type":"User","site_admin":false},"repo":{"id":8639481,"name":"saddle","full_name":"mLewisLogic/saddle","owner":{"login":"mLewisLogic","id":311322,"avatar_url":"https://avatars.githubusercontent.com/u/311322?v=3","gravatar_id":"","url":"https://api.github.com/users/mLewisLogic","html_url":"https://github.com/mLewisLogic","followers_url":"https://api.github.com/users/mLewisLogic/followers","following_url":"https://api.github.com/users/mLewisLogic/following{/other_user}","gists_url":"https://api.github.com/users/mLewisLogic/gists{/gist_id}","starred_url":"https://api.github.com/users/mLewisLogic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mLewisLogic/subscriptions","organizations_url":"https://api.github.com/users/mLewisLogic/orgs","repos_url":"https://api.github.com/users/mLewisLogic/repos","events_url":"https://api.github.com/users/mLewisLogic/events{/privacy}","received_events_url":"https://api.github.com/users/mLewisLogic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mLewisLogic/saddle","description":"A Ruby framework for service clients","fork":false,"url":"https://api.github.com/repos/mLewisLogic/saddle","forks_url":"https://api.github.com/repos/mLewisLogic/saddle/forks","keys_url":"https://api.github.com/repos/mLewisLogic/saddle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mLewisLogic/saddle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mLewisLogic/saddle/teams","hooks_url":"https://api.github.com/repos/mLewisLogic/saddle/hooks","issue_events_url":"https://api.github.com/repos/mLewisLogic/saddle/issues/events{/number}","events_url":"https://api.github.com/repos/mLewisLogic/saddle/events","assignees_url":"https://api.github.com/repos/mLewisLogic/saddle/assignees{/user}","branches_url":"https://api.github.com/repos/mLewisLogic/saddle/branches{/branch}","tags_url":"https://api.github.com/repos/mLewisLogic/saddle/tags","blobs_url":"https://api.github.com/repos/mLewisLogic/saddle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mLewisLogic/saddle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mLewisLogic/saddle/git/refs{/sha}","trees_url":"https://api.github.com/repos/mLewisLogic/saddle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mLewisLogic/saddle/statuses/{sha}","languages_url":"https://api.github.com/repos/mLewisLogic/saddle/languages","stargazers_url":"https://api.github.com/repos/mLewisLogic/saddle/stargazers","contributors_url":"https://api.github.com/repos/mLewisLogic/saddle/contributors","subscribers_url":"https://api.github.com/repos/mLewisLogic/saddle/subscribers","subscription_url":"https://api.github.com/repos/mLewisLogic/saddle/subscription","commits_url":"https://api.github.com/repos/mLewisLogic/saddle/commits{/sha}","git_commits_url":"https://api.github.com/repos/mLewisLogic/saddle/git/commits{/sha}","comments_url":"https://api.github.com/repos/mLewisLogic/saddle/comments{/number}","issue_comment_url":"https://api.github.com/repos/mLewisLogic/saddle/issues/comments{/number}","contents_url":"https://api.github.com/repos/mLewisLogic/saddle/contents/{+path}","compare_url":"https://api.github.com/repos/mLewisLogic/saddle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mLewisLogic/saddle/merges","archive_url":"https://api.github.com/repos/mLewisLogic/saddle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mLewisLogic/saddle/downloads","issues_url":"https://api.github.com/repos/mLewisLogic/saddle/issues{/number}","pulls_url":"https://api.github.com/repos/mLewisLogic/saddle/pulls{/number}","milestones_url":"https://api.github.com/repos/mLewisLogic/saddle/milestones{/number}","notifications_url":"https://api.github.com/repos/mLewisLogic/saddle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mLewisLogic/saddle/labels{/name}","releases_url":"https://api.github.com/repos/mLewisLogic/saddle/releases{/id}","created_at":"2013-03-08T00:04:42Z","updated_at":"2015-02-09T00:53:30Z","pushed_at":"2015-06-30T23:58:09Z","git_url":"git://github.com/mLewisLogic/saddle.git","ssh_url":"git@github.com:mLewisLogic/saddle.git","clone_url":"https://github.com/mLewisLogic/saddle.git","svn_url":"https://github.com/mLewisLogic/saddle","homepage":"","size":719,"stargazers_count":40,"watchers_count":40,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":40,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mLewisLogic/saddle/pulls/14"},"html":{"href":"https://github.com/mLewisLogic/saddle/pull/14"},"issue":{"href":"https://api.github.com/repos/mLewisLogic/saddle/issues/14"},"comments":{"href":"https://api.github.com/repos/mLewisLogic/saddle/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/mLewisLogic/saddle/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/mLewisLogic/saddle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mLewisLogic/saddle/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/mLewisLogic/saddle/statuses/fd5791b36d8ecb69d590fa8cb886ffcff61b8a6a"}}}}