{"action":"created","issue":{"url":"https://api.github.com/repos/OSVR/OSVR-Core/issues/232","labels_url":"https://api.github.com/repos/OSVR/OSVR-Core/issues/232/labels{/name}","comments_url":"https://api.github.com/repos/OSVR/OSVR-Core/issues/232/comments","events_url":"https://api.github.com/repos/OSVR/OSVR-Core/issues/232/events","html_url":"https://github.com/OSVR/OSVR-Core/pull/232","id":110119493,"number":232,"title":"Adjust FindSDL2 to hopefully be able to find the framework on Mac.","user":{"login":"rpavlik","id":61129,"avatar_url":"https://avatars.githubusercontent.com/u/61129?v=3","gravatar_id":"","url":"https://api.github.com/users/rpavlik","html_url":"https://github.com/rpavlik","followers_url":"https://api.github.com/users/rpavlik/followers","following_url":"https://api.github.com/users/rpavlik/following{/other_user}","gists_url":"https://api.github.com/users/rpavlik/gists{/gist_id}","starred_url":"https://api.github.com/users/rpavlik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpavlik/subscriptions","organizations_url":"https://api.github.com/users/rpavlik/orgs","repos_url":"https://api.github.com/users/rpavlik/repos","events_url":"https://api.github.com/users/rpavlik/events{/privacy}","received_events_url":"https://api.github.com/users/rpavlik/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/OSVR/OSVR-Core/labels/in%20progress","name":"in progress","color":"ededed"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-10-06T23:01:33Z","updated_at":"2015-10-07T16:26:16Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/OSVR/OSVR-Core/pulls/232","html_url":"https://github.com/OSVR/OSVR-Core/pull/232","diff_url":"https://github.com/OSVR/OSVR-Core/pull/232.diff","patch_url":"https://github.com/OSVR/OSVR-Core/pull/232.patch"},"body":"cc @d235j - hopefully you can test this. It should follow/respect the preferences set in CMake regarding whether to find frameworks first, last, never, and should also correctly handle linking to cocoa."},"comment":{"url":"https://api.github.com/repos/OSVR/OSVR-Core/issues/comments/146252299","html_url":"https://github.com/OSVR/OSVR-Core/pull/232#issuecomment-146252299","issue_url":"https://api.github.com/repos/OSVR/OSVR-Core/issues/232","id":146252299,"user":{"login":"d235j","id":44988,"avatar_url":"https://avatars.githubusercontent.com/u/44988?v=3","gravatar_id":"","url":"https://api.github.com/users/d235j","html_url":"https://github.com/d235j","followers_url":"https://api.github.com/users/d235j/followers","following_url":"https://api.github.com/users/d235j/following{/other_user}","gists_url":"https://api.github.com/users/d235j/gists{/gist_id}","starred_url":"https://api.github.com/users/d235j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d235j/subscriptions","organizations_url":"https://api.github.com/users/d235j/orgs","repos_url":"https://api.github.com/users/d235j/repos","events_url":"https://api.github.com/users/d235j/events{/privacy}","received_events_url":"https://api.github.com/users/d235j/received_events","type":"User","site_admin":false},"created_at":"2015-10-07T16:26:16Z","updated_at":"2015-10-07T16:26:16Z","body":"Yeah, that report is out of date. It does look like Apple's breaking changes are very recent — possibly appearing in Xcode 7 and OS 10.11, which was released as a beta in June and has just hit general availability a week ago.\r\n\r\nI don't have a problem with the existing script, as long as is responds to SDL2DIR which it seems like it does.\r\n\r\nAs for SDL2Main, it seems their approach is to use the SDL2_BUILDING_LIBRARY flag for things that don't need SDL2Main...\r\n\r\nRegarding frameworks, I was considering potentially building OSVR as a framework, but that is a discussion that doesn't really belong here at this time."}}