{"action":"opened","number":82,"pull_request":{"url":"https://api.github.com/repos/formapro/JsFormValidatorBundle/pulls/82","id":34357415,"html_url":"https://github.com/formapro/JsFormValidatorBundle/pull/82","diff_url":"https://github.com/formapro/JsFormValidatorBundle/pull/82.diff","patch_url":"https://github.com/formapro/JsFormValidatorBundle/pull/82.patch","issue_url":"https://api.github.com/repos/formapro/JsFormValidatorBundle/issues/82","number":82,"state":"open","locked":false,"title":"allow empty dates, fixes #33","user":{"login":"hanneskaeufler","id":68024,"avatar_url":"https://avatars.githubusercontent.com/u/68024?v=3","gravatar_id":"","url":"https://api.github.com/users/hanneskaeufler","html_url":"https://github.com/hanneskaeufler","followers_url":"https://api.github.com/users/hanneskaeufler/followers","following_url":"https://api.github.com/users/hanneskaeufler/following{/other_user}","gists_url":"https://api.github.com/users/hanneskaeufler/gists{/gist_id}","starred_url":"https://api.github.com/users/hanneskaeufler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hanneskaeufler/subscriptions","organizations_url":"https://api.github.com/users/hanneskaeufler/orgs","repos_url":"https://api.github.com/users/hanneskaeufler/repos","events_url":"https://api.github.com/users/hanneskaeufler/events{/privacy}","received_events_url":"https://api.github.com/users/hanneskaeufler/received_events","type":"User","site_admin":false},"body":"This pr fixes issue #33, which makes empty dates valid if the field is not required.\r\n\r\nIt also adds karma as a test runner for javascript tests, so smaller fixes to constraints, transformers etc. do not have to be verified with slow functional tests.\r\n\r\nYou need to\r\n\r\n```shell\r\nnpm install -g karma-cli && npm install && karma start\r\n```\r\n\r\nto run the tests. We could also use the PhantomJS to run those specs with travis.","created_at":"2015-04-29T12:26:58Z","updated_at":"2015-04-29T12:26:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/formapro/JsFormValidatorBundle/pulls/82/commits","review_comments_url":"https://api.github.com/repos/formapro/JsFormValidatorBundle/pulls/82/comments","review_comment_url":"https://api.github.com/repos/formapro/JsFormValidatorBundle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/formapro/JsFormValidatorBundle/issues/82/comments","statuses_url":"https://api.github.com/repos/formapro/JsFormValidatorBundle/statuses/793dbcff038836eae9e6107cdbc51ed8620f1a48","head":{"label":"hanneskaeufler:hk-issue-33","ref":"hk-issue-33","sha":"793dbcff038836eae9e6107cdbc51ed8620f1a48","user":{"login":"hanneskaeufler","id":68024,"avatar_url":"https://avatars.githubusercontent.com/u/68024?v=3","gravatar_id":"","url":"https://api.github.com/users/hanneskaeufler","html_url":"https://github.com/hanneskaeufler","followers_url":"https://api.github.com/users/hanneskaeufler/followers","following_url":"https://api.github.com/users/hanneskaeufler/following{/other_user}","gists_url":"https://api.github.com/users/hanneskaeufler/gists{/gist_id}","starred_url":"https://api.github.com/users/hanneskaeufler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hanneskaeufler/subscriptions","organizations_url":"https://api.github.com/users/hanneskaeufler/orgs","repos_url":"https://api.github.com/users/hanneskaeufler/repos","events_url":"https://api.github.com/users/hanneskaeufler/events{/privacy}","received_events_url":"https://api.github.com/users/hanneskaeufler/received_events","type":"User","site_admin":false},"repo":{"id":34785086,"name":"JsFormValidatorBundle","full_name":"hanneskaeufler/JsFormValidatorBundle","owner":{"login":"hanneskaeufler","id":68024,"avatar_url":"https://avatars.githubusercontent.com/u/68024?v=3","gravatar_id":"","url":"https://api.github.com/users/hanneskaeufler","html_url":"https://github.com/hanneskaeufler","followers_url":"https://api.github.com/users/hanneskaeufler/followers","following_url":"https://api.github.com/users/hanneskaeufler/following{/other_user}","gists_url":"https://api.github.com/users/hanneskaeufler/gists{/gist_id}","starred_url":"https://api.github.com/users/hanneskaeufler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hanneskaeufler/subscriptions","organizations_url":"https://api.github.com/users/hanneskaeufler/orgs","repos_url":"https://api.github.com/users/hanneskaeufler/repos","events_url":"https://api.github.com/users/hanneskaeufler/events{/privacy}","received_events_url":"https://api.github.com/users/hanneskaeufler/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hanneskaeufler/JsFormValidatorBundle","description":"The Javascript validation for sf2 forms","fork":true,"url":"https://api.github.com/repos/hanneskaeufler/JsFormValidatorBundle","forks_url":"https://api.github.com/repos/hanneskaeufler/JsFormValidatorBundle/forks","keys_url":"https://api.github.com/repos/hanneskaeufler/JsFormValidatorBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hanneskaeufler/JsFormValidatorBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hanneskaeufler/JsFormValidatorBundle/teams","hooks_url":"https://api.github.com/repos/hanneskaeufler/JsFormValidatorBundle/hooks","issue_events_url":"https://api.github.com/repos/hanneskaeufler/JsFormValidatorBundle/issues/events{/number}","events_url":"https://api.github.com/repos/hanneskaeufler/JsFormValidatorBundle/events","assignees_url":"https://api.github.com/repos/hanneskaeufler/JsFormValidatorBundle/assignees{/user}","branches_url":"https://api.github.com/repos/hanneskaeufler/JsFormValidatorBundle/branches{/branch}","tags_url":"https://api.github.com/repos/hanneskaeufler/JsFormValidatorBundle/tags","blobs_url":"https://api.github.com/repos/hanneskaeufler/JsFormValidatorBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hanneskaeufler/JsFormValidatorBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hanneskaeufler/JsFormValidatorBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/hanneskaeufler/JsFormValidatorBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hanneskaeufler/JsFormValidatorBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/hanneskaeufler/JsFormValidatorBundle/languages","stargazers_url":"https://api.github.com/repos/hanneskaeufler/JsFormValidatorBundle/stargazers","contributors_url":"https://api.github.com/repos/hanneskaeufler/JsFormValidatorBundle/contributors","subscribers_url":"https://api.github.com/repos/hanneskaeufler/JsFormValidatorBundle/subscribers","subscription_url":"https://api.github.com/repos/hanneskaeufler/JsFormValidatorBundle/subscription","commits_url":"https://api.github.com/repos/hanneskaeufler/JsFormValidatorBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/hanneskaeufler/JsFormValidatorBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/hanneskaeufler/JsFormValidatorBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/hanneskaeufler/JsFormValidatorBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/hanneskaeufler/JsFormValidatorBundle/contents/{+path}","compare_url":"https://api.github.com/repos/hanneskaeufler/JsFormValidatorBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hanneskaeufler/JsFormValidatorBundle/merges","archive_url":"https://api.github.com/repos/hanneskaeufler/JsFormValidatorBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hanneskaeufler/JsFormValidatorBundle/downloads","issues_url":"https://api.github.com/repos/hanneskaeufler/JsFormValidatorBundle/issues{/number}","pulls_url":"https://api.github.com/repos/hanneskaeufler/JsFormValidatorBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/hanneskaeufler/JsFormValidatorBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/hanneskaeufler/JsFormValidatorBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hanneskaeufler/JsFormValidatorBundle/labels{/name}","releases_url":"https://api.github.com/repos/hanneskaeufler/JsFormValidatorBundle/releases{/id}","created_at":"2015-04-29T09:32:30Z","updated_at":"2015-04-29T09:32:31Z","pushed_at":"2015-04-29T12:23:52Z","git_url":"git://github.com/hanneskaeufler/JsFormValidatorBundle.git","ssh_url":"git@github.com:hanneskaeufler/JsFormValidatorBundle.git","clone_url":"https://github.com/hanneskaeufler/JsFormValidatorBundle.git","svn_url":"https://github.com/hanneskaeufler/JsFormValidatorBundle","homepage":"","size":1629,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"formapro:master","ref":"master","sha":"ffe1ae014eeb7acbbca1e03bf3866a0e984fccab","user":{"login":"formapro","id":783375,"avatar_url":"https://avatars.githubusercontent.com/u/783375?v=3","gravatar_id":"","url":"https://api.github.com/users/formapro","html_url":"https://github.com/formapro","followers_url":"https://api.github.com/users/formapro/followers","following_url":"https://api.github.com/users/formapro/following{/other_user}","gists_url":"https://api.github.com/users/formapro/gists{/gist_id}","starred_url":"https://api.github.com/users/formapro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/formapro/subscriptions","organizations_url":"https://api.github.com/users/formapro/orgs","repos_url":"https://api.github.com/users/formapro/repos","events_url":"https://api.github.com/users/formapro/events{/privacy}","received_events_url":"https://api.github.com/users/formapro/received_events","type":"Organization","site_admin":false},"repo":{"id":13801966,"name":"JsFormValidatorBundle","full_name":"formapro/JsFormValidatorBundle","owner":{"login":"formapro","id":783375,"avatar_url":"https://avatars.githubusercontent.com/u/783375?v=3","gravatar_id":"","url":"https://api.github.com/users/formapro","html_url":"https://github.com/formapro","followers_url":"https://api.github.com/users/formapro/followers","following_url":"https://api.github.com/users/formapro/following{/other_user}","gists_url":"https://api.github.com/users/formapro/gists{/gist_id}","starred_url":"https://api.github.com/users/formapro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/formapro/subscriptions","organizations_url":"https://api.github.com/users/formapro/orgs","repos_url":"https://api.github.com/users/formapro/repos","events_url":"https://api.github.com/users/formapro/events{/privacy}","received_events_url":"https://api.github.com/users/formapro/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/formapro/JsFormValidatorBundle","description":"The Javascript validation for sf2 forms","fork":false,"url":"https://api.github.com/repos/formapro/JsFormValidatorBundle","forks_url":"https://api.github.com/repos/formapro/JsFormValidatorBundle/forks","keys_url":"https://api.github.com/repos/formapro/JsFormValidatorBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/formapro/JsFormValidatorBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/formapro/JsFormValidatorBundle/teams","hooks_url":"https://api.github.com/repos/formapro/JsFormValidatorBundle/hooks","issue_events_url":"https://api.github.com/repos/formapro/JsFormValidatorBundle/issues/events{/number}","events_url":"https://api.github.com/repos/formapro/JsFormValidatorBundle/events","assignees_url":"https://api.github.com/repos/formapro/JsFormValidatorBundle/assignees{/user}","branches_url":"https://api.github.com/repos/formapro/JsFormValidatorBundle/branches{/branch}","tags_url":"https://api.github.com/repos/formapro/JsFormValidatorBundle/tags","blobs_url":"https://api.github.com/repos/formapro/JsFormValidatorBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/formapro/JsFormValidatorBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/formapro/JsFormValidatorBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/formapro/JsFormValidatorBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/formapro/JsFormValidatorBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/formapro/JsFormValidatorBundle/languages","stargazers_url":"https://api.github.com/repos/formapro/JsFormValidatorBundle/stargazers","contributors_url":"https://api.github.com/repos/formapro/JsFormValidatorBundle/contributors","subscribers_url":"https://api.github.com/repos/formapro/JsFormValidatorBundle/subscribers","subscription_url":"https://api.github.com/repos/formapro/JsFormValidatorBundle/subscription","commits_url":"https://api.github.com/repos/formapro/JsFormValidatorBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/formapro/JsFormValidatorBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/formapro/JsFormValidatorBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/formapro/JsFormValidatorBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/formapro/JsFormValidatorBundle/contents/{+path}","compare_url":"https://api.github.com/repos/formapro/JsFormValidatorBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/formapro/JsFormValidatorBundle/merges","archive_url":"https://api.github.com/repos/formapro/JsFormValidatorBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/formapro/JsFormValidatorBundle/downloads","issues_url":"https://api.github.com/repos/formapro/JsFormValidatorBundle/issues{/number}","pulls_url":"https://api.github.com/repos/formapro/JsFormValidatorBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/formapro/JsFormValidatorBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/formapro/JsFormValidatorBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/formapro/JsFormValidatorBundle/labels{/name}","releases_url":"https://api.github.com/repos/formapro/JsFormValidatorBundle/releases{/id}","created_at":"2013-10-23T12:20:52Z","updated_at":"2015-04-22T20:40:39Z","pushed_at":"2015-04-21T11:39:51Z","git_url":"git://github.com/formapro/JsFormValidatorBundle.git","ssh_url":"git@github.com:formapro/JsFormValidatorBundle.git","clone_url":"https://github.com/formapro/JsFormValidatorBundle.git","svn_url":"https://github.com/formapro/JsFormValidatorBundle","homepage":"","size":1629,"stargazers_count":56,"watchers_count":56,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"open_issues_count":31,"forks":26,"open_issues":31,"watchers":56,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/formapro/JsFormValidatorBundle/pulls/82"},"html":{"href":"https://github.com/formapro/JsFormValidatorBundle/pull/82"},"issue":{"href":"https://api.github.com/repos/formapro/JsFormValidatorBundle/issues/82"},"comments":{"href":"https://api.github.com/repos/formapro/JsFormValidatorBundle/issues/82/comments"},"review_comments":{"href":"https://api.github.com/repos/formapro/JsFormValidatorBundle/pulls/82/comments"},"review_comment":{"href":"https://api.github.com/repos/formapro/JsFormValidatorBundle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/formapro/JsFormValidatorBundle/pulls/82/commits"},"statuses":{"href":"https://api.github.com/repos/formapro/JsFormValidatorBundle/statuses/793dbcff038836eae9e6107cdbc51ed8620f1a48"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":167,"deletions":4,"changed_files":5}}