{"action":"created","issue":{"url":"https://api.github.com/repos/brigade/scss-lint/issues/557","labels_url":"https://api.github.com/repos/brigade/scss-lint/issues/557/labels{/name}","comments_url":"https://api.github.com/repos/brigade/scss-lint/issues/557/comments","events_url":"https://api.github.com/repos/brigade/scss-lint/issues/557/events","html_url":"https://github.com/brigade/scss-lint/pull/557","id":101458517,"number":557,"title":"Adds linter for transition all (#556)","user":{"login":"baileyparker","id":7943649,"avatar_url":"https://avatars.githubusercontent.com/u/7943649?v=3","gravatar_id":"","url":"https://api.github.com/users/baileyparker","html_url":"https://github.com/baileyparker","followers_url":"https://api.github.com/users/baileyparker/followers","following_url":"https://api.github.com/users/baileyparker/following{/other_user}","gists_url":"https://api.github.com/users/baileyparker/gists{/gist_id}","starred_url":"https://api.github.com/users/baileyparker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baileyparker/subscriptions","organizations_url":"https://api.github.com/users/baileyparker/orgs","repos_url":"https://api.github.com/users/baileyparker/repos","events_url":"https://api.github.com/users/baileyparker/events{/privacy}","received_events_url":"https://api.github.com/users/baileyparker/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/brigade/scss-lint/labels/enhancement","name":"enhancement","color":"bfe5bf"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-08-17T16:23:06Z","updated_at":"2015-08-19T04:40:07Z","closed_at":"2015-08-19T04:40:07Z","pull_request":{"url":"https://api.github.com/repos/brigade/scss-lint/pulls/557","html_url":"https://github.com/brigade/scss-lint/pull/557","diff_url":"https://github.com/brigade/scss-lint/pull/557.diff","patch_url":"https://github.com/brigade/scss-lint/pull/557.patch"},"body":"This PR addresses #556 by adding a `TransitionAll` linter that enforces explicit declaration of properties to be transitioned instead of using `transition: all` or `transition-property: all` (discussion about the validity of this preference can be found in the issue).\r\n\r\nI have set the linter to be disabled by default, because I wasn't sure if it should be enabled. I think it's a fairly common sense linter to enable, but if there is a compelling reason why it shouldn't be, it can be left as is.\r\n\r\nI've updated the docs and tried to add as helpful of error messages as possible. The best I could come up with was:\r\n\r\n> {transition/transition-property} should contain explicit properties instead of using the keyword all\r\n\r\nI'm definitely open to alternative phrasings, though.\r\n\r\nAlso one thing to note: To test if the `all` keyword is used, I've done a word-boundaried regex on the value of `transition` or `transition-property`. This of course could report false positives in very strange cases, but it seems like this approach is used by other linters, so I assumed it was accepted. If there is a better way though, I'd love to hear about it."},"comment":{"url":"https://api.github.com/repos/brigade/scss-lint/issues/comments/132443908","html_url":"https://github.com/brigade/scss-lint/pull/557#issuecomment-132443908","issue_url":"https://api.github.com/repos/brigade/scss-lint/issues/557","id":132443908,"user":{"login":"sds","id":677877,"avatar_url":"https://avatars.githubusercontent.com/u/677877?v=3","gravatar_id":"","url":"https://api.github.com/users/sds","html_url":"https://github.com/sds","followers_url":"https://api.github.com/users/sds/followers","following_url":"https://api.github.com/users/sds/following{/other_user}","gists_url":"https://api.github.com/users/sds/gists{/gist_id}","starred_url":"https://api.github.com/users/sds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sds/subscriptions","organizations_url":"https://api.github.com/users/sds/orgs","repos_url":"https://api.github.com/users/sds/repos","events_url":"https://api.github.com/users/sds/events{/privacy}","received_events_url":"https://api.github.com/users/sds/received_events","type":"User","site_admin":false},"created_at":"2015-08-19T04:40:07Z","updated_at":"2015-08-19T04:40:07Z","body":"Thanks! Merged in 62641033111fb3f2dc08cc6a1c0c0fc5237a1e41."}}