{"action":"created","issue":{"url":"https://api.github.com/repos/citation-style-language/styles/issues/1822","labels_url":"https://api.github.com/repos/citation-style-language/styles/issues/1822/labels{/name}","comments_url":"https://api.github.com/repos/citation-style-language/styles/issues/1822/comments","events_url":"https://api.github.com/repos/citation-style-language/styles/issues/1822/events","html_url":"https://github.com/citation-style-language/styles/pull/1822","id":121828703,"number":1822,"title":"Include entry-dictionary/entry-encyclopedia with book sections","user":{"login":"adunning","id":1084407,"avatar_url":"https://avatars.githubusercontent.com/u/1084407?v=3","gravatar_id":"","url":"https://api.github.com/users/adunning","html_url":"https://github.com/adunning","followers_url":"https://api.github.com/users/adunning/followers","following_url":"https://api.github.com/users/adunning/following{/other_user}","gists_url":"https://api.github.com/users/adunning/gists{/gist_id}","starred_url":"https://api.github.com/users/adunning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adunning/subscriptions","organizations_url":"https://api.github.com/users/adunning/orgs","repos_url":"https://api.github.com/users/adunning/repos","events_url":"https://api.github.com/users/adunning/events{/privacy}","received_events_url":"https://api.github.com/users/adunning/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-12-12T02:40:37Z","updated_at":"2015-12-12T02:40:38Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/citation-style-language/styles/pulls/1822","html_url":"https://github.com/citation-style-language/styles/pull/1822","diff_url":"https://github.com/citation-style-language/styles/pull/1822.diff","patch_url":"https://github.com/citation-style-language/styles/pull/1822.patch"},"body":"Generally speaking, entry-dictionary and entry-encyclopedia are conceived as a type of book section. These were latecomers to CSL, and do not seem to have been properly included in the appropriate macros for most styles. This is most notably manifested by printing the secondary contributors before the container title.\r\n\r\nI have found that this can be fixed in all styles I have tested by replacing `\"chapter paper-conference\"` with `\"chapter entry-dictionary entry-encyclopedia paper-conference\"`, and this pull request applies this across the entire repository. I have not found any ill effects, but would strongly recommend further scrutiny.\r\n\r\nFor instance, if one runs this example through chicago-author-date.csl:\r\n\r\n```json\r\n{\"id\":\"test\",\"type\":\"entry-encyclopedia\",\"title\":\"Test Entry\",\"container-title\":\"The Test Encyclopedia\",\"publisher\":\"Citeproc\",\"publisher-place\":\"Oxford\",\"editor\":[{\"family\":\"Smith\",\"given\":\"Adam\"}],\"author\":[{\"family\":\"Smith\",\"given\":\"Adam\"}],\"issued\":{\"date-parts\":[[2004]]}}\r\n```\r\n\r\nThis is the result before these changes:\r\n\r\n> Smith, Adam. 2004. “Test Entry.” Edited by Adam Smith. <em>The Test Encyclopedia</em>. Oxford: Citeproc.\r\n\r\nWhereas this is expected:\r\n\r\n> Smith, Adam. 2004. “Test Entry.” <em>The Test Encyclopedia</em>. Edited by Adam Smith. Oxford: Citeproc."},"comment":{"url":"https://api.github.com/repos/citation-style-language/styles/issues/comments/164102707","html_url":"https://github.com/citation-style-language/styles/pull/1822#issuecomment-164102707","issue_url":"https://api.github.com/repos/citation-style-language/styles/issues/1822","id":164102707,"user":{"login":"csl-bot","id":6621735,"avatar_url":"https://avatars.githubusercontent.com/u/6621735?v=3","gravatar_id":"","url":"https://api.github.com/users/csl-bot","html_url":"https://github.com/csl-bot","followers_url":"https://api.github.com/users/csl-bot/followers","following_url":"https://api.github.com/users/csl-bot/following{/other_user}","gists_url":"https://api.github.com/users/csl-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/csl-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csl-bot/subscriptions","organizations_url":"https://api.github.com/users/csl-bot/orgs","repos_url":"https://api.github.com/users/csl-bot/repos","events_url":"https://api.github.com/users/csl-bot/events{/privacy}","received_events_url":"https://api.github.com/users/csl-bot/received_events","type":"User","site_admin":false},"created_at":"2015-12-12T02:40:38Z","updated_at":"2015-12-12T02:40:38Z","body":"Awesome! You've created a pull request to the Citation Styles Language styles repository. We'll get in touch soon (usually within a day or two). In the meantime, our automated test system will go ahead and run some checks on your pull request. In a few minutes you'll be notified of the test results.\n\nIf you haven't done so yet, please make sure your style [validates](https://github.com/citation-style-language/styles/wiki/Validation) and follows all our other [Style Requirements](https://github.com/citation-style-language/styles/wiki/Style-Requirements).\n\nTo update the current pull request, visit the \"Files changed\" tab above. Then click the \"View\" button of the file you wish to change, and click on the pencil icon (see below) that appears in the next screen to start editing.\n\n![image](https://cloud.githubusercontent.com/assets/77951/10228312/da729b6a-683f-11e5-8219-748562173ae8.png)\n\nIf you need assistance at any point, please leave a comment and we'll get back to you (feel free to write in Dutch, English, French, German, Portuguese, or Spanish).\n"}}