{"action":"closed","issue":{"url":"https://api.github.com/repos/survivejs/webpack_react/issues/128","labels_url":"https://api.github.com/repos/survivejs/webpack_react/issues/128/labels{/name}","comments_url":"https://api.github.com/repos/survivejs/webpack_react/issues/128/comments","events_url":"https://api.github.com/repos/survivejs/webpack_react/issues/128/events","html_url":"https://github.com/survivejs/webpack_react/issues/128","id":97313194,"number":128,"title":"Feedback on \"From Notes to Kanban\"","user":{"login":"Foxandxss","id":1087957,"avatar_url":"https://avatars.githubusercontent.com/u/1087957?v=3","gravatar_id":"","url":"https://api.github.com/users/Foxandxss","html_url":"https://github.com/Foxandxss","followers_url":"https://api.github.com/users/Foxandxss/followers","following_url":"https://api.github.com/users/Foxandxss/following{/other_user}","gists_url":"https://api.github.com/users/Foxandxss/gists{/gist_id}","starred_url":"https://api.github.com/users/Foxandxss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Foxandxss/subscriptions","organizations_url":"https://api.github.com/users/Foxandxss/orgs","repos_url":"https://api.github.com/users/Foxandxss/repos","events_url":"https://api.github.com/users/Foxandxss/events{/privacy}","received_events_url":"https://api.github.com/users/Foxandxss/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/survivejs/webpack_react/milestones/1","html_url":"https://github.com/survivejs/webpack_react/milestones/v1.5.0","labels_url":"https://api.github.com/repos/survivejs/webpack_react/milestones/1/labels","id":1225709,"number":1,"title":"v1.5.0","description":"Intermediate public release focusing on polish.","creator":{"login":"bebraw","id":166921,"avatar_url":"https://avatars.githubusercontent.com/u/166921?v=3","gravatar_id":"","url":"https://api.github.com/users/bebraw","html_url":"https://github.com/bebraw","followers_url":"https://api.github.com/users/bebraw/followers","following_url":"https://api.github.com/users/bebraw/following{/other_user}","gists_url":"https://api.github.com/users/bebraw/gists{/gist_id}","starred_url":"https://api.github.com/users/bebraw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bebraw/subscriptions","organizations_url":"https://api.github.com/users/bebraw/orgs","repos_url":"https://api.github.com/users/bebraw/repos","events_url":"https://api.github.com/users/bebraw/events{/privacy}","received_events_url":"https://api.github.com/users/bebraw/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":26,"state":"closed","created_at":"2015-07-25T17:56:08Z","updated_at":"2015-08-17T18:23:21Z","due_on":"2015-07-30T21:00:00Z","closed_at":"2015-08-02T14:48:01Z"},"comments":2,"created_at":"2015-07-26T12:40:38Z","updated_at":"2015-08-17T18:23:21Z","closed_at":"2015-08-17T18:23:21Z","body":"As I did with #109, I will give a overview of this chapter to talk about the rough edges I see.\r\n\r\nThis chapter relies on \"React and Flux\" to have better explanations because some of the code in here does the same.\r\n\r\n### Extracting Lanes\r\n\r\nFirst, you modified  `App.jsx` to now use `alt.takeSnapshot()` but there is no reason behind that and I think that `takeSnapshot` was mentioned like once as a curiosity so this needs much more explanation and reasoning behind the change.\r\n\r\nWhen you modify the storage, it is always a good idea to note what changes did you do on it. Something like \"We added a function here so we can grab the initial data from a storage in one place\". I think it is a good practice not to assume that the reader knows your intentions (even if it is dead simple).\r\n\r\n### Going from Note Singletons to Instances\r\n\r\nWhen changing `NoteActions` to export a function that will generate a new set of actions, I would like an explanation in there.\r\n\r\nAfter the big snippet of `Lane`, a general discussion of the changes is in place. (The verbal explanation we talked about).\r\n\r\n### Implementing Edit/Remove for Lane\r\n\r\nThis section is pretty good, there is more verbal explanations of all the steps and it is really easy to follow."}}