{"action":"created","comment":{"url":"https://api.github.com/repos/Addepar/ember-widgets/pulls/comments/29599517","id":29599517,"diff_hunk":"@@ -166,8 +182,7 @@ Ember.AddeparMixins.ResizeHandlerMixin,\n   # TODO(Peter): consider calling this optionViewClass?\n   itemView: Ember.computed ->\n     itemViewClass = @get 'itemViewClass'\n-    if typeof itemViewClass is 'string'\n-      return Ember.get itemViewClass\n+    return Ember.get itemViewClass if typeof itemViewClass is 'string'","path":"src/select.coffee","position":70,"original_position":70,"commit_id":"d8cb07ea0ed161913fc8d6bda2b675c9d69331cf","original_commit_id":"d8cb07ea0ed161913fc8d6bda2b675c9d69331cf","user":{"login":"cyril-sf","id":743977,"avatar_url":"https://avatars.githubusercontent.com/u/743977?v=3","gravatar_id":"","url":"https://api.github.com/users/cyril-sf","html_url":"https://github.com/cyril-sf","followers_url":"https://api.github.com/users/cyril-sf/followers","following_url":"https://api.github.com/users/cyril-sf/following{/other_user}","gists_url":"https://api.github.com/users/cyril-sf/gists{/gist_id}","starred_url":"https://api.github.com/users/cyril-sf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyril-sf/subscriptions","organizations_url":"https://api.github.com/users/cyril-sf/orgs","repos_url":"https://api.github.com/users/cyril-sf/repos","events_url":"https://api.github.com/users/cyril-sf/events{/privacy}","received_events_url":"https://api.github.com/users/cyril-sf/received_events","type":"User","site_admin":false},"body":"Not a huge fan of this. This assumes that the string represents the global path to the class. But you didn't write it, so we can revisit that later.","created_at":"2015-05-04T16:36:46Z","updated_at":"2015-05-04T16:36:46Z","html_url":"https://github.com/Addepar/ember-widgets/pull/166#discussion_r29599517","pull_request_url":"https://api.github.com/repos/Addepar/ember-widgets/pulls/166","_links":{"self":{"href":"https://api.github.com/repos/Addepar/ember-widgets/pulls/comments/29599517"},"html":{"href":"https://github.com/Addepar/ember-widgets/pull/166#discussion_r29599517"},"pull_request":{"href":"https://api.github.com/repos/Addepar/ember-widgets/pulls/166"}}},"pull_request":{"url":"https://api.github.com/repos/Addepar/ember-widgets/pulls/166","id":27452455,"html_url":"https://github.com/Addepar/ember-widgets/pull/166","diff_url":"https://github.com/Addepar/ember-widgets/pull/166.diff","patch_url":"https://github.com/Addepar/ember-widgets/pull/166.patch","issue_url":"https://api.github.com/repos/Addepar/ember-widgets/issues/166","number":166,"state":"open","locked":false,"title":"Improve usability of Select component","user":{"login":"thangdinh","id":8838366,"avatar_url":"https://avatars.githubusercontent.com/u/8838366?v=3","gravatar_id":"","url":"https://api.github.com/users/thangdinh","html_url":"https://github.com/thangdinh","followers_url":"https://api.github.com/users/thangdinh/followers","following_url":"https://api.github.com/users/thangdinh/following{/other_user}","gists_url":"https://api.github.com/users/thangdinh/gists{/gist_id}","starred_url":"https://api.github.com/users/thangdinh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thangdinh/subscriptions","organizations_url":"https://api.github.com/users/thangdinh/orgs","repos_url":"https://api.github.com/users/thangdinh/repos","events_url":"https://api.github.com/users/thangdinh/events{/privacy}","received_events_url":"https://api.github.com/users/thangdinh/received_events","type":"User","site_admin":false},"body":"Basically, I would like to make select component now tabbable.  I also changed the behavior of pressing any key will show the dropdown, because it seems to be uncommon to show the dropdown when we press special keys such as: shift, capslock, F1,F2...\r\nPlease help me review it @igillis @azirbel @hanakimis \r\nThank you.","created_at":"2015-01-15T18:56:05Z","updated_at":"2015-05-04T16:36:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9f89039abc7fceb0cd3767a0897c3f375edda996","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Addepar/ember-widgets/pulls/166/commits","review_comments_url":"https://api.github.com/repos/Addepar/ember-widgets/pulls/166/comments","review_comment_url":"https://api.github.com/repos/Addepar/ember-widgets/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Addepar/ember-widgets/issues/166/comments","statuses_url":"https://api.github.com/repos/Addepar/ember-widgets/statuses/d8cb07ea0ed161913fc8d6bda2b675c9d69331cf","head":{"label":"Addepar:thang/selectUsability","ref":"thang/selectUsability","sha":"d8cb07ea0ed161913fc8d6bda2b675c9d69331cf","user":{"login":"Addepar","id":847867,"avatar_url":"https://avatars.githubusercontent.com/u/847867?v=3","gravatar_id":"","url":"https://api.github.com/users/Addepar","html_url":"https://github.com/Addepar","followers_url":"https://api.github.com/users/Addepar/followers","following_url":"https://api.github.com/users/Addepar/following{/other_user}","gists_url":"https://api.github.com/users/Addepar/gists{/gist_id}","starred_url":"https://api.github.com/users/Addepar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Addepar/subscriptions","organizations_url":"https://api.github.com/users/Addepar/orgs","repos_url":"https://api.github.com/users/Addepar/repos","events_url":"https://api.github.com/users/Addepar/events{/privacy}","received_events_url":"https://api.github.com/users/Addepar/received_events","type":"Organization","site_admin":false},"repo":{"id":13793634,"name":"ember-widgets","full_name":"Addepar/ember-widgets","owner":{"login":"Addepar","id":847867,"avatar_url":"https://avatars.githubusercontent.com/u/847867?v=3","gravatar_id":"","url":"https://api.github.com/users/Addepar","html_url":"https://github.com/Addepar","followers_url":"https://api.github.com/users/Addepar/followers","following_url":"https://api.github.com/users/Addepar/following{/other_user}","gists_url":"https://api.github.com/users/Addepar/gists{/gist_id}","starred_url":"https://api.github.com/users/Addepar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Addepar/subscriptions","organizations_url":"https://api.github.com/users/Addepar/orgs","repos_url":"https://api.github.com/users/Addepar/repos","events_url":"https://api.github.com/users/Addepar/events{/privacy}","received_events_url":"https://api.github.com/users/Addepar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Addepar/ember-widgets","description":"","fork":false,"url":"https://api.github.com/repos/Addepar/ember-widgets","forks_url":"https://api.github.com/repos/Addepar/ember-widgets/forks","keys_url":"https://api.github.com/repos/Addepar/ember-widgets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Addepar/ember-widgets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Addepar/ember-widgets/teams","hooks_url":"https://api.github.com/repos/Addepar/ember-widgets/hooks","issue_events_url":"https://api.github.com/repos/Addepar/ember-widgets/issues/events{/number}","events_url":"https://api.github.com/repos/Addepar/ember-widgets/events","assignees_url":"https://api.github.com/repos/Addepar/ember-widgets/assignees{/user}","branches_url":"https://api.github.com/repos/Addepar/ember-widgets/branches{/branch}","tags_url":"https://api.github.com/repos/Addepar/ember-widgets/tags","blobs_url":"https://api.github.com/repos/Addepar/ember-widgets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Addepar/ember-widgets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Addepar/ember-widgets/git/refs{/sha}","trees_url":"https://api.github.com/repos/Addepar/ember-widgets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Addepar/ember-widgets/statuses/{sha}","languages_url":"https://api.github.com/repos/Addepar/ember-widgets/languages","stargazers_url":"https://api.github.com/repos/Addepar/ember-widgets/stargazers","contributors_url":"https://api.github.com/repos/Addepar/ember-widgets/contributors","subscribers_url":"https://api.github.com/repos/Addepar/ember-widgets/subscribers","subscription_url":"https://api.github.com/repos/Addepar/ember-widgets/subscription","commits_url":"https://api.github.com/repos/Addepar/ember-widgets/commits{/sha}","git_commits_url":"https://api.github.com/repos/Addepar/ember-widgets/git/commits{/sha}","comments_url":"https://api.github.com/repos/Addepar/ember-widgets/comments{/number}","issue_comment_url":"https://api.github.com/repos/Addepar/ember-widgets/issues/comments{/number}","contents_url":"https://api.github.com/repos/Addepar/ember-widgets/contents/{+path}","compare_url":"https://api.github.com/repos/Addepar/ember-widgets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Addepar/ember-widgets/merges","archive_url":"https://api.github.com/repos/Addepar/ember-widgets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Addepar/ember-widgets/downloads","issues_url":"https://api.github.com/repos/Addepar/ember-widgets/issues{/number}","pulls_url":"https://api.github.com/repos/Addepar/ember-widgets/pulls{/number}","milestones_url":"https://api.github.com/repos/Addepar/ember-widgets/milestones{/number}","notifications_url":"https://api.github.com/repos/Addepar/ember-widgets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Addepar/ember-widgets/labels{/name}","releases_url":"https://api.github.com/repos/Addepar/ember-widgets/releases{/id}","created_at":"2013-10-23T04:39:36Z","updated_at":"2015-05-02T21:47:13Z","pushed_at":"2015-05-01T20:35:15Z","git_url":"git://github.com/Addepar/ember-widgets.git","ssh_url":"git@github.com:Addepar/ember-widgets.git","clone_url":"https://github.com/Addepar/ember-widgets.git","svn_url":"https://github.com/Addepar/ember-widgets","homepage":null,"size":16477,"stargazers_count":251,"watchers_count":251,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":75,"mirror_url":null,"open_issues_count":36,"forks":75,"open_issues":36,"watchers":251,"default_branch":"master"}},"base":{"label":"Addepar:master","ref":"master","sha":"7bcd28203da5e8b254d173d43547926fff0d0938","user":{"login":"Addepar","id":847867,"avatar_url":"https://avatars.githubusercontent.com/u/847867?v=3","gravatar_id":"","url":"https://api.github.com/users/Addepar","html_url":"https://github.com/Addepar","followers_url":"https://api.github.com/users/Addepar/followers","following_url":"https://api.github.com/users/Addepar/following{/other_user}","gists_url":"https://api.github.com/users/Addepar/gists{/gist_id}","starred_url":"https://api.github.com/users/Addepar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Addepar/subscriptions","organizations_url":"https://api.github.com/users/Addepar/orgs","repos_url":"https://api.github.com/users/Addepar/repos","events_url":"https://api.github.com/users/Addepar/events{/privacy}","received_events_url":"https://api.github.com/users/Addepar/received_events","type":"Organization","site_admin":false},"repo":{"id":13793634,"name":"ember-widgets","full_name":"Addepar/ember-widgets","owner":{"login":"Addepar","id":847867,"avatar_url":"https://avatars.githubusercontent.com/u/847867?v=3","gravatar_id":"","url":"https://api.github.com/users/Addepar","html_url":"https://github.com/Addepar","followers_url":"https://api.github.com/users/Addepar/followers","following_url":"https://api.github.com/users/Addepar/following{/other_user}","gists_url":"https://api.github.com/users/Addepar/gists{/gist_id}","starred_url":"https://api.github.com/users/Addepar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Addepar/subscriptions","organizations_url":"https://api.github.com/users/Addepar/orgs","repos_url":"https://api.github.com/users/Addepar/repos","events_url":"https://api.github.com/users/Addepar/events{/privacy}","received_events_url":"https://api.github.com/users/Addepar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Addepar/ember-widgets","description":"","fork":false,"url":"https://api.github.com/repos/Addepar/ember-widgets","forks_url":"https://api.github.com/repos/Addepar/ember-widgets/forks","keys_url":"https://api.github.com/repos/Addepar/ember-widgets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Addepar/ember-widgets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Addepar/ember-widgets/teams","hooks_url":"https://api.github.com/repos/Addepar/ember-widgets/hooks","issue_events_url":"https://api.github.com/repos/Addepar/ember-widgets/issues/events{/number}","events_url":"https://api.github.com/repos/Addepar/ember-widgets/events","assignees_url":"https://api.github.com/repos/Addepar/ember-widgets/assignees{/user}","branches_url":"https://api.github.com/repos/Addepar/ember-widgets/branches{/branch}","tags_url":"https://api.github.com/repos/Addepar/ember-widgets/tags","blobs_url":"https://api.github.com/repos/Addepar/ember-widgets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Addepar/ember-widgets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Addepar/ember-widgets/git/refs{/sha}","trees_url":"https://api.github.com/repos/Addepar/ember-widgets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Addepar/ember-widgets/statuses/{sha}","languages_url":"https://api.github.com/repos/Addepar/ember-widgets/languages","stargazers_url":"https://api.github.com/repos/Addepar/ember-widgets/stargazers","contributors_url":"https://api.github.com/repos/Addepar/ember-widgets/contributors","subscribers_url":"https://api.github.com/repos/Addepar/ember-widgets/subscribers","subscription_url":"https://api.github.com/repos/Addepar/ember-widgets/subscription","commits_url":"https://api.github.com/repos/Addepar/ember-widgets/commits{/sha}","git_commits_url":"https://api.github.com/repos/Addepar/ember-widgets/git/commits{/sha}","comments_url":"https://api.github.com/repos/Addepar/ember-widgets/comments{/number}","issue_comment_url":"https://api.github.com/repos/Addepar/ember-widgets/issues/comments{/number}","contents_url":"https://api.github.com/repos/Addepar/ember-widgets/contents/{+path}","compare_url":"https://api.github.com/repos/Addepar/ember-widgets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Addepar/ember-widgets/merges","archive_url":"https://api.github.com/repos/Addepar/ember-widgets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Addepar/ember-widgets/downloads","issues_url":"https://api.github.com/repos/Addepar/ember-widgets/issues{/number}","pulls_url":"https://api.github.com/repos/Addepar/ember-widgets/pulls{/number}","milestones_url":"https://api.github.com/repos/Addepar/ember-widgets/milestones{/number}","notifications_url":"https://api.github.com/repos/Addepar/ember-widgets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Addepar/ember-widgets/labels{/name}","releases_url":"https://api.github.com/repos/Addepar/ember-widgets/releases{/id}","created_at":"2013-10-23T04:39:36Z","updated_at":"2015-05-02T21:47:13Z","pushed_at":"2015-05-01T20:35:15Z","git_url":"git://github.com/Addepar/ember-widgets.git","ssh_url":"git@github.com:Addepar/ember-widgets.git","clone_url":"https://github.com/Addepar/ember-widgets.git","svn_url":"https://github.com/Addepar/ember-widgets","homepage":null,"size":16477,"stargazers_count":251,"watchers_count":251,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":75,"mirror_url":null,"open_issues_count":36,"forks":75,"open_issues":36,"watchers":251,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Addepar/ember-widgets/pulls/166"},"html":{"href":"https://github.com/Addepar/ember-widgets/pull/166"},"issue":{"href":"https://api.github.com/repos/Addepar/ember-widgets/issues/166"},"comments":{"href":"https://api.github.com/repos/Addepar/ember-widgets/issues/166/comments"},"review_comments":{"href":"https://api.github.com/repos/Addepar/ember-widgets/pulls/166/comments"},"review_comment":{"href":"https://api.github.com/repos/Addepar/ember-widgets/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Addepar/ember-widgets/pulls/166/commits"},"statuses":{"href":"https://api.github.com/repos/Addepar/ember-widgets/statuses/d8cb07ea0ed161913fc8d6bda2b675c9d69331cf"}}}}