{"action":"created","issue":{"url":"https://api.github.com/repos/getgrav/grav/issues/188","labels_url":"https://api.github.com/repos/getgrav/grav/issues/188/labels{/name}","comments_url":"https://api.github.com/repos/getgrav/grav/issues/188/comments","events_url":"https://api.github.com/repos/getgrav/grav/issues/188/events","html_url":"https://github.com/getgrav/grav/pull/188","id":73409156,"number":188,"title":"Added resumable download support","user":{"login":"Sommerregen","id":9073307,"avatar_url":"https://avatars.githubusercontent.com/u/9073307?v=3","gravatar_id":"","url":"https://api.github.com/users/Sommerregen","html_url":"https://github.com/Sommerregen","followers_url":"https://api.github.com/users/Sommerregen/followers","following_url":"https://api.github.com/users/Sommerregen/following{/other_user}","gists_url":"https://api.github.com/users/Sommerregen/gists{/gist_id}","starred_url":"https://api.github.com/users/Sommerregen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sommerregen/subscriptions","organizations_url":"https://api.github.com/users/Sommerregen/orgs","repos_url":"https://api.github.com/users/Sommerregen/repos","events_url":"https://api.github.com/users/Sommerregen/events{/privacy}","received_events_url":"https://api.github.com/users/Sommerregen/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-05-05T19:28:01Z","updated_at":"2015-05-06T18:25:35Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/getgrav/grav/pulls/188","html_url":"https://github.com/getgrav/grav/pull/188","diff_url":"https://github.com/getgrav/grav/pull/188.diff","patch_url":"https://github.com/getgrav/grav/pull/188.patch"},"body":"Hi @rhukster,\r\n\r\nthis PR adds a resumable download support into Grav. It supports a download limit as well as a qualitity parameter called `download.balance` to tune the download rate (num flushes versus memory size used for buffering). Further it polishes the `getMimeType` method (having speed in mind) and adds support for more mime types."},"comment":{"url":"https://api.github.com/repos/getgrav/grav/issues/comments/99561801","html_url":"https://github.com/getgrav/grav/pull/188#issuecomment-99561801","issue_url":"https://api.github.com/repos/getgrav/grav/issues/188","id":99561801,"user":{"login":"rhukster","id":1084697,"avatar_url":"https://avatars.githubusercontent.com/u/1084697?v=3","gravatar_id":"","url":"https://api.github.com/users/rhukster","html_url":"https://github.com/rhukster","followers_url":"https://api.github.com/users/rhukster/followers","following_url":"https://api.github.com/users/rhukster/following{/other_user}","gists_url":"https://api.github.com/users/rhukster/gists{/gist_id}","starred_url":"https://api.github.com/users/rhukster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhukster/subscriptions","organizations_url":"https://api.github.com/users/rhukster/orgs","repos_url":"https://api.github.com/users/rhukster/repos","events_url":"https://api.github.com/users/rhukster/events{/privacy}","received_events_url":"https://api.github.com/users/rhukster/received_events","type":"User","site_admin":false},"created_at":"2015-05-06T18:25:35Z","updated_at":"2015-05-06T18:25:35Z","body":"This is interesting benny.  One thing I would like to see before merging, is that this be off by default and something you can enabled. Resumable downloads are great for large files, but the download() method is also used to download/send other files including images.  it needs to work optimally and fast for small files too.  There's a lot of work going on here to support the resumable that is only going to add overhead in the majority of cases."}}