{"action":"created","comment":{"url":"https://api.github.com/repos/HOST-Oman/libraqm/pulls/comments/47952475","id":47952475,"diff_hunk":"@@ -457,30 +461,34 @@ raqm_shape_u32 (unsigned int* u32_str,\n                 raqm_direction_t direction)\n {\n     int i = 0;\n-    FriBidiCharType* types;\n-    FriBidiLevel* levels;\n-    FriBidiParType par_type;\n-    hb_script_t* scripts;\n-    hb_unicode_funcs_t* unicode_funcs;\n-    hb_script_t last_script_value;\n-    int last_script_index = -1;\n-    int last_set_index = -1;\n-    Stack* script_stack;\n+    int j = 0;","path":"raqm.c","position":279,"original_position":279,"commit_id":"3c0eb5efa85489ca720e5ebd999f66f0a8961098","original_commit_id":"3c0eb5efa85489ca720e5ebd999f66f0a8961098","user":{"login":"khaledhosny","id":93914,"avatar_url":"https://avatars.githubusercontent.com/u/93914?v=3","gravatar_id":"","url":"https://api.github.com/users/khaledhosny","html_url":"https://github.com/khaledhosny","followers_url":"https://api.github.com/users/khaledhosny/followers","following_url":"https://api.github.com/users/khaledhosny/following{/other_user}","gists_url":"https://api.github.com/users/khaledhosny/gists{/gist_id}","starred_url":"https://api.github.com/users/khaledhosny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khaledhosny/subscriptions","organizations_url":"https://api.github.com/users/khaledhosny/orgs","repos_url":"https://api.github.com/users/khaledhosny/repos","events_url":"https://api.github.com/users/khaledhosny/events{/privacy}","received_events_url":"https://api.github.com/users/khaledhosny/received_events","type":"User","site_admin":false},"body":"This variable is only used in the for loop below, so it is better be declared there. You just need to move it to the top of the block to fix the compiler warning.","created_at":"2015-12-17T19:52:40Z","updated_at":"2015-12-17T19:52:40Z","html_url":"https://github.com/HOST-Oman/libraqm/pull/25#discussion_r47952475","pull_request_url":"https://api.github.com/repos/HOST-Oman/libraqm/pulls/25","_links":{"self":{"href":"https://api.github.com/repos/HOST-Oman/libraqm/pulls/comments/47952475"},"html":{"href":"https://github.com/HOST-Oman/libraqm/pull/25#discussion_r47952475"},"pull_request":{"href":"https://api.github.com/repos/HOST-Oman/libraqm/pulls/25"}}},"pull_request":{"url":"https://api.github.com/repos/HOST-Oman/libraqm/pulls/25","id":53982483,"html_url":"https://github.com/HOST-Oman/libraqm/pull/25","diff_url":"https://github.com/HOST-Oman/libraqm/pull/25.diff","patch_url":"https://github.com/HOST-Oman/libraqm/pull/25.patch","issue_url":"https://api.github.com/repos/HOST-Oman/libraqm/issues/25","number":25,"state":"open","locked":false,"title":"Code cleanup and compiler warn fixs","user":{"login":"abderraouf-adjal","id":2000728,"avatar_url":"https://avatars.githubusercontent.com/u/2000728?v=3","gravatar_id":"","url":"https://api.github.com/users/abderraouf-adjal","html_url":"https://github.com/abderraouf-adjal","followers_url":"https://api.github.com/users/abderraouf-adjal/followers","following_url":"https://api.github.com/users/abderraouf-adjal/following{/other_user}","gists_url":"https://api.github.com/users/abderraouf-adjal/gists{/gist_id}","starred_url":"https://api.github.com/users/abderraouf-adjal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abderraouf-adjal/subscriptions","organizations_url":"https://api.github.com/users/abderraouf-adjal/orgs","repos_url":"https://api.github.com/users/abderraouf-adjal/repos","events_url":"https://api.github.com/users/abderraouf-adjal/events{/privacy}","received_events_url":"https://api.github.com/users/abderraouf-adjal/received_events","type":"User","site_admin":false},"body":"I fixed a lot of compiler warnings when compile with the flags:\r\n\r\n`-W -Wall -Wextra -Wformat=2 -Wstrict-prototypes -Wimplicit-function-declaration -Wredundant-decls -Wdeclaration-after-statement -Wconversion -Wsign-conversion -Winit-self -Wundef -Wshadow -Wpointer-arith -Wreturn-type -Wsign-compare -Wmultichar -Wformat-nonliteral -Wuninitialized -Wformat-security -pedantic`\r\n\r\nAlso there is a warning when compile with `-O1` or `-O2`, I did not try to fix it.","created_at":"2015-12-17T14:30:14Z","updated_at":"2015-12-17T19:52:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a70e9a4a7c0c84533c87e8ba3d995d85e184cdf3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/HOST-Oman/libraqm/pulls/25/commits","review_comments_url":"https://api.github.com/repos/HOST-Oman/libraqm/pulls/25/comments","review_comment_url":"https://api.github.com/repos/HOST-Oman/libraqm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/HOST-Oman/libraqm/issues/25/comments","statuses_url":"https://api.github.com/repos/HOST-Oman/libraqm/statuses/3c0eb5efa85489ca720e5ebd999f66f0a8961098","head":{"label":"abderraouf-adjal:master","ref":"master","sha":"3c0eb5efa85489ca720e5ebd999f66f0a8961098","user":{"login":"abderraouf-adjal","id":2000728,"avatar_url":"https://avatars.githubusercontent.com/u/2000728?v=3","gravatar_id":"","url":"https://api.github.com/users/abderraouf-adjal","html_url":"https://github.com/abderraouf-adjal","followers_url":"https://api.github.com/users/abderraouf-adjal/followers","following_url":"https://api.github.com/users/abderraouf-adjal/following{/other_user}","gists_url":"https://api.github.com/users/abderraouf-adjal/gists{/gist_id}","starred_url":"https://api.github.com/users/abderraouf-adjal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abderraouf-adjal/subscriptions","organizations_url":"https://api.github.com/users/abderraouf-adjal/orgs","repos_url":"https://api.github.com/users/abderraouf-adjal/repos","events_url":"https://api.github.com/users/abderraouf-adjal/events{/privacy}","received_events_url":"https://api.github.com/users/abderraouf-adjal/received_events","type":"User","site_admin":false},"repo":{"id":48172019,"name":"libraqm","full_name":"abderraouf-adjal/libraqm","owner":{"login":"abderraouf-adjal","id":2000728,"avatar_url":"https://avatars.githubusercontent.com/u/2000728?v=3","gravatar_id":"","url":"https://api.github.com/users/abderraouf-adjal","html_url":"https://github.com/abderraouf-adjal","followers_url":"https://api.github.com/users/abderraouf-adjal/followers","following_url":"https://api.github.com/users/abderraouf-adjal/following{/other_user}","gists_url":"https://api.github.com/users/abderraouf-adjal/gists{/gist_id}","starred_url":"https://api.github.com/users/abderraouf-adjal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abderraouf-adjal/subscriptions","organizations_url":"https://api.github.com/users/abderraouf-adjal/orgs","repos_url":"https://api.github.com/users/abderraouf-adjal/repos","events_url":"https://api.github.com/users/abderraouf-adjal/events{/privacy}","received_events_url":"https://api.github.com/users/abderraouf-adjal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/abderraouf-adjal/libraqm","description":"A library for complex text layout","fork":true,"url":"https://api.github.com/repos/abderraouf-adjal/libraqm","forks_url":"https://api.github.com/repos/abderraouf-adjal/libraqm/forks","keys_url":"https://api.github.com/repos/abderraouf-adjal/libraqm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/abderraouf-adjal/libraqm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/abderraouf-adjal/libraqm/teams","hooks_url":"https://api.github.com/repos/abderraouf-adjal/libraqm/hooks","issue_events_url":"https://api.github.com/repos/abderraouf-adjal/libraqm/issues/events{/number}","events_url":"https://api.github.com/repos/abderraouf-adjal/libraqm/events","assignees_url":"https://api.github.com/repos/abderraouf-adjal/libraqm/assignees{/user}","branches_url":"https://api.github.com/repos/abderraouf-adjal/libraqm/branches{/branch}","tags_url":"https://api.github.com/repos/abderraouf-adjal/libraqm/tags","blobs_url":"https://api.github.com/repos/abderraouf-adjal/libraqm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/abderraouf-adjal/libraqm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/abderraouf-adjal/libraqm/git/refs{/sha}","trees_url":"https://api.github.com/repos/abderraouf-adjal/libraqm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/abderraouf-adjal/libraqm/statuses/{sha}","languages_url":"https://api.github.com/repos/abderraouf-adjal/libraqm/languages","stargazers_url":"https://api.github.com/repos/abderraouf-adjal/libraqm/stargazers","contributors_url":"https://api.github.com/repos/abderraouf-adjal/libraqm/contributors","subscribers_url":"https://api.github.com/repos/abderraouf-adjal/libraqm/subscribers","subscription_url":"https://api.github.com/repos/abderraouf-adjal/libraqm/subscription","commits_url":"https://api.github.com/repos/abderraouf-adjal/libraqm/commits{/sha}","git_commits_url":"https://api.github.com/repos/abderraouf-adjal/libraqm/git/commits{/sha}","comments_url":"https://api.github.com/repos/abderraouf-adjal/libraqm/comments{/number}","issue_comment_url":"https://api.github.com/repos/abderraouf-adjal/libraqm/issues/comments{/number}","contents_url":"https://api.github.com/repos/abderraouf-adjal/libraqm/contents/{+path}","compare_url":"https://api.github.com/repos/abderraouf-adjal/libraqm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/abderraouf-adjal/libraqm/merges","archive_url":"https://api.github.com/repos/abderraouf-adjal/libraqm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/abderraouf-adjal/libraqm/downloads","issues_url":"https://api.github.com/repos/abderraouf-adjal/libraqm/issues{/number}","pulls_url":"https://api.github.com/repos/abderraouf-adjal/libraqm/pulls{/number}","milestones_url":"https://api.github.com/repos/abderraouf-adjal/libraqm/milestones{/number}","notifications_url":"https://api.github.com/repos/abderraouf-adjal/libraqm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/abderraouf-adjal/libraqm/labels{/name}","releases_url":"https://api.github.com/repos/abderraouf-adjal/libraqm/releases{/id}","created_at":"2015-12-17T12:02:27Z","updated_at":"2015-12-17T12:02:28Z","pushed_at":"2015-12-17T14:24:53Z","git_url":"git://github.com/abderraouf-adjal/libraqm.git","ssh_url":"git@github.com:abderraouf-adjal/libraqm.git","clone_url":"https://github.com/abderraouf-adjal/libraqm.git","svn_url":"https://github.com/abderraouf-adjal/libraqm","homepage":"","size":370,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"HOST-Oman:master","ref":"master","sha":"67cf83dacfce5ef731bf62c407b4e07e0821e1ef","user":{"login":"HOST-Oman","id":16079338,"avatar_url":"https://avatars.githubusercontent.com/u/16079338?v=3","gravatar_id":"","url":"https://api.github.com/users/HOST-Oman","html_url":"https://github.com/HOST-Oman","followers_url":"https://api.github.com/users/HOST-Oman/followers","following_url":"https://api.github.com/users/HOST-Oman/following{/other_user}","gists_url":"https://api.github.com/users/HOST-Oman/gists{/gist_id}","starred_url":"https://api.github.com/users/HOST-Oman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HOST-Oman/subscriptions","organizations_url":"https://api.github.com/users/HOST-Oman/orgs","repos_url":"https://api.github.com/users/HOST-Oman/repos","events_url":"https://api.github.com/users/HOST-Oman/events{/privacy}","received_events_url":"https://api.github.com/users/HOST-Oman/received_events","type":"Organization","site_admin":false},"repo":{"id":47186392,"name":"libraqm","full_name":"HOST-Oman/libraqm","owner":{"login":"HOST-Oman","id":16079338,"avatar_url":"https://avatars.githubusercontent.com/u/16079338?v=3","gravatar_id":"","url":"https://api.github.com/users/HOST-Oman","html_url":"https://github.com/HOST-Oman","followers_url":"https://api.github.com/users/HOST-Oman/followers","following_url":"https://api.github.com/users/HOST-Oman/following{/other_user}","gists_url":"https://api.github.com/users/HOST-Oman/gists{/gist_id}","starred_url":"https://api.github.com/users/HOST-Oman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HOST-Oman/subscriptions","organizations_url":"https://api.github.com/users/HOST-Oman/orgs","repos_url":"https://api.github.com/users/HOST-Oman/repos","events_url":"https://api.github.com/users/HOST-Oman/events{/privacy}","received_events_url":"https://api.github.com/users/HOST-Oman/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HOST-Oman/libraqm","description":"A library for complex text layout","fork":false,"url":"https://api.github.com/repos/HOST-Oman/libraqm","forks_url":"https://api.github.com/repos/HOST-Oman/libraqm/forks","keys_url":"https://api.github.com/repos/HOST-Oman/libraqm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HOST-Oman/libraqm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HOST-Oman/libraqm/teams","hooks_url":"https://api.github.com/repos/HOST-Oman/libraqm/hooks","issue_events_url":"https://api.github.com/repos/HOST-Oman/libraqm/issues/events{/number}","events_url":"https://api.github.com/repos/HOST-Oman/libraqm/events","assignees_url":"https://api.github.com/repos/HOST-Oman/libraqm/assignees{/user}","branches_url":"https://api.github.com/repos/HOST-Oman/libraqm/branches{/branch}","tags_url":"https://api.github.com/repos/HOST-Oman/libraqm/tags","blobs_url":"https://api.github.com/repos/HOST-Oman/libraqm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HOST-Oman/libraqm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HOST-Oman/libraqm/git/refs{/sha}","trees_url":"https://api.github.com/repos/HOST-Oman/libraqm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HOST-Oman/libraqm/statuses/{sha}","languages_url":"https://api.github.com/repos/HOST-Oman/libraqm/languages","stargazers_url":"https://api.github.com/repos/HOST-Oman/libraqm/stargazers","contributors_url":"https://api.github.com/repos/HOST-Oman/libraqm/contributors","subscribers_url":"https://api.github.com/repos/HOST-Oman/libraqm/subscribers","subscription_url":"https://api.github.com/repos/HOST-Oman/libraqm/subscription","commits_url":"https://api.github.com/repos/HOST-Oman/libraqm/commits{/sha}","git_commits_url":"https://api.github.com/repos/HOST-Oman/libraqm/git/commits{/sha}","comments_url":"https://api.github.com/repos/HOST-Oman/libraqm/comments{/number}","issue_comment_url":"https://api.github.com/repos/HOST-Oman/libraqm/issues/comments{/number}","contents_url":"https://api.github.com/repos/HOST-Oman/libraqm/contents/{+path}","compare_url":"https://api.github.com/repos/HOST-Oman/libraqm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HOST-Oman/libraqm/merges","archive_url":"https://api.github.com/repos/HOST-Oman/libraqm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HOST-Oman/libraqm/downloads","issues_url":"https://api.github.com/repos/HOST-Oman/libraqm/issues{/number}","pulls_url":"https://api.github.com/repos/HOST-Oman/libraqm/pulls{/number}","milestones_url":"https://api.github.com/repos/HOST-Oman/libraqm/milestones{/number}","notifications_url":"https://api.github.com/repos/HOST-Oman/libraqm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HOST-Oman/libraqm/labels{/name}","releases_url":"https://api.github.com/repos/HOST-Oman/libraqm/releases{/id}","created_at":"2015-12-01T11:56:54Z","updated_at":"2015-12-16T09:24:06Z","pushed_at":"2015-12-17T14:30:14Z","git_url":"git://github.com/HOST-Oman/libraqm.git","ssh_url":"git@github.com:HOST-Oman/libraqm.git","clone_url":"https://github.com/HOST-Oman/libraqm.git","svn_url":"https://github.com/HOST-Oman/libraqm","homepage":"","size":376,"stargazers_count":7,"watchers_count":7,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":4,"forks":8,"open_issues":4,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/HOST-Oman/libraqm/pulls/25"},"html":{"href":"https://github.com/HOST-Oman/libraqm/pull/25"},"issue":{"href":"https://api.github.com/repos/HOST-Oman/libraqm/issues/25"},"comments":{"href":"https://api.github.com/repos/HOST-Oman/libraqm/issues/25/comments"},"review_comments":{"href":"https://api.github.com/repos/HOST-Oman/libraqm/pulls/25/comments"},"review_comment":{"href":"https://api.github.com/repos/HOST-Oman/libraqm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/HOST-Oman/libraqm/pulls/25/commits"},"statuses":{"href":"https://api.github.com/repos/HOST-Oman/libraqm/statuses/3c0eb5efa85489ca720e5ebd999f66f0a8961098"}}}}