{"action":"opened","number":362,"pull_request":{"url":"https://api.github.com/repos/tavendo/AutobahnPython/pulls/362","id":31280835,"html_url":"https://github.com/tavendo/AutobahnPython/pull/362","diff_url":"https://github.com/tavendo/AutobahnPython/pull/362.diff","patch_url":"https://github.com/tavendo/AutobahnPython/pull/362.patch","issue_url":"https://api.github.com/repos/tavendo/AutobahnPython/issues/362","number":362,"state":"open","locked":false,"title":"Sync and async error handling","user":{"login":"meejah","id":145599,"avatar_url":"https://avatars.githubusercontent.com/u/145599?v=3","gravatar_id":"","url":"https://api.github.com/users/meejah","html_url":"https://github.com/meejah","followers_url":"https://api.github.com/users/meejah/followers","following_url":"https://api.github.com/users/meejah/following{/other_user}","gists_url":"https://api.github.com/users/meejah/gists{/gist_id}","starred_url":"https://api.github.com/users/meejah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meejah/subscriptions","organizations_url":"https://api.github.com/users/meejah/orgs","repos_url":"https://api.github.com/users/meejah/repos","events_url":"https://api.github.com/users/meejah/events{/privacy}","received_events_url":"https://api.github.com/users/meejah/received_events","type":"User","site_admin":false},"body":"This is a portion of #358 with just the sync and async error-handling and logging added (i.e. it doesn't change the ``onUserError`` or errback APIs).\r\n\r\nSince there was a bug in onProgress versus on_progress, this in in here as well; I can take that out as well if you like (it's in a separate commit).\r\n\r\nIt does make a slight change to ``_add_future_callbacks()`` API so that you can pass ``None`` as a callback in order to provde a way to add *just* an errback.\r\n\r\nNote that I re-based the unit-tests to (all) be in a separate commit from the code-changes. Is it better to have the unit-tests in the same commit as the code-changes?","created_at":"2015-03-16T20:24:05Z","updated_at":"2015-03-16T20:24:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/tavendo/AutobahnPython/pulls/362/commits","review_comments_url":"https://api.github.com/repos/tavendo/AutobahnPython/pulls/362/comments","review_comment_url":"https://api.github.com/repos/tavendo/AutobahnPython/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tavendo/AutobahnPython/issues/362/comments","statuses_url":"https://api.github.com/repos/tavendo/AutobahnPython/statuses/1cda3252d9c54e4cea980b112cfbeeafce9e9712","head":{"label":"meejah:sync-and-async-error-handling","ref":"sync-and-async-error-handling","sha":"1cda3252d9c54e4cea980b112cfbeeafce9e9712","user":{"login":"meejah","id":145599,"avatar_url":"https://avatars.githubusercontent.com/u/145599?v=3","gravatar_id":"","url":"https://api.github.com/users/meejah","html_url":"https://github.com/meejah","followers_url":"https://api.github.com/users/meejah/followers","following_url":"https://api.github.com/users/meejah/following{/other_user}","gists_url":"https://api.github.com/users/meejah/gists{/gist_id}","starred_url":"https://api.github.com/users/meejah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meejah/subscriptions","organizations_url":"https://api.github.com/users/meejah/orgs","repos_url":"https://api.github.com/users/meejah/repos","events_url":"https://api.github.com/users/meejah/events{/privacy}","received_events_url":"https://api.github.com/users/meejah/received_events","type":"User","site_admin":false},"repo":{"id":30720845,"name":"AutobahnPython","full_name":"meejah/AutobahnPython","owner":{"login":"meejah","id":145599,"avatar_url":"https://avatars.githubusercontent.com/u/145599?v=3","gravatar_id":"","url":"https://api.github.com/users/meejah","html_url":"https://github.com/meejah","followers_url":"https://api.github.com/users/meejah/followers","following_url":"https://api.github.com/users/meejah/following{/other_user}","gists_url":"https://api.github.com/users/meejah/gists{/gist_id}","starred_url":"https://api.github.com/users/meejah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meejah/subscriptions","organizations_url":"https://api.github.com/users/meejah/orgs","repos_url":"https://api.github.com/users/meejah/repos","events_url":"https://api.github.com/users/meejah/events{/privacy}","received_events_url":"https://api.github.com/users/meejah/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/meejah/AutobahnPython","description":"WebSocket & WAMP for Python on Twisted and asyncio","fork":true,"url":"https://api.github.com/repos/meejah/AutobahnPython","forks_url":"https://api.github.com/repos/meejah/AutobahnPython/forks","keys_url":"https://api.github.com/repos/meejah/AutobahnPython/keys{/key_id}","collaborators_url":"https://api.github.com/repos/meejah/AutobahnPython/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/meejah/AutobahnPython/teams","hooks_url":"https://api.github.com/repos/meejah/AutobahnPython/hooks","issue_events_url":"https://api.github.com/repos/meejah/AutobahnPython/issues/events{/number}","events_url":"https://api.github.com/repos/meejah/AutobahnPython/events","assignees_url":"https://api.github.com/repos/meejah/AutobahnPython/assignees{/user}","branches_url":"https://api.github.com/repos/meejah/AutobahnPython/branches{/branch}","tags_url":"https://api.github.com/repos/meejah/AutobahnPython/tags","blobs_url":"https://api.github.com/repos/meejah/AutobahnPython/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/meejah/AutobahnPython/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/meejah/AutobahnPython/git/refs{/sha}","trees_url":"https://api.github.com/repos/meejah/AutobahnPython/git/trees{/sha}","statuses_url":"https://api.github.com/repos/meejah/AutobahnPython/statuses/{sha}","languages_url":"https://api.github.com/repos/meejah/AutobahnPython/languages","stargazers_url":"https://api.github.com/repos/meejah/AutobahnPython/stargazers","contributors_url":"https://api.github.com/repos/meejah/AutobahnPython/contributors","subscribers_url":"https://api.github.com/repos/meejah/AutobahnPython/subscribers","subscription_url":"https://api.github.com/repos/meejah/AutobahnPython/subscription","commits_url":"https://api.github.com/repos/meejah/AutobahnPython/commits{/sha}","git_commits_url":"https://api.github.com/repos/meejah/AutobahnPython/git/commits{/sha}","comments_url":"https://api.github.com/repos/meejah/AutobahnPython/comments{/number}","issue_comment_url":"https://api.github.com/repos/meejah/AutobahnPython/issues/comments{/number}","contents_url":"https://api.github.com/repos/meejah/AutobahnPython/contents/{+path}","compare_url":"https://api.github.com/repos/meejah/AutobahnPython/compare/{base}...{head}","merges_url":"https://api.github.com/repos/meejah/AutobahnPython/merges","archive_url":"https://api.github.com/repos/meejah/AutobahnPython/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/meejah/AutobahnPython/downloads","issues_url":"https://api.github.com/repos/meejah/AutobahnPython/issues{/number}","pulls_url":"https://api.github.com/repos/meejah/AutobahnPython/pulls{/number}","milestones_url":"https://api.github.com/repos/meejah/AutobahnPython/milestones{/number}","notifications_url":"https://api.github.com/repos/meejah/AutobahnPython/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/meejah/AutobahnPython/labels{/name}","releases_url":"https://api.github.com/repos/meejah/AutobahnPython/releases{/id}","created_at":"2015-02-12T19:58:50Z","updated_at":"2015-03-05T10:02:21Z","pushed_at":"2015-03-16T20:14:28Z","git_url":"git://github.com/meejah/AutobahnPython.git","ssh_url":"git@github.com:meejah/AutobahnPython.git","clone_url":"https://github.com/meejah/AutobahnPython.git","svn_url":"https://github.com/meejah/AutobahnPython","homepage":"http://autobahn.ws/python","size":9996,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tavendo:master","ref":"master","sha":"1f45ff8e2b96522d008311fe6f72c0ad7ffc0a24","user":{"login":"tavendo","id":1519673,"avatar_url":"https://avatars.githubusercontent.com/u/1519673?v=3","gravatar_id":"","url":"https://api.github.com/users/tavendo","html_url":"https://github.com/tavendo","followers_url":"https://api.github.com/users/tavendo/followers","following_url":"https://api.github.com/users/tavendo/following{/other_user}","gists_url":"https://api.github.com/users/tavendo/gists{/gist_id}","starred_url":"https://api.github.com/users/tavendo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tavendo/subscriptions","organizations_url":"https://api.github.com/users/tavendo/orgs","repos_url":"https://api.github.com/users/tavendo/repos","events_url":"https://api.github.com/users/tavendo/events{/privacy}","received_events_url":"https://api.github.com/users/tavendo/received_events","type":"Organization","site_admin":false},"repo":{"id":2113510,"name":"AutobahnPython","full_name":"tavendo/AutobahnPython","owner":{"login":"tavendo","id":1519673,"avatar_url":"https://avatars.githubusercontent.com/u/1519673?v=3","gravatar_id":"","url":"https://api.github.com/users/tavendo","html_url":"https://github.com/tavendo","followers_url":"https://api.github.com/users/tavendo/followers","following_url":"https://api.github.com/users/tavendo/following{/other_user}","gists_url":"https://api.github.com/users/tavendo/gists{/gist_id}","starred_url":"https://api.github.com/users/tavendo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tavendo/subscriptions","organizations_url":"https://api.github.com/users/tavendo/orgs","repos_url":"https://api.github.com/users/tavendo/repos","events_url":"https://api.github.com/users/tavendo/events{/privacy}","received_events_url":"https://api.github.com/users/tavendo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tavendo/AutobahnPython","description":"WebSocket & WAMP for Python on Twisted and asyncio","fork":false,"url":"https://api.github.com/repos/tavendo/AutobahnPython","forks_url":"https://api.github.com/repos/tavendo/AutobahnPython/forks","keys_url":"https://api.github.com/repos/tavendo/AutobahnPython/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tavendo/AutobahnPython/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tavendo/AutobahnPython/teams","hooks_url":"https://api.github.com/repos/tavendo/AutobahnPython/hooks","issue_events_url":"https://api.github.com/repos/tavendo/AutobahnPython/issues/events{/number}","events_url":"https://api.github.com/repos/tavendo/AutobahnPython/events","assignees_url":"https://api.github.com/repos/tavendo/AutobahnPython/assignees{/user}","branches_url":"https://api.github.com/repos/tavendo/AutobahnPython/branches{/branch}","tags_url":"https://api.github.com/repos/tavendo/AutobahnPython/tags","blobs_url":"https://api.github.com/repos/tavendo/AutobahnPython/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tavendo/AutobahnPython/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tavendo/AutobahnPython/git/refs{/sha}","trees_url":"https://api.github.com/repos/tavendo/AutobahnPython/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tavendo/AutobahnPython/statuses/{sha}","languages_url":"https://api.github.com/repos/tavendo/AutobahnPython/languages","stargazers_url":"https://api.github.com/repos/tavendo/AutobahnPython/stargazers","contributors_url":"https://api.github.com/repos/tavendo/AutobahnPython/contributors","subscribers_url":"https://api.github.com/repos/tavendo/AutobahnPython/subscribers","subscription_url":"https://api.github.com/repos/tavendo/AutobahnPython/subscription","commits_url":"https://api.github.com/repos/tavendo/AutobahnPython/commits{/sha}","git_commits_url":"https://api.github.com/repos/tavendo/AutobahnPython/git/commits{/sha}","comments_url":"https://api.github.com/repos/tavendo/AutobahnPython/comments{/number}","issue_comment_url":"https://api.github.com/repos/tavendo/AutobahnPython/issues/comments{/number}","contents_url":"https://api.github.com/repos/tavendo/AutobahnPython/contents/{+path}","compare_url":"https://api.github.com/repos/tavendo/AutobahnPython/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tavendo/AutobahnPython/merges","archive_url":"https://api.github.com/repos/tavendo/AutobahnPython/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tavendo/AutobahnPython/downloads","issues_url":"https://api.github.com/repos/tavendo/AutobahnPython/issues{/number}","pulls_url":"https://api.github.com/repos/tavendo/AutobahnPython/pulls{/number}","milestones_url":"https://api.github.com/repos/tavendo/AutobahnPython/milestones{/number}","notifications_url":"https://api.github.com/repos/tavendo/AutobahnPython/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tavendo/AutobahnPython/labels{/name}","releases_url":"https://api.github.com/repos/tavendo/AutobahnPython/releases{/id}","created_at":"2011-07-27T15:22:13Z","updated_at":"2015-03-16T17:53:42Z","pushed_at":"2015-03-16T17:53:42Z","git_url":"git://github.com/tavendo/AutobahnPython.git","ssh_url":"git@github.com:tavendo/AutobahnPython.git","clone_url":"https://github.com/tavendo/AutobahnPython.git","svn_url":"https://github.com/tavendo/AutobahnPython","homepage":"http://autobahn.ws/python","size":15590,"stargazers_count":690,"watchers_count":690,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":220,"mirror_url":null,"open_issues_count":52,"forks":220,"open_issues":52,"watchers":690,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tavendo/AutobahnPython/pulls/362"},"html":{"href":"https://github.com/tavendo/AutobahnPython/pull/362"},"issue":{"href":"https://api.github.com/repos/tavendo/AutobahnPython/issues/362"},"comments":{"href":"https://api.github.com/repos/tavendo/AutobahnPython/issues/362/comments"},"review_comments":{"href":"https://api.github.com/repos/tavendo/AutobahnPython/pulls/362/comments"},"review_comment":{"href":"https://api.github.com/repos/tavendo/AutobahnPython/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tavendo/AutobahnPython/pulls/362/commits"},"statuses":{"href":"https://api.github.com/repos/tavendo/AutobahnPython/statuses/1cda3252d9c54e4cea980b112cfbeeafce9e9712"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":4,"additions":728,"deletions":67,"changed_files":11}}