{"action":"closed","number":398,"pull_request":{"url":"https://api.github.com/repos/awesomeWM/awesome/pulls/398","id":41974764,"html_url":"https://github.com/awesomeWM/awesome/pull/398","diff_url":"https://github.com/awesomeWM/awesome/pull/398.diff","patch_url":"https://github.com/awesomeWM/awesome/pull/398.patch","issue_url":"https://api.github.com/repos/awesomeWM/awesome/issues/398","number":398,"state":"closed","locked":false,"title":"Widget context","user":{"login":"psychon","id":89482,"avatar_url":"https://avatars.githubusercontent.com/u/89482?v=3","gravatar_id":"","url":"https://api.github.com/users/psychon","html_url":"https://github.com/psychon","followers_url":"https://api.github.com/users/psychon/followers","following_url":"https://api.github.com/users/psychon/following{/other_user}","gists_url":"https://api.github.com/users/psychon/gists{/gist_id}","starred_url":"https://api.github.com/users/psychon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psychon/subscriptions","organizations_url":"https://api.github.com/users/psychon/orgs","repos_url":"https://api.github.com/users/psychon/repos","events_url":"https://api.github.com/users/psychon/events{/privacy}","received_events_url":"https://api.github.com/users/psychon/received_events","type":"User","site_admin":false},"body":"This changes the `wibox` argument that widgets get in `:draw` to a `context` table. This contains an (optional (needed for titlebars)) wibox key, the drawable etc. This also adds a `screen` and a `dpi` entry, allowing widgets to make their look depend on the DPI.\r\n\r\nTo also allow a widget size that depends on the dpi, the `:fit` callback is also changed to get this context argument (**this is an API change that can break configs**). Based on this @blueyed might implement DPI-support for the `textbox` widget.\r\n\r\nSince we cache the results of `:fit`, this code is careful not to break the cache. The same `context` table will be used as long as the `wibox.drawable` is not moved to another screen. This is enough so that the cache continues to work.\r\n\r\nIf we really change the widget API to allow partial redraws, another API break might follow later. Do we want bleeding edge users to live \"on a bumpy road\"?\r\n\r\n@blueyed This is mostly a request for comments. How much do you want the textbox to incorporate the DPI of the screen? Is it ok to break the API for this?\r\n\r\n@Elv13 API break. Opinions?","created_at":"2015-08-09T18:33:21Z","updated_at":"2015-08-23T13:37:46Z","closed_at":"2015-08-23T13:37:46Z","merged_at":"2015-08-23T13:37:46Z","merge_commit_sha":"60d24268442a8c2f9b42ad65afb76e9f45b8be5a","assignee":null,"milestone":{"url":"https://api.github.com/repos/awesomeWM/awesome/milestones/1","html_url":"https://github.com/awesomeWM/awesome/milestones/next:%20pull%20requests%20to%20be%20merged%20soon","labels_url":"https://api.github.com/repos/awesomeWM/awesome/milestones/1/labels","id":1069592,"number":1,"title":"next: pull requests to be merged soon","description":"Pending pull requests to be merged soon.","creator":{"login":"blueyed","id":9766,"avatar_url":"https://avatars.githubusercontent.com/u/9766?v=3","gravatar_id":"","url":"https://api.github.com/users/blueyed","html_url":"https://github.com/blueyed","followers_url":"https://api.github.com/users/blueyed/followers","following_url":"https://api.github.com/users/blueyed/following{/other_user}","gists_url":"https://api.github.com/users/blueyed/gists{/gist_id}","starred_url":"https://api.github.com/users/blueyed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blueyed/subscriptions","organizations_url":"https://api.github.com/users/blueyed/orgs","repos_url":"https://api.github.com/users/blueyed/repos","events_url":"https://api.github.com/users/blueyed/events{/privacy}","received_events_url":"https://api.github.com/users/blueyed/received_events","type":"User","site_admin":false},"open_issues":8,"closed_issues":84,"state":"open","created_at":"2015-04-15T22:58:10Z","updated_at":"2015-08-23T13:37:46Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/awesomeWM/awesome/pulls/398/commits","review_comments_url":"https://api.github.com/repos/awesomeWM/awesome/pulls/398/comments","review_comment_url":"https://api.github.com/repos/awesomeWM/awesome/pulls/comments{/number}","comments_url":"https://api.github.com/repos/awesomeWM/awesome/issues/398/comments","statuses_url":"https://api.github.com/repos/awesomeWM/awesome/statuses/1ebc34b5e9c31b82013ed7ef2c59716d31333267","head":{"label":"psychon:widget_context","ref":"widget_context","sha":"1ebc34b5e9c31b82013ed7ef2c59716d31333267","user":{"login":"psychon","id":89482,"avatar_url":"https://avatars.githubusercontent.com/u/89482?v=3","gravatar_id":"","url":"https://api.github.com/users/psychon","html_url":"https://github.com/psychon","followers_url":"https://api.github.com/users/psychon/followers","following_url":"https://api.github.com/users/psychon/following{/other_user}","gists_url":"https://api.github.com/users/psychon/gists{/gist_id}","starred_url":"https://api.github.com/users/psychon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psychon/subscriptions","organizations_url":"https://api.github.com/users/psychon/orgs","repos_url":"https://api.github.com/users/psychon/repos","events_url":"https://api.github.com/users/psychon/events{/privacy}","received_events_url":"https://api.github.com/users/psychon/received_events","type":"User","site_admin":false},"repo":{"id":28717216,"name":"awesome","full_name":"psychon/awesome","owner":{"login":"psychon","id":89482,"avatar_url":"https://avatars.githubusercontent.com/u/89482?v=3","gravatar_id":"","url":"https://api.github.com/users/psychon","html_url":"https://github.com/psychon","followers_url":"https://api.github.com/users/psychon/followers","following_url":"https://api.github.com/users/psychon/following{/other_user}","gists_url":"https://api.github.com/users/psychon/gists{/gist_id}","starred_url":"https://api.github.com/users/psychon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psychon/subscriptions","organizations_url":"https://api.github.com/users/psychon/orgs","repos_url":"https://api.github.com/users/psychon/repos","events_url":"https://api.github.com/users/psychon/events{/privacy}","received_events_url":"https://api.github.com/users/psychon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/psychon/awesome","description":"awesome window manager","fork":true,"url":"https://api.github.com/repos/psychon/awesome","forks_url":"https://api.github.com/repos/psychon/awesome/forks","keys_url":"https://api.github.com/repos/psychon/awesome/keys{/key_id}","collaborators_url":"https://api.github.com/repos/psychon/awesome/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/psychon/awesome/teams","hooks_url":"https://api.github.com/repos/psychon/awesome/hooks","issue_events_url":"https://api.github.com/repos/psychon/awesome/issues/events{/number}","events_url":"https://api.github.com/repos/psychon/awesome/events","assignees_url":"https://api.github.com/repos/psychon/awesome/assignees{/user}","branches_url":"https://api.github.com/repos/psychon/awesome/branches{/branch}","tags_url":"https://api.github.com/repos/psychon/awesome/tags","blobs_url":"https://api.github.com/repos/psychon/awesome/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/psychon/awesome/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/psychon/awesome/git/refs{/sha}","trees_url":"https://api.github.com/repos/psychon/awesome/git/trees{/sha}","statuses_url":"https://api.github.com/repos/psychon/awesome/statuses/{sha}","languages_url":"https://api.github.com/repos/psychon/awesome/languages","stargazers_url":"https://api.github.com/repos/psychon/awesome/stargazers","contributors_url":"https://api.github.com/repos/psychon/awesome/contributors","subscribers_url":"https://api.github.com/repos/psychon/awesome/subscribers","subscription_url":"https://api.github.com/repos/psychon/awesome/subscription","commits_url":"https://api.github.com/repos/psychon/awesome/commits{/sha}","git_commits_url":"https://api.github.com/repos/psychon/awesome/git/commits{/sha}","comments_url":"https://api.github.com/repos/psychon/awesome/comments{/number}","issue_comment_url":"https://api.github.com/repos/psychon/awesome/issues/comments{/number}","contents_url":"https://api.github.com/repos/psychon/awesome/contents/{+path}","compare_url":"https://api.github.com/repos/psychon/awesome/compare/{base}...{head}","merges_url":"https://api.github.com/repos/psychon/awesome/merges","archive_url":"https://api.github.com/repos/psychon/awesome/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/psychon/awesome/downloads","issues_url":"https://api.github.com/repos/psychon/awesome/issues{/number}","pulls_url":"https://api.github.com/repos/psychon/awesome/pulls{/number}","milestones_url":"https://api.github.com/repos/psychon/awesome/milestones{/number}","notifications_url":"https://api.github.com/repos/psychon/awesome/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/psychon/awesome/labels{/name}","releases_url":"https://api.github.com/repos/psychon/awesome/releases{/id}","created_at":"2015-01-02T15:31:52Z","updated_at":"2015-01-02T15:31:53Z","pushed_at":"2015-08-17T11:26:48Z","git_url":"git://github.com/psychon/awesome.git","ssh_url":"git@github.com:psychon/awesome.git","clone_url":"https://github.com/psychon/awesome.git","svn_url":"https://github.com/psychon/awesome","homepage":"https://awesome.naquadah.org/","size":8923,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"awesomeWM:master","ref":"master","sha":"a166f868649762d541c1b674bc4a34caba5901f3","user":{"login":"awesomeWM","id":6843364,"avatar_url":"https://avatars.githubusercontent.com/u/6843364?v=3","gravatar_id":"","url":"https://api.github.com/users/awesomeWM","html_url":"https://github.com/awesomeWM","followers_url":"https://api.github.com/users/awesomeWM/followers","following_url":"https://api.github.com/users/awesomeWM/following{/other_user}","gists_url":"https://api.github.com/users/awesomeWM/gists{/gist_id}","starred_url":"https://api.github.com/users/awesomeWM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awesomeWM/subscriptions","organizations_url":"https://api.github.com/users/awesomeWM/orgs","repos_url":"https://api.github.com/users/awesomeWM/repos","events_url":"https://api.github.com/users/awesomeWM/events{/privacy}","received_events_url":"https://api.github.com/users/awesomeWM/received_events","type":"Organization","site_admin":false},"repo":{"id":17378009,"name":"awesome","full_name":"awesomeWM/awesome","owner":{"login":"awesomeWM","id":6843364,"avatar_url":"https://avatars.githubusercontent.com/u/6843364?v=3","gravatar_id":"","url":"https://api.github.com/users/awesomeWM","html_url":"https://github.com/awesomeWM","followers_url":"https://api.github.com/users/awesomeWM/followers","following_url":"https://api.github.com/users/awesomeWM/following{/other_user}","gists_url":"https://api.github.com/users/awesomeWM/gists{/gist_id}","starred_url":"https://api.github.com/users/awesomeWM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awesomeWM/subscriptions","organizations_url":"https://api.github.com/users/awesomeWM/orgs","repos_url":"https://api.github.com/users/awesomeWM/repos","events_url":"https://api.github.com/users/awesomeWM/events{/privacy}","received_events_url":"https://api.github.com/users/awesomeWM/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/awesomeWM/awesome","description":"awesome window manager","fork":false,"url":"https://api.github.com/repos/awesomeWM/awesome","forks_url":"https://api.github.com/repos/awesomeWM/awesome/forks","keys_url":"https://api.github.com/repos/awesomeWM/awesome/keys{/key_id}","collaborators_url":"https://api.github.com/repos/awesomeWM/awesome/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/awesomeWM/awesome/teams","hooks_url":"https://api.github.com/repos/awesomeWM/awesome/hooks","issue_events_url":"https://api.github.com/repos/awesomeWM/awesome/issues/events{/number}","events_url":"https://api.github.com/repos/awesomeWM/awesome/events","assignees_url":"https://api.github.com/repos/awesomeWM/awesome/assignees{/user}","branches_url":"https://api.github.com/repos/awesomeWM/awesome/branches{/branch}","tags_url":"https://api.github.com/repos/awesomeWM/awesome/tags","blobs_url":"https://api.github.com/repos/awesomeWM/awesome/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/awesomeWM/awesome/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/awesomeWM/awesome/git/refs{/sha}","trees_url":"https://api.github.com/repos/awesomeWM/awesome/git/trees{/sha}","statuses_url":"https://api.github.com/repos/awesomeWM/awesome/statuses/{sha}","languages_url":"https://api.github.com/repos/awesomeWM/awesome/languages","stargazers_url":"https://api.github.com/repos/awesomeWM/awesome/stargazers","contributors_url":"https://api.github.com/repos/awesomeWM/awesome/contributors","subscribers_url":"https://api.github.com/repos/awesomeWM/awesome/subscribers","subscription_url":"https://api.github.com/repos/awesomeWM/awesome/subscription","commits_url":"https://api.github.com/repos/awesomeWM/awesome/commits{/sha}","git_commits_url":"https://api.github.com/repos/awesomeWM/awesome/git/commits{/sha}","comments_url":"https://api.github.com/repos/awesomeWM/awesome/comments{/number}","issue_comment_url":"https://api.github.com/repos/awesomeWM/awesome/issues/comments{/number}","contents_url":"https://api.github.com/repos/awesomeWM/awesome/contents/{+path}","compare_url":"https://api.github.com/repos/awesomeWM/awesome/compare/{base}...{head}","merges_url":"https://api.github.com/repos/awesomeWM/awesome/merges","archive_url":"https://api.github.com/repos/awesomeWM/awesome/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/awesomeWM/awesome/downloads","issues_url":"https://api.github.com/repos/awesomeWM/awesome/issues{/number}","pulls_url":"https://api.github.com/repos/awesomeWM/awesome/pulls{/number}","milestones_url":"https://api.github.com/repos/awesomeWM/awesome/milestones{/number}","notifications_url":"https://api.github.com/repos/awesomeWM/awesome/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/awesomeWM/awesome/labels{/name}","releases_url":"https://api.github.com/repos/awesomeWM/awesome/releases{/id}","created_at":"2014-03-03T19:56:16Z","updated_at":"2015-08-22T23:10:26Z","pushed_at":"2015-08-23T13:37:44Z","git_url":"git://github.com/awesomeWM/awesome.git","ssh_url":"git@github.com:awesomeWM/awesome.git","clone_url":"https://github.com/awesomeWM/awesome.git","svn_url":"https://github.com/awesomeWM/awesome","homepage":"https://awesome.naquadah.org/","size":16781,"stargazers_count":422,"watchers_count":422,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":67,"mirror_url":null,"open_issues_count":130,"forks":67,"open_issues":130,"watchers":422,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/awesomeWM/awesome/pulls/398"},"html":{"href":"https://github.com/awesomeWM/awesome/pull/398"},"issue":{"href":"https://api.github.com/repos/awesomeWM/awesome/issues/398"},"comments":{"href":"https://api.github.com/repos/awesomeWM/awesome/issues/398/comments"},"review_comments":{"href":"https://api.github.com/repos/awesomeWM/awesome/pulls/398/comments"},"review_comment":{"href":"https://api.github.com/repos/awesomeWM/awesome/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/awesomeWM/awesome/pulls/398/commits"},"statuses":{"href":"https://api.github.com/repos/awesomeWM/awesome/statuses/1ebc34b5e9c31b82013ed7ef2c59716d31333267"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"psychon","id":89482,"avatar_url":"https://avatars.githubusercontent.com/u/89482?v=3","gravatar_id":"","url":"https://api.github.com/users/psychon","html_url":"https://github.com/psychon","followers_url":"https://api.github.com/users/psychon/followers","following_url":"https://api.github.com/users/psychon/following{/other_user}","gists_url":"https://api.github.com/users/psychon/gists{/gist_id}","starred_url":"https://api.github.com/users/psychon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psychon/subscriptions","organizations_url":"https://api.github.com/users/psychon/orgs","repos_url":"https://api.github.com/users/psychon/repos","events_url":"https://api.github.com/users/psychon/events{/privacy}","received_events_url":"https://api.github.com/users/psychon/received_events","type":"User","site_admin":false},"comments":5,"review_comments":0,"commits":5,"additions":129,"deletions":84,"changed_files":22}}