{"action":"created","issue":{"url":"https://api.github.com/repos/catapult-project/catapult/issues/390","labels_url":"https://api.github.com/repos/catapult-project/catapult/issues/390/labels{/name}","comments_url":"https://api.github.com/repos/catapult-project/catapult/issues/390/comments","events_url":"https://api.github.com/repos/catapult-project/catapult/issues/390/events","html_url":"https://github.com/catapult-project/catapult/issues/390","id":98560545,"number":390,"title":"LayerView has a LayerTreeQuadStackViewer. Both names should either have 'tree' or not.","user":{"login":"catapult-bot","id":13457154,"avatar_url":"https://avatars.githubusercontent.com/u/13457154?v=3","gravatar_id":"","url":"https://api.github.com/users/catapult-bot","html_url":"https://github.com/catapult-bot","followers_url":"https://api.github.com/users/catapult-bot/followers","following_url":"https://api.github.com/users/catapult-bot/following{/other_user}","gists_url":"https://api.github.com/users/catapult-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/catapult-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/catapult-bot/subscriptions","organizations_url":"https://api.github.com/users/catapult-bot/orgs","repos_url":"https://api.github.com/users/catapult-bot/repos","events_url":"https://api.github.com/users/catapult-bot/events{/privacy}","received_events_url":"https://api.github.com/users/catapult-bot/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/catapult-project/catapult/labels/Frame%20Viewer","name":"Frame Viewer","color":"d4c5f9"},{"url":"https://api.github.com/repos/catapult-project/catapult/labels/P2","name":"P2","color":"fbca04"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-08-01T20:45:09Z","updated_at":"2015-08-01T20:45:19Z","closed_at":"2015-08-01T20:45:14Z","body":"<a href=\"https://github.com/natduca\"><img src=\"https://avatars.githubusercontent.com/u/412396?v=3\" align=\"left\" width=\"96\" height=\"96\" hspace=\"10\"></img></a> **Issue by [natduca](https://github.com/natduca)**\n_Monday Sep 22, 2014 at 20:16 GMT_\n_Originally opened as https://github.com/google/trace-viewer/issues/390_\n\n----\n\n_From [nd...@chromium.org](https://code.google.com/u/102435256078839283966/) on August 08, 2013 21:01:02_\n\nThey are tightly related classes. It should one of the two:\r\na)  LayerTreeViewer, LayerTreeQuadStackViewer\r\nb)  LayerViewer, LayerQuadStackViewer\r\n\r\nI think a is better.\n\n_Original issue: http://code.google.com/p/trace-viewer/issues/detail?id=385_\n"},"comment":{"url":"https://api.github.com/repos/catapult-project/catapult/issues/comments/126952607","html_url":"https://github.com/catapult-project/catapult/issues/390#issuecomment-126952607","issue_url":"https://api.github.com/repos/catapult-project/catapult/issues/390","id":126952607,"user":{"login":"catapult-bot","id":13457154,"avatar_url":"https://avatars.githubusercontent.com/u/13457154?v=3","gravatar_id":"","url":"https://api.github.com/users/catapult-bot","html_url":"https://github.com/catapult-bot","followers_url":"https://api.github.com/users/catapult-bot/followers","following_url":"https://api.github.com/users/catapult-bot/following{/other_user}","gists_url":"https://api.github.com/users/catapult-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/catapult-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/catapult-bot/subscriptions","organizations_url":"https://api.github.com/users/catapult-bot/orgs","repos_url":"https://api.github.com/users/catapult-bot/repos","events_url":"https://api.github.com/users/catapult-bot/events{/privacy}","received_events_url":"https://api.github.com/users/catapult-bot/received_events","type":"User","site_admin":false},"created_at":"2015-08-01T20:45:19Z","updated_at":"2015-08-01T20:45:19Z","body":"<a href=\"https://github.com/natduca\"><img src=\"https://avatars.githubusercontent.com/u/412396?v=3\" align=\"left\" width=\"48\" height=\"48\" hspace=\"10\"></img></a> **Comment by [natduca](https://github.com/natduca)**\n_Monday Sep 22, 2014 at 20:16 GMT_\n\n----\n\n_From [johnjbar...@chromium.org](https://code.google.com/u/102793569239199088523/) on August 14, 2013 17:01:36_\n\nI agree that the current names are not great. But LayerTreeQuadStackViewer makes no sense to me. It contains a QuadStackViewer, but it is not a type of QuadStackViewer. \r\n\r\nThe class we now call LayerTreeQuadStackViewer has controls that affect the object viewed in QuadStackViewer. Thus maybe LayerTreeViewController. Or I suppose LayerTreeQuadStackViewerController. \r\n\r\nOur current LayerViewer looks like LayerAnalysisController or LayerSelectionAnalysisController.\r\n\r\nI think these long names result from using highly specialized elements in the nested UI. If instead we created the LayerPicker, both sets of controls, QuadStackViewer and LayerAnalysis objects at the Snapshot level and wired them together, then the controll-y things could just be toolbars of controls, the layer picker would be a control as well, the layer analysis would be display surface and the QuadStackViewer would be the only complex object. We'd have fewer chained accessors and fewer names to make up.\n"}}