{"action":"closed","number":27,"pull_request":{"url":"https://api.github.com/repos/tnhu/jsface/pulls/27","id":34111655,"html_url":"https://github.com/tnhu/jsface/pull/27","diff_url":"https://github.com/tnhu/jsface/pull/27.diff","patch_url":"https://github.com/tnhu/jsface/pull/27.patch","issue_url":"https://api.github.com/repos/tnhu/jsface/issues/27","number":27,"state":"closed","locked":false,"title":"Support for getters and setters","user":{"login":"zikicm","id":8972153,"avatar_url":"https://avatars.githubusercontent.com/u/8972153?v=3","gravatar_id":"","url":"https://api.github.com/users/zikicm","html_url":"https://github.com/zikicm","followers_url":"https://api.github.com/users/zikicm/followers","following_url":"https://api.github.com/users/zikicm/following{/other_user}","gists_url":"https://api.github.com/users/zikicm/gists{/gist_id}","starred_url":"https://api.github.com/users/zikicm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zikicm/subscriptions","organizations_url":"https://api.github.com/users/zikicm/orgs","repos_url":"https://api.github.com/users/zikicm/repos","events_url":"https://api.github.com/users/zikicm/events{/privacy}","received_events_url":"https://api.github.com/users/zikicm/received_events","type":"User","site_admin":false},"body":"Hello,\r\n\r\nI would like to add a feature to this great library and that is support for getters and setters. The following code snippet will explain that the best:\r\n\r\nvar Person = Class({\r\n\tconstructor : function(name) {\r\n\t\tthis._name = name;\r\n\t},\r\n\tname : {\r\n\t\tget : function() {\r\n\t\t\treturn this._name;\r\n\t\t},\r\n\t\tset : function(value) {\r\n\t\t\tthis._name = value;\r\n\t\t}\r\n\t}\r\n});\r\n\r\nvar Student = Class(Person, {\r\n\tconstructor : function(name, age) {\r\n\t\tStudent.$super.call(this, name);\r\n\t\tthis._age = age;\r\n\t},\r\n\tage : {\r\n\t\tget : function() {\r\n\t\t\treturn this._age;\r\n\t\t}\r\n\t}\r\n});\r\n\r\nvar milos = new Person(\"Milos\");\r\nvar mia = new Student(\"Mia\", 18);\r\n\r\nconsole.log(milos.name); // output: Milos\r\n\r\nconsole.log(mia.name); // output: Mia\r\nmia.name = \"Mirela\";\r\nconsole.log(mia.name); // output: Mirela\r\n\r\nconsole.log(mia.age); // output: 18\r\n\r\nThanks,\r\nMilos","created_at":"2015-04-25T19:30:03Z","updated_at":"2015-04-26T03:07:44Z","closed_at":"2015-04-26T03:07:44Z","merged_at":"2015-04-26T03:07:44Z","merge_commit_sha":"0d466705cbc8b243f23c810619edfd085e95101f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/tnhu/jsface/pulls/27/commits","review_comments_url":"https://api.github.com/repos/tnhu/jsface/pulls/27/comments","review_comment_url":"https://api.github.com/repos/tnhu/jsface/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tnhu/jsface/issues/27/comments","statuses_url":"https://api.github.com/repos/tnhu/jsface/statuses/3100782c6dec96263c22a272182bc3f4c1db9bc6","head":{"label":"zikicm:master","ref":"master","sha":"3100782c6dec96263c22a272182bc3f4c1db9bc6","user":{"login":"zikicm","id":8972153,"avatar_url":"https://avatars.githubusercontent.com/u/8972153?v=3","gravatar_id":"","url":"https://api.github.com/users/zikicm","html_url":"https://github.com/zikicm","followers_url":"https://api.github.com/users/zikicm/followers","following_url":"https://api.github.com/users/zikicm/following{/other_user}","gists_url":"https://api.github.com/users/zikicm/gists{/gist_id}","starred_url":"https://api.github.com/users/zikicm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zikicm/subscriptions","organizations_url":"https://api.github.com/users/zikicm/orgs","repos_url":"https://api.github.com/users/zikicm/repos","events_url":"https://api.github.com/users/zikicm/events{/privacy}","received_events_url":"https://api.github.com/users/zikicm/received_events","type":"User","site_admin":false},"repo":{"id":34581833,"name":"jsface","full_name":"zikicm/jsface","owner":{"login":"zikicm","id":8972153,"avatar_url":"https://avatars.githubusercontent.com/u/8972153?v=3","gravatar_id":"","url":"https://api.github.com/users/zikicm","html_url":"https://github.com/zikicm","followers_url":"https://api.github.com/users/zikicm/followers","following_url":"https://api.github.com/users/zikicm/following{/other_user}","gists_url":"https://api.github.com/users/zikicm/gists{/gist_id}","starred_url":"https://api.github.com/users/zikicm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zikicm/subscriptions","organizations_url":"https://api.github.com/users/zikicm/orgs","repos_url":"https://api.github.com/users/zikicm/repos","events_url":"https://api.github.com/users/zikicm/events{/privacy}","received_events_url":"https://api.github.com/users/zikicm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zikicm/jsface","description":"Small, fast, elegant, powerful, and cross platform JavaScript OOP library. Support main(), singleton, super call, private, mixins, plugins, AOP and more.","fork":true,"url":"https://api.github.com/repos/zikicm/jsface","forks_url":"https://api.github.com/repos/zikicm/jsface/forks","keys_url":"https://api.github.com/repos/zikicm/jsface/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zikicm/jsface/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zikicm/jsface/teams","hooks_url":"https://api.github.com/repos/zikicm/jsface/hooks","issue_events_url":"https://api.github.com/repos/zikicm/jsface/issues/events{/number}","events_url":"https://api.github.com/repos/zikicm/jsface/events","assignees_url":"https://api.github.com/repos/zikicm/jsface/assignees{/user}","branches_url":"https://api.github.com/repos/zikicm/jsface/branches{/branch}","tags_url":"https://api.github.com/repos/zikicm/jsface/tags","blobs_url":"https://api.github.com/repos/zikicm/jsface/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zikicm/jsface/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zikicm/jsface/git/refs{/sha}","trees_url":"https://api.github.com/repos/zikicm/jsface/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zikicm/jsface/statuses/{sha}","languages_url":"https://api.github.com/repos/zikicm/jsface/languages","stargazers_url":"https://api.github.com/repos/zikicm/jsface/stargazers","contributors_url":"https://api.github.com/repos/zikicm/jsface/contributors","subscribers_url":"https://api.github.com/repos/zikicm/jsface/subscribers","subscription_url":"https://api.github.com/repos/zikicm/jsface/subscription","commits_url":"https://api.github.com/repos/zikicm/jsface/commits{/sha}","git_commits_url":"https://api.github.com/repos/zikicm/jsface/git/commits{/sha}","comments_url":"https://api.github.com/repos/zikicm/jsface/comments{/number}","issue_comment_url":"https://api.github.com/repos/zikicm/jsface/issues/comments{/number}","contents_url":"https://api.github.com/repos/zikicm/jsface/contents/{+path}","compare_url":"https://api.github.com/repos/zikicm/jsface/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zikicm/jsface/merges","archive_url":"https://api.github.com/repos/zikicm/jsface/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zikicm/jsface/downloads","issues_url":"https://api.github.com/repos/zikicm/jsface/issues{/number}","pulls_url":"https://api.github.com/repos/zikicm/jsface/pulls{/number}","milestones_url":"https://api.github.com/repos/zikicm/jsface/milestones{/number}","notifications_url":"https://api.github.com/repos/zikicm/jsface/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zikicm/jsface/labels{/name}","releases_url":"https://api.github.com/repos/zikicm/jsface/releases{/id}","created_at":"2015-04-25T19:01:35Z","updated_at":"2015-04-25T19:16:38Z","pushed_at":"2015-04-25T19:16:37Z","git_url":"git://github.com/zikicm/jsface.git","ssh_url":"git@github.com:zikicm/jsface.git","clone_url":"https://github.com/zikicm/jsface.git","svn_url":"https://github.com/zikicm/jsface","homepage":"","size":304,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tnhu:master","ref":"master","sha":"6c5e11d082b0bd4ba9c5fa7beec055fd8af25012","user":{"login":"tnhu","id":30633,"avatar_url":"https://avatars.githubusercontent.com/u/30633?v=3","gravatar_id":"","url":"https://api.github.com/users/tnhu","html_url":"https://github.com/tnhu","followers_url":"https://api.github.com/users/tnhu/followers","following_url":"https://api.github.com/users/tnhu/following{/other_user}","gists_url":"https://api.github.com/users/tnhu/gists{/gist_id}","starred_url":"https://api.github.com/users/tnhu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tnhu/subscriptions","organizations_url":"https://api.github.com/users/tnhu/orgs","repos_url":"https://api.github.com/users/tnhu/repos","events_url":"https://api.github.com/users/tnhu/events{/privacy}","received_events_url":"https://api.github.com/users/tnhu/received_events","type":"User","site_admin":false},"repo":{"id":1092609,"name":"jsface","full_name":"tnhu/jsface","owner":{"login":"tnhu","id":30633,"avatar_url":"https://avatars.githubusercontent.com/u/30633?v=3","gravatar_id":"","url":"https://api.github.com/users/tnhu","html_url":"https://github.com/tnhu","followers_url":"https://api.github.com/users/tnhu/followers","following_url":"https://api.github.com/users/tnhu/following{/other_user}","gists_url":"https://api.github.com/users/tnhu/gists{/gist_id}","starred_url":"https://api.github.com/users/tnhu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tnhu/subscriptions","organizations_url":"https://api.github.com/users/tnhu/orgs","repos_url":"https://api.github.com/users/tnhu/repos","events_url":"https://api.github.com/users/tnhu/events{/privacy}","received_events_url":"https://api.github.com/users/tnhu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tnhu/jsface","description":"Small, fast, elegant, powerful, and cross platform JavaScript OOP library. Support main(), singleton, super call, private, mixins, plugins, AOP and more.","fork":false,"url":"https://api.github.com/repos/tnhu/jsface","forks_url":"https://api.github.com/repos/tnhu/jsface/forks","keys_url":"https://api.github.com/repos/tnhu/jsface/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tnhu/jsface/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tnhu/jsface/teams","hooks_url":"https://api.github.com/repos/tnhu/jsface/hooks","issue_events_url":"https://api.github.com/repos/tnhu/jsface/issues/events{/number}","events_url":"https://api.github.com/repos/tnhu/jsface/events","assignees_url":"https://api.github.com/repos/tnhu/jsface/assignees{/user}","branches_url":"https://api.github.com/repos/tnhu/jsface/branches{/branch}","tags_url":"https://api.github.com/repos/tnhu/jsface/tags","blobs_url":"https://api.github.com/repos/tnhu/jsface/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tnhu/jsface/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tnhu/jsface/git/refs{/sha}","trees_url":"https://api.github.com/repos/tnhu/jsface/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tnhu/jsface/statuses/{sha}","languages_url":"https://api.github.com/repos/tnhu/jsface/languages","stargazers_url":"https://api.github.com/repos/tnhu/jsface/stargazers","contributors_url":"https://api.github.com/repos/tnhu/jsface/contributors","subscribers_url":"https://api.github.com/repos/tnhu/jsface/subscribers","subscription_url":"https://api.github.com/repos/tnhu/jsface/subscription","commits_url":"https://api.github.com/repos/tnhu/jsface/commits{/sha}","git_commits_url":"https://api.github.com/repos/tnhu/jsface/git/commits{/sha}","comments_url":"https://api.github.com/repos/tnhu/jsface/comments{/number}","issue_comment_url":"https://api.github.com/repos/tnhu/jsface/issues/comments{/number}","contents_url":"https://api.github.com/repos/tnhu/jsface/contents/{+path}","compare_url":"https://api.github.com/repos/tnhu/jsface/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tnhu/jsface/merges","archive_url":"https://api.github.com/repos/tnhu/jsface/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tnhu/jsface/downloads","issues_url":"https://api.github.com/repos/tnhu/jsface/issues{/number}","pulls_url":"https://api.github.com/repos/tnhu/jsface/pulls{/number}","milestones_url":"https://api.github.com/repos/tnhu/jsface/milestones{/number}","notifications_url":"https://api.github.com/repos/tnhu/jsface/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tnhu/jsface/labels{/name}","releases_url":"https://api.github.com/repos/tnhu/jsface/releases{/id}","created_at":"2010-11-18T19:30:49Z","updated_at":"2015-04-26T03:07:46Z","pushed_at":"2015-04-26T03:07:44Z","git_url":"git://github.com/tnhu/jsface.git","ssh_url":"git@github.com:tnhu/jsface.git","clone_url":"https://github.com/tnhu/jsface.git","svn_url":"https://github.com/tnhu/jsface","homepage":"","size":591,"stargazers_count":198,"watchers_count":198,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":26,"mirror_url":null,"open_issues_count":2,"forks":26,"open_issues":2,"watchers":198,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tnhu/jsface/pulls/27"},"html":{"href":"https://github.com/tnhu/jsface/pull/27"},"issue":{"href":"https://api.github.com/repos/tnhu/jsface/issues/27"},"comments":{"href":"https://api.github.com/repos/tnhu/jsface/issues/27/comments"},"review_comments":{"href":"https://api.github.com/repos/tnhu/jsface/pulls/27/comments"},"review_comment":{"href":"https://api.github.com/repos/tnhu/jsface/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tnhu/jsface/pulls/27/commits"},"statuses":{"href":"https://api.github.com/repos/tnhu/jsface/statuses/3100782c6dec96263c22a272182bc3f4c1db9bc6"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"tnhu","id":30633,"avatar_url":"https://avatars.githubusercontent.com/u/30633?v=3","gravatar_id":"","url":"https://api.github.com/users/tnhu","html_url":"https://github.com/tnhu","followers_url":"https://api.github.com/users/tnhu/followers","following_url":"https://api.github.com/users/tnhu/following{/other_user}","gists_url":"https://api.github.com/users/tnhu/gists{/gist_id}","starred_url":"https://api.github.com/users/tnhu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tnhu/subscriptions","organizations_url":"https://api.github.com/users/tnhu/orgs","repos_url":"https://api.github.com/users/tnhu/repos","events_url":"https://api.github.com/users/tnhu/events{/privacy}","received_events_url":"https://api.github.com/users/tnhu/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":2,"additions":6,"deletions":1,"changed_files":1}}