{"action":"closed","number":95,"pull_request":{"url":"https://api.github.com/repos/Microsoft/llvm/pulls/95","id":46658048,"html_url":"https://github.com/Microsoft/llvm/pull/95","diff_url":"https://github.com/Microsoft/llvm/pull/95.diff","patch_url":"https://github.com/Microsoft/llvm/pull/95.patch","issue_url":"https://api.github.com/repos/Microsoft/llvm/issues/95","number":95,"state":"closed","locked":false,"title":"Add CLR EH table generation for new EH; remove it for landingpad EH","user":{"login":"JosephTremoulet","id":10655216,"avatar_url":"https://avatars.githubusercontent.com/u/10655216?v=3","gravatar_id":"","url":"https://api.github.com/users/JosephTremoulet","html_url":"https://github.com/JosephTremoulet","followers_url":"https://api.github.com/users/JosephTremoulet/followers","following_url":"https://api.github.com/users/JosephTremoulet/following{/other_user}","gists_url":"https://api.github.com/users/JosephTremoulet/gists{/gist_id}","starred_url":"https://api.github.com/users/JosephTremoulet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JosephTremoulet/subscriptions","organizations_url":"https://api.github.com/users/JosephTremoulet/orgs","repos_url":"https://api.github.com/users/JosephTremoulet/repos","events_url":"https://api.github.com/users/JosephTremoulet/events{/privacy}","received_events_url":"https://api.github.com/users/JosephTremoulet/received_events","type":"User","site_admin":false},"body":"This is a PR for a change to go into the EH branch.\r\n\r\nI think the relevant bits are stable enough to upstream this to LLVM (assuming I can figure out how to write a lit test that verifies we generate tables as expected), but want to PR it into the EH branch first since this provides a more useful diff to review from the LLILC perspective.\r\n\r\nI split it into one commit that adds the new functionality and a second that removes the old; the second is a straight revert of the relevant code to match master.\r\n\r\nNote that consuming these tables in LLILC and passing them along to the CLR is still being implemented, though I've got far enough to vet that these tables are reasonable for basic cases.\r\n\r\nNote also that EH table generation isn't the whole of EH lowering; funclet prolog sequences will need some adjustment, we may need to change where nops are inserted, etc.\r\n\r\nThe support here for filters is just a stub, since LLILC currently (in the EH branch) translates filters to catches in the reader.","created_at":"2015-10-02T17:02:57Z","updated_at":"2015-10-02T21:01:10Z","closed_at":"2015-10-02T21:01:10Z","merged_at":"2015-10-02T21:01:10Z","merge_commit_sha":"05bda14f844d4ed4775bfdf3e64a15e3eef08c9d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/llvm/pulls/95/commits","review_comments_url":"https://api.github.com/repos/Microsoft/llvm/pulls/95/comments","review_comment_url":"https://api.github.com/repos/Microsoft/llvm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/llvm/issues/95/comments","statuses_url":"https://api.github.com/repos/Microsoft/llvm/statuses/935de0cd4084800cd1eed4bd61f93858ab140d9f","head":{"label":"JosephTremoulet:NewTables","ref":"NewTables","sha":"935de0cd4084800cd1eed4bd61f93858ab140d9f","user":{"login":"JosephTremoulet","id":10655216,"avatar_url":"https://avatars.githubusercontent.com/u/10655216?v=3","gravatar_id":"","url":"https://api.github.com/users/JosephTremoulet","html_url":"https://github.com/JosephTremoulet","followers_url":"https://api.github.com/users/JosephTremoulet/followers","following_url":"https://api.github.com/users/JosephTremoulet/following{/other_user}","gists_url":"https://api.github.com/users/JosephTremoulet/gists{/gist_id}","starred_url":"https://api.github.com/users/JosephTremoulet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JosephTremoulet/subscriptions","organizations_url":"https://api.github.com/users/JosephTremoulet/orgs","repos_url":"https://api.github.com/users/JosephTremoulet/repos","events_url":"https://api.github.com/users/JosephTremoulet/events{/privacy}","received_events_url":"https://api.github.com/users/JosephTremoulet/received_events","type":"User","site_admin":false},"repo":{"id":35576595,"name":"llvm","full_name":"JosephTremoulet/llvm","owner":{"login":"JosephTremoulet","id":10655216,"avatar_url":"https://avatars.githubusercontent.com/u/10655216?v=3","gravatar_id":"","url":"https://api.github.com/users/JosephTremoulet","html_url":"https://github.com/JosephTremoulet","followers_url":"https://api.github.com/users/JosephTremoulet/followers","following_url":"https://api.github.com/users/JosephTremoulet/following{/other_user}","gists_url":"https://api.github.com/users/JosephTremoulet/gists{/gist_id}","starred_url":"https://api.github.com/users/JosephTremoulet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JosephTremoulet/subscriptions","organizations_url":"https://api.github.com/users/JosephTremoulet/orgs","repos_url":"https://api.github.com/users/JosephTremoulet/repos","events_url":"https://api.github.com/users/JosephTremoulet/events{/privacy}","received_events_url":"https://api.github.com/users/JosephTremoulet/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JosephTremoulet/llvm","description":"Fork of the LLVM Compiler Infrastructure","fork":true,"url":"https://api.github.com/repos/JosephTremoulet/llvm","forks_url":"https://api.github.com/repos/JosephTremoulet/llvm/forks","keys_url":"https://api.github.com/repos/JosephTremoulet/llvm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JosephTremoulet/llvm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JosephTremoulet/llvm/teams","hooks_url":"https://api.github.com/repos/JosephTremoulet/llvm/hooks","issue_events_url":"https://api.github.com/repos/JosephTremoulet/llvm/issues/events{/number}","events_url":"https://api.github.com/repos/JosephTremoulet/llvm/events","assignees_url":"https://api.github.com/repos/JosephTremoulet/llvm/assignees{/user}","branches_url":"https://api.github.com/repos/JosephTremoulet/llvm/branches{/branch}","tags_url":"https://api.github.com/repos/JosephTremoulet/llvm/tags","blobs_url":"https://api.github.com/repos/JosephTremoulet/llvm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JosephTremoulet/llvm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JosephTremoulet/llvm/git/refs{/sha}","trees_url":"https://api.github.com/repos/JosephTremoulet/llvm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JosephTremoulet/llvm/statuses/{sha}","languages_url":"https://api.github.com/repos/JosephTremoulet/llvm/languages","stargazers_url":"https://api.github.com/repos/JosephTremoulet/llvm/stargazers","contributors_url":"https://api.github.com/repos/JosephTremoulet/llvm/contributors","subscribers_url":"https://api.github.com/repos/JosephTremoulet/llvm/subscribers","subscription_url":"https://api.github.com/repos/JosephTremoulet/llvm/subscription","commits_url":"https://api.github.com/repos/JosephTremoulet/llvm/commits{/sha}","git_commits_url":"https://api.github.com/repos/JosephTremoulet/llvm/git/commits{/sha}","comments_url":"https://api.github.com/repos/JosephTremoulet/llvm/comments{/number}","issue_comment_url":"https://api.github.com/repos/JosephTremoulet/llvm/issues/comments{/number}","contents_url":"https://api.github.com/repos/JosephTremoulet/llvm/contents/{+path}","compare_url":"https://api.github.com/repos/JosephTremoulet/llvm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JosephTremoulet/llvm/merges","archive_url":"https://api.github.com/repos/JosephTremoulet/llvm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JosephTremoulet/llvm/downloads","issues_url":"https://api.github.com/repos/JosephTremoulet/llvm/issues{/number}","pulls_url":"https://api.github.com/repos/JosephTremoulet/llvm/pulls{/number}","milestones_url":"https://api.github.com/repos/JosephTremoulet/llvm/milestones{/number}","notifications_url":"https://api.github.com/repos/JosephTremoulet/llvm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JosephTremoulet/llvm/labels{/name}","releases_url":"https://api.github.com/repos/JosephTremoulet/llvm/releases{/id}","created_at":"2015-05-13T22:07:43Z","updated_at":"2015-05-13T22:08:27Z","pushed_at":"2015-10-02T20:01:23Z","git_url":"git://github.com/JosephTremoulet/llvm.git","ssh_url":"git@github.com:JosephTremoulet/llvm.git","clone_url":"https://github.com/JosephTremoulet/llvm.git","svn_url":"https://github.com/JosephTremoulet/llvm","homepage":"http://llvm.org","size":678178,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:EH","ref":"EH","sha":"025795227344c146c283e0e02fe4b5b043711e00","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":29704274,"name":"llvm","full_name":"Microsoft/llvm","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/llvm","description":"Fork of the LLVM Compiler Infrastructure","fork":false,"url":"https://api.github.com/repos/Microsoft/llvm","forks_url":"https://api.github.com/repos/Microsoft/llvm/forks","keys_url":"https://api.github.com/repos/Microsoft/llvm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/llvm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/llvm/teams","hooks_url":"https://api.github.com/repos/Microsoft/llvm/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/llvm/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/llvm/events","assignees_url":"https://api.github.com/repos/Microsoft/llvm/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/llvm/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/llvm/tags","blobs_url":"https://api.github.com/repos/Microsoft/llvm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/llvm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/llvm/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/llvm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/llvm/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/llvm/languages","stargazers_url":"https://api.github.com/repos/Microsoft/llvm/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/llvm/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/llvm/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/llvm/subscription","commits_url":"https://api.github.com/repos/Microsoft/llvm/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/llvm/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/llvm/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/llvm/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/llvm/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/llvm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/llvm/merges","archive_url":"https://api.github.com/repos/Microsoft/llvm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/llvm/downloads","issues_url":"https://api.github.com/repos/Microsoft/llvm/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/llvm/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/llvm/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/llvm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/llvm/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/llvm/releases{/id}","created_at":"2015-01-22T22:44:45Z","updated_at":"2015-09-28T19:37:29Z","pushed_at":"2015-10-02T21:01:10Z","git_url":"git://github.com/Microsoft/llvm.git","ssh_url":"git@github.com:Microsoft/llvm.git","clone_url":"https://github.com/Microsoft/llvm.git","svn_url":"https://github.com/Microsoft/llvm","homepage":"http://llvm.org","size":746899,"stargazers_count":51,"watchers_count":51,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"open_issues_count":7,"forks":23,"open_issues":7,"watchers":51,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/llvm/pulls/95"},"html":{"href":"https://github.com/Microsoft/llvm/pull/95"},"issue":{"href":"https://api.github.com/repos/Microsoft/llvm/issues/95"},"comments":{"href":"https://api.github.com/repos/Microsoft/llvm/issues/95/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/llvm/pulls/95/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/llvm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/llvm/pulls/95/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/llvm/statuses/935de0cd4084800cd1eed4bd61f93858ab140d9f"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"JosephTremoulet","id":10655216,"avatar_url":"https://avatars.githubusercontent.com/u/10655216?v=3","gravatar_id":"","url":"https://api.github.com/users/JosephTremoulet","html_url":"https://github.com/JosephTremoulet","followers_url":"https://api.github.com/users/JosephTremoulet/followers","following_url":"https://api.github.com/users/JosephTremoulet/following{/other_user}","gists_url":"https://api.github.com/users/JosephTremoulet/gists{/gist_id}","starred_url":"https://api.github.com/users/JosephTremoulet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JosephTremoulet/subscriptions","organizations_url":"https://api.github.com/users/JosephTremoulet/orgs","repos_url":"https://api.github.com/users/JosephTremoulet/repos","events_url":"https://api.github.com/users/JosephTremoulet/events{/privacy}","received_events_url":"https://api.github.com/users/JosephTremoulet/received_events","type":"User","site_admin":false},"comments":2,"review_comments":6,"commits":2,"additions":382,"deletions":301,"changed_files":9}}