{"action":"created","issue":{"url":"https://api.github.com/repos/neovim/neovim/issues/1883","labels_url":"https://api.github.com/repos/neovim/neovim/issues/1883/labels{/name}","comments_url":"https://api.github.com/repos/neovim/neovim/issues/1883/comments","events_url":"https://api.github.com/repos/neovim/neovim/issues/1883/events","html_url":"https://github.com/neovim/neovim/pull/1883","id":55372346,"number":1883,"title":"[RFC] More work on highlight tests + update documentation","user":{"login":"bfredl","id":1363104,"avatar_url":"https://avatars.githubusercontent.com/u/1363104?v=3","gravatar_id":"","url":"https://api.github.com/users/bfredl","html_url":"https://github.com/bfredl","followers_url":"https://api.github.com/users/bfredl/followers","following_url":"https://api.github.com/users/bfredl/following{/other_user}","gists_url":"https://api.github.com/users/bfredl/gists{/gist_id}","starred_url":"https://api.github.com/users/bfredl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bfredl/subscriptions","organizations_url":"https://api.github.com/users/bfredl/orgs","repos_url":"https://api.github.com/users/bfredl/repos","events_url":"https://api.github.com/users/bfredl/events{/privacy}","received_events_url":"https://api.github.com/users/bfredl/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/neovim/neovim/labels/api","name":"api","color":"c7def8"},{"url":"https://api.github.com/repos/neovim/neovim/labels/gui","name":"gui","color":"c7def8"},{"url":"https://api.github.com/repos/neovim/neovim/labels/RFC","name":"RFC","color":"ededed"},{"url":"https://api.github.com/repos/neovim/neovim/labels/tests","name":"tests","color":"c7def8"},{"url":"https://api.github.com/repos/neovim/neovim/labels/ui","name":"ui","color":"c7def8"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":13,"created_at":"2015-01-24T14:22:49Z","updated_at":"2015-02-02T16:57:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/neovim/neovim/pulls/1883","html_url":"https://github.com/neovim/neovim/pull/1883","diff_url":"https://github.com/neovim/neovim/pull/1883.diff","patch_url":"https://github.com/neovim/neovim/pull/1883.patch"},"body":"Continuation of #1835.\r\n* Better error messages for unexpected highlights\r\n* Use strict mode per default and in existing tests. It is still possible to ignore unexpected highlights by\r\nsetting `ignore = true`\r\n* Update documentation\r\n\r\nI will \"dog-food\" this and write some tests for search highlighting and such, to uncover remaining rough corners. \r\n\r\nThere is an api function that translates color names to rgb values, but when using the `snapshot_util` workflow, it would be convenient to be able to do the reverse, i.e. given a present rgb value, find the canonical color name for it. \r\nOne possibility: when initializing the `screen`, populate a table with all color name / rgb value pairs. Then, also, every specific test need not use `nvim('name_to_color', 'MyColor')`, instead `screen.colors.MyColor`."},"comment":{"url":"https://api.github.com/repos/neovim/neovim/issues/comments/72492877","html_url":"https://github.com/neovim/neovim/pull/1883#issuecomment-72492877","issue_url":"https://api.github.com/repos/neovim/neovim/issues/1883","id":72492877,"user":{"login":"bfredl","id":1363104,"avatar_url":"https://avatars.githubusercontent.com/u/1363104?v=3","gravatar_id":"","url":"https://api.github.com/users/bfredl","html_url":"https://github.com/bfredl","followers_url":"https://api.github.com/users/bfredl/followers","following_url":"https://api.github.com/users/bfredl/following{/other_user}","gists_url":"https://api.github.com/users/bfredl/gists{/gist_id}","starred_url":"https://api.github.com/users/bfredl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bfredl/subscriptions","organizations_url":"https://api.github.com/users/bfredl/orgs","repos_url":"https://api.github.com/users/bfredl/repos","events_url":"https://api.github.com/users/bfredl/events{/privacy}","received_events_url":"https://api.github.com/users/bfredl/received_events","type":"User","site_admin":false},"created_at":"2015-02-02T16:57:48Z","updated_at":"2015-02-02T16:57:48Z","body":"I used this quite conveniently to generate some basic `hlsearch` tests (will push PR after this), so marking as RDY if no one has more objections/suggestions."}}