{"action":"created","issue":{"url":"https://api.github.com/repos/stan-dev/math/issues/181","labels_url":"https://api.github.com/repos/stan-dev/math/issues/181/labels{/name}","comments_url":"https://api.github.com/repos/stan-dev/math/issues/181/comments","events_url":"https://api.github.com/repos/stan-dev/math/issues/181/events","html_url":"https://github.com/stan-dev/math/pull/181","id":108664970,"number":181,"title":"Feature/issue 180 clean up ode","user":{"login":"betanalpha","id":1527190,"avatar_url":"https://avatars.githubusercontent.com/u/1527190?v=3","gravatar_id":"","url":"https://api.github.com/users/betanalpha","html_url":"https://github.com/betanalpha","followers_url":"https://api.github.com/users/betanalpha/followers","following_url":"https://api.github.com/users/betanalpha/following{/other_user}","gists_url":"https://api.github.com/users/betanalpha/gists{/gist_id}","starred_url":"https://api.github.com/users/betanalpha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/betanalpha/subscriptions","organizations_url":"https://api.github.com/users/betanalpha/orgs","repos_url":"https://api.github.com/users/betanalpha/repos","events_url":"https://api.github.com/users/betanalpha/events{/privacy}","received_events_url":"https://api.github.com/users/betanalpha/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":18,"created_at":"2015-09-28T14:07:26Z","updated_at":"2015-10-01T06:51:04Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/stan-dev/math/pulls/181","html_url":"https://github.com/stan-dev/math/pull/181","diff_url":"https://github.com/stan-dev/math/pull/181.diff","patch_url":"https://github.com/stan-dev/math/pull/181.patch"},"body":"#### Summary:\r\n\r\nAddresses Issue #180.  The rev implementation of coupled_ode_system::operator() now features consistent notation making it easier to understand.  Additionally the autodiff stack is now built only once instead of the N (size of the base ODE system) times, which should lead to a pretty noticeable speed up.\r\n\r\nAdditionally a new test of the resulting ODE sensitivies was added to complement the ODE state tests in integrated_ode_test.cpp.\r\n\r\n#### Intended Effect:\r\n\r\nMore easily maintained code, faster execution of ODE derivatives.\r\n\r\n#### How to Verify:\r\n\r\n./runTests.py test/unit/math/rev/arr/functor/*test.cpp\r\n\r\n#### Side Effects:\r\n\r\nFaster execution.\r\n\r\n#### Documentation:\r\n\r\nNone, nothing user facing.\r\n\r\n#### Reviewer Suggestions:\r\n\r\n@syclik @bob-carpenter "},"comment":{"url":"https://api.github.com/repos/stan-dev/math/issues/comments/144636843","html_url":"https://github.com/stan-dev/math/pull/181#issuecomment-144636843","issue_url":"https://api.github.com/repos/stan-dev/math/issues/181","id":144636843,"user":{"login":"wds15","id":12070126,"avatar_url":"https://avatars.githubusercontent.com/u/12070126?v=3","gravatar_id":"","url":"https://api.github.com/users/wds15","html_url":"https://github.com/wds15","followers_url":"https://api.github.com/users/wds15/followers","following_url":"https://api.github.com/users/wds15/following{/other_user}","gists_url":"https://api.github.com/users/wds15/gists{/gist_id}","starred_url":"https://api.github.com/users/wds15/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wds15/subscriptions","organizations_url":"https://api.github.com/users/wds15/orgs","repos_url":"https://api.github.com/users/wds15/repos","events_url":"https://api.github.com/users/wds15/events{/privacy}","received_events_url":"https://api.github.com/users/wds15/received_events","type":"User","site_admin":false},"created_at":"2015-10-01T06:51:04Z","updated_at":"2015-10-01T06:51:04Z","body":"Awesome!\r\n\r\nIf you drop me note which branch to test when the virtual evilness is gone, then I am happy to run the benchmark above again on it. This is great news all together."}}