{"action":"created","comment":{"url":"https://api.github.com/repos/rackerlabs/blueflood/pulls/comments/23049509","id":23049509,"diff_hunk":"@@ -219,4 +127,74 @@ public void exceptionCaught(ChannelHandlerContext ctx, ExceptionEvent e) throws\n             return pipeline;\n         }\n     }\n+    static class Processor {","path":"blueflood-http/src/main/java/com/rackspacecloud/blueflood/inputs/handlers/HttpMetricsIngestionServer.java","position":168,"original_position":168,"commit_id":"429e917203d5a8c37acb37dd793304946b9689f2","original_commit_id":"429e917203d5a8c37acb37dd793304946b9689f2","user":{"login":"GeorgeJahad","id":86830,"avatar_url":"https://avatars.githubusercontent.com/u/86830?v=3","gravatar_id":"","url":"https://api.github.com/users/GeorgeJahad","html_url":"https://github.com/GeorgeJahad","followers_url":"https://api.github.com/users/GeorgeJahad/followers","following_url":"https://api.github.com/users/GeorgeJahad/following{/other_user}","gists_url":"https://api.github.com/users/GeorgeJahad/gists{/gist_id}","starred_url":"https://api.github.com/users/GeorgeJahad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GeorgeJahad/subscriptions","organizations_url":"https://api.github.com/users/GeorgeJahad/orgs","repos_url":"https://api.github.com/users/GeorgeJahad/repos","events_url":"https://api.github.com/users/GeorgeJahad/events{/privacy}","received_events_url":"https://api.github.com/users/GeorgeJahad/received_events","type":"User","site_admin":false},"body":"It made sense to me as a subclass in the same namespace, and it didn't need a reference to an instance of the parent class.  But I have no problem moving it out, if you think it isn't clear.\r\n","created_at":"2015-01-15T22:29:43Z","updated_at":"2015-01-15T22:29:43Z","html_url":"https://github.com/rackerlabs/blueflood/pull/416#discussion_r23049509","pull_request_url":"https://api.github.com/repos/rackerlabs/blueflood/pulls/416","_links":{"self":{"href":"https://api.github.com/repos/rackerlabs/blueflood/pulls/comments/23049509"},"html":{"href":"https://github.com/rackerlabs/blueflood/pull/416#discussion_r23049509"},"pull_request":{"href":"https://api.github.com/repos/rackerlabs/blueflood/pulls/416"}}},"pull_request":{"url":"https://api.github.com/repos/rackerlabs/blueflood/pulls/416","id":27297545,"html_url":"https://github.com/rackerlabs/blueflood/pull/416","diff_url":"https://github.com/rackerlabs/blueflood/pull/416.diff","patch_url":"https://github.com/rackerlabs/blueflood/pull/416.patch","issue_url":"https://api.github.com/repos/rackerlabs/blueflood/issues/416","number":416,"state":"open","locked":false,"title":"Removal of overly complicated AsyncChain code, in order to facilitate future maintenance","user":{"login":"GeorgeJahad","id":86830,"avatar_url":"https://avatars.githubusercontent.com/u/86830?v=3","gravatar_id":"","url":"https://api.github.com/users/GeorgeJahad","html_url":"https://github.com/GeorgeJahad","followers_url":"https://api.github.com/users/GeorgeJahad/followers","following_url":"https://api.github.com/users/GeorgeJahad/following{/other_user}","gists_url":"https://api.github.com/users/GeorgeJahad/gists{/gist_id}","starred_url":"https://api.github.com/users/GeorgeJahad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GeorgeJahad/subscriptions","organizations_url":"https://api.github.com/users/GeorgeJahad/orgs","repos_url":"https://api.github.com/users/GeorgeJahad/repos","events_url":"https://api.github.com/users/GeorgeJahad/events{/privacy}","received_events_url":"https://api.github.com/users/GeorgeJahad/received_events","type":"User","site_admin":false},"body":"1. Removed AsyncChain class and associated tests.\r\n2. Replaced AsyncFunctionWithThreadPool class with FunctionWithThreadPool.\r\n3. Converted AsyncFunctionWithThreadPool's subclasses to use FunctionWithThreadPool instead\r\n4. Converted the users of AsyncChain to invoke each step of the chain individually.\r\n5. Added/fixed unit tests for the individual functions in the chain, (which didn't exist.)\r\n6. Added integration test for preaggregated metrics.\r\n7. Increased the http request timeout from 5 seconds to 1 minute, and changed the status\r\n   returned on timeout from 202 to 504, (GATEWAY_TIMEOUT).\r\n8. My understanding is the Udp ingestor code is basically deprecated.  Since it uses\r\n   AsyncChain as well, I had to update it, just to keep it compiling.  It didn't have\r\n   any tests, and I didn't add any.\r\n","created_at":"2015-01-13T19:31:19Z","updated_at":"2015-01-15T22:29:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8804c2c9662d005575e66655831c2bf87345fec5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rackerlabs/blueflood/pulls/416/commits","review_comments_url":"https://api.github.com/repos/rackerlabs/blueflood/pulls/416/comments","review_comment_url":"https://api.github.com/repos/rackerlabs/blueflood/pulls/comments/{number}","comments_url":"https://api.github.com/repos/rackerlabs/blueflood/issues/416/comments","statuses_url":"https://api.github.com/repos/rackerlabs/blueflood/statuses/429e917203d5a8c37acb37dd793304946b9689f2","head":{"label":"GeorgeJahad:george/remove_async_chain_rebase","ref":"george/remove_async_chain_rebase","sha":"429e917203d5a8c37acb37dd793304946b9689f2","user":{"login":"GeorgeJahad","id":86830,"avatar_url":"https://avatars.githubusercontent.com/u/86830?v=3","gravatar_id":"","url":"https://api.github.com/users/GeorgeJahad","html_url":"https://github.com/GeorgeJahad","followers_url":"https://api.github.com/users/GeorgeJahad/followers","following_url":"https://api.github.com/users/GeorgeJahad/following{/other_user}","gists_url":"https://api.github.com/users/GeorgeJahad/gists{/gist_id}","starred_url":"https://api.github.com/users/GeorgeJahad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GeorgeJahad/subscriptions","organizations_url":"https://api.github.com/users/GeorgeJahad/orgs","repos_url":"https://api.github.com/users/GeorgeJahad/repos","events_url":"https://api.github.com/users/GeorgeJahad/events{/privacy}","received_events_url":"https://api.github.com/users/GeorgeJahad/received_events","type":"User","site_admin":false},"repo":{"id":21632887,"name":"blueflood","full_name":"GeorgeJahad/blueflood","owner":{"login":"GeorgeJahad","id":86830,"avatar_url":"https://avatars.githubusercontent.com/u/86830?v=3","gravatar_id":"","url":"https://api.github.com/users/GeorgeJahad","html_url":"https://github.com/GeorgeJahad","followers_url":"https://api.github.com/users/GeorgeJahad/followers","following_url":"https://api.github.com/users/GeorgeJahad/following{/other_user}","gists_url":"https://api.github.com/users/GeorgeJahad/gists{/gist_id}","starred_url":"https://api.github.com/users/GeorgeJahad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GeorgeJahad/subscriptions","organizations_url":"https://api.github.com/users/GeorgeJahad/orgs","repos_url":"https://api.github.com/users/GeorgeJahad/repos","events_url":"https://api.github.com/users/GeorgeJahad/events{/privacy}","received_events_url":"https://api.github.com/users/GeorgeJahad/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/GeorgeJahad/blueflood","description":"A distributed system designed to ingest and process time series data","fork":true,"url":"https://api.github.com/repos/GeorgeJahad/blueflood","forks_url":"https://api.github.com/repos/GeorgeJahad/blueflood/forks","keys_url":"https://api.github.com/repos/GeorgeJahad/blueflood/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GeorgeJahad/blueflood/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GeorgeJahad/blueflood/teams","hooks_url":"https://api.github.com/repos/GeorgeJahad/blueflood/hooks","issue_events_url":"https://api.github.com/repos/GeorgeJahad/blueflood/issues/events{/number}","events_url":"https://api.github.com/repos/GeorgeJahad/blueflood/events","assignees_url":"https://api.github.com/repos/GeorgeJahad/blueflood/assignees{/user}","branches_url":"https://api.github.com/repos/GeorgeJahad/blueflood/branches{/branch}","tags_url":"https://api.github.com/repos/GeorgeJahad/blueflood/tags","blobs_url":"https://api.github.com/repos/GeorgeJahad/blueflood/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GeorgeJahad/blueflood/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GeorgeJahad/blueflood/git/refs{/sha}","trees_url":"https://api.github.com/repos/GeorgeJahad/blueflood/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GeorgeJahad/blueflood/statuses/{sha}","languages_url":"https://api.github.com/repos/GeorgeJahad/blueflood/languages","stargazers_url":"https://api.github.com/repos/GeorgeJahad/blueflood/stargazers","contributors_url":"https://api.github.com/repos/GeorgeJahad/blueflood/contributors","subscribers_url":"https://api.github.com/repos/GeorgeJahad/blueflood/subscribers","subscription_url":"https://api.github.com/repos/GeorgeJahad/blueflood/subscription","commits_url":"https://api.github.com/repos/GeorgeJahad/blueflood/commits{/sha}","git_commits_url":"https://api.github.com/repos/GeorgeJahad/blueflood/git/commits{/sha}","comments_url":"https://api.github.com/repos/GeorgeJahad/blueflood/comments{/number}","issue_comment_url":"https://api.github.com/repos/GeorgeJahad/blueflood/issues/comments/{number}","contents_url":"https://api.github.com/repos/GeorgeJahad/blueflood/contents/{+path}","compare_url":"https://api.github.com/repos/GeorgeJahad/blueflood/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GeorgeJahad/blueflood/merges","archive_url":"https://api.github.com/repos/GeorgeJahad/blueflood/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GeorgeJahad/blueflood/downloads","issues_url":"https://api.github.com/repos/GeorgeJahad/blueflood/issues{/number}","pulls_url":"https://api.github.com/repos/GeorgeJahad/blueflood/pulls{/number}","milestones_url":"https://api.github.com/repos/GeorgeJahad/blueflood/milestones{/number}","notifications_url":"https://api.github.com/repos/GeorgeJahad/blueflood/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GeorgeJahad/blueflood/labels{/name}","releases_url":"https://api.github.com/repos/GeorgeJahad/blueflood/releases{/id}","created_at":"2014-07-08T23:42:17Z","updated_at":"2014-07-08T23:54:07Z","pushed_at":"2015-01-13T19:24:41Z","git_url":"git://github.com/GeorgeJahad/blueflood.git","ssh_url":"git@github.com:GeorgeJahad/blueflood.git","clone_url":"https://github.com/GeorgeJahad/blueflood.git","svn_url":"https://github.com/GeorgeJahad/blueflood","homepage":"http://www.blueflood.io","size":3467,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rackerlabs:master","ref":"master","sha":"6c440fc04a465fd01e4ab84135c9b56c191a7f0c","user":{"login":"rackerlabs","id":84293,"avatar_url":"https://avatars.githubusercontent.com/u/84293?v=3","gravatar_id":"","url":"https://api.github.com/users/rackerlabs","html_url":"https://github.com/rackerlabs","followers_url":"https://api.github.com/users/rackerlabs/followers","following_url":"https://api.github.com/users/rackerlabs/following{/other_user}","gists_url":"https://api.github.com/users/rackerlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/rackerlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rackerlabs/subscriptions","organizations_url":"https://api.github.com/users/rackerlabs/orgs","repos_url":"https://api.github.com/users/rackerlabs/repos","events_url":"https://api.github.com/users/rackerlabs/events{/privacy}","received_events_url":"https://api.github.com/users/rackerlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":10081109,"name":"blueflood","full_name":"rackerlabs/blueflood","owner":{"login":"rackerlabs","id":84293,"avatar_url":"https://avatars.githubusercontent.com/u/84293?v=3","gravatar_id":"","url":"https://api.github.com/users/rackerlabs","html_url":"https://github.com/rackerlabs","followers_url":"https://api.github.com/users/rackerlabs/followers","following_url":"https://api.github.com/users/rackerlabs/following{/other_user}","gists_url":"https://api.github.com/users/rackerlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/rackerlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rackerlabs/subscriptions","organizations_url":"https://api.github.com/users/rackerlabs/orgs","repos_url":"https://api.github.com/users/rackerlabs/repos","events_url":"https://api.github.com/users/rackerlabs/events{/privacy}","received_events_url":"https://api.github.com/users/rackerlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rackerlabs/blueflood","description":"A distributed system designed to ingest and process time series data","fork":false,"url":"https://api.github.com/repos/rackerlabs/blueflood","forks_url":"https://api.github.com/repos/rackerlabs/blueflood/forks","keys_url":"https://api.github.com/repos/rackerlabs/blueflood/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rackerlabs/blueflood/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rackerlabs/blueflood/teams","hooks_url":"https://api.github.com/repos/rackerlabs/blueflood/hooks","issue_events_url":"https://api.github.com/repos/rackerlabs/blueflood/issues/events{/number}","events_url":"https://api.github.com/repos/rackerlabs/blueflood/events","assignees_url":"https://api.github.com/repos/rackerlabs/blueflood/assignees{/user}","branches_url":"https://api.github.com/repos/rackerlabs/blueflood/branches{/branch}","tags_url":"https://api.github.com/repos/rackerlabs/blueflood/tags","blobs_url":"https://api.github.com/repos/rackerlabs/blueflood/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rackerlabs/blueflood/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rackerlabs/blueflood/git/refs{/sha}","trees_url":"https://api.github.com/repos/rackerlabs/blueflood/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rackerlabs/blueflood/statuses/{sha}","languages_url":"https://api.github.com/repos/rackerlabs/blueflood/languages","stargazers_url":"https://api.github.com/repos/rackerlabs/blueflood/stargazers","contributors_url":"https://api.github.com/repos/rackerlabs/blueflood/contributors","subscribers_url":"https://api.github.com/repos/rackerlabs/blueflood/subscribers","subscription_url":"https://api.github.com/repos/rackerlabs/blueflood/subscription","commits_url":"https://api.github.com/repos/rackerlabs/blueflood/commits{/sha}","git_commits_url":"https://api.github.com/repos/rackerlabs/blueflood/git/commits{/sha}","comments_url":"https://api.github.com/repos/rackerlabs/blueflood/comments{/number}","issue_comment_url":"https://api.github.com/repos/rackerlabs/blueflood/issues/comments/{number}","contents_url":"https://api.github.com/repos/rackerlabs/blueflood/contents/{+path}","compare_url":"https://api.github.com/repos/rackerlabs/blueflood/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rackerlabs/blueflood/merges","archive_url":"https://api.github.com/repos/rackerlabs/blueflood/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rackerlabs/blueflood/downloads","issues_url":"https://api.github.com/repos/rackerlabs/blueflood/issues{/number}","pulls_url":"https://api.github.com/repos/rackerlabs/blueflood/pulls{/number}","milestones_url":"https://api.github.com/repos/rackerlabs/blueflood/milestones{/number}","notifications_url":"https://api.github.com/repos/rackerlabs/blueflood/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rackerlabs/blueflood/labels{/name}","releases_url":"https://api.github.com/repos/rackerlabs/blueflood/releases{/id}","created_at":"2013-05-15T14:50:39Z","updated_at":"2015-01-15T17:19:51Z","pushed_at":"2015-01-15T17:19:51Z","git_url":"git://github.com/rackerlabs/blueflood.git","ssh_url":"git@github.com:rackerlabs/blueflood.git","clone_url":"https://github.com/rackerlabs/blueflood.git","svn_url":"https://github.com/rackerlabs/blueflood","homepage":"http://www.blueflood.io","size":8658,"stargazers_count":261,"watchers_count":261,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":33,"mirror_url":null,"open_issues_count":29,"forks":33,"open_issues":29,"watchers":261,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rackerlabs/blueflood/pulls/416"},"html":{"href":"https://github.com/rackerlabs/blueflood/pull/416"},"issue":{"href":"https://api.github.com/repos/rackerlabs/blueflood/issues/416"},"comments":{"href":"https://api.github.com/repos/rackerlabs/blueflood/issues/416/comments"},"review_comments":{"href":"https://api.github.com/repos/rackerlabs/blueflood/pulls/416/comments"},"review_comment":{"href":"https://api.github.com/repos/rackerlabs/blueflood/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/rackerlabs/blueflood/pulls/416/commits"},"statuses":{"href":"https://api.github.com/repos/rackerlabs/blueflood/statuses/429e917203d5a8c37acb37dd793304946b9689f2"}}}}