{"action":"created","issue":{"url":"https://api.github.com/repos/jas-/node-libnmap/issues/16","labels_url":"https://api.github.com/repos/jas-/node-libnmap/issues/16/labels{/name}","comments_url":"https://api.github.com/repos/jas-/node-libnmap/issues/16/comments","events_url":"https://api.github.com/repos/jas-/node-libnmap/issues/16/events","html_url":"https://github.com/jas-/node-libnmap/issues/16","id":98254081,"number":16,"title":"Discuss: Use xml as output instead of cli output parsing","user":{"login":"mrzmyr","id":746429,"avatar_url":"https://avatars.githubusercontent.com/u/746429?v=3","gravatar_id":"","url":"https://api.github.com/users/mrzmyr","html_url":"https://github.com/mrzmyr","followers_url":"https://api.github.com/users/mrzmyr/followers","following_url":"https://api.github.com/users/mrzmyr/following{/other_user}","gists_url":"https://api.github.com/users/mrzmyr/gists{/gist_id}","starred_url":"https://api.github.com/users/mrzmyr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrzmyr/subscriptions","organizations_url":"https://api.github.com/users/mrzmyr/orgs","repos_url":"https://api.github.com/users/mrzmyr/repos","events_url":"https://api.github.com/users/mrzmyr/events{/privacy}","received_events_url":"https://api.github.com/users/mrzmyr/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2015-07-30T20:14:41Z","updated_at":"2015-08-05T00:01:29Z","closed_at":null,"body":"I came along with a few problems with the [`report`](https://github.com/jas-/node-libnmap/blob/master/lib/node-libnmap.js#L539) function. The parser didn't work well when passing in some different flag. So I decided to implement in [my fork](https://github.com/mrzmyr/node-libnmap/commit/21cbec2aece103df5f3aeec596bc9c50b85af524) a version where the XML output (`-oX -`) is used. This has the benefit that you have a way better control about the data you are getting out of the reports (basically all data which comes from `nmap`).\r\n\r\nAs I saw that you commented some better practices in my code, I thought about discussing if you would like to have this in your module as well and, if you do so, to discuss about a short feature list (as you already commented in the fork).\r\n\r\nWhat do you think?"},"comment":{"url":"https://api.github.com/repos/jas-/node-libnmap/issues/comments/127799901","html_url":"https://github.com/jas-/node-libnmap/issues/16#issuecomment-127799901","issue_url":"https://api.github.com/repos/jas-/node-libnmap/issues/16","id":127799901,"user":{"login":"jas-","id":422084,"avatar_url":"https://avatars.githubusercontent.com/u/422084?v=3","gravatar_id":"","url":"https://api.github.com/users/jas-","html_url":"https://github.com/jas-","followers_url":"https://api.github.com/users/jas-/followers","following_url":"https://api.github.com/users/jas-/following{/other_user}","gists_url":"https://api.github.com/users/jas-/gists{/gist_id}","starred_url":"https://api.github.com/users/jas-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jas-/subscriptions","organizations_url":"https://api.github.com/users/jas-/orgs","repos_url":"https://api.github.com/users/jas-/repos","events_url":"https://api.github.com/users/jas-/events{/privacy}","received_events_url":"https://api.github.com/users/jas-/received_events","type":"User","site_admin":false},"created_at":"2015-08-05T00:01:29Z","updated_at":"2015-08-05T00:01:29Z","body":"Oh, sure. In your [updated readme](https://github.com/mrzmyr/node-libnmap/blob/feature/replace-cli-parser-with-xml-parser/README.md#output-2) you provide two separate links; one under 'Flatten' which links to the function within the source code & the second provides a link to the nmap output documentation.\r\n\r\nI think both of those are un-necessary. Are you familiar with the [semantic versioning](http://semver.org/)?"}}