{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-reef/pulls/comments/37913859","id":37913859,"diff_hunk":"@@ -64,11 +66,13 @@ private YarnDriverRuntimeRestartManager(@Parameter(YarnEvaluatorPreserver.class)\n                                           final EvaluatorPreserver evaluatorPreserver,\n                                           final REEFEventHandlers reefEventHandlers,\n                                           final ApplicationMasterRegistration registration,\n-                                          final YarnContainerManager yarnContainerManager) {\n+                                          final YarnContainerManager yarnContainerManager,\n+                                          final RackNameFormatter rackNameFormatter) {\n     this.registration = registration;\n     this.evaluatorPreserver = evaluatorPreserver;\n     this.reefEventHandlers = reefEventHandlers;\n     this.yarnContainerManager = yarnContainerManager;\n+    this.rackNameFormatter = rackNameFormatter;","path":"lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/YarnDriverRuntimeRestartManager.java","position":27,"original_position":27,"commit_id":"35c5875729eb1922807ab9ffd314a0308d924701","original_commit_id":"35c5875729eb1922807ab9ffd314a0308d924701","user":{"login":"markusweimer","id":502371,"avatar_url":"https://avatars.githubusercontent.com/u/502371?v=3","gravatar_id":"","url":"https://api.github.com/users/markusweimer","html_url":"https://github.com/markusweimer","followers_url":"https://api.github.com/users/markusweimer/followers","following_url":"https://api.github.com/users/markusweimer/following{/other_user}","gists_url":"https://api.github.com/users/markusweimer/gists{/gist_id}","starred_url":"https://api.github.com/users/markusweimer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markusweimer/subscriptions","organizations_url":"https://api.github.com/users/markusweimer/orgs","repos_url":"https://api.github.com/users/markusweimer/repos","events_url":"https://api.github.com/users/markusweimer/events{/privacy}","received_events_url":"https://api.github.com/users/markusweimer/received_events","type":"User","site_admin":false},"body":"Odd. Wasn't this added in an earlier PR?","created_at":"2015-08-25T20:18:18Z","updated_at":"2015-08-25T20:18:18Z","html_url":"https://github.com/apache/incubator-reef/pull/408#discussion_r37913859","pull_request_url":"https://api.github.com/repos/apache/incubator-reef/pulls/408","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-reef/pulls/comments/37913859"},"html":{"href":"https://github.com/apache/incubator-reef/pull/408#discussion_r37913859"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-reef/pulls/408"}}},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-reef/pulls/408","id":43198678,"html_url":"https://github.com/apache/incubator-reef/pull/408","diff_url":"https://github.com/apache/incubator-reef/pull/408.diff","patch_url":"https://github.com/apache/incubator-reef/pull/408.patch","issue_url":"https://api.github.com/repos/apache/incubator-reef/issues/408","number":408,"state":"open","locked":false,"title":"[REEF-634] Add an object that encapsulates information needed to recover an evaluator on restart","user":{"login":"afchung","id":2817619,"avatar_url":"https://avatars.githubusercontent.com/u/2817619?v=3","gravatar_id":"","url":"https://api.github.com/users/afchung","html_url":"https://github.com/afchung","followers_url":"https://api.github.com/users/afchung/followers","following_url":"https://api.github.com/users/afchung/following{/other_user}","gists_url":"https://api.github.com/users/afchung/gists{/gist_id}","starred_url":"https://api.github.com/users/afchung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afchung/subscriptions","organizations_url":"https://api.github.com/users/afchung/orgs","repos_url":"https://api.github.com/users/afchung/repos","events_url":"https://api.github.com/users/afchung/events{/privacy}","received_events_url":"https://api.github.com/users/afchung/received_events","type":"User","site_admin":false},"body":"This addressed the issue by\r\n  * Creating ResourceRecoverEvent and changing EvaluatorRestartInfo to save the state of (potentially) restarted Evaluator.\r\n  * Creating the interface ResourceEvent and have ResourceAllocationEvent and ResourceRecoverEvent extend it.\r\n  * Have DriverRestartManager remember the status and other information of the evaluators to recover/fail on restart.\r\n\r\nJIRA:\r\n  [REEF-634](https://issues.apache.org/jira/browse/REEF-634)","created_at":"2015-08-24T17:16:43Z","updated_at":"2015-08-25T20:18:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4be28460e6cd02350098d7e57709d027c5b7783b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-reef/pulls/408/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-reef/pulls/408/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-reef/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-reef/issues/408/comments","statuses_url":"https://api.github.com/repos/apache/incubator-reef/statuses/35c5875729eb1922807ab9ffd314a0308d924701","head":{"label":"afchung:REEF-634","ref":"REEF-634","sha":"35c5875729eb1922807ab9ffd314a0308d924701","user":{"login":"afchung","id":2817619,"avatar_url":"https://avatars.githubusercontent.com/u/2817619?v=3","gravatar_id":"","url":"https://api.github.com/users/afchung","html_url":"https://github.com/afchung","followers_url":"https://api.github.com/users/afchung/followers","following_url":"https://api.github.com/users/afchung/following{/other_user}","gists_url":"https://api.github.com/users/afchung/gists{/gist_id}","starred_url":"https://api.github.com/users/afchung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afchung/subscriptions","organizations_url":"https://api.github.com/users/afchung/orgs","repos_url":"https://api.github.com/users/afchung/repos","events_url":"https://api.github.com/users/afchung/events{/privacy}","received_events_url":"https://api.github.com/users/afchung/received_events","type":"User","site_admin":false},"repo":{"id":31485914,"name":"incubator-reef","full_name":"afchung/incubator-reef","owner":{"login":"afchung","id":2817619,"avatar_url":"https://avatars.githubusercontent.com/u/2817619?v=3","gravatar_id":"","url":"https://api.github.com/users/afchung","html_url":"https://github.com/afchung","followers_url":"https://api.github.com/users/afchung/followers","following_url":"https://api.github.com/users/afchung/following{/other_user}","gists_url":"https://api.github.com/users/afchung/gists{/gist_id}","starred_url":"https://api.github.com/users/afchung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afchung/subscriptions","organizations_url":"https://api.github.com/users/afchung/orgs","repos_url":"https://api.github.com/users/afchung/repos","events_url":"https://api.github.com/users/afchung/events{/privacy}","received_events_url":"https://api.github.com/users/afchung/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/afchung/incubator-reef","description":"Mirror of Apache REEF (Incubating)","fork":true,"url":"https://api.github.com/repos/afchung/incubator-reef","forks_url":"https://api.github.com/repos/afchung/incubator-reef/forks","keys_url":"https://api.github.com/repos/afchung/incubator-reef/keys{/key_id}","collaborators_url":"https://api.github.com/repos/afchung/incubator-reef/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/afchung/incubator-reef/teams","hooks_url":"https://api.github.com/repos/afchung/incubator-reef/hooks","issue_events_url":"https://api.github.com/repos/afchung/incubator-reef/issues/events{/number}","events_url":"https://api.github.com/repos/afchung/incubator-reef/events","assignees_url":"https://api.github.com/repos/afchung/incubator-reef/assignees{/user}","branches_url":"https://api.github.com/repos/afchung/incubator-reef/branches{/branch}","tags_url":"https://api.github.com/repos/afchung/incubator-reef/tags","blobs_url":"https://api.github.com/repos/afchung/incubator-reef/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/afchung/incubator-reef/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/afchung/incubator-reef/git/refs{/sha}","trees_url":"https://api.github.com/repos/afchung/incubator-reef/git/trees{/sha}","statuses_url":"https://api.github.com/repos/afchung/incubator-reef/statuses/{sha}","languages_url":"https://api.github.com/repos/afchung/incubator-reef/languages","stargazers_url":"https://api.github.com/repos/afchung/incubator-reef/stargazers","contributors_url":"https://api.github.com/repos/afchung/incubator-reef/contributors","subscribers_url":"https://api.github.com/repos/afchung/incubator-reef/subscribers","subscription_url":"https://api.github.com/repos/afchung/incubator-reef/subscription","commits_url":"https://api.github.com/repos/afchung/incubator-reef/commits{/sha}","git_commits_url":"https://api.github.com/repos/afchung/incubator-reef/git/commits{/sha}","comments_url":"https://api.github.com/repos/afchung/incubator-reef/comments{/number}","issue_comment_url":"https://api.github.com/repos/afchung/incubator-reef/issues/comments{/number}","contents_url":"https://api.github.com/repos/afchung/incubator-reef/contents/{+path}","compare_url":"https://api.github.com/repos/afchung/incubator-reef/compare/{base}...{head}","merges_url":"https://api.github.com/repos/afchung/incubator-reef/merges","archive_url":"https://api.github.com/repos/afchung/incubator-reef/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/afchung/incubator-reef/downloads","issues_url":"https://api.github.com/repos/afchung/incubator-reef/issues{/number}","pulls_url":"https://api.github.com/repos/afchung/incubator-reef/pulls{/number}","milestones_url":"https://api.github.com/repos/afchung/incubator-reef/milestones{/number}","notifications_url":"https://api.github.com/repos/afchung/incubator-reef/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/afchung/incubator-reef/labels{/name}","releases_url":"https://api.github.com/repos/afchung/incubator-reef/releases{/id}","created_at":"2015-03-01T03:44:31Z","updated_at":"2015-05-06T05:54:15Z","pushed_at":"2015-08-25T16:33:49Z","git_url":"git://github.com/afchung/incubator-reef.git","ssh_url":"git@github.com:afchung/incubator-reef.git","clone_url":"https://github.com/afchung/incubator-reef.git","svn_url":"https://github.com/afchung/incubator-reef","homepage":null,"size":31119,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"1dd68f70e4760ec1e08692d09d0daccd8015e90f","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":25623941,"name":"incubator-reef","full_name":"apache/incubator-reef","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-reef","description":"Mirror of Apache REEF (Incubating)","fork":false,"url":"https://api.github.com/repos/apache/incubator-reef","forks_url":"https://api.github.com/repos/apache/incubator-reef/forks","keys_url":"https://api.github.com/repos/apache/incubator-reef/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-reef/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-reef/teams","hooks_url":"https://api.github.com/repos/apache/incubator-reef/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-reef/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-reef/events","assignees_url":"https://api.github.com/repos/apache/incubator-reef/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-reef/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-reef/tags","blobs_url":"https://api.github.com/repos/apache/incubator-reef/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-reef/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-reef/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-reef/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-reef/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-reef/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-reef/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-reef/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-reef/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-reef/subscription","commits_url":"https://api.github.com/repos/apache/incubator-reef/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-reef/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-reef/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-reef/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-reef/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-reef/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-reef/merges","archive_url":"https://api.github.com/repos/apache/incubator-reef/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-reef/downloads","issues_url":"https://api.github.com/repos/apache/incubator-reef/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-reef/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-reef/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-reef/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-reef/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-reef/releases{/id}","created_at":"2014-10-23T07:00:10Z","updated_at":"2015-08-04T17:05:33Z","pushed_at":"2015-08-25T19:17:08Z","git_url":"git://github.com/apache/incubator-reef.git","ssh_url":"git@github.com:apache/incubator-reef.git","clone_url":"https://github.com/apache/incubator-reef.git","svn_url":"https://github.com/apache/incubator-reef","homepage":null,"size":43597,"stargazers_count":24,"watchers_count":24,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":34,"mirror_url":"git://git.apache.org/incubator-reef.git","open_issues_count":5,"forks":34,"open_issues":5,"watchers":24,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-reef/pulls/408"},"html":{"href":"https://github.com/apache/incubator-reef/pull/408"},"issue":{"href":"https://api.github.com/repos/apache/incubator-reef/issues/408"},"comments":{"href":"https://api.github.com/repos/apache/incubator-reef/issues/408/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-reef/pulls/408/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-reef/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-reef/pulls/408/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-reef/statuses/35c5875729eb1922807ab9ffd314a0308d924701"}}}}