{"push_id":743616104,"size":14,"distinct_size":12,"ref":"refs/heads/2.8","head":"2655072bfdf5bef44c34495a01ec2470a82bcacb","before":"96e211d2daca33d7f1c9de1ccd52c5c5268a3914","commits":[{"sha":"3ad0794aa14aa929eb57886973640026ce7f9aa7","author":{"email":"0f27998afa7c877fc91ce38efb3333cf2b4c4f23@sessiondigital.de","name":"Tomaz Ahlin"},"message":"[DependencyInjection] fixed FrozenParameterBag and improved Parameter…","distinct":true,"url":"https://api.github.com/repos/sgehrig/symfony/commits/3ad0794aa14aa929eb57886973640026ce7f9aa7"},{"sha":"f1ebfd7b4720db419ff6905b9eccec05729bcd0b","author":{"email":"d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com","name":"Fabien Potencier"},"message":"minor #15172 [DependencyInjection] fixed FrozenParameterBag and improved Parameter… (Tomaz Ahlin)\n\nThis PR was squashed before being merged into the 2.3 branch (closes #15172).\n\nDiscussion\n----------\n\n[DependencyInjection] fixed FrozenParameterBag and improved Parameter…\n\nThe ParameterBagInterface was missing some @throws annotations, so the FrozenParameterBag class was a violation of Liskov subtitution principle. Also the ParameterBagInterface was missing the remove method.\n\n(Optionally the ParameterBagInterface can be later split into two smaller interfaces, because the FrozenParameterBag shouldn't have the add, remove methods in the first place.)\n\n| Q             | A\n| ------------- | ---\n| Bug fix?      | yes\n| New feature?  | no\n| BC breaks?    | yes\n| Deprecations? | no\n| Tests pass?   | yes\n| Fixed tickets |\n| License       | MIT\n| Doc PR        |\n\nI have also fixed removing elements from FrozenParameterBag, as introduced by @satahippy\nhttps://github.com/symfony/DependencyInjection/pull/8\n\nCommits\n-------\n\n3ad0794 [DependencyInjection] fixed FrozenParameterBag and improved Parameter…","distinct":true,"url":"https://api.github.com/repos/sgehrig/symfony/commits/f1ebfd7b4720db419ff6905b9eccec05729bcd0b"},{"sha":"32d964ba3946cdc8572f0b95288b5c3446b24cfc","author":{"email":"e274eeff768c6396088ec6eb091f4bf4d47ab1e0@mattfarmer.net","name":"Matt Farmer"},"message":"Fix calls to HttpCache#getSurrogate triggering E_USER_DEPRECATED errors.","distinct":false,"url":"https://api.github.com/repos/sgehrig/symfony/commits/32d964ba3946cdc8572f0b95288b5c3446b24cfc"},{"sha":"0252e4e2e44e308b88eed89993d8263db3abfbdb","author":{"email":"d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com","name":"Fabien Potencier"},"message":"bug #15306 [HttpKernel] [HttpCache] Fix deprecated error in HttpCache#getSurrogate (m14t)\n\nThis PR was submitted for the 2.8 branch but it was merged into the 2.7 branch instead (closes #15306).\n\nDiscussion\n----------\n\n[HttpKernel] [HttpCache] Fix deprecated error in HttpCache#getSurrogate\n\n| Q             | A\n| ------------- | ---\n| Bug fix?      | yes? - I could not find an open issue, but it does appear to be a but to throw a `E_USER_DEPRECATED` when calling a non-depreciated method.\n| New feature?  | no\n| BC breaks?    | no\n| Deprecations? | no - but related to\n| Tests pass?   | yes\n| Fixed tickets |\n| License       | MIT\n| Doc PR        |\n\nCurrently calls to `HttpCache#getEsi` correctly trigger a `E_USER_DEPRECATED` error and inform the user that they should instead use `HttpCache#getSurrogate`.\n\nUnfortunately `HttpCache#getSurrogate` currently calls `$this->getEsi();` which will result in the `E_USER_DEPRECATED` still being triggered.\n\nThis pull request simply moves the logic that was previously in `getEsi` to `getSurrogate`, and leaves `getEsi` as a wrapper around `getSurrogate` with the addition of also triggering this warning.\n\nThis pull request also effects the 2.7 branch.\n\nCommits\n-------\n\n32d964b Fix calls to HttpCache#getSurrogate triggering E_USER_DEPRECATED errors.","distinct":false,"url":"https://api.github.com/repos/sgehrig/symfony/commits/0252e4e2e44e308b88eed89993d8263db3abfbdb"},{"sha":"335825363de8bac4d0dd55d9e82e19bdc963a252","author":{"email":"9fc93db08bc68d0ea66821ec756907c610496bea@lyrixx.info","name":"Grégoire Pineau"},"message":"[Security] Do not save the target path in the session for a stateless firewall","distinct":true,"url":"https://api.github.com/repos/sgehrig/symfony/commits/335825363de8bac4d0dd55d9e82e19bdc963a252"},{"sha":"633d0d835c4d7f10059524ddc7943c429d0d0ce7","author":{"email":"d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com","name":"Fabien Potencier"},"message":"bug #15355 [Security] Do not save the target path in the session for a stateless firewall (lyrixx)\n\nThis PR was submitted for the 2.8 branch but it was merged into the 2.3 branch instead (closes #15355).\n\nDiscussion\n----------\n\n[Security] Do not save the target path in the session for a stateless firewall\n\n| Q             | A\n| ------------- | ---\n| Bug fix?      | partially\n| New feature?  | partially\n| BC breaks?    | no\n| Deprecations? | no\n| Tests pass?   | -\n| Fixed tickets | -\n| License       | MIT\n| Doc PR        | -\n\nNote: I think this PR can be merged into 2.3 because it's like a bug fix\n\nCommits\n-------\n\n3358253 [Security] Do not save the target path in the session for a stateless firewall","distinct":true,"url":"https://api.github.com/repos/sgehrig/symfony/commits/633d0d835c4d7f10059524ddc7943c429d0d0ce7"},{"sha":"0e934637dfc8e43f288adf6874cc57abc977be34","author":{"email":"b3f594e10a9edcf5413cf1190121d45078c62290@derusse.com","name":"Jérémy Derussé"},"message":"Small optimization in AccessDecisionManager","distinct":true,"url":"https://api.github.com/repos/sgehrig/symfony/commits/0e934637dfc8e43f288adf6874cc57abc977be34"},{"sha":"77ee866dd8601300209cc44ab5e2975bdb0b22ed","author":{"email":"8d3fadd4fad95f65a95a07af54a8b1c515d4d5e3@gmail.com","name":"Nicolas Grekas"},"message":"[php7] Fix for substr() always returning a string","distinct":true,"url":"https://api.github.com/repos/sgehrig/symfony/commits/77ee866dd8601300209cc44ab5e2975bdb0b22ed"},{"sha":"ccf52ecd6e6c201d026e2f7de245bb1db71fb00a","author":{"email":"d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com","name":"Fabien Potencier"},"message":"bug #15386 [php7] Fix for substr() always returning a string (nicolas-grekas)\n\nThis PR was merged into the 2.3 branch.\n\nDiscussion\n----------\n\n[php7] Fix for substr() always returning a string\n\n| Q             | A\n| ------------- | ---\n| Bug fix?      | yes\n| New feature?  | no\n| BC breaks?    | no\n| Deprecations? | no\n| Tests pass?   | yes\n| Fixed tickets | #14086\n| License       | MIT\n| Doc PR        | -\n\nThis should be the last required fix for PHP7 support.\n\nThe patch in the debug component is a workaround for a bug in PHP7 (http://3v4l.org/8rm9B) that is going to be fixed soon (@jpauli power).\n\nCommits\n-------\n\n77ee866 [php7] Fix for substr() always returning a string","distinct":true,"url":"https://api.github.com/repos/sgehrig/symfony/commits/ccf52ecd6e6c201d026e2f7de245bb1db71fb00a"},{"sha":"c37387dc02f8f5373ea76fa670b36772fdf5aee4","author":{"email":"8d3fadd4fad95f65a95a07af54a8b1c515d4d5e3@gmail.com","name":"Nicolas Grekas"},"message":"Merge branch '2.3' into 2.7\n\n* 2.3:\n  [php7] Fix for substr() always returning a string\n  [Security] Do not save the target path in the session for a stateless firewall\n  [DependencyInjection] fixed FrozenParameterBag and improved Parameter…\n\nConflicts:\n\tsrc/Symfony/Component/Debug/Tests/ErrorHandlerTest.php\n\tsrc/Symfony/Component/Security/Http/Firewall/ExceptionListener.php","distinct":true,"url":"https://api.github.com/repos/sgehrig/symfony/commits/c37387dc02f8f5373ea76fa670b36772fdf5aee4"},{"sha":"d6dfe9871c4e4e0c2912c8019c75aeccd801a42c","author":{"email":"8d3fadd4fad95f65a95a07af54a8b1c515d4d5e3@gmail.com","name":"Nicolas Grekas"},"message":"[php7] Fix for substr() always returning a string","distinct":true,"url":"https://api.github.com/repos/sgehrig/symfony/commits/d6dfe9871c4e4e0c2912c8019c75aeccd801a42c"},{"sha":"342c4b5fd1f13e714a3d56aeced6daa09fbab866","author":{"email":"d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com","name":"Fabien Potencier"},"message":"bug #15390 [php7] Fix for substr() always returning a string (nicolas-grekas)\n\nThis PR was merged into the 2.7 branch.\n\nDiscussion\n----------\n\n[php7] Fix for substr() always returning a string\n\n| Q             | A\n| ------------- | ---\n| Bug fix?      | yes\n| New feature?  | no\n| BC breaks?    | no\n| Deprecations? | no\n| Tests pass?   | yes\n| Fixed tickets | #14086\n| License       | MIT\n| Doc PR        | -\n\nThe remaining failures will stop once https://bugs.php.net/bug.php?id=70159 is fixed ([patch pending](https://github.com/php/php-src/commit/a28115ccdb11301a418cc748ef7716a1687cc585)).\n\nCommits\n-------\n\nd6dfe98 [php7] Fix for substr() always returning a string","distinct":true,"url":"https://api.github.com/repos/sgehrig/symfony/commits/342c4b5fd1f13e714a3d56aeced6daa09fbab866"},{"sha":"1fd70891d32de9bd02b5c7eedb6c3a8ea644de9e","author":{"email":"d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com","name":"Fabien Potencier"},"message":"minor #15383 [Security] Small optimization in AccessDecisionManager (jderusse)\n\nThis PR was merged into the 2.8 branch.\n\nDiscussion\n----------\n\n[Security] Small optimization in AccessDecisionManager\n\n| Q             | A\n| ------------- | ---\n| Bug fix?      | no\n| New feature?  | yes\n| BC breaks?    | no\n| Deprecations? | no\n| Tests pass?   | yes\n| Fixed tickets | na\n| License       | MIT\n| Doc PR        | na\n\n- Remove unused variable `$abstain`\n- Remove equals comparison: if not `$grant > $deny` and not `$deny > $grant` then `$grant` equals `$deny`\n\nCommits\n-------\n\n0e93463 Small optimization in AccessDecisionManager","distinct":true,"url":"https://api.github.com/repos/sgehrig/symfony/commits/1fd70891d32de9bd02b5c7eedb6c3a8ea644de9e"},{"sha":"2655072bfdf5bef44c34495a01ec2470a82bcacb","author":{"email":"8d3fadd4fad95f65a95a07af54a8b1c515d4d5e3@gmail.com","name":"Nicolas Grekas"},"message":"Merge branch '2.7' into 2.8\n\n* 2.7:\n  [php7] Fix for substr() always returning a string\n  [Security] Do not save the target path in the session for a stateless firewall\n  Fix calls to HttpCache#getSurrogate triggering E_USER_DEPRECATED errors.\n  [DependencyInjection] fixed FrozenParameterBag and improved Parameter…","distinct":true,"url":"https://api.github.com/repos/sgehrig/symfony/commits/2655072bfdf5bef44c34495a01ec2470a82bcacb"}]}