{"action":"created","issue":{"url":"https://api.github.com/repos/sequelize/sequelize/issues/5113","labels_url":"https://api.github.com/repos/sequelize/sequelize/issues/5113/labels{/name}","comments_url":"https://api.github.com/repos/sequelize/sequelize/issues/5113/comments","events_url":"https://api.github.com/repos/sequelize/sequelize/issues/5113/events","html_url":"https://github.com/sequelize/sequelize/pull/5113","id":124235132,"number":5113,"title":"Add support for scope in has-one association","user":{"login":"Verdier","id":2900150,"avatar_url":"https://avatars.githubusercontent.com/u/2900150?v=3","gravatar_id":"","url":"https://api.github.com/users/Verdier","html_url":"https://github.com/Verdier","followers_url":"https://api.github.com/users/Verdier/followers","following_url":"https://api.github.com/users/Verdier/following{/other_user}","gists_url":"https://api.github.com/users/Verdier/gists{/gist_id}","starred_url":"https://api.github.com/users/Verdier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Verdier/subscriptions","organizations_url":"https://api.github.com/users/Verdier/orgs","repos_url":"https://api.github.com/users/Verdier/repos","events_url":"https://api.github.com/users/Verdier/events{/privacy}","received_events_url":"https://api.github.com/users/Verdier/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-12-29T16:30:58Z","updated_at":"2015-12-29T20:49:51Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/sequelize/sequelize/pulls/5113","html_url":"https://github.com/sequelize/sequelize/pull/5113","diff_url":"https://github.com/sequelize/sequelize/pull/5113.diff","patch_url":"https://github.com/sequelize/sequelize/pull/5113.patch"},"body":"This PR fix two issues:\r\n- the association's `scope` was not injected in `where` clause when eager loaded. This is **extremely critical** because any *raw* that match without the `where` restriction is eager loaded, that could result in sending private data to the client (that's what append to us...),\r\n- the association's `scope` was not used is the creator helper method (ie. `createInstance`)"},"comment":{"url":"https://api.github.com/repos/sequelize/sequelize/issues/comments/167875281","html_url":"https://github.com/sequelize/sequelize/pull/5113#issuecomment-167875281","issue_url":"https://api.github.com/repos/sequelize/sequelize/issues/5113","id":167875281,"user":{"login":"Verdier","id":2900150,"avatar_url":"https://avatars.githubusercontent.com/u/2900150?v=3","gravatar_id":"","url":"https://api.github.com/users/Verdier","html_url":"https://github.com/Verdier","followers_url":"https://api.github.com/users/Verdier/followers","following_url":"https://api.github.com/users/Verdier/following{/other_user}","gists_url":"https://api.github.com/users/Verdier/gists{/gist_id}","starred_url":"https://api.github.com/users/Verdier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Verdier/subscriptions","organizations_url":"https://api.github.com/users/Verdier/orgs","repos_url":"https://api.github.com/users/Verdier/repos","events_url":"https://api.github.com/users/Verdier/events{/privacy}","received_events_url":"https://api.github.com/users/Verdier/received_events","type":"User","site_admin":false},"created_at":"2015-12-29T20:49:51Z","updated_at":"2015-12-29T20:49:51Z","body":"@mickhansen done. Ready to merge."}}