{"action":"created","comment":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/38200671","id":38200671,"diff_hunk":"@@ -20,14 +20,27 @@\n \n #include <cstdlib>\n \n+#include \"xbmc/ApplicationMessenger.h\"","path":"xbmc/network/linux/NetworkLinux.cpp","position":4,"original_position":4,"commit_id":"1e2f2aa43e24e41310ffb127a425473443789252","original_commit_id":"1e2f2aa43e24e41310ffb127a425473443789252","user":{"login":"hudokkow","id":516183,"avatar_url":"https://avatars.githubusercontent.com/u/516183?v=3","gravatar_id":"","url":"https://api.github.com/users/hudokkow","html_url":"https://github.com/hudokkow","followers_url":"https://api.github.com/users/hudokkow/followers","following_url":"https://api.github.com/users/hudokkow/following{/other_user}","gists_url":"https://api.github.com/users/hudokkow/gists{/gist_id}","starred_url":"https://api.github.com/users/hudokkow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hudokkow/subscriptions","organizations_url":"https://api.github.com/users/hudokkow/orgs","repos_url":"https://api.github.com/users/hudokkow/repos","events_url":"https://api.github.com/users/hudokkow/events{/privacy}","received_events_url":"https://api.github.com/users/hudokkow/received_events","type":"User","site_admin":false},"body":"#include \"xbmc/messaging/ApplicationMessenger.h\"\r\n\r\nChanged in https://github.com/xbmc/xbmc/pull/7268","created_at":"2015-08-28T13:47:22Z","updated_at":"2015-08-28T13:47:22Z","html_url":"https://github.com/xbmc/xbmc/pull/7030#discussion_r38200671","pull_request_url":"https://api.github.com/repos/xbmc/xbmc/pulls/7030","_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/38200671"},"html":{"href":"https://github.com/xbmc/xbmc/pull/7030#discussion_r38200671"},"pull_request":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/7030"}}},"pull_request":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/7030","id":34324134,"html_url":"https://github.com/xbmc/xbmc/pull/7030","diff_url":"https://github.com/xbmc/xbmc/pull/7030.diff","patch_url":"https://github.com/xbmc/xbmc/pull/7030.patch","issue_url":"https://api.github.com/repos/xbmc/xbmc/issues/7030","number":7030,"state":"open","locked":false,"title":"CNetwork - implement IPv6","user":{"login":"mk01","id":3136693,"avatar_url":"https://avatars.githubusercontent.com/u/3136693?v=3","gravatar_id":"","url":"https://api.github.com/users/mk01","html_url":"https://github.com/mk01","followers_url":"https://api.github.com/users/mk01/followers","following_url":"https://api.github.com/users/mk01/following{/other_user}","gists_url":"https://api.github.com/users/mk01/gists{/gist_id}","starred_url":"https://api.github.com/users/mk01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mk01/subscriptions","organizations_url":"https://api.github.com/users/mk01/orgs","repos_url":"https://api.github.com/users/mk01/repos","events_url":"https://api.github.com/users/mk01/events{/privacy}","received_events_url":"https://api.github.com/users/mk01/received_events","type":"User","site_admin":false},"body":"We are changing class CDNSNameCache:\r\n- code was updated to not hardcode X.X.X.X as before\r\n- obsolete calls (gethostbyname()) removed / replaced\r\n\r\n- all previous checks and host info fetch via this function (and forced AF_INET) was changed to family AF_UNSPEC and new getaddrinfo()\r\n- the final name -> ip translation is now IPv6 compatible and done via new function \r\nGetIpStr() - which was moved to CNetwork class (as this particular lookup is used on more places within the networking code - with basically all code be somehow inherited from that class\r\n\r\n- use of NFSClient triggers refreshing of CNetwork information (interfaces, it's state & flags)\r\n- because CNetwork code responsible for fetching the low-level info was also using IPv6 not compatible calls (ioctl via SIOC* commands), the bare minimum was changed as well.\r\n\r\nas a final result of those changes, libNFS now properly works with IPv6 hosts, native ipv6-only targets are fine, 6over4 too. syntax is the same as before (in case hostname is used), ipv6 IP addresses has to be enclosed in [] eg.\r\n\r\n   nfs://[fd00::3]/exportnfs/media\r\n","created_at":"2015-04-29T00:13:16Z","updated_at":"2015-08-28T13:47:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d7b3e2b719859414e990979728ebbce91799a60f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/xbmc/xbmc/pulls/7030/commits","review_comments_url":"https://api.github.com/repos/xbmc/xbmc/pulls/7030/comments","review_comment_url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xbmc/xbmc/issues/7030/comments","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/1e2f2aa43e24e41310ffb127a425473443789252","head":{"label":"mk01:master_par","ref":"master_par","sha":"1e2f2aa43e24e41310ffb127a425473443789252","user":{"login":"mk01","id":3136693,"avatar_url":"https://avatars.githubusercontent.com/u/3136693?v=3","gravatar_id":"","url":"https://api.github.com/users/mk01","html_url":"https://github.com/mk01","followers_url":"https://api.github.com/users/mk01/followers","following_url":"https://api.github.com/users/mk01/following{/other_user}","gists_url":"https://api.github.com/users/mk01/gists{/gist_id}","starred_url":"https://api.github.com/users/mk01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mk01/subscriptions","organizations_url":"https://api.github.com/users/mk01/orgs","repos_url":"https://api.github.com/users/mk01/repos","events_url":"https://api.github.com/users/mk01/events{/privacy}","received_events_url":"https://api.github.com/users/mk01/received_events","type":"User","site_admin":false},"repo":{"id":34284175,"name":"xbmc","full_name":"mk01/xbmc","owner":{"login":"mk01","id":3136693,"avatar_url":"https://avatars.githubusercontent.com/u/3136693?v=3","gravatar_id":"","url":"https://api.github.com/users/mk01","html_url":"https://github.com/mk01","followers_url":"https://api.github.com/users/mk01/followers","following_url":"https://api.github.com/users/mk01/following{/other_user}","gists_url":"https://api.github.com/users/mk01/gists{/gist_id}","starred_url":"https://api.github.com/users/mk01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mk01/subscriptions","organizations_url":"https://api.github.com/users/mk01/orgs","repos_url":"https://api.github.com/users/mk01/repos","events_url":"https://api.github.com/users/mk01/events{/privacy}","received_events_url":"https://api.github.com/users/mk01/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mk01/xbmc","description":"Kodi Main Repository - By using this code you agree with our policy and will follow the GPLv2 license as included","fork":true,"url":"https://api.github.com/repos/mk01/xbmc","forks_url":"https://api.github.com/repos/mk01/xbmc/forks","keys_url":"https://api.github.com/repos/mk01/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mk01/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mk01/xbmc/teams","hooks_url":"https://api.github.com/repos/mk01/xbmc/hooks","issue_events_url":"https://api.github.com/repos/mk01/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/mk01/xbmc/events","assignees_url":"https://api.github.com/repos/mk01/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/mk01/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/mk01/xbmc/tags","blobs_url":"https://api.github.com/repos/mk01/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mk01/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mk01/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/mk01/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mk01/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/mk01/xbmc/languages","stargazers_url":"https://api.github.com/repos/mk01/xbmc/stargazers","contributors_url":"https://api.github.com/repos/mk01/xbmc/contributors","subscribers_url":"https://api.github.com/repos/mk01/xbmc/subscribers","subscription_url":"https://api.github.com/repos/mk01/xbmc/subscription","commits_url":"https://api.github.com/repos/mk01/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/mk01/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/mk01/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/mk01/xbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/mk01/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/mk01/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mk01/xbmc/merges","archive_url":"https://api.github.com/repos/mk01/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mk01/xbmc/downloads","issues_url":"https://api.github.com/repos/mk01/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/mk01/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/mk01/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/mk01/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mk01/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/mk01/xbmc/releases{/id}","created_at":"2015-04-20T20:20:26Z","updated_at":"2015-04-28T12:26:00Z","pushed_at":"2015-08-26T20:48:08Z","git_url":"git://github.com/mk01/xbmc.git","ssh_url":"git@github.com:mk01/xbmc.git","clone_url":"https://github.com/mk01/xbmc.git","svn_url":"https://github.com/mk01/xbmc","homepage":"http://kodi.wiki/view/Official:Trademark_Policy","size":532882,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xbmc:master","ref":"master","sha":"7121243316f8c9742fbee11bd0dbcf162816c221","user":{"login":"xbmc","id":199122,"avatar_url":"https://avatars.githubusercontent.com/u/199122?v=3","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"repo":{"id":1217614,"name":"xbmc","full_name":"xbmc/xbmc","owner":{"login":"xbmc","id":199122,"avatar_url":"https://avatars.githubusercontent.com/u/199122?v=3","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xbmc/xbmc","description":"Kodi Main Repository - By using this code you agree with our policy and will follow the GPLv2 license as included","fork":false,"url":"https://api.github.com/repos/xbmc/xbmc","forks_url":"https://api.github.com/repos/xbmc/xbmc/forks","keys_url":"https://api.github.com/repos/xbmc/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xbmc/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xbmc/xbmc/teams","hooks_url":"https://api.github.com/repos/xbmc/xbmc/hooks","issue_events_url":"https://api.github.com/repos/xbmc/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/xbmc/xbmc/events","assignees_url":"https://api.github.com/repos/xbmc/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/xbmc/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/xbmc/xbmc/tags","blobs_url":"https://api.github.com/repos/xbmc/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xbmc/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xbmc/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/xbmc/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/xbmc/xbmc/languages","stargazers_url":"https://api.github.com/repos/xbmc/xbmc/stargazers","contributors_url":"https://api.github.com/repos/xbmc/xbmc/contributors","subscribers_url":"https://api.github.com/repos/xbmc/xbmc/subscribers","subscription_url":"https://api.github.com/repos/xbmc/xbmc/subscription","commits_url":"https://api.github.com/repos/xbmc/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/xbmc/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/xbmc/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/xbmc/xbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/xbmc/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/xbmc/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xbmc/xbmc/merges","archive_url":"https://api.github.com/repos/xbmc/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xbmc/xbmc/downloads","issues_url":"https://api.github.com/repos/xbmc/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/xbmc/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/xbmc/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/xbmc/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xbmc/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/xbmc/xbmc/releases{/id}","created_at":"2011-01-03T21:18:51Z","updated_at":"2015-08-28T07:56:50Z","pushed_at":"2015-08-28T13:23:58Z","git_url":"git://github.com/xbmc/xbmc.git","ssh_url":"git@github.com:xbmc/xbmc.git","clone_url":"https://github.com/xbmc/xbmc.git","svn_url":"https://github.com/xbmc/xbmc","homepage":"http://kodi.wiki/view/Official:Trademark_Policy","size":1884008,"stargazers_count":4071,"watchers_count":4071,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2984,"mirror_url":null,"open_issues_count":225,"forks":2984,"open_issues":225,"watchers":4071,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/7030"},"html":{"href":"https://github.com/xbmc/xbmc/pull/7030"},"issue":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/7030"},"comments":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/7030/comments"},"review_comments":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/7030/comments"},"review_comment":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/7030/commits"},"statuses":{"href":"https://api.github.com/repos/xbmc/xbmc/statuses/1e2f2aa43e24e41310ffb127a425473443789252"}}}}