{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/pulls/comments/26533962","id":26533962,"diff_hunk":"@@ -17,7 +16,53 @@\n \n ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;\n ;;; Constants / Defaults\n+;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;\n+;;;\n+;;; NOTE: We are making a decisive move away from overriding Jetty's\n+;;; implicit default values for settings when downstream TK apps do not\n+;;; explicitly provide values for them.  Please see the comments/tests in\n+;;; `jetty9_default_config_test.clj` for full details.\n+;;;\n+;;; Below we are making a handful of deliberate exceptions to this rule,\n+;;; but please do not perpetuate this pattern without a compelling reason to\n+;;; do so.\n+\n+\n+;;;\n+;;; Host/port settings\n+;;;\n+;;; These are really common and fairly benign, and removing them would probably\n+;;; only serve to make the bare configuration more onerous.\n+;;;\n+(def default-http-port 8080)\n+(def default-https-port 8081)\n+(def default-host \"localhost\")","path":"src/puppetlabs/trapperkeeper/services/webserver/jetty9_config.clj","position":37,"original_position":37,"commit_id":"60e12ecf49c4f77299943d0d715530b33e7f067c","original_commit_id":"60e12ecf49c4f77299943d0d715530b33e7f067c","user":{"login":"cprice404","id":1341071,"avatar_url":"https://avatars.githubusercontent.com/u/1341071?v=3","gravatar_id":"","url":"https://api.github.com/users/cprice404","html_url":"https://github.com/cprice404","followers_url":"https://api.github.com/users/cprice404/followers","following_url":"https://api.github.com/users/cprice404/following{/other_user}","gists_url":"https://api.github.com/users/cprice404/gists{/gist_id}","starred_url":"https://api.github.com/users/cprice404/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cprice404/subscriptions","organizations_url":"https://api.github.com/users/cprice404/orgs","repos_url":"https://api.github.com/users/cprice404/repos","events_url":"https://api.github.com/users/cprice404/events{/privacy}","received_events_url":"https://api.github.com/users/cprice404/received_events","type":"User","site_admin":false},"body":"Yeah; and `localhost` is what we've always used here, didn't see a great reason to change it.","created_at":"2015-03-16T22:27:29Z","updated_at":"2015-03-16T22:27:29Z","html_url":"https://github.com/puppetlabs/trapperkeeper-webserver-jetty9/pull/112#discussion_r26533962","pull_request_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/pulls/112","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/pulls/comments/26533962"},"html":{"href":"https://github.com/puppetlabs/trapperkeeper-webserver-jetty9/pull/112#discussion_r26533962"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/pulls/112"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/pulls/112","id":31169465,"html_url":"https://github.com/puppetlabs/trapperkeeper-webserver-jetty9/pull/112","diff_url":"https://github.com/puppetlabs/trapperkeeper-webserver-jetty9/pull/112.diff","patch_url":"https://github.com/puppetlabs/trapperkeeper-webserver-jetty9/pull/112.patch","issue_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/issues/112","number":112,"state":"open","locked":false,"title":"(TK-168) remove hardcoded jetty defaults","user":{"login":"cprice404","id":1341071,"avatar_url":"https://avatars.githubusercontent.com/u/1341071?v=3","gravatar_id":"","url":"https://api.github.com/users/cprice404","html_url":"https://github.com/cprice404","followers_url":"https://api.github.com/users/cprice404/followers","following_url":"https://api.github.com/users/cprice404/following{/other_user}","gists_url":"https://api.github.com/users/cprice404/gists{/gist_id}","starred_url":"https://api.github.com/users/cprice404/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cprice404/subscriptions","organizations_url":"https://api.github.com/users/cprice404/orgs","repos_url":"https://api.github.com/users/cprice404/repos","events_url":"https://api.github.com/users/cprice404/events{/privacy}","received_events_url":"https://api.github.com/users/cprice404/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-03-13T22:29:15Z","updated_at":"2015-03-16T22:27:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eaaa258701a7440d78a3168b1bb261ce317cbef8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/pulls/112/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/pulls/112/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/issues/112/comments","statuses_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/statuses/60e12ecf49c4f77299943d0d715530b33e7f067c","head":{"label":"cprice404:maint/master/TK-168-hardcode-jetty-defaults","ref":"maint/master/TK-168-hardcode-jetty-defaults","sha":"60e12ecf49c4f77299943d0d715530b33e7f067c","user":{"login":"cprice404","id":1341071,"avatar_url":"https://avatars.githubusercontent.com/u/1341071?v=3","gravatar_id":"","url":"https://api.github.com/users/cprice404","html_url":"https://github.com/cprice404","followers_url":"https://api.github.com/users/cprice404/followers","following_url":"https://api.github.com/users/cprice404/following{/other_user}","gists_url":"https://api.github.com/users/cprice404/gists{/gist_id}","starred_url":"https://api.github.com/users/cprice404/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cprice404/subscriptions","organizations_url":"https://api.github.com/users/cprice404/orgs","repos_url":"https://api.github.com/users/cprice404/repos","events_url":"https://api.github.com/users/cprice404/events{/privacy}","received_events_url":"https://api.github.com/users/cprice404/received_events","type":"User","site_admin":false},"repo":{"id":16051714,"name":"trapperkeeper-webserver-jetty9","full_name":"cprice404/trapperkeeper-webserver-jetty9","owner":{"login":"cprice404","id":1341071,"avatar_url":"https://avatars.githubusercontent.com/u/1341071?v=3","gravatar_id":"","url":"https://api.github.com/users/cprice404","html_url":"https://github.com/cprice404","followers_url":"https://api.github.com/users/cprice404/followers","following_url":"https://api.github.com/users/cprice404/following{/other_user}","gists_url":"https://api.github.com/users/cprice404/gists{/gist_id}","starred_url":"https://api.github.com/users/cprice404/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cprice404/subscriptions","organizations_url":"https://api.github.com/users/cprice404/orgs","repos_url":"https://api.github.com/users/cprice404/repos","events_url":"https://api.github.com/users/cprice404/events{/privacy}","received_events_url":"https://api.github.com/users/cprice404/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cprice404/trapperkeeper-webserver-jetty9","description":"Trapperkeeper webservice service (jetty9 implementation)","fork":true,"url":"https://api.github.com/repos/cprice404/trapperkeeper-webserver-jetty9","forks_url":"https://api.github.com/repos/cprice404/trapperkeeper-webserver-jetty9/forks","keys_url":"https://api.github.com/repos/cprice404/trapperkeeper-webserver-jetty9/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cprice404/trapperkeeper-webserver-jetty9/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cprice404/trapperkeeper-webserver-jetty9/teams","hooks_url":"https://api.github.com/repos/cprice404/trapperkeeper-webserver-jetty9/hooks","issue_events_url":"https://api.github.com/repos/cprice404/trapperkeeper-webserver-jetty9/issues/events{/number}","events_url":"https://api.github.com/repos/cprice404/trapperkeeper-webserver-jetty9/events","assignees_url":"https://api.github.com/repos/cprice404/trapperkeeper-webserver-jetty9/assignees{/user}","branches_url":"https://api.github.com/repos/cprice404/trapperkeeper-webserver-jetty9/branches{/branch}","tags_url":"https://api.github.com/repos/cprice404/trapperkeeper-webserver-jetty9/tags","blobs_url":"https://api.github.com/repos/cprice404/trapperkeeper-webserver-jetty9/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cprice404/trapperkeeper-webserver-jetty9/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cprice404/trapperkeeper-webserver-jetty9/git/refs{/sha}","trees_url":"https://api.github.com/repos/cprice404/trapperkeeper-webserver-jetty9/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cprice404/trapperkeeper-webserver-jetty9/statuses/{sha}","languages_url":"https://api.github.com/repos/cprice404/trapperkeeper-webserver-jetty9/languages","stargazers_url":"https://api.github.com/repos/cprice404/trapperkeeper-webserver-jetty9/stargazers","contributors_url":"https://api.github.com/repos/cprice404/trapperkeeper-webserver-jetty9/contributors","subscribers_url":"https://api.github.com/repos/cprice404/trapperkeeper-webserver-jetty9/subscribers","subscription_url":"https://api.github.com/repos/cprice404/trapperkeeper-webserver-jetty9/subscription","commits_url":"https://api.github.com/repos/cprice404/trapperkeeper-webserver-jetty9/commits{/sha}","git_commits_url":"https://api.github.com/repos/cprice404/trapperkeeper-webserver-jetty9/git/commits{/sha}","comments_url":"https://api.github.com/repos/cprice404/trapperkeeper-webserver-jetty9/comments{/number}","issue_comment_url":"https://api.github.com/repos/cprice404/trapperkeeper-webserver-jetty9/issues/comments{/number}","contents_url":"https://api.github.com/repos/cprice404/trapperkeeper-webserver-jetty9/contents/{+path}","compare_url":"https://api.github.com/repos/cprice404/trapperkeeper-webserver-jetty9/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cprice404/trapperkeeper-webserver-jetty9/merges","archive_url":"https://api.github.com/repos/cprice404/trapperkeeper-webserver-jetty9/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cprice404/trapperkeeper-webserver-jetty9/downloads","issues_url":"https://api.github.com/repos/cprice404/trapperkeeper-webserver-jetty9/issues{/number}","pulls_url":"https://api.github.com/repos/cprice404/trapperkeeper-webserver-jetty9/pulls{/number}","milestones_url":"https://api.github.com/repos/cprice404/trapperkeeper-webserver-jetty9/milestones{/number}","notifications_url":"https://api.github.com/repos/cprice404/trapperkeeper-webserver-jetty9/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cprice404/trapperkeeper-webserver-jetty9/labels{/name}","releases_url":"https://api.github.com/repos/cprice404/trapperkeeper-webserver-jetty9/releases{/id}","created_at":"2014-01-19T18:35:58Z","updated_at":"2014-06-22T22:56:55Z","pushed_at":"2015-03-14T14:59:35Z","git_url":"git://github.com/cprice404/trapperkeeper-webserver-jetty9.git","ssh_url":"git@github.com:cprice404/trapperkeeper-webserver-jetty9.git","clone_url":"https://github.com/cprice404/trapperkeeper-webserver-jetty9.git","svn_url":"https://github.com/cprice404/trapperkeeper-webserver-jetty9","homepage":null,"size":1405,"stargazers_count":0,"watchers_count":0,"language":"Clojure","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"66d7cc1925f8f31c624c76babf29e939fd440aa1","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":15646171,"name":"trapperkeeper-webserver-jetty9","full_name":"puppetlabs/trapperkeeper-webserver-jetty9","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/trapperkeeper-webserver-jetty9","description":"Trapperkeeper webservice service (jetty9 implementation).","fork":false,"url":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9","forks_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/forks","keys_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/teams","hooks_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/events","assignees_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/tags","blobs_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/subscription","commits_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/merges","archive_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/downloads","issues_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/releases{/id}","created_at":"2014-01-05T05:40:45Z","updated_at":"2015-03-06T19:20:22Z","pushed_at":"2015-03-06T19:20:23Z","git_url":"git://github.com/puppetlabs/trapperkeeper-webserver-jetty9.git","ssh_url":"git@github.com:puppetlabs/trapperkeeper-webserver-jetty9.git","clone_url":"https://github.com/puppetlabs/trapperkeeper-webserver-jetty9.git","svn_url":"https://github.com/puppetlabs/trapperkeeper-webserver-jetty9","homepage":"https://tickets.puppetlabs.com/browse/TK","size":2072,"stargazers_count":15,"watchers_count":15,"language":"Clojure","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"open_issues_count":1,"forks":23,"open_issues":1,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/pulls/112"},"html":{"href":"https://github.com/puppetlabs/trapperkeeper-webserver-jetty9/pull/112"},"issue":{"href":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/issues/112"},"comments":{"href":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/issues/112/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/pulls/112/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/pulls/112/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/trapperkeeper-webserver-jetty9/statuses/60e12ecf49c4f77299943d0d715530b33e7f067c"}}}}