{"action":"created","issue":{"url":"https://api.github.com/repos/letsencrypt/letsencrypt/issues/762","labels_url":"https://api.github.com/repos/letsencrypt/letsencrypt/issues/762/labels{/name}","comments_url":"https://api.github.com/repos/letsencrypt/letsencrypt/issues/762/comments","events_url":"https://api.github.com/repos/letsencrypt/letsencrypt/issues/762/events","html_url":"https://github.com/letsencrypt/letsencrypt/pull/762","id":105900770,"number":762,"title":"Multi cert chains (fixes #633).","user":{"login":"kuba","id":106176,"avatar_url":"https://avatars.githubusercontent.com/u/106176?v=3","gravatar_id":"","url":"https://api.github.com/users/kuba","html_url":"https://github.com/kuba","followers_url":"https://api.github.com/users/kuba/followers","following_url":"https://api.github.com/users/kuba/following{/other_user}","gists_url":"https://api.github.com/users/kuba/gists{/gist_id}","starred_url":"https://api.github.com/users/kuba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kuba/subscriptions","organizations_url":"https://api.github.com/users/kuba/orgs","repos_url":"https://api.github.com/users/kuba/repos","events_url":"https://api.github.com/users/kuba/events{/privacy}","received_events_url":"https://api.github.com/users/kuba/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-09-10T21:24:14Z","updated_at":"2015-09-11T22:23:46Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/letsencrypt/letsencrypt/pulls/762","html_url":"https://github.com/letsencrypt/letsencrypt/pull/762","diff_url":"https://github.com/letsencrypt/letsencrypt/pull/762.diff","patch_url":"https://github.com/letsencrypt/letsencrypt/pull/762.patch"},"body":"@schoen, could you have a look?"},"comment":{"url":"https://api.github.com/repos/letsencrypt/letsencrypt/issues/comments/139675622","html_url":"https://github.com/letsencrypt/letsencrypt/pull/762#issuecomment-139675622","issue_url":"https://api.github.com/repos/letsencrypt/letsencrypt/issues/762","id":139675622,"user":{"login":"schoen","id":1750103,"avatar_url":"https://avatars.githubusercontent.com/u/1750103?v=3","gravatar_id":"","url":"https://api.github.com/users/schoen","html_url":"https://github.com/schoen","followers_url":"https://api.github.com/users/schoen/followers","following_url":"https://api.github.com/users/schoen/following{/other_user}","gists_url":"https://api.github.com/users/schoen/gists{/gist_id}","starred_url":"https://api.github.com/users/schoen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schoen/subscriptions","organizations_url":"https://api.github.com/users/schoen/orgs","repos_url":"https://api.github.com/users/schoen/repos","events_url":"https://api.github.com/users/schoen/events{/privacy}","received_events_url":"https://api.github.com/users/schoen/received_events","type":"User","site_admin":false},"created_at":"2015-09-11T22:23:46Z","updated_at":"2015-09-11T22:23:46Z","body":"Hi @kuba, isn't there one more `save_successor` use that needs to be updated, in `cli.py`?  It still has the old-style\r\n\r\n```\r\n        lineage.save_successor(\r\n            lineage.latest_common_version(), OpenSSL.crypto.dump_certificate(\r\n                OpenSSL.crypto.FILETYPE_PEM, new_certr.body),\r\n            new_key.pem, OpenSSL.crypto.dump_certificate(\r\n                OpenSSL.crypto.FILETYPE_PEM, new_chain))\r\n```\r\n\r\nwhich doesn't seem to be modified by your PR, but probably needs to be in the same way that the others are. (This is at line 898 in my current tree but probably a slightly different line number in master.) This one would also need to use `crypto_util.dump_pyopenssl_chain` instead of `OpenSSL.crypto.dump_certificate`, right?"}}