{"action":"created","issue":{"url":"https://api.github.com/repos/Katello/katello/issues/5480","labels_url":"https://api.github.com/repos/Katello/katello/issues/5480/labels{/name}","comments_url":"https://api.github.com/repos/Katello/katello/issues/5480/comments","events_url":"https://api.github.com/repos/Katello/katello/issues/5480/events","html_url":"https://github.com/Katello/katello/pull/5480","id":106541772,"number":5480,"title":"fixes #11506 - import rhsm facts to hosts","user":{"login":"thomasmckay","id":338096,"avatar_url":"https://avatars.githubusercontent.com/u/338096?v=3","gravatar_id":"","url":"https://api.github.com/users/thomasmckay","html_url":"https://github.com/thomasmckay","followers_url":"https://api.github.com/users/thomasmckay/followers","following_url":"https://api.github.com/users/thomasmckay/following{/other_user}","gists_url":"https://api.github.com/users/thomasmckay/gists{/gist_id}","starred_url":"https://api.github.com/users/thomasmckay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomasmckay/subscriptions","organizations_url":"https://api.github.com/users/thomasmckay/orgs","repos_url":"https://api.github.com/users/thomasmckay/repos","events_url":"https://api.github.com/users/thomasmckay/events{/privacy}","received_events_url":"https://api.github.com/users/thomasmckay/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Katello/katello/labels/Needs%20testing","name":"Needs testing","color":"fbca04"},{"url":"https://api.github.com/repos/Katello/katello/labels/Not%20yet%20reviewed","name":"Not yet reviewed","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-09-15T12:06:55Z","updated_at":"2015-09-28T18:56:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Katello/katello/pulls/5480","html_url":"https://github.com/Katello/katello/pull/5480","diff_url":"https://github.com/Katello/katello/pull/5480.diff","patch_url":"https://github.com/Katello/katello/pull/5480.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/Katello/katello/issues/comments/143843438","html_url":"https://github.com/Katello/katello/pull/5480#issuecomment-143843438","issue_url":"https://api.github.com/repos/Katello/katello/issues/5480","id":143843438,"user":{"login":"stbenjam","id":429763,"avatar_url":"https://avatars.githubusercontent.com/u/429763?v=3","gravatar_id":"","url":"https://api.github.com/users/stbenjam","html_url":"https://github.com/stbenjam","followers_url":"https://api.github.com/users/stbenjam/followers","following_url":"https://api.github.com/users/stbenjam/following{/other_user}","gists_url":"https://api.github.com/users/stbenjam/gists{/gist_id}","starred_url":"https://api.github.com/users/stbenjam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stbenjam/subscriptions","organizations_url":"https://api.github.com/users/stbenjam/orgs","repos_url":"https://api.github.com/users/stbenjam/repos","events_url":"https://api.github.com/users/stbenjam/events{/privacy}","received_events_url":"https://api.github.com/users/stbenjam/received_events","type":"User","site_admin":false},"created_at":"2015-09-28T18:56:11Z","updated_at":"2015-09-28T18:56:11Z","body":"> @stbenjam I did look at the salt fact importer before I started but it seemed overly complex for the basics of sub-mgr facts. Yes, there is grouping represented in the keys (period separated) but storing it other than strings seems unnecessary.\r\n\r\n> Are there use cases with puppet or salt facts where the saving of structured data is critical to functionality of use cases?\r\n\r\nIMHO Katello should do things the way other plugins do, even if its too complicated.  You don't have to use the nested facts, but I think you should.\r\n\r\n`net.interface.docker0.ipv4_address` should represent a nested fact though in Foreman, and displayed as a hierarchy: net::interface::docker0::ipv4_address, which would let you query all the facts at the net::interface::docker0 level, for example.\r\n\r\nEven if you don't want to do that, the implementation code should go into a FactImporter class so at least that's the same."}}