{"action":"created","comment":{"url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/comments/29393733","id":29393733,"diff_hunk":"@@ -723,21 +725,33 @@ protected final boolean performAllBuildSteps(BuildListener listener, Iterable<?\n                     try {\n                         if (!perform(bs,listener)) {\n                             LOGGER.log(Level.FINE, \"{0} : {1} failed\", new Object[] {AbstractBuild.this, bs});\n+                            setResult(Result.FAILURE);\n                             r = false;\n                         }\n                     } catch (Exception e) {\n                         reportError(bs, e, listener, phase);\n+                        r = false;\n                     } catch (LinkageError e) {\n                         reportError(bs, e, listener, phase);\n+                        r = false;","path":"core/src/main/java/hudson/model/AbstractBuild.java","position":21,"original_position":21,"commit_id":"92734a8345b782ffd7e5f7c6f023b6228aa4c93d","original_commit_id":"92734a8345b782ffd7e5f7c6f023b6228aa4c93d","user":{"login":"KostyaSha","id":231611,"avatar_url":"https://avatars.githubusercontent.com/u/231611?v=3","gravatar_id":"","url":"https://api.github.com/users/KostyaSha","html_url":"https://github.com/KostyaSha","followers_url":"https://api.github.com/users/KostyaSha/followers","following_url":"https://api.github.com/users/KostyaSha/following{/other_user}","gists_url":"https://api.github.com/users/KostyaSha/gists{/gist_id}","starred_url":"https://api.github.com/users/KostyaSha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KostyaSha/subscriptions","organizations_url":"https://api.github.com/users/KostyaSha/orgs","repos_url":"https://api.github.com/users/KostyaSha/repos","events_url":"https://api.github.com/users/KostyaSha/events{/privacy}","received_events_url":"https://api.github.com/users/KostyaSha/received_events","type":"User","site_admin":false},"body":"`performAllBuildSteps` is ignored in most calls, but i think this should add consistency for failed execution","created_at":"2015-04-29T23:57:39Z","updated_at":"2015-04-29T23:57:39Z","html_url":"https://github.com/jenkinsci/jenkins/pull/1577#discussion_r29393733","pull_request_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/1577","_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/comments/29393733"},"html":{"href":"https://github.com/jenkinsci/jenkins/pull/1577#discussion_r29393733"},"pull_request":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/1577"}}},"pull_request":{"url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/1577","id":29706977,"html_url":"https://github.com/jenkinsci/jenkins/pull/1577","diff_url":"https://github.com/jenkinsci/jenkins/pull/1577.diff","patch_url":"https://github.com/jenkinsci/jenkins/pull/1577.patch","issue_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/1577","number":1577,"state":"open","locked":false,"title":"[FIXED JENKINS-26964] Handle AbortException right","user":{"login":"KostyaSha","id":231611,"avatar_url":"https://avatars.githubusercontent.com/u/231611?v=3","gravatar_id":"","url":"https://api.github.com/users/KostyaSha","html_url":"https://github.com/KostyaSha","followers_url":"https://api.github.com/users/KostyaSha/followers","following_url":"https://api.github.com/users/KostyaSha/following{/other_user}","gists_url":"https://api.github.com/users/KostyaSha/gists{/gist_id}","starred_url":"https://api.github.com/users/KostyaSha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KostyaSha/subscriptions","organizations_url":"https://api.github.com/users/KostyaSha/orgs","repos_url":"https://api.github.com/users/KostyaSha/repos","events_url":"https://api.github.com/users/KostyaSha/events{/privacy}","received_events_url":"https://api.github.com/users/KostyaSha/received_events","type":"User","site_admin":false},"body":"[JENKINS-26964](https://issues.jenkins-ci.org/browse/JENKINS-26964)","created_at":"2015-02-20T16:01:47Z","updated_at":"2015-04-29T23:57:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d1ad4b7433d959671a8ce130196ae3310f9f7f72","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/1577/commits","review_comments_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/1577/comments","review_comment_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/1577/comments","statuses_url":"https://api.github.com/repos/jenkinsci/jenkins/statuses/92734a8345b782ffd7e5f7c6f023b6228aa4c93d","head":{"label":"KostyaSha:JENKINS-26964","ref":"JENKINS-26964","sha":"92734a8345b782ffd7e5f7c6f023b6228aa4c93d","user":{"login":"KostyaSha","id":231611,"avatar_url":"https://avatars.githubusercontent.com/u/231611?v=3","gravatar_id":"","url":"https://api.github.com/users/KostyaSha","html_url":"https://github.com/KostyaSha","followers_url":"https://api.github.com/users/KostyaSha/followers","following_url":"https://api.github.com/users/KostyaSha/following{/other_user}","gists_url":"https://api.github.com/users/KostyaSha/gists{/gist_id}","starred_url":"https://api.github.com/users/KostyaSha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KostyaSha/subscriptions","organizations_url":"https://api.github.com/users/KostyaSha/orgs","repos_url":"https://api.github.com/users/KostyaSha/repos","events_url":"https://api.github.com/users/KostyaSha/events{/privacy}","received_events_url":"https://api.github.com/users/KostyaSha/received_events","type":"User","site_admin":false},"repo":{"id":5225392,"name":"jenkins","full_name":"KostyaSha/jenkins","owner":{"login":"KostyaSha","id":231611,"avatar_url":"https://avatars.githubusercontent.com/u/231611?v=3","gravatar_id":"","url":"https://api.github.com/users/KostyaSha","html_url":"https://github.com/KostyaSha","followers_url":"https://api.github.com/users/KostyaSha/followers","following_url":"https://api.github.com/users/KostyaSha/following{/other_user}","gists_url":"https://api.github.com/users/KostyaSha/gists{/gist_id}","starred_url":"https://api.github.com/users/KostyaSha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KostyaSha/subscriptions","organizations_url":"https://api.github.com/users/KostyaSha/orgs","repos_url":"https://api.github.com/users/KostyaSha/repos","events_url":"https://api.github.com/users/KostyaSha/events{/privacy}","received_events_url":"https://api.github.com/users/KostyaSha/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/KostyaSha/jenkins","description":"Jenkins Continuous Integration Server","fork":true,"url":"https://api.github.com/repos/KostyaSha/jenkins","forks_url":"https://api.github.com/repos/KostyaSha/jenkins/forks","keys_url":"https://api.github.com/repos/KostyaSha/jenkins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KostyaSha/jenkins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KostyaSha/jenkins/teams","hooks_url":"https://api.github.com/repos/KostyaSha/jenkins/hooks","issue_events_url":"https://api.github.com/repos/KostyaSha/jenkins/issues/events{/number}","events_url":"https://api.github.com/repos/KostyaSha/jenkins/events","assignees_url":"https://api.github.com/repos/KostyaSha/jenkins/assignees{/user}","branches_url":"https://api.github.com/repos/KostyaSha/jenkins/branches{/branch}","tags_url":"https://api.github.com/repos/KostyaSha/jenkins/tags","blobs_url":"https://api.github.com/repos/KostyaSha/jenkins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KostyaSha/jenkins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KostyaSha/jenkins/git/refs{/sha}","trees_url":"https://api.github.com/repos/KostyaSha/jenkins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KostyaSha/jenkins/statuses/{sha}","languages_url":"https://api.github.com/repos/KostyaSha/jenkins/languages","stargazers_url":"https://api.github.com/repos/KostyaSha/jenkins/stargazers","contributors_url":"https://api.github.com/repos/KostyaSha/jenkins/contributors","subscribers_url":"https://api.github.com/repos/KostyaSha/jenkins/subscribers","subscription_url":"https://api.github.com/repos/KostyaSha/jenkins/subscription","commits_url":"https://api.github.com/repos/KostyaSha/jenkins/commits{/sha}","git_commits_url":"https://api.github.com/repos/KostyaSha/jenkins/git/commits{/sha}","comments_url":"https://api.github.com/repos/KostyaSha/jenkins/comments{/number}","issue_comment_url":"https://api.github.com/repos/KostyaSha/jenkins/issues/comments{/number}","contents_url":"https://api.github.com/repos/KostyaSha/jenkins/contents/{+path}","compare_url":"https://api.github.com/repos/KostyaSha/jenkins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KostyaSha/jenkins/merges","archive_url":"https://api.github.com/repos/KostyaSha/jenkins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KostyaSha/jenkins/downloads","issues_url":"https://api.github.com/repos/KostyaSha/jenkins/issues{/number}","pulls_url":"https://api.github.com/repos/KostyaSha/jenkins/pulls{/number}","milestones_url":"https://api.github.com/repos/KostyaSha/jenkins/milestones{/number}","notifications_url":"https://api.github.com/repos/KostyaSha/jenkins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KostyaSha/jenkins/labels{/name}","releases_url":"https://api.github.com/repos/KostyaSha/jenkins/releases{/id}","created_at":"2012-07-29T20:32:26Z","updated_at":"2015-04-23T21:06:17Z","pushed_at":"2015-04-29T23:54:09Z","git_url":"git://github.com/KostyaSha/jenkins.git","ssh_url":"git@github.com:KostyaSha/jenkins.git","clone_url":"https://github.com/KostyaSha/jenkins.git","svn_url":"https://github.com/KostyaSha/jenkins","homepage":"http://jenkins-ci.org/","size":86572,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jenkinsci:master","ref":"master","sha":"0a6e00cb576cf8beb5c971c682029fb1e761b487","user":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"repo":{"id":1103607,"name":"jenkins","full_name":"jenkinsci/jenkins","owner":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jenkinsci/jenkins","description":"Jenkins Continuous Integration Server","fork":true,"url":"https://api.github.com/repos/jenkinsci/jenkins","forks_url":"https://api.github.com/repos/jenkinsci/jenkins/forks","keys_url":"https://api.github.com/repos/jenkinsci/jenkins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenkinsci/jenkins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenkinsci/jenkins/teams","hooks_url":"https://api.github.com/repos/jenkinsci/jenkins/hooks","issue_events_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/events{/number}","events_url":"https://api.github.com/repos/jenkinsci/jenkins/events","assignees_url":"https://api.github.com/repos/jenkinsci/jenkins/assignees{/user}","branches_url":"https://api.github.com/repos/jenkinsci/jenkins/branches{/branch}","tags_url":"https://api.github.com/repos/jenkinsci/jenkins/tags","blobs_url":"https://api.github.com/repos/jenkinsci/jenkins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenkinsci/jenkins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenkinsci/jenkins/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenkinsci/jenkins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenkinsci/jenkins/statuses/{sha}","languages_url":"https://api.github.com/repos/jenkinsci/jenkins/languages","stargazers_url":"https://api.github.com/repos/jenkinsci/jenkins/stargazers","contributors_url":"https://api.github.com/repos/jenkinsci/jenkins/contributors","subscribers_url":"https://api.github.com/repos/jenkinsci/jenkins/subscribers","subscription_url":"https://api.github.com/repos/jenkinsci/jenkins/subscription","commits_url":"https://api.github.com/repos/jenkinsci/jenkins/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenkinsci/jenkins/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenkinsci/jenkins/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/comments{/number}","contents_url":"https://api.github.com/repos/jenkinsci/jenkins/contents/{+path}","compare_url":"https://api.github.com/repos/jenkinsci/jenkins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenkinsci/jenkins/merges","archive_url":"https://api.github.com/repos/jenkinsci/jenkins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenkinsci/jenkins/downloads","issues_url":"https://api.github.com/repos/jenkinsci/jenkins/issues{/number}","pulls_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls{/number}","milestones_url":"https://api.github.com/repos/jenkinsci/jenkins/milestones{/number}","notifications_url":"https://api.github.com/repos/jenkinsci/jenkins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenkinsci/jenkins/labels{/name}","releases_url":"https://api.github.com/repos/jenkinsci/jenkins/releases{/id}","created_at":"2010-11-22T21:21:23Z","updated_at":"2015-04-29T23:12:37Z","pushed_at":"2015-04-29T23:54:12Z","git_url":"git://github.com/jenkinsci/jenkins.git","ssh_url":"git@github.com:jenkinsci/jenkins.git","clone_url":"https://github.com/jenkinsci/jenkins.git","svn_url":"https://github.com/jenkinsci/jenkins","homepage":"http://jenkins-ci.org/","size":419730,"stargazers_count":4011,"watchers_count":4011,"language":"Java","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1795,"mirror_url":null,"open_issues_count":105,"forks":1795,"open_issues":105,"watchers":4011,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/1577"},"html":{"href":"https://github.com/jenkinsci/jenkins/pull/1577"},"issue":{"href":"https://api.github.com/repos/jenkinsci/jenkins/issues/1577"},"comments":{"href":"https://api.github.com/repos/jenkinsci/jenkins/issues/1577/comments"},"review_comments":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/1577/comments"},"review_comment":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/1577/commits"},"statuses":{"href":"https://api.github.com/repos/jenkinsci/jenkins/statuses/92734a8345b782ffd7e5f7c6f023b6228aa4c93d"}}}}