{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/comments/47675911","id":47675911,"diff_hunk":"@@ -187,33 +187,38 @@ class FloatDecoder(TypeVerifier):\n     min: None or float. If provided, it specifies the minimum accepted value.\n   \"\"\"\n \n-  def __init__(self, component, option, max=None, min=None, **kwargs):\n-    super(FloatDecoder, self).__init__(component, option, (float,), **kwargs)\n+  def __init__(self, option, max=None, min=None, **kwargs):\n+    super(FloatDecoder, self).__init__(option, (float,), **kwargs)","path":"perfkitbenchmarker/configs/option_decoders.py","position":7,"original_position":7,"commit_id":"9eace893d8d69ff05a2df7e3994a091b8918e36c","original_commit_id":"9eace893d8d69ff05a2df7e3994a091b8918e36c","user":{"login":"skschneider","id":11166925,"avatar_url":"https://avatars.githubusercontent.com/u/11166925?v=3","gravatar_id":"","url":"https://api.github.com/users/skschneider","html_url":"https://github.com/skschneider","followers_url":"https://api.github.com/users/skschneider/followers","following_url":"https://api.github.com/users/skschneider/following{/other_user}","gists_url":"https://api.github.com/users/skschneider/gists{/gist_id}","starred_url":"https://api.github.com/users/skschneider/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skschneider/subscriptions","organizations_url":"https://api.github.com/users/skschneider/orgs","repos_url":"https://api.github.com/users/skschneider/repos","events_url":"https://api.github.com/users/skschneider/events{/privacy}","received_events_url":"https://api.github.com/users/skschneider/received_events","type":"User","site_admin":false},"body":"Sorry, I wasn't aware when this class was introduced, so it was my changes that broke it.\r\nI have a concern about the use of (float,) here. Because of the way yaml.load works, an input like 'docker_cpus: 2' will become an int that I don't think would be accepted by this FloatDecoder. It's probably best to accept int as well. Consider adding a test case to tests/configs/option_decoders_test.py","created_at":"2015-12-15T18:23:37Z","updated_at":"2015-12-15T18:23:37Z","html_url":"https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/731#discussion_r47675911","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/731","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/comments/47675911"},"html":{"href":"https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/731#discussion_r47675911"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/731"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/731","id":53673282,"html_url":"https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/731","diff_url":"https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/731.diff","patch_url":"https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/731.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/issues/731","number":731,"state":"open","locked":false,"title":"Fix for the FloatDecoder used in Mesos provider.","user":{"login":"mateusz-blaszkowski","id":1431695,"avatar_url":"https://avatars.githubusercontent.com/u/1431695?v=3","gravatar_id":"","url":"https://api.github.com/users/mateusz-blaszkowski","html_url":"https://github.com/mateusz-blaszkowski","followers_url":"https://api.github.com/users/mateusz-blaszkowski/followers","following_url":"https://api.github.com/users/mateusz-blaszkowski/following{/other_user}","gists_url":"https://api.github.com/users/mateusz-blaszkowski/gists{/gist_id}","starred_url":"https://api.github.com/users/mateusz-blaszkowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mateusz-blaszkowski/subscriptions","organizations_url":"https://api.github.com/users/mateusz-blaszkowski/orgs","repos_url":"https://api.github.com/users/mateusz-blaszkowski/repos","events_url":"https://api.github.com/users/mateusz-blaszkowski/events{/privacy}","received_events_url":"https://api.github.com/users/mateusz-blaszkowski/received_events","type":"User","site_admin":false},"body":"I must have done the merge improperly.\r\n\r\nSigned-off-by: Mateusz Blaszkowski <mateusz.blaszkowski@intel.com>","created_at":"2015-12-15T08:30:54Z","updated_at":"2015-12-15T18:23:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3e45c8e043153d52464e9116f6619e59e643a033","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/731/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/731/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/issues/731/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/statuses/9eace893d8d69ff05a2df7e3994a091b8918e36c","head":{"label":"mateusz-blaszkowski:float_decoder_fix","ref":"float_decoder_fix","sha":"9eace893d8d69ff05a2df7e3994a091b8918e36c","user":{"login":"mateusz-blaszkowski","id":1431695,"avatar_url":"https://avatars.githubusercontent.com/u/1431695?v=3","gravatar_id":"","url":"https://api.github.com/users/mateusz-blaszkowski","html_url":"https://github.com/mateusz-blaszkowski","followers_url":"https://api.github.com/users/mateusz-blaszkowski/followers","following_url":"https://api.github.com/users/mateusz-blaszkowski/following{/other_user}","gists_url":"https://api.github.com/users/mateusz-blaszkowski/gists{/gist_id}","starred_url":"https://api.github.com/users/mateusz-blaszkowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mateusz-blaszkowski/subscriptions","organizations_url":"https://api.github.com/users/mateusz-blaszkowski/orgs","repos_url":"https://api.github.com/users/mateusz-blaszkowski/repos","events_url":"https://api.github.com/users/mateusz-blaszkowski/events{/privacy}","received_events_url":"https://api.github.com/users/mateusz-blaszkowski/received_events","type":"User","site_admin":false},"repo":{"id":38477926,"name":"PerfKitBenchmarker","full_name":"mateusz-blaszkowski/PerfKitBenchmarker","owner":{"login":"mateusz-blaszkowski","id":1431695,"avatar_url":"https://avatars.githubusercontent.com/u/1431695?v=3","gravatar_id":"","url":"https://api.github.com/users/mateusz-blaszkowski","html_url":"https://github.com/mateusz-blaszkowski","followers_url":"https://api.github.com/users/mateusz-blaszkowski/followers","following_url":"https://api.github.com/users/mateusz-blaszkowski/following{/other_user}","gists_url":"https://api.github.com/users/mateusz-blaszkowski/gists{/gist_id}","starred_url":"https://api.github.com/users/mateusz-blaszkowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mateusz-blaszkowski/subscriptions","organizations_url":"https://api.github.com/users/mateusz-blaszkowski/orgs","repos_url":"https://api.github.com/users/mateusz-blaszkowski/repos","events_url":"https://api.github.com/users/mateusz-blaszkowski/events{/privacy}","received_events_url":"https://api.github.com/users/mateusz-blaszkowski/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mateusz-blaszkowski/PerfKitBenchmarker","description":"Perfkit Benchmarker contains set of benchmarks to measure and compare cloud offerings. The benchmarks are not tuned (i.e. use defaults) to reflect what most users will see. PerfKit Benchmarker is licensed under the Apache 2 license terms. Please make sure to read, understand and agree to the terms of the LICENSE and CONTRIBUTING files before proceeding.","fork":true,"url":"https://api.github.com/repos/mateusz-blaszkowski/PerfKitBenchmarker","forks_url":"https://api.github.com/repos/mateusz-blaszkowski/PerfKitBenchmarker/forks","keys_url":"https://api.github.com/repos/mateusz-blaszkowski/PerfKitBenchmarker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mateusz-blaszkowski/PerfKitBenchmarker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mateusz-blaszkowski/PerfKitBenchmarker/teams","hooks_url":"https://api.github.com/repos/mateusz-blaszkowski/PerfKitBenchmarker/hooks","issue_events_url":"https://api.github.com/repos/mateusz-blaszkowski/PerfKitBenchmarker/issues/events{/number}","events_url":"https://api.github.com/repos/mateusz-blaszkowski/PerfKitBenchmarker/events","assignees_url":"https://api.github.com/repos/mateusz-blaszkowski/PerfKitBenchmarker/assignees{/user}","branches_url":"https://api.github.com/repos/mateusz-blaszkowski/PerfKitBenchmarker/branches{/branch}","tags_url":"https://api.github.com/repos/mateusz-blaszkowski/PerfKitBenchmarker/tags","blobs_url":"https://api.github.com/repos/mateusz-blaszkowski/PerfKitBenchmarker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mateusz-blaszkowski/PerfKitBenchmarker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mateusz-blaszkowski/PerfKitBenchmarker/git/refs{/sha}","trees_url":"https://api.github.com/repos/mateusz-blaszkowski/PerfKitBenchmarker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mateusz-blaszkowski/PerfKitBenchmarker/statuses/{sha}","languages_url":"https://api.github.com/repos/mateusz-blaszkowski/PerfKitBenchmarker/languages","stargazers_url":"https://api.github.com/repos/mateusz-blaszkowski/PerfKitBenchmarker/stargazers","contributors_url":"https://api.github.com/repos/mateusz-blaszkowski/PerfKitBenchmarker/contributors","subscribers_url":"https://api.github.com/repos/mateusz-blaszkowski/PerfKitBenchmarker/subscribers","subscription_url":"https://api.github.com/repos/mateusz-blaszkowski/PerfKitBenchmarker/subscription","commits_url":"https://api.github.com/repos/mateusz-blaszkowski/PerfKitBenchmarker/commits{/sha}","git_commits_url":"https://api.github.com/repos/mateusz-blaszkowski/PerfKitBenchmarker/git/commits{/sha}","comments_url":"https://api.github.com/repos/mateusz-blaszkowski/PerfKitBenchmarker/comments{/number}","issue_comment_url":"https://api.github.com/repos/mateusz-blaszkowski/PerfKitBenchmarker/issues/comments{/number}","contents_url":"https://api.github.com/repos/mateusz-blaszkowski/PerfKitBenchmarker/contents/{+path}","compare_url":"https://api.github.com/repos/mateusz-blaszkowski/PerfKitBenchmarker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mateusz-blaszkowski/PerfKitBenchmarker/merges","archive_url":"https://api.github.com/repos/mateusz-blaszkowski/PerfKitBenchmarker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mateusz-blaszkowski/PerfKitBenchmarker/downloads","issues_url":"https://api.github.com/repos/mateusz-blaszkowski/PerfKitBenchmarker/issues{/number}","pulls_url":"https://api.github.com/repos/mateusz-blaszkowski/PerfKitBenchmarker/pulls{/number}","milestones_url":"https://api.github.com/repos/mateusz-blaszkowski/PerfKitBenchmarker/milestones{/number}","notifications_url":"https://api.github.com/repos/mateusz-blaszkowski/PerfKitBenchmarker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mateusz-blaszkowski/PerfKitBenchmarker/labels{/name}","releases_url":"https://api.github.com/repos/mateusz-blaszkowski/PerfKitBenchmarker/releases{/id}","created_at":"2015-07-03T07:02:56Z","updated_at":"2015-07-03T07:02:57Z","pushed_at":"2015-12-15T08:29:32Z","git_url":"git://github.com/mateusz-blaszkowski/PerfKitBenchmarker.git","ssh_url":"git@github.com:mateusz-blaszkowski/PerfKitBenchmarker.git","clone_url":"https://github.com/mateusz-blaszkowski/PerfKitBenchmarker.git","svn_url":"https://github.com/mateusz-blaszkowski/PerfKitBenchmarker","homepage":"","size":3870,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"a93147cd547fc64f56ba6302fdf7761463757a1a","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":21950910,"name":"PerfKitBenchmarker","full_name":"GoogleCloudPlatform/PerfKitBenchmarker","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/PerfKitBenchmarker","description":"Perfkit Benchmarker contains set of benchmarks to measure and compare cloud offerings. The benchmarks are not tuned (i.e. use defaults) to reflect what most users will see. PerfKit Benchmarker is licensed under the Apache 2 license terms. Please make sure to read, understand and agree to the terms of the LICENSE and CONTRIBUTING files before proceeding.","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/releases{/id}","created_at":"2014-07-17T17:23:26Z","updated_at":"2015-12-15T13:17:18Z","pushed_at":"2015-12-15T18:12:44Z","git_url":"git://github.com/GoogleCloudPlatform/PerfKitBenchmarker.git","ssh_url":"git@github.com:GoogleCloudPlatform/PerfKitBenchmarker.git","clone_url":"https://github.com/GoogleCloudPlatform/PerfKitBenchmarker.git","svn_url":"https://github.com/GoogleCloudPlatform/PerfKitBenchmarker","homepage":"","size":84540,"stargazers_count":531,"watchers_count":531,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":102,"mirror_url":null,"open_issues_count":99,"forks":102,"open_issues":99,"watchers":531,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/731"},"html":{"href":"https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/731"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/issues/731"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/issues/731/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/731/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/731/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/statuses/9eace893d8d69ff05a2df7e3994a091b8918e36c"}}}}