{"action":"opened","number":1557,"pull_request":{"url":"https://api.github.com/repos/Modernizr/Modernizr/pulls/1557","id":31233646,"html_url":"https://github.com/Modernizr/Modernizr/pull/1557","diff_url":"https://github.com/Modernizr/Modernizr/pull/1557.diff","patch_url":"https://github.com/Modernizr/Modernizr/pull/1557.patch","issue_url":"https://api.github.com/repos/Modernizr/Modernizr/issues/1557","number":1557,"state":"open","locked":false,"title":"Flash: Attach fake body only when actually needed","user":{"login":"niksy","id":389286,"avatar_url":"https://avatars.githubusercontent.com/u/389286?v=3","gravatar_id":"","url":"https://api.github.com/users/niksy","html_url":"https://github.com/niksy","followers_url":"https://api.github.com/users/niksy/followers","following_url":"https://api.github.com/users/niksy/following{/other_user}","gists_url":"https://api.github.com/users/niksy/gists{/gist_id}","starred_url":"https://api.github.com/users/niksy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/niksy/subscriptions","organizations_url":"https://api.github.com/users/niksy/orgs","repos_url":"https://api.github.com/users/niksy/repos","events_url":"https://api.github.com/users/niksy/events{/privacy}","received_events_url":"https://api.github.com/users/niksy/received_events","type":"User","site_admin":false},"body":"I was getting the infamous IE8 error `HTML Parsing Error: Unable to modify the parent container element before the child element is closed (KB927917)` when trying to use and attach fake `body` to `html`. Little testing and trying and I came to the solution that attached `body` only when it’s actually needed for checking, and that’s in two places, but with additional check to se if it’s available inside `docElement`.\r\n\r\nIs this making any sense? :)","created_at":"2015-03-16T11:04:31Z","updated_at":"2015-03-16T11:04:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Modernizr/Modernizr/pulls/1557/commits","review_comments_url":"https://api.github.com/repos/Modernizr/Modernizr/pulls/1557/comments","review_comment_url":"https://api.github.com/repos/Modernizr/Modernizr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Modernizr/Modernizr/issues/1557/comments","statuses_url":"https://api.github.com/repos/Modernizr/Modernizr/statuses/a8ef19f9b9c4b875788aa11d23e2342c83eadbd9","head":{"label":"niksy:flash-attach-fake-body","ref":"flash-attach-fake-body","sha":"a8ef19f9b9c4b875788aa11d23e2342c83eadbd9","user":{"login":"niksy","id":389286,"avatar_url":"https://avatars.githubusercontent.com/u/389286?v=3","gravatar_id":"","url":"https://api.github.com/users/niksy","html_url":"https://github.com/niksy","followers_url":"https://api.github.com/users/niksy/followers","following_url":"https://api.github.com/users/niksy/following{/other_user}","gists_url":"https://api.github.com/users/niksy/gists{/gist_id}","starred_url":"https://api.github.com/users/niksy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/niksy/subscriptions","organizations_url":"https://api.github.com/users/niksy/orgs","repos_url":"https://api.github.com/users/niksy/repos","events_url":"https://api.github.com/users/niksy/events{/privacy}","received_events_url":"https://api.github.com/users/niksy/received_events","type":"User","site_admin":false},"repo":{"id":30066825,"name":"Modernizr","full_name":"niksy/Modernizr","owner":{"login":"niksy","id":389286,"avatar_url":"https://avatars.githubusercontent.com/u/389286?v=3","gravatar_id":"","url":"https://api.github.com/users/niksy","html_url":"https://github.com/niksy","followers_url":"https://api.github.com/users/niksy/followers","following_url":"https://api.github.com/users/niksy/following{/other_user}","gists_url":"https://api.github.com/users/niksy/gists{/gist_id}","starred_url":"https://api.github.com/users/niksy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/niksy/subscriptions","organizations_url":"https://api.github.com/users/niksy/orgs","repos_url":"https://api.github.com/users/niksy/repos","events_url":"https://api.github.com/users/niksy/events{/privacy}","received_events_url":"https://api.github.com/users/niksy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/niksy/Modernizr","description":"Modernizr is a JavaScript library that detects HTML5 and CSS3 features in the user’s browser.","fork":true,"url":"https://api.github.com/repos/niksy/Modernizr","forks_url":"https://api.github.com/repos/niksy/Modernizr/forks","keys_url":"https://api.github.com/repos/niksy/Modernizr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/niksy/Modernizr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/niksy/Modernizr/teams","hooks_url":"https://api.github.com/repos/niksy/Modernizr/hooks","issue_events_url":"https://api.github.com/repos/niksy/Modernizr/issues/events{/number}","events_url":"https://api.github.com/repos/niksy/Modernizr/events","assignees_url":"https://api.github.com/repos/niksy/Modernizr/assignees{/user}","branches_url":"https://api.github.com/repos/niksy/Modernizr/branches{/branch}","tags_url":"https://api.github.com/repos/niksy/Modernizr/tags","blobs_url":"https://api.github.com/repos/niksy/Modernizr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/niksy/Modernizr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/niksy/Modernizr/git/refs{/sha}","trees_url":"https://api.github.com/repos/niksy/Modernizr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/niksy/Modernizr/statuses/{sha}","languages_url":"https://api.github.com/repos/niksy/Modernizr/languages","stargazers_url":"https://api.github.com/repos/niksy/Modernizr/stargazers","contributors_url":"https://api.github.com/repos/niksy/Modernizr/contributors","subscribers_url":"https://api.github.com/repos/niksy/Modernizr/subscribers","subscription_url":"https://api.github.com/repos/niksy/Modernizr/subscription","commits_url":"https://api.github.com/repos/niksy/Modernizr/commits{/sha}","git_commits_url":"https://api.github.com/repos/niksy/Modernizr/git/commits{/sha}","comments_url":"https://api.github.com/repos/niksy/Modernizr/comments{/number}","issue_comment_url":"https://api.github.com/repos/niksy/Modernizr/issues/comments{/number}","contents_url":"https://api.github.com/repos/niksy/Modernizr/contents/{+path}","compare_url":"https://api.github.com/repos/niksy/Modernizr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/niksy/Modernizr/merges","archive_url":"https://api.github.com/repos/niksy/Modernizr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/niksy/Modernizr/downloads","issues_url":"https://api.github.com/repos/niksy/Modernizr/issues{/number}","pulls_url":"https://api.github.com/repos/niksy/Modernizr/pulls{/number}","milestones_url":"https://api.github.com/repos/niksy/Modernizr/milestones{/number}","notifications_url":"https://api.github.com/repos/niksy/Modernizr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/niksy/Modernizr/labels{/name}","releases_url":"https://api.github.com/repos/niksy/Modernizr/releases{/id}","created_at":"2015-01-30T10:12:36Z","updated_at":"2015-01-30T10:12:38Z","pushed_at":"2015-03-16T11:00:39Z","git_url":"git://github.com/niksy/Modernizr.git","ssh_url":"git@github.com:niksy/Modernizr.git","clone_url":"https://github.com/niksy/Modernizr.git","svn_url":"https://github.com/niksy/Modernizr","homepage":"http://modernizr.com","size":13439,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Modernizr:master","ref":"master","sha":"c653d628d1a6a63a97ab560089a2e0f718db69ea","user":{"login":"Modernizr","id":131060,"avatar_url":"https://avatars.githubusercontent.com/u/131060?v=3","gravatar_id":"","url":"https://api.github.com/users/Modernizr","html_url":"https://github.com/Modernizr","followers_url":"https://api.github.com/users/Modernizr/followers","following_url":"https://api.github.com/users/Modernizr/following{/other_user}","gists_url":"https://api.github.com/users/Modernizr/gists{/gist_id}","starred_url":"https://api.github.com/users/Modernizr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Modernizr/subscriptions","organizations_url":"https://api.github.com/users/Modernizr/orgs","repos_url":"https://api.github.com/users/Modernizr/repos","events_url":"https://api.github.com/users/Modernizr/events{/privacy}","received_events_url":"https://api.github.com/users/Modernizr/received_events","type":"Organization","site_admin":false},"repo":{"id":317757,"name":"Modernizr","full_name":"Modernizr/Modernizr","owner":{"login":"Modernizr","id":131060,"avatar_url":"https://avatars.githubusercontent.com/u/131060?v=3","gravatar_id":"","url":"https://api.github.com/users/Modernizr","html_url":"https://github.com/Modernizr","followers_url":"https://api.github.com/users/Modernizr/followers","following_url":"https://api.github.com/users/Modernizr/following{/other_user}","gists_url":"https://api.github.com/users/Modernizr/gists{/gist_id}","starred_url":"https://api.github.com/users/Modernizr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Modernizr/subscriptions","organizations_url":"https://api.github.com/users/Modernizr/orgs","repos_url":"https://api.github.com/users/Modernizr/repos","events_url":"https://api.github.com/users/Modernizr/events{/privacy}","received_events_url":"https://api.github.com/users/Modernizr/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Modernizr/Modernizr","description":"Modernizr is a JavaScript library that detects HTML5 and CSS3 features in the user’s browser.","fork":false,"url":"https://api.github.com/repos/Modernizr/Modernizr","forks_url":"https://api.github.com/repos/Modernizr/Modernizr/forks","keys_url":"https://api.github.com/repos/Modernizr/Modernizr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Modernizr/Modernizr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Modernizr/Modernizr/teams","hooks_url":"https://api.github.com/repos/Modernizr/Modernizr/hooks","issue_events_url":"https://api.github.com/repos/Modernizr/Modernizr/issues/events{/number}","events_url":"https://api.github.com/repos/Modernizr/Modernizr/events","assignees_url":"https://api.github.com/repos/Modernizr/Modernizr/assignees{/user}","branches_url":"https://api.github.com/repos/Modernizr/Modernizr/branches{/branch}","tags_url":"https://api.github.com/repos/Modernizr/Modernizr/tags","blobs_url":"https://api.github.com/repos/Modernizr/Modernizr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Modernizr/Modernizr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Modernizr/Modernizr/git/refs{/sha}","trees_url":"https://api.github.com/repos/Modernizr/Modernizr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Modernizr/Modernizr/statuses/{sha}","languages_url":"https://api.github.com/repos/Modernizr/Modernizr/languages","stargazers_url":"https://api.github.com/repos/Modernizr/Modernizr/stargazers","contributors_url":"https://api.github.com/repos/Modernizr/Modernizr/contributors","subscribers_url":"https://api.github.com/repos/Modernizr/Modernizr/subscribers","subscription_url":"https://api.github.com/repos/Modernizr/Modernizr/subscription","commits_url":"https://api.github.com/repos/Modernizr/Modernizr/commits{/sha}","git_commits_url":"https://api.github.com/repos/Modernizr/Modernizr/git/commits{/sha}","comments_url":"https://api.github.com/repos/Modernizr/Modernizr/comments{/number}","issue_comment_url":"https://api.github.com/repos/Modernizr/Modernizr/issues/comments{/number}","contents_url":"https://api.github.com/repos/Modernizr/Modernizr/contents/{+path}","compare_url":"https://api.github.com/repos/Modernizr/Modernizr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Modernizr/Modernizr/merges","archive_url":"https://api.github.com/repos/Modernizr/Modernizr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Modernizr/Modernizr/downloads","issues_url":"https://api.github.com/repos/Modernizr/Modernizr/issues{/number}","pulls_url":"https://api.github.com/repos/Modernizr/Modernizr/pulls{/number}","milestones_url":"https://api.github.com/repos/Modernizr/Modernizr/milestones{/number}","notifications_url":"https://api.github.com/repos/Modernizr/Modernizr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Modernizr/Modernizr/labels{/name}","releases_url":"https://api.github.com/repos/Modernizr/Modernizr/releases{/id}","created_at":"2009-09-25T20:13:23Z","updated_at":"2015-03-16T10:01:05Z","pushed_at":"2015-03-13T17:04:28Z","git_url":"git://github.com/Modernizr/Modernizr.git","ssh_url":"git@github.com:Modernizr/Modernizr.git","clone_url":"https://github.com/Modernizr/Modernizr.git","svn_url":"https://github.com/Modernizr/Modernizr","homepage":"http://modernizr.com","size":26185,"stargazers_count":14659,"watchers_count":14659,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1936,"mirror_url":null,"open_issues_count":110,"forks":1936,"open_issues":110,"watchers":14659,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Modernizr/Modernizr/pulls/1557"},"html":{"href":"https://github.com/Modernizr/Modernizr/pull/1557"},"issue":{"href":"https://api.github.com/repos/Modernizr/Modernizr/issues/1557"},"comments":{"href":"https://api.github.com/repos/Modernizr/Modernizr/issues/1557/comments"},"review_comments":{"href":"https://api.github.com/repos/Modernizr/Modernizr/pulls/1557/comments"},"review_comment":{"href":"https://api.github.com/repos/Modernizr/Modernizr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Modernizr/Modernizr/pulls/1557/commits"},"statuses":{"href":"https://api.github.com/repos/Modernizr/Modernizr/statuses/a8ef19f9b9c4b875788aa11d23e2342c83eadbd9"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":7,"deletions":1,"changed_files":1}}