{"action":"created","comment":{"url":"https://api.github.com/repos/Mudlet/Mudlet/pulls/comments/46328568","id":46328568,"diff_hunk":"@@ -363,6 +363,18 @@ ADD_SUBDIRECTORY(irc)\n \n ADD_DEFINITIONS(-DAPP_VERSION=\"${APP_VERSION}\" -DAPP_BUILD=\"${APP_BUILD}\" -DAPP_TARGET=\"${APP_TARGET}\")\n \n+IF(UNIX)\n+    SET(DATAROOTDIR \"${CMAKE_INSTALL_PREFIX}/share\" CACHE STRING \"The platform-specific directory in which read-only data is generally installed\")\n+    SET(DATADIR \"${DATAROOTDIR}/mudlet\" CACHE STRING \"Directory in which mudlet installs it's read-only data\")","path":"src/CMakeLists.txt","position":null,"original_position":6,"commit_id":"bfe5a890f81663bdf4031f622e5a33f493aa0fb2","original_commit_id":"042bff4c3cb6ebe8a09891f7a221e88746fa5945","user":{"login":"lucianposton","id":646121,"avatar_url":"https://avatars.githubusercontent.com/u/646121?v=3","gravatar_id":"","url":"https://api.github.com/users/lucianposton","html_url":"https://github.com/lucianposton","followers_url":"https://api.github.com/users/lucianposton/followers","following_url":"https://api.github.com/users/lucianposton/following{/other_user}","gists_url":"https://api.github.com/users/lucianposton/gists{/gist_id}","starred_url":"https://api.github.com/users/lucianposton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucianposton/subscriptions","organizations_url":"https://api.github.com/users/lucianposton/orgs","repos_url":"https://api.github.com/users/lucianposton/repos","events_url":"https://api.github.com/users/lucianposton/events{/privacy}","received_events_url":"https://api.github.com/users/lucianposton/received_events","type":"User","site_admin":false},"body":"fixed typo","created_at":"2015-12-01T19:47:32Z","updated_at":"2015-12-01T19:47:32Z","html_url":"https://github.com/Mudlet/Mudlet/pull/284#discussion_r46328568","pull_request_url":"https://api.github.com/repos/Mudlet/Mudlet/pulls/284","_links":{"self":{"href":"https://api.github.com/repos/Mudlet/Mudlet/pulls/comments/46328568"},"html":{"href":"https://github.com/Mudlet/Mudlet/pull/284#discussion_r46328568"},"pull_request":{"href":"https://api.github.com/repos/Mudlet/Mudlet/pulls/284"}}},"pull_request":{"url":"https://api.github.com/repos/Mudlet/Mudlet/pulls/284","id":52294989,"html_url":"https://github.com/Mudlet/Mudlet/pull/284","diff_url":"https://github.com/Mudlet/Mudlet/pull/284.diff","patch_url":"https://github.com/Mudlet/Mudlet/pull/284.patch","issue_url":"https://api.github.com/repos/Mudlet/Mudlet/issues/284","number":284,"state":"open","locked":false,"title":"Bugfix/Enhance: Load LuaGlobal.lua from LUA_DEFAULT_PATH","user":{"login":"lucianposton","id":646121,"avatar_url":"https://avatars.githubusercontent.com/u/646121?v=3","gravatar_id":"","url":"https://api.github.com/users/lucianposton","html_url":"https://github.com/lucianposton","followers_url":"https://api.github.com/users/lucianposton/followers","following_url":"https://api.github.com/users/lucianposton/following{/other_user}","gists_url":"https://api.github.com/users/lucianposton/gists{/gist_id}","starred_url":"https://api.github.com/users/lucianposton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucianposton/subscriptions","organizations_url":"https://api.github.com/users/lucianposton/orgs","repos_url":"https://api.github.com/users/lucianposton/repos","events_url":"https://api.github.com/users/lucianposton/events{/privacy}","received_events_url":"https://api.github.com/users/lucianposton/received_events","type":"User","site_admin":false},"body":"Add comptile-time fallback to LuaGlobal.lua loading logic to attempt to load\r\nfrom LUA_DEFAULT_PATH, defined in src/src.pro using the value from\r\nLUA_DEFAULT_DIR.\r\n\r\nFor platforms that don't currently define LUA_DEFAULT_DIR in src/src.pro (e.g.\r\nwin32, macx), the loading logic will behave as though LUA_DEFAULT_DIR were\r\ndefined as \"/\", the root directory. This is accomplished by compile time\r\nconcatenation of LUA_DEFAULT_PATH and the string literal \"/\". If necessary,\r\nLUA_DEFAULT_DIR can later be defined for additional platforms (win32, macx,\r\netc) in src/src.pro to provide a different compile-time fallback for that\r\nplatform.","created_at":"2015-12-01T18:18:32Z","updated_at":"2015-12-01T19:47:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b4d3f865c2159deaa6d213ec970053670614db71","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Mudlet/Mudlet/pulls/284/commits","review_comments_url":"https://api.github.com/repos/Mudlet/Mudlet/pulls/284/comments","review_comment_url":"https://api.github.com/repos/Mudlet/Mudlet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Mudlet/Mudlet/issues/284/comments","statuses_url":"https://api.github.com/repos/Mudlet/Mudlet/statuses/bfe5a890f81663bdf4031f622e5a33f493aa0fb2","head":{"label":"lucianposton:use-lua-default-path","ref":"use-lua-default-path","sha":"bfe5a890f81663bdf4031f622e5a33f493aa0fb2","user":{"login":"lucianposton","id":646121,"avatar_url":"https://avatars.githubusercontent.com/u/646121?v=3","gravatar_id":"","url":"https://api.github.com/users/lucianposton","html_url":"https://github.com/lucianposton","followers_url":"https://api.github.com/users/lucianposton/followers","following_url":"https://api.github.com/users/lucianposton/following{/other_user}","gists_url":"https://api.github.com/users/lucianposton/gists{/gist_id}","starred_url":"https://api.github.com/users/lucianposton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucianposton/subscriptions","organizations_url":"https://api.github.com/users/lucianposton/orgs","repos_url":"https://api.github.com/users/lucianposton/repos","events_url":"https://api.github.com/users/lucianposton/events{/privacy}","received_events_url":"https://api.github.com/users/lucianposton/received_events","type":"User","site_admin":false},"repo":{"id":47136402,"name":"Mudlet","full_name":"lucianposton/Mudlet","owner":{"login":"lucianposton","id":646121,"avatar_url":"https://avatars.githubusercontent.com/u/646121?v=3","gravatar_id":"","url":"https://api.github.com/users/lucianposton","html_url":"https://github.com/lucianposton","followers_url":"https://api.github.com/users/lucianposton/followers","following_url":"https://api.github.com/users/lucianposton/following{/other_user}","gists_url":"https://api.github.com/users/lucianposton/gists{/gist_id}","starred_url":"https://api.github.com/users/lucianposton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucianposton/subscriptions","organizations_url":"https://api.github.com/users/lucianposton/orgs","repos_url":"https://api.github.com/users/lucianposton/repos","events_url":"https://api.github.com/users/lucianposton/events{/privacy}","received_events_url":"https://api.github.com/users/lucianposton/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lucianposton/Mudlet","description":"A modern open source MUD client with a graphical user inteface and full built in Lua scripting support for all major platforms.","fork":true,"url":"https://api.github.com/repos/lucianposton/Mudlet","forks_url":"https://api.github.com/repos/lucianposton/Mudlet/forks","keys_url":"https://api.github.com/repos/lucianposton/Mudlet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lucianposton/Mudlet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lucianposton/Mudlet/teams","hooks_url":"https://api.github.com/repos/lucianposton/Mudlet/hooks","issue_events_url":"https://api.github.com/repos/lucianposton/Mudlet/issues/events{/number}","events_url":"https://api.github.com/repos/lucianposton/Mudlet/events","assignees_url":"https://api.github.com/repos/lucianposton/Mudlet/assignees{/user}","branches_url":"https://api.github.com/repos/lucianposton/Mudlet/branches{/branch}","tags_url":"https://api.github.com/repos/lucianposton/Mudlet/tags","blobs_url":"https://api.github.com/repos/lucianposton/Mudlet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lucianposton/Mudlet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lucianposton/Mudlet/git/refs{/sha}","trees_url":"https://api.github.com/repos/lucianposton/Mudlet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lucianposton/Mudlet/statuses/{sha}","languages_url":"https://api.github.com/repos/lucianposton/Mudlet/languages","stargazers_url":"https://api.github.com/repos/lucianposton/Mudlet/stargazers","contributors_url":"https://api.github.com/repos/lucianposton/Mudlet/contributors","subscribers_url":"https://api.github.com/repos/lucianposton/Mudlet/subscribers","subscription_url":"https://api.github.com/repos/lucianposton/Mudlet/subscription","commits_url":"https://api.github.com/repos/lucianposton/Mudlet/commits{/sha}","git_commits_url":"https://api.github.com/repos/lucianposton/Mudlet/git/commits{/sha}","comments_url":"https://api.github.com/repos/lucianposton/Mudlet/comments{/number}","issue_comment_url":"https://api.github.com/repos/lucianposton/Mudlet/issues/comments{/number}","contents_url":"https://api.github.com/repos/lucianposton/Mudlet/contents/{+path}","compare_url":"https://api.github.com/repos/lucianposton/Mudlet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lucianposton/Mudlet/merges","archive_url":"https://api.github.com/repos/lucianposton/Mudlet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lucianposton/Mudlet/downloads","issues_url":"https://api.github.com/repos/lucianposton/Mudlet/issues{/number}","pulls_url":"https://api.github.com/repos/lucianposton/Mudlet/pulls{/number}","milestones_url":"https://api.github.com/repos/lucianposton/Mudlet/milestones{/number}","notifications_url":"https://api.github.com/repos/lucianposton/Mudlet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lucianposton/Mudlet/labels{/name}","releases_url":"https://api.github.com/repos/lucianposton/Mudlet/releases{/id}","created_at":"2015-11-30T18:02:35Z","updated_at":"2015-11-30T18:02:39Z","pushed_at":"2015-12-01T19:46:14Z","git_url":"git://github.com/lucianposton/Mudlet.git","ssh_url":"git@github.com:lucianposton/Mudlet.git","clone_url":"https://github.com/lucianposton/Mudlet.git","svn_url":"https://github.com/lucianposton/Mudlet","homepage":null,"size":19526,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"development"}},"base":{"label":"Mudlet:development","ref":"development","sha":"12296577862f8058bb4783bbc9c761942e407146","user":{"login":"Mudlet","id":6158612,"avatar_url":"https://avatars.githubusercontent.com/u/6158612?v=3","gravatar_id":"","url":"https://api.github.com/users/Mudlet","html_url":"https://github.com/Mudlet","followers_url":"https://api.github.com/users/Mudlet/followers","following_url":"https://api.github.com/users/Mudlet/following{/other_user}","gists_url":"https://api.github.com/users/Mudlet/gists{/gist_id}","starred_url":"https://api.github.com/users/Mudlet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mudlet/subscriptions","organizations_url":"https://api.github.com/users/Mudlet/orgs","repos_url":"https://api.github.com/users/Mudlet/repos","events_url":"https://api.github.com/users/Mudlet/events{/privacy}","received_events_url":"https://api.github.com/users/Mudlet/received_events","type":"Organization","site_admin":false},"repo":{"id":15108812,"name":"Mudlet","full_name":"Mudlet/Mudlet","owner":{"login":"Mudlet","id":6158612,"avatar_url":"https://avatars.githubusercontent.com/u/6158612?v=3","gravatar_id":"","url":"https://api.github.com/users/Mudlet","html_url":"https://github.com/Mudlet","followers_url":"https://api.github.com/users/Mudlet/followers","following_url":"https://api.github.com/users/Mudlet/following{/other_user}","gists_url":"https://api.github.com/users/Mudlet/gists{/gist_id}","starred_url":"https://api.github.com/users/Mudlet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mudlet/subscriptions","organizations_url":"https://api.github.com/users/Mudlet/orgs","repos_url":"https://api.github.com/users/Mudlet/repos","events_url":"https://api.github.com/users/Mudlet/events{/privacy}","received_events_url":"https://api.github.com/users/Mudlet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Mudlet/Mudlet","description":"A modern open source MUD client with a graphical user inteface and full built in Lua scripting support for all major platforms.","fork":false,"url":"https://api.github.com/repos/Mudlet/Mudlet","forks_url":"https://api.github.com/repos/Mudlet/Mudlet/forks","keys_url":"https://api.github.com/repos/Mudlet/Mudlet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Mudlet/Mudlet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Mudlet/Mudlet/teams","hooks_url":"https://api.github.com/repos/Mudlet/Mudlet/hooks","issue_events_url":"https://api.github.com/repos/Mudlet/Mudlet/issues/events{/number}","events_url":"https://api.github.com/repos/Mudlet/Mudlet/events","assignees_url":"https://api.github.com/repos/Mudlet/Mudlet/assignees{/user}","branches_url":"https://api.github.com/repos/Mudlet/Mudlet/branches{/branch}","tags_url":"https://api.github.com/repos/Mudlet/Mudlet/tags","blobs_url":"https://api.github.com/repos/Mudlet/Mudlet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Mudlet/Mudlet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Mudlet/Mudlet/git/refs{/sha}","trees_url":"https://api.github.com/repos/Mudlet/Mudlet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Mudlet/Mudlet/statuses/{sha}","languages_url":"https://api.github.com/repos/Mudlet/Mudlet/languages","stargazers_url":"https://api.github.com/repos/Mudlet/Mudlet/stargazers","contributors_url":"https://api.github.com/repos/Mudlet/Mudlet/contributors","subscribers_url":"https://api.github.com/repos/Mudlet/Mudlet/subscribers","subscription_url":"https://api.github.com/repos/Mudlet/Mudlet/subscription","commits_url":"https://api.github.com/repos/Mudlet/Mudlet/commits{/sha}","git_commits_url":"https://api.github.com/repos/Mudlet/Mudlet/git/commits{/sha}","comments_url":"https://api.github.com/repos/Mudlet/Mudlet/comments{/number}","issue_comment_url":"https://api.github.com/repos/Mudlet/Mudlet/issues/comments{/number}","contents_url":"https://api.github.com/repos/Mudlet/Mudlet/contents/{+path}","compare_url":"https://api.github.com/repos/Mudlet/Mudlet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Mudlet/Mudlet/merges","archive_url":"https://api.github.com/repos/Mudlet/Mudlet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Mudlet/Mudlet/downloads","issues_url":"https://api.github.com/repos/Mudlet/Mudlet/issues{/number}","pulls_url":"https://api.github.com/repos/Mudlet/Mudlet/pulls{/number}","milestones_url":"https://api.github.com/repos/Mudlet/Mudlet/milestones{/number}","notifications_url":"https://api.github.com/repos/Mudlet/Mudlet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Mudlet/Mudlet/labels{/name}","releases_url":"https://api.github.com/repos/Mudlet/Mudlet/releases{/id}","created_at":"2013-12-11T14:04:21Z","updated_at":"2015-11-13T13:04:10Z","pushed_at":"2015-12-01T19:46:14Z","git_url":"git://github.com/Mudlet/Mudlet.git","ssh_url":"git@github.com:Mudlet/Mudlet.git","clone_url":"https://github.com/Mudlet/Mudlet.git","svn_url":"https://github.com/Mudlet/Mudlet","homepage":null,"size":20299,"stargazers_count":44,"watchers_count":44,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":29,"mirror_url":null,"open_issues_count":12,"forks":29,"open_issues":12,"watchers":44,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/Mudlet/Mudlet/pulls/284"},"html":{"href":"https://github.com/Mudlet/Mudlet/pull/284"},"issue":{"href":"https://api.github.com/repos/Mudlet/Mudlet/issues/284"},"comments":{"href":"https://api.github.com/repos/Mudlet/Mudlet/issues/284/comments"},"review_comments":{"href":"https://api.github.com/repos/Mudlet/Mudlet/pulls/284/comments"},"review_comment":{"href":"https://api.github.com/repos/Mudlet/Mudlet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Mudlet/Mudlet/pulls/284/commits"},"statuses":{"href":"https://api.github.com/repos/Mudlet/Mudlet/statuses/bfe5a890f81663bdf4031f622e5a33f493aa0fb2"}}}}