{"action":"created","comment":{"url":"https://api.github.com/repos/rails/rails/pulls/comments/24683116","id":24683116,"diff_hunk":"@@ -241,4 +241,10 @@ class ImmutableRelation < ActiveRecordError\n   # The mysql, mysql2 and postgresql adapters support setting the transaction isolation level.\n   class TransactionIsolationError < ActiveRecordError\n   end\n+\n+  # UnreversableOrderError will be raised when #reverse_order can not reverse the order.","path":"activerecord/lib/active_record/errors.rb","position":5,"original_position":5,"commit_id":"5a9352f17d0c11cfea9c6a6bad8c5de30e5a2106","original_commit_id":"5a9352f17d0c11cfea9c6a6bad8c5de30e5a2106","user":{"login":"kaspth","id":350807,"avatar_url":"https://avatars.githubusercontent.com/u/350807?v=3","gravatar_id":"","url":"https://api.github.com/users/kaspth","html_url":"https://github.com/kaspth","followers_url":"https://api.github.com/users/kaspth/followers","following_url":"https://api.github.com/users/kaspth/following{/other_user}","gists_url":"https://api.github.com/users/kaspth/gists{/gist_id}","starred_url":"https://api.github.com/users/kaspth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaspth/subscriptions","organizations_url":"https://api.github.com/users/kaspth/orgs","repos_url":"https://api.github.com/users/kaspth/repos","events_url":"https://api.github.com/users/kaspth/events{/privacy}","received_events_url":"https://api.github.com/users/kaspth/received_events","type":"User","site_admin":false},"body":"You're correct ;)\n\n--\nKasper\n\n> Den 13/02/2015 kl. 18.54 skrev Eugene Gilburg <notifications@github.com>:\n> \n> In activerecord/lib/active_record/errors.rb:\n> \n> > @@ -241,4 +241,10 @@ class ImmutableRelation < ActiveRecordError\n> >    # The mysql, mysql2 and postgresql adapters support setting the transaction isolation level.\n> >    class TransactionIsolationError < ActiveRecordError\n> >    end\n> > +\n> > +  # UnreversableOrderError will be raised when #reverse_order can not reverse the order.\n> I think it's spelled Irreversible\n> \n> —\n> Reply to this email directly or view it on GitHub.\n> \n","created_at":"2015-02-13T18:04:17Z","updated_at":"2015-02-13T18:04:17Z","html_url":"https://github.com/rails/rails/pull/18928#discussion_r24683116","pull_request_url":"https://api.github.com/repos/rails/rails/pulls/18928","_links":{"self":{"href":"https://api.github.com/repos/rails/rails/pulls/comments/24683116"},"html":{"href":"https://github.com/rails/rails/pull/18928#discussion_r24683116"},"pull_request":{"href":"https://api.github.com/repos/rails/rails/pulls/18928"}}},"pull_request":{"url":"https://api.github.com/repos/rails/rails/pulls/18928","id":29267471,"html_url":"https://github.com/rails/rails/pull/18928","diff_url":"https://github.com/rails/rails/pull/18928.diff","patch_url":"https://github.com/rails/rails/pull/18928.patch","issue_url":"https://api.github.com/repos/rails/rails/issues/18928","number":18928,"state":"open","locked":false,"title":"Raise AR::UnreversableOrderError when #reverse_order can not do it's job","user":{"login":"bogdan","id":122436,"avatar_url":"https://avatars.githubusercontent.com/u/122436?v=3","gravatar_id":"","url":"https://api.github.com/users/bogdan","html_url":"https://github.com/bogdan","followers_url":"https://api.github.com/users/bogdan/followers","following_url":"https://api.github.com/users/bogdan/following{/other_user}","gists_url":"https://api.github.com/users/bogdan/gists{/gist_id}","starred_url":"https://api.github.com/users/bogdan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bogdan/subscriptions","organizations_url":"https://api.github.com/users/bogdan/orgs","repos_url":"https://api.github.com/users/bogdan/repos","events_url":"https://api.github.com/users/bogdan/events{/privacy}","received_events_url":"https://api.github.com/users/bogdan/received_events","type":"User","site_admin":false},"body":"Current `#reverse_order` algorithm is very simple and doesn't try to\r\nhandle complicated cases of reversing order given as string.\r\nThis patch makes AR to raise exception instead of generating invalid SQL\r\ninside `#reverse_order`.\r\n\r\nFixes #8225, #11571\r\n\r\nThis patch is alternative to #16779 and #18754.","created_at":"2015-02-13T14:19:41Z","updated_at":"2015-02-13T18:04:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"13350102ca6c7a49fbf16c42dacc4c14477e63ff","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rails/rails/pulls/18928/commits","review_comments_url":"https://api.github.com/repos/rails/rails/pulls/18928/comments","review_comment_url":"https://api.github.com/repos/rails/rails/pulls/comments/{number}","comments_url":"https://api.github.com/repos/rails/rails/issues/18928/comments","statuses_url":"https://api.github.com/repos/rails/rails/statuses/5a9352f17d0c11cfea9c6a6bad8c5de30e5a2106","head":{"label":"bogdan:unreversable-order","ref":"unreversable-order","sha":"5a9352f17d0c11cfea9c6a6bad8c5de30e5a2106","user":{"login":"bogdan","id":122436,"avatar_url":"https://avatars.githubusercontent.com/u/122436?v=3","gravatar_id":"","url":"https://api.github.com/users/bogdan","html_url":"https://github.com/bogdan","followers_url":"https://api.github.com/users/bogdan/followers","following_url":"https://api.github.com/users/bogdan/following{/other_user}","gists_url":"https://api.github.com/users/bogdan/gists{/gist_id}","starred_url":"https://api.github.com/users/bogdan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bogdan/subscriptions","organizations_url":"https://api.github.com/users/bogdan/orgs","repos_url":"https://api.github.com/users/bogdan/repos","events_url":"https://api.github.com/users/bogdan/events{/privacy}","received_events_url":"https://api.github.com/users/bogdan/received_events","type":"User","site_admin":false},"repo":{"id":3515719,"name":"rails","full_name":"bogdan/rails","owner":{"login":"bogdan","id":122436,"avatar_url":"https://avatars.githubusercontent.com/u/122436?v=3","gravatar_id":"","url":"https://api.github.com/users/bogdan","html_url":"https://github.com/bogdan","followers_url":"https://api.github.com/users/bogdan/followers","following_url":"https://api.github.com/users/bogdan/following{/other_user}","gists_url":"https://api.github.com/users/bogdan/gists{/gist_id}","starred_url":"https://api.github.com/users/bogdan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bogdan/subscriptions","organizations_url":"https://api.github.com/users/bogdan/orgs","repos_url":"https://api.github.com/users/bogdan/repos","events_url":"https://api.github.com/users/bogdan/events{/privacy}","received_events_url":"https://api.github.com/users/bogdan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bogdan/rails","description":"Ruby on Rails","fork":true,"url":"https://api.github.com/repos/bogdan/rails","forks_url":"https://api.github.com/repos/bogdan/rails/forks","keys_url":"https://api.github.com/repos/bogdan/rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bogdan/rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bogdan/rails/teams","hooks_url":"https://api.github.com/repos/bogdan/rails/hooks","issue_events_url":"https://api.github.com/repos/bogdan/rails/issues/events{/number}","events_url":"https://api.github.com/repos/bogdan/rails/events","assignees_url":"https://api.github.com/repos/bogdan/rails/assignees{/user}","branches_url":"https://api.github.com/repos/bogdan/rails/branches{/branch}","tags_url":"https://api.github.com/repos/bogdan/rails/tags","blobs_url":"https://api.github.com/repos/bogdan/rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bogdan/rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bogdan/rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/bogdan/rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bogdan/rails/statuses/{sha}","languages_url":"https://api.github.com/repos/bogdan/rails/languages","stargazers_url":"https://api.github.com/repos/bogdan/rails/stargazers","contributors_url":"https://api.github.com/repos/bogdan/rails/contributors","subscribers_url":"https://api.github.com/repos/bogdan/rails/subscribers","subscription_url":"https://api.github.com/repos/bogdan/rails/subscription","commits_url":"https://api.github.com/repos/bogdan/rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/bogdan/rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/bogdan/rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/bogdan/rails/issues/comments/{number}","contents_url":"https://api.github.com/repos/bogdan/rails/contents/{+path}","compare_url":"https://api.github.com/repos/bogdan/rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bogdan/rails/merges","archive_url":"https://api.github.com/repos/bogdan/rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bogdan/rails/downloads","issues_url":"https://api.github.com/repos/bogdan/rails/issues{/number}","pulls_url":"https://api.github.com/repos/bogdan/rails/pulls{/number}","milestones_url":"https://api.github.com/repos/bogdan/rails/milestones{/number}","notifications_url":"https://api.github.com/repos/bogdan/rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bogdan/rails/labels{/name}","releases_url":"https://api.github.com/repos/bogdan/rails/releases{/id}","created_at":"2012-02-22T15:18:15Z","updated_at":"2015-01-26T09:16:44Z","pushed_at":"2015-02-13T16:20:46Z","git_url":"git://github.com/bogdan/rails.git","ssh_url":"git@github.com:bogdan/rails.git","clone_url":"https://github.com/bogdan/rails.git","svn_url":"https://github.com/bogdan/rails","homepage":"http://rubyonrails.org","size":126712,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"rails:master","ref":"master","sha":"7919c29d507b571315a6391fe56bf4f3bce23689","user":{"login":"rails","id":4223,"avatar_url":"https://avatars.githubusercontent.com/u/4223?v=3","gravatar_id":"","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"repo":{"id":8514,"name":"rails","full_name":"rails/rails","owner":{"login":"rails","id":4223,"avatar_url":"https://avatars.githubusercontent.com/u/4223?v=3","gravatar_id":"","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rails/rails","description":"Ruby on Rails","fork":false,"url":"https://api.github.com/repos/rails/rails","forks_url":"https://api.github.com/repos/rails/rails/forks","keys_url":"https://api.github.com/repos/rails/rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rails/rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rails/rails/teams","hooks_url":"https://api.github.com/repos/rails/rails/hooks","issue_events_url":"https://api.github.com/repos/rails/rails/issues/events{/number}","events_url":"https://api.github.com/repos/rails/rails/events","assignees_url":"https://api.github.com/repos/rails/rails/assignees{/user}","branches_url":"https://api.github.com/repos/rails/rails/branches{/branch}","tags_url":"https://api.github.com/repos/rails/rails/tags","blobs_url":"https://api.github.com/repos/rails/rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rails/rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rails/rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/rails/rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rails/rails/statuses/{sha}","languages_url":"https://api.github.com/repos/rails/rails/languages","stargazers_url":"https://api.github.com/repos/rails/rails/stargazers","contributors_url":"https://api.github.com/repos/rails/rails/contributors","subscribers_url":"https://api.github.com/repos/rails/rails/subscribers","subscription_url":"https://api.github.com/repos/rails/rails/subscription","commits_url":"https://api.github.com/repos/rails/rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/rails/rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/rails/rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/rails/rails/issues/comments/{number}","contents_url":"https://api.github.com/repos/rails/rails/contents/{+path}","compare_url":"https://api.github.com/repos/rails/rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rails/rails/merges","archive_url":"https://api.github.com/repos/rails/rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rails/rails/downloads","issues_url":"https://api.github.com/repos/rails/rails/issues{/number}","pulls_url":"https://api.github.com/repos/rails/rails/pulls{/number}","milestones_url":"https://api.github.com/repos/rails/rails/milestones{/number}","notifications_url":"https://api.github.com/repos/rails/rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rails/rails/labels{/name}","releases_url":"https://api.github.com/repos/rails/rails/releases{/id}","created_at":"2008-04-11T02:19:47Z","updated_at":"2015-02-13T17:36:09Z","pushed_at":"2015-02-13T14:09:44Z","git_url":"git://github.com/rails/rails.git","ssh_url":"git@github.com:rails/rails.git","clone_url":"https://github.com/rails/rails.git","svn_url":"https://github.com/rails/rails","homepage":"http://rubyonrails.org","size":374514,"stargazers_count":24932,"watchers_count":24932,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":9705,"mirror_url":null,"open_issues_count":750,"forks":9705,"open_issues":750,"watchers":24932,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rails/rails/pulls/18928"},"html":{"href":"https://github.com/rails/rails/pull/18928"},"issue":{"href":"https://api.github.com/repos/rails/rails/issues/18928"},"comments":{"href":"https://api.github.com/repos/rails/rails/issues/18928/comments"},"review_comments":{"href":"https://api.github.com/repos/rails/rails/pulls/18928/comments"},"review_comment":{"href":"https://api.github.com/repos/rails/rails/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/rails/rails/pulls/18928/commits"},"statuses":{"href":"https://api.github.com/repos/rails/rails/statuses/5a9352f17d0c11cfea9c6a6bad8c5de30e5a2106"}}}}