{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/commonplace/pulls/comments/24875424","id":24875424,"diff_hunk":"@@ -58,31 +10,17 @@ var bowerConfig = {\n     // TODO: Use the official nunjucks and not a modified one.\n     // 'nunjucks/browser/nunjucks-slim.js': LIB_DEST_PATH,\n     'underscore/underscore.js': LIB_DEST_PATH,\n-    'marketplace-core-modules/tests/**/*.js': CORE_DEST_PATH + 'tests',\n-    'marketplace-core-modules/tests/tests.html': 'src/templates/commonplace/'\n };\n-CORE_MODULES.forEach(function(module) {\n-    if (CORE_MODULES_ROOT_JS.indexOf(module) !== -1) {\n-        // Modules that go into the root JS path (for some reason).\n-        bowerConfig[CORE_SRC_PATH + module + '.js'] = JS_DEST_PATH;\n-        return;\n-    }\n-    bowerConfig[CORE_SRC_PATH + module + '.js'] = CORE_DEST_PATH;\n-});\n-CORE_VIEWS.forEach(function(view) {\n-    bowerConfig[CORE_SRC_PATH + view + '.js'] = CORE_DEST_PATH + 'views/';\n-});\n \n // Build require config, to be used in development and AMD optimizers.\n var requireConfig = {\n     enforceDefine: true,\n     paths: {\n+        'core': 'lib/core',","path":"lib/config.js","position":78,"original_position":78,"commit_id":"f1a396ff33e65dc7f36cea261b55db6d40271aa7","original_commit_id":"f1a396ff33e65dc7f36cea261b55db6d40271aa7","user":{"login":"ngokevin","id":674727,"avatar_url":"https://avatars.githubusercontent.com/u/674727?v=3","gravatar_id":"","url":"https://api.github.com/users/ngokevin","html_url":"https://github.com/ngokevin","followers_url":"https://api.github.com/users/ngokevin/followers","following_url":"https://api.github.com/users/ngokevin/following{/other_user}","gists_url":"https://api.github.com/users/ngokevin/gists{/gist_id}","starred_url":"https://api.github.com/users/ngokevin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngokevin/subscriptions","organizations_url":"https://api.github.com/users/ngokevin/orgs","repos_url":"https://api.github.com/users/ngokevin/repos","events_url":"https://api.github.com/users/ngokevin/events{/privacy}","received_events_url":"https://api.github.com/users/ngokevin/received_events","type":"User","site_admin":false},"body":"Alright. I think it'd be safe to say all consumers of marketplace-gulp/commonplace will be using mcm.","created_at":"2015-02-18T02:37:18Z","updated_at":"2015-02-18T02:37:18Z","html_url":"https://github.com/mozilla/commonplace/pull/61#discussion_r24875424","pull_request_url":"https://api.github.com/repos/mozilla/commonplace/pulls/61","_links":{"self":{"href":"https://api.github.com/repos/mozilla/commonplace/pulls/comments/24875424"},"html":{"href":"https://github.com/mozilla/commonplace/pull/61#discussion_r24875424"},"pull_request":{"href":"https://api.github.com/repos/mozilla/commonplace/pulls/61"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/commonplace/pulls/61","id":29486908,"html_url":"https://github.com/mozilla/commonplace/pull/61","diff_url":"https://github.com/mozilla/commonplace/pull/61.diff","patch_url":"https://github.com/mozilla/commonplace/pull/61.patch","issue_url":"https://api.github.com/repos/mozilla/commonplace/issues/61","number":61,"state":"open","locked":false,"title":"Handle the marketplace-core-modules core/ prefix","user":{"login":"mstriemer","id":211578,"avatar_url":"https://avatars.githubusercontent.com/u/211578?v=3","gravatar_id":"","url":"https://api.github.com/users/mstriemer","html_url":"https://github.com/mstriemer","followers_url":"https://api.github.com/users/mstriemer/followers","following_url":"https://api.github.com/users/mstriemer/following{/other_user}","gists_url":"https://api.github.com/users/mstriemer/gists{/gist_id}","starred_url":"https://api.github.com/users/mstriemer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mstriemer/subscriptions","organizations_url":"https://api.github.com/users/mstriemer/orgs","repos_url":"https://api.github.com/users/mstriemer/repos","events_url":"https://api.github.com/users/mstriemer/events{/privacy}","received_events_url":"https://api.github.com/users/mstriemer/received_events","type":"User","site_admin":false},"body":"DO NOT MERGE! This depends on the m-c-m module renaming and marketplace-gulp webserver updates in the v2.0.0/testing updates.\r\n\r\nStop copying marketplace-core-modules files because the webserver will now serve them.","created_at":"2015-02-17T23:10:22Z","updated_at":"2015-02-18T02:37:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dd86a96f0cbdaed1a4885dc5b8d505970465a895","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/commonplace/pulls/61/commits","review_comments_url":"https://api.github.com/repos/mozilla/commonplace/pulls/61/comments","review_comment_url":"https://api.github.com/repos/mozilla/commonplace/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mozilla/commonplace/issues/61/comments","statuses_url":"https://api.github.com/repos/mozilla/commonplace/statuses/f1a396ff33e65dc7f36cea261b55db6d40271aa7","head":{"label":"mstriemer:handle-mcm-core-prefix","ref":"handle-mcm-core-prefix","sha":"f1a396ff33e65dc7f36cea261b55db6d40271aa7","user":{"login":"mstriemer","id":211578,"avatar_url":"https://avatars.githubusercontent.com/u/211578?v=3","gravatar_id":"","url":"https://api.github.com/users/mstriemer","html_url":"https://github.com/mstriemer","followers_url":"https://api.github.com/users/mstriemer/followers","following_url":"https://api.github.com/users/mstriemer/following{/other_user}","gists_url":"https://api.github.com/users/mstriemer/gists{/gist_id}","starred_url":"https://api.github.com/users/mstriemer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mstriemer/subscriptions","organizations_url":"https://api.github.com/users/mstriemer/orgs","repos_url":"https://api.github.com/users/mstriemer/repos","events_url":"https://api.github.com/users/mstriemer/events{/privacy}","received_events_url":"https://api.github.com/users/mstriemer/received_events","type":"User","site_admin":false},"repo":{"id":15907940,"name":"commonplace","full_name":"mstriemer/commonplace","owner":{"login":"mstriemer","id":211578,"avatar_url":"https://avatars.githubusercontent.com/u/211578?v=3","gravatar_id":"","url":"https://api.github.com/users/mstriemer","html_url":"https://github.com/mstriemer","followers_url":"https://api.github.com/users/mstriemer/followers","following_url":"https://api.github.com/users/mstriemer/following{/other_user}","gists_url":"https://api.github.com/users/mstriemer/gists{/gist_id}","starred_url":"https://api.github.com/users/mstriemer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mstriemer/subscriptions","organizations_url":"https://api.github.com/users/mstriemer/orgs","repos_url":"https://api.github.com/users/mstriemer/repos","events_url":"https://api.github.com/users/mstriemer/events{/privacy}","received_events_url":"https://api.github.com/users/mstriemer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mstriemer/commonplace","description":"Common, reusable components for the Firefox Marketplace...and beyond!","fork":true,"url":"https://api.github.com/repos/mstriemer/commonplace","forks_url":"https://api.github.com/repos/mstriemer/commonplace/forks","keys_url":"https://api.github.com/repos/mstriemer/commonplace/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mstriemer/commonplace/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mstriemer/commonplace/teams","hooks_url":"https://api.github.com/repos/mstriemer/commonplace/hooks","issue_events_url":"https://api.github.com/repos/mstriemer/commonplace/issues/events{/number}","events_url":"https://api.github.com/repos/mstriemer/commonplace/events","assignees_url":"https://api.github.com/repos/mstriemer/commonplace/assignees{/user}","branches_url":"https://api.github.com/repos/mstriemer/commonplace/branches{/branch}","tags_url":"https://api.github.com/repos/mstriemer/commonplace/tags","blobs_url":"https://api.github.com/repos/mstriemer/commonplace/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mstriemer/commonplace/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mstriemer/commonplace/git/refs{/sha}","trees_url":"https://api.github.com/repos/mstriemer/commonplace/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mstriemer/commonplace/statuses/{sha}","languages_url":"https://api.github.com/repos/mstriemer/commonplace/languages","stargazers_url":"https://api.github.com/repos/mstriemer/commonplace/stargazers","contributors_url":"https://api.github.com/repos/mstriemer/commonplace/contributors","subscribers_url":"https://api.github.com/repos/mstriemer/commonplace/subscribers","subscription_url":"https://api.github.com/repos/mstriemer/commonplace/subscription","commits_url":"https://api.github.com/repos/mstriemer/commonplace/commits{/sha}","git_commits_url":"https://api.github.com/repos/mstriemer/commonplace/git/commits{/sha}","comments_url":"https://api.github.com/repos/mstriemer/commonplace/comments{/number}","issue_comment_url":"https://api.github.com/repos/mstriemer/commonplace/issues/comments/{number}","contents_url":"https://api.github.com/repos/mstriemer/commonplace/contents/{+path}","compare_url":"https://api.github.com/repos/mstriemer/commonplace/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mstriemer/commonplace/merges","archive_url":"https://api.github.com/repos/mstriemer/commonplace/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mstriemer/commonplace/downloads","issues_url":"https://api.github.com/repos/mstriemer/commonplace/issues{/number}","pulls_url":"https://api.github.com/repos/mstriemer/commonplace/pulls{/number}","milestones_url":"https://api.github.com/repos/mstriemer/commonplace/milestones{/number}","notifications_url":"https://api.github.com/repos/mstriemer/commonplace/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mstriemer/commonplace/labels{/name}","releases_url":"https://api.github.com/repos/mstriemer/commonplace/releases{/id}","created_at":"2014-01-14T16:29:32Z","updated_at":"2014-01-14T18:53:28Z","pushed_at":"2015-02-17T23:08:36Z","git_url":"git://github.com/mstriemer/commonplace.git","ssh_url":"git@github.com:mstriemer/commonplace.git","clone_url":"https://github.com/mstriemer/commonplace.git","svn_url":"https://github.com/mstriemer/commonplace","homepage":"","size":1528,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"3346ec0bc51581ca0cabc64b13dea8519637c878","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":11262627,"name":"commonplace","full_name":"mozilla/commonplace","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/commonplace","description":"Node modules for Firefox Marketplace frontend projects","fork":false,"url":"https://api.github.com/repos/mozilla/commonplace","forks_url":"https://api.github.com/repos/mozilla/commonplace/forks","keys_url":"https://api.github.com/repos/mozilla/commonplace/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/commonplace/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/commonplace/teams","hooks_url":"https://api.github.com/repos/mozilla/commonplace/hooks","issue_events_url":"https://api.github.com/repos/mozilla/commonplace/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/commonplace/events","assignees_url":"https://api.github.com/repos/mozilla/commonplace/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/commonplace/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/commonplace/tags","blobs_url":"https://api.github.com/repos/mozilla/commonplace/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/commonplace/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/commonplace/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/commonplace/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/commonplace/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/commonplace/languages","stargazers_url":"https://api.github.com/repos/mozilla/commonplace/stargazers","contributors_url":"https://api.github.com/repos/mozilla/commonplace/contributors","subscribers_url":"https://api.github.com/repos/mozilla/commonplace/subscribers","subscription_url":"https://api.github.com/repos/mozilla/commonplace/subscription","commits_url":"https://api.github.com/repos/mozilla/commonplace/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/commonplace/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/commonplace/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/commonplace/issues/comments/{number}","contents_url":"https://api.github.com/repos/mozilla/commonplace/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/commonplace/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/commonplace/merges","archive_url":"https://api.github.com/repos/mozilla/commonplace/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/commonplace/downloads","issues_url":"https://api.github.com/repos/mozilla/commonplace/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/commonplace/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/commonplace/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/commonplace/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/commonplace/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/commonplace/releases{/id}","created_at":"2013-07-08T19:03:34Z","updated_at":"2015-02-11T02:15:04Z","pushed_at":"2015-02-11T02:15:02Z","git_url":"git://github.com/mozilla/commonplace.git","ssh_url":"git@github.com:mozilla/commonplace.git","clone_url":"https://github.com/mozilla/commonplace.git","svn_url":"https://github.com/mozilla/commonplace","homepage":"","size":3246,"stargazers_count":9,"watchers_count":9,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"open_issues_count":3,"forks":20,"open_issues":3,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/commonplace/pulls/61"},"html":{"href":"https://github.com/mozilla/commonplace/pull/61"},"issue":{"href":"https://api.github.com/repos/mozilla/commonplace/issues/61"},"comments":{"href":"https://api.github.com/repos/mozilla/commonplace/issues/61/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/commonplace/pulls/61/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/commonplace/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mozilla/commonplace/pulls/61/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/commonplace/statuses/f1a396ff33e65dc7f36cea261b55db6d40271aa7"}}}}