{"action":"closed","number":276,"pull_request":{"url":"https://api.github.com/repos/mroth/lolcommits/pulls/276","id":33617606,"html_url":"https://github.com/mroth/lolcommits/pull/276","diff_url":"https://github.com/mroth/lolcommits/pull/276.diff","patch_url":"https://github.com/mroth/lolcommits/pull/276.patch","issue_url":"https://api.github.com/repos/mroth/lolcommits/issues/276","number":276,"state":"closed","locked":false,"title":"fixing windows mini_magick escape issues","user":{"login":"matthutchinson","id":2095,"avatar_url":"https://avatars.githubusercontent.com/u/2095?v=3","gravatar_id":"","url":"https://api.github.com/users/matthutchinson","html_url":"https://github.com/matthutchinson","followers_url":"https://api.github.com/users/matthutchinson/followers","following_url":"https://api.github.com/users/matthutchinson/following{/other_user}","gists_url":"https://api.github.com/users/matthutchinson/gists{/gist_id}","starred_url":"https://api.github.com/users/matthutchinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthutchinson/subscriptions","organizations_url":"https://api.github.com/users/matthutchinson/orgs","repos_url":"https://api.github.com/users/matthutchinson/repos","events_url":"https://api.github.com/users/matthutchinson/events{/privacy}","received_events_url":"https://api.github.com/users/matthutchinson/received_events","type":"User","site_admin":false},"body":"To maintain MiniMagick compatibility on Windows for v3.8.1 we need this patch.  \r\n\r\nIt fixes an issue that was [introduced in an earlier version](https://github.com/minimagick/minimagick/commit/65b6427395cbfe6) of MiniMagick, but was later fixed in 4+\r\n\r\nWe are locked at v3.8.1 since MiniMagick 4+ dropped support for Ruby 1.8.7. If/when we upgrade MiniMagick to 4.2+ this patch can be removed.\r\n\r\nTesting in Windows 8.1 and now working:\r\n\r\n![019a9b8c-e692-11e4-8ea7-4eb88a03ed62](https://cloud.githubusercontent.com/assets/2095/7219335/72b8dc3e-e692-11e4-95f7-4675ed92a3b2.gif)\r\n\r\n:rocket: (also bumps rubocop gem to 0.30 and travis tests on Ruby 2.2.2)\r\n\r\n","created_at":"2015-04-19T11:49:12Z","updated_at":"2015-04-19T13:22:16Z","closed_at":"2015-04-19T13:22:16Z","merged_at":"2015-04-19T13:22:16Z","merge_commit_sha":"a7ac9a69565f7d07ec0e7960a5f97d989b7d5c3c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mroth/lolcommits/pulls/276/commits","review_comments_url":"https://api.github.com/repos/mroth/lolcommits/pulls/276/comments","review_comment_url":"https://api.github.com/repos/mroth/lolcommits/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mroth/lolcommits/issues/276/comments","statuses_url":"https://api.github.com/repos/mroth/lolcommits/statuses/cf7265743d36333b3fb427556b36973ed05d9564","head":{"label":"mroth:fix-windows-mini-magick-issue","ref":"fix-windows-mini-magick-issue","sha":"cf7265743d36333b3fb427556b36973ed05d9564","user":{"login":"mroth","id":40650,"avatar_url":"https://avatars.githubusercontent.com/u/40650?v=3","gravatar_id":"","url":"https://api.github.com/users/mroth","html_url":"https://github.com/mroth","followers_url":"https://api.github.com/users/mroth/followers","following_url":"https://api.github.com/users/mroth/following{/other_user}","gists_url":"https://api.github.com/users/mroth/gists{/gist_id}","starred_url":"https://api.github.com/users/mroth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mroth/subscriptions","organizations_url":"https://api.github.com/users/mroth/orgs","repos_url":"https://api.github.com/users/mroth/repos","events_url":"https://api.github.com/users/mroth/events{/privacy}","received_events_url":"https://api.github.com/users/mroth/received_events","type":"User","site_admin":false},"repo":{"id":2499845,"name":"lolcommits","full_name":"mroth/lolcommits","owner":{"login":"mroth","id":40650,"avatar_url":"https://avatars.githubusercontent.com/u/40650?v=3","gravatar_id":"","url":"https://api.github.com/users/mroth","html_url":"https://github.com/mroth","followers_url":"https://api.github.com/users/mroth/followers","following_url":"https://api.github.com/users/mroth/following{/other_user}","gists_url":"https://api.github.com/users/mroth/gists{/gist_id}","starred_url":"https://api.github.com/users/mroth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mroth/subscriptions","organizations_url":"https://api.github.com/users/mroth/orgs","repos_url":"https://api.github.com/users/mroth/repos","events_url":"https://api.github.com/users/mroth/events{/privacy}","received_events_url":"https://api.github.com/users/mroth/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mroth/lolcommits","description":":camera: git-based selfies for software developers","fork":false,"url":"https://api.github.com/repos/mroth/lolcommits","forks_url":"https://api.github.com/repos/mroth/lolcommits/forks","keys_url":"https://api.github.com/repos/mroth/lolcommits/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mroth/lolcommits/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mroth/lolcommits/teams","hooks_url":"https://api.github.com/repos/mroth/lolcommits/hooks","issue_events_url":"https://api.github.com/repos/mroth/lolcommits/issues/events{/number}","events_url":"https://api.github.com/repos/mroth/lolcommits/events","assignees_url":"https://api.github.com/repos/mroth/lolcommits/assignees{/user}","branches_url":"https://api.github.com/repos/mroth/lolcommits/branches{/branch}","tags_url":"https://api.github.com/repos/mroth/lolcommits/tags","blobs_url":"https://api.github.com/repos/mroth/lolcommits/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mroth/lolcommits/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mroth/lolcommits/git/refs{/sha}","trees_url":"https://api.github.com/repos/mroth/lolcommits/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mroth/lolcommits/statuses/{sha}","languages_url":"https://api.github.com/repos/mroth/lolcommits/languages","stargazers_url":"https://api.github.com/repos/mroth/lolcommits/stargazers","contributors_url":"https://api.github.com/repos/mroth/lolcommits/contributors","subscribers_url":"https://api.github.com/repos/mroth/lolcommits/subscribers","subscription_url":"https://api.github.com/repos/mroth/lolcommits/subscription","commits_url":"https://api.github.com/repos/mroth/lolcommits/commits{/sha}","git_commits_url":"https://api.github.com/repos/mroth/lolcommits/git/commits{/sha}","comments_url":"https://api.github.com/repos/mroth/lolcommits/comments{/number}","issue_comment_url":"https://api.github.com/repos/mroth/lolcommits/issues/comments{/number}","contents_url":"https://api.github.com/repos/mroth/lolcommits/contents/{+path}","compare_url":"https://api.github.com/repos/mroth/lolcommits/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mroth/lolcommits/merges","archive_url":"https://api.github.com/repos/mroth/lolcommits/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mroth/lolcommits/downloads","issues_url":"https://api.github.com/repos/mroth/lolcommits/issues{/number}","pulls_url":"https://api.github.com/repos/mroth/lolcommits/pulls{/number}","milestones_url":"https://api.github.com/repos/mroth/lolcommits/milestones{/number}","notifications_url":"https://api.github.com/repos/mroth/lolcommits/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mroth/lolcommits/labels{/name}","releases_url":"https://api.github.com/repos/mroth/lolcommits/releases{/id}","created_at":"2011-10-02T15:25:44Z","updated_at":"2015-04-18T17:31:02Z","pushed_at":"2015-04-19T13:22:16Z","git_url":"git://github.com/mroth/lolcommits.git","ssh_url":"git@github.com:mroth/lolcommits.git","clone_url":"https://github.com/mroth/lolcommits.git","svn_url":"https://github.com/mroth/lolcommits","homepage":"https://lolcommits.github.io","size":5589,"stargazers_count":2825,"watchers_count":2825,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":198,"mirror_url":null,"open_issues_count":27,"forks":198,"open_issues":27,"watchers":2825,"default_branch":"master"}},"base":{"label":"mroth:master","ref":"master","sha":"083dcb0fb1f9cd2eae06898f6c187460a4950077","user":{"login":"mroth","id":40650,"avatar_url":"https://avatars.githubusercontent.com/u/40650?v=3","gravatar_id":"","url":"https://api.github.com/users/mroth","html_url":"https://github.com/mroth","followers_url":"https://api.github.com/users/mroth/followers","following_url":"https://api.github.com/users/mroth/following{/other_user}","gists_url":"https://api.github.com/users/mroth/gists{/gist_id}","starred_url":"https://api.github.com/users/mroth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mroth/subscriptions","organizations_url":"https://api.github.com/users/mroth/orgs","repos_url":"https://api.github.com/users/mroth/repos","events_url":"https://api.github.com/users/mroth/events{/privacy}","received_events_url":"https://api.github.com/users/mroth/received_events","type":"User","site_admin":false},"repo":{"id":2499845,"name":"lolcommits","full_name":"mroth/lolcommits","owner":{"login":"mroth","id":40650,"avatar_url":"https://avatars.githubusercontent.com/u/40650?v=3","gravatar_id":"","url":"https://api.github.com/users/mroth","html_url":"https://github.com/mroth","followers_url":"https://api.github.com/users/mroth/followers","following_url":"https://api.github.com/users/mroth/following{/other_user}","gists_url":"https://api.github.com/users/mroth/gists{/gist_id}","starred_url":"https://api.github.com/users/mroth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mroth/subscriptions","organizations_url":"https://api.github.com/users/mroth/orgs","repos_url":"https://api.github.com/users/mroth/repos","events_url":"https://api.github.com/users/mroth/events{/privacy}","received_events_url":"https://api.github.com/users/mroth/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mroth/lolcommits","description":":camera: git-based selfies for software developers","fork":false,"url":"https://api.github.com/repos/mroth/lolcommits","forks_url":"https://api.github.com/repos/mroth/lolcommits/forks","keys_url":"https://api.github.com/repos/mroth/lolcommits/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mroth/lolcommits/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mroth/lolcommits/teams","hooks_url":"https://api.github.com/repos/mroth/lolcommits/hooks","issue_events_url":"https://api.github.com/repos/mroth/lolcommits/issues/events{/number}","events_url":"https://api.github.com/repos/mroth/lolcommits/events","assignees_url":"https://api.github.com/repos/mroth/lolcommits/assignees{/user}","branches_url":"https://api.github.com/repos/mroth/lolcommits/branches{/branch}","tags_url":"https://api.github.com/repos/mroth/lolcommits/tags","blobs_url":"https://api.github.com/repos/mroth/lolcommits/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mroth/lolcommits/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mroth/lolcommits/git/refs{/sha}","trees_url":"https://api.github.com/repos/mroth/lolcommits/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mroth/lolcommits/statuses/{sha}","languages_url":"https://api.github.com/repos/mroth/lolcommits/languages","stargazers_url":"https://api.github.com/repos/mroth/lolcommits/stargazers","contributors_url":"https://api.github.com/repos/mroth/lolcommits/contributors","subscribers_url":"https://api.github.com/repos/mroth/lolcommits/subscribers","subscription_url":"https://api.github.com/repos/mroth/lolcommits/subscription","commits_url":"https://api.github.com/repos/mroth/lolcommits/commits{/sha}","git_commits_url":"https://api.github.com/repos/mroth/lolcommits/git/commits{/sha}","comments_url":"https://api.github.com/repos/mroth/lolcommits/comments{/number}","issue_comment_url":"https://api.github.com/repos/mroth/lolcommits/issues/comments{/number}","contents_url":"https://api.github.com/repos/mroth/lolcommits/contents/{+path}","compare_url":"https://api.github.com/repos/mroth/lolcommits/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mroth/lolcommits/merges","archive_url":"https://api.github.com/repos/mroth/lolcommits/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mroth/lolcommits/downloads","issues_url":"https://api.github.com/repos/mroth/lolcommits/issues{/number}","pulls_url":"https://api.github.com/repos/mroth/lolcommits/pulls{/number}","milestones_url":"https://api.github.com/repos/mroth/lolcommits/milestones{/number}","notifications_url":"https://api.github.com/repos/mroth/lolcommits/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mroth/lolcommits/labels{/name}","releases_url":"https://api.github.com/repos/mroth/lolcommits/releases{/id}","created_at":"2011-10-02T15:25:44Z","updated_at":"2015-04-18T17:31:02Z","pushed_at":"2015-04-19T13:22:16Z","git_url":"git://github.com/mroth/lolcommits.git","ssh_url":"git@github.com:mroth/lolcommits.git","clone_url":"https://github.com/mroth/lolcommits.git","svn_url":"https://github.com/mroth/lolcommits","homepage":"https://lolcommits.github.io","size":5589,"stargazers_count":2825,"watchers_count":2825,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":198,"mirror_url":null,"open_issues_count":27,"forks":198,"open_issues":27,"watchers":2825,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mroth/lolcommits/pulls/276"},"html":{"href":"https://github.com/mroth/lolcommits/pull/276"},"issue":{"href":"https://api.github.com/repos/mroth/lolcommits/issues/276"},"comments":{"href":"https://api.github.com/repos/mroth/lolcommits/issues/276/comments"},"review_comments":{"href":"https://api.github.com/repos/mroth/lolcommits/pulls/276/comments"},"review_comment":{"href":"https://api.github.com/repos/mroth/lolcommits/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mroth/lolcommits/pulls/276/commits"},"statuses":{"href":"https://api.github.com/repos/mroth/lolcommits/statuses/cf7265743d36333b3fb427556b36973ed05d9564"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"matthutchinson","id":2095,"avatar_url":"https://avatars.githubusercontent.com/u/2095?v=3","gravatar_id":"","url":"https://api.github.com/users/matthutchinson","html_url":"https://github.com/matthutchinson","followers_url":"https://api.github.com/users/matthutchinson/followers","following_url":"https://api.github.com/users/matthutchinson/following{/other_user}","gists_url":"https://api.github.com/users/matthutchinson/gists{/gist_id}","starred_url":"https://api.github.com/users/matthutchinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthutchinson/subscriptions","organizations_url":"https://api.github.com/users/matthutchinson/orgs","repos_url":"https://api.github.com/users/matthutchinson/repos","events_url":"https://api.github.com/users/matthutchinson/events{/privacy}","received_events_url":"https://api.github.com/users/matthutchinson/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":18,"deletions":2,"changed_files":4}}