{"action":"created","issue":{"url":"https://api.github.com/repos/agnat/node_mdns/issues/115","labels_url":"https://api.github.com/repos/agnat/node_mdns/issues/115/labels{/name}","comments_url":"https://api.github.com/repos/agnat/node_mdns/issues/115/comments","events_url":"https://api.github.com/repos/agnat/node_mdns/issues/115/events","html_url":"https://github.com/agnat/node_mdns/pull/115","id":54425605,"number":115,"title":"Emit dns error thrown by native code","user":{"login":"achingbrain","id":665810,"avatar_url":"https://avatars.githubusercontent.com/u/665810?v=3","gravatar_id":"","url":"https://api.github.com/users/achingbrain","html_url":"https://github.com/achingbrain","followers_url":"https://api.github.com/users/achingbrain/followers","following_url":"https://api.github.com/users/achingbrain/following{/other_user}","gists_url":"https://api.github.com/users/achingbrain/gists{/gist_id}","starred_url":"https://api.github.com/users/achingbrain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/achingbrain/subscriptions","organizations_url":"https://api.github.com/users/achingbrain/orgs","repos_url":"https://api.github.com/users/achingbrain/repos","events_url":"https://api.github.com/users/achingbrain/events{/privacy}","received_events_url":"https://api.github.com/users/achingbrain/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-01-15T08:56:49Z","updated_at":"2015-01-29T02:14:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/agnat/node_mdns/pulls/115","html_url":"https://github.com/agnat/node_mdns/pull/115","diff_url":"https://github.com/agnat/node_mdns/pull/115.diff","patch_url":"https://github.com/agnat/node_mdns/pull/115.patch"},"body":"The native `dns_sd.DNSServicePRocessResult` method can [throw an error](https://github.com/agnat/node_mdns/blob/7832eecc07d49f49735c771b1e00e06e513d1067/src/dns_service_process_result.cpp#L26) if there's a DNS failure, resulting in an uncaught exception and your application going down, so this pull request wraps it in a try/catch block and gets the `Browser` object (extends `MDNSService`) to emit an error event instead.\r\n\r\nAlso includes a unit test.  Actually the `test_functional`/`simple browsing` test is failing at the moment but I figure better fixed in a different commit."},"comment":{"url":"https://api.github.com/repos/agnat/node_mdns/issues/comments/71957111","html_url":"https://github.com/agnat/node_mdns/pull/115#issuecomment-71957111","issue_url":"https://api.github.com/repos/agnat/node_mdns/issues/115","id":71957111,"user":{"login":"ronkorving","id":631240,"avatar_url":"https://avatars.githubusercontent.com/u/631240?v=3","gravatar_id":"","url":"https://api.github.com/users/ronkorving","html_url":"https://github.com/ronkorving","followers_url":"https://api.github.com/users/ronkorving/followers","following_url":"https://api.github.com/users/ronkorving/following{/other_user}","gists_url":"https://api.github.com/users/ronkorving/gists{/gist_id}","starred_url":"https://api.github.com/users/ronkorving/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ronkorving/subscriptions","organizations_url":"https://api.github.com/users/ronkorving/orgs","repos_url":"https://api.github.com/users/ronkorving/repos","events_url":"https://api.github.com/users/ronkorving/events{/privacy}","received_events_url":"https://api.github.com/users/ronkorving/received_events","type":"User","site_admin":false},"created_at":"2015-01-29T02:14:54Z","updated_at":"2015-01-29T02:14:54Z","body":"Looks good to me, thanks :)"}}