{"action":"opened","issue":{"url":"https://api.github.com/repos/hashicorp/raft/issues/68","labels_url":"https://api.github.com/repos/hashicorp/raft/issues/68/labels{/name}","comments_url":"https://api.github.com/repos/hashicorp/raft/issues/68/comments","events_url":"https://api.github.com/repos/hashicorp/raft/issues/68/events","html_url":"https://github.com/hashicorp/raft/issues/68","id":114361060,"number":68,"title":"Verify that the stop channel always gets closed when we remove a peer","user":{"login":"slackpad","id":673509,"avatar_url":"https://avatars.githubusercontent.com/u/673509?v=3","gravatar_id":"","url":"https://api.github.com/users/slackpad","html_url":"https://github.com/slackpad","followers_url":"https://api.github.com/users/slackpad/followers","following_url":"https://api.github.com/users/slackpad/following{/other_user}","gists_url":"https://api.github.com/users/slackpad/gists{/gist_id}","starred_url":"https://api.github.com/users/slackpad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slackpad/subscriptions","organizations_url":"https://api.github.com/users/slackpad/orgs","repos_url":"https://api.github.com/users/slackpad/repos","events_url":"https://api.github.com/users/slackpad/events{/privacy}","received_events_url":"https://api.github.com/users/slackpad/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2015-10-30T21:42:52Z","updated_at":"2015-10-30T21:42:52Z","closed_at":null,"body":"We were looking at `LogRemovePeer` and thought that there might be a case where the peers list doesn't have an entry for a peer so the current logic would skip closing the stop channel.\r\n\r\n@sean- attempted a fix in https://github.com/hashicorp/raft/pull/64 but it was failing tests and we weren't sure if this fix was actually necessary. Go through this code again and double check things are ok."}}