{"action":"created","comment":{"url":"https://api.github.com/repos/VoltDB/voltdb/pulls/comments/35358594","id":35358594,"diff_hunk":"@@ -178,8 +180,14 @@ public void deliver(VoltMessage message)\n             if (response.getHandle() != Long.MAX_VALUE) {\n                 m_maxSeenTxnId = Math.max(m_maxSeenTxnId, response.getHandle());\n             }\n-            m_maxSeenBinaryLogSequenceNumber = Math.max(m_maxSeenBinaryLogSequenceNumber, response.getBinaryLogSequenceNumber());\n-            m_maxSeenBinaryLogUniqueId = Math.max(m_maxSeenBinaryLogUniqueId, response.getBinaryLogUniqueId());\n+            if (response.getBinaryLogSequenceNumber() == 0) {","path":"src/frontend/org/voltdb/iv2/SpPromoteAlgo.java","position":22,"original_position":22,"commit_id":"9388dbd3c64af6674e790997cf4e9d78f46c4b9c","original_commit_id":"9388dbd3c64af6674e790997cf4e9d78f46c4b9c","user":{"login":"afrogers","id":4966215,"avatar_url":"https://avatars.githubusercontent.com/u/4966215?v=3","gravatar_id":"","url":"https://api.github.com/users/afrogers","html_url":"https://github.com/afrogers","followers_url":"https://api.github.com/users/afrogers/followers","following_url":"https://api.github.com/users/afrogers/following{/other_user}","gists_url":"https://api.github.com/users/afrogers/gists{/gist_id}","starred_url":"https://api.github.com/users/afrogers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afrogers/subscriptions","organizations_url":"https://api.github.com/users/afrogers/orgs","repos_url":"https://api.github.com/users/afrogers/repos","events_url":"https://api.github.com/users/afrogers/events{/privacy}","received_events_url":"https://api.github.com/users/afrogers/received_events","type":"User","site_admin":false},"body":"This check looks wrong. It think you mean `response.getSequence()`","created_at":"2015-07-23T19:01:35Z","updated_at":"2015-07-23T19:01:35Z","html_url":"https://github.com/VoltDB/voltdb/pull/2591#discussion_r35358594","pull_request_url":"https://api.github.com/repos/VoltDB/voltdb/pulls/2591","_links":{"self":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/comments/35358594"},"html":{"href":"https://github.com/VoltDB/voltdb/pull/2591#discussion_r35358594"},"pull_request":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/2591"}}},"pull_request":{"url":"https://api.github.com/repos/VoltDB/voltdb/pulls/2591","id":40690580,"html_url":"https://github.com/VoltDB/voltdb/pull/2591","diff_url":"https://github.com/VoltDB/voltdb/pull/2591.diff","patch_url":"https://github.com/VoltDB/voltdb/pull/2591.patch","issue_url":"https://api.github.com/repos/VoltDB/voltdb/issues/2591","number":2591,"state":"open","locked":false,"title":"ENG-8624: Only Ack DrIds that are globally committed by all replicas,…","user":{"login":"wweiss-voltdb","id":6462615,"avatar_url":"https://avatars.githubusercontent.com/u/6462615?v=3","gravatar_id":"","url":"https://api.github.com/users/wweiss-voltdb","html_url":"https://github.com/wweiss-voltdb","followers_url":"https://api.github.com/users/wweiss-voltdb/followers","following_url":"https://api.github.com/users/wweiss-voltdb/following{/other_user}","gists_url":"https://api.github.com/users/wweiss-voltdb/gists{/gist_id}","starred_url":"https://api.github.com/users/wweiss-voltdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wweiss-voltdb/subscriptions","organizations_url":"https://api.github.com/users/wweiss-voltdb/orgs","repos_url":"https://api.github.com/users/wweiss-voltdb/repos","events_url":"https://api.github.com/users/wweiss-voltdb/events{/privacy}","received_events_url":"https://api.github.com/users/wweiss-voltdb/received_events","type":"User","site_admin":false},"body":"… not just the local server","created_at":"2015-07-23T16:22:06Z","updated_at":"2015-07-23T19:01:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"662cd814314fd253a6af92caa0959662911c9711","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/VoltDB/voltdb/pulls/2591/commits","review_comments_url":"https://api.github.com/repos/VoltDB/voltdb/pulls/2591/comments","review_comment_url":"https://api.github.com/repos/VoltDB/voltdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/VoltDB/voltdb/issues/2591/comments","statuses_url":"https://api.github.com/repos/VoltDB/voltdb/statuses/9388dbd3c64af6674e790997cf4e9d78f46c4b9c","head":{"label":"VoltDB:ENG-8624-DistinguishLocallyAppliedDrIdInConsumer","ref":"ENG-8624-DistinguishLocallyAppliedDrIdInConsumer","sha":"9388dbd3c64af6674e790997cf4e9d78f46c4b9c","user":{"login":"VoltDB","id":703910,"avatar_url":"https://avatars.githubusercontent.com/u/703910?v=3","gravatar_id":"","url":"https://api.github.com/users/VoltDB","html_url":"https://github.com/VoltDB","followers_url":"https://api.github.com/users/VoltDB/followers","following_url":"https://api.github.com/users/VoltDB/following{/other_user}","gists_url":"https://api.github.com/users/VoltDB/gists{/gist_id}","starred_url":"https://api.github.com/users/VoltDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VoltDB/subscriptions","organizations_url":"https://api.github.com/users/VoltDB/orgs","repos_url":"https://api.github.com/users/VoltDB/repos","events_url":"https://api.github.com/users/VoltDB/events{/privacy}","received_events_url":"https://api.github.com/users/VoltDB/received_events","type":"Organization","site_admin":false},"repo":{"id":2445970,"name":"voltdb","full_name":"VoltDB/voltdb","owner":{"login":"VoltDB","id":703910,"avatar_url":"https://avatars.githubusercontent.com/u/703910?v=3","gravatar_id":"","url":"https://api.github.com/users/VoltDB","html_url":"https://github.com/VoltDB","followers_url":"https://api.github.com/users/VoltDB/followers","following_url":"https://api.github.com/users/VoltDB/following{/other_user}","gists_url":"https://api.github.com/users/VoltDB/gists{/gist_id}","starred_url":"https://api.github.com/users/VoltDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VoltDB/subscriptions","organizations_url":"https://api.github.com/users/VoltDB/orgs","repos_url":"https://api.github.com/users/VoltDB/repos","events_url":"https://api.github.com/users/VoltDB/events{/privacy}","received_events_url":"https://api.github.com/users/VoltDB/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/VoltDB/voltdb","description":"VoltDB","fork":false,"url":"https://api.github.com/repos/VoltDB/voltdb","forks_url":"https://api.github.com/repos/VoltDB/voltdb/forks","keys_url":"https://api.github.com/repos/VoltDB/voltdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VoltDB/voltdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VoltDB/voltdb/teams","hooks_url":"https://api.github.com/repos/VoltDB/voltdb/hooks","issue_events_url":"https://api.github.com/repos/VoltDB/voltdb/issues/events{/number}","events_url":"https://api.github.com/repos/VoltDB/voltdb/events","assignees_url":"https://api.github.com/repos/VoltDB/voltdb/assignees{/user}","branches_url":"https://api.github.com/repos/VoltDB/voltdb/branches{/branch}","tags_url":"https://api.github.com/repos/VoltDB/voltdb/tags","blobs_url":"https://api.github.com/repos/VoltDB/voltdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VoltDB/voltdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VoltDB/voltdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/VoltDB/voltdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VoltDB/voltdb/statuses/{sha}","languages_url":"https://api.github.com/repos/VoltDB/voltdb/languages","stargazers_url":"https://api.github.com/repos/VoltDB/voltdb/stargazers","contributors_url":"https://api.github.com/repos/VoltDB/voltdb/contributors","subscribers_url":"https://api.github.com/repos/VoltDB/voltdb/subscribers","subscription_url":"https://api.github.com/repos/VoltDB/voltdb/subscription","commits_url":"https://api.github.com/repos/VoltDB/voltdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/VoltDB/voltdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/VoltDB/voltdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/VoltDB/voltdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/VoltDB/voltdb/contents/{+path}","compare_url":"https://api.github.com/repos/VoltDB/voltdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VoltDB/voltdb/merges","archive_url":"https://api.github.com/repos/VoltDB/voltdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VoltDB/voltdb/downloads","issues_url":"https://api.github.com/repos/VoltDB/voltdb/issues{/number}","pulls_url":"https://api.github.com/repos/VoltDB/voltdb/pulls{/number}","milestones_url":"https://api.github.com/repos/VoltDB/voltdb/milestones{/number}","notifications_url":"https://api.github.com/repos/VoltDB/voltdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VoltDB/voltdb/labels{/name}","releases_url":"https://api.github.com/repos/VoltDB/voltdb/releases{/id}","created_at":"2011-09-23T18:46:12Z","updated_at":"2015-07-20T08:07:35Z","pushed_at":"2015-07-23T18:57:56Z","git_url":"git://github.com/VoltDB/voltdb.git","ssh_url":"git@github.com:VoltDB/voltdb.git","clone_url":"https://github.com/VoltDB/voltdb.git","svn_url":"https://github.com/VoltDB/voltdb","homepage":"http://community.voltdb.com/","size":733777,"stargazers_count":597,"watchers_count":597,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":177,"mirror_url":null,"open_issues_count":29,"forks":177,"open_issues":29,"watchers":597,"default_branch":"master"}},"base":{"label":"VoltDB:master","ref":"master","sha":"2f35d5a94ab1820896a2d37795e1d87243252b2a","user":{"login":"VoltDB","id":703910,"avatar_url":"https://avatars.githubusercontent.com/u/703910?v=3","gravatar_id":"","url":"https://api.github.com/users/VoltDB","html_url":"https://github.com/VoltDB","followers_url":"https://api.github.com/users/VoltDB/followers","following_url":"https://api.github.com/users/VoltDB/following{/other_user}","gists_url":"https://api.github.com/users/VoltDB/gists{/gist_id}","starred_url":"https://api.github.com/users/VoltDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VoltDB/subscriptions","organizations_url":"https://api.github.com/users/VoltDB/orgs","repos_url":"https://api.github.com/users/VoltDB/repos","events_url":"https://api.github.com/users/VoltDB/events{/privacy}","received_events_url":"https://api.github.com/users/VoltDB/received_events","type":"Organization","site_admin":false},"repo":{"id":2445970,"name":"voltdb","full_name":"VoltDB/voltdb","owner":{"login":"VoltDB","id":703910,"avatar_url":"https://avatars.githubusercontent.com/u/703910?v=3","gravatar_id":"","url":"https://api.github.com/users/VoltDB","html_url":"https://github.com/VoltDB","followers_url":"https://api.github.com/users/VoltDB/followers","following_url":"https://api.github.com/users/VoltDB/following{/other_user}","gists_url":"https://api.github.com/users/VoltDB/gists{/gist_id}","starred_url":"https://api.github.com/users/VoltDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VoltDB/subscriptions","organizations_url":"https://api.github.com/users/VoltDB/orgs","repos_url":"https://api.github.com/users/VoltDB/repos","events_url":"https://api.github.com/users/VoltDB/events{/privacy}","received_events_url":"https://api.github.com/users/VoltDB/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/VoltDB/voltdb","description":"VoltDB","fork":false,"url":"https://api.github.com/repos/VoltDB/voltdb","forks_url":"https://api.github.com/repos/VoltDB/voltdb/forks","keys_url":"https://api.github.com/repos/VoltDB/voltdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VoltDB/voltdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VoltDB/voltdb/teams","hooks_url":"https://api.github.com/repos/VoltDB/voltdb/hooks","issue_events_url":"https://api.github.com/repos/VoltDB/voltdb/issues/events{/number}","events_url":"https://api.github.com/repos/VoltDB/voltdb/events","assignees_url":"https://api.github.com/repos/VoltDB/voltdb/assignees{/user}","branches_url":"https://api.github.com/repos/VoltDB/voltdb/branches{/branch}","tags_url":"https://api.github.com/repos/VoltDB/voltdb/tags","blobs_url":"https://api.github.com/repos/VoltDB/voltdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VoltDB/voltdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VoltDB/voltdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/VoltDB/voltdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VoltDB/voltdb/statuses/{sha}","languages_url":"https://api.github.com/repos/VoltDB/voltdb/languages","stargazers_url":"https://api.github.com/repos/VoltDB/voltdb/stargazers","contributors_url":"https://api.github.com/repos/VoltDB/voltdb/contributors","subscribers_url":"https://api.github.com/repos/VoltDB/voltdb/subscribers","subscription_url":"https://api.github.com/repos/VoltDB/voltdb/subscription","commits_url":"https://api.github.com/repos/VoltDB/voltdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/VoltDB/voltdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/VoltDB/voltdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/VoltDB/voltdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/VoltDB/voltdb/contents/{+path}","compare_url":"https://api.github.com/repos/VoltDB/voltdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VoltDB/voltdb/merges","archive_url":"https://api.github.com/repos/VoltDB/voltdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VoltDB/voltdb/downloads","issues_url":"https://api.github.com/repos/VoltDB/voltdb/issues{/number}","pulls_url":"https://api.github.com/repos/VoltDB/voltdb/pulls{/number}","milestones_url":"https://api.github.com/repos/VoltDB/voltdb/milestones{/number}","notifications_url":"https://api.github.com/repos/VoltDB/voltdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VoltDB/voltdb/labels{/name}","releases_url":"https://api.github.com/repos/VoltDB/voltdb/releases{/id}","created_at":"2011-09-23T18:46:12Z","updated_at":"2015-07-20T08:07:35Z","pushed_at":"2015-07-23T18:57:56Z","git_url":"git://github.com/VoltDB/voltdb.git","ssh_url":"git@github.com:VoltDB/voltdb.git","clone_url":"https://github.com/VoltDB/voltdb.git","svn_url":"https://github.com/VoltDB/voltdb","homepage":"http://community.voltdb.com/","size":733777,"stargazers_count":597,"watchers_count":597,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":177,"mirror_url":null,"open_issues_count":29,"forks":177,"open_issues":29,"watchers":597,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/2591"},"html":{"href":"https://github.com/VoltDB/voltdb/pull/2591"},"issue":{"href":"https://api.github.com/repos/VoltDB/voltdb/issues/2591"},"comments":{"href":"https://api.github.com/repos/VoltDB/voltdb/issues/2591/comments"},"review_comments":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/2591/comments"},"review_comment":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/2591/commits"},"statuses":{"href":"https://api.github.com/repos/VoltDB/voltdb/statuses/9388dbd3c64af6674e790997cf4e9d78f46c4b9c"}}}}