{"action":"created","comment":{"url":"https://api.github.com/repos/juanignaciomolina/training/pulls/comments/27332116","id":27332116,"diff_hunk":"@@ -206,12 +198,12 @@ public void success(User user, Response response) {\n                 mPreferencesEditor.putString(Config.LOGIN_PASSWORD_KEY, mUser.getPassword());\n                 mPreferencesEditor.putString(Config.LOGIN_SESSION_KEY, mUser.getSessionToken());\n                 mPreferencesEditor.apply();\n-                showToast(\"User created\"); //TODO En lugar de mostrar el mensaje abrir la activity principal\n+                UiHelper.showToast(mContext, \"User created\"); //TODO En lugar de mostrar el mensaje abrir la activity principal","path":"app/src/main/java/ar/com/wolox/woloxtrainingmolina/activities/SignUpActivity.java","position":78,"original_position":78,"commit_id":"874d3e7d23bd59e697f67066796d919df5b70f69","original_commit_id":"874d3e7d23bd59e697f67066796d919df5b70f69","user":{"login":"nicomagni","id":494001,"avatar_url":"https://avatars.githubusercontent.com/u/494001?v=3","gravatar_id":"","url":"https://api.github.com/users/nicomagni","html_url":"https://github.com/nicomagni","followers_url":"https://api.github.com/users/nicomagni/followers","following_url":"https://api.github.com/users/nicomagni/following{/other_user}","gists_url":"https://api.github.com/users/nicomagni/gists{/gist_id}","starred_url":"https://api.github.com/users/nicomagni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicomagni/subscriptions","organizations_url":"https://api.github.com/users/nicomagni/orgs","repos_url":"https://api.github.com/users/nicomagni/repos","events_url":"https://api.github.com/users/nicomagni/events{/privacy}","received_events_url":"https://api.github.com/users/nicomagni/received_events","type":"User","site_admin":false},"body":"\"User Created\" mandalo al archivo de strings.","created_at":"2015-03-27T21:21:23Z","updated_at":"2015-03-27T21:21:23Z","html_url":"https://github.com/juanignaciomolina/training/pull/4#discussion_r27332116","pull_request_url":"https://api.github.com/repos/juanignaciomolina/training/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/juanignaciomolina/training/pulls/comments/27332116"},"html":{"href":"https://github.com/juanignaciomolina/training/pull/4#discussion_r27332116"},"pull_request":{"href":"https://api.github.com/repos/juanignaciomolina/training/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/juanignaciomolina/training/pulls/4","id":32141701,"html_url":"https://github.com/juanignaciomolina/training/pull/4","diff_url":"https://github.com/juanignaciomolina/training/pull/4.diff","patch_url":"https://github.com/juanignaciomolina/training/pull/4.patch","issue_url":"https://api.github.com/repos/juanignaciomolina/training/issues/4","number":4,"state":"open","locked":false,"title":"Main Activity Frontend","user":{"login":"juanignaciomolina","id":4109119,"avatar_url":"https://avatars.githubusercontent.com/u/4109119?v=3","gravatar_id":"","url":"https://api.github.com/users/juanignaciomolina","html_url":"https://github.com/juanignaciomolina","followers_url":"https://api.github.com/users/juanignaciomolina/followers","following_url":"https://api.github.com/users/juanignaciomolina/following{/other_user}","gists_url":"https://api.github.com/users/juanignaciomolina/gists{/gist_id}","starred_url":"https://api.github.com/users/juanignaciomolina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juanignaciomolina/subscriptions","organizations_url":"https://api.github.com/users/juanignaciomolina/orgs","repos_url":"https://api.github.com/users/juanignaciomolina/repos","events_url":"https://api.github.com/users/juanignaciomolina/events{/privacy}","received_events_url":"https://api.github.com/users/juanignaciomolina/received_events","type":"User","site_admin":false},"body":"# Main Activity Frontend\r\n### Implementación del Frontend de la Main Activity de la app\r\n\r\n![fragmentnews-2015-03-27-171844](https://cloud.githubusercontent.com/assets/4109119/6876362/8eaf8036-d4a5-11e4-893f-1203eb5c5995.png)\r\n![fragmentprofile-2015-03-27-171923](https://cloud.githubusercontent.com/assets/4109119/6876363/8eb2c6f6-d4a5-11e4-8fa4-6a97dd6a0792.png)\r\n\r\n#### Funcionalidades\r\n* Frontend de la activity principal de la app.\r\n* Provee el soporte a los fragments de la app (en principio News y Profile) con el patrón de diseño de SwipeView.\r\n* Cumple totalmente con los requerimientos del documento de diseño\r\n\r\n###### Cards de Trello asociadas a este pull request\r\n* [16] https://trello.com/c/luDD8Tvp/16-news\r\n* [17] https://trello.com/c/wlefyOuA/17-profile\r\n\r\n##### Características técnicas destacadas\r\n* Se utilizó la Toolbar de la app en lugar de una ActionBar\r\n* Se utilizó el widget de Google SlidingTabLayout, la forma más moderna de usar tabs. Además se modifico el comportamiento del mismo para admitir imágenes dinámicas dentro de las tabs.\r\n* En dispositivos Lollipop en adelante se usa el atributo elevation, mientras que en dispositivos más viejos se usa una imagen que simula la elevation sin romper la retrocompatibilidad.\r\n* Durante la implementación de este Pull Request se creó una nueva clase UiHelper que simplifica tareas como mostrar toast dialogs y preparar toolbars.\r\n\r\n##### Test plan\r\n* El cambio de tabs se puede hacer haciendo click en cada tab o haciendo un swipe hacia los costados\r\n* En dispositivos Lollipop en adelante las sombras se hacen con elevation\r\n* En dispositivos pre Lollipop las sombras se hacen con imagenes\r\n\r\n##### Notas adicionales\r\n* El layout fue diseñado para utilizar en modo *portrait*","created_at":"2015-03-27T20:23:29Z","updated_at":"2015-03-27T21:21:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eaf7813d2824aa6fa47f36790cf4094cab9fb6db","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/juanignaciomolina/training/pulls/4/commits","review_comments_url":"https://api.github.com/repos/juanignaciomolina/training/pulls/4/comments","review_comment_url":"https://api.github.com/repos/juanignaciomolina/training/pulls/comments{/number}","comments_url":"https://api.github.com/repos/juanignaciomolina/training/issues/4/comments","statuses_url":"https://api.github.com/repos/juanignaciomolina/training/statuses/874d3e7d23bd59e697f67066796d919df5b70f69","head":{"label":"juanignaciomolina:news_frontend","ref":"news_frontend","sha":"874d3e7d23bd59e697f67066796d919df5b70f69","user":{"login":"juanignaciomolina","id":4109119,"avatar_url":"https://avatars.githubusercontent.com/u/4109119?v=3","gravatar_id":"","url":"https://api.github.com/users/juanignaciomolina","html_url":"https://github.com/juanignaciomolina","followers_url":"https://api.github.com/users/juanignaciomolina/followers","following_url":"https://api.github.com/users/juanignaciomolina/following{/other_user}","gists_url":"https://api.github.com/users/juanignaciomolina/gists{/gist_id}","starred_url":"https://api.github.com/users/juanignaciomolina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juanignaciomolina/subscriptions","organizations_url":"https://api.github.com/users/juanignaciomolina/orgs","repos_url":"https://api.github.com/users/juanignaciomolina/repos","events_url":"https://api.github.com/users/juanignaciomolina/events{/privacy}","received_events_url":"https://api.github.com/users/juanignaciomolina/received_events","type":"User","site_admin":false},"repo":{"id":32464594,"name":"training","full_name":"juanignaciomolina/training","owner":{"login":"juanignaciomolina","id":4109119,"avatar_url":"https://avatars.githubusercontent.com/u/4109119?v=3","gravatar_id":"","url":"https://api.github.com/users/juanignaciomolina","html_url":"https://github.com/juanignaciomolina","followers_url":"https://api.github.com/users/juanignaciomolina/followers","following_url":"https://api.github.com/users/juanignaciomolina/following{/other_user}","gists_url":"https://api.github.com/users/juanignaciomolina/gists{/gist_id}","starred_url":"https://api.github.com/users/juanignaciomolina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juanignaciomolina/subscriptions","organizations_url":"https://api.github.com/users/juanignaciomolina/orgs","repos_url":"https://api.github.com/users/juanignaciomolina/repos","events_url":"https://api.github.com/users/juanignaciomolina/events{/privacy}","received_events_url":"https://api.github.com/users/juanignaciomolina/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/juanignaciomolina/training","description":"Wolox training app","fork":false,"url":"https://api.github.com/repos/juanignaciomolina/training","forks_url":"https://api.github.com/repos/juanignaciomolina/training/forks","keys_url":"https://api.github.com/repos/juanignaciomolina/training/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juanignaciomolina/training/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juanignaciomolina/training/teams","hooks_url":"https://api.github.com/repos/juanignaciomolina/training/hooks","issue_events_url":"https://api.github.com/repos/juanignaciomolina/training/issues/events{/number}","events_url":"https://api.github.com/repos/juanignaciomolina/training/events","assignees_url":"https://api.github.com/repos/juanignaciomolina/training/assignees{/user}","branches_url":"https://api.github.com/repos/juanignaciomolina/training/branches{/branch}","tags_url":"https://api.github.com/repos/juanignaciomolina/training/tags","blobs_url":"https://api.github.com/repos/juanignaciomolina/training/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juanignaciomolina/training/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juanignaciomolina/training/git/refs{/sha}","trees_url":"https://api.github.com/repos/juanignaciomolina/training/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juanignaciomolina/training/statuses/{sha}","languages_url":"https://api.github.com/repos/juanignaciomolina/training/languages","stargazers_url":"https://api.github.com/repos/juanignaciomolina/training/stargazers","contributors_url":"https://api.github.com/repos/juanignaciomolina/training/contributors","subscribers_url":"https://api.github.com/repos/juanignaciomolina/training/subscribers","subscription_url":"https://api.github.com/repos/juanignaciomolina/training/subscription","commits_url":"https://api.github.com/repos/juanignaciomolina/training/commits{/sha}","git_commits_url":"https://api.github.com/repos/juanignaciomolina/training/git/commits{/sha}","comments_url":"https://api.github.com/repos/juanignaciomolina/training/comments{/number}","issue_comment_url":"https://api.github.com/repos/juanignaciomolina/training/issues/comments{/number}","contents_url":"https://api.github.com/repos/juanignaciomolina/training/contents/{+path}","compare_url":"https://api.github.com/repos/juanignaciomolina/training/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juanignaciomolina/training/merges","archive_url":"https://api.github.com/repos/juanignaciomolina/training/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juanignaciomolina/training/downloads","issues_url":"https://api.github.com/repos/juanignaciomolina/training/issues{/number}","pulls_url":"https://api.github.com/repos/juanignaciomolina/training/pulls{/number}","milestones_url":"https://api.github.com/repos/juanignaciomolina/training/milestones{/number}","notifications_url":"https://api.github.com/repos/juanignaciomolina/training/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juanignaciomolina/training/labels{/name}","releases_url":"https://api.github.com/repos/juanignaciomolina/training/releases{/id}","created_at":"2015-03-18T14:44:09Z","updated_at":"2015-03-18T14:44:09Z","pushed_at":"2015-03-27T21:06:54Z","git_url":"git://github.com/juanignaciomolina/training.git","ssh_url":"git@github.com:juanignaciomolina/training.git","clone_url":"https://github.com/juanignaciomolina/training.git","svn_url":"https://github.com/juanignaciomolina/training","homepage":null,"size":5312,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"juanignaciomolina:development","ref":"development","sha":"8384179f552abd56998697c214419776aee68584","user":{"login":"juanignaciomolina","id":4109119,"avatar_url":"https://avatars.githubusercontent.com/u/4109119?v=3","gravatar_id":"","url":"https://api.github.com/users/juanignaciomolina","html_url":"https://github.com/juanignaciomolina","followers_url":"https://api.github.com/users/juanignaciomolina/followers","following_url":"https://api.github.com/users/juanignaciomolina/following{/other_user}","gists_url":"https://api.github.com/users/juanignaciomolina/gists{/gist_id}","starred_url":"https://api.github.com/users/juanignaciomolina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juanignaciomolina/subscriptions","organizations_url":"https://api.github.com/users/juanignaciomolina/orgs","repos_url":"https://api.github.com/users/juanignaciomolina/repos","events_url":"https://api.github.com/users/juanignaciomolina/events{/privacy}","received_events_url":"https://api.github.com/users/juanignaciomolina/received_events","type":"User","site_admin":false},"repo":{"id":32464594,"name":"training","full_name":"juanignaciomolina/training","owner":{"login":"juanignaciomolina","id":4109119,"avatar_url":"https://avatars.githubusercontent.com/u/4109119?v=3","gravatar_id":"","url":"https://api.github.com/users/juanignaciomolina","html_url":"https://github.com/juanignaciomolina","followers_url":"https://api.github.com/users/juanignaciomolina/followers","following_url":"https://api.github.com/users/juanignaciomolina/following{/other_user}","gists_url":"https://api.github.com/users/juanignaciomolina/gists{/gist_id}","starred_url":"https://api.github.com/users/juanignaciomolina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juanignaciomolina/subscriptions","organizations_url":"https://api.github.com/users/juanignaciomolina/orgs","repos_url":"https://api.github.com/users/juanignaciomolina/repos","events_url":"https://api.github.com/users/juanignaciomolina/events{/privacy}","received_events_url":"https://api.github.com/users/juanignaciomolina/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/juanignaciomolina/training","description":"Wolox training app","fork":false,"url":"https://api.github.com/repos/juanignaciomolina/training","forks_url":"https://api.github.com/repos/juanignaciomolina/training/forks","keys_url":"https://api.github.com/repos/juanignaciomolina/training/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juanignaciomolina/training/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juanignaciomolina/training/teams","hooks_url":"https://api.github.com/repos/juanignaciomolina/training/hooks","issue_events_url":"https://api.github.com/repos/juanignaciomolina/training/issues/events{/number}","events_url":"https://api.github.com/repos/juanignaciomolina/training/events","assignees_url":"https://api.github.com/repos/juanignaciomolina/training/assignees{/user}","branches_url":"https://api.github.com/repos/juanignaciomolina/training/branches{/branch}","tags_url":"https://api.github.com/repos/juanignaciomolina/training/tags","blobs_url":"https://api.github.com/repos/juanignaciomolina/training/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juanignaciomolina/training/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juanignaciomolina/training/git/refs{/sha}","trees_url":"https://api.github.com/repos/juanignaciomolina/training/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juanignaciomolina/training/statuses/{sha}","languages_url":"https://api.github.com/repos/juanignaciomolina/training/languages","stargazers_url":"https://api.github.com/repos/juanignaciomolina/training/stargazers","contributors_url":"https://api.github.com/repos/juanignaciomolina/training/contributors","subscribers_url":"https://api.github.com/repos/juanignaciomolina/training/subscribers","subscription_url":"https://api.github.com/repos/juanignaciomolina/training/subscription","commits_url":"https://api.github.com/repos/juanignaciomolina/training/commits{/sha}","git_commits_url":"https://api.github.com/repos/juanignaciomolina/training/git/commits{/sha}","comments_url":"https://api.github.com/repos/juanignaciomolina/training/comments{/number}","issue_comment_url":"https://api.github.com/repos/juanignaciomolina/training/issues/comments{/number}","contents_url":"https://api.github.com/repos/juanignaciomolina/training/contents/{+path}","compare_url":"https://api.github.com/repos/juanignaciomolina/training/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juanignaciomolina/training/merges","archive_url":"https://api.github.com/repos/juanignaciomolina/training/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juanignaciomolina/training/downloads","issues_url":"https://api.github.com/repos/juanignaciomolina/training/issues{/number}","pulls_url":"https://api.github.com/repos/juanignaciomolina/training/pulls{/number}","milestones_url":"https://api.github.com/repos/juanignaciomolina/training/milestones{/number}","notifications_url":"https://api.github.com/repos/juanignaciomolina/training/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juanignaciomolina/training/labels{/name}","releases_url":"https://api.github.com/repos/juanignaciomolina/training/releases{/id}","created_at":"2015-03-18T14:44:09Z","updated_at":"2015-03-18T14:44:09Z","pushed_at":"2015-03-27T21:06:54Z","git_url":"git://github.com/juanignaciomolina/training.git","ssh_url":"git@github.com:juanignaciomolina/training.git","clone_url":"https://github.com/juanignaciomolina/training.git","svn_url":"https://github.com/juanignaciomolina/training","homepage":null,"size":5312,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/juanignaciomolina/training/pulls/4"},"html":{"href":"https://github.com/juanignaciomolina/training/pull/4"},"issue":{"href":"https://api.github.com/repos/juanignaciomolina/training/issues/4"},"comments":{"href":"https://api.github.com/repos/juanignaciomolina/training/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/juanignaciomolina/training/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/juanignaciomolina/training/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/juanignaciomolina/training/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/juanignaciomolina/training/statuses/874d3e7d23bd59e697f67066796d919df5b70f69"}}}}