{"action":"created","comment":{"url":"https://api.github.com/repos/thlorenz/proxyquireify/pulls/comments/35060253","id":35060253,"diff_hunk":"@@ -15,17 +14,54 @@ function run(name) {\n     .require(require.resolve('../..'), { expose: 'proxyquireify' })\n     .require(require.resolve('./' + name), { entry: true })\n     .bundle()\n-    .on('error',  function error(err) { console.error(err); process.exit(1); })\n+    .on('error', function error(err) { cb(err); })","path":"test/clientside/run.js","position":15,"original_position":15,"commit_id":"2a4b43e8fbca3aa00af22f7a478b29acae95864f","original_commit_id":"2a4b43e8fbca3aa00af22f7a478b29acae95864f","user":{"login":"thlorenz","id":192891,"avatar_url":"https://avatars.githubusercontent.com/u/192891?v=3","gravatar_id":"","url":"https://api.github.com/users/thlorenz","html_url":"https://github.com/thlorenz","followers_url":"https://api.github.com/users/thlorenz/followers","following_url":"https://api.github.com/users/thlorenz/following{/other_user}","gists_url":"https://api.github.com/users/thlorenz/gists{/gist_id}","starred_url":"https://api.github.com/users/thlorenz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thlorenz/subscriptions","organizations_url":"https://api.github.com/users/thlorenz/orgs","repos_url":"https://api.github.com/users/thlorenz/repos","events_url":"https://api.github.com/users/thlorenz/events{/privacy}","received_events_url":"https://api.github.com/users/thlorenz/received_events","type":"User","site_admin":false},"body":"Here you could just do ` .on('error', cb)` instead.","created_at":"2015-07-21T00:38:33Z","updated_at":"2015-07-21T00:38:33Z","html_url":"https://github.com/thlorenz/proxyquireify/pull/39#discussion_r35060253","pull_request_url":"https://api.github.com/repos/thlorenz/proxyquireify/pulls/39","_links":{"self":{"href":"https://api.github.com/repos/thlorenz/proxyquireify/pulls/comments/35060253"},"html":{"href":"https://github.com/thlorenz/proxyquireify/pull/39#discussion_r35060253"},"pull_request":{"href":"https://api.github.com/repos/thlorenz/proxyquireify/pulls/39"}}},"pull_request":{"url":"https://api.github.com/repos/thlorenz/proxyquireify/pulls/39","id":40322795,"html_url":"https://github.com/thlorenz/proxyquireify/pull/39","diff_url":"https://github.com/thlorenz/proxyquireify/pull/39.diff","patch_url":"https://github.com/thlorenz/proxyquireify/pull/39.patch","issue_url":"https://api.github.com/repos/thlorenz/proxyquireify/issues/39","number":39,"state":"open","locked":false,"title":"Do not execute required mock","user":{"login":"royriojas","id":131290,"avatar_url":"https://avatars.githubusercontent.com/u/131290?v=3","gravatar_id":"","url":"https://api.github.com/users/royriojas","html_url":"https://github.com/royriojas","followers_url":"https://api.github.com/users/royriojas/followers","following_url":"https://api.github.com/users/royriojas/following{/other_user}","gists_url":"https://api.github.com/users/royriojas/gists{/gist_id}","starred_url":"https://api.github.com/users/royriojas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/royriojas/subscriptions","organizations_url":"https://api.github.com/users/royriojas/orgs","repos_url":"https://api.github.com/users/royriojas/repos","events_url":"https://api.github.com/users/royriojas/events{/privacy}","received_events_url":"https://api.github.com/users/royriojas/received_events","type":"User","site_admin":false},"body":"Hi guys this is the improvement proposed as part of https://github.com/thlorenz/proxyquireify/issues/38\r\n\r\nCouple of notes.\r\n\r\n- the magic just wraps the call to require with an anonymous function. Since it is not executed it prevents double calls to require that were happening before.\r\n- the tests were consistently failing, some sort of race condition maybe. I just solved it splitting the problematic test into its own module and launching it after the other tests. Would be really nice to figure it out what went wrong, but at least this helps pass the tests for now ","created_at":"2015-07-20T04:21:22Z","updated_at":"2015-07-21T00:38:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"acbc773c22362a76501844182c55642301a79ac5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/thlorenz/proxyquireify/pulls/39/commits","review_comments_url":"https://api.github.com/repos/thlorenz/proxyquireify/pulls/39/comments","review_comment_url":"https://api.github.com/repos/thlorenz/proxyquireify/pulls/comments{/number}","comments_url":"https://api.github.com/repos/thlorenz/proxyquireify/issues/39/comments","statuses_url":"https://api.github.com/repos/thlorenz/proxyquireify/statuses/2a4b43e8fbca3aa00af22f7a478b29acae95864f","head":{"label":"royriojas:do-not-execute-required-mock","ref":"do-not-execute-required-mock","sha":"2a4b43e8fbca3aa00af22f7a478b29acae95864f","user":{"login":"royriojas","id":131290,"avatar_url":"https://avatars.githubusercontent.com/u/131290?v=3","gravatar_id":"","url":"https://api.github.com/users/royriojas","html_url":"https://github.com/royriojas","followers_url":"https://api.github.com/users/royriojas/followers","following_url":"https://api.github.com/users/royriojas/following{/other_user}","gists_url":"https://api.github.com/users/royriojas/gists{/gist_id}","starred_url":"https://api.github.com/users/royriojas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/royriojas/subscriptions","organizations_url":"https://api.github.com/users/royriojas/orgs","repos_url":"https://api.github.com/users/royriojas/repos","events_url":"https://api.github.com/users/royriojas/events{/privacy}","received_events_url":"https://api.github.com/users/royriojas/received_events","type":"User","site_admin":false},"repo":{"id":39362754,"name":"proxyquireify","full_name":"royriojas/proxyquireify","owner":{"login":"royriojas","id":131290,"avatar_url":"https://avatars.githubusercontent.com/u/131290?v=3","gravatar_id":"","url":"https://api.github.com/users/royriojas","html_url":"https://github.com/royriojas","followers_url":"https://api.github.com/users/royriojas/followers","following_url":"https://api.github.com/users/royriojas/following{/other_user}","gists_url":"https://api.github.com/users/royriojas/gists{/gist_id}","starred_url":"https://api.github.com/users/royriojas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/royriojas/subscriptions","organizations_url":"https://api.github.com/users/royriojas/orgs","repos_url":"https://api.github.com/users/royriojas/repos","events_url":"https://api.github.com/users/royriojas/events{/privacy}","received_events_url":"https://api.github.com/users/royriojas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/royriojas/proxyquireify","description":"browserify v2 version of proxyquire. Mocks out browserify's require to allow stubbing out dependencies while testing.","fork":true,"url":"https://api.github.com/repos/royriojas/proxyquireify","forks_url":"https://api.github.com/repos/royriojas/proxyquireify/forks","keys_url":"https://api.github.com/repos/royriojas/proxyquireify/keys{/key_id}","collaborators_url":"https://api.github.com/repos/royriojas/proxyquireify/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/royriojas/proxyquireify/teams","hooks_url":"https://api.github.com/repos/royriojas/proxyquireify/hooks","issue_events_url":"https://api.github.com/repos/royriojas/proxyquireify/issues/events{/number}","events_url":"https://api.github.com/repos/royriojas/proxyquireify/events","assignees_url":"https://api.github.com/repos/royriojas/proxyquireify/assignees{/user}","branches_url":"https://api.github.com/repos/royriojas/proxyquireify/branches{/branch}","tags_url":"https://api.github.com/repos/royriojas/proxyquireify/tags","blobs_url":"https://api.github.com/repos/royriojas/proxyquireify/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/royriojas/proxyquireify/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/royriojas/proxyquireify/git/refs{/sha}","trees_url":"https://api.github.com/repos/royriojas/proxyquireify/git/trees{/sha}","statuses_url":"https://api.github.com/repos/royriojas/proxyquireify/statuses/{sha}","languages_url":"https://api.github.com/repos/royriojas/proxyquireify/languages","stargazers_url":"https://api.github.com/repos/royriojas/proxyquireify/stargazers","contributors_url":"https://api.github.com/repos/royriojas/proxyquireify/contributors","subscribers_url":"https://api.github.com/repos/royriojas/proxyquireify/subscribers","subscription_url":"https://api.github.com/repos/royriojas/proxyquireify/subscription","commits_url":"https://api.github.com/repos/royriojas/proxyquireify/commits{/sha}","git_commits_url":"https://api.github.com/repos/royriojas/proxyquireify/git/commits{/sha}","comments_url":"https://api.github.com/repos/royriojas/proxyquireify/comments{/number}","issue_comment_url":"https://api.github.com/repos/royriojas/proxyquireify/issues/comments{/number}","contents_url":"https://api.github.com/repos/royriojas/proxyquireify/contents/{+path}","compare_url":"https://api.github.com/repos/royriojas/proxyquireify/compare/{base}...{head}","merges_url":"https://api.github.com/repos/royriojas/proxyquireify/merges","archive_url":"https://api.github.com/repos/royriojas/proxyquireify/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/royriojas/proxyquireify/downloads","issues_url":"https://api.github.com/repos/royriojas/proxyquireify/issues{/number}","pulls_url":"https://api.github.com/repos/royriojas/proxyquireify/pulls{/number}","milestones_url":"https://api.github.com/repos/royriojas/proxyquireify/milestones{/number}","notifications_url":"https://api.github.com/repos/royriojas/proxyquireify/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/royriojas/proxyquireify/labels{/name}","releases_url":"https://api.github.com/repos/royriojas/proxyquireify/releases{/id}","created_at":"2015-07-20T04:12:55Z","updated_at":"2015-07-20T04:12:55Z","pushed_at":"2015-07-20T22:54:51Z","git_url":"git://github.com/royriojas/proxyquireify.git","ssh_url":"git@github.com:royriojas/proxyquireify.git","clone_url":"https://github.com/royriojas/proxyquireify.git","svn_url":"https://github.com/royriojas/proxyquireify","homepage":"","size":163,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"thlorenz:master","ref":"master","sha":"141633d38448e067fa5a4f99a965edc4e7e87d7e","user":{"login":"thlorenz","id":192891,"avatar_url":"https://avatars.githubusercontent.com/u/192891?v=3","gravatar_id":"","url":"https://api.github.com/users/thlorenz","html_url":"https://github.com/thlorenz","followers_url":"https://api.github.com/users/thlorenz/followers","following_url":"https://api.github.com/users/thlorenz/following{/other_user}","gists_url":"https://api.github.com/users/thlorenz/gists{/gist_id}","starred_url":"https://api.github.com/users/thlorenz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thlorenz/subscriptions","organizations_url":"https://api.github.com/users/thlorenz/orgs","repos_url":"https://api.github.com/users/thlorenz/repos","events_url":"https://api.github.com/users/thlorenz/events{/privacy}","received_events_url":"https://api.github.com/users/thlorenz/received_events","type":"User","site_admin":false},"repo":{"id":9029977,"name":"proxyquireify","full_name":"thlorenz/proxyquireify","owner":{"login":"thlorenz","id":192891,"avatar_url":"https://avatars.githubusercontent.com/u/192891?v=3","gravatar_id":"","url":"https://api.github.com/users/thlorenz","html_url":"https://github.com/thlorenz","followers_url":"https://api.github.com/users/thlorenz/followers","following_url":"https://api.github.com/users/thlorenz/following{/other_user}","gists_url":"https://api.github.com/users/thlorenz/gists{/gist_id}","starred_url":"https://api.github.com/users/thlorenz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thlorenz/subscriptions","organizations_url":"https://api.github.com/users/thlorenz/orgs","repos_url":"https://api.github.com/users/thlorenz/repos","events_url":"https://api.github.com/users/thlorenz/events{/privacy}","received_events_url":"https://api.github.com/users/thlorenz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/thlorenz/proxyquireify","description":"browserify v2 version of proxyquire. Mocks out browserify's require to allow stubbing out dependencies while testing.","fork":false,"url":"https://api.github.com/repos/thlorenz/proxyquireify","forks_url":"https://api.github.com/repos/thlorenz/proxyquireify/forks","keys_url":"https://api.github.com/repos/thlorenz/proxyquireify/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thlorenz/proxyquireify/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thlorenz/proxyquireify/teams","hooks_url":"https://api.github.com/repos/thlorenz/proxyquireify/hooks","issue_events_url":"https://api.github.com/repos/thlorenz/proxyquireify/issues/events{/number}","events_url":"https://api.github.com/repos/thlorenz/proxyquireify/events","assignees_url":"https://api.github.com/repos/thlorenz/proxyquireify/assignees{/user}","branches_url":"https://api.github.com/repos/thlorenz/proxyquireify/branches{/branch}","tags_url":"https://api.github.com/repos/thlorenz/proxyquireify/tags","blobs_url":"https://api.github.com/repos/thlorenz/proxyquireify/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thlorenz/proxyquireify/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thlorenz/proxyquireify/git/refs{/sha}","trees_url":"https://api.github.com/repos/thlorenz/proxyquireify/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thlorenz/proxyquireify/statuses/{sha}","languages_url":"https://api.github.com/repos/thlorenz/proxyquireify/languages","stargazers_url":"https://api.github.com/repos/thlorenz/proxyquireify/stargazers","contributors_url":"https://api.github.com/repos/thlorenz/proxyquireify/contributors","subscribers_url":"https://api.github.com/repos/thlorenz/proxyquireify/subscribers","subscription_url":"https://api.github.com/repos/thlorenz/proxyquireify/subscription","commits_url":"https://api.github.com/repos/thlorenz/proxyquireify/commits{/sha}","git_commits_url":"https://api.github.com/repos/thlorenz/proxyquireify/git/commits{/sha}","comments_url":"https://api.github.com/repos/thlorenz/proxyquireify/comments{/number}","issue_comment_url":"https://api.github.com/repos/thlorenz/proxyquireify/issues/comments{/number}","contents_url":"https://api.github.com/repos/thlorenz/proxyquireify/contents/{+path}","compare_url":"https://api.github.com/repos/thlorenz/proxyquireify/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thlorenz/proxyquireify/merges","archive_url":"https://api.github.com/repos/thlorenz/proxyquireify/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thlorenz/proxyquireify/downloads","issues_url":"https://api.github.com/repos/thlorenz/proxyquireify/issues{/number}","pulls_url":"https://api.github.com/repos/thlorenz/proxyquireify/pulls{/number}","milestones_url":"https://api.github.com/repos/thlorenz/proxyquireify/milestones{/number}","notifications_url":"https://api.github.com/repos/thlorenz/proxyquireify/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thlorenz/proxyquireify/labels{/name}","releases_url":"https://api.github.com/repos/thlorenz/proxyquireify/releases{/id}","created_at":"2013-03-26T12:43:18Z","updated_at":"2015-07-20T04:44:12Z","pushed_at":"2015-07-20T22:54:51Z","git_url":"git://github.com/thlorenz/proxyquireify.git","ssh_url":"git@github.com:thlorenz/proxyquireify.git","clone_url":"https://github.com/thlorenz/proxyquireify.git","svn_url":"https://github.com/thlorenz/proxyquireify","homepage":"","size":603,"stargazers_count":92,"watchers_count":92,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":3,"forks":17,"open_issues":3,"watchers":92,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/thlorenz/proxyquireify/pulls/39"},"html":{"href":"https://github.com/thlorenz/proxyquireify/pull/39"},"issue":{"href":"https://api.github.com/repos/thlorenz/proxyquireify/issues/39"},"comments":{"href":"https://api.github.com/repos/thlorenz/proxyquireify/issues/39/comments"},"review_comments":{"href":"https://api.github.com/repos/thlorenz/proxyquireify/pulls/39/comments"},"review_comment":{"href":"https://api.github.com/repos/thlorenz/proxyquireify/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/thlorenz/proxyquireify/pulls/39/commits"},"statuses":{"href":"https://api.github.com/repos/thlorenz/proxyquireify/statuses/2a4b43e8fbca3aa00af22f7a478b29acae95864f"}}}}