{"action":"closed","number":1912,"pull_request":{"url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/pulls/1912","id":26611195,"html_url":"https://github.com/honestbleeps/Reddit-Enhancement-Suite/pull/1912","diff_url":"https://github.com/honestbleeps/Reddit-Enhancement-Suite/pull/1912.diff","patch_url":"https://github.com/honestbleeps/Reddit-Enhancement-Suite/pull/1912.patch","issue_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/issues/1912","number":1912,"state":"closed","locked":false,"title":"Replace repeated code with RESUtils.getCacheable","user":{"login":"erikdesjardins","id":7673145,"avatar_url":"https://avatars.githubusercontent.com/u/7673145?v=3","gravatar_id":"","url":"https://api.github.com/users/erikdesjardins","html_url":"https://github.com/erikdesjardins","followers_url":"https://api.github.com/users/erikdesjardins/followers","following_url":"https://api.github.com/users/erikdesjardins/following{/other_user}","gists_url":"https://api.github.com/users/erikdesjardins/gists{/gist_id}","starred_url":"https://api.github.com/users/erikdesjardins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikdesjardins/subscriptions","organizations_url":"https://api.github.com/users/erikdesjardins/orgs","repos_url":"https://api.github.com/users/erikdesjardins/repos","events_url":"https://api.github.com/users/erikdesjardins/events{/privacy}","received_events_url":"https://api.github.com/users/erikdesjardins/received_events","type":"User","site_admin":false},"body":"This was only repeated three times, so it might not be worth having its own function.\r\n\r\n~~Not sure about `getCacheable` or `maxAge`. (suggestions for better names?)~~\r\n\r\nThe idea behind splitting the callback into `callback` and `handleData` is to save a tiny bit on storage space (we don't have to store the whole response), and for a tiny bit of performance when using the cache (we don't have to parse it again).","created_at":"2014-12-27T05:01:59Z","updated_at":"2015-02-22T02:07:02Z","closed_at":"2015-02-22T02:07:02Z","merged_at":"2015-02-22T02:07:02Z","merge_commit_sha":"e9c7b52f5b356bd04c9c8469f97be3510e61aecc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/pulls/1912/commits","review_comments_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/pulls/1912/comments","review_comment_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/pulls/comments/{number}","comments_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/issues/1912/comments","statuses_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/statuses/f953444b3ea91aa728d56febfd6ec1ecdacebe45","head":{"label":"erikdesjardins:get-cacheable","ref":"get-cacheable","sha":"f953444b3ea91aa728d56febfd6ec1ecdacebe45","user":{"login":"erikdesjardins","id":7673145,"avatar_url":"https://avatars.githubusercontent.com/u/7673145?v=3","gravatar_id":"","url":"https://api.github.com/users/erikdesjardins","html_url":"https://github.com/erikdesjardins","followers_url":"https://api.github.com/users/erikdesjardins/followers","following_url":"https://api.github.com/users/erikdesjardins/following{/other_user}","gists_url":"https://api.github.com/users/erikdesjardins/gists{/gist_id}","starred_url":"https://api.github.com/users/erikdesjardins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikdesjardins/subscriptions","organizations_url":"https://api.github.com/users/erikdesjardins/orgs","repos_url":"https://api.github.com/users/erikdesjardins/repos","events_url":"https://api.github.com/users/erikdesjardins/events{/privacy}","received_events_url":"https://api.github.com/users/erikdesjardins/received_events","type":"User","site_admin":false},"repo":{"id":24658917,"name":"Reddit-Enhancement-Suite","full_name":"erikdesjardins/Reddit-Enhancement-Suite","owner":{"login":"erikdesjardins","id":7673145,"avatar_url":"https://avatars.githubusercontent.com/u/7673145?v=3","gravatar_id":"","url":"https://api.github.com/users/erikdesjardins","html_url":"https://github.com/erikdesjardins","followers_url":"https://api.github.com/users/erikdesjardins/followers","following_url":"https://api.github.com/users/erikdesjardins/following{/other_user}","gists_url":"https://api.github.com/users/erikdesjardins/gists{/gist_id}","starred_url":"https://api.github.com/users/erikdesjardins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikdesjardins/subscriptions","organizations_url":"https://api.github.com/users/erikdesjardins/orgs","repos_url":"https://api.github.com/users/erikdesjardins/repos","events_url":"https://api.github.com/users/erikdesjardins/events{/privacy}","received_events_url":"https://api.github.com/users/erikdesjardins/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/erikdesjardins/Reddit-Enhancement-Suite","description":"Reddit Enhancement Suite","fork":true,"url":"https://api.github.com/repos/erikdesjardins/Reddit-Enhancement-Suite","forks_url":"https://api.github.com/repos/erikdesjardins/Reddit-Enhancement-Suite/forks","keys_url":"https://api.github.com/repos/erikdesjardins/Reddit-Enhancement-Suite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/erikdesjardins/Reddit-Enhancement-Suite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/erikdesjardins/Reddit-Enhancement-Suite/teams","hooks_url":"https://api.github.com/repos/erikdesjardins/Reddit-Enhancement-Suite/hooks","issue_events_url":"https://api.github.com/repos/erikdesjardins/Reddit-Enhancement-Suite/issues/events{/number}","events_url":"https://api.github.com/repos/erikdesjardins/Reddit-Enhancement-Suite/events","assignees_url":"https://api.github.com/repos/erikdesjardins/Reddit-Enhancement-Suite/assignees{/user}","branches_url":"https://api.github.com/repos/erikdesjardins/Reddit-Enhancement-Suite/branches{/branch}","tags_url":"https://api.github.com/repos/erikdesjardins/Reddit-Enhancement-Suite/tags","blobs_url":"https://api.github.com/repos/erikdesjardins/Reddit-Enhancement-Suite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/erikdesjardins/Reddit-Enhancement-Suite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/erikdesjardins/Reddit-Enhancement-Suite/git/refs{/sha}","trees_url":"https://api.github.com/repos/erikdesjardins/Reddit-Enhancement-Suite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/erikdesjardins/Reddit-Enhancement-Suite/statuses/{sha}","languages_url":"https://api.github.com/repos/erikdesjardins/Reddit-Enhancement-Suite/languages","stargazers_url":"https://api.github.com/repos/erikdesjardins/Reddit-Enhancement-Suite/stargazers","contributors_url":"https://api.github.com/repos/erikdesjardins/Reddit-Enhancement-Suite/contributors","subscribers_url":"https://api.github.com/repos/erikdesjardins/Reddit-Enhancement-Suite/subscribers","subscription_url":"https://api.github.com/repos/erikdesjardins/Reddit-Enhancement-Suite/subscription","commits_url":"https://api.github.com/repos/erikdesjardins/Reddit-Enhancement-Suite/commits{/sha}","git_commits_url":"https://api.github.com/repos/erikdesjardins/Reddit-Enhancement-Suite/git/commits{/sha}","comments_url":"https://api.github.com/repos/erikdesjardins/Reddit-Enhancement-Suite/comments{/number}","issue_comment_url":"https://api.github.com/repos/erikdesjardins/Reddit-Enhancement-Suite/issues/comments{/number}","contents_url":"https://api.github.com/repos/erikdesjardins/Reddit-Enhancement-Suite/contents/{+path}","compare_url":"https://api.github.com/repos/erikdesjardins/Reddit-Enhancement-Suite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/erikdesjardins/Reddit-Enhancement-Suite/merges","archive_url":"https://api.github.com/repos/erikdesjardins/Reddit-Enhancement-Suite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/erikdesjardins/Reddit-Enhancement-Suite/downloads","issues_url":"https://api.github.com/repos/erikdesjardins/Reddit-Enhancement-Suite/issues{/number}","pulls_url":"https://api.github.com/repos/erikdesjardins/Reddit-Enhancement-Suite/pulls{/number}","milestones_url":"https://api.github.com/repos/erikdesjardins/Reddit-Enhancement-Suite/milestones{/number}","notifications_url":"https://api.github.com/repos/erikdesjardins/Reddit-Enhancement-Suite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/erikdesjardins/Reddit-Enhancement-Suite/labels{/name}","releases_url":"https://api.github.com/repos/erikdesjardins/Reddit-Enhancement-Suite/releases{/id}","created_at":"2014-09-30T23:06:04Z","updated_at":"2015-01-09T15:12:04Z","pushed_at":"2015-02-21T23:41:31Z","git_url":"git://github.com/erikdesjardins/Reddit-Enhancement-Suite.git","ssh_url":"git@github.com:erikdesjardins/Reddit-Enhancement-Suite.git","clone_url":"https://github.com/erikdesjardins/Reddit-Enhancement-Suite.git","svn_url":"https://github.com/erikdesjardins/Reddit-Enhancement-Suite","homepage":"http://redditenhancementsuite.com","size":14075,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"honestbleeps:master","ref":"master","sha":"ce18c00cd3fa9337f153c9d60111e13782c0c321","user":{"login":"honestbleeps","id":323763,"avatar_url":"https://avatars.githubusercontent.com/u/323763?v=3","gravatar_id":"","url":"https://api.github.com/users/honestbleeps","html_url":"https://github.com/honestbleeps","followers_url":"https://api.github.com/users/honestbleeps/followers","following_url":"https://api.github.com/users/honestbleeps/following{/other_user}","gists_url":"https://api.github.com/users/honestbleeps/gists{/gist_id}","starred_url":"https://api.github.com/users/honestbleeps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/honestbleeps/subscriptions","organizations_url":"https://api.github.com/users/honestbleeps/orgs","repos_url":"https://api.github.com/users/honestbleeps/repos","events_url":"https://api.github.com/users/honestbleeps/events{/privacy}","received_events_url":"https://api.github.com/users/honestbleeps/received_events","type":"User","site_admin":false},"repo":{"id":2688907,"name":"Reddit-Enhancement-Suite","full_name":"honestbleeps/Reddit-Enhancement-Suite","owner":{"login":"honestbleeps","id":323763,"avatar_url":"https://avatars.githubusercontent.com/u/323763?v=3","gravatar_id":"","url":"https://api.github.com/users/honestbleeps","html_url":"https://github.com/honestbleeps","followers_url":"https://api.github.com/users/honestbleeps/followers","following_url":"https://api.github.com/users/honestbleeps/following{/other_user}","gists_url":"https://api.github.com/users/honestbleeps/gists{/gist_id}","starred_url":"https://api.github.com/users/honestbleeps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/honestbleeps/subscriptions","organizations_url":"https://api.github.com/users/honestbleeps/orgs","repos_url":"https://api.github.com/users/honestbleeps/repos","events_url":"https://api.github.com/users/honestbleeps/events{/privacy}","received_events_url":"https://api.github.com/users/honestbleeps/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/honestbleeps/Reddit-Enhancement-Suite","description":"Reddit Enhancement Suite","fork":false,"url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite","forks_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/forks","keys_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/teams","hooks_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/hooks","issue_events_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/issues/events{/number}","events_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/events","assignees_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/assignees{/user}","branches_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/branches{/branch}","tags_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/tags","blobs_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/git/refs{/sha}","trees_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/statuses/{sha}","languages_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/languages","stargazers_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/stargazers","contributors_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/contributors","subscribers_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/subscribers","subscription_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/subscription","commits_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/commits{/sha}","git_commits_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/git/commits{/sha}","comments_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/comments{/number}","issue_comment_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/issues/comments{/number}","contents_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/contents/{+path}","compare_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/merges","archive_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/downloads","issues_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/issues{/number}","pulls_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/pulls{/number}","milestones_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/milestones{/number}","notifications_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/labels{/name}","releases_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/releases{/id}","created_at":"2011-11-01T16:31:51Z","updated_at":"2015-02-22T02:07:01Z","pushed_at":"2015-02-22T02:07:00Z","git_url":"git://github.com/honestbleeps/Reddit-Enhancement-Suite.git","ssh_url":"git@github.com:honestbleeps/Reddit-Enhancement-Suite.git","clone_url":"https://github.com/honestbleeps/Reddit-Enhancement-Suite.git","svn_url":"https://github.com/honestbleeps/Reddit-Enhancement-Suite","homepage":"http://redditenhancementsuite.com","size":118348,"stargazers_count":773,"watchers_count":773,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":390,"mirror_url":null,"open_issues_count":471,"forks":390,"open_issues":471,"watchers":773,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/pulls/1912"},"html":{"href":"https://github.com/honestbleeps/Reddit-Enhancement-Suite/pull/1912"},"issue":{"href":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/issues/1912"},"comments":{"href":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/issues/1912/comments"},"review_comments":{"href":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/pulls/1912/comments"},"review_comment":{"href":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/pulls/1912/commits"},"statuses":{"href":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/statuses/f953444b3ea91aa728d56febfd6ec1ecdacebe45"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"andytuba","id":455632,"avatar_url":"https://avatars.githubusercontent.com/u/455632?v=3","gravatar_id":"","url":"https://api.github.com/users/andytuba","html_url":"https://github.com/andytuba","followers_url":"https://api.github.com/users/andytuba/followers","following_url":"https://api.github.com/users/andytuba/following{/other_user}","gists_url":"https://api.github.com/users/andytuba/gists{/gist_id}","starred_url":"https://api.github.com/users/andytuba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andytuba/subscriptions","organizations_url":"https://api.github.com/users/andytuba/orgs","repos_url":"https://api.github.com/users/andytuba/repos","events_url":"https://api.github.com/users/andytuba/events{/privacy}","received_events_url":"https://api.github.com/users/andytuba/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"commits":11,"additions":104,"deletions":106,"changed_files":3}}