{"action":"created","comment":{"url":"https://api.github.com/repos/SonarSource/sonar-java/pulls/comments/32202096","id":32202096,"diff_hunk":"@@ -0,0 +1,74 @@\n+/*\n+ * SonarQube Java\n+ * Copyright (C) 2012 SonarSource\n+ * dev@sonar.codehaus.org\n+ *\n+ * This program is free software; you can redistribute it and/or\n+ * modify it under the terms of the GNU Lesser General Public\n+ * License as published by the Free Software Foundation; either\n+ * version 3 of the License, or (at your option) any later version.\n+ *\n+ * This program is distributed in the hope that it will be useful,\n+ * but WITHOUT ANY WARRANTY; without even the implied warranty of\n+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU\n+ * Lesser General Public License for more details.\n+ *\n+ * You should have received a copy of the GNU Lesser General Public\n+ * License along with this program; if not, write to the Free Software\n+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02\n+ */\n+package org.sonar.java.checks;\n+\n+import com.google.common.collect.ImmutableList;\n+import java.util.ArrayList;\n+import java.util.List;\n+import org.apache.commons.lang.StringUtils;\n+import org.sonar.api.server.rule.RulesDefinition;\n+import org.sonar.check.Priority;\n+import org.sonar.check.Rule;\n+import org.sonar.plugins.java.api.JavaFileScannerContext;\n+import org.sonar.plugins.java.api.tree.Tree;\n+import org.sonar.plugins.java.api.tree.Tree.Kind;\n+import org.sonar.plugins.java.api.tree.VariableTree;\n+import org.sonar.squidbridge.annotations.SqaleConstantRemediation;\n+import org.sonar.squidbridge.annotations.SqaleSubCharacteristic;\n+\n+@Rule(\n+  key = \"S1659\",\n+  name = \"Multiple variables should not be declared on the same line\",\n+  tags = {\"convention\"},\n+  priority = Priority.MAJOR)\n+@SqaleSubCharacteristic(RulesDefinition.SubCharacteristics.READABILITY)\n+@SqaleConstantRemediation(\"5min\")\n+public class OneDeclarationPerLineCheck extends SubscriptionBaseVisitor {\n+\n+  private int varLineLast;\n+  private List<String> varsOnSameLine = new ArrayList<>();\n+\n+  @Override\n+  public void scanFile(JavaFileScannerContext context) {\n+    varLineLast = -1;\n+    varsOnSameLine.clear();\n+    super.scanFile(context);\n+  }\n+\n+  @Override\n+  public List<Kind> nodesToVisit() {\n+    return ImmutableList.of(Tree.Kind.VARIABLE);\n+  }\n+\n+  @Override\n+  public void visitNode(Tree tree) {\n+    VariableTree varTree = (VariableTree) tree;\n+    int varLineCurrent = varTree.endToken().line();\n+    if (varLineCurrent == varLineLast) {\n+      varsOnSameLine.add(varTree.symbol().name());\n+    } else {\n+      if (!varsOnSameLine.isEmpty()) {\n+        addIssue(varLineLast, String.format(\"Declare \\\"%s\\\" on a separate line.\", StringUtils.join(varsOnSameLine, \"\\\", \\\"\")));","path":"java-checks/src/main/java/org/sonar/java/checks/OneDeclarationPerLineCheck.java","position":68,"original_position":68,"commit_id":"5ff6dcc8290dee3671d950e8be46a95e785f1549","original_commit_id":"5ff6dcc8290dee3671d950e8be46a95e785f1549","user":{"login":"m-g-sonar","id":10588758,"avatar_url":"https://avatars.githubusercontent.com/u/10588758?v=3","gravatar_id":"","url":"https://api.github.com/users/m-g-sonar","html_url":"https://github.com/m-g-sonar","followers_url":"https://api.github.com/users/m-g-sonar/followers","following_url":"https://api.github.com/users/m-g-sonar/following{/other_user}","gists_url":"https://api.github.com/users/m-g-sonar/gists{/gist_id}","starred_url":"https://api.github.com/users/m-g-sonar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m-g-sonar/subscriptions","organizations_url":"https://api.github.com/users/m-g-sonar/orgs","repos_url":"https://api.github.com/users/m-g-sonar/repos","events_url":"https://api.github.com/users/m-g-sonar/events{/privacy}","received_events_url":"https://api.github.com/users/m-g-sonar/received_events","type":"User","site_admin":false},"body":"With that approach you will miss some cases, in particular the case of the last variable declaration. For instance, your current implementation, you will miss the issue in the following code:\r\n\r\n```java\r\nclass A {\r\n  int a; // Compliant\r\n  int b, c; // Noncompliant and detected\r\n  int d, e; // Noncompliant but not detected\r\n}\r\n```\r\n","created_at":"2015-06-11T09:09:07Z","updated_at":"2015-06-11T09:09:07Z","html_url":"https://github.com/SonarSource/sonar-java/pull/281#discussion_r32202096","pull_request_url":"https://api.github.com/repos/SonarSource/sonar-java/pulls/281","_links":{"self":{"href":"https://api.github.com/repos/SonarSource/sonar-java/pulls/comments/32202096"},"html":{"href":"https://github.com/SonarSource/sonar-java/pull/281#discussion_r32202096"},"pull_request":{"href":"https://api.github.com/repos/SonarSource/sonar-java/pulls/281"}}},"pull_request":{"url":"https://api.github.com/repos/SonarSource/sonar-java/pulls/281","id":37393414,"html_url":"https://github.com/SonarSource/sonar-java/pull/281","diff_url":"https://github.com/SonarSource/sonar-java/pull/281.diff","patch_url":"https://github.com/SonarSource/sonar-java/pull/281.patch","issue_url":"https://api.github.com/repos/SonarSource/sonar-java/issues/281","number":281,"state":"open","locked":false,"title":"RSPEC-1659 : Multiple variables should not be declared on the same line","user":{"login":"axel3rd","id":2912441,"avatar_url":"https://avatars.githubusercontent.com/u/2912441?v=3","gravatar_id":"","url":"https://api.github.com/users/axel3rd","html_url":"https://github.com/axel3rd","followers_url":"https://api.github.com/users/axel3rd/followers","following_url":"https://api.github.com/users/axel3rd/following{/other_user}","gists_url":"https://api.github.com/users/axel3rd/gists{/gist_id}","starred_url":"https://api.github.com/users/axel3rd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/axel3rd/subscriptions","organizations_url":"https://api.github.com/users/axel3rd/orgs","repos_url":"https://api.github.com/users/axel3rd/repos","events_url":"https://api.github.com/users/axel3rd/events{/privacy}","received_events_url":"https://api.github.com/users/axel3rd/received_events","type":"User","site_admin":false},"body":"Proposal for [RSPEC-1659](http://jira.sonarsource.com/browse/RSPEC-1659), note about it :\r\n* No tag => I choose **convention**\r\n* **description** can't be apply for Java language => some liberties in *S1659.html*\r\n* sqale cost to **5min** is not too much ?","created_at":"2015-06-10T19:12:13Z","updated_at":"2015-06-11T09:09:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4a73447d7dc714bed2d96575a65b1f46aa598636","assignee":{"login":"m-g-sonar","id":10588758,"avatar_url":"https://avatars.githubusercontent.com/u/10588758?v=3","gravatar_id":"","url":"https://api.github.com/users/m-g-sonar","html_url":"https://github.com/m-g-sonar","followers_url":"https://api.github.com/users/m-g-sonar/followers","following_url":"https://api.github.com/users/m-g-sonar/following{/other_user}","gists_url":"https://api.github.com/users/m-g-sonar/gists{/gist_id}","starred_url":"https://api.github.com/users/m-g-sonar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m-g-sonar/subscriptions","organizations_url":"https://api.github.com/users/m-g-sonar/orgs","repos_url":"https://api.github.com/users/m-g-sonar/repos","events_url":"https://api.github.com/users/m-g-sonar/events{/privacy}","received_events_url":"https://api.github.com/users/m-g-sonar/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/SonarSource/sonar-java/pulls/281/commits","review_comments_url":"https://api.github.com/repos/SonarSource/sonar-java/pulls/281/comments","review_comment_url":"https://api.github.com/repos/SonarSource/sonar-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SonarSource/sonar-java/issues/281/comments","statuses_url":"https://api.github.com/repos/SonarSource/sonar-java/statuses/5ff6dcc8290dee3671d950e8be46a95e785f1549","head":{"label":"axel3rd:MultipleVariableDeclarations-S1659","ref":"MultipleVariableDeclarations-S1659","sha":"5ff6dcc8290dee3671d950e8be46a95e785f1549","user":{"login":"axel3rd","id":2912441,"avatar_url":"https://avatars.githubusercontent.com/u/2912441?v=3","gravatar_id":"","url":"https://api.github.com/users/axel3rd","html_url":"https://github.com/axel3rd","followers_url":"https://api.github.com/users/axel3rd/followers","following_url":"https://api.github.com/users/axel3rd/following{/other_user}","gists_url":"https://api.github.com/users/axel3rd/gists{/gist_id}","starred_url":"https://api.github.com/users/axel3rd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/axel3rd/subscriptions","organizations_url":"https://api.github.com/users/axel3rd/orgs","repos_url":"https://api.github.com/users/axel3rd/repos","events_url":"https://api.github.com/users/axel3rd/events{/privacy}","received_events_url":"https://api.github.com/users/axel3rd/received_events","type":"User","site_admin":false},"repo":{"id":37074952,"name":"sonar-java","full_name":"axel3rd/sonar-java","owner":{"login":"axel3rd","id":2912441,"avatar_url":"https://avatars.githubusercontent.com/u/2912441?v=3","gravatar_id":"","url":"https://api.github.com/users/axel3rd","html_url":"https://github.com/axel3rd","followers_url":"https://api.github.com/users/axel3rd/followers","following_url":"https://api.github.com/users/axel3rd/following{/other_user}","gists_url":"https://api.github.com/users/axel3rd/gists{/gist_id}","starred_url":"https://api.github.com/users/axel3rd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/axel3rd/subscriptions","organizations_url":"https://api.github.com/users/axel3rd/orgs","repos_url":"https://api.github.com/users/axel3rd/repos","events_url":"https://api.github.com/users/axel3rd/events{/privacy}","received_events_url":"https://api.github.com/users/axel3rd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/axel3rd/sonar-java","description":"","fork":true,"url":"https://api.github.com/repos/axel3rd/sonar-java","forks_url":"https://api.github.com/repos/axel3rd/sonar-java/forks","keys_url":"https://api.github.com/repos/axel3rd/sonar-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/axel3rd/sonar-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/axel3rd/sonar-java/teams","hooks_url":"https://api.github.com/repos/axel3rd/sonar-java/hooks","issue_events_url":"https://api.github.com/repos/axel3rd/sonar-java/issues/events{/number}","events_url":"https://api.github.com/repos/axel3rd/sonar-java/events","assignees_url":"https://api.github.com/repos/axel3rd/sonar-java/assignees{/user}","branches_url":"https://api.github.com/repos/axel3rd/sonar-java/branches{/branch}","tags_url":"https://api.github.com/repos/axel3rd/sonar-java/tags","blobs_url":"https://api.github.com/repos/axel3rd/sonar-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/axel3rd/sonar-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/axel3rd/sonar-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/axel3rd/sonar-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/axel3rd/sonar-java/statuses/{sha}","languages_url":"https://api.github.com/repos/axel3rd/sonar-java/languages","stargazers_url":"https://api.github.com/repos/axel3rd/sonar-java/stargazers","contributors_url":"https://api.github.com/repos/axel3rd/sonar-java/contributors","subscribers_url":"https://api.github.com/repos/axel3rd/sonar-java/subscribers","subscription_url":"https://api.github.com/repos/axel3rd/sonar-java/subscription","commits_url":"https://api.github.com/repos/axel3rd/sonar-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/axel3rd/sonar-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/axel3rd/sonar-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/axel3rd/sonar-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/axel3rd/sonar-java/contents/{+path}","compare_url":"https://api.github.com/repos/axel3rd/sonar-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/axel3rd/sonar-java/merges","archive_url":"https://api.github.com/repos/axel3rd/sonar-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/axel3rd/sonar-java/downloads","issues_url":"https://api.github.com/repos/axel3rd/sonar-java/issues{/number}","pulls_url":"https://api.github.com/repos/axel3rd/sonar-java/pulls{/number}","milestones_url":"https://api.github.com/repos/axel3rd/sonar-java/milestones{/number}","notifications_url":"https://api.github.com/repos/axel3rd/sonar-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/axel3rd/sonar-java/labels{/name}","releases_url":"https://api.github.com/repos/axel3rd/sonar-java/releases{/id}","created_at":"2015-06-08T15:20:06Z","updated_at":"2015-06-08T15:20:10Z","pushed_at":"2015-06-10T20:13:21Z","git_url":"git://github.com/axel3rd/sonar-java.git","ssh_url":"git@github.com:axel3rd/sonar-java.git","clone_url":"https://github.com/axel3rd/sonar-java.git","svn_url":"https://github.com/axel3rd/sonar-java","homepage":"","size":12211,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SonarSource:master","ref":"master","sha":"4842f7592846a3c920e55cbb7dfdb10f9b49e959","user":{"login":"SonarSource","id":545988,"avatar_url":"https://avatars.githubusercontent.com/u/545988?v=3","gravatar_id":"","url":"https://api.github.com/users/SonarSource","html_url":"https://github.com/SonarSource","followers_url":"https://api.github.com/users/SonarSource/followers","following_url":"https://api.github.com/users/SonarSource/following{/other_user}","gists_url":"https://api.github.com/users/SonarSource/gists{/gist_id}","starred_url":"https://api.github.com/users/SonarSource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SonarSource/subscriptions","organizations_url":"https://api.github.com/users/SonarSource/orgs","repos_url":"https://api.github.com/users/SonarSource/repos","events_url":"https://api.github.com/users/SonarSource/events{/privacy}","received_events_url":"https://api.github.com/users/SonarSource/received_events","type":"Organization","site_admin":false},"repo":{"id":5674787,"name":"sonar-java","full_name":"SonarSource/sonar-java","owner":{"login":"SonarSource","id":545988,"avatar_url":"https://avatars.githubusercontent.com/u/545988?v=3","gravatar_id":"","url":"https://api.github.com/users/SonarSource","html_url":"https://github.com/SonarSource","followers_url":"https://api.github.com/users/SonarSource/followers","following_url":"https://api.github.com/users/SonarSource/following{/other_user}","gists_url":"https://api.github.com/users/SonarSource/gists{/gist_id}","starred_url":"https://api.github.com/users/SonarSource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SonarSource/subscriptions","organizations_url":"https://api.github.com/users/SonarSource/orgs","repos_url":"https://api.github.com/users/SonarSource/repos","events_url":"https://api.github.com/users/SonarSource/events{/privacy}","received_events_url":"https://api.github.com/users/SonarSource/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SonarSource/sonar-java","description":"","fork":false,"url":"https://api.github.com/repos/SonarSource/sonar-java","forks_url":"https://api.github.com/repos/SonarSource/sonar-java/forks","keys_url":"https://api.github.com/repos/SonarSource/sonar-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SonarSource/sonar-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SonarSource/sonar-java/teams","hooks_url":"https://api.github.com/repos/SonarSource/sonar-java/hooks","issue_events_url":"https://api.github.com/repos/SonarSource/sonar-java/issues/events{/number}","events_url":"https://api.github.com/repos/SonarSource/sonar-java/events","assignees_url":"https://api.github.com/repos/SonarSource/sonar-java/assignees{/user}","branches_url":"https://api.github.com/repos/SonarSource/sonar-java/branches{/branch}","tags_url":"https://api.github.com/repos/SonarSource/sonar-java/tags","blobs_url":"https://api.github.com/repos/SonarSource/sonar-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SonarSource/sonar-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SonarSource/sonar-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/SonarSource/sonar-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SonarSource/sonar-java/statuses/{sha}","languages_url":"https://api.github.com/repos/SonarSource/sonar-java/languages","stargazers_url":"https://api.github.com/repos/SonarSource/sonar-java/stargazers","contributors_url":"https://api.github.com/repos/SonarSource/sonar-java/contributors","subscribers_url":"https://api.github.com/repos/SonarSource/sonar-java/subscribers","subscription_url":"https://api.github.com/repos/SonarSource/sonar-java/subscription","commits_url":"https://api.github.com/repos/SonarSource/sonar-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/SonarSource/sonar-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/SonarSource/sonar-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/SonarSource/sonar-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/SonarSource/sonar-java/contents/{+path}","compare_url":"https://api.github.com/repos/SonarSource/sonar-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SonarSource/sonar-java/merges","archive_url":"https://api.github.com/repos/SonarSource/sonar-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SonarSource/sonar-java/downloads","issues_url":"https://api.github.com/repos/SonarSource/sonar-java/issues{/number}","pulls_url":"https://api.github.com/repos/SonarSource/sonar-java/pulls{/number}","milestones_url":"https://api.github.com/repos/SonarSource/sonar-java/milestones{/number}","notifications_url":"https://api.github.com/repos/SonarSource/sonar-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SonarSource/sonar-java/labels{/name}","releases_url":"https://api.github.com/repos/SonarSource/sonar-java/releases{/id}","created_at":"2012-09-04T15:53:13Z","updated_at":"2015-06-08T11:35:26Z","pushed_at":"2015-06-11T08:17:01Z","git_url":"git://github.com/SonarSource/sonar-java.git","ssh_url":"git@github.com:SonarSource/sonar-java.git","clone_url":"https://github.com/SonarSource/sonar-java.git","svn_url":"https://github.com/SonarSource/sonar-java","homepage":"","size":34547,"stargazers_count":46,"watchers_count":46,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":84,"mirror_url":null,"open_issues_count":8,"forks":84,"open_issues":8,"watchers":46,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SonarSource/sonar-java/pulls/281"},"html":{"href":"https://github.com/SonarSource/sonar-java/pull/281"},"issue":{"href":"https://api.github.com/repos/SonarSource/sonar-java/issues/281"},"comments":{"href":"https://api.github.com/repos/SonarSource/sonar-java/issues/281/comments"},"review_comments":{"href":"https://api.github.com/repos/SonarSource/sonar-java/pulls/281/comments"},"review_comment":{"href":"https://api.github.com/repos/SonarSource/sonar-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SonarSource/sonar-java/pulls/281/commits"},"statuses":{"href":"https://api.github.com/repos/SonarSource/sonar-java/statuses/5ff6dcc8290dee3671d950e8be46a95e785f1549"}}}}