{"action":"created","comment":{"url":"https://api.github.com/repos/epost-dev/opennebula-puppet-module/pulls/comments/29834256","id":29834256,"diff_hunk":"@@ -29,102 +29,78 @@\n   $ohd_deb_repo      = $one::preseed_ohd_deb_repo,\n   $debian_mirror_url = $one::preseed_debian_mirror_url,\n   $preseed_tmpl      = $one::preseed_tmpl,\n+  $libvirtd_cfg      = $one::libvirtd_cfg,\n+  $libvirtd_source   = $one::libvirtd_source,\n+  $libvirtd_srv      = $one::libvirtd_srv\n ){\n \n-  File {\n-    ensure => 'present',\n-  }\n-\n   validate_string ($debian_mirror_url)\n   validate_hash   ($preseed_data)\n \n   file { '/etc/libvirt/libvirtd.conf':\n-    owner  => 'root',\n+    ensure => file,\n     source => 'puppet:///modules/one/libvirtd.conf',\n-    notify => Service[$one::libvirtd_srv],\n-  }\n+    notify => Service[$libvirtd_srv],\n+  } ->\n \n-  file { $one::libvirtd_cfg:\n-    owner  => 'root',\n-    source => $one::libvirtd_source,\n-    notify => Service[$one::libvirtd_srv],\n-  }\n+  file { $libvirtd_cfg:\n+    ensure => file,\n+    source => $libvirtd_source,\n+    notify => Service[$libvirtd_srv],\n+  } ->\n \n   file { '/etc/udev/rules.d/80-kvm.rules':\n-    owner  => 'root',\n+    ensure => file,\n     source => 'puppet:///modules/one/udev-kvm-rules',\n-  }\n+  } ->\n \n   file { '/etc/sudoers.d/10_oneadmin':\n-    owner  => 'root',\n-    group  => 'root',\n-    mode   => '0644',\n+    ensure => file,\n     source => 'puppet:///modules/one/oneadmin_sudoers',\n-  }\n+  } ->\n \n   file { '/etc/sudoers.d/20_imaginator':\n-    owner  => 'root',\n-    group  => 'root',\n-    mode   => '0644',\n+    ensure => file,\n     source => 'puppet:///modules/one/sudoers_imaginator',\n-  }\n-\n-  if $::osfamily == 'Debian' {\n-    file { '/sbin/brctl':\n-      ensure => link,\n-      target => '/usr/sbin/brctl',\n-    }\n-  }\n-\n-  if $::osfamily == 'RedHat' and versioncmp($::operatingsystemmajrelease, '7') < 0  {\n-    file { '/sbin/brctl':\n-      ensure => link,\n-      target => '/usr/sbin/brctl',\n-    }\n-  }\n+  } ->\n \n   file { 'polkit-opennebula':\n+    ensure => file,\n     path   => $::osfamily ? {\n       'RedHat' => '/etc/polkit-1/localauthority/50-local.d/50-org.libvirt.unix.manage-opennebula.pkla',\n       'Debian' => '/var/lib/polkit-1/localauthority/50-local.d/50-org.libvirt.unix.manage-opennebula.pkla',\n     },\n-    owner  => 'root',\n-    group  => 'root',\n-    mode   => '0644',\n     source => 'puppet:///modules/one/50-org.libvirt.unix.manage-opennebula.pkla',\n-  }\n+  } ->\n \n   file { '/etc/libvirt/qemu.conf':\n-    owner  => 'root',\n-    group  => 'root',\n-    mode   => '0644',\n+    ensure => file,\n     source => 'puppet:///modules/one/qemu.conf'\n-  }\n+  } ->\n \n-  # Imaginator\n   file { '/var/lib/one/.virtinst':\n-    ensure => directory,\n-    owner  => 'oneadmin',\n-    group  => 'oneadmin',\n-    mode   => '0755',","path":"manifests/compute_node/config.pp","position":102,"original_position":102,"commit_id":"dcf7313d8971c59cade5cd83e771d53275a427b2","original_commit_id":"dcf7313d8971c59cade5cd83e771d53275a427b2","user":{"login":"tuxmea","id":763214,"avatar_url":"https://avatars.githubusercontent.com/u/763214?v=3","gravatar_id":"","url":"https://api.github.com/users/tuxmea","html_url":"https://github.com/tuxmea","followers_url":"https://api.github.com/users/tuxmea/followers","following_url":"https://api.github.com/users/tuxmea/following{/other_user}","gists_url":"https://api.github.com/users/tuxmea/gists{/gist_id}","starred_url":"https://api.github.com/users/tuxmea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tuxmea/subscriptions","organizations_url":"https://api.github.com/users/tuxmea/orgs","repos_url":"https://api.github.com/users/tuxmea/repos","events_url":"https://api.github.com/users/tuxmea/events{/privacy}","received_events_url":"https://api.github.com/users/tuxmea/received_events","type":"User","site_admin":false},"body":"Please keep the mode in place.\r\nYou might get trouble when umask is set to a more restrictive setting.","created_at":"2015-05-07T08:50:10Z","updated_at":"2015-05-07T08:50:10Z","html_url":"https://github.com/epost-dev/opennebula-puppet-module/pull/151#discussion_r29834256","pull_request_url":"https://api.github.com/repos/epost-dev/opennebula-puppet-module/pulls/151","_links":{"self":{"href":"https://api.github.com/repos/epost-dev/opennebula-puppet-module/pulls/comments/29834256"},"html":{"href":"https://github.com/epost-dev/opennebula-puppet-module/pull/151#discussion_r29834256"},"pull_request":{"href":"https://api.github.com/repos/epost-dev/opennebula-puppet-module/pulls/151"}}},"pull_request":{"url":"https://api.github.com/repos/epost-dev/opennebula-puppet-module/pulls/151","id":34731681,"html_url":"https://github.com/epost-dev/opennebula-puppet-module/pull/151","diff_url":"https://github.com/epost-dev/opennebula-puppet-module/pull/151.diff","patch_url":"https://github.com/epost-dev/opennebula-puppet-module/pull/151.patch","issue_url":"https://api.github.com/repos/epost-dev/opennebula-puppet-module/issues/151","number":151,"state":"open","locked":false,"title":"Improvements and style","user":{"login":"rwaffen","id":1800591,"avatar_url":"https://avatars.githubusercontent.com/u/1800591?v=3","gravatar_id":"","url":"https://api.github.com/users/rwaffen","html_url":"https://github.com/rwaffen","followers_url":"https://api.github.com/users/rwaffen/followers","following_url":"https://api.github.com/users/rwaffen/following{/other_user}","gists_url":"https://api.github.com/users/rwaffen/gists{/gist_id}","starred_url":"https://api.github.com/users/rwaffen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwaffen/subscriptions","organizations_url":"https://api.github.com/users/rwaffen/orgs","repos_url":"https://api.github.com/users/rwaffen/repos","events_url":"https://api.github.com/users/rwaffen/events{/privacy}","received_events_url":"https://api.github.com/users/rwaffen/received_events","type":"User","site_admin":false},"body":"Had some time while traveling, so i reworked the module. Did some reordering, style fixes and added parameters to all the classes, so that you can test them one by one. Added some spec tests, but not for all the classes. Changed the behavior of the big over-all-test. merge the deb and the rhel version into one file.","created_at":"2015-05-05T14:49:29Z","updated_at":"2015-05-07T08:50:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"56e250604adbbdaad5158cb5ee6c8460ac16c5d2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/epost-dev/opennebula-puppet-module/pulls/151/commits","review_comments_url":"https://api.github.com/repos/epost-dev/opennebula-puppet-module/pulls/151/comments","review_comment_url":"https://api.github.com/repos/epost-dev/opennebula-puppet-module/pulls/comments{/number}","comments_url":"https://api.github.com/repos/epost-dev/opennebula-puppet-module/issues/151/comments","statuses_url":"https://api.github.com/repos/epost-dev/opennebula-puppet-module/statuses/dcf7313d8971c59cade5cd83e771d53275a427b2","head":{"label":"rwaffen:improvements_and_style","ref":"improvements_and_style","sha":"dcf7313d8971c59cade5cd83e771d53275a427b2","user":{"login":"rwaffen","id":1800591,"avatar_url":"https://avatars.githubusercontent.com/u/1800591?v=3","gravatar_id":"","url":"https://api.github.com/users/rwaffen","html_url":"https://github.com/rwaffen","followers_url":"https://api.github.com/users/rwaffen/followers","following_url":"https://api.github.com/users/rwaffen/following{/other_user}","gists_url":"https://api.github.com/users/rwaffen/gists{/gist_id}","starred_url":"https://api.github.com/users/rwaffen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwaffen/subscriptions","organizations_url":"https://api.github.com/users/rwaffen/orgs","repos_url":"https://api.github.com/users/rwaffen/repos","events_url":"https://api.github.com/users/rwaffen/events{/privacy}","received_events_url":"https://api.github.com/users/rwaffen/received_events","type":"User","site_admin":false},"repo":{"id":16579340,"name":"opennebula-puppet-module","full_name":"rwaffen/opennebula-puppet-module","owner":{"login":"rwaffen","id":1800591,"avatar_url":"https://avatars.githubusercontent.com/u/1800591?v=3","gravatar_id":"","url":"https://api.github.com/users/rwaffen","html_url":"https://github.com/rwaffen","followers_url":"https://api.github.com/users/rwaffen/followers","following_url":"https://api.github.com/users/rwaffen/following{/other_user}","gists_url":"https://api.github.com/users/rwaffen/gists{/gist_id}","starred_url":"https://api.github.com/users/rwaffen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwaffen/subscriptions","organizations_url":"https://api.github.com/users/rwaffen/orgs","repos_url":"https://api.github.com/users/rwaffen/repos","events_url":"https://api.github.com/users/rwaffen/events{/privacy}","received_events_url":"https://api.github.com/users/rwaffen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rwaffen/opennebula-puppet-module","description":"The one module allows to install and manage your OpenNebula cloud","fork":true,"url":"https://api.github.com/repos/rwaffen/opennebula-puppet-module","forks_url":"https://api.github.com/repos/rwaffen/opennebula-puppet-module/forks","keys_url":"https://api.github.com/repos/rwaffen/opennebula-puppet-module/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rwaffen/opennebula-puppet-module/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rwaffen/opennebula-puppet-module/teams","hooks_url":"https://api.github.com/repos/rwaffen/opennebula-puppet-module/hooks","issue_events_url":"https://api.github.com/repos/rwaffen/opennebula-puppet-module/issues/events{/number}","events_url":"https://api.github.com/repos/rwaffen/opennebula-puppet-module/events","assignees_url":"https://api.github.com/repos/rwaffen/opennebula-puppet-module/assignees{/user}","branches_url":"https://api.github.com/repos/rwaffen/opennebula-puppet-module/branches{/branch}","tags_url":"https://api.github.com/repos/rwaffen/opennebula-puppet-module/tags","blobs_url":"https://api.github.com/repos/rwaffen/opennebula-puppet-module/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rwaffen/opennebula-puppet-module/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rwaffen/opennebula-puppet-module/git/refs{/sha}","trees_url":"https://api.github.com/repos/rwaffen/opennebula-puppet-module/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rwaffen/opennebula-puppet-module/statuses/{sha}","languages_url":"https://api.github.com/repos/rwaffen/opennebula-puppet-module/languages","stargazers_url":"https://api.github.com/repos/rwaffen/opennebula-puppet-module/stargazers","contributors_url":"https://api.github.com/repos/rwaffen/opennebula-puppet-module/contributors","subscribers_url":"https://api.github.com/repos/rwaffen/opennebula-puppet-module/subscribers","subscription_url":"https://api.github.com/repos/rwaffen/opennebula-puppet-module/subscription","commits_url":"https://api.github.com/repos/rwaffen/opennebula-puppet-module/commits{/sha}","git_commits_url":"https://api.github.com/repos/rwaffen/opennebula-puppet-module/git/commits{/sha}","comments_url":"https://api.github.com/repos/rwaffen/opennebula-puppet-module/comments{/number}","issue_comment_url":"https://api.github.com/repos/rwaffen/opennebula-puppet-module/issues/comments{/number}","contents_url":"https://api.github.com/repos/rwaffen/opennebula-puppet-module/contents/{+path}","compare_url":"https://api.github.com/repos/rwaffen/opennebula-puppet-module/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rwaffen/opennebula-puppet-module/merges","archive_url":"https://api.github.com/repos/rwaffen/opennebula-puppet-module/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rwaffen/opennebula-puppet-module/downloads","issues_url":"https://api.github.com/repos/rwaffen/opennebula-puppet-module/issues{/number}","pulls_url":"https://api.github.com/repos/rwaffen/opennebula-puppet-module/pulls{/number}","milestones_url":"https://api.github.com/repos/rwaffen/opennebula-puppet-module/milestones{/number}","notifications_url":"https://api.github.com/repos/rwaffen/opennebula-puppet-module/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rwaffen/opennebula-puppet-module/labels{/name}","releases_url":"https://api.github.com/repos/rwaffen/opennebula-puppet-module/releases{/id}","created_at":"2014-02-06T12:58:39Z","updated_at":"2015-05-05T11:31:18Z","pushed_at":"2015-05-05T20:32:44Z","git_url":"git://github.com/rwaffen/opennebula-puppet-module.git","ssh_url":"git@github.com:rwaffen/opennebula-puppet-module.git","clone_url":"https://github.com/rwaffen/opennebula-puppet-module.git","svn_url":"https://github.com/rwaffen/opennebula-puppet-module","homepage":"","size":924,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"epost-dev:master","ref":"master","sha":"e61cf5456c1c0efa63e5f8236dd9d9747a8b0553","user":{"login":"epost-dev","id":5647007,"avatar_url":"https://avatars.githubusercontent.com/u/5647007?v=3","gravatar_id":"","url":"https://api.github.com/users/epost-dev","html_url":"https://github.com/epost-dev","followers_url":"https://api.github.com/users/epost-dev/followers","following_url":"https://api.github.com/users/epost-dev/following{/other_user}","gists_url":"https://api.github.com/users/epost-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/epost-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/epost-dev/subscriptions","organizations_url":"https://api.github.com/users/epost-dev/orgs","repos_url":"https://api.github.com/users/epost-dev/repos","events_url":"https://api.github.com/users/epost-dev/events{/privacy}","received_events_url":"https://api.github.com/users/epost-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":14229215,"name":"opennebula-puppet-module","full_name":"epost-dev/opennebula-puppet-module","owner":{"login":"epost-dev","id":5647007,"avatar_url":"https://avatars.githubusercontent.com/u/5647007?v=3","gravatar_id":"","url":"https://api.github.com/users/epost-dev","html_url":"https://github.com/epost-dev","followers_url":"https://api.github.com/users/epost-dev/followers","following_url":"https://api.github.com/users/epost-dev/following{/other_user}","gists_url":"https://api.github.com/users/epost-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/epost-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/epost-dev/subscriptions","organizations_url":"https://api.github.com/users/epost-dev/orgs","repos_url":"https://api.github.com/users/epost-dev/repos","events_url":"https://api.github.com/users/epost-dev/events{/privacy}","received_events_url":"https://api.github.com/users/epost-dev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/epost-dev/opennebula-puppet-module","description":"The one module allows to install and manage your OpenNebula cloud","fork":false,"url":"https://api.github.com/repos/epost-dev/opennebula-puppet-module","forks_url":"https://api.github.com/repos/epost-dev/opennebula-puppet-module/forks","keys_url":"https://api.github.com/repos/epost-dev/opennebula-puppet-module/keys{/key_id}","collaborators_url":"https://api.github.com/repos/epost-dev/opennebula-puppet-module/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/epost-dev/opennebula-puppet-module/teams","hooks_url":"https://api.github.com/repos/epost-dev/opennebula-puppet-module/hooks","issue_events_url":"https://api.github.com/repos/epost-dev/opennebula-puppet-module/issues/events{/number}","events_url":"https://api.github.com/repos/epost-dev/opennebula-puppet-module/events","assignees_url":"https://api.github.com/repos/epost-dev/opennebula-puppet-module/assignees{/user}","branches_url":"https://api.github.com/repos/epost-dev/opennebula-puppet-module/branches{/branch}","tags_url":"https://api.github.com/repos/epost-dev/opennebula-puppet-module/tags","blobs_url":"https://api.github.com/repos/epost-dev/opennebula-puppet-module/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/epost-dev/opennebula-puppet-module/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/epost-dev/opennebula-puppet-module/git/refs{/sha}","trees_url":"https://api.github.com/repos/epost-dev/opennebula-puppet-module/git/trees{/sha}","statuses_url":"https://api.github.com/repos/epost-dev/opennebula-puppet-module/statuses/{sha}","languages_url":"https://api.github.com/repos/epost-dev/opennebula-puppet-module/languages","stargazers_url":"https://api.github.com/repos/epost-dev/opennebula-puppet-module/stargazers","contributors_url":"https://api.github.com/repos/epost-dev/opennebula-puppet-module/contributors","subscribers_url":"https://api.github.com/repos/epost-dev/opennebula-puppet-module/subscribers","subscription_url":"https://api.github.com/repos/epost-dev/opennebula-puppet-module/subscription","commits_url":"https://api.github.com/repos/epost-dev/opennebula-puppet-module/commits{/sha}","git_commits_url":"https://api.github.com/repos/epost-dev/opennebula-puppet-module/git/commits{/sha}","comments_url":"https://api.github.com/repos/epost-dev/opennebula-puppet-module/comments{/number}","issue_comment_url":"https://api.github.com/repos/epost-dev/opennebula-puppet-module/issues/comments{/number}","contents_url":"https://api.github.com/repos/epost-dev/opennebula-puppet-module/contents/{+path}","compare_url":"https://api.github.com/repos/epost-dev/opennebula-puppet-module/compare/{base}...{head}","merges_url":"https://api.github.com/repos/epost-dev/opennebula-puppet-module/merges","archive_url":"https://api.github.com/repos/epost-dev/opennebula-puppet-module/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/epost-dev/opennebula-puppet-module/downloads","issues_url":"https://api.github.com/repos/epost-dev/opennebula-puppet-module/issues{/number}","pulls_url":"https://api.github.com/repos/epost-dev/opennebula-puppet-module/pulls{/number}","milestones_url":"https://api.github.com/repos/epost-dev/opennebula-puppet-module/milestones{/number}","notifications_url":"https://api.github.com/repos/epost-dev/opennebula-puppet-module/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/epost-dev/opennebula-puppet-module/labels{/name}","releases_url":"https://api.github.com/repos/epost-dev/opennebula-puppet-module/releases{/id}","created_at":"2013-11-08T09:43:17Z","updated_at":"2015-05-05T09:18:16Z","pushed_at":"2015-05-05T20:32:44Z","git_url":"git://github.com/epost-dev/opennebula-puppet-module.git","ssh_url":"git@github.com:epost-dev/opennebula-puppet-module.git","clone_url":"https://github.com/epost-dev/opennebula-puppet-module.git","svn_url":"https://github.com/epost-dev/opennebula-puppet-module","homepage":"","size":1619,"stargazers_count":19,"watchers_count":19,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":28,"mirror_url":null,"open_issues_count":4,"forks":28,"open_issues":4,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/epost-dev/opennebula-puppet-module/pulls/151"},"html":{"href":"https://github.com/epost-dev/opennebula-puppet-module/pull/151"},"issue":{"href":"https://api.github.com/repos/epost-dev/opennebula-puppet-module/issues/151"},"comments":{"href":"https://api.github.com/repos/epost-dev/opennebula-puppet-module/issues/151/comments"},"review_comments":{"href":"https://api.github.com/repos/epost-dev/opennebula-puppet-module/pulls/151/comments"},"review_comment":{"href":"https://api.github.com/repos/epost-dev/opennebula-puppet-module/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/epost-dev/opennebula-puppet-module/pulls/151/commits"},"statuses":{"href":"https://api.github.com/repos/epost-dev/opennebula-puppet-module/statuses/dcf7313d8971c59cade5cd83e771d53275a427b2"}}}}