{"action":"created","issue":{"url":"https://api.github.com/repos/ssj71/OSC2MIDI/issues/4","labels_url":"https://api.github.com/repos/ssj71/OSC2MIDI/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/ssj71/OSC2MIDI/issues/4/comments","events_url":"https://api.github.com/repos/ssj71/OSC2MIDI/issues/4/events","html_url":"https://github.com/ssj71/OSC2MIDI/pull/4","id":86719713,"number":4,"title":"OSX fixes","user":{"login":"agraef","id":2853977,"avatar_url":"https://avatars.githubusercontent.com/u/2853977?v=3","gravatar_id":"","url":"https://api.github.com/users/agraef","html_url":"https://github.com/agraef","followers_url":"https://api.github.com/users/agraef/followers","following_url":"https://api.github.com/users/agraef/following{/other_user}","gists_url":"https://api.github.com/users/agraef/gists{/gist_id}","starred_url":"https://api.github.com/users/agraef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agraef/subscriptions","organizations_url":"https://api.github.com/users/agraef/orgs","repos_url":"https://api.github.com/users/agraef/repos","events_url":"https://api.github.com/users/agraef/events{/privacy}","received_events_url":"https://api.github.com/users/agraef/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-06-09T20:09:42Z","updated_at":"2015-06-11T16:27:58Z","closed_at":"2015-06-10T23:12:49Z","pull_request":{"url":"https://api.github.com/repos/ssj71/OSC2MIDI/pulls/4","html_url":"https://github.com/ssj71/OSC2MIDI/pull/4","diff_url":"https://github.com/ssj71/OSC2MIDI/pull/4.diff","patch_url":"https://github.com/ssj71/OSC2MIDI/pull/4.patch"},"body":"This fixes padding with extra null bytes in osc2midi's MIDI output, which JackOSX/CoreMidi doesn't like. Output MIDI messages are now trimmed to the proper byte count, and invalid MIDI data is ignored.\r\n\r\nFor some reason, the extra bytes don't cause issues on Linux -- maybe the ALSA layer eliminates them when hooking up osc2midi to ALSA MIDI applications via a2jmidid? But on OSX this fix is definitely needed, otherwise MIDI applications may misbehave, or at least spit out warnings about invalid MIDI data. And of course the fix works on Linux, too."},"comment":{"url":"https://api.github.com/repos/ssj71/OSC2MIDI/issues/comments/111193788","html_url":"https://github.com/ssj71/OSC2MIDI/pull/4#issuecomment-111193788","issue_url":"https://api.github.com/repos/ssj71/OSC2MIDI/issues/4","id":111193788,"user":{"login":"ssj71","id":3495244,"avatar_url":"https://avatars.githubusercontent.com/u/3495244?v=3","gravatar_id":"","url":"https://api.github.com/users/ssj71","html_url":"https://github.com/ssj71","followers_url":"https://api.github.com/users/ssj71/followers","following_url":"https://api.github.com/users/ssj71/following{/other_user}","gists_url":"https://api.github.com/users/ssj71/gists{/gist_id}","starred_url":"https://api.github.com/users/ssj71/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssj71/subscriptions","organizations_url":"https://api.github.com/users/ssj71/orgs","repos_url":"https://api.github.com/users/ssj71/repos","events_url":"https://api.github.com/users/ssj71/events{/privacy}","received_events_url":"https://api.github.com/users/ssj71/received_events","type":"User","site_admin":false},"created_at":"2015-06-11T16:27:58Z","updated_at":"2015-06-11T16:27:58Z","body":"Right. I saw exactly those two places. I don't mean to criticize your code at all. I just meant more that I'd probably be looking at if it would be good to refactor those. Things are getting a bit busy at work right now so I won't get to it for a while. Its not a big deal, just me being pedantic. :)\r\n\r\nMany many thanks as always for your contributions."}}