{"action":"created","comment":{"url":"https://api.github.com/repos/fedora-infra/fedocal/pulls/comments/26567358","id":26567358,"diff_hunk":"@@ -432,6 +433,27 @@ def test_ical_meeting(self):\n         )\n         self.assertEqual(data, expected_data)\n \n+        # Test meeting iCal with reminder\n+        expected_data = self.get_sample_file_content(\n+            'meeting_with_reminder.ical').format(\n+            start_datetime=datetime.combine(\n+                meeting_obj.meeting_date,\n+                meeting_obj.meeting_time_start).strftime(\n+                    '%Y%m%dT%H%M%SZ'),\n+            end_datetime=datetime.combine(\n+                meeting_obj.meeting_date_end,\n+                meeting_obj.meeting_time_stop).strftime(\n+                    '%Y%m%dT%H%M%SZ')\n+        )\n+        output = self.app.get('/ical/calendar/meeting/2/?reminder_delta=60')","path":"tests/test_flask.py","position":26,"original_position":26,"commit_id":"b7fcaa22d4799e4a15c08d54879084bb9ad84bcf","original_commit_id":"b7fcaa22d4799e4a15c08d54879084bb9ad84bcf","user":{"login":"pypingou","id":1240038,"avatar_url":"https://avatars.githubusercontent.com/u/1240038?v=3","gravatar_id":"","url":"https://api.github.com/users/pypingou","html_url":"https://github.com/pypingou","followers_url":"https://api.github.com/users/pypingou/followers","following_url":"https://api.github.com/users/pypingou/following{/other_user}","gists_url":"https://api.github.com/users/pypingou/gists{/gist_id}","starred_url":"https://api.github.com/users/pypingou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pypingou/subscriptions","organizations_url":"https://api.github.com/users/pypingou/orgs","repos_url":"https://api.github.com/users/pypingou/repos","events_url":"https://api.github.com/users/pypingou/events{/privacy}","received_events_url":"https://api.github.com/users/pypingou/received_events","type":"User","site_admin":false},"body":"Could we test with a reminder_delta that is not an int? Also test with a reminder_delta that is not in the default choice (ie: 90)?","created_at":"2015-03-17T12:15:52Z","updated_at":"2015-03-17T12:15:52Z","html_url":"https://github.com/fedora-infra/fedocal/pull/162#discussion_r26567358","pull_request_url":"https://api.github.com/repos/fedora-infra/fedocal/pulls/162","_links":{"self":{"href":"https://api.github.com/repos/fedora-infra/fedocal/pulls/comments/26567358"},"html":{"href":"https://github.com/fedora-infra/fedocal/pull/162#discussion_r26567358"},"pull_request":{"href":"https://api.github.com/repos/fedora-infra/fedocal/pulls/162"}}},"pull_request":{"url":"https://api.github.com/repos/fedora-infra/fedocal/pulls/162","id":28217708,"html_url":"https://github.com/fedora-infra/fedocal/pull/162","diff_url":"https://github.com/fedora-infra/fedocal/pull/162.diff","patch_url":"https://github.com/fedora-infra/fedocal/pull/162.patch","issue_url":"https://api.github.com/repos/fedora-infra/fedocal/issues/162","number":162,"state":"open","locked":false,"title":"Enhance iCal file exports","user":{"login":"rtnpro","id":231684,"avatar_url":"https://avatars.githubusercontent.com/u/231684?v=3","gravatar_id":"","url":"https://api.github.com/users/rtnpro","html_url":"https://github.com/rtnpro","followers_url":"https://api.github.com/users/rtnpro/followers","following_url":"https://api.github.com/users/rtnpro/following{/other_user}","gists_url":"https://api.github.com/users/rtnpro/gists{/gist_id}","starred_url":"https://api.github.com/users/rtnpro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rtnpro/subscriptions","organizations_url":"https://api.github.com/users/rtnpro/orgs","repos_url":"https://api.github.com/users/rtnpro/repos","events_url":"https://api.github.com/users/rtnpro/events{/privacy}","received_events_url":"https://api.github.com/users/rtnpro/received_events","type":"User","site_admin":false},"body":"This branch improves export of iCal files in the following ways:\r\n- Allow export iCal file for a calendar event\r\n- Add reminder logic in iCal file\r\n- when downloading iCal info for a meeting, allow the option to add a reminder as well.\r\n\r\n``NOTE``: This is work in progress and the PR has been created for review of ongoing work.","created_at":"2015-01-28T18:36:49Z","updated_at":"2015-03-17T12:15:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"02f49ff5922e9aaf093dd720d3361485ac578389","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/fedora-infra/fedocal/pulls/162/commits","review_comments_url":"https://api.github.com/repos/fedora-infra/fedocal/pulls/162/comments","review_comment_url":"https://api.github.com/repos/fedora-infra/fedocal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fedora-infra/fedocal/issues/162/comments","statuses_url":"https://api.github.com/repos/fedora-infra/fedocal/statuses/b7fcaa22d4799e4a15c08d54879084bb9ad84bcf","head":{"label":"rtnpro:ical_enhancement","ref":"ical_enhancement","sha":"b7fcaa22d4799e4a15c08d54879084bb9ad84bcf","user":{"login":"rtnpro","id":231684,"avatar_url":"https://avatars.githubusercontent.com/u/231684?v=3","gravatar_id":"","url":"https://api.github.com/users/rtnpro","html_url":"https://github.com/rtnpro","followers_url":"https://api.github.com/users/rtnpro/followers","following_url":"https://api.github.com/users/rtnpro/following{/other_user}","gists_url":"https://api.github.com/users/rtnpro/gists{/gist_id}","starred_url":"https://api.github.com/users/rtnpro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rtnpro/subscriptions","organizations_url":"https://api.github.com/users/rtnpro/orgs","repos_url":"https://api.github.com/users/rtnpro/repos","events_url":"https://api.github.com/users/rtnpro/events{/privacy}","received_events_url":"https://api.github.com/users/rtnpro/received_events","type":"User","site_admin":false},"repo":{"id":29054751,"name":"fedocal","full_name":"rtnpro/fedocal","owner":{"login":"rtnpro","id":231684,"avatar_url":"https://avatars.githubusercontent.com/u/231684?v=3","gravatar_id":"","url":"https://api.github.com/users/rtnpro","html_url":"https://github.com/rtnpro","followers_url":"https://api.github.com/users/rtnpro/followers","following_url":"https://api.github.com/users/rtnpro/following{/other_user}","gists_url":"https://api.github.com/users/rtnpro/gists{/gist_id}","starred_url":"https://api.github.com/users/rtnpro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rtnpro/subscriptions","organizations_url":"https://api.github.com/users/rtnpro/orgs","repos_url":"https://api.github.com/users/rtnpro/repos","events_url":"https://api.github.com/users/rtnpro/events{/privacy}","received_events_url":"https://api.github.com/users/rtnpro/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rtnpro/fedocal","description":"A web based calendar application for Fedora","fork":true,"url":"https://api.github.com/repos/rtnpro/fedocal","forks_url":"https://api.github.com/repos/rtnpro/fedocal/forks","keys_url":"https://api.github.com/repos/rtnpro/fedocal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rtnpro/fedocal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rtnpro/fedocal/teams","hooks_url":"https://api.github.com/repos/rtnpro/fedocal/hooks","issue_events_url":"https://api.github.com/repos/rtnpro/fedocal/issues/events{/number}","events_url":"https://api.github.com/repos/rtnpro/fedocal/events","assignees_url":"https://api.github.com/repos/rtnpro/fedocal/assignees{/user}","branches_url":"https://api.github.com/repos/rtnpro/fedocal/branches{/branch}","tags_url":"https://api.github.com/repos/rtnpro/fedocal/tags","blobs_url":"https://api.github.com/repos/rtnpro/fedocal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rtnpro/fedocal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rtnpro/fedocal/git/refs{/sha}","trees_url":"https://api.github.com/repos/rtnpro/fedocal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rtnpro/fedocal/statuses/{sha}","languages_url":"https://api.github.com/repos/rtnpro/fedocal/languages","stargazers_url":"https://api.github.com/repos/rtnpro/fedocal/stargazers","contributors_url":"https://api.github.com/repos/rtnpro/fedocal/contributors","subscribers_url":"https://api.github.com/repos/rtnpro/fedocal/subscribers","subscription_url":"https://api.github.com/repos/rtnpro/fedocal/subscription","commits_url":"https://api.github.com/repos/rtnpro/fedocal/commits{/sha}","git_commits_url":"https://api.github.com/repos/rtnpro/fedocal/git/commits{/sha}","comments_url":"https://api.github.com/repos/rtnpro/fedocal/comments{/number}","issue_comment_url":"https://api.github.com/repos/rtnpro/fedocal/issues/comments{/number}","contents_url":"https://api.github.com/repos/rtnpro/fedocal/contents/{+path}","compare_url":"https://api.github.com/repos/rtnpro/fedocal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rtnpro/fedocal/merges","archive_url":"https://api.github.com/repos/rtnpro/fedocal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rtnpro/fedocal/downloads","issues_url":"https://api.github.com/repos/rtnpro/fedocal/issues{/number}","pulls_url":"https://api.github.com/repos/rtnpro/fedocal/pulls{/number}","milestones_url":"https://api.github.com/repos/rtnpro/fedocal/milestones{/number}","notifications_url":"https://api.github.com/repos/rtnpro/fedocal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rtnpro/fedocal/labels{/name}","releases_url":"https://api.github.com/repos/rtnpro/fedocal/releases{/id}","created_at":"2015-01-10T11:08:09Z","updated_at":"2015-01-10T11:08:10Z","pushed_at":"2015-03-06T18:52:12Z","git_url":"git://github.com/rtnpro/fedocal.git","ssh_url":"git@github.com:rtnpro/fedocal.git","clone_url":"https://github.com/rtnpro/fedocal.git","svn_url":"https://github.com/rtnpro/fedocal","homepage":"","size":2695,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fedora-infra:master","ref":"master","sha":"259c1e76db400eb82736c569f9483d25954eb4b2","user":{"login":"fedora-infra","id":3316637,"avatar_url":"https://avatars.githubusercontent.com/u/3316637?v=3","gravatar_id":"","url":"https://api.github.com/users/fedora-infra","html_url":"https://github.com/fedora-infra","followers_url":"https://api.github.com/users/fedora-infra/followers","following_url":"https://api.github.com/users/fedora-infra/following{/other_user}","gists_url":"https://api.github.com/users/fedora-infra/gists{/gist_id}","starred_url":"https://api.github.com/users/fedora-infra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fedora-infra/subscriptions","organizations_url":"https://api.github.com/users/fedora-infra/orgs","repos_url":"https://api.github.com/users/fedora-infra/repos","events_url":"https://api.github.com/users/fedora-infra/events{/privacy}","received_events_url":"https://api.github.com/users/fedora-infra/received_events","type":"Organization","site_admin":false},"repo":{"id":8959394,"name":"fedocal","full_name":"fedora-infra/fedocal","owner":{"login":"fedora-infra","id":3316637,"avatar_url":"https://avatars.githubusercontent.com/u/3316637?v=3","gravatar_id":"","url":"https://api.github.com/users/fedora-infra","html_url":"https://github.com/fedora-infra","followers_url":"https://api.github.com/users/fedora-infra/followers","following_url":"https://api.github.com/users/fedora-infra/following{/other_user}","gists_url":"https://api.github.com/users/fedora-infra/gists{/gist_id}","starred_url":"https://api.github.com/users/fedora-infra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fedora-infra/subscriptions","organizations_url":"https://api.github.com/users/fedora-infra/orgs","repos_url":"https://api.github.com/users/fedora-infra/repos","events_url":"https://api.github.com/users/fedora-infra/events{/privacy}","received_events_url":"https://api.github.com/users/fedora-infra/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fedora-infra/fedocal","description":"A web based calendar application for Fedora","fork":false,"url":"https://api.github.com/repos/fedora-infra/fedocal","forks_url":"https://api.github.com/repos/fedora-infra/fedocal/forks","keys_url":"https://api.github.com/repos/fedora-infra/fedocal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fedora-infra/fedocal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fedora-infra/fedocal/teams","hooks_url":"https://api.github.com/repos/fedora-infra/fedocal/hooks","issue_events_url":"https://api.github.com/repos/fedora-infra/fedocal/issues/events{/number}","events_url":"https://api.github.com/repos/fedora-infra/fedocal/events","assignees_url":"https://api.github.com/repos/fedora-infra/fedocal/assignees{/user}","branches_url":"https://api.github.com/repos/fedora-infra/fedocal/branches{/branch}","tags_url":"https://api.github.com/repos/fedora-infra/fedocal/tags","blobs_url":"https://api.github.com/repos/fedora-infra/fedocal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fedora-infra/fedocal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fedora-infra/fedocal/git/refs{/sha}","trees_url":"https://api.github.com/repos/fedora-infra/fedocal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fedora-infra/fedocal/statuses/{sha}","languages_url":"https://api.github.com/repos/fedora-infra/fedocal/languages","stargazers_url":"https://api.github.com/repos/fedora-infra/fedocal/stargazers","contributors_url":"https://api.github.com/repos/fedora-infra/fedocal/contributors","subscribers_url":"https://api.github.com/repos/fedora-infra/fedocal/subscribers","subscription_url":"https://api.github.com/repos/fedora-infra/fedocal/subscription","commits_url":"https://api.github.com/repos/fedora-infra/fedocal/commits{/sha}","git_commits_url":"https://api.github.com/repos/fedora-infra/fedocal/git/commits{/sha}","comments_url":"https://api.github.com/repos/fedora-infra/fedocal/comments{/number}","issue_comment_url":"https://api.github.com/repos/fedora-infra/fedocal/issues/comments{/number}","contents_url":"https://api.github.com/repos/fedora-infra/fedocal/contents/{+path}","compare_url":"https://api.github.com/repos/fedora-infra/fedocal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fedora-infra/fedocal/merges","archive_url":"https://api.github.com/repos/fedora-infra/fedocal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fedora-infra/fedocal/downloads","issues_url":"https://api.github.com/repos/fedora-infra/fedocal/issues{/number}","pulls_url":"https://api.github.com/repos/fedora-infra/fedocal/pulls{/number}","milestones_url":"https://api.github.com/repos/fedora-infra/fedocal/milestones{/number}","notifications_url":"https://api.github.com/repos/fedora-infra/fedocal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fedora-infra/fedocal/labels{/name}","releases_url":"https://api.github.com/repos/fedora-infra/fedocal/releases{/id}","created_at":"2013-03-22T19:35:10Z","updated_at":"2015-02-10T16:05:54Z","pushed_at":"2015-03-17T12:02:40Z","git_url":"git://github.com/fedora-infra/fedocal.git","ssh_url":"git@github.com:fedora-infra/fedocal.git","clone_url":"https://github.com/fedora-infra/fedocal.git","svn_url":"https://github.com/fedora-infra/fedocal","homepage":"","size":4450,"stargazers_count":6,"watchers_count":6,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":2,"forks":10,"open_issues":2,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fedora-infra/fedocal/pulls/162"},"html":{"href":"https://github.com/fedora-infra/fedocal/pull/162"},"issue":{"href":"https://api.github.com/repos/fedora-infra/fedocal/issues/162"},"comments":{"href":"https://api.github.com/repos/fedora-infra/fedocal/issues/162/comments"},"review_comments":{"href":"https://api.github.com/repos/fedora-infra/fedocal/pulls/162/comments"},"review_comment":{"href":"https://api.github.com/repos/fedora-infra/fedocal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fedora-infra/fedocal/pulls/162/commits"},"statuses":{"href":"https://api.github.com/repos/fedora-infra/fedocal/statuses/b7fcaa22d4799e4a15c08d54879084bb9ad84bcf"}}}}