{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/react-native/pulls/comments/43738594","id":43738594,"diff_hunk":"@@ -32,4 +32,17 @@ - (void)setMaximumValue:(float)maximumValue\n   super.value = _unclippedValue;\n }\n \n+-(void)setTrackImage: (NSString *) trackImageSrc\n+{\n+\n+  UIImage *sliderTrackImage = [UIImage imageNamed: trackImageSrc];\n+  NSInteger width = sliderTrackImage.size.width;\n+\n+  UIImage *sliderLeftTrackImage = [sliderTrackImage resizableImageWithCapInsets:UIEdgeInsetsMake(0, width, 0, 0)];\n+  UIImage *setMaximumTrackImage = [sliderTrackImage resizableImageWithCapInsets:UIEdgeInsetsMake(0, 0, 0, width)];","path":"React/Views/RCTSlider.m","position":11,"original_position":11,"commit_id":"3923ecd3c88df7dcdf1bcd58c44fd32e7bc6fe01","original_commit_id":"3923ecd3c88df7dcdf1bcd58c44fd32e7bc6fe01","user":{"login":"nicklockwood","id":546885,"avatar_url":"https://avatars.githubusercontent.com/u/546885?v=3","gravatar_id":"","url":"https://api.github.com/users/nicklockwood","html_url":"https://github.com/nicklockwood","followers_url":"https://api.github.com/users/nicklockwood/followers","following_url":"https://api.github.com/users/nicklockwood/following{/other_user}","gists_url":"https://api.github.com/users/nicklockwood/gists{/gist_id}","starred_url":"https://api.github.com/users/nicklockwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicklockwood/subscriptions","organizations_url":"https://api.github.com/users/nicklockwood/orgs","repos_url":"https://api.github.com/users/nicklockwood/repos","events_url":"https://api.github.com/users/nicklockwood/events{/privacy}","received_events_url":"https://api.github.com/users/nicklockwood/received_events","type":"User","site_admin":false},"body":"Wouldn't it be better to make these separate properties?","created_at":"2015-11-03T11:38:29Z","updated_at":"2015-11-03T11:38:29Z","html_url":"https://github.com/facebook/react-native/pull/3850#discussion_r43738594","pull_request_url":"https://api.github.com/repos/facebook/react-native/pulls/3850","_links":{"self":{"href":"https://api.github.com/repos/facebook/react-native/pulls/comments/43738594"},"html":{"href":"https://github.com/facebook/react-native/pull/3850#discussion_r43738594"},"pull_request":{"href":"https://api.github.com/repos/facebook/react-native/pulls/3850"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/react-native/pulls/3850","id":49515514,"html_url":"https://github.com/facebook/react-native/pull/3850","diff_url":"https://github.com/facebook/react-native/pull/3850.diff","patch_url":"https://github.com/facebook/react-native/pull/3850.patch","issue_url":"https://api.github.com/repos/facebook/react-native/issues/3850","number":3850,"state":"open","locked":false,"title":"added a property to set a track image to slider ios","user":{"login":"manask88","id":694340,"avatar_url":"https://avatars.githubusercontent.com/u/694340?v=3","gravatar_id":"","url":"https://api.github.com/users/manask88","html_url":"https://github.com/manask88","followers_url":"https://api.github.com/users/manask88/followers","following_url":"https://api.github.com/users/manask88/following{/other_user}","gists_url":"https://api.github.com/users/manask88/gists{/gist_id}","starred_url":"https://api.github.com/users/manask88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manask88/subscriptions","organizations_url":"https://api.github.com/users/manask88/orgs","repos_url":"https://api.github.com/users/manask88/repos","events_url":"https://api.github.com/users/manask88/events{/privacy}","received_events_url":"https://api.github.com/users/manask88/received_events","type":"User","site_admin":false},"body":"this change will allow the slider to have different track images.\r\n\r\nSets an image for the sliderIOS's track. It only supports images that are included as assets.","created_at":"2015-11-03T03:12:25Z","updated_at":"2015-11-03T11:38:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8c6aaa5a4067bf7cf0b8cfd9c3ab43afadf860c2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/facebook/react-native/pulls/3850/commits","review_comments_url":"https://api.github.com/repos/facebook/react-native/pulls/3850/comments","review_comment_url":"https://api.github.com/repos/facebook/react-native/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/react-native/issues/3850/comments","statuses_url":"https://api.github.com/repos/facebook/react-native/statuses/3923ecd3c88df7dcdf1bcd58c44fd32e7bc6fe01","head":{"label":"apprennet:set-track-image-sliderios","ref":"set-track-image-sliderios","sha":"3923ecd3c88df7dcdf1bcd58c44fd32e7bc6fe01","user":{"login":"apprennet","id":6934261,"avatar_url":"https://avatars.githubusercontent.com/u/6934261?v=3","gravatar_id":"","url":"https://api.github.com/users/apprennet","html_url":"https://github.com/apprennet","followers_url":"https://api.github.com/users/apprennet/followers","following_url":"https://api.github.com/users/apprennet/following{/other_user}","gists_url":"https://api.github.com/users/apprennet/gists{/gist_id}","starred_url":"https://api.github.com/users/apprennet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apprennet/subscriptions","organizations_url":"https://api.github.com/users/apprennet/orgs","repos_url":"https://api.github.com/users/apprennet/repos","events_url":"https://api.github.com/users/apprennet/events{/privacy}","received_events_url":"https://api.github.com/users/apprennet/received_events","type":"Organization","site_admin":false},"repo":{"id":43336435,"name":"react-native","full_name":"apprennet/react-native","owner":{"login":"apprennet","id":6934261,"avatar_url":"https://avatars.githubusercontent.com/u/6934261?v=3","gravatar_id":"","url":"https://api.github.com/users/apprennet","html_url":"https://github.com/apprennet","followers_url":"https://api.github.com/users/apprennet/followers","following_url":"https://api.github.com/users/apprennet/following{/other_user}","gists_url":"https://api.github.com/users/apprennet/gists{/gist_id}","starred_url":"https://api.github.com/users/apprennet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apprennet/subscriptions","organizations_url":"https://api.github.com/users/apprennet/orgs","repos_url":"https://api.github.com/users/apprennet/repos","events_url":"https://api.github.com/users/apprennet/events{/privacy}","received_events_url":"https://api.github.com/users/apprennet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apprennet/react-native","description":"A framework for building native apps with React.","fork":true,"url":"https://api.github.com/repos/apprennet/react-native","forks_url":"https://api.github.com/repos/apprennet/react-native/forks","keys_url":"https://api.github.com/repos/apprennet/react-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apprennet/react-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apprennet/react-native/teams","hooks_url":"https://api.github.com/repos/apprennet/react-native/hooks","issue_events_url":"https://api.github.com/repos/apprennet/react-native/issues/events{/number}","events_url":"https://api.github.com/repos/apprennet/react-native/events","assignees_url":"https://api.github.com/repos/apprennet/react-native/assignees{/user}","branches_url":"https://api.github.com/repos/apprennet/react-native/branches{/branch}","tags_url":"https://api.github.com/repos/apprennet/react-native/tags","blobs_url":"https://api.github.com/repos/apprennet/react-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apprennet/react-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apprennet/react-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/apprennet/react-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apprennet/react-native/statuses/{sha}","languages_url":"https://api.github.com/repos/apprennet/react-native/languages","stargazers_url":"https://api.github.com/repos/apprennet/react-native/stargazers","contributors_url":"https://api.github.com/repos/apprennet/react-native/contributors","subscribers_url":"https://api.github.com/repos/apprennet/react-native/subscribers","subscription_url":"https://api.github.com/repos/apprennet/react-native/subscription","commits_url":"https://api.github.com/repos/apprennet/react-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/apprennet/react-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/apprennet/react-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/apprennet/react-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/apprennet/react-native/contents/{+path}","compare_url":"https://api.github.com/repos/apprennet/react-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apprennet/react-native/merges","archive_url":"https://api.github.com/repos/apprennet/react-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apprennet/react-native/downloads","issues_url":"https://api.github.com/repos/apprennet/react-native/issues{/number}","pulls_url":"https://api.github.com/repos/apprennet/react-native/pulls{/number}","milestones_url":"https://api.github.com/repos/apprennet/react-native/milestones{/number}","notifications_url":"https://api.github.com/repos/apprennet/react-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apprennet/react-native/labels{/name}","releases_url":"https://api.github.com/repos/apprennet/react-native/releases{/id}","created_at":"2015-09-29T01:04:05Z","updated_at":"2015-09-29T01:04:10Z","pushed_at":"2015-11-03T03:04:51Z","git_url":"git://github.com/apprennet/react-native.git","ssh_url":"git@github.com:apprennet/react-native.git","clone_url":"https://github.com/apprennet/react-native.git","svn_url":"https://github.com/apprennet/react-native","homepage":"http://facebook.github.io/react-native/","size":28985,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"9bfadb7e1e0432079405dcd33e2deabf28e6195a","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":29028775,"name":"react-native","full_name":"facebook/react-native","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/react-native","description":"A framework for building native apps with React.","fork":false,"url":"https://api.github.com/repos/facebook/react-native","forks_url":"https://api.github.com/repos/facebook/react-native/forks","keys_url":"https://api.github.com/repos/facebook/react-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/react-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/react-native/teams","hooks_url":"https://api.github.com/repos/facebook/react-native/hooks","issue_events_url":"https://api.github.com/repos/facebook/react-native/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/react-native/events","assignees_url":"https://api.github.com/repos/facebook/react-native/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/react-native/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/react-native/tags","blobs_url":"https://api.github.com/repos/facebook/react-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/react-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/react-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/react-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/react-native/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/react-native/languages","stargazers_url":"https://api.github.com/repos/facebook/react-native/stargazers","contributors_url":"https://api.github.com/repos/facebook/react-native/contributors","subscribers_url":"https://api.github.com/repos/facebook/react-native/subscribers","subscription_url":"https://api.github.com/repos/facebook/react-native/subscription","commits_url":"https://api.github.com/repos/facebook/react-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/react-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/react-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/react-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/react-native/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/react-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/react-native/merges","archive_url":"https://api.github.com/repos/facebook/react-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/react-native/downloads","issues_url":"https://api.github.com/repos/facebook/react-native/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/react-native/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/react-native/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/react-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/react-native/labels{/name}","releases_url":"https://api.github.com/repos/facebook/react-native/releases{/id}","created_at":"2015-01-09T18:10:16Z","updated_at":"2015-11-03T11:24:37Z","pushed_at":"2015-11-03T11:25:16Z","git_url":"git://github.com/facebook/react-native.git","ssh_url":"git@github.com:facebook/react-native.git","clone_url":"https://github.com/facebook/react-native.git","svn_url":"https://github.com/facebook/react-native","homepage":"http://facebook.github.io/react-native/","size":70312,"stargazers_count":21862,"watchers_count":21862,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3351,"mirror_url":null,"open_issues_count":883,"forks":3351,"open_issues":883,"watchers":21862,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/react-native/pulls/3850"},"html":{"href":"https://github.com/facebook/react-native/pull/3850"},"issue":{"href":"https://api.github.com/repos/facebook/react-native/issues/3850"},"comments":{"href":"https://api.github.com/repos/facebook/react-native/issues/3850/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/react-native/pulls/3850/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/react-native/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/react-native/pulls/3850/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/react-native/statuses/3923ecd3c88df7dcdf1bcd58c44fd32e7bc6fe01"}}}}