{"action":"created","comment":{"url":"https://api.github.com/repos/nrc/rustfmt/pulls/comments/35255559","id":35255559,"diff_hunk":"@@ -66,6 +67,27 @@ fn idempotence_tests() {\n     assert!(fails == 0, \"{} idempotent tests failed\", fails);\n }\n \n+// Run rustfmt in tidy mode and check we don't modify the file.\n+#[test]\n+fn tidy_tests() {","path":"tests/system.rs","position":43,"original_position":43,"commit_id":"5f48d670573ed07e63b4c699dc4cf0e89cf42213","original_commit_id":"5f48d670573ed07e63b4c699dc4cf0e89cf42213","user":{"login":"marcusklaas","id":1255413,"avatar_url":"https://avatars.githubusercontent.com/u/1255413?v=3","gravatar_id":"","url":"https://api.github.com/users/marcusklaas","html_url":"https://github.com/marcusklaas","followers_url":"https://api.github.com/users/marcusklaas/followers","following_url":"https://api.github.com/users/marcusklaas/following{/other_user}","gists_url":"https://api.github.com/users/marcusklaas/gists{/gist_id}","starred_url":"https://api.github.com/users/marcusklaas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcusklaas/subscriptions","organizations_url":"https://api.github.com/users/marcusklaas/orgs","repos_url":"https://api.github.com/users/marcusklaas/repos","events_url":"https://api.github.com/users/marcusklaas/events{/privacy}","received_events_url":"https://api.github.com/users/marcusklaas/received_events","type":"User","site_admin":false},"body":"I know it's a test, but there's a lot of code duplication between this and `idempotence_tests`.","created_at":"2015-07-22T19:51:28Z","updated_at":"2015-07-22T19:51:28Z","html_url":"https://github.com/nrc/rustfmt/pull/149#discussion_r35255559","pull_request_url":"https://api.github.com/repos/nrc/rustfmt/pulls/149","_links":{"self":{"href":"https://api.github.com/repos/nrc/rustfmt/pulls/comments/35255559"},"html":{"href":"https://github.com/nrc/rustfmt/pull/149#discussion_r35255559"},"pull_request":{"href":"https://api.github.com/repos/nrc/rustfmt/pulls/149"}}},"pull_request":{"url":"https://api.github.com/repos/nrc/rustfmt/pulls/149","id":40531910,"html_url":"https://github.com/nrc/rustfmt/pull/149","diff_url":"https://github.com/nrc/rustfmt/pull/149.diff","patch_url":"https://github.com/nrc/rustfmt/pull/149.patch","issue_url":"https://api.github.com/repos/nrc/rustfmt/issues/149","number":149,"state":"open","locked":false,"title":"Features","user":{"login":"nrc","id":762626,"avatar_url":"https://avatars.githubusercontent.com/u/762626?v=3","gravatar_id":"","url":"https://api.github.com/users/nrc","html_url":"https://github.com/nrc","followers_url":"https://api.github.com/users/nrc/followers","following_url":"https://api.github.com/users/nrc/following{/other_user}","gists_url":"https://api.github.com/users/nrc/gists{/gist_id}","starred_url":"https://api.github.com/users/nrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nrc/subscriptions","organizations_url":"https://api.github.com/users/nrc/orgs","repos_url":"https://api.github.com/users/nrc/repos","events_url":"https://api.github.com/users/nrc/events{/privacy}","received_events_url":"https://api.github.com/users/nrc/received_events","type":"User","site_admin":false},"body":"The idea here is that you can define in the config file which features Rustfmt will use when formatting your files, thus avoiding using any feature which is unstable or controversial.\r\n\r\nNo feature string => use everything.\r\n\r\nr? @marcusklaas, @cassiersg \r\n\r\nThis is far from perfect. I'm not sure it can ever be perfect, and probably not without a big refactoring. This is probably necessary for adoption though. I hope that as we focus on each particular feature, we can put some effort into making it work properly. So far, I have tried to make the following subsets work well: Tidy; Tidy, Trim; Tidy, Trim, FnDecls. The rest is probably a bit wonky.\r\n\r\nThere's a bit of basic refactoring here too - mostly moving things around, I should have made it a separate commit, but this took *ages* and I've run out of energy.","created_at":"2015-07-22T05:40:33Z","updated_at":"2015-07-22T19:51:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8c1f21ec6c018e6cde62e119145fdeea9786e623","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nrc/rustfmt/pulls/149/commits","review_comments_url":"https://api.github.com/repos/nrc/rustfmt/pulls/149/comments","review_comment_url":"https://api.github.com/repos/nrc/rustfmt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nrc/rustfmt/issues/149/comments","statuses_url":"https://api.github.com/repos/nrc/rustfmt/statuses/5f48d670573ed07e63b4c699dc4cf0e89cf42213","head":{"label":"nrc:feature","ref":"feature","sha":"5f48d670573ed07e63b4c699dc4cf0e89cf42213","user":{"login":"nrc","id":762626,"avatar_url":"https://avatars.githubusercontent.com/u/762626?v=3","gravatar_id":"","url":"https://api.github.com/users/nrc","html_url":"https://github.com/nrc","followers_url":"https://api.github.com/users/nrc/followers","following_url":"https://api.github.com/users/nrc/following{/other_user}","gists_url":"https://api.github.com/users/nrc/gists{/gist_id}","starred_url":"https://api.github.com/users/nrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nrc/subscriptions","organizations_url":"https://api.github.com/users/nrc/orgs","repos_url":"https://api.github.com/users/nrc/repos","events_url":"https://api.github.com/users/nrc/events{/privacy}","received_events_url":"https://api.github.com/users/nrc/received_events","type":"User","site_admin":false},"repo":{"id":31830551,"name":"rustfmt","full_name":"nrc/rustfmt","owner":{"login":"nrc","id":762626,"avatar_url":"https://avatars.githubusercontent.com/u/762626?v=3","gravatar_id":"","url":"https://api.github.com/users/nrc","html_url":"https://github.com/nrc","followers_url":"https://api.github.com/users/nrc/followers","following_url":"https://api.github.com/users/nrc/following{/other_user}","gists_url":"https://api.github.com/users/nrc/gists{/gist_id}","starred_url":"https://api.github.com/users/nrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nrc/subscriptions","organizations_url":"https://api.github.com/users/nrc/orgs","repos_url":"https://api.github.com/users/nrc/repos","events_url":"https://api.github.com/users/nrc/events{/privacy}","received_events_url":"https://api.github.com/users/nrc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nrc/rustfmt","description":"Format Rust code","fork":false,"url":"https://api.github.com/repos/nrc/rustfmt","forks_url":"https://api.github.com/repos/nrc/rustfmt/forks","keys_url":"https://api.github.com/repos/nrc/rustfmt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nrc/rustfmt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nrc/rustfmt/teams","hooks_url":"https://api.github.com/repos/nrc/rustfmt/hooks","issue_events_url":"https://api.github.com/repos/nrc/rustfmt/issues/events{/number}","events_url":"https://api.github.com/repos/nrc/rustfmt/events","assignees_url":"https://api.github.com/repos/nrc/rustfmt/assignees{/user}","branches_url":"https://api.github.com/repos/nrc/rustfmt/branches{/branch}","tags_url":"https://api.github.com/repos/nrc/rustfmt/tags","blobs_url":"https://api.github.com/repos/nrc/rustfmt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nrc/rustfmt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nrc/rustfmt/git/refs{/sha}","trees_url":"https://api.github.com/repos/nrc/rustfmt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nrc/rustfmt/statuses/{sha}","languages_url":"https://api.github.com/repos/nrc/rustfmt/languages","stargazers_url":"https://api.github.com/repos/nrc/rustfmt/stargazers","contributors_url":"https://api.github.com/repos/nrc/rustfmt/contributors","subscribers_url":"https://api.github.com/repos/nrc/rustfmt/subscribers","subscription_url":"https://api.github.com/repos/nrc/rustfmt/subscription","commits_url":"https://api.github.com/repos/nrc/rustfmt/commits{/sha}","git_commits_url":"https://api.github.com/repos/nrc/rustfmt/git/commits{/sha}","comments_url":"https://api.github.com/repos/nrc/rustfmt/comments{/number}","issue_comment_url":"https://api.github.com/repos/nrc/rustfmt/issues/comments{/number}","contents_url":"https://api.github.com/repos/nrc/rustfmt/contents/{+path}","compare_url":"https://api.github.com/repos/nrc/rustfmt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nrc/rustfmt/merges","archive_url":"https://api.github.com/repos/nrc/rustfmt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nrc/rustfmt/downloads","issues_url":"https://api.github.com/repos/nrc/rustfmt/issues{/number}","pulls_url":"https://api.github.com/repos/nrc/rustfmt/pulls{/number}","milestones_url":"https://api.github.com/repos/nrc/rustfmt/milestones{/number}","notifications_url":"https://api.github.com/repos/nrc/rustfmt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nrc/rustfmt/labels{/name}","releases_url":"https://api.github.com/repos/nrc/rustfmt/releases{/id}","created_at":"2015-03-07T22:51:56Z","updated_at":"2015-07-21T22:52:14Z","pushed_at":"2015-07-22T05:43:07Z","git_url":"git://github.com/nrc/rustfmt.git","ssh_url":"git@github.com:nrc/rustfmt.git","clone_url":"https://github.com/nrc/rustfmt.git","svn_url":"https://github.com/nrc/rustfmt","homepage":null,"size":1012,"stargazers_count":240,"watchers_count":240,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"open_issues_count":56,"forks":33,"open_issues":56,"watchers":240,"default_branch":"master"}},"base":{"label":"nrc:master","ref":"master","sha":"8e8a5b399030c4ce6a2a16c3af3a528f26cec24f","user":{"login":"nrc","id":762626,"avatar_url":"https://avatars.githubusercontent.com/u/762626?v=3","gravatar_id":"","url":"https://api.github.com/users/nrc","html_url":"https://github.com/nrc","followers_url":"https://api.github.com/users/nrc/followers","following_url":"https://api.github.com/users/nrc/following{/other_user}","gists_url":"https://api.github.com/users/nrc/gists{/gist_id}","starred_url":"https://api.github.com/users/nrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nrc/subscriptions","organizations_url":"https://api.github.com/users/nrc/orgs","repos_url":"https://api.github.com/users/nrc/repos","events_url":"https://api.github.com/users/nrc/events{/privacy}","received_events_url":"https://api.github.com/users/nrc/received_events","type":"User","site_admin":false},"repo":{"id":31830551,"name":"rustfmt","full_name":"nrc/rustfmt","owner":{"login":"nrc","id":762626,"avatar_url":"https://avatars.githubusercontent.com/u/762626?v=3","gravatar_id":"","url":"https://api.github.com/users/nrc","html_url":"https://github.com/nrc","followers_url":"https://api.github.com/users/nrc/followers","following_url":"https://api.github.com/users/nrc/following{/other_user}","gists_url":"https://api.github.com/users/nrc/gists{/gist_id}","starred_url":"https://api.github.com/users/nrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nrc/subscriptions","organizations_url":"https://api.github.com/users/nrc/orgs","repos_url":"https://api.github.com/users/nrc/repos","events_url":"https://api.github.com/users/nrc/events{/privacy}","received_events_url":"https://api.github.com/users/nrc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nrc/rustfmt","description":"Format Rust code","fork":false,"url":"https://api.github.com/repos/nrc/rustfmt","forks_url":"https://api.github.com/repos/nrc/rustfmt/forks","keys_url":"https://api.github.com/repos/nrc/rustfmt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nrc/rustfmt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nrc/rustfmt/teams","hooks_url":"https://api.github.com/repos/nrc/rustfmt/hooks","issue_events_url":"https://api.github.com/repos/nrc/rustfmt/issues/events{/number}","events_url":"https://api.github.com/repos/nrc/rustfmt/events","assignees_url":"https://api.github.com/repos/nrc/rustfmt/assignees{/user}","branches_url":"https://api.github.com/repos/nrc/rustfmt/branches{/branch}","tags_url":"https://api.github.com/repos/nrc/rustfmt/tags","blobs_url":"https://api.github.com/repos/nrc/rustfmt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nrc/rustfmt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nrc/rustfmt/git/refs{/sha}","trees_url":"https://api.github.com/repos/nrc/rustfmt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nrc/rustfmt/statuses/{sha}","languages_url":"https://api.github.com/repos/nrc/rustfmt/languages","stargazers_url":"https://api.github.com/repos/nrc/rustfmt/stargazers","contributors_url":"https://api.github.com/repos/nrc/rustfmt/contributors","subscribers_url":"https://api.github.com/repos/nrc/rustfmt/subscribers","subscription_url":"https://api.github.com/repos/nrc/rustfmt/subscription","commits_url":"https://api.github.com/repos/nrc/rustfmt/commits{/sha}","git_commits_url":"https://api.github.com/repos/nrc/rustfmt/git/commits{/sha}","comments_url":"https://api.github.com/repos/nrc/rustfmt/comments{/number}","issue_comment_url":"https://api.github.com/repos/nrc/rustfmt/issues/comments{/number}","contents_url":"https://api.github.com/repos/nrc/rustfmt/contents/{+path}","compare_url":"https://api.github.com/repos/nrc/rustfmt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nrc/rustfmt/merges","archive_url":"https://api.github.com/repos/nrc/rustfmt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nrc/rustfmt/downloads","issues_url":"https://api.github.com/repos/nrc/rustfmt/issues{/number}","pulls_url":"https://api.github.com/repos/nrc/rustfmt/pulls{/number}","milestones_url":"https://api.github.com/repos/nrc/rustfmt/milestones{/number}","notifications_url":"https://api.github.com/repos/nrc/rustfmt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nrc/rustfmt/labels{/name}","releases_url":"https://api.github.com/repos/nrc/rustfmt/releases{/id}","created_at":"2015-03-07T22:51:56Z","updated_at":"2015-07-21T22:52:14Z","pushed_at":"2015-07-22T05:43:07Z","git_url":"git://github.com/nrc/rustfmt.git","ssh_url":"git@github.com:nrc/rustfmt.git","clone_url":"https://github.com/nrc/rustfmt.git","svn_url":"https://github.com/nrc/rustfmt","homepage":null,"size":1012,"stargazers_count":240,"watchers_count":240,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"open_issues_count":56,"forks":33,"open_issues":56,"watchers":240,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nrc/rustfmt/pulls/149"},"html":{"href":"https://github.com/nrc/rustfmt/pull/149"},"issue":{"href":"https://api.github.com/repos/nrc/rustfmt/issues/149"},"comments":{"href":"https://api.github.com/repos/nrc/rustfmt/issues/149/comments"},"review_comments":{"href":"https://api.github.com/repos/nrc/rustfmt/pulls/149/comments"},"review_comment":{"href":"https://api.github.com/repos/nrc/rustfmt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nrc/rustfmt/pulls/149/commits"},"statuses":{"href":"https://api.github.com/repos/nrc/rustfmt/statuses/5f48d670573ed07e63b4c699dc4cf0e89cf42213"}}}}