{"comment":{"url":"https://api.github.com/repos/liewegas/ceph/comments/13445339","html_url":"https://github.com/liewegas/ceph/commit/cdccf1106e453e8df933bb5fc418f4c70ba54ffc#commitcomment-13445339","id":13445339,"user":{"login":"liewegas","id":433031,"avatar_url":"https://avatars.githubusercontent.com/u/433031?v=3","gravatar_id":"","url":"https://api.github.com/users/liewegas","html_url":"https://github.com/liewegas","followers_url":"https://api.github.com/users/liewegas/followers","following_url":"https://api.github.com/users/liewegas/following{/other_user}","gists_url":"https://api.github.com/users/liewegas/gists{/gist_id}","starred_url":"https://api.github.com/users/liewegas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liewegas/subscriptions","organizations_url":"https://api.github.com/users/liewegas/orgs","repos_url":"https://api.github.com/users/liewegas/repos","events_url":"https://api.github.com/users/liewegas/events{/privacy}","received_events_url":"https://api.github.com/users/liewegas/received_events","type":"User","site_admin":false},"position":null,"line":null,"path":"","commit_id":"cdccf1106e453e8df933bb5fc418f4c70ba54ffc","created_at":"2015-09-25T19:09:26Z","updated_at":"2015-09-25T19:09:26Z","body":"On Fri, 25 Sep 2015, Kefu Chai wrote:\n\n> \n>       but post-hammer is much more careful about this sort of thing.)\n> \n> @liewegas just want to confirm with you: is the reason of this \"carefulness\" the cmp_bitwise() we are using now. which is\n> different from the tuple of <hobj, shard_id, generation> to compare the ghobjects when listing objects in a collection\n> back to hammer. am i right?\n\nSort of.  The old FileStore is sloppy about the 'next' value it returns \nwill iterating.. it sets some fields in the hobject (hash) but not all.  \nThe sort order of the fields changed, and as part of that the newer \nimplementaiton is *much* more careful about sort order, so anything \noutside the range of hobjects_t the pg covers will generally mean no items \nare returned.\n\nAs part of that series I had to update all fo the store_test.cc tests to \nuse hobject_t's inside the pgs...\n"}}