{"action":"closed","number":461,"pull_request":{"url":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls/461","id":27046056,"html_url":"https://github.com/The-Compiler/qutebrowser/pull/461","diff_url":"https://github.com/The-Compiler/qutebrowser/pull/461.diff","patch_url":"https://github.com/The-Compiler/qutebrowser/pull/461.patch","issue_url":"https://api.github.com/repos/The-Compiler/qutebrowser/issues/461","number":461,"state":"closed","locked":false,"title":"Stop the icon database from being created when private-browsing is set to true","user":{"login":"sbinix","id":10439642,"avatar_url":"https://avatars.githubusercontent.com/u/10439642?v=3","gravatar_id":"","url":"https://api.github.com/users/sbinix","html_url":"https://github.com/sbinix","followers_url":"https://api.github.com/users/sbinix/followers","following_url":"https://api.github.com/users/sbinix/following{/other_user}","gists_url":"https://api.github.com/users/sbinix/gists{/gist_id}","starred_url":"https://api.github.com/users/sbinix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbinix/subscriptions","organizations_url":"https://api.github.com/users/sbinix/orgs","repos_url":"https://api.github.com/users/sbinix/repos","events_url":"https://api.github.com/users/sbinix/events{/privacy}","received_events_url":"https://api.github.com/users/sbinix/received_events","type":"User","site_admin":false},"body":"There is a database created by QtWebkit in the cache folder called WebpageIcons.db. It has a table called PageURL, which stores a history of all visited URLs. The private-browsing setting does not stop this behaviour.  \r\n\r\nPassing a blank string to \"QWebSettings.setIconDatabasePath\" stops the creation of the icon database in the cache folder. This change should fix the problem. \r\n","created_at":"2015-01-08T17:47:54Z","updated_at":"2015-03-18T19:44:44Z","closed_at":"2015-03-18T19:44:44Z","merged_at":"2015-03-18T19:44:44Z","merge_commit_sha":"4ff6e11216224d3c0467531514ccefb4bce389b6","assignee":{"login":"The-Compiler","id":625793,"avatar_url":"https://avatars.githubusercontent.com/u/625793?v=3","gravatar_id":"","url":"https://api.github.com/users/The-Compiler","html_url":"https://github.com/The-Compiler","followers_url":"https://api.github.com/users/The-Compiler/followers","following_url":"https://api.github.com/users/The-Compiler/following{/other_user}","gists_url":"https://api.github.com/users/The-Compiler/gists{/gist_id}","starred_url":"https://api.github.com/users/The-Compiler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/The-Compiler/subscriptions","organizations_url":"https://api.github.com/users/The-Compiler/orgs","repos_url":"https://api.github.com/users/The-Compiler/repos","events_url":"https://api.github.com/users/The-Compiler/events{/privacy}","received_events_url":"https://api.github.com/users/The-Compiler/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls/461/commits","review_comments_url":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls/461/comments","review_comment_url":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls/comments{/number}","comments_url":"https://api.github.com/repos/The-Compiler/qutebrowser/issues/461/comments","statuses_url":"https://api.github.com/repos/The-Compiler/qutebrowser/statuses/969c3550cdc91d8307fdcc67abca731f32bd7b2b","head":{"label":"sbinix:master","ref":"master","sha":"969c3550cdc91d8307fdcc67abca731f32bd7b2b","user":{"login":"sbinix","id":10439642,"avatar_url":"https://avatars.githubusercontent.com/u/10439642?v=3","gravatar_id":"","url":"https://api.github.com/users/sbinix","html_url":"https://github.com/sbinix","followers_url":"https://api.github.com/users/sbinix/followers","following_url":"https://api.github.com/users/sbinix/following{/other_user}","gists_url":"https://api.github.com/users/sbinix/gists{/gist_id}","starred_url":"https://api.github.com/users/sbinix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbinix/subscriptions","organizations_url":"https://api.github.com/users/sbinix/orgs","repos_url":"https://api.github.com/users/sbinix/repos","events_url":"https://api.github.com/users/sbinix/events{/privacy}","received_events_url":"https://api.github.com/users/sbinix/received_events","type":"User","site_admin":false},"repo":{"id":28975201,"name":"qutebrowser","full_name":"sbinix/qutebrowser","owner":{"login":"sbinix","id":10439642,"avatar_url":"https://avatars.githubusercontent.com/u/10439642?v=3","gravatar_id":"","url":"https://api.github.com/users/sbinix","html_url":"https://github.com/sbinix","followers_url":"https://api.github.com/users/sbinix/followers","following_url":"https://api.github.com/users/sbinix/following{/other_user}","gists_url":"https://api.github.com/users/sbinix/gists{/gist_id}","starred_url":"https://api.github.com/users/sbinix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbinix/subscriptions","organizations_url":"https://api.github.com/users/sbinix/orgs","repos_url":"https://api.github.com/users/sbinix/repos","events_url":"https://api.github.com/users/sbinix/events{/privacy}","received_events_url":"https://api.github.com/users/sbinix/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sbinix/qutebrowser","description":"A keyboard-driven, vim-like browser based on PyQt5 and QtWebKit.","fork":true,"url":"https://api.github.com/repos/sbinix/qutebrowser","forks_url":"https://api.github.com/repos/sbinix/qutebrowser/forks","keys_url":"https://api.github.com/repos/sbinix/qutebrowser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sbinix/qutebrowser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sbinix/qutebrowser/teams","hooks_url":"https://api.github.com/repos/sbinix/qutebrowser/hooks","issue_events_url":"https://api.github.com/repos/sbinix/qutebrowser/issues/events{/number}","events_url":"https://api.github.com/repos/sbinix/qutebrowser/events","assignees_url":"https://api.github.com/repos/sbinix/qutebrowser/assignees{/user}","branches_url":"https://api.github.com/repos/sbinix/qutebrowser/branches{/branch}","tags_url":"https://api.github.com/repos/sbinix/qutebrowser/tags","blobs_url":"https://api.github.com/repos/sbinix/qutebrowser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sbinix/qutebrowser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sbinix/qutebrowser/git/refs{/sha}","trees_url":"https://api.github.com/repos/sbinix/qutebrowser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sbinix/qutebrowser/statuses/{sha}","languages_url":"https://api.github.com/repos/sbinix/qutebrowser/languages","stargazers_url":"https://api.github.com/repos/sbinix/qutebrowser/stargazers","contributors_url":"https://api.github.com/repos/sbinix/qutebrowser/contributors","subscribers_url":"https://api.github.com/repos/sbinix/qutebrowser/subscribers","subscription_url":"https://api.github.com/repos/sbinix/qutebrowser/subscription","commits_url":"https://api.github.com/repos/sbinix/qutebrowser/commits{/sha}","git_commits_url":"https://api.github.com/repos/sbinix/qutebrowser/git/commits{/sha}","comments_url":"https://api.github.com/repos/sbinix/qutebrowser/comments{/number}","issue_comment_url":"https://api.github.com/repos/sbinix/qutebrowser/issues/comments{/number}","contents_url":"https://api.github.com/repos/sbinix/qutebrowser/contents/{+path}","compare_url":"https://api.github.com/repos/sbinix/qutebrowser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sbinix/qutebrowser/merges","archive_url":"https://api.github.com/repos/sbinix/qutebrowser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sbinix/qutebrowser/downloads","issues_url":"https://api.github.com/repos/sbinix/qutebrowser/issues{/number}","pulls_url":"https://api.github.com/repos/sbinix/qutebrowser/pulls{/number}","milestones_url":"https://api.github.com/repos/sbinix/qutebrowser/milestones{/number}","notifications_url":"https://api.github.com/repos/sbinix/qutebrowser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sbinix/qutebrowser/labels{/name}","releases_url":"https://api.github.com/repos/sbinix/qutebrowser/releases{/id}","created_at":"2015-01-08T16:40:25Z","updated_at":"2015-01-09T23:25:53Z","pushed_at":"2015-01-09T23:25:53Z","git_url":"git://github.com/sbinix/qutebrowser.git","ssh_url":"git@github.com:sbinix/qutebrowser.git","clone_url":"https://github.com/sbinix/qutebrowser.git","svn_url":"https://github.com/sbinix/qutebrowser","homepage":null,"size":4310,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"The-Compiler:master","ref":"master","sha":"77df4c72414dd10a5c99ee390ff941d44ca9eae5","user":{"login":"The-Compiler","id":625793,"avatar_url":"https://avatars.githubusercontent.com/u/625793?v=3","gravatar_id":"","url":"https://api.github.com/users/The-Compiler","html_url":"https://github.com/The-Compiler","followers_url":"https://api.github.com/users/The-Compiler/followers","following_url":"https://api.github.com/users/The-Compiler/following{/other_user}","gists_url":"https://api.github.com/users/The-Compiler/gists{/gist_id}","starred_url":"https://api.github.com/users/The-Compiler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/The-Compiler/subscriptions","organizations_url":"https://api.github.com/users/The-Compiler/orgs","repos_url":"https://api.github.com/users/The-Compiler/repos","events_url":"https://api.github.com/users/The-Compiler/events{/privacy}","received_events_url":"https://api.github.com/users/The-Compiler/received_events","type":"User","site_admin":false},"repo":{"id":21244505,"name":"qutebrowser","full_name":"The-Compiler/qutebrowser","owner":{"login":"The-Compiler","id":625793,"avatar_url":"https://avatars.githubusercontent.com/u/625793?v=3","gravatar_id":"","url":"https://api.github.com/users/The-Compiler","html_url":"https://github.com/The-Compiler","followers_url":"https://api.github.com/users/The-Compiler/followers","following_url":"https://api.github.com/users/The-Compiler/following{/other_user}","gists_url":"https://api.github.com/users/The-Compiler/gists{/gist_id}","starred_url":"https://api.github.com/users/The-Compiler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/The-Compiler/subscriptions","organizations_url":"https://api.github.com/users/The-Compiler/orgs","repos_url":"https://api.github.com/users/The-Compiler/repos","events_url":"https://api.github.com/users/The-Compiler/events{/privacy}","received_events_url":"https://api.github.com/users/The-Compiler/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/The-Compiler/qutebrowser","description":"A keyboard-driven, vim-like browser based on PyQt5 and QtWebKit.","fork":false,"url":"https://api.github.com/repos/The-Compiler/qutebrowser","forks_url":"https://api.github.com/repos/The-Compiler/qutebrowser/forks","keys_url":"https://api.github.com/repos/The-Compiler/qutebrowser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/The-Compiler/qutebrowser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/The-Compiler/qutebrowser/teams","hooks_url":"https://api.github.com/repos/The-Compiler/qutebrowser/hooks","issue_events_url":"https://api.github.com/repos/The-Compiler/qutebrowser/issues/events{/number}","events_url":"https://api.github.com/repos/The-Compiler/qutebrowser/events","assignees_url":"https://api.github.com/repos/The-Compiler/qutebrowser/assignees{/user}","branches_url":"https://api.github.com/repos/The-Compiler/qutebrowser/branches{/branch}","tags_url":"https://api.github.com/repos/The-Compiler/qutebrowser/tags","blobs_url":"https://api.github.com/repos/The-Compiler/qutebrowser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/The-Compiler/qutebrowser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/The-Compiler/qutebrowser/git/refs{/sha}","trees_url":"https://api.github.com/repos/The-Compiler/qutebrowser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/The-Compiler/qutebrowser/statuses/{sha}","languages_url":"https://api.github.com/repos/The-Compiler/qutebrowser/languages","stargazers_url":"https://api.github.com/repos/The-Compiler/qutebrowser/stargazers","contributors_url":"https://api.github.com/repos/The-Compiler/qutebrowser/contributors","subscribers_url":"https://api.github.com/repos/The-Compiler/qutebrowser/subscribers","subscription_url":"https://api.github.com/repos/The-Compiler/qutebrowser/subscription","commits_url":"https://api.github.com/repos/The-Compiler/qutebrowser/commits{/sha}","git_commits_url":"https://api.github.com/repos/The-Compiler/qutebrowser/git/commits{/sha}","comments_url":"https://api.github.com/repos/The-Compiler/qutebrowser/comments{/number}","issue_comment_url":"https://api.github.com/repos/The-Compiler/qutebrowser/issues/comments{/number}","contents_url":"https://api.github.com/repos/The-Compiler/qutebrowser/contents/{+path}","compare_url":"https://api.github.com/repos/The-Compiler/qutebrowser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/The-Compiler/qutebrowser/merges","archive_url":"https://api.github.com/repos/The-Compiler/qutebrowser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/The-Compiler/qutebrowser/downloads","issues_url":"https://api.github.com/repos/The-Compiler/qutebrowser/issues{/number}","pulls_url":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls{/number}","milestones_url":"https://api.github.com/repos/The-Compiler/qutebrowser/milestones{/number}","notifications_url":"https://api.github.com/repos/The-Compiler/qutebrowser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/The-Compiler/qutebrowser/labels{/name}","releases_url":"https://api.github.com/repos/The-Compiler/qutebrowser/releases{/id}","created_at":"2014-06-26T14:59:34Z","updated_at":"2015-03-18T13:21:30Z","pushed_at":"2015-03-18T19:44:43Z","git_url":"git://github.com/The-Compiler/qutebrowser.git","ssh_url":"git@github.com:The-Compiler/qutebrowser.git","clone_url":"https://github.com/The-Compiler/qutebrowser.git","svn_url":"https://github.com/The-Compiler/qutebrowser","homepage":null,"size":9251,"stargazers_count":490,"watchers_count":490,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":51,"mirror_url":null,"open_issues_count":205,"forks":51,"open_issues":205,"watchers":490,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls/461"},"html":{"href":"https://github.com/The-Compiler/qutebrowser/pull/461"},"issue":{"href":"https://api.github.com/repos/The-Compiler/qutebrowser/issues/461"},"comments":{"href":"https://api.github.com/repos/The-Compiler/qutebrowser/issues/461/comments"},"review_comments":{"href":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls/461/comments"},"review_comment":{"href":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls/461/commits"},"statuses":{"href":"https://api.github.com/repos/The-Compiler/qutebrowser/statuses/969c3550cdc91d8307fdcc67abca731f32bd7b2b"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"The-Compiler","id":625793,"avatar_url":"https://avatars.githubusercontent.com/u/625793?v=3","gravatar_id":"","url":"https://api.github.com/users/The-Compiler","html_url":"https://github.com/The-Compiler","followers_url":"https://api.github.com/users/The-Compiler/followers","following_url":"https://api.github.com/users/The-Compiler/following{/other_user}","gists_url":"https://api.github.com/users/The-Compiler/gists{/gist_id}","starred_url":"https://api.github.com/users/The-Compiler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/The-Compiler/subscriptions","organizations_url":"https://api.github.com/users/The-Compiler/orgs","repos_url":"https://api.github.com/users/The-Compiler/repos","events_url":"https://api.github.com/users/The-Compiler/events{/privacy}","received_events_url":"https://api.github.com/users/The-Compiler/received_events","type":"User","site_admin":false},"comments":14,"review_comments":0,"commits":3,"additions":4,"deletions":1,"changed_files":1}}