{"action":"created","comment":{"url":"https://api.github.com/repos/ldionne/hana/pulls/comments/38380816","id":38380816,"diff_hunk":"@@ -0,0 +1,64 @@\n+# Copyright Louis Dionne 2015","path":"cmake/CheckCxxCompilerCompatibility.cmake","position":1,"original_position":1,"commit_id":"e66cb6cdd1b7358bf39560bfc481d733170de40f","original_commit_id":"e66cb6cdd1b7358bf39560bfc481d733170de40f","user":{"login":"ldionne","id":700834,"avatar_url":"https://avatars.githubusercontent.com/u/700834?v=3","gravatar_id":"","url":"https://api.github.com/users/ldionne","html_url":"https://github.com/ldionne","followers_url":"https://api.github.com/users/ldionne/followers","following_url":"https://api.github.com/users/ldionne/following{/other_user}","gists_url":"https://api.github.com/users/ldionne/gists{/gist_id}","starred_url":"https://api.github.com/users/ldionne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldionne/subscriptions","organizations_url":"https://api.github.com/users/ldionne/orgs","repos_url":"https://api.github.com/users/ldionne/repos","events_url":"https://api.github.com/users/ldionne/events{/privacy}","received_events_url":"https://api.github.com/users/ldionne/received_events","type":"User","site_admin":false},"body":"You probably want your name there, not mine (x3).","created_at":"2015-09-01T02:32:22Z","updated_at":"2015-09-01T02:32:22Z","html_url":"https://github.com/ldionne/hana/pull/168#discussion_r38380816","pull_request_url":"https://api.github.com/repos/ldionne/hana/pulls/168","_links":{"self":{"href":"https://api.github.com/repos/ldionne/hana/pulls/comments/38380816"},"html":{"href":"https://github.com/ldionne/hana/pull/168#discussion_r38380816"},"pull_request":{"href":"https://api.github.com/repos/ldionne/hana/pulls/168"}}},"pull_request":{"url":"https://api.github.com/repos/ldionne/hana/pulls/168","id":43824484,"html_url":"https://github.com/ldionne/hana/pull/168","diff_url":"https://github.com/ldionne/hana/pull/168.diff","patch_url":"https://github.com/ldionne/hana/pull/168.patch","issue_url":"https://api.github.com/repos/ldionne/hana/issues/168","number":168,"state":"open","locked":false,"title":"[Build] Check C++ ABI and exception issues with Clang/GCC on Cygwin","user":{"login":"m-j-w","id":14040010,"avatar_url":"https://avatars.githubusercontent.com/u/14040010?v=3","gravatar_id":"","url":"https://api.github.com/users/m-j-w","html_url":"https://github.com/m-j-w","followers_url":"https://api.github.com/users/m-j-w/followers","following_url":"https://api.github.com/users/m-j-w/following{/other_user}","gists_url":"https://api.github.com/users/m-j-w/gists{/gist_id}","starred_url":"https://api.github.com/users/m-j-w/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m-j-w/subscriptions","organizations_url":"https://api.github.com/users/m-j-w/orgs","repos_url":"https://api.github.com/users/m-j-w/repos","events_url":"https://api.github.com/users/m-j-w/events{/privacy}","received_events_url":"https://api.github.com/users/m-j-w/received_events","type":"User","site_admin":false},"body":"Fixes  #167\r\n\r\n- Check whether compiler supports and successfully compiles with exceptions.\r\n- Check whether the provided stdlib has C++14 type traits fully implemented.\r\n- Perform some compiler version checks in cmake and give hints to the user.\r\n\r\nBoth errors occured on Cygwin using Clang 3.5.2 with libstdc++ from GCC\r\n4.9.3. However, Clang may also use the GCC stdlib on other systems, like\r\nLinux Mint.\r\nThe error with exceptions is also expected to occure on MSYS2 and maybe\r\nWindows, since Clang seems to have general problems there.\r\n\r\nUnfortunately, the incomplete stdlib is supposedly not detectable from within\r\nthe compilation. Thus a test is created which may fail during compilation.\r\nIf so, an additional symbol is defined to handle the issue:\r\nBOOST_HANA_CXX_INCOMPLETE_STDLIB\r\n\r\nAvailability of exceptions is tested with the existance of __EXCEPTIONS, and\r\nhandled accordingly. Instead of throw, a assert(false) or abort() comes to mind.\r\n\r\nLastly, the cmake cygwin warning message is deactivated in CMakeLists.txt,\r\nand the main include <boost/hana/hana.hpp> checks the C++ standard to be\r\nat least C++14 or raises an error otherwise. Should give beginners a valuable\r\nhint on what is going wrong...\r\n\r\nA side note for other Cygwin/MinGW/MSYS2 users: Compile with Clang or\r\nGCC with static binding of (both) standard libs using \r\n     -static-libgcc -static-libstdc++\r\nMakes your life a lot easier.\r\n\r\nRemaining issues are some non-compiling tests and examples. These have been\r\nremoved from the build on Cygwin. The reason may also be the incomplete stlib.\r\nSee test/CMakeLists.txt and example/CMakeLists.txt\r\n\r\nTested on\r\n- Cygwin/Clang 3.5.2/libstdc++ of gcc 4.9.3 w/o exceptions (success)\r\n- Cygwin/Clang 3.5.2/libstdc++ of gcc 4.9.3 w/ exceptions (failure, but captured)\r\n- Cygwin/GCC 4.9.3/libstdc++ of gcc 4.9.3 (failure, as expected)\r\n- Linux Mint/Clang 3.6.0/libstdc++ of gcc 4.8.4 (failure, as expected)\r\n- Linux Mint/Clang 3.6.0/libc++ of clang 3.6.0 w/ exceptions (success)\r\n- Linux Mint/gcc 4.8.4/libstdc++ of gcc 4.8.4 (uncaptured failure, as expected)","created_at":"2015-09-01T00:04:49Z","updated_at":"2015-09-01T02:32:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"51ba94fbd2eeadfedcf1bc9a4b37a3715424ac78","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ldionne/hana/pulls/168/commits","review_comments_url":"https://api.github.com/repos/ldionne/hana/pulls/168/comments","review_comment_url":"https://api.github.com/repos/ldionne/hana/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ldionne/hana/issues/168/comments","statuses_url":"https://api.github.com/repos/ldionne/hana/statuses/e66cb6cdd1b7358bf39560bfc481d733170de40f","head":{"label":"m-j-w:bugfix/cygwin","ref":"bugfix/cygwin","sha":"e66cb6cdd1b7358bf39560bfc481d733170de40f","user":{"login":"m-j-w","id":14040010,"avatar_url":"https://avatars.githubusercontent.com/u/14040010?v=3","gravatar_id":"","url":"https://api.github.com/users/m-j-w","html_url":"https://github.com/m-j-w","followers_url":"https://api.github.com/users/m-j-w/followers","following_url":"https://api.github.com/users/m-j-w/following{/other_user}","gists_url":"https://api.github.com/users/m-j-w/gists{/gist_id}","starred_url":"https://api.github.com/users/m-j-w/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m-j-w/subscriptions","organizations_url":"https://api.github.com/users/m-j-w/orgs","repos_url":"https://api.github.com/users/m-j-w/repos","events_url":"https://api.github.com/users/m-j-w/events{/privacy}","received_events_url":"https://api.github.com/users/m-j-w/received_events","type":"User","site_admin":false},"repo":{"id":41688174,"name":"hana","full_name":"m-j-w/hana","owner":{"login":"m-j-w","id":14040010,"avatar_url":"https://avatars.githubusercontent.com/u/14040010?v=3","gravatar_id":"","url":"https://api.github.com/users/m-j-w","html_url":"https://github.com/m-j-w","followers_url":"https://api.github.com/users/m-j-w/followers","following_url":"https://api.github.com/users/m-j-w/following{/other_user}","gists_url":"https://api.github.com/users/m-j-w/gists{/gist_id}","starred_url":"https://api.github.com/users/m-j-w/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m-j-w/subscriptions","organizations_url":"https://api.github.com/users/m-j-w/orgs","repos_url":"https://api.github.com/users/m-j-w/repos","events_url":"https://api.github.com/users/m-j-w/events{/privacy}","received_events_url":"https://api.github.com/users/m-j-w/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/m-j-w/hana","description":"Your standard library for metaprogramming","fork":true,"url":"https://api.github.com/repos/m-j-w/hana","forks_url":"https://api.github.com/repos/m-j-w/hana/forks","keys_url":"https://api.github.com/repos/m-j-w/hana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/m-j-w/hana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/m-j-w/hana/teams","hooks_url":"https://api.github.com/repos/m-j-w/hana/hooks","issue_events_url":"https://api.github.com/repos/m-j-w/hana/issues/events{/number}","events_url":"https://api.github.com/repos/m-j-w/hana/events","assignees_url":"https://api.github.com/repos/m-j-w/hana/assignees{/user}","branches_url":"https://api.github.com/repos/m-j-w/hana/branches{/branch}","tags_url":"https://api.github.com/repos/m-j-w/hana/tags","blobs_url":"https://api.github.com/repos/m-j-w/hana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/m-j-w/hana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/m-j-w/hana/git/refs{/sha}","trees_url":"https://api.github.com/repos/m-j-w/hana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/m-j-w/hana/statuses/{sha}","languages_url":"https://api.github.com/repos/m-j-w/hana/languages","stargazers_url":"https://api.github.com/repos/m-j-w/hana/stargazers","contributors_url":"https://api.github.com/repos/m-j-w/hana/contributors","subscribers_url":"https://api.github.com/repos/m-j-w/hana/subscribers","subscription_url":"https://api.github.com/repos/m-j-w/hana/subscription","commits_url":"https://api.github.com/repos/m-j-w/hana/commits{/sha}","git_commits_url":"https://api.github.com/repos/m-j-w/hana/git/commits{/sha}","comments_url":"https://api.github.com/repos/m-j-w/hana/comments{/number}","issue_comment_url":"https://api.github.com/repos/m-j-w/hana/issues/comments{/number}","contents_url":"https://api.github.com/repos/m-j-w/hana/contents/{+path}","compare_url":"https://api.github.com/repos/m-j-w/hana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/m-j-w/hana/merges","archive_url":"https://api.github.com/repos/m-j-w/hana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/m-j-w/hana/downloads","issues_url":"https://api.github.com/repos/m-j-w/hana/issues{/number}","pulls_url":"https://api.github.com/repos/m-j-w/hana/pulls{/number}","milestones_url":"https://api.github.com/repos/m-j-w/hana/milestones{/number}","notifications_url":"https://api.github.com/repos/m-j-w/hana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/m-j-w/hana/labels{/name}","releases_url":"https://api.github.com/repos/m-j-w/hana/releases{/id}","created_at":"2015-08-31T16:48:12Z","updated_at":"2015-08-31T16:48:14Z","pushed_at":"2015-08-31T23:59:02Z","git_url":"git://github.com/m-j-w/hana.git","ssh_url":"git@github.com:m-j-w/hana.git","clone_url":"https://github.com/m-j-w/hana.git","svn_url":"https://github.com/m-j-w/hana","homepage":"http://ldionne.github.io/hana","size":28399,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ldionne:develop","ref":"develop","sha":"6f2def29c07361f90138a5f3faa07ebb3977f2a0","user":{"login":"ldionne","id":700834,"avatar_url":"https://avatars.githubusercontent.com/u/700834?v=3","gravatar_id":"","url":"https://api.github.com/users/ldionne","html_url":"https://github.com/ldionne","followers_url":"https://api.github.com/users/ldionne/followers","following_url":"https://api.github.com/users/ldionne/following{/other_user}","gists_url":"https://api.github.com/users/ldionne/gists{/gist_id}","starred_url":"https://api.github.com/users/ldionne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldionne/subscriptions","organizations_url":"https://api.github.com/users/ldionne/orgs","repos_url":"https://api.github.com/users/ldionne/repos","events_url":"https://api.github.com/users/ldionne/events{/privacy}","received_events_url":"https://api.github.com/users/ldionne/received_events","type":"User","site_admin":false},"repo":{"id":19887998,"name":"hana","full_name":"ldionne/hana","owner":{"login":"ldionne","id":700834,"avatar_url":"https://avatars.githubusercontent.com/u/700834?v=3","gravatar_id":"","url":"https://api.github.com/users/ldionne","html_url":"https://github.com/ldionne","followers_url":"https://api.github.com/users/ldionne/followers","following_url":"https://api.github.com/users/ldionne/following{/other_user}","gists_url":"https://api.github.com/users/ldionne/gists{/gist_id}","starred_url":"https://api.github.com/users/ldionne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldionne/subscriptions","organizations_url":"https://api.github.com/users/ldionne/orgs","repos_url":"https://api.github.com/users/ldionne/repos","events_url":"https://api.github.com/users/ldionne/events{/privacy}","received_events_url":"https://api.github.com/users/ldionne/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ldionne/hana","description":"Your standard library for metaprogramming","fork":false,"url":"https://api.github.com/repos/ldionne/hana","forks_url":"https://api.github.com/repos/ldionne/hana/forks","keys_url":"https://api.github.com/repos/ldionne/hana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ldionne/hana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ldionne/hana/teams","hooks_url":"https://api.github.com/repos/ldionne/hana/hooks","issue_events_url":"https://api.github.com/repos/ldionne/hana/issues/events{/number}","events_url":"https://api.github.com/repos/ldionne/hana/events","assignees_url":"https://api.github.com/repos/ldionne/hana/assignees{/user}","branches_url":"https://api.github.com/repos/ldionne/hana/branches{/branch}","tags_url":"https://api.github.com/repos/ldionne/hana/tags","blobs_url":"https://api.github.com/repos/ldionne/hana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ldionne/hana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ldionne/hana/git/refs{/sha}","trees_url":"https://api.github.com/repos/ldionne/hana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ldionne/hana/statuses/{sha}","languages_url":"https://api.github.com/repos/ldionne/hana/languages","stargazers_url":"https://api.github.com/repos/ldionne/hana/stargazers","contributors_url":"https://api.github.com/repos/ldionne/hana/contributors","subscribers_url":"https://api.github.com/repos/ldionne/hana/subscribers","subscription_url":"https://api.github.com/repos/ldionne/hana/subscription","commits_url":"https://api.github.com/repos/ldionne/hana/commits{/sha}","git_commits_url":"https://api.github.com/repos/ldionne/hana/git/commits{/sha}","comments_url":"https://api.github.com/repos/ldionne/hana/comments{/number}","issue_comment_url":"https://api.github.com/repos/ldionne/hana/issues/comments{/number}","contents_url":"https://api.github.com/repos/ldionne/hana/contents/{+path}","compare_url":"https://api.github.com/repos/ldionne/hana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ldionne/hana/merges","archive_url":"https://api.github.com/repos/ldionne/hana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ldionne/hana/downloads","issues_url":"https://api.github.com/repos/ldionne/hana/issues{/number}","pulls_url":"https://api.github.com/repos/ldionne/hana/pulls{/number}","milestones_url":"https://api.github.com/repos/ldionne/hana/milestones{/number}","notifications_url":"https://api.github.com/repos/ldionne/hana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ldionne/hana/labels{/name}","releases_url":"https://api.github.com/repos/ldionne/hana/releases{/id}","created_at":"2014-05-17T14:06:06Z","updated_at":"2015-08-31T16:38:12Z","pushed_at":"2015-09-01T02:29:00Z","git_url":"git://github.com/ldionne/hana.git","ssh_url":"git@github.com:ldionne/hana.git","clone_url":"https://github.com/ldionne/hana.git","svn_url":"https://github.com/ldionne/hana","homepage":"http://ldionne.github.io/hana","size":28399,"stargazers_count":231,"watchers_count":231,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":29,"mirror_url":null,"open_issues_count":54,"forks":29,"open_issues":54,"watchers":231,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ldionne/hana/pulls/168"},"html":{"href":"https://github.com/ldionne/hana/pull/168"},"issue":{"href":"https://api.github.com/repos/ldionne/hana/issues/168"},"comments":{"href":"https://api.github.com/repos/ldionne/hana/issues/168/comments"},"review_comments":{"href":"https://api.github.com/repos/ldionne/hana/pulls/168/comments"},"review_comment":{"href":"https://api.github.com/repos/ldionne/hana/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ldionne/hana/pulls/168/commits"},"statuses":{"href":"https://api.github.com/repos/ldionne/hana/statuses/e66cb6cdd1b7358bf39560bfc481d733170de40f"}}}}