{"comment":{"url":"https://api.github.com/repos/alphagov/cf-terraform/comments/14906342","html_url":"https://github.com/alphagov/cf-terraform/commit/ac699df2f45ce0a9ad3926acb83ec3e4008661b3#commitcomment-14906342","id":14906342,"user":{"login":"mtekel","id":483891,"avatar_url":"https://avatars.githubusercontent.com/u/483891?v=3","gravatar_id":"","url":"https://api.github.com/users/mtekel","html_url":"https://github.com/mtekel","followers_url":"https://api.github.com/users/mtekel/followers","following_url":"https://api.github.com/users/mtekel/following{/other_user}","gists_url":"https://api.github.com/users/mtekel/gists{/gist_id}","starred_url":"https://api.github.com/users/mtekel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtekel/subscriptions","organizations_url":"https://api.github.com/users/mtekel/orgs","repos_url":"https://api.github.com/users/mtekel/repos","events_url":"https://api.github.com/users/mtekel/events{/privacy}","received_events_url":"https://api.github.com/users/mtekel/received_events","type":"User","site_admin":false},"position":null,"line":null,"path":"","commit_id":"ac699df2f45ce0a9ad3926acb83ec3e4008661b3","created_at":"2015-12-10T17:43:01Z","updated_at":"2015-12-10T17:43:01Z","body":"This works. Yet I think we should also check if the job IP doesn't fit into reserved IP or outside of static IPs:\r\n```\r\n- name: cf1\r\n  subnets:\r\n  - cloud_properties:\r\n      security_groups:\r\n      - cf\r\n      subnet: subnet-12345678\r\n    dns:\r\n    - 10.10.0.2\r\n    gateway: 10.10.16.1\r\n    range: 10.10.16.0/20\r\n    reserved:\r\n    - 10.10.16.2 - 10.10.16.9\r\n    static:\r\n    - 10.10.16.10 - 10.10.16.255\r\n```\r\ne.g. 10.10.30.10 passes test, but is outside both static and reserved. Nevertheless, spruce already ensures correct IP computation, so it won't let you have IP outside static..."}}