{"push_id":882606837,"size":2,"distinct_size":2,"ref":"refs/heads/ls/test-must-fail-sigpipe","head":"8bf4becf0c1e4b4ca56dab3501f9cd3da3362215","before":"2f9dfe4eda4d6aeed681059c99a684698603a1d0","commits":[{"sha":"bbfe5302d50891233cef645b74324c01d8b004c8","author":{"email":"5a28c51a1a2fd940035a2c87b954b4548c87165f@gmail.com","name":"Lars Schneider"},"message":"implement test_might_fail using a refactored test_must_fail\n\nAdd an (optional) first parameter \"ok=<special case>\" to test_must_fail\nand return success for \"<special case>\". Add \"success\" as\n\"<special case>\" and use it to implement \"test_might_fail\". This removes\nredundancies in test-lib-function.sh.\n\nYou can pass multiple <special case> arguments divided by comma (e.g.\n\"test_must_fail ok=success,something\")\n\nSigned-off-by: Junio C Hamano <gitster@pobox.com>\nSigned-off-by: Lars Schneider <larsxschneider@gmail.com>\nSigned-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>\nSigned-off-by: Jeff King <peff@peff.net>","distinct":true,"url":"https://api.github.com/repos/peff/git/commits/bbfe5302d50891233cef645b74324c01d8b004c8"},{"sha":"8bf4becf0c1e4b4ca56dab3501f9cd3da3362215","author":{"email":"5a28c51a1a2fd940035a2c87b954b4548c87165f@gmail.com","name":"Lars Schneider"},"message":"add \"ok=sigpipe\" to test_must_fail and use it to fix flaky tests\n\nt5516 \"75 - deny fetch unreachable SHA1, allowtipsha1inwant=true\" is\nflaky in the following case:\n1. remote upload-pack finds out \"not our ref\"\n2. remote sends a response and closes the pipe\n3. fetch-pack still tries to write commands to the remote upload-pack\n4. write call in wrapper.c dies with SIGPIPE\n\nThe test is flaky because the sending fetch-pack may or may\nnot have finished writing its output by step (3). If it did,\nthen we see a closed pipe on the next read() call. If it\ndidn't, then we get the SIGPIPE from step (4) above. Both\nare fine, but the latter fools test_must_fail.\n\nt5504 \"9 - push with transfer.fsckobjects\" is flaky, too, and returns\nSIGPIPE once in a while. I had to remove the final \"To dst...\" output\ncheck because there is no output if the process dies with SIGPIPE.\n\nAccept such a death-with-sigpipe also as OK when we are expecting a\nfailure.\n\nSigned-off-by: Lars Schneider <larsxschneider@gmail.com>\nSigned-off-by: Jeff King <peff@peff.net>","distinct":true,"url":"https://api.github.com/repos/peff/git/commits/8bf4becf0c1e4b4ca56dab3501f9cd3da3362215"}]}