{"action":"opened","number":14315,"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/14315","id":33100526,"html_url":"https://github.com/symfony/symfony/pull/14315","diff_url":"https://github.com/symfony/symfony/pull/14315.diff","patch_url":"https://github.com/symfony/symfony/pull/14315.patch","issue_url":"https://api.github.com/repos/symfony/symfony/issues/14315","number":14315,"state":"open","locked":false,"title":"[Translator] getCatalogue() inconsistency when cache comes into play","user":{"login":"mpdude","id":1202333,"avatar_url":"https://avatars.githubusercontent.com/u/1202333?v=3","gravatar_id":"","url":"https://api.github.com/users/mpdude","html_url":"https://github.com/mpdude","followers_url":"https://api.github.com/users/mpdude/followers","following_url":"https://api.github.com/users/mpdude/following{/other_user}","gists_url":"https://api.github.com/users/mpdude/gists{/gist_id}","starred_url":"https://api.github.com/users/mpdude/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpdude/subscriptions","organizations_url":"https://api.github.com/users/mpdude/orgs","repos_url":"https://api.github.com/users/mpdude/repos","events_url":"https://api.github.com/users/mpdude/events{/privacy}","received_events_url":"https://api.github.com/users/mpdude/received_events","type":"User","site_admin":false},"body":"The results from `getCatalogue()` are inconsistent when we're in production *and* a cache comes into play.\r\n\r\nThis is due to the changes in 6eb5e7395cfb631240804319645b4592cf4fff8f, where the fallback catalogues will be *merged* into the primary catalogue when it is written to the cache.\r\n\r\nStrictly speaking, this is a BC break because it behaved differently before.\r\n\r\nI am not sure what the relevance of this might be in practice.\r\n\r\nHowever, it might be a pain because \r\n* The result changes only in the second+ try (when the cache is warm)\r\n* The catalogue is clearly not what the loader provided\r\n* You have no chance of telling whether the message was originally available in the catalogue or not\r\n* Generally, for every message you retrieve from the catalogue, you have no way of telling which locale it actually comes from\r\n\r\nRegarding the last point, you usually don't care when using the `Translator`. Its purpose is to get the \"best\" translation available. However, when you bother to explicitly retrieve the catalogue, chances are your intentions are different.\r\n\r\n","created_at":"2015-04-11T09:14:42Z","updated_at":"2015-04-11T09:14:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1adca1cab5acaad148f5b238f9150e5e5057529b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/symfony/symfony/pulls/14315/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony/pulls/14315/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/14315/comments","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/7503f2acfac3b477915301505dd7179c4db4190f","head":{"label":"webfactory:translator-get-catalogue-inconsistent","ref":"translator-get-catalogue-inconsistent","sha":"7503f2acfac3b477915301505dd7179c4db4190f","user":{"login":"webfactory","id":135788,"avatar_url":"https://avatars.githubusercontent.com/u/135788?v=3","gravatar_id":"","url":"https://api.github.com/users/webfactory","html_url":"https://github.com/webfactory","followers_url":"https://api.github.com/users/webfactory/followers","following_url":"https://api.github.com/users/webfactory/following{/other_user}","gists_url":"https://api.github.com/users/webfactory/gists{/gist_id}","starred_url":"https://api.github.com/users/webfactory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webfactory/subscriptions","organizations_url":"https://api.github.com/users/webfactory/orgs","repos_url":"https://api.github.com/users/webfactory/repos","events_url":"https://api.github.com/users/webfactory/events{/privacy}","received_events_url":"https://api.github.com/users/webfactory/received_events","type":"Organization","site_admin":false},"repo":{"id":3041501,"name":"symfony","full_name":"webfactory/symfony","owner":{"login":"webfactory","id":135788,"avatar_url":"https://avatars.githubusercontent.com/u/135788?v=3","gravatar_id":"","url":"https://api.github.com/users/webfactory","html_url":"https://github.com/webfactory","followers_url":"https://api.github.com/users/webfactory/followers","following_url":"https://api.github.com/users/webfactory/following{/other_user}","gists_url":"https://api.github.com/users/webfactory/gists{/gist_id}","starred_url":"https://api.github.com/users/webfactory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webfactory/subscriptions","organizations_url":"https://api.github.com/users/webfactory/orgs","repos_url":"https://api.github.com/users/webfactory/repos","events_url":"https://api.github.com/users/webfactory/events{/privacy}","received_events_url":"https://api.github.com/users/webfactory/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/webfactory/symfony","description":"The Symfony2 PHP framework","fork":true,"url":"https://api.github.com/repos/webfactory/symfony","forks_url":"https://api.github.com/repos/webfactory/symfony/forks","keys_url":"https://api.github.com/repos/webfactory/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/webfactory/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/webfactory/symfony/teams","hooks_url":"https://api.github.com/repos/webfactory/symfony/hooks","issue_events_url":"https://api.github.com/repos/webfactory/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/webfactory/symfony/events","assignees_url":"https://api.github.com/repos/webfactory/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/webfactory/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/webfactory/symfony/tags","blobs_url":"https://api.github.com/repos/webfactory/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/webfactory/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/webfactory/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/webfactory/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/webfactory/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/webfactory/symfony/languages","stargazers_url":"https://api.github.com/repos/webfactory/symfony/stargazers","contributors_url":"https://api.github.com/repos/webfactory/symfony/contributors","subscribers_url":"https://api.github.com/repos/webfactory/symfony/subscribers","subscription_url":"https://api.github.com/repos/webfactory/symfony/subscription","commits_url":"https://api.github.com/repos/webfactory/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/webfactory/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/webfactory/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/webfactory/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/webfactory/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/webfactory/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/webfactory/symfony/merges","archive_url":"https://api.github.com/repos/webfactory/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/webfactory/symfony/downloads","issues_url":"https://api.github.com/repos/webfactory/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/webfactory/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/webfactory/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/webfactory/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/webfactory/symfony/labels{/name}","releases_url":"https://api.github.com/repos/webfactory/symfony/releases{/id}","created_at":"2011-12-23T17:57:42Z","updated_at":"2014-09-30T06:38:40Z","pushed_at":"2015-04-11T08:54:45Z","git_url":"git://github.com/webfactory/symfony.git","ssh_url":"git@github.com:webfactory/symfony.git","clone_url":"https://github.com/webfactory/symfony.git","svn_url":"https://github.com/webfactory/symfony","homepage":"symfony.com","size":54590,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"symfony:2.7","ref":"2.7","sha":"37611405e52683b1d4ddb4b9c1722f69d1895a1e","user":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":458058,"name":"symfony","full_name":"symfony/symfony","owner":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/symfony","description":"The Symfony PHP framework","fork":false,"url":"https://api.github.com/repos/symfony/symfony","forks_url":"https://api.github.com/repos/symfony/symfony/forks","keys_url":"https://api.github.com/repos/symfony/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony/teams","hooks_url":"https://api.github.com/repos/symfony/symfony/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony/events","assignees_url":"https://api.github.com/repos/symfony/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony/tags","blobs_url":"https://api.github.com/repos/symfony/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony/subscription","commits_url":"https://api.github.com/repos/symfony/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony/merges","archive_url":"https://api.github.com/repos/symfony/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony/downloads","issues_url":"https://api.github.com/repos/symfony/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony/releases{/id}","created_at":"2010-01-04T14:21:21Z","updated_at":"2015-04-11T08:51:56Z","pushed_at":"2015-04-11T09:14:42Z","git_url":"git://github.com/symfony/symfony.git","ssh_url":"git@github.com:symfony/symfony.git","clone_url":"https://github.com/symfony/symfony.git","svn_url":"https://github.com/symfony/symfony","homepage":"symfony.com","size":219202,"stargazers_count":9989,"watchers_count":9989,"language":"PHP","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":3919,"mirror_url":null,"open_issues_count":814,"forks":3919,"open_issues":814,"watchers":9989,"default_branch":"2.7"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/14315"},"html":{"href":"https://github.com/symfony/symfony/pull/14315"},"issue":{"href":"https://api.github.com/repos/symfony/symfony/issues/14315"},"comments":{"href":"https://api.github.com/repos/symfony/symfony/issues/14315/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony/pulls/14315/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony/pulls/14315/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony/statuses/7503f2acfac3b477915301505dd7179c4db4190f"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":31,"deletions":0,"changed_files":1}}