{"action":"created","comment":{"url":"https://api.github.com/repos/splitbrain/dokuwiki-plugin-dw2pdf/pulls/comments/28272773","id":28272773,"diff_hunk":"@@ -51,6 +51,10 @@ public function getPType() {\n      */\n     public function connectTo($mode) {\n         $this->Lexer->addSpecialPattern('~~PDF:(?:LANDSCAPE|PORTRAIT)~~', $mode, 'plugin_dw2pdf_pagesetting');\n+\n+        // this I put here, because it doesnt have sense to create whole new class just for this line\n+        // but if things change ...\n+\t\t$this->Lexer->addSpecialPattern('<pdfvars[^>]*>[^<]*</pdfvars>' , $mode, 'plugin_dw2pdf_pagesetting');","path":"syntax/pagesetting.php","position":7,"original_position":7,"commit_id":"9b49a4372c289e0c103fb34b1dfe5cc5eafbcb21","original_commit_id":"9b49a4372c289e0c103fb34b1dfe5cc5eafbcb21","user":{"login":"Klap-in","id":183250,"avatar_url":"https://avatars.githubusercontent.com/u/183250?v=3","gravatar_id":"","url":"https://api.github.com/users/Klap-in","html_url":"https://github.com/Klap-in","followers_url":"https://api.github.com/users/Klap-in/followers","following_url":"https://api.github.com/users/Klap-in/following{/other_user}","gists_url":"https://api.github.com/users/Klap-in/gists{/gist_id}","starred_url":"https://api.github.com/users/Klap-in/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Klap-in/subscriptions","organizations_url":"https://api.github.com/users/Klap-in/orgs","repos_url":"https://api.github.com/users/Klap-in/repos","events_url":"https://api.github.com/users/Klap-in/events{/privacy}","received_events_url":"https://api.github.com/users/Klap-in/received_events","type":"User","site_admin":false},"body":"Can you do a proposal for a syntax format that matches with the `~~PDF: ...... ~~`? It is fine for me if it is multilined.","created_at":"2015-04-13T19:56:13Z","updated_at":"2015-04-13T19:56:13Z","html_url":"https://github.com/splitbrain/dokuwiki-plugin-dw2pdf/pull/181#discussion_r28272773","pull_request_url":"https://api.github.com/repos/splitbrain/dokuwiki-plugin-dw2pdf/pulls/181","_links":{"self":{"href":"https://api.github.com/repos/splitbrain/dokuwiki-plugin-dw2pdf/pulls/comments/28272773"},"html":{"href":"https://github.com/splitbrain/dokuwiki-plugin-dw2pdf/pull/181#discussion_r28272773"},"pull_request":{"href":"https://api.github.com/repos/splitbrain/dokuwiki-plugin-dw2pdf/pulls/181"}}},"pull_request":{"url":"https://api.github.com/repos/splitbrain/dokuwiki-plugin-dw2pdf/pulls/181","id":33181252,"html_url":"https://github.com/splitbrain/dokuwiki-plugin-dw2pdf/pull/181","diff_url":"https://github.com/splitbrain/dokuwiki-plugin-dw2pdf/pull/181.diff","patch_url":"https://github.com/splitbrain/dokuwiki-plugin-dw2pdf/pull/181.patch","issue_url":"https://api.github.com/repos/splitbrain/dokuwiki-plugin-dw2pdf/issues/181","number":181,"state":"open","locked":false,"title":"Custom variables in PDF template.","user":{"login":"dturkalj","id":7556478,"avatar_url":"https://avatars.githubusercontent.com/u/7556478?v=3","gravatar_id":"","url":"https://api.github.com/users/dturkalj","html_url":"https://github.com/dturkalj","followers_url":"https://api.github.com/users/dturkalj/followers","following_url":"https://api.github.com/users/dturkalj/following{/other_user}","gists_url":"https://api.github.com/users/dturkalj/gists{/gist_id}","starred_url":"https://api.github.com/users/dturkalj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dturkalj/subscriptions","organizations_url":"https://api.github.com/users/dturkalj/orgs","repos_url":"https://api.github.com/users/dturkalj/repos","events_url":"https://api.github.com/users/dturkalj/events{/privacy}","received_events_url":"https://api.github.com/users/dturkalj/received_events","type":"User","site_admin":false},"body":"Hello,\r\n\r\nI have feature proposition for dw2pdf plugin. In some cases some information in header and footer, are not enough. So I make modification in plugin for implementation of custom variables.\r\n\r\nSimply use in DokuWiki page sintax:\r\n\r\n    <pdfvars>\r\n    varname1=value1\r\n    varname2=value2\r\n    ...\r\n    </pdfvars>\r\n\r\nblock to define custom variables, and then in header / footer template use\r\n\r\n    @varname1@    @varname2@    ...\r\n\r\nfor replacement just like standard ones. I hope that it will be useful also for other users.\r\n\r\nI tested it on my local test wiki instance and it works. But my knowledge of PHP is very, very limited.\r\nIn fact I reuse code (and idea) from const plugin, and use my universal programming experience.\r\nNot tested with bookcreator, but I think that it will not interfere with it.\r\n\r\nI closed my previous request since I overlooked that syntax object already exist as multi-component.\r\n\r\nregards,\r\nDavor\r\n","created_at":"2015-04-13T16:47:44Z","updated_at":"2015-04-13T19:56:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2b420b57ea6417880a0e6e6c5c0e073fe0e728a6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/splitbrain/dokuwiki-plugin-dw2pdf/pulls/181/commits","review_comments_url":"https://api.github.com/repos/splitbrain/dokuwiki-plugin-dw2pdf/pulls/181/comments","review_comment_url":"https://api.github.com/repos/splitbrain/dokuwiki-plugin-dw2pdf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/splitbrain/dokuwiki-plugin-dw2pdf/issues/181/comments","statuses_url":"https://api.github.com/repos/splitbrain/dokuwiki-plugin-dw2pdf/statuses/9b49a4372c289e0c103fb34b1dfe5cc5eafbcb21","head":{"label":"dturkalj:master","ref":"master","sha":"9b49a4372c289e0c103fb34b1dfe5cc5eafbcb21","user":{"login":"dturkalj","id":7556478,"avatar_url":"https://avatars.githubusercontent.com/u/7556478?v=3","gravatar_id":"","url":"https://api.github.com/users/dturkalj","html_url":"https://github.com/dturkalj","followers_url":"https://api.github.com/users/dturkalj/followers","following_url":"https://api.github.com/users/dturkalj/following{/other_user}","gists_url":"https://api.github.com/users/dturkalj/gists{/gist_id}","starred_url":"https://api.github.com/users/dturkalj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dturkalj/subscriptions","organizations_url":"https://api.github.com/users/dturkalj/orgs","repos_url":"https://api.github.com/users/dturkalj/repos","events_url":"https://api.github.com/users/dturkalj/events{/privacy}","received_events_url":"https://api.github.com/users/dturkalj/received_events","type":"User","site_admin":false},"repo":{"id":33861265,"name":"dokuwiki-plugin-dw2pdf","full_name":"dturkalj/dokuwiki-plugin-dw2pdf","owner":{"login":"dturkalj","id":7556478,"avatar_url":"https://avatars.githubusercontent.com/u/7556478?v=3","gravatar_id":"","url":"https://api.github.com/users/dturkalj","html_url":"https://github.com/dturkalj","followers_url":"https://api.github.com/users/dturkalj/followers","following_url":"https://api.github.com/users/dturkalj/following{/other_user}","gists_url":"https://api.github.com/users/dturkalj/gists{/gist_id}","starred_url":"https://api.github.com/users/dturkalj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dturkalj/subscriptions","organizations_url":"https://api.github.com/users/dturkalj/orgs","repos_url":"https://api.github.com/users/dturkalj/repos","events_url":"https://api.github.com/users/dturkalj/events{/privacy}","received_events_url":"https://api.github.com/users/dturkalj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dturkalj/dokuwiki-plugin-dw2pdf","description":"A fork of Luigi Micco's PDF export plugin for DokuWiki","fork":true,"url":"https://api.github.com/repos/dturkalj/dokuwiki-plugin-dw2pdf","forks_url":"https://api.github.com/repos/dturkalj/dokuwiki-plugin-dw2pdf/forks","keys_url":"https://api.github.com/repos/dturkalj/dokuwiki-plugin-dw2pdf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dturkalj/dokuwiki-plugin-dw2pdf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dturkalj/dokuwiki-plugin-dw2pdf/teams","hooks_url":"https://api.github.com/repos/dturkalj/dokuwiki-plugin-dw2pdf/hooks","issue_events_url":"https://api.github.com/repos/dturkalj/dokuwiki-plugin-dw2pdf/issues/events{/number}","events_url":"https://api.github.com/repos/dturkalj/dokuwiki-plugin-dw2pdf/events","assignees_url":"https://api.github.com/repos/dturkalj/dokuwiki-plugin-dw2pdf/assignees{/user}","branches_url":"https://api.github.com/repos/dturkalj/dokuwiki-plugin-dw2pdf/branches{/branch}","tags_url":"https://api.github.com/repos/dturkalj/dokuwiki-plugin-dw2pdf/tags","blobs_url":"https://api.github.com/repos/dturkalj/dokuwiki-plugin-dw2pdf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dturkalj/dokuwiki-plugin-dw2pdf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dturkalj/dokuwiki-plugin-dw2pdf/git/refs{/sha}","trees_url":"https://api.github.com/repos/dturkalj/dokuwiki-plugin-dw2pdf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dturkalj/dokuwiki-plugin-dw2pdf/statuses/{sha}","languages_url":"https://api.github.com/repos/dturkalj/dokuwiki-plugin-dw2pdf/languages","stargazers_url":"https://api.github.com/repos/dturkalj/dokuwiki-plugin-dw2pdf/stargazers","contributors_url":"https://api.github.com/repos/dturkalj/dokuwiki-plugin-dw2pdf/contributors","subscribers_url":"https://api.github.com/repos/dturkalj/dokuwiki-plugin-dw2pdf/subscribers","subscription_url":"https://api.github.com/repos/dturkalj/dokuwiki-plugin-dw2pdf/subscription","commits_url":"https://api.github.com/repos/dturkalj/dokuwiki-plugin-dw2pdf/commits{/sha}","git_commits_url":"https://api.github.com/repos/dturkalj/dokuwiki-plugin-dw2pdf/git/commits{/sha}","comments_url":"https://api.github.com/repos/dturkalj/dokuwiki-plugin-dw2pdf/comments{/number}","issue_comment_url":"https://api.github.com/repos/dturkalj/dokuwiki-plugin-dw2pdf/issues/comments{/number}","contents_url":"https://api.github.com/repos/dturkalj/dokuwiki-plugin-dw2pdf/contents/{+path}","compare_url":"https://api.github.com/repos/dturkalj/dokuwiki-plugin-dw2pdf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dturkalj/dokuwiki-plugin-dw2pdf/merges","archive_url":"https://api.github.com/repos/dturkalj/dokuwiki-plugin-dw2pdf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dturkalj/dokuwiki-plugin-dw2pdf/downloads","issues_url":"https://api.github.com/repos/dturkalj/dokuwiki-plugin-dw2pdf/issues{/number}","pulls_url":"https://api.github.com/repos/dturkalj/dokuwiki-plugin-dw2pdf/pulls{/number}","milestones_url":"https://api.github.com/repos/dturkalj/dokuwiki-plugin-dw2pdf/milestones{/number}","notifications_url":"https://api.github.com/repos/dturkalj/dokuwiki-plugin-dw2pdf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dturkalj/dokuwiki-plugin-dw2pdf/labels{/name}","releases_url":"https://api.github.com/repos/dturkalj/dokuwiki-plugin-dw2pdf/releases{/id}","created_at":"2015-04-13T10:03:40Z","updated_at":"2015-04-13T16:37:12Z","pushed_at":"2015-04-13T16:37:12Z","git_url":"git://github.com/dturkalj/dokuwiki-plugin-dw2pdf.git","ssh_url":"git@github.com:dturkalj/dokuwiki-plugin-dw2pdf.git","clone_url":"https://github.com/dturkalj/dokuwiki-plugin-dw2pdf.git","svn_url":"https://github.com/dturkalj/dokuwiki-plugin-dw2pdf","homepage":"http://www.dokuwiki.org/plugin:dw2pdf","size":26699,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"splitbrain:master","ref":"master","sha":"575d1d496f13a5bd22cf564e917599dd8f1956fe","user":{"login":"splitbrain","id":86426,"avatar_url":"https://avatars.githubusercontent.com/u/86426?v=3","gravatar_id":"","url":"https://api.github.com/users/splitbrain","html_url":"https://github.com/splitbrain","followers_url":"https://api.github.com/users/splitbrain/followers","following_url":"https://api.github.com/users/splitbrain/following{/other_user}","gists_url":"https://api.github.com/users/splitbrain/gists{/gist_id}","starred_url":"https://api.github.com/users/splitbrain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/splitbrain/subscriptions","organizations_url":"https://api.github.com/users/splitbrain/orgs","repos_url":"https://api.github.com/users/splitbrain/repos","events_url":"https://api.github.com/users/splitbrain/events{/privacy}","received_events_url":"https://api.github.com/users/splitbrain/received_events","type":"User","site_admin":false},"repo":{"id":1883719,"name":"dokuwiki-plugin-dw2pdf","full_name":"splitbrain/dokuwiki-plugin-dw2pdf","owner":{"login":"splitbrain","id":86426,"avatar_url":"https://avatars.githubusercontent.com/u/86426?v=3","gravatar_id":"","url":"https://api.github.com/users/splitbrain","html_url":"https://github.com/splitbrain","followers_url":"https://api.github.com/users/splitbrain/followers","following_url":"https://api.github.com/users/splitbrain/following{/other_user}","gists_url":"https://api.github.com/users/splitbrain/gists{/gist_id}","starred_url":"https://api.github.com/users/splitbrain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/splitbrain/subscriptions","organizations_url":"https://api.github.com/users/splitbrain/orgs","repos_url":"https://api.github.com/users/splitbrain/repos","events_url":"https://api.github.com/users/splitbrain/events{/privacy}","received_events_url":"https://api.github.com/users/splitbrain/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/splitbrain/dokuwiki-plugin-dw2pdf","description":"A fork of Luigi Micco's PDF export plugin for DokuWiki","fork":false,"url":"https://api.github.com/repos/splitbrain/dokuwiki-plugin-dw2pdf","forks_url":"https://api.github.com/repos/splitbrain/dokuwiki-plugin-dw2pdf/forks","keys_url":"https://api.github.com/repos/splitbrain/dokuwiki-plugin-dw2pdf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/splitbrain/dokuwiki-plugin-dw2pdf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/splitbrain/dokuwiki-plugin-dw2pdf/teams","hooks_url":"https://api.github.com/repos/splitbrain/dokuwiki-plugin-dw2pdf/hooks","issue_events_url":"https://api.github.com/repos/splitbrain/dokuwiki-plugin-dw2pdf/issues/events{/number}","events_url":"https://api.github.com/repos/splitbrain/dokuwiki-plugin-dw2pdf/events","assignees_url":"https://api.github.com/repos/splitbrain/dokuwiki-plugin-dw2pdf/assignees{/user}","branches_url":"https://api.github.com/repos/splitbrain/dokuwiki-plugin-dw2pdf/branches{/branch}","tags_url":"https://api.github.com/repos/splitbrain/dokuwiki-plugin-dw2pdf/tags","blobs_url":"https://api.github.com/repos/splitbrain/dokuwiki-plugin-dw2pdf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/splitbrain/dokuwiki-plugin-dw2pdf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/splitbrain/dokuwiki-plugin-dw2pdf/git/refs{/sha}","trees_url":"https://api.github.com/repos/splitbrain/dokuwiki-plugin-dw2pdf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/splitbrain/dokuwiki-plugin-dw2pdf/statuses/{sha}","languages_url":"https://api.github.com/repos/splitbrain/dokuwiki-plugin-dw2pdf/languages","stargazers_url":"https://api.github.com/repos/splitbrain/dokuwiki-plugin-dw2pdf/stargazers","contributors_url":"https://api.github.com/repos/splitbrain/dokuwiki-plugin-dw2pdf/contributors","subscribers_url":"https://api.github.com/repos/splitbrain/dokuwiki-plugin-dw2pdf/subscribers","subscription_url":"https://api.github.com/repos/splitbrain/dokuwiki-plugin-dw2pdf/subscription","commits_url":"https://api.github.com/repos/splitbrain/dokuwiki-plugin-dw2pdf/commits{/sha}","git_commits_url":"https://api.github.com/repos/splitbrain/dokuwiki-plugin-dw2pdf/git/commits{/sha}","comments_url":"https://api.github.com/repos/splitbrain/dokuwiki-plugin-dw2pdf/comments{/number}","issue_comment_url":"https://api.github.com/repos/splitbrain/dokuwiki-plugin-dw2pdf/issues/comments{/number}","contents_url":"https://api.github.com/repos/splitbrain/dokuwiki-plugin-dw2pdf/contents/{+path}","compare_url":"https://api.github.com/repos/splitbrain/dokuwiki-plugin-dw2pdf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/splitbrain/dokuwiki-plugin-dw2pdf/merges","archive_url":"https://api.github.com/repos/splitbrain/dokuwiki-plugin-dw2pdf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/splitbrain/dokuwiki-plugin-dw2pdf/downloads","issues_url":"https://api.github.com/repos/splitbrain/dokuwiki-plugin-dw2pdf/issues{/number}","pulls_url":"https://api.github.com/repos/splitbrain/dokuwiki-plugin-dw2pdf/pulls{/number}","milestones_url":"https://api.github.com/repos/splitbrain/dokuwiki-plugin-dw2pdf/milestones{/number}","notifications_url":"https://api.github.com/repos/splitbrain/dokuwiki-plugin-dw2pdf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/splitbrain/dokuwiki-plugin-dw2pdf/labels{/name}","releases_url":"https://api.github.com/repos/splitbrain/dokuwiki-plugin-dw2pdf/releases{/id}","created_at":"2011-06-12T06:03:01Z","updated_at":"2015-03-17T14:47:25Z","pushed_at":"2015-04-13T16:47:44Z","git_url":"git://github.com/splitbrain/dokuwiki-plugin-dw2pdf.git","ssh_url":"git@github.com:splitbrain/dokuwiki-plugin-dw2pdf.git","clone_url":"https://github.com/splitbrain/dokuwiki-plugin-dw2pdf.git","svn_url":"https://github.com/splitbrain/dokuwiki-plugin-dw2pdf","homepage":"http://www.dokuwiki.org/plugin:dw2pdf","size":27271,"stargazers_count":26,"watchers_count":26,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"open_issues_count":23,"forks":25,"open_issues":23,"watchers":26,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/splitbrain/dokuwiki-plugin-dw2pdf/pulls/181"},"html":{"href":"https://github.com/splitbrain/dokuwiki-plugin-dw2pdf/pull/181"},"issue":{"href":"https://api.github.com/repos/splitbrain/dokuwiki-plugin-dw2pdf/issues/181"},"comments":{"href":"https://api.github.com/repos/splitbrain/dokuwiki-plugin-dw2pdf/issues/181/comments"},"review_comments":{"href":"https://api.github.com/repos/splitbrain/dokuwiki-plugin-dw2pdf/pulls/181/comments"},"review_comment":{"href":"https://api.github.com/repos/splitbrain/dokuwiki-plugin-dw2pdf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/splitbrain/dokuwiki-plugin-dw2pdf/pulls/181/commits"},"statuses":{"href":"https://api.github.com/repos/splitbrain/dokuwiki-plugin-dw2pdf/statuses/9b49a4372c289e0c103fb34b1dfe5cc5eafbcb21"}}}}