{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/3490","labels_url":"https://api.github.com/repos/nodejs/node/issues/3490/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/3490/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/3490/events","html_url":"https://github.com/nodejs/node/pull/3490","id":112861703,"number":3490,"title":"stream: fix stdin race condition in Windows 8/10","user":{"login":"silverwind","id":115237,"avatar_url":"https://avatars.githubusercontent.com/u/115237?v=3","gravatar_id":"","url":"https://api.github.com/users/silverwind","html_url":"https://github.com/silverwind","followers_url":"https://api.github.com/users/silverwind/followers","following_url":"https://api.github.com/users/silverwind/following{/other_user}","gists_url":"https://api.github.com/users/silverwind/gists{/gist_id}","starred_url":"https://api.github.com/users/silverwind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/silverwind/subscriptions","organizations_url":"https://api.github.com/users/silverwind/orgs","repos_url":"https://api.github.com/users/silverwind/repos","events_url":"https://api.github.com/users/silverwind/events{/privacy}","received_events_url":"https://api.github.com/users/silverwind/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/nodejs/node/labels/land-on-v3.x","name":"land-on-v3.x","color":"fef2c0"},{"url":"https://api.github.com/repos/nodejs/node/labels/land-on-v4.x","name":"land-on-v4.x","color":"d4c5f9"},{"url":"https://api.github.com/repos/nodejs/node/labels/lts-watch-v4.x","name":"lts-watch-v4.x","color":"eb6420"},{"url":"https://api.github.com/repos/nodejs/node/labels/stream","name":"stream","color":"c7def8"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-10-22T18:23:25Z","updated_at":"2015-10-29T06:26:56Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/3490","html_url":"https://github.com/nodejs/node/pull/3490","diff_url":"https://github.com/nodejs/node/pull/3490.diff","patch_url":"https://github.com/nodejs/node/pull/3490.patch"},"body":"This reverts https://github.com/nodejs/node/commit/8cee8f54fc5fe3d340bf10ba2e9dbb5648b21b83 which was causing a regression through a possible race condition on Windows 8 and 10. The test is **not working and WIP**.\r\n\r\nFixes: https://github.com/nodejs/node/issues/2996\r\nFixes: https://github.com/nodejs/node/issues/2504\r\n\r\nThe test cases presented in #2996 seem to fail only sometimes, those in #2504 failed all the time for me.\r\n\r\nI took one of the examples from #2504 and tried to make a test for it, but it appears to not trigger the bug when spawning in a child process. Running the fixture alone from powershell does show the issue, so I'm a bit out of ideas here. @anseki could you maybe have a look? An automated test for this bug would be great to have.\r\n\r\ncc: @chrisdickinson @nodejs/platform-windows "},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/152092628","html_url":"https://github.com/nodejs/node/pull/3490#issuecomment-152092628","issue_url":"https://api.github.com/repos/nodejs/node/issues/3490","id":152092628,"user":{"login":"silverwind","id":115237,"avatar_url":"https://avatars.githubusercontent.com/u/115237?v=3","gravatar_id":"","url":"https://api.github.com/users/silverwind","html_url":"https://github.com/silverwind","followers_url":"https://api.github.com/users/silverwind/followers","following_url":"https://api.github.com/users/silverwind/following{/other_user}","gists_url":"https://api.github.com/users/silverwind/gists{/gist_id}","starred_url":"https://api.github.com/users/silverwind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/silverwind/subscriptions","organizations_url":"https://api.github.com/users/silverwind/orgs","repos_url":"https://api.github.com/users/silverwind/repos","events_url":"https://api.github.com/users/silverwind/events{/privacy}","received_events_url":"https://api.github.com/users/silverwind/received_events","type":"User","site_admin":false},"created_at":"2015-10-29T06:26:55Z","updated_at":"2015-10-29T06:26:55Z","body":"Anyone able to review? It's a simple revert that fixes 2 (imho) pretty serious bugs on Windows."}}