{"action":"created","issue":{"url":"https://api.github.com/repos/DirectEmployers/MyJobs/issues/1967","labels_url":"https://api.github.com/repos/DirectEmployers/MyJobs/issues/1967/labels{/name}","comments_url":"https://api.github.com/repos/DirectEmployers/MyJobs/issues/1967/comments","events_url":"https://api.github.com/repos/DirectEmployers/MyJobs/issues/1967/events","html_url":"https://github.com/DirectEmployers/MyJobs/pull/1967","id":122120334,"number":1967,"title":"[PD-1958]  tags interface","user":{"login":"darrint","id":108186,"avatar_url":"https://avatars.githubusercontent.com/u/108186?v=3","gravatar_id":"","url":"https://api.github.com/users/darrint","html_url":"https://github.com/darrint","followers_url":"https://api.github.com/users/darrint/followers","following_url":"https://api.github.com/users/darrint/following{/other_user}","gists_url":"https://api.github.com/users/darrint/gists{/gist_id}","starred_url":"https://api.github.com/users/darrint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darrint/subscriptions","organizations_url":"https://api.github.com/users/darrint/orgs","repos_url":"https://api.github.com/users/darrint/repos","events_url":"https://api.github.com/users/darrint/events{/privacy}","received_events_url":"https://api.github.com/users/darrint/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":11,"created_at":"2015-12-14T20:07:50Z","updated_at":"2015-12-22T18:20:26Z","closed_at":"2015-12-22T18:19:21Z","pull_request":{"url":"https://api.github.com/repos/DirectEmployers/MyJobs/pulls/1967","html_url":"https://github.com/DirectEmployers/MyJobs/pull/1967","diff_url":"https://github.com/DirectEmployers/MyJobs/pull/1967.diff","patch_url":"https://github.com/DirectEmployers/MyJobs/pull/1967.patch"},"body":"This implements David's prototype tags interface without drag and drop. I have added autocomplete as that was intended to be implemented, although it was not a part of the prototype.\r\n\r\nThe CSS is lifted almost verbatim from the prototype. The behavior is implemented as React components. There is a working python API behind this component.\r\n\r\nAlso present is a new common directory scheme for common JS code. I have written documentation for all the new code in common/. I did not experiment with any kind of doc tooling.\r\n\r\nDavid's original ticket with some screenshots, etc. is here: https://directemployersfoundation.atlassian.net/browse/PD-1428\r\n\r\nFrom @aspidites comment below:\r\n\r\n- [ ] ~~there are times when a tag doesn't show up when filtering despite it showing up pre-filter~~ pushing to PD-2040\r\n- [ ] ~~if I start typing a tag that doesn't exist, rather than clear on enter, the erroneous tag remains (vs. other behavior pertaining to create tag permissions)~~ pushing to PD-2040\r\n- [x] add ticket for drag and drop: PD-2048\r\n- [x] placeholders\r\n- [x] already added tags aren't highlighted when clicked\r\n- [x] the input box doesn't span the entire add box\r\n- [x] tags aren't colored when they should be\r\n\r\nFuture work:\r\n\r\n* [[PD-2039]](https://directemployersfoundation.atlassian.net/browse/PD-2039) what to do about partner tags and the contacts datasource\r\n* [[PD-2040]](https://directemployersfoundation.atlassian.net/browse/PD-2040) improve autocomplete with regard to \"hidden\" items\r\n* [[PD-2048]](https://directemployersfoundation.atlassian.net/browse/PD-2048) add drag and drop"},"comment":{"url":"https://api.github.com/repos/DirectEmployers/MyJobs/issues/comments/166695682","html_url":"https://github.com/DirectEmployers/MyJobs/pull/1967#issuecomment-166695682","issue_url":"https://api.github.com/repos/DirectEmployers/MyJobs/issues/1967","id":166695682,"user":{"login":"darrint","id":108186,"avatar_url":"https://avatars.githubusercontent.com/u/108186?v=3","gravatar_id":"","url":"https://api.github.com/users/darrint","html_url":"https://github.com/darrint","followers_url":"https://api.github.com/users/darrint/followers","following_url":"https://api.github.com/users/darrint/following{/other_user}","gists_url":"https://api.github.com/users/darrint/gists{/gist_id}","starred_url":"https://api.github.com/users/darrint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darrint/subscriptions","organizations_url":"https://api.github.com/users/darrint/orgs","repos_url":"https://api.github.com/users/darrint/repos","events_url":"https://api.github.com/users/darrint/events{/privacy}","received_events_url":"https://api.github.com/users/darrint/received_events","type":"User","site_admin":false},"created_at":"2015-12-22T18:20:26Z","updated_at":"2015-12-22T18:20:26Z","body":"@tdphillips and I looked into this and it turned out to be related to compression settings in his development environment. We don't fully understand exactly what happened but I'm willing to say it doesn't affect this ticket."}}