{"action":"closed","number":2,"pull_request":{"url":"https://api.github.com/repos/wikimedia/oojs/pulls/2","id":27579150,"html_url":"https://github.com/wikimedia/oojs/pull/2","diff_url":"https://github.com/wikimedia/oojs/pull/2.diff","patch_url":"https://github.com/wikimedia/oojs/pull/2.patch","issue_url":"https://api.github.com/repos/wikimedia/oojs/issues/2","number":2,"state":"closed","locked":false,"title":"v8 opt: Copy arguments into new array rather than use [].slice","user":{"login":"atdt","id":376462,"avatar_url":"https://avatars.githubusercontent.com/u/376462?v=3","gravatar_id":"","url":"https://api.github.com/users/atdt","html_url":"https://github.com/atdt","followers_url":"https://api.github.com/users/atdt/followers","following_url":"https://api.github.com/users/atdt/following{/other_user}","gists_url":"https://api.github.com/users/atdt/gists{/gist_id}","starred_url":"https://api.github.com/users/atdt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atdt/subscriptions","organizations_url":"https://api.github.com/users/atdt/orgs","repos_url":"https://api.github.com/users/atdt/repos","events_url":"https://api.github.com/users/atdt/events{/privacy}","received_events_url":"https://api.github.com/users/atdt/received_events","type":"User","site_admin":false},"body":"Calling Array.prototype.slice on the arguments object disables certain V8\r\noptimizations. The Chrome Dev Tools profiler flags OO.Factory with the warning\r\n\"bad value context for arguments value\". Using a simple array copy is just as\r\nidiomatic and ought to work faster.\r\n\r\nI didn't see a statistically significant improvement from this change, but I\r\nplan on submitting these as I go down the list of warnings if the change needed\r\nto make v8 happy doesn't compromise the readability of the code.\r\n\r\nSome more details here: <https://github.com/jashkenas/coffeescript/issues/3274>","created_at":"2015-01-18T23:32:14Z","updated_at":"2015-01-22T16:52:13Z","closed_at":"2015-01-22T16:52:13Z","merged_at":null,"merge_commit_sha":"9ea522aae5e0e4aa596201433dd2994114881518","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/wikimedia/oojs/pulls/2/commits","review_comments_url":"https://api.github.com/repos/wikimedia/oojs/pulls/2/comments","review_comment_url":"https://api.github.com/repos/wikimedia/oojs/pulls/comments/{number}","comments_url":"https://api.github.com/repos/wikimedia/oojs/issues/2/comments","statuses_url":"https://api.github.com/repos/wikimedia/oojs/statuses/02cf334f6637596e5700b9ab21158aa4fb04fde6","head":{"label":"atdt:v8-opts","ref":"v8-opts","sha":"02cf334f6637596e5700b9ab21158aa4fb04fde6","user":{"login":"atdt","id":376462,"avatar_url":"https://avatars.githubusercontent.com/u/376462?v=3","gravatar_id":"","url":"https://api.github.com/users/atdt","html_url":"https://github.com/atdt","followers_url":"https://api.github.com/users/atdt/followers","following_url":"https://api.github.com/users/atdt/following{/other_user}","gists_url":"https://api.github.com/users/atdt/gists{/gist_id}","starred_url":"https://api.github.com/users/atdt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atdt/subscriptions","organizations_url":"https://api.github.com/users/atdt/orgs","repos_url":"https://api.github.com/users/atdt/repos","events_url":"https://api.github.com/users/atdt/events{/privacy}","received_events_url":"https://api.github.com/users/atdt/received_events","type":"User","site_admin":false},"repo":{"id":29445175,"name":"oojs","full_name":"atdt/oojs","owner":{"login":"atdt","id":376462,"avatar_url":"https://avatars.githubusercontent.com/u/376462?v=3","gravatar_id":"","url":"https://api.github.com/users/atdt","html_url":"https://github.com/atdt","followers_url":"https://api.github.com/users/atdt/followers","following_url":"https://api.github.com/users/atdt/following{/other_user}","gists_url":"https://api.github.com/users/atdt/gists{/gist_id}","starred_url":"https://api.github.com/users/atdt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atdt/subscriptions","organizations_url":"https://api.github.com/users/atdt/orgs","repos_url":"https://api.github.com/users/atdt/repos","events_url":"https://api.github.com/users/atdt/events{/privacy}","received_events_url":"https://api.github.com/users/atdt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/atdt/oojs","description":"Power for object oriented javascript libraries.","fork":true,"url":"https://api.github.com/repos/atdt/oojs","forks_url":"https://api.github.com/repos/atdt/oojs/forks","keys_url":"https://api.github.com/repos/atdt/oojs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/atdt/oojs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/atdt/oojs/teams","hooks_url":"https://api.github.com/repos/atdt/oojs/hooks","issue_events_url":"https://api.github.com/repos/atdt/oojs/issues/events{/number}","events_url":"https://api.github.com/repos/atdt/oojs/events","assignees_url":"https://api.github.com/repos/atdt/oojs/assignees{/user}","branches_url":"https://api.github.com/repos/atdt/oojs/branches{/branch}","tags_url":"https://api.github.com/repos/atdt/oojs/tags","blobs_url":"https://api.github.com/repos/atdt/oojs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/atdt/oojs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/atdt/oojs/git/refs{/sha}","trees_url":"https://api.github.com/repos/atdt/oojs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/atdt/oojs/statuses/{sha}","languages_url":"https://api.github.com/repos/atdt/oojs/languages","stargazers_url":"https://api.github.com/repos/atdt/oojs/stargazers","contributors_url":"https://api.github.com/repos/atdt/oojs/contributors","subscribers_url":"https://api.github.com/repos/atdt/oojs/subscribers","subscription_url":"https://api.github.com/repos/atdt/oojs/subscription","commits_url":"https://api.github.com/repos/atdt/oojs/commits{/sha}","git_commits_url":"https://api.github.com/repos/atdt/oojs/git/commits{/sha}","comments_url":"https://api.github.com/repos/atdt/oojs/comments{/number}","issue_comment_url":"https://api.github.com/repos/atdt/oojs/issues/comments/{number}","contents_url":"https://api.github.com/repos/atdt/oojs/contents/{+path}","compare_url":"https://api.github.com/repos/atdt/oojs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/atdt/oojs/merges","archive_url":"https://api.github.com/repos/atdt/oojs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/atdt/oojs/downloads","issues_url":"https://api.github.com/repos/atdt/oojs/issues{/number}","pulls_url":"https://api.github.com/repos/atdt/oojs/pulls{/number}","milestones_url":"https://api.github.com/repos/atdt/oojs/milestones{/number}","notifications_url":"https://api.github.com/repos/atdt/oojs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/atdt/oojs/labels{/name}","releases_url":"https://api.github.com/repos/atdt/oojs/releases{/id}","created_at":"2015-01-18T23:30:29Z","updated_at":"2015-01-18T23:31:26Z","pushed_at":"2015-01-18T23:31:58Z","git_url":"git://github.com/atdt/oojs.git","ssh_url":"git@github.com:atdt/oojs.git","clone_url":"https://github.com/atdt/oojs.git","svn_url":"https://github.com/atdt/oojs","homepage":"https://www.mediawiki.org/wiki/OOjs","size":466,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wikimedia:master","ref":"master","sha":"a586f681b7a232e3377014c7918cd80fe84a2474","user":{"login":"wikimedia","id":56668,"avatar_url":"https://avatars.githubusercontent.com/u/56668?v=3","gravatar_id":"","url":"https://api.github.com/users/wikimedia","html_url":"https://github.com/wikimedia","followers_url":"https://api.github.com/users/wikimedia/followers","following_url":"https://api.github.com/users/wikimedia/following{/other_user}","gists_url":"https://api.github.com/users/wikimedia/gists{/gist_id}","starred_url":"https://api.github.com/users/wikimedia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wikimedia/subscriptions","organizations_url":"https://api.github.com/users/wikimedia/orgs","repos_url":"https://api.github.com/users/wikimedia/repos","events_url":"https://api.github.com/users/wikimedia/events{/privacy}","received_events_url":"https://api.github.com/users/wikimedia/received_events","type":"Organization","site_admin":false},"repo":{"id":14212360,"name":"oojs","full_name":"wikimedia/oojs","owner":{"login":"wikimedia","id":56668,"avatar_url":"https://avatars.githubusercontent.com/u/56668?v=3","gravatar_id":"","url":"https://api.github.com/users/wikimedia","html_url":"https://github.com/wikimedia","followers_url":"https://api.github.com/users/wikimedia/followers","following_url":"https://api.github.com/users/wikimedia/following{/other_user}","gists_url":"https://api.github.com/users/wikimedia/gists{/gist_id}","starred_url":"https://api.github.com/users/wikimedia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wikimedia/subscriptions","organizations_url":"https://api.github.com/users/wikimedia/orgs","repos_url":"https://api.github.com/users/wikimedia/repos","events_url":"https://api.github.com/users/wikimedia/events{/privacy}","received_events_url":"https://api.github.com/users/wikimedia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wikimedia/oojs","description":"Power for object oriented javascript libraries.","fork":false,"url":"https://api.github.com/repos/wikimedia/oojs","forks_url":"https://api.github.com/repos/wikimedia/oojs/forks","keys_url":"https://api.github.com/repos/wikimedia/oojs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wikimedia/oojs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wikimedia/oojs/teams","hooks_url":"https://api.github.com/repos/wikimedia/oojs/hooks","issue_events_url":"https://api.github.com/repos/wikimedia/oojs/issues/events{/number}","events_url":"https://api.github.com/repos/wikimedia/oojs/events","assignees_url":"https://api.github.com/repos/wikimedia/oojs/assignees{/user}","branches_url":"https://api.github.com/repos/wikimedia/oojs/branches{/branch}","tags_url":"https://api.github.com/repos/wikimedia/oojs/tags","blobs_url":"https://api.github.com/repos/wikimedia/oojs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wikimedia/oojs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wikimedia/oojs/git/refs{/sha}","trees_url":"https://api.github.com/repos/wikimedia/oojs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wikimedia/oojs/statuses/{sha}","languages_url":"https://api.github.com/repos/wikimedia/oojs/languages","stargazers_url":"https://api.github.com/repos/wikimedia/oojs/stargazers","contributors_url":"https://api.github.com/repos/wikimedia/oojs/contributors","subscribers_url":"https://api.github.com/repos/wikimedia/oojs/subscribers","subscription_url":"https://api.github.com/repos/wikimedia/oojs/subscription","commits_url":"https://api.github.com/repos/wikimedia/oojs/commits{/sha}","git_commits_url":"https://api.github.com/repos/wikimedia/oojs/git/commits{/sha}","comments_url":"https://api.github.com/repos/wikimedia/oojs/comments{/number}","issue_comment_url":"https://api.github.com/repos/wikimedia/oojs/issues/comments/{number}","contents_url":"https://api.github.com/repos/wikimedia/oojs/contents/{+path}","compare_url":"https://api.github.com/repos/wikimedia/oojs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wikimedia/oojs/merges","archive_url":"https://api.github.com/repos/wikimedia/oojs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wikimedia/oojs/downloads","issues_url":"https://api.github.com/repos/wikimedia/oojs/issues{/number}","pulls_url":"https://api.github.com/repos/wikimedia/oojs/pulls{/number}","milestones_url":"https://api.github.com/repos/wikimedia/oojs/milestones{/number}","notifications_url":"https://api.github.com/repos/wikimedia/oojs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wikimedia/oojs/labels{/name}","releases_url":"https://api.github.com/repos/wikimedia/oojs/releases{/id}","created_at":"2013-11-07T18:40:16Z","updated_at":"2015-01-19T00:40:35Z","pushed_at":"2015-01-10T01:10:35Z","git_url":"git://github.com/wikimedia/oojs.git","ssh_url":"git@github.com:wikimedia/oojs.git","clone_url":"https://github.com/wikimedia/oojs.git","svn_url":"https://github.com/wikimedia/oojs","homepage":"https://www.mediawiki.org/wiki/OOjs","size":873,"stargazers_count":7,"watchers_count":7,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":0,"forks":5,"open_issues":0,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wikimedia/oojs/pulls/2"},"html":{"href":"https://github.com/wikimedia/oojs/pull/2"},"issue":{"href":"https://api.github.com/repos/wikimedia/oojs/issues/2"},"comments":{"href":"https://api.github.com/repos/wikimedia/oojs/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/wikimedia/oojs/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/wikimedia/oojs/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/wikimedia/oojs/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/wikimedia/oojs/statuses/02cf334f6637596e5700b9ab21158aa4fb04fde6"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":5,"deletions":2,"changed_files":1}}