{"action":"created","issue":{"url":"https://api.github.com/repos/samccone/paper-typeahead/issues/8","labels_url":"https://api.github.com/repos/samccone/paper-typeahead/issues/8/labels{/name}","comments_url":"https://api.github.com/repos/samccone/paper-typeahead/issues/8/comments","events_url":"https://api.github.com/repos/samccone/paper-typeahead/issues/8/events","html_url":"https://github.com/samccone/paper-typeahead/pull/8","id":111430951,"number":8,"title":"new features","user":{"login":"Zecat","id":11428108,"avatar_url":"https://avatars.githubusercontent.com/u/11428108?v=3","gravatar_id":"","url":"https://api.github.com/users/Zecat","html_url":"https://github.com/Zecat","followers_url":"https://api.github.com/users/Zecat/followers","following_url":"https://api.github.com/users/Zecat/following{/other_user}","gists_url":"https://api.github.com/users/Zecat/gists{/gist_id}","starred_url":"https://api.github.com/users/Zecat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zecat/subscriptions","organizations_url":"https://api.github.com/users/Zecat/orgs","repos_url":"https://api.github.com/users/Zecat/repos","events_url":"https://api.github.com/users/Zecat/events{/privacy}","received_events_url":"https://api.github.com/users/Zecat/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-10-14T16:00:33Z","updated_at":"2015-10-14T19:24:42Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/samccone/paper-typeahead/pulls/8","html_url":"https://github.com/samccone/paper-typeahead/pull/8","diff_url":"https://github.com/samccone/paper-typeahead/pull/8.diff","patch_url":"https://github.com/samccone/paper-typeahead/pull/8.patch"},"body":"#### enhancements\r\n- input still focus when we navigate with arrows in the result list, using iron-selector insead of IronMenuBehavior\r\n- put the typeahead logic in IronTypeaheadBehavior\r\n- bind paper-input attributes\r\n- provide methods to control the results manually\r\n- I used hidden$=\"[[_hideResults]]\" instead of dom-if -> is it better ?\r\n- various var name change, fixes & enhancements\r\n\r\n#### bugs\r\n- moving up/down in the results with arrow should not change input caret position, need to prevent default  input's comportement.\r\n- The default filterFn function should pay attention to exclude regExp characters in \"value\" so they are not interpreted.\r\n- mousedown on a result should not focus it\r\n- tap outside the element should close the results layer but for now, because result are focused on tap, we can't just use blur handler on paper-input"},"comment":{"url":"https://api.github.com/repos/samccone/paper-typeahead/issues/comments/148167272","html_url":"https://github.com/samccone/paper-typeahead/pull/8#issuecomment-148167272","issue_url":"https://api.github.com/repos/samccone/paper-typeahead/issues/8","id":148167272,"user":{"login":"samccone","id":883126,"avatar_url":"https://avatars.githubusercontent.com/u/883126?v=3","gravatar_id":"","url":"https://api.github.com/users/samccone","html_url":"https://github.com/samccone","followers_url":"https://api.github.com/users/samccone/followers","following_url":"https://api.github.com/users/samccone/following{/other_user}","gists_url":"https://api.github.com/users/samccone/gists{/gist_id}","starred_url":"https://api.github.com/users/samccone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samccone/subscriptions","organizations_url":"https://api.github.com/users/samccone/orgs","repos_url":"https://api.github.com/users/samccone/repos","events_url":"https://api.github.com/users/samccone/events{/privacy}","received_events_url":"https://api.github.com/users/samccone/received_events","type":"User","site_admin":false},"created_at":"2015-10-14T19:24:42Z","updated_at":"2015-10-14T19:24:42Z","body":"> I think it's just unclear when to use or not dom-if, I put it back, using IronSelectableBehavior this makes things easier, no strange access to dynamically created node anymore.\r\n\r\nSGTM"}}