{"action":"closed","number":15,"pull_request":{"url":"https://api.github.com/repos/ke-yu/Dynamo/pulls/15","id":41396238,"html_url":"https://github.com/ke-yu/Dynamo/pull/15","diff_url":"https://github.com/ke-yu/Dynamo/pull/15.diff","patch_url":"https://github.com/ke-yu/Dynamo/pull/15.patch","issue_url":"https://api.github.com/repos/ke-yu/Dynamo/issues/15","number":15,"state":"closed","locked":false,"title":"Introduced Communicator to manage all communications","user":{"login":"Benglin","id":5086849,"avatar_url":"https://avatars.githubusercontent.com/u/5086849?v=3","gravatar_id":"","url":"https://api.github.com/users/Benglin","html_url":"https://github.com/Benglin","followers_url":"https://api.github.com/users/Benglin/followers","following_url":"https://api.github.com/users/Benglin/following{/other_user}","gists_url":"https://api.github.com/users/Benglin/gists{/gist_id}","starred_url":"https://api.github.com/users/Benglin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Benglin/subscriptions","organizations_url":"https://api.github.com/users/Benglin/orgs","repos_url":"https://api.github.com/users/Benglin/repos","events_url":"https://api.github.com/users/Benglin/events{/privacy}","received_events_url":"https://api.github.com/users/Benglin/received_events","type":"User","site_admin":false},"body":"I've added some comments in the code while other design intents should be self-explanatory. Please let me know what you think. The goal is to have `Communicator` encapsulates physical channel (e.g. `Socket`, `Named Pipe`, etc.) that `NanoMessage` uses. And `Communicator` does not expose `Channel` beyond itself therefore all communications can only go through it. `DynamoModel` and `WorkspaceModel` should not have to know anything about communication.","created_at":"2015-08-01T04:30:21Z","updated_at":"2015-08-03T02:21:45Z","closed_at":"2015-08-03T02:21:45Z","merged_at":"2015-08-03T02:21:45Z","merge_commit_sha":"1ef344f7f75e90024bf732a2a2d8e805567683c2","assignee":{"login":"ke-yu","id":2600379,"avatar_url":"https://avatars.githubusercontent.com/u/2600379?v=3","gravatar_id":"","url":"https://api.github.com/users/ke-yu","html_url":"https://github.com/ke-yu","followers_url":"https://api.github.com/users/ke-yu/followers","following_url":"https://api.github.com/users/ke-yu/following{/other_user}","gists_url":"https://api.github.com/users/ke-yu/gists{/gist_id}","starred_url":"https://api.github.com/users/ke-yu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ke-yu/subscriptions","organizations_url":"https://api.github.com/users/ke-yu/orgs","repos_url":"https://api.github.com/users/ke-yu/repos","events_url":"https://api.github.com/users/ke-yu/events{/privacy}","received_events_url":"https://api.github.com/users/ke-yu/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/ke-yu/Dynamo/pulls/15/commits","review_comments_url":"https://api.github.com/repos/ke-yu/Dynamo/pulls/15/comments","review_comment_url":"https://api.github.com/repos/ke-yu/Dynamo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ke-yu/Dynamo/issues/15/comments","statuses_url":"https://api.github.com/repos/ke-yu/Dynamo/statuses/70c0d534400ab8c819eadc6879fb8a61e3da5571","head":{"label":"Benglin:Multiverse","ref":"Multiverse","sha":"70c0d534400ab8c819eadc6879fb8a61e3da5571","user":{"login":"Benglin","id":5086849,"avatar_url":"https://avatars.githubusercontent.com/u/5086849?v=3","gravatar_id":"","url":"https://api.github.com/users/Benglin","html_url":"https://github.com/Benglin","followers_url":"https://api.github.com/users/Benglin/followers","following_url":"https://api.github.com/users/Benglin/following{/other_user}","gists_url":"https://api.github.com/users/Benglin/gists{/gist_id}","starred_url":"https://api.github.com/users/Benglin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Benglin/subscriptions","organizations_url":"https://api.github.com/users/Benglin/orgs","repos_url":"https://api.github.com/users/Benglin/repos","events_url":"https://api.github.com/users/Benglin/events{/privacy}","received_events_url":"https://api.github.com/users/Benglin/received_events","type":"User","site_admin":false},"repo":{"id":11675425,"name":"Dynamo","full_name":"Benglin/Dynamo","owner":{"login":"Benglin","id":5086849,"avatar_url":"https://avatars.githubusercontent.com/u/5086849?v=3","gravatar_id":"","url":"https://api.github.com/users/Benglin","html_url":"https://github.com/Benglin","followers_url":"https://api.github.com/users/Benglin/followers","following_url":"https://api.github.com/users/Benglin/following{/other_user}","gists_url":"https://api.github.com/users/Benglin/gists{/gist_id}","starred_url":"https://api.github.com/users/Benglin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Benglin/subscriptions","organizations_url":"https://api.github.com/users/Benglin/orgs","repos_url":"https://api.github.com/users/Benglin/repos","events_url":"https://api.github.com/users/Benglin/events{/privacy}","received_events_url":"https://api.github.com/users/Benglin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Benglin/Dynamo","description":"Visual Programming For Revit","fork":true,"url":"https://api.github.com/repos/Benglin/Dynamo","forks_url":"https://api.github.com/repos/Benglin/Dynamo/forks","keys_url":"https://api.github.com/repos/Benglin/Dynamo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Benglin/Dynamo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Benglin/Dynamo/teams","hooks_url":"https://api.github.com/repos/Benglin/Dynamo/hooks","issue_events_url":"https://api.github.com/repos/Benglin/Dynamo/issues/events{/number}","events_url":"https://api.github.com/repos/Benglin/Dynamo/events","assignees_url":"https://api.github.com/repos/Benglin/Dynamo/assignees{/user}","branches_url":"https://api.github.com/repos/Benglin/Dynamo/branches{/branch}","tags_url":"https://api.github.com/repos/Benglin/Dynamo/tags","blobs_url":"https://api.github.com/repos/Benglin/Dynamo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Benglin/Dynamo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Benglin/Dynamo/git/refs{/sha}","trees_url":"https://api.github.com/repos/Benglin/Dynamo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Benglin/Dynamo/statuses/{sha}","languages_url":"https://api.github.com/repos/Benglin/Dynamo/languages","stargazers_url":"https://api.github.com/repos/Benglin/Dynamo/stargazers","contributors_url":"https://api.github.com/repos/Benglin/Dynamo/contributors","subscribers_url":"https://api.github.com/repos/Benglin/Dynamo/subscribers","subscription_url":"https://api.github.com/repos/Benglin/Dynamo/subscription","commits_url":"https://api.github.com/repos/Benglin/Dynamo/commits{/sha}","git_commits_url":"https://api.github.com/repos/Benglin/Dynamo/git/commits{/sha}","comments_url":"https://api.github.com/repos/Benglin/Dynamo/comments{/number}","issue_comment_url":"https://api.github.com/repos/Benglin/Dynamo/issues/comments{/number}","contents_url":"https://api.github.com/repos/Benglin/Dynamo/contents/{+path}","compare_url":"https://api.github.com/repos/Benglin/Dynamo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Benglin/Dynamo/merges","archive_url":"https://api.github.com/repos/Benglin/Dynamo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Benglin/Dynamo/downloads","issues_url":"https://api.github.com/repos/Benglin/Dynamo/issues{/number}","pulls_url":"https://api.github.com/repos/Benglin/Dynamo/pulls{/number}","milestones_url":"https://api.github.com/repos/Benglin/Dynamo/milestones{/number}","notifications_url":"https://api.github.com/repos/Benglin/Dynamo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Benglin/Dynamo/labels{/name}","releases_url":"https://api.github.com/repos/Benglin/Dynamo/releases{/id}","created_at":"2013-07-26T01:54:49Z","updated_at":"2015-05-07T02:09:45Z","pushed_at":"2015-08-03T02:04:55Z","git_url":"git://github.com/Benglin/Dynamo.git","ssh_url":"git@github.com:Benglin/Dynamo.git","clone_url":"https://github.com/Benglin/Dynamo.git","svn_url":"https://github.com/Benglin/Dynamo","homepage":"http://dynamobim.org","size":855959,"stargazers_count":2,"watchers_count":2,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"ke-yu:Multiverse","ref":"Multiverse","sha":"38de68da445f32c61a3fb9706c80ef068a29336b","user":{"login":"ke-yu","id":2600379,"avatar_url":"https://avatars.githubusercontent.com/u/2600379?v=3","gravatar_id":"","url":"https://api.github.com/users/ke-yu","html_url":"https://github.com/ke-yu","followers_url":"https://api.github.com/users/ke-yu/followers","following_url":"https://api.github.com/users/ke-yu/following{/other_user}","gists_url":"https://api.github.com/users/ke-yu/gists{/gist_id}","starred_url":"https://api.github.com/users/ke-yu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ke-yu/subscriptions","organizations_url":"https://api.github.com/users/ke-yu/orgs","repos_url":"https://api.github.com/users/ke-yu/repos","events_url":"https://api.github.com/users/ke-yu/events{/privacy}","received_events_url":"https://api.github.com/users/ke-yu/received_events","type":"User","site_admin":false},"repo":{"id":18300645,"name":"Dynamo","full_name":"ke-yu/Dynamo","owner":{"login":"ke-yu","id":2600379,"avatar_url":"https://avatars.githubusercontent.com/u/2600379?v=3","gravatar_id":"","url":"https://api.github.com/users/ke-yu","html_url":"https://github.com/ke-yu","followers_url":"https://api.github.com/users/ke-yu/followers","following_url":"https://api.github.com/users/ke-yu/following{/other_user}","gists_url":"https://api.github.com/users/ke-yu/gists{/gist_id}","starred_url":"https://api.github.com/users/ke-yu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ke-yu/subscriptions","organizations_url":"https://api.github.com/users/ke-yu/orgs","repos_url":"https://api.github.com/users/ke-yu/repos","events_url":"https://api.github.com/users/ke-yu/events{/privacy}","received_events_url":"https://api.github.com/users/ke-yu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ke-yu/Dynamo","description":"Visual Programming For Revit","fork":true,"url":"https://api.github.com/repos/ke-yu/Dynamo","forks_url":"https://api.github.com/repos/ke-yu/Dynamo/forks","keys_url":"https://api.github.com/repos/ke-yu/Dynamo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ke-yu/Dynamo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ke-yu/Dynamo/teams","hooks_url":"https://api.github.com/repos/ke-yu/Dynamo/hooks","issue_events_url":"https://api.github.com/repos/ke-yu/Dynamo/issues/events{/number}","events_url":"https://api.github.com/repos/ke-yu/Dynamo/events","assignees_url":"https://api.github.com/repos/ke-yu/Dynamo/assignees{/user}","branches_url":"https://api.github.com/repos/ke-yu/Dynamo/branches{/branch}","tags_url":"https://api.github.com/repos/ke-yu/Dynamo/tags","blobs_url":"https://api.github.com/repos/ke-yu/Dynamo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ke-yu/Dynamo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ke-yu/Dynamo/git/refs{/sha}","trees_url":"https://api.github.com/repos/ke-yu/Dynamo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ke-yu/Dynamo/statuses/{sha}","languages_url":"https://api.github.com/repos/ke-yu/Dynamo/languages","stargazers_url":"https://api.github.com/repos/ke-yu/Dynamo/stargazers","contributors_url":"https://api.github.com/repos/ke-yu/Dynamo/contributors","subscribers_url":"https://api.github.com/repos/ke-yu/Dynamo/subscribers","subscription_url":"https://api.github.com/repos/ke-yu/Dynamo/subscription","commits_url":"https://api.github.com/repos/ke-yu/Dynamo/commits{/sha}","git_commits_url":"https://api.github.com/repos/ke-yu/Dynamo/git/commits{/sha}","comments_url":"https://api.github.com/repos/ke-yu/Dynamo/comments{/number}","issue_comment_url":"https://api.github.com/repos/ke-yu/Dynamo/issues/comments{/number}","contents_url":"https://api.github.com/repos/ke-yu/Dynamo/contents/{+path}","compare_url":"https://api.github.com/repos/ke-yu/Dynamo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ke-yu/Dynamo/merges","archive_url":"https://api.github.com/repos/ke-yu/Dynamo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ke-yu/Dynamo/downloads","issues_url":"https://api.github.com/repos/ke-yu/Dynamo/issues{/number}","pulls_url":"https://api.github.com/repos/ke-yu/Dynamo/pulls{/number}","milestones_url":"https://api.github.com/repos/ke-yu/Dynamo/milestones{/number}","notifications_url":"https://api.github.com/repos/ke-yu/Dynamo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ke-yu/Dynamo/labels{/name}","releases_url":"https://api.github.com/repos/ke-yu/Dynamo/releases{/id}","created_at":"2014-03-31T16:53:50Z","updated_at":"2014-06-26T05:45:55Z","pushed_at":"2015-08-03T02:21:45Z","git_url":"git://github.com/ke-yu/Dynamo.git","ssh_url":"git@github.com:ke-yu/Dynamo.git","clone_url":"https://github.com/ke-yu/Dynamo.git","svn_url":"https://github.com/ke-yu/Dynamo","homepage":"http://dynamobim.org","size":730161,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ke-yu/Dynamo/pulls/15"},"html":{"href":"https://github.com/ke-yu/Dynamo/pull/15"},"issue":{"href":"https://api.github.com/repos/ke-yu/Dynamo/issues/15"},"comments":{"href":"https://api.github.com/repos/ke-yu/Dynamo/issues/15/comments"},"review_comments":{"href":"https://api.github.com/repos/ke-yu/Dynamo/pulls/15/comments"},"review_comment":{"href":"https://api.github.com/repos/ke-yu/Dynamo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ke-yu/Dynamo/pulls/15/commits"},"statuses":{"href":"https://api.github.com/repos/ke-yu/Dynamo/statuses/70c0d534400ab8c819eadc6879fb8a61e3da5571"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"Benglin","id":5086849,"avatar_url":"https://avatars.githubusercontent.com/u/5086849?v=3","gravatar_id":"","url":"https://api.github.com/users/Benglin","html_url":"https://github.com/Benglin","followers_url":"https://api.github.com/users/Benglin/followers","following_url":"https://api.github.com/users/Benglin/following{/other_user}","gists_url":"https://api.github.com/users/Benglin/gists{/gist_id}","starred_url":"https://api.github.com/users/Benglin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Benglin/subscriptions","organizations_url":"https://api.github.com/users/Benglin/orgs","repos_url":"https://api.github.com/users/Benglin/repos","events_url":"https://api.github.com/users/Benglin/events{/privacy}","received_events_url":"https://api.github.com/users/Benglin/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":6,"additions":250,"deletions":30,"changed_files":6}}