{"action":"created","comment":{"url":"https://api.github.com/repos/protegeproject/protege-owlapi/pulls/comments/28015772","id":28015772,"diff_hunk":"@@ -1318,4 +1297,861 @@ public boolean isTopEntity() {\n         }\n     } \n     \n+    @Override\n+    public void accept(OWLNamedObjectVisitor visitor) {\n+        readLock.lock();\n+        try {\n+            delegate.accept(visitor);\n+        } finally {\n+            readLock.unlock();\n+        }\n+    }\n+\n+    @Override\n+    public <O> O accept(OWLNamedObjectVisitorEx<O> visitor) {\n+        readLock.lock();\n+        try {\n+            return delegate.accept(visitor);\n+        } finally {\n+            readLock.unlock();\n+        }\n+    }\n+\n+    @Override\n+    public void setOWLOntologyManager(OWLOntologyManager saveOntology) {\n+        writeLock.lock();\n+        try {\n+            delegate.setOWLOntologyManager(saveOntology);\n+        } finally {\n+            writeLock.unlock();\n+        }\n+    }\n+\n+    @Override\n+    public void saveOntology() throws OWLOntologyStorageException {\n+        writeLock.lock();","path":"src/main/java/org/protege/owlapi/concurrent/WriteSafeOWLOntologyImpl.java","position":1196,"original_position":1196,"commit_id":"c8fb90c9d3b92d31ea9a38dd057dab9e8bbf42f9","original_commit_id":"c8fb90c9d3b92d31ea9a38dd057dab9e8bbf42f9","user":{"login":"matthewhorridge","id":488607,"avatar_url":"https://avatars.githubusercontent.com/u/488607?v=3","gravatar_id":"","url":"https://api.github.com/users/matthewhorridge","html_url":"https://github.com/matthewhorridge","followers_url":"https://api.github.com/users/matthewhorridge/followers","following_url":"https://api.github.com/users/matthewhorridge/following{/other_user}","gists_url":"https://api.github.com/users/matthewhorridge/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewhorridge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewhorridge/subscriptions","organizations_url":"https://api.github.com/users/matthewhorridge/orgs","repos_url":"https://api.github.com/users/matthewhorridge/repos","events_url":"https://api.github.com/users/matthewhorridge/events{/privacy}","received_events_url":"https://api.github.com/users/matthewhorridge/received_events","type":"User","site_admin":false},"body":"> I was thinking of tests that would attempt to access an ontology from multiple....\r\n\r\nAh right, more than a unit test then.  Sorry, I don't have these.\r\n\r\n> Regarding listeners and other ancillary collections in the managers, I'd be more tempted to synchronize on the collection itself, \r\n\r\nWell, what ever is equivalent.\r\n\r\n> or use synchronized collections \r\n\r\nI'm not sure this is a good idea.\r\n\r\n> Also, they are completely separate from ontology data, I believe - unless we want to guarantee that a listener receives all changes sent by a thread up until it gets removed from the manager by another thread?\r\n\r\nYes, something like this. \r\n\r\n> My head is spinning a bit now, I think we're describing two different sets of changes.\r\n\r\n:)","created_at":"2015-04-08T21:31:53Z","updated_at":"2015-04-08T21:31:53Z","html_url":"https://github.com/protegeproject/protege-owlapi/pull/3#discussion_r28015772","pull_request_url":"https://api.github.com/repos/protegeproject/protege-owlapi/pulls/3","_links":{"self":{"href":"https://api.github.com/repos/protegeproject/protege-owlapi/pulls/comments/28015772"},"html":{"href":"https://github.com/protegeproject/protege-owlapi/pull/3#discussion_r28015772"},"pull_request":{"href":"https://api.github.com/repos/protegeproject/protege-owlapi/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/protegeproject/protege-owlapi/pulls/3","id":16304138,"html_url":"https://github.com/protegeproject/protege-owlapi/pull/3","diff_url":"https://github.com/protegeproject/protege-owlapi/pull/3.diff","patch_url":"https://github.com/protegeproject/protege-owlapi/pull/3.patch","issue_url":"https://api.github.com/repos/protegeproject/protege-owlapi/issues/3","number":3,"state":"open","locked":false,"title":"Port to OWL API 4.0.2","user":{"login":"ignazio1977","id":2596901,"avatar_url":"https://avatars.githubusercontent.com/u/2596901?v=3","gravatar_id":"","url":"https://api.github.com/users/ignazio1977","html_url":"https://github.com/ignazio1977","followers_url":"https://api.github.com/users/ignazio1977/followers","following_url":"https://api.github.com/users/ignazio1977/following{/other_user}","gists_url":"https://api.github.com/users/ignazio1977/gists{/gist_id}","starred_url":"https://api.github.com/users/ignazio1977/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ignazio1977/subscriptions","organizations_url":"https://api.github.com/users/ignazio1977/orgs","repos_url":"https://api.github.com/users/ignazio1977/repos","events_url":"https://api.github.com/users/ignazio1977/events{/privacy}","received_events_url":"https://api.github.com/users/ignazio1977/received_events","type":"User","site_admin":false},"body":"Made the necessary changes to compile and build with OWLAPI 4.0.2.\r\nI've made a local release of 4.0.2 so that I can point POMS at it, so this won't build correctly until 4.0.2 is releases.","created_at":"2014-05-24T08:47:43Z","updated_at":"2015-04-08T21:31:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bbd2f50de0fb1520474d5e22433e95c480b2c800","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/protegeproject/protege-owlapi/pulls/3/commits","review_comments_url":"https://api.github.com/repos/protegeproject/protege-owlapi/pulls/3/comments","review_comment_url":"https://api.github.com/repos/protegeproject/protege-owlapi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/protegeproject/protege-owlapi/issues/3/comments","statuses_url":"https://api.github.com/repos/protegeproject/protege-owlapi/statuses/c8fb90c9d3b92d31ea9a38dd057dab9e8bbf42f9","head":{"label":"ignazio1977:master","ref":"master","sha":"c8fb90c9d3b92d31ea9a38dd057dab9e8bbf42f9","user":{"login":"ignazio1977","id":2596901,"avatar_url":"https://avatars.githubusercontent.com/u/2596901?v=3","gravatar_id":"","url":"https://api.github.com/users/ignazio1977","html_url":"https://github.com/ignazio1977","followers_url":"https://api.github.com/users/ignazio1977/followers","following_url":"https://api.github.com/users/ignazio1977/following{/other_user}","gists_url":"https://api.github.com/users/ignazio1977/gists{/gist_id}","starred_url":"https://api.github.com/users/ignazio1977/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ignazio1977/subscriptions","organizations_url":"https://api.github.com/users/ignazio1977/orgs","repos_url":"https://api.github.com/users/ignazio1977/repos","events_url":"https://api.github.com/users/ignazio1977/events{/privacy}","received_events_url":"https://api.github.com/users/ignazio1977/received_events","type":"User","site_admin":false},"repo":{"id":19917491,"name":"protege-owlapi","full_name":"ignazio1977/protege-owlapi","owner":{"login":"ignazio1977","id":2596901,"avatar_url":"https://avatars.githubusercontent.com/u/2596901?v=3","gravatar_id":"","url":"https://api.github.com/users/ignazio1977","html_url":"https://github.com/ignazio1977","followers_url":"https://api.github.com/users/ignazio1977/followers","following_url":"https://api.github.com/users/ignazio1977/following{/other_user}","gists_url":"https://api.github.com/users/ignazio1977/gists{/gist_id}","starred_url":"https://api.github.com/users/ignazio1977/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ignazio1977/subscriptions","organizations_url":"https://api.github.com/users/ignazio1977/orgs","repos_url":"https://api.github.com/users/ignazio1977/repos","events_url":"https://api.github.com/users/ignazio1977/events{/privacy}","received_events_url":"https://api.github.com/users/ignazio1977/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ignazio1977/protege-owlapi","description":"Extensions to the OWL API for Protege","fork":true,"url":"https://api.github.com/repos/ignazio1977/protege-owlapi","forks_url":"https://api.github.com/repos/ignazio1977/protege-owlapi/forks","keys_url":"https://api.github.com/repos/ignazio1977/protege-owlapi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ignazio1977/protege-owlapi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ignazio1977/protege-owlapi/teams","hooks_url":"https://api.github.com/repos/ignazio1977/protege-owlapi/hooks","issue_events_url":"https://api.github.com/repos/ignazio1977/protege-owlapi/issues/events{/number}","events_url":"https://api.github.com/repos/ignazio1977/protege-owlapi/events","assignees_url":"https://api.github.com/repos/ignazio1977/protege-owlapi/assignees{/user}","branches_url":"https://api.github.com/repos/ignazio1977/protege-owlapi/branches{/branch}","tags_url":"https://api.github.com/repos/ignazio1977/protege-owlapi/tags","blobs_url":"https://api.github.com/repos/ignazio1977/protege-owlapi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ignazio1977/protege-owlapi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ignazio1977/protege-owlapi/git/refs{/sha}","trees_url":"https://api.github.com/repos/ignazio1977/protege-owlapi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ignazio1977/protege-owlapi/statuses/{sha}","languages_url":"https://api.github.com/repos/ignazio1977/protege-owlapi/languages","stargazers_url":"https://api.github.com/repos/ignazio1977/protege-owlapi/stargazers","contributors_url":"https://api.github.com/repos/ignazio1977/protege-owlapi/contributors","subscribers_url":"https://api.github.com/repos/ignazio1977/protege-owlapi/subscribers","subscription_url":"https://api.github.com/repos/ignazio1977/protege-owlapi/subscription","commits_url":"https://api.github.com/repos/ignazio1977/protege-owlapi/commits{/sha}","git_commits_url":"https://api.github.com/repos/ignazio1977/protege-owlapi/git/commits{/sha}","comments_url":"https://api.github.com/repos/ignazio1977/protege-owlapi/comments{/number}","issue_comment_url":"https://api.github.com/repos/ignazio1977/protege-owlapi/issues/comments{/number}","contents_url":"https://api.github.com/repos/ignazio1977/protege-owlapi/contents/{+path}","compare_url":"https://api.github.com/repos/ignazio1977/protege-owlapi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ignazio1977/protege-owlapi/merges","archive_url":"https://api.github.com/repos/ignazio1977/protege-owlapi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ignazio1977/protege-owlapi/downloads","issues_url":"https://api.github.com/repos/ignazio1977/protege-owlapi/issues{/number}","pulls_url":"https://api.github.com/repos/ignazio1977/protege-owlapi/pulls{/number}","milestones_url":"https://api.github.com/repos/ignazio1977/protege-owlapi/milestones{/number}","notifications_url":"https://api.github.com/repos/ignazio1977/protege-owlapi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ignazio1977/protege-owlapi/labels{/name}","releases_url":"https://api.github.com/repos/ignazio1977/protege-owlapi/releases{/id}","created_at":"2014-05-18T18:19:04Z","updated_at":"2015-03-25T20:12:41Z","pushed_at":"2015-03-28T23:23:49Z","git_url":"git://github.com/ignazio1977/protege-owlapi.git","ssh_url":"git@github.com:ignazio1977/protege-owlapi.git","clone_url":"https://github.com/ignazio1977/protege-owlapi.git","svn_url":"https://github.com/ignazio1977/protege-owlapi","homepage":null,"size":3995,"stargazers_count":0,"watchers_count":0,"language":"Web Ontology Language","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"protegeproject:master","ref":"master","sha":"8e395bc5989eb7a41abc7b967694b81691a30dc2","user":{"login":"protegeproject","id":1696943,"avatar_url":"https://avatars.githubusercontent.com/u/1696943?v=3","gravatar_id":"","url":"https://api.github.com/users/protegeproject","html_url":"https://github.com/protegeproject","followers_url":"https://api.github.com/users/protegeproject/followers","following_url":"https://api.github.com/users/protegeproject/following{/other_user}","gists_url":"https://api.github.com/users/protegeproject/gists{/gist_id}","starred_url":"https://api.github.com/users/protegeproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/protegeproject/subscriptions","organizations_url":"https://api.github.com/users/protegeproject/orgs","repos_url":"https://api.github.com/users/protegeproject/repos","events_url":"https://api.github.com/users/protegeproject/events{/privacy}","received_events_url":"https://api.github.com/users/protegeproject/received_events","type":"Organization","site_admin":false},"repo":{"id":14733095,"name":"protege-owlapi","full_name":"protegeproject/protege-owlapi","owner":{"login":"protegeproject","id":1696943,"avatar_url":"https://avatars.githubusercontent.com/u/1696943?v=3","gravatar_id":"","url":"https://api.github.com/users/protegeproject","html_url":"https://github.com/protegeproject","followers_url":"https://api.github.com/users/protegeproject/followers","following_url":"https://api.github.com/users/protegeproject/following{/other_user}","gists_url":"https://api.github.com/users/protegeproject/gists{/gist_id}","starred_url":"https://api.github.com/users/protegeproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/protegeproject/subscriptions","organizations_url":"https://api.github.com/users/protegeproject/orgs","repos_url":"https://api.github.com/users/protegeproject/repos","events_url":"https://api.github.com/users/protegeproject/events{/privacy}","received_events_url":"https://api.github.com/users/protegeproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/protegeproject/protege-owlapi","description":"Extensions to the OWL API for Protege","fork":false,"url":"https://api.github.com/repos/protegeproject/protege-owlapi","forks_url":"https://api.github.com/repos/protegeproject/protege-owlapi/forks","keys_url":"https://api.github.com/repos/protegeproject/protege-owlapi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/protegeproject/protege-owlapi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/protegeproject/protege-owlapi/teams","hooks_url":"https://api.github.com/repos/protegeproject/protege-owlapi/hooks","issue_events_url":"https://api.github.com/repos/protegeproject/protege-owlapi/issues/events{/number}","events_url":"https://api.github.com/repos/protegeproject/protege-owlapi/events","assignees_url":"https://api.github.com/repos/protegeproject/protege-owlapi/assignees{/user}","branches_url":"https://api.github.com/repos/protegeproject/protege-owlapi/branches{/branch}","tags_url":"https://api.github.com/repos/protegeproject/protege-owlapi/tags","blobs_url":"https://api.github.com/repos/protegeproject/protege-owlapi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/protegeproject/protege-owlapi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/protegeproject/protege-owlapi/git/refs{/sha}","trees_url":"https://api.github.com/repos/protegeproject/protege-owlapi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/protegeproject/protege-owlapi/statuses/{sha}","languages_url":"https://api.github.com/repos/protegeproject/protege-owlapi/languages","stargazers_url":"https://api.github.com/repos/protegeproject/protege-owlapi/stargazers","contributors_url":"https://api.github.com/repos/protegeproject/protege-owlapi/contributors","subscribers_url":"https://api.github.com/repos/protegeproject/protege-owlapi/subscribers","subscription_url":"https://api.github.com/repos/protegeproject/protege-owlapi/subscription","commits_url":"https://api.github.com/repos/protegeproject/protege-owlapi/commits{/sha}","git_commits_url":"https://api.github.com/repos/protegeproject/protege-owlapi/git/commits{/sha}","comments_url":"https://api.github.com/repos/protegeproject/protege-owlapi/comments{/number}","issue_comment_url":"https://api.github.com/repos/protegeproject/protege-owlapi/issues/comments{/number}","contents_url":"https://api.github.com/repos/protegeproject/protege-owlapi/contents/{+path}","compare_url":"https://api.github.com/repos/protegeproject/protege-owlapi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/protegeproject/protege-owlapi/merges","archive_url":"https://api.github.com/repos/protegeproject/protege-owlapi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/protegeproject/protege-owlapi/downloads","issues_url":"https://api.github.com/repos/protegeproject/protege-owlapi/issues{/number}","pulls_url":"https://api.github.com/repos/protegeproject/protege-owlapi/pulls{/number}","milestones_url":"https://api.github.com/repos/protegeproject/protege-owlapi/milestones{/number}","notifications_url":"https://api.github.com/repos/protegeproject/protege-owlapi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/protegeproject/protege-owlapi/labels{/name}","releases_url":"https://api.github.com/repos/protegeproject/protege-owlapi/releases{/id}","created_at":"2013-11-27T00:17:12Z","updated_at":"2015-04-07T22:21:49Z","pushed_at":"2015-04-07T22:21:49Z","git_url":"git://github.com/protegeproject/protege-owlapi.git","ssh_url":"git@github.com:protegeproject/protege-owlapi.git","clone_url":"https://github.com/protegeproject/protege-owlapi.git","svn_url":"https://github.com/protegeproject/protege-owlapi","homepage":null,"size":4146,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":3,"forks":4,"open_issues":3,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/protegeproject/protege-owlapi/pulls/3"},"html":{"href":"https://github.com/protegeproject/protege-owlapi/pull/3"},"issue":{"href":"https://api.github.com/repos/protegeproject/protege-owlapi/issues/3"},"comments":{"href":"https://api.github.com/repos/protegeproject/protege-owlapi/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/protegeproject/protege-owlapi/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/protegeproject/protege-owlapi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/protegeproject/protege-owlapi/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/protegeproject/protege-owlapi/statuses/c8fb90c9d3b92d31ea9a38dd057dab9e8bbf42f9"}}}}