{"action":"created","issue":{"url":"https://api.github.com/repos/sequelize/sequelize/issues/2976","labels_url":"https://api.github.com/repos/sequelize/sequelize/issues/2976/labels{/name}","comments_url":"https://api.github.com/repos/sequelize/sequelize/issues/2976/comments","events_url":"https://api.github.com/repos/sequelize/sequelize/issues/2976/events","html_url":"https://github.com/sequelize/sequelize/pull/2976","id":54923113,"number":2976,"title":"refactor: initial work on sql unit tests refactor","user":{"login":"mickhansen","id":699049,"avatar_url":"https://avatars.githubusercontent.com/u/699049?v=3","gravatar_id":"","url":"https://api.github.com/users/mickhansen","html_url":"https://github.com/mickhansen","followers_url":"https://api.github.com/users/mickhansen/followers","following_url":"https://api.github.com/users/mickhansen/following{/other_user}","gists_url":"https://api.github.com/users/mickhansen/gists{/gist_id}","starred_url":"https://api.github.com/users/mickhansen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mickhansen/subscriptions","organizations_url":"https://api.github.com/users/mickhansen/orgs","repos_url":"https://api.github.com/users/mickhansen/repos","events_url":"https://api.github.com/users/mickhansen/events{/privacy}","received_events_url":"https://api.github.com/users/mickhansen/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-01-20T18:53:12Z","updated_at":"2015-01-22T10:05:38Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/sequelize/sequelize/pulls/2976","html_url":"https://github.com/sequelize/sequelize/pull/2976","diff_url":"https://github.com/sequelize/sequelize/pull/2976.diff","patch_url":"https://github.com/sequelize/sequelize/pull/2976.patch"},"body":"Very much work in progress"},"comment":{"url":"https://api.github.com/repos/sequelize/sequelize/issues/comments/70997586","html_url":"https://github.com/sequelize/sequelize/pull/2976#issuecomment-70997586","issue_url":"https://api.github.com/repos/sequelize/sequelize/issues/2976","id":70997586,"user":{"login":"janmeier","id":1210224,"avatar_url":"https://avatars.githubusercontent.com/u/1210224?v=3","gravatar_id":"","url":"https://api.github.com/users/janmeier","html_url":"https://github.com/janmeier","followers_url":"https://api.github.com/users/janmeier/followers","following_url":"https://api.github.com/users/janmeier/following{/other_user}","gists_url":"https://api.github.com/users/janmeier/gists{/gist_id}","starred_url":"https://api.github.com/users/janmeier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janmeier/subscriptions","organizations_url":"https://api.github.com/users/janmeier/orgs","repos_url":"https://api.github.com/users/janmeier/repos","events_url":"https://api.github.com/users/janmeier/events{/privacy}","received_events_url":"https://api.github.com/users/janmeier/received_events","type":"User","site_admin":false},"created_at":"2015-01-22T10:05:38Z","updated_at":"2015-01-22T10:05:38Z","body":"Well my though was that for cases that require escaped ticks we write them out for each dialect. But for example:\r\n\r\n```js\r\n {\r\n        default: \"`deleted` NOT NULL\",\r\n        postgres: '\"deleted\" NOT NULL',\r\n        mssql: \"[deleted] NOT NULL\"\r\n}\r\n```\r\n\r\nWe could just write the default and in expectsql do \r\n\r\n```js\r\nif (!(dialect in expectations)) {\r\n  expectations[dialect] = expectations.default.replace('`', '\"')\r\n}\r\n``` \r\n\r\nFor postgres at least ... One issue would be however that mssql uses both `[` and `]` - so perhaps that should be the default"}}