{"action":"created","comment":{"url":"https://api.github.com/repos/OpenXT/xenclient-oe/pulls/comments/28025967","id":28025967,"diff_hunk":"@@ -12,15 +12,19 @@ DEPENDS = \"xen-tools alsa-lib pciutils libpng blktap libxenacpi libv4v openssl z\n #            file://0010-xc-emulated-nic-link-state-propagation.patch;striplevel=1 \\\n #            file://0012-audio-alsa.patch;striplevel=1 \\\n #            file://0014-audio-alsa-stub.patch;striplevel=1 \\\n-#            file://0020-audio-policy.patch;striplevel=1 \\\n #            file://0026-openxtaudio.patch;striplevel=1 \\\n+#            file://0007-pci-reserve-igd-slot.patch;striplevel=1 \\","path":"recipes-openxt/qemu-dm/qemu-dm.inc","position":6,"original_position":6,"commit_id":"92be56706d6eb1481af194f923cfbfdc946063e1","original_commit_id":"92be56706d6eb1481af194f923cfbfdc946063e1","user":{"login":"rianquinn","id":5932003,"avatar_url":"https://avatars.githubusercontent.com/u/5932003?v=3","gravatar_id":"","url":"https://api.github.com/users/rianquinn","html_url":"https://github.com/rianquinn","followers_url":"https://api.github.com/users/rianquinn/followers","following_url":"https://api.github.com/users/rianquinn/following{/other_user}","gists_url":"https://api.github.com/users/rianquinn/gists{/gist_id}","starred_url":"https://api.github.com/users/rianquinn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rianquinn/subscriptions","organizations_url":"https://api.github.com/users/rianquinn/orgs","repos_url":"https://api.github.com/users/rianquinn/repos","events_url":"https://api.github.com/users/rianquinn/events{/privacy}","received_events_url":"https://api.github.com/users/rianquinn/received_events","type":"User","site_admin":false},"body":"Yes","created_at":"2015-04-09T00:02:34Z","updated_at":"2015-04-09T00:02:34Z","html_url":"https://github.com/OpenXT/xenclient-oe/pull/83#discussion_r28025967","pull_request_url":"https://api.github.com/repos/OpenXT/xenclient-oe/pulls/83","_links":{"self":{"href":"https://api.github.com/repos/OpenXT/xenclient-oe/pulls/comments/28025967"},"html":{"href":"https://github.com/OpenXT/xenclient-oe/pull/83#discussion_r28025967"},"pull_request":{"href":"https://api.github.com/repos/OpenXT/xenclient-oe/pulls/83"}}},"pull_request":{"url":"https://api.github.com/repos/OpenXT/xenclient-oe/pulls/83","id":32901056,"html_url":"https://github.com/OpenXT/xenclient-oe/pull/83","diff_url":"https://github.com/OpenXT/xenclient-oe/pull/83.diff","patch_url":"https://github.com/OpenXT/xenclient-oe/pull/83.patch","issue_url":"https://api.github.com/repos/OpenXT/xenclient-oe/issues/83","number":83,"state":"open","locked":false,"title":"New audio code","user":{"login":"rianquinn","id":5932003,"avatar_url":"https://avatars.githubusercontent.com/u/5932003?v=3","gravatar_id":"","url":"https://api.github.com/users/rianquinn","html_url":"https://github.com/rianquinn","followers_url":"https://api.github.com/users/rianquinn/followers","following_url":"https://api.github.com/users/rianquinn/following{/other_user}","gists_url":"https://api.github.com/users/rianquinn/gists{/gist_id}","starred_url":"https://api.github.com/users/rianquinn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rianquinn/subscriptions","organizations_url":"https://api.github.com/users/rianquinn/orgs","repos_url":"https://api.github.com/users/rianquinn/repos","events_url":"https://api.github.com/users/rianquinn/events{/privacy}","received_events_url":"https://api.github.com/users/rianquinn/received_events","type":"User","site_admin":false},"body":"New audio code\r\n\r\nLong description:\r\nThese changes bring in a bunch of audio fixes, including a new audio\r\nfront/back driver model for QEMU 1.4. The following was addressed:\r\n- General quest instability\r\n- Performance issues with capture and playback (there were a lot\r\n  of unneeded world switches due to v4v API)\r\n- Security cleanup (the old code had known buffer overflow attacks\r\n  and handle rewrite attack vulnerabilities)\r\n- Added error validation (the old code had little to no error checks)\r\n- Bugs with amixer patch. The patch was moved to the audio helper removing\r\n  the need to patch ALSA. This was a relatively easy thing to do as the\r\n  audio helper and amixer have to do the same kind of tasks\r\n- Changes to init script (the old init script over-wrote the ALSA state\r\n  on reboot, so settings in the UIVM would roll-back on each reboot)\r\n- Patch queue cleanup\r\n- Recipe cleanup\r\n- SELinux work to support init script\r\n\r\nBugs:\r\nOXT-133: Qemu 1.4 crash during tools install\r\nOXT-220: Qemu 1.4: sometimes the VM volume defaults to 0\r\nOXT-234: amixer patch\r\nOXT-189: Mic mute not working\r\nOXT-196: Audio on Dell Latitude E6540\r\nOXT-195: Audio on HP 2570p\r\nOXT-194: Audio Capture Setting not working\r\n\r\nSinged-off-by: Rian Quinn <quinnr@ainfosec.com>","created_at":"2015-04-08T20:55:22Z","updated_at":"2015-04-09T00:02:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a138f3db3649c8e4fed8af3ee2139e77234bfed0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/OpenXT/xenclient-oe/pulls/83/commits","review_comments_url":"https://api.github.com/repos/OpenXT/xenclient-oe/pulls/83/comments","review_comment_url":"https://api.github.com/repos/OpenXT/xenclient-oe/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenXT/xenclient-oe/issues/83/comments","statuses_url":"https://api.github.com/repos/OpenXT/xenclient-oe/statuses/92be56706d6eb1481af194f923cfbfdc946063e1","head":{"label":"rianquinn:audio-next","ref":"audio-next","sha":"92be56706d6eb1481af194f923cfbfdc946063e1","user":{"login":"rianquinn","id":5932003,"avatar_url":"https://avatars.githubusercontent.com/u/5932003?v=3","gravatar_id":"","url":"https://api.github.com/users/rianquinn","html_url":"https://github.com/rianquinn","followers_url":"https://api.github.com/users/rianquinn/followers","following_url":"https://api.github.com/users/rianquinn/following{/other_user}","gists_url":"https://api.github.com/users/rianquinn/gists{/gist_id}","starred_url":"https://api.github.com/users/rianquinn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rianquinn/subscriptions","organizations_url":"https://api.github.com/users/rianquinn/orgs","repos_url":"https://api.github.com/users/rianquinn/repos","events_url":"https://api.github.com/users/rianquinn/events{/privacy}","received_events_url":"https://api.github.com/users/rianquinn/received_events","type":"User","site_admin":false},"repo":{"id":33630951,"name":"xenclient-oe","full_name":"rianquinn/xenclient-oe","owner":{"login":"rianquinn","id":5932003,"avatar_url":"https://avatars.githubusercontent.com/u/5932003?v=3","gravatar_id":"","url":"https://api.github.com/users/rianquinn","html_url":"https://github.com/rianquinn","followers_url":"https://api.github.com/users/rianquinn/followers","following_url":"https://api.github.com/users/rianquinn/following{/other_user}","gists_url":"https://api.github.com/users/rianquinn/gists{/gist_id}","starred_url":"https://api.github.com/users/rianquinn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rianquinn/subscriptions","organizations_url":"https://api.github.com/users/rianquinn/orgs","repos_url":"https://api.github.com/users/rianquinn/repos","events_url":"https://api.github.com/users/rianquinn/events{/privacy}","received_events_url":"https://api.github.com/users/rianquinn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rianquinn/xenclient-oe","description":"","fork":true,"url":"https://api.github.com/repos/rianquinn/xenclient-oe","forks_url":"https://api.github.com/repos/rianquinn/xenclient-oe/forks","keys_url":"https://api.github.com/repos/rianquinn/xenclient-oe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rianquinn/xenclient-oe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rianquinn/xenclient-oe/teams","hooks_url":"https://api.github.com/repos/rianquinn/xenclient-oe/hooks","issue_events_url":"https://api.github.com/repos/rianquinn/xenclient-oe/issues/events{/number}","events_url":"https://api.github.com/repos/rianquinn/xenclient-oe/events","assignees_url":"https://api.github.com/repos/rianquinn/xenclient-oe/assignees{/user}","branches_url":"https://api.github.com/repos/rianquinn/xenclient-oe/branches{/branch}","tags_url":"https://api.github.com/repos/rianquinn/xenclient-oe/tags","blobs_url":"https://api.github.com/repos/rianquinn/xenclient-oe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rianquinn/xenclient-oe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rianquinn/xenclient-oe/git/refs{/sha}","trees_url":"https://api.github.com/repos/rianquinn/xenclient-oe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rianquinn/xenclient-oe/statuses/{sha}","languages_url":"https://api.github.com/repos/rianquinn/xenclient-oe/languages","stargazers_url":"https://api.github.com/repos/rianquinn/xenclient-oe/stargazers","contributors_url":"https://api.github.com/repos/rianquinn/xenclient-oe/contributors","subscribers_url":"https://api.github.com/repos/rianquinn/xenclient-oe/subscribers","subscription_url":"https://api.github.com/repos/rianquinn/xenclient-oe/subscription","commits_url":"https://api.github.com/repos/rianquinn/xenclient-oe/commits{/sha}","git_commits_url":"https://api.github.com/repos/rianquinn/xenclient-oe/git/commits{/sha}","comments_url":"https://api.github.com/repos/rianquinn/xenclient-oe/comments{/number}","issue_comment_url":"https://api.github.com/repos/rianquinn/xenclient-oe/issues/comments{/number}","contents_url":"https://api.github.com/repos/rianquinn/xenclient-oe/contents/{+path}","compare_url":"https://api.github.com/repos/rianquinn/xenclient-oe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rianquinn/xenclient-oe/merges","archive_url":"https://api.github.com/repos/rianquinn/xenclient-oe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rianquinn/xenclient-oe/downloads","issues_url":"https://api.github.com/repos/rianquinn/xenclient-oe/issues{/number}","pulls_url":"https://api.github.com/repos/rianquinn/xenclient-oe/pulls{/number}","milestones_url":"https://api.github.com/repos/rianquinn/xenclient-oe/milestones{/number}","notifications_url":"https://api.github.com/repos/rianquinn/xenclient-oe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rianquinn/xenclient-oe/labels{/name}","releases_url":"https://api.github.com/repos/rianquinn/xenclient-oe/releases{/id}","created_at":"2015-04-08T20:37:57Z","updated_at":"2015-04-08T20:38:00Z","pushed_at":"2015-04-08T20:54:39Z","git_url":"git://github.com/rianquinn/xenclient-oe.git","ssh_url":"git@github.com:rianquinn/xenclient-oe.git","clone_url":"https://github.com/rianquinn/xenclient-oe.git","svn_url":"https://github.com/rianquinn/xenclient-oe","homepage":null,"size":9210,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OpenXT:master","ref":"master","sha":"3c58c17c85b044c84265fdd2ccf49e20c9d561ae","user":{"login":"OpenXT","id":7283187,"avatar_url":"https://avatars.githubusercontent.com/u/7283187?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenXT","html_url":"https://github.com/OpenXT","followers_url":"https://api.github.com/users/OpenXT/followers","following_url":"https://api.github.com/users/OpenXT/following{/other_user}","gists_url":"https://api.github.com/users/OpenXT/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenXT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenXT/subscriptions","organizations_url":"https://api.github.com/users/OpenXT/orgs","repos_url":"https://api.github.com/users/OpenXT/repos","events_url":"https://api.github.com/users/OpenXT/events{/privacy}","received_events_url":"https://api.github.com/users/OpenXT/received_events","type":"Organization","site_admin":false},"repo":{"id":20779371,"name":"xenclient-oe","full_name":"OpenXT/xenclient-oe","owner":{"login":"OpenXT","id":7283187,"avatar_url":"https://avatars.githubusercontent.com/u/7283187?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenXT","html_url":"https://github.com/OpenXT","followers_url":"https://api.github.com/users/OpenXT/followers","following_url":"https://api.github.com/users/OpenXT/following{/other_user}","gists_url":"https://api.github.com/users/OpenXT/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenXT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenXT/subscriptions","organizations_url":"https://api.github.com/users/OpenXT/orgs","repos_url":"https://api.github.com/users/OpenXT/repos","events_url":"https://api.github.com/users/OpenXT/events{/privacy}","received_events_url":"https://api.github.com/users/OpenXT/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenXT/xenclient-oe","description":"","fork":false,"url":"https://api.github.com/repos/OpenXT/xenclient-oe","forks_url":"https://api.github.com/repos/OpenXT/xenclient-oe/forks","keys_url":"https://api.github.com/repos/OpenXT/xenclient-oe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenXT/xenclient-oe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenXT/xenclient-oe/teams","hooks_url":"https://api.github.com/repos/OpenXT/xenclient-oe/hooks","issue_events_url":"https://api.github.com/repos/OpenXT/xenclient-oe/issues/events{/number}","events_url":"https://api.github.com/repos/OpenXT/xenclient-oe/events","assignees_url":"https://api.github.com/repos/OpenXT/xenclient-oe/assignees{/user}","branches_url":"https://api.github.com/repos/OpenXT/xenclient-oe/branches{/branch}","tags_url":"https://api.github.com/repos/OpenXT/xenclient-oe/tags","blobs_url":"https://api.github.com/repos/OpenXT/xenclient-oe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenXT/xenclient-oe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenXT/xenclient-oe/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenXT/xenclient-oe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenXT/xenclient-oe/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenXT/xenclient-oe/languages","stargazers_url":"https://api.github.com/repos/OpenXT/xenclient-oe/stargazers","contributors_url":"https://api.github.com/repos/OpenXT/xenclient-oe/contributors","subscribers_url":"https://api.github.com/repos/OpenXT/xenclient-oe/subscribers","subscription_url":"https://api.github.com/repos/OpenXT/xenclient-oe/subscription","commits_url":"https://api.github.com/repos/OpenXT/xenclient-oe/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenXT/xenclient-oe/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenXT/xenclient-oe/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenXT/xenclient-oe/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenXT/xenclient-oe/contents/{+path}","compare_url":"https://api.github.com/repos/OpenXT/xenclient-oe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenXT/xenclient-oe/merges","archive_url":"https://api.github.com/repos/OpenXT/xenclient-oe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenXT/xenclient-oe/downloads","issues_url":"https://api.github.com/repos/OpenXT/xenclient-oe/issues{/number}","pulls_url":"https://api.github.com/repos/OpenXT/xenclient-oe/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenXT/xenclient-oe/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenXT/xenclient-oe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenXT/xenclient-oe/labels{/name}","releases_url":"https://api.github.com/repos/OpenXT/xenclient-oe/releases{/id}","created_at":"2014-06-12T19:00:56Z","updated_at":"2015-04-08T21:05:03Z","pushed_at":"2015-04-08T22:13:44Z","git_url":"git://github.com/OpenXT/xenclient-oe.git","ssh_url":"git@github.com:OpenXT/xenclient-oe.git","clone_url":"https://github.com/OpenXT/xenclient-oe.git","svn_url":"https://github.com/OpenXT/xenclient-oe","homepage":null,"size":9210,"stargazers_count":3,"watchers_count":3,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":7,"forks":15,"open_issues":7,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenXT/xenclient-oe/pulls/83"},"html":{"href":"https://github.com/OpenXT/xenclient-oe/pull/83"},"issue":{"href":"https://api.github.com/repos/OpenXT/xenclient-oe/issues/83"},"comments":{"href":"https://api.github.com/repos/OpenXT/xenclient-oe/issues/83/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenXT/xenclient-oe/pulls/83/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenXT/xenclient-oe/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenXT/xenclient-oe/pulls/83/commits"},"statuses":{"href":"https://api.github.com/repos/OpenXT/xenclient-oe/statuses/92be56706d6eb1481af194f923cfbfdc946063e1"}}}}