{"action":"created","comment":{"url":"https://api.github.com/repos/CanalTP/navitia/pulls/comments/40895758","id":40895758,"diff_hunk":"@@ -92,49 +74,43 @@ VJ::VJ(builder & b, const std::string &line_name, const std::string &validity_pa\n     } else {\n         route = it->second->route_list.front();\n     }\n-    if (jp_uri.empty()) {\n-        jp_uri = route->uri + \":0\";\n-    }\n-    auto jp = get_or_create_journey_pattern(b, jp_uri);\n \n-    route->journey_pattern_list.push_back(jp);\n-    jp->route = route;\n+    if (is_frequency) {\n+        auto f_vj = std::make_unique<nt::FrequencyVehicleJourney>();\n+        f_vj->idx = route->frequency_vehicle_journey_list.size() - 1;","path":"source/ed/build_helper.cpp","position":46,"original_position":46,"commit_id":"26d6d03d6353705005a5da3924b1fc900744ab9b","original_commit_id":"26d6d03d6353705005a5da3924b1fc900744ab9b","user":{"login":"antoine-de","id":3987698,"avatar_url":"https://avatars.githubusercontent.com/u/3987698?v=3","gravatar_id":"","url":"https://api.github.com/users/antoine-de","html_url":"https://github.com/antoine-de","followers_url":"https://api.github.com/users/antoine-de/followers","following_url":"https://api.github.com/users/antoine-de/following{/other_user}","gists_url":"https://api.github.com/users/antoine-de/gists{/gist_id}","starred_url":"https://api.github.com/users/antoine-de/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antoine-de/subscriptions","organizations_url":"https://api.github.com/users/antoine-de/orgs","repos_url":"https://api.github.com/users/antoine-de/repos","events_url":"https://api.github.com/users/antoine-de/events{/privacy}","received_events_url":"https://api.github.com/users/antoine-de/received_events","type":"User","site_admin":false},"body":"ah k I didin't see this was moved.\r\n\r\nif this is reindexed later, I'd vote for the removal of this, as this seem quite buggy for the reader point of view","created_at":"2015-10-01T09:44:23Z","updated_at":"2015-10-01T09:44:23Z","html_url":"https://github.com/CanalTP/navitia/pull/1171#discussion_r40895758","pull_request_url":"https://api.github.com/repos/CanalTP/navitia/pulls/1171","_links":{"self":{"href":"https://api.github.com/repos/CanalTP/navitia/pulls/comments/40895758"},"html":{"href":"https://github.com/CanalTP/navitia/pull/1171#discussion_r40895758"},"pull_request":{"href":"https://api.github.com/repos/CanalTP/navitia/pulls/1171"}}},"pull_request":{"url":"https://api.github.com/repos/CanalTP/navitia/pulls/1171","id":45051127,"html_url":"https://github.com/CanalTP/navitia/pull/1171","diff_url":"https://github.com/CanalTP/navitia/pull/1171.diff","patch_url":"https://github.com/CanalTP/navitia/pull/1171.patch","issue_url":"https://api.github.com/repos/CanalTP/navitia/issues/1171","number":1171,"state":"open","locked":false,"title":"all: raptor manage its journey patterns","user":{"login":"TeXitoi","id":5787066,"avatar_url":"https://avatars.githubusercontent.com/u/5787066?v=3","gravatar_id":"","url":"https://api.github.com/users/TeXitoi","html_url":"https://github.com/TeXitoi","followers_url":"https://api.github.com/users/TeXitoi/followers","following_url":"https://api.github.com/users/TeXitoi/following{/other_user}","gists_url":"https://api.github.com/users/TeXitoi/gists{/gist_id}","starred_url":"https://api.github.com/users/TeXitoi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TeXitoi/subscriptions","organizations_url":"https://api.github.com/users/TeXitoi/orgs","repos_url":"https://api.github.com/users/TeXitoi/repos","events_url":"https://api.github.com/users/TeXitoi/events{/privacy}","received_events_url":"https://api.github.com/users/TeXitoi/received_events","type":"User","site_admin":false},"body":"A big refactor that'll help creating vj.\r\n\r\n\r\nBenchmark:\r\n\r\nOn stif (from customer)\r\n\r\nItem | new | old | diff | %diff\r\n------|-------|-----|------|--------\r\nmemory (virt/res, Mo) | 2055 / 1791 | 2036 / 1774 | +19 / +17 | +0.93% / +0.96%\r\njourney_patterns | 12261 | 12217 | +44 | +0.36%\r\nvehicle_journeys | 325423 | 325025 | +398 | +0.12%\r\nstop_times | 7361655 | 7357011 | +4644 | +0.06%\r\nbenchmark (algo/load, s) | 65.5+65.6+65.5 / 19.2+18.9+19.4 | 67.1+67.5+67.3 / 16.9+17.2+17.0 | -1.8 / +2.1 | -2.6% / +12.5%\r\nphysical_mode:Bus/stop_areas (median, ms) | 681 | 707 | -26 | -3.6%","created_at":"2015-09-15T13:48:13Z","updated_at":"2015-10-01T09:44:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"abad2a274e707de6c6762363b6b00237714c99fa","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/CanalTP/navitia/pulls/1171/commits","review_comments_url":"https://api.github.com/repos/CanalTP/navitia/pulls/1171/comments","review_comment_url":"https://api.github.com/repos/CanalTP/navitia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CanalTP/navitia/issues/1171/comments","statuses_url":"https://api.github.com/repos/CanalTP/navitia/statuses/26d6d03d6353705005a5da3924b1fc900744ab9b","head":{"label":"TeXitoi:jp_refactor","ref":"jp_refactor","sha":"26d6d03d6353705005a5da3924b1fc900744ab9b","user":{"login":"TeXitoi","id":5787066,"avatar_url":"https://avatars.githubusercontent.com/u/5787066?v=3","gravatar_id":"","url":"https://api.github.com/users/TeXitoi","html_url":"https://github.com/TeXitoi","followers_url":"https://api.github.com/users/TeXitoi/followers","following_url":"https://api.github.com/users/TeXitoi/following{/other_user}","gists_url":"https://api.github.com/users/TeXitoi/gists{/gist_id}","starred_url":"https://api.github.com/users/TeXitoi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TeXitoi/subscriptions","organizations_url":"https://api.github.com/users/TeXitoi/orgs","repos_url":"https://api.github.com/users/TeXitoi/repos","events_url":"https://api.github.com/users/TeXitoi/events{/privacy}","received_events_url":"https://api.github.com/users/TeXitoi/received_events","type":"User","site_admin":false},"repo":{"id":23435249,"name":"navitia","full_name":"TeXitoi/navitia","owner":{"login":"TeXitoi","id":5787066,"avatar_url":"https://avatars.githubusercontent.com/u/5787066?v=3","gravatar_id":"","url":"https://api.github.com/users/TeXitoi","html_url":"https://github.com/TeXitoi","followers_url":"https://api.github.com/users/TeXitoi/followers","following_url":"https://api.github.com/users/TeXitoi/following{/other_user}","gists_url":"https://api.github.com/users/TeXitoi/gists{/gist_id}","starred_url":"https://api.github.com/users/TeXitoi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TeXitoi/subscriptions","organizations_url":"https://api.github.com/users/TeXitoi/orgs","repos_url":"https://api.github.com/users/TeXitoi/repos","events_url":"https://api.github.com/users/TeXitoi/events{/privacy}","received_events_url":"https://api.github.com/users/TeXitoi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TeXitoi/navitia","description":"The REST API to build cool stuff with public transport","fork":true,"url":"https://api.github.com/repos/TeXitoi/navitia","forks_url":"https://api.github.com/repos/TeXitoi/navitia/forks","keys_url":"https://api.github.com/repos/TeXitoi/navitia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TeXitoi/navitia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TeXitoi/navitia/teams","hooks_url":"https://api.github.com/repos/TeXitoi/navitia/hooks","issue_events_url":"https://api.github.com/repos/TeXitoi/navitia/issues/events{/number}","events_url":"https://api.github.com/repos/TeXitoi/navitia/events","assignees_url":"https://api.github.com/repos/TeXitoi/navitia/assignees{/user}","branches_url":"https://api.github.com/repos/TeXitoi/navitia/branches{/branch}","tags_url":"https://api.github.com/repos/TeXitoi/navitia/tags","blobs_url":"https://api.github.com/repos/TeXitoi/navitia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TeXitoi/navitia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TeXitoi/navitia/git/refs{/sha}","trees_url":"https://api.github.com/repos/TeXitoi/navitia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TeXitoi/navitia/statuses/{sha}","languages_url":"https://api.github.com/repos/TeXitoi/navitia/languages","stargazers_url":"https://api.github.com/repos/TeXitoi/navitia/stargazers","contributors_url":"https://api.github.com/repos/TeXitoi/navitia/contributors","subscribers_url":"https://api.github.com/repos/TeXitoi/navitia/subscribers","subscription_url":"https://api.github.com/repos/TeXitoi/navitia/subscription","commits_url":"https://api.github.com/repos/TeXitoi/navitia/commits{/sha}","git_commits_url":"https://api.github.com/repos/TeXitoi/navitia/git/commits{/sha}","comments_url":"https://api.github.com/repos/TeXitoi/navitia/comments{/number}","issue_comment_url":"https://api.github.com/repos/TeXitoi/navitia/issues/comments{/number}","contents_url":"https://api.github.com/repos/TeXitoi/navitia/contents/{+path}","compare_url":"https://api.github.com/repos/TeXitoi/navitia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TeXitoi/navitia/merges","archive_url":"https://api.github.com/repos/TeXitoi/navitia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TeXitoi/navitia/downloads","issues_url":"https://api.github.com/repos/TeXitoi/navitia/issues{/number}","pulls_url":"https://api.github.com/repos/TeXitoi/navitia/pulls{/number}","milestones_url":"https://api.github.com/repos/TeXitoi/navitia/milestones{/number}","notifications_url":"https://api.github.com/repos/TeXitoi/navitia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TeXitoi/navitia/labels{/name}","releases_url":"https://api.github.com/repos/TeXitoi/navitia/releases{/id}","created_at":"2014-08-28T16:35:05Z","updated_at":"2014-09-09T14:32:07Z","pushed_at":"2015-09-30T15:46:42Z","git_url":"git://github.com/TeXitoi/navitia.git","ssh_url":"git@github.com:TeXitoi/navitia.git","clone_url":"https://github.com/TeXitoi/navitia.git","svn_url":"https://github.com/TeXitoi/navitia","homepage":"http://www.navitia.io","size":26310,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"CanalTP:dev","ref":"dev","sha":"5b9309ee5b9e50f8a5f33a20e14bd3c58c661c7f","user":{"login":"CanalTP","id":2743985,"avatar_url":"https://avatars.githubusercontent.com/u/2743985?v=3","gravatar_id":"","url":"https://api.github.com/users/CanalTP","html_url":"https://github.com/CanalTP","followers_url":"https://api.github.com/users/CanalTP/followers","following_url":"https://api.github.com/users/CanalTP/following{/other_user}","gists_url":"https://api.github.com/users/CanalTP/gists{/gist_id}","starred_url":"https://api.github.com/users/CanalTP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CanalTP/subscriptions","organizations_url":"https://api.github.com/users/CanalTP/orgs","repos_url":"https://api.github.com/users/CanalTP/repos","events_url":"https://api.github.com/users/CanalTP/events{/privacy}","received_events_url":"https://api.github.com/users/CanalTP/received_events","type":"Organization","site_admin":false},"repo":{"id":10797333,"name":"navitia","full_name":"CanalTP/navitia","owner":{"login":"CanalTP","id":2743985,"avatar_url":"https://avatars.githubusercontent.com/u/2743985?v=3","gravatar_id":"","url":"https://api.github.com/users/CanalTP","html_url":"https://github.com/CanalTP","followers_url":"https://api.github.com/users/CanalTP/followers","following_url":"https://api.github.com/users/CanalTP/following{/other_user}","gists_url":"https://api.github.com/users/CanalTP/gists{/gist_id}","starred_url":"https://api.github.com/users/CanalTP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CanalTP/subscriptions","organizations_url":"https://api.github.com/users/CanalTP/orgs","repos_url":"https://api.github.com/users/CanalTP/repos","events_url":"https://api.github.com/users/CanalTP/events{/privacy}","received_events_url":"https://api.github.com/users/CanalTP/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CanalTP/navitia","description":"The REST API to build cool stuff with public transport","fork":false,"url":"https://api.github.com/repos/CanalTP/navitia","forks_url":"https://api.github.com/repos/CanalTP/navitia/forks","keys_url":"https://api.github.com/repos/CanalTP/navitia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CanalTP/navitia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CanalTP/navitia/teams","hooks_url":"https://api.github.com/repos/CanalTP/navitia/hooks","issue_events_url":"https://api.github.com/repos/CanalTP/navitia/issues/events{/number}","events_url":"https://api.github.com/repos/CanalTP/navitia/events","assignees_url":"https://api.github.com/repos/CanalTP/navitia/assignees{/user}","branches_url":"https://api.github.com/repos/CanalTP/navitia/branches{/branch}","tags_url":"https://api.github.com/repos/CanalTP/navitia/tags","blobs_url":"https://api.github.com/repos/CanalTP/navitia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CanalTP/navitia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CanalTP/navitia/git/refs{/sha}","trees_url":"https://api.github.com/repos/CanalTP/navitia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CanalTP/navitia/statuses/{sha}","languages_url":"https://api.github.com/repos/CanalTP/navitia/languages","stargazers_url":"https://api.github.com/repos/CanalTP/navitia/stargazers","contributors_url":"https://api.github.com/repos/CanalTP/navitia/contributors","subscribers_url":"https://api.github.com/repos/CanalTP/navitia/subscribers","subscription_url":"https://api.github.com/repos/CanalTP/navitia/subscription","commits_url":"https://api.github.com/repos/CanalTP/navitia/commits{/sha}","git_commits_url":"https://api.github.com/repos/CanalTP/navitia/git/commits{/sha}","comments_url":"https://api.github.com/repos/CanalTP/navitia/comments{/number}","issue_comment_url":"https://api.github.com/repos/CanalTP/navitia/issues/comments{/number}","contents_url":"https://api.github.com/repos/CanalTP/navitia/contents/{+path}","compare_url":"https://api.github.com/repos/CanalTP/navitia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CanalTP/navitia/merges","archive_url":"https://api.github.com/repos/CanalTP/navitia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CanalTP/navitia/downloads","issues_url":"https://api.github.com/repos/CanalTP/navitia/issues{/number}","pulls_url":"https://api.github.com/repos/CanalTP/navitia/pulls{/number}","milestones_url":"https://api.github.com/repos/CanalTP/navitia/milestones{/number}","notifications_url":"https://api.github.com/repos/CanalTP/navitia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CanalTP/navitia/labels{/name}","releases_url":"https://api.github.com/repos/CanalTP/navitia/releases{/id}","created_at":"2013-06-19T15:34:30Z","updated_at":"2015-09-20T12:44:27Z","pushed_at":"2015-09-30T17:04:44Z","git_url":"git://github.com/CanalTP/navitia.git","ssh_url":"git@github.com:CanalTP/navitia.git","clone_url":"https://github.com/CanalTP/navitia.git","svn_url":"https://github.com/CanalTP/navitia","homepage":"http://www.navitia.io","size":35857,"stargazers_count":125,"watchers_count":125,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":40,"mirror_url":null,"open_issues_count":26,"forks":40,"open_issues":26,"watchers":125,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/CanalTP/navitia/pulls/1171"},"html":{"href":"https://github.com/CanalTP/navitia/pull/1171"},"issue":{"href":"https://api.github.com/repos/CanalTP/navitia/issues/1171"},"comments":{"href":"https://api.github.com/repos/CanalTP/navitia/issues/1171/comments"},"review_comments":{"href":"https://api.github.com/repos/CanalTP/navitia/pulls/1171/comments"},"review_comment":{"href":"https://api.github.com/repos/CanalTP/navitia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CanalTP/navitia/pulls/1171/commits"},"statuses":{"href":"https://api.github.com/repos/CanalTP/navitia/statuses/26d6d03d6353705005a5da3924b1fc900744ab9b"}}}}