{"action":"created","issue":{"url":"https://api.github.com/repos/wingrunr21/griddler-mandrill/issues/23","labels_url":"https://api.github.com/repos/wingrunr21/griddler-mandrill/issues/23/labels{/name}","comments_url":"https://api.github.com/repos/wingrunr21/griddler-mandrill/issues/23/comments","events_url":"https://api.github.com/repos/wingrunr21/griddler-mandrill/issues/23/events","html_url":"https://github.com/wingrunr21/griddler-mandrill/issues/23","id":104424612,"number":23,"title":"SPF validation","user":{"login":"ciihla","id":123601,"avatar_url":"https://avatars.githubusercontent.com/u/123601?v=3","gravatar_id":"","url":"https://api.github.com/users/ciihla","html_url":"https://github.com/ciihla","followers_url":"https://api.github.com/users/ciihla/followers","following_url":"https://api.github.com/users/ciihla/following{/other_user}","gists_url":"https://api.github.com/users/ciihla/gists{/gist_id}","starred_url":"https://api.github.com/users/ciihla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ciihla/subscriptions","organizations_url":"https://api.github.com/users/ciihla/orgs","repos_url":"https://api.github.com/users/ciihla/repos","events_url":"https://api.github.com/users/ciihla/events{/privacy}","received_events_url":"https://api.github.com/users/ciihla/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":14,"created_at":"2015-09-02T08:15:39Z","updated_at":"2015-09-02T16:01:10Z","closed_at":null,"body":"I just wanted to ask why you added the SPF validation to the adapter? I think it is mandrill's responsiility to filter SPF. And if Mandrill sends the email, then griddle would not have to validate it.\r\n\r\nMaybe Im wrong but at least it could have been optional or configurable, right? Can I do a MR with configurable this SPF validation?"},"comment":{"url":"https://api.github.com/repos/wingrunr21/griddler-mandrill/issues/comments/137144405","html_url":"https://github.com/wingrunr21/griddler-mandrill/issues/23#issuecomment-137144405","issue_url":"https://api.github.com/repos/wingrunr21/griddler-mandrill/issues/23","id":137144405,"user":{"login":"wingrunr21","id":46283,"avatar_url":"https://avatars.githubusercontent.com/u/46283?v=3","gravatar_id":"","url":"https://api.github.com/users/wingrunr21","html_url":"https://github.com/wingrunr21","followers_url":"https://api.github.com/users/wingrunr21/followers","following_url":"https://api.github.com/users/wingrunr21/following{/other_user}","gists_url":"https://api.github.com/users/wingrunr21/gists{/gist_id}","starred_url":"https://api.github.com/users/wingrunr21/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wingrunr21/subscriptions","organizations_url":"https://api.github.com/users/wingrunr21/orgs","repos_url":"https://api.github.com/users/wingrunr21/repos","events_url":"https://api.github.com/users/wingrunr21/events{/privacy}","received_events_url":"https://api.github.com/users/wingrunr21/received_events","type":"User","site_admin":false},"created_at":"2015-09-02T16:01:10Z","updated_at":"2015-09-02T16:01:10Z","body":"Depends. You can check the arity of `new` and conditionally pass things to the method. Griddler can also bump their version to reflect the API change and the adapters can depend on the lower version until they make their changes."}}