{"action":"closed","number":17,"pull_request":{"url":"https://api.github.com/repos/jdittrich/ep_autocomp/pulls/17","id":50638896,"html_url":"https://github.com/jdittrich/ep_autocomp/pull/17","diff_url":"https://github.com/jdittrich/ep_autocomp/pull/17.diff","patch_url":"https://github.com/jdittrich/ep_autocomp/pull/17.patch","issue_url":"https://api.github.com/repos/jdittrich/ep_autocomp/issues/17","number":17,"state":"closed","locked":false,"title":"Remove tempDisabledHelper + bug fix + minor improvements","user":{"login":"lpagliari","id":836386,"avatar_url":"https://avatars.githubusercontent.com/u/836386?v=3","gravatar_id":"","url":"https://api.github.com/users/lpagliari","html_url":"https://github.com/lpagliari","followers_url":"https://api.github.com/users/lpagliari/followers","following_url":"https://api.github.com/users/lpagliari/following{/other_user}","gists_url":"https://api.github.com/users/lpagliari/gists{/gist_id}","starred_url":"https://api.github.com/users/lpagliari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lpagliari/subscriptions","organizations_url":"https://api.github.com/users/lpagliari/orgs","repos_url":"https://api.github.com/users/lpagliari/repos","events_url":"https://api.github.com/users/lpagliari/events{/privacy}","received_events_url":"https://api.github.com/users/lpagliari/received_events","type":"User","site_admin":false},"body":"By checking `context.evt.type === \"keydown\"`, we are able to avoid duplicate processing of key events, so `tempDisabledHelper` is not necessary anymore.\r\n\r\nI've also fixed an issue when user presses Ctrl+space on a machine where space is configured to scroll page down (was happening on my Mac, using Chrome) -- suggestions were shown, but page was scrolling down, which was a bad experience.\r\n\r\nFinally, I've made some minor organizations on the code","created_at":"2015-11-13T13:07:53Z","updated_at":"2015-11-14T09:17:46Z","closed_at":"2015-11-14T09:17:46Z","merged_at":null,"merge_commit_sha":"c0095902d694e0d1569ab7db82cab9afd65f281e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jdittrich/ep_autocomp/pulls/17/commits","review_comments_url":"https://api.github.com/repos/jdittrich/ep_autocomp/pulls/17/comments","review_comment_url":"https://api.github.com/repos/jdittrich/ep_autocomp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jdittrich/ep_autocomp/issues/17/comments","statuses_url":"https://api.github.com/repos/jdittrich/ep_autocomp/statuses/7f0be3a5ada3e542d569bfa32d8f03274965fb6b","head":{"label":"lpagliari:master","ref":"master","sha":"7f0be3a5ada3e542d569bfa32d8f03274965fb6b","user":{"login":"lpagliari","id":836386,"avatar_url":"https://avatars.githubusercontent.com/u/836386?v=3","gravatar_id":"","url":"https://api.github.com/users/lpagliari","html_url":"https://github.com/lpagliari","followers_url":"https://api.github.com/users/lpagliari/followers","following_url":"https://api.github.com/users/lpagliari/following{/other_user}","gists_url":"https://api.github.com/users/lpagliari/gists{/gist_id}","starred_url":"https://api.github.com/users/lpagliari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lpagliari/subscriptions","organizations_url":"https://api.github.com/users/lpagliari/orgs","repos_url":"https://api.github.com/users/lpagliari/repos","events_url":"https://api.github.com/users/lpagliari/events{/privacy}","received_events_url":"https://api.github.com/users/lpagliari/received_events","type":"User","site_admin":false},"repo":{"id":46120788,"name":"ep_autocomp","full_name":"lpagliari/ep_autocomp","owner":{"login":"lpagliari","id":836386,"avatar_url":"https://avatars.githubusercontent.com/u/836386?v=3","gravatar_id":"","url":"https://api.github.com/users/lpagliari","html_url":"https://github.com/lpagliari","followers_url":"https://api.github.com/users/lpagliari/followers","following_url":"https://api.github.com/users/lpagliari/following{/other_user}","gists_url":"https://api.github.com/users/lpagliari/gists{/gist_id}","starred_url":"https://api.github.com/users/lpagliari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lpagliari/subscriptions","organizations_url":"https://api.github.com/users/lpagliari/orgs","repos_url":"https://api.github.com/users/lpagliari/repos","events_url":"https://api.github.com/users/lpagliari/events{/privacy}","received_events_url":"https://api.github.com/users/lpagliari/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lpagliari/ep_autocomp","description":"autocompletion for etherpad","fork":true,"url":"https://api.github.com/repos/lpagliari/ep_autocomp","forks_url":"https://api.github.com/repos/lpagliari/ep_autocomp/forks","keys_url":"https://api.github.com/repos/lpagliari/ep_autocomp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lpagliari/ep_autocomp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lpagliari/ep_autocomp/teams","hooks_url":"https://api.github.com/repos/lpagliari/ep_autocomp/hooks","issue_events_url":"https://api.github.com/repos/lpagliari/ep_autocomp/issues/events{/number}","events_url":"https://api.github.com/repos/lpagliari/ep_autocomp/events","assignees_url":"https://api.github.com/repos/lpagliari/ep_autocomp/assignees{/user}","branches_url":"https://api.github.com/repos/lpagliari/ep_autocomp/branches{/branch}","tags_url":"https://api.github.com/repos/lpagliari/ep_autocomp/tags","blobs_url":"https://api.github.com/repos/lpagliari/ep_autocomp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lpagliari/ep_autocomp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lpagliari/ep_autocomp/git/refs{/sha}","trees_url":"https://api.github.com/repos/lpagliari/ep_autocomp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lpagliari/ep_autocomp/statuses/{sha}","languages_url":"https://api.github.com/repos/lpagliari/ep_autocomp/languages","stargazers_url":"https://api.github.com/repos/lpagliari/ep_autocomp/stargazers","contributors_url":"https://api.github.com/repos/lpagliari/ep_autocomp/contributors","subscribers_url":"https://api.github.com/repos/lpagliari/ep_autocomp/subscribers","subscription_url":"https://api.github.com/repos/lpagliari/ep_autocomp/subscription","commits_url":"https://api.github.com/repos/lpagliari/ep_autocomp/commits{/sha}","git_commits_url":"https://api.github.com/repos/lpagliari/ep_autocomp/git/commits{/sha}","comments_url":"https://api.github.com/repos/lpagliari/ep_autocomp/comments{/number}","issue_comment_url":"https://api.github.com/repos/lpagliari/ep_autocomp/issues/comments{/number}","contents_url":"https://api.github.com/repos/lpagliari/ep_autocomp/contents/{+path}","compare_url":"https://api.github.com/repos/lpagliari/ep_autocomp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lpagliari/ep_autocomp/merges","archive_url":"https://api.github.com/repos/lpagliari/ep_autocomp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lpagliari/ep_autocomp/downloads","issues_url":"https://api.github.com/repos/lpagliari/ep_autocomp/issues{/number}","pulls_url":"https://api.github.com/repos/lpagliari/ep_autocomp/pulls{/number}","milestones_url":"https://api.github.com/repos/lpagliari/ep_autocomp/milestones{/number}","notifications_url":"https://api.github.com/repos/lpagliari/ep_autocomp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lpagliari/ep_autocomp/labels{/name}","releases_url":"https://api.github.com/repos/lpagliari/ep_autocomp/releases{/id}","created_at":"2015-11-13T12:31:04Z","updated_at":"2015-11-13T12:31:06Z","pushed_at":"2015-11-13T13:04:27Z","git_url":"git://github.com/lpagliari/ep_autocomp.git","ssh_url":"git@github.com:lpagliari/ep_autocomp.git","clone_url":"https://github.com/lpagliari/ep_autocomp.git","svn_url":"https://github.com/lpagliari/ep_autocomp","homepage":null,"size":521,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jdittrich:master","ref":"master","sha":"46e811db63b9ff4370711cad81641ab604861e63","user":{"login":"jdittrich","id":3416487,"avatar_url":"https://avatars.githubusercontent.com/u/3416487?v=3","gravatar_id":"","url":"https://api.github.com/users/jdittrich","html_url":"https://github.com/jdittrich","followers_url":"https://api.github.com/users/jdittrich/followers","following_url":"https://api.github.com/users/jdittrich/following{/other_user}","gists_url":"https://api.github.com/users/jdittrich/gists{/gist_id}","starred_url":"https://api.github.com/users/jdittrich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdittrich/subscriptions","organizations_url":"https://api.github.com/users/jdittrich/orgs","repos_url":"https://api.github.com/users/jdittrich/repos","events_url":"https://api.github.com/users/jdittrich/events{/privacy}","received_events_url":"https://api.github.com/users/jdittrich/received_events","type":"User","site_admin":false},"repo":{"id":17381226,"name":"ep_autocomp","full_name":"jdittrich/ep_autocomp","owner":{"login":"jdittrich","id":3416487,"avatar_url":"https://avatars.githubusercontent.com/u/3416487?v=3","gravatar_id":"","url":"https://api.github.com/users/jdittrich","html_url":"https://github.com/jdittrich","followers_url":"https://api.github.com/users/jdittrich/followers","following_url":"https://api.github.com/users/jdittrich/following{/other_user}","gists_url":"https://api.github.com/users/jdittrich/gists{/gist_id}","starred_url":"https://api.github.com/users/jdittrich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdittrich/subscriptions","organizations_url":"https://api.github.com/users/jdittrich/orgs","repos_url":"https://api.github.com/users/jdittrich/repos","events_url":"https://api.github.com/users/jdittrich/events{/privacy}","received_events_url":"https://api.github.com/users/jdittrich/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jdittrich/ep_autocomp","description":"autocompletion for etherpad","fork":false,"url":"https://api.github.com/repos/jdittrich/ep_autocomp","forks_url":"https://api.github.com/repos/jdittrich/ep_autocomp/forks","keys_url":"https://api.github.com/repos/jdittrich/ep_autocomp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jdittrich/ep_autocomp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jdittrich/ep_autocomp/teams","hooks_url":"https://api.github.com/repos/jdittrich/ep_autocomp/hooks","issue_events_url":"https://api.github.com/repos/jdittrich/ep_autocomp/issues/events{/number}","events_url":"https://api.github.com/repos/jdittrich/ep_autocomp/events","assignees_url":"https://api.github.com/repos/jdittrich/ep_autocomp/assignees{/user}","branches_url":"https://api.github.com/repos/jdittrich/ep_autocomp/branches{/branch}","tags_url":"https://api.github.com/repos/jdittrich/ep_autocomp/tags","blobs_url":"https://api.github.com/repos/jdittrich/ep_autocomp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jdittrich/ep_autocomp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jdittrich/ep_autocomp/git/refs{/sha}","trees_url":"https://api.github.com/repos/jdittrich/ep_autocomp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jdittrich/ep_autocomp/statuses/{sha}","languages_url":"https://api.github.com/repos/jdittrich/ep_autocomp/languages","stargazers_url":"https://api.github.com/repos/jdittrich/ep_autocomp/stargazers","contributors_url":"https://api.github.com/repos/jdittrich/ep_autocomp/contributors","subscribers_url":"https://api.github.com/repos/jdittrich/ep_autocomp/subscribers","subscription_url":"https://api.github.com/repos/jdittrich/ep_autocomp/subscription","commits_url":"https://api.github.com/repos/jdittrich/ep_autocomp/commits{/sha}","git_commits_url":"https://api.github.com/repos/jdittrich/ep_autocomp/git/commits{/sha}","comments_url":"https://api.github.com/repos/jdittrich/ep_autocomp/comments{/number}","issue_comment_url":"https://api.github.com/repos/jdittrich/ep_autocomp/issues/comments{/number}","contents_url":"https://api.github.com/repos/jdittrich/ep_autocomp/contents/{+path}","compare_url":"https://api.github.com/repos/jdittrich/ep_autocomp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jdittrich/ep_autocomp/merges","archive_url":"https://api.github.com/repos/jdittrich/ep_autocomp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jdittrich/ep_autocomp/downloads","issues_url":"https://api.github.com/repos/jdittrich/ep_autocomp/issues{/number}","pulls_url":"https://api.github.com/repos/jdittrich/ep_autocomp/pulls{/number}","milestones_url":"https://api.github.com/repos/jdittrich/ep_autocomp/milestones{/number}","notifications_url":"https://api.github.com/repos/jdittrich/ep_autocomp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jdittrich/ep_autocomp/labels{/name}","releases_url":"https://api.github.com/repos/jdittrich/ep_autocomp/releases{/id}","created_at":"2014-03-03T21:43:28Z","updated_at":"2015-05-11T04:57:37Z","pushed_at":"2015-11-13T13:07:53Z","git_url":"git://github.com/jdittrich/ep_autocomp.git","ssh_url":"git@github.com:jdittrich/ep_autocomp.git","clone_url":"https://github.com/jdittrich/ep_autocomp.git","svn_url":"https://github.com/jdittrich/ep_autocomp","homepage":null,"size":521,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":1,"forks":3,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jdittrich/ep_autocomp/pulls/17"},"html":{"href":"https://github.com/jdittrich/ep_autocomp/pull/17"},"issue":{"href":"https://api.github.com/repos/jdittrich/ep_autocomp/issues/17"},"comments":{"href":"https://api.github.com/repos/jdittrich/ep_autocomp/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/jdittrich/ep_autocomp/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/jdittrich/ep_autocomp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jdittrich/ep_autocomp/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/jdittrich/ep_autocomp/statuses/7f0be3a5ada3e542d569bfa32d8f03274965fb6b"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":2,"review_comments":0,"commits":3,"additions":31,"deletions":36,"changed_files":2}}