{"action":"created","comment":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/comments/41330083","id":41330083,"diff_hunk":"@@ -974,9 +974,6 @@ void ScriptEngine::entityScriptContentAvailable(const EntityItemID& entityID, co\n     QScriptValue entityScriptObject = entityScriptConstructor.construct();\n     EntityScriptDetails newDetails = { scriptOrURL, entityScriptObject };\n     _entityScripts[entityID] = newDetails;\n-    if (isURL) {","path":"libraries/script-engine/src/ScriptEngine.cpp","position":4,"original_position":4,"commit_id":"713499d6d05a418bdc5378d591dbf61fdfc51bb9","original_commit_id":"713499d6d05a418bdc5378d591dbf61fdfc51bb9","user":{"login":"ZappoMan","id":2093195,"avatar_url":"https://avatars.githubusercontent.com/u/2093195?v=3","gravatar_id":"","url":"https://api.github.com/users/ZappoMan","html_url":"https://github.com/ZappoMan","followers_url":"https://api.github.com/users/ZappoMan/followers","following_url":"https://api.github.com/users/ZappoMan/following{/other_user}","gists_url":"https://api.github.com/users/ZappoMan/gists{/gist_id}","starred_url":"https://api.github.com/users/ZappoMan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZappoMan/subscriptions","organizations_url":"https://api.github.com/users/ZappoMan/orgs","repos_url":"https://api.github.com/users/ZappoMan/repos","events_url":"https://api.github.com/users/ZappoMan/events{/privacy}","received_events_url":"https://api.github.com/users/ZappoMan/received_events","type":"User","site_admin":false},"body":"I think this will cause other bugs... but it does highlight the problem you found.\r\n\r\nI think the correct fix is to add a `QStack<QString> _parentScriptStack` and at line 958 you should do something like `_parentScriptStack.push(getParentURL());` then the call to `setParentURL(scriptOrURL);`\r\n\r\nThen here you want to do something like...\r\n\r\n```\r\n if (isURL) {\r\n    QString lastParent = _parentScriptStack.pop();\r\n    setParentURL(lastParent);\r\n}\r\n```","created_at":"2015-10-06T22:17:24Z","updated_at":"2015-10-06T22:17:24Z","html_url":"https://github.com/highfidelity/hifi/pull/6005#discussion_r41330083","pull_request_url":"https://api.github.com/repos/highfidelity/hifi/pulls/6005","_links":{"self":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/comments/41330083"},"html":{"href":"https://github.com/highfidelity/hifi/pull/6005#discussion_r41330083"},"pull_request":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/6005"}}},"pull_request":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/6005","id":46964936,"html_url":"https://github.com/highfidelity/hifi/pull/6005","diff_url":"https://github.com/highfidelity/hifi/pull/6005.diff","patch_url":"https://github.com/highfidelity/hifi/pull/6005.patch","issue_url":"https://api.github.com/repos/highfidelity/hifi/issues/6005","number":6005,"state":"open","locked":false,"title":"Fix for bug where Script.resolvePath returned an incorrect URL in some cases","user":{"login":"ericrius1","id":908702,"avatar_url":"https://avatars.githubusercontent.com/u/908702?v=3","gravatar_id":"","url":"https://api.github.com/users/ericrius1","html_url":"https://github.com/ericrius1","followers_url":"https://api.github.com/users/ericrius1/followers","following_url":"https://api.github.com/users/ericrius1/following{/other_user}","gists_url":"https://api.github.com/users/ericrius1/gists{/gist_id}","starred_url":"https://api.github.com/users/ericrius1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericrius1/subscriptions","organizations_url":"https://api.github.com/users/ericrius1/orgs","repos_url":"https://api.github.com/users/ericrius1/repos","events_url":"https://api.github.com/users/ericrius1/events{/privacy}","received_events_url":"https://api.github.com/users/ericrius1/received_events","type":"User","site_admin":false},"body":"There was a bug when an entity script which was attached to an entity from a parent entity script and called Script.resolvePath, it would have the incorrect path returned. This is now fixed","created_at":"2015-10-06T22:12:07Z","updated_at":"2015-10-06T22:17:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8c28309e51d5b1c0560a0413a099d21ae8d0801e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/highfidelity/hifi/pulls/6005/commits","review_comments_url":"https://api.github.com/repos/highfidelity/hifi/pulls/6005/comments","review_comment_url":"https://api.github.com/repos/highfidelity/hifi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/highfidelity/hifi/issues/6005/comments","statuses_url":"https://api.github.com/repos/highfidelity/hifi/statuses/713499d6d05a418bdc5378d591dbf61fdfc51bb9","head":{"label":"ericrius1:entityPathFix","ref":"entityPathFix","sha":"713499d6d05a418bdc5378d591dbf61fdfc51bb9","user":{"login":"ericrius1","id":908702,"avatar_url":"https://avatars.githubusercontent.com/u/908702?v=3","gravatar_id":"","url":"https://api.github.com/users/ericrius1","html_url":"https://github.com/ericrius1","followers_url":"https://api.github.com/users/ericrius1/followers","following_url":"https://api.github.com/users/ericrius1/following{/other_user}","gists_url":"https://api.github.com/users/ericrius1/gists{/gist_id}","starred_url":"https://api.github.com/users/ericrius1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericrius1/subscriptions","organizations_url":"https://api.github.com/users/ericrius1/orgs","repos_url":"https://api.github.com/users/ericrius1/repos","events_url":"https://api.github.com/users/ericrius1/events{/privacy}","received_events_url":"https://api.github.com/users/ericrius1/received_events","type":"User","site_admin":false},"repo":{"id":33081860,"name":"hifi","full_name":"ericrius1/hifi","owner":{"login":"ericrius1","id":908702,"avatar_url":"https://avatars.githubusercontent.com/u/908702?v=3","gravatar_id":"","url":"https://api.github.com/users/ericrius1","html_url":"https://github.com/ericrius1","followers_url":"https://api.github.com/users/ericrius1/followers","following_url":"https://api.github.com/users/ericrius1/following{/other_user}","gists_url":"https://api.github.com/users/ericrius1/gists{/gist_id}","starred_url":"https://api.github.com/users/ericrius1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericrius1/subscriptions","organizations_url":"https://api.github.com/users/ericrius1/orgs","repos_url":"https://api.github.com/users/ericrius1/repos","events_url":"https://api.github.com/users/ericrius1/events{/privacy}","received_events_url":"https://api.github.com/users/ericrius1/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ericrius1/hifi","description":"Open, decentralized virtual worlds using sensors to control avatars and dynamically assigned devices as servers.  San Francisco based startup, we are hiring: http://highfidelity.com/jobs  Documentation at http://docs.highfidelity.com  Contribute by reporting bugs & doing jobs on http://worklist.net","fork":true,"url":"https://api.github.com/repos/ericrius1/hifi","forks_url":"https://api.github.com/repos/ericrius1/hifi/forks","keys_url":"https://api.github.com/repos/ericrius1/hifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ericrius1/hifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ericrius1/hifi/teams","hooks_url":"https://api.github.com/repos/ericrius1/hifi/hooks","issue_events_url":"https://api.github.com/repos/ericrius1/hifi/issues/events{/number}","events_url":"https://api.github.com/repos/ericrius1/hifi/events","assignees_url":"https://api.github.com/repos/ericrius1/hifi/assignees{/user}","branches_url":"https://api.github.com/repos/ericrius1/hifi/branches{/branch}","tags_url":"https://api.github.com/repos/ericrius1/hifi/tags","blobs_url":"https://api.github.com/repos/ericrius1/hifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ericrius1/hifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ericrius1/hifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/ericrius1/hifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ericrius1/hifi/statuses/{sha}","languages_url":"https://api.github.com/repos/ericrius1/hifi/languages","stargazers_url":"https://api.github.com/repos/ericrius1/hifi/stargazers","contributors_url":"https://api.github.com/repos/ericrius1/hifi/contributors","subscribers_url":"https://api.github.com/repos/ericrius1/hifi/subscribers","subscription_url":"https://api.github.com/repos/ericrius1/hifi/subscription","commits_url":"https://api.github.com/repos/ericrius1/hifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/ericrius1/hifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/ericrius1/hifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/ericrius1/hifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/ericrius1/hifi/contents/{+path}","compare_url":"https://api.github.com/repos/ericrius1/hifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ericrius1/hifi/merges","archive_url":"https://api.github.com/repos/ericrius1/hifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ericrius1/hifi/downloads","issues_url":"https://api.github.com/repos/ericrius1/hifi/issues{/number}","pulls_url":"https://api.github.com/repos/ericrius1/hifi/pulls{/number}","milestones_url":"https://api.github.com/repos/ericrius1/hifi/milestones{/number}","notifications_url":"https://api.github.com/repos/ericrius1/hifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ericrius1/hifi/labels{/name}","releases_url":"https://api.github.com/repos/ericrius1/hifi/releases{/id}","created_at":"2015-03-29T17:21:39Z","updated_at":"2015-05-04T23:40:14Z","pushed_at":"2015-10-06T21:38:53Z","git_url":"git://github.com/ericrius1/hifi.git","ssh_url":"git@github.com:ericrius1/hifi.git","clone_url":"https://github.com/ericrius1/hifi.git","svn_url":"https://github.com/ericrius1/hifi","homepage":"","size":179215,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"highfidelity:master","ref":"master","sha":"2c276bb13e61a228cc5253d21f2c72d828e81982","user":{"login":"highfidelity","id":1565370,"avatar_url":"https://avatars.githubusercontent.com/u/1565370?v=3","gravatar_id":"","url":"https://api.github.com/users/highfidelity","html_url":"https://github.com/highfidelity","followers_url":"https://api.github.com/users/highfidelity/followers","following_url":"https://api.github.com/users/highfidelity/following{/other_user}","gists_url":"https://api.github.com/users/highfidelity/gists{/gist_id}","starred_url":"https://api.github.com/users/highfidelity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highfidelity/subscriptions","organizations_url":"https://api.github.com/users/highfidelity/orgs","repos_url":"https://api.github.com/users/highfidelity/repos","events_url":"https://api.github.com/users/highfidelity/events{/privacy}","received_events_url":"https://api.github.com/users/highfidelity/received_events","type":"Organization","site_admin":false},"repo":{"id":5372872,"name":"hifi","full_name":"highfidelity/hifi","owner":{"login":"highfidelity","id":1565370,"avatar_url":"https://avatars.githubusercontent.com/u/1565370?v=3","gravatar_id":"","url":"https://api.github.com/users/highfidelity","html_url":"https://github.com/highfidelity","followers_url":"https://api.github.com/users/highfidelity/followers","following_url":"https://api.github.com/users/highfidelity/following{/other_user}","gists_url":"https://api.github.com/users/highfidelity/gists{/gist_id}","starred_url":"https://api.github.com/users/highfidelity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highfidelity/subscriptions","organizations_url":"https://api.github.com/users/highfidelity/orgs","repos_url":"https://api.github.com/users/highfidelity/repos","events_url":"https://api.github.com/users/highfidelity/events{/privacy}","received_events_url":"https://api.github.com/users/highfidelity/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/highfidelity/hifi","description":"Open source software for shared virtual worlds using HMDs and dynamically assigned devices as servers.  San Francisco based startup, we are hiring: http://highfidelity.com/jobs  Documentation at http://docs.highfidelity.com  Contribute by reporting bugs & doing jobs on http://worklist.net","fork":false,"url":"https://api.github.com/repos/highfidelity/hifi","forks_url":"https://api.github.com/repos/highfidelity/hifi/forks","keys_url":"https://api.github.com/repos/highfidelity/hifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/highfidelity/hifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/highfidelity/hifi/teams","hooks_url":"https://api.github.com/repos/highfidelity/hifi/hooks","issue_events_url":"https://api.github.com/repos/highfidelity/hifi/issues/events{/number}","events_url":"https://api.github.com/repos/highfidelity/hifi/events","assignees_url":"https://api.github.com/repos/highfidelity/hifi/assignees{/user}","branches_url":"https://api.github.com/repos/highfidelity/hifi/branches{/branch}","tags_url":"https://api.github.com/repos/highfidelity/hifi/tags","blobs_url":"https://api.github.com/repos/highfidelity/hifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/highfidelity/hifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/highfidelity/hifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/highfidelity/hifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/highfidelity/hifi/statuses/{sha}","languages_url":"https://api.github.com/repos/highfidelity/hifi/languages","stargazers_url":"https://api.github.com/repos/highfidelity/hifi/stargazers","contributors_url":"https://api.github.com/repos/highfidelity/hifi/contributors","subscribers_url":"https://api.github.com/repos/highfidelity/hifi/subscribers","subscription_url":"https://api.github.com/repos/highfidelity/hifi/subscription","commits_url":"https://api.github.com/repos/highfidelity/hifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/highfidelity/hifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/highfidelity/hifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/highfidelity/hifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/highfidelity/hifi/contents/{+path}","compare_url":"https://api.github.com/repos/highfidelity/hifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/highfidelity/hifi/merges","archive_url":"https://api.github.com/repos/highfidelity/hifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/highfidelity/hifi/downloads","issues_url":"https://api.github.com/repos/highfidelity/hifi/issues{/number}","pulls_url":"https://api.github.com/repos/highfidelity/hifi/pulls{/number}","milestones_url":"https://api.github.com/repos/highfidelity/hifi/milestones{/number}","notifications_url":"https://api.github.com/repos/highfidelity/hifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/highfidelity/hifi/labels{/name}","releases_url":"https://api.github.com/repos/highfidelity/hifi/releases{/id}","created_at":"2012-08-10T18:26:22Z","updated_at":"2015-10-01T15:27:15Z","pushed_at":"2015-10-06T22:12:07Z","git_url":"git://github.com/highfidelity/hifi.git","ssh_url":"git@github.com:highfidelity/hifi.git","clone_url":"https://github.com/highfidelity/hifi.git","svn_url":"https://github.com/highfidelity/hifi","homepage":"","size":240357,"stargazers_count":311,"watchers_count":311,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":178,"mirror_url":null,"open_issues_count":60,"forks":178,"open_issues":60,"watchers":311,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/6005"},"html":{"href":"https://github.com/highfidelity/hifi/pull/6005"},"issue":{"href":"https://api.github.com/repos/highfidelity/hifi/issues/6005"},"comments":{"href":"https://api.github.com/repos/highfidelity/hifi/issues/6005/comments"},"review_comments":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/6005/comments"},"review_comment":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/6005/commits"},"statuses":{"href":"https://api.github.com/repos/highfidelity/hifi/statuses/713499d6d05a418bdc5378d591dbf61fdfc51bb9"}}}}