{"action":"created","issue":{"url":"https://api.github.com/repos/apache/parquet-mr/issues/220","labels_url":"https://api.github.com/repos/apache/parquet-mr/issues/220/labels{/name}","comments_url":"https://api.github.com/repos/apache/parquet-mr/issues/220/comments","events_url":"https://api.github.com/repos/apache/parquet-mr/issues/220/events","html_url":"https://github.com/apache/parquet-mr/pull/220","id":89456474,"number":220,"title":"PARQUET-284: Clean up ParquetMetadataConverter","user":{"login":"isnotinvain","id":372969,"avatar_url":"https://avatars.githubusercontent.com/u/372969?v=3","gravatar_id":"","url":"https://api.github.com/users/isnotinvain","html_url":"https://github.com/isnotinvain","followers_url":"https://api.github.com/users/isnotinvain/followers","following_url":"https://api.github.com/users/isnotinvain/following{/other_user}","gists_url":"https://api.github.com/users/isnotinvain/gists{/gist_id}","starred_url":"https://api.github.com/users/isnotinvain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isnotinvain/subscriptions","organizations_url":"https://api.github.com/users/isnotinvain/orgs","repos_url":"https://api.github.com/users/isnotinvain/repos","events_url":"https://api.github.com/users/isnotinvain/events{/privacy}","received_events_url":"https://api.github.com/users/isnotinvain/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-06-19T03:33:25Z","updated_at":"2015-06-19T04:24:06Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/parquet-mr/pulls/220","html_url":"https://github.com/apache/parquet-mr/pull/220","diff_url":"https://github.com/apache/parquet-mr/pull/220.diff","patch_url":"https://github.com/apache/parquet-mr/pull/220.patch"},"body":"makes all method static, removes unused thread-unsafe cache, etc.\r\n\r\nTurns out the \"cache\" was only read from *after* rebuilding what needed to be cached... so no performance gain there (and no loss by getting rid of it)\r\n\r\nHowever, I don't know if this will fix the issue mentioned in PARQUET-284, I don't think concurrent access to a HashMap will cause deadlock, it would just cause undefined behavior in reads or maybe ConcurrentModificationException\r\n\r\nUPDATE: I'm wrong, it can cause an infinite loop so this should fix the issue https://gist.github.com/rednaxelafx/1081908"},"comment":{"url":"https://api.github.com/repos/apache/parquet-mr/issues/comments/113362562","html_url":"https://github.com/apache/parquet-mr/pull/220#issuecomment-113362562","issue_url":"https://api.github.com/repos/apache/parquet-mr/issues/220","id":113362562,"user":{"login":"isnotinvain","id":372969,"avatar_url":"https://avatars.githubusercontent.com/u/372969?v=3","gravatar_id":"","url":"https://api.github.com/users/isnotinvain","html_url":"https://github.com/isnotinvain","followers_url":"https://api.github.com/users/isnotinvain/followers","following_url":"https://api.github.com/users/isnotinvain/following{/other_user}","gists_url":"https://api.github.com/users/isnotinvain/gists{/gist_id}","starred_url":"https://api.github.com/users/isnotinvain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isnotinvain/subscriptions","organizations_url":"https://api.github.com/users/isnotinvain/orgs","repos_url":"https://api.github.com/users/isnotinvain/repos","events_url":"https://api.github.com/users/isnotinvain/events{/privacy}","received_events_url":"https://api.github.com/users/isnotinvain/received_events","type":"User","site_admin":false},"created_at":"2015-06-19T04:24:06Z","updated_at":"2015-06-19T04:24:06Z","body":"@tsdeng @rdblue @SinghAsDev This one is ready to go too"}}