{"action":"created","issue":{"url":"https://api.github.com/repos/edx/edx-platform/issues/7451","labels_url":"https://api.github.com/repos/edx/edx-platform/issues/7451/labels{/name}","comments_url":"https://api.github.com/repos/edx/edx-platform/issues/7451/comments","events_url":"https://api.github.com/repos/edx/edx-platform/issues/7451/events","html_url":"https://github.com/edx/edx-platform/pull/7451","id":63781807,"number":7451,"title":"Make e-mail activation optional","user":{"login":"pmitros","id":1427775,"avatar_url":"https://avatars.githubusercontent.com/u/1427775?v=3","gravatar_id":"","url":"https://api.github.com/users/pmitros","html_url":"https://github.com/pmitros","followers_url":"https://api.github.com/users/pmitros/followers","following_url":"https://api.github.com/users/pmitros/following{/other_user}","gists_url":"https://api.github.com/users/pmitros/gists{/gist_id}","starred_url":"https://api.github.com/users/pmitros/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmitros/subscriptions","organizations_url":"https://api.github.com/users/pmitros/orgs","repos_url":"https://api.github.com/users/pmitros/repos","events_url":"https://api.github.com/users/pmitros/events{/privacy}","received_events_url":"https://api.github.com/users/pmitros/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/edx/edx-platform/labels/awaiting%20prioritization","name":"awaiting prioritization","color":"fad8c7"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2015-03-23T17:23:12Z","updated_at":"2015-04-01T16:37:57Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/7451","html_url":"https://github.com/edx/edx-platform/pull/7451","diff_url":"https://github.com/edx/edx-platform/pull/7451.diff","patch_url":"https://github.com/edx/edx-platform/pull/7451.patch"},"body":"This is a pull request to make e-mail activation optional. This is a feature which has been discussed at edX a fair bit. There was a request for this from a partner working with off-line Open edX installs (where students simply do not have genuine e-mail addresses), and I made a quick change which allows this. \r\n\r\nThis was tested on old-master on my machine, and tests passed. I rebased to latest master. I have not run tests yet (either manual or automatic), but I wanted to start the Jenkins build while I do that. I'll tag folks on this as soon as tests pass. "},"comment":{"url":"https://api.github.com/repos/edx/edx-platform/issues/comments/88548552","html_url":"https://github.com/edx/edx-platform/pull/7451#issuecomment-88548552","issue_url":"https://api.github.com/repos/edx/edx-platform/issues/7451","id":88548552,"user":{"login":"stephensanchez","id":235752,"avatar_url":"https://avatars.githubusercontent.com/u/235752?v=3","gravatar_id":"","url":"https://api.github.com/users/stephensanchez","html_url":"https://github.com/stephensanchez","followers_url":"https://api.github.com/users/stephensanchez/followers","following_url":"https://api.github.com/users/stephensanchez/following{/other_user}","gists_url":"https://api.github.com/users/stephensanchez/gists{/gist_id}","starred_url":"https://api.github.com/users/stephensanchez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephensanchez/subscriptions","organizations_url":"https://api.github.com/users/stephensanchez/orgs","repos_url":"https://api.github.com/users/stephensanchez/repos","events_url":"https://api.github.com/users/stephensanchez/events{/privacy}","received_events_url":"https://api.github.com/users/stephensanchez/received_events","type":"User","site_admin":false},"created_at":"2015-04-01T16:37:57Z","updated_at":"2015-04-01T16:37:57Z","body":"This implementation looks good, but I'm curious about existing inactive users, if this feature is turned on for an existing platform. Right now, if you are inactive, and try to log in, the system will send you another activation email. \r\n\r\n* Feature is *not* enabled\r\n* Student creates account\r\n* Feature *is* enabled\r\n* Student spends 4 hours in courses, logs out without activating\r\n* Student comes back a week later, account is inactive.\r\n\r\nMay be worth checking the feature flag there, and automatically activating students"}}