{"action":"created","comment":{"url":"https://api.github.com/repos/hhff/ember-infinity/pulls/comments/39782443","id":39782443,"diff_hunk":"@@ -160,117 +174,150 @@ export default Ember.Mixin.create({\n     delete options.perPage;\n     delete options.modelPath;\n \n-    this.set('_perPage', perPage);\n-    this.set('_modelPath', modelPath);\n-    this.set('_extraParams', options);\n-\n-    var requestPayloadBase = {};\n-    requestPayloadBase[this.get('perPageParam')] = perPage;\n-    requestPayloadBase[this.get('pageParam')] = startingPage;\n+    this.setProperties({\n+      currentPage: startingPage,\n+      _perPage: perPage,\n+      _modelPath: modelPath,\n+      _extraParams: options\n+    });\n \n     if (typeof boundParams === 'object') {\n       this.set('_boundParams', boundParams);\n-      options = this._includeBoundParams(options, boundParams);\n     }\n \n-    var params = Ember.merge(requestPayloadBase, options);\n-    let promise = this.store[this._storeFindMethod](modelName, params);\n+    return this._loadNextPage();\n+  },\n+\n+  /**\n+   Trigger a load of the next page of results.\n+\n+   @method infinityLoad\n+   @return {Boolean} always false, to prevent bubbling\n+   */\n+  _infinityLoad() {\n+    if (this.get('_loadingMore')) {\n+     return false;\n+    }\n+\n+    if (!this.get('_canLoadMore')) {\n+      this._finishLoad();\n+      return false;\n+    }\n+\n+    this._loadNextPage();\n+\n+    return false;","path":"addon/mixins/route.js","position":110,"original_position":110,"commit_id":"268dfff72da7274c42d4ae68c03e56a87057d344","original_commit_id":"268dfff72da7274c42d4ae68c03e56a87057d344","user":{"login":"davidgoli","id":44666,"avatar_url":"https://avatars.githubusercontent.com/u/44666?v=3","gravatar_id":"","url":"https://api.github.com/users/davidgoli","html_url":"https://github.com/davidgoli","followers_url":"https://api.github.com/users/davidgoli/followers","following_url":"https://api.github.com/users/davidgoli/following{/other_user}","gists_url":"https://api.github.com/users/davidgoli/gists{/gist_id}","starred_url":"https://api.github.com/users/davidgoli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidgoli/subscriptions","organizations_url":"https://api.github.com/users/davidgoli/orgs","repos_url":"https://api.github.com/users/davidgoli/repos","events_url":"https://api.github.com/users/davidgoli/events{/privacy}","received_events_url":"https://api.github.com/users/davidgoli/received_events","type":"User","site_admin":false},"body":"So I don't think it's actually necessary to `return false;` from this method. The action itself does not return false, or return the value of this method, so it is probably unnecessary.","created_at":"2015-09-17T18:36:50Z","updated_at":"2015-09-17T18:36:50Z","html_url":"https://github.com/hhff/ember-infinity/pull/88#discussion_r39782443","pull_request_url":"https://api.github.com/repos/hhff/ember-infinity/pulls/88","_links":{"self":{"href":"https://api.github.com/repos/hhff/ember-infinity/pulls/comments/39782443"},"html":{"href":"https://github.com/hhff/ember-infinity/pull/88#discussion_r39782443"},"pull_request":{"href":"https://api.github.com/repos/hhff/ember-infinity/pulls/88"}}},"pull_request":{"url":"https://api.github.com/repos/hhff/ember-infinity/pulls/88","id":44884107,"html_url":"https://github.com/hhff/ember-infinity/pull/88","diff_url":"https://github.com/hhff/ember-infinity/pull/88.diff","patch_url":"https://github.com/hhff/ember-infinity/pull/88.patch","issue_url":"https://api.github.com/repos/hhff/ember-infinity/issues/88","number":88,"state":"open","locked":false,"title":"Reduce duplication in route","user":{"login":"davidgoli","id":44666,"avatar_url":"https://avatars.githubusercontent.com/u/44666?v=3","gravatar_id":"","url":"https://api.github.com/users/davidgoli","html_url":"https://github.com/davidgoli","followers_url":"https://api.github.com/users/davidgoli/followers","following_url":"https://api.github.com/users/davidgoli/following{/other_user}","gists_url":"https://api.github.com/users/davidgoli/gists{/gist_id}","starred_url":"https://api.github.com/users/davidgoli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidgoli/subscriptions","organizations_url":"https://api.github.com/users/davidgoli/orgs","repos_url":"https://api.github.com/users/davidgoli/repos","events_url":"https://api.github.com/users/davidgoli/events{/privacy}","received_events_url":"https://api.github.com/users/davidgoli/received_events","type":"User","site_admin":false},"body":"WIP: DNM\r\n\r\nThis branch is motivated in anticipation of some upcoming bugfixes. The state of the route is difficult to reason about due to numerous duplications and minor inconsistencies between the initial load and page 2+ loads. This branch attempts to bring them into line with each other. No tests have been changed, because no behavior has been changed.","created_at":"2015-09-14T00:05:01Z","updated_at":"2015-09-17T18:36:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3cd9ef9d57250235f2c96291246a80f00441c28c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hhff/ember-infinity/pulls/88/commits","review_comments_url":"https://api.github.com/repos/hhff/ember-infinity/pulls/88/comments","review_comment_url":"https://api.github.com/repos/hhff/ember-infinity/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hhff/ember-infinity/issues/88/comments","statuses_url":"https://api.github.com/repos/hhff/ember-infinity/statuses/268dfff72da7274c42d4ae68c03e56a87057d344","head":{"label":"sirenfoxlike:reduce-duplication","ref":"reduce-duplication","sha":"268dfff72da7274c42d4ae68c03e56a87057d344","user":{"login":"sirenfoxlike","id":8755008,"avatar_url":"https://avatars.githubusercontent.com/u/8755008?v=3","gravatar_id":"","url":"https://api.github.com/users/sirenfoxlike","html_url":"https://github.com/sirenfoxlike","followers_url":"https://api.github.com/users/sirenfoxlike/followers","following_url":"https://api.github.com/users/sirenfoxlike/following{/other_user}","gists_url":"https://api.github.com/users/sirenfoxlike/gists{/gist_id}","starred_url":"https://api.github.com/users/sirenfoxlike/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sirenfoxlike/subscriptions","organizations_url":"https://api.github.com/users/sirenfoxlike/orgs","repos_url":"https://api.github.com/users/sirenfoxlike/repos","events_url":"https://api.github.com/users/sirenfoxlike/events{/privacy}","received_events_url":"https://api.github.com/users/sirenfoxlike/received_events","type":"Organization","site_admin":false},"repo":{"id":38009030,"name":"ember-infinity","full_name":"sirenfoxlike/ember-infinity","owner":{"login":"sirenfoxlike","id":8755008,"avatar_url":"https://avatars.githubusercontent.com/u/8755008?v=3","gravatar_id":"","url":"https://api.github.com/users/sirenfoxlike","html_url":"https://github.com/sirenfoxlike","followers_url":"https://api.github.com/users/sirenfoxlike/followers","following_url":"https://api.github.com/users/sirenfoxlike/following{/other_user}","gists_url":"https://api.github.com/users/sirenfoxlike/gists{/gist_id}","starred_url":"https://api.github.com/users/sirenfoxlike/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sirenfoxlike/subscriptions","organizations_url":"https://api.github.com/users/sirenfoxlike/orgs","repos_url":"https://api.github.com/users/sirenfoxlike/repos","events_url":"https://api.github.com/users/sirenfoxlike/events{/privacy}","received_events_url":"https://api.github.com/users/sirenfoxlike/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sirenfoxlike/ember-infinity","description":"Simple, flexible Infinite Scroll for Ember CLI Apps.","fork":true,"url":"https://api.github.com/repos/sirenfoxlike/ember-infinity","forks_url":"https://api.github.com/repos/sirenfoxlike/ember-infinity/forks","keys_url":"https://api.github.com/repos/sirenfoxlike/ember-infinity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sirenfoxlike/ember-infinity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sirenfoxlike/ember-infinity/teams","hooks_url":"https://api.github.com/repos/sirenfoxlike/ember-infinity/hooks","issue_events_url":"https://api.github.com/repos/sirenfoxlike/ember-infinity/issues/events{/number}","events_url":"https://api.github.com/repos/sirenfoxlike/ember-infinity/events","assignees_url":"https://api.github.com/repos/sirenfoxlike/ember-infinity/assignees{/user}","branches_url":"https://api.github.com/repos/sirenfoxlike/ember-infinity/branches{/branch}","tags_url":"https://api.github.com/repos/sirenfoxlike/ember-infinity/tags","blobs_url":"https://api.github.com/repos/sirenfoxlike/ember-infinity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sirenfoxlike/ember-infinity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sirenfoxlike/ember-infinity/git/refs{/sha}","trees_url":"https://api.github.com/repos/sirenfoxlike/ember-infinity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sirenfoxlike/ember-infinity/statuses/{sha}","languages_url":"https://api.github.com/repos/sirenfoxlike/ember-infinity/languages","stargazers_url":"https://api.github.com/repos/sirenfoxlike/ember-infinity/stargazers","contributors_url":"https://api.github.com/repos/sirenfoxlike/ember-infinity/contributors","subscribers_url":"https://api.github.com/repos/sirenfoxlike/ember-infinity/subscribers","subscription_url":"https://api.github.com/repos/sirenfoxlike/ember-infinity/subscription","commits_url":"https://api.github.com/repos/sirenfoxlike/ember-infinity/commits{/sha}","git_commits_url":"https://api.github.com/repos/sirenfoxlike/ember-infinity/git/commits{/sha}","comments_url":"https://api.github.com/repos/sirenfoxlike/ember-infinity/comments{/number}","issue_comment_url":"https://api.github.com/repos/sirenfoxlike/ember-infinity/issues/comments{/number}","contents_url":"https://api.github.com/repos/sirenfoxlike/ember-infinity/contents/{+path}","compare_url":"https://api.github.com/repos/sirenfoxlike/ember-infinity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sirenfoxlike/ember-infinity/merges","archive_url":"https://api.github.com/repos/sirenfoxlike/ember-infinity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sirenfoxlike/ember-infinity/downloads","issues_url":"https://api.github.com/repos/sirenfoxlike/ember-infinity/issues{/number}","pulls_url":"https://api.github.com/repos/sirenfoxlike/ember-infinity/pulls{/number}","milestones_url":"https://api.github.com/repos/sirenfoxlike/ember-infinity/milestones{/number}","notifications_url":"https://api.github.com/repos/sirenfoxlike/ember-infinity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sirenfoxlike/ember-infinity/labels{/name}","releases_url":"https://api.github.com/repos/sirenfoxlike/ember-infinity/releases{/id}","created_at":"2015-06-24T20:24:13Z","updated_at":"2015-06-24T20:24:14Z","pushed_at":"2015-09-17T18:33:58Z","git_url":"git://github.com/sirenfoxlike/ember-infinity.git","ssh_url":"git@github.com:sirenfoxlike/ember-infinity.git","clone_url":"https://github.com/sirenfoxlike/ember-infinity.git","svn_url":"https://github.com/sirenfoxlike/ember-infinity","homepage":"http://hhff.github.io/ember-infinity/","size":20243,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hhff:master","ref":"master","sha":"d1163805fea3ea9a7c033b5a131af8beb984bc85","user":{"login":"hhff","id":2865404,"avatar_url":"https://avatars.githubusercontent.com/u/2865404?v=3","gravatar_id":"","url":"https://api.github.com/users/hhff","html_url":"https://github.com/hhff","followers_url":"https://api.github.com/users/hhff/followers","following_url":"https://api.github.com/users/hhff/following{/other_user}","gists_url":"https://api.github.com/users/hhff/gists{/gist_id}","starred_url":"https://api.github.com/users/hhff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hhff/subscriptions","organizations_url":"https://api.github.com/users/hhff/orgs","repos_url":"https://api.github.com/users/hhff/repos","events_url":"https://api.github.com/users/hhff/events{/privacy}","received_events_url":"https://api.github.com/users/hhff/received_events","type":"User","site_admin":false},"repo":{"id":32656538,"name":"ember-infinity","full_name":"hhff/ember-infinity","owner":{"login":"hhff","id":2865404,"avatar_url":"https://avatars.githubusercontent.com/u/2865404?v=3","gravatar_id":"","url":"https://api.github.com/users/hhff","html_url":"https://github.com/hhff","followers_url":"https://api.github.com/users/hhff/followers","following_url":"https://api.github.com/users/hhff/following{/other_user}","gists_url":"https://api.github.com/users/hhff/gists{/gist_id}","starred_url":"https://api.github.com/users/hhff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hhff/subscriptions","organizations_url":"https://api.github.com/users/hhff/orgs","repos_url":"https://api.github.com/users/hhff/repos","events_url":"https://api.github.com/users/hhff/events{/privacy}","received_events_url":"https://api.github.com/users/hhff/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hhff/ember-infinity","description":"Simple, flexible Infinite Scroll for Ember CLI Apps.","fork":false,"url":"https://api.github.com/repos/hhff/ember-infinity","forks_url":"https://api.github.com/repos/hhff/ember-infinity/forks","keys_url":"https://api.github.com/repos/hhff/ember-infinity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hhff/ember-infinity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hhff/ember-infinity/teams","hooks_url":"https://api.github.com/repos/hhff/ember-infinity/hooks","issue_events_url":"https://api.github.com/repos/hhff/ember-infinity/issues/events{/number}","events_url":"https://api.github.com/repos/hhff/ember-infinity/events","assignees_url":"https://api.github.com/repos/hhff/ember-infinity/assignees{/user}","branches_url":"https://api.github.com/repos/hhff/ember-infinity/branches{/branch}","tags_url":"https://api.github.com/repos/hhff/ember-infinity/tags","blobs_url":"https://api.github.com/repos/hhff/ember-infinity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hhff/ember-infinity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hhff/ember-infinity/git/refs{/sha}","trees_url":"https://api.github.com/repos/hhff/ember-infinity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hhff/ember-infinity/statuses/{sha}","languages_url":"https://api.github.com/repos/hhff/ember-infinity/languages","stargazers_url":"https://api.github.com/repos/hhff/ember-infinity/stargazers","contributors_url":"https://api.github.com/repos/hhff/ember-infinity/contributors","subscribers_url":"https://api.github.com/repos/hhff/ember-infinity/subscribers","subscription_url":"https://api.github.com/repos/hhff/ember-infinity/subscription","commits_url":"https://api.github.com/repos/hhff/ember-infinity/commits{/sha}","git_commits_url":"https://api.github.com/repos/hhff/ember-infinity/git/commits{/sha}","comments_url":"https://api.github.com/repos/hhff/ember-infinity/comments{/number}","issue_comment_url":"https://api.github.com/repos/hhff/ember-infinity/issues/comments{/number}","contents_url":"https://api.github.com/repos/hhff/ember-infinity/contents/{+path}","compare_url":"https://api.github.com/repos/hhff/ember-infinity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hhff/ember-infinity/merges","archive_url":"https://api.github.com/repos/hhff/ember-infinity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hhff/ember-infinity/downloads","issues_url":"https://api.github.com/repos/hhff/ember-infinity/issues{/number}","pulls_url":"https://api.github.com/repos/hhff/ember-infinity/pulls{/number}","milestones_url":"https://api.github.com/repos/hhff/ember-infinity/milestones{/number}","notifications_url":"https://api.github.com/repos/hhff/ember-infinity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hhff/ember-infinity/labels{/name}","releases_url":"https://api.github.com/repos/hhff/ember-infinity/releases{/id}","created_at":"2015-03-22T01:00:39Z","updated_at":"2015-09-15T20:29:56Z","pushed_at":"2015-09-17T18:33:59Z","git_url":"git://github.com/hhff/ember-infinity.git","ssh_url":"git@github.com:hhff/ember-infinity.git","clone_url":"https://github.com/hhff/ember-infinity.git","svn_url":"https://github.com/hhff/ember-infinity","homepage":"http://hhff.github.io/ember-infinity/","size":20744,"stargazers_count":110,"watchers_count":110,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":42,"mirror_url":null,"open_issues_count":10,"forks":42,"open_issues":10,"watchers":110,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hhff/ember-infinity/pulls/88"},"html":{"href":"https://github.com/hhff/ember-infinity/pull/88"},"issue":{"href":"https://api.github.com/repos/hhff/ember-infinity/issues/88"},"comments":{"href":"https://api.github.com/repos/hhff/ember-infinity/issues/88/comments"},"review_comments":{"href":"https://api.github.com/repos/hhff/ember-infinity/pulls/88/comments"},"review_comment":{"href":"https://api.github.com/repos/hhff/ember-infinity/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hhff/ember-infinity/pulls/88/commits"},"statuses":{"href":"https://api.github.com/repos/hhff/ember-infinity/statuses/268dfff72da7274c42d4ae68c03e56a87057d344"}}}}