{"action":"created","comment":{"url":"https://api.github.com/repos/metabrainz/critiquebrainz/pulls/comments/48458251","id":48458251,"diff_hunk":"@@ -51,3 +51,11 @@\n     </script>\n   {% endif %}\n {% endmacro %}\n+\n+{% macro review_credit(review) %}\n+{{ _(\n+  'Event review by %(user)s' if review.entity_type == 'event' else 'Music review by %(user)s' if review.entity_type == 'release_group' else 'Review by %(user)s',\n+  user = '<img class=\"avatar\" src=\"%s&s=16\" /> '|safe % review.user.avatar + '<a href=\"%s\">%s</a>'|safe % (url_for('user.reviews', user_id=review.user.id), review.user.display_name),\n+  entitytype = _('Event')\n+) }}","path":"critiquebrainz/frontend/templates/macros.html","position":10,"original_position":10,"commit_id":"024db0b1a741e79f4b7f9acebfcaf962d7de51c0","original_commit_id":"024db0b1a741e79f4b7f9acebfcaf962d7de51c0","user":{"login":"gentlecat","id":460525,"avatar_url":"https://avatars.githubusercontent.com/u/460525?v=3","gravatar_id":"","url":"https://api.github.com/users/gentlecat","html_url":"https://github.com/gentlecat","followers_url":"https://api.github.com/users/gentlecat/followers","following_url":"https://api.github.com/users/gentlecat/following{/other_user}","gists_url":"https://api.github.com/users/gentlecat/gists{/gist_id}","starred_url":"https://api.github.com/users/gentlecat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gentlecat/subscriptions","organizations_url":"https://api.github.com/users/gentlecat/orgs","repos_url":"https://api.github.com/users/gentlecat/repos","events_url":"https://api.github.com/users/gentlecat/events{/privacy}","received_events_url":"https://api.github.com/users/gentlecat/received_events","type":"User","site_admin":false},"body":"Also, can you update this macro a bit so it doesn't take so much space horizontally? It's hard to read and understand. I'd just replace shortcut conditionals with full versions.","created_at":"2015-12-27T21:03:46Z","updated_at":"2015-12-27T21:03:46Z","html_url":"https://github.com/metabrainz/critiquebrainz/pull/26#discussion_r48458251","pull_request_url":"https://api.github.com/repos/metabrainz/critiquebrainz/pulls/26","_links":{"self":{"href":"https://api.github.com/repos/metabrainz/critiquebrainz/pulls/comments/48458251"},"html":{"href":"https://github.com/metabrainz/critiquebrainz/pull/26#discussion_r48458251"},"pull_request":{"href":"https://api.github.com/repos/metabrainz/critiquebrainz/pulls/26"}}},"pull_request":{"url":"https://api.github.com/repos/metabrainz/critiquebrainz/pulls/26","id":54560935,"html_url":"https://github.com/metabrainz/critiquebrainz/pull/26","diff_url":"https://github.com/metabrainz/critiquebrainz/pull/26.diff","patch_url":"https://github.com/metabrainz/critiquebrainz/pull/26.patch","issue_url":"https://api.github.com/repos/metabrainz/critiquebrainz/issues/26","number":26,"state":"open","locked":false,"title":"Indicate type of entity of review where mixed","user":{"login":"YatharthROCK","id":1520684,"avatar_url":"https://avatars.githubusercontent.com/u/1520684?v=3","gravatar_id":"","url":"https://api.github.com/users/YatharthROCK","html_url":"https://github.com/YatharthROCK","followers_url":"https://api.github.com/users/YatharthROCK/followers","following_url":"https://api.github.com/users/YatharthROCK/following{/other_user}","gists_url":"https://api.github.com/users/YatharthROCK/gists{/gist_id}","starred_url":"https://api.github.com/users/YatharthROCK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YatharthROCK/subscriptions","organizations_url":"https://api.github.com/users/YatharthROCK/orgs","repos_url":"https://api.github.com/users/YatharthROCK/repos","events_url":"https://api.github.com/users/YatharthROCK/events{/privacy}","received_events_url":"https://api.github.com/users/YatharthROCK/received_events","type":"User","site_admin":false},"body":"This PR resolves [CB-184](http://tickets.musicbrainz.org/browse/CB-184). It builds upon #25 and so should only be merged after/if #25 is merged. The first commit's message reads:\r\n\r\n> A macro was defined and used in the three places reviews of mixed-type entities are displayed.\r\n> \r\n> It is up to the translators to translate 'release_group' in English as 'release group' (and similarly for other languages).\r\n\r\n","created_at":"2015-12-24T17:25:58Z","updated_at":"2015-12-27T21:03:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2f39ebd5d12eaf7b8e5e9fc3ca749528e78fceb8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/metabrainz/critiquebrainz/pulls/26/commits","review_comments_url":"https://api.github.com/repos/metabrainz/critiquebrainz/pulls/26/comments","review_comment_url":"https://api.github.com/repos/metabrainz/critiquebrainz/pulls/comments{/number}","comments_url":"https://api.github.com/repos/metabrainz/critiquebrainz/issues/26/comments","statuses_url":"https://api.github.com/repos/metabrainz/critiquebrainz/statuses/024db0b1a741e79f4b7f9acebfcaf962d7de51c0","head":{"label":"YatharthROCK:eventtypelabel","ref":"eventtypelabel","sha":"024db0b1a741e79f4b7f9acebfcaf962d7de51c0","user":{"login":"YatharthROCK","id":1520684,"avatar_url":"https://avatars.githubusercontent.com/u/1520684?v=3","gravatar_id":"","url":"https://api.github.com/users/YatharthROCK","html_url":"https://github.com/YatharthROCK","followers_url":"https://api.github.com/users/YatharthROCK/followers","following_url":"https://api.github.com/users/YatharthROCK/following{/other_user}","gists_url":"https://api.github.com/users/YatharthROCK/gists{/gist_id}","starred_url":"https://api.github.com/users/YatharthROCK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YatharthROCK/subscriptions","organizations_url":"https://api.github.com/users/YatharthROCK/orgs","repos_url":"https://api.github.com/users/YatharthROCK/repos","events_url":"https://api.github.com/users/YatharthROCK/events{/privacy}","received_events_url":"https://api.github.com/users/YatharthROCK/received_events","type":"User","site_admin":false},"repo":{"id":48425714,"name":"critiquebrainz","full_name":"YatharthROCK/critiquebrainz","owner":{"login":"YatharthROCK","id":1520684,"avatar_url":"https://avatars.githubusercontent.com/u/1520684?v=3","gravatar_id":"","url":"https://api.github.com/users/YatharthROCK","html_url":"https://github.com/YatharthROCK","followers_url":"https://api.github.com/users/YatharthROCK/followers","following_url":"https://api.github.com/users/YatharthROCK/following{/other_user}","gists_url":"https://api.github.com/users/YatharthROCK/gists{/gist_id}","starred_url":"https://api.github.com/users/YatharthROCK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YatharthROCK/subscriptions","organizations_url":"https://api.github.com/users/YatharthROCK/orgs","repos_url":"https://api.github.com/users/YatharthROCK/repos","events_url":"https://api.github.com/users/YatharthROCK/events{/privacy}","received_events_url":"https://api.github.com/users/YatharthROCK/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/YatharthROCK/critiquebrainz","description":"Repository for Creative Commons licensed reviews","fork":true,"url":"https://api.github.com/repos/YatharthROCK/critiquebrainz","forks_url":"https://api.github.com/repos/YatharthROCK/critiquebrainz/forks","keys_url":"https://api.github.com/repos/YatharthROCK/critiquebrainz/keys{/key_id}","collaborators_url":"https://api.github.com/repos/YatharthROCK/critiquebrainz/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/YatharthROCK/critiquebrainz/teams","hooks_url":"https://api.github.com/repos/YatharthROCK/critiquebrainz/hooks","issue_events_url":"https://api.github.com/repos/YatharthROCK/critiquebrainz/issues/events{/number}","events_url":"https://api.github.com/repos/YatharthROCK/critiquebrainz/events","assignees_url":"https://api.github.com/repos/YatharthROCK/critiquebrainz/assignees{/user}","branches_url":"https://api.github.com/repos/YatharthROCK/critiquebrainz/branches{/branch}","tags_url":"https://api.github.com/repos/YatharthROCK/critiquebrainz/tags","blobs_url":"https://api.github.com/repos/YatharthROCK/critiquebrainz/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/YatharthROCK/critiquebrainz/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/YatharthROCK/critiquebrainz/git/refs{/sha}","trees_url":"https://api.github.com/repos/YatharthROCK/critiquebrainz/git/trees{/sha}","statuses_url":"https://api.github.com/repos/YatharthROCK/critiquebrainz/statuses/{sha}","languages_url":"https://api.github.com/repos/YatharthROCK/critiquebrainz/languages","stargazers_url":"https://api.github.com/repos/YatharthROCK/critiquebrainz/stargazers","contributors_url":"https://api.github.com/repos/YatharthROCK/critiquebrainz/contributors","subscribers_url":"https://api.github.com/repos/YatharthROCK/critiquebrainz/subscribers","subscription_url":"https://api.github.com/repos/YatharthROCK/critiquebrainz/subscription","commits_url":"https://api.github.com/repos/YatharthROCK/critiquebrainz/commits{/sha}","git_commits_url":"https://api.github.com/repos/YatharthROCK/critiquebrainz/git/commits{/sha}","comments_url":"https://api.github.com/repos/YatharthROCK/critiquebrainz/comments{/number}","issue_comment_url":"https://api.github.com/repos/YatharthROCK/critiquebrainz/issues/comments{/number}","contents_url":"https://api.github.com/repos/YatharthROCK/critiquebrainz/contents/{+path}","compare_url":"https://api.github.com/repos/YatharthROCK/critiquebrainz/compare/{base}...{head}","merges_url":"https://api.github.com/repos/YatharthROCK/critiquebrainz/merges","archive_url":"https://api.github.com/repos/YatharthROCK/critiquebrainz/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/YatharthROCK/critiquebrainz/downloads","issues_url":"https://api.github.com/repos/YatharthROCK/critiquebrainz/issues{/number}","pulls_url":"https://api.github.com/repos/YatharthROCK/critiquebrainz/pulls{/number}","milestones_url":"https://api.github.com/repos/YatharthROCK/critiquebrainz/milestones{/number}","notifications_url":"https://api.github.com/repos/YatharthROCK/critiquebrainz/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/YatharthROCK/critiquebrainz/labels{/name}","releases_url":"https://api.github.com/repos/YatharthROCK/critiquebrainz/releases{/id}","created_at":"2015-12-22T10:26:57Z","updated_at":"2015-12-22T10:26:59Z","pushed_at":"2015-12-27T19:54:29Z","git_url":"git://github.com/YatharthROCK/critiquebrainz.git","ssh_url":"git@github.com:YatharthROCK/critiquebrainz.git","clone_url":"https://github.com/YatharthROCK/critiquebrainz.git","svn_url":"https://github.com/YatharthROCK/critiquebrainz","homepage":"https://critiquebrainz.org/","size":3201,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"metabrainz:master","ref":"master","sha":"d71a3941c26d54999f217590d980c67fa2c2972e","user":{"login":"metabrainz","id":293421,"avatar_url":"https://avatars.githubusercontent.com/u/293421?v=3","gravatar_id":"","url":"https://api.github.com/users/metabrainz","html_url":"https://github.com/metabrainz","followers_url":"https://api.github.com/users/metabrainz/followers","following_url":"https://api.github.com/users/metabrainz/following{/other_user}","gists_url":"https://api.github.com/users/metabrainz/gists{/gist_id}","starred_url":"https://api.github.com/users/metabrainz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metabrainz/subscriptions","organizations_url":"https://api.github.com/users/metabrainz/orgs","repos_url":"https://api.github.com/users/metabrainz/repos","events_url":"https://api.github.com/users/metabrainz/events{/privacy}","received_events_url":"https://api.github.com/users/metabrainz/received_events","type":"Organization","site_admin":false},"repo":{"id":16650099,"name":"critiquebrainz","full_name":"metabrainz/critiquebrainz","owner":{"login":"metabrainz","id":293421,"avatar_url":"https://avatars.githubusercontent.com/u/293421?v=3","gravatar_id":"","url":"https://api.github.com/users/metabrainz","html_url":"https://github.com/metabrainz","followers_url":"https://api.github.com/users/metabrainz/followers","following_url":"https://api.github.com/users/metabrainz/following{/other_user}","gists_url":"https://api.github.com/users/metabrainz/gists{/gist_id}","starred_url":"https://api.github.com/users/metabrainz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metabrainz/subscriptions","organizations_url":"https://api.github.com/users/metabrainz/orgs","repos_url":"https://api.github.com/users/metabrainz/repos","events_url":"https://api.github.com/users/metabrainz/events{/privacy}","received_events_url":"https://api.github.com/users/metabrainz/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/metabrainz/critiquebrainz","description":"Repository for Creative Commons licensed reviews","fork":false,"url":"https://api.github.com/repos/metabrainz/critiquebrainz","forks_url":"https://api.github.com/repos/metabrainz/critiquebrainz/forks","keys_url":"https://api.github.com/repos/metabrainz/critiquebrainz/keys{/key_id}","collaborators_url":"https://api.github.com/repos/metabrainz/critiquebrainz/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/metabrainz/critiquebrainz/teams","hooks_url":"https://api.github.com/repos/metabrainz/critiquebrainz/hooks","issue_events_url":"https://api.github.com/repos/metabrainz/critiquebrainz/issues/events{/number}","events_url":"https://api.github.com/repos/metabrainz/critiquebrainz/events","assignees_url":"https://api.github.com/repos/metabrainz/critiquebrainz/assignees{/user}","branches_url":"https://api.github.com/repos/metabrainz/critiquebrainz/branches{/branch}","tags_url":"https://api.github.com/repos/metabrainz/critiquebrainz/tags","blobs_url":"https://api.github.com/repos/metabrainz/critiquebrainz/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/metabrainz/critiquebrainz/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/metabrainz/critiquebrainz/git/refs{/sha}","trees_url":"https://api.github.com/repos/metabrainz/critiquebrainz/git/trees{/sha}","statuses_url":"https://api.github.com/repos/metabrainz/critiquebrainz/statuses/{sha}","languages_url":"https://api.github.com/repos/metabrainz/critiquebrainz/languages","stargazers_url":"https://api.github.com/repos/metabrainz/critiquebrainz/stargazers","contributors_url":"https://api.github.com/repos/metabrainz/critiquebrainz/contributors","subscribers_url":"https://api.github.com/repos/metabrainz/critiquebrainz/subscribers","subscription_url":"https://api.github.com/repos/metabrainz/critiquebrainz/subscription","commits_url":"https://api.github.com/repos/metabrainz/critiquebrainz/commits{/sha}","git_commits_url":"https://api.github.com/repos/metabrainz/critiquebrainz/git/commits{/sha}","comments_url":"https://api.github.com/repos/metabrainz/critiquebrainz/comments{/number}","issue_comment_url":"https://api.github.com/repos/metabrainz/critiquebrainz/issues/comments{/number}","contents_url":"https://api.github.com/repos/metabrainz/critiquebrainz/contents/{+path}","compare_url":"https://api.github.com/repos/metabrainz/critiquebrainz/compare/{base}...{head}","merges_url":"https://api.github.com/repos/metabrainz/critiquebrainz/merges","archive_url":"https://api.github.com/repos/metabrainz/critiquebrainz/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/metabrainz/critiquebrainz/downloads","issues_url":"https://api.github.com/repos/metabrainz/critiquebrainz/issues{/number}","pulls_url":"https://api.github.com/repos/metabrainz/critiquebrainz/pulls{/number}","milestones_url":"https://api.github.com/repos/metabrainz/critiquebrainz/milestones{/number}","notifications_url":"https://api.github.com/repos/metabrainz/critiquebrainz/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/metabrainz/critiquebrainz/labels{/name}","releases_url":"https://api.github.com/repos/metabrainz/critiquebrainz/releases{/id}","created_at":"2014-02-08T18:41:37Z","updated_at":"2015-10-28T21:22:27Z","pushed_at":"2015-12-27T18:03:14Z","git_url":"git://github.com/metabrainz/critiquebrainz.git","ssh_url":"git@github.com:metabrainz/critiquebrainz.git","clone_url":"https://github.com/metabrainz/critiquebrainz.git","svn_url":"https://github.com/metabrainz/critiquebrainz","homepage":"https://critiquebrainz.org/","size":3320,"stargazers_count":10,"watchers_count":10,"language":"CSS","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":3,"forks":15,"open_issues":3,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/metabrainz/critiquebrainz/pulls/26"},"html":{"href":"https://github.com/metabrainz/critiquebrainz/pull/26"},"issue":{"href":"https://api.github.com/repos/metabrainz/critiquebrainz/issues/26"},"comments":{"href":"https://api.github.com/repos/metabrainz/critiquebrainz/issues/26/comments"},"review_comments":{"href":"https://api.github.com/repos/metabrainz/critiquebrainz/pulls/26/comments"},"review_comment":{"href":"https://api.github.com/repos/metabrainz/critiquebrainz/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/metabrainz/critiquebrainz/pulls/26/commits"},"statuses":{"href":"https://api.github.com/repos/metabrainz/critiquebrainz/statuses/024db0b1a741e79f4b7f9acebfcaf962d7de51c0"}}}}