{"action":"created","issue":{"url":"https://api.github.com/repos/ritz078/embed.js/issues/47","labels_url":"https://api.github.com/repos/ritz078/embed.js/issues/47/labels{/name}","comments_url":"https://api.github.com/repos/ritz078/embed.js/issues/47/comments","events_url":"https://api.github.com/repos/ritz078/embed.js/issues/47/events","html_url":"https://github.com/ritz078/embed.js/issues/47","id":115026140,"number":47,"title":"Improvement","user":{"login":"jflefebvre06","id":2685607,"avatar_url":"https://avatars.githubusercontent.com/u/2685607?v=3","gravatar_id":"","url":"https://api.github.com/users/jflefebvre06","html_url":"https://github.com/jflefebvre06","followers_url":"https://api.github.com/users/jflefebvre06/followers","following_url":"https://api.github.com/users/jflefebvre06/following{/other_user}","gists_url":"https://api.github.com/users/jflefebvre06/gists{/gist_id}","starred_url":"https://api.github.com/users/jflefebvre06/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jflefebvre06/subscriptions","organizations_url":"https://api.github.com/users/jflefebvre06/orgs","repos_url":"https://api.github.com/users/jflefebvre06/repos","events_url":"https://api.github.com/users/jflefebvre06/events{/privacy}","received_events_url":"https://api.github.com/users/jflefebvre06/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ritz078/embed.js/labels/enhancement","name":"enhancement","color":"84b6eb"},{"url":"https://api.github.com/repos/ritz078/embed.js/labels/v3.0.0","name":"v3.0.0","color":"0052cc"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-11-04T10:53:11Z","updated_at":"2015-11-04T11:31:59Z","closed_at":null,"body":"Hi Ritesh,\r\n\r\nI would like to suggest you the modifications below :\r\njquery.embed.css\r\n1) Add\r\n```css\r\n .emoticon {\r\n    background : transparent url(../resources/images/emojis.png) 0 0 no-repeat;\r\n}\r\n```\r\n\r\nbefore @media all and (-webkit-min-device-pixel-ratio : 1),  .....\r\nfor browsers not support media queries\r\n\r\n\r\njquery.embed.js :\r\n\r\n2) Replace :\r\n```javascript\r\nicons.forEach(function (icon) {\r\n                for (var i = 0; i < a.length; i++) {\r\n                    if (a[i] === icon.text) {\r\n                        a[i] = '<span class=\"icon-emoticon\" title=\"' + icon.text + '\">' + '&#x' + icon.code + '</span>';\r\n                    }\r\n                }\r\n            });\r\n```\r\nby\r\n```javascript\r\njQuery.each(icons, function(index, icon) {\r\n                for (var i = 0; i < a.length; i++) {\r\nif (a[i] === icon.text) {\r\n    a[i] = '<span class=\"icon-emoticon\" title=\"' + icon.text + '\">' + '&#x' + icon.code + ';</span>';\r\n}\r\n                }\r\n            });\r\n```\r\n2 reasons : for browser not support forEach and the missing ';' after icon.code\r\n\r\n\r\n3) Replace :\r\n```javascript\r\nvar lat = d.results[0].geometry.location.lat;\r\nvar long = d.results[0].geometry.location.lng;\r\n\r\nif (opts.mapOptions.mode === 'streetview') {\r\n    template = '<iframe width=\"600\" height=\"450\" frameborder=\"0\" style=\"border:0\" src=\"https://www.google.com/maps/embed/v1/streetview?key=' + opts.gdevAuthKey + '&location=' + lat + ',' + long + '&heading=210&pitch=10&fov=35\"></iframe>';\r\n}\r\n\r\nelse {\r\n    template = '<iframe width=\"600\" height=\"450\" frameborder=\"0\" style=\"border:0\" src=\"https://www.google.com/maps/embed/v1/view?key=' + opts.gdevAuthKey + '&center=' + lat + ',' + long + '&zoom=18&maptype=satellite\"></iframe>';\r\n}\r\n```\r\nby\r\n```javascript\r\nvar latitude = d.results[0].geometry.location.lat;\r\nvar longitude = d.results[0].geometry.location.lng;\r\n\r\nif (opts.mapOptions.mode === 'streetview') {\r\n    template = '<iframe width=\"600\" height=\"450\" frameborder=\"0\" style=\"border:0\" src=\"https://www.google.com/maps/embed/v1/streetview?key=' + opts.gdevAuthKey + '&location=' + latitude + ',' + longitude + '&heading=210&pitch=10&fov=35\"></iframe>';\r\n} else {\r\n    template = '<iframe width=\"600\" height=\"450\" frameborder=\"0\" style=\"border:0\" src=\"https://www.google.com/maps/embed/v1/view?key=' + opts.gdevAuthKey + '&center=' + latitude + ',' + longitude + '&zoom=18&maptype=satellite\"></iframe>';\r\n}\r\n\r\n```\r\nlong is a reserved word\r\n\r\n\r\nJF\r\n"},"comment":{"url":"https://api.github.com/repos/ritz078/embed.js/issues/comments/153693757","html_url":"https://github.com/ritz078/embed.js/issues/47#issuecomment-153693757","issue_url":"https://api.github.com/repos/ritz078/embed.js/issues/47","id":153693757,"user":{"login":"jflefebvre06","id":2685607,"avatar_url":"https://avatars.githubusercontent.com/u/2685607?v=3","gravatar_id":"","url":"https://api.github.com/users/jflefebvre06","html_url":"https://github.com/jflefebvre06","followers_url":"https://api.github.com/users/jflefebvre06/followers","following_url":"https://api.github.com/users/jflefebvre06/following{/other_user}","gists_url":"https://api.github.com/users/jflefebvre06/gists{/gist_id}","starred_url":"https://api.github.com/users/jflefebvre06/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jflefebvre06/subscriptions","organizations_url":"https://api.github.com/users/jflefebvre06/orgs","repos_url":"https://api.github.com/users/jflefebvre06/repos","events_url":"https://api.github.com/users/jflefebvre06/events{/privacy}","received_events_url":"https://api.github.com/users/jflefebvre06/received_events","type":"User","site_admin":false},"created_at":"2015-11-04T11:31:59Z","updated_at":"2015-11-04T11:31:59Z","body":"Cool :) very good job"}}