{"action":"created","issue":{"url":"https://api.github.com/repos/Esri/angular-esri-map/issues/82","labels_url":"https://api.github.com/repos/Esri/angular-esri-map/issues/82/labels{/name}","comments_url":"https://api.github.com/repos/Esri/angular-esri-map/issues/82/comments","events_url":"https://api.github.com/repos/Esri/angular-esri-map/issues/82/events","html_url":"https://github.com/Esri/angular-esri-map/pull/82","id":105723825,"number":82,"title":"Integration testing","user":{"login":"jwasil","id":4933392,"avatar_url":"https://avatars.githubusercontent.com/u/4933392?v=3","gravatar_id":"","url":"https://api.github.com/users/jwasil","html_url":"https://github.com/jwasil","followers_url":"https://api.github.com/users/jwasil/followers","following_url":"https://api.github.com/users/jwasil/following{/other_user}","gists_url":"https://api.github.com/users/jwasil/gists{/gist_id}","starred_url":"https://api.github.com/users/jwasil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwasil/subscriptions","organizations_url":"https://api.github.com/users/jwasil/orgs","repos_url":"https://api.github.com/users/jwasil/repos","events_url":"https://api.github.com/users/jwasil/events{/privacy}","received_events_url":"https://api.github.com/users/jwasil/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"jwasil","id":4933392,"avatar_url":"https://avatars.githubusercontent.com/u/4933392?v=3","gravatar_id":"","url":"https://api.github.com/users/jwasil","html_url":"https://github.com/jwasil","followers_url":"https://api.github.com/users/jwasil/followers","following_url":"https://api.github.com/users/jwasil/following{/other_user}","gists_url":"https://api.github.com/users/jwasil/gists{/gist_id}","starred_url":"https://api.github.com/users/jwasil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwasil/subscriptions","organizations_url":"https://api.github.com/users/jwasil/orgs","repos_url":"https://api.github.com/users/jwasil/repos","events_url":"https://api.github.com/users/jwasil/events{/privacy}","received_events_url":"https://api.github.com/users/jwasil/received_events","type":"User","site_admin":false},"milestone":null,"comments":2,"created_at":"2015-09-10T03:11:53Z","updated_at":"2015-09-11T12:18:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Esri/angular-esri-map/pulls/82","html_url":"https://github.com/Esri/angular-esri-map/pull/82","diff_url":"https://github.com/Esri/angular-esri-map/pull/82.diff","patch_url":"https://github.com/Esri/angular-esri-map/pull/82.patch"},"body":"@tomwayson please review\r\n\r\n- adds protractor integration testing\r\n- adds the ability to do a new `gulp test`\r\n- attempts to establish a pattern for:\r\n  - waiting on async JSAPI map properties in the DOM\r\n  - placing some reusable utility functions among specs in the protractor conf.js (debatable)\r\n- so far, includes specs for set-basemap, simple-map, and web-map\r\n\r\nresolves #79 "},"comment":{"url":"https://api.github.com/repos/Esri/angular-esri-map/issues/comments/139531443","html_url":"https://github.com/Esri/angular-esri-map/pull/82#issuecomment-139531443","issue_url":"https://api.github.com/repos/Esri/angular-esri-map/issues/82","id":139531443,"user":{"login":"jwasil","id":4933392,"avatar_url":"https://avatars.githubusercontent.com/u/4933392?v=3","gravatar_id":"","url":"https://api.github.com/users/jwasil","html_url":"https://github.com/jwasil","followers_url":"https://api.github.com/users/jwasil/followers","following_url":"https://api.github.com/users/jwasil/following{/other_user}","gists_url":"https://api.github.com/users/jwasil/gists{/gist_id}","starred_url":"https://api.github.com/users/jwasil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwasil/subscriptions","organizations_url":"https://api.github.com/users/jwasil/orgs","repos_url":"https://api.github.com/users/jwasil/repos","events_url":"https://api.github.com/users/jwasil/events{/privacy}","received_events_url":"https://api.github.com/users/jwasil/received_events","type":"User","site_admin":false},"created_at":"2015-09-11T12:18:00Z","updated_at":"2015-09-11T12:18:00Z","body":"@tomwayson thank you for the thorough review and for making some solid enhancements!\r\n\r\nI really like the new **helper.js** for the shared spec functions, rather than hitching on to Protractor's global.\r\n\r\nAnd Jasmine 2's `beforeAll()` is ideal; the original `beforeEach()` page load was getting to be unnecessary and making me feel a tiny, underlying current of :rage1:.  This could also open up the doors for other kinds of matchers we could use (if need be).\r\n\r\nIf we want to revisit the helper functions in the future, maybe we could use Jasmine 2's `done()` to help us out (which I recall you pointed out to me in a separate convo). That's assuming there is a way to make it work for us when dealing with individual async element locators, rather than whole assertions.  Just a thought for later on."}}