{"action":"created","comment":{"url":"https://api.github.com/repos/biocore/qiita/pulls/comments/29628129","id":29628129,"diff_hunk":"@@ -141,14 +142,17 @@ def get(self, analysis_id):\n             jobres[jobject.datatype].append((jobject.command[0],\n                                              jobject.results))\n \n-        dropped = {}\n         dropped_samples = analysis.dropped_samples\n+        dropped = defaultdict(list)\n         if dropped_samples:\n-            for proc_data_id, samples in viewitems(dropped_samples):\n+            for proc_data_id, samples in viewitems(analysis.dropped_samples):","path":"qiita_pet/handlers/analysis_handlers.py","position":17,"original_position":17,"commit_id":"d57bd9768856de57a7147096da49ce7dbc38f152","original_commit_id":"d57bd9768856de57a7147096da49ce7dbc38f152","user":{"login":"adamrp","id":2574407,"avatar_url":"https://avatars.githubusercontent.com/u/2574407?v=3","gravatar_id":"","url":"https://api.github.com/users/adamrp","html_url":"https://github.com/adamrp","followers_url":"https://api.github.com/users/adamrp/followers","following_url":"https://api.github.com/users/adamrp/following{/other_user}","gists_url":"https://api.github.com/users/adamrp/gists{/gist_id}","starred_url":"https://api.github.com/users/adamrp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamrp/subscriptions","organizations_url":"https://api.github.com/users/adamrp/orgs","repos_url":"https://api.github.com/users/adamrp/repos","events_url":"https://api.github.com/users/adamrp/events{/privacy}","received_events_url":"https://api.github.com/users/adamrp/received_events","type":"User","site_admin":false},"body":"In fact, the `if` statement on line 147 is not needed here, since this `for` loop will not run if `dropped_samples` is empty","created_at":"2015-05-04T21:58:43Z","updated_at":"2015-05-04T21:58:43Z","html_url":"https://github.com/biocore/qiita/pull/1144#discussion_r29628129","pull_request_url":"https://api.github.com/repos/biocore/qiita/pulls/1144","_links":{"self":{"href":"https://api.github.com/repos/biocore/qiita/pulls/comments/29628129"},"html":{"href":"https://github.com/biocore/qiita/pull/1144#discussion_r29628129"},"pull_request":{"href":"https://api.github.com/repos/biocore/qiita/pulls/1144"}}},"pull_request":{"url":"https://api.github.com/repos/biocore/qiita/pulls/1144","id":34593312,"html_url":"https://github.com/biocore/qiita/pull/1144","diff_url":"https://github.com/biocore/qiita/pull/1144.diff","patch_url":"https://github.com/biocore/qiita/pull/1144.patch","issue_url":"https://api.github.com/repos/biocore/qiita/issues/1144","number":1144,"state":"open","locked":false,"title":"Fix 947","user":{"login":"antgonza","id":2014559,"avatar_url":"https://avatars.githubusercontent.com/u/2014559?v=3","gravatar_id":"","url":"https://api.github.com/users/antgonza","html_url":"https://github.com/antgonza","followers_url":"https://api.github.com/users/antgonza/followers","following_url":"https://api.github.com/users/antgonza/following{/other_user}","gists_url":"https://api.github.com/users/antgonza/gists{/gist_id}","starred_url":"https://api.github.com/users/antgonza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antgonza/subscriptions","organizations_url":"https://api.github.com/users/antgonza/orgs","repos_url":"https://api.github.com/users/antgonza/repos","events_url":"https://api.github.com/users/antgonza/events{/privacy}","received_events_url":"https://api.github.com/users/antgonza/received_events","type":"User","site_admin":false},"body":"This adds a nicer visualization of dropped samples in an analysis. This is the base to add https://github.com/biocore/qiita/issues/1091, which will be in another PR.","created_at":"2015-05-02T22:59:53Z","updated_at":"2015-05-04T21:58:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ab86e81f8f0a87fcf84e0266a960272c3d26d5dc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/biocore/qiita/pulls/1144/commits","review_comments_url":"https://api.github.com/repos/biocore/qiita/pulls/1144/comments","review_comment_url":"https://api.github.com/repos/biocore/qiita/pulls/comments{/number}","comments_url":"https://api.github.com/repos/biocore/qiita/issues/1144/comments","statuses_url":"https://api.github.com/repos/biocore/qiita/statuses/d57bd9768856de57a7147096da49ce7dbc38f152","head":{"label":"antgonza:fix-947","ref":"fix-947","sha":"d57bd9768856de57a7147096da49ce7dbc38f152","user":{"login":"antgonza","id":2014559,"avatar_url":"https://avatars.githubusercontent.com/u/2014559?v=3","gravatar_id":"","url":"https://api.github.com/users/antgonza","html_url":"https://github.com/antgonza","followers_url":"https://api.github.com/users/antgonza/followers","following_url":"https://api.github.com/users/antgonza/following{/other_user}","gists_url":"https://api.github.com/users/antgonza/gists{/gist_id}","starred_url":"https://api.github.com/users/antgonza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antgonza/subscriptions","organizations_url":"https://api.github.com/users/antgonza/orgs","repos_url":"https://api.github.com/users/antgonza/repos","events_url":"https://api.github.com/users/antgonza/events{/privacy}","received_events_url":"https://api.github.com/users/antgonza/received_events","type":"User","site_admin":false},"repo":{"id":16964638,"name":"qiita","full_name":"antgonza/qiita","owner":{"login":"antgonza","id":2014559,"avatar_url":"https://avatars.githubusercontent.com/u/2014559?v=3","gravatar_id":"","url":"https://api.github.com/users/antgonza","html_url":"https://github.com/antgonza","followers_url":"https://api.github.com/users/antgonza/followers","following_url":"https://api.github.com/users/antgonza/following{/other_user}","gists_url":"https://api.github.com/users/antgonza/gists{/gist_id}","starred_url":"https://api.github.com/users/antgonza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antgonza/subscriptions","organizations_url":"https://api.github.com/users/antgonza/orgs","repos_url":"https://api.github.com/users/antgonza/repos","events_url":"https://api.github.com/users/antgonza/events{/privacy}","received_events_url":"https://api.github.com/users/antgonza/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/antgonza/qiita","description":"Qiita - A QIIME databasing effort","fork":true,"url":"https://api.github.com/repos/antgonza/qiita","forks_url":"https://api.github.com/repos/antgonza/qiita/forks","keys_url":"https://api.github.com/repos/antgonza/qiita/keys{/key_id}","collaborators_url":"https://api.github.com/repos/antgonza/qiita/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/antgonza/qiita/teams","hooks_url":"https://api.github.com/repos/antgonza/qiita/hooks","issue_events_url":"https://api.github.com/repos/antgonza/qiita/issues/events{/number}","events_url":"https://api.github.com/repos/antgonza/qiita/events","assignees_url":"https://api.github.com/repos/antgonza/qiita/assignees{/user}","branches_url":"https://api.github.com/repos/antgonza/qiita/branches{/branch}","tags_url":"https://api.github.com/repos/antgonza/qiita/tags","blobs_url":"https://api.github.com/repos/antgonza/qiita/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/antgonza/qiita/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/antgonza/qiita/git/refs{/sha}","trees_url":"https://api.github.com/repos/antgonza/qiita/git/trees{/sha}","statuses_url":"https://api.github.com/repos/antgonza/qiita/statuses/{sha}","languages_url":"https://api.github.com/repos/antgonza/qiita/languages","stargazers_url":"https://api.github.com/repos/antgonza/qiita/stargazers","contributors_url":"https://api.github.com/repos/antgonza/qiita/contributors","subscribers_url":"https://api.github.com/repos/antgonza/qiita/subscribers","subscription_url":"https://api.github.com/repos/antgonza/qiita/subscription","commits_url":"https://api.github.com/repos/antgonza/qiita/commits{/sha}","git_commits_url":"https://api.github.com/repos/antgonza/qiita/git/commits{/sha}","comments_url":"https://api.github.com/repos/antgonza/qiita/comments{/number}","issue_comment_url":"https://api.github.com/repos/antgonza/qiita/issues/comments{/number}","contents_url":"https://api.github.com/repos/antgonza/qiita/contents/{+path}","compare_url":"https://api.github.com/repos/antgonza/qiita/compare/{base}...{head}","merges_url":"https://api.github.com/repos/antgonza/qiita/merges","archive_url":"https://api.github.com/repos/antgonza/qiita/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/antgonza/qiita/downloads","issues_url":"https://api.github.com/repos/antgonza/qiita/issues{/number}","pulls_url":"https://api.github.com/repos/antgonza/qiita/pulls{/number}","milestones_url":"https://api.github.com/repos/antgonza/qiita/milestones{/number}","notifications_url":"https://api.github.com/repos/antgonza/qiita/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/antgonza/qiita/labels{/name}","releases_url":"https://api.github.com/repos/antgonza/qiita/releases{/id}","created_at":"2014-02-18T21:38:48Z","updated_at":"2015-05-04T02:58:47Z","pushed_at":"2015-05-04T03:05:51Z","git_url":"git://github.com/antgonza/qiita.git","ssh_url":"git@github.com:antgonza/qiita.git","clone_url":"https://github.com/antgonza/qiita.git","svn_url":"https://github.com/antgonza/qiita","homepage":"","size":124113,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"biocore:master","ref":"master","sha":"01ac199d172409edc20c99da4b67b05d1f92e614","user":{"login":"biocore","id":6241857,"avatar_url":"https://avatars.githubusercontent.com/u/6241857?v=3","gravatar_id":"","url":"https://api.github.com/users/biocore","html_url":"https://github.com/biocore","followers_url":"https://api.github.com/users/biocore/followers","following_url":"https://api.github.com/users/biocore/following{/other_user}","gists_url":"https://api.github.com/users/biocore/gists{/gist_id}","starred_url":"https://api.github.com/users/biocore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/biocore/subscriptions","organizations_url":"https://api.github.com/users/biocore/orgs","repos_url":"https://api.github.com/users/biocore/repos","events_url":"https://api.github.com/users/biocore/events{/privacy}","received_events_url":"https://api.github.com/users/biocore/received_events","type":"Organization","site_admin":false},"repo":{"id":13131245,"name":"qiita","full_name":"biocore/qiita","owner":{"login":"biocore","id":6241857,"avatar_url":"https://avatars.githubusercontent.com/u/6241857?v=3","gravatar_id":"","url":"https://api.github.com/users/biocore","html_url":"https://github.com/biocore","followers_url":"https://api.github.com/users/biocore/followers","following_url":"https://api.github.com/users/biocore/following{/other_user}","gists_url":"https://api.github.com/users/biocore/gists{/gist_id}","starred_url":"https://api.github.com/users/biocore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/biocore/subscriptions","organizations_url":"https://api.github.com/users/biocore/orgs","repos_url":"https://api.github.com/users/biocore/repos","events_url":"https://api.github.com/users/biocore/events{/privacy}","received_events_url":"https://api.github.com/users/biocore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/biocore/qiita","description":"Qiita - A QIIME databasing effort","fork":false,"url":"https://api.github.com/repos/biocore/qiita","forks_url":"https://api.github.com/repos/biocore/qiita/forks","keys_url":"https://api.github.com/repos/biocore/qiita/keys{/key_id}","collaborators_url":"https://api.github.com/repos/biocore/qiita/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/biocore/qiita/teams","hooks_url":"https://api.github.com/repos/biocore/qiita/hooks","issue_events_url":"https://api.github.com/repos/biocore/qiita/issues/events{/number}","events_url":"https://api.github.com/repos/biocore/qiita/events","assignees_url":"https://api.github.com/repos/biocore/qiita/assignees{/user}","branches_url":"https://api.github.com/repos/biocore/qiita/branches{/branch}","tags_url":"https://api.github.com/repos/biocore/qiita/tags","blobs_url":"https://api.github.com/repos/biocore/qiita/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/biocore/qiita/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/biocore/qiita/git/refs{/sha}","trees_url":"https://api.github.com/repos/biocore/qiita/git/trees{/sha}","statuses_url":"https://api.github.com/repos/biocore/qiita/statuses/{sha}","languages_url":"https://api.github.com/repos/biocore/qiita/languages","stargazers_url":"https://api.github.com/repos/biocore/qiita/stargazers","contributors_url":"https://api.github.com/repos/biocore/qiita/contributors","subscribers_url":"https://api.github.com/repos/biocore/qiita/subscribers","subscription_url":"https://api.github.com/repos/biocore/qiita/subscription","commits_url":"https://api.github.com/repos/biocore/qiita/commits{/sha}","git_commits_url":"https://api.github.com/repos/biocore/qiita/git/commits{/sha}","comments_url":"https://api.github.com/repos/biocore/qiita/comments{/number}","issue_comment_url":"https://api.github.com/repos/biocore/qiita/issues/comments{/number}","contents_url":"https://api.github.com/repos/biocore/qiita/contents/{+path}","compare_url":"https://api.github.com/repos/biocore/qiita/compare/{base}...{head}","merges_url":"https://api.github.com/repos/biocore/qiita/merges","archive_url":"https://api.github.com/repos/biocore/qiita/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/biocore/qiita/downloads","issues_url":"https://api.github.com/repos/biocore/qiita/issues{/number}","pulls_url":"https://api.github.com/repos/biocore/qiita/pulls{/number}","milestones_url":"https://api.github.com/repos/biocore/qiita/milestones{/number}","notifications_url":"https://api.github.com/repos/biocore/qiita/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/biocore/qiita/labels{/name}","releases_url":"https://api.github.com/repos/biocore/qiita/releases{/id}","created_at":"2013-09-26T18:50:43Z","updated_at":"2015-05-03T20:00:00Z","pushed_at":"2015-05-04T21:53:33Z","git_url":"git://github.com/biocore/qiita.git","ssh_url":"git@github.com:biocore/qiita.git","clone_url":"https://github.com/biocore/qiita.git","svn_url":"https://github.com/biocore/qiita","homepage":"","size":128280,"stargazers_count":18,"watchers_count":18,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"open_issues_count":253,"forks":21,"open_issues":253,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/biocore/qiita/pulls/1144"},"html":{"href":"https://github.com/biocore/qiita/pull/1144"},"issue":{"href":"https://api.github.com/repos/biocore/qiita/issues/1144"},"comments":{"href":"https://api.github.com/repos/biocore/qiita/issues/1144/comments"},"review_comments":{"href":"https://api.github.com/repos/biocore/qiita/pulls/1144/comments"},"review_comment":{"href":"https://api.github.com/repos/biocore/qiita/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/biocore/qiita/pulls/1144/commits"},"statuses":{"href":"https://api.github.com/repos/biocore/qiita/statuses/d57bd9768856de57a7147096da49ce7dbc38f152"}}}}