{"action":"created","comment":{"url":"https://api.github.com/repos/apache/parquet-mr/pulls/comments/33077832","id":33077832,"diff_hunk":"@@ -22,13 +22,32 @@\n First, build the ``parquet-benchmarks`` module\n \n ```\n-mvn --projects parquet-benchmarks -amd -DskipTests -Denforcer.skip=true -P hadoop-2 clean package\n+mvn --projects parquet-benchmarks -amd -DskipTests -Denforcer.skip=true clean package\n ```\n \n-Then, you can run all the benchmarks with the following command\n+Then, you can run all the benchmarks with the following command (use parquetVersion=vN to specify\n+the parquet file format version)\n \n ```\n- ./parquet-benchmarks/run.sh -wi 5 -i 5 -f 3 -bm all\n+  ./parquet-benchmarks/run.sh -wi 5 -i 5 -f 3 -p parquetVersion=v1     # Run all benchmarks with PARQUET_1_0\n+  ./parquet-benchmarks/run.sh -wi 5 -i 5 -f 3 -p parquetVersion=v2     # Run all benchmarks with PARQUET_2_0\n+```\n+\n+Also, you can run only write or read benchmarks with the following command","path":"parquet-benchmarks/README.md","position":18,"original_position":18,"commit_id":"afb2b98ef2db258e00a1aee4cd0aec6244d1ea70","original_commit_id":"afb2b98ef2db258e00a1aee4cd0aec6244d1ea70","user":{"login":"nezihyigitbasi","id":1223839,"avatar_url":"https://avatars.githubusercontent.com/u/1223839?v=3","gravatar_id":"","url":"https://api.github.com/users/nezihyigitbasi","html_url":"https://github.com/nezihyigitbasi","followers_url":"https://api.github.com/users/nezihyigitbasi/followers","following_url":"https://api.github.com/users/nezihyigitbasi/following{/other_user}","gists_url":"https://api.github.com/users/nezihyigitbasi/gists{/gist_id}","starred_url":"https://api.github.com/users/nezihyigitbasi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nezihyigitbasi/subscriptions","organizations_url":"https://api.github.com/users/nezihyigitbasi/orgs","repos_url":"https://api.github.com/users/nezihyigitbasi/repos","events_url":"https://api.github.com/users/nezihyigitbasi/events{/privacy}","received_events_url":"https://api.github.com/users/nezihyigitbasi/received_events","type":"User","site_admin":false},"body":"`command` --> `commands`","created_at":"2015-06-23T18:55:04Z","updated_at":"2015-06-23T18:55:04Z","html_url":"https://github.com/apache/parquet-mr/pull/224#discussion_r33077832","pull_request_url":"https://api.github.com/repos/apache/parquet-mr/pulls/224","_links":{"self":{"href":"https://api.github.com/repos/apache/parquet-mr/pulls/comments/33077832"},"html":{"href":"https://github.com/apache/parquet-mr/pull/224#discussion_r33077832"},"pull_request":{"href":"https://api.github.com/repos/apache/parquet-mr/pulls/224"}}},"pull_request":{"url":"https://api.github.com/repos/apache/parquet-mr/pulls/224","id":38261075,"html_url":"https://github.com/apache/parquet-mr/pull/224","diff_url":"https://github.com/apache/parquet-mr/pull/224.diff","patch_url":"https://github.com/apache/parquet-mr/pull/224.patch","issue_url":"https://api.github.com/repos/apache/parquet-mr/issues/224","number":224,"state":"open","locked":false,"title":"PARQUET-315: Add PARQUET_1_0 and non-repeated data performance tests …","user":{"login":"spena","id":5048242,"avatar_url":"https://avatars.githubusercontent.com/u/5048242?v=3","gravatar_id":"","url":"https://api.github.com/users/spena","html_url":"https://github.com/spena","followers_url":"https://api.github.com/users/spena/followers","following_url":"https://api.github.com/users/spena/following{/other_user}","gists_url":"https://api.github.com/users/spena/gists{/gist_id}","starred_url":"https://api.github.com/users/spena/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spena/subscriptions","organizations_url":"https://api.github.com/users/spena/orgs","repos_url":"https://api.github.com/users/spena/repos","events_url":"https://api.github.com/users/spena/events{/privacy}","received_events_url":"https://api.github.com/users/spena/received_events","type":"User","site_admin":false},"body":"Here's a list of changes I did on the parquet-benchmarks module:\r\n- Add variable to test PARQUET_1_0 format\r\n- Add variable to generate random data for the tests\r\n- Move part of the DataGenerator.generate() code to constructors so that we measure time when\r\n  when writing data only.\r\n- Add annotation to display AverageTime. The Throughput mode was always displaying less than 1 op/s. So I thought time was a better mode here.\r\n\r\n@nezihyigitbasi @danielcweeks You did a good job starting the parquet-benchmarks module. Could you please review these changes?","created_at":"2015-06-22T18:26:51Z","updated_at":"2015-06-23T18:55:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6aa6f9849844fda364d9fac822090a77a8a6c8a4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/parquet-mr/pulls/224/commits","review_comments_url":"https://api.github.com/repos/apache/parquet-mr/pulls/224/comments","review_comment_url":"https://api.github.com/repos/apache/parquet-mr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/parquet-mr/issues/224/comments","statuses_url":"https://api.github.com/repos/apache/parquet-mr/statuses/afb2b98ef2db258e00a1aee4cd0aec6244d1ea70","head":{"label":"spena:parquet-315","ref":"parquet-315","sha":"afb2b98ef2db258e00a1aee4cd0aec6244d1ea70","user":{"login":"spena","id":5048242,"avatar_url":"https://avatars.githubusercontent.com/u/5048242?v=3","gravatar_id":"","url":"https://api.github.com/users/spena","html_url":"https://github.com/spena","followers_url":"https://api.github.com/users/spena/followers","following_url":"https://api.github.com/users/spena/following{/other_user}","gists_url":"https://api.github.com/users/spena/gists{/gist_id}","starred_url":"https://api.github.com/users/spena/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spena/subscriptions","organizations_url":"https://api.github.com/users/spena/orgs","repos_url":"https://api.github.com/users/spena/repos","events_url":"https://api.github.com/users/spena/events{/privacy}","received_events_url":"https://api.github.com/users/spena/received_events","type":"User","site_admin":false},"repo":{"id":37625590,"name":"parquet-mr","full_name":"spena/parquet-mr","owner":{"login":"spena","id":5048242,"avatar_url":"https://avatars.githubusercontent.com/u/5048242?v=3","gravatar_id":"","url":"https://api.github.com/users/spena","html_url":"https://github.com/spena","followers_url":"https://api.github.com/users/spena/followers","following_url":"https://api.github.com/users/spena/following{/other_user}","gists_url":"https://api.github.com/users/spena/gists{/gist_id}","starred_url":"https://api.github.com/users/spena/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spena/subscriptions","organizations_url":"https://api.github.com/users/spena/orgs","repos_url":"https://api.github.com/users/spena/repos","events_url":"https://api.github.com/users/spena/events{/privacy}","received_events_url":"https://api.github.com/users/spena/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/spena/parquet-mr","description":"Mirror of Apache Parquet","fork":true,"url":"https://api.github.com/repos/spena/parquet-mr","forks_url":"https://api.github.com/repos/spena/parquet-mr/forks","keys_url":"https://api.github.com/repos/spena/parquet-mr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spena/parquet-mr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spena/parquet-mr/teams","hooks_url":"https://api.github.com/repos/spena/parquet-mr/hooks","issue_events_url":"https://api.github.com/repos/spena/parquet-mr/issues/events{/number}","events_url":"https://api.github.com/repos/spena/parquet-mr/events","assignees_url":"https://api.github.com/repos/spena/parquet-mr/assignees{/user}","branches_url":"https://api.github.com/repos/spena/parquet-mr/branches{/branch}","tags_url":"https://api.github.com/repos/spena/parquet-mr/tags","blobs_url":"https://api.github.com/repos/spena/parquet-mr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spena/parquet-mr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spena/parquet-mr/git/refs{/sha}","trees_url":"https://api.github.com/repos/spena/parquet-mr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spena/parquet-mr/statuses/{sha}","languages_url":"https://api.github.com/repos/spena/parquet-mr/languages","stargazers_url":"https://api.github.com/repos/spena/parquet-mr/stargazers","contributors_url":"https://api.github.com/repos/spena/parquet-mr/contributors","subscribers_url":"https://api.github.com/repos/spena/parquet-mr/subscribers","subscription_url":"https://api.github.com/repos/spena/parquet-mr/subscription","commits_url":"https://api.github.com/repos/spena/parquet-mr/commits{/sha}","git_commits_url":"https://api.github.com/repos/spena/parquet-mr/git/commits{/sha}","comments_url":"https://api.github.com/repos/spena/parquet-mr/comments{/number}","issue_comment_url":"https://api.github.com/repos/spena/parquet-mr/issues/comments{/number}","contents_url":"https://api.github.com/repos/spena/parquet-mr/contents/{+path}","compare_url":"https://api.github.com/repos/spena/parquet-mr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spena/parquet-mr/merges","archive_url":"https://api.github.com/repos/spena/parquet-mr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spena/parquet-mr/downloads","issues_url":"https://api.github.com/repos/spena/parquet-mr/issues{/number}","pulls_url":"https://api.github.com/repos/spena/parquet-mr/pulls{/number}","milestones_url":"https://api.github.com/repos/spena/parquet-mr/milestones{/number}","notifications_url":"https://api.github.com/repos/spena/parquet-mr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spena/parquet-mr/labels{/name}","releases_url":"https://api.github.com/repos/spena/parquet-mr/releases{/id}","created_at":"2015-06-17T23:04:37Z","updated_at":"2015-06-17T23:04:39Z","pushed_at":"2015-06-23T18:32:48Z","git_url":"git://github.com/spena/parquet-mr.git","ssh_url":"git@github.com:spena/parquet-mr.git","clone_url":"https://github.com/spena/parquet-mr.git","svn_url":"https://github.com/spena/parquet-mr","homepage":null,"size":12920,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"079bcd0339f30343c01c5fd3d5521be4b822d30f","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":20675636,"name":"parquet-mr","full_name":"apache/parquet-mr","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/parquet-mr","description":"Mirror of Apache Parquet","fork":false,"url":"https://api.github.com/repos/apache/parquet-mr","forks_url":"https://api.github.com/repos/apache/parquet-mr/forks","keys_url":"https://api.github.com/repos/apache/parquet-mr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/parquet-mr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/parquet-mr/teams","hooks_url":"https://api.github.com/repos/apache/parquet-mr/hooks","issue_events_url":"https://api.github.com/repos/apache/parquet-mr/issues/events{/number}","events_url":"https://api.github.com/repos/apache/parquet-mr/events","assignees_url":"https://api.github.com/repos/apache/parquet-mr/assignees{/user}","branches_url":"https://api.github.com/repos/apache/parquet-mr/branches{/branch}","tags_url":"https://api.github.com/repos/apache/parquet-mr/tags","blobs_url":"https://api.github.com/repos/apache/parquet-mr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/parquet-mr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/parquet-mr/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/parquet-mr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/parquet-mr/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/parquet-mr/languages","stargazers_url":"https://api.github.com/repos/apache/parquet-mr/stargazers","contributors_url":"https://api.github.com/repos/apache/parquet-mr/contributors","subscribers_url":"https://api.github.com/repos/apache/parquet-mr/subscribers","subscription_url":"https://api.github.com/repos/apache/parquet-mr/subscription","commits_url":"https://api.github.com/repos/apache/parquet-mr/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/parquet-mr/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/parquet-mr/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/parquet-mr/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/parquet-mr/contents/{+path}","compare_url":"https://api.github.com/repos/apache/parquet-mr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/parquet-mr/merges","archive_url":"https://api.github.com/repos/apache/parquet-mr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/parquet-mr/downloads","issues_url":"https://api.github.com/repos/apache/parquet-mr/issues{/number}","pulls_url":"https://api.github.com/repos/apache/parquet-mr/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/parquet-mr/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/parquet-mr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/parquet-mr/labels{/name}","releases_url":"https://api.github.com/repos/apache/parquet-mr/releases{/id}","created_at":"2014-06-10T07:00:07Z","updated_at":"2015-06-17T15:58:06Z","pushed_at":"2015-06-23T18:48:29Z","git_url":"git://github.com/apache/parquet-mr.git","ssh_url":"git@github.com:apache/parquet-mr.git","clone_url":"https://github.com/apache/parquet-mr.git","svn_url":"https://github.com/apache/parquet-mr","homepage":null,"size":96149,"stargazers_count":97,"watchers_count":97,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":134,"mirror_url":"git://git.apache.org/incubator-parquet-mr.git","open_issues_count":50,"forks":134,"open_issues":50,"watchers":97,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/parquet-mr/pulls/224"},"html":{"href":"https://github.com/apache/parquet-mr/pull/224"},"issue":{"href":"https://api.github.com/repos/apache/parquet-mr/issues/224"},"comments":{"href":"https://api.github.com/repos/apache/parquet-mr/issues/224/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/parquet-mr/pulls/224/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/parquet-mr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/parquet-mr/pulls/224/commits"},"statuses":{"href":"https://api.github.com/repos/apache/parquet-mr/statuses/afb2b98ef2db258e00a1aee4cd0aec6244d1ea70"}}}}