{"action":"closed","number":2508,"pull_request":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/2508","id":36783997,"html_url":"https://github.com/dolphin-emu/dolphin/pull/2508","diff_url":"https://github.com/dolphin-emu/dolphin/pull/2508.diff","patch_url":"https://github.com/dolphin-emu/dolphin/pull/2508.patch","issue_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/2508","number":2508,"state":"closed","locked":false,"title":"Fix bug where Gecko codes would be \"enabled by default\"","user":{"login":"comex","id":47517,"avatar_url":"https://avatars.githubusercontent.com/u/47517?v=3","gravatar_id":"","url":"https://api.github.com/users/comex","html_url":"https://github.com/comex","followers_url":"https://api.github.com/users/comex/followers","following_url":"https://api.github.com/users/comex/following{/other_user}","gists_url":"https://api.github.com/users/comex/gists{/gist_id}","starred_url":"https://api.github.com/users/comex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/comex/subscriptions","organizations_url":"https://api.github.com/users/comex/orgs","repos_url":"https://api.github.com/users/comex/repos","events_url":"https://api.github.com/users/comex/events{/privacy}","received_events_url":"https://api.github.com/users/comex/received_events","type":"User","site_admin":false},"body":"Actually caused by IniFiles::GetLines leaving the output vector in its\r\nold state if the section wasn't found, and Gecko::LoadCodes not checking\r\nthe return value.  Fix by moving lines->clear() up.","created_at":"2015-06-02T23:05:52Z","updated_at":"2015-06-02T23:13:43Z","closed_at":"2015-06-02T23:13:43Z","merged_at":"2015-06-02T23:13:43Z","merge_commit_sha":"a431bde9e2c3f3ab3e6d31f45d8da143c097c6e2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/2508/commits","review_comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/2508/comments","review_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/2508/comments","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/35ca27f1cddedf537dfe3f69f0a9ca422fa6b1e0","head":{"label":"comex:fix-gecko-codes","ref":"fix-gecko-codes","sha":"35ca27f1cddedf537dfe3f69f0a9ca422fa6b1e0","user":{"login":"comex","id":47517,"avatar_url":"https://avatars.githubusercontent.com/u/47517?v=3","gravatar_id":"","url":"https://api.github.com/users/comex","html_url":"https://github.com/comex","followers_url":"https://api.github.com/users/comex/followers","following_url":"https://api.github.com/users/comex/following{/other_user}","gists_url":"https://api.github.com/users/comex/gists{/gist_id}","starred_url":"https://api.github.com/users/comex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/comex/subscriptions","organizations_url":"https://api.github.com/users/comex/orgs","repos_url":"https://api.github.com/users/comex/repos","events_url":"https://api.github.com/users/comex/events{/privacy}","received_events_url":"https://api.github.com/users/comex/received_events","type":"User","site_admin":false},"repo":{"id":18200306,"name":"dolphin","full_name":"comex/dolphin","owner":{"login":"comex","id":47517,"avatar_url":"https://avatars.githubusercontent.com/u/47517?v=3","gravatar_id":"","url":"https://api.github.com/users/comex","html_url":"https://github.com/comex","followers_url":"https://api.github.com/users/comex/followers","following_url":"https://api.github.com/users/comex/following{/other_user}","gists_url":"https://api.github.com/users/comex/gists{/gist_id}","starred_url":"https://api.github.com/users/comex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/comex/subscriptions","organizations_url":"https://api.github.com/users/comex/orgs","repos_url":"https://api.github.com/users/comex/repos","events_url":"https://api.github.com/users/comex/events{/privacy}","received_events_url":"https://api.github.com/users/comex/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/comex/dolphin","description":"Dolphin is a GameCube/Wii emulator, allowing you to play games for these two platforms on PC, with improvements.","fork":true,"url":"https://api.github.com/repos/comex/dolphin","forks_url":"https://api.github.com/repos/comex/dolphin/forks","keys_url":"https://api.github.com/repos/comex/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/comex/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/comex/dolphin/teams","hooks_url":"https://api.github.com/repos/comex/dolphin/hooks","issue_events_url":"https://api.github.com/repos/comex/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/comex/dolphin/events","assignees_url":"https://api.github.com/repos/comex/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/comex/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/comex/dolphin/tags","blobs_url":"https://api.github.com/repos/comex/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/comex/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/comex/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/comex/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/comex/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/comex/dolphin/languages","stargazers_url":"https://api.github.com/repos/comex/dolphin/stargazers","contributors_url":"https://api.github.com/repos/comex/dolphin/contributors","subscribers_url":"https://api.github.com/repos/comex/dolphin/subscribers","subscription_url":"https://api.github.com/repos/comex/dolphin/subscription","commits_url":"https://api.github.com/repos/comex/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/comex/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/comex/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/comex/dolphin/issues/comments{/number}","contents_url":"https://api.github.com/repos/comex/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/comex/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/comex/dolphin/merges","archive_url":"https://api.github.com/repos/comex/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/comex/dolphin/downloads","issues_url":"https://api.github.com/repos/comex/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/comex/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/comex/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/comex/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/comex/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/comex/dolphin/releases{/id}","created_at":"2014-03-28T03:47:13Z","updated_at":"2015-04-16T04:42:04Z","pushed_at":"2015-06-02T23:05:38Z","git_url":"git://github.com/comex/dolphin.git","ssh_url":"git@github.com:comex/dolphin.git","clone_url":"https://github.com/comex/dolphin.git","svn_url":"https://github.com/comex/dolphin","homepage":null,"size":227663,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"dolphin-emu:master","ref":"master","sha":"64ccea4e0512535944961c91afca040005ce6153","user":{"login":"dolphin-emu","id":5050316,"avatar_url":"https://avatars.githubusercontent.com/u/5050316?v=3","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"repo":{"id":11577304,"name":"dolphin","full_name":"dolphin-emu/dolphin","owner":{"login":"dolphin-emu","id":5050316,"avatar_url":"https://avatars.githubusercontent.com/u/5050316?v=3","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dolphin-emu/dolphin","description":"Dolphin is a GameCube / Wii emulator, allowing you to play games for these two platforms on PC with improvements.","fork":false,"url":"https://api.github.com/repos/dolphin-emu/dolphin","forks_url":"https://api.github.com/repos/dolphin-emu/dolphin/forks","keys_url":"https://api.github.com/repos/dolphin-emu/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dolphin-emu/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dolphin-emu/dolphin/teams","hooks_url":"https://api.github.com/repos/dolphin-emu/dolphin/hooks","issue_events_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/dolphin-emu/dolphin/events","assignees_url":"https://api.github.com/repos/dolphin-emu/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/dolphin-emu/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/tags","blobs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/dolphin-emu/dolphin/languages","stargazers_url":"https://api.github.com/repos/dolphin-emu/dolphin/stargazers","contributors_url":"https://api.github.com/repos/dolphin-emu/dolphin/contributors","subscribers_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscribers","subscription_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscription","commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/comments{/number}","contents_url":"https://api.github.com/repos/dolphin-emu/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/dolphin-emu/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dolphin-emu/dolphin/merges","archive_url":"https://api.github.com/repos/dolphin-emu/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dolphin-emu/dolphin/downloads","issues_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/dolphin-emu/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/dolphin-emu/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dolphin-emu/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/dolphin-emu/dolphin/releases{/id}","created_at":"2013-07-22T09:07:57Z","updated_at":"2015-06-02T18:34:30Z","pushed_at":"2015-06-02T23:13:44Z","git_url":"git://github.com/dolphin-emu/dolphin.git","ssh_url":"git@github.com:dolphin-emu/dolphin.git","clone_url":"https://github.com/dolphin-emu/dolphin.git","svn_url":"https://github.com/dolphin-emu/dolphin","homepage":"https://dolphin-emu.org/","size":296730,"stargazers_count":1413,"watchers_count":1413,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":430,"mirror_url":null,"open_issues_count":57,"forks":430,"open_issues":57,"watchers":1413,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/2508"},"html":{"href":"https://github.com/dolphin-emu/dolphin/pull/2508"},"issue":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/2508"},"comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/2508/comments"},"review_comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/2508/comments"},"review_comment":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/2508/commits"},"statuses":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/35ca27f1cddedf537dfe3f69f0a9ca422fa6b1e0"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"Tilka","id":123798,"avatar_url":"https://avatars.githubusercontent.com/u/123798?v=3","gravatar_id":"","url":"https://api.github.com/users/Tilka","html_url":"https://github.com/Tilka","followers_url":"https://api.github.com/users/Tilka/followers","following_url":"https://api.github.com/users/Tilka/following{/other_user}","gists_url":"https://api.github.com/users/Tilka/gists{/gist_id}","starred_url":"https://api.github.com/users/Tilka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tilka/subscriptions","organizations_url":"https://api.github.com/users/Tilka/orgs","repos_url":"https://api.github.com/users/Tilka/repos","events_url":"https://api.github.com/users/Tilka/events{/privacy}","received_events_url":"https://api.github.com/users/Tilka/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":2,"deletions":1,"changed_files":1}}