{"action":"created","comment":{"url":"https://api.github.com/repos/torch/nn/pulls/comments/43598433","id":43598433,"diff_hunk":"@@ -564,9 +564,13 @@ module = nn.Reshape(dimension1, dimension2, ... [, batchMode])\n ```\n \n \n-Reshapes an `nxpxqx..`  Tensor into a `dimension1xdimension2x...` Tensor, taking the elements column-wise.\n+Reshapes an `n x p x q x..`  Tensor into a `dimension1 x dimension2 x...` Tensor, taking the elements column-wise.\n \n-The optional last argument `batchMode`, when `true` forces the first dimension of the input to be considered the batch dimension, and thus keep its size fixed. This is necessary when dealing with batch sizes of one. When `false`, it forces the entire input (including the first dimension) to be reshaped to the input size. Default `batchMode=nil`, which means that the module considers inputs with more elements than the produce of provided sizes, i.e. `dimension1xdimension2x...`, to be batches.\n+The optional last argument `batchMode`, when `true` forces the first dimension of the input to be considered as the batch dimension (i.e., the size of the first dimension will be treated as the batch size), and thus keep the size of the first dimension fixed and only reshape the other dimensions. When `false`, it forces the entire input (including the first dimension) to be reshaped to the input size. The default for `batchMode` is `nil`, which means that this moudle will reshape all the dimensions only when the two statements below","path":"doc/simple.md","position":null,"original_position":8,"commit_id":"a89051c231f2d493119d551b693224eb262db506","original_commit_id":"e7a0c543d39ba2a90ff7df9d0aa7819c2b0a0c8d","user":{"login":"allanqunzi","id":7896282,"avatar_url":"https://avatars.githubusercontent.com/u/7896282?v=3","gravatar_id":"","url":"https://api.github.com/users/allanqunzi","html_url":"https://github.com/allanqunzi","followers_url":"https://api.github.com/users/allanqunzi/followers","following_url":"https://api.github.com/users/allanqunzi/following{/other_user}","gists_url":"https://api.github.com/users/allanqunzi/gists{/gist_id}","starred_url":"https://api.github.com/users/allanqunzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allanqunzi/subscriptions","organizations_url":"https://api.github.com/users/allanqunzi/orgs","repos_url":"https://api.github.com/users/allanqunzi/repos","events_url":"https://api.github.com/users/allanqunzi/events{/privacy}","received_events_url":"https://api.github.com/users/allanqunzi/received_events","type":"User","site_admin":false},"body":"Thanks, changed it.","created_at":"2015-11-02T05:45:37Z","updated_at":"2015-11-02T05:45:37Z","html_url":"https://github.com/torch/nn/pull/453#discussion_r43598433","pull_request_url":"https://api.github.com/repos/torch/nn/pulls/453","_links":{"self":{"href":"https://api.github.com/repos/torch/nn/pulls/comments/43598433"},"html":{"href":"https://github.com/torch/nn/pull/453#discussion_r43598433"},"pull_request":{"href":"https://api.github.com/repos/torch/nn/pulls/453"}}},"pull_request":{"url":"https://api.github.com/repos/torch/nn/pulls/453","id":49396011,"html_url":"https://github.com/torch/nn/pull/453","diff_url":"https://github.com/torch/nn/pull/453.diff","patch_url":"https://github.com/torch/nn/pull/453.patch","issue_url":"https://api.github.com/repos/torch/nn/issues/453","number":453,"state":"open","locked":false,"title":"Rewording the documentation for `nn.Reshape`","user":{"login":"allanqunzi","id":7896282,"avatar_url":"https://avatars.githubusercontent.com/u/7896282?v=3","gravatar_id":"","url":"https://api.github.com/users/allanqunzi","html_url":"https://github.com/allanqunzi","followers_url":"https://api.github.com/users/allanqunzi/followers","following_url":"https://api.github.com/users/allanqunzi/following{/other_user}","gists_url":"https://api.github.com/users/allanqunzi/gists{/gist_id}","starred_url":"https://api.github.com/users/allanqunzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allanqunzi/subscriptions","organizations_url":"https://api.github.com/users/allanqunzi/orgs","repos_url":"https://api.github.com/users/allanqunzi/repos","events_url":"https://api.github.com/users/allanqunzi/events{/privacy}","received_events_url":"https://api.github.com/users/allanqunzi/received_events","type":"User","site_admin":false},"body":"Rewording the documentation for `nn.Reshape` to make it more clear.","created_at":"2015-11-02T05:23:55Z","updated_at":"2015-11-02T05:45:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ddf88c9de004c69b8928b4bee25451e719a5ada3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/torch/nn/pulls/453/commits","review_comments_url":"https://api.github.com/repos/torch/nn/pulls/453/comments","review_comment_url":"https://api.github.com/repos/torch/nn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/torch/nn/issues/453/comments","statuses_url":"https://api.github.com/repos/torch/nn/statuses/a89051c231f2d493119d551b693224eb262db506","head":{"label":"allanqunzi:master","ref":"master","sha":"a89051c231f2d493119d551b693224eb262db506","user":{"login":"allanqunzi","id":7896282,"avatar_url":"https://avatars.githubusercontent.com/u/7896282?v=3","gravatar_id":"","url":"https://api.github.com/users/allanqunzi","html_url":"https://github.com/allanqunzi","followers_url":"https://api.github.com/users/allanqunzi/followers","following_url":"https://api.github.com/users/allanqunzi/following{/other_user}","gists_url":"https://api.github.com/users/allanqunzi/gists{/gist_id}","starred_url":"https://api.github.com/users/allanqunzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allanqunzi/subscriptions","organizations_url":"https://api.github.com/users/allanqunzi/orgs","repos_url":"https://api.github.com/users/allanqunzi/repos","events_url":"https://api.github.com/users/allanqunzi/events{/privacy}","received_events_url":"https://api.github.com/users/allanqunzi/received_events","type":"User","site_admin":false},"repo":{"id":45373281,"name":"nn","full_name":"allanqunzi/nn","owner":{"login":"allanqunzi","id":7896282,"avatar_url":"https://avatars.githubusercontent.com/u/7896282?v=3","gravatar_id":"","url":"https://api.github.com/users/allanqunzi","html_url":"https://github.com/allanqunzi","followers_url":"https://api.github.com/users/allanqunzi/followers","following_url":"https://api.github.com/users/allanqunzi/following{/other_user}","gists_url":"https://api.github.com/users/allanqunzi/gists{/gist_id}","starred_url":"https://api.github.com/users/allanqunzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allanqunzi/subscriptions","organizations_url":"https://api.github.com/users/allanqunzi/orgs","repos_url":"https://api.github.com/users/allanqunzi/repos","events_url":"https://api.github.com/users/allanqunzi/events{/privacy}","received_events_url":"https://api.github.com/users/allanqunzi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/allanqunzi/nn","description":"","fork":true,"url":"https://api.github.com/repos/allanqunzi/nn","forks_url":"https://api.github.com/repos/allanqunzi/nn/forks","keys_url":"https://api.github.com/repos/allanqunzi/nn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/allanqunzi/nn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/allanqunzi/nn/teams","hooks_url":"https://api.github.com/repos/allanqunzi/nn/hooks","issue_events_url":"https://api.github.com/repos/allanqunzi/nn/issues/events{/number}","events_url":"https://api.github.com/repos/allanqunzi/nn/events","assignees_url":"https://api.github.com/repos/allanqunzi/nn/assignees{/user}","branches_url":"https://api.github.com/repos/allanqunzi/nn/branches{/branch}","tags_url":"https://api.github.com/repos/allanqunzi/nn/tags","blobs_url":"https://api.github.com/repos/allanqunzi/nn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/allanqunzi/nn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/allanqunzi/nn/git/refs{/sha}","trees_url":"https://api.github.com/repos/allanqunzi/nn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/allanqunzi/nn/statuses/{sha}","languages_url":"https://api.github.com/repos/allanqunzi/nn/languages","stargazers_url":"https://api.github.com/repos/allanqunzi/nn/stargazers","contributors_url":"https://api.github.com/repos/allanqunzi/nn/contributors","subscribers_url":"https://api.github.com/repos/allanqunzi/nn/subscribers","subscription_url":"https://api.github.com/repos/allanqunzi/nn/subscription","commits_url":"https://api.github.com/repos/allanqunzi/nn/commits{/sha}","git_commits_url":"https://api.github.com/repos/allanqunzi/nn/git/commits{/sha}","comments_url":"https://api.github.com/repos/allanqunzi/nn/comments{/number}","issue_comment_url":"https://api.github.com/repos/allanqunzi/nn/issues/comments{/number}","contents_url":"https://api.github.com/repos/allanqunzi/nn/contents/{+path}","compare_url":"https://api.github.com/repos/allanqunzi/nn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/allanqunzi/nn/merges","archive_url":"https://api.github.com/repos/allanqunzi/nn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/allanqunzi/nn/downloads","issues_url":"https://api.github.com/repos/allanqunzi/nn/issues{/number}","pulls_url":"https://api.github.com/repos/allanqunzi/nn/pulls{/number}","milestones_url":"https://api.github.com/repos/allanqunzi/nn/milestones{/number}","notifications_url":"https://api.github.com/repos/allanqunzi/nn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/allanqunzi/nn/labels{/name}","releases_url":"https://api.github.com/repos/allanqunzi/nn/releases{/id}","created_at":"2015-11-02T05:08:15Z","updated_at":"2015-11-02T05:08:16Z","pushed_at":"2015-11-02T05:43:41Z","git_url":"git://github.com/allanqunzi/nn.git","ssh_url":"git@github.com:allanqunzi/nn.git","clone_url":"https://github.com/allanqunzi/nn.git","svn_url":"https://github.com/allanqunzi/nn","homepage":"","size":5061,"stargazers_count":0,"watchers_count":0,"language":"Lua","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"torch:master","ref":"master","sha":"36c89032fb0f6568383de413f9e309fee1763d73","user":{"login":"torch","id":4978924,"avatar_url":"https://avatars.githubusercontent.com/u/4978924?v=3","gravatar_id":"","url":"https://api.github.com/users/torch","html_url":"https://github.com/torch","followers_url":"https://api.github.com/users/torch/followers","following_url":"https://api.github.com/users/torch/following{/other_user}","gists_url":"https://api.github.com/users/torch/gists{/gist_id}","starred_url":"https://api.github.com/users/torch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/torch/subscriptions","organizations_url":"https://api.github.com/users/torch/orgs","repos_url":"https://api.github.com/users/torch/repos","events_url":"https://api.github.com/users/torch/events{/privacy}","received_events_url":"https://api.github.com/users/torch/received_events","type":"Organization","site_admin":false},"repo":{"id":13677447,"name":"nn","full_name":"torch/nn","owner":{"login":"torch","id":4978924,"avatar_url":"https://avatars.githubusercontent.com/u/4978924?v=3","gravatar_id":"","url":"https://api.github.com/users/torch","html_url":"https://github.com/torch","followers_url":"https://api.github.com/users/torch/followers","following_url":"https://api.github.com/users/torch/following{/other_user}","gists_url":"https://api.github.com/users/torch/gists{/gist_id}","starred_url":"https://api.github.com/users/torch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/torch/subscriptions","organizations_url":"https://api.github.com/users/torch/orgs","repos_url":"https://api.github.com/users/torch/repos","events_url":"https://api.github.com/users/torch/events{/privacy}","received_events_url":"https://api.github.com/users/torch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/torch/nn","description":"","fork":false,"url":"https://api.github.com/repos/torch/nn","forks_url":"https://api.github.com/repos/torch/nn/forks","keys_url":"https://api.github.com/repos/torch/nn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/torch/nn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/torch/nn/teams","hooks_url":"https://api.github.com/repos/torch/nn/hooks","issue_events_url":"https://api.github.com/repos/torch/nn/issues/events{/number}","events_url":"https://api.github.com/repos/torch/nn/events","assignees_url":"https://api.github.com/repos/torch/nn/assignees{/user}","branches_url":"https://api.github.com/repos/torch/nn/branches{/branch}","tags_url":"https://api.github.com/repos/torch/nn/tags","blobs_url":"https://api.github.com/repos/torch/nn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/torch/nn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/torch/nn/git/refs{/sha}","trees_url":"https://api.github.com/repos/torch/nn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/torch/nn/statuses/{sha}","languages_url":"https://api.github.com/repos/torch/nn/languages","stargazers_url":"https://api.github.com/repos/torch/nn/stargazers","contributors_url":"https://api.github.com/repos/torch/nn/contributors","subscribers_url":"https://api.github.com/repos/torch/nn/subscribers","subscription_url":"https://api.github.com/repos/torch/nn/subscription","commits_url":"https://api.github.com/repos/torch/nn/commits{/sha}","git_commits_url":"https://api.github.com/repos/torch/nn/git/commits{/sha}","comments_url":"https://api.github.com/repos/torch/nn/comments{/number}","issue_comment_url":"https://api.github.com/repos/torch/nn/issues/comments{/number}","contents_url":"https://api.github.com/repos/torch/nn/contents/{+path}","compare_url":"https://api.github.com/repos/torch/nn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/torch/nn/merges","archive_url":"https://api.github.com/repos/torch/nn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/torch/nn/downloads","issues_url":"https://api.github.com/repos/torch/nn/issues{/number}","pulls_url":"https://api.github.com/repos/torch/nn/pulls{/number}","milestones_url":"https://api.github.com/repos/torch/nn/milestones{/number}","notifications_url":"https://api.github.com/repos/torch/nn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/torch/nn/labels{/name}","releases_url":"https://api.github.com/repos/torch/nn/releases{/id}","created_at":"2013-10-18T12:27:25Z","updated_at":"2015-11-02T05:15:51Z","pushed_at":"2015-11-02T05:43:41Z","git_url":"git://github.com/torch/nn.git","ssh_url":"git@github.com:torch/nn.git","clone_url":"https://github.com/torch/nn.git","svn_url":"https://github.com/torch/nn","homepage":"","size":5061,"stargazers_count":308,"watchers_count":308,"language":"Lua","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":253,"mirror_url":null,"open_issues_count":37,"forks":253,"open_issues":37,"watchers":308,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/torch/nn/pulls/453"},"html":{"href":"https://github.com/torch/nn/pull/453"},"issue":{"href":"https://api.github.com/repos/torch/nn/issues/453"},"comments":{"href":"https://api.github.com/repos/torch/nn/issues/453/comments"},"review_comments":{"href":"https://api.github.com/repos/torch/nn/pulls/453/comments"},"review_comment":{"href":"https://api.github.com/repos/torch/nn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/torch/nn/pulls/453/commits"},"statuses":{"href":"https://api.github.com/repos/torch/nn/statuses/a89051c231f2d493119d551b693224eb262db506"}}}}