{"action":"created","issue":{"url":"https://api.github.com/repos/choderalab/openpathsampling/issues/196","labels_url":"https://api.github.com/repos/choderalab/openpathsampling/issues/196/labels{/name}","comments_url":"https://api.github.com/repos/choderalab/openpathsampling/issues/196/comments","events_url":"https://api.github.com/repos/choderalab/openpathsampling/issues/196/events","html_url":"https://github.com/choderalab/openpathsampling/pull/196","id":65309229,"number":196,"title":"Rename movepath [rename merge no. #4]","user":{"login":"jhprinz","id":5091934,"avatar_url":"https://avatars.githubusercontent.com/u/5091934?v=3","gravatar_id":"","url":"https://api.github.com/users/jhprinz","html_url":"https://github.com/jhprinz","followers_url":"https://api.github.com/users/jhprinz/followers","following_url":"https://api.github.com/users/jhprinz/following{/other_user}","gists_url":"https://api.github.com/users/jhprinz/gists{/gist_id}","starred_url":"https://api.github.com/users/jhprinz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhprinz/subscriptions","organizations_url":"https://api.github.com/users/jhprinz/orgs","repos_url":"https://api.github.com/users/jhprinz/repos","events_url":"https://api.github.com/users/jhprinz/events{/privacy}","received_events_url":"https://api.github.com/users/jhprinz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"dwhswenson","id":8178546,"avatar_url":"https://avatars.githubusercontent.com/u/8178546?v=3","gravatar_id":"","url":"https://api.github.com/users/dwhswenson","html_url":"https://github.com/dwhswenson","followers_url":"https://api.github.com/users/dwhswenson/followers","following_url":"https://api.github.com/users/dwhswenson/following{/other_user}","gists_url":"https://api.github.com/users/dwhswenson/gists{/gist_id}","starred_url":"https://api.github.com/users/dwhswenson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwhswenson/subscriptions","organizations_url":"https://api.github.com/users/dwhswenson/orgs","repos_url":"https://api.github.com/users/dwhswenson/repos","events_url":"https://api.github.com/users/dwhswenson/events{/privacy}","received_events_url":"https://api.github.com/users/dwhswenson/received_events","type":"User","site_admin":false},"milestone":null,"comments":10,"created_at":"2015-03-30T21:46:24Z","updated_at":"2015-04-22T17:34:12Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/choderalab/openpathsampling/pulls/196","html_url":"https://github.com/choderalab/openpathsampling/pull/196","diff_url":"https://github.com/choderalab/openpathsampling/pull/196.diff","patch_url":"https://github.com/choderalab/openpathsampling/pull/196.patch"},"body":"### Renaming\r\n- Rename MovePath to `PathMoveChange`\r\n- Rename stores to use plural `trajectory` -> `trajectories`\r\n\r\n### Visualization\r\n- fixes visualization of PathTrees. These should work again and the new sample attributes help here a lot. \r\n\r\n### ChainDict\r\n- fixes a bug in `chaindict` that could lead to wrong results when several storages were used and only some of these stored a CV\r\n- makes `chaindict` a little faster for writing and loading\r\n- there should be now lots of obsolete code in `chaindict` but I leave that for now\r\n\r\n### PathMoveChange and PathMovers\r\n- These have been reorganised as was discussed in PR #210.\r\n- There are now things attached to PathMovers and Samples. Both are accessed using details\r\n- Samples have more information, like `.accepted`, `.mover`, `.parent`, etc...\r\n- PathMovers can now be queried for their tree structure using `__contains__`\r\n- Samples load faster and use delayed loading of rarely accessed attributes\r\n- `__iter__` / `__reversed__` will traverse the PathMoveTree in order.\r\n- MoveDetails will be attached to MovePathChanges and not Samples!\r\n- change all tests for PathMovers and Shooters to check PathMoveChanges and not the Samples.\r\n- removes lots of unnecessary initialization of Samples with empty Details\r\n- PathMoveChanges are now trees and will be treated as such.\r\n- `__getitem__(self, n)` will select the n_th subchange\r\n- `__len__` will give the number of all underlying nodes (not the number of subcanges), this will be given by len(pm.subchanges)\r\n- `.subchange` is a property that returns the first sub change for conveniene and backwards portability\r\n"},"comment":{"url":"https://api.github.com/repos/choderalab/openpathsampling/issues/comments/95278256","html_url":"https://github.com/choderalab/openpathsampling/pull/196#issuecomment-95278256","issue_url":"https://api.github.com/repos/choderalab/openpathsampling/issues/196","id":95278256,"user":{"login":"dwhswenson","id":8178546,"avatar_url":"https://avatars.githubusercontent.com/u/8178546?v=3","gravatar_id":"","url":"https://api.github.com/users/dwhswenson","html_url":"https://github.com/dwhswenson","followers_url":"https://api.github.com/users/dwhswenson/followers","following_url":"https://api.github.com/users/dwhswenson/following{/other_user}","gists_url":"https://api.github.com/users/dwhswenson/gists{/gist_id}","starred_url":"https://api.github.com/users/dwhswenson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwhswenson/subscriptions","organizations_url":"https://api.github.com/users/dwhswenson/orgs","repos_url":"https://api.github.com/users/dwhswenson/repos","events_url":"https://api.github.com/users/dwhswenson/events{/privacy}","received_events_url":"https://api.github.com/users/dwhswenson/received_events","type":"User","site_admin":false},"created_at":"2015-04-22T17:34:12Z","updated_at":"2015-04-22T17:34:12Z","body":"Woohoo! Looks good from the quick review I could give (52 files changed is a *lot*). Merging."}}