{"action":"created","comment":{"url":"https://api.github.com/repos/sabel83/metashell/pulls/comments/48411086","id":48411086,"diff_hunk":"@@ -339,45 +332,58 @@ namespace\n   {\n     std::vector<std::string>\n       args{\n-        \"-Wfatal-errors\",\n         \"-iquote\", \".\",\n         \"-x\", \"c++-header\",\n         \"-I\", internal_dir_\n       };\n \n-    if (env_detector_.on_windows())\n+    if (UseInternalTemplight)\n     {\n-      args.push_back(\"-fno-ms-compatibility\");\n-      args.push_back(\"-U_MSC_VER\");\n-    }\n+      args.push_back(\"-Wfatal-errors\");\n \n-    if (!cpp_standard_set(config_.extra_clang_args))\n-    {\n-      args.push_back(\"-std=c++0x\");\n-    }\n+      if (env_detector_.on_windows())\n+      {\n+        args.push_back(\"-fno-ms-compatibility\");\n+        args.push_back(\"-U_MSC_VER\");\n+      }\n+\n+      if (!cpp_standard_set(config_.extra_clang_args))\n+      {\n+        args.push_back(\"-std=c++0x\");\n+      }\n+\n+      if (!max_template_depth_set(config_.extra_clang_args))\n+      {\n+        args.push_back(set_max_template_depth(256));\n+      }\n   \n-    if (!max_template_depth_set(config_.extra_clang_args))\n-    {\n-      args.push_back(set_max_template_depth(256));\n-    }\n+      const std::vector<std::string> include_path =\n+        determine_include_path(clang_path_, env_detector_, logger_);\n+      args.reserve(args.size() + include_path.size());\n+      for (const std::string& p : include_path)\n+      {\n+        args.push_back(\"-I\" + p);\n+      }\n \n-    const std::vector<std::string> include_path =\n-      determine_include_path(clang_path_, env_detector_, logger_);\n-    args.reserve(args.size() + include_path.size());\n-    for (const std::string& p : include_path)\n+      args.insert(\n+        args.end(),\n+        config_.extra_clang_args.begin(),\n+        config_.extra_clang_args.end()\n+      );\n+    }\n+    else if (config_.extra_clang_args.size() > 1)\n     {\n-      args.push_back(\"-I\" + p);\n+      args.insert(\n+        args.end(),\n+        config_.extra_clang_args.begin() + 1,\n+        config_.extra_clang_args.end()\n+      );\n     }\n \n-    args.insert(\n-      args.end(),\n-      config_.extra_clang_args.begin(),\n-      config_.extra_clang_args.end()\n-    );\n-\n     return args;\n   }\n \n+  template <bool UseInternalTemplight>","path":"lib/core/engine_clang.cpp","position":276,"original_position":276,"commit_id":"9a082da5eb7fb8d8ac254d34bb962fe12d4c722f","original_commit_id":"9a082da5eb7fb8d8ac254d34bb962fe12d4c722f","user":{"login":"sabel83","id":290270,"avatar_url":"https://avatars.githubusercontent.com/u/290270?v=3","gravatar_id":"","url":"https://api.github.com/users/sabel83","html_url":"https://github.com/sabel83","followers_url":"https://api.github.com/users/sabel83/followers","following_url":"https://api.github.com/users/sabel83/following{/other_user}","gists_url":"https://api.github.com/users/sabel83/gists{/gist_id}","starred_url":"https://api.github.com/users/sabel83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sabel83/subscriptions","organizations_url":"https://api.github.com/users/sabel83/orgs","repos_url":"https://api.github.com/users/sabel83/repos","events_url":"https://api.github.com/users/sabel83/events{/privacy}","received_events_url":"https://api.github.com/users/sabel83/received_events","type":"User","site_admin":false},"body":"The gcc in my dev env (4.8.4) doesn't seem to be able to handle parameter packs in lambdas. I haven't tried Visual C++, but I'd leave it the way it is for now to avoid having to upgrade compilers on all platforms.\r\n\r\nNote that I don't expect to have similar issues with other engines, as Clang is special case because of it being the \"internal\" compiler.","created_at":"2015-12-24T11:39:04Z","updated_at":"2015-12-24T11:39:04Z","html_url":"https://github.com/sabel83/metashell/pull/63#discussion_r48411086","pull_request_url":"https://api.github.com/repos/sabel83/metashell/pulls/63","_links":{"self":{"href":"https://api.github.com/repos/sabel83/metashell/pulls/comments/48411086"},"html":{"href":"https://github.com/sabel83/metashell/pull/63#discussion_r48411086"},"pull_request":{"href":"https://api.github.com/repos/sabel83/metashell/pulls/63"}}},"pull_request":{"url":"https://api.github.com/repos/sabel83/metashell/pulls/63","id":54507714,"html_url":"https://github.com/sabel83/metashell/pull/63","diff_url":"https://github.com/sabel83/metashell/pull/63.diff","patch_url":"https://github.com/sabel83/metashell/pull/63.patch","issue_url":"https://api.github.com/repos/sabel83/metashell/issues/63","number":63,"state":"open","locked":false,"title":"Clang engine","user":{"login":"sabel83","id":290270,"avatar_url":"https://avatars.githubusercontent.com/u/290270?v=3","gravatar_id":"","url":"https://api.github.com/users/sabel83","html_url":"https://github.com/sabel83","followers_url":"https://api.github.com/users/sabel83/followers","following_url":"https://api.github.com/users/sabel83/following{/other_user}","gists_url":"https://api.github.com/users/sabel83/gists{/gist_id}","starred_url":"https://api.github.com/users/sabel83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sabel83/subscriptions","organizations_url":"https://api.github.com/users/sabel83/orgs","repos_url":"https://api.github.com/users/sabel83/repos","events_url":"https://api.github.com/users/sabel83/events{/privacy}","received_events_url":"https://api.github.com/users/sabel83/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-12-23T21:20:05Z","updated_at":"2015-12-24T11:39:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fd0b9730bbf6789a68e22513aab30859de471af2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sabel83/metashell/pulls/63/commits","review_comments_url":"https://api.github.com/repos/sabel83/metashell/pulls/63/comments","review_comment_url":"https://api.github.com/repos/sabel83/metashell/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sabel83/metashell/issues/63/comments","statuses_url":"https://api.github.com/repos/sabel83/metashell/statuses/9a082da5eb7fb8d8ac254d34bb962fe12d4c722f","head":{"label":"sabel83:clang_engine","ref":"clang_engine","sha":"9a082da5eb7fb8d8ac254d34bb962fe12d4c722f","user":{"login":"sabel83","id":290270,"avatar_url":"https://avatars.githubusercontent.com/u/290270?v=3","gravatar_id":"","url":"https://api.github.com/users/sabel83","html_url":"https://github.com/sabel83","followers_url":"https://api.github.com/users/sabel83/followers","following_url":"https://api.github.com/users/sabel83/following{/other_user}","gists_url":"https://api.github.com/users/sabel83/gists{/gist_id}","starred_url":"https://api.github.com/users/sabel83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sabel83/subscriptions","organizations_url":"https://api.github.com/users/sabel83/orgs","repos_url":"https://api.github.com/users/sabel83/repos","events_url":"https://api.github.com/users/sabel83/events{/privacy}","received_events_url":"https://api.github.com/users/sabel83/received_events","type":"User","site_admin":false},"repo":{"id":11401082,"name":"metashell","full_name":"sabel83/metashell","owner":{"login":"sabel83","id":290270,"avatar_url":"https://avatars.githubusercontent.com/u/290270?v=3","gravatar_id":"","url":"https://api.github.com/users/sabel83","html_url":"https://github.com/sabel83","followers_url":"https://api.github.com/users/sabel83/followers","following_url":"https://api.github.com/users/sabel83/following{/other_user}","gists_url":"https://api.github.com/users/sabel83/gists{/gist_id}","starred_url":"https://api.github.com/users/sabel83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sabel83/subscriptions","organizations_url":"https://api.github.com/users/sabel83/orgs","repos_url":"https://api.github.com/users/sabel83/repos","events_url":"https://api.github.com/users/sabel83/events{/privacy}","received_events_url":"https://api.github.com/users/sabel83/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sabel83/metashell","description":"Template metaprogramming shell","fork":false,"url":"https://api.github.com/repos/sabel83/metashell","forks_url":"https://api.github.com/repos/sabel83/metashell/forks","keys_url":"https://api.github.com/repos/sabel83/metashell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sabel83/metashell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sabel83/metashell/teams","hooks_url":"https://api.github.com/repos/sabel83/metashell/hooks","issue_events_url":"https://api.github.com/repos/sabel83/metashell/issues/events{/number}","events_url":"https://api.github.com/repos/sabel83/metashell/events","assignees_url":"https://api.github.com/repos/sabel83/metashell/assignees{/user}","branches_url":"https://api.github.com/repos/sabel83/metashell/branches{/branch}","tags_url":"https://api.github.com/repos/sabel83/metashell/tags","blobs_url":"https://api.github.com/repos/sabel83/metashell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sabel83/metashell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sabel83/metashell/git/refs{/sha}","trees_url":"https://api.github.com/repos/sabel83/metashell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sabel83/metashell/statuses/{sha}","languages_url":"https://api.github.com/repos/sabel83/metashell/languages","stargazers_url":"https://api.github.com/repos/sabel83/metashell/stargazers","contributors_url":"https://api.github.com/repos/sabel83/metashell/contributors","subscribers_url":"https://api.github.com/repos/sabel83/metashell/subscribers","subscription_url":"https://api.github.com/repos/sabel83/metashell/subscription","commits_url":"https://api.github.com/repos/sabel83/metashell/commits{/sha}","git_commits_url":"https://api.github.com/repos/sabel83/metashell/git/commits{/sha}","comments_url":"https://api.github.com/repos/sabel83/metashell/comments{/number}","issue_comment_url":"https://api.github.com/repos/sabel83/metashell/issues/comments{/number}","contents_url":"https://api.github.com/repos/sabel83/metashell/contents/{+path}","compare_url":"https://api.github.com/repos/sabel83/metashell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sabel83/metashell/merges","archive_url":"https://api.github.com/repos/sabel83/metashell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sabel83/metashell/downloads","issues_url":"https://api.github.com/repos/sabel83/metashell/issues{/number}","pulls_url":"https://api.github.com/repos/sabel83/metashell/pulls{/number}","milestones_url":"https://api.github.com/repos/sabel83/metashell/milestones{/number}","notifications_url":"https://api.github.com/repos/sabel83/metashell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sabel83/metashell/labels{/name}","releases_url":"https://api.github.com/repos/sabel83/metashell/releases{/id}","created_at":"2013-07-14T09:39:33Z","updated_at":"2015-12-16T14:38:08Z","pushed_at":"2015-12-23T23:12:40Z","git_url":"git://github.com/sabel83/metashell.git","ssh_url":"git@github.com:sabel83/metashell.git","clone_url":"https://github.com/sabel83/metashell.git","svn_url":"https://github.com/sabel83/metashell","homepage":null,"size":78096,"stargazers_count":194,"watchers_count":194,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":3,"forks":17,"open_issues":3,"watchers":194,"default_branch":"master"}},"base":{"label":"sabel83:master","ref":"master","sha":"faa487a7b73e388ed958f38685ce1d3cdc6f386b","user":{"login":"sabel83","id":290270,"avatar_url":"https://avatars.githubusercontent.com/u/290270?v=3","gravatar_id":"","url":"https://api.github.com/users/sabel83","html_url":"https://github.com/sabel83","followers_url":"https://api.github.com/users/sabel83/followers","following_url":"https://api.github.com/users/sabel83/following{/other_user}","gists_url":"https://api.github.com/users/sabel83/gists{/gist_id}","starred_url":"https://api.github.com/users/sabel83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sabel83/subscriptions","organizations_url":"https://api.github.com/users/sabel83/orgs","repos_url":"https://api.github.com/users/sabel83/repos","events_url":"https://api.github.com/users/sabel83/events{/privacy}","received_events_url":"https://api.github.com/users/sabel83/received_events","type":"User","site_admin":false},"repo":{"id":11401082,"name":"metashell","full_name":"sabel83/metashell","owner":{"login":"sabel83","id":290270,"avatar_url":"https://avatars.githubusercontent.com/u/290270?v=3","gravatar_id":"","url":"https://api.github.com/users/sabel83","html_url":"https://github.com/sabel83","followers_url":"https://api.github.com/users/sabel83/followers","following_url":"https://api.github.com/users/sabel83/following{/other_user}","gists_url":"https://api.github.com/users/sabel83/gists{/gist_id}","starred_url":"https://api.github.com/users/sabel83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sabel83/subscriptions","organizations_url":"https://api.github.com/users/sabel83/orgs","repos_url":"https://api.github.com/users/sabel83/repos","events_url":"https://api.github.com/users/sabel83/events{/privacy}","received_events_url":"https://api.github.com/users/sabel83/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sabel83/metashell","description":"Template metaprogramming shell","fork":false,"url":"https://api.github.com/repos/sabel83/metashell","forks_url":"https://api.github.com/repos/sabel83/metashell/forks","keys_url":"https://api.github.com/repos/sabel83/metashell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sabel83/metashell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sabel83/metashell/teams","hooks_url":"https://api.github.com/repos/sabel83/metashell/hooks","issue_events_url":"https://api.github.com/repos/sabel83/metashell/issues/events{/number}","events_url":"https://api.github.com/repos/sabel83/metashell/events","assignees_url":"https://api.github.com/repos/sabel83/metashell/assignees{/user}","branches_url":"https://api.github.com/repos/sabel83/metashell/branches{/branch}","tags_url":"https://api.github.com/repos/sabel83/metashell/tags","blobs_url":"https://api.github.com/repos/sabel83/metashell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sabel83/metashell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sabel83/metashell/git/refs{/sha}","trees_url":"https://api.github.com/repos/sabel83/metashell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sabel83/metashell/statuses/{sha}","languages_url":"https://api.github.com/repos/sabel83/metashell/languages","stargazers_url":"https://api.github.com/repos/sabel83/metashell/stargazers","contributors_url":"https://api.github.com/repos/sabel83/metashell/contributors","subscribers_url":"https://api.github.com/repos/sabel83/metashell/subscribers","subscription_url":"https://api.github.com/repos/sabel83/metashell/subscription","commits_url":"https://api.github.com/repos/sabel83/metashell/commits{/sha}","git_commits_url":"https://api.github.com/repos/sabel83/metashell/git/commits{/sha}","comments_url":"https://api.github.com/repos/sabel83/metashell/comments{/number}","issue_comment_url":"https://api.github.com/repos/sabel83/metashell/issues/comments{/number}","contents_url":"https://api.github.com/repos/sabel83/metashell/contents/{+path}","compare_url":"https://api.github.com/repos/sabel83/metashell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sabel83/metashell/merges","archive_url":"https://api.github.com/repos/sabel83/metashell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sabel83/metashell/downloads","issues_url":"https://api.github.com/repos/sabel83/metashell/issues{/number}","pulls_url":"https://api.github.com/repos/sabel83/metashell/pulls{/number}","milestones_url":"https://api.github.com/repos/sabel83/metashell/milestones{/number}","notifications_url":"https://api.github.com/repos/sabel83/metashell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sabel83/metashell/labels{/name}","releases_url":"https://api.github.com/repos/sabel83/metashell/releases{/id}","created_at":"2013-07-14T09:39:33Z","updated_at":"2015-12-16T14:38:08Z","pushed_at":"2015-12-23T23:12:40Z","git_url":"git://github.com/sabel83/metashell.git","ssh_url":"git@github.com:sabel83/metashell.git","clone_url":"https://github.com/sabel83/metashell.git","svn_url":"https://github.com/sabel83/metashell","homepage":null,"size":78096,"stargazers_count":194,"watchers_count":194,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":3,"forks":17,"open_issues":3,"watchers":194,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sabel83/metashell/pulls/63"},"html":{"href":"https://github.com/sabel83/metashell/pull/63"},"issue":{"href":"https://api.github.com/repos/sabel83/metashell/issues/63"},"comments":{"href":"https://api.github.com/repos/sabel83/metashell/issues/63/comments"},"review_comments":{"href":"https://api.github.com/repos/sabel83/metashell/pulls/63/comments"},"review_comment":{"href":"https://api.github.com/repos/sabel83/metashell/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sabel83/metashell/pulls/63/commits"},"statuses":{"href":"https://api.github.com/repos/sabel83/metashell/statuses/9a082da5eb7fb8d8ac254d34bb962fe12d4c722f"}}}}