{"action":"created","comment":{"url":"https://api.github.com/repos/antirez/redis/pulls/comments/24847153","id":24847153,"diff_hunk":"@@ -70,6 +70,29 @@ tcp-backlog 511\n # unixsocket /tmp/redis.sock\n # unixsocketperm 700\n \n+# Enable forcing of TCP connections over SSL. \n+# If enabled, you must specify either a certificate root store file or directory (not both) in \n+# PEM format (or a set of PEM files if a directory). You must also specify the certificate for the\n+# server, the private key file, and the Diffie-Hellman parameters file. These may be in separate files\n+# or in the same file. All files must be in PEM format (as required by openSSL). \n+# If you wish, you can customize the cipher list to use when accepting SSL connections. By default, the list\n+# By default, we use all ciphers with the exception of: ones with anonymous Diffie-Hellman, low-strength ciphers, \n+# export ciphers, md5 hashing. Ordered from strongest to weakest.\n+# Note that as ciphers become broken, it will be necessary to change the available cipher list to remain secure. \n+#\n+# If you are using slave processes, and wish to validate the common name of the redis server, you can\n+# specify the parameter ssl_cert_common_name with the name you wish to validate against.\n+#\n+# ssl true\n+# ssl_ca_root_dir < Path to your openSSL root certificates directory >\n+# ssl_ca_root_file < Path to your openSSL root certificate file (You must specify either a root CA file, or a directory, but not both) >\n+# ssl_cert_file <Path to your server's SSL cert>\n+# ssl_pk_file <Path to your server's private key file (may be the same as above)>\n+# ssl_dhk_file <Path to your Diffie-Hellman data file (may be the same as above)>\n+# ssl_cert_pass <optional - password for server cert file>\n+# ssl_cipher_list <optional - cipher list to use for the server. Defaults to ALL:!ADH:!LOW:!EXP:!MD5:@STRENGTH>\n+# ssl_cert_common_name <optional - common name of server cert to match>\n+","path":"redis.conf","position":26,"original_position":26,"commit_id":"c69382d8d44fc0d2dff83a4ce7dbf31d19b58c0a","original_commit_id":"c69382d8d44fc0d2dff83a4ce7dbf31d19b58c0a","user":{"login":"joemiller","id":377603,"avatar_url":"https://avatars.githubusercontent.com/u/377603?v=3","gravatar_id":"","url":"https://api.github.com/users/joemiller","html_url":"https://github.com/joemiller","followers_url":"https://api.github.com/users/joemiller/followers","following_url":"https://api.github.com/users/joemiller/following{/other_user}","gists_url":"https://api.github.com/users/joemiller/gists{/gist_id}","starred_url":"https://api.github.com/users/joemiller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joemiller/subscriptions","organizations_url":"https://api.github.com/users/joemiller/orgs","repos_url":"https://api.github.com/users/joemiller/repos","events_url":"https://api.github.com/users/joemiller/events{/privacy}","received_events_url":"https://api.github.com/users/joemiller/received_events","type":"User","site_admin":false},"body":"A nit: instead of `root_dir` and `root_file` a more common term might be `ca_bundle_file` and `ca_bundle_dir` since the certs in these locations are both CA root and intermediates and other things (cross-signing CAs etc)","created_at":"2015-02-17T19:47:29Z","updated_at":"2015-02-17T19:47:29Z","html_url":"https://github.com/antirez/redis/pull/2402#discussion_r24847153","pull_request_url":"https://api.github.com/repos/antirez/redis/pulls/2402","_links":{"self":{"href":"https://api.github.com/repos/antirez/redis/pulls/comments/24847153"},"html":{"href":"https://github.com/antirez/redis/pull/2402#discussion_r24847153"},"pull_request":{"href":"https://api.github.com/repos/antirez/redis/pulls/2402"}}},"pull_request":{"url":"https://api.github.com/repos/antirez/redis/pulls/2402","id":29468795,"html_url":"https://github.com/antirez/redis/pull/2402","diff_url":"https://github.com/antirez/redis/pull/2402.diff","patch_url":"https://github.com/antirez/redis/pull/2402.patch","issue_url":"https://api.github.com/repos/antirez/redis/issues/2402","number":2402,"state":"open","locked":false,"title":"Redis SSL support (#2178)","user":{"login":"bbroerman30","id":2095142,"avatar_url":"https://avatars.githubusercontent.com/u/2095142?v=3","gravatar_id":"","url":"https://api.github.com/users/bbroerman30","html_url":"https://github.com/bbroerman30","followers_url":"https://api.github.com/users/bbroerman30/followers","following_url":"https://api.github.com/users/bbroerman30/following{/other_user}","gists_url":"https://api.github.com/users/bbroerman30/gists{/gist_id}","starred_url":"https://api.github.com/users/bbroerman30/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbroerman30/subscriptions","organizations_url":"https://api.github.com/users/bbroerman30/orgs","repos_url":"https://api.github.com/users/bbroerman30/repos","events_url":"https://api.github.com/users/bbroerman30/events{/privacy}","received_events_url":"https://api.github.com/users/bbroerman30/received_events","type":"User","site_admin":false},"body":"Initial PR for adding SSL support natively to Redis.","created_at":"2015-02-17T19:12:23Z","updated_at":"2015-02-17T19:47:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/antirez/redis/pulls/2402/commits","review_comments_url":"https://api.github.com/repos/antirez/redis/pulls/2402/comments","review_comment_url":"https://api.github.com/repos/antirez/redis/pulls/comments/{number}","comments_url":"https://api.github.com/repos/antirez/redis/issues/2402/comments","statuses_url":"https://api.github.com/repos/antirez/redis/statuses/c69382d8d44fc0d2dff83a4ce7dbf31d19b58c0a","head":{"label":"bbroerman30:unstable","ref":"unstable","sha":"c69382d8d44fc0d2dff83a4ce7dbf31d19b58c0a","user":{"login":"bbroerman30","id":2095142,"avatar_url":"https://avatars.githubusercontent.com/u/2095142?v=3","gravatar_id":"","url":"https://api.github.com/users/bbroerman30","html_url":"https://github.com/bbroerman30","followers_url":"https://api.github.com/users/bbroerman30/followers","following_url":"https://api.github.com/users/bbroerman30/following{/other_user}","gists_url":"https://api.github.com/users/bbroerman30/gists{/gist_id}","starred_url":"https://api.github.com/users/bbroerman30/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbroerman30/subscriptions","organizations_url":"https://api.github.com/users/bbroerman30/orgs","repos_url":"https://api.github.com/users/bbroerman30/repos","events_url":"https://api.github.com/users/bbroerman30/events{/privacy}","received_events_url":"https://api.github.com/users/bbroerman30/received_events","type":"User","site_admin":false},"repo":{"id":28524644,"name":"redis","full_name":"bbroerman30/redis","owner":{"login":"bbroerman30","id":2095142,"avatar_url":"https://avatars.githubusercontent.com/u/2095142?v=3","gravatar_id":"","url":"https://api.github.com/users/bbroerman30","html_url":"https://github.com/bbroerman30","followers_url":"https://api.github.com/users/bbroerman30/followers","following_url":"https://api.github.com/users/bbroerman30/following{/other_user}","gists_url":"https://api.github.com/users/bbroerman30/gists{/gist_id}","starred_url":"https://api.github.com/users/bbroerman30/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbroerman30/subscriptions","organizations_url":"https://api.github.com/users/bbroerman30/orgs","repos_url":"https://api.github.com/users/bbroerman30/repos","events_url":"https://api.github.com/users/bbroerman30/events{/privacy}","received_events_url":"https://api.github.com/users/bbroerman30/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bbroerman30/redis","description":"Redis is an in-memory database that persists on disk. The data model is key-value, but many different kind of values are supported: Strings, Lists, Sets, Sorted Sets, Hashes, HyperLogLogs, Bitmaps.","fork":true,"url":"https://api.github.com/repos/bbroerman30/redis","forks_url":"https://api.github.com/repos/bbroerman30/redis/forks","keys_url":"https://api.github.com/repos/bbroerman30/redis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bbroerman30/redis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bbroerman30/redis/teams","hooks_url":"https://api.github.com/repos/bbroerman30/redis/hooks","issue_events_url":"https://api.github.com/repos/bbroerman30/redis/issues/events{/number}","events_url":"https://api.github.com/repos/bbroerman30/redis/events","assignees_url":"https://api.github.com/repos/bbroerman30/redis/assignees{/user}","branches_url":"https://api.github.com/repos/bbroerman30/redis/branches{/branch}","tags_url":"https://api.github.com/repos/bbroerman30/redis/tags","blobs_url":"https://api.github.com/repos/bbroerman30/redis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bbroerman30/redis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bbroerman30/redis/git/refs{/sha}","trees_url":"https://api.github.com/repos/bbroerman30/redis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bbroerman30/redis/statuses/{sha}","languages_url":"https://api.github.com/repos/bbroerman30/redis/languages","stargazers_url":"https://api.github.com/repos/bbroerman30/redis/stargazers","contributors_url":"https://api.github.com/repos/bbroerman30/redis/contributors","subscribers_url":"https://api.github.com/repos/bbroerman30/redis/subscribers","subscription_url":"https://api.github.com/repos/bbroerman30/redis/subscription","commits_url":"https://api.github.com/repos/bbroerman30/redis/commits{/sha}","git_commits_url":"https://api.github.com/repos/bbroerman30/redis/git/commits{/sha}","comments_url":"https://api.github.com/repos/bbroerman30/redis/comments{/number}","issue_comment_url":"https://api.github.com/repos/bbroerman30/redis/issues/comments/{number}","contents_url":"https://api.github.com/repos/bbroerman30/redis/contents/{+path}","compare_url":"https://api.github.com/repos/bbroerman30/redis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bbroerman30/redis/merges","archive_url":"https://api.github.com/repos/bbroerman30/redis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bbroerman30/redis/downloads","issues_url":"https://api.github.com/repos/bbroerman30/redis/issues{/number}","pulls_url":"https://api.github.com/repos/bbroerman30/redis/pulls{/number}","milestones_url":"https://api.github.com/repos/bbroerman30/redis/milestones{/number}","notifications_url":"https://api.github.com/repos/bbroerman30/redis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bbroerman30/redis/labels{/name}","releases_url":"https://api.github.com/repos/bbroerman30/redis/releases{/id}","created_at":"2014-12-27T00:17:57Z","updated_at":"2015-02-12T03:26:59Z","pushed_at":"2015-02-12T03:26:59Z","git_url":"git://github.com/bbroerman30/redis.git","ssh_url":"git@github.com:bbroerman30/redis.git","clone_url":"https://github.com/bbroerman30/redis.git","svn_url":"https://github.com/bbroerman30/redis","homepage":"http://redis.io","size":19349,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"unstable"}},"base":{"label":"antirez:unstable","ref":"unstable","sha":"cfe5eaaed6c136f34db8ada4a704dc81491e2742","user":{"login":"antirez","id":65632,"avatar_url":"https://avatars.githubusercontent.com/u/65632?v=3","gravatar_id":"","url":"https://api.github.com/users/antirez","html_url":"https://github.com/antirez","followers_url":"https://api.github.com/users/antirez/followers","following_url":"https://api.github.com/users/antirez/following{/other_user}","gists_url":"https://api.github.com/users/antirez/gists{/gist_id}","starred_url":"https://api.github.com/users/antirez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antirez/subscriptions","organizations_url":"https://api.github.com/users/antirez/orgs","repos_url":"https://api.github.com/users/antirez/repos","events_url":"https://api.github.com/users/antirez/events{/privacy}","received_events_url":"https://api.github.com/users/antirez/received_events","type":"User","site_admin":false},"repo":{"id":156018,"name":"redis","full_name":"antirez/redis","owner":{"login":"antirez","id":65632,"avatar_url":"https://avatars.githubusercontent.com/u/65632?v=3","gravatar_id":"","url":"https://api.github.com/users/antirez","html_url":"https://github.com/antirez","followers_url":"https://api.github.com/users/antirez/followers","following_url":"https://api.github.com/users/antirez/following{/other_user}","gists_url":"https://api.github.com/users/antirez/gists{/gist_id}","starred_url":"https://api.github.com/users/antirez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antirez/subscriptions","organizations_url":"https://api.github.com/users/antirez/orgs","repos_url":"https://api.github.com/users/antirez/repos","events_url":"https://api.github.com/users/antirez/events{/privacy}","received_events_url":"https://api.github.com/users/antirez/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/antirez/redis","description":"Redis is an in-memory database that persists on disk. The data model is key-value, but many different kind of values are supported: Strings, Lists, Sets, Sorted Sets, Hashes, HyperLogLogs, Bitmaps.","fork":false,"url":"https://api.github.com/repos/antirez/redis","forks_url":"https://api.github.com/repos/antirez/redis/forks","keys_url":"https://api.github.com/repos/antirez/redis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/antirez/redis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/antirez/redis/teams","hooks_url":"https://api.github.com/repos/antirez/redis/hooks","issue_events_url":"https://api.github.com/repos/antirez/redis/issues/events{/number}","events_url":"https://api.github.com/repos/antirez/redis/events","assignees_url":"https://api.github.com/repos/antirez/redis/assignees{/user}","branches_url":"https://api.github.com/repos/antirez/redis/branches{/branch}","tags_url":"https://api.github.com/repos/antirez/redis/tags","blobs_url":"https://api.github.com/repos/antirez/redis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/antirez/redis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/antirez/redis/git/refs{/sha}","trees_url":"https://api.github.com/repos/antirez/redis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/antirez/redis/statuses/{sha}","languages_url":"https://api.github.com/repos/antirez/redis/languages","stargazers_url":"https://api.github.com/repos/antirez/redis/stargazers","contributors_url":"https://api.github.com/repos/antirez/redis/contributors","subscribers_url":"https://api.github.com/repos/antirez/redis/subscribers","subscription_url":"https://api.github.com/repos/antirez/redis/subscription","commits_url":"https://api.github.com/repos/antirez/redis/commits{/sha}","git_commits_url":"https://api.github.com/repos/antirez/redis/git/commits{/sha}","comments_url":"https://api.github.com/repos/antirez/redis/comments{/number}","issue_comment_url":"https://api.github.com/repos/antirez/redis/issues/comments/{number}","contents_url":"https://api.github.com/repos/antirez/redis/contents/{+path}","compare_url":"https://api.github.com/repos/antirez/redis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/antirez/redis/merges","archive_url":"https://api.github.com/repos/antirez/redis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/antirez/redis/downloads","issues_url":"https://api.github.com/repos/antirez/redis/issues{/number}","pulls_url":"https://api.github.com/repos/antirez/redis/pulls{/number}","milestones_url":"https://api.github.com/repos/antirez/redis/milestones{/number}","notifications_url":"https://api.github.com/repos/antirez/redis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/antirez/redis/labels{/name}","releases_url":"https://api.github.com/repos/antirez/redis/releases{/id}","created_at":"2009-03-21T22:32:25Z","updated_at":"2015-02-17T19:05:01Z","pushed_at":"2015-02-14T16:19:45Z","git_url":"git://github.com/antirez/redis.git","ssh_url":"git@github.com:antirez/redis.git","clone_url":"https://github.com/antirez/redis.git","svn_url":"https://github.com/antirez/redis","homepage":"http://redis.io","size":157331,"stargazers_count":12128,"watchers_count":12128,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3885,"mirror_url":null,"open_issues_count":648,"forks":3885,"open_issues":648,"watchers":12128,"default_branch":"unstable"}},"_links":{"self":{"href":"https://api.github.com/repos/antirez/redis/pulls/2402"},"html":{"href":"https://github.com/antirez/redis/pull/2402"},"issue":{"href":"https://api.github.com/repos/antirez/redis/issues/2402"},"comments":{"href":"https://api.github.com/repos/antirez/redis/issues/2402/comments"},"review_comments":{"href":"https://api.github.com/repos/antirez/redis/pulls/2402/comments"},"review_comment":{"href":"https://api.github.com/repos/antirez/redis/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/antirez/redis/pulls/2402/commits"},"statuses":{"href":"https://api.github.com/repos/antirez/redis/statuses/c69382d8d44fc0d2dff83a4ce7dbf31d19b58c0a"}}}}