{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/sti-perl/pulls/comments/33549260","id":33549260,"diff_hunk":"@@ -23,23 +23,23 @@ LABEL Component=\"perl516\" \\\n # Copy the STI scripts from the specific language image to /usr/local/sti\n COPY ./.sti/bin/ /usr/local/sti\n \n-# Each language image can have 'contrib' a directory with extra files needed to\n-# run and build the applications.\n-COPY ./contrib/ /opt/openshift\n-\n # TODO: Cleanup cpanp cache after cpanminus is installed?\n RUN yum-config-manager --enable rhel-server-rhscl-7-rpms \\\n     yum-config-manager --enable rhel-7-server-optional-rpms && \\\n     yum install -y --setopt=tsflags=nodocs httpd24 perl516 perl516-mod_perl perl516-perl-CPANPLUS && \\\n     yum clean all && \\\n     scl enable perl516 -- cpanp 's conf prereqs 1; s save system' && \\\n-    scl enable perl516 -- cpanp 's conf allow_build_interactivity 0; s save system' && \\\n-    chown -R default:default /opt/openshift && \\\n-    sed -i -f /opt/openshift/etc/httpdconf.sed /opt/rh/httpd24/root/etc/httpd/conf/httpd.conf  && \\\n-    chmod -R og+rwx /opt/rh/httpd24/root/var/run/httpd && \\\n-    mkdir /opt/openshift/config && \\\n-    chmod -R og+rwx /opt/openshift/config\n+    scl enable perl516 -- cpanp 's conf allow_build_interactivity 0; s save system'\n \n+# Each language image can have 'contrib' a directory with extra files needed to\n+# run and build the applications.\n+COPY ./contrib/ /opt/openshift\n+\n+# Drop the root user and make the content of /opt/openshift owned by user 1001","path":"5.16/Dockerfile.rhel7","position":41,"original_position":41,"commit_id":"853b9ee2ea23207bfabe8f1a05b1645ad15f659b","original_commit_id":"853b9ee2ea23207bfabe8f1a05b1645ad15f659b","user":{"login":"mfojtik","id":44136,"avatar_url":"https://avatars.githubusercontent.com/u/44136?v=3","gravatar_id":"","url":"https://api.github.com/users/mfojtik","html_url":"https://github.com/mfojtik","followers_url":"https://api.github.com/users/mfojtik/followers","following_url":"https://api.github.com/users/mfojtik/following{/other_user}","gists_url":"https://api.github.com/users/mfojtik/gists{/gist_id}","starred_url":"https://api.github.com/users/mfojtik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfojtik/subscriptions","organizations_url":"https://api.github.com/users/mfojtik/orgs","repos_url":"https://api.github.com/users/mfojtik/repos","events_url":"https://api.github.com/users/mfojtik/events{/privacy}","received_events_url":"https://api.github.com/users/mfojtik/received_events","type":"User","site_admin":false},"body":"I ment this comment to apply to the RUN as well, where you have to chown/chmod some dir in order to drop the user privileges.","created_at":"2015-06-30T08:09:52Z","updated_at":"2015-06-30T08:09:52Z","html_url":"https://github.com/openshift/sti-perl/pull/31#discussion_r33549260","pull_request_url":"https://api.github.com/repos/openshift/sti-perl/pulls/31","_links":{"self":{"href":"https://api.github.com/repos/openshift/sti-perl/pulls/comments/33549260"},"html":{"href":"https://github.com/openshift/sti-perl/pull/31#discussion_r33549260"},"pull_request":{"href":"https://api.github.com/repos/openshift/sti-perl/pulls/31"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/sti-perl/pulls/31","id":38761885,"html_url":"https://github.com/openshift/sti-perl/pull/31","diff_url":"https://github.com/openshift/sti-perl/pull/31.diff","patch_url":"https://github.com/openshift/sti-perl/pull/31.patch","issue_url":"https://api.github.com/repos/openshift/sti-perl/issues/31","number":31,"state":"open","locked":false,"title":"Fix the label schema","user":{"login":"mfojtik","id":44136,"avatar_url":"https://avatars.githubusercontent.com/u/44136?v=3","gravatar_id":"","url":"https://api.github.com/users/mfojtik","html_url":"https://github.com/mfojtik","followers_url":"https://api.github.com/users/mfojtik/followers","following_url":"https://api.github.com/users/mfojtik/following{/other_user}","gists_url":"https://api.github.com/users/mfojtik/gists{/gist_id}","starred_url":"https://api.github.com/users/mfojtik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfojtik/subscriptions","organizations_url":"https://api.github.com/users/mfojtik/orgs","repos_url":"https://api.github.com/users/mfojtik/repos","events_url":"https://api.github.com/users/mfojtik/events{/privacy}","received_events_url":"https://api.github.com/users/mfojtik/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-06-29T10:52:05Z","updated_at":"2015-06-30T08:09:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7a30300c9e1cd4f77705e18861d94c38db8dee96","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openshift/sti-perl/pulls/31/commits","review_comments_url":"https://api.github.com/repos/openshift/sti-perl/pulls/31/comments","review_comment_url":"https://api.github.com/repos/openshift/sti-perl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/sti-perl/issues/31/comments","statuses_url":"https://api.github.com/repos/openshift/sti-perl/statuses/853b9ee2ea23207bfabe8f1a05b1645ad15f659b","head":{"label":"mfojtik:fix-labels","ref":"fix-labels","sha":"853b9ee2ea23207bfabe8f1a05b1645ad15f659b","user":{"login":"mfojtik","id":44136,"avatar_url":"https://avatars.githubusercontent.com/u/44136?v=3","gravatar_id":"","url":"https://api.github.com/users/mfojtik","html_url":"https://github.com/mfojtik","followers_url":"https://api.github.com/users/mfojtik/followers","following_url":"https://api.github.com/users/mfojtik/following{/other_user}","gists_url":"https://api.github.com/users/mfojtik/gists{/gist_id}","starred_url":"https://api.github.com/users/mfojtik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfojtik/subscriptions","organizations_url":"https://api.github.com/users/mfojtik/orgs","repos_url":"https://api.github.com/users/mfojtik/repos","events_url":"https://api.github.com/users/mfojtik/events{/privacy}","received_events_url":"https://api.github.com/users/mfojtik/received_events","type":"User","site_admin":false},"repo":{"id":35148553,"name":"sti-perl","full_name":"mfojtik/sti-perl","owner":{"login":"mfojtik","id":44136,"avatar_url":"https://avatars.githubusercontent.com/u/44136?v=3","gravatar_id":"","url":"https://api.github.com/users/mfojtik","html_url":"https://github.com/mfojtik","followers_url":"https://api.github.com/users/mfojtik/followers","following_url":"https://api.github.com/users/mfojtik/following{/other_user}","gists_url":"https://api.github.com/users/mfojtik/gists{/gist_id}","starred_url":"https://api.github.com/users/mfojtik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfojtik/subscriptions","organizations_url":"https://api.github.com/users/mfojtik/orgs","repos_url":"https://api.github.com/users/mfojtik/repos","events_url":"https://api.github.com/users/mfojtik/events{/privacy}","received_events_url":"https://api.github.com/users/mfojtik/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mfojtik/sti-perl","description":"","fork":true,"url":"https://api.github.com/repos/mfojtik/sti-perl","forks_url":"https://api.github.com/repos/mfojtik/sti-perl/forks","keys_url":"https://api.github.com/repos/mfojtik/sti-perl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mfojtik/sti-perl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mfojtik/sti-perl/teams","hooks_url":"https://api.github.com/repos/mfojtik/sti-perl/hooks","issue_events_url":"https://api.github.com/repos/mfojtik/sti-perl/issues/events{/number}","events_url":"https://api.github.com/repos/mfojtik/sti-perl/events","assignees_url":"https://api.github.com/repos/mfojtik/sti-perl/assignees{/user}","branches_url":"https://api.github.com/repos/mfojtik/sti-perl/branches{/branch}","tags_url":"https://api.github.com/repos/mfojtik/sti-perl/tags","blobs_url":"https://api.github.com/repos/mfojtik/sti-perl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mfojtik/sti-perl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mfojtik/sti-perl/git/refs{/sha}","trees_url":"https://api.github.com/repos/mfojtik/sti-perl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mfojtik/sti-perl/statuses/{sha}","languages_url":"https://api.github.com/repos/mfojtik/sti-perl/languages","stargazers_url":"https://api.github.com/repos/mfojtik/sti-perl/stargazers","contributors_url":"https://api.github.com/repos/mfojtik/sti-perl/contributors","subscribers_url":"https://api.github.com/repos/mfojtik/sti-perl/subscribers","subscription_url":"https://api.github.com/repos/mfojtik/sti-perl/subscription","commits_url":"https://api.github.com/repos/mfojtik/sti-perl/commits{/sha}","git_commits_url":"https://api.github.com/repos/mfojtik/sti-perl/git/commits{/sha}","comments_url":"https://api.github.com/repos/mfojtik/sti-perl/comments{/number}","issue_comment_url":"https://api.github.com/repos/mfojtik/sti-perl/issues/comments{/number}","contents_url":"https://api.github.com/repos/mfojtik/sti-perl/contents/{+path}","compare_url":"https://api.github.com/repos/mfojtik/sti-perl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mfojtik/sti-perl/merges","archive_url":"https://api.github.com/repos/mfojtik/sti-perl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mfojtik/sti-perl/downloads","issues_url":"https://api.github.com/repos/mfojtik/sti-perl/issues{/number}","pulls_url":"https://api.github.com/repos/mfojtik/sti-perl/pulls{/number}","milestones_url":"https://api.github.com/repos/mfojtik/sti-perl/milestones{/number}","notifications_url":"https://api.github.com/repos/mfojtik/sti-perl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mfojtik/sti-perl/labels{/name}","releases_url":"https://api.github.com/repos/mfojtik/sti-perl/releases{/id}","created_at":"2015-05-06T08:43:11Z","updated_at":"2015-05-06T08:43:11Z","pushed_at":"2015-06-30T08:08:36Z","git_url":"git://github.com/mfojtik/sti-perl.git","ssh_url":"git@github.com:mfojtik/sti-perl.git","clone_url":"https://github.com/mfojtik/sti-perl.git","svn_url":"https://github.com/mfojtik/sti-perl","homepage":null,"size":178,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"5a2390c4d1f5fe336c58ba50eae61060faabc2ed","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":32732062,"name":"sti-perl","full_name":"openshift/sti-perl","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/sti-perl","description":"","fork":false,"url":"https://api.github.com/repos/openshift/sti-perl","forks_url":"https://api.github.com/repos/openshift/sti-perl/forks","keys_url":"https://api.github.com/repos/openshift/sti-perl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/sti-perl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/sti-perl/teams","hooks_url":"https://api.github.com/repos/openshift/sti-perl/hooks","issue_events_url":"https://api.github.com/repos/openshift/sti-perl/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/sti-perl/events","assignees_url":"https://api.github.com/repos/openshift/sti-perl/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/sti-perl/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/sti-perl/tags","blobs_url":"https://api.github.com/repos/openshift/sti-perl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/sti-perl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/sti-perl/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/sti-perl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/sti-perl/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/sti-perl/languages","stargazers_url":"https://api.github.com/repos/openshift/sti-perl/stargazers","contributors_url":"https://api.github.com/repos/openshift/sti-perl/contributors","subscribers_url":"https://api.github.com/repos/openshift/sti-perl/subscribers","subscription_url":"https://api.github.com/repos/openshift/sti-perl/subscription","commits_url":"https://api.github.com/repos/openshift/sti-perl/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/sti-perl/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/sti-perl/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/sti-perl/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/sti-perl/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/sti-perl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/sti-perl/merges","archive_url":"https://api.github.com/repos/openshift/sti-perl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/sti-perl/downloads","issues_url":"https://api.github.com/repos/openshift/sti-perl/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/sti-perl/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/sti-perl/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/sti-perl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/sti-perl/labels{/name}","releases_url":"https://api.github.com/repos/openshift/sti-perl/releases{/id}","created_at":"2015-03-23T12:53:15Z","updated_at":"2015-05-07T19:51:51Z","pushed_at":"2015-06-29T18:23:54Z","git_url":"git://github.com/openshift/sti-perl.git","ssh_url":"git@github.com:openshift/sti-perl.git","clone_url":"https://github.com/openshift/sti-perl.git","svn_url":"https://github.com/openshift/sti-perl","homepage":null,"size":393,"stargazers_count":1,"watchers_count":1,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":2,"forks":9,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/sti-perl/pulls/31"},"html":{"href":"https://github.com/openshift/sti-perl/pull/31"},"issue":{"href":"https://api.github.com/repos/openshift/sti-perl/issues/31"},"comments":{"href":"https://api.github.com/repos/openshift/sti-perl/issues/31/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/sti-perl/pulls/31/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/sti-perl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/sti-perl/pulls/31/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/sti-perl/statuses/853b9ee2ea23207bfabe8f1a05b1645ad15f659b"}}}}