{"action":"created","comment":{"url":"https://api.github.com/repos/vincentlab/PyFR/pulls/comments/47813109","id":47813109,"diff_hunk":"@@ -211,47 +211,87 @@ def _gen_pnorm_fpts(self):\n         self._norm_pnorm_fpts = pnorm_fpts / mag_pnorm_fpts[..., None]\n         self._mag_pnorm_fpts = mag_pnorm_fpts\n \n-    def _get_jac_eles_at(self, pts):\n-        nspts, neles, ndims = self.nspts, self.neles, self.ndims\n+    def _get_smats(self, pts, retdets=False):\n         npts = len(pts)\n \n-        # Form the Jacobian operator\n-        jacop = np.rollaxis(self.basis.sbasis.jac_nodal_basis_at(pts), 2)\n+        # Interpolation matrix to pts\n+        M0 = self.basis.mbasis.nodal_basis_at(pts)\n+\n+        # Interpolate smats\n+        smats = np.array([np.dot(M0, smat) for smat in self._smats])\n+        smats = smats.reshape(self.ndims, npts, self.ndims, -1)\n+\n+        # Interpolate djacs\n+        if retdets:\n+            djacs = np.dot(M0, self._djacs)\n+\n+        return (smats, djacs) if retdets else smats\n+\n+    def _ploc_at_pts_np(self, pts):\n+        op = self.basis.sbasis.nodal_basis_at(pts)\n+\n+        ploc = np.dot(op, self.eles.reshape(self.nspts, -1))\n+        ploc = ploc.reshape(-1, self.neles, self.ndims).swapaxes(1, 2)\n+\n+        return ploc\n+\n+    @lazyprop\n+    def _smats(self):","path":"pyfr/solvers/base/elements.py","position":33,"original_position":33,"commit_id":"02330649093d9199c4935a2a78e39e19e1f2cac2","original_commit_id":"02330649093d9199c4935a2a78e39e19e1f2cac2","user":{"login":"FreddieWitherden","id":528611,"avatar_url":"https://avatars.githubusercontent.com/u/528611?v=3","gravatar_id":"","url":"https://api.github.com/users/FreddieWitherden","html_url":"https://github.com/FreddieWitherden","followers_url":"https://api.github.com/users/FreddieWitherden/followers","following_url":"https://api.github.com/users/FreddieWitherden/following{/other_user}","gists_url":"https://api.github.com/users/FreddieWitherden/gists{/gist_id}","starred_url":"https://api.github.com/users/FreddieWitherden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FreddieWitherden/subscriptions","organizations_url":"https://api.github.com/users/FreddieWitherden/orgs","repos_url":"https://api.github.com/users/FreddieWitherden/repos","events_url":"https://api.github.com/users/FreddieWitherden/events{/privacy}","received_events_url":"https://api.github.com/users/FreddieWitherden/received_events","type":"User","site_admin":false},"body":"I'm good with `_smat_mpts`.","created_at":"2015-12-16T18:23:08Z","updated_at":"2015-12-16T18:23:08Z","html_url":"https://github.com/vincentlab/PyFR/pull/80#discussion_r47813109","pull_request_url":"https://api.github.com/repos/vincentlab/PyFR/pulls/80","_links":{"self":{"href":"https://api.github.com/repos/vincentlab/PyFR/pulls/comments/47813109"},"html":{"href":"https://github.com/vincentlab/PyFR/pull/80#discussion_r47813109"},"pull_request":{"href":"https://api.github.com/repos/vincentlab/PyFR/pulls/80"}}},"pull_request":{"url":"https://api.github.com/repos/vincentlab/PyFR/pulls/80","id":49169578,"html_url":"https://github.com/vincentlab/PyFR/pull/80","diff_url":"https://github.com/vincentlab/PyFR/pull/80.diff","patch_url":"https://github.com/vincentlab/PyFR/pull/80.patch","issue_url":"https://api.github.com/repos/vincentlab/PyFR/issues/80","number":80,"state":"open","locked":false,"title":"Implementation of free-stream metric.","user":{"login":"Aerojspark","id":8792917,"avatar_url":"https://avatars.githubusercontent.com/u/8792917?v=3","gravatar_id":"","url":"https://api.github.com/users/Aerojspark","html_url":"https://github.com/Aerojspark","followers_url":"https://api.github.com/users/Aerojspark/followers","following_url":"https://api.github.com/users/Aerojspark/following{/other_user}","gists_url":"https://api.github.com/users/Aerojspark/gists{/gist_id}","starred_url":"https://api.github.com/users/Aerojspark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aerojspark/subscriptions","organizations_url":"https://api.github.com/users/Aerojspark/orgs","repos_url":"https://api.github.com/users/Aerojspark/repos","events_url":"https://api.github.com/users/Aerojspark/events{/privacy}","received_events_url":"https://api.github.com/users/Aerojspark/received_events","type":"User","site_admin":false},"body":"I have implemented the free-stream metric, which satisfies the discrete metric identity.","created_at":"2015-10-29T17:05:25Z","updated_at":"2015-12-16T18:23:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d60b70221e131e02d882657030d52fc028f41201","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/vincentlab/PyFR/pulls/80/commits","review_comments_url":"https://api.github.com/repos/vincentlab/PyFR/pulls/80/comments","review_comment_url":"https://api.github.com/repos/vincentlab/PyFR/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vincentlab/PyFR/issues/80/comments","statuses_url":"https://api.github.com/repos/vincentlab/PyFR/statuses/02330649093d9199c4935a2a78e39e19e1f2cac2","head":{"label":"Aerojspark:develop","ref":"develop","sha":"02330649093d9199c4935a2a78e39e19e1f2cac2","user":{"login":"Aerojspark","id":8792917,"avatar_url":"https://avatars.githubusercontent.com/u/8792917?v=3","gravatar_id":"","url":"https://api.github.com/users/Aerojspark","html_url":"https://github.com/Aerojspark","followers_url":"https://api.github.com/users/Aerojspark/followers","following_url":"https://api.github.com/users/Aerojspark/following{/other_user}","gists_url":"https://api.github.com/users/Aerojspark/gists{/gist_id}","starred_url":"https://api.github.com/users/Aerojspark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aerojspark/subscriptions","organizations_url":"https://api.github.com/users/Aerojspark/orgs","repos_url":"https://api.github.com/users/Aerojspark/repos","events_url":"https://api.github.com/users/Aerojspark/events{/privacy}","received_events_url":"https://api.github.com/users/Aerojspark/received_events","type":"User","site_admin":false},"repo":{"id":24884060,"name":"PyFR","full_name":"Aerojspark/PyFR","owner":{"login":"Aerojspark","id":8792917,"avatar_url":"https://avatars.githubusercontent.com/u/8792917?v=3","gravatar_id":"","url":"https://api.github.com/users/Aerojspark","html_url":"https://github.com/Aerojspark","followers_url":"https://api.github.com/users/Aerojspark/followers","following_url":"https://api.github.com/users/Aerojspark/following{/other_user}","gists_url":"https://api.github.com/users/Aerojspark/gists{/gist_id}","starred_url":"https://api.github.com/users/Aerojspark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aerojspark/subscriptions","organizations_url":"https://api.github.com/users/Aerojspark/orgs","repos_url":"https://api.github.com/users/Aerojspark/repos","events_url":"https://api.github.com/users/Aerojspark/events{/privacy}","received_events_url":"https://api.github.com/users/Aerojspark/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Aerojspark/PyFR","description":"PyFR","fork":true,"url":"https://api.github.com/repos/Aerojspark/PyFR","forks_url":"https://api.github.com/repos/Aerojspark/PyFR/forks","keys_url":"https://api.github.com/repos/Aerojspark/PyFR/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Aerojspark/PyFR/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Aerojspark/PyFR/teams","hooks_url":"https://api.github.com/repos/Aerojspark/PyFR/hooks","issue_events_url":"https://api.github.com/repos/Aerojspark/PyFR/issues/events{/number}","events_url":"https://api.github.com/repos/Aerojspark/PyFR/events","assignees_url":"https://api.github.com/repos/Aerojspark/PyFR/assignees{/user}","branches_url":"https://api.github.com/repos/Aerojspark/PyFR/branches{/branch}","tags_url":"https://api.github.com/repos/Aerojspark/PyFR/tags","blobs_url":"https://api.github.com/repos/Aerojspark/PyFR/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Aerojspark/PyFR/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Aerojspark/PyFR/git/refs{/sha}","trees_url":"https://api.github.com/repos/Aerojspark/PyFR/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Aerojspark/PyFR/statuses/{sha}","languages_url":"https://api.github.com/repos/Aerojspark/PyFR/languages","stargazers_url":"https://api.github.com/repos/Aerojspark/PyFR/stargazers","contributors_url":"https://api.github.com/repos/Aerojspark/PyFR/contributors","subscribers_url":"https://api.github.com/repos/Aerojspark/PyFR/subscribers","subscription_url":"https://api.github.com/repos/Aerojspark/PyFR/subscription","commits_url":"https://api.github.com/repos/Aerojspark/PyFR/commits{/sha}","git_commits_url":"https://api.github.com/repos/Aerojspark/PyFR/git/commits{/sha}","comments_url":"https://api.github.com/repos/Aerojspark/PyFR/comments{/number}","issue_comment_url":"https://api.github.com/repos/Aerojspark/PyFR/issues/comments{/number}","contents_url":"https://api.github.com/repos/Aerojspark/PyFR/contents/{+path}","compare_url":"https://api.github.com/repos/Aerojspark/PyFR/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Aerojspark/PyFR/merges","archive_url":"https://api.github.com/repos/Aerojspark/PyFR/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Aerojspark/PyFR/downloads","issues_url":"https://api.github.com/repos/Aerojspark/PyFR/issues{/number}","pulls_url":"https://api.github.com/repos/Aerojspark/PyFR/pulls{/number}","milestones_url":"https://api.github.com/repos/Aerojspark/PyFR/milestones{/number}","notifications_url":"https://api.github.com/repos/Aerojspark/PyFR/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Aerojspark/PyFR/labels{/name}","releases_url":"https://api.github.com/repos/Aerojspark/PyFR/releases{/id}","created_at":"2014-10-07T09:22:28Z","updated_at":"2015-05-05T19:47:39Z","pushed_at":"2015-12-16T17:41:58Z","git_url":"git://github.com/Aerojspark/PyFR.git","ssh_url":"git@github.com:Aerojspark/PyFR.git","clone_url":"https://github.com/Aerojspark/PyFR.git","svn_url":"https://github.com/Aerojspark/PyFR","homepage":"","size":1731,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"vincentlab:develop","ref":"develop","sha":"db9e1b3eaf05d3d6e0f51623cdb87302ce3087c3","user":{"login":"vincentlab","id":3252468,"avatar_url":"https://avatars.githubusercontent.com/u/3252468?v=3","gravatar_id":"","url":"https://api.github.com/users/vincentlab","html_url":"https://github.com/vincentlab","followers_url":"https://api.github.com/users/vincentlab/followers","following_url":"https://api.github.com/users/vincentlab/following{/other_user}","gists_url":"https://api.github.com/users/vincentlab/gists{/gist_id}","starred_url":"https://api.github.com/users/vincentlab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vincentlab/subscriptions","organizations_url":"https://api.github.com/users/vincentlab/orgs","repos_url":"https://api.github.com/users/vincentlab/repos","events_url":"https://api.github.com/users/vincentlab/events{/privacy}","received_events_url":"https://api.github.com/users/vincentlab/received_events","type":"Organization","site_admin":false},"repo":{"id":7652671,"name":"PyFR","full_name":"vincentlab/PyFR","owner":{"login":"vincentlab","id":3252468,"avatar_url":"https://avatars.githubusercontent.com/u/3252468?v=3","gravatar_id":"","url":"https://api.github.com/users/vincentlab","html_url":"https://github.com/vincentlab","followers_url":"https://api.github.com/users/vincentlab/followers","following_url":"https://api.github.com/users/vincentlab/following{/other_user}","gists_url":"https://api.github.com/users/vincentlab/gists{/gist_id}","starred_url":"https://api.github.com/users/vincentlab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vincentlab/subscriptions","organizations_url":"https://api.github.com/users/vincentlab/orgs","repos_url":"https://api.github.com/users/vincentlab/repos","events_url":"https://api.github.com/users/vincentlab/events{/privacy}","received_events_url":"https://api.github.com/users/vincentlab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vincentlab/PyFR","description":"PyFR","fork":false,"url":"https://api.github.com/repos/vincentlab/PyFR","forks_url":"https://api.github.com/repos/vincentlab/PyFR/forks","keys_url":"https://api.github.com/repos/vincentlab/PyFR/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vincentlab/PyFR/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vincentlab/PyFR/teams","hooks_url":"https://api.github.com/repos/vincentlab/PyFR/hooks","issue_events_url":"https://api.github.com/repos/vincentlab/PyFR/issues/events{/number}","events_url":"https://api.github.com/repos/vincentlab/PyFR/events","assignees_url":"https://api.github.com/repos/vincentlab/PyFR/assignees{/user}","branches_url":"https://api.github.com/repos/vincentlab/PyFR/branches{/branch}","tags_url":"https://api.github.com/repos/vincentlab/PyFR/tags","blobs_url":"https://api.github.com/repos/vincentlab/PyFR/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vincentlab/PyFR/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vincentlab/PyFR/git/refs{/sha}","trees_url":"https://api.github.com/repos/vincentlab/PyFR/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vincentlab/PyFR/statuses/{sha}","languages_url":"https://api.github.com/repos/vincentlab/PyFR/languages","stargazers_url":"https://api.github.com/repos/vincentlab/PyFR/stargazers","contributors_url":"https://api.github.com/repos/vincentlab/PyFR/contributors","subscribers_url":"https://api.github.com/repos/vincentlab/PyFR/subscribers","subscription_url":"https://api.github.com/repos/vincentlab/PyFR/subscription","commits_url":"https://api.github.com/repos/vincentlab/PyFR/commits{/sha}","git_commits_url":"https://api.github.com/repos/vincentlab/PyFR/git/commits{/sha}","comments_url":"https://api.github.com/repos/vincentlab/PyFR/comments{/number}","issue_comment_url":"https://api.github.com/repos/vincentlab/PyFR/issues/comments{/number}","contents_url":"https://api.github.com/repos/vincentlab/PyFR/contents/{+path}","compare_url":"https://api.github.com/repos/vincentlab/PyFR/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vincentlab/PyFR/merges","archive_url":"https://api.github.com/repos/vincentlab/PyFR/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vincentlab/PyFR/downloads","issues_url":"https://api.github.com/repos/vincentlab/PyFR/issues{/number}","pulls_url":"https://api.github.com/repos/vincentlab/PyFR/pulls{/number}","milestones_url":"https://api.github.com/repos/vincentlab/PyFR/milestones{/number}","notifications_url":"https://api.github.com/repos/vincentlab/PyFR/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vincentlab/PyFR/labels{/name}","releases_url":"https://api.github.com/repos/vincentlab/PyFR/releases{/id}","created_at":"2013-01-16T19:53:24Z","updated_at":"2015-11-20T20:08:55Z","pushed_at":"2015-12-16T17:41:59Z","git_url":"git://github.com/vincentlab/PyFR.git","ssh_url":"git@github.com:vincentlab/PyFR.git","clone_url":"https://github.com/vincentlab/PyFR.git","svn_url":"https://github.com/vincentlab/PyFR","homepage":"","size":1859,"stargazers_count":38,"watchers_count":38,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":30,"mirror_url":null,"open_issues_count":5,"forks":30,"open_issues":5,"watchers":38,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/vincentlab/PyFR/pulls/80"},"html":{"href":"https://github.com/vincentlab/PyFR/pull/80"},"issue":{"href":"https://api.github.com/repos/vincentlab/PyFR/issues/80"},"comments":{"href":"https://api.github.com/repos/vincentlab/PyFR/issues/80/comments"},"review_comments":{"href":"https://api.github.com/repos/vincentlab/PyFR/pulls/80/comments"},"review_comment":{"href":"https://api.github.com/repos/vincentlab/PyFR/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vincentlab/PyFR/pulls/80/commits"},"statuses":{"href":"https://api.github.com/repos/vincentlab/PyFR/statuses/02330649093d9199c4935a2a78e39e19e1f2cac2"}}}}