{"action":"created","issue":{"url":"https://api.github.com/repos/SparkTC/systemml/issues/50","labels_url":"https://api.github.com/repos/SparkTC/systemml/issues/50/labels{/name}","comments_url":"https://api.github.com/repos/SparkTC/systemml/issues/50/comments","events_url":"https://api.github.com/repos/SparkTC/systemml/issues/50/events","html_url":"https://github.com/SparkTC/systemml/pull/50","id":110588117,"number":50,"title":"[SYSML-282] Outer binary comparison implementation","user":{"login":"asurve","id":13441665,"avatar_url":"https://avatars.githubusercontent.com/u/13441665?v=3","gravatar_id":"","url":"https://api.github.com/users/asurve","html_url":"https://github.com/asurve","followers_url":"https://api.github.com/users/asurve/followers","following_url":"https://api.github.com/users/asurve/following{/other_user}","gists_url":"https://api.github.com/users/asurve/gists{/gist_id}","starred_url":"https://api.github.com/users/asurve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asurve/subscriptions","organizations_url":"https://api.github.com/users/asurve/orgs","repos_url":"https://api.github.com/users/asurve/repos","events_url":"https://api.github.com/users/asurve/events{/privacy}","received_events_url":"https://api.github.com/users/asurve/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-10-09T05:08:44Z","updated_at":"2015-10-09T08:58:04Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/SparkTC/systemml/pulls/50","html_url":"https://github.com/SparkTC/systemml/pull/50","diff_url":"https://github.com/SparkTC/systemml/pull/50.diff","patch_url":"https://github.com/SparkTC/systemml/pull/50.patch"},"body":"- Implemented changes for matrix outer operation for following operators\r\n   <, <=, >, >=, == and !="},"comment":{"url":"https://api.github.com/repos/SparkTC/systemml/issues/comments/146805821","html_url":"https://github.com/SparkTC/systemml/pull/50#issuecomment-146805821","issue_url":"https://api.github.com/repos/SparkTC/systemml/issues/50","id":146805821,"user":{"login":"mboehm7","id":13721609,"avatar_url":"https://avatars.githubusercontent.com/u/13721609?v=3","gravatar_id":"","url":"https://api.github.com/users/mboehm7","html_url":"https://github.com/mboehm7","followers_url":"https://api.github.com/users/mboehm7/followers","following_url":"https://api.github.com/users/mboehm7/following{/other_user}","gists_url":"https://api.github.com/users/mboehm7/gists{/gist_id}","starred_url":"https://api.github.com/users/mboehm7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mboehm7/subscriptions","organizations_url":"https://api.github.com/users/mboehm7/orgs","repos_url":"https://api.github.com/users/mboehm7/repos","events_url":"https://api.github.com/users/mboehm7/events{/privacy}","received_events_url":"https://api.github.com/users/mboehm7/received_events","type":"User","site_admin":false},"created_at":"2015-10-09T08:58:04Z","updated_at":"2015-10-09T08:58:04Z","body":"1) Correctness NNZ: Due to the custom array fill w/ 1s you need to explicitly maintain the number of non-zeros.\r\n2) Correctness sparse data: The method isSorted is incorrect in case of sparse input data; please use DataConverter.convertToDoubleVector to make this independent of the sparse/dense representation.\r\n3) Check for isSorted: We have already a check for isSorted in SortUtils but for int arrays. Please add a similar method for double values and just call this util function.\r\n4) Dense output allocation: Please think about alternative preprocessing steps to figure out dense/sparse output allocation - in case of actually sparse output data, the dense allocation will unnecessarily dominate the runtime."}}