{"action":"created","issue":{"url":"https://api.github.com/repos/google/flatbuffers/issues/1208","labels_url":"https://api.github.com/repos/google/flatbuffers/issues/1208/labels{/name}","comments_url":"https://api.github.com/repos/google/flatbuffers/issues/1208/comments","events_url":"https://api.github.com/repos/google/flatbuffers/issues/1208/events","html_url":"https://github.com/google/flatbuffers/pull/1208","id":120912778,"number":1208,"title":"Improved Java/C# FlatBufferBuilder's 'required' assert message","user":{"login":"evolutional","id":2247662,"avatar_url":"https://avatars.githubusercontent.com/u/2247662?v=3","gravatar_id":"","url":"https://api.github.com/users/evolutional","html_url":"https://github.com/evolutional","followers_url":"https://api.github.com/users/evolutional/followers","following_url":"https://api.github.com/users/evolutional/following{/other_user}","gists_url":"https://api.github.com/users/evolutional/gists{/gist_id}","starred_url":"https://api.github.com/users/evolutional/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evolutional/subscriptions","organizations_url":"https://api.github.com/users/evolutional/orgs","repos_url":"https://api.github.com/users/evolutional/repos","events_url":"https://api.github.com/users/evolutional/events{/privacy}","received_events_url":"https://api.github.com/users/evolutional/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-12-08T01:56:16Z","updated_at":"2015-12-09T21:14:59Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/google/flatbuffers/pulls/1208","html_url":"https://github.com/google/flatbuffers/pull/1208","diff_url":"https://github.com/google/flatbuffers/pull/1208.diff","patch_url":"https://github.com/google/flatbuffers/pull/1208.patch"},"body":"Improved Java/C# FlatBufferBuilder's 'required' method assert message by including the field name as a parameter.\r\n\r\nTested with Java/C# on Windows"},"comment":{"url":"https://api.github.com/repos/google/flatbuffers/issues/comments/163393745","html_url":"https://github.com/google/flatbuffers/pull/1208#issuecomment-163393745","issue_url":"https://api.github.com/repos/google/flatbuffers/issues/1208","id":163393745,"user":{"login":"gwvo","id":6145400,"avatar_url":"https://avatars.githubusercontent.com/u/6145400?v=3","gravatar_id":"","url":"https://api.github.com/users/gwvo","html_url":"https://github.com/gwvo","followers_url":"https://api.github.com/users/gwvo/followers","following_url":"https://api.github.com/users/gwvo/following{/other_user}","gists_url":"https://api.github.com/users/gwvo/gists{/gist_id}","starred_url":"https://api.github.com/users/gwvo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gwvo/subscriptions","organizations_url":"https://api.github.com/users/gwvo/orgs","repos_url":"https://api.github.com/users/gwvo/repos","events_url":"https://api.github.com/users/gwvo/events{/privacy}","received_events_url":"https://api.github.com/users/gwvo/received_events","type":"User","site_admin":false},"created_at":"2015-12-09T21:14:59Z","updated_at":"2015-12-09T21:14:59Z","body":"Nice improvement, but one issue: what is the efficiency of passing strings like that in Java in particular?\r\n\r\nJava does string pooling, but the way it appears to do that is to call `String.intern()`, meaning it would first have to construct a `String` object for that constant before it finds out it can be shared.\r\n\r\nIf this code causes any allocation, then I think we shouldn't merge it?\r\n\r\nhttp://stackoverflow.com/questions/3297867/difference-between-string-object-and-string-literal"}}