{"action":"created","issue":{"url":"https://api.github.com/repos/ansible/ansible-modules-extras/issues/788","labels_url":"https://api.github.com/repos/ansible/ansible-modules-extras/issues/788/labels{/name}","comments_url":"https://api.github.com/repos/ansible/ansible-modules-extras/issues/788/comments","events_url":"https://api.github.com/repos/ansible/ansible-modules-extras/issues/788/events","html_url":"https://github.com/ansible/ansible-modules-extras/pull/788","id":98095053,"number":788,"title":"Port vsphere_copy from httplib to open_url for TLS cert validation","user":{"login":"abadger","id":209242,"avatar_url":"https://avatars.githubusercontent.com/u/209242?v=3","gravatar_id":"","url":"https://api.github.com/users/abadger","html_url":"https://github.com/abadger","followers_url":"https://api.github.com/users/abadger/followers","following_url":"https://api.github.com/users/abadger/following{/other_user}","gists_url":"https://api.github.com/users/abadger/gists{/gist_id}","starred_url":"https://api.github.com/users/abadger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abadger/subscriptions","organizations_url":"https://api.github.com/users/abadger/orgs","repos_url":"https://api.github.com/users/abadger/repos","events_url":"https://api.github.com/users/abadger/events{/privacy}","received_events_url":"https://api.github.com/users/abadger/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ansible/ansible-modules-extras/labels/bugfix_pull_request","name":"bugfix_pull_request","color":"ded270"},{"url":"https://api.github.com/repos/ansible/ansible-modules-extras/labels/community_review","name":"community_review","color":"eb6420"},{"url":"https://api.github.com/repos/ansible/ansible-modules-extras/labels/P1","name":"P1","color":"f7c6c7"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-07-30T06:16:48Z","updated_at":"2015-07-30T20:58:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ansible/ansible-modules-extras/pulls/788","html_url":"https://github.com/ansible/ansible-modules-extras/pull/788","diff_url":"https://github.com/ansible/ansible-modules-extras/pull/788.diff","patch_url":"https://github.com/ansible/ansible-modules-extras/pull/788.patch"},"body":"vsphere_copy was using raw httplib which does not verify the server's SSL certificate. Ported to ansible's open_url() which does certificate checking.\r\n\r\n@dagwieers - I don't use vsphere so if you are able to review this and verify that it still works, that would be greatly appreciated. Since this change will prevent man-in-the-middle attacks I will merge this even if you don't get back to me but I would vastly prefer you (or someone else using vsphere_copy) take a look to make sure this works."},"comment":{"url":"https://api.github.com/repos/ansible/ansible-modules-extras/issues/comments/126485504","html_url":"https://github.com/ansible/ansible-modules-extras/pull/788#issuecomment-126485504","issue_url":"https://api.github.com/repos/ansible/ansible-modules-extras/issues/788","id":126485504,"user":{"login":"abadger","id":209242,"avatar_url":"https://avatars.githubusercontent.com/u/209242?v=3","gravatar_id":"","url":"https://api.github.com/users/abadger","html_url":"https://github.com/abadger","followers_url":"https://api.github.com/users/abadger/followers","following_url":"https://api.github.com/users/abadger/following{/other_user}","gists_url":"https://api.github.com/users/abadger/gists{/gist_id}","starred_url":"https://api.github.com/users/abadger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abadger/subscriptions","organizations_url":"https://api.github.com/users/abadger/orgs","repos_url":"https://api.github.com/users/abadger/repos","events_url":"https://api.github.com/users/abadger/events{/privacy}","received_events_url":"https://api.github.com/users/abadger/received_events","type":"User","site_admin":false},"created_at":"2015-07-30T20:58:49Z","updated_at":"2015-07-30T20:58:49Z","body":"Fixed the status conditional.  About the naming of the status variable... I was just following the existing code there... The existing code uses a field called status in the return value.  If there's a socket error, the status is the erno otherwise it's the http status code.  I can rename the variable but it seems like the return value is the bigger problem as that's visible from user's playbooks.  Since this hasn't gone out in a released ansible yet, perhaps we want to change the name of that as well?"}}