{"action":"created","issue":{"url":"https://api.github.com/repos/pithu/js-joda/issues/2","labels_url":"https://api.github.com/repos/pithu/js-joda/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/pithu/js-joda/issues/2/comments","events_url":"https://api.github.com/repos/pithu/js-joda/issues/2/events","html_url":"https://github.com/pithu/js-joda/pull/2","id":123892138,"number":2,"title":"LocalDate.minusDays() implementation and test enhancements","user":{"login":"phueper","id":113417,"avatar_url":"https://avatars.githubusercontent.com/u/113417?v=3","gravatar_id":"","url":"https://api.github.com/users/phueper","html_url":"https://github.com/phueper","followers_url":"https://api.github.com/users/phueper/followers","following_url":"https://api.github.com/users/phueper/following{/other_user}","gists_url":"https://api.github.com/users/phueper/gists{/gist_id}","starred_url":"https://api.github.com/users/phueper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phueper/subscriptions","organizations_url":"https://api.github.com/users/phueper/orgs","repos_url":"https://api.github.com/users/phueper/repos","events_url":"https://api.github.com/users/phueper/events{/privacy}","received_events_url":"https://api.github.com/users/phueper/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-12-25T17:47:17Z","updated_at":"2015-12-26T11:24:29Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/pithu/js-joda/pulls/2","html_url":"https://github.com/pithu/js-joda/pull/2","diff_url":"https://github.com/pithu/js-joda/pull/2.diff","patch_url":"https://github.com/pithu/js-joda/pull/2.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/pithu/js-joda/issues/comments/167317643","html_url":"https://github.com/pithu/js-joda/pull/2#issuecomment-167317643","issue_url":"https://api.github.com/repos/pithu/js-joda/issues/2","id":167317643,"user":{"login":"pithu","id":1837621,"avatar_url":"https://avatars.githubusercontent.com/u/1837621?v=3","gravatar_id":"","url":"https://api.github.com/users/pithu","html_url":"https://github.com/pithu","followers_url":"https://api.github.com/users/pithu/followers","following_url":"https://api.github.com/users/pithu/following{/other_user}","gists_url":"https://api.github.com/users/pithu/gists{/gist_id}","starred_url":"https://api.github.com/users/pithu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pithu/subscriptions","organizations_url":"https://api.github.com/users/pithu/orgs","repos_url":"https://api.github.com/users/pithu/repos","events_url":"https://api.github.com/users/pithu/events{/privacy}","received_events_url":"https://api.github.com/users/pithu/received_events","type":"User","site_admin":false},"created_at":"2015-12-26T11:24:29Z","updated_at":"2015-12-26T11:24:29Z","body":"contributions, yes great !!!! thx a lot patty !\r\n\r\nbut puh, so many different apsects in one pull request.\r\n\r\n1) minusDays\r\nmy idea is to stay as close as possible to the openjdk 8 implementation (JSR310) for mainly two reason:\r\n- if you know the JSR310 API you should feel comfortable with js-joda API\r\n- minimize unexpected bugs or missbehaviour\r\nAt http://hg.openjdk.java.net/jdk8/jdk8/jdk/file/687fd7c7986d/src/share/classes/java/time/LocalDate.java#l1486, they made it a bit different. Do you know why ? Do we need that?\r\n\r\n2) minusDays tests\r\nDo we really need this bunch of tests ? I would like to add only really necessary tests. \r\nI am not really happy with the tests right now. I would like to just reuse the jdk tests or at least use the same test cases. Did you had a look on that ?\r\n\r\n3 ) node 10\r\nusing node 10 was by purpose. Why not being downward compatible to an older node version? Will be there anything special we will need of the node 4 features. (i hope not ;) )\r\n\r\n4) Phantom vs Firefox\r\ni am unsure with this point. Since travis is doing the job, we could even add both browser to the test job. But is this really necessary. Since we are independent from any Dom feature, and using babel to transpile es5 code out of the es6 code, i do not really expect any issues here. \r\n\r\nBut on the other side, me, as a developer want to run all travis tests before pushing to the main line. So i would have to install phantomjs locally. And, sorry, i had so much trouble with phantomjs ... \r\nBut the same might go for Firefox. Not every developer like this browser and is not willing to install it locally\r\n\r\nHey patty, can you split the pull request it separate peaces, so we can discuss/ merge it separately.\r\n\r\nEspecially at the beginning of this project its quite important to find the right vision and philosophy for the right pass for this project.\r\n\r\nP.S. and whats about Christmas ???   ;)"}}