{"action":"created","issue":{"url":"https://api.github.com/repos/jMonkeyEngine/jmonkeyengine/issues/218","labels_url":"https://api.github.com/repos/jMonkeyEngine/jmonkeyengine/issues/218/labels{/name}","comments_url":"https://api.github.com/repos/jMonkeyEngine/jmonkeyengine/issues/218/comments","events_url":"https://api.github.com/repos/jMonkeyEngine/jmonkeyengine/issues/218/events","html_url":"https://github.com/jMonkeyEngine/jmonkeyengine/pull/218","id":59210547,"number":218,"title":"Fix shadow disappearing for Spot and Point Lights","user":{"login":"Bebul","id":9265147,"avatar_url":"https://avatars.githubusercontent.com/u/9265147?v=3","gravatar_id":"","url":"https://api.github.com/users/Bebul","html_url":"https://github.com/Bebul","followers_url":"https://api.github.com/users/Bebul/followers","following_url":"https://api.github.com/users/Bebul/following{/other_user}","gists_url":"https://api.github.com/users/Bebul/gists{/gist_id}","starred_url":"https://api.github.com/users/Bebul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bebul/subscriptions","organizations_url":"https://api.github.com/users/Bebul/orgs","repos_url":"https://api.github.com/users/Bebul/repos","events_url":"https://api.github.com/users/Bebul/events{/privacy}","received_events_url":"https://api.github.com/users/Bebul/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":14,"created_at":"2015-02-27T09:30:03Z","updated_at":"2015-07-14T06:50:47Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jMonkeyEngine/jmonkeyengine/pulls/218","html_url":"https://github.com/jMonkeyEngine/jmonkeyengine/pull/218","diff_url":"https://github.com/jMonkeyEngine/jmonkeyengine/pull/218.diff","patch_url":"https://github.com/jMonkeyEngine/jmonkeyengine/pull/218.patch"},"body":"After **Light culling** implementation there is a problem with shadow disappearing for `SpotLight` and `PointLight`. As documented in worthy @Nehon article: [3.1 Sneak peek : Light culling and Single pass lighting](http://jmonkeyengine.org/298849/3-1-sneak-peek-light-culling-and-single-pass-lighting/)\r\n> **Noteworthy**\r\n> Shadows now also use light culling. This means that shadow maps won’t be calculated for lights that are outside of the frustum. This can give a huge performance boost.\r\n\r\nThe shadow disappears when shadow caster geometry is inside light cone which does not reach the camera view frustum but its shadow is casted into the view. It happens very easy. Just make the shadow long enough and move the camera.\r\nIt is because the light radius (or range) is short enough not to reach the view frustum but the caster is close enough, so the shadow is casted.\r\n\r\nProposed fix in this pull request is conservative. It allows to cull shadows less aggressively through new `PointLight` or `SpotLight` setting public method `setShowCulledLightssShadows(boolean)` while default is the old behaviour."},"comment":{"url":"https://api.github.com/repos/jMonkeyEngine/jmonkeyengine/issues/comments/121146894","html_url":"https://github.com/jMonkeyEngine/jmonkeyengine/pull/218#issuecomment-121146894","issue_url":"https://api.github.com/repos/jMonkeyEngine/jmonkeyengine/issues/218","id":121146894,"user":{"login":"Nehon","id":3286588,"avatar_url":"https://avatars.githubusercontent.com/u/3286588?v=3","gravatar_id":"","url":"https://api.github.com/users/Nehon","html_url":"https://github.com/Nehon","followers_url":"https://api.github.com/users/Nehon/followers","following_url":"https://api.github.com/users/Nehon/following{/other_user}","gists_url":"https://api.github.com/users/Nehon/gists{/gist_id}","starred_url":"https://api.github.com/users/Nehon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nehon/subscriptions","organizations_url":"https://api.github.com/users/Nehon/orgs","repos_url":"https://api.github.com/users/Nehon/repos","events_url":"https://api.github.com/users/Nehon/events{/privacy}","received_events_url":"https://api.github.com/users/Nehon/received_events","type":"User","site_admin":false},"created_at":"2015-07-14T06:50:47Z","updated_at":"2015-07-14T06:50:47Z","body":"tbh this slipped my mind.\r\ngonna look into it"}}