{"action":"created","comment":{"url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/comments/35091737","id":35091737,"diff_hunk":"@@ -85,6 +95,24 @@ uint64_t tegra_sip_handler(uint32_t smc_fid,\n \n \t\tSMC_RET1(handle, 0);\n \n+\tcase TEGRA_SIP_AARCH_SWITCH:","path":"plat/nvidia/tegra/common/tegra_sip_calls.c","position":29,"original_position":29,"commit_id":"e6d986d97fb54a6c3961c9405f848ad7b50709a7","original_commit_id":"e6d986d97fb54a6c3961c9405f848ad7b50709a7","user":{"login":"athoelke","id":5690199,"avatar_url":"https://avatars.githubusercontent.com/u/5690199?v=3","gravatar_id":"","url":"https://api.github.com/users/athoelke","html_url":"https://github.com/athoelke","followers_url":"https://api.github.com/users/athoelke/followers","following_url":"https://api.github.com/users/athoelke/following{/other_user}","gists_url":"https://api.github.com/users/athoelke/gists{/gist_id}","starred_url":"https://api.github.com/users/athoelke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/athoelke/subscriptions","organizations_url":"https://api.github.com/users/athoelke/orgs","repos_url":"https://api.github.com/users/athoelke/repos","events_url":"https://api.github.com/users/athoelke/events{/privacy}","received_events_url":"https://api.github.com/users/athoelke/received_events","type":"User","site_admin":false},"body":"This is a SMC32 call - based on the smc_fid value. Thus you should clean the high bits of the x1/x2 parameters\r\n`x1 = (uint32_t)x1;`\r\netc. before using them. In the case that a call came from AArch32, it is not guaranteed that the high bits are zero, which this code appears to depend on.\r\n\r\nI notice that this also affects the VIDEOMEM_REGION function, but I can't add a comment there in this commit diff.\r\n\r\n I presume you already realise that these two SIP service calls cannot be passed addresses above 4GB as they are 32-bit functions.","created_at":"2015-07-21T11:17:23Z","updated_at":"2015-07-21T11:17:23Z","html_url":"https://github.com/ARM-software/arm-trusted-firmware/pull/339#discussion_r35091737","pull_request_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/339","_links":{"self":{"href":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/comments/35091737"},"html":{"href":"https://github.com/ARM-software/arm-trusted-firmware/pull/339#discussion_r35091737"},"pull_request":{"href":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/339"}}},"pull_request":{"url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/339","id":40422611,"html_url":"https://github.com/ARM-software/arm-trusted-firmware/pull/339","diff_url":"https://github.com/ARM-software/arm-trusted-firmware/pull/339.diff","patch_url":"https://github.com/ARM-software/arm-trusted-firmware/pull/339.patch","issue_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/issues/339","number":339,"state":"open","locked":false,"title":"Tegra denver plat support v1","user":{"login":"vwadekar","id":3041253,"avatar_url":"https://avatars.githubusercontent.com/u/3041253?v=3","gravatar_id":"","url":"https://api.github.com/users/vwadekar","html_url":"https://github.com/vwadekar","followers_url":"https://api.github.com/users/vwadekar/followers","following_url":"https://api.github.com/users/vwadekar/following{/other_user}","gists_url":"https://api.github.com/users/vwadekar/gists{/gist_id}","starred_url":"https://api.github.com/users/vwadekar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vwadekar/subscriptions","organizations_url":"https://api.github.com/users/vwadekar/orgs","repos_url":"https://api.github.com/users/vwadekar/repos","events_url":"https://api.github.com/users/vwadekar/events{/privacy}","received_events_url":"https://api.github.com/users/vwadekar/received_events","type":"User","site_admin":false},"body":"Support for Tegra's \"Project Denver\" CPU platforms","created_at":"2015-07-21T04:56:16Z","updated_at":"2015-07-21T11:17:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"309e89efffe6bc98b82d3585377773ed2d4449be","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/339/commits","review_comments_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/339/comments","review_comment_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/issues/339/comments","statuses_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/statuses/e6d986d97fb54a6c3961c9405f848ad7b50709a7","head":{"label":"vwadekar:tegra-denver-plat-support-v1","ref":"tegra-denver-plat-support-v1","sha":"e6d986d97fb54a6c3961c9405f848ad7b50709a7","user":{"login":"vwadekar","id":3041253,"avatar_url":"https://avatars.githubusercontent.com/u/3041253?v=3","gravatar_id":"","url":"https://api.github.com/users/vwadekar","html_url":"https://github.com/vwadekar","followers_url":"https://api.github.com/users/vwadekar/followers","following_url":"https://api.github.com/users/vwadekar/following{/other_user}","gists_url":"https://api.github.com/users/vwadekar/gists{/gist_id}","starred_url":"https://api.github.com/users/vwadekar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vwadekar/subscriptions","organizations_url":"https://api.github.com/users/vwadekar/orgs","repos_url":"https://api.github.com/users/vwadekar/repos","events_url":"https://api.github.com/users/vwadekar/events{/privacy}","received_events_url":"https://api.github.com/users/vwadekar/received_events","type":"User","site_admin":false},"repo":{"id":32440903,"name":"arm-trusted-firmware","full_name":"vwadekar/arm-trusted-firmware","owner":{"login":"vwadekar","id":3041253,"avatar_url":"https://avatars.githubusercontent.com/u/3041253?v=3","gravatar_id":"","url":"https://api.github.com/users/vwadekar","html_url":"https://github.com/vwadekar","followers_url":"https://api.github.com/users/vwadekar/followers","following_url":"https://api.github.com/users/vwadekar/following{/other_user}","gists_url":"https://api.github.com/users/vwadekar/gists{/gist_id}","starred_url":"https://api.github.com/users/vwadekar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vwadekar/subscriptions","organizations_url":"https://api.github.com/users/vwadekar/orgs","repos_url":"https://api.github.com/users/vwadekar/repos","events_url":"https://api.github.com/users/vwadekar/events{/privacy}","received_events_url":"https://api.github.com/users/vwadekar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vwadekar/arm-trusted-firmware","description":"NVIDIA's fork of the ARM Trusted Firmware","fork":true,"url":"https://api.github.com/repos/vwadekar/arm-trusted-firmware","forks_url":"https://api.github.com/repos/vwadekar/arm-trusted-firmware/forks","keys_url":"https://api.github.com/repos/vwadekar/arm-trusted-firmware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vwadekar/arm-trusted-firmware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vwadekar/arm-trusted-firmware/teams","hooks_url":"https://api.github.com/repos/vwadekar/arm-trusted-firmware/hooks","issue_events_url":"https://api.github.com/repos/vwadekar/arm-trusted-firmware/issues/events{/number}","events_url":"https://api.github.com/repos/vwadekar/arm-trusted-firmware/events","assignees_url":"https://api.github.com/repos/vwadekar/arm-trusted-firmware/assignees{/user}","branches_url":"https://api.github.com/repos/vwadekar/arm-trusted-firmware/branches{/branch}","tags_url":"https://api.github.com/repos/vwadekar/arm-trusted-firmware/tags","blobs_url":"https://api.github.com/repos/vwadekar/arm-trusted-firmware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vwadekar/arm-trusted-firmware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vwadekar/arm-trusted-firmware/git/refs{/sha}","trees_url":"https://api.github.com/repos/vwadekar/arm-trusted-firmware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vwadekar/arm-trusted-firmware/statuses/{sha}","languages_url":"https://api.github.com/repos/vwadekar/arm-trusted-firmware/languages","stargazers_url":"https://api.github.com/repos/vwadekar/arm-trusted-firmware/stargazers","contributors_url":"https://api.github.com/repos/vwadekar/arm-trusted-firmware/contributors","subscribers_url":"https://api.github.com/repos/vwadekar/arm-trusted-firmware/subscribers","subscription_url":"https://api.github.com/repos/vwadekar/arm-trusted-firmware/subscription","commits_url":"https://api.github.com/repos/vwadekar/arm-trusted-firmware/commits{/sha}","git_commits_url":"https://api.github.com/repos/vwadekar/arm-trusted-firmware/git/commits{/sha}","comments_url":"https://api.github.com/repos/vwadekar/arm-trusted-firmware/comments{/number}","issue_comment_url":"https://api.github.com/repos/vwadekar/arm-trusted-firmware/issues/comments{/number}","contents_url":"https://api.github.com/repos/vwadekar/arm-trusted-firmware/contents/{+path}","compare_url":"https://api.github.com/repos/vwadekar/arm-trusted-firmware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vwadekar/arm-trusted-firmware/merges","archive_url":"https://api.github.com/repos/vwadekar/arm-trusted-firmware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vwadekar/arm-trusted-firmware/downloads","issues_url":"https://api.github.com/repos/vwadekar/arm-trusted-firmware/issues{/number}","pulls_url":"https://api.github.com/repos/vwadekar/arm-trusted-firmware/pulls{/number}","milestones_url":"https://api.github.com/repos/vwadekar/arm-trusted-firmware/milestones{/number}","notifications_url":"https://api.github.com/repos/vwadekar/arm-trusted-firmware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vwadekar/arm-trusted-firmware/labels{/name}","releases_url":"https://api.github.com/repos/vwadekar/arm-trusted-firmware/releases{/id}","created_at":"2015-03-18T06:01:21Z","updated_at":"2015-04-02T09:04:28Z","pushed_at":"2015-07-21T06:34:09Z","git_url":"git://github.com/vwadekar/arm-trusted-firmware.git","ssh_url":"git@github.com:vwadekar/arm-trusted-firmware.git","clone_url":"https://github.com/vwadekar/arm-trusted-firmware.git","svn_url":"https://github.com/vwadekar/arm-trusted-firmware","homepage":"","size":4050,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ARM-software:integration","ref":"integration","sha":"53d069c28c2738c3a4f59211fbc61323ec28208c","user":{"login":"ARM-software","id":5690313,"avatar_url":"https://avatars.githubusercontent.com/u/5690313?v=3","gravatar_id":"","url":"https://api.github.com/users/ARM-software","html_url":"https://github.com/ARM-software","followers_url":"https://api.github.com/users/ARM-software/followers","following_url":"https://api.github.com/users/ARM-software/following{/other_user}","gists_url":"https://api.github.com/users/ARM-software/gists{/gist_id}","starred_url":"https://api.github.com/users/ARM-software/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARM-software/subscriptions","organizations_url":"https://api.github.com/users/ARM-software/orgs","repos_url":"https://api.github.com/users/ARM-software/repos","events_url":"https://api.github.com/users/ARM-software/events{/privacy}","received_events_url":"https://api.github.com/users/ARM-software/received_events","type":"Organization","site_admin":false},"repo":{"id":13740589,"name":"arm-trusted-firmware","full_name":"ARM-software/arm-trusted-firmware","owner":{"login":"ARM-software","id":5690313,"avatar_url":"https://avatars.githubusercontent.com/u/5690313?v=3","gravatar_id":"","url":"https://api.github.com/users/ARM-software","html_url":"https://github.com/ARM-software","followers_url":"https://api.github.com/users/ARM-software/followers","following_url":"https://api.github.com/users/ARM-software/following{/other_user}","gists_url":"https://api.github.com/users/ARM-software/gists{/gist_id}","starred_url":"https://api.github.com/users/ARM-software/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARM-software/subscriptions","organizations_url":"https://api.github.com/users/ARM-software/orgs","repos_url":"https://api.github.com/users/ARM-software/repos","events_url":"https://api.github.com/users/ARM-software/events{/privacy}","received_events_url":"https://api.github.com/users/ARM-software/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ARM-software/arm-trusted-firmware","description":"ARM Trusted Firmware","fork":false,"url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware","forks_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/forks","keys_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/teams","hooks_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/hooks","issue_events_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/issues/events{/number}","events_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/events","assignees_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/assignees{/user}","branches_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/branches{/branch}","tags_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/tags","blobs_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/git/refs{/sha}","trees_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/statuses/{sha}","languages_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/languages","stargazers_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/stargazers","contributors_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/contributors","subscribers_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/subscribers","subscription_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/subscription","commits_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/commits{/sha}","git_commits_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/git/commits{/sha}","comments_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/comments{/number}","issue_comment_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/issues/comments{/number}","contents_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/contents/{+path}","compare_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/merges","archive_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/downloads","issues_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/issues{/number}","pulls_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls{/number}","milestones_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/milestones{/number}","notifications_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/labels{/name}","releases_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/releases{/id}","created_at":"2013-10-21T11:39:00Z","updated_at":"2015-07-21T02:36:08Z","pushed_at":"2015-07-21T07:44:45Z","git_url":"git://github.com/ARM-software/arm-trusted-firmware.git","ssh_url":"git@github.com:ARM-software/arm-trusted-firmware.git","clone_url":"https://github.com/ARM-software/arm-trusted-firmware.git","svn_url":"https://github.com/ARM-software/arm-trusted-firmware","homepage":null,"size":6770,"stargazers_count":88,"watchers_count":88,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":99,"mirror_url":null,"open_issues_count":4,"forks":99,"open_issues":4,"watchers":88,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/339"},"html":{"href":"https://github.com/ARM-software/arm-trusted-firmware/pull/339"},"issue":{"href":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/issues/339"},"comments":{"href":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/issues/339/comments"},"review_comments":{"href":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/339/comments"},"review_comment":{"href":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/339/commits"},"statuses":{"href":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/statuses/e6d986d97fb54a6c3961c9405f848ad7b50709a7"}}}}