{"action":"opened","number":912,"pull_request":{"url":"https://api.github.com/repos/FluidTYPO3/vhs/pulls/912","id":45485039,"html_url":"https://github.com/FluidTYPO3/vhs/pull/912","diff_url":"https://github.com/FluidTYPO3/vhs/pull/912.diff","patch_url":"https://github.com/FluidTYPO3/vhs/pull/912.patch","issue_url":"https://api.github.com/repos/FluidTYPO3/vhs/issues/912","number":912,"state":"open","locked":false,"title":"[TASK] Make Condition/Variable ViewHelpers static compilable","user":{"login":"mneuhaus","id":316605,"avatar_url":"https://avatars.githubusercontent.com/u/316605?v=3","gravatar_id":"","url":"https://api.github.com/users/mneuhaus","html_url":"https://github.com/mneuhaus","followers_url":"https://api.github.com/users/mneuhaus/followers","following_url":"https://api.github.com/users/mneuhaus/following{/other_user}","gists_url":"https://api.github.com/users/mneuhaus/gists{/gist_id}","starred_url":"https://api.github.com/users/mneuhaus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mneuhaus/subscriptions","organizations_url":"https://api.github.com/users/mneuhaus/orgs","repos_url":"https://api.github.com/users/mneuhaus/repos","events_url":"https://api.github.com/users/mneuhaus/events{/privacy}","received_events_url":"https://api.github.com/users/mneuhaus/received_events","type":"User","site_admin":false},"body":"many viewHelpers extending from AbstractConditionViewHelper\r\nstopped working since 7.3 because the AbstractConditionViewHelper\r\nis now compiled statically by default. Any ConditionViewHelper that\r\nimplements it's own render method without taking compiling into\r\naccount currently simple fail by showing their \"false/else\" result\r\nas soon as they are executed from cache. Non-cached execution\r\nstill works, which makes this problem a bit weird to catch.\r\nAside from fixing the ViewHelpers itself the Testcases are updated\r\nto verify, that the effected viewHelpers render/work the same in\r\ncached and uncached context.","created_at":"2015-09-19T21:53:32Z","updated_at":"2015-09-19T21:53:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/FluidTYPO3/vhs/pulls/912/commits","review_comments_url":"https://api.github.com/repos/FluidTYPO3/vhs/pulls/912/comments","review_comment_url":"https://api.github.com/repos/FluidTYPO3/vhs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FluidTYPO3/vhs/issues/912/comments","statuses_url":"https://api.github.com/repos/FluidTYPO3/vhs/statuses/92b6c594d94a3aa7a3eac75e445c664a3d86cfa6","head":{"label":"mneuhaus:conditions_variable","ref":"conditions_variable","sha":"92b6c594d94a3aa7a3eac75e445c664a3d86cfa6","user":{"login":"mneuhaus","id":316605,"avatar_url":"https://avatars.githubusercontent.com/u/316605?v=3","gravatar_id":"","url":"https://api.github.com/users/mneuhaus","html_url":"https://github.com/mneuhaus","followers_url":"https://api.github.com/users/mneuhaus/followers","following_url":"https://api.github.com/users/mneuhaus/following{/other_user}","gists_url":"https://api.github.com/users/mneuhaus/gists{/gist_id}","starred_url":"https://api.github.com/users/mneuhaus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mneuhaus/subscriptions","organizations_url":"https://api.github.com/users/mneuhaus/orgs","repos_url":"https://api.github.com/users/mneuhaus/repos","events_url":"https://api.github.com/users/mneuhaus/events{/privacy}","received_events_url":"https://api.github.com/users/mneuhaus/received_events","type":"User","site_admin":false},"repo":{"id":8179798,"name":"vhs","full_name":"mneuhaus/vhs","owner":{"login":"mneuhaus","id":316605,"avatar_url":"https://avatars.githubusercontent.com/u/316605?v=3","gravatar_id":"","url":"https://api.github.com/users/mneuhaus","html_url":"https://github.com/mneuhaus","followers_url":"https://api.github.com/users/mneuhaus/followers","following_url":"https://api.github.com/users/mneuhaus/following{/other_user}","gists_url":"https://api.github.com/users/mneuhaus/gists{/gist_id}","starred_url":"https://api.github.com/users/mneuhaus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mneuhaus/subscriptions","organizations_url":"https://api.github.com/users/mneuhaus/orgs","repos_url":"https://api.github.com/users/mneuhaus/repos","events_url":"https://api.github.com/users/mneuhaus/events{/privacy}","received_events_url":"https://api.github.com/users/mneuhaus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mneuhaus/vhs","description":"TYPO3 extension VHS: Fluid ViewHelpers","fork":true,"url":"https://api.github.com/repos/mneuhaus/vhs","forks_url":"https://api.github.com/repos/mneuhaus/vhs/forks","keys_url":"https://api.github.com/repos/mneuhaus/vhs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mneuhaus/vhs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mneuhaus/vhs/teams","hooks_url":"https://api.github.com/repos/mneuhaus/vhs/hooks","issue_events_url":"https://api.github.com/repos/mneuhaus/vhs/issues/events{/number}","events_url":"https://api.github.com/repos/mneuhaus/vhs/events","assignees_url":"https://api.github.com/repos/mneuhaus/vhs/assignees{/user}","branches_url":"https://api.github.com/repos/mneuhaus/vhs/branches{/branch}","tags_url":"https://api.github.com/repos/mneuhaus/vhs/tags","blobs_url":"https://api.github.com/repos/mneuhaus/vhs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mneuhaus/vhs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mneuhaus/vhs/git/refs{/sha}","trees_url":"https://api.github.com/repos/mneuhaus/vhs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mneuhaus/vhs/statuses/{sha}","languages_url":"https://api.github.com/repos/mneuhaus/vhs/languages","stargazers_url":"https://api.github.com/repos/mneuhaus/vhs/stargazers","contributors_url":"https://api.github.com/repos/mneuhaus/vhs/contributors","subscribers_url":"https://api.github.com/repos/mneuhaus/vhs/subscribers","subscription_url":"https://api.github.com/repos/mneuhaus/vhs/subscription","commits_url":"https://api.github.com/repos/mneuhaus/vhs/commits{/sha}","git_commits_url":"https://api.github.com/repos/mneuhaus/vhs/git/commits{/sha}","comments_url":"https://api.github.com/repos/mneuhaus/vhs/comments{/number}","issue_comment_url":"https://api.github.com/repos/mneuhaus/vhs/issues/comments{/number}","contents_url":"https://api.github.com/repos/mneuhaus/vhs/contents/{+path}","compare_url":"https://api.github.com/repos/mneuhaus/vhs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mneuhaus/vhs/merges","archive_url":"https://api.github.com/repos/mneuhaus/vhs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mneuhaus/vhs/downloads","issues_url":"https://api.github.com/repos/mneuhaus/vhs/issues{/number}","pulls_url":"https://api.github.com/repos/mneuhaus/vhs/pulls{/number}","milestones_url":"https://api.github.com/repos/mneuhaus/vhs/milestones{/number}","notifications_url":"https://api.github.com/repos/mneuhaus/vhs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mneuhaus/vhs/labels{/name}","releases_url":"https://api.github.com/repos/mneuhaus/vhs/releases{/id}","created_at":"2013-02-13T13:42:37Z","updated_at":"2015-07-28T21:55:06Z","pushed_at":"2015-09-19T21:53:26Z","git_url":"git://github.com/mneuhaus/vhs.git","ssh_url":"git@github.com:mneuhaus/vhs.git","clone_url":"https://github.com/mneuhaus/vhs.git","svn_url":"https://github.com/mneuhaus/vhs","homepage":null,"size":3942,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"development"}},"base":{"label":"FluidTYPO3:development","ref":"development","sha":"5d337d184276cebc57997c50010abdfdf8a7df94","user":{"login":"FluidTYPO3","id":3912401,"avatar_url":"https://avatars.githubusercontent.com/u/3912401?v=3","gravatar_id":"","url":"https://api.github.com/users/FluidTYPO3","html_url":"https://github.com/FluidTYPO3","followers_url":"https://api.github.com/users/FluidTYPO3/followers","following_url":"https://api.github.com/users/FluidTYPO3/following{/other_user}","gists_url":"https://api.github.com/users/FluidTYPO3/gists{/gist_id}","starred_url":"https://api.github.com/users/FluidTYPO3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FluidTYPO3/subscriptions","organizations_url":"https://api.github.com/users/FluidTYPO3/orgs","repos_url":"https://api.github.com/users/FluidTYPO3/repos","events_url":"https://api.github.com/users/FluidTYPO3/events{/privacy}","received_events_url":"https://api.github.com/users/FluidTYPO3/received_events","type":"Organization","site_admin":false},"repo":{"id":6505090,"name":"vhs","full_name":"FluidTYPO3/vhs","owner":{"login":"FluidTYPO3","id":3912401,"avatar_url":"https://avatars.githubusercontent.com/u/3912401?v=3","gravatar_id":"","url":"https://api.github.com/users/FluidTYPO3","html_url":"https://github.com/FluidTYPO3","followers_url":"https://api.github.com/users/FluidTYPO3/followers","following_url":"https://api.github.com/users/FluidTYPO3/following{/other_user}","gists_url":"https://api.github.com/users/FluidTYPO3/gists{/gist_id}","starred_url":"https://api.github.com/users/FluidTYPO3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FluidTYPO3/subscriptions","organizations_url":"https://api.github.com/users/FluidTYPO3/orgs","repos_url":"https://api.github.com/users/FluidTYPO3/repos","events_url":"https://api.github.com/users/FluidTYPO3/events{/privacy}","received_events_url":"https://api.github.com/users/FluidTYPO3/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FluidTYPO3/vhs","description":"TYPO3 extension VHS: Fluid ViewHelpers","fork":false,"url":"https://api.github.com/repos/FluidTYPO3/vhs","forks_url":"https://api.github.com/repos/FluidTYPO3/vhs/forks","keys_url":"https://api.github.com/repos/FluidTYPO3/vhs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FluidTYPO3/vhs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FluidTYPO3/vhs/teams","hooks_url":"https://api.github.com/repos/FluidTYPO3/vhs/hooks","issue_events_url":"https://api.github.com/repos/FluidTYPO3/vhs/issues/events{/number}","events_url":"https://api.github.com/repos/FluidTYPO3/vhs/events","assignees_url":"https://api.github.com/repos/FluidTYPO3/vhs/assignees{/user}","branches_url":"https://api.github.com/repos/FluidTYPO3/vhs/branches{/branch}","tags_url":"https://api.github.com/repos/FluidTYPO3/vhs/tags","blobs_url":"https://api.github.com/repos/FluidTYPO3/vhs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FluidTYPO3/vhs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FluidTYPO3/vhs/git/refs{/sha}","trees_url":"https://api.github.com/repos/FluidTYPO3/vhs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FluidTYPO3/vhs/statuses/{sha}","languages_url":"https://api.github.com/repos/FluidTYPO3/vhs/languages","stargazers_url":"https://api.github.com/repos/FluidTYPO3/vhs/stargazers","contributors_url":"https://api.github.com/repos/FluidTYPO3/vhs/contributors","subscribers_url":"https://api.github.com/repos/FluidTYPO3/vhs/subscribers","subscription_url":"https://api.github.com/repos/FluidTYPO3/vhs/subscription","commits_url":"https://api.github.com/repos/FluidTYPO3/vhs/commits{/sha}","git_commits_url":"https://api.github.com/repos/FluidTYPO3/vhs/git/commits{/sha}","comments_url":"https://api.github.com/repos/FluidTYPO3/vhs/comments{/number}","issue_comment_url":"https://api.github.com/repos/FluidTYPO3/vhs/issues/comments{/number}","contents_url":"https://api.github.com/repos/FluidTYPO3/vhs/contents/{+path}","compare_url":"https://api.github.com/repos/FluidTYPO3/vhs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FluidTYPO3/vhs/merges","archive_url":"https://api.github.com/repos/FluidTYPO3/vhs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FluidTYPO3/vhs/downloads","issues_url":"https://api.github.com/repos/FluidTYPO3/vhs/issues{/number}","pulls_url":"https://api.github.com/repos/FluidTYPO3/vhs/pulls{/number}","milestones_url":"https://api.github.com/repos/FluidTYPO3/vhs/milestones{/number}","notifications_url":"https://api.github.com/repos/FluidTYPO3/vhs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FluidTYPO3/vhs/labels{/name}","releases_url":"https://api.github.com/repos/FluidTYPO3/vhs/releases{/id}","created_at":"2012-11-02T11:19:14Z","updated_at":"2015-09-05T21:16:04Z","pushed_at":"2015-09-19T21:43:57Z","git_url":"git://github.com/FluidTYPO3/vhs.git","ssh_url":"git@github.com:FluidTYPO3/vhs.git","clone_url":"https://github.com/FluidTYPO3/vhs.git","svn_url":"https://github.com/FluidTYPO3/vhs","homepage":"http://fluidtypo3.org","size":14581,"stargazers_count":88,"watchers_count":88,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":107,"mirror_url":null,"open_issues_count":12,"forks":107,"open_issues":12,"watchers":88,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/FluidTYPO3/vhs/pulls/912"},"html":{"href":"https://github.com/FluidTYPO3/vhs/pull/912"},"issue":{"href":"https://api.github.com/repos/FluidTYPO3/vhs/issues/912"},"comments":{"href":"https://api.github.com/repos/FluidTYPO3/vhs/issues/912/comments"},"review_comments":{"href":"https://api.github.com/repos/FluidTYPO3/vhs/pulls/912/comments"},"review_comment":{"href":"https://api.github.com/repos/FluidTYPO3/vhs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FluidTYPO3/vhs/pulls/912/commits"},"statuses":{"href":"https://api.github.com/repos/FluidTYPO3/vhs/statuses/92b6c594d94a3aa7a3eac75e445c664a3d86cfa6"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":76,"deletions":16,"changed_files":4}}