{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/31516101","id":31516101,"diff_hunk":"@@ -0,0 +1,1523 @@\n+// Copyright (c) Microsoft. All rights reserved.\n+// Licensed under the MIT license. See LICENSE file in the project root for full license information.\n+\n+using System;\n+using System.Linq;\n+using Xunit;\n+\n+namespace Test\n+{\n+    [Trait(\"category\", \"outerloop\")]\n+    public partial class ParallelQueryCombinationTests\n+    {\n+        [Theory]\n+        [MemberData(\"UnaryOperators\")]\n+        [MemberData(\"BinaryOperators\")]\n+        public static void Aggregate(LabelledOperation source, LabelledOperation operation)\n+        {\n+            Assert.Equal(Functions.SumRange(defaultStart, defaultSize),\n+                operation.Item(defaultStart, defaultSize, source.Item).Aggregate((x, y) => x + y));\n+        }\n+\n+        [Theory]\n+        [MemberData(\"UnaryOperators\")]\n+        [MemberData(\"BinaryOperators\")]\n+        public static void Aggregate_Seed(LabelledOperation source, LabelledOperation operation)\n+        {\n+            Assert.Equal(Functions.SumRange(defaultStart, defaultSize),\n+                operation.Item(defaultStart, defaultSize, source.Item).Aggregate(0, (x, y) => x + y));\n+        }\n+\n+        [Theory]\n+        [MemberData(\"UnaryOperators\")]\n+        [MemberData(\"BinaryOperators\")]\n+        public static void Aggregate_Result(LabelledOperation source, LabelledOperation operation)\n+        {\n+            Assert.Equal(Functions.SumRange(defaultStart, defaultSize) + 17,","path":"src/System.Linq.Parallel/tests/Combinatorial/ParallelQueryCombinationTests.cs","position":36,"original_position":36,"commit_id":"264ed5cbfff5f021379ef63d6aa8a5262d3d2f94","original_commit_id":"264ed5cbfff5f021379ef63d6aa8a5262d3d2f94","user":{"login":"Clockwork-Muse","id":5569508,"avatar_url":"https://avatars.githubusercontent.com/u/5569508?v=3","gravatar_id":"","url":"https://api.github.com/users/Clockwork-Muse","html_url":"https://github.com/Clockwork-Muse","followers_url":"https://api.github.com/users/Clockwork-Muse/followers","following_url":"https://api.github.com/users/Clockwork-Muse/following{/other_user}","gists_url":"https://api.github.com/users/Clockwork-Muse/gists{/gist_id}","starred_url":"https://api.github.com/users/Clockwork-Muse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Clockwork-Muse/subscriptions","organizations_url":"https://api.github.com/users/Clockwork-Muse/orgs","repos_url":"https://api.github.com/users/Clockwork-Muse/repos","events_url":"https://api.github.com/users/Clockwork-Muse/events{/privacy}","received_events_url":"https://api.github.com/users/Clockwork-Muse/received_events","type":"User","site_admin":false},"body":"Arbitrary.  I've moved it to the stand-alone Aggregate tests, as it fits there better.","created_at":"2015-06-02T12:20:30Z","updated_at":"2015-06-02T12:20:30Z","html_url":"https://github.com/dotnet/corefx/pull/1599#discussion_r31516101","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/1599","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/31516101"},"html":{"href":"https://github.com/dotnet/corefx/pull/1599#discussion_r31516101"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/1599"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/1599","id":34511724,"html_url":"https://github.com/dotnet/corefx/pull/1599","diff_url":"https://github.com/dotnet/corefx/pull/1599.diff","patch_url":"https://github.com/dotnet/corefx/pull/1599.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/1599","number":1599,"state":"open","locked":false,"title":"System.Linq.Parallel Test - initial cleanup","user":{"login":"Clockwork-Muse","id":5569508,"avatar_url":"https://avatars.githubusercontent.com/u/5569508?v=3","gravatar_id":"","url":"https://api.github.com/users/Clockwork-Muse","html_url":"https://github.com/Clockwork-Muse","followers_url":"https://api.github.com/users/Clockwork-Muse/followers","following_url":"https://api.github.com/users/Clockwork-Muse/following{/other_user}","gists_url":"https://api.github.com/users/Clockwork-Muse/gists{/gist_id}","starred_url":"https://api.github.com/users/Clockwork-Muse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Clockwork-Muse/subscriptions","organizations_url":"https://api.github.com/users/Clockwork-Muse/orgs","repos_url":"https://api.github.com/users/Clockwork-Muse/repos","events_url":"https://api.github.com/users/Clockwork-Muse/events{/privacy}","received_events_url":"https://api.github.com/users/Clockwork-Muse/received_events","type":"User","site_admin":false},"body":"Initial PR for cleaned up PLINQ tests.\r\n\r\nnote: I don't consider myself done with this by any means.  In particular, there's a number of things I want to add to the combinatorial tests (like cancellation).\r\n\r\nAll tests are passing - all 200K+ of them (most of that is the combinatorial tests).  The original version didn't appear to have many, due to not using `Theory`.  `OuterLoop` will take a _very_ long time to run, ~10 minutes on my machine(innerloop runs in about 90 seconds).\r\n\r\n@rafidka - you should be able to grab things now.  You'll actually want [this other branch instead](https://github.com/Clockwork-Muse/corefx/tree/516_System.Linq.Parallel_FullyOrdered), which assumes more ordered output than PLINQ currently delivers (but I'm not sure if it's a bug...).\r\n\r\nI'm going to be in Scotland for two weeks, so my ability to reply/deal with changes from the code review in that time will be limited.\r\n\r\nPossibly interested people: \r\n@stephentoub , @alfredoMS , @svick, @weshaggard","created_at":"2015-04-30T23:46:33Z","updated_at":"2015-06-02T12:20:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4c402b3f0b4616461da4d760b02b5b3a9af8c830","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/1599/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/1599/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/1599/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/264ed5cbfff5f021379ef63d6aa8a5262d3d2f94","head":{"label":"Clockwork-Muse:516_System.Linq.Parallel","ref":"516_System.Linq.Parallel","sha":"264ed5cbfff5f021379ef63d6aa8a5262d3d2f94","user":{"login":"Clockwork-Muse","id":5569508,"avatar_url":"https://avatars.githubusercontent.com/u/5569508?v=3","gravatar_id":"","url":"https://api.github.com/users/Clockwork-Muse","html_url":"https://github.com/Clockwork-Muse","followers_url":"https://api.github.com/users/Clockwork-Muse/followers","following_url":"https://api.github.com/users/Clockwork-Muse/following{/other_user}","gists_url":"https://api.github.com/users/Clockwork-Muse/gists{/gist_id}","starred_url":"https://api.github.com/users/Clockwork-Muse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Clockwork-Muse/subscriptions","organizations_url":"https://api.github.com/users/Clockwork-Muse/orgs","repos_url":"https://api.github.com/users/Clockwork-Muse/repos","events_url":"https://api.github.com/users/Clockwork-Muse/events{/privacy}","received_events_url":"https://api.github.com/users/Clockwork-Muse/received_events","type":"User","site_admin":false},"repo":{"id":29805465,"name":"corefx","full_name":"Clockwork-Muse/corefx","owner":{"login":"Clockwork-Muse","id":5569508,"avatar_url":"https://avatars.githubusercontent.com/u/5569508?v=3","gravatar_id":"","url":"https://api.github.com/users/Clockwork-Muse","html_url":"https://github.com/Clockwork-Muse","followers_url":"https://api.github.com/users/Clockwork-Muse/followers","following_url":"https://api.github.com/users/Clockwork-Muse/following{/other_user}","gists_url":"https://api.github.com/users/Clockwork-Muse/gists{/gist_id}","starred_url":"https://api.github.com/users/Clockwork-Muse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Clockwork-Muse/subscriptions","organizations_url":"https://api.github.com/users/Clockwork-Muse/orgs","repos_url":"https://api.github.com/users/Clockwork-Muse/repos","events_url":"https://api.github.com/users/Clockwork-Muse/events{/privacy}","received_events_url":"https://api.github.com/users/Clockwork-Muse/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Clockwork-Muse/corefx","description":"Branch for issue #516.  WARNING - will be rebased often.","fork":true,"url":"https://api.github.com/repos/Clockwork-Muse/corefx","forks_url":"https://api.github.com/repos/Clockwork-Muse/corefx/forks","keys_url":"https://api.github.com/repos/Clockwork-Muse/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Clockwork-Muse/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Clockwork-Muse/corefx/teams","hooks_url":"https://api.github.com/repos/Clockwork-Muse/corefx/hooks","issue_events_url":"https://api.github.com/repos/Clockwork-Muse/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/Clockwork-Muse/corefx/events","assignees_url":"https://api.github.com/repos/Clockwork-Muse/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/Clockwork-Muse/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/Clockwork-Muse/corefx/tags","blobs_url":"https://api.github.com/repos/Clockwork-Muse/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Clockwork-Muse/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Clockwork-Muse/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/Clockwork-Muse/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Clockwork-Muse/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/Clockwork-Muse/corefx/languages","stargazers_url":"https://api.github.com/repos/Clockwork-Muse/corefx/stargazers","contributors_url":"https://api.github.com/repos/Clockwork-Muse/corefx/contributors","subscribers_url":"https://api.github.com/repos/Clockwork-Muse/corefx/subscribers","subscription_url":"https://api.github.com/repos/Clockwork-Muse/corefx/subscription","commits_url":"https://api.github.com/repos/Clockwork-Muse/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/Clockwork-Muse/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/Clockwork-Muse/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/Clockwork-Muse/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/Clockwork-Muse/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/Clockwork-Muse/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Clockwork-Muse/corefx/merges","archive_url":"https://api.github.com/repos/Clockwork-Muse/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Clockwork-Muse/corefx/downloads","issues_url":"https://api.github.com/repos/Clockwork-Muse/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/Clockwork-Muse/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/Clockwork-Muse/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/Clockwork-Muse/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Clockwork-Muse/corefx/labels{/name}","releases_url":"https://api.github.com/repos/Clockwork-Muse/corefx/releases{/id}","created_at":"2015-01-25T06:35:53Z","updated_at":"2015-04-30T10:08:57Z","pushed_at":"2015-06-02T11:41:43Z","git_url":"git://github.com/Clockwork-Muse/corefx.git","ssh_url":"git@github.com:Clockwork-Muse/corefx.git","clone_url":"https://github.com/Clockwork-Muse/corefx.git","svn_url":"https://github.com/Clockwork-Muse/corefx","homepage":"","size":20458,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"819f3c3c151a716cf59c0d2f185f4f6ceb8d49fd","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","created_at":"2014-11-06T23:42:48Z","updated_at":"2015-06-02T07:54:12Z","pushed_at":"2015-06-02T11:41:44Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"","size":48739,"stargazers_count":7859,"watchers_count":7859,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1588,"mirror_url":null,"open_issues_count":409,"forks":1588,"open_issues":409,"watchers":7859,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/1599"},"html":{"href":"https://github.com/dotnet/corefx/pull/1599"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/1599"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/1599/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/1599/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/1599/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/264ed5cbfff5f021379ef63d6aa8a5262d3d2f94"}}}}