{"action":"opened","number":141,"pull_request":{"url":"https://api.github.com/repos/cyclus/fundamentals-paper/pulls/141","id":52089516,"html_url":"https://github.com/cyclus/fundamentals-paper/pull/141","diff_url":"https://github.com/cyclus/fundamentals-paper/pull/141.diff","patch_url":"https://github.com/cyclus/fundamentals-paper/pull/141.patch","issue_url":"https://api.github.com/repos/cyclus/fundamentals-paper/issues/141","number":141,"state":"open","locked":false,"title":"Review and Resubmit","user":{"login":"katyhuff","id":393899,"avatar_url":"https://avatars.githubusercontent.com/u/393899?v=3","gravatar_id":"","url":"https://api.github.com/users/katyhuff","html_url":"https://github.com/katyhuff","followers_url":"https://api.github.com/users/katyhuff/followers","following_url":"https://api.github.com/users/katyhuff/following{/other_user}","gists_url":"https://api.github.com/users/katyhuff/gists{/gist_id}","starred_url":"https://api.github.com/users/katyhuff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/katyhuff/subscriptions","organizations_url":"https://api.github.com/users/katyhuff/orgs","repos_url":"https://api.github.com/users/katyhuff/repos","events_url":"https://api.github.com/users/katyhuff/events{/privacy}","received_events_url":"https://api.github.com/users/katyhuff/received_events","type":"User","site_admin":false},"body":"This PR contains the minor revisions suggested by the reviewers from Advances in Engineering Software. This doesn't complete all suggested revisions. A few less trivial revisions remain to adequately satisfy those needs. \r\n\r\nEach of the recommendations was addressed with a separate commit message, where possible. The recommendations addressed include:\r\n\r\n## Reviewer 1\r\n- Line 15: You indicate \"current tools are typically privately distributed\" - such as? Reviewer can think of ORION and possibly COSI - are there others? (Indicate examples if possible)\r\n- Line 17: \"inflexible architectures\" - authors  explain this a little more later in the paper, but consider expanding your meaning briefly here.\r\n- Line 67: toxicity is best described as radiotoxicity; mined uranium is mined uranium requirements. Meanwhile it's probably useful to express these in terms of per unit energy.\r\n- Line 102: \"nuclear technologies\" - probably better described as nuclear technologies and facility types.\r\n- Line 160: What platform does CAFCA rely upon? (Simulink? PowerSim? VISION for example relies on PowerSim; even when universities are able to get their hands on it, modification is indeed difficult because of the proprietary software requirement).\r\n- Line 161: I think it's important to note here in this context that Cyclus is based on C++, where development tools are freely available and an open, well-documented standard.\r\n- Line 227: What kind of nonproliferation applications is this significant to? What kinds of questions *can* Cyclus answer? This need not be terribly explicit, but I would suggest giving some further detail rather than alluding to it and then leaving it unspecified.\r\n- Line 270: \"Resource computing infrastructures\" - this term might warrant further definition. (I assume you mean systems like cloud computing and batch scheduling computing clusters.)\r\n- Line 278: proof-of-principle\r\n- Line 339: \"is superior to the system dynamic approach.\" I feel like a claim is being made here about superiority without much substantiation or expression of what the merit criteria is. This paragraph could use some further unpacking.\r\n- Line 353: \"The API abstracts away unnecessary detail\" => suggest phrasing as \"abstracts away details unnecessary to the implementation of the archetype-specific behavior\"\r\n- Figure 3 could be a bit bigger.\r\n- Line 379: Directed acyclic graph: I suspect most readers will not be familiar with graph theory. A brief explanation and unpacking of the relevant context would be useful here.\r\n- Line 398: \"However, some questions require resolution at the level of individual facilities and materials.\" Such as? No need to go into explicit detail here, but given that you're building a case for flexible scoping, it would be helpful to produce a few examples that help to make your case. (For example, detailed isotopic analysis for thermal recycle vs. recipes. Nonproliferation applications. Etc.)\r\n- Line 649: \"because the new version is almost always wrong.\" This wording seems dangerously unclear. I think the intent is to say that deviation from prior, blessed results is almost always wrong (unless the change is expected, obviously). What is \"wrong\" are departures in results from a baseline.\r\n- Line 785: Define heavy metal (and its abbreviation) for non-nuclear engineers.\r\n\r\n## Reviewer 2\r\n\r\n- Section 1.2 Line 127 change facilitates to facilitate\r\n- Section 2.5.1 Line 616 Do the authors  mean tool git or tool kit? In English English git is a pejorative term and will cause some amusement!\r\n- Section 2.5.3 Line 670 correct spelling of automated\r\n- Section 3.1.2 line 754 Should the table being referenced be Table 3 rather than Table 1?\r\n","created_at":"2015-11-30T06:32:00Z","updated_at":"2015-11-30T06:32:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cyclus/fundamentals-paper/pulls/141/commits","review_comments_url":"https://api.github.com/repos/cyclus/fundamentals-paper/pulls/141/comments","review_comment_url":"https://api.github.com/repos/cyclus/fundamentals-paper/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cyclus/fundamentals-paper/issues/141/comments","statuses_url":"https://api.github.com/repos/cyclus/fundamentals-paper/statuses/3475d8f39f1f5e3b3cb67bccb98ed6f019b737b0","head":{"label":"katyhuff:rr","ref":"rr","sha":"3475d8f39f1f5e3b3cb67bccb98ed6f019b737b0","user":{"login":"katyhuff","id":393899,"avatar_url":"https://avatars.githubusercontent.com/u/393899?v=3","gravatar_id":"","url":"https://api.github.com/users/katyhuff","html_url":"https://github.com/katyhuff","followers_url":"https://api.github.com/users/katyhuff/followers","following_url":"https://api.github.com/users/katyhuff/following{/other_user}","gists_url":"https://api.github.com/users/katyhuff/gists{/gist_id}","starred_url":"https://api.github.com/users/katyhuff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/katyhuff/subscriptions","organizations_url":"https://api.github.com/users/katyhuff/orgs","repos_url":"https://api.github.com/users/katyhuff/repos","events_url":"https://api.github.com/users/katyhuff/events{/privacy}","received_events_url":"https://api.github.com/users/katyhuff/received_events","type":"User","site_admin":false},"repo":{"id":22134605,"name":"fundamentals-paper","full_name":"katyhuff/fundamentals-paper","owner":{"login":"katyhuff","id":393899,"avatar_url":"https://avatars.githubusercontent.com/u/393899?v=3","gravatar_id":"","url":"https://api.github.com/users/katyhuff","html_url":"https://github.com/katyhuff","followers_url":"https://api.github.com/users/katyhuff/followers","following_url":"https://api.github.com/users/katyhuff/following{/other_user}","gists_url":"https://api.github.com/users/katyhuff/gists{/gist_id}","starred_url":"https://api.github.com/users/katyhuff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/katyhuff/subscriptions","organizations_url":"https://api.github.com/users/katyhuff/orgs","repos_url":"https://api.github.com/users/katyhuff/repos","events_url":"https://api.github.com/users/katyhuff/events{/privacy}","received_events_url":"https://api.github.com/users/katyhuff/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/katyhuff/fundamentals-paper","description":"A repository to hold the fundamentals paper","fork":true,"url":"https://api.github.com/repos/katyhuff/fundamentals-paper","forks_url":"https://api.github.com/repos/katyhuff/fundamentals-paper/forks","keys_url":"https://api.github.com/repos/katyhuff/fundamentals-paper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/katyhuff/fundamentals-paper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/katyhuff/fundamentals-paper/teams","hooks_url":"https://api.github.com/repos/katyhuff/fundamentals-paper/hooks","issue_events_url":"https://api.github.com/repos/katyhuff/fundamentals-paper/issues/events{/number}","events_url":"https://api.github.com/repos/katyhuff/fundamentals-paper/events","assignees_url":"https://api.github.com/repos/katyhuff/fundamentals-paper/assignees{/user}","branches_url":"https://api.github.com/repos/katyhuff/fundamentals-paper/branches{/branch}","tags_url":"https://api.github.com/repos/katyhuff/fundamentals-paper/tags","blobs_url":"https://api.github.com/repos/katyhuff/fundamentals-paper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/katyhuff/fundamentals-paper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/katyhuff/fundamentals-paper/git/refs{/sha}","trees_url":"https://api.github.com/repos/katyhuff/fundamentals-paper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/katyhuff/fundamentals-paper/statuses/{sha}","languages_url":"https://api.github.com/repos/katyhuff/fundamentals-paper/languages","stargazers_url":"https://api.github.com/repos/katyhuff/fundamentals-paper/stargazers","contributors_url":"https://api.github.com/repos/katyhuff/fundamentals-paper/contributors","subscribers_url":"https://api.github.com/repos/katyhuff/fundamentals-paper/subscribers","subscription_url":"https://api.github.com/repos/katyhuff/fundamentals-paper/subscription","commits_url":"https://api.github.com/repos/katyhuff/fundamentals-paper/commits{/sha}","git_commits_url":"https://api.github.com/repos/katyhuff/fundamentals-paper/git/commits{/sha}","comments_url":"https://api.github.com/repos/katyhuff/fundamentals-paper/comments{/number}","issue_comment_url":"https://api.github.com/repos/katyhuff/fundamentals-paper/issues/comments{/number}","contents_url":"https://api.github.com/repos/katyhuff/fundamentals-paper/contents/{+path}","compare_url":"https://api.github.com/repos/katyhuff/fundamentals-paper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/katyhuff/fundamentals-paper/merges","archive_url":"https://api.github.com/repos/katyhuff/fundamentals-paper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/katyhuff/fundamentals-paper/downloads","issues_url":"https://api.github.com/repos/katyhuff/fundamentals-paper/issues{/number}","pulls_url":"https://api.github.com/repos/katyhuff/fundamentals-paper/pulls{/number}","milestones_url":"https://api.github.com/repos/katyhuff/fundamentals-paper/milestones{/number}","notifications_url":"https://api.github.com/repos/katyhuff/fundamentals-paper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/katyhuff/fundamentals-paper/labels{/name}","releases_url":"https://api.github.com/repos/katyhuff/fundamentals-paper/releases{/id}","created_at":"2014-07-23T06:37:34Z","updated_at":"2015-03-11T19:53:14Z","pushed_at":"2015-11-30T06:17:15Z","git_url":"git://github.com/katyhuff/fundamentals-paper.git","ssh_url":"git@github.com:katyhuff/fundamentals-paper.git","clone_url":"https://github.com/katyhuff/fundamentals-paper.git","svn_url":"https://github.com/katyhuff/fundamentals-paper","homepage":null,"size":1378,"stargazers_count":0,"watchers_count":0,"language":"TeX","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cyclus:master","ref":"master","sha":"9be690e256dbcb44d7d71a8736d7829a543c0b0c","user":{"login":"cyclus","id":1355686,"avatar_url":"https://avatars.githubusercontent.com/u/1355686?v=3","gravatar_id":"","url":"https://api.github.com/users/cyclus","html_url":"https://github.com/cyclus","followers_url":"https://api.github.com/users/cyclus/followers","following_url":"https://api.github.com/users/cyclus/following{/other_user}","gists_url":"https://api.github.com/users/cyclus/gists{/gist_id}","starred_url":"https://api.github.com/users/cyclus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyclus/subscriptions","organizations_url":"https://api.github.com/users/cyclus/orgs","repos_url":"https://api.github.com/users/cyclus/repos","events_url":"https://api.github.com/users/cyclus/events{/privacy}","received_events_url":"https://api.github.com/users/cyclus/received_events","type":"Organization","site_admin":false},"repo":{"id":21914330,"name":"fundamentals-paper","full_name":"cyclus/fundamentals-paper","owner":{"login":"cyclus","id":1355686,"avatar_url":"https://avatars.githubusercontent.com/u/1355686?v=3","gravatar_id":"","url":"https://api.github.com/users/cyclus","html_url":"https://github.com/cyclus","followers_url":"https://api.github.com/users/cyclus/followers","following_url":"https://api.github.com/users/cyclus/following{/other_user}","gists_url":"https://api.github.com/users/cyclus/gists{/gist_id}","starred_url":"https://api.github.com/users/cyclus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyclus/subscriptions","organizations_url":"https://api.github.com/users/cyclus/orgs","repos_url":"https://api.github.com/users/cyclus/repos","events_url":"https://api.github.com/users/cyclus/events{/privacy}","received_events_url":"https://api.github.com/users/cyclus/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cyclus/fundamentals-paper","description":"A repository to hold the fundamentals paper","fork":false,"url":"https://api.github.com/repos/cyclus/fundamentals-paper","forks_url":"https://api.github.com/repos/cyclus/fundamentals-paper/forks","keys_url":"https://api.github.com/repos/cyclus/fundamentals-paper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cyclus/fundamentals-paper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cyclus/fundamentals-paper/teams","hooks_url":"https://api.github.com/repos/cyclus/fundamentals-paper/hooks","issue_events_url":"https://api.github.com/repos/cyclus/fundamentals-paper/issues/events{/number}","events_url":"https://api.github.com/repos/cyclus/fundamentals-paper/events","assignees_url":"https://api.github.com/repos/cyclus/fundamentals-paper/assignees{/user}","branches_url":"https://api.github.com/repos/cyclus/fundamentals-paper/branches{/branch}","tags_url":"https://api.github.com/repos/cyclus/fundamentals-paper/tags","blobs_url":"https://api.github.com/repos/cyclus/fundamentals-paper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cyclus/fundamentals-paper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cyclus/fundamentals-paper/git/refs{/sha}","trees_url":"https://api.github.com/repos/cyclus/fundamentals-paper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cyclus/fundamentals-paper/statuses/{sha}","languages_url":"https://api.github.com/repos/cyclus/fundamentals-paper/languages","stargazers_url":"https://api.github.com/repos/cyclus/fundamentals-paper/stargazers","contributors_url":"https://api.github.com/repos/cyclus/fundamentals-paper/contributors","subscribers_url":"https://api.github.com/repos/cyclus/fundamentals-paper/subscribers","subscription_url":"https://api.github.com/repos/cyclus/fundamentals-paper/subscription","commits_url":"https://api.github.com/repos/cyclus/fundamentals-paper/commits{/sha}","git_commits_url":"https://api.github.com/repos/cyclus/fundamentals-paper/git/commits{/sha}","comments_url":"https://api.github.com/repos/cyclus/fundamentals-paper/comments{/number}","issue_comment_url":"https://api.github.com/repos/cyclus/fundamentals-paper/issues/comments{/number}","contents_url":"https://api.github.com/repos/cyclus/fundamentals-paper/contents/{+path}","compare_url":"https://api.github.com/repos/cyclus/fundamentals-paper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cyclus/fundamentals-paper/merges","archive_url":"https://api.github.com/repos/cyclus/fundamentals-paper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cyclus/fundamentals-paper/downloads","issues_url":"https://api.github.com/repos/cyclus/fundamentals-paper/issues{/number}","pulls_url":"https://api.github.com/repos/cyclus/fundamentals-paper/pulls{/number}","milestones_url":"https://api.github.com/repos/cyclus/fundamentals-paper/milestones{/number}","notifications_url":"https://api.github.com/repos/cyclus/fundamentals-paper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cyclus/fundamentals-paper/labels{/name}","releases_url":"https://api.github.com/repos/cyclus/fundamentals-paper/releases{/id}","created_at":"2014-07-16T19:36:00Z","updated_at":"2015-05-04T20:03:47Z","pushed_at":"2015-11-30T06:16:54Z","git_url":"git://github.com/cyclus/fundamentals-paper.git","ssh_url":"git@github.com:cyclus/fundamentals-paper.git","clone_url":"https://github.com/cyclus/fundamentals-paper.git","svn_url":"https://github.com/cyclus/fundamentals-paper","homepage":null,"size":1377,"stargazers_count":1,"watchers_count":1,"language":"TeX","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":1,"forks":7,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cyclus/fundamentals-paper/pulls/141"},"html":{"href":"https://github.com/cyclus/fundamentals-paper/pull/141"},"issue":{"href":"https://api.github.com/repos/cyclus/fundamentals-paper/issues/141"},"comments":{"href":"https://api.github.com/repos/cyclus/fundamentals-paper/issues/141/comments"},"review_comments":{"href":"https://api.github.com/repos/cyclus/fundamentals-paper/pulls/141/comments"},"review_comment":{"href":"https://api.github.com/repos/cyclus/fundamentals-paper/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cyclus/fundamentals-paper/pulls/141/commits"},"statuses":{"href":"https://api.github.com/repos/cyclus/fundamentals-paper/statuses/3475d8f39f1f5e3b3cb67bccb98ed6f019b737b0"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":19,"additions":51,"deletions":33,"changed_files":4}}