{"action":"closed","number":67,"pull_request":{"url":"https://api.github.com/repos/dojo/core/pulls/67","id":43088913,"html_url":"https://github.com/dojo/core/pull/67","diff_url":"https://github.com/dojo/core/pull/67.diff","patch_url":"https://github.com/dojo/core/pull/67.patch","issue_url":"https://api.github.com/repos/dojo/core/issues/67","number":67,"state":"closed","locked":false,"title":"Fix request/xhr timeout logic","user":{"login":"kfranqueiro","id":398379,"avatar_url":"https://avatars.githubusercontent.com/u/398379?v=3","gravatar_id":"","url":"https://api.github.com/users/kfranqueiro","html_url":"https://github.com/kfranqueiro","followers_url":"https://api.github.com/users/kfranqueiro/followers","following_url":"https://api.github.com/users/kfranqueiro/following{/other_user}","gists_url":"https://api.github.com/users/kfranqueiro/gists{/gist_id}","starred_url":"https://api.github.com/users/kfranqueiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kfranqueiro/subscriptions","organizations_url":"https://api.github.com/users/kfranqueiro/orgs","repos_url":"https://api.github.com/users/kfranqueiro/repos","events_url":"https://api.github.com/users/kfranqueiro/events{/privacy}","received_events_url":"https://api.github.com/users/kfranqueiro/received_events","type":"User","site_admin":false},"body":"This PR is based on top of a rebased/squashed version of #66, and additionally fixes #64.\r\n\r\nAs mentioned in #64, I first tried resolving this using a timestamp comparison, but that didn't turn out too well in IE.  This works across browsers.\r\n\r\nThe only possible reservation I might have is that historically, large numbers of setTimeouts were bad news for old IE, which is why Dojo 1 had a polling interval and kept track of all in-flight XHRs instead.  This PR opts for simply setting one timeout per XHR (which is also what our code in the node provider is doing), since the code for it is a lot simpler and more straightforward.  If this proves to still be a bad thing for any modern browsers we're actually interested in supporting, we can revisit this.","created_at":"2015-08-21T22:53:47Z","updated_at":"2015-11-16T09:31:26Z","closed_at":"2015-11-16T09:31:26Z","merged_at":null,"merge_commit_sha":"932bcf4f14dd5c3f049ff006b2c78c6abc99e7d0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dojo/core/pulls/67/commits","review_comments_url":"https://api.github.com/repos/dojo/core/pulls/67/comments","review_comment_url":"https://api.github.com/repos/dojo/core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dojo/core/issues/67/comments","statuses_url":"https://api.github.com/repos/dojo/core/statuses/82a387a7c43cddaf54a762a5e05f0d549484c17d","head":{"label":"kfranqueiro:xhr-timeout","ref":"xhr-timeout","sha":"82a387a7c43cddaf54a762a5e05f0d549484c17d","user":{"login":"kfranqueiro","id":398379,"avatar_url":"https://avatars.githubusercontent.com/u/398379?v=3","gravatar_id":"","url":"https://api.github.com/users/kfranqueiro","html_url":"https://github.com/kfranqueiro","followers_url":"https://api.github.com/users/kfranqueiro/followers","following_url":"https://api.github.com/users/kfranqueiro/following{/other_user}","gists_url":"https://api.github.com/users/kfranqueiro/gists{/gist_id}","starred_url":"https://api.github.com/users/kfranqueiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kfranqueiro/subscriptions","organizations_url":"https://api.github.com/users/kfranqueiro/orgs","repos_url":"https://api.github.com/users/kfranqueiro/repos","events_url":"https://api.github.com/users/kfranqueiro/events{/privacy}","received_events_url":"https://api.github.com/users/kfranqueiro/received_events","type":"User","site_admin":false},"repo":{"id":35290881,"name":"core","full_name":"kfranqueiro/core","owner":{"login":"kfranqueiro","id":398379,"avatar_url":"https://avatars.githubusercontent.com/u/398379?v=3","gravatar_id":"","url":"https://api.github.com/users/kfranqueiro","html_url":"https://github.com/kfranqueiro","followers_url":"https://api.github.com/users/kfranqueiro/followers","following_url":"https://api.github.com/users/kfranqueiro/following{/other_user}","gists_url":"https://api.github.com/users/kfranqueiro/gists{/gist_id}","starred_url":"https://api.github.com/users/kfranqueiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kfranqueiro/subscriptions","organizations_url":"https://api.github.com/users/kfranqueiro/orgs","repos_url":"https://api.github.com/users/kfranqueiro/repos","events_url":"https://api.github.com/users/kfranqueiro/events{/privacy}","received_events_url":"https://api.github.com/users/kfranqueiro/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kfranqueiro/core","description":"Dojo 2 package containing TypeScript and JavaScript core utilities","fork":true,"url":"https://api.github.com/repos/kfranqueiro/core","forks_url":"https://api.github.com/repos/kfranqueiro/core/forks","keys_url":"https://api.github.com/repos/kfranqueiro/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kfranqueiro/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kfranqueiro/core/teams","hooks_url":"https://api.github.com/repos/kfranqueiro/core/hooks","issue_events_url":"https://api.github.com/repos/kfranqueiro/core/issues/events{/number}","events_url":"https://api.github.com/repos/kfranqueiro/core/events","assignees_url":"https://api.github.com/repos/kfranqueiro/core/assignees{/user}","branches_url":"https://api.github.com/repos/kfranqueiro/core/branches{/branch}","tags_url":"https://api.github.com/repos/kfranqueiro/core/tags","blobs_url":"https://api.github.com/repos/kfranqueiro/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kfranqueiro/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kfranqueiro/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/kfranqueiro/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kfranqueiro/core/statuses/{sha}","languages_url":"https://api.github.com/repos/kfranqueiro/core/languages","stargazers_url":"https://api.github.com/repos/kfranqueiro/core/stargazers","contributors_url":"https://api.github.com/repos/kfranqueiro/core/contributors","subscribers_url":"https://api.github.com/repos/kfranqueiro/core/subscribers","subscription_url":"https://api.github.com/repos/kfranqueiro/core/subscription","commits_url":"https://api.github.com/repos/kfranqueiro/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/kfranqueiro/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/kfranqueiro/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/kfranqueiro/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/kfranqueiro/core/contents/{+path}","compare_url":"https://api.github.com/repos/kfranqueiro/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kfranqueiro/core/merges","archive_url":"https://api.github.com/repos/kfranqueiro/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kfranqueiro/core/downloads","issues_url":"https://api.github.com/repos/kfranqueiro/core/issues{/number}","pulls_url":"https://api.github.com/repos/kfranqueiro/core/pulls{/number}","milestones_url":"https://api.github.com/repos/kfranqueiro/core/milestones{/number}","notifications_url":"https://api.github.com/repos/kfranqueiro/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kfranqueiro/core/labels{/name}","releases_url":"https://api.github.com/repos/kfranqueiro/core/releases{/id}","created_at":"2015-05-08T16:52:18Z","updated_at":"2015-06-21T03:20:05Z","pushed_at":"2015-08-21T22:49:34Z","git_url":"git://github.com/kfranqueiro/core.git","ssh_url":"git@github.com:kfranqueiro/core.git","clone_url":"https://github.com/kfranqueiro/core.git","svn_url":"https://github.com/kfranqueiro/core","homepage":"","size":683,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dojo:master","ref":"master","sha":"bef38f2b7206e021572e7af1e08dfed43ad1b57f","user":{"login":"dojo","id":86896,"avatar_url":"https://avatars.githubusercontent.com/u/86896?v=3","gravatar_id":"","url":"https://api.github.com/users/dojo","html_url":"https://github.com/dojo","followers_url":"https://api.github.com/users/dojo/followers","following_url":"https://api.github.com/users/dojo/following{/other_user}","gists_url":"https://api.github.com/users/dojo/gists{/gist_id}","starred_url":"https://api.github.com/users/dojo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dojo/subscriptions","organizations_url":"https://api.github.com/users/dojo/orgs","repos_url":"https://api.github.com/users/dojo/repos","events_url":"https://api.github.com/users/dojo/events{/privacy}","received_events_url":"https://api.github.com/users/dojo/received_events","type":"Organization","site_admin":false},"repo":{"id":31790386,"name":"core","full_name":"dojo/core","owner":{"login":"dojo","id":86896,"avatar_url":"https://avatars.githubusercontent.com/u/86896?v=3","gravatar_id":"","url":"https://api.github.com/users/dojo","html_url":"https://github.com/dojo","followers_url":"https://api.github.com/users/dojo/followers","following_url":"https://api.github.com/users/dojo/following{/other_user}","gists_url":"https://api.github.com/users/dojo/gists{/gist_id}","starred_url":"https://api.github.com/users/dojo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dojo/subscriptions","organizations_url":"https://api.github.com/users/dojo/orgs","repos_url":"https://api.github.com/users/dojo/repos","events_url":"https://api.github.com/users/dojo/events{/privacy}","received_events_url":"https://api.github.com/users/dojo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dojo/core","description":"Dojo 2 package containing TypeScript and JavaScript core utilities","fork":false,"url":"https://api.github.com/repos/dojo/core","forks_url":"https://api.github.com/repos/dojo/core/forks","keys_url":"https://api.github.com/repos/dojo/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dojo/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dojo/core/teams","hooks_url":"https://api.github.com/repos/dojo/core/hooks","issue_events_url":"https://api.github.com/repos/dojo/core/issues/events{/number}","events_url":"https://api.github.com/repos/dojo/core/events","assignees_url":"https://api.github.com/repos/dojo/core/assignees{/user}","branches_url":"https://api.github.com/repos/dojo/core/branches{/branch}","tags_url":"https://api.github.com/repos/dojo/core/tags","blobs_url":"https://api.github.com/repos/dojo/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dojo/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dojo/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/dojo/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dojo/core/statuses/{sha}","languages_url":"https://api.github.com/repos/dojo/core/languages","stargazers_url":"https://api.github.com/repos/dojo/core/stargazers","contributors_url":"https://api.github.com/repos/dojo/core/contributors","subscribers_url":"https://api.github.com/repos/dojo/core/subscribers","subscription_url":"https://api.github.com/repos/dojo/core/subscription","commits_url":"https://api.github.com/repos/dojo/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/dojo/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/dojo/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/dojo/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/dojo/core/contents/{+path}","compare_url":"https://api.github.com/repos/dojo/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dojo/core/merges","archive_url":"https://api.github.com/repos/dojo/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dojo/core/downloads","issues_url":"https://api.github.com/repos/dojo/core/issues{/number}","pulls_url":"https://api.github.com/repos/dojo/core/pulls{/number}","milestones_url":"https://api.github.com/repos/dojo/core/milestones{/number}","notifications_url":"https://api.github.com/repos/dojo/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dojo/core/labels{/name}","releases_url":"https://api.github.com/repos/dojo/core/releases{/id}","created_at":"2015-03-06T21:44:31Z","updated_at":"2015-11-07T08:14:11Z","pushed_at":"2015-11-16T09:30:37Z","git_url":"git://github.com/dojo/core.git","ssh_url":"git@github.com:dojo/core.git","clone_url":"https://github.com/dojo/core.git","svn_url":"https://github.com/dojo/core","homepage":"","size":1711,"stargazers_count":41,"watchers_count":41,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"open_issues_count":19,"forks":25,"open_issues":19,"watchers":41,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dojo/core/pulls/67"},"html":{"href":"https://github.com/dojo/core/pull/67"},"issue":{"href":"https://api.github.com/repos/dojo/core/issues/67"},"comments":{"href":"https://api.github.com/repos/dojo/core/issues/67/comments"},"review_comments":{"href":"https://api.github.com/repos/dojo/core/pulls/67/comments"},"review_comment":{"href":"https://api.github.com/repos/dojo/core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dojo/core/pulls/67/commits"},"statuses":{"href":"https://api.github.com/repos/dojo/core/statuses/82a387a7c43cddaf54a762a5e05f0d549484c17d"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":2,"review_comments":0,"commits":2,"additions":30,"deletions":13,"changed_files":3}}