{"action":"created","issue":{"url":"https://api.github.com/repos/kevin-alpine/chorus-models-upgrade/issues/2","labels_url":"https://api.github.com/repos/kevin-alpine/chorus-models-upgrade/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/kevin-alpine/chorus-models-upgrade/issues/2/comments","events_url":"https://api.github.com/repos/kevin-alpine/chorus-models-upgrade/issues/2/events","html_url":"https://github.com/kevin-alpine/chorus-models-upgrade/pull/2","id":75423995,"number":2,"title":"Rails 3.2.18 - > Rails 4.0.13 + fix spec failures (DO NOT MERGE)","user":{"login":"kevin-alpine","id":12001313,"avatar_url":"https://avatars.githubusercontent.com/u/12001313?v=3","gravatar_id":"","url":"https://api.github.com/users/kevin-alpine","html_url":"https://github.com/kevin-alpine","followers_url":"https://api.github.com/users/kevin-alpine/followers","following_url":"https://api.github.com/users/kevin-alpine/following{/other_user}","gists_url":"https://api.github.com/users/kevin-alpine/gists{/gist_id}","starred_url":"https://api.github.com/users/kevin-alpine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevin-alpine/subscriptions","organizations_url":"https://api.github.com/users/kevin-alpine/orgs","repos_url":"https://api.github.com/users/kevin-alpine/repos","events_url":"https://api.github.com/users/kevin-alpine/events{/privacy}","received_events_url":"https://api.github.com/users/kevin-alpine/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-05-12T01:53:06Z","updated_at":"2015-05-20T19:03:36Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kevin-alpine/chorus-models-upgrade/pulls/2","html_url":"https://github.com/kevin-alpine/chorus-models-upgrade/pull/2","diff_url":"https://github.com/kevin-alpine/chorus-models-upgrade/pull/2.diff","patch_url":"https://github.com/kevin-alpine/chorus-models-upgrade/pull/2.patch"},"body":"Changes involved with upgrading Rails 3.2.18 -> 4.0.13 ... \r\n\r\nEach commit is targeted to a certain type of Rails upgrade change.  Check the commit log to see the rationale for each.  I will comment within the PR as well when something is uncertain or extra notable.\r\n\r\nThe PRs will be chained, one into another so that we can more easily keep track of which changes we are making and why.  \r\n\r\nWe will never merge them back into master, because we'll just copy the final branch over to the ensemble repo and, then either delete this repo or, keep it as documentation for a while."},"comment":{"url":"https://api.github.com/repos/kevin-alpine/chorus-models-upgrade/issues/comments/103997408","html_url":"https://github.com/kevin-alpine/chorus-models-upgrade/pull/2#issuecomment-103997408","issue_url":"https://api.github.com/repos/kevin-alpine/chorus-models-upgrade/issues/2","id":103997408,"user":{"login":"kevin-alpine","id":12001313,"avatar_url":"https://avatars.githubusercontent.com/u/12001313?v=3","gravatar_id":"","url":"https://api.github.com/users/kevin-alpine","html_url":"https://github.com/kevin-alpine","followers_url":"https://api.github.com/users/kevin-alpine/followers","following_url":"https://api.github.com/users/kevin-alpine/following{/other_user}","gists_url":"https://api.github.com/users/kevin-alpine/gists{/gist_id}","starred_url":"https://api.github.com/users/kevin-alpine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevin-alpine/subscriptions","organizations_url":"https://api.github.com/users/kevin-alpine/orgs","repos_url":"https://api.github.com/users/kevin-alpine/repos","events_url":"https://api.github.com/users/kevin-alpine/events{/privacy}","received_events_url":"https://api.github.com/users/kevin-alpine/received_events","type":"User","site_admin":false},"created_at":"2015-05-20T19:03:36Z","updated_at":"2015-05-20T19:03:36Z","body":"I marked two areas of specs as pending, for now:\r\n\r\n`````\r\n  GpdbDatasetColumn#simplified_type Is it ok to ignore changes to how Postgresql driver uses the simplifies_type method?\r\n    # No reason given\r\n    # ./spec/models/gpdb_dataset_column_spec.rb:142\r\n`````\r\n\r\n`````\r\n  Workspace associations\r\n    # KT: upgraded shoulda-matcher syntax potentially depends on RSpec 3 ...\r\n    # ./spec/models/workspace_spec.rb:34\r\n`````"}}