{"action":"closed","number":10,"pull_request":{"url":"https://api.github.com/repos/mautic/api-library/pulls/10","id":34537436,"html_url":"https://github.com/mautic/api-library/pull/10","diff_url":"https://github.com/mautic/api-library/pull/10.diff","patch_url":"https://github.com/mautic/api-library/pull/10.patch","issue_url":"https://api.github.com/repos/mautic/api-library/issues/10","number":10,"state":"closed","locked":false,"title":"Appended the callback to the authorize URL for OAuth1a","user":{"login":"alanhartless","id":63312,"avatar_url":"https://avatars.githubusercontent.com/u/63312?v=3","gravatar_id":"","url":"https://api.github.com/users/alanhartless","html_url":"https://github.com/alanhartless","followers_url":"https://api.github.com/users/alanhartless/followers","following_url":"https://api.github.com/users/alanhartless/following{/other_user}","gists_url":"https://api.github.com/users/alanhartless/gists{/gist_id}","starred_url":"https://api.github.com/users/alanhartless/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alanhartless/subscriptions","organizations_url":"https://api.github.com/users/alanhartless/orgs","repos_url":"https://api.github.com/users/alanhartless/repos","events_url":"https://api.github.com/users/alanhartless/events{/privacy}","received_events_url":"https://api.github.com/users/alanhartless/received_events","type":"User","site_admin":false},"body":"**Background**\r\nMautic has a PR that allows the admin to configure a consumer without restricting to a specific callback URL. In this scenario, the oauth server needs to know what URL to return to post authorization. The library didn't include the callback when requesting the token and thus Mautic didn't redirect back to the requesting script. \r\n\r\n**Testing**\r\nThis is in partnership with PR https://github.com/mautic/mautic/pull/358. Create an oauth1a consumer without restricting a callback. Then try to authorize via the api tester. Before the PR, the server would just download a file with the token and not redirect. After the PR, the user should be redirected back to the api tester or whatever is included as the callback.  If a callback is configured in the Consumer, using a different callback will result in access denied.","created_at":"2015-05-01T13:38:07Z","updated_at":"2015-06-19T17:40:29Z","closed_at":"2015-06-19T17:40:29Z","merged_at":"2015-06-19T17:40:29Z","merge_commit_sha":"7ab6d6caeb79b6a648abcba3b88f7bda7287ffed","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mautic/api-library/pulls/10/commits","review_comments_url":"https://api.github.com/repos/mautic/api-library/pulls/10/comments","review_comment_url":"https://api.github.com/repos/mautic/api-library/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mautic/api-library/issues/10/comments","statuses_url":"https://api.github.com/repos/mautic/api-library/statuses/74a150a9c5c50de389c74834096c7f8a6798c6ed","head":{"label":"alanhartless:callback-fix","ref":"callback-fix","sha":"74a150a9c5c50de389c74834096c7f8a6798c6ed","user":{"login":"alanhartless","id":63312,"avatar_url":"https://avatars.githubusercontent.com/u/63312?v=3","gravatar_id":"","url":"https://api.github.com/users/alanhartless","html_url":"https://github.com/alanhartless","followers_url":"https://api.github.com/users/alanhartless/followers","following_url":"https://api.github.com/users/alanhartless/following{/other_user}","gists_url":"https://api.github.com/users/alanhartless/gists{/gist_id}","starred_url":"https://api.github.com/users/alanhartless/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alanhartless/subscriptions","organizations_url":"https://api.github.com/users/alanhartless/orgs","repos_url":"https://api.github.com/users/alanhartless/repos","events_url":"https://api.github.com/users/alanhartless/events{/privacy}","received_events_url":"https://api.github.com/users/alanhartless/received_events","type":"User","site_admin":false},"repo":{"id":32093565,"name":"api-library","full_name":"alanhartless/api-library","owner":{"login":"alanhartless","id":63312,"avatar_url":"https://avatars.githubusercontent.com/u/63312?v=3","gravatar_id":"","url":"https://api.github.com/users/alanhartless","html_url":"https://github.com/alanhartless","followers_url":"https://api.github.com/users/alanhartless/followers","following_url":"https://api.github.com/users/alanhartless/following{/other_user}","gists_url":"https://api.github.com/users/alanhartless/gists{/gist_id}","starred_url":"https://api.github.com/users/alanhartless/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alanhartless/subscriptions","organizations_url":"https://api.github.com/users/alanhartless/orgs","repos_url":"https://api.github.com/users/alanhartless/repos","events_url":"https://api.github.com/users/alanhartless/events{/privacy}","received_events_url":"https://api.github.com/users/alanhartless/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alanhartless/api-library","description":"Mautic API Library","fork":true,"url":"https://api.github.com/repos/alanhartless/api-library","forks_url":"https://api.github.com/repos/alanhartless/api-library/forks","keys_url":"https://api.github.com/repos/alanhartless/api-library/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alanhartless/api-library/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alanhartless/api-library/teams","hooks_url":"https://api.github.com/repos/alanhartless/api-library/hooks","issue_events_url":"https://api.github.com/repos/alanhartless/api-library/issues/events{/number}","events_url":"https://api.github.com/repos/alanhartless/api-library/events","assignees_url":"https://api.github.com/repos/alanhartless/api-library/assignees{/user}","branches_url":"https://api.github.com/repos/alanhartless/api-library/branches{/branch}","tags_url":"https://api.github.com/repos/alanhartless/api-library/tags","blobs_url":"https://api.github.com/repos/alanhartless/api-library/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alanhartless/api-library/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alanhartless/api-library/git/refs{/sha}","trees_url":"https://api.github.com/repos/alanhartless/api-library/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alanhartless/api-library/statuses/{sha}","languages_url":"https://api.github.com/repos/alanhartless/api-library/languages","stargazers_url":"https://api.github.com/repos/alanhartless/api-library/stargazers","contributors_url":"https://api.github.com/repos/alanhartless/api-library/contributors","subscribers_url":"https://api.github.com/repos/alanhartless/api-library/subscribers","subscription_url":"https://api.github.com/repos/alanhartless/api-library/subscription","commits_url":"https://api.github.com/repos/alanhartless/api-library/commits{/sha}","git_commits_url":"https://api.github.com/repos/alanhartless/api-library/git/commits{/sha}","comments_url":"https://api.github.com/repos/alanhartless/api-library/comments{/number}","issue_comment_url":"https://api.github.com/repos/alanhartless/api-library/issues/comments{/number}","contents_url":"https://api.github.com/repos/alanhartless/api-library/contents/{+path}","compare_url":"https://api.github.com/repos/alanhartless/api-library/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alanhartless/api-library/merges","archive_url":"https://api.github.com/repos/alanhartless/api-library/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alanhartless/api-library/downloads","issues_url":"https://api.github.com/repos/alanhartless/api-library/issues{/number}","pulls_url":"https://api.github.com/repos/alanhartless/api-library/pulls{/number}","milestones_url":"https://api.github.com/repos/alanhartless/api-library/milestones{/number}","notifications_url":"https://api.github.com/repos/alanhartless/api-library/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alanhartless/api-library/labels{/name}","releases_url":"https://api.github.com/repos/alanhartless/api-library/releases{/id}","created_at":"2015-03-12T18:13:41Z","updated_at":"2015-03-13T15:42:04Z","pushed_at":"2015-06-19T17:05:42Z","git_url":"git://github.com/alanhartless/api-library.git","ssh_url":"git@github.com:alanhartless/api-library.git","clone_url":"https://github.com/alanhartless/api-library.git","svn_url":"https://github.com/alanhartless/api-library","homepage":null,"size":450,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mautic:master","ref":"master","sha":"1c59044e4ae07e3deda994318073ad6bb516e016","user":{"login":"mautic","id":5257677,"avatar_url":"https://avatars.githubusercontent.com/u/5257677?v=3","gravatar_id":"","url":"https://api.github.com/users/mautic","html_url":"https://github.com/mautic","followers_url":"https://api.github.com/users/mautic/followers","following_url":"https://api.github.com/users/mautic/following{/other_user}","gists_url":"https://api.github.com/users/mautic/gists{/gist_id}","starred_url":"https://api.github.com/users/mautic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mautic/subscriptions","organizations_url":"https://api.github.com/users/mautic/orgs","repos_url":"https://api.github.com/users/mautic/repos","events_url":"https://api.github.com/users/mautic/events{/privacy}","received_events_url":"https://api.github.com/users/mautic/received_events","type":"Organization","site_admin":false},"repo":{"id":29319882,"name":"api-library","full_name":"mautic/api-library","owner":{"login":"mautic","id":5257677,"avatar_url":"https://avatars.githubusercontent.com/u/5257677?v=3","gravatar_id":"","url":"https://api.github.com/users/mautic","html_url":"https://github.com/mautic","followers_url":"https://api.github.com/users/mautic/followers","following_url":"https://api.github.com/users/mautic/following{/other_user}","gists_url":"https://api.github.com/users/mautic/gists{/gist_id}","starred_url":"https://api.github.com/users/mautic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mautic/subscriptions","organizations_url":"https://api.github.com/users/mautic/orgs","repos_url":"https://api.github.com/users/mautic/repos","events_url":"https://api.github.com/users/mautic/events{/privacy}","received_events_url":"https://api.github.com/users/mautic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mautic/api-library","description":"Mautic API Library","fork":false,"url":"https://api.github.com/repos/mautic/api-library","forks_url":"https://api.github.com/repos/mautic/api-library/forks","keys_url":"https://api.github.com/repos/mautic/api-library/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mautic/api-library/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mautic/api-library/teams","hooks_url":"https://api.github.com/repos/mautic/api-library/hooks","issue_events_url":"https://api.github.com/repos/mautic/api-library/issues/events{/number}","events_url":"https://api.github.com/repos/mautic/api-library/events","assignees_url":"https://api.github.com/repos/mautic/api-library/assignees{/user}","branches_url":"https://api.github.com/repos/mautic/api-library/branches{/branch}","tags_url":"https://api.github.com/repos/mautic/api-library/tags","blobs_url":"https://api.github.com/repos/mautic/api-library/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mautic/api-library/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mautic/api-library/git/refs{/sha}","trees_url":"https://api.github.com/repos/mautic/api-library/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mautic/api-library/statuses/{sha}","languages_url":"https://api.github.com/repos/mautic/api-library/languages","stargazers_url":"https://api.github.com/repos/mautic/api-library/stargazers","contributors_url":"https://api.github.com/repos/mautic/api-library/contributors","subscribers_url":"https://api.github.com/repos/mautic/api-library/subscribers","subscription_url":"https://api.github.com/repos/mautic/api-library/subscription","commits_url":"https://api.github.com/repos/mautic/api-library/commits{/sha}","git_commits_url":"https://api.github.com/repos/mautic/api-library/git/commits{/sha}","comments_url":"https://api.github.com/repos/mautic/api-library/comments{/number}","issue_comment_url":"https://api.github.com/repos/mautic/api-library/issues/comments{/number}","contents_url":"https://api.github.com/repos/mautic/api-library/contents/{+path}","compare_url":"https://api.github.com/repos/mautic/api-library/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mautic/api-library/merges","archive_url":"https://api.github.com/repos/mautic/api-library/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mautic/api-library/downloads","issues_url":"https://api.github.com/repos/mautic/api-library/issues{/number}","pulls_url":"https://api.github.com/repos/mautic/api-library/pulls{/number}","milestones_url":"https://api.github.com/repos/mautic/api-library/milestones{/number}","notifications_url":"https://api.github.com/repos/mautic/api-library/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mautic/api-library/labels{/name}","releases_url":"https://api.github.com/repos/mautic/api-library/releases{/id}","created_at":"2015-01-15T21:48:57Z","updated_at":"2015-04-20T13:50:19Z","pushed_at":"2015-06-19T17:40:29Z","git_url":"git://github.com/mautic/api-library.git","ssh_url":"git@github.com:mautic/api-library.git","clone_url":"https://github.com/mautic/api-library.git","svn_url":"https://github.com/mautic/api-library","homepage":null,"size":572,"stargazers_count":3,"watchers_count":3,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":0,"forks":4,"open_issues":0,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mautic/api-library/pulls/10"},"html":{"href":"https://github.com/mautic/api-library/pull/10"},"issue":{"href":"https://api.github.com/repos/mautic/api-library/issues/10"},"comments":{"href":"https://api.github.com/repos/mautic/api-library/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/mautic/api-library/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/mautic/api-library/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mautic/api-library/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/mautic/api-library/statuses/74a150a9c5c50de389c74834096c7f8a6798c6ed"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"escopecz","id":1235442,"avatar_url":"https://avatars.githubusercontent.com/u/1235442?v=3","gravatar_id":"","url":"https://api.github.com/users/escopecz","html_url":"https://github.com/escopecz","followers_url":"https://api.github.com/users/escopecz/followers","following_url":"https://api.github.com/users/escopecz/following{/other_user}","gists_url":"https://api.github.com/users/escopecz/gists{/gist_id}","starred_url":"https://api.github.com/users/escopecz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/escopecz/subscriptions","organizations_url":"https://api.github.com/users/escopecz/orgs","repos_url":"https://api.github.com/users/escopecz/repos","events_url":"https://api.github.com/users/escopecz/events{/privacy}","received_events_url":"https://api.github.com/users/escopecz/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":2,"additions":8,"deletions":3,"changed_files":1}}