{"action":"closed","number":1,"pull_request":{"url":"https://api.github.com/repos/meejah/txaio/pulls/1","id":31497907,"html_url":"https://github.com/meejah/txaio/pull/1","diff_url":"https://github.com/meejah/txaio/pull/1.diff","patch_url":"https://github.com/meejah/txaio/pull/1.patch","issue_url":"https://api.github.com/repos/meejah/txaio/issues/1","number":1,"state":"closed","locked":false,"title":"API ideas","user":{"login":"meejah","id":145599,"avatar_url":"https://avatars.githubusercontent.com/u/145599?v=3","gravatar_id":"","url":"https://api.github.com/users/meejah","html_url":"https://github.com/meejah","followers_url":"https://api.github.com/users/meejah/followers","following_url":"https://api.github.com/users/meejah/following{/other_user}","gists_url":"https://api.github.com/users/meejah/gists{/gist_id}","starred_url":"https://api.github.com/users/meejah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meejah/subscriptions","organizations_url":"https://api.github.com/users/meejah/orgs","repos_url":"https://api.github.com/users/meejah/repos","events_url":"https://api.github.com/users/meejah/events{/privacy}","received_events_url":"https://api.github.com/users/meejah/received_events","type":"User","site_admin":false},"body":"(Note: this PR is intended to be closed; here for diff-viewing purposes).\r\n\r\nAfter some brief feedback on #twisted, I've tried to simplify the API a little (some suggested it was \"too wordy\"). There was also suggestions to provide a non-magic, simple wrapper around the Future or Deferred (e.g. so you can call ``.add_callbacks`` on it).\r\n\r\nNote I collapsed ``create_future, create_future_success and create_future_error`` down to a single API with a couple kwargs -- maybe it's better to keep them separate...\r\n\r\nI also took a stab at a Mixin-style API. I prefixed everything with \"promise_\", which hopefully means it's conflict-free for most user-classes. This would be most-like the current Autobahn API...\r\n\r\nI'm very strongly leaning towards calling everything a \"promise\" in the API/docs to lessen the chance of confusion between Future and Deferred, and to make it more-obvious this is its own API and not a \"mere\" compatilibity-wrapper (e.g. giving you Twisted-style API on top of asyncio or vice-versa).\r\n\r\n@oberstet or @hawkowl what do you think?","created_at":"2015-03-19T06:14:03Z","updated_at":"2015-03-23T05:26:53Z","closed_at":"2015-03-23T05:26:53Z","merged_at":null,"merge_commit_sha":"23492454989a7460afbbade722932754a711349b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/meejah/txaio/pulls/1/commits","review_comments_url":"https://api.github.com/repos/meejah/txaio/pulls/1/comments","review_comment_url":"https://api.github.com/repos/meejah/txaio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/meejah/txaio/issues/1/comments","statuses_url":"https://api.github.com/repos/meejah/txaio/statuses/c64948b31ba852a0a804750dcc1db4f4c3bec0fd","head":{"label":"meejah:api-ideas","ref":"api-ideas","sha":"c64948b31ba852a0a804750dcc1db4f4c3bec0fd","user":{"login":"meejah","id":145599,"avatar_url":"https://avatars.githubusercontent.com/u/145599?v=3","gravatar_id":"","url":"https://api.github.com/users/meejah","html_url":"https://github.com/meejah","followers_url":"https://api.github.com/users/meejah/followers","following_url":"https://api.github.com/users/meejah/following{/other_user}","gists_url":"https://api.github.com/users/meejah/gists{/gist_id}","starred_url":"https://api.github.com/users/meejah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meejah/subscriptions","organizations_url":"https://api.github.com/users/meejah/orgs","repos_url":"https://api.github.com/users/meejah/repos","events_url":"https://api.github.com/users/meejah/events{/privacy}","received_events_url":"https://api.github.com/users/meejah/received_events","type":"User","site_admin":false},"repo":{"id":32409295,"name":"txaio","full_name":"meejah/txaio","owner":{"login":"meejah","id":145599,"avatar_url":"https://avatars.githubusercontent.com/u/145599?v=3","gravatar_id":"","url":"https://api.github.com/users/meejah","html_url":"https://github.com/meejah","followers_url":"https://api.github.com/users/meejah/followers","following_url":"https://api.github.com/users/meejah/following{/other_user}","gists_url":"https://api.github.com/users/meejah/gists{/gist_id}","starred_url":"https://api.github.com/users/meejah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meejah/subscriptions","organizations_url":"https://api.github.com/users/meejah/orgs","repos_url":"https://api.github.com/users/meejah/repos","events_url":"https://api.github.com/users/meejah/events{/privacy}","received_events_url":"https://api.github.com/users/meejah/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/meejah/txaio","description":"Utilities to support code that runs unmodified on Twisted and asyncio","fork":true,"url":"https://api.github.com/repos/meejah/txaio","forks_url":"https://api.github.com/repos/meejah/txaio/forks","keys_url":"https://api.github.com/repos/meejah/txaio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/meejah/txaio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/meejah/txaio/teams","hooks_url":"https://api.github.com/repos/meejah/txaio/hooks","issue_events_url":"https://api.github.com/repos/meejah/txaio/issues/events{/number}","events_url":"https://api.github.com/repos/meejah/txaio/events","assignees_url":"https://api.github.com/repos/meejah/txaio/assignees{/user}","branches_url":"https://api.github.com/repos/meejah/txaio/branches{/branch}","tags_url":"https://api.github.com/repos/meejah/txaio/tags","blobs_url":"https://api.github.com/repos/meejah/txaio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/meejah/txaio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/meejah/txaio/git/refs{/sha}","trees_url":"https://api.github.com/repos/meejah/txaio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/meejah/txaio/statuses/{sha}","languages_url":"https://api.github.com/repos/meejah/txaio/languages","stargazers_url":"https://api.github.com/repos/meejah/txaio/stargazers","contributors_url":"https://api.github.com/repos/meejah/txaio/contributors","subscribers_url":"https://api.github.com/repos/meejah/txaio/subscribers","subscription_url":"https://api.github.com/repos/meejah/txaio/subscription","commits_url":"https://api.github.com/repos/meejah/txaio/commits{/sha}","git_commits_url":"https://api.github.com/repos/meejah/txaio/git/commits{/sha}","comments_url":"https://api.github.com/repos/meejah/txaio/comments{/number}","issue_comment_url":"https://api.github.com/repos/meejah/txaio/issues/comments{/number}","contents_url":"https://api.github.com/repos/meejah/txaio/contents/{+path}","compare_url":"https://api.github.com/repos/meejah/txaio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/meejah/txaio/merges","archive_url":"https://api.github.com/repos/meejah/txaio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/meejah/txaio/downloads","issues_url":"https://api.github.com/repos/meejah/txaio/issues{/number}","pulls_url":"https://api.github.com/repos/meejah/txaio/pulls{/number}","milestones_url":"https://api.github.com/repos/meejah/txaio/milestones{/number}","notifications_url":"https://api.github.com/repos/meejah/txaio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/meejah/txaio/labels{/name}","releases_url":"https://api.github.com/repos/meejah/txaio/releases{/id}","created_at":"2015-03-17T17:31:52Z","updated_at":"2015-03-19T06:20:50Z","pushed_at":"2015-03-23T05:25:50Z","git_url":"git://github.com/meejah/txaio.git","ssh_url":"git@github.com:meejah/txaio.git","clone_url":"https://github.com/meejah/txaio.git","svn_url":"https://github.com/meejah/txaio","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"meejah:master","ref":"master","sha":"3893fdd7c5172095bbf0456191ee034960f8eeaa","user":{"login":"meejah","id":145599,"avatar_url":"https://avatars.githubusercontent.com/u/145599?v=3","gravatar_id":"","url":"https://api.github.com/users/meejah","html_url":"https://github.com/meejah","followers_url":"https://api.github.com/users/meejah/followers","following_url":"https://api.github.com/users/meejah/following{/other_user}","gists_url":"https://api.github.com/users/meejah/gists{/gist_id}","starred_url":"https://api.github.com/users/meejah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meejah/subscriptions","organizations_url":"https://api.github.com/users/meejah/orgs","repos_url":"https://api.github.com/users/meejah/repos","events_url":"https://api.github.com/users/meejah/events{/privacy}","received_events_url":"https://api.github.com/users/meejah/received_events","type":"User","site_admin":false},"repo":{"id":32409295,"name":"txaio","full_name":"meejah/txaio","owner":{"login":"meejah","id":145599,"avatar_url":"https://avatars.githubusercontent.com/u/145599?v=3","gravatar_id":"","url":"https://api.github.com/users/meejah","html_url":"https://github.com/meejah","followers_url":"https://api.github.com/users/meejah/followers","following_url":"https://api.github.com/users/meejah/following{/other_user}","gists_url":"https://api.github.com/users/meejah/gists{/gist_id}","starred_url":"https://api.github.com/users/meejah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meejah/subscriptions","organizations_url":"https://api.github.com/users/meejah/orgs","repos_url":"https://api.github.com/users/meejah/repos","events_url":"https://api.github.com/users/meejah/events{/privacy}","received_events_url":"https://api.github.com/users/meejah/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/meejah/txaio","description":"Utilities to support code that runs unmodified on Twisted and asyncio","fork":true,"url":"https://api.github.com/repos/meejah/txaio","forks_url":"https://api.github.com/repos/meejah/txaio/forks","keys_url":"https://api.github.com/repos/meejah/txaio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/meejah/txaio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/meejah/txaio/teams","hooks_url":"https://api.github.com/repos/meejah/txaio/hooks","issue_events_url":"https://api.github.com/repos/meejah/txaio/issues/events{/number}","events_url":"https://api.github.com/repos/meejah/txaio/events","assignees_url":"https://api.github.com/repos/meejah/txaio/assignees{/user}","branches_url":"https://api.github.com/repos/meejah/txaio/branches{/branch}","tags_url":"https://api.github.com/repos/meejah/txaio/tags","blobs_url":"https://api.github.com/repos/meejah/txaio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/meejah/txaio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/meejah/txaio/git/refs{/sha}","trees_url":"https://api.github.com/repos/meejah/txaio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/meejah/txaio/statuses/{sha}","languages_url":"https://api.github.com/repos/meejah/txaio/languages","stargazers_url":"https://api.github.com/repos/meejah/txaio/stargazers","contributors_url":"https://api.github.com/repos/meejah/txaio/contributors","subscribers_url":"https://api.github.com/repos/meejah/txaio/subscribers","subscription_url":"https://api.github.com/repos/meejah/txaio/subscription","commits_url":"https://api.github.com/repos/meejah/txaio/commits{/sha}","git_commits_url":"https://api.github.com/repos/meejah/txaio/git/commits{/sha}","comments_url":"https://api.github.com/repos/meejah/txaio/comments{/number}","issue_comment_url":"https://api.github.com/repos/meejah/txaio/issues/comments{/number}","contents_url":"https://api.github.com/repos/meejah/txaio/contents/{+path}","compare_url":"https://api.github.com/repos/meejah/txaio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/meejah/txaio/merges","archive_url":"https://api.github.com/repos/meejah/txaio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/meejah/txaio/downloads","issues_url":"https://api.github.com/repos/meejah/txaio/issues{/number}","pulls_url":"https://api.github.com/repos/meejah/txaio/pulls{/number}","milestones_url":"https://api.github.com/repos/meejah/txaio/milestones{/number}","notifications_url":"https://api.github.com/repos/meejah/txaio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/meejah/txaio/labels{/name}","releases_url":"https://api.github.com/repos/meejah/txaio/releases{/id}","created_at":"2015-03-17T17:31:52Z","updated_at":"2015-03-19T06:20:50Z","pushed_at":"2015-03-23T05:25:50Z","git_url":"git://github.com/meejah/txaio.git","ssh_url":"git@github.com:meejah/txaio.git","clone_url":"https://github.com/meejah/txaio.git","svn_url":"https://github.com/meejah/txaio","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/meejah/txaio/pulls/1"},"html":{"href":"https://github.com/meejah/txaio/pull/1"},"issue":{"href":"https://api.github.com/repos/meejah/txaio/issues/1"},"comments":{"href":"https://api.github.com/repos/meejah/txaio/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/meejah/txaio/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/meejah/txaio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/meejah/txaio/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/meejah/txaio/statuses/c64948b31ba852a0a804750dcc1db4f4c3bec0fd"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":7,"review_comments":0,"commits":2,"additions":98,"deletions":3,"changed_files":3}}