{"action":"created","comment":{"url":"https://api.github.com/repos/elixir-lang/elixir/pulls/comments/39922848","id":39922848,"diff_hunk":"@@ -229,9 +229,18 @@ defmodule Mix.Tasks.Test do\n   end\n \n   defp parse_files([], test_paths) do\n+    warn_about_incorrect_extensions_in(test_paths)\n+\n     test_paths\n   end\n \n+  defp warn_about_incorrect_extensions_in(test_paths) do\n+    for file <- Mix.Utils.extract_files(test_paths, \"*_test.ex\") do\n+      IO.puts \"Warning: #{file} has incorrect extension and won't be run. \" <>","path":"lib/mix/lib/mix/tasks/test.ex","position":11,"original_position":11,"commit_id":"fbc2c0f2b5c7a233c1dd622d861f37776f2234fc","original_commit_id":"fbc2c0f2b5c7a233c1dd622d861f37776f2234fc","user":{"login":"lexmag","id":248290,"avatar_url":"https://avatars.githubusercontent.com/u/248290?v=3","gravatar_id":"","url":"https://api.github.com/users/lexmag","html_url":"https://github.com/lexmag","followers_url":"https://api.github.com/users/lexmag/followers","following_url":"https://api.github.com/users/lexmag/following{/other_user}","gists_url":"https://api.github.com/users/lexmag/gists{/gist_id}","starred_url":"https://api.github.com/users/lexmag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lexmag/subscriptions","organizations_url":"https://api.github.com/users/lexmag/orgs","repos_url":"https://api.github.com/users/lexmag/repos","events_url":"https://api.github.com/users/lexmag/events{/privacy}","received_events_url":"https://api.github.com/users/lexmag/received_events","type":"User","site_admin":false},"body":"@paulcsmith `Mix.shell.(info|error)` is preferable in almost every situation inside mix tasks. The main difference is that `Mix.shell` can be replaced, might be useful for mix-only output handling. Another thing is that default `Mix.Shell.IO` will print application in which `Mix.shell.(info|error)` call happens, important for umbrella applications.\r\nThere are some relevant commits for it from last 2 weeks: https://github.com/elixir-lang/elixir/commit/f858ccf205302f14abd14536c106e97a248a79cf, https://github.com/elixir-lang/elixir/commit/21ff94de1f5df137f8bbb061ab0d6979831daac8.\r\n\r\nSorry for late reply, was away from the computer last 2 days. :smile: ","created_at":"2015-09-19T19:24:18Z","updated_at":"2015-09-19T19:24:18Z","html_url":"https://github.com/elixir-lang/elixir/pull/3750#discussion_r39922848","pull_request_url":"https://api.github.com/repos/elixir-lang/elixir/pulls/3750","_links":{"self":{"href":"https://api.github.com/repos/elixir-lang/elixir/pulls/comments/39922848"},"html":{"href":"https://github.com/elixir-lang/elixir/pull/3750#discussion_r39922848"},"pull_request":{"href":"https://api.github.com/repos/elixir-lang/elixir/pulls/3750"}}},"pull_request":{"url":"https://api.github.com/repos/elixir-lang/elixir/pulls/3750","id":45345397,"html_url":"https://github.com/elixir-lang/elixir/pull/3750","diff_url":"https://github.com/elixir-lang/elixir/pull/3750.diff","patch_url":"https://github.com/elixir-lang/elixir/pull/3750.patch","issue_url":"https://api.github.com/repos/elixir-lang/elixir/issues/3750","number":3750,"state":"open","locked":false,"title":"Warn when test files have incorrect extension","user":{"login":"paulcsmith","id":22394,"avatar_url":"https://avatars.githubusercontent.com/u/22394?v=3","gravatar_id":"","url":"https://api.github.com/users/paulcsmith","html_url":"https://github.com/paulcsmith","followers_url":"https://api.github.com/users/paulcsmith/followers","following_url":"https://api.github.com/users/paulcsmith/following{/other_user}","gists_url":"https://api.github.com/users/paulcsmith/gists{/gist_id}","starred_url":"https://api.github.com/users/paulcsmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulcsmith/subscriptions","organizations_url":"https://api.github.com/users/paulcsmith/orgs","repos_url":"https://api.github.com/users/paulcsmith/repos","events_url":"https://api.github.com/users/paulcsmith/events{/privacy}","received_events_url":"https://api.github.com/users/paulcsmith/received_events","type":"User","site_admin":false},"body":"[ExUnit: Raise or warn if there are files in the test directory that end in `_test.ex` - in Google groups](https://groups.google.com/forum/?utm_medium=email&utm_source=footer#!msg/elixir-lang-core/yfWemHZfiq0/Dj5NBuILDAAJ)\r\n\r\nI believe this will work, but I couldn't figure out how to test it. It seems that `make test` does not use the mix task. I'm opening this up and hoping someone could offer some guidance on how to test this. I can finish it up tomorrow once I know how to check if it's working :)","created_at":"2015-09-17T21:38:56Z","updated_at":"2015-09-19T19:24:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"31cf0794a6678faed6a06c03a98eeb7ef46957be","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/elixir-lang/elixir/pulls/3750/commits","review_comments_url":"https://api.github.com/repos/elixir-lang/elixir/pulls/3750/comments","review_comment_url":"https://api.github.com/repos/elixir-lang/elixir/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elixir-lang/elixir/issues/3750/comments","statuses_url":"https://api.github.com/repos/elixir-lang/elixir/statuses/fbc2c0f2b5c7a233c1dd622d861f37776f2234fc","head":{"label":"paulcsmith:ps-warn-about-no-exs","ref":"ps-warn-about-no-exs","sha":"fbc2c0f2b5c7a233c1dd622d861f37776f2234fc","user":{"login":"paulcsmith","id":22394,"avatar_url":"https://avatars.githubusercontent.com/u/22394?v=3","gravatar_id":"","url":"https://api.github.com/users/paulcsmith","html_url":"https://github.com/paulcsmith","followers_url":"https://api.github.com/users/paulcsmith/followers","following_url":"https://api.github.com/users/paulcsmith/following{/other_user}","gists_url":"https://api.github.com/users/paulcsmith/gists{/gist_id}","starred_url":"https://api.github.com/users/paulcsmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulcsmith/subscriptions","organizations_url":"https://api.github.com/users/paulcsmith/orgs","repos_url":"https://api.github.com/users/paulcsmith/repos","events_url":"https://api.github.com/users/paulcsmith/events{/privacy}","received_events_url":"https://api.github.com/users/paulcsmith/received_events","type":"User","site_admin":false},"repo":{"id":32413345,"name":"elixir","full_name":"paulcsmith/elixir","owner":{"login":"paulcsmith","id":22394,"avatar_url":"https://avatars.githubusercontent.com/u/22394?v=3","gravatar_id":"","url":"https://api.github.com/users/paulcsmith","html_url":"https://github.com/paulcsmith","followers_url":"https://api.github.com/users/paulcsmith/followers","following_url":"https://api.github.com/users/paulcsmith/following{/other_user}","gists_url":"https://api.github.com/users/paulcsmith/gists{/gist_id}","starred_url":"https://api.github.com/users/paulcsmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulcsmith/subscriptions","organizations_url":"https://api.github.com/users/paulcsmith/orgs","repos_url":"https://api.github.com/users/paulcsmith/repos","events_url":"https://api.github.com/users/paulcsmith/events{/privacy}","received_events_url":"https://api.github.com/users/paulcsmith/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/paulcsmith/elixir","description":"Elixir is a dynamic, functional language designed for building scalable and maintainable applications","fork":true,"url":"https://api.github.com/repos/paulcsmith/elixir","forks_url":"https://api.github.com/repos/paulcsmith/elixir/forks","keys_url":"https://api.github.com/repos/paulcsmith/elixir/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paulcsmith/elixir/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paulcsmith/elixir/teams","hooks_url":"https://api.github.com/repos/paulcsmith/elixir/hooks","issue_events_url":"https://api.github.com/repos/paulcsmith/elixir/issues/events{/number}","events_url":"https://api.github.com/repos/paulcsmith/elixir/events","assignees_url":"https://api.github.com/repos/paulcsmith/elixir/assignees{/user}","branches_url":"https://api.github.com/repos/paulcsmith/elixir/branches{/branch}","tags_url":"https://api.github.com/repos/paulcsmith/elixir/tags","blobs_url":"https://api.github.com/repos/paulcsmith/elixir/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paulcsmith/elixir/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paulcsmith/elixir/git/refs{/sha}","trees_url":"https://api.github.com/repos/paulcsmith/elixir/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paulcsmith/elixir/statuses/{sha}","languages_url":"https://api.github.com/repos/paulcsmith/elixir/languages","stargazers_url":"https://api.github.com/repos/paulcsmith/elixir/stargazers","contributors_url":"https://api.github.com/repos/paulcsmith/elixir/contributors","subscribers_url":"https://api.github.com/repos/paulcsmith/elixir/subscribers","subscription_url":"https://api.github.com/repos/paulcsmith/elixir/subscription","commits_url":"https://api.github.com/repos/paulcsmith/elixir/commits{/sha}","git_commits_url":"https://api.github.com/repos/paulcsmith/elixir/git/commits{/sha}","comments_url":"https://api.github.com/repos/paulcsmith/elixir/comments{/number}","issue_comment_url":"https://api.github.com/repos/paulcsmith/elixir/issues/comments{/number}","contents_url":"https://api.github.com/repos/paulcsmith/elixir/contents/{+path}","compare_url":"https://api.github.com/repos/paulcsmith/elixir/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paulcsmith/elixir/merges","archive_url":"https://api.github.com/repos/paulcsmith/elixir/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paulcsmith/elixir/downloads","issues_url":"https://api.github.com/repos/paulcsmith/elixir/issues{/number}","pulls_url":"https://api.github.com/repos/paulcsmith/elixir/pulls{/number}","milestones_url":"https://api.github.com/repos/paulcsmith/elixir/milestones{/number}","notifications_url":"https://api.github.com/repos/paulcsmith/elixir/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paulcsmith/elixir/labels{/name}","releases_url":"https://api.github.com/repos/paulcsmith/elixir/releases{/id}","created_at":"2015-03-17T18:48:52Z","updated_at":"2015-03-17T18:48:54Z","pushed_at":"2015-09-18T01:11:05Z","git_url":"git://github.com/paulcsmith/elixir.git","ssh_url":"git@github.com:paulcsmith/elixir.git","clone_url":"https://github.com/paulcsmith/elixir.git","svn_url":"https://github.com/paulcsmith/elixir","homepage":"http://elixir-lang.org/","size":28797,"stargazers_count":0,"watchers_count":0,"language":"Elixir","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elixir-lang:master","ref":"master","sha":"b1088475a2f1fff4f2bb4a995c8f511befa77dd0","user":{"login":"elixir-lang","id":1481354,"avatar_url":"https://avatars.githubusercontent.com/u/1481354?v=3","gravatar_id":"","url":"https://api.github.com/users/elixir-lang","html_url":"https://github.com/elixir-lang","followers_url":"https://api.github.com/users/elixir-lang/followers","following_url":"https://api.github.com/users/elixir-lang/following{/other_user}","gists_url":"https://api.github.com/users/elixir-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/elixir-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elixir-lang/subscriptions","organizations_url":"https://api.github.com/users/elixir-lang/orgs","repos_url":"https://api.github.com/users/elixir-lang/repos","events_url":"https://api.github.com/users/elixir-lang/events{/privacy}","received_events_url":"https://api.github.com/users/elixir-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":1234714,"name":"elixir","full_name":"elixir-lang/elixir","owner":{"login":"elixir-lang","id":1481354,"avatar_url":"https://avatars.githubusercontent.com/u/1481354?v=3","gravatar_id":"","url":"https://api.github.com/users/elixir-lang","html_url":"https://github.com/elixir-lang","followers_url":"https://api.github.com/users/elixir-lang/followers","following_url":"https://api.github.com/users/elixir-lang/following{/other_user}","gists_url":"https://api.github.com/users/elixir-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/elixir-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elixir-lang/subscriptions","organizations_url":"https://api.github.com/users/elixir-lang/orgs","repos_url":"https://api.github.com/users/elixir-lang/repos","events_url":"https://api.github.com/users/elixir-lang/events{/privacy}","received_events_url":"https://api.github.com/users/elixir-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elixir-lang/elixir","description":"Elixir is a dynamic, functional language designed for building scalable and maintainable applications","fork":false,"url":"https://api.github.com/repos/elixir-lang/elixir","forks_url":"https://api.github.com/repos/elixir-lang/elixir/forks","keys_url":"https://api.github.com/repos/elixir-lang/elixir/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elixir-lang/elixir/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elixir-lang/elixir/teams","hooks_url":"https://api.github.com/repos/elixir-lang/elixir/hooks","issue_events_url":"https://api.github.com/repos/elixir-lang/elixir/issues/events{/number}","events_url":"https://api.github.com/repos/elixir-lang/elixir/events","assignees_url":"https://api.github.com/repos/elixir-lang/elixir/assignees{/user}","branches_url":"https://api.github.com/repos/elixir-lang/elixir/branches{/branch}","tags_url":"https://api.github.com/repos/elixir-lang/elixir/tags","blobs_url":"https://api.github.com/repos/elixir-lang/elixir/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elixir-lang/elixir/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elixir-lang/elixir/git/refs{/sha}","trees_url":"https://api.github.com/repos/elixir-lang/elixir/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elixir-lang/elixir/statuses/{sha}","languages_url":"https://api.github.com/repos/elixir-lang/elixir/languages","stargazers_url":"https://api.github.com/repos/elixir-lang/elixir/stargazers","contributors_url":"https://api.github.com/repos/elixir-lang/elixir/contributors","subscribers_url":"https://api.github.com/repos/elixir-lang/elixir/subscribers","subscription_url":"https://api.github.com/repos/elixir-lang/elixir/subscription","commits_url":"https://api.github.com/repos/elixir-lang/elixir/commits{/sha}","git_commits_url":"https://api.github.com/repos/elixir-lang/elixir/git/commits{/sha}","comments_url":"https://api.github.com/repos/elixir-lang/elixir/comments{/number}","issue_comment_url":"https://api.github.com/repos/elixir-lang/elixir/issues/comments{/number}","contents_url":"https://api.github.com/repos/elixir-lang/elixir/contents/{+path}","compare_url":"https://api.github.com/repos/elixir-lang/elixir/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elixir-lang/elixir/merges","archive_url":"https://api.github.com/repos/elixir-lang/elixir/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elixir-lang/elixir/downloads","issues_url":"https://api.github.com/repos/elixir-lang/elixir/issues{/number}","pulls_url":"https://api.github.com/repos/elixir-lang/elixir/pulls{/number}","milestones_url":"https://api.github.com/repos/elixir-lang/elixir/milestones{/number}","notifications_url":"https://api.github.com/repos/elixir-lang/elixir/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elixir-lang/elixir/labels{/name}","releases_url":"https://api.github.com/repos/elixir-lang/elixir/releases{/id}","created_at":"2011-01-09T08:43:57Z","updated_at":"2015-09-19T17:42:12Z","pushed_at":"2015-09-19T17:37:44Z","git_url":"git://github.com/elixir-lang/elixir.git","ssh_url":"git@github.com:elixir-lang/elixir.git","clone_url":"https://github.com/elixir-lang/elixir.git","svn_url":"https://github.com/elixir-lang/elixir","homepage":"http://elixir-lang.org/","size":50594,"stargazers_count":4808,"watchers_count":4808,"language":"Elixir","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":665,"mirror_url":null,"open_issues_count":51,"forks":665,"open_issues":51,"watchers":4808,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elixir-lang/elixir/pulls/3750"},"html":{"href":"https://github.com/elixir-lang/elixir/pull/3750"},"issue":{"href":"https://api.github.com/repos/elixir-lang/elixir/issues/3750"},"comments":{"href":"https://api.github.com/repos/elixir-lang/elixir/issues/3750/comments"},"review_comments":{"href":"https://api.github.com/repos/elixir-lang/elixir/pulls/3750/comments"},"review_comment":{"href":"https://api.github.com/repos/elixir-lang/elixir/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elixir-lang/elixir/pulls/3750/commits"},"statuses":{"href":"https://api.github.com/repos/elixir-lang/elixir/statuses/fbc2c0f2b5c7a233c1dd622d861f37776f2234fc"}}}}