{"action":"created","comment":{"url":"https://api.github.com/repos/d3athrow/vgstation13/pulls/comments/33408669","id":33408669,"diff_hunk":"@@ -1,142 +1,125 @@\n /datum/smelting_recipe\n-\tvar/name=\"\"\n-\tvar/list/ingredients=list() // phazon=1, iron=1\n-\tvar/yieldtype=null\n+\tvar/name= \"\"\n+\tvar/list/ingredients[0]\n+\tvar/yieldtype = null\n \n // Note: Returns -1 if not enough ore!\n /datum/smelting_recipe/proc/checkIngredients(var/obj/machinery/mineral/processing_unit/P)\n-\tvar/sufficient_ore=1\n-\tvar/matching_ingredient_count=0\n \tfor(var/ore_id in P.ore.storage)\n-\t\tvar/required=(ore_id in ingredients)\n-\t\tvar/selected=(ore_id in P.selected)\n+\t\tvar/min_ore_required = ingredients[ore_id]\n \n-\t\t// Selected but not in ingredients\n-\t\tif(selected && !required)\n+\t\tif(P.ore.getAmount(ore_id) < min_ore_required)\n \t\t\treturn 0\n \n-\t\t// Unselected but in ingredients\n-\t\tif(!selected && required)\n-\t\t\treturn 0\n-\n-\t\tvar/min_ore_required=ingredients[ore_id]\n-\n-\t\t// Selected, in ingredients, but not enough in stock.\n-\t\tif(selected && required)\n-\t\t\tif(P.ore.storage[ore_id] < min_ore_required)\n-\t\t\t\tsufficient_ore=0\n-\t\t\t\tcontinue\n-\n-\t\t\tmatching_ingredient_count++\n-\n-\tif(!sufficient_ore)\n-\t\treturn -1 // -1 means not enough ore. NOT A TYPO.\n-\n-\treturn matching_ingredient_count == ingredients.len\n+\t. = 1\n \n // RECIPES BEEP BOOP\n /datum/smelting_recipe/glass\n-\tname=\"Glass\"\n+\tname = \"Glass\"\n \tingredients=list(\n-\t\tMAT_GLASS=1\n+\t\tMAT_GLASS = 1\n \t)\n-\tyieldtype=/obj/item/stack/sheet/glass/glass\n+\tyieldtype = /obj/item/stack/sheet/glass/glass\n \n+/*","path":"code/modules/mining/smelting.dm","position":null,"original_position":54,"commit_id":"6656242ded03c1c4f8b71d9528fd5c6c6c703c4e","original_commit_id":"7748d1e339a64982efd35ed1ded80b06935babd4","user":{"login":"Exxion","id":9827785,"avatar_url":"https://avatars.githubusercontent.com/u/9827785?v=3","gravatar_id":"","url":"https://api.github.com/users/Exxion","html_url":"https://github.com/Exxion","followers_url":"https://api.github.com/users/Exxion/followers","following_url":"https://api.github.com/users/Exxion/following{/other_user}","gists_url":"https://api.github.com/users/Exxion/gists{/gist_id}","starred_url":"https://api.github.com/users/Exxion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Exxion/subscriptions","organizations_url":"https://api.github.com/users/Exxion/orgs","repos_url":"https://api.github.com/users/Exxion/repos","events_url":"https://api.github.com/users/Exxion/events{/privacy}","received_events_url":"https://api.github.com/users/Exxion/received_events","type":"User","site_admin":false},"body":"I could be wrong, but I think it works the other way, too\r\nYou get a full metal sheet from smelting a rod\r\n...Maybe","created_at":"2015-06-27T02:43:53Z","updated_at":"2015-06-27T02:43:53Z","html_url":"https://github.com/d3athrow/vgstation13/pull/4285#discussion_r33408669","pull_request_url":"https://api.github.com/repos/d3athrow/vgstation13/pulls/4285","_links":{"self":{"href":"https://api.github.com/repos/d3athrow/vgstation13/pulls/comments/33408669"},"html":{"href":"https://github.com/d3athrow/vgstation13/pull/4285#discussion_r33408669"},"pull_request":{"href":"https://api.github.com/repos/d3athrow/vgstation13/pulls/4285"}}},"pull_request":{"url":"https://api.github.com/repos/d3athrow/vgstation13/pulls/4285","id":34683762,"html_url":"https://github.com/d3athrow/vgstation13/pull/4285","diff_url":"https://github.com/d3athrow/vgstation13/pull/4285.diff","patch_url":"https://github.com/d3athrow/vgstation13/pull/4285.patch","issue_url":"https://api.github.com/repos/d3athrow/vgstation13/issues/4285","number":4285,"state":"open","locked":false,"title":"Recycling & Mining processing machinery things","user":{"login":"PJB3005","id":8107459,"avatar_url":"https://avatars.githubusercontent.com/u/8107459?v=3","gravatar_id":"","url":"https://api.github.com/users/PJB3005","html_url":"https://github.com/PJB3005","followers_url":"https://api.github.com/users/PJB3005/followers","following_url":"https://api.github.com/users/PJB3005/following{/other_user}","gists_url":"https://api.github.com/users/PJB3005/gists{/gist_id}","starred_url":"https://api.github.com/users/PJB3005/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PJB3005/subscriptions","organizations_url":"https://api.github.com/users/PJB3005/orgs","repos_url":"https://api.github.com/users/PJB3005/repos","events_url":"https://api.github.com/users/PJB3005/events{/privacy}","received_events_url":"https://api.github.com/users/PJB3005/received_events","type":"User","site_admin":false},"body":"Cleans up & adds stuff to recycling & mining machinery.\r\n\r\n\r\n# Ore processor & Recycling furnace.\r\n* Uses a priority based system for recipes, recipes at the top get done first, and vice versa.\r\n* You can get dosh from it.\r\n* Constructable.\r\n* Console is no longer snowflaky and shit.\r\n\r\n# Stacking machine\r\n* All the above stuff, except for the stacking machine.\r\n\r\n# Sorting Machine\r\n* Cleans up old shitty code, to be up to current coding standards.\r\n * Removes the usage of magic I/O objects.\r\n * Browser datum based UI\r\n * More\r\n* (De)constructable\r\n * Just a board in the circuit imprinter\r\n   * Parts are 3 matter bins and 1 capacitor.\r\n      * Better matter bins can increase the speed up to a max of 3x\r\n      * Better capacitors decrease power usage to up to 50%\r\n * I/O sides configureable with multitool menus.\r\n* Fixes shit\r\n * The UI flatout didn't work, go figure. \r\n * AIs can interact with it now.\r\n\r\n# BELT HELL!\r\n* The idea is to connect the disposals networks of taxi's stations with a mass driver network.\r\n* Destination sorter, which is basically the disposals sorting junctions outside a disposals pipe.\r\n * Constructible and everything.\r\n\r\n# Other stuff\r\n* Disposals sorting & wrap sorting pipes buildable.\r\n* Fixes #4721\r\n* Helps with #4697, janitor closet aint cramped anymore.\r\n* Fixes #5020, except for the shite airlock.\r\n\r\n- [x] Sorting machine\r\n - [x] Code cleanup\r\n - [x] Constructability\r\n- [x] Smelter.\r\n - [x] Code cleanup.\r\n - [x] Constructability.\r\n - [x] RC cleanup.\r\n   - [x] Not stupid with snowflaking and shit like it is now.\r\n - [x] Make it useful.\r\n   - [x] Getting credits from the smelter.\r\n   - [x] Priority system\r\n- [x] Stacking machine.\r\n - [x] Code cleanup.\r\n - [x] Constructability.\r\n - [x] ~~Filtering side for non-stacks.~~\r\n - [x] RC cleanup\r\n   - [x] Not stupid with snowflaking and shit like it is now.\r\n\r\n- [x] BELT HELL!\r\n  - [x] ~~Automatic mass drivers.~~\r\n    - [x] ~~Constructability.~~\r\n    - These were not needed.\r\n  - [x] Destination sorting machine.\r\n    - [x] Constructability.\r\n  - [x] Map taxi so disposals is unified THROUGH BELT HELL! (fixes #4724)","created_at":"2015-05-04T23:00:37Z","updated_at":"2015-06-27T02:43:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"968927a690c7b642e901260cd60614aeaebaa4d2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/d3athrow/vgstation13/pulls/4285/commits","review_comments_url":"https://api.github.com/repos/d3athrow/vgstation13/pulls/4285/comments","review_comment_url":"https://api.github.com/repos/d3athrow/vgstation13/pulls/comments{/number}","comments_url":"https://api.github.com/repos/d3athrow/vgstation13/issues/4285/comments","statuses_url":"https://api.github.com/repos/d3athrow/vgstation13/statuses/6656242ded03c1c4f8b71d9528fd5c6c6c703c4e","head":{"label":"PJB3005:sorted-out","ref":"sorted-out","sha":"6656242ded03c1c4f8b71d9528fd5c6c6c703c4e","user":{"login":"PJB3005","id":8107459,"avatar_url":"https://avatars.githubusercontent.com/u/8107459?v=3","gravatar_id":"","url":"https://api.github.com/users/PJB3005","html_url":"https://github.com/PJB3005","followers_url":"https://api.github.com/users/PJB3005/followers","following_url":"https://api.github.com/users/PJB3005/following{/other_user}","gists_url":"https://api.github.com/users/PJB3005/gists{/gist_id}","starred_url":"https://api.github.com/users/PJB3005/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PJB3005/subscriptions","organizations_url":"https://api.github.com/users/PJB3005/orgs","repos_url":"https://api.github.com/users/PJB3005/repos","events_url":"https://api.github.com/users/PJB3005/events{/privacy}","received_events_url":"https://api.github.com/users/PJB3005/received_events","type":"User","site_admin":false},"repo":{"id":26824993,"name":"vgstation13","full_name":"PJB3005/vgstation13","owner":{"login":"PJB3005","id":8107459,"avatar_url":"https://avatars.githubusercontent.com/u/8107459?v=3","gravatar_id":"","url":"https://api.github.com/users/PJB3005","html_url":"https://github.com/PJB3005","followers_url":"https://api.github.com/users/PJB3005/followers","following_url":"https://api.github.com/users/PJB3005/following{/other_user}","gists_url":"https://api.github.com/users/PJB3005/gists{/gist_id}","starred_url":"https://api.github.com/users/PJB3005/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PJB3005/subscriptions","organizations_url":"https://api.github.com/users/PJB3005/orgs","repos_url":"https://api.github.com/users/PJB3005/repos","events_url":"https://api.github.com/users/PJB3005/events{/privacy}","received_events_url":"https://api.github.com/users/PJB3005/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/PJB3005/vgstation13","description":"This is the vgstation's fork of baystation12's code.","fork":true,"url":"https://api.github.com/repos/PJB3005/vgstation13","forks_url":"https://api.github.com/repos/PJB3005/vgstation13/forks","keys_url":"https://api.github.com/repos/PJB3005/vgstation13/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PJB3005/vgstation13/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PJB3005/vgstation13/teams","hooks_url":"https://api.github.com/repos/PJB3005/vgstation13/hooks","issue_events_url":"https://api.github.com/repos/PJB3005/vgstation13/issues/events{/number}","events_url":"https://api.github.com/repos/PJB3005/vgstation13/events","assignees_url":"https://api.github.com/repos/PJB3005/vgstation13/assignees{/user}","branches_url":"https://api.github.com/repos/PJB3005/vgstation13/branches{/branch}","tags_url":"https://api.github.com/repos/PJB3005/vgstation13/tags","blobs_url":"https://api.github.com/repos/PJB3005/vgstation13/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PJB3005/vgstation13/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PJB3005/vgstation13/git/refs{/sha}","trees_url":"https://api.github.com/repos/PJB3005/vgstation13/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PJB3005/vgstation13/statuses/{sha}","languages_url":"https://api.github.com/repos/PJB3005/vgstation13/languages","stargazers_url":"https://api.github.com/repos/PJB3005/vgstation13/stargazers","contributors_url":"https://api.github.com/repos/PJB3005/vgstation13/contributors","subscribers_url":"https://api.github.com/repos/PJB3005/vgstation13/subscribers","subscription_url":"https://api.github.com/repos/PJB3005/vgstation13/subscription","commits_url":"https://api.github.com/repos/PJB3005/vgstation13/commits{/sha}","git_commits_url":"https://api.github.com/repos/PJB3005/vgstation13/git/commits{/sha}","comments_url":"https://api.github.com/repos/PJB3005/vgstation13/comments{/number}","issue_comment_url":"https://api.github.com/repos/PJB3005/vgstation13/issues/comments{/number}","contents_url":"https://api.github.com/repos/PJB3005/vgstation13/contents/{+path}","compare_url":"https://api.github.com/repos/PJB3005/vgstation13/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PJB3005/vgstation13/merges","archive_url":"https://api.github.com/repos/PJB3005/vgstation13/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PJB3005/vgstation13/downloads","issues_url":"https://api.github.com/repos/PJB3005/vgstation13/issues{/number}","pulls_url":"https://api.github.com/repos/PJB3005/vgstation13/pulls{/number}","milestones_url":"https://api.github.com/repos/PJB3005/vgstation13/milestones{/number}","notifications_url":"https://api.github.com/repos/PJB3005/vgstation13/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PJB3005/vgstation13/labels{/name}","releases_url":"https://api.github.com/repos/PJB3005/vgstation13/releases{/id}","created_at":"2014-11-18T19:01:04Z","updated_at":"2015-06-01T15:04:46Z","pushed_at":"2015-06-26T22:15:03Z","git_url":"git://github.com/PJB3005/vgstation13.git","ssh_url":"git@github.com:PJB3005/vgstation13.git","clone_url":"https://github.com/PJB3005/vgstation13.git","svn_url":"https://github.com/PJB3005/vgstation13","homepage":"","size":1026429,"stargazers_count":1,"watchers_count":1,"language":"DM","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"Bleeding-Edge"}},"base":{"label":"d3athrow:Bleeding-Edge","ref":"Bleeding-Edge","sha":"6b63a2286c331945cecd82cbd81c491c773127b7","user":{"login":"d3athrow","id":706947,"avatar_url":"https://avatars.githubusercontent.com/u/706947?v=3","gravatar_id":"","url":"https://api.github.com/users/d3athrow","html_url":"https://github.com/d3athrow","followers_url":"https://api.github.com/users/d3athrow/followers","following_url":"https://api.github.com/users/d3athrow/following{/other_user}","gists_url":"https://api.github.com/users/d3athrow/gists{/gist_id}","starred_url":"https://api.github.com/users/d3athrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d3athrow/subscriptions","organizations_url":"https://api.github.com/users/d3athrow/orgs","repos_url":"https://api.github.com/users/d3athrow/repos","events_url":"https://api.github.com/users/d3athrow/events{/privacy}","received_events_url":"https://api.github.com/users/d3athrow/received_events","type":"User","site_admin":false},"repo":{"id":10441188,"name":"vgstation13","full_name":"d3athrow/vgstation13","owner":{"login":"d3athrow","id":706947,"avatar_url":"https://avatars.githubusercontent.com/u/706947?v=3","gravatar_id":"","url":"https://api.github.com/users/d3athrow","html_url":"https://github.com/d3athrow","followers_url":"https://api.github.com/users/d3athrow/followers","following_url":"https://api.github.com/users/d3athrow/following{/other_user}","gists_url":"https://api.github.com/users/d3athrow/gists{/gist_id}","starred_url":"https://api.github.com/users/d3athrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d3athrow/subscriptions","organizations_url":"https://api.github.com/users/d3athrow/orgs","repos_url":"https://api.github.com/users/d3athrow/repos","events_url":"https://api.github.com/users/d3athrow/events{/privacy}","received_events_url":"https://api.github.com/users/d3athrow/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/d3athrow/vgstation13","description":"This is the vgstation's fork of baystation12's code.","fork":true,"url":"https://api.github.com/repos/d3athrow/vgstation13","forks_url":"https://api.github.com/repos/d3athrow/vgstation13/forks","keys_url":"https://api.github.com/repos/d3athrow/vgstation13/keys{/key_id}","collaborators_url":"https://api.github.com/repos/d3athrow/vgstation13/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/d3athrow/vgstation13/teams","hooks_url":"https://api.github.com/repos/d3athrow/vgstation13/hooks","issue_events_url":"https://api.github.com/repos/d3athrow/vgstation13/issues/events{/number}","events_url":"https://api.github.com/repos/d3athrow/vgstation13/events","assignees_url":"https://api.github.com/repos/d3athrow/vgstation13/assignees{/user}","branches_url":"https://api.github.com/repos/d3athrow/vgstation13/branches{/branch}","tags_url":"https://api.github.com/repos/d3athrow/vgstation13/tags","blobs_url":"https://api.github.com/repos/d3athrow/vgstation13/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/d3athrow/vgstation13/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/d3athrow/vgstation13/git/refs{/sha}","trees_url":"https://api.github.com/repos/d3athrow/vgstation13/git/trees{/sha}","statuses_url":"https://api.github.com/repos/d3athrow/vgstation13/statuses/{sha}","languages_url":"https://api.github.com/repos/d3athrow/vgstation13/languages","stargazers_url":"https://api.github.com/repos/d3athrow/vgstation13/stargazers","contributors_url":"https://api.github.com/repos/d3athrow/vgstation13/contributors","subscribers_url":"https://api.github.com/repos/d3athrow/vgstation13/subscribers","subscription_url":"https://api.github.com/repos/d3athrow/vgstation13/subscription","commits_url":"https://api.github.com/repos/d3athrow/vgstation13/commits{/sha}","git_commits_url":"https://api.github.com/repos/d3athrow/vgstation13/git/commits{/sha}","comments_url":"https://api.github.com/repos/d3athrow/vgstation13/comments{/number}","issue_comment_url":"https://api.github.com/repos/d3athrow/vgstation13/issues/comments{/number}","contents_url":"https://api.github.com/repos/d3athrow/vgstation13/contents/{+path}","compare_url":"https://api.github.com/repos/d3athrow/vgstation13/compare/{base}...{head}","merges_url":"https://api.github.com/repos/d3athrow/vgstation13/merges","archive_url":"https://api.github.com/repos/d3athrow/vgstation13/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/d3athrow/vgstation13/downloads","issues_url":"https://api.github.com/repos/d3athrow/vgstation13/issues{/number}","pulls_url":"https://api.github.com/repos/d3athrow/vgstation13/pulls{/number}","milestones_url":"https://api.github.com/repos/d3athrow/vgstation13/milestones{/number}","notifications_url":"https://api.github.com/repos/d3athrow/vgstation13/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/d3athrow/vgstation13/labels{/name}","releases_url":"https://api.github.com/repos/d3athrow/vgstation13/releases{/id}","created_at":"2013-06-02T19:39:54Z","updated_at":"2015-06-19T02:20:46Z","pushed_at":"2015-06-26T22:15:04Z","git_url":"git://github.com/d3athrow/vgstation13.git","ssh_url":"git@github.com:d3athrow/vgstation13.git","clone_url":"https://github.com/d3athrow/vgstation13.git","svn_url":"https://github.com/d3athrow/vgstation13","homepage":"","size":1103411,"stargazers_count":60,"watchers_count":60,"language":"DM","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":172,"mirror_url":null,"open_issues_count":704,"forks":172,"open_issues":704,"watchers":60,"default_branch":"Bleeding-Edge"}},"_links":{"self":{"href":"https://api.github.com/repos/d3athrow/vgstation13/pulls/4285"},"html":{"href":"https://github.com/d3athrow/vgstation13/pull/4285"},"issue":{"href":"https://api.github.com/repos/d3athrow/vgstation13/issues/4285"},"comments":{"href":"https://api.github.com/repos/d3athrow/vgstation13/issues/4285/comments"},"review_comments":{"href":"https://api.github.com/repos/d3athrow/vgstation13/pulls/4285/comments"},"review_comment":{"href":"https://api.github.com/repos/d3athrow/vgstation13/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/d3athrow/vgstation13/pulls/4285/commits"},"statuses":{"href":"https://api.github.com/repos/d3athrow/vgstation13/statuses/6656242ded03c1c4f8b71d9528fd5c6c6c703c4e"}}}}