{"action":"created","issue":{"url":"https://api.github.com/repos/Cockatrice/Cockatrice/issues/1294","labels_url":"https://api.github.com/repos/Cockatrice/Cockatrice/issues/1294/labels{/name}","comments_url":"https://api.github.com/repos/Cockatrice/Cockatrice/issues/1294/comments","events_url":"https://api.github.com/repos/Cockatrice/Cockatrice/issues/1294/events","html_url":"https://github.com/Cockatrice/Cockatrice/pull/1294","id":97171306,"number":1294,"title":"tablezone refactor and cleanup","user":{"login":"mildmongrel","id":13039044,"avatar_url":"https://avatars.githubusercontent.com/u/13039044?v=3","gravatar_id":"","url":"https://api.github.com/users/mildmongrel","html_url":"https://github.com/mildmongrel","followers_url":"https://api.github.com/users/mildmongrel/followers","following_url":"https://api.github.com/users/mildmongrel/following{/other_user}","gists_url":"https://api.github.com/users/mildmongrel/gists{/gist_id}","starred_url":"https://api.github.com/users/mildmongrel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mildmongrel/subscriptions","organizations_url":"https://api.github.com/users/mildmongrel/orgs","repos_url":"https://api.github.com/users/mildmongrel/repos","events_url":"https://api.github.com/users/mildmongrel/events{/privacy}","received_events_url":"https://api.github.com/users/mildmongrel/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-07-24T23:58:49Z","updated_at":"2015-07-25T17:07:33Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Cockatrice/Cockatrice/pulls/1294","html_url":"https://github.com/Cockatrice/Cockatrice/pull/1294","diff_url":"https://github.com/Cockatrice/Cockatrice/pull/1294.diff","patch_url":"https://github.com/Cockatrice/Cockatrice/pull/1294.patch"},"body":"The tablezone code is pretty difficult to follow in its current state.  Looking ahead to features like #453 I think it made sense to tend to it a bit - more comments, more named constants, fewer magic numbers, refactored the large reorganizeCards() method, etc.\r\n\r\n*Functionality should be unchanged* with one small exception:  The previous code was a little liberal with the amount of empty space being allocated to the right of the last card, so I reduced that.  That way the table area stays a little more compact and cards will stay just a little bit larger than before after scaling.\r\n\r\nTested by playing local games (Linux qt4) and by giving test builds to friends (Windows qt5) and playing some network games.  No reports of any unusual behavior. \r\n\r\nThis code is pretty fundamental; please code review."},"comment":{"url":"https://api.github.com/repos/Cockatrice/Cockatrice/issues/comments/124862582","html_url":"https://github.com/Cockatrice/Cockatrice/pull/1294#issuecomment-124862582","issue_url":"https://api.github.com/repos/Cockatrice/Cockatrice/issues/1294","id":124862582,"user":{"login":"ctrlaltca","id":1631111,"avatar_url":"https://avatars.githubusercontent.com/u/1631111?v=3","gravatar_id":"","url":"https://api.github.com/users/ctrlaltca","html_url":"https://github.com/ctrlaltca","followers_url":"https://api.github.com/users/ctrlaltca/followers","following_url":"https://api.github.com/users/ctrlaltca/following{/other_user}","gists_url":"https://api.github.com/users/ctrlaltca/gists{/gist_id}","starred_url":"https://api.github.com/users/ctrlaltca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctrlaltca/subscriptions","organizations_url":"https://api.github.com/users/ctrlaltca/orgs","repos_url":"https://api.github.com/users/ctrlaltca/repos","events_url":"https://api.github.com/users/ctrlaltca/events{/privacy}","received_events_url":"https://api.github.com/users/ctrlaltca/received_events","type":"User","site_admin":false},"created_at":"2015-07-25T17:07:32Z","updated_at":"2015-07-25T17:07:32Z","body":"Code seems fine, and works as expected :+1: "}}