{"action":"created","issue":{"url":"https://api.github.com/repos/kbase/narrative/issues/129","labels_url":"https://api.github.com/repos/kbase/narrative/issues/129/labels{/name}","comments_url":"https://api.github.com/repos/kbase/narrative/issues/129/comments","events_url":"https://api.github.com/repos/kbase/narrative/issues/129/events","html_url":"https://github.com/kbase/narrative/issues/129","id":54147136,"number":129,"title":"Drag and drop is broken","user":{"login":"dangunter","id":420923,"avatar_url":"https://avatars.githubusercontent.com/u/420923?v=3","gravatar_id":"","url":"https://api.github.com/users/dangunter","html_url":"https://github.com/dangunter","followers_url":"https://api.github.com/users/dangunter/followers","following_url":"https://api.github.com/users/dangunter/following{/other_user}","gists_url":"https://api.github.com/users/dangunter/gists{/gist_id}","starred_url":"https://api.github.com/users/dangunter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dangunter/subscriptions","organizations_url":"https://api.github.com/users/dangunter/orgs","repos_url":"https://api.github.com/users/dangunter/repos","events_url":"https://api.github.com/users/dangunter/events{/privacy}","received_events_url":"https://api.github.com/users/dangunter/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"dangunter","id":420923,"avatar_url":"https://avatars.githubusercontent.com/u/420923?v=3","gravatar_id":"","url":"https://api.github.com/users/dangunter","html_url":"https://github.com/dangunter","followers_url":"https://api.github.com/users/dangunter/followers","following_url":"https://api.github.com/users/dangunter/following{/other_user}","gists_url":"https://api.github.com/users/dangunter/gists{/gist_id}","starred_url":"https://api.github.com/users/dangunter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dangunter/subscriptions","organizations_url":"https://api.github.com/users/dangunter/orgs","repos_url":"https://api.github.com/users/dangunter/repos","events_url":"https://api.github.com/users/dangunter/events{/privacy}","received_events_url":"https://api.github.com/users/dangunter/received_events","type":"User","site_admin":false},"milestone":null,"comments":1,"created_at":"2015-01-13T03:33:45Z","updated_at":"2015-01-13T05:20:14Z","closed_at":null,"body":"Drag and drop is broken due to a change in where the \"kb-oid\" attribute is added. This attribute is used to look the object up in the list when the DOM element is dropped. The element passed to DnD got changed, so the kb-oid attribute cannot be found, and dropping results in badness.\r\n\r\nTwo things need to be fixed:\r\n(a) the function addDragAndDrop() should include the identifier as a parameter, so it can control where it is added, and add it to the right place\r\n(b) The drop phase of DnD should check for failures in more places"},"comment":{"url":"https://api.github.com/repos/kbase/narrative/issues/comments/69697017","html_url":"https://github.com/kbase/narrative/issues/129#issuecomment-69697017","issue_url":"https://api.github.com/repos/kbase/narrative/issues/129","id":69697017,"user":{"login":"msneddon","id":1524213,"avatar_url":"https://avatars.githubusercontent.com/u/1524213?v=3","gravatar_id":"","url":"https://api.github.com/users/msneddon","html_url":"https://github.com/msneddon","followers_url":"https://api.github.com/users/msneddon/followers","following_url":"https://api.github.com/users/msneddon/following{/other_user}","gists_url":"https://api.github.com/users/msneddon/gists{/gist_id}","starred_url":"https://api.github.com/users/msneddon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msneddon/subscriptions","organizations_url":"https://api.github.com/users/msneddon/orgs","repos_url":"https://api.github.com/users/msneddon/repos","events_url":"https://api.github.com/users/msneddon/events{/privacy}","received_events_url":"https://api.github.com/users/msneddon/received_events","type":"User","site_admin":false},"created_at":"2015-01-13T05:20:14Z","updated_at":"2015-01-13T05:20:14Z","body":"Sorry, must have been me who broke it... I switched the element being\r\ndragged so that the advanced details aren't shown when dragged and metadata\r\ntext can be selected for copy and paste. It \"looked\" like DnD was still\r\nbasically working as before, but I guess I didn't look closely enough. I'll\r\ntry to help test and fix tomorrow.\r\nOn Jan 12, 2015 7:33 PM, \"Dan Gunter\" <notifications@github.com> wrote:\r\n\r\n> Drag and drop is broken due to a change in where the \"kb-oid\" attribute is\r\n> added. This attribute is used to look the object up in the list when the\r\n> DOM element is dropped. The element passed to DnD got changed, so the\r\n> kb-oid attribute cannot be found, and dropping results in badness.\r\n>\r\n> Two things need to be fixed:\r\n> (a) the function addDragAndDrop() should include the identifier as a\r\n> parameter, so it can control where it is added, and add it to the right\r\n> place\r\n> (b) The drop phase of DnD should check for failures in more places\r\n>\r\n> —\r\n> Reply to this email directly or view it on GitHub\r\n> <https://github.com/kbase/narrative/issues/129>.\r\n>"}}