{"action":"created","issue":{"url":"https://api.github.com/repos/uniqush/uniqush-push/issues/76","labels_url":"https://api.github.com/repos/uniqush/uniqush-push/issues/76/labels{/name}","comments_url":"https://api.github.com/repos/uniqush/uniqush-push/issues/76/comments","events_url":"https://api.github.com/repos/uniqush/uniqush-push/issues/76/events","html_url":"https://github.com/uniqush/uniqush-push/issues/76","id":114775980,"number":76,"title":"maxPayLoadSize in apns.go","user":{"login":"FischC","id":7221030,"avatar_url":"https://avatars.githubusercontent.com/u/7221030?v=3","gravatar_id":"","url":"https://api.github.com/users/FischC","html_url":"https://github.com/FischC","followers_url":"https://api.github.com/users/FischC/followers","following_url":"https://api.github.com/users/FischC/following{/other_user}","gists_url":"https://api.github.com/users/FischC/gists{/gist_id}","starred_url":"https://api.github.com/users/FischC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FischC/subscriptions","organizations_url":"https://api.github.com/users/FischC/orgs","repos_url":"https://api.github.com/users/FischC/repos","events_url":"https://api.github.com/users/FischC/events{/privacy}","received_events_url":"https://api.github.com/users/FischC/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-11-03T09:32:38Z","updated_at":"2015-11-19T20:37:33Z","closed_at":null,"body":"Hi!\r\n\r\nCurrently the maxPayLoadSize is set to 256 bytes (in \"srv/apns.go\" @line#43). Introducing iOS8 the payload size was increased to 2k (https://developer.apple.com/library/ios/documentation/NetworkingInternet/Conceptual/RemoteNotificationsPG/Chapters/ApplePushService.html#//apple_ref/doc/uid/TP40008194-CH100-SW1).\r\nIs there any plan to adjust this value and/or make it configurable?\r\n\r\nThanks\r\n// Clemens"},"comment":{"url":"https://api.github.com/repos/uniqush/uniqush-push/issues/comments/158190426","html_url":"https://github.com/uniqush/uniqush-push/issues/76#issuecomment-158190426","issue_url":"https://api.github.com/repos/uniqush/uniqush-push/issues/76","id":158190426,"user":{"login":"mishan","id":788577,"avatar_url":"https://avatars.githubusercontent.com/u/788577?v=3","gravatar_id":"","url":"https://api.github.com/users/mishan","html_url":"https://github.com/mishan","followers_url":"https://api.github.com/users/mishan/followers","following_url":"https://api.github.com/users/mishan/following{/other_user}","gists_url":"https://api.github.com/users/mishan/gists{/gist_id}","starred_url":"https://api.github.com/users/mishan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mishan/subscriptions","organizations_url":"https://api.github.com/users/mishan/orgs","repos_url":"https://api.github.com/users/mishan/repos","events_url":"https://api.github.com/users/mishan/events{/privacy}","received_events_url":"https://api.github.com/users/mishan/received_events","type":"User","site_admin":false},"created_at":"2015-11-19T20:37:33Z","updated_at":"2015-11-19T20:37:33Z","body":"I could see making it configurable. My concern is for the use case of where a subscriber could have pre-iOS 8 devices and post-iOS8 devices registered. If there's a way to tell from device ID or something, that'd be great, otherwise maybe we'd want to consider storing some flag in Redis.\r\n\r\nThe problem I can think of then -- you start sending 2k payloads over and uniqush-push can't deliver to some of the devices because they're too long.\r\n\r\nBut maybe just adding a configuration is good enough for now -- users of uniqush-push could decide what's appropriate for them. Eventually I imagine there won't be too many Apple devices with < iOS8."}}