{"action":"created","comment":{"url":"https://api.github.com/repos/uber/hyperbahn/pulls/comments/43561273","id":43561273,"diff_hunk":"@@ -51,6 +52,9 @@ var RATE_LIMIT_KILLSWITCH = 'killswitch';\n \n var CN_HEADER_BUFFER = new Buffer('cn');\n \n+// TODO: ring change trigger","path":"service-proxy.js","position":12,"original_position":12,"commit_id":"ba6d19982f4b6b78773e7b1b5e5e0af0b0165320","original_commit_id":"ba6d19982f4b6b78773e7b1b5e5e0af0b0165320","user":{"login":"Raynos","id":479538,"avatar_url":"https://avatars.githubusercontent.com/u/479538?v=3","gravatar_id":"","url":"https://api.github.com/users/Raynos","html_url":"https://github.com/Raynos","followers_url":"https://api.github.com/users/Raynos/followers","following_url":"https://api.github.com/users/Raynos/following{/other_user}","gists_url":"https://api.github.com/users/Raynos/gists{/gist_id}","starred_url":"https://api.github.com/users/Raynos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Raynos/subscriptions","organizations_url":"https://api.github.com/users/Raynos/orgs","repos_url":"https://api.github.com/users/Raynos/repos","events_url":"https://api.github.com/users/Raynos/events{/privacy}","received_events_url":"https://api.github.com/users/Raynos/received_events","type":"User","site_admin":false},"body":"We need this before going global, we can test on canaries without ringpop change trigger.","created_at":"2015-10-30T23:06:14Z","updated_at":"2015-10-30T23:06:14Z","html_url":"https://github.com/uber/hyperbahn/pull/66#discussion_r43561273","pull_request_url":"https://api.github.com/repos/uber/hyperbahn/pulls/66","_links":{"self":{"href":"https://api.github.com/repos/uber/hyperbahn/pulls/comments/43561273"},"html":{"href":"https://github.com/uber/hyperbahn/pull/66#discussion_r43561273"},"pull_request":{"href":"https://api.github.com/repos/uber/hyperbahn/pulls/66"}}},"pull_request":{"url":"https://api.github.com/repos/uber/hyperbahn/pulls/66","id":47978997,"html_url":"https://github.com/uber/hyperbahn/pull/66","diff_url":"https://github.com/uber/hyperbahn/pull/66.diff","patch_url":"https://github.com/uber/hyperbahn/pull/66.patch","issue_url":"https://api.github.com/repos/uber/hyperbahn/issues/66","number":66,"state":"open","locked":false,"title":"Add partial affinity peer pruning","user":{"login":"Raynos","id":479538,"avatar_url":"https://avatars.githubusercontent.com/u/479538?v=3","gravatar_id":"","url":"https://api.github.com/users/Raynos","html_url":"https://github.com/Raynos","followers_url":"https://api.github.com/users/Raynos/followers","following_url":"https://api.github.com/users/Raynos/following{/other_user}","gists_url":"https://api.github.com/users/Raynos/gists{/gist_id}","starred_url":"https://api.github.com/users/Raynos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Raynos/subscriptions","organizations_url":"https://api.github.com/users/Raynos/orgs","repos_url":"https://api.github.com/users/Raynos/repos","events_url":"https://api.github.com/users/Raynos/events{/privacy}","received_events_url":"https://api.github.com/users/Raynos/received_events","type":"User","site_admin":false},"body":"I've updated the code here to make it work with\ndead peer reaper.\n\nI've also fixed a few bugs here and there.\n\nr: @jcorbin @rf @kriskowal","created_at":"2015-10-17T04:20:42Z","updated_at":"2015-10-30T23:06:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4be1b57c0e335029b6d8a7e8a34210b310b4cb23","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/uber/hyperbahn/pulls/66/commits","review_comments_url":"https://api.github.com/repos/uber/hyperbahn/pulls/66/comments","review_comment_url":"https://api.github.com/repos/uber/hyperbahn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uber/hyperbahn/issues/66/comments","statuses_url":"https://api.github.com/repos/uber/hyperbahn/statuses/ba6d19982f4b6b78773e7b1b5e5e0af0b0165320","head":{"label":"uber:partial-affinity-peer-gc","ref":"partial-affinity-peer-gc","sha":"ba6d19982f4b6b78773e7b1b5e5e0af0b0165320","user":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"repo":{"id":41167537,"name":"hyperbahn","full_name":"uber/hyperbahn","owner":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uber/hyperbahn","description":"Service discovery and routing solution","fork":false,"url":"https://api.github.com/repos/uber/hyperbahn","forks_url":"https://api.github.com/repos/uber/hyperbahn/forks","keys_url":"https://api.github.com/repos/uber/hyperbahn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber/hyperbahn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber/hyperbahn/teams","hooks_url":"https://api.github.com/repos/uber/hyperbahn/hooks","issue_events_url":"https://api.github.com/repos/uber/hyperbahn/issues/events{/number}","events_url":"https://api.github.com/repos/uber/hyperbahn/events","assignees_url":"https://api.github.com/repos/uber/hyperbahn/assignees{/user}","branches_url":"https://api.github.com/repos/uber/hyperbahn/branches{/branch}","tags_url":"https://api.github.com/repos/uber/hyperbahn/tags","blobs_url":"https://api.github.com/repos/uber/hyperbahn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber/hyperbahn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber/hyperbahn/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber/hyperbahn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber/hyperbahn/statuses/{sha}","languages_url":"https://api.github.com/repos/uber/hyperbahn/languages","stargazers_url":"https://api.github.com/repos/uber/hyperbahn/stargazers","contributors_url":"https://api.github.com/repos/uber/hyperbahn/contributors","subscribers_url":"https://api.github.com/repos/uber/hyperbahn/subscribers","subscription_url":"https://api.github.com/repos/uber/hyperbahn/subscription","commits_url":"https://api.github.com/repos/uber/hyperbahn/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber/hyperbahn/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber/hyperbahn/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber/hyperbahn/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber/hyperbahn/contents/{+path}","compare_url":"https://api.github.com/repos/uber/hyperbahn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber/hyperbahn/merges","archive_url":"https://api.github.com/repos/uber/hyperbahn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber/hyperbahn/downloads","issues_url":"https://api.github.com/repos/uber/hyperbahn/issues{/number}","pulls_url":"https://api.github.com/repos/uber/hyperbahn/pulls{/number}","milestones_url":"https://api.github.com/repos/uber/hyperbahn/milestones{/number}","notifications_url":"https://api.github.com/repos/uber/hyperbahn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber/hyperbahn/labels{/name}","releases_url":"https://api.github.com/repos/uber/hyperbahn/releases{/id}","created_at":"2015-08-21T17:04:51Z","updated_at":"2015-10-26T17:15:43Z","pushed_at":"2015-10-30T22:49:37Z","git_url":"git://github.com/uber/hyperbahn.git","ssh_url":"git@github.com:uber/hyperbahn.git","clone_url":"https://github.com/uber/hyperbahn.git","svn_url":"https://github.com/uber/hyperbahn","homepage":"","size":2554,"stargazers_count":16,"watchers_count":16,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":19,"forks":2,"open_issues":19,"watchers":16,"default_branch":"master"}},"base":{"label":"uber:master","ref":"master","sha":"1944940e43de20ec99e0d1c3c416c8ec1cfffbe8","user":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"repo":{"id":41167537,"name":"hyperbahn","full_name":"uber/hyperbahn","owner":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uber/hyperbahn","description":"Service discovery and routing solution","fork":false,"url":"https://api.github.com/repos/uber/hyperbahn","forks_url":"https://api.github.com/repos/uber/hyperbahn/forks","keys_url":"https://api.github.com/repos/uber/hyperbahn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber/hyperbahn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber/hyperbahn/teams","hooks_url":"https://api.github.com/repos/uber/hyperbahn/hooks","issue_events_url":"https://api.github.com/repos/uber/hyperbahn/issues/events{/number}","events_url":"https://api.github.com/repos/uber/hyperbahn/events","assignees_url":"https://api.github.com/repos/uber/hyperbahn/assignees{/user}","branches_url":"https://api.github.com/repos/uber/hyperbahn/branches{/branch}","tags_url":"https://api.github.com/repos/uber/hyperbahn/tags","blobs_url":"https://api.github.com/repos/uber/hyperbahn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber/hyperbahn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber/hyperbahn/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber/hyperbahn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber/hyperbahn/statuses/{sha}","languages_url":"https://api.github.com/repos/uber/hyperbahn/languages","stargazers_url":"https://api.github.com/repos/uber/hyperbahn/stargazers","contributors_url":"https://api.github.com/repos/uber/hyperbahn/contributors","subscribers_url":"https://api.github.com/repos/uber/hyperbahn/subscribers","subscription_url":"https://api.github.com/repos/uber/hyperbahn/subscription","commits_url":"https://api.github.com/repos/uber/hyperbahn/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber/hyperbahn/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber/hyperbahn/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber/hyperbahn/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber/hyperbahn/contents/{+path}","compare_url":"https://api.github.com/repos/uber/hyperbahn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber/hyperbahn/merges","archive_url":"https://api.github.com/repos/uber/hyperbahn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber/hyperbahn/downloads","issues_url":"https://api.github.com/repos/uber/hyperbahn/issues{/number}","pulls_url":"https://api.github.com/repos/uber/hyperbahn/pulls{/number}","milestones_url":"https://api.github.com/repos/uber/hyperbahn/milestones{/number}","notifications_url":"https://api.github.com/repos/uber/hyperbahn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber/hyperbahn/labels{/name}","releases_url":"https://api.github.com/repos/uber/hyperbahn/releases{/id}","created_at":"2015-08-21T17:04:51Z","updated_at":"2015-10-26T17:15:43Z","pushed_at":"2015-10-30T22:49:37Z","git_url":"git://github.com/uber/hyperbahn.git","ssh_url":"git@github.com:uber/hyperbahn.git","clone_url":"https://github.com/uber/hyperbahn.git","svn_url":"https://github.com/uber/hyperbahn","homepage":"","size":2554,"stargazers_count":16,"watchers_count":16,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":19,"forks":2,"open_issues":19,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uber/hyperbahn/pulls/66"},"html":{"href":"https://github.com/uber/hyperbahn/pull/66"},"issue":{"href":"https://api.github.com/repos/uber/hyperbahn/issues/66"},"comments":{"href":"https://api.github.com/repos/uber/hyperbahn/issues/66/comments"},"review_comments":{"href":"https://api.github.com/repos/uber/hyperbahn/pulls/66/comments"},"review_comment":{"href":"https://api.github.com/repos/uber/hyperbahn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uber/hyperbahn/pulls/66/commits"},"statuses":{"href":"https://api.github.com/repos/uber/hyperbahn/statuses/ba6d19982f4b6b78773e7b1b5e5e0af0b0165320"}}}}