{"action":"created","issue":{"url":"https://api.github.com/repos/django-oscar/django-oscar/issues/1867","labels_url":"https://api.github.com/repos/django-oscar/django-oscar/issues/1867/labels{/name}","comments_url":"https://api.github.com/repos/django-oscar/django-oscar/issues/1867/comments","events_url":"https://api.github.com/repos/django-oscar/django-oscar/issues/1867/events","html_url":"https://github.com/django-oscar/django-oscar/pull/1867","id":111201789,"number":1867,"title":"Allow for children to have different images from their siblings","user":{"login":"john-parton","id":2071543,"avatar_url":"https://avatars.githubusercontent.com/u/2071543?v=3","gravatar_id":"","url":"https://api.github.com/users/john-parton","html_url":"https://github.com/john-parton","followers_url":"https://api.github.com/users/john-parton/followers","following_url":"https://api.github.com/users/john-parton/following{/other_user}","gists_url":"https://api.github.com/users/john-parton/gists{/gist_id}","starred_url":"https://api.github.com/users/john-parton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/john-parton/subscriptions","organizations_url":"https://api.github.com/users/john-parton/orgs","repos_url":"https://api.github.com/users/john-parton/repos","events_url":"https://api.github.com/users/john-parton/events{/privacy}","received_events_url":"https://api.github.com/users/john-parton/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/django-oscar/django-oscar/labels/%E2%9C%8D%20For%20review","name":"✍ For review","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-10-13T15:13:18Z","updated_at":"2015-12-01T21:50:02Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/django-oscar/django-oscar/pulls/1867","html_url":"https://github.com/django-oscar/django-oscar/pull/1867","diff_url":"https://github.com/django-oscar/django-oscar/pull/1867.diff","patch_url":"https://github.com/django-oscar/django-oscar/pull/1867.patch"},"body":"This is my attempt to reduce the size of https://github.com/django-oscar/django-oscar/pull/1643\r\n\r\nThis should close https://github.com/django-oscar/django-oscar/issues/1611\r\n\r\nIt really only does a very small number of things:\r\n\r\n* Adds a `child_images` field\r\n* Exposes it in the dashboard\r\n* When a user adds a child to the basket, it uses the `child_images` field to determine which image show.\r\n\r\nThings this *does not* do:\r\n\r\n* Change any template\r\n* Show the variant image on the product page (before the user adds it to their cart)\r\n* Make associating images with children particularly easy. (The widget in the dashboard is usable for products with small numbers of images and variants, but quickly becomes cumbersome when you have dozens of them.)\r\n* Test my changes\r\n\r\n@mvantellingen or another maintainer, can you please let me know if you think this approach is viable. and I'll add some tests."},"comment":{"url":"https://api.github.com/repos/django-oscar/django-oscar/issues/comments/161106516","html_url":"https://github.com/django-oscar/django-oscar/pull/1867#issuecomment-161106516","issue_url":"https://api.github.com/repos/django-oscar/django-oscar/issues/1867","id":161106516,"user":{"login":"john-parton","id":2071543,"avatar_url":"https://avatars.githubusercontent.com/u/2071543?v=3","gravatar_id":"","url":"https://api.github.com/users/john-parton","html_url":"https://github.com/john-parton","followers_url":"https://api.github.com/users/john-parton/followers","following_url":"https://api.github.com/users/john-parton/following{/other_user}","gists_url":"https://api.github.com/users/john-parton/gists{/gist_id}","starred_url":"https://api.github.com/users/john-parton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/john-parton/subscriptions","organizations_url":"https://api.github.com/users/john-parton/orgs","repos_url":"https://api.github.com/users/john-parton/repos","events_url":"https://api.github.com/users/john-parton/events{/privacy}","received_events_url":"https://api.github.com/users/john-parton/received_events","type":"User","site_admin":false},"created_at":"2015-12-01T21:50:02Z","updated_at":"2015-12-01T21:50:02Z","body":"@mvantellingen Merged in master. There was a conflict with migrations. I wasn't sure what the best way to resolve that would be, but I made an attempt. Let me know if you need anything changed."}}