{"action":"created","issue":{"url":"https://api.github.com/repos/rust-lang/rust/issues/28857","labels_url":"https://api.github.com/repos/rust-lang/rust/issues/28857/labels{/name}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/28857/comments","events_url":"https://api.github.com/repos/rust-lang/rust/issues/28857/events","html_url":"https://github.com/rust-lang/rust/pull/28857","id":109927253,"number":28857,"title":"Move desugarings to lowering step","user":{"login":"nrc","id":762626,"avatar_url":"https://avatars.githubusercontent.com/u/762626?v=3","gravatar_id":"","url":"https://api.github.com/users/nrc","html_url":"https://github.com/nrc","followers_url":"https://api.github.com/users/nrc/followers","following_url":"https://api.github.com/users/nrc/following{/other_user}","gists_url":"https://api.github.com/users/nrc/gists{/gist_id}","starred_url":"https://api.github.com/users/nrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nrc/subscriptions","organizations_url":"https://api.github.com/users/nrc/orgs","repos_url":"https://api.github.com/users/nrc/repos","events_url":"https://api.github.com/users/nrc/events{/privacy}","received_events_url":"https://api.github.com/users/nrc/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"nikomatsakis","id":155238,"avatar_url":"https://avatars.githubusercontent.com/u/155238?v=3","gravatar_id":"","url":"https://api.github.com/users/nikomatsakis","html_url":"https://github.com/nikomatsakis","followers_url":"https://api.github.com/users/nikomatsakis/followers","following_url":"https://api.github.com/users/nikomatsakis/following{/other_user}","gists_url":"https://api.github.com/users/nikomatsakis/gists{/gist_id}","starred_url":"https://api.github.com/users/nikomatsakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikomatsakis/subscriptions","organizations_url":"https://api.github.com/users/nikomatsakis/orgs","repos_url":"https://api.github.com/users/nikomatsakis/repos","events_url":"https://api.github.com/users/nikomatsakis/events{/privacy}","received_events_url":"https://api.github.com/users/nikomatsakis/received_events","type":"User","site_admin":false},"milestone":null,"comments":2,"created_at":"2015-10-06T03:10:47Z","updated_at":"2015-10-06T21:52:53Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/28857","html_url":"https://github.com/rust-lang/rust/pull/28857","diff_url":"https://github.com/rust-lang/rust/pull/28857.diff","patch_url":"https://github.com/rust-lang/rust/pull/28857.patch"},"body":"r? @nikomatsakis "},"comment":{"url":"https://api.github.com/repos/rust-lang/rust/issues/comments/146012460","html_url":"https://github.com/rust-lang/rust/pull/28857#issuecomment-146012460","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/28857","id":146012460,"user":{"login":"nikomatsakis","id":155238,"avatar_url":"https://avatars.githubusercontent.com/u/155238?v=3","gravatar_id":"","url":"https://api.github.com/users/nikomatsakis","html_url":"https://github.com/nikomatsakis","followers_url":"https://api.github.com/users/nikomatsakis/followers","following_url":"https://api.github.com/users/nikomatsakis/following{/other_user}","gists_url":"https://api.github.com/users/nikomatsakis/gists{/gist_id}","starred_url":"https://api.github.com/users/nikomatsakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikomatsakis/subscriptions","organizations_url":"https://api.github.com/users/nikomatsakis/orgs","repos_url":"https://api.github.com/users/nikomatsakis/repos","events_url":"https://api.github.com/users/nikomatsakis/events{/privacy}","received_events_url":"https://api.github.com/users/nikomatsakis/received_events","type":"User","site_admin":false},"created_at":"2015-10-06T21:52:53Z","updated_at":"2015-10-06T21:52:53Z","body":"OK, I apologize for the \"stream-of-consciousness\" style review, but that's GH for you. r=me modulo:\r\n\r\n1. Test for using unstable code in place/expr of placement new\r\n2. Fix bug (if any) around unstable code in placer expr\r\n3. Test that if we lower some AST twice we get same output\r\n    - presumably try to use if let, while let, etc in the test\r\n    - maybe add a note to the comment encouraging future non-trivial lowerings to have a test\r\n4. Typos"}}