{"action":"created","issue":{"url":"https://api.github.com/repos/rackt/react-a11y/issues/15","labels_url":"https://api.github.com/repos/rackt/react-a11y/issues/15/labels{/name}","comments_url":"https://api.github.com/repos/rackt/react-a11y/issues/15/comments","events_url":"https://api.github.com/repos/rackt/react-a11y/issues/15/events","html_url":"https://github.com/rackt/react-a11y/pull/15","id":60153977,"number":15,"title":"[fixed] Button role didn't allow onKeyDown","user":{"login":"AsaAyers","id":324999,"avatar_url":"https://avatars.githubusercontent.com/u/324999?v=3","gravatar_id":"","url":"https://api.github.com/users/AsaAyers","html_url":"https://github.com/AsaAyers","followers_url":"https://api.github.com/users/AsaAyers/followers","following_url":"https://api.github.com/users/AsaAyers/following{/other_user}","gists_url":"https://api.github.com/users/AsaAyers/gists{/gist_id}","starred_url":"https://api.github.com/users/AsaAyers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AsaAyers/subscriptions","organizations_url":"https://api.github.com/users/AsaAyers/orgs","repos_url":"https://api.github.com/users/AsaAyers/repos","events_url":"https://api.github.com/users/AsaAyers/events{/privacy}","received_events_url":"https://api.github.com/users/AsaAyers/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-03-06T20:26:04Z","updated_at":"2015-04-17T17:25:26Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/rackt/react-a11y/pulls/15","html_url":"https://github.com/rackt/react-a11y/pull/15","diff_url":"https://github.com/rackt/react-a11y/pull/15.diff","patch_url":"https://github.com/rackt/react-a11y/pull/15.patch"},"body":"onKeyUp is too late to prevent space from scrolling the browser, so it\r\nshould be onKeyDown.\r\n\r\nWhile I was doing this I clarified the `BUTTON_ROLE_*` rule names and set\r\n`BUTTON_ROLE_ENTER` to account for `onKeyUp` or `onKeyDown`"},"comment":{"url":"https://api.github.com/repos/rackt/react-a11y/issues/comments/94031932","html_url":"https://github.com/rackt/react-a11y/pull/15#issuecomment-94031932","issue_url":"https://api.github.com/repos/rackt/react-a11y/issues/15","id":94031932,"user":{"login":"AsaAyers","id":324999,"avatar_url":"https://avatars.githubusercontent.com/u/324999?v=3","gravatar_id":"","url":"https://api.github.com/users/AsaAyers","html_url":"https://github.com/AsaAyers","followers_url":"https://api.github.com/users/AsaAyers/followers","following_url":"https://api.github.com/users/AsaAyers/following{/other_user}","gists_url":"https://api.github.com/users/AsaAyers/gists{/gist_id}","starred_url":"https://api.github.com/users/AsaAyers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AsaAyers/subscriptions","organizations_url":"https://api.github.com/users/AsaAyers/orgs","repos_url":"https://api.github.com/users/AsaAyers/repos","events_url":"https://api.github.com/users/AsaAyers/events{/privacy}","received_events_url":"https://api.github.com/users/AsaAyers/received_events","type":"User","site_admin":false},"created_at":"2015-04-17T17:25:26Z","updated_at":"2015-04-17T17:25:26Z","body":"This and all of my other PRs are available with `npm install @asaayers/react-a11y`\r\n[@asaayers/react-a11y](https://www.npmjs.com/package/@asaayers/react-a11y)"}}