{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/heapster/pulls/comments/38790553","id":38790553,"diff_hunk":"@@ -336,84 +344,106 @@ func (a *Api) containerPaths(request *restful.Request, response *restful.Respons\n \tresponse.WriteEntity(entities)\n }\n \n-// allNodes returns a list of all the available node names in the cluster.\n+// makeExternalEntityList converts the result of model's getX methods to the external type.\n+func makeExternalEntityList(list []model_api.EntityListEntry) []types.ExternalEntityListEntry {","path":"api/v1/model_handlers.go","position":92,"original_position":92,"commit_id":"2003dc981eaf5fc5cfd040d3c9ba3e2a3bef3e39","original_commit_id":"b5afec980dce12e4e20b9648e35c681cb6d35260","user":{"login":"vishh","id":7063592,"avatar_url":"https://avatars.githubusercontent.com/u/7063592?v=3","gravatar_id":"","url":"https://api.github.com/users/vishh","html_url":"https://github.com/vishh","followers_url":"https://api.github.com/users/vishh/followers","following_url":"https://api.github.com/users/vishh/following{/other_user}","gists_url":"https://api.github.com/users/vishh/gists{/gist_id}","starred_url":"https://api.github.com/users/vishh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vishh/subscriptions","organizations_url":"https://api.github.com/users/vishh/orgs","repos_url":"https://api.github.com/users/vishh/repos","events_url":"https://api.github.com/users/vishh/events{/privacy}","received_events_url":"https://api.github.com/users/vishh/received_events","type":"User","site_admin":false},"body":"Ok. Can you add a comment about this? Not necessarily in this PR. ","created_at":"2015-09-04T20:24:24Z","updated_at":"2015-09-04T20:24:24Z","html_url":"https://github.com/kubernetes/heapster/pull/508#discussion_r38790553","pull_request_url":"https://api.github.com/repos/kubernetes/heapster/pulls/508","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/heapster/pulls/comments/38790553"},"html":{"href":"https://github.com/kubernetes/heapster/pull/508#discussion_r38790553"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/heapster/pulls/508"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/heapster/pulls/508","id":43938737,"html_url":"https://github.com/kubernetes/heapster/pull/508","diff_url":"https://github.com/kubernetes/heapster/pull/508.diff","patch_url":"https://github.com/kubernetes/heapster/pull/508.patch","issue_url":"https://api.github.com/repos/kubernetes/heapster/issues/508","number":508,"state":"open","locked":false,"title":"Change model to use the new stores & Cleanup","user":{"login":"afein","id":680441,"avatar_url":"https://avatars.githubusercontent.com/u/680441?v=3","gravatar_id":"","url":"https://api.github.com/users/afein","html_url":"https://github.com/afein","followers_url":"https://api.github.com/users/afein/followers","following_url":"https://api.github.com/users/afein/following{/other_user}","gists_url":"https://api.github.com/users/afein/gists{/gist_id}","starred_url":"https://api.github.com/users/afein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afein/subscriptions","organizations_url":"https://api.github.com/users/afein/orgs","repos_url":"https://api.github.com/users/afein/repos","events_url":"https://api.github.com/users/afein/events{/privacy}","received_events_url":"https://api.github.com/users/afein/received_events","type":"User","site_admin":false},"body":"Part 2 of #478 \r\n\r\nChangeset:\r\n- Moved Getter methods to getters.go and tests to getters_test.go\r\n- renamed top-level entity to Model from Cluster\r\n- added a /nodes/{node-name}/pods endpoint\r\n- Listing endpoints now also return the latest memory and CPU usage value through the new ExternalEntityListEntry struct\r\n- ported the underlying stores to utilize DayStore structs instead. Epsilon is configured statically for each metric at model/types.go\r\n\r\nPlease do not be discouraged by the PR size, the majority of changes are on unit tests.\r\n\r\n\\cc @vishh @mvdan @piosz ","created_at":"2015-09-01T23:25:19Z","updated_at":"2015-09-04T20:24:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6eaeb60c79b85871e7bb2e1047bf29b7450dd684","assignee":{"login":"vishh","id":7063592,"avatar_url":"https://avatars.githubusercontent.com/u/7063592?v=3","gravatar_id":"","url":"https://api.github.com/users/vishh","html_url":"https://github.com/vishh","followers_url":"https://api.github.com/users/vishh/followers","following_url":"https://api.github.com/users/vishh/following{/other_user}","gists_url":"https://api.github.com/users/vishh/gists{/gist_id}","starred_url":"https://api.github.com/users/vishh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vishh/subscriptions","organizations_url":"https://api.github.com/users/vishh/orgs","repos_url":"https://api.github.com/users/vishh/repos","events_url":"https://api.github.com/users/vishh/events{/privacy}","received_events_url":"https://api.github.com/users/vishh/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/kubernetes/heapster/milestones/2","html_url":"https://github.com/kubernetes/heapster/milestones/Enable%20Model%20API","labels_url":"https://api.github.com/repos/kubernetes/heapster/milestones/2/labels","id":1265186,"number":2,"title":"Enable Model API","description":"This milestone tracks all the issues related to enabling the Model API safely in production","creator":{"login":"vishh","id":7063592,"avatar_url":"https://avatars.githubusercontent.com/u/7063592?v=3","gravatar_id":"","url":"https://api.github.com/users/vishh","html_url":"https://github.com/vishh","followers_url":"https://api.github.com/users/vishh/followers","following_url":"https://api.github.com/users/vishh/following{/other_user}","gists_url":"https://api.github.com/users/vishh/gists{/gist_id}","starred_url":"https://api.github.com/users/vishh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vishh/subscriptions","organizations_url":"https://api.github.com/users/vishh/orgs","repos_url":"https://api.github.com/users/vishh/repos","events_url":"https://api.github.com/users/vishh/events{/privacy}","received_events_url":"https://api.github.com/users/vishh/received_events","type":"User","site_admin":false},"open_issues":10,"closed_issues":0,"state":"open","created_at":"2015-08-20T19:33:35Z","updated_at":"2015-09-03T18:07:06Z","due_on":"2015-08-28T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/kubernetes/heapster/pulls/508/commits","review_comments_url":"https://api.github.com/repos/kubernetes/heapster/pulls/508/comments","review_comment_url":"https://api.github.com/repos/kubernetes/heapster/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/heapster/issues/508/comments","statuses_url":"https://api.github.com/repos/kubernetes/heapster/statuses/2003dc981eaf5fc5cfd040d3c9ba3e2a3bef3e39","head":{"label":"afein:model_store_update","ref":"model_store_update","sha":"2003dc981eaf5fc5cfd040d3c9ba3e2a3bef3e39","user":{"login":"afein","id":680441,"avatar_url":"https://avatars.githubusercontent.com/u/680441?v=3","gravatar_id":"","url":"https://api.github.com/users/afein","html_url":"https://github.com/afein","followers_url":"https://api.github.com/users/afein/followers","following_url":"https://api.github.com/users/afein/following{/other_user}","gists_url":"https://api.github.com/users/afein/gists{/gist_id}","starred_url":"https://api.github.com/users/afein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afein/subscriptions","organizations_url":"https://api.github.com/users/afein/orgs","repos_url":"https://api.github.com/users/afein/repos","events_url":"https://api.github.com/users/afein/events{/privacy}","received_events_url":"https://api.github.com/users/afein/received_events","type":"User","site_admin":false},"repo":{"id":36956080,"name":"heapster","full_name":"afein/heapster","owner":{"login":"afein","id":680441,"avatar_url":"https://avatars.githubusercontent.com/u/680441?v=3","gravatar_id":"","url":"https://api.github.com/users/afein","html_url":"https://github.com/afein","followers_url":"https://api.github.com/users/afein/followers","following_url":"https://api.github.com/users/afein/following{/other_user}","gists_url":"https://api.github.com/users/afein/gists{/gist_id}","starred_url":"https://api.github.com/users/afein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afein/subscriptions","organizations_url":"https://api.github.com/users/afein/orgs","repos_url":"https://api.github.com/users/afein/repos","events_url":"https://api.github.com/users/afein/events{/privacy}","received_events_url":"https://api.github.com/users/afein/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/afein/heapster","description":"Monitor container resource usage of a Kubernetes cluster","fork":true,"url":"https://api.github.com/repos/afein/heapster","forks_url":"https://api.github.com/repos/afein/heapster/forks","keys_url":"https://api.github.com/repos/afein/heapster/keys{/key_id}","collaborators_url":"https://api.github.com/repos/afein/heapster/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/afein/heapster/teams","hooks_url":"https://api.github.com/repos/afein/heapster/hooks","issue_events_url":"https://api.github.com/repos/afein/heapster/issues/events{/number}","events_url":"https://api.github.com/repos/afein/heapster/events","assignees_url":"https://api.github.com/repos/afein/heapster/assignees{/user}","branches_url":"https://api.github.com/repos/afein/heapster/branches{/branch}","tags_url":"https://api.github.com/repos/afein/heapster/tags","blobs_url":"https://api.github.com/repos/afein/heapster/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/afein/heapster/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/afein/heapster/git/refs{/sha}","trees_url":"https://api.github.com/repos/afein/heapster/git/trees{/sha}","statuses_url":"https://api.github.com/repos/afein/heapster/statuses/{sha}","languages_url":"https://api.github.com/repos/afein/heapster/languages","stargazers_url":"https://api.github.com/repos/afein/heapster/stargazers","contributors_url":"https://api.github.com/repos/afein/heapster/contributors","subscribers_url":"https://api.github.com/repos/afein/heapster/subscribers","subscription_url":"https://api.github.com/repos/afein/heapster/subscription","commits_url":"https://api.github.com/repos/afein/heapster/commits{/sha}","git_commits_url":"https://api.github.com/repos/afein/heapster/git/commits{/sha}","comments_url":"https://api.github.com/repos/afein/heapster/comments{/number}","issue_comment_url":"https://api.github.com/repos/afein/heapster/issues/comments{/number}","contents_url":"https://api.github.com/repos/afein/heapster/contents/{+path}","compare_url":"https://api.github.com/repos/afein/heapster/compare/{base}...{head}","merges_url":"https://api.github.com/repos/afein/heapster/merges","archive_url":"https://api.github.com/repos/afein/heapster/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/afein/heapster/downloads","issues_url":"https://api.github.com/repos/afein/heapster/issues{/number}","pulls_url":"https://api.github.com/repos/afein/heapster/pulls{/number}","milestones_url":"https://api.github.com/repos/afein/heapster/milestones{/number}","notifications_url":"https://api.github.com/repos/afein/heapster/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/afein/heapster/labels{/name}","releases_url":"https://api.github.com/repos/afein/heapster/releases{/id}","created_at":"2015-06-05T21:24:01Z","updated_at":"2015-06-05T21:24:02Z","pushed_at":"2015-09-03T18:58:19Z","git_url":"git://github.com/afein/heapster.git","ssh_url":"git@github.com:afein/heapster.git","clone_url":"https://github.com/afein/heapster.git","svn_url":"https://github.com/afein/heapster","homepage":"","size":20401,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"9ed0954b5ed9ed29cd8f2bd0b51e2293bcd6f41b","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":23272510,"name":"heapster","full_name":"kubernetes/heapster","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/heapster","description":"Compute Resource Usage Analysis and Monitoring of Container Clusters","fork":false,"url":"https://api.github.com/repos/kubernetes/heapster","forks_url":"https://api.github.com/repos/kubernetes/heapster/forks","keys_url":"https://api.github.com/repos/kubernetes/heapster/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/heapster/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/heapster/teams","hooks_url":"https://api.github.com/repos/kubernetes/heapster/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/heapster/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/heapster/events","assignees_url":"https://api.github.com/repos/kubernetes/heapster/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/heapster/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/heapster/tags","blobs_url":"https://api.github.com/repos/kubernetes/heapster/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/heapster/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/heapster/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/heapster/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/heapster/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/heapster/languages","stargazers_url":"https://api.github.com/repos/kubernetes/heapster/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/heapster/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/heapster/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/heapster/subscription","commits_url":"https://api.github.com/repos/kubernetes/heapster/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/heapster/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/heapster/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/heapster/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/heapster/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/heapster/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/heapster/merges","archive_url":"https://api.github.com/repos/kubernetes/heapster/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/heapster/downloads","issues_url":"https://api.github.com/repos/kubernetes/heapster/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/heapster/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/heapster/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/heapster/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/heapster/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/heapster/releases{/id}","created_at":"2014-08-24T03:50:18Z","updated_at":"2015-09-04T13:41:51Z","pushed_at":"2015-09-04T15:01:25Z","git_url":"git://github.com/kubernetes/heapster.git","ssh_url":"git@github.com:kubernetes/heapster.git","clone_url":"https://github.com/kubernetes/heapster.git","svn_url":"https://github.com/kubernetes/heapster","homepage":"","size":22803,"stargazers_count":404,"watchers_count":404,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":106,"mirror_url":null,"open_issues_count":100,"forks":106,"open_issues":100,"watchers":404,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/heapster/pulls/508"},"html":{"href":"https://github.com/kubernetes/heapster/pull/508"},"issue":{"href":"https://api.github.com/repos/kubernetes/heapster/issues/508"},"comments":{"href":"https://api.github.com/repos/kubernetes/heapster/issues/508/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/heapster/pulls/508/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/heapster/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/heapster/pulls/508/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/heapster/statuses/2003dc981eaf5fc5cfd040d3c9ba3e2a3bef3e39"}}}}