{"action":"closed","number":256,"pull_request":{"url":"https://api.github.com/repos/brython-dev/brython/pulls/256","id":43113372,"html_url":"https://github.com/brython-dev/brython/pull/256","diff_url":"https://github.com/brython-dev/brython/pull/256.diff","patch_url":"https://github.com/brython-dev/brython/pull/256.patch","issue_url":"https://api.github.com/repos/brython-dev/brython/issues/256","number":256,"state":"closed","locked":false,"title":"[FIX] Replace every '.' per '_' before eval(), not 1st only","user":{"login":"alanjds","id":155623,"avatar_url":"https://avatars.githubusercontent.com/u/155623?v=3","gravatar_id":"","url":"https://api.github.com/users/alanjds","html_url":"https://github.com/alanjds","followers_url":"https://api.github.com/users/alanjds/followers","following_url":"https://api.github.com/users/alanjds/following{/other_user}","gists_url":"https://api.github.com/users/alanjds/gists{/gist_id}","starred_url":"https://api.github.com/users/alanjds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alanjds/subscriptions","organizations_url":"https://api.github.com/users/alanjds/orgs","repos_url":"https://api.github.com/users/alanjds/repos","events_url":"https://api.github.com/users/alanjds/events{/privacy}","received_events_url":"https://api.github.com/users/alanjds/received_events","type":"User","site_admin":false},"body":"Trying to import `rpyc.core.brine`, it crashes on this javascript eval. The `sc_id` should not contains `.`, only `_` IIUC. Solved [this way](http://stackoverflow.com/a/1144788/798575).","created_at":"2015-08-23T01:03:18Z","updated_at":"2015-08-31T19:15:58Z","closed_at":"2015-08-31T19:15:58Z","merged_at":"2015-08-31T19:15:58Z","merge_commit_sha":"1b180ac6a90f218d71ded90dde207a2d7da975cd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/brython-dev/brython/pulls/256/commits","review_comments_url":"https://api.github.com/repos/brython-dev/brython/pulls/256/comments","review_comment_url":"https://api.github.com/repos/brython-dev/brython/pulls/comments{/number}","comments_url":"https://api.github.com/repos/brython-dev/brython/issues/256/comments","statuses_url":"https://api.github.com/repos/brython-dev/brython/statuses/7dad282461984403e30baae5989a26869384090b","head":{"label":"alanjds:rpyc-core-brine","ref":"rpyc-core-brine","sha":"7dad282461984403e30baae5989a26869384090b","user":{"login":"alanjds","id":155623,"avatar_url":"https://avatars.githubusercontent.com/u/155623?v=3","gravatar_id":"","url":"https://api.github.com/users/alanjds","html_url":"https://github.com/alanjds","followers_url":"https://api.github.com/users/alanjds/followers","following_url":"https://api.github.com/users/alanjds/following{/other_user}","gists_url":"https://api.github.com/users/alanjds/gists{/gist_id}","starred_url":"https://api.github.com/users/alanjds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alanjds/subscriptions","organizations_url":"https://api.github.com/users/alanjds/orgs","repos_url":"https://api.github.com/users/alanjds/repos","events_url":"https://api.github.com/users/alanjds/events{/privacy}","received_events_url":"https://api.github.com/users/alanjds/received_events","type":"User","site_admin":false},"repo":{"id":41218922,"name":"brython","full_name":"alanjds/brython","owner":{"login":"alanjds","id":155623,"avatar_url":"https://avatars.githubusercontent.com/u/155623?v=3","gravatar_id":"","url":"https://api.github.com/users/alanjds","html_url":"https://github.com/alanjds","followers_url":"https://api.github.com/users/alanjds/followers","following_url":"https://api.github.com/users/alanjds/following{/other_user}","gists_url":"https://api.github.com/users/alanjds/gists{/gist_id}","starred_url":"https://api.github.com/users/alanjds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alanjds/subscriptions","organizations_url":"https://api.github.com/users/alanjds/orgs","repos_url":"https://api.github.com/users/alanjds/repos","events_url":"https://api.github.com/users/alanjds/events{/privacy}","received_events_url":"https://api.github.com/users/alanjds/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alanjds/brython","description":"Brython (Browser Python) is an implementation of Python 3 running in the browser","fork":true,"url":"https://api.github.com/repos/alanjds/brython","forks_url":"https://api.github.com/repos/alanjds/brython/forks","keys_url":"https://api.github.com/repos/alanjds/brython/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alanjds/brython/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alanjds/brython/teams","hooks_url":"https://api.github.com/repos/alanjds/brython/hooks","issue_events_url":"https://api.github.com/repos/alanjds/brython/issues/events{/number}","events_url":"https://api.github.com/repos/alanjds/brython/events","assignees_url":"https://api.github.com/repos/alanjds/brython/assignees{/user}","branches_url":"https://api.github.com/repos/alanjds/brython/branches{/branch}","tags_url":"https://api.github.com/repos/alanjds/brython/tags","blobs_url":"https://api.github.com/repos/alanjds/brython/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alanjds/brython/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alanjds/brython/git/refs{/sha}","trees_url":"https://api.github.com/repos/alanjds/brython/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alanjds/brython/statuses/{sha}","languages_url":"https://api.github.com/repos/alanjds/brython/languages","stargazers_url":"https://api.github.com/repos/alanjds/brython/stargazers","contributors_url":"https://api.github.com/repos/alanjds/brython/contributors","subscribers_url":"https://api.github.com/repos/alanjds/brython/subscribers","subscription_url":"https://api.github.com/repos/alanjds/brython/subscription","commits_url":"https://api.github.com/repos/alanjds/brython/commits{/sha}","git_commits_url":"https://api.github.com/repos/alanjds/brython/git/commits{/sha}","comments_url":"https://api.github.com/repos/alanjds/brython/comments{/number}","issue_comment_url":"https://api.github.com/repos/alanjds/brython/issues/comments{/number}","contents_url":"https://api.github.com/repos/alanjds/brython/contents/{+path}","compare_url":"https://api.github.com/repos/alanjds/brython/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alanjds/brython/merges","archive_url":"https://api.github.com/repos/alanjds/brython/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alanjds/brython/downloads","issues_url":"https://api.github.com/repos/alanjds/brython/issues{/number}","pulls_url":"https://api.github.com/repos/alanjds/brython/pulls{/number}","milestones_url":"https://api.github.com/repos/alanjds/brython/milestones{/number}","notifications_url":"https://api.github.com/repos/alanjds/brython/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alanjds/brython/labels{/name}","releases_url":"https://api.github.com/repos/alanjds/brython/releases{/id}","created_at":"2015-08-22T18:07:43Z","updated_at":"2015-08-22T18:07:50Z","pushed_at":"2015-08-23T00:57:17Z","git_url":"git://github.com/alanjds/brython.git","ssh_url":"git@github.com:alanjds/brython.git","clone_url":"https://github.com/alanjds/brython.git","svn_url":"https://github.com/alanjds/brython","homepage":null,"size":26276,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"brython-dev:master","ref":"master","sha":"8c9eec2c1d2f1b1f43bf53916b3d79030b1b5070","user":{"login":"brython-dev","id":8774340,"avatar_url":"https://avatars.githubusercontent.com/u/8774340?v=3","gravatar_id":"","url":"https://api.github.com/users/brython-dev","html_url":"https://github.com/brython-dev","followers_url":"https://api.github.com/users/brython-dev/followers","following_url":"https://api.github.com/users/brython-dev/following{/other_user}","gists_url":"https://api.github.com/users/brython-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/brython-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brython-dev/subscriptions","organizations_url":"https://api.github.com/users/brython-dev/orgs","repos_url":"https://api.github.com/users/brython-dev/repos","events_url":"https://api.github.com/users/brython-dev/events{/privacy}","received_events_url":"https://api.github.com/users/brython-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":24046239,"name":"brython","full_name":"brython-dev/brython","owner":{"login":"brython-dev","id":8774340,"avatar_url":"https://avatars.githubusercontent.com/u/8774340?v=3","gravatar_id":"","url":"https://api.github.com/users/brython-dev","html_url":"https://github.com/brython-dev","followers_url":"https://api.github.com/users/brython-dev/followers","following_url":"https://api.github.com/users/brython-dev/following{/other_user}","gists_url":"https://api.github.com/users/brython-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/brython-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brython-dev/subscriptions","organizations_url":"https://api.github.com/users/brython-dev/orgs","repos_url":"https://api.github.com/users/brython-dev/repos","events_url":"https://api.github.com/users/brython-dev/events{/privacy}","received_events_url":"https://api.github.com/users/brython-dev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/brython-dev/brython","description":"Brython (Browser Python) is an implementation of Python 3 running in the browser","fork":true,"url":"https://api.github.com/repos/brython-dev/brython","forks_url":"https://api.github.com/repos/brython-dev/brython/forks","keys_url":"https://api.github.com/repos/brython-dev/brython/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brython-dev/brython/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brython-dev/brython/teams","hooks_url":"https://api.github.com/repos/brython-dev/brython/hooks","issue_events_url":"https://api.github.com/repos/brython-dev/brython/issues/events{/number}","events_url":"https://api.github.com/repos/brython-dev/brython/events","assignees_url":"https://api.github.com/repos/brython-dev/brython/assignees{/user}","branches_url":"https://api.github.com/repos/brython-dev/brython/branches{/branch}","tags_url":"https://api.github.com/repos/brython-dev/brython/tags","blobs_url":"https://api.github.com/repos/brython-dev/brython/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brython-dev/brython/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brython-dev/brython/git/refs{/sha}","trees_url":"https://api.github.com/repos/brython-dev/brython/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brython-dev/brython/statuses/{sha}","languages_url":"https://api.github.com/repos/brython-dev/brython/languages","stargazers_url":"https://api.github.com/repos/brython-dev/brython/stargazers","contributors_url":"https://api.github.com/repos/brython-dev/brython/contributors","subscribers_url":"https://api.github.com/repos/brython-dev/brython/subscribers","subscription_url":"https://api.github.com/repos/brython-dev/brython/subscription","commits_url":"https://api.github.com/repos/brython-dev/brython/commits{/sha}","git_commits_url":"https://api.github.com/repos/brython-dev/brython/git/commits{/sha}","comments_url":"https://api.github.com/repos/brython-dev/brython/comments{/number}","issue_comment_url":"https://api.github.com/repos/brython-dev/brython/issues/comments{/number}","contents_url":"https://api.github.com/repos/brython-dev/brython/contents/{+path}","compare_url":"https://api.github.com/repos/brython-dev/brython/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brython-dev/brython/merges","archive_url":"https://api.github.com/repos/brython-dev/brython/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brython-dev/brython/downloads","issues_url":"https://api.github.com/repos/brython-dev/brython/issues{/number}","pulls_url":"https://api.github.com/repos/brython-dev/brython/pulls{/number}","milestones_url":"https://api.github.com/repos/brython-dev/brython/milestones{/number}","notifications_url":"https://api.github.com/repos/brython-dev/brython/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brython-dev/brython/labels{/name}","releases_url":"https://api.github.com/repos/brython-dev/brython/releases{/id}","created_at":"2014-09-15T06:58:21Z","updated_at":"2015-08-31T11:45:28Z","pushed_at":"2015-08-31T19:15:59Z","git_url":"git://github.com/brython-dev/brython.git","ssh_url":"git@github.com:brython-dev/brython.git","clone_url":"https://github.com/brython-dev/brython.git","svn_url":"https://github.com/brython-dev/brython","homepage":null,"size":38379,"stargazers_count":689,"watchers_count":689,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":70,"mirror_url":null,"open_issues_count":47,"forks":70,"open_issues":47,"watchers":689,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/brython-dev/brython/pulls/256"},"html":{"href":"https://github.com/brython-dev/brython/pull/256"},"issue":{"href":"https://api.github.com/repos/brython-dev/brython/issues/256"},"comments":{"href":"https://api.github.com/repos/brython-dev/brython/issues/256/comments"},"review_comments":{"href":"https://api.github.com/repos/brython-dev/brython/pulls/256/comments"},"review_comment":{"href":"https://api.github.com/repos/brython-dev/brython/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/brython-dev/brython/pulls/256/commits"},"statuses":{"href":"https://api.github.com/repos/brython-dev/brython/statuses/7dad282461984403e30baae5989a26869384090b"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"PierreQuentel","id":3447215,"avatar_url":"https://avatars.githubusercontent.com/u/3447215?v=3","gravatar_id":"","url":"https://api.github.com/users/PierreQuentel","html_url":"https://github.com/PierreQuentel","followers_url":"https://api.github.com/users/PierreQuentel/followers","following_url":"https://api.github.com/users/PierreQuentel/following{/other_user}","gists_url":"https://api.github.com/users/PierreQuentel/gists{/gist_id}","starred_url":"https://api.github.com/users/PierreQuentel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PierreQuentel/subscriptions","organizations_url":"https://api.github.com/users/PierreQuentel/orgs","repos_url":"https://api.github.com/users/PierreQuentel/repos","events_url":"https://api.github.com/users/PierreQuentel/events{/privacy}","received_events_url":"https://api.github.com/users/PierreQuentel/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}