{"action":"closed","number":10,"pull_request":{"url":"https://api.github.com/repos/osrf/osrf_pycommon/pulls/10","id":38588820,"html_url":"https://github.com/osrf/osrf_pycommon/pull/10","diff_url":"https://github.com/osrf/osrf_pycommon/pull/10.diff","patch_url":"https://github.com/osrf/osrf_pycommon/pull/10.patch","issue_url":"https://api.github.com/repos/osrf/osrf_pycommon/issues/10","number":10,"state":"closed","locked":false,"title":"execute_process: Don't close all file descriptors","user":{"login":"jbohren","id":1253450,"avatar_url":"https://avatars.githubusercontent.com/u/1253450?v=3","gravatar_id":"","url":"https://api.github.com/users/jbohren","html_url":"https://github.com/jbohren","followers_url":"https://api.github.com/users/jbohren/followers","following_url":"https://api.github.com/users/jbohren/following{/other_user}","gists_url":"https://api.github.com/users/jbohren/gists{/gist_id}","starred_url":"https://api.github.com/users/jbohren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbohren/subscriptions","organizations_url":"https://api.github.com/users/jbohren/orgs","repos_url":"https://api.github.com/users/jbohren/repos","events_url":"https://api.github.com/users/jbohren/events{/privacy}","received_events_url":"https://api.github.com/users/jbohren/received_events","type":"User","site_admin":false},"body":"In Python 3.2, `close_fds` defaults to `True` whereas in Python 2.7 it defaulted to `False`. This breaks support for passing file descriptors to child processes in Python 3.2, which is required to support the GNU Make jobserver in catkin_tools (see https://github.com/catkin/catkin_tools/issues/208)\r\n\r\nFor more info, see here: https://docs.python.org/3.2/library/subprocess.html#popen-constructor\r\n\r\nI understand that this option could be exposed to the `osrf_pycommon` API, but this PR unifies behavior between Python 2 and Python 3.\r\n\r\nNote that while leaking file descriptors is bad, in Python 3.4 all file descriptors were made non-inheritable by default, so they still need to be explicitly flagged to be passed so subprocesses. \r\n\r\nFor more info on this, see here: http://legacy.python.org/dev/peps/pep-0446/","created_at":"2015-06-25T20:20:28Z","updated_at":"2015-08-11T05:14:41Z","closed_at":"2015-08-11T05:14:41Z","merged_at":"2015-08-11T05:14:41Z","merge_commit_sha":"1c193575e5f25886938e4b46907e7242dbe6f24e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/osrf/osrf_pycommon/pulls/10/commits","review_comments_url":"https://api.github.com/repos/osrf/osrf_pycommon/pulls/10/comments","review_comment_url":"https://api.github.com/repos/osrf/osrf_pycommon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/osrf/osrf_pycommon/issues/10/comments","statuses_url":"https://api.github.com/repos/osrf/osrf_pycommon/statuses/9d1992ebdaf5d595086a11132c070e7d9ce5bf22","head":{"label":"jbohren-forks:dont-close-fds","ref":"dont-close-fds","sha":"9d1992ebdaf5d595086a11132c070e7d9ce5bf22","user":{"login":"jbohren-forks","id":2775020,"avatar_url":"https://avatars.githubusercontent.com/u/2775020?v=3","gravatar_id":"","url":"https://api.github.com/users/jbohren-forks","html_url":"https://github.com/jbohren-forks","followers_url":"https://api.github.com/users/jbohren-forks/followers","following_url":"https://api.github.com/users/jbohren-forks/following{/other_user}","gists_url":"https://api.github.com/users/jbohren-forks/gists{/gist_id}","starred_url":"https://api.github.com/users/jbohren-forks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbohren-forks/subscriptions","organizations_url":"https://api.github.com/users/jbohren-forks/orgs","repos_url":"https://api.github.com/users/jbohren-forks/repos","events_url":"https://api.github.com/users/jbohren-forks/events{/privacy}","received_events_url":"https://api.github.com/users/jbohren-forks/received_events","type":"Organization","site_admin":false},"repo":{"id":38058117,"name":"osrf_pycommon","full_name":"jbohren-forks/osrf_pycommon","owner":{"login":"jbohren-forks","id":2775020,"avatar_url":"https://avatars.githubusercontent.com/u/2775020?v=3","gravatar_id":"","url":"https://api.github.com/users/jbohren-forks","html_url":"https://github.com/jbohren-forks","followers_url":"https://api.github.com/users/jbohren-forks/followers","following_url":"https://api.github.com/users/jbohren-forks/following{/other_user}","gists_url":"https://api.github.com/users/jbohren-forks/gists{/gist_id}","starred_url":"https://api.github.com/users/jbohren-forks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbohren-forks/subscriptions","organizations_url":"https://api.github.com/users/jbohren-forks/orgs","repos_url":"https://api.github.com/users/jbohren-forks/repos","events_url":"https://api.github.com/users/jbohren-forks/events{/privacy}","received_events_url":"https://api.github.com/users/jbohren-forks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jbohren-forks/osrf_pycommon","description":"Commonly needed Python modules, used by Python software developed at OSRF","fork":true,"url":"https://api.github.com/repos/jbohren-forks/osrf_pycommon","forks_url":"https://api.github.com/repos/jbohren-forks/osrf_pycommon/forks","keys_url":"https://api.github.com/repos/jbohren-forks/osrf_pycommon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jbohren-forks/osrf_pycommon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jbohren-forks/osrf_pycommon/teams","hooks_url":"https://api.github.com/repos/jbohren-forks/osrf_pycommon/hooks","issue_events_url":"https://api.github.com/repos/jbohren-forks/osrf_pycommon/issues/events{/number}","events_url":"https://api.github.com/repos/jbohren-forks/osrf_pycommon/events","assignees_url":"https://api.github.com/repos/jbohren-forks/osrf_pycommon/assignees{/user}","branches_url":"https://api.github.com/repos/jbohren-forks/osrf_pycommon/branches{/branch}","tags_url":"https://api.github.com/repos/jbohren-forks/osrf_pycommon/tags","blobs_url":"https://api.github.com/repos/jbohren-forks/osrf_pycommon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jbohren-forks/osrf_pycommon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jbohren-forks/osrf_pycommon/git/refs{/sha}","trees_url":"https://api.github.com/repos/jbohren-forks/osrf_pycommon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jbohren-forks/osrf_pycommon/statuses/{sha}","languages_url":"https://api.github.com/repos/jbohren-forks/osrf_pycommon/languages","stargazers_url":"https://api.github.com/repos/jbohren-forks/osrf_pycommon/stargazers","contributors_url":"https://api.github.com/repos/jbohren-forks/osrf_pycommon/contributors","subscribers_url":"https://api.github.com/repos/jbohren-forks/osrf_pycommon/subscribers","subscription_url":"https://api.github.com/repos/jbohren-forks/osrf_pycommon/subscription","commits_url":"https://api.github.com/repos/jbohren-forks/osrf_pycommon/commits{/sha}","git_commits_url":"https://api.github.com/repos/jbohren-forks/osrf_pycommon/git/commits{/sha}","comments_url":"https://api.github.com/repos/jbohren-forks/osrf_pycommon/comments{/number}","issue_comment_url":"https://api.github.com/repos/jbohren-forks/osrf_pycommon/issues/comments{/number}","contents_url":"https://api.github.com/repos/jbohren-forks/osrf_pycommon/contents/{+path}","compare_url":"https://api.github.com/repos/jbohren-forks/osrf_pycommon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jbohren-forks/osrf_pycommon/merges","archive_url":"https://api.github.com/repos/jbohren-forks/osrf_pycommon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jbohren-forks/osrf_pycommon/downloads","issues_url":"https://api.github.com/repos/jbohren-forks/osrf_pycommon/issues{/number}","pulls_url":"https://api.github.com/repos/jbohren-forks/osrf_pycommon/pulls{/number}","milestones_url":"https://api.github.com/repos/jbohren-forks/osrf_pycommon/milestones{/number}","notifications_url":"https://api.github.com/repos/jbohren-forks/osrf_pycommon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jbohren-forks/osrf_pycommon/labels{/name}","releases_url":"https://api.github.com/repos/jbohren-forks/osrf_pycommon/releases{/id}","created_at":"2015-06-25T15:36:46Z","updated_at":"2015-06-25T15:36:46Z","pushed_at":"2015-06-29T14:23:31Z","git_url":"git://github.com/jbohren-forks/osrf_pycommon.git","ssh_url":"git@github.com:jbohren-forks/osrf_pycommon.git","clone_url":"https://github.com/jbohren-forks/osrf_pycommon.git","svn_url":"https://github.com/jbohren-forks/osrf_pycommon","homepage":"http://osrf-pycommon.readthedocs.org/","size":166,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"osrf:master","ref":"master","sha":"845590f113a3438065b4c9ec920c6a3229461bf3","user":{"login":"osrf","id":3999730,"avatar_url":"https://avatars.githubusercontent.com/u/3999730?v=3","gravatar_id":"","url":"https://api.github.com/users/osrf","html_url":"https://github.com/osrf","followers_url":"https://api.github.com/users/osrf/followers","following_url":"https://api.github.com/users/osrf/following{/other_user}","gists_url":"https://api.github.com/users/osrf/gists{/gist_id}","starred_url":"https://api.github.com/users/osrf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osrf/subscriptions","organizations_url":"https://api.github.com/users/osrf/orgs","repos_url":"https://api.github.com/users/osrf/repos","events_url":"https://api.github.com/users/osrf/events{/privacy}","received_events_url":"https://api.github.com/users/osrf/received_events","type":"Organization","site_admin":false},"repo":{"id":19592058,"name":"osrf_pycommon","full_name":"osrf/osrf_pycommon","owner":{"login":"osrf","id":3999730,"avatar_url":"https://avatars.githubusercontent.com/u/3999730?v=3","gravatar_id":"","url":"https://api.github.com/users/osrf","html_url":"https://github.com/osrf","followers_url":"https://api.github.com/users/osrf/followers","following_url":"https://api.github.com/users/osrf/following{/other_user}","gists_url":"https://api.github.com/users/osrf/gists{/gist_id}","starred_url":"https://api.github.com/users/osrf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osrf/subscriptions","organizations_url":"https://api.github.com/users/osrf/orgs","repos_url":"https://api.github.com/users/osrf/repos","events_url":"https://api.github.com/users/osrf/events{/privacy}","received_events_url":"https://api.github.com/users/osrf/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/osrf/osrf_pycommon","description":"Commonly needed Python modules, used by Python software developed at OSRF","fork":false,"url":"https://api.github.com/repos/osrf/osrf_pycommon","forks_url":"https://api.github.com/repos/osrf/osrf_pycommon/forks","keys_url":"https://api.github.com/repos/osrf/osrf_pycommon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/osrf/osrf_pycommon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/osrf/osrf_pycommon/teams","hooks_url":"https://api.github.com/repos/osrf/osrf_pycommon/hooks","issue_events_url":"https://api.github.com/repos/osrf/osrf_pycommon/issues/events{/number}","events_url":"https://api.github.com/repos/osrf/osrf_pycommon/events","assignees_url":"https://api.github.com/repos/osrf/osrf_pycommon/assignees{/user}","branches_url":"https://api.github.com/repos/osrf/osrf_pycommon/branches{/branch}","tags_url":"https://api.github.com/repos/osrf/osrf_pycommon/tags","blobs_url":"https://api.github.com/repos/osrf/osrf_pycommon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/osrf/osrf_pycommon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/osrf/osrf_pycommon/git/refs{/sha}","trees_url":"https://api.github.com/repos/osrf/osrf_pycommon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/osrf/osrf_pycommon/statuses/{sha}","languages_url":"https://api.github.com/repos/osrf/osrf_pycommon/languages","stargazers_url":"https://api.github.com/repos/osrf/osrf_pycommon/stargazers","contributors_url":"https://api.github.com/repos/osrf/osrf_pycommon/contributors","subscribers_url":"https://api.github.com/repos/osrf/osrf_pycommon/subscribers","subscription_url":"https://api.github.com/repos/osrf/osrf_pycommon/subscription","commits_url":"https://api.github.com/repos/osrf/osrf_pycommon/commits{/sha}","git_commits_url":"https://api.github.com/repos/osrf/osrf_pycommon/git/commits{/sha}","comments_url":"https://api.github.com/repos/osrf/osrf_pycommon/comments{/number}","issue_comment_url":"https://api.github.com/repos/osrf/osrf_pycommon/issues/comments{/number}","contents_url":"https://api.github.com/repos/osrf/osrf_pycommon/contents/{+path}","compare_url":"https://api.github.com/repos/osrf/osrf_pycommon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/osrf/osrf_pycommon/merges","archive_url":"https://api.github.com/repos/osrf/osrf_pycommon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/osrf/osrf_pycommon/downloads","issues_url":"https://api.github.com/repos/osrf/osrf_pycommon/issues{/number}","pulls_url":"https://api.github.com/repos/osrf/osrf_pycommon/pulls{/number}","milestones_url":"https://api.github.com/repos/osrf/osrf_pycommon/milestones{/number}","notifications_url":"https://api.github.com/repos/osrf/osrf_pycommon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/osrf/osrf_pycommon/labels{/name}","releases_url":"https://api.github.com/repos/osrf/osrf_pycommon/releases{/id}","created_at":"2014-05-08T23:11:16Z","updated_at":"2015-04-08T21:43:45Z","pushed_at":"2015-08-11T05:14:41Z","git_url":"git://github.com/osrf/osrf_pycommon.git","ssh_url":"git@github.com:osrf/osrf_pycommon.git","clone_url":"https://github.com/osrf/osrf_pycommon.git","svn_url":"https://github.com/osrf/osrf_pycommon","homepage":"http://osrf-pycommon.readthedocs.org/","size":460,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/osrf/osrf_pycommon/pulls/10"},"html":{"href":"https://github.com/osrf/osrf_pycommon/pull/10"},"issue":{"href":"https://api.github.com/repos/osrf/osrf_pycommon/issues/10"},"comments":{"href":"https://api.github.com/repos/osrf/osrf_pycommon/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/osrf/osrf_pycommon/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/osrf/osrf_pycommon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/osrf/osrf_pycommon/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/osrf/osrf_pycommon/statuses/9d1992ebdaf5d595086a11132c070e7d9ce5bf22"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"wjwwood","id":100427,"avatar_url":"https://avatars.githubusercontent.com/u/100427?v=3","gravatar_id":"","url":"https://api.github.com/users/wjwwood","html_url":"https://github.com/wjwwood","followers_url":"https://api.github.com/users/wjwwood/followers","following_url":"https://api.github.com/users/wjwwood/following{/other_user}","gists_url":"https://api.github.com/users/wjwwood/gists{/gist_id}","starred_url":"https://api.github.com/users/wjwwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wjwwood/subscriptions","organizations_url":"https://api.github.com/users/wjwwood/orgs","repos_url":"https://api.github.com/users/wjwwood/repos","events_url":"https://api.github.com/users/wjwwood/events{/privacy}","received_events_url":"https://api.github.com/users/wjwwood/received_events","type":"User","site_admin":false},"comments":5,"review_comments":0,"commits":1,"additions":20,"deletions":11,"changed_files":5}}