{"action":"closed","number":3,"pull_request":{"url":"https://api.github.com/repos/binarygeotech/fatfree-core/pulls/3","id":36565355,"html_url":"https://github.com/binarygeotech/fatfree-core/pull/3","diff_url":"https://github.com/binarygeotech/fatfree-core/pull/3.diff","patch_url":"https://github.com/binarygeotech/fatfree-core/pull/3.patch","issue_url":"https://api.github.com/repos/binarygeotech/fatfree-core/issues/3","number":3,"state":"closed","locked":false,"title":"Removing strict preg_match for 'include' tag","user":{"login":"binarygeotech","id":6354982,"avatar_url":"https://avatars.githubusercontent.com/u/6354982?v=3","gravatar_id":"","url":"https://api.github.com/users/binarygeotech","html_url":"https://github.com/binarygeotech","followers_url":"https://api.github.com/users/binarygeotech/followers","following_url":"https://api.github.com/users/binarygeotech/following{/other_user}","gists_url":"https://api.github.com/users/binarygeotech/gists{/gist_id}","starred_url":"https://api.github.com/users/binarygeotech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/binarygeotech/subscriptions","organizations_url":"https://api.github.com/users/binarygeotech/orgs","repos_url":"https://api.github.com/users/binarygeotech/repos","events_url":"https://api.github.com/users/binarygeotech/events{/privacy}","received_events_url":"https://api.github.com/users/binarygeotech/received_events","type":"User","site_admin":false},"body":"In previous version, I was able to use the include tag this way without error;\r\n\r\n```` <include href=\"{{@temp_base}}.{{@section}}.'header.html'\" /> ````\r\n\r\nafter updating to the latest version, I received\r\n\r\n``` 500 Internal Server Error ```, in the trace, I saw ```` {{@temp_base}}.{{@section}}.'header.html' not found ````.\r\n\r\nit only accepts\r\n\r\n```` <include href=\"{{@temp_base}}.{{@section}}.{{@header_file}}\" /> ````\r\n \r\nAfter several debugging, I noticed this ```` preg_match ```` in template.php line 76;\r\n```` preg_match('/^\\{\\{(.+?)\\}\\}$/',$attrib['href']) ```` which restricts the ``` href ``` value to declared variables or strings only, mixture not allowed.\r\n\r\nThis little fix save me from the error by allowing mix value in the href attribute of the include tag.","created_at":"2015-05-30T13:12:29Z","updated_at":"2015-05-30T13:12:45Z","closed_at":"2015-05-30T13:12:44Z","merged_at":"2015-05-30T13:12:44Z","merge_commit_sha":"521e182df41bda2c90697f7ce9cdc835ebd94abc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/binarygeotech/fatfree-core/pulls/3/commits","review_comments_url":"https://api.github.com/repos/binarygeotech/fatfree-core/pulls/3/comments","review_comment_url":"https://api.github.com/repos/binarygeotech/fatfree-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/binarygeotech/fatfree-core/issues/3/comments","statuses_url":"https://api.github.com/repos/binarygeotech/fatfree-core/statuses/3233b6cfd98dadd07d181238e133a1f59dfc144f","head":{"label":"binarygeotech:binarygeotech-template_include-patch","ref":"binarygeotech-template_include-patch","sha":"3233b6cfd98dadd07d181238e133a1f59dfc144f","user":{"login":"binarygeotech","id":6354982,"avatar_url":"https://avatars.githubusercontent.com/u/6354982?v=3","gravatar_id":"","url":"https://api.github.com/users/binarygeotech","html_url":"https://github.com/binarygeotech","followers_url":"https://api.github.com/users/binarygeotech/followers","following_url":"https://api.github.com/users/binarygeotech/following{/other_user}","gists_url":"https://api.github.com/users/binarygeotech/gists{/gist_id}","starred_url":"https://api.github.com/users/binarygeotech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/binarygeotech/subscriptions","organizations_url":"https://api.github.com/users/binarygeotech/orgs","repos_url":"https://api.github.com/users/binarygeotech/repos","events_url":"https://api.github.com/users/binarygeotech/events{/privacy}","received_events_url":"https://api.github.com/users/binarygeotech/received_events","type":"User","site_admin":false},"repo":{"id":28697782,"name":"fatfree-core","full_name":"binarygeotech/fatfree-core","owner":{"login":"binarygeotech","id":6354982,"avatar_url":"https://avatars.githubusercontent.com/u/6354982?v=3","gravatar_id":"","url":"https://api.github.com/users/binarygeotech","html_url":"https://github.com/binarygeotech","followers_url":"https://api.github.com/users/binarygeotech/followers","following_url":"https://api.github.com/users/binarygeotech/following{/other_user}","gists_url":"https://api.github.com/users/binarygeotech/gists{/gist_id}","starred_url":"https://api.github.com/users/binarygeotech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/binarygeotech/subscriptions","organizations_url":"https://api.github.com/users/binarygeotech/orgs","repos_url":"https://api.github.com/users/binarygeotech/repos","events_url":"https://api.github.com/users/binarygeotech/events{/privacy}","received_events_url":"https://api.github.com/users/binarygeotech/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/binarygeotech/fatfree-core","description":"Fat-Free Framework core library","fork":true,"url":"https://api.github.com/repos/binarygeotech/fatfree-core","forks_url":"https://api.github.com/repos/binarygeotech/fatfree-core/forks","keys_url":"https://api.github.com/repos/binarygeotech/fatfree-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/binarygeotech/fatfree-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/binarygeotech/fatfree-core/teams","hooks_url":"https://api.github.com/repos/binarygeotech/fatfree-core/hooks","issue_events_url":"https://api.github.com/repos/binarygeotech/fatfree-core/issues/events{/number}","events_url":"https://api.github.com/repos/binarygeotech/fatfree-core/events","assignees_url":"https://api.github.com/repos/binarygeotech/fatfree-core/assignees{/user}","branches_url":"https://api.github.com/repos/binarygeotech/fatfree-core/branches{/branch}","tags_url":"https://api.github.com/repos/binarygeotech/fatfree-core/tags","blobs_url":"https://api.github.com/repos/binarygeotech/fatfree-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/binarygeotech/fatfree-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/binarygeotech/fatfree-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/binarygeotech/fatfree-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/binarygeotech/fatfree-core/statuses/{sha}","languages_url":"https://api.github.com/repos/binarygeotech/fatfree-core/languages","stargazers_url":"https://api.github.com/repos/binarygeotech/fatfree-core/stargazers","contributors_url":"https://api.github.com/repos/binarygeotech/fatfree-core/contributors","subscribers_url":"https://api.github.com/repos/binarygeotech/fatfree-core/subscribers","subscription_url":"https://api.github.com/repos/binarygeotech/fatfree-core/subscription","commits_url":"https://api.github.com/repos/binarygeotech/fatfree-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/binarygeotech/fatfree-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/binarygeotech/fatfree-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/binarygeotech/fatfree-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/binarygeotech/fatfree-core/contents/{+path}","compare_url":"https://api.github.com/repos/binarygeotech/fatfree-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/binarygeotech/fatfree-core/merges","archive_url":"https://api.github.com/repos/binarygeotech/fatfree-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/binarygeotech/fatfree-core/downloads","issues_url":"https://api.github.com/repos/binarygeotech/fatfree-core/issues{/number}","pulls_url":"https://api.github.com/repos/binarygeotech/fatfree-core/pulls{/number}","milestones_url":"https://api.github.com/repos/binarygeotech/fatfree-core/milestones{/number}","notifications_url":"https://api.github.com/repos/binarygeotech/fatfree-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/binarygeotech/fatfree-core/labels{/name}","releases_url":"https://api.github.com/repos/binarygeotech/fatfree-core/releases{/id}","created_at":"2015-01-01T22:55:03Z","updated_at":"2015-05-25T17:55:11Z","pushed_at":"2015-05-30T13:12:45Z","git_url":"git://github.com/binarygeotech/fatfree-core.git","ssh_url":"git@github.com:binarygeotech/fatfree-core.git","clone_url":"https://github.com/binarygeotech/fatfree-core.git","svn_url":"https://github.com/binarygeotech/fatfree-core","homepage":null,"size":11092,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"binarygeotech:master","ref":"master","sha":"9fd5f74dc8ec536ade91d40d2d945578b24db4c9","user":{"login":"binarygeotech","id":6354982,"avatar_url":"https://avatars.githubusercontent.com/u/6354982?v=3","gravatar_id":"","url":"https://api.github.com/users/binarygeotech","html_url":"https://github.com/binarygeotech","followers_url":"https://api.github.com/users/binarygeotech/followers","following_url":"https://api.github.com/users/binarygeotech/following{/other_user}","gists_url":"https://api.github.com/users/binarygeotech/gists{/gist_id}","starred_url":"https://api.github.com/users/binarygeotech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/binarygeotech/subscriptions","organizations_url":"https://api.github.com/users/binarygeotech/orgs","repos_url":"https://api.github.com/users/binarygeotech/repos","events_url":"https://api.github.com/users/binarygeotech/events{/privacy}","received_events_url":"https://api.github.com/users/binarygeotech/received_events","type":"User","site_admin":false},"repo":{"id":28697782,"name":"fatfree-core","full_name":"binarygeotech/fatfree-core","owner":{"login":"binarygeotech","id":6354982,"avatar_url":"https://avatars.githubusercontent.com/u/6354982?v=3","gravatar_id":"","url":"https://api.github.com/users/binarygeotech","html_url":"https://github.com/binarygeotech","followers_url":"https://api.github.com/users/binarygeotech/followers","following_url":"https://api.github.com/users/binarygeotech/following{/other_user}","gists_url":"https://api.github.com/users/binarygeotech/gists{/gist_id}","starred_url":"https://api.github.com/users/binarygeotech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/binarygeotech/subscriptions","organizations_url":"https://api.github.com/users/binarygeotech/orgs","repos_url":"https://api.github.com/users/binarygeotech/repos","events_url":"https://api.github.com/users/binarygeotech/events{/privacy}","received_events_url":"https://api.github.com/users/binarygeotech/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/binarygeotech/fatfree-core","description":"Fat-Free Framework core library","fork":true,"url":"https://api.github.com/repos/binarygeotech/fatfree-core","forks_url":"https://api.github.com/repos/binarygeotech/fatfree-core/forks","keys_url":"https://api.github.com/repos/binarygeotech/fatfree-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/binarygeotech/fatfree-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/binarygeotech/fatfree-core/teams","hooks_url":"https://api.github.com/repos/binarygeotech/fatfree-core/hooks","issue_events_url":"https://api.github.com/repos/binarygeotech/fatfree-core/issues/events{/number}","events_url":"https://api.github.com/repos/binarygeotech/fatfree-core/events","assignees_url":"https://api.github.com/repos/binarygeotech/fatfree-core/assignees{/user}","branches_url":"https://api.github.com/repos/binarygeotech/fatfree-core/branches{/branch}","tags_url":"https://api.github.com/repos/binarygeotech/fatfree-core/tags","blobs_url":"https://api.github.com/repos/binarygeotech/fatfree-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/binarygeotech/fatfree-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/binarygeotech/fatfree-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/binarygeotech/fatfree-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/binarygeotech/fatfree-core/statuses/{sha}","languages_url":"https://api.github.com/repos/binarygeotech/fatfree-core/languages","stargazers_url":"https://api.github.com/repos/binarygeotech/fatfree-core/stargazers","contributors_url":"https://api.github.com/repos/binarygeotech/fatfree-core/contributors","subscribers_url":"https://api.github.com/repos/binarygeotech/fatfree-core/subscribers","subscription_url":"https://api.github.com/repos/binarygeotech/fatfree-core/subscription","commits_url":"https://api.github.com/repos/binarygeotech/fatfree-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/binarygeotech/fatfree-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/binarygeotech/fatfree-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/binarygeotech/fatfree-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/binarygeotech/fatfree-core/contents/{+path}","compare_url":"https://api.github.com/repos/binarygeotech/fatfree-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/binarygeotech/fatfree-core/merges","archive_url":"https://api.github.com/repos/binarygeotech/fatfree-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/binarygeotech/fatfree-core/downloads","issues_url":"https://api.github.com/repos/binarygeotech/fatfree-core/issues{/number}","pulls_url":"https://api.github.com/repos/binarygeotech/fatfree-core/pulls{/number}","milestones_url":"https://api.github.com/repos/binarygeotech/fatfree-core/milestones{/number}","notifications_url":"https://api.github.com/repos/binarygeotech/fatfree-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/binarygeotech/fatfree-core/labels{/name}","releases_url":"https://api.github.com/repos/binarygeotech/fatfree-core/releases{/id}","created_at":"2015-01-01T22:55:03Z","updated_at":"2015-05-25T17:55:11Z","pushed_at":"2015-05-30T13:12:45Z","git_url":"git://github.com/binarygeotech/fatfree-core.git","ssh_url":"git@github.com:binarygeotech/fatfree-core.git","clone_url":"https://github.com/binarygeotech/fatfree-core.git","svn_url":"https://github.com/binarygeotech/fatfree-core","homepage":null,"size":11092,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/binarygeotech/fatfree-core/pulls/3"},"html":{"href":"https://github.com/binarygeotech/fatfree-core/pull/3"},"issue":{"href":"https://api.github.com/repos/binarygeotech/fatfree-core/issues/3"},"comments":{"href":"https://api.github.com/repos/binarygeotech/fatfree-core/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/binarygeotech/fatfree-core/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/binarygeotech/fatfree-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/binarygeotech/fatfree-core/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/binarygeotech/fatfree-core/statuses/3233b6cfd98dadd07d181238e133a1f59dfc144f"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"binarygeotech","id":6354982,"avatar_url":"https://avatars.githubusercontent.com/u/6354982?v=3","gravatar_id":"","url":"https://api.github.com/users/binarygeotech","html_url":"https://github.com/binarygeotech","followers_url":"https://api.github.com/users/binarygeotech/followers","following_url":"https://api.github.com/users/binarygeotech/following{/other_user}","gists_url":"https://api.github.com/users/binarygeotech/gists{/gist_id}","starred_url":"https://api.github.com/users/binarygeotech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/binarygeotech/subscriptions","organizations_url":"https://api.github.com/users/binarygeotech/orgs","repos_url":"https://api.github.com/users/binarygeotech/repos","events_url":"https://api.github.com/users/binarygeotech/events{/privacy}","received_events_url":"https://api.github.com/users/binarygeotech/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}