{"action":"created","comment":{"url":"https://api.github.com/repos/RPCS3/rpcs3/pulls/comments/37055350","id":37055350,"diff_hunk":"@@ -1,40 +1,129 @@\n #include \"stdafx.h\"\n #include \"Emu/Memory/Memory.h\"\n #include \"Emu/System.h\"\n+#include \"Emu/IdManager.h\"\n #include \"Emu/SysCalls/Modules.h\"\n \n #include \"sysPrxForUser.h\"\n \n extern Module sysPrxForUser;\n \n+using sys_mempool_t = u32;\n+\n+struct memory_pool_t","path":"rpcs3/Emu/SysCalls/Modules/sys_mempool.cpp","position":13,"original_position":13,"commit_id":"b03ef0e08a117d3f9efadbda026ff7d9cec1c86f","original_commit_id":"b03ef0e08a117d3f9efadbda026ff7d9cec1c86f","user":{"login":"tambry","id":1827708,"avatar_url":"https://avatars.githubusercontent.com/u/1827708?v=3","gravatar_id":"","url":"https://api.github.com/users/tambry","html_url":"https://github.com/tambry","followers_url":"https://api.github.com/users/tambry/followers","following_url":"https://api.github.com/users/tambry/following{/other_user}","gists_url":"https://api.github.com/users/tambry/gists{/gist_id}","starred_url":"https://api.github.com/users/tambry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tambry/subscriptions","organizations_url":"https://api.github.com/users/tambry/orgs","repos_url":"https://api.github.com/users/tambry/repos","events_url":"https://api.github.com/users/tambry/events{/privacy}","received_events_url":"https://api.github.com/users/tambry/received_events","type":"User","site_admin":false},"body":"@KaOs1 It is overall still prefered to put all the typdefs/structs/etc into headers to keep the .cpp from being \"bloated\" (especially, when there are a lot of typdefs/structs/etc). Plus it would be nice to keep it consistent, with rest of the emulator.","created_at":"2015-08-14T07:40:10Z","updated_at":"2015-08-14T07:40:10Z","html_url":"https://github.com/RPCS3/rpcs3/pull/1179#discussion_r37055350","pull_request_url":"https://api.github.com/repos/RPCS3/rpcs3/pulls/1179","_links":{"self":{"href":"https://api.github.com/repos/RPCS3/rpcs3/pulls/comments/37055350"},"html":{"href":"https://github.com/RPCS3/rpcs3/pull/1179#discussion_r37055350"},"pull_request":{"href":"https://api.github.com/repos/RPCS3/rpcs3/pulls/1179"}}},"pull_request":{"url":"https://api.github.com/repos/RPCS3/rpcs3/pulls/1179","id":42372434,"html_url":"https://github.com/RPCS3/rpcs3/pull/1179","diff_url":"https://github.com/RPCS3/rpcs3/pull/1179.diff","patch_url":"https://github.com/RPCS3/rpcs3/pull/1179.patch","issue_url":"https://api.github.com/repos/RPCS3/rpcs3/issues/1179","number":1179,"state":"open","locked":false,"title":"sys_mempool implemented","user":{"login":"KaOs1","id":8782059,"avatar_url":"https://avatars.githubusercontent.com/u/8782059?v=3","gravatar_id":"","url":"https://api.github.com/users/KaOs1","html_url":"https://github.com/KaOs1","followers_url":"https://api.github.com/users/KaOs1/followers","following_url":"https://api.github.com/users/KaOs1/following{/other_user}","gists_url":"https://api.github.com/users/KaOs1/gists{/gist_id}","starred_url":"https://api.github.com/users/KaOs1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KaOs1/subscriptions","organizations_url":"https://api.github.com/users/KaOs1/orgs","repos_url":"https://api.github.com/users/KaOs1/repos","events_url":"https://api.github.com/users/KaOs1/events{/privacy}","received_events_url":"https://api.github.com/users/KaOs1/received_events","type":"User","site_admin":false},"body":"Afro Samurai Demo [NPUB90215] boots (to a black screen) with this commit","created_at":"2015-08-13T16:45:33Z","updated_at":"2015-08-14T07:40:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"576618af52e8c1f3f7bff95ed64a1f46d4d7cc25","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/RPCS3/rpcs3/pulls/1179/commits","review_comments_url":"https://api.github.com/repos/RPCS3/rpcs3/pulls/1179/comments","review_comment_url":"https://api.github.com/repos/RPCS3/rpcs3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RPCS3/rpcs3/issues/1179/comments","statuses_url":"https://api.github.com/repos/RPCS3/rpcs3/statuses/b03ef0e08a117d3f9efadbda026ff7d9cec1c86f","head":{"label":"KaOs1:master","ref":"master","sha":"b03ef0e08a117d3f9efadbda026ff7d9cec1c86f","user":{"login":"KaOs1","id":8782059,"avatar_url":"https://avatars.githubusercontent.com/u/8782059?v=3","gravatar_id":"","url":"https://api.github.com/users/KaOs1","html_url":"https://github.com/KaOs1","followers_url":"https://api.github.com/users/KaOs1/followers","following_url":"https://api.github.com/users/KaOs1/following{/other_user}","gists_url":"https://api.github.com/users/KaOs1/gists{/gist_id}","starred_url":"https://api.github.com/users/KaOs1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KaOs1/subscriptions","organizations_url":"https://api.github.com/users/KaOs1/orgs","repos_url":"https://api.github.com/users/KaOs1/repos","events_url":"https://api.github.com/users/KaOs1/events{/privacy}","received_events_url":"https://api.github.com/users/KaOs1/received_events","type":"User","site_admin":false},"repo":{"id":40623171,"name":"rpcs3","full_name":"KaOs1/rpcs3","owner":{"login":"KaOs1","id":8782059,"avatar_url":"https://avatars.githubusercontent.com/u/8782059?v=3","gravatar_id":"","url":"https://api.github.com/users/KaOs1","html_url":"https://github.com/KaOs1","followers_url":"https://api.github.com/users/KaOs1/followers","following_url":"https://api.github.com/users/KaOs1/following{/other_user}","gists_url":"https://api.github.com/users/KaOs1/gists{/gist_id}","starred_url":"https://api.github.com/users/KaOs1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KaOs1/subscriptions","organizations_url":"https://api.github.com/users/KaOs1/orgs","repos_url":"https://api.github.com/users/KaOs1/repos","events_url":"https://api.github.com/users/KaOs1/events{/privacy}","received_events_url":"https://api.github.com/users/KaOs1/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/KaOs1/rpcs3","description":"PS3 emulator/debugger","fork":true,"url":"https://api.github.com/repos/KaOs1/rpcs3","forks_url":"https://api.github.com/repos/KaOs1/rpcs3/forks","keys_url":"https://api.github.com/repos/KaOs1/rpcs3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KaOs1/rpcs3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KaOs1/rpcs3/teams","hooks_url":"https://api.github.com/repos/KaOs1/rpcs3/hooks","issue_events_url":"https://api.github.com/repos/KaOs1/rpcs3/issues/events{/number}","events_url":"https://api.github.com/repos/KaOs1/rpcs3/events","assignees_url":"https://api.github.com/repos/KaOs1/rpcs3/assignees{/user}","branches_url":"https://api.github.com/repos/KaOs1/rpcs3/branches{/branch}","tags_url":"https://api.github.com/repos/KaOs1/rpcs3/tags","blobs_url":"https://api.github.com/repos/KaOs1/rpcs3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KaOs1/rpcs3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KaOs1/rpcs3/git/refs{/sha}","trees_url":"https://api.github.com/repos/KaOs1/rpcs3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KaOs1/rpcs3/statuses/{sha}","languages_url":"https://api.github.com/repos/KaOs1/rpcs3/languages","stargazers_url":"https://api.github.com/repos/KaOs1/rpcs3/stargazers","contributors_url":"https://api.github.com/repos/KaOs1/rpcs3/contributors","subscribers_url":"https://api.github.com/repos/KaOs1/rpcs3/subscribers","subscription_url":"https://api.github.com/repos/KaOs1/rpcs3/subscription","commits_url":"https://api.github.com/repos/KaOs1/rpcs3/commits{/sha}","git_commits_url":"https://api.github.com/repos/KaOs1/rpcs3/git/commits{/sha}","comments_url":"https://api.github.com/repos/KaOs1/rpcs3/comments{/number}","issue_comment_url":"https://api.github.com/repos/KaOs1/rpcs3/issues/comments{/number}","contents_url":"https://api.github.com/repos/KaOs1/rpcs3/contents/{+path}","compare_url":"https://api.github.com/repos/KaOs1/rpcs3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KaOs1/rpcs3/merges","archive_url":"https://api.github.com/repos/KaOs1/rpcs3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KaOs1/rpcs3/downloads","issues_url":"https://api.github.com/repos/KaOs1/rpcs3/issues{/number}","pulls_url":"https://api.github.com/repos/KaOs1/rpcs3/pulls{/number}","milestones_url":"https://api.github.com/repos/KaOs1/rpcs3/milestones{/number}","notifications_url":"https://api.github.com/repos/KaOs1/rpcs3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KaOs1/rpcs3/labels{/name}","releases_url":"https://api.github.com/repos/KaOs1/rpcs3/releases{/id}","created_at":"2015-08-12T20:38:47Z","updated_at":"2015-08-12T20:38:50Z","pushed_at":"2015-08-13T16:42:34Z","git_url":"git://github.com/KaOs1/rpcs3.git","ssh_url":"git@github.com:KaOs1/rpcs3.git","clone_url":"https://github.com/KaOs1/rpcs3.git","svn_url":"https://github.com/KaOs1/rpcs3","homepage":null,"size":24271,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"RPCS3:master","ref":"master","sha":"07f33a3809edd5e5d63587ff086e2bb21d668fc3","user":{"login":"RPCS3","id":8070735,"avatar_url":"https://avatars.githubusercontent.com/u/8070735?v=3","gravatar_id":"","url":"https://api.github.com/users/RPCS3","html_url":"https://github.com/RPCS3","followers_url":"https://api.github.com/users/RPCS3/followers","following_url":"https://api.github.com/users/RPCS3/following{/other_user}","gists_url":"https://api.github.com/users/RPCS3/gists{/gist_id}","starred_url":"https://api.github.com/users/RPCS3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RPCS3/subscriptions","organizations_url":"https://api.github.com/users/RPCS3/orgs","repos_url":"https://api.github.com/users/RPCS3/repos","events_url":"https://api.github.com/users/RPCS3/events{/privacy}","received_events_url":"https://api.github.com/users/RPCS3/received_events","type":"Organization","site_admin":false},"repo":{"id":6520784,"name":"rpcs3","full_name":"RPCS3/rpcs3","owner":{"login":"RPCS3","id":8070735,"avatar_url":"https://avatars.githubusercontent.com/u/8070735?v=3","gravatar_id":"","url":"https://api.github.com/users/RPCS3","html_url":"https://github.com/RPCS3","followers_url":"https://api.github.com/users/RPCS3/followers","following_url":"https://api.github.com/users/RPCS3/following{/other_user}","gists_url":"https://api.github.com/users/RPCS3/gists{/gist_id}","starred_url":"https://api.github.com/users/RPCS3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RPCS3/subscriptions","organizations_url":"https://api.github.com/users/RPCS3/orgs","repos_url":"https://api.github.com/users/RPCS3/repos","events_url":"https://api.github.com/users/RPCS3/events{/privacy}","received_events_url":"https://api.github.com/users/RPCS3/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RPCS3/rpcs3","description":"PS3 emulator/debugger","fork":false,"url":"https://api.github.com/repos/RPCS3/rpcs3","forks_url":"https://api.github.com/repos/RPCS3/rpcs3/forks","keys_url":"https://api.github.com/repos/RPCS3/rpcs3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RPCS3/rpcs3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RPCS3/rpcs3/teams","hooks_url":"https://api.github.com/repos/RPCS3/rpcs3/hooks","issue_events_url":"https://api.github.com/repos/RPCS3/rpcs3/issues/events{/number}","events_url":"https://api.github.com/repos/RPCS3/rpcs3/events","assignees_url":"https://api.github.com/repos/RPCS3/rpcs3/assignees{/user}","branches_url":"https://api.github.com/repos/RPCS3/rpcs3/branches{/branch}","tags_url":"https://api.github.com/repos/RPCS3/rpcs3/tags","blobs_url":"https://api.github.com/repos/RPCS3/rpcs3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RPCS3/rpcs3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RPCS3/rpcs3/git/refs{/sha}","trees_url":"https://api.github.com/repos/RPCS3/rpcs3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RPCS3/rpcs3/statuses/{sha}","languages_url":"https://api.github.com/repos/RPCS3/rpcs3/languages","stargazers_url":"https://api.github.com/repos/RPCS3/rpcs3/stargazers","contributors_url":"https://api.github.com/repos/RPCS3/rpcs3/contributors","subscribers_url":"https://api.github.com/repos/RPCS3/rpcs3/subscribers","subscription_url":"https://api.github.com/repos/RPCS3/rpcs3/subscription","commits_url":"https://api.github.com/repos/RPCS3/rpcs3/commits{/sha}","git_commits_url":"https://api.github.com/repos/RPCS3/rpcs3/git/commits{/sha}","comments_url":"https://api.github.com/repos/RPCS3/rpcs3/comments{/number}","issue_comment_url":"https://api.github.com/repos/RPCS3/rpcs3/issues/comments{/number}","contents_url":"https://api.github.com/repos/RPCS3/rpcs3/contents/{+path}","compare_url":"https://api.github.com/repos/RPCS3/rpcs3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RPCS3/rpcs3/merges","archive_url":"https://api.github.com/repos/RPCS3/rpcs3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RPCS3/rpcs3/downloads","issues_url":"https://api.github.com/repos/RPCS3/rpcs3/issues{/number}","pulls_url":"https://api.github.com/repos/RPCS3/rpcs3/pulls{/number}","milestones_url":"https://api.github.com/repos/RPCS3/rpcs3/milestones{/number}","notifications_url":"https://api.github.com/repos/RPCS3/rpcs3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RPCS3/rpcs3/labels{/name}","releases_url":"https://api.github.com/repos/RPCS3/rpcs3/releases{/id}","created_at":"2012-11-03T15:16:18Z","updated_at":"2015-08-13T21:10:06Z","pushed_at":"2015-08-13T22:29:47Z","git_url":"git://github.com/RPCS3/rpcs3.git","ssh_url":"git@github.com:RPCS3/rpcs3.git","clone_url":"https://github.com/RPCS3/rpcs3.git","svn_url":"https://github.com/RPCS3/rpcs3","homepage":null,"size":73242,"stargazers_count":1542,"watchers_count":1542,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":286,"mirror_url":null,"open_issues_count":36,"forks":286,"open_issues":36,"watchers":1542,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RPCS3/rpcs3/pulls/1179"},"html":{"href":"https://github.com/RPCS3/rpcs3/pull/1179"},"issue":{"href":"https://api.github.com/repos/RPCS3/rpcs3/issues/1179"},"comments":{"href":"https://api.github.com/repos/RPCS3/rpcs3/issues/1179/comments"},"review_comments":{"href":"https://api.github.com/repos/RPCS3/rpcs3/pulls/1179/comments"},"review_comment":{"href":"https://api.github.com/repos/RPCS3/rpcs3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RPCS3/rpcs3/pulls/1179/commits"},"statuses":{"href":"https://api.github.com/repos/RPCS3/rpcs3/statuses/b03ef0e08a117d3f9efadbda026ff7d9cec1c86f"}}}}