{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin/pulls/comments/36298846","id":36298846,"diff_hunk":"@@ -21,7 +21,9 @@ angular.module('openshiftConsole')\n       var containers = dcContainers(dc);\n       if (containers) {\n         angular.forEach(containers, function(container) {\n-          images.push(container.image);\n+          if (container.image) {","path":"assets/app/scripts/controllers/newfromtemplate.js","position":5,"original_position":5,"commit_id":"90a1f30d90d17a220f6bb68c4d523cd50cecdf23","original_commit_id":"90a1f30d90d17a220f6bb68c4d523cd50cecdf23","user":{"login":"jwforres","id":1467629,"avatar_url":"https://avatars.githubusercontent.com/u/1467629?v=3","gravatar_id":"","url":"https://api.github.com/users/jwforres","html_url":"https://github.com/jwforres","followers_url":"https://api.github.com/users/jwforres/followers","following_url":"https://api.github.com/users/jwforres/following{/other_user}","gists_url":"https://api.github.com/users/jwforres/gists{/gist_id}","starred_url":"https://api.github.com/users/jwforres/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwforres/subscriptions","organizations_url":"https://api.github.com/users/jwforres/orgs","repos_url":"https://api.github.com/users/jwforres/repos","events_url":"https://api.github.com/users/jwforres/events{/privacy}","received_events_url":"https://api.github.com/users/jwforres/received_events","type":"User","site_admin":false},"body":"just curious, in what case is container.image not defined / null ?","created_at":"2015-08-05T13:08:10Z","updated_at":"2015-08-05T13:08:10Z","html_url":"https://github.com/openshift/origin/pull/4000#discussion_r36298846","pull_request_url":"https://api.github.com/repos/openshift/origin/pulls/4000","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments/36298846"},"html":{"href":"https://github.com/openshift/origin/pull/4000#discussion_r36298846"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin/pulls/4000"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/4000","id":41603171,"html_url":"https://github.com/openshift/origin/pull/4000","diff_url":"https://github.com/openshift/origin/pull/4000.diff","patch_url":"https://github.com/openshift/origin/pull/4000.patch","issue_url":"https://api.github.com/repos/openshift/origin/issues/4000","number":4000,"state":"open","locked":false,"title":"[WIP] - Update UI to k8s API version v1","user":{"login":"spadgett","id":1167259,"avatar_url":"https://avatars.githubusercontent.com/u/1167259?v=3","gravatar_id":"","url":"https://api.github.com/users/spadgett","html_url":"https://github.com/spadgett","followers_url":"https://api.github.com/users/spadgett/followers","following_url":"https://api.github.com/users/spadgett/following{/other_user}","gists_url":"https://api.github.com/users/spadgett/gists{/gist_id}","starred_url":"https://api.github.com/users/spadgett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spadgett/subscriptions","organizations_url":"https://api.github.com/users/spadgett/orgs","repos_url":"https://api.github.com/users/spadgett/repos","events_url":"https://api.github.com/users/spadgett/events{/privacy}","received_events_url":"https://api.github.com/users/spadgett/received_events","type":"User","site_admin":false},"body":"Does not cover oapi/v1, only k8s. Still needs object describer changes.\r\n\r\nSee #2851 \r\n\r\n@liggitt @jwforres ","created_at":"2015-08-04T18:44:59Z","updated_at":"2015-08-05T13:08:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"59b97a04df41b2302d0187fc2231f542a2b95413","assignee":{"login":"liggitt","id":980082,"avatar_url":"https://avatars.githubusercontent.com/u/980082?v=3","gravatar_id":"","url":"https://api.github.com/users/liggitt","html_url":"https://github.com/liggitt","followers_url":"https://api.github.com/users/liggitt/followers","following_url":"https://api.github.com/users/liggitt/following{/other_user}","gists_url":"https://api.github.com/users/liggitt/gists{/gist_id}","starred_url":"https://api.github.com/users/liggitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liggitt/subscriptions","organizations_url":"https://api.github.com/users/liggitt/orgs","repos_url":"https://api.github.com/users/liggitt/repos","events_url":"https://api.github.com/users/liggitt/events{/privacy}","received_events_url":"https://api.github.com/users/liggitt/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin/pulls/4000/commits","review_comments_url":"https://api.github.com/repos/openshift/origin/pulls/4000/comments","review_comment_url":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin/issues/4000/comments","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/90a1f30d90d17a220f6bb68c4d523cd50cecdf23","head":{"label":"spadgett:k8s-v1-api","ref":"k8s-v1-api","sha":"90a1f30d90d17a220f6bb68c4d523cd50cecdf23","user":{"login":"spadgett","id":1167259,"avatar_url":"https://avatars.githubusercontent.com/u/1167259?v=3","gravatar_id":"","url":"https://api.github.com/users/spadgett","html_url":"https://github.com/spadgett","followers_url":"https://api.github.com/users/spadgett/followers","following_url":"https://api.github.com/users/spadgett/following{/other_user}","gists_url":"https://api.github.com/users/spadgett/gists{/gist_id}","starred_url":"https://api.github.com/users/spadgett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spadgett/subscriptions","organizations_url":"https://api.github.com/users/spadgett/orgs","repos_url":"https://api.github.com/users/spadgett/repos","events_url":"https://api.github.com/users/spadgett/events{/privacy}","received_events_url":"https://api.github.com/users/spadgett/received_events","type":"User","site_admin":false},"repo":{"id":34353535,"name":"origin","full_name":"spadgett/origin","owner":{"login":"spadgett","id":1167259,"avatar_url":"https://avatars.githubusercontent.com/u/1167259?v=3","gravatar_id":"","url":"https://api.github.com/users/spadgett","html_url":"https://github.com/spadgett","followers_url":"https://api.github.com/users/spadgett/followers","following_url":"https://api.github.com/users/spadgett/following{/other_user}","gists_url":"https://api.github.com/users/spadgett/gists{/gist_id}","starred_url":"https://api.github.com/users/spadgett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spadgett/subscriptions","organizations_url":"https://api.github.com/users/spadgett/orgs","repos_url":"https://api.github.com/users/spadgett/repos","events_url":"https://api.github.com/users/spadgett/events{/privacy}","received_events_url":"https://api.github.com/users/spadgett/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/spadgett/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":true,"url":"https://api.github.com/repos/spadgett/origin","forks_url":"https://api.github.com/repos/spadgett/origin/forks","keys_url":"https://api.github.com/repos/spadgett/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spadgett/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spadgett/origin/teams","hooks_url":"https://api.github.com/repos/spadgett/origin/hooks","issue_events_url":"https://api.github.com/repos/spadgett/origin/issues/events{/number}","events_url":"https://api.github.com/repos/spadgett/origin/events","assignees_url":"https://api.github.com/repos/spadgett/origin/assignees{/user}","branches_url":"https://api.github.com/repos/spadgett/origin/branches{/branch}","tags_url":"https://api.github.com/repos/spadgett/origin/tags","blobs_url":"https://api.github.com/repos/spadgett/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spadgett/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spadgett/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/spadgett/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spadgett/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/spadgett/origin/languages","stargazers_url":"https://api.github.com/repos/spadgett/origin/stargazers","contributors_url":"https://api.github.com/repos/spadgett/origin/contributors","subscribers_url":"https://api.github.com/repos/spadgett/origin/subscribers","subscription_url":"https://api.github.com/repos/spadgett/origin/subscription","commits_url":"https://api.github.com/repos/spadgett/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/spadgett/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/spadgett/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/spadgett/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/spadgett/origin/contents/{+path}","compare_url":"https://api.github.com/repos/spadgett/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spadgett/origin/merges","archive_url":"https://api.github.com/repos/spadgett/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spadgett/origin/downloads","issues_url":"https://api.github.com/repos/spadgett/origin/issues{/number}","pulls_url":"https://api.github.com/repos/spadgett/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/spadgett/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/spadgett/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spadgett/origin/labels{/name}","releases_url":"https://api.github.com/repos/spadgett/origin/releases{/id}","created_at":"2015-04-21T21:38:33Z","updated_at":"2015-05-08T19:33:23Z","pushed_at":"2015-08-05T12:38:12Z","git_url":"git://github.com/spadgett/origin.git","ssh_url":"git@github.com:spadgett/origin.git","clone_url":"https://github.com/spadgett/origin.git","svn_url":"https://github.com/spadgett/origin","homepage":"http://www.openshift.org","size":122440,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"786896fe77232f1db9f460abadb740a7a3323b66","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":22442668,"name":"origin","full_name":"openshift/origin","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":false,"url":"https://api.github.com/repos/openshift/origin","forks_url":"https://api.github.com/repos/openshift/origin/forks","keys_url":"https://api.github.com/repos/openshift/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin/teams","hooks_url":"https://api.github.com/repos/openshift/origin/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin/events","assignees_url":"https://api.github.com/repos/openshift/origin/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin/tags","blobs_url":"https://api.github.com/repos/openshift/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin/languages","stargazers_url":"https://api.github.com/repos/openshift/origin/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin/subscription","commits_url":"https://api.github.com/repos/openshift/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin/merges","archive_url":"https://api.github.com/repos/openshift/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin/downloads","issues_url":"https://api.github.com/repos/openshift/origin/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin/releases{/id}","created_at":"2014-07-30T20:04:05Z","updated_at":"2015-08-05T10:34:14Z","pushed_at":"2015-08-05T13:04:27Z","git_url":"git://github.com/openshift/origin.git","ssh_url":"git@github.com:openshift/origin.git","clone_url":"https://github.com/openshift/origin.git","svn_url":"https://github.com/openshift/origin","homepage":"http://www.openshift.org","size":209521,"stargazers_count":600,"watchers_count":600,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":337,"mirror_url":null,"open_issues_count":466,"forks":337,"open_issues":466,"watchers":600,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/4000"},"html":{"href":"https://github.com/openshift/origin/pull/4000"},"issue":{"href":"https://api.github.com/repos/openshift/origin/issues/4000"},"comments":{"href":"https://api.github.com/repos/openshift/origin/issues/4000/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin/pulls/4000/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin/pulls/4000/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin/statuses/90a1f30d90d17a220f6bb68c4d523cd50cecdf23"}}}}