{"push_id":790721316,"size":829,"distinct_size":829,"ref":"refs/heads/digest-helper-dependencies","head":"8ddfd58d6ffe58f97ecd5091b869efe597757a7a","before":"d420402fffbcaa052a94eeb1198416ab365b53d5","commits":[{"sha":"e0cb21f5f767606ad3ecf2db33855d27aa9f083d","author":{"email":"2be88ae07a73b8c2a75656d36b1412903f7f78b8@2suggestions.com.au","name":"Tristan Gamilis"},"message":"Require explicit counter_cache option for has_many\n\nPreviously has_many associations assumed a counter_cache was to be used\nbased on the presence of an appropriately named column. This is\ninconsistent, since the inverse belongs_to association will not make\nthis assumption. See issues #19042 #8446.\nThis commit checks for the presence of the counter_cache key in the\noptions of either the has_many or belongs_to association as well as\nensuring that the *_count column is present.","distinct":true,"url":"https://api.github.com/repos/javan/rails/commits/e0cb21f5f767606ad3ecf2db33855d27aa9f083d"},{"sha":"543523045112c5f5920c486e6fcf2d7e1ffedf5a","author":{"email":"2be88ae07a73b8c2a75656d36b1412903f7f78b8@2suggestions.com.au","name":"Tristan Gamilis"},"message":"Add tests for associations without counter_cache\n\nAssert that counter_cache behaviour is not used on belongs_to or\nhas_many associations if the option is not given explicitly.","distinct":true,"url":"https://api.github.com/repos/javan/rails/commits/543523045112c5f5920c486e6fcf2d7e1ffedf5a"},{"sha":"929fcd26179f2b589d52f9515cbd349f1197ece9","author":{"email":"e6fe9b428cbd844027679efe8ffd169eb501ceab@gmail.com","name":"Mehmet Emin İNAÇ"},"message":"Prevent duplicating `where` clauses when model is extended from an abstract class\nFixes #19528\n\nfix for mysql2 test\n\nbetter test","distinct":true,"url":"https://api.github.com/repos/javan/rails/commits/929fcd26179f2b589d52f9515cbd349f1197ece9"},{"sha":"c4a83b5454a3516b630b38cd8e8472f2166fc986","author":{"email":"246d8aa8dbeecc7021e37dcb9dd1f6b3921b4925@gmail.com","name":"Brian Weaver"},"message":"Fix broken IPv6 addresses handling","distinct":true,"url":"https://api.github.com/repos/javan/rails/commits/c4a83b5454a3516b630b38cd8e8472f2166fc986"},{"sha":"ad389286bbce5a43de34dc2df3968fa1f47181e1","author":{"email":"8586b34907138f3768124603c81a0a3bc76e6be7@gmail.com","name":"Rob Looby"},"message":"put dynamic matchers on the GeneratedAssociationMethods instead of model","distinct":true,"url":"https://api.github.com/repos/javan/rails/commits/ad389286bbce5a43de34dc2df3968fa1f47181e1"},{"sha":"7f2037a990fd81e07f612169f72e8d59fc2a4e52","author":{"email":"e6fe9b428cbd844027679efe8ffd169eb501ceab@gmail.com","name":"Mehmet Emin İNAÇ"},"message":"Add missing data types for ActiveRecord migrations","distinct":true,"url":"https://api.github.com/repos/javan/rails/commits/7f2037a990fd81e07f612169f72e8d59fc2a4e52"},{"sha":"012af6cd7c815350f1ece6d9f46d202efb26a089","author":{"email":"bc89ccf42c56120135b3ed341020b476f6e98400@fea.st","name":"Rob Sharp"},"message":"Add missing require to ensure #advance will work without being implicity required","distinct":true,"url":"https://api.github.com/repos/javan/rails/commits/012af6cd7c815350f1ece6d9f46d202efb26a089"},{"sha":"fd151670ebe6d50fb4df84ab10c04dca7ecbff19","author":{"email":"bc89ccf42c56120135b3ed341020b476f6e98400@fea.st","name":"Rob Sharp"},"message":"Remove accidental ruby-version","distinct":true,"url":"https://api.github.com/repos/javan/rails/commits/fd151670ebe6d50fb4df84ab10c04dca7ecbff19"},{"sha":"bec65fa261b9803c19edbbe9dc89836e1edf78c7","author":{"email":"8c905192dd563038f2813894389d755c0a811d41@gmail.com","name":"Peter Boling"},"message":"Improve sql logging coloration in `ActiveRecord::LogSubscriber`.\n\n- Improves coloring for statements like:\n\n    # Become WHITE\n    SELECT * FROM (\n        SELECT * FROM mytable FOR UPDATE\n    ) ss WHERE col1 = 5;\n    LOCK TABLE table_name IN ACCESS EXCLUSIVE MODE;\n\n    # Becomes RED\n    ROLLBACK\n\n- Reinstates the coloration of the `payload[:name]`.\n  Instead of simple alternating colors, adds meaning:\n  - `MAGENTA` for `\"SQL\"` or `blank?` payload names\n  - `CYAN` for Model Load/Exists\n\n- Introduces specs for sql coloration.\n- Introduces specs for payload name coloration.\n\nGH#20885","distinct":true,"url":"https://api.github.com/repos/javan/rails/commits/bec65fa261b9803c19edbbe9dc89836e1edf78c7"},{"sha":"4fda1f2fade4dafb4f94d1f2a682750d2db5da53","author":{"email":"8c905192dd563038f2813894389d755c0a811d41@gmail.com","name":"Peter Boling"},"message":"Remove extraneous `then` from case statement\n\n- CR feedback from @egilburg\n\nAdditionally\n\n- Move logic for colorizing the payload name into a separate method\n- Make some `ActiveRecord::LogSubscriber` instance methods private for clarity:\n  - `colorize_payload_name`\n  - `sql_color`\n  - `logger`\n- Improve Changelog Documentation\n\nGH #20885","distinct":true,"url":"https://api.github.com/repos/javan/rails/commits/4fda1f2fade4dafb4f94d1f2a682750d2db5da53"},{"sha":"0868b4cec92dba5474e9faa12944a66c7f50fd15","author":{"email":"37b8411fc533112bb69dd1aa56980922c21ae5e0@gmail.com","name":"yui-knk"},"message":"[ci skip] Minor fix\n\n* add a space\n* add a `.`","distinct":true,"url":"https://api.github.com/repos/javan/rails/commits/0868b4cec92dba5474e9faa12944a66c7f50fd15"},{"sha":"1b6131d38586e907461f53e65faab83adeb2306d","author":{"email":"37b8411fc533112bb69dd1aa56980922c21ae5e0@gmail.com","name":"yui-knk"},"message":"[ci skip] Fix `before_filter` -> `before_action`","distinct":true,"url":"https://api.github.com/repos/javan/rails/commits/1b6131d38586e907461f53e65faab83adeb2306d"},{"sha":"f9015ada7e414a1a296499d5c92463016ba200ef","author":{"email":"37b8411fc533112bb69dd1aa56980922c21ae5e0@gmail.com","name":"yui-knk"},"message":"[ci skip] Fix minor typo\n\n* Remove `,`\n* Fix `&lt`; -> `&lt;`","distinct":true,"url":"https://api.github.com/repos/javan/rails/commits/f9015ada7e414a1a296499d5c92463016ba200ef"},{"sha":"12e5cb5db30f27bab1c44ebff1b3446336305603","author":{"email":"d7e19930cc1f42c2d0781f4d9e6f1fe5891bf9cf@thoughtbot.com","name":"Sean Griffin"},"message":"Replace the giant comment in routes.rb with a link to the guides\n\nThis comment not only serves no purpose, but in my experience is\nactively detrimental to new developers getting started with Rails.\nExpereinced developers just end up deleting this comment, and are\nannoyed that they had to take this step. I also spend a lot of time\nmentoring brand new developers, and a consistent theme I've seen is that\nthis comment just ends up intimidating them, and making them think it's\ndangerous to edit this file.\n\nOne of my students just said this (due to the number of comments which\neven new developers don't actually read, they just see it as a sign that\nthis thing is \"dangerous\").\n\n> I don't edit any file that Rails generates for me, until my instructor\n> says that it's OK to do so.\n\nRealistically, this comment adds 0 value. We have very good\ndocumentation, which we can just link to instead. If someone is truly\nnew enough to benefit from this info, they presumably just ran `gem\ninstall rails`, and have an internet connection that they can use to\nread the routing guide.\n\nThe choice of language here was very specific. I chose \"the DSL\navailable\" over \"what is possible\", because a consistent theme I've\nnoticed among my students is that they aren't aware that this is\nactually a Ruby file, and can write any Ruby code here that they want.\n\nThis file is not the only offender, but is by far the biggest point of\npain that I've seen, and felt it was a good spot to open this\ndiscussion.","distinct":true,"url":"https://api.github.com/repos/javan/rails/commits/12e5cb5db30f27bab1c44ebff1b3446336305603"},{"sha":"33a72824b8e355b5f2666816fb62573b5bebc1ae","author":{"email":"37b8411fc533112bb69dd1aa56980922c21ae5e0@gmail.com","name":"yui-knk"},"message":"[ci skip] Fix to `a, b and c` format","distinct":true,"url":"https://api.github.com/repos/javan/rails/commits/33a72824b8e355b5f2666816fb62573b5bebc1ae"},{"sha":"46599260b1361d1ec54c7cc3188b41200fc272b8","author":{"email":"16356534c1589fe78070f5640bedf8614007153c@gmail.com","name":"yuuji.yaginuma"},"message":"set the correct path to `ActionDispatch::IntegrationTest.fixture_path`\n\n`ActionDispatch::IntegrationTest.fixture_path` set by `test_help.rb`, but if the engine,\npath under the dummy is will be set, fixtures under test was not loaded.","distinct":true,"url":"https://api.github.com/repos/javan/rails/commits/46599260b1361d1ec54c7cc3188b41200fc272b8"},{"sha":"9876a16904f817e11713bc85479dd70da1de454b","author":{"email":"37b8411fc533112bb69dd1aa56980922c21ae5e0@gmail.com","name":"yui-knk"},"message":"[ci skip] Fix to `a, b or c` format","distinct":true,"url":"https://api.github.com/repos/javan/rails/commits/9876a16904f817e11713bc85479dd70da1de454b"},{"sha":"8e2f267f6250838cf9057d61d986d2afee2d044b","author":{"email":"a8982b90417ea23143fc49f8fbc13d4745795134@gmail.com","name":"Thomas Walpole"},"message":"Add method_source dependency to activesupport","distinct":true,"url":"https://api.github.com/repos/javan/rails/commits/8e2f267f6250838cf9057d61d986d2afee2d044b"},{"sha":"86e3b047ba0349bd88952d4e54504327c3f7e59c","author":{"email":"a8da7ec6a90be298cc0416fd354ce2a265f27927@gmail.com","name":"Dmitry Polushkin"},"message":"Validate multiple contexts on `valid?` and `invalid?` at once.\n\nExample:\n\n```ruby\nclass Person\n  include ActiveModel::Validations\n\n  attr_reader :name, :title\n  validates_presence_of :name, on: :create\n  validates_presence_of :title, on: :update\nend\n\nperson = Person.new\nperson.valid?([:create, :update])    # => true\nperson.errors.messages               # => {:name=>[\"can't be blank\"], :title=>[\"can't be blank\"]}\n```","distinct":true,"url":"https://api.github.com/repos/javan/rails/commits/86e3b047ba0349bd88952d4e54504327c3f7e59c"},{"sha":"4ec818d28c3984ec9d27c362fc8ff48af9335cde","author":{"email":"afc4fcf5240077e4dc33a8a4cccd740dc11d85b8@gmail.com","name":"Vladimir Rybas"},"message":"RDoc: fix wrong model name `:inverse_of` with `:belongs_to` [ci skip]\n\nThere's a typo in ActiveRecord associations RDocs.\nWrong `Taggable` model name, instead of `Tagging` in example of using\noption `:inverse_of` with `:belongs_to` association.\n\nCommit where typo was introduced:\nhttps://github.com/rails/rails/commit/91fd6510563f84ee473bb217bc63ed598abe3f24#diff-39001423802a8470dba9c931e66e101eR11\n\nFirst it appears in `activerecord/CHANGELOG` in example of `:inverse_of`\nusage:\n\n```ruby\n    class Post < ActiveRecord::Base\n      has_many :taggings\n      has_many :tags, :through => :taggings\n    end\n\n    class Tagging < ActiveRecord::Base\n      belongs_to :post\n      belongs_to :tag, :inverse_of => :tagging # :inverse_of must be set!\n    end\n\n    class Tag < ActiveRecord::Base\n      has_many :taggings\n      has_many :posts, :through => :taggings\n    end\n\n    post = Post.first\n    tag = post.tags.build :name => \"ruby\"\n!>  tag.save # will save a Taggable linking to the post\n```\n\nThe last line should be\n\n```ruby\n    tag.save # will save a Tagging linking to the post\n```\n\nThe same typo appears in\n`activerecord/lib/active_record/associations.rb`.\nThe association name is given as `:inverse_of => :taggings`, but class\nname is `Taggable`.\n\n```ruby\n    #   @post = Post.first\n    #   @tag = @post.tags.build :name => \"ruby\"\n    #   @tag.save\n    #\n!>  # The last line ought to save the through record (a <tt>Taggable</tt>). This will only work if the\n    # <tt>:inverse_of</tt> is set:\n    #\n!>  #   class Taggable < ActiveRecord::Base\n    #     belongs_to :post\n!>  #     belongs_to :tag, :inverse_of => :taggings\n    #   end\n```\n\nThis PR fixes model name.","distinct":true,"url":"https://api.github.com/repos/javan/rails/commits/4ec818d28c3984ec9d27c362fc8ff48af9335cde"}]}