{"action":"created","comment":{"url":"https://api.github.com/repos/slipstream/SlipStreamServer/pulls/comments/44223966","id":44223966,"diff_hunk":"@@ -79,7 +80,8 @@\n      (-> (create-ring-handler)\n          (httpkit/start-container port))\n      (-> (create-ring-handler)\n-         (aleph/start-container port)))))\n+         (aleph/start-container port)))\n+   (graphite/start-graphite-reporter)))","path":"ssclj/jar/src/main/clojure/com/sixsq/slipstream/ssclj/app/server.clj","position":null,"original_position":14,"commit_id":"c5974af0ce3d78b451fc44554942c5828d28d122","original_commit_id":"09853542b7c46e0501937a9fbfc82fc441b9b234","user":{"login":"loomis","id":490506,"avatar_url":"https://avatars.githubusercontent.com/u/490506?v=3","gravatar_id":"","url":"https://api.github.com/users/loomis","html_url":"https://github.com/loomis","followers_url":"https://api.github.com/users/loomis/followers","following_url":"https://api.github.com/users/loomis/following{/other_user}","gists_url":"https://api.github.com/users/loomis/gists{/gist_id}","starred_url":"https://api.github.com/users/loomis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loomis/subscriptions","organizations_url":"https://api.github.com/users/loomis/orgs","repos_url":"https://api.github.com/users/loomis/repos","events_url":"https://api.github.com/users/loomis/events{/privacy}","received_events_url":"https://api.github.com/users/loomis/received_events","type":"User","site_admin":false},"body":"Good catch.  I've moved the metrics process before the starting of the containers but after the definition of the ring handler, where the metrics are defined.  The start/stop should work correctly from the REPL now.  The previous implementation was working from the `init.d` script, but only because the stop function isn't used there. ","created_at":"2015-11-08T12:03:59Z","updated_at":"2015-11-08T12:03:59Z","html_url":"https://github.com/slipstream/SlipStreamServer/pull/527#discussion_r44223966","pull_request_url":"https://api.github.com/repos/slipstream/SlipStreamServer/pulls/527","_links":{"self":{"href":"https://api.github.com/repos/slipstream/SlipStreamServer/pulls/comments/44223966"},"html":{"href":"https://github.com/slipstream/SlipStreamServer/pull/527#discussion_r44223966"},"pull_request":{"href":"https://api.github.com/repos/slipstream/SlipStreamServer/pulls/527"}}},"pull_request":{"url":"https://api.github.com/repos/slipstream/SlipStreamServer/pulls/527","id":50045128,"html_url":"https://github.com/slipstream/SlipStreamServer/pull/527","diff_url":"https://github.com/slipstream/SlipStreamServer/pull/527.diff","patch_url":"https://github.com/slipstream/SlipStreamServer/pull/527.patch","issue_url":"https://api.github.com/repos/slipstream/SlipStreamServer/issues/527","number":527,"state":"open","locked":false,"title":"allow metrics to be pushed to graphite","user":{"login":"loomis","id":490506,"avatar_url":"https://avatars.githubusercontent.com/u/490506?v=3","gravatar_id":"","url":"https://api.github.com/users/loomis","html_url":"https://github.com/loomis","followers_url":"https://api.github.com/users/loomis/followers","following_url":"https://api.github.com/users/loomis/following{/other_user}","gists_url":"https://api.github.com/users/loomis/gists{/gist_id}","starred_url":"https://api.github.com/users/loomis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loomis/subscriptions","organizations_url":"https://api.github.com/users/loomis/orgs","repos_url":"https://api.github.com/users/loomis/repos","events_url":"https://api.github.com/users/loomis/events{/privacy}","received_events_url":"https://api.github.com/users/loomis/received_events","type":"User","site_admin":false},"body":"This PR allows a graphite server to be specified on startup.  If specified, then the defined metrics (JVM, Ring, etc.) will be pushed to that server.  If not specified, then the thread to push the metrics is not started. In both cases, the metrics will continue to be available from `/api/metrics` in JSON format.","created_at":"2015-11-07T20:57:19Z","updated_at":"2015-11-08T12:03:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"94d7535ed5c18787901312a28c669fb9822725b2","assignee":{"login":"st","id":16004,"avatar_url":"https://avatars.githubusercontent.com/u/16004?v=3","gravatar_id":"","url":"https://api.github.com/users/st","html_url":"https://github.com/st","followers_url":"https://api.github.com/users/st/followers","following_url":"https://api.github.com/users/st/following{/other_user}","gists_url":"https://api.github.com/users/st/gists{/gist_id}","starred_url":"https://api.github.com/users/st/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/st/subscriptions","organizations_url":"https://api.github.com/users/st/orgs","repos_url":"https://api.github.com/users/st/repos","events_url":"https://api.github.com/users/st/events{/privacy}","received_events_url":"https://api.github.com/users/st/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/slipstream/SlipStreamServer/milestones/24","html_url":"https://github.com/slipstream/SlipStreamServer/milestones/v2.19","labels_url":"https://api.github.com/repos/slipstream/SlipStreamServer/milestones/24/labels","id":1359511,"number":24,"title":"v2.19","description":"Milestone for sprint Oct 26 - Nov 09 with target version 2.19. The planning meeting is scheduled for Friday, 23th October. The final demo is scheduled for Monday, 9th November.","creator":{"login":"rbf","id":807084,"avatar_url":"https://avatars.githubusercontent.com/u/807084?v=3","gravatar_id":"","url":"https://api.github.com/users/rbf","html_url":"https://github.com/rbf","followers_url":"https://api.github.com/users/rbf/followers","following_url":"https://api.github.com/users/rbf/following{/other_user}","gists_url":"https://api.github.com/users/rbf/gists{/gist_id}","starred_url":"https://api.github.com/users/rbf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rbf/subscriptions","organizations_url":"https://api.github.com/users/rbf/orgs","repos_url":"https://api.github.com/users/rbf/repos","events_url":"https://api.github.com/users/rbf/events{/privacy}","received_events_url":"https://api.github.com/users/rbf/received_events","type":"User","site_admin":false},"open_issues":11,"closed_issues":6,"state":"open","created_at":"2015-10-16T14:09:22Z","updated_at":"2015-11-07T20:57:19Z","due_on":"2015-11-09T18:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/slipstream/SlipStreamServer/pulls/527/commits","review_comments_url":"https://api.github.com/repos/slipstream/SlipStreamServer/pulls/527/comments","review_comment_url":"https://api.github.com/repos/slipstream/SlipStreamServer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/slipstream/SlipStreamServer/issues/527/comments","statuses_url":"https://api.github.com/repos/slipstream/SlipStreamServer/statuses/c5974af0ce3d78b451fc44554942c5828d28d122","head":{"label":"slipstream:feature/graphite-reporting","ref":"feature/graphite-reporting","sha":"c5974af0ce3d78b451fc44554942c5828d28d122","user":{"login":"slipstream","id":3378685,"avatar_url":"https://avatars.githubusercontent.com/u/3378685?v=3","gravatar_id":"","url":"https://api.github.com/users/slipstream","html_url":"https://github.com/slipstream","followers_url":"https://api.github.com/users/slipstream/followers","following_url":"https://api.github.com/users/slipstream/following{/other_user}","gists_url":"https://api.github.com/users/slipstream/gists{/gist_id}","starred_url":"https://api.github.com/users/slipstream/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slipstream/subscriptions","organizations_url":"https://api.github.com/users/slipstream/orgs","repos_url":"https://api.github.com/users/slipstream/repos","events_url":"https://api.github.com/users/slipstream/events{/privacy}","received_events_url":"https://api.github.com/users/slipstream/received_events","type":"Organization","site_admin":false},"repo":{"id":8266573,"name":"SlipStreamServer","full_name":"slipstream/SlipStreamServer","owner":{"login":"slipstream","id":3378685,"avatar_url":"https://avatars.githubusercontent.com/u/3378685?v=3","gravatar_id":"","url":"https://api.github.com/users/slipstream","html_url":"https://github.com/slipstream","followers_url":"https://api.github.com/users/slipstream/followers","following_url":"https://api.github.com/users/slipstream/following{/other_user}","gists_url":"https://api.github.com/users/slipstream/gists{/gist_id}","starred_url":"https://api.github.com/users/slipstream/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slipstream/subscriptions","organizations_url":"https://api.github.com/users/slipstream/orgs","repos_url":"https://api.github.com/users/slipstream/repos","events_url":"https://api.github.com/users/slipstream/events{/privacy}","received_events_url":"https://api.github.com/users/slipstream/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/slipstream/SlipStreamServer","description":"SlipStream RESTful web service","fork":false,"url":"https://api.github.com/repos/slipstream/SlipStreamServer","forks_url":"https://api.github.com/repos/slipstream/SlipStreamServer/forks","keys_url":"https://api.github.com/repos/slipstream/SlipStreamServer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/slipstream/SlipStreamServer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/slipstream/SlipStreamServer/teams","hooks_url":"https://api.github.com/repos/slipstream/SlipStreamServer/hooks","issue_events_url":"https://api.github.com/repos/slipstream/SlipStreamServer/issues/events{/number}","events_url":"https://api.github.com/repos/slipstream/SlipStreamServer/events","assignees_url":"https://api.github.com/repos/slipstream/SlipStreamServer/assignees{/user}","branches_url":"https://api.github.com/repos/slipstream/SlipStreamServer/branches{/branch}","tags_url":"https://api.github.com/repos/slipstream/SlipStreamServer/tags","blobs_url":"https://api.github.com/repos/slipstream/SlipStreamServer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/slipstream/SlipStreamServer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/slipstream/SlipStreamServer/git/refs{/sha}","trees_url":"https://api.github.com/repos/slipstream/SlipStreamServer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/slipstream/SlipStreamServer/statuses/{sha}","languages_url":"https://api.github.com/repos/slipstream/SlipStreamServer/languages","stargazers_url":"https://api.github.com/repos/slipstream/SlipStreamServer/stargazers","contributors_url":"https://api.github.com/repos/slipstream/SlipStreamServer/contributors","subscribers_url":"https://api.github.com/repos/slipstream/SlipStreamServer/subscribers","subscription_url":"https://api.github.com/repos/slipstream/SlipStreamServer/subscription","commits_url":"https://api.github.com/repos/slipstream/SlipStreamServer/commits{/sha}","git_commits_url":"https://api.github.com/repos/slipstream/SlipStreamServer/git/commits{/sha}","comments_url":"https://api.github.com/repos/slipstream/SlipStreamServer/comments{/number}","issue_comment_url":"https://api.github.com/repos/slipstream/SlipStreamServer/issues/comments{/number}","contents_url":"https://api.github.com/repos/slipstream/SlipStreamServer/contents/{+path}","compare_url":"https://api.github.com/repos/slipstream/SlipStreamServer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/slipstream/SlipStreamServer/merges","archive_url":"https://api.github.com/repos/slipstream/SlipStreamServer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/slipstream/SlipStreamServer/downloads","issues_url":"https://api.github.com/repos/slipstream/SlipStreamServer/issues{/number}","pulls_url":"https://api.github.com/repos/slipstream/SlipStreamServer/pulls{/number}","milestones_url":"https://api.github.com/repos/slipstream/SlipStreamServer/milestones{/number}","notifications_url":"https://api.github.com/repos/slipstream/SlipStreamServer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/slipstream/SlipStreamServer/labels{/name}","releases_url":"https://api.github.com/repos/slipstream/SlipStreamServer/releases{/id}","created_at":"2013-02-18T10:48:52Z","updated_at":"2015-05-08T09:17:58Z","pushed_at":"2015-11-08T12:01:44Z","git_url":"git://github.com/slipstream/SlipStreamServer.git","ssh_url":"git@github.com:slipstream/SlipStreamServer.git","clone_url":"https://github.com/slipstream/SlipStreamServer.git","svn_url":"https://github.com/slipstream/SlipStreamServer","homepage":null,"size":14759,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":143,"forks":5,"open_issues":143,"watchers":3,"default_branch":"master"}},"base":{"label":"slipstream:master","ref":"master","sha":"c60940dd6499f3e77eebb6af342dc147a680f6ac","user":{"login":"slipstream","id":3378685,"avatar_url":"https://avatars.githubusercontent.com/u/3378685?v=3","gravatar_id":"","url":"https://api.github.com/users/slipstream","html_url":"https://github.com/slipstream","followers_url":"https://api.github.com/users/slipstream/followers","following_url":"https://api.github.com/users/slipstream/following{/other_user}","gists_url":"https://api.github.com/users/slipstream/gists{/gist_id}","starred_url":"https://api.github.com/users/slipstream/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slipstream/subscriptions","organizations_url":"https://api.github.com/users/slipstream/orgs","repos_url":"https://api.github.com/users/slipstream/repos","events_url":"https://api.github.com/users/slipstream/events{/privacy}","received_events_url":"https://api.github.com/users/slipstream/received_events","type":"Organization","site_admin":false},"repo":{"id":8266573,"name":"SlipStreamServer","full_name":"slipstream/SlipStreamServer","owner":{"login":"slipstream","id":3378685,"avatar_url":"https://avatars.githubusercontent.com/u/3378685?v=3","gravatar_id":"","url":"https://api.github.com/users/slipstream","html_url":"https://github.com/slipstream","followers_url":"https://api.github.com/users/slipstream/followers","following_url":"https://api.github.com/users/slipstream/following{/other_user}","gists_url":"https://api.github.com/users/slipstream/gists{/gist_id}","starred_url":"https://api.github.com/users/slipstream/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slipstream/subscriptions","organizations_url":"https://api.github.com/users/slipstream/orgs","repos_url":"https://api.github.com/users/slipstream/repos","events_url":"https://api.github.com/users/slipstream/events{/privacy}","received_events_url":"https://api.github.com/users/slipstream/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/slipstream/SlipStreamServer","description":"SlipStream RESTful web service","fork":false,"url":"https://api.github.com/repos/slipstream/SlipStreamServer","forks_url":"https://api.github.com/repos/slipstream/SlipStreamServer/forks","keys_url":"https://api.github.com/repos/slipstream/SlipStreamServer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/slipstream/SlipStreamServer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/slipstream/SlipStreamServer/teams","hooks_url":"https://api.github.com/repos/slipstream/SlipStreamServer/hooks","issue_events_url":"https://api.github.com/repos/slipstream/SlipStreamServer/issues/events{/number}","events_url":"https://api.github.com/repos/slipstream/SlipStreamServer/events","assignees_url":"https://api.github.com/repos/slipstream/SlipStreamServer/assignees{/user}","branches_url":"https://api.github.com/repos/slipstream/SlipStreamServer/branches{/branch}","tags_url":"https://api.github.com/repos/slipstream/SlipStreamServer/tags","blobs_url":"https://api.github.com/repos/slipstream/SlipStreamServer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/slipstream/SlipStreamServer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/slipstream/SlipStreamServer/git/refs{/sha}","trees_url":"https://api.github.com/repos/slipstream/SlipStreamServer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/slipstream/SlipStreamServer/statuses/{sha}","languages_url":"https://api.github.com/repos/slipstream/SlipStreamServer/languages","stargazers_url":"https://api.github.com/repos/slipstream/SlipStreamServer/stargazers","contributors_url":"https://api.github.com/repos/slipstream/SlipStreamServer/contributors","subscribers_url":"https://api.github.com/repos/slipstream/SlipStreamServer/subscribers","subscription_url":"https://api.github.com/repos/slipstream/SlipStreamServer/subscription","commits_url":"https://api.github.com/repos/slipstream/SlipStreamServer/commits{/sha}","git_commits_url":"https://api.github.com/repos/slipstream/SlipStreamServer/git/commits{/sha}","comments_url":"https://api.github.com/repos/slipstream/SlipStreamServer/comments{/number}","issue_comment_url":"https://api.github.com/repos/slipstream/SlipStreamServer/issues/comments{/number}","contents_url":"https://api.github.com/repos/slipstream/SlipStreamServer/contents/{+path}","compare_url":"https://api.github.com/repos/slipstream/SlipStreamServer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/slipstream/SlipStreamServer/merges","archive_url":"https://api.github.com/repos/slipstream/SlipStreamServer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/slipstream/SlipStreamServer/downloads","issues_url":"https://api.github.com/repos/slipstream/SlipStreamServer/issues{/number}","pulls_url":"https://api.github.com/repos/slipstream/SlipStreamServer/pulls{/number}","milestones_url":"https://api.github.com/repos/slipstream/SlipStreamServer/milestones{/number}","notifications_url":"https://api.github.com/repos/slipstream/SlipStreamServer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/slipstream/SlipStreamServer/labels{/name}","releases_url":"https://api.github.com/repos/slipstream/SlipStreamServer/releases{/id}","created_at":"2013-02-18T10:48:52Z","updated_at":"2015-05-08T09:17:58Z","pushed_at":"2015-11-08T12:01:44Z","git_url":"git://github.com/slipstream/SlipStreamServer.git","ssh_url":"git@github.com:slipstream/SlipStreamServer.git","clone_url":"https://github.com/slipstream/SlipStreamServer.git","svn_url":"https://github.com/slipstream/SlipStreamServer","homepage":null,"size":14759,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":143,"forks":5,"open_issues":143,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/slipstream/SlipStreamServer/pulls/527"},"html":{"href":"https://github.com/slipstream/SlipStreamServer/pull/527"},"issue":{"href":"https://api.github.com/repos/slipstream/SlipStreamServer/issues/527"},"comments":{"href":"https://api.github.com/repos/slipstream/SlipStreamServer/issues/527/comments"},"review_comments":{"href":"https://api.github.com/repos/slipstream/SlipStreamServer/pulls/527/comments"},"review_comment":{"href":"https://api.github.com/repos/slipstream/SlipStreamServer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/slipstream/SlipStreamServer/pulls/527/commits"},"statuses":{"href":"https://api.github.com/repos/slipstream/SlipStreamServer/statuses/c5974af0ce3d78b451fc44554942c5828d28d122"}}}}