{"action":"created","issue":{"url":"https://api.github.com/repos/bitcoin/bitcoin/issues/6907","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/6907/labels{/name}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/6907/comments","events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/6907/events","html_url":"https://github.com/bitcoin/bitcoin/pull/6907","id":114148113,"number":6907,"title":"Chainparams: Use a regular factory for creating chainparams","user":{"login":"jtimon","id":1008458,"avatar_url":"https://avatars.githubusercontent.com/u/1008458?v=3","gravatar_id":"","url":"https://api.github.com/users/jtimon","html_url":"https://github.com/jtimon","followers_url":"https://api.github.com/users/jtimon/followers","following_url":"https://api.github.com/users/jtimon/following{/other_user}","gists_url":"https://api.github.com/users/jtimon/gists{/gist_id}","starred_url":"https://api.github.com/users/jtimon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtimon/subscriptions","organizations_url":"https://api.github.com/users/jtimon/orgs","repos_url":"https://api.github.com/users/jtimon/repos","events_url":"https://api.github.com/users/jtimon/events{/privacy}","received_events_url":"https://api.github.com/users/jtimon/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/bitcoin/bitcoin/labels/Refactoring","name":"Refactoring","color":"E6F6D6"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-10-29T21:11:00Z","updated_at":"2015-11-05T00:47:19Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/6907","html_url":"https://github.com/bitcoin/bitcoin/pull/6907","diff_url":"https://github.com/bitcoin/bitcoin/pull/6907.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/6907.patch"},"body":"This makes it simpler for people to create new testchains in their own branches by removing the need to create a new static global variable for the new chains.\r\n\r\nIt also prepares chainparams and chainparamsbase to be cleaned out of globals by moving the globals and related functions (```Params(), SelectParams()```, etc) outside, maybe to globals/server.o and globals/common.o respectively.\r\n\r\nBut that would need another PR after this, something @theuni has been wanting to do for some time.\r\nI would prefer to do this first to be able to leave the 2 factories (which don't need to depend on any global) where they are. \r\nPart of #6382"},"comment":{"url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments/153917620","html_url":"https://github.com/bitcoin/bitcoin/pull/6907#issuecomment-153917620","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/6907","id":153917620,"user":{"login":"dcousens","id":413395,"avatar_url":"https://avatars.githubusercontent.com/u/413395?v=3","gravatar_id":"","url":"https://api.github.com/users/dcousens","html_url":"https://github.com/dcousens","followers_url":"https://api.github.com/users/dcousens/followers","following_url":"https://api.github.com/users/dcousens/following{/other_user}","gists_url":"https://api.github.com/users/dcousens/gists{/gist_id}","starred_url":"https://api.github.com/users/dcousens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcousens/subscriptions","organizations_url":"https://api.github.com/users/dcousens/orgs","repos_url":"https://api.github.com/users/dcousens/repos","events_url":"https://api.github.com/users/dcousens/events{/privacy}","received_events_url":"https://api.github.com/users/dcousens/received_events","type":"User","site_admin":false},"created_at":"2015-11-05T00:47:19Z","updated_at":"2015-11-05T00:47:19Z","body":"utACK"}}