{"action":"created","comment":{"url":"https://api.github.com/repos/chef/chef-provisioning-docker/pulls/comments/33091782","id":33091782,"diff_hunk":"@@ -0,0 +1,113 @@\n+require 'spec_helper'\n+require 'time'\n+require 'fileutils'\n+\n+describe \"chef-provisioning-docker\" do\n+  extend DockerSupport\n+  include DockerConfig\n+\n+  when_the_chef_12_server \"exists\", organization: \"foo\", server_scope: :context, port: 8900..9000 do\n+    with_docker \"volumes supported\" do\n+\n+      # owing to how RSpec works, things defined by let() are not accessible in the recipes we define inside\n+      # expect_converge{}.\n+      ubuntu_options = {\n+          :base_image => {\n+            :name => 'ubuntu',\n+            :repository => 'ubuntu',\n+            :tag => '14.04'\n+          }\n+        }\n+\n+      let(:timestamp) { Time.now.to_i }\n+      docker_driver = driver\n+\n+      context \"machine_image resource\" do\n+\n+        let(:spec_image_tag) { \"docker_image_spec_#{timestamp}\" }\n+\n+        after(:each) {\n+          image = docker_driver.find_image(\"chef:#{spec_image_tag}\")","path":"spec/integration/volumes_spec.rb","position":30,"original_position":30,"commit_id":"6c92d4939c4dbcddcea6ff01a5270fc36a6e7d8b","original_commit_id":"6c92d4939c4dbcddcea6ff01a5270fc36a6e7d8b","user":{"login":"marc-","id":454771,"avatar_url":"https://avatars.githubusercontent.com/u/454771?v=3","gravatar_id":"","url":"https://api.github.com/users/marc-","html_url":"https://github.com/marc-","followers_url":"https://api.github.com/users/marc-/followers","following_url":"https://api.github.com/users/marc-/following{/other_user}","gists_url":"https://api.github.com/users/marc-/gists{/gist_id}","starred_url":"https://api.github.com/users/marc-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marc-/subscriptions","organizations_url":"https://api.github.com/users/marc-/orgs","repos_url":"https://api.github.com/users/marc-/repos","events_url":"https://api.github.com/users/marc-/events{/privacy}","received_events_url":"https://api.github.com/users/marc-/received_events","type":"User","site_admin":false},"body":"Will fix.","created_at":"2015-06-23T21:00:39Z","updated_at":"2015-06-23T21:00:39Z","html_url":"https://github.com/chef/chef-provisioning-docker/pull/54#discussion_r33091782","pull_request_url":"https://api.github.com/repos/chef/chef-provisioning-docker/pulls/54","_links":{"self":{"href":"https://api.github.com/repos/chef/chef-provisioning-docker/pulls/comments/33091782"},"html":{"href":"https://github.com/chef/chef-provisioning-docker/pull/54#discussion_r33091782"},"pull_request":{"href":"https://api.github.com/repos/chef/chef-provisioning-docker/pulls/54"}}},"pull_request":{"url":"https://api.github.com/repos/chef/chef-provisioning-docker/pulls/54","id":37378667,"html_url":"https://github.com/chef/chef-provisioning-docker/pull/54","diff_url":"https://github.com/chef/chef-provisioning-docker/pull/54.diff","patch_url":"https://github.com/chef/chef-provisioning-docker/pull/54.patch","issue_url":"https://api.github.com/repos/chef/chef-provisioning-docker/issues/54","number":54,"state":"open","locked":false,"title":"Install chef-client omnibus on docker volume (#26)","user":{"login":"marc-","id":454771,"avatar_url":"https://avatars.githubusercontent.com/u/454771?v=3","gravatar_id":"","url":"https://api.github.com/users/marc-","html_url":"https://github.com/marc-","followers_url":"https://api.github.com/users/marc-/followers","following_url":"https://api.github.com/users/marc-/following{/other_user}","gists_url":"https://api.github.com/users/marc-/gists{/gist_id}","starred_url":"https://api.github.com/users/marc-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marc-/subscriptions","organizations_url":"https://api.github.com/users/marc-/orgs","repos_url":"https://api.github.com/users/marc-/repos","events_url":"https://api.github.com/users/marc-/events{/privacy}","received_events_url":"https://api.github.com/users/marc-/received_events","type":"User","site_admin":false},"body":"This patch allows to install chef-client omnibus on docker volume instead copying and installing it inside container. Image size after is reduced by about 150Mb. See #26 for more.\r\nIt is also allows to use volumes during convergence.","created_at":"2015-06-10T16:36:27Z","updated_at":"2015-06-23T21:00:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8b73f68503c702c911ff0795805b45d17655f01a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/chef/chef-provisioning-docker/pulls/54/commits","review_comments_url":"https://api.github.com/repos/chef/chef-provisioning-docker/pulls/54/comments","review_comment_url":"https://api.github.com/repos/chef/chef-provisioning-docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chef/chef-provisioning-docker/issues/54/comments","statuses_url":"https://api.github.com/repos/chef/chef-provisioning-docker/statuses/6c92d4939c4dbcddcea6ff01a5270fc36a6e7d8b","head":{"label":"marc-:issue-26","ref":"issue-26","sha":"6c92d4939c4dbcddcea6ff01a5270fc36a6e7d8b","user":{"login":"marc-","id":454771,"avatar_url":"https://avatars.githubusercontent.com/u/454771?v=3","gravatar_id":"","url":"https://api.github.com/users/marc-","html_url":"https://github.com/marc-","followers_url":"https://api.github.com/users/marc-/followers","following_url":"https://api.github.com/users/marc-/following{/other_user}","gists_url":"https://api.github.com/users/marc-/gists{/gist_id}","starred_url":"https://api.github.com/users/marc-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marc-/subscriptions","organizations_url":"https://api.github.com/users/marc-/orgs","repos_url":"https://api.github.com/users/marc-/repos","events_url":"https://api.github.com/users/marc-/events{/privacy}","received_events_url":"https://api.github.com/users/marc-/received_events","type":"User","site_admin":false},"repo":{"id":30963135,"name":"chef-provisioning-docker","full_name":"marc-/chef-provisioning-docker","owner":{"login":"marc-","id":454771,"avatar_url":"https://avatars.githubusercontent.com/u/454771?v=3","gravatar_id":"","url":"https://api.github.com/users/marc-","html_url":"https://github.com/marc-","followers_url":"https://api.github.com/users/marc-/followers","following_url":"https://api.github.com/users/marc-/following{/other_user}","gists_url":"https://api.github.com/users/marc-/gists{/gist_id}","starred_url":"https://api.github.com/users/marc-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marc-/subscriptions","organizations_url":"https://api.github.com/users/marc-/orgs","repos_url":"https://api.github.com/users/marc-/repos","events_url":"https://api.github.com/users/marc-/events{/privacy}","received_events_url":"https://api.github.com/users/marc-/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/marc-/chef-provisioning-docker","description":"Docker provisioner for chef-metal","fork":true,"url":"https://api.github.com/repos/marc-/chef-provisioning-docker","forks_url":"https://api.github.com/repos/marc-/chef-provisioning-docker/forks","keys_url":"https://api.github.com/repos/marc-/chef-provisioning-docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marc-/chef-provisioning-docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marc-/chef-provisioning-docker/teams","hooks_url":"https://api.github.com/repos/marc-/chef-provisioning-docker/hooks","issue_events_url":"https://api.github.com/repos/marc-/chef-provisioning-docker/issues/events{/number}","events_url":"https://api.github.com/repos/marc-/chef-provisioning-docker/events","assignees_url":"https://api.github.com/repos/marc-/chef-provisioning-docker/assignees{/user}","branches_url":"https://api.github.com/repos/marc-/chef-provisioning-docker/branches{/branch}","tags_url":"https://api.github.com/repos/marc-/chef-provisioning-docker/tags","blobs_url":"https://api.github.com/repos/marc-/chef-provisioning-docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marc-/chef-provisioning-docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marc-/chef-provisioning-docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/marc-/chef-provisioning-docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marc-/chef-provisioning-docker/statuses/{sha}","languages_url":"https://api.github.com/repos/marc-/chef-provisioning-docker/languages","stargazers_url":"https://api.github.com/repos/marc-/chef-provisioning-docker/stargazers","contributors_url":"https://api.github.com/repos/marc-/chef-provisioning-docker/contributors","subscribers_url":"https://api.github.com/repos/marc-/chef-provisioning-docker/subscribers","subscription_url":"https://api.github.com/repos/marc-/chef-provisioning-docker/subscription","commits_url":"https://api.github.com/repos/marc-/chef-provisioning-docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/marc-/chef-provisioning-docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/marc-/chef-provisioning-docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/marc-/chef-provisioning-docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/marc-/chef-provisioning-docker/contents/{+path}","compare_url":"https://api.github.com/repos/marc-/chef-provisioning-docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marc-/chef-provisioning-docker/merges","archive_url":"https://api.github.com/repos/marc-/chef-provisioning-docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marc-/chef-provisioning-docker/downloads","issues_url":"https://api.github.com/repos/marc-/chef-provisioning-docker/issues{/number}","pulls_url":"https://api.github.com/repos/marc-/chef-provisioning-docker/pulls{/number}","milestones_url":"https://api.github.com/repos/marc-/chef-provisioning-docker/milestones{/number}","notifications_url":"https://api.github.com/repos/marc-/chef-provisioning-docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marc-/chef-provisioning-docker/labels{/name}","releases_url":"https://api.github.com/repos/marc-/chef-provisioning-docker/releases{/id}","created_at":"2015-02-18T11:37:00Z","updated_at":"2015-05-06T09:15:00Z","pushed_at":"2015-06-23T15:36:00Z","git_url":"git://github.com/marc-/chef-provisioning-docker.git","ssh_url":"git@github.com:marc-/chef-provisioning-docker.git","clone_url":"https://github.com/marc-/chef-provisioning-docker.git","svn_url":"https://github.com/marc-/chef-provisioning-docker","homepage":null,"size":406,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"chef:master","ref":"master","sha":"ee5db516a14445dbdb8dd56ff9eb32e0ee279d43","user":{"login":"chef","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?v=3","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"repo":{"id":18409797,"name":"chef-provisioning-docker","full_name":"chef/chef-provisioning-docker","owner":{"login":"chef","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?v=3","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chef/chef-provisioning-docker","description":"Docker provisioner for chef-provisioning","fork":false,"url":"https://api.github.com/repos/chef/chef-provisioning-docker","forks_url":"https://api.github.com/repos/chef/chef-provisioning-docker/forks","keys_url":"https://api.github.com/repos/chef/chef-provisioning-docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chef/chef-provisioning-docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chef/chef-provisioning-docker/teams","hooks_url":"https://api.github.com/repos/chef/chef-provisioning-docker/hooks","issue_events_url":"https://api.github.com/repos/chef/chef-provisioning-docker/issues/events{/number}","events_url":"https://api.github.com/repos/chef/chef-provisioning-docker/events","assignees_url":"https://api.github.com/repos/chef/chef-provisioning-docker/assignees{/user}","branches_url":"https://api.github.com/repos/chef/chef-provisioning-docker/branches{/branch}","tags_url":"https://api.github.com/repos/chef/chef-provisioning-docker/tags","blobs_url":"https://api.github.com/repos/chef/chef-provisioning-docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chef/chef-provisioning-docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chef/chef-provisioning-docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/chef/chef-provisioning-docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chef/chef-provisioning-docker/statuses/{sha}","languages_url":"https://api.github.com/repos/chef/chef-provisioning-docker/languages","stargazers_url":"https://api.github.com/repos/chef/chef-provisioning-docker/stargazers","contributors_url":"https://api.github.com/repos/chef/chef-provisioning-docker/contributors","subscribers_url":"https://api.github.com/repos/chef/chef-provisioning-docker/subscribers","subscription_url":"https://api.github.com/repos/chef/chef-provisioning-docker/subscription","commits_url":"https://api.github.com/repos/chef/chef-provisioning-docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/chef/chef-provisioning-docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/chef/chef-provisioning-docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/chef/chef-provisioning-docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/chef/chef-provisioning-docker/contents/{+path}","compare_url":"https://api.github.com/repos/chef/chef-provisioning-docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chef/chef-provisioning-docker/merges","archive_url":"https://api.github.com/repos/chef/chef-provisioning-docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chef/chef-provisioning-docker/downloads","issues_url":"https://api.github.com/repos/chef/chef-provisioning-docker/issues{/number}","pulls_url":"https://api.github.com/repos/chef/chef-provisioning-docker/pulls{/number}","milestones_url":"https://api.github.com/repos/chef/chef-provisioning-docker/milestones{/number}","notifications_url":"https://api.github.com/repos/chef/chef-provisioning-docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chef/chef-provisioning-docker/labels{/name}","releases_url":"https://api.github.com/repos/chef/chef-provisioning-docker/releases{/id}","created_at":"2014-04-03T16:22:05Z","updated_at":"2015-06-21T21:35:18Z","pushed_at":"2015-06-23T15:36:00Z","git_url":"git://github.com/chef/chef-provisioning-docker.git","ssh_url":"git@github.com:chef/chef-provisioning-docker.git","clone_url":"https://github.com/chef/chef-provisioning-docker.git","svn_url":"https://github.com/chef/chef-provisioning-docker","homepage":"","size":1098,"stargazers_count":52,"watchers_count":52,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"open_issues_count":18,"forks":24,"open_issues":18,"watchers":52,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chef/chef-provisioning-docker/pulls/54"},"html":{"href":"https://github.com/chef/chef-provisioning-docker/pull/54"},"issue":{"href":"https://api.github.com/repos/chef/chef-provisioning-docker/issues/54"},"comments":{"href":"https://api.github.com/repos/chef/chef-provisioning-docker/issues/54/comments"},"review_comments":{"href":"https://api.github.com/repos/chef/chef-provisioning-docker/pulls/54/comments"},"review_comment":{"href":"https://api.github.com/repos/chef/chef-provisioning-docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chef/chef-provisioning-docker/pulls/54/commits"},"statuses":{"href":"https://api.github.com/repos/chef/chef-provisioning-docker/statuses/6c92d4939c4dbcddcea6ff01a5270fc36a6e7d8b"}}}}