{"action":"created","issue":{"url":"https://api.github.com/repos/docker/machine/issues/1522","labels_url":"https://api.github.com/repos/docker/machine/issues/1522/labels{/name}","comments_url":"https://api.github.com/repos/docker/machine/issues/1522/comments","events_url":"https://api.github.com/repos/docker/machine/issues/1522/events","html_url":"https://github.com/docker/machine/pull/1522","id":94928033,"number":1522,"title":"Full rewrite of the vSphere driver","user":{"login":"frapposelli","id":541832,"avatar_url":"https://avatars.githubusercontent.com/u/541832?v=3","gravatar_id":"","url":"https://api.github.com/users/frapposelli","html_url":"https://github.com/frapposelli","followers_url":"https://api.github.com/users/frapposelli/followers","following_url":"https://api.github.com/users/frapposelli/following{/other_user}","gists_url":"https://api.github.com/users/frapposelli/gists{/gist_id}","starred_url":"https://api.github.com/users/frapposelli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frapposelli/subscriptions","organizations_url":"https://api.github.com/users/frapposelli/orgs","repos_url":"https://api.github.com/users/frapposelli/repos","events_url":"https://api.github.com/users/frapposelli/events{/privacy}","received_events_url":"https://api.github.com/users/frapposelli/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/docker/machine/labels/driver/vmwarevsphere","name":"driver/vmwarevsphere","color":"0052cc"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/docker/machine/milestones/9","html_url":"https://github.com/docker/machine/milestones/0.5.5","labels_url":"https://api.github.com/repos/docker/machine/milestones/9/labels","id":1373608,"number":9,"title":"0.5.5","description":"","creator":{"login":"dmp42","id":332946,"avatar_url":"https://avatars.githubusercontent.com/u/332946?v=3","gravatar_id":"","url":"https://api.github.com/users/dmp42","html_url":"https://github.com/dmp42","followers_url":"https://api.github.com/users/dmp42/followers","following_url":"https://api.github.com/users/dmp42/following{/other_user}","gists_url":"https://api.github.com/users/dmp42/gists{/gist_id}","starred_url":"https://api.github.com/users/dmp42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmp42/subscriptions","organizations_url":"https://api.github.com/users/dmp42/orgs","repos_url":"https://api.github.com/users/dmp42/repos","events_url":"https://api.github.com/users/dmp42/events{/privacy}","received_events_url":"https://api.github.com/users/dmp42/received_events","type":"User","site_admin":false},"open_issues":35,"closed_issues":21,"state":"open","created_at":"2015-10-24T04:12:35Z","updated_at":"2015-12-24T08:57:20Z","due_on":"2015-12-28T08:00:00Z","closed_at":null},"comments":19,"created_at":"2015-07-14T11:44:42Z","updated_at":"2015-12-24T10:09:47Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/docker/machine/pulls/1522","html_url":"https://github.com/docker/machine/pull/1522","diff_url":"https://github.com/docker/machine/pull/1522.diff","patch_url":"https://github.com/docker/machine/pull/1522.patch"},"body":"This is a complete rewrite of the vSphere driver, this drops the `govc` requirement by using the `govmomi` library directly.\r\n\r\nAlso enhances auto detection of resources and general performance improvement.\r\n\r\nPasses bats test:\r\n\r\n```shell\r\nmachine · vspheredriver-with-govmomi ⟩ env DRIVER=vmwarevsphere \\\r\n                                       VSPHERE_DATASTORE=\"nfs_fas2020_15k_01\" \\\r\n                                       VSPHERE_VCENTER=\"monster.ad.lab.gosddc.com\" \\\r\n                                       VSPHERE_NETWORK=\"VM Network\" \\\r\n                                       VSPHERE_USERNAME=\"root\" \\\r\n                                       VSPHERE_PASSWORD=\"xxxxxxxxxxxx\" \\\r\n                                       ./test/integration/run-bats.sh ./test/integration/core/core-commands.bats\r\n=> ./test/integration/core/core-commands.bats\r\n ✓ vmwarevsphere: machine should not exist\r\n ✓ vmwarevsphere: create\r\n ✓ vmwarevsphere: ls\r\n ✓ vmwarevsphere: run busybox container\r\n ✓ vmwarevsphere: url\r\n ✓ vmwarevsphere: ip\r\n ✓ vmwarevsphere: ssh\r\n ✓ vmwarevsphere: docker commands with the socket should work\r\n ✓ vmwarevsphere: stop\r\n ✓ vmwarevsphere: machine should show stopped after stop\r\n ✓ vmwarevsphere: url should show an error when machine is stopped\r\n ✓ vmwarevsphere: env should show an error when machine is stopped\r\n ✓ vmwarevsphere: machine should not allow upgrade when stopped\r\n ✓ vmwarevsphere: start\r\n ✓ vmwarevsphere: machine should show running after start\r\n ✓ vmwarevsphere: kill\r\n ✓ vmwarevsphere: machine should show stopped after kill\r\n ✓ vmwarevsphere: restart\r\n ✓ vmwarevsphere: machine should show running after restart\r\n\r\n19 tests, 0 failures\r\n```"},"comment":{"url":"https://api.github.com/repos/docker/machine/issues/comments/167081335","html_url":"https://github.com/docker/machine/pull/1522#issuecomment-167081335","issue_url":"https://api.github.com/repos/docker/machine/issues/1522","id":167081335,"user":{"login":"jeanlaurent","id":197016,"avatar_url":"https://avatars.githubusercontent.com/u/197016?v=3","gravatar_id":"","url":"https://api.github.com/users/jeanlaurent","html_url":"https://github.com/jeanlaurent","followers_url":"https://api.github.com/users/jeanlaurent/followers","following_url":"https://api.github.com/users/jeanlaurent/following{/other_user}","gists_url":"https://api.github.com/users/jeanlaurent/gists{/gist_id}","starred_url":"https://api.github.com/users/jeanlaurent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeanlaurent/subscriptions","organizations_url":"https://api.github.com/users/jeanlaurent/orgs","repos_url":"https://api.github.com/users/jeanlaurent/repos","events_url":"https://api.github.com/users/jeanlaurent/events{/privacy}","received_events_url":"https://api.github.com/users/jeanlaurent/received_events","type":"User","site_admin":false},"created_at":"2015-12-24T10:09:47Z","updated_at":"2015-12-24T10:09:47Z","body":"LGTM"}}