{"action":"created","comment":{"url":"https://api.github.com/repos/squirrel-project/squirrel_robotino/pulls/comments/45731364","id":45731364,"diff_hunk":"@@ -121,30 +121,51 @@\n \n \t\ttry:\n \t\t\tfile_localition = roslib.packages.get_pkg_dir('cob_gazebo_objects') + '/objects/' + model + '.' + model_type\n-\t\texcept:\n-\t\t\tprint \"File not found: cob_gazebo_objects\" + \"/objects/\" + model + \".\" + model_type\n-\t\t\tcontinue\n-\n-\t\t# call gazebo service to spawn model (see http://ros.org/wiki/gazebo)\n-\t\tif model_type == \"urdf\":\n-\t\t\tsrv_spawn_model = rospy.ServiceProxy('/gazebo/spawn_urdf_model', SpawnModel)\n-\t\t\tfile_xml = open(file_localition)\n-\t\t\txml_string=file_xml.read()\n-\n-\t\telif model_type == \"urdf.xacro\":\n-\t\t\tp = os.popen(\"rosrun xacro xacro.py \" + file_localition)\n-\t\t\txml_string = p.read()\n-\t\t\tp.close()\n-\t\t\tsrv_spawn_model = rospy.ServiceProxy('/gazebo/spawn_urdf_model', SpawnModel)\n-\n-\t\telif model_type == \"model\":\n-\t\t\tsrv_spawn_model = rospy.ServiceProxy('/gazebo/spawn_gazebo_model', SpawnModel)\n-\t\t\tfile_xml = open(file_localition)\n-\t\t\txml_string=file_xml.read()\n-\t\telse:\n-\t\t\trospy.logerr('Model type not know. model_type = ' + model_type)\n-\t\t\tcontinue\n-\n+\t\t\n+\t\t\t# call gazebo service to spawn model (see http://ros.org/wiki/gazebo)\n+\t\t\tif model_type == \"urdf\":\n+\t\t\t\tsrv_spawn_model = rospy.ServiceProxy('/gazebo/spawn_urdf_model', SpawnModel)\n+\t\t\t\tfile_xml = open(file_localition)\n+\t\t\t\txml_string=file_xml.read()\n+\n+\t\t\telif model_type == \"urdf.xacro\":\n+\t\t\t\tp = os.popen(\"rosrun xacro xacro.py \" + file_localition)\n+\t\t\t\txml_string = p.read()\n+\t\t\t\tp.close()\n+\t\t\t\tsrv_spawn_model = rospy.ServiceProxy('/gazebo/spawn_urdf_model', SpawnModel)\n+\n+\t\t\telif model_type == \"model\":\n+\t\t\t\tsrv_spawn_model = rospy.ServiceProxy('/gazebo/spawn_gazebo_model', SpawnModel)\n+\t\t\t\tfile_xml = open(file_localition)\n+\t\t\t\txml_string=file_xml.read()\n+\t\t\telse:\n+\t\t\t\trospy.logerr('Model type not know. model_type = ' + model_type)\n+\t\t\t\tcontinue\n+\t\texcept: \n+\t\t\ttry:\n+\t\t\t\tfile_localition = roslib.packages.get_pkg_dir('robotino_gazebo_worlds') + '/objects/' + model + '.' + model_type","path":"robotino_bringup_sim/scripts/spawn_object.py","position":50,"original_position":50,"commit_id":"260dd558e0bd3dc6a1623e4a41f12f2f81cd78cc","original_commit_id":"260dd558e0bd3dc6a1623e4a41f12f2f81cd78cc","user":{"login":"ipa-nhg","id":650568,"avatar_url":"https://avatars.githubusercontent.com/u/650568?v=3","gravatar_id":"","url":"https://api.github.com/users/ipa-nhg","html_url":"https://github.com/ipa-nhg","followers_url":"https://api.github.com/users/ipa-nhg/followers","following_url":"https://api.github.com/users/ipa-nhg/following{/other_user}","gists_url":"https://api.github.com/users/ipa-nhg/gists{/gist_id}","starred_url":"https://api.github.com/users/ipa-nhg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipa-nhg/subscriptions","organizations_url":"https://api.github.com/users/ipa-nhg/orgs","repos_url":"https://api.github.com/users/ipa-nhg/repos","events_url":"https://api.github.com/users/ipa-nhg/events{/privacy}","received_events_url":"https://api.github.com/users/ipa-nhg/received_events","type":"User","site_admin":false},"body":"This change can not be merged, you will not be able to spawn the rest of the objects. We should find other solution... ","created_at":"2015-11-24T12:59:40Z","updated_at":"2015-11-24T12:59:40Z","html_url":"https://github.com/squirrel-project/squirrel_robotino/pull/66#discussion_r45731364","pull_request_url":"https://api.github.com/repos/squirrel-project/squirrel_robotino/pulls/66","_links":{"self":{"href":"https://api.github.com/repos/squirrel-project/squirrel_robotino/pulls/comments/45731364"},"html":{"href":"https://github.com/squirrel-project/squirrel_robotino/pull/66#discussion_r45731364"},"pull_request":{"href":"https://api.github.com/repos/squirrel-project/squirrel_robotino/pulls/66"}}},"pull_request":{"url":"https://api.github.com/repos/squirrel-project/squirrel_robotino/pulls/66","id":51525707,"html_url":"https://github.com/squirrel-project/squirrel_robotino/pull/66","diff_url":"https://github.com/squirrel-project/squirrel_robotino/pull/66.diff","patch_url":"https://github.com/squirrel-project/squirrel_robotino/pull/66.patch","issue_url":"https://api.github.com/repos/squirrel-project/squirrel_robotino/issues/66","number":66,"state":"open","locked":false,"title":" added folders for new objects;; changed script for object spawn","user":{"login":"Senka2112","id":6683150,"avatar_url":"https://avatars.githubusercontent.com/u/6683150?v=3","gravatar_id":"","url":"https://api.github.com/users/Senka2112","html_url":"https://github.com/Senka2112","followers_url":"https://api.github.com/users/Senka2112/followers","following_url":"https://api.github.com/users/Senka2112/following{/other_user}","gists_url":"https://api.github.com/users/Senka2112/gists{/gist_id}","starred_url":"https://api.github.com/users/Senka2112/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Senka2112/subscriptions","organizations_url":"https://api.github.com/users/Senka2112/orgs","repos_url":"https://api.github.com/users/Senka2112/repos","events_url":"https://api.github.com/users/Senka2112/events{/privacy}","received_events_url":"https://api.github.com/users/Senka2112/received_events","type":"User","site_admin":false},"body":" aded simple box object\r\n\r\n","created_at":"2015-11-23T13:57:27Z","updated_at":"2015-11-24T12:59:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f6047d1a19253d7273c5a1c26f498984df4aa37d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/squirrel-project/squirrel_robotino/pulls/66/commits","review_comments_url":"https://api.github.com/repos/squirrel-project/squirrel_robotino/pulls/66/comments","review_comment_url":"https://api.github.com/repos/squirrel-project/squirrel_robotino/pulls/comments{/number}","comments_url":"https://api.github.com/repos/squirrel-project/squirrel_robotino/issues/66/comments","statuses_url":"https://api.github.com/repos/squirrel-project/squirrel_robotino/statuses/260dd558e0bd3dc6a1623e4a41f12f2f81cd78cc","head":{"label":"Senka2112:indigo_dev","ref":"indigo_dev","sha":"260dd558e0bd3dc6a1623e4a41f12f2f81cd78cc","user":{"login":"Senka2112","id":6683150,"avatar_url":"https://avatars.githubusercontent.com/u/6683150?v=3","gravatar_id":"","url":"https://api.github.com/users/Senka2112","html_url":"https://github.com/Senka2112","followers_url":"https://api.github.com/users/Senka2112/followers","following_url":"https://api.github.com/users/Senka2112/following{/other_user}","gists_url":"https://api.github.com/users/Senka2112/gists{/gist_id}","starred_url":"https://api.github.com/users/Senka2112/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Senka2112/subscriptions","organizations_url":"https://api.github.com/users/Senka2112/orgs","repos_url":"https://api.github.com/users/Senka2112/repos","events_url":"https://api.github.com/users/Senka2112/events{/privacy}","received_events_url":"https://api.github.com/users/Senka2112/received_events","type":"User","site_admin":false},"repo":{"id":44374975,"name":"squirrel_robotino-1","full_name":"Senka2112/squirrel_robotino-1","owner":{"login":"Senka2112","id":6683150,"avatar_url":"https://avatars.githubusercontent.com/u/6683150?v=3","gravatar_id":"","url":"https://api.github.com/users/Senka2112","html_url":"https://github.com/Senka2112","followers_url":"https://api.github.com/users/Senka2112/followers","following_url":"https://api.github.com/users/Senka2112/following{/other_user}","gists_url":"https://api.github.com/users/Senka2112/gists{/gist_id}","starred_url":"https://api.github.com/users/Senka2112/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Senka2112/subscriptions","organizations_url":"https://api.github.com/users/Senka2112/orgs","repos_url":"https://api.github.com/users/Senka2112/repos","events_url":"https://api.github.com/users/Senka2112/events{/privacy}","received_events_url":"https://api.github.com/users/Senka2112/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Senka2112/squirrel_robotino-1","description":"This repository holds packages for hardware launch files and configuration, as well as the simulation model for starting up the basic layer for operating Robotino","fork":true,"url":"https://api.github.com/repos/Senka2112/squirrel_robotino-1","forks_url":"https://api.github.com/repos/Senka2112/squirrel_robotino-1/forks","keys_url":"https://api.github.com/repos/Senka2112/squirrel_robotino-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Senka2112/squirrel_robotino-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Senka2112/squirrel_robotino-1/teams","hooks_url":"https://api.github.com/repos/Senka2112/squirrel_robotino-1/hooks","issue_events_url":"https://api.github.com/repos/Senka2112/squirrel_robotino-1/issues/events{/number}","events_url":"https://api.github.com/repos/Senka2112/squirrel_robotino-1/events","assignees_url":"https://api.github.com/repos/Senka2112/squirrel_robotino-1/assignees{/user}","branches_url":"https://api.github.com/repos/Senka2112/squirrel_robotino-1/branches{/branch}","tags_url":"https://api.github.com/repos/Senka2112/squirrel_robotino-1/tags","blobs_url":"https://api.github.com/repos/Senka2112/squirrel_robotino-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Senka2112/squirrel_robotino-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Senka2112/squirrel_robotino-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/Senka2112/squirrel_robotino-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Senka2112/squirrel_robotino-1/statuses/{sha}","languages_url":"https://api.github.com/repos/Senka2112/squirrel_robotino-1/languages","stargazers_url":"https://api.github.com/repos/Senka2112/squirrel_robotino-1/stargazers","contributors_url":"https://api.github.com/repos/Senka2112/squirrel_robotino-1/contributors","subscribers_url":"https://api.github.com/repos/Senka2112/squirrel_robotino-1/subscribers","subscription_url":"https://api.github.com/repos/Senka2112/squirrel_robotino-1/subscription","commits_url":"https://api.github.com/repos/Senka2112/squirrel_robotino-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/Senka2112/squirrel_robotino-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/Senka2112/squirrel_robotino-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/Senka2112/squirrel_robotino-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/Senka2112/squirrel_robotino-1/contents/{+path}","compare_url":"https://api.github.com/repos/Senka2112/squirrel_robotino-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Senka2112/squirrel_robotino-1/merges","archive_url":"https://api.github.com/repos/Senka2112/squirrel_robotino-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Senka2112/squirrel_robotino-1/downloads","issues_url":"https://api.github.com/repos/Senka2112/squirrel_robotino-1/issues{/number}","pulls_url":"https://api.github.com/repos/Senka2112/squirrel_robotino-1/pulls{/number}","milestones_url":"https://api.github.com/repos/Senka2112/squirrel_robotino-1/milestones{/number}","notifications_url":"https://api.github.com/repos/Senka2112/squirrel_robotino-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Senka2112/squirrel_robotino-1/labels{/name}","releases_url":"https://api.github.com/repos/Senka2112/squirrel_robotino-1/releases{/id}","created_at":"2015-10-16T09:16:37Z","updated_at":"2015-10-16T09:16:41Z","pushed_at":"2015-11-23T15:23:45Z","git_url":"git://github.com/Senka2112/squirrel_robotino-1.git","ssh_url":"git@github.com:Senka2112/squirrel_robotino-1.git","clone_url":"https://github.com/Senka2112/squirrel_robotino-1.git","svn_url":"https://github.com/Senka2112/squirrel_robotino-1","homepage":null,"size":23677,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"indigo_dev"}},"base":{"label":"squirrel-project:indigo_dev","ref":"indigo_dev","sha":"e15a22c0977280a9d365cc337541442467ae3f80","user":{"login":"squirrel-project","id":6783934,"avatar_url":"https://avatars.githubusercontent.com/u/6783934?v=3","gravatar_id":"","url":"https://api.github.com/users/squirrel-project","html_url":"https://github.com/squirrel-project","followers_url":"https://api.github.com/users/squirrel-project/followers","following_url":"https://api.github.com/users/squirrel-project/following{/other_user}","gists_url":"https://api.github.com/users/squirrel-project/gists{/gist_id}","starred_url":"https://api.github.com/users/squirrel-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/squirrel-project/subscriptions","organizations_url":"https://api.github.com/users/squirrel-project/orgs","repos_url":"https://api.github.com/users/squirrel-project/repos","events_url":"https://api.github.com/users/squirrel-project/events{/privacy}","received_events_url":"https://api.github.com/users/squirrel-project/received_events","type":"Organization","site_admin":false},"repo":{"id":26916946,"name":"squirrel_robotino","full_name":"squirrel-project/squirrel_robotino","owner":{"login":"squirrel-project","id":6783934,"avatar_url":"https://avatars.githubusercontent.com/u/6783934?v=3","gravatar_id":"","url":"https://api.github.com/users/squirrel-project","html_url":"https://github.com/squirrel-project","followers_url":"https://api.github.com/users/squirrel-project/followers","following_url":"https://api.github.com/users/squirrel-project/following{/other_user}","gists_url":"https://api.github.com/users/squirrel-project/gists{/gist_id}","starred_url":"https://api.github.com/users/squirrel-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/squirrel-project/subscriptions","organizations_url":"https://api.github.com/users/squirrel-project/orgs","repos_url":"https://api.github.com/users/squirrel-project/repos","events_url":"https://api.github.com/users/squirrel-project/events{/privacy}","received_events_url":"https://api.github.com/users/squirrel-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/squirrel-project/squirrel_robotino","description":"This repository holds packages for hardware launch files and configuration, as well as the simulation model for starting up the basic layer for operating Robotino","fork":false,"url":"https://api.github.com/repos/squirrel-project/squirrel_robotino","forks_url":"https://api.github.com/repos/squirrel-project/squirrel_robotino/forks","keys_url":"https://api.github.com/repos/squirrel-project/squirrel_robotino/keys{/key_id}","collaborators_url":"https://api.github.com/repos/squirrel-project/squirrel_robotino/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/squirrel-project/squirrel_robotino/teams","hooks_url":"https://api.github.com/repos/squirrel-project/squirrel_robotino/hooks","issue_events_url":"https://api.github.com/repos/squirrel-project/squirrel_robotino/issues/events{/number}","events_url":"https://api.github.com/repos/squirrel-project/squirrel_robotino/events","assignees_url":"https://api.github.com/repos/squirrel-project/squirrel_robotino/assignees{/user}","branches_url":"https://api.github.com/repos/squirrel-project/squirrel_robotino/branches{/branch}","tags_url":"https://api.github.com/repos/squirrel-project/squirrel_robotino/tags","blobs_url":"https://api.github.com/repos/squirrel-project/squirrel_robotino/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/squirrel-project/squirrel_robotino/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/squirrel-project/squirrel_robotino/git/refs{/sha}","trees_url":"https://api.github.com/repos/squirrel-project/squirrel_robotino/git/trees{/sha}","statuses_url":"https://api.github.com/repos/squirrel-project/squirrel_robotino/statuses/{sha}","languages_url":"https://api.github.com/repos/squirrel-project/squirrel_robotino/languages","stargazers_url":"https://api.github.com/repos/squirrel-project/squirrel_robotino/stargazers","contributors_url":"https://api.github.com/repos/squirrel-project/squirrel_robotino/contributors","subscribers_url":"https://api.github.com/repos/squirrel-project/squirrel_robotino/subscribers","subscription_url":"https://api.github.com/repos/squirrel-project/squirrel_robotino/subscription","commits_url":"https://api.github.com/repos/squirrel-project/squirrel_robotino/commits{/sha}","git_commits_url":"https://api.github.com/repos/squirrel-project/squirrel_robotino/git/commits{/sha}","comments_url":"https://api.github.com/repos/squirrel-project/squirrel_robotino/comments{/number}","issue_comment_url":"https://api.github.com/repos/squirrel-project/squirrel_robotino/issues/comments{/number}","contents_url":"https://api.github.com/repos/squirrel-project/squirrel_robotino/contents/{+path}","compare_url":"https://api.github.com/repos/squirrel-project/squirrel_robotino/compare/{base}...{head}","merges_url":"https://api.github.com/repos/squirrel-project/squirrel_robotino/merges","archive_url":"https://api.github.com/repos/squirrel-project/squirrel_robotino/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/squirrel-project/squirrel_robotino/downloads","issues_url":"https://api.github.com/repos/squirrel-project/squirrel_robotino/issues{/number}","pulls_url":"https://api.github.com/repos/squirrel-project/squirrel_robotino/pulls{/number}","milestones_url":"https://api.github.com/repos/squirrel-project/squirrel_robotino/milestones{/number}","notifications_url":"https://api.github.com/repos/squirrel-project/squirrel_robotino/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/squirrel-project/squirrel_robotino/labels{/name}","releases_url":"https://api.github.com/repos/squirrel-project/squirrel_robotino/releases{/id}","created_at":"2014-11-20T14:51:43Z","updated_at":"2015-09-24T09:09:33Z","pushed_at":"2015-11-23T15:23:45Z","git_url":"git://github.com/squirrel-project/squirrel_robotino.git","ssh_url":"git@github.com:squirrel-project/squirrel_robotino.git","clone_url":"https://github.com/squirrel-project/squirrel_robotino.git","svn_url":"https://github.com/squirrel-project/squirrel_robotino","homepage":null,"size":24086,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":3,"forks":7,"open_issues":3,"watchers":0,"default_branch":"indigo_dev"}},"_links":{"self":{"href":"https://api.github.com/repos/squirrel-project/squirrel_robotino/pulls/66"},"html":{"href":"https://github.com/squirrel-project/squirrel_robotino/pull/66"},"issue":{"href":"https://api.github.com/repos/squirrel-project/squirrel_robotino/issues/66"},"comments":{"href":"https://api.github.com/repos/squirrel-project/squirrel_robotino/issues/66/comments"},"review_comments":{"href":"https://api.github.com/repos/squirrel-project/squirrel_robotino/pulls/66/comments"},"review_comment":{"href":"https://api.github.com/repos/squirrel-project/squirrel_robotino/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/squirrel-project/squirrel_robotino/pulls/66/commits"},"statuses":{"href":"https://api.github.com/repos/squirrel-project/squirrel_robotino/statuses/260dd558e0bd3dc6a1623e4a41f12f2f81cd78cc"}}}}