{"action":"created","comment":{"url":"https://api.github.com/repos/owncloud/core/pulls/comments/27768565","id":27768565,"diff_hunk":"@@ -58,10 +58,10 @@ protected function configure() {\n \t\t\t\t'User ID used to login (must only contain a-z, A-Z, 0-9, -, _ and @)'\n \t\t\t)\n \t\t\t->addOption(\n-\t\t\t\t'password',","path":"core/command/user/add.php","position":4,"original_position":4,"commit_id":"d9323ca1be35ffe0a115278de29106fe37d35c63","original_commit_id":"d9323ca1be35ffe0a115278de29106fe37d35c63","user":{"login":"Crote","id":931757,"avatar_url":"https://avatars.githubusercontent.com/u/931757?v=3","gravatar_id":"","url":"https://api.github.com/users/Crote","html_url":"https://github.com/Crote","followers_url":"https://api.github.com/users/Crote/followers","following_url":"https://api.github.com/users/Crote/following{/other_user}","gists_url":"https://api.github.com/users/Crote/gists{/gist_id}","starred_url":"https://api.github.com/users/Crote/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Crote/subscriptions","organizations_url":"https://api.github.com/users/Crote/orgs","repos_url":"https://api.github.com/users/Crote/repos","events_url":"https://api.github.com/users/Crote/events{/privacy}","received_events_url":"https://api.github.com/users/Crote/received_events","type":"User","site_admin":false},"body":"Because it is insecure. The whole command, including the password, in this case, shows up when any user does a `ps` on the server. This means that anyone using this option to script adding users will inadvertedly expose the password of the newly created user.\r\n\r\nNormally I would not have removed any options due to backwards compatibility, but as the user:add command is not yet in stable it would be more reasonable to not support the insecure option at all.","created_at":"2015-04-04T12:17:20Z","updated_at":"2015-04-04T12:17:20Z","html_url":"https://github.com/owncloud/core/pull/15404#discussion_r27768565","pull_request_url":"https://api.github.com/repos/owncloud/core/pulls/15404","_links":{"self":{"href":"https://api.github.com/repos/owncloud/core/pulls/comments/27768565"},"html":{"href":"https://github.com/owncloud/core/pull/15404#discussion_r27768565"},"pull_request":{"href":"https://api.github.com/repos/owncloud/core/pulls/15404"}}},"pull_request":{"url":"https://api.github.com/repos/owncloud/core/pulls/15404","id":32632709,"html_url":"https://github.com/owncloud/core/pull/15404","diff_url":"https://github.com/owncloud/core/pull/15404.diff","patch_url":"https://github.com/owncloud/core/pull/15404.patch","issue_url":"https://api.github.com/repos/owncloud/core/issues/15404","number":15404,"state":"open","locked":false,"title":"Add password input from env variable for occ user:{add, resetpassword}","user":{"login":"Crote","id":931757,"avatar_url":"https://avatars.githubusercontent.com/u/931757?v=3","gravatar_id":"","url":"https://api.github.com/users/Crote","html_url":"https://github.com/Crote","followers_url":"https://api.github.com/users/Crote/followers","following_url":"https://api.github.com/users/Crote/following{/other_user}","gists_url":"https://api.github.com/users/Crote/gists{/gist_id}","starred_url":"https://api.github.com/users/Crote/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Crote/subscriptions","organizations_url":"https://api.github.com/users/Crote/orgs","repos_url":"https://api.github.com/users/Crote/repos","events_url":"https://api.github.com/users/Crote/events{/privacy}","received_events_url":"https://api.github.com/users/Crote/received_events","type":"User","site_admin":false},"body":"This commit adds the --password-from-env switch to the `occ user:add` and\r\n`occ user:resetpassword` commands. When this parameter is given, Owncloud\r\nwill use the password specified in environment variable OC_PASS. This\r\nis safer than using command line parameters, as those can be read by any\r\nprocess.\r\n\r\nI haven't been able to verify that the alteration to user:add works, but it's pretty much a copy & paste from user:resetpassword which I have been able to verify as working.\r\n\r\nIdeally, to keep the code DRY, the password retrieval routine should be extracted to a separate class, but I'm a Ruby dev, not a PHP one, so that's left for someone else.\r\n\r\nThis contribution is MIT licenced.","created_at":"2015-04-04T12:06:09Z","updated_at":"2015-04-04T12:17:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d8cec7168a4d6d414571aa33954196266f78defa","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/owncloud/core/pulls/15404/commits","review_comments_url":"https://api.github.com/repos/owncloud/core/pulls/15404/comments","review_comment_url":"https://api.github.com/repos/owncloud/core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/owncloud/core/issues/15404/comments","statuses_url":"https://api.github.com/repos/owncloud/core/statuses/d9323ca1be35ffe0a115278de29106fe37d35c63","head":{"label":"Crote:occ-password-from-env","ref":"occ-password-from-env","sha":"d9323ca1be35ffe0a115278de29106fe37d35c63","user":{"login":"Crote","id":931757,"avatar_url":"https://avatars.githubusercontent.com/u/931757?v=3","gravatar_id":"","url":"https://api.github.com/users/Crote","html_url":"https://github.com/Crote","followers_url":"https://api.github.com/users/Crote/followers","following_url":"https://api.github.com/users/Crote/following{/other_user}","gists_url":"https://api.github.com/users/Crote/gists{/gist_id}","starred_url":"https://api.github.com/users/Crote/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Crote/subscriptions","organizations_url":"https://api.github.com/users/Crote/orgs","repos_url":"https://api.github.com/users/Crote/repos","events_url":"https://api.github.com/users/Crote/events{/privacy}","received_events_url":"https://api.github.com/users/Crote/received_events","type":"User","site_admin":false},"repo":{"id":33212363,"name":"core","full_name":"Crote/core","owner":{"login":"Crote","id":931757,"avatar_url":"https://avatars.githubusercontent.com/u/931757?v=3","gravatar_id":"","url":"https://api.github.com/users/Crote","html_url":"https://github.com/Crote","followers_url":"https://api.github.com/users/Crote/followers","following_url":"https://api.github.com/users/Crote/following{/other_user}","gists_url":"https://api.github.com/users/Crote/gists{/gist_id}","starred_url":"https://api.github.com/users/Crote/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Crote/subscriptions","organizations_url":"https://api.github.com/users/Crote/orgs","repos_url":"https://api.github.com/users/Crote/repos","events_url":"https://api.github.com/users/Crote/events{/privacy}","received_events_url":"https://api.github.com/users/Crote/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Crote/core","description":"The ownCloud core","fork":true,"url":"https://api.github.com/repos/Crote/core","forks_url":"https://api.github.com/repos/Crote/core/forks","keys_url":"https://api.github.com/repos/Crote/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Crote/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Crote/core/teams","hooks_url":"https://api.github.com/repos/Crote/core/hooks","issue_events_url":"https://api.github.com/repos/Crote/core/issues/events{/number}","events_url":"https://api.github.com/repos/Crote/core/events","assignees_url":"https://api.github.com/repos/Crote/core/assignees{/user}","branches_url":"https://api.github.com/repos/Crote/core/branches{/branch}","tags_url":"https://api.github.com/repos/Crote/core/tags","blobs_url":"https://api.github.com/repos/Crote/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Crote/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Crote/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/Crote/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Crote/core/statuses/{sha}","languages_url":"https://api.github.com/repos/Crote/core/languages","stargazers_url":"https://api.github.com/repos/Crote/core/stargazers","contributors_url":"https://api.github.com/repos/Crote/core/contributors","subscribers_url":"https://api.github.com/repos/Crote/core/subscribers","subscription_url":"https://api.github.com/repos/Crote/core/subscription","commits_url":"https://api.github.com/repos/Crote/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/Crote/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/Crote/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/Crote/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/Crote/core/contents/{+path}","compare_url":"https://api.github.com/repos/Crote/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Crote/core/merges","archive_url":"https://api.github.com/repos/Crote/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Crote/core/downloads","issues_url":"https://api.github.com/repos/Crote/core/issues{/number}","pulls_url":"https://api.github.com/repos/Crote/core/pulls{/number}","milestones_url":"https://api.github.com/repos/Crote/core/milestones{/number}","notifications_url":"https://api.github.com/repos/Crote/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Crote/core/labels{/name}","releases_url":"https://api.github.com/repos/Crote/core/releases{/id}","created_at":"2015-03-31T21:58:42Z","updated_at":"2015-03-31T21:58:55Z","pushed_at":"2015-04-04T11:25:12Z","git_url":"git://github.com/Crote/core.git","ssh_url":"git@github.com:Crote/core.git","clone_url":"https://github.com/Crote/core.git","svn_url":"https://github.com/Crote/core","homepage":null,"size":166247,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"owncloud:master","ref":"master","sha":"4996706078a901fa532b0fed0fb0bc264d1ba778","user":{"login":"owncloud","id":1645051,"avatar_url":"https://avatars.githubusercontent.com/u/1645051?v=3","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"repo":{"id":5550552,"name":"core","full_name":"owncloud/core","owner":{"login":"owncloud","id":1645051,"avatar_url":"https://avatars.githubusercontent.com/u/1645051?v=3","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/owncloud/core","description":"The ownCloud core","fork":false,"url":"https://api.github.com/repos/owncloud/core","forks_url":"https://api.github.com/repos/owncloud/core/forks","keys_url":"https://api.github.com/repos/owncloud/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/owncloud/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/owncloud/core/teams","hooks_url":"https://api.github.com/repos/owncloud/core/hooks","issue_events_url":"https://api.github.com/repos/owncloud/core/issues/events{/number}","events_url":"https://api.github.com/repos/owncloud/core/events","assignees_url":"https://api.github.com/repos/owncloud/core/assignees{/user}","branches_url":"https://api.github.com/repos/owncloud/core/branches{/branch}","tags_url":"https://api.github.com/repos/owncloud/core/tags","blobs_url":"https://api.github.com/repos/owncloud/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/owncloud/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/owncloud/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/owncloud/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/owncloud/core/statuses/{sha}","languages_url":"https://api.github.com/repos/owncloud/core/languages","stargazers_url":"https://api.github.com/repos/owncloud/core/stargazers","contributors_url":"https://api.github.com/repos/owncloud/core/contributors","subscribers_url":"https://api.github.com/repos/owncloud/core/subscribers","subscription_url":"https://api.github.com/repos/owncloud/core/subscription","commits_url":"https://api.github.com/repos/owncloud/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/owncloud/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/owncloud/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/owncloud/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/owncloud/core/contents/{+path}","compare_url":"https://api.github.com/repos/owncloud/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/owncloud/core/merges","archive_url":"https://api.github.com/repos/owncloud/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/owncloud/core/downloads","issues_url":"https://api.github.com/repos/owncloud/core/issues{/number}","pulls_url":"https://api.github.com/repos/owncloud/core/pulls{/number}","milestones_url":"https://api.github.com/repos/owncloud/core/milestones{/number}","notifications_url":"https://api.github.com/repos/owncloud/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/owncloud/core/labels{/name}","releases_url":"https://api.github.com/repos/owncloud/core/releases{/id}","created_at":"2012-08-25T10:32:48Z","updated_at":"2015-04-04T10:51:42Z","pushed_at":"2015-04-04T12:06:10Z","git_url":"git://github.com/owncloud/core.git","ssh_url":"git@github.com:owncloud/core.git","clone_url":"https://github.com/owncloud/core.git","svn_url":"https://github.com/owncloud/core","homepage":null,"size":988122,"stargazers_count":3193,"watchers_count":3193,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1022,"mirror_url":null,"open_issues_count":1652,"forks":1022,"open_issues":1652,"watchers":3193,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/owncloud/core/pulls/15404"},"html":{"href":"https://github.com/owncloud/core/pull/15404"},"issue":{"href":"https://api.github.com/repos/owncloud/core/issues/15404"},"comments":{"href":"https://api.github.com/repos/owncloud/core/issues/15404/comments"},"review_comments":{"href":"https://api.github.com/repos/owncloud/core/pulls/15404/comments"},"review_comment":{"href":"https://api.github.com/repos/owncloud/core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/owncloud/core/pulls/15404/commits"},"statuses":{"href":"https://api.github.com/repos/owncloud/core/statuses/d9323ca1be35ffe0a115278de29106fe37d35c63"}}}}