{"action":"created","comment":{"url":"https://api.github.com/repos/SUSE-Cloud/suse-cloud-upgrade/pulls/comments/23836414","id":23836414,"diff_hunk":"@@ -206,7 +206,35 @@ for node in $allocated_nodes; do\n done\n \n # Make sure all openstack services are down on all nodes before we stop rabbitmq\n-sleep 10\n+services_stopped=\"\"\n+count=0\n+while [ \"$services_stopped\" != \"yes\" -a \"$count\" -lt 100 ]; do\n+  echo \"Waiting for OpenStack services to stop...\"\n+  sleep 1\n+  services_stopped=\"yes\"\n+  for node in $allocated_nodes; do\n+    if ssh \"$node\" 'shopt -s nullglob\n+      for i in /etc/init.d/openstack-* ; do\n+        if $i status >/dev/null ; then\n+          echo \"$i still running at `hostname`\"; exit 0\n+        fi\n+      done\n+      if pgrep -f neutron-ns-metadata-proxy >/dev/null; then\n+        echo \"neutron proxy is still runing at `hostname`\"\n+        exit 0\n+      fi\n+      exit 1'; then\n+      services_stopped=\"no\"\n+    fi\n+    if [ \"$services_stopped\" == \"no\" ]; then","path":"lib/suse-cloud-upgrade-4-to-5-pre","position":25,"original_position":25,"commit_id":"03fb342493665bc79eb3235c489afd6b29bb3eb7","original_commit_id":"03fb342493665bc79eb3235c489afd6b29bb3eb7","user":{"login":"aspiers","id":100738,"avatar_url":"https://avatars.githubusercontent.com/u/100738?v=3","gravatar_id":"","url":"https://api.github.com/users/aspiers","html_url":"https://github.com/aspiers","followers_url":"https://api.github.com/users/aspiers/followers","following_url":"https://api.github.com/users/aspiers/following{/other_user}","gists_url":"https://api.github.com/users/aspiers/gists{/gist_id}","starred_url":"https://api.github.com/users/aspiers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspiers/subscriptions","organizations_url":"https://api.github.com/users/aspiers/orgs","repos_url":"https://api.github.com/users/aspiers/repos","events_url":"https://api.github.com/users/aspiers/events{/privacy}","received_events_url":"https://api.github.com/users/aspiers/received_events","type":"User","site_admin":false},"body":"Yes, I know.  I didn't say the `break` is pointless, just these two lines.","created_at":"2015-01-30T11:18:34Z","updated_at":"2015-01-30T11:18:34Z","html_url":"https://github.com/SUSE-Cloud/suse-cloud-upgrade/pull/33#discussion_r23836414","pull_request_url":"https://api.github.com/repos/SUSE-Cloud/suse-cloud-upgrade/pulls/33","_links":{"self":{"href":"https://api.github.com/repos/SUSE-Cloud/suse-cloud-upgrade/pulls/comments/23836414"},"html":{"href":"https://github.com/SUSE-Cloud/suse-cloud-upgrade/pull/33#discussion_r23836414"},"pull_request":{"href":"https://api.github.com/repos/SUSE-Cloud/suse-cloud-upgrade/pulls/33"}}},"pull_request":{"url":"https://api.github.com/repos/SUSE-Cloud/suse-cloud-upgrade/pulls/33","id":28193298,"html_url":"https://github.com/SUSE-Cloud/suse-cloud-upgrade/pull/33","diff_url":"https://github.com/SUSE-Cloud/suse-cloud-upgrade/pull/33.diff","patch_url":"https://github.com/SUSE-Cloud/suse-cloud-upgrade/pull/33.patch","issue_url":"https://api.github.com/repos/SUSE-Cloud/suse-cloud-upgrade/issues/33","number":33,"state":"open","locked":false,"title":"Make sure all openstack services are down on all nodes before we stop rabbitmq","user":{"login":"jsuchome","id":910000,"avatar_url":"https://avatars.githubusercontent.com/u/910000?v=3","gravatar_id":"","url":"https://api.github.com/users/jsuchome","html_url":"https://github.com/jsuchome","followers_url":"https://api.github.com/users/jsuchome/followers","following_url":"https://api.github.com/users/jsuchome/following{/other_user}","gists_url":"https://api.github.com/users/jsuchome/gists{/gist_id}","starred_url":"https://api.github.com/users/jsuchome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsuchome/subscriptions","organizations_url":"https://api.github.com/users/jsuchome/orgs","repos_url":"https://api.github.com/users/jsuchome/repos","events_url":"https://api.github.com/users/jsuchome/events{/privacy}","received_events_url":"https://api.github.com/users/jsuchome/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-01-28T13:31:01Z","updated_at":"2015-01-30T11:18:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a0cac7e07fc4dcb563e0728876ab027b0efca2f8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/SUSE-Cloud/suse-cloud-upgrade/pulls/33/commits","review_comments_url":"https://api.github.com/repos/SUSE-Cloud/suse-cloud-upgrade/pulls/33/comments","review_comment_url":"https://api.github.com/repos/SUSE-Cloud/suse-cloud-upgrade/pulls/comments/{number}","comments_url":"https://api.github.com/repos/SUSE-Cloud/suse-cloud-upgrade/issues/33/comments","statuses_url":"https://api.github.com/repos/SUSE-Cloud/suse-cloud-upgrade/statuses/03fb342493665bc79eb3235c489afd6b29bb3eb7","head":{"label":"jsuchome:wait_for_openstack","ref":"wait_for_openstack","sha":"03fb342493665bc79eb3235c489afd6b29bb3eb7","user":{"login":"jsuchome","id":910000,"avatar_url":"https://avatars.githubusercontent.com/u/910000?v=3","gravatar_id":"","url":"https://api.github.com/users/jsuchome","html_url":"https://github.com/jsuchome","followers_url":"https://api.github.com/users/jsuchome/followers","following_url":"https://api.github.com/users/jsuchome/following{/other_user}","gists_url":"https://api.github.com/users/jsuchome/gists{/gist_id}","starred_url":"https://api.github.com/users/jsuchome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsuchome/subscriptions","organizations_url":"https://api.github.com/users/jsuchome/orgs","repos_url":"https://api.github.com/users/jsuchome/repos","events_url":"https://api.github.com/users/jsuchome/events{/privacy}","received_events_url":"https://api.github.com/users/jsuchome/received_events","type":"User","site_admin":false},"repo":{"id":28862779,"name":"suse-cloud-upgrade","full_name":"jsuchome/suse-cloud-upgrade","owner":{"login":"jsuchome","id":910000,"avatar_url":"https://avatars.githubusercontent.com/u/910000?v=3","gravatar_id":"","url":"https://api.github.com/users/jsuchome","html_url":"https://github.com/jsuchome","followers_url":"https://api.github.com/users/jsuchome/followers","following_url":"https://api.github.com/users/jsuchome/following{/other_user}","gists_url":"https://api.github.com/users/jsuchome/gists{/gist_id}","starred_url":"https://api.github.com/users/jsuchome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsuchome/subscriptions","organizations_url":"https://api.github.com/users/jsuchome/orgs","repos_url":"https://api.github.com/users/jsuchome/repos","events_url":"https://api.github.com/users/jsuchome/events{/privacy}","received_events_url":"https://api.github.com/users/jsuchome/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jsuchome/suse-cloud-upgrade","description":"Upgrade scripts for SUSE Cloud","fork":true,"url":"https://api.github.com/repos/jsuchome/suse-cloud-upgrade","forks_url":"https://api.github.com/repos/jsuchome/suse-cloud-upgrade/forks","keys_url":"https://api.github.com/repos/jsuchome/suse-cloud-upgrade/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jsuchome/suse-cloud-upgrade/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jsuchome/suse-cloud-upgrade/teams","hooks_url":"https://api.github.com/repos/jsuchome/suse-cloud-upgrade/hooks","issue_events_url":"https://api.github.com/repos/jsuchome/suse-cloud-upgrade/issues/events{/number}","events_url":"https://api.github.com/repos/jsuchome/suse-cloud-upgrade/events","assignees_url":"https://api.github.com/repos/jsuchome/suse-cloud-upgrade/assignees{/user}","branches_url":"https://api.github.com/repos/jsuchome/suse-cloud-upgrade/branches{/branch}","tags_url":"https://api.github.com/repos/jsuchome/suse-cloud-upgrade/tags","blobs_url":"https://api.github.com/repos/jsuchome/suse-cloud-upgrade/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jsuchome/suse-cloud-upgrade/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jsuchome/suse-cloud-upgrade/git/refs{/sha}","trees_url":"https://api.github.com/repos/jsuchome/suse-cloud-upgrade/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jsuchome/suse-cloud-upgrade/statuses/{sha}","languages_url":"https://api.github.com/repos/jsuchome/suse-cloud-upgrade/languages","stargazers_url":"https://api.github.com/repos/jsuchome/suse-cloud-upgrade/stargazers","contributors_url":"https://api.github.com/repos/jsuchome/suse-cloud-upgrade/contributors","subscribers_url":"https://api.github.com/repos/jsuchome/suse-cloud-upgrade/subscribers","subscription_url":"https://api.github.com/repos/jsuchome/suse-cloud-upgrade/subscription","commits_url":"https://api.github.com/repos/jsuchome/suse-cloud-upgrade/commits{/sha}","git_commits_url":"https://api.github.com/repos/jsuchome/suse-cloud-upgrade/git/commits{/sha}","comments_url":"https://api.github.com/repos/jsuchome/suse-cloud-upgrade/comments{/number}","issue_comment_url":"https://api.github.com/repos/jsuchome/suse-cloud-upgrade/issues/comments/{number}","contents_url":"https://api.github.com/repos/jsuchome/suse-cloud-upgrade/contents/{+path}","compare_url":"https://api.github.com/repos/jsuchome/suse-cloud-upgrade/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jsuchome/suse-cloud-upgrade/merges","archive_url":"https://api.github.com/repos/jsuchome/suse-cloud-upgrade/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jsuchome/suse-cloud-upgrade/downloads","issues_url":"https://api.github.com/repos/jsuchome/suse-cloud-upgrade/issues{/number}","pulls_url":"https://api.github.com/repos/jsuchome/suse-cloud-upgrade/pulls{/number}","milestones_url":"https://api.github.com/repos/jsuchome/suse-cloud-upgrade/milestones{/number}","notifications_url":"https://api.github.com/repos/jsuchome/suse-cloud-upgrade/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jsuchome/suse-cloud-upgrade/labels{/name}","releases_url":"https://api.github.com/repos/jsuchome/suse-cloud-upgrade/releases{/id}","created_at":"2015-01-06T12:38:59Z","updated_at":"2015-01-06T12:39:00Z","pushed_at":"2015-01-30T11:06:29Z","git_url":"git://github.com/jsuchome/suse-cloud-upgrade.git","ssh_url":"git@github.com:jsuchome/suse-cloud-upgrade.git","clone_url":"https://github.com/jsuchome/suse-cloud-upgrade.git","svn_url":"https://github.com/jsuchome/suse-cloud-upgrade","homepage":null,"size":211,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SUSE-Cloud:master","ref":"master","sha":"89b7e2e5594bdd4425558bcd1d16a7d8acea2350","user":{"login":"SUSE-Cloud","id":1553906,"avatar_url":"https://avatars.githubusercontent.com/u/1553906?v=3","gravatar_id":"","url":"https://api.github.com/users/SUSE-Cloud","html_url":"https://github.com/SUSE-Cloud","followers_url":"https://api.github.com/users/SUSE-Cloud/followers","following_url":"https://api.github.com/users/SUSE-Cloud/following{/other_user}","gists_url":"https://api.github.com/users/SUSE-Cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/SUSE-Cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUSE-Cloud/subscriptions","organizations_url":"https://api.github.com/users/SUSE-Cloud/orgs","repos_url":"https://api.github.com/users/SUSE-Cloud/repos","events_url":"https://api.github.com/users/SUSE-Cloud/events{/privacy}","received_events_url":"https://api.github.com/users/SUSE-Cloud/received_events","type":"Organization","site_admin":false},"repo":{"id":16208119,"name":"suse-cloud-upgrade","full_name":"SUSE-Cloud/suse-cloud-upgrade","owner":{"login":"SUSE-Cloud","id":1553906,"avatar_url":"https://avatars.githubusercontent.com/u/1553906?v=3","gravatar_id":"","url":"https://api.github.com/users/SUSE-Cloud","html_url":"https://github.com/SUSE-Cloud","followers_url":"https://api.github.com/users/SUSE-Cloud/followers","following_url":"https://api.github.com/users/SUSE-Cloud/following{/other_user}","gists_url":"https://api.github.com/users/SUSE-Cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/SUSE-Cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUSE-Cloud/subscriptions","organizations_url":"https://api.github.com/users/SUSE-Cloud/orgs","repos_url":"https://api.github.com/users/SUSE-Cloud/repos","events_url":"https://api.github.com/users/SUSE-Cloud/events{/privacy}","received_events_url":"https://api.github.com/users/SUSE-Cloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SUSE-Cloud/suse-cloud-upgrade","description":"Upgrade scripts for SUSE Cloud","fork":false,"url":"https://api.github.com/repos/SUSE-Cloud/suse-cloud-upgrade","forks_url":"https://api.github.com/repos/SUSE-Cloud/suse-cloud-upgrade/forks","keys_url":"https://api.github.com/repos/SUSE-Cloud/suse-cloud-upgrade/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SUSE-Cloud/suse-cloud-upgrade/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SUSE-Cloud/suse-cloud-upgrade/teams","hooks_url":"https://api.github.com/repos/SUSE-Cloud/suse-cloud-upgrade/hooks","issue_events_url":"https://api.github.com/repos/SUSE-Cloud/suse-cloud-upgrade/issues/events{/number}","events_url":"https://api.github.com/repos/SUSE-Cloud/suse-cloud-upgrade/events","assignees_url":"https://api.github.com/repos/SUSE-Cloud/suse-cloud-upgrade/assignees{/user}","branches_url":"https://api.github.com/repos/SUSE-Cloud/suse-cloud-upgrade/branches{/branch}","tags_url":"https://api.github.com/repos/SUSE-Cloud/suse-cloud-upgrade/tags","blobs_url":"https://api.github.com/repos/SUSE-Cloud/suse-cloud-upgrade/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SUSE-Cloud/suse-cloud-upgrade/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SUSE-Cloud/suse-cloud-upgrade/git/refs{/sha}","trees_url":"https://api.github.com/repos/SUSE-Cloud/suse-cloud-upgrade/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SUSE-Cloud/suse-cloud-upgrade/statuses/{sha}","languages_url":"https://api.github.com/repos/SUSE-Cloud/suse-cloud-upgrade/languages","stargazers_url":"https://api.github.com/repos/SUSE-Cloud/suse-cloud-upgrade/stargazers","contributors_url":"https://api.github.com/repos/SUSE-Cloud/suse-cloud-upgrade/contributors","subscribers_url":"https://api.github.com/repos/SUSE-Cloud/suse-cloud-upgrade/subscribers","subscription_url":"https://api.github.com/repos/SUSE-Cloud/suse-cloud-upgrade/subscription","commits_url":"https://api.github.com/repos/SUSE-Cloud/suse-cloud-upgrade/commits{/sha}","git_commits_url":"https://api.github.com/repos/SUSE-Cloud/suse-cloud-upgrade/git/commits{/sha}","comments_url":"https://api.github.com/repos/SUSE-Cloud/suse-cloud-upgrade/comments{/number}","issue_comment_url":"https://api.github.com/repos/SUSE-Cloud/suse-cloud-upgrade/issues/comments/{number}","contents_url":"https://api.github.com/repos/SUSE-Cloud/suse-cloud-upgrade/contents/{+path}","compare_url":"https://api.github.com/repos/SUSE-Cloud/suse-cloud-upgrade/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SUSE-Cloud/suse-cloud-upgrade/merges","archive_url":"https://api.github.com/repos/SUSE-Cloud/suse-cloud-upgrade/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SUSE-Cloud/suse-cloud-upgrade/downloads","issues_url":"https://api.github.com/repos/SUSE-Cloud/suse-cloud-upgrade/issues{/number}","pulls_url":"https://api.github.com/repos/SUSE-Cloud/suse-cloud-upgrade/pulls{/number}","milestones_url":"https://api.github.com/repos/SUSE-Cloud/suse-cloud-upgrade/milestones{/number}","notifications_url":"https://api.github.com/repos/SUSE-Cloud/suse-cloud-upgrade/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SUSE-Cloud/suse-cloud-upgrade/labels{/name}","releases_url":"https://api.github.com/repos/SUSE-Cloud/suse-cloud-upgrade/releases{/id}","created_at":"2014-01-24T15:21:12Z","updated_at":"2015-01-19T19:09:27Z","pushed_at":"2015-01-22T13:44:46Z","git_url":"git://github.com/SUSE-Cloud/suse-cloud-upgrade.git","ssh_url":"git@github.com:SUSE-Cloud/suse-cloud-upgrade.git","clone_url":"https://github.com/SUSE-Cloud/suse-cloud-upgrade.git","svn_url":"https://github.com/SUSE-Cloud/suse-cloud-upgrade","homepage":null,"size":475,"stargazers_count":2,"watchers_count":2,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":3,"forks":10,"open_issues":3,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SUSE-Cloud/suse-cloud-upgrade/pulls/33"},"html":{"href":"https://github.com/SUSE-Cloud/suse-cloud-upgrade/pull/33"},"issue":{"href":"https://api.github.com/repos/SUSE-Cloud/suse-cloud-upgrade/issues/33"},"comments":{"href":"https://api.github.com/repos/SUSE-Cloud/suse-cloud-upgrade/issues/33/comments"},"review_comments":{"href":"https://api.github.com/repos/SUSE-Cloud/suse-cloud-upgrade/pulls/33/comments"},"review_comment":{"href":"https://api.github.com/repos/SUSE-Cloud/suse-cloud-upgrade/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/SUSE-Cloud/suse-cloud-upgrade/pulls/33/commits"},"statuses":{"href":"https://api.github.com/repos/SUSE-Cloud/suse-cloud-upgrade/statuses/03fb342493665bc79eb3235c489afd6b29bb3eb7"}}}}