{"action":"created","comment":{"url":"https://api.github.com/repos/docker/docker/pulls/comments/30949770","id":30949770,"diff_hunk":"@@ -0,0 +1,7 @@\n+// +build windows\n+\n+package builder\n+\n+func fixPermissions(source, destination string, uid, gid int, destExisted bool) error {\n+\t// chown is not supported on Windows","path":"builder/internals_windows.go","position":6,"original_position":6,"commit_id":"010e3e046b3d31ab69f37dfb504551fe5042d84a","original_commit_id":"285e9d0ab7cb0548ad5ca734b327a05667dd40b8","user":{"login":"jhowardmsft","id":10522484,"avatar_url":"https://avatars.githubusercontent.com/u/10522484?v=3","gravatar_id":"","url":"https://api.github.com/users/jhowardmsft","html_url":"https://github.com/jhowardmsft","followers_url":"https://api.github.com/users/jhowardmsft/followers","following_url":"https://api.github.com/users/jhowardmsft/following{/other_user}","gists_url":"https://api.github.com/users/jhowardmsft/gists{/gist_id}","starred_url":"https://api.github.com/users/jhowardmsft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhowardmsft/subscriptions","organizations_url":"https://api.github.com/users/jhowardmsft/orgs","repos_url":"https://api.github.com/users/jhowardmsft/repos","events_url":"https://api.github.com/users/jhowardmsft/events{/privacy}","received_events_url":"https://api.github.com/users/jhowardmsft/received_events","type":"User","site_admin":false},"body":"@vieux Could you re-review please. Thanks :)","created_at":"2015-05-24T03:06:05Z","updated_at":"2015-05-24T03:06:05Z","html_url":"https://github.com/docker/docker/pull/13055#discussion_r30949770","pull_request_url":"https://api.github.com/repos/docker/docker/pulls/13055","_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/comments/30949770"},"html":{"href":"https://github.com/docker/docker/pull/13055#discussion_r30949770"},"pull_request":{"href":"https://api.github.com/repos/docker/docker/pulls/13055"}}},"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/13055","id":34929830,"html_url":"https://github.com/docker/docker/pull/13055","diff_url":"https://github.com/docker/docker/pull/13055.diff","patch_url":"https://github.com/docker/docker/pull/13055.patch","issue_url":"https://api.github.com/repos/docker/docker/issues/13055","number":13055,"state":"open","locked":false,"title":"Windows: Fixup builder/internals.go","user":{"login":"jhowardmsft","id":10522484,"avatar_url":"https://avatars.githubusercontent.com/u/10522484?v=3","gravatar_id":"","url":"https://api.github.com/users/jhowardmsft","html_url":"https://github.com/jhowardmsft","followers_url":"https://api.github.com/users/jhowardmsft/followers","following_url":"https://api.github.com/users/jhowardmsft/following{/other_user}","gists_url":"https://api.github.com/users/jhowardmsft/gists{/gist_id}","starred_url":"https://api.github.com/users/jhowardmsft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhowardmsft/subscriptions","organizations_url":"https://api.github.com/users/jhowardmsft/orgs","repos_url":"https://api.github.com/users/jhowardmsft/repos","events_url":"https://api.github.com/users/jhowardmsft/events{/privacy}","received_events_url":"https://api.github.com/users/jhowardmsft/received_events","type":"User","site_admin":false},"body":"Signed-off-by: John Howard <jhoward@microsoft.com>\r\n@swernli\r\n\r\nThis PR is part of the proposal described in issue 10662 to port the docker daemon to Windows. This PR has multiple fixes to builder\\internals.go to support Windows and bugfixes. It splits fixPermissions() out into Linux and Windows versions; fixes the use of os.Mkdirall; fixes the default shell; corrects the use of filepath instead of path; and Evaluates symlinks in checkPathForAddition.\r\n","created_at":"2015-05-07T15:50:26Z","updated_at":"2015-05-24T03:06:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6340795bc7228d9eaa130c7da6c2b9ea2c0450df","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/docker/docker/pulls/13055/commits","review_comments_url":"https://api.github.com/repos/docker/docker/pulls/13055/comments","review_comment_url":"https://api.github.com/repos/docker/docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/docker/issues/13055/comments","statuses_url":"https://api.github.com/repos/docker/docker/statuses/010e3e046b3d31ab69f37dfb504551fe5042d84a","head":{"label":"Microsoft:10662-internalsfixperms","ref":"10662-internalsfixperms","sha":"010e3e046b3d31ab69f37dfb504551fe5042d84a","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":30096470,"name":"docker","full_name":"Microsoft/docker","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/docker","description":"Docker - the open-source application container engine","fork":true,"url":"https://api.github.com/repos/Microsoft/docker","forks_url":"https://api.github.com/repos/Microsoft/docker/forks","keys_url":"https://api.github.com/repos/Microsoft/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/docker/teams","hooks_url":"https://api.github.com/repos/Microsoft/docker/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/docker/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/docker/events","assignees_url":"https://api.github.com/repos/Microsoft/docker/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/docker/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/docker/tags","blobs_url":"https://api.github.com/repos/Microsoft/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/docker/languages","stargazers_url":"https://api.github.com/repos/Microsoft/docker/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/docker/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/docker/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/docker/subscription","commits_url":"https://api.github.com/repos/Microsoft/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/docker/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/docker/merges","archive_url":"https://api.github.com/repos/Microsoft/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/docker/downloads","issues_url":"https://api.github.com/repos/Microsoft/docker/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/docker/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/docker/releases{/id}","created_at":"2015-01-31T00:05:16Z","updated_at":"2015-05-21T02:16:10Z","pushed_at":"2015-05-24T02:51:15Z","git_url":"git://github.com/Microsoft/docker.git","ssh_url":"git@github.com:Microsoft/docker.git","clone_url":"https://github.com/Microsoft/docker.git","svn_url":"https://github.com/Microsoft/docker","homepage":"http://www.docker.com","size":58071,"stargazers_count":123,"watchers_count":123,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":26,"mirror_url":null,"open_issues_count":1,"forks":26,"open_issues":1,"watchers":123,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"c696993452636acfbed44da29ebd4c2554a5054d","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":7691631,"name":"docker","full_name":"docker/docker","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/docker","description":"Docker - the open-source application container engine","fork":false,"url":"https://api.github.com/repos/docker/docker","forks_url":"https://api.github.com/repos/docker/docker/forks","keys_url":"https://api.github.com/repos/docker/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/docker/teams","hooks_url":"https://api.github.com/repos/docker/docker/hooks","issue_events_url":"https://api.github.com/repos/docker/docker/issues/events{/number}","events_url":"https://api.github.com/repos/docker/docker/events","assignees_url":"https://api.github.com/repos/docker/docker/assignees{/user}","branches_url":"https://api.github.com/repos/docker/docker/branches{/branch}","tags_url":"https://api.github.com/repos/docker/docker/tags","blobs_url":"https://api.github.com/repos/docker/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/docker/languages","stargazers_url":"https://api.github.com/repos/docker/docker/stargazers","contributors_url":"https://api.github.com/repos/docker/docker/contributors","subscribers_url":"https://api.github.com/repos/docker/docker/subscribers","subscription_url":"https://api.github.com/repos/docker/docker/subscription","commits_url":"https://api.github.com/repos/docker/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/docker/contents/{+path}","compare_url":"https://api.github.com/repos/docker/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/docker/merges","archive_url":"https://api.github.com/repos/docker/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/docker/downloads","issues_url":"https://api.github.com/repos/docker/docker/issues{/number}","pulls_url":"https://api.github.com/repos/docker/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/docker/labels{/name}","releases_url":"https://api.github.com/repos/docker/docker/releases{/id}","created_at":"2013-01-18T18:10:57Z","updated_at":"2015-05-24T02:29:48Z","pushed_at":"2015-05-24T02:51:18Z","git_url":"git://github.com/docker/docker.git","ssh_url":"git@github.com:docker/docker.git","clone_url":"https://github.com/docker/docker.git","svn_url":"https://github.com/docker/docker","homepage":"http://www.docker.com","size":217964,"stargazers_count":21868,"watchers_count":21868,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5165,"mirror_url":null,"open_issues_count":1009,"forks":5165,"open_issues":1009,"watchers":21868,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/13055"},"html":{"href":"https://github.com/docker/docker/pull/13055"},"issue":{"href":"https://api.github.com/repos/docker/docker/issues/13055"},"comments":{"href":"https://api.github.com/repos/docker/docker/issues/13055/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/docker/pulls/13055/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/docker/pulls/13055/commits"},"statuses":{"href":"https://api.github.com/repos/docker/docker/statuses/010e3e046b3d31ab69f37dfb504551fe5042d84a"}}}}