{"action":"closed","number":172,"pull_request":{"url":"https://api.github.com/repos/artem-zinnatullin/android-wail-app/pulls/172","id":39131165,"html_url":"https://github.com/artem-zinnatullin/android-wail-app/pull/172","diff_url":"https://github.com/artem-zinnatullin/android-wail-app/pull/172.diff","patch_url":"https://github.com/artem-zinnatullin/android-wail-app/pull/172.patch","issue_url":"https://api.github.com/repos/artem-zinnatullin/android-wail-app/issues/172","number":172,"state":"closed","locked":false,"title":"'Seconds' text is managed via resource bundles rather than by the code","user":{"login":"bassstorm","id":749825,"avatar_url":"https://avatars.githubusercontent.com/u/749825?v=3","gravatar_id":"","url":"https://api.github.com/users/bassstorm","html_url":"https://github.com/bassstorm","followers_url":"https://api.github.com/users/bassstorm/followers","following_url":"https://api.github.com/users/bassstorm/following{/other_user}","gists_url":"https://api.github.com/users/bassstorm/gists{/gist_id}","starred_url":"https://api.github.com/users/bassstorm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bassstorm/subscriptions","organizations_url":"https://api.github.com/users/bassstorm/orgs","repos_url":"https://api.github.com/users/bassstorm/repos","events_url":"https://api.github.com/users/bassstorm/events{/privacy}","received_events_url":"https://api.github.com/users/bassstorm/received_events","type":"User","site_admin":false},"body":"Hi Devs,\r\n\r\nNoticed that \"seconds\" text is mentioned twice in settings (*Scrobbling options*). First occurrence is generated by code, and second is specified in resource bundle. I think for translators it's better to have all in one single place, and the best choice is resource bundles of course.\r\nSo I updated the code and fixed German translation (not a German speaking guy, so this is to be verified for sure).\r\nShould you see any issue with this pull request - please let me know.\r\n\r\nThanks much,\r\nMaksim","created_at":"2015-07-02T22:16:14Z","updated_at":"2015-07-04T14:13:59Z","closed_at":"2015-07-04T14:13:59Z","merged_at":"2015-07-04T14:13:59Z","merge_commit_sha":"545a563d51d05bd508f47d516b55d0c3c4088eeb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/artem-zinnatullin/android-wail-app/pulls/172/commits","review_comments_url":"https://api.github.com/repos/artem-zinnatullin/android-wail-app/pulls/172/comments","review_comment_url":"https://api.github.com/repos/artem-zinnatullin/android-wail-app/pulls/comments{/number}","comments_url":"https://api.github.com/repos/artem-zinnatullin/android-wail-app/issues/172/comments","statuses_url":"https://api.github.com/repos/artem-zinnatullin/android-wail-app/statuses/ec248888455ca89d63418e050ed192c7aaaca5be","head":{"label":"bassstorm:develop","ref":"develop","sha":"ec248888455ca89d63418e050ed192c7aaaca5be","user":{"login":"bassstorm","id":749825,"avatar_url":"https://avatars.githubusercontent.com/u/749825?v=3","gravatar_id":"","url":"https://api.github.com/users/bassstorm","html_url":"https://github.com/bassstorm","followers_url":"https://api.github.com/users/bassstorm/followers","following_url":"https://api.github.com/users/bassstorm/following{/other_user}","gists_url":"https://api.github.com/users/bassstorm/gists{/gist_id}","starred_url":"https://api.github.com/users/bassstorm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bassstorm/subscriptions","organizations_url":"https://api.github.com/users/bassstorm/orgs","repos_url":"https://api.github.com/users/bassstorm/repos","events_url":"https://api.github.com/users/bassstorm/events{/privacy}","received_events_url":"https://api.github.com/users/bassstorm/received_events","type":"User","site_admin":false},"repo":{"id":38458472,"name":"android-wail-app","full_name":"bassstorm/android-wail-app","owner":{"login":"bassstorm","id":749825,"avatar_url":"https://avatars.githubusercontent.com/u/749825?v=3","gravatar_id":"","url":"https://api.github.com/users/bassstorm","html_url":"https://github.com/bassstorm","followers_url":"https://api.github.com/users/bassstorm/followers","following_url":"https://api.github.com/users/bassstorm/following{/other_user}","gists_url":"https://api.github.com/users/bassstorm/gists{/gist_id}","starred_url":"https://api.github.com/users/bassstorm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bassstorm/subscriptions","organizations_url":"https://api.github.com/users/bassstorm/orgs","repos_url":"https://api.github.com/users/bassstorm/repos","events_url":"https://api.github.com/users/bassstorm/events{/privacy}","received_events_url":"https://api.github.com/users/bassstorm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bassstorm/android-wail-app","description":"Android Last.fm scrobbler","fork":true,"url":"https://api.github.com/repos/bassstorm/android-wail-app","forks_url":"https://api.github.com/repos/bassstorm/android-wail-app/forks","keys_url":"https://api.github.com/repos/bassstorm/android-wail-app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bassstorm/android-wail-app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bassstorm/android-wail-app/teams","hooks_url":"https://api.github.com/repos/bassstorm/android-wail-app/hooks","issue_events_url":"https://api.github.com/repos/bassstorm/android-wail-app/issues/events{/number}","events_url":"https://api.github.com/repos/bassstorm/android-wail-app/events","assignees_url":"https://api.github.com/repos/bassstorm/android-wail-app/assignees{/user}","branches_url":"https://api.github.com/repos/bassstorm/android-wail-app/branches{/branch}","tags_url":"https://api.github.com/repos/bassstorm/android-wail-app/tags","blobs_url":"https://api.github.com/repos/bassstorm/android-wail-app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bassstorm/android-wail-app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bassstorm/android-wail-app/git/refs{/sha}","trees_url":"https://api.github.com/repos/bassstorm/android-wail-app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bassstorm/android-wail-app/statuses/{sha}","languages_url":"https://api.github.com/repos/bassstorm/android-wail-app/languages","stargazers_url":"https://api.github.com/repos/bassstorm/android-wail-app/stargazers","contributors_url":"https://api.github.com/repos/bassstorm/android-wail-app/contributors","subscribers_url":"https://api.github.com/repos/bassstorm/android-wail-app/subscribers","subscription_url":"https://api.github.com/repos/bassstorm/android-wail-app/subscription","commits_url":"https://api.github.com/repos/bassstorm/android-wail-app/commits{/sha}","git_commits_url":"https://api.github.com/repos/bassstorm/android-wail-app/git/commits{/sha}","comments_url":"https://api.github.com/repos/bassstorm/android-wail-app/comments{/number}","issue_comment_url":"https://api.github.com/repos/bassstorm/android-wail-app/issues/comments{/number}","contents_url":"https://api.github.com/repos/bassstorm/android-wail-app/contents/{+path}","compare_url":"https://api.github.com/repos/bassstorm/android-wail-app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bassstorm/android-wail-app/merges","archive_url":"https://api.github.com/repos/bassstorm/android-wail-app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bassstorm/android-wail-app/downloads","issues_url":"https://api.github.com/repos/bassstorm/android-wail-app/issues{/number}","pulls_url":"https://api.github.com/repos/bassstorm/android-wail-app/pulls{/number}","milestones_url":"https://api.github.com/repos/bassstorm/android-wail-app/milestones{/number}","notifications_url":"https://api.github.com/repos/bassstorm/android-wail-app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bassstorm/android-wail-app/labels{/name}","releases_url":"https://api.github.com/repos/bassstorm/android-wail-app/releases{/id}","created_at":"2015-07-02T21:44:27Z","updated_at":"2015-07-02T21:44:28Z","pushed_at":"2015-07-03T14:59:34Z","git_url":"git://github.com/bassstorm/android-wail-app.git","ssh_url":"git@github.com:bassstorm/android-wail-app.git","clone_url":"https://github.com/bassstorm/android-wail-app.git","svn_url":"https://github.com/bassstorm/android-wail-app","homepage":null,"size":5542,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"artem-zinnatullin:develop","ref":"develop","sha":"1b55e01298236511c2643c4ec087f9ac1461a2c5","user":{"login":"artem-zinnatullin","id":967132,"avatar_url":"https://avatars.githubusercontent.com/u/967132?v=3","gravatar_id":"","url":"https://api.github.com/users/artem-zinnatullin","html_url":"https://github.com/artem-zinnatullin","followers_url":"https://api.github.com/users/artem-zinnatullin/followers","following_url":"https://api.github.com/users/artem-zinnatullin/following{/other_user}","gists_url":"https://api.github.com/users/artem-zinnatullin/gists{/gist_id}","starred_url":"https://api.github.com/users/artem-zinnatullin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artem-zinnatullin/subscriptions","organizations_url":"https://api.github.com/users/artem-zinnatullin/orgs","repos_url":"https://api.github.com/users/artem-zinnatullin/repos","events_url":"https://api.github.com/users/artem-zinnatullin/events{/privacy}","received_events_url":"https://api.github.com/users/artem-zinnatullin/received_events","type":"User","site_admin":false},"repo":{"id":21711285,"name":"android-wail-app","full_name":"artem-zinnatullin/android-wail-app","owner":{"login":"artem-zinnatullin","id":967132,"avatar_url":"https://avatars.githubusercontent.com/u/967132?v=3","gravatar_id":"","url":"https://api.github.com/users/artem-zinnatullin","html_url":"https://github.com/artem-zinnatullin","followers_url":"https://api.github.com/users/artem-zinnatullin/followers","following_url":"https://api.github.com/users/artem-zinnatullin/following{/other_user}","gists_url":"https://api.github.com/users/artem-zinnatullin/gists{/gist_id}","starred_url":"https://api.github.com/users/artem-zinnatullin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artem-zinnatullin/subscriptions","organizations_url":"https://api.github.com/users/artem-zinnatullin/orgs","repos_url":"https://api.github.com/users/artem-zinnatullin/repos","events_url":"https://api.github.com/users/artem-zinnatullin/events{/privacy}","received_events_url":"https://api.github.com/users/artem-zinnatullin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/artem-zinnatullin/android-wail-app","description":"Android Last.fm scrobbler","fork":false,"url":"https://api.github.com/repos/artem-zinnatullin/android-wail-app","forks_url":"https://api.github.com/repos/artem-zinnatullin/android-wail-app/forks","keys_url":"https://api.github.com/repos/artem-zinnatullin/android-wail-app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/artem-zinnatullin/android-wail-app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/artem-zinnatullin/android-wail-app/teams","hooks_url":"https://api.github.com/repos/artem-zinnatullin/android-wail-app/hooks","issue_events_url":"https://api.github.com/repos/artem-zinnatullin/android-wail-app/issues/events{/number}","events_url":"https://api.github.com/repos/artem-zinnatullin/android-wail-app/events","assignees_url":"https://api.github.com/repos/artem-zinnatullin/android-wail-app/assignees{/user}","branches_url":"https://api.github.com/repos/artem-zinnatullin/android-wail-app/branches{/branch}","tags_url":"https://api.github.com/repos/artem-zinnatullin/android-wail-app/tags","blobs_url":"https://api.github.com/repos/artem-zinnatullin/android-wail-app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/artem-zinnatullin/android-wail-app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/artem-zinnatullin/android-wail-app/git/refs{/sha}","trees_url":"https://api.github.com/repos/artem-zinnatullin/android-wail-app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/artem-zinnatullin/android-wail-app/statuses/{sha}","languages_url":"https://api.github.com/repos/artem-zinnatullin/android-wail-app/languages","stargazers_url":"https://api.github.com/repos/artem-zinnatullin/android-wail-app/stargazers","contributors_url":"https://api.github.com/repos/artem-zinnatullin/android-wail-app/contributors","subscribers_url":"https://api.github.com/repos/artem-zinnatullin/android-wail-app/subscribers","subscription_url":"https://api.github.com/repos/artem-zinnatullin/android-wail-app/subscription","commits_url":"https://api.github.com/repos/artem-zinnatullin/android-wail-app/commits{/sha}","git_commits_url":"https://api.github.com/repos/artem-zinnatullin/android-wail-app/git/commits{/sha}","comments_url":"https://api.github.com/repos/artem-zinnatullin/android-wail-app/comments{/number}","issue_comment_url":"https://api.github.com/repos/artem-zinnatullin/android-wail-app/issues/comments{/number}","contents_url":"https://api.github.com/repos/artem-zinnatullin/android-wail-app/contents/{+path}","compare_url":"https://api.github.com/repos/artem-zinnatullin/android-wail-app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/artem-zinnatullin/android-wail-app/merges","archive_url":"https://api.github.com/repos/artem-zinnatullin/android-wail-app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/artem-zinnatullin/android-wail-app/downloads","issues_url":"https://api.github.com/repos/artem-zinnatullin/android-wail-app/issues{/number}","pulls_url":"https://api.github.com/repos/artem-zinnatullin/android-wail-app/pulls{/number}","milestones_url":"https://api.github.com/repos/artem-zinnatullin/android-wail-app/milestones{/number}","notifications_url":"https://api.github.com/repos/artem-zinnatullin/android-wail-app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/artem-zinnatullin/android-wail-app/labels{/name}","releases_url":"https://api.github.com/repos/artem-zinnatullin/android-wail-app/releases{/id}","created_at":"2014-07-10T21:39:03Z","updated_at":"2015-07-04T08:21:00Z","pushed_at":"2015-07-04T14:13:58Z","git_url":"git://github.com/artem-zinnatullin/android-wail-app.git","ssh_url":"git@github.com:artem-zinnatullin/android-wail-app.git","clone_url":"https://github.com/artem-zinnatullin/android-wail-app.git","svn_url":"https://github.com/artem-zinnatullin/android-wail-app","homepage":null,"size":5542,"stargazers_count":100,"watchers_count":100,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":29,"mirror_url":null,"open_issues_count":44,"forks":29,"open_issues":44,"watchers":100,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/artem-zinnatullin/android-wail-app/pulls/172"},"html":{"href":"https://github.com/artem-zinnatullin/android-wail-app/pull/172"},"issue":{"href":"https://api.github.com/repos/artem-zinnatullin/android-wail-app/issues/172"},"comments":{"href":"https://api.github.com/repos/artem-zinnatullin/android-wail-app/issues/172/comments"},"review_comments":{"href":"https://api.github.com/repos/artem-zinnatullin/android-wail-app/pulls/172/comments"},"review_comment":{"href":"https://api.github.com/repos/artem-zinnatullin/android-wail-app/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/artem-zinnatullin/android-wail-app/pulls/172/commits"},"statuses":{"href":"https://api.github.com/repos/artem-zinnatullin/android-wail-app/statuses/ec248888455ca89d63418e050ed192c7aaaca5be"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"ilya-murzinov","id":3704363,"avatar_url":"https://avatars.githubusercontent.com/u/3704363?v=3","gravatar_id":"","url":"https://api.github.com/users/ilya-murzinov","html_url":"https://github.com/ilya-murzinov","followers_url":"https://api.github.com/users/ilya-murzinov/followers","following_url":"https://api.github.com/users/ilya-murzinov/following{/other_user}","gists_url":"https://api.github.com/users/ilya-murzinov/gists{/gist_id}","starred_url":"https://api.github.com/users/ilya-murzinov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilya-murzinov/subscriptions","organizations_url":"https://api.github.com/users/ilya-murzinov/orgs","repos_url":"https://api.github.com/users/ilya-murzinov/repos","events_url":"https://api.github.com/users/ilya-murzinov/events{/privacy}","received_events_url":"https://api.github.com/users/ilya-murzinov/received_events","type":"User","site_admin":false},"comments":2,"review_comments":3,"commits":2,"additions":2,"deletions":2,"changed_files":2}}