{"action":"created","comment":{"url":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/comments/32728413","id":32728413,"diff_hunk":"@@ -1459,13 +1495,7 @@ int freerdp_client_settings_parse_command_line_arguments(rdpSettings* settings,\n \t\t}\n \t\tCommandLineSwitchCase(arg, \"u\")\n \t\t{\n-\t\t\tchar* user;\n-\t\t\tchar* domain;\n-\n-\t\t\tfreerdp_parse_username(arg->Value, &user, &domain);\n-\n-\t\t\tsettings->Username = user;\n-\t\t\tsettings->Domain = domain;\n+\t\t\tuser = _strdup(arg->Value);","path":"client/common/cmdline.c","position":114,"original_position":114,"commit_id":"e563b2b62e48d3881ef51cb96b29f4cf0fd1486a","original_commit_id":"e563b2b62e48d3881ef51cb96b29f4cf0fd1486a","user":{"login":"bmiklautz","id":195793,"avatar_url":"https://avatars.githubusercontent.com/u/195793?v=3","gravatar_id":"","url":"https://api.github.com/users/bmiklautz","html_url":"https://github.com/bmiklautz","followers_url":"https://api.github.com/users/bmiklautz/followers","following_url":"https://api.github.com/users/bmiklautz/following{/other_user}","gists_url":"https://api.github.com/users/bmiklautz/gists{/gist_id}","starred_url":"https://api.github.com/users/bmiklautz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmiklautz/subscriptions","organizations_url":"https://api.github.com/users/bmiklautz/orgs","repos_url":"https://api.github.com/users/bmiklautz/repos","events_url":"https://api.github.com/users/bmiklautz/events{/privacy}","received_events_url":"https://api.github.com/users/bmiklautz/received_events","type":"User","site_admin":false},"body":"Missing strdup check.","created_at":"2015-06-18T13:22:52Z","updated_at":"2015-06-18T13:22:52Z","html_url":"https://github.com/FreeRDP/FreeRDP/pull/2701#discussion_r32728413","pull_request_url":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/2701","_links":{"self":{"href":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/comments/32728413"},"html":{"href":"https://github.com/FreeRDP/FreeRDP/pull/2701#discussion_r32728413"},"pull_request":{"href":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/2701"}}},"pull_request":{"url":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/2701","id":37665727,"html_url":"https://github.com/FreeRDP/FreeRDP/pull/2701","diff_url":"https://github.com/FreeRDP/FreeRDP/pull/2701.diff","patch_url":"https://github.com/FreeRDP/FreeRDP/pull/2701.patch","issue_url":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/2701","number":2701,"state":"open","locked":false,"title":"Allowing UPN syntax for user argument.","user":{"login":"akallabeth","id":3472254,"avatar_url":"https://avatars.githubusercontent.com/u/3472254?v=3","gravatar_id":"","url":"https://api.github.com/users/akallabeth","html_url":"https://github.com/akallabeth","followers_url":"https://api.github.com/users/akallabeth/followers","following_url":"https://api.github.com/users/akallabeth/following{/other_user}","gists_url":"https://api.github.com/users/akallabeth/gists{/gist_id}","starred_url":"https://api.github.com/users/akallabeth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akallabeth/subscriptions","organizations_url":"https://api.github.com/users/akallabeth/orgs","repos_url":"https://api.github.com/users/akallabeth/repos","events_url":"https://api.github.com/users/akallabeth/events{/privacy}","received_events_url":"https://api.github.com/users/akallabeth/received_events","type":"User","site_admin":false},"body":"* Fixed issues with authentication:\r\n* If ```user@domain``` syntax is used, the domain is set to an empty string instead of ```NULL``` and user to the full string\r\n* If only ```user``` is given, set domain to ```TARGET``` (similar to ```CredUIParseUserName```)\r\n* If ```domain\\user``` syntax is used, split the string.","created_at":"2015-06-15T07:48:15Z","updated_at":"2015-06-18T13:22:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"179553d4731115b34e14e490a83c2e3c8461d25d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/2701/commits","review_comments_url":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/2701/comments","review_comment_url":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/2701/comments","statuses_url":"https://api.github.com/repos/FreeRDP/FreeRDP/statuses/e563b2b62e48d3881ef51cb96b29f4cf0fd1486a","head":{"label":"akallabeth:upn_syntax_support","ref":"upn_syntax_support","sha":"e563b2b62e48d3881ef51cb96b29f4cf0fd1486a","user":{"login":"akallabeth","id":3472254,"avatar_url":"https://avatars.githubusercontent.com/u/3472254?v=3","gravatar_id":"","url":"https://api.github.com/users/akallabeth","html_url":"https://github.com/akallabeth","followers_url":"https://api.github.com/users/akallabeth/followers","following_url":"https://api.github.com/users/akallabeth/following{/other_user}","gists_url":"https://api.github.com/users/akallabeth/gists{/gist_id}","starred_url":"https://api.github.com/users/akallabeth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akallabeth/subscriptions","organizations_url":"https://api.github.com/users/akallabeth/orgs","repos_url":"https://api.github.com/users/akallabeth/repos","events_url":"https://api.github.com/users/akallabeth/events{/privacy}","received_events_url":"https://api.github.com/users/akallabeth/received_events","type":"User","site_admin":false},"repo":{"id":11418147,"name":"FreeRDP","full_name":"akallabeth/FreeRDP","owner":{"login":"akallabeth","id":3472254,"avatar_url":"https://avatars.githubusercontent.com/u/3472254?v=3","gravatar_id":"","url":"https://api.github.com/users/akallabeth","html_url":"https://github.com/akallabeth","followers_url":"https://api.github.com/users/akallabeth/followers","following_url":"https://api.github.com/users/akallabeth/following{/other_user}","gists_url":"https://api.github.com/users/akallabeth/gists{/gist_id}","starred_url":"https://api.github.com/users/akallabeth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akallabeth/subscriptions","organizations_url":"https://api.github.com/users/akallabeth/orgs","repos_url":"https://api.github.com/users/akallabeth/repos","events_url":"https://api.github.com/users/akallabeth/events{/privacy}","received_events_url":"https://api.github.com/users/akallabeth/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/akallabeth/FreeRDP","description":"FreeRDP is a free remote desktop protocol client","fork":true,"url":"https://api.github.com/repos/akallabeth/FreeRDP","forks_url":"https://api.github.com/repos/akallabeth/FreeRDP/forks","keys_url":"https://api.github.com/repos/akallabeth/FreeRDP/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akallabeth/FreeRDP/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akallabeth/FreeRDP/teams","hooks_url":"https://api.github.com/repos/akallabeth/FreeRDP/hooks","issue_events_url":"https://api.github.com/repos/akallabeth/FreeRDP/issues/events{/number}","events_url":"https://api.github.com/repos/akallabeth/FreeRDP/events","assignees_url":"https://api.github.com/repos/akallabeth/FreeRDP/assignees{/user}","branches_url":"https://api.github.com/repos/akallabeth/FreeRDP/branches{/branch}","tags_url":"https://api.github.com/repos/akallabeth/FreeRDP/tags","blobs_url":"https://api.github.com/repos/akallabeth/FreeRDP/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akallabeth/FreeRDP/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akallabeth/FreeRDP/git/refs{/sha}","trees_url":"https://api.github.com/repos/akallabeth/FreeRDP/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akallabeth/FreeRDP/statuses/{sha}","languages_url":"https://api.github.com/repos/akallabeth/FreeRDP/languages","stargazers_url":"https://api.github.com/repos/akallabeth/FreeRDP/stargazers","contributors_url":"https://api.github.com/repos/akallabeth/FreeRDP/contributors","subscribers_url":"https://api.github.com/repos/akallabeth/FreeRDP/subscribers","subscription_url":"https://api.github.com/repos/akallabeth/FreeRDP/subscription","commits_url":"https://api.github.com/repos/akallabeth/FreeRDP/commits{/sha}","git_commits_url":"https://api.github.com/repos/akallabeth/FreeRDP/git/commits{/sha}","comments_url":"https://api.github.com/repos/akallabeth/FreeRDP/comments{/number}","issue_comment_url":"https://api.github.com/repos/akallabeth/FreeRDP/issues/comments{/number}","contents_url":"https://api.github.com/repos/akallabeth/FreeRDP/contents/{+path}","compare_url":"https://api.github.com/repos/akallabeth/FreeRDP/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akallabeth/FreeRDP/merges","archive_url":"https://api.github.com/repos/akallabeth/FreeRDP/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akallabeth/FreeRDP/downloads","issues_url":"https://api.github.com/repos/akallabeth/FreeRDP/issues{/number}","pulls_url":"https://api.github.com/repos/akallabeth/FreeRDP/pulls{/number}","milestones_url":"https://api.github.com/repos/akallabeth/FreeRDP/milestones{/number}","notifications_url":"https://api.github.com/repos/akallabeth/FreeRDP/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akallabeth/FreeRDP/labels{/name}","releases_url":"https://api.github.com/repos/akallabeth/FreeRDP/releases{/id}","created_at":"2013-07-15T08:16:31Z","updated_at":"2015-01-26T06:50:05Z","pushed_at":"2015-06-18T11:01:42Z","git_url":"git://github.com/akallabeth/FreeRDP.git","ssh_url":"git@github.com:akallabeth/FreeRDP.git","clone_url":"https://github.com/akallabeth/FreeRDP.git","svn_url":"https://github.com/akallabeth/FreeRDP","homepage":"http://www.freerdp.com/","size":31632,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"FreeRDP:master","ref":"master","sha":"145fc104121e7a723893d5983d4d15e9613d69e9","user":{"login":"FreeRDP","id":663376,"avatar_url":"https://avatars.githubusercontent.com/u/663376?v=3","gravatar_id":"","url":"https://api.github.com/users/FreeRDP","html_url":"https://github.com/FreeRDP","followers_url":"https://api.github.com/users/FreeRDP/followers","following_url":"https://api.github.com/users/FreeRDP/following{/other_user}","gists_url":"https://api.github.com/users/FreeRDP/gists{/gist_id}","starred_url":"https://api.github.com/users/FreeRDP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FreeRDP/subscriptions","organizations_url":"https://api.github.com/users/FreeRDP/orgs","repos_url":"https://api.github.com/users/FreeRDP/repos","events_url":"https://api.github.com/users/FreeRDP/events{/privacy}","received_events_url":"https://api.github.com/users/FreeRDP/received_events","type":"Organization","site_admin":false},"repo":{"id":1979797,"name":"FreeRDP","full_name":"FreeRDP/FreeRDP","owner":{"login":"FreeRDP","id":663376,"avatar_url":"https://avatars.githubusercontent.com/u/663376?v=3","gravatar_id":"","url":"https://api.github.com/users/FreeRDP","html_url":"https://github.com/FreeRDP","followers_url":"https://api.github.com/users/FreeRDP/followers","following_url":"https://api.github.com/users/FreeRDP/following{/other_user}","gists_url":"https://api.github.com/users/FreeRDP/gists{/gist_id}","starred_url":"https://api.github.com/users/FreeRDP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FreeRDP/subscriptions","organizations_url":"https://api.github.com/users/FreeRDP/orgs","repos_url":"https://api.github.com/users/FreeRDP/repos","events_url":"https://api.github.com/users/FreeRDP/events{/privacy}","received_events_url":"https://api.github.com/users/FreeRDP/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FreeRDP/FreeRDP","description":"FreeRDP is a free remote desktop protocol client","fork":false,"url":"https://api.github.com/repos/FreeRDP/FreeRDP","forks_url":"https://api.github.com/repos/FreeRDP/FreeRDP/forks","keys_url":"https://api.github.com/repos/FreeRDP/FreeRDP/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FreeRDP/FreeRDP/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FreeRDP/FreeRDP/teams","hooks_url":"https://api.github.com/repos/FreeRDP/FreeRDP/hooks","issue_events_url":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/events{/number}","events_url":"https://api.github.com/repos/FreeRDP/FreeRDP/events","assignees_url":"https://api.github.com/repos/FreeRDP/FreeRDP/assignees{/user}","branches_url":"https://api.github.com/repos/FreeRDP/FreeRDP/branches{/branch}","tags_url":"https://api.github.com/repos/FreeRDP/FreeRDP/tags","blobs_url":"https://api.github.com/repos/FreeRDP/FreeRDP/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FreeRDP/FreeRDP/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FreeRDP/FreeRDP/git/refs{/sha}","trees_url":"https://api.github.com/repos/FreeRDP/FreeRDP/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FreeRDP/FreeRDP/statuses/{sha}","languages_url":"https://api.github.com/repos/FreeRDP/FreeRDP/languages","stargazers_url":"https://api.github.com/repos/FreeRDP/FreeRDP/stargazers","contributors_url":"https://api.github.com/repos/FreeRDP/FreeRDP/contributors","subscribers_url":"https://api.github.com/repos/FreeRDP/FreeRDP/subscribers","subscription_url":"https://api.github.com/repos/FreeRDP/FreeRDP/subscription","commits_url":"https://api.github.com/repos/FreeRDP/FreeRDP/commits{/sha}","git_commits_url":"https://api.github.com/repos/FreeRDP/FreeRDP/git/commits{/sha}","comments_url":"https://api.github.com/repos/FreeRDP/FreeRDP/comments{/number}","issue_comment_url":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/comments{/number}","contents_url":"https://api.github.com/repos/FreeRDP/FreeRDP/contents/{+path}","compare_url":"https://api.github.com/repos/FreeRDP/FreeRDP/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FreeRDP/FreeRDP/merges","archive_url":"https://api.github.com/repos/FreeRDP/FreeRDP/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FreeRDP/FreeRDP/downloads","issues_url":"https://api.github.com/repos/FreeRDP/FreeRDP/issues{/number}","pulls_url":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls{/number}","milestones_url":"https://api.github.com/repos/FreeRDP/FreeRDP/milestones{/number}","notifications_url":"https://api.github.com/repos/FreeRDP/FreeRDP/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FreeRDP/FreeRDP/labels{/name}","releases_url":"https://api.github.com/repos/FreeRDP/FreeRDP/releases{/id}","created_at":"2011-06-30T19:14:15Z","updated_at":"2015-06-18T06:16:39Z","pushed_at":"2015-06-18T12:37:18Z","git_url":"git://github.com/FreeRDP/FreeRDP.git","ssh_url":"git@github.com:FreeRDP/FreeRDP.git","clone_url":"https://github.com/FreeRDP/FreeRDP.git","svn_url":"https://github.com/FreeRDP/FreeRDP","homepage":"http://www.freerdp.com/","size":120099,"stargazers_count":983,"watchers_count":983,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":641,"mirror_url":null,"open_issues_count":559,"forks":641,"open_issues":559,"watchers":983,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/2701"},"html":{"href":"https://github.com/FreeRDP/FreeRDP/pull/2701"},"issue":{"href":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/2701"},"comments":{"href":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/2701/comments"},"review_comments":{"href":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/2701/comments"},"review_comment":{"href":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/2701/commits"},"statuses":{"href":"https://api.github.com/repos/FreeRDP/FreeRDP/statuses/e563b2b62e48d3881ef51cb96b29f4cf0fd1486a"}}}}