{"action":"created","issue":{"url":"https://api.github.com/repos/ionrock/cachecontrol/issues/51","labels_url":"https://api.github.com/repos/ionrock/cachecontrol/issues/51/labels{/name}","comments_url":"https://api.github.com/repos/ionrock/cachecontrol/issues/51/comments","events_url":"https://api.github.com/repos/ionrock/cachecontrol/issues/51/events","html_url":"https://github.com/ionrock/cachecontrol/issues/51","id":53616079,"number":51,"title":"BaseHeuristic.warning is insufficiently flexible to implement HTTP caching spec properly","user":{"login":"ssokolow","id":46915,"avatar_url":"https://avatars.githubusercontent.com/u/46915?v=3","gravatar_id":"","url":"https://api.github.com/users/ssokolow","html_url":"https://github.com/ssokolow","followers_url":"https://api.github.com/users/ssokolow/followers","following_url":"https://api.github.com/users/ssokolow/following{/other_user}","gists_url":"https://api.github.com/users/ssokolow/gists{/gist_id}","starred_url":"https://api.github.com/users/ssokolow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssokolow/subscriptions","organizations_url":"https://api.github.com/users/ssokolow/orgs","repos_url":"https://api.github.com/users/ssokolow/repos","events_url":"https://api.github.com/users/ssokolow/events{/privacy}","received_events_url":"https://api.github.com/users/ssokolow/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-01-07T10:03:46Z","updated_at":"2015-01-07T17:14:47Z","closed_at":null,"body":"According to the spec, you're supposed to return [warning 113](http://tools.ietf.org/html/rfc7234#section-5.5.4) if your cache has intentionally served up something more than 24 hours stale. However, you neglected to expose the response's information to `warning` so I can check how old the response is.\r\n\r\nAs is, I'm probably going to wind up overriding `BaseHeuristic.apply` instead, which grates on me since the docs say nothing about its API stability."},"comment":{"url":"https://api.github.com/repos/ionrock/cachecontrol/issues/comments/69055416","html_url":"https://github.com/ionrock/cachecontrol/issues/51#issuecomment-69055416","issue_url":"https://api.github.com/repos/ionrock/cachecontrol/issues/51","id":69055416,"user":{"login":"ssokolow","id":46915,"avatar_url":"https://avatars.githubusercontent.com/u/46915?v=3","gravatar_id":"","url":"https://api.github.com/users/ssokolow","html_url":"https://github.com/ssokolow","followers_url":"https://api.github.com/users/ssokolow/followers","following_url":"https://api.github.com/users/ssokolow/following{/other_user}","gists_url":"https://api.github.com/users/ssokolow/gists{/gist_id}","starred_url":"https://api.github.com/users/ssokolow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssokolow/subscriptions","organizations_url":"https://api.github.com/users/ssokolow/orgs","repos_url":"https://api.github.com/users/ssokolow/repos","events_url":"https://api.github.com/users/ssokolow/events{/privacy}","received_events_url":"https://api.github.com/users/ssokolow/received_events","type":"User","site_admin":false},"created_at":"2015-01-07T17:14:46Z","updated_at":"2015-01-07T17:14:46Z","body":"In that case, I'm very glad I decided to rework this project now. Having the heuristics API, as immature as it is, will allow me to greatly simplify things."}}