{"action":"closed","number":2,"pull_request":{"url":"https://api.github.com/repos/RustAudio/synth/pulls/2","id":29156789,"html_url":"https://github.com/RustAudio/synth/pull/2","diff_url":"https://github.com/RustAudio/synth/pull/2.diff","patch_url":"https://github.com/RustAudio/synth/pull/2.patch","issue_url":"https://api.github.com/repos/RustAudio/synth/issues/2","number":2,"state":"closed","locked":false,"title":"Improved Synth construction API, fixed multiple waveform errors and \"warbliness\" effect.","user":{"login":"mitchmindtree","id":4587373,"avatar_url":"https://avatars.githubusercontent.com/u/4587373?v=3","gravatar_id":"","url":"https://api.github.com/users/mitchmindtree","html_url":"https://github.com/mitchmindtree","followers_url":"https://api.github.com/users/mitchmindtree/followers","following_url":"https://api.github.com/users/mitchmindtree/following{/other_user}","gists_url":"https://api.github.com/users/mitchmindtree/gists{/gist_id}","starred_url":"https://api.github.com/users/mitchmindtree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitchmindtree/subscriptions","organizations_url":"https://api.github.com/users/mitchmindtree/orgs","repos_url":"https://api.github.com/users/mitchmindtree/repos","events_url":"https://api.github.com/users/mitchmindtree/events{/privacy}","received_events_url":"https://api.github.com/users/mitchmindtree/received_events","type":"User","site_admin":false},"body":"- Synth now uses builder methods for construction.\r\n- Fixed warbliness effect by applying gaussian randomness to the pitch in the form of mels rather than hz.\r\n- Removed unnecessary next_phase fn\r\n- Fixed incorrect Square waveform.\r\n- Tweaked noisewalk frequency enveloping.\r\n- Added pause, unpause and stop methods to Synth.\r\n\r\nNOTE: travis may still be broken as code is slightly ahead of nightlies.","created_at":"2015-02-12T06:56:51Z","updated_at":"2015-02-12T06:58:27Z","closed_at":"2015-02-12T06:58:27Z","merged_at":"2015-02-12T06:58:27Z","merge_commit_sha":"b93f62ae1594d4956335c939cfb24c641ec19f64","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/RustAudio/synth/pulls/2/commits","review_comments_url":"https://api.github.com/repos/RustAudio/synth/pulls/2/comments","review_comment_url":"https://api.github.com/repos/RustAudio/synth/pulls/comments/{number}","comments_url":"https://api.github.com/repos/RustAudio/synth/issues/2/comments","statuses_url":"https://api.github.com/repos/RustAudio/synth/statuses/c98e6b2937ffe1108720e50a5bbffbd0503b879b","head":{"label":"mitchmindtree:master","ref":"master","sha":"c98e6b2937ffe1108720e50a5bbffbd0503b879b","user":{"login":"mitchmindtree","id":4587373,"avatar_url":"https://avatars.githubusercontent.com/u/4587373?v=3","gravatar_id":"","url":"https://api.github.com/users/mitchmindtree","html_url":"https://github.com/mitchmindtree","followers_url":"https://api.github.com/users/mitchmindtree/followers","following_url":"https://api.github.com/users/mitchmindtree/following{/other_user}","gists_url":"https://api.github.com/users/mitchmindtree/gists{/gist_id}","starred_url":"https://api.github.com/users/mitchmindtree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitchmindtree/subscriptions","organizations_url":"https://api.github.com/users/mitchmindtree/orgs","repos_url":"https://api.github.com/users/mitchmindtree/repos","events_url":"https://api.github.com/users/mitchmindtree/events{/privacy}","received_events_url":"https://api.github.com/users/mitchmindtree/received_events","type":"User","site_admin":false},"repo":{"id":30650816,"name":"synth","full_name":"mitchmindtree/synth","owner":{"login":"mitchmindtree","id":4587373,"avatar_url":"https://avatars.githubusercontent.com/u/4587373?v=3","gravatar_id":"","url":"https://api.github.com/users/mitchmindtree","html_url":"https://github.com/mitchmindtree","followers_url":"https://api.github.com/users/mitchmindtree/followers","following_url":"https://api.github.com/users/mitchmindtree/following{/other_user}","gists_url":"https://api.github.com/users/mitchmindtree/gists{/gist_id}","starred_url":"https://api.github.com/users/mitchmindtree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitchmindtree/subscriptions","organizations_url":"https://api.github.com/users/mitchmindtree/orgs","repos_url":"https://api.github.com/users/mitchmindtree/repos","events_url":"https://api.github.com/users/mitchmindtree/events{/privacy}","received_events_url":"https://api.github.com/users/mitchmindtree/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mitchmindtree/synth","description":"A polyphonic Synth type whose multiple oscillators generate sound via amplitude and frequency envelopes, implemented in Rust.","fork":true,"url":"https://api.github.com/repos/mitchmindtree/synth","forks_url":"https://api.github.com/repos/mitchmindtree/synth/forks","keys_url":"https://api.github.com/repos/mitchmindtree/synth/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mitchmindtree/synth/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mitchmindtree/synth/teams","hooks_url":"https://api.github.com/repos/mitchmindtree/synth/hooks","issue_events_url":"https://api.github.com/repos/mitchmindtree/synth/issues/events{/number}","events_url":"https://api.github.com/repos/mitchmindtree/synth/events","assignees_url":"https://api.github.com/repos/mitchmindtree/synth/assignees{/user}","branches_url":"https://api.github.com/repos/mitchmindtree/synth/branches{/branch}","tags_url":"https://api.github.com/repos/mitchmindtree/synth/tags","blobs_url":"https://api.github.com/repos/mitchmindtree/synth/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mitchmindtree/synth/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mitchmindtree/synth/git/refs{/sha}","trees_url":"https://api.github.com/repos/mitchmindtree/synth/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mitchmindtree/synth/statuses/{sha}","languages_url":"https://api.github.com/repos/mitchmindtree/synth/languages","stargazers_url":"https://api.github.com/repos/mitchmindtree/synth/stargazers","contributors_url":"https://api.github.com/repos/mitchmindtree/synth/contributors","subscribers_url":"https://api.github.com/repos/mitchmindtree/synth/subscribers","subscription_url":"https://api.github.com/repos/mitchmindtree/synth/subscription","commits_url":"https://api.github.com/repos/mitchmindtree/synth/commits{/sha}","git_commits_url":"https://api.github.com/repos/mitchmindtree/synth/git/commits{/sha}","comments_url":"https://api.github.com/repos/mitchmindtree/synth/comments{/number}","issue_comment_url":"https://api.github.com/repos/mitchmindtree/synth/issues/comments/{number}","contents_url":"https://api.github.com/repos/mitchmindtree/synth/contents/{+path}","compare_url":"https://api.github.com/repos/mitchmindtree/synth/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mitchmindtree/synth/merges","archive_url":"https://api.github.com/repos/mitchmindtree/synth/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mitchmindtree/synth/downloads","issues_url":"https://api.github.com/repos/mitchmindtree/synth/issues{/number}","pulls_url":"https://api.github.com/repos/mitchmindtree/synth/pulls{/number}","milestones_url":"https://api.github.com/repos/mitchmindtree/synth/milestones{/number}","notifications_url":"https://api.github.com/repos/mitchmindtree/synth/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mitchmindtree/synth/labels{/name}","releases_url":"https://api.github.com/repos/mitchmindtree/synth/releases{/id}","created_at":"2015-02-11T14:13:40Z","updated_at":"2015-02-12T06:50:17Z","pushed_at":"2015-02-12T06:50:17Z","git_url":"git://github.com/mitchmindtree/synth.git","ssh_url":"git@github.com:mitchmindtree/synth.git","clone_url":"https://github.com/mitchmindtree/synth.git","svn_url":"https://github.com/mitchmindtree/synth","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"RustAudio:master","ref":"master","sha":"752641cce92eed0d777cacb3d9d8cd8ed0bb76b5","user":{"login":"RustAudio","id":9999738,"avatar_url":"https://avatars.githubusercontent.com/u/9999738?v=3","gravatar_id":"","url":"https://api.github.com/users/RustAudio","html_url":"https://github.com/RustAudio","followers_url":"https://api.github.com/users/RustAudio/followers","following_url":"https://api.github.com/users/RustAudio/following{/other_user}","gists_url":"https://api.github.com/users/RustAudio/gists{/gist_id}","starred_url":"https://api.github.com/users/RustAudio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RustAudio/subscriptions","organizations_url":"https://api.github.com/users/RustAudio/orgs","repos_url":"https://api.github.com/users/RustAudio/repos","events_url":"https://api.github.com/users/RustAudio/events{/privacy}","received_events_url":"https://api.github.com/users/RustAudio/received_events","type":"Organization","site_admin":false},"repo":{"id":30650453,"name":"synth","full_name":"RustAudio/synth","owner":{"login":"RustAudio","id":9999738,"avatar_url":"https://avatars.githubusercontent.com/u/9999738?v=3","gravatar_id":"","url":"https://api.github.com/users/RustAudio","html_url":"https://github.com/RustAudio","followers_url":"https://api.github.com/users/RustAudio/followers","following_url":"https://api.github.com/users/RustAudio/following{/other_user}","gists_url":"https://api.github.com/users/RustAudio/gists{/gist_id}","starred_url":"https://api.github.com/users/RustAudio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RustAudio/subscriptions","organizations_url":"https://api.github.com/users/RustAudio/orgs","repos_url":"https://api.github.com/users/RustAudio/repos","events_url":"https://api.github.com/users/RustAudio/events{/privacy}","received_events_url":"https://api.github.com/users/RustAudio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RustAudio/synth","description":"A polyphonic Synth type whose multiple oscillators generate sound via amplitude and frequency envelopes, implemented in Rust.","fork":false,"url":"https://api.github.com/repos/RustAudio/synth","forks_url":"https://api.github.com/repos/RustAudio/synth/forks","keys_url":"https://api.github.com/repos/RustAudio/synth/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RustAudio/synth/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RustAudio/synth/teams","hooks_url":"https://api.github.com/repos/RustAudio/synth/hooks","issue_events_url":"https://api.github.com/repos/RustAudio/synth/issues/events{/number}","events_url":"https://api.github.com/repos/RustAudio/synth/events","assignees_url":"https://api.github.com/repos/RustAudio/synth/assignees{/user}","branches_url":"https://api.github.com/repos/RustAudio/synth/branches{/branch}","tags_url":"https://api.github.com/repos/RustAudio/synth/tags","blobs_url":"https://api.github.com/repos/RustAudio/synth/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RustAudio/synth/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RustAudio/synth/git/refs{/sha}","trees_url":"https://api.github.com/repos/RustAudio/synth/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RustAudio/synth/statuses/{sha}","languages_url":"https://api.github.com/repos/RustAudio/synth/languages","stargazers_url":"https://api.github.com/repos/RustAudio/synth/stargazers","contributors_url":"https://api.github.com/repos/RustAudio/synth/contributors","subscribers_url":"https://api.github.com/repos/RustAudio/synth/subscribers","subscription_url":"https://api.github.com/repos/RustAudio/synth/subscription","commits_url":"https://api.github.com/repos/RustAudio/synth/commits{/sha}","git_commits_url":"https://api.github.com/repos/RustAudio/synth/git/commits{/sha}","comments_url":"https://api.github.com/repos/RustAudio/synth/comments{/number}","issue_comment_url":"https://api.github.com/repos/RustAudio/synth/issues/comments/{number}","contents_url":"https://api.github.com/repos/RustAudio/synth/contents/{+path}","compare_url":"https://api.github.com/repos/RustAudio/synth/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RustAudio/synth/merges","archive_url":"https://api.github.com/repos/RustAudio/synth/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RustAudio/synth/downloads","issues_url":"https://api.github.com/repos/RustAudio/synth/issues{/number}","pulls_url":"https://api.github.com/repos/RustAudio/synth/pulls{/number}","milestones_url":"https://api.github.com/repos/RustAudio/synth/milestones{/number}","notifications_url":"https://api.github.com/repos/RustAudio/synth/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RustAudio/synth/labels{/name}","releases_url":"https://api.github.com/repos/RustAudio/synth/releases{/id}","created_at":"2015-02-11T14:05:54Z","updated_at":"2015-02-11T14:24:27Z","pushed_at":"2015-02-12T06:58:27Z","git_url":"git://github.com/RustAudio/synth.git","ssh_url":"git@github.com:RustAudio/synth.git","clone_url":"https://github.com/RustAudio/synth.git","svn_url":"https://github.com/RustAudio/synth","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RustAudio/synth/pulls/2"},"html":{"href":"https://github.com/RustAudio/synth/pull/2"},"issue":{"href":"https://api.github.com/repos/RustAudio/synth/issues/2"},"comments":{"href":"https://api.github.com/repos/RustAudio/synth/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/RustAudio/synth/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/RustAudio/synth/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/RustAudio/synth/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/RustAudio/synth/statuses/c98e6b2937ffe1108720e50a5bbffbd0503b879b"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"mitchmindtree","id":4587373,"avatar_url":"https://avatars.githubusercontent.com/u/4587373?v=3","gravatar_id":"","url":"https://api.github.com/users/mitchmindtree","html_url":"https://github.com/mitchmindtree","followers_url":"https://api.github.com/users/mitchmindtree/followers","following_url":"https://api.github.com/users/mitchmindtree/following{/other_user}","gists_url":"https://api.github.com/users/mitchmindtree/gists{/gist_id}","starred_url":"https://api.github.com/users/mitchmindtree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitchmindtree/subscriptions","organizations_url":"https://api.github.com/users/mitchmindtree/orgs","repos_url":"https://api.github.com/users/mitchmindtree/repos","events_url":"https://api.github.com/users/mitchmindtree/events{/privacy}","received_events_url":"https://api.github.com/users/mitchmindtree/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":2,"additions":206,"deletions":230,"changed_files":4}}