{"action":"created","issue":{"url":"https://api.github.com/repos/jbenet/go-ipfs/issues/676","labels_url":"https://api.github.com/repos/jbenet/go-ipfs/issues/676/labels{/name}","comments_url":"https://api.github.com/repos/jbenet/go-ipfs/issues/676/comments","events_url":"https://api.github.com/repos/jbenet/go-ipfs/issues/676/events","html_url":"https://github.com/jbenet/go-ipfs/pull/676","id":55594121,"number":676,"title":"p2p/net: dial log -> events","user":{"login":"jbenet","id":138401,"avatar_url":"https://avatars.githubusercontent.com/u/138401?v=3","gravatar_id":"","url":"https://api.github.com/users/jbenet","html_url":"https://github.com/jbenet","followers_url":"https://api.github.com/users/jbenet/followers","following_url":"https://api.github.com/users/jbenet/following{/other_user}","gists_url":"https://api.github.com/users/jbenet/gists{/gist_id}","starred_url":"https://api.github.com/users/jbenet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbenet/subscriptions","organizations_url":"https://api.github.com/users/jbenet/orgs","repos_url":"https://api.github.com/users/jbenet/repos","events_url":"https://api.github.com/users/jbenet/events{/privacy}","received_events_url":"https://api.github.com/users/jbenet/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/jbenet/go-ipfs/labels/in%20progress","name":"in progress","color":"ededed"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/jbenet/go-ipfs/milestones/1","labels_url":"https://api.github.com/repos/jbenet/go-ipfs/milestones/1/labels","id":800719,"number":1,"title":"α","description":"","creator":{"login":"briantigerchow","id":734339,"avatar_url":"https://avatars.githubusercontent.com/u/734339?v=3","gravatar_id":"","url":"https://api.github.com/users/briantigerchow","html_url":"https://github.com/briantigerchow","followers_url":"https://api.github.com/users/briantigerchow/followers","following_url":"https://api.github.com/users/briantigerchow/following{/other_user}","gists_url":"https://api.github.com/users/briantigerchow/gists{/gist_id}","starred_url":"https://api.github.com/users/briantigerchow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/briantigerchow/subscriptions","organizations_url":"https://api.github.com/users/briantigerchow/orgs","repos_url":"https://api.github.com/users/briantigerchow/repos","events_url":"https://api.github.com/users/briantigerchow/events{/privacy}","received_events_url":"https://api.github.com/users/briantigerchow/received_events","type":"User","site_admin":false},"open_issues":30,"closed_issues":48,"state":"open","created_at":"2014-09-24T06:57:49Z","updated_at":"2015-01-27T09:28:14Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2015-01-27T09:27:18Z","updated_at":"2015-01-27T09:43:55Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jbenet/go-ipfs/pulls/676","html_url":"https://github.com/jbenet/go-ipfs/pull/676","diff_url":"https://github.com/jbenet/go-ipfs/pull/676.diff","patch_url":"https://github.com/jbenet/go-ipfs/pull/676.patch"},"body":"This commit turns all dial logs into log.Events.\r\n\r\nEverything's great except for one problem: The LoggableMap I'm using does not\r\nprint out things correctly. I gave it peer.IDs, and Multiaddrs and both got\r\nlogged as nothing `{}` (didn't even call their String() methods!) So, for now,\r\nthis function encodes it when called... This is wrong and should be fixed\r\nbefore being merged in. Otherwise we  will be constantly encoding peer.IDs and\r\nMultiaddrs without needing to.\r\n\r\n@briantigerchow how do you suggest doing this? I don't know my way around your\r\nLoggable things."},"comment":{"url":"https://api.github.com/repos/jbenet/go-ipfs/issues/comments/71617226","html_url":"https://github.com/jbenet/go-ipfs/pull/676#issuecomment-71617226","issue_url":"https://api.github.com/repos/jbenet/go-ipfs/issues/676","id":71617226,"user":{"login":"jbenet","id":138401,"avatar_url":"https://avatars.githubusercontent.com/u/138401?v=3","gravatar_id":"","url":"https://api.github.com/users/jbenet","html_url":"https://github.com/jbenet","followers_url":"https://api.github.com/users/jbenet/followers","following_url":"https://api.github.com/users/jbenet/following{/other_user}","gists_url":"https://api.github.com/users/jbenet/gists{/gist_id}","starred_url":"https://api.github.com/users/jbenet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbenet/subscriptions","organizations_url":"https://api.github.com/users/jbenet/orgs","repos_url":"https://api.github.com/users/jbenet/repos","events_url":"https://api.github.com/users/jbenet/events{/privacy}","received_events_url":"https://api.github.com/users/jbenet/received_events","type":"User","site_admin":false},"created_at":"2015-01-27T09:43:55Z","updated_at":"2015-01-27T09:43:55Z","body":"Aaaaand this way of doing it causes races. so has to be done another way. This is basically what i _want_ to do. @briantigerchow how should I do it right?"}}