{"action":"created","comment":{"url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/DiscoveryEnvironmentBackend/pulls/comments/41423722","id":41423722,"diff_hunk":"@@ -30,8 +28,8 @@\n \n (defn- authorization-redirect\n   [server-info username state-info]\n-  (throw+ {:error_code ce/ERR_TEMPORARILY_MOVED\n-           :location   (authorization-uri server-info username state-info)}))\n+  (throw+ {:type       :clojure-commons.exception/temporary-redirect\n+           :location (authorization-uri server-info username state-info)}))","path":"services/metadactyl-clj/src/metadactyl/service/apps.clj","position":23,"original_position":23,"commit_id":"99d21ed83109bf7e660846b540be5ada2b29a740","original_commit_id":"99d21ed83109bf7e660846b540be5ada2b29a740","user":{"login":"strootman","id":1720162,"avatar_url":"https://avatars.githubusercontent.com/u/1720162?v=3","gravatar_id":"","url":"https://api.github.com/users/strootman","html_url":"https://github.com/strootman","followers_url":"https://api.github.com/users/strootman/followers","following_url":"https://api.github.com/users/strootman/following{/other_user}","gists_url":"https://api.github.com/users/strootman/gists{/gist_id}","starred_url":"https://api.github.com/users/strootman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strootman/subscriptions","organizations_url":"https://api.github.com/users/strootman/orgs","repos_url":"https://api.github.com/users/strootman/repos","events_url":"https://api.github.com/users/strootman/events{/privacy}","received_events_url":"https://api.github.com/users/strootman/received_events","type":"User","site_admin":false},"body":"The correction will go in.","created_at":"2015-10-07T18:01:20Z","updated_at":"2015-10-07T18:01:20Z","html_url":"https://github.com/iPlantCollaborativeOpenSource/DiscoveryEnvironmentBackend/pull/20#discussion_r41423722","pull_request_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/DiscoveryEnvironmentBackend/pulls/20","_links":{"self":{"href":"https://api.github.com/repos/iPlantCollaborativeOpenSource/DiscoveryEnvironmentBackend/pulls/comments/41423722"},"html":{"href":"https://github.com/iPlantCollaborativeOpenSource/DiscoveryEnvironmentBackend/pull/20#discussion_r41423722"},"pull_request":{"href":"https://api.github.com/repos/iPlantCollaborativeOpenSource/DiscoveryEnvironmentBackend/pulls/20"}}},"pull_request":{"url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/DiscoveryEnvironmentBackend/pulls/20","id":47050672,"html_url":"https://github.com/iPlantCollaborativeOpenSource/DiscoveryEnvironmentBackend/pull/20","diff_url":"https://github.com/iPlantCollaborativeOpenSource/DiscoveryEnvironmentBackend/pull/20.diff","patch_url":"https://github.com/iPlantCollaborativeOpenSource/DiscoveryEnvironmentBackend/pull/20.patch","issue_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/DiscoveryEnvironmentBackend/issues/20","number":20,"state":"open","locked":false,"title":"Core 7112,7113 Update metadactyl Access logging and exception handling","user":{"login":"strootman","id":1720162,"avatar_url":"https://avatars.githubusercontent.com/u/1720162?v=3","gravatar_id":"","url":"https://api.github.com/users/strootman","html_url":"https://github.com/strootman","followers_url":"https://api.github.com/users/strootman/followers","following_url":"https://api.github.com/users/strootman/following{/other_user}","gists_url":"https://api.github.com/users/strootman/gists{/gist_id}","starred_url":"https://api.github.com/users/strootman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strootman/subscriptions","organizations_url":"https://api.github.com/users/strootman/orgs","repos_url":"https://api.github.com/users/strootman/repos","events_url":"https://api.github.com/users/strootman/events{/privacy}","received_events_url":"https://api.github.com/users/strootman/received_events","type":"User","site_admin":false},"body":"This PR contains the updates for metadactyl's Access logging and exception handling.\r\n\r\nSome of the changes that have been made here still need to be propagated back into Donkey. I'd like those changes to be part of this PR, but I do not want to commit them until the first batch of metadactyl-only changes have been settled on.\r\n\r\nAll exceptions are now thrown as a map containing [:type, :error, and\r\noptional keys]. The optional keys are placed into the exception response\r\nautomatically (not nested in a \":fields\" key).\r\n\r\nRoutes are the only functions which should return success responses.\r\nAll non-route functions have been cleansed of returning any kind of Ring\r\nresponse.\r\n\r\nThrowables and exceptions are no longer passed to the response logging\r\nmiddlewares through the response map. The response logging middlewares\r\nwill only be executed if all is successful. It is now the responsibility\r\nof the exception handlers to log response errors.","created_at":"2015-10-07T16:33:30Z","updated_at":"2015-10-07T18:01:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c15f8f626b2591f38006d94bd3e834f0d3e89974","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/DiscoveryEnvironmentBackend/pulls/20/commits","review_comments_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/DiscoveryEnvironmentBackend/pulls/20/comments","review_comment_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/DiscoveryEnvironmentBackend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/DiscoveryEnvironmentBackend/issues/20/comments","statuses_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/DiscoveryEnvironmentBackend/statuses/99d21ed83109bf7e660846b540be5ada2b29a740","head":{"label":"strootman:CORE-7112,7113_Metadactyl-Logging_Exception","ref":"CORE-7112,7113_Metadactyl-Logging_Exception","sha":"99d21ed83109bf7e660846b540be5ada2b29a740","user":{"login":"strootman","id":1720162,"avatar_url":"https://avatars.githubusercontent.com/u/1720162?v=3","gravatar_id":"","url":"https://api.github.com/users/strootman","html_url":"https://github.com/strootman","followers_url":"https://api.github.com/users/strootman/followers","following_url":"https://api.github.com/users/strootman/following{/other_user}","gists_url":"https://api.github.com/users/strootman/gists{/gist_id}","starred_url":"https://api.github.com/users/strootman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strootman/subscriptions","organizations_url":"https://api.github.com/users/strootman/orgs","repos_url":"https://api.github.com/users/strootman/repos","events_url":"https://api.github.com/users/strootman/events{/privacy}","received_events_url":"https://api.github.com/users/strootman/received_events","type":"User","site_admin":false},"repo":{"id":25179368,"name":"DiscoveryEnvironmentBackend","full_name":"strootman/DiscoveryEnvironmentBackend","owner":{"login":"strootman","id":1720162,"avatar_url":"https://avatars.githubusercontent.com/u/1720162?v=3","gravatar_id":"","url":"https://api.github.com/users/strootman","html_url":"https://github.com/strootman","followers_url":"https://api.github.com/users/strootman/followers","following_url":"https://api.github.com/users/strootman/following{/other_user}","gists_url":"https://api.github.com/users/strootman/gists{/gist_id}","starred_url":"https://api.github.com/users/strootman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strootman/subscriptions","organizations_url":"https://api.github.com/users/strootman/orgs","repos_url":"https://api.github.com/users/strootman/repos","events_url":"https://api.github.com/users/strootman/events{/privacy}","received_events_url":"https://api.github.com/users/strootman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/strootman/DiscoveryEnvironmentBackend","description":"All of the backend code for the Discovery Environment in a single repository.","fork":true,"url":"https://api.github.com/repos/strootman/DiscoveryEnvironmentBackend","forks_url":"https://api.github.com/repos/strootman/DiscoveryEnvironmentBackend/forks","keys_url":"https://api.github.com/repos/strootman/DiscoveryEnvironmentBackend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/strootman/DiscoveryEnvironmentBackend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/strootman/DiscoveryEnvironmentBackend/teams","hooks_url":"https://api.github.com/repos/strootman/DiscoveryEnvironmentBackend/hooks","issue_events_url":"https://api.github.com/repos/strootman/DiscoveryEnvironmentBackend/issues/events{/number}","events_url":"https://api.github.com/repos/strootman/DiscoveryEnvironmentBackend/events","assignees_url":"https://api.github.com/repos/strootman/DiscoveryEnvironmentBackend/assignees{/user}","branches_url":"https://api.github.com/repos/strootman/DiscoveryEnvironmentBackend/branches{/branch}","tags_url":"https://api.github.com/repos/strootman/DiscoveryEnvironmentBackend/tags","blobs_url":"https://api.github.com/repos/strootman/DiscoveryEnvironmentBackend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/strootman/DiscoveryEnvironmentBackend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/strootman/DiscoveryEnvironmentBackend/git/refs{/sha}","trees_url":"https://api.github.com/repos/strootman/DiscoveryEnvironmentBackend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/strootman/DiscoveryEnvironmentBackend/statuses/{sha}","languages_url":"https://api.github.com/repos/strootman/DiscoveryEnvironmentBackend/languages","stargazers_url":"https://api.github.com/repos/strootman/DiscoveryEnvironmentBackend/stargazers","contributors_url":"https://api.github.com/repos/strootman/DiscoveryEnvironmentBackend/contributors","subscribers_url":"https://api.github.com/repos/strootman/DiscoveryEnvironmentBackend/subscribers","subscription_url":"https://api.github.com/repos/strootman/DiscoveryEnvironmentBackend/subscription","commits_url":"https://api.github.com/repos/strootman/DiscoveryEnvironmentBackend/commits{/sha}","git_commits_url":"https://api.github.com/repos/strootman/DiscoveryEnvironmentBackend/git/commits{/sha}","comments_url":"https://api.github.com/repos/strootman/DiscoveryEnvironmentBackend/comments{/number}","issue_comment_url":"https://api.github.com/repos/strootman/DiscoveryEnvironmentBackend/issues/comments{/number}","contents_url":"https://api.github.com/repos/strootman/DiscoveryEnvironmentBackend/contents/{+path}","compare_url":"https://api.github.com/repos/strootman/DiscoveryEnvironmentBackend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/strootman/DiscoveryEnvironmentBackend/merges","archive_url":"https://api.github.com/repos/strootman/DiscoveryEnvironmentBackend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/strootman/DiscoveryEnvironmentBackend/downloads","issues_url":"https://api.github.com/repos/strootman/DiscoveryEnvironmentBackend/issues{/number}","pulls_url":"https://api.github.com/repos/strootman/DiscoveryEnvironmentBackend/pulls{/number}","milestones_url":"https://api.github.com/repos/strootman/DiscoveryEnvironmentBackend/milestones{/number}","notifications_url":"https://api.github.com/repos/strootman/DiscoveryEnvironmentBackend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/strootman/DiscoveryEnvironmentBackend/labels{/name}","releases_url":"https://api.github.com/repos/strootman/DiscoveryEnvironmentBackend/releases{/id}","created_at":"2014-10-13T21:49:55Z","updated_at":"2015-09-25T03:37:32Z","pushed_at":"2015-10-07T16:42:05Z","git_url":"git://github.com/strootman/DiscoveryEnvironmentBackend.git","ssh_url":"git@github.com:strootman/DiscoveryEnvironmentBackend.git","clone_url":"https://github.com/strootman/DiscoveryEnvironmentBackend.git","svn_url":"https://github.com/strootman/DiscoveryEnvironmentBackend","homepage":"","size":17274,"stargazers_count":0,"watchers_count":0,"language":"Clojure","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"iPlantCollaborativeOpenSource:dev","ref":"dev","sha":"796fd98545a3f028ada0d699dda98f05748d87a8","user":{"login":"iPlantCollaborativeOpenSource","id":669032,"avatar_url":"https://avatars.githubusercontent.com/u/669032?v=3","gravatar_id":"","url":"https://api.github.com/users/iPlantCollaborativeOpenSource","html_url":"https://github.com/iPlantCollaborativeOpenSource","followers_url":"https://api.github.com/users/iPlantCollaborativeOpenSource/followers","following_url":"https://api.github.com/users/iPlantCollaborativeOpenSource/following{/other_user}","gists_url":"https://api.github.com/users/iPlantCollaborativeOpenSource/gists{/gist_id}","starred_url":"https://api.github.com/users/iPlantCollaborativeOpenSource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iPlantCollaborativeOpenSource/subscriptions","organizations_url":"https://api.github.com/users/iPlantCollaborativeOpenSource/orgs","repos_url":"https://api.github.com/users/iPlantCollaborativeOpenSource/repos","events_url":"https://api.github.com/users/iPlantCollaborativeOpenSource/events{/privacy}","received_events_url":"https://api.github.com/users/iPlantCollaborativeOpenSource/received_events","type":"Organization","site_admin":false},"repo":{"id":17852451,"name":"DiscoveryEnvironmentBackend","full_name":"iPlantCollaborativeOpenSource/DiscoveryEnvironmentBackend","owner":{"login":"iPlantCollaborativeOpenSource","id":669032,"avatar_url":"https://avatars.githubusercontent.com/u/669032?v=3","gravatar_id":"","url":"https://api.github.com/users/iPlantCollaborativeOpenSource","html_url":"https://github.com/iPlantCollaborativeOpenSource","followers_url":"https://api.github.com/users/iPlantCollaborativeOpenSource/followers","following_url":"https://api.github.com/users/iPlantCollaborativeOpenSource/following{/other_user}","gists_url":"https://api.github.com/users/iPlantCollaborativeOpenSource/gists{/gist_id}","starred_url":"https://api.github.com/users/iPlantCollaborativeOpenSource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iPlantCollaborativeOpenSource/subscriptions","organizations_url":"https://api.github.com/users/iPlantCollaborativeOpenSource/orgs","repos_url":"https://api.github.com/users/iPlantCollaborativeOpenSource/repos","events_url":"https://api.github.com/users/iPlantCollaborativeOpenSource/events{/privacy}","received_events_url":"https://api.github.com/users/iPlantCollaborativeOpenSource/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/iPlantCollaborativeOpenSource/DiscoveryEnvironmentBackend","description":"All of the backend code for the Discovery Environment in a single repository.","fork":false,"url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/DiscoveryEnvironmentBackend","forks_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/DiscoveryEnvironmentBackend/forks","keys_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/DiscoveryEnvironmentBackend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/DiscoveryEnvironmentBackend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/DiscoveryEnvironmentBackend/teams","hooks_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/DiscoveryEnvironmentBackend/hooks","issue_events_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/DiscoveryEnvironmentBackend/issues/events{/number}","events_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/DiscoveryEnvironmentBackend/events","assignees_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/DiscoveryEnvironmentBackend/assignees{/user}","branches_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/DiscoveryEnvironmentBackend/branches{/branch}","tags_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/DiscoveryEnvironmentBackend/tags","blobs_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/DiscoveryEnvironmentBackend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/DiscoveryEnvironmentBackend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/DiscoveryEnvironmentBackend/git/refs{/sha}","trees_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/DiscoveryEnvironmentBackend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/DiscoveryEnvironmentBackend/statuses/{sha}","languages_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/DiscoveryEnvironmentBackend/languages","stargazers_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/DiscoveryEnvironmentBackend/stargazers","contributors_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/DiscoveryEnvironmentBackend/contributors","subscribers_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/DiscoveryEnvironmentBackend/subscribers","subscription_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/DiscoveryEnvironmentBackend/subscription","commits_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/DiscoveryEnvironmentBackend/commits{/sha}","git_commits_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/DiscoveryEnvironmentBackend/git/commits{/sha}","comments_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/DiscoveryEnvironmentBackend/comments{/number}","issue_comment_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/DiscoveryEnvironmentBackend/issues/comments{/number}","contents_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/DiscoveryEnvironmentBackend/contents/{+path}","compare_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/DiscoveryEnvironmentBackend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/DiscoveryEnvironmentBackend/merges","archive_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/DiscoveryEnvironmentBackend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/DiscoveryEnvironmentBackend/downloads","issues_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/DiscoveryEnvironmentBackend/issues{/number}","pulls_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/DiscoveryEnvironmentBackend/pulls{/number}","milestones_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/DiscoveryEnvironmentBackend/milestones{/number}","notifications_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/DiscoveryEnvironmentBackend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/DiscoveryEnvironmentBackend/labels{/name}","releases_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/DiscoveryEnvironmentBackend/releases{/id}","created_at":"2014-03-18T03:26:15Z","updated_at":"2015-10-06T00:42:33Z","pushed_at":"2015-10-07T17:54:05Z","git_url":"git://github.com/iPlantCollaborativeOpenSource/DiscoveryEnvironmentBackend.git","ssh_url":"git@github.com:iPlantCollaborativeOpenSource/DiscoveryEnvironmentBackend.git","clone_url":"https://github.com/iPlantCollaborativeOpenSource/DiscoveryEnvironmentBackend.git","svn_url":"https://github.com/iPlantCollaborativeOpenSource/DiscoveryEnvironmentBackend","homepage":"","size":22928,"stargazers_count":7,"watchers_count":7,"language":"Clojure","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":1,"forks":9,"open_issues":1,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/iPlantCollaborativeOpenSource/DiscoveryEnvironmentBackend/pulls/20"},"html":{"href":"https://github.com/iPlantCollaborativeOpenSource/DiscoveryEnvironmentBackend/pull/20"},"issue":{"href":"https://api.github.com/repos/iPlantCollaborativeOpenSource/DiscoveryEnvironmentBackend/issues/20"},"comments":{"href":"https://api.github.com/repos/iPlantCollaborativeOpenSource/DiscoveryEnvironmentBackend/issues/20/comments"},"review_comments":{"href":"https://api.github.com/repos/iPlantCollaborativeOpenSource/DiscoveryEnvironmentBackend/pulls/20/comments"},"review_comment":{"href":"https://api.github.com/repos/iPlantCollaborativeOpenSource/DiscoveryEnvironmentBackend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/iPlantCollaborativeOpenSource/DiscoveryEnvironmentBackend/pulls/20/commits"},"statuses":{"href":"https://api.github.com/repos/iPlantCollaborativeOpenSource/DiscoveryEnvironmentBackend/statuses/99d21ed83109bf7e660846b540be5ada2b29a740"}}}}