{"action":"created","comment":{"url":"https://api.github.com/repos/chef/chef-zero/pulls/comments/45075071","id":45075071,"diff_hunk":"@@ -88,10 +107,12 @@ def start_server(chef_repo_path)\n     '--skip-cookbook-artifacts',\n     '--skip-containers',\n     '--skip-api-v1'\n+  ] + chef_fs_skips)\n \n-  ])\n+  fail_fast = []\n+  # fail_fast = [\"--fail-fast\"]","path":"spec/run_oc_pedant.rb","position":83,"original_position":83,"commit_id":"0344829524c43f2872fe54f8b89198d04441b44e","original_commit_id":"0344829524c43f2872fe54f8b89198d04441b44e","user":{"login":"tyler-ball","id":2481463,"avatar_url":"https://avatars.githubusercontent.com/u/2481463?v=3","gravatar_id":"","url":"https://api.github.com/users/tyler-ball","html_url":"https://github.com/tyler-ball","followers_url":"https://api.github.com/users/tyler-ball/followers","following_url":"https://api.github.com/users/tyler-ball/following{/other_user}","gists_url":"https://api.github.com/users/tyler-ball/gists{/gist_id}","starred_url":"https://api.github.com/users/tyler-ball/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tyler-ball/subscriptions","organizations_url":"https://api.github.com/users/tyler-ball/orgs","repos_url":"https://api.github.com/users/tyler-ball/repos","events_url":"https://api.github.com/users/tyler-ball/events{/privacy}","received_events_url":"https://api.github.com/users/tyler-ball/received_events","type":"User","site_admin":false},"body":"Are we purposefully leaving fail_fast off?","created_at":"2015-11-17T15:42:17Z","updated_at":"2015-11-17T15:42:17Z","html_url":"https://github.com/chef/chef-zero/pull/173#discussion_r45075071","pull_request_url":"https://api.github.com/repos/chef/chef-zero/pulls/173","_links":{"self":{"href":"https://api.github.com/repos/chef/chef-zero/pulls/comments/45075071"},"html":{"href":"https://github.com/chef/chef-zero/pull/173#discussion_r45075071"},"pull_request":{"href":"https://api.github.com/repos/chef/chef-zero/pulls/173"}}},"pull_request":{"url":"https://api.github.com/repos/chef/chef-zero/pulls/173","id":50852645,"html_url":"https://github.com/chef/chef-zero/pull/173","diff_url":"https://github.com/chef/chef-zero/pull/173.diff","patch_url":"https://github.com/chef/chef-zero/pull/173.patch","issue_url":"https://api.github.com/repos/chef/chef-zero/issues/173","number":173,"state":"open","locked":false,"title":"Upgrade pedant, and enable running in ChefFS mode","user":{"login":"randomcamel","id":400783,"avatar_url":"https://avatars.githubusercontent.com/u/400783?v=3","gravatar_id":"","url":"https://api.github.com/users/randomcamel","html_url":"https://github.com/randomcamel","followers_url":"https://api.github.com/users/randomcamel/followers","following_url":"https://api.github.com/users/randomcamel/following{/other_user}","gists_url":"https://api.github.com/users/randomcamel/gists{/gist_id}","starred_url":"https://api.github.com/users/randomcamel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/randomcamel/subscriptions","organizations_url":"https://api.github.com/users/randomcamel/orgs","repos_url":"https://api.github.com/users/randomcamel/repos","events_url":"https://api.github.com/users/randomcamel/events{/privacy}","received_events_url":"https://api.github.com/users/randomcamel/received_events","type":"User","site_admin":false},"body":"This has `chef-zero` run against the most recent version of `oc-chef-pedant` (currently 2.2.0, though we'll need to do a release due to a single change there), and has numerous changes to run with ChefFS as the backing store.\r\n\r\nDepends on:\r\n  - https://github.com/chef/chef-server/pull/622 (`oc-chef-pedant` tags and behavioral changes)\r\n  - https://github.com/chef/chef/pull/4173 (ChefFS changes to handle invitations and members)","created_at":"2015-11-16T19:17:49Z","updated_at":"2015-11-17T15:42:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"894ee85897b85187b2651cbb71f06a29216cc847","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/chef/chef-zero/pulls/173/commits","review_comments_url":"https://api.github.com/repos/chef/chef-zero/pulls/173/comments","review_comment_url":"https://api.github.com/repos/chef/chef-zero/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chef/chef-zero/issues/173/comments","statuses_url":"https://api.github.com/repos/chef/chef-zero/statuses/0344829524c43f2872fe54f8b89198d04441b44e","head":{"label":"chef:cd/run-moar-pedant","ref":"cd/run-moar-pedant","sha":"0344829524c43f2872fe54f8b89198d04441b44e","user":{"login":"chef","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?v=3","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"repo":{"id":7253769,"name":"chef-zero","full_name":"chef/chef-zero","owner":{"login":"chef","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?v=3","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chef/chef-zero","description":"Simple, easy-run, fast-start in-memory Chef server for testing and solo purposes","fork":false,"url":"https://api.github.com/repos/chef/chef-zero","forks_url":"https://api.github.com/repos/chef/chef-zero/forks","keys_url":"https://api.github.com/repos/chef/chef-zero/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chef/chef-zero/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chef/chef-zero/teams","hooks_url":"https://api.github.com/repos/chef/chef-zero/hooks","issue_events_url":"https://api.github.com/repos/chef/chef-zero/issues/events{/number}","events_url":"https://api.github.com/repos/chef/chef-zero/events","assignees_url":"https://api.github.com/repos/chef/chef-zero/assignees{/user}","branches_url":"https://api.github.com/repos/chef/chef-zero/branches{/branch}","tags_url":"https://api.github.com/repos/chef/chef-zero/tags","blobs_url":"https://api.github.com/repos/chef/chef-zero/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chef/chef-zero/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chef/chef-zero/git/refs{/sha}","trees_url":"https://api.github.com/repos/chef/chef-zero/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chef/chef-zero/statuses/{sha}","languages_url":"https://api.github.com/repos/chef/chef-zero/languages","stargazers_url":"https://api.github.com/repos/chef/chef-zero/stargazers","contributors_url":"https://api.github.com/repos/chef/chef-zero/contributors","subscribers_url":"https://api.github.com/repos/chef/chef-zero/subscribers","subscription_url":"https://api.github.com/repos/chef/chef-zero/subscription","commits_url":"https://api.github.com/repos/chef/chef-zero/commits{/sha}","git_commits_url":"https://api.github.com/repos/chef/chef-zero/git/commits{/sha}","comments_url":"https://api.github.com/repos/chef/chef-zero/comments{/number}","issue_comment_url":"https://api.github.com/repos/chef/chef-zero/issues/comments{/number}","contents_url":"https://api.github.com/repos/chef/chef-zero/contents/{+path}","compare_url":"https://api.github.com/repos/chef/chef-zero/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chef/chef-zero/merges","archive_url":"https://api.github.com/repos/chef/chef-zero/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chef/chef-zero/downloads","issues_url":"https://api.github.com/repos/chef/chef-zero/issues{/number}","pulls_url":"https://api.github.com/repos/chef/chef-zero/pulls{/number}","milestones_url":"https://api.github.com/repos/chef/chef-zero/milestones{/number}","notifications_url":"https://api.github.com/repos/chef/chef-zero/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chef/chef-zero/labels{/name}","releases_url":"https://api.github.com/repos/chef/chef-zero/releases{/id}","created_at":"2012-12-20T07:24:14Z","updated_at":"2015-11-17T01:55:46Z","pushed_at":"2015-11-16T19:29:01Z","git_url":"git://github.com/chef/chef-zero.git","ssh_url":"git@github.com:chef/chef-zero.git","clone_url":"https://github.com/chef/chef-zero.git","svn_url":"https://github.com/chef/chef-zero","homepage":null,"size":632,"stargazers_count":447,"watchers_count":447,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":66,"mirror_url":null,"open_issues_count":49,"forks":66,"open_issues":49,"watchers":447,"default_branch":"master"}},"base":{"label":"chef:master","ref":"master","sha":"5205839b26a804ce0016c5935d11a4699d90cbda","user":{"login":"chef","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?v=3","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"repo":{"id":7253769,"name":"chef-zero","full_name":"chef/chef-zero","owner":{"login":"chef","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?v=3","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chef/chef-zero","description":"Simple, easy-run, fast-start in-memory Chef server for testing and solo purposes","fork":false,"url":"https://api.github.com/repos/chef/chef-zero","forks_url":"https://api.github.com/repos/chef/chef-zero/forks","keys_url":"https://api.github.com/repos/chef/chef-zero/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chef/chef-zero/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chef/chef-zero/teams","hooks_url":"https://api.github.com/repos/chef/chef-zero/hooks","issue_events_url":"https://api.github.com/repos/chef/chef-zero/issues/events{/number}","events_url":"https://api.github.com/repos/chef/chef-zero/events","assignees_url":"https://api.github.com/repos/chef/chef-zero/assignees{/user}","branches_url":"https://api.github.com/repos/chef/chef-zero/branches{/branch}","tags_url":"https://api.github.com/repos/chef/chef-zero/tags","blobs_url":"https://api.github.com/repos/chef/chef-zero/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chef/chef-zero/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chef/chef-zero/git/refs{/sha}","trees_url":"https://api.github.com/repos/chef/chef-zero/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chef/chef-zero/statuses/{sha}","languages_url":"https://api.github.com/repos/chef/chef-zero/languages","stargazers_url":"https://api.github.com/repos/chef/chef-zero/stargazers","contributors_url":"https://api.github.com/repos/chef/chef-zero/contributors","subscribers_url":"https://api.github.com/repos/chef/chef-zero/subscribers","subscription_url":"https://api.github.com/repos/chef/chef-zero/subscription","commits_url":"https://api.github.com/repos/chef/chef-zero/commits{/sha}","git_commits_url":"https://api.github.com/repos/chef/chef-zero/git/commits{/sha}","comments_url":"https://api.github.com/repos/chef/chef-zero/comments{/number}","issue_comment_url":"https://api.github.com/repos/chef/chef-zero/issues/comments{/number}","contents_url":"https://api.github.com/repos/chef/chef-zero/contents/{+path}","compare_url":"https://api.github.com/repos/chef/chef-zero/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chef/chef-zero/merges","archive_url":"https://api.github.com/repos/chef/chef-zero/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chef/chef-zero/downloads","issues_url":"https://api.github.com/repos/chef/chef-zero/issues{/number}","pulls_url":"https://api.github.com/repos/chef/chef-zero/pulls{/number}","milestones_url":"https://api.github.com/repos/chef/chef-zero/milestones{/number}","notifications_url":"https://api.github.com/repos/chef/chef-zero/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chef/chef-zero/labels{/name}","releases_url":"https://api.github.com/repos/chef/chef-zero/releases{/id}","created_at":"2012-12-20T07:24:14Z","updated_at":"2015-11-17T01:55:46Z","pushed_at":"2015-11-16T19:29:01Z","git_url":"git://github.com/chef/chef-zero.git","ssh_url":"git@github.com:chef/chef-zero.git","clone_url":"https://github.com/chef/chef-zero.git","svn_url":"https://github.com/chef/chef-zero","homepage":null,"size":632,"stargazers_count":447,"watchers_count":447,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":66,"mirror_url":null,"open_issues_count":49,"forks":66,"open_issues":49,"watchers":447,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chef/chef-zero/pulls/173"},"html":{"href":"https://github.com/chef/chef-zero/pull/173"},"issue":{"href":"https://api.github.com/repos/chef/chef-zero/issues/173"},"comments":{"href":"https://api.github.com/repos/chef/chef-zero/issues/173/comments"},"review_comments":{"href":"https://api.github.com/repos/chef/chef-zero/pulls/173/comments"},"review_comment":{"href":"https://api.github.com/repos/chef/chef-zero/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chef/chef-zero/pulls/173/commits"},"statuses":{"href":"https://api.github.com/repos/chef/chef-zero/statuses/0344829524c43f2872fe54f8b89198d04441b44e"}}}}