{"action":"created","comment":{"url":"https://api.github.com/repos/mbedmicro/pyOCD/pulls/comments/35497252","id":35497252,"diff_hunk":"@@ -329,12 +338,27 @@ def run(self):\n                     break\n \n                 if self.packet_io.interrupt_event.isSet():\n-                    logging.debug(\"Got unexpected ctrl-c, ignoring\")\n+                    if self.non_stop:","path":"pyOCD/gdbserver/gdbserver.py","position":82,"original_position":82,"commit_id":"1f2ede89919f9c9fbb90a245fe59ef27894962c9","original_commit_id":"1f2ede89919f9c9fbb90a245fe59ef27894962c9","user":{"login":"c1728p9","id":2916772,"avatar_url":"https://avatars.githubusercontent.com/u/2916772?v=3","gravatar_id":"","url":"https://api.github.com/users/c1728p9","html_url":"https://github.com/c1728p9","followers_url":"https://api.github.com/users/c1728p9/followers","following_url":"https://api.github.com/users/c1728p9/following{/other_user}","gists_url":"https://api.github.com/users/c1728p9/gists{/gist_id}","starred_url":"https://api.github.com/users/c1728p9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/c1728p9/subscriptions","organizations_url":"https://api.github.com/users/c1728p9/orgs","repos_url":"https://api.github.com/users/c1728p9/repos","events_url":"https://api.github.com/users/c1728p9/events{/privacy}","received_events_url":"https://api.github.com/users/c1728p9/received_events","type":"User","site_admin":false},"body":"Yeah, that is a good point that all-stop mode would have already halted the target.   I see no downside to the way you have it now, so I wouldn't worry about changing it.  Out of curiosity, how should ctrl-c behave when there are multiple threads?  Should it stop all the threads, or just the current one?  Or should another command such as vCont be used instead of ctrl-c in non-stop mode for well defined behavior among all threads?","created_at":"2015-07-26T20:37:07Z","updated_at":"2015-07-26T20:37:07Z","html_url":"https://github.com/mbedmicro/pyOCD/pull/175#discussion_r35497252","pull_request_url":"https://api.github.com/repos/mbedmicro/pyOCD/pulls/175","_links":{"self":{"href":"https://api.github.com/repos/mbedmicro/pyOCD/pulls/comments/35497252"},"html":{"href":"https://github.com/mbedmicro/pyOCD/pull/175#discussion_r35497252"},"pull_request":{"href":"https://api.github.com/repos/mbedmicro/pyOCD/pulls/175"}}},"pull_request":{"url":"https://api.github.com/repos/mbedmicro/pyOCD/pulls/175","id":40318310,"html_url":"https://github.com/mbedmicro/pyOCD/pull/175","diff_url":"https://github.com/mbedmicro/pyOCD/pull/175.diff","patch_url":"https://github.com/mbedmicro/pyOCD/pull/175.patch","issue_url":"https://api.github.com/repos/mbedmicro/pyOCD/issues/175","number":175,"state":"open","locked":false,"title":"gdb server non-stop mode support","user":{"login":"flit","id":3116536,"avatar_url":"https://avatars.githubusercontent.com/u/3116536?v=3","gravatar_id":"","url":"https://api.github.com/users/flit","html_url":"https://github.com/flit","followers_url":"https://api.github.com/users/flit/followers","following_url":"https://api.github.com/users/flit/following{/other_user}","gists_url":"https://api.github.com/users/flit/gists{/gist_id}","starred_url":"https://api.github.com/users/flit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flit/subscriptions","organizations_url":"https://api.github.com/users/flit/orgs","repos_url":"https://api.github.com/users/flit/repos","events_url":"https://api.github.com/users/flit/events{/privacy}","received_events_url":"https://api.github.com/users/flit/received_events","type":"User","site_admin":false},"body":"This PR adds support for [non-stop mode](https://sourceware.org/gdb/current/onlinedocs/gdb/Remote-Non_002dStop.html#Remote-Non_002dStop). This feature allows for accessing memory while the target is running.\r\n\r\nThese changes were tested with command-line arm-none-eabi-gdb version 7.8.0.20150604 from GNU ARM Embedded 2015q2. To enable non-stop mode, issue the `set non-stop on` command before connecting to the gdb server. Note that you need to use `continue&` to run the target and still have gdb command access.\r\n\r\nEclipse supposedly has [support for non-stop mode](http://help.eclipse.org/luna/index.jsp?topic=%2Forg.eclipse.cdt.doc.user%2Freference%2Fcdt_u_dsfgdb.htm). However, it doesn't seem to work at all. Setting this preference doesn't actually cause non-stop mode to be requested to the gdb server. ","created_at":"2015-07-20T00:43:00Z","updated_at":"2015-07-26T20:37:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cffdfc944d9f462f249a17e023ab3d807d659da0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mbedmicro/pyOCD/pulls/175/commits","review_comments_url":"https://api.github.com/repos/mbedmicro/pyOCD/pulls/175/comments","review_comment_url":"https://api.github.com/repos/mbedmicro/pyOCD/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mbedmicro/pyOCD/issues/175/comments","statuses_url":"https://api.github.com/repos/mbedmicro/pyOCD/statuses/1f2ede89919f9c9fbb90a245fe59ef27894962c9","head":{"label":"flit:dev_gdb_server","ref":"dev_gdb_server","sha":"1f2ede89919f9c9fbb90a245fe59ef27894962c9","user":{"login":"flit","id":3116536,"avatar_url":"https://avatars.githubusercontent.com/u/3116536?v=3","gravatar_id":"","url":"https://api.github.com/users/flit","html_url":"https://github.com/flit","followers_url":"https://api.github.com/users/flit/followers","following_url":"https://api.github.com/users/flit/following{/other_user}","gists_url":"https://api.github.com/users/flit/gists{/gist_id}","starred_url":"https://api.github.com/users/flit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flit/subscriptions","organizations_url":"https://api.github.com/users/flit/orgs","repos_url":"https://api.github.com/users/flit/repos","events_url":"https://api.github.com/users/flit/events{/privacy}","received_events_url":"https://api.github.com/users/flit/received_events","type":"User","site_admin":false},"repo":{"id":14731481,"name":"pyOCD","full_name":"flit/pyOCD","owner":{"login":"flit","id":3116536,"avatar_url":"https://avatars.githubusercontent.com/u/3116536?v=3","gravatar_id":"","url":"https://api.github.com/users/flit","html_url":"https://github.com/flit","followers_url":"https://api.github.com/users/flit/followers","following_url":"https://api.github.com/users/flit/following{/other_user}","gists_url":"https://api.github.com/users/flit/gists{/gist_id}","starred_url":"https://api.github.com/users/flit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flit/subscriptions","organizations_url":"https://api.github.com/users/flit/orgs","repos_url":"https://api.github.com/users/flit/repos","events_url":"https://api.github.com/users/flit/events{/privacy}","received_events_url":"https://api.github.com/users/flit/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/flit/pyOCD","description":"Open source python library for programming and debugging ARM Cortex-M microcontrollers using CMSIS-DAP","fork":true,"url":"https://api.github.com/repos/flit/pyOCD","forks_url":"https://api.github.com/repos/flit/pyOCD/forks","keys_url":"https://api.github.com/repos/flit/pyOCD/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flit/pyOCD/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flit/pyOCD/teams","hooks_url":"https://api.github.com/repos/flit/pyOCD/hooks","issue_events_url":"https://api.github.com/repos/flit/pyOCD/issues/events{/number}","events_url":"https://api.github.com/repos/flit/pyOCD/events","assignees_url":"https://api.github.com/repos/flit/pyOCD/assignees{/user}","branches_url":"https://api.github.com/repos/flit/pyOCD/branches{/branch}","tags_url":"https://api.github.com/repos/flit/pyOCD/tags","blobs_url":"https://api.github.com/repos/flit/pyOCD/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flit/pyOCD/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flit/pyOCD/git/refs{/sha}","trees_url":"https://api.github.com/repos/flit/pyOCD/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flit/pyOCD/statuses/{sha}","languages_url":"https://api.github.com/repos/flit/pyOCD/languages","stargazers_url":"https://api.github.com/repos/flit/pyOCD/stargazers","contributors_url":"https://api.github.com/repos/flit/pyOCD/contributors","subscribers_url":"https://api.github.com/repos/flit/pyOCD/subscribers","subscription_url":"https://api.github.com/repos/flit/pyOCD/subscription","commits_url":"https://api.github.com/repos/flit/pyOCD/commits{/sha}","git_commits_url":"https://api.github.com/repos/flit/pyOCD/git/commits{/sha}","comments_url":"https://api.github.com/repos/flit/pyOCD/comments{/number}","issue_comment_url":"https://api.github.com/repos/flit/pyOCD/issues/comments{/number}","contents_url":"https://api.github.com/repos/flit/pyOCD/contents/{+path}","compare_url":"https://api.github.com/repos/flit/pyOCD/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flit/pyOCD/merges","archive_url":"https://api.github.com/repos/flit/pyOCD/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flit/pyOCD/downloads","issues_url":"https://api.github.com/repos/flit/pyOCD/issues{/number}","pulls_url":"https://api.github.com/repos/flit/pyOCD/pulls{/number}","milestones_url":"https://api.github.com/repos/flit/pyOCD/milestones{/number}","notifications_url":"https://api.github.com/repos/flit/pyOCD/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flit/pyOCD/labels{/name}","releases_url":"https://api.github.com/repos/flit/pyOCD/releases{/id}","created_at":"2013-11-26T22:48:46Z","updated_at":"2014-07-23T15:16:30Z","pushed_at":"2015-07-21T23:28:47Z","git_url":"git://github.com/flit/pyOCD.git","ssh_url":"git@github.com:flit/pyOCD.git","clone_url":"https://github.com/flit/pyOCD.git","svn_url":"https://github.com/flit/pyOCD","homepage":null,"size":1497,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mbedmicro:master","ref":"master","sha":"4847b8f235a12fd80ef6d8e55eef8959f0c06a6c","user":{"login":"mbedmicro","id":3626466,"avatar_url":"https://avatars.githubusercontent.com/u/3626466?v=3","gravatar_id":"","url":"https://api.github.com/users/mbedmicro","html_url":"https://github.com/mbedmicro","followers_url":"https://api.github.com/users/mbedmicro/followers","following_url":"https://api.github.com/users/mbedmicro/following{/other_user}","gists_url":"https://api.github.com/users/mbedmicro/gists{/gist_id}","starred_url":"https://api.github.com/users/mbedmicro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbedmicro/subscriptions","organizations_url":"https://api.github.com/users/mbedmicro/orgs","repos_url":"https://api.github.com/users/mbedmicro/repos","events_url":"https://api.github.com/users/mbedmicro/events{/privacy}","received_events_url":"https://api.github.com/users/mbedmicro/received_events","type":"Organization","site_admin":false},"repo":{"id":13862423,"name":"pyOCD","full_name":"mbedmicro/pyOCD","owner":{"login":"mbedmicro","id":3626466,"avatar_url":"https://avatars.githubusercontent.com/u/3626466?v=3","gravatar_id":"","url":"https://api.github.com/users/mbedmicro","html_url":"https://github.com/mbedmicro","followers_url":"https://api.github.com/users/mbedmicro/followers","following_url":"https://api.github.com/users/mbedmicro/following{/other_user}","gists_url":"https://api.github.com/users/mbedmicro/gists{/gist_id}","starred_url":"https://api.github.com/users/mbedmicro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbedmicro/subscriptions","organizations_url":"https://api.github.com/users/mbedmicro/orgs","repos_url":"https://api.github.com/users/mbedmicro/repos","events_url":"https://api.github.com/users/mbedmicro/events{/privacy}","received_events_url":"https://api.github.com/users/mbedmicro/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mbedmicro/pyOCD","description":"Open source python library for programming and debugging ARM Cortex-M microcontrollers using CMSIS-DAP","fork":false,"url":"https://api.github.com/repos/mbedmicro/pyOCD","forks_url":"https://api.github.com/repos/mbedmicro/pyOCD/forks","keys_url":"https://api.github.com/repos/mbedmicro/pyOCD/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mbedmicro/pyOCD/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mbedmicro/pyOCD/teams","hooks_url":"https://api.github.com/repos/mbedmicro/pyOCD/hooks","issue_events_url":"https://api.github.com/repos/mbedmicro/pyOCD/issues/events{/number}","events_url":"https://api.github.com/repos/mbedmicro/pyOCD/events","assignees_url":"https://api.github.com/repos/mbedmicro/pyOCD/assignees{/user}","branches_url":"https://api.github.com/repos/mbedmicro/pyOCD/branches{/branch}","tags_url":"https://api.github.com/repos/mbedmicro/pyOCD/tags","blobs_url":"https://api.github.com/repos/mbedmicro/pyOCD/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mbedmicro/pyOCD/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mbedmicro/pyOCD/git/refs{/sha}","trees_url":"https://api.github.com/repos/mbedmicro/pyOCD/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mbedmicro/pyOCD/statuses/{sha}","languages_url":"https://api.github.com/repos/mbedmicro/pyOCD/languages","stargazers_url":"https://api.github.com/repos/mbedmicro/pyOCD/stargazers","contributors_url":"https://api.github.com/repos/mbedmicro/pyOCD/contributors","subscribers_url":"https://api.github.com/repos/mbedmicro/pyOCD/subscribers","subscription_url":"https://api.github.com/repos/mbedmicro/pyOCD/subscription","commits_url":"https://api.github.com/repos/mbedmicro/pyOCD/commits{/sha}","git_commits_url":"https://api.github.com/repos/mbedmicro/pyOCD/git/commits{/sha}","comments_url":"https://api.github.com/repos/mbedmicro/pyOCD/comments{/number}","issue_comment_url":"https://api.github.com/repos/mbedmicro/pyOCD/issues/comments{/number}","contents_url":"https://api.github.com/repos/mbedmicro/pyOCD/contents/{+path}","compare_url":"https://api.github.com/repos/mbedmicro/pyOCD/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mbedmicro/pyOCD/merges","archive_url":"https://api.github.com/repos/mbedmicro/pyOCD/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mbedmicro/pyOCD/downloads","issues_url":"https://api.github.com/repos/mbedmicro/pyOCD/issues{/number}","pulls_url":"https://api.github.com/repos/mbedmicro/pyOCD/pulls{/number}","milestones_url":"https://api.github.com/repos/mbedmicro/pyOCD/milestones{/number}","notifications_url":"https://api.github.com/repos/mbedmicro/pyOCD/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mbedmicro/pyOCD/labels{/name}","releases_url":"https://api.github.com/repos/mbedmicro/pyOCD/releases{/id}","created_at":"2013-10-25T14:10:05Z","updated_at":"2015-06-22T08:00:38Z","pushed_at":"2015-07-21T19:04:57Z","git_url":"git://github.com/mbedmicro/pyOCD.git","ssh_url":"git@github.com:mbedmicro/pyOCD.git","clone_url":"https://github.com/mbedmicro/pyOCD.git","svn_url":"https://github.com/mbedmicro/pyOCD","homepage":null,"size":1879,"stargazers_count":68,"watchers_count":68,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":63,"mirror_url":null,"open_issues_count":16,"forks":63,"open_issues":16,"watchers":68,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mbedmicro/pyOCD/pulls/175"},"html":{"href":"https://github.com/mbedmicro/pyOCD/pull/175"},"issue":{"href":"https://api.github.com/repos/mbedmicro/pyOCD/issues/175"},"comments":{"href":"https://api.github.com/repos/mbedmicro/pyOCD/issues/175/comments"},"review_comments":{"href":"https://api.github.com/repos/mbedmicro/pyOCD/pulls/175/comments"},"review_comment":{"href":"https://api.github.com/repos/mbedmicro/pyOCD/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mbedmicro/pyOCD/pulls/175/commits"},"statuses":{"href":"https://api.github.com/repos/mbedmicro/pyOCD/statuses/1f2ede89919f9c9fbb90a245fe59ef27894962c9"}}}}