{"action":"closed","number":1371,"pull_request":{"url":"https://api.github.com/repos/flutter/engine/pulls/1371","id":46184036,"html_url":"https://github.com/flutter/engine/pull/1371","diff_url":"https://github.com/flutter/engine/pull/1371.diff","patch_url":"https://github.com/flutter/engine/pull/1371.patch","issue_url":"https://api.github.com/repos/flutter/engine/issues/1371","number":1371,"state":"closed","locked":false,"title":"Make the FAB move up when a Snack Bar slides in.","user":{"login":"Hixie","id":551196,"avatar_url":"https://avatars.githubusercontent.com/u/551196?v=3","gravatar_id":"","url":"https://api.github.com/users/Hixie","html_url":"https://github.com/Hixie","followers_url":"https://api.github.com/users/Hixie/followers","following_url":"https://api.github.com/users/Hixie/following{/other_user}","gists_url":"https://api.github.com/users/Hixie/gists{/gist_id}","starred_url":"https://api.github.com/users/Hixie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hixie/subscriptions","organizations_url":"https://api.github.com/users/Hixie/orgs","repos_url":"https://api.github.com/users/Hixie/repos","events_url":"https://api.github.com/users/Hixie/events{/privacy}","received_events_url":"https://api.github.com/users/Hixie/received_events","type":"User","site_admin":false},"body":"This changes how SnackBar works so you can use it anywhere, not just on\r\nthe bottom edge of the screen (it used to rely on overflowing its bounds\r\nand having negative offsets... I'm not really sure how hit testing\r\nworked on it before!).\r\n\r\nTo do this I introduced a new RenderBox, RenderOverflowBox, that lets\r\nyou set your child's size independent of your own. I needed this so that\r\nthe snack bar could use a SquashTransition to change its size, while not\r\naffecting the layout of its child. This is exposed as OverflowBox in\r\nfn3. I'm not sure if it's the best API. It doesn't let you position the\r\nchild (which is an issue if the size you give is smaller), it doesn't\r\nlet you give a loose constraint (which maybe you might want?). But it\r\nhandles this use case, so for now it's probably ok.\r\n\r\nMaking the FAB get repositioned out of the way of the Snack Bar is now\r\ndone in the Scaffold, which is in charge of positioning both of those\r\nand is the place that knows that both exist.","created_at":"2015-09-28T17:24:53Z","updated_at":"2015-09-29T22:23:49Z","closed_at":"2015-09-29T22:23:49Z","merged_at":"2015-09-29T22:23:49Z","merge_commit_sha":"c8eb0870e0ba601e55ba293dd9248cefbf76d922","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/flutter/engine/pulls/1371/commits","review_comments_url":"https://api.github.com/repos/flutter/engine/pulls/1371/comments","review_comment_url":"https://api.github.com/repos/flutter/engine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flutter/engine/issues/1371/comments","statuses_url":"https://api.github.com/repos/flutter/engine/statuses/e7ddb4ce78130336faf1a07c472526c3384d8536","head":{"label":"Hixie:fab-snack","ref":"fab-snack","sha":"e7ddb4ce78130336faf1a07c472526c3384d8536","user":{"login":"Hixie","id":551196,"avatar_url":"https://avatars.githubusercontent.com/u/551196?v=3","gravatar_id":"","url":"https://api.github.com/users/Hixie","html_url":"https://github.com/Hixie","followers_url":"https://api.github.com/users/Hixie/followers","following_url":"https://api.github.com/users/Hixie/following{/other_user}","gists_url":"https://api.github.com/users/Hixie/gists{/gist_id}","starred_url":"https://api.github.com/users/Hixie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hixie/subscriptions","organizations_url":"https://api.github.com/users/Hixie/orgs","repos_url":"https://api.github.com/users/Hixie/repos","events_url":"https://api.github.com/users/Hixie/events{/privacy}","received_events_url":"https://api.github.com/users/Hixie/received_events","type":"User","site_admin":false},"repo":{"id":39216363,"name":"sky_engine","full_name":"Hixie/sky_engine","owner":{"login":"Hixie","id":551196,"avatar_url":"https://avatars.githubusercontent.com/u/551196?v=3","gravatar_id":"","url":"https://api.github.com/users/Hixie","html_url":"https://github.com/Hixie","followers_url":"https://api.github.com/users/Hixie/followers","following_url":"https://api.github.com/users/Hixie/following{/other_user}","gists_url":"https://api.github.com/users/Hixie/gists{/gist_id}","starred_url":"https://api.github.com/users/Hixie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hixie/subscriptions","organizations_url":"https://api.github.com/users/Hixie/orgs","repos_url":"https://api.github.com/users/Hixie/repos","events_url":"https://api.github.com/users/Hixie/events{/privacy}","received_events_url":"https://api.github.com/users/Hixie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Hixie/sky_engine","description":"The Sky engine","fork":true,"url":"https://api.github.com/repos/Hixie/sky_engine","forks_url":"https://api.github.com/repos/Hixie/sky_engine/forks","keys_url":"https://api.github.com/repos/Hixie/sky_engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Hixie/sky_engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Hixie/sky_engine/teams","hooks_url":"https://api.github.com/repos/Hixie/sky_engine/hooks","issue_events_url":"https://api.github.com/repos/Hixie/sky_engine/issues/events{/number}","events_url":"https://api.github.com/repos/Hixie/sky_engine/events","assignees_url":"https://api.github.com/repos/Hixie/sky_engine/assignees{/user}","branches_url":"https://api.github.com/repos/Hixie/sky_engine/branches{/branch}","tags_url":"https://api.github.com/repos/Hixie/sky_engine/tags","blobs_url":"https://api.github.com/repos/Hixie/sky_engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Hixie/sky_engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Hixie/sky_engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/Hixie/sky_engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Hixie/sky_engine/statuses/{sha}","languages_url":"https://api.github.com/repos/Hixie/sky_engine/languages","stargazers_url":"https://api.github.com/repos/Hixie/sky_engine/stargazers","contributors_url":"https://api.github.com/repos/Hixie/sky_engine/contributors","subscribers_url":"https://api.github.com/repos/Hixie/sky_engine/subscribers","subscription_url":"https://api.github.com/repos/Hixie/sky_engine/subscription","commits_url":"https://api.github.com/repos/Hixie/sky_engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/Hixie/sky_engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/Hixie/sky_engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/Hixie/sky_engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/Hixie/sky_engine/contents/{+path}","compare_url":"https://api.github.com/repos/Hixie/sky_engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Hixie/sky_engine/merges","archive_url":"https://api.github.com/repos/Hixie/sky_engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Hixie/sky_engine/downloads","issues_url":"https://api.github.com/repos/Hixie/sky_engine/issues{/number}","pulls_url":"https://api.github.com/repos/Hixie/sky_engine/pulls{/number}","milestones_url":"https://api.github.com/repos/Hixie/sky_engine/milestones{/number}","notifications_url":"https://api.github.com/repos/Hixie/sky_engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Hixie/sky_engine/labels{/name}","releases_url":"https://api.github.com/repos/Hixie/sky_engine/releases{/id}","created_at":"2015-07-16T19:32:05Z","updated_at":"2015-07-16T19:32:25Z","pushed_at":"2015-09-29T19:54:09Z","git_url":"git://github.com/Hixie/sky_engine.git","ssh_url":"git@github.com:Hixie/sky_engine.git","clone_url":"https://github.com/Hixie/sky_engine.git","svn_url":"https://github.com/Hixie/sky_engine","homepage":null,"size":75986,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"flutter:master","ref":"master","sha":"eb6f2f069e55f53967d078e52dabfb6c05cb7eb9","user":{"login":"flutter","id":14101776,"avatar_url":"https://avatars.githubusercontent.com/u/14101776?v=3","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"repo":{"id":39211337,"name":"engine","full_name":"flutter/engine","owner":{"login":"flutter","id":14101776,"avatar_url":"https://avatars.githubusercontent.com/u/14101776?v=3","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/flutter/engine","description":"The Flutter engine","fork":false,"url":"https://api.github.com/repos/flutter/engine","forks_url":"https://api.github.com/repos/flutter/engine/forks","keys_url":"https://api.github.com/repos/flutter/engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flutter/engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flutter/engine/teams","hooks_url":"https://api.github.com/repos/flutter/engine/hooks","issue_events_url":"https://api.github.com/repos/flutter/engine/issues/events{/number}","events_url":"https://api.github.com/repos/flutter/engine/events","assignees_url":"https://api.github.com/repos/flutter/engine/assignees{/user}","branches_url":"https://api.github.com/repos/flutter/engine/branches{/branch}","tags_url":"https://api.github.com/repos/flutter/engine/tags","blobs_url":"https://api.github.com/repos/flutter/engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flutter/engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flutter/engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/flutter/engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flutter/engine/statuses/{sha}","languages_url":"https://api.github.com/repos/flutter/engine/languages","stargazers_url":"https://api.github.com/repos/flutter/engine/stargazers","contributors_url":"https://api.github.com/repos/flutter/engine/contributors","subscribers_url":"https://api.github.com/repos/flutter/engine/subscribers","subscription_url":"https://api.github.com/repos/flutter/engine/subscription","commits_url":"https://api.github.com/repos/flutter/engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/flutter/engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/flutter/engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/flutter/engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/flutter/engine/contents/{+path}","compare_url":"https://api.github.com/repos/flutter/engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flutter/engine/merges","archive_url":"https://api.github.com/repos/flutter/engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flutter/engine/downloads","issues_url":"https://api.github.com/repos/flutter/engine/issues{/number}","pulls_url":"https://api.github.com/repos/flutter/engine/pulls{/number}","milestones_url":"https://api.github.com/repos/flutter/engine/milestones{/number}","notifications_url":"https://api.github.com/repos/flutter/engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flutter/engine/labels{/name}","releases_url":"https://api.github.com/repos/flutter/engine/releases{/id}","created_at":"2015-07-16T17:39:56Z","updated_at":"2015-09-28T17:18:04Z","pushed_at":"2015-09-29T22:23:49Z","git_url":"git://github.com/flutter/engine.git","ssh_url":"git@github.com:flutter/engine.git","clone_url":"https://github.com/flutter/engine.git","svn_url":"https://github.com/flutter/engine","homepage":"http://flutter.io","size":87398,"stargazers_count":244,"watchers_count":244,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":66,"mirror_url":null,"open_issues_count":245,"forks":66,"open_issues":245,"watchers":244,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flutter/engine/pulls/1371"},"html":{"href":"https://github.com/flutter/engine/pull/1371"},"issue":{"href":"https://api.github.com/repos/flutter/engine/issues/1371"},"comments":{"href":"https://api.github.com/repos/flutter/engine/issues/1371/comments"},"review_comments":{"href":"https://api.github.com/repos/flutter/engine/pulls/1371/comments"},"review_comment":{"href":"https://api.github.com/repos/flutter/engine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flutter/engine/pulls/1371/commits"},"statuses":{"href":"https://api.github.com/repos/flutter/engine/statuses/e7ddb4ce78130336faf1a07c472526c3384d8536"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"Hixie","id":551196,"avatar_url":"https://avatars.githubusercontent.com/u/551196?v=3","gravatar_id":"","url":"https://api.github.com/users/Hixie","html_url":"https://github.com/Hixie","followers_url":"https://api.github.com/users/Hixie/followers","following_url":"https://api.github.com/users/Hixie/following{/other_user}","gists_url":"https://api.github.com/users/Hixie/gists{/gist_id}","starred_url":"https://api.github.com/users/Hixie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hixie/subscriptions","organizations_url":"https://api.github.com/users/Hixie/orgs","repos_url":"https://api.github.com/users/Hixie/repos","events_url":"https://api.github.com/users/Hixie/events{/privacy}","received_events_url":"https://api.github.com/users/Hixie/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":149,"deletions":29,"changed_files":5}}