{"action":"created","issue":{"url":"https://api.github.com/repos/dreamwidth/dw-free/issues/923","labels_url":"https://api.github.com/repos/dreamwidth/dw-free/issues/923/labels{/name}","comments_url":"https://api.github.com/repos/dreamwidth/dw-free/issues/923/comments","events_url":"https://api.github.com/repos/dreamwidth/dw-free/issues/923/events","html_url":"https://github.com/dreamwidth/dw-free/issues/923","id":39899985,"number":923,"title":"$r->connection->remote_ip removed on Apache 2.4","user":{"login":"anall","id":12371,"avatar_url":"https://avatars.githubusercontent.com/u/12371?v=3","gravatar_id":"","url":"https://api.github.com/users/anall","html_url":"https://github.com/anall","followers_url":"https://api.github.com/users/anall/followers","following_url":"https://api.github.com/users/anall/following{/other_user}","gists_url":"https://api.github.com/users/anall/gists{/gist_id}","starred_url":"https://api.github.com/users/anall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anall/subscriptions","organizations_url":"https://api.github.com/users/anall/orgs","repos_url":"https://api.github.com/users/anall/repos","events_url":"https://api.github.com/users/anall/events{/privacy}","received_events_url":"https://api.github.com/users/anall/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/dreamwidth/dw-free/labels/effort:%20(2)%20average","name":"effort: (2) average","color":"0052cc"},{"url":"https://api.github.com/repos/dreamwidth/dw-free/labels/severity:%20(1)%20minor","name":"severity: (1) minor","color":"fbca04"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":10,"created_at":"2014-08-10T03:24:08Z","updated_at":"2015-02-14T04:10:05Z","closed_at":null,"body":"Apache 2.4 / mod_perl 2.4 have removed `$r->connection->remote_ip` -- Replacements are either `$r->connection->client_ip` ( closest load balancer, I think ) and `$r->useragent_ip` ( actual user IP -- may not be secure depending on how the `X-Forwarded-For` headers are trusted in upstream proxies ) seem to be the possible replacements.\r\n\r\n`$r->useragent_ip` seems to be the correct replacement, however I am unsure if that works on pre-2.4 and do not have easy access to check.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/dreamwidth/dw-free/issues/comments/74360661","html_url":"https://github.com/dreamwidth/dw-free/issues/923#issuecomment-74360661","issue_url":"https://api.github.com/repos/dreamwidth/dw-free/issues/923","id":74360661,"user":{"login":"zorkian","id":361428,"avatar_url":"https://avatars.githubusercontent.com/u/361428?v=3","gravatar_id":"","url":"https://api.github.com/users/zorkian","html_url":"https://github.com/zorkian","followers_url":"https://api.github.com/users/zorkian/followers","following_url":"https://api.github.com/users/zorkian/following{/other_user}","gists_url":"https://api.github.com/users/zorkian/gists{/gist_id}","starred_url":"https://api.github.com/users/zorkian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zorkian/subscriptions","organizations_url":"https://api.github.com/users/zorkian/orgs","repos_url":"https://api.github.com/users/zorkian/repos","events_url":"https://api.github.com/users/zorkian/events{/privacy}","received_events_url":"https://api.github.com/users/zorkian/received_events","type":"User","site_admin":false},"created_at":"2015-02-14T04:10:05Z","updated_at":"2015-02-14T04:10:05Z","body":"Oh yeah. I have a crappy patch in my new 2.4 hack, I am using `client_ip`. I looked at the source code between 2.2 and 2.4 and they just renamed `remote_ip` to `client_ip`.\r\n\r\nGenerally we can't use `useragent_ip` unless we want to get rid of the ability to turn off trusting `X-Forwarded-For`. Which, honestly, I'd be OK with.  That would simplify a bunch of our code since we could just say \"we trust, put a proxy in front\"."}}