{"action":"created","issue":{"url":"https://api.github.com/repos/fabric8io/fluent-plugin-kubernetes_metadata_filter/issues/6","labels_url":"https://api.github.com/repos/fabric8io/fluent-plugin-kubernetes_metadata_filter/issues/6/labels{/name}","comments_url":"https://api.github.com/repos/fabric8io/fluent-plugin-kubernetes_metadata_filter/issues/6/comments","events_url":"https://api.github.com/repos/fabric8io/fluent-plugin-kubernetes_metadata_filter/issues/6/events","html_url":"https://github.com/fabric8io/fluent-plugin-kubernetes_metadata_filter/pull/6","id":105506448,"number":6,"title":"Add an include_namespace_id option that watches the namespaces in the","user":{"login":"a-robinson","id":7085343,"avatar_url":"https://avatars.githubusercontent.com/u/7085343?v=3","gravatar_id":"","url":"https://api.github.com/users/a-robinson","html_url":"https://github.com/a-robinson","followers_url":"https://api.github.com/users/a-robinson/followers","following_url":"https://api.github.com/users/a-robinson/following{/other_user}","gists_url":"https://api.github.com/users/a-robinson/gists{/gist_id}","starred_url":"https://api.github.com/users/a-robinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-robinson/subscriptions","organizations_url":"https://api.github.com/users/a-robinson/orgs","repos_url":"https://api.github.com/users/a-robinson/repos","events_url":"https://api.github.com/users/a-robinson/events{/privacy}","received_events_url":"https://api.github.com/users/a-robinson/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-09-09T02:34:14Z","updated_at":"2015-09-09T17:58:59Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/fabric8io/fluent-plugin-kubernetes_metadata_filter/pulls/6","html_url":"https://github.com/fabric8io/fluent-plugin-kubernetes_metadata_filter/pull/6","diff_url":"https://github.com/fabric8io/fluent-plugin-kubernetes_metadata_filter/pull/6.diff","patch_url":"https://github.com/fabric8io/fluent-plugin-kubernetes_metadata_filter/pull/6.patch"},"body":"cluster in order to be able to attach the namespace ID to log records if\r\nrequested.\r\n\r\nAlso change the field names from 'uid' to 'pod_id' and 'namespace' to\r\n'namespace_name'. I'm happy to change either back if you'd like, but I\r\nthink this way is clearer.\r\n\r\nI've verified this to work as desired in conjunction with my recent\r\nout_google_cloud change.\r\n\r\nI'll hopefully have time to add tests later tonight, but if not I'll get to them tomorrow morning.\r\n\r\n@jimmidyson @mr-salty @brendandburns"},"comment":{"url":"https://api.github.com/repos/fabric8io/fluent-plugin-kubernetes_metadata_filter/issues/comments/138990850","html_url":"https://github.com/fabric8io/fluent-plugin-kubernetes_metadata_filter/pull/6#issuecomment-138990850","issue_url":"https://api.github.com/repos/fabric8io/fluent-plugin-kubernetes_metadata_filter/issues/6","id":138990850,"user":{"login":"a-robinson","id":7085343,"avatar_url":"https://avatars.githubusercontent.com/u/7085343?v=3","gravatar_id":"","url":"https://api.github.com/users/a-robinson","html_url":"https://github.com/a-robinson","followers_url":"https://api.github.com/users/a-robinson/followers","following_url":"https://api.github.com/users/a-robinson/following{/other_user}","gists_url":"https://api.github.com/users/a-robinson/gists{/gist_id}","starred_url":"https://api.github.com/users/a-robinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-robinson/subscriptions","organizations_url":"https://api.github.com/users/a-robinson/orgs","repos_url":"https://api.github.com/users/a-robinson/repos","events_url":"https://api.github.com/users/a-robinson/events{/privacy}","received_events_url":"https://api.github.com/users/a-robinson/received_events","type":"User","site_admin":false},"created_at":"2015-09-09T17:58:59Z","updated_at":"2015-09-09T17:58:59Z","body":"I'm not convinced that namespace id is useful either, given that the pod UID + container name already uniquely identifies the source of the logs across pod deletions and recreations. It's only really useful in the case that you delete and recreate your namespace if you want to be able to notice that everything in the new namespace afterwards is in a different namespace than before.\r\n\r\nUnfortunately, I'm kind of stuck. I'm doing this is due to the schema requirements that the Google cloud logging/monitoring folks have put in place around using unique IDs rather than names. At this point, given that it's what monitoring is using, it's tough to justify changing it for logging. I'll revisit it with them, but more as feedback than as expecting a change.\r\n\r\nIf you don't want to take this addition, which is perfectly fair, my next step will be to move both the pod and namespace watching logic into the out_google_cloud plugin directly. That may be the best move anyway, given that it has the added benefit of cutting out all the json parsing necessitated by this being a separate plugin."}}