{"action":"created","issue":{"url":"https://api.github.com/repos/PyTables/PyTables/issues/463","labels_url":"https://api.github.com/repos/PyTables/PyTables/issues/463/labels{/name}","comments_url":"https://api.github.com/repos/PyTables/PyTables/issues/463/comments","events_url":"https://api.github.com/repos/PyTables/PyTables/issues/463/events","html_url":"https://github.com/PyTables/PyTables/pull/463","id":81367656,"number":463,"title":"Allow slashes in attribute names","user":{"login":"mythsmith","id":1889232,"avatar_url":"https://avatars.githubusercontent.com/u/1889232?v=3","gravatar_id":"","url":"https://api.github.com/users/mythsmith","html_url":"https://github.com/mythsmith","followers_url":"https://api.github.com/users/mythsmith/followers","following_url":"https://api.github.com/users/mythsmith/following{/other_user}","gists_url":"https://api.github.com/users/mythsmith/gists{/gist_id}","starred_url":"https://api.github.com/users/mythsmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mythsmith/subscriptions","organizations_url":"https://api.github.com/users/mythsmith/orgs","repos_url":"https://api.github.com/users/mythsmith/repos","events_url":"https://api.github.com/users/mythsmith/events{/privacy}","received_events_url":"https://api.github.com/users/mythsmith/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-05-27T09:29:48Z","updated_at":"2015-05-28T06:35:46Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/PyTables/PyTables/pulls/463","html_url":"https://github.com/PyTables/PyTables/pull/463","diff_url":"https://github.com/PyTables/PyTables/pull/463.diff","patch_url":"https://github.com/PyTables/PyTables/pull/463.patch"},"body":"Added allow_slash=False parameter to tables.path.check_name_validity.\r\nPass allow_slash=True when checking attribute names in AttributeSet.__setattr__.\r\nAdded doctest for tables/path.py\r\nAdded attribute names test in test_attributes.py.\r\nissue #462 "},"comment":{"url":"https://api.github.com/repos/PyTables/PyTables/issues/comments/106196437","html_url":"https://github.com/PyTables/PyTables/pull/463#issuecomment-106196437","issue_url":"https://api.github.com/repos/PyTables/PyTables/issues/463","id":106196437,"user":{"login":"mythsmith","id":1889232,"avatar_url":"https://avatars.githubusercontent.com/u/1889232?v=3","gravatar_id":"","url":"https://api.github.com/users/mythsmith","html_url":"https://github.com/mythsmith","followers_url":"https://api.github.com/users/mythsmith/followers","following_url":"https://api.github.com/users/mythsmith/following{/other_user}","gists_url":"https://api.github.com/users/mythsmith/gists{/gist_id}","starred_url":"https://api.github.com/users/mythsmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mythsmith/subscriptions","organizations_url":"https://api.github.com/users/mythsmith/orgs","repos_url":"https://api.github.com/users/mythsmith/repos","events_url":"https://api.github.com/users/mythsmith/events{/privacy}","received_events_url":"https://api.github.com/users/mythsmith/received_events","type":"User","site_admin":false},"created_at":"2015-05-28T06:35:46Z","updated_at":"2015-05-28T06:35:46Z","body":"I splitted in two functions: check_attribute_name and check_name_validity. The second simply calls the first, then adds a couple of checks.\r\n\r\nI ended up doing a new pull request with cleaned history: #464\r\n"}}