{"action":"created","comment":{"url":"https://api.github.com/repos/deepthawtz/faker/pulls/comments/36290702","id":36290702,"diff_hunk":"@@ -1,6 +1,6 @@\n # Python 2/3 compat\n import sys\n-if sys.version < '3':\n+if sys.version_info[0] < 3:","path":"faker/compat.py","position":4,"original_position":4,"commit_id":"825439850c71bd14727818b0358ab7cb82eb2820","original_commit_id":"825439850c71bd14727818b0358ab7cb82eb2820","user":{"login":"svisser","id":723226,"avatar_url":"https://avatars.githubusercontent.com/u/723226?v=3","gravatar_id":"","url":"https://api.github.com/users/svisser","html_url":"https://github.com/svisser","followers_url":"https://api.github.com/users/svisser/followers","following_url":"https://api.github.com/users/svisser/following{/other_user}","gists_url":"https://api.github.com/users/svisser/gists{/gist_id}","starred_url":"https://api.github.com/users/svisser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/svisser/subscriptions","organizations_url":"https://api.github.com/users/svisser/orgs","repos_url":"https://api.github.com/users/svisser/repos","events_url":"https://api.github.com/users/svisser/events{/privacy}","received_events_url":"https://api.github.com/users/svisser/received_events","type":"User","site_admin":false},"body":"The pull request is about a year old now; I'm not sure I should make that change when it makes little difference.","created_at":"2015-08-05T11:11:15Z","updated_at":"2015-08-05T11:11:15Z","html_url":"https://github.com/deepthawtz/faker/pull/11#discussion_r36290702","pull_request_url":"https://api.github.com/repos/deepthawtz/faker/pulls/11","_links":{"self":{"href":"https://api.github.com/repos/deepthawtz/faker/pulls/comments/36290702"},"html":{"href":"https://github.com/deepthawtz/faker/pull/11#discussion_r36290702"},"pull_request":{"href":"https://api.github.com/repos/deepthawtz/faker/pulls/11"}}},"pull_request":{"url":"https://api.github.com/repos/deepthawtz/faker/pulls/11","id":21197774,"html_url":"https://github.com/deepthawtz/faker/pull/11","diff_url":"https://github.com/deepthawtz/faker/pull/11.diff","patch_url":"https://github.com/deepthawtz/faker/pull/11.patch","issue_url":"https://api.github.com/repos/deepthawtz/faker/issues/11","number":11,"state":"open","locked":false,"title":"Changed Python version check to use sys.version_info","user":{"login":"svisser","id":723226,"avatar_url":"https://avatars.githubusercontent.com/u/723226?v=3","gravatar_id":"","url":"https://api.github.com/users/svisser","html_url":"https://github.com/svisser","followers_url":"https://api.github.com/users/svisser/followers","following_url":"https://api.github.com/users/svisser/following{/other_user}","gists_url":"https://api.github.com/users/svisser/gists{/gist_id}","starred_url":"https://api.github.com/users/svisser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/svisser/subscriptions","organizations_url":"https://api.github.com/users/svisser/orgs","repos_url":"https://api.github.com/users/svisser/repos","events_url":"https://api.github.com/users/svisser/events{/privacy}","received_events_url":"https://api.github.com/users/svisser/received_events","type":"User","site_admin":false},"body":"The string `sys.version` should not be used for version checks as there's no guarantee the version number is at the beginning of the string. Instead the value `sys.version_info` should be used.","created_at":"2014-09-13T21:52:25Z","updated_at":"2015-08-05T11:11:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f93ff587608cddf62e1c944156c6426353a0bf1b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/deepthawtz/faker/pulls/11/commits","review_comments_url":"https://api.github.com/repos/deepthawtz/faker/pulls/11/comments","review_comment_url":"https://api.github.com/repos/deepthawtz/faker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/deepthawtz/faker/issues/11/comments","statuses_url":"https://api.github.com/repos/deepthawtz/faker/statuses/825439850c71bd14727818b0358ab7cb82eb2820","head":{"label":"svisser:patch-1","ref":"patch-1","sha":"825439850c71bd14727818b0358ab7cb82eb2820","user":{"login":"svisser","id":723226,"avatar_url":"https://avatars.githubusercontent.com/u/723226?v=3","gravatar_id":"","url":"https://api.github.com/users/svisser","html_url":"https://github.com/svisser","followers_url":"https://api.github.com/users/svisser/followers","following_url":"https://api.github.com/users/svisser/following{/other_user}","gists_url":"https://api.github.com/users/svisser/gists{/gist_id}","starred_url":"https://api.github.com/users/svisser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/svisser/subscriptions","organizations_url":"https://api.github.com/users/svisser/orgs","repos_url":"https://api.github.com/users/svisser/repos","events_url":"https://api.github.com/users/svisser/events{/privacy}","received_events_url":"https://api.github.com/users/svisser/received_events","type":"User","site_admin":false},"repo":{"id":24006779,"name":"faker","full_name":"svisser/faker","owner":{"login":"svisser","id":723226,"avatar_url":"https://avatars.githubusercontent.com/u/723226?v=3","gravatar_id":"","url":"https://api.github.com/users/svisser","html_url":"https://github.com/svisser","followers_url":"https://api.github.com/users/svisser/followers","following_url":"https://api.github.com/users/svisser/following{/other_user}","gists_url":"https://api.github.com/users/svisser/gists{/gist_id}","starred_url":"https://api.github.com/users/svisser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/svisser/subscriptions","organizations_url":"https://api.github.com/users/svisser/orgs","repos_url":"https://api.github.com/users/svisser/repos","events_url":"https://api.github.com/users/svisser/events{/privacy}","received_events_url":"https://api.github.com/users/svisser/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/svisser/faker","description":"A Python library for generating fake user data.","fork":true,"url":"https://api.github.com/repos/svisser/faker","forks_url":"https://api.github.com/repos/svisser/faker/forks","keys_url":"https://api.github.com/repos/svisser/faker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/svisser/faker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/svisser/faker/teams","hooks_url":"https://api.github.com/repos/svisser/faker/hooks","issue_events_url":"https://api.github.com/repos/svisser/faker/issues/events{/number}","events_url":"https://api.github.com/repos/svisser/faker/events","assignees_url":"https://api.github.com/repos/svisser/faker/assignees{/user}","branches_url":"https://api.github.com/repos/svisser/faker/branches{/branch}","tags_url":"https://api.github.com/repos/svisser/faker/tags","blobs_url":"https://api.github.com/repos/svisser/faker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/svisser/faker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/svisser/faker/git/refs{/sha}","trees_url":"https://api.github.com/repos/svisser/faker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/svisser/faker/statuses/{sha}","languages_url":"https://api.github.com/repos/svisser/faker/languages","stargazers_url":"https://api.github.com/repos/svisser/faker/stargazers","contributors_url":"https://api.github.com/repos/svisser/faker/contributors","subscribers_url":"https://api.github.com/repos/svisser/faker/subscribers","subscription_url":"https://api.github.com/repos/svisser/faker/subscription","commits_url":"https://api.github.com/repos/svisser/faker/commits{/sha}","git_commits_url":"https://api.github.com/repos/svisser/faker/git/commits{/sha}","comments_url":"https://api.github.com/repos/svisser/faker/comments{/number}","issue_comment_url":"https://api.github.com/repos/svisser/faker/issues/comments{/number}","contents_url":"https://api.github.com/repos/svisser/faker/contents/{+path}","compare_url":"https://api.github.com/repos/svisser/faker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/svisser/faker/merges","archive_url":"https://api.github.com/repos/svisser/faker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/svisser/faker/downloads","issues_url":"https://api.github.com/repos/svisser/faker/issues{/number}","pulls_url":"https://api.github.com/repos/svisser/faker/pulls{/number}","milestones_url":"https://api.github.com/repos/svisser/faker/milestones{/number}","notifications_url":"https://api.github.com/repos/svisser/faker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/svisser/faker/labels{/name}","releases_url":"https://api.github.com/repos/svisser/faker/releases{/id}","created_at":"2014-09-13T21:50:24Z","updated_at":"2014-08-11T18:35:49Z","pushed_at":"2014-09-13T21:51:54Z","git_url":"git://github.com/svisser/faker.git","ssh_url":"git@github.com:svisser/faker.git","clone_url":"https://github.com/svisser/faker.git","svn_url":"https://github.com/svisser/faker","homepage":"http://pypi.python.org/pypi/Faker","size":138,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"deepthawtz:master","ref":"master","sha":"5c045952dfecdadcb86f9595341ba69e52dcc009","user":{"login":"deepthawtz","id":31030,"avatar_url":"https://avatars.githubusercontent.com/u/31030?v=3","gravatar_id":"","url":"https://api.github.com/users/deepthawtz","html_url":"https://github.com/deepthawtz","followers_url":"https://api.github.com/users/deepthawtz/followers","following_url":"https://api.github.com/users/deepthawtz/following{/other_user}","gists_url":"https://api.github.com/users/deepthawtz/gists{/gist_id}","starred_url":"https://api.github.com/users/deepthawtz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deepthawtz/subscriptions","organizations_url":"https://api.github.com/users/deepthawtz/orgs","repos_url":"https://api.github.com/users/deepthawtz/repos","events_url":"https://api.github.com/users/deepthawtz/events{/privacy}","received_events_url":"https://api.github.com/users/deepthawtz/received_events","type":"User","site_admin":false},"repo":{"id":501613,"name":"faker","full_name":"deepthawtz/faker","owner":{"login":"deepthawtz","id":31030,"avatar_url":"https://avatars.githubusercontent.com/u/31030?v=3","gravatar_id":"","url":"https://api.github.com/users/deepthawtz","html_url":"https://github.com/deepthawtz","followers_url":"https://api.github.com/users/deepthawtz/followers","following_url":"https://api.github.com/users/deepthawtz/following{/other_user}","gists_url":"https://api.github.com/users/deepthawtz/gists{/gist_id}","starred_url":"https://api.github.com/users/deepthawtz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deepthawtz/subscriptions","organizations_url":"https://api.github.com/users/deepthawtz/orgs","repos_url":"https://api.github.com/users/deepthawtz/repos","events_url":"https://api.github.com/users/deepthawtz/events{/privacy}","received_events_url":"https://api.github.com/users/deepthawtz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/deepthawtz/faker","description":"A Python library for generating fake user data.","fork":false,"url":"https://api.github.com/repos/deepthawtz/faker","forks_url":"https://api.github.com/repos/deepthawtz/faker/forks","keys_url":"https://api.github.com/repos/deepthawtz/faker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/deepthawtz/faker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/deepthawtz/faker/teams","hooks_url":"https://api.github.com/repos/deepthawtz/faker/hooks","issue_events_url":"https://api.github.com/repos/deepthawtz/faker/issues/events{/number}","events_url":"https://api.github.com/repos/deepthawtz/faker/events","assignees_url":"https://api.github.com/repos/deepthawtz/faker/assignees{/user}","branches_url":"https://api.github.com/repos/deepthawtz/faker/branches{/branch}","tags_url":"https://api.github.com/repos/deepthawtz/faker/tags","blobs_url":"https://api.github.com/repos/deepthawtz/faker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/deepthawtz/faker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/deepthawtz/faker/git/refs{/sha}","trees_url":"https://api.github.com/repos/deepthawtz/faker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/deepthawtz/faker/statuses/{sha}","languages_url":"https://api.github.com/repos/deepthawtz/faker/languages","stargazers_url":"https://api.github.com/repos/deepthawtz/faker/stargazers","contributors_url":"https://api.github.com/repos/deepthawtz/faker/contributors","subscribers_url":"https://api.github.com/repos/deepthawtz/faker/subscribers","subscription_url":"https://api.github.com/repos/deepthawtz/faker/subscription","commits_url":"https://api.github.com/repos/deepthawtz/faker/commits{/sha}","git_commits_url":"https://api.github.com/repos/deepthawtz/faker/git/commits{/sha}","comments_url":"https://api.github.com/repos/deepthawtz/faker/comments{/number}","issue_comment_url":"https://api.github.com/repos/deepthawtz/faker/issues/comments{/number}","contents_url":"https://api.github.com/repos/deepthawtz/faker/contents/{+path}","compare_url":"https://api.github.com/repos/deepthawtz/faker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/deepthawtz/faker/merges","archive_url":"https://api.github.com/repos/deepthawtz/faker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/deepthawtz/faker/downloads","issues_url":"https://api.github.com/repos/deepthawtz/faker/issues{/number}","pulls_url":"https://api.github.com/repos/deepthawtz/faker/pulls{/number}","milestones_url":"https://api.github.com/repos/deepthawtz/faker/milestones{/number}","notifications_url":"https://api.github.com/repos/deepthawtz/faker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/deepthawtz/faker/labels{/name}","releases_url":"https://api.github.com/repos/deepthawtz/faker/releases{/id}","created_at":"2010-02-04T00:42:02Z","updated_at":"2015-05-11T11:56:45Z","pushed_at":"2015-06-10T06:23:53Z","git_url":"git://github.com/deepthawtz/faker.git","ssh_url":"git@github.com:deepthawtz/faker.git","clone_url":"https://github.com/deepthawtz/faker.git","svn_url":"https://github.com/deepthawtz/faker","homepage":"http://pypi.python.org/pypi/Faker","size":215,"stargazers_count":113,"watchers_count":113,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"open_issues_count":3,"forks":25,"open_issues":3,"watchers":113,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/deepthawtz/faker/pulls/11"},"html":{"href":"https://github.com/deepthawtz/faker/pull/11"},"issue":{"href":"https://api.github.com/repos/deepthawtz/faker/issues/11"},"comments":{"href":"https://api.github.com/repos/deepthawtz/faker/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/deepthawtz/faker/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/deepthawtz/faker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/deepthawtz/faker/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/deepthawtz/faker/statuses/825439850c71bd14727818b0358ab7cb82eb2820"}}}}