{"action":"created","issue":{"url":"https://api.github.com/repos/SFML/SFML/issues/942","labels_url":"https://api.github.com/repos/SFML/SFML/issues/942/labels{/name}","comments_url":"https://api.github.com/repos/SFML/SFML/issues/942/comments","events_url":"https://api.github.com/repos/SFML/SFML/issues/942/events","html_url":"https://github.com/SFML/SFML/pull/942","id":100882196,"number":942,"title":"Fixing #935: Secure function against random data return.","user":{"login":"susnux","id":1855448,"avatar_url":"https://avatars.githubusercontent.com/u/1855448?v=3","gravatar_id":"","url":"https://api.github.com/users/susnux","html_url":"https://github.com/susnux","followers_url":"https://api.github.com/users/susnux/followers","following_url":"https://api.github.com/users/susnux/following{/other_user}","gists_url":"https://api.github.com/users/susnux/gists{/gist_id}","starred_url":"https://api.github.com/users/susnux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/susnux/subscriptions","organizations_url":"https://api.github.com/users/susnux/orgs","repos_url":"https://api.github.com/users/susnux/repos","events_url":"https://api.github.com/users/susnux/events{/privacy}","received_events_url":"https://api.github.com/users/susnux/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/SFML/SFML/labels/bug","name":"bug","color":"ff4242"},{"url":"https://api.github.com/repos/SFML/SFML/labels/s:accepted","name":"s:accepted","color":"207de5"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/SFML/SFML/milestones/12","html_url":"https://github.com/SFML/SFML/milestones/2.3.2","labels_url":"https://api.github.com/repos/SFML/SFML/milestones/12/labels","id":1183626,"number":12,"title":"2.3.2","description":"","creator":{"login":"binary1248","id":949359,"avatar_url":"https://avatars.githubusercontent.com/u/949359?v=3","gravatar_id":"","url":"https://api.github.com/users/binary1248","html_url":"https://github.com/binary1248","followers_url":"https://api.github.com/users/binary1248/followers","following_url":"https://api.github.com/users/binary1248/following{/other_user}","gists_url":"https://api.github.com/users/binary1248/gists{/gist_id}","starred_url":"https://api.github.com/users/binary1248/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/binary1248/subscriptions","organizations_url":"https://api.github.com/users/binary1248/orgs","repos_url":"https://api.github.com/users/binary1248/repos","events_url":"https://api.github.com/users/binary1248/events{/privacy}","received_events_url":"https://api.github.com/users/binary1248/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":9,"state":"open","created_at":"2015-06-27T13:28:18Z","updated_at":"2015-08-19T22:59:59Z","due_on":null,"closed_at":null},"comments":9,"created_at":"2015-08-13T22:18:52Z","updated_at":"2015-08-19T23:02:07Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/SFML/SFML/pulls/942","html_url":"https://github.com/SFML/SFML/pull/942","diff_url":"https://github.com/SFML/SFML/pull/942.diff","patch_url":"https://github.com/SFML/SFML/pull/942.patch"},"body":"As described in bug #935, this will secure\r\nsf::Uint32 factorToGlConstant(sf::BlendMode::Factor blendFactor)\r\nand\r\nsf::Uint32 equationToGlConstant(sf::BlendMode::Equation blendEquation)\r\nfrom RenderTarget.cpp against returning random data.\r\nThe common consent was to apply the patch and add an assert on top.\r\n\r\nSee also discussion in bug report #935."},"comment":{"url":"https://api.github.com/repos/SFML/SFML/issues/comments/132819249","html_url":"https://github.com/SFML/SFML/pull/942#issuecomment-132819249","issue_url":"https://api.github.com/repos/SFML/SFML/issues/942","id":132819249,"user":{"login":"eXpl0it3r","id":920861,"avatar_url":"https://avatars.githubusercontent.com/u/920861?v=3","gravatar_id":"","url":"https://api.github.com/users/eXpl0it3r","html_url":"https://github.com/eXpl0it3r","followers_url":"https://api.github.com/users/eXpl0it3r/followers","following_url":"https://api.github.com/users/eXpl0it3r/following{/other_user}","gists_url":"https://api.github.com/users/eXpl0it3r/gists{/gist_id}","starred_url":"https://api.github.com/users/eXpl0it3r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eXpl0it3r/subscriptions","organizations_url":"https://api.github.com/users/eXpl0it3r/orgs","repos_url":"https://api.github.com/users/eXpl0it3r/repos","events_url":"https://api.github.com/users/eXpl0it3r/events{/privacy}","received_events_url":"https://api.github.com/users/eXpl0it3r/received_events","type":"User","site_admin":false},"created_at":"2015-08-19T23:02:06Z","updated_at":"2015-08-19T23:02:06Z","body":"This PR has been added to my merge list, meaning it will be merged soon into the 2.3.x branch, unless someone raises any concerns."}}