{"action":"created","comment":{"url":"https://api.github.com/repos/angular/ts2dart/pulls/comments/27709099","id":27709099,"diff_hunk":"@@ -5,6 +5,8 @@ require('source-map-support').install();\n import ts = require(\"typescript\");\n import fs = require(\"fs\");\n \n+export enum DART_KEYWORD_KIND { RESERVED = 0, BUILTIN = 1, LIMITED = 2 };","path":"lib/main.ts","position":4,"original_position":4,"commit_id":"5ff9a5f251dbae314af59db15ab6239324897a12","original_commit_id":"5ff9a5f251dbae314af59db15ab6239324897a12","user":{"login":"chalin","id":4140793,"avatar_url":"https://avatars.githubusercontent.com/u/4140793?v=3","gravatar_id":"","url":"https://api.github.com/users/chalin","html_url":"https://github.com/chalin","followers_url":"https://api.github.com/users/chalin/followers","following_url":"https://api.github.com/users/chalin/following{/other_user}","gists_url":"https://api.github.com/users/chalin/gists{/gist_id}","starred_url":"https://api.github.com/users/chalin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chalin/subscriptions","organizations_url":"https://api.github.com/users/chalin/orgs","repos_url":"https://api.github.com/users/chalin/repos","events_url":"https://api.github.com/users/chalin/events{/privacy}","received_events_url":"https://api.github.com/users/chalin/received_events","type":"User","site_admin":false},"body":"I had tried that earlier. It doesn't work.","created_at":"2015-04-03T00:25:19Z","updated_at":"2015-04-03T00:25:19Z","html_url":"https://github.com/angular/ts2dart/pull/115#discussion_r27709099","pull_request_url":"https://api.github.com/repos/angular/ts2dart/pulls/115","_links":{"self":{"href":"https://api.github.com/repos/angular/ts2dart/pulls/comments/27709099"},"html":{"href":"https://github.com/angular/ts2dart/pull/115#discussion_r27709099"},"pull_request":{"href":"https://api.github.com/repos/angular/ts2dart/pulls/115"}}},"pull_request":{"url":"https://api.github.com/repos/angular/ts2dart/pulls/115","id":32475773,"html_url":"https://github.com/angular/ts2dart/pull/115","diff_url":"https://github.com/angular/ts2dart/pull/115.diff","patch_url":"https://github.com/angular/ts2dart/pull/115.patch","issue_url":"https://api.github.com/repos/angular/ts2dart/issues/115","number":115,"state":"open","locked":false,"title":"Refine identifying keyword kind (in prep for fix)","user":{"login":"chalin","id":4140793,"avatar_url":"https://avatars.githubusercontent.com/u/4140793?v=3","gravatar_id":"","url":"https://api.github.com/users/chalin","html_url":"https://github.com/chalin","followers_url":"https://api.github.com/users/chalin/followers","following_url":"https://api.github.com/users/chalin/following{/other_user}","gists_url":"https://api.github.com/users/chalin/gists{/gist_id}","starred_url":"https://api.github.com/users/chalin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chalin/subscriptions","organizations_url":"https://api.github.com/users/chalin/orgs","repos_url":"https://api.github.com/users/chalin/repos","events_url":"https://api.github.com/users/chalin/events{/privacy}","received_events_url":"https://api.github.com/users/chalin/received_events","type":"User","site_admin":false},"body":"* This is preparatory work for #113.\r\n* Note that there are **three kinds of keywords**: reserved, built-in, and\r\nlimited. Only reserved words must be avoided when porting from JS to\r\nDart (see [footnote 1 in Dart Up and Running Chap. 2](https://www.dartlang.org/docs/dart-up-and-running/ch02.html#keywords)).\r\n* `getLibraryName()` has been tweaked to only rename libraries having names that\r\nmatch a *reserved word*. If this change causes problems when run over the\r\nAngular code base, then the condition can be changed to `>=\r\nDART_KEYWORD_KIND.RESERVED` to recover the current behavior.","created_at":"2015-04-02T01:13:39Z","updated_at":"2015-04-03T00:25:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"df0c245f3ae2d59058160139feeb5dc6ae257542","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/angular/ts2dart/pulls/115/commits","review_comments_url":"https://api.github.com/repos/angular/ts2dart/pulls/115/comments","review_comment_url":"https://api.github.com/repos/angular/ts2dart/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/ts2dart/issues/115/comments","statuses_url":"https://api.github.com/repos/angular/ts2dart/statuses/5ff9a5f251dbae314af59db15ab6239324897a12","head":{"label":"chalin:chalin-0401-keyword-rework","ref":"chalin-0401-keyword-rework","sha":"5ff9a5f251dbae314af59db15ab6239324897a12","user":{"login":"chalin","id":4140793,"avatar_url":"https://avatars.githubusercontent.com/u/4140793?v=3","gravatar_id":"","url":"https://api.github.com/users/chalin","html_url":"https://github.com/chalin","followers_url":"https://api.github.com/users/chalin/followers","following_url":"https://api.github.com/users/chalin/following{/other_user}","gists_url":"https://api.github.com/users/chalin/gists{/gist_id}","starred_url":"https://api.github.com/users/chalin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chalin/subscriptions","organizations_url":"https://api.github.com/users/chalin/orgs","repos_url":"https://api.github.com/users/chalin/repos","events_url":"https://api.github.com/users/chalin/events{/privacy}","received_events_url":"https://api.github.com/users/chalin/received_events","type":"User","site_admin":false},"repo":{"id":32438125,"name":"ts2dart","full_name":"chalin/ts2dart","owner":{"login":"chalin","id":4140793,"avatar_url":"https://avatars.githubusercontent.com/u/4140793?v=3","gravatar_id":"","url":"https://api.github.com/users/chalin","html_url":"https://github.com/chalin","followers_url":"https://api.github.com/users/chalin/followers","following_url":"https://api.github.com/users/chalin/following{/other_user}","gists_url":"https://api.github.com/users/chalin/gists{/gist_id}","starred_url":"https://api.github.com/users/chalin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chalin/subscriptions","organizations_url":"https://api.github.com/users/chalin/orgs","repos_url":"https://api.github.com/users/chalin/repos","events_url":"https://api.github.com/users/chalin/events{/privacy}","received_events_url":"https://api.github.com/users/chalin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chalin/ts2dart","description":"","fork":true,"url":"https://api.github.com/repos/chalin/ts2dart","forks_url":"https://api.github.com/repos/chalin/ts2dart/forks","keys_url":"https://api.github.com/repos/chalin/ts2dart/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chalin/ts2dart/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chalin/ts2dart/teams","hooks_url":"https://api.github.com/repos/chalin/ts2dart/hooks","issue_events_url":"https://api.github.com/repos/chalin/ts2dart/issues/events{/number}","events_url":"https://api.github.com/repos/chalin/ts2dart/events","assignees_url":"https://api.github.com/repos/chalin/ts2dart/assignees{/user}","branches_url":"https://api.github.com/repos/chalin/ts2dart/branches{/branch}","tags_url":"https://api.github.com/repos/chalin/ts2dart/tags","blobs_url":"https://api.github.com/repos/chalin/ts2dart/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chalin/ts2dart/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chalin/ts2dart/git/refs{/sha}","trees_url":"https://api.github.com/repos/chalin/ts2dart/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chalin/ts2dart/statuses/{sha}","languages_url":"https://api.github.com/repos/chalin/ts2dart/languages","stargazers_url":"https://api.github.com/repos/chalin/ts2dart/stargazers","contributors_url":"https://api.github.com/repos/chalin/ts2dart/contributors","subscribers_url":"https://api.github.com/repos/chalin/ts2dart/subscribers","subscription_url":"https://api.github.com/repos/chalin/ts2dart/subscription","commits_url":"https://api.github.com/repos/chalin/ts2dart/commits{/sha}","git_commits_url":"https://api.github.com/repos/chalin/ts2dart/git/commits{/sha}","comments_url":"https://api.github.com/repos/chalin/ts2dart/comments{/number}","issue_comment_url":"https://api.github.com/repos/chalin/ts2dart/issues/comments{/number}","contents_url":"https://api.github.com/repos/chalin/ts2dart/contents/{+path}","compare_url":"https://api.github.com/repos/chalin/ts2dart/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chalin/ts2dart/merges","archive_url":"https://api.github.com/repos/chalin/ts2dart/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chalin/ts2dart/downloads","issues_url":"https://api.github.com/repos/chalin/ts2dart/issues{/number}","pulls_url":"https://api.github.com/repos/chalin/ts2dart/pulls{/number}","milestones_url":"https://api.github.com/repos/chalin/ts2dart/milestones{/number}","notifications_url":"https://api.github.com/repos/chalin/ts2dart/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chalin/ts2dart/labels{/name}","releases_url":"https://api.github.com/repos/chalin/ts2dart/releases{/id}","created_at":"2015-03-18T04:36:35Z","updated_at":"2015-04-03T00:06:24Z","pushed_at":"2015-04-03T00:06:24Z","git_url":"git://github.com/chalin/ts2dart.git","ssh_url":"git@github.com:chalin/ts2dart.git","clone_url":"https://github.com/chalin/ts2dart.git","svn_url":"https://github.com/chalin/ts2dart","homepage":null,"size":264,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"e8bf69eb6306adbf484d6b8d215a42b0c99d3396","user":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":32405591,"name":"ts2dart","full_name":"angular/ts2dart","owner":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/ts2dart","description":"ts2dart TypeScript to Dart transpiler","fork":false,"url":"https://api.github.com/repos/angular/ts2dart","forks_url":"https://api.github.com/repos/angular/ts2dart/forks","keys_url":"https://api.github.com/repos/angular/ts2dart/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/ts2dart/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/ts2dart/teams","hooks_url":"https://api.github.com/repos/angular/ts2dart/hooks","issue_events_url":"https://api.github.com/repos/angular/ts2dart/issues/events{/number}","events_url":"https://api.github.com/repos/angular/ts2dart/events","assignees_url":"https://api.github.com/repos/angular/ts2dart/assignees{/user}","branches_url":"https://api.github.com/repos/angular/ts2dart/branches{/branch}","tags_url":"https://api.github.com/repos/angular/ts2dart/tags","blobs_url":"https://api.github.com/repos/angular/ts2dart/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/ts2dart/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/ts2dart/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/ts2dart/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/ts2dart/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/ts2dart/languages","stargazers_url":"https://api.github.com/repos/angular/ts2dart/stargazers","contributors_url":"https://api.github.com/repos/angular/ts2dart/contributors","subscribers_url":"https://api.github.com/repos/angular/ts2dart/subscribers","subscription_url":"https://api.github.com/repos/angular/ts2dart/subscription","commits_url":"https://api.github.com/repos/angular/ts2dart/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/ts2dart/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/ts2dart/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/ts2dart/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/ts2dart/contents/{+path}","compare_url":"https://api.github.com/repos/angular/ts2dart/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/ts2dart/merges","archive_url":"https://api.github.com/repos/angular/ts2dart/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/ts2dart/downloads","issues_url":"https://api.github.com/repos/angular/ts2dart/issues{/number}","pulls_url":"https://api.github.com/repos/angular/ts2dart/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/ts2dart/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/ts2dart/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/ts2dart/labels{/name}","releases_url":"https://api.github.com/repos/angular/ts2dart/releases{/id}","created_at":"2015-03-17T16:28:22Z","updated_at":"2015-04-02T22:15:15Z","pushed_at":"2015-04-02T22:20:52Z","git_url":"git://github.com/angular/ts2dart.git","ssh_url":"git@github.com:angular/ts2dart.git","clone_url":"https://github.com/angular/ts2dart.git","svn_url":"https://github.com/angular/ts2dart","homepage":"","size":1851,"stargazers_count":13,"watchers_count":13,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":11,"forks":3,"open_issues":11,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/ts2dart/pulls/115"},"html":{"href":"https://github.com/angular/ts2dart/pull/115"},"issue":{"href":"https://api.github.com/repos/angular/ts2dart/issues/115"},"comments":{"href":"https://api.github.com/repos/angular/ts2dart/issues/115/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/ts2dart/pulls/115/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/ts2dart/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/ts2dart/pulls/115/commits"},"statuses":{"href":"https://api.github.com/repos/angular/ts2dart/statuses/5ff9a5f251dbae314af59db15ab6239324897a12"}}}}