{"action":"created","issue":{"url":"https://api.github.com/repos/sqlectron/sqlectron-core/issues/7","labels_url":"https://api.github.com/repos/sqlectron/sqlectron-core/issues/7/labels{/name}","comments_url":"https://api.github.com/repos/sqlectron/sqlectron-core/issues/7/comments","events_url":"https://api.github.com/repos/sqlectron/sqlectron-core/issues/7/events","html_url":"https://github.com/sqlectron/sqlectron-core/pull/7","id":121156150,"number":7,"title":"adding sqlserver","user":{"login":"luisrudge","id":941075,"avatar_url":"https://avatars.githubusercontent.com/u/941075?v=3","gravatar_id":"","url":"https://api.github.com/users/luisrudge","html_url":"https://github.com/luisrudge","followers_url":"https://api.github.com/users/luisrudge/followers","following_url":"https://api.github.com/users/luisrudge/following{/other_user}","gists_url":"https://api.github.com/users/luisrudge/gists{/gist_id}","starred_url":"https://api.github.com/users/luisrudge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luisrudge/subscriptions","organizations_url":"https://api.github.com/users/luisrudge/orgs","repos_url":"https://api.github.com/users/luisrudge/repos","events_url":"https://api.github.com/users/luisrudge/events{/privacy}","received_events_url":"https://api.github.com/users/luisrudge/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2015-12-09T04:13:32Z","updated_at":"2015-12-09T17:44:05Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/sqlectron/sqlectron-core/pulls/7","html_url":"https://github.com/sqlectron/sqlectron-core/pull/7","diff_url":"https://github.com/sqlectron/sqlectron-core/pull/7.diff","patch_url":"https://github.com/sqlectron/sqlectron-core/pull/7.patch"},"body":"fix #2 \r\n\r\n# YO!\r\n All tests are passing :)\r\nhttps://ci.appveyor.com/project/luisrudge/sqlectron-core\r\n\r\nSo, let's discuss the PR.\r\n\r\nOnce the PR lands, you won't be able to run `npm test` anymore, because you don't have a sql and you can't run sql server via docker (yet). So, how we'll handle this?\r\nOne test command per db (pg, mysql sqlserver)?\r\nOne test command per env (unix, win)?\r\n\r\nIf you need some sql server credentials to test this, ping me on [twitter](https://twitter.com/luisrudge) and I can send you via DM."},"comment":{"url":"https://api.github.com/repos/sqlectron/sqlectron-core/issues/comments/163336389","html_url":"https://github.com/sqlectron/sqlectron-core/pull/7#issuecomment-163336389","issue_url":"https://api.github.com/repos/sqlectron/sqlectron-core/issues/7","id":163336389,"user":{"login":"luisrudge","id":941075,"avatar_url":"https://avatars.githubusercontent.com/u/941075?v=3","gravatar_id":"","url":"https://api.github.com/users/luisrudge","html_url":"https://github.com/luisrudge","followers_url":"https://api.github.com/users/luisrudge/followers","following_url":"https://api.github.com/users/luisrudge/following{/other_user}","gists_url":"https://api.github.com/users/luisrudge/gists{/gist_id}","starred_url":"https://api.github.com/users/luisrudge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luisrudge/subscriptions","organizations_url":"https://api.github.com/users/luisrudge/orgs","repos_url":"https://api.github.com/users/luisrudge/repos","events_url":"https://api.github.com/users/luisrudge/events{/privacy}","received_events_url":"https://api.github.com/users/luisrudge/received_events","type":"User","site_admin":false},"created_at":"2015-12-09T17:44:04Z","updated_at":"2015-12-09T17:44:04Z","body":"I like the idea of having specific test commands (`npm run test:mysql`) more than ENV vars.\r\n\r\nI'm not sure how to get affectedRows with mssql, so I [opened an issue](https://github.com/patriksimek/node-mssql/issues/242) in the repo. Let's see how that goes"}}