{"action":"created","issue":{"url":"https://api.github.com/repos/georgestephanis/two-factor/issues/8","labels_url":"https://api.github.com/repos/georgestephanis/two-factor/issues/8/labels{/name}","comments_url":"https://api.github.com/repos/georgestephanis/two-factor/issues/8/comments","events_url":"https://api.github.com/repos/georgestephanis/two-factor/issues/8/events","html_url":"https://github.com/georgestephanis/two-factor/pull/8","id":95728040,"number":8,"title":"Code Standards & Testing Tools","user":{"login":"valendesigns","id":62798,"avatar_url":"https://avatars.githubusercontent.com/u/62798?v=3","gravatar_id":"","url":"https://api.github.com/users/valendesigns","html_url":"https://github.com/valendesigns","followers_url":"https://api.github.com/users/valendesigns/followers","following_url":"https://api.github.com/users/valendesigns/following{/other_user}","gists_url":"https://api.github.com/users/valendesigns/gists{/gist_id}","starred_url":"https://api.github.com/users/valendesigns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/valendesigns/subscriptions","organizations_url":"https://api.github.com/users/valendesigns/orgs","repos_url":"https://api.github.com/users/valendesigns/repos","events_url":"https://api.github.com/users/valendesigns/events{/privacy}","received_events_url":"https://api.github.com/users/valendesigns/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-07-17T19:34:10Z","updated_at":"2015-08-03T20:58:13Z","closed_at":"2015-08-03T12:15:03Z","pull_request":{"url":"https://api.github.com/repos/georgestephanis/two-factor/pulls/8","html_url":"https://github.com/georgestephanis/two-factor/pull/8","diff_url":"https://github.com/georgestephanis/two-factor/pull/8.diff","patch_url":"https://github.com/georgestephanis/two-factor/pull/8.patch"},"body":"I've added Sniffs, PHPUnit, Travis CI, & Coveralls. I fixed all the build errors and added documentation, please review the docs from the perspective of someone who knows the code before merging. \r\n\r\nAdditionally, I added a couple basic unit tests to kick things off. Let me know if you have any questions or want me to change something. You should probably set things up for this repo over at travis-ci.org and coveralls.io before merging. \r\n\r\nI would suggest doing an audit on all the methods in `Application_Passwords`. I don't believe they all need to be `static`. As well, we should be standardizing the class names by prefixing all of them with `Two_Factor_` so they can easily be changed to `WP_` in the future.\r\n\r\nSomething that stands out as being odd is the way your verifying nonces. I had to add an exclusion so the coding standards didn't complain about it."},"comment":{"url":"https://api.github.com/repos/georgestephanis/two-factor/issues/comments/127404846","html_url":"https://github.com/georgestephanis/two-factor/pull/8#issuecomment-127404846","issue_url":"https://api.github.com/repos/georgestephanis/two-factor/issues/8","id":127404846,"user":{"login":"valendesigns","id":62798,"avatar_url":"https://avatars.githubusercontent.com/u/62798?v=3","gravatar_id":"","url":"https://api.github.com/users/valendesigns","html_url":"https://github.com/valendesigns","followers_url":"https://api.github.com/users/valendesigns/followers","following_url":"https://api.github.com/users/valendesigns/following{/other_user}","gists_url":"https://api.github.com/users/valendesigns/gists{/gist_id}","starred_url":"https://api.github.com/users/valendesigns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/valendesigns/subscriptions","organizations_url":"https://api.github.com/users/valendesigns/orgs","repos_url":"https://api.github.com/users/valendesigns/repos","events_url":"https://api.github.com/users/valendesigns/events{/privacy}","received_events_url":"https://api.github.com/users/valendesigns/received_events","type":"User","site_admin":false},"created_at":"2015-08-03T20:58:13Z","updated_at":"2015-08-03T20:58:13Z","body":"You didn't turn travis on before merging.\r\n"}}