{"action":"created","issue":{"url":"https://api.github.com/repos/ReactiveX/RxJava/issues/2928","labels_url":"https://api.github.com/repos/ReactiveX/RxJava/issues/2928/labels{/name}","comments_url":"https://api.github.com/repos/ReactiveX/RxJava/issues/2928/comments","events_url":"https://api.github.com/repos/ReactiveX/RxJava/issues/2928/events","html_url":"https://github.com/ReactiveX/RxJava/pull/2928","id":72267411,"number":2928,"title":"Merge and MergeMaxConcurrent unified and rewritten","user":{"login":"akarnokd","id":1269832,"avatar_url":"https://avatars.githubusercontent.com/u/1269832?v=3","gravatar_id":"","url":"https://api.github.com/users/akarnokd","html_url":"https://github.com/akarnokd","followers_url":"https://api.github.com/users/akarnokd/followers","following_url":"https://api.github.com/users/akarnokd/following{/other_user}","gists_url":"https://api.github.com/users/akarnokd/gists{/gist_id}","starred_url":"https://api.github.com/users/akarnokd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akarnokd/subscriptions","organizations_url":"https://api.github.com/users/akarnokd/orgs","repos_url":"https://api.github.com/users/akarnokd/repos","events_url":"https://api.github.com/users/akarnokd/events{/privacy}","received_events_url":"https://api.github.com/users/akarnokd/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ReactiveX/RxJava/labels/Bug","name":"Bug","color":"fc2929"},{"url":"https://api.github.com/repos/ReactiveX/RxJava/labels/Enhancement","name":"Enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":17,"created_at":"2015-04-30T20:02:47Z","updated_at":"2015-06-06T09:04:23Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ReactiveX/RxJava/pulls/2928","html_url":"https://github.com/ReactiveX/RxJava/pull/2928","diff_url":"https://github.com/ReactiveX/RxJava/pull/2928.diff","patch_url":"https://github.com/ReactiveX/RxJava/pull/2928.patch"},"body":"I've rewritten ```merge``` and ```mergeMaxConcurrent``` together from scratch.\r\n\r\n  - Added experimental ```maxConcurrent``` overloads to the array-merge and the mergeDelayError\r\n  - Fixed ```OperatorMapNotification``` beause it disregarded backpressure on its terminal emissions.\r\n  - While debugging some merge test failures, I've encountered a bug in OperatorPublish with the same underlying logical error (see comment) and fixed it here.\r\n  - Accidentally introduced a few tabs, therefore, I went in and replaced all tabs with spaces.\r\n  - I've changed ```OperatorMergeTest.shouldNotCompleteIfThereArePendingScalarSynchronousEmissionsWhenTheLastInnerSubscriberCompletes``` because it is legal to get onCompleted without any request.\r\n"},"comment":{"url":"https://api.github.com/repos/ReactiveX/RxJava/issues/comments/109554448","html_url":"https://github.com/ReactiveX/RxJava/pull/2928#issuecomment-109554448","issue_url":"https://api.github.com/repos/ReactiveX/RxJava/issues/2928","id":109554448,"user":{"login":"headinthebox","id":1073054,"avatar_url":"https://avatars.githubusercontent.com/u/1073054?v=3","gravatar_id":"","url":"https://api.github.com/users/headinthebox","html_url":"https://github.com/headinthebox","followers_url":"https://api.github.com/users/headinthebox/followers","following_url":"https://api.github.com/users/headinthebox/following{/other_user}","gists_url":"https://api.github.com/users/headinthebox/gists{/gist_id}","starred_url":"https://api.github.com/users/headinthebox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/headinthebox/subscriptions","organizations_url":"https://api.github.com/users/headinthebox/orgs","repos_url":"https://api.github.com/users/headinthebox/repos","events_url":"https://api.github.com/users/headinthebox/events{/privacy}","received_events_url":"https://api.github.com/users/headinthebox/received_events","type":"User","site_admin":false},"created_at":"2015-06-06T09:04:23Z","updated_at":"2015-06-06T09:04:23Z","body":"That should be easy to check."}}