{"action":"created","comment":{"url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/pulls/comments/31530026","id":31530026,"diff_hunk":"@@ -0,0 +1,55 @@\n+/**\n+ * @fileoverview This file provides an Angular service for interacting\n+ * with the \"shorturl\" web service.\n+ */\n+goog.provide('app.GetShorturl');\n+\n+goog.require('app');\n+\n+\n+/**\n+ * @typedef {function(ol.Coordinate=):!angular.$q.Promise}\n+ */\n+app.GetShorturl;\n+\n+\n+/**\n+ * @param {angular.$http} $http The Angular $http service.\n+ * @param {ngeo.Location} ngeoLocation The ngeo Location service.\n+ * @param {string} shorturlServiceUrl The URL to the \"shorturl\" service.\n+ * @return {app.GetShorturl} The getShorturl function.\n+ * @private\n+ * @ngInject\n+ */\n+app.getShorturl_ = function($http, ngeoLocation, shorturlServiceUrl) {\n+  return (\n+      /**\n+     * @param {ol.Coordinate=} opt_coordinate\n+     * @return {!angular.$q.Promise} Promise providing the short URL.\n+     */\n+      function getShorturl(opt_coordinate) {\n+        var location = ngeoLocation;\n+        if (opt_coordinate) {\n+          location.updateParams({\n+            'X': Math.round(opt_coordinate[0]),\n+            'Y': Math.round(opt_coordinate[1])\n+          });\n+        }\n+        var url = location.getUriString();\n+        return $http.get(shorturlServiceUrl, {\n+          params: {\n+            'url': url\n+          }\n+        }).then(\n+            /**","path":"geoportailv3/static/js/shorturlservice.js","position":null,"original_position":44,"commit_id":"db43ee02541600e8ba4247df2b3bca7f3490a2a9","original_commit_id":"5f40af5b5379ddf09ccc238fbf739a89fc7f6641","user":{"login":"elemoine","id":76594,"avatar_url":"https://avatars.githubusercontent.com/u/76594?v=3","gravatar_id":"","url":"https://api.github.com/users/elemoine","html_url":"https://github.com/elemoine","followers_url":"https://api.github.com/users/elemoine/followers","following_url":"https://api.github.com/users/elemoine/following{/other_user}","gists_url":"https://api.github.com/users/elemoine/gists{/gist_id}","starred_url":"https://api.github.com/users/elemoine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elemoine/subscriptions","organizations_url":"https://api.github.com/users/elemoine/orgs","repos_url":"https://api.github.com/users/elemoine/repos","events_url":"https://api.github.com/users/elemoine/events{/privacy}","received_events_url":"https://api.github.com/users/elemoine/received_events","type":"User","site_admin":false},"body":"I've had bad experience with fixjsstyle and I never use it.\n\nOn Tue, Jun 2, 2015 at 4:20 PM, Patrick Weber <notifications@github.com>\nwrote:\n\n> In geoportailv3/static/js/shorturlservice.js\n> <https://github.com/Geoportail-Luxembourg/geoportailv3/pull/507#discussion_r31527097>\n> :\n>\n> > +     */\n> > +      function getShorturl(opt_coordinate) {\n> > +        var location = ngeoLocation;\n> > +        if (opt_coordinate) {\n> > +          location.updateParams({\n> > +            'X': Math.round(opt_coordinate[0]),\n> > +            'Y': Math.round(opt_coordinate[1])\n> > +          });\n> > +        }\n> > +        var url = location.getUriString();\n> > +        return $http.get(shorturlServiceUrl, {\n> > +          params: {\n> > +            'url': url\n> > +          }\n> > +        }).then(\n> > +            /**\n>\n> fixjsstyle creates this indent, seems like a bug\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/Geoportail-Luxembourg/geoportailv3/pull/507/files#r31527097>\n> .\n>\n\n\n\n-- \nEric Lemoine\n\nCamptocamp France SAS\nSavoie Technolac, BP 352\n73377 Le Bourget du Lac, Cedex\n\nTel : +33 (0)4 58 48 20 34\nMail : eric.lemoine@camptocamp.com\nhttp://www.camptocamp.com\n","created_at":"2015-06-02T14:45:04Z","updated_at":"2015-06-02T14:45:04Z","html_url":"https://github.com/Geoportail-Luxembourg/geoportailv3/pull/507#discussion_r31530026","pull_request_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/pulls/507","_links":{"self":{"href":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/pulls/comments/31530026"},"html":{"href":"https://github.com/Geoportail-Luxembourg/geoportailv3/pull/507#discussion_r31530026"},"pull_request":{"href":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/pulls/507"}}},"pull_request":{"url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/pulls/507","id":36507386,"html_url":"https://github.com/Geoportail-Luxembourg/geoportailv3/pull/507","diff_url":"https://github.com/Geoportail-Luxembourg/geoportailv3/pull/507.diff","patch_url":"https://github.com/Geoportail-Luxembourg/geoportailv3/pull/507.patch","issue_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/issues/507","number":507,"state":"open","locked":false,"title":"WIP - Right-click info","user":{"login":"petzlux","id":2540428,"avatar_url":"https://avatars.githubusercontent.com/u/2540428?v=3","gravatar_id":"","url":"https://api.github.com/users/petzlux","html_url":"https://github.com/petzlux","followers_url":"https://api.github.com/users/petzlux/followers","following_url":"https://api.github.com/users/petzlux/following{/other_user}","gists_url":"https://api.github.com/users/petzlux/gists{/gist_id}","starred_url":"https://api.github.com/users/petzlux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petzlux/subscriptions","organizations_url":"https://api.github.com/users/petzlux/orgs","repos_url":"https://api.github.com/users/petzlux/repos","events_url":"https://api.github.com/users/petzlux/events{/privacy}","received_events_url":"https://api.github.com/users/petzlux/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-05-29T13:54:45Z","updated_at":"2015-06-02T14:45:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0e7c1c67e8111e12f6e0ed5600fa848f1cfd7fcd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/pulls/507/commits","review_comments_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/pulls/507/comments","review_comment_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/issues/507/comments","statuses_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/statuses/db43ee02541600e8ba4247df2b3bca7f3490a2a9","head":{"label":"Geoportail-Luxembourg:petzlux_location_info","ref":"petzlux_location_info","sha":"db43ee02541600e8ba4247df2b3bca7f3490a2a9","user":{"login":"Geoportail-Luxembourg","id":5592884,"avatar_url":"https://avatars.githubusercontent.com/u/5592884?v=3","gravatar_id":"","url":"https://api.github.com/users/Geoportail-Luxembourg","html_url":"https://github.com/Geoportail-Luxembourg","followers_url":"https://api.github.com/users/Geoportail-Luxembourg/followers","following_url":"https://api.github.com/users/Geoportail-Luxembourg/following{/other_user}","gists_url":"https://api.github.com/users/Geoportail-Luxembourg/gists{/gist_id}","starred_url":"https://api.github.com/users/Geoportail-Luxembourg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Geoportail-Luxembourg/subscriptions","organizations_url":"https://api.github.com/users/Geoportail-Luxembourg/orgs","repos_url":"https://api.github.com/users/Geoportail-Luxembourg/repos","events_url":"https://api.github.com/users/Geoportail-Luxembourg/events{/privacy}","received_events_url":"https://api.github.com/users/Geoportail-Luxembourg/received_events","type":"Organization","site_admin":false},"repo":{"id":24669372,"name":"geoportailv3","full_name":"Geoportail-Luxembourg/geoportailv3","owner":{"login":"Geoportail-Luxembourg","id":5592884,"avatar_url":"https://avatars.githubusercontent.com/u/5592884?v=3","gravatar_id":"","url":"https://api.github.com/users/Geoportail-Luxembourg","html_url":"https://github.com/Geoportail-Luxembourg","followers_url":"https://api.github.com/users/Geoportail-Luxembourg/followers","following_url":"https://api.github.com/users/Geoportail-Luxembourg/following{/other_user}","gists_url":"https://api.github.com/users/Geoportail-Luxembourg/gists{/gist_id}","starred_url":"https://api.github.com/users/Geoportail-Luxembourg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Geoportail-Luxembourg/subscriptions","organizations_url":"https://api.github.com/users/Geoportail-Luxembourg/orgs","repos_url":"https://api.github.com/users/Geoportail-Luxembourg/repos","events_url":"https://api.github.com/users/Geoportail-Luxembourg/events{/privacy}","received_events_url":"https://api.github.com/users/Geoportail-Luxembourg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Geoportail-Luxembourg/geoportailv3","description":"geoportailv3 is the implementation of the v3 of the map viewer of the luxembourgish geoportal","fork":false,"url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3","forks_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/forks","keys_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/teams","hooks_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/hooks","issue_events_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/issues/events{/number}","events_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/events","assignees_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/assignees{/user}","branches_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/branches{/branch}","tags_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/tags","blobs_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/git/refs{/sha}","trees_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/statuses/{sha}","languages_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/languages","stargazers_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/stargazers","contributors_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/contributors","subscribers_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/subscribers","subscription_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/subscription","commits_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/commits{/sha}","git_commits_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/git/commits{/sha}","comments_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/comments{/number}","issue_comment_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/issues/comments{/number}","contents_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/contents/{+path}","compare_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/merges","archive_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/downloads","issues_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/issues{/number}","pulls_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/pulls{/number}","milestones_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/milestones{/number}","notifications_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/labels{/name}","releases_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/releases{/id}","created_at":"2014-10-01T07:23:27Z","updated_at":"2015-05-06T13:42:38Z","pushed_at":"2015-06-02T14:38:10Z","git_url":"git://github.com/Geoportail-Luxembourg/geoportailv3.git","ssh_url":"git@github.com:Geoportail-Luxembourg/geoportailv3.git","clone_url":"https://github.com/Geoportail-Luxembourg/geoportailv3.git","svn_url":"https://github.com/Geoportail-Luxembourg/geoportailv3","homepage":"","size":158627,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":53,"forks":0,"open_issues":53,"watchers":4,"default_branch":"master"}},"base":{"label":"Geoportail-Luxembourg:master","ref":"master","sha":"420233d6c5a7d649d3b84d9176e8edbf43418a32","user":{"login":"Geoportail-Luxembourg","id":5592884,"avatar_url":"https://avatars.githubusercontent.com/u/5592884?v=3","gravatar_id":"","url":"https://api.github.com/users/Geoportail-Luxembourg","html_url":"https://github.com/Geoportail-Luxembourg","followers_url":"https://api.github.com/users/Geoportail-Luxembourg/followers","following_url":"https://api.github.com/users/Geoportail-Luxembourg/following{/other_user}","gists_url":"https://api.github.com/users/Geoportail-Luxembourg/gists{/gist_id}","starred_url":"https://api.github.com/users/Geoportail-Luxembourg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Geoportail-Luxembourg/subscriptions","organizations_url":"https://api.github.com/users/Geoportail-Luxembourg/orgs","repos_url":"https://api.github.com/users/Geoportail-Luxembourg/repos","events_url":"https://api.github.com/users/Geoportail-Luxembourg/events{/privacy}","received_events_url":"https://api.github.com/users/Geoportail-Luxembourg/received_events","type":"Organization","site_admin":false},"repo":{"id":24669372,"name":"geoportailv3","full_name":"Geoportail-Luxembourg/geoportailv3","owner":{"login":"Geoportail-Luxembourg","id":5592884,"avatar_url":"https://avatars.githubusercontent.com/u/5592884?v=3","gravatar_id":"","url":"https://api.github.com/users/Geoportail-Luxembourg","html_url":"https://github.com/Geoportail-Luxembourg","followers_url":"https://api.github.com/users/Geoportail-Luxembourg/followers","following_url":"https://api.github.com/users/Geoportail-Luxembourg/following{/other_user}","gists_url":"https://api.github.com/users/Geoportail-Luxembourg/gists{/gist_id}","starred_url":"https://api.github.com/users/Geoportail-Luxembourg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Geoportail-Luxembourg/subscriptions","organizations_url":"https://api.github.com/users/Geoportail-Luxembourg/orgs","repos_url":"https://api.github.com/users/Geoportail-Luxembourg/repos","events_url":"https://api.github.com/users/Geoportail-Luxembourg/events{/privacy}","received_events_url":"https://api.github.com/users/Geoportail-Luxembourg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Geoportail-Luxembourg/geoportailv3","description":"geoportailv3 is the implementation of the v3 of the map viewer of the luxembourgish geoportal","fork":false,"url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3","forks_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/forks","keys_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/teams","hooks_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/hooks","issue_events_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/issues/events{/number}","events_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/events","assignees_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/assignees{/user}","branches_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/branches{/branch}","tags_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/tags","blobs_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/git/refs{/sha}","trees_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/statuses/{sha}","languages_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/languages","stargazers_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/stargazers","contributors_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/contributors","subscribers_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/subscribers","subscription_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/subscription","commits_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/commits{/sha}","git_commits_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/git/commits{/sha}","comments_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/comments{/number}","issue_comment_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/issues/comments{/number}","contents_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/contents/{+path}","compare_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/merges","archive_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/downloads","issues_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/issues{/number}","pulls_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/pulls{/number}","milestones_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/milestones{/number}","notifications_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/labels{/name}","releases_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/releases{/id}","created_at":"2014-10-01T07:23:27Z","updated_at":"2015-05-06T13:42:38Z","pushed_at":"2015-06-02T14:38:10Z","git_url":"git://github.com/Geoportail-Luxembourg/geoportailv3.git","ssh_url":"git@github.com:Geoportail-Luxembourg/geoportailv3.git","clone_url":"https://github.com/Geoportail-Luxembourg/geoportailv3.git","svn_url":"https://github.com/Geoportail-Luxembourg/geoportailv3","homepage":"","size":158627,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":53,"forks":0,"open_issues":53,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/pulls/507"},"html":{"href":"https://github.com/Geoportail-Luxembourg/geoportailv3/pull/507"},"issue":{"href":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/issues/507"},"comments":{"href":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/issues/507/comments"},"review_comments":{"href":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/pulls/507/comments"},"review_comment":{"href":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/pulls/507/commits"},"statuses":{"href":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/statuses/db43ee02541600e8ba4247df2b3bca7f3490a2a9"}}}}