{"action":"created","comment":{"url":"https://api.github.com/repos/ahmadsoe/ember-highcharts/pulls/comments/26772442","id":26772442,"diff_hunk":"@@ -18,16 +18,17 @@ export default Ember.Component.extend({\n   chartOptions: undefined,\n   chart: null,\n   theme: undefined,\n+  callback: undefined,\n \n   buildOptions: computed('chartOptions', 'content.@each.isLoaded', function() {\n-    let chartOptions = Ember.$.extend(true, {}, get(this, 'theme'), get(this, 'chartOptions'));\n-    let chartContent = get(this, 'content.length') ? get(this, 'content') : [{\n-      id    : 'noData',\n-      data  : 0,\n-      color : '#aaaaaa'\n-    }];\n-\n-    let defaults = { series: chartContent };\n+    let defaultChartData = [{\n+          id    : 'noData',\n+          data  : 0,\n+          color : '#aaaaaa'\n+        }],\n+        chartOptions = Ember.$.extend(true, {}, get(this, 'theme'), get(this, 'chartOptions')),","path":"addon/components/high-charts.js","position":20,"original_position":20,"commit_id":"a5d61482d900cdb217b40ca272bf10db7318a702","original_commit_id":"a5d61482d900cdb217b40ca272bf10db7318a702","user":{"login":"huiyuan","id":1836695,"avatar_url":"https://avatars.githubusercontent.com/u/1836695?v=3","gravatar_id":"","url":"https://api.github.com/users/huiyuan","html_url":"https://github.com/huiyuan","followers_url":"https://api.github.com/users/huiyuan/followers","following_url":"https://api.github.com/users/huiyuan/following{/other_user}","gists_url":"https://api.github.com/users/huiyuan/gists{/gist_id}","starred_url":"https://api.github.com/users/huiyuan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huiyuan/subscriptions","organizations_url":"https://api.github.com/users/huiyuan/orgs","repos_url":"https://api.github.com/users/huiyuan/repos","events_url":"https://api.github.com/users/huiyuan/events{/privacy}","received_events_url":"https://api.github.com/users/huiyuan/received_events","type":"User","site_admin":false},"body":"A deep merge is needed here. Ember.merge doesn't do that.","created_at":"2015-03-19T16:42:07Z","updated_at":"2015-03-19T16:42:07Z","html_url":"https://github.com/ahmadsoe/ember-highcharts/pull/20#discussion_r26772442","pull_request_url":"https://api.github.com/repos/ahmadsoe/ember-highcharts/pulls/20","_links":{"self":{"href":"https://api.github.com/repos/ahmadsoe/ember-highcharts/pulls/comments/26772442"},"html":{"href":"https://github.com/ahmadsoe/ember-highcharts/pull/20#discussion_r26772442"},"pull_request":{"href":"https://api.github.com/repos/ahmadsoe/ember-highcharts/pulls/20"}}},"pull_request":{"url":"https://api.github.com/repos/ahmadsoe/ember-highcharts/pulls/20","id":31378565,"html_url":"https://github.com/ahmadsoe/ember-highcharts/pull/20","diff_url":"https://github.com/ahmadsoe/ember-highcharts/pull/20.diff","patch_url":"https://github.com/ahmadsoe/ember-highcharts/pull/20.patch","issue_url":"https://api.github.com/repos/ahmadsoe/ember-highcharts/issues/20","number":20,"state":"open","locked":false,"title":"Updated highchart initializer to accept secondary argument, 'let' clean up","user":{"login":"huiyuan","id":1836695,"avatar_url":"https://avatars.githubusercontent.com/u/1836695?v=3","gravatar_id":"","url":"https://api.github.com/users/huiyuan","html_url":"https://github.com/huiyuan","followers_url":"https://api.github.com/users/huiyuan/followers","following_url":"https://api.github.com/users/huiyuan/following{/other_user}","gists_url":"https://api.github.com/users/huiyuan/gists{/gist_id}","starred_url":"https://api.github.com/users/huiyuan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huiyuan/subscriptions","organizations_url":"https://api.github.com/users/huiyuan/orgs","repos_url":"https://api.github.com/users/huiyuan/repos","events_url":"https://api.github.com/users/huiyuan/events{/privacy}","received_events_url":"https://api.github.com/users/huiyuan/received_events","type":"User","site_admin":false},"body":"Updated highchart initializer to accept secondary argument, removed extra 'let' to keep only one 'let' per scope.","created_at":"2015-03-17T21:13:00Z","updated_at":"2015-03-19T16:42:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e6ddf132f5cb6789cf5a7f3ee1b34f6d1143b22c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ahmadsoe/ember-highcharts/pulls/20/commits","review_comments_url":"https://api.github.com/repos/ahmadsoe/ember-highcharts/pulls/20/comments","review_comment_url":"https://api.github.com/repos/ahmadsoe/ember-highcharts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ahmadsoe/ember-highcharts/issues/20/comments","statuses_url":"https://api.github.com/repos/ahmadsoe/ember-highcharts/statuses/a5d61482d900cdb217b40ca272bf10db7318a702","head":{"label":"huiyuan:huiyuan-branch","ref":"huiyuan-branch","sha":"a5d61482d900cdb217b40ca272bf10db7318a702","user":{"login":"huiyuan","id":1836695,"avatar_url":"https://avatars.githubusercontent.com/u/1836695?v=3","gravatar_id":"","url":"https://api.github.com/users/huiyuan","html_url":"https://github.com/huiyuan","followers_url":"https://api.github.com/users/huiyuan/followers","following_url":"https://api.github.com/users/huiyuan/following{/other_user}","gists_url":"https://api.github.com/users/huiyuan/gists{/gist_id}","starred_url":"https://api.github.com/users/huiyuan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huiyuan/subscriptions","organizations_url":"https://api.github.com/users/huiyuan/orgs","repos_url":"https://api.github.com/users/huiyuan/repos","events_url":"https://api.github.com/users/huiyuan/events{/privacy}","received_events_url":"https://api.github.com/users/huiyuan/received_events","type":"User","site_admin":false},"repo":{"id":31928039,"name":"ember-highcharts","full_name":"huiyuan/ember-highcharts","owner":{"login":"huiyuan","id":1836695,"avatar_url":"https://avatars.githubusercontent.com/u/1836695?v=3","gravatar_id":"","url":"https://api.github.com/users/huiyuan","html_url":"https://github.com/huiyuan","followers_url":"https://api.github.com/users/huiyuan/followers","following_url":"https://api.github.com/users/huiyuan/following{/other_user}","gists_url":"https://api.github.com/users/huiyuan/gists{/gist_id}","starred_url":"https://api.github.com/users/huiyuan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huiyuan/subscriptions","organizations_url":"https://api.github.com/users/huiyuan/orgs","repos_url":"https://api.github.com/users/huiyuan/repos","events_url":"https://api.github.com/users/huiyuan/events{/privacy}","received_events_url":"https://api.github.com/users/huiyuan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/huiyuan/ember-highcharts","description":"A Highcharts component for ember cli","fork":true,"url":"https://api.github.com/repos/huiyuan/ember-highcharts","forks_url":"https://api.github.com/repos/huiyuan/ember-highcharts/forks","keys_url":"https://api.github.com/repos/huiyuan/ember-highcharts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/huiyuan/ember-highcharts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/huiyuan/ember-highcharts/teams","hooks_url":"https://api.github.com/repos/huiyuan/ember-highcharts/hooks","issue_events_url":"https://api.github.com/repos/huiyuan/ember-highcharts/issues/events{/number}","events_url":"https://api.github.com/repos/huiyuan/ember-highcharts/events","assignees_url":"https://api.github.com/repos/huiyuan/ember-highcharts/assignees{/user}","branches_url":"https://api.github.com/repos/huiyuan/ember-highcharts/branches{/branch}","tags_url":"https://api.github.com/repos/huiyuan/ember-highcharts/tags","blobs_url":"https://api.github.com/repos/huiyuan/ember-highcharts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/huiyuan/ember-highcharts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/huiyuan/ember-highcharts/git/refs{/sha}","trees_url":"https://api.github.com/repos/huiyuan/ember-highcharts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/huiyuan/ember-highcharts/statuses/{sha}","languages_url":"https://api.github.com/repos/huiyuan/ember-highcharts/languages","stargazers_url":"https://api.github.com/repos/huiyuan/ember-highcharts/stargazers","contributors_url":"https://api.github.com/repos/huiyuan/ember-highcharts/contributors","subscribers_url":"https://api.github.com/repos/huiyuan/ember-highcharts/subscribers","subscription_url":"https://api.github.com/repos/huiyuan/ember-highcharts/subscription","commits_url":"https://api.github.com/repos/huiyuan/ember-highcharts/commits{/sha}","git_commits_url":"https://api.github.com/repos/huiyuan/ember-highcharts/git/commits{/sha}","comments_url":"https://api.github.com/repos/huiyuan/ember-highcharts/comments{/number}","issue_comment_url":"https://api.github.com/repos/huiyuan/ember-highcharts/issues/comments{/number}","contents_url":"https://api.github.com/repos/huiyuan/ember-highcharts/contents/{+path}","compare_url":"https://api.github.com/repos/huiyuan/ember-highcharts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/huiyuan/ember-highcharts/merges","archive_url":"https://api.github.com/repos/huiyuan/ember-highcharts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/huiyuan/ember-highcharts/downloads","issues_url":"https://api.github.com/repos/huiyuan/ember-highcharts/issues{/number}","pulls_url":"https://api.github.com/repos/huiyuan/ember-highcharts/pulls{/number}","milestones_url":"https://api.github.com/repos/huiyuan/ember-highcharts/milestones{/number}","notifications_url":"https://api.github.com/repos/huiyuan/ember-highcharts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/huiyuan/ember-highcharts/labels{/name}","releases_url":"https://api.github.com/repos/huiyuan/ember-highcharts/releases{/id}","created_at":"2015-03-09T23:24:28Z","updated_at":"2015-03-15T06:32:30Z","pushed_at":"2015-03-17T21:08:17Z","git_url":"git://github.com/huiyuan/ember-highcharts.git","ssh_url":"git@github.com:huiyuan/ember-highcharts.git","clone_url":"https://github.com/huiyuan/ember-highcharts.git","svn_url":"https://github.com/huiyuan/ember-highcharts","homepage":"http://ahmadsoe.github.io/ember-highcharts/","size":494,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ahmadsoe:master","ref":"master","sha":"e6ce0e6776ff1776cc25210348d5a88e913368c2","user":{"login":"ahmadsoe","id":1957737,"avatar_url":"https://avatars.githubusercontent.com/u/1957737?v=3","gravatar_id":"","url":"https://api.github.com/users/ahmadsoe","html_url":"https://github.com/ahmadsoe","followers_url":"https://api.github.com/users/ahmadsoe/followers","following_url":"https://api.github.com/users/ahmadsoe/following{/other_user}","gists_url":"https://api.github.com/users/ahmadsoe/gists{/gist_id}","starred_url":"https://api.github.com/users/ahmadsoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahmadsoe/subscriptions","organizations_url":"https://api.github.com/users/ahmadsoe/orgs","repos_url":"https://api.github.com/users/ahmadsoe/repos","events_url":"https://api.github.com/users/ahmadsoe/events{/privacy}","received_events_url":"https://api.github.com/users/ahmadsoe/received_events","type":"User","site_admin":false},"repo":{"id":26840868,"name":"ember-highcharts","full_name":"ahmadsoe/ember-highcharts","owner":{"login":"ahmadsoe","id":1957737,"avatar_url":"https://avatars.githubusercontent.com/u/1957737?v=3","gravatar_id":"","url":"https://api.github.com/users/ahmadsoe","html_url":"https://github.com/ahmadsoe","followers_url":"https://api.github.com/users/ahmadsoe/followers","following_url":"https://api.github.com/users/ahmadsoe/following{/other_user}","gists_url":"https://api.github.com/users/ahmadsoe/gists{/gist_id}","starred_url":"https://api.github.com/users/ahmadsoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahmadsoe/subscriptions","organizations_url":"https://api.github.com/users/ahmadsoe/orgs","repos_url":"https://api.github.com/users/ahmadsoe/repos","events_url":"https://api.github.com/users/ahmadsoe/events{/privacy}","received_events_url":"https://api.github.com/users/ahmadsoe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ahmadsoe/ember-highcharts","description":"A Highcharts, HighStock and HighMaps component for ember cli","fork":false,"url":"https://api.github.com/repos/ahmadsoe/ember-highcharts","forks_url":"https://api.github.com/repos/ahmadsoe/ember-highcharts/forks","keys_url":"https://api.github.com/repos/ahmadsoe/ember-highcharts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ahmadsoe/ember-highcharts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ahmadsoe/ember-highcharts/teams","hooks_url":"https://api.github.com/repos/ahmadsoe/ember-highcharts/hooks","issue_events_url":"https://api.github.com/repos/ahmadsoe/ember-highcharts/issues/events{/number}","events_url":"https://api.github.com/repos/ahmadsoe/ember-highcharts/events","assignees_url":"https://api.github.com/repos/ahmadsoe/ember-highcharts/assignees{/user}","branches_url":"https://api.github.com/repos/ahmadsoe/ember-highcharts/branches{/branch}","tags_url":"https://api.github.com/repos/ahmadsoe/ember-highcharts/tags","blobs_url":"https://api.github.com/repos/ahmadsoe/ember-highcharts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ahmadsoe/ember-highcharts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ahmadsoe/ember-highcharts/git/refs{/sha}","trees_url":"https://api.github.com/repos/ahmadsoe/ember-highcharts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ahmadsoe/ember-highcharts/statuses/{sha}","languages_url":"https://api.github.com/repos/ahmadsoe/ember-highcharts/languages","stargazers_url":"https://api.github.com/repos/ahmadsoe/ember-highcharts/stargazers","contributors_url":"https://api.github.com/repos/ahmadsoe/ember-highcharts/contributors","subscribers_url":"https://api.github.com/repos/ahmadsoe/ember-highcharts/subscribers","subscription_url":"https://api.github.com/repos/ahmadsoe/ember-highcharts/subscription","commits_url":"https://api.github.com/repos/ahmadsoe/ember-highcharts/commits{/sha}","git_commits_url":"https://api.github.com/repos/ahmadsoe/ember-highcharts/git/commits{/sha}","comments_url":"https://api.github.com/repos/ahmadsoe/ember-highcharts/comments{/number}","issue_comment_url":"https://api.github.com/repos/ahmadsoe/ember-highcharts/issues/comments{/number}","contents_url":"https://api.github.com/repos/ahmadsoe/ember-highcharts/contents/{+path}","compare_url":"https://api.github.com/repos/ahmadsoe/ember-highcharts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ahmadsoe/ember-highcharts/merges","archive_url":"https://api.github.com/repos/ahmadsoe/ember-highcharts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ahmadsoe/ember-highcharts/downloads","issues_url":"https://api.github.com/repos/ahmadsoe/ember-highcharts/issues{/number}","pulls_url":"https://api.github.com/repos/ahmadsoe/ember-highcharts/pulls{/number}","milestones_url":"https://api.github.com/repos/ahmadsoe/ember-highcharts/milestones{/number}","notifications_url":"https://api.github.com/repos/ahmadsoe/ember-highcharts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ahmadsoe/ember-highcharts/labels{/name}","releases_url":"https://api.github.com/repos/ahmadsoe/ember-highcharts/releases{/id}","created_at":"2014-11-19T02:36:44Z","updated_at":"2015-03-19T16:05:37Z","pushed_at":"2015-03-19T16:05:36Z","git_url":"git://github.com/ahmadsoe/ember-highcharts.git","ssh_url":"git@github.com:ahmadsoe/ember-highcharts.git","clone_url":"https://github.com/ahmadsoe/ember-highcharts.git","svn_url":"https://github.com/ahmadsoe/ember-highcharts","homepage":"http://ahmadsoe.github.io/ember-highcharts/","size":1243,"stargazers_count":17,"watchers_count":17,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":7,"mirror_url":null,"open_issues_count":3,"forks":7,"open_issues":3,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ahmadsoe/ember-highcharts/pulls/20"},"html":{"href":"https://github.com/ahmadsoe/ember-highcharts/pull/20"},"issue":{"href":"https://api.github.com/repos/ahmadsoe/ember-highcharts/issues/20"},"comments":{"href":"https://api.github.com/repos/ahmadsoe/ember-highcharts/issues/20/comments"},"review_comments":{"href":"https://api.github.com/repos/ahmadsoe/ember-highcharts/pulls/20/comments"},"review_comment":{"href":"https://api.github.com/repos/ahmadsoe/ember-highcharts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ahmadsoe/ember-highcharts/pulls/20/commits"},"statuses":{"href":"https://api.github.com/repos/ahmadsoe/ember-highcharts/statuses/a5d61482d900cdb217b40ca272bf10db7318a702"}}}}