{"action":"opened","number":5,"pull_request":{"url":"https://api.github.com/repos/prestodb/presto-yarn/pulls/5","id":47080688,"html_url":"https://github.com/prestodb/presto-yarn/pull/5","diff_url":"https://github.com/prestodb/presto-yarn/pull/5.diff","patch_url":"https://github.com/prestodb/presto-yarn/pull/5.patch","issue_url":"https://api.github.com/repos/prestodb/presto-yarn/issues/5","number":5,"state":"open","locked":false,"title":"tests: Wait before asserting that slider is stoppable","user":{"login":"anusudarsan","id":10963707,"avatar_url":"https://avatars.githubusercontent.com/u/10963707?v=3","gravatar_id":"","url":"https://api.github.com/users/anusudarsan","html_url":"https://github.com/anusudarsan","followers_url":"https://api.github.com/users/anusudarsan/followers","following_url":"https://api.github.com/users/anusudarsan/following{/other_user}","gists_url":"https://api.github.com/users/anusudarsan/gists{/gist_id}","starred_url":"https://api.github.com/users/anusudarsan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anusudarsan/subscriptions","organizations_url":"https://api.github.com/users/anusudarsan/orgs","repos_url":"https://api.github.com/users/anusudarsan/repos","events_url":"https://api.github.com/users/anusudarsan/events{/privacy}","received_events_url":"https://api.github.com/users/anusudarsan/received_events","type":"User","site_admin":false},"body":"The --wait argument in bin/slider stop is to delay the process of\r\nstopping\r\nthe presto application, and not really waiting *after* the process has\r\nstopped. So just remove it and add a wait time in the tests (using retry\r\n)to confirm the process\r\nhas stopped before we call the assertion statement.\r\n\r\nSWARM-1405","created_at":"2015-10-07T20:54:30Z","updated_at":"2015-10-07T20:54:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/prestodb/presto-yarn/pulls/5/commits","review_comments_url":"https://api.github.com/repos/prestodb/presto-yarn/pulls/5/comments","review_comment_url":"https://api.github.com/repos/prestodb/presto-yarn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/prestodb/presto-yarn/issues/5/comments","statuses_url":"https://api.github.com/repos/prestodb/presto-yarn/statuses/a0214dc235f9c19de2b57c48d671468becc1847e","head":{"label":"prestodb:fix-stoppable-assertion","ref":"fix-stoppable-assertion","sha":"a0214dc235f9c19de2b57c48d671468becc1847e","user":{"login":"prestodb","id":6882181,"avatar_url":"https://avatars.githubusercontent.com/u/6882181?v=3","gravatar_id":"","url":"https://api.github.com/users/prestodb","html_url":"https://github.com/prestodb","followers_url":"https://api.github.com/users/prestodb/followers","following_url":"https://api.github.com/users/prestodb/following{/other_user}","gists_url":"https://api.github.com/users/prestodb/gists{/gist_id}","starred_url":"https://api.github.com/users/prestodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prestodb/subscriptions","organizations_url":"https://api.github.com/users/prestodb/orgs","repos_url":"https://api.github.com/users/prestodb/repos","events_url":"https://api.github.com/users/prestodb/events{/privacy}","received_events_url":"https://api.github.com/users/prestodb/received_events","type":"Organization","site_admin":false},"repo":{"id":42887203,"name":"presto-yarn","full_name":"prestodb/presto-yarn","owner":{"login":"prestodb","id":6882181,"avatar_url":"https://avatars.githubusercontent.com/u/6882181?v=3","gravatar_id":"","url":"https://api.github.com/users/prestodb","html_url":"https://github.com/prestodb","followers_url":"https://api.github.com/users/prestodb/followers","following_url":"https://api.github.com/users/prestodb/following{/other_user}","gists_url":"https://api.github.com/users/prestodb/gists{/gist_id}","starred_url":"https://api.github.com/users/prestodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prestodb/subscriptions","organizations_url":"https://api.github.com/users/prestodb/orgs","repos_url":"https://api.github.com/users/prestodb/repos","events_url":"https://api.github.com/users/prestodb/events{/privacy}","received_events_url":"https://api.github.com/users/prestodb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/prestodb/presto-yarn","description":"","fork":false,"url":"https://api.github.com/repos/prestodb/presto-yarn","forks_url":"https://api.github.com/repos/prestodb/presto-yarn/forks","keys_url":"https://api.github.com/repos/prestodb/presto-yarn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prestodb/presto-yarn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prestodb/presto-yarn/teams","hooks_url":"https://api.github.com/repos/prestodb/presto-yarn/hooks","issue_events_url":"https://api.github.com/repos/prestodb/presto-yarn/issues/events{/number}","events_url":"https://api.github.com/repos/prestodb/presto-yarn/events","assignees_url":"https://api.github.com/repos/prestodb/presto-yarn/assignees{/user}","branches_url":"https://api.github.com/repos/prestodb/presto-yarn/branches{/branch}","tags_url":"https://api.github.com/repos/prestodb/presto-yarn/tags","blobs_url":"https://api.github.com/repos/prestodb/presto-yarn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prestodb/presto-yarn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prestodb/presto-yarn/git/refs{/sha}","trees_url":"https://api.github.com/repos/prestodb/presto-yarn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prestodb/presto-yarn/statuses/{sha}","languages_url":"https://api.github.com/repos/prestodb/presto-yarn/languages","stargazers_url":"https://api.github.com/repos/prestodb/presto-yarn/stargazers","contributors_url":"https://api.github.com/repos/prestodb/presto-yarn/contributors","subscribers_url":"https://api.github.com/repos/prestodb/presto-yarn/subscribers","subscription_url":"https://api.github.com/repos/prestodb/presto-yarn/subscription","commits_url":"https://api.github.com/repos/prestodb/presto-yarn/commits{/sha}","git_commits_url":"https://api.github.com/repos/prestodb/presto-yarn/git/commits{/sha}","comments_url":"https://api.github.com/repos/prestodb/presto-yarn/comments{/number}","issue_comment_url":"https://api.github.com/repos/prestodb/presto-yarn/issues/comments{/number}","contents_url":"https://api.github.com/repos/prestodb/presto-yarn/contents/{+path}","compare_url":"https://api.github.com/repos/prestodb/presto-yarn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prestodb/presto-yarn/merges","archive_url":"https://api.github.com/repos/prestodb/presto-yarn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prestodb/presto-yarn/downloads","issues_url":"https://api.github.com/repos/prestodb/presto-yarn/issues{/number}","pulls_url":"https://api.github.com/repos/prestodb/presto-yarn/pulls{/number}","milestones_url":"https://api.github.com/repos/prestodb/presto-yarn/milestones{/number}","notifications_url":"https://api.github.com/repos/prestodb/presto-yarn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prestodb/presto-yarn/labels{/name}","releases_url":"https://api.github.com/repos/prestodb/presto-yarn/releases{/id}","created_at":"2015-09-21T18:55:00Z","updated_at":"2015-09-22T17:03:45Z","pushed_at":"2015-10-07T20:53:32Z","git_url":"git://github.com/prestodb/presto-yarn.git","ssh_url":"git@github.com:prestodb/presto-yarn.git","clone_url":"https://github.com/prestodb/presto-yarn.git","svn_url":"https://github.com/prestodb/presto-yarn","homepage":null,"size":43432,"stargazers_count":6,"watchers_count":6,"language":"Groovy","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":6,"default_branch":"master"}},"base":{"label":"prestodb:master","ref":"master","sha":"c292c172865cd4f04e2c5c5a6ca8adeb0357132a","user":{"login":"prestodb","id":6882181,"avatar_url":"https://avatars.githubusercontent.com/u/6882181?v=3","gravatar_id":"","url":"https://api.github.com/users/prestodb","html_url":"https://github.com/prestodb","followers_url":"https://api.github.com/users/prestodb/followers","following_url":"https://api.github.com/users/prestodb/following{/other_user}","gists_url":"https://api.github.com/users/prestodb/gists{/gist_id}","starred_url":"https://api.github.com/users/prestodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prestodb/subscriptions","organizations_url":"https://api.github.com/users/prestodb/orgs","repos_url":"https://api.github.com/users/prestodb/repos","events_url":"https://api.github.com/users/prestodb/events{/privacy}","received_events_url":"https://api.github.com/users/prestodb/received_events","type":"Organization","site_admin":false},"repo":{"id":42887203,"name":"presto-yarn","full_name":"prestodb/presto-yarn","owner":{"login":"prestodb","id":6882181,"avatar_url":"https://avatars.githubusercontent.com/u/6882181?v=3","gravatar_id":"","url":"https://api.github.com/users/prestodb","html_url":"https://github.com/prestodb","followers_url":"https://api.github.com/users/prestodb/followers","following_url":"https://api.github.com/users/prestodb/following{/other_user}","gists_url":"https://api.github.com/users/prestodb/gists{/gist_id}","starred_url":"https://api.github.com/users/prestodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prestodb/subscriptions","organizations_url":"https://api.github.com/users/prestodb/orgs","repos_url":"https://api.github.com/users/prestodb/repos","events_url":"https://api.github.com/users/prestodb/events{/privacy}","received_events_url":"https://api.github.com/users/prestodb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/prestodb/presto-yarn","description":"","fork":false,"url":"https://api.github.com/repos/prestodb/presto-yarn","forks_url":"https://api.github.com/repos/prestodb/presto-yarn/forks","keys_url":"https://api.github.com/repos/prestodb/presto-yarn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prestodb/presto-yarn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prestodb/presto-yarn/teams","hooks_url":"https://api.github.com/repos/prestodb/presto-yarn/hooks","issue_events_url":"https://api.github.com/repos/prestodb/presto-yarn/issues/events{/number}","events_url":"https://api.github.com/repos/prestodb/presto-yarn/events","assignees_url":"https://api.github.com/repos/prestodb/presto-yarn/assignees{/user}","branches_url":"https://api.github.com/repos/prestodb/presto-yarn/branches{/branch}","tags_url":"https://api.github.com/repos/prestodb/presto-yarn/tags","blobs_url":"https://api.github.com/repos/prestodb/presto-yarn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prestodb/presto-yarn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prestodb/presto-yarn/git/refs{/sha}","trees_url":"https://api.github.com/repos/prestodb/presto-yarn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prestodb/presto-yarn/statuses/{sha}","languages_url":"https://api.github.com/repos/prestodb/presto-yarn/languages","stargazers_url":"https://api.github.com/repos/prestodb/presto-yarn/stargazers","contributors_url":"https://api.github.com/repos/prestodb/presto-yarn/contributors","subscribers_url":"https://api.github.com/repos/prestodb/presto-yarn/subscribers","subscription_url":"https://api.github.com/repos/prestodb/presto-yarn/subscription","commits_url":"https://api.github.com/repos/prestodb/presto-yarn/commits{/sha}","git_commits_url":"https://api.github.com/repos/prestodb/presto-yarn/git/commits{/sha}","comments_url":"https://api.github.com/repos/prestodb/presto-yarn/comments{/number}","issue_comment_url":"https://api.github.com/repos/prestodb/presto-yarn/issues/comments{/number}","contents_url":"https://api.github.com/repos/prestodb/presto-yarn/contents/{+path}","compare_url":"https://api.github.com/repos/prestodb/presto-yarn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prestodb/presto-yarn/merges","archive_url":"https://api.github.com/repos/prestodb/presto-yarn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prestodb/presto-yarn/downloads","issues_url":"https://api.github.com/repos/prestodb/presto-yarn/issues{/number}","pulls_url":"https://api.github.com/repos/prestodb/presto-yarn/pulls{/number}","milestones_url":"https://api.github.com/repos/prestodb/presto-yarn/milestones{/number}","notifications_url":"https://api.github.com/repos/prestodb/presto-yarn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prestodb/presto-yarn/labels{/name}","releases_url":"https://api.github.com/repos/prestodb/presto-yarn/releases{/id}","created_at":"2015-09-21T18:55:00Z","updated_at":"2015-09-22T17:03:45Z","pushed_at":"2015-10-07T20:53:32Z","git_url":"git://github.com/prestodb/presto-yarn.git","ssh_url":"git@github.com:prestodb/presto-yarn.git","clone_url":"https://github.com/prestodb/presto-yarn.git","svn_url":"https://github.com/prestodb/presto-yarn","homepage":null,"size":43432,"stargazers_count":6,"watchers_count":6,"language":"Groovy","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/prestodb/presto-yarn/pulls/5"},"html":{"href":"https://github.com/prestodb/presto-yarn/pull/5"},"issue":{"href":"https://api.github.com/repos/prestodb/presto-yarn/issues/5"},"comments":{"href":"https://api.github.com/repos/prestodb/presto-yarn/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/prestodb/presto-yarn/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/prestodb/presto-yarn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/prestodb/presto-yarn/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/prestodb/presto-yarn/statuses/a0214dc235f9c19de2b57c48d671468becc1847e"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":10,"deletions":3,"changed_files":2}}