{"action":"created","comment":{"url":"https://api.github.com/repos/docker/docker/pulls/comments/26887611","id":26887611,"diff_hunk":"@@ -239,9 +239,18 @@ func TestBuildEnvironmentReplacementEnv(t *testing.T) {\n \n \t_, err := buildImage(name,\n \t\t`\n-  FROM scratch\n+  FROM busybox\n   ENV foo foo\n   ENV bar ${foo}\n+  ENV abc1='$foo'\n+  ENV env1=$foo env2=${foo} env3=\"$foo\" env4=\"${foo}\"\n+  RUN [ \"$abc1\" = '$foo' ] && (echo \"$abc1\" | grep foo)","path":"integration-cli/docker_cli_build_test.go","position":10,"original_position":10,"commit_id":"a361f4e25efd4d106de0338cdcba5684252f8ccb","original_commit_id":"a361f4e25efd4d106de0338cdcba5684252f8ccb","user":{"login":"tiborvass","id":827131,"avatar_url":"https://avatars.githubusercontent.com/u/827131?v=3","gravatar_id":"","url":"https://api.github.com/users/tiborvass","html_url":"https://github.com/tiborvass","followers_url":"https://api.github.com/users/tiborvass/followers","following_url":"https://api.github.com/users/tiborvass/following{/other_user}","gists_url":"https://api.github.com/users/tiborvass/gists{/gist_id}","starred_url":"https://api.github.com/users/tiborvass/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiborvass/subscriptions","organizations_url":"https://api.github.com/users/tiborvass/orgs","repos_url":"https://api.github.com/users/tiborvass/repos","events_url":"https://api.github.com/users/tiborvass/events{/privacy}","received_events_url":"https://api.github.com/users/tiborvass/received_events","type":"User","site_admin":false},"body":"@duglin if $foo were replaced it would be replaced to `foo`.","created_at":"2015-03-21T01:59:20Z","updated_at":"2015-03-21T01:59:20Z","html_url":"https://github.com/docker/docker/pull/10431#discussion_r26887611","pull_request_url":"https://api.github.com/repos/docker/docker/pulls/10431","_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/comments/26887611"},"html":{"href":"https://github.com/docker/docker/pull/10431#discussion_r26887611"},"pull_request":{"href":"https://api.github.com/repos/docker/docker/pulls/10431"}}},"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/10431","id":28249137,"html_url":"https://github.com/docker/docker/pull/10431","diff_url":"https://github.com/docker/docker/pull/10431.diff","patch_url":"https://github.com/docker/docker/pull/10431.patch","issue_url":"https://api.github.com/repos/docker/docker/issues/10431","number":10431,"state":"open","locked":false,"title":"Clarify ENV non-recursivenes w.r.t. env var substitution + fix escaping","user":{"login":"duglin","id":1944671,"avatar_url":"https://avatars.githubusercontent.com/u/1944671?v=3","gravatar_id":"","url":"https://api.github.com/users/duglin","html_url":"https://github.com/duglin","followers_url":"https://api.github.com/users/duglin/followers","following_url":"https://api.github.com/users/duglin/following{/other_user}","gists_url":"https://api.github.com/users/duglin/gists{/gist_id}","starred_url":"https://api.github.com/users/duglin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duglin/subscriptions","organizations_url":"https://api.github.com/users/duglin/orgs","repos_url":"https://api.github.com/users/duglin/repos","events_url":"https://api.github.com/users/duglin/events{/privacy}","received_events_url":"https://api.github.com/users/duglin/received_events","type":"User","site_admin":false},"body":"Fix some escaping in ENVs and clarify that ENV is not recursive\r\n\r\nCloses #10391\r\n\r\nSupport for #8667 will be done in a new PR.\r\n\r\nSigned-off-by: Doug Davis <dug@us.ibm.com>","created_at":"2015-01-29T02:31:17Z","updated_at":"2015-03-21T01:59:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4e19bc7a4cf257c0f9598ac4e13dbb1df9abd82a","assignee":null,"milestone":{"url":"https://api.github.com/repos/docker/docker/milestones/37","html_url":"https://github.com/docker/docker/milestones/1.6.0","labels_url":"https://api.github.com/repos/docker/docker/milestones/37/labels","id":952335,"number":37,"title":"1.6.0","description":"","creator":{"login":"crosbymichael","id":749551,"avatar_url":"https://avatars.githubusercontent.com/u/749551?v=3","gravatar_id":"","url":"https://api.github.com/users/crosbymichael","html_url":"https://github.com/crosbymichael","followers_url":"https://api.github.com/users/crosbymichael/followers","following_url":"https://api.github.com/users/crosbymichael/following{/other_user}","gists_url":"https://api.github.com/users/crosbymichael/gists{/gist_id}","starred_url":"https://api.github.com/users/crosbymichael/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crosbymichael/subscriptions","organizations_url":"https://api.github.com/users/crosbymichael/orgs","repos_url":"https://api.github.com/users/crosbymichael/repos","events_url":"https://api.github.com/users/crosbymichael/events{/privacy}","received_events_url":"https://api.github.com/users/crosbymichael/received_events","type":"User","site_admin":false},"open_issues":19,"closed_issues":66,"state":"open","created_at":"2015-01-26T23:40:13Z","updated_at":"2015-03-21T01:35:16Z","due_on":"2015-03-23T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/docker/docker/pulls/10431/commits","review_comments_url":"https://api.github.com/repos/docker/docker/pulls/10431/comments","review_comment_url":"https://api.github.com/repos/docker/docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/docker/issues/10431/comments","statuses_url":"https://api.github.com/repos/docker/docker/statuses/a361f4e25efd4d106de0338cdcba5684252f8ccb","head":{"label":"duglin:Issue10391","ref":"Issue10391","sha":"a361f4e25efd4d106de0338cdcba5684252f8ccb","user":{"login":"duglin","id":1944671,"avatar_url":"https://avatars.githubusercontent.com/u/1944671?v=3","gravatar_id":"","url":"https://api.github.com/users/duglin","html_url":"https://github.com/duglin","followers_url":"https://api.github.com/users/duglin/followers","following_url":"https://api.github.com/users/duglin/following{/other_user}","gists_url":"https://api.github.com/users/duglin/gists{/gist_id}","starred_url":"https://api.github.com/users/duglin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duglin/subscriptions","organizations_url":"https://api.github.com/users/duglin/orgs","repos_url":"https://api.github.com/users/duglin/repos","events_url":"https://api.github.com/users/duglin/events{/privacy}","received_events_url":"https://api.github.com/users/duglin/received_events","type":"User","site_admin":false},"repo":{"id":22769065,"name":"docker","full_name":"duglin/docker","owner":{"login":"duglin","id":1944671,"avatar_url":"https://avatars.githubusercontent.com/u/1944671?v=3","gravatar_id":"","url":"https://api.github.com/users/duglin","html_url":"https://github.com/duglin","followers_url":"https://api.github.com/users/duglin/followers","following_url":"https://api.github.com/users/duglin/following{/other_user}","gists_url":"https://api.github.com/users/duglin/gists{/gist_id}","starred_url":"https://api.github.com/users/duglin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duglin/subscriptions","organizations_url":"https://api.github.com/users/duglin/orgs","repos_url":"https://api.github.com/users/duglin/repos","events_url":"https://api.github.com/users/duglin/events{/privacy}","received_events_url":"https://api.github.com/users/duglin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/duglin/docker","description":"Docker - the open-source application container engine","fork":true,"url":"https://api.github.com/repos/duglin/docker","forks_url":"https://api.github.com/repos/duglin/docker/forks","keys_url":"https://api.github.com/repos/duglin/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/duglin/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/duglin/docker/teams","hooks_url":"https://api.github.com/repos/duglin/docker/hooks","issue_events_url":"https://api.github.com/repos/duglin/docker/issues/events{/number}","events_url":"https://api.github.com/repos/duglin/docker/events","assignees_url":"https://api.github.com/repos/duglin/docker/assignees{/user}","branches_url":"https://api.github.com/repos/duglin/docker/branches{/branch}","tags_url":"https://api.github.com/repos/duglin/docker/tags","blobs_url":"https://api.github.com/repos/duglin/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/duglin/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/duglin/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/duglin/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/duglin/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/duglin/docker/languages","stargazers_url":"https://api.github.com/repos/duglin/docker/stargazers","contributors_url":"https://api.github.com/repos/duglin/docker/contributors","subscribers_url":"https://api.github.com/repos/duglin/docker/subscribers","subscription_url":"https://api.github.com/repos/duglin/docker/subscription","commits_url":"https://api.github.com/repos/duglin/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/duglin/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/duglin/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/duglin/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/duglin/docker/contents/{+path}","compare_url":"https://api.github.com/repos/duglin/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/duglin/docker/merges","archive_url":"https://api.github.com/repos/duglin/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/duglin/docker/downloads","issues_url":"https://api.github.com/repos/duglin/docker/issues{/number}","pulls_url":"https://api.github.com/repos/duglin/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/duglin/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/duglin/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/duglin/docker/labels{/name}","releases_url":"https://api.github.com/repos/duglin/docker/releases{/id}","created_at":"2014-08-08T19:24:58Z","updated_at":"2015-03-20T12:03:28Z","pushed_at":"2015-03-20T17:29:35Z","git_url":"git://github.com/duglin/docker.git","ssh_url":"git@github.com:duglin/docker.git","clone_url":"https://github.com/duglin/docker.git","svn_url":"https://github.com/duglin/docker","homepage":"http://www.docker.com","size":47221,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"831c796fb7cdf7f9bd429d65b6e420405e2cae83","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":7691631,"name":"docker","full_name":"docker/docker","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/docker","description":"Docker - the open-source application container engine","fork":false,"url":"https://api.github.com/repos/docker/docker","forks_url":"https://api.github.com/repos/docker/docker/forks","keys_url":"https://api.github.com/repos/docker/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/docker/teams","hooks_url":"https://api.github.com/repos/docker/docker/hooks","issue_events_url":"https://api.github.com/repos/docker/docker/issues/events{/number}","events_url":"https://api.github.com/repos/docker/docker/events","assignees_url":"https://api.github.com/repos/docker/docker/assignees{/user}","branches_url":"https://api.github.com/repos/docker/docker/branches{/branch}","tags_url":"https://api.github.com/repos/docker/docker/tags","blobs_url":"https://api.github.com/repos/docker/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/docker/languages","stargazers_url":"https://api.github.com/repos/docker/docker/stargazers","contributors_url":"https://api.github.com/repos/docker/docker/contributors","subscribers_url":"https://api.github.com/repos/docker/docker/subscribers","subscription_url":"https://api.github.com/repos/docker/docker/subscription","commits_url":"https://api.github.com/repos/docker/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/docker/contents/{+path}","compare_url":"https://api.github.com/repos/docker/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/docker/merges","archive_url":"https://api.github.com/repos/docker/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/docker/downloads","issues_url":"https://api.github.com/repos/docker/docker/issues{/number}","pulls_url":"https://api.github.com/repos/docker/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/docker/labels{/name}","releases_url":"https://api.github.com/repos/docker/docker/releases{/id}","created_at":"2013-01-18T18:10:57Z","updated_at":"2015-03-21T01:56:00Z","pushed_at":"2015-03-21T00:30:03Z","git_url":"git://github.com/docker/docker.git","ssh_url":"git@github.com:docker/docker.git","clone_url":"https://github.com/docker/docker.git","svn_url":"https://github.com/docker/docker","homepage":"http://www.docker.com","size":155190,"stargazers_count":20014,"watchers_count":20014,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4221,"mirror_url":null,"open_issues_count":793,"forks":4221,"open_issues":793,"watchers":20014,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/10431"},"html":{"href":"https://github.com/docker/docker/pull/10431"},"issue":{"href":"https://api.github.com/repos/docker/docker/issues/10431"},"comments":{"href":"https://api.github.com/repos/docker/docker/issues/10431/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/docker/pulls/10431/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/docker/pulls/10431/commits"},"statuses":{"href":"https://api.github.com/repos/docker/docker/statuses/a361f4e25efd4d106de0338cdcba5684252f8ccb"}}}}