{"action":"created","comment":{"url":"https://api.github.com/repos/symfony/symfony/pulls/comments/43586655","id":43586655,"diff_hunk":"@@ -167,12 +168,12 @@ public function resolve()\n      * @throws ParameterCircularReferenceException if a circular reference if detected\n      * @throws RuntimeException                    when a given parameter has a type problem.\n      */\n-    public function resolveValue($value, array $resolving = array())\n+    public function resolveValue($value, array $resolving = array(), $protectEnvVariables = false)","path":"src/Symfony/Component/DependencyInjection/ParameterBag/ParameterBag.php","position":13,"original_position":13,"commit_id":"ecec857c306ae3e50e5e24550feb4e6f2f34f755","original_commit_id":"ecec857c306ae3e50e5e24550feb4e6f2f34f755","user":{"login":"ogizanagi","id":2211145,"avatar_url":"https://avatars.githubusercontent.com/u/2211145?v=3","gravatar_id":"","url":"https://api.github.com/users/ogizanagi","html_url":"https://github.com/ogizanagi","followers_url":"https://api.github.com/users/ogizanagi/followers","following_url":"https://api.github.com/users/ogizanagi/following{/other_user}","gists_url":"https://api.github.com/users/ogizanagi/gists{/gist_id}","starred_url":"https://api.github.com/users/ogizanagi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ogizanagi/subscriptions","organizations_url":"https://api.github.com/users/ogizanagi/orgs","repos_url":"https://api.github.com/users/ogizanagi/repos","events_url":"https://api.github.com/users/ogizanagi/events{/privacy}","received_events_url":"https://api.github.com/users/ogizanagi/received_events","type":"User","site_admin":false},"body":"The new `protectEnvVariables` param is missing from the docblock.","created_at":"2015-11-01T19:41:31Z","updated_at":"2015-11-01T19:41:31Z","html_url":"https://github.com/symfony/symfony/pull/16403#discussion_r43586655","pull_request_url":"https://api.github.com/repos/symfony/symfony/pulls/16403","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/43586655"},"html":{"href":"https://github.com/symfony/symfony/pull/16403#discussion_r43586655"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony/pulls/16403"}}},"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/16403","id":49331941,"html_url":"https://github.com/symfony/symfony/pull/16403","diff_url":"https://github.com/symfony/symfony/pull/16403.diff","patch_url":"https://github.com/symfony/symfony/pull/16403.patch","issue_url":"https://api.github.com/repos/symfony/symfony/issues/16403","number":16403,"state":"open","locked":false,"title":"[DependencyInjection] added a way to reference dynamic environment variables in service definitions","user":{"login":"fabpot","id":47313,"avatar_url":"https://avatars.githubusercontent.com/u/47313?v=3","gravatar_id":"","url":"https://api.github.com/users/fabpot","html_url":"https://github.com/fabpot","followers_url":"https://api.github.com/users/fabpot/followers","following_url":"https://api.github.com/users/fabpot/following{/other_user}","gists_url":"https://api.github.com/users/fabpot/gists{/gist_id}","starred_url":"https://api.github.com/users/fabpot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabpot/subscriptions","organizations_url":"https://api.github.com/users/fabpot/orgs","repos_url":"https://api.github.com/users/fabpot/repos","events_url":"https://api.github.com/users/fabpot/events{/privacy}","received_events_url":"https://api.github.com/users/fabpot/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Bug fix?      | yesish\r\n| New feature?  | yes\r\n| BC breaks?    | no\r\n| Deprecations? | no\r\n| Tests pass?   | yes\r\n| Fixed tickets | #10138, #7555\r\n| License       | MIT\r\n| Doc PR        | not yet\r\n\r\nWhen hosting a Symfony app on some PaaS like Heroku, or even if you are just using Docker, you need a way to reference environment variables in the container. That's already possible in Symfony but the values are dumped into the cache. This PR adds a way to reference an env variable that is resolved dynamically even on a compiled container.\r\n\r\nping @dzuelke\r\n\r\n","created_at":"2015-10-30T23:01:35Z","updated_at":"2015-11-01T19:41:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"930301f093c28966185b9b68bf43772cdb0f1b91","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/symfony/symfony/pulls/16403/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony/pulls/16403/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/16403/comments","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/ecec857c306ae3e50e5e24550feb4e6f2f34f755","head":{"label":"fabpot:env-parameters","ref":"env-parameters","sha":"ecec857c306ae3e50e5e24550feb4e6f2f34f755","user":{"login":"fabpot","id":47313,"avatar_url":"https://avatars.githubusercontent.com/u/47313?v=3","gravatar_id":"","url":"https://api.github.com/users/fabpot","html_url":"https://github.com/fabpot","followers_url":"https://api.github.com/users/fabpot/followers","following_url":"https://api.github.com/users/fabpot/following{/other_user}","gists_url":"https://api.github.com/users/fabpot/gists{/gist_id}","starred_url":"https://api.github.com/users/fabpot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabpot/subscriptions","organizations_url":"https://api.github.com/users/fabpot/orgs","repos_url":"https://api.github.com/users/fabpot/repos","events_url":"https://api.github.com/users/fabpot/events{/privacy}","received_events_url":"https://api.github.com/users/fabpot/received_events","type":"User","site_admin":false},"repo":{"id":458135,"name":"symfony","full_name":"fabpot/symfony","owner":{"login":"fabpot","id":47313,"avatar_url":"https://avatars.githubusercontent.com/u/47313?v=3","gravatar_id":"","url":"https://api.github.com/users/fabpot","html_url":"https://github.com/fabpot","followers_url":"https://api.github.com/users/fabpot/followers","following_url":"https://api.github.com/users/fabpot/following{/other_user}","gists_url":"https://api.github.com/users/fabpot/gists{/gist_id}","starred_url":"https://api.github.com/users/fabpot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabpot/subscriptions","organizations_url":"https://api.github.com/users/fabpot/orgs","repos_url":"https://api.github.com/users/fabpot/repos","events_url":"https://api.github.com/users/fabpot/events{/privacy}","received_events_url":"https://api.github.com/users/fabpot/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fabpot/symfony","description":"The Symfony PHP framework","fork":true,"url":"https://api.github.com/repos/fabpot/symfony","forks_url":"https://api.github.com/repos/fabpot/symfony/forks","keys_url":"https://api.github.com/repos/fabpot/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fabpot/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fabpot/symfony/teams","hooks_url":"https://api.github.com/repos/fabpot/symfony/hooks","issue_events_url":"https://api.github.com/repos/fabpot/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/fabpot/symfony/events","assignees_url":"https://api.github.com/repos/fabpot/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/fabpot/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/fabpot/symfony/tags","blobs_url":"https://api.github.com/repos/fabpot/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fabpot/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fabpot/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/fabpot/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fabpot/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/fabpot/symfony/languages","stargazers_url":"https://api.github.com/repos/fabpot/symfony/stargazers","contributors_url":"https://api.github.com/repos/fabpot/symfony/contributors","subscribers_url":"https://api.github.com/repos/fabpot/symfony/subscribers","subscription_url":"https://api.github.com/repos/fabpot/symfony/subscription","commits_url":"https://api.github.com/repos/fabpot/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/fabpot/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/fabpot/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/fabpot/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/fabpot/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/fabpot/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fabpot/symfony/merges","archive_url":"https://api.github.com/repos/fabpot/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fabpot/symfony/downloads","issues_url":"https://api.github.com/repos/fabpot/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/fabpot/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/fabpot/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/fabpot/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fabpot/symfony/labels{/name}","releases_url":"https://api.github.com/repos/fabpot/symfony/releases{/id}","created_at":"2010-01-04T15:41:06Z","updated_at":"2015-10-28T05:51:47Z","pushed_at":"2015-10-31T14:56:13Z","git_url":"git://github.com/fabpot/symfony.git","ssh_url":"git@github.com:fabpot/symfony.git","clone_url":"https://github.com/fabpot/symfony.git","svn_url":"https://github.com/fabpot/symfony","homepage":"http://symfony.com/","size":68961,"stargazers_count":343,"watchers_count":343,"language":"PHP","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":51,"mirror_url":null,"open_issues_count":0,"forks":51,"open_issues":0,"watchers":343,"default_branch":"master"}},"base":{"label":"symfony:2.8","ref":"2.8","sha":"a15c9eb82d36855672aa05c91cfb045ae146bde1","user":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":458058,"name":"symfony","full_name":"symfony/symfony","owner":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/symfony","description":"The Symfony PHP framework","fork":false,"url":"https://api.github.com/repos/symfony/symfony","forks_url":"https://api.github.com/repos/symfony/symfony/forks","keys_url":"https://api.github.com/repos/symfony/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony/teams","hooks_url":"https://api.github.com/repos/symfony/symfony/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony/events","assignees_url":"https://api.github.com/repos/symfony/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony/tags","blobs_url":"https://api.github.com/repos/symfony/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony/subscription","commits_url":"https://api.github.com/repos/symfony/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony/merges","archive_url":"https://api.github.com/repos/symfony/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony/downloads","issues_url":"https://api.github.com/repos/symfony/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony/releases{/id}","created_at":"2010-01-04T14:21:21Z","updated_at":"2015-11-01T19:35:41Z","pushed_at":"2015-11-01T17:39:17Z","git_url":"git://github.com/symfony/symfony.git","ssh_url":"git@github.com:symfony/symfony.git","clone_url":"https://github.com/symfony/symfony.git","svn_url":"https://github.com/symfony/symfony","homepage":"symfony.com","size":259060,"stargazers_count":11059,"watchers_count":11059,"language":"PHP","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":4349,"mirror_url":null,"open_issues_count":782,"forks":4349,"open_issues":782,"watchers":11059,"default_branch":"2.8"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/16403"},"html":{"href":"https://github.com/symfony/symfony/pull/16403"},"issue":{"href":"https://api.github.com/repos/symfony/symfony/issues/16403"},"comments":{"href":"https://api.github.com/repos/symfony/symfony/issues/16403/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony/pulls/16403/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony/pulls/16403/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony/statuses/ecec857c306ae3e50e5e24550feb4e6f2f34f755"}}}}