{"action":"closed","number":23,"pull_request":{"url":"https://api.github.com/repos/migzai/irc-api/pulls/23","id":31779258,"html_url":"https://github.com/migzai/irc-api/pull/23","diff_url":"https://github.com/migzai/irc-api/pull/23.diff","patch_url":"https://github.com/migzai/irc-api/pull/23.patch","issue_url":"https://api.github.com/repos/migzai/irc-api/issues/23","number":23,"state":"closed","locked":false,"title":"SOCKS 5 proxy support","user":{"login":"cobratbq","id":1936470,"avatar_url":"https://avatars.githubusercontent.com/u/1936470?v=3","gravatar_id":"","url":"https://api.github.com/users/cobratbq","html_url":"https://github.com/cobratbq","followers_url":"https://api.github.com/users/cobratbq/followers","following_url":"https://api.github.com/users/cobratbq/following{/other_user}","gists_url":"https://api.github.com/users/cobratbq/gists{/gist_id}","starred_url":"https://api.github.com/users/cobratbq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cobratbq/subscriptions","organizations_url":"https://api.github.com/users/cobratbq/orgs","repos_url":"https://api.github.com/users/cobratbq/repos","events_url":"https://api.github.com/users/cobratbq/events{/privacy}","received_events_url":"https://api.github.com/users/cobratbq/received_events","type":"User","site_admin":false},"body":"SOCKS 5 proxy support including deferring DNS domain name resolving to proxy.\r\n\r\nThis includes a custom SocketChannel implementation that utilizes a Socket internally for its proxy support. Non-blocking behaviour is not implemented yet, but was not used by irc-api anyways, so it does not degrade features anyway.\r\nI have included the implementation directly in the pull request. Let me know if this is a problem for you.\r\n\r\nPlease have a look at this. I am not suggesting you merge the PR as is. I'm open to suggestions. (Unless rebasing failed, this should be in fully workable form.)","created_at":"2015-03-23T22:08:57Z","updated_at":"2015-04-03T19:31:37Z","closed_at":"2015-04-03T19:31:37Z","merged_at":null,"merge_commit_sha":"3faaa3aa148272a2c298ae47f7b0b33a5c448226","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/migzai/irc-api/pulls/23/commits","review_comments_url":"https://api.github.com/repos/migzai/irc-api/pulls/23/comments","review_comment_url":"https://api.github.com/repos/migzai/irc-api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/migzai/irc-api/issues/23/comments","statuses_url":"https://api.github.com/repos/migzai/irc-api/statuses/f72adeaebda3f334bb6d9eebaec6eb56a522951f","head":{"label":"cobratbq:proxy-rebased","ref":"proxy-rebased","sha":"f72adeaebda3f334bb6d9eebaec6eb56a522951f","user":{"login":"cobratbq","id":1936470,"avatar_url":"https://avatars.githubusercontent.com/u/1936470?v=3","gravatar_id":"","url":"https://api.github.com/users/cobratbq","html_url":"https://github.com/cobratbq","followers_url":"https://api.github.com/users/cobratbq/followers","following_url":"https://api.github.com/users/cobratbq/following{/other_user}","gists_url":"https://api.github.com/users/cobratbq/gists{/gist_id}","starred_url":"https://api.github.com/users/cobratbq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cobratbq/subscriptions","organizations_url":"https://api.github.com/users/cobratbq/orgs","repos_url":"https://api.github.com/users/cobratbq/repos","events_url":"https://api.github.com/users/cobratbq/events{/privacy}","received_events_url":"https://api.github.com/users/cobratbq/received_events","type":"User","site_admin":false},"repo":{"id":32760977,"name":"irc-api","full_name":"cobratbq/irc-api","owner":{"login":"cobratbq","id":1936470,"avatar_url":"https://avatars.githubusercontent.com/u/1936470?v=3","gravatar_id":"","url":"https://api.github.com/users/cobratbq","html_url":"https://github.com/cobratbq","followers_url":"https://api.github.com/users/cobratbq/followers","following_url":"https://api.github.com/users/cobratbq/following{/other_user}","gists_url":"https://api.github.com/users/cobratbq/gists{/gist_id}","starred_url":"https://api.github.com/users/cobratbq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cobratbq/subscriptions","organizations_url":"https://api.github.com/users/cobratbq/orgs","repos_url":"https://api.github.com/users/cobratbq/repos","events_url":"https://api.github.com/users/cobratbq/events{/privacy}","received_events_url":"https://api.github.com/users/cobratbq/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cobratbq/irc-api","description":"A Java IRC API","fork":true,"url":"https://api.github.com/repos/cobratbq/irc-api","forks_url":"https://api.github.com/repos/cobratbq/irc-api/forks","keys_url":"https://api.github.com/repos/cobratbq/irc-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cobratbq/irc-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cobratbq/irc-api/teams","hooks_url":"https://api.github.com/repos/cobratbq/irc-api/hooks","issue_events_url":"https://api.github.com/repos/cobratbq/irc-api/issues/events{/number}","events_url":"https://api.github.com/repos/cobratbq/irc-api/events","assignees_url":"https://api.github.com/repos/cobratbq/irc-api/assignees{/user}","branches_url":"https://api.github.com/repos/cobratbq/irc-api/branches{/branch}","tags_url":"https://api.github.com/repos/cobratbq/irc-api/tags","blobs_url":"https://api.github.com/repos/cobratbq/irc-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cobratbq/irc-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cobratbq/irc-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/cobratbq/irc-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cobratbq/irc-api/statuses/{sha}","languages_url":"https://api.github.com/repos/cobratbq/irc-api/languages","stargazers_url":"https://api.github.com/repos/cobratbq/irc-api/stargazers","contributors_url":"https://api.github.com/repos/cobratbq/irc-api/contributors","subscribers_url":"https://api.github.com/repos/cobratbq/irc-api/subscribers","subscription_url":"https://api.github.com/repos/cobratbq/irc-api/subscription","commits_url":"https://api.github.com/repos/cobratbq/irc-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/cobratbq/irc-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/cobratbq/irc-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/cobratbq/irc-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/cobratbq/irc-api/contents/{+path}","compare_url":"https://api.github.com/repos/cobratbq/irc-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cobratbq/irc-api/merges","archive_url":"https://api.github.com/repos/cobratbq/irc-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cobratbq/irc-api/downloads","issues_url":"https://api.github.com/repos/cobratbq/irc-api/issues{/number}","pulls_url":"https://api.github.com/repos/cobratbq/irc-api/pulls{/number}","milestones_url":"https://api.github.com/repos/cobratbq/irc-api/milestones{/number}","notifications_url":"https://api.github.com/repos/cobratbq/irc-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cobratbq/irc-api/labels{/name}","releases_url":"https://api.github.com/repos/cobratbq/irc-api/releases{/id}","created_at":"2015-03-23T21:52:53Z","updated_at":"2015-03-23T23:08:49Z","pushed_at":"2015-04-03T19:31:37Z","git_url":"git://github.com/cobratbq/irc-api.git","ssh_url":"git@github.com:cobratbq/irc-api.git","clone_url":"https://github.com/cobratbq/irc-api.git","svn_url":"https://github.com/cobratbq/irc-api","homepage":"","size":386,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"migzai:master","ref":"master","sha":"2a688fe7b6cf852820f3aa233e5b4546606edc97","user":{"login":"migzai","id":5177584,"avatar_url":"https://avatars.githubusercontent.com/u/5177584?v=3","gravatar_id":"","url":"https://api.github.com/users/migzai","html_url":"https://github.com/migzai","followers_url":"https://api.github.com/users/migzai/followers","following_url":"https://api.github.com/users/migzai/following{/other_user}","gists_url":"https://api.github.com/users/migzai/gists{/gist_id}","starred_url":"https://api.github.com/users/migzai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/migzai/subscriptions","organizations_url":"https://api.github.com/users/migzai/orgs","repos_url":"https://api.github.com/users/migzai/repos","events_url":"https://api.github.com/users/migzai/events{/privacy}","received_events_url":"https://api.github.com/users/migzai/received_events","type":"User","site_admin":false},"repo":{"id":32316352,"name":"irc-api","full_name":"migzai/irc-api","owner":{"login":"migzai","id":5177584,"avatar_url":"https://avatars.githubusercontent.com/u/5177584?v=3","gravatar_id":"","url":"https://api.github.com/users/migzai","html_url":"https://github.com/migzai","followers_url":"https://api.github.com/users/migzai/followers","following_url":"https://api.github.com/users/migzai/following{/other_user}","gists_url":"https://api.github.com/users/migzai/gists{/gist_id}","starred_url":"https://api.github.com/users/migzai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/migzai/subscriptions","organizations_url":"https://api.github.com/users/migzai/orgs","repos_url":"https://api.github.com/users/migzai/repos","events_url":"https://api.github.com/users/migzai/events{/privacy}","received_events_url":"https://api.github.com/users/migzai/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/migzai/irc-api","description":"A Java IRC API","fork":false,"url":"https://api.github.com/repos/migzai/irc-api","forks_url":"https://api.github.com/repos/migzai/irc-api/forks","keys_url":"https://api.github.com/repos/migzai/irc-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/migzai/irc-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/migzai/irc-api/teams","hooks_url":"https://api.github.com/repos/migzai/irc-api/hooks","issue_events_url":"https://api.github.com/repos/migzai/irc-api/issues/events{/number}","events_url":"https://api.github.com/repos/migzai/irc-api/events","assignees_url":"https://api.github.com/repos/migzai/irc-api/assignees{/user}","branches_url":"https://api.github.com/repos/migzai/irc-api/branches{/branch}","tags_url":"https://api.github.com/repos/migzai/irc-api/tags","blobs_url":"https://api.github.com/repos/migzai/irc-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/migzai/irc-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/migzai/irc-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/migzai/irc-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/migzai/irc-api/statuses/{sha}","languages_url":"https://api.github.com/repos/migzai/irc-api/languages","stargazers_url":"https://api.github.com/repos/migzai/irc-api/stargazers","contributors_url":"https://api.github.com/repos/migzai/irc-api/contributors","subscribers_url":"https://api.github.com/repos/migzai/irc-api/subscribers","subscription_url":"https://api.github.com/repos/migzai/irc-api/subscription","commits_url":"https://api.github.com/repos/migzai/irc-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/migzai/irc-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/migzai/irc-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/migzai/irc-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/migzai/irc-api/contents/{+path}","compare_url":"https://api.github.com/repos/migzai/irc-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/migzai/irc-api/merges","archive_url":"https://api.github.com/repos/migzai/irc-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/migzai/irc-api/downloads","issues_url":"https://api.github.com/repos/migzai/irc-api/issues{/number}","pulls_url":"https://api.github.com/repos/migzai/irc-api/pulls{/number}","milestones_url":"https://api.github.com/repos/migzai/irc-api/milestones{/number}","notifications_url":"https://api.github.com/repos/migzai/irc-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/migzai/irc-api/labels{/name}","releases_url":"https://api.github.com/repos/migzai/irc-api/releases{/id}","created_at":"2015-03-16T10:05:54Z","updated_at":"2015-03-20T06:59:04Z","pushed_at":"2015-03-23T22:08:57Z","git_url":"git://github.com/migzai/irc-api.git","ssh_url":"git@github.com:migzai/irc-api.git","clone_url":"https://github.com/migzai/irc-api.git","svn_url":"https://github.com/migzai/irc-api","homepage":"","size":465,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/migzai/irc-api/pulls/23"},"html":{"href":"https://github.com/migzai/irc-api/pull/23"},"issue":{"href":"https://api.github.com/repos/migzai/irc-api/issues/23"},"comments":{"href":"https://api.github.com/repos/migzai/irc-api/issues/23/comments"},"review_comments":{"href":"https://api.github.com/repos/migzai/irc-api/pulls/23/comments"},"review_comment":{"href":"https://api.github.com/repos/migzai/irc-api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/migzai/irc-api/pulls/23/commits"},"statuses":{"href":"https://api.github.com/repos/migzai/irc-api/statuses/f72adeaebda3f334bb6d9eebaec6eb56a522951f"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":4,"additions":517,"deletions":38,"changed_files":8}}