{"action":"created","comment":{"url":"https://api.github.com/repos/rails/rails/pulls/comments/37270203","id":37270203,"diff_hunk":"@@ -150,16 +147,13 @@ def test_environment_with_block_should_include_block_contents_in_environment_ini\n   end\n \n   def test_git_with_symbol_should_run_command_using_git_scm\n-    @mock_generator.expect(:call, nil, ['git init'])\n-    generator.stub(:run, @mock_generator) do\n+    assert_called_with(generator, :run, ['git init']) do\n       action :git, :init\n     end\n   end\n \n   def test_git_with_hash_should_run_each_command_using_git_scm\n-    @mock_generator.expect(:call, nil, [\"git rm README\"])\n-    @mock_generator.expect(:call, nil, [\"git add .\"])\n-    generator.stub(:run, @mock_generator) do\n+    assert_called(generator, :run, times: 2) do","path":"railties/test/generators/actions_test.rb","position":37,"original_position":37,"commit_id":"bb5beef1131ade32ccb5b9cc6af006f6e3b26c85","original_commit_id":"bb5beef1131ade32ccb5b9cc6af006f6e3b26c85","user":{"login":"senny","id":5402,"avatar_url":"https://avatars.githubusercontent.com/u/5402?v=3","gravatar_id":"","url":"https://api.github.com/users/senny","html_url":"https://github.com/senny","followers_url":"https://api.github.com/users/senny/followers","following_url":"https://api.github.com/users/senny/following{/other_user}","gists_url":"https://api.github.com/users/senny/gists{/gist_id}","starred_url":"https://api.github.com/users/senny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/senny/subscriptions","organizations_url":"https://api.github.com/users/senny/orgs","repos_url":"https://api.github.com/users/senny/repos","events_url":"https://api.github.com/users/senny/events{/privacy}","received_events_url":"https://api.github.com/users/senny/received_events","type":"User","site_admin":false},"body":"In my opinion this kind of test refactoring open potential holes in our suite. The assertions used to be specific, now with `times: 2` they are very generalized and don't have much meaning left.","created_at":"2015-08-18T07:16:40Z","updated_at":"2015-08-18T07:16:40Z","html_url":"https://github.com/rails/rails/pull/21279#discussion_r37270203","pull_request_url":"https://api.github.com/repos/rails/rails/pulls/21279","_links":{"self":{"href":"https://api.github.com/repos/rails/rails/pulls/comments/37270203"},"html":{"href":"https://github.com/rails/rails/pull/21279#discussion_r37270203"},"pull_request":{"href":"https://api.github.com/repos/rails/rails/pulls/21279"}}},"pull_request":{"url":"https://api.github.com/repos/rails/rails/pulls/21279","id":42651747,"html_url":"https://github.com/rails/rails/pull/21279","diff_url":"https://github.com/rails/rails/pull/21279.diff","patch_url":"https://github.com/rails/rails/pull/21279.patch","issue_url":"https://api.github.com/repos/rails/rails/issues/21279","number":21279,"state":"open","locked":false,"title":"Cleaned up generators tests using internal assertion helper","user":{"login":"ronakjangir47","id":1909242,"avatar_url":"https://avatars.githubusercontent.com/u/1909242?v=3","gravatar_id":"","url":"https://api.github.com/users/ronakjangir47","html_url":"https://github.com/ronakjangir47","followers_url":"https://api.github.com/users/ronakjangir47/followers","following_url":"https://api.github.com/users/ronakjangir47/following{/other_user}","gists_url":"https://api.github.com/users/ronakjangir47/gists{/gist_id}","starred_url":"https://api.github.com/users/ronakjangir47/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ronakjangir47/subscriptions","organizations_url":"https://api.github.com/users/ronakjangir47/orgs","repos_url":"https://api.github.com/users/ronakjangir47/repos","events_url":"https://api.github.com/users/ronakjangir47/events{/privacy}","received_events_url":"https://api.github.com/users/ronakjangir47/received_events","type":"User","site_admin":false},"body":"/cc @kaspth ","created_at":"2015-08-18T01:04:14Z","updated_at":"2015-08-18T07:16:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e7e676bbb6b0c233a0970443726eb363e9ef0c1e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rails/rails/pulls/21279/commits","review_comments_url":"https://api.github.com/repos/rails/rails/pulls/21279/comments","review_comment_url":"https://api.github.com/repos/rails/rails/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rails/rails/issues/21279/comments","statuses_url":"https://api.github.com/repos/rails/rails/statuses/bb5beef1131ade32ccb5b9cc6af006f6e3b26c85","head":{"label":"ronakjangir47:test_cleanup","ref":"test_cleanup","sha":"bb5beef1131ade32ccb5b9cc6af006f6e3b26c85","user":{"login":"ronakjangir47","id":1909242,"avatar_url":"https://avatars.githubusercontent.com/u/1909242?v=3","gravatar_id":"","url":"https://api.github.com/users/ronakjangir47","html_url":"https://github.com/ronakjangir47","followers_url":"https://api.github.com/users/ronakjangir47/followers","following_url":"https://api.github.com/users/ronakjangir47/following{/other_user}","gists_url":"https://api.github.com/users/ronakjangir47/gists{/gist_id}","starred_url":"https://api.github.com/users/ronakjangir47/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ronakjangir47/subscriptions","organizations_url":"https://api.github.com/users/ronakjangir47/orgs","repos_url":"https://api.github.com/users/ronakjangir47/repos","events_url":"https://api.github.com/users/ronakjangir47/events{/privacy}","received_events_url":"https://api.github.com/users/ronakjangir47/received_events","type":"User","site_admin":false},"repo":{"id":24029561,"name":"rails","full_name":"ronakjangir47/rails","owner":{"login":"ronakjangir47","id":1909242,"avatar_url":"https://avatars.githubusercontent.com/u/1909242?v=3","gravatar_id":"","url":"https://api.github.com/users/ronakjangir47","html_url":"https://github.com/ronakjangir47","followers_url":"https://api.github.com/users/ronakjangir47/followers","following_url":"https://api.github.com/users/ronakjangir47/following{/other_user}","gists_url":"https://api.github.com/users/ronakjangir47/gists{/gist_id}","starred_url":"https://api.github.com/users/ronakjangir47/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ronakjangir47/subscriptions","organizations_url":"https://api.github.com/users/ronakjangir47/orgs","repos_url":"https://api.github.com/users/ronakjangir47/repos","events_url":"https://api.github.com/users/ronakjangir47/events{/privacy}","received_events_url":"https://api.github.com/users/ronakjangir47/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ronakjangir47/rails","description":"Ruby on Rails","fork":true,"url":"https://api.github.com/repos/ronakjangir47/rails","forks_url":"https://api.github.com/repos/ronakjangir47/rails/forks","keys_url":"https://api.github.com/repos/ronakjangir47/rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ronakjangir47/rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ronakjangir47/rails/teams","hooks_url":"https://api.github.com/repos/ronakjangir47/rails/hooks","issue_events_url":"https://api.github.com/repos/ronakjangir47/rails/issues/events{/number}","events_url":"https://api.github.com/repos/ronakjangir47/rails/events","assignees_url":"https://api.github.com/repos/ronakjangir47/rails/assignees{/user}","branches_url":"https://api.github.com/repos/ronakjangir47/rails/branches{/branch}","tags_url":"https://api.github.com/repos/ronakjangir47/rails/tags","blobs_url":"https://api.github.com/repos/ronakjangir47/rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ronakjangir47/rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ronakjangir47/rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/ronakjangir47/rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ronakjangir47/rails/statuses/{sha}","languages_url":"https://api.github.com/repos/ronakjangir47/rails/languages","stargazers_url":"https://api.github.com/repos/ronakjangir47/rails/stargazers","contributors_url":"https://api.github.com/repos/ronakjangir47/rails/contributors","subscribers_url":"https://api.github.com/repos/ronakjangir47/rails/subscribers","subscription_url":"https://api.github.com/repos/ronakjangir47/rails/subscription","commits_url":"https://api.github.com/repos/ronakjangir47/rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/ronakjangir47/rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/ronakjangir47/rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/ronakjangir47/rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/ronakjangir47/rails/contents/{+path}","compare_url":"https://api.github.com/repos/ronakjangir47/rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ronakjangir47/rails/merges","archive_url":"https://api.github.com/repos/ronakjangir47/rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ronakjangir47/rails/downloads","issues_url":"https://api.github.com/repos/ronakjangir47/rails/issues{/number}","pulls_url":"https://api.github.com/repos/ronakjangir47/rails/pulls{/number}","milestones_url":"https://api.github.com/repos/ronakjangir47/rails/milestones{/number}","notifications_url":"https://api.github.com/repos/ronakjangir47/rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ronakjangir47/rails/labels{/name}","releases_url":"https://api.github.com/repos/ronakjangir47/rails/releases{/id}","created_at":"2014-09-14T18:25:14Z","updated_at":"2015-05-20T16:54:33Z","pushed_at":"2015-08-18T06:37:28Z","git_url":"git://github.com/ronakjangir47/rails.git","ssh_url":"git@github.com:ronakjangir47/rails.git","clone_url":"https://github.com/ronakjangir47/rails.git","svn_url":"https://github.com/ronakjangir47/rails","homepage":"http://rubyonrails.org","size":142030,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rails:master","ref":"master","sha":"88a1800526855edfc42209d4960b48550212fd8f","user":{"login":"rails","id":4223,"avatar_url":"https://avatars.githubusercontent.com/u/4223?v=3","gravatar_id":"","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"repo":{"id":8514,"name":"rails","full_name":"rails/rails","owner":{"login":"rails","id":4223,"avatar_url":"https://avatars.githubusercontent.com/u/4223?v=3","gravatar_id":"","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rails/rails","description":"Ruby on Rails","fork":false,"url":"https://api.github.com/repos/rails/rails","forks_url":"https://api.github.com/repos/rails/rails/forks","keys_url":"https://api.github.com/repos/rails/rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rails/rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rails/rails/teams","hooks_url":"https://api.github.com/repos/rails/rails/hooks","issue_events_url":"https://api.github.com/repos/rails/rails/issues/events{/number}","events_url":"https://api.github.com/repos/rails/rails/events","assignees_url":"https://api.github.com/repos/rails/rails/assignees{/user}","branches_url":"https://api.github.com/repos/rails/rails/branches{/branch}","tags_url":"https://api.github.com/repos/rails/rails/tags","blobs_url":"https://api.github.com/repos/rails/rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rails/rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rails/rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/rails/rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rails/rails/statuses/{sha}","languages_url":"https://api.github.com/repos/rails/rails/languages","stargazers_url":"https://api.github.com/repos/rails/rails/stargazers","contributors_url":"https://api.github.com/repos/rails/rails/contributors","subscribers_url":"https://api.github.com/repos/rails/rails/subscribers","subscription_url":"https://api.github.com/repos/rails/rails/subscription","commits_url":"https://api.github.com/repos/rails/rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/rails/rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/rails/rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/rails/rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/rails/rails/contents/{+path}","compare_url":"https://api.github.com/repos/rails/rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rails/rails/merges","archive_url":"https://api.github.com/repos/rails/rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rails/rails/downloads","issues_url":"https://api.github.com/repos/rails/rails/issues{/number}","pulls_url":"https://api.github.com/repos/rails/rails/pulls{/number}","milestones_url":"https://api.github.com/repos/rails/rails/milestones{/number}","notifications_url":"https://api.github.com/repos/rails/rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rails/rails/labels{/name}","releases_url":"https://api.github.com/repos/rails/rails/releases{/id}","created_at":"2008-04-11T02:19:47Z","updated_at":"2015-08-18T06:21:34Z","pushed_at":"2015-08-18T07:13:35Z","git_url":"git://github.com/rails/rails.git","ssh_url":"git@github.com:rails/rails.git","clone_url":"https://github.com/rails/rails.git","svn_url":"https://github.com/rails/rails","homepage":"http://rubyonrails.org","size":445060,"stargazers_count":27327,"watchers_count":27327,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10956,"mirror_url":null,"open_issues_count":894,"forks":10956,"open_issues":894,"watchers":27327,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rails/rails/pulls/21279"},"html":{"href":"https://github.com/rails/rails/pull/21279"},"issue":{"href":"https://api.github.com/repos/rails/rails/issues/21279"},"comments":{"href":"https://api.github.com/repos/rails/rails/issues/21279/comments"},"review_comments":{"href":"https://api.github.com/repos/rails/rails/pulls/21279/comments"},"review_comment":{"href":"https://api.github.com/repos/rails/rails/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rails/rails/pulls/21279/commits"},"statuses":{"href":"https://api.github.com/repos/rails/rails/statuses/bb5beef1131ade32ccb5b9cc6af006f6e3b26c85"}}}}