{"action":"created","issue":{"url":"https://api.github.com/repos/vufind-org/vufind/issues/348","labels_url":"https://api.github.com/repos/vufind-org/vufind/issues/348/labels{/name}","comments_url":"https://api.github.com/repos/vufind-org/vufind/issues/348/comments","events_url":"https://api.github.com/repos/vufind-org/vufind/issues/348/events","html_url":"https://github.com/vufind-org/vufind/pull/348","id":70067767,"number":348,"title":"enables conditional filters for Solr","user":{"login":"olli-gold","id":1461291,"avatar_url":"https://avatars.githubusercontent.com/u/1461291?v=3","gravatar_id":"","url":"https://api.github.com/users/olli-gold","html_url":"https://github.com/olli-gold","followers_url":"https://api.github.com/users/olli-gold/followers","following_url":"https://api.github.com/users/olli-gold/following{/other_user}","gists_url":"https://api.github.com/users/olli-gold/gists{/gist_id}","starred_url":"https://api.github.com/users/olli-gold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olli-gold/subscriptions","organizations_url":"https://api.github.com/users/olli-gold/orgs","repos_url":"https://api.github.com/users/olli-gold/repos","events_url":"https://api.github.com/users/olli-gold/events{/privacy}","received_events_url":"https://api.github.com/users/olli-gold/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2015-04-22T09:15:01Z","updated_at":"2015-04-22T14:33:18Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/vufind-org/vufind/pulls/348","html_url":"https://github.com/vufind-org/vufind/pull/348","diff_url":"https://github.com/vufind-org/vufind/pull/348.diff","patch_url":"https://github.com/vufind-org/vufind/pull/348.patch"},"body":"This is my suggestion to enable conditional filters, which are interacting with the permission system. I guess the method permissionExists($name) should be better in another class, but I did not know, which class would be best for it. \r\n\r\nI have also done some documentation for the new option in searches.ini and have put an example for an appropriate permission set for conditional filters into permissions.ini.\r\n\r\nIt would be great, if you could review and comment, how this feature could be improved.\r\n\r\nOne limitation is, that its only applicable for Solr at the moment. But I think it shouldn't be too difficult to use it also in other contexts."},"comment":{"url":"https://api.github.com/repos/vufind-org/vufind/issues/comments/95208333","html_url":"https://github.com/vufind-org/vufind/pull/348#issuecomment-95208333","issue_url":"https://api.github.com/repos/vufind-org/vufind/issues/348","id":95208333,"user":{"login":"demiankatz","id":309069,"avatar_url":"https://avatars.githubusercontent.com/u/309069?v=3","gravatar_id":"","url":"https://api.github.com/users/demiankatz","html_url":"https://github.com/demiankatz","followers_url":"https://api.github.com/users/demiankatz/followers","following_url":"https://api.github.com/users/demiankatz/following{/other_user}","gists_url":"https://api.github.com/users/demiankatz/gists{/gist_id}","starred_url":"https://api.github.com/users/demiankatz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/demiankatz/subscriptions","organizations_url":"https://api.github.com/users/demiankatz/orgs","repos_url":"https://api.github.com/users/demiankatz/repos","events_url":"https://api.github.com/users/demiankatz/events{/privacy}","received_events_url":"https://api.github.com/users/demiankatz/received_events","type":"User","site_admin":false},"created_at":"2015-04-22T14:33:18Z","updated_at":"2015-04-22T14:33:18Z","body":"Yes, that's probably the most appropriate place to start, though I think your test will be considerably simpler."}}