{"action":"created","issue":{"url":"https://api.github.com/repos/makersacademy/chitter-challenge/issues/64","labels_url":"https://api.github.com/repos/makersacademy/chitter-challenge/issues/64/labels{/name}","comments_url":"https://api.github.com/repos/makersacademy/chitter-challenge/issues/64/comments","events_url":"https://api.github.com/repos/makersacademy/chitter-challenge/issues/64/events","html_url":"https://github.com/makersacademy/chitter-challenge/pull/64","id":80607979,"number":64,"title":"Meeting user stories and tests passing - pre CSS beautification.","user":{"login":"timrobertson0122","id":2273224,"avatar_url":"https://avatars.githubusercontent.com/u/2273224?v=3","gravatar_id":"","url":"https://api.github.com/users/timrobertson0122","html_url":"https://github.com/timrobertson0122","followers_url":"https://api.github.com/users/timrobertson0122/followers","following_url":"https://api.github.com/users/timrobertson0122/following{/other_user}","gists_url":"https://api.github.com/users/timrobertson0122/gists{/gist_id}","starred_url":"https://api.github.com/users/timrobertson0122/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timrobertson0122/subscriptions","organizations_url":"https://api.github.com/users/timrobertson0122/orgs","repos_url":"https://api.github.com/users/timrobertson0122/repos","events_url":"https://api.github.com/users/timrobertson0122/events{/privacy}","received_events_url":"https://api.github.com/users/timrobertson0122/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-05-25T17:30:49Z","updated_at":"2015-05-28T09:00:53Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/makersacademy/chitter-challenge/pulls/64","html_url":"https://github.com/makersacademy/chitter-challenge/pull/64","diff_url":"https://github.com/makersacademy/chitter-challenge/pull/64.diff","patch_url":"https://github.com/makersacademy/chitter-challenge/pull/64.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/makersacademy/chitter-challenge/issues/comments/106238925","html_url":"https://github.com/makersacademy/chitter-challenge/pull/64#issuecomment-106238925","issue_url":"https://api.github.com/repos/makersacademy/chitter-challenge/issues/64","id":106238925,"user":{"login":"ptolemybarnes","id":9342866,"avatar_url":"https://avatars.githubusercontent.com/u/9342866?v=3","gravatar_id":"","url":"https://api.github.com/users/ptolemybarnes","html_url":"https://github.com/ptolemybarnes","followers_url":"https://api.github.com/users/ptolemybarnes/followers","following_url":"https://api.github.com/users/ptolemybarnes/following{/other_user}","gists_url":"https://api.github.com/users/ptolemybarnes/gists{/gist_id}","starred_url":"https://api.github.com/users/ptolemybarnes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ptolemybarnes/subscriptions","organizations_url":"https://api.github.com/users/ptolemybarnes/orgs","repos_url":"https://api.github.com/users/ptolemybarnes/repos","events_url":"https://api.github.com/users/ptolemybarnes/events{/privacy}","received_events_url":"https://api.github.com/users/ptolemybarnes/received_events","type":"User","site_admin":false},"created_at":"2015-05-28T09:00:53Z","updated_at":"2015-05-28T09:00:53Z","body":"Well done with modularizing your sinatra app! This is a great challenge submission.\r\nBe careful about a few things:\r\n - Indentation. You want to minimize the mental friction for yourself and whoever else is reading your code. Good indentation can really help with this, making your code easier to debug.\r\n - Think about refactoring complicated logic out to helper methods. \"(1..64).map { ('A'..'Z').to_a.sample }.join\", for example, could be moved out to a method called \"generate_password_token\".\r\n - Your unit test of Peep is basically just testing DataMapper functionality, which you needn't test."}}