{"action":"created","issue":{"url":"https://api.github.com/repos/dankelley/oce/issues/713","labels_url":"https://api.github.com/repos/dankelley/oce/issues/713/labels{/name}","comments_url":"https://api.github.com/repos/dankelley/oce/issues/713/comments","events_url":"https://api.github.com/repos/dankelley/oce/issues/713/events","html_url":"https://github.com/dankelley/oce/issues/713","id":100542215,"number":713,"title":"Need new rsk data set","user":{"login":"richardsc","id":233584,"avatar_url":"https://avatars.githubusercontent.com/u/233584?v=3","gravatar_id":"","url":"https://api.github.com/users/richardsc","html_url":"https://github.com/richardsc","followers_url":"https://api.github.com/users/richardsc/followers","following_url":"https://api.github.com/users/richardsc/following{/other_user}","gists_url":"https://api.github.com/users/richardsc/gists{/gist_id}","starred_url":"https://api.github.com/users/richardsc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardsc/subscriptions","organizations_url":"https://api.github.com/users/richardsc/orgs","repos_url":"https://api.github.com/users/richardsc/repos","events_url":"https://api.github.com/users/richardsc/events{/privacy}","received_events_url":"https://api.github.com/users/richardsc/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/dankelley/oce/labels/rsk","name":"rsk","color":"bfe5bf"}],"state":"open","locked":false,"assignee":{"login":"richardsc","id":233584,"avatar_url":"https://avatars.githubusercontent.com/u/233584?v=3","gravatar_id":"","url":"https://api.github.com/users/richardsc","html_url":"https://github.com/richardsc","followers_url":"https://api.github.com/users/richardsc/followers","following_url":"https://api.github.com/users/richardsc/following{/other_user}","gists_url":"https://api.github.com/users/richardsc/gists{/gist_id}","starred_url":"https://api.github.com/users/richardsc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardsc/subscriptions","organizations_url":"https://api.github.com/users/richardsc/orgs","repos_url":"https://api.github.com/users/richardsc/repos","events_url":"https://api.github.com/users/richardsc/events{/privacy}","received_events_url":"https://api.github.com/users/richardsc/received_events","type":"User","site_admin":false},"milestone":null,"comments":3,"created_at":"2015-08-12T13:24:08Z","updated_at":"2015-11-30T11:56:42Z","closed_at":null,"body":"With recent changes to all the `rsk-class` functionality, it is time to replace the sample `rsk` dataset with something more modern. Ideally this should be an actual `.rsk` file, so that the full suite of SQLite interactions can be used and tested at build. The issue currently is that most `.rsk` files are too large to be included as a standard dataset and must be compressed (and trimmed of \"unnecessary\" tables). This may soon be able to be solved by improvements on the Ruskin side, which will allow export of a specific region of an rsk to a new rsk. If such improvements happen it would be easy to get a smaller rsk file.\r\n\r\nI would also propose that we could include a second example dataset, which is an ASCII text export of the same `.rsk` file. That way, tests can be incorporated into the package build to compare the reading of the two raw files to make sure that changes to the code for one or the other don't break things.\r\n\r\nThoughts @dankelley?"},"comment":{"url":"https://api.github.com/repos/dankelley/oce/issues/comments/160609729","html_url":"https://github.com/dankelley/oce/issues/713#issuecomment-160609729","issue_url":"https://api.github.com/repos/dankelley/oce/issues/713","id":160609729,"user":{"login":"dankelley","id":99469,"avatar_url":"https://avatars.githubusercontent.com/u/99469?v=3","gravatar_id":"","url":"https://api.github.com/users/dankelley","html_url":"https://github.com/dankelley","followers_url":"https://api.github.com/users/dankelley/followers","following_url":"https://api.github.com/users/dankelley/following{/other_user}","gists_url":"https://api.github.com/users/dankelley/gists{/gist_id}","starred_url":"https://api.github.com/users/dankelley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dankelley/subscriptions","organizations_url":"https://api.github.com/users/dankelley/orgs","repos_url":"https://api.github.com/users/dankelley/repos","events_url":"https://api.github.com/users/dankelley/events{/privacy}","received_events_url":"https://api.github.com/users/dankelley/received_events","type":"User","site_admin":false},"created_at":"2015-11-30T11:56:42Z","updated_at":"2015-11-30T11:56:42Z","body":"A question is whether we are talking about including a ``.rsk`` file (in ``inst/extdata``) or an object created from one. If the latter, and if oce is up to it, we could use ``subset`` to get a smaller ``.rda`` file. If the former, I think we need to drop the idea unless RBR has well-tested software to subset from a dataset.  I fear that if we manually tweak the ``.rsk`` file, we may get something wrong, and that won't serve much purpose (put another way, it could mess things up).\r\n\r\nFor half a day, a week ago, I had a ``data/odf.rda`` object in there. Then I realized there was really not much point since it's just a data format, not really a data type.  I wonder if the same may be true of Ruskin format.  Put another way, if the only use to which these datasets would be put would be e.g.\r\n```r\r\ndata(rsk)\r\nplot(rsk)\r\nnew <- subset(rsk, pressure<100)\r\n```\r\nor similar, then I don't see any huge advantage to having the data built in like that. Users who do not have ``.rsk`` data will gain nothing. And those with ``.rsk`` data will be doing the nearly-equivalent\r\n```r\r\nrsk <- read.oce(\"myDataFile.rsk\")\r\nplot(rsk)\r\nnew <- subset(rsk, pressure<100)\r\n```\r\nAlso, if RBR has a stable URL on a sample file, then that could be used directly too.  (**Question:** does RBR have such a URL?)\r\n\r\nIn other words, I'm coming around to saying we simply give up on including an ``rsk`` dataset. We already have a class (``odf``) that has no built-in dataset.  Maybe we should restrict these built-in datasets to things that are the most useful for learning (I would argue ``ctd`` falls into that category, and also ``sealevel`` and ``section``) or for work (here we have ``coastlineWorld`` and similar).\r\n\r\nPS. as regards your last line, I think you mean including an ``rsk`` in ``inst/extdata`` but I'd suggest we do not do that. I am thinking of removing the ``odf`` file that's there, for example, because the only people who would ever want to use ``odf`` functions are people who have odf datasets."}}