{"action":"closed","number":7880,"pull_request":{"url":"https://api.github.com/repos/cakephp/cakephp/pulls/7880","id":54194992,"html_url":"https://github.com/cakephp/cakephp/pull/7880","diff_url":"https://github.com/cakephp/cakephp/pull/7880.diff","patch_url":"https://github.com/cakephp/cakephp/pull/7880.patch","issue_url":"https://api.github.com/repos/cakephp/cakephp/issues/7880","number":7880,"state":"closed","locked":false,"title":"[3.1] Add IntegrationTestCase::cookieEncrypted().","user":{"login":"waterada","id":1920020,"avatar_url":"https://avatars.githubusercontent.com/u/1920020?v=3","gravatar_id":"","url":"https://api.github.com/users/waterada","html_url":"https://github.com/waterada","followers_url":"https://api.github.com/users/waterada/followers","following_url":"https://api.github.com/users/waterada/following{/other_user}","gists_url":"https://api.github.com/users/waterada/gists{/gist_id}","starred_url":"https://api.github.com/users/waterada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/waterada/subscriptions","organizations_url":"https://api.github.com/users/waterada/orgs","repos_url":"https://api.github.com/users/waterada/repos","events_url":"https://api.github.com/users/waterada/events{/privacy}","received_events_url":"https://api.github.com/users/waterada/received_events","type":"User","site_admin":false},"body":"Add `IntegrationTestCase::cookieEncrypted()` to encrypt with the CookieComponent.\r\nSee: issue #7862 \r\nSee also: the previous pull request #7873 (will be closed soon)\r\n\r\n- This is the re-pull-request which is based on master on [@lorenzo's advice](https://github.com/cakephp/cakephp/pull/7873#issuecomment-165981425).\r\n- Extracting the crypt logic from `CookieComponent` to the trait on [@markstory's advice](https://github.com/cakephp/cakephp/pull/7873#discussion_r48092730).\r\n- Add the new method `cookieEncrypted()` separately from `cookie()`  on [@markstory's advice](https://github.com/cakephp/cakephp/pull/7873#discussion_r48094276).\r\n-  Add the test to make sure a controller action can decode the cookie on [@markstory's advice](https://github.com/cakephp/cakephp/pull/7873#discussion_r48092742).\r\n- Add the forth argument to specify the encryption key to `cookieEncrypted()` on [@jeremyharris' advice](https://github.com/cakephp/cakephp/pull/7873#issuecomment-165992475).\r\n","created_at":"2015-12-20T08:04:44Z","updated_at":"2015-12-23T16:16:22Z","closed_at":"2015-12-23T16:16:22Z","merged_at":"2015-12-23T16:16:22Z","merge_commit_sha":"3b564449ce5223c47988fc2bf4a46ab1ecc72c1f","assignee":null,"milestone":{"url":"https://api.github.com/repos/cakephp/cakephp/milestones/71","html_url":"https://github.com/cakephp/cakephp/milestones/3.1.7","labels_url":"https://api.github.com/repos/cakephp/cakephp/milestones/71/labels","id":1472762,"number":71,"title":"3.1.7","description":"Bugfixes and minor features for CakePHP 3.1.x","creator":{"login":"markstory","id":24086,"avatar_url":"https://avatars.githubusercontent.com/u/24086?v=3","gravatar_id":"","url":"https://api.github.com/users/markstory","html_url":"https://github.com/markstory","followers_url":"https://api.github.com/users/markstory/followers","following_url":"https://api.github.com/users/markstory/following{/other_user}","gists_url":"https://api.github.com/users/markstory/gists{/gist_id}","starred_url":"https://api.github.com/users/markstory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markstory/subscriptions","organizations_url":"https://api.github.com/users/markstory/orgs","repos_url":"https://api.github.com/users/markstory/repos","events_url":"https://api.github.com/users/markstory/events{/privacy}","received_events_url":"https://api.github.com/users/markstory/received_events","type":"User","site_admin":false},"open_issues":26,"closed_issues":2,"state":"open","created_at":"2015-12-23T16:13:37Z","updated_at":"2015-12-23T16:16:22Z","due_on":"2016-01-17T05:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/cakephp/cakephp/pulls/7880/commits","review_comments_url":"https://api.github.com/repos/cakephp/cakephp/pulls/7880/comments","review_comment_url":"https://api.github.com/repos/cakephp/cakephp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cakephp/cakephp/issues/7880/comments","statuses_url":"https://api.github.com/repos/cakephp/cakephp/statuses/7fcc47183f4909475b0ed1576513d9b9a762aa4d","head":{"label":"waterada:ticket-7862-based-on-master","ref":"ticket-7862-based-on-master","sha":"7fcc47183f4909475b0ed1576513d9b9a762aa4d","user":{"login":"waterada","id":1920020,"avatar_url":"https://avatars.githubusercontent.com/u/1920020?v=3","gravatar_id":"","url":"https://api.github.com/users/waterada","html_url":"https://github.com/waterada","followers_url":"https://api.github.com/users/waterada/followers","following_url":"https://api.github.com/users/waterada/following{/other_user}","gists_url":"https://api.github.com/users/waterada/gists{/gist_id}","starred_url":"https://api.github.com/users/waterada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/waterada/subscriptions","organizations_url":"https://api.github.com/users/waterada/orgs","repos_url":"https://api.github.com/users/waterada/repos","events_url":"https://api.github.com/users/waterada/events{/privacy}","received_events_url":"https://api.github.com/users/waterada/received_events","type":"User","site_admin":false},"repo":{"id":48016524,"name":"cakephp","full_name":"waterada/cakephp","owner":{"login":"waterada","id":1920020,"avatar_url":"https://avatars.githubusercontent.com/u/1920020?v=3","gravatar_id":"","url":"https://api.github.com/users/waterada","html_url":"https://github.com/waterada","followers_url":"https://api.github.com/users/waterada/followers","following_url":"https://api.github.com/users/waterada/following{/other_user}","gists_url":"https://api.github.com/users/waterada/gists{/gist_id}","starred_url":"https://api.github.com/users/waterada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/waterada/subscriptions","organizations_url":"https://api.github.com/users/waterada/orgs","repos_url":"https://api.github.com/users/waterada/repos","events_url":"https://api.github.com/users/waterada/events{/privacy}","received_events_url":"https://api.github.com/users/waterada/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/waterada/cakephp","description":"CakePHP: The Rapid Development Framework for PHP - Official Repository","fork":true,"url":"https://api.github.com/repos/waterada/cakephp","forks_url":"https://api.github.com/repos/waterada/cakephp/forks","keys_url":"https://api.github.com/repos/waterada/cakephp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/waterada/cakephp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/waterada/cakephp/teams","hooks_url":"https://api.github.com/repos/waterada/cakephp/hooks","issue_events_url":"https://api.github.com/repos/waterada/cakephp/issues/events{/number}","events_url":"https://api.github.com/repos/waterada/cakephp/events","assignees_url":"https://api.github.com/repos/waterada/cakephp/assignees{/user}","branches_url":"https://api.github.com/repos/waterada/cakephp/branches{/branch}","tags_url":"https://api.github.com/repos/waterada/cakephp/tags","blobs_url":"https://api.github.com/repos/waterada/cakephp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/waterada/cakephp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/waterada/cakephp/git/refs{/sha}","trees_url":"https://api.github.com/repos/waterada/cakephp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/waterada/cakephp/statuses/{sha}","languages_url":"https://api.github.com/repos/waterada/cakephp/languages","stargazers_url":"https://api.github.com/repos/waterada/cakephp/stargazers","contributors_url":"https://api.github.com/repos/waterada/cakephp/contributors","subscribers_url":"https://api.github.com/repos/waterada/cakephp/subscribers","subscription_url":"https://api.github.com/repos/waterada/cakephp/subscription","commits_url":"https://api.github.com/repos/waterada/cakephp/commits{/sha}","git_commits_url":"https://api.github.com/repos/waterada/cakephp/git/commits{/sha}","comments_url":"https://api.github.com/repos/waterada/cakephp/comments{/number}","issue_comment_url":"https://api.github.com/repos/waterada/cakephp/issues/comments{/number}","contents_url":"https://api.github.com/repos/waterada/cakephp/contents/{+path}","compare_url":"https://api.github.com/repos/waterada/cakephp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/waterada/cakephp/merges","archive_url":"https://api.github.com/repos/waterada/cakephp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/waterada/cakephp/downloads","issues_url":"https://api.github.com/repos/waterada/cakephp/issues{/number}","pulls_url":"https://api.github.com/repos/waterada/cakephp/pulls{/number}","milestones_url":"https://api.github.com/repos/waterada/cakephp/milestones{/number}","notifications_url":"https://api.github.com/repos/waterada/cakephp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/waterada/cakephp/labels{/name}","releases_url":"https://api.github.com/repos/waterada/cakephp/releases{/id}","created_at":"2015-12-15T03:11:39Z","updated_at":"2015-12-15T03:11:45Z","pushed_at":"2015-12-22T01:37:27Z","git_url":"git://github.com/waterada/cakephp.git","ssh_url":"git@github.com:waterada/cakephp.git","clone_url":"https://github.com/waterada/cakephp.git","svn_url":"https://github.com/waterada/cakephp","homepage":"http://cakephp.org","size":79159,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cakephp:master","ref":"master","sha":"912b14261ddb8455fdf5f2bf73fcf08d736fd362","user":{"login":"cakephp","id":23666,"avatar_url":"https://avatars.githubusercontent.com/u/23666?v=3","gravatar_id":"","url":"https://api.github.com/users/cakephp","html_url":"https://github.com/cakephp","followers_url":"https://api.github.com/users/cakephp/followers","following_url":"https://api.github.com/users/cakephp/following{/other_user}","gists_url":"https://api.github.com/users/cakephp/gists{/gist_id}","starred_url":"https://api.github.com/users/cakephp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cakephp/subscriptions","organizations_url":"https://api.github.com/users/cakephp/orgs","repos_url":"https://api.github.com/users/cakephp/repos","events_url":"https://api.github.com/users/cakephp/events{/privacy}","received_events_url":"https://api.github.com/users/cakephp/received_events","type":"Organization","site_admin":false},"repo":{"id":656494,"name":"cakephp","full_name":"cakephp/cakephp","owner":{"login":"cakephp","id":23666,"avatar_url":"https://avatars.githubusercontent.com/u/23666?v=3","gravatar_id":"","url":"https://api.github.com/users/cakephp","html_url":"https://github.com/cakephp","followers_url":"https://api.github.com/users/cakephp/followers","following_url":"https://api.github.com/users/cakephp/following{/other_user}","gists_url":"https://api.github.com/users/cakephp/gists{/gist_id}","starred_url":"https://api.github.com/users/cakephp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cakephp/subscriptions","organizations_url":"https://api.github.com/users/cakephp/orgs","repos_url":"https://api.github.com/users/cakephp/repos","events_url":"https://api.github.com/users/cakephp/events{/privacy}","received_events_url":"https://api.github.com/users/cakephp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cakephp/cakephp","description":"CakePHP: The Rapid Development Framework for PHP - Official Repository","fork":false,"url":"https://api.github.com/repos/cakephp/cakephp","forks_url":"https://api.github.com/repos/cakephp/cakephp/forks","keys_url":"https://api.github.com/repos/cakephp/cakephp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cakephp/cakephp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cakephp/cakephp/teams","hooks_url":"https://api.github.com/repos/cakephp/cakephp/hooks","issue_events_url":"https://api.github.com/repos/cakephp/cakephp/issues/events{/number}","events_url":"https://api.github.com/repos/cakephp/cakephp/events","assignees_url":"https://api.github.com/repos/cakephp/cakephp/assignees{/user}","branches_url":"https://api.github.com/repos/cakephp/cakephp/branches{/branch}","tags_url":"https://api.github.com/repos/cakephp/cakephp/tags","blobs_url":"https://api.github.com/repos/cakephp/cakephp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cakephp/cakephp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cakephp/cakephp/git/refs{/sha}","trees_url":"https://api.github.com/repos/cakephp/cakephp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cakephp/cakephp/statuses/{sha}","languages_url":"https://api.github.com/repos/cakephp/cakephp/languages","stargazers_url":"https://api.github.com/repos/cakephp/cakephp/stargazers","contributors_url":"https://api.github.com/repos/cakephp/cakephp/contributors","subscribers_url":"https://api.github.com/repos/cakephp/cakephp/subscribers","subscription_url":"https://api.github.com/repos/cakephp/cakephp/subscription","commits_url":"https://api.github.com/repos/cakephp/cakephp/commits{/sha}","git_commits_url":"https://api.github.com/repos/cakephp/cakephp/git/commits{/sha}","comments_url":"https://api.github.com/repos/cakephp/cakephp/comments{/number}","issue_comment_url":"https://api.github.com/repos/cakephp/cakephp/issues/comments{/number}","contents_url":"https://api.github.com/repos/cakephp/cakephp/contents/{+path}","compare_url":"https://api.github.com/repos/cakephp/cakephp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cakephp/cakephp/merges","archive_url":"https://api.github.com/repos/cakephp/cakephp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cakephp/cakephp/downloads","issues_url":"https://api.github.com/repos/cakephp/cakephp/issues{/number}","pulls_url":"https://api.github.com/repos/cakephp/cakephp/pulls{/number}","milestones_url":"https://api.github.com/repos/cakephp/cakephp/milestones{/number}","notifications_url":"https://api.github.com/repos/cakephp/cakephp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cakephp/cakephp/labels{/name}","releases_url":"https://api.github.com/repos/cakephp/cakephp/releases{/id}","created_at":"2010-05-08T14:38:22Z","updated_at":"2015-12-23T15:25:24Z","pushed_at":"2015-12-23T16:16:22Z","git_url":"git://github.com/cakephp/cakephp.git","ssh_url":"git@github.com:cakephp/cakephp.git","clone_url":"https://github.com/cakephp/cakephp.git","svn_url":"https://github.com/cakephp/cakephp","homepage":"http://cakephp.org","size":112108,"stargazers_count":6202,"watchers_count":6202,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2842,"mirror_url":null,"open_issues_count":165,"forks":2842,"open_issues":165,"watchers":6202,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cakephp/cakephp/pulls/7880"},"html":{"href":"https://github.com/cakephp/cakephp/pull/7880"},"issue":{"href":"https://api.github.com/repos/cakephp/cakephp/issues/7880"},"comments":{"href":"https://api.github.com/repos/cakephp/cakephp/issues/7880/comments"},"review_comments":{"href":"https://api.github.com/repos/cakephp/cakephp/pulls/7880/comments"},"review_comment":{"href":"https://api.github.com/repos/cakephp/cakephp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cakephp/cakephp/pulls/7880/commits"},"statuses":{"href":"https://api.github.com/repos/cakephp/cakephp/statuses/7fcc47183f4909475b0ed1576513d9b9a762aa4d"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"markstory","id":24086,"avatar_url":"https://avatars.githubusercontent.com/u/24086?v=3","gravatar_id":"","url":"https://api.github.com/users/markstory","html_url":"https://github.com/markstory","followers_url":"https://api.github.com/users/markstory/followers","following_url":"https://api.github.com/users/markstory/following{/other_user}","gists_url":"https://api.github.com/users/markstory/gists{/gist_id}","starred_url":"https://api.github.com/users/markstory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markstory/subscriptions","organizations_url":"https://api.github.com/users/markstory/orgs","repos_url":"https://api.github.com/users/markstory/repos","events_url":"https://api.github.com/users/markstory/events{/privacy}","received_events_url":"https://api.github.com/users/markstory/received_events","type":"User","site_admin":false},"comments":3,"review_comments":13,"commits":13,"additions":390,"deletions":127,"changed_files":6}}