{"action":"opened","number":1099,"pull_request":{"url":"https://api.github.com/repos/facebook/react-native/pulls/1099","id":34562468,"html_url":"https://github.com/facebook/react-native/pull/1099","diff_url":"https://github.com/facebook/react-native/pull/1099.diff","patch_url":"https://github.com/facebook/react-native/pull/1099.patch","issue_url":"https://api.github.com/repos/facebook/react-native/issues/1099","number":1099,"state":"open","locked":false,"title":"Install flow-bin and use that for packager Flow check","user":{"login":"gabelevi","id":1887264,"avatar_url":"https://avatars.githubusercontent.com/u/1887264?v=3","gravatar_id":"","url":"https://api.github.com/users/gabelevi","html_url":"https://github.com/gabelevi","followers_url":"https://api.github.com/users/gabelevi/followers","following_url":"https://api.github.com/users/gabelevi/following{/other_user}","gists_url":"https://api.github.com/users/gabelevi/gists{/gist_id}","starred_url":"https://api.github.com/users/gabelevi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabelevi/subscriptions","organizations_url":"https://api.github.com/users/gabelevi/orgs","repos_url":"https://api.github.com/users/gabelevi/repos","events_url":"https://api.github.com/users/gabelevi/events{/privacy}","received_events_url":"https://api.github.com/users/gabelevi/received_events","type":"User","site_admin":false},"body":"Flow is versioned with semver, and almost every deploy includes a breaking change. We can address this by installing the [`flow-bin`](https://github.com/sindresorhus/flow-bin) package...a very simple npm package that downloads the correct binary based on the operating system and the version. Then the packager can use the correct version of Flow, even if a more recent version of Flow is available.\r\n\r\nThis is a sister PR to https://github.com/facebook/react-native/pull/1097 which also sticks the version number in the `.flowconfig`, so that users will get a clear error if they try to do Flow checks with the wrong version of Flow.\r\n\r\nThis means when we update react-native to work with a new version of Flow, we need to update the version number in `react-native-cli/index.js` and in `Examples/SampleApp/_flowconfig`. When a user wants to update the version of Flow they're using locally, they will just need to edit their `.flowconfig` and their `package.json`. We should document this somewhere.\r\n\r\nFuture work includes maybe transitioning people from installing flow with homebrew to globally installing some wrapper script, which can intelligently find which flow binary to use (like looking for a flow-bin package, for example).","created_at":"2015-05-01T19:54:48Z","updated_at":"2015-05-01T19:54:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/facebook/react-native/pulls/1099/commits","review_comments_url":"https://api.github.com/repos/facebook/react-native/pulls/1099/comments","review_comment_url":"https://api.github.com/repos/facebook/react-native/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/react-native/issues/1099/comments","statuses_url":"https://api.github.com/repos/facebook/react-native/statuses/ea70018f0224819b63ad670838c495076f9a6c66","head":{"label":"gabelevi:packager","ref":"packager","sha":"ea70018f0224819b63ad670838c495076f9a6c66","user":{"login":"gabelevi","id":1887264,"avatar_url":"https://avatars.githubusercontent.com/u/1887264?v=3","gravatar_id":"","url":"https://api.github.com/users/gabelevi","html_url":"https://github.com/gabelevi","followers_url":"https://api.github.com/users/gabelevi/followers","following_url":"https://api.github.com/users/gabelevi/following{/other_user}","gists_url":"https://api.github.com/users/gabelevi/gists{/gist_id}","starred_url":"https://api.github.com/users/gabelevi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabelevi/subscriptions","organizations_url":"https://api.github.com/users/gabelevi/orgs","repos_url":"https://api.github.com/users/gabelevi/repos","events_url":"https://api.github.com/users/gabelevi/events{/privacy}","received_events_url":"https://api.github.com/users/gabelevi/received_events","type":"User","site_admin":false},"repo":{"id":34634166,"name":"react-native","full_name":"gabelevi/react-native","owner":{"login":"gabelevi","id":1887264,"avatar_url":"https://avatars.githubusercontent.com/u/1887264?v=3","gravatar_id":"","url":"https://api.github.com/users/gabelevi","html_url":"https://github.com/gabelevi","followers_url":"https://api.github.com/users/gabelevi/followers","following_url":"https://api.github.com/users/gabelevi/following{/other_user}","gists_url":"https://api.github.com/users/gabelevi/gists{/gist_id}","starred_url":"https://api.github.com/users/gabelevi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabelevi/subscriptions","organizations_url":"https://api.github.com/users/gabelevi/orgs","repos_url":"https://api.github.com/users/gabelevi/repos","events_url":"https://api.github.com/users/gabelevi/events{/privacy}","received_events_url":"https://api.github.com/users/gabelevi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gabelevi/react-native","description":"A framework for building native apps with React.","fork":true,"url":"https://api.github.com/repos/gabelevi/react-native","forks_url":"https://api.github.com/repos/gabelevi/react-native/forks","keys_url":"https://api.github.com/repos/gabelevi/react-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gabelevi/react-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gabelevi/react-native/teams","hooks_url":"https://api.github.com/repos/gabelevi/react-native/hooks","issue_events_url":"https://api.github.com/repos/gabelevi/react-native/issues/events{/number}","events_url":"https://api.github.com/repos/gabelevi/react-native/events","assignees_url":"https://api.github.com/repos/gabelevi/react-native/assignees{/user}","branches_url":"https://api.github.com/repos/gabelevi/react-native/branches{/branch}","tags_url":"https://api.github.com/repos/gabelevi/react-native/tags","blobs_url":"https://api.github.com/repos/gabelevi/react-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gabelevi/react-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gabelevi/react-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/gabelevi/react-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gabelevi/react-native/statuses/{sha}","languages_url":"https://api.github.com/repos/gabelevi/react-native/languages","stargazers_url":"https://api.github.com/repos/gabelevi/react-native/stargazers","contributors_url":"https://api.github.com/repos/gabelevi/react-native/contributors","subscribers_url":"https://api.github.com/repos/gabelevi/react-native/subscribers","subscription_url":"https://api.github.com/repos/gabelevi/react-native/subscription","commits_url":"https://api.github.com/repos/gabelevi/react-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/gabelevi/react-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/gabelevi/react-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/gabelevi/react-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/gabelevi/react-native/contents/{+path}","compare_url":"https://api.github.com/repos/gabelevi/react-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gabelevi/react-native/merges","archive_url":"https://api.github.com/repos/gabelevi/react-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gabelevi/react-native/downloads","issues_url":"https://api.github.com/repos/gabelevi/react-native/issues{/number}","pulls_url":"https://api.github.com/repos/gabelevi/react-native/pulls{/number}","milestones_url":"https://api.github.com/repos/gabelevi/react-native/milestones{/number}","notifications_url":"https://api.github.com/repos/gabelevi/react-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gabelevi/react-native/labels{/name}","releases_url":"https://api.github.com/repos/gabelevi/react-native/releases{/id}","created_at":"2015-04-26T22:23:07Z","updated_at":"2015-04-26T22:23:08Z","pushed_at":"2015-05-01T19:47:29Z","git_url":"git://github.com/gabelevi/react-native.git","ssh_url":"git@github.com:gabelevi/react-native.git","clone_url":"https://github.com/gabelevi/react-native.git","svn_url":"https://github.com/gabelevi/react-native","homepage":"http://facebook.github.io/react-native/","size":11234,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"f8a4467b7df02940fd172c797f5686a83b27b49c","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":29028775,"name":"react-native","full_name":"facebook/react-native","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/react-native","description":"A framework for building native apps with React.","fork":false,"url":"https://api.github.com/repos/facebook/react-native","forks_url":"https://api.github.com/repos/facebook/react-native/forks","keys_url":"https://api.github.com/repos/facebook/react-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/react-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/react-native/teams","hooks_url":"https://api.github.com/repos/facebook/react-native/hooks","issue_events_url":"https://api.github.com/repos/facebook/react-native/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/react-native/events","assignees_url":"https://api.github.com/repos/facebook/react-native/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/react-native/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/react-native/tags","blobs_url":"https://api.github.com/repos/facebook/react-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/react-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/react-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/react-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/react-native/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/react-native/languages","stargazers_url":"https://api.github.com/repos/facebook/react-native/stargazers","contributors_url":"https://api.github.com/repos/facebook/react-native/contributors","subscribers_url":"https://api.github.com/repos/facebook/react-native/subscribers","subscription_url":"https://api.github.com/repos/facebook/react-native/subscription","commits_url":"https://api.github.com/repos/facebook/react-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/react-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/react-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/react-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/react-native/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/react-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/react-native/merges","archive_url":"https://api.github.com/repos/facebook/react-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/react-native/downloads","issues_url":"https://api.github.com/repos/facebook/react-native/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/react-native/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/react-native/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/react-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/react-native/labels{/name}","releases_url":"https://api.github.com/repos/facebook/react-native/releases{/id}","created_at":"2015-01-09T18:10:16Z","updated_at":"2015-05-01T19:46:14Z","pushed_at":"2015-05-01T18:28:59Z","git_url":"git://github.com/facebook/react-native.git","ssh_url":"git@github.com:facebook/react-native.git","clone_url":"https://github.com/facebook/react-native.git","svn_url":"https://github.com/facebook/react-native","homepage":"http://facebook.github.io/react-native/","size":29558,"stargazers_count":13409,"watchers_count":13409,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1429,"mirror_url":null,"open_issues_count":376,"forks":1429,"open_issues":376,"watchers":13409,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/react-native/pulls/1099"},"html":{"href":"https://github.com/facebook/react-native/pull/1099"},"issue":{"href":"https://api.github.com/repos/facebook/react-native/issues/1099"},"comments":{"href":"https://api.github.com/repos/facebook/react-native/issues/1099/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/react-native/pulls/1099/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/react-native/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/react-native/pulls/1099/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/react-native/statuses/ea70018f0224819b63ad670838c495076f9a6c66"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":29,"deletions":10,"changed_files":4}}