{"action":"created","comment":{"url":"https://api.github.com/repos/apache/nifi/pulls/comments/44874262","id":44874262,"diff_hunk":"@@ -47,9 +46,6 @@\n public class DocsReader {\n     private final Logger logger = LoggerFactory.getLogger(DocsReader.class);\n \n-    public DocsReader(final List<File> storageDirectories) {\n-    }\n-","path":"nifi-nar-bundles/nifi-provenance-repository-bundle/nifi-persistent-provenance-repository/src/main/java/org/apache/nifi/provenance/lucene/DocsReader.java","position":23,"original_position":23,"commit_id":"a4d93c62c88f594ef0cd3739a0536769f1ab9b26","original_commit_id":"a4d93c62c88f594ef0cd3739a0536769f1ab9b26","user":{"login":"apiri","id":502889,"avatar_url":"https://avatars.githubusercontent.com/u/502889?v=3","gravatar_id":"","url":"https://api.github.com/users/apiri","html_url":"https://github.com/apiri","followers_url":"https://api.github.com/users/apiri/followers","following_url":"https://api.github.com/users/apiri/following{/other_user}","gists_url":"https://api.github.com/users/apiri/gists{/gist_id}","starred_url":"https://api.github.com/users/apiri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apiri/subscriptions","organizations_url":"https://api.github.com/users/apiri/orgs","repos_url":"https://api.github.com/users/apiri/repos","events_url":"https://api.github.com/users/apiri/events{/privacy}","received_events_url":"https://api.github.com/users/apiri/received_events","type":"User","site_admin":false},"body":"I think there has been a \"handshake agreement\" on the nature of the framework code versus the extension developer facing API.  Having said that, I was not able to find any documentation that indicates that is the case.  As a result, I think I am a similar 95/5 split as Tony.  As a result, I think the \"right\" thing given the circumstances is to tag it up as Deprecated and remove at 1.x.  However, I think it's likely a fair assumption that this is clear.  Either way, we need to get the handshake agreement in a tangible form some place.  I'll make a ticket and please add on/enhance as needed.","created_at":"2015-11-15T16:56:29Z","updated_at":"2015-11-15T16:56:29Z","html_url":"https://github.com/apache/nifi/pull/123#discussion_r44874262","pull_request_url":"https://api.github.com/repos/apache/nifi/pulls/123","_links":{"self":{"href":"https://api.github.com/repos/apache/nifi/pulls/comments/44874262"},"html":{"href":"https://github.com/apache/nifi/pull/123#discussion_r44874262"},"pull_request":{"href":"https://api.github.com/repos/apache/nifi/pulls/123"}}},"pull_request":{"url":"https://api.github.com/repos/apache/nifi/pulls/123","id":50680597,"html_url":"https://github.com/apache/nifi/pull/123","diff_url":"https://github.com/apache/nifi/pull/123.diff","patch_url":"https://github.com/apache/nifi/pull/123.patch","issue_url":"https://api.github.com/repos/apache/nifi/issues/123","number":123,"state":"open","locked":false,"title":"NIFI-748 Fixed logic around handling partial query results from prove…","user":{"login":"olegz","id":172397,"avatar_url":"https://avatars.githubusercontent.com/u/172397?v=3","gravatar_id":"","url":"https://api.github.com/users/olegz","html_url":"https://github.com/olegz","followers_url":"https://api.github.com/users/olegz/followers","following_url":"https://api.github.com/users/olegz/following{/other_user}","gists_url":"https://api.github.com/users/olegz/gists{/gist_id}","starred_url":"https://api.github.com/users/olegz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olegz/subscriptions","organizations_url":"https://api.github.com/users/olegz/orgs","repos_url":"https://api.github.com/users/olegz/repos","events_url":"https://api.github.com/users/olegz/events{/privacy}","received_events_url":"https://api.github.com/users/olegz/received_events","type":"User","site_admin":false},"body":"…nance repository\r\n\r\n- Ensured that failures derived form correlating Document to its actual provenance event do fail the entire query and produce partial results with warning messages\r\n- Refactored DocsReader.read() operation.\r\n- Added test to validate two conditions where the such failures could occur","created_at":"2015-11-13T19:24:21Z","updated_at":"2015-11-15T16:56:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b82c572eb1750a1c65f5e0c01f33fa8391ec5042","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/nifi/pulls/123/commits","review_comments_url":"https://api.github.com/repos/apache/nifi/pulls/123/comments","review_comment_url":"https://api.github.com/repos/apache/nifi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/nifi/issues/123/comments","statuses_url":"https://api.github.com/repos/apache/nifi/statuses/a4d93c62c88f594ef0cd3739a0536769f1ab9b26","head":{"label":"olegz:NIFI-748","ref":"NIFI-748","sha":"a4d93c62c88f594ef0cd3739a0536769f1ab9b26","user":{"login":"olegz","id":172397,"avatar_url":"https://avatars.githubusercontent.com/u/172397?v=3","gravatar_id":"","url":"https://api.github.com/users/olegz","html_url":"https://github.com/olegz","followers_url":"https://api.github.com/users/olegz/followers","following_url":"https://api.github.com/users/olegz/following{/other_user}","gists_url":"https://api.github.com/users/olegz/gists{/gist_id}","starred_url":"https://api.github.com/users/olegz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olegz/subscriptions","organizations_url":"https://api.github.com/users/olegz/orgs","repos_url":"https://api.github.com/users/olegz/repos","events_url":"https://api.github.com/users/olegz/events{/privacy}","received_events_url":"https://api.github.com/users/olegz/received_events","type":"User","site_admin":false},"repo":{"id":41562413,"name":"nifi","full_name":"olegz/nifi","owner":{"login":"olegz","id":172397,"avatar_url":"https://avatars.githubusercontent.com/u/172397?v=3","gravatar_id":"","url":"https://api.github.com/users/olegz","html_url":"https://github.com/olegz","followers_url":"https://api.github.com/users/olegz/followers","following_url":"https://api.github.com/users/olegz/following{/other_user}","gists_url":"https://api.github.com/users/olegz/gists{/gist_id}","starred_url":"https://api.github.com/users/olegz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olegz/subscriptions","organizations_url":"https://api.github.com/users/olegz/orgs","repos_url":"https://api.github.com/users/olegz/repos","events_url":"https://api.github.com/users/olegz/events{/privacy}","received_events_url":"https://api.github.com/users/olegz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/olegz/nifi","description":"Mirror of Apache NiFi","fork":true,"url":"https://api.github.com/repos/olegz/nifi","forks_url":"https://api.github.com/repos/olegz/nifi/forks","keys_url":"https://api.github.com/repos/olegz/nifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/olegz/nifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/olegz/nifi/teams","hooks_url":"https://api.github.com/repos/olegz/nifi/hooks","issue_events_url":"https://api.github.com/repos/olegz/nifi/issues/events{/number}","events_url":"https://api.github.com/repos/olegz/nifi/events","assignees_url":"https://api.github.com/repos/olegz/nifi/assignees{/user}","branches_url":"https://api.github.com/repos/olegz/nifi/branches{/branch}","tags_url":"https://api.github.com/repos/olegz/nifi/tags","blobs_url":"https://api.github.com/repos/olegz/nifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/olegz/nifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/olegz/nifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/olegz/nifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/olegz/nifi/statuses/{sha}","languages_url":"https://api.github.com/repos/olegz/nifi/languages","stargazers_url":"https://api.github.com/repos/olegz/nifi/stargazers","contributors_url":"https://api.github.com/repos/olegz/nifi/contributors","subscribers_url":"https://api.github.com/repos/olegz/nifi/subscribers","subscription_url":"https://api.github.com/repos/olegz/nifi/subscription","commits_url":"https://api.github.com/repos/olegz/nifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/olegz/nifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/olegz/nifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/olegz/nifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/olegz/nifi/contents/{+path}","compare_url":"https://api.github.com/repos/olegz/nifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/olegz/nifi/merges","archive_url":"https://api.github.com/repos/olegz/nifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/olegz/nifi/downloads","issues_url":"https://api.github.com/repos/olegz/nifi/issues{/number}","pulls_url":"https://api.github.com/repos/olegz/nifi/pulls{/number}","milestones_url":"https://api.github.com/repos/olegz/nifi/milestones{/number}","notifications_url":"https://api.github.com/repos/olegz/nifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/olegz/nifi/labels{/name}","releases_url":"https://api.github.com/repos/olegz/nifi/releases{/id}","created_at":"2015-08-28T18:20:46Z","updated_at":"2015-08-28T18:20:54Z","pushed_at":"2015-11-13T20:02:51Z","git_url":"git://github.com/olegz/nifi.git","ssh_url":"git@github.com:olegz/nifi.git","clone_url":"https://github.com/olegz/nifi.git","svn_url":"https://github.com/olegz/nifi","homepage":"","size":34232,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"90f6830003b76204e25dec9fafec2488c8bda550","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":27911088,"name":"nifi","full_name":"apache/nifi","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/nifi","description":"Mirror of Apache NiFi","fork":false,"url":"https://api.github.com/repos/apache/nifi","forks_url":"https://api.github.com/repos/apache/nifi/forks","keys_url":"https://api.github.com/repos/apache/nifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/nifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/nifi/teams","hooks_url":"https://api.github.com/repos/apache/nifi/hooks","issue_events_url":"https://api.github.com/repos/apache/nifi/issues/events{/number}","events_url":"https://api.github.com/repos/apache/nifi/events","assignees_url":"https://api.github.com/repos/apache/nifi/assignees{/user}","branches_url":"https://api.github.com/repos/apache/nifi/branches{/branch}","tags_url":"https://api.github.com/repos/apache/nifi/tags","blobs_url":"https://api.github.com/repos/apache/nifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/nifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/nifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/nifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/nifi/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/nifi/languages","stargazers_url":"https://api.github.com/repos/apache/nifi/stargazers","contributors_url":"https://api.github.com/repos/apache/nifi/contributors","subscribers_url":"https://api.github.com/repos/apache/nifi/subscribers","subscription_url":"https://api.github.com/repos/apache/nifi/subscription","commits_url":"https://api.github.com/repos/apache/nifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/nifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/nifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/nifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/nifi/contents/{+path}","compare_url":"https://api.github.com/repos/apache/nifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/nifi/merges","archive_url":"https://api.github.com/repos/apache/nifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/nifi/downloads","issues_url":"https://api.github.com/repos/apache/nifi/issues{/number}","pulls_url":"https://api.github.com/repos/apache/nifi/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/nifi/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/nifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/nifi/labels{/name}","releases_url":"https://api.github.com/repos/apache/nifi/releases{/id}","created_at":"2014-12-12T08:00:05Z","updated_at":"2015-11-15T12:09:14Z","pushed_at":"2015-11-15T13:41:58Z","git_url":"git://github.com/apache/nifi.git","ssh_url":"git@github.com:apache/nifi.git","clone_url":"https://github.com/apache/nifi.git","svn_url":"https://github.com/apache/nifi","homepage":"","size":95288,"stargazers_count":164,"watchers_count":164,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":130,"mirror_url":"git://git.apache.org/incubator-nifi.git","open_issues_count":12,"forks":130,"open_issues":12,"watchers":164,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/nifi/pulls/123"},"html":{"href":"https://github.com/apache/nifi/pull/123"},"issue":{"href":"https://api.github.com/repos/apache/nifi/issues/123"},"comments":{"href":"https://api.github.com/repos/apache/nifi/issues/123/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/nifi/pulls/123/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/nifi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/nifi/pulls/123/commits"},"statuses":{"href":"https://api.github.com/repos/apache/nifi/statuses/a4d93c62c88f594ef0cd3739a0536769f1ab9b26"}}}}