{"action":"created","comment":{"url":"https://api.github.com/repos/cdi-spec/cdi/pulls/comments/46421645","id":46421645,"diff_hunk":"@@ -123,14 +124,15 @@\n \n     /**\n      * <p>\n-     * Fires an event asynchronously with the specified qualifiers and notifies synchronous and asynchronous observers.\n+     * Fires an event asynchronously with the specified qualifiers and notifies asynchronous observers.\n      * A custom {@link Executor} will be used to make asynchronous calls \n      * </p>\n      *\n      * @param event the event object\n      * @param executor a custom executor to execute asynchronous event\n      * @return a {@link CompletionStage} allowing further pipeline composition on the asynchronous operation.\n-     *         if any of the synchronous or asynchronous observers notfied by this event throws an exception\n+     *         Default asynchronous execution facility is container specific.\n+     *         if any observer notified by this event throws an exception","path":"api/src/main/java/javax/enterprise/event/Event.java","position":31,"original_position":31,"commit_id":"89a329f28bd76b9f75bc29a01f88ff7e3072618c","original_commit_id":"89a329f28bd76b9f75bc29a01f88ff7e3072618c","user":{"login":"tremes","id":924640,"avatar_url":"https://avatars.githubusercontent.com/u/924640?v=3","gravatar_id":"","url":"https://api.github.com/users/tremes","html_url":"https://github.com/tremes","followers_url":"https://api.github.com/users/tremes/followers","following_url":"https://api.github.com/users/tremes/following{/other_user}","gists_url":"https://api.github.com/users/tremes/gists{/gist_id}","starred_url":"https://api.github.com/users/tremes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tremes/subscriptions","organizations_url":"https://api.github.com/users/tremes/orgs","repos_url":"https://api.github.com/users/tremes/repos","events_url":"https://api.github.com/users/tremes/events{/privacy}","received_events_url":"https://api.github.com/users/tremes/received_events","type":"User","site_admin":false},"body":"Uppercase \"If\"?. Same for line 115. ","created_at":"2015-12-02T14:44:32Z","updated_at":"2015-12-02T14:44:32Z","html_url":"https://github.com/cdi-spec/cdi/pull/266#discussion_r46421645","pull_request_url":"https://api.github.com/repos/cdi-spec/cdi/pulls/266","_links":{"self":{"href":"https://api.github.com/repos/cdi-spec/cdi/pulls/comments/46421645"},"html":{"href":"https://github.com/cdi-spec/cdi/pull/266#discussion_r46421645"},"pull_request":{"href":"https://api.github.com/repos/cdi-spec/cdi/pulls/266"}}},"pull_request":{"url":"https://api.github.com/repos/cdi-spec/cdi/pulls/266","id":52237302,"html_url":"https://github.com/cdi-spec/cdi/pull/266","diff_url":"https://github.com/cdi-spec/cdi/pull/266.diff","patch_url":"https://github.com/cdi-spec/cdi/pull/266.patch","issue_url":"https://api.github.com/repos/cdi-spec/cdi/issues/266","number":266,"state":"open","locked":false,"title":"CDI-563 Event.fireAsync() - clarify the usage of the returned CompletionStage","user":{"login":"antoinesd","id":489817,"avatar_url":"https://avatars.githubusercontent.com/u/489817?v=3","gravatar_id":"","url":"https://api.github.com/users/antoinesd","html_url":"https://github.com/antoinesd","followers_url":"https://api.github.com/users/antoinesd/followers","following_url":"https://api.github.com/users/antoinesd/following{/other_user}","gists_url":"https://api.github.com/users/antoinesd/gists{/gist_id}","starred_url":"https://api.github.com/users/antoinesd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antoinesd/subscriptions","organizations_url":"https://api.github.com/users/antoinesd/orgs","repos_url":"https://api.github.com/users/antoinesd/repos","events_url":"https://api.github.com/users/antoinesd/events{/privacy}","received_events_url":"https://api.github.com/users/antoinesd/received_events","type":"User","site_admin":false},"body":"CDI-563 Event.fireAsync() - clarify the usage of the returned CompletionStage","created_at":"2015-12-01T10:01:28Z","updated_at":"2015-12-02T14:44:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"06d0b1ad959785c072533235c1e408ac66360de3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cdi-spec/cdi/pulls/266/commits","review_comments_url":"https://api.github.com/repos/cdi-spec/cdi/pulls/266/comments","review_comment_url":"https://api.github.com/repos/cdi-spec/cdi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cdi-spec/cdi/issues/266/comments","statuses_url":"https://api.github.com/repos/cdi-spec/cdi/statuses/89a329f28bd76b9f75bc29a01f88ff7e3072618c","head":{"label":"antoinesd:CDI-563","ref":"CDI-563","sha":"89a329f28bd76b9f75bc29a01f88ff7e3072618c","user":{"login":"antoinesd","id":489817,"avatar_url":"https://avatars.githubusercontent.com/u/489817?v=3","gravatar_id":"","url":"https://api.github.com/users/antoinesd","html_url":"https://github.com/antoinesd","followers_url":"https://api.github.com/users/antoinesd/followers","following_url":"https://api.github.com/users/antoinesd/following{/other_user}","gists_url":"https://api.github.com/users/antoinesd/gists{/gist_id}","starred_url":"https://api.github.com/users/antoinesd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antoinesd/subscriptions","organizations_url":"https://api.github.com/users/antoinesd/orgs","repos_url":"https://api.github.com/users/antoinesd/repos","events_url":"https://api.github.com/users/antoinesd/events{/privacy}","received_events_url":"https://api.github.com/users/antoinesd/received_events","type":"User","site_admin":false},"repo":{"id":16379835,"name":"cdi-spec","full_name":"antoinesd/cdi-spec","owner":{"login":"antoinesd","id":489817,"avatar_url":"https://avatars.githubusercontent.com/u/489817?v=3","gravatar_id":"","url":"https://api.github.com/users/antoinesd","html_url":"https://github.com/antoinesd","followers_url":"https://api.github.com/users/antoinesd/followers","following_url":"https://api.github.com/users/antoinesd/following{/other_user}","gists_url":"https://api.github.com/users/antoinesd/gists{/gist_id}","starred_url":"https://api.github.com/users/antoinesd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antoinesd/subscriptions","organizations_url":"https://api.github.com/users/antoinesd/orgs","repos_url":"https://api.github.com/users/antoinesd/repos","events_url":"https://api.github.com/users/antoinesd/events{/privacy}","received_events_url":"https://api.github.com/users/antoinesd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/antoinesd/cdi-spec","description":"CDI specification","fork":true,"url":"https://api.github.com/repos/antoinesd/cdi-spec","forks_url":"https://api.github.com/repos/antoinesd/cdi-spec/forks","keys_url":"https://api.github.com/repos/antoinesd/cdi-spec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/antoinesd/cdi-spec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/antoinesd/cdi-spec/teams","hooks_url":"https://api.github.com/repos/antoinesd/cdi-spec/hooks","issue_events_url":"https://api.github.com/repos/antoinesd/cdi-spec/issues/events{/number}","events_url":"https://api.github.com/repos/antoinesd/cdi-spec/events","assignees_url":"https://api.github.com/repos/antoinesd/cdi-spec/assignees{/user}","branches_url":"https://api.github.com/repos/antoinesd/cdi-spec/branches{/branch}","tags_url":"https://api.github.com/repos/antoinesd/cdi-spec/tags","blobs_url":"https://api.github.com/repos/antoinesd/cdi-spec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/antoinesd/cdi-spec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/antoinesd/cdi-spec/git/refs{/sha}","trees_url":"https://api.github.com/repos/antoinesd/cdi-spec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/antoinesd/cdi-spec/statuses/{sha}","languages_url":"https://api.github.com/repos/antoinesd/cdi-spec/languages","stargazers_url":"https://api.github.com/repos/antoinesd/cdi-spec/stargazers","contributors_url":"https://api.github.com/repos/antoinesd/cdi-spec/contributors","subscribers_url":"https://api.github.com/repos/antoinesd/cdi-spec/subscribers","subscription_url":"https://api.github.com/repos/antoinesd/cdi-spec/subscription","commits_url":"https://api.github.com/repos/antoinesd/cdi-spec/commits{/sha}","git_commits_url":"https://api.github.com/repos/antoinesd/cdi-spec/git/commits{/sha}","comments_url":"https://api.github.com/repos/antoinesd/cdi-spec/comments{/number}","issue_comment_url":"https://api.github.com/repos/antoinesd/cdi-spec/issues/comments{/number}","contents_url":"https://api.github.com/repos/antoinesd/cdi-spec/contents/{+path}","compare_url":"https://api.github.com/repos/antoinesd/cdi-spec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/antoinesd/cdi-spec/merges","archive_url":"https://api.github.com/repos/antoinesd/cdi-spec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/antoinesd/cdi-spec/downloads","issues_url":"https://api.github.com/repos/antoinesd/cdi-spec/issues{/number}","pulls_url":"https://api.github.com/repos/antoinesd/cdi-spec/pulls{/number}","milestones_url":"https://api.github.com/repos/antoinesd/cdi-spec/milestones{/number}","notifications_url":"https://api.github.com/repos/antoinesd/cdi-spec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/antoinesd/cdi-spec/labels{/name}","releases_url":"https://api.github.com/repos/antoinesd/cdi-spec/releases{/id}","created_at":"2014-01-30T14:43:02Z","updated_at":"2015-04-30T15:02:23Z","pushed_at":"2015-12-02T14:31:47Z","git_url":"git://github.com/antoinesd/cdi-spec.git","ssh_url":"git@github.com:antoinesd/cdi-spec.git","clone_url":"https://github.com/antoinesd/cdi-spec.git","svn_url":"https://github.com/antoinesd/cdi-spec","homepage":"","size":7438,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"cdi-spec:2.0-EDR2","ref":"2.0-EDR2","sha":"86d9594e447ce9285d6f5c05abc8a8c6af63ed30","user":{"login":"cdi-spec","id":2632663,"avatar_url":"https://avatars.githubusercontent.com/u/2632663?v=3","gravatar_id":"","url":"https://api.github.com/users/cdi-spec","html_url":"https://github.com/cdi-spec","followers_url":"https://api.github.com/users/cdi-spec/followers","following_url":"https://api.github.com/users/cdi-spec/following{/other_user}","gists_url":"https://api.github.com/users/cdi-spec/gists{/gist_id}","starred_url":"https://api.github.com/users/cdi-spec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdi-spec/subscriptions","organizations_url":"https://api.github.com/users/cdi-spec/orgs","repos_url":"https://api.github.com/users/cdi-spec/repos","events_url":"https://api.github.com/users/cdi-spec/events{/privacy}","received_events_url":"https://api.github.com/users/cdi-spec/received_events","type":"Organization","site_admin":false},"repo":{"id":1756541,"name":"cdi","full_name":"cdi-spec/cdi","owner":{"login":"cdi-spec","id":2632663,"avatar_url":"https://avatars.githubusercontent.com/u/2632663?v=3","gravatar_id":"","url":"https://api.github.com/users/cdi-spec","html_url":"https://github.com/cdi-spec","followers_url":"https://api.github.com/users/cdi-spec/followers","following_url":"https://api.github.com/users/cdi-spec/following{/other_user}","gists_url":"https://api.github.com/users/cdi-spec/gists{/gist_id}","starred_url":"https://api.github.com/users/cdi-spec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdi-spec/subscriptions","organizations_url":"https://api.github.com/users/cdi-spec/orgs","repos_url":"https://api.github.com/users/cdi-spec/repos","events_url":"https://api.github.com/users/cdi-spec/events{/privacy}","received_events_url":"https://api.github.com/users/cdi-spec/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cdi-spec/cdi","description":"CDI specification","fork":false,"url":"https://api.github.com/repos/cdi-spec/cdi","forks_url":"https://api.github.com/repos/cdi-spec/cdi/forks","keys_url":"https://api.github.com/repos/cdi-spec/cdi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cdi-spec/cdi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cdi-spec/cdi/teams","hooks_url":"https://api.github.com/repos/cdi-spec/cdi/hooks","issue_events_url":"https://api.github.com/repos/cdi-spec/cdi/issues/events{/number}","events_url":"https://api.github.com/repos/cdi-spec/cdi/events","assignees_url":"https://api.github.com/repos/cdi-spec/cdi/assignees{/user}","branches_url":"https://api.github.com/repos/cdi-spec/cdi/branches{/branch}","tags_url":"https://api.github.com/repos/cdi-spec/cdi/tags","blobs_url":"https://api.github.com/repos/cdi-spec/cdi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cdi-spec/cdi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cdi-spec/cdi/git/refs{/sha}","trees_url":"https://api.github.com/repos/cdi-spec/cdi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cdi-spec/cdi/statuses/{sha}","languages_url":"https://api.github.com/repos/cdi-spec/cdi/languages","stargazers_url":"https://api.github.com/repos/cdi-spec/cdi/stargazers","contributors_url":"https://api.github.com/repos/cdi-spec/cdi/contributors","subscribers_url":"https://api.github.com/repos/cdi-spec/cdi/subscribers","subscription_url":"https://api.github.com/repos/cdi-spec/cdi/subscription","commits_url":"https://api.github.com/repos/cdi-spec/cdi/commits{/sha}","git_commits_url":"https://api.github.com/repos/cdi-spec/cdi/git/commits{/sha}","comments_url":"https://api.github.com/repos/cdi-spec/cdi/comments{/number}","issue_comment_url":"https://api.github.com/repos/cdi-spec/cdi/issues/comments{/number}","contents_url":"https://api.github.com/repos/cdi-spec/cdi/contents/{+path}","compare_url":"https://api.github.com/repos/cdi-spec/cdi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cdi-spec/cdi/merges","archive_url":"https://api.github.com/repos/cdi-spec/cdi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cdi-spec/cdi/downloads","issues_url":"https://api.github.com/repos/cdi-spec/cdi/issues{/number}","pulls_url":"https://api.github.com/repos/cdi-spec/cdi/pulls{/number}","milestones_url":"https://api.github.com/repos/cdi-spec/cdi/milestones{/number}","notifications_url":"https://api.github.com/repos/cdi-spec/cdi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cdi-spec/cdi/labels{/name}","releases_url":"https://api.github.com/repos/cdi-spec/cdi/releases{/id}","created_at":"2011-05-16T17:27:06Z","updated_at":"2015-11-26T19:46:44Z","pushed_at":"2015-12-02T14:31:47Z","git_url":"git://github.com/cdi-spec/cdi.git","ssh_url":"git@github.com:cdi-spec/cdi.git","clone_url":"https://github.com/cdi-spec/cdi.git","svn_url":"https://github.com/cdi-spec/cdi","homepage":"","size":7993,"stargazers_count":46,"watchers_count":46,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":29,"mirror_url":null,"open_issues_count":1,"forks":29,"open_issues":1,"watchers":46,"default_branch":"2.0-EDR2"}},"_links":{"self":{"href":"https://api.github.com/repos/cdi-spec/cdi/pulls/266"},"html":{"href":"https://github.com/cdi-spec/cdi/pull/266"},"issue":{"href":"https://api.github.com/repos/cdi-spec/cdi/issues/266"},"comments":{"href":"https://api.github.com/repos/cdi-spec/cdi/issues/266/comments"},"review_comments":{"href":"https://api.github.com/repos/cdi-spec/cdi/pulls/266/comments"},"review_comment":{"href":"https://api.github.com/repos/cdi-spec/cdi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cdi-spec/cdi/pulls/266/commits"},"statuses":{"href":"https://api.github.com/repos/cdi-spec/cdi/statuses/89a329f28bd76b9f75bc29a01f88ff7e3072618c"}}}}