{"action":"created","issue":{"url":"https://api.github.com/repos/mamedev/mame/issues/517","labels_url":"https://api.github.com/repos/mamedev/mame/issues/517/labels{/name}","comments_url":"https://api.github.com/repos/mamedev/mame/issues/517/comments","events_url":"https://api.github.com/repos/mamedev/mame/issues/517/events","html_url":"https://github.com/mamedev/mame/pull/517","id":123322414,"number":517,"title":"Modernize x86log.h and x86log.cpp:","user":{"login":"SuperV1234","id":918661,"avatar_url":"https://avatars.githubusercontent.com/u/918661?v=3","gravatar_id":"","url":"https://api.github.com/users/SuperV1234","html_url":"https://github.com/SuperV1234","followers_url":"https://api.github.com/users/SuperV1234/followers","following_url":"https://api.github.com/users/SuperV1234/following{/other_user}","gists_url":"https://api.github.com/users/SuperV1234/gists{/gist_id}","starred_url":"https://api.github.com/users/SuperV1234/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SuperV1234/subscriptions","organizations_url":"https://api.github.com/users/SuperV1234/orgs","repos_url":"https://api.github.com/users/SuperV1234/repos","events_url":"https://api.github.com/users/SuperV1234/events{/privacy}","received_events_url":"https://api.github.com/users/SuperV1234/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-12-21T17:31:19Z","updated_at":"2015-12-23T18:02:57Z","closed_at":"2015-12-21T17:50:16Z","pull_request":{"url":"https://api.github.com/repos/mamedev/mame/pulls/517","html_url":"https://github.com/mamedev/mame/pull/517","diff_url":"https://github.com/mamedev/mame/pull/517.diff","patch_url":"https://github.com/mamedev/mame/pull/517.patch"},"body":"* Use variadic template functions instead of `va_list`\r\n    * In `x86log_mark_as_data` and `x86log_printf`\r\n* Add `noexcept` where appropriate/safe\r\n* Use `constexpr std::size_t` instead of macros for constants\r\n* Nest `nullptr` check to prevent useless check, add assertion\r\n    * In `x86log_printf`\r\n* Move definitions of `log_comment`, `data_range_t`, `x86log_context` to `x86_log.h` from `x86_log.cpp`\r\n* Adapt usages of `x86log_printf` in `drcbex64.cpp` and `drcbex86.cpp`"},"comment":{"url":"https://api.github.com/repos/mamedev/mame/issues/comments/166959770","html_url":"https://github.com/mamedev/mame/pull/517#issuecomment-166959770","issue_url":"https://api.github.com/repos/mamedev/mame/issues/517","id":166959770,"user":{"login":"SuperV1234","id":918661,"avatar_url":"https://avatars.githubusercontent.com/u/918661?v=3","gravatar_id":"","url":"https://api.github.com/users/SuperV1234","html_url":"https://github.com/SuperV1234","followers_url":"https://api.github.com/users/SuperV1234/followers","following_url":"https://api.github.com/users/SuperV1234/following{/other_user}","gists_url":"https://api.github.com/users/SuperV1234/gists{/gist_id}","starred_url":"https://api.github.com/users/SuperV1234/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SuperV1234/subscriptions","organizations_url":"https://api.github.com/users/SuperV1234/orgs","repos_url":"https://api.github.com/users/SuperV1234/repos","events_url":"https://api.github.com/users/SuperV1234/events{/privacy}","received_events_url":"https://api.github.com/users/SuperV1234/received_events","type":"User","site_admin":false},"created_at":"2015-12-23T18:02:57Z","updated_at":"2015-12-23T18:02:57Z","body":"I'm still looking into any possible mistake - is it possible that `simple_list` was being used polymorphically somewhere? \r\n\r\nIt had a `virtual` destructor that I changed into a non-`virtual` destructor in aa6d4d0b882c86dc5e55e0dcf68884c6a588797b, because I could not find any polymorphically usage of `simple_list` in the codebase.\r\n\r\nAssuming I missed such usages: could you try if reintroducing `virtual` in `~simple_list` \r\n\r\n    virtual ~simple_list() noexcept { reset(); }\r\n\r\nand check if the crash still occurs?"}}