{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/readability/pulls/comments/27226850","id":27226850,"diff_hunk":"@@ -462,6 +477,37 @@ Readability.prototype = {\n     return node && node.nextElementSibling;\n   },\n \n+  /**\n+   * Like _getNextNode, but for DOM implementations with no\n+   * firstElementChild/nextElementSibling functionality...","path":"Readability.js","position":36,"original_position":36,"commit_id":"9cee1357f8baac3600b0ccdc034409c2950e674d","original_commit_id":"9cee1357f8baac3600b0ccdc034409c2950e674d","user":{"login":"n1k0","id":41547,"avatar_url":"https://avatars.githubusercontent.com/u/41547?v=3","gravatar_id":"","url":"https://api.github.com/users/n1k0","html_url":"https://github.com/n1k0","followers_url":"https://api.github.com/users/n1k0/followers","following_url":"https://api.github.com/users/n1k0/following{/other_user}","gists_url":"https://api.github.com/users/n1k0/gists{/gist_id}","starred_url":"https://api.github.com/users/n1k0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/n1k0/subscriptions","organizations_url":"https://api.github.com/users/n1k0/orgs","repos_url":"https://api.github.com/users/n1k0/repos","events_url":"https://api.github.com/users/n1k0/events{/privacy}","received_events_url":"https://api.github.com/users/n1k0/received_events","type":"User","site_admin":false},"body":"Does this only concern jsdom? If so we might want to revisit using it at all if it's broken…","created_at":"2015-03-26T16:01:56Z","updated_at":"2015-03-26T16:01:56Z","html_url":"https://github.com/mozilla/readability/pull/78#discussion_r27226850","pull_request_url":"https://api.github.com/repos/mozilla/readability/pulls/78","_links":{"self":{"href":"https://api.github.com/repos/mozilla/readability/pulls/comments/27226850"},"html":{"href":"https://github.com/mozilla/readability/pull/78#discussion_r27226850"},"pull_request":{"href":"https://api.github.com/repos/mozilla/readability/pulls/78"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/readability/pulls/78","id":31923915,"html_url":"https://github.com/mozilla/readability/pull/78","diff_url":"https://github.com/mozilla/readability/pull/78.diff","patch_url":"https://github.com/mozilla/readability/pull/78.patch","issue_url":"https://api.github.com/repos/mozilla/readability/issues/78","number":78,"state":"open","locked":false,"title":"Fix readability to work with real dom (fixes #72)","user":{"login":"gijsk","id":375983,"avatar_url":"https://avatars.githubusercontent.com/u/375983?v=3","gravatar_id":"","url":"https://api.github.com/users/gijsk","html_url":"https://github.com/gijsk","followers_url":"https://api.github.com/users/gijsk/followers","following_url":"https://api.github.com/users/gijsk/following{/other_user}","gists_url":"https://api.github.com/users/gijsk/gists{/gist_id}","starred_url":"https://api.github.com/users/gijsk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gijsk/subscriptions","organizations_url":"https://api.github.com/users/gijsk/orgs","repos_url":"https://api.github.com/users/gijsk/repos","events_url":"https://api.github.com/users/gijsk/events{/privacy}","received_events_url":"https://api.github.com/users/gijsk/received_events","type":"User","site_admin":false},"body":"This really needs careful review and probably another iteration or two.\r\n\r\nThere is 1 failing test, the TMZ one, with jsdom, because it contains a comment.\r\n\r\nI don't want to add comment parsing to JSDOMParser.\r\nI don't want to have different testcase output for jsdom.\r\nI don't really want to strip all the comments explicitly because it'll need another DOM walk and is essentially useless.\r\n\r\nThoughts? @leibovic @n1k0 @DavidBruant ","created_at":"2015-03-25T13:56:48Z","updated_at":"2015-03-26T16:01:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a3a614c7797e2fc72d583c9428e81aec9fc892af","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/readability/pulls/78/commits","review_comments_url":"https://api.github.com/repos/mozilla/readability/pulls/78/comments","review_comment_url":"https://api.github.com/repos/mozilla/readability/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/readability/issues/78/comments","statuses_url":"https://api.github.com/repos/mozilla/readability/statuses/9cee1357f8baac3600b0ccdc034409c2950e674d","head":{"label":"gijsk:fix-readability-to-work-with-real-dom","ref":"fix-readability-to-work-with-real-dom","sha":"9cee1357f8baac3600b0ccdc034409c2950e674d","user":{"login":"gijsk","id":375983,"avatar_url":"https://avatars.githubusercontent.com/u/375983?v=3","gravatar_id":"","url":"https://api.github.com/users/gijsk","html_url":"https://github.com/gijsk","followers_url":"https://api.github.com/users/gijsk/followers","following_url":"https://api.github.com/users/gijsk/following{/other_user}","gists_url":"https://api.github.com/users/gijsk/gists{/gist_id}","starred_url":"https://api.github.com/users/gijsk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gijsk/subscriptions","organizations_url":"https://api.github.com/users/gijsk/orgs","repos_url":"https://api.github.com/users/gijsk/repos","events_url":"https://api.github.com/users/gijsk/events{/privacy}","received_events_url":"https://api.github.com/users/gijsk/received_events","type":"User","site_admin":false},"repo":{"id":32408267,"name":"readability","full_name":"gijsk/readability","owner":{"login":"gijsk","id":375983,"avatar_url":"https://avatars.githubusercontent.com/u/375983?v=3","gravatar_id":"","url":"https://api.github.com/users/gijsk","html_url":"https://github.com/gijsk","followers_url":"https://api.github.com/users/gijsk/followers","following_url":"https://api.github.com/users/gijsk/following{/other_user}","gists_url":"https://api.github.com/users/gijsk/gists{/gist_id}","starred_url":"https://api.github.com/users/gijsk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gijsk/subscriptions","organizations_url":"https://api.github.com/users/gijsk/orgs","repos_url":"https://api.github.com/users/gijsk/repos","events_url":"https://api.github.com/users/gijsk/events{/privacy}","received_events_url":"https://api.github.com/users/gijsk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gijsk/readability","description":"A standalone version of the readability lib","fork":true,"url":"https://api.github.com/repos/gijsk/readability","forks_url":"https://api.github.com/repos/gijsk/readability/forks","keys_url":"https://api.github.com/repos/gijsk/readability/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gijsk/readability/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gijsk/readability/teams","hooks_url":"https://api.github.com/repos/gijsk/readability/hooks","issue_events_url":"https://api.github.com/repos/gijsk/readability/issues/events{/number}","events_url":"https://api.github.com/repos/gijsk/readability/events","assignees_url":"https://api.github.com/repos/gijsk/readability/assignees{/user}","branches_url":"https://api.github.com/repos/gijsk/readability/branches{/branch}","tags_url":"https://api.github.com/repos/gijsk/readability/tags","blobs_url":"https://api.github.com/repos/gijsk/readability/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gijsk/readability/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gijsk/readability/git/refs{/sha}","trees_url":"https://api.github.com/repos/gijsk/readability/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gijsk/readability/statuses/{sha}","languages_url":"https://api.github.com/repos/gijsk/readability/languages","stargazers_url":"https://api.github.com/repos/gijsk/readability/stargazers","contributors_url":"https://api.github.com/repos/gijsk/readability/contributors","subscribers_url":"https://api.github.com/repos/gijsk/readability/subscribers","subscription_url":"https://api.github.com/repos/gijsk/readability/subscription","commits_url":"https://api.github.com/repos/gijsk/readability/commits{/sha}","git_commits_url":"https://api.github.com/repos/gijsk/readability/git/commits{/sha}","comments_url":"https://api.github.com/repos/gijsk/readability/comments{/number}","issue_comment_url":"https://api.github.com/repos/gijsk/readability/issues/comments{/number}","contents_url":"https://api.github.com/repos/gijsk/readability/contents/{+path}","compare_url":"https://api.github.com/repos/gijsk/readability/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gijsk/readability/merges","archive_url":"https://api.github.com/repos/gijsk/readability/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gijsk/readability/downloads","issues_url":"https://api.github.com/repos/gijsk/readability/issues{/number}","pulls_url":"https://api.github.com/repos/gijsk/readability/pulls{/number}","milestones_url":"https://api.github.com/repos/gijsk/readability/milestones{/number}","notifications_url":"https://api.github.com/repos/gijsk/readability/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gijsk/readability/labels{/name}","releases_url":"https://api.github.com/repos/gijsk/readability/releases{/id}","created_at":"2015-03-17T17:13:44Z","updated_at":"2015-03-25T17:13:27Z","pushed_at":"2015-03-25T17:15:29Z","git_url":"git://github.com/gijsk/readability.git","ssh_url":"git@github.com:gijsk/readability.git","clone_url":"https://github.com/gijsk/readability.git","svn_url":"https://github.com/gijsk/readability","homepage":null,"size":683,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"194a5376c8b2d3489fb7432995158b4b08353370","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":30231828,"name":"readability","full_name":"mozilla/readability","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/readability","description":"A standalone version of the readability lib","fork":false,"url":"https://api.github.com/repos/mozilla/readability","forks_url":"https://api.github.com/repos/mozilla/readability/forks","keys_url":"https://api.github.com/repos/mozilla/readability/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/readability/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/readability/teams","hooks_url":"https://api.github.com/repos/mozilla/readability/hooks","issue_events_url":"https://api.github.com/repos/mozilla/readability/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/readability/events","assignees_url":"https://api.github.com/repos/mozilla/readability/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/readability/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/readability/tags","blobs_url":"https://api.github.com/repos/mozilla/readability/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/readability/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/readability/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/readability/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/readability/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/readability/languages","stargazers_url":"https://api.github.com/repos/mozilla/readability/stargazers","contributors_url":"https://api.github.com/repos/mozilla/readability/contributors","subscribers_url":"https://api.github.com/repos/mozilla/readability/subscribers","subscription_url":"https://api.github.com/repos/mozilla/readability/subscription","commits_url":"https://api.github.com/repos/mozilla/readability/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/readability/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/readability/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/readability/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/readability/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/readability/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/readability/merges","archive_url":"https://api.github.com/repos/mozilla/readability/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/readability/downloads","issues_url":"https://api.github.com/repos/mozilla/readability/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/readability/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/readability/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/readability/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/readability/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/readability/releases{/id}","created_at":"2015-02-03T08:01:54Z","updated_at":"2015-03-25T13:57:35Z","pushed_at":"2015-03-25T17:15:29Z","git_url":"git://github.com/mozilla/readability.git","ssh_url":"git@github.com:mozilla/readability.git","clone_url":"https://github.com/mozilla/readability.git","svn_url":"https://github.com/mozilla/readability","homepage":null,"size":1338,"stargazers_count":52,"watchers_count":52,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":25,"forks":7,"open_issues":25,"watchers":52,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/readability/pulls/78"},"html":{"href":"https://github.com/mozilla/readability/pull/78"},"issue":{"href":"https://api.github.com/repos/mozilla/readability/issues/78"},"comments":{"href":"https://api.github.com/repos/mozilla/readability/issues/78/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/readability/pulls/78/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/readability/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/readability/pulls/78/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/readability/statuses/9cee1357f8baac3600b0ccdc034409c2950e674d"}}}}