{"action":"created","issue":{"url":"https://api.github.com/repos/djs55/ocaml-c3/issues/10","labels_url":"https://api.github.com/repos/djs55/ocaml-c3/issues/10/labels{/name}","comments_url":"https://api.github.com/repos/djs55/ocaml-c3/issues/10/comments","events_url":"https://api.github.com/repos/djs55/ocaml-c3/issues/10/events","html_url":"https://github.com/djs55/ocaml-c3/pull/10","id":89725849,"number":10,"title":"React interface","user":{"login":"Drup","id":801124,"avatar_url":"https://avatars.githubusercontent.com/u/801124?v=3","gravatar_id":"","url":"https://api.github.com/users/Drup","html_url":"https://github.com/Drup","followers_url":"https://api.github.com/users/Drup/followers","following_url":"https://api.github.com/users/Drup/following{/other_user}","gists_url":"https://api.github.com/users/Drup/gists{/gist_id}","starred_url":"https://api.github.com/users/Drup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Drup/subscriptions","organizations_url":"https://api.github.com/users/Drup/orgs","repos_url":"https://api.github.com/users/Drup/repos","events_url":"https://api.github.com/users/Drup/events{/privacy}","received_events_url":"https://api.github.com/users/Drup/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-06-20T06:20:49Z","updated_at":"2015-06-20T15:58:33Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/djs55/ocaml-c3/pulls/10","html_url":"https://github.com/djs55/ocaml-c3/pull/10","diff_url":"https://github.com/djs55/ocaml-c3/pull/10.diff","patch_url":"https://github.com/djs55/ocaml-c3/pull/10.patch"},"body":"This adds a react interface for Segment/Line\r\n\r\nThere is a bit of a question here. I decided to add a separated interface, but I actually think it would be better integrated directly by adding a function `Segment.make_react`. The downside is that it forces dependency to react. I don't think that's much of an issue in practice.\r\n\r\nI also think it would be interesting to add a flow mode \"window\" (of int) that would scroll through the updates if they get over a certain size.\r\n\r\nI'm not sure about react for the other graphs (and I didn't really looked at the c3 interface for them)."},"comment":{"url":"https://api.github.com/repos/djs55/ocaml-c3/issues/comments/113786333","html_url":"https://github.com/djs55/ocaml-c3/pull/10#issuecomment-113786333","issue_url":"https://api.github.com/repos/djs55/ocaml-c3/issues/10","id":113786333,"user":{"login":"Drup","id":801124,"avatar_url":"https://avatars.githubusercontent.com/u/801124?v=3","gravatar_id":"","url":"https://api.github.com/users/Drup","html_url":"https://github.com/Drup","followers_url":"https://api.github.com/users/Drup/followers","following_url":"https://api.github.com/users/Drup/following{/other_user}","gists_url":"https://api.github.com/users/Drup/gists{/gist_id}","starred_url":"https://api.github.com/users/Drup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Drup/subscriptions","organizations_url":"https://api.github.com/users/Drup/orgs","repos_url":"https://api.github.com/users/Drup/repos","events_url":"https://api.github.com/users/Drup/events{/privacy}","received_events_url":"https://api.github.com/users/Drup/received_events","type":"User","site_admin":false},"created_at":"2015-06-20T15:58:33Z","updated_at":"2015-06-20T15:58:33Z","body":"Important note: using react is not completely free in javascript, because it doesn't have weak references (we replace them by non-weak ones). So you can have space leaks as it keeps the past of an event/signal in memory. Of course it goes away if you refresh the page. It's usually pretty benign, but it's something to be aware of.\r\n\r\nIt's not a problem if you just use the non-react part, of course, but it means you still want a non-react way to update a graph, for users who cares. "}}