{"action":"created","issue":{"url":"https://api.github.com/repos/mit-crpg/openmc/issues/480","labels_url":"https://api.github.com/repos/mit-crpg/openmc/issues/480/labels{/name}","comments_url":"https://api.github.com/repos/mit-crpg/openmc/issues/480/comments","events_url":"https://api.github.com/repos/mit-crpg/openmc/issues/480/events","html_url":"https://github.com/mit-crpg/openmc/issues/480","id":111186423,"number":480,"title":"Tally triggers fail with more than one filter","user":{"login":"wbinventor","id":209492,"avatar_url":"https://avatars.githubusercontent.com/u/209492?v=3","gravatar_id":"","url":"https://api.github.com/users/wbinventor","html_url":"https://github.com/wbinventor","followers_url":"https://api.github.com/users/wbinventor/followers","following_url":"https://api.github.com/users/wbinventor/following{/other_user}","gists_url":"https://api.github.com/users/wbinventor/gists{/gist_id}","starred_url":"https://api.github.com/users/wbinventor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wbinventor/subscriptions","organizations_url":"https://api.github.com/users/wbinventor/orgs","repos_url":"https://api.github.com/users/wbinventor/repos","events_url":"https://api.github.com/users/wbinventor/events{/privacy}","received_events_url":"https://api.github.com/users/wbinventor/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/mit-crpg/openmc/labels/Bugs","name":"Bugs","color":"e10c02"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-10-13T14:00:47Z","updated_at":"2015-10-25T01:08:36Z","closed_at":"2015-10-25T01:08:36Z","body":"As part of the conversation on PR #471, I've come to the realization that tally triggers do not work with more than one filter. In the case of the MGXS module, tallies have a filter over \"cell\" / \"material\" / \"universe\" IDs and another over \"energy\" (and in some cases a third over \"energyout\"). None of these triggers are checked properly since it appears that the logic to compute filter bins fails. In particular, I think there is an issue with lines 174-184 in \"src/trigger.F90\" ([link](https://github.com/mit-crpg/openmc/blob/develop/src/trigger.F90#L178)). I've always found the code to compute filter indices tricky, and don't have much time at the moment to spend on this, so wanted to post it here to keep a record of it and why triggers won't yet work for the MGXS module."},"comment":{"url":"https://api.github.com/repos/mit-crpg/openmc/issues/comments/150878351","html_url":"https://github.com/mit-crpg/openmc/issues/480#issuecomment-150878351","issue_url":"https://api.github.com/repos/mit-crpg/openmc/issues/480","id":150878351,"user":{"login":"wbinventor","id":209492,"avatar_url":"https://avatars.githubusercontent.com/u/209492?v=3","gravatar_id":"","url":"https://api.github.com/users/wbinventor","html_url":"https://github.com/wbinventor","followers_url":"https://api.github.com/users/wbinventor/followers","following_url":"https://api.github.com/users/wbinventor/following{/other_user}","gists_url":"https://api.github.com/users/wbinventor/gists{/gist_id}","starred_url":"https://api.github.com/users/wbinventor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wbinventor/subscriptions","organizations_url":"https://api.github.com/users/wbinventor/orgs","repos_url":"https://api.github.com/users/wbinventor/repos","events_url":"https://api.github.com/users/wbinventor/events{/privacy}","received_events_url":"https://api.github.com/users/wbinventor/received_events","type":"User","site_admin":false},"created_at":"2015-10-25T01:08:36Z","updated_at":"2015-10-25T01:08:36Z","body":"Closed with #481."}}