{"action":"created","comment":{"url":"https://api.github.com/repos/Homebrew/homebrew/pulls/comments/25996881","id":25996881,"diff_hunk":"@@ -36,18 +40,14 @@ def install\n \n     if build.with? \"gui\"\n       cd \"gui\" do\n-        # fix make not finding cfg directory:\n-        # https://github.com/Homebrew/homebrew/issues/27756\n-        inreplace \"gui.qrc\", \"../cfg/\", \"#{prefix}/cfg/\"\n-\n         if build.with? \"rules\"\n-          system \"qmake\"\n+          system \"qmake\", \"HAVE_RULES=yes\"\n         else\n           system \"qmake\", \"HAVE_RULES=no\"\n         end\n \n         system \"make\"","path":"Library/Formula/cppcheck.rb","position":26,"original_position":26,"commit_id":"f1d2bedfa2fa75c79a98b054c832d592aed557c5","original_commit_id":"f1d2bedfa2fa75c79a98b054c832d592aed557c5","user":{"login":"mikemcquaid","id":125011,"avatar_url":"https://avatars.githubusercontent.com/u/125011?v=3","gravatar_id":"","url":"https://api.github.com/users/mikemcquaid","html_url":"https://github.com/mikemcquaid","followers_url":"https://api.github.com/users/mikemcquaid/followers","following_url":"https://api.github.com/users/mikemcquaid/following{/other_user}","gists_url":"https://api.github.com/users/mikemcquaid/gists{/gist_id}","starred_url":"https://api.github.com/users/mikemcquaid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikemcquaid/subscriptions","organizations_url":"https://api.github.com/users/mikemcquaid/orgs","repos_url":"https://api.github.com/users/mikemcquaid/repos","events_url":"https://api.github.com/users/mikemcquaid/events{/privacy}","received_events_url":"https://api.github.com/users/mikemcquaid/received_events","type":"User","site_admin":true},"body":"Is there no `make install` we can use?","created_at":"2015-03-07T15:43:26Z","updated_at":"2015-03-07T15:43:26Z","html_url":"https://github.com/Homebrew/homebrew/pull/37417#discussion_r25996881","pull_request_url":"https://api.github.com/repos/Homebrew/homebrew/pulls/37417","_links":{"self":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/comments/25996881"},"html":{"href":"https://github.com/Homebrew/homebrew/pull/37417#discussion_r25996881"},"pull_request":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/37417"}}},"pull_request":{"url":"https://api.github.com/repos/Homebrew/homebrew/pulls/37417","id":30550879,"html_url":"https://github.com/Homebrew/homebrew/pull/37417","diff_url":"https://github.com/Homebrew/homebrew/pull/37417.diff","patch_url":"https://github.com/Homebrew/homebrew/pull/37417.patch","issue_url":"https://api.github.com/repos/Homebrew/homebrew/issues/37417","number":37417,"state":"open","locked":false,"title":"cppcheck: Fix --with-gui option","user":{"login":"aharrison24","id":717570,"avatar_url":"https://avatars.githubusercontent.com/u/717570?v=3","gravatar_id":"","url":"https://api.github.com/users/aharrison24","html_url":"https://github.com/aharrison24","followers_url":"https://api.github.com/users/aharrison24/followers","following_url":"https://api.github.com/users/aharrison24/following{/other_user}","gists_url":"https://api.github.com/users/aharrison24/gists{/gist_id}","starred_url":"https://api.github.com/users/aharrison24/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aharrison24/subscriptions","organizations_url":"https://api.github.com/users/aharrison24/orgs","repos_url":"https://api.github.com/users/aharrison24/repos","events_url":"https://api.github.com/users/aharrison24/events{/privacy}","received_events_url":"https://api.github.com/users/aharrison24/received_events","type":"User","site_admin":false},"body":"- In 1.68, gui.qrc no longer references a cfg dir, so removed the\r\n  previously-required inreplace.\r\n- The QT build now requires HAVE_RULES to be explicitly enabled, so\r\n  added that to the qmake invocation.\r\n- Fixed a clang compile error caused by ambiguous closing template angle\r\n  brackets.  This fix is already in upstream’s master branch.\r\n- Made sure QT project builds in C++11 mode when using clang.  This fix\r\n  is taken from upstream’s master branch.\r\n- Caused .app to be installed directly in the prefix dir, not the bin\r\n  dir - that was stopping ‘brew linkapps’ from working.","created_at":"2015-03-05T11:55:04Z","updated_at":"2015-03-07T15:43:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0cf0f96bed06f3304891646b036d0e0ffb76a532","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Homebrew/homebrew/pulls/37417/commits","review_comments_url":"https://api.github.com/repos/Homebrew/homebrew/pulls/37417/comments","review_comment_url":"https://api.github.com/repos/Homebrew/homebrew/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Homebrew/homebrew/issues/37417/comments","statuses_url":"https://api.github.com/repos/Homebrew/homebrew/statuses/f1d2bedfa2fa75c79a98b054c832d592aed557c5","head":{"label":"aharrison24:master","ref":"master","sha":"f1d2bedfa2fa75c79a98b054c832d592aed557c5","user":{"login":"aharrison24","id":717570,"avatar_url":"https://avatars.githubusercontent.com/u/717570?v=3","gravatar_id":"","url":"https://api.github.com/users/aharrison24","html_url":"https://github.com/aharrison24","followers_url":"https://api.github.com/users/aharrison24/followers","following_url":"https://api.github.com/users/aharrison24/following{/other_user}","gists_url":"https://api.github.com/users/aharrison24/gists{/gist_id}","starred_url":"https://api.github.com/users/aharrison24/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aharrison24/subscriptions","organizations_url":"https://api.github.com/users/aharrison24/orgs","repos_url":"https://api.github.com/users/aharrison24/repos","events_url":"https://api.github.com/users/aharrison24/events{/privacy}","received_events_url":"https://api.github.com/users/aharrison24/received_events","type":"User","site_admin":false},"repo":{"id":1587611,"name":"homebrew","full_name":"aharrison24/homebrew","owner":{"login":"aharrison24","id":717570,"avatar_url":"https://avatars.githubusercontent.com/u/717570?v=3","gravatar_id":"","url":"https://api.github.com/users/aharrison24","html_url":"https://github.com/aharrison24","followers_url":"https://api.github.com/users/aharrison24/followers","following_url":"https://api.github.com/users/aharrison24/following{/other_user}","gists_url":"https://api.github.com/users/aharrison24/gists{/gist_id}","starred_url":"https://api.github.com/users/aharrison24/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aharrison24/subscriptions","organizations_url":"https://api.github.com/users/aharrison24/orgs","repos_url":"https://api.github.com/users/aharrison24/repos","events_url":"https://api.github.com/users/aharrison24/events{/privacy}","received_events_url":"https://api.github.com/users/aharrison24/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aharrison24/homebrew","description":"The missing package manager for OS X.","fork":true,"url":"https://api.github.com/repos/aharrison24/homebrew","forks_url":"https://api.github.com/repos/aharrison24/homebrew/forks","keys_url":"https://api.github.com/repos/aharrison24/homebrew/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aharrison24/homebrew/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aharrison24/homebrew/teams","hooks_url":"https://api.github.com/repos/aharrison24/homebrew/hooks","issue_events_url":"https://api.github.com/repos/aharrison24/homebrew/issues/events{/number}","events_url":"https://api.github.com/repos/aharrison24/homebrew/events","assignees_url":"https://api.github.com/repos/aharrison24/homebrew/assignees{/user}","branches_url":"https://api.github.com/repos/aharrison24/homebrew/branches{/branch}","tags_url":"https://api.github.com/repos/aharrison24/homebrew/tags","blobs_url":"https://api.github.com/repos/aharrison24/homebrew/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aharrison24/homebrew/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aharrison24/homebrew/git/refs{/sha}","trees_url":"https://api.github.com/repos/aharrison24/homebrew/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aharrison24/homebrew/statuses/{sha}","languages_url":"https://api.github.com/repos/aharrison24/homebrew/languages","stargazers_url":"https://api.github.com/repos/aharrison24/homebrew/stargazers","contributors_url":"https://api.github.com/repos/aharrison24/homebrew/contributors","subscribers_url":"https://api.github.com/repos/aharrison24/homebrew/subscribers","subscription_url":"https://api.github.com/repos/aharrison24/homebrew/subscription","commits_url":"https://api.github.com/repos/aharrison24/homebrew/commits{/sha}","git_commits_url":"https://api.github.com/repos/aharrison24/homebrew/git/commits{/sha}","comments_url":"https://api.github.com/repos/aharrison24/homebrew/comments{/number}","issue_comment_url":"https://api.github.com/repos/aharrison24/homebrew/issues/comments{/number}","contents_url":"https://api.github.com/repos/aharrison24/homebrew/contents/{+path}","compare_url":"https://api.github.com/repos/aharrison24/homebrew/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aharrison24/homebrew/merges","archive_url":"https://api.github.com/repos/aharrison24/homebrew/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aharrison24/homebrew/downloads","issues_url":"https://api.github.com/repos/aharrison24/homebrew/issues{/number}","pulls_url":"https://api.github.com/repos/aharrison24/homebrew/pulls{/number}","milestones_url":"https://api.github.com/repos/aharrison24/homebrew/milestones{/number}","notifications_url":"https://api.github.com/repos/aharrison24/homebrew/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aharrison24/homebrew/labels{/name}","releases_url":"https://api.github.com/repos/aharrison24/homebrew/releases{/id}","created_at":"2011-04-08T14:40:10Z","updated_at":"2015-03-07T15:14:12Z","pushed_at":"2015-03-07T15:14:08Z","git_url":"git://github.com/aharrison24/homebrew.git","ssh_url":"git@github.com:aharrison24/homebrew.git","clone_url":"https://github.com/aharrison24/homebrew.git","svn_url":"https://github.com/aharrison24/homebrew","homepage":"http://mxcl.github.com/homebrew","size":7175,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Homebrew:master","ref":"master","sha":"ac4e21396aa4fa555af69b978f6e5a9feea04cdd","user":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars.githubusercontent.com/u/1503512?v=3","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"repo":{"id":206084,"name":"homebrew","full_name":"Homebrew/homebrew","owner":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars.githubusercontent.com/u/1503512?v=3","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Homebrew/homebrew","description":"The missing package manager for OS X.","fork":false,"url":"https://api.github.com/repos/Homebrew/homebrew","forks_url":"https://api.github.com/repos/Homebrew/homebrew/forks","keys_url":"https://api.github.com/repos/Homebrew/homebrew/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Homebrew/homebrew/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Homebrew/homebrew/teams","hooks_url":"https://api.github.com/repos/Homebrew/homebrew/hooks","issue_events_url":"https://api.github.com/repos/Homebrew/homebrew/issues/events{/number}","events_url":"https://api.github.com/repos/Homebrew/homebrew/events","assignees_url":"https://api.github.com/repos/Homebrew/homebrew/assignees{/user}","branches_url":"https://api.github.com/repos/Homebrew/homebrew/branches{/branch}","tags_url":"https://api.github.com/repos/Homebrew/homebrew/tags","blobs_url":"https://api.github.com/repos/Homebrew/homebrew/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Homebrew/homebrew/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Homebrew/homebrew/git/refs{/sha}","trees_url":"https://api.github.com/repos/Homebrew/homebrew/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Homebrew/homebrew/statuses/{sha}","languages_url":"https://api.github.com/repos/Homebrew/homebrew/languages","stargazers_url":"https://api.github.com/repos/Homebrew/homebrew/stargazers","contributors_url":"https://api.github.com/repos/Homebrew/homebrew/contributors","subscribers_url":"https://api.github.com/repos/Homebrew/homebrew/subscribers","subscription_url":"https://api.github.com/repos/Homebrew/homebrew/subscription","commits_url":"https://api.github.com/repos/Homebrew/homebrew/commits{/sha}","git_commits_url":"https://api.github.com/repos/Homebrew/homebrew/git/commits{/sha}","comments_url":"https://api.github.com/repos/Homebrew/homebrew/comments{/number}","issue_comment_url":"https://api.github.com/repos/Homebrew/homebrew/issues/comments{/number}","contents_url":"https://api.github.com/repos/Homebrew/homebrew/contents/{+path}","compare_url":"https://api.github.com/repos/Homebrew/homebrew/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Homebrew/homebrew/merges","archive_url":"https://api.github.com/repos/Homebrew/homebrew/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Homebrew/homebrew/downloads","issues_url":"https://api.github.com/repos/Homebrew/homebrew/issues{/number}","pulls_url":"https://api.github.com/repos/Homebrew/homebrew/pulls{/number}","milestones_url":"https://api.github.com/repos/Homebrew/homebrew/milestones{/number}","notifications_url":"https://api.github.com/repos/Homebrew/homebrew/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Homebrew/homebrew/labels{/name}","releases_url":"https://api.github.com/repos/Homebrew/homebrew/releases{/id}","created_at":"2009-05-20T19:38:37Z","updated_at":"2015-03-07T15:34:42Z","pushed_at":"2015-03-07T13:45:28Z","git_url":"git://github.com/Homebrew/homebrew.git","ssh_url":"git@github.com:Homebrew/homebrew.git","clone_url":"https://github.com/Homebrew/homebrew.git","svn_url":"https://github.com/Homebrew/homebrew","homepage":"http://brew.sh","size":1453002,"stargazers_count":21764,"watchers_count":21764,"language":"Ruby","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":10872,"mirror_url":null,"open_issues_count":337,"forks":10872,"open_issues":337,"watchers":21764,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/37417"},"html":{"href":"https://github.com/Homebrew/homebrew/pull/37417"},"issue":{"href":"https://api.github.com/repos/Homebrew/homebrew/issues/37417"},"comments":{"href":"https://api.github.com/repos/Homebrew/homebrew/issues/37417/comments"},"review_comments":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/37417/comments"},"review_comment":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/37417/commits"},"statuses":{"href":"https://api.github.com/repos/Homebrew/homebrew/statuses/f1d2bedfa2fa75c79a98b054c832d592aed557c5"}}}}