{"action":"created","comment":{"url":"https://api.github.com/repos/clappr/clappr/pulls/comments/37363156","id":37363156,"diff_hunk":"@@ -56,11 +62,8 @@ export default class SeekTime extends UIObject {\n   }\n \n   update(options) {\n-    if (this.mediaControl.container.settings.seekEnabled) {\n-      this.$el.find('[data-seek-time]').text(options.formattedTime)\n-      this.$el.css('left', Math.max(0, options.pointerPosition - (this.$el.width() / 2)))\n-      this.$el.removeClass('hidden')\n-    }\n+    this.$el.find('[data-seek-time]').text(options.formattedTime)\n+    this.$el.css('left', Math.max(0, options.pointerPosition - (this.$el.width() / 2)))","path":"src/components/seek_time/seek_time.js","position":23,"original_position":23,"commit_id":"256b62f3171b2cee17828d2f726080740ef1dfcc","original_commit_id":"256b62f3171b2cee17828d2f726080740ef1dfcc","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Line is too long.","created_at":"2015-08-18T22:47:25Z","updated_at":"2015-08-18T22:47:25Z","html_url":"https://github.com/clappr/clappr/pull/525#discussion_r37363156","pull_request_url":"https://api.github.com/repos/clappr/clappr/pulls/525","_links":{"self":{"href":"https://api.github.com/repos/clappr/clappr/pulls/comments/37363156"},"html":{"href":"https://github.com/clappr/clappr/pull/525#discussion_r37363156"},"pull_request":{"href":"https://api.github.com/repos/clappr/clappr/pulls/525"}}},"pull_request":{"url":"https://api.github.com/repos/clappr/clappr/pulls/525","id":42758209,"html_url":"https://github.com/clappr/clappr/pull/525","diff_url":"https://github.com/clappr/clappr/pull/525.diff","patch_url":"https://github.com/clappr/clappr/pull/525.patch","issue_url":"https://api.github.com/repos/clappr/clappr/issues/525","number":525,"state":"open","locked":false,"title":"Fix so that seek time doesn't flicker when hovering","user":{"login":"tjenkinson","id":3259993,"avatar_url":"https://avatars.githubusercontent.com/u/3259993?v=3","gravatar_id":"","url":"https://api.github.com/users/tjenkinson","html_url":"https://github.com/tjenkinson","followers_url":"https://api.github.com/users/tjenkinson/followers","following_url":"https://api.github.com/users/tjenkinson/following{/other_user}","gists_url":"https://api.github.com/users/tjenkinson/gists{/gist_id}","starred_url":"https://api.github.com/users/tjenkinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tjenkinson/subscriptions","organizations_url":"https://api.github.com/users/tjenkinson/orgs","repos_url":"https://api.github.com/users/tjenkinson/repos","events_url":"https://api.github.com/users/tjenkinson/events{/privacy}","received_events_url":"https://api.github.com/users/tjenkinson/received_events","type":"User","site_admin":false},"body":"Previously the `showTime` and `update` methods both queried `$el` for it's width, but if `$el` wasn't visible its width would be reported as 0 by the browser, resulting in the time then being shown in the wrong place. This change ensures that the element is always visible before the width queries are made, and prevents the time jumping left and right when hovering.\r\n\r\nThis also makes sure it doesn't wrap onto 2 lines when it reaches the far right of the player. Previously if it did wrap this would also cause the width to change and it would get a bit confused.\r\n\r\nAlso the previous code didn't, and this change currently doesn't listen to see if the `this.mediaControl.container.settings.seekEnabled` option changes, and then update appropriately. E.g. the user is hovering over the bar whilst `seekEnabled` is `true`, and then it flips to `false`. The time will still be visible until the cursor is moved. The reverse behaviour can happen when a HLS stream becomes longer than the minimum duration to DVR, causing DVR to become enabled.\r\n\r\nIs there an event that is fired when settings change? If so I can have a look at adding this functionality in as well if you'd like?\r\n","created_at":"2015-08-18T22:45:06Z","updated_at":"2015-08-18T22:47:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"25e05f63b77ea72039e412984e64b52a1e2c3863","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/clappr/clappr/pulls/525/commits","review_comments_url":"https://api.github.com/repos/clappr/clappr/pulls/525/comments","review_comment_url":"https://api.github.com/repos/clappr/clappr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/clappr/clappr/issues/525/comments","statuses_url":"https://api.github.com/repos/clappr/clappr/statuses/256b62f3171b2cee17828d2f726080740ef1dfcc","head":{"label":"tjenkinson:seek-time-fix","ref":"seek-time-fix","sha":"256b62f3171b2cee17828d2f726080740ef1dfcc","user":{"login":"tjenkinson","id":3259993,"avatar_url":"https://avatars.githubusercontent.com/u/3259993?v=3","gravatar_id":"","url":"https://api.github.com/users/tjenkinson","html_url":"https://github.com/tjenkinson","followers_url":"https://api.github.com/users/tjenkinson/followers","following_url":"https://api.github.com/users/tjenkinson/following{/other_user}","gists_url":"https://api.github.com/users/tjenkinson/gists{/gist_id}","starred_url":"https://api.github.com/users/tjenkinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tjenkinson/subscriptions","organizations_url":"https://api.github.com/users/tjenkinson/orgs","repos_url":"https://api.github.com/users/tjenkinson/repos","events_url":"https://api.github.com/users/tjenkinson/events{/privacy}","received_events_url":"https://api.github.com/users/tjenkinson/received_events","type":"User","site_admin":false},"repo":{"id":35844737,"name":"clappr","full_name":"tjenkinson/clappr","owner":{"login":"tjenkinson","id":3259993,"avatar_url":"https://avatars.githubusercontent.com/u/3259993?v=3","gravatar_id":"","url":"https://api.github.com/users/tjenkinson","html_url":"https://github.com/tjenkinson","followers_url":"https://api.github.com/users/tjenkinson/followers","following_url":"https://api.github.com/users/tjenkinson/following{/other_user}","gists_url":"https://api.github.com/users/tjenkinson/gists{/gist_id}","starred_url":"https://api.github.com/users/tjenkinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tjenkinson/subscriptions","organizations_url":"https://api.github.com/users/tjenkinson/orgs","repos_url":"https://api.github.com/users/tjenkinson/repos","events_url":"https://api.github.com/users/tjenkinson/events{/privacy}","received_events_url":"https://api.github.com/users/tjenkinson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tjenkinson/clappr","description":"An extensible media player for the web","fork":true,"url":"https://api.github.com/repos/tjenkinson/clappr","forks_url":"https://api.github.com/repos/tjenkinson/clappr/forks","keys_url":"https://api.github.com/repos/tjenkinson/clappr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tjenkinson/clappr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tjenkinson/clappr/teams","hooks_url":"https://api.github.com/repos/tjenkinson/clappr/hooks","issue_events_url":"https://api.github.com/repos/tjenkinson/clappr/issues/events{/number}","events_url":"https://api.github.com/repos/tjenkinson/clappr/events","assignees_url":"https://api.github.com/repos/tjenkinson/clappr/assignees{/user}","branches_url":"https://api.github.com/repos/tjenkinson/clappr/branches{/branch}","tags_url":"https://api.github.com/repos/tjenkinson/clappr/tags","blobs_url":"https://api.github.com/repos/tjenkinson/clappr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tjenkinson/clappr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tjenkinson/clappr/git/refs{/sha}","trees_url":"https://api.github.com/repos/tjenkinson/clappr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tjenkinson/clappr/statuses/{sha}","languages_url":"https://api.github.com/repos/tjenkinson/clappr/languages","stargazers_url":"https://api.github.com/repos/tjenkinson/clappr/stargazers","contributors_url":"https://api.github.com/repos/tjenkinson/clappr/contributors","subscribers_url":"https://api.github.com/repos/tjenkinson/clappr/subscribers","subscription_url":"https://api.github.com/repos/tjenkinson/clappr/subscription","commits_url":"https://api.github.com/repos/tjenkinson/clappr/commits{/sha}","git_commits_url":"https://api.github.com/repos/tjenkinson/clappr/git/commits{/sha}","comments_url":"https://api.github.com/repos/tjenkinson/clappr/comments{/number}","issue_comment_url":"https://api.github.com/repos/tjenkinson/clappr/issues/comments{/number}","contents_url":"https://api.github.com/repos/tjenkinson/clappr/contents/{+path}","compare_url":"https://api.github.com/repos/tjenkinson/clappr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tjenkinson/clappr/merges","archive_url":"https://api.github.com/repos/tjenkinson/clappr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tjenkinson/clappr/downloads","issues_url":"https://api.github.com/repos/tjenkinson/clappr/issues{/number}","pulls_url":"https://api.github.com/repos/tjenkinson/clappr/pulls{/number}","milestones_url":"https://api.github.com/repos/tjenkinson/clappr/milestones{/number}","notifications_url":"https://api.github.com/repos/tjenkinson/clappr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tjenkinson/clappr/labels{/name}","releases_url":"https://api.github.com/repos/tjenkinson/clappr/releases{/id}","created_at":"2015-05-18T21:56:29Z","updated_at":"2015-05-18T21:56:31Z","pushed_at":"2015-08-18T22:36:16Z","git_url":"git://github.com/tjenkinson/clappr.git","ssh_url":"git@github.com:tjenkinson/clappr.git","clone_url":"https://github.com/tjenkinson/clappr.git","svn_url":"https://github.com/tjenkinson/clappr","homepage":"http://clappr.io","size":10340,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"clappr:master","ref":"master","sha":"579cddb2715bb817fdf603f1ad6d812ce2f56174","user":{"login":"clappr","id":10685859,"avatar_url":"https://avatars.githubusercontent.com/u/10685859?v=3","gravatar_id":"","url":"https://api.github.com/users/clappr","html_url":"https://github.com/clappr","followers_url":"https://api.github.com/users/clappr/followers","following_url":"https://api.github.com/users/clappr/following{/other_user}","gists_url":"https://api.github.com/users/clappr/gists{/gist_id}","starred_url":"https://api.github.com/users/clappr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clappr/subscriptions","organizations_url":"https://api.github.com/users/clappr/orgs","repos_url":"https://api.github.com/users/clappr/repos","events_url":"https://api.github.com/users/clappr/events{/privacy}","received_events_url":"https://api.github.com/users/clappr/received_events","type":"Organization","site_admin":false},"repo":{"id":16844474,"name":"clappr","full_name":"clappr/clappr","owner":{"login":"clappr","id":10685859,"avatar_url":"https://avatars.githubusercontent.com/u/10685859?v=3","gravatar_id":"","url":"https://api.github.com/users/clappr","html_url":"https://github.com/clappr","followers_url":"https://api.github.com/users/clappr/followers","following_url":"https://api.github.com/users/clappr/following{/other_user}","gists_url":"https://api.github.com/users/clappr/gists{/gist_id}","starred_url":"https://api.github.com/users/clappr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clappr/subscriptions","organizations_url":"https://api.github.com/users/clappr/orgs","repos_url":"https://api.github.com/users/clappr/repos","events_url":"https://api.github.com/users/clappr/events{/privacy}","received_events_url":"https://api.github.com/users/clappr/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/clappr/clappr","description":"An extensible media player for the web","fork":false,"url":"https://api.github.com/repos/clappr/clappr","forks_url":"https://api.github.com/repos/clappr/clappr/forks","keys_url":"https://api.github.com/repos/clappr/clappr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/clappr/clappr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/clappr/clappr/teams","hooks_url":"https://api.github.com/repos/clappr/clappr/hooks","issue_events_url":"https://api.github.com/repos/clappr/clappr/issues/events{/number}","events_url":"https://api.github.com/repos/clappr/clappr/events","assignees_url":"https://api.github.com/repos/clappr/clappr/assignees{/user}","branches_url":"https://api.github.com/repos/clappr/clappr/branches{/branch}","tags_url":"https://api.github.com/repos/clappr/clappr/tags","blobs_url":"https://api.github.com/repos/clappr/clappr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/clappr/clappr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/clappr/clappr/git/refs{/sha}","trees_url":"https://api.github.com/repos/clappr/clappr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/clappr/clappr/statuses/{sha}","languages_url":"https://api.github.com/repos/clappr/clappr/languages","stargazers_url":"https://api.github.com/repos/clappr/clappr/stargazers","contributors_url":"https://api.github.com/repos/clappr/clappr/contributors","subscribers_url":"https://api.github.com/repos/clappr/clappr/subscribers","subscription_url":"https://api.github.com/repos/clappr/clappr/subscription","commits_url":"https://api.github.com/repos/clappr/clappr/commits{/sha}","git_commits_url":"https://api.github.com/repos/clappr/clappr/git/commits{/sha}","comments_url":"https://api.github.com/repos/clappr/clappr/comments{/number}","issue_comment_url":"https://api.github.com/repos/clappr/clappr/issues/comments{/number}","contents_url":"https://api.github.com/repos/clappr/clappr/contents/{+path}","compare_url":"https://api.github.com/repos/clappr/clappr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/clappr/clappr/merges","archive_url":"https://api.github.com/repos/clappr/clappr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/clappr/clappr/downloads","issues_url":"https://api.github.com/repos/clappr/clappr/issues{/number}","pulls_url":"https://api.github.com/repos/clappr/clappr/pulls{/number}","milestones_url":"https://api.github.com/repos/clappr/clappr/milestones{/number}","notifications_url":"https://api.github.com/repos/clappr/clappr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/clappr/clappr/labels{/name}","releases_url":"https://api.github.com/repos/clappr/clappr/releases{/id}","created_at":"2014-02-14T17:36:40Z","updated_at":"2015-08-17T16:31:43Z","pushed_at":"2015-08-18T22:45:08Z","git_url":"git://github.com/clappr/clappr.git","ssh_url":"git@github.com:clappr/clappr.git","clone_url":"https://github.com/clappr/clappr.git","svn_url":"https://github.com/clappr/clappr","homepage":"http://clappr.io","size":98681,"stargazers_count":2329,"watchers_count":2329,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":201,"mirror_url":null,"open_issues_count":36,"forks":201,"open_issues":36,"watchers":2329,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/clappr/clappr/pulls/525"},"html":{"href":"https://github.com/clappr/clappr/pull/525"},"issue":{"href":"https://api.github.com/repos/clappr/clappr/issues/525"},"comments":{"href":"https://api.github.com/repos/clappr/clappr/issues/525/comments"},"review_comments":{"href":"https://api.github.com/repos/clappr/clappr/pulls/525/comments"},"review_comment":{"href":"https://api.github.com/repos/clappr/clappr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/clappr/clappr/pulls/525/commits"},"statuses":{"href":"https://api.github.com/repos/clappr/clappr/statuses/256b62f3171b2cee17828d2f726080740ef1dfcc"}}}}