{"action":"created","issue":{"url":"https://api.github.com/repos/magnumripper/JohnTheRipper/issues/1249","labels_url":"https://api.github.com/repos/magnumripper/JohnTheRipper/issues/1249/labels{/name}","comments_url":"https://api.github.com/repos/magnumripper/JohnTheRipper/issues/1249/comments","events_url":"https://api.github.com/repos/magnumripper/JohnTheRipper/issues/1249/events","html_url":"https://github.com/magnumripper/JohnTheRipper/pull/1249","id":72441594,"number":1249,"title":"MainProcess forward sigint/sigterm to children.","user":{"login":"math07","id":9955284,"avatar_url":"https://avatars.githubusercontent.com/u/9955284?v=3","gravatar_id":"","url":"https://api.github.com/users/math07","html_url":"https://github.com/math07","followers_url":"https://api.github.com/users/math07/followers","following_url":"https://api.github.com/users/math07/following{/other_user}","gists_url":"https://api.github.com/users/math07/gists{/gist_id}","starred_url":"https://api.github.com/users/math07/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/math07/subscriptions","organizations_url":"https://api.github.com/users/math07/orgs","repos_url":"https://api.github.com/users/math07/repos","events_url":"https://api.github.com/users/math07/events{/privacy}","received_events_url":"https://api.github.com/users/math07/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-05-01T14:20:17Z","updated_at":"2015-05-03T22:36:04Z","closed_at":"2015-05-01T16:31:58Z","pull_request":{"url":"https://api.github.com/repos/magnumripper/JohnTheRipper/pulls/1249","html_url":"https://github.com/magnumripper/JohnTheRipper/pull/1249","diff_url":"https://github.com/magnumripper/JohnTheRipper/pull/1249.diff","patch_url":"https://github.com/magnumripper/JohnTheRipper/pull/1249.patch"},"body":"When I started doing the --fork option on Johnny, it seems to me that John only kills its children when ascii code 3 ( CTRL-c) or 'q'. is pushed on the keyboard, not with signals. I looked at the code in \"signal.c\" of JtR and it seems to be consistent with my tests. So now when main process receive sigterm/sigint, I forward it to its children.\r\n\r\nIf you want more details, here are the most important messages on the list where Shinnok, Frank and me talked about it:\r\nhttp://www.openwall.com/lists/john-dev/2015/04/28/16\r\nhttp://www.openwall.com/lists/john-dev/2015/04/30/4\r\nhttp://www.openwall.com/lists/john-dev/2015/04/30/5\r\nhttp://www.openwall.com/lists/john-dev/2015/04/30/6\r\n\r\nI tested it but I'm not a john pro yet so I'm not sure to know if placing the forwarding at that place doesn't have unwished behaviour. So I'll take your comments."},"comment":{"url":"https://api.github.com/repos/magnumripper/JohnTheRipper/issues/comments/98552389","html_url":"https://github.com/magnumripper/JohnTheRipper/pull/1249#issuecomment-98552389","issue_url":"https://api.github.com/repos/magnumripper/JohnTheRipper/issues/1249","id":98552389,"user":{"login":"magnumripper","id":1268598,"avatar_url":"https://avatars.githubusercontent.com/u/1268598?v=3","gravatar_id":"","url":"https://api.github.com/users/magnumripper","html_url":"https://github.com/magnumripper","followers_url":"https://api.github.com/users/magnumripper/followers","following_url":"https://api.github.com/users/magnumripper/following{/other_user}","gists_url":"https://api.github.com/users/magnumripper/gists{/gist_id}","starred_url":"https://api.github.com/users/magnumripper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magnumripper/subscriptions","organizations_url":"https://api.github.com/users/magnumripper/orgs","repos_url":"https://api.github.com/users/magnumripper/repos","events_url":"https://api.github.com/users/magnumripper/events{/privacy}","received_events_url":"https://api.github.com/users/magnumripper/received_events","type":"User","site_admin":false},"created_at":"2015-05-03T22:36:04Z","updated_at":"2015-05-03T22:36:04Z","body":"OK, will merge when I get the time."}}