{"action":"created","comment":{"url":"https://api.github.com/repos/kellydunn/golang-geo/pulls/comments/28655470","id":28655470,"diff_hunk":"@@ -115,8 +134,13 @@ func (g *OpenCageGeocoder) ReverseGeocode(p *Point) (string, error) {\n // Return sthe first address in the passed in byte array.\n func (g *OpenCageGeocoder) extractAddressFromResponse(data []byte) string {\n \tres := &opencageGeocodeResponse{}\n-\tjson.Unmarshal(data, &res)\n+\tif err :=  json.Unmarshal(data, &res) ; err != nil {\n+        panic(err)\n+    }","path":"opencage_geocoder.go","position":76,"original_position":76,"commit_id":"bf40d44b267c54a56045471a6e0f91e39499bcc0","original_commit_id":"bf40d44b267c54a56045471a6e0f91e39499bcc0","user":{"login":"kellydunn","id":116621,"avatar_url":"https://avatars.githubusercontent.com/u/116621?v=3","gravatar_id":"","url":"https://api.github.com/users/kellydunn","html_url":"https://github.com/kellydunn","followers_url":"https://api.github.com/users/kellydunn/followers","following_url":"https://api.github.com/users/kellydunn/following{/other_user}","gists_url":"https://api.github.com/users/kellydunn/gists{/gist_id}","starred_url":"https://api.github.com/users/kellydunn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kellydunn/subscriptions","organizations_url":"https://api.github.com/users/kellydunn/orgs","repos_url":"https://api.github.com/users/kellydunn/repos","events_url":"https://api.github.com/users/kellydunn/events{/privacy}","received_events_url":"https://api.github.com/users/kellydunn/received_events","type":"User","site_admin":false},"body":"It looks like a `panic` was added here?  You mentioned in your Pull Request that you were removing a `panic`?\r\n\r\nFor what it's worth, the [GoogleGeocoder equivalent](https://github.com/zingbats/golang-geo/blob/dont_panic/google_geocoder.go#L134-L147) is returning `(string, error)` instead of just a `string`.  I think that's a good model to follow here, as well.","created_at":"2015-04-19T18:47:51Z","updated_at":"2015-04-19T18:47:51Z","html_url":"https://github.com/kellydunn/golang-geo/pull/36#discussion_r28655470","pull_request_url":"https://api.github.com/repos/kellydunn/golang-geo/pulls/36","_links":{"self":{"href":"https://api.github.com/repos/kellydunn/golang-geo/pulls/comments/28655470"},"html":{"href":"https://github.com/kellydunn/golang-geo/pull/36#discussion_r28655470"},"pull_request":{"href":"https://api.github.com/repos/kellydunn/golang-geo/pulls/36"}}},"pull_request":{"url":"https://api.github.com/repos/kellydunn/golang-geo/pulls/36","id":33613277,"html_url":"https://github.com/kellydunn/golang-geo/pull/36","diff_url":"https://github.com/kellydunn/golang-geo/pull/36.diff","patch_url":"https://github.com/kellydunn/golang-geo/pull/36.patch","issue_url":"https://api.github.com/repos/kellydunn/golang-geo/issues/36","number":36,"state":"open","locked":false,"title":"Dont panic","user":{"login":"zingbats","id":1696454,"avatar_url":"https://avatars.githubusercontent.com/u/1696454?v=3","gravatar_id":"","url":"https://api.github.com/users/zingbats","html_url":"https://github.com/zingbats","followers_url":"https://api.github.com/users/zingbats/followers","following_url":"https://api.github.com/users/zingbats/following{/other_user}","gists_url":"https://api.github.com/users/zingbats/gists{/gist_id}","starred_url":"https://api.github.com/users/zingbats/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zingbats/subscriptions","organizations_url":"https://api.github.com/users/zingbats/orgs","repos_url":"https://api.github.com/users/zingbats/repos","events_url":"https://api.github.com/users/zingbats/events{/privacy}","received_events_url":"https://api.github.com/users/zingbats/received_events","type":"User","site_admin":false},"body":"For OpenCage and Mapquest, if any error occurs in Request() this would panic and crash the program. This is a bit too drastic for production code. Changed to do what the google api version of Request() does, which is return nil. Now the behavior is consistent across all services. ","created_at":"2015-04-19T04:13:06Z","updated_at":"2015-04-19T18:47:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"903128dda7c01b1f1be2d9d9d9e1d062437104cd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/kellydunn/golang-geo/pulls/36/commits","review_comments_url":"https://api.github.com/repos/kellydunn/golang-geo/pulls/36/comments","review_comment_url":"https://api.github.com/repos/kellydunn/golang-geo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kellydunn/golang-geo/issues/36/comments","statuses_url":"https://api.github.com/repos/kellydunn/golang-geo/statuses/bf40d44b267c54a56045471a6e0f91e39499bcc0","head":{"label":"zingbats:dont_panic","ref":"dont_panic","sha":"bf40d44b267c54a56045471a6e0f91e39499bcc0","user":{"login":"zingbats","id":1696454,"avatar_url":"https://avatars.githubusercontent.com/u/1696454?v=3","gravatar_id":"","url":"https://api.github.com/users/zingbats","html_url":"https://github.com/zingbats","followers_url":"https://api.github.com/users/zingbats/followers","following_url":"https://api.github.com/users/zingbats/following{/other_user}","gists_url":"https://api.github.com/users/zingbats/gists{/gist_id}","starred_url":"https://api.github.com/users/zingbats/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zingbats/subscriptions","organizations_url":"https://api.github.com/users/zingbats/orgs","repos_url":"https://api.github.com/users/zingbats/repos","events_url":"https://api.github.com/users/zingbats/events{/privacy}","received_events_url":"https://api.github.com/users/zingbats/received_events","type":"User","site_admin":false},"repo":{"id":34186264,"name":"golang-geo","full_name":"zingbats/golang-geo","owner":{"login":"zingbats","id":1696454,"avatar_url":"https://avatars.githubusercontent.com/u/1696454?v=3","gravatar_id":"","url":"https://api.github.com/users/zingbats","html_url":"https://github.com/zingbats","followers_url":"https://api.github.com/users/zingbats/followers","following_url":"https://api.github.com/users/zingbats/following{/other_user}","gists_url":"https://api.github.com/users/zingbats/gists{/gist_id}","starred_url":"https://api.github.com/users/zingbats/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zingbats/subscriptions","organizations_url":"https://api.github.com/users/zingbats/orgs","repos_url":"https://api.github.com/users/zingbats/repos","events_url":"https://api.github.com/users/zingbats/events{/privacy}","received_events_url":"https://api.github.com/users/zingbats/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zingbats/golang-geo","description":"Geographical calculations in Go.","fork":true,"url":"https://api.github.com/repos/zingbats/golang-geo","forks_url":"https://api.github.com/repos/zingbats/golang-geo/forks","keys_url":"https://api.github.com/repos/zingbats/golang-geo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zingbats/golang-geo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zingbats/golang-geo/teams","hooks_url":"https://api.github.com/repos/zingbats/golang-geo/hooks","issue_events_url":"https://api.github.com/repos/zingbats/golang-geo/issues/events{/number}","events_url":"https://api.github.com/repos/zingbats/golang-geo/events","assignees_url":"https://api.github.com/repos/zingbats/golang-geo/assignees{/user}","branches_url":"https://api.github.com/repos/zingbats/golang-geo/branches{/branch}","tags_url":"https://api.github.com/repos/zingbats/golang-geo/tags","blobs_url":"https://api.github.com/repos/zingbats/golang-geo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zingbats/golang-geo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zingbats/golang-geo/git/refs{/sha}","trees_url":"https://api.github.com/repos/zingbats/golang-geo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zingbats/golang-geo/statuses/{sha}","languages_url":"https://api.github.com/repos/zingbats/golang-geo/languages","stargazers_url":"https://api.github.com/repos/zingbats/golang-geo/stargazers","contributors_url":"https://api.github.com/repos/zingbats/golang-geo/contributors","subscribers_url":"https://api.github.com/repos/zingbats/golang-geo/subscribers","subscription_url":"https://api.github.com/repos/zingbats/golang-geo/subscription","commits_url":"https://api.github.com/repos/zingbats/golang-geo/commits{/sha}","git_commits_url":"https://api.github.com/repos/zingbats/golang-geo/git/commits{/sha}","comments_url":"https://api.github.com/repos/zingbats/golang-geo/comments{/number}","issue_comment_url":"https://api.github.com/repos/zingbats/golang-geo/issues/comments{/number}","contents_url":"https://api.github.com/repos/zingbats/golang-geo/contents/{+path}","compare_url":"https://api.github.com/repos/zingbats/golang-geo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zingbats/golang-geo/merges","archive_url":"https://api.github.com/repos/zingbats/golang-geo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zingbats/golang-geo/downloads","issues_url":"https://api.github.com/repos/zingbats/golang-geo/issues{/number}","pulls_url":"https://api.github.com/repos/zingbats/golang-geo/pulls{/number}","milestones_url":"https://api.github.com/repos/zingbats/golang-geo/milestones{/number}","notifications_url":"https://api.github.com/repos/zingbats/golang-geo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zingbats/golang-geo/labels{/name}","releases_url":"https://api.github.com/repos/zingbats/golang-geo/releases{/id}","created_at":"2015-04-18T23:07:03Z","updated_at":"2015-04-18T23:07:05Z","pushed_at":"2015-04-19T04:11:18Z","git_url":"git://github.com/zingbats/golang-geo.git","ssh_url":"git@github.com:zingbats/golang-geo.git","clone_url":"https://github.com/zingbats/golang-geo.git","svn_url":"https://github.com/zingbats/golang-geo","homepage":"","size":1150,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"develop"}},"base":{"label":"kellydunn:develop","ref":"develop","sha":"061c1657e1ce92282bc290bce53753d4aa46d4f1","user":{"login":"kellydunn","id":116621,"avatar_url":"https://avatars.githubusercontent.com/u/116621?v=3","gravatar_id":"","url":"https://api.github.com/users/kellydunn","html_url":"https://github.com/kellydunn","followers_url":"https://api.github.com/users/kellydunn/followers","following_url":"https://api.github.com/users/kellydunn/following{/other_user}","gists_url":"https://api.github.com/users/kellydunn/gists{/gist_id}","starred_url":"https://api.github.com/users/kellydunn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kellydunn/subscriptions","organizations_url":"https://api.github.com/users/kellydunn/orgs","repos_url":"https://api.github.com/users/kellydunn/repos","events_url":"https://api.github.com/users/kellydunn/events{/privacy}","received_events_url":"https://api.github.com/users/kellydunn/received_events","type":"User","site_admin":false},"repo":{"id":8196033,"name":"golang-geo","full_name":"kellydunn/golang-geo","owner":{"login":"kellydunn","id":116621,"avatar_url":"https://avatars.githubusercontent.com/u/116621?v=3","gravatar_id":"","url":"https://api.github.com/users/kellydunn","html_url":"https://github.com/kellydunn","followers_url":"https://api.github.com/users/kellydunn/followers","following_url":"https://api.github.com/users/kellydunn/following{/other_user}","gists_url":"https://api.github.com/users/kellydunn/gists{/gist_id}","starred_url":"https://api.github.com/users/kellydunn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kellydunn/subscriptions","organizations_url":"https://api.github.com/users/kellydunn/orgs","repos_url":"https://api.github.com/users/kellydunn/repos","events_url":"https://api.github.com/users/kellydunn/events{/privacy}","received_events_url":"https://api.github.com/users/kellydunn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kellydunn/golang-geo","description":"Geographical calculations in Go.","fork":false,"url":"https://api.github.com/repos/kellydunn/golang-geo","forks_url":"https://api.github.com/repos/kellydunn/golang-geo/forks","keys_url":"https://api.github.com/repos/kellydunn/golang-geo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kellydunn/golang-geo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kellydunn/golang-geo/teams","hooks_url":"https://api.github.com/repos/kellydunn/golang-geo/hooks","issue_events_url":"https://api.github.com/repos/kellydunn/golang-geo/issues/events{/number}","events_url":"https://api.github.com/repos/kellydunn/golang-geo/events","assignees_url":"https://api.github.com/repos/kellydunn/golang-geo/assignees{/user}","branches_url":"https://api.github.com/repos/kellydunn/golang-geo/branches{/branch}","tags_url":"https://api.github.com/repos/kellydunn/golang-geo/tags","blobs_url":"https://api.github.com/repos/kellydunn/golang-geo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kellydunn/golang-geo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kellydunn/golang-geo/git/refs{/sha}","trees_url":"https://api.github.com/repos/kellydunn/golang-geo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kellydunn/golang-geo/statuses/{sha}","languages_url":"https://api.github.com/repos/kellydunn/golang-geo/languages","stargazers_url":"https://api.github.com/repos/kellydunn/golang-geo/stargazers","contributors_url":"https://api.github.com/repos/kellydunn/golang-geo/contributors","subscribers_url":"https://api.github.com/repos/kellydunn/golang-geo/subscribers","subscription_url":"https://api.github.com/repos/kellydunn/golang-geo/subscription","commits_url":"https://api.github.com/repos/kellydunn/golang-geo/commits{/sha}","git_commits_url":"https://api.github.com/repos/kellydunn/golang-geo/git/commits{/sha}","comments_url":"https://api.github.com/repos/kellydunn/golang-geo/comments{/number}","issue_comment_url":"https://api.github.com/repos/kellydunn/golang-geo/issues/comments{/number}","contents_url":"https://api.github.com/repos/kellydunn/golang-geo/contents/{+path}","compare_url":"https://api.github.com/repos/kellydunn/golang-geo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kellydunn/golang-geo/merges","archive_url":"https://api.github.com/repos/kellydunn/golang-geo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kellydunn/golang-geo/downloads","issues_url":"https://api.github.com/repos/kellydunn/golang-geo/issues{/number}","pulls_url":"https://api.github.com/repos/kellydunn/golang-geo/pulls{/number}","milestones_url":"https://api.github.com/repos/kellydunn/golang-geo/milestones{/number}","notifications_url":"https://api.github.com/repos/kellydunn/golang-geo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kellydunn/golang-geo/labels{/name}","releases_url":"https://api.github.com/repos/kellydunn/golang-geo/releases{/id}","created_at":"2013-02-14T08:29:23Z","updated_at":"2015-04-17T13:48:43Z","pushed_at":"2015-04-19T04:13:06Z","git_url":"git://github.com/kellydunn/golang-geo.git","ssh_url":"git@github.com:kellydunn/golang-geo.git","clone_url":"https://github.com/kellydunn/golang-geo.git","svn_url":"https://github.com/kellydunn/golang-geo","homepage":"","size":1150,"stargazers_count":179,"watchers_count":179,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":36,"mirror_url":null,"open_issues_count":4,"forks":36,"open_issues":4,"watchers":179,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/kellydunn/golang-geo/pulls/36"},"html":{"href":"https://github.com/kellydunn/golang-geo/pull/36"},"issue":{"href":"https://api.github.com/repos/kellydunn/golang-geo/issues/36"},"comments":{"href":"https://api.github.com/repos/kellydunn/golang-geo/issues/36/comments"},"review_comments":{"href":"https://api.github.com/repos/kellydunn/golang-geo/pulls/36/comments"},"review_comment":{"href":"https://api.github.com/repos/kellydunn/golang-geo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kellydunn/golang-geo/pulls/36/commits"},"statuses":{"href":"https://api.github.com/repos/kellydunn/golang-geo/statuses/bf40d44b267c54a56045471a6e0f91e39499bcc0"}}}}