{"action":"opened","number":38,"pull_request":{"url":"https://api.github.com/repos/leafgarland/typescript-vim/pulls/38","id":30710809,"html_url":"https://github.com/leafgarland/typescript-vim/pull/38","diff_url":"https://github.com/leafgarland/typescript-vim/pull/38.diff","patch_url":"https://github.com/leafgarland/typescript-vim/pull/38.patch","issue_url":"https://api.github.com/repos/leafgarland/typescript-vim/issues/38","number":38,"state":"open","locked":false,"title":"Fix (simplify) function highlighting and other improvements","user":{"login":"mcmaniac","id":92021,"avatar_url":"https://avatars.githubusercontent.com/u/92021?v=3","gravatar_id":"","url":"https://api.github.com/users/mcmaniac","html_url":"https://github.com/mcmaniac","followers_url":"https://api.github.com/users/mcmaniac/followers","following_url":"https://api.github.com/users/mcmaniac/following{/other_user}","gists_url":"https://api.github.com/users/mcmaniac/gists{/gist_id}","starred_url":"https://api.github.com/users/mcmaniac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcmaniac/subscriptions","organizations_url":"https://api.github.com/users/mcmaniac/orgs","repos_url":"https://api.github.com/users/mcmaniac/repos","events_url":"https://api.github.com/users/mcmaniac/events{/privacy}","received_events_url":"https://api.github.com/users/mcmaniac/received_events","type":"User","site_admin":false},"body":"Hi,\r\n\r\nI fixed a few issues I had with this plugin:\r\n\r\n * Syntax highlighting for function definitions was broken. Type annotations completly messed up the highlighting, the used colors were inconsistent with e.g. javascript function highlighting. I simplified it by removing (just commented out for now) the special `match` rules for functions and parameters and instead simply kept the `function` keyword. Should also fix #13.\r\n * Used `contained` on HTML element properties, ajax methods and others and used the `typeScriptDotNotation` rule for those. This used to mess up e.g. class method definitions with names like \"load\", \"send\" or \"id\". (Even though calling those methods will still trigger those highlighting rules – I'm not sure if they should be kept at all, but I could live with that.)\r\n * Changed some of the highlighting groups to be more consistent overall\r\n * Fixed indentation. `.ts` files by default are set to `filetype xml` in (stock) vim, which sets the `identexpr` variable, thus effectively preventing C indention for typescript files. (Might also be related to #23, but I never use tabs in my code so I can't reproduce this.)\r\n\r\nAnd some other minor fixes.","created_at":"2015-03-07T22:47:06Z","updated_at":"2015-03-07T22:47:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/leafgarland/typescript-vim/pulls/38/commits","review_comments_url":"https://api.github.com/repos/leafgarland/typescript-vim/pulls/38/comments","review_comment_url":"https://api.github.com/repos/leafgarland/typescript-vim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/leafgarland/typescript-vim/issues/38/comments","statuses_url":"https://api.github.com/repos/leafgarland/typescript-vim/statuses/fb986cf039496e11c08b2ccf713a9237500e9a27","head":{"label":"mcmaniac:master","ref":"master","sha":"fb986cf039496e11c08b2ccf713a9237500e9a27","user":{"login":"mcmaniac","id":92021,"avatar_url":"https://avatars.githubusercontent.com/u/92021?v=3","gravatar_id":"","url":"https://api.github.com/users/mcmaniac","html_url":"https://github.com/mcmaniac","followers_url":"https://api.github.com/users/mcmaniac/followers","following_url":"https://api.github.com/users/mcmaniac/following{/other_user}","gists_url":"https://api.github.com/users/mcmaniac/gists{/gist_id}","starred_url":"https://api.github.com/users/mcmaniac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcmaniac/subscriptions","organizations_url":"https://api.github.com/users/mcmaniac/orgs","repos_url":"https://api.github.com/users/mcmaniac/repos","events_url":"https://api.github.com/users/mcmaniac/events{/privacy}","received_events_url":"https://api.github.com/users/mcmaniac/received_events","type":"User","site_admin":false},"repo":{"id":31820906,"name":"typescript-vim","full_name":"mcmaniac/typescript-vim","owner":{"login":"mcmaniac","id":92021,"avatar_url":"https://avatars.githubusercontent.com/u/92021?v=3","gravatar_id":"","url":"https://api.github.com/users/mcmaniac","html_url":"https://github.com/mcmaniac","followers_url":"https://api.github.com/users/mcmaniac/followers","following_url":"https://api.github.com/users/mcmaniac/following{/other_user}","gists_url":"https://api.github.com/users/mcmaniac/gists{/gist_id}","starred_url":"https://api.github.com/users/mcmaniac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcmaniac/subscriptions","organizations_url":"https://api.github.com/users/mcmaniac/orgs","repos_url":"https://api.github.com/users/mcmaniac/repos","events_url":"https://api.github.com/users/mcmaniac/events{/privacy}","received_events_url":"https://api.github.com/users/mcmaniac/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mcmaniac/typescript-vim","description":"Typescript syntax files for Vim","fork":true,"url":"https://api.github.com/repos/mcmaniac/typescript-vim","forks_url":"https://api.github.com/repos/mcmaniac/typescript-vim/forks","keys_url":"https://api.github.com/repos/mcmaniac/typescript-vim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mcmaniac/typescript-vim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mcmaniac/typescript-vim/teams","hooks_url":"https://api.github.com/repos/mcmaniac/typescript-vim/hooks","issue_events_url":"https://api.github.com/repos/mcmaniac/typescript-vim/issues/events{/number}","events_url":"https://api.github.com/repos/mcmaniac/typescript-vim/events","assignees_url":"https://api.github.com/repos/mcmaniac/typescript-vim/assignees{/user}","branches_url":"https://api.github.com/repos/mcmaniac/typescript-vim/branches{/branch}","tags_url":"https://api.github.com/repos/mcmaniac/typescript-vim/tags","blobs_url":"https://api.github.com/repos/mcmaniac/typescript-vim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mcmaniac/typescript-vim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mcmaniac/typescript-vim/git/refs{/sha}","trees_url":"https://api.github.com/repos/mcmaniac/typescript-vim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mcmaniac/typescript-vim/statuses/{sha}","languages_url":"https://api.github.com/repos/mcmaniac/typescript-vim/languages","stargazers_url":"https://api.github.com/repos/mcmaniac/typescript-vim/stargazers","contributors_url":"https://api.github.com/repos/mcmaniac/typescript-vim/contributors","subscribers_url":"https://api.github.com/repos/mcmaniac/typescript-vim/subscribers","subscription_url":"https://api.github.com/repos/mcmaniac/typescript-vim/subscription","commits_url":"https://api.github.com/repos/mcmaniac/typescript-vim/commits{/sha}","git_commits_url":"https://api.github.com/repos/mcmaniac/typescript-vim/git/commits{/sha}","comments_url":"https://api.github.com/repos/mcmaniac/typescript-vim/comments{/number}","issue_comment_url":"https://api.github.com/repos/mcmaniac/typescript-vim/issues/comments{/number}","contents_url":"https://api.github.com/repos/mcmaniac/typescript-vim/contents/{+path}","compare_url":"https://api.github.com/repos/mcmaniac/typescript-vim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mcmaniac/typescript-vim/merges","archive_url":"https://api.github.com/repos/mcmaniac/typescript-vim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mcmaniac/typescript-vim/downloads","issues_url":"https://api.github.com/repos/mcmaniac/typescript-vim/issues{/number}","pulls_url":"https://api.github.com/repos/mcmaniac/typescript-vim/pulls{/number}","milestones_url":"https://api.github.com/repos/mcmaniac/typescript-vim/milestones{/number}","notifications_url":"https://api.github.com/repos/mcmaniac/typescript-vim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mcmaniac/typescript-vim/labels{/name}","releases_url":"https://api.github.com/repos/mcmaniac/typescript-vim/releases{/id}","created_at":"2015-03-07T17:37:39Z","updated_at":"2015-03-07T22:31:20Z","pushed_at":"2015-03-07T22:31:20Z","git_url":"git://github.com/mcmaniac/typescript-vim.git","ssh_url":"git@github.com:mcmaniac/typescript-vim.git","clone_url":"https://github.com/mcmaniac/typescript-vim.git","svn_url":"https://github.com/mcmaniac/typescript-vim","homepage":null,"size":127,"stargazers_count":0,"watchers_count":0,"language":"VimL","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"leafgarland:master","ref":"master","sha":"85ea0dc8cb07b299e3441146a434a809130c84be","user":{"login":"leafgarland","id":675335,"avatar_url":"https://avatars.githubusercontent.com/u/675335?v=3","gravatar_id":"","url":"https://api.github.com/users/leafgarland","html_url":"https://github.com/leafgarland","followers_url":"https://api.github.com/users/leafgarland/followers","following_url":"https://api.github.com/users/leafgarland/following{/other_user}","gists_url":"https://api.github.com/users/leafgarland/gists{/gist_id}","starred_url":"https://api.github.com/users/leafgarland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leafgarland/subscriptions","organizations_url":"https://api.github.com/users/leafgarland/orgs","repos_url":"https://api.github.com/users/leafgarland/repos","events_url":"https://api.github.com/users/leafgarland/events{/privacy}","received_events_url":"https://api.github.com/users/leafgarland/received_events","type":"User","site_admin":false},"repo":{"id":6044030,"name":"typescript-vim","full_name":"leafgarland/typescript-vim","owner":{"login":"leafgarland","id":675335,"avatar_url":"https://avatars.githubusercontent.com/u/675335?v=3","gravatar_id":"","url":"https://api.github.com/users/leafgarland","html_url":"https://github.com/leafgarland","followers_url":"https://api.github.com/users/leafgarland/followers","following_url":"https://api.github.com/users/leafgarland/following{/other_user}","gists_url":"https://api.github.com/users/leafgarland/gists{/gist_id}","starred_url":"https://api.github.com/users/leafgarland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leafgarland/subscriptions","organizations_url":"https://api.github.com/users/leafgarland/orgs","repos_url":"https://api.github.com/users/leafgarland/repos","events_url":"https://api.github.com/users/leafgarland/events{/privacy}","received_events_url":"https://api.github.com/users/leafgarland/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/leafgarland/typescript-vim","description":"Typescript syntax files for Vim","fork":false,"url":"https://api.github.com/repos/leafgarland/typescript-vim","forks_url":"https://api.github.com/repos/leafgarland/typescript-vim/forks","keys_url":"https://api.github.com/repos/leafgarland/typescript-vim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/leafgarland/typescript-vim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/leafgarland/typescript-vim/teams","hooks_url":"https://api.github.com/repos/leafgarland/typescript-vim/hooks","issue_events_url":"https://api.github.com/repos/leafgarland/typescript-vim/issues/events{/number}","events_url":"https://api.github.com/repos/leafgarland/typescript-vim/events","assignees_url":"https://api.github.com/repos/leafgarland/typescript-vim/assignees{/user}","branches_url":"https://api.github.com/repos/leafgarland/typescript-vim/branches{/branch}","tags_url":"https://api.github.com/repos/leafgarland/typescript-vim/tags","blobs_url":"https://api.github.com/repos/leafgarland/typescript-vim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/leafgarland/typescript-vim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/leafgarland/typescript-vim/git/refs{/sha}","trees_url":"https://api.github.com/repos/leafgarland/typescript-vim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/leafgarland/typescript-vim/statuses/{sha}","languages_url":"https://api.github.com/repos/leafgarland/typescript-vim/languages","stargazers_url":"https://api.github.com/repos/leafgarland/typescript-vim/stargazers","contributors_url":"https://api.github.com/repos/leafgarland/typescript-vim/contributors","subscribers_url":"https://api.github.com/repos/leafgarland/typescript-vim/subscribers","subscription_url":"https://api.github.com/repos/leafgarland/typescript-vim/subscription","commits_url":"https://api.github.com/repos/leafgarland/typescript-vim/commits{/sha}","git_commits_url":"https://api.github.com/repos/leafgarland/typescript-vim/git/commits{/sha}","comments_url":"https://api.github.com/repos/leafgarland/typescript-vim/comments{/number}","issue_comment_url":"https://api.github.com/repos/leafgarland/typescript-vim/issues/comments{/number}","contents_url":"https://api.github.com/repos/leafgarland/typescript-vim/contents/{+path}","compare_url":"https://api.github.com/repos/leafgarland/typescript-vim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/leafgarland/typescript-vim/merges","archive_url":"https://api.github.com/repos/leafgarland/typescript-vim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/leafgarland/typescript-vim/downloads","issues_url":"https://api.github.com/repos/leafgarland/typescript-vim/issues{/number}","pulls_url":"https://api.github.com/repos/leafgarland/typescript-vim/pulls{/number}","milestones_url":"https://api.github.com/repos/leafgarland/typescript-vim/milestones{/number}","notifications_url":"https://api.github.com/repos/leafgarland/typescript-vim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/leafgarland/typescript-vim/labels{/name}","releases_url":"https://api.github.com/repos/leafgarland/typescript-vim/releases{/id}","created_at":"2012-10-02T11:43:38Z","updated_at":"2015-03-06T16:58:40Z","pushed_at":"2015-02-05T03:48:53Z","git_url":"git://github.com/leafgarland/typescript-vim.git","ssh_url":"git@github.com:leafgarland/typescript-vim.git","clone_url":"https://github.com/leafgarland/typescript-vim.git","svn_url":"https://github.com/leafgarland/typescript-vim","homepage":null,"size":335,"stargazers_count":105,"watchers_count":105,"language":"VimL","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":32,"mirror_url":null,"open_issues_count":7,"forks":32,"open_issues":7,"watchers":105,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/leafgarland/typescript-vim/pulls/38"},"html":{"href":"https://github.com/leafgarland/typescript-vim/pull/38"},"issue":{"href":"https://api.github.com/repos/leafgarland/typescript-vim/issues/38"},"comments":{"href":"https://api.github.com/repos/leafgarland/typescript-vim/issues/38/comments"},"review_comments":{"href":"https://api.github.com/repos/leafgarland/typescript-vim/pulls/38/comments"},"review_comment":{"href":"https://api.github.com/repos/leafgarland/typescript-vim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/leafgarland/typescript-vim/pulls/38/commits"},"statuses":{"href":"https://api.github.com/repos/leafgarland/typescript-vim/statuses/fb986cf039496e11c08b2ccf713a9237500e9a27"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":7,"additions":80,"deletions":42,"changed_files":3}}