{"action":"created","comment":{"url":"https://api.github.com/repos/scanmem/scanmem/pulls/comments/29832372","id":29832372,"diff_hunk":"@@ -681,8 +681,10 @@ def bytes2value(self, typename, bytes):\n         if typename in TYPENAMES_G2STRUCT:\n             return struct.unpack(TYPENAMES_G2STRUCT[typename], bytes)[0]\n         elif typename == 'string':\n+            bytes = str(bytes.decode())","path":"gui/GameConqueror.py","position":4,"original_position":4,"commit_id":"3ddf468d3ff1bcf538b179adb70540e38f3acb1e","original_commit_id":"3ddf468d3ff1bcf538b179adb70540e38f3acb1e","user":{"login":"coolwanglu","id":734614,"avatar_url":"https://avatars.githubusercontent.com/u/734614?v=3","gravatar_id":"","url":"https://api.github.com/users/coolwanglu","html_url":"https://github.com/coolwanglu","followers_url":"https://api.github.com/users/coolwanglu/followers","following_url":"https://api.github.com/users/coolwanglu/following{/other_user}","gists_url":"https://api.github.com/users/coolwanglu/gists{/gist_id}","starred_url":"https://api.github.com/users/coolwanglu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coolwanglu/subscriptions","organizations_url":"https://api.github.com/users/coolwanglu/orgs","repos_url":"https://api.github.com/users/coolwanglu/repos","events_url":"https://api.github.com/users/coolwanglu/events{/privacy}","received_events_url":"https://api.github.com/users/coolwanglu/received_events","type":"User","site_admin":false},"body":"Looks good. Please use it.","created_at":"2015-05-07T08:17:58Z","updated_at":"2015-05-07T08:17:58Z","html_url":"https://github.com/scanmem/scanmem/pull/102#discussion_r29832372","pull_request_url":"https://api.github.com/repos/scanmem/scanmem/pulls/102","_links":{"self":{"href":"https://api.github.com/repos/scanmem/scanmem/pulls/comments/29832372"},"html":{"href":"https://github.com/scanmem/scanmem/pull/102#discussion_r29832372"},"pull_request":{"href":"https://api.github.com/repos/scanmem/scanmem/pulls/102"}}},"pull_request":{"url":"https://api.github.com/repos/scanmem/scanmem/pulls/102","id":34608336,"html_url":"https://github.com/scanmem/scanmem/pull/102","diff_url":"https://github.com/scanmem/scanmem/pull/102.diff","patch_url":"https://github.com/scanmem/scanmem/pull/102.patch","issue_url":"https://api.github.com/repos/scanmem/scanmem/issues/102","number":102,"state":"open","locked":false,"title":"gui: add support for string/bytearray search with Python 3","user":{"login":"sriemer","id":1803210,"avatar_url":"https://avatars.githubusercontent.com/u/1803210?v=3","gravatar_id":"","url":"https://api.github.com/users/sriemer","html_url":"https://github.com/sriemer","followers_url":"https://api.github.com/users/sriemer/followers","following_url":"https://api.github.com/users/sriemer/following{/other_user}","gists_url":"https://api.github.com/users/sriemer/gists{/gist_id}","starred_url":"https://api.github.com/users/sriemer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sriemer/subscriptions","organizations_url":"https://api.github.com/users/sriemer/orgs","repos_url":"https://api.github.com/users/sriemer/repos","events_url":"https://api.github.com/users/sriemer/events{/privacy}","received_events_url":"https://api.github.com/users/sriemer/received_events","type":"User","site_admin":false},"body":"Python 3 intentionally doesn't convert from bytes to unicode. This is why the search for string/bytearray freezes in GameConqueror and causes a debug message. So explicitly convert strings returned by scanmem as bytes to unicode.\r\n\r\nThis has been tested with Python 2.7 and 3.4 and is suitable for 0.15 stable.\r\n\r\nReported-by: calculuswhiz","created_at":"2015-05-03T21:42:57Z","updated_at":"2015-05-07T08:17:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"515f79bc22c5652ae6b2024c6c5ba653083554fd","assignee":{"login":"coolwanglu","id":734614,"avatar_url":"https://avatars.githubusercontent.com/u/734614?v=3","gravatar_id":"","url":"https://api.github.com/users/coolwanglu","html_url":"https://github.com/coolwanglu","followers_url":"https://api.github.com/users/coolwanglu/followers","following_url":"https://api.github.com/users/coolwanglu/following{/other_user}","gists_url":"https://api.github.com/users/coolwanglu/gists{/gist_id}","starred_url":"https://api.github.com/users/coolwanglu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coolwanglu/subscriptions","organizations_url":"https://api.github.com/users/coolwanglu/orgs","repos_url":"https://api.github.com/users/coolwanglu/repos","events_url":"https://api.github.com/users/coolwanglu/events{/privacy}","received_events_url":"https://api.github.com/users/coolwanglu/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/scanmem/scanmem/pulls/102/commits","review_comments_url":"https://api.github.com/repos/scanmem/scanmem/pulls/102/comments","review_comment_url":"https://api.github.com/repos/scanmem/scanmem/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scanmem/scanmem/issues/102/comments","statuses_url":"https://api.github.com/repos/scanmem/scanmem/statuses/3ddf468d3ff1bcf538b179adb70540e38f3acb1e","head":{"label":"sriemer:for-wanglu","ref":"for-wanglu","sha":"3ddf468d3ff1bcf538b179adb70540e38f3acb1e","user":{"login":"sriemer","id":1803210,"avatar_url":"https://avatars.githubusercontent.com/u/1803210?v=3","gravatar_id":"","url":"https://api.github.com/users/sriemer","html_url":"https://github.com/sriemer","followers_url":"https://api.github.com/users/sriemer/followers","following_url":"https://api.github.com/users/sriemer/following{/other_user}","gists_url":"https://api.github.com/users/sriemer/gists{/gist_id}","starred_url":"https://api.github.com/users/sriemer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sriemer/subscriptions","organizations_url":"https://api.github.com/users/sriemer/orgs","repos_url":"https://api.github.com/users/sriemer/repos","events_url":"https://api.github.com/users/sriemer/events{/privacy}","received_events_url":"https://api.github.com/users/sriemer/received_events","type":"User","site_admin":false},"repo":{"id":32619126,"name":"scanmem","full_name":"sriemer/scanmem","owner":{"login":"sriemer","id":1803210,"avatar_url":"https://avatars.githubusercontent.com/u/1803210?v=3","gravatar_id":"","url":"https://api.github.com/users/sriemer","html_url":"https://github.com/sriemer","followers_url":"https://api.github.com/users/sriemer/followers","following_url":"https://api.github.com/users/sriemer/following{/other_user}","gists_url":"https://api.github.com/users/sriemer/gists{/gist_id}","starred_url":"https://api.github.com/users/sriemer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sriemer/subscriptions","organizations_url":"https://api.github.com/users/sriemer/orgs","repos_url":"https://api.github.com/users/sriemer/repos","events_url":"https://api.github.com/users/sriemer/events{/privacy}","received_events_url":"https://api.github.com/users/sriemer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sriemer/scanmem","description":"Fork of scanmem for custom patches","fork":true,"url":"https://api.github.com/repos/sriemer/scanmem","forks_url":"https://api.github.com/repos/sriemer/scanmem/forks","keys_url":"https://api.github.com/repos/sriemer/scanmem/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sriemer/scanmem/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sriemer/scanmem/teams","hooks_url":"https://api.github.com/repos/sriemer/scanmem/hooks","issue_events_url":"https://api.github.com/repos/sriemer/scanmem/issues/events{/number}","events_url":"https://api.github.com/repos/sriemer/scanmem/events","assignees_url":"https://api.github.com/repos/sriemer/scanmem/assignees{/user}","branches_url":"https://api.github.com/repos/sriemer/scanmem/branches{/branch}","tags_url":"https://api.github.com/repos/sriemer/scanmem/tags","blobs_url":"https://api.github.com/repos/sriemer/scanmem/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sriemer/scanmem/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sriemer/scanmem/git/refs{/sha}","trees_url":"https://api.github.com/repos/sriemer/scanmem/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sriemer/scanmem/statuses/{sha}","languages_url":"https://api.github.com/repos/sriemer/scanmem/languages","stargazers_url":"https://api.github.com/repos/sriemer/scanmem/stargazers","contributors_url":"https://api.github.com/repos/sriemer/scanmem/contributors","subscribers_url":"https://api.github.com/repos/sriemer/scanmem/subscribers","subscription_url":"https://api.github.com/repos/sriemer/scanmem/subscription","commits_url":"https://api.github.com/repos/sriemer/scanmem/commits{/sha}","git_commits_url":"https://api.github.com/repos/sriemer/scanmem/git/commits{/sha}","comments_url":"https://api.github.com/repos/sriemer/scanmem/comments{/number}","issue_comment_url":"https://api.github.com/repos/sriemer/scanmem/issues/comments{/number}","contents_url":"https://api.github.com/repos/sriemer/scanmem/contents/{+path}","compare_url":"https://api.github.com/repos/sriemer/scanmem/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sriemer/scanmem/merges","archive_url":"https://api.github.com/repos/sriemer/scanmem/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sriemer/scanmem/downloads","issues_url":"https://api.github.com/repos/sriemer/scanmem/issues{/number}","pulls_url":"https://api.github.com/repos/sriemer/scanmem/pulls{/number}","milestones_url":"https://api.github.com/repos/sriemer/scanmem/milestones{/number}","notifications_url":"https://api.github.com/repos/sriemer/scanmem/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sriemer/scanmem/labels{/name}","releases_url":"https://api.github.com/repos/sriemer/scanmem/releases{/id}","created_at":"2015-03-21T03:53:41Z","updated_at":"2015-05-03T09:58:42Z","pushed_at":"2015-05-04T21:52:37Z","git_url":"git://github.com/sriemer/scanmem.git","ssh_url":"git@github.com:sriemer/scanmem.git","clone_url":"https://github.com/sriemer/scanmem.git","svn_url":"https://github.com/sriemer/scanmem","homepage":"https://github.com/scanmem/scanmem","size":1070,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"scanmem:master","ref":"master","sha":"a8fb9e2010a160de8b4fe9f989b63ce506cd2354","user":{"login":"scanmem","id":11469404,"avatar_url":"https://avatars.githubusercontent.com/u/11469404?v=3","gravatar_id":"","url":"https://api.github.com/users/scanmem","html_url":"https://github.com/scanmem","followers_url":"https://api.github.com/users/scanmem/followers","following_url":"https://api.github.com/users/scanmem/following{/other_user}","gists_url":"https://api.github.com/users/scanmem/gists{/gist_id}","starred_url":"https://api.github.com/users/scanmem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scanmem/subscriptions","organizations_url":"https://api.github.com/users/scanmem/orgs","repos_url":"https://api.github.com/users/scanmem/repos","events_url":"https://api.github.com/users/scanmem/events{/privacy}","received_events_url":"https://api.github.com/users/scanmem/received_events","type":"Organization","site_admin":false},"repo":{"id":32192995,"name":"scanmem","full_name":"scanmem/scanmem","owner":{"login":"scanmem","id":11469404,"avatar_url":"https://avatars.githubusercontent.com/u/11469404?v=3","gravatar_id":"","url":"https://api.github.com/users/scanmem","html_url":"https://github.com/scanmem","followers_url":"https://api.github.com/users/scanmem/followers","following_url":"https://api.github.com/users/scanmem/following{/other_user}","gists_url":"https://api.github.com/users/scanmem/gists{/gist_id}","starred_url":"https://api.github.com/users/scanmem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scanmem/subscriptions","organizations_url":"https://api.github.com/users/scanmem/orgs","repos_url":"https://api.github.com/users/scanmem/repos","events_url":"https://api.github.com/users/scanmem/events{/privacy}","received_events_url":"https://api.github.com/users/scanmem/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scanmem/scanmem","description":"memory scanner for Linux","fork":false,"url":"https://api.github.com/repos/scanmem/scanmem","forks_url":"https://api.github.com/repos/scanmem/scanmem/forks","keys_url":"https://api.github.com/repos/scanmem/scanmem/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scanmem/scanmem/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scanmem/scanmem/teams","hooks_url":"https://api.github.com/repos/scanmem/scanmem/hooks","issue_events_url":"https://api.github.com/repos/scanmem/scanmem/issues/events{/number}","events_url":"https://api.github.com/repos/scanmem/scanmem/events","assignees_url":"https://api.github.com/repos/scanmem/scanmem/assignees{/user}","branches_url":"https://api.github.com/repos/scanmem/scanmem/branches{/branch}","tags_url":"https://api.github.com/repos/scanmem/scanmem/tags","blobs_url":"https://api.github.com/repos/scanmem/scanmem/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scanmem/scanmem/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scanmem/scanmem/git/refs{/sha}","trees_url":"https://api.github.com/repos/scanmem/scanmem/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scanmem/scanmem/statuses/{sha}","languages_url":"https://api.github.com/repos/scanmem/scanmem/languages","stargazers_url":"https://api.github.com/repos/scanmem/scanmem/stargazers","contributors_url":"https://api.github.com/repos/scanmem/scanmem/contributors","subscribers_url":"https://api.github.com/repos/scanmem/scanmem/subscribers","subscription_url":"https://api.github.com/repos/scanmem/scanmem/subscription","commits_url":"https://api.github.com/repos/scanmem/scanmem/commits{/sha}","git_commits_url":"https://api.github.com/repos/scanmem/scanmem/git/commits{/sha}","comments_url":"https://api.github.com/repos/scanmem/scanmem/comments{/number}","issue_comment_url":"https://api.github.com/repos/scanmem/scanmem/issues/comments{/number}","contents_url":"https://api.github.com/repos/scanmem/scanmem/contents/{+path}","compare_url":"https://api.github.com/repos/scanmem/scanmem/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scanmem/scanmem/merges","archive_url":"https://api.github.com/repos/scanmem/scanmem/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scanmem/scanmem/downloads","issues_url":"https://api.github.com/repos/scanmem/scanmem/issues{/number}","pulls_url":"https://api.github.com/repos/scanmem/scanmem/pulls{/number}","milestones_url":"https://api.github.com/repos/scanmem/scanmem/milestones{/number}","notifications_url":"https://api.github.com/repos/scanmem/scanmem/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scanmem/scanmem/labels{/name}","releases_url":"https://api.github.com/repos/scanmem/scanmem/releases{/id}","created_at":"2015-03-14T02:53:21Z","updated_at":"2015-05-04T21:33:14Z","pushed_at":"2015-05-04T21:52:37Z","git_url":"git://github.com/scanmem/scanmem.git","ssh_url":"git@github.com:scanmem/scanmem.git","clone_url":"https://github.com/scanmem/scanmem.git","svn_url":"https://github.com/scanmem/scanmem","homepage":"https://github.com/scanmem/scanmem","size":1525,"stargazers_count":20,"watchers_count":20,"language":"C","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":7,"forks":6,"open_issues":7,"watchers":20,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scanmem/scanmem/pulls/102"},"html":{"href":"https://github.com/scanmem/scanmem/pull/102"},"issue":{"href":"https://api.github.com/repos/scanmem/scanmem/issues/102"},"comments":{"href":"https://api.github.com/repos/scanmem/scanmem/issues/102/comments"},"review_comments":{"href":"https://api.github.com/repos/scanmem/scanmem/pulls/102/comments"},"review_comment":{"href":"https://api.github.com/repos/scanmem/scanmem/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scanmem/scanmem/pulls/102/commits"},"statuses":{"href":"https://api.github.com/repos/scanmem/scanmem/statuses/3ddf468d3ff1bcf538b179adb70540e38f3acb1e"}}}}