{"action":"created","comment":{"url":"https://api.github.com/repos/google/ggrc-core/pulls/comments/33849614","id":33849614,"diff_hunk":"@@ -453,62 +452,62 @@\n     return options;\n   }\n \n-  $(function() {\n-    $('body').on('click', '[data-toggle=\"modal-relationship-selector\"]', function(e) {\n-      var $this = $(this)\n-        ;\n-\n-      e.preventDefault();\n-\n-      // Trigger the controller\n-      GGRC.Controllers.ModalSelector.launch(\n-        $this, get_relationship_option_set({\n-            related_model_singular: $this.data('related-model-singular')\n-          , related_title_singular: $this.data('related-title-singular')\n-          , related_title_plural: $this.data('related-title-plural')\n-          , related_table_plural: $this.data('related-table-plural')\n-          , related_table_singular: $this.data('related-table-singular')\n-          , related_side: $this.data('related-side')\n-          , related_model: $this.data('related-model')\n-          , join_object_id: $this.data('join-object-id')\n-          , join_object_type: $this.data('join-object-type')\n-          , object_side: $this.data('object-side')\n-          , relationship_type: $this.data('relationship-type')\n-          , join_query: $this.data('join-query')\n-        })).on(\"relationshipcreated relationshipdestroyed\", function(ev, data) {\n-          $this.trigger(\"modal:\" + ev.type, data);\n-        });\n-    });\n-  });\n-\n-  $(function() {\n-    $('body').on('click', '[data-toggle=\"modal-selector\"]', function(e) {\n-      var $this = $(this)\n-        , options = $this.data('modal-selector-options')\n-        , data_set = can.extend({}, $this.data())\n-        ;\n-\n-      can.each($this.data(), function(v, k) {\n-        data_set[k.replace(/[A-Z]/g, function(s) { return \"_\" + s.toLowerCase(); })] = v; //this is just a mapping of keys to underscored keys\n-        if(/[A-Z]/.test(k)) //if we haven't changed the key at all, don't delete the original\n-          delete data_set[k];\n-      });\n-\n-      if (typeof(options) === \"string\")\n-        options = get_option_set(\n-          options\n-          , data_set\n-        );\n-\n-      e.preventDefault();\n-\n-      // Trigger the controller\n-      GGRC.Controllers.ModalSelector.launch($this, options)\n-      .on(\"relationshipcreated relationshipdestroyed\", function(ev, data) {\n-        $this.trigger(\"modal:\" + ev.type, data);\n-      });\n-    });\n-  });\n+  // $(function() {","path":"src/ggrc/assets/javascripts/controllers/modal_selector_controller.js","position":88,"original_position":88,"commit_id":"211299fd1a4651726afa7eed401079d72d930e0c","original_commit_id":"211299fd1a4651726afa7eed401079d72d930e0c","user":{"login":"edofic","id":597476,"avatar_url":"https://avatars.githubusercontent.com/u/597476?v=3","gravatar_id":"","url":"https://api.github.com/users/edofic","html_url":"https://github.com/edofic","followers_url":"https://api.github.com/users/edofic/followers","following_url":"https://api.github.com/users/edofic/following{/other_user}","gists_url":"https://api.github.com/users/edofic/gists{/gist_id}","starred_url":"https://api.github.com/users/edofic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edofic/subscriptions","organizations_url":"https://api.github.com/users/edofic/orgs","repos_url":"https://api.github.com/users/edofic/repos","events_url":"https://api.github.com/users/edofic/events{/privacy}","received_events_url":"https://api.github.com/users/edofic/received_events","type":"User","site_admin":false},"body":"Do you have any particular reason to comment out this (and other following) code instead of deleting it?","created_at":"2015-07-03T09:01:00Z","updated_at":"2015-07-03T09:01:00Z","html_url":"https://github.com/google/ggrc-core/pull/2853#discussion_r33849614","pull_request_url":"https://api.github.com/repos/google/ggrc-core/pulls/2853","_links":{"self":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/comments/33849614"},"html":{"href":"https://github.com/google/ggrc-core/pull/2853#discussion_r33849614"},"pull_request":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/2853"}}},"pull_request":{"url":"https://api.github.com/repos/google/ggrc-core/pulls/2853","id":38984688,"html_url":"https://github.com/google/ggrc-core/pull/2853","diff_url":"https://github.com/google/ggrc-core/pull/2853.diff","patch_url":"https://github.com/google/ggrc-core/pull/2853.patch","issue_url":"https://api.github.com/repos/google/ggrc-core/issues/2853","number":2853,"state":"open","locked":false,"title":"CORE-1766 Unified mapper","user":{"login":"hyperNURb","id":59742,"avatar_url":"https://avatars.githubusercontent.com/u/59742?v=3","gravatar_id":"","url":"https://api.github.com/users/hyperNURb","html_url":"https://github.com/hyperNURb","followers_url":"https://api.github.com/users/hyperNURb/followers","following_url":"https://api.github.com/users/hyperNURb/following{/other_user}","gists_url":"https://api.github.com/users/hyperNURb/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperNURb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperNURb/subscriptions","organizations_url":"https://api.github.com/users/hyperNURb/orgs","repos_url":"https://api.github.com/users/hyperNURb/repos","events_url":"https://api.github.com/users/hyperNURb/events{/privacy}","received_events_url":"https://api.github.com/users/hyperNURb/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-07-01T13:59:37Z","updated_at":"2015-07-03T09:01:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a8fb8e2e9b6281488937e1ebee4a29d2c80cc801","assignee":null,"milestone":{"url":"https://api.github.com/repos/google/ggrc-core/milestones/14","html_url":"https://github.com/google/ggrc-core/milestones/0.9.4-Plum","labels_url":"https://api.github.com/repos/google/ggrc-core/milestones/14/labels","id":1055304,"number":14,"title":"0.9.4-Plum","description":"","creator":{"login":"Smotko","id":513444,"avatar_url":"https://avatars.githubusercontent.com/u/513444?v=3","gravatar_id":"","url":"https://api.github.com/users/Smotko","html_url":"https://github.com/Smotko","followers_url":"https://api.github.com/users/Smotko/followers","following_url":"https://api.github.com/users/Smotko/following{/other_user}","gists_url":"https://api.github.com/users/Smotko/gists{/gist_id}","starred_url":"https://api.github.com/users/Smotko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Smotko/subscriptions","organizations_url":"https://api.github.com/users/Smotko/orgs","repos_url":"https://api.github.com/users/Smotko/repos","events_url":"https://api.github.com/users/Smotko/events{/privacy}","received_events_url":"https://api.github.com/users/Smotko/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":45,"state":"open","created_at":"2015-04-06T23:02:21Z","updated_at":"2015-07-03T07:51:09Z","due_on":"2015-06-29T22:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/google/ggrc-core/pulls/2853/commits","review_comments_url":"https://api.github.com/repos/google/ggrc-core/pulls/2853/comments","review_comment_url":"https://api.github.com/repos/google/ggrc-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/ggrc-core/issues/2853/comments","statuses_url":"https://api.github.com/repos/google/ggrc-core/statuses/211299fd1a4651726afa7eed401079d72d930e0c","head":{"label":"hyperNURb:feature/CORE-1766","ref":"feature/CORE-1766","sha":"211299fd1a4651726afa7eed401079d72d930e0c","user":{"login":"hyperNURb","id":59742,"avatar_url":"https://avatars.githubusercontent.com/u/59742?v=3","gravatar_id":"","url":"https://api.github.com/users/hyperNURb","html_url":"https://github.com/hyperNURb","followers_url":"https://api.github.com/users/hyperNURb/followers","following_url":"https://api.github.com/users/hyperNURb/following{/other_user}","gists_url":"https://api.github.com/users/hyperNURb/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperNURb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperNURb/subscriptions","organizations_url":"https://api.github.com/users/hyperNURb/orgs","repos_url":"https://api.github.com/users/hyperNURb/repos","events_url":"https://api.github.com/users/hyperNURb/events{/privacy}","received_events_url":"https://api.github.com/users/hyperNURb/received_events","type":"User","site_admin":false},"repo":{"id":34402765,"name":"ggrc-core","full_name":"hyperNURb/ggrc-core","owner":{"login":"hyperNURb","id":59742,"avatar_url":"https://avatars.githubusercontent.com/u/59742?v=3","gravatar_id":"","url":"https://api.github.com/users/hyperNURb","html_url":"https://github.com/hyperNURb","followers_url":"https://api.github.com/users/hyperNURb/followers","following_url":"https://api.github.com/users/hyperNURb/following{/other_user}","gists_url":"https://api.github.com/users/hyperNURb/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperNURb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperNURb/subscriptions","organizations_url":"https://api.github.com/users/hyperNURb/orgs","repos_url":"https://api.github.com/users/hyperNURb/repos","events_url":"https://api.github.com/users/hyperNURb/events{/privacy}","received_events_url":"https://api.github.com/users/hyperNURb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hyperNURb/ggrc-core","description":"GGRC Core","fork":true,"url":"https://api.github.com/repos/hyperNURb/ggrc-core","forks_url":"https://api.github.com/repos/hyperNURb/ggrc-core/forks","keys_url":"https://api.github.com/repos/hyperNURb/ggrc-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hyperNURb/ggrc-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hyperNURb/ggrc-core/teams","hooks_url":"https://api.github.com/repos/hyperNURb/ggrc-core/hooks","issue_events_url":"https://api.github.com/repos/hyperNURb/ggrc-core/issues/events{/number}","events_url":"https://api.github.com/repos/hyperNURb/ggrc-core/events","assignees_url":"https://api.github.com/repos/hyperNURb/ggrc-core/assignees{/user}","branches_url":"https://api.github.com/repos/hyperNURb/ggrc-core/branches{/branch}","tags_url":"https://api.github.com/repos/hyperNURb/ggrc-core/tags","blobs_url":"https://api.github.com/repos/hyperNURb/ggrc-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hyperNURb/ggrc-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hyperNURb/ggrc-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/hyperNURb/ggrc-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hyperNURb/ggrc-core/statuses/{sha}","languages_url":"https://api.github.com/repos/hyperNURb/ggrc-core/languages","stargazers_url":"https://api.github.com/repos/hyperNURb/ggrc-core/stargazers","contributors_url":"https://api.github.com/repos/hyperNURb/ggrc-core/contributors","subscribers_url":"https://api.github.com/repos/hyperNURb/ggrc-core/subscribers","subscription_url":"https://api.github.com/repos/hyperNURb/ggrc-core/subscription","commits_url":"https://api.github.com/repos/hyperNURb/ggrc-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/hyperNURb/ggrc-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/hyperNURb/ggrc-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/hyperNURb/ggrc-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/hyperNURb/ggrc-core/contents/{+path}","compare_url":"https://api.github.com/repos/hyperNURb/ggrc-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hyperNURb/ggrc-core/merges","archive_url":"https://api.github.com/repos/hyperNURb/ggrc-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hyperNURb/ggrc-core/downloads","issues_url":"https://api.github.com/repos/hyperNURb/ggrc-core/issues{/number}","pulls_url":"https://api.github.com/repos/hyperNURb/ggrc-core/pulls{/number}","milestones_url":"https://api.github.com/repos/hyperNURb/ggrc-core/milestones{/number}","notifications_url":"https://api.github.com/repos/hyperNURb/ggrc-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hyperNURb/ggrc-core/labels{/name}","releases_url":"https://api.github.com/repos/hyperNURb/ggrc-core/releases{/id}","created_at":"2015-04-22T16:45:05Z","updated_at":"2015-05-05T08:45:45Z","pushed_at":"2015-07-03T00:02:34Z","git_url":"git://github.com/hyperNURb/ggrc-core.git","ssh_url":"git@github.com:hyperNURb/ggrc-core.git","clone_url":"https://github.com/hyperNURb/ggrc-core.git","svn_url":"https://github.com/hyperNURb/ggrc-core","homepage":null,"size":37314,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"google:develop","ref":"develop","sha":"14fe7fa6145de8a740878006e5d0610b08fe69e1","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":9304637,"name":"ggrc-core","full_name":"google/ggrc-core","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/ggrc-core","description":"GGRC Core","fork":false,"url":"https://api.github.com/repos/google/ggrc-core","forks_url":"https://api.github.com/repos/google/ggrc-core/forks","keys_url":"https://api.github.com/repos/google/ggrc-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/ggrc-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/ggrc-core/teams","hooks_url":"https://api.github.com/repos/google/ggrc-core/hooks","issue_events_url":"https://api.github.com/repos/google/ggrc-core/issues/events{/number}","events_url":"https://api.github.com/repos/google/ggrc-core/events","assignees_url":"https://api.github.com/repos/google/ggrc-core/assignees{/user}","branches_url":"https://api.github.com/repos/google/ggrc-core/branches{/branch}","tags_url":"https://api.github.com/repos/google/ggrc-core/tags","blobs_url":"https://api.github.com/repos/google/ggrc-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/ggrc-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/ggrc-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/ggrc-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/ggrc-core/statuses/{sha}","languages_url":"https://api.github.com/repos/google/ggrc-core/languages","stargazers_url":"https://api.github.com/repos/google/ggrc-core/stargazers","contributors_url":"https://api.github.com/repos/google/ggrc-core/contributors","subscribers_url":"https://api.github.com/repos/google/ggrc-core/subscribers","subscription_url":"https://api.github.com/repos/google/ggrc-core/subscription","commits_url":"https://api.github.com/repos/google/ggrc-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/ggrc-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/ggrc-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/ggrc-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/ggrc-core/contents/{+path}","compare_url":"https://api.github.com/repos/google/ggrc-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/ggrc-core/merges","archive_url":"https://api.github.com/repos/google/ggrc-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/ggrc-core/downloads","issues_url":"https://api.github.com/repos/google/ggrc-core/issues{/number}","pulls_url":"https://api.github.com/repos/google/ggrc-core/pulls{/number}","milestones_url":"https://api.github.com/repos/google/ggrc-core/milestones{/number}","notifications_url":"https://api.github.com/repos/google/ggrc-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/ggrc-core/labels{/name}","releases_url":"https://api.github.com/repos/google/ggrc-core/releases{/id}","created_at":"2013-04-08T19:16:28Z","updated_at":"2015-06-29T03:53:39Z","pushed_at":"2015-07-03T08:53:37Z","git_url":"git://github.com/google/ggrc-core.git","ssh_url":"git@github.com:google/ggrc-core.git","clone_url":"https://github.com/google/ggrc-core.git","svn_url":"https://github.com/google/ggrc-core","homepage":null,"size":68005,"stargazers_count":28,"watchers_count":28,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"open_issues_count":7,"forks":23,"open_issues":7,"watchers":28,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/2853"},"html":{"href":"https://github.com/google/ggrc-core/pull/2853"},"issue":{"href":"https://api.github.com/repos/google/ggrc-core/issues/2853"},"comments":{"href":"https://api.github.com/repos/google/ggrc-core/issues/2853/comments"},"review_comments":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/2853/comments"},"review_comment":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/2853/commits"},"statuses":{"href":"https://api.github.com/repos/google/ggrc-core/statuses/211299fd1a4651726afa7eed401079d72d930e0c"}}}}