{"action":"closed","number":16,"pull_request":{"url":"https://api.github.com/repos/amco/loudspeaker/pulls/16","id":37750083,"html_url":"https://github.com/amco/loudspeaker/pull/16","diff_url":"https://github.com/amco/loudspeaker/pull/16.diff","patch_url":"https://github.com/amco/loudspeaker/pull/16.patch","issue_url":"https://api.github.com/repos/amco/loudspeaker/issues/16","number":16,"state":"closed","locked":false,"title":"Remove accessor methods in initialization","user":{"login":"davidquon","id":1626593,"avatar_url":"https://avatars.githubusercontent.com/u/1626593?v=3","gravatar_id":"","url":"https://api.github.com/users/davidquon","html_url":"https://github.com/davidquon","followers_url":"https://api.github.com/users/davidquon/followers","following_url":"https://api.github.com/users/davidquon/following{/other_user}","gists_url":"https://api.github.com/users/davidquon/gists{/gist_id}","starred_url":"https://api.github.com/users/davidquon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidquon/subscriptions","organizations_url":"https://api.github.com/users/davidquon/orgs","repos_url":"https://api.github.com/users/davidquon/repos","events_url":"https://api.github.com/users/davidquon/events{/privacy}","received_events_url":"https://api.github.com/users/davidquon/received_events","type":"User","site_admin":false},"body":"To make the code safer per http://qualitycoding.org/objective-c-init/ and https://developer.apple.com/library/mac/#documentation/Cocoa/Conceptual/MemoryMgmt/Articles/mmPractical.html, the accessor methods were removed from the `init` of `LSPAudioViewController`.\r\n\r\n@adamyanalunas - Please inspect.","created_at":"2015-06-16T00:45:17Z","updated_at":"2015-06-16T17:07:35Z","closed_at":"2015-06-16T17:07:35Z","merged_at":"2015-06-16T17:07:35Z","merge_commit_sha":"adfbabfdccb66e33d8b92f1cc97c93f0a580a142","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/amco/loudspeaker/pulls/16/commits","review_comments_url":"https://api.github.com/repos/amco/loudspeaker/pulls/16/comments","review_comment_url":"https://api.github.com/repos/amco/loudspeaker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/amco/loudspeaker/issues/16/comments","statuses_url":"https://api.github.com/repos/amco/loudspeaker/statuses/c8b731b67061b0636fe95e7f32368504276b625a","head":{"label":"amco:remove_accessors_in_init","ref":"remove_accessors_in_init","sha":"c8b731b67061b0636fe95e7f32368504276b625a","user":{"login":"amco","id":137698,"avatar_url":"https://avatars.githubusercontent.com/u/137698?v=3","gravatar_id":"","url":"https://api.github.com/users/amco","html_url":"https://github.com/amco","followers_url":"https://api.github.com/users/amco/followers","following_url":"https://api.github.com/users/amco/following{/other_user}","gists_url":"https://api.github.com/users/amco/gists{/gist_id}","starred_url":"https://api.github.com/users/amco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amco/subscriptions","organizations_url":"https://api.github.com/users/amco/orgs","repos_url":"https://api.github.com/users/amco/repos","events_url":"https://api.github.com/users/amco/events{/privacy}","received_events_url":"https://api.github.com/users/amco/received_events","type":"Organization","site_admin":false},"repo":{"id":23481380,"name":"loudspeaker","full_name":"amco/loudspeaker","owner":{"login":"amco","id":137698,"avatar_url":"https://avatars.githubusercontent.com/u/137698?v=3","gravatar_id":"","url":"https://api.github.com/users/amco","html_url":"https://github.com/amco","followers_url":"https://api.github.com/users/amco/followers","following_url":"https://api.github.com/users/amco/following{/other_user}","gists_url":"https://api.github.com/users/amco/gists{/gist_id}","starred_url":"https://api.github.com/users/amco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amco/subscriptions","organizations_url":"https://api.github.com/users/amco/orgs","repos_url":"https://api.github.com/users/amco/repos","events_url":"https://api.github.com/users/amco/events{/privacy}","received_events_url":"https://api.github.com/users/amco/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/amco/loudspeaker","description":"An AVQueuePlayer-backed audio player for iOS with a modern, minimal UI","fork":false,"url":"https://api.github.com/repos/amco/loudspeaker","forks_url":"https://api.github.com/repos/amco/loudspeaker/forks","keys_url":"https://api.github.com/repos/amco/loudspeaker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amco/loudspeaker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amco/loudspeaker/teams","hooks_url":"https://api.github.com/repos/amco/loudspeaker/hooks","issue_events_url":"https://api.github.com/repos/amco/loudspeaker/issues/events{/number}","events_url":"https://api.github.com/repos/amco/loudspeaker/events","assignees_url":"https://api.github.com/repos/amco/loudspeaker/assignees{/user}","branches_url":"https://api.github.com/repos/amco/loudspeaker/branches{/branch}","tags_url":"https://api.github.com/repos/amco/loudspeaker/tags","blobs_url":"https://api.github.com/repos/amco/loudspeaker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amco/loudspeaker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amco/loudspeaker/git/refs{/sha}","trees_url":"https://api.github.com/repos/amco/loudspeaker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amco/loudspeaker/statuses/{sha}","languages_url":"https://api.github.com/repos/amco/loudspeaker/languages","stargazers_url":"https://api.github.com/repos/amco/loudspeaker/stargazers","contributors_url":"https://api.github.com/repos/amco/loudspeaker/contributors","subscribers_url":"https://api.github.com/repos/amco/loudspeaker/subscribers","subscription_url":"https://api.github.com/repos/amco/loudspeaker/subscription","commits_url":"https://api.github.com/repos/amco/loudspeaker/commits{/sha}","git_commits_url":"https://api.github.com/repos/amco/loudspeaker/git/commits{/sha}","comments_url":"https://api.github.com/repos/amco/loudspeaker/comments{/number}","issue_comment_url":"https://api.github.com/repos/amco/loudspeaker/issues/comments{/number}","contents_url":"https://api.github.com/repos/amco/loudspeaker/contents/{+path}","compare_url":"https://api.github.com/repos/amco/loudspeaker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amco/loudspeaker/merges","archive_url":"https://api.github.com/repos/amco/loudspeaker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amco/loudspeaker/downloads","issues_url":"https://api.github.com/repos/amco/loudspeaker/issues{/number}","pulls_url":"https://api.github.com/repos/amco/loudspeaker/pulls{/number}","milestones_url":"https://api.github.com/repos/amco/loudspeaker/milestones{/number}","notifications_url":"https://api.github.com/repos/amco/loudspeaker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amco/loudspeaker/labels{/name}","releases_url":"https://api.github.com/repos/amco/loudspeaker/releases{/id}","created_at":"2014-08-30T00:27:15Z","updated_at":"2015-03-11T14:17:35Z","pushed_at":"2015-06-16T17:07:35Z","git_url":"git://github.com/amco/loudspeaker.git","ssh_url":"git@github.com:amco/loudspeaker.git","clone_url":"https://github.com/amco/loudspeaker.git","svn_url":"https://github.com/amco/loudspeaker","homepage":null,"size":908,"stargazers_count":5,"watchers_count":5,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":5,"default_branch":"master"}},"base":{"label":"amco:master","ref":"master","sha":"ca31f5f9ef4cdc01507cf22f570b28088de07abf","user":{"login":"amco","id":137698,"avatar_url":"https://avatars.githubusercontent.com/u/137698?v=3","gravatar_id":"","url":"https://api.github.com/users/amco","html_url":"https://github.com/amco","followers_url":"https://api.github.com/users/amco/followers","following_url":"https://api.github.com/users/amco/following{/other_user}","gists_url":"https://api.github.com/users/amco/gists{/gist_id}","starred_url":"https://api.github.com/users/amco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amco/subscriptions","organizations_url":"https://api.github.com/users/amco/orgs","repos_url":"https://api.github.com/users/amco/repos","events_url":"https://api.github.com/users/amco/events{/privacy}","received_events_url":"https://api.github.com/users/amco/received_events","type":"Organization","site_admin":false},"repo":{"id":23481380,"name":"loudspeaker","full_name":"amco/loudspeaker","owner":{"login":"amco","id":137698,"avatar_url":"https://avatars.githubusercontent.com/u/137698?v=3","gravatar_id":"","url":"https://api.github.com/users/amco","html_url":"https://github.com/amco","followers_url":"https://api.github.com/users/amco/followers","following_url":"https://api.github.com/users/amco/following{/other_user}","gists_url":"https://api.github.com/users/amco/gists{/gist_id}","starred_url":"https://api.github.com/users/amco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amco/subscriptions","organizations_url":"https://api.github.com/users/amco/orgs","repos_url":"https://api.github.com/users/amco/repos","events_url":"https://api.github.com/users/amco/events{/privacy}","received_events_url":"https://api.github.com/users/amco/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/amco/loudspeaker","description":"An AVQueuePlayer-backed audio player for iOS with a modern, minimal UI","fork":false,"url":"https://api.github.com/repos/amco/loudspeaker","forks_url":"https://api.github.com/repos/amco/loudspeaker/forks","keys_url":"https://api.github.com/repos/amco/loudspeaker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amco/loudspeaker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amco/loudspeaker/teams","hooks_url":"https://api.github.com/repos/amco/loudspeaker/hooks","issue_events_url":"https://api.github.com/repos/amco/loudspeaker/issues/events{/number}","events_url":"https://api.github.com/repos/amco/loudspeaker/events","assignees_url":"https://api.github.com/repos/amco/loudspeaker/assignees{/user}","branches_url":"https://api.github.com/repos/amco/loudspeaker/branches{/branch}","tags_url":"https://api.github.com/repos/amco/loudspeaker/tags","blobs_url":"https://api.github.com/repos/amco/loudspeaker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amco/loudspeaker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amco/loudspeaker/git/refs{/sha}","trees_url":"https://api.github.com/repos/amco/loudspeaker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amco/loudspeaker/statuses/{sha}","languages_url":"https://api.github.com/repos/amco/loudspeaker/languages","stargazers_url":"https://api.github.com/repos/amco/loudspeaker/stargazers","contributors_url":"https://api.github.com/repos/amco/loudspeaker/contributors","subscribers_url":"https://api.github.com/repos/amco/loudspeaker/subscribers","subscription_url":"https://api.github.com/repos/amco/loudspeaker/subscription","commits_url":"https://api.github.com/repos/amco/loudspeaker/commits{/sha}","git_commits_url":"https://api.github.com/repos/amco/loudspeaker/git/commits{/sha}","comments_url":"https://api.github.com/repos/amco/loudspeaker/comments{/number}","issue_comment_url":"https://api.github.com/repos/amco/loudspeaker/issues/comments{/number}","contents_url":"https://api.github.com/repos/amco/loudspeaker/contents/{+path}","compare_url":"https://api.github.com/repos/amco/loudspeaker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amco/loudspeaker/merges","archive_url":"https://api.github.com/repos/amco/loudspeaker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amco/loudspeaker/downloads","issues_url":"https://api.github.com/repos/amco/loudspeaker/issues{/number}","pulls_url":"https://api.github.com/repos/amco/loudspeaker/pulls{/number}","milestones_url":"https://api.github.com/repos/amco/loudspeaker/milestones{/number}","notifications_url":"https://api.github.com/repos/amco/loudspeaker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amco/loudspeaker/labels{/name}","releases_url":"https://api.github.com/repos/amco/loudspeaker/releases{/id}","created_at":"2014-08-30T00:27:15Z","updated_at":"2015-03-11T14:17:35Z","pushed_at":"2015-06-16T17:07:35Z","git_url":"git://github.com/amco/loudspeaker.git","ssh_url":"git@github.com:amco/loudspeaker.git","clone_url":"https://github.com/amco/loudspeaker.git","svn_url":"https://github.com/amco/loudspeaker","homepage":null,"size":908,"stargazers_count":5,"watchers_count":5,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/amco/loudspeaker/pulls/16"},"html":{"href":"https://github.com/amco/loudspeaker/pull/16"},"issue":{"href":"https://api.github.com/repos/amco/loudspeaker/issues/16"},"comments":{"href":"https://api.github.com/repos/amco/loudspeaker/issues/16/comments"},"review_comments":{"href":"https://api.github.com/repos/amco/loudspeaker/pulls/16/comments"},"review_comment":{"href":"https://api.github.com/repos/amco/loudspeaker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/amco/loudspeaker/pulls/16/commits"},"statuses":{"href":"https://api.github.com/repos/amco/loudspeaker/statuses/c8b731b67061b0636fe95e7f32368504276b625a"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"adamyanalunas","id":366221,"avatar_url":"https://avatars.githubusercontent.com/u/366221?v=3","gravatar_id":"","url":"https://api.github.com/users/adamyanalunas","html_url":"https://github.com/adamyanalunas","followers_url":"https://api.github.com/users/adamyanalunas/followers","following_url":"https://api.github.com/users/adamyanalunas/following{/other_user}","gists_url":"https://api.github.com/users/adamyanalunas/gists{/gist_id}","starred_url":"https://api.github.com/users/adamyanalunas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamyanalunas/subscriptions","organizations_url":"https://api.github.com/users/adamyanalunas/orgs","repos_url":"https://api.github.com/users/adamyanalunas/repos","events_url":"https://api.github.com/users/adamyanalunas/events{/privacy}","received_events_url":"https://api.github.com/users/adamyanalunas/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":4,"deletions":12,"changed_files":2}}