{"action":"created","comment":{"url":"https://api.github.com/repos/jashkenas/backbone/pulls/comments/43513999","id":43513999,"diff_hunk":"@@ -428,27 +421,24 @@\n   });\n \n   QUnit.test(\"defaults\", function(assert) {\n-    assert.expect(4);\n+    assert.expect(5);\n     var Defaulted = Backbone.Model.extend({\n       defaults: {\n-        \"one\": 1,\n-        \"two\": 2\n+        one: 1,\n+        two: 2\n       }\n     });\n     var model = new Defaulted({two: undefined});\n     assert.equal(model.get('one'), 1);\n     assert.equal(model.get('two'), 2);\n+    model = new Defaulted({two: 3});\n+    assert.equal(model.get('one'), 1);\n+    assert.equal(model.get('two'), 3);\n     Defaulted = Backbone.Model.extend({\n-      defaults: function() {\n-        return {\n-          \"one\": 3,\n-          \"two\": 4\n-        };\n-      }\n+      defaults: { hasOwnProperty: true, }\n     });\n-    model = new Defaulted({two: undefined});","path":"test/model.js","position":62,"original_position":62,"commit_id":"bb2b6157e6f23c401407fb0b53e1f01d6db33de2","original_commit_id":"bb2b6157e6f23c401407fb0b53e1f01d6db33de2","user":{"login":"jridgewell","id":112982,"avatar_url":"https://avatars.githubusercontent.com/u/112982?v=3","gravatar_id":"","url":"https://api.github.com/users/jridgewell","html_url":"https://github.com/jridgewell","followers_url":"https://api.github.com/users/jridgewell/followers","following_url":"https://api.github.com/users/jridgewell/following{/other_user}","gists_url":"https://api.github.com/users/jridgewell/gists{/gist_id}","starred_url":"https://api.github.com/users/jridgewell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jridgewell/subscriptions","organizations_url":"https://api.github.com/users/jridgewell/orgs","repos_url":"https://api.github.com/users/jridgewell/repos","events_url":"https://api.github.com/users/jridgewell/events{/privacy}","received_events_url":"https://api.github.com/users/jridgewell/received_events","type":"User","site_admin":false},"body":"It's testing the same thing as the one above it, no?","created_at":"2015-10-30T15:21:45Z","updated_at":"2015-10-30T15:21:45Z","html_url":"https://github.com/jashkenas/backbone/pull/3843#discussion_r43513999","pull_request_url":"https://api.github.com/repos/jashkenas/backbone/pulls/3843","_links":{"self":{"href":"https://api.github.com/repos/jashkenas/backbone/pulls/comments/43513999"},"html":{"href":"https://github.com/jashkenas/backbone/pull/3843#discussion_r43513999"},"pull_request":{"href":"https://api.github.com/repos/jashkenas/backbone/pulls/3843"}}},"pull_request":{"url":"https://api.github.com/repos/jashkenas/backbone/pulls/3843","id":49218939,"html_url":"https://github.com/jashkenas/backbone/pull/3843","diff_url":"https://github.com/jashkenas/backbone/pull/3843.diff","patch_url":"https://github.com/jashkenas/backbone/pull/3843.patch","issue_url":"https://api.github.com/repos/jashkenas/backbone/issues/3843","number":3843,"state":"open","locked":false,"title":"Use modified defaults algorithm to avoid Object.prototype collisions","user":{"login":"jridgewell","id":112982,"avatar_url":"https://avatars.githubusercontent.com/u/112982?v=3","gravatar_id":"","url":"https://api.github.com/users/jridgewell","html_url":"https://github.com/jridgewell","followers_url":"https://api.github.com/users/jridgewell/followers","following_url":"https://api.github.com/users/jridgewell/following{/other_user}","gists_url":"https://api.github.com/users/jridgewell/gists{/gist_id}","starred_url":"https://api.github.com/users/jridgewell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jridgewell/subscriptions","organizations_url":"https://api.github.com/users/jridgewell/orgs","repos_url":"https://api.github.com/users/jridgewell/repos","events_url":"https://api.github.com/users/jridgewell/events{/privacy}","received_events_url":"https://api.github.com/users/jridgewell/received_events","type":"User","site_admin":false},"body":"This is definitely an underscore concern, but it's easier to demo in Backbone code.\r\n\r\nFixes #3842.","created_at":"2015-10-30T00:36:03Z","updated_at":"2015-10-30T15:21:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cde7fa29d3ed5164d1d038a0b4b9ac1d7c403726","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jashkenas/backbone/pulls/3843/commits","review_comments_url":"https://api.github.com/repos/jashkenas/backbone/pulls/3843/comments","review_comment_url":"https://api.github.com/repos/jashkenas/backbone/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jashkenas/backbone/issues/3843/comments","statuses_url":"https://api.github.com/repos/jashkenas/backbone/statuses/bb2b6157e6f23c401407fb0b53e1f01d6db33de2","head":{"label":"jridgewell:defaults-prototype-collision","ref":"defaults-prototype-collision","sha":"bb2b6157e6f23c401407fb0b53e1f01d6db33de2","user":{"login":"jridgewell","id":112982,"avatar_url":"https://avatars.githubusercontent.com/u/112982?v=3","gravatar_id":"","url":"https://api.github.com/users/jridgewell","html_url":"https://github.com/jridgewell","followers_url":"https://api.github.com/users/jridgewell/followers","following_url":"https://api.github.com/users/jridgewell/following{/other_user}","gists_url":"https://api.github.com/users/jridgewell/gists{/gist_id}","starred_url":"https://api.github.com/users/jridgewell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jridgewell/subscriptions","organizations_url":"https://api.github.com/users/jridgewell/orgs","repos_url":"https://api.github.com/users/jridgewell/repos","events_url":"https://api.github.com/users/jridgewell/events{/privacy}","received_events_url":"https://api.github.com/users/jridgewell/received_events","type":"User","site_admin":false},"repo":{"id":25927845,"name":"backbone","full_name":"jridgewell/backbone","owner":{"login":"jridgewell","id":112982,"avatar_url":"https://avatars.githubusercontent.com/u/112982?v=3","gravatar_id":"","url":"https://api.github.com/users/jridgewell","html_url":"https://github.com/jridgewell","followers_url":"https://api.github.com/users/jridgewell/followers","following_url":"https://api.github.com/users/jridgewell/following{/other_user}","gists_url":"https://api.github.com/users/jridgewell/gists{/gist_id}","starred_url":"https://api.github.com/users/jridgewell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jridgewell/subscriptions","organizations_url":"https://api.github.com/users/jridgewell/orgs","repos_url":"https://api.github.com/users/jridgewell/repos","events_url":"https://api.github.com/users/jridgewell/events{/privacy}","received_events_url":"https://api.github.com/users/jridgewell/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jridgewell/backbone","description":"Give your JS App some Backbone with Models, Views, Collections, and Events","fork":true,"url":"https://api.github.com/repos/jridgewell/backbone","forks_url":"https://api.github.com/repos/jridgewell/backbone/forks","keys_url":"https://api.github.com/repos/jridgewell/backbone/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jridgewell/backbone/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jridgewell/backbone/teams","hooks_url":"https://api.github.com/repos/jridgewell/backbone/hooks","issue_events_url":"https://api.github.com/repos/jridgewell/backbone/issues/events{/number}","events_url":"https://api.github.com/repos/jridgewell/backbone/events","assignees_url":"https://api.github.com/repos/jridgewell/backbone/assignees{/user}","branches_url":"https://api.github.com/repos/jridgewell/backbone/branches{/branch}","tags_url":"https://api.github.com/repos/jridgewell/backbone/tags","blobs_url":"https://api.github.com/repos/jridgewell/backbone/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jridgewell/backbone/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jridgewell/backbone/git/refs{/sha}","trees_url":"https://api.github.com/repos/jridgewell/backbone/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jridgewell/backbone/statuses/{sha}","languages_url":"https://api.github.com/repos/jridgewell/backbone/languages","stargazers_url":"https://api.github.com/repos/jridgewell/backbone/stargazers","contributors_url":"https://api.github.com/repos/jridgewell/backbone/contributors","subscribers_url":"https://api.github.com/repos/jridgewell/backbone/subscribers","subscription_url":"https://api.github.com/repos/jridgewell/backbone/subscription","commits_url":"https://api.github.com/repos/jridgewell/backbone/commits{/sha}","git_commits_url":"https://api.github.com/repos/jridgewell/backbone/git/commits{/sha}","comments_url":"https://api.github.com/repos/jridgewell/backbone/comments{/number}","issue_comment_url":"https://api.github.com/repos/jridgewell/backbone/issues/comments{/number}","contents_url":"https://api.github.com/repos/jridgewell/backbone/contents/{+path}","compare_url":"https://api.github.com/repos/jridgewell/backbone/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jridgewell/backbone/merges","archive_url":"https://api.github.com/repos/jridgewell/backbone/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jridgewell/backbone/downloads","issues_url":"https://api.github.com/repos/jridgewell/backbone/issues{/number}","pulls_url":"https://api.github.com/repos/jridgewell/backbone/pulls{/number}","milestones_url":"https://api.github.com/repos/jridgewell/backbone/milestones{/number}","notifications_url":"https://api.github.com/repos/jridgewell/backbone/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jridgewell/backbone/labels{/name}","releases_url":"https://api.github.com/repos/jridgewell/backbone/releases{/id}","created_at":"2014-10-29T15:38:55Z","updated_at":"2015-05-01T23:24:06Z","pushed_at":"2015-10-30T00:34:56Z","git_url":"git://github.com/jridgewell/backbone.git","ssh_url":"git@github.com:jridgewell/backbone.git","clone_url":"https://github.com/jridgewell/backbone.git","svn_url":"https://github.com/jridgewell/backbone","homepage":"http://backbonejs.org","size":27079,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jashkenas:master","ref":"master","sha":"569f07e6a692031c67cd5d7d579426bc98232905","user":{"login":"jashkenas","id":4732,"avatar_url":"https://avatars.githubusercontent.com/u/4732?v=3","gravatar_id":"","url":"https://api.github.com/users/jashkenas","html_url":"https://github.com/jashkenas","followers_url":"https://api.github.com/users/jashkenas/followers","following_url":"https://api.github.com/users/jashkenas/following{/other_user}","gists_url":"https://api.github.com/users/jashkenas/gists{/gist_id}","starred_url":"https://api.github.com/users/jashkenas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jashkenas/subscriptions","organizations_url":"https://api.github.com/users/jashkenas/orgs","repos_url":"https://api.github.com/users/jashkenas/repos","events_url":"https://api.github.com/users/jashkenas/events{/privacy}","received_events_url":"https://api.github.com/users/jashkenas/received_events","type":"User","site_admin":false},"repo":{"id":952189,"name":"backbone","full_name":"jashkenas/backbone","owner":{"login":"jashkenas","id":4732,"avatar_url":"https://avatars.githubusercontent.com/u/4732?v=3","gravatar_id":"","url":"https://api.github.com/users/jashkenas","html_url":"https://github.com/jashkenas","followers_url":"https://api.github.com/users/jashkenas/followers","following_url":"https://api.github.com/users/jashkenas/following{/other_user}","gists_url":"https://api.github.com/users/jashkenas/gists{/gist_id}","starred_url":"https://api.github.com/users/jashkenas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jashkenas/subscriptions","organizations_url":"https://api.github.com/users/jashkenas/orgs","repos_url":"https://api.github.com/users/jashkenas/repos","events_url":"https://api.github.com/users/jashkenas/events{/privacy}","received_events_url":"https://api.github.com/users/jashkenas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jashkenas/backbone","description":"Give your JS App some Backbone with Models, Views, Collections, and Events","fork":false,"url":"https://api.github.com/repos/jashkenas/backbone","forks_url":"https://api.github.com/repos/jashkenas/backbone/forks","keys_url":"https://api.github.com/repos/jashkenas/backbone/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jashkenas/backbone/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jashkenas/backbone/teams","hooks_url":"https://api.github.com/repos/jashkenas/backbone/hooks","issue_events_url":"https://api.github.com/repos/jashkenas/backbone/issues/events{/number}","events_url":"https://api.github.com/repos/jashkenas/backbone/events","assignees_url":"https://api.github.com/repos/jashkenas/backbone/assignees{/user}","branches_url":"https://api.github.com/repos/jashkenas/backbone/branches{/branch}","tags_url":"https://api.github.com/repos/jashkenas/backbone/tags","blobs_url":"https://api.github.com/repos/jashkenas/backbone/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jashkenas/backbone/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jashkenas/backbone/git/refs{/sha}","trees_url":"https://api.github.com/repos/jashkenas/backbone/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jashkenas/backbone/statuses/{sha}","languages_url":"https://api.github.com/repos/jashkenas/backbone/languages","stargazers_url":"https://api.github.com/repos/jashkenas/backbone/stargazers","contributors_url":"https://api.github.com/repos/jashkenas/backbone/contributors","subscribers_url":"https://api.github.com/repos/jashkenas/backbone/subscribers","subscription_url":"https://api.github.com/repos/jashkenas/backbone/subscription","commits_url":"https://api.github.com/repos/jashkenas/backbone/commits{/sha}","git_commits_url":"https://api.github.com/repos/jashkenas/backbone/git/commits{/sha}","comments_url":"https://api.github.com/repos/jashkenas/backbone/comments{/number}","issue_comment_url":"https://api.github.com/repos/jashkenas/backbone/issues/comments{/number}","contents_url":"https://api.github.com/repos/jashkenas/backbone/contents/{+path}","compare_url":"https://api.github.com/repos/jashkenas/backbone/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jashkenas/backbone/merges","archive_url":"https://api.github.com/repos/jashkenas/backbone/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jashkenas/backbone/downloads","issues_url":"https://api.github.com/repos/jashkenas/backbone/issues{/number}","pulls_url":"https://api.github.com/repos/jashkenas/backbone/pulls{/number}","milestones_url":"https://api.github.com/repos/jashkenas/backbone/milestones{/number}","notifications_url":"https://api.github.com/repos/jashkenas/backbone/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jashkenas/backbone/labels{/name}","releases_url":"https://api.github.com/repos/jashkenas/backbone/releases{/id}","created_at":"2010-09-30T19:41:28Z","updated_at":"2015-10-30T14:01:30Z","pushed_at":"2015-10-30T15:13:44Z","git_url":"git://github.com/jashkenas/backbone.git","ssh_url":"git@github.com:jashkenas/backbone.git","clone_url":"https://github.com/jashkenas/backbone.git","svn_url":"https://github.com/jashkenas/backbone","homepage":"http://backbonejs.org","size":47691,"stargazers_count":23280,"watchers_count":23280,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5209,"mirror_url":null,"open_issues_count":38,"forks":5209,"open_issues":38,"watchers":23280,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jashkenas/backbone/pulls/3843"},"html":{"href":"https://github.com/jashkenas/backbone/pull/3843"},"issue":{"href":"https://api.github.com/repos/jashkenas/backbone/issues/3843"},"comments":{"href":"https://api.github.com/repos/jashkenas/backbone/issues/3843/comments"},"review_comments":{"href":"https://api.github.com/repos/jashkenas/backbone/pulls/3843/comments"},"review_comment":{"href":"https://api.github.com/repos/jashkenas/backbone/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jashkenas/backbone/pulls/3843/commits"},"statuses":{"href":"https://api.github.com/repos/jashkenas/backbone/statuses/bb2b6157e6f23c401407fb0b53e1f01d6db33de2"}}}}