{"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/44656565","id":44656565,"diff_hunk":"@@ -1279,6 +1279,45 @@ def refresh_firewall_rules\n   def refresh_advanced_settings\n   end\n \n+  def refresh_network_interfaces(ssu)\n+    smartstate_network_ports = MiqLinux::Utils.parse_network_interface_list(ssu.shell_exec(\"ip a\"))\n+\n+    neutron_network_ports = network_ports.where(:source => :neutron).each_with_object({}) do |network_port, obj|\n+      obj[network_port.mac_address] = network_port\n+    end\n+    neutron_cloud_subnets = ext_management_system.cloud_subnets\n+    hashes = []\n+\n+    smartstate_network_ports.each do |network_port|\n+      existing_network_port = neutron_network_ports[network_port[:mac_address]]\n+      if existing_network_port.blank?\n+        cloud_subnet = neutron_cloud_subnets.detect do |neutron_cloud_subnet|\n+          if neutron_cloud_subnet.ip_version == 4\n+            IPAddr.new(neutron_cloud_subnet.cidr).include?(network_port[:fixed_ip])\n+          else\n+            IPAddr.new(neutron_cloud_subnet.cidr).include?(network_port[:fixed_ipv6])\n+          end\n+        end\n+\n+        hashes << {:name          => network_port[:name],\n+                   :mac_address   => network_port[:mac_address],\n+                   :cloud_subnet  => cloud_subnet,\n+                   :cloud_network => cloud_subnet.try(:cloud_network),\n+                   :device        => self,\n+                   :fixed_ips     => {:subnet_id     => nil,\n+                                      :ip_address    => network_port[:fixed_ip],\n+                                      :ip_address_v6 => network_port[:fixed_ipv6]}}\n+      else\n+        # Just updating a names of network_ports refreshed fro Neutron, rest of attributes\n+        # is handled in refresh section.\n+        existing_network_port.update_attributes(:name => network_port[:name])\n+      end\n+    end\n+    EmsRefresh.save_network_ports_inventory(ext_management_system, hashes, ext_management_system, :smartstate) if hashes","path":"app/models/host.rb","position":38,"original_position":38,"commit_id":"0e29e3eba45eb72e5d22cf78953fbdff1f8b48df","original_commit_id":"0e29e3eba45eb72e5d22cf78953fbdff1f8b48df","user":{"login":"blomquisg","id":14183,"avatar_url":"https://avatars.githubusercontent.com/u/14183?v=3","gravatar_id":"","url":"https://api.github.com/users/blomquisg","html_url":"https://github.com/blomquisg","followers_url":"https://api.github.com/users/blomquisg/followers","following_url":"https://api.github.com/users/blomquisg/following{/other_user}","gists_url":"https://api.github.com/users/blomquisg/gists{/gist_id}","starred_url":"https://api.github.com/users/blomquisg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blomquisg/subscriptions","organizations_url":"https://api.github.com/users/blomquisg/orgs","repos_url":"https://api.github.com/users/blomquisg/repos","events_url":"https://api.github.com/users/blomquisg/events{/privacy}","received_events_url":"https://api.github.com/users/blomquisg/received_events","type":"User","site_admin":false},"body":"`hashes` will never be `nil`, so checking `if hashes` at the end of the line here will never fail.\r\n\r\nMaybe `unless hashes.blank?`","created_at":"2015-11-12T13:33:15Z","updated_at":"2015-11-12T13:33:15Z","html_url":"https://github.com/ManageIQ/manageiq/pull/4829#discussion_r44656565","pull_request_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/4829","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/44656565"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/4829#discussion_r44656565"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/4829"}}},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/4829","id":47525498,"html_url":"https://github.com/ManageIQ/manageiq/pull/4829","diff_url":"https://github.com/ManageIQ/manageiq/pull/4829.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/4829.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/4829","number":4829,"state":"open","locked":false,"title":"Openstack infra get missing network ports from smartstate","user":{"login":"Ladas","id":1737058,"avatar_url":"https://avatars.githubusercontent.com/u/1737058?v=3","gravatar_id":"","url":"https://api.github.com/users/Ladas","html_url":"https://github.com/Ladas","followers_url":"https://api.github.com/users/Ladas/followers","following_url":"https://api.github.com/users/Ladas/following{/other_user}","gists_url":"https://api.github.com/users/Ladas/gists{/gist_id}","starred_url":"https://api.github.com/users/Ladas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ladas/subscriptions","organizations_url":"https://api.github.com/users/Ladas/orgs","repos_url":"https://api.github.com/users/Ladas/repos","events_url":"https://api.github.com/users/Ladas/events{/privacy}","received_events_url":"https://api.github.com/users/Ladas/received_events","type":"User","site_admin":false},"body":"Getting list of all network interfaces of Host using smart state analysis.","created_at":"2015-10-13T12:19:55Z","updated_at":"2015-11-12T13:33:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"772ed2f006598d2ade2770d9f4c78f2d52b2f87d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/4829/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/4829/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/4829/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/0e29e3eba45eb72e5d22cf78953fbdff1f8b48df","head":{"label":"Ladas:openstack_infra_get_missing_network_ports_from_smartstate","ref":"openstack_infra_get_missing_network_ports_from_smartstate","sha":"0e29e3eba45eb72e5d22cf78953fbdff1f8b48df","user":{"login":"Ladas","id":1737058,"avatar_url":"https://avatars.githubusercontent.com/u/1737058?v=3","gravatar_id":"","url":"https://api.github.com/users/Ladas","html_url":"https://github.com/Ladas","followers_url":"https://api.github.com/users/Ladas/followers","following_url":"https://api.github.com/users/Ladas/following{/other_user}","gists_url":"https://api.github.com/users/Ladas/gists{/gist_id}","starred_url":"https://api.github.com/users/Ladas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ladas/subscriptions","organizations_url":"https://api.github.com/users/Ladas/orgs","repos_url":"https://api.github.com/users/Ladas/repos","events_url":"https://api.github.com/users/Ladas/events{/privacy}","received_events_url":"https://api.github.com/users/Ladas/received_events","type":"User","site_admin":false},"repo":{"id":27175121,"name":"manageiq","full_name":"Ladas/manageiq","owner":{"login":"Ladas","id":1737058,"avatar_url":"https://avatars.githubusercontent.com/u/1737058?v=3","gravatar_id":"","url":"https://api.github.com/users/Ladas","html_url":"https://github.com/Ladas","followers_url":"https://api.github.com/users/Ladas/followers","following_url":"https://api.github.com/users/Ladas/following{/other_user}","gists_url":"https://api.github.com/users/Ladas/gists{/gist_id}","starred_url":"https://api.github.com/users/Ladas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ladas/subscriptions","organizations_url":"https://api.github.com/users/Ladas/orgs","repos_url":"https://api.github.com/users/Ladas/repos","events_url":"https://api.github.com/users/Ladas/events{/privacy}","received_events_url":"https://api.github.com/users/Ladas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Ladas/manageiq","description":"ManageIQ Cloud Management Platform","fork":true,"url":"https://api.github.com/repos/Ladas/manageiq","forks_url":"https://api.github.com/repos/Ladas/manageiq/forks","keys_url":"https://api.github.com/repos/Ladas/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ladas/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ladas/manageiq/teams","hooks_url":"https://api.github.com/repos/Ladas/manageiq/hooks","issue_events_url":"https://api.github.com/repos/Ladas/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/Ladas/manageiq/events","assignees_url":"https://api.github.com/repos/Ladas/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/Ladas/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/Ladas/manageiq/tags","blobs_url":"https://api.github.com/repos/Ladas/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ladas/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ladas/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ladas/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ladas/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/Ladas/manageiq/languages","stargazers_url":"https://api.github.com/repos/Ladas/manageiq/stargazers","contributors_url":"https://api.github.com/repos/Ladas/manageiq/contributors","subscribers_url":"https://api.github.com/repos/Ladas/manageiq/subscribers","subscription_url":"https://api.github.com/repos/Ladas/manageiq/subscription","commits_url":"https://api.github.com/repos/Ladas/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ladas/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ladas/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ladas/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ladas/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/Ladas/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ladas/manageiq/merges","archive_url":"https://api.github.com/repos/Ladas/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ladas/manageiq/downloads","issues_url":"https://api.github.com/repos/Ladas/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/Ladas/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/Ladas/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/Ladas/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ladas/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/Ladas/manageiq/releases{/id}","created_at":"2014-11-26T12:09:24Z","updated_at":"2015-04-30T10:44:09Z","pushed_at":"2015-11-12T12:55:05Z","git_url":"git://github.com/Ladas/manageiq.git","ssh_url":"git@github.com:Ladas/manageiq.git","clone_url":"https://github.com/Ladas/manageiq.git","svn_url":"https://github.com/Ladas/manageiq","homepage":"manageiq.org","size":96061,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"49e01acc60f67a0b4a4a8ff7e76c0bcab0b6a449","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":20789757,"name":"manageiq","full_name":"ManageIQ/manageiq","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq","description":"ManageIQ Cloud Management Platform","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq","forks_url":"https://api.github.com/repos/ManageIQ/manageiq/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq/releases{/id}","created_at":"2014-06-13T02:31:26Z","updated_at":"2015-11-07T00:19:32Z","pushed_at":"2015-11-12T13:16:11Z","git_url":"git://github.com/ManageIQ/manageiq.git","ssh_url":"git@github.com:ManageIQ/manageiq.git","clone_url":"https://github.com/ManageIQ/manageiq.git","svn_url":"https://github.com/ManageIQ/manageiq","homepage":"manageiq.org","size":186087,"stargazers_count":165,"watchers_count":165,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":179,"mirror_url":null,"open_issues_count":443,"forks":179,"open_issues":443,"watchers":165,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/4829"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/4829"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/4829"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/4829/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/4829/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/4829/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq/statuses/0e29e3eba45eb72e5d22cf78953fbdff1f8b48df"}}}}