{"action":"created","issue":{"url":"https://api.github.com/repos/Mango/slideout/issues/86","labels_url":"https://api.github.com/repos/Mango/slideout/issues/86/labels{/name}","comments_url":"https://api.github.com/repos/Mango/slideout/issues/86/comments","events_url":"https://api.github.com/repos/Mango/slideout/issues/86/events","html_url":"https://github.com/Mango/slideout/pull/86","id":84195709,"number":86,"title":"New option: 'heightFix'","user":{"login":"Oreqizer","id":11172408,"avatar_url":"https://avatars.githubusercontent.com/u/11172408?v=3","gravatar_id":"","url":"https://api.github.com/users/Oreqizer","html_url":"https://github.com/Oreqizer","followers_url":"https://api.github.com/users/Oreqizer/followers","following_url":"https://api.github.com/users/Oreqizer/following{/other_user}","gists_url":"https://api.github.com/users/Oreqizer/gists{/gist_id}","starred_url":"https://api.github.com/users/Oreqizer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Oreqizer/subscriptions","organizations_url":"https://api.github.com/users/Oreqizer/orgs","repos_url":"https://api.github.com/users/Oreqizer/repos","events_url":"https://api.github.com/users/Oreqizer/events{/privacy}","received_events_url":"https://api.github.com/users/Oreqizer/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-06-02T20:23:47Z","updated_at":"2015-06-16T16:00:33Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Mango/slideout/pulls/86","html_url":"https://github.com/Mango/slideout/pull/86","diff_url":"https://github.com/Mango/slideout/pull/86.diff","patch_url":"https://github.com/Mango/slideout/pull/86.patch"},"body":"Added an option called 'heightFix', that is a boolean. If set to true, it sets a 'min-height' property on `#panel` to ensure it is at least the height of the window.\r\n\r\nI ran into this problem, when testing my site, where one page has only a tiny bit of content in it. If I set `body { height: 100% }`, on larger contents, it scrolls the page up if slideout is open.\r\n\r\nI've tried multiple versions with this option, like adding the `height: 100%` property on the `body` element, not comparing with `!=`, rather with `<=`. They work, IF the user doesn't make the window smaller, or doesn't change the content. `min-height` is non-destructive (opposed to `body { height: 100% }`) and works great also while changing content and making the window smaller.\r\n\r\nIt fires as the slideout is set up, as well as on every resize.\r\n\r\nYou can see it in action here: http://groupr.fortleet.com/ . Works below 720px width."},"comment":{"url":"https://api.github.com/repos/Mango/slideout/issues/comments/112479580","html_url":"https://github.com/Mango/slideout/pull/86#issuecomment-112479580","issue_url":"https://api.github.com/repos/Mango/slideout/issues/86","id":112479580,"user":{"login":"danzajdband","id":165799,"avatar_url":"https://avatars.githubusercontent.com/u/165799?v=3","gravatar_id":"","url":"https://api.github.com/users/danzajdband","html_url":"https://github.com/danzajdband","followers_url":"https://api.github.com/users/danzajdband/followers","following_url":"https://api.github.com/users/danzajdband/following{/other_user}","gists_url":"https://api.github.com/users/danzajdband/gists{/gist_id}","starred_url":"https://api.github.com/users/danzajdband/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danzajdband/subscriptions","organizations_url":"https://api.github.com/users/danzajdband/orgs","repos_url":"https://api.github.com/users/danzajdband/repos","events_url":"https://api.github.com/users/danzajdband/events{/privacy}","received_events_url":"https://api.github.com/users/danzajdband/received_events","type":"User","site_admin":false},"created_at":"2015-06-16T16:00:33Z","updated_at":"2015-06-16T16:00:33Z","body":"I don't know what @pazguille think about this option so I won't be very specific on the code review but the first thing I noticed is you modified dist/slideout.js instead of index.js. index.js is our source that is transpiled to dist/slideout.js for release."}}