{"action":"created","comment":{"url":"https://api.github.com/repos/broadinstitute/agora/pulls/comments/33574748","id":33574748,"diff_hunk":"@@ -59,8 +68,14 @@ class QueryHandler(authorizationProvider: AuthorizationProvider) extends Actor {\n             entityTypes: Seq[AgoraEntityType.EntityType],\n             username: String): Unit = {\n     val entities = agoraBusiness.find(agoraSearch, agoraProjection, entityTypes, username)\n-    authorizationProvider.filterByReadPermissions(authorizationProvider.authorizationsForEntities(entities, username))\n-    context.parent ! RequestComplete(entities)\n+    try {\n+      val authorizedEntities = authorizationProvider.filterByReadPermissions(authorizationProvider.authorizationsForEntities(entities, username))","path":"src/main/scala/org/broadinstitute/dsde/agora/server/webservice/QueryHandler.scala","position":38,"original_position":38,"commit_id":"995b63af4b39609a524dfa69ac7a3968bde3701b","original_commit_id":"995b63af4b39609a524dfa69ac7a3968bde3701b","user":{"login":"bradtaylor","id":3492466,"avatar_url":"https://avatars.githubusercontent.com/u/3492466?v=3","gravatar_id":"","url":"https://api.github.com/users/bradtaylor","html_url":"https://github.com/bradtaylor","followers_url":"https://api.github.com/users/bradtaylor/followers","following_url":"https://api.github.com/users/bradtaylor/following{/other_user}","gists_url":"https://api.github.com/users/bradtaylor/gists{/gist_id}","starred_url":"https://api.github.com/users/bradtaylor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bradtaylor/subscriptions","organizations_url":"https://api.github.com/users/bradtaylor/orgs","repos_url":"https://api.github.com/users/bradtaylor/repos","events_url":"https://api.github.com/users/bradtaylor/events{/privacy}","received_events_url":"https://api.github.com/users/bradtaylor/received_events","type":"User","site_admin":false},"body":"Yes that bothered me as well.","created_at":"2015-06-30T13:57:00Z","updated_at":"2015-06-30T13:57:00Z","html_url":"https://github.com/broadinstitute/agora/pull/71#discussion_r33574748","pull_request_url":"https://api.github.com/repos/broadinstitute/agora/pulls/71","_links":{"self":{"href":"https://api.github.com/repos/broadinstitute/agora/pulls/comments/33574748"},"html":{"href":"https://github.com/broadinstitute/agora/pull/71#discussion_r33574748"},"pull_request":{"href":"https://api.github.com/repos/broadinstitute/agora/pulls/71"}}},"pull_request":{"url":"https://api.github.com/repos/broadinstitute/agora/pulls/71","id":38658675,"html_url":"https://github.com/broadinstitute/agora/pull/71","diff_url":"https://github.com/broadinstitute/agora/pull/71.diff","patch_url":"https://github.com/broadinstitute/agora/pull/71.patch","issue_url":"https://api.github.com/repos/broadinstitute/agora/issues/71","number":71,"state":"open","locked":false,"title":"Working version of method read authorization restriction","user":{"login":"bradtaylor","id":3492466,"avatar_url":"https://avatars.githubusercontent.com/u/3492466?v=3","gravatar_id":"","url":"https://api.github.com/users/bradtaylor","html_url":"https://github.com/bradtaylor","followers_url":"https://api.github.com/users/bradtaylor/followers","following_url":"https://api.github.com/users/bradtaylor/following{/other_user}","gists_url":"https://api.github.com/users/bradtaylor/gists{/gist_id}","starred_url":"https://api.github.com/users/bradtaylor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bradtaylor/subscriptions","organizations_url":"https://api.github.com/users/bradtaylor/orgs","repos_url":"https://api.github.com/users/bradtaylor/repos","events_url":"https://api.github.com/users/bradtaylor/events{/privacy}","received_events_url":"https://api.github.com/users/bradtaylor/received_events","type":"User","site_admin":false},"body":"GcsAuthorizaitonProvider is making spray-client calls to GCS JSON API endpoints. 404 responses for ACL get are interpreted as Nothing permission.\r\n\r\nFor the method/config list endpoint, we collect the http response futures into a single future of a sequence, and await the result of that.\r\nThis allows futures to complete in parallel, ensuring we only block until the slowest http response arrives.\r\n\r\nBubbling GCS contact failures up to the query-handler as a ClientServiceFailure exception, which the queryHandler catches. Responds to user as 500 error.\r\n\r\nMoved a ton of stuff into new packages\r\n\r\nThis version works on pre-created buckets.\r\nNot sure this is the best way to handle the refresh token when authenticating GCS contact","created_at":"2015-06-26T15:09:30Z","updated_at":"2015-06-30T13:57:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"466717ea5a00e98a2b797fc0426772b09463e8fc","assignee":{"login":"jacarey","id":6933549,"avatar_url":"https://avatars.githubusercontent.com/u/6933549?v=3","gravatar_id":"","url":"https://api.github.com/users/jacarey","html_url":"https://github.com/jacarey","followers_url":"https://api.github.com/users/jacarey/followers","following_url":"https://api.github.com/users/jacarey/following{/other_user}","gists_url":"https://api.github.com/users/jacarey/gists{/gist_id}","starred_url":"https://api.github.com/users/jacarey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacarey/subscriptions","organizations_url":"https://api.github.com/users/jacarey/orgs","repos_url":"https://api.github.com/users/jacarey/repos","events_url":"https://api.github.com/users/jacarey/events{/privacy}","received_events_url":"https://api.github.com/users/jacarey/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/broadinstitute/agora/pulls/71/commits","review_comments_url":"https://api.github.com/repos/broadinstitute/agora/pulls/71/comments","review_comment_url":"https://api.github.com/repos/broadinstitute/agora/pulls/comments{/number}","comments_url":"https://api.github.com/repos/broadinstitute/agora/issues/71/comments","statuses_url":"https://api.github.com/repos/broadinstitute/agora/statuses/995b63af4b39609a524dfa69ac7a3968bde3701b","head":{"label":"broadinstitute:bt_google_object_acl_get","ref":"bt_google_object_acl_get","sha":"995b63af4b39609a524dfa69ac7a3968bde3701b","user":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars.githubusercontent.com/u/393552?v=3","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"repo":{"id":34753721,"name":"agora","full_name":"broadinstitute/agora","owner":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars.githubusercontent.com/u/393552?v=3","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/broadinstitute/agora","description":"It's a methods repository!","fork":false,"url":"https://api.github.com/repos/broadinstitute/agora","forks_url":"https://api.github.com/repos/broadinstitute/agora/forks","keys_url":"https://api.github.com/repos/broadinstitute/agora/keys{/key_id}","collaborators_url":"https://api.github.com/repos/broadinstitute/agora/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/broadinstitute/agora/teams","hooks_url":"https://api.github.com/repos/broadinstitute/agora/hooks","issue_events_url":"https://api.github.com/repos/broadinstitute/agora/issues/events{/number}","events_url":"https://api.github.com/repos/broadinstitute/agora/events","assignees_url":"https://api.github.com/repos/broadinstitute/agora/assignees{/user}","branches_url":"https://api.github.com/repos/broadinstitute/agora/branches{/branch}","tags_url":"https://api.github.com/repos/broadinstitute/agora/tags","blobs_url":"https://api.github.com/repos/broadinstitute/agora/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/broadinstitute/agora/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/broadinstitute/agora/git/refs{/sha}","trees_url":"https://api.github.com/repos/broadinstitute/agora/git/trees{/sha}","statuses_url":"https://api.github.com/repos/broadinstitute/agora/statuses/{sha}","languages_url":"https://api.github.com/repos/broadinstitute/agora/languages","stargazers_url":"https://api.github.com/repos/broadinstitute/agora/stargazers","contributors_url":"https://api.github.com/repos/broadinstitute/agora/contributors","subscribers_url":"https://api.github.com/repos/broadinstitute/agora/subscribers","subscription_url":"https://api.github.com/repos/broadinstitute/agora/subscription","commits_url":"https://api.github.com/repos/broadinstitute/agora/commits{/sha}","git_commits_url":"https://api.github.com/repos/broadinstitute/agora/git/commits{/sha}","comments_url":"https://api.github.com/repos/broadinstitute/agora/comments{/number}","issue_comment_url":"https://api.github.com/repos/broadinstitute/agora/issues/comments{/number}","contents_url":"https://api.github.com/repos/broadinstitute/agora/contents/{+path}","compare_url":"https://api.github.com/repos/broadinstitute/agora/compare/{base}...{head}","merges_url":"https://api.github.com/repos/broadinstitute/agora/merges","archive_url":"https://api.github.com/repos/broadinstitute/agora/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/broadinstitute/agora/downloads","issues_url":"https://api.github.com/repos/broadinstitute/agora/issues{/number}","pulls_url":"https://api.github.com/repos/broadinstitute/agora/pulls{/number}","milestones_url":"https://api.github.com/repos/broadinstitute/agora/milestones{/number}","notifications_url":"https://api.github.com/repos/broadinstitute/agora/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/broadinstitute/agora/labels{/name}","releases_url":"https://api.github.com/repos/broadinstitute/agora/releases{/id}","created_at":"2015-04-28T20:18:52Z","updated_at":"2015-05-08T19:49:06Z","pushed_at":"2015-06-30T11:55:12Z","git_url":"git://github.com/broadinstitute/agora.git","ssh_url":"git@github.com:broadinstitute/agora.git","clone_url":"https://github.com/broadinstitute/agora.git","svn_url":"https://github.com/broadinstitute/agora","homepage":"","size":9234,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"broadinstitute:master","ref":"master","sha":"63aef9278d403ceb978c5cb25b2698543643dbc5","user":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars.githubusercontent.com/u/393552?v=3","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"repo":{"id":34753721,"name":"agora","full_name":"broadinstitute/agora","owner":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars.githubusercontent.com/u/393552?v=3","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/broadinstitute/agora","description":"It's a methods repository!","fork":false,"url":"https://api.github.com/repos/broadinstitute/agora","forks_url":"https://api.github.com/repos/broadinstitute/agora/forks","keys_url":"https://api.github.com/repos/broadinstitute/agora/keys{/key_id}","collaborators_url":"https://api.github.com/repos/broadinstitute/agora/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/broadinstitute/agora/teams","hooks_url":"https://api.github.com/repos/broadinstitute/agora/hooks","issue_events_url":"https://api.github.com/repos/broadinstitute/agora/issues/events{/number}","events_url":"https://api.github.com/repos/broadinstitute/agora/events","assignees_url":"https://api.github.com/repos/broadinstitute/agora/assignees{/user}","branches_url":"https://api.github.com/repos/broadinstitute/agora/branches{/branch}","tags_url":"https://api.github.com/repos/broadinstitute/agora/tags","blobs_url":"https://api.github.com/repos/broadinstitute/agora/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/broadinstitute/agora/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/broadinstitute/agora/git/refs{/sha}","trees_url":"https://api.github.com/repos/broadinstitute/agora/git/trees{/sha}","statuses_url":"https://api.github.com/repos/broadinstitute/agora/statuses/{sha}","languages_url":"https://api.github.com/repos/broadinstitute/agora/languages","stargazers_url":"https://api.github.com/repos/broadinstitute/agora/stargazers","contributors_url":"https://api.github.com/repos/broadinstitute/agora/contributors","subscribers_url":"https://api.github.com/repos/broadinstitute/agora/subscribers","subscription_url":"https://api.github.com/repos/broadinstitute/agora/subscription","commits_url":"https://api.github.com/repos/broadinstitute/agora/commits{/sha}","git_commits_url":"https://api.github.com/repos/broadinstitute/agora/git/commits{/sha}","comments_url":"https://api.github.com/repos/broadinstitute/agora/comments{/number}","issue_comment_url":"https://api.github.com/repos/broadinstitute/agora/issues/comments{/number}","contents_url":"https://api.github.com/repos/broadinstitute/agora/contents/{+path}","compare_url":"https://api.github.com/repos/broadinstitute/agora/compare/{base}...{head}","merges_url":"https://api.github.com/repos/broadinstitute/agora/merges","archive_url":"https://api.github.com/repos/broadinstitute/agora/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/broadinstitute/agora/downloads","issues_url":"https://api.github.com/repos/broadinstitute/agora/issues{/number}","pulls_url":"https://api.github.com/repos/broadinstitute/agora/pulls{/number}","milestones_url":"https://api.github.com/repos/broadinstitute/agora/milestones{/number}","notifications_url":"https://api.github.com/repos/broadinstitute/agora/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/broadinstitute/agora/labels{/name}","releases_url":"https://api.github.com/repos/broadinstitute/agora/releases{/id}","created_at":"2015-04-28T20:18:52Z","updated_at":"2015-05-08T19:49:06Z","pushed_at":"2015-06-30T11:55:12Z","git_url":"git://github.com/broadinstitute/agora.git","ssh_url":"git@github.com:broadinstitute/agora.git","clone_url":"https://github.com/broadinstitute/agora.git","svn_url":"https://github.com/broadinstitute/agora","homepage":"","size":9234,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/broadinstitute/agora/pulls/71"},"html":{"href":"https://github.com/broadinstitute/agora/pull/71"},"issue":{"href":"https://api.github.com/repos/broadinstitute/agora/issues/71"},"comments":{"href":"https://api.github.com/repos/broadinstitute/agora/issues/71/comments"},"review_comments":{"href":"https://api.github.com/repos/broadinstitute/agora/pulls/71/comments"},"review_comment":{"href":"https://api.github.com/repos/broadinstitute/agora/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/broadinstitute/agora/pulls/71/commits"},"statuses":{"href":"https://api.github.com/repos/broadinstitute/agora/statuses/995b63af4b39609a524dfa69ac7a3968bde3701b"}}}}