{"action":"created","comment":{"url":"https://api.github.com/repos/grpc/grpc-java/pulls/comments/34619348","id":34619348,"diff_hunk":"@@ -351,28 +345,27 @@ protected final void onSendingBytes(int numBytes) {\n   protected final void onSentBytes(int numBytes) {\n     boolean doNotify;\n     synchronized (onReadyLock) {\n+      doNotify = wentBelowThreshold(\n+          numSentBytesQueued,  // Previous queued sent bytes\n+          onReadyThreshold,\n+          numSentBytesQueued - numBytes, // New queued sent bytes\n+          onReadyThreshold);\n       numSentBytesQueued -= numBytes;\n-      doNotify = needToNotifyOnReady();\n     }\n     if (doNotify) {\n-      listener().onReady();\n+      maybeNotifyListener();","path":"core/src/main/java/io/grpc/transport/AbstractStream.java","position":null,"original_position":163,"commit_id":"6b650b8392a0da9e20f237c61bd1b3553be766fe","original_commit_id":"4daf402afd80b1c1386f57ce76b40b2194df9dc2","user":{"login":"nmittler","id":6493296,"avatar_url":"https://avatars.githubusercontent.com/u/6493296?v=3","gravatar_id":"","url":"https://api.github.com/users/nmittler","html_url":"https://github.com/nmittler","followers_url":"https://api.github.com/users/nmittler/followers","following_url":"https://api.github.com/users/nmittler/following{/other_user}","gists_url":"https://api.github.com/users/nmittler/gists{/gist_id}","starred_url":"https://api.github.com/users/nmittler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmittler/subscriptions","organizations_url":"https://api.github.com/users/nmittler/orgs","repos_url":"https://api.github.com/users/nmittler/repos","events_url":"https://api.github.com/users/nmittler/events{/privacy}","received_events_url":"https://api.github.com/users/nmittler/received_events","type":"User","site_admin":false},"body":"hmm ... don't you still have the same potential race with `maybeNotifyListener` in that you release the lock before calling the listener?","created_at":"2015-07-14T21:04:06Z","updated_at":"2015-07-14T21:04:06Z","html_url":"https://github.com/grpc/grpc-java/pull/625#discussion_r34619348","pull_request_url":"https://api.github.com/repos/grpc/grpc-java/pulls/625","_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/comments/34619348"},"html":{"href":"https://github.com/grpc/grpc-java/pull/625#discussion_r34619348"},"pull_request":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/625"}}},"pull_request":{"url":"https://api.github.com/repos/grpc/grpc-java/pulls/625","id":39958606,"html_url":"https://github.com/grpc/grpc-java/pull/625","diff_url":"https://github.com/grpc/grpc-java/pull/625.diff","patch_url":"https://github.com/grpc/grpc-java/pull/625.patch","issue_url":"https://api.github.com/repos/grpc/grpc-java/issues/625","number":625,"state":"open","locked":false,"title":"Add basic unit tests to Abstract Stream","user":{"login":"carl-mastrangelo","id":8943572,"avatar_url":"https://avatars.githubusercontent.com/u/8943572?v=3","gravatar_id":"","url":"https://api.github.com/users/carl-mastrangelo","html_url":"https://github.com/carl-mastrangelo","followers_url":"https://api.github.com/users/carl-mastrangelo/followers","following_url":"https://api.github.com/users/carl-mastrangelo/following{/other_user}","gists_url":"https://api.github.com/users/carl-mastrangelo/gists{/gist_id}","starred_url":"https://api.github.com/users/carl-mastrangelo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carl-mastrangelo/subscriptions","organizations_url":"https://api.github.com/users/carl-mastrangelo/orgs","repos_url":"https://api.github.com/users/carl-mastrangelo/repos","events_url":"https://api.github.com/users/carl-mastrangelo/events{/privacy}","received_events_url":"https://api.github.com/users/carl-mastrangelo/received_events","type":"User","site_admin":false},"body":"This has a minor change in behavior in onSentBytes, where it will no call onReady unless it actually goes below the threshold.  Previously, if it was below the threshold, and then went even lower, onReady would be called.\r\n\r\nAddresses #24\r\n\r\nR= @nmittler ","created_at":"2015-07-14T20:28:00Z","updated_at":"2015-07-14T21:04:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4035f554d83399b1399c959c48f3b65e790784ae","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/grpc/grpc-java/pulls/625/commits","review_comments_url":"https://api.github.com/repos/grpc/grpc-java/pulls/625/comments","review_comment_url":"https://api.github.com/repos/grpc/grpc-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/grpc/grpc-java/issues/625/comments","statuses_url":"https://api.github.com/repos/grpc/grpc-java/statuses/6b650b8392a0da9e20f237c61bd1b3553be766fe","head":{"label":"carl-mastrangelo:eggplant","ref":"eggplant","sha":"6b650b8392a0da9e20f237c61bd1b3553be766fe","user":{"login":"carl-mastrangelo","id":8943572,"avatar_url":"https://avatars.githubusercontent.com/u/8943572?v=3","gravatar_id":"","url":"https://api.github.com/users/carl-mastrangelo","html_url":"https://github.com/carl-mastrangelo","followers_url":"https://api.github.com/users/carl-mastrangelo/followers","following_url":"https://api.github.com/users/carl-mastrangelo/following{/other_user}","gists_url":"https://api.github.com/users/carl-mastrangelo/gists{/gist_id}","starred_url":"https://api.github.com/users/carl-mastrangelo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carl-mastrangelo/subscriptions","organizations_url":"https://api.github.com/users/carl-mastrangelo/orgs","repos_url":"https://api.github.com/users/carl-mastrangelo/repos","events_url":"https://api.github.com/users/carl-mastrangelo/events{/privacy}","received_events_url":"https://api.github.com/users/carl-mastrangelo/received_events","type":"User","site_admin":false},"repo":{"id":38781678,"name":"grpc-java","full_name":"carl-mastrangelo/grpc-java","owner":{"login":"carl-mastrangelo","id":8943572,"avatar_url":"https://avatars.githubusercontent.com/u/8943572?v=3","gravatar_id":"","url":"https://api.github.com/users/carl-mastrangelo","html_url":"https://github.com/carl-mastrangelo","followers_url":"https://api.github.com/users/carl-mastrangelo/followers","following_url":"https://api.github.com/users/carl-mastrangelo/following{/other_user}","gists_url":"https://api.github.com/users/carl-mastrangelo/gists{/gist_id}","starred_url":"https://api.github.com/users/carl-mastrangelo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carl-mastrangelo/subscriptions","organizations_url":"https://api.github.com/users/carl-mastrangelo/orgs","repos_url":"https://api.github.com/users/carl-mastrangelo/repos","events_url":"https://api.github.com/users/carl-mastrangelo/events{/privacy}","received_events_url":"https://api.github.com/users/carl-mastrangelo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/carl-mastrangelo/grpc-java","description":"The Java gRPC implementation. HTTP/2 based RPC","fork":true,"url":"https://api.github.com/repos/carl-mastrangelo/grpc-java","forks_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/forks","keys_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/teams","hooks_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/hooks","issue_events_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/issues/events{/number}","events_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/events","assignees_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/assignees{/user}","branches_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/branches{/branch}","tags_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/tags","blobs_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/statuses/{sha}","languages_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/languages","stargazers_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/stargazers","contributors_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/contributors","subscribers_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/subscribers","subscription_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/subscription","commits_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/contents/{+path}","compare_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/merges","archive_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/downloads","issues_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/issues{/number}","pulls_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/pulls{/number}","milestones_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/milestones{/number}","notifications_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/labels{/name}","releases_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/releases{/id}","created_at":"2015-07-08T21:45:19Z","updated_at":"2015-07-08T21:45:20Z","pushed_at":"2015-07-14T21:02:20Z","git_url":"git://github.com/carl-mastrangelo/grpc-java.git","ssh_url":"git@github.com:carl-mastrangelo/grpc-java.git","clone_url":"https://github.com/carl-mastrangelo/grpc-java.git","svn_url":"https://github.com/carl-mastrangelo/grpc-java","homepage":"","size":2846,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"grpc:master","ref":"master","sha":"9c27540a4fc5302b730a7edd81bb9f9efadd2f54","user":{"login":"grpc","id":7802525,"avatar_url":"https://avatars.githubusercontent.com/u/7802525?v=3","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"repo":{"id":27729926,"name":"grpc-java","full_name":"grpc/grpc-java","owner":{"login":"grpc","id":7802525,"avatar_url":"https://avatars.githubusercontent.com/u/7802525?v=3","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/grpc/grpc-java","description":"The Java gRPC implementation. HTTP/2 based RPC","fork":false,"url":"https://api.github.com/repos/grpc/grpc-java","forks_url":"https://api.github.com/repos/grpc/grpc-java/forks","keys_url":"https://api.github.com/repos/grpc/grpc-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grpc/grpc-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grpc/grpc-java/teams","hooks_url":"https://api.github.com/repos/grpc/grpc-java/hooks","issue_events_url":"https://api.github.com/repos/grpc/grpc-java/issues/events{/number}","events_url":"https://api.github.com/repos/grpc/grpc-java/events","assignees_url":"https://api.github.com/repos/grpc/grpc-java/assignees{/user}","branches_url":"https://api.github.com/repos/grpc/grpc-java/branches{/branch}","tags_url":"https://api.github.com/repos/grpc/grpc-java/tags","blobs_url":"https://api.github.com/repos/grpc/grpc-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grpc/grpc-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grpc/grpc-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/grpc/grpc-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grpc/grpc-java/statuses/{sha}","languages_url":"https://api.github.com/repos/grpc/grpc-java/languages","stargazers_url":"https://api.github.com/repos/grpc/grpc-java/stargazers","contributors_url":"https://api.github.com/repos/grpc/grpc-java/contributors","subscribers_url":"https://api.github.com/repos/grpc/grpc-java/subscribers","subscription_url":"https://api.github.com/repos/grpc/grpc-java/subscription","commits_url":"https://api.github.com/repos/grpc/grpc-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/grpc/grpc-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/grpc/grpc-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/grpc/grpc-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/grpc/grpc-java/contents/{+path}","compare_url":"https://api.github.com/repos/grpc/grpc-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grpc/grpc-java/merges","archive_url":"https://api.github.com/repos/grpc/grpc-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grpc/grpc-java/downloads","issues_url":"https://api.github.com/repos/grpc/grpc-java/issues{/number}","pulls_url":"https://api.github.com/repos/grpc/grpc-java/pulls{/number}","milestones_url":"https://api.github.com/repos/grpc/grpc-java/milestones{/number}","notifications_url":"https://api.github.com/repos/grpc/grpc-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grpc/grpc-java/labels{/name}","releases_url":"https://api.github.com/repos/grpc/grpc-java/releases{/id}","created_at":"2014-12-08T19:00:00Z","updated_at":"2015-07-14T08:29:37Z","pushed_at":"2015-07-14T21:02:20Z","git_url":"git://github.com/grpc/grpc-java.git","ssh_url":"git@github.com:grpc/grpc-java.git","clone_url":"https://github.com/grpc/grpc-java.git","svn_url":"https://github.com/grpc/grpc-java","homepage":"","size":19215,"stargazers_count":781,"watchers_count":781,"language":"Java","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":177,"mirror_url":null,"open_issues_count":89,"forks":177,"open_issues":89,"watchers":781,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/625"},"html":{"href":"https://github.com/grpc/grpc-java/pull/625"},"issue":{"href":"https://api.github.com/repos/grpc/grpc-java/issues/625"},"comments":{"href":"https://api.github.com/repos/grpc/grpc-java/issues/625/comments"},"review_comments":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/625/comments"},"review_comment":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/625/commits"},"statuses":{"href":"https://api.github.com/repos/grpc/grpc-java/statuses/6b650b8392a0da9e20f237c61bd1b3553be766fe"}}}}