{"action":"created","comment":{"url":"https://api.github.com/repos/openmrs/openmrs-module-radiologydcm4chee/pulls/comments/34943911","id":34943911,"diff_hunk":"@@ -53,15 +63,28 @@\n \t\n \tprivate static final String NON_EXISTING_STUDY_INSTANCE_UID = \"1.2.826.0.1.3680043.8.2186.1.9999\";\n \t\n+\tprivate static final int EXISTING_STUDY_ID = 1;\n+\t\n+\tprivate static final String GLOBAL_PROPERTY_MWL_DIRECTORY = \"radiology.mwlDirectory\";","path":"api/src/test/java/org/openmrs/module/radiology/RadiologyServiceTest.java","position":37,"original_position":37,"commit_id":"9e439c47367895ac16dcaf465c90b31ed2d476c6","original_commit_id":"9e439c47367895ac16dcaf465c90b31ed2d476c6","user":{"login":"sunbiz","id":1017771,"avatar_url":"https://avatars.githubusercontent.com/u/1017771?v=3","gravatar_id":"","url":"https://api.github.com/users/sunbiz","html_url":"https://github.com/sunbiz","followers_url":"https://api.github.com/users/sunbiz/followers","following_url":"https://api.github.com/users/sunbiz/following{/other_user}","gists_url":"https://api.github.com/users/sunbiz/gists{/gist_id}","starred_url":"https://api.github.com/users/sunbiz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sunbiz/subscriptions","organizations_url":"https://api.github.com/users/sunbiz/orgs","repos_url":"https://api.github.com/users/sunbiz/repos","events_url":"https://api.github.com/users/sunbiz/events{/privacy}","received_events_url":"https://api.github.com/users/sunbiz/received_events","type":"User","site_admin":false},"body":"My point was why not store it in the Openmrs ApplicationDataDirectory. That way it becomes easier for the implementation to manage where all files are stored on the system","created_at":"2015-07-18T03:53:41Z","updated_at":"2015-07-18T03:53:41Z","html_url":"https://github.com/openmrs/openmrs-module-radiologydcm4chee/pull/91#discussion_r34943911","pull_request_url":"https://api.github.com/repos/openmrs/openmrs-module-radiologydcm4chee/pulls/91","_links":{"self":{"href":"https://api.github.com/repos/openmrs/openmrs-module-radiologydcm4chee/pulls/comments/34943911"},"html":{"href":"https://github.com/openmrs/openmrs-module-radiologydcm4chee/pull/91#discussion_r34943911"},"pull_request":{"href":"https://api.github.com/repos/openmrs/openmrs-module-radiologydcm4chee/pulls/91"}}},"pull_request":{"url":"https://api.github.com/repos/openmrs/openmrs-module-radiologydcm4chee/pulls/91","id":40217060,"html_url":"https://github.com/openmrs/openmrs-module-radiologydcm4chee/pull/91","diff_url":"https://github.com/openmrs/openmrs-module-radiologydcm4chee/pull/91.diff","patch_url":"https://github.com/openmrs/openmrs-module-radiologydcm4chee/pull/91.patch","issue_url":"https://api.github.com/repos/openmrs/openmrs-module-radiologydcm4chee/issues/91","number":91,"state":"open","locked":false,"title":"RAD-55 Add unit tests to RadiologyService.saveStudy(Study)","user":{"login":"teleivo","id":4661144,"avatar_url":"https://avatars.githubusercontent.com/u/4661144?v=3","gravatar_id":"","url":"https://api.github.com/users/teleivo","html_url":"https://github.com/teleivo","followers_url":"https://api.github.com/users/teleivo/followers","following_url":"https://api.github.com/users/teleivo/following{/other_user}","gists_url":"https://api.github.com/users/teleivo/gists{/gist_id}","starred_url":"https://api.github.com/users/teleivo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teleivo/subscriptions","organizations_url":"https://api.github.com/users/teleivo/orgs","repos_url":"https://api.github.com/users/teleivo/repos","events_url":"https://api.github.com/users/teleivo/events{/privacy}","received_events_url":"https://api.github.com/users/teleivo/received_events","type":"User","site_admin":false},"body":"* add unit tests for RadiologyService.saveStudy()\r\n* prevent saving a Study with no orderId or modality\r\n\r\nsee https://issues.openmrs.org/browse/RAD-55","created_at":"2015-07-17T10:07:18Z","updated_at":"2015-07-18T03:53:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9bd4edd26fb5eec5ffab6b3a96e05fe45142a7f9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openmrs/openmrs-module-radiologydcm4chee/pulls/91/commits","review_comments_url":"https://api.github.com/repos/openmrs/openmrs-module-radiologydcm4chee/pulls/91/comments","review_comment_url":"https://api.github.com/repos/openmrs/openmrs-module-radiologydcm4chee/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openmrs/openmrs-module-radiologydcm4chee/issues/91/comments","statuses_url":"https://api.github.com/repos/openmrs/openmrs-module-radiologydcm4chee/statuses/9e439c47367895ac16dcaf465c90b31ed2d476c6","head":{"label":"teleivo:RAD-55","ref":"RAD-55","sha":"9e439c47367895ac16dcaf465c90b31ed2d476c6","user":{"login":"teleivo","id":4661144,"avatar_url":"https://avatars.githubusercontent.com/u/4661144?v=3","gravatar_id":"","url":"https://api.github.com/users/teleivo","html_url":"https://github.com/teleivo","followers_url":"https://api.github.com/users/teleivo/followers","following_url":"https://api.github.com/users/teleivo/following{/other_user}","gists_url":"https://api.github.com/users/teleivo/gists{/gist_id}","starred_url":"https://api.github.com/users/teleivo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teleivo/subscriptions","organizations_url":"https://api.github.com/users/teleivo/orgs","repos_url":"https://api.github.com/users/teleivo/repos","events_url":"https://api.github.com/users/teleivo/events{/privacy}","received_events_url":"https://api.github.com/users/teleivo/received_events","type":"User","site_admin":false},"repo":{"id":31494383,"name":"openmrs-module-radiologydcm4chee","full_name":"teleivo/openmrs-module-radiologydcm4chee","owner":{"login":"teleivo","id":4661144,"avatar_url":"https://avatars.githubusercontent.com/u/4661144?v=3","gravatar_id":"","url":"https://api.github.com/users/teleivo","html_url":"https://github.com/teleivo","followers_url":"https://api.github.com/users/teleivo/followers","following_url":"https://api.github.com/users/teleivo/following{/other_user}","gists_url":"https://api.github.com/users/teleivo/gists{/gist_id}","starred_url":"https://api.github.com/users/teleivo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teleivo/subscriptions","organizations_url":"https://api.github.com/users/teleivo/orgs","repos_url":"https://api.github.com/users/teleivo/repos","events_url":"https://api.github.com/users/teleivo/events{/privacy}","received_events_url":"https://api.github.com/users/teleivo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/teleivo/openmrs-module-radiologydcm4chee","description":"OpenMRS Radiology Module with dcm4chee","fork":true,"url":"https://api.github.com/repos/teleivo/openmrs-module-radiologydcm4chee","forks_url":"https://api.github.com/repos/teleivo/openmrs-module-radiologydcm4chee/forks","keys_url":"https://api.github.com/repos/teleivo/openmrs-module-radiologydcm4chee/keys{/key_id}","collaborators_url":"https://api.github.com/repos/teleivo/openmrs-module-radiologydcm4chee/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/teleivo/openmrs-module-radiologydcm4chee/teams","hooks_url":"https://api.github.com/repos/teleivo/openmrs-module-radiologydcm4chee/hooks","issue_events_url":"https://api.github.com/repos/teleivo/openmrs-module-radiologydcm4chee/issues/events{/number}","events_url":"https://api.github.com/repos/teleivo/openmrs-module-radiologydcm4chee/events","assignees_url":"https://api.github.com/repos/teleivo/openmrs-module-radiologydcm4chee/assignees{/user}","branches_url":"https://api.github.com/repos/teleivo/openmrs-module-radiologydcm4chee/branches{/branch}","tags_url":"https://api.github.com/repos/teleivo/openmrs-module-radiologydcm4chee/tags","blobs_url":"https://api.github.com/repos/teleivo/openmrs-module-radiologydcm4chee/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/teleivo/openmrs-module-radiologydcm4chee/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/teleivo/openmrs-module-radiologydcm4chee/git/refs{/sha}","trees_url":"https://api.github.com/repos/teleivo/openmrs-module-radiologydcm4chee/git/trees{/sha}","statuses_url":"https://api.github.com/repos/teleivo/openmrs-module-radiologydcm4chee/statuses/{sha}","languages_url":"https://api.github.com/repos/teleivo/openmrs-module-radiologydcm4chee/languages","stargazers_url":"https://api.github.com/repos/teleivo/openmrs-module-radiologydcm4chee/stargazers","contributors_url":"https://api.github.com/repos/teleivo/openmrs-module-radiologydcm4chee/contributors","subscribers_url":"https://api.github.com/repos/teleivo/openmrs-module-radiologydcm4chee/subscribers","subscription_url":"https://api.github.com/repos/teleivo/openmrs-module-radiologydcm4chee/subscription","commits_url":"https://api.github.com/repos/teleivo/openmrs-module-radiologydcm4chee/commits{/sha}","git_commits_url":"https://api.github.com/repos/teleivo/openmrs-module-radiologydcm4chee/git/commits{/sha}","comments_url":"https://api.github.com/repos/teleivo/openmrs-module-radiologydcm4chee/comments{/number}","issue_comment_url":"https://api.github.com/repos/teleivo/openmrs-module-radiologydcm4chee/issues/comments{/number}","contents_url":"https://api.github.com/repos/teleivo/openmrs-module-radiologydcm4chee/contents/{+path}","compare_url":"https://api.github.com/repos/teleivo/openmrs-module-radiologydcm4chee/compare/{base}...{head}","merges_url":"https://api.github.com/repos/teleivo/openmrs-module-radiologydcm4chee/merges","archive_url":"https://api.github.com/repos/teleivo/openmrs-module-radiologydcm4chee/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/teleivo/openmrs-module-radiologydcm4chee/downloads","issues_url":"https://api.github.com/repos/teleivo/openmrs-module-radiologydcm4chee/issues{/number}","pulls_url":"https://api.github.com/repos/teleivo/openmrs-module-radiologydcm4chee/pulls{/number}","milestones_url":"https://api.github.com/repos/teleivo/openmrs-module-radiologydcm4chee/milestones{/number}","notifications_url":"https://api.github.com/repos/teleivo/openmrs-module-radiologydcm4chee/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/teleivo/openmrs-module-radiologydcm4chee/labels{/name}","releases_url":"https://api.github.com/repos/teleivo/openmrs-module-radiologydcm4chee/releases{/id}","created_at":"2015-03-01T11:17:34Z","updated_at":"2015-03-07T13:43:55Z","pushed_at":"2015-07-17T14:17:08Z","git_url":"git://github.com/teleivo/openmrs-module-radiologydcm4chee.git","ssh_url":"git@github.com:teleivo/openmrs-module-radiologydcm4chee.git","clone_url":"https://github.com/teleivo/openmrs-module-radiologydcm4chee.git","svn_url":"https://github.com/teleivo/openmrs-module-radiologydcm4chee","homepage":null,"size":71254,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openmrs:master","ref":"master","sha":"06e72e84768e9bc2c3e9a44136cd1a228d654e03","user":{"login":"openmrs","id":860776,"avatar_url":"https://avatars.githubusercontent.com/u/860776?v=3","gravatar_id":"","url":"https://api.github.com/users/openmrs","html_url":"https://github.com/openmrs","followers_url":"https://api.github.com/users/openmrs/followers","following_url":"https://api.github.com/users/openmrs/following{/other_user}","gists_url":"https://api.github.com/users/openmrs/gists{/gist_id}","starred_url":"https://api.github.com/users/openmrs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openmrs/subscriptions","organizations_url":"https://api.github.com/users/openmrs/orgs","repos_url":"https://api.github.com/users/openmrs/repos","events_url":"https://api.github.com/users/openmrs/events{/privacy}","received_events_url":"https://api.github.com/users/openmrs/received_events","type":"Organization","site_admin":false},"repo":{"id":13028147,"name":"openmrs-module-radiologydcm4chee","full_name":"openmrs/openmrs-module-radiologydcm4chee","owner":{"login":"openmrs","id":860776,"avatar_url":"https://avatars.githubusercontent.com/u/860776?v=3","gravatar_id":"","url":"https://api.github.com/users/openmrs","html_url":"https://github.com/openmrs","followers_url":"https://api.github.com/users/openmrs/followers","following_url":"https://api.github.com/users/openmrs/following{/other_user}","gists_url":"https://api.github.com/users/openmrs/gists{/gist_id}","starred_url":"https://api.github.com/users/openmrs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openmrs/subscriptions","organizations_url":"https://api.github.com/users/openmrs/orgs","repos_url":"https://api.github.com/users/openmrs/repos","events_url":"https://api.github.com/users/openmrs/events{/privacy}","received_events_url":"https://api.github.com/users/openmrs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openmrs/openmrs-module-radiologydcm4chee","description":"OpenMRS Radiology Module with dcm4chee","fork":false,"url":"https://api.github.com/repos/openmrs/openmrs-module-radiologydcm4chee","forks_url":"https://api.github.com/repos/openmrs/openmrs-module-radiologydcm4chee/forks","keys_url":"https://api.github.com/repos/openmrs/openmrs-module-radiologydcm4chee/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openmrs/openmrs-module-radiologydcm4chee/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openmrs/openmrs-module-radiologydcm4chee/teams","hooks_url":"https://api.github.com/repos/openmrs/openmrs-module-radiologydcm4chee/hooks","issue_events_url":"https://api.github.com/repos/openmrs/openmrs-module-radiologydcm4chee/issues/events{/number}","events_url":"https://api.github.com/repos/openmrs/openmrs-module-radiologydcm4chee/events","assignees_url":"https://api.github.com/repos/openmrs/openmrs-module-radiologydcm4chee/assignees{/user}","branches_url":"https://api.github.com/repos/openmrs/openmrs-module-radiologydcm4chee/branches{/branch}","tags_url":"https://api.github.com/repos/openmrs/openmrs-module-radiologydcm4chee/tags","blobs_url":"https://api.github.com/repos/openmrs/openmrs-module-radiologydcm4chee/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openmrs/openmrs-module-radiologydcm4chee/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openmrs/openmrs-module-radiologydcm4chee/git/refs{/sha}","trees_url":"https://api.github.com/repos/openmrs/openmrs-module-radiologydcm4chee/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openmrs/openmrs-module-radiologydcm4chee/statuses/{sha}","languages_url":"https://api.github.com/repos/openmrs/openmrs-module-radiologydcm4chee/languages","stargazers_url":"https://api.github.com/repos/openmrs/openmrs-module-radiologydcm4chee/stargazers","contributors_url":"https://api.github.com/repos/openmrs/openmrs-module-radiologydcm4chee/contributors","subscribers_url":"https://api.github.com/repos/openmrs/openmrs-module-radiologydcm4chee/subscribers","subscription_url":"https://api.github.com/repos/openmrs/openmrs-module-radiologydcm4chee/subscription","commits_url":"https://api.github.com/repos/openmrs/openmrs-module-radiologydcm4chee/commits{/sha}","git_commits_url":"https://api.github.com/repos/openmrs/openmrs-module-radiologydcm4chee/git/commits{/sha}","comments_url":"https://api.github.com/repos/openmrs/openmrs-module-radiologydcm4chee/comments{/number}","issue_comment_url":"https://api.github.com/repos/openmrs/openmrs-module-radiologydcm4chee/issues/comments{/number}","contents_url":"https://api.github.com/repos/openmrs/openmrs-module-radiologydcm4chee/contents/{+path}","compare_url":"https://api.github.com/repos/openmrs/openmrs-module-radiologydcm4chee/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openmrs/openmrs-module-radiologydcm4chee/merges","archive_url":"https://api.github.com/repos/openmrs/openmrs-module-radiologydcm4chee/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openmrs/openmrs-module-radiologydcm4chee/downloads","issues_url":"https://api.github.com/repos/openmrs/openmrs-module-radiologydcm4chee/issues{/number}","pulls_url":"https://api.github.com/repos/openmrs/openmrs-module-radiologydcm4chee/pulls{/number}","milestones_url":"https://api.github.com/repos/openmrs/openmrs-module-radiologydcm4chee/milestones{/number}","notifications_url":"https://api.github.com/repos/openmrs/openmrs-module-radiologydcm4chee/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openmrs/openmrs-module-radiologydcm4chee/labels{/name}","releases_url":"https://api.github.com/repos/openmrs/openmrs-module-radiologydcm4chee/releases{/id}","created_at":"2013-09-23T06:03:47Z","updated_at":"2015-06-22T15:24:05Z","pushed_at":"2015-07-17T14:17:08Z","git_url":"git://github.com/openmrs/openmrs-module-radiologydcm4chee.git","ssh_url":"git@github.com:openmrs/openmrs-module-radiologydcm4chee.git","clone_url":"https://github.com/openmrs/openmrs-module-radiologydcm4chee.git","svn_url":"https://github.com/openmrs/openmrs-module-radiologydcm4chee","homepage":null,"size":72799,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":2,"forks":12,"open_issues":2,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openmrs/openmrs-module-radiologydcm4chee/pulls/91"},"html":{"href":"https://github.com/openmrs/openmrs-module-radiologydcm4chee/pull/91"},"issue":{"href":"https://api.github.com/repos/openmrs/openmrs-module-radiologydcm4chee/issues/91"},"comments":{"href":"https://api.github.com/repos/openmrs/openmrs-module-radiologydcm4chee/issues/91/comments"},"review_comments":{"href":"https://api.github.com/repos/openmrs/openmrs-module-radiologydcm4chee/pulls/91/comments"},"review_comment":{"href":"https://api.github.com/repos/openmrs/openmrs-module-radiologydcm4chee/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openmrs/openmrs-module-radiologydcm4chee/pulls/91/commits"},"statuses":{"href":"https://api.github.com/repos/openmrs/openmrs-module-radiologydcm4chee/statuses/9e439c47367895ac16dcaf465c90b31ed2d476c6"}}}}