{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/logstash-performance-testing/pulls/comments/42546781","id":42546781,"diff_hunk":"@@ -18,9 +18,9 @@ class Runner\n \n     attr_reader :command\n \n-    def initialize(config, debug = false, logstash_home = Dir.pwd)\n+    def initialize(config, workers = \"1\", debug = false, logstash_home = Dir.pwd)","path":"lib/lsperfm/core/run.rb","position":5,"original_position":5,"commit_id":"671579ba8a58b55169c3d1e43b0aef1c06addd4d","original_commit_id":"671579ba8a58b55169c3d1e43b0aef1c06addd4d","user":{"login":"daph","id":151402,"avatar_url":"https://avatars.githubusercontent.com/u/151402?v=3","gravatar_id":"","url":"https://api.github.com/users/daph","html_url":"https://github.com/daph","followers_url":"https://api.github.com/users/daph/followers","following_url":"https://api.github.com/users/daph/following{/other_user}","gists_url":"https://api.github.com/users/daph/gists{/gist_id}","starred_url":"https://api.github.com/users/daph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daph/subscriptions","organizations_url":"https://api.github.com/users/daph/orgs","repos_url":"https://api.github.com/users/daph/repos","events_url":"https://api.github.com/users/daph/events{/privacy}","received_events_url":"https://api.github.com/users/daph/received_events","type":"User","site_admin":false},"body":"Yeah, the reason workers is a string here is because popen expects a string and fails if it's an integer. I suppose we could have it set to an int here and then call .to_s when setting the variable that gets sent to popen","created_at":"2015-10-20T20:09:39Z","updated_at":"2015-10-20T20:09:39Z","html_url":"https://github.com/elastic/logstash-performance-testing/pull/25#discussion_r42546781","pull_request_url":"https://api.github.com/repos/elastic/logstash-performance-testing/pulls/25","_links":{"self":{"href":"https://api.github.com/repos/elastic/logstash-performance-testing/pulls/comments/42546781"},"html":{"href":"https://github.com/elastic/logstash-performance-testing/pull/25#discussion_r42546781"},"pull_request":{"href":"https://api.github.com/repos/elastic/logstash-performance-testing/pulls/25"}}},"pull_request":{"url":"https://api.github.com/repos/elastic/logstash-performance-testing/pulls/25","id":47938595,"html_url":"https://github.com/elastic/logstash-performance-testing/pull/25","diff_url":"https://github.com/elastic/logstash-performance-testing/pull/25.diff","patch_url":"https://github.com/elastic/logstash-performance-testing/pull/25.patch","issue_url":"https://api.github.com/repos/elastic/logstash-performance-testing/issues/25","number":25,"state":"open","locked":false,"title":"Added ability to specifiy filter worker threads","user":{"login":"daph","id":151402,"avatar_url":"https://avatars.githubusercontent.com/u/151402?v=3","gravatar_id":"","url":"https://api.github.com/users/daph","html_url":"https://github.com/daph","followers_url":"https://api.github.com/users/daph/followers","following_url":"https://api.github.com/users/daph/following{/other_user}","gists_url":"https://api.github.com/users/daph/gists{/gist_id}","starred_url":"https://api.github.com/users/daph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daph/subscriptions","organizations_url":"https://api.github.com/users/daph/orgs","repos_url":"https://api.github.com/users/daph/repos","events_url":"https://api.github.com/users/daph/events{/privacy}","received_events_url":"https://api.github.com/users/daph/received_events","type":"User","site_admin":false},"body":"This change fixes issue #23 \r\n\r\nIt adds the ability to (optionally) specify the amount of worker threads for each test in a suite, by adding `:workers => N` to the test. If it's not there, it defaults to 1 worker, which is what logstash does by default itself if you don't specify `-w` to it.","created_at":"2015-10-16T17:37:31Z","updated_at":"2015-10-20T20:09:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d2d2e2273bfa29bda85803ce3abba955813a3036","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/elastic/logstash-performance-testing/pulls/25/commits","review_comments_url":"https://api.github.com/repos/elastic/logstash-performance-testing/pulls/25/comments","review_comment_url":"https://api.github.com/repos/elastic/logstash-performance-testing/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/logstash-performance-testing/issues/25/comments","statuses_url":"https://api.github.com/repos/elastic/logstash-performance-testing/statuses/671579ba8a58b55169c3d1e43b0aef1c06addd4d","head":{"label":"daph:master","ref":"master","sha":"671579ba8a58b55169c3d1e43b0aef1c06addd4d","user":{"login":"daph","id":151402,"avatar_url":"https://avatars.githubusercontent.com/u/151402?v=3","gravatar_id":"","url":"https://api.github.com/users/daph","html_url":"https://github.com/daph","followers_url":"https://api.github.com/users/daph/followers","following_url":"https://api.github.com/users/daph/following{/other_user}","gists_url":"https://api.github.com/users/daph/gists{/gist_id}","starred_url":"https://api.github.com/users/daph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daph/subscriptions","organizations_url":"https://api.github.com/users/daph/orgs","repos_url":"https://api.github.com/users/daph/repos","events_url":"https://api.github.com/users/daph/events{/privacy}","received_events_url":"https://api.github.com/users/daph/received_events","type":"User","site_admin":false},"repo":{"id":44338764,"name":"logstash-performance-testing","full_name":"daph/logstash-performance-testing","owner":{"login":"daph","id":151402,"avatar_url":"https://avatars.githubusercontent.com/u/151402?v=3","gravatar_id":"","url":"https://api.github.com/users/daph","html_url":"https://github.com/daph","followers_url":"https://api.github.com/users/daph/followers","following_url":"https://api.github.com/users/daph/following{/other_user}","gists_url":"https://api.github.com/users/daph/gists{/gist_id}","starred_url":"https://api.github.com/users/daph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daph/subscriptions","organizations_url":"https://api.github.com/users/daph/orgs","repos_url":"https://api.github.com/users/daph/repos","events_url":"https://api.github.com/users/daph/events{/privacy}","received_events_url":"https://api.github.com/users/daph/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/daph/logstash-performance-testing","description":"Logstash performance testing tool","fork":true,"url":"https://api.github.com/repos/daph/logstash-performance-testing","forks_url":"https://api.github.com/repos/daph/logstash-performance-testing/forks","keys_url":"https://api.github.com/repos/daph/logstash-performance-testing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/daph/logstash-performance-testing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/daph/logstash-performance-testing/teams","hooks_url":"https://api.github.com/repos/daph/logstash-performance-testing/hooks","issue_events_url":"https://api.github.com/repos/daph/logstash-performance-testing/issues/events{/number}","events_url":"https://api.github.com/repos/daph/logstash-performance-testing/events","assignees_url":"https://api.github.com/repos/daph/logstash-performance-testing/assignees{/user}","branches_url":"https://api.github.com/repos/daph/logstash-performance-testing/branches{/branch}","tags_url":"https://api.github.com/repos/daph/logstash-performance-testing/tags","blobs_url":"https://api.github.com/repos/daph/logstash-performance-testing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/daph/logstash-performance-testing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/daph/logstash-performance-testing/git/refs{/sha}","trees_url":"https://api.github.com/repos/daph/logstash-performance-testing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/daph/logstash-performance-testing/statuses/{sha}","languages_url":"https://api.github.com/repos/daph/logstash-performance-testing/languages","stargazers_url":"https://api.github.com/repos/daph/logstash-performance-testing/stargazers","contributors_url":"https://api.github.com/repos/daph/logstash-performance-testing/contributors","subscribers_url":"https://api.github.com/repos/daph/logstash-performance-testing/subscribers","subscription_url":"https://api.github.com/repos/daph/logstash-performance-testing/subscription","commits_url":"https://api.github.com/repos/daph/logstash-performance-testing/commits{/sha}","git_commits_url":"https://api.github.com/repos/daph/logstash-performance-testing/git/commits{/sha}","comments_url":"https://api.github.com/repos/daph/logstash-performance-testing/comments{/number}","issue_comment_url":"https://api.github.com/repos/daph/logstash-performance-testing/issues/comments{/number}","contents_url":"https://api.github.com/repos/daph/logstash-performance-testing/contents/{+path}","compare_url":"https://api.github.com/repos/daph/logstash-performance-testing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/daph/logstash-performance-testing/merges","archive_url":"https://api.github.com/repos/daph/logstash-performance-testing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/daph/logstash-performance-testing/downloads","issues_url":"https://api.github.com/repos/daph/logstash-performance-testing/issues{/number}","pulls_url":"https://api.github.com/repos/daph/logstash-performance-testing/pulls{/number}","milestones_url":"https://api.github.com/repos/daph/logstash-performance-testing/milestones{/number}","notifications_url":"https://api.github.com/repos/daph/logstash-performance-testing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/daph/logstash-performance-testing/labels{/name}","releases_url":"https://api.github.com/repos/daph/logstash-performance-testing/releases{/id}","created_at":"2015-10-15T18:57:43Z","updated_at":"2015-10-15T18:57:44Z","pushed_at":"2015-10-16T17:30:23Z","git_url":"git://github.com/daph/logstash-performance-testing.git","ssh_url":"git@github.com:daph/logstash-performance-testing.git","clone_url":"https://github.com/daph/logstash-performance-testing.git","svn_url":"https://github.com/daph/logstash-performance-testing","homepage":"https://www.elastic.co/products/logstash","size":137,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"f2968f9e521159af1500736757198e7fec3ec7fe","user":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":27456726,"name":"logstash-performance-testing","full_name":"elastic/logstash-performance-testing","owner":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/logstash-performance-testing","description":"Logstash performance testing tool","fork":false,"url":"https://api.github.com/repos/elastic/logstash-performance-testing","forks_url":"https://api.github.com/repos/elastic/logstash-performance-testing/forks","keys_url":"https://api.github.com/repos/elastic/logstash-performance-testing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/logstash-performance-testing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/logstash-performance-testing/teams","hooks_url":"https://api.github.com/repos/elastic/logstash-performance-testing/hooks","issue_events_url":"https://api.github.com/repos/elastic/logstash-performance-testing/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/logstash-performance-testing/events","assignees_url":"https://api.github.com/repos/elastic/logstash-performance-testing/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/logstash-performance-testing/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/logstash-performance-testing/tags","blobs_url":"https://api.github.com/repos/elastic/logstash-performance-testing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/logstash-performance-testing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/logstash-performance-testing/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/logstash-performance-testing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/logstash-performance-testing/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/logstash-performance-testing/languages","stargazers_url":"https://api.github.com/repos/elastic/logstash-performance-testing/stargazers","contributors_url":"https://api.github.com/repos/elastic/logstash-performance-testing/contributors","subscribers_url":"https://api.github.com/repos/elastic/logstash-performance-testing/subscribers","subscription_url":"https://api.github.com/repos/elastic/logstash-performance-testing/subscription","commits_url":"https://api.github.com/repos/elastic/logstash-performance-testing/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/logstash-performance-testing/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/logstash-performance-testing/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/logstash-performance-testing/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/logstash-performance-testing/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/logstash-performance-testing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/logstash-performance-testing/merges","archive_url":"https://api.github.com/repos/elastic/logstash-performance-testing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/logstash-performance-testing/downloads","issues_url":"https://api.github.com/repos/elastic/logstash-performance-testing/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/logstash-performance-testing/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/logstash-performance-testing/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/logstash-performance-testing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/logstash-performance-testing/labels{/name}","releases_url":"https://api.github.com/repos/elastic/logstash-performance-testing/releases{/id}","created_at":"2014-12-02T22:27:08Z","updated_at":"2015-10-08T04:24:36Z","pushed_at":"2015-10-20T13:38:36Z","git_url":"git://github.com/elastic/logstash-performance-testing.git","ssh_url":"git@github.com:elastic/logstash-performance-testing.git","clone_url":"https://github.com/elastic/logstash-performance-testing.git","svn_url":"https://github.com/elastic/logstash-performance-testing","homepage":"https://www.elastic.co/products/logstash","size":491,"stargazers_count":6,"watchers_count":6,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":10,"forks":9,"open_issues":10,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/logstash-performance-testing/pulls/25"},"html":{"href":"https://github.com/elastic/logstash-performance-testing/pull/25"},"issue":{"href":"https://api.github.com/repos/elastic/logstash-performance-testing/issues/25"},"comments":{"href":"https://api.github.com/repos/elastic/logstash-performance-testing/issues/25/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/logstash-performance-testing/pulls/25/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/logstash-performance-testing/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/logstash-performance-testing/pulls/25/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/logstash-performance-testing/statuses/671579ba8a58b55169c3d1e43b0aef1c06addd4d"}}}}