{"action":"created","comment":{"url":"https://api.github.com/repos/zendframework/modules.zendframework.com/pulls/comments/40177249","id":40177249,"diff_hunk":"@@ -4,28 +4,28 @@\n \n use Zend\\Mvc\\Controller\\AbstractActionController;\n use Zend\\View\\Model\\ViewModel;\n-use ZfModule\\Mapper;\n+use ZfModule\\Service;\n \n class SearchController extends AbstractActionController\n {\n     /**\n-     * @var Mapper\\Module\n+     * @var Service\\Module\n      */\n-    private $moduleMapper;\n+    private $moduleService;\n \n     /**\n-     * @param Mapper\\Module $moduleMapper\n+     * @param Service\\Module $moduleService\n      */\n-    public function __construct(Mapper\\Module $moduleMapper)\n+    public function __construct(Service\\Module $moduleService)\n     {\n-        $this->moduleMapper = $moduleMapper;\n+        $this->moduleService = $moduleService;\n     }\n \n     public function indexAction()\n     {\n         $query =  $this->params()->fromQuery('query', null);\n \n-        $results = $this->moduleMapper->findByLike($query);\n+        $results = $this->moduleService->findModules($query, ['m.name']);","path":"module/Application/src/Application/Controller/SearchController.php","position":32,"original_position":32,"commit_id":"cffd6880182194fec5265913106200bc0b3b7426","original_commit_id":"cffd6880182194fec5265913106200bc0b3b7426","user":{"login":"localheinz","id":605483,"avatar_url":"https://avatars.githubusercontent.com/u/605483?v=3","gravatar_id":"","url":"https://api.github.com/users/localheinz","html_url":"https://github.com/localheinz","followers_url":"https://api.github.com/users/localheinz/followers","following_url":"https://api.github.com/users/localheinz/following{/other_user}","gists_url":"https://api.github.com/users/localheinz/gists{/gist_id}","starred_url":"https://api.github.com/users/localheinz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/localheinz/subscriptions","organizations_url":"https://api.github.com/users/localheinz/orgs","repos_url":"https://api.github.com/users/localheinz/repos","events_url":"https://api.github.com/users/localheinz/events{/privacy}","received_events_url":"https://api.github.com/users/localheinz/received_events","type":"User","site_admin":false},"body":"@ins0 \r\n\r\nIt's probably better not to expose internals to much - so how about (if need be) exposing a method which fill find modules by name, specifically (if that's what it does)?\r\n","created_at":"2015-09-23T07:41:45Z","updated_at":"2015-09-23T07:41:45Z","html_url":"https://github.com/zendframework/modules.zendframework.com/pull/497#discussion_r40177249","pull_request_url":"https://api.github.com/repos/zendframework/modules.zendframework.com/pulls/497","_links":{"self":{"href":"https://api.github.com/repos/zendframework/modules.zendframework.com/pulls/comments/40177249"},"html":{"href":"https://github.com/zendframework/modules.zendframework.com/pull/497#discussion_r40177249"},"pull_request":{"href":"https://api.github.com/repos/zendframework/modules.zendframework.com/pulls/497"}}},"pull_request":{"url":"https://api.github.com/repos/zendframework/modules.zendframework.com/pulls/497","id":45465027,"html_url":"https://github.com/zendframework/modules.zendframework.com/pull/497","diff_url":"https://github.com/zendframework/modules.zendframework.com/pull/497.diff","patch_url":"https://github.com/zendframework/modules.zendframework.com/pull/497.patch","issue_url":"https://api.github.com/repos/zendframework/modules.zendframework.com/issues/497","number":497,"state":"open","locked":false,"title":"[WIP] Feature/doctrine","user":{"login":"ins0","id":2622534,"avatar_url":"https://avatars.githubusercontent.com/u/2622534?v=3","gravatar_id":"","url":"https://api.github.com/users/ins0","html_url":"https://github.com/ins0","followers_url":"https://api.github.com/users/ins0/followers","following_url":"https://api.github.com/users/ins0/following{/other_user}","gists_url":"https://api.github.com/users/ins0/gists{/gist_id}","starred_url":"https://api.github.com/users/ins0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ins0/subscriptions","organizations_url":"https://api.github.com/users/ins0/orgs","repos_url":"https://api.github.com/users/ins0/repos","events_url":"https://api.github.com/users/ins0/events{/privacy}","received_events_url":"https://api.github.com/users/ins0/received_events","type":"User","site_admin":false},"body":"This PR is adding Doctrine ORM to the Project and will replace the Zend\\Db Mappers.\r\nFollows after Discussion in #496 \r\n\r\n- [x] added doctrine\r\n- [x] added module entity\r\n- [ ] added user entity\r\n- [x] changed application module\r\n- [ ] changed user module\r\n- [ ] changed zfmodule module\r\n- [ ] remove old mapper\r\n- [ ] edit existing tests\r\n\r\n@localheinz @gianarb @Ocramius @GeeH ","created_at":"2015-09-19T00:17:29Z","updated_at":"2015-09-23T07:41:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4e46c81b9d4a73296901c7c61269a8faec97beef","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/zendframework/modules.zendframework.com/pulls/497/commits","review_comments_url":"https://api.github.com/repos/zendframework/modules.zendframework.com/pulls/497/comments","review_comment_url":"https://api.github.com/repos/zendframework/modules.zendframework.com/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zendframework/modules.zendframework.com/issues/497/comments","statuses_url":"https://api.github.com/repos/zendframework/modules.zendframework.com/statuses/cffd6880182194fec5265913106200bc0b3b7426","head":{"label":"ins0:feature/doctrine","ref":"feature/doctrine","sha":"cffd6880182194fec5265913106200bc0b3b7426","user":{"login":"ins0","id":2622534,"avatar_url":"https://avatars.githubusercontent.com/u/2622534?v=3","gravatar_id":"","url":"https://api.github.com/users/ins0","html_url":"https://github.com/ins0","followers_url":"https://api.github.com/users/ins0/followers","following_url":"https://api.github.com/users/ins0/following{/other_user}","gists_url":"https://api.github.com/users/ins0/gists{/gist_id}","starred_url":"https://api.github.com/users/ins0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ins0/subscriptions","organizations_url":"https://api.github.com/users/ins0/orgs","repos_url":"https://api.github.com/users/ins0/repos","events_url":"https://api.github.com/users/ins0/events{/privacy}","received_events_url":"https://api.github.com/users/ins0/received_events","type":"User","site_admin":false},"repo":{"id":27591329,"name":"modules.zendframework.com","full_name":"ins0/modules.zendframework.com","owner":{"login":"ins0","id":2622534,"avatar_url":"https://avatars.githubusercontent.com/u/2622534?v=3","gravatar_id":"","url":"https://api.github.com/users/ins0","html_url":"https://github.com/ins0","followers_url":"https://api.github.com/users/ins0/followers","following_url":"https://api.github.com/users/ins0/following{/other_user}","gists_url":"https://api.github.com/users/ins0/gists{/gist_id}","starred_url":"https://api.github.com/users/ins0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ins0/subscriptions","organizations_url":"https://api.github.com/users/ins0/orgs","repos_url":"https://api.github.com/users/ins0/repos","events_url":"https://api.github.com/users/ins0/events{/privacy}","received_events_url":"https://api.github.com/users/ins0/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ins0/modules.zendframework.com","description":"(Eventual) home for ZF2 module distribution","fork":true,"url":"https://api.github.com/repos/ins0/modules.zendframework.com","forks_url":"https://api.github.com/repos/ins0/modules.zendframework.com/forks","keys_url":"https://api.github.com/repos/ins0/modules.zendframework.com/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ins0/modules.zendframework.com/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ins0/modules.zendframework.com/teams","hooks_url":"https://api.github.com/repos/ins0/modules.zendframework.com/hooks","issue_events_url":"https://api.github.com/repos/ins0/modules.zendframework.com/issues/events{/number}","events_url":"https://api.github.com/repos/ins0/modules.zendframework.com/events","assignees_url":"https://api.github.com/repos/ins0/modules.zendframework.com/assignees{/user}","branches_url":"https://api.github.com/repos/ins0/modules.zendframework.com/branches{/branch}","tags_url":"https://api.github.com/repos/ins0/modules.zendframework.com/tags","blobs_url":"https://api.github.com/repos/ins0/modules.zendframework.com/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ins0/modules.zendframework.com/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ins0/modules.zendframework.com/git/refs{/sha}","trees_url":"https://api.github.com/repos/ins0/modules.zendframework.com/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ins0/modules.zendframework.com/statuses/{sha}","languages_url":"https://api.github.com/repos/ins0/modules.zendframework.com/languages","stargazers_url":"https://api.github.com/repos/ins0/modules.zendframework.com/stargazers","contributors_url":"https://api.github.com/repos/ins0/modules.zendframework.com/contributors","subscribers_url":"https://api.github.com/repos/ins0/modules.zendframework.com/subscribers","subscription_url":"https://api.github.com/repos/ins0/modules.zendframework.com/subscription","commits_url":"https://api.github.com/repos/ins0/modules.zendframework.com/commits{/sha}","git_commits_url":"https://api.github.com/repos/ins0/modules.zendframework.com/git/commits{/sha}","comments_url":"https://api.github.com/repos/ins0/modules.zendframework.com/comments{/number}","issue_comment_url":"https://api.github.com/repos/ins0/modules.zendframework.com/issues/comments{/number}","contents_url":"https://api.github.com/repos/ins0/modules.zendframework.com/contents/{+path}","compare_url":"https://api.github.com/repos/ins0/modules.zendframework.com/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ins0/modules.zendframework.com/merges","archive_url":"https://api.github.com/repos/ins0/modules.zendframework.com/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ins0/modules.zendframework.com/downloads","issues_url":"https://api.github.com/repos/ins0/modules.zendframework.com/issues{/number}","pulls_url":"https://api.github.com/repos/ins0/modules.zendframework.com/pulls{/number}","milestones_url":"https://api.github.com/repos/ins0/modules.zendframework.com/milestones{/number}","notifications_url":"https://api.github.com/repos/ins0/modules.zendframework.com/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ins0/modules.zendframework.com/labels{/name}","releases_url":"https://api.github.com/repos/ins0/modules.zendframework.com/releases{/id}","created_at":"2014-12-05T12:50:43Z","updated_at":"2015-03-06T13:09:11Z","pushed_at":"2015-09-19T00:12:30Z","git_url":"git://github.com/ins0/modules.zendframework.com.git","ssh_url":"git@github.com:ins0/modules.zendframework.com.git","clone_url":"https://github.com/ins0/modules.zendframework.com.git","svn_url":"https://github.com/ins0/modules.zendframework.com","homepage":"","size":4793,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zendframework:master","ref":"master","sha":"181856da991fbab13a732f677aaa4ac2e9f6489a","user":{"login":"zendframework","id":296074,"avatar_url":"https://avatars.githubusercontent.com/u/296074?v=3","gravatar_id":"","url":"https://api.github.com/users/zendframework","html_url":"https://github.com/zendframework","followers_url":"https://api.github.com/users/zendframework/followers","following_url":"https://api.github.com/users/zendframework/following{/other_user}","gists_url":"https://api.github.com/users/zendframework/gists{/gist_id}","starred_url":"https://api.github.com/users/zendframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zendframework/subscriptions","organizations_url":"https://api.github.com/users/zendframework/orgs","repos_url":"https://api.github.com/users/zendframework/repos","events_url":"https://api.github.com/users/zendframework/events{/privacy}","received_events_url":"https://api.github.com/users/zendframework/received_events","type":"Organization","site_admin":false},"repo":{"id":2652980,"name":"modules.zendframework.com","full_name":"zendframework/modules.zendframework.com","owner":{"login":"zendframework","id":296074,"avatar_url":"https://avatars.githubusercontent.com/u/296074?v=3","gravatar_id":"","url":"https://api.github.com/users/zendframework","html_url":"https://github.com/zendframework","followers_url":"https://api.github.com/users/zendframework/followers","following_url":"https://api.github.com/users/zendframework/following{/other_user}","gists_url":"https://api.github.com/users/zendframework/gists{/gist_id}","starred_url":"https://api.github.com/users/zendframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zendframework/subscriptions","organizations_url":"https://api.github.com/users/zendframework/orgs","repos_url":"https://api.github.com/users/zendframework/repos","events_url":"https://api.github.com/users/zendframework/events{/privacy}","received_events_url":"https://api.github.com/users/zendframework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zendframework/modules.zendframework.com","description":"Home for ZF2 module distribution","fork":false,"url":"https://api.github.com/repos/zendframework/modules.zendframework.com","forks_url":"https://api.github.com/repos/zendframework/modules.zendframework.com/forks","keys_url":"https://api.github.com/repos/zendframework/modules.zendframework.com/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zendframework/modules.zendframework.com/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zendframework/modules.zendframework.com/teams","hooks_url":"https://api.github.com/repos/zendframework/modules.zendframework.com/hooks","issue_events_url":"https://api.github.com/repos/zendframework/modules.zendframework.com/issues/events{/number}","events_url":"https://api.github.com/repos/zendframework/modules.zendframework.com/events","assignees_url":"https://api.github.com/repos/zendframework/modules.zendframework.com/assignees{/user}","branches_url":"https://api.github.com/repos/zendframework/modules.zendframework.com/branches{/branch}","tags_url":"https://api.github.com/repos/zendframework/modules.zendframework.com/tags","blobs_url":"https://api.github.com/repos/zendframework/modules.zendframework.com/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zendframework/modules.zendframework.com/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zendframework/modules.zendframework.com/git/refs{/sha}","trees_url":"https://api.github.com/repos/zendframework/modules.zendframework.com/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zendframework/modules.zendframework.com/statuses/{sha}","languages_url":"https://api.github.com/repos/zendframework/modules.zendframework.com/languages","stargazers_url":"https://api.github.com/repos/zendframework/modules.zendframework.com/stargazers","contributors_url":"https://api.github.com/repos/zendframework/modules.zendframework.com/contributors","subscribers_url":"https://api.github.com/repos/zendframework/modules.zendframework.com/subscribers","subscription_url":"https://api.github.com/repos/zendframework/modules.zendframework.com/subscription","commits_url":"https://api.github.com/repos/zendframework/modules.zendframework.com/commits{/sha}","git_commits_url":"https://api.github.com/repos/zendframework/modules.zendframework.com/git/commits{/sha}","comments_url":"https://api.github.com/repos/zendframework/modules.zendframework.com/comments{/number}","issue_comment_url":"https://api.github.com/repos/zendframework/modules.zendframework.com/issues/comments{/number}","contents_url":"https://api.github.com/repos/zendframework/modules.zendframework.com/contents/{+path}","compare_url":"https://api.github.com/repos/zendframework/modules.zendframework.com/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zendframework/modules.zendframework.com/merges","archive_url":"https://api.github.com/repos/zendframework/modules.zendframework.com/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zendframework/modules.zendframework.com/downloads","issues_url":"https://api.github.com/repos/zendframework/modules.zendframework.com/issues{/number}","pulls_url":"https://api.github.com/repos/zendframework/modules.zendframework.com/pulls{/number}","milestones_url":"https://api.github.com/repos/zendframework/modules.zendframework.com/milestones{/number}","notifications_url":"https://api.github.com/repos/zendframework/modules.zendframework.com/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zendframework/modules.zendframework.com/labels{/name}","releases_url":"https://api.github.com/repos/zendframework/modules.zendframework.com/releases{/id}","created_at":"2011-10-26T18:23:54Z","updated_at":"2015-09-17T06:58:44Z","pushed_at":"2015-09-19T15:26:24Z","git_url":"git://github.com/zendframework/modules.zendframework.com.git","ssh_url":"git@github.com:zendframework/modules.zendframework.com.git","clone_url":"https://github.com/zendframework/modules.zendframework.com.git","svn_url":"https://github.com/zendframework/modules.zendframework.com","homepage":"https://zfmodules.com","size":8179,"stargazers_count":193,"watchers_count":193,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":174,"mirror_url":null,"open_issues_count":33,"forks":174,"open_issues":33,"watchers":193,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zendframework/modules.zendframework.com/pulls/497"},"html":{"href":"https://github.com/zendframework/modules.zendframework.com/pull/497"},"issue":{"href":"https://api.github.com/repos/zendframework/modules.zendframework.com/issues/497"},"comments":{"href":"https://api.github.com/repos/zendframework/modules.zendframework.com/issues/497/comments"},"review_comments":{"href":"https://api.github.com/repos/zendframework/modules.zendframework.com/pulls/497/comments"},"review_comment":{"href":"https://api.github.com/repos/zendframework/modules.zendframework.com/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zendframework/modules.zendframework.com/pulls/497/commits"},"statuses":{"href":"https://api.github.com/repos/zendframework/modules.zendframework.com/statuses/cffd6880182194fec5265913106200bc0b3b7426"}}}}