{"action":"created","issue":{"url":"https://api.github.com/repos/glob3mobile/g3m/issues/153","labels_url":"https://api.github.com/repos/glob3mobile/g3m/issues/153/labels{/name}","comments_url":"https://api.github.com/repos/glob3mobile/g3m/issues/153/comments","events_url":"https://api.github.com/repos/glob3mobile/g3m/issues/153/events","html_url":"https://github.com/glob3mobile/g3m/pull/153","id":122003787,"number":153,"title":"Aeroglass features","user":{"login":"DrakkLord","id":7610117,"avatar_url":"https://avatars.githubusercontent.com/u/7610117?v=3","gravatar_id":"","url":"https://api.github.com/users/DrakkLord","html_url":"https://github.com/DrakkLord","followers_url":"https://api.github.com/users/DrakkLord/followers","following_url":"https://api.github.com/users/DrakkLord/following{/other_user}","gists_url":"https://api.github.com/users/DrakkLord/gists{/gist_id}","starred_url":"https://api.github.com/users/DrakkLord/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DrakkLord/subscriptions","organizations_url":"https://api.github.com/users/DrakkLord/orgs","repos_url":"https://api.github.com/users/DrakkLord/repos","events_url":"https://api.github.com/users/DrakkLord/events{/privacy}","received_events_url":"https://api.github.com/users/DrakkLord/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-12-14T09:24:56Z","updated_at":"2015-12-18T10:37:26Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/glob3mobile/g3m/pulls/153","html_url":"https://github.com/glob3mobile/g3m/pull/153","diff_url":"https://github.com/glob3mobile/g3m/pull/153.diff","patch_url":"https://github.com/glob3mobile/g3m/pull/153.patch"},"body":"Hi @DiegoGomezDeck !\r\n\r\nWe decided to not make pull requests on the aeroglass branch, instead we will make pull requests from individual feature branches, so here is branch with out current feature changes.\r\n\r\n---\r\n\r\n- fixed an invalid character in the iOS C++ source which causes a compile error with the generated java code in Android Studio under Windows 10\r\n- added Android Studio and Gradle specific things to .gitignore\r\n- added a feature to turn off FPS reduction for the android widget because we do the FPS reduction in our own code\r\n- reverted test commits made only to test the java converter\r\n- added a feature for android specific code to allow storing large files within the downlaod cache by saving them next to the database file, this is due to a problem coming from android's SQLite which crashes around 1-2Mb of blob size, this is a workaround by storing a the file name reference instead and saving the file externally\r\n- added a new GL feature which allows using custom opengl shader names and allows setting uniforms and attributes from that feature, also added code that makes sure that G3M does not try to set unrecognized attributes and/or uniforms\r\n- added feature to distinguish between shaders loaded by name and uniform / attribute keys\r\n\r\n---"},"comment":{"url":"https://api.github.com/repos/glob3mobile/g3m/issues/comments/165743865","html_url":"https://github.com/glob3mobile/g3m/pull/153#issuecomment-165743865","issue_url":"https://api.github.com/repos/glob3mobile/g3m/issues/153","id":165743865,"user":{"login":"amazingsmash","id":1220012,"avatar_url":"https://avatars.githubusercontent.com/u/1220012?v=3","gravatar_id":"","url":"https://api.github.com/users/amazingsmash","html_url":"https://github.com/amazingsmash","followers_url":"https://api.github.com/users/amazingsmash/followers","following_url":"https://api.github.com/users/amazingsmash/following{/other_user}","gists_url":"https://api.github.com/users/amazingsmash/gists{/gist_id}","starred_url":"https://api.github.com/users/amazingsmash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amazingsmash/subscriptions","organizations_url":"https://api.github.com/users/amazingsmash/orgs","repos_url":"https://api.github.com/users/amazingsmash/repos","events_url":"https://api.github.com/users/amazingsmash/events{/privacy}","received_events_url":"https://api.github.com/users/amazingsmash/received_events","type":"User","site_admin":false},"created_at":"2015-12-18T10:37:25Z","updated_at":"2015-12-18T10:37:25Z","body":"In general, I agree with @DiegoGomezDeck . The system should allow you to select any specific shader based on a unique set of entries. One of the main purposes of the whole shader mechanism is to ensure the consistency between the shader used and the provided information. Taking a look at the PR the GPUAttributeKey.UNRECOGNIZED_ATTRIBUTE seems to break that feature.\r\n\r\nOn the other hand, I agree with @DrakkLord that the system, at this moment, does not allow new shaders to be used. IG3MBuilder lacks a method to include new shaders, and the new variables of those shaders should be recognized properly via GPUVariable."}}