{"action":"created","issue":{"url":"https://api.github.com/repos/covermymeds/dbdeployer/issues/19","labels_url":"https://api.github.com/repos/covermymeds/dbdeployer/issues/19/labels{/name}","comments_url":"https://api.github.com/repos/covermymeds/dbdeployer/issues/19/comments","events_url":"https://api.github.com/repos/covermymeds/dbdeployer/issues/19/events","html_url":"https://github.com/covermymeds/dbdeployer/pull/19","id":113791435,"number":19,"title":"fixes no rows and allows use command substitution","user":{"login":"jpodonnell","id":10518682,"avatar_url":"https://avatars.githubusercontent.com/u/10518682?v=3","gravatar_id":"","url":"https://api.github.com/users/jpodonnell","html_url":"https://github.com/jpodonnell","followers_url":"https://api.github.com/users/jpodonnell/followers","following_url":"https://api.github.com/users/jpodonnell/following{/other_user}","gists_url":"https://api.github.com/users/jpodonnell/gists{/gist_id}","starred_url":"https://api.github.com/users/jpodonnell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpodonnell/subscriptions","organizations_url":"https://api.github.com/users/jpodonnell/orgs","repos_url":"https://api.github.com/users/jpodonnell/repos","events_url":"https://api.github.com/users/jpodonnell/events{/privacy}","received_events_url":"https://api.github.com/users/jpodonnell/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-10-28T10:53:50Z","updated_at":"2015-10-28T12:47:35Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/covermymeds/dbdeployer/pulls/19","html_url":"https://github.com/covermymeds/dbdeployer/pull/19","diff_url":"https://github.com/covermymeds/dbdeployer/pull/19.diff","patch_url":"https://github.com/covermymeds/dbdeployer/pull/19.patch"},"body":"This fixes the no rows affected in mssql, this also allows the use $(DBNAME) functionality to work by performing a substitution on the incoming file"},"comment":{"url":"https://api.github.com/repos/covermymeds/dbdeployer/issues/comments/151833130","html_url":"https://github.com/covermymeds/dbdeployer/pull/19#issuecomment-151833130","issue_url":"https://api.github.com/repos/covermymeds/dbdeployer/issues/19","id":151833130,"user":{"login":"cjestel","id":8523882,"avatar_url":"https://avatars.githubusercontent.com/u/8523882?v=3","gravatar_id":"","url":"https://api.github.com/users/cjestel","html_url":"https://github.com/cjestel","followers_url":"https://api.github.com/users/cjestel/followers","following_url":"https://api.github.com/users/cjestel/following{/other_user}","gists_url":"https://api.github.com/users/cjestel/gists{/gist_id}","starred_url":"https://api.github.com/users/cjestel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjestel/subscriptions","organizations_url":"https://api.github.com/users/cjestel/orgs","repos_url":"https://api.github.com/users/cjestel/repos","events_url":"https://api.github.com/users/cjestel/events{/privacy}","received_events_url":"https://api.github.com/users/cjestel/received_events","type":"User","site_admin":false},"created_at":"2015-10-28T12:47:35Z","updated_at":"2015-10-28T12:47:35Z","body":"With the abstraction of the sed stuff out to a new function, can you add a call to stuff that builds the temp file to the respective postgres file as well and have it reach out to the variable substitution function too as part of this change? I'm thinking we just set that function up to take the filename as a param. It would also give us that central place to add further substitution stuff in the future. I can see us adding a key value pair csv list in a command line option to allow extension of user defined interpretations on the fly as well. That would allow us to look through sed commands with all of the user defined stuff as well. You don't have to get that deep now, just thinking how we can set this up to easily support it in the future."}}