{"action":"created","issue":{"url":"https://api.github.com/repos/lpil/dogma/issues/72","labels_url":"https://api.github.com/repos/lpil/dogma/issues/72/labels{/name}","comments_url":"https://api.github.com/repos/lpil/dogma/issues/72/comments","events_url":"https://api.github.com/repos/lpil/dogma/issues/72/events","html_url":"https://github.com/lpil/dogma/pull/72","id":102228709,"number":72,"title":"Run rules on a script in parallel","user":{"login":"lpil","id":6134406,"avatar_url":"https://avatars.githubusercontent.com/u/6134406?v=3","gravatar_id":"","url":"https://api.github.com/users/lpil","html_url":"https://github.com/lpil","followers_url":"https://api.github.com/users/lpil/followers","following_url":"https://api.github.com/users/lpil/following{/other_user}","gists_url":"https://api.github.com/users/lpil/gists{/gist_id}","starred_url":"https://api.github.com/users/lpil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lpil/subscriptions","organizations_url":"https://api.github.com/users/lpil/orgs","repos_url":"https://api.github.com/users/lpil/repos","events_url":"https://api.github.com/users/lpil/events{/privacy}","received_events_url":"https://api.github.com/users/lpil/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/lpil/dogma/labels/Kind:%20Discussion","name":"Kind: Discussion","color":"ffb0cf"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-08-20T20:23:22Z","updated_at":"2015-08-21T07:20:24Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/lpil/dogma/pulls/72","html_url":"https://github.com/lpil/dogma/pull/72","diff_url":"https://github.com/lpil/dogma/pull/72.diff","patch_url":"https://github.com/lpil/dogma/pull/72.patch"},"body":"This actually seems to negatively impact performance...\r\n\r\nUsing [this](https://github.com/lpil/dogma/blob/master/bench/single_file_bench.exs) benchmark:\r\n\r\n| Bench     | Typical result |\r\n| --------- | -------------- |\r\n| Series    | 204.51 µs/op   |\r\n| Parallel  | 445.52 µs/op   |\r\n\r\nI guess we shouldn't run things in parallel when we're not actually doing anything that expensive? I think I may have made an assumption about the amount of computation required to make it break even, much like when I was playing with the `Stream` module.\r\n\r\nOr am I doing something wrong?\r\n\r\n@meadsteve @jonnyarnold"},"comment":{"url":"https://api.github.com/repos/lpil/dogma/issues/comments/133313614","html_url":"https://github.com/lpil/dogma/pull/72#issuecomment-133313614","issue_url":"https://api.github.com/repos/lpil/dogma/issues/72","id":133313614,"user":{"login":"meadsteve","id":1663120,"avatar_url":"https://avatars.githubusercontent.com/u/1663120?v=3","gravatar_id":"","url":"https://api.github.com/users/meadsteve","html_url":"https://github.com/meadsteve","followers_url":"https://api.github.com/users/meadsteve/followers","following_url":"https://api.github.com/users/meadsteve/following{/other_user}","gists_url":"https://api.github.com/users/meadsteve/gists{/gist_id}","starred_url":"https://api.github.com/users/meadsteve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meadsteve/subscriptions","organizations_url":"https://api.github.com/users/meadsteve/orgs","repos_url":"https://api.github.com/users/meadsteve/repos","events_url":"https://api.github.com/users/meadsteve/events{/privacy}","received_events_url":"https://api.github.com/users/meadsteve/received_events","type":"User","site_admin":false},"created_at":"2015-08-21T07:20:24Z","updated_at":"2015-08-21T07:20:24Z","body":"My first thought is that it may well be slower when the number of files is small. But once this gets larger and the files get larger I suspect the overhead of parallel will be outweighed by the benefit.\r\n\r\nMight be interesting to plot a graph of benchmark against number of files.\r\n\r\nI'll take a better look at the PR in the meantime though."}}