{"action":"created","issue":{"url":"https://api.github.com/repos/HiSPARC/pysparc/issues/18","labels_url":"https://api.github.com/repos/HiSPARC/pysparc/issues/18/labels{/name}","comments_url":"https://api.github.com/repos/HiSPARC/pysparc/issues/18/comments","events_url":"https://api.github.com/repos/HiSPARC/pysparc/issues/18/events","html_url":"https://github.com/HiSPARC/pysparc/pull/18","id":72390420,"number":18,"title":"Patch linesettings","user":{"login":"tomkooij","id":6316468,"avatar_url":"https://avatars.githubusercontent.com/u/6316468?v=3","gravatar_id":"","url":"https://api.github.com/users/tomkooij","html_url":"https://github.com/tomkooij","followers_url":"https://api.github.com/users/tomkooij/followers","following_url":"https://api.github.com/users/tomkooij/following{/other_user}","gists_url":"https://api.github.com/users/tomkooij/gists{/gist_id}","starred_url":"https://api.github.com/users/tomkooij/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomkooij/subscriptions","organizations_url":"https://api.github.com/users/tomkooij/orgs","repos_url":"https://api.github.com/users/tomkooij/repos","events_url":"https://api.github.com/users/tomkooij/events{/privacy}","received_events_url":"https://api.github.com/users/tomkooij/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"tomkooij","id":6316468,"avatar_url":"https://avatars.githubusercontent.com/u/6316468?v=3","gravatar_id":"","url":"https://api.github.com/users/tomkooij","html_url":"https://github.com/tomkooij","followers_url":"https://api.github.com/users/tomkooij/followers","following_url":"https://api.github.com/users/tomkooij/following{/other_user}","gists_url":"https://api.github.com/users/tomkooij/gists{/gist_id}","starred_url":"https://api.github.com/users/tomkooij/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomkooij/subscriptions","organizations_url":"https://api.github.com/users/tomkooij/orgs","repos_url":"https://api.github.com/users/tomkooij/repos","events_url":"https://api.github.com/users/tomkooij/events{/privacy}","received_events_url":"https://api.github.com/users/tomkooij/received_events","type":"User","site_admin":false},"milestone":null,"comments":9,"created_at":"2015-05-01T09:16:32Z","updated_at":"2015-05-13T18:26:27Z","closed_at":"2015-05-13T18:26:27Z","pull_request":{"url":"https://api.github.com/repos/HiSPARC/pysparc/pulls/18","html_url":"https://github.com/HiSPARC/pysparc/pull/18","diff_url":"https://github.com/HiSPARC/pysparc/pull/18.diff","patch_url":"https://github.com/HiSPARC/pysparc/pull/18.patch"},"body":"This is a patch to allow linesettings to be set in FtdiChip()\r\n\r\nThis sets default linesettings to 9600,8,N,1 using libftdi::ftdi_set_line_settings() , pylibftdi::Device() does not automatically set linesettings but relies on hardware? default linesettings. Dangerous!\r\n\r\nTrimble TSIP is supposed to be 9600,8,O,1 (odd parity). This is now set in TrimbleGPS() in hardware.py\r\n\r\nTodo:\r\n- [ ] Add unittest for default linesettings\r\n- [x] remove baudrate from linesettings. Baudrate is controlled by Device.baudrate property. ftdi_set_baudrate should *not* be called by Ftdi_chip().\r\n- [x] handle databits (7, 8). ~~For some reason ftdi_set_line_settings does not set databits.~~  Embarassing bug fixed in a2d760f\r\n- [x] Test trimble TSIP at 9600,8,O,1 using TrimbleGPS()\r\n"},"comment":{"url":"https://api.github.com/repos/HiSPARC/pysparc/issues/comments/101768016","html_url":"https://github.com/HiSPARC/pysparc/pull/18#issuecomment-101768016","issue_url":"https://api.github.com/repos/HiSPARC/pysparc/issues/18","id":101768016,"user":{"login":"davidfokkema","id":917137,"avatar_url":"https://avatars.githubusercontent.com/u/917137?v=3","gravatar_id":"","url":"https://api.github.com/users/davidfokkema","html_url":"https://github.com/davidfokkema","followers_url":"https://api.github.com/users/davidfokkema/followers","following_url":"https://api.github.com/users/davidfokkema/following{/other_user}","gists_url":"https://api.github.com/users/davidfokkema/gists{/gist_id}","starred_url":"https://api.github.com/users/davidfokkema/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidfokkema/subscriptions","organizations_url":"https://api.github.com/users/davidfokkema/orgs","repos_url":"https://api.github.com/users/davidfokkema/repos","events_url":"https://api.github.com/users/davidfokkema/events{/privacy}","received_events_url":"https://api.github.com/users/davidfokkema/received_events","type":"User","site_admin":false},"created_at":"2015-05-13T18:26:27Z","updated_at":"2015-05-13T18:26:27Z","body":"Merged into gps-messages. Thanks, Tom!"}}