{"action":"created","comment":{"url":"https://api.github.com/repos/http4s/http4s/pulls/comments/33111345","id":33111345,"diff_hunk":"@@ -3,7 +3,7 @@ package server\n package jetty\n \n import com.codahale.metrics.{InstrumentedExecutorService, MetricRegistry}\n-import com.codahale.metrics.jetty9.{InstrumentedQueuedThreadPool, InstrumentedConnectionFactory}\n+import com.codahale.metrics.jetty9.{InstrumentedQueuedThreadPool, InstrumentedHandler, InstrumentedConnectionFactory}","path":"jetty/src/main/scala/org/http4s/server/jetty/JettyBuilder.scala","position":5,"original_position":5,"commit_id":"534863fcdbb6dde02597111aae64eac28af0dcfa","original_commit_id":"534863fcdbb6dde02597111aae64eac28af0dcfa","user":{"login":"jonoabroad","id":99416,"avatar_url":"https://avatars.githubusercontent.com/u/99416?v=3","gravatar_id":"","url":"https://api.github.com/users/jonoabroad","html_url":"https://github.com/jonoabroad","followers_url":"https://api.github.com/users/jonoabroad/followers","following_url":"https://api.github.com/users/jonoabroad/following{/other_user}","gists_url":"https://api.github.com/users/jonoabroad/gists{/gist_id}","starred_url":"https://api.github.com/users/jonoabroad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonoabroad/subscriptions","organizations_url":"https://api.github.com/users/jonoabroad/orgs","repos_url":"https://api.github.com/users/jonoabroad/repos","events_url":"https://api.github.com/users/jonoabroad/events{/privacy}","received_events_url":"https://api.github.com/users/jonoabroad/received_events","type":"User","site_admin":false},"body":"Hmmm, I'm still getting the error on a fresh checkout.\r\n\r\n    $git log --pretty=oneline --abbrev-commit\r\n    39d674a Nope. It's still a snapshot.\r\n\r\n    $ sbt clean test\r\n    [info] Passed: Total 27, Failed 0, Errors 0, Passed 27\r\n    [error] (jetty/compile:compileIncremental) Compilation failed\r\n    [error] Total time: 149 s, completed 24/06/2015 11:46:22 AM\r\n\r\n","created_at":"2015-06-24T01:48:07Z","updated_at":"2015-06-24T01:48:07Z","html_url":"https://github.com/http4s/http4s/pull/309#discussion_r33111345","pull_request_url":"https://api.github.com/repos/http4s/http4s/pulls/309","_links":{"self":{"href":"https://api.github.com/repos/http4s/http4s/pulls/comments/33111345"},"html":{"href":"https://github.com/http4s/http4s/pull/309#discussion_r33111345"},"pull_request":{"href":"https://api.github.com/repos/http4s/http4s/pulls/309"}}},"pull_request":{"url":"https://api.github.com/repos/http4s/http4s/pulls/309","id":38307764,"html_url":"https://github.com/http4s/http4s/pull/309","diff_url":"https://github.com/http4s/http4s/pull/309.diff","patch_url":"https://github.com/http4s/http4s/pull/309.patch","issue_url":"https://api.github.com/repos/http4s/http4s/issues/309","number":309,"state":"open","locked":false,"title":"Issue/179","user":{"login":"jonoabroad","id":99416,"avatar_url":"https://avatars.githubusercontent.com/u/99416?v=3","gravatar_id":"","url":"https://api.github.com/users/jonoabroad","html_url":"https://github.com/jonoabroad","followers_url":"https://api.github.com/users/jonoabroad/followers","following_url":"https://api.github.com/users/jonoabroad/following{/other_user}","gists_url":"https://api.github.com/users/jonoabroad/gists{/gist_id}","starred_url":"https://api.github.com/users/jonoabroad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonoabroad/subscriptions","organizations_url":"https://api.github.com/users/jonoabroad/orgs","repos_url":"https://api.github.com/users/jonoabroad/repos","events_url":"https://api.github.com/users/jonoabroad/events{/privacy}","received_events_url":"https://api.github.com/users/jonoabroad/received_events","type":"User","site_admin":false},"body":"This provides multipart/form-data support.\r\n\r\nIt is worth noting that decode is using the parboiled2 parser which doesn't support Streaming or chunking and so the entire message body needs to be consumed before it can be parsed.\r\n\r\nI am going to look at alternatives to switch to which support chunked/stream parsing, but would value your feedback on the current implementation. \r\n\r\nThere are some tests and I've added to the example module, although only for the server. \r\n\r\nLet me know what feedback you have, in the meantime I am going to look at the following: \r\n  * https://github.com/tpolecat/atto\r\n  * https://github.com/djspiewak/sparse\r\n  * http://lakhin.com/projects/papa-carlo/\r\n","created_at":"2015-06-23T07:24:42Z","updated_at":"2015-06-24T01:48:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9a39f2414b0962dda47c84bc12879b560a0a7153","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/http4s/http4s/pulls/309/commits","review_comments_url":"https://api.github.com/repos/http4s/http4s/pulls/309/comments","review_comment_url":"https://api.github.com/repos/http4s/http4s/pulls/comments{/number}","comments_url":"https://api.github.com/repos/http4s/http4s/issues/309/comments","statuses_url":"https://api.github.com/repos/http4s/http4s/statuses/534863fcdbb6dde02597111aae64eac28af0dcfa","head":{"label":"jonoabroad:issue/179","ref":"issue/179","sha":"534863fcdbb6dde02597111aae64eac28af0dcfa","user":{"login":"jonoabroad","id":99416,"avatar_url":"https://avatars.githubusercontent.com/u/99416?v=3","gravatar_id":"","url":"https://api.github.com/users/jonoabroad","html_url":"https://github.com/jonoabroad","followers_url":"https://api.github.com/users/jonoabroad/followers","following_url":"https://api.github.com/users/jonoabroad/following{/other_user}","gists_url":"https://api.github.com/users/jonoabroad/gists{/gist_id}","starred_url":"https://api.github.com/users/jonoabroad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonoabroad/subscriptions","organizations_url":"https://api.github.com/users/jonoabroad/orgs","repos_url":"https://api.github.com/users/jonoabroad/repos","events_url":"https://api.github.com/users/jonoabroad/events{/privacy}","received_events_url":"https://api.github.com/users/jonoabroad/received_events","type":"User","site_admin":false},"repo":{"id":34775448,"name":"http4s","full_name":"jonoabroad/http4s","owner":{"login":"jonoabroad","id":99416,"avatar_url":"https://avatars.githubusercontent.com/u/99416?v=3","gravatar_id":"","url":"https://api.github.com/users/jonoabroad","html_url":"https://github.com/jonoabroad","followers_url":"https://api.github.com/users/jonoabroad/followers","following_url":"https://api.github.com/users/jonoabroad/following{/other_user}","gists_url":"https://api.github.com/users/jonoabroad/gists{/gist_id}","starred_url":"https://api.github.com/users/jonoabroad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonoabroad/subscriptions","organizations_url":"https://api.github.com/users/jonoabroad/orgs","repos_url":"https://api.github.com/users/jonoabroad/repos","events_url":"https://api.github.com/users/jonoabroad/events{/privacy}","received_events_url":"https://api.github.com/users/jonoabroad/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jonoabroad/http4s","description":"A minimal, idiomatic Scala interface for HTTP","fork":true,"url":"https://api.github.com/repos/jonoabroad/http4s","forks_url":"https://api.github.com/repos/jonoabroad/http4s/forks","keys_url":"https://api.github.com/repos/jonoabroad/http4s/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jonoabroad/http4s/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jonoabroad/http4s/teams","hooks_url":"https://api.github.com/repos/jonoabroad/http4s/hooks","issue_events_url":"https://api.github.com/repos/jonoabroad/http4s/issues/events{/number}","events_url":"https://api.github.com/repos/jonoabroad/http4s/events","assignees_url":"https://api.github.com/repos/jonoabroad/http4s/assignees{/user}","branches_url":"https://api.github.com/repos/jonoabroad/http4s/branches{/branch}","tags_url":"https://api.github.com/repos/jonoabroad/http4s/tags","blobs_url":"https://api.github.com/repos/jonoabroad/http4s/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jonoabroad/http4s/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jonoabroad/http4s/git/refs{/sha}","trees_url":"https://api.github.com/repos/jonoabroad/http4s/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jonoabroad/http4s/statuses/{sha}","languages_url":"https://api.github.com/repos/jonoabroad/http4s/languages","stargazers_url":"https://api.github.com/repos/jonoabroad/http4s/stargazers","contributors_url":"https://api.github.com/repos/jonoabroad/http4s/contributors","subscribers_url":"https://api.github.com/repos/jonoabroad/http4s/subscribers","subscription_url":"https://api.github.com/repos/jonoabroad/http4s/subscription","commits_url":"https://api.github.com/repos/jonoabroad/http4s/commits{/sha}","git_commits_url":"https://api.github.com/repos/jonoabroad/http4s/git/commits{/sha}","comments_url":"https://api.github.com/repos/jonoabroad/http4s/comments{/number}","issue_comment_url":"https://api.github.com/repos/jonoabroad/http4s/issues/comments{/number}","contents_url":"https://api.github.com/repos/jonoabroad/http4s/contents/{+path}","compare_url":"https://api.github.com/repos/jonoabroad/http4s/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jonoabroad/http4s/merges","archive_url":"https://api.github.com/repos/jonoabroad/http4s/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jonoabroad/http4s/downloads","issues_url":"https://api.github.com/repos/jonoabroad/http4s/issues{/number}","pulls_url":"https://api.github.com/repos/jonoabroad/http4s/pulls{/number}","milestones_url":"https://api.github.com/repos/jonoabroad/http4s/milestones{/number}","notifications_url":"https://api.github.com/repos/jonoabroad/http4s/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jonoabroad/http4s/labels{/name}","releases_url":"https://api.github.com/repos/jonoabroad/http4s/releases{/id}","created_at":"2015-04-29T06:06:50Z","updated_at":"2015-04-29T06:06:52Z","pushed_at":"2015-06-23T05:45:58Z","git_url":"git://github.com/jonoabroad/http4s.git","ssh_url":"git@github.com:jonoabroad/http4s.git","clone_url":"https://github.com/jonoabroad/http4s.git","svn_url":"https://github.com/jonoabroad/http4s","homepage":"http://http4s.org/","size":10229,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"http4s:master","ref":"master","sha":"39d674a5d4962733ece4d3a42caacadda353be75","user":{"login":"http4s","id":1527492,"avatar_url":"https://avatars.githubusercontent.com/u/1527492?v=3","gravatar_id":"","url":"https://api.github.com/users/http4s","html_url":"https://github.com/http4s","followers_url":"https://api.github.com/users/http4s/followers","following_url":"https://api.github.com/users/http4s/following{/other_user}","gists_url":"https://api.github.com/users/http4s/gists{/gist_id}","starred_url":"https://api.github.com/users/http4s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/http4s/subscriptions","organizations_url":"https://api.github.com/users/http4s/orgs","repos_url":"https://api.github.com/users/http4s/repos","events_url":"https://api.github.com/users/http4s/events{/privacy}","received_events_url":"https://api.github.com/users/http4s/received_events","type":"Organization","site_admin":false},"repo":{"id":3692188,"name":"http4s","full_name":"http4s/http4s","owner":{"login":"http4s","id":1527492,"avatar_url":"https://avatars.githubusercontent.com/u/1527492?v=3","gravatar_id":"","url":"https://api.github.com/users/http4s","html_url":"https://github.com/http4s","followers_url":"https://api.github.com/users/http4s/followers","following_url":"https://api.github.com/users/http4s/following{/other_user}","gists_url":"https://api.github.com/users/http4s/gists{/gist_id}","starred_url":"https://api.github.com/users/http4s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/http4s/subscriptions","organizations_url":"https://api.github.com/users/http4s/orgs","repos_url":"https://api.github.com/users/http4s/repos","events_url":"https://api.github.com/users/http4s/events{/privacy}","received_events_url":"https://api.github.com/users/http4s/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/http4s/http4s","description":"A minimal, idiomatic Scala interface for HTTP","fork":false,"url":"https://api.github.com/repos/http4s/http4s","forks_url":"https://api.github.com/repos/http4s/http4s/forks","keys_url":"https://api.github.com/repos/http4s/http4s/keys{/key_id}","collaborators_url":"https://api.github.com/repos/http4s/http4s/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/http4s/http4s/teams","hooks_url":"https://api.github.com/repos/http4s/http4s/hooks","issue_events_url":"https://api.github.com/repos/http4s/http4s/issues/events{/number}","events_url":"https://api.github.com/repos/http4s/http4s/events","assignees_url":"https://api.github.com/repos/http4s/http4s/assignees{/user}","branches_url":"https://api.github.com/repos/http4s/http4s/branches{/branch}","tags_url":"https://api.github.com/repos/http4s/http4s/tags","blobs_url":"https://api.github.com/repos/http4s/http4s/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/http4s/http4s/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/http4s/http4s/git/refs{/sha}","trees_url":"https://api.github.com/repos/http4s/http4s/git/trees{/sha}","statuses_url":"https://api.github.com/repos/http4s/http4s/statuses/{sha}","languages_url":"https://api.github.com/repos/http4s/http4s/languages","stargazers_url":"https://api.github.com/repos/http4s/http4s/stargazers","contributors_url":"https://api.github.com/repos/http4s/http4s/contributors","subscribers_url":"https://api.github.com/repos/http4s/http4s/subscribers","subscription_url":"https://api.github.com/repos/http4s/http4s/subscription","commits_url":"https://api.github.com/repos/http4s/http4s/commits{/sha}","git_commits_url":"https://api.github.com/repos/http4s/http4s/git/commits{/sha}","comments_url":"https://api.github.com/repos/http4s/http4s/comments{/number}","issue_comment_url":"https://api.github.com/repos/http4s/http4s/issues/comments{/number}","contents_url":"https://api.github.com/repos/http4s/http4s/contents/{+path}","compare_url":"https://api.github.com/repos/http4s/http4s/compare/{base}...{head}","merges_url":"https://api.github.com/repos/http4s/http4s/merges","archive_url":"https://api.github.com/repos/http4s/http4s/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/http4s/http4s/downloads","issues_url":"https://api.github.com/repos/http4s/http4s/issues{/number}","pulls_url":"https://api.github.com/repos/http4s/http4s/pulls{/number}","milestones_url":"https://api.github.com/repos/http4s/http4s/milestones{/number}","notifications_url":"https://api.github.com/repos/http4s/http4s/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/http4s/http4s/labels{/name}","releases_url":"https://api.github.com/repos/http4s/http4s/releases{/id}","created_at":"2012-03-12T04:41:20Z","updated_at":"2015-06-22T19:31:24Z","pushed_at":"2015-06-23T23:47:37Z","git_url":"git://github.com/http4s/http4s.git","ssh_url":"git@github.com:http4s/http4s.git","clone_url":"https://github.com/http4s/http4s.git","svn_url":"https://github.com/http4s/http4s","homepage":"http://http4s.org/","size":16722,"stargazers_count":262,"watchers_count":262,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":49,"mirror_url":null,"open_issues_count":32,"forks":49,"open_issues":32,"watchers":262,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/http4s/http4s/pulls/309"},"html":{"href":"https://github.com/http4s/http4s/pull/309"},"issue":{"href":"https://api.github.com/repos/http4s/http4s/issues/309"},"comments":{"href":"https://api.github.com/repos/http4s/http4s/issues/309/comments"},"review_comments":{"href":"https://api.github.com/repos/http4s/http4s/pulls/309/comments"},"review_comment":{"href":"https://api.github.com/repos/http4s/http4s/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/http4s/http4s/pulls/309/commits"},"statuses":{"href":"https://api.github.com/repos/http4s/http4s/statuses/534863fcdbb6dde02597111aae64eac28af0dcfa"}}}}