{"action":"created","comment":{"url":"https://api.github.com/repos/solidusio/solidus_signifyd/pulls/comments/41467646","id":41467646,"diff_hunk":"@@ -20,7 +20,7 @@ def set_score(order:, score:)\n \n   def approve(order:)\n     order.contents.approve(name: self.name)\n-    order.shipments.each { |shipment| shipment.ready! unless shipment.ready? }\n+    order.shipments.each(&:ready!)\n     order.updater.update_shipment_state\n     order.save!\n   end","path":"lib/spree_signifyd.rb","position":8,"original_position":8,"commit_id":"c8a1cb3f33faa59c2262e0e27eab4dbf47344e19","original_commit_id":"c8a1cb3f33faa59c2262e0e27eab4dbf47344e19","user":{"login":"magnusvk","id":704153,"avatar_url":"https://avatars.githubusercontent.com/u/704153?v=3","gravatar_id":"","url":"https://api.github.com/users/magnusvk","html_url":"https://github.com/magnusvk","followers_url":"https://api.github.com/users/magnusvk/followers","following_url":"https://api.github.com/users/magnusvk/following{/other_user}","gists_url":"https://api.github.com/users/magnusvk/gists{/gist_id}","starred_url":"https://api.github.com/users/magnusvk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magnusvk/subscriptions","organizations_url":"https://api.github.com/users/magnusvk/orgs","repos_url":"https://api.github.com/users/magnusvk/repos","events_url":"https://api.github.com/users/magnusvk/events{/privacy}","received_events_url":"https://api.github.com/users/magnusvk/received_events","type":"User","site_admin":false},"body":"This whole method in my mind really isn't Signifyd-specific, and I wonder if there's a better place for it in Solidus somewhere.","created_at":"2015-10-08T01:18:43Z","updated_at":"2015-10-08T01:18:43Z","html_url":"https://github.com/solidusio/solidus_signifyd/pull/9#discussion_r41467646","pull_request_url":"https://api.github.com/repos/solidusio/solidus_signifyd/pulls/9","_links":{"self":{"href":"https://api.github.com/repos/solidusio/solidus_signifyd/pulls/comments/41467646"},"html":{"href":"https://github.com/solidusio/solidus_signifyd/pull/9#discussion_r41467646"},"pull_request":{"href":"https://api.github.com/repos/solidusio/solidus_signifyd/pulls/9"}}},"pull_request":{"url":"https://api.github.com/repos/solidusio/solidus_signifyd/pulls/9","id":47078464,"html_url":"https://github.com/solidusio/solidus_signifyd/pull/9","diff_url":"https://github.com/solidusio/solidus_signifyd/pull/9.diff","patch_url":"https://github.com/solidusio/solidus_signifyd/pull/9.patch","issue_url":"https://api.github.com/repos/solidusio/solidus_signifyd/issues/9","number":9,"state":"open","locked":false,"title":"tell shipments ready! without asking if they already are first","user":{"login":"gvaughn","id":10173,"avatar_url":"https://avatars.githubusercontent.com/u/10173?v=3","gravatar_id":"","url":"https://api.github.com/users/gvaughn","html_url":"https://github.com/gvaughn","followers_url":"https://api.github.com/users/gvaughn/followers","following_url":"https://api.github.com/users/gvaughn/following{/other_user}","gists_url":"https://api.github.com/users/gvaughn/gists{/gist_id}","starred_url":"https://api.github.com/users/gvaughn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gvaughn/subscriptions","organizations_url":"https://api.github.com/users/gvaughn/orgs","repos_url":"https://api.github.com/users/gvaughn/repos","events_url":"https://api.github.com/users/gvaughn/events{/privacy}","received_events_url":"https://api.github.com/users/gvaughn/received_events","type":"User","site_admin":false},"body":"This other solidus PR needs to go first: https://github.com/solidusio/solidus/pull/424","created_at":"2015-10-07T20:35:25Z","updated_at":"2015-10-08T01:18:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ea1a3d227b4ea419017f2918c14b42a8455b178c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/solidusio/solidus_signifyd/pulls/9/commits","review_comments_url":"https://api.github.com/repos/solidusio/solidus_signifyd/pulls/9/comments","review_comment_url":"https://api.github.com/repos/solidusio/solidus_signifyd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/solidusio/solidus_signifyd/issues/9/comments","statuses_url":"https://api.github.com/repos/solidusio/solidus_signifyd/statuses/c8a1cb3f33faa59c2262e0e27eab4dbf47344e19","head":{"label":"gvaughn:tell_dont_ask","ref":"tell_dont_ask","sha":"c8a1cb3f33faa59c2262e0e27eab4dbf47344e19","user":{"login":"gvaughn","id":10173,"avatar_url":"https://avatars.githubusercontent.com/u/10173?v=3","gravatar_id":"","url":"https://api.github.com/users/gvaughn","html_url":"https://github.com/gvaughn","followers_url":"https://api.github.com/users/gvaughn/followers","following_url":"https://api.github.com/users/gvaughn/following{/other_user}","gists_url":"https://api.github.com/users/gvaughn/gists{/gist_id}","starred_url":"https://api.github.com/users/gvaughn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gvaughn/subscriptions","organizations_url":"https://api.github.com/users/gvaughn/orgs","repos_url":"https://api.github.com/users/gvaughn/repos","events_url":"https://api.github.com/users/gvaughn/events{/privacy}","received_events_url":"https://api.github.com/users/gvaughn/received_events","type":"User","site_admin":false},"repo":{"id":43843215,"name":"solidus_signifyd","full_name":"gvaughn/solidus_signifyd","owner":{"login":"gvaughn","id":10173,"avatar_url":"https://avatars.githubusercontent.com/u/10173?v=3","gravatar_id":"","url":"https://api.github.com/users/gvaughn","html_url":"https://github.com/gvaughn","followers_url":"https://api.github.com/users/gvaughn/followers","following_url":"https://api.github.com/users/gvaughn/following{/other_user}","gists_url":"https://api.github.com/users/gvaughn/gists{/gist_id}","starred_url":"https://api.github.com/users/gvaughn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gvaughn/subscriptions","organizations_url":"https://api.github.com/users/gvaughn/orgs","repos_url":"https://api.github.com/users/gvaughn/repos","events_url":"https://api.github.com/users/gvaughn/events{/privacy}","received_events_url":"https://api.github.com/users/gvaughn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gvaughn/solidus_signifyd","description":"Solidus integration with Signifyd fraud check service","fork":true,"url":"https://api.github.com/repos/gvaughn/solidus_signifyd","forks_url":"https://api.github.com/repos/gvaughn/solidus_signifyd/forks","keys_url":"https://api.github.com/repos/gvaughn/solidus_signifyd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gvaughn/solidus_signifyd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gvaughn/solidus_signifyd/teams","hooks_url":"https://api.github.com/repos/gvaughn/solidus_signifyd/hooks","issue_events_url":"https://api.github.com/repos/gvaughn/solidus_signifyd/issues/events{/number}","events_url":"https://api.github.com/repos/gvaughn/solidus_signifyd/events","assignees_url":"https://api.github.com/repos/gvaughn/solidus_signifyd/assignees{/user}","branches_url":"https://api.github.com/repos/gvaughn/solidus_signifyd/branches{/branch}","tags_url":"https://api.github.com/repos/gvaughn/solidus_signifyd/tags","blobs_url":"https://api.github.com/repos/gvaughn/solidus_signifyd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gvaughn/solidus_signifyd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gvaughn/solidus_signifyd/git/refs{/sha}","trees_url":"https://api.github.com/repos/gvaughn/solidus_signifyd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gvaughn/solidus_signifyd/statuses/{sha}","languages_url":"https://api.github.com/repos/gvaughn/solidus_signifyd/languages","stargazers_url":"https://api.github.com/repos/gvaughn/solidus_signifyd/stargazers","contributors_url":"https://api.github.com/repos/gvaughn/solidus_signifyd/contributors","subscribers_url":"https://api.github.com/repos/gvaughn/solidus_signifyd/subscribers","subscription_url":"https://api.github.com/repos/gvaughn/solidus_signifyd/subscription","commits_url":"https://api.github.com/repos/gvaughn/solidus_signifyd/commits{/sha}","git_commits_url":"https://api.github.com/repos/gvaughn/solidus_signifyd/git/commits{/sha}","comments_url":"https://api.github.com/repos/gvaughn/solidus_signifyd/comments{/number}","issue_comment_url":"https://api.github.com/repos/gvaughn/solidus_signifyd/issues/comments{/number}","contents_url":"https://api.github.com/repos/gvaughn/solidus_signifyd/contents/{+path}","compare_url":"https://api.github.com/repos/gvaughn/solidus_signifyd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gvaughn/solidus_signifyd/merges","archive_url":"https://api.github.com/repos/gvaughn/solidus_signifyd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gvaughn/solidus_signifyd/downloads","issues_url":"https://api.github.com/repos/gvaughn/solidus_signifyd/issues{/number}","pulls_url":"https://api.github.com/repos/gvaughn/solidus_signifyd/pulls{/number}","milestones_url":"https://api.github.com/repos/gvaughn/solidus_signifyd/milestones{/number}","notifications_url":"https://api.github.com/repos/gvaughn/solidus_signifyd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gvaughn/solidus_signifyd/labels{/name}","releases_url":"https://api.github.com/repos/gvaughn/solidus_signifyd/releases{/id}","created_at":"2015-10-07T20:34:21Z","updated_at":"2015-10-07T20:34:22Z","pushed_at":"2015-10-07T20:34:45Z","git_url":"git://github.com/gvaughn/solidus_signifyd.git","ssh_url":"git@github.com:gvaughn/solidus_signifyd.git","clone_url":"https://github.com/gvaughn/solidus_signifyd.git","svn_url":"https://github.com/gvaughn/solidus_signifyd","homepage":"","size":254,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"solidusio:master","ref":"master","sha":"201d9f13eee2d2b3c8ee546183765ade235d2202","user":{"login":"solidusio","id":11045486,"avatar_url":"https://avatars.githubusercontent.com/u/11045486?v=3","gravatar_id":"","url":"https://api.github.com/users/solidusio","html_url":"https://github.com/solidusio","followers_url":"https://api.github.com/users/solidusio/followers","following_url":"https://api.github.com/users/solidusio/following{/other_user}","gists_url":"https://api.github.com/users/solidusio/gists{/gist_id}","starred_url":"https://api.github.com/users/solidusio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solidusio/subscriptions","organizations_url":"https://api.github.com/users/solidusio/orgs","repos_url":"https://api.github.com/users/solidusio/repos","events_url":"https://api.github.com/users/solidusio/events{/privacy}","received_events_url":"https://api.github.com/users/solidusio/received_events","type":"Organization","site_admin":false},"repo":{"id":36316622,"name":"solidus_signifyd","full_name":"solidusio/solidus_signifyd","owner":{"login":"solidusio","id":11045486,"avatar_url":"https://avatars.githubusercontent.com/u/11045486?v=3","gravatar_id":"","url":"https://api.github.com/users/solidusio","html_url":"https://github.com/solidusio","followers_url":"https://api.github.com/users/solidusio/followers","following_url":"https://api.github.com/users/solidusio/following{/other_user}","gists_url":"https://api.github.com/users/solidusio/gists{/gist_id}","starred_url":"https://api.github.com/users/solidusio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solidusio/subscriptions","organizations_url":"https://api.github.com/users/solidusio/orgs","repos_url":"https://api.github.com/users/solidusio/repos","events_url":"https://api.github.com/users/solidusio/events{/privacy}","received_events_url":"https://api.github.com/users/solidusio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/solidusio/solidus_signifyd","description":"Solidus integration with Signifyd fraud check service","fork":false,"url":"https://api.github.com/repos/solidusio/solidus_signifyd","forks_url":"https://api.github.com/repos/solidusio/solidus_signifyd/forks","keys_url":"https://api.github.com/repos/solidusio/solidus_signifyd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/solidusio/solidus_signifyd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/solidusio/solidus_signifyd/teams","hooks_url":"https://api.github.com/repos/solidusio/solidus_signifyd/hooks","issue_events_url":"https://api.github.com/repos/solidusio/solidus_signifyd/issues/events{/number}","events_url":"https://api.github.com/repos/solidusio/solidus_signifyd/events","assignees_url":"https://api.github.com/repos/solidusio/solidus_signifyd/assignees{/user}","branches_url":"https://api.github.com/repos/solidusio/solidus_signifyd/branches{/branch}","tags_url":"https://api.github.com/repos/solidusio/solidus_signifyd/tags","blobs_url":"https://api.github.com/repos/solidusio/solidus_signifyd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/solidusio/solidus_signifyd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/solidusio/solidus_signifyd/git/refs{/sha}","trees_url":"https://api.github.com/repos/solidusio/solidus_signifyd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/solidusio/solidus_signifyd/statuses/{sha}","languages_url":"https://api.github.com/repos/solidusio/solidus_signifyd/languages","stargazers_url":"https://api.github.com/repos/solidusio/solidus_signifyd/stargazers","contributors_url":"https://api.github.com/repos/solidusio/solidus_signifyd/contributors","subscribers_url":"https://api.github.com/repos/solidusio/solidus_signifyd/subscribers","subscription_url":"https://api.github.com/repos/solidusio/solidus_signifyd/subscription","commits_url":"https://api.github.com/repos/solidusio/solidus_signifyd/commits{/sha}","git_commits_url":"https://api.github.com/repos/solidusio/solidus_signifyd/git/commits{/sha}","comments_url":"https://api.github.com/repos/solidusio/solidus_signifyd/comments{/number}","issue_comment_url":"https://api.github.com/repos/solidusio/solidus_signifyd/issues/comments{/number}","contents_url":"https://api.github.com/repos/solidusio/solidus_signifyd/contents/{+path}","compare_url":"https://api.github.com/repos/solidusio/solidus_signifyd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/solidusio/solidus_signifyd/merges","archive_url":"https://api.github.com/repos/solidusio/solidus_signifyd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/solidusio/solidus_signifyd/downloads","issues_url":"https://api.github.com/repos/solidusio/solidus_signifyd/issues{/number}","pulls_url":"https://api.github.com/repos/solidusio/solidus_signifyd/pulls{/number}","milestones_url":"https://api.github.com/repos/solidusio/solidus_signifyd/milestones{/number}","notifications_url":"https://api.github.com/repos/solidusio/solidus_signifyd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/solidusio/solidus_signifyd/labels{/name}","releases_url":"https://api.github.com/repos/solidusio/solidus_signifyd/releases{/id}","created_at":"2015-05-26T18:47:34Z","updated_at":"2015-09-04T03:06:13Z","pushed_at":"2015-10-07T20:35:26Z","git_url":"git://github.com/solidusio/solidus_signifyd.git","ssh_url":"git@github.com:solidusio/solidus_signifyd.git","clone_url":"https://github.com/solidusio/solidus_signifyd.git","svn_url":"https://github.com/solidusio/solidus_signifyd","homepage":"","size":254,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":1,"forks":5,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/solidusio/solidus_signifyd/pulls/9"},"html":{"href":"https://github.com/solidusio/solidus_signifyd/pull/9"},"issue":{"href":"https://api.github.com/repos/solidusio/solidus_signifyd/issues/9"},"comments":{"href":"https://api.github.com/repos/solidusio/solidus_signifyd/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/solidusio/solidus_signifyd/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/solidusio/solidus_signifyd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/solidusio/solidus_signifyd/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/solidusio/solidus_signifyd/statuses/c8a1cb3f33faa59c2262e0e27eab4dbf47344e19"}}}}