{"action":"closed","number":454,"pull_request":{"url":"https://api.github.com/repos/tj/git-extras/pulls/454","id":46610199,"html_url":"https://github.com/tj/git-extras/pull/454","diff_url":"https://github.com/tj/git-extras/pull/454.diff","patch_url":"https://github.com/tj/git-extras/pull/454.patch","issue_url":"https://api.github.com/repos/tj/git-extras/issues/454","number":454,"state":"closed","locked":false,"title":"Makefile: escape $ used inside eval as shell variable","user":{"login":"apjanke","id":2618447,"avatar_url":"https://avatars.githubusercontent.com/u/2618447?v=3","gravatar_id":"","url":"https://api.github.com/users/apjanke","html_url":"https://github.com/apjanke","followers_url":"https://api.github.com/users/apjanke/followers","following_url":"https://api.github.com/users/apjanke/following{/other_user}","gists_url":"https://api.github.com/users/apjanke/gists{/gist_id}","starred_url":"https://api.github.com/users/apjanke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apjanke/subscriptions","organizations_url":"https://api.github.com/users/apjanke/orgs","repos_url":"https://api.github.com/users/apjanke/repos","events_url":"https://api.github.com/users/apjanke/events{/privacy}","received_events_url":"https://api.github.com/users/apjanke/received_events","type":"User","site_admin":false},"body":"Follows up on #383, which introduced a build problem on OS X.\r\n\r\nIn an `eval` in a `Makefile`, shell variables need to have their `$` escaped as `$$` so they're expanded by the called shell instead of by `make`.\r\n\r\nCurrently, the build is breaking for me like this.\r\n\r\n```\r\n[~/local/opp/git/git-extras on ⇄ master]\r\n$ make PREFIX=/tmp/git-extras install\r\nusage: mktemp [-d] [-q] [-t prefix] [-u] template ...\r\n       mktemp [-d] [-q] [-u] -t prefix\r\n... installing bins to /tmp/git-extras/bin\r\n... installing man pages to /tmp/git-extras/share/man/man1\r\nusage:\tchmod [-fhv] [-R [-H | -L | -P]] [-a | +a | =a  [i][# [ n]]] mode|entry file ...\r\n\tchmod [-fhv] [-R [-H | -L | -P]] [-E | -C | -N | -i | -I] file ...\r\nmake: *** [install] Error 1\r\n[✘ ~/local/opp/git/git-extras on ⇄ master]\r\n$\r\n```","created_at":"2015-10-02T07:51:07Z","updated_at":"2015-10-02T08:05:35Z","closed_at":"2015-10-02T08:05:35Z","merged_at":"2015-10-02T08:05:35Z","merge_commit_sha":"ec87d4229864a755aaacda50d7b20b5416de7790","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/tj/git-extras/pulls/454/commits","review_comments_url":"https://api.github.com/repos/tj/git-extras/pulls/454/comments","review_comment_url":"https://api.github.com/repos/tj/git-extras/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tj/git-extras/issues/454/comments","statuses_url":"https://api.github.com/repos/tj/git-extras/statuses/5b285380e794ca059aa028eceffb5a773d222d15","head":{"label":"apjanke:makefile-escape-mktemp","ref":"makefile-escape-mktemp","sha":"5b285380e794ca059aa028eceffb5a773d222d15","user":{"login":"apjanke","id":2618447,"avatar_url":"https://avatars.githubusercontent.com/u/2618447?v=3","gravatar_id":"","url":"https://api.github.com/users/apjanke","html_url":"https://github.com/apjanke","followers_url":"https://api.github.com/users/apjanke/followers","following_url":"https://api.github.com/users/apjanke/following{/other_user}","gists_url":"https://api.github.com/users/apjanke/gists{/gist_id}","starred_url":"https://api.github.com/users/apjanke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apjanke/subscriptions","organizations_url":"https://api.github.com/users/apjanke/orgs","repos_url":"https://api.github.com/users/apjanke/repos","events_url":"https://api.github.com/users/apjanke/events{/privacy}","received_events_url":"https://api.github.com/users/apjanke/received_events","type":"User","site_admin":false},"repo":{"id":43541297,"name":"git-extras","full_name":"apjanke/git-extras","owner":{"login":"apjanke","id":2618447,"avatar_url":"https://avatars.githubusercontent.com/u/2618447?v=3","gravatar_id":"","url":"https://api.github.com/users/apjanke","html_url":"https://github.com/apjanke","followers_url":"https://api.github.com/users/apjanke/followers","following_url":"https://api.github.com/users/apjanke/following{/other_user}","gists_url":"https://api.github.com/users/apjanke/gists{/gist_id}","starred_url":"https://api.github.com/users/apjanke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apjanke/subscriptions","organizations_url":"https://api.github.com/users/apjanke/orgs","repos_url":"https://api.github.com/users/apjanke/repos","events_url":"https://api.github.com/users/apjanke/events{/privacy}","received_events_url":"https://api.github.com/users/apjanke/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/apjanke/git-extras","description":"GIT utilities -- repo summary, repl, changelog population, author commit percentages and more","fork":true,"url":"https://api.github.com/repos/apjanke/git-extras","forks_url":"https://api.github.com/repos/apjanke/git-extras/forks","keys_url":"https://api.github.com/repos/apjanke/git-extras/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apjanke/git-extras/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apjanke/git-extras/teams","hooks_url":"https://api.github.com/repos/apjanke/git-extras/hooks","issue_events_url":"https://api.github.com/repos/apjanke/git-extras/issues/events{/number}","events_url":"https://api.github.com/repos/apjanke/git-extras/events","assignees_url":"https://api.github.com/repos/apjanke/git-extras/assignees{/user}","branches_url":"https://api.github.com/repos/apjanke/git-extras/branches{/branch}","tags_url":"https://api.github.com/repos/apjanke/git-extras/tags","blobs_url":"https://api.github.com/repos/apjanke/git-extras/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apjanke/git-extras/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apjanke/git-extras/git/refs{/sha}","trees_url":"https://api.github.com/repos/apjanke/git-extras/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apjanke/git-extras/statuses/{sha}","languages_url":"https://api.github.com/repos/apjanke/git-extras/languages","stargazers_url":"https://api.github.com/repos/apjanke/git-extras/stargazers","contributors_url":"https://api.github.com/repos/apjanke/git-extras/contributors","subscribers_url":"https://api.github.com/repos/apjanke/git-extras/subscribers","subscription_url":"https://api.github.com/repos/apjanke/git-extras/subscription","commits_url":"https://api.github.com/repos/apjanke/git-extras/commits{/sha}","git_commits_url":"https://api.github.com/repos/apjanke/git-extras/git/commits{/sha}","comments_url":"https://api.github.com/repos/apjanke/git-extras/comments{/number}","issue_comment_url":"https://api.github.com/repos/apjanke/git-extras/issues/comments{/number}","contents_url":"https://api.github.com/repos/apjanke/git-extras/contents/{+path}","compare_url":"https://api.github.com/repos/apjanke/git-extras/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apjanke/git-extras/merges","archive_url":"https://api.github.com/repos/apjanke/git-extras/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apjanke/git-extras/downloads","issues_url":"https://api.github.com/repos/apjanke/git-extras/issues{/number}","pulls_url":"https://api.github.com/repos/apjanke/git-extras/pulls{/number}","milestones_url":"https://api.github.com/repos/apjanke/git-extras/milestones{/number}","notifications_url":"https://api.github.com/repos/apjanke/git-extras/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apjanke/git-extras/labels{/name}","releases_url":"https://api.github.com/repos/apjanke/git-extras/releases{/id}","created_at":"2015-10-02T07:47:47Z","updated_at":"2015-10-02T07:47:48Z","pushed_at":"2015-10-02T07:49:20Z","git_url":"git://github.com/apjanke/git-extras.git","ssh_url":"git@github.com:apjanke/git-extras.git","clone_url":"https://github.com/apjanke/git-extras.git","svn_url":"https://github.com/apjanke/git-extras","homepage":"","size":3688,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tj:master","ref":"master","sha":"cc488a035d205c340e533d15817fbdb43573f833","user":{"login":"tj","id":25254,"avatar_url":"https://avatars.githubusercontent.com/u/25254?v=3","gravatar_id":"","url":"https://api.github.com/users/tj","html_url":"https://github.com/tj","followers_url":"https://api.github.com/users/tj/followers","following_url":"https://api.github.com/users/tj/following{/other_user}","gists_url":"https://api.github.com/users/tj/gists{/gist_id}","starred_url":"https://api.github.com/users/tj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tj/subscriptions","organizations_url":"https://api.github.com/users/tj/orgs","repos_url":"https://api.github.com/users/tj/repos","events_url":"https://api.github.com/users/tj/events{/privacy}","received_events_url":"https://api.github.com/users/tj/received_events","type":"User","site_admin":false},"repo":{"id":817345,"name":"git-extras","full_name":"tj/git-extras","owner":{"login":"tj","id":25254,"avatar_url":"https://avatars.githubusercontent.com/u/25254?v=3","gravatar_id":"","url":"https://api.github.com/users/tj","html_url":"https://github.com/tj","followers_url":"https://api.github.com/users/tj/followers","following_url":"https://api.github.com/users/tj/following{/other_user}","gists_url":"https://api.github.com/users/tj/gists{/gist_id}","starred_url":"https://api.github.com/users/tj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tj/subscriptions","organizations_url":"https://api.github.com/users/tj/orgs","repos_url":"https://api.github.com/users/tj/repos","events_url":"https://api.github.com/users/tj/events{/privacy}","received_events_url":"https://api.github.com/users/tj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tj/git-extras","description":"GIT utilities -- repo summary, repl, changelog population, author commit percentages and more","fork":false,"url":"https://api.github.com/repos/tj/git-extras","forks_url":"https://api.github.com/repos/tj/git-extras/forks","keys_url":"https://api.github.com/repos/tj/git-extras/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tj/git-extras/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tj/git-extras/teams","hooks_url":"https://api.github.com/repos/tj/git-extras/hooks","issue_events_url":"https://api.github.com/repos/tj/git-extras/issues/events{/number}","events_url":"https://api.github.com/repos/tj/git-extras/events","assignees_url":"https://api.github.com/repos/tj/git-extras/assignees{/user}","branches_url":"https://api.github.com/repos/tj/git-extras/branches{/branch}","tags_url":"https://api.github.com/repos/tj/git-extras/tags","blobs_url":"https://api.github.com/repos/tj/git-extras/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tj/git-extras/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tj/git-extras/git/refs{/sha}","trees_url":"https://api.github.com/repos/tj/git-extras/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tj/git-extras/statuses/{sha}","languages_url":"https://api.github.com/repos/tj/git-extras/languages","stargazers_url":"https://api.github.com/repos/tj/git-extras/stargazers","contributors_url":"https://api.github.com/repos/tj/git-extras/contributors","subscribers_url":"https://api.github.com/repos/tj/git-extras/subscribers","subscription_url":"https://api.github.com/repos/tj/git-extras/subscription","commits_url":"https://api.github.com/repos/tj/git-extras/commits{/sha}","git_commits_url":"https://api.github.com/repos/tj/git-extras/git/commits{/sha}","comments_url":"https://api.github.com/repos/tj/git-extras/comments{/number}","issue_comment_url":"https://api.github.com/repos/tj/git-extras/issues/comments{/number}","contents_url":"https://api.github.com/repos/tj/git-extras/contents/{+path}","compare_url":"https://api.github.com/repos/tj/git-extras/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tj/git-extras/merges","archive_url":"https://api.github.com/repos/tj/git-extras/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tj/git-extras/downloads","issues_url":"https://api.github.com/repos/tj/git-extras/issues{/number}","pulls_url":"https://api.github.com/repos/tj/git-extras/pulls{/number}","milestones_url":"https://api.github.com/repos/tj/git-extras/milestones{/number}","notifications_url":"https://api.github.com/repos/tj/git-extras/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tj/git-extras/labels{/name}","releases_url":"https://api.github.com/repos/tj/git-extras/releases{/id}","created_at":"2010-08-04T16:32:07Z","updated_at":"2015-10-02T07:52:41Z","pushed_at":"2015-10-02T08:05:35Z","git_url":"git://github.com/tj/git-extras.git","ssh_url":"git@github.com:tj/git-extras.git","clone_url":"https://github.com/tj/git-extras.git","svn_url":"https://github.com/tj/git-extras","homepage":"","size":3688,"stargazers_count":6736,"watchers_count":6736,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":460,"mirror_url":null,"open_issues_count":76,"forks":460,"open_issues":76,"watchers":6736,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tj/git-extras/pulls/454"},"html":{"href":"https://github.com/tj/git-extras/pull/454"},"issue":{"href":"https://api.github.com/repos/tj/git-extras/issues/454"},"comments":{"href":"https://api.github.com/repos/tj/git-extras/issues/454/comments"},"review_comments":{"href":"https://api.github.com/repos/tj/git-extras/pulls/454/comments"},"review_comment":{"href":"https://api.github.com/repos/tj/git-extras/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tj/git-extras/pulls/454/commits"},"statuses":{"href":"https://api.github.com/repos/tj/git-extras/statuses/5b285380e794ca059aa028eceffb5a773d222d15"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"hemanth","id":18315,"avatar_url":"https://avatars.githubusercontent.com/u/18315?v=3","gravatar_id":"","url":"https://api.github.com/users/hemanth","html_url":"https://github.com/hemanth","followers_url":"https://api.github.com/users/hemanth/followers","following_url":"https://api.github.com/users/hemanth/following{/other_user}","gists_url":"https://api.github.com/users/hemanth/gists{/gist_id}","starred_url":"https://api.github.com/users/hemanth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hemanth/subscriptions","organizations_url":"https://api.github.com/users/hemanth/orgs","repos_url":"https://api.github.com/users/hemanth/repos","events_url":"https://api.github.com/users/hemanth/events{/privacy}","received_events_url":"https://api.github.com/users/hemanth/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}