{"action":"created","comment":{"url":"https://api.github.com/repos/JuliaParallel/ClusterManagers.jl/pulls/comments/42310158","id":42310158,"diff_hunk":"@@ -68,7 +70,7 @@ function launch(manager::Union{PBSManager, SGEManager}, params::Dict, instances_\n end\n \n function manage(manager::Union{PBSManager, SGEManager}, id::Integer, config::WorkerConfig, op::Symbol)\n-    if op == :finalize\n+    if op == :interrupt","path":"src/qsub.jl","position":34,"original_position":34,"commit_id":"6a77e83f5274529b1dc4ebdf05c625e1cc18dfd7","original_commit_id":"6a77e83f5274529b1dc4ebdf05c625e1cc18dfd7","user":{"login":"amitmurthy","id":117461,"avatar_url":"https://avatars.githubusercontent.com/u/117461?v=3","gravatar_id":"","url":"https://api.github.com/users/amitmurthy","html_url":"https://github.com/amitmurthy","followers_url":"https://api.github.com/users/amitmurthy/followers","following_url":"https://api.github.com/users/amitmurthy/following{/other_user}","gists_url":"https://api.github.com/users/amitmurthy/gists{/gist_id}","starred_url":"https://api.github.com/users/amitmurthy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amitmurthy/subscriptions","organizations_url":"https://api.github.com/users/amitmurthy/orgs","repos_url":"https://api.github.com/users/amitmurthy/repos","events_url":"https://api.github.com/users/amitmurthy/events{/privacy}","received_events_url":"https://api.github.com/users/amitmurthy/received_events","type":"User","site_admin":false},"body":"Why this change? Shouldn't `:interrupt` send a message that simulates a SIGINT? And `:finalize` should kill the workers. ","created_at":"2015-10-17T15:09:05Z","updated_at":"2015-10-17T15:09:05Z","html_url":"https://github.com/JuliaParallel/ClusterManagers.jl/pull/25#discussion_r42310158","pull_request_url":"https://api.github.com/repos/JuliaParallel/ClusterManagers.jl/pulls/25","_links":{"self":{"href":"https://api.github.com/repos/JuliaParallel/ClusterManagers.jl/pulls/comments/42310158"},"html":{"href":"https://github.com/JuliaParallel/ClusterManagers.jl/pull/25#discussion_r42310158"},"pull_request":{"href":"https://api.github.com/repos/JuliaParallel/ClusterManagers.jl/pulls/25"}}},"pull_request":{"url":"https://api.github.com/repos/JuliaParallel/ClusterManagers.jl/pulls/25","id":47284056,"html_url":"https://github.com/JuliaParallel/ClusterManagers.jl/pull/25","diff_url":"https://github.com/JuliaParallel/ClusterManagers.jl/pull/25.diff","patch_url":"https://github.com/JuliaParallel/ClusterManagers.jl/pull/25.patch","issue_url":"https://api.github.com/repos/JuliaParallel/ClusterManagers.jl/issues/25","number":25,"state":"open","locked":false,"title":"String Interpolation and Immutable Errors","user":{"login":"gcamilo","id":3434853,"avatar_url":"https://avatars.githubusercontent.com/u/3434853?v=3","gravatar_id":"","url":"https://api.github.com/users/gcamilo","html_url":"https://github.com/gcamilo","followers_url":"https://api.github.com/users/gcamilo/followers","following_url":"https://api.github.com/users/gcamilo/following{/other_user}","gists_url":"https://api.github.com/users/gcamilo/gists{/gist_id}","starred_url":"https://api.github.com/users/gcamilo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gcamilo/subscriptions","organizations_url":"https://api.github.com/users/gcamilo/orgs","repos_url":"https://api.github.com/users/gcamilo/repos","events_url":"https://api.github.com/users/gcamilo/events{/privacy}","received_events_url":"https://api.github.com/users/gcamilo/received_events","type":"User","site_admin":false},"body":"Fixed string interpolation errors and new types in Julia 0.4","created_at":"2015-10-09T15:16:38Z","updated_at":"2015-10-17T15:09:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"740eca124ea46a53f2c3306017ddc8a467e7489f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/JuliaParallel/ClusterManagers.jl/pulls/25/commits","review_comments_url":"https://api.github.com/repos/JuliaParallel/ClusterManagers.jl/pulls/25/comments","review_comment_url":"https://api.github.com/repos/JuliaParallel/ClusterManagers.jl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JuliaParallel/ClusterManagers.jl/issues/25/comments","statuses_url":"https://api.github.com/repos/JuliaParallel/ClusterManagers.jl/statuses/6a77e83f5274529b1dc4ebdf05c625e1cc18dfd7","head":{"label":"gcamilo:pull-request/399bcb2d","ref":"pull-request/399bcb2d","sha":"6a77e83f5274529b1dc4ebdf05c625e1cc18dfd7","user":{"login":"gcamilo","id":3434853,"avatar_url":"https://avatars.githubusercontent.com/u/3434853?v=3","gravatar_id":"","url":"https://api.github.com/users/gcamilo","html_url":"https://github.com/gcamilo","followers_url":"https://api.github.com/users/gcamilo/followers","following_url":"https://api.github.com/users/gcamilo/following{/other_user}","gists_url":"https://api.github.com/users/gcamilo/gists{/gist_id}","starred_url":"https://api.github.com/users/gcamilo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gcamilo/subscriptions","organizations_url":"https://api.github.com/users/gcamilo/orgs","repos_url":"https://api.github.com/users/gcamilo/repos","events_url":"https://api.github.com/users/gcamilo/events{/privacy}","received_events_url":"https://api.github.com/users/gcamilo/received_events","type":"User","site_admin":false},"repo":{"id":43963174,"name":"ClusterManagers.jl","full_name":"gcamilo/ClusterManagers.jl","owner":{"login":"gcamilo","id":3434853,"avatar_url":"https://avatars.githubusercontent.com/u/3434853?v=3","gravatar_id":"","url":"https://api.github.com/users/gcamilo","html_url":"https://github.com/gcamilo","followers_url":"https://api.github.com/users/gcamilo/followers","following_url":"https://api.github.com/users/gcamilo/following{/other_user}","gists_url":"https://api.github.com/users/gcamilo/gists{/gist_id}","starred_url":"https://api.github.com/users/gcamilo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gcamilo/subscriptions","organizations_url":"https://api.github.com/users/gcamilo/orgs","repos_url":"https://api.github.com/users/gcamilo/repos","events_url":"https://api.github.com/users/gcamilo/events{/privacy}","received_events_url":"https://api.github.com/users/gcamilo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gcamilo/ClusterManagers.jl","description":"","fork":true,"url":"https://api.github.com/repos/gcamilo/ClusterManagers.jl","forks_url":"https://api.github.com/repos/gcamilo/ClusterManagers.jl/forks","keys_url":"https://api.github.com/repos/gcamilo/ClusterManagers.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gcamilo/ClusterManagers.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gcamilo/ClusterManagers.jl/teams","hooks_url":"https://api.github.com/repos/gcamilo/ClusterManagers.jl/hooks","issue_events_url":"https://api.github.com/repos/gcamilo/ClusterManagers.jl/issues/events{/number}","events_url":"https://api.github.com/repos/gcamilo/ClusterManagers.jl/events","assignees_url":"https://api.github.com/repos/gcamilo/ClusterManagers.jl/assignees{/user}","branches_url":"https://api.github.com/repos/gcamilo/ClusterManagers.jl/branches{/branch}","tags_url":"https://api.github.com/repos/gcamilo/ClusterManagers.jl/tags","blobs_url":"https://api.github.com/repos/gcamilo/ClusterManagers.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gcamilo/ClusterManagers.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gcamilo/ClusterManagers.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/gcamilo/ClusterManagers.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gcamilo/ClusterManagers.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/gcamilo/ClusterManagers.jl/languages","stargazers_url":"https://api.github.com/repos/gcamilo/ClusterManagers.jl/stargazers","contributors_url":"https://api.github.com/repos/gcamilo/ClusterManagers.jl/contributors","subscribers_url":"https://api.github.com/repos/gcamilo/ClusterManagers.jl/subscribers","subscription_url":"https://api.github.com/repos/gcamilo/ClusterManagers.jl/subscription","commits_url":"https://api.github.com/repos/gcamilo/ClusterManagers.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/gcamilo/ClusterManagers.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/gcamilo/ClusterManagers.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/gcamilo/ClusterManagers.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/gcamilo/ClusterManagers.jl/contents/{+path}","compare_url":"https://api.github.com/repos/gcamilo/ClusterManagers.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gcamilo/ClusterManagers.jl/merges","archive_url":"https://api.github.com/repos/gcamilo/ClusterManagers.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gcamilo/ClusterManagers.jl/downloads","issues_url":"https://api.github.com/repos/gcamilo/ClusterManagers.jl/issues{/number}","pulls_url":"https://api.github.com/repos/gcamilo/ClusterManagers.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/gcamilo/ClusterManagers.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/gcamilo/ClusterManagers.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gcamilo/ClusterManagers.jl/labels{/name}","releases_url":"https://api.github.com/repos/gcamilo/ClusterManagers.jl/releases{/id}","created_at":"2015-10-09T15:11:02Z","updated_at":"2015-10-09T15:11:03Z","pushed_at":"2015-10-16T00:29:32Z","git_url":"git://github.com/gcamilo/ClusterManagers.jl.git","ssh_url":"git@github.com:gcamilo/ClusterManagers.jl.git","clone_url":"https://github.com/gcamilo/ClusterManagers.jl.git","svn_url":"https://github.com/gcamilo/ClusterManagers.jl","homepage":null,"size":172,"stargazers_count":0,"watchers_count":0,"language":"Julia","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JuliaParallel:master","ref":"master","sha":"ee3469b2fbc7d0eeca638d9facf96d309cf07497","user":{"login":"JuliaParallel","id":10119367,"avatar_url":"https://avatars.githubusercontent.com/u/10119367?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaParallel","html_url":"https://github.com/JuliaParallel","followers_url":"https://api.github.com/users/JuliaParallel/followers","following_url":"https://api.github.com/users/JuliaParallel/following{/other_user}","gists_url":"https://api.github.com/users/JuliaParallel/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaParallel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaParallel/subscriptions","organizations_url":"https://api.github.com/users/JuliaParallel/orgs","repos_url":"https://api.github.com/users/JuliaParallel/repos","events_url":"https://api.github.com/users/JuliaParallel/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaParallel/received_events","type":"Organization","site_admin":false},"repo":{"id":11250727,"name":"ClusterManagers.jl","full_name":"JuliaParallel/ClusterManagers.jl","owner":{"login":"JuliaParallel","id":10119367,"avatar_url":"https://avatars.githubusercontent.com/u/10119367?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaParallel","html_url":"https://github.com/JuliaParallel","followers_url":"https://api.github.com/users/JuliaParallel/followers","following_url":"https://api.github.com/users/JuliaParallel/following{/other_user}","gists_url":"https://api.github.com/users/JuliaParallel/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaParallel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaParallel/subscriptions","organizations_url":"https://api.github.com/users/JuliaParallel/orgs","repos_url":"https://api.github.com/users/JuliaParallel/repos","events_url":"https://api.github.com/users/JuliaParallel/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaParallel/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaParallel/ClusterManagers.jl","description":"","fork":false,"url":"https://api.github.com/repos/JuliaParallel/ClusterManagers.jl","forks_url":"https://api.github.com/repos/JuliaParallel/ClusterManagers.jl/forks","keys_url":"https://api.github.com/repos/JuliaParallel/ClusterManagers.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaParallel/ClusterManagers.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaParallel/ClusterManagers.jl/teams","hooks_url":"https://api.github.com/repos/JuliaParallel/ClusterManagers.jl/hooks","issue_events_url":"https://api.github.com/repos/JuliaParallel/ClusterManagers.jl/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaParallel/ClusterManagers.jl/events","assignees_url":"https://api.github.com/repos/JuliaParallel/ClusterManagers.jl/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaParallel/ClusterManagers.jl/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaParallel/ClusterManagers.jl/tags","blobs_url":"https://api.github.com/repos/JuliaParallel/ClusterManagers.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaParallel/ClusterManagers.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaParallel/ClusterManagers.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaParallel/ClusterManagers.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaParallel/ClusterManagers.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaParallel/ClusterManagers.jl/languages","stargazers_url":"https://api.github.com/repos/JuliaParallel/ClusterManagers.jl/stargazers","contributors_url":"https://api.github.com/repos/JuliaParallel/ClusterManagers.jl/contributors","subscribers_url":"https://api.github.com/repos/JuliaParallel/ClusterManagers.jl/subscribers","subscription_url":"https://api.github.com/repos/JuliaParallel/ClusterManagers.jl/subscription","commits_url":"https://api.github.com/repos/JuliaParallel/ClusterManagers.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaParallel/ClusterManagers.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaParallel/ClusterManagers.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaParallel/ClusterManagers.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaParallel/ClusterManagers.jl/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaParallel/ClusterManagers.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaParallel/ClusterManagers.jl/merges","archive_url":"https://api.github.com/repos/JuliaParallel/ClusterManagers.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaParallel/ClusterManagers.jl/downloads","issues_url":"https://api.github.com/repos/JuliaParallel/ClusterManagers.jl/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaParallel/ClusterManagers.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaParallel/ClusterManagers.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaParallel/ClusterManagers.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaParallel/ClusterManagers.jl/labels{/name}","releases_url":"https://api.github.com/repos/JuliaParallel/ClusterManagers.jl/releases{/id}","created_at":"2013-07-08T09:32:59Z","updated_at":"2015-10-09T14:51:41Z","pushed_at":"2015-10-16T00:23:38Z","git_url":"git://github.com/JuliaParallel/ClusterManagers.jl.git","ssh_url":"git@github.com:JuliaParallel/ClusterManagers.jl.git","clone_url":"https://github.com/JuliaParallel/ClusterManagers.jl.git","svn_url":"https://github.com/JuliaParallel/ClusterManagers.jl","homepage":null,"size":430,"stargazers_count":14,"watchers_count":14,"language":"Julia","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":9,"forks":10,"open_issues":9,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JuliaParallel/ClusterManagers.jl/pulls/25"},"html":{"href":"https://github.com/JuliaParallel/ClusterManagers.jl/pull/25"},"issue":{"href":"https://api.github.com/repos/JuliaParallel/ClusterManagers.jl/issues/25"},"comments":{"href":"https://api.github.com/repos/JuliaParallel/ClusterManagers.jl/issues/25/comments"},"review_comments":{"href":"https://api.github.com/repos/JuliaParallel/ClusterManagers.jl/pulls/25/comments"},"review_comment":{"href":"https://api.github.com/repos/JuliaParallel/ClusterManagers.jl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JuliaParallel/ClusterManagers.jl/pulls/25/commits"},"statuses":{"href":"https://api.github.com/repos/JuliaParallel/ClusterManagers.jl/statuses/6a77e83f5274529b1dc4ebdf05c625e1cc18dfd7"}}}}