{"action":"created","issue":{"url":"https://api.github.com/repos/solidusio/solidus/issues/340","labels_url":"https://api.github.com/repos/solidusio/solidus/issues/340/labels{/name}","comments_url":"https://api.github.com/repos/solidusio/solidus/issues/340/comments","events_url":"https://api.github.com/repos/solidusio/solidus/issues/340/events","html_url":"https://github.com/solidusio/solidus/pull/340","id":103727345,"number":340,"title":"Skip shipment creation for unreturned exchanges","user":{"login":"richardnuno","id":2223534,"avatar_url":"https://avatars.githubusercontent.com/u/2223534?v=3","gravatar_id":"","url":"https://api.github.com/users/richardnuno","html_url":"https://github.com/richardnuno","followers_url":"https://api.github.com/users/richardnuno/followers","following_url":"https://api.github.com/users/richardnuno/following{/other_user}","gists_url":"https://api.github.com/users/richardnuno/gists{/gist_id}","starred_url":"https://api.github.com/users/richardnuno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardnuno/subscriptions","organizations_url":"https://api.github.com/users/richardnuno/orgs","repos_url":"https://api.github.com/users/richardnuno/repos","events_url":"https://api.github.com/users/richardnuno/events{/privacy}","received_events_url":"https://api.github.com/users/richardnuno/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-08-28T14:22:57Z","updated_at":"2015-08-31T14:58:29Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/solidusio/solidus/pulls/340","html_url":"https://github.com/solidusio/solidus/pull/340","diff_url":"https://github.com/solidusio/solidus/pull/340.diff","patch_url":"https://github.com/solidusio/solidus/pull/340.patch"},"body":"This change fixes a bug whereby the UnreturnedItemCharger would fail to create a new order when any of the variants in the new order was out of stock. Since the shipment has already shipped, no verification for stock quantity is required."},"comment":{"url":"https://api.github.com/repos/solidusio/solidus/issues/comments/136397917","html_url":"https://github.com/solidusio/solidus/pull/340#issuecomment-136397917","issue_url":"https://api.github.com/repos/solidusio/solidus/issues/340","id":136397917,"user":{"login":"richardnuno","id":2223534,"avatar_url":"https://avatars.githubusercontent.com/u/2223534?v=3","gravatar_id":"","url":"https://api.github.com/users/richardnuno","html_url":"https://github.com/richardnuno","followers_url":"https://api.github.com/users/richardnuno/followers","following_url":"https://api.github.com/users/richardnuno/following{/other_user}","gists_url":"https://api.github.com/users/richardnuno/gists{/gist_id}","starred_url":"https://api.github.com/users/richardnuno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardnuno/subscriptions","organizations_url":"https://api.github.com/users/richardnuno/orgs","repos_url":"https://api.github.com/users/richardnuno/repos","events_url":"https://api.github.com/users/richardnuno/events{/privacy}","received_events_url":"https://api.github.com/users/richardnuno/received_events","type":"User","site_admin":false},"created_at":"2015-08-31T14:58:29Z","updated_at":"2015-08-31T14:58:29Z","body":"@jhawthorn updated with your feedback. Thanks for suggesting the extra spec, it actually uncovered another issue that would have happened further along while finalizing the order. When finalizing the new order, the shipment would be finalized again causing the count on hand for the variants in the shipment to be decremented (causing the out of stock error again if there is no stock). I've added a fix for that issue as well, mind taking another look?"}}