{"action":"created","issue":{"url":"https://api.github.com/repos/joewing/jwm/issues/218","labels_url":"https://api.github.com/repos/joewing/jwm/issues/218/labels{/name}","comments_url":"https://api.github.com/repos/joewing/jwm/issues/218/comments","events_url":"https://api.github.com/repos/joewing/jwm/issues/218/events","html_url":"https://github.com/joewing/jwm/issues/218","id":103307312,"number":218,"title":"Issues with window maximazing (LXTerminal, Sakura, ROXTerm only)","user":{"login":"wdlkmpx","id":10052849,"avatar_url":"https://avatars.githubusercontent.com/u/10052849?v=3","gravatar_id":"","url":"https://api.github.com/users/wdlkmpx","html_url":"https://github.com/wdlkmpx","followers_url":"https://api.github.com/users/wdlkmpx/followers","following_url":"https://api.github.com/users/wdlkmpx/following{/other_user}","gists_url":"https://api.github.com/users/wdlkmpx/gists{/gist_id}","starred_url":"https://api.github.com/users/wdlkmpx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wdlkmpx/subscriptions","organizations_url":"https://api.github.com/users/wdlkmpx/orgs","repos_url":"https://api.github.com/users/wdlkmpx/repos","events_url":"https://api.github.com/users/wdlkmpx/events{/privacy}","received_events_url":"https://api.github.com/users/wdlkmpx/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/joewing/jwm/labels/bug","name":"bug","color":"fc2929"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-08-26T16:09:15Z","updated_at":"2015-08-28T23:15:37Z","closed_at":null,"body":"These 3 terminal emulators refuse to maximize, it's like the window is saying: this is wrong so I'll go back to my previous state.\r\n\r\nI think I've traced the origin of the problem.\r\n\r\nThis happens since commit https://github.com/joewing/jwm/commit/f538f75e8c4ef186ba2660b2af7a0e31f55a9a9d\r\n\r\nThe key file is src/place.c\r\n\r\nI've been testing s1051, s1053(ORIGIN) and s1247\r\n\r\nIn s1051 there are issues with window maximizing, however LXTerminal does maximize.\r\nIn s1053 there are issues with window maximizing\r\n\r\ns1051 & 1053: geany search dialog is BIG, pcmanfm confirm dialogs have incorrect size\r\n\r\ns1247: EVERYTHING OK but LXTerminal windows don't maximize.\r\n\r\n\r\n===============\r\nplace.c\r\n===============\r\n\r\nSo, after undoing and redoing every change, I think the issue happens here:\r\n\r\nLine 844\r\n\r\n\t   /* If maximizing vertically, update height. */\r\n\t   if(flags & MAX_VERT) {\r\n\t\t  np->y = box.y + north;\r\n\t\t  np->height = box.height - north;\r\n\r\n \r\nIf I remove '- north'\r\n\r\n\t   /* If maximizing vertically, update height. */\r\n\t   if(flags & MAX_VERT) {\r\n\t\t  np->y = box.y + north;\r\n\t\t  np->height = box.height;\r\n\r\nAnd compile again... LXTerminal windows maximize, though maximized windows now have incorrect height"},"comment":{"url":"https://api.github.com/repos/joewing/jwm/issues/comments/135908678","html_url":"https://github.com/joewing/jwm/issues/218#issuecomment-135908678","issue_url":"https://api.github.com/repos/joewing/jwm/issues/218","id":135908678,"user":{"login":"joewing","id":1285008,"avatar_url":"https://avatars.githubusercontent.com/u/1285008?v=3","gravatar_id":"","url":"https://api.github.com/users/joewing","html_url":"https://github.com/joewing","followers_url":"https://api.github.com/users/joewing/followers","following_url":"https://api.github.com/users/joewing/following{/other_user}","gists_url":"https://api.github.com/users/joewing/gists{/gist_id}","starred_url":"https://api.github.com/users/joewing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joewing/subscriptions","organizations_url":"https://api.github.com/users/joewing/orgs","repos_url":"https://api.github.com/users/joewing/repos","events_url":"https://api.github.com/users/joewing/events{/privacy}","received_events_url":"https://api.github.com/users/joewing/received_events","type":"User","site_admin":false},"created_at":"2015-08-28T23:15:37Z","updated_at":"2015-08-28T23:15:37Z","body":"This fix is available in snapshot 1257."}}