{"action":"created","comment":{"url":"https://api.github.com/repos/lkroesen/BubbleBobble/pulls/comments/40245673","id":40245673,"diff_hunk":"@@ -123,4 +125,111 @@ public void testTick2()\n         game.tick();\n         verify(levels.get(0), times(1)).tick();\n     }\n+    \n+    /**\n+     * Tests that a game over occurs when the player has no lives left.\n+     */\n+    @Test\n+    public void testGameOverSetLives()\n+    {\n+\n+    \tlevels.add(l);\n+    \tPlayer p = new Player(po);\n+    \tArrayList<Player> list = new ArrayList<Player>();\n+    \tlist.add(p);\n+    \tGame game = new Game(levels, list);\n+    \tgame.start();\n+    \tassertTrue(game.isRunning());\n+    \t\n+    \tp.setLives(0);\n+    \tgame.tickGO();\n+    \tassertFalse(game.isRunning());\n+    \t","path":"src/test/java/website/frontrow/GameTest.java","position":49,"original_position":49,"commit_id":"e0efa5ee1ed2712721f156a02ad40f47404f8f52","original_commit_id":"e0efa5ee1ed2712721f156a02ad40f47404f8f52","user":{"login":"LarsStegman","id":9332816,"avatar_url":"https://avatars.githubusercontent.com/u/9332816?v=3","gravatar_id":"","url":"https://api.github.com/users/LarsStegman","html_url":"https://github.com/LarsStegman","followers_url":"https://api.github.com/users/LarsStegman/followers","following_url":"https://api.github.com/users/LarsStegman/following{/other_user}","gists_url":"https://api.github.com/users/LarsStegman/gists{/gist_id}","starred_url":"https://api.github.com/users/LarsStegman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LarsStegman/subscriptions","organizations_url":"https://api.github.com/users/LarsStegman/orgs","repos_url":"https://api.github.com/users/LarsStegman/repos","events_url":"https://api.github.com/users/LarsStegman/events{/privacy}","received_events_url":"https://api.github.com/users/LarsStegman/received_events","type":"User","site_admin":false},"body":"I agree with @ThatFlint the whitespace makes it a lot easier to read the code.","created_at":"2015-09-23T19:21:19Z","updated_at":"2015-09-23T19:21:19Z","html_url":"https://github.com/lkroesen/BubbleBobble/pull/35#discussion_r40245673","pull_request_url":"https://api.github.com/repos/lkroesen/BubbleBobble/pulls/35","_links":{"self":{"href":"https://api.github.com/repos/lkroesen/BubbleBobble/pulls/comments/40245673"},"html":{"href":"https://github.com/lkroesen/BubbleBobble/pull/35#discussion_r40245673"},"pull_request":{"href":"https://api.github.com/repos/lkroesen/BubbleBobble/pulls/35"}}},"pull_request":{"url":"https://api.github.com/repos/lkroesen/BubbleBobble/pulls/35","id":45647462,"html_url":"https://github.com/lkroesen/BubbleBobble/pull/35","diff_url":"https://github.com/lkroesen/BubbleBobble/pull/35.diff","patch_url":"https://github.com/lkroesen/BubbleBobble/pull/35.patch","issue_url":"https://api.github.com/repos/lkroesen/BubbleBobble/issues/35","number":35,"state":"open","locked":false,"title":"Dev lives game over","user":{"login":"ThatFlint","id":9696198,"avatar_url":"https://avatars.githubusercontent.com/u/9696198?v=3","gravatar_id":"","url":"https://api.github.com/users/ThatFlint","html_url":"https://github.com/ThatFlint","followers_url":"https://api.github.com/users/ThatFlint/followers","following_url":"https://api.github.com/users/ThatFlint/following{/other_user}","gists_url":"https://api.github.com/users/ThatFlint/gists{/gist_id}","starred_url":"https://api.github.com/users/ThatFlint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThatFlint/subscriptions","organizations_url":"https://api.github.com/users/ThatFlint/orgs","repos_url":"https://api.github.com/users/ThatFlint/repos","events_url":"https://api.github.com/users/ThatFlint/events{/privacy}","received_events_url":"https://api.github.com/users/ThatFlint/received_events","type":"User","site_admin":false},"body":"Now we have a game over state, which is accessed when the player is out of lives.\r\nSince we don't have a Game Over screen yet, the application just prints \"GAME OVER\" to the console.\r\n\r\nAlso, a second tick function has been made that only checks if all players are dead. This is because the use of a mocked level causes the game to immediately end, since there are no enemies in the level. This should only be used by certain test cases.","created_at":"2015-09-22T10:27:28Z","updated_at":"2015-09-23T19:21:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"50750e24794ecf0b68c18757d1000bee18069be4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/lkroesen/BubbleBobble/pulls/35/commits","review_comments_url":"https://api.github.com/repos/lkroesen/BubbleBobble/pulls/35/comments","review_comment_url":"https://api.github.com/repos/lkroesen/BubbleBobble/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lkroesen/BubbleBobble/issues/35/comments","statuses_url":"https://api.github.com/repos/lkroesen/BubbleBobble/statuses/e0efa5ee1ed2712721f156a02ad40f47404f8f52","head":{"label":"lkroesen:dev-lives-game-over","ref":"dev-lives-game-over","sha":"e0efa5ee1ed2712721f156a02ad40f47404f8f52","user":{"login":"lkroesen","id":9070087,"avatar_url":"https://avatars.githubusercontent.com/u/9070087?v=3","gravatar_id":"","url":"https://api.github.com/users/lkroesen","html_url":"https://github.com/lkroesen","followers_url":"https://api.github.com/users/lkroesen/followers","following_url":"https://api.github.com/users/lkroesen/following{/other_user}","gists_url":"https://api.github.com/users/lkroesen/gists{/gist_id}","starred_url":"https://api.github.com/users/lkroesen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lkroesen/subscriptions","organizations_url":"https://api.github.com/users/lkroesen/orgs","repos_url":"https://api.github.com/users/lkroesen/repos","events_url":"https://api.github.com/users/lkroesen/events{/privacy}","received_events_url":"https://api.github.com/users/lkroesen/received_events","type":"User","site_admin":false},"repo":{"id":41728060,"name":"BubbleBobble","full_name":"lkroesen/BubbleBobble","owner":{"login":"lkroesen","id":9070087,"avatar_url":"https://avatars.githubusercontent.com/u/9070087?v=3","gravatar_id":"","url":"https://api.github.com/users/lkroesen","html_url":"https://github.com/lkroesen","followers_url":"https://api.github.com/users/lkroesen/followers","following_url":"https://api.github.com/users/lkroesen/following{/other_user}","gists_url":"https://api.github.com/users/lkroesen/gists{/gist_id}","starred_url":"https://api.github.com/users/lkroesen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lkroesen/subscriptions","organizations_url":"https://api.github.com/users/lkroesen/orgs","repos_url":"https://api.github.com/users/lkroesen/repos","events_url":"https://api.github.com/users/lkroesen/events{/privacy}","received_events_url":"https://api.github.com/users/lkroesen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lkroesen/BubbleBobble","description":"","fork":false,"url":"https://api.github.com/repos/lkroesen/BubbleBobble","forks_url":"https://api.github.com/repos/lkroesen/BubbleBobble/forks","keys_url":"https://api.github.com/repos/lkroesen/BubbleBobble/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lkroesen/BubbleBobble/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lkroesen/BubbleBobble/teams","hooks_url":"https://api.github.com/repos/lkroesen/BubbleBobble/hooks","issue_events_url":"https://api.github.com/repos/lkroesen/BubbleBobble/issues/events{/number}","events_url":"https://api.github.com/repos/lkroesen/BubbleBobble/events","assignees_url":"https://api.github.com/repos/lkroesen/BubbleBobble/assignees{/user}","branches_url":"https://api.github.com/repos/lkroesen/BubbleBobble/branches{/branch}","tags_url":"https://api.github.com/repos/lkroesen/BubbleBobble/tags","blobs_url":"https://api.github.com/repos/lkroesen/BubbleBobble/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lkroesen/BubbleBobble/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lkroesen/BubbleBobble/git/refs{/sha}","trees_url":"https://api.github.com/repos/lkroesen/BubbleBobble/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lkroesen/BubbleBobble/statuses/{sha}","languages_url":"https://api.github.com/repos/lkroesen/BubbleBobble/languages","stargazers_url":"https://api.github.com/repos/lkroesen/BubbleBobble/stargazers","contributors_url":"https://api.github.com/repos/lkroesen/BubbleBobble/contributors","subscribers_url":"https://api.github.com/repos/lkroesen/BubbleBobble/subscribers","subscription_url":"https://api.github.com/repos/lkroesen/BubbleBobble/subscription","commits_url":"https://api.github.com/repos/lkroesen/BubbleBobble/commits{/sha}","git_commits_url":"https://api.github.com/repos/lkroesen/BubbleBobble/git/commits{/sha}","comments_url":"https://api.github.com/repos/lkroesen/BubbleBobble/comments{/number}","issue_comment_url":"https://api.github.com/repos/lkroesen/BubbleBobble/issues/comments{/number}","contents_url":"https://api.github.com/repos/lkroesen/BubbleBobble/contents/{+path}","compare_url":"https://api.github.com/repos/lkroesen/BubbleBobble/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lkroesen/BubbleBobble/merges","archive_url":"https://api.github.com/repos/lkroesen/BubbleBobble/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lkroesen/BubbleBobble/downloads","issues_url":"https://api.github.com/repos/lkroesen/BubbleBobble/issues{/number}","pulls_url":"https://api.github.com/repos/lkroesen/BubbleBobble/pulls{/number}","milestones_url":"https://api.github.com/repos/lkroesen/BubbleBobble/milestones{/number}","notifications_url":"https://api.github.com/repos/lkroesen/BubbleBobble/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lkroesen/BubbleBobble/labels{/name}","releases_url":"https://api.github.com/repos/lkroesen/BubbleBobble/releases{/id}","created_at":"2015-09-01T08:58:50Z","updated_at":"2015-09-01T10:12:36Z","pushed_at":"2015-09-23T19:16:33Z","git_url":"git://github.com/lkroesen/BubbleBobble.git","ssh_url":"git@github.com:lkroesen/BubbleBobble.git","clone_url":"https://github.com/lkroesen/BubbleBobble.git","svn_url":"https://github.com/lkroesen/BubbleBobble","homepage":null,"size":109216,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":12,"forks":0,"open_issues":12,"watchers":0,"default_branch":"master"}},"base":{"label":"lkroesen:dev","ref":"dev","sha":"56273aafcb1ba5f6d7c5f5ec5833925d6a188148","user":{"login":"lkroesen","id":9070087,"avatar_url":"https://avatars.githubusercontent.com/u/9070087?v=3","gravatar_id":"","url":"https://api.github.com/users/lkroesen","html_url":"https://github.com/lkroesen","followers_url":"https://api.github.com/users/lkroesen/followers","following_url":"https://api.github.com/users/lkroesen/following{/other_user}","gists_url":"https://api.github.com/users/lkroesen/gists{/gist_id}","starred_url":"https://api.github.com/users/lkroesen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lkroesen/subscriptions","organizations_url":"https://api.github.com/users/lkroesen/orgs","repos_url":"https://api.github.com/users/lkroesen/repos","events_url":"https://api.github.com/users/lkroesen/events{/privacy}","received_events_url":"https://api.github.com/users/lkroesen/received_events","type":"User","site_admin":false},"repo":{"id":41728060,"name":"BubbleBobble","full_name":"lkroesen/BubbleBobble","owner":{"login":"lkroesen","id":9070087,"avatar_url":"https://avatars.githubusercontent.com/u/9070087?v=3","gravatar_id":"","url":"https://api.github.com/users/lkroesen","html_url":"https://github.com/lkroesen","followers_url":"https://api.github.com/users/lkroesen/followers","following_url":"https://api.github.com/users/lkroesen/following{/other_user}","gists_url":"https://api.github.com/users/lkroesen/gists{/gist_id}","starred_url":"https://api.github.com/users/lkroesen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lkroesen/subscriptions","organizations_url":"https://api.github.com/users/lkroesen/orgs","repos_url":"https://api.github.com/users/lkroesen/repos","events_url":"https://api.github.com/users/lkroesen/events{/privacy}","received_events_url":"https://api.github.com/users/lkroesen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lkroesen/BubbleBobble","description":"","fork":false,"url":"https://api.github.com/repos/lkroesen/BubbleBobble","forks_url":"https://api.github.com/repos/lkroesen/BubbleBobble/forks","keys_url":"https://api.github.com/repos/lkroesen/BubbleBobble/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lkroesen/BubbleBobble/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lkroesen/BubbleBobble/teams","hooks_url":"https://api.github.com/repos/lkroesen/BubbleBobble/hooks","issue_events_url":"https://api.github.com/repos/lkroesen/BubbleBobble/issues/events{/number}","events_url":"https://api.github.com/repos/lkroesen/BubbleBobble/events","assignees_url":"https://api.github.com/repos/lkroesen/BubbleBobble/assignees{/user}","branches_url":"https://api.github.com/repos/lkroesen/BubbleBobble/branches{/branch}","tags_url":"https://api.github.com/repos/lkroesen/BubbleBobble/tags","blobs_url":"https://api.github.com/repos/lkroesen/BubbleBobble/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lkroesen/BubbleBobble/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lkroesen/BubbleBobble/git/refs{/sha}","trees_url":"https://api.github.com/repos/lkroesen/BubbleBobble/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lkroesen/BubbleBobble/statuses/{sha}","languages_url":"https://api.github.com/repos/lkroesen/BubbleBobble/languages","stargazers_url":"https://api.github.com/repos/lkroesen/BubbleBobble/stargazers","contributors_url":"https://api.github.com/repos/lkroesen/BubbleBobble/contributors","subscribers_url":"https://api.github.com/repos/lkroesen/BubbleBobble/subscribers","subscription_url":"https://api.github.com/repos/lkroesen/BubbleBobble/subscription","commits_url":"https://api.github.com/repos/lkroesen/BubbleBobble/commits{/sha}","git_commits_url":"https://api.github.com/repos/lkroesen/BubbleBobble/git/commits{/sha}","comments_url":"https://api.github.com/repos/lkroesen/BubbleBobble/comments{/number}","issue_comment_url":"https://api.github.com/repos/lkroesen/BubbleBobble/issues/comments{/number}","contents_url":"https://api.github.com/repos/lkroesen/BubbleBobble/contents/{+path}","compare_url":"https://api.github.com/repos/lkroesen/BubbleBobble/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lkroesen/BubbleBobble/merges","archive_url":"https://api.github.com/repos/lkroesen/BubbleBobble/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lkroesen/BubbleBobble/downloads","issues_url":"https://api.github.com/repos/lkroesen/BubbleBobble/issues{/number}","pulls_url":"https://api.github.com/repos/lkroesen/BubbleBobble/pulls{/number}","milestones_url":"https://api.github.com/repos/lkroesen/BubbleBobble/milestones{/number}","notifications_url":"https://api.github.com/repos/lkroesen/BubbleBobble/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lkroesen/BubbleBobble/labels{/name}","releases_url":"https://api.github.com/repos/lkroesen/BubbleBobble/releases{/id}","created_at":"2015-09-01T08:58:50Z","updated_at":"2015-09-01T10:12:36Z","pushed_at":"2015-09-23T19:16:33Z","git_url":"git://github.com/lkroesen/BubbleBobble.git","ssh_url":"git@github.com:lkroesen/BubbleBobble.git","clone_url":"https://github.com/lkroesen/BubbleBobble.git","svn_url":"https://github.com/lkroesen/BubbleBobble","homepage":null,"size":109216,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":12,"forks":0,"open_issues":12,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lkroesen/BubbleBobble/pulls/35"},"html":{"href":"https://github.com/lkroesen/BubbleBobble/pull/35"},"issue":{"href":"https://api.github.com/repos/lkroesen/BubbleBobble/issues/35"},"comments":{"href":"https://api.github.com/repos/lkroesen/BubbleBobble/issues/35/comments"},"review_comments":{"href":"https://api.github.com/repos/lkroesen/BubbleBobble/pulls/35/comments"},"review_comment":{"href":"https://api.github.com/repos/lkroesen/BubbleBobble/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lkroesen/BubbleBobble/pulls/35/commits"},"statuses":{"href":"https://api.github.com/repos/lkroesen/BubbleBobble/statuses/e0efa5ee1ed2712721f156a02ad40f47404f8f52"}}}}