{"action":"created","issue":{"url":"https://api.github.com/repos/elastic/elasticsearch/issues/13353","labels_url":"https://api.github.com/repos/elastic/elasticsearch/issues/13353/labels{/name}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/issues/13353/comments","events_url":"https://api.github.com/repos/elastic/elasticsearch/issues/13353/events","html_url":"https://github.com/elastic/elasticsearch/pull/13353","id":104942177,"number":13353,"title":"Remove use of underscore as an identifier","user":{"login":"jasontedor","id":4744941,"avatar_url":"https://avatars.githubusercontent.com/u/4744941?v=3","gravatar_id":"","url":"https://api.github.com/users/jasontedor","html_url":"https://github.com/jasontedor","followers_url":"https://api.github.com/users/jasontedor/followers","following_url":"https://api.github.com/users/jasontedor/following{/other_user}","gists_url":"https://api.github.com/users/jasontedor/gists{/gist_id}","starred_url":"https://api.github.com/users/jasontedor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasontedor/subscriptions","organizations_url":"https://api.github.com/users/jasontedor/orgs","repos_url":"https://api.github.com/users/jasontedor/repos","events_url":"https://api.github.com/users/jasontedor/events{/privacy}","received_events_url":"https://api.github.com/users/jasontedor/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/elastic/elasticsearch/labels/:Internal","name":":Internal","color":"009800"},{"url":"https://api.github.com/repos/elastic/elasticsearch/labels/enhancement","name":"enhancement","color":"4a4ea8"},{"url":"https://api.github.com/repos/elastic/elasticsearch/labels/review","name":"review","color":"0052cc"},{"url":"https://api.github.com/repos/elastic/elasticsearch/labels/v3.0.0","name":"v3.0.0","color":"ededed"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-09-04T18:21:11Z","updated_at":"2015-09-04T18:27:33Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/elastic/elasticsearch/pulls/13353","html_url":"https://github.com/elastic/elasticsearch/pull/13353","diff_url":"https://github.com/elastic/elasticsearch/pull/13353.diff","patch_url":"https://github.com/elastic/elasticsearch/pull/13353.patch"},"body":"As a refinement to Project Coin ([JEP-213](http://openjdk.java.net/jeps/213), [JDK-8042880](https://bugs.openjdk.java.net/browse/JDK-8042880)), Java 9 is going\r\nto disallow the use of `_` as a one-character identifier. This will be\r\ndone by adding `_` as a keyword to the Java language ([JDK-8065599](https://bugs.openjdk.java.net/browse/JDK-8065599)).\r\nCurrently, uses of `_` as a one-character identifier are warnings in\r\nthe Java 8 compiler. This commit removes all uses of `_` as a\r\none-character identifier from the codebase."},"comment":{"url":"https://api.github.com/repos/elastic/elasticsearch/issues/comments/137812878","html_url":"https://github.com/elastic/elasticsearch/pull/13353#issuecomment-137812878","issue_url":"https://api.github.com/repos/elastic/elasticsearch/issues/13353","id":137812878,"user":{"login":"jasontedor","id":4744941,"avatar_url":"https://avatars.githubusercontent.com/u/4744941?v=3","gravatar_id":"","url":"https://api.github.com/users/jasontedor","html_url":"https://github.com/jasontedor","followers_url":"https://api.github.com/users/jasontedor/followers","following_url":"https://api.github.com/users/jasontedor/following{/other_user}","gists_url":"https://api.github.com/users/jasontedor/gists{/gist_id}","starred_url":"https://api.github.com/users/jasontedor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasontedor/subscriptions","organizations_url":"https://api.github.com/users/jasontedor/orgs","repos_url":"https://api.github.com/users/jasontedor/repos","events_url":"https://api.github.com/users/jasontedor/events{/privacy}","received_events_url":"https://api.github.com/users/jasontedor/received_events","type":"User","site_admin":false},"created_at":"2015-09-04T18:27:33Z","updated_at":"2015-09-04T18:27:33Z","body":"@nik9000 We do not, but I'm not sure if it's worth the effort. In this particular case, when JDK 9 is stable enough for the CI infrastructure to start running builds against it again, those failing builds will be loud enough (assuming that the '_' proposal is actually merged into mainline JDK 9) to get our attention. Whether or not there is a general need for banning certain identifier names I'm not sure."}}