{"action":"created","issue":{"url":"https://api.github.com/repos/PaxInstruments/t400-electronics/issues/189","labels_url":"https://api.github.com/repos/PaxInstruments/t400-electronics/issues/189/labels{/name}","comments_url":"https://api.github.com/repos/PaxInstruments/t400-electronics/issues/189/comments","events_url":"https://api.github.com/repos/PaxInstruments/t400-electronics/issues/189/events","html_url":"https://github.com/PaxInstruments/t400-electronics/issues/189","id":101148423,"number":189,"title":"Suggestion: depopulate or remove external pullups on the buttons","user":{"login":"cibomahto","id":44493,"avatar_url":"https://avatars.githubusercontent.com/u/44493?v=3","gravatar_id":"","url":"https://api.github.com/users/cibomahto","html_url":"https://github.com/cibomahto","followers_url":"https://api.github.com/users/cibomahto/followers","following_url":"https://api.github.com/users/cibomahto/following{/other_user}","gists_url":"https://api.github.com/users/cibomahto/gists{/gist_id}","starred_url":"https://api.github.com/users/cibomahto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cibomahto/subscriptions","organizations_url":"https://api.github.com/users/cibomahto/orgs","repos_url":"https://api.github.com/users/cibomahto/repos","events_url":"https://api.github.com/users/cibomahto/events{/privacy}","received_events_url":"https://api.github.com/users/cibomahto/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/PaxInstruments/t400-electronics/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-08-15T06:51:08Z","updated_at":"2015-08-17T07:28:15Z","closed_at":"2015-08-17T07:28:15Z","body":"External pullups are usually only necessary when the traces from button to processor input are long, or expected to be subject to large amounts of external noise. Neither of these seems to apply here, and the internal resistors should work fine for the buttons.\r\n\r\n![screen shot 2015-08-15 at 2 46 51 pm](https://cloud.githubusercontent.com/assets/44493/9287829/9bf5c63a-435c-11e5-9adb-b470120c45bb.png)\r\n"},"comment":{"url":"https://api.github.com/repos/PaxInstruments/t400-electronics/issues/comments/131705178","html_url":"https://github.com/PaxInstruments/t400-electronics/issues/189#issuecomment-131705178","issue_url":"https://api.github.com/repos/PaxInstruments/t400-electronics/issues/189","id":131705178,"user":{"login":"charlespax","id":281642,"avatar_url":"https://avatars.githubusercontent.com/u/281642?v=3","gravatar_id":"","url":"https://api.github.com/users/charlespax","html_url":"https://github.com/charlespax","followers_url":"https://api.github.com/users/charlespax/followers","following_url":"https://api.github.com/users/charlespax/following{/other_user}","gists_url":"https://api.github.com/users/charlespax/gists{/gist_id}","starred_url":"https://api.github.com/users/charlespax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charlespax/subscriptions","organizations_url":"https://api.github.com/users/charlespax/orgs","repos_url":"https://api.github.com/users/charlespax/repos","events_url":"https://api.github.com/users/charlespax/events{/privacy}","received_events_url":"https://api.github.com/users/charlespax/received_events","type":"User","site_admin":false},"created_at":"2015-08-17T07:28:15Z","updated_at":"2015-08-17T07:28:15Z","body":"Yes, Sam, let's keep them in the design as DNP. It can be useful to have them there in other derivative designs. For example, to make the LCD shield I just copied the Eagle files and removed a bunch of parts. It would be good to now have to add them back later. However, if we run into an issue we can solve by removing them, we should remove them. I made a note for production https://github.com/PaxInstruments/t400-electronics/issues/191"}}