{"action":"created","issue":{"url":"https://api.github.com/repos/highfidelity/hifi/issues/4386","labels_url":"https://api.github.com/repos/highfidelity/hifi/issues/4386/labels{/name}","comments_url":"https://api.github.com/repos/highfidelity/hifi/issues/4386/comments","events_url":"https://api.github.com/repos/highfidelity/hifi/issues/4386/events","html_url":"https://github.com/highfidelity/hifi/pull/4386","id":60159280,"number":4386,"title":"Update Oculus SDK integration","user":{"login":"jherico","id":1533642,"avatar_url":"https://avatars.githubusercontent.com/u/1533642?v=3","gravatar_id":"","url":"https://api.github.com/users/jherico","html_url":"https://github.com/jherico","followers_url":"https://api.github.com/users/jherico/followers","following_url":"https://api.github.com/users/jherico/following{/other_user}","gists_url":"https://api.github.com/users/jherico/gists{/gist_id}","starred_url":"https://api.github.com/users/jherico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jherico/subscriptions","organizations_url":"https://api.github.com/users/jherico/orgs","repos_url":"https://api.github.com/users/jherico/repos","events_url":"https://api.github.com/users/jherico/events{/privacy}","received_events_url":"https://api.github.com/users/jherico/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"ZappoMan","id":2093195,"avatar_url":"https://avatars.githubusercontent.com/u/2093195?v=3","gravatar_id":"","url":"https://api.github.com/users/ZappoMan","html_url":"https://github.com/ZappoMan","followers_url":"https://api.github.com/users/ZappoMan/followers","following_url":"https://api.github.com/users/ZappoMan/following{/other_user}","gists_url":"https://api.github.com/users/ZappoMan/gists{/gist_id}","starred_url":"https://api.github.com/users/ZappoMan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZappoMan/subscriptions","organizations_url":"https://api.github.com/users/ZappoMan/orgs","repos_url":"https://api.github.com/users/ZappoMan/repos","events_url":"https://api.github.com/users/ZappoMan/events{/privacy}","received_events_url":"https://api.github.com/users/ZappoMan/received_events","type":"User","site_admin":false},"milestone":null,"comments":19,"created_at":"2015-03-06T21:11:27Z","updated_at":"2015-03-11T07:37:57Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/4386","html_url":"https://github.com/highfidelity/hifi/pull/4386","diff_url":"https://github.com/highfidelity/hifi/pull/4386.diff","patch_url":"https://github.com/highfidelity/hifi/pull/4386.patch"},"body":"This CR represents some work to bring the Oculus integration up to date.  This change should also enable Direct HMD mode on platforms where it is supported. \r\n\r\nFirst, it changes the Oculus SDK to an 'external project', bringing it inline with some of the other dependencies like GLEW, GLM, etc.  This ends up changing the Oculus SDK dependency from optional to required, but reduces the effort needed by people building the project to get it working.\r\n\r\nThe FindOVR.cmake file has been somewhat butchered, because I'm not focused on the android integration, so I may have broken it.  \r\n\r\nThere is also a small change that allows a user to disable nSight integration from the CMake command line, as I have nSight on my system, but when the integration is found the build either  breaks or the app will not run.  "},"comment":{"url":"https://api.github.com/repos/highfidelity/hifi/issues/comments/78217327","html_url":"https://github.com/highfidelity/hifi/pull/4386#issuecomment-78217327","issue_url":"https://api.github.com/repos/highfidelity/hifi/issues/4386","id":78217327,"user":{"login":"jherico","id":1533642,"avatar_url":"https://avatars.githubusercontent.com/u/1533642?v=3","gravatar_id":"","url":"https://api.github.com/users/jherico","html_url":"https://github.com/jherico","followers_url":"https://api.github.com/users/jherico/followers","following_url":"https://api.github.com/users/jherico/following{/other_user}","gists_url":"https://api.github.com/users/jherico/gists{/gist_id}","starred_url":"https://api.github.com/users/jherico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jherico/subscriptions","organizations_url":"https://api.github.com/users/jherico/orgs","repos_url":"https://api.github.com/users/jherico/repos","events_url":"https://api.github.com/users/jherico/events{/privacy}","received_events_url":"https://api.github.com/users/jherico/received_events","type":"User","site_admin":false},"created_at":"2015-03-11T07:37:57Z","updated_at":"2015-03-11T07:37:57Z","body":"I'm investigating the performance of the framerate change, but I'm having a hard time understanding the framerate calculation code.  Often, even if I have v-sync enabled it will report well above my actual screen refresh rate, which makes me wary of it's accuracy.  My own tests seem to indicate that regardless of v-sync paintGL is being called more often than the refresh rate.... hmmmm."}}