{"action":"created","issue":{"url":"https://api.github.com/repos/petkaantonov/bluebird/issues/482","labels_url":"https://api.github.com/repos/petkaantonov/bluebird/issues/482/labels{/name}","comments_url":"https://api.github.com/repos/petkaantonov/bluebird/issues/482/comments","events_url":"https://api.github.com/repos/petkaantonov/bluebird/issues/482/events","html_url":"https://github.com/petkaantonov/bluebird/issues/482","id":56558478,"number":482,"title":"then warning creates messy logs for thenable APIs","user":{"login":"bendrucker","id":808808,"avatar_url":"https://avatars.githubusercontent.com/u/808808?v=3","gravatar_id":"","url":"https://api.github.com/users/bendrucker","html_url":"https://github.com/bendrucker","followers_url":"https://api.github.com/users/bendrucker/followers","following_url":"https://api.github.com/users/bendrucker/following{/other_user}","gists_url":"https://api.github.com/users/bendrucker/gists{/gist_id}","starred_url":"https://api.github.com/users/bendrucker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bendrucker/subscriptions","organizations_url":"https://api.github.com/users/bendrucker/orgs","repos_url":"https://api.github.com/users/bendrucker/repos","events_url":"https://api.github.com/users/bendrucker/events{/privacy}","received_events_url":"https://api.github.com/users/bendrucker/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2015-02-04T17:23:20Z","updated_at":"2015-02-04T21:03:05Z","closed_at":null,"body":"The [recent addition of warnings when `then` is called with a non function argument](https://github.com/petkaantonov/bluebird/commit/c352c3760422adae611fbf486ae96a5be308d27a) is creating messy test output over at [Knex](http://knexjs.org/). The basic issue here is that [query objects are thenables](https://github.com/tgriesser/knex/blob/master/lib/interface.js#L25-L28) that proxy to a real promise which gets created. Since [`Promise.longStackTraces`](https://github.com/petkaantonov/bluebird/blob/master/src/debuggability.js#L136) turns on debugging, we're getting loads of warnings about empty thens in the integration tests.\r\n\r\nThe easy fix here is just to revert the warning, but I understand if there was a compelling reason to do it. We could also use `promise.then.apply(promise, arguments)` in place of explicitly passing the two callbacks to `promise.then`. I'd prefer not to go that route since it's harder to read/understand."},"comment":{"url":"https://api.github.com/repos/petkaantonov/bluebird/issues/comments/72938607","html_url":"https://github.com/petkaantonov/bluebird/issues/482#issuecomment-72938607","issue_url":"https://api.github.com/repos/petkaantonov/bluebird/issues/482","id":72938607,"user":{"login":"bendrucker","id":808808,"avatar_url":"https://avatars.githubusercontent.com/u/808808?v=3","gravatar_id":"","url":"https://api.github.com/users/bendrucker","html_url":"https://github.com/bendrucker","followers_url":"https://api.github.com/users/bendrucker/followers","following_url":"https://api.github.com/users/bendrucker/following{/other_user}","gists_url":"https://api.github.com/users/bendrucker/gists{/gist_id}","starred_url":"https://api.github.com/users/bendrucker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bendrucker/subscriptions","organizations_url":"https://api.github.com/users/bendrucker/orgs","repos_url":"https://api.github.com/users/bendrucker/repos","events_url":"https://api.github.com/users/bendrucker/events{/privacy}","received_events_url":"https://api.github.com/users/bendrucker/received_events","type":"User","site_admin":false},"created_at":"2015-02-04T21:03:05Z","updated_at":"2015-02-04T21:03:05Z","body":"If you're considering reverting and saving for 3.0 I'll wait on that. Otherwise I'll drop in a fix and probably just end up applying the arguments."}}