{"action":"created","issue":{"url":"https://api.github.com/repos/docker/libcontainer/issues/418","labels_url":"https://api.github.com/repos/docker/libcontainer/issues/418/labels{/name}","comments_url":"https://api.github.com/repos/docker/libcontainer/issues/418/comments","events_url":"https://api.github.com/repos/docker/libcontainer/issues/418/events","html_url":"https://github.com/docker/libcontainer/pull/418","id":59210575,"number":418,"title":"Setup environment for processes with os.Environ()","user":{"login":"dqminh","id":62707,"avatar_url":"https://avatars.githubusercontent.com/u/62707?v=3","gravatar_id":"","url":"https://api.github.com/users/dqminh","html_url":"https://github.com/dqminh","followers_url":"https://api.github.com/users/dqminh/followers","following_url":"https://api.github.com/users/dqminh/following{/other_user}","gists_url":"https://api.github.com/users/dqminh/gists{/gist_id}","starred_url":"https://api.github.com/users/dqminh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dqminh/subscriptions","organizations_url":"https://api.github.com/users/dqminh/orgs","repos_url":"https://api.github.com/users/dqminh/repos","events_url":"https://api.github.com/users/dqminh/events{/privacy}","received_events_url":"https://api.github.com/users/dqminh/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":17,"created_at":"2015-02-27T09:30:18Z","updated_at":"2015-03-03T17:14:43Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/docker/libcontainer/pulls/418","html_url":"https://github.com/docker/libcontainer/pull/418","diff_url":"https://github.com/docker/libcontainer/pull/418.diff","patch_url":"https://github.com/docker/libcontainer/pull/418.patch"},"body":"- `genericError` constructor should not panic when we pass in `nil` error, but we should not pass nil error actually. This fixes it.\r\n- Instead of taking the raw config.Env, we use `os.Environ()` when execve which works correctly because the environment has been setup properly with `newContainerInit`\r\n"},"comment":{"url":"https://api.github.com/repos/docker/libcontainer/issues/comments/76989271","html_url":"https://github.com/docker/libcontainer/pull/418#issuecomment-76989271","issue_url":"https://api.github.com/repos/docker/libcontainer/issues/418","id":76989271,"user":{"login":"LK4D4","id":101445,"avatar_url":"https://avatars.githubusercontent.com/u/101445?v=3","gravatar_id":"","url":"https://api.github.com/users/LK4D4","html_url":"https://github.com/LK4D4","followers_url":"https://api.github.com/users/LK4D4/followers","following_url":"https://api.github.com/users/LK4D4/following{/other_user}","gists_url":"https://api.github.com/users/LK4D4/gists{/gist_id}","starred_url":"https://api.github.com/users/LK4D4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LK4D4/subscriptions","organizations_url":"https://api.github.com/users/LK4D4/orgs","repos_url":"https://api.github.com/users/LK4D4/repos","events_url":"https://api.github.com/users/LK4D4/events{/privacy}","received_events_url":"https://api.github.com/users/LK4D4/received_events","type":"User","site_admin":false},"created_at":"2015-03-03T17:14:43Z","updated_at":"2015-03-03T17:14:43Z","body":"I'm not sure about PATH, but \"HOME\" we set indeed before `Execv` in `setupUser` by `os.Setenv`, should we pass `append(l.config.Env, os.Getenv(\"HOME\")`?"}}