{"action":"created","issue":{"url":"https://api.github.com/repos/otland/forgottenserver/issues/1305","labels_url":"https://api.github.com/repos/otland/forgottenserver/issues/1305/labels{/name}","comments_url":"https://api.github.com/repos/otland/forgottenserver/issues/1305/comments","events_url":"https://api.github.com/repos/otland/forgottenserver/issues/1305/events","html_url":"https://github.com/otland/forgottenserver/pull/1305","id":69979588,"number":1305,"title":"Fix attack scheduler","user":{"login":"ranisalt","id":1993083,"avatar_url":"https://avatars.githubusercontent.com/u/1993083?v=3","gravatar_id":"","url":"https://api.github.com/users/ranisalt","html_url":"https://github.com/ranisalt","followers_url":"https://api.github.com/users/ranisalt/followers","following_url":"https://api.github.com/users/ranisalt/following{/other_user}","gists_url":"https://api.github.com/users/ranisalt/gists{/gist_id}","starred_url":"https://api.github.com/users/ranisalt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ranisalt/subscriptions","organizations_url":"https://api.github.com/users/ranisalt/orgs","repos_url":"https://api.github.com/users/ranisalt/repos","events_url":"https://api.github.com/users/ranisalt/events{/privacy}","received_events_url":"https://api.github.com/users/ranisalt/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-04-21T23:38:46Z","updated_at":"2015-05-29T06:19:13Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/otland/forgottenserver/pulls/1305","html_url":"https://github.com/otland/forgottenserver/pull/1305","diff_url":"https://github.com/otland/forgottenserver/pull/1305.diff","patch_url":"https://github.com/otland/forgottenserver/pull/1305.patch"},"body":"I have stumbled across this problem when I was trying to use an attack speed that was not a multiple of 1000. Apparently the server only checks if there is a new action every 1000 ms, but this limits attack speed to multiples of this time frame, as the server won't check if there is a new attack to calculate in between time frames.\r\n\r\nThis fix changes it by adding a new SchedulerTask when the attack is in the middle of a time frame. I haven't had time and resources to check if this is a heavy change and if this works properly 100% of the time, but I hope @marksamman can have a look and say somethind :grinning: "},"comment":{"url":"https://api.github.com/repos/otland/forgottenserver/issues/comments/106704002","html_url":"https://github.com/otland/forgottenserver/pull/1305#issuecomment-106704002","issue_url":"https://api.github.com/repos/otland/forgottenserver/issues/1305","id":106704002,"user":{"login":"ranisalt","id":1993083,"avatar_url":"https://avatars.githubusercontent.com/u/1993083?v=3","gravatar_id":"","url":"https://api.github.com/users/ranisalt","html_url":"https://github.com/ranisalt","followers_url":"https://api.github.com/users/ranisalt/followers","following_url":"https://api.github.com/users/ranisalt/following{/other_user}","gists_url":"https://api.github.com/users/ranisalt/gists{/gist_id}","starred_url":"https://api.github.com/users/ranisalt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ranisalt/subscriptions","organizations_url":"https://api.github.com/users/ranisalt/orgs","repos_url":"https://api.github.com/users/ranisalt/repos","events_url":"https://api.github.com/users/ranisalt/events{/privacy}","received_events_url":"https://api.github.com/users/ranisalt/received_events","type":"User","site_admin":false},"created_at":"2015-05-29T06:19:13Z","updated_at":"2015-05-29T06:19:13Z","body":"How's that going?"}}