{"action":"created","issue":{"url":"https://api.github.com/repos/open-craft/problem-builder/issues/80","labels_url":"https://api.github.com/repos/open-craft/problem-builder/issues/80/labels{/name}","comments_url":"https://api.github.com/repos/open-craft/problem-builder/issues/80/comments","events_url":"https://api.github.com/repos/open-craft/problem-builder/issues/80/events","html_url":"https://github.com/open-craft/problem-builder/pull/80","id":112500579,"number":80,"title":"Fix: Problem Builder does not show on Progress page until student submits an answer (OC-1033)","user":{"login":"bradenmacdonald","id":945577,"avatar_url":"https://avatars.githubusercontent.com/u/945577?v=3","gravatar_id":"","url":"https://api.github.com/users/bradenmacdonald","html_url":"https://github.com/bradenmacdonald","followers_url":"https://api.github.com/users/bradenmacdonald/followers","following_url":"https://api.github.com/users/bradenmacdonald/following{/other_user}","gists_url":"https://api.github.com/users/bradenmacdonald/gists{/gist_id}","starred_url":"https://api.github.com/users/bradenmacdonald/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bradenmacdonald/subscriptions","organizations_url":"https://api.github.com/users/bradenmacdonald/orgs","repos_url":"https://api.github.com/users/bradenmacdonald/repos","events_url":"https://api.github.com/users/bradenmacdonald/events{/privacy}","received_events_url":"https://api.github.com/users/bradenmacdonald/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":11,"created_at":"2015-10-21T02:37:33Z","updated_at":"2015-10-22T23:40:48Z","closed_at":"2015-10-22T18:57:48Z","pull_request":{"url":"https://api.github.com/repos/open-craft/problem-builder/pulls/80","html_url":"https://github.com/open-craft/problem-builder/pull/80","diff_url":"https://github.com/open-craft/problem-builder/pull/80.diff","patch_url":"https://github.com/open-craft/problem-builder/pull/80.patch"},"body":"OC-1033\r\n\r\n**Fix Description**\r\nWithout this fix, Problem Builder blocks do not appear on a student's \"Progress\" page until the student has submitted a grade. The reason was that Problem Builder did not implement the `max_score()` method.\r\n\r\n**Potential Further Improvement**\r\nProblem Builder blocks currently return scores as floating point values between `0` and `1`. It would be better to return integer numerator/denominator pairs (simpler for students, more reliable, more consistent with CAPA modules). However, changing that in the middle of any live course could cause some students' scores to be weighted differently than others. (e.g. Student A could have a score of '0.5/1' while student B could submit the same answer post-upgrade and get a score of '1/2' - which is theoretically the same but would be weighted more heavily when computing the grade of that unit as a whole). \r\n\r\nThat said, if the currently live course[s] mostly use problem builder blocks containing only one question each, it would make sense to make that change/fix now.\r\n\r\n**Note**\r\nThis PR also includes some fixes for the Travis CI build, but those changes do not affect the code itself and are contained to `.travis.yml`"},"comment":{"url":"https://api.github.com/repos/open-craft/problem-builder/issues/comments/150387649","html_url":"https://github.com/open-craft/problem-builder/pull/80#issuecomment-150387649","issue_url":"https://api.github.com/repos/open-craft/problem-builder/issues/80","id":150387649,"user":{"login":"bradenmacdonald","id":945577,"avatar_url":"https://avatars.githubusercontent.com/u/945577?v=3","gravatar_id":"","url":"https://api.github.com/users/bradenmacdonald","html_url":"https://github.com/bradenmacdonald","followers_url":"https://api.github.com/users/bradenmacdonald/followers","following_url":"https://api.github.com/users/bradenmacdonald/following{/other_user}","gists_url":"https://api.github.com/users/bradenmacdonald/gists{/gist_id}","starred_url":"https://api.github.com/users/bradenmacdonald/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bradenmacdonald/subscriptions","organizations_url":"https://api.github.com/users/bradenmacdonald/orgs","repos_url":"https://api.github.com/users/bradenmacdonald/repos","events_url":"https://api.github.com/users/bradenmacdonald/events{/privacy}","received_events_url":"https://api.github.com/users/bradenmacdonald/received_events","type":"User","site_admin":false},"created_at":"2015-10-22T23:40:48Z","updated_at":"2015-10-22T23:40:48Z","body":"Following up on the discussion here about further improvements, it seems that the platform always scales the score of our block to the value of its `weight` field. (So whether we report the score as \"0.8\" or \"4/5\", students always see just \"0.8\" if the `weight` is kept at its defaults value of `1.0`) So although that means that we could actually re-scale the scores to be integers rather than floats without any consequences, it also means that there wouldn't be much point in doing so. So I'm going to just leave that as-is."}}