{"action":"created","issue":{"url":"https://api.github.com/repos/edx/ux-pattern-library/issues/19","labels_url":"https://api.github.com/repos/edx/ux-pattern-library/issues/19/labels{/name}","comments_url":"https://api.github.com/repos/edx/ux-pattern-library/issues/19/comments","events_url":"https://api.github.com/repos/edx/ux-pattern-library/issues/19/events","html_url":"https://github.com/edx/ux-pattern-library/pull/19","id":64836540,"number":19,"title":"Elements: Buttons","user":{"login":"clrux","id":2112024,"avatar_url":"https://avatars.githubusercontent.com/u/2112024?v=3","gravatar_id":"","url":"https://api.github.com/users/clrux","html_url":"https://github.com/clrux","followers_url":"https://api.github.com/users/clrux/followers","following_url":"https://api.github.com/users/clrux/following{/other_user}","gists_url":"https://api.github.com/users/clrux/gists{/gist_id}","starred_url":"https://api.github.com/users/clrux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clrux/subscriptions","organizations_url":"https://api.github.com/users/clrux/orgs","repos_url":"https://api.github.com/users/clrux/repos","events_url":"https://api.github.com/users/clrux/events{/privacy}","received_events_url":"https://api.github.com/users/clrux/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-03-27T19:31:53Z","updated_at":"2015-04-10T14:03:19Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/edx/ux-pattern-library/pulls/19","html_url":"https://github.com/edx/ux-pattern-library/pull/19","diff_url":"https://github.com/edx/ux-pattern-library/pull/19.diff","patch_url":"https://github.com/edx/ux-pattern-library/pull/19.patch"},"body":"# Elements: Buttons\r\nThis pull request establishes Sass partials for our buttons and contains a demo page that displays them all using our created styles.\r\n\r\n**Buttons with icons are not yet included as we don't have a finished set of icons to incorporate.**\r\n\r\n@talbs Please review at your convenience."},"comment":{"url":"https://api.github.com/repos/edx/ux-pattern-library/issues/comments/91569187","html_url":"https://github.com/edx/ux-pattern-library/pull/19#issuecomment-91569187","issue_url":"https://api.github.com/repos/edx/ux-pattern-library/issues/19","id":91569187,"user":{"login":"talbs","id":163763,"avatar_url":"https://avatars.githubusercontent.com/u/163763?v=3","gravatar_id":"","url":"https://api.github.com/users/talbs","html_url":"https://github.com/talbs","followers_url":"https://api.github.com/users/talbs/followers","following_url":"https://api.github.com/users/talbs/following{/other_user}","gists_url":"https://api.github.com/users/talbs/gists{/gist_id}","starred_url":"https://api.github.com/users/talbs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/talbs/subscriptions","organizations_url":"https://api.github.com/users/talbs/orgs","repos_url":"https://api.github.com/users/talbs/repos","events_url":"https://api.github.com/users/talbs/events{/privacy}","received_events_url":"https://api.github.com/users/talbs/received_events","type":"User","site_admin":false},"created_at":"2015-04-10T14:03:19Z","updated_at":"2015-04-10T14:03:19Z","body":"@clrux, this is really well-organized work. Thanks!\r\n\r\nI've left some comments inline, but I also have a few larger ones for all of buttons:\r\n\r\n1. **Theming** - I'd like us to plumb through theming into the values of a lot of these button properties . Remember that we're trying to tackle theming hooks with each new pattern/component we're adding. Can you A) revise and abstract the properties you've added based on the [spirit of this Theming inventory doc](https://docs.google.com/a/edx.org/spreadsheets/d/1kHttF70rf2p7-9-Ev6kubfSFwncrDi0KzwFO9jArOx0/edit?usp=sharing), B) adjust anything needed at a configuration level (mostly in ``_variables.scss``) to support that work, and C) test this against an updated version of your faux MIT theming branch?\r\n2. **Arrangement + Alignment** - While grids are a bit away, should we give folks utility classes to have buttons display inline/inline-block next to each other vs. taking up a whole visual line with more block displays\r\n3. **Links and Other Actions** - The examples you added are all ``<button>``-based. These classes should cosmetically be able to be applied to other things we want to visually look like an action (the most common case will be an ``<a>``). Can you test that this can be done and also provide an example of that in your new post markdown? Also, is this the time and place to add basic text link (and maybe image/whole block-level element) link stylng since you have some visual cues to go from?\r\n\r\n- - -\r\n\r\nLet me know on all of the above. I'm still reviewing the actual rendering/visual design and will try to get some for the group to review the buttons now that you've put em in the browser wild."}}