{"push_id":898252442,"size":6,"distinct_size":6,"ref":"refs/heads/master","head":"26d30953c87b04b0029d1361f69f49b3b0448baa","before":"6f221551a396e76f047e8c36e896063b59ae604f","commits":[{"sha":"74d327f2730e9fc7dcf3b8aba195c45c97f136f1","author":{"email":"9c008e38982a5397deb855345fb164f0558459ae@redhat.com","name":"Miloslav Trmač"},"message":"Remove an incorrect comment.\n\nThe commented code is not converting DER to PEM, it is parsing DER into\nan in-memory data structure, and is hopefully just as clear without a\ncomment.\n\nSigned-off-by: Miloslav Trmač <mitr@redhat.com>","distinct":true,"url":"https://api.github.com/repos/docker/notary/commits/74d327f2730e9fc7dcf3b8aba195c45c97f136f1"},{"sha":"d5c080ae9cb1d27893f4928caae49995da0fa7e3","author":{"email":"9c008e38982a5397deb855345fb164f0558459ae@redhat.com","name":"Miloslav Trmač"},"message":"Add cryptoservice.GenerateTestingCertificate\n\nVarious tests have been calling trustmanager.NewCertificate and\nopen-coding most of cryptoservice.GenerateCertificate.  So, add\ncryptoservice.GenerateTestingCertificate.  It differs only by using\ncrypto.Signer instead of data.PrivateKey because the tests\nhave a crypto.Signer more frequently available, and converting\nfrom data.PrivateKey to crypto.Signer is easier than the other way.\n\nThis will make it easier to add policy parameters which the tests don't\ncare about to trustmanager.NewCertificate and\ncryptoservice.GenerateCertificate in the future.\n\nSigned-off-by: Miloslav Trmač <mitr@redhat.com>","distinct":true,"url":"https://api.github.com/repos/docker/notary/commits/d5c080ae9cb1d27893f4928caae49995da0fa7e3"},{"sha":"3c6335c57260daae0b7c030c5403aaeda5008cc2","author":{"email":"9c008e38982a5397deb855345fb164f0558459ae@redhat.com","name":"Miloslav Trmač"},"message":"Explicitly supply validity times to certificate generation\n\nAdd explicit startTime and endTime parameters to\ncryptoservice.GenerateCertificate and trustmanager.NewCertificate.\n\ntrustmanager.NewCertificate as a low-level data manipulation function\nshould not be hard-coding policy (10-year expiration); that policy\nbelongs to its callers, or one more level higher to callers of\ncryptoservice.GenerateCertificate.\n\nThese places hard-coding policy now also have an explict comment to\nthat effect.\n\nIn addition to conceptual cleanliness, this will allow writing tests\nof certificate expiry by generating appropriate expired or nearly-expired\ncertificates.\n\nTests which don't care about the policy much will continue to use the\njust added cryptoservice.GenerateTestingCertificate.\n\nSigned-off-by: Miloslav Trmač <mitr@redhat.com>","distinct":true,"url":"https://api.github.com/repos/docker/notary/commits/3c6335c57260daae0b7c030c5403aaeda5008cc2"},{"sha":"bd6d937f43887dec7f53b371c41a1ca5dc45d218","author":{"email":"9c008e38982a5397deb855345fb164f0558459ae@redhat.com","name":"Miloslav Trmač"},"message":"Fix computation of certificate expiration\n\nInstead of 3650 days, actually use 10 years (i.e. take into account leap\ndays).\n\nSigned-off-by: Miloslav Trmač <mitr@redhat.com>","distinct":true,"url":"https://api.github.com/repos/docker/notary/commits/bd6d937f43887dec7f53b371c41a1ca5dc45d218"},{"sha":"06e58c1d11ba646f8d3181fa1ec5e9524a609289","author":{"email":"9c008e38982a5397deb855345fb164f0558459ae@redhat.com","name":"Miloslav Trmač"},"message":"Tighten TestNewCertificate tests\n\nUsing the just added facility to generate a certificate as of a specific\ntime, tighten TestNewCertificate to use equality comparisons.\n\nSigned-off-by: Miloslav Trmač <mitr@redhat.com>","distinct":true,"url":"https://api.github.com/repos/docker/notary/commits/06e58c1d11ba646f8d3181fa1ec5e9524a609289"},{"sha":"26d30953c87b04b0029d1361f69f49b3b0448baa","author":{"email":"5144c042720ac4240240f0ad1d5bf334d216b5f9@gmail.com","name":"David Lawrence"},"message":"Merge pull request #312 from mtrmac/cert-expiration\n\nCert expiration","distinct":true,"url":"https://api.github.com/repos/docker/notary/commits/26d30953c87b04b0029d1361f69f49b3b0448baa"}]}