{"action":"created","issue":{"url":"https://api.github.com/repos/EFForg/privacybadgerfirefox/issues/425","labels_url":"https://api.github.com/repos/EFForg/privacybadgerfirefox/issues/425/labels{/name}","comments_url":"https://api.github.com/repos/EFForg/privacybadgerfirefox/issues/425/comments","events_url":"https://api.github.com/repos/EFForg/privacybadgerfirefox/issues/425/events","html_url":"https://github.com/EFForg/privacybadgerfirefox/pull/425","id":96218572,"number":425,"title":"refactor cookieblocking, fixes #206","user":{"login":"cooperq","id":64981,"avatar_url":"https://avatars.githubusercontent.com/u/64981?v=3","gravatar_id":"","url":"https://api.github.com/users/cooperq","html_url":"https://github.com/cooperq","followers_url":"https://api.github.com/users/cooperq/followers","following_url":"https://api.github.com/users/cooperq/following{/other_user}","gists_url":"https://api.github.com/users/cooperq/gists{/gist_id}","starred_url":"https://api.github.com/users/cooperq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cooperq/subscriptions","organizations_url":"https://api.github.com/users/cooperq/orgs","repos_url":"https://api.github.com/users/cooperq/repos","events_url":"https://api.github.com/users/cooperq/events{/privacy}","received_events_url":"https://api.github.com/users/cooperq/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/EFForg/privacybadgerfirefox/milestones/4","html_url":"https://github.com/EFForg/privacybadgerfirefox/milestones/1.0","labels_url":"https://api.github.com/repos/EFForg/privacybadgerfirefox/milestones/4/labels","id":653512,"number":4,"title":"1.0","description":null,"creator":{"login":"pde","id":479213,"avatar_url":"https://avatars.githubusercontent.com/u/479213?v=3","gravatar_id":"","url":"https://api.github.com/users/pde","html_url":"https://github.com/pde","followers_url":"https://api.github.com/users/pde/followers","following_url":"https://api.github.com/users/pde/following{/other_user}","gists_url":"https://api.github.com/users/pde/gists{/gist_id}","starred_url":"https://api.github.com/users/pde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pde/subscriptions","organizations_url":"https://api.github.com/users/pde/orgs","repos_url":"https://api.github.com/users/pde/repos","events_url":"https://api.github.com/users/pde/events{/privacy}","received_events_url":"https://api.github.com/users/pde/received_events","type":"User","site_admin":false},"open_issues":9,"closed_issues":21,"state":"open","created_at":"2014-05-08T21:25:49Z","updated_at":"2015-07-21T03:50:11Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2015-07-21T03:41:35Z","updated_at":"2015-07-21T16:36:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/EFForg/privacybadgerfirefox/pulls/425","html_url":"https://github.com/EFForg/privacybadgerfirefox/pull/425","diff_url":"https://github.com/EFForg/privacybadgerfirefox/pull/425.diff","patch_url":"https://github.com/EFForg/privacybadgerfirefox/pull/425.patch"},"body":"cc @SwartzCr or @pde for approval. \r\nThis gets privacy badger to stop relying on firefox's cookie permissions for cookie blocking (which causes a whole host of side effects, see the list in #206) and uses our own logic for cookie blocking instead. Stripping headers and clobbering js cookies. \r\nI can't really tell you an easy way to test this, cookie block something, delete all of it's cookies, and make sure it can't set new cookies, I guess. All the tests pass, so there is that. \r\n\r\nFixes #206 "},"comment":{"url":"https://api.github.com/repos/EFForg/privacybadgerfirefox/issues/comments/123395431","html_url":"https://github.com/EFForg/privacybadgerfirefox/pull/425#issuecomment-123395431","issue_url":"https://api.github.com/repos/EFForg/privacybadgerfirefox/issues/425","id":123395431,"user":{"login":"SwartzCr","id":649860,"avatar_url":"https://avatars.githubusercontent.com/u/649860?v=3","gravatar_id":"","url":"https://api.github.com/users/SwartzCr","html_url":"https://github.com/SwartzCr","followers_url":"https://api.github.com/users/SwartzCr/followers","following_url":"https://api.github.com/users/SwartzCr/following{/other_user}","gists_url":"https://api.github.com/users/SwartzCr/gists{/gist_id}","starred_url":"https://api.github.com/users/SwartzCr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SwartzCr/subscriptions","organizations_url":"https://api.github.com/users/SwartzCr/orgs","repos_url":"https://api.github.com/users/SwartzCr/repos","events_url":"https://api.github.com/users/SwartzCr/events{/privacy}","received_events_url":"https://api.github.com/users/SwartzCr/received_events","type":"User","site_admin":false},"created_at":"2015-07-21T16:36:48Z","updated_at":"2015-07-21T16:36:48Z","body":"There seem to be major problems with the pop-up\r\nsteps to reproduce:\r\ngo to cnn.com\r\nyellowlist a domain\r\nrefresh the page, watch as the badge number doesn't not increase monotonically\r\nnotice things like this happening where something is yellowlisted according to the settings, but isn't showing up yellowlisted on the pop-up for that page\r\n![cookiestorage](https://cloud.githubusercontent.com/assets/649860/8806542/ff70d0a4-2f8b-11e5-9004-9fc547f641db.jpg)\r\n"}}