{"action":"created","issue":{"url":"https://api.github.com/repos/ukoethe/vigra/issues/227","labels_url":"https://api.github.com/repos/ukoethe/vigra/issues/227/labels{/name}","comments_url":"https://api.github.com/repos/ukoethe/vigra/issues/227/comments","events_url":"https://api.github.com/repos/ukoethe/vigra/issues/227/events","html_url":"https://github.com/ukoethe/vigra/pull/227","id":53912540,"number":227,"title":"Mac libcxx fixes (third attempt)","user":{"login":"stuarteberg","id":1655821,"avatar_url":"https://avatars.githubusercontent.com/u/1655821?v=3","gravatar_id":"","url":"https://api.github.com/users/stuarteberg","html_url":"https://github.com/stuarteberg","followers_url":"https://api.github.com/users/stuarteberg/followers","following_url":"https://api.github.com/users/stuarteberg/following{/other_user}","gists_url":"https://api.github.com/users/stuarteberg/gists{/gist_id}","starred_url":"https://api.github.com/users/stuarteberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stuarteberg/subscriptions","organizations_url":"https://api.github.com/users/stuarteberg/orgs","repos_url":"https://api.github.com/users/stuarteberg/repos","events_url":"https://api.github.com/users/stuarteberg/events{/privacy}","received_events_url":"https://api.github.com/users/stuarteberg/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-01-09T20:42:06Z","updated_at":"2015-01-09T22:25:29Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ukoethe/vigra/pulls/227","html_url":"https://github.com/ukoethe/vigra/pull/227","diff_url":"https://github.com/ukoethe/vigra/pull/227.diff","patch_url":"https://github.com/ukoethe/vigra/pull/227.patch"},"body":"Hi again,\r\n\r\nI've reworked these changes once more.  I believe the build problems on Travis and Mac mentioned in #225 should now be fixed (we'll see what Travis says).\r\n\r\nInstead of updating the old PR, I've created a new branch/PR with clean commits for each change.  Please review them.  In particular, my changes to `vigra/config.hxx` should be double-checked.\r\n\r\nOther considerations:\r\n\r\n- As before, if the user specifies `-DWITH_BOOST_THREAD`, then we never add `-std=c++11` to `CMAKE_CXX_FLAGS`, which means that the entire project is compiled in C++98 mode.  As a result, modules that **require** C++11 (so far, just the multiarray tests) should be skipped.  C++98 mode is now detected in cmake via a new `try_run` step to detect the value of `__cplusplus`\r\n- I don't know how to \"test\" for a working `isnan(int)` function at compile time, so I used `try_compile` at cmake time, along with a preprocessor definition."},"comment":{"url":"https://api.github.com/repos/ukoethe/vigra/issues/comments/69409945","html_url":"https://github.com/ukoethe/vigra/pull/227#issuecomment-69409945","issue_url":"https://api.github.com/repos/ukoethe/vigra/issues/227","id":69409945,"user":{"login":"ukoethe","id":897680,"avatar_url":"https://avatars.githubusercontent.com/u/897680?v=3","gravatar_id":"","url":"https://api.github.com/users/ukoethe","html_url":"https://github.com/ukoethe","followers_url":"https://api.github.com/users/ukoethe/followers","following_url":"https://api.github.com/users/ukoethe/following{/other_user}","gists_url":"https://api.github.com/users/ukoethe/gists{/gist_id}","starred_url":"https://api.github.com/users/ukoethe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ukoethe/subscriptions","organizations_url":"https://api.github.com/users/ukoethe/orgs","repos_url":"https://api.github.com/users/ukoethe/repos","events_url":"https://api.github.com/users/ukoethe/events{/privacy}","received_events_url":"https://api.github.com/users/ukoethe/received_events","type":"User","site_admin":false},"created_at":"2015-01-09T22:25:29Z","updated_at":"2015-01-09T22:25:29Z","body":"`make test` is a predefined target of cmake/ctest. It only works after a successfull `make` call (provided that cmake was configured with `-DAUTOBUILD_TESTS=1`). That is, one first compiles everything and then runs all tests. In contrast, `make check` executes each test immediately after compilation (unless cmake was configured with `-DAUTOEXEC_TESTS=0`). I prefer the latter behavior for test-driven development, whereas the former may be better for automated testing. I tried to implement both behaviors with just `make test`, but couldn't get cmake to do what I wanted."}}