{"action":"closed","number":247,"pull_request":{"url":"https://api.github.com/repos/fulcrum-agile/fulcrum/pulls/247","id":30734505,"html_url":"https://github.com/fulcrum-agile/fulcrum/pull/247","diff_url":"https://github.com/fulcrum-agile/fulcrum/pull/247.diff","patch_url":"https://github.com/fulcrum-agile/fulcrum/pull/247.patch","issue_url":"https://api.github.com/repos/fulcrum-agile/fulcrum/issues/247","number":247,"state":"closed","locked":false,"title":"Some JS code refactor","user":{"login":"merodriguezblanco","id":984707,"avatar_url":"https://avatars.githubusercontent.com/u/984707?v=3","gravatar_id":"","url":"https://api.github.com/users/merodriguezblanco","html_url":"https://github.com/merodriguezblanco","followers_url":"https://api.github.com/users/merodriguezblanco/followers","following_url":"https://api.github.com/users/merodriguezblanco/following{/other_user}","gists_url":"https://api.github.com/users/merodriguezblanco/gists{/gist_id}","starred_url":"https://api.github.com/users/merodriguezblanco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/merodriguezblanco/subscriptions","organizations_url":"https://api.github.com/users/merodriguezblanco/orgs","repos_url":"https://api.github.com/users/merodriguezblanco/repos","events_url":"https://api.github.com/users/merodriguezblanco/events{/privacy}","received_events_url":"https://api.github.com/users/merodriguezblanco/received_events","type":"User","site_admin":false},"body":"Hi, nice tool, congrats!\r\n\r\nI was taking a look at the code in order to see how I can contribute. I noticed that in several parts of it you ask for conditionals in the following way:\r\n\r\ntypeof foo == null\r\ntypeof bar == 'string'\r\n\r\nUnderscorejs provides of several methods that are more readable, such as _.isNull and _.isString. I think that using this methods would be less error-prone too.\r\n\r\nThe intention of this pull request is to refactor the JS of the backbone app using these underscore methods.\r\n\r\nWhat do you think?\r\n\r\nCheers!","created_at":"2015-03-09T03:43:57Z","updated_at":"2015-03-11T00:21:16Z","closed_at":"2015-03-11T00:21:16Z","merged_at":"2015-03-11T00:21:16Z","merge_commit_sha":"d604d5e3dc51d8a8d4830248d5766291484462c6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/fulcrum-agile/fulcrum/pulls/247/commits","review_comments_url":"https://api.github.com/repos/fulcrum-agile/fulcrum/pulls/247/comments","review_comment_url":"https://api.github.com/repos/fulcrum-agile/fulcrum/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fulcrum-agile/fulcrum/issues/247/comments","statuses_url":"https://api.github.com/repos/fulcrum-agile/fulcrum/statuses/759298f90862c898b0d185899f4faf777a75adf5","head":{"label":"merodriguezblanco:js-refactor","ref":"js-refactor","sha":"759298f90862c898b0d185899f4faf777a75adf5","user":{"login":"merodriguezblanco","id":984707,"avatar_url":"https://avatars.githubusercontent.com/u/984707?v=3","gravatar_id":"","url":"https://api.github.com/users/merodriguezblanco","html_url":"https://github.com/merodriguezblanco","followers_url":"https://api.github.com/users/merodriguezblanco/followers","following_url":"https://api.github.com/users/merodriguezblanco/following{/other_user}","gists_url":"https://api.github.com/users/merodriguezblanco/gists{/gist_id}","starred_url":"https://api.github.com/users/merodriguezblanco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/merodriguezblanco/subscriptions","organizations_url":"https://api.github.com/users/merodriguezblanco/orgs","repos_url":"https://api.github.com/users/merodriguezblanco/repos","events_url":"https://api.github.com/users/merodriguezblanco/events{/privacy}","received_events_url":"https://api.github.com/users/merodriguezblanco/received_events","type":"User","site_admin":false},"repo":{"id":31876133,"name":"fulcrum","full_name":"merodriguezblanco/fulcrum","owner":{"login":"merodriguezblanco","id":984707,"avatar_url":"https://avatars.githubusercontent.com/u/984707?v=3","gravatar_id":"","url":"https://api.github.com/users/merodriguezblanco","html_url":"https://github.com/merodriguezblanco","followers_url":"https://api.github.com/users/merodriguezblanco/followers","following_url":"https://api.github.com/users/merodriguezblanco/following{/other_user}","gists_url":"https://api.github.com/users/merodriguezblanco/gists{/gist_id}","starred_url":"https://api.github.com/users/merodriguezblanco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/merodriguezblanco/subscriptions","organizations_url":"https://api.github.com/users/merodriguezblanco/orgs","repos_url":"https://api.github.com/users/merodriguezblanco/repos","events_url":"https://api.github.com/users/merodriguezblanco/events{/privacy}","received_events_url":"https://api.github.com/users/merodriguezblanco/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/merodriguezblanco/fulcrum","description":"An agile project planning tool","fork":true,"url":"https://api.github.com/repos/merodriguezblanco/fulcrum","forks_url":"https://api.github.com/repos/merodriguezblanco/fulcrum/forks","keys_url":"https://api.github.com/repos/merodriguezblanco/fulcrum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/merodriguezblanco/fulcrum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/merodriguezblanco/fulcrum/teams","hooks_url":"https://api.github.com/repos/merodriguezblanco/fulcrum/hooks","issue_events_url":"https://api.github.com/repos/merodriguezblanco/fulcrum/issues/events{/number}","events_url":"https://api.github.com/repos/merodriguezblanco/fulcrum/events","assignees_url":"https://api.github.com/repos/merodriguezblanco/fulcrum/assignees{/user}","branches_url":"https://api.github.com/repos/merodriguezblanco/fulcrum/branches{/branch}","tags_url":"https://api.github.com/repos/merodriguezblanco/fulcrum/tags","blobs_url":"https://api.github.com/repos/merodriguezblanco/fulcrum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/merodriguezblanco/fulcrum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/merodriguezblanco/fulcrum/git/refs{/sha}","trees_url":"https://api.github.com/repos/merodriguezblanco/fulcrum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/merodriguezblanco/fulcrum/statuses/{sha}","languages_url":"https://api.github.com/repos/merodriguezblanco/fulcrum/languages","stargazers_url":"https://api.github.com/repos/merodriguezblanco/fulcrum/stargazers","contributors_url":"https://api.github.com/repos/merodriguezblanco/fulcrum/contributors","subscribers_url":"https://api.github.com/repos/merodriguezblanco/fulcrum/subscribers","subscription_url":"https://api.github.com/repos/merodriguezblanco/fulcrum/subscription","commits_url":"https://api.github.com/repos/merodriguezblanco/fulcrum/commits{/sha}","git_commits_url":"https://api.github.com/repos/merodriguezblanco/fulcrum/git/commits{/sha}","comments_url":"https://api.github.com/repos/merodriguezblanco/fulcrum/comments{/number}","issue_comment_url":"https://api.github.com/repos/merodriguezblanco/fulcrum/issues/comments{/number}","contents_url":"https://api.github.com/repos/merodriguezblanco/fulcrum/contents/{+path}","compare_url":"https://api.github.com/repos/merodriguezblanco/fulcrum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/merodriguezblanco/fulcrum/merges","archive_url":"https://api.github.com/repos/merodriguezblanco/fulcrum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/merodriguezblanco/fulcrum/downloads","issues_url":"https://api.github.com/repos/merodriguezblanco/fulcrum/issues{/number}","pulls_url":"https://api.github.com/repos/merodriguezblanco/fulcrum/pulls{/number}","milestones_url":"https://api.github.com/repos/merodriguezblanco/fulcrum/milestones{/number}","notifications_url":"https://api.github.com/repos/merodriguezblanco/fulcrum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/merodriguezblanco/fulcrum/labels{/name}","releases_url":"https://api.github.com/repos/merodriguezblanco/fulcrum/releases{/id}","created_at":"2015-03-09T02:46:13Z","updated_at":"2015-03-09T02:46:13Z","pushed_at":"2015-03-10T02:14:46Z","git_url":"git://github.com/merodriguezblanco/fulcrum.git","ssh_url":"git@github.com:merodriguezblanco/fulcrum.git","clone_url":"https://github.com/merodriguezblanco/fulcrum.git","svn_url":"https://github.com/merodriguezblanco/fulcrum","homepage":"http://wholemeal.co.nz/projects/fulcrum.html","size":2427,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fulcrum-agile:master","ref":"master","sha":"dc71a9958ad52d82603505cd9c69defd599d7ebf","user":{"login":"fulcrum-agile","id":8453569,"avatar_url":"https://avatars.githubusercontent.com/u/8453569?v=3","gravatar_id":"","url":"https://api.github.com/users/fulcrum-agile","html_url":"https://github.com/fulcrum-agile","followers_url":"https://api.github.com/users/fulcrum-agile/followers","following_url":"https://api.github.com/users/fulcrum-agile/following{/other_user}","gists_url":"https://api.github.com/users/fulcrum-agile/gists{/gist_id}","starred_url":"https://api.github.com/users/fulcrum-agile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fulcrum-agile/subscriptions","organizations_url":"https://api.github.com/users/fulcrum-agile/orgs","repos_url":"https://api.github.com/users/fulcrum-agile/repos","events_url":"https://api.github.com/users/fulcrum-agile/events{/privacy}","received_events_url":"https://api.github.com/users/fulcrum-agile/received_events","type":"Organization","site_admin":false},"repo":{"id":1853821,"name":"fulcrum","full_name":"fulcrum-agile/fulcrum","owner":{"login":"fulcrum-agile","id":8453569,"avatar_url":"https://avatars.githubusercontent.com/u/8453569?v=3","gravatar_id":"","url":"https://api.github.com/users/fulcrum-agile","html_url":"https://github.com/fulcrum-agile","followers_url":"https://api.github.com/users/fulcrum-agile/followers","following_url":"https://api.github.com/users/fulcrum-agile/following{/other_user}","gists_url":"https://api.github.com/users/fulcrum-agile/gists{/gist_id}","starred_url":"https://api.github.com/users/fulcrum-agile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fulcrum-agile/subscriptions","organizations_url":"https://api.github.com/users/fulcrum-agile/orgs","repos_url":"https://api.github.com/users/fulcrum-agile/repos","events_url":"https://api.github.com/users/fulcrum-agile/events{/privacy}","received_events_url":"https://api.github.com/users/fulcrum-agile/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fulcrum-agile/fulcrum","description":"An agile project planning tool","fork":false,"url":"https://api.github.com/repos/fulcrum-agile/fulcrum","forks_url":"https://api.github.com/repos/fulcrum-agile/fulcrum/forks","keys_url":"https://api.github.com/repos/fulcrum-agile/fulcrum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fulcrum-agile/fulcrum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fulcrum-agile/fulcrum/teams","hooks_url":"https://api.github.com/repos/fulcrum-agile/fulcrum/hooks","issue_events_url":"https://api.github.com/repos/fulcrum-agile/fulcrum/issues/events{/number}","events_url":"https://api.github.com/repos/fulcrum-agile/fulcrum/events","assignees_url":"https://api.github.com/repos/fulcrum-agile/fulcrum/assignees{/user}","branches_url":"https://api.github.com/repos/fulcrum-agile/fulcrum/branches{/branch}","tags_url":"https://api.github.com/repos/fulcrum-agile/fulcrum/tags","blobs_url":"https://api.github.com/repos/fulcrum-agile/fulcrum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fulcrum-agile/fulcrum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fulcrum-agile/fulcrum/git/refs{/sha}","trees_url":"https://api.github.com/repos/fulcrum-agile/fulcrum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fulcrum-agile/fulcrum/statuses/{sha}","languages_url":"https://api.github.com/repos/fulcrum-agile/fulcrum/languages","stargazers_url":"https://api.github.com/repos/fulcrum-agile/fulcrum/stargazers","contributors_url":"https://api.github.com/repos/fulcrum-agile/fulcrum/contributors","subscribers_url":"https://api.github.com/repos/fulcrum-agile/fulcrum/subscribers","subscription_url":"https://api.github.com/repos/fulcrum-agile/fulcrum/subscription","commits_url":"https://api.github.com/repos/fulcrum-agile/fulcrum/commits{/sha}","git_commits_url":"https://api.github.com/repos/fulcrum-agile/fulcrum/git/commits{/sha}","comments_url":"https://api.github.com/repos/fulcrum-agile/fulcrum/comments{/number}","issue_comment_url":"https://api.github.com/repos/fulcrum-agile/fulcrum/issues/comments{/number}","contents_url":"https://api.github.com/repos/fulcrum-agile/fulcrum/contents/{+path}","compare_url":"https://api.github.com/repos/fulcrum-agile/fulcrum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fulcrum-agile/fulcrum/merges","archive_url":"https://api.github.com/repos/fulcrum-agile/fulcrum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fulcrum-agile/fulcrum/downloads","issues_url":"https://api.github.com/repos/fulcrum-agile/fulcrum/issues{/number}","pulls_url":"https://api.github.com/repos/fulcrum-agile/fulcrum/pulls{/number}","milestones_url":"https://api.github.com/repos/fulcrum-agile/fulcrum/milestones{/number}","notifications_url":"https://api.github.com/repos/fulcrum-agile/fulcrum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fulcrum-agile/fulcrum/labels{/name}","releases_url":"https://api.github.com/repos/fulcrum-agile/fulcrum/releases{/id}","created_at":"2011-06-06T09:37:07Z","updated_at":"2015-03-10T12:11:56Z","pushed_at":"2015-03-11T00:21:16Z","git_url":"git://github.com/fulcrum-agile/fulcrum.git","ssh_url":"git@github.com:fulcrum-agile/fulcrum.git","clone_url":"https://github.com/fulcrum-agile/fulcrum.git","svn_url":"https://github.com/fulcrum-agile/fulcrum","homepage":"http://wholemeal.co.nz/projects/fulcrum.html","size":4518,"stargazers_count":1372,"watchers_count":1372,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":339,"mirror_url":null,"open_issues_count":57,"forks":339,"open_issues":57,"watchers":1372,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fulcrum-agile/fulcrum/pulls/247"},"html":{"href":"https://github.com/fulcrum-agile/fulcrum/pull/247"},"issue":{"href":"https://api.github.com/repos/fulcrum-agile/fulcrum/issues/247"},"comments":{"href":"https://api.github.com/repos/fulcrum-agile/fulcrum/issues/247/comments"},"review_comments":{"href":"https://api.github.com/repos/fulcrum-agile/fulcrum/pulls/247/comments"},"review_comment":{"href":"https://api.github.com/repos/fulcrum-agile/fulcrum/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fulcrum-agile/fulcrum/pulls/247/commits"},"statuses":{"href":"https://api.github.com/repos/fulcrum-agile/fulcrum/statuses/759298f90862c898b0d185899f4faf777a75adf5"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"malclocke","id":169126,"avatar_url":"https://avatars.githubusercontent.com/u/169126?v=3","gravatar_id":"","url":"https://api.github.com/users/malclocke","html_url":"https://github.com/malclocke","followers_url":"https://api.github.com/users/malclocke/followers","following_url":"https://api.github.com/users/malclocke/following{/other_user}","gists_url":"https://api.github.com/users/malclocke/gists{/gist_id}","starred_url":"https://api.github.com/users/malclocke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/malclocke/subscriptions","organizations_url":"https://api.github.com/users/malclocke/orgs","repos_url":"https://api.github.com/users/malclocke/repos","events_url":"https://api.github.com/users/malclocke/events{/privacy}","received_events_url":"https://api.github.com/users/malclocke/received_events","type":"User","site_admin":false},"comments":1,"review_comments":2,"commits":3,"additions":13,"deletions":13,"changed_files":5}}