{"action":"created","comment":{"url":"https://api.github.com/repos/sympy/symengine/pulls/comments/34786404","id":34786404,"diff_hunk":"@@ -32,16 +32,16 @@ class Expression\n     //! Construct Expression from `int`\n     Expression(int n) : m_basic(integer(n)) {}\n     //! Construct Expression from Basic\n-    template <typename T, typename = typename std::enable_if<std::is_constructible<RCP<const Basic>, T &&>::value>::type>\n+    template <typename T>","path":"symengine/expression.h","position":5,"original_position":5,"commit_id":"ce4d748836bd3927e3d6844707fc43eddc3af9ae","original_commit_id":"ce4d748836bd3927e3d6844707fc43eddc3af9ae","user":{"login":"certik","id":20568,"avatar_url":"https://avatars.githubusercontent.com/u/20568?v=3","gravatar_id":"","url":"https://api.github.com/users/certik","html_url":"https://github.com/certik","followers_url":"https://api.github.com/users/certik/followers","following_url":"https://api.github.com/users/certik/following{/other_user}","gists_url":"https://api.github.com/users/certik/gists{/gist_id}","starred_url":"https://api.github.com/users/certik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/certik/subscriptions","organizations_url":"https://api.github.com/users/certik/orgs","repos_url":"https://api.github.com/users/certik/repos","events_url":"https://api.github.com/users/certik/events{/privacy}","received_events_url":"https://api.github.com/users/certik/received_events","type":"User","site_admin":false},"body":"The Intel compiler didn't seem to understand `std::is_constructible`. So again, probably have to use some ifdefs.","created_at":"2015-07-16T13:30:47Z","updated_at":"2015-07-16T13:30:47Z","html_url":"https://github.com/sympy/symengine/pull/536#discussion_r34786404","pull_request_url":"https://api.github.com/repos/sympy/symengine/pulls/536","_links":{"self":{"href":"https://api.github.com/repos/sympy/symengine/pulls/comments/34786404"},"html":{"href":"https://github.com/sympy/symengine/pull/536#discussion_r34786404"},"pull_request":{"href":"https://api.github.com/repos/sympy/symengine/pulls/536"}}},"pull_request":{"url":"https://api.github.com/repos/sympy/symengine/pulls/536","id":40092229,"html_url":"https://github.com/sympy/symengine/pull/536","diff_url":"https://github.com/sympy/symengine/pull/536.diff","patch_url":"https://github.com/sympy/symengine/pull/536.patch","issue_url":"https://api.github.com/repos/sympy/symengine/issues/536","number":536,"state":"open","locked":false,"title":"Port SymEngine to Intel compiler","user":{"login":"certik","id":20568,"avatar_url":"https://avatars.githubusercontent.com/u/20568?v=3","gravatar_id":"","url":"https://api.github.com/users/certik","html_url":"https://github.com/certik","followers_url":"https://api.github.com/users/certik/followers","following_url":"https://api.github.com/users/certik/following{/other_user}","gists_url":"https://api.github.com/users/certik/gists{/gist_id}","starred_url":"https://api.github.com/users/certik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/certik/subscriptions","organizations_url":"https://api.github.com/users/certik/orgs","repos_url":"https://api.github.com/users/certik/repos","events_url":"https://api.github.com/users/certik/events{/privacy}","received_events_url":"https://api.github.com/users/certik/received_events","type":"User","site_admin":false},"body":"This makes the whole SymEngine build and pass all tests in both Debug and Release modes with Intel 15.0.3 C++ compiler (`icpc`).\r\n\r\nMost of these changes can be merged, but some of them require a workaround using ifdefs.\r\n\r\nThere might be similar changes needed for MSVC.","created_at":"2015-07-16T03:44:02Z","updated_at":"2015-07-16T13:30:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e34621ce18adc252f2f6130f757652f18e81db45","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sympy/symengine/pulls/536/commits","review_comments_url":"https://api.github.com/repos/sympy/symengine/pulls/536/comments","review_comment_url":"https://api.github.com/repos/sympy/symengine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sympy/symengine/issues/536/comments","statuses_url":"https://api.github.com/repos/sympy/symengine/statuses/ce4d748836bd3927e3d6844707fc43eddc3af9ae","head":{"label":"certik:icpc","ref":"icpc","sha":"ce4d748836bd3927e3d6844707fc43eddc3af9ae","user":{"login":"certik","id":20568,"avatar_url":"https://avatars.githubusercontent.com/u/20568?v=3","gravatar_id":"","url":"https://api.github.com/users/certik","html_url":"https://github.com/certik","followers_url":"https://api.github.com/users/certik/followers","following_url":"https://api.github.com/users/certik/following{/other_user}","gists_url":"https://api.github.com/users/certik/gists{/gist_id}","starred_url":"https://api.github.com/users/certik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/certik/subscriptions","organizations_url":"https://api.github.com/users/certik/orgs","repos_url":"https://api.github.com/users/certik/repos","events_url":"https://api.github.com/users/certik/events{/privacy}","received_events_url":"https://api.github.com/users/certik/received_events","type":"User","site_admin":false},"repo":{"id":18584165,"name":"symengine","full_name":"certik/symengine","owner":{"login":"certik","id":20568,"avatar_url":"https://avatars.githubusercontent.com/u/20568?v=3","gravatar_id":"","url":"https://api.github.com/users/certik","html_url":"https://github.com/certik","followers_url":"https://api.github.com/users/certik/followers","following_url":"https://api.github.com/users/certik/following{/other_user}","gists_url":"https://api.github.com/users/certik/gists{/gist_id}","starred_url":"https://api.github.com/users/certik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/certik/subscriptions","organizations_url":"https://api.github.com/users/certik/orgs","repos_url":"https://api.github.com/users/certik/repos","events_url":"https://api.github.com/users/certik/events{/privacy}","received_events_url":"https://api.github.com/users/certik/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/certik/symengine","description":"Fast symbolic manipulation library, written in C++","fork":true,"url":"https://api.github.com/repos/certik/symengine","forks_url":"https://api.github.com/repos/certik/symengine/forks","keys_url":"https://api.github.com/repos/certik/symengine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/certik/symengine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/certik/symengine/teams","hooks_url":"https://api.github.com/repos/certik/symengine/hooks","issue_events_url":"https://api.github.com/repos/certik/symengine/issues/events{/number}","events_url":"https://api.github.com/repos/certik/symengine/events","assignees_url":"https://api.github.com/repos/certik/symengine/assignees{/user}","branches_url":"https://api.github.com/repos/certik/symengine/branches{/branch}","tags_url":"https://api.github.com/repos/certik/symengine/tags","blobs_url":"https://api.github.com/repos/certik/symengine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/certik/symengine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/certik/symengine/git/refs{/sha}","trees_url":"https://api.github.com/repos/certik/symengine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/certik/symengine/statuses/{sha}","languages_url":"https://api.github.com/repos/certik/symengine/languages","stargazers_url":"https://api.github.com/repos/certik/symengine/stargazers","contributors_url":"https://api.github.com/repos/certik/symengine/contributors","subscribers_url":"https://api.github.com/repos/certik/symengine/subscribers","subscription_url":"https://api.github.com/repos/certik/symengine/subscription","commits_url":"https://api.github.com/repos/certik/symengine/commits{/sha}","git_commits_url":"https://api.github.com/repos/certik/symengine/git/commits{/sha}","comments_url":"https://api.github.com/repos/certik/symengine/comments{/number}","issue_comment_url":"https://api.github.com/repos/certik/symengine/issues/comments{/number}","contents_url":"https://api.github.com/repos/certik/symengine/contents/{+path}","compare_url":"https://api.github.com/repos/certik/symengine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/certik/symengine/merges","archive_url":"https://api.github.com/repos/certik/symengine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/certik/symengine/downloads","issues_url":"https://api.github.com/repos/certik/symengine/issues{/number}","pulls_url":"https://api.github.com/repos/certik/symengine/pulls{/number}","milestones_url":"https://api.github.com/repos/certik/symengine/milestones{/number}","notifications_url":"https://api.github.com/repos/certik/symengine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/certik/symengine/labels{/name}","releases_url":"https://api.github.com/repos/certik/symengine/releases{/id}","created_at":"2014-04-09T03:40:03Z","updated_at":"2015-06-10T11:28:21Z","pushed_at":"2015-07-16T13:10:44Z","git_url":"git://github.com/certik/symengine.git","ssh_url":"git@github.com:certik/symengine.git","clone_url":"https://github.com/certik/symengine.git","svn_url":"https://github.com/certik/symengine","homepage":"http://sympy.org","size":3870,"stargazers_count":3,"watchers_count":3,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":3,"default_branch":"master"}},"base":{"label":"sympy:master","ref":"master","sha":"31f59f2e9851fceb416e5e5027367fe599cae51b","user":{"login":"sympy","id":260832,"avatar_url":"https://avatars.githubusercontent.com/u/260832?v=3","gravatar_id":"","url":"https://api.github.com/users/sympy","html_url":"https://github.com/sympy","followers_url":"https://api.github.com/users/sympy/followers","following_url":"https://api.github.com/users/sympy/following{/other_user}","gists_url":"https://api.github.com/users/sympy/gists{/gist_id}","starred_url":"https://api.github.com/users/sympy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sympy/subscriptions","organizations_url":"https://api.github.com/users/sympy/orgs","repos_url":"https://api.github.com/users/sympy/repos","events_url":"https://api.github.com/users/sympy/events{/privacy}","received_events_url":"https://api.github.com/users/sympy/received_events","type":"Organization","site_admin":false},"repo":{"id":42376,"name":"symengine","full_name":"sympy/symengine","owner":{"login":"sympy","id":260832,"avatar_url":"https://avatars.githubusercontent.com/u/260832?v=3","gravatar_id":"","url":"https://api.github.com/users/sympy","html_url":"https://github.com/sympy","followers_url":"https://api.github.com/users/sympy/followers","following_url":"https://api.github.com/users/sympy/following{/other_user}","gists_url":"https://api.github.com/users/sympy/gists{/gist_id}","starred_url":"https://api.github.com/users/sympy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sympy/subscriptions","organizations_url":"https://api.github.com/users/sympy/orgs","repos_url":"https://api.github.com/users/sympy/repos","events_url":"https://api.github.com/users/sympy/events{/privacy}","received_events_url":"https://api.github.com/users/sympy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sympy/symengine","description":"SymEngine is a fast symbolic manipulation library, written in C++ (SymEngine was previously called CSymPy)","fork":false,"url":"https://api.github.com/repos/sympy/symengine","forks_url":"https://api.github.com/repos/sympy/symengine/forks","keys_url":"https://api.github.com/repos/sympy/symengine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sympy/symengine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sympy/symengine/teams","hooks_url":"https://api.github.com/repos/sympy/symengine/hooks","issue_events_url":"https://api.github.com/repos/sympy/symengine/issues/events{/number}","events_url":"https://api.github.com/repos/sympy/symengine/events","assignees_url":"https://api.github.com/repos/sympy/symengine/assignees{/user}","branches_url":"https://api.github.com/repos/sympy/symengine/branches{/branch}","tags_url":"https://api.github.com/repos/sympy/symengine/tags","blobs_url":"https://api.github.com/repos/sympy/symengine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sympy/symengine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sympy/symengine/git/refs{/sha}","trees_url":"https://api.github.com/repos/sympy/symengine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sympy/symengine/statuses/{sha}","languages_url":"https://api.github.com/repos/sympy/symengine/languages","stargazers_url":"https://api.github.com/repos/sympy/symengine/stargazers","contributors_url":"https://api.github.com/repos/sympy/symengine/contributors","subscribers_url":"https://api.github.com/repos/sympy/symengine/subscribers","subscription_url":"https://api.github.com/repos/sympy/symengine/subscription","commits_url":"https://api.github.com/repos/sympy/symengine/commits{/sha}","git_commits_url":"https://api.github.com/repos/sympy/symengine/git/commits{/sha}","comments_url":"https://api.github.com/repos/sympy/symengine/comments{/number}","issue_comment_url":"https://api.github.com/repos/sympy/symengine/issues/comments{/number}","contents_url":"https://api.github.com/repos/sympy/symengine/contents/{+path}","compare_url":"https://api.github.com/repos/sympy/symengine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sympy/symengine/merges","archive_url":"https://api.github.com/repos/sympy/symengine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sympy/symengine/downloads","issues_url":"https://api.github.com/repos/sympy/symengine/issues{/number}","pulls_url":"https://api.github.com/repos/sympy/symengine/pulls{/number}","milestones_url":"https://api.github.com/repos/sympy/symengine/milestones{/number}","notifications_url":"https://api.github.com/repos/sympy/symengine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sympy/symengine/labels{/name}","releases_url":"https://api.github.com/repos/sympy/symengine/releases{/id}","created_at":"2008-08-13T18:40:14Z","updated_at":"2015-07-15T23:45:05Z","pushed_at":"2015-07-16T13:10:45Z","git_url":"git://github.com/sympy/symengine.git","ssh_url":"git@github.com:sympy/symengine.git","clone_url":"https://github.com/sympy/symengine.git","svn_url":"https://github.com/sympy/symengine","homepage":"http://sympy.org","size":22836,"stargazers_count":69,"watchers_count":69,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":60,"mirror_url":null,"open_issues_count":87,"forks":60,"open_issues":87,"watchers":69,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sympy/symengine/pulls/536"},"html":{"href":"https://github.com/sympy/symengine/pull/536"},"issue":{"href":"https://api.github.com/repos/sympy/symengine/issues/536"},"comments":{"href":"https://api.github.com/repos/sympy/symengine/issues/536/comments"},"review_comments":{"href":"https://api.github.com/repos/sympy/symengine/pulls/536/comments"},"review_comment":{"href":"https://api.github.com/repos/sympy/symengine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sympy/symengine/pulls/536/commits"},"statuses":{"href":"https://api.github.com/repos/sympy/symengine/statuses/ce4d748836bd3927e3d6844707fc43eddc3af9ae"}}}}