{"action":"created","comment":{"url":"https://api.github.com/repos/linkedin/gobblin/pulls/comments/48206579","id":48206579,"diff_hunk":"@@ -0,0 +1,47 @@\n+/*\n+ * Copyright (C) 2015 LinkedIn Corp. All rights reserved.\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\"); you may not use\n+ * this file except in compliance with the License. You may obtain a copy of the\n+ * License at  http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software distributed\n+ * under the License is distributed on an \"AS IS\" BASIS, WITHOUT WARRANTIES OR\n+ * CONDITIONS OF ANY KIND, either express or implied.\n+ */\n+\n+package gobblin.config.store.api;\n+\n+import java.lang.annotation.Documented;\n+import java.lang.annotation.ElementType;\n+import java.lang.annotation.Retention;\n+import java.lang.annotation.RetentionPolicy;\n+import java.lang.annotation.Target;\n+\n+import gobblin.annotation.Alpha;\n+import gobblin.config.client.api.VersionStabilityPolicy;\n+\n+/**\n+ * The ConfigStoreWithStableVersion annotation is used to indicate that the configuration store\n+ * supports stable versioning. This means that:\n+ *\n+ * <ul>\n+ *   <li>Once published the version will remain available for at least a day even if it gets rolled","path":"gobblin-config-management/gobblin-config-core/src/main/java/gobblin/config/store/api/ConfigStoreWithStableVersioning.java","position":29,"original_position":29,"commit_id":"84ca15d0eea72200c31780baadc1a6f41e6a7e30","original_commit_id":"84ca15d0eea72200c31780baadc1a6f41e6a7e30","user":{"login":"zliu41","id":6342538,"avatar_url":"https://avatars.githubusercontent.com/u/6342538?v=3","gravatar_id":"","url":"https://api.github.com/users/zliu41","html_url":"https://github.com/zliu41","followers_url":"https://api.github.com/users/zliu41/followers","following_url":"https://api.github.com/users/zliu41/following{/other_user}","gists_url":"https://api.github.com/users/zliu41/gists{/gist_id}","starred_url":"https://api.github.com/users/zliu41/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zliu41/subscriptions","organizations_url":"https://api.github.com/users/zliu41/orgs","repos_url":"https://api.github.com/users/zliu41/repos","events_url":"https://api.github.com/users/zliu41/events{/privacy}","received_events_url":"https://api.github.com/users/zliu41/received_events","type":"User","site_admin":false},"body":"Why should it be a day, not 3 days or a week?","created_at":"2015-12-21T23:48:56Z","updated_at":"2015-12-21T23:48:56Z","html_url":"https://github.com/linkedin/gobblin/pull/553#discussion_r48206579","pull_request_url":"https://api.github.com/repos/linkedin/gobblin/pulls/553","_links":{"self":{"href":"https://api.github.com/repos/linkedin/gobblin/pulls/comments/48206579"},"html":{"href":"https://github.com/linkedin/gobblin/pull/553#discussion_r48206579"},"pull_request":{"href":"https://api.github.com/repos/linkedin/gobblin/pulls/553"}}},"pull_request":{"url":"https://api.github.com/repos/linkedin/gobblin/pulls/553","id":54307542,"html_url":"https://github.com/linkedin/gobblin/pull/553","diff_url":"https://github.com/linkedin/gobblin/pull/553.diff","patch_url":"https://github.com/linkedin/gobblin/pull/553.patch","issue_url":"https://api.github.com/repos/linkedin/gobblin/issues/553","number":553,"state":"open","locked":false,"title":"Config api changes","user":{"login":"chavdar","id":928795,"avatar_url":"https://avatars.githubusercontent.com/u/928795?v=3","gravatar_id":"","url":"https://api.github.com/users/chavdar","html_url":"https://github.com/chavdar","followers_url":"https://api.github.com/users/chavdar/followers","following_url":"https://api.github.com/users/chavdar/following{/other_user}","gists_url":"https://api.github.com/users/chavdar/gists{/gist_id}","starred_url":"https://api.github.com/users/chavdar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chavdar/subscriptions","organizations_url":"https://api.github.com/users/chavdar/orgs","repos_url":"https://api.github.com/users/chavdar/repos","events_url":"https://api.github.com/users/chavdar/events{/privacy}","received_events_url":"https://api.github.com/users/chavdar/received_events","type":"User","site_admin":false},"body":"Changes to the ConfigStore API\r\n* Cleanup javadocs\r\n* Replace references to config key URIs with ConfigKeyPaths\r\n* Add  VersionStabilityPolicy\r\n* Add Alpha annotations\r\n\r\n@ibuenros @zliu41 @ydai1124 can you review?","created_at":"2015-12-21T21:53:44Z","updated_at":"2015-12-21T23:48:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"396f63f8adeca3ca21c2e90c9cb93c16ec3885a2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/linkedin/gobblin/pulls/553/commits","review_comments_url":"https://api.github.com/repos/linkedin/gobblin/pulls/553/comments","review_comment_url":"https://api.github.com/repos/linkedin/gobblin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/linkedin/gobblin/issues/553/comments","statuses_url":"https://api.github.com/repos/linkedin/gobblin/statuses/84ca15d0eea72200c31780baadc1a6f41e6a7e30","head":{"label":"chavdar:config_api_changes","ref":"config_api_changes","sha":"84ca15d0eea72200c31780baadc1a6f41e6a7e30","user":{"login":"chavdar","id":928795,"avatar_url":"https://avatars.githubusercontent.com/u/928795?v=3","gravatar_id":"","url":"https://api.github.com/users/chavdar","html_url":"https://github.com/chavdar","followers_url":"https://api.github.com/users/chavdar/followers","following_url":"https://api.github.com/users/chavdar/following{/other_user}","gists_url":"https://api.github.com/users/chavdar/gists{/gist_id}","starred_url":"https://api.github.com/users/chavdar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chavdar/subscriptions","organizations_url":"https://api.github.com/users/chavdar/orgs","repos_url":"https://api.github.com/users/chavdar/repos","events_url":"https://api.github.com/users/chavdar/events{/privacy}","received_events_url":"https://api.github.com/users/chavdar/received_events","type":"User","site_admin":false},"repo":{"id":31112986,"name":"gobblin-1","full_name":"chavdar/gobblin-1","owner":{"login":"chavdar","id":928795,"avatar_url":"https://avatars.githubusercontent.com/u/928795?v=3","gravatar_id":"","url":"https://api.github.com/users/chavdar","html_url":"https://github.com/chavdar","followers_url":"https://api.github.com/users/chavdar/followers","following_url":"https://api.github.com/users/chavdar/following{/other_user}","gists_url":"https://api.github.com/users/chavdar/gists{/gist_id}","starred_url":"https://api.github.com/users/chavdar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chavdar/subscriptions","organizations_url":"https://api.github.com/users/chavdar/orgs","repos_url":"https://api.github.com/users/chavdar/repos","events_url":"https://api.github.com/users/chavdar/events{/privacy}","received_events_url":"https://api.github.com/users/chavdar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chavdar/gobblin-1","description":"","fork":true,"url":"https://api.github.com/repos/chavdar/gobblin-1","forks_url":"https://api.github.com/repos/chavdar/gobblin-1/forks","keys_url":"https://api.github.com/repos/chavdar/gobblin-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chavdar/gobblin-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chavdar/gobblin-1/teams","hooks_url":"https://api.github.com/repos/chavdar/gobblin-1/hooks","issue_events_url":"https://api.github.com/repos/chavdar/gobblin-1/issues/events{/number}","events_url":"https://api.github.com/repos/chavdar/gobblin-1/events","assignees_url":"https://api.github.com/repos/chavdar/gobblin-1/assignees{/user}","branches_url":"https://api.github.com/repos/chavdar/gobblin-1/branches{/branch}","tags_url":"https://api.github.com/repos/chavdar/gobblin-1/tags","blobs_url":"https://api.github.com/repos/chavdar/gobblin-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chavdar/gobblin-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chavdar/gobblin-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/chavdar/gobblin-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chavdar/gobblin-1/statuses/{sha}","languages_url":"https://api.github.com/repos/chavdar/gobblin-1/languages","stargazers_url":"https://api.github.com/repos/chavdar/gobblin-1/stargazers","contributors_url":"https://api.github.com/repos/chavdar/gobblin-1/contributors","subscribers_url":"https://api.github.com/repos/chavdar/gobblin-1/subscribers","subscription_url":"https://api.github.com/repos/chavdar/gobblin-1/subscription","commits_url":"https://api.github.com/repos/chavdar/gobblin-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/chavdar/gobblin-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/chavdar/gobblin-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/chavdar/gobblin-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/chavdar/gobblin-1/contents/{+path}","compare_url":"https://api.github.com/repos/chavdar/gobblin-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chavdar/gobblin-1/merges","archive_url":"https://api.github.com/repos/chavdar/gobblin-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chavdar/gobblin-1/downloads","issues_url":"https://api.github.com/repos/chavdar/gobblin-1/issues{/number}","pulls_url":"https://api.github.com/repos/chavdar/gobblin-1/pulls{/number}","milestones_url":"https://api.github.com/repos/chavdar/gobblin-1/milestones{/number}","notifications_url":"https://api.github.com/repos/chavdar/gobblin-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chavdar/gobblin-1/labels{/name}","releases_url":"https://api.github.com/repos/chavdar/gobblin-1/releases{/id}","created_at":"2015-02-21T02:34:18Z","updated_at":"2015-03-24T04:36:09Z","pushed_at":"2015-12-21T23:48:05Z","git_url":"git://github.com/chavdar/gobblin-1.git","ssh_url":"git@github.com:chavdar/gobblin-1.git","clone_url":"https://github.com/chavdar/gobblin-1.git","svn_url":"https://github.com/chavdar/gobblin-1","homepage":null,"size":81643,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"linkedin:master","ref":"master","sha":"41f37507048cf8ab793fb946d6c5cd0a3bb6484c","user":{"login":"linkedin","id":357098,"avatar_url":"https://avatars.githubusercontent.com/u/357098?v=3","gravatar_id":"","url":"https://api.github.com/users/linkedin","html_url":"https://github.com/linkedin","followers_url":"https://api.github.com/users/linkedin/followers","following_url":"https://api.github.com/users/linkedin/following{/other_user}","gists_url":"https://api.github.com/users/linkedin/gists{/gist_id}","starred_url":"https://api.github.com/users/linkedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkedin/subscriptions","organizations_url":"https://api.github.com/users/linkedin/orgs","repos_url":"https://api.github.com/users/linkedin/repos","events_url":"https://api.github.com/users/linkedin/events{/privacy}","received_events_url":"https://api.github.com/users/linkedin/received_events","type":"Organization","site_admin":false},"repo":{"id":27392543,"name":"gobblin","full_name":"linkedin/gobblin","owner":{"login":"linkedin","id":357098,"avatar_url":"https://avatars.githubusercontent.com/u/357098?v=3","gravatar_id":"","url":"https://api.github.com/users/linkedin","html_url":"https://github.com/linkedin","followers_url":"https://api.github.com/users/linkedin/followers","following_url":"https://api.github.com/users/linkedin/following{/other_user}","gists_url":"https://api.github.com/users/linkedin/gists{/gist_id}","starred_url":"https://api.github.com/users/linkedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkedin/subscriptions","organizations_url":"https://api.github.com/users/linkedin/orgs","repos_url":"https://api.github.com/users/linkedin/repos","events_url":"https://api.github.com/users/linkedin/events{/privacy}","received_events_url":"https://api.github.com/users/linkedin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/linkedin/gobblin","description":"Universal data ingestion framework for Hadoop.","fork":false,"url":"https://api.github.com/repos/linkedin/gobblin","forks_url":"https://api.github.com/repos/linkedin/gobblin/forks","keys_url":"https://api.github.com/repos/linkedin/gobblin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linkedin/gobblin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linkedin/gobblin/teams","hooks_url":"https://api.github.com/repos/linkedin/gobblin/hooks","issue_events_url":"https://api.github.com/repos/linkedin/gobblin/issues/events{/number}","events_url":"https://api.github.com/repos/linkedin/gobblin/events","assignees_url":"https://api.github.com/repos/linkedin/gobblin/assignees{/user}","branches_url":"https://api.github.com/repos/linkedin/gobblin/branches{/branch}","tags_url":"https://api.github.com/repos/linkedin/gobblin/tags","blobs_url":"https://api.github.com/repos/linkedin/gobblin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linkedin/gobblin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linkedin/gobblin/git/refs{/sha}","trees_url":"https://api.github.com/repos/linkedin/gobblin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linkedin/gobblin/statuses/{sha}","languages_url":"https://api.github.com/repos/linkedin/gobblin/languages","stargazers_url":"https://api.github.com/repos/linkedin/gobblin/stargazers","contributors_url":"https://api.github.com/repos/linkedin/gobblin/contributors","subscribers_url":"https://api.github.com/repos/linkedin/gobblin/subscribers","subscription_url":"https://api.github.com/repos/linkedin/gobblin/subscription","commits_url":"https://api.github.com/repos/linkedin/gobblin/commits{/sha}","git_commits_url":"https://api.github.com/repos/linkedin/gobblin/git/commits{/sha}","comments_url":"https://api.github.com/repos/linkedin/gobblin/comments{/number}","issue_comment_url":"https://api.github.com/repos/linkedin/gobblin/issues/comments{/number}","contents_url":"https://api.github.com/repos/linkedin/gobblin/contents/{+path}","compare_url":"https://api.github.com/repos/linkedin/gobblin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linkedin/gobblin/merges","archive_url":"https://api.github.com/repos/linkedin/gobblin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linkedin/gobblin/downloads","issues_url":"https://api.github.com/repos/linkedin/gobblin/issues{/number}","pulls_url":"https://api.github.com/repos/linkedin/gobblin/pulls{/number}","milestones_url":"https://api.github.com/repos/linkedin/gobblin/milestones{/number}","notifications_url":"https://api.github.com/repos/linkedin/gobblin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linkedin/gobblin/labels{/name}","releases_url":"https://api.github.com/repos/linkedin/gobblin/releases{/id}","created_at":"2014-12-01T18:10:50Z","updated_at":"2015-12-21T06:20:37Z","pushed_at":"2015-12-21T23:48:41Z","git_url":"git://github.com/linkedin/gobblin.git","ssh_url":"git@github.com:linkedin/gobblin.git","clone_url":"https://github.com/linkedin/gobblin.git","svn_url":"https://github.com/linkedin/gobblin","homepage":"https://github.com/linkedin/gobblin/wiki","size":159209,"stargazers_count":334,"watchers_count":334,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":132,"mirror_url":null,"open_issues_count":29,"forks":132,"open_issues":29,"watchers":334,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/linkedin/gobblin/pulls/553"},"html":{"href":"https://github.com/linkedin/gobblin/pull/553"},"issue":{"href":"https://api.github.com/repos/linkedin/gobblin/issues/553"},"comments":{"href":"https://api.github.com/repos/linkedin/gobblin/issues/553/comments"},"review_comments":{"href":"https://api.github.com/repos/linkedin/gobblin/pulls/553/comments"},"review_comment":{"href":"https://api.github.com/repos/linkedin/gobblin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/linkedin/gobblin/pulls/553/commits"},"statuses":{"href":"https://api.github.com/repos/linkedin/gobblin/statuses/84ca15d0eea72200c31780baadc1a6f41e6a7e30"}}}}