{"action":"created","issue":{"url":"https://api.github.com/repos/scipy/scipy/issues/4021","labels_url":"https://api.github.com/repos/scipy/scipy/issues/4021/labels{/name}","comments_url":"https://api.github.com/repos/scipy/scipy/issues/4021/comments","events_url":"https://api.github.com/repos/scipy/scipy/issues/4021/events","html_url":"https://github.com/scipy/scipy/pull/4021","id":43702292,"number":4021,"title":"ENH: Cython api for lapack and blas","user":{"login":"insertinterestingnamehere","id":1847484,"avatar_url":"https://avatars.githubusercontent.com/u/1847484?v=3","gravatar_id":"","url":"https://api.github.com/users/insertinterestingnamehere","html_url":"https://github.com/insertinterestingnamehere","followers_url":"https://api.github.com/users/insertinterestingnamehere/followers","following_url":"https://api.github.com/users/insertinterestingnamehere/following{/other_user}","gists_url":"https://api.github.com/users/insertinterestingnamehere/gists{/gist_id}","starred_url":"https://api.github.com/users/insertinterestingnamehere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/insertinterestingnamehere/subscriptions","organizations_url":"https://api.github.com/users/insertinterestingnamehere/orgs","repos_url":"https://api.github.com/users/insertinterestingnamehere/repos","events_url":"https://api.github.com/users/insertinterestingnamehere/events{/privacy}","received_events_url":"https://api.github.com/users/insertinterestingnamehere/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/scipy/scipy/labels/enhancement","name":"enhancement","color":"bfe5bf"},{"url":"https://api.github.com/repos/scipy/scipy/labels/scipy.linalg","name":"scipy.linalg","color":"207de5"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":87,"created_at":"2014-09-24T00:45:41Z","updated_at":"2015-01-21T20:50:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/scipy/scipy/pulls/4021","html_url":"https://github.com/scipy/scipy/pull/4021","diff_url":"https://github.com/scipy/scipy/pull/4021.diff","patch_url":"https://github.com/scipy/scipy/pull/4021.patch"},"body":"- [x] Add interface for lapack and blas routines.\r\n- [x] Add working example in tests\r\n- [x] Review signatures for correctness\r\n- [x] Add function to get directory of `scipy.linalg` (similar to `numpy.get_include`)\r\n- [x] Finish wrappers for 'gees' and 'gges' functions.\r\n- [x] Add interfaces to the functions added in https://github.com/scipy/scipy/pull/3984\r\n- [x] Add this api to the documentation"},"comment":{"url":"https://api.github.com/repos/scipy/scipy/issues/comments/70918869","html_url":"https://github.com/scipy/scipy/pull/4021#issuecomment-70918869","issue_url":"https://api.github.com/repos/scipy/scipy/issues/4021","id":70918869,"user":{"login":"insertinterestingnamehere","id":1847484,"avatar_url":"https://avatars.githubusercontent.com/u/1847484?v=3","gravatar_id":"","url":"https://api.github.com/users/insertinterestingnamehere","html_url":"https://github.com/insertinterestingnamehere","followers_url":"https://api.github.com/users/insertinterestingnamehere/followers","following_url":"https://api.github.com/users/insertinterestingnamehere/following{/other_user}","gists_url":"https://api.github.com/users/insertinterestingnamehere/gists{/gist_id}","starred_url":"https://api.github.com/users/insertinterestingnamehere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/insertinterestingnamehere/subscriptions","organizations_url":"https://api.github.com/users/insertinterestingnamehere/orgs","repos_url":"https://api.github.com/users/insertinterestingnamehere/repos","events_url":"https://api.github.com/users/insertinterestingnamehere/events{/privacy}","received_events_url":"https://api.github.com/users/insertinterestingnamehere/received_events","type":"User","site_admin":false},"created_at":"2015-01-21T20:50:49Z","updated_at":"2015-01-21T20:50:49Z","body":"@pv That looks great. The version without f2py is much more direct. I hadn't figured out how to use macros like that in Cython. FWIW, I prefer having the two as seperate modules `cython_blas` and `cython_lapack`. These changes look great to me. I do have a few questions though.\r\n\r\nI'm not finding the header \"fortran_defs.h\". Did you mean to add it in git somewhere? I haven't been able to use these wrappers without including the `scipy.linalg` source directory, if I can figure out what is going on with the header though, I'd be happy to test it.\r\n\r\nIf we're going to use a macro to make external declarations at the C level that properly handle the Fortran name mangling, why not avoid using function pointers entirely? If I understand correctly, that should make it easier for the C compiler to inline them.\r\n\r\nAlso, how would you like me to work with the git history in including these changes?"}}