{"action":"created","comment":{"url":"https://api.github.com/repos/coreos/rkt/pulls/comments/41374127","id":41374127,"diff_hunk":"@@ -86,13 +84,7 @@ func TestShortHash(t *testing.T) {\n \tfor _, imageId := range imageIds {\n \t\tcmd := fmt.Sprintf(\"%s --insecure-skip-verify fetch %s\", ctx.cmd(), imageId.path)\n \t\tt.Logf(\"Fetching %s: %v\", imageId.path, cmd)\n-\t\tchild, err := gexpect.Spawn(cmd)\n-\t\tif err != nil {\n-\t\t\tt.Fatalf(\"Cannot exec: %v\", err)\n-\t\t}\n-\t\tif err := child.Wait(); err != nil {\n-\t\t\tt.Fatalf(\"rkt didn't terminate correctly: %v\", err)\n-\t\t}\n+\t\tspawnAndWaitOrFail(t, cmd, true)","path":"tests/rkt_image_list_test.go","position":20,"original_position":20,"commit_id":"cdd54df3490cace1dda1e41de993cdc4933c4649","original_commit_id":"cdd54df3490cace1dda1e41de993cdc4933c4649","user":{"login":"krnowak","id":96081,"avatar_url":"https://avatars.githubusercontent.com/u/96081?v=3","gravatar_id":"","url":"https://api.github.com/users/krnowak","html_url":"https://github.com/krnowak","followers_url":"https://api.github.com/users/krnowak/followers","following_url":"https://api.github.com/users/krnowak/following{/other_user}","gists_url":"https://api.github.com/users/krnowak/gists{/gist_id}","starred_url":"https://api.github.com/users/krnowak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krnowak/subscriptions","organizations_url":"https://api.github.com/users/krnowak/orgs","repos_url":"https://api.github.com/users/krnowak/repos","events_url":"https://api.github.com/users/krnowak/events{/privacy}","received_events_url":"https://api.github.com/users/krnowak/received_events","type":"User","site_admin":false},"body":"This will print the command twice.","created_at":"2015-10-07T10:28:15Z","updated_at":"2015-10-07T10:28:15Z","html_url":"https://github.com/coreos/rkt/pull/1546#discussion_r41374127","pull_request_url":"https://api.github.com/repos/coreos/rkt/pulls/1546","_links":{"self":{"href":"https://api.github.com/repos/coreos/rkt/pulls/comments/41374127"},"html":{"href":"https://github.com/coreos/rkt/pull/1546#discussion_r41374127"},"pull_request":{"href":"https://api.github.com/repos/coreos/rkt/pulls/1546"}}},"pull_request":{"url":"https://api.github.com/repos/coreos/rkt/pulls/1546","id":46884573,"html_url":"https://github.com/coreos/rkt/pull/1546","diff_url":"https://github.com/coreos/rkt/pull/1546.diff","patch_url":"https://github.com/coreos/rkt/pull/1546.patch","issue_url":"https://api.github.com/repos/coreos/rkt/issues/1546","number":1546,"state":"open","locked":false,"title":"tests: functional test refactoring","user":{"login":"blixtra","id":115075,"avatar_url":"https://avatars.githubusercontent.com/u/115075?v=3","gravatar_id":"","url":"https://api.github.com/users/blixtra","html_url":"https://github.com/blixtra","followers_url":"https://api.github.com/users/blixtra/followers","following_url":"https://api.github.com/users/blixtra/following{/other_user}","gists_url":"https://api.github.com/users/blixtra/gists{/gist_id}","starred_url":"https://api.github.com/users/blixtra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blixtra/subscriptions","organizations_url":"https://api.github.com/users/blixtra/orgs","repos_url":"https://api.github.com/users/blixtra/repos","events_url":"https://api.github.com/users/blixtra/events{/privacy}","received_events_url":"https://api.github.com/users/blixtra/received_events","type":"User","site_admin":false},"body":"Much of the code in the functional tests was copy and pasted around. This commit tries to reduce that a bit by providing functions for the common tasks of spawning, waiting, checking expected values, etc.\r\n\r\nThere is much more room for improvement, but this is a start.","created_at":"2015-10-06T10:16:23Z","updated_at":"2015-10-07T10:28:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d819f045abb5d5a6adbd02c4ec64c202578b290e","assignee":null,"milestone":{"url":"https://api.github.com/repos/coreos/rkt/milestones/21","html_url":"https://github.com/coreos/rkt/milestones/v0.10.0","labels_url":"https://api.github.com/repos/coreos/rkt/milestones/21/labels","id":1335294,"number":21,"title":"v0.10.0","description":"","creator":{"login":"jonboulle","id":2601015,"avatar_url":"https://avatars.githubusercontent.com/u/2601015?v=3","gravatar_id":"","url":"https://api.github.com/users/jonboulle","html_url":"https://github.com/jonboulle","followers_url":"https://api.github.com/users/jonboulle/followers","following_url":"https://api.github.com/users/jonboulle/following{/other_user}","gists_url":"https://api.github.com/users/jonboulle/gists{/gist_id}","starred_url":"https://api.github.com/users/jonboulle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonboulle/subscriptions","organizations_url":"https://api.github.com/users/jonboulle/orgs","repos_url":"https://api.github.com/users/jonboulle/repos","events_url":"https://api.github.com/users/jonboulle/events{/privacy}","received_events_url":"https://api.github.com/users/jonboulle/received_events","type":"User","site_admin":false},"open_issues":35,"closed_issues":2,"state":"open","created_at":"2015-10-02T17:41:16Z","updated_at":"2015-10-07T01:25:00Z","due_on":"2015-10-14T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/coreos/rkt/pulls/1546/commits","review_comments_url":"https://api.github.com/repos/coreos/rkt/pulls/1546/comments","review_comment_url":"https://api.github.com/repos/coreos/rkt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coreos/rkt/issues/1546/comments","statuses_url":"https://api.github.com/repos/coreos/rkt/statuses/cdd54df3490cace1dda1e41de993cdc4933c4649","head":{"label":"blixtra:blixtra/tests-refactoring","ref":"blixtra/tests-refactoring","sha":"cdd54df3490cace1dda1e41de993cdc4933c4649","user":{"login":"blixtra","id":115075,"avatar_url":"https://avatars.githubusercontent.com/u/115075?v=3","gravatar_id":"","url":"https://api.github.com/users/blixtra","html_url":"https://github.com/blixtra","followers_url":"https://api.github.com/users/blixtra/followers","following_url":"https://api.github.com/users/blixtra/following{/other_user}","gists_url":"https://api.github.com/users/blixtra/gists{/gist_id}","starred_url":"https://api.github.com/users/blixtra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blixtra/subscriptions","organizations_url":"https://api.github.com/users/blixtra/orgs","repos_url":"https://api.github.com/users/blixtra/repos","events_url":"https://api.github.com/users/blixtra/events{/privacy}","received_events_url":"https://api.github.com/users/blixtra/received_events","type":"User","site_admin":false},"repo":{"id":42307931,"name":"rkt","full_name":"blixtra/rkt","owner":{"login":"blixtra","id":115075,"avatar_url":"https://avatars.githubusercontent.com/u/115075?v=3","gravatar_id":"","url":"https://api.github.com/users/blixtra","html_url":"https://github.com/blixtra","followers_url":"https://api.github.com/users/blixtra/followers","following_url":"https://api.github.com/users/blixtra/following{/other_user}","gists_url":"https://api.github.com/users/blixtra/gists{/gist_id}","starred_url":"https://api.github.com/users/blixtra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blixtra/subscriptions","organizations_url":"https://api.github.com/users/blixtra/orgs","repos_url":"https://api.github.com/users/blixtra/repos","events_url":"https://api.github.com/users/blixtra/events{/privacy}","received_events_url":"https://api.github.com/users/blixtra/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/blixtra/rkt","description":"rkt is an App Container runtime for Linux","fork":true,"url":"https://api.github.com/repos/blixtra/rkt","forks_url":"https://api.github.com/repos/blixtra/rkt/forks","keys_url":"https://api.github.com/repos/blixtra/rkt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/blixtra/rkt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/blixtra/rkt/teams","hooks_url":"https://api.github.com/repos/blixtra/rkt/hooks","issue_events_url":"https://api.github.com/repos/blixtra/rkt/issues/events{/number}","events_url":"https://api.github.com/repos/blixtra/rkt/events","assignees_url":"https://api.github.com/repos/blixtra/rkt/assignees{/user}","branches_url":"https://api.github.com/repos/blixtra/rkt/branches{/branch}","tags_url":"https://api.github.com/repos/blixtra/rkt/tags","blobs_url":"https://api.github.com/repos/blixtra/rkt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/blixtra/rkt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/blixtra/rkt/git/refs{/sha}","trees_url":"https://api.github.com/repos/blixtra/rkt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/blixtra/rkt/statuses/{sha}","languages_url":"https://api.github.com/repos/blixtra/rkt/languages","stargazers_url":"https://api.github.com/repos/blixtra/rkt/stargazers","contributors_url":"https://api.github.com/repos/blixtra/rkt/contributors","subscribers_url":"https://api.github.com/repos/blixtra/rkt/subscribers","subscription_url":"https://api.github.com/repos/blixtra/rkt/subscription","commits_url":"https://api.github.com/repos/blixtra/rkt/commits{/sha}","git_commits_url":"https://api.github.com/repos/blixtra/rkt/git/commits{/sha}","comments_url":"https://api.github.com/repos/blixtra/rkt/comments{/number}","issue_comment_url":"https://api.github.com/repos/blixtra/rkt/issues/comments{/number}","contents_url":"https://api.github.com/repos/blixtra/rkt/contents/{+path}","compare_url":"https://api.github.com/repos/blixtra/rkt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/blixtra/rkt/merges","archive_url":"https://api.github.com/repos/blixtra/rkt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/blixtra/rkt/downloads","issues_url":"https://api.github.com/repos/blixtra/rkt/issues{/number}","pulls_url":"https://api.github.com/repos/blixtra/rkt/pulls{/number}","milestones_url":"https://api.github.com/repos/blixtra/rkt/milestones{/number}","notifications_url":"https://api.github.com/repos/blixtra/rkt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/blixtra/rkt/labels{/name}","releases_url":"https://api.github.com/repos/blixtra/rkt/releases{/id}","created_at":"2015-09-11T12:45:16Z","updated_at":"2015-09-11T12:45:17Z","pushed_at":"2015-10-07T09:51:53Z","git_url":"git://github.com/blixtra/rkt.git","ssh_url":"git@github.com:blixtra/rkt.git","clone_url":"https://github.com/blixtra/rkt.git","svn_url":"https://github.com/blixtra/rkt","homepage":"","size":16398,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"coreos:master","ref":"master","sha":"8f4c3980c0717f4efc84043d476fa97fbe7a6b62","user":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"repo":{"id":26509369,"name":"rkt","full_name":"coreos/rkt","owner":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coreos/rkt","description":"rkt is an App Container runtime for Linux","fork":false,"url":"https://api.github.com/repos/coreos/rkt","forks_url":"https://api.github.com/repos/coreos/rkt/forks","keys_url":"https://api.github.com/repos/coreos/rkt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coreos/rkt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coreos/rkt/teams","hooks_url":"https://api.github.com/repos/coreos/rkt/hooks","issue_events_url":"https://api.github.com/repos/coreos/rkt/issues/events{/number}","events_url":"https://api.github.com/repos/coreos/rkt/events","assignees_url":"https://api.github.com/repos/coreos/rkt/assignees{/user}","branches_url":"https://api.github.com/repos/coreos/rkt/branches{/branch}","tags_url":"https://api.github.com/repos/coreos/rkt/tags","blobs_url":"https://api.github.com/repos/coreos/rkt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coreos/rkt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coreos/rkt/git/refs{/sha}","trees_url":"https://api.github.com/repos/coreos/rkt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coreos/rkt/statuses/{sha}","languages_url":"https://api.github.com/repos/coreos/rkt/languages","stargazers_url":"https://api.github.com/repos/coreos/rkt/stargazers","contributors_url":"https://api.github.com/repos/coreos/rkt/contributors","subscribers_url":"https://api.github.com/repos/coreos/rkt/subscribers","subscription_url":"https://api.github.com/repos/coreos/rkt/subscription","commits_url":"https://api.github.com/repos/coreos/rkt/commits{/sha}","git_commits_url":"https://api.github.com/repos/coreos/rkt/git/commits{/sha}","comments_url":"https://api.github.com/repos/coreos/rkt/comments{/number}","issue_comment_url":"https://api.github.com/repos/coreos/rkt/issues/comments{/number}","contents_url":"https://api.github.com/repos/coreos/rkt/contents/{+path}","compare_url":"https://api.github.com/repos/coreos/rkt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coreos/rkt/merges","archive_url":"https://api.github.com/repos/coreos/rkt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coreos/rkt/downloads","issues_url":"https://api.github.com/repos/coreos/rkt/issues{/number}","pulls_url":"https://api.github.com/repos/coreos/rkt/pulls{/number}","milestones_url":"https://api.github.com/repos/coreos/rkt/milestones{/number}","notifications_url":"https://api.github.com/repos/coreos/rkt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coreos/rkt/labels{/name}","releases_url":"https://api.github.com/repos/coreos/rkt/releases{/id}","created_at":"2014-11-11T23:13:18Z","updated_at":"2015-10-07T08:56:39Z","pushed_at":"2015-10-07T10:16:13Z","git_url":"git://github.com/coreos/rkt.git","ssh_url":"git@github.com:coreos/rkt.git","clone_url":"https://github.com/coreos/rkt.git","svn_url":"https://github.com/coreos/rkt","homepage":"","size":26302,"stargazers_count":4718,"watchers_count":4718,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":393,"mirror_url":null,"open_issues_count":175,"forks":393,"open_issues":175,"watchers":4718,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coreos/rkt/pulls/1546"},"html":{"href":"https://github.com/coreos/rkt/pull/1546"},"issue":{"href":"https://api.github.com/repos/coreos/rkt/issues/1546"},"comments":{"href":"https://api.github.com/repos/coreos/rkt/issues/1546/comments"},"review_comments":{"href":"https://api.github.com/repos/coreos/rkt/pulls/1546/comments"},"review_comment":{"href":"https://api.github.com/repos/coreos/rkt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coreos/rkt/pulls/1546/commits"},"statuses":{"href":"https://api.github.com/repos/coreos/rkt/statuses/cdd54df3490cace1dda1e41de993cdc4933c4649"}}}}