{"action":"created","issue":{"url":"https://api.github.com/repos/markovmodel/PyEMMA/issues/316","labels_url":"https://api.github.com/repos/markovmodel/PyEMMA/issues/316/labels{/name}","comments_url":"https://api.github.com/repos/markovmodel/PyEMMA/issues/316/comments","events_url":"https://api.github.com/repos/markovmodel/PyEMMA/issues/316/events","html_url":"https://github.com/markovmodel/PyEMMA/pull/316","id":78617025,"number":316,"title":"Improvements featurizer","user":{"login":"sstolzen007","id":11540502,"avatar_url":"https://avatars.githubusercontent.com/u/11540502?v=3","gravatar_id":"","url":"https://api.github.com/users/sstolzen007","html_url":"https://github.com/sstolzen007","followers_url":"https://api.github.com/users/sstolzen007/followers","following_url":"https://api.github.com/users/sstolzen007/following{/other_user}","gists_url":"https://api.github.com/users/sstolzen007/gists{/gist_id}","starred_url":"https://api.github.com/users/sstolzen007/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sstolzen007/subscriptions","organizations_url":"https://api.github.com/users/sstolzen007/orgs","repos_url":"https://api.github.com/users/sstolzen007/repos","events_url":"https://api.github.com/users/sstolzen007/events{/privacy}","received_events_url":"https://api.github.com/users/sstolzen007/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-05-20T17:27:15Z","updated_at":"2015-05-20T18:17:07Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/markovmodel/PyEMMA/pulls/316","html_url":"https://github.com/markovmodel/PyEMMA/pull/316","diff_url":"https://github.com/markovmodel/PyEMMA/pull/316.diff","patch_url":"https://github.com/markovmodel/PyEMMA/pull/316.patch"},"body":"* pre-selection for backbone torsions.\r\n* cos/sin components for chi1/phi/psi.\r\n* labels"},"comment":{"url":"https://api.github.com/repos/markovmodel/PyEMMA/issues/comments/103982616","html_url":"https://github.com/markovmodel/PyEMMA/pull/316#issuecomment-103982616","issue_url":"https://api.github.com/repos/markovmodel/PyEMMA/issues/316","id":103982616,"user":{"login":"franknoe","id":6495810,"avatar_url":"https://avatars.githubusercontent.com/u/6495810?v=3","gravatar_id":"","url":"https://api.github.com/users/franknoe","html_url":"https://github.com/franknoe","followers_url":"https://api.github.com/users/franknoe/followers","following_url":"https://api.github.com/users/franknoe/following{/other_user}","gists_url":"https://api.github.com/users/franknoe/gists{/gist_id}","starred_url":"https://api.github.com/users/franknoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/franknoe/subscriptions","organizations_url":"https://api.github.com/users/franknoe/orgs","repos_url":"https://api.github.com/users/franknoe/repos","events_url":"https://api.github.com/users/franknoe/events{/privacy}","received_events_url":"https://api.github.com/users/franknoe/received_events","type":"User","site_admin":false},"created_at":"2015-05-20T18:17:07Z","updated_at":"2015-05-20T18:17:07Z","body":"* If we do it, cos/sin calculation should be added to all torsion features, not just backbone and chi1torsions. So it should also appear in DihedralFeature and in add_dihedrals. Maybe we can put that functionality in the DihedralFeature superclass and just manage the dihedral selection in the subclasses?\r\n* The cos/sin option should affect the describe() output as well, because you now have doubled your dimensions, so you also need to double the number of description strings. For example, one could use \"COS ...\" and \"SIN ...\" followed by the normal dihedral description. Maybe you are doing something like this, but I can't spot it."}}