{"action":"created","issue":{"url":"https://api.github.com/repos/quantopian/zipline/issues/782","labels_url":"https://api.github.com/repos/quantopian/zipline/issues/782/labels{/name}","comments_url":"https://api.github.com/repos/quantopian/zipline/issues/782/comments","events_url":"https://api.github.com/repos/quantopian/zipline/issues/782/events","html_url":"https://github.com/quantopian/zipline/pull/782","id":111884416,"number":782,"title":"MAINT: Removes unneeded knowledge_date logic from future_chain","user":{"login":"jfkirk","id":10326791,"avatar_url":"https://avatars.githubusercontent.com/u/10326791?v=3","gravatar_id":"","url":"https://api.github.com/users/jfkirk","html_url":"https://github.com/jfkirk","followers_url":"https://api.github.com/users/jfkirk/followers","following_url":"https://api.github.com/users/jfkirk/following{/other_user}","gists_url":"https://api.github.com/users/jfkirk/gists{/gist_id}","starred_url":"https://api.github.com/users/jfkirk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfkirk/subscriptions","organizations_url":"https://api.github.com/users/jfkirk/orgs","repos_url":"https://api.github.com/users/jfkirk/repos","events_url":"https://api.github.com/users/jfkirk/events{/privacy}","received_events_url":"https://api.github.com/users/jfkirk/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-10-16T18:23:36Z","updated_at":"2015-10-19T15:52:52Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/quantopian/zipline/pulls/782","html_url":"https://github.com/quantopian/zipline/pull/782","diff_url":"https://github.com/quantopian/zipline/pull/782.diff","patch_url":"https://github.com/quantopian/zipline/pull/782.patch"},"body":"The knowledge_date logic could lead to a situation where a futures are inserted to the middle of the chain unexpectedly, and that could lead to inconsistent behavior in trading. To avoid this, the knowledge_date logic has been removed.\r\n\r\nIt is not far-fetched to assume that all contracts are known at all points in a simulation, as futures follow regular schedules and there are few, if any, surprises."},"comment":{"url":"https://api.github.com/repos/quantopian/zipline/issues/comments/149256092","html_url":"https://github.com/quantopian/zipline/pull/782#issuecomment-149256092","issue_url":"https://api.github.com/repos/quantopian/zipline/issues/782","id":149256092,"user":{"login":"yankees714","id":790109,"avatar_url":"https://avatars.githubusercontent.com/u/790109?v=3","gravatar_id":"","url":"https://api.github.com/users/yankees714","html_url":"https://github.com/yankees714","followers_url":"https://api.github.com/users/yankees714/followers","following_url":"https://api.github.com/users/yankees714/following{/other_user}","gists_url":"https://api.github.com/users/yankees714/gists{/gist_id}","starred_url":"https://api.github.com/users/yankees714/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yankees714/subscriptions","organizations_url":"https://api.github.com/users/yankees714/orgs","repos_url":"https://api.github.com/users/yankees714/repos","events_url":"https://api.github.com/users/yankees714/events{/privacy}","received_events_url":"https://api.github.com/users/yankees714/received_events","type":"User","site_admin":false},"created_at":"2015-10-19T15:52:52Z","updated_at":"2015-10-19T15:52:52Z","body":"LGTM"}}