{"action":"created","issue":{"url":"https://api.github.com/repos/yourabi/django-banish/issues/21","labels_url":"https://api.github.com/repos/yourabi/django-banish/issues/21/labels{/name}","comments_url":"https://api.github.com/repos/yourabi/django-banish/issues/21/comments","events_url":"https://api.github.com/repos/yourabi/django-banish/issues/21/events","html_url":"https://github.com/yourabi/django-banish/pull/21","id":55850431,"number":21,"title":"Added whitelist support","user":{"login":"jamonation","id":328553,"avatar_url":"https://avatars.githubusercontent.com/u/328553?v=3","gravatar_id":"","url":"https://api.github.com/users/jamonation","html_url":"https://github.com/jamonation","followers_url":"https://api.github.com/users/jamonation/followers","following_url":"https://api.github.com/users/jamonation/following{/other_user}","gists_url":"https://api.github.com/users/jamonation/gists{/gist_id}","starred_url":"https://api.github.com/users/jamonation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamonation/subscriptions","organizations_url":"https://api.github.com/users/jamonation/orgs","repos_url":"https://api.github.com/users/jamonation/repos","events_url":"https://api.github.com/users/jamonation/events{/privacy}","received_events_url":"https://api.github.com/users/jamonation/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-01-29T03:06:41Z","updated_at":"2015-01-29T18:24:01Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/yourabi/django-banish/pulls/21","html_url":"https://github.com/yourabi/django-banish/pull/21","diff_url":"https://github.com/yourabi/django-banish/pull/21.diff","patch_url":"https://github.com/yourabi/django-banish/pull/21.patch"},"body":"Thanks for reviving this app! I've added in what I think is a straightforward implementation of whitelisting an IP address by editing the model a bit, and adding in a check is_whitelisted to the middleware.\r\n\r\nI think the diff should be reasonably straightforward to review. Would you mind testing this out and getting back to me with any feedback? The Django instance that I'm testing with has some heavy caching so I'm not 100% sure that when I delete a ban/whitelist it takes effect immediately.\r\n\r\nCheers! Jamon"},"comment":{"url":"https://api.github.com/repos/yourabi/django-banish/issues/comments/72076551","html_url":"https://github.com/yourabi/django-banish/pull/21#issuecomment-72076551","issue_url":"https://api.github.com/repos/yourabi/django-banish/issues/21","id":72076551,"user":{"login":"jamonation","id":328553,"avatar_url":"https://avatars.githubusercontent.com/u/328553?v=3","gravatar_id":"","url":"https://api.github.com/users/jamonation","html_url":"https://github.com/jamonation","followers_url":"https://api.github.com/users/jamonation/followers","following_url":"https://api.github.com/users/jamonation/following{/other_user}","gists_url":"https://api.github.com/users/jamonation/gists{/gist_id}","starred_url":"https://api.github.com/users/jamonation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamonation/subscriptions","organizations_url":"https://api.github.com/users/jamonation/orgs","repos_url":"https://api.github.com/users/jamonation/repos","events_url":"https://api.github.com/users/jamonation/events{/privacy}","received_events_url":"https://api.github.com/users/jamonation/received_events","type":"User","site_admin":false},"created_at":"2015-01-29T18:24:01Z","updated_at":"2015-01-29T18:24:01Z","body":"That makes a lot of sense @groovecoder - this being my first look at Django I didn't realize I could have multiple models that show up in the admin UI. I've split whitelisting out into a separate model and the admin UI shows both types of operations now in separate forms for each type.\r\n\r\n@yourabi, how does this look to you?"}}