{"action":"created","comment":{"url":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments/30355443","id":30355443,"diff_hunk":"@@ -256,7 +267,7 @@ def f(x):\n         self.estimators_ = sum(out, list())\n         return self\n \n-    def predict(self, epochs, test_times=None, picks=None):\n+    def predict(self, epochs, test_times=None, y=None, picks=None):","path":"mne/decoding/time_gen.py","position":167,"original_position":167,"commit_id":"66ace037ccd383f7475cb25a45bc3f674d549e61","original_commit_id":"66ace037ccd383f7475cb25a45bc3f674d549e61","user":{"login":"agramfort","id":161052,"avatar_url":"https://avatars.githubusercontent.com/u/161052?v=3","gravatar_id":"","url":"https://api.github.com/users/agramfort","html_url":"https://github.com/agramfort","followers_url":"https://api.github.com/users/agramfort/followers","following_url":"https://api.github.com/users/agramfort/following{/other_user}","gists_url":"https://api.github.com/users/agramfort/gists{/gist_id}","starred_url":"https://api.github.com/users/agramfort/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agramfort/subscriptions","organizations_url":"https://api.github.com/users/agramfort/orgs","repos_url":"https://api.github.com/users/agramfort/repos","events_url":"https://api.github.com/users/agramfort/events{/privacy}","received_events_url":"https://api.github.com/users/agramfort/received_events","type":"User","site_admin":false},"body":"gat.fit(epochs[:10]).score(epochs[:10])\n\nshould be the way to go. Don't by pass the fit method...\n","created_at":"2015-05-14T19:44:51Z","updated_at":"2015-05-14T19:44:51Z","html_url":"https://github.com/mne-tools/mne-python/pull/2072#discussion_r30355443","pull_request_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/2072","_links":{"self":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments/30355443"},"html":{"href":"https://github.com/mne-tools/mne-python/pull/2072#discussion_r30355443"},"pull_request":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/2072"}}},"pull_request":{"url":"https://api.github.com/repos/mne-tools/mne-python/pulls/2072","id":35002654,"html_url":"https://github.com/mne-tools/mne-python/pull/2072","diff_url":"https://github.com/mne-tools/mne-python/pull/2072.diff","patch_url":"https://github.com/mne-tools/mne-python/pull/2072.patch","issue_url":"https://api.github.com/repos/mne-tools/mne-python/issues/2072","number":2072,"state":"open","locked":false,"title":"MRG: GAT small fixes","user":{"login":"kingjr","id":4881164,"avatar_url":"https://avatars.githubusercontent.com/u/4881164?v=3","gravatar_id":"","url":"https://api.github.com/users/kingjr","html_url":"https://github.com/kingjr","followers_url":"https://api.github.com/users/kingjr/followers","following_url":"https://api.github.com/users/kingjr/following{/other_user}","gists_url":"https://api.github.com/users/kingjr/gists{/gist_id}","starred_url":"https://api.github.com/users/kingjr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kingjr/subscriptions","organizations_url":"https://api.github.com/users/kingjr/orgs","repos_url":"https://api.github.com/users/kingjr/repos","events_url":"https://api.github.com/users/kingjr/events{/privacy}","received_events_url":"https://api.github.com/users/kingjr/received_events","type":"User","site_admin":false},"body":"This PR aims at cleaning up, testing and enhancing small features of the GAT.\r\n* By default, the classifier is changed from an SVC to a LogisticRegression to improve memory load and computation time. (SVC keeps all support vectors, and make the gat object quite heavy)\r\n* The ```picks``` parameters is now saved together with `ch_names`\r\n* The size of the prediction is now estimated from the first prediction. (In most use cases, this sizes is equal to 1, but for some prediction (derived from predict_proba or decision_function for instance), we can get higher ```y_pred``` dimensionality\r\n* The basic plots are improved:  1. chance level is estimated from the classifier,  2. the default ```ylim``` is empirically derived ([0 1] doesn't fit many classifiers) 3. a new plot gat.plot_slice(train_time) is added to allow users to make a non-diagonal slice of the gat matrix (as in King et al PLoS One). => Perhaps we should add this to the example?\r\n* Some more test to the plotting function.\r\n\r\nI'll keep to separate PR:\r\n* TimeResolvedDecoding\r\n* logarithmic level for >2 class plots","created_at":"2015-05-08T12:00:06Z","updated_at":"2015-05-14T19:44:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"df4662368b2712583c6dcffb867c7975cb3b83b5","assignee":null,"milestone":{"url":"https://api.github.com/repos/mne-tools/mne-python/milestones/5","html_url":"https://github.com/mne-tools/mne-python/milestones/0.9","labels_url":"https://api.github.com/repos/mne-tools/mne-python/milestones/5/labels","id":1011721,"number":5,"title":"0.9","description":null,"creator":{"login":"Eric89GXL","id":2365790,"avatar_url":"https://avatars.githubusercontent.com/u/2365790?v=3","gravatar_id":"","url":"https://api.github.com/users/Eric89GXL","html_url":"https://github.com/Eric89GXL","followers_url":"https://api.github.com/users/Eric89GXL/followers","following_url":"https://api.github.com/users/Eric89GXL/following{/other_user}","gists_url":"https://api.github.com/users/Eric89GXL/gists{/gist_id}","starred_url":"https://api.github.com/users/Eric89GXL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Eric89GXL/subscriptions","organizations_url":"https://api.github.com/users/Eric89GXL/orgs","repos_url":"https://api.github.com/users/Eric89GXL/repos","events_url":"https://api.github.com/users/Eric89GXL/events{/privacy}","received_events_url":"https://api.github.com/users/Eric89GXL/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":134,"state":"open","created_at":"2015-03-09T03:10:39Z","updated_at":"2015-05-14T17:25:06Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/2072/commits","review_comments_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/2072/comments","review_comment_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mne-tools/mne-python/issues/2072/comments","statuses_url":"https://api.github.com/repos/mne-tools/mne-python/statuses/66ace037ccd383f7475cb25a45bc3f674d549e61","head":{"label":"kingjr:gat_small_fixes","ref":"gat_small_fixes","sha":"66ace037ccd383f7475cb25a45bc3f674d549e61","user":{"login":"kingjr","id":4881164,"avatar_url":"https://avatars.githubusercontent.com/u/4881164?v=3","gravatar_id":"","url":"https://api.github.com/users/kingjr","html_url":"https://github.com/kingjr","followers_url":"https://api.github.com/users/kingjr/followers","following_url":"https://api.github.com/users/kingjr/following{/other_user}","gists_url":"https://api.github.com/users/kingjr/gists{/gist_id}","starred_url":"https://api.github.com/users/kingjr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kingjr/subscriptions","organizations_url":"https://api.github.com/users/kingjr/orgs","repos_url":"https://api.github.com/users/kingjr/repos","events_url":"https://api.github.com/users/kingjr/events{/privacy}","received_events_url":"https://api.github.com/users/kingjr/received_events","type":"User","site_admin":false},"repo":{"id":19731468,"name":"mne-python","full_name":"kingjr/mne-python","owner":{"login":"kingjr","id":4881164,"avatar_url":"https://avatars.githubusercontent.com/u/4881164?v=3","gravatar_id":"","url":"https://api.github.com/users/kingjr","html_url":"https://github.com/kingjr","followers_url":"https://api.github.com/users/kingjr/followers","following_url":"https://api.github.com/users/kingjr/following{/other_user}","gists_url":"https://api.github.com/users/kingjr/gists{/gist_id}","starred_url":"https://api.github.com/users/kingjr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kingjr/subscriptions","organizations_url":"https://api.github.com/users/kingjr/orgs","repos_url":"https://api.github.com/users/kingjr/repos","events_url":"https://api.github.com/users/kingjr/events{/privacy}","received_events_url":"https://api.github.com/users/kingjr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kingjr/mne-python","description":"MNE : Magnetoencephalography (MEG) and Electroencephalography (EEG) in Python","fork":true,"url":"https://api.github.com/repos/kingjr/mne-python","forks_url":"https://api.github.com/repos/kingjr/mne-python/forks","keys_url":"https://api.github.com/repos/kingjr/mne-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kingjr/mne-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kingjr/mne-python/teams","hooks_url":"https://api.github.com/repos/kingjr/mne-python/hooks","issue_events_url":"https://api.github.com/repos/kingjr/mne-python/issues/events{/number}","events_url":"https://api.github.com/repos/kingjr/mne-python/events","assignees_url":"https://api.github.com/repos/kingjr/mne-python/assignees{/user}","branches_url":"https://api.github.com/repos/kingjr/mne-python/branches{/branch}","tags_url":"https://api.github.com/repos/kingjr/mne-python/tags","blobs_url":"https://api.github.com/repos/kingjr/mne-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kingjr/mne-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kingjr/mne-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/kingjr/mne-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kingjr/mne-python/statuses/{sha}","languages_url":"https://api.github.com/repos/kingjr/mne-python/languages","stargazers_url":"https://api.github.com/repos/kingjr/mne-python/stargazers","contributors_url":"https://api.github.com/repos/kingjr/mne-python/contributors","subscribers_url":"https://api.github.com/repos/kingjr/mne-python/subscribers","subscription_url":"https://api.github.com/repos/kingjr/mne-python/subscription","commits_url":"https://api.github.com/repos/kingjr/mne-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/kingjr/mne-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/kingjr/mne-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/kingjr/mne-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/kingjr/mne-python/contents/{+path}","compare_url":"https://api.github.com/repos/kingjr/mne-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kingjr/mne-python/merges","archive_url":"https://api.github.com/repos/kingjr/mne-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kingjr/mne-python/downloads","issues_url":"https://api.github.com/repos/kingjr/mne-python/issues{/number}","pulls_url":"https://api.github.com/repos/kingjr/mne-python/pulls{/number}","milestones_url":"https://api.github.com/repos/kingjr/mne-python/milestones{/number}","notifications_url":"https://api.github.com/repos/kingjr/mne-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kingjr/mne-python/labels{/name}","releases_url":"https://api.github.com/repos/kingjr/mne-python/releases{/id}","created_at":"2014-05-13T08:28:44Z","updated_at":"2014-06-02T12:58:51Z","pushed_at":"2015-05-14T18:35:05Z","git_url":"git://github.com/kingjr/mne-python.git","ssh_url":"git@github.com:kingjr/mne-python.git","clone_url":"https://github.com/kingjr/mne-python.git","svn_url":"https://github.com/kingjr/mne-python","homepage":"http://martinos.org/mne/","size":77415,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mne-tools:master","ref":"master","sha":"7f8071891d7a8c2fdaa61ea3a8819394fcd86de2","user":{"login":"mne-tools","id":583875,"avatar_url":"https://avatars.githubusercontent.com/u/583875?v=3","gravatar_id":"","url":"https://api.github.com/users/mne-tools","html_url":"https://github.com/mne-tools","followers_url":"https://api.github.com/users/mne-tools/followers","following_url":"https://api.github.com/users/mne-tools/following{/other_user}","gists_url":"https://api.github.com/users/mne-tools/gists{/gist_id}","starred_url":"https://api.github.com/users/mne-tools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mne-tools/subscriptions","organizations_url":"https://api.github.com/users/mne-tools/orgs","repos_url":"https://api.github.com/users/mne-tools/repos","events_url":"https://api.github.com/users/mne-tools/events{/privacy}","received_events_url":"https://api.github.com/users/mne-tools/received_events","type":"Organization","site_admin":false},"repo":{"id":1301584,"name":"mne-python","full_name":"mne-tools/mne-python","owner":{"login":"mne-tools","id":583875,"avatar_url":"https://avatars.githubusercontent.com/u/583875?v=3","gravatar_id":"","url":"https://api.github.com/users/mne-tools","html_url":"https://github.com/mne-tools","followers_url":"https://api.github.com/users/mne-tools/followers","following_url":"https://api.github.com/users/mne-tools/following{/other_user}","gists_url":"https://api.github.com/users/mne-tools/gists{/gist_id}","starred_url":"https://api.github.com/users/mne-tools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mne-tools/subscriptions","organizations_url":"https://api.github.com/users/mne-tools/orgs","repos_url":"https://api.github.com/users/mne-tools/repos","events_url":"https://api.github.com/users/mne-tools/events{/privacy}","received_events_url":"https://api.github.com/users/mne-tools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mne-tools/mne-python","description":"MNE : Magnetoencephalography (MEG) and Electroencephalography (EEG) in Python","fork":false,"url":"https://api.github.com/repos/mne-tools/mne-python","forks_url":"https://api.github.com/repos/mne-tools/mne-python/forks","keys_url":"https://api.github.com/repos/mne-tools/mne-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mne-tools/mne-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mne-tools/mne-python/teams","hooks_url":"https://api.github.com/repos/mne-tools/mne-python/hooks","issue_events_url":"https://api.github.com/repos/mne-tools/mne-python/issues/events{/number}","events_url":"https://api.github.com/repos/mne-tools/mne-python/events","assignees_url":"https://api.github.com/repos/mne-tools/mne-python/assignees{/user}","branches_url":"https://api.github.com/repos/mne-tools/mne-python/branches{/branch}","tags_url":"https://api.github.com/repos/mne-tools/mne-python/tags","blobs_url":"https://api.github.com/repos/mne-tools/mne-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mne-tools/mne-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mne-tools/mne-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/mne-tools/mne-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mne-tools/mne-python/statuses/{sha}","languages_url":"https://api.github.com/repos/mne-tools/mne-python/languages","stargazers_url":"https://api.github.com/repos/mne-tools/mne-python/stargazers","contributors_url":"https://api.github.com/repos/mne-tools/mne-python/contributors","subscribers_url":"https://api.github.com/repos/mne-tools/mne-python/subscribers","subscription_url":"https://api.github.com/repos/mne-tools/mne-python/subscription","commits_url":"https://api.github.com/repos/mne-tools/mne-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/mne-tools/mne-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/mne-tools/mne-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/mne-tools/mne-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/mne-tools/mne-python/contents/{+path}","compare_url":"https://api.github.com/repos/mne-tools/mne-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mne-tools/mne-python/merges","archive_url":"https://api.github.com/repos/mne-tools/mne-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mne-tools/mne-python/downloads","issues_url":"https://api.github.com/repos/mne-tools/mne-python/issues{/number}","pulls_url":"https://api.github.com/repos/mne-tools/mne-python/pulls{/number}","milestones_url":"https://api.github.com/repos/mne-tools/mne-python/milestones{/number}","notifications_url":"https://api.github.com/repos/mne-tools/mne-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mne-tools/mne-python/labels{/name}","releases_url":"https://api.github.com/repos/mne-tools/mne-python/releases{/id}","created_at":"2011-01-28T03:31:13Z","updated_at":"2015-05-08T07:28:10Z","pushed_at":"2015-05-14T18:35:07Z","git_url":"git://github.com/mne-tools/mne-python.git","ssh_url":"git@github.com:mne-tools/mne-python.git","clone_url":"https://github.com/mne-tools/mne-python.git","svn_url":"https://github.com/mne-tools/mne-python","homepage":"http://martinos.org/mne/","size":169500,"stargazers_count":128,"watchers_count":128,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":115,"mirror_url":null,"open_issues_count":132,"forks":115,"open_issues":132,"watchers":128,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/2072"},"html":{"href":"https://github.com/mne-tools/mne-python/pull/2072"},"issue":{"href":"https://api.github.com/repos/mne-tools/mne-python/issues/2072"},"comments":{"href":"https://api.github.com/repos/mne-tools/mne-python/issues/2072/comments"},"review_comments":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/2072/comments"},"review_comment":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/2072/commits"},"statuses":{"href":"https://api.github.com/repos/mne-tools/mne-python/statuses/66ace037ccd383f7475cb25a45bc3f674d549e61"}}}}