{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/29958587","id":29958587,"diff_hunk":"@@ -169,10 +168,6 @@ public void ListenAndDispatchConnections(string pipeName, TimeSpan? keepAlive, b\n             Task<NamedPipeServerStream> listenTask = null;\n             CancellationTokenSource listenCancellationTokenSource = null;\n \n-            // If we aren't being asked to watch analyzer files then simple create a Task which never \n-            // completes.  This is the behavior of AnalyzerWatcher when files don't change on disk.\n-            Task analyzerTask = watchAnalyzerFiles ? CompilerServerFileWatcher.CreateWatchFilesTask() : new TaskCompletionSource<bool>().Task;","path":"src/Compilers/Core/VBCSCompiler/ServerDispatcher.cs","position":25,"original_position":25,"commit_id":"3d98202c1d117558025a4d593131b7d876c7c23e","original_commit_id":"4fb863e94bf35e74ed56083550d40e3210c909f5","user":{"login":"mavasani","id":10605811,"avatar_url":"https://avatars.githubusercontent.com/u/10605811?v=3","gravatar_id":"","url":"https://api.github.com/users/mavasani","html_url":"https://github.com/mavasani","followers_url":"https://api.github.com/users/mavasani/followers","following_url":"https://api.github.com/users/mavasani/following{/other_user}","gists_url":"https://api.github.com/users/mavasani/gists{/gist_id}","starred_url":"https://api.github.com/users/mavasani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mavasani/subscriptions","organizations_url":"https://api.github.com/users/mavasani/orgs","repos_url":"https://api.github.com/users/mavasani/repos","events_url":"https://api.github.com/users/mavasani/events{/privacy}","received_events_url":"https://api.github.com/users/mavasani/received_events","type":"User","site_admin":false},"body":"Great, thanks!","created_at":"2015-05-08T17:25:28Z","updated_at":"2015-05-08T17:25:28Z","html_url":"https://github.com/dotnet/roslyn/pull/2502#discussion_r29958587","pull_request_url":"https://api.github.com/repos/dotnet/roslyn/pulls/2502","_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/29958587"},"html":{"href":"https://github.com/dotnet/roslyn/pull/2502#discussion_r29958587"},"pull_request":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/2502"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/2502","id":34684008,"html_url":"https://github.com/dotnet/roslyn/pull/2502","diff_url":"https://github.com/dotnet/roslyn/pull/2502.diff","patch_url":"https://github.com/dotnet/roslyn/pull/2502.patch","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/2502","number":2502,"state":"open","locked":false,"title":"Reject builds with analyzer inconsistencies","user":{"login":"tmeschter","id":10506730,"avatar_url":"https://avatars.githubusercontent.com/u/10506730?v=3","gravatar_id":"","url":"https://api.github.com/users/tmeschter","html_url":"https://github.com/tmeschter","followers_url":"https://api.github.com/users/tmeschter/followers","following_url":"https://api.github.com/users/tmeschter/following{/other_user}","gists_url":"https://api.github.com/users/tmeschter/gists{/gist_id}","starred_url":"https://api.github.com/users/tmeschter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmeschter/subscriptions","organizations_url":"https://api.github.com/users/tmeschter/orgs","repos_url":"https://api.github.com/users/tmeschter/repos","events_url":"https://api.github.com/users/tmeschter/events{/privacy}","received_events_url":"https://api.github.com/users/tmeschter/received_events","type":"User","site_admin":false},"body":"This commit updates vbcscompiler.exe to reject builds where the list of\r\nanalyzers is incomplete (i.e., some of the analyzers depend on\r\nassemblies that are not present), we're unable to load the analyzers, or\r\nthe assemblies on disk do not actually match the ones that are loaded.\r\n\r\nIf one of these checks fails the build request is rejected, and the\r\nclients have been updated to fall back to running the build in their own\r\nprocess (that is, csc.exe or vbc.exe).\r\n\r\nIt is possible in some cases that a build that was rejected by\r\nvbcscompiler.exe will succeed in csc.exe/vbc.exe. Generally this will\r\noccur when an analyzer dependency is not passed via the `/analyzer`\r\nswitch but happens to be in a place where the CLR will find and load it\r\nautomatically. We want to ensure consistency which is why these builds\r\nare not allowed in vbcscompiler.exe; otherwise we risk a build sometimes\r\nsucceeding and sometimes failing depending on which assemblies happen to\r\nhave been loaded by other, unrelated builds.\r\n\r\nThis commit adds utility code for the following:\r\n\r\n1. Mapping from an assembly to its nearby dependencies on disk.\r\n2. Checking that an assembly file and a loaded `Assembly` have the same MVIDs.\r\n3. Identifying which assembly identities are missing from a set.\r\n4. Checking if an assembly on disk has a strong name or not.\r\n\r\nUnit tests are also included for these utilities.","created_at":"2015-05-04T23:04:52Z","updated_at":"2015-05-08T17:25:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2ea6710a4c73d1c80ebf18e2c7c698bf3053a5d6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/roslyn/pulls/2502/commits","review_comments_url":"https://api.github.com/repos/dotnet/roslyn/pulls/2502/comments","review_comment_url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/2502/comments","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/3d98202c1d117558025a4d593131b7d876c7c23e","head":{"label":"tmeschter:AnalyzerAssemblyChecks","ref":"AnalyzerAssemblyChecks","sha":"3d98202c1d117558025a4d593131b7d876c7c23e","user":{"login":"tmeschter","id":10506730,"avatar_url":"https://avatars.githubusercontent.com/u/10506730?v=3","gravatar_id":"","url":"https://api.github.com/users/tmeschter","html_url":"https://github.com/tmeschter","followers_url":"https://api.github.com/users/tmeschter/followers","following_url":"https://api.github.com/users/tmeschter/following{/other_user}","gists_url":"https://api.github.com/users/tmeschter/gists{/gist_id}","starred_url":"https://api.github.com/users/tmeschter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmeschter/subscriptions","organizations_url":"https://api.github.com/users/tmeschter/orgs","repos_url":"https://api.github.com/users/tmeschter/repos","events_url":"https://api.github.com/users/tmeschter/events{/privacy}","received_events_url":"https://api.github.com/users/tmeschter/received_events","type":"User","site_admin":false},"repo":{"id":30270414,"name":"roslyn","full_name":"tmeschter/roslyn","owner":{"login":"tmeschter","id":10506730,"avatar_url":"https://avatars.githubusercontent.com/u/10506730?v=3","gravatar_id":"","url":"https://api.github.com/users/tmeschter","html_url":"https://github.com/tmeschter","followers_url":"https://api.github.com/users/tmeschter/followers","following_url":"https://api.github.com/users/tmeschter/following{/other_user}","gists_url":"https://api.github.com/users/tmeschter/gists{/gist_id}","starred_url":"https://api.github.com/users/tmeschter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmeschter/subscriptions","organizations_url":"https://api.github.com/users/tmeschter/orgs","repos_url":"https://api.github.com/users/tmeschter/repos","events_url":"https://api.github.com/users/tmeschter/events{/privacy}","received_events_url":"https://api.github.com/users/tmeschter/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tmeschter/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":true,"url":"https://api.github.com/repos/tmeschter/roslyn","forks_url":"https://api.github.com/repos/tmeschter/roslyn/forks","keys_url":"https://api.github.com/repos/tmeschter/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tmeschter/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tmeschter/roslyn/teams","hooks_url":"https://api.github.com/repos/tmeschter/roslyn/hooks","issue_events_url":"https://api.github.com/repos/tmeschter/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/tmeschter/roslyn/events","assignees_url":"https://api.github.com/repos/tmeschter/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/tmeschter/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/tmeschter/roslyn/tags","blobs_url":"https://api.github.com/repos/tmeschter/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tmeschter/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tmeschter/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/tmeschter/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tmeschter/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/tmeschter/roslyn/languages","stargazers_url":"https://api.github.com/repos/tmeschter/roslyn/stargazers","contributors_url":"https://api.github.com/repos/tmeschter/roslyn/contributors","subscribers_url":"https://api.github.com/repos/tmeschter/roslyn/subscribers","subscription_url":"https://api.github.com/repos/tmeschter/roslyn/subscription","commits_url":"https://api.github.com/repos/tmeschter/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/tmeschter/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/tmeschter/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/tmeschter/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/tmeschter/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/tmeschter/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tmeschter/roslyn/merges","archive_url":"https://api.github.com/repos/tmeschter/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tmeschter/roslyn/downloads","issues_url":"https://api.github.com/repos/tmeschter/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/tmeschter/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/tmeschter/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/tmeschter/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tmeschter/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/tmeschter/roslyn/releases{/id}","created_at":"2015-02-03T23:28:08Z","updated_at":"2015-02-19T19:54:34Z","pushed_at":"2015-05-08T15:25:49Z","git_url":"git://github.com/tmeschter/roslyn.git","ssh_url":"git@github.com:tmeschter/roslyn.git","clone_url":"https://github.com/tmeschter/roslyn.git","svn_url":"https://github.com/tmeschter/roslyn","homepage":"","size":72262,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"9c66e81c1424d8f4999f70eb8b85f0e76f253c30","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":29078997,"name":"roslyn","full_name":"dotnet/roslyn","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":false,"url":"https://api.github.com/repos/dotnet/roslyn","forks_url":"https://api.github.com/repos/dotnet/roslyn/forks","keys_url":"https://api.github.com/repos/dotnet/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/roslyn/teams","hooks_url":"https://api.github.com/repos/dotnet/roslyn/hooks","issue_events_url":"https://api.github.com/repos/dotnet/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/roslyn/events","assignees_url":"https://api.github.com/repos/dotnet/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/roslyn/tags","blobs_url":"https://api.github.com/repos/dotnet/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/roslyn/languages","stargazers_url":"https://api.github.com/repos/dotnet/roslyn/stargazers","contributors_url":"https://api.github.com/repos/dotnet/roslyn/contributors","subscribers_url":"https://api.github.com/repos/dotnet/roslyn/subscribers","subscription_url":"https://api.github.com/repos/dotnet/roslyn/subscription","commits_url":"https://api.github.com/repos/dotnet/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/roslyn/merges","archive_url":"https://api.github.com/repos/dotnet/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/roslyn/downloads","issues_url":"https://api.github.com/repos/dotnet/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/roslyn/releases{/id}","created_at":"2015-01-11T02:39:03Z","updated_at":"2015-05-08T16:43:30Z","pushed_at":"2015-05-08T16:43:32Z","git_url":"git://github.com/dotnet/roslyn.git","ssh_url":"git@github.com:dotnet/roslyn.git","clone_url":"https://github.com/dotnet/roslyn.git","svn_url":"https://github.com/dotnet/roslyn","homepage":"","size":127358,"stargazers_count":2233,"watchers_count":2233,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":469,"mirror_url":null,"open_issues_count":787,"forks":469,"open_issues":787,"watchers":2233,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/2502"},"html":{"href":"https://github.com/dotnet/roslyn/pull/2502"},"issue":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/2502"},"comments":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/2502/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/2502/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/2502/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/roslyn/statuses/3d98202c1d117558025a4d593131b7d876c7c23e"}}}}