{"action":"created","issue":{"url":"https://api.github.com/repos/modxcms/revolution/issues/12550","labels_url":"https://api.github.com/repos/modxcms/revolution/issues/12550/labels{/name}","comments_url":"https://api.github.com/repos/modxcms/revolution/issues/12550/comments","events_url":"https://api.github.com/repos/modxcms/revolution/issues/12550/events","html_url":"https://github.com/modxcms/revolution/pull/12550","id":100639733,"number":12550,"title":"Fix #12549: Site name in header not accounting for quotes","user":{"login":"OptimusCrime","id":2326278,"avatar_url":"https://avatars.githubusercontent.com/u/2326278?v=3","gravatar_id":"","url":"https://api.github.com/users/OptimusCrime","html_url":"https://github.com/OptimusCrime","followers_url":"https://api.github.com/users/OptimusCrime/followers","following_url":"https://api.github.com/users/OptimusCrime/following{/other_user}","gists_url":"https://api.github.com/users/OptimusCrime/gists{/gist_id}","starred_url":"https://api.github.com/users/OptimusCrime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OptimusCrime/subscriptions","organizations_url":"https://api.github.com/users/OptimusCrime/orgs","repos_url":"https://api.github.com/users/OptimusCrime/repos","events_url":"https://api.github.com/users/OptimusCrime/events{/privacy}","received_events_url":"https://api.github.com/users/OptimusCrime/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/modxcms/revolution/milestones/57","html_url":"https://github.com/modxcms/revolution/milestones/v2.4.0-pl","labels_url":"https://api.github.com/repos/modxcms/revolution/milestones/57/labels","id":723777,"number":57,"title":"v2.4.0-pl","description":"Features for the next minor release of MODX Revolution 2.x","creator":{"login":"opengeek","id":232812,"avatar_url":"https://avatars.githubusercontent.com/u/232812?v=3","gravatar_id":"","url":"https://api.github.com/users/opengeek","html_url":"https://github.com/opengeek","followers_url":"https://api.github.com/users/opengeek/followers","following_url":"https://api.github.com/users/opengeek/following{/other_user}","gists_url":"https://api.github.com/users/opengeek/gists{/gist_id}","starred_url":"https://api.github.com/users/opengeek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opengeek/subscriptions","organizations_url":"https://api.github.com/users/opengeek/orgs","repos_url":"https://api.github.com/users/opengeek/repos","events_url":"https://api.github.com/users/opengeek/events{/privacy}","received_events_url":"https://api.github.com/users/opengeek/received_events","type":"User","site_admin":false},"open_issues":21,"closed_issues":109,"state":"open","created_at":"2014-07-17T05:06:15Z","updated_at":"2015-08-12T22:41:30Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2015-08-12T21:30:13Z","updated_at":"2015-08-12T22:46:55Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/modxcms/revolution/pulls/12550","html_url":"https://github.com/modxcms/revolution/pull/12550","diff_url":"https://github.com/modxcms/revolution/pull/12550.diff","patch_url":"https://github.com/modxcms/revolution/pull/12550.patch"},"body":"### Summary\r\nFixes issue #12549 where the tooltip for the site name does not account for quotes in the site name. The description visible in the tooltip is truncated at the first occurence of a quote.\r\n\r\n### Step to reproduce\r\nGive the site a name containing a quote.\r\n\r\n### Observed behavior\r\nHover the site name in the top menu. The tooltip that should appear is truncated.\r\n\r\n### Expected behavior\r\nThe tooltip should not be truncated.\r\n\r\n### Environment\r\nRunning MODX Revolution 2.4.0-rc1, forked and synced with modxcms/revolution today (12.08.15). Nothing else is relevant"},"comment":{"url":"https://api.github.com/repos/modxcms/revolution/issues/comments/130470290","html_url":"https://github.com/modxcms/revolution/pull/12550#issuecomment-130470290","issue_url":"https://api.github.com/repos/modxcms/revolution/issues/12550","id":130470290,"user":{"login":"pixelchutes","id":352182,"avatar_url":"https://avatars.githubusercontent.com/u/352182?v=3","gravatar_id":"","url":"https://api.github.com/users/pixelchutes","html_url":"https://github.com/pixelchutes","followers_url":"https://api.github.com/users/pixelchutes/followers","following_url":"https://api.github.com/users/pixelchutes/following{/other_user}","gists_url":"https://api.github.com/users/pixelchutes/gists{/gist_id}","starred_url":"https://api.github.com/users/pixelchutes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pixelchutes/subscriptions","organizations_url":"https://api.github.com/users/pixelchutes/orgs","repos_url":"https://api.github.com/users/pixelchutes/repos","events_url":"https://api.github.com/users/pixelchutes/events{/privacy}","received_events_url":"https://api.github.com/users/pixelchutes/received_events","type":"User","site_admin":false},"created_at":"2015-08-12T22:46:55Z","updated_at":"2015-08-12T22:46:55Z","body":"I have not verified, but this should probably be passed through `|strip_tags` first, to prevent potential XSS?"}}