{"action":"created","comment":{"url":"https://api.github.com/repos/mattermost/platform/pulls/comments/37266063","id":37266063,"diff_hunk":"@@ -3,67 +3,102 @@\n \n var ChannelStore = require('../stores/channel_store.jsx');\n var TeamStore = require('../stores/team_store.jsx');\n+var Client = require('../utils/client.jsx');\n+var AsyncClient = require('../utils/async_client.jsx');\n var utils = require('../utils/utils.jsx');\n \n module.exports = React.createClass({\n+    displayName: 'MoreDirectChannels',\n     componentDidMount: function() {\n         var self = this;\n-        $(this.refs.modal.getDOMNode()).on('show.bs.modal', function(e) {\n+        $(this.refs.modal.getDOMNode()).on('show.bs.modal', function showModal(e) {\n             var button = e.relatedTarget;\n-            self.setState({ channels: $(button).data('channels') });\n+            self.setState({channels: $(button).data('channels')});\n         });\n     },\n     getInitialState: function() {\n-        return { channels: [] };\n+        return {channels: [], loadingPMChannel: -1};","path":"web/react/components/more_direct_channels.jsx","position":21,"original_position":21,"commit_id":"411d1340cb4164c7486865b71ad430d3ae4ae685","original_commit_id":"411d1340cb4164c7486865b71ad430d3ae4ae685","user":{"login":"rgarmsen2295","id":9124858,"avatar_url":"https://avatars.githubusercontent.com/u/9124858?v=3","gravatar_id":"","url":"https://api.github.com/users/rgarmsen2295","html_url":"https://github.com/rgarmsen2295","followers_url":"https://api.github.com/users/rgarmsen2295/followers","following_url":"https://api.github.com/users/rgarmsen2295/following{/other_user}","gists_url":"https://api.github.com/users/rgarmsen2295/gists{/gist_id}","starred_url":"https://api.github.com/users/rgarmsen2295/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgarmsen2295/subscriptions","organizations_url":"https://api.github.com/users/rgarmsen2295/orgs","repos_url":"https://api.github.com/users/rgarmsen2295/repos","events_url":"https://api.github.com/users/rgarmsen2295/events{/privacy}","received_events_url":"https://api.github.com/users/rgarmsen2295/received_events","type":"User","site_admin":false},"body":"Oh so remove _all_ references to private message channels.  Okay, misunderstood, thought it was only stuff dealing with the backend since we call direct message channels private message channels to users, but it does make more sense to be completely consistent with variables and functions one way or the other, I'll change it when I get a chance tomorrow.","created_at":"2015-08-18T05:49:44Z","updated_at":"2015-08-18T05:49:44Z","html_url":"https://github.com/mattermost/platform/pull/383#discussion_r37266063","pull_request_url":"https://api.github.com/repos/mattermost/platform/pulls/383","_links":{"self":{"href":"https://api.github.com/repos/mattermost/platform/pulls/comments/37266063"},"html":{"href":"https://github.com/mattermost/platform/pull/383#discussion_r37266063"},"pull_request":{"href":"https://api.github.com/repos/mattermost/platform/pulls/383"}}},"pull_request":{"url":"https://api.github.com/repos/mattermost/platform/pulls/383","id":42511276,"html_url":"https://github.com/mattermost/platform/pull/383","diff_url":"https://github.com/mattermost/platform/pull/383.diff","patch_url":"https://github.com/mattermost/platform/pull/383.patch","issue_url":"https://api.github.com/repos/mattermost/platform/issues/383","number":383,"state":"open","locked":false,"title":"MM-1584 Private message channels no longer do a page refresh on creation/first use","user":{"login":"rgarmsen2295","id":9124858,"avatar_url":"https://avatars.githubusercontent.com/u/9124858?v=3","gravatar_id":"","url":"https://api.github.com/users/rgarmsen2295","html_url":"https://github.com/rgarmsen2295","followers_url":"https://api.github.com/users/rgarmsen2295/followers","following_url":"https://api.github.com/users/rgarmsen2295/following{/other_user}","gists_url":"https://api.github.com/users/rgarmsen2295/gists{/gist_id}","starred_url":"https://api.github.com/users/rgarmsen2295/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgarmsen2295/subscriptions","organizations_url":"https://api.github.com/users/rgarmsen2295/orgs","repos_url":"https://api.github.com/users/rgarmsen2295/repos","events_url":"https://api.github.com/users/rgarmsen2295/events{/privacy}","received_events_url":"https://api.github.com/users/rgarmsen2295/received_events","type":"User","site_admin":false},"body":"I believe this should also fix the issue with online status icons not appearing for uncreated PM channels as a side-effect.  When a user clicks on a new PM channel instead of refreshing, a new client call is made to get the server to create the channel that causes the user to switch to the PM channel on completion.  The online status icon is replaced by a loading gif while this occurs, which is usually less than a second except on slow connections.  On failure it simply falls back to the original method of channel creation.","created_at":"2015-08-15T01:40:31Z","updated_at":"2015-08-18T05:49:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e211067052717d6ac72adb2edac0bf9645a50642","assignee":{"login":"coreyhulen","id":1431746,"avatar_url":"https://avatars.githubusercontent.com/u/1431746?v=3","gravatar_id":"","url":"https://api.github.com/users/coreyhulen","html_url":"https://github.com/coreyhulen","followers_url":"https://api.github.com/users/coreyhulen/followers","following_url":"https://api.github.com/users/coreyhulen/following{/other_user}","gists_url":"https://api.github.com/users/coreyhulen/gists{/gist_id}","starred_url":"https://api.github.com/users/coreyhulen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreyhulen/subscriptions","organizations_url":"https://api.github.com/users/coreyhulen/orgs","repos_url":"https://api.github.com/users/coreyhulen/repos","events_url":"https://api.github.com/users/coreyhulen/events{/privacy}","received_events_url":"https://api.github.com/users/coreyhulen/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/mattermost/platform/milestones/2","html_url":"https://github.com/mattermost/platform/milestones/v0.7.0","labels_url":"https://api.github.com/repos/mattermost/platform/milestones/2/labels","id":1229900,"number":2,"title":"v0.7.0","description":"","creator":{"login":"it33","id":177788,"avatar_url":"https://avatars.githubusercontent.com/u/177788?v=3","gravatar_id":"","url":"https://api.github.com/users/it33","html_url":"https://github.com/it33","followers_url":"https://api.github.com/users/it33/followers","following_url":"https://api.github.com/users/it33/following{/other_user}","gists_url":"https://api.github.com/users/it33/gists{/gist_id}","starred_url":"https://api.github.com/users/it33/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/it33/subscriptions","organizations_url":"https://api.github.com/users/it33/orgs","repos_url":"https://api.github.com/users/it33/repos","events_url":"https://api.github.com/users/it33/events{/privacy}","received_events_url":"https://api.github.com/users/it33/received_events","type":"User","site_admin":false},"open_issues":12,"closed_issues":34,"state":"open","created_at":"2015-07-28T17:01:12Z","updated_at":"2015-08-17T13:44:27Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/mattermost/platform/pulls/383/commits","review_comments_url":"https://api.github.com/repos/mattermost/platform/pulls/383/comments","review_comment_url":"https://api.github.com/repos/mattermost/platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mattermost/platform/issues/383/comments","statuses_url":"https://api.github.com/repos/mattermost/platform/statuses/411d1340cb4164c7486865b71ad430d3ae4ae685","head":{"label":"rgarmsen2295:mm-1584b","ref":"mm-1584b","sha":"411d1340cb4164c7486865b71ad430d3ae4ae685","user":{"login":"rgarmsen2295","id":9124858,"avatar_url":"https://avatars.githubusercontent.com/u/9124858?v=3","gravatar_id":"","url":"https://api.github.com/users/rgarmsen2295","html_url":"https://github.com/rgarmsen2295","followers_url":"https://api.github.com/users/rgarmsen2295/followers","following_url":"https://api.github.com/users/rgarmsen2295/following{/other_user}","gists_url":"https://api.github.com/users/rgarmsen2295/gists{/gist_id}","starred_url":"https://api.github.com/users/rgarmsen2295/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgarmsen2295/subscriptions","organizations_url":"https://api.github.com/users/rgarmsen2295/orgs","repos_url":"https://api.github.com/users/rgarmsen2295/repos","events_url":"https://api.github.com/users/rgarmsen2295/events{/privacy}","received_events_url":"https://api.github.com/users/rgarmsen2295/received_events","type":"User","site_admin":false},"repo":{"id":37988993,"name":"platform","full_name":"rgarmsen2295/platform","owner":{"login":"rgarmsen2295","id":9124858,"avatar_url":"https://avatars.githubusercontent.com/u/9124858?v=3","gravatar_id":"","url":"https://api.github.com/users/rgarmsen2295","html_url":"https://github.com/rgarmsen2295","followers_url":"https://api.github.com/users/rgarmsen2295/followers","following_url":"https://api.github.com/users/rgarmsen2295/following{/other_user}","gists_url":"https://api.github.com/users/rgarmsen2295/gists{/gist_id}","starred_url":"https://api.github.com/users/rgarmsen2295/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgarmsen2295/subscriptions","organizations_url":"https://api.github.com/users/rgarmsen2295/orgs","repos_url":"https://api.github.com/users/rgarmsen2295/repos","events_url":"https://api.github.com/users/rgarmsen2295/events{/privacy}","received_events_url":"https://api.github.com/users/rgarmsen2295/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rgarmsen2295/platform","description":"Team communication service across PC and phones, with archiving and search.","fork":true,"url":"https://api.github.com/repos/rgarmsen2295/platform","forks_url":"https://api.github.com/repos/rgarmsen2295/platform/forks","keys_url":"https://api.github.com/repos/rgarmsen2295/platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rgarmsen2295/platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rgarmsen2295/platform/teams","hooks_url":"https://api.github.com/repos/rgarmsen2295/platform/hooks","issue_events_url":"https://api.github.com/repos/rgarmsen2295/platform/issues/events{/number}","events_url":"https://api.github.com/repos/rgarmsen2295/platform/events","assignees_url":"https://api.github.com/repos/rgarmsen2295/platform/assignees{/user}","branches_url":"https://api.github.com/repos/rgarmsen2295/platform/branches{/branch}","tags_url":"https://api.github.com/repos/rgarmsen2295/platform/tags","blobs_url":"https://api.github.com/repos/rgarmsen2295/platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rgarmsen2295/platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rgarmsen2295/platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/rgarmsen2295/platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rgarmsen2295/platform/statuses/{sha}","languages_url":"https://api.github.com/repos/rgarmsen2295/platform/languages","stargazers_url":"https://api.github.com/repos/rgarmsen2295/platform/stargazers","contributors_url":"https://api.github.com/repos/rgarmsen2295/platform/contributors","subscribers_url":"https://api.github.com/repos/rgarmsen2295/platform/subscribers","subscription_url":"https://api.github.com/repos/rgarmsen2295/platform/subscription","commits_url":"https://api.github.com/repos/rgarmsen2295/platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/rgarmsen2295/platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/rgarmsen2295/platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/rgarmsen2295/platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/rgarmsen2295/platform/contents/{+path}","compare_url":"https://api.github.com/repos/rgarmsen2295/platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rgarmsen2295/platform/merges","archive_url":"https://api.github.com/repos/rgarmsen2295/platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rgarmsen2295/platform/downloads","issues_url":"https://api.github.com/repos/rgarmsen2295/platform/issues{/number}","pulls_url":"https://api.github.com/repos/rgarmsen2295/platform/pulls{/number}","milestones_url":"https://api.github.com/repos/rgarmsen2295/platform/milestones{/number}","notifications_url":"https://api.github.com/repos/rgarmsen2295/platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rgarmsen2295/platform/labels{/name}","releases_url":"https://api.github.com/repos/rgarmsen2295/platform/releases{/id}","created_at":"2015-06-24T14:21:28Z","updated_at":"2015-07-08T16:09:44Z","pushed_at":"2015-08-18T04:31:30Z","git_url":"git://github.com/rgarmsen2295/platform.git","ssh_url":"git@github.com:rgarmsen2295/platform.git","clone_url":"https://github.com/rgarmsen2295/platform.git","svn_url":"https://github.com/rgarmsen2295/platform","homepage":"http://mattermost.org","size":6251,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mattermost:master","ref":"master","sha":"a5bff83558c737645c4a3d516047403f69080c2d","user":{"login":"mattermost","id":9828093,"avatar_url":"https://avatars.githubusercontent.com/u/9828093?v=3","gravatar_id":"","url":"https://api.github.com/users/mattermost","html_url":"https://github.com/mattermost","followers_url":"https://api.github.com/users/mattermost/followers","following_url":"https://api.github.com/users/mattermost/following{/other_user}","gists_url":"https://api.github.com/users/mattermost/gists{/gist_id}","starred_url":"https://api.github.com/users/mattermost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattermost/subscriptions","organizations_url":"https://api.github.com/users/mattermost/orgs","repos_url":"https://api.github.com/users/mattermost/repos","events_url":"https://api.github.com/users/mattermost/events{/privacy}","received_events_url":"https://api.github.com/users/mattermost/received_events","type":"Organization","site_admin":false},"repo":{"id":37448451,"name":"platform","full_name":"mattermost/platform","owner":{"login":"mattermost","id":9828093,"avatar_url":"https://avatars.githubusercontent.com/u/9828093?v=3","gravatar_id":"","url":"https://api.github.com/users/mattermost","html_url":"https://github.com/mattermost","followers_url":"https://api.github.com/users/mattermost/followers","following_url":"https://api.github.com/users/mattermost/following{/other_user}","gists_url":"https://api.github.com/users/mattermost/gists{/gist_id}","starred_url":"https://api.github.com/users/mattermost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattermost/subscriptions","organizations_url":"https://api.github.com/users/mattermost/orgs","repos_url":"https://api.github.com/users/mattermost/repos","events_url":"https://api.github.com/users/mattermost/events{/privacy}","received_events_url":"https://api.github.com/users/mattermost/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mattermost/platform","description":"Open source Slack-alternative in Golang and React","fork":false,"url":"https://api.github.com/repos/mattermost/platform","forks_url":"https://api.github.com/repos/mattermost/platform/forks","keys_url":"https://api.github.com/repos/mattermost/platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mattermost/platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mattermost/platform/teams","hooks_url":"https://api.github.com/repos/mattermost/platform/hooks","issue_events_url":"https://api.github.com/repos/mattermost/platform/issues/events{/number}","events_url":"https://api.github.com/repos/mattermost/platform/events","assignees_url":"https://api.github.com/repos/mattermost/platform/assignees{/user}","branches_url":"https://api.github.com/repos/mattermost/platform/branches{/branch}","tags_url":"https://api.github.com/repos/mattermost/platform/tags","blobs_url":"https://api.github.com/repos/mattermost/platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mattermost/platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mattermost/platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/mattermost/platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mattermost/platform/statuses/{sha}","languages_url":"https://api.github.com/repos/mattermost/platform/languages","stargazers_url":"https://api.github.com/repos/mattermost/platform/stargazers","contributors_url":"https://api.github.com/repos/mattermost/platform/contributors","subscribers_url":"https://api.github.com/repos/mattermost/platform/subscribers","subscription_url":"https://api.github.com/repos/mattermost/platform/subscription","commits_url":"https://api.github.com/repos/mattermost/platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/mattermost/platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/mattermost/platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/mattermost/platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/mattermost/platform/contents/{+path}","compare_url":"https://api.github.com/repos/mattermost/platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mattermost/platform/merges","archive_url":"https://api.github.com/repos/mattermost/platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mattermost/platform/downloads","issues_url":"https://api.github.com/repos/mattermost/platform/issues{/number}","pulls_url":"https://api.github.com/repos/mattermost/platform/pulls{/number}","milestones_url":"https://api.github.com/repos/mattermost/platform/milestones{/number}","notifications_url":"https://api.github.com/repos/mattermost/platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mattermost/platform/labels{/name}","releases_url":"https://api.github.com/repos/mattermost/platform/releases{/id}","created_at":"2015-06-15T06:50:02Z","updated_at":"2015-08-17T22:45:56Z","pushed_at":"2015-08-17T23:29:39Z","git_url":"git://github.com/mattermost/platform.git","ssh_url":"git@github.com:mattermost/platform.git","clone_url":"https://github.com/mattermost/platform.git","svn_url":"https://github.com/mattermost/platform","homepage":"http://mattermost.org","size":8559,"stargazers_count":2516,"watchers_count":2516,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":202,"mirror_url":null,"open_issues_count":21,"forks":202,"open_issues":21,"watchers":2516,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mattermost/platform/pulls/383"},"html":{"href":"https://github.com/mattermost/platform/pull/383"},"issue":{"href":"https://api.github.com/repos/mattermost/platform/issues/383"},"comments":{"href":"https://api.github.com/repos/mattermost/platform/issues/383/comments"},"review_comments":{"href":"https://api.github.com/repos/mattermost/platform/pulls/383/comments"},"review_comment":{"href":"https://api.github.com/repos/mattermost/platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mattermost/platform/pulls/383/commits"},"statuses":{"href":"https://api.github.com/repos/mattermost/platform/statuses/411d1340cb4164c7486865b71ad430d3ae4ae685"}}}}