{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/23261958","id":23261958,"diff_hunk":"@@ -14,9 +14,13 @@ class Puppet::Network::HTTP::API::V3\n     Environments.new(Puppet.lookup(:environments))\n   end)\n \n-  def self.routes\n-    Puppet::Network::HTTP::Route.path(%r{/v3}).\n+  def self.master_routes\n+    Puppet::Network::HTTP::Route.path(%r{v3}).\n         any.\n         chain(ENVIRONMENTS, INDIRECTED)\n   end\n+\n+  def self.ca_routes\n+    Puppet::Network::HTTP::Route.path(%r{v1}).any.chain(INDIRECTED)","path":"lib/puppet/network/http/api/v3.rb","position":13,"original_position":13,"commit_id":"2a9ba6968bc2ef26f4f68cb9aa25144a0e247f0c","original_commit_id":"ec1e1f892e6487c8520631409f8764ab0bd9ac34","user":{"login":"cprice404","id":1341071,"avatar_url":"https://avatars.githubusercontent.com/u/1341071?v=3","gravatar_id":"","url":"https://api.github.com/users/cprice404","html_url":"https://github.com/cprice404","followers_url":"https://api.github.com/users/cprice404/followers","following_url":"https://api.github.com/users/cprice404/following{/other_user}","gists_url":"https://api.github.com/users/cprice404/gists{/gist_id}","starred_url":"https://api.github.com/users/cprice404/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cprice404/subscriptions","organizations_url":"https://api.github.com/users/cprice404/orgs","repos_url":"https://api.github.com/users/cprice404/repos","events_url":"https://api.github.com/users/cprice404/events{/privacy}","received_events_url":"https://api.github.com/users/cprice404/received_events","type":"User","site_admin":false},"body":"I think that with the minor refactors we discussed at various points in the PR comments, we could end up in a state where IndirectedRoutes doesn't contain any references to any version strings.  If that's the case then we could put it in the `api` dir or even the parent dir of that, whichever seems like a better fit.","created_at":"2015-01-20T22:24:12Z","updated_at":"2015-01-20T22:24:12Z","html_url":"https://github.com/puppetlabs/puppet/pull/3464#discussion_r23261958","pull_request_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/3464","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/23261958"},"html":{"href":"https://github.com/puppetlabs/puppet/pull/3464#discussion_r23261958"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/3464"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppet/pulls/3464","id":27075385,"html_url":"https://github.com/puppetlabs/puppet/pull/3464","diff_url":"https://github.com/puppetlabs/puppet/pull/3464.diff","patch_url":"https://github.com/puppetlabs/puppet/pull/3464.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppet/issues/3464","number":3464,"state":"open","locked":false,"title":"(PUP-3526) Add configurable prefix for CA routes","user":{"login":"rlinehan","id":1530016,"avatar_url":"https://avatars.githubusercontent.com/u/1530016?v=3","gravatar_id":"","url":"https://api.github.com/users/rlinehan","html_url":"https://github.com/rlinehan","followers_url":"https://api.github.com/users/rlinehan/followers","following_url":"https://api.github.com/users/rlinehan/following{/other_user}","gists_url":"https://api.github.com/users/rlinehan/gists{/gist_id}","starred_url":"https://api.github.com/users/rlinehan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rlinehan/subscriptions","organizations_url":"https://api.github.com/users/rlinehan/orgs","repos_url":"https://api.github.com/users/rlinehan/repos","events_url":"https://api.github.com/users/rlinehan/events{/privacy}","received_events_url":"https://api.github.com/users/rlinehan/received_events","type":"User","site_admin":false},"body":"Restructure the CA endpoints to allow for a configurable url prefix, separate from the master url prefix. ","created_at":"2015-01-09T01:55:36Z","updated_at":"2015-01-20T22:24:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"64c35b37aa6f13aa3fee23b672639da4079faf43","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/3464/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/3464/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/{number}","comments_url":"https://api.github.com/repos/puppetlabs/puppet/issues/3464/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppet/statuses/2a9ba6968bc2ef26f4f68cb9aa25144a0e247f0c","head":{"label":"rlinehan:feature/master/PUP-3526-ca-api-prefix","ref":"feature/master/PUP-3526-ca-api-prefix","sha":"2a9ba6968bc2ef26f4f68cb9aa25144a0e247f0c","user":{"login":"rlinehan","id":1530016,"avatar_url":"https://avatars.githubusercontent.com/u/1530016?v=3","gravatar_id":"","url":"https://api.github.com/users/rlinehan","html_url":"https://github.com/rlinehan","followers_url":"https://api.github.com/users/rlinehan/followers","following_url":"https://api.github.com/users/rlinehan/following{/other_user}","gists_url":"https://api.github.com/users/rlinehan/gists{/gist_id}","starred_url":"https://api.github.com/users/rlinehan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rlinehan/subscriptions","organizations_url":"https://api.github.com/users/rlinehan/orgs","repos_url":"https://api.github.com/users/rlinehan/repos","events_url":"https://api.github.com/users/rlinehan/events{/privacy}","received_events_url":"https://api.github.com/users/rlinehan/received_events","type":"User","site_admin":false},"repo":{"id":5954894,"name":"puppet","full_name":"rlinehan/puppet","owner":{"login":"rlinehan","id":1530016,"avatar_url":"https://avatars.githubusercontent.com/u/1530016?v=3","gravatar_id":"","url":"https://api.github.com/users/rlinehan","html_url":"https://github.com/rlinehan","followers_url":"https://api.github.com/users/rlinehan/followers","following_url":"https://api.github.com/users/rlinehan/following{/other_user}","gists_url":"https://api.github.com/users/rlinehan/gists{/gist_id}","starred_url":"https://api.github.com/users/rlinehan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rlinehan/subscriptions","organizations_url":"https://api.github.com/users/rlinehan/orgs","repos_url":"https://api.github.com/users/rlinehan/repos","events_url":"https://api.github.com/users/rlinehan/events{/privacy}","received_events_url":"https://api.github.com/users/rlinehan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rlinehan/puppet","description":"Server automation framework and application","fork":true,"url":"https://api.github.com/repos/rlinehan/puppet","forks_url":"https://api.github.com/repos/rlinehan/puppet/forks","keys_url":"https://api.github.com/repos/rlinehan/puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rlinehan/puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rlinehan/puppet/teams","hooks_url":"https://api.github.com/repos/rlinehan/puppet/hooks","issue_events_url":"https://api.github.com/repos/rlinehan/puppet/issues/events{/number}","events_url":"https://api.github.com/repos/rlinehan/puppet/events","assignees_url":"https://api.github.com/repos/rlinehan/puppet/assignees{/user}","branches_url":"https://api.github.com/repos/rlinehan/puppet/branches{/branch}","tags_url":"https://api.github.com/repos/rlinehan/puppet/tags","blobs_url":"https://api.github.com/repos/rlinehan/puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rlinehan/puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rlinehan/puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/rlinehan/puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rlinehan/puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/rlinehan/puppet/languages","stargazers_url":"https://api.github.com/repos/rlinehan/puppet/stargazers","contributors_url":"https://api.github.com/repos/rlinehan/puppet/contributors","subscribers_url":"https://api.github.com/repos/rlinehan/puppet/subscribers","subscription_url":"https://api.github.com/repos/rlinehan/puppet/subscription","commits_url":"https://api.github.com/repos/rlinehan/puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/rlinehan/puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/rlinehan/puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/rlinehan/puppet/issues/comments/{number}","contents_url":"https://api.github.com/repos/rlinehan/puppet/contents/{+path}","compare_url":"https://api.github.com/repos/rlinehan/puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rlinehan/puppet/merges","archive_url":"https://api.github.com/repos/rlinehan/puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rlinehan/puppet/downloads","issues_url":"https://api.github.com/repos/rlinehan/puppet/issues{/number}","pulls_url":"https://api.github.com/repos/rlinehan/puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/rlinehan/puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/rlinehan/puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rlinehan/puppet/labels{/name}","releases_url":"https://api.github.com/repos/rlinehan/puppet/releases{/id}","created_at":"2012-09-25T18:56:10Z","updated_at":"2015-01-20T19:21:33Z","pushed_at":"2015-01-20T19:21:28Z","git_url":"git://github.com/rlinehan/puppet.git","ssh_url":"git@github.com:rlinehan/puppet.git","clone_url":"https://github.com/rlinehan/puppet.git","svn_url":"https://github.com/rlinehan/puppet","homepage":"http://www.puppetlabs.com/puppet/introduction/","size":44403,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"648d19fff1b229f07301644b71bc9d52ecb80323","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":910744,"name":"puppet","full_name":"puppetlabs/puppet","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/puppet","description":"Server automation framework and application","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppet","forks_url":"https://api.github.com/repos/puppetlabs/puppet/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppet/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppet/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppet/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppet/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppet/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppet/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppet/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppet/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppet/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppet/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppet/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppet/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppet/issues/comments/{number}","contents_url":"https://api.github.com/repos/puppetlabs/puppet/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppet/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppet/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppet/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppet/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppet/releases{/id}","created_at":"2010-09-14T19:26:44Z","updated_at":"2015-01-20T21:54:39Z","pushed_at":"2015-01-20T21:54:39Z","git_url":"git://github.com/puppetlabs/puppet.git","ssh_url":"git@github.com:puppetlabs/puppet.git","clone_url":"https://github.com/puppetlabs/puppet.git","svn_url":"https://github.com/puppetlabs/puppet","homepage":"http://www.puppetlabs.com/puppet/introduction/","size":105060,"stargazers_count":2908,"watchers_count":2908,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1251,"mirror_url":null,"open_issues_count":33,"forks":1251,"open_issues":33,"watchers":2908,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/3464"},"html":{"href":"https://github.com/puppetlabs/puppet/pull/3464"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppet/issues/3464"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppet/issues/3464/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/3464/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/3464/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppet/statuses/2a9ba6968bc2ef26f4f68cb9aa25144a0e247f0c"}}}}