{"action":"closed","number":1591,"pull_request":{"url":"https://api.github.com/repos/johndyer/mediaelement/pulls/1591","id":45061623,"html_url":"https://github.com/johndyer/mediaelement/pull/1591","diff_url":"https://github.com/johndyer/mediaelement/pull/1591.diff","patch_url":"https://github.com/johndyer/mediaelement/pull/1591.patch","issue_url":"https://api.github.com/repos/johndyer/mediaelement/issues/1591","number":1591,"state":"closed","locked":false,"title":"Maintain backward compatibility in secondsToTime() code method signature.","user":{"login":"bradyvercher","id":1302030,"avatar_url":"https://avatars.githubusercontent.com/u/1302030?v=3","gravatar_id":"","url":"https://api.github.com/users/bradyvercher","html_url":"https://github.com/bradyvercher","followers_url":"https://api.github.com/users/bradyvercher/followers","following_url":"https://api.github.com/users/bradyvercher/following{/other_user}","gists_url":"https://api.github.com/users/bradyvercher/gists{/gist_id}","starred_url":"https://api.github.com/users/bradyvercher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bradyvercher/subscriptions","organizations_url":"https://api.github.com/users/bradyvercher/orgs","repos_url":"https://api.github.com/users/bradyvercher/repos","events_url":"https://api.github.com/users/bradyvercher/events{/privacy}","received_events_url":"https://api.github.com/users/bradyvercher/received_events","type":"User","site_admin":false},"body":"The method signature for mejs.Utility.secondsToTimeCode() changed in v2.18 to\r\nallow for greater control over time formats, but the change breaks backward\r\ncompatibility and throws errors for scripts expecting the old signature.\r\n\r\nThis change detects when the method is being called with the original parameters\r\nand converts them to the new options object.","created_at":"2015-09-15T15:09:28Z","updated_at":"2015-09-16T22:47:19Z","closed_at":"2015-09-16T22:47:19Z","merged_at":"2015-09-16T22:47:19Z","merge_commit_sha":"7c599f2757009a6dc8006ab2b54485d08b674189","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/johndyer/mediaelement/pulls/1591/commits","review_comments_url":"https://api.github.com/repos/johndyer/mediaelement/pulls/1591/comments","review_comment_url":"https://api.github.com/repos/johndyer/mediaelement/pulls/comments{/number}","comments_url":"https://api.github.com/repos/johndyer/mediaelement/issues/1591/comments","statuses_url":"https://api.github.com/repos/johndyer/mediaelement/statuses/ccba8d0b6ad1661026e43879876126223c88c5e2","head":{"label":"bradyvercher:fix-utility-bc","ref":"fix-utility-bc","sha":"ccba8d0b6ad1661026e43879876126223c88c5e2","user":{"login":"bradyvercher","id":1302030,"avatar_url":"https://avatars.githubusercontent.com/u/1302030?v=3","gravatar_id":"","url":"https://api.github.com/users/bradyvercher","html_url":"https://github.com/bradyvercher","followers_url":"https://api.github.com/users/bradyvercher/followers","following_url":"https://api.github.com/users/bradyvercher/following{/other_user}","gists_url":"https://api.github.com/users/bradyvercher/gists{/gist_id}","starred_url":"https://api.github.com/users/bradyvercher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bradyvercher/subscriptions","organizations_url":"https://api.github.com/users/bradyvercher/orgs","repos_url":"https://api.github.com/users/bradyvercher/repos","events_url":"https://api.github.com/users/bradyvercher/events{/privacy}","received_events_url":"https://api.github.com/users/bradyvercher/received_events","type":"User","site_admin":false},"repo":{"id":27523338,"name":"mediaelement","full_name":"bradyvercher/mediaelement","owner":{"login":"bradyvercher","id":1302030,"avatar_url":"https://avatars.githubusercontent.com/u/1302030?v=3","gravatar_id":"","url":"https://api.github.com/users/bradyvercher","html_url":"https://github.com/bradyvercher","followers_url":"https://api.github.com/users/bradyvercher/followers","following_url":"https://api.github.com/users/bradyvercher/following{/other_user}","gists_url":"https://api.github.com/users/bradyvercher/gists{/gist_id}","starred_url":"https://api.github.com/users/bradyvercher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bradyvercher/subscriptions","organizations_url":"https://api.github.com/users/bradyvercher/orgs","repos_url":"https://api.github.com/users/bradyvercher/repos","events_url":"https://api.github.com/users/bradyvercher/events{/privacy}","received_events_url":"https://api.github.com/users/bradyvercher/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bradyvercher/mediaelement","description":"HTML5 <audio> or <video> player with Flash and Silverlight shims that mimics the HTML5 MediaElement API, enabling a consistent UI in all browsers.","fork":true,"url":"https://api.github.com/repos/bradyvercher/mediaelement","forks_url":"https://api.github.com/repos/bradyvercher/mediaelement/forks","keys_url":"https://api.github.com/repos/bradyvercher/mediaelement/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bradyvercher/mediaelement/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bradyvercher/mediaelement/teams","hooks_url":"https://api.github.com/repos/bradyvercher/mediaelement/hooks","issue_events_url":"https://api.github.com/repos/bradyvercher/mediaelement/issues/events{/number}","events_url":"https://api.github.com/repos/bradyvercher/mediaelement/events","assignees_url":"https://api.github.com/repos/bradyvercher/mediaelement/assignees{/user}","branches_url":"https://api.github.com/repos/bradyvercher/mediaelement/branches{/branch}","tags_url":"https://api.github.com/repos/bradyvercher/mediaelement/tags","blobs_url":"https://api.github.com/repos/bradyvercher/mediaelement/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bradyvercher/mediaelement/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bradyvercher/mediaelement/git/refs{/sha}","trees_url":"https://api.github.com/repos/bradyvercher/mediaelement/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bradyvercher/mediaelement/statuses/{sha}","languages_url":"https://api.github.com/repos/bradyvercher/mediaelement/languages","stargazers_url":"https://api.github.com/repos/bradyvercher/mediaelement/stargazers","contributors_url":"https://api.github.com/repos/bradyvercher/mediaelement/contributors","subscribers_url":"https://api.github.com/repos/bradyvercher/mediaelement/subscribers","subscription_url":"https://api.github.com/repos/bradyvercher/mediaelement/subscription","commits_url":"https://api.github.com/repos/bradyvercher/mediaelement/commits{/sha}","git_commits_url":"https://api.github.com/repos/bradyvercher/mediaelement/git/commits{/sha}","comments_url":"https://api.github.com/repos/bradyvercher/mediaelement/comments{/number}","issue_comment_url":"https://api.github.com/repos/bradyvercher/mediaelement/issues/comments{/number}","contents_url":"https://api.github.com/repos/bradyvercher/mediaelement/contents/{+path}","compare_url":"https://api.github.com/repos/bradyvercher/mediaelement/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bradyvercher/mediaelement/merges","archive_url":"https://api.github.com/repos/bradyvercher/mediaelement/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bradyvercher/mediaelement/downloads","issues_url":"https://api.github.com/repos/bradyvercher/mediaelement/issues{/number}","pulls_url":"https://api.github.com/repos/bradyvercher/mediaelement/pulls{/number}","milestones_url":"https://api.github.com/repos/bradyvercher/mediaelement/milestones{/number}","notifications_url":"https://api.github.com/repos/bradyvercher/mediaelement/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bradyvercher/mediaelement/labels{/name}","releases_url":"https://api.github.com/repos/bradyvercher/mediaelement/releases{/id}","created_at":"2014-12-04T04:41:05Z","updated_at":"2014-12-04T04:41:08Z","pushed_at":"2015-09-15T15:06:49Z","git_url":"git://github.com/bradyvercher/mediaelement.git","ssh_url":"git@github.com:bradyvercher/mediaelement.git","clone_url":"https://github.com/bradyvercher/mediaelement.git","svn_url":"https://github.com/bradyvercher/mediaelement","homepage":"http://mediaelementjs.com/","size":184725,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"johndyer:master","ref":"master","sha":"64dcb191894f4caeb76d5743ceb93c495d60cd37","user":{"login":"johndyer","id":214227,"avatar_url":"https://avatars.githubusercontent.com/u/214227?v=3","gravatar_id":"","url":"https://api.github.com/users/johndyer","html_url":"https://github.com/johndyer","followers_url":"https://api.github.com/users/johndyer/followers","following_url":"https://api.github.com/users/johndyer/following{/other_user}","gists_url":"https://api.github.com/users/johndyer/gists{/gist_id}","starred_url":"https://api.github.com/users/johndyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johndyer/subscriptions","organizations_url":"https://api.github.com/users/johndyer/orgs","repos_url":"https://api.github.com/users/johndyer/repos","events_url":"https://api.github.com/users/johndyer/events{/privacy}","received_events_url":"https://api.github.com/users/johndyer/received_events","type":"User","site_admin":false},"repo":{"id":802006,"name":"mediaelement","full_name":"johndyer/mediaelement","owner":{"login":"johndyer","id":214227,"avatar_url":"https://avatars.githubusercontent.com/u/214227?v=3","gravatar_id":"","url":"https://api.github.com/users/johndyer","html_url":"https://github.com/johndyer","followers_url":"https://api.github.com/users/johndyer/followers","following_url":"https://api.github.com/users/johndyer/following{/other_user}","gists_url":"https://api.github.com/users/johndyer/gists{/gist_id}","starred_url":"https://api.github.com/users/johndyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johndyer/subscriptions","organizations_url":"https://api.github.com/users/johndyer/orgs","repos_url":"https://api.github.com/users/johndyer/repos","events_url":"https://api.github.com/users/johndyer/events{/privacy}","received_events_url":"https://api.github.com/users/johndyer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/johndyer/mediaelement","description":"HTML5 <audio> or <video> player with Flash and Silverlight shims that mimics the HTML5 MediaElement API, enabling a consistent UI in all browsers.","fork":false,"url":"https://api.github.com/repos/johndyer/mediaelement","forks_url":"https://api.github.com/repos/johndyer/mediaelement/forks","keys_url":"https://api.github.com/repos/johndyer/mediaelement/keys{/key_id}","collaborators_url":"https://api.github.com/repos/johndyer/mediaelement/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/johndyer/mediaelement/teams","hooks_url":"https://api.github.com/repos/johndyer/mediaelement/hooks","issue_events_url":"https://api.github.com/repos/johndyer/mediaelement/issues/events{/number}","events_url":"https://api.github.com/repos/johndyer/mediaelement/events","assignees_url":"https://api.github.com/repos/johndyer/mediaelement/assignees{/user}","branches_url":"https://api.github.com/repos/johndyer/mediaelement/branches{/branch}","tags_url":"https://api.github.com/repos/johndyer/mediaelement/tags","blobs_url":"https://api.github.com/repos/johndyer/mediaelement/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/johndyer/mediaelement/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/johndyer/mediaelement/git/refs{/sha}","trees_url":"https://api.github.com/repos/johndyer/mediaelement/git/trees{/sha}","statuses_url":"https://api.github.com/repos/johndyer/mediaelement/statuses/{sha}","languages_url":"https://api.github.com/repos/johndyer/mediaelement/languages","stargazers_url":"https://api.github.com/repos/johndyer/mediaelement/stargazers","contributors_url":"https://api.github.com/repos/johndyer/mediaelement/contributors","subscribers_url":"https://api.github.com/repos/johndyer/mediaelement/subscribers","subscription_url":"https://api.github.com/repos/johndyer/mediaelement/subscription","commits_url":"https://api.github.com/repos/johndyer/mediaelement/commits{/sha}","git_commits_url":"https://api.github.com/repos/johndyer/mediaelement/git/commits{/sha}","comments_url":"https://api.github.com/repos/johndyer/mediaelement/comments{/number}","issue_comment_url":"https://api.github.com/repos/johndyer/mediaelement/issues/comments{/number}","contents_url":"https://api.github.com/repos/johndyer/mediaelement/contents/{+path}","compare_url":"https://api.github.com/repos/johndyer/mediaelement/compare/{base}...{head}","merges_url":"https://api.github.com/repos/johndyer/mediaelement/merges","archive_url":"https://api.github.com/repos/johndyer/mediaelement/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/johndyer/mediaelement/downloads","issues_url":"https://api.github.com/repos/johndyer/mediaelement/issues{/number}","pulls_url":"https://api.github.com/repos/johndyer/mediaelement/pulls{/number}","milestones_url":"https://api.github.com/repos/johndyer/mediaelement/milestones{/number}","notifications_url":"https://api.github.com/repos/johndyer/mediaelement/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/johndyer/mediaelement/labels{/name}","releases_url":"https://api.github.com/repos/johndyer/mediaelement/releases{/id}","created_at":"2010-07-28T02:32:56Z","updated_at":"2015-09-16T22:35:09Z","pushed_at":"2015-09-16T22:47:19Z","git_url":"git://github.com/johndyer/mediaelement.git","ssh_url":"git@github.com:johndyer/mediaelement.git","clone_url":"https://github.com/johndyer/mediaelement.git","svn_url":"https://github.com/johndyer/mediaelement","homepage":"http://mediaelementjs.com/","size":193153,"stargazers_count":3573,"watchers_count":3573,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":823,"mirror_url":null,"open_issues_count":663,"forks":823,"open_issues":663,"watchers":3573,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/johndyer/mediaelement/pulls/1591"},"html":{"href":"https://github.com/johndyer/mediaelement/pull/1591"},"issue":{"href":"https://api.github.com/repos/johndyer/mediaelement/issues/1591"},"comments":{"href":"https://api.github.com/repos/johndyer/mediaelement/issues/1591/comments"},"review_comments":{"href":"https://api.github.com/repos/johndyer/mediaelement/pulls/1591/comments"},"review_comment":{"href":"https://api.github.com/repos/johndyer/mediaelement/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/johndyer/mediaelement/pulls/1591/commits"},"statuses":{"href":"https://api.github.com/repos/johndyer/mediaelement/statuses/ccba8d0b6ad1661026e43879876126223c88c5e2"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"johndyer","id":214227,"avatar_url":"https://avatars.githubusercontent.com/u/214227?v=3","gravatar_id":"","url":"https://api.github.com/users/johndyer","html_url":"https://github.com/johndyer","followers_url":"https://api.github.com/users/johndyer/followers","following_url":"https://api.github.com/users/johndyer/following{/other_user}","gists_url":"https://api.github.com/users/johndyer/gists{/gist_id}","starred_url":"https://api.github.com/users/johndyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johndyer/subscriptions","organizations_url":"https://api.github.com/users/johndyer/orgs","repos_url":"https://api.github.com/users/johndyer/repos","events_url":"https://api.github.com/users/johndyer/events{/privacy}","received_events_url":"https://api.github.com/users/johndyer/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":12,"deletions":0,"changed_files":1}}