{"action":"created","comment":{"url":"https://api.github.com/repos/apache/storm/pulls/comments/22676169","id":22676169,"diff_hunk":"@@ -31,6 +32,7 @@\n \n (defmulti download-storm-code cluster-mode)\n (defmulti launch-worker (fn [supervisor & _] (cluster-mode (:conf supervisor))))\n+(defmulti mk-bt-tracker cluster-mode)","path":"storm-core/src/clj/backtype/storm/daemon/supervisor.clj","position":14,"original_position":14,"commit_id":"58667be951623848406f699f82cafa79a40cb496","original_commit_id":"58667be951623848406f699f82cafa79a40cb496","user":{"login":"Parth-Brahmbhatt","id":6914358,"avatar_url":"https://avatars.githubusercontent.com/u/6914358?v=3","gravatar_id":"","url":"https://api.github.com/users/Parth-Brahmbhatt","html_url":"https://github.com/Parth-Brahmbhatt","followers_url":"https://api.github.com/users/Parth-Brahmbhatt/followers","following_url":"https://api.github.com/users/Parth-Brahmbhatt/following{/other_user}","gists_url":"https://api.github.com/users/Parth-Brahmbhatt/gists{/gist_id}","starred_url":"https://api.github.com/users/Parth-Brahmbhatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Parth-Brahmbhatt/subscriptions","organizations_url":"https://api.github.com/users/Parth-Brahmbhatt/orgs","repos_url":"https://api.github.com/users/Parth-Brahmbhatt/repos","events_url":"https://api.github.com/users/Parth-Brahmbhatt/events{/privacy}","received_events_url":"https://api.github.com/users/Parth-Brahmbhatt/received_events","type":"User","site_admin":false},"body":"yes, will have to rename all things bit torrent. I will push the change soon.","created_at":"2015-01-08T19:44:56Z","updated_at":"2015-01-08T19:44:56Z","html_url":"https://github.com/apache/storm/pull/354#discussion_r22676169","pull_request_url":"https://api.github.com/repos/apache/storm/pulls/354","_links":{"self":{"href":"https://api.github.com/repos/apache/storm/pulls/comments/22676169"},"html":{"href":"https://github.com/apache/storm/pull/354#discussion_r22676169"},"pull_request":{"href":"https://api.github.com/repos/apache/storm/pulls/354"}}},"pull_request":{"url":"https://api.github.com/repos/apache/storm/pulls/354","id":26404601,"html_url":"https://github.com/apache/storm/pull/354","diff_url":"https://github.com/apache/storm/pull/354.diff","patch_url":"https://github.com/apache/storm/pull/354.patch","issue_url":"https://api.github.com/repos/apache/storm/issues/354","number":354,"state":"open","locked":false,"title":"Storm-166: Nimbus HA design doc and implementation.","user":{"login":"Parth-Brahmbhatt","id":6914358,"avatar_url":"https://avatars.githubusercontent.com/u/6914358?v=3","gravatar_id":"","url":"https://api.github.com/users/Parth-Brahmbhatt","html_url":"https://github.com/Parth-Brahmbhatt","followers_url":"https://api.github.com/users/Parth-Brahmbhatt/followers","following_url":"https://api.github.com/users/Parth-Brahmbhatt/following{/other_user}","gists_url":"https://api.github.com/users/Parth-Brahmbhatt/gists{/gist_id}","starred_url":"https://api.github.com/users/Parth-Brahmbhatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Parth-Brahmbhatt/subscriptions","organizations_url":"https://api.github.com/users/Parth-Brahmbhatt/orgs","repos_url":"https://api.github.com/users/Parth-Brahmbhatt/repos","events_url":"https://api.github.com/users/Parth-Brahmbhatt/events{/privacy}","received_events_url":"https://api.github.com/users/Parth-Brahmbhatt/received_events","type":"User","site_admin":false},"body":"I have deleted the bit torrent implementation from this pull request as the only available bit torrent library does not support tracker less torrents. In absence of tracker less torrents a single tracker becomes a single point of failure and a multi tracker implementation requires that if a tracker host fails the replacement host has same dns/network configuration. \r\n\r\nSome manual tests I executed:\r\n* start 3 nimbuses, test simple word count topology works. try storm list/activate/deactivate/rebalance/kill from ui and CLI.\r\n* set the replication factor to 2 run the first test again.\r\n* bring up a new nimbus, ensure it catches up and competes for leader lock.\r\n* with 3 nimbuses and 2 topologies, delete one topology code from each non leader nimbus. After killing master nimbus, ensure one of them eventually becomes leader.\r\n","created_at":"2014-12-19T22:51:16Z","updated_at":"2015-01-08T19:44:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"36adf47202071f3be78c192d9a298aac617a3c8d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/storm/pulls/354/commits","review_comments_url":"https://api.github.com/repos/apache/storm/pulls/354/comments","review_comment_url":"https://api.github.com/repos/apache/storm/pulls/comments/{number}","comments_url":"https://api.github.com/repos/apache/storm/issues/354/comments","statuses_url":"https://api.github.com/repos/apache/storm/statuses/58667be951623848406f699f82cafa79a40cb496","head":{"label":"Parth-Brahmbhatt:STORM-166","ref":"STORM-166","sha":"58667be951623848406f699f82cafa79a40cb496","user":{"login":"Parth-Brahmbhatt","id":6914358,"avatar_url":"https://avatars.githubusercontent.com/u/6914358?v=3","gravatar_id":"","url":"https://api.github.com/users/Parth-Brahmbhatt","html_url":"https://github.com/Parth-Brahmbhatt","followers_url":"https://api.github.com/users/Parth-Brahmbhatt/followers","following_url":"https://api.github.com/users/Parth-Brahmbhatt/following{/other_user}","gists_url":"https://api.github.com/users/Parth-Brahmbhatt/gists{/gist_id}","starred_url":"https://api.github.com/users/Parth-Brahmbhatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Parth-Brahmbhatt/subscriptions","organizations_url":"https://api.github.com/users/Parth-Brahmbhatt/orgs","repos_url":"https://api.github.com/users/Parth-Brahmbhatt/repos","events_url":"https://api.github.com/users/Parth-Brahmbhatt/events{/privacy}","received_events_url":"https://api.github.com/users/Parth-Brahmbhatt/received_events","type":"User","site_admin":false},"repo":{"id":20899571,"name":"incubator-storm","full_name":"Parth-Brahmbhatt/incubator-storm","owner":{"login":"Parth-Brahmbhatt","id":6914358,"avatar_url":"https://avatars.githubusercontent.com/u/6914358?v=3","gravatar_id":"","url":"https://api.github.com/users/Parth-Brahmbhatt","html_url":"https://github.com/Parth-Brahmbhatt","followers_url":"https://api.github.com/users/Parth-Brahmbhatt/followers","following_url":"https://api.github.com/users/Parth-Brahmbhatt/following{/other_user}","gists_url":"https://api.github.com/users/Parth-Brahmbhatt/gists{/gist_id}","starred_url":"https://api.github.com/users/Parth-Brahmbhatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Parth-Brahmbhatt/subscriptions","organizations_url":"https://api.github.com/users/Parth-Brahmbhatt/orgs","repos_url":"https://api.github.com/users/Parth-Brahmbhatt/repos","events_url":"https://api.github.com/users/Parth-Brahmbhatt/events{/privacy}","received_events_url":"https://api.github.com/users/Parth-Brahmbhatt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Parth-Brahmbhatt/incubator-storm","description":"Mirror of Apache Storm","fork":true,"url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm","forks_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/forks","keys_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/teams","hooks_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/hooks","issue_events_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/issues/events{/number}","events_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/events","assignees_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/assignees{/user}","branches_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/branches{/branch}","tags_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/tags","blobs_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/git/refs{/sha}","trees_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/statuses/{sha}","languages_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/languages","stargazers_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/stargazers","contributors_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/contributors","subscribers_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/subscribers","subscription_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/subscription","commits_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/commits{/sha}","git_commits_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/git/commits{/sha}","comments_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/comments{/number}","issue_comment_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/issues/comments/{number}","contents_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/contents/{+path}","compare_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/merges","archive_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/downloads","issues_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/issues{/number}","pulls_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/pulls{/number}","milestones_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/milestones{/number}","notifications_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/labels{/name}","releases_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/releases{/id}","created_at":"2014-06-16T20:27:09Z","updated_at":"2014-12-08T22:49:40Z","pushed_at":"2015-01-08T16:59:37Z","git_url":"git://github.com/Parth-Brahmbhatt/incubator-storm.git","ssh_url":"git@github.com:Parth-Brahmbhatt/incubator-storm.git","clone_url":"https://github.com/Parth-Brahmbhatt/incubator-storm.git","svn_url":"https://github.com/Parth-Brahmbhatt/incubator-storm","homepage":null,"size":16678,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"e71e2a3f745ee770e20dfd9c878b26f5123877f4","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":14135470,"name":"storm","full_name":"apache/storm","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/storm","description":"Mirror of Apache Storm","fork":false,"url":"https://api.github.com/repos/apache/storm","forks_url":"https://api.github.com/repos/apache/storm/forks","keys_url":"https://api.github.com/repos/apache/storm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/storm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/storm/teams","hooks_url":"https://api.github.com/repos/apache/storm/hooks","issue_events_url":"https://api.github.com/repos/apache/storm/issues/events{/number}","events_url":"https://api.github.com/repos/apache/storm/events","assignees_url":"https://api.github.com/repos/apache/storm/assignees{/user}","branches_url":"https://api.github.com/repos/apache/storm/branches{/branch}","tags_url":"https://api.github.com/repos/apache/storm/tags","blobs_url":"https://api.github.com/repos/apache/storm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/storm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/storm/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/storm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/storm/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/storm/languages","stargazers_url":"https://api.github.com/repos/apache/storm/stargazers","contributors_url":"https://api.github.com/repos/apache/storm/contributors","subscribers_url":"https://api.github.com/repos/apache/storm/subscribers","subscription_url":"https://api.github.com/repos/apache/storm/subscription","commits_url":"https://api.github.com/repos/apache/storm/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/storm/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/storm/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/storm/issues/comments/{number}","contents_url":"https://api.github.com/repos/apache/storm/contents/{+path}","compare_url":"https://api.github.com/repos/apache/storm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/storm/merges","archive_url":"https://api.github.com/repos/apache/storm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/storm/downloads","issues_url":"https://api.github.com/repos/apache/storm/issues{/number}","pulls_url":"https://api.github.com/repos/apache/storm/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/storm/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/storm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/storm/labels{/name}","releases_url":"https://api.github.com/repos/apache/storm/releases{/id}","created_at":"2013-11-05T08:00:14Z","updated_at":"2015-01-08T17:35:40Z","pushed_at":"2015-01-06T22:44:21Z","git_url":"git://github.com/apache/storm.git","ssh_url":"git@github.com:apache/storm.git","clone_url":"https://github.com/apache/storm.git","svn_url":"https://github.com/apache/storm","homepage":null,"size":767495,"stargazers_count":1387,"watchers_count":1387,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":871,"mirror_url":"git://git.apache.org/incubator-storm.git","open_issues_count":53,"forks":871,"open_issues":53,"watchers":1387,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/storm/pulls/354"},"html":{"href":"https://github.com/apache/storm/pull/354"},"issue":{"href":"https://api.github.com/repos/apache/storm/issues/354"},"comments":{"href":"https://api.github.com/repos/apache/storm/issues/354/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/storm/pulls/354/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/storm/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/apache/storm/pulls/354/commits"},"statuses":{"href":"https://api.github.com/repos/apache/storm/statuses/58667be951623848406f699f82cafa79a40cb496"}}}}