{"action":"opened","number":123,"pull_request":{"url":"https://api.github.com/repos/twisted/txmongo/pulls/123","id":37296365,"html_url":"https://github.com/twisted/txmongo/pull/123","diff_url":"https://github.com/twisted/txmongo/pull/123.diff","patch_url":"https://github.com/twisted/txmongo/pull/123.patch","issue_url":"https://api.github.com/repos/twisted/txmongo/issues/123","number":123,"state":"open","locked":false,"title":"Remove dbref","user":{"login":"IlyaSkriblovsky","id":909638,"avatar_url":"https://avatars.githubusercontent.com/u/909638?v=3","gravatar_id":"","url":"https://api.github.com/users/IlyaSkriblovsky","html_url":"https://github.com/IlyaSkriblovsky","followers_url":"https://api.github.com/users/IlyaSkriblovsky/followers","following_url":"https://api.github.com/users/IlyaSkriblovsky/following{/other_user}","gists_url":"https://api.github.com/users/IlyaSkriblovsky/gists{/gist_id}","starred_url":"https://api.github.com/users/IlyaSkriblovsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IlyaSkriblovsky/subscriptions","organizations_url":"https://api.github.com/users/IlyaSkriblovsky/orgs","repos_url":"https://api.github.com/users/IlyaSkriblovsky/repos","events_url":"https://api.github.com/users/IlyaSkriblovsky/events{/privacy}","received_events_url":"https://api.github.com/users/IlyaSkriblovsky/received_events","type":"User","site_admin":false},"body":"Is there any reason for TxMongo to contain it's own `DBRef` implementation?\r\n\r\nIt was probably copy-pasted from older version of PyMongo. I suggest to remove it and use PyMongo's `bson.dbref.DBRef` instead.\r\n\r\nBut the is a couple of incompatibilities here:\r\n- TxMongo's `DBRef` can accept `Collection` instance as its first argument. PyMongo's `DBRef` only accept strings;\r\n- TxMongo's `DBRef` declared `__cmp__` for some mysterious reason. PyMongo's `DBRef` cannot be meaningfully compared.\r\n\r\nI think both these issues are trivial enough to be neglected in favor of more code sharing with PyMongo.\r\n\r\nWhat do you think?\r\n\r\np.s. coverage decrease is expected :)","created_at":"2015-06-09T20:32:12Z","updated_at":"2015-06-09T20:32:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/twisted/txmongo/pulls/123/commits","review_comments_url":"https://api.github.com/repos/twisted/txmongo/pulls/123/comments","review_comment_url":"https://api.github.com/repos/twisted/txmongo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/twisted/txmongo/issues/123/comments","statuses_url":"https://api.github.com/repos/twisted/txmongo/statuses/56157ba0e523e4d2fa7bb6bb20c1fb55fc2e448b","head":{"label":"IlyaSkriblovsky:remove-dbref","ref":"remove-dbref","sha":"56157ba0e523e4d2fa7bb6bb20c1fb55fc2e448b","user":{"login":"IlyaSkriblovsky","id":909638,"avatar_url":"https://avatars.githubusercontent.com/u/909638?v=3","gravatar_id":"","url":"https://api.github.com/users/IlyaSkriblovsky","html_url":"https://github.com/IlyaSkriblovsky","followers_url":"https://api.github.com/users/IlyaSkriblovsky/followers","following_url":"https://api.github.com/users/IlyaSkriblovsky/following{/other_user}","gists_url":"https://api.github.com/users/IlyaSkriblovsky/gists{/gist_id}","starred_url":"https://api.github.com/users/IlyaSkriblovsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IlyaSkriblovsky/subscriptions","organizations_url":"https://api.github.com/users/IlyaSkriblovsky/orgs","repos_url":"https://api.github.com/users/IlyaSkriblovsky/repos","events_url":"https://api.github.com/users/IlyaSkriblovsky/events{/privacy}","received_events_url":"https://api.github.com/users/IlyaSkriblovsky/received_events","type":"User","site_admin":false},"repo":{"id":31769022,"name":"txmongo","full_name":"IlyaSkriblovsky/txmongo","owner":{"login":"IlyaSkriblovsky","id":909638,"avatar_url":"https://avatars.githubusercontent.com/u/909638?v=3","gravatar_id":"","url":"https://api.github.com/users/IlyaSkriblovsky","html_url":"https://github.com/IlyaSkriblovsky","followers_url":"https://api.github.com/users/IlyaSkriblovsky/followers","following_url":"https://api.github.com/users/IlyaSkriblovsky/following{/other_user}","gists_url":"https://api.github.com/users/IlyaSkriblovsky/gists{/gist_id}","starred_url":"https://api.github.com/users/IlyaSkriblovsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IlyaSkriblovsky/subscriptions","organizations_url":"https://api.github.com/users/IlyaSkriblovsky/orgs","repos_url":"https://api.github.com/users/IlyaSkriblovsky/repos","events_url":"https://api.github.com/users/IlyaSkriblovsky/events{/privacy}","received_events_url":"https://api.github.com/users/IlyaSkriblovsky/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/IlyaSkriblovsky/txmongo","description":"asynchronous python driver for mongo","fork":true,"url":"https://api.github.com/repos/IlyaSkriblovsky/txmongo","forks_url":"https://api.github.com/repos/IlyaSkriblovsky/txmongo/forks","keys_url":"https://api.github.com/repos/IlyaSkriblovsky/txmongo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/IlyaSkriblovsky/txmongo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/IlyaSkriblovsky/txmongo/teams","hooks_url":"https://api.github.com/repos/IlyaSkriblovsky/txmongo/hooks","issue_events_url":"https://api.github.com/repos/IlyaSkriblovsky/txmongo/issues/events{/number}","events_url":"https://api.github.com/repos/IlyaSkriblovsky/txmongo/events","assignees_url":"https://api.github.com/repos/IlyaSkriblovsky/txmongo/assignees{/user}","branches_url":"https://api.github.com/repos/IlyaSkriblovsky/txmongo/branches{/branch}","tags_url":"https://api.github.com/repos/IlyaSkriblovsky/txmongo/tags","blobs_url":"https://api.github.com/repos/IlyaSkriblovsky/txmongo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/IlyaSkriblovsky/txmongo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/IlyaSkriblovsky/txmongo/git/refs{/sha}","trees_url":"https://api.github.com/repos/IlyaSkriblovsky/txmongo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/IlyaSkriblovsky/txmongo/statuses/{sha}","languages_url":"https://api.github.com/repos/IlyaSkriblovsky/txmongo/languages","stargazers_url":"https://api.github.com/repos/IlyaSkriblovsky/txmongo/stargazers","contributors_url":"https://api.github.com/repos/IlyaSkriblovsky/txmongo/contributors","subscribers_url":"https://api.github.com/repos/IlyaSkriblovsky/txmongo/subscribers","subscription_url":"https://api.github.com/repos/IlyaSkriblovsky/txmongo/subscription","commits_url":"https://api.github.com/repos/IlyaSkriblovsky/txmongo/commits{/sha}","git_commits_url":"https://api.github.com/repos/IlyaSkriblovsky/txmongo/git/commits{/sha}","comments_url":"https://api.github.com/repos/IlyaSkriblovsky/txmongo/comments{/number}","issue_comment_url":"https://api.github.com/repos/IlyaSkriblovsky/txmongo/issues/comments{/number}","contents_url":"https://api.github.com/repos/IlyaSkriblovsky/txmongo/contents/{+path}","compare_url":"https://api.github.com/repos/IlyaSkriblovsky/txmongo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/IlyaSkriblovsky/txmongo/merges","archive_url":"https://api.github.com/repos/IlyaSkriblovsky/txmongo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/IlyaSkriblovsky/txmongo/downloads","issues_url":"https://api.github.com/repos/IlyaSkriblovsky/txmongo/issues{/number}","pulls_url":"https://api.github.com/repos/IlyaSkriblovsky/txmongo/pulls{/number}","milestones_url":"https://api.github.com/repos/IlyaSkriblovsky/txmongo/milestones{/number}","notifications_url":"https://api.github.com/repos/IlyaSkriblovsky/txmongo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/IlyaSkriblovsky/txmongo/labels{/name}","releases_url":"https://api.github.com/repos/IlyaSkriblovsky/txmongo/releases{/id}","created_at":"2015-03-06T12:49:23Z","updated_at":"2015-04-27T13:04:41Z","pushed_at":"2015-06-09T20:24:11Z","git_url":"git://github.com/IlyaSkriblovsky/txmongo.git","ssh_url":"git@github.com:IlyaSkriblovsky/txmongo.git","clone_url":"https://github.com/IlyaSkriblovsky/txmongo.git","svn_url":"https://github.com/IlyaSkriblovsky/txmongo","homepage":"","size":894,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"twisted:master","ref":"master","sha":"0c1bd84a0db577d40bdf7aff9178276423d68870","user":{"login":"twisted","id":716546,"avatar_url":"https://avatars.githubusercontent.com/u/716546?v=3","gravatar_id":"","url":"https://api.github.com/users/twisted","html_url":"https://github.com/twisted","followers_url":"https://api.github.com/users/twisted/followers","following_url":"https://api.github.com/users/twisted/following{/other_user}","gists_url":"https://api.github.com/users/twisted/gists{/gist_id}","starred_url":"https://api.github.com/users/twisted/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twisted/subscriptions","organizations_url":"https://api.github.com/users/twisted/orgs","repos_url":"https://api.github.com/users/twisted/repos","events_url":"https://api.github.com/users/twisted/events{/privacy}","received_events_url":"https://api.github.com/users/twisted/received_events","type":"Organization","site_admin":false},"repo":{"id":318058,"name":"txmongo","full_name":"twisted/txmongo","owner":{"login":"twisted","id":716546,"avatar_url":"https://avatars.githubusercontent.com/u/716546?v=3","gravatar_id":"","url":"https://api.github.com/users/twisted","html_url":"https://github.com/twisted","followers_url":"https://api.github.com/users/twisted/followers","following_url":"https://api.github.com/users/twisted/following{/other_user}","gists_url":"https://api.github.com/users/twisted/gists{/gist_id}","starred_url":"https://api.github.com/users/twisted/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twisted/subscriptions","organizations_url":"https://api.github.com/users/twisted/orgs","repos_url":"https://api.github.com/users/twisted/repos","events_url":"https://api.github.com/users/twisted/events{/privacy}","received_events_url":"https://api.github.com/users/twisted/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/twisted/txmongo","description":"asynchronous python driver for mongo","fork":false,"url":"https://api.github.com/repos/twisted/txmongo","forks_url":"https://api.github.com/repos/twisted/txmongo/forks","keys_url":"https://api.github.com/repos/twisted/txmongo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twisted/txmongo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twisted/txmongo/teams","hooks_url":"https://api.github.com/repos/twisted/txmongo/hooks","issue_events_url":"https://api.github.com/repos/twisted/txmongo/issues/events{/number}","events_url":"https://api.github.com/repos/twisted/txmongo/events","assignees_url":"https://api.github.com/repos/twisted/txmongo/assignees{/user}","branches_url":"https://api.github.com/repos/twisted/txmongo/branches{/branch}","tags_url":"https://api.github.com/repos/twisted/txmongo/tags","blobs_url":"https://api.github.com/repos/twisted/txmongo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twisted/txmongo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twisted/txmongo/git/refs{/sha}","trees_url":"https://api.github.com/repos/twisted/txmongo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twisted/txmongo/statuses/{sha}","languages_url":"https://api.github.com/repos/twisted/txmongo/languages","stargazers_url":"https://api.github.com/repos/twisted/txmongo/stargazers","contributors_url":"https://api.github.com/repos/twisted/txmongo/contributors","subscribers_url":"https://api.github.com/repos/twisted/txmongo/subscribers","subscription_url":"https://api.github.com/repos/twisted/txmongo/subscription","commits_url":"https://api.github.com/repos/twisted/txmongo/commits{/sha}","git_commits_url":"https://api.github.com/repos/twisted/txmongo/git/commits{/sha}","comments_url":"https://api.github.com/repos/twisted/txmongo/comments{/number}","issue_comment_url":"https://api.github.com/repos/twisted/txmongo/issues/comments{/number}","contents_url":"https://api.github.com/repos/twisted/txmongo/contents/{+path}","compare_url":"https://api.github.com/repos/twisted/txmongo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twisted/txmongo/merges","archive_url":"https://api.github.com/repos/twisted/txmongo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twisted/txmongo/downloads","issues_url":"https://api.github.com/repos/twisted/txmongo/issues{/number}","pulls_url":"https://api.github.com/repos/twisted/txmongo/pulls{/number}","milestones_url":"https://api.github.com/repos/twisted/txmongo/milestones{/number}","notifications_url":"https://api.github.com/repos/twisted/txmongo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twisted/txmongo/labels{/name}","releases_url":"https://api.github.com/repos/twisted/txmongo/releases{/id}","created_at":"2009-09-26T06:00:05Z","updated_at":"2015-06-07T18:19:24Z","pushed_at":"2015-06-09T20:25:11Z","git_url":"git://github.com/twisted/txmongo.git","ssh_url":"git@github.com:twisted/txmongo.git","clone_url":"https://github.com/twisted/txmongo.git","svn_url":"https://github.com/twisted/txmongo","homepage":"","size":1137,"stargazers_count":257,"watchers_count":257,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":63,"mirror_url":null,"open_issues_count":6,"forks":63,"open_issues":6,"watchers":257,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/twisted/txmongo/pulls/123"},"html":{"href":"https://github.com/twisted/txmongo/pull/123"},"issue":{"href":"https://api.github.com/repos/twisted/txmongo/issues/123"},"comments":{"href":"https://api.github.com/repos/twisted/txmongo/issues/123/comments"},"review_comments":{"href":"https://api.github.com/repos/twisted/txmongo/pulls/123/comments"},"review_comment":{"href":"https://api.github.com/repos/twisted/txmongo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/twisted/txmongo/pulls/123/commits"},"statuses":{"href":"https://api.github.com/repos/twisted/txmongo/statuses/56157ba0e523e4d2fa7bb6bb20c1fb55fc2e448b"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":0,"deletions":167,"changed_files":2}}