{"action":"created","comment":{"url":"https://api.github.com/repos/restorando/split/pulls/comments/40004595","id":40004595,"diff_hunk":"@@ -483,6 +483,111 @@ def should_finish_experiment(experiment_name, should_finish=true)\n     end\n   end\n \n+  describe 'ensure_alternative_or_exclude' do\n+    let(:alternatives) { %w[blue red] }\n+    let(:current_alternative) { ab_user['link_color'] }","path":"spec/helper_spec.rb","position":15,"original_position":15,"commit_id":"4d36c8f86ed9a89910ccb8ef77ed327e8b5de14f","original_commit_id":"4d36c8f86ed9a89910ccb8ef77ed327e8b5de14f","user":{"login":"gschammah","id":591992,"avatar_url":"https://avatars.githubusercontent.com/u/591992?v=3","gravatar_id":"","url":"https://api.github.com/users/gschammah","html_url":"https://github.com/gschammah","followers_url":"https://api.github.com/users/gschammah/followers","following_url":"https://api.github.com/users/gschammah/following{/other_user}","gists_url":"https://api.github.com/users/gschammah/gists{/gist_id}","starred_url":"https://api.github.com/users/gschammah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gschammah/subscriptions","organizations_url":"https://api.github.com/users/gschammah/orgs","repos_url":"https://api.github.com/users/gschammah/repos","events_url":"https://api.github.com/users/gschammah/events{/privacy}","received_events_url":"https://api.github.com/users/gschammah/received_events","type":"User","site_admin":false},"body":"exacto. Yo lo habia pensado como que si te toco betiana y entraste a un perfil icbc, dejamos corriendo el test. Pero si te toco arnaldo, y entraste a un perfil icbc, descontamos al usuario y lo excluimos del test. \r\n\r\nEs verdad lo que decis, quizas es tendencioso dejarlo correr en el primer caso por que hay mas descuentos. Estaria bueno que nos ayude @hernanpgarcia y @tanolonetti \r\n\r\nSi vamos a excluir a todos los que pasen por un perfil icbc, deberiamos crear un helper para unicamente excluirlos, sin contar o descontar nada","created_at":"2015-09-21T18:09:59Z","updated_at":"2015-09-21T18:09:59Z","html_url":"https://github.com/restorando/split/pull/1#discussion_r40004595","pull_request_url":"https://api.github.com/repos/restorando/split/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/restorando/split/pulls/comments/40004595"},"html":{"href":"https://github.com/restorando/split/pull/1#discussion_r40004595"},"pull_request":{"href":"https://api.github.com/repos/restorando/split/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/restorando/split/pulls/1","id":45508103,"html_url":"https://github.com/restorando/split/pull/1","diff_url":"https://github.com/restorando/split/pull/1.diff","patch_url":"https://github.com/restorando/split/pull/1.patch","issue_url":"https://api.github.com/repos/restorando/split/issues/1","number":1,"state":"open","locked":false,"title":"add hack to ensure alternative","user":{"login":"gschammah","id":591992,"avatar_url":"https://avatars.githubusercontent.com/u/591992?v=3","gravatar_id":"","url":"https://api.github.com/users/gschammah","html_url":"https://github.com/gschammah","followers_url":"https://api.github.com/users/gschammah/followers","following_url":"https://api.github.com/users/gschammah/following{/other_user}","gists_url":"https://api.github.com/users/gschammah/gists{/gist_id}","starred_url":"https://api.github.com/users/gschammah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gschammah/subscriptions","organizations_url":"https://api.github.com/users/gschammah/orgs","repos_url":"https://api.github.com/users/gschammah/repos","events_url":"https://api.github.com/users/gschammah/events{/privacy}","received_events_url":"https://api.github.com/users/gschammah/received_events","type":"User","site_admin":false},"body":"@ndrisso estuve probando como hacer lo qeu queriamos. \r\n\r\nesto funciona (es bastante hackish), y hay que llamar al nuevo metodo antes de llamar a `ab_test`. No se si esto rompe el `active_experiments`. \r\n\r\nlo ves?","created_at":"2015-09-21T00:48:12Z","updated_at":"2015-09-21T18:09:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"064b3dc2f652fb77e9a865c6fa72f9557e85b1f1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/restorando/split/pulls/1/commits","review_comments_url":"https://api.github.com/repos/restorando/split/pulls/1/comments","review_comment_url":"https://api.github.com/repos/restorando/split/pulls/comments{/number}","comments_url":"https://api.github.com/repos/restorando/split/issues/1/comments","statuses_url":"https://api.github.com/repos/restorando/split/statuses/4d36c8f86ed9a89910ccb8ef77ed327e8b5de14f","head":{"label":"restorando:feature/ensure_alternative","ref":"feature/ensure_alternative","sha":"4d36c8f86ed9a89910ccb8ef77ed327e8b5de14f","user":{"login":"restorando","id":709444,"avatar_url":"https://avatars.githubusercontent.com/u/709444?v=3","gravatar_id":"","url":"https://api.github.com/users/restorando","html_url":"https://github.com/restorando","followers_url":"https://api.github.com/users/restorando/followers","following_url":"https://api.github.com/users/restorando/following{/other_user}","gists_url":"https://api.github.com/users/restorando/gists{/gist_id}","starred_url":"https://api.github.com/users/restorando/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/restorando/subscriptions","organizations_url":"https://api.github.com/users/restorando/orgs","repos_url":"https://api.github.com/users/restorando/repos","events_url":"https://api.github.com/users/restorando/events{/privacy}","received_events_url":"https://api.github.com/users/restorando/received_events","type":"Organization","site_admin":false},"repo":{"id":42058152,"name":"split","full_name":"restorando/split","owner":{"login":"restorando","id":709444,"avatar_url":"https://avatars.githubusercontent.com/u/709444?v=3","gravatar_id":"","url":"https://api.github.com/users/restorando","html_url":"https://github.com/restorando","followers_url":"https://api.github.com/users/restorando/followers","following_url":"https://api.github.com/users/restorando/following{/other_user}","gists_url":"https://api.github.com/users/restorando/gists{/gist_id}","starred_url":"https://api.github.com/users/restorando/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/restorando/subscriptions","organizations_url":"https://api.github.com/users/restorando/orgs","repos_url":"https://api.github.com/users/restorando/repos","events_url":"https://api.github.com/users/restorando/events{/privacy}","received_events_url":"https://api.github.com/users/restorando/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/restorando/split","description":":chart_with_upwards_trend: The Rack Based AB testing framework","fork":true,"url":"https://api.github.com/repos/restorando/split","forks_url":"https://api.github.com/repos/restorando/split/forks","keys_url":"https://api.github.com/repos/restorando/split/keys{/key_id}","collaborators_url":"https://api.github.com/repos/restorando/split/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/restorando/split/teams","hooks_url":"https://api.github.com/repos/restorando/split/hooks","issue_events_url":"https://api.github.com/repos/restorando/split/issues/events{/number}","events_url":"https://api.github.com/repos/restorando/split/events","assignees_url":"https://api.github.com/repos/restorando/split/assignees{/user}","branches_url":"https://api.github.com/repos/restorando/split/branches{/branch}","tags_url":"https://api.github.com/repos/restorando/split/tags","blobs_url":"https://api.github.com/repos/restorando/split/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/restorando/split/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/restorando/split/git/refs{/sha}","trees_url":"https://api.github.com/repos/restorando/split/git/trees{/sha}","statuses_url":"https://api.github.com/repos/restorando/split/statuses/{sha}","languages_url":"https://api.github.com/repos/restorando/split/languages","stargazers_url":"https://api.github.com/repos/restorando/split/stargazers","contributors_url":"https://api.github.com/repos/restorando/split/contributors","subscribers_url":"https://api.github.com/repos/restorando/split/subscribers","subscription_url":"https://api.github.com/repos/restorando/split/subscription","commits_url":"https://api.github.com/repos/restorando/split/commits{/sha}","git_commits_url":"https://api.github.com/repos/restorando/split/git/commits{/sha}","comments_url":"https://api.github.com/repos/restorando/split/comments{/number}","issue_comment_url":"https://api.github.com/repos/restorando/split/issues/comments{/number}","contents_url":"https://api.github.com/repos/restorando/split/contents/{+path}","compare_url":"https://api.github.com/repos/restorando/split/compare/{base}...{head}","merges_url":"https://api.github.com/repos/restorando/split/merges","archive_url":"https://api.github.com/repos/restorando/split/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/restorando/split/downloads","issues_url":"https://api.github.com/repos/restorando/split/issues{/number}","pulls_url":"https://api.github.com/repos/restorando/split/pulls{/number}","milestones_url":"https://api.github.com/repos/restorando/split/milestones{/number}","notifications_url":"https://api.github.com/repos/restorando/split/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/restorando/split/labels{/name}","releases_url":"https://api.github.com/repos/restorando/split/releases{/id}","created_at":"2015-09-07T14:44:10Z","updated_at":"2015-09-07T14:44:10Z","pushed_at":"2015-09-21T00:48:13Z","git_url":"git://github.com/restorando/split.git","ssh_url":"git@github.com:restorando/split.git","clone_url":"https://github.com/restorando/split.git","svn_url":"https://github.com/restorando/split","homepage":"http://libraries.io/rubygems/split","size":893,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"restorando:master","ref":"master","sha":"789d67af10c524162822cbac7bc3136ed82eedc7","user":{"login":"restorando","id":709444,"avatar_url":"https://avatars.githubusercontent.com/u/709444?v=3","gravatar_id":"","url":"https://api.github.com/users/restorando","html_url":"https://github.com/restorando","followers_url":"https://api.github.com/users/restorando/followers","following_url":"https://api.github.com/users/restorando/following{/other_user}","gists_url":"https://api.github.com/users/restorando/gists{/gist_id}","starred_url":"https://api.github.com/users/restorando/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/restorando/subscriptions","organizations_url":"https://api.github.com/users/restorando/orgs","repos_url":"https://api.github.com/users/restorando/repos","events_url":"https://api.github.com/users/restorando/events{/privacy}","received_events_url":"https://api.github.com/users/restorando/received_events","type":"Organization","site_admin":false},"repo":{"id":42058152,"name":"split","full_name":"restorando/split","owner":{"login":"restorando","id":709444,"avatar_url":"https://avatars.githubusercontent.com/u/709444?v=3","gravatar_id":"","url":"https://api.github.com/users/restorando","html_url":"https://github.com/restorando","followers_url":"https://api.github.com/users/restorando/followers","following_url":"https://api.github.com/users/restorando/following{/other_user}","gists_url":"https://api.github.com/users/restorando/gists{/gist_id}","starred_url":"https://api.github.com/users/restorando/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/restorando/subscriptions","organizations_url":"https://api.github.com/users/restorando/orgs","repos_url":"https://api.github.com/users/restorando/repos","events_url":"https://api.github.com/users/restorando/events{/privacy}","received_events_url":"https://api.github.com/users/restorando/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/restorando/split","description":":chart_with_upwards_trend: The Rack Based AB testing framework","fork":true,"url":"https://api.github.com/repos/restorando/split","forks_url":"https://api.github.com/repos/restorando/split/forks","keys_url":"https://api.github.com/repos/restorando/split/keys{/key_id}","collaborators_url":"https://api.github.com/repos/restorando/split/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/restorando/split/teams","hooks_url":"https://api.github.com/repos/restorando/split/hooks","issue_events_url":"https://api.github.com/repos/restorando/split/issues/events{/number}","events_url":"https://api.github.com/repos/restorando/split/events","assignees_url":"https://api.github.com/repos/restorando/split/assignees{/user}","branches_url":"https://api.github.com/repos/restorando/split/branches{/branch}","tags_url":"https://api.github.com/repos/restorando/split/tags","blobs_url":"https://api.github.com/repos/restorando/split/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/restorando/split/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/restorando/split/git/refs{/sha}","trees_url":"https://api.github.com/repos/restorando/split/git/trees{/sha}","statuses_url":"https://api.github.com/repos/restorando/split/statuses/{sha}","languages_url":"https://api.github.com/repos/restorando/split/languages","stargazers_url":"https://api.github.com/repos/restorando/split/stargazers","contributors_url":"https://api.github.com/repos/restorando/split/contributors","subscribers_url":"https://api.github.com/repos/restorando/split/subscribers","subscription_url":"https://api.github.com/repos/restorando/split/subscription","commits_url":"https://api.github.com/repos/restorando/split/commits{/sha}","git_commits_url":"https://api.github.com/repos/restorando/split/git/commits{/sha}","comments_url":"https://api.github.com/repos/restorando/split/comments{/number}","issue_comment_url":"https://api.github.com/repos/restorando/split/issues/comments{/number}","contents_url":"https://api.github.com/repos/restorando/split/contents/{+path}","compare_url":"https://api.github.com/repos/restorando/split/compare/{base}...{head}","merges_url":"https://api.github.com/repos/restorando/split/merges","archive_url":"https://api.github.com/repos/restorando/split/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/restorando/split/downloads","issues_url":"https://api.github.com/repos/restorando/split/issues{/number}","pulls_url":"https://api.github.com/repos/restorando/split/pulls{/number}","milestones_url":"https://api.github.com/repos/restorando/split/milestones{/number}","notifications_url":"https://api.github.com/repos/restorando/split/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/restorando/split/labels{/name}","releases_url":"https://api.github.com/repos/restorando/split/releases{/id}","created_at":"2015-09-07T14:44:10Z","updated_at":"2015-09-07T14:44:10Z","pushed_at":"2015-09-21T00:48:13Z","git_url":"git://github.com/restorando/split.git","ssh_url":"git@github.com:restorando/split.git","clone_url":"https://github.com/restorando/split.git","svn_url":"https://github.com/restorando/split","homepage":"http://libraries.io/rubygems/split","size":893,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/restorando/split/pulls/1"},"html":{"href":"https://github.com/restorando/split/pull/1"},"issue":{"href":"https://api.github.com/repos/restorando/split/issues/1"},"comments":{"href":"https://api.github.com/repos/restorando/split/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/restorando/split/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/restorando/split/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/restorando/split/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/restorando/split/statuses/4d36c8f86ed9a89910ccb8ef77ed327e8b5de14f"}}}}