{"action":"created","issue":{"url":"https://api.github.com/repos/MongoEngine/mongoengine/issues/946","labels_url":"https://api.github.com/repos/MongoEngine/mongoengine/issues/946/labels{/name}","comments_url":"https://api.github.com/repos/MongoEngine/mongoengine/issues/946/comments","events_url":"https://api.github.com/repos/MongoEngine/mongoengine/issues/946/events","html_url":"https://github.com/MongoEngine/mongoengine/pull/946","id":67260382,"number":946,"title":"Pymongo3 fixes release candidate","user":{"login":"MRigal","id":2190327,"avatar_url":"https://avatars.githubusercontent.com/u/2190327?v=3","gravatar_id":"","url":"https://api.github.com/users/MRigal","html_url":"https://github.com/MRigal","followers_url":"https://api.github.com/users/MRigal/followers","following_url":"https://api.github.com/users/MRigal/following{/other_user}","gists_url":"https://api.github.com/users/MRigal/gists{/gist_id}","starred_url":"https://api.github.com/users/MRigal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MRigal/subscriptions","organizations_url":"https://api.github.com/users/MRigal/orgs","repos_url":"https://api.github.com/users/MRigal/repos","events_url":"https://api.github.com/users/MRigal/events{/privacy}","received_events_url":"https://api.github.com/users/MRigal/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":69,"created_at":"2015-04-09T01:55:47Z","updated_at":"2015-04-29T13:53:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/MongoEngine/mongoengine/pulls/946","html_url":"https://github.com/MongoEngine/mongoengine/pull/946","diff_url":"https://github.com/MongoEngine/mongoengine/pull/946.diff","patch_url":"https://github.com/MongoEngine/mongoengine/pull/946.patch"},"body":"Hi guys,\r\n\r\nNow everything is fixed and is fully compatible for both PyMongo 2.X and 3.X\r\n\r\nI'm awaiting some feedback for:\r\n1) ~~The way I introduced differential behaviour based on PyMongo version~~\r\n2) ~~The behaviour for save() when a document is created with a given primary key, source of 5 of remaining issues. Here particularly, I have removed the check for self._created since we used to modify this why changing/switching db on the fly. This whole behaviour has changed in PyMongo3 and IMHO doesn't make sense anymore.~~\r\n3) ~~Your opinion if the test_hint failure could point to a bug in PyMongo3~~\r\n4) ~~A hand on the other error on test_geo_indexes_recursion~~\r\n5) ~~A problem with binary field used as primary index that was always there and only discovered now by a better test that became mandatory by the use of a work-around concerning a PyMongo 3.0 bug already fixed in the upcoming 3.0.1~~\r\n\r\nCheers,\r\nMatthieu\r\n\r\n<!-- Reviewable:start -->\r\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/mongoengine/mongoengine/946)\r\n<!-- Reviewable:end -->\r\n"},"comment":{"url":"https://api.github.com/repos/MongoEngine/mongoengine/issues/comments/97432070","html_url":"https://github.com/MongoEngine/mongoengine/pull/946#issuecomment-97432070","issue_url":"https://api.github.com/repos/MongoEngine/mongoengine/issues/946","id":97432070,"user":{"login":"MRigal","id":2190327,"avatar_url":"https://avatars.githubusercontent.com/u/2190327?v=3","gravatar_id":"","url":"https://api.github.com/users/MRigal","html_url":"https://github.com/MRigal","followers_url":"https://api.github.com/users/MRigal/followers","following_url":"https://api.github.com/users/MRigal/following{/other_user}","gists_url":"https://api.github.com/users/MRigal/gists{/gist_id}","starred_url":"https://api.github.com/users/MRigal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MRigal/subscriptions","organizations_url":"https://api.github.com/users/MRigal/orgs","repos_url":"https://api.github.com/users/MRigal/repos","events_url":"https://api.github.com/users/MRigal/events{/privacy}","received_events_url":"https://api.github.com/users/MRigal/received_events","type":"User","site_admin":false},"created_at":"2015-04-29T13:53:20Z","updated_at":"2015-04-29T13:53:20Z","body":"OK, I've pushed a commit with the new warnings. I think it is then ready to merge. Should I already rebase?\r\nI think that with the Tox nice PR and the removal of Django support, it is already worth a 0.10.0 version"}}