{"action":"created","comment":{"url":"https://api.github.com/repos/django/django/pulls/comments/31870065","id":31870065,"diff_hunk":"@@ -0,0 +1,39 @@\n+from django.core.checks.templates import E001\n+from django.test import SimpleTestCase\n+from django.test.utils import override_settings\n+\n+TEMPLATES = [","path":"tests/check_framework/test_templates.py","position":5,"original_position":5,"commit_id":"b8fe71b5226513fd8691999cb01330d25ef9569d","original_commit_id":"b8fe71b5226513fd8691999cb01330d25ef9569d","user":{"login":"timgraham","id":411869,"avatar_url":"https://avatars.githubusercontent.com/u/411869?v=3","gravatar_id":"","url":"https://api.github.com/users/timgraham","html_url":"https://github.com/timgraham","followers_url":"https://api.github.com/users/timgraham/followers","following_url":"https://api.github.com/users/timgraham/following{/other_user}","gists_url":"https://api.github.com/users/timgraham/gists{/gist_id}","starred_url":"https://api.github.com/users/timgraham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timgraham/subscriptions","organizations_url":"https://api.github.com/users/timgraham/orgs","repos_url":"https://api.github.com/users/timgraham/repos","events_url":"https://api.github.com/users/timgraham/events{/privacy}","received_events_url":"https://api.github.com/users/timgraham/received_events","type":"User","site_admin":false},"body":"I'd put this inside the class above the test and give it a name specific to the test in case more checks and tests are added.","created_at":"2015-06-06T17:51:14Z","updated_at":"2015-06-06T17:51:14Z","html_url":"https://github.com/django/django/pull/4773#discussion_r31870065","pull_request_url":"https://api.github.com/repos/django/django/pulls/4773","_links":{"self":{"href":"https://api.github.com/repos/django/django/pulls/comments/31870065"},"html":{"href":"https://github.com/django/django/pull/4773#discussion_r31870065"},"pull_request":{"href":"https://api.github.com/repos/django/django/pulls/4773"}}},"pull_request":{"url":"https://api.github.com/repos/django/django/pulls/4773","id":36949880,"html_url":"https://github.com/django/django/pull/4773","diff_url":"https://github.com/django/django/pull/4773.diff","patch_url":"https://github.com/django/django/pull/4773.patch","issue_url":"https://api.github.com/repos/django/django/issues/4773","number":4773,"state":"open","locked":false,"title":"Fixed #24922 -- Added system check for templates setting","user":{"login":"sergei-maertens","id":5518550,"avatar_url":"https://avatars.githubusercontent.com/u/5518550?v=3","gravatar_id":"","url":"https://api.github.com/users/sergei-maertens","html_url":"https://github.com/sergei-maertens","followers_url":"https://api.github.com/users/sergei-maertens/followers","following_url":"https://api.github.com/users/sergei-maertens/following{/other_user}","gists_url":"https://api.github.com/users/sergei-maertens/gists{/gist_id}","starred_url":"https://api.github.com/users/sergei-maertens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergei-maertens/subscriptions","organizations_url":"https://api.github.com/users/sergei-maertens/orgs","repos_url":"https://api.github.com/users/sergei-maertens/repos","events_url":"https://api.github.com/users/sergei-maertens/events{/privacy}","received_events_url":"https://api.github.com/users/sergei-maertens/received_events","type":"User","site_admin":false},"body":"If `'loaders'` is present in the `TEMPLATES` options together with\r\n`APP_DIRS` set to `True`, the template engine raises an exception. This\r\nconflict is detected by the system check `templates.E001`","created_at":"2015-06-04T16:01:07Z","updated_at":"2015-06-06T17:51:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"75e3e67ba8af4b1c3c67738e2df7ac25ee5ef15d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/django/django/pulls/4773/commits","review_comments_url":"https://api.github.com/repos/django/django/pulls/4773/comments","review_comment_url":"https://api.github.com/repos/django/django/pulls/comments{/number}","comments_url":"https://api.github.com/repos/django/django/issues/4773/comments","statuses_url":"https://api.github.com/repos/django/django/statuses/b8fe71b5226513fd8691999cb01330d25ef9569d","head":{"label":"sergei-maertens:ticket_24922","ref":"ticket_24922","sha":"b8fe71b5226513fd8691999cb01330d25ef9569d","user":{"login":"sergei-maertens","id":5518550,"avatar_url":"https://avatars.githubusercontent.com/u/5518550?v=3","gravatar_id":"","url":"https://api.github.com/users/sergei-maertens","html_url":"https://github.com/sergei-maertens","followers_url":"https://api.github.com/users/sergei-maertens/followers","following_url":"https://api.github.com/users/sergei-maertens/following{/other_user}","gists_url":"https://api.github.com/users/sergei-maertens/gists{/gist_id}","starred_url":"https://api.github.com/users/sergei-maertens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergei-maertens/subscriptions","organizations_url":"https://api.github.com/users/sergei-maertens/orgs","repos_url":"https://api.github.com/users/sergei-maertens/repos","events_url":"https://api.github.com/users/sergei-maertens/events{/privacy}","received_events_url":"https://api.github.com/users/sergei-maertens/received_events","type":"User","site_admin":false},"repo":{"id":36856484,"name":"django","full_name":"sergei-maertens/django","owner":{"login":"sergei-maertens","id":5518550,"avatar_url":"https://avatars.githubusercontent.com/u/5518550?v=3","gravatar_id":"","url":"https://api.github.com/users/sergei-maertens","html_url":"https://github.com/sergei-maertens","followers_url":"https://api.github.com/users/sergei-maertens/followers","following_url":"https://api.github.com/users/sergei-maertens/following{/other_user}","gists_url":"https://api.github.com/users/sergei-maertens/gists{/gist_id}","starred_url":"https://api.github.com/users/sergei-maertens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergei-maertens/subscriptions","organizations_url":"https://api.github.com/users/sergei-maertens/orgs","repos_url":"https://api.github.com/users/sergei-maertens/repos","events_url":"https://api.github.com/users/sergei-maertens/events{/privacy}","received_events_url":"https://api.github.com/users/sergei-maertens/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sergei-maertens/django","description":"The Web framework for perfectionists with deadlines.","fork":true,"url":"https://api.github.com/repos/sergei-maertens/django","forks_url":"https://api.github.com/repos/sergei-maertens/django/forks","keys_url":"https://api.github.com/repos/sergei-maertens/django/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sergei-maertens/django/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sergei-maertens/django/teams","hooks_url":"https://api.github.com/repos/sergei-maertens/django/hooks","issue_events_url":"https://api.github.com/repos/sergei-maertens/django/issues/events{/number}","events_url":"https://api.github.com/repos/sergei-maertens/django/events","assignees_url":"https://api.github.com/repos/sergei-maertens/django/assignees{/user}","branches_url":"https://api.github.com/repos/sergei-maertens/django/branches{/branch}","tags_url":"https://api.github.com/repos/sergei-maertens/django/tags","blobs_url":"https://api.github.com/repos/sergei-maertens/django/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sergei-maertens/django/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sergei-maertens/django/git/refs{/sha}","trees_url":"https://api.github.com/repos/sergei-maertens/django/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sergei-maertens/django/statuses/{sha}","languages_url":"https://api.github.com/repos/sergei-maertens/django/languages","stargazers_url":"https://api.github.com/repos/sergei-maertens/django/stargazers","contributors_url":"https://api.github.com/repos/sergei-maertens/django/contributors","subscribers_url":"https://api.github.com/repos/sergei-maertens/django/subscribers","subscription_url":"https://api.github.com/repos/sergei-maertens/django/subscription","commits_url":"https://api.github.com/repos/sergei-maertens/django/commits{/sha}","git_commits_url":"https://api.github.com/repos/sergei-maertens/django/git/commits{/sha}","comments_url":"https://api.github.com/repos/sergei-maertens/django/comments{/number}","issue_comment_url":"https://api.github.com/repos/sergei-maertens/django/issues/comments{/number}","contents_url":"https://api.github.com/repos/sergei-maertens/django/contents/{+path}","compare_url":"https://api.github.com/repos/sergei-maertens/django/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sergei-maertens/django/merges","archive_url":"https://api.github.com/repos/sergei-maertens/django/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sergei-maertens/django/downloads","issues_url":"https://api.github.com/repos/sergei-maertens/django/issues{/number}","pulls_url":"https://api.github.com/repos/sergei-maertens/django/pulls{/number}","milestones_url":"https://api.github.com/repos/sergei-maertens/django/milestones{/number}","notifications_url":"https://api.github.com/repos/sergei-maertens/django/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sergei-maertens/django/labels{/name}","releases_url":"https://api.github.com/repos/sergei-maertens/django/releases{/id}","created_at":"2015-06-04T07:58:03Z","updated_at":"2015-06-04T07:58:21Z","pushed_at":"2015-06-05T21:15:41Z","git_url":"git://github.com/sergei-maertens/django.git","ssh_url":"git@github.com:sergei-maertens/django.git","clone_url":"https://github.com/sergei-maertens/django.git","svn_url":"https://github.com/sergei-maertens/django","homepage":"https://www.djangoproject.com/","size":140275,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"django:master","ref":"master","sha":"1f28521e0ac81dcc660a5b9891f45a20306e093a","user":{"login":"django","id":27804,"avatar_url":"https://avatars.githubusercontent.com/u/27804?v=3","gravatar_id":"","url":"https://api.github.com/users/django","html_url":"https://github.com/django","followers_url":"https://api.github.com/users/django/followers","following_url":"https://api.github.com/users/django/following{/other_user}","gists_url":"https://api.github.com/users/django/gists{/gist_id}","starred_url":"https://api.github.com/users/django/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/django/subscriptions","organizations_url":"https://api.github.com/users/django/orgs","repos_url":"https://api.github.com/users/django/repos","events_url":"https://api.github.com/users/django/events{/privacy}","received_events_url":"https://api.github.com/users/django/received_events","type":"Organization","site_admin":false},"repo":{"id":4164482,"name":"django","full_name":"django/django","owner":{"login":"django","id":27804,"avatar_url":"https://avatars.githubusercontent.com/u/27804?v=3","gravatar_id":"","url":"https://api.github.com/users/django","html_url":"https://github.com/django","followers_url":"https://api.github.com/users/django/followers","following_url":"https://api.github.com/users/django/following{/other_user}","gists_url":"https://api.github.com/users/django/gists{/gist_id}","starred_url":"https://api.github.com/users/django/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/django/subscriptions","organizations_url":"https://api.github.com/users/django/orgs","repos_url":"https://api.github.com/users/django/repos","events_url":"https://api.github.com/users/django/events{/privacy}","received_events_url":"https://api.github.com/users/django/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/django/django","description":"The Web framework for perfectionists with deadlines.","fork":false,"url":"https://api.github.com/repos/django/django","forks_url":"https://api.github.com/repos/django/django/forks","keys_url":"https://api.github.com/repos/django/django/keys{/key_id}","collaborators_url":"https://api.github.com/repos/django/django/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/django/django/teams","hooks_url":"https://api.github.com/repos/django/django/hooks","issue_events_url":"https://api.github.com/repos/django/django/issues/events{/number}","events_url":"https://api.github.com/repos/django/django/events","assignees_url":"https://api.github.com/repos/django/django/assignees{/user}","branches_url":"https://api.github.com/repos/django/django/branches{/branch}","tags_url":"https://api.github.com/repos/django/django/tags","blobs_url":"https://api.github.com/repos/django/django/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/django/django/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/django/django/git/refs{/sha}","trees_url":"https://api.github.com/repos/django/django/git/trees{/sha}","statuses_url":"https://api.github.com/repos/django/django/statuses/{sha}","languages_url":"https://api.github.com/repos/django/django/languages","stargazers_url":"https://api.github.com/repos/django/django/stargazers","contributors_url":"https://api.github.com/repos/django/django/contributors","subscribers_url":"https://api.github.com/repos/django/django/subscribers","subscription_url":"https://api.github.com/repos/django/django/subscription","commits_url":"https://api.github.com/repos/django/django/commits{/sha}","git_commits_url":"https://api.github.com/repos/django/django/git/commits{/sha}","comments_url":"https://api.github.com/repos/django/django/comments{/number}","issue_comment_url":"https://api.github.com/repos/django/django/issues/comments{/number}","contents_url":"https://api.github.com/repos/django/django/contents/{+path}","compare_url":"https://api.github.com/repos/django/django/compare/{base}...{head}","merges_url":"https://api.github.com/repos/django/django/merges","archive_url":"https://api.github.com/repos/django/django/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/django/django/downloads","issues_url":"https://api.github.com/repos/django/django/issues{/number}","pulls_url":"https://api.github.com/repos/django/django/pulls{/number}","milestones_url":"https://api.github.com/repos/django/django/milestones{/number}","notifications_url":"https://api.github.com/repos/django/django/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/django/django/labels{/name}","releases_url":"https://api.github.com/repos/django/django/releases{/id}","created_at":"2012-04-28T02:47:18Z","updated_at":"2015-06-06T17:03:12Z","pushed_at":"2015-06-06T17:38:23Z","git_url":"git://github.com/django/django.git","ssh_url":"git@github.com:django/django.git","clone_url":"https://github.com/django/django.git","svn_url":"https://github.com/django/django","homepage":"https://www.djangoproject.com/","size":292595,"stargazers_count":14526,"watchers_count":14526,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5809,"mirror_url":null,"open_issues_count":92,"forks":5809,"open_issues":92,"watchers":14526,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/django/django/pulls/4773"},"html":{"href":"https://github.com/django/django/pull/4773"},"issue":{"href":"https://api.github.com/repos/django/django/issues/4773"},"comments":{"href":"https://api.github.com/repos/django/django/issues/4773/comments"},"review_comments":{"href":"https://api.github.com/repos/django/django/pulls/4773/comments"},"review_comment":{"href":"https://api.github.com/repos/django/django/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/django/django/pulls/4773/commits"},"statuses":{"href":"https://api.github.com/repos/django/django/statuses/b8fe71b5226513fd8691999cb01330d25ef9569d"}}}}