{"action":"created","comment":{"url":"https://api.github.com/repos/nouiz/Theano/pulls/comments/44659350","id":44659350,"diff_hunk":"@@ -153,10 +163,22 @@ APPLY_SPECIFIC(conv_fwd)(PyGpuArrayObject *input, PyGpuArrayObject *kerns,\n       return 1;\n     }\n \n-    if (stride[0] != 1 || stride[1] != 1 ||\n-        PyGpuArray_DIM(input, 0) > 1024 || PyGpuArray_DIM(input, 1) > 1024 ||\n-        (PyGpuArray_DIM(kerns, 0) == 1 && PyGpuArray_DIM(kerns, 1) == 1)) {\n-      algo = CUDNN_CONVOLUTION_FWD_ALGO_IMPLICIT_PRECOMP_GEMM;\n+    if (algo == CUDNN_CONVOLUTION_FWD_ALGO_FFT)\n+    {\n+      if (stride_v != 1 || stride_h != 1 ||\n+          PyGpuArray_DIM(input, 2) > 1024 || PyGpuArray_DIM(input, 3) > 1024 ||\n+          (PyGpuArray_DIM(kerns, 2) == 1 && PyGpuArray_DIM(kerns, 3) == 1))\n+      {\n+        algo = CUDNN_CONVOLUTION_FWD_ALGO_IMPLICIT_GEMM;\n+      }\n+    }\n+    else\n+    {\n+      // algo == CUDNN_CONVOLUTION_FWD_ALGO_FFT_TILING\n+      if (stride_v != 1 || stride_h != 1)\n+      {\n+        algo = CUDNN_CONVOLUTION_FWD_ALGO_IMPLICIT_GEMM;","path":"theano/sandbox/gpuarray/dnn_fwd.c","position":null,"original_position":54,"commit_id":"bb5e832b1d1a70a2b8f0c6603aa290a686a089c9","original_commit_id":"e17f1edcb7ec69d671df5cbeb554341367bc859e","user":{"login":"nouiz","id":180987,"avatar_url":"https://avatars.githubusercontent.com/u/180987?v=3","gravatar_id":"","url":"https://api.github.com/users/nouiz","html_url":"https://github.com/nouiz","followers_url":"https://api.github.com/users/nouiz/followers","following_url":"https://api.github.com/users/nouiz/following{/other_user}","gists_url":"https://api.github.com/users/nouiz/gists{/gist_id}","starred_url":"https://api.github.com/users/nouiz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nouiz/subscriptions","organizations_url":"https://api.github.com/users/nouiz/orgs","repos_url":"https://api.github.com/users/nouiz/repos","events_url":"https://api.github.com/users/nouiz/events{/privacy}","received_events_url":"https://api.github.com/users/nouiz/received_events","type":"User","site_admin":false},"body":"ok\n\nOn Tue, Nov 10, 2015 at 5:19 PM, carriepl <notifications@github.com> wrote:\n\n> In theano/sandbox/gpuarray/dnn_fwd.c\n> <https://github.com/nouiz/Theano/pull/39#discussion_r44474239>:\n>\n> > -      algo = CUDNN_CONVOLUTION_FWD_ALGO_IMPLICIT_PRECOMP_GEMM;\n> > +    if (algo == CUDNN_CONVOLUTION_FWD_ALGO_FFT)\n> > +    {\n> > +      if (stride_v != 1 || stride_h != 1 ||\n> > +          PyGpuArray_DIM(input, 2) > 1024 || PyGpuArray_DIM(input, 3) > 1024 ||\n> > +          (PyGpuArray_DIM(kerns, 2) == 1 && PyGpuArray_DIM(kerns, 3) == 1))\n> > +      {\n> > +        algo = CUDNN_CONVOLUTION_FWD_ALGO_IMPLICIT_GEMM;\n> > +      }\n> > +    }\n> > +    else\n> > +    {\n> > +      // algo == CUDNN_CONVOLUTION_FWD_ALGO_FFT_TILING\n> > +      if (stride_v != 1 || stride_h != 1)\n> > +      {\n> > +        algo = CUDNN_CONVOLUTION_FWD_ALGO_IMPLICIT_GEMM;\n>\n> I guess my \"yes, but\" would be the case where the person does something\n> like 'guess_once' or 'time_once' which gives chooses for him the FFT\n> implementation and then at some of the following executions, the shapes\n> will be similar but sometimes the shapes are such that fft is not usable.\n>\n> I am not sure someone would need to have a message in that case, the user\n> is essentially saying 'choose for me' so popping him a message saying that\n> the choice he didn't make is not valid and we'll be using something else\n> will probably be very confusing to him.\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/nouiz/Theano/pull/39/files#r44474239>.\n>\n","created_at":"2015-11-12T14:02:17Z","updated_at":"2015-11-12T14:02:17Z","html_url":"https://github.com/nouiz/Theano/pull/39#discussion_r44659350","pull_request_url":"https://api.github.com/repos/nouiz/Theano/pulls/39","_links":{"self":{"href":"https://api.github.com/repos/nouiz/Theano/pulls/comments/44659350"},"html":{"href":"https://github.com/nouiz/Theano/pull/39#discussion_r44659350"},"pull_request":{"href":"https://api.github.com/repos/nouiz/Theano/pulls/39"}}},"pull_request":{"url":"https://api.github.com/repos/nouiz/Theano/pulls/39","id":49002041,"html_url":"https://github.com/nouiz/Theano/pull/39","diff_url":"https://github.com/nouiz/Theano/pull/39.diff","patch_url":"https://github.com/nouiz/Theano/pull/39.patch","issue_url":"https://api.github.com/repos/nouiz/Theano/issues/39","number":39,"state":"open","locked":false,"title":"V4","user":{"login":"carriepl","id":832811,"avatar_url":"https://avatars.githubusercontent.com/u/832811?v=3","gravatar_id":"","url":"https://api.github.com/users/carriepl","html_url":"https://github.com/carriepl","followers_url":"https://api.github.com/users/carriepl/followers","following_url":"https://api.github.com/users/carriepl/following{/other_user}","gists_url":"https://api.github.com/users/carriepl/gists{/gist_id}","starred_url":"https://api.github.com/users/carriepl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carriepl/subscriptions","organizations_url":"https://api.github.com/users/carriepl/orgs","repos_url":"https://api.github.com/users/carriepl/repos","events_url":"https://api.github.com/users/carriepl/events{/privacy}","received_events_url":"https://api.github.com/users/carriepl/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-10-28T12:59:28Z","updated_at":"2015-11-12T14:02:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c152ebe6ce48ce1aab2c2296399c4d1957fe914c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nouiz/Theano/pulls/39/commits","review_comments_url":"https://api.github.com/repos/nouiz/Theano/pulls/39/comments","review_comment_url":"https://api.github.com/repos/nouiz/Theano/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nouiz/Theano/issues/39/comments","statuses_url":"https://api.github.com/repos/nouiz/Theano/statuses/bb5e832b1d1a70a2b8f0c6603aa290a686a089c9","head":{"label":"carriepl:v4","ref":"v4","sha":"bb5e832b1d1a70a2b8f0c6603aa290a686a089c9","user":{"login":"carriepl","id":832811,"avatar_url":"https://avatars.githubusercontent.com/u/832811?v=3","gravatar_id":"","url":"https://api.github.com/users/carriepl","html_url":"https://github.com/carriepl","followers_url":"https://api.github.com/users/carriepl/followers","following_url":"https://api.github.com/users/carriepl/following{/other_user}","gists_url":"https://api.github.com/users/carriepl/gists{/gist_id}","starred_url":"https://api.github.com/users/carriepl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carriepl/subscriptions","organizations_url":"https://api.github.com/users/carriepl/orgs","repos_url":"https://api.github.com/users/carriepl/repos","events_url":"https://api.github.com/users/carriepl/events{/privacy}","received_events_url":"https://api.github.com/users/carriepl/received_events","type":"User","site_admin":false},"repo":{"id":18150468,"name":"Theano","full_name":"carriepl/Theano","owner":{"login":"carriepl","id":832811,"avatar_url":"https://avatars.githubusercontent.com/u/832811?v=3","gravatar_id":"","url":"https://api.github.com/users/carriepl","html_url":"https://github.com/carriepl","followers_url":"https://api.github.com/users/carriepl/followers","following_url":"https://api.github.com/users/carriepl/following{/other_user}","gists_url":"https://api.github.com/users/carriepl/gists{/gist_id}","starred_url":"https://api.github.com/users/carriepl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carriepl/subscriptions","organizations_url":"https://api.github.com/users/carriepl/orgs","repos_url":"https://api.github.com/users/carriepl/repos","events_url":"https://api.github.com/users/carriepl/events{/privacy}","received_events_url":"https://api.github.com/users/carriepl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/carriepl/Theano","description":"Optimizing GPU-meta-programming code generating array oriented optimizing math compiler in Python","fork":true,"url":"https://api.github.com/repos/carriepl/Theano","forks_url":"https://api.github.com/repos/carriepl/Theano/forks","keys_url":"https://api.github.com/repos/carriepl/Theano/keys{/key_id}","collaborators_url":"https://api.github.com/repos/carriepl/Theano/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/carriepl/Theano/teams","hooks_url":"https://api.github.com/repos/carriepl/Theano/hooks","issue_events_url":"https://api.github.com/repos/carriepl/Theano/issues/events{/number}","events_url":"https://api.github.com/repos/carriepl/Theano/events","assignees_url":"https://api.github.com/repos/carriepl/Theano/assignees{/user}","branches_url":"https://api.github.com/repos/carriepl/Theano/branches{/branch}","tags_url":"https://api.github.com/repos/carriepl/Theano/tags","blobs_url":"https://api.github.com/repos/carriepl/Theano/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/carriepl/Theano/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/carriepl/Theano/git/refs{/sha}","trees_url":"https://api.github.com/repos/carriepl/Theano/git/trees{/sha}","statuses_url":"https://api.github.com/repos/carriepl/Theano/statuses/{sha}","languages_url":"https://api.github.com/repos/carriepl/Theano/languages","stargazers_url":"https://api.github.com/repos/carriepl/Theano/stargazers","contributors_url":"https://api.github.com/repos/carriepl/Theano/contributors","subscribers_url":"https://api.github.com/repos/carriepl/Theano/subscribers","subscription_url":"https://api.github.com/repos/carriepl/Theano/subscription","commits_url":"https://api.github.com/repos/carriepl/Theano/commits{/sha}","git_commits_url":"https://api.github.com/repos/carriepl/Theano/git/commits{/sha}","comments_url":"https://api.github.com/repos/carriepl/Theano/comments{/number}","issue_comment_url":"https://api.github.com/repos/carriepl/Theano/issues/comments{/number}","contents_url":"https://api.github.com/repos/carriepl/Theano/contents/{+path}","compare_url":"https://api.github.com/repos/carriepl/Theano/compare/{base}...{head}","merges_url":"https://api.github.com/repos/carriepl/Theano/merges","archive_url":"https://api.github.com/repos/carriepl/Theano/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/carriepl/Theano/downloads","issues_url":"https://api.github.com/repos/carriepl/Theano/issues{/number}","pulls_url":"https://api.github.com/repos/carriepl/Theano/pulls{/number}","milestones_url":"https://api.github.com/repos/carriepl/Theano/milestones{/number}","notifications_url":"https://api.github.com/repos/carriepl/Theano/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/carriepl/Theano/labels{/name}","releases_url":"https://api.github.com/repos/carriepl/Theano/releases{/id}","created_at":"2014-03-26T19:13:49Z","updated_at":"2014-09-10T14:19:14Z","pushed_at":"2015-11-12T13:56:07Z","git_url":"git://github.com/carriepl/Theano.git","ssh_url":"git@github.com:carriepl/Theano.git","clone_url":"https://github.com/carriepl/Theano.git","svn_url":"https://github.com/carriepl/Theano","homepage":"http://www.deeplearning.net/software/theano","size":45585,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"nouiz:master","ref":"master","sha":"c5b120c867b9caf824b87877224081b2e26465d1","user":{"login":"nouiz","id":180987,"avatar_url":"https://avatars.githubusercontent.com/u/180987?v=3","gravatar_id":"","url":"https://api.github.com/users/nouiz","html_url":"https://github.com/nouiz","followers_url":"https://api.github.com/users/nouiz/followers","following_url":"https://api.github.com/users/nouiz/following{/other_user}","gists_url":"https://api.github.com/users/nouiz/gists{/gist_id}","starred_url":"https://api.github.com/users/nouiz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nouiz/subscriptions","organizations_url":"https://api.github.com/users/nouiz/orgs","repos_url":"https://api.github.com/users/nouiz/repos","events_url":"https://api.github.com/users/nouiz/events{/privacy}","received_events_url":"https://api.github.com/users/nouiz/received_events","type":"User","site_admin":false},"repo":{"id":2255296,"name":"Theano","full_name":"nouiz/Theano","owner":{"login":"nouiz","id":180987,"avatar_url":"https://avatars.githubusercontent.com/u/180987?v=3","gravatar_id":"","url":"https://api.github.com/users/nouiz","html_url":"https://github.com/nouiz","followers_url":"https://api.github.com/users/nouiz/followers","following_url":"https://api.github.com/users/nouiz/following{/other_user}","gists_url":"https://api.github.com/users/nouiz/gists{/gist_id}","starred_url":"https://api.github.com/users/nouiz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nouiz/subscriptions","organizations_url":"https://api.github.com/users/nouiz/orgs","repos_url":"https://api.github.com/users/nouiz/repos","events_url":"https://api.github.com/users/nouiz/events{/privacy}","received_events_url":"https://api.github.com/users/nouiz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nouiz/Theano","description":"Theano is a Python library that allows you to define, optimize, and evaluate mathematical expressions involving multi-dimensional arrays efficiently. It can use GPUs and perform efficient symbolic differentiation. ","fork":true,"url":"https://api.github.com/repos/nouiz/Theano","forks_url":"https://api.github.com/repos/nouiz/Theano/forks","keys_url":"https://api.github.com/repos/nouiz/Theano/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nouiz/Theano/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nouiz/Theano/teams","hooks_url":"https://api.github.com/repos/nouiz/Theano/hooks","issue_events_url":"https://api.github.com/repos/nouiz/Theano/issues/events{/number}","events_url":"https://api.github.com/repos/nouiz/Theano/events","assignees_url":"https://api.github.com/repos/nouiz/Theano/assignees{/user}","branches_url":"https://api.github.com/repos/nouiz/Theano/branches{/branch}","tags_url":"https://api.github.com/repos/nouiz/Theano/tags","blobs_url":"https://api.github.com/repos/nouiz/Theano/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nouiz/Theano/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nouiz/Theano/git/refs{/sha}","trees_url":"https://api.github.com/repos/nouiz/Theano/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nouiz/Theano/statuses/{sha}","languages_url":"https://api.github.com/repos/nouiz/Theano/languages","stargazers_url":"https://api.github.com/repos/nouiz/Theano/stargazers","contributors_url":"https://api.github.com/repos/nouiz/Theano/contributors","subscribers_url":"https://api.github.com/repos/nouiz/Theano/subscribers","subscription_url":"https://api.github.com/repos/nouiz/Theano/subscription","commits_url":"https://api.github.com/repos/nouiz/Theano/commits{/sha}","git_commits_url":"https://api.github.com/repos/nouiz/Theano/git/commits{/sha}","comments_url":"https://api.github.com/repos/nouiz/Theano/comments{/number}","issue_comment_url":"https://api.github.com/repos/nouiz/Theano/issues/comments{/number}","contents_url":"https://api.github.com/repos/nouiz/Theano/contents/{+path}","compare_url":"https://api.github.com/repos/nouiz/Theano/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nouiz/Theano/merges","archive_url":"https://api.github.com/repos/nouiz/Theano/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nouiz/Theano/downloads","issues_url":"https://api.github.com/repos/nouiz/Theano/issues{/number}","pulls_url":"https://api.github.com/repos/nouiz/Theano/pulls{/number}","milestones_url":"https://api.github.com/repos/nouiz/Theano/milestones{/number}","notifications_url":"https://api.github.com/repos/nouiz/Theano/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nouiz/Theano/labels{/name}","releases_url":"https://api.github.com/repos/nouiz/Theano/releases{/id}","created_at":"2011-08-23T13:23:37Z","updated_at":"2015-05-09T01:09:56Z","pushed_at":"2015-11-12T13:56:08Z","git_url":"git://github.com/nouiz/Theano.git","ssh_url":"git@github.com:nouiz/Theano.git","clone_url":"https://github.com/nouiz/Theano.git","svn_url":"https://github.com/nouiz/Theano","homepage":"http://www.deeplearning.net/software/theano","size":50100,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":1,"forks":4,"open_issues":1,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nouiz/Theano/pulls/39"},"html":{"href":"https://github.com/nouiz/Theano/pull/39"},"issue":{"href":"https://api.github.com/repos/nouiz/Theano/issues/39"},"comments":{"href":"https://api.github.com/repos/nouiz/Theano/issues/39/comments"},"review_comments":{"href":"https://api.github.com/repos/nouiz/Theano/pulls/39/comments"},"review_comment":{"href":"https://api.github.com/repos/nouiz/Theano/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nouiz/Theano/pulls/39/commits"},"statuses":{"href":"https://api.github.com/repos/nouiz/Theano/statuses/bb5e832b1d1a70a2b8f0c6603aa290a686a089c9"}}}}