{"action":"closed","number":68,"pull_request":{"url":"https://api.github.com/repos/fragaria/angular-daterangepicker/pulls/68","id":36881893,"html_url":"https://github.com/fragaria/angular-daterangepicker/pull/68","diff_url":"https://github.com/fragaria/angular-daterangepicker/pull/68.diff","patch_url":"https://github.com/fragaria/angular-daterangepicker/pull/68.patch","issue_url":"https://api.github.com/repos/fragaria/angular-daterangepicker/issues/68","number":68,"state":"closed","locked":false,"title":"Attribute changes caused changes to previous instantiated daterangepicker","user":{"login":"EricByers","id":403278,"avatar_url":"https://avatars.githubusercontent.com/u/403278?v=3","gravatar_id":"","url":"https://api.github.com/users/EricByers","html_url":"https://github.com/EricByers","followers_url":"https://api.github.com/users/EricByers/followers","following_url":"https://api.github.com/users/EricByers/following{/other_user}","gists_url":"https://api.github.com/users/EricByers/gists{/gist_id}","starred_url":"https://api.github.com/users/EricByers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EricByers/subscriptions","organizations_url":"https://api.github.com/users/EricByers/orgs","repos_url":"https://api.github.com/users/EricByers/repos","events_url":"https://api.github.com/users/EricByers/events{/privacy}","received_events_url":"https://api.github.com/users/EricByers/received_events","type":"User","site_admin":false},"body":"Passing in options cause the daterangepicker to re-init itself, however due to recent changes in (#59 and #60) to allow _picker.remove() to work, caused this to break.\r\n\r\nPreviously _picker was only set in the callback (which is only called for notifications, not immediately).  The change was to move the _picker setting to the top of the init.  However when items are re-inited this causes the reference to be to the previous daterangepicker instantiation.\r\n\r\nI believe this also removes the need for PR #63 as well since the _picker will always be set (init always gets called)\r\n\r\nShould also fix issues #65 & #61","created_at":"2015-06-03T21:48:12Z","updated_at":"2015-06-07T12:21:11Z","closed_at":"2015-06-07T12:21:10Z","merged_at":"2015-06-07T12:21:10Z","merge_commit_sha":"d82fbbc1146e68a95c9bf62753ddaffb2b69f911","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/fragaria/angular-daterangepicker/pulls/68/commits","review_comments_url":"https://api.github.com/repos/fragaria/angular-daterangepicker/pulls/68/comments","review_comment_url":"https://api.github.com/repos/fragaria/angular-daterangepicker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fragaria/angular-daterangepicker/issues/68/comments","statuses_url":"https://api.github.com/repos/fragaria/angular-daterangepicker/statuses/2d948ea3a13afa1a36c21dfb08fda8c77890bbc7","head":{"label":"EricByers:master","ref":"master","sha":"2d948ea3a13afa1a36c21dfb08fda8c77890bbc7","user":{"login":"EricByers","id":403278,"avatar_url":"https://avatars.githubusercontent.com/u/403278?v=3","gravatar_id":"","url":"https://api.github.com/users/EricByers","html_url":"https://github.com/EricByers","followers_url":"https://api.github.com/users/EricByers/followers","following_url":"https://api.github.com/users/EricByers/following{/other_user}","gists_url":"https://api.github.com/users/EricByers/gists{/gist_id}","starred_url":"https://api.github.com/users/EricByers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EricByers/subscriptions","organizations_url":"https://api.github.com/users/EricByers/orgs","repos_url":"https://api.github.com/users/EricByers/repos","events_url":"https://api.github.com/users/EricByers/events{/privacy}","received_events_url":"https://api.github.com/users/EricByers/received_events","type":"User","site_admin":false},"repo":{"id":36830409,"name":"angular-daterangepicker","full_name":"EricByers/angular-daterangepicker","owner":{"login":"EricByers","id":403278,"avatar_url":"https://avatars.githubusercontent.com/u/403278?v=3","gravatar_id":"","url":"https://api.github.com/users/EricByers","html_url":"https://github.com/EricByers","followers_url":"https://api.github.com/users/EricByers/followers","following_url":"https://api.github.com/users/EricByers/following{/other_user}","gists_url":"https://api.github.com/users/EricByers/gists{/gist_id}","starred_url":"https://api.github.com/users/EricByers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EricByers/subscriptions","organizations_url":"https://api.github.com/users/EricByers/orgs","repos_url":"https://api.github.com/users/EricByers/repos","events_url":"https://api.github.com/users/EricByers/events{/privacy}","received_events_url":"https://api.github.com/users/EricByers/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/EricByers/angular-daterangepicker","description":"Angular.js wrapper for dangrossman/bootstrap-daterangepicker","fork":true,"url":"https://api.github.com/repos/EricByers/angular-daterangepicker","forks_url":"https://api.github.com/repos/EricByers/angular-daterangepicker/forks","keys_url":"https://api.github.com/repos/EricByers/angular-daterangepicker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/EricByers/angular-daterangepicker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/EricByers/angular-daterangepicker/teams","hooks_url":"https://api.github.com/repos/EricByers/angular-daterangepicker/hooks","issue_events_url":"https://api.github.com/repos/EricByers/angular-daterangepicker/issues/events{/number}","events_url":"https://api.github.com/repos/EricByers/angular-daterangepicker/events","assignees_url":"https://api.github.com/repos/EricByers/angular-daterangepicker/assignees{/user}","branches_url":"https://api.github.com/repos/EricByers/angular-daterangepicker/branches{/branch}","tags_url":"https://api.github.com/repos/EricByers/angular-daterangepicker/tags","blobs_url":"https://api.github.com/repos/EricByers/angular-daterangepicker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/EricByers/angular-daterangepicker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/EricByers/angular-daterangepicker/git/refs{/sha}","trees_url":"https://api.github.com/repos/EricByers/angular-daterangepicker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/EricByers/angular-daterangepicker/statuses/{sha}","languages_url":"https://api.github.com/repos/EricByers/angular-daterangepicker/languages","stargazers_url":"https://api.github.com/repos/EricByers/angular-daterangepicker/stargazers","contributors_url":"https://api.github.com/repos/EricByers/angular-daterangepicker/contributors","subscribers_url":"https://api.github.com/repos/EricByers/angular-daterangepicker/subscribers","subscription_url":"https://api.github.com/repos/EricByers/angular-daterangepicker/subscription","commits_url":"https://api.github.com/repos/EricByers/angular-daterangepicker/commits{/sha}","git_commits_url":"https://api.github.com/repos/EricByers/angular-daterangepicker/git/commits{/sha}","comments_url":"https://api.github.com/repos/EricByers/angular-daterangepicker/comments{/number}","issue_comment_url":"https://api.github.com/repos/EricByers/angular-daterangepicker/issues/comments{/number}","contents_url":"https://api.github.com/repos/EricByers/angular-daterangepicker/contents/{+path}","compare_url":"https://api.github.com/repos/EricByers/angular-daterangepicker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/EricByers/angular-daterangepicker/merges","archive_url":"https://api.github.com/repos/EricByers/angular-daterangepicker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/EricByers/angular-daterangepicker/downloads","issues_url":"https://api.github.com/repos/EricByers/angular-daterangepicker/issues{/number}","pulls_url":"https://api.github.com/repos/EricByers/angular-daterangepicker/pulls{/number}","milestones_url":"https://api.github.com/repos/EricByers/angular-daterangepicker/milestones{/number}","notifications_url":"https://api.github.com/repos/EricByers/angular-daterangepicker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/EricByers/angular-daterangepicker/labels{/name}","releases_url":"https://api.github.com/repos/EricByers/angular-daterangepicker/releases{/id}","created_at":"2015-06-03T21:02:40Z","updated_at":"2015-06-03T21:02:40Z","pushed_at":"2015-06-03T21:10:38Z","git_url":"git://github.com/EricByers/angular-daterangepicker.git","ssh_url":"git@github.com:EricByers/angular-daterangepicker.git","clone_url":"https://github.com/EricByers/angular-daterangepicker.git","svn_url":"https://github.com/EricByers/angular-daterangepicker","homepage":null,"size":695,"stargazers_count":0,"watchers_count":0,"language":"CoffeeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fragaria:master","ref":"master","sha":"8a407fbe9922fd7c2258c2224376704d14ab53c7","user":{"login":"fragaria","id":756758,"avatar_url":"https://avatars.githubusercontent.com/u/756758?v=3","gravatar_id":"","url":"https://api.github.com/users/fragaria","html_url":"https://github.com/fragaria","followers_url":"https://api.github.com/users/fragaria/followers","following_url":"https://api.github.com/users/fragaria/following{/other_user}","gists_url":"https://api.github.com/users/fragaria/gists{/gist_id}","starred_url":"https://api.github.com/users/fragaria/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fragaria/subscriptions","organizations_url":"https://api.github.com/users/fragaria/orgs","repos_url":"https://api.github.com/users/fragaria/repos","events_url":"https://api.github.com/users/fragaria/events{/privacy}","received_events_url":"https://api.github.com/users/fragaria/received_events","type":"Organization","site_admin":false},"repo":{"id":17179940,"name":"angular-daterangepicker","full_name":"fragaria/angular-daterangepicker","owner":{"login":"fragaria","id":756758,"avatar_url":"https://avatars.githubusercontent.com/u/756758?v=3","gravatar_id":"","url":"https://api.github.com/users/fragaria","html_url":"https://github.com/fragaria","followers_url":"https://api.github.com/users/fragaria/followers","following_url":"https://api.github.com/users/fragaria/following{/other_user}","gists_url":"https://api.github.com/users/fragaria/gists{/gist_id}","starred_url":"https://api.github.com/users/fragaria/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fragaria/subscriptions","organizations_url":"https://api.github.com/users/fragaria/orgs","repos_url":"https://api.github.com/users/fragaria/repos","events_url":"https://api.github.com/users/fragaria/events{/privacy}","received_events_url":"https://api.github.com/users/fragaria/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fragaria/angular-daterangepicker","description":"Angular.js wrapper for dangrossman/bootstrap-daterangepicker","fork":false,"url":"https://api.github.com/repos/fragaria/angular-daterangepicker","forks_url":"https://api.github.com/repos/fragaria/angular-daterangepicker/forks","keys_url":"https://api.github.com/repos/fragaria/angular-daterangepicker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fragaria/angular-daterangepicker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fragaria/angular-daterangepicker/teams","hooks_url":"https://api.github.com/repos/fragaria/angular-daterangepicker/hooks","issue_events_url":"https://api.github.com/repos/fragaria/angular-daterangepicker/issues/events{/number}","events_url":"https://api.github.com/repos/fragaria/angular-daterangepicker/events","assignees_url":"https://api.github.com/repos/fragaria/angular-daterangepicker/assignees{/user}","branches_url":"https://api.github.com/repos/fragaria/angular-daterangepicker/branches{/branch}","tags_url":"https://api.github.com/repos/fragaria/angular-daterangepicker/tags","blobs_url":"https://api.github.com/repos/fragaria/angular-daterangepicker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fragaria/angular-daterangepicker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fragaria/angular-daterangepicker/git/refs{/sha}","trees_url":"https://api.github.com/repos/fragaria/angular-daterangepicker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fragaria/angular-daterangepicker/statuses/{sha}","languages_url":"https://api.github.com/repos/fragaria/angular-daterangepicker/languages","stargazers_url":"https://api.github.com/repos/fragaria/angular-daterangepicker/stargazers","contributors_url":"https://api.github.com/repos/fragaria/angular-daterangepicker/contributors","subscribers_url":"https://api.github.com/repos/fragaria/angular-daterangepicker/subscribers","subscription_url":"https://api.github.com/repos/fragaria/angular-daterangepicker/subscription","commits_url":"https://api.github.com/repos/fragaria/angular-daterangepicker/commits{/sha}","git_commits_url":"https://api.github.com/repos/fragaria/angular-daterangepicker/git/commits{/sha}","comments_url":"https://api.github.com/repos/fragaria/angular-daterangepicker/comments{/number}","issue_comment_url":"https://api.github.com/repos/fragaria/angular-daterangepicker/issues/comments{/number}","contents_url":"https://api.github.com/repos/fragaria/angular-daterangepicker/contents/{+path}","compare_url":"https://api.github.com/repos/fragaria/angular-daterangepicker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fragaria/angular-daterangepicker/merges","archive_url":"https://api.github.com/repos/fragaria/angular-daterangepicker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fragaria/angular-daterangepicker/downloads","issues_url":"https://api.github.com/repos/fragaria/angular-daterangepicker/issues{/number}","pulls_url":"https://api.github.com/repos/fragaria/angular-daterangepicker/pulls{/number}","milestones_url":"https://api.github.com/repos/fragaria/angular-daterangepicker/milestones{/number}","notifications_url":"https://api.github.com/repos/fragaria/angular-daterangepicker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fragaria/angular-daterangepicker/labels{/name}","releases_url":"https://api.github.com/repos/fragaria/angular-daterangepicker/releases{/id}","created_at":"2014-02-25T16:34:57Z","updated_at":"2015-06-06T07:45:25Z","pushed_at":"2015-06-07T12:21:11Z","git_url":"git://github.com/fragaria/angular-daterangepicker.git","ssh_url":"git@github.com:fragaria/angular-daterangepicker.git","clone_url":"https://github.com/fragaria/angular-daterangepicker.git","svn_url":"https://github.com/fragaria/angular-daterangepicker","homepage":null,"size":695,"stargazers_count":76,"watchers_count":76,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":52,"mirror_url":null,"open_issues_count":30,"forks":52,"open_issues":30,"watchers":76,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fragaria/angular-daterangepicker/pulls/68"},"html":{"href":"https://github.com/fragaria/angular-daterangepicker/pull/68"},"issue":{"href":"https://api.github.com/repos/fragaria/angular-daterangepicker/issues/68"},"comments":{"href":"https://api.github.com/repos/fragaria/angular-daterangepicker/issues/68/comments"},"review_comments":{"href":"https://api.github.com/repos/fragaria/angular-daterangepicker/pulls/68/comments"},"review_comment":{"href":"https://api.github.com/repos/fragaria/angular-daterangepicker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fragaria/angular-daterangepicker/pulls/68/commits"},"statuses":{"href":"https://api.github.com/repos/fragaria/angular-daterangepicker/statuses/2d948ea3a13afa1a36c21dfb08fda8c77890bbc7"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"krtek","id":422139,"avatar_url":"https://avatars.githubusercontent.com/u/422139?v=3","gravatar_id":"","url":"https://api.github.com/users/krtek","html_url":"https://github.com/krtek","followers_url":"https://api.github.com/users/krtek/followers","following_url":"https://api.github.com/users/krtek/following{/other_user}","gists_url":"https://api.github.com/users/krtek/gists{/gist_id}","starred_url":"https://api.github.com/users/krtek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krtek/subscriptions","organizations_url":"https://api.github.com/users/krtek/orgs","repos_url":"https://api.github.com/users/krtek/repos","events_url":"https://api.github.com/users/krtek/events{/privacy}","received_events_url":"https://api.github.com/users/krtek/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":9,"deletions":6,"changed_files":4}}