{"action":"created","comment":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/28780854","id":28780854,"diff_hunk":"@@ -338,7 +365,11 @@ bool CEGLNativeTypeIMX::ModeToResolution(std::string mode, RESOLUTION_INFO *res)\n   res->iScreen       = 0;\n   res->bFullScreen   = true;\n   res->iSubtitles    = (int)(0.965 * res->iHeight);\n-  res->fPixelRatio   = 1.0f;\n+\n+  // recalculated PR relatively to startup desktop resolution will result in 1.0f\n+  // for all res with same AR and allows use of others without need to calibrate before\n+  // by user.\n+  res->fPixelRatio   = (float)m_init.fPixelRatio / (res->iScreenWidth/res->iScreenHeight);","path":"xbmc/windowing/egl/EGLNativeTypeIMX.cpp","position":72,"original_position":72,"commit_id":"0cecf8b02697bbbbb81468f2274c763d241a8011","original_commit_id":"0cecf8b02697bbbbb81468f2274c763d241a8011","user":{"login":"mk01","id":3136693,"avatar_url":"https://avatars.githubusercontent.com/u/3136693?v=3","gravatar_id":"","url":"https://api.github.com/users/mk01","html_url":"https://github.com/mk01","followers_url":"https://api.github.com/users/mk01/followers","following_url":"https://api.github.com/users/mk01/following{/other_user}","gists_url":"https://api.github.com/users/mk01/gists{/gist_id}","starred_url":"https://api.github.com/users/mk01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mk01/subscriptions","organizations_url":"https://api.github.com/users/mk01/orgs","repos_url":"https://api.github.com/users/mk01/repos","events_url":"https://api.github.com/users/mk01/events{/privacy}","received_events_url":"https://api.github.com/users/mk01/received_events","type":"User","site_admin":false},"body":"@koying \r\n\r\nthe EDID is finished as is. it just wasn't pushed over this one already existing PR to keep discussion & stuff simple and clear.","created_at":"2015-04-21T14:09:10Z","updated_at":"2015-04-21T14:09:10Z","html_url":"https://github.com/xbmc/xbmc/pull/6996#discussion_r28780854","pull_request_url":"https://api.github.com/repos/xbmc/xbmc/pulls/6996","_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/28780854"},"html":{"href":"https://github.com/xbmc/xbmc/pull/6996#discussion_r28780854"},"pull_request":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/6996"}}},"pull_request":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/6996","id":33702854,"html_url":"https://github.com/xbmc/xbmc/pull/6996","diff_url":"https://github.com/xbmc/xbmc/pull/6996.diff","patch_url":"https://github.com/xbmc/xbmc/pull/6996.patch","issue_url":"https://api.github.com/repos/xbmc/xbmc/issues/6996","number":6996,"state":"open","locked":false,"title":"[IMX] probe & push all resolutions we can use","user":{"login":"mk01","id":3136693,"avatar_url":"https://avatars.githubusercontent.com/u/3136693?v=3","gravatar_id":"","url":"https://api.github.com/users/mk01","html_url":"https://github.com/mk01","followers_url":"https://api.github.com/users/mk01/followers","following_url":"https://api.github.com/users/mk01/following{/other_user}","gists_url":"https://api.github.com/users/mk01/gists{/gist_id}","starred_url":"https://api.github.com/users/mk01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mk01/subscriptions","organizations_url":"https://api.github.com/users/mk01/orgs","repos_url":"https://api.github.com/users/mk01/repos","events_url":"https://api.github.com/users/mk01/events{/privacy}","received_events_url":"https://api.github.com/users/mk01/received_events","type":"User","site_admin":false},"body":"      beside standard(S), try also DVI(U), VESA(V)\r\n\r\n - try in order S -> U -> V\r\n - don't add modes with resolution & refresh we alredy have\r\n - S are preferred (over other types with same XxYxR) because\r\n   they come from EDID(CEA) and do pass requirements\r\n   for proper hdmi audio out\r\n\r\n (this superseeds sam's PR and was rediscussed with\r\n  fritsch on IRC. also please see code comments around\r\n  m_init and fPixelRatio calculation)","created_at":"2015-04-20T20:28:59Z","updated_at":"2015-04-21T14:09:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a330141d4691c5076332b7ada2572810ff9f15b4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/xbmc/xbmc/pulls/6996/commits","review_comments_url":"https://api.github.com/repos/xbmc/xbmc/pulls/6996/comments","review_comment_url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xbmc/xbmc/issues/6996/comments","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/0cecf8b02697bbbbb81468f2274c763d241a8011","head":{"label":"mk01:master","ref":"master","sha":"0cecf8b02697bbbbb81468f2274c763d241a8011","user":{"login":"mk01","id":3136693,"avatar_url":"https://avatars.githubusercontent.com/u/3136693?v=3","gravatar_id":"","url":"https://api.github.com/users/mk01","html_url":"https://github.com/mk01","followers_url":"https://api.github.com/users/mk01/followers","following_url":"https://api.github.com/users/mk01/following{/other_user}","gists_url":"https://api.github.com/users/mk01/gists{/gist_id}","starred_url":"https://api.github.com/users/mk01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mk01/subscriptions","organizations_url":"https://api.github.com/users/mk01/orgs","repos_url":"https://api.github.com/users/mk01/repos","events_url":"https://api.github.com/users/mk01/events{/privacy}","received_events_url":"https://api.github.com/users/mk01/received_events","type":"User","site_admin":false},"repo":{"id":34284175,"name":"xbmc","full_name":"mk01/xbmc","owner":{"login":"mk01","id":3136693,"avatar_url":"https://avatars.githubusercontent.com/u/3136693?v=3","gravatar_id":"","url":"https://api.github.com/users/mk01","html_url":"https://github.com/mk01","followers_url":"https://api.github.com/users/mk01/followers","following_url":"https://api.github.com/users/mk01/following{/other_user}","gists_url":"https://api.github.com/users/mk01/gists{/gist_id}","starred_url":"https://api.github.com/users/mk01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mk01/subscriptions","organizations_url":"https://api.github.com/users/mk01/orgs","repos_url":"https://api.github.com/users/mk01/repos","events_url":"https://api.github.com/users/mk01/events{/privacy}","received_events_url":"https://api.github.com/users/mk01/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mk01/xbmc","description":"Kodi Main Repository - By using this code you agree with our policy and will follow the GPLv2 license as included","fork":true,"url":"https://api.github.com/repos/mk01/xbmc","forks_url":"https://api.github.com/repos/mk01/xbmc/forks","keys_url":"https://api.github.com/repos/mk01/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mk01/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mk01/xbmc/teams","hooks_url":"https://api.github.com/repos/mk01/xbmc/hooks","issue_events_url":"https://api.github.com/repos/mk01/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/mk01/xbmc/events","assignees_url":"https://api.github.com/repos/mk01/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/mk01/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/mk01/xbmc/tags","blobs_url":"https://api.github.com/repos/mk01/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mk01/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mk01/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/mk01/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mk01/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/mk01/xbmc/languages","stargazers_url":"https://api.github.com/repos/mk01/xbmc/stargazers","contributors_url":"https://api.github.com/repos/mk01/xbmc/contributors","subscribers_url":"https://api.github.com/repos/mk01/xbmc/subscribers","subscription_url":"https://api.github.com/repos/mk01/xbmc/subscription","commits_url":"https://api.github.com/repos/mk01/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/mk01/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/mk01/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/mk01/xbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/mk01/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/mk01/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mk01/xbmc/merges","archive_url":"https://api.github.com/repos/mk01/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mk01/xbmc/downloads","issues_url":"https://api.github.com/repos/mk01/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/mk01/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/mk01/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/mk01/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mk01/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/mk01/xbmc/releases{/id}","created_at":"2015-04-20T20:20:26Z","updated_at":"2015-04-20T20:27:07Z","pushed_at":"2015-04-21T09:00:25Z","git_url":"git://github.com/mk01/xbmc.git","ssh_url":"git@github.com:mk01/xbmc.git","clone_url":"https://github.com/mk01/xbmc.git","svn_url":"https://github.com/mk01/xbmc","homepage":"http://kodi.wiki/view/Official:Trademark_Policy","size":512406,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xbmc:master","ref":"master","sha":"bae6085b1f00c83d18138ab39276b49e2d62e6c1","user":{"login":"xbmc","id":199122,"avatar_url":"https://avatars.githubusercontent.com/u/199122?v=3","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"repo":{"id":1217614,"name":"xbmc","full_name":"xbmc/xbmc","owner":{"login":"xbmc","id":199122,"avatar_url":"https://avatars.githubusercontent.com/u/199122?v=3","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xbmc/xbmc","description":"Kodi Main Repository - By using this code you agree with our policy and will follow the GPLv2 license as included","fork":false,"url":"https://api.github.com/repos/xbmc/xbmc","forks_url":"https://api.github.com/repos/xbmc/xbmc/forks","keys_url":"https://api.github.com/repos/xbmc/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xbmc/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xbmc/xbmc/teams","hooks_url":"https://api.github.com/repos/xbmc/xbmc/hooks","issue_events_url":"https://api.github.com/repos/xbmc/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/xbmc/xbmc/events","assignees_url":"https://api.github.com/repos/xbmc/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/xbmc/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/xbmc/xbmc/tags","blobs_url":"https://api.github.com/repos/xbmc/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xbmc/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xbmc/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/xbmc/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/xbmc/xbmc/languages","stargazers_url":"https://api.github.com/repos/xbmc/xbmc/stargazers","contributors_url":"https://api.github.com/repos/xbmc/xbmc/contributors","subscribers_url":"https://api.github.com/repos/xbmc/xbmc/subscribers","subscription_url":"https://api.github.com/repos/xbmc/xbmc/subscription","commits_url":"https://api.github.com/repos/xbmc/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/xbmc/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/xbmc/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/xbmc/xbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/xbmc/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/xbmc/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xbmc/xbmc/merges","archive_url":"https://api.github.com/repos/xbmc/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xbmc/xbmc/downloads","issues_url":"https://api.github.com/repos/xbmc/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/xbmc/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/xbmc/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/xbmc/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xbmc/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/xbmc/xbmc/releases{/id}","created_at":"2011-01-03T21:18:51Z","updated_at":"2015-04-21T13:28:09Z","pushed_at":"2015-04-21T13:59:04Z","git_url":"git://github.com/xbmc/xbmc.git","ssh_url":"git@github.com:xbmc/xbmc.git","clone_url":"https://github.com/xbmc/xbmc.git","svn_url":"https://github.com/xbmc/xbmc","homepage":"http://kodi.wiki/view/Official:Trademark_Policy","size":1861558,"stargazers_count":3847,"watchers_count":3847,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2804,"mirror_url":null,"open_issues_count":235,"forks":2804,"open_issues":235,"watchers":3847,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/6996"},"html":{"href":"https://github.com/xbmc/xbmc/pull/6996"},"issue":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/6996"},"comments":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/6996/comments"},"review_comments":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/6996/comments"},"review_comment":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/6996/commits"},"statuses":{"href":"https://api.github.com/repos/xbmc/xbmc/statuses/0cecf8b02697bbbbb81468f2274c763d241a8011"}}}}