{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin/pulls/comments/41757474","id":41757474,"diff_hunk":"@@ -125,29 +125,8 @@ func (bc *BuildController) nextBuildPhase(build *buildapi.Build) error {\n \t// Set the build phase, which will be persisted if no error occurs.\n \tbuild.Status.Phase = buildapi.BuildPhasePending\n \n-\t// Make a copy to avoid mutating the build from this point on.","path":"pkg/build/controller/controller.go","position":4,"original_position":4,"commit_id":"9b257ce36a5c37b7492167ed1ae5fc569b51ecb7","original_commit_id":"9b257ce36a5c37b7492167ed1ae5fc569b51ecb7","user":{"login":"liggitt","id":980082,"avatar_url":"https://avatars.githubusercontent.com/u/980082?v=3","gravatar_id":"","url":"https://api.github.com/users/liggitt","html_url":"https://github.com/liggitt","followers_url":"https://api.github.com/users/liggitt/followers","following_url":"https://api.github.com/users/liggitt/following{/other_user}","gists_url":"https://api.github.com/users/liggitt/gists{/gist_id}","starred_url":"https://api.github.com/users/liggitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liggitt/subscriptions","organizations_url":"https://api.github.com/users/liggitt/orgs","repos_url":"https://api.github.com/users/liggitt/repos","events_url":"https://api.github.com/users/liggitt/events{/privacy}","received_events_url":"https://api.github.com/users/liggitt/received_events","type":"User","site_admin":false},"body":"does CreateBuildPod mutate the build at all? Can we add a test that ensures nextBuldPhase doesn't mutate the build in unexpected ways (e.g. only the status phase changes). I'd also like tests for CreateBuildPod for each strategy to make sure they don't change the build (or pass a struct to them, rather than a reference)","created_at":"2015-10-12T13:49:02Z","updated_at":"2015-10-12T13:49:02Z","html_url":"https://github.com/openshift/origin/pull/5071#discussion_r41757474","pull_request_url":"https://api.github.com/repos/openshift/origin/pulls/5071","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments/41757474"},"html":{"href":"https://github.com/openshift/origin/pull/5071#discussion_r41757474"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin/pulls/5071"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/5071","id":47412252,"html_url":"https://github.com/openshift/origin/pull/5071","diff_url":"https://github.com/openshift/origin/pull/5071.diff","patch_url":"https://github.com/openshift/origin/pull/5071.patch","issue_url":"https://api.github.com/repos/openshift/origin/issues/5071","number":5071,"state":"open","locked":false,"title":"cleaned up build config","user":{"login":"PI-Victor","id":6294120,"avatar_url":"https://avatars.githubusercontent.com/u/6294120?v=3","gravatar_id":"","url":"https://api.github.com/users/PI-Victor","html_url":"https://github.com/PI-Victor","followers_url":"https://api.github.com/users/PI-Victor/followers","following_url":"https://api.github.com/users/PI-Victor/following{/other_user}","gists_url":"https://api.github.com/users/PI-Victor/gists{/gist_id}","starred_url":"https://api.github.com/users/PI-Victor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PI-Victor/subscriptions","organizations_url":"https://api.github.com/users/PI-Victor/orgs","repos_url":"https://api.github.com/users/PI-Victor/repos","events_url":"https://api.github.com/users/PI-Victor/events{/privacy}","received_events_url":"https://api.github.com/users/PI-Victor/received_events","type":"User","site_admin":false},"body":"i've removed the build config copy object in controller.go and made docker and sti builds use build.Status.OutputDockerImageReference. \r\n\r\n@liggitt sorry i wasn't more specific, here's the trello ref card https://trello.com/c/xrPu7upe/590-1-clean-up-validation-logic-in-builds . i'll amend this pr to fix the issues. ","created_at":"2015-10-12T12:07:21Z","updated_at":"2015-10-12T13:49:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"761d75b095543e34d3fb90308093bceea7a243f3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin/pulls/5071/commits","review_comments_url":"https://api.github.com/repos/openshift/origin/pulls/5071/comments","review_comment_url":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin/issues/5071/comments","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/9b257ce36a5c37b7492167ed1ae5fc569b51ecb7","head":{"label":"PI-Victor:ipalade/clean_build_configs","ref":"ipalade/clean_build_configs","sha":"9b257ce36a5c37b7492167ed1ae5fc569b51ecb7","user":{"login":"PI-Victor","id":6294120,"avatar_url":"https://avatars.githubusercontent.com/u/6294120?v=3","gravatar_id":"","url":"https://api.github.com/users/PI-Victor","html_url":"https://github.com/PI-Victor","followers_url":"https://api.github.com/users/PI-Victor/followers","following_url":"https://api.github.com/users/PI-Victor/following{/other_user}","gists_url":"https://api.github.com/users/PI-Victor/gists{/gist_id}","starred_url":"https://api.github.com/users/PI-Victor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PI-Victor/subscriptions","organizations_url":"https://api.github.com/users/PI-Victor/orgs","repos_url":"https://api.github.com/users/PI-Victor/repos","events_url":"https://api.github.com/users/PI-Victor/events{/privacy}","received_events_url":"https://api.github.com/users/PI-Victor/received_events","type":"User","site_admin":false},"repo":{"id":44103475,"name":"origin","full_name":"PI-Victor/origin","owner":{"login":"PI-Victor","id":6294120,"avatar_url":"https://avatars.githubusercontent.com/u/6294120?v=3","gravatar_id":"","url":"https://api.github.com/users/PI-Victor","html_url":"https://github.com/PI-Victor","followers_url":"https://api.github.com/users/PI-Victor/followers","following_url":"https://api.github.com/users/PI-Victor/following{/other_user}","gists_url":"https://api.github.com/users/PI-Victor/gists{/gist_id}","starred_url":"https://api.github.com/users/PI-Victor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PI-Victor/subscriptions","organizations_url":"https://api.github.com/users/PI-Victor/orgs","repos_url":"https://api.github.com/users/PI-Victor/repos","events_url":"https://api.github.com/users/PI-Victor/events{/privacy}","received_events_url":"https://api.github.com/users/PI-Victor/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/PI-Victor/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":true,"url":"https://api.github.com/repos/PI-Victor/origin","forks_url":"https://api.github.com/repos/PI-Victor/origin/forks","keys_url":"https://api.github.com/repos/PI-Victor/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PI-Victor/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PI-Victor/origin/teams","hooks_url":"https://api.github.com/repos/PI-Victor/origin/hooks","issue_events_url":"https://api.github.com/repos/PI-Victor/origin/issues/events{/number}","events_url":"https://api.github.com/repos/PI-Victor/origin/events","assignees_url":"https://api.github.com/repos/PI-Victor/origin/assignees{/user}","branches_url":"https://api.github.com/repos/PI-Victor/origin/branches{/branch}","tags_url":"https://api.github.com/repos/PI-Victor/origin/tags","blobs_url":"https://api.github.com/repos/PI-Victor/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PI-Victor/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PI-Victor/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/PI-Victor/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PI-Victor/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/PI-Victor/origin/languages","stargazers_url":"https://api.github.com/repos/PI-Victor/origin/stargazers","contributors_url":"https://api.github.com/repos/PI-Victor/origin/contributors","subscribers_url":"https://api.github.com/repos/PI-Victor/origin/subscribers","subscription_url":"https://api.github.com/repos/PI-Victor/origin/subscription","commits_url":"https://api.github.com/repos/PI-Victor/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/PI-Victor/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/PI-Victor/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/PI-Victor/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/PI-Victor/origin/contents/{+path}","compare_url":"https://api.github.com/repos/PI-Victor/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PI-Victor/origin/merges","archive_url":"https://api.github.com/repos/PI-Victor/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PI-Victor/origin/downloads","issues_url":"https://api.github.com/repos/PI-Victor/origin/issues{/number}","pulls_url":"https://api.github.com/repos/PI-Victor/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/PI-Victor/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/PI-Victor/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PI-Victor/origin/labels{/name}","releases_url":"https://api.github.com/repos/PI-Victor/origin/releases{/id}","created_at":"2015-10-12T11:36:04Z","updated_at":"2015-10-12T11:36:30Z","pushed_at":"2015-10-12T11:52:32Z","git_url":"git://github.com/PI-Victor/origin.git","ssh_url":"git@github.com:PI-Victor/origin.git","clone_url":"https://github.com/PI-Victor/origin.git","svn_url":"https://github.com/PI-Victor/origin","homepage":"http://www.openshift.org","size":256234,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"86b63beaabe05067afc066089f94a34bad367185","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":22442668,"name":"origin","full_name":"openshift/origin","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":false,"url":"https://api.github.com/repos/openshift/origin","forks_url":"https://api.github.com/repos/openshift/origin/forks","keys_url":"https://api.github.com/repos/openshift/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin/teams","hooks_url":"https://api.github.com/repos/openshift/origin/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin/events","assignees_url":"https://api.github.com/repos/openshift/origin/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin/tags","blobs_url":"https://api.github.com/repos/openshift/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin/languages","stargazers_url":"https://api.github.com/repos/openshift/origin/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin/subscription","commits_url":"https://api.github.com/repos/openshift/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin/merges","archive_url":"https://api.github.com/repos/openshift/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin/downloads","issues_url":"https://api.github.com/repos/openshift/origin/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin/releases{/id}","created_at":"2014-07-30T20:04:05Z","updated_at":"2015-10-12T12:28:48Z","pushed_at":"2015-10-12T13:40:46Z","git_url":"git://github.com/openshift/origin.git","ssh_url":"git@github.com:openshift/origin.git","clone_url":"https://github.com/openshift/origin.git","svn_url":"https://github.com/openshift/origin","homepage":"http://www.openshift.org","size":256234,"stargazers_count":731,"watchers_count":731,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":445,"mirror_url":null,"open_issues_count":588,"forks":445,"open_issues":588,"watchers":731,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/5071"},"html":{"href":"https://github.com/openshift/origin/pull/5071"},"issue":{"href":"https://api.github.com/repos/openshift/origin/issues/5071"},"comments":{"href":"https://api.github.com/repos/openshift/origin/issues/5071/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin/pulls/5071/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin/pulls/5071/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin/statuses/9b257ce36a5c37b7492167ed1ae5fc569b51ecb7"}}}}