{"action":"opened","number":225,"pull_request":{"url":"https://api.github.com/repos/dennisdoomen/fluentassertions/pulls/225","id":28873845,"html_url":"https://github.com/dennisdoomen/fluentassertions/pull/225","diff_url":"https://github.com/dennisdoomen/fluentassertions/pull/225.diff","patch_url":"https://github.com/dennisdoomen/fluentassertions/pull/225.patch","issue_url":"https://api.github.com/repos/dennisdoomen/fluentassertions/issues/225","number":225,"state":"open","locked":false,"title":"Fixes duplicate failure messages in ShouldBeEquivalentTo","user":{"login":"vossad01","id":965439,"avatar_url":"https://avatars.githubusercontent.com/u/965439?v=3","gravatar_id":"","url":"https://api.github.com/users/vossad01","html_url":"https://github.com/vossad01","followers_url":"https://api.github.com/users/vossad01/followers","following_url":"https://api.github.com/users/vossad01/following{/other_user}","gists_url":"https://api.github.com/users/vossad01/gists{/gist_id}","starred_url":"https://api.github.com/users/vossad01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vossad01/subscriptions","organizations_url":"https://api.github.com/users/vossad01/orgs","repos_url":"https://api.github.com/users/vossad01/repos","events_url":"https://api.github.com/users/vossad01/events{/privacy}","received_events_url":"https://api.github.com/users/vossad01/received_events","type":"User","site_admin":false},"body":"Corrects an issue wherein true duplicates of failure messages were being reported to users by `ShouldBeEquivalentTo` when the graph contained an Enumerable.\r\n\r\nBy 'true duplicates', I mean multiple reports of the same failure pertaining to the same member produced by a single check.  This is distinct from the previously removed \"duplicates\" where it was a distinct failure that produced the same failure message.\r\n___\r\n\r\nI found the fix a little surprising.  I did not trace history far enough to see why the code was added in the first place.  Since no tests broke by its removal I am thinking it is probably okay.  Based on how `AssertionScope.Dispose` is implemented I do not see how this removal would be an issue.\r\n\r\nThis does change the return from `Discard`, but that is what is fixing this bug for Collections (and Exceptions, untested).  I would be surprised if end-users are using `Discard` and depending on the return but if they are than this would be a breaking change.\r\n\r\nI did trace history on the 6 vs 4 vs 1 in `AssertionScopeSpecs`.  I think going from 1 to 6 was just an oversight when deduplication was removed for #151.","created_at":"2015-02-08T01:54:43Z","updated_at":"2015-02-08T01:54:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dennisdoomen/fluentassertions/pulls/225/commits","review_comments_url":"https://api.github.com/repos/dennisdoomen/fluentassertions/pulls/225/comments","review_comment_url":"https://api.github.com/repos/dennisdoomen/fluentassertions/pulls/comments/{number}","comments_url":"https://api.github.com/repos/dennisdoomen/fluentassertions/issues/225/comments","statuses_url":"https://api.github.com/repos/dennisdoomen/fluentassertions/statuses/c05d9847f24771fecf47da2bccc2385b5b135aa6","head":{"label":"vossad01:FixDuplicateEquivalencyFailures","ref":"FixDuplicateEquivalencyFailures","sha":"c05d9847f24771fecf47da2bccc2385b5b135aa6","user":{"login":"vossad01","id":965439,"avatar_url":"https://avatars.githubusercontent.com/u/965439?v=3","gravatar_id":"","url":"https://api.github.com/users/vossad01","html_url":"https://github.com/vossad01","followers_url":"https://api.github.com/users/vossad01/followers","following_url":"https://api.github.com/users/vossad01/following{/other_user}","gists_url":"https://api.github.com/users/vossad01/gists{/gist_id}","starred_url":"https://api.github.com/users/vossad01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vossad01/subscriptions","organizations_url":"https://api.github.com/users/vossad01/orgs","repos_url":"https://api.github.com/users/vossad01/repos","events_url":"https://api.github.com/users/vossad01/events{/privacy}","received_events_url":"https://api.github.com/users/vossad01/received_events","type":"User","site_admin":false},"repo":{"id":14546050,"name":"fluentassertions","full_name":"vossad01/fluentassertions","owner":{"login":"vossad01","id":965439,"avatar_url":"https://avatars.githubusercontent.com/u/965439?v=3","gravatar_id":"","url":"https://api.github.com/users/vossad01","html_url":"https://github.com/vossad01","followers_url":"https://api.github.com/users/vossad01/followers","following_url":"https://api.github.com/users/vossad01/following{/other_user}","gists_url":"https://api.github.com/users/vossad01/gists{/gist_id}","starred_url":"https://api.github.com/users/vossad01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vossad01/subscriptions","organizations_url":"https://api.github.com/users/vossad01/orgs","repos_url":"https://api.github.com/users/vossad01/repos","events_url":"https://api.github.com/users/vossad01/events{/privacy}","received_events_url":"https://api.github.com/users/vossad01/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vossad01/fluentassertions","description":"Fluent Assertions is a set of .NET extension methods that allow you to more naturally specify the expected outcome of a TDD or BDD-style test. We currently use it in all our internal and client projects, and it is used in many open-source projects. It runs on .NET 3.5, 4.0 and 4.5 (Desktop and Windows Store), Silverlight 4 and 5 and Windows Phone 7.5. And it supports the unit test frameworks NUnit, XUnit, MBUnit, Gallio and MSpec.","fork":true,"url":"https://api.github.com/repos/vossad01/fluentassertions","forks_url":"https://api.github.com/repos/vossad01/fluentassertions/forks","keys_url":"https://api.github.com/repos/vossad01/fluentassertions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vossad01/fluentassertions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vossad01/fluentassertions/teams","hooks_url":"https://api.github.com/repos/vossad01/fluentassertions/hooks","issue_events_url":"https://api.github.com/repos/vossad01/fluentassertions/issues/events{/number}","events_url":"https://api.github.com/repos/vossad01/fluentassertions/events","assignees_url":"https://api.github.com/repos/vossad01/fluentassertions/assignees{/user}","branches_url":"https://api.github.com/repos/vossad01/fluentassertions/branches{/branch}","tags_url":"https://api.github.com/repos/vossad01/fluentassertions/tags","blobs_url":"https://api.github.com/repos/vossad01/fluentassertions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vossad01/fluentassertions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vossad01/fluentassertions/git/refs{/sha}","trees_url":"https://api.github.com/repos/vossad01/fluentassertions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vossad01/fluentassertions/statuses/{sha}","languages_url":"https://api.github.com/repos/vossad01/fluentassertions/languages","stargazers_url":"https://api.github.com/repos/vossad01/fluentassertions/stargazers","contributors_url":"https://api.github.com/repos/vossad01/fluentassertions/contributors","subscribers_url":"https://api.github.com/repos/vossad01/fluentassertions/subscribers","subscription_url":"https://api.github.com/repos/vossad01/fluentassertions/subscription","commits_url":"https://api.github.com/repos/vossad01/fluentassertions/commits{/sha}","git_commits_url":"https://api.github.com/repos/vossad01/fluentassertions/git/commits{/sha}","comments_url":"https://api.github.com/repos/vossad01/fluentassertions/comments{/number}","issue_comment_url":"https://api.github.com/repos/vossad01/fluentassertions/issues/comments/{number}","contents_url":"https://api.github.com/repos/vossad01/fluentassertions/contents/{+path}","compare_url":"https://api.github.com/repos/vossad01/fluentassertions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vossad01/fluentassertions/merges","archive_url":"https://api.github.com/repos/vossad01/fluentassertions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vossad01/fluentassertions/downloads","issues_url":"https://api.github.com/repos/vossad01/fluentassertions/issues{/number}","pulls_url":"https://api.github.com/repos/vossad01/fluentassertions/pulls{/number}","milestones_url":"https://api.github.com/repos/vossad01/fluentassertions/milestones{/number}","notifications_url":"https://api.github.com/repos/vossad01/fluentassertions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vossad01/fluentassertions/labels{/name}","releases_url":"https://api.github.com/repos/vossad01/fluentassertions/releases{/id}","created_at":"2013-11-20T03:47:59Z","updated_at":"2015-01-17T15:33:59Z","pushed_at":"2015-02-08T01:53:39Z","git_url":"git://github.com/vossad01/fluentassertions.git","ssh_url":"git@github.com:vossad01/fluentassertions.git","clone_url":"https://github.com/vossad01/fluentassertions.git","svn_url":"https://github.com/vossad01/fluentassertions","homepage":null,"size":11166,"stargazers_count":0,"watchers_count":0,"language":"Smalltalk","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dennisdoomen:develop","ref":"develop","sha":"ca717532627a74da7a45260e42803d6a53055139","user":{"login":"dennisdoomen","id":572734,"avatar_url":"https://avatars.githubusercontent.com/u/572734?v=3","gravatar_id":"","url":"https://api.github.com/users/dennisdoomen","html_url":"https://github.com/dennisdoomen","followers_url":"https://api.github.com/users/dennisdoomen/followers","following_url":"https://api.github.com/users/dennisdoomen/following{/other_user}","gists_url":"https://api.github.com/users/dennisdoomen/gists{/gist_id}","starred_url":"https://api.github.com/users/dennisdoomen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dennisdoomen/subscriptions","organizations_url":"https://api.github.com/users/dennisdoomen/orgs","repos_url":"https://api.github.com/users/dennisdoomen/repos","events_url":"https://api.github.com/users/dennisdoomen/events{/privacy}","received_events_url":"https://api.github.com/users/dennisdoomen/received_events","type":"User","site_admin":false},"repo":{"id":11718424,"name":"fluentassertions","full_name":"dennisdoomen/fluentassertions","owner":{"login":"dennisdoomen","id":572734,"avatar_url":"https://avatars.githubusercontent.com/u/572734?v=3","gravatar_id":"","url":"https://api.github.com/users/dennisdoomen","html_url":"https://github.com/dennisdoomen","followers_url":"https://api.github.com/users/dennisdoomen/followers","following_url":"https://api.github.com/users/dennisdoomen/following{/other_user}","gists_url":"https://api.github.com/users/dennisdoomen/gists{/gist_id}","starred_url":"https://api.github.com/users/dennisdoomen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dennisdoomen/subscriptions","organizations_url":"https://api.github.com/users/dennisdoomen/orgs","repos_url":"https://api.github.com/users/dennisdoomen/repos","events_url":"https://api.github.com/users/dennisdoomen/events{/privacy}","received_events_url":"https://api.github.com/users/dennisdoomen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dennisdoomen/fluentassertions","description":"Fluent Assertions is a set of .NET extension methods that allow you to more naturally specify the expected outcome of a TDD or BDD-style test. We currently use it in all our internal and client projects, and it is used in many open-source projects. It runs on .NET 3.5, 4.0 and 4.5 (Desktop and Windows Store), Silverlight 4 and 5 and Windows Phone 7.5 and later. It supports the unit test frameworks NUnit, XUnit, MBUnit, Gallio, NSpec and MSpec.","fork":false,"url":"https://api.github.com/repos/dennisdoomen/fluentassertions","forks_url":"https://api.github.com/repos/dennisdoomen/fluentassertions/forks","keys_url":"https://api.github.com/repos/dennisdoomen/fluentassertions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dennisdoomen/fluentassertions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dennisdoomen/fluentassertions/teams","hooks_url":"https://api.github.com/repos/dennisdoomen/fluentassertions/hooks","issue_events_url":"https://api.github.com/repos/dennisdoomen/fluentassertions/issues/events{/number}","events_url":"https://api.github.com/repos/dennisdoomen/fluentassertions/events","assignees_url":"https://api.github.com/repos/dennisdoomen/fluentassertions/assignees{/user}","branches_url":"https://api.github.com/repos/dennisdoomen/fluentassertions/branches{/branch}","tags_url":"https://api.github.com/repos/dennisdoomen/fluentassertions/tags","blobs_url":"https://api.github.com/repos/dennisdoomen/fluentassertions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dennisdoomen/fluentassertions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dennisdoomen/fluentassertions/git/refs{/sha}","trees_url":"https://api.github.com/repos/dennisdoomen/fluentassertions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dennisdoomen/fluentassertions/statuses/{sha}","languages_url":"https://api.github.com/repos/dennisdoomen/fluentassertions/languages","stargazers_url":"https://api.github.com/repos/dennisdoomen/fluentassertions/stargazers","contributors_url":"https://api.github.com/repos/dennisdoomen/fluentassertions/contributors","subscribers_url":"https://api.github.com/repos/dennisdoomen/fluentassertions/subscribers","subscription_url":"https://api.github.com/repos/dennisdoomen/fluentassertions/subscription","commits_url":"https://api.github.com/repos/dennisdoomen/fluentassertions/commits{/sha}","git_commits_url":"https://api.github.com/repos/dennisdoomen/fluentassertions/git/commits{/sha}","comments_url":"https://api.github.com/repos/dennisdoomen/fluentassertions/comments{/number}","issue_comment_url":"https://api.github.com/repos/dennisdoomen/fluentassertions/issues/comments/{number}","contents_url":"https://api.github.com/repos/dennisdoomen/fluentassertions/contents/{+path}","compare_url":"https://api.github.com/repos/dennisdoomen/fluentassertions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dennisdoomen/fluentassertions/merges","archive_url":"https://api.github.com/repos/dennisdoomen/fluentassertions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dennisdoomen/fluentassertions/downloads","issues_url":"https://api.github.com/repos/dennisdoomen/fluentassertions/issues{/number}","pulls_url":"https://api.github.com/repos/dennisdoomen/fluentassertions/pulls{/number}","milestones_url":"https://api.github.com/repos/dennisdoomen/fluentassertions/milestones{/number}","notifications_url":"https://api.github.com/repos/dennisdoomen/fluentassertions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dennisdoomen/fluentassertions/labels{/name}","releases_url":"https://api.github.com/repos/dennisdoomen/fluentassertions/releases{/id}","created_at":"2013-07-28T10:35:25Z","updated_at":"2015-02-07T13:20:27Z","pushed_at":"2015-02-03T19:54:08Z","git_url":"git://github.com/dennisdoomen/fluentassertions.git","ssh_url":"git@github.com:dennisdoomen/fluentassertions.git","clone_url":"https://github.com/dennisdoomen/fluentassertions.git","svn_url":"https://github.com/dennisdoomen/fluentassertions","homepage":"https://www.nuget.org/packages/FluentAssertions","size":13420,"stargazers_count":275,"watchers_count":275,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":59,"mirror_url":null,"open_issues_count":35,"forks":59,"open_issues":35,"watchers":275,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/dennisdoomen/fluentassertions/pulls/225"},"html":{"href":"https://github.com/dennisdoomen/fluentassertions/pull/225"},"issue":{"href":"https://api.github.com/repos/dennisdoomen/fluentassertions/issues/225"},"comments":{"href":"https://api.github.com/repos/dennisdoomen/fluentassertions/issues/225/comments"},"review_comments":{"href":"https://api.github.com/repos/dennisdoomen/fluentassertions/pulls/225/comments"},"review_comment":{"href":"https://api.github.com/repos/dennisdoomen/fluentassertions/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/dennisdoomen/fluentassertions/pulls/225/commits"},"statuses":{"href":"https://api.github.com/repos/dennisdoomen/fluentassertions/statuses/c05d9847f24771fecf47da2bccc2385b5b135aa6"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":38,"deletions":10,"changed_files":4}}