{"action":"created","comment":{"url":"https://api.github.com/repos/zendframework/zf2/pulls/comments/25025875","id":25025875,"diff_hunk":"@@ -44,6 +45,58 @@ class MemcacheOptions extends AdapterOptions\n     protected $compression = false;\n \n     /**\n+     * {inheritdoc}\n+     */\n+    public function setFromArray($options)\n+    {\n+        if ($options instanceof AbstractOptions) {\n+            $options = $options->toArray();\n+        }\n+\n+        if (!is_array($options) && !$options instanceof Traversable) {\n+            throw new Exception\\InvalidArgumentException(\n+                sprintf(\n+                    'Parameter provided to %s must be an %s, %s or %s',\n+                    __METHOD__,\n+                    'array',\n+                    'Traversable',\n+                    'Zend\\Stdlib\\AbstractOptions'\n+                )\n+            );\n+        }\n+\n+        if ($options instanceof Traversable) {\n+            $options = iterator_to_array($options);\n+        }\n+\n+        $options  = array_change_key_case($options, CASE_LOWER);\n+        $prioOpts = array();","path":"library/Zend/Cache/Storage/Adapter/MemcacheOptions.php","position":37,"original_position":37,"commit_id":"d996f4476fbdbdd49a6dc4f789aab53bd872d1fd","original_commit_id":"d996f4476fbdbdd49a6dc4f789aab53bd872d1fd","user":{"login":"weierophinney","id":25943,"avatar_url":"https://avatars.githubusercontent.com/u/25943?v=3","gravatar_id":"","url":"https://api.github.com/users/weierophinney","html_url":"https://github.com/weierophinney","followers_url":"https://api.github.com/users/weierophinney/followers","following_url":"https://api.github.com/users/weierophinney/following{/other_user}","gists_url":"https://api.github.com/users/weierophinney/gists{/gist_id}","starred_url":"https://api.github.com/users/weierophinney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weierophinney/subscriptions","organizations_url":"https://api.github.com/users/weierophinney/orgs","repos_url":"https://api.github.com/users/weierophinney/repos","events_url":"https://api.github.com/users/weierophinney/events{/privacy}","received_events_url":"https://api.github.com/users/weierophinney/received_events","type":"User","site_admin":false},"body":"What does `$prioOpts` stand for? `prior options`? or `priority options`? or...? Please be explicit. :)","created_at":"2015-02-19T21:11:10Z","updated_at":"2015-02-19T21:11:10Z","html_url":"https://github.com/zendframework/zf2/pull/7205#discussion_r25025875","pull_request_url":"https://api.github.com/repos/zendframework/zf2/pulls/7205","_links":{"self":{"href":"https://api.github.com/repos/zendframework/zf2/pulls/comments/25025875"},"html":{"href":"https://github.com/zendframework/zf2/pull/7205#discussion_r25025875"},"pull_request":{"href":"https://api.github.com/repos/zendframework/zf2/pulls/7205"}}},"pull_request":{"url":"https://api.github.com/repos/zendframework/zf2/pulls/7205","id":29121828,"html_url":"https://github.com/zendframework/zf2/pull/7205","diff_url":"https://github.com/zendframework/zf2/pull/7205.diff","patch_url":"https://github.com/zendframework/zf2/pull/7205.patch","issue_url":"https://api.github.com/repos/zendframework/zf2/issues/7205","number":7205,"state":"open","locked":false,"title":"Prototype fixing #6381: Order of resource based adapter options may cause Exception","user":{"login":"marc-mabe","id":302689,"avatar_url":"https://avatars.githubusercontent.com/u/302689?v=3","gravatar_id":"","url":"https://api.github.com/users/marc-mabe","html_url":"https://github.com/marc-mabe","followers_url":"https://api.github.com/users/marc-mabe/followers","following_url":"https://api.github.com/users/marc-mabe/following{/other_user}","gists_url":"https://api.github.com/users/marc-mabe/gists{/gist_id}","starred_url":"https://api.github.com/users/marc-mabe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marc-mabe/subscriptions","organizations_url":"https://api.github.com/users/marc-mabe/orgs","repos_url":"https://api.github.com/users/marc-mabe/repos","events_url":"https://api.github.com/users/marc-mabe/events{/privacy}","received_events_url":"https://api.github.com/users/marc-mabe/received_events","type":"User","site_admin":false},"body":"This is a prototype!!!!\r\n\r\nThis would be duplicated in all Options classes requiring some ordering of options.\r\n\r\n@Ocramius @weierophinney In my opinion the issue #6381 should be marked as won't fixed as the options will be applied in the order they are defined. This behavior should be documented but not changed into a adapter defined ordering like this prototype. Additionally this prototype shows it's more error prone than the current behavior and would be needed to be document3ed for each adapter what the defined order would resulting in other WTF moments.","created_at":"2015-02-11T19:43:42Z","updated_at":"2015-02-19T21:11:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"332b26e0f4e3c37b082f4ff7438479aecff954c5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/zendframework/zf2/pulls/7205/commits","review_comments_url":"https://api.github.com/repos/zendframework/zf2/pulls/7205/comments","review_comment_url":"https://api.github.com/repos/zendframework/zf2/pulls/comments/{number}","comments_url":"https://api.github.com/repos/zendframework/zf2/issues/7205/comments","statuses_url":"https://api.github.com/repos/zendframework/zf2/statuses/d996f4476fbdbdd49a6dc4f789aab53bd872d1fd","head":{"label":"marc-mabe:hotfix/6381","ref":"hotfix/6381","sha":"d996f4476fbdbdd49a6dc4f789aab53bd872d1fd","user":{"login":"marc-mabe","id":302689,"avatar_url":"https://avatars.githubusercontent.com/u/302689?v=3","gravatar_id":"","url":"https://api.github.com/users/marc-mabe","html_url":"https://github.com/marc-mabe","followers_url":"https://api.github.com/users/marc-mabe/followers","following_url":"https://api.github.com/users/marc-mabe/following{/other_user}","gists_url":"https://api.github.com/users/marc-mabe/gists{/gist_id}","starred_url":"https://api.github.com/users/marc-mabe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marc-mabe/subscriptions","organizations_url":"https://api.github.com/users/marc-mabe/orgs","repos_url":"https://api.github.com/users/marc-mabe/repos","events_url":"https://api.github.com/users/marc-mabe/events{/privacy}","received_events_url":"https://api.github.com/users/marc-mabe/received_events","type":"User","site_admin":false},"repo":{"id":726228,"name":"zf2","full_name":"marc-mabe/zf2","owner":{"login":"marc-mabe","id":302689,"avatar_url":"https://avatars.githubusercontent.com/u/302689?v=3","gravatar_id":"","url":"https://api.github.com/users/marc-mabe","html_url":"https://github.com/marc-mabe","followers_url":"https://api.github.com/users/marc-mabe/followers","following_url":"https://api.github.com/users/marc-mabe/following{/other_user}","gists_url":"https://api.github.com/users/marc-mabe/gists{/gist_id}","starred_url":"https://api.github.com/users/marc-mabe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marc-mabe/subscriptions","organizations_url":"https://api.github.com/users/marc-mabe/orgs","repos_url":"https://api.github.com/users/marc-mabe/repos","events_url":"https://api.github.com/users/marc-mabe/events{/privacy}","received_events_url":"https://api.github.com/users/marc-mabe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/marc-mabe/zf2","description":"Fork of Zend Framework 2.0","fork":true,"url":"https://api.github.com/repos/marc-mabe/zf2","forks_url":"https://api.github.com/repos/marc-mabe/zf2/forks","keys_url":"https://api.github.com/repos/marc-mabe/zf2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marc-mabe/zf2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marc-mabe/zf2/teams","hooks_url":"https://api.github.com/repos/marc-mabe/zf2/hooks","issue_events_url":"https://api.github.com/repos/marc-mabe/zf2/issues/events{/number}","events_url":"https://api.github.com/repos/marc-mabe/zf2/events","assignees_url":"https://api.github.com/repos/marc-mabe/zf2/assignees{/user}","branches_url":"https://api.github.com/repos/marc-mabe/zf2/branches{/branch}","tags_url":"https://api.github.com/repos/marc-mabe/zf2/tags","blobs_url":"https://api.github.com/repos/marc-mabe/zf2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marc-mabe/zf2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marc-mabe/zf2/git/refs{/sha}","trees_url":"https://api.github.com/repos/marc-mabe/zf2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marc-mabe/zf2/statuses/{sha}","languages_url":"https://api.github.com/repos/marc-mabe/zf2/languages","stargazers_url":"https://api.github.com/repos/marc-mabe/zf2/stargazers","contributors_url":"https://api.github.com/repos/marc-mabe/zf2/contributors","subscribers_url":"https://api.github.com/repos/marc-mabe/zf2/subscribers","subscription_url":"https://api.github.com/repos/marc-mabe/zf2/subscription","commits_url":"https://api.github.com/repos/marc-mabe/zf2/commits{/sha}","git_commits_url":"https://api.github.com/repos/marc-mabe/zf2/git/commits{/sha}","comments_url":"https://api.github.com/repos/marc-mabe/zf2/comments{/number}","issue_comment_url":"https://api.github.com/repos/marc-mabe/zf2/issues/comments/{number}","contents_url":"https://api.github.com/repos/marc-mabe/zf2/contents/{+path}","compare_url":"https://api.github.com/repos/marc-mabe/zf2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marc-mabe/zf2/merges","archive_url":"https://api.github.com/repos/marc-mabe/zf2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marc-mabe/zf2/downloads","issues_url":"https://api.github.com/repos/marc-mabe/zf2/issues{/number}","pulls_url":"https://api.github.com/repos/marc-mabe/zf2/pulls{/number}","milestones_url":"https://api.github.com/repos/marc-mabe/zf2/milestones{/number}","notifications_url":"https://api.github.com/repos/marc-mabe/zf2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marc-mabe/zf2/labels{/name}","releases_url":"https://api.github.com/repos/marc-mabe/zf2/releases{/id}","created_at":"2010-06-17T16:30:01Z","updated_at":"2015-01-09T20:34:55Z","pushed_at":"2015-02-11T19:35:25Z","git_url":"git://github.com/marc-mabe/zf2.git","ssh_url":"git@github.com:marc-mabe/zf2.git","clone_url":"https://github.com/marc-mabe/zf2.git","svn_url":"https://github.com/marc-mabe/zf2","homepage":"http://framework.zend.com/zf2","size":97446,"stargazers_count":5,"watchers_count":5,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":0,"forks":3,"open_issues":0,"watchers":5,"default_branch":"master"}},"base":{"label":"zendframework:master","ref":"master","sha":"70d098c946a0e784fe26a08b1779bc388f02a327","user":{"login":"zendframework","id":296074,"avatar_url":"https://avatars.githubusercontent.com/u/296074?v=3","gravatar_id":"","url":"https://api.github.com/users/zendframework","html_url":"https://github.com/zendframework","followers_url":"https://api.github.com/users/zendframework/followers","following_url":"https://api.github.com/users/zendframework/following{/other_user}","gists_url":"https://api.github.com/users/zendframework/gists{/gist_id}","starred_url":"https://api.github.com/users/zendframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zendframework/subscriptions","organizations_url":"https://api.github.com/users/zendframework/orgs","repos_url":"https://api.github.com/users/zendframework/repos","events_url":"https://api.github.com/users/zendframework/events{/privacy}","received_events_url":"https://api.github.com/users/zendframework/received_events","type":"Organization","site_admin":false},"repo":{"id":702550,"name":"zf2","full_name":"zendframework/zf2","owner":{"login":"zendframework","id":296074,"avatar_url":"https://avatars.githubusercontent.com/u/296074?v=3","gravatar_id":"","url":"https://api.github.com/users/zendframework","html_url":"https://github.com/zendframework","followers_url":"https://api.github.com/users/zendframework/followers","following_url":"https://api.github.com/users/zendframework/following{/other_user}","gists_url":"https://api.github.com/users/zendframework/gists{/gist_id}","starred_url":"https://api.github.com/users/zendframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zendframework/subscriptions","organizations_url":"https://api.github.com/users/zendframework/orgs","repos_url":"https://api.github.com/users/zendframework/repos","events_url":"https://api.github.com/users/zendframework/events{/privacy}","received_events_url":"https://api.github.com/users/zendframework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zendframework/zf2","description":"Official Zend Framework 2 git repository","fork":false,"url":"https://api.github.com/repos/zendframework/zf2","forks_url":"https://api.github.com/repos/zendframework/zf2/forks","keys_url":"https://api.github.com/repos/zendframework/zf2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zendframework/zf2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zendframework/zf2/teams","hooks_url":"https://api.github.com/repos/zendframework/zf2/hooks","issue_events_url":"https://api.github.com/repos/zendframework/zf2/issues/events{/number}","events_url":"https://api.github.com/repos/zendframework/zf2/events","assignees_url":"https://api.github.com/repos/zendframework/zf2/assignees{/user}","branches_url":"https://api.github.com/repos/zendframework/zf2/branches{/branch}","tags_url":"https://api.github.com/repos/zendframework/zf2/tags","blobs_url":"https://api.github.com/repos/zendframework/zf2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zendframework/zf2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zendframework/zf2/git/refs{/sha}","trees_url":"https://api.github.com/repos/zendframework/zf2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zendframework/zf2/statuses/{sha}","languages_url":"https://api.github.com/repos/zendframework/zf2/languages","stargazers_url":"https://api.github.com/repos/zendframework/zf2/stargazers","contributors_url":"https://api.github.com/repos/zendframework/zf2/contributors","subscribers_url":"https://api.github.com/repos/zendframework/zf2/subscribers","subscription_url":"https://api.github.com/repos/zendframework/zf2/subscription","commits_url":"https://api.github.com/repos/zendframework/zf2/commits{/sha}","git_commits_url":"https://api.github.com/repos/zendframework/zf2/git/commits{/sha}","comments_url":"https://api.github.com/repos/zendframework/zf2/comments{/number}","issue_comment_url":"https://api.github.com/repos/zendframework/zf2/issues/comments/{number}","contents_url":"https://api.github.com/repos/zendframework/zf2/contents/{+path}","compare_url":"https://api.github.com/repos/zendframework/zf2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zendframework/zf2/merges","archive_url":"https://api.github.com/repos/zendframework/zf2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zendframework/zf2/downloads","issues_url":"https://api.github.com/repos/zendframework/zf2/issues{/number}","pulls_url":"https://api.github.com/repos/zendframework/zf2/pulls{/number}","milestones_url":"https://api.github.com/repos/zendframework/zf2/milestones{/number}","notifications_url":"https://api.github.com/repos/zendframework/zf2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zendframework/zf2/labels{/name}","releases_url":"https://api.github.com/repos/zendframework/zf2/releases{/id}","created_at":"2010-06-04T02:42:05Z","updated_at":"2015-02-19T16:17:07Z","pushed_at":"2015-02-18T19:54:23Z","git_url":"git://github.com/zendframework/zf2.git","ssh_url":"git@github.com:zendframework/zf2.git","clone_url":"https://github.com/zendframework/zf2.git","svn_url":"https://github.com/zendframework/zf2","homepage":"http://framework.zend.com/","size":217843,"stargazers_count":5021,"watchers_count":5021,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3060,"mirror_url":null,"open_issues_count":597,"forks":3060,"open_issues":597,"watchers":5021,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zendframework/zf2/pulls/7205"},"html":{"href":"https://github.com/zendframework/zf2/pull/7205"},"issue":{"href":"https://api.github.com/repos/zendframework/zf2/issues/7205"},"comments":{"href":"https://api.github.com/repos/zendframework/zf2/issues/7205/comments"},"review_comments":{"href":"https://api.github.com/repos/zendframework/zf2/pulls/7205/comments"},"review_comment":{"href":"https://api.github.com/repos/zendframework/zf2/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/zendframework/zf2/pulls/7205/commits"},"statuses":{"href":"https://api.github.com/repos/zendframework/zf2/statuses/d996f4476fbdbdd49a6dc4f789aab53bd872d1fd"}}}}