{"action":"created","issue":{"url":"https://api.github.com/repos/Fody/PropertyChanged/issues/130","labels_url":"https://api.github.com/repos/Fody/PropertyChanged/issues/130/labels{/name}","comments_url":"https://api.github.com/repos/Fody/PropertyChanged/issues/130/comments","events_url":"https://api.github.com/repos/Fody/PropertyChanged/issues/130/events","html_url":"https://github.com/Fody/PropertyChanged/pull/130","id":82393055,"number":130,"title":"Prevent NullReferenceException with obfuscated assemblies and add .editorconfig","user":{"login":"smischke","id":8622962,"avatar_url":"https://avatars.githubusercontent.com/u/8622962?v=3","gravatar_id":"","url":"https://api.github.com/users/smischke","html_url":"https://github.com/smischke","followers_url":"https://api.github.com/users/smischke/followers","following_url":"https://api.github.com/users/smischke/following{/other_user}","gists_url":"https://api.github.com/users/smischke/gists{/gist_id}","starred_url":"https://api.github.com/users/smischke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smischke/subscriptions","organizations_url":"https://api.github.com/users/smischke/orgs","repos_url":"https://api.github.com/users/smischke/repos","events_url":"https://api.github.com/users/smischke/events{/privacy}","received_events_url":"https://api.github.com/users/smischke/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-05-29T11:41:24Z","updated_at":"2015-12-22T03:47:35Z","closed_at":"2015-12-22T03:47:34Z","pull_request":{"url":"https://api.github.com/repos/Fody/PropertyChanged/pulls/130","html_url":"https://github.com/Fody/PropertyChanged/pull/130","diff_url":"https://github.com/Fody/PropertyChanged/pull/130.diff","patch_url":"https://github.com/Fody/PropertyChanged/pull/130.patch"},"body":"When using PropertyChanged in a project that references obfuscated assemblies, a NullReferenceExceptions occurs in \"PropertyChanged.Fody/NotifyInterfaceFinder.cs\" because typeDefinition is not tested against null. Also, please add \".editorconfig\" so that one doesn't have to configure Visual Studio when working with different solutions (see editorconfig.org)."},"comment":{"url":"https://api.github.com/repos/Fody/PropertyChanged/issues/comments/166498423","html_url":"https://github.com/Fody/PropertyChanged/pull/130#issuecomment-166498423","issue_url":"https://api.github.com/repos/Fody/PropertyChanged/issues/130","id":166498423,"user":{"login":"SimonCropp","id":122666,"avatar_url":"https://avatars.githubusercontent.com/u/122666?v=3","gravatar_id":"","url":"https://api.github.com/users/SimonCropp","html_url":"https://github.com/SimonCropp","followers_url":"https://api.github.com/users/SimonCropp/followers","following_url":"https://api.github.com/users/SimonCropp/following{/other_user}","gists_url":"https://api.github.com/users/SimonCropp/gists{/gist_id}","starred_url":"https://api.github.com/users/SimonCropp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimonCropp/subscriptions","organizations_url":"https://api.github.com/users/SimonCropp/orgs","repos_url":"https://api.github.com/users/SimonCropp/repos","events_url":"https://api.github.com/users/SimonCropp/events{/privacy}","received_events_url":"https://api.github.com/users/SimonCropp/received_events","type":"User","site_admin":false},"created_at":"2015-12-22T03:47:34Z","updated_at":"2015-12-22T03:47:34Z","body":"closing this. we cant swallow exceptions when a ref fails to resolve. this could hide all kind of other problems. also this would be a problem over all weavers and not just this one. \r\n\r\nI suggest that, since an obfuscated assembly is still valid IL, you raise an issue in mono.cecil repo and upload the offending assembly"}}