{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/42435310","id":42435310,"diff_hunk":"@@ -118,8 +118,8 @@ private[hive] object HiveShim {\n    *\n    * @param functionClassName UDF class name\n    */\n-  private[hive] case class HiveFunctionWrapper(var functionClassName: String)\n-    extends java.io.Externalizable {\n+  private[hive] case class HiveFunctionWrapper(var functionClassName: String,\n+    var instance: AnyRef = null) extends java.io.Externalizable with Logging {","path":"sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveShim.scala","position":16,"original_position":16,"commit_id":"fd799a1163a47c2819ab8d91d2131968ab45871f","original_commit_id":"fd799a1163a47c2819ab8d91d2131968ab45871f","user":{"login":"JoshRosen","id":50748,"avatar_url":"https://avatars.githubusercontent.com/u/50748?v=3","gravatar_id":"","url":"https://api.github.com/users/JoshRosen","html_url":"https://github.com/JoshRosen","followers_url":"https://api.github.com/users/JoshRosen/followers","following_url":"https://api.github.com/users/JoshRosen/following{/other_user}","gists_url":"https://api.github.com/users/JoshRosen/gists{/gist_id}","starred_url":"https://api.github.com/users/JoshRosen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoshRosen/subscriptions","organizations_url":"https://api.github.com/users/JoshRosen/orgs","repos_url":"https://api.github.com/users/JoshRosen/repos","events_url":"https://api.github.com/users/JoshRosen/events{/privacy}","received_events_url":"https://api.github.com/users/JoshRosen/received_events","type":"User","site_admin":false},"body":"Actually, why does instance need to be public here?","created_at":"2015-10-19T22:39:05Z","updated_at":"2015-10-19T22:39:05Z","html_url":"https://github.com/apache/spark/pull/8354#discussion_r42435310","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/8354","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/42435310"},"html":{"href":"https://github.com/apache/spark/pull/8354#discussion_r42435310"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/8354"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/8354","id":43013729,"html_url":"https://github.com/apache/spark/pull/8354","diff_url":"https://github.com/apache/spark/pull/8354.diff","patch_url":"https://github.com/apache/spark/pull/8354.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/8354","number":8354,"state":"open","locked":false,"title":"[SPARK-10151] [SQL] Support invocation of hive macro","user":{"login":"navis","id":809395,"avatar_url":"https://avatars.githubusercontent.com/u/809395?v=3","gravatar_id":"","url":"https://api.github.com/users/navis","html_url":"https://github.com/navis","followers_url":"https://api.github.com/users/navis/followers","following_url":"https://api.github.com/users/navis/following{/other_user}","gists_url":"https://api.github.com/users/navis/gists{/gist_id}","starred_url":"https://api.github.com/users/navis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/navis/subscriptions","organizations_url":"https://api.github.com/users/navis/orgs","repos_url":"https://api.github.com/users/navis/repos","events_url":"https://api.github.com/users/navis/events{/privacy}","received_events_url":"https://api.github.com/users/navis/received_events","type":"User","site_admin":false},"body":"Macro in hive (which is GenericUDFMacro) contains real function inside of it but it's not conveyed to tasks, resulting null-pointer exception.","created_at":"2015-08-21T08:14:39Z","updated_at":"2015-10-19T22:39:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e4a037b0aab4da510a1a30202ea2921634f72cb2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/8354/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/8354/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/8354/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/fd799a1163a47c2819ab8d91d2131968ab45871f","head":{"label":"navis:SPARK-10151","ref":"SPARK-10151","sha":"fd799a1163a47c2819ab8d91d2131968ab45871f","user":{"login":"navis","id":809395,"avatar_url":"https://avatars.githubusercontent.com/u/809395?v=3","gravatar_id":"","url":"https://api.github.com/users/navis","html_url":"https://github.com/navis","followers_url":"https://api.github.com/users/navis/followers","following_url":"https://api.github.com/users/navis/following{/other_user}","gists_url":"https://api.github.com/users/navis/gists{/gist_id}","starred_url":"https://api.github.com/users/navis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/navis/subscriptions","organizations_url":"https://api.github.com/users/navis/orgs","repos_url":"https://api.github.com/users/navis/repos","events_url":"https://api.github.com/users/navis/events{/privacy}","received_events_url":"https://api.github.com/users/navis/received_events","type":"User","site_admin":false},"repo":{"id":36485276,"name":"spark","full_name":"navis/spark","owner":{"login":"navis","id":809395,"avatar_url":"https://avatars.githubusercontent.com/u/809395?v=3","gravatar_id":"","url":"https://api.github.com/users/navis","html_url":"https://github.com/navis","followers_url":"https://api.github.com/users/navis/followers","following_url":"https://api.github.com/users/navis/following{/other_user}","gists_url":"https://api.github.com/users/navis/gists{/gist_id}","starred_url":"https://api.github.com/users/navis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/navis/subscriptions","organizations_url":"https://api.github.com/users/navis/orgs","repos_url":"https://api.github.com/users/navis/repos","events_url":"https://api.github.com/users/navis/events{/privacy}","received_events_url":"https://api.github.com/users/navis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/navis/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/navis/spark","forks_url":"https://api.github.com/repos/navis/spark/forks","keys_url":"https://api.github.com/repos/navis/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/navis/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/navis/spark/teams","hooks_url":"https://api.github.com/repos/navis/spark/hooks","issue_events_url":"https://api.github.com/repos/navis/spark/issues/events{/number}","events_url":"https://api.github.com/repos/navis/spark/events","assignees_url":"https://api.github.com/repos/navis/spark/assignees{/user}","branches_url":"https://api.github.com/repos/navis/spark/branches{/branch}","tags_url":"https://api.github.com/repos/navis/spark/tags","blobs_url":"https://api.github.com/repos/navis/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/navis/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/navis/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/navis/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/navis/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/navis/spark/languages","stargazers_url":"https://api.github.com/repos/navis/spark/stargazers","contributors_url":"https://api.github.com/repos/navis/spark/contributors","subscribers_url":"https://api.github.com/repos/navis/spark/subscribers","subscription_url":"https://api.github.com/repos/navis/spark/subscription","commits_url":"https://api.github.com/repos/navis/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/navis/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/navis/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/navis/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/navis/spark/contents/{+path}","compare_url":"https://api.github.com/repos/navis/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/navis/spark/merges","archive_url":"https://api.github.com/repos/navis/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/navis/spark/downloads","issues_url":"https://api.github.com/repos/navis/spark/issues{/number}","pulls_url":"https://api.github.com/repos/navis/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/navis/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/navis/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/navis/spark/labels{/name}","releases_url":"https://api.github.com/repos/navis/spark/releases{/id}","created_at":"2015-05-29T06:08:05Z","updated_at":"2015-05-29T06:08:25Z","pushed_at":"2015-10-16T06:33:11Z","git_url":"git://github.com/navis/spark.git","ssh_url":"git@github.com:navis/spark.git","clone_url":"https://github.com/navis/spark.git","svn_url":"https://github.com/navis/spark","homepage":null,"size":290291,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"883bd8fccf83aae7a2a847c9a6ca129fac86e6a3","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","created_at":"2014-02-25T08:00:08Z","updated_at":"2015-10-19T18:50:48Z","pushed_at":"2015-10-19T22:38:15Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":1636152,"stargazers_count":5805,"watchers_count":5805,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5411,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":324,"forks":5411,"open_issues":324,"watchers":5805,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/8354"},"html":{"href":"https://github.com/apache/spark/pull/8354"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/8354"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/8354/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/8354/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/8354/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/fd799a1163a47c2819ab8d91d2131968ab45871f"}}}}