{"action":"created","issue":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/11758","labels_url":"https://api.github.com/repos/cms-sw/cmssw/issues/11758/labels{/name}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/11758/comments","events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/11758/events","html_url":"https://github.com/cms-sw/cmssw/pull/11758","id":111173701,"number":11758,"title":"Made static const in LimiDetails","user":{"login":"Dr15Jones","id":3757616,"avatar_url":"https://avatars.githubusercontent.com/u/3757616?v=3","gravatar_id":"","url":"https://api.github.com/users/Dr15Jones","html_url":"https://github.com/Dr15Jones","followers_url":"https://api.github.com/users/Dr15Jones/followers","following_url":"https://api.github.com/users/Dr15Jones/following{/other_user}","gists_url":"https://api.github.com/users/Dr15Jones/gists{/gist_id}","starred_url":"https://api.github.com/users/Dr15Jones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dr15Jones/subscriptions","organizations_url":"https://api.github.com/users/Dr15Jones/orgs","repos_url":"https://api.github.com/users/Dr15Jones/repos","events_url":"https://api.github.com/users/Dr15Jones/events{/privacy}","received_events_url":"https://api.github.com/users/Dr15Jones/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-available","name":"comparison-available","color":"009800"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/pending-signatures","name":"pending-signatures","color":"eb6420"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/reconstruction-pending","name":"reconstruction-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-approved","name":"tests-approved","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/55","html_url":"https://github.com/cms-sw/cmssw/milestones/Next%20CMSSW_7_6_X","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/55/labels","id":1176788,"number":55,"title":"Next CMSSW_7_6_X","description":"","creator":{"login":"smuzaffar","id":4115138,"avatar_url":"https://avatars.githubusercontent.com/u/4115138?v=3","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":93,"closed_issues":912,"state":"open","created_at":"2015-06-23T07:27:04Z","updated_at":"2015-10-15T14:03:56Z","due_on":null,"closed_at":null},"comments":9,"created_at":"2015-10-13T12:53:05Z","updated_at":"2015-10-15T14:18:37Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/11758","html_url":"https://github.com/cms-sw/cmssw/pull/11758","diff_url":"https://github.com/cms-sw/cmssw/pull/11758.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/11758.patch"},"body":"The class static member m_algoNames was changed to const and initialized\r\nat constructor time. Also seperated storage of dipalgoNames from\r\nalgoNames since if dipalgoNames() was called before algoNames() the\r\ncode would assert while the other direction was OK. Based on the\r\nimplementation of operator<< it appears that those two functions\r\nwere meant to have different contains with dipalgoNames() not containing\r\nthe results from algoNames()."},"comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments/148399514","html_url":"https://github.com/cms-sw/cmssw/pull/11758#issuecomment-148399514","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/11758","id":148399514,"user":{"login":"cvuosalo","id":5736159,"avatar_url":"https://avatars.githubusercontent.com/u/5736159?v=3","gravatar_id":"","url":"https://api.github.com/users/cvuosalo","html_url":"https://github.com/cvuosalo","followers_url":"https://api.github.com/users/cvuosalo/followers","following_url":"https://api.github.com/users/cvuosalo/following{/other_user}","gists_url":"https://api.github.com/users/cvuosalo/gists{/gist_id}","starred_url":"https://api.github.com/users/cvuosalo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cvuosalo/subscriptions","organizations_url":"https://api.github.com/users/cvuosalo/orgs","repos_url":"https://api.github.com/users/cvuosalo/repos","events_url":"https://api.github.com/users/cvuosalo/events{/privacy}","received_events_url":"https://api.github.com/users/cvuosalo/received_events","type":"User","site_admin":false},"created_at":"2015-10-15T14:18:37Z","updated_at":"2015-10-15T14:18:37Z","body":"+1\r\n\r\nFor #11758 87299675e4bc1405513d83dcb6206e5d4b925d1d\r\n\r\nMinor fixes to algorithm name storage in LimiDetails to convert static to const for thread safety. There should be no change in run-time behavior.\r\n\r\nThe code changes are satisfactory, and Jenkins [tests](https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11758/8860/summary.html) against baseline CMSSW_7_6_X_2015-10-14-1600 show no significant differences, as expected. "}}