{"action":"closed","issue":{"url":"https://api.github.com/repos/ola-ct/Qt-SESAM/issues/34","labels_url":"https://api.github.com/repos/ola-ct/Qt-SESAM/issues/34/labels{/name}","comments_url":"https://api.github.com/repos/ola-ct/Qt-SESAM/issues/34/comments","events_url":"https://api.github.com/repos/ola-ct/Qt-SESAM/issues/34/events","html_url":"https://github.com/ola-ct/Qt-SESAM/issues/34","id":106227732,"number":34,"title":"Separate master password from domain password","user":{"login":"digulla","id":159306,"avatar_url":"https://avatars.githubusercontent.com/u/159306?v=3","gravatar_id":"","url":"https://api.github.com/users/digulla","html_url":"https://github.com/digulla","followers_url":"https://api.github.com/users/digulla/followers","following_url":"https://api.github.com/users/digulla/following{/other_user}","gists_url":"https://api.github.com/users/digulla/gists{/gist_id}","starred_url":"https://api.github.com/users/digulla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/digulla/subscriptions","organizations_url":"https://api.github.com/users/digulla/orgs","repos_url":"https://api.github.com/users/digulla/repos","events_url":"https://api.github.com/users/digulla/events{/privacy}","received_events_url":"https://api.github.com/users/digulla/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ola-ct/Qt-SESAM/labels/invalid","name":"invalid","color":"e6e6e6"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-09-13T17:07:29Z","updated_at":"2015-09-13T17:51:12Z","closed_at":"2015-09-13T17:51:12Z","body":"The code generates the domain password like so:\r\n\r\n    const QByteArray &pwd =\r\n      d->domainSettings.domainName.toUtf8() +\r\n      d->domainSettings.userName.toUtf8() +\r\n      masterPassword;\r\n\r\nThis is great from a security perspective but bad for usability: If I change my master password, I have to reset all passwords for all web sites.\r\n\r\nSince the domain password already has a salt, my feeling is that including the master password doesn't add much to security."}}