{"action":"created","issue":{"url":"https://api.github.com/repos/mantidproject/mantid/issues/309","labels_url":"https://api.github.com/repos/mantidproject/mantid/issues/309/labels{/name}","comments_url":"https://api.github.com/repos/mantidproject/mantid/issues/309/comments","events_url":"https://api.github.com/repos/mantidproject/mantid/issues/309/events","html_url":"https://github.com/mantidproject/mantid/pull/309","id":59048473,"number":309,"title":"CheckWorkspacesMatch should use tolerance property on NumericAxis comparison","user":{"login":"DanNixon","id":4037377,"avatar_url":"https://avatars.githubusercontent.com/u/4037377?v=3","gravatar_id":"","url":"https://api.github.com/users/DanNixon","html_url":"https://github.com/DanNixon","followers_url":"https://api.github.com/users/DanNixon/followers","following_url":"https://api.github.com/users/DanNixon/following{/other_user}","gists_url":"https://api.github.com/users/DanNixon/gists{/gist_id}","starred_url":"https://api.github.com/users/DanNixon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanNixon/subscriptions","organizations_url":"https://api.github.com/users/DanNixon/orgs","repos_url":"https://api.github.com/users/DanNixon/repos","events_url":"https://api.github.com/users/DanNixon/events{/privacy}","received_events_url":"https://api.github.com/users/DanNixon/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/mantidproject/mantid/labels/Framework","name":"Framework","color":"fad8c7"},{"url":"https://api.github.com/repos/mantidproject/mantid/labels/High%20Priority","name":"High Priority","color":"e11d21"}],"state":"open","locked":false,"assignee":{"login":"quantumsteve","id":5920552,"avatar_url":"https://avatars.githubusercontent.com/u/5920552?v=3","gravatar_id":"","url":"https://api.github.com/users/quantumsteve","html_url":"https://github.com/quantumsteve","followers_url":"https://api.github.com/users/quantumsteve/followers","following_url":"https://api.github.com/users/quantumsteve/following{/other_user}","gists_url":"https://api.github.com/users/quantumsteve/gists{/gist_id}","starred_url":"https://api.github.com/users/quantumsteve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quantumsteve/subscriptions","organizations_url":"https://api.github.com/users/quantumsteve/orgs","repos_url":"https://api.github.com/users/quantumsteve/repos","events_url":"https://api.github.com/users/quantumsteve/events{/privacy}","received_events_url":"https://api.github.com/users/quantumsteve/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/mantidproject/mantid/milestones/2","html_url":"https://github.com/mantidproject/mantid/milestones/Release%203.4","labels_url":"https://api.github.com/repos/mantidproject/mantid/milestones/2/labels","id":922405,"number":2,"title":"Release 3.4","description":"This is a placeholder in git for the [trac Release 3.4 milestone](http://trac.mantidproject.org/mantid/milestone/Release%203.4)","creator":{"login":"OwenArnold","id":1109536,"avatar_url":"https://avatars.githubusercontent.com/u/1109536?v=3","gravatar_id":"","url":"https://api.github.com/users/OwenArnold","html_url":"https://github.com/OwenArnold","followers_url":"https://api.github.com/users/OwenArnold/followers","following_url":"https://api.github.com/users/OwenArnold/following{/other_user}","gists_url":"https://api.github.com/users/OwenArnold/gists{/gist_id}","starred_url":"https://api.github.com/users/OwenArnold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OwenArnold/subscriptions","organizations_url":"https://api.github.com/users/OwenArnold/orgs","repos_url":"https://api.github.com/users/OwenArnold/repos","events_url":"https://api.github.com/users/OwenArnold/events{/privacy}","received_events_url":"https://api.github.com/users/OwenArnold/received_events","type":"User","site_admin":false},"open_issues":27,"closed_issues":136,"state":"open","created_at":"2015-01-05T16:53:00Z","updated_at":"2015-02-26T19:46:56Z","due_on":"2015-05-01T23:00:00Z","closed_at":null},"comments":4,"created_at":"2015-02-26T10:04:02Z","updated_at":"2015-02-26T23:45:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mantidproject/mantid/pulls/309","html_url":"https://github.com/mantidproject/mantid/pull/309","diff_url":"https://github.com/mantidproject/mantid/pull/309.diff","patch_url":"https://github.com/mantidproject/mantid/pull/309.patch"},"body":"Fixes [#11179](http://trac.mantidproject.org/mantid/ticket/11179).\r\n\r\nTo test:\r\n- Review code changes and unit test\r\n- Load the files attached to the Trac ticket\r\n- Run CheckWorkspacesMatch on both pairs of workspaces, ensuring CheckAxis is enabled, CheckSpectraMap is disabled and tolerance is set to 1e-10\r\n- On master this fails, with this fix it should pass\r\n\r\nAll being well this should fix the failing system test on OSX 10.9."},"comment":{"url":"https://api.github.com/repos/mantidproject/mantid/issues/comments/76300463","html_url":"https://github.com/mantidproject/mantid/pull/309#issuecomment-76300463","issue_url":"https://api.github.com/repos/mantidproject/mantid/issues/309","id":76300463,"user":{"login":"quantumsteve","id":5920552,"avatar_url":"https://avatars.githubusercontent.com/u/5920552?v=3","gravatar_id":"","url":"https://api.github.com/users/quantumsteve","html_url":"https://github.com/quantumsteve","followers_url":"https://api.github.com/users/quantumsteve/followers","following_url":"https://api.github.com/users/quantumsteve/following{/other_user}","gists_url":"https://api.github.com/users/quantumsteve/gists{/gist_id}","starred_url":"https://api.github.com/users/quantumsteve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quantumsteve/subscriptions","organizations_url":"https://api.github.com/users/quantumsteve/orgs","repos_url":"https://api.github.com/users/quantumsteve/repos","events_url":"https://api.github.com/users/quantumsteve/events{/privacy}","received_events_url":"https://api.github.com/users/quantumsteve/received_events","type":"User","site_admin":false},"created_at":"2015-02-26T23:45:20Z","updated_at":"2015-02-26T23:45:20Z","body":"1) Would you please add unit tests for the special case when one or more of the values is Inf or NaN?\r\n\r\n2) I think this should replace the current behavior of `virtual bool operator==(const Axis &) const` because we should never use operator== to compare floating point values. Can we create an optional argument for the tolerance?\r\n\r\n3) Consider replacing your for loop with std::equal and a binary predicate.\r\n\r\n4) The system test is still failing on os x because m_values.size() is not equal.\r\n![screen shot 2015-02-26 at 6 08 25 pm](https://cloud.githubusercontent.com/assets/5920552/6404392/7805542c-bde5-11e4-8c12-cc85dfdbbe3a.png)\r\n"}}