{"action":"closed","issue":{"url":"https://api.github.com/repos/git-multimail/git-multimail/issues/119","labels_url":"https://api.github.com/repos/git-multimail/git-multimail/issues/119/labels{/name}","comments_url":"https://api.github.com/repos/git-multimail/git-multimail/issues/119/comments","events_url":"https://api.github.com/repos/git-multimail/git-multimail/issues/119/events","html_url":"https://github.com/git-multimail/git-multimail/issues/119","id":102445844,"number":119,"title":"gitolite's default \"config\" option filter is overly conservative, precluding usage of refFilter*Regex options (docs issue)","user":{"login":"pfalcon","id":500451,"avatar_url":"https://avatars.githubusercontent.com/u/500451?v=3","gravatar_id":"","url":"https://api.github.com/users/pfalcon","html_url":"https://github.com/pfalcon","followers_url":"https://api.github.com/users/pfalcon/followers","following_url":"https://api.github.com/users/pfalcon/following{/other_user}","gists_url":"https://api.github.com/users/pfalcon/gists{/gist_id}","starred_url":"https://api.github.com/users/pfalcon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfalcon/subscriptions","organizations_url":"https://api.github.com/users/pfalcon/orgs","repos_url":"https://api.github.com/users/pfalcon/repos","events_url":"https://api.github.com/users/pfalcon/events{/privacy}","received_events_url":"https://api.github.com/users/pfalcon/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-08-21T19:15:12Z","updated_at":"2015-08-21T20:03:51Z","closed_at":"2015-08-21T20:03:51Z","body":"See #118 for background. We tried to use multimailhook.refFilterInclusionRegex option, and had gitolite barf about suspicious chars in option value (a regex). So, we had to adjust UNSAFE_PATT setting in gitolite.rc (see patch below). Again, maybe worth mentioned that in gitolite.rc (just mention that UNSAFE_PATT may need to be adjusted in that file to give user a direction, and let them research and decide what would be \"safe\" setting for them).\r\n\r\n~~~~\r\n    gitolite.rc: Override and make more liberal UNSAFE_PATT.\r\n    \r\n    UNSAFE_PATT appears to be used to validate \"config\" directives in\r\n    gitolite.conf file (i.e. entries to be added to .git/config of\r\n    gitolite-managed repos). This changes is similar REMOTE_COMMAND_PATT\r\n    override applied previously. Specific cause is the need to specify a\r\n    regex for git-multimail hook.\r\n    \r\ndiff --git a/per-service/git-servers/roles/gitolite/templates/gitolite.rc b/per-service/git-servers/roles/gitolite/templates/gitolite.rc\r\nindex 1e74588..d7406e1 100644\r\n--- a/per-service/git-servers/roles/gitolite/templates/gitolite.rc\r\n+++ b/per-service/git-servers/roles/gitolite/templates/gitolite.rc\r\n@@ -190,6 +190,7 @@\r\n # Allow single quote appear in gitolite commands, useful e.g. with \"desc\"\r\n # command.\r\n $REMOTE_COMMAND_PATT = qr(^[-0-9a-zA-Z._\\@/+ :,\\%=']*$);\r\n+$UNSAFE_PATT         = qr([`~#\\&;<>]);\r\n \r\n # ------------------------------------------------------------------------------\r\n # per perl rules, this should be the last line in such a file:\r\n~~~~\r\n"}}