{"action":"created","issue":{"url":"https://api.github.com/repos/vivekanandan/ember-i18n-yaml-to-json/issues/1","labels_url":"https://api.github.com/repos/vivekanandan/ember-i18n-yaml-to-json/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/vivekanandan/ember-i18n-yaml-to-json/issues/1/comments","events_url":"https://api.github.com/repos/vivekanandan/ember-i18n-yaml-to-json/issues/1/events","html_url":"https://github.com/vivekanandan/ember-i18n-yaml-to-json/pull/1","id":106728020,"number":1,"title":"fix doctorMissingElements by not using eval","user":{"login":"mreq","id":1286942,"avatar_url":"https://avatars.githubusercontent.com/u/1286942?v=3","gravatar_id":"","url":"https://api.github.com/users/mreq","html_url":"https://github.com/mreq","followers_url":"https://api.github.com/users/mreq/followers","following_url":"https://api.github.com/users/mreq/following{/other_user}","gists_url":"https://api.github.com/users/mreq/gists{/gist_id}","starred_url":"https://api.github.com/users/mreq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mreq/subscriptions","organizations_url":"https://api.github.com/users/mreq/orgs","repos_url":"https://api.github.com/users/mreq/repos","events_url":"https://api.github.com/users/mreq/events{/privacy}","received_events_url":"https://api.github.com/users/mreq/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-09-16T08:48:44Z","updated_at":"2015-09-16T09:23:37Z","closed_at":"2015-09-16T09:22:52Z","pull_request":{"url":"https://api.github.com/repos/vivekanandan/ember-i18n-yaml-to-json/pulls/1","html_url":"https://github.com/vivekanandan/ember-i18n-yaml-to-json/pull/1","diff_url":"https://github.com/vivekanandan/ember-i18n-yaml-to-json/pull/1.diff","patch_url":"https://github.com/vivekanandan/ember-i18n-yaml-to-json/pull/1.patch"},"body":"`doctorMissingElements` fails when the yaml has a numeric/mixed key\r\n\r\nexample:\r\n\r\n```\r\nen:\r\n  whatever:\r\n    1x2: \"fails\"\r\n```\r\n\r\nerror:\r\n\r\n```\r\nUnexpected number\r\nSyntaxError: Unexpected number\r\n  at Object.YAMLToJSON.doctorMissingElements (node_modules/ember-i18n-yaml-to-json/index.js:59:39)\r\n  at Object.YAMLToJSON.doctorMissingElements (node_modules/ember-i18n-yaml-to-json/index.js:64:14)\r\n  at Object.YAMLToJSON.doctorMissingElements (node_modules/ember-i18n-yaml-to-json/index.js:64:14)\r\n  at Object.YAMLToJSON.convert (node_modules/ember-i18n-yaml-to-json/index.js:29:12)\r\n  at Object.<anonymous> (ember-cli-build.js:5:18)\r\n  at Module._compile (module.js:460:26)\r\n  at Object.Module._extensions..js (module.js:478:10)\r\n  at Module.load (module.js:355:32)\r\n  at Function.Module._load (module.js:310:12)\r\n  at Module.require (module.js:365:17)\r\n  at require (module.js:384:17)\r\n  at module.exports (node_modules/ember-cli/lib/utilities/find-build-file.js:19:19)\r\n  at Class.module.exports.Task.extend.setupBroccoliBuilder (node_modules/ember-cli/lib/models/builder.js:25:21)\r\n  at Class.module.exports.Task.extend.init (node_modules/ember-cli/lib/models/builder.js:50:10)\r\n  at new Class (node_modules/ember-cli/node_modules/core-object/core-object.js:18:12)\r\n  at Class.module.exports.Task.extend.run (node_modules/ember-cli/lib/tasks/serve.js:15:19)\r\n  at Class.<anonymous> (node_modules/ember-cli/lib/commands/serve.js:62:20)\r\n  at lib$rsvp$$internal$$tryCatch (node_modules/ember-cli/node_modules/rsvp/dist/rsvp.js:493:16)\r\n  at lib$rsvp$$internal$$invokeCallback (node_modules/ember-cli/node_modules/rsvp/dist/rsvp.js:505:17)\r\n  at lib$rsvp$$internal$$publish (node_modules/ember-cli/node_modules/rsvp/dist/rsvp.js:476:11)\r\n  at lib$rsvp$asap$$flush (node_modules/ember-cli/node_modules/rsvp/dist/rsvp.js:1198:9)\r\n  at process._tickCallback (node.js:355:11)\r\n```\r\n\r\nalso using `eval` is almost never a good idea ;)"},"comment":{"url":"https://api.github.com/repos/vivekanandan/ember-i18n-yaml-to-json/issues/comments/140683527","html_url":"https://github.com/vivekanandan/ember-i18n-yaml-to-json/pull/1#issuecomment-140683527","issue_url":"https://api.github.com/repos/vivekanandan/ember-i18n-yaml-to-json/issues/1","id":140683527,"user":{"login":"vivekanandan","id":1253440,"avatar_url":"https://avatars.githubusercontent.com/u/1253440?v=3","gravatar_id":"","url":"https://api.github.com/users/vivekanandan","html_url":"https://github.com/vivekanandan","followers_url":"https://api.github.com/users/vivekanandan/followers","following_url":"https://api.github.com/users/vivekanandan/following{/other_user}","gists_url":"https://api.github.com/users/vivekanandan/gists{/gist_id}","starred_url":"https://api.github.com/users/vivekanandan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vivekanandan/subscriptions","organizations_url":"https://api.github.com/users/vivekanandan/orgs","repos_url":"https://api.github.com/users/vivekanandan/repos","events_url":"https://api.github.com/users/vivekanandan/events{/privacy}","received_events_url":"https://api.github.com/users/vivekanandan/received_events","type":"User","site_admin":false},"created_at":"2015-09-16T09:23:37Z","updated_at":"2015-09-16T09:23:37Z","body":"Thanks mreq for the contribution. :+1: "}}