{"action":"closed","number":5486,"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/5486","id":50994386,"html_url":"https://github.com/ManageIQ/manageiq/pull/5486","diff_url":"https://github.com/ManageIQ/manageiq/pull/5486.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/5486.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/5486","number":5486,"state":"closed","locked":false,"title":"Refactor miq report result","user":{"login":"imtayadeway","id":1710874,"avatar_url":"https://avatars.githubusercontent.com/u/1710874?v=3","gravatar_id":"","url":"https://api.github.com/users/imtayadeway","html_url":"https://github.com/imtayadeway","followers_url":"https://api.github.com/users/imtayadeway/followers","following_url":"https://api.github.com/users/imtayadeway/following{/other_user}","gists_url":"https://api.github.com/users/imtayadeway/gists{/gist_id}","starred_url":"https://api.github.com/users/imtayadeway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imtayadeway/subscriptions","organizations_url":"https://api.github.com/users/imtayadeway/orgs","repos_url":"https://api.github.com/users/imtayadeway/repos","events_url":"https://api.github.com/users/imtayadeway/events{/privacy}","received_events_url":"https://api.github.com/users/imtayadeway/received_events","type":"User","site_admin":false},"body":"* Have BinaryBlob work out the appropriate serializer for its data_type\r\n* Add some specs\r\n* Rearrange BinaryBlob specs so they don't all have the same shared\r\n  setup\r\n* Use FactoryGirl.build instead of .create\r\n* Remove a useless else clause\r\n* Remove a useless comment\r\n\r\n*** \r\nI wanted to do some work to clean up a bit after https://github.com/ManageIQ/manageiq/pull/5420. Here's a first step by moving the logic done in `MiqReportResult#report_results` based on `BinaryBlob`'s data into `BinaryBlob`\r\n\r\nTested this in the UI and everything looks good.\r\n\r\ncc @gtanzillo \r\n@miq-bot add-label refactoring, reporting, core","created_at":"2015-11-17T19:44:34Z","updated_at":"2015-11-20T17:15:09Z","closed_at":"2015-11-20T17:15:09Z","merged_at":"2015-11-20T17:15:09Z","merge_commit_sha":"a465a5d86e7a61b170a408d5a1220568ed144154","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/5486/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/5486/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/5486/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/d8df7a63babe808c80a529baac059caa01b7f3ff","head":{"label":"imtayadeway:refactor-miq-report-result","ref":"refactor-miq-report-result","sha":"d8df7a63babe808c80a529baac059caa01b7f3ff","user":{"login":"imtayadeway","id":1710874,"avatar_url":"https://avatars.githubusercontent.com/u/1710874?v=3","gravatar_id":"","url":"https://api.github.com/users/imtayadeway","html_url":"https://github.com/imtayadeway","followers_url":"https://api.github.com/users/imtayadeway/followers","following_url":"https://api.github.com/users/imtayadeway/following{/other_user}","gists_url":"https://api.github.com/users/imtayadeway/gists{/gist_id}","starred_url":"https://api.github.com/users/imtayadeway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imtayadeway/subscriptions","organizations_url":"https://api.github.com/users/imtayadeway/orgs","repos_url":"https://api.github.com/users/imtayadeway/repos","events_url":"https://api.github.com/users/imtayadeway/events{/privacy}","received_events_url":"https://api.github.com/users/imtayadeway/received_events","type":"User","site_admin":false},"repo":{"id":34932503,"name":"manageiq","full_name":"imtayadeway/manageiq","owner":{"login":"imtayadeway","id":1710874,"avatar_url":"https://avatars.githubusercontent.com/u/1710874?v=3","gravatar_id":"","url":"https://api.github.com/users/imtayadeway","html_url":"https://github.com/imtayadeway","followers_url":"https://api.github.com/users/imtayadeway/followers","following_url":"https://api.github.com/users/imtayadeway/following{/other_user}","gists_url":"https://api.github.com/users/imtayadeway/gists{/gist_id}","starred_url":"https://api.github.com/users/imtayadeway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imtayadeway/subscriptions","organizations_url":"https://api.github.com/users/imtayadeway/orgs","repos_url":"https://api.github.com/users/imtayadeway/repos","events_url":"https://api.github.com/users/imtayadeway/events{/privacy}","received_events_url":"https://api.github.com/users/imtayadeway/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/imtayadeway/manageiq","description":"ManageIQ Cloud Management Platform","fork":true,"url":"https://api.github.com/repos/imtayadeway/manageiq","forks_url":"https://api.github.com/repos/imtayadeway/manageiq/forks","keys_url":"https://api.github.com/repos/imtayadeway/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/imtayadeway/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/imtayadeway/manageiq/teams","hooks_url":"https://api.github.com/repos/imtayadeway/manageiq/hooks","issue_events_url":"https://api.github.com/repos/imtayadeway/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/imtayadeway/manageiq/events","assignees_url":"https://api.github.com/repos/imtayadeway/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/imtayadeway/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/imtayadeway/manageiq/tags","blobs_url":"https://api.github.com/repos/imtayadeway/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/imtayadeway/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/imtayadeway/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/imtayadeway/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/imtayadeway/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/imtayadeway/manageiq/languages","stargazers_url":"https://api.github.com/repos/imtayadeway/manageiq/stargazers","contributors_url":"https://api.github.com/repos/imtayadeway/manageiq/contributors","subscribers_url":"https://api.github.com/repos/imtayadeway/manageiq/subscribers","subscription_url":"https://api.github.com/repos/imtayadeway/manageiq/subscription","commits_url":"https://api.github.com/repos/imtayadeway/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/imtayadeway/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/imtayadeway/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/imtayadeway/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/imtayadeway/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/imtayadeway/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/imtayadeway/manageiq/merges","archive_url":"https://api.github.com/repos/imtayadeway/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/imtayadeway/manageiq/downloads","issues_url":"https://api.github.com/repos/imtayadeway/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/imtayadeway/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/imtayadeway/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/imtayadeway/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/imtayadeway/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/imtayadeway/manageiq/releases{/id}","created_at":"2015-05-02T02:08:43Z","updated_at":"2015-05-02T02:09:00Z","pushed_at":"2015-11-19T01:09:40Z","git_url":"git://github.com/imtayadeway/manageiq.git","ssh_url":"git@github.com:imtayadeway/manageiq.git","clone_url":"https://github.com/imtayadeway/manageiq.git","svn_url":"https://github.com/imtayadeway/manageiq","homepage":"manageiq.org","size":115977,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"05fb4ddb960e35048146d9c8ebd25b545b68edf7","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":20789757,"name":"manageiq","full_name":"ManageIQ/manageiq","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq","description":"ManageIQ Cloud Management Platform","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq","forks_url":"https://api.github.com/repos/ManageIQ/manageiq/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq/releases{/id}","created_at":"2014-06-13T02:31:26Z","updated_at":"2015-11-19T14:12:43Z","pushed_at":"2015-11-20T17:15:09Z","git_url":"git://github.com/ManageIQ/manageiq.git","ssh_url":"git@github.com:ManageIQ/manageiq.git","clone_url":"https://github.com/ManageIQ/manageiq.git","svn_url":"https://github.com/ManageIQ/manageiq","homepage":"manageiq.org","size":128625,"stargazers_count":168,"watchers_count":168,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":185,"mirror_url":null,"open_issues_count":438,"forks":185,"open_issues":438,"watchers":168,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/5486"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/5486"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/5486"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/5486/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/5486/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/5486/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq/statuses/d8df7a63babe808c80a529baac059caa01b7f3ff"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"Fryguy","id":52120,"avatar_url":"https://avatars.githubusercontent.com/u/52120?v=3","gravatar_id":"","url":"https://api.github.com/users/Fryguy","html_url":"https://github.com/Fryguy","followers_url":"https://api.github.com/users/Fryguy/followers","following_url":"https://api.github.com/users/Fryguy/following{/other_user}","gists_url":"https://api.github.com/users/Fryguy/gists{/gist_id}","starred_url":"https://api.github.com/users/Fryguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fryguy/subscriptions","organizations_url":"https://api.github.com/users/Fryguy/orgs","repos_url":"https://api.github.com/users/Fryguy/repos","events_url":"https://api.github.com/users/Fryguy/events{/privacy}","received_events_url":"https://api.github.com/users/Fryguy/received_events","type":"User","site_admin":false},"comments":6,"review_comments":5,"commits":6,"additions":67,"deletions":28,"changed_files":3}}