{"action":"closed","number":4985,"pull_request":{"url":"https://api.github.com/repos/facebook/hhvm/pulls/4985","id":30836385,"html_url":"https://github.com/facebook/hhvm/pull/4985","diff_url":"https://github.com/facebook/hhvm/pull/4985.diff","patch_url":"https://github.com/facebook/hhvm/pull/4985.patch","issue_url":"https://api.github.com/repos/facebook/hhvm/issues/4985","number":4985,"state":"closed","locked":false,"title":"Make DoublyLinkedList ArrayAcces work with LIFO","user":{"login":"SiebelsTim","id":1153003,"avatar_url":"https://avatars.githubusercontent.com/u/1153003?v=3","gravatar_id":"","url":"https://api.github.com/users/SiebelsTim","html_url":"https://github.com/SiebelsTim","followers_url":"https://api.github.com/users/SiebelsTim/followers","following_url":"https://api.github.com/users/SiebelsTim/following{/other_user}","gists_url":"https://api.github.com/users/SiebelsTim/gists{/gist_id}","starred_url":"https://api.github.com/users/SiebelsTim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SiebelsTim/subscriptions","organizations_url":"https://api.github.com/users/SiebelsTim/orgs","repos_url":"https://api.github.com/users/SiebelsTim/repos","events_url":"https://api.github.com/users/SiebelsTim/events{/privacy}","received_events_url":"https://api.github.com/users/SiebelsTim/received_events","type":"User","site_admin":false},"body":"These weren't implemented before. I tried to mitigate redundant special casing everywhere with the two helper functions inside _SplDoublyLinkedListNode\r\n\r\nFixes #4984\r\n\r\nTest Plan:\r\nzend/good and slow/ext_spl_datastructures","created_at":"2015-03-10T10:06:59Z","updated_at":"2015-04-06T17:42:48Z","closed_at":"2015-04-06T17:42:48Z","merged_at":null,"merge_commit_sha":"43288a71f91a8b64a77c17b211fd07f3ab256bea","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/facebook/hhvm/pulls/4985/commits","review_comments_url":"https://api.github.com/repos/facebook/hhvm/pulls/4985/comments","review_comment_url":"https://api.github.com/repos/facebook/hhvm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/hhvm/issues/4985/comments","statuses_url":"https://api.github.com/repos/facebook/hhvm/statuses/f28a36f5dd82787e6955e7e05dd9a876c9a5ff30","head":{"label":"SiebelsTim:dll-arrayaccess","ref":"dll-arrayaccess","sha":"f28a36f5dd82787e6955e7e05dd9a876c9a5ff30","user":{"login":"SiebelsTim","id":1153003,"avatar_url":"https://avatars.githubusercontent.com/u/1153003?v=3","gravatar_id":"","url":"https://api.github.com/users/SiebelsTim","html_url":"https://github.com/SiebelsTim","followers_url":"https://api.github.com/users/SiebelsTim/followers","following_url":"https://api.github.com/users/SiebelsTim/following{/other_user}","gists_url":"https://api.github.com/users/SiebelsTim/gists{/gist_id}","starred_url":"https://api.github.com/users/SiebelsTim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SiebelsTim/subscriptions","organizations_url":"https://api.github.com/users/SiebelsTim/orgs","repos_url":"https://api.github.com/users/SiebelsTim/repos","events_url":"https://api.github.com/users/SiebelsTim/events{/privacy}","received_events_url":"https://api.github.com/users/SiebelsTim/received_events","type":"User","site_admin":false},"repo":{"id":18767988,"name":"hhvm","full_name":"SiebelsTim/hhvm","owner":{"login":"SiebelsTim","id":1153003,"avatar_url":"https://avatars.githubusercontent.com/u/1153003?v=3","gravatar_id":"","url":"https://api.github.com/users/SiebelsTim","html_url":"https://github.com/SiebelsTim","followers_url":"https://api.github.com/users/SiebelsTim/followers","following_url":"https://api.github.com/users/SiebelsTim/following{/other_user}","gists_url":"https://api.github.com/users/SiebelsTim/gists{/gist_id}","starred_url":"https://api.github.com/users/SiebelsTim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SiebelsTim/subscriptions","organizations_url":"https://api.github.com/users/SiebelsTim/orgs","repos_url":"https://api.github.com/users/SiebelsTim/repos","events_url":"https://api.github.com/users/SiebelsTim/events{/privacy}","received_events_url":"https://api.github.com/users/SiebelsTim/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SiebelsTim/hhvm","description":"HHVM is an open-source virtual machine designed for executing programs written in Hack and PHP. HHVM uses a just-in-time (JIT) compilation approach to achieve superior performance while maintaining the flexibility that PHP developers are accustomed to.","fork":true,"url":"https://api.github.com/repos/SiebelsTim/hhvm","forks_url":"https://api.github.com/repos/SiebelsTim/hhvm/forks","keys_url":"https://api.github.com/repos/SiebelsTim/hhvm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SiebelsTim/hhvm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SiebelsTim/hhvm/teams","hooks_url":"https://api.github.com/repos/SiebelsTim/hhvm/hooks","issue_events_url":"https://api.github.com/repos/SiebelsTim/hhvm/issues/events{/number}","events_url":"https://api.github.com/repos/SiebelsTim/hhvm/events","assignees_url":"https://api.github.com/repos/SiebelsTim/hhvm/assignees{/user}","branches_url":"https://api.github.com/repos/SiebelsTim/hhvm/branches{/branch}","tags_url":"https://api.github.com/repos/SiebelsTim/hhvm/tags","blobs_url":"https://api.github.com/repos/SiebelsTim/hhvm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SiebelsTim/hhvm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SiebelsTim/hhvm/git/refs{/sha}","trees_url":"https://api.github.com/repos/SiebelsTim/hhvm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SiebelsTim/hhvm/statuses/{sha}","languages_url":"https://api.github.com/repos/SiebelsTim/hhvm/languages","stargazers_url":"https://api.github.com/repos/SiebelsTim/hhvm/stargazers","contributors_url":"https://api.github.com/repos/SiebelsTim/hhvm/contributors","subscribers_url":"https://api.github.com/repos/SiebelsTim/hhvm/subscribers","subscription_url":"https://api.github.com/repos/SiebelsTim/hhvm/subscription","commits_url":"https://api.github.com/repos/SiebelsTim/hhvm/commits{/sha}","git_commits_url":"https://api.github.com/repos/SiebelsTim/hhvm/git/commits{/sha}","comments_url":"https://api.github.com/repos/SiebelsTim/hhvm/comments{/number}","issue_comment_url":"https://api.github.com/repos/SiebelsTim/hhvm/issues/comments{/number}","contents_url":"https://api.github.com/repos/SiebelsTim/hhvm/contents/{+path}","compare_url":"https://api.github.com/repos/SiebelsTim/hhvm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SiebelsTim/hhvm/merges","archive_url":"https://api.github.com/repos/SiebelsTim/hhvm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SiebelsTim/hhvm/downloads","issues_url":"https://api.github.com/repos/SiebelsTim/hhvm/issues{/number}","pulls_url":"https://api.github.com/repos/SiebelsTim/hhvm/pulls{/number}","milestones_url":"https://api.github.com/repos/SiebelsTim/hhvm/milestones{/number}","notifications_url":"https://api.github.com/repos/SiebelsTim/hhvm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SiebelsTim/hhvm/labels{/name}","releases_url":"https://api.github.com/repos/SiebelsTim/hhvm/releases{/id}","created_at":"2014-04-14T16:33:47Z","updated_at":"2015-02-05T19:29:57Z","pushed_at":"2015-03-23T21:09:58Z","git_url":"git://github.com/SiebelsTim/hhvm.git","ssh_url":"git@github.com:SiebelsTim/hhvm.git","clone_url":"https://github.com/SiebelsTim/hhvm.git","svn_url":"https://github.com/SiebelsTim/hhvm","homepage":"http://hhvm.com","size":193036,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"037e616b5b2a917e113ec9a1f71fa8e58b957ad7","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":455600,"name":"hhvm","full_name":"facebook/hhvm","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/hhvm","description":"A virtual machine designed for executing programs written in Hack and PHP. ","fork":false,"url":"https://api.github.com/repos/facebook/hhvm","forks_url":"https://api.github.com/repos/facebook/hhvm/forks","keys_url":"https://api.github.com/repos/facebook/hhvm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/hhvm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/hhvm/teams","hooks_url":"https://api.github.com/repos/facebook/hhvm/hooks","issue_events_url":"https://api.github.com/repos/facebook/hhvm/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/hhvm/events","assignees_url":"https://api.github.com/repos/facebook/hhvm/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/hhvm/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/hhvm/tags","blobs_url":"https://api.github.com/repos/facebook/hhvm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/hhvm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/hhvm/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/hhvm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/hhvm/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/hhvm/languages","stargazers_url":"https://api.github.com/repos/facebook/hhvm/stargazers","contributors_url":"https://api.github.com/repos/facebook/hhvm/contributors","subscribers_url":"https://api.github.com/repos/facebook/hhvm/subscribers","subscription_url":"https://api.github.com/repos/facebook/hhvm/subscription","commits_url":"https://api.github.com/repos/facebook/hhvm/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/hhvm/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/hhvm/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/hhvm/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/hhvm/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/hhvm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/hhvm/merges","archive_url":"https://api.github.com/repos/facebook/hhvm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/hhvm/downloads","issues_url":"https://api.github.com/repos/facebook/hhvm/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/hhvm/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/hhvm/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/hhvm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/hhvm/labels{/name}","releases_url":"https://api.github.com/repos/facebook/hhvm/releases{/id}","created_at":"2010-01-02T01:17:06Z","updated_at":"2015-04-06T17:42:44Z","pushed_at":"2015-04-06T17:42:44Z","git_url":"git://github.com/facebook/hhvm.git","ssh_url":"git@github.com:facebook/hhvm.git","clone_url":"https://github.com/facebook/hhvm.git","svn_url":"https://github.com/facebook/hhvm","homepage":"http://hhvm.com","size":397556,"stargazers_count":11526,"watchers_count":11526,"language":"C++","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":2030,"mirror_url":null,"open_issues_count":666,"forks":2030,"open_issues":666,"watchers":11526,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/hhvm/pulls/4985"},"html":{"href":"https://github.com/facebook/hhvm/pull/4985"},"issue":{"href":"https://api.github.com/repos/facebook/hhvm/issues/4985"},"comments":{"href":"https://api.github.com/repos/facebook/hhvm/issues/4985/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/hhvm/pulls/4985/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/hhvm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/hhvm/pulls/4985/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/hhvm/statuses/f28a36f5dd82787e6955e7e05dd9a876c9a5ff30"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":1,"review_comments":0,"commits":3,"additions":130,"deletions":15,"changed_files":3}}