{"action":"closed","number":12,"pull_request":{"url":"https://api.github.com/repos/krockode/x_x/pulls/12","id":32043510,"html_url":"https://github.com/krockode/x_x/pull/12","diff_url":"https://github.com/krockode/x_x/pull/12.diff","patch_url":"https://github.com/krockode/x_x/pull/12.patch","issue_url":"https://api.github.com/repos/krockode/x_x/issues/12","number":12,"state":"closed","locked":false,"title":"Added CSV Support","user":{"login":"jackmaney","id":1554625,"avatar_url":"https://avatars.githubusercontent.com/u/1554625?v=3","gravatar_id":"","url":"https://api.github.com/users/jackmaney","html_url":"https://github.com/jackmaney","followers_url":"https://api.github.com/users/jackmaney/followers","following_url":"https://api.github.com/users/jackmaney/following{/other_user}","gists_url":"https://api.github.com/users/jackmaney/gists{/gist_id}","starred_url":"https://api.github.com/users/jackmaney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackmaney/subscriptions","organizations_url":"https://api.github.com/users/jackmaney/orgs","repos_url":"https://api.github.com/users/jackmaney/repos","events_url":"https://api.github.com/users/jackmaney/events{/privacy}","received_events_url":"https://api.github.com/users/jackmaney/received_events","type":"User","site_admin":false},"body":"* Added the following CLI options:\r\n\r\n    * `--file-type`: If enabled, must be one of `csv` or `excel`. This forces parsing of the file to the given file type. If not enabled, then the file is treated as a CSV if it ends in `.csv` and is treated as Excel otherwise.\r\n\r\n    * `--delimiter` and `--quotechar`: CSV-only options that are passed directly into the CSV reader (defaults of `','` and `'\"'`, respectively, of course).\r\n\r\n    * `--encoding`: Allows the user to specify the file encoding (default of `utf-8`).\r\n\r\n* Refactored the API for `XCursor` so that it could be easily extended to `CSVCursor`, and moved the cursor classes into a `cursor` module.\r\n\r\n* Since `CSVCursor` has the same API as `XCursor` (and which is compatible with the previous (external) `XCursor` API), it can be passed into `asciitable.draw` with no problems.\r\n\r\n* Changed `out` to a pipe (rather than just the pipe's `stdin`), disabled buffering on the `out` pipe and closed `out.stdin` at the end of `asciitable.draw` to help prevent errors when `less` is exited prematurely.\r\n\r\n* Refactored most of the 2 vs 3 compatibility pieces into a `compat` module.\r\n\r\n* Updated README, adding some relevant docs for these changes.","created_at":"2015-03-26T17:55:47Z","updated_at":"2015-03-26T23:56:25Z","closed_at":"2015-03-26T23:56:25Z","merged_at":"2015-03-26T23:56:25Z","merge_commit_sha":"f334c95f00c33e9b503cac944977e695b8a10ee2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/krockode/x_x/pulls/12/commits","review_comments_url":"https://api.github.com/repos/krockode/x_x/pulls/12/comments","review_comment_url":"https://api.github.com/repos/krockode/x_x/pulls/comments{/number}","comments_url":"https://api.github.com/repos/krockode/x_x/issues/12/comments","statuses_url":"https://api.github.com/repos/krockode/x_x/statuses/a9921cea77611f6fd55e8ab6dd77f5a435c393e4","head":{"label":"jackmaney:csv","ref":"csv","sha":"a9921cea77611f6fd55e8ab6dd77f5a435c393e4","user":{"login":"jackmaney","id":1554625,"avatar_url":"https://avatars.githubusercontent.com/u/1554625?v=3","gravatar_id":"","url":"https://api.github.com/users/jackmaney","html_url":"https://github.com/jackmaney","followers_url":"https://api.github.com/users/jackmaney/followers","following_url":"https://api.github.com/users/jackmaney/following{/other_user}","gists_url":"https://api.github.com/users/jackmaney/gists{/gist_id}","starred_url":"https://api.github.com/users/jackmaney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackmaney/subscriptions","organizations_url":"https://api.github.com/users/jackmaney/orgs","repos_url":"https://api.github.com/users/jackmaney/repos","events_url":"https://api.github.com/users/jackmaney/events{/privacy}","received_events_url":"https://api.github.com/users/jackmaney/received_events","type":"User","site_admin":false},"repo":{"id":32809438,"name":"x_x","full_name":"jackmaney/x_x","owner":{"login":"jackmaney","id":1554625,"avatar_url":"https://avatars.githubusercontent.com/u/1554625?v=3","gravatar_id":"","url":"https://api.github.com/users/jackmaney","html_url":"https://github.com/jackmaney","followers_url":"https://api.github.com/users/jackmaney/followers","following_url":"https://api.github.com/users/jackmaney/following{/other_user}","gists_url":"https://api.github.com/users/jackmaney/gists{/gist_id}","starred_url":"https://api.github.com/users/jackmaney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackmaney/subscriptions","organizations_url":"https://api.github.com/users/jackmaney/orgs","repos_url":"https://api.github.com/users/jackmaney/repos","events_url":"https://api.github.com/users/jackmaney/events{/privacy}","received_events_url":"https://api.github.com/users/jackmaney/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jackmaney/x_x","description":"excel file viewer cli","fork":true,"url":"https://api.github.com/repos/jackmaney/x_x","forks_url":"https://api.github.com/repos/jackmaney/x_x/forks","keys_url":"https://api.github.com/repos/jackmaney/x_x/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jackmaney/x_x/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jackmaney/x_x/teams","hooks_url":"https://api.github.com/repos/jackmaney/x_x/hooks","issue_events_url":"https://api.github.com/repos/jackmaney/x_x/issues/events{/number}","events_url":"https://api.github.com/repos/jackmaney/x_x/events","assignees_url":"https://api.github.com/repos/jackmaney/x_x/assignees{/user}","branches_url":"https://api.github.com/repos/jackmaney/x_x/branches{/branch}","tags_url":"https://api.github.com/repos/jackmaney/x_x/tags","blobs_url":"https://api.github.com/repos/jackmaney/x_x/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jackmaney/x_x/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jackmaney/x_x/git/refs{/sha}","trees_url":"https://api.github.com/repos/jackmaney/x_x/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jackmaney/x_x/statuses/{sha}","languages_url":"https://api.github.com/repos/jackmaney/x_x/languages","stargazers_url":"https://api.github.com/repos/jackmaney/x_x/stargazers","contributors_url":"https://api.github.com/repos/jackmaney/x_x/contributors","subscribers_url":"https://api.github.com/repos/jackmaney/x_x/subscribers","subscription_url":"https://api.github.com/repos/jackmaney/x_x/subscription","commits_url":"https://api.github.com/repos/jackmaney/x_x/commits{/sha}","git_commits_url":"https://api.github.com/repos/jackmaney/x_x/git/commits{/sha}","comments_url":"https://api.github.com/repos/jackmaney/x_x/comments{/number}","issue_comment_url":"https://api.github.com/repos/jackmaney/x_x/issues/comments{/number}","contents_url":"https://api.github.com/repos/jackmaney/x_x/contents/{+path}","compare_url":"https://api.github.com/repos/jackmaney/x_x/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jackmaney/x_x/merges","archive_url":"https://api.github.com/repos/jackmaney/x_x/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jackmaney/x_x/downloads","issues_url":"https://api.github.com/repos/jackmaney/x_x/issues{/number}","pulls_url":"https://api.github.com/repos/jackmaney/x_x/pulls{/number}","milestones_url":"https://api.github.com/repos/jackmaney/x_x/milestones{/number}","notifications_url":"https://api.github.com/repos/jackmaney/x_x/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jackmaney/x_x/labels{/name}","releases_url":"https://api.github.com/repos/jackmaney/x_x/releases{/id}","created_at":"2015-03-24T16:03:51Z","updated_at":"2015-03-26T19:50:26Z","pushed_at":"2015-03-26T19:50:26Z","git_url":"git://github.com/jackmaney/x_x.git","ssh_url":"git@github.com:jackmaney/x_x.git","clone_url":"https://github.com/jackmaney/x_x.git","svn_url":"https://github.com/jackmaney/x_x","homepage":"","size":204,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"krockode:master","ref":"master","sha":"f1c81c384ab9e3f9066b5dc9e564769ab54de4b6","user":{"login":"krockode","id":1023780,"avatar_url":"https://avatars.githubusercontent.com/u/1023780?v=3","gravatar_id":"","url":"https://api.github.com/users/krockode","html_url":"https://github.com/krockode","followers_url":"https://api.github.com/users/krockode/followers","following_url":"https://api.github.com/users/krockode/following{/other_user}","gists_url":"https://api.github.com/users/krockode/gists{/gist_id}","starred_url":"https://api.github.com/users/krockode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krockode/subscriptions","organizations_url":"https://api.github.com/users/krockode/orgs","repos_url":"https://api.github.com/users/krockode/repos","events_url":"https://api.github.com/users/krockode/events{/privacy}","received_events_url":"https://api.github.com/users/krockode/received_events","type":"User","site_admin":false},"repo":{"id":28957038,"name":"x_x","full_name":"krockode/x_x","owner":{"login":"krockode","id":1023780,"avatar_url":"https://avatars.githubusercontent.com/u/1023780?v=3","gravatar_id":"","url":"https://api.github.com/users/krockode","html_url":"https://github.com/krockode","followers_url":"https://api.github.com/users/krockode/followers","following_url":"https://api.github.com/users/krockode/following{/other_user}","gists_url":"https://api.github.com/users/krockode/gists{/gist_id}","starred_url":"https://api.github.com/users/krockode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krockode/subscriptions","organizations_url":"https://api.github.com/users/krockode/orgs","repos_url":"https://api.github.com/users/krockode/repos","events_url":"https://api.github.com/users/krockode/events{/privacy}","received_events_url":"https://api.github.com/users/krockode/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/krockode/x_x","description":"excel file viewer cli","fork":false,"url":"https://api.github.com/repos/krockode/x_x","forks_url":"https://api.github.com/repos/krockode/x_x/forks","keys_url":"https://api.github.com/repos/krockode/x_x/keys{/key_id}","collaborators_url":"https://api.github.com/repos/krockode/x_x/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/krockode/x_x/teams","hooks_url":"https://api.github.com/repos/krockode/x_x/hooks","issue_events_url":"https://api.github.com/repos/krockode/x_x/issues/events{/number}","events_url":"https://api.github.com/repos/krockode/x_x/events","assignees_url":"https://api.github.com/repos/krockode/x_x/assignees{/user}","branches_url":"https://api.github.com/repos/krockode/x_x/branches{/branch}","tags_url":"https://api.github.com/repos/krockode/x_x/tags","blobs_url":"https://api.github.com/repos/krockode/x_x/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/krockode/x_x/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/krockode/x_x/git/refs{/sha}","trees_url":"https://api.github.com/repos/krockode/x_x/git/trees{/sha}","statuses_url":"https://api.github.com/repos/krockode/x_x/statuses/{sha}","languages_url":"https://api.github.com/repos/krockode/x_x/languages","stargazers_url":"https://api.github.com/repos/krockode/x_x/stargazers","contributors_url":"https://api.github.com/repos/krockode/x_x/contributors","subscribers_url":"https://api.github.com/repos/krockode/x_x/subscribers","subscription_url":"https://api.github.com/repos/krockode/x_x/subscription","commits_url":"https://api.github.com/repos/krockode/x_x/commits{/sha}","git_commits_url":"https://api.github.com/repos/krockode/x_x/git/commits{/sha}","comments_url":"https://api.github.com/repos/krockode/x_x/comments{/number}","issue_comment_url":"https://api.github.com/repos/krockode/x_x/issues/comments{/number}","contents_url":"https://api.github.com/repos/krockode/x_x/contents/{+path}","compare_url":"https://api.github.com/repos/krockode/x_x/compare/{base}...{head}","merges_url":"https://api.github.com/repos/krockode/x_x/merges","archive_url":"https://api.github.com/repos/krockode/x_x/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/krockode/x_x/downloads","issues_url":"https://api.github.com/repos/krockode/x_x/issues{/number}","pulls_url":"https://api.github.com/repos/krockode/x_x/pulls{/number}","milestones_url":"https://api.github.com/repos/krockode/x_x/milestones{/number}","notifications_url":"https://api.github.com/repos/krockode/x_x/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/krockode/x_x/labels{/name}","releases_url":"https://api.github.com/repos/krockode/x_x/releases{/id}","created_at":"2015-01-08T08:45:41Z","updated_at":"2015-03-26T23:46:13Z","pushed_at":"2015-03-26T23:56:25Z","git_url":"git://github.com/krockode/x_x.git","ssh_url":"git@github.com:krockode/x_x.git","clone_url":"https://github.com/krockode/x_x.git","svn_url":"https://github.com/krockode/x_x","homepage":"","size":204,"stargazers_count":337,"watchers_count":337,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":4,"forks":9,"open_issues":4,"watchers":337,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/krockode/x_x/pulls/12"},"html":{"href":"https://github.com/krockode/x_x/pull/12"},"issue":{"href":"https://api.github.com/repos/krockode/x_x/issues/12"},"comments":{"href":"https://api.github.com/repos/krockode/x_x/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/krockode/x_x/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/krockode/x_x/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/krockode/x_x/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/krockode/x_x/statuses/a9921cea77611f6fd55e8ab6dd77f5a435c393e4"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"krockode","id":1023780,"avatar_url":"https://avatars.githubusercontent.com/u/1023780?v=3","gravatar_id":"","url":"https://api.github.com/users/krockode","html_url":"https://github.com/krockode","followers_url":"https://api.github.com/users/krockode/followers","following_url":"https://api.github.com/users/krockode/following{/other_user}","gists_url":"https://api.github.com/users/krockode/gists{/gist_id}","starred_url":"https://api.github.com/users/krockode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krockode/subscriptions","organizations_url":"https://api.github.com/users/krockode/orgs","repos_url":"https://api.github.com/users/krockode/repos","events_url":"https://api.github.com/users/krockode/events{/privacy}","received_events_url":"https://api.github.com/users/krockode/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":229,"deletions":64,"changed_files":6}}