{"action":"created","issue":{"url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/issues/541","labels_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/issues/541/labels{/name}","comments_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/issues/541/comments","events_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/issues/541/events","html_url":"https://github.com/hpcugent/easybuild-easyblocks/pull/541","id":55283117,"number":541,"title":"Fix/suitesparse","user":{"login":"gjbex","id":4801336,"avatar_url":"https://avatars.githubusercontent.com/u/4801336?v=3","gravatar_id":"","url":"https://api.github.com/users/gjbex","html_url":"https://github.com/gjbex","followers_url":"https://api.github.com/users/gjbex/followers","following_url":"https://api.github.com/users/gjbex/following{/other_user}","gists_url":"https://api.github.com/users/gjbex/gists{/gist_id}","starred_url":"https://api.github.com/users/gjbex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gjbex/subscriptions","organizations_url":"https://api.github.com/users/gjbex/orgs","repos_url":"https://api.github.com/users/gjbex/repos","events_url":"https://api.github.com/users/gjbex/events{/privacy}","received_events_url":"https://api.github.com/users/gjbex/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":10,"created_at":"2015-01-23T13:50:47Z","updated_at":"2015-01-26T23:35:08Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/pulls/541","html_url":"https://github.com/hpcugent/easybuild-easyblocks/pull/541","diff_url":"https://github.com/hpcugent/easybuild-easyblocks/pull/541.diff","patch_url":"https://github.com/hpcugent/easybuild-easyblocks/pull/541.patch"},"body":"Fixed two problems with this easyblock:\r\n1) it assumes variable definitions in the .mk file will not have leading whitespace (assumption doesn't hold for SuiteSparse 4.4.3),\r\n2) the mechanism for ensuring that all variables not replaced in the .mk file are appended works only if the variable name does not occur in any line (e.g., comment) prior to its definition (definitely not the case in SuiteSparse 4.4.3).\r\n\r\nAlthough the current code works, it is not future proof.  In Python 2, the items() method returns a list of key/value tuples, hence it is save to apply the pop() method to the cfgvars dictionary.  In Python 3, the items() method will return an iterator, and removing items from a data structure one is iterating over is not a good idea.\r\nI've only added a comment, since I assume that this pattern will be quite pervasive given the list of authors of this block, so it should probably be addressed more systematically."},"comment":{"url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/issues/comments/71561621","html_url":"https://github.com/hpcugent/easybuild-easyblocks/pull/541#issuecomment-71561621","issue_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/issues/541","id":71561621,"user":{"login":"boegel","id":620876,"avatar_url":"https://avatars.githubusercontent.com/u/620876?v=3","gravatar_id":"","url":"https://api.github.com/users/boegel","html_url":"https://github.com/boegel","followers_url":"https://api.github.com/users/boegel/followers","following_url":"https://api.github.com/users/boegel/following{/other_user}","gists_url":"https://api.github.com/users/boegel/gists{/gist_id}","starred_url":"https://api.github.com/users/boegel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boegel/subscriptions","organizations_url":"https://api.github.com/users/boegel/orgs","repos_url":"https://api.github.com/users/boegel/repos","events_url":"https://api.github.com/users/boegel/events{/privacy}","received_events_url":"https://api.github.com/users/boegel/received_events","type":"User","site_admin":false},"created_at":"2015-01-26T23:35:08Z","updated_at":"2015-01-26T23:35:08Z","body":"Tested this together with https://github.com/hpcugent/easybuild-easyconfigs/pull/1328, working great, looking good, so going in. Thanks again @gjbex!"}}