{"action":"created","comment":{"url":"https://api.github.com/repos/linkedin/gobblin/pulls/comments/44600437","id":44600437,"diff_hunk":"@@ -237,10 +237,22 @@ public void setJobProps(State jobProps) {\n     return this.throwables;\n   }\n \n+  /**\n+   * Record a {@link Throwable} in a {@link Dataset}.\n+   */\n   public synchronized void addThrowable(Throwable t) {\n     this.throwables.add(t);\n   }\n \n+  /**\n+   * Skip the {@link Dataset} by setting its {@link DatasetState} to {@link DatasetState#COMPACTION_COMPLETE},\n+   * and record the given {@link Throwable} in the {@link Dataset}.\n+   */\n+  public void skip(Throwable t) {","path":"gobblin-compaction/src/main/java/gobblin/compaction/Dataset.java","position":15,"original_position":15,"commit_id":"9ef1d0ac85bad71c0b1d0d04b4fd9365b2223295","original_commit_id":"9ef1d0ac85bad71c0b1d0d04b4fd9365b2223295","user":{"login":"liyinan926","id":3709137,"avatar_url":"https://avatars.githubusercontent.com/u/3709137?v=3","gravatar_id":"","url":"https://api.github.com/users/liyinan926","html_url":"https://github.com/liyinan926","followers_url":"https://api.github.com/users/liyinan926/followers","following_url":"https://api.github.com/users/liyinan926/following{/other_user}","gists_url":"https://api.github.com/users/liyinan926/gists{/gist_id}","starred_url":"https://api.github.com/users/liyinan926/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liyinan926/subscriptions","organizations_url":"https://api.github.com/users/liyinan926/orgs","repos_url":"https://api.github.com/users/liyinan926/repos","events_url":"https://api.github.com/users/liyinan926/events{/privacy}","received_events_url":"https://api.github.com/users/liyinan926/received_events","type":"User","site_admin":false},"body":"Seems you use `synchronized` in `addThrowable`, but not here. If you do need synchronization, I suggest you change `this.throwables` to a `ConcurrentHashSet` or if you really need a `List`, to something like `Collections.synchronizedList`.","created_at":"2015-11-11T23:04:39Z","updated_at":"2015-11-11T23:04:39Z","html_url":"https://github.com/linkedin/gobblin/pull/441#discussion_r44600437","pull_request_url":"https://api.github.com/repos/linkedin/gobblin/pulls/441","_links":{"self":{"href":"https://api.github.com/repos/linkedin/gobblin/pulls/comments/44600437"},"html":{"href":"https://github.com/linkedin/gobblin/pull/441#discussion_r44600437"},"pull_request":{"href":"https://api.github.com/repos/linkedin/gobblin/pulls/441"}}},"pull_request":{"url":"https://api.github.com/repos/linkedin/gobblin/pulls/441","id":50448606,"html_url":"https://github.com/linkedin/gobblin/pull/441","diff_url":"https://github.com/linkedin/gobblin/pull/441.diff","patch_url":"https://github.com/linkedin/gobblin/pull/441.patch","issue_url":"https://api.github.com/repos/linkedin/gobblin/issues/441","number":441,"state":"open","locked":false,"title":"Improve topic isolation in MRCompactor","user":{"login":"zliu41","id":6342538,"avatar_url":"https://avatars.githubusercontent.com/u/6342538?v=3","gravatar_id":"","url":"https://api.github.com/users/zliu41","html_url":"https://github.com/zliu41","followers_url":"https://api.github.com/users/zliu41/followers","following_url":"https://api.github.com/users/zliu41/following{/other_user}","gists_url":"https://api.github.com/users/zliu41/gists{/gist_id}","starred_url":"https://api.github.com/users/zliu41/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zliu41/subscriptions","organizations_url":"https://api.github.com/users/zliu41/orgs","repos_url":"https://api.github.com/users/zliu41/repos","events_url":"https://api.github.com/users/zliu41/events{/privacy}","received_events_url":"https://api.github.com/users/zliu41/received_events","type":"User","site_admin":false},"body":"Previously if the MR compaction job for a topic fails it won't affect other topics, but if it fails when creating job properties for a topic or submitting the topic to the job executor, the whole job will fail immediately and no other topic will be processed.\r\n\r\nThis PR fixes it -- in the above cases the topic will be skipped without affecting other topics.","created_at":"2015-11-11T22:55:16Z","updated_at":"2015-11-11T23:04:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d69629e4191a7b2272b1977ecb924c95a00e4ba7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/linkedin/gobblin/pulls/441/commits","review_comments_url":"https://api.github.com/repos/linkedin/gobblin/pulls/441/comments","review_comment_url":"https://api.github.com/repos/linkedin/gobblin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/linkedin/gobblin/issues/441/comments","statuses_url":"https://api.github.com/repos/linkedin/gobblin/statuses/9ef1d0ac85bad71c0b1d0d04b4fd9365b2223295","head":{"label":"zliu41:compaction","ref":"compaction","sha":"9ef1d0ac85bad71c0b1d0d04b4fd9365b2223295","user":{"login":"zliu41","id":6342538,"avatar_url":"https://avatars.githubusercontent.com/u/6342538?v=3","gravatar_id":"","url":"https://api.github.com/users/zliu41","html_url":"https://github.com/zliu41","followers_url":"https://api.github.com/users/zliu41/followers","following_url":"https://api.github.com/users/zliu41/following{/other_user}","gists_url":"https://api.github.com/users/zliu41/gists{/gist_id}","starred_url":"https://api.github.com/users/zliu41/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zliu41/subscriptions","organizations_url":"https://api.github.com/users/zliu41/orgs","repos_url":"https://api.github.com/users/zliu41/repos","events_url":"https://api.github.com/users/zliu41/events{/privacy}","received_events_url":"https://api.github.com/users/zliu41/received_events","type":"User","site_admin":false},"repo":{"id":32048123,"name":"gobblin","full_name":"zliu41/gobblin","owner":{"login":"zliu41","id":6342538,"avatar_url":"https://avatars.githubusercontent.com/u/6342538?v=3","gravatar_id":"","url":"https://api.github.com/users/zliu41","html_url":"https://github.com/zliu41","followers_url":"https://api.github.com/users/zliu41/followers","following_url":"https://api.github.com/users/zliu41/following{/other_user}","gists_url":"https://api.github.com/users/zliu41/gists{/gist_id}","starred_url":"https://api.github.com/users/zliu41/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zliu41/subscriptions","organizations_url":"https://api.github.com/users/zliu41/orgs","repos_url":"https://api.github.com/users/zliu41/repos","events_url":"https://api.github.com/users/zliu41/events{/privacy}","received_events_url":"https://api.github.com/users/zliu41/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zliu41/gobblin","description":"","fork":true,"url":"https://api.github.com/repos/zliu41/gobblin","forks_url":"https://api.github.com/repos/zliu41/gobblin/forks","keys_url":"https://api.github.com/repos/zliu41/gobblin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zliu41/gobblin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zliu41/gobblin/teams","hooks_url":"https://api.github.com/repos/zliu41/gobblin/hooks","issue_events_url":"https://api.github.com/repos/zliu41/gobblin/issues/events{/number}","events_url":"https://api.github.com/repos/zliu41/gobblin/events","assignees_url":"https://api.github.com/repos/zliu41/gobblin/assignees{/user}","branches_url":"https://api.github.com/repos/zliu41/gobblin/branches{/branch}","tags_url":"https://api.github.com/repos/zliu41/gobblin/tags","blobs_url":"https://api.github.com/repos/zliu41/gobblin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zliu41/gobblin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zliu41/gobblin/git/refs{/sha}","trees_url":"https://api.github.com/repos/zliu41/gobblin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zliu41/gobblin/statuses/{sha}","languages_url":"https://api.github.com/repos/zliu41/gobblin/languages","stargazers_url":"https://api.github.com/repos/zliu41/gobblin/stargazers","contributors_url":"https://api.github.com/repos/zliu41/gobblin/contributors","subscribers_url":"https://api.github.com/repos/zliu41/gobblin/subscribers","subscription_url":"https://api.github.com/repos/zliu41/gobblin/subscription","commits_url":"https://api.github.com/repos/zliu41/gobblin/commits{/sha}","git_commits_url":"https://api.github.com/repos/zliu41/gobblin/git/commits{/sha}","comments_url":"https://api.github.com/repos/zliu41/gobblin/comments{/number}","issue_comment_url":"https://api.github.com/repos/zliu41/gobblin/issues/comments{/number}","contents_url":"https://api.github.com/repos/zliu41/gobblin/contents/{+path}","compare_url":"https://api.github.com/repos/zliu41/gobblin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zliu41/gobblin/merges","archive_url":"https://api.github.com/repos/zliu41/gobblin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zliu41/gobblin/downloads","issues_url":"https://api.github.com/repos/zliu41/gobblin/issues{/number}","pulls_url":"https://api.github.com/repos/zliu41/gobblin/pulls{/number}","milestones_url":"https://api.github.com/repos/zliu41/gobblin/milestones{/number}","notifications_url":"https://api.github.com/repos/zliu41/gobblin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zliu41/gobblin/labels{/name}","releases_url":"https://api.github.com/repos/zliu41/gobblin/releases{/id}","created_at":"2015-03-12T00:17:48Z","updated_at":"2015-05-07T16:27:07Z","pushed_at":"2015-11-11T22:52:42Z","git_url":"git://github.com/zliu41/gobblin.git","ssh_url":"git@github.com:zliu41/gobblin.git","clone_url":"https://github.com/zliu41/gobblin.git","svn_url":"https://github.com/zliu41/gobblin","homepage":null,"size":80751,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"linkedin:master","ref":"master","sha":"ec5e7dab2442ca9665d66bed3aba95e26637e351","user":{"login":"linkedin","id":357098,"avatar_url":"https://avatars.githubusercontent.com/u/357098?v=3","gravatar_id":"","url":"https://api.github.com/users/linkedin","html_url":"https://github.com/linkedin","followers_url":"https://api.github.com/users/linkedin/followers","following_url":"https://api.github.com/users/linkedin/following{/other_user}","gists_url":"https://api.github.com/users/linkedin/gists{/gist_id}","starred_url":"https://api.github.com/users/linkedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkedin/subscriptions","organizations_url":"https://api.github.com/users/linkedin/orgs","repos_url":"https://api.github.com/users/linkedin/repos","events_url":"https://api.github.com/users/linkedin/events{/privacy}","received_events_url":"https://api.github.com/users/linkedin/received_events","type":"Organization","site_admin":false},"repo":{"id":27392543,"name":"gobblin","full_name":"linkedin/gobblin","owner":{"login":"linkedin","id":357098,"avatar_url":"https://avatars.githubusercontent.com/u/357098?v=3","gravatar_id":"","url":"https://api.github.com/users/linkedin","html_url":"https://github.com/linkedin","followers_url":"https://api.github.com/users/linkedin/followers","following_url":"https://api.github.com/users/linkedin/following{/other_user}","gists_url":"https://api.github.com/users/linkedin/gists{/gist_id}","starred_url":"https://api.github.com/users/linkedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkedin/subscriptions","organizations_url":"https://api.github.com/users/linkedin/orgs","repos_url":"https://api.github.com/users/linkedin/repos","events_url":"https://api.github.com/users/linkedin/events{/privacy}","received_events_url":"https://api.github.com/users/linkedin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/linkedin/gobblin","description":"Universal data ingestion framework for Hadoop.","fork":false,"url":"https://api.github.com/repos/linkedin/gobblin","forks_url":"https://api.github.com/repos/linkedin/gobblin/forks","keys_url":"https://api.github.com/repos/linkedin/gobblin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linkedin/gobblin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linkedin/gobblin/teams","hooks_url":"https://api.github.com/repos/linkedin/gobblin/hooks","issue_events_url":"https://api.github.com/repos/linkedin/gobblin/issues/events{/number}","events_url":"https://api.github.com/repos/linkedin/gobblin/events","assignees_url":"https://api.github.com/repos/linkedin/gobblin/assignees{/user}","branches_url":"https://api.github.com/repos/linkedin/gobblin/branches{/branch}","tags_url":"https://api.github.com/repos/linkedin/gobblin/tags","blobs_url":"https://api.github.com/repos/linkedin/gobblin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linkedin/gobblin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linkedin/gobblin/git/refs{/sha}","trees_url":"https://api.github.com/repos/linkedin/gobblin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linkedin/gobblin/statuses/{sha}","languages_url":"https://api.github.com/repos/linkedin/gobblin/languages","stargazers_url":"https://api.github.com/repos/linkedin/gobblin/stargazers","contributors_url":"https://api.github.com/repos/linkedin/gobblin/contributors","subscribers_url":"https://api.github.com/repos/linkedin/gobblin/subscribers","subscription_url":"https://api.github.com/repos/linkedin/gobblin/subscription","commits_url":"https://api.github.com/repos/linkedin/gobblin/commits{/sha}","git_commits_url":"https://api.github.com/repos/linkedin/gobblin/git/commits{/sha}","comments_url":"https://api.github.com/repos/linkedin/gobblin/comments{/number}","issue_comment_url":"https://api.github.com/repos/linkedin/gobblin/issues/comments{/number}","contents_url":"https://api.github.com/repos/linkedin/gobblin/contents/{+path}","compare_url":"https://api.github.com/repos/linkedin/gobblin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linkedin/gobblin/merges","archive_url":"https://api.github.com/repos/linkedin/gobblin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linkedin/gobblin/downloads","issues_url":"https://api.github.com/repos/linkedin/gobblin/issues{/number}","pulls_url":"https://api.github.com/repos/linkedin/gobblin/pulls{/number}","milestones_url":"https://api.github.com/repos/linkedin/gobblin/milestones{/number}","notifications_url":"https://api.github.com/repos/linkedin/gobblin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linkedin/gobblin/labels{/name}","releases_url":"https://api.github.com/repos/linkedin/gobblin/releases{/id}","created_at":"2014-12-01T18:10:50Z","updated_at":"2015-11-11T17:06:26Z","pushed_at":"2015-11-11T22:55:16Z","git_url":"git://github.com/linkedin/gobblin.git","ssh_url":"git@github.com:linkedin/gobblin.git","clone_url":"https://github.com/linkedin/gobblin.git","svn_url":"https://github.com/linkedin/gobblin","homepage":"https://github.com/linkedin/gobblin/wiki","size":163451,"stargazers_count":288,"watchers_count":288,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":98,"mirror_url":null,"open_issues_count":16,"forks":98,"open_issues":16,"watchers":288,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/linkedin/gobblin/pulls/441"},"html":{"href":"https://github.com/linkedin/gobblin/pull/441"},"issue":{"href":"https://api.github.com/repos/linkedin/gobblin/issues/441"},"comments":{"href":"https://api.github.com/repos/linkedin/gobblin/issues/441/comments"},"review_comments":{"href":"https://api.github.com/repos/linkedin/gobblin/pulls/441/comments"},"review_comment":{"href":"https://api.github.com/repos/linkedin/gobblin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/linkedin/gobblin/pulls/441/commits"},"statuses":{"href":"https://api.github.com/repos/linkedin/gobblin/statuses/9ef1d0ac85bad71c0b1d0d04b4fd9365b2223295"}}}}