{"action":"created","comment":{"url":"https://api.github.com/repos/tmpvar/jsdom/pulls/comments/36052186","id":36052186,"diff_hunk":"@@ -11,10 +11,10 @@ function StateEntry(data, title, url) {\n module.exports = History;\n \n function History(window) {\n-  this._states = [new StateEntry(null, \"\", window.location._url.href)];\n+  this._states = [new StateEntry(null, \"\", window._document._URL)];\n   this._index = 0;\n   this._window = window;\n-  this._location = window.location;\n+  this._location = window._document._location;","path":"lib/jsdom/browser/history.js","position":16,"original_position":16,"commit_id":"8f706f879972bd43018a65c969b4c4beb1ba8ef6","original_commit_id":"8f706f879972bd43018a65c969b4c4beb1ba8ef6","user":{"login":"domenic","id":617481,"avatar_url":"https://avatars.githubusercontent.com/u/617481?v=3","gravatar_id":"","url":"https://api.github.com/users/domenic","html_url":"https://github.com/domenic","followers_url":"https://api.github.com/users/domenic/followers","following_url":"https://api.github.com/users/domenic/following{/other_user}","gists_url":"https://api.github.com/users/domenic/gists{/gist_id}","starred_url":"https://api.github.com/users/domenic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/domenic/subscriptions","organizations_url":"https://api.github.com/users/domenic/orgs","repos_url":"https://api.github.com/users/domenic/repos","events_url":"https://api.github.com/users/domenic/events{/privacy}","received_events_url":"https://api.github.com/users/domenic/received_events","type":"User","site_admin":false},"body":"Because that's where it's really stored; window.location is a getter for this._document._location","created_at":"2015-08-03T02:08:49Z","updated_at":"2015-08-03T02:08:49Z","html_url":"https://github.com/tmpvar/jsdom/pull/1178#discussion_r36052186","pull_request_url":"https://api.github.com/repos/tmpvar/jsdom/pulls/1178","_links":{"self":{"href":"https://api.github.com/repos/tmpvar/jsdom/pulls/comments/36052186"},"html":{"href":"https://github.com/tmpvar/jsdom/pull/1178#discussion_r36052186"},"pull_request":{"href":"https://api.github.com/repos/tmpvar/jsdom/pulls/1178"}}},"pull_request":{"url":"https://api.github.com/repos/tmpvar/jsdom/pulls/1178","id":41424519,"html_url":"https://github.com/tmpvar/jsdom/pull/1178","diff_url":"https://github.com/tmpvar/jsdom/pull/1178.diff","patch_url":"https://github.com/tmpvar/jsdom/pull/1178.patch","issue_url":"https://api.github.com/repos/tmpvar/jsdom/issues/1178","number":1178,"state":"open","locked":false,"title":"Update Location to use whatwg-url's URLUtils","user":{"login":"domenic","id":617481,"avatar_url":"https://avatars.githubusercontent.com/u/617481?v=3","gravatar_id":"","url":"https://api.github.com/users/domenic","html_url":"https://github.com/domenic","followers_url":"https://api.github.com/users/domenic/followers","following_url":"https://api.github.com/users/domenic/following{/other_user}","gists_url":"https://api.github.com/users/domenic/gists{/gist_id}","starred_url":"https://api.github.com/users/domenic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/domenic/subscriptions","organizations_url":"https://api.github.com/users/domenic/orgs","repos_url":"https://api.github.com/users/domenic/repos","events_url":"https://api.github.com/users/domenic/events{/privacy}","received_events_url":"https://api.github.com/users/domenic/received_events","type":"User","site_admin":false},"body":"A jsdom/env test is failing currently due to https://github.com/jsdom/whatwg-url/issues/31","created_at":"2015-08-02T21:07:50Z","updated_at":"2015-08-03T02:08:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"97dbc7a85be6157cfb3cafe1fe0c78d0a78268c7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/tmpvar/jsdom/pulls/1178/commits","review_comments_url":"https://api.github.com/repos/tmpvar/jsdom/pulls/1178/comments","review_comment_url":"https://api.github.com/repos/tmpvar/jsdom/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tmpvar/jsdom/issues/1178/comments","statuses_url":"https://api.github.com/repos/tmpvar/jsdom/statuses/8f706f879972bd43018a65c969b4c4beb1ba8ef6","head":{"label":"tmpvar:migrate-location","ref":"migrate-location","sha":"8f706f879972bd43018a65c969b4c4beb1ba8ef6","user":{"login":"tmpvar","id":46673,"avatar_url":"https://avatars.githubusercontent.com/u/46673?v=3","gravatar_id":"","url":"https://api.github.com/users/tmpvar","html_url":"https://github.com/tmpvar","followers_url":"https://api.github.com/users/tmpvar/followers","following_url":"https://api.github.com/users/tmpvar/following{/other_user}","gists_url":"https://api.github.com/users/tmpvar/gists{/gist_id}","starred_url":"https://api.github.com/users/tmpvar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmpvar/subscriptions","organizations_url":"https://api.github.com/users/tmpvar/orgs","repos_url":"https://api.github.com/users/tmpvar/repos","events_url":"https://api.github.com/users/tmpvar/events{/privacy}","received_events_url":"https://api.github.com/users/tmpvar/received_events","type":"User","site_admin":false},"repo":{"id":478584,"name":"jsdom","full_name":"tmpvar/jsdom","owner":{"login":"tmpvar","id":46673,"avatar_url":"https://avatars.githubusercontent.com/u/46673?v=3","gravatar_id":"","url":"https://api.github.com/users/tmpvar","html_url":"https://github.com/tmpvar","followers_url":"https://api.github.com/users/tmpvar/followers","following_url":"https://api.github.com/users/tmpvar/following{/other_user}","gists_url":"https://api.github.com/users/tmpvar/gists{/gist_id}","starred_url":"https://api.github.com/users/tmpvar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmpvar/subscriptions","organizations_url":"https://api.github.com/users/tmpvar/orgs","repos_url":"https://api.github.com/users/tmpvar/repos","events_url":"https://api.github.com/users/tmpvar/events{/privacy}","received_events_url":"https://api.github.com/users/tmpvar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tmpvar/jsdom","description":"A JavaScript implementation of the WHATWG DOM and HTML standards, for use with io.js","fork":false,"url":"https://api.github.com/repos/tmpvar/jsdom","forks_url":"https://api.github.com/repos/tmpvar/jsdom/forks","keys_url":"https://api.github.com/repos/tmpvar/jsdom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tmpvar/jsdom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tmpvar/jsdom/teams","hooks_url":"https://api.github.com/repos/tmpvar/jsdom/hooks","issue_events_url":"https://api.github.com/repos/tmpvar/jsdom/issues/events{/number}","events_url":"https://api.github.com/repos/tmpvar/jsdom/events","assignees_url":"https://api.github.com/repos/tmpvar/jsdom/assignees{/user}","branches_url":"https://api.github.com/repos/tmpvar/jsdom/branches{/branch}","tags_url":"https://api.github.com/repos/tmpvar/jsdom/tags","blobs_url":"https://api.github.com/repos/tmpvar/jsdom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tmpvar/jsdom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tmpvar/jsdom/git/refs{/sha}","trees_url":"https://api.github.com/repos/tmpvar/jsdom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tmpvar/jsdom/statuses/{sha}","languages_url":"https://api.github.com/repos/tmpvar/jsdom/languages","stargazers_url":"https://api.github.com/repos/tmpvar/jsdom/stargazers","contributors_url":"https://api.github.com/repos/tmpvar/jsdom/contributors","subscribers_url":"https://api.github.com/repos/tmpvar/jsdom/subscribers","subscription_url":"https://api.github.com/repos/tmpvar/jsdom/subscription","commits_url":"https://api.github.com/repos/tmpvar/jsdom/commits{/sha}","git_commits_url":"https://api.github.com/repos/tmpvar/jsdom/git/commits{/sha}","comments_url":"https://api.github.com/repos/tmpvar/jsdom/comments{/number}","issue_comment_url":"https://api.github.com/repos/tmpvar/jsdom/issues/comments{/number}","contents_url":"https://api.github.com/repos/tmpvar/jsdom/contents/{+path}","compare_url":"https://api.github.com/repos/tmpvar/jsdom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tmpvar/jsdom/merges","archive_url":"https://api.github.com/repos/tmpvar/jsdom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tmpvar/jsdom/downloads","issues_url":"https://api.github.com/repos/tmpvar/jsdom/issues{/number}","pulls_url":"https://api.github.com/repos/tmpvar/jsdom/pulls{/number}","milestones_url":"https://api.github.com/repos/tmpvar/jsdom/milestones{/number}","notifications_url":"https://api.github.com/repos/tmpvar/jsdom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tmpvar/jsdom/labels{/name}","releases_url":"https://api.github.com/repos/tmpvar/jsdom/releases{/id}","created_at":"2010-01-19T06:55:19Z","updated_at":"2015-08-03T01:28:45Z","pushed_at":"2015-08-03T00:01:19Z","git_url":"git://github.com/tmpvar/jsdom.git","ssh_url":"git@github.com:tmpvar/jsdom.git","clone_url":"https://github.com/tmpvar/jsdom.git","svn_url":"https://github.com/tmpvar/jsdom","homepage":"","size":17331,"stargazers_count":4519,"watchers_count":4519,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":514,"mirror_url":null,"open_issues_count":115,"forks":514,"open_issues":115,"watchers":4519,"default_branch":"master"}},"base":{"label":"tmpvar:master","ref":"master","sha":"8d11724faeff3878730873de468c6d8d64c019dd","user":{"login":"tmpvar","id":46673,"avatar_url":"https://avatars.githubusercontent.com/u/46673?v=3","gravatar_id":"","url":"https://api.github.com/users/tmpvar","html_url":"https://github.com/tmpvar","followers_url":"https://api.github.com/users/tmpvar/followers","following_url":"https://api.github.com/users/tmpvar/following{/other_user}","gists_url":"https://api.github.com/users/tmpvar/gists{/gist_id}","starred_url":"https://api.github.com/users/tmpvar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmpvar/subscriptions","organizations_url":"https://api.github.com/users/tmpvar/orgs","repos_url":"https://api.github.com/users/tmpvar/repos","events_url":"https://api.github.com/users/tmpvar/events{/privacy}","received_events_url":"https://api.github.com/users/tmpvar/received_events","type":"User","site_admin":false},"repo":{"id":478584,"name":"jsdom","full_name":"tmpvar/jsdom","owner":{"login":"tmpvar","id":46673,"avatar_url":"https://avatars.githubusercontent.com/u/46673?v=3","gravatar_id":"","url":"https://api.github.com/users/tmpvar","html_url":"https://github.com/tmpvar","followers_url":"https://api.github.com/users/tmpvar/followers","following_url":"https://api.github.com/users/tmpvar/following{/other_user}","gists_url":"https://api.github.com/users/tmpvar/gists{/gist_id}","starred_url":"https://api.github.com/users/tmpvar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmpvar/subscriptions","organizations_url":"https://api.github.com/users/tmpvar/orgs","repos_url":"https://api.github.com/users/tmpvar/repos","events_url":"https://api.github.com/users/tmpvar/events{/privacy}","received_events_url":"https://api.github.com/users/tmpvar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tmpvar/jsdom","description":"A JavaScript implementation of the WHATWG DOM and HTML standards, for use with io.js","fork":false,"url":"https://api.github.com/repos/tmpvar/jsdom","forks_url":"https://api.github.com/repos/tmpvar/jsdom/forks","keys_url":"https://api.github.com/repos/tmpvar/jsdom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tmpvar/jsdom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tmpvar/jsdom/teams","hooks_url":"https://api.github.com/repos/tmpvar/jsdom/hooks","issue_events_url":"https://api.github.com/repos/tmpvar/jsdom/issues/events{/number}","events_url":"https://api.github.com/repos/tmpvar/jsdom/events","assignees_url":"https://api.github.com/repos/tmpvar/jsdom/assignees{/user}","branches_url":"https://api.github.com/repos/tmpvar/jsdom/branches{/branch}","tags_url":"https://api.github.com/repos/tmpvar/jsdom/tags","blobs_url":"https://api.github.com/repos/tmpvar/jsdom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tmpvar/jsdom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tmpvar/jsdom/git/refs{/sha}","trees_url":"https://api.github.com/repos/tmpvar/jsdom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tmpvar/jsdom/statuses/{sha}","languages_url":"https://api.github.com/repos/tmpvar/jsdom/languages","stargazers_url":"https://api.github.com/repos/tmpvar/jsdom/stargazers","contributors_url":"https://api.github.com/repos/tmpvar/jsdom/contributors","subscribers_url":"https://api.github.com/repos/tmpvar/jsdom/subscribers","subscription_url":"https://api.github.com/repos/tmpvar/jsdom/subscription","commits_url":"https://api.github.com/repos/tmpvar/jsdom/commits{/sha}","git_commits_url":"https://api.github.com/repos/tmpvar/jsdom/git/commits{/sha}","comments_url":"https://api.github.com/repos/tmpvar/jsdom/comments{/number}","issue_comment_url":"https://api.github.com/repos/tmpvar/jsdom/issues/comments{/number}","contents_url":"https://api.github.com/repos/tmpvar/jsdom/contents/{+path}","compare_url":"https://api.github.com/repos/tmpvar/jsdom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tmpvar/jsdom/merges","archive_url":"https://api.github.com/repos/tmpvar/jsdom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tmpvar/jsdom/downloads","issues_url":"https://api.github.com/repos/tmpvar/jsdom/issues{/number}","pulls_url":"https://api.github.com/repos/tmpvar/jsdom/pulls{/number}","milestones_url":"https://api.github.com/repos/tmpvar/jsdom/milestones{/number}","notifications_url":"https://api.github.com/repos/tmpvar/jsdom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tmpvar/jsdom/labels{/name}","releases_url":"https://api.github.com/repos/tmpvar/jsdom/releases{/id}","created_at":"2010-01-19T06:55:19Z","updated_at":"2015-08-03T01:28:45Z","pushed_at":"2015-08-03T00:01:19Z","git_url":"git://github.com/tmpvar/jsdom.git","ssh_url":"git@github.com:tmpvar/jsdom.git","clone_url":"https://github.com/tmpvar/jsdom.git","svn_url":"https://github.com/tmpvar/jsdom","homepage":"","size":17331,"stargazers_count":4519,"watchers_count":4519,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":514,"mirror_url":null,"open_issues_count":115,"forks":514,"open_issues":115,"watchers":4519,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tmpvar/jsdom/pulls/1178"},"html":{"href":"https://github.com/tmpvar/jsdom/pull/1178"},"issue":{"href":"https://api.github.com/repos/tmpvar/jsdom/issues/1178"},"comments":{"href":"https://api.github.com/repos/tmpvar/jsdom/issues/1178/comments"},"review_comments":{"href":"https://api.github.com/repos/tmpvar/jsdom/pulls/1178/comments"},"review_comment":{"href":"https://api.github.com/repos/tmpvar/jsdom/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tmpvar/jsdom/pulls/1178/commits"},"statuses":{"href":"https://api.github.com/repos/tmpvar/jsdom/statuses/8f706f879972bd43018a65c969b4c4beb1ba8ef6"}}}}