{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin/pulls/comments/28721037","id":28721037,"diff_hunk":"@@ -175,12 +175,20 @@ angular.module('openshiftConsole')\n     };\n   })\n   .filter('imageRepoReference', function(){\n-    return function(objectRef, tag){\n-      tag = tag || \"latest\";\n+    return function(objectRef, kind, tag){\n       var ns = objectRef.namespace || \"\";\n       ns = ns == \"\" ? ns : ns + \"/\";\n+\n+      if (kind == \"ImageStreamTag\" || kind==\"ImageStreamImage\") {\n+        return ns+objectRef.name;\n+      }\n       var ref = ns + objectRef.name;\n-      ref += \" [\" + tag + \"]\";\n+      // until v1beta2, the ImageStreamImage Kind isn't being set so we need to\n+      // manually check if the name looks like an ImageStreamImage\n+      if (objectRef.name.indexOf(\"@\")==-1) {","path":"assets/app/scripts/filters/resources.js","position":null,"original_position":17,"commit_id":"1c4d090e4b5acc1ffe0e31b15563a0e12e0ef93c","original_commit_id":"72032f19a2c0cc85ec55179a063a6958ac787b6a","user":{"login":"bparees","id":4974046,"avatar_url":"https://avatars.githubusercontent.com/u/4974046?v=3","gravatar_id":"","url":"https://api.github.com/users/bparees","html_url":"https://github.com/bparees","followers_url":"https://api.github.com/users/bparees/followers","following_url":"https://api.github.com/users/bparees/following{/other_user}","gists_url":"https://api.github.com/users/bparees/gists{/gist_id}","starred_url":"https://api.github.com/users/bparees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bparees/subscriptions","organizations_url":"https://api.github.com/users/bparees/orgs","repos_url":"https://api.github.com/users/bparees/repos","events_url":"https://api.github.com/users/bparees/events{/privacy}","received_events_url":"https://api.github.com/users/bparees/received_events","type":"User","site_admin":false},"body":"thanks, done.\r\n","created_at":"2015-04-20T19:34:30Z","updated_at":"2015-04-20T19:34:30Z","html_url":"https://github.com/openshift/origin/pull/1693#discussion_r28721037","pull_request_url":"https://api.github.com/repos/openshift/origin/pulls/1693","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments/28721037"},"html":{"href":"https://github.com/openshift/origin/pull/1693#discussion_r28721037"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin/pulls/1693"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/1693","id":33063956,"html_url":"https://github.com/openshift/origin/pull/1693","diff_url":"https://github.com/openshift/origin/pull/1693.diff","patch_url":"https://github.com/openshift/origin/pull/1693.patch","issue_url":"https://api.github.com/repos/openshift/origin/issues/1693","number":1693,"state":"open","locked":false,"title":"add imagestream refs for custom and docker strategies","user":{"login":"bparees","id":4974046,"avatar_url":"https://avatars.githubusercontent.com/u/4974046?v=3","gravatar_id":"","url":"https://api.github.com/users/bparees","html_url":"https://github.com/bparees","followers_url":"https://api.github.com/users/bparees/followers","following_url":"https://api.github.com/users/bparees/following{/other_user}","gists_url":"https://api.github.com/users/bparees/gists{/gist_id}","starred_url":"https://api.github.com/users/bparees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bparees/subscriptions","organizations_url":"https://api.github.com/users/bparees/orgs","repos_url":"https://api.github.com/users/bparees/repos","events_url":"https://api.github.com/users/bparees/events{/privacy}","received_events_url":"https://api.github.com/users/bparees/received_events","type":"User","site_admin":false},"body":null,"created_at":"2015-04-10T16:53:09Z","updated_at":"2015-04-20T19:34:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4564f4b938bb0c049b57e5e02ebc5c7a74560b4a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin/pulls/1693/commits","review_comments_url":"https://api.github.com/repos/openshift/origin/pulls/1693/comments","review_comment_url":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin/issues/1693/comments","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/1c4d090e4b5acc1ffe0e31b15563a0e12e0ef93c","head":{"label":"bparees:image_refs","ref":"image_refs","sha":"1c4d090e4b5acc1ffe0e31b15563a0e12e0ef93c","user":{"login":"bparees","id":4974046,"avatar_url":"https://avatars.githubusercontent.com/u/4974046?v=3","gravatar_id":"","url":"https://api.github.com/users/bparees","html_url":"https://github.com/bparees","followers_url":"https://api.github.com/users/bparees/followers","following_url":"https://api.github.com/users/bparees/following{/other_user}","gists_url":"https://api.github.com/users/bparees/gists{/gist_id}","starred_url":"https://api.github.com/users/bparees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bparees/subscriptions","organizations_url":"https://api.github.com/users/bparees/orgs","repos_url":"https://api.github.com/users/bparees/repos","events_url":"https://api.github.com/users/bparees/events{/privacy}","received_events_url":"https://api.github.com/users/bparees/received_events","type":"User","site_admin":false},"repo":{"id":23590442,"name":"origin","full_name":"bparees/origin","owner":{"login":"bparees","id":4974046,"avatar_url":"https://avatars.githubusercontent.com/u/4974046?v=3","gravatar_id":"","url":"https://api.github.com/users/bparees","html_url":"https://github.com/bparees","followers_url":"https://api.github.com/users/bparees/followers","following_url":"https://api.github.com/users/bparees/following{/other_user}","gists_url":"https://api.github.com/users/bparees/gists{/gist_id}","starred_url":"https://api.github.com/users/bparees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bparees/subscriptions","organizations_url":"https://api.github.com/users/bparees/orgs","repos_url":"https://api.github.com/users/bparees/repos","events_url":"https://api.github.com/users/bparees/events{/privacy}","received_events_url":"https://api.github.com/users/bparees/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bparees/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":true,"url":"https://api.github.com/repos/bparees/origin","forks_url":"https://api.github.com/repos/bparees/origin/forks","keys_url":"https://api.github.com/repos/bparees/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bparees/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bparees/origin/teams","hooks_url":"https://api.github.com/repos/bparees/origin/hooks","issue_events_url":"https://api.github.com/repos/bparees/origin/issues/events{/number}","events_url":"https://api.github.com/repos/bparees/origin/events","assignees_url":"https://api.github.com/repos/bparees/origin/assignees{/user}","branches_url":"https://api.github.com/repos/bparees/origin/branches{/branch}","tags_url":"https://api.github.com/repos/bparees/origin/tags","blobs_url":"https://api.github.com/repos/bparees/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bparees/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bparees/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/bparees/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bparees/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/bparees/origin/languages","stargazers_url":"https://api.github.com/repos/bparees/origin/stargazers","contributors_url":"https://api.github.com/repos/bparees/origin/contributors","subscribers_url":"https://api.github.com/repos/bparees/origin/subscribers","subscription_url":"https://api.github.com/repos/bparees/origin/subscription","commits_url":"https://api.github.com/repos/bparees/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/bparees/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/bparees/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/bparees/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/bparees/origin/contents/{+path}","compare_url":"https://api.github.com/repos/bparees/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bparees/origin/merges","archive_url":"https://api.github.com/repos/bparees/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bparees/origin/downloads","issues_url":"https://api.github.com/repos/bparees/origin/issues{/number}","pulls_url":"https://api.github.com/repos/bparees/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/bparees/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/bparees/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bparees/origin/labels{/name}","releases_url":"https://api.github.com/repos/bparees/origin/releases{/id}","created_at":"2014-09-02T18:28:48Z","updated_at":"2015-04-20T01:20:10Z","pushed_at":"2015-04-20T19:34:17Z","git_url":"git://github.com/bparees/origin.git","ssh_url":"git@github.com:bparees/origin.git","clone_url":"https://github.com/bparees/origin.git","svn_url":"https://github.com/bparees/origin","homepage":"https://openshift.github.io","size":79279,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"f674dbf3864a7cdd825a15b4707eb2e145ec5167","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":22442668,"name":"origin","full_name":"openshift/origin","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":false,"url":"https://api.github.com/repos/openshift/origin","forks_url":"https://api.github.com/repos/openshift/origin/forks","keys_url":"https://api.github.com/repos/openshift/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin/teams","hooks_url":"https://api.github.com/repos/openshift/origin/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin/events","assignees_url":"https://api.github.com/repos/openshift/origin/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin/tags","blobs_url":"https://api.github.com/repos/openshift/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin/languages","stargazers_url":"https://api.github.com/repos/openshift/origin/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin/subscription","commits_url":"https://api.github.com/repos/openshift/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin/merges","archive_url":"https://api.github.com/repos/openshift/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin/downloads","issues_url":"https://api.github.com/repos/openshift/origin/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin/releases{/id}","created_at":"2014-07-30T20:04:05Z","updated_at":"2015-04-20T19:02:07Z","pushed_at":"2015-04-20T19:34:17Z","git_url":"git://github.com/openshift/origin.git","ssh_url":"git@github.com:openshift/origin.git","clone_url":"https://github.com/openshift/origin.git","svn_url":"https://github.com/openshift/origin","homepage":"http://www.openshift.org","size":120011,"stargazers_count":374,"watchers_count":374,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":189,"mirror_url":null,"open_issues_count":203,"forks":189,"open_issues":203,"watchers":374,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/1693"},"html":{"href":"https://github.com/openshift/origin/pull/1693"},"issue":{"href":"https://api.github.com/repos/openshift/origin/issues/1693"},"comments":{"href":"https://api.github.com/repos/openshift/origin/issues/1693/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin/pulls/1693/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin/pulls/1693/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin/statuses/1c4d090e4b5acc1ffe0e31b15563a0e12e0ef93c"}}}}