{"action":"closed","number":997,"pull_request":{"url":"https://api.github.com/repos/cargomedia/puppet-packages/pulls/997","id":51378790,"html_url":"https://github.com/cargomedia/puppet-packages/pull/997","diff_url":"https://github.com/cargomedia/puppet-packages/pull/997.diff","patch_url":"https://github.com/cargomedia/puppet-packages/pull/997.patch","issue_url":"https://api.github.com/repos/cargomedia/puppet-packages/issues/997","number":997,"state":"closed","locked":false,"title":"Don't run apt::update before actual spec manifest","user":{"login":"tomaszdurka","id":113303,"avatar_url":"https://avatars.githubusercontent.com/u/113303?v=3","gravatar_id":"","url":"https://api.github.com/users/tomaszdurka","html_url":"https://github.com/tomaszdurka","followers_url":"https://api.github.com/users/tomaszdurka/followers","following_url":"https://api.github.com/users/tomaszdurka/following{/other_user}","gists_url":"https://api.github.com/users/tomaszdurka/gists{/gist_id}","starred_url":"https://api.github.com/users/tomaszdurka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomaszdurka/subscriptions","organizations_url":"https://api.github.com/users/tomaszdurka/orgs","repos_url":"https://api.github.com/users/tomaszdurka/repos","events_url":"https://api.github.com/users/tomaszdurka/events{/privacy}","received_events_url":"https://api.github.com/users/tomaszdurka/received_events","type":"User","site_admin":false},"body":"I understand we rely that some packages are present on the system or at least are within the manifests we run when using those packages. That's why we have `spec_before.pp` which basically prepares ground for specs by installing required modules. *(I don't agree with this, I think modules themselves should require dependencies and not rely they are included elsewhere - but let's ignore that for now).\r\n\r\nCurrently we apply `spec_before.pp` which adds some prerequisites like `apt`, apt-repo is up to date. This sounds reasonable, but problem is this manifest is applied in separate puppet apply run here in tests, while it runs together with modules from spec in production. Possible errors - like last one with nodejs.\r\n\r\nSteps to take:\r\n1. drop `apt::update` in `provision.pp` (or only, manually run `apt-get update` command) *# I would drop it fully*\r\n2. run spec_before's `apt::update` together with spec manifest, so either:\r\n  - require 'apt-get' in each spec manifest needing it\r\n  - merge manifests (spec_before + spec's manifest) and run together - tested to be working","created_at":"2015-11-20T16:40:54Z","updated_at":"2015-11-26T13:46:34Z","closed_at":"2015-11-26T13:46:34Z","merged_at":"2015-11-26T13:46:34Z","merge_commit_sha":"5de2f7870b5b70caa3f97171b0a443463e7ea05d","assignee":{"login":"tomaszdurka","id":113303,"avatar_url":"https://avatars.githubusercontent.com/u/113303?v=3","gravatar_id":"","url":"https://api.github.com/users/tomaszdurka","html_url":"https://github.com/tomaszdurka","followers_url":"https://api.github.com/users/tomaszdurka/followers","following_url":"https://api.github.com/users/tomaszdurka/following{/other_user}","gists_url":"https://api.github.com/users/tomaszdurka/gists{/gist_id}","starred_url":"https://api.github.com/users/tomaszdurka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomaszdurka/subscriptions","organizations_url":"https://api.github.com/users/tomaszdurka/orgs","repos_url":"https://api.github.com/users/tomaszdurka/repos","events_url":"https://api.github.com/users/tomaszdurka/events{/privacy}","received_events_url":"https://api.github.com/users/tomaszdurka/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/cargomedia/puppet-packages/pulls/997/commits","review_comments_url":"https://api.github.com/repos/cargomedia/puppet-packages/pulls/997/comments","review_comment_url":"https://api.github.com/repos/cargomedia/puppet-packages/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cargomedia/puppet-packages/issues/997/comments","statuses_url":"https://api.github.com/repos/cargomedia/puppet-packages/statuses/24fb5209122cafcbbef2283417d0c36b7da57d85","head":{"label":"tomaszdurka:issue-997","ref":"issue-997","sha":"24fb5209122cafcbbef2283417d0c36b7da57d85","user":{"login":"tomaszdurka","id":113303,"avatar_url":"https://avatars.githubusercontent.com/u/113303?v=3","gravatar_id":"","url":"https://api.github.com/users/tomaszdurka","html_url":"https://github.com/tomaszdurka","followers_url":"https://api.github.com/users/tomaszdurka/followers","following_url":"https://api.github.com/users/tomaszdurka/following{/other_user}","gists_url":"https://api.github.com/users/tomaszdurka/gists{/gist_id}","starred_url":"https://api.github.com/users/tomaszdurka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomaszdurka/subscriptions","organizations_url":"https://api.github.com/users/tomaszdurka/orgs","repos_url":"https://api.github.com/users/tomaszdurka/repos","events_url":"https://api.github.com/users/tomaszdurka/events{/privacy}","received_events_url":"https://api.github.com/users/tomaszdurka/received_events","type":"User","site_admin":false},"repo":{"id":10485341,"name":"puppet-packages","full_name":"tomaszdurka/puppet-packages","owner":{"login":"tomaszdurka","id":113303,"avatar_url":"https://avatars.githubusercontent.com/u/113303?v=3","gravatar_id":"","url":"https://api.github.com/users/tomaszdurka","html_url":"https://github.com/tomaszdurka","followers_url":"https://api.github.com/users/tomaszdurka/followers","following_url":"https://api.github.com/users/tomaszdurka/following{/other_user}","gists_url":"https://api.github.com/users/tomaszdurka/gists{/gist_id}","starred_url":"https://api.github.com/users/tomaszdurka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomaszdurka/subscriptions","organizations_url":"https://api.github.com/users/tomaszdurka/orgs","repos_url":"https://api.github.com/users/tomaszdurka/repos","events_url":"https://api.github.com/users/tomaszdurka/events{/privacy}","received_events_url":"https://api.github.com/users/tomaszdurka/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tomaszdurka/puppet-packages","description":"","fork":true,"url":"https://api.github.com/repos/tomaszdurka/puppet-packages","forks_url":"https://api.github.com/repos/tomaszdurka/puppet-packages/forks","keys_url":"https://api.github.com/repos/tomaszdurka/puppet-packages/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tomaszdurka/puppet-packages/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tomaszdurka/puppet-packages/teams","hooks_url":"https://api.github.com/repos/tomaszdurka/puppet-packages/hooks","issue_events_url":"https://api.github.com/repos/tomaszdurka/puppet-packages/issues/events{/number}","events_url":"https://api.github.com/repos/tomaszdurka/puppet-packages/events","assignees_url":"https://api.github.com/repos/tomaszdurka/puppet-packages/assignees{/user}","branches_url":"https://api.github.com/repos/tomaszdurka/puppet-packages/branches{/branch}","tags_url":"https://api.github.com/repos/tomaszdurka/puppet-packages/tags","blobs_url":"https://api.github.com/repos/tomaszdurka/puppet-packages/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tomaszdurka/puppet-packages/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tomaszdurka/puppet-packages/git/refs{/sha}","trees_url":"https://api.github.com/repos/tomaszdurka/puppet-packages/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tomaszdurka/puppet-packages/statuses/{sha}","languages_url":"https://api.github.com/repos/tomaszdurka/puppet-packages/languages","stargazers_url":"https://api.github.com/repos/tomaszdurka/puppet-packages/stargazers","contributors_url":"https://api.github.com/repos/tomaszdurka/puppet-packages/contributors","subscribers_url":"https://api.github.com/repos/tomaszdurka/puppet-packages/subscribers","subscription_url":"https://api.github.com/repos/tomaszdurka/puppet-packages/subscription","commits_url":"https://api.github.com/repos/tomaszdurka/puppet-packages/commits{/sha}","git_commits_url":"https://api.github.com/repos/tomaszdurka/puppet-packages/git/commits{/sha}","comments_url":"https://api.github.com/repos/tomaszdurka/puppet-packages/comments{/number}","issue_comment_url":"https://api.github.com/repos/tomaszdurka/puppet-packages/issues/comments{/number}","contents_url":"https://api.github.com/repos/tomaszdurka/puppet-packages/contents/{+path}","compare_url":"https://api.github.com/repos/tomaszdurka/puppet-packages/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tomaszdurka/puppet-packages/merges","archive_url":"https://api.github.com/repos/tomaszdurka/puppet-packages/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tomaszdurka/puppet-packages/downloads","issues_url":"https://api.github.com/repos/tomaszdurka/puppet-packages/issues{/number}","pulls_url":"https://api.github.com/repos/tomaszdurka/puppet-packages/pulls{/number}","milestones_url":"https://api.github.com/repos/tomaszdurka/puppet-packages/milestones{/number}","notifications_url":"https://api.github.com/repos/tomaszdurka/puppet-packages/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tomaszdurka/puppet-packages/labels{/name}","releases_url":"https://api.github.com/repos/tomaszdurka/puppet-packages/releases{/id}","created_at":"2013-06-04T18:10:18Z","updated_at":"2014-06-06T11:35:57Z","pushed_at":"2015-11-26T11:33:59Z","git_url":"git://github.com/tomaszdurka/puppet-packages.git","ssh_url":"git@github.com:tomaszdurka/puppet-packages.git","clone_url":"https://github.com/tomaszdurka/puppet-packages.git","svn_url":"https://github.com/tomaszdurka/puppet-packages","homepage":null,"size":3146,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cargomedia:master","ref":"master","sha":"477a4f9415d5b44e1b7b88df94bccf9dffd32b1f","user":{"login":"cargomedia","id":1699929,"avatar_url":"https://avatars.githubusercontent.com/u/1699929?v=3","gravatar_id":"","url":"https://api.github.com/users/cargomedia","html_url":"https://github.com/cargomedia","followers_url":"https://api.github.com/users/cargomedia/followers","following_url":"https://api.github.com/users/cargomedia/following{/other_user}","gists_url":"https://api.github.com/users/cargomedia/gists{/gist_id}","starred_url":"https://api.github.com/users/cargomedia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cargomedia/subscriptions","organizations_url":"https://api.github.com/users/cargomedia/orgs","repos_url":"https://api.github.com/users/cargomedia/repos","events_url":"https://api.github.com/users/cargomedia/events{/privacy}","received_events_url":"https://api.github.com/users/cargomedia/received_events","type":"Organization","site_admin":false},"repo":{"id":10485244,"name":"puppet-packages","full_name":"cargomedia/puppet-packages","owner":{"login":"cargomedia","id":1699929,"avatar_url":"https://avatars.githubusercontent.com/u/1699929?v=3","gravatar_id":"","url":"https://api.github.com/users/cargomedia","html_url":"https://github.com/cargomedia","followers_url":"https://api.github.com/users/cargomedia/followers","following_url":"https://api.github.com/users/cargomedia/following{/other_user}","gists_url":"https://api.github.com/users/cargomedia/gists{/gist_id}","starred_url":"https://api.github.com/users/cargomedia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cargomedia/subscriptions","organizations_url":"https://api.github.com/users/cargomedia/orgs","repos_url":"https://api.github.com/users/cargomedia/repos","events_url":"https://api.github.com/users/cargomedia/events{/privacy}","received_events_url":"https://api.github.com/users/cargomedia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cargomedia/puppet-packages","description":"Reusable puppet modules for Debian","fork":false,"url":"https://api.github.com/repos/cargomedia/puppet-packages","forks_url":"https://api.github.com/repos/cargomedia/puppet-packages/forks","keys_url":"https://api.github.com/repos/cargomedia/puppet-packages/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cargomedia/puppet-packages/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cargomedia/puppet-packages/teams","hooks_url":"https://api.github.com/repos/cargomedia/puppet-packages/hooks","issue_events_url":"https://api.github.com/repos/cargomedia/puppet-packages/issues/events{/number}","events_url":"https://api.github.com/repos/cargomedia/puppet-packages/events","assignees_url":"https://api.github.com/repos/cargomedia/puppet-packages/assignees{/user}","branches_url":"https://api.github.com/repos/cargomedia/puppet-packages/branches{/branch}","tags_url":"https://api.github.com/repos/cargomedia/puppet-packages/tags","blobs_url":"https://api.github.com/repos/cargomedia/puppet-packages/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cargomedia/puppet-packages/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cargomedia/puppet-packages/git/refs{/sha}","trees_url":"https://api.github.com/repos/cargomedia/puppet-packages/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cargomedia/puppet-packages/statuses/{sha}","languages_url":"https://api.github.com/repos/cargomedia/puppet-packages/languages","stargazers_url":"https://api.github.com/repos/cargomedia/puppet-packages/stargazers","contributors_url":"https://api.github.com/repos/cargomedia/puppet-packages/contributors","subscribers_url":"https://api.github.com/repos/cargomedia/puppet-packages/subscribers","subscription_url":"https://api.github.com/repos/cargomedia/puppet-packages/subscription","commits_url":"https://api.github.com/repos/cargomedia/puppet-packages/commits{/sha}","git_commits_url":"https://api.github.com/repos/cargomedia/puppet-packages/git/commits{/sha}","comments_url":"https://api.github.com/repos/cargomedia/puppet-packages/comments{/number}","issue_comment_url":"https://api.github.com/repos/cargomedia/puppet-packages/issues/comments{/number}","contents_url":"https://api.github.com/repos/cargomedia/puppet-packages/contents/{+path}","compare_url":"https://api.github.com/repos/cargomedia/puppet-packages/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cargomedia/puppet-packages/merges","archive_url":"https://api.github.com/repos/cargomedia/puppet-packages/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cargomedia/puppet-packages/downloads","issues_url":"https://api.github.com/repos/cargomedia/puppet-packages/issues{/number}","pulls_url":"https://api.github.com/repos/cargomedia/puppet-packages/pulls{/number}","milestones_url":"https://api.github.com/repos/cargomedia/puppet-packages/milestones{/number}","notifications_url":"https://api.github.com/repos/cargomedia/puppet-packages/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cargomedia/puppet-packages/labels{/name}","releases_url":"https://api.github.com/repos/cargomedia/puppet-packages/releases{/id}","created_at":"2013-06-04T18:05:41Z","updated_at":"2015-06-29T13:29:16Z","pushed_at":"2015-11-26T13:46:34Z","git_url":"git://github.com/cargomedia/puppet-packages.git","ssh_url":"git@github.com:cargomedia/puppet-packages.git","clone_url":"https://github.com/cargomedia/puppet-packages.git","svn_url":"https://github.com/cargomedia/puppet-packages","homepage":"","size":3341,"stargazers_count":5,"watchers_count":5,"language":"Puppet","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":22,"forks":10,"open_issues":22,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cargomedia/puppet-packages/pulls/997"},"html":{"href":"https://github.com/cargomedia/puppet-packages/pull/997"},"issue":{"href":"https://api.github.com/repos/cargomedia/puppet-packages/issues/997"},"comments":{"href":"https://api.github.com/repos/cargomedia/puppet-packages/issues/997/comments"},"review_comments":{"href":"https://api.github.com/repos/cargomedia/puppet-packages/pulls/997/comments"},"review_comment":{"href":"https://api.github.com/repos/cargomedia/puppet-packages/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cargomedia/puppet-packages/pulls/997/commits"},"statuses":{"href":"https://api.github.com/repos/cargomedia/puppet-packages/statuses/24fb5209122cafcbbef2283417d0c36b7da57d85"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"tomaszdurka","id":113303,"avatar_url":"https://avatars.githubusercontent.com/u/113303?v=3","gravatar_id":"","url":"https://api.github.com/users/tomaszdurka","html_url":"https://github.com/tomaszdurka","followers_url":"https://api.github.com/users/tomaszdurka/followers","following_url":"https://api.github.com/users/tomaszdurka/following{/other_user}","gists_url":"https://api.github.com/users/tomaszdurka/gists{/gist_id}","starred_url":"https://api.github.com/users/tomaszdurka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomaszdurka/subscriptions","organizations_url":"https://api.github.com/users/tomaszdurka/orgs","repos_url":"https://api.github.com/users/tomaszdurka/repos","events_url":"https://api.github.com/users/tomaszdurka/events{/privacy}","received_events_url":"https://api.github.com/users/tomaszdurka/received_events","type":"User","site_admin":false},"comments":16,"review_comments":0,"commits":16,"additions":544,"deletions":159,"changed_files":144}}