{"action":"created","comment":{"url":"https://api.github.com/repos/PCSX2/pcsx2/pulls/comments/41711870","id":41711870,"diff_hunk":"@@ -294,6 +294,20 @@ void Pcsx2App::PadKeyDispatch( const keyEvent& ev )\n \n \tm_kevt.m_keyCode = vkey? vkey : ev.key;\n \n+\tif (DevConWriterEnabled && m_kevt.GetEventType() == wxEVT_KEY_DOWN) {\n+\t\twxString strFromCode = wxAcceleratorEntry(0, m_kevt.m_keyCode).ToString();\n+\t\tif (strFromCode == \"\\\\\")\n+\t\t\tstrFromCode = \"\\\\\\\\\"; // If copied into PCSX2_keys.ini, \\ needs escaping\n+\n+\t\t// for some reason it doesn't work with extra %ld, so extend the fmt string with it.\n+\t\tConsole.WriteLn(wxString(L\"> Key: %ls%ls%ls%s\") + pxsFmt(L\" (code: %ld)\", m_kevt.m_keyCode),\n+\t\t\t(m_kevt.m_altDown ? L\"Alt-\" : L\"\"),\n+\t\t\t(m_kevt.m_controlDown ? L\"Ctrl-\" : L\"\"),\n+\t\t\t(m_kevt.m_shiftDown ? L\"Shift-\" : L\"\"),\n+\t\t\tstrFromCode.c_str()","path":"pcsx2/gui/AppMain.cpp","position":14,"original_position":14,"commit_id":"25d2c20f1ac3a72fd4c40f8b14b319bf8de72c4a","original_commit_id":"25d2c20f1ac3a72fd4c40f8b14b319bf8de72c4a","user":{"login":"turtleli","id":10976277,"avatar_url":"https://avatars.githubusercontent.com/u/10976277?v=3","gravatar_id":"","url":"https://api.github.com/users/turtleli","html_url":"https://github.com/turtleli","followers_url":"https://api.github.com/users/turtleli/followers","following_url":"https://api.github.com/users/turtleli/following{/other_user}","gists_url":"https://api.github.com/users/turtleli/gists{/gist_id}","starred_url":"https://api.github.com/users/turtleli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/turtleli/subscriptions","organizations_url":"https://api.github.com/users/turtleli/orgs","repos_url":"https://api.github.com/users/turtleli/repos","events_url":"https://api.github.com/users/turtleli/events{/privacy}","received_events_url":"https://api.github.com/users/turtleli/received_events","type":"User","site_admin":false},"body":"Needs to be WX_STR(strFromCode), otherwise it outputs garbage on Windows, and fails to compile on Linux. That's probably why the extra %ld didn't work properly.","created_at":"2015-10-11T15:32:59Z","updated_at":"2015-10-11T15:32:59Z","html_url":"https://github.com/PCSX2/pcsx2/pull/887#discussion_r41711870","pull_request_url":"https://api.github.com/repos/PCSX2/pcsx2/pulls/887","_links":{"self":{"href":"https://api.github.com/repos/PCSX2/pcsx2/pulls/comments/41711870"},"html":{"href":"https://github.com/PCSX2/pcsx2/pull/887#discussion_r41711870"},"pull_request":{"href":"https://api.github.com/repos/PCSX2/pcsx2/pulls/887"}}},"pull_request":{"url":"https://api.github.com/repos/PCSX2/pcsx2/pulls/887","id":47355879,"html_url":"https://github.com/PCSX2/pcsx2/pull/887","diff_url":"https://github.com/PCSX2/pcsx2/pull/887.diff","patch_url":"https://github.com/PCSX2/pcsx2/pull/887.patch","issue_url":"https://api.github.com/repos/PCSX2/pcsx2/issues/887","number":887,"state":"open","locked":false,"title":"gui: kb shortcuts: fix incorrect wx key codes for \"plain\" keys","user":{"login":"avih","id":2164962,"avatar_url":"https://avatars.githubusercontent.com/u/2164962?v=3","gravatar_id":"","url":"https://api.github.com/users/avih","html_url":"https://github.com/avih","followers_url":"https://api.github.com/users/avih/followers","following_url":"https://api.github.com/users/avih/following{/other_user}","gists_url":"https://api.github.com/users/avih/gists{/gist_id}","starred_url":"https://api.github.com/users/avih/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avih/subscriptions","organizations_url":"https://api.github.com/users/avih/orgs","repos_url":"https://api.github.com/users/avih/repos","events_url":"https://api.github.com/users/avih/events{/privacy}","received_events_url":"https://api.github.com/users/avih/received_events","type":"User","site_admin":false},"body":"This fixes two issues which were observed on windows:\r\n- plain letters: wx passes the capital code (e.g. 81 instead of 113 for 'q')\r\n- symbol-only keys: just incorrect code (e.g. 219 instead of 91 for '[')\r\n\r\nFor both these cases, holding e.g. shift correctly has the shift flag set, and\r\nthe key code remains the same.\r\n\r\nThis should allow using letters and symbols at PCSX2_keys.ini\r\n\r\nNote: this should have supposedly been fixed at r4918 ( 851bfba ), but neither\r\nthat build from the buildbot archive, nor the official 1.2.1 release (r5875),\r\nnor the current builds have this working, which is really weird (tested on win8)","created_at":"2015-10-10T22:54:12Z","updated_at":"2015-10-11T15:32:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b764bb15110681c4a342178526d84ae123c99286","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/PCSX2/pcsx2/pulls/887/commits","review_comments_url":"https://api.github.com/repos/PCSX2/pcsx2/pulls/887/comments","review_comment_url":"https://api.github.com/repos/PCSX2/pcsx2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PCSX2/pcsx2/issues/887/comments","statuses_url":"https://api.github.com/repos/PCSX2/pcsx2/statuses/25d2c20f1ac3a72fd4c40f8b14b319bf8de72c4a","head":{"label":"PCSX2:wx-normal-keys","ref":"wx-normal-keys","sha":"25d2c20f1ac3a72fd4c40f8b14b319bf8de72c4a","user":{"login":"PCSX2","id":6278711,"avatar_url":"https://avatars.githubusercontent.com/u/6278711?v=3","gravatar_id":"","url":"https://api.github.com/users/PCSX2","html_url":"https://github.com/PCSX2","followers_url":"https://api.github.com/users/PCSX2/followers","following_url":"https://api.github.com/users/PCSX2/following{/other_user}","gists_url":"https://api.github.com/users/PCSX2/gists{/gist_id}","starred_url":"https://api.github.com/users/PCSX2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PCSX2/subscriptions","organizations_url":"https://api.github.com/users/PCSX2/orgs","repos_url":"https://api.github.com/users/PCSX2/repos","events_url":"https://api.github.com/users/PCSX2/events{/privacy}","received_events_url":"https://api.github.com/users/PCSX2/received_events","type":"Organization","site_admin":false},"repo":{"id":15379620,"name":"pcsx2","full_name":"PCSX2/pcsx2","owner":{"login":"PCSX2","id":6278711,"avatar_url":"https://avatars.githubusercontent.com/u/6278711?v=3","gravatar_id":"","url":"https://api.github.com/users/PCSX2","html_url":"https://github.com/PCSX2","followers_url":"https://api.github.com/users/PCSX2/followers","following_url":"https://api.github.com/users/PCSX2/following{/other_user}","gists_url":"https://api.github.com/users/PCSX2/gists{/gist_id}","starred_url":"https://api.github.com/users/PCSX2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PCSX2/subscriptions","organizations_url":"https://api.github.com/users/PCSX2/orgs","repos_url":"https://api.github.com/users/PCSX2/repos","events_url":"https://api.github.com/users/PCSX2/events{/privacy}","received_events_url":"https://api.github.com/users/PCSX2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PCSX2/pcsx2","description":"PCSX2 - The Playstation 2 Emulator","fork":false,"url":"https://api.github.com/repos/PCSX2/pcsx2","forks_url":"https://api.github.com/repos/PCSX2/pcsx2/forks","keys_url":"https://api.github.com/repos/PCSX2/pcsx2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PCSX2/pcsx2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PCSX2/pcsx2/teams","hooks_url":"https://api.github.com/repos/PCSX2/pcsx2/hooks","issue_events_url":"https://api.github.com/repos/PCSX2/pcsx2/issues/events{/number}","events_url":"https://api.github.com/repos/PCSX2/pcsx2/events","assignees_url":"https://api.github.com/repos/PCSX2/pcsx2/assignees{/user}","branches_url":"https://api.github.com/repos/PCSX2/pcsx2/branches{/branch}","tags_url":"https://api.github.com/repos/PCSX2/pcsx2/tags","blobs_url":"https://api.github.com/repos/PCSX2/pcsx2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PCSX2/pcsx2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PCSX2/pcsx2/git/refs{/sha}","trees_url":"https://api.github.com/repos/PCSX2/pcsx2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PCSX2/pcsx2/statuses/{sha}","languages_url":"https://api.github.com/repos/PCSX2/pcsx2/languages","stargazers_url":"https://api.github.com/repos/PCSX2/pcsx2/stargazers","contributors_url":"https://api.github.com/repos/PCSX2/pcsx2/contributors","subscribers_url":"https://api.github.com/repos/PCSX2/pcsx2/subscribers","subscription_url":"https://api.github.com/repos/PCSX2/pcsx2/subscription","commits_url":"https://api.github.com/repos/PCSX2/pcsx2/commits{/sha}","git_commits_url":"https://api.github.com/repos/PCSX2/pcsx2/git/commits{/sha}","comments_url":"https://api.github.com/repos/PCSX2/pcsx2/comments{/number}","issue_comment_url":"https://api.github.com/repos/PCSX2/pcsx2/issues/comments{/number}","contents_url":"https://api.github.com/repos/PCSX2/pcsx2/contents/{+path}","compare_url":"https://api.github.com/repos/PCSX2/pcsx2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PCSX2/pcsx2/merges","archive_url":"https://api.github.com/repos/PCSX2/pcsx2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PCSX2/pcsx2/downloads","issues_url":"https://api.github.com/repos/PCSX2/pcsx2/issues{/number}","pulls_url":"https://api.github.com/repos/PCSX2/pcsx2/pulls{/number}","milestones_url":"https://api.github.com/repos/PCSX2/pcsx2/milestones{/number}","notifications_url":"https://api.github.com/repos/PCSX2/pcsx2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PCSX2/pcsx2/labels{/name}","releases_url":"https://api.github.com/repos/PCSX2/pcsx2/releases{/id}","created_at":"2013-12-22T17:56:48Z","updated_at":"2015-10-11T02:48:09Z","pushed_at":"2015-10-11T14:38:45Z","git_url":"git://github.com/PCSX2/pcsx2.git","ssh_url":"git@github.com:PCSX2/pcsx2.git","clone_url":"https://github.com/PCSX2/pcsx2.git","svn_url":"https://github.com/PCSX2/pcsx2","homepage":"http://pcsx2.net/","size":109638,"stargazers_count":884,"watchers_count":884,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":222,"mirror_url":null,"open_issues_count":184,"forks":222,"open_issues":184,"watchers":884,"default_branch":"master"}},"base":{"label":"PCSX2:master","ref":"master","sha":"31ee576d6a0f015199d91948602a79bcc64c2d22","user":{"login":"PCSX2","id":6278711,"avatar_url":"https://avatars.githubusercontent.com/u/6278711?v=3","gravatar_id":"","url":"https://api.github.com/users/PCSX2","html_url":"https://github.com/PCSX2","followers_url":"https://api.github.com/users/PCSX2/followers","following_url":"https://api.github.com/users/PCSX2/following{/other_user}","gists_url":"https://api.github.com/users/PCSX2/gists{/gist_id}","starred_url":"https://api.github.com/users/PCSX2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PCSX2/subscriptions","organizations_url":"https://api.github.com/users/PCSX2/orgs","repos_url":"https://api.github.com/users/PCSX2/repos","events_url":"https://api.github.com/users/PCSX2/events{/privacy}","received_events_url":"https://api.github.com/users/PCSX2/received_events","type":"Organization","site_admin":false},"repo":{"id":15379620,"name":"pcsx2","full_name":"PCSX2/pcsx2","owner":{"login":"PCSX2","id":6278711,"avatar_url":"https://avatars.githubusercontent.com/u/6278711?v=3","gravatar_id":"","url":"https://api.github.com/users/PCSX2","html_url":"https://github.com/PCSX2","followers_url":"https://api.github.com/users/PCSX2/followers","following_url":"https://api.github.com/users/PCSX2/following{/other_user}","gists_url":"https://api.github.com/users/PCSX2/gists{/gist_id}","starred_url":"https://api.github.com/users/PCSX2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PCSX2/subscriptions","organizations_url":"https://api.github.com/users/PCSX2/orgs","repos_url":"https://api.github.com/users/PCSX2/repos","events_url":"https://api.github.com/users/PCSX2/events{/privacy}","received_events_url":"https://api.github.com/users/PCSX2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PCSX2/pcsx2","description":"PCSX2 - The Playstation 2 Emulator","fork":false,"url":"https://api.github.com/repos/PCSX2/pcsx2","forks_url":"https://api.github.com/repos/PCSX2/pcsx2/forks","keys_url":"https://api.github.com/repos/PCSX2/pcsx2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PCSX2/pcsx2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PCSX2/pcsx2/teams","hooks_url":"https://api.github.com/repos/PCSX2/pcsx2/hooks","issue_events_url":"https://api.github.com/repos/PCSX2/pcsx2/issues/events{/number}","events_url":"https://api.github.com/repos/PCSX2/pcsx2/events","assignees_url":"https://api.github.com/repos/PCSX2/pcsx2/assignees{/user}","branches_url":"https://api.github.com/repos/PCSX2/pcsx2/branches{/branch}","tags_url":"https://api.github.com/repos/PCSX2/pcsx2/tags","blobs_url":"https://api.github.com/repos/PCSX2/pcsx2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PCSX2/pcsx2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PCSX2/pcsx2/git/refs{/sha}","trees_url":"https://api.github.com/repos/PCSX2/pcsx2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PCSX2/pcsx2/statuses/{sha}","languages_url":"https://api.github.com/repos/PCSX2/pcsx2/languages","stargazers_url":"https://api.github.com/repos/PCSX2/pcsx2/stargazers","contributors_url":"https://api.github.com/repos/PCSX2/pcsx2/contributors","subscribers_url":"https://api.github.com/repos/PCSX2/pcsx2/subscribers","subscription_url":"https://api.github.com/repos/PCSX2/pcsx2/subscription","commits_url":"https://api.github.com/repos/PCSX2/pcsx2/commits{/sha}","git_commits_url":"https://api.github.com/repos/PCSX2/pcsx2/git/commits{/sha}","comments_url":"https://api.github.com/repos/PCSX2/pcsx2/comments{/number}","issue_comment_url":"https://api.github.com/repos/PCSX2/pcsx2/issues/comments{/number}","contents_url":"https://api.github.com/repos/PCSX2/pcsx2/contents/{+path}","compare_url":"https://api.github.com/repos/PCSX2/pcsx2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PCSX2/pcsx2/merges","archive_url":"https://api.github.com/repos/PCSX2/pcsx2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PCSX2/pcsx2/downloads","issues_url":"https://api.github.com/repos/PCSX2/pcsx2/issues{/number}","pulls_url":"https://api.github.com/repos/PCSX2/pcsx2/pulls{/number}","milestones_url":"https://api.github.com/repos/PCSX2/pcsx2/milestones{/number}","notifications_url":"https://api.github.com/repos/PCSX2/pcsx2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PCSX2/pcsx2/labels{/name}","releases_url":"https://api.github.com/repos/PCSX2/pcsx2/releases{/id}","created_at":"2013-12-22T17:56:48Z","updated_at":"2015-10-11T02:48:09Z","pushed_at":"2015-10-11T14:38:45Z","git_url":"git://github.com/PCSX2/pcsx2.git","ssh_url":"git@github.com:PCSX2/pcsx2.git","clone_url":"https://github.com/PCSX2/pcsx2.git","svn_url":"https://github.com/PCSX2/pcsx2","homepage":"http://pcsx2.net/","size":109638,"stargazers_count":884,"watchers_count":884,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":222,"mirror_url":null,"open_issues_count":184,"forks":222,"open_issues":184,"watchers":884,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PCSX2/pcsx2/pulls/887"},"html":{"href":"https://github.com/PCSX2/pcsx2/pull/887"},"issue":{"href":"https://api.github.com/repos/PCSX2/pcsx2/issues/887"},"comments":{"href":"https://api.github.com/repos/PCSX2/pcsx2/issues/887/comments"},"review_comments":{"href":"https://api.github.com/repos/PCSX2/pcsx2/pulls/887/comments"},"review_comment":{"href":"https://api.github.com/repos/PCSX2/pcsx2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PCSX2/pcsx2/pulls/887/commits"},"statuses":{"href":"https://api.github.com/repos/PCSX2/pcsx2/statuses/25d2c20f1ac3a72fd4c40f8b14b319bf8de72c4a"}}}}