{"action":"created","issue":{"url":"https://api.github.com/repos/springnz/smack-scala/issues/9","labels_url":"https://api.github.com/repos/springnz/smack-scala/issues/9/labels{/name}","comments_url":"https://api.github.com/repos/springnz/smack-scala/issues/9/comments","events_url":"https://api.github.com/repos/springnz/smack-scala/issues/9/events","html_url":"https://github.com/springnz/smack-scala/pull/9","id":111527350,"number":9,"title":"Multi user chat","user":{"login":"mikkelspring","id":14224932,"avatar_url":"https://avatars.githubusercontent.com/u/14224932?v=3","gravatar_id":"","url":"https://api.github.com/users/mikkelspring","html_url":"https://github.com/mikkelspring","followers_url":"https://api.github.com/users/mikkelspring/followers","following_url":"https://api.github.com/users/mikkelspring/following{/other_user}","gists_url":"https://api.github.com/users/mikkelspring/gists{/gist_id}","starred_url":"https://api.github.com/users/mikkelspring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikkelspring/subscriptions","organizations_url":"https://api.github.com/users/mikkelspring/orgs","repos_url":"https://api.github.com/users/mikkelspring/repos","events_url":"https://api.github.com/users/mikkelspring/events{/privacy}","received_events_url":"https://api.github.com/users/mikkelspring/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-10-15T01:34:25Z","updated_at":"2015-10-15T02:40:49Z","closed_at":"2015-10-15T02:06:01Z","pull_request":{"url":"https://api.github.com/repos/springnz/smack-scala/pulls/9","html_url":"https://github.com/springnz/smack-scala/pull/9","diff_url":"https://github.com/springnz/smack-scala/pull/9.diff","patch_url":"https://github.com/springnz/smack-scala/pull/9.patch"},"body":"Allows admin to create a closed room and register users to get access"},"comment":{"url":"https://api.github.com/repos/springnz/smack-scala/issues/comments/148263255","html_url":"https://github.com/springnz/smack-scala/pull/9#issuecomment-148263255","issue_url":"https://api.github.com/repos/springnz/smack-scala/issues/9","id":148263255,"user":{"login":"KadekM","id":4306279,"avatar_url":"https://avatars.githubusercontent.com/u/4306279?v=3","gravatar_id":"","url":"https://api.github.com/users/KadekM","html_url":"https://github.com/KadekM","followers_url":"https://api.github.com/users/KadekM/followers","following_url":"https://api.github.com/users/KadekM/following{/other_user}","gists_url":"https://api.github.com/users/KadekM/gists{/gist_id}","starred_url":"https://api.github.com/users/KadekM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KadekM/subscriptions","organizations_url":"https://api.github.com/users/KadekM/orgs","repos_url":"https://api.github.com/users/KadekM/repos","events_url":"https://api.github.com/users/KadekM/events{/privacy}","received_events_url":"https://api.github.com/users/KadekM/received_events","type":"User","site_admin":false},"created_at":"2015-10-15T02:40:49Z","updated_at":"2015-10-15T02:40:49Z","body":"That doesn't really make it better. So if client is handling that specific error, and stringly typed message is changed, he will be a bit surprised for getting just the generic message.\r\n\r\nIt looks a bit weird that now actor turned into 100% receive-respond type of thing -> I don't really see benefit of returning success messages, especially since none of them hold any data.\r\n\r\nI would delete all ActorSuccess and ActorFailure responses, let exception bubble to parent of Client, and let him handle the situation (whether its resuming operation normally, restarting or killing it all together). Usage of actors like this don't 100% make sense to me! But if it works for you / @mpollmeier thats fine and feel free to ignore me :)\r\n\r\n------------------------------\r\nalso ` uploadAdapter.upload(file, description)` should take ExecutionContext, it should not be hardcoded in implementation of the adapter. Either\r\na) make adapter not return Future, thus being synchronous, then client knows he needs to start future\r\nb) put EC as argument, so client can specify which ec he wants the future to run on\r\nI prefer (b)"}}