{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/openshift-sdn/pulls/comments/36560319","id":36560319,"diff_hunk":"@@ -230,6 +238,11 @@ func (sub *EtcdSubnetRegistry) GetContainerNetwork() (string, error) {\n \treturn resp.Node.Value, err\n }\n \n+func (sub *EtcdSubnetRegistry) GetServicesNetwork() (string, error) {\n+\t// FIXME\n+\treturn \"172.30.0.0/16\", nil","path":"ovssubnet/registry/registry.go","position":21,"original_position":21,"commit_id":"b19a39fc62ef9414f9f9e38e00d30f25cc3331e0","original_commit_id":"b19a39fc62ef9414f9f9e38e00d30f25cc3331e0","user":{"login":"rajatchopra","id":982221,"avatar_url":"https://avatars.githubusercontent.com/u/982221?v=3","gravatar_id":"","url":"https://api.github.com/users/rajatchopra","html_url":"https://github.com/rajatchopra","followers_url":"https://api.github.com/users/rajatchopra/followers","following_url":"https://api.github.com/users/rajatchopra/following{/other_user}","gists_url":"https://api.github.com/users/rajatchopra/gists{/gist_id}","starred_url":"https://api.github.com/users/rajatchopra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rajatchopra/subscriptions","organizations_url":"https://api.github.com/users/rajatchopra/orgs","repos_url":"https://api.github.com/users/rajatchopra/repos","events_url":"https://api.github.com/users/rajatchopra/events{/privacy}","received_events_url":"https://api.github.com/users/rajatchopra/received_events","type":"User","site_admin":false},"body":"Do we need to create a resource for it?","created_at":"2015-08-07T20:54:36Z","updated_at":"2015-08-07T20:54:36Z","html_url":"https://github.com/openshift/openshift-sdn/pull/115#discussion_r36560319","pull_request_url":"https://api.github.com/repos/openshift/openshift-sdn/pulls/115","_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-sdn/pulls/comments/36560319"},"html":{"href":"https://github.com/openshift/openshift-sdn/pull/115#discussion_r36560319"},"pull_request":{"href":"https://api.github.com/repos/openshift/openshift-sdn/pulls/115"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/openshift-sdn/pulls/115","id":41151321,"html_url":"https://github.com/openshift/openshift-sdn/pull/115","diff_url":"https://github.com/openshift/openshift-sdn/pull/115.diff","patch_url":"https://github.com/openshift/openshift-sdn/pull/115.patch","issue_url":"https://api.github.com/repos/openshift/openshift-sdn/issues/115","number":115,"state":"open","locked":false,"title":"service isolation support","user":{"login":"danwinship","id":96040,"avatar_url":"https://avatars.githubusercontent.com/u/96040?v=3","gravatar_id":"","url":"https://api.github.com/users/danwinship","html_url":"https://github.com/danwinship","followers_url":"https://api.github.com/users/danwinship/followers","following_url":"https://api.github.com/users/danwinship/following{/other_user}","gists_url":"https://api.github.com/users/danwinship/gists{/gist_id}","starred_url":"https://api.github.com/users/danwinship/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danwinship/subscriptions","organizations_url":"https://api.github.com/users/danwinship/orgs","repos_url":"https://api.github.com/users/danwinship/repos","events_url":"https://api.github.com/users/danwinship/events{/privacy}","received_events_url":"https://api.github.com/users/danwinship/received_events","type":"User","site_admin":false},"body":"Implementation of the basis of service isolation; does not actually implement it; it will only be implemented in origin","created_at":"2015-07-29T17:44:31Z","updated_at":"2015-08-07T20:54:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2497b9bdbf7ee8134beb5978902ce28ffe477100","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openshift/openshift-sdn/pulls/115/commits","review_comments_url":"https://api.github.com/repos/openshift/openshift-sdn/pulls/115/comments","review_comment_url":"https://api.github.com/repos/openshift/openshift-sdn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/openshift-sdn/issues/115/comments","statuses_url":"https://api.github.com/repos/openshift/openshift-sdn/statuses/b19a39fc62ef9414f9f9e38e00d30f25cc3331e0","head":{"label":"danwinship:service-isolation","ref":"service-isolation","sha":"b19a39fc62ef9414f9f9e38e00d30f25cc3331e0","user":{"login":"danwinship","id":96040,"avatar_url":"https://avatars.githubusercontent.com/u/96040?v=3","gravatar_id":"","url":"https://api.github.com/users/danwinship","html_url":"https://github.com/danwinship","followers_url":"https://api.github.com/users/danwinship/followers","following_url":"https://api.github.com/users/danwinship/following{/other_user}","gists_url":"https://api.github.com/users/danwinship/gists{/gist_id}","starred_url":"https://api.github.com/users/danwinship/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danwinship/subscriptions","organizations_url":"https://api.github.com/users/danwinship/orgs","repos_url":"https://api.github.com/users/danwinship/repos","events_url":"https://api.github.com/users/danwinship/events{/privacy}","received_events_url":"https://api.github.com/users/danwinship/received_events","type":"User","site_admin":false},"repo":{"id":33740026,"name":"openshift-sdn","full_name":"danwinship/openshift-sdn","owner":{"login":"danwinship","id":96040,"avatar_url":"https://avatars.githubusercontent.com/u/96040?v=3","gravatar_id":"","url":"https://api.github.com/users/danwinship","html_url":"https://github.com/danwinship","followers_url":"https://api.github.com/users/danwinship/followers","following_url":"https://api.github.com/users/danwinship/following{/other_user}","gists_url":"https://api.github.com/users/danwinship/gists{/gist_id}","starred_url":"https://api.github.com/users/danwinship/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danwinship/subscriptions","organizations_url":"https://api.github.com/users/danwinship/orgs","repos_url":"https://api.github.com/users/danwinship/repos","events_url":"https://api.github.com/users/danwinship/events{/privacy}","received_events_url":"https://api.github.com/users/danwinship/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/danwinship/openshift-sdn","description":"","fork":true,"url":"https://api.github.com/repos/danwinship/openshift-sdn","forks_url":"https://api.github.com/repos/danwinship/openshift-sdn/forks","keys_url":"https://api.github.com/repos/danwinship/openshift-sdn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danwinship/openshift-sdn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danwinship/openshift-sdn/teams","hooks_url":"https://api.github.com/repos/danwinship/openshift-sdn/hooks","issue_events_url":"https://api.github.com/repos/danwinship/openshift-sdn/issues/events{/number}","events_url":"https://api.github.com/repos/danwinship/openshift-sdn/events","assignees_url":"https://api.github.com/repos/danwinship/openshift-sdn/assignees{/user}","branches_url":"https://api.github.com/repos/danwinship/openshift-sdn/branches{/branch}","tags_url":"https://api.github.com/repos/danwinship/openshift-sdn/tags","blobs_url":"https://api.github.com/repos/danwinship/openshift-sdn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danwinship/openshift-sdn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danwinship/openshift-sdn/git/refs{/sha}","trees_url":"https://api.github.com/repos/danwinship/openshift-sdn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danwinship/openshift-sdn/statuses/{sha}","languages_url":"https://api.github.com/repos/danwinship/openshift-sdn/languages","stargazers_url":"https://api.github.com/repos/danwinship/openshift-sdn/stargazers","contributors_url":"https://api.github.com/repos/danwinship/openshift-sdn/contributors","subscribers_url":"https://api.github.com/repos/danwinship/openshift-sdn/subscribers","subscription_url":"https://api.github.com/repos/danwinship/openshift-sdn/subscription","commits_url":"https://api.github.com/repos/danwinship/openshift-sdn/commits{/sha}","git_commits_url":"https://api.github.com/repos/danwinship/openshift-sdn/git/commits{/sha}","comments_url":"https://api.github.com/repos/danwinship/openshift-sdn/comments{/number}","issue_comment_url":"https://api.github.com/repos/danwinship/openshift-sdn/issues/comments{/number}","contents_url":"https://api.github.com/repos/danwinship/openshift-sdn/contents/{+path}","compare_url":"https://api.github.com/repos/danwinship/openshift-sdn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danwinship/openshift-sdn/merges","archive_url":"https://api.github.com/repos/danwinship/openshift-sdn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danwinship/openshift-sdn/downloads","issues_url":"https://api.github.com/repos/danwinship/openshift-sdn/issues{/number}","pulls_url":"https://api.github.com/repos/danwinship/openshift-sdn/pulls{/number}","milestones_url":"https://api.github.com/repos/danwinship/openshift-sdn/milestones{/number}","notifications_url":"https://api.github.com/repos/danwinship/openshift-sdn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danwinship/openshift-sdn/labels{/name}","releases_url":"https://api.github.com/repos/danwinship/openshift-sdn/releases{/id}","created_at":"2015-04-10T16:58:50Z","updated_at":"2015-04-10T16:58:50Z","pushed_at":"2015-07-30T20:16:25Z","git_url":"git://github.com/danwinship/openshift-sdn.git","ssh_url":"git@github.com:danwinship/openshift-sdn.git","clone_url":"https://github.com/danwinship/openshift-sdn.git","svn_url":"https://github.com/danwinship/openshift-sdn","homepage":null,"size":349,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"db2c91d677a2b801a33bbf67a0ebeb9d433c9810","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":29500061,"name":"openshift-sdn","full_name":"openshift/openshift-sdn","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/openshift-sdn","description":"","fork":false,"url":"https://api.github.com/repos/openshift/openshift-sdn","forks_url":"https://api.github.com/repos/openshift/openshift-sdn/forks","keys_url":"https://api.github.com/repos/openshift/openshift-sdn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/openshift-sdn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/openshift-sdn/teams","hooks_url":"https://api.github.com/repos/openshift/openshift-sdn/hooks","issue_events_url":"https://api.github.com/repos/openshift/openshift-sdn/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/openshift-sdn/events","assignees_url":"https://api.github.com/repos/openshift/openshift-sdn/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/openshift-sdn/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/openshift-sdn/tags","blobs_url":"https://api.github.com/repos/openshift/openshift-sdn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/openshift-sdn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/openshift-sdn/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/openshift-sdn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/openshift-sdn/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/openshift-sdn/languages","stargazers_url":"https://api.github.com/repos/openshift/openshift-sdn/stargazers","contributors_url":"https://api.github.com/repos/openshift/openshift-sdn/contributors","subscribers_url":"https://api.github.com/repos/openshift/openshift-sdn/subscribers","subscription_url":"https://api.github.com/repos/openshift/openshift-sdn/subscription","commits_url":"https://api.github.com/repos/openshift/openshift-sdn/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/openshift-sdn/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/openshift-sdn/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/openshift-sdn/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/openshift-sdn/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/openshift-sdn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/openshift-sdn/merges","archive_url":"https://api.github.com/repos/openshift/openshift-sdn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/openshift-sdn/downloads","issues_url":"https://api.github.com/repos/openshift/openshift-sdn/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/openshift-sdn/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/openshift-sdn/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/openshift-sdn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/openshift-sdn/labels{/name}","releases_url":"https://api.github.com/repos/openshift/openshift-sdn/releases{/id}","created_at":"2015-01-19T22:32:20Z","updated_at":"2015-07-25T06:35:05Z","pushed_at":"2015-08-07T20:53:23Z","git_url":"git://github.com/openshift/openshift-sdn.git","ssh_url":"git@github.com:openshift/openshift-sdn.git","clone_url":"https://github.com/openshift/openshift-sdn.git","svn_url":"https://github.com/openshift/openshift-sdn","homepage":null,"size":1211,"stargazers_count":22,"watchers_count":22,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":23,"mirror_url":null,"open_issues_count":18,"forks":23,"open_issues":18,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-sdn/pulls/115"},"html":{"href":"https://github.com/openshift/openshift-sdn/pull/115"},"issue":{"href":"https://api.github.com/repos/openshift/openshift-sdn/issues/115"},"comments":{"href":"https://api.github.com/repos/openshift/openshift-sdn/issues/115/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/openshift-sdn/pulls/115/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/openshift-sdn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/openshift-sdn/pulls/115/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/openshift-sdn/statuses/b19a39fc62ef9414f9f9e38e00d30f25cc3331e0"}}}}