{"action":"closed","number":240,"pull_request":{"url":"https://api.github.com/repos/torch/torch7/pulls/240","id":36057711,"html_url":"https://github.com/torch/torch7/pull/240","diff_url":"https://github.com/torch/torch7/pull/240.diff","patch_url":"https://github.com/torch/torch7/pull/240.patch","issue_url":"https://api.github.com/repos/torch/torch7/issues/240","number":240,"state":"closed","locked":false,"title":"Adding support for Storage views and exposing Storage type.","user":{"login":"zakattacktwitter","id":4247897,"avatar_url":"https://avatars.githubusercontent.com/u/4247897?v=3","gravatar_id":"","url":"https://api.github.com/users/zakattacktwitter","html_url":"https://github.com/zakattacktwitter","followers_url":"https://api.github.com/users/zakattacktwitter/followers","following_url":"https://api.github.com/users/zakattacktwitter/following{/other_user}","gists_url":"https://api.github.com/users/zakattacktwitter/gists{/gist_id}","starred_url":"https://api.github.com/users/zakattacktwitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zakattacktwitter/subscriptions","organizations_url":"https://api.github.com/users/zakattacktwitter/orgs","repos_url":"https://api.github.com/users/zakattacktwitter/repos","events_url":"https://api.github.com/users/zakattacktwitter/events{/privacy}","received_events_url":"https://api.github.com/users/zakattacktwitter/received_events","type":"User","site_admin":false},"body":"This PR allows storage instances to be a view of another storage. It is similar to the way tensors can share the same underlying storage.\r\n\r\nAll the THStorage->type related code has been removed.","created_at":"2015-05-22T18:38:20Z","updated_at":"2015-05-27T13:53:28Z","closed_at":"2015-05-27T13:53:28Z","merged_at":"2015-05-27T13:53:28Z","merge_commit_sha":"3e07ba1ee8d20f3e2e0e504fd4496a4666805ddd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/torch/torch7/pulls/240/commits","review_comments_url":"https://api.github.com/repos/torch/torch7/pulls/240/comments","review_comment_url":"https://api.github.com/repos/torch/torch7/pulls/comments{/number}","comments_url":"https://api.github.com/repos/torch/torch7/issues/240/comments","statuses_url":"https://api.github.com/repos/torch/torch7/statuses/3e1601ba7368919762d52f0cd309257381567ce1","head":{"label":"zakattacktwitter:ztaylor/storage_view","ref":"ztaylor/storage_view","sha":"3e1601ba7368919762d52f0cd309257381567ce1","user":{"login":"zakattacktwitter","id":4247897,"avatar_url":"https://avatars.githubusercontent.com/u/4247897?v=3","gravatar_id":"","url":"https://api.github.com/users/zakattacktwitter","html_url":"https://github.com/zakattacktwitter","followers_url":"https://api.github.com/users/zakattacktwitter/followers","following_url":"https://api.github.com/users/zakattacktwitter/following{/other_user}","gists_url":"https://api.github.com/users/zakattacktwitter/gists{/gist_id}","starred_url":"https://api.github.com/users/zakattacktwitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zakattacktwitter/subscriptions","organizations_url":"https://api.github.com/users/zakattacktwitter/orgs","repos_url":"https://api.github.com/users/zakattacktwitter/repos","events_url":"https://api.github.com/users/zakattacktwitter/events{/privacy}","received_events_url":"https://api.github.com/users/zakattacktwitter/received_events","type":"User","site_admin":false},"repo":{"id":36085145,"name":"torch7","full_name":"zakattacktwitter/torch7","owner":{"login":"zakattacktwitter","id":4247897,"avatar_url":"https://avatars.githubusercontent.com/u/4247897?v=3","gravatar_id":"","url":"https://api.github.com/users/zakattacktwitter","html_url":"https://github.com/zakattacktwitter","followers_url":"https://api.github.com/users/zakattacktwitter/followers","following_url":"https://api.github.com/users/zakattacktwitter/following{/other_user}","gists_url":"https://api.github.com/users/zakattacktwitter/gists{/gist_id}","starred_url":"https://api.github.com/users/zakattacktwitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zakattacktwitter/subscriptions","organizations_url":"https://api.github.com/users/zakattacktwitter/orgs","repos_url":"https://api.github.com/users/zakattacktwitter/repos","events_url":"https://api.github.com/users/zakattacktwitter/events{/privacy}","received_events_url":"https://api.github.com/users/zakattacktwitter/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zakattacktwitter/torch7","description":"","fork":true,"url":"https://api.github.com/repos/zakattacktwitter/torch7","forks_url":"https://api.github.com/repos/zakattacktwitter/torch7/forks","keys_url":"https://api.github.com/repos/zakattacktwitter/torch7/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zakattacktwitter/torch7/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zakattacktwitter/torch7/teams","hooks_url":"https://api.github.com/repos/zakattacktwitter/torch7/hooks","issue_events_url":"https://api.github.com/repos/zakattacktwitter/torch7/issues/events{/number}","events_url":"https://api.github.com/repos/zakattacktwitter/torch7/events","assignees_url":"https://api.github.com/repos/zakattacktwitter/torch7/assignees{/user}","branches_url":"https://api.github.com/repos/zakattacktwitter/torch7/branches{/branch}","tags_url":"https://api.github.com/repos/zakattacktwitter/torch7/tags","blobs_url":"https://api.github.com/repos/zakattacktwitter/torch7/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zakattacktwitter/torch7/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zakattacktwitter/torch7/git/refs{/sha}","trees_url":"https://api.github.com/repos/zakattacktwitter/torch7/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zakattacktwitter/torch7/statuses/{sha}","languages_url":"https://api.github.com/repos/zakattacktwitter/torch7/languages","stargazers_url":"https://api.github.com/repos/zakattacktwitter/torch7/stargazers","contributors_url":"https://api.github.com/repos/zakattacktwitter/torch7/contributors","subscribers_url":"https://api.github.com/repos/zakattacktwitter/torch7/subscribers","subscription_url":"https://api.github.com/repos/zakattacktwitter/torch7/subscription","commits_url":"https://api.github.com/repos/zakattacktwitter/torch7/commits{/sha}","git_commits_url":"https://api.github.com/repos/zakattacktwitter/torch7/git/commits{/sha}","comments_url":"https://api.github.com/repos/zakattacktwitter/torch7/comments{/number}","issue_comment_url":"https://api.github.com/repos/zakattacktwitter/torch7/issues/comments{/number}","contents_url":"https://api.github.com/repos/zakattacktwitter/torch7/contents/{+path}","compare_url":"https://api.github.com/repos/zakattacktwitter/torch7/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zakattacktwitter/torch7/merges","archive_url":"https://api.github.com/repos/zakattacktwitter/torch7/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zakattacktwitter/torch7/downloads","issues_url":"https://api.github.com/repos/zakattacktwitter/torch7/issues{/number}","pulls_url":"https://api.github.com/repos/zakattacktwitter/torch7/pulls{/number}","milestones_url":"https://api.github.com/repos/zakattacktwitter/torch7/milestones{/number}","notifications_url":"https://api.github.com/repos/zakattacktwitter/torch7/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zakattacktwitter/torch7/labels{/name}","releases_url":"https://api.github.com/repos/zakattacktwitter/torch7/releases{/id}","created_at":"2015-05-22T17:13:33Z","updated_at":"2015-05-22T17:13:34Z","pushed_at":"2015-05-26T21:05:01Z","git_url":"git://github.com/zakattacktwitter/torch7.git","ssh_url":"git@github.com:zakattacktwitter/torch7.git","clone_url":"https://github.com/zakattacktwitter/torch7.git","svn_url":"https://github.com/zakattacktwitter/torch7","homepage":null,"size":3646,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"torch:master","ref":"master","sha":"984865b3f22afece2feff68807404071920a8586","user":{"login":"torch","id":4978924,"avatar_url":"https://avatars.githubusercontent.com/u/4978924?v=3","gravatar_id":"","url":"https://api.github.com/users/torch","html_url":"https://github.com/torch","followers_url":"https://api.github.com/users/torch/followers","following_url":"https://api.github.com/users/torch/following{/other_user}","gists_url":"https://api.github.com/users/torch/gists{/gist_id}","starred_url":"https://api.github.com/users/torch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/torch/subscriptions","organizations_url":"https://api.github.com/users/torch/orgs","repos_url":"https://api.github.com/users/torch/repos","events_url":"https://api.github.com/users/torch/events{/privacy}","received_events_url":"https://api.github.com/users/torch/received_events","type":"Organization","site_admin":false},"repo":{"id":13677187,"name":"torch7","full_name":"torch/torch7","owner":{"login":"torch","id":4978924,"avatar_url":"https://avatars.githubusercontent.com/u/4978924?v=3","gravatar_id":"","url":"https://api.github.com/users/torch","html_url":"https://github.com/torch","followers_url":"https://api.github.com/users/torch/followers","following_url":"https://api.github.com/users/torch/following{/other_user}","gists_url":"https://api.github.com/users/torch/gists{/gist_id}","starred_url":"https://api.github.com/users/torch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/torch/subscriptions","organizations_url":"https://api.github.com/users/torch/orgs","repos_url":"https://api.github.com/users/torch/repos","events_url":"https://api.github.com/users/torch/events{/privacy}","received_events_url":"https://api.github.com/users/torch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/torch/torch7","description":"","fork":false,"url":"https://api.github.com/repos/torch/torch7","forks_url":"https://api.github.com/repos/torch/torch7/forks","keys_url":"https://api.github.com/repos/torch/torch7/keys{/key_id}","collaborators_url":"https://api.github.com/repos/torch/torch7/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/torch/torch7/teams","hooks_url":"https://api.github.com/repos/torch/torch7/hooks","issue_events_url":"https://api.github.com/repos/torch/torch7/issues/events{/number}","events_url":"https://api.github.com/repos/torch/torch7/events","assignees_url":"https://api.github.com/repos/torch/torch7/assignees{/user}","branches_url":"https://api.github.com/repos/torch/torch7/branches{/branch}","tags_url":"https://api.github.com/repos/torch/torch7/tags","blobs_url":"https://api.github.com/repos/torch/torch7/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/torch/torch7/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/torch/torch7/git/refs{/sha}","trees_url":"https://api.github.com/repos/torch/torch7/git/trees{/sha}","statuses_url":"https://api.github.com/repos/torch/torch7/statuses/{sha}","languages_url":"https://api.github.com/repos/torch/torch7/languages","stargazers_url":"https://api.github.com/repos/torch/torch7/stargazers","contributors_url":"https://api.github.com/repos/torch/torch7/contributors","subscribers_url":"https://api.github.com/repos/torch/torch7/subscribers","subscription_url":"https://api.github.com/repos/torch/torch7/subscription","commits_url":"https://api.github.com/repos/torch/torch7/commits{/sha}","git_commits_url":"https://api.github.com/repos/torch/torch7/git/commits{/sha}","comments_url":"https://api.github.com/repos/torch/torch7/comments{/number}","issue_comment_url":"https://api.github.com/repos/torch/torch7/issues/comments{/number}","contents_url":"https://api.github.com/repos/torch/torch7/contents/{+path}","compare_url":"https://api.github.com/repos/torch/torch7/compare/{base}...{head}","merges_url":"https://api.github.com/repos/torch/torch7/merges","archive_url":"https://api.github.com/repos/torch/torch7/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/torch/torch7/downloads","issues_url":"https://api.github.com/repos/torch/torch7/issues{/number}","pulls_url":"https://api.github.com/repos/torch/torch7/pulls{/number}","milestones_url":"https://api.github.com/repos/torch/torch7/milestones{/number}","notifications_url":"https://api.github.com/repos/torch/torch7/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/torch/torch7/labels{/name}","releases_url":"https://api.github.com/repos/torch/torch7/releases{/id}","created_at":"2013-10-18T12:13:58Z","updated_at":"2015-05-27T12:18:36Z","pushed_at":"2015-05-27T13:53:28Z","git_url":"git://github.com/torch/torch7.git","ssh_url":"git@github.com:torch/torch7.git","clone_url":"https://github.com/torch/torch7.git","svn_url":"https://github.com/torch/torch7","homepage":null,"size":3646,"stargazers_count":2005,"watchers_count":2005,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":371,"mirror_url":null,"open_issues_count":25,"forks":371,"open_issues":25,"watchers":2005,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/torch/torch7/pulls/240"},"html":{"href":"https://github.com/torch/torch7/pull/240"},"issue":{"href":"https://api.github.com/repos/torch/torch7/issues/240"},"comments":{"href":"https://api.github.com/repos/torch/torch7/issues/240/comments"},"review_comments":{"href":"https://api.github.com/repos/torch/torch7/pulls/240/comments"},"review_comment":{"href":"https://api.github.com/repos/torch/torch7/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/torch/torch7/pulls/240/commits"},"statuses":{"href":"https://api.github.com/repos/torch/torch7/statuses/3e1601ba7368919762d52f0cd309257381567ce1"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"clementfarabet","id":188959,"avatar_url":"https://avatars.githubusercontent.com/u/188959?v=3","gravatar_id":"","url":"https://api.github.com/users/clementfarabet","html_url":"https://github.com/clementfarabet","followers_url":"https://api.github.com/users/clementfarabet/followers","following_url":"https://api.github.com/users/clementfarabet/following{/other_user}","gists_url":"https://api.github.com/users/clementfarabet/gists{/gist_id}","starred_url":"https://api.github.com/users/clementfarabet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clementfarabet/subscriptions","organizations_url":"https://api.github.com/users/clementfarabet/orgs","repos_url":"https://api.github.com/users/clementfarabet/repos","events_url":"https://api.github.com/users/clementfarabet/events{/privacy}","received_events_url":"https://api.github.com/users/clementfarabet/received_events","type":"User","site_admin":false},"comments":5,"review_comments":17,"commits":8,"additions":77,"deletions":9,"changed_files":5}}