{"action":"created","issue":{"url":"https://api.github.com/repos/RPCS3/rpcs3/issues/1332","labels_url":"https://api.github.com/repos/RPCS3/rpcs3/issues/1332/labels{/name}","comments_url":"https://api.github.com/repos/RPCS3/rpcs3/issues/1332/comments","events_url":"https://api.github.com/repos/RPCS3/rpcs3/issues/1332/events","html_url":"https://github.com/RPCS3/rpcs3/pull/1332","id":120589073,"number":1332,"title":"Move llvm tests to VS unit testing framework","user":{"login":"vlj","id":6413475,"avatar_url":"https://avatars.githubusercontent.com/u/6413475?v=3","gravatar_id":"","url":"https://api.github.com/users/vlj","html_url":"https://github.com/vlj","followers_url":"https://api.github.com/users/vlj/followers","following_url":"https://api.github.com/users/vlj/following{/other_user}","gists_url":"https://api.github.com/users/vlj/gists{/gist_id}","starred_url":"https://api.github.com/users/vlj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vlj/subscriptions","organizations_url":"https://api.github.com/users/vlj/orgs","repos_url":"https://api.github.com/users/vlj/repos","events_url":"https://api.github.com/users/vlj/events{/privacy}","received_events_url":"https://api.github.com/users/vlj/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":21,"created_at":"2015-12-05T21:26:58Z","updated_at":"2015-12-06T22:52:25Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/RPCS3/rpcs3/pulls/1332","html_url":"https://github.com/RPCS3/rpcs3/pull/1332","diff_url":"https://github.com/RPCS3/rpcs3/pull/1332.diff","patch_url":"https://github.com/RPCS3/rpcs3/pull/1332.patch"},"body":"In master llvm tests are located in PPULLVMRecompilerTests.cpp and need to update a manual define to be enabled. When enabled they are run in Compiler constructor and they might interfere with the inner working of rpcs3 since they sometimes write/read to memory. In summary they are quite impracticable.\r\n\r\nThis PR solves this by moving all the testing in rpcs3-tests project introduced some commits ago.\r\nThese 555 tests are now standalone unit tests Inside VS unit testing Framework. They can be run independently or by group if needed. I think they can even be run Inside appveyor if necessary.\r\n\r\nThere are 2 drawbacks atm :\r\n* These tests are obviously Windows specific. I don't think it will be hard to have a non Windows implementation, the Framework only uses 2 macro TEST_CLASS() and TEST_METHOD and an Assert::IsEqual function. Besides if PPULLVM works in Windows there is no reason it doesn't on linux...\r\n* I encounter a pop up \"Warning: IEEE mode not enabled\" when running them which makes the tests requires manual input at the moment. In addition all the FP tests are failing too."},"comment":{"url":"https://api.github.com/repos/RPCS3/rpcs3/issues/comments/162358916","html_url":"https://github.com/RPCS3/rpcs3/pull/1332#issuecomment-162358916","issue_url":"https://api.github.com/repos/RPCS3/rpcs3/issues/1332","id":162358916,"user":{"login":"vlj","id":6413475,"avatar_url":"https://avatars.githubusercontent.com/u/6413475?v=3","gravatar_id":"","url":"https://api.github.com/users/vlj","html_url":"https://github.com/vlj","followers_url":"https://api.github.com/users/vlj/followers","following_url":"https://api.github.com/users/vlj/following{/other_user}","gists_url":"https://api.github.com/users/vlj/gists{/gist_id}","starred_url":"https://api.github.com/users/vlj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vlj/subscriptions","organizations_url":"https://api.github.com/users/vlj/orgs","repos_url":"https://api.github.com/users/vlj/repos","events_url":"https://api.github.com/users/vlj/events{/privacy}","received_events_url":"https://api.github.com/users/vlj/received_events","type":"User","site_admin":false},"created_at":"2015-12-06T22:52:25Z","updated_at":"2015-12-06T22:52:25Z","body":"Forgot reinterpret_cast"}}