{"action":"closed","number":2644,"pull_request":{"url":"https://api.github.com/repos/checkstyle/checkstyle/pulls/2644","id":51472234,"html_url":"https://github.com/checkstyle/checkstyle/pull/2644","diff_url":"https://github.com/checkstyle/checkstyle/pull/2644.diff","patch_url":"https://github.com/checkstyle/checkstyle/pull/2644.patch","issue_url":"https://api.github.com/repos/checkstyle/checkstyle/issues/2644","number":2644,"state":"closed","locked":false,"title":"Fix 'tokens' property in JavadocStyle check","user":{"login":"tsjensen","id":7677131,"avatar_url":"https://avatars.githubusercontent.com/u/7677131?v=3","gravatar_id":"","url":"https://api.github.com/users/tsjensen","html_url":"https://github.com/tsjensen","followers_url":"https://api.github.com/users/tsjensen/followers","following_url":"https://api.github.com/users/tsjensen/following{/other_user}","gists_url":"https://api.github.com/users/tsjensen/gists{/gist_id}","starred_url":"https://api.github.com/users/tsjensen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsjensen/subscriptions","organizations_url":"https://api.github.com/users/tsjensen/orgs","repos_url":"https://api.github.com/users/tsjensen/repos","events_url":"https://api.github.com/users/tsjensen/events{/privacy}","received_events_url":"https://api.github.com/users/tsjensen/received_events","type":"User","site_admin":false},"body":"This is a fix for a problem introduced with Checkstyle 6.10 with commit [#d56a2a3](https://github.com/checkstyle/checkstyle/commit/d56a2a366c6f9e3e8639d492d548ae562b75dc81#diff-6dbb31589372edafae8e79665300f05a), which prevents the *JavadocStyle* check from correctly evaluating the `tokens` property. Since `getRequiredTokens()` was set to return the result of `getAcceptableTokens()`, the `tokens` property was effectively disabled.\r\n\r\nFor example, the following configuration, which checks end-of-sentence format exclusively on methods, is no longer possible:\r\n\r\n```xml\r\n<module name=\"JavadocStyle\">\r\n  <property name=\"severity\" value=\"info\"/>\r\n  <property name=\"tokens\" value=\"METHOD_DEF\"/>\r\n  <property name=\"scope\" value=\"public\"/>\r\n  <property name=\"checkFirstSentence\" value=\"true\"/>\r\n  <property name=\"checkEmptyJavadoc\" value=\"false\"/>\r\n  <property name=\"checkHtml\" value=\"false\"/>\r\n</module>\r\n```\r\nThis PR restores the pre-6.10 behavior of configurable tokens and adds a test case for the above configuration.","created_at":"2015-11-22T19:27:11Z","updated_at":"2015-12-03T22:25:12Z","closed_at":"2015-12-03T22:25:12Z","merged_at":"2015-12-03T22:25:12Z","merge_commit_sha":"1e2804c3d82393f322b0c285301c6052dd75dd27","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/checkstyle/checkstyle/pulls/2644/commits","review_comments_url":"https://api.github.com/repos/checkstyle/checkstyle/pulls/2644/comments","review_comment_url":"https://api.github.com/repos/checkstyle/checkstyle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/checkstyle/checkstyle/issues/2644/comments","statuses_url":"https://api.github.com/repos/checkstyle/checkstyle/statuses/e9e8d2f0a76601762e59f4743f0df0c792bea44d","head":{"label":"tsjensen:javadocDot","ref":"javadocDot","sha":"e9e8d2f0a76601762e59f4743f0df0c792bea44d","user":{"login":"tsjensen","id":7677131,"avatar_url":"https://avatars.githubusercontent.com/u/7677131?v=3","gravatar_id":"","url":"https://api.github.com/users/tsjensen","html_url":"https://github.com/tsjensen","followers_url":"https://api.github.com/users/tsjensen/followers","following_url":"https://api.github.com/users/tsjensen/following{/other_user}","gists_url":"https://api.github.com/users/tsjensen/gists{/gist_id}","starred_url":"https://api.github.com/users/tsjensen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsjensen/subscriptions","organizations_url":"https://api.github.com/users/tsjensen/orgs","repos_url":"https://api.github.com/users/tsjensen/repos","events_url":"https://api.github.com/users/tsjensen/events{/privacy}","received_events_url":"https://api.github.com/users/tsjensen/received_events","type":"User","site_admin":false},"repo":{"id":37336967,"name":"checkstyle","full_name":"tsjensen/checkstyle","owner":{"login":"tsjensen","id":7677131,"avatar_url":"https://avatars.githubusercontent.com/u/7677131?v=3","gravatar_id":"","url":"https://api.github.com/users/tsjensen","html_url":"https://github.com/tsjensen","followers_url":"https://api.github.com/users/tsjensen/followers","following_url":"https://api.github.com/users/tsjensen/following{/other_user}","gists_url":"https://api.github.com/users/tsjensen/gists{/gist_id}","starred_url":"https://api.github.com/users/tsjensen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsjensen/subscriptions","organizations_url":"https://api.github.com/users/tsjensen/orgs","repos_url":"https://api.github.com/users/tsjensen/repos","events_url":"https://api.github.com/users/tsjensen/events{/privacy}","received_events_url":"https://api.github.com/users/tsjensen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tsjensen/checkstyle","description":"Checkstyle is a development tool to help programmers write Java code that adheres to a coding standard. By default it supports the Google Java Style Guide and Sun Code Conventions, but is highly configurable. It can be invoked with an ANT task and a command line program.","fork":true,"url":"https://api.github.com/repos/tsjensen/checkstyle","forks_url":"https://api.github.com/repos/tsjensen/checkstyle/forks","keys_url":"https://api.github.com/repos/tsjensen/checkstyle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tsjensen/checkstyle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tsjensen/checkstyle/teams","hooks_url":"https://api.github.com/repos/tsjensen/checkstyle/hooks","issue_events_url":"https://api.github.com/repos/tsjensen/checkstyle/issues/events{/number}","events_url":"https://api.github.com/repos/tsjensen/checkstyle/events","assignees_url":"https://api.github.com/repos/tsjensen/checkstyle/assignees{/user}","branches_url":"https://api.github.com/repos/tsjensen/checkstyle/branches{/branch}","tags_url":"https://api.github.com/repos/tsjensen/checkstyle/tags","blobs_url":"https://api.github.com/repos/tsjensen/checkstyle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tsjensen/checkstyle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tsjensen/checkstyle/git/refs{/sha}","trees_url":"https://api.github.com/repos/tsjensen/checkstyle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tsjensen/checkstyle/statuses/{sha}","languages_url":"https://api.github.com/repos/tsjensen/checkstyle/languages","stargazers_url":"https://api.github.com/repos/tsjensen/checkstyle/stargazers","contributors_url":"https://api.github.com/repos/tsjensen/checkstyle/contributors","subscribers_url":"https://api.github.com/repos/tsjensen/checkstyle/subscribers","subscription_url":"https://api.github.com/repos/tsjensen/checkstyle/subscription","commits_url":"https://api.github.com/repos/tsjensen/checkstyle/commits{/sha}","git_commits_url":"https://api.github.com/repos/tsjensen/checkstyle/git/commits{/sha}","comments_url":"https://api.github.com/repos/tsjensen/checkstyle/comments{/number}","issue_comment_url":"https://api.github.com/repos/tsjensen/checkstyle/issues/comments{/number}","contents_url":"https://api.github.com/repos/tsjensen/checkstyle/contents/{+path}","compare_url":"https://api.github.com/repos/tsjensen/checkstyle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tsjensen/checkstyle/merges","archive_url":"https://api.github.com/repos/tsjensen/checkstyle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tsjensen/checkstyle/downloads","issues_url":"https://api.github.com/repos/tsjensen/checkstyle/issues{/number}","pulls_url":"https://api.github.com/repos/tsjensen/checkstyle/pulls{/number}","milestones_url":"https://api.github.com/repos/tsjensen/checkstyle/milestones{/number}","notifications_url":"https://api.github.com/repos/tsjensen/checkstyle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tsjensen/checkstyle/labels{/name}","releases_url":"https://api.github.com/repos/tsjensen/checkstyle/releases{/id}","created_at":"2015-06-12T18:09:46Z","updated_at":"2015-06-12T18:09:49Z","pushed_at":"2015-12-03T20:41:19Z","git_url":"git://github.com/tsjensen/checkstyle.git","ssh_url":"git@github.com:tsjensen/checkstyle.git","clone_url":"https://github.com/tsjensen/checkstyle.git","svn_url":"https://github.com/tsjensen/checkstyle","homepage":"http://checkstyle.sourceforge.net/","size":47996,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"checkstyle:master","ref":"master","sha":"c2d01289dda6c11cfdad86ff0b47d289be15113e","user":{"login":"checkstyle","id":5179750,"avatar_url":"https://avatars.githubusercontent.com/u/5179750?v=3","gravatar_id":"","url":"https://api.github.com/users/checkstyle","html_url":"https://github.com/checkstyle","followers_url":"https://api.github.com/users/checkstyle/followers","following_url":"https://api.github.com/users/checkstyle/following{/other_user}","gists_url":"https://api.github.com/users/checkstyle/gists{/gist_id}","starred_url":"https://api.github.com/users/checkstyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/checkstyle/subscriptions","organizations_url":"https://api.github.com/users/checkstyle/orgs","repos_url":"https://api.github.com/users/checkstyle/repos","events_url":"https://api.github.com/users/checkstyle/events{/privacy}","received_events_url":"https://api.github.com/users/checkstyle/received_events","type":"Organization","site_admin":false},"repo":{"id":12499251,"name":"checkstyle","full_name":"checkstyle/checkstyle","owner":{"login":"checkstyle","id":5179750,"avatar_url":"https://avatars.githubusercontent.com/u/5179750?v=3","gravatar_id":"","url":"https://api.github.com/users/checkstyle","html_url":"https://github.com/checkstyle","followers_url":"https://api.github.com/users/checkstyle/followers","following_url":"https://api.github.com/users/checkstyle/following{/other_user}","gists_url":"https://api.github.com/users/checkstyle/gists{/gist_id}","starred_url":"https://api.github.com/users/checkstyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/checkstyle/subscriptions","organizations_url":"https://api.github.com/users/checkstyle/orgs","repos_url":"https://api.github.com/users/checkstyle/repos","events_url":"https://api.github.com/users/checkstyle/events{/privacy}","received_events_url":"https://api.github.com/users/checkstyle/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/checkstyle/checkstyle","description":"Checkstyle is a development tool to help programmers write Java code that adheres to a coding standard. By default it supports the Google Java Style Guide and Sun Code Conventions, but is highly configurable. It can be invoked with an ANT task and a command line program.","fork":false,"url":"https://api.github.com/repos/checkstyle/checkstyle","forks_url":"https://api.github.com/repos/checkstyle/checkstyle/forks","keys_url":"https://api.github.com/repos/checkstyle/checkstyle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/checkstyle/checkstyle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/checkstyle/checkstyle/teams","hooks_url":"https://api.github.com/repos/checkstyle/checkstyle/hooks","issue_events_url":"https://api.github.com/repos/checkstyle/checkstyle/issues/events{/number}","events_url":"https://api.github.com/repos/checkstyle/checkstyle/events","assignees_url":"https://api.github.com/repos/checkstyle/checkstyle/assignees{/user}","branches_url":"https://api.github.com/repos/checkstyle/checkstyle/branches{/branch}","tags_url":"https://api.github.com/repos/checkstyle/checkstyle/tags","blobs_url":"https://api.github.com/repos/checkstyle/checkstyle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/checkstyle/checkstyle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/checkstyle/checkstyle/git/refs{/sha}","trees_url":"https://api.github.com/repos/checkstyle/checkstyle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/checkstyle/checkstyle/statuses/{sha}","languages_url":"https://api.github.com/repos/checkstyle/checkstyle/languages","stargazers_url":"https://api.github.com/repos/checkstyle/checkstyle/stargazers","contributors_url":"https://api.github.com/repos/checkstyle/checkstyle/contributors","subscribers_url":"https://api.github.com/repos/checkstyle/checkstyle/subscribers","subscription_url":"https://api.github.com/repos/checkstyle/checkstyle/subscription","commits_url":"https://api.github.com/repos/checkstyle/checkstyle/commits{/sha}","git_commits_url":"https://api.github.com/repos/checkstyle/checkstyle/git/commits{/sha}","comments_url":"https://api.github.com/repos/checkstyle/checkstyle/comments{/number}","issue_comment_url":"https://api.github.com/repos/checkstyle/checkstyle/issues/comments{/number}","contents_url":"https://api.github.com/repos/checkstyle/checkstyle/contents/{+path}","compare_url":"https://api.github.com/repos/checkstyle/checkstyle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/checkstyle/checkstyle/merges","archive_url":"https://api.github.com/repos/checkstyle/checkstyle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/checkstyle/checkstyle/downloads","issues_url":"https://api.github.com/repos/checkstyle/checkstyle/issues{/number}","pulls_url":"https://api.github.com/repos/checkstyle/checkstyle/pulls{/number}","milestones_url":"https://api.github.com/repos/checkstyle/checkstyle/milestones{/number}","notifications_url":"https://api.github.com/repos/checkstyle/checkstyle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/checkstyle/checkstyle/labels{/name}","releases_url":"https://api.github.com/repos/checkstyle/checkstyle/releases{/id}","created_at":"2013-08-31T02:05:05Z","updated_at":"2015-12-03T13:57:42Z","pushed_at":"2015-12-03T22:25:11Z","git_url":"git://github.com/checkstyle/checkstyle.git","ssh_url":"git@github.com:checkstyle/checkstyle.git","clone_url":"https://github.com/checkstyle/checkstyle.git","svn_url":"https://github.com/checkstyle/checkstyle","homepage":"http://checkstyle.sourceforge.net/","size":51144,"stargazers_count":740,"watchers_count":740,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":346,"mirror_url":null,"open_issues_count":216,"forks":346,"open_issues":216,"watchers":740,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/checkstyle/checkstyle/pulls/2644"},"html":{"href":"https://github.com/checkstyle/checkstyle/pull/2644"},"issue":{"href":"https://api.github.com/repos/checkstyle/checkstyle/issues/2644"},"comments":{"href":"https://api.github.com/repos/checkstyle/checkstyle/issues/2644/comments"},"review_comments":{"href":"https://api.github.com/repos/checkstyle/checkstyle/pulls/2644/comments"},"review_comment":{"href":"https://api.github.com/repos/checkstyle/checkstyle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/checkstyle/checkstyle/pulls/2644/commits"},"statuses":{"href":"https://api.github.com/repos/checkstyle/checkstyle/statuses/e9e8d2f0a76601762e59f4743f0df0c792bea44d"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"romani","id":812984,"avatar_url":"https://avatars.githubusercontent.com/u/812984?v=3","gravatar_id":"","url":"https://api.github.com/users/romani","html_url":"https://github.com/romani","followers_url":"https://api.github.com/users/romani/followers","following_url":"https://api.github.com/users/romani/following{/other_user}","gists_url":"https://api.github.com/users/romani/gists{/gist_id}","starred_url":"https://api.github.com/users/romani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romani/subscriptions","organizations_url":"https://api.github.com/users/romani/orgs","repos_url":"https://api.github.com/users/romani/repos","events_url":"https://api.github.com/users/romani/events{/privacy}","received_events_url":"https://api.github.com/users/romani/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":1,"additions":59,"deletions":32,"changed_files":3}}