{"action":"opened","number":378,"pull_request":{"url":"https://api.github.com/repos/maebert/jrnl/pulls/378","id":44299505,"html_url":"https://github.com/maebert/jrnl/pull/378","diff_url":"https://github.com/maebert/jrnl/pull/378.diff","patch_url":"https://github.com/maebert/jrnl/pull/378.patch","issue_url":"https://api.github.com/repos/maebert/jrnl/issues/378","number":378,"state":"open","locked":false,"title":"Fix issue where jrnl would erroneously mark entries as modified","user":{"login":"nikvdp","id":4651473,"avatar_url":"https://avatars.githubusercontent.com/u/4651473?v=3","gravatar_id":"","url":"https://api.github.com/users/nikvdp","html_url":"https://github.com/nikvdp","followers_url":"https://api.github.com/users/nikvdp/followers","following_url":"https://api.github.com/users/nikvdp/following{/other_user}","gists_url":"https://api.github.com/users/nikvdp/gists{/gist_id}","starred_url":"https://api.github.com/users/nikvdp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikvdp/subscriptions","organizations_url":"https://api.github.com/users/nikvdp/orgs","repos_url":"https://api.github.com/users/nikvdp/repos","events_url":"https://api.github.com/users/nikvdp/events{/privacy}","received_events_url":"https://api.github.com/users/nikvdp/received_events","type":"User","site_admin":false},"body":"Jrnl's Entry class (and possibly other places?) strip new-lines and some spaces, which causes jrnl to incorrectly see entries loaded from DayOne as modified when loaded in edit mode, even if they weren't actually modified.\r\n\r\nThis PR just compares the .split()-ed values of the entry bodies rather than comparing them directly so that whitespace-only differences will not cause the entries to be marked as modified.","created_at":"2015-09-06T09:47:29Z","updated_at":"2015-09-06T09:47:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/maebert/jrnl/pulls/378/commits","review_comments_url":"https://api.github.com/repos/maebert/jrnl/pulls/378/comments","review_comment_url":"https://api.github.com/repos/maebert/jrnl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/maebert/jrnl/issues/378/comments","statuses_url":"https://api.github.com/repos/maebert/jrnl/statuses/42b8f2bdb8bc58f8968bd8f9a5027aff098ec679","head":{"label":"nikvdp:fixDayOneChangedEntryCheck","ref":"fixDayOneChangedEntryCheck","sha":"42b8f2bdb8bc58f8968bd8f9a5027aff098ec679","user":{"login":"nikvdp","id":4651473,"avatar_url":"https://avatars.githubusercontent.com/u/4651473?v=3","gravatar_id":"","url":"https://api.github.com/users/nikvdp","html_url":"https://github.com/nikvdp","followers_url":"https://api.github.com/users/nikvdp/followers","following_url":"https://api.github.com/users/nikvdp/following{/other_user}","gists_url":"https://api.github.com/users/nikvdp/gists{/gist_id}","starred_url":"https://api.github.com/users/nikvdp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikvdp/subscriptions","organizations_url":"https://api.github.com/users/nikvdp/orgs","repos_url":"https://api.github.com/users/nikvdp/repos","events_url":"https://api.github.com/users/nikvdp/events{/privacy}","received_events_url":"https://api.github.com/users/nikvdp/received_events","type":"User","site_admin":false},"repo":{"id":27872803,"name":"jrnl","full_name":"nikvdp/jrnl","owner":{"login":"nikvdp","id":4651473,"avatar_url":"https://avatars.githubusercontent.com/u/4651473?v=3","gravatar_id":"","url":"https://api.github.com/users/nikvdp","html_url":"https://github.com/nikvdp","followers_url":"https://api.github.com/users/nikvdp/followers","following_url":"https://api.github.com/users/nikvdp/following{/other_user}","gists_url":"https://api.github.com/users/nikvdp/gists{/gist_id}","starred_url":"https://api.github.com/users/nikvdp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikvdp/subscriptions","organizations_url":"https://api.github.com/users/nikvdp/orgs","repos_url":"https://api.github.com/users/nikvdp/repos","events_url":"https://api.github.com/users/nikvdp/events{/privacy}","received_events_url":"https://api.github.com/users/nikvdp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nikvdp/jrnl","description":"A simple command line journal application that stores your journal in a plain text file.","fork":true,"url":"https://api.github.com/repos/nikvdp/jrnl","forks_url":"https://api.github.com/repos/nikvdp/jrnl/forks","keys_url":"https://api.github.com/repos/nikvdp/jrnl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nikvdp/jrnl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nikvdp/jrnl/teams","hooks_url":"https://api.github.com/repos/nikvdp/jrnl/hooks","issue_events_url":"https://api.github.com/repos/nikvdp/jrnl/issues/events{/number}","events_url":"https://api.github.com/repos/nikvdp/jrnl/events","assignees_url":"https://api.github.com/repos/nikvdp/jrnl/assignees{/user}","branches_url":"https://api.github.com/repos/nikvdp/jrnl/branches{/branch}","tags_url":"https://api.github.com/repos/nikvdp/jrnl/tags","blobs_url":"https://api.github.com/repos/nikvdp/jrnl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nikvdp/jrnl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nikvdp/jrnl/git/refs{/sha}","trees_url":"https://api.github.com/repos/nikvdp/jrnl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nikvdp/jrnl/statuses/{sha}","languages_url":"https://api.github.com/repos/nikvdp/jrnl/languages","stargazers_url":"https://api.github.com/repos/nikvdp/jrnl/stargazers","contributors_url":"https://api.github.com/repos/nikvdp/jrnl/contributors","subscribers_url":"https://api.github.com/repos/nikvdp/jrnl/subscribers","subscription_url":"https://api.github.com/repos/nikvdp/jrnl/subscription","commits_url":"https://api.github.com/repos/nikvdp/jrnl/commits{/sha}","git_commits_url":"https://api.github.com/repos/nikvdp/jrnl/git/commits{/sha}","comments_url":"https://api.github.com/repos/nikvdp/jrnl/comments{/number}","issue_comment_url":"https://api.github.com/repos/nikvdp/jrnl/issues/comments{/number}","contents_url":"https://api.github.com/repos/nikvdp/jrnl/contents/{+path}","compare_url":"https://api.github.com/repos/nikvdp/jrnl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nikvdp/jrnl/merges","archive_url":"https://api.github.com/repos/nikvdp/jrnl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nikvdp/jrnl/downloads","issues_url":"https://api.github.com/repos/nikvdp/jrnl/issues{/number}","pulls_url":"https://api.github.com/repos/nikvdp/jrnl/pulls{/number}","milestones_url":"https://api.github.com/repos/nikvdp/jrnl/milestones{/number}","notifications_url":"https://api.github.com/repos/nikvdp/jrnl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nikvdp/jrnl/labels{/name}","releases_url":"https://api.github.com/repos/nikvdp/jrnl/releases{/id}","created_at":"2014-12-11T13:29:57Z","updated_at":"2015-01-10T08:23:33Z","pushed_at":"2015-09-06T09:41:24Z","git_url":"git://github.com/nikvdp/jrnl.git","ssh_url":"git@github.com:nikvdp/jrnl.git","clone_url":"https://github.com/nikvdp/jrnl.git","svn_url":"https://github.com/nikvdp/jrnl","homepage":"http://jrnl.sh","size":2411,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"maebert:master","ref":"master","sha":"15ef9749ae497b594b2a325c6ea897a8572d5bc6","user":{"login":"maebert","id":1047165,"avatar_url":"https://avatars.githubusercontent.com/u/1047165?v=3","gravatar_id":"","url":"https://api.github.com/users/maebert","html_url":"https://github.com/maebert","followers_url":"https://api.github.com/users/maebert/followers","following_url":"https://api.github.com/users/maebert/following{/other_user}","gists_url":"https://api.github.com/users/maebert/gists{/gist_id}","starred_url":"https://api.github.com/users/maebert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maebert/subscriptions","organizations_url":"https://api.github.com/users/maebert/orgs","repos_url":"https://api.github.com/users/maebert/repos","events_url":"https://api.github.com/users/maebert/events{/privacy}","received_events_url":"https://api.github.com/users/maebert/received_events","type":"User","site_admin":false},"repo":{"id":3868463,"name":"jrnl","full_name":"maebert/jrnl","owner":{"login":"maebert","id":1047165,"avatar_url":"https://avatars.githubusercontent.com/u/1047165?v=3","gravatar_id":"","url":"https://api.github.com/users/maebert","html_url":"https://github.com/maebert","followers_url":"https://api.github.com/users/maebert/followers","following_url":"https://api.github.com/users/maebert/following{/other_user}","gists_url":"https://api.github.com/users/maebert/gists{/gist_id}","starred_url":"https://api.github.com/users/maebert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maebert/subscriptions","organizations_url":"https://api.github.com/users/maebert/orgs","repos_url":"https://api.github.com/users/maebert/repos","events_url":"https://api.github.com/users/maebert/events{/privacy}","received_events_url":"https://api.github.com/users/maebert/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/maebert/jrnl","description":"A simple command line journal application that stores your journal in a plain text file.","fork":false,"url":"https://api.github.com/repos/maebert/jrnl","forks_url":"https://api.github.com/repos/maebert/jrnl/forks","keys_url":"https://api.github.com/repos/maebert/jrnl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maebert/jrnl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maebert/jrnl/teams","hooks_url":"https://api.github.com/repos/maebert/jrnl/hooks","issue_events_url":"https://api.github.com/repos/maebert/jrnl/issues/events{/number}","events_url":"https://api.github.com/repos/maebert/jrnl/events","assignees_url":"https://api.github.com/repos/maebert/jrnl/assignees{/user}","branches_url":"https://api.github.com/repos/maebert/jrnl/branches{/branch}","tags_url":"https://api.github.com/repos/maebert/jrnl/tags","blobs_url":"https://api.github.com/repos/maebert/jrnl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maebert/jrnl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maebert/jrnl/git/refs{/sha}","trees_url":"https://api.github.com/repos/maebert/jrnl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maebert/jrnl/statuses/{sha}","languages_url":"https://api.github.com/repos/maebert/jrnl/languages","stargazers_url":"https://api.github.com/repos/maebert/jrnl/stargazers","contributors_url":"https://api.github.com/repos/maebert/jrnl/contributors","subscribers_url":"https://api.github.com/repos/maebert/jrnl/subscribers","subscription_url":"https://api.github.com/repos/maebert/jrnl/subscription","commits_url":"https://api.github.com/repos/maebert/jrnl/commits{/sha}","git_commits_url":"https://api.github.com/repos/maebert/jrnl/git/commits{/sha}","comments_url":"https://api.github.com/repos/maebert/jrnl/comments{/number}","issue_comment_url":"https://api.github.com/repos/maebert/jrnl/issues/comments{/number}","contents_url":"https://api.github.com/repos/maebert/jrnl/contents/{+path}","compare_url":"https://api.github.com/repos/maebert/jrnl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maebert/jrnl/merges","archive_url":"https://api.github.com/repos/maebert/jrnl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maebert/jrnl/downloads","issues_url":"https://api.github.com/repos/maebert/jrnl/issues{/number}","pulls_url":"https://api.github.com/repos/maebert/jrnl/pulls{/number}","milestones_url":"https://api.github.com/repos/maebert/jrnl/milestones{/number}","notifications_url":"https://api.github.com/repos/maebert/jrnl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maebert/jrnl/labels{/name}","releases_url":"https://api.github.com/repos/maebert/jrnl/releases{/id}","created_at":"2012-03-29T17:23:58Z","updated_at":"2015-09-04T16:02:23Z","pushed_at":"2015-09-06T09:47:29Z","git_url":"git://github.com/maebert/jrnl.git","ssh_url":"git@github.com:maebert/jrnl.git","clone_url":"https://github.com/maebert/jrnl.git","svn_url":"https://github.com/maebert/jrnl","homepage":"http://jrnl.sh","size":4292,"stargazers_count":1754,"watchers_count":1754,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":188,"mirror_url":null,"open_issues_count":43,"forks":188,"open_issues":43,"watchers":1754,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/maebert/jrnl/pulls/378"},"html":{"href":"https://github.com/maebert/jrnl/pull/378"},"issue":{"href":"https://api.github.com/repos/maebert/jrnl/issues/378"},"comments":{"href":"https://api.github.com/repos/maebert/jrnl/issues/378/comments"},"review_comments":{"href":"https://api.github.com/repos/maebert/jrnl/pulls/378/comments"},"review_comment":{"href":"https://api.github.com/repos/maebert/jrnl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/maebert/jrnl/pulls/378/commits"},"statuses":{"href":"https://api.github.com/repos/maebert/jrnl/statuses/42b8f2bdb8bc58f8968bd8f9a5027aff098ec679"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":5,"deletions":1,"changed_files":1}}