{"action":"created","comment":{"url":"https://api.github.com/repos/wagn/wagn/pulls/comments/22767536","id":22767536,"diff_hunk":"@@ -216,8 +265,8 @@ def unsupported_view view\n     end\n \n     def final_link href, opts={}\n-      text = opts[:text] || href\n-      %{<a class=\"#{opts[:class]}\" href=\"#{href}\">#{text}</a>}\n+      text = (opts.delete(:text) || href).dup\n+      content_tag :a, text, opts.merge(:href=>href)","path":"mod/01_core/format/html_format.rb","position":72,"original_position":72,"commit_id":"f91cf478deee1fa0e02ae9be7f4d611927a3bdaf","original_commit_id":"a6202796d26db1d4fb0daed53888093ca7fe0afc","user":{"login":"GerryG","id":76243,"avatar_url":"https://avatars.githubusercontent.com/u/76243?v=3","gravatar_id":"","url":"https://api.github.com/users/GerryG","html_url":"https://github.com/GerryG","followers_url":"https://api.github.com/users/GerryG/followers","following_url":"https://api.github.com/users/GerryG/following{/other_user}","gists_url":"https://api.github.com/users/GerryG/gists{/gist_id}","starred_url":"https://api.github.com/users/GerryG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GerryG/subscriptions","organizations_url":"https://api.github.com/users/GerryG/orgs","repos_url":"https://api.github.com/users/GerryG/repos","events_url":"https://api.github.com/users/GerryG/events{/privacy}","received_events_url":"https://api.github.com/users/GerryG/received_events","type":"User","site_admin":false},"body":"You'll note that I changed those back and compensated by changing the expected result to an encoded &.\r\n\r\nAlso added test case for text rendering of links which should not change a regular url.  If the recognized url is missing something (like http://, a bare host+path), then the url is different from the parsed text, so it does the [] thing.","created_at":"2015-01-11T15:40:02Z","updated_at":"2015-01-11T15:40:02Z","html_url":"https://github.com/wagn/wagn/pull/281#discussion_r22767536","pull_request_url":"https://api.github.com/repos/wagn/wagn/pulls/281","_links":{"self":{"href":"https://api.github.com/repos/wagn/wagn/pulls/comments/22767536"},"html":{"href":"https://github.com/wagn/wagn/pull/281#discussion_r22767536"},"pull_request":{"href":"https://api.github.com/repos/wagn/wagn/pulls/281"}}},"pull_request":{"url":"https://api.github.com/repos/wagn/wagn/pulls/281","id":26711876,"html_url":"https://github.com/wagn/wagn/pull/281","diff_url":"https://github.com/wagn/wagn/pull/281.diff","patch_url":"https://github.com/wagn/wagn/pull/281.patch","issue_url":"https://api.github.com/repos/wagn/wagn/issues/281","number":281,"state":"open","locked":false,"title":"Link type","user":{"login":"GerryG","id":76243,"avatar_url":"https://avatars.githubusercontent.com/u/76243?v=3","gravatar_id":"","url":"https://api.github.com/users/GerryG","html_url":"https://github.com/GerryG","followers_url":"https://api.github.com/users/GerryG/followers","following_url":"https://api.github.com/users/GerryG/following{/other_user}","gists_url":"https://api.github.com/users/GerryG/gists{/gist_id}","starred_url":"https://api.github.com/users/GerryG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GerryG/subscriptions","organizations_url":"https://api.github.com/users/GerryG/orgs","repos_url":"https://api.github.com/users/GerryG/repos","events_url":"https://api.github.com/users/GerryG/events{/privacy}","received_events_url":"https://api.github.com/users/GerryG/received_events","type":"User","site_admin":false},"body":"Updated and now targeted to master","created_at":"2014-12-31T01:16:38Z","updated_at":"2015-01-11T15:40:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6f242ba7a4221e24019845c39cb68701364096b9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/wagn/wagn/pulls/281/commits","review_comments_url":"https://api.github.com/repos/wagn/wagn/pulls/281/comments","review_comment_url":"https://api.github.com/repos/wagn/wagn/pulls/comments/{number}","comments_url":"https://api.github.com/repos/wagn/wagn/issues/281/comments","statuses_url":"https://api.github.com/repos/wagn/wagn/statuses/f91cf478deee1fa0e02ae9be7f4d611927a3bdaf","head":{"label":"GerryG:link_type","ref":"link_type","sha":"f91cf478deee1fa0e02ae9be7f4d611927a3bdaf","user":{"login":"GerryG","id":76243,"avatar_url":"https://avatars.githubusercontent.com/u/76243?v=3","gravatar_id":"","url":"https://api.github.com/users/GerryG","html_url":"https://github.com/GerryG","followers_url":"https://api.github.com/users/GerryG/followers","following_url":"https://api.github.com/users/GerryG/following{/other_user}","gists_url":"https://api.github.com/users/GerryG/gists{/gist_id}","starred_url":"https://api.github.com/users/GerryG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GerryG/subscriptions","organizations_url":"https://api.github.com/users/GerryG/orgs","repos_url":"https://api.github.com/users/GerryG/repos","events_url":"https://api.github.com/users/GerryG/events{/privacy}","received_events_url":"https://api.github.com/users/GerryG/received_events","type":"User","site_admin":false},"repo":{"id":182039,"name":"wagn","full_name":"GerryG/wagn","owner":{"login":"GerryG","id":76243,"avatar_url":"https://avatars.githubusercontent.com/u/76243?v=3","gravatar_id":"","url":"https://api.github.com/users/GerryG","html_url":"https://github.com/GerryG","followers_url":"https://api.github.com/users/GerryG/followers","following_url":"https://api.github.com/users/GerryG/following{/other_user}","gists_url":"https://api.github.com/users/GerryG/gists{/gist_id}","starred_url":"https://api.github.com/users/GerryG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GerryG/subscriptions","organizations_url":"https://api.github.com/users/GerryG/orgs","repos_url":"https://api.github.com/users/GerryG/repos","events_url":"https://api.github.com/users/GerryG/events{/privacy}","received_events_url":"https://api.github.com/users/GerryG/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/GerryG/wagn","description":"the wiki on wheels: a Ruby on Rails app for building dynamic, structured websites out of wiki cards","fork":true,"url":"https://api.github.com/repos/GerryG/wagn","forks_url":"https://api.github.com/repos/GerryG/wagn/forks","keys_url":"https://api.github.com/repos/GerryG/wagn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GerryG/wagn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GerryG/wagn/teams","hooks_url":"https://api.github.com/repos/GerryG/wagn/hooks","issue_events_url":"https://api.github.com/repos/GerryG/wagn/issues/events{/number}","events_url":"https://api.github.com/repos/GerryG/wagn/events","assignees_url":"https://api.github.com/repos/GerryG/wagn/assignees{/user}","branches_url":"https://api.github.com/repos/GerryG/wagn/branches{/branch}","tags_url":"https://api.github.com/repos/GerryG/wagn/tags","blobs_url":"https://api.github.com/repos/GerryG/wagn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GerryG/wagn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GerryG/wagn/git/refs{/sha}","trees_url":"https://api.github.com/repos/GerryG/wagn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GerryG/wagn/statuses/{sha}","languages_url":"https://api.github.com/repos/GerryG/wagn/languages","stargazers_url":"https://api.github.com/repos/GerryG/wagn/stargazers","contributors_url":"https://api.github.com/repos/GerryG/wagn/contributors","subscribers_url":"https://api.github.com/repos/GerryG/wagn/subscribers","subscription_url":"https://api.github.com/repos/GerryG/wagn/subscription","commits_url":"https://api.github.com/repos/GerryG/wagn/commits{/sha}","git_commits_url":"https://api.github.com/repos/GerryG/wagn/git/commits{/sha}","comments_url":"https://api.github.com/repos/GerryG/wagn/comments{/number}","issue_comment_url":"https://api.github.com/repos/GerryG/wagn/issues/comments/{number}","contents_url":"https://api.github.com/repos/GerryG/wagn/contents/{+path}","compare_url":"https://api.github.com/repos/GerryG/wagn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GerryG/wagn/merges","archive_url":"https://api.github.com/repos/GerryG/wagn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GerryG/wagn/downloads","issues_url":"https://api.github.com/repos/GerryG/wagn/issues{/number}","pulls_url":"https://api.github.com/repos/GerryG/wagn/pulls{/number}","milestones_url":"https://api.github.com/repos/GerryG/wagn/milestones{/number}","notifications_url":"https://api.github.com/repos/GerryG/wagn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GerryG/wagn/labels{/name}","releases_url":"https://api.github.com/repos/GerryG/wagn/releases{/id}","created_at":"2009-04-21T19:16:29Z","updated_at":"2014-11-21T14:30:43Z","pushed_at":"2015-01-11T15:15:48Z","git_url":"git://github.com/GerryG/wagn.git","ssh_url":"git@github.com:GerryG/wagn.git","clone_url":"https://github.com/GerryG/wagn.git","svn_url":"https://github.com/GerryG/wagn","homepage":"http://www.wagn.org","size":50299,"stargazers_count":4,"watchers_count":4,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":4,"default_branch":"develop"}},"base":{"label":"wagn:master","ref":"master","sha":"15e4269f68d4fc7faf94c64c9f47ff1d894b2024","user":{"login":"wagn","id":20722,"avatar_url":"https://avatars.githubusercontent.com/u/20722?v=3","gravatar_id":"","url":"https://api.github.com/users/wagn","html_url":"https://github.com/wagn","followers_url":"https://api.github.com/users/wagn/followers","following_url":"https://api.github.com/users/wagn/following{/other_user}","gists_url":"https://api.github.com/users/wagn/gists{/gist_id}","starred_url":"https://api.github.com/users/wagn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wagn/subscriptions","organizations_url":"https://api.github.com/users/wagn/orgs","repos_url":"https://api.github.com/users/wagn/repos","events_url":"https://api.github.com/users/wagn/events{/privacy}","received_events_url":"https://api.github.com/users/wagn/received_events","type":"User","site_admin":false},"repo":{"id":44462,"name":"wagn","full_name":"wagn/wagn","owner":{"login":"wagn","id":20722,"avatar_url":"https://avatars.githubusercontent.com/u/20722?v=3","gravatar_id":"","url":"https://api.github.com/users/wagn","html_url":"https://github.com/wagn","followers_url":"https://api.github.com/users/wagn/followers","following_url":"https://api.github.com/users/wagn/following{/other_user}","gists_url":"https://api.github.com/users/wagn/gists{/gist_id}","starred_url":"https://api.github.com/users/wagn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wagn/subscriptions","organizations_url":"https://api.github.com/users/wagn/orgs","repos_url":"https://api.github.com/users/wagn/repos","events_url":"https://api.github.com/users/wagn/events{/privacy}","received_events_url":"https://api.github.com/users/wagn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wagn/wagn","description":"Ruby on rails wiki platform for collaborating to build custom web systems","fork":false,"url":"https://api.github.com/repos/wagn/wagn","forks_url":"https://api.github.com/repos/wagn/wagn/forks","keys_url":"https://api.github.com/repos/wagn/wagn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wagn/wagn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wagn/wagn/teams","hooks_url":"https://api.github.com/repos/wagn/wagn/hooks","issue_events_url":"https://api.github.com/repos/wagn/wagn/issues/events{/number}","events_url":"https://api.github.com/repos/wagn/wagn/events","assignees_url":"https://api.github.com/repos/wagn/wagn/assignees{/user}","branches_url":"https://api.github.com/repos/wagn/wagn/branches{/branch}","tags_url":"https://api.github.com/repos/wagn/wagn/tags","blobs_url":"https://api.github.com/repos/wagn/wagn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wagn/wagn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wagn/wagn/git/refs{/sha}","trees_url":"https://api.github.com/repos/wagn/wagn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wagn/wagn/statuses/{sha}","languages_url":"https://api.github.com/repos/wagn/wagn/languages","stargazers_url":"https://api.github.com/repos/wagn/wagn/stargazers","contributors_url":"https://api.github.com/repos/wagn/wagn/contributors","subscribers_url":"https://api.github.com/repos/wagn/wagn/subscribers","subscription_url":"https://api.github.com/repos/wagn/wagn/subscription","commits_url":"https://api.github.com/repos/wagn/wagn/commits{/sha}","git_commits_url":"https://api.github.com/repos/wagn/wagn/git/commits{/sha}","comments_url":"https://api.github.com/repos/wagn/wagn/comments{/number}","issue_comment_url":"https://api.github.com/repos/wagn/wagn/issues/comments/{number}","contents_url":"https://api.github.com/repos/wagn/wagn/contents/{+path}","compare_url":"https://api.github.com/repos/wagn/wagn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wagn/wagn/merges","archive_url":"https://api.github.com/repos/wagn/wagn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wagn/wagn/downloads","issues_url":"https://api.github.com/repos/wagn/wagn/issues{/number}","pulls_url":"https://api.github.com/repos/wagn/wagn/pulls{/number}","milestones_url":"https://api.github.com/repos/wagn/wagn/milestones{/number}","notifications_url":"https://api.github.com/repos/wagn/wagn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wagn/wagn/labels{/name}","releases_url":"https://api.github.com/repos/wagn/wagn/releases{/id}","created_at":"2008-08-21T00:36:11Z","updated_at":"2015-01-10T23:58:55Z","pushed_at":"2015-01-10T23:58:55Z","git_url":"git://github.com/wagn/wagn.git","ssh_url":"git@github.com:wagn/wagn.git","clone_url":"https://github.com/wagn/wagn.git","svn_url":"https://github.com/wagn/wagn","homepage":"http://www.wagn.org","size":52171,"stargazers_count":244,"watchers_count":244,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":53,"mirror_url":null,"open_issues_count":8,"forks":53,"open_issues":8,"watchers":244,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wagn/wagn/pulls/281"},"html":{"href":"https://github.com/wagn/wagn/pull/281"},"issue":{"href":"https://api.github.com/repos/wagn/wagn/issues/281"},"comments":{"href":"https://api.github.com/repos/wagn/wagn/issues/281/comments"},"review_comments":{"href":"https://api.github.com/repos/wagn/wagn/pulls/281/comments"},"review_comment":{"href":"https://api.github.com/repos/wagn/wagn/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/wagn/wagn/pulls/281/commits"},"statuses":{"href":"https://api.github.com/repos/wagn/wagn/statuses/f91cf478deee1fa0e02ae9be7f4d611927a3bdaf"}}}}