{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-brooklyn/pulls/comments/44760536","id":44760536,"diff_hunk":"@@ -121,6 +121,11 @@ public CatalogItemBuilder(CatalogItemType dto) {\n         return this;\n     }\n \n+    public CatalogItemBuilder<CatalogItemType> tag(Object tag) {","path":"core/src/main/java/org/apache/brooklyn/core/catalog/internal/CatalogItemBuilder.java","position":4,"original_position":4,"commit_id":"334650046cfd38190a631727db40284e0aeb8b67","original_commit_id":"334650046cfd38190a631727db40284e0aeb8b67","user":{"login":"tbouron","id":2082759,"avatar_url":"https://avatars.githubusercontent.com/u/2082759?v=3","gravatar_id":"","url":"https://api.github.com/users/tbouron","html_url":"https://github.com/tbouron","followers_url":"https://api.github.com/users/tbouron/followers","following_url":"https://api.github.com/users/tbouron/following{/other_user}","gists_url":"https://api.github.com/users/tbouron/gists{/gist_id}","starred_url":"https://api.github.com/users/tbouron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbouron/subscriptions","organizations_url":"https://api.github.com/users/tbouron/orgs","repos_url":"https://api.github.com/users/tbouron/repos","events_url":"https://api.github.com/users/tbouron/events{/privacy}","received_events_url":"https://api.github.com/users/tbouron/received_events","type":"User","site_admin":false},"body":"I'm in a process of creating tests for that, I'll push ASAP","created_at":"2015-11-13T08:46:04Z","updated_at":"2015-11-13T08:46:04Z","html_url":"https://github.com/apache/incubator-brooklyn/pull/1020#discussion_r44760536","pull_request_url":"https://api.github.com/repos/apache/incubator-brooklyn/pulls/1020","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-brooklyn/pulls/comments/44760536"},"html":{"href":"https://github.com/apache/incubator-brooklyn/pull/1020#discussion_r44760536"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-brooklyn/pulls/1020"}}},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-brooklyn/pulls/1020","id":50387219,"html_url":"https://github.com/apache/incubator-brooklyn/pull/1020","diff_url":"https://github.com/apache/incubator-brooklyn/pull/1020.diff","patch_url":"https://github.com/apache/incubator-brooklyn/pull/1020.patch","issue_url":"https://api.github.com/repos/apache/incubator-brooklyn/issues/1020","number":1020,"state":"open","locked":false,"title":"Add TOSCA metadata support for catalog entities and templates","user":{"login":"tbouron","id":2082759,"avatar_url":"https://avatars.githubusercontent.com/u/2082759?v=3","gravatar_id":"","url":"https://api.github.com/users/tbouron","html_url":"https://github.com/tbouron","followers_url":"https://api.github.com/users/tbouron/followers","following_url":"https://api.github.com/users/tbouron/following{/other_user}","gists_url":"https://api.github.com/users/tbouron/gists{/gist_id}","starred_url":"https://api.github.com/users/tbouron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbouron/subscriptions","organizations_url":"https://api.github.com/users/tbouron/orgs","repos_url":"https://api.github.com/users/tbouron/repos","events_url":"https://api.github.com/users/tbouron/events{/privacy}","received_events_url":"https://api.github.com/users/tbouron/received_events","type":"User","site_admin":false},"body":"This implementation adds TOSCA type's metadata as a strongly typed tag into entities and templates catalog items. This information can be retrieved from the REST API, endpoints:\r\n- /v1/catalog/applications\r\n- /v1/catalog/entities\r\n\r\nTOSCA type will default to `brooklyn.nodes.SoftwareProcess` but can be overridden by specifying:\r\n- a `Tosca` annotation on Java entities, [here is an example](https://github.com/tbouron/incubator-brooklyn/commit/fe169eab38d6c17afcbc2221914609eaa8e1e1f0#diff-4b98848c850b4fc0e6a3927b3d76f167R43)\r\n- the TOSCA type when adding a pure CAMP YAML blueprint to the catalog like this:\r\n```\r\nbrooklyn.catalog:\r\n  id: my.app\r\n  version: 1.0\r\n  description: My application\r\n  displayName: My application\r\n  itemType: template\r\n  derivedFrom: brooklyn.nodes.WebApplication\r\n\r\nservices:\r\n- type: org.apache.brooklyn.entity.stock.BasicApplication\r\n```","created_at":"2015-11-11T14:14:01Z","updated_at":"2015-11-13T08:46:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a23c951fd14762bdb86c5d8d35b4a6ed1da146a9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-brooklyn/pulls/1020/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-brooklyn/pulls/1020/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-brooklyn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-brooklyn/issues/1020/comments","statuses_url":"https://api.github.com/repos/apache/incubator-brooklyn/statuses/334650046cfd38190a631727db40284e0aeb8b67","head":{"label":"tbouron:tosca-type-definition","ref":"tosca-type-definition","sha":"334650046cfd38190a631727db40284e0aeb8b67","user":{"login":"tbouron","id":2082759,"avatar_url":"https://avatars.githubusercontent.com/u/2082759?v=3","gravatar_id":"","url":"https://api.github.com/users/tbouron","html_url":"https://github.com/tbouron","followers_url":"https://api.github.com/users/tbouron/followers","following_url":"https://api.github.com/users/tbouron/following{/other_user}","gists_url":"https://api.github.com/users/tbouron/gists{/gist_id}","starred_url":"https://api.github.com/users/tbouron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbouron/subscriptions","organizations_url":"https://api.github.com/users/tbouron/orgs","repos_url":"https://api.github.com/users/tbouron/repos","events_url":"https://api.github.com/users/tbouron/events{/privacy}","received_events_url":"https://api.github.com/users/tbouron/received_events","type":"User","site_admin":false},"repo":{"id":35183769,"name":"incubator-brooklyn","full_name":"tbouron/incubator-brooklyn","owner":{"login":"tbouron","id":2082759,"avatar_url":"https://avatars.githubusercontent.com/u/2082759?v=3","gravatar_id":"","url":"https://api.github.com/users/tbouron","html_url":"https://github.com/tbouron","followers_url":"https://api.github.com/users/tbouron/followers","following_url":"https://api.github.com/users/tbouron/following{/other_user}","gists_url":"https://api.github.com/users/tbouron/gists{/gist_id}","starred_url":"https://api.github.com/users/tbouron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbouron/subscriptions","organizations_url":"https://api.github.com/users/tbouron/orgs","repos_url":"https://api.github.com/users/tbouron/repos","events_url":"https://api.github.com/users/tbouron/events{/privacy}","received_events_url":"https://api.github.com/users/tbouron/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tbouron/incubator-brooklyn","description":"Mirror of Apache Brooklyn","fork":true,"url":"https://api.github.com/repos/tbouron/incubator-brooklyn","forks_url":"https://api.github.com/repos/tbouron/incubator-brooklyn/forks","keys_url":"https://api.github.com/repos/tbouron/incubator-brooklyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tbouron/incubator-brooklyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tbouron/incubator-brooklyn/teams","hooks_url":"https://api.github.com/repos/tbouron/incubator-brooklyn/hooks","issue_events_url":"https://api.github.com/repos/tbouron/incubator-brooklyn/issues/events{/number}","events_url":"https://api.github.com/repos/tbouron/incubator-brooklyn/events","assignees_url":"https://api.github.com/repos/tbouron/incubator-brooklyn/assignees{/user}","branches_url":"https://api.github.com/repos/tbouron/incubator-brooklyn/branches{/branch}","tags_url":"https://api.github.com/repos/tbouron/incubator-brooklyn/tags","blobs_url":"https://api.github.com/repos/tbouron/incubator-brooklyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tbouron/incubator-brooklyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tbouron/incubator-brooklyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/tbouron/incubator-brooklyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tbouron/incubator-brooklyn/statuses/{sha}","languages_url":"https://api.github.com/repos/tbouron/incubator-brooklyn/languages","stargazers_url":"https://api.github.com/repos/tbouron/incubator-brooklyn/stargazers","contributors_url":"https://api.github.com/repos/tbouron/incubator-brooklyn/contributors","subscribers_url":"https://api.github.com/repos/tbouron/incubator-brooklyn/subscribers","subscription_url":"https://api.github.com/repos/tbouron/incubator-brooklyn/subscription","commits_url":"https://api.github.com/repos/tbouron/incubator-brooklyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/tbouron/incubator-brooklyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/tbouron/incubator-brooklyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/tbouron/incubator-brooklyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/tbouron/incubator-brooklyn/contents/{+path}","compare_url":"https://api.github.com/repos/tbouron/incubator-brooklyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tbouron/incubator-brooklyn/merges","archive_url":"https://api.github.com/repos/tbouron/incubator-brooklyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tbouron/incubator-brooklyn/downloads","issues_url":"https://api.github.com/repos/tbouron/incubator-brooklyn/issues{/number}","pulls_url":"https://api.github.com/repos/tbouron/incubator-brooklyn/pulls{/number}","milestones_url":"https://api.github.com/repos/tbouron/incubator-brooklyn/milestones{/number}","notifications_url":"https://api.github.com/repos/tbouron/incubator-brooklyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tbouron/incubator-brooklyn/labels{/name}","releases_url":"https://api.github.com/repos/tbouron/incubator-brooklyn/releases{/id}","created_at":"2015-05-06T21:26:34Z","updated_at":"2015-05-06T21:26:44Z","pushed_at":"2015-11-12T10:47:03Z","git_url":"git://github.com/tbouron/incubator-brooklyn.git","ssh_url":"git@github.com:tbouron/incubator-brooklyn.git","clone_url":"https://github.com/tbouron/incubator-brooklyn.git","svn_url":"https://github.com/tbouron/incubator-brooklyn","homepage":null,"size":253846,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"78df97a0c8fffb81cf25a6588b128743ca44620c","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":19368221,"name":"incubator-brooklyn","full_name":"apache/incubator-brooklyn","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-brooklyn","description":"Mirror of Apache Brooklyn","fork":false,"url":"https://api.github.com/repos/apache/incubator-brooklyn","forks_url":"https://api.github.com/repos/apache/incubator-brooklyn/forks","keys_url":"https://api.github.com/repos/apache/incubator-brooklyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-brooklyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-brooklyn/teams","hooks_url":"https://api.github.com/repos/apache/incubator-brooklyn/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-brooklyn/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-brooklyn/events","assignees_url":"https://api.github.com/repos/apache/incubator-brooklyn/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-brooklyn/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-brooklyn/tags","blobs_url":"https://api.github.com/repos/apache/incubator-brooklyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-brooklyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-brooklyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-brooklyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-brooklyn/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-brooklyn/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-brooklyn/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-brooklyn/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-brooklyn/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-brooklyn/subscription","commits_url":"https://api.github.com/repos/apache/incubator-brooklyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-brooklyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-brooklyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-brooklyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-brooklyn/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-brooklyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-brooklyn/merges","archive_url":"https://api.github.com/repos/apache/incubator-brooklyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-brooklyn/downloads","issues_url":"https://api.github.com/repos/apache/incubator-brooklyn/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-brooklyn/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-brooklyn/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-brooklyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-brooklyn/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-brooklyn/releases{/id}","created_at":"2014-05-02T07:00:07Z","updated_at":"2015-11-12T17:59:23Z","pushed_at":"2015-11-13T02:25:41Z","git_url":"git://github.com/apache/incubator-brooklyn.git","ssh_url":"git@github.com:apache/incubator-brooklyn.git","clone_url":"https://github.com/apache/incubator-brooklyn.git","svn_url":"https://github.com/apache/incubator-brooklyn","homepage":null,"size":266573,"stargazers_count":124,"watchers_count":124,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":97,"mirror_url":"git://git.apache.org/incubator-brooklyn.git","open_issues_count":15,"forks":97,"open_issues":15,"watchers":124,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-brooklyn/pulls/1020"},"html":{"href":"https://github.com/apache/incubator-brooklyn/pull/1020"},"issue":{"href":"https://api.github.com/repos/apache/incubator-brooklyn/issues/1020"},"comments":{"href":"https://api.github.com/repos/apache/incubator-brooklyn/issues/1020/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-brooklyn/pulls/1020/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-brooklyn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-brooklyn/pulls/1020/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-brooklyn/statuses/334650046cfd38190a631727db40284e0aeb8b67"}}}}