{"action":"created","issue":{"url":"https://api.github.com/repos/shysaur/Fragaria/issues/19","labels_url":"https://api.github.com/repos/shysaur/Fragaria/issues/19/labels{/name}","comments_url":"https://api.github.com/repos/shysaur/Fragaria/issues/19/comments","events_url":"https://api.github.com/repos/shysaur/Fragaria/issues/19/events","html_url":"https://github.com/shysaur/Fragaria/pull/19","id":57730757,"number":19,"title":"Improve errors","user":{"login":"balthisar","id":3053246,"avatar_url":"https://avatars.githubusercontent.com/u/3053246?v=3","gravatar_id":"","url":"https://api.github.com/users/balthisar","html_url":"https://github.com/balthisar","followers_url":"https://api.github.com/users/balthisar/followers","following_url":"https://api.github.com/users/balthisar/following{/other_user}","gists_url":"https://api.github.com/users/balthisar/gists{/gist_id}","starred_url":"https://api.github.com/users/balthisar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balthisar/subscriptions","organizations_url":"https://api.github.com/users/balthisar/orgs","repos_url":"https://api.github.com/users/balthisar/repos","events_url":"https://api.github.com/users/balthisar/events{/privacy}","received_events_url":"https://api.github.com/users/balthisar/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-02-15T13:45:33Z","updated_at":"2015-02-15T16:30:17Z","closed_at":"2015-02-15T15:03:12Z","pull_request":{"url":"https://api.github.com/repos/shysaur/Fragaria/pulls/19","html_url":"https://github.com/shysaur/Fragaria/pull/19","diff_url":"https://github.com/shysaur/Fragaria/pull/19.diff","patch_url":"https://github.com/shysaur/Fragaria/pull/19.patch"},"body":"Okay, I'm taking this in smaller steps this time, including smaller, more logical commits. This change is small:\r\n\r\n- Document SMLSyntaxError (although AppleDoc bug doesn't handle deprecated properties).\r\n- Deprecated some of the properties/methods with warnings in order to implement properties/methods with better names. \"Better\" is subjective, of course. In any case no API change.\r\n- Added a few convenience methods.\r\n- Added two highlighting properties I hope to implement later in order to support the use of `character` and `length` properties to highlight the actual error(s) in addition to the error line.\r\n- `customBackgroundColor` was deprecated in favor of `errorLineHighlightColor`, which now returns the default used in SMLSyntaxColoring. I'll replacing that existing logic in another PR (just an if/then). (possible that once I commit, Github will add it to this PR automatically).\r\n- Did not updated any of the deprecations anywhere else in the code, so you will get a few annoying build warnings. (Demo, let's call it).\r\n\r\nEdit:\r\n\r\n- It should also be possible to specify a user warningImage now, too, with fallback for the built-in images.\r\n"},"comment":{"url":"https://api.github.com/repos/shysaur/Fragaria/issues/comments/74424268","html_url":"https://github.com/shysaur/Fragaria/pull/19#issuecomment-74424268","issue_url":"https://api.github.com/repos/shysaur/Fragaria/issues/19","id":74424268,"user":{"login":"balthisar","id":3053246,"avatar_url":"https://avatars.githubusercontent.com/u/3053246?v=3","gravatar_id":"","url":"https://api.github.com/users/balthisar","html_url":"https://github.com/balthisar","followers_url":"https://api.github.com/users/balthisar/followers","following_url":"https://api.github.com/users/balthisar/following{/other_user}","gists_url":"https://api.github.com/users/balthisar/gists{/gist_id}","starred_url":"https://api.github.com/users/balthisar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balthisar/subscriptions","organizations_url":"https://api.github.com/users/balthisar/orgs","repos_url":"https://api.github.com/users/balthisar/repos","events_url":"https://api.github.com/users/balthisar/events{/privacy}","received_events_url":"https://api.github.com/users/balthisar/received_events","type":"User","site_admin":false},"created_at":"2015-02-15T16:30:17Z","updated_at":"2015-02-15T16:30:17Z","body":"Excellent suggestions both. I'll find some time tomorrow.\r\n\r\nI can't deprecate the enum; I'll just cross my fingers and hope no one starts depending on the behavior between one hour ago and tomorrow.\r\n"}}