{"action":"created","comment":{"url":"https://api.github.com/repos/danpottshimself/noughts-and-crosses/pulls/comments/40546660","id":40546660,"diff_hunk":"@@ -0,0 +1,21 @@\n+angular.module('Tombola.MyModule')\n+.controller('MyController', ['$scope','$q', 'Server', 'ServerTurn','FreshGame', 'CoreData','BothHumans', function ($scope,$q, server, serverTurn, freshGame, coreData, bothHumans) {\n+        $scope.model=freshGame;\n+        $scope.boardmodel=coreData;\n+        $scope.chooseBlock = function (index){\n+            if (coreData.gameBoard.charAt(index)!==\"0\" || coreData.currentGameState === \"Win\"){\n+                return;\n+            }\n+            if (freshGame.Player1 == 'human' && freshGame.Player2 !=='human'){\n+                coreData.currentPlayer = '1';\n+                freshGame.makeTurn(index);\n+            }\n+            if (freshGame.Player1 == 'human' && freshGame.Player2 =='human') {\n+                bothHumans.humanLogic(index);\n+            }\n+           if (freshGame.Player2 == 'human'  && freshGame.Player1 !=='human') {","path":"main-app/app/scripts/gameboard/gameboard-controller/gameBoard.js","position":16,"original_position":16,"commit_id":"cde8174baf73bf96ec3948b6d8fbe9b6d6b3f29d","original_commit_id":"cde8174baf73bf96ec3948b6d8fbe9b6d6b3f29d","user":{"login":"keithbarrow","id":8112111,"avatar_url":"https://avatars.githubusercontent.com/u/8112111?v=3","gravatar_id":"","url":"https://api.github.com/users/keithbarrow","html_url":"https://github.com/keithbarrow","followers_url":"https://api.github.com/users/keithbarrow/followers","following_url":"https://api.github.com/users/keithbarrow/following{/other_user}","gists_url":"https://api.github.com/users/keithbarrow/gists{/gist_id}","starred_url":"https://api.github.com/users/keithbarrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keithbarrow/subscriptions","organizations_url":"https://api.github.com/users/keithbarrow/orgs","repos_url":"https://api.github.com/users/keithbarrow/repos","events_url":"https://api.github.com/users/keithbarrow/events{/privacy}","received_events_url":"https://api.github.com/users/keithbarrow/received_events","type":"User","site_admin":false},"body":"Almost the same logic?  ","created_at":"2015-09-28T12:41:04Z","updated_at":"2015-09-28T12:41:04Z","html_url":"https://github.com/danpottshimself/noughts-and-crosses/pull/2#discussion_r40546660","pull_request_url":"https://api.github.com/repos/danpottshimself/noughts-and-crosses/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/danpottshimself/noughts-and-crosses/pulls/comments/40546660"},"html":{"href":"https://github.com/danpottshimself/noughts-and-crosses/pull/2#discussion_r40546660"},"pull_request":{"href":"https://api.github.com/repos/danpottshimself/noughts-and-crosses/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/danpottshimself/noughts-and-crosses/pulls/2","id":45394625,"html_url":"https://github.com/danpottshimself/noughts-and-crosses/pull/2","diff_url":"https://github.com/danpottshimself/noughts-and-crosses/pull/2.diff","patch_url":"https://github.com/danpottshimself/noughts-and-crosses/pull/2.patch","issue_url":"https://api.github.com/repos/danpottshimself/noughts-and-crosses/issues/2","number":2,"state":"open","locked":false,"title":"Main Branch ","user":{"login":"danpottshimself","id":13645940,"avatar_url":"https://avatars.githubusercontent.com/u/13645940?v=3","gravatar_id":"","url":"https://api.github.com/users/danpottshimself","html_url":"https://github.com/danpottshimself","followers_url":"https://api.github.com/users/danpottshimself/followers","following_url":"https://api.github.com/users/danpottshimself/following{/other_user}","gists_url":"https://api.github.com/users/danpottshimself/gists{/gist_id}","starred_url":"https://api.github.com/users/danpottshimself/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danpottshimself/subscriptions","organizations_url":"https://api.github.com/users/danpottshimself/orgs","repos_url":"https://api.github.com/users/danpottshimself/repos","events_url":"https://api.github.com/users/danpottshimself/events{/privacy}","received_events_url":"https://api.github.com/users/danpottshimself/received_events","type":"User","site_admin":false},"body":"I have changed game board to show without reaching DOM elements.\r\n\r\nI have added directives/partials.\r\n\r\nI have separated code into separate files.\r\n\r\nAdded server and ui routing.\r\n\r\nNeed to separate controller into files and add rules route to ui routing.","created_at":"2015-09-18T11:10:15Z","updated_at":"2015-09-28T12:41:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2ae541d31a61bf6d9a78f543dca66002c7c605af","assignee":{"login":"keithbarrow","id":8112111,"avatar_url":"https://avatars.githubusercontent.com/u/8112111?v=3","gravatar_id":"","url":"https://api.github.com/users/keithbarrow","html_url":"https://github.com/keithbarrow","followers_url":"https://api.github.com/users/keithbarrow/followers","following_url":"https://api.github.com/users/keithbarrow/following{/other_user}","gists_url":"https://api.github.com/users/keithbarrow/gists{/gist_id}","starred_url":"https://api.github.com/users/keithbarrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keithbarrow/subscriptions","organizations_url":"https://api.github.com/users/keithbarrow/orgs","repos_url":"https://api.github.com/users/keithbarrow/repos","events_url":"https://api.github.com/users/keithbarrow/events{/privacy}","received_events_url":"https://api.github.com/users/keithbarrow/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/danpottshimself/noughts-and-crosses/pulls/2/commits","review_comments_url":"https://api.github.com/repos/danpottshimself/noughts-and-crosses/pulls/2/comments","review_comment_url":"https://api.github.com/repos/danpottshimself/noughts-and-crosses/pulls/comments{/number}","comments_url":"https://api.github.com/repos/danpottshimself/noughts-and-crosses/issues/2/comments","statuses_url":"https://api.github.com/repos/danpottshimself/noughts-and-crosses/statuses/cde8174baf73bf96ec3948b6d8fbe9b6d6b3f29d","head":{"label":"danpottshimself:server","ref":"server","sha":"cde8174baf73bf96ec3948b6d8fbe9b6d6b3f29d","user":{"login":"danpottshimself","id":13645940,"avatar_url":"https://avatars.githubusercontent.com/u/13645940?v=3","gravatar_id":"","url":"https://api.github.com/users/danpottshimself","html_url":"https://github.com/danpottshimself","followers_url":"https://api.github.com/users/danpottshimself/followers","following_url":"https://api.github.com/users/danpottshimself/following{/other_user}","gists_url":"https://api.github.com/users/danpottshimself/gists{/gist_id}","starred_url":"https://api.github.com/users/danpottshimself/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danpottshimself/subscriptions","organizations_url":"https://api.github.com/users/danpottshimself/orgs","repos_url":"https://api.github.com/users/danpottshimself/repos","events_url":"https://api.github.com/users/danpottshimself/events{/privacy}","received_events_url":"https://api.github.com/users/danpottshimself/received_events","type":"User","site_admin":false},"repo":{"id":42048006,"name":"noughts-and-crosses","full_name":"danpottshimself/noughts-and-crosses","owner":{"login":"danpottshimself","id":13645940,"avatar_url":"https://avatars.githubusercontent.com/u/13645940?v=3","gravatar_id":"","url":"https://api.github.com/users/danpottshimself","html_url":"https://github.com/danpottshimself","followers_url":"https://api.github.com/users/danpottshimself/followers","following_url":"https://api.github.com/users/danpottshimself/following{/other_user}","gists_url":"https://api.github.com/users/danpottshimself/gists{/gist_id}","starred_url":"https://api.github.com/users/danpottshimself/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danpottshimself/subscriptions","organizations_url":"https://api.github.com/users/danpottshimself/orgs","repos_url":"https://api.github.com/users/danpottshimself/repos","events_url":"https://api.github.com/users/danpottshimself/events{/privacy}","received_events_url":"https://api.github.com/users/danpottshimself/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/danpottshimself/noughts-and-crosses","description":"Noughts and Crosses game made with angular as a training exercise.","fork":false,"url":"https://api.github.com/repos/danpottshimself/noughts-and-crosses","forks_url":"https://api.github.com/repos/danpottshimself/noughts-and-crosses/forks","keys_url":"https://api.github.com/repos/danpottshimself/noughts-and-crosses/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danpottshimself/noughts-and-crosses/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danpottshimself/noughts-and-crosses/teams","hooks_url":"https://api.github.com/repos/danpottshimself/noughts-and-crosses/hooks","issue_events_url":"https://api.github.com/repos/danpottshimself/noughts-and-crosses/issues/events{/number}","events_url":"https://api.github.com/repos/danpottshimself/noughts-and-crosses/events","assignees_url":"https://api.github.com/repos/danpottshimself/noughts-and-crosses/assignees{/user}","branches_url":"https://api.github.com/repos/danpottshimself/noughts-and-crosses/branches{/branch}","tags_url":"https://api.github.com/repos/danpottshimself/noughts-and-crosses/tags","blobs_url":"https://api.github.com/repos/danpottshimself/noughts-and-crosses/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danpottshimself/noughts-and-crosses/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danpottshimself/noughts-and-crosses/git/refs{/sha}","trees_url":"https://api.github.com/repos/danpottshimself/noughts-and-crosses/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danpottshimself/noughts-and-crosses/statuses/{sha}","languages_url":"https://api.github.com/repos/danpottshimself/noughts-and-crosses/languages","stargazers_url":"https://api.github.com/repos/danpottshimself/noughts-and-crosses/stargazers","contributors_url":"https://api.github.com/repos/danpottshimself/noughts-and-crosses/contributors","subscribers_url":"https://api.github.com/repos/danpottshimself/noughts-and-crosses/subscribers","subscription_url":"https://api.github.com/repos/danpottshimself/noughts-and-crosses/subscription","commits_url":"https://api.github.com/repos/danpottshimself/noughts-and-crosses/commits{/sha}","git_commits_url":"https://api.github.com/repos/danpottshimself/noughts-and-crosses/git/commits{/sha}","comments_url":"https://api.github.com/repos/danpottshimself/noughts-and-crosses/comments{/number}","issue_comment_url":"https://api.github.com/repos/danpottshimself/noughts-and-crosses/issues/comments{/number}","contents_url":"https://api.github.com/repos/danpottshimself/noughts-and-crosses/contents/{+path}","compare_url":"https://api.github.com/repos/danpottshimself/noughts-and-crosses/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danpottshimself/noughts-and-crosses/merges","archive_url":"https://api.github.com/repos/danpottshimself/noughts-and-crosses/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danpottshimself/noughts-and-crosses/downloads","issues_url":"https://api.github.com/repos/danpottshimself/noughts-and-crosses/issues{/number}","pulls_url":"https://api.github.com/repos/danpottshimself/noughts-and-crosses/pulls{/number}","milestones_url":"https://api.github.com/repos/danpottshimself/noughts-and-crosses/milestones{/number}","notifications_url":"https://api.github.com/repos/danpottshimself/noughts-and-crosses/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danpottshimself/noughts-and-crosses/labels{/name}","releases_url":"https://api.github.com/repos/danpottshimself/noughts-and-crosses/releases{/id}","created_at":"2015-09-07T10:57:15Z","updated_at":"2015-09-07T13:09:49Z","pushed_at":"2015-09-28T07:59:38Z","git_url":"git://github.com/danpottshimself/noughts-and-crosses.git","ssh_url":"git@github.com:danpottshimself/noughts-and-crosses.git","clone_url":"https://github.com/danpottshimself/noughts-and-crosses.git","svn_url":"https://github.com/danpottshimself/noughts-and-crosses","homepage":null,"size":3564,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"danpottshimself:master","ref":"master","sha":"e765c2a7e2b554824e62f64b5f22a0dcf6dffea6","user":{"login":"danpottshimself","id":13645940,"avatar_url":"https://avatars.githubusercontent.com/u/13645940?v=3","gravatar_id":"","url":"https://api.github.com/users/danpottshimself","html_url":"https://github.com/danpottshimself","followers_url":"https://api.github.com/users/danpottshimself/followers","following_url":"https://api.github.com/users/danpottshimself/following{/other_user}","gists_url":"https://api.github.com/users/danpottshimself/gists{/gist_id}","starred_url":"https://api.github.com/users/danpottshimself/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danpottshimself/subscriptions","organizations_url":"https://api.github.com/users/danpottshimself/orgs","repos_url":"https://api.github.com/users/danpottshimself/repos","events_url":"https://api.github.com/users/danpottshimself/events{/privacy}","received_events_url":"https://api.github.com/users/danpottshimself/received_events","type":"User","site_admin":false},"repo":{"id":42048006,"name":"noughts-and-crosses","full_name":"danpottshimself/noughts-and-crosses","owner":{"login":"danpottshimself","id":13645940,"avatar_url":"https://avatars.githubusercontent.com/u/13645940?v=3","gravatar_id":"","url":"https://api.github.com/users/danpottshimself","html_url":"https://github.com/danpottshimself","followers_url":"https://api.github.com/users/danpottshimself/followers","following_url":"https://api.github.com/users/danpottshimself/following{/other_user}","gists_url":"https://api.github.com/users/danpottshimself/gists{/gist_id}","starred_url":"https://api.github.com/users/danpottshimself/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danpottshimself/subscriptions","organizations_url":"https://api.github.com/users/danpottshimself/orgs","repos_url":"https://api.github.com/users/danpottshimself/repos","events_url":"https://api.github.com/users/danpottshimself/events{/privacy}","received_events_url":"https://api.github.com/users/danpottshimself/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/danpottshimself/noughts-and-crosses","description":"Noughts and Crosses game made with angular as a training exercise.","fork":false,"url":"https://api.github.com/repos/danpottshimself/noughts-and-crosses","forks_url":"https://api.github.com/repos/danpottshimself/noughts-and-crosses/forks","keys_url":"https://api.github.com/repos/danpottshimself/noughts-and-crosses/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danpottshimself/noughts-and-crosses/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danpottshimself/noughts-and-crosses/teams","hooks_url":"https://api.github.com/repos/danpottshimself/noughts-and-crosses/hooks","issue_events_url":"https://api.github.com/repos/danpottshimself/noughts-and-crosses/issues/events{/number}","events_url":"https://api.github.com/repos/danpottshimself/noughts-and-crosses/events","assignees_url":"https://api.github.com/repos/danpottshimself/noughts-and-crosses/assignees{/user}","branches_url":"https://api.github.com/repos/danpottshimself/noughts-and-crosses/branches{/branch}","tags_url":"https://api.github.com/repos/danpottshimself/noughts-and-crosses/tags","blobs_url":"https://api.github.com/repos/danpottshimself/noughts-and-crosses/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danpottshimself/noughts-and-crosses/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danpottshimself/noughts-and-crosses/git/refs{/sha}","trees_url":"https://api.github.com/repos/danpottshimself/noughts-and-crosses/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danpottshimself/noughts-and-crosses/statuses/{sha}","languages_url":"https://api.github.com/repos/danpottshimself/noughts-and-crosses/languages","stargazers_url":"https://api.github.com/repos/danpottshimself/noughts-and-crosses/stargazers","contributors_url":"https://api.github.com/repos/danpottshimself/noughts-and-crosses/contributors","subscribers_url":"https://api.github.com/repos/danpottshimself/noughts-and-crosses/subscribers","subscription_url":"https://api.github.com/repos/danpottshimself/noughts-and-crosses/subscription","commits_url":"https://api.github.com/repos/danpottshimself/noughts-and-crosses/commits{/sha}","git_commits_url":"https://api.github.com/repos/danpottshimself/noughts-and-crosses/git/commits{/sha}","comments_url":"https://api.github.com/repos/danpottshimself/noughts-and-crosses/comments{/number}","issue_comment_url":"https://api.github.com/repos/danpottshimself/noughts-and-crosses/issues/comments{/number}","contents_url":"https://api.github.com/repos/danpottshimself/noughts-and-crosses/contents/{+path}","compare_url":"https://api.github.com/repos/danpottshimself/noughts-and-crosses/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danpottshimself/noughts-and-crosses/merges","archive_url":"https://api.github.com/repos/danpottshimself/noughts-and-crosses/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danpottshimself/noughts-and-crosses/downloads","issues_url":"https://api.github.com/repos/danpottshimself/noughts-and-crosses/issues{/number}","pulls_url":"https://api.github.com/repos/danpottshimself/noughts-and-crosses/pulls{/number}","milestones_url":"https://api.github.com/repos/danpottshimself/noughts-and-crosses/milestones{/number}","notifications_url":"https://api.github.com/repos/danpottshimself/noughts-and-crosses/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danpottshimself/noughts-and-crosses/labels{/name}","releases_url":"https://api.github.com/repos/danpottshimself/noughts-and-crosses/releases{/id}","created_at":"2015-09-07T10:57:15Z","updated_at":"2015-09-07T13:09:49Z","pushed_at":"2015-09-28T07:59:38Z","git_url":"git://github.com/danpottshimself/noughts-and-crosses.git","ssh_url":"git@github.com:danpottshimself/noughts-and-crosses.git","clone_url":"https://github.com/danpottshimself/noughts-and-crosses.git","svn_url":"https://github.com/danpottshimself/noughts-and-crosses","homepage":null,"size":3564,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/danpottshimself/noughts-and-crosses/pulls/2"},"html":{"href":"https://github.com/danpottshimself/noughts-and-crosses/pull/2"},"issue":{"href":"https://api.github.com/repos/danpottshimself/noughts-and-crosses/issues/2"},"comments":{"href":"https://api.github.com/repos/danpottshimself/noughts-and-crosses/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/danpottshimself/noughts-and-crosses/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/danpottshimself/noughts-and-crosses/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/danpottshimself/noughts-and-crosses/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/danpottshimself/noughts-and-crosses/statuses/cde8174baf73bf96ec3948b6d8fbe9b6d6b3f29d"}}}}