{"action":"created","issue":{"url":"https://api.github.com/repos/git-for-windows/git/issues/156","labels_url":"https://api.github.com/repos/git-for-windows/git/issues/156/labels{/name}","comments_url":"https://api.github.com/repos/git-for-windows/git/issues/156/comments","events_url":"https://api.github.com/repos/git-for-windows/git/issues/156/events","html_url":"https://github.com/git-for-windows/git/pull/156","id":78648820,"number":156,"title":"Symlink support","user":{"login":"kblees","id":1111200,"avatar_url":"https://avatars.githubusercontent.com/u/1111200?v=3","gravatar_id":"","url":"https://api.github.com/users/kblees","html_url":"https://github.com/kblees","followers_url":"https://api.github.com/users/kblees/followers","following_url":"https://api.github.com/users/kblees/following{/other_user}","gists_url":"https://api.github.com/users/kblees/gists{/gist_id}","starred_url":"https://api.github.com/users/kblees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kblees/subscriptions","organizations_url":"https://api.github.com/users/kblees/orgs","repos_url":"https://api.github.com/users/kblees/repos","events_url":"https://api.github.com/users/kblees/events{/privacy}","received_events_url":"https://api.github.com/users/kblees/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2015-05-20T18:58:37Z","updated_at":"2015-06-19T05:45:30Z","closed_at":"2015-05-24T09:24:04Z","pull_request":{"url":"https://api.github.com/repos/git-for-windows/git/pulls/156","html_url":"https://github.com/git-for-windows/git/pull/156","diff_url":"https://github.com/git-for-windows/git/pull/156.diff","patch_url":"https://github.com/git-for-windows/git/pull/156.patch"},"body":"This with https://github.com/git-for-windows/msys2-runtime/pull/10 should fix issue #117\r\n\r\nI only tested this as admin with UAC disabled, so feedback from end users with UAC is welcome.\r\n\r\nDesign goals:\r\n\r\n * Symlinks should be disabled by default (due to the many quirks with Windows symlinks such as permissions, UAC, D/F conflicts, '..' path resolution etc.).\r\n * Existing functionality should not be affected if symlinks are disabled (i.e. guard symlink-specific code with `if (has_symlinks)`).\r\n * Minimize changes to core git code and the test suite.\r\n * Don't try to resolve symlinks manually (i.e. let Windows do the job by opening the symlink and using `Get*ByHandle()`).\r\n\r\nTo run the test-suite with symlinks enabled:\r\n```\r\nexport MSYS=winsymlinks:nativestrict\r\nmake test # or prove...\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/git-for-windows/git/issues/comments/113382169","html_url":"https://github.com/git-for-windows/git/pull/156#issuecomment-113382169","issue_url":"https://api.github.com/repos/git-for-windows/git/issues/156","id":113382169,"user":{"login":"chrisrichard","id":1100888,"avatar_url":"https://avatars.githubusercontent.com/u/1100888?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisrichard","html_url":"https://github.com/chrisrichard","followers_url":"https://api.github.com/users/chrisrichard/followers","following_url":"https://api.github.com/users/chrisrichard/following{/other_user}","gists_url":"https://api.github.com/users/chrisrichard/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisrichard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisrichard/subscriptions","organizations_url":"https://api.github.com/users/chrisrichard/orgs","repos_url":"https://api.github.com/users/chrisrichard/repos","events_url":"https://api.github.com/users/chrisrichard/events{/privacy}","received_events_url":"https://api.github.com/users/chrisrichard/received_events","type":"User","site_admin":false},"created_at":"2015-06-19T05:45:30Z","updated_at":"2015-06-19T05:45:30Z","body":"Thanks for doing this. I think it's a really important feature.\r\n\r\nIt's working well for me except for one little wrinkle that seems to crop up on directory links that were created on *nix. On Windows, git sees the destination path without the trailing slash, which causes it report changes immediately following a clone:\r\n\r\n```\r\ndiff --git a/public_html/public/wp-content b/public_html/public/wp-content\r\nindex 6787298..efcdaa6 120000\r\n--- a/public_html/public/wp-content\r\n+++ b/public_html/public/wp-content\r\n@@ -1 +1 @@\r\n-../content/\r\n+../content\r\n```\r\n\r\n"}}