{"action":"closed","number":2771,"pull_request":{"url":"https://api.github.com/repos/ajaxorg/ace/pulls/2771","id":50733192,"html_url":"https://github.com/ajaxorg/ace/pull/2771","diff_url":"https://github.com/ajaxorg/ace/pull/2771.diff","patch_url":"https://github.com/ajaxorg/ace/pull/2771.patch","issue_url":"https://api.github.com/repos/ajaxorg/ace/issues/2771","number":2771,"state":"closed","locked":false,"title":"If a completer returns undefined results, prevents ace throwing exception","user":{"login":"matthew-dean","id":414752,"avatar_url":"https://avatars.githubusercontent.com/u/414752?v=3","gravatar_id":"","url":"https://api.github.com/users/matthew-dean","html_url":"https://github.com/matthew-dean","followers_url":"https://api.github.com/users/matthew-dean/followers","following_url":"https://api.github.com/users/matthew-dean/following{/other_user}","gists_url":"https://api.github.com/users/matthew-dean/gists{/gist_id}","starred_url":"https://api.github.com/users/matthew-dean/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthew-dean/subscriptions","organizations_url":"https://api.github.com/users/matthew-dean/orgs","repos_url":"https://api.github.com/users/matthew-dean/repos","events_url":"https://api.github.com/users/matthew-dean/events{/privacy}","received_events_url":"https://api.github.com/users/matthew-dean/received_events","type":"User","site_admin":false},"body":"~~While this may have been caused by me with the Less mode (not sure)~~  **--scratch that, this happened for me in a PHP file**, this code change would at least prevent a misbehaving autocompleter from crashing Ace. Note that autocompletions still work in all other cases, so it must be from one errant token.","created_at":"2015-11-14T21:52:31Z","updated_at":"2015-11-29T14:41:06Z","closed_at":"2015-11-29T14:41:06Z","merged_at":"2015-11-29T14:41:06Z","merge_commit_sha":"1ec30ebf8353ef9fa493ecc0c5e4e2a255a7f896","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ajaxorg/ace/pulls/2771/commits","review_comments_url":"https://api.github.com/repos/ajaxorg/ace/pulls/2771/comments","review_comment_url":"https://api.github.com/repos/ajaxorg/ace/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ajaxorg/ace/issues/2771/comments","statuses_url":"https://api.github.com/repos/ajaxorg/ace/statuses/ce5e572c2caca68f4b81984e4a59404efa3e635a","head":{"label":"Crunch:master","ref":"master","sha":"ce5e572c2caca68f4b81984e4a59404efa3e635a","user":{"login":"Crunch","id":6404069,"avatar_url":"https://avatars.githubusercontent.com/u/6404069?v=3","gravatar_id":"","url":"https://api.github.com/users/Crunch","html_url":"https://github.com/Crunch","followers_url":"https://api.github.com/users/Crunch/followers","following_url":"https://api.github.com/users/Crunch/following{/other_user}","gists_url":"https://api.github.com/users/Crunch/gists{/gist_id}","starred_url":"https://api.github.com/users/Crunch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Crunch/subscriptions","organizations_url":"https://api.github.com/users/Crunch/orgs","repos_url":"https://api.github.com/users/Crunch/repos","events_url":"https://api.github.com/users/Crunch/events{/privacy}","received_events_url":"https://api.github.com/users/Crunch/received_events","type":"Organization","site_admin":false},"repo":{"id":45927573,"name":"ace","full_name":"Crunch/ace","owner":{"login":"Crunch","id":6404069,"avatar_url":"https://avatars.githubusercontent.com/u/6404069?v=3","gravatar_id":"","url":"https://api.github.com/users/Crunch","html_url":"https://github.com/Crunch","followers_url":"https://api.github.com/users/Crunch/followers","following_url":"https://api.github.com/users/Crunch/following{/other_user}","gists_url":"https://api.github.com/users/Crunch/gists{/gist_id}","starred_url":"https://api.github.com/users/Crunch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Crunch/subscriptions","organizations_url":"https://api.github.com/users/Crunch/orgs","repos_url":"https://api.github.com/users/Crunch/repos","events_url":"https://api.github.com/users/Crunch/events{/privacy}","received_events_url":"https://api.github.com/users/Crunch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Crunch/ace","description":"Ace (Ajax.org Cloud9 Editor)","fork":true,"url":"https://api.github.com/repos/Crunch/ace","forks_url":"https://api.github.com/repos/Crunch/ace/forks","keys_url":"https://api.github.com/repos/Crunch/ace/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Crunch/ace/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Crunch/ace/teams","hooks_url":"https://api.github.com/repos/Crunch/ace/hooks","issue_events_url":"https://api.github.com/repos/Crunch/ace/issues/events{/number}","events_url":"https://api.github.com/repos/Crunch/ace/events","assignees_url":"https://api.github.com/repos/Crunch/ace/assignees{/user}","branches_url":"https://api.github.com/repos/Crunch/ace/branches{/branch}","tags_url":"https://api.github.com/repos/Crunch/ace/tags","blobs_url":"https://api.github.com/repos/Crunch/ace/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Crunch/ace/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Crunch/ace/git/refs{/sha}","trees_url":"https://api.github.com/repos/Crunch/ace/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Crunch/ace/statuses/{sha}","languages_url":"https://api.github.com/repos/Crunch/ace/languages","stargazers_url":"https://api.github.com/repos/Crunch/ace/stargazers","contributors_url":"https://api.github.com/repos/Crunch/ace/contributors","subscribers_url":"https://api.github.com/repos/Crunch/ace/subscribers","subscription_url":"https://api.github.com/repos/Crunch/ace/subscription","commits_url":"https://api.github.com/repos/Crunch/ace/commits{/sha}","git_commits_url":"https://api.github.com/repos/Crunch/ace/git/commits{/sha}","comments_url":"https://api.github.com/repos/Crunch/ace/comments{/number}","issue_comment_url":"https://api.github.com/repos/Crunch/ace/issues/comments{/number}","contents_url":"https://api.github.com/repos/Crunch/ace/contents/{+path}","compare_url":"https://api.github.com/repos/Crunch/ace/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Crunch/ace/merges","archive_url":"https://api.github.com/repos/Crunch/ace/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Crunch/ace/downloads","issues_url":"https://api.github.com/repos/Crunch/ace/issues{/number}","pulls_url":"https://api.github.com/repos/Crunch/ace/pulls{/number}","milestones_url":"https://api.github.com/repos/Crunch/ace/milestones{/number}","notifications_url":"https://api.github.com/repos/Crunch/ace/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Crunch/ace/labels{/name}","releases_url":"https://api.github.com/repos/Crunch/ace/releases{/id}","created_at":"2015-11-10T17:14:04Z","updated_at":"2015-11-10T17:14:12Z","pushed_at":"2015-11-14T21:50:08Z","git_url":"git://github.com/Crunch/ace.git","ssh_url":"git@github.com:Crunch/ace.git","clone_url":"https://github.com/Crunch/ace.git","svn_url":"https://github.com/Crunch/ace","homepage":"http://ace.c9.io","size":72480,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ajaxorg:master","ref":"master","sha":"8a33670568e9359fa1f16f183e1c012dea569625","user":{"login":"ajaxorg","id":168515,"avatar_url":"https://avatars.githubusercontent.com/u/168515?v=3","gravatar_id":"","url":"https://api.github.com/users/ajaxorg","html_url":"https://github.com/ajaxorg","followers_url":"https://api.github.com/users/ajaxorg/followers","following_url":"https://api.github.com/users/ajaxorg/following{/other_user}","gists_url":"https://api.github.com/users/ajaxorg/gists{/gist_id}","starred_url":"https://api.github.com/users/ajaxorg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajaxorg/subscriptions","organizations_url":"https://api.github.com/users/ajaxorg/orgs","repos_url":"https://api.github.com/users/ajaxorg/repos","events_url":"https://api.github.com/users/ajaxorg/events{/privacy}","received_events_url":"https://api.github.com/users/ajaxorg/received_events","type":"Organization","site_admin":false},"repo":{"id":1028340,"name":"ace","full_name":"ajaxorg/ace","owner":{"login":"ajaxorg","id":168515,"avatar_url":"https://avatars.githubusercontent.com/u/168515?v=3","gravatar_id":"","url":"https://api.github.com/users/ajaxorg","html_url":"https://github.com/ajaxorg","followers_url":"https://api.github.com/users/ajaxorg/followers","following_url":"https://api.github.com/users/ajaxorg/following{/other_user}","gists_url":"https://api.github.com/users/ajaxorg/gists{/gist_id}","starred_url":"https://api.github.com/users/ajaxorg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajaxorg/subscriptions","organizations_url":"https://api.github.com/users/ajaxorg/orgs","repos_url":"https://api.github.com/users/ajaxorg/repos","events_url":"https://api.github.com/users/ajaxorg/events{/privacy}","received_events_url":"https://api.github.com/users/ajaxorg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ajaxorg/ace","description":"Ace (Ajax.org Cloud9 Editor)","fork":false,"url":"https://api.github.com/repos/ajaxorg/ace","forks_url":"https://api.github.com/repos/ajaxorg/ace/forks","keys_url":"https://api.github.com/repos/ajaxorg/ace/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ajaxorg/ace/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ajaxorg/ace/teams","hooks_url":"https://api.github.com/repos/ajaxorg/ace/hooks","issue_events_url":"https://api.github.com/repos/ajaxorg/ace/issues/events{/number}","events_url":"https://api.github.com/repos/ajaxorg/ace/events","assignees_url":"https://api.github.com/repos/ajaxorg/ace/assignees{/user}","branches_url":"https://api.github.com/repos/ajaxorg/ace/branches{/branch}","tags_url":"https://api.github.com/repos/ajaxorg/ace/tags","blobs_url":"https://api.github.com/repos/ajaxorg/ace/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ajaxorg/ace/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ajaxorg/ace/git/refs{/sha}","trees_url":"https://api.github.com/repos/ajaxorg/ace/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ajaxorg/ace/statuses/{sha}","languages_url":"https://api.github.com/repos/ajaxorg/ace/languages","stargazers_url":"https://api.github.com/repos/ajaxorg/ace/stargazers","contributors_url":"https://api.github.com/repos/ajaxorg/ace/contributors","subscribers_url":"https://api.github.com/repos/ajaxorg/ace/subscribers","subscription_url":"https://api.github.com/repos/ajaxorg/ace/subscription","commits_url":"https://api.github.com/repos/ajaxorg/ace/commits{/sha}","git_commits_url":"https://api.github.com/repos/ajaxorg/ace/git/commits{/sha}","comments_url":"https://api.github.com/repos/ajaxorg/ace/comments{/number}","issue_comment_url":"https://api.github.com/repos/ajaxorg/ace/issues/comments{/number}","contents_url":"https://api.github.com/repos/ajaxorg/ace/contents/{+path}","compare_url":"https://api.github.com/repos/ajaxorg/ace/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ajaxorg/ace/merges","archive_url":"https://api.github.com/repos/ajaxorg/ace/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ajaxorg/ace/downloads","issues_url":"https://api.github.com/repos/ajaxorg/ace/issues{/number}","pulls_url":"https://api.github.com/repos/ajaxorg/ace/pulls{/number}","milestones_url":"https://api.github.com/repos/ajaxorg/ace/milestones{/number}","notifications_url":"https://api.github.com/repos/ajaxorg/ace/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ajaxorg/ace/labels{/name}","releases_url":"https://api.github.com/repos/ajaxorg/ace/releases{/id}","created_at":"2010-10-27T10:43:36Z","updated_at":"2015-11-29T11:24:23Z","pushed_at":"2015-11-29T14:41:06Z","git_url":"git://github.com/ajaxorg/ace.git","ssh_url":"git@github.com:ajaxorg/ace.git","clone_url":"https://github.com/ajaxorg/ace.git","svn_url":"https://github.com/ajaxorg/ace","homepage":"http://ace.c9.io","size":55624,"stargazers_count":11723,"watchers_count":11723,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2772,"mirror_url":null,"open_issues_count":417,"forks":2772,"open_issues":417,"watchers":11723,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ajaxorg/ace/pulls/2771"},"html":{"href":"https://github.com/ajaxorg/ace/pull/2771"},"issue":{"href":"https://api.github.com/repos/ajaxorg/ace/issues/2771"},"comments":{"href":"https://api.github.com/repos/ajaxorg/ace/issues/2771/comments"},"review_comments":{"href":"https://api.github.com/repos/ajaxorg/ace/pulls/2771/comments"},"review_comment":{"href":"https://api.github.com/repos/ajaxorg/ace/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ajaxorg/ace/pulls/2771/commits"},"statuses":{"href":"https://api.github.com/repos/ajaxorg/ace/statuses/ce5e572c2caca68f4b81984e4a59404efa3e635a"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"nightwing","id":341801,"avatar_url":"https://avatars.githubusercontent.com/u/341801?v=3","gravatar_id":"","url":"https://api.github.com/users/nightwing","html_url":"https://github.com/nightwing","followers_url":"https://api.github.com/users/nightwing/followers","following_url":"https://api.github.com/users/nightwing/following{/other_user}","gists_url":"https://api.github.com/users/nightwing/gists{/gist_id}","starred_url":"https://api.github.com/users/nightwing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nightwing/subscriptions","organizations_url":"https://api.github.com/users/nightwing/orgs","repos_url":"https://api.github.com/users/nightwing/repos","events_url":"https://api.github.com/users/nightwing/events{/privacy}","received_events_url":"https://api.github.com/users/nightwing/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":2,"deletions":2,"changed_files":1}}