{"action":"created","issue":{"url":"https://api.github.com/repos/Polyconseil/aioamqp/issues/59","labels_url":"https://api.github.com/repos/Polyconseil/aioamqp/issues/59/labels{/name}","comments_url":"https://api.github.com/repos/Polyconseil/aioamqp/issues/59/comments","events_url":"https://api.github.com/repos/Polyconseil/aioamqp/issues/59/events","html_url":"https://github.com/Polyconseil/aioamqp/pull/59","id":119963886,"number":59,"title":"Bcz/client heartbeat","user":{"login":"dzen","id":50241,"avatar_url":"https://avatars.githubusercontent.com/u/50241?v=3","gravatar_id":"","url":"https://api.github.com/users/dzen","html_url":"https://github.com/dzen","followers_url":"https://api.github.com/users/dzen/followers","following_url":"https://api.github.com/users/dzen/following{/other_user}","gists_url":"https://api.github.com/users/dzen/gists{/gist_id}","starred_url":"https://api.github.com/users/dzen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dzen/subscriptions","organizations_url":"https://api.github.com/users/dzen/orgs","repos_url":"https://api.github.com/users/dzen/repos","events_url":"https://api.github.com/users/dzen/events{/privacy}","received_events_url":"https://api.github.com/users/dzen/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-12-02T15:17:38Z","updated_at":"2015-12-03T11:19:56Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Polyconseil/aioamqp/pulls/59","html_url":"https://github.com/Polyconseil/aioamqp/pull/59","diff_url":"https://github.com/Polyconseil/aioamqp/pull/59.diff","patch_url":"https://github.com/Polyconseil/aioamqp/pull/59.patch"},"body":"This PR deals with two things\r\n* allows to tune the AMQP connection\r\n* allows to handle heartbeat errors / timeout correctly"},"comment":{"url":"https://api.github.com/repos/Polyconseil/aioamqp/issues/comments/161602641","html_url":"https://github.com/Polyconseil/aioamqp/pull/59#issuecomment-161602641","issue_url":"https://api.github.com/repos/Polyconseil/aioamqp/issues/59","id":161602641,"user":{"login":"dzen","id":50241,"avatar_url":"https://avatars.githubusercontent.com/u/50241?v=3","gravatar_id":"","url":"https://api.github.com/users/dzen","html_url":"https://github.com/dzen","followers_url":"https://api.github.com/users/dzen/followers","following_url":"https://api.github.com/users/dzen/following{/other_user}","gists_url":"https://api.github.com/users/dzen/gists{/gist_id}","starred_url":"https://api.github.com/users/dzen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dzen/subscriptions","organizations_url":"https://api.github.com/users/dzen/orgs","repos_url":"https://api.github.com/users/dzen/repos","events_url":"https://api.github.com/users/dzen/events{/privacy}","received_events_url":"https://api.github.com/users/dzen/received_events","type":"User","site_admin":false},"created_at":"2015-12-03T11:19:56Z","updated_at":"2015-12-03T11:19:56Z","body":"From the documentation:\r\n\r\n```Heartbeat frames are sent about every timeout / 2 seconds. After two missed heartbeats, the peer is considered to be unreachable. Different clients manifest this differently but the TCP connection will be closed. When a client detects that RabbitMQ node is unreachable due to a heartbeat, it needs to re-connect. ```\r\n\r\nfor now this code only `wait_for` timeout=server_heartbeat. we should probably wait for a timeout of `server_heartbeat * 2`."}}