{"action":"created","issue":{"url":"https://api.github.com/repos/hyperspy/hyperspy/issues/498","labels_url":"https://api.github.com/repos/hyperspy/hyperspy/issues/498/labels{/name}","comments_url":"https://api.github.com/repos/hyperspy/hyperspy/issues/498/comments","events_url":"https://api.github.com/repos/hyperspy/hyperspy/issues/498/events","html_url":"https://github.com/hyperspy/hyperspy/pull/498","id":65919329,"number":498,"title":"Francisco dlp clone enh plot arguments","user":{"login":"to266","id":3384140,"avatar_url":"https://avatars.githubusercontent.com/u/3384140?v=3","gravatar_id":"","url":"https://api.github.com/users/to266","html_url":"https://github.com/to266","followers_url":"https://api.github.com/users/to266/followers","following_url":"https://api.github.com/users/to266/following{/other_user}","gists_url":"https://api.github.com/users/to266/gists{/gist_id}","starred_url":"https://api.github.com/users/to266/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/to266/subscriptions","organizations_url":"https://api.github.com/users/to266/orgs","repos_url":"https://api.github.com/users/to266/repos","events_url":"https://api.github.com/users/to266/events{/privacy}","received_events_url":"https://api.github.com/users/to266/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/hyperspy/hyperspy/labels/enhancement","name":"enhancement","color":"02e10c"},{"url":"https://api.github.com/repos/hyperspy/hyperspy/labels/needs%20review","name":"needs review","color":"006b75"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/hyperspy/hyperspy/milestones/2","html_url":"https://github.com/hyperspy/hyperspy/milestones/0.8","labels_url":"https://api.github.com/repos/hyperspy/hyperspy/milestones/2/labels","id":616623,"number":2,"title":"0.8","description":"","creator":{"login":"francisco-dlp","id":989719,"avatar_url":"https://avatars.githubusercontent.com/u/989719?v=3","gravatar_id":"","url":"https://api.github.com/users/francisco-dlp","html_url":"https://github.com/francisco-dlp","followers_url":"https://api.github.com/users/francisco-dlp/followers","following_url":"https://api.github.com/users/francisco-dlp/following{/other_user}","gists_url":"https://api.github.com/users/francisco-dlp/gists{/gist_id}","starred_url":"https://api.github.com/users/francisco-dlp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/francisco-dlp/subscriptions","organizations_url":"https://api.github.com/users/francisco-dlp/orgs","repos_url":"https://api.github.com/users/francisco-dlp/repos","events_url":"https://api.github.com/users/francisco-dlp/events{/privacy}","received_events_url":"https://api.github.com/users/francisco-dlp/received_events","type":"User","site_admin":false},"open_issues":8,"closed_issues":66,"state":"open","created_at":"2014-04-01T11:09:41Z","updated_at":"2015-04-06T08:58:40Z","due_on":"2015-03-26T00:00:00Z","closed_at":null},"comments":1,"created_at":"2015-04-02T12:57:33Z","updated_at":"2015-04-06T10:06:29Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/hyperspy/hyperspy/pulls/498","html_url":"https://github.com/hyperspy/hyperspy/pull/498","diff_url":"https://github.com/hyperspy/hyperspy/pull/498.diff","patch_url":"https://github.com/hyperspy/hyperspy/pull/498.patch"},"body":"Starting point (and replaces) #489 \r\n\r\n@jat255 , I think I fixed all the bugs you mentioned, but let me know if anything else is missing.\r\n@pburdet , could you review the code changes and merge once the documentation is added?\r\n\r\nThe most notable change from #489 and previous versions, is that the percentile is now calculated sanely - it now gives the part  of datapoints that will __not__ be saturated (i.e. percentile of 0.9 leaves 5% of points black and 5% white (i.e. saturated) ). It does not tak into account the values of the points, only the number of them.\r\n\r\nI believe before a bug was left, and since there was no way to specify values of percentiles and the default was sane, noone noticed.\r\n"},"comment":{"url":"https://api.github.com/repos/hyperspy/hyperspy/issues/comments/90000057","html_url":"https://github.com/hyperspy/hyperspy/pull/498#issuecomment-90000057","issue_url":"https://api.github.com/repos/hyperspy/hyperspy/issues/498","id":90000057,"user":{"login":"pburdet","id":3855190,"avatar_url":"https://avatars.githubusercontent.com/u/3855190?v=3","gravatar_id":"","url":"https://api.github.com/users/pburdet","html_url":"https://github.com/pburdet","followers_url":"https://api.github.com/users/pburdet/followers","following_url":"https://api.github.com/users/pburdet/following{/other_user}","gists_url":"https://api.github.com/users/pburdet/gists{/gist_id}","starred_url":"https://api.github.com/users/pburdet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pburdet/subscriptions","organizations_url":"https://api.github.com/users/pburdet/orgs","repos_url":"https://api.github.com/users/pburdet/repos","events_url":"https://api.github.com/users/pburdet/events{/privacy}","received_events_url":"https://api.github.com/users/pburdet/received_events","type":"User","site_admin":false},"created_at":"2015-04-06T10:06:29Z","updated_at":"2015-04-06T10:06:29Z","body":"Nice! \r\n\r\nI hit a bug when I'm doing that:\r\n\r\n```python\r\nim = signals.Image(np.random.random((10,64, 64)))\r\nim.plot(auto_contrast=False)\r\n```\r\n\r\nI'm expecting that `vmin` and `vmax`  are calculated on the current image and keept for the others images.\r\n\r\nAlso If `vmin` or `vmax` are provided, the `userWarning` is raised the first time but not afterwards. \r\n\r\n```python\r\nim = signals.Image(np.random.random((10,64, 64)))\r\nim.plot(vmin=0, vmax=1.)\r\n```\r\n\r\nCould `auto_contrast` be `False` if `vmin` or/and `vmax` are provided?"}}