{"action":"created","issue":{"url":"https://api.github.com/repos/start-jsk/rtmros_hironx/issues/338","labels_url":"https://api.github.com/repos/start-jsk/rtmros_hironx/issues/338/labels{/name}","comments_url":"https://api.github.com/repos/start-jsk/rtmros_hironx/issues/338/comments","events_url":"https://api.github.com/repos/start-jsk/rtmros_hironx/issues/338/events","html_url":"https://github.com/start-jsk/rtmros_hironx/pull/338","id":62380472,"number":338,"title":"[hironx_client.py] fix startImpedance and stopImpedance for new IDL > hrpsys 315.3.0","user":{"login":"k-okada","id":493276,"avatar_url":"https://avatars.githubusercontent.com/u/493276?v=3","gravatar_id":"","url":"https://api.github.com/users/k-okada","html_url":"https://github.com/k-okada","followers_url":"https://api.github.com/users/k-okada/followers","following_url":"https://api.github.com/users/k-okada/following{/other_user}","gists_url":"https://api.github.com/users/k-okada/gists{/gist_id}","starred_url":"https://api.github.com/users/k-okada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k-okada/subscriptions","organizations_url":"https://api.github.com/users/k-okada/orgs","repos_url":"https://api.github.com/users/k-okada/repos","events_url":"https://api.github.com/users/k-okada/events{/privacy}","received_events_url":"https://api.github.com/users/k-okada/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-03-17T12:17:02Z","updated_at":"2015-03-17T14:51:13Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/start-jsk/rtmros_hironx/pulls/338","html_url":"https://github.com/start-jsk/rtmros_hironx/pull/338","diff_url":"https://github.com/start-jsk/rtmros_hironx/pull/338.diff","patch_url":"https://github.com/start-jsk/rtmros_hironx/pull/338.patch"},"body":"since 315.3.0, Impedance Controller parameter has been changed, \nhttps://github.com/fkanehiro/hrpsys-base/issues/232\n\nwe may have to use conf file to set arm/force information such as https://github.com/fkanehiro/hrpsys-base/blob/master/sample/SampleRobot/SampleRobot.conf.in#L5, which is not documented (or required) at \nhttps://github.com/start-jsk/rtmros_hironx/pull/253#issuecomment-57050332\n\nwe need someone to confirm this"},"comment":{"url":"https://api.github.com/repos/start-jsk/rtmros_hironx/issues/comments/82392562","html_url":"https://github.com/start-jsk/rtmros_hironx/pull/338#issuecomment-82392562","issue_url":"https://api.github.com/repos/start-jsk/rtmros_hironx/issues/338","id":82392562,"user":{"login":"k-okada","id":493276,"avatar_url":"https://avatars.githubusercontent.com/u/493276?v=3","gravatar_id":"","url":"https://api.github.com/users/k-okada","html_url":"https://github.com/k-okada","followers_url":"https://api.github.com/users/k-okada/followers","following_url":"https://api.github.com/users/k-okada/following{/other_user}","gists_url":"https://api.github.com/users/k-okada/gists{/gist_id}","starred_url":"https://api.github.com/users/k-okada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k-okada/subscriptions","organizations_url":"https://api.github.com/users/k-okada/orgs","repos_url":"https://api.github.com/users/k-okada/repos","events_url":"https://api.github.com/users/k-okada/events{/privacy}","received_events_url":"https://api.github.com/users/k-okada/received_events","type":"User","site_admin":false},"created_at":"2015-03-17T14:51:13Z","updated_at":"2015-03-17T14:51:13Z","body":"+1 for both, so it is +2\n\n@eusoku9618 is working on this,\n\n2015年3月17日火曜日、Shunichi Nozawa<notifications@github.com>さんは書きました:\n\n> startImpedance and stopImpedance are quite important functions and we\n> have almost same functions in our robots' hrpsys.py.\n> I'd like to add these funcitons to hrpsys-base's hrpsys_config.py.\n>\n>    - Function name idl function name is startImpedanceController and\n>    stopImpedanceController.\n>    https://github.com/fkanehiro/hrpsys-base/blob/master/idl/ImpedanceControllerService.idl#L48\n>    What do you think about using startImpedanceController instead of\n>    startImpedance?\n>    - Set param startImpedanceController in idl file just starts impedance\n>    control mode. This function does not set any impedance controller param. I\n>    think it would be better that startImpedanceController just starts\n>    impedance mode and does not set any parameters. This is because if\n>    userA sets parameters and then userB calls startImpedanceController,\n>    userA's parameter is overritten by userB's startImpedanceController\n>    function.\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/start-jsk/rtmros_hironx/pull/338#issuecomment-82380075>\n> .\n>\n\n\n-- \n--\n◉ Kei Okada\n"}}