{"action":"created","comment":{"url":"https://api.github.com/repos/scala-ide/scala-ide/pulls/comments/31129243","id":31129243,"diff_hunk":"@@ -153,31 +147,63 @@ trait SaveActionExtensions extends HasLogger {\n   }\n \n   /**\n-   * Applies all save actions that extends [[DocumentSupport]].\n+   * Applies all save actions that extend [[DocumentSupport]].\n    */\n   private def applyDocumentExtensions(udoc: IDocument): Unit = {\n     for ((setting, ext) <- documentSaveActions if isEnabled(setting.id)) {\n       val doc = new TextDocument(udoc)\n       val instance = ext(doc)\n-      performExtension(instance, udoc) {\n+      performDocumentExtension(instance, udoc) {\n         instance.perform()\n       }\n     }\n   }\n \n   /**\n-   * Applies all save actions that extends [[CompilerSupport]].\n+   * Applies all save actions that extend [[CompilerSupport]].\n    */\n   private def applyCompilerExtensions(udoc: IDocument): Unit = {\n-    for ((setting, ext) <- compilerSaveActions if isEnabled(setting.id)) {\n-      createExtensionWithCompilerSupport(ext) foreach { instance =>\n-        performExtension(instance, udoc) {\n-          instance.global.asInstanceOf[IScalaPresentationCompiler].asyncExec {\n-            instance.perform()\n-          }.getOrElse(Seq())()\n+    val timeout = saveActionTimeout\n+\n+    def loop(xs: Seq[(SaveActionSetting, CompilerSupportCreator)]): Unit = xs match {\n+      case Nil ⇒\n+\n+      case (setting, ext) :: xs if isEnabled(setting.id) ⇒\n+        val res = FutureUtils.performWithTimeout(timeout) {\n+          EclipseUtils.withSafeRunner(s\"An error occurred while executing compiler driven save action.\") {","path":"org.scala-ide.sdt.core/src/org/scalaide/ui/internal/editor/SaveActionExtensions.scala","position":98,"original_position":98,"commit_id":"c7271eda5f6f75fc06258db287b9e4e1d25791c4","original_commit_id":"c7271eda5f6f75fc06258db287b9e4e1d25791c4","user":{"login":"Kwestor","id":3084180,"avatar_url":"https://avatars.githubusercontent.com/u/3084180?v=3","gravatar_id":"","url":"https://api.github.com/users/Kwestor","html_url":"https://github.com/Kwestor","followers_url":"https://api.github.com/users/Kwestor/followers","following_url":"https://api.github.com/users/Kwestor/following{/other_user}","gists_url":"https://api.github.com/users/Kwestor/gists{/gist_id}","starred_url":"https://api.github.com/users/Kwestor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kwestor/subscriptions","organizations_url":"https://api.github.com/users/Kwestor/orgs","repos_url":"https://api.github.com/users/Kwestor/repos","events_url":"https://api.github.com/users/Kwestor/events{/privacy}","received_events_url":"https://api.github.com/users/Kwestor/received_events","type":"User","site_admin":false},"body":"Is there a reason not to include `${setting.id}` here?","created_at":"2015-05-27T12:48:51Z","updated_at":"2015-05-27T12:48:51Z","html_url":"https://github.com/scala-ide/scala-ide/pull/960#discussion_r31129243","pull_request_url":"https://api.github.com/repos/scala-ide/scala-ide/pulls/960","_links":{"self":{"href":"https://api.github.com/repos/scala-ide/scala-ide/pulls/comments/31129243"},"html":{"href":"https://github.com/scala-ide/scala-ide/pull/960#discussion_r31129243"},"pull_request":{"href":"https://api.github.com/repos/scala-ide/scala-ide/pulls/960"}}},"pull_request":{"url":"https://api.github.com/repos/scala-ide/scala-ide/pulls/960","id":36299359,"html_url":"https://github.com/scala-ide/scala-ide/pull/960","diff_url":"https://github.com/scala-ide/scala-ide/pull/960.diff","patch_url":"https://github.com/scala-ide/scala-ide/pull/960.patch","issue_url":"https://api.github.com/repos/scala-ide/scala-ide/issues/960","number":960,"state":"open","locked":false,"title":"Enable compiler driven save actions","user":{"login":"sschaef","id":488530,"avatar_url":"https://avatars.githubusercontent.com/u/488530?v=3","gravatar_id":"","url":"https://api.github.com/users/sschaef","html_url":"https://github.com/sschaef","followers_url":"https://api.github.com/users/sschaef/followers","following_url":"https://api.github.com/users/sschaef/following{/other_user}","gists_url":"https://api.github.com/users/sschaef/gists{/gist_id}","starred_url":"https://api.github.com/users/sschaef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sschaef/subscriptions","organizations_url":"https://api.github.com/users/sschaef/orgs","repos_url":"https://api.github.com/users/sschaef/repos","events_url":"https://api.github.com/users/sschaef/events{/privacy}","received_events_url":"https://api.github.com/users/sschaef/received_events","type":"User","site_admin":false},"body":"See commit messages for more information","created_at":"2015-05-27T12:43:59Z","updated_at":"2015-05-27T12:48:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eb49922af34563cc50a43ebb9e9c75baebf20465","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/scala-ide/scala-ide/pulls/960/commits","review_comments_url":"https://api.github.com/repos/scala-ide/scala-ide/pulls/960/comments","review_comment_url":"https://api.github.com/repos/scala-ide/scala-ide/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scala-ide/scala-ide/issues/960/comments","statuses_url":"https://api.github.com/repos/scala-ide/scala-ide/statuses/c7271eda5f6f75fc06258db287b9e4e1d25791c4","head":{"label":"sschaef:t1002308","ref":"t1002308","sha":"c7271eda5f6f75fc06258db287b9e4e1d25791c4","user":{"login":"sschaef","id":488530,"avatar_url":"https://avatars.githubusercontent.com/u/488530?v=3","gravatar_id":"","url":"https://api.github.com/users/sschaef","html_url":"https://github.com/sschaef","followers_url":"https://api.github.com/users/sschaef/followers","following_url":"https://api.github.com/users/sschaef/following{/other_user}","gists_url":"https://api.github.com/users/sschaef/gists{/gist_id}","starred_url":"https://api.github.com/users/sschaef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sschaef/subscriptions","organizations_url":"https://api.github.com/users/sschaef/orgs","repos_url":"https://api.github.com/users/sschaef/repos","events_url":"https://api.github.com/users/sschaef/events{/privacy}","received_events_url":"https://api.github.com/users/sschaef/received_events","type":"User","site_admin":false},"repo":{"id":4021060,"name":"scala-ide","full_name":"sschaef/scala-ide","owner":{"login":"sschaef","id":488530,"avatar_url":"https://avatars.githubusercontent.com/u/488530?v=3","gravatar_id":"","url":"https://api.github.com/users/sschaef","html_url":"https://github.com/sschaef","followers_url":"https://api.github.com/users/sschaef/followers","following_url":"https://api.github.com/users/sschaef/following{/other_user}","gists_url":"https://api.github.com/users/sschaef/gists{/gist_id}","starred_url":"https://api.github.com/users/sschaef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sschaef/subscriptions","organizations_url":"https://api.github.com/users/sschaef/orgs","repos_url":"https://api.github.com/users/sschaef/repos","events_url":"https://api.github.com/users/sschaef/events{/privacy}","received_events_url":"https://api.github.com/users/sschaef/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sschaef/scala-ide","description":"Scala IDE for Eclipse","fork":true,"url":"https://api.github.com/repos/sschaef/scala-ide","forks_url":"https://api.github.com/repos/sschaef/scala-ide/forks","keys_url":"https://api.github.com/repos/sschaef/scala-ide/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sschaef/scala-ide/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sschaef/scala-ide/teams","hooks_url":"https://api.github.com/repos/sschaef/scala-ide/hooks","issue_events_url":"https://api.github.com/repos/sschaef/scala-ide/issues/events{/number}","events_url":"https://api.github.com/repos/sschaef/scala-ide/events","assignees_url":"https://api.github.com/repos/sschaef/scala-ide/assignees{/user}","branches_url":"https://api.github.com/repos/sschaef/scala-ide/branches{/branch}","tags_url":"https://api.github.com/repos/sschaef/scala-ide/tags","blobs_url":"https://api.github.com/repos/sschaef/scala-ide/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sschaef/scala-ide/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sschaef/scala-ide/git/refs{/sha}","trees_url":"https://api.github.com/repos/sschaef/scala-ide/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sschaef/scala-ide/statuses/{sha}","languages_url":"https://api.github.com/repos/sschaef/scala-ide/languages","stargazers_url":"https://api.github.com/repos/sschaef/scala-ide/stargazers","contributors_url":"https://api.github.com/repos/sschaef/scala-ide/contributors","subscribers_url":"https://api.github.com/repos/sschaef/scala-ide/subscribers","subscription_url":"https://api.github.com/repos/sschaef/scala-ide/subscription","commits_url":"https://api.github.com/repos/sschaef/scala-ide/commits{/sha}","git_commits_url":"https://api.github.com/repos/sschaef/scala-ide/git/commits{/sha}","comments_url":"https://api.github.com/repos/sschaef/scala-ide/comments{/number}","issue_comment_url":"https://api.github.com/repos/sschaef/scala-ide/issues/comments{/number}","contents_url":"https://api.github.com/repos/sschaef/scala-ide/contents/{+path}","compare_url":"https://api.github.com/repos/sschaef/scala-ide/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sschaef/scala-ide/merges","archive_url":"https://api.github.com/repos/sschaef/scala-ide/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sschaef/scala-ide/downloads","issues_url":"https://api.github.com/repos/sschaef/scala-ide/issues{/number}","pulls_url":"https://api.github.com/repos/sschaef/scala-ide/pulls{/number}","milestones_url":"https://api.github.com/repos/sschaef/scala-ide/milestones{/number}","notifications_url":"https://api.github.com/repos/sschaef/scala-ide/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sschaef/scala-ide/labels{/name}","releases_url":"https://api.github.com/repos/sschaef/scala-ide/releases{/id}","created_at":"2012-04-13T23:03:01Z","updated_at":"2015-05-08T13:08:22Z","pushed_at":"2015-05-27T12:41:40Z","git_url":"git://github.com/sschaef/scala-ide.git","ssh_url":"git@github.com:sschaef/scala-ide.git","clone_url":"https://github.com/sschaef/scala-ide.git","svn_url":"https://github.com/sschaef/scala-ide","homepage":"www.scala-ide.org","size":147298,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scala-ide:master","ref":"master","sha":"4652c00a15e22e8a5bec2da43005454712289c29","user":{"login":"scala-ide","id":1026788,"avatar_url":"https://avatars.githubusercontent.com/u/1026788?v=3","gravatar_id":"","url":"https://api.github.com/users/scala-ide","html_url":"https://github.com/scala-ide","followers_url":"https://api.github.com/users/scala-ide/followers","following_url":"https://api.github.com/users/scala-ide/following{/other_user}","gists_url":"https://api.github.com/users/scala-ide/gists{/gist_id}","starred_url":"https://api.github.com/users/scala-ide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scala-ide/subscriptions","organizations_url":"https://api.github.com/users/scala-ide/orgs","repos_url":"https://api.github.com/users/scala-ide/repos","events_url":"https://api.github.com/users/scala-ide/events{/privacy}","received_events_url":"https://api.github.com/users/scala-ide/received_events","type":"Organization","site_admin":false},"repo":{"id":2510011,"name":"scala-ide","full_name":"scala-ide/scala-ide","owner":{"login":"scala-ide","id":1026788,"avatar_url":"https://avatars.githubusercontent.com/u/1026788?v=3","gravatar_id":"","url":"https://api.github.com/users/scala-ide","html_url":"https://github.com/scala-ide","followers_url":"https://api.github.com/users/scala-ide/followers","following_url":"https://api.github.com/users/scala-ide/following{/other_user}","gists_url":"https://api.github.com/users/scala-ide/gists{/gist_id}","starred_url":"https://api.github.com/users/scala-ide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scala-ide/subscriptions","organizations_url":"https://api.github.com/users/scala-ide/orgs","repos_url":"https://api.github.com/users/scala-ide/repos","events_url":"https://api.github.com/users/scala-ide/events{/privacy}","received_events_url":"https://api.github.com/users/scala-ide/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scala-ide/scala-ide","description":"Scala IDE for Eclipse","fork":false,"url":"https://api.github.com/repos/scala-ide/scala-ide","forks_url":"https://api.github.com/repos/scala-ide/scala-ide/forks","keys_url":"https://api.github.com/repos/scala-ide/scala-ide/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scala-ide/scala-ide/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scala-ide/scala-ide/teams","hooks_url":"https://api.github.com/repos/scala-ide/scala-ide/hooks","issue_events_url":"https://api.github.com/repos/scala-ide/scala-ide/issues/events{/number}","events_url":"https://api.github.com/repos/scala-ide/scala-ide/events","assignees_url":"https://api.github.com/repos/scala-ide/scala-ide/assignees{/user}","branches_url":"https://api.github.com/repos/scala-ide/scala-ide/branches{/branch}","tags_url":"https://api.github.com/repos/scala-ide/scala-ide/tags","blobs_url":"https://api.github.com/repos/scala-ide/scala-ide/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scala-ide/scala-ide/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scala-ide/scala-ide/git/refs{/sha}","trees_url":"https://api.github.com/repos/scala-ide/scala-ide/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scala-ide/scala-ide/statuses/{sha}","languages_url":"https://api.github.com/repos/scala-ide/scala-ide/languages","stargazers_url":"https://api.github.com/repos/scala-ide/scala-ide/stargazers","contributors_url":"https://api.github.com/repos/scala-ide/scala-ide/contributors","subscribers_url":"https://api.github.com/repos/scala-ide/scala-ide/subscribers","subscription_url":"https://api.github.com/repos/scala-ide/scala-ide/subscription","commits_url":"https://api.github.com/repos/scala-ide/scala-ide/commits{/sha}","git_commits_url":"https://api.github.com/repos/scala-ide/scala-ide/git/commits{/sha}","comments_url":"https://api.github.com/repos/scala-ide/scala-ide/comments{/number}","issue_comment_url":"https://api.github.com/repos/scala-ide/scala-ide/issues/comments{/number}","contents_url":"https://api.github.com/repos/scala-ide/scala-ide/contents/{+path}","compare_url":"https://api.github.com/repos/scala-ide/scala-ide/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scala-ide/scala-ide/merges","archive_url":"https://api.github.com/repos/scala-ide/scala-ide/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scala-ide/scala-ide/downloads","issues_url":"https://api.github.com/repos/scala-ide/scala-ide/issues{/number}","pulls_url":"https://api.github.com/repos/scala-ide/scala-ide/pulls{/number}","milestones_url":"https://api.github.com/repos/scala-ide/scala-ide/milestones{/number}","notifications_url":"https://api.github.com/repos/scala-ide/scala-ide/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scala-ide/scala-ide/labels{/name}","releases_url":"https://api.github.com/repos/scala-ide/scala-ide/releases{/id}","created_at":"2011-10-04T05:56:23Z","updated_at":"2015-05-20T07:56:44Z","pushed_at":"2015-05-27T12:43:59Z","git_url":"git://github.com/scala-ide/scala-ide.git","ssh_url":"git@github.com:scala-ide/scala-ide.git","clone_url":"https://github.com/scala-ide/scala-ide.git","svn_url":"https://github.com/scala-ide/scala-ide","homepage":"www.scala-ide.org","size":159187,"stargazers_count":391,"watchers_count":391,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":200,"mirror_url":null,"open_issues_count":7,"forks":200,"open_issues":7,"watchers":391,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scala-ide/scala-ide/pulls/960"},"html":{"href":"https://github.com/scala-ide/scala-ide/pull/960"},"issue":{"href":"https://api.github.com/repos/scala-ide/scala-ide/issues/960"},"comments":{"href":"https://api.github.com/repos/scala-ide/scala-ide/issues/960/comments"},"review_comments":{"href":"https://api.github.com/repos/scala-ide/scala-ide/pulls/960/comments"},"review_comment":{"href":"https://api.github.com/repos/scala-ide/scala-ide/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scala-ide/scala-ide/pulls/960/commits"},"statuses":{"href":"https://api.github.com/repos/scala-ide/scala-ide/statuses/c7271eda5f6f75fc06258db287b9e4e1d25791c4"}}}}