{"action":"created","comment":{"url":"https://api.github.com/repos/theforeman/puppet-foreman/pulls/comments/23224562","id":23224562,"diff_hunk":"@@ -33,15 +33,19 @@\n   if $install_images {\n     include ::tftp::params\n \n-    foreman::remote_file {\"${::tftp::params::root}boot/${kernel}\":\n-      remote_location => \"${source}${kernel}\",\n+    foreman::remote_file {\"${::tftp::params::root}boot/${image_name}\":\n+      remote_location => \"${source}${image_name}\",\n       mode            => 0644,\n       require         => File[\"${::tftp::params::root}boot\"],\n+      notify          => Exec[\"untar ${image_name}\"],\n     }\n-    foreman::remote_file {\"${::tftp::params::root}boot/${initrd}\":\n-      remote_location => \"${source}${initrd}\",\n-      mode            => 0644,\n-      require         => File[\"${::tftp::params::root}boot\"],\n+\n+    exec { \"untar ${image_name}\":\n+      command     => \"tar xf ${image_name}\",\n+      path        => '/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin',\n+      cwd         => \"${::tftp::params::root}boot\",\n+      refreshonly => true,","path":"manifests/plugin/discovery.pp","position":54,"original_position":54,"commit_id":"fdf0f0fa6abcfa864f9095990890254939141c91","original_commit_id":"fdf0f0fa6abcfa864f9095990890254939141c91","user":{"login":"lzap","id":49752,"avatar_url":"https://avatars.githubusercontent.com/u/49752?v=3","gravatar_id":"","url":"https://api.github.com/users/lzap","html_url":"https://github.com/lzap","followers_url":"https://api.github.com/users/lzap/followers","following_url":"https://api.github.com/users/lzap/following{/other_user}","gists_url":"https://api.github.com/users/lzap/gists{/gist_id}","starred_url":"https://api.github.com/users/lzap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lzap/subscriptions","organizations_url":"https://api.github.com/users/lzap/orgs","repos_url":"https://api.github.com/users/lzap/repos","events_url":"https://api.github.com/users/lzap/events{/privacy}","received_events_url":"https://api.github.com/users/lzap/received_events","type":"User","site_admin":false},"body":"Oh sure, created this:\r\n\r\n      creates     => \"${::tftp::params::root}boot/fdi-image/initrd0.img\"],\r\n\r\n","created_at":"2015-01-20T14:24:41Z","updated_at":"2015-01-20T14:24:41Z","html_url":"https://github.com/theforeman/puppet-foreman/pull/253#discussion_r23224562","pull_request_url":"https://api.github.com/repos/theforeman/puppet-foreman/pulls/253","_links":{"self":{"href":"https://api.github.com/repos/theforeman/puppet-foreman/pulls/comments/23224562"},"html":{"href":"https://github.com/theforeman/puppet-foreman/pull/253#discussion_r23224562"},"pull_request":{"href":"https://api.github.com/repos/theforeman/puppet-foreman/pulls/253"}}},"pull_request":{"url":"https://api.github.com/repos/theforeman/puppet-foreman/pulls/253","id":24753753,"html_url":"https://github.com/theforeman/puppet-foreman/pull/253","diff_url":"https://github.com/theforeman/puppet-foreman/pull/253.diff","patch_url":"https://github.com/theforeman/puppet-foreman/pull/253.patch","issue_url":"https://api.github.com/repos/theforeman/puppet-foreman/issues/253","number":253,"state":"open","locked":false,"title":"Added support for tar-based discovery image 2.0","user":{"login":"lzap","id":49752,"avatar_url":"https://avatars.githubusercontent.com/u/49752?v=3","gravatar_id":"","url":"https://api.github.com/users/lzap","html_url":"https://github.com/lzap","followers_url":"https://api.github.com/users/lzap/followers","following_url":"https://api.github.com/users/lzap/following{/other_user}","gists_url":"https://api.github.com/users/lzap/gists{/gist_id}","starred_url":"https://api.github.com/users/lzap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lzap/subscriptions","organizations_url":"https://api.github.com/users/lzap/orgs","repos_url":"https://api.github.com/users/lzap/repos","events_url":"https://api.github.com/users/lzap/events{/privacy}","received_events_url":"https://api.github.com/users/lzap/received_events","type":"User","site_admin":false},"body":"Tests are green, but I struggle testing this. When I do\n\n`foreman-installer -v --foreman-plugin-discovery-install-images=true`\n\nnothing happens. I am not sure if kafo caches the parameters or something (they\nchanged a bit). @ares any tips for me?\n\nThanks","created_at":"2014-11-20T10:01:27Z","updated_at":"2015-01-20T14:24:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e59d1de6482c9d9b82d8609f3f2fced0837584c2","assignee":null,"milestone":{"url":"https://api.github.com/repos/theforeman/puppet-foreman/milestones/1","labels_url":"https://api.github.com/repos/theforeman/puppet-foreman/milestones/1/labels","id":936475,"number":1,"title":"3.0.0","description":"Major release, so may contain incompatible changes.","creator":{"login":"domcleal","id":482089,"avatar_url":"https://avatars.githubusercontent.com/u/482089?v=3","gravatar_id":"","url":"https://api.github.com/users/domcleal","html_url":"https://github.com/domcleal","followers_url":"https://api.github.com/users/domcleal/followers","following_url":"https://api.github.com/users/domcleal/following{/other_user}","gists_url":"https://api.github.com/users/domcleal/gists{/gist_id}","starred_url":"https://api.github.com/users/domcleal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/domcleal/subscriptions","organizations_url":"https://api.github.com/users/domcleal/orgs","repos_url":"https://api.github.com/users/domcleal/repos","events_url":"https://api.github.com/users/domcleal/events{/privacy}","received_events_url":"https://api.github.com/users/domcleal/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":1,"state":"open","created_at":"2015-01-15T09:10:11Z","updated_at":"2015-01-15T18:00:48Z","due_on":"2015-02-04T00:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/theforeman/puppet-foreman/pulls/253/commits","review_comments_url":"https://api.github.com/repos/theforeman/puppet-foreman/pulls/253/comments","review_comment_url":"https://api.github.com/repos/theforeman/puppet-foreman/pulls/comments/{number}","comments_url":"https://api.github.com/repos/theforeman/puppet-foreman/issues/253/comments","statuses_url":"https://api.github.com/repos/theforeman/puppet-foreman/statuses/fdf0f0fa6abcfa864f9095990890254939141c91","head":{"label":"lzap:master","ref":"master","sha":"fdf0f0fa6abcfa864f9095990890254939141c91","user":{"login":"lzap","id":49752,"avatar_url":"https://avatars.githubusercontent.com/u/49752?v=3","gravatar_id":"","url":"https://api.github.com/users/lzap","html_url":"https://github.com/lzap","followers_url":"https://api.github.com/users/lzap/followers","following_url":"https://api.github.com/users/lzap/following{/other_user}","gists_url":"https://api.github.com/users/lzap/gists{/gist_id}","starred_url":"https://api.github.com/users/lzap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lzap/subscriptions","organizations_url":"https://api.github.com/users/lzap/orgs","repos_url":"https://api.github.com/users/lzap/repos","events_url":"https://api.github.com/users/lzap/events{/privacy}","received_events_url":"https://api.github.com/users/lzap/received_events","type":"User","site_admin":false},"repo":{"id":9980074,"name":"puppet-foreman","full_name":"lzap/puppet-foreman","owner":{"login":"lzap","id":49752,"avatar_url":"https://avatars.githubusercontent.com/u/49752?v=3","gravatar_id":"","url":"https://api.github.com/users/lzap","html_url":"https://github.com/lzap","followers_url":"https://api.github.com/users/lzap/followers","following_url":"https://api.github.com/users/lzap/following{/other_user}","gists_url":"https://api.github.com/users/lzap/gists{/gist_id}","starred_url":"https://api.github.com/users/lzap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lzap/subscriptions","organizations_url":"https://api.github.com/users/lzap/orgs","repos_url":"https://api.github.com/users/lzap/repos","events_url":"https://api.github.com/users/lzap/events{/privacy}","received_events_url":"https://api.github.com/users/lzap/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lzap/puppet-foreman","description":"Puppet module for Foreman","fork":true,"url":"https://api.github.com/repos/lzap/puppet-foreman","forks_url":"https://api.github.com/repos/lzap/puppet-foreman/forks","keys_url":"https://api.github.com/repos/lzap/puppet-foreman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lzap/puppet-foreman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lzap/puppet-foreman/teams","hooks_url":"https://api.github.com/repos/lzap/puppet-foreman/hooks","issue_events_url":"https://api.github.com/repos/lzap/puppet-foreman/issues/events{/number}","events_url":"https://api.github.com/repos/lzap/puppet-foreman/events","assignees_url":"https://api.github.com/repos/lzap/puppet-foreman/assignees{/user}","branches_url":"https://api.github.com/repos/lzap/puppet-foreman/branches{/branch}","tags_url":"https://api.github.com/repos/lzap/puppet-foreman/tags","blobs_url":"https://api.github.com/repos/lzap/puppet-foreman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lzap/puppet-foreman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lzap/puppet-foreman/git/refs{/sha}","trees_url":"https://api.github.com/repos/lzap/puppet-foreman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lzap/puppet-foreman/statuses/{sha}","languages_url":"https://api.github.com/repos/lzap/puppet-foreman/languages","stargazers_url":"https://api.github.com/repos/lzap/puppet-foreman/stargazers","contributors_url":"https://api.github.com/repos/lzap/puppet-foreman/contributors","subscribers_url":"https://api.github.com/repos/lzap/puppet-foreman/subscribers","subscription_url":"https://api.github.com/repos/lzap/puppet-foreman/subscription","commits_url":"https://api.github.com/repos/lzap/puppet-foreman/commits{/sha}","git_commits_url":"https://api.github.com/repos/lzap/puppet-foreman/git/commits{/sha}","comments_url":"https://api.github.com/repos/lzap/puppet-foreman/comments{/number}","issue_comment_url":"https://api.github.com/repos/lzap/puppet-foreman/issues/comments/{number}","contents_url":"https://api.github.com/repos/lzap/puppet-foreman/contents/{+path}","compare_url":"https://api.github.com/repos/lzap/puppet-foreman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lzap/puppet-foreman/merges","archive_url":"https://api.github.com/repos/lzap/puppet-foreman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lzap/puppet-foreman/downloads","issues_url":"https://api.github.com/repos/lzap/puppet-foreman/issues{/number}","pulls_url":"https://api.github.com/repos/lzap/puppet-foreman/pulls{/number}","milestones_url":"https://api.github.com/repos/lzap/puppet-foreman/milestones{/number}","notifications_url":"https://api.github.com/repos/lzap/puppet-foreman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lzap/puppet-foreman/labels{/name}","releases_url":"https://api.github.com/repos/lzap/puppet-foreman/releases{/id}","created_at":"2013-05-10T11:23:59Z","updated_at":"2014-11-20T11:15:41Z","pushed_at":"2014-11-20T11:15:40Z","git_url":"git://github.com/lzap/puppet-foreman.git","ssh_url":"git@github.com:lzap/puppet-foreman.git","clone_url":"https://github.com/lzap/puppet-foreman.git","svn_url":"https://github.com/lzap/puppet-foreman","homepage":"","size":842,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"theforeman:master","ref":"master","sha":"30b7d48e9abe5381bf0c62a62d55e4b55d31c202","user":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars.githubusercontent.com/u/1439844?v=3","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"repo":{"id":3449583,"name":"puppet-foreman","full_name":"theforeman/puppet-foreman","owner":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars.githubusercontent.com/u/1439844?v=3","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/theforeman/puppet-foreman","description":"Puppet module for Foreman","fork":false,"url":"https://api.github.com/repos/theforeman/puppet-foreman","forks_url":"https://api.github.com/repos/theforeman/puppet-foreman/forks","keys_url":"https://api.github.com/repos/theforeman/puppet-foreman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theforeman/puppet-foreman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theforeman/puppet-foreman/teams","hooks_url":"https://api.github.com/repos/theforeman/puppet-foreman/hooks","issue_events_url":"https://api.github.com/repos/theforeman/puppet-foreman/issues/events{/number}","events_url":"https://api.github.com/repos/theforeman/puppet-foreman/events","assignees_url":"https://api.github.com/repos/theforeman/puppet-foreman/assignees{/user}","branches_url":"https://api.github.com/repos/theforeman/puppet-foreman/branches{/branch}","tags_url":"https://api.github.com/repos/theforeman/puppet-foreman/tags","blobs_url":"https://api.github.com/repos/theforeman/puppet-foreman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theforeman/puppet-foreman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theforeman/puppet-foreman/git/refs{/sha}","trees_url":"https://api.github.com/repos/theforeman/puppet-foreman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theforeman/puppet-foreman/statuses/{sha}","languages_url":"https://api.github.com/repos/theforeman/puppet-foreman/languages","stargazers_url":"https://api.github.com/repos/theforeman/puppet-foreman/stargazers","contributors_url":"https://api.github.com/repos/theforeman/puppet-foreman/contributors","subscribers_url":"https://api.github.com/repos/theforeman/puppet-foreman/subscribers","subscription_url":"https://api.github.com/repos/theforeman/puppet-foreman/subscription","commits_url":"https://api.github.com/repos/theforeman/puppet-foreman/commits{/sha}","git_commits_url":"https://api.github.com/repos/theforeman/puppet-foreman/git/commits{/sha}","comments_url":"https://api.github.com/repos/theforeman/puppet-foreman/comments{/number}","issue_comment_url":"https://api.github.com/repos/theforeman/puppet-foreman/issues/comments/{number}","contents_url":"https://api.github.com/repos/theforeman/puppet-foreman/contents/{+path}","compare_url":"https://api.github.com/repos/theforeman/puppet-foreman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theforeman/puppet-foreman/merges","archive_url":"https://api.github.com/repos/theforeman/puppet-foreman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theforeman/puppet-foreman/downloads","issues_url":"https://api.github.com/repos/theforeman/puppet-foreman/issues{/number}","pulls_url":"https://api.github.com/repos/theforeman/puppet-foreman/pulls{/number}","milestones_url":"https://api.github.com/repos/theforeman/puppet-foreman/milestones{/number}","notifications_url":"https://api.github.com/repos/theforeman/puppet-foreman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theforeman/puppet-foreman/labels{/name}","releases_url":"https://api.github.com/repos/theforeman/puppet-foreman/releases{/id}","created_at":"2012-02-15T13:19:01Z","updated_at":"2015-01-15T17:58:51Z","pushed_at":"2015-01-15T17:58:51Z","git_url":"git://github.com/theforeman/puppet-foreman.git","ssh_url":"git@github.com:theforeman/puppet-foreman.git","clone_url":"https://github.com/theforeman/puppet-foreman.git","svn_url":"https://github.com/theforeman/puppet-foreman","homepage":"","size":2583,"stargazers_count":48,"watchers_count":48,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":119,"mirror_url":null,"open_issues_count":19,"forks":119,"open_issues":19,"watchers":48,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/theforeman/puppet-foreman/pulls/253"},"html":{"href":"https://github.com/theforeman/puppet-foreman/pull/253"},"issue":{"href":"https://api.github.com/repos/theforeman/puppet-foreman/issues/253"},"comments":{"href":"https://api.github.com/repos/theforeman/puppet-foreman/issues/253/comments"},"review_comments":{"href":"https://api.github.com/repos/theforeman/puppet-foreman/pulls/253/comments"},"review_comment":{"href":"https://api.github.com/repos/theforeman/puppet-foreman/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/theforeman/puppet-foreman/pulls/253/commits"},"statuses":{"href":"https://api.github.com/repos/theforeman/puppet-foreman/statuses/fdf0f0fa6abcfa864f9095990890254939141c91"}}}}