{"action":"created","issue":{"url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/issues/1936","labels_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/issues/1936/labels{/name}","comments_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/issues/1936/comments","events_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/issues/1936/events","html_url":"https://github.com/AppliedEnergistics/Applied-Energistics-2/pull/1936","id":110459114,"number":1936,"title":"Make all fields private and creates necessary getters/setters","user":{"login":"yueh","id":151949,"avatar_url":"https://avatars.githubusercontent.com/u/151949?v=3","gravatar_id":"","url":"https://api.github.com/users/yueh","html_url":"https://github.com/yueh","followers_url":"https://api.github.com/users/yueh/followers","following_url":"https://api.github.com/users/yueh/following{/other_user}","gists_url":"https://api.github.com/users/yueh/gists{/gist_id}","starred_url":"https://api.github.com/users/yueh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yueh/subscriptions","organizations_url":"https://api.github.com/users/yueh/orgs","repos_url":"https://api.github.com/users/yueh/repos","events_url":"https://api.github.com/users/yueh/events{/privacy}","received_events_url":"https://api.github.com/users/yueh/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-10-08T14:08:08Z","updated_at":"2015-10-19T14:06:01Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/pulls/1936","html_url":"https://github.com/AppliedEnergistics/Applied-Energistics-2/pull/1936","diff_url":"https://github.com/AppliedEnergistics/Applied-Energistics-2/pull/1936.diff","patch_url":"https://github.com/AppliedEnergistics/Applied-Energistics-2/pull/1936.patch"},"body":"This makes every field private and creates a getter/setter  for it when actually necessary.\r\nThe only exceptions are currently any field with `@GuiSync` as they will not be synchronized when not public.\r\n\r\nThis will probably create a ton of issues regarding unused fields now.."},"comment":{"url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/issues/comments/149222880","html_url":"https://github.com/AppliedEnergistics/Applied-Energistics-2/pull/1936#issuecomment-149222880","issue_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/issues/1936","id":149222880,"user":{"login":"orod-org","id":14347709,"avatar_url":"https://avatars.githubusercontent.com/u/14347709?v=3","gravatar_id":"","url":"https://api.github.com/users/orod-org","html_url":"https://github.com/orod-org","followers_url":"https://api.github.com/users/orod-org/followers","following_url":"https://api.github.com/users/orod-org/following{/other_user}","gists_url":"https://api.github.com/users/orod-org/gists{/gist_id}","starred_url":"https://api.github.com/users/orod-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orod-org/subscriptions","organizations_url":"https://api.github.com/users/orod-org/orgs","repos_url":"https://api.github.com/users/orod-org/repos","events_url":"https://api.github.com/users/orod-org/events{/privacy}","received_events_url":"https://api.github.com/users/orod-org/received_events","type":"User","site_admin":false},"created_at":"2015-10-19T14:06:01Z","updated_at":"2015-10-19T14:06:01Z","body":"SonarQube analysis reported 13 issues:\n* ![MAJOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-major.png) 12 major\n* ![MINOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-minor.png) 1 minor\n\nWatch the comments in this conversation to review them.\nNote: the following issues could not be reported as comments because they are located on lines that are not displayed in this pull request:\n* ![MAJOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-major.png) [Remove this unused \"max\" private field.](https://github.com/AppliedEnergistics/Applied-Energistics-2/blob/6ee176b9e73e6ecc76ac0675013e0e106bfb7e1e/src/main/java/appeng/me/cluster/implementations/QuantumCluster.java#L52) [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](http://nemo.sonarqube.org/coding_rules#rule_key=squid%3AS1068)\n* ![MAJOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-major.png) [Remove this unused \"min\" private field.](https://github.com/AppliedEnergistics/Applied-Energistics-2/blob/6ee176b9e73e6ecc76ac0675013e0e106bfb7e1e/src/main/java/appeng/me/cluster/implementations/QuantumCluster.java#L51) [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](http://nemo.sonarqube.org/coding_rules#rule_key=squid%3AS1068)\n* ![MAJOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-major.png) [The type of the \"connections\" object should be an interface such as \"Set\" rather than the implementation \"EnumSet\".](https://github.com/AppliedEnergistics/Applied-Energistics-2/blob/6ee176b9e73e6ecc76ac0675013e0e106bfb7e1e/src/main/java/appeng/parts/networking/PartCable.java#L1072) [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](http://nemo.sonarqube.org/coding_rules#rule_key=squid%3AS1319)\n* ![MAJOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-major.png) [The return type of this method should be an interface such as \"Set\" rather than the implementation \"EnumSet\".](https://github.com/AppliedEnergistics/Applied-Energistics-2/blob/6ee176b9e73e6ecc76ac0675013e0e106bfb7e1e/src/main/java/appeng/parts/networking/PartCable.java#L1067) [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](http://nemo.sonarqube.org/coding_rules#rule_key=squid%3AS1319)\n"}}