{"action":"closed","number":207,"pull_request":{"url":"https://api.github.com/repos/asm-products/cloudroutes-service/pulls/207","id":28442123,"html_url":"https://github.com/asm-products/cloudroutes-service/pull/207","diff_url":"https://github.com/asm-products/cloudroutes-service/pull/207.diff","patch_url":"https://github.com/asm-products/cloudroutes-service/pull/207.patch","issue_url":"https://api.github.com/repos/asm-products/cloudroutes-service/issues/207","number":207,"state":"closed","locked":false,"title":"BaseReaction class for writing reactions","user":{"login":"Sanrag","id":194580,"avatar_url":"https://avatars.githubusercontent.com/u/194580?v=3","gravatar_id":"","url":"https://api.github.com/users/Sanrag","html_url":"https://github.com/Sanrag","followers_url":"https://api.github.com/users/Sanrag/followers","following_url":"https://api.github.com/users/Sanrag/following{/other_user}","gists_url":"https://api.github.com/users/Sanrag/gists{/gist_id}","starred_url":"https://api.github.com/users/Sanrag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sanrag/subscriptions","organizations_url":"https://api.github.com/users/Sanrag/orgs","repos_url":"https://api.github.com/users/Sanrag/repos","events_url":"https://api.github.com/users/Sanrag/events{/privacy}","received_events_url":"https://api.github.com/users/Sanrag/received_events","type":"User","site_admin":false},"body":"New reactions can simply subclass it and override the _Action method to\r\nwrite the business logic of the reaction. Other surrounding logic like\r\nwhether to run the reaction or not or error handling etc. are taken\r\ncare of by the base class.\r\n\r\nObvious benefits include that by making the BaseReaction class more\r\nrobust over the time, all other reactions also become more robust.\r\nFurthermore, similar reactions like AmazonEC2 reactions can have an\r\nintermediate subclass which can encapsulate EC2 specific logic.\r\n\r\nMigrated Twilio SMS notification reaction to the new style as a proof\r\nof concept.","created_at":"2015-02-02T02:36:51Z","updated_at":"2015-02-07T17:41:40Z","closed_at":"2015-02-07T17:41:40Z","merged_at":null,"merge_commit_sha":"dcf70352bb4ac4ff2534f64477b87fc518bfadc3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/asm-products/cloudroutes-service/pulls/207/commits","review_comments_url":"https://api.github.com/repos/asm-products/cloudroutes-service/pulls/207/comments","review_comment_url":"https://api.github.com/repos/asm-products/cloudroutes-service/pulls/comments/{number}","comments_url":"https://api.github.com/repos/asm-products/cloudroutes-service/issues/207/comments","statuses_url":"https://api.github.com/repos/asm-products/cloudroutes-service/statuses/bc0a7c73db609913bfd1dcb521f37f3adac40679","head":{"label":"Sanrag:reaction","ref":"reaction","sha":"bc0a7c73db609913bfd1dcb521f37f3adac40679","user":{"login":"Sanrag","id":194580,"avatar_url":"https://avatars.githubusercontent.com/u/194580?v=3","gravatar_id":"","url":"https://api.github.com/users/Sanrag","html_url":"https://github.com/Sanrag","followers_url":"https://api.github.com/users/Sanrag/followers","following_url":"https://api.github.com/users/Sanrag/following{/other_user}","gists_url":"https://api.github.com/users/Sanrag/gists{/gist_id}","starred_url":"https://api.github.com/users/Sanrag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sanrag/subscriptions","organizations_url":"https://api.github.com/users/Sanrag/orgs","repos_url":"https://api.github.com/users/Sanrag/repos","events_url":"https://api.github.com/users/Sanrag/events{/privacy}","received_events_url":"https://api.github.com/users/Sanrag/received_events","type":"User","site_admin":false},"repo":{"id":27798652,"name":"cloudroutes-service","full_name":"Sanrag/cloudroutes-service","owner":{"login":"Sanrag","id":194580,"avatar_url":"https://avatars.githubusercontent.com/u/194580?v=3","gravatar_id":"","url":"https://api.github.com/users/Sanrag","html_url":"https://github.com/Sanrag","followers_url":"https://api.github.com/users/Sanrag/followers","following_url":"https://api.github.com/users/Sanrag/following{/other_user}","gists_url":"https://api.github.com/users/Sanrag/gists{/gist_id}","starred_url":"https://api.github.com/users/Sanrag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sanrag/subscriptions","organizations_url":"https://api.github.com/users/Sanrag/orgs","repos_url":"https://api.github.com/users/Sanrag/repos","events_url":"https://api.github.com/users/Sanrag/events{/privacy}","received_events_url":"https://api.github.com/users/Sanrag/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Sanrag/cloudroutes-service","description":"Monitor and automatically resolve issues for applications and infrastructure.","fork":true,"url":"https://api.github.com/repos/Sanrag/cloudroutes-service","forks_url":"https://api.github.com/repos/Sanrag/cloudroutes-service/forks","keys_url":"https://api.github.com/repos/Sanrag/cloudroutes-service/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Sanrag/cloudroutes-service/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Sanrag/cloudroutes-service/teams","hooks_url":"https://api.github.com/repos/Sanrag/cloudroutes-service/hooks","issue_events_url":"https://api.github.com/repos/Sanrag/cloudroutes-service/issues/events{/number}","events_url":"https://api.github.com/repos/Sanrag/cloudroutes-service/events","assignees_url":"https://api.github.com/repos/Sanrag/cloudroutes-service/assignees{/user}","branches_url":"https://api.github.com/repos/Sanrag/cloudroutes-service/branches{/branch}","tags_url":"https://api.github.com/repos/Sanrag/cloudroutes-service/tags","blobs_url":"https://api.github.com/repos/Sanrag/cloudroutes-service/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Sanrag/cloudroutes-service/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Sanrag/cloudroutes-service/git/refs{/sha}","trees_url":"https://api.github.com/repos/Sanrag/cloudroutes-service/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Sanrag/cloudroutes-service/statuses/{sha}","languages_url":"https://api.github.com/repos/Sanrag/cloudroutes-service/languages","stargazers_url":"https://api.github.com/repos/Sanrag/cloudroutes-service/stargazers","contributors_url":"https://api.github.com/repos/Sanrag/cloudroutes-service/contributors","subscribers_url":"https://api.github.com/repos/Sanrag/cloudroutes-service/subscribers","subscription_url":"https://api.github.com/repos/Sanrag/cloudroutes-service/subscription","commits_url":"https://api.github.com/repos/Sanrag/cloudroutes-service/commits{/sha}","git_commits_url":"https://api.github.com/repos/Sanrag/cloudroutes-service/git/commits{/sha}","comments_url":"https://api.github.com/repos/Sanrag/cloudroutes-service/comments{/number}","issue_comment_url":"https://api.github.com/repos/Sanrag/cloudroutes-service/issues/comments/{number}","contents_url":"https://api.github.com/repos/Sanrag/cloudroutes-service/contents/{+path}","compare_url":"https://api.github.com/repos/Sanrag/cloudroutes-service/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Sanrag/cloudroutes-service/merges","archive_url":"https://api.github.com/repos/Sanrag/cloudroutes-service/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Sanrag/cloudroutes-service/downloads","issues_url":"https://api.github.com/repos/Sanrag/cloudroutes-service/issues{/number}","pulls_url":"https://api.github.com/repos/Sanrag/cloudroutes-service/pulls{/number}","milestones_url":"https://api.github.com/repos/Sanrag/cloudroutes-service/milestones{/number}","notifications_url":"https://api.github.com/repos/Sanrag/cloudroutes-service/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Sanrag/cloudroutes-service/labels{/name}","releases_url":"https://api.github.com/repos/Sanrag/cloudroutes-service/releases{/id}","created_at":"2014-12-10T02:33:49Z","updated_at":"2015-01-27T06:00:37Z","pushed_at":"2015-02-02T02:35:52Z","git_url":"git://github.com/Sanrag/cloudroutes-service.git","ssh_url":"git@github.com:Sanrag/cloudroutes-service.git","clone_url":"https://github.com/Sanrag/cloudroutes-service.git","svn_url":"https://github.com/Sanrag/cloudroutes-service","homepage":"https://assembly.com/runbook","size":38428,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"asm-products:develop","ref":"develop","sha":"d64085edd6eb0122822825b687cc7128c38b4d91","user":{"login":"asm-products","id":6548361,"avatar_url":"https://avatars.githubusercontent.com/u/6548361?v=3","gravatar_id":"","url":"https://api.github.com/users/asm-products","html_url":"https://github.com/asm-products","followers_url":"https://api.github.com/users/asm-products/followers","following_url":"https://api.github.com/users/asm-products/following{/other_user}","gists_url":"https://api.github.com/users/asm-products/gists{/gist_id}","starred_url":"https://api.github.com/users/asm-products/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asm-products/subscriptions","organizations_url":"https://api.github.com/users/asm-products/orgs","repos_url":"https://api.github.com/users/asm-products/repos","events_url":"https://api.github.com/users/asm-products/events{/privacy}","received_events_url":"https://api.github.com/users/asm-products/received_events","type":"Organization","site_admin":false},"repo":{"id":24500947,"name":"cloudroutes-service","full_name":"asm-products/cloudroutes-service","owner":{"login":"asm-products","id":6548361,"avatar_url":"https://avatars.githubusercontent.com/u/6548361?v=3","gravatar_id":"","url":"https://api.github.com/users/asm-products","html_url":"https://github.com/asm-products","followers_url":"https://api.github.com/users/asm-products/followers","following_url":"https://api.github.com/users/asm-products/following{/other_user}","gists_url":"https://api.github.com/users/asm-products/gists{/gist_id}","starred_url":"https://api.github.com/users/asm-products/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asm-products/subscriptions","organizations_url":"https://api.github.com/users/asm-products/orgs","repos_url":"https://api.github.com/users/asm-products/repos","events_url":"https://api.github.com/users/asm-products/events{/privacy}","received_events_url":"https://api.github.com/users/asm-products/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/asm-products/cloudroutes-service","description":"Monitor and automatically resolve issues for applications and infrastructure.","fork":false,"url":"https://api.github.com/repos/asm-products/cloudroutes-service","forks_url":"https://api.github.com/repos/asm-products/cloudroutes-service/forks","keys_url":"https://api.github.com/repos/asm-products/cloudroutes-service/keys{/key_id}","collaborators_url":"https://api.github.com/repos/asm-products/cloudroutes-service/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/asm-products/cloudroutes-service/teams","hooks_url":"https://api.github.com/repos/asm-products/cloudroutes-service/hooks","issue_events_url":"https://api.github.com/repos/asm-products/cloudroutes-service/issues/events{/number}","events_url":"https://api.github.com/repos/asm-products/cloudroutes-service/events","assignees_url":"https://api.github.com/repos/asm-products/cloudroutes-service/assignees{/user}","branches_url":"https://api.github.com/repos/asm-products/cloudroutes-service/branches{/branch}","tags_url":"https://api.github.com/repos/asm-products/cloudroutes-service/tags","blobs_url":"https://api.github.com/repos/asm-products/cloudroutes-service/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/asm-products/cloudroutes-service/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/asm-products/cloudroutes-service/git/refs{/sha}","trees_url":"https://api.github.com/repos/asm-products/cloudroutes-service/git/trees{/sha}","statuses_url":"https://api.github.com/repos/asm-products/cloudroutes-service/statuses/{sha}","languages_url":"https://api.github.com/repos/asm-products/cloudroutes-service/languages","stargazers_url":"https://api.github.com/repos/asm-products/cloudroutes-service/stargazers","contributors_url":"https://api.github.com/repos/asm-products/cloudroutes-service/contributors","subscribers_url":"https://api.github.com/repos/asm-products/cloudroutes-service/subscribers","subscription_url":"https://api.github.com/repos/asm-products/cloudroutes-service/subscription","commits_url":"https://api.github.com/repos/asm-products/cloudroutes-service/commits{/sha}","git_commits_url":"https://api.github.com/repos/asm-products/cloudroutes-service/git/commits{/sha}","comments_url":"https://api.github.com/repos/asm-products/cloudroutes-service/comments{/number}","issue_comment_url":"https://api.github.com/repos/asm-products/cloudroutes-service/issues/comments/{number}","contents_url":"https://api.github.com/repos/asm-products/cloudroutes-service/contents/{+path}","compare_url":"https://api.github.com/repos/asm-products/cloudroutes-service/compare/{base}...{head}","merges_url":"https://api.github.com/repos/asm-products/cloudroutes-service/merges","archive_url":"https://api.github.com/repos/asm-products/cloudroutes-service/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/asm-products/cloudroutes-service/downloads","issues_url":"https://api.github.com/repos/asm-products/cloudroutes-service/issues{/number}","pulls_url":"https://api.github.com/repos/asm-products/cloudroutes-service/pulls{/number}","milestones_url":"https://api.github.com/repos/asm-products/cloudroutes-service/milestones{/number}","notifications_url":"https://api.github.com/repos/asm-products/cloudroutes-service/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/asm-products/cloudroutes-service/labels{/name}","releases_url":"https://api.github.com/repos/asm-products/cloudroutes-service/releases{/id}","created_at":"2014-09-26T13:42:09Z","updated_at":"2015-02-04T17:18:30Z","pushed_at":"2015-02-07T16:49:50Z","git_url":"git://github.com/asm-products/cloudroutes-service.git","ssh_url":"git@github.com:asm-products/cloudroutes-service.git","clone_url":"https://github.com/asm-products/cloudroutes-service.git","svn_url":"https://github.com/asm-products/cloudroutes-service","homepage":"https://assembly.com/runbook","size":41568,"stargazers_count":44,"watchers_count":44,"language":"Python","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":20,"mirror_url":null,"open_issues_count":4,"forks":20,"open_issues":4,"watchers":44,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/asm-products/cloudroutes-service/pulls/207"},"html":{"href":"https://github.com/asm-products/cloudroutes-service/pull/207"},"issue":{"href":"https://api.github.com/repos/asm-products/cloudroutes-service/issues/207"},"comments":{"href":"https://api.github.com/repos/asm-products/cloudroutes-service/issues/207/comments"},"review_comments":{"href":"https://api.github.com/repos/asm-products/cloudroutes-service/pulls/207/comments"},"review_comment":{"href":"https://api.github.com/repos/asm-products/cloudroutes-service/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/asm-products/cloudroutes-service/pulls/207/commits"},"statuses":{"href":"https://api.github.com/repos/asm-products/cloudroutes-service/statuses/bc0a7c73db609913bfd1dcb521f37f3adac40679"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":1,"review_comments":0,"commits":1,"additions":122,"deletions":37,"changed_files":3}}