{"action":"created","issue":{"url":"https://api.github.com/repos/SiCKRAGETV/sickrage-issues/issues/2774","labels_url":"https://api.github.com/repos/SiCKRAGETV/sickrage-issues/issues/2774/labels{/name}","comments_url":"https://api.github.com/repos/SiCKRAGETV/sickrage-issues/issues/2774/comments","events_url":"https://api.github.com/repos/SiCKRAGETV/sickrage-issues/issues/2774/events","html_url":"https://github.com/SiCKRAGETV/sickrage-issues/issues/2774","id":106145889,"number":2774,"title":"Embedded subtitles not detected","user":{"login":"NicoLeOca","id":9487685,"avatar_url":"https://avatars.githubusercontent.com/u/9487685?v=3","gravatar_id":"","url":"https://api.github.com/users/NicoLeOca","html_url":"https://github.com/NicoLeOca","followers_url":"https://api.github.com/users/NicoLeOca/followers","following_url":"https://api.github.com/users/NicoLeOca/following{/other_user}","gists_url":"https://api.github.com/users/NicoLeOca/gists{/gist_id}","starred_url":"https://api.github.com/users/NicoLeOca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NicoLeOca/subscriptions","organizations_url":"https://api.github.com/users/NicoLeOca/orgs","repos_url":"https://api.github.com/users/NicoLeOca/repos","events_url":"https://api.github.com/users/NicoLeOca/events{/privacy}","received_events_url":"https://api.github.com/users/NicoLeOca/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/SiCKRAGETV/sickrage-issues/labels/1:%20Bug%20/%20issue","name":"1: Bug / issue","color":"fc2929"},{"url":"https://api.github.com/repos/SiCKRAGETV/sickrage-issues/labels/2:%20Low%20Priority","name":"2: Low Priority","color":"d4c5f9"},{"url":"https://api.github.com/repos/SiCKRAGETV/sickrage-issues/labels/4:%20Fix%20pending","name":"4: Fix pending","color":"bfe5bf"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":21,"created_at":"2015-09-12T10:20:02Z","updated_at":"2015-09-14T12:48:39Z","closed_at":null,"body":"Hi,\r\nCan you please investigate and let me know what's wrong?\r\n\r\nBranch : master\r\nCommit hash : 37914618686ee70479da0fa4b2cca851fa49c5e2 (Sr is uptodate)\r\nYour operating system and python version : Synology DSM with Python 2.7.10\r\n\r\nWhat you did:\r\nmanually added a couple of media\r\n\r\nWhat happened\r\nfor a few of them, embedded subtitles were not detected:\r\nThe.Mindy.Project.S03E08.Diary.of.a.Mad.Indian.Woman.720p.WEB-DL.DD5.1.H.264-SA89\r\nThe.Mindy.Project.S03E19.720p.HDTV.x264-IMMERSE\r\nThe.Mindy.Project.S03E20.720p.HDTV.x264-IMMERSE\r\nnone of the subs are forced\r\n\r\nWhat you expected\r\nSR to detect the very subtitles\r\n\r\nLink to a copy/paste of your logfile with clear debug info of the error on GIST:\r\nhttps://gist.github.com/NicoLeOca/c0e4f6acb0260147953c"},"comment":{"url":"https://api.github.com/repos/SiCKRAGETV/sickrage-issues/issues/comments/140060698","html_url":"https://github.com/SiCKRAGETV/sickrage-issues/issues/2774#issuecomment-140060698","issue_url":"https://api.github.com/repos/SiCKRAGETV/sickrage-issues/issues/2774","id":140060698,"user":{"login":"medariox","id":2893509,"avatar_url":"https://avatars.githubusercontent.com/u/2893509?v=3","gravatar_id":"","url":"https://api.github.com/users/medariox","html_url":"https://github.com/medariox","followers_url":"https://api.github.com/users/medariox/followers","following_url":"https://api.github.com/users/medariox/following{/other_user}","gists_url":"https://api.github.com/users/medariox/gists{/gist_id}","starred_url":"https://api.github.com/users/medariox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/medariox/subscriptions","organizations_url":"https://api.github.com/users/medariox/orgs","repos_url":"https://api.github.com/users/medariox/repos","events_url":"https://api.github.com/users/medariox/events{/privacy}","received_events_url":"https://api.github.com/users/medariox/received_events","type":"User","site_admin":false},"created_at":"2015-09-14T12:48:39Z","updated_at":"2015-09-14T12:48:39Z","body":"So, just submitted a PR that fixes the bug.\r\n\r\nA few things that I'd like to clarify:\r\n- Support for embedded subtitles most probably never really worked, as the logic behind it was completely ineffective.\r\n- Some embedded subtitles are not being correctly recognized by subliminal (actually enzyme: https://github.com/Diaoul/enzyme) and will be tagged as \"und\" (undefined), in that case the correct subtitle will be downloaded. There is nothing we can do to solve this, I guess it depends on how the subtitle has been embedded.\r\n- The embedded subtitles can now be effectively ignored (probably never really worked either)"}}