{"action":"created","comment":{"url":"https://api.github.com/repos/artsy/eigen/pulls/comments/28797390","id":28797390,"diff_hunk":"@@ -15,16 +15,30 @@ void _itTestsAsyncronouslyWithDevicesRecording(id self, int lineNumber, const ch\n \n     it([name stringByAppendingString:@\" as iphone\"], ^{\n         [ARTestContext stubDevice:ARDeviceTypePhone5];\n-        id sut = block();\n-        snapshot(sut, @\" as iphone\");\n-        [ARTestContext stopStubbing];\n+        @try {\n+            id sut = block();\n+            snapshot(sut, @\" as iphone\");\n+        }\n+        @catch (NSException *exception) {\n+            EXPFail(self, lineNumber, fileName, [NSString stringWithFormat:@\"'%@' has crashed\", [name stringByAppendingString:@\" as iphone\"]]);","path":"Artsy Tests/ARExpectaExtensions.m","position":12,"original_position":12,"commit_id":"fbe07e82c1b30d24165d67999f1abee74bf016bb","original_commit_id":"fbe07e82c1b30d24165d67999f1abee74bf016bb","user":{"login":"1aurabrown","id":3171662,"avatar_url":"https://avatars.githubusercontent.com/u/3171662?v=3","gravatar_id":"","url":"https://api.github.com/users/1aurabrown","html_url":"https://github.com/1aurabrown","followers_url":"https://api.github.com/users/1aurabrown/followers","following_url":"https://api.github.com/users/1aurabrown/following{/other_user}","gists_url":"https://api.github.com/users/1aurabrown/gists{/gist_id}","starred_url":"https://api.github.com/users/1aurabrown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/1aurabrown/subscriptions","organizations_url":"https://api.github.com/users/1aurabrown/orgs","repos_url":"https://api.github.com/users/1aurabrown/repos","events_url":"https://api.github.com/users/1aurabrown/events{/privacy}","received_events_url":"https://api.github.com/users/1aurabrown/received_events","type":"User","site_admin":false},"body":"we don't want to catch the exception, because an exception represents a failing test","created_at":"2015-04-21T16:43:48Z","updated_at":"2015-04-21T16:43:48Z","html_url":"https://github.com/artsy/eigen/pull/358#discussion_r28797390","pull_request_url":"https://api.github.com/repos/artsy/eigen/pulls/358","_links":{"self":{"href":"https://api.github.com/repos/artsy/eigen/pulls/comments/28797390"},"html":{"href":"https://github.com/artsy/eigen/pull/358#discussion_r28797390"},"pull_request":{"href":"https://api.github.com/repos/artsy/eigen/pulls/358"}}},"pull_request":{"url":"https://api.github.com/repos/artsy/eigen/pulls/358","id":32906635,"html_url":"https://github.com/artsy/eigen/pull/358","diff_url":"https://github.com/artsy/eigen/pull/358.diff","patch_url":"https://github.com/artsy/eigen/pull/358.patch","issue_url":"https://api.github.com/repos/artsy/eigen/issues/358","number":358,"state":"open","locked":false,"title":"[WIP] Address in show view","user":{"login":"sarahscott","id":2712962,"avatar_url":"https://avatars.githubusercontent.com/u/2712962?v=3","gravatar_id":"","url":"https://api.github.com/users/sarahscott","html_url":"https://github.com/sarahscott","followers_url":"https://api.github.com/users/sarahscott/followers","following_url":"https://api.github.com/users/sarahscott/following{/other_user}","gists_url":"https://api.github.com/users/sarahscott/gists{/gist_id}","starred_url":"https://api.github.com/users/sarahscott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarahscott/subscriptions","organizations_url":"https://api.github.com/users/sarahscott/orgs","repos_url":"https://api.github.com/users/sarahscott/repos","events_url":"https://api.github.com/users/sarahscott/events{/privacy}","received_events_url":"https://api.github.com/users/sarahscott/received_events","type":"User","site_admin":false},"body":"- [x] Changed PartnerShow model to include street address of gallery\r\n- [x] Updated usage of location property elsewhere to instead show the city property\r\n- [x] Added myself to the UIFonts list\r\n- [x] Added officialDescription property to PartnerShow model so show descriptions can be displayed\r\n- [x] Make Location model so I can get rid of my messy PartnerShow methods\r\n- [x] Clean up ShowViewController labels\r\n- [x] Make sure shows in fairs and shows not in fairs display correctly\r\n- [ ] Tests\r\n\r\nFixes #311 ","created_at":"2015-04-08T22:00:37Z","updated_at":"2015-04-21T16:43:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7281bfd07fa1f03364c67afd2484374db143adaf","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/artsy/eigen/pulls/358/commits","review_comments_url":"https://api.github.com/repos/artsy/eigen/pulls/358/comments","review_comment_url":"https://api.github.com/repos/artsy/eigen/pulls/comments{/number}","comments_url":"https://api.github.com/repos/artsy/eigen/issues/358/comments","statuses_url":"https://api.github.com/repos/artsy/eigen/statuses/fbe07e82c1b30d24165d67999f1abee74bf016bb","head":{"label":"sarahscott:address-in-show-view","ref":"address-in-show-view","sha":"fbe07e82c1b30d24165d67999f1abee74bf016bb","user":{"login":"sarahscott","id":2712962,"avatar_url":"https://avatars.githubusercontent.com/u/2712962?v=3","gravatar_id":"","url":"https://api.github.com/users/sarahscott","html_url":"https://github.com/sarahscott","followers_url":"https://api.github.com/users/sarahscott/followers","following_url":"https://api.github.com/users/sarahscott/following{/other_user}","gists_url":"https://api.github.com/users/sarahscott/gists{/gist_id}","starred_url":"https://api.github.com/users/sarahscott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarahscott/subscriptions","organizations_url":"https://api.github.com/users/sarahscott/orgs","repos_url":"https://api.github.com/users/sarahscott/repos","events_url":"https://api.github.com/users/sarahscott/events{/privacy}","received_events_url":"https://api.github.com/users/sarahscott/received_events","type":"User","site_admin":false},"repo":{"id":33563307,"name":"eigen","full_name":"sarahscott/eigen","owner":{"login":"sarahscott","id":2712962,"avatar_url":"https://avatars.githubusercontent.com/u/2712962?v=3","gravatar_id":"","url":"https://api.github.com/users/sarahscott","html_url":"https://github.com/sarahscott","followers_url":"https://api.github.com/users/sarahscott/followers","following_url":"https://api.github.com/users/sarahscott/following{/other_user}","gists_url":"https://api.github.com/users/sarahscott/gists{/gist_id}","starred_url":"https://api.github.com/users/sarahscott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarahscott/subscriptions","organizations_url":"https://api.github.com/users/sarahscott/orgs","repos_url":"https://api.github.com/users/sarahscott/repos","events_url":"https://api.github.com/users/sarahscott/events{/privacy}","received_events_url":"https://api.github.com/users/sarahscott/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sarahscott/eigen","description":"The Art World in Your Pocket, Artsy's iOS app.","fork":true,"url":"https://api.github.com/repos/sarahscott/eigen","forks_url":"https://api.github.com/repos/sarahscott/eigen/forks","keys_url":"https://api.github.com/repos/sarahscott/eigen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sarahscott/eigen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sarahscott/eigen/teams","hooks_url":"https://api.github.com/repos/sarahscott/eigen/hooks","issue_events_url":"https://api.github.com/repos/sarahscott/eigen/issues/events{/number}","events_url":"https://api.github.com/repos/sarahscott/eigen/events","assignees_url":"https://api.github.com/repos/sarahscott/eigen/assignees{/user}","branches_url":"https://api.github.com/repos/sarahscott/eigen/branches{/branch}","tags_url":"https://api.github.com/repos/sarahscott/eigen/tags","blobs_url":"https://api.github.com/repos/sarahscott/eigen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sarahscott/eigen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sarahscott/eigen/git/refs{/sha}","trees_url":"https://api.github.com/repos/sarahscott/eigen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sarahscott/eigen/statuses/{sha}","languages_url":"https://api.github.com/repos/sarahscott/eigen/languages","stargazers_url":"https://api.github.com/repos/sarahscott/eigen/stargazers","contributors_url":"https://api.github.com/repos/sarahscott/eigen/contributors","subscribers_url":"https://api.github.com/repos/sarahscott/eigen/subscribers","subscription_url":"https://api.github.com/repos/sarahscott/eigen/subscription","commits_url":"https://api.github.com/repos/sarahscott/eigen/commits{/sha}","git_commits_url":"https://api.github.com/repos/sarahscott/eigen/git/commits{/sha}","comments_url":"https://api.github.com/repos/sarahscott/eigen/comments{/number}","issue_comment_url":"https://api.github.com/repos/sarahscott/eigen/issues/comments{/number}","contents_url":"https://api.github.com/repos/sarahscott/eigen/contents/{+path}","compare_url":"https://api.github.com/repos/sarahscott/eigen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sarahscott/eigen/merges","archive_url":"https://api.github.com/repos/sarahscott/eigen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sarahscott/eigen/downloads","issues_url":"https://api.github.com/repos/sarahscott/eigen/issues{/number}","pulls_url":"https://api.github.com/repos/sarahscott/eigen/pulls{/number}","milestones_url":"https://api.github.com/repos/sarahscott/eigen/milestones{/number}","notifications_url":"https://api.github.com/repos/sarahscott/eigen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sarahscott/eigen/labels{/name}","releases_url":"https://api.github.com/repos/sarahscott/eigen/releases{/id}","created_at":"2015-04-07T19:20:49Z","updated_at":"2015-04-15T17:46:24Z","pushed_at":"2015-04-15T17:46:24Z","git_url":"git://github.com/sarahscott/eigen.git","ssh_url":"git@github.com:sarahscott/eigen.git","clone_url":"https://github.com/sarahscott/eigen.git","svn_url":"https://github.com/sarahscott/eigen","homepage":"http://iphone.artsy.net","size":38849,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"artsy:master","ref":"master","sha":"d6a4ed3961c7fef2f7db8ad41d6fbc6b8bd97146","user":{"login":"artsy","id":546231,"avatar_url":"https://avatars.githubusercontent.com/u/546231?v=3","gravatar_id":"","url":"https://api.github.com/users/artsy","html_url":"https://github.com/artsy","followers_url":"https://api.github.com/users/artsy/followers","following_url":"https://api.github.com/users/artsy/following{/other_user}","gists_url":"https://api.github.com/users/artsy/gists{/gist_id}","starred_url":"https://api.github.com/users/artsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artsy/subscriptions","organizations_url":"https://api.github.com/users/artsy/orgs","repos_url":"https://api.github.com/users/artsy/repos","events_url":"https://api.github.com/users/artsy/events{/privacy}","received_events_url":"https://api.github.com/users/artsy/received_events","type":"Organization","site_admin":false},"repo":{"id":29702213,"name":"eigen","full_name":"artsy/eigen","owner":{"login":"artsy","id":546231,"avatar_url":"https://avatars.githubusercontent.com/u/546231?v=3","gravatar_id":"","url":"https://api.github.com/users/artsy","html_url":"https://github.com/artsy","followers_url":"https://api.github.com/users/artsy/followers","following_url":"https://api.github.com/users/artsy/following{/other_user}","gists_url":"https://api.github.com/users/artsy/gists{/gist_id}","starred_url":"https://api.github.com/users/artsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artsy/subscriptions","organizations_url":"https://api.github.com/users/artsy/orgs","repos_url":"https://api.github.com/users/artsy/repos","events_url":"https://api.github.com/users/artsy/events{/privacy}","received_events_url":"https://api.github.com/users/artsy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/artsy/eigen","description":"The Art World in Your Pocket, Artsy's iOS app.","fork":false,"url":"https://api.github.com/repos/artsy/eigen","forks_url":"https://api.github.com/repos/artsy/eigen/forks","keys_url":"https://api.github.com/repos/artsy/eigen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/artsy/eigen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/artsy/eigen/teams","hooks_url":"https://api.github.com/repos/artsy/eigen/hooks","issue_events_url":"https://api.github.com/repos/artsy/eigen/issues/events{/number}","events_url":"https://api.github.com/repos/artsy/eigen/events","assignees_url":"https://api.github.com/repos/artsy/eigen/assignees{/user}","branches_url":"https://api.github.com/repos/artsy/eigen/branches{/branch}","tags_url":"https://api.github.com/repos/artsy/eigen/tags","blobs_url":"https://api.github.com/repos/artsy/eigen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/artsy/eigen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/artsy/eigen/git/refs{/sha}","trees_url":"https://api.github.com/repos/artsy/eigen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/artsy/eigen/statuses/{sha}","languages_url":"https://api.github.com/repos/artsy/eigen/languages","stargazers_url":"https://api.github.com/repos/artsy/eigen/stargazers","contributors_url":"https://api.github.com/repos/artsy/eigen/contributors","subscribers_url":"https://api.github.com/repos/artsy/eigen/subscribers","subscription_url":"https://api.github.com/repos/artsy/eigen/subscription","commits_url":"https://api.github.com/repos/artsy/eigen/commits{/sha}","git_commits_url":"https://api.github.com/repos/artsy/eigen/git/commits{/sha}","comments_url":"https://api.github.com/repos/artsy/eigen/comments{/number}","issue_comment_url":"https://api.github.com/repos/artsy/eigen/issues/comments{/number}","contents_url":"https://api.github.com/repos/artsy/eigen/contents/{+path}","compare_url":"https://api.github.com/repos/artsy/eigen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/artsy/eigen/merges","archive_url":"https://api.github.com/repos/artsy/eigen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/artsy/eigen/downloads","issues_url":"https://api.github.com/repos/artsy/eigen/issues{/number}","pulls_url":"https://api.github.com/repos/artsy/eigen/pulls{/number}","milestones_url":"https://api.github.com/repos/artsy/eigen/milestones{/number}","notifications_url":"https://api.github.com/repos/artsy/eigen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/artsy/eigen/labels{/name}","releases_url":"https://api.github.com/repos/artsy/eigen/releases{/id}","created_at":"2015-01-22T21:52:39Z","updated_at":"2015-04-21T09:26:56Z","pushed_at":"2015-04-17T22:28:53Z","git_url":"git://github.com/artsy/eigen.git","ssh_url":"git@github.com:artsy/eigen.git","clone_url":"https://github.com/artsy/eigen.git","svn_url":"https://github.com/artsy/eigen","homepage":"http://iphone.artsy.net","size":42310,"stargazers_count":623,"watchers_count":623,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":76,"mirror_url":null,"open_issues_count":107,"forks":76,"open_issues":107,"watchers":623,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/artsy/eigen/pulls/358"},"html":{"href":"https://github.com/artsy/eigen/pull/358"},"issue":{"href":"https://api.github.com/repos/artsy/eigen/issues/358"},"comments":{"href":"https://api.github.com/repos/artsy/eigen/issues/358/comments"},"review_comments":{"href":"https://api.github.com/repos/artsy/eigen/pulls/358/comments"},"review_comment":{"href":"https://api.github.com/repos/artsy/eigen/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/artsy/eigen/pulls/358/commits"},"statuses":{"href":"https://api.github.com/repos/artsy/eigen/statuses/fbe07e82c1b30d24165d67999f1abee74bf016bb"}}}}