{"action":"created","comment":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments/43143367","id":43143367,"diff_hunk":"@@ -71,8 +72,8 @@ void _fini(void)\n  */\n void _exit(int n)\n {\n-    printf(\"#! exit %i: resetting\\n\", n);\n-    reboot(n);\n+    LOG_INFO(\"#! exit %i: resetting\\n\", n);","path":"sys/newlib/syscalls.c","position":17,"original_position":17,"commit_id":"011a6e14bf25f45a0409556f73b0256e46379987","original_commit_id":"011a6e14bf25f45a0409556f73b0256e46379987","user":{"login":"OlegHahm","id":1590423,"avatar_url":"https://avatars.githubusercontent.com/u/1590423?v=3","gravatar_id":"","url":"https://api.github.com/users/OlegHahm","html_url":"https://github.com/OlegHahm","followers_url":"https://api.github.com/users/OlegHahm/followers","following_url":"https://api.github.com/users/OlegHahm/following{/other_user}","gists_url":"https://api.github.com/users/OlegHahm/gists{/gist_id}","starred_url":"https://api.github.com/users/OlegHahm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OlegHahm/subscriptions","organizations_url":"https://api.github.com/users/OlegHahm/orgs","repos_url":"https://api.github.com/users/OlegHahm/repos","events_url":"https://api.github.com/users/OlegHahm/events{/privacy}","received_events_url":"https://api.github.com/users/OlegHahm/received_events","type":"User","site_admin":false},"body":"Isn't this message likely to get cut if logging to UART because of the removed delay loop?","created_at":"2015-10-27T16:05:04Z","updated_at":"2015-10-27T16:05:04Z","html_url":"https://github.com/RIOT-OS/RIOT/pull/3984#discussion_r43143367","pull_request_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/3984","_links":{"self":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments/43143367"},"html":{"href":"https://github.com/RIOT-OS/RIOT/pull/3984#discussion_r43143367"},"pull_request":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/3984"}}},"pull_request":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/3984","id":46266903,"html_url":"https://github.com/RIOT-OS/RIOT/pull/3984","diff_url":"https://github.com/RIOT-OS/RIOT/pull/3984.diff","patch_url":"https://github.com/RIOT-OS/RIOT/pull/3984.patch","issue_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/3984","number":3984,"state":"open","locked":false,"title":"core: cpu: sys: simplify reboot()","user":{"login":"kaspar030","id":4679640,"avatar_url":"https://avatars.githubusercontent.com/u/4679640?v=3","gravatar_id":"","url":"https://api.github.com/users/kaspar030","html_url":"https://github.com/kaspar030","followers_url":"https://api.github.com/users/kaspar030/followers","following_url":"https://api.github.com/users/kaspar030/following{/other_user}","gists_url":"https://api.github.com/users/kaspar030/gists{/gist_id}","starred_url":"https://api.github.com/users/kaspar030/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaspar030/subscriptions","organizations_url":"https://api.github.com/users/kaspar030/orgs","repos_url":"https://api.github.com/users/kaspar030/repos","events_url":"https://api.github.com/users/kaspar030/events{/privacy}","received_events_url":"https://api.github.com/users/kaspar030/received_events","type":"User","site_admin":false},"body":"This PR changes the signature of reboot to ```void reboot(void)```\r\n\r\n- reboot() returning a value is a bug\r\n- reboot()'s mode parameter was unused\r\n\r\n(also changes _exit printf to \"LOG_INFO\")","created_at":"2015-09-29T11:48:34Z","updated_at":"2015-10-27T16:05:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6288e094dd6cb7e2135f5f06b8ba084f3f81e245","assignee":{"login":"gebart","id":317506,"avatar_url":"https://avatars.githubusercontent.com/u/317506?v=3","gravatar_id":"","url":"https://api.github.com/users/gebart","html_url":"https://github.com/gebart","followers_url":"https://api.github.com/users/gebart/followers","following_url":"https://api.github.com/users/gebart/following{/other_user}","gists_url":"https://api.github.com/users/gebart/gists{/gist_id}","starred_url":"https://api.github.com/users/gebart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gebart/subscriptions","organizations_url":"https://api.github.com/users/gebart/orgs","repos_url":"https://api.github.com/users/gebart/repos","events_url":"https://api.github.com/users/gebart/events{/privacy}","received_events_url":"https://api.github.com/users/gebart/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/3984/commits","review_comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/3984/comments","review_comment_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/3984/comments","statuses_url":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/011a6e14bf25f45a0409556f73b0256e46379987","head":{"label":"kaspar030:simplify_reboot","ref":"simplify_reboot","sha":"011a6e14bf25f45a0409556f73b0256e46379987","user":{"login":"kaspar030","id":4679640,"avatar_url":"https://avatars.githubusercontent.com/u/4679640?v=3","gravatar_id":"","url":"https://api.github.com/users/kaspar030","html_url":"https://github.com/kaspar030","followers_url":"https://api.github.com/users/kaspar030/followers","following_url":"https://api.github.com/users/kaspar030/following{/other_user}","gists_url":"https://api.github.com/users/kaspar030/gists{/gist_id}","starred_url":"https://api.github.com/users/kaspar030/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaspar030/subscriptions","organizations_url":"https://api.github.com/users/kaspar030/orgs","repos_url":"https://api.github.com/users/kaspar030/repos","events_url":"https://api.github.com/users/kaspar030/events{/privacy}","received_events_url":"https://api.github.com/users/kaspar030/received_events","type":"User","site_admin":false},"repo":{"id":14115364,"name":"RIOT","full_name":"kaspar030/RIOT","owner":{"login":"kaspar030","id":4679640,"avatar_url":"https://avatars.githubusercontent.com/u/4679640?v=3","gravatar_id":"","url":"https://api.github.com/users/kaspar030","html_url":"https://github.com/kaspar030","followers_url":"https://api.github.com/users/kaspar030/followers","following_url":"https://api.github.com/users/kaspar030/following{/other_user}","gists_url":"https://api.github.com/users/kaspar030/gists{/gist_id}","starred_url":"https://api.github.com/users/kaspar030/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaspar030/subscriptions","organizations_url":"https://api.github.com/users/kaspar030/orgs","repos_url":"https://api.github.com/users/kaspar030/repos","events_url":"https://api.github.com/users/kaspar030/events{/privacy}","received_events_url":"https://api.github.com/users/kaspar030/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kaspar030/RIOT","description":"RIOT -  The friendly OS for IoT","fork":true,"url":"https://api.github.com/repos/kaspar030/RIOT","forks_url":"https://api.github.com/repos/kaspar030/RIOT/forks","keys_url":"https://api.github.com/repos/kaspar030/RIOT/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kaspar030/RIOT/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kaspar030/RIOT/teams","hooks_url":"https://api.github.com/repos/kaspar030/RIOT/hooks","issue_events_url":"https://api.github.com/repos/kaspar030/RIOT/issues/events{/number}","events_url":"https://api.github.com/repos/kaspar030/RIOT/events","assignees_url":"https://api.github.com/repos/kaspar030/RIOT/assignees{/user}","branches_url":"https://api.github.com/repos/kaspar030/RIOT/branches{/branch}","tags_url":"https://api.github.com/repos/kaspar030/RIOT/tags","blobs_url":"https://api.github.com/repos/kaspar030/RIOT/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kaspar030/RIOT/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kaspar030/RIOT/git/refs{/sha}","trees_url":"https://api.github.com/repos/kaspar030/RIOT/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kaspar030/RIOT/statuses/{sha}","languages_url":"https://api.github.com/repos/kaspar030/RIOT/languages","stargazers_url":"https://api.github.com/repos/kaspar030/RIOT/stargazers","contributors_url":"https://api.github.com/repos/kaspar030/RIOT/contributors","subscribers_url":"https://api.github.com/repos/kaspar030/RIOT/subscribers","subscription_url":"https://api.github.com/repos/kaspar030/RIOT/subscription","commits_url":"https://api.github.com/repos/kaspar030/RIOT/commits{/sha}","git_commits_url":"https://api.github.com/repos/kaspar030/RIOT/git/commits{/sha}","comments_url":"https://api.github.com/repos/kaspar030/RIOT/comments{/number}","issue_comment_url":"https://api.github.com/repos/kaspar030/RIOT/issues/comments{/number}","contents_url":"https://api.github.com/repos/kaspar030/RIOT/contents/{+path}","compare_url":"https://api.github.com/repos/kaspar030/RIOT/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kaspar030/RIOT/merges","archive_url":"https://api.github.com/repos/kaspar030/RIOT/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kaspar030/RIOT/downloads","issues_url":"https://api.github.com/repos/kaspar030/RIOT/issues{/number}","pulls_url":"https://api.github.com/repos/kaspar030/RIOT/pulls{/number}","milestones_url":"https://api.github.com/repos/kaspar030/RIOT/milestones{/number}","notifications_url":"https://api.github.com/repos/kaspar030/RIOT/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kaspar030/RIOT/labels{/name}","releases_url":"https://api.github.com/repos/kaspar030/RIOT/releases{/id}","created_at":"2013-11-04T16:04:12Z","updated_at":"2015-05-08T14:32:24Z","pushed_at":"2015-10-27T15:42:05Z","git_url":"git://github.com/kaspar030/RIOT.git","ssh_url":"git@github.com:kaspar030/RIOT.git","clone_url":"https://github.com/kaspar030/RIOT.git","svn_url":"https://github.com/kaspar030/RIOT","homepage":"https://github.com/RIOT-OS/RIOT/wiki","size":23850,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"RIOT-OS:master","ref":"master","sha":"c1d9b5e42a036c9a90264a148909fc77b0e71c57","user":{"login":"RIOT-OS","id":3079480,"avatar_url":"https://avatars.githubusercontent.com/u/3079480?v=3","gravatar_id":"","url":"https://api.github.com/users/RIOT-OS","html_url":"https://github.com/RIOT-OS","followers_url":"https://api.github.com/users/RIOT-OS/followers","following_url":"https://api.github.com/users/RIOT-OS/following{/other_user}","gists_url":"https://api.github.com/users/RIOT-OS/gists{/gist_id}","starred_url":"https://api.github.com/users/RIOT-OS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RIOT-OS/subscriptions","organizations_url":"https://api.github.com/users/RIOT-OS/orgs","repos_url":"https://api.github.com/users/RIOT-OS/repos","events_url":"https://api.github.com/users/RIOT-OS/events{/privacy}","received_events_url":"https://api.github.com/users/RIOT-OS/received_events","type":"Organization","site_admin":false},"repo":{"id":7370241,"name":"RIOT","full_name":"RIOT-OS/RIOT","owner":{"login":"RIOT-OS","id":3079480,"avatar_url":"https://avatars.githubusercontent.com/u/3079480?v=3","gravatar_id":"","url":"https://api.github.com/users/RIOT-OS","html_url":"https://github.com/RIOT-OS","followers_url":"https://api.github.com/users/RIOT-OS/followers","following_url":"https://api.github.com/users/RIOT-OS/following{/other_user}","gists_url":"https://api.github.com/users/RIOT-OS/gists{/gist_id}","starred_url":"https://api.github.com/users/RIOT-OS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RIOT-OS/subscriptions","organizations_url":"https://api.github.com/users/RIOT-OS/orgs","repos_url":"https://api.github.com/users/RIOT-OS/repos","events_url":"https://api.github.com/users/RIOT-OS/events{/privacy}","received_events_url":"https://api.github.com/users/RIOT-OS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RIOT-OS/RIOT","description":"RIOT -  The friendly OS for IoT","fork":false,"url":"https://api.github.com/repos/RIOT-OS/RIOT","forks_url":"https://api.github.com/repos/RIOT-OS/RIOT/forks","keys_url":"https://api.github.com/repos/RIOT-OS/RIOT/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RIOT-OS/RIOT/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RIOT-OS/RIOT/teams","hooks_url":"https://api.github.com/repos/RIOT-OS/RIOT/hooks","issue_events_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/events{/number}","events_url":"https://api.github.com/repos/RIOT-OS/RIOT/events","assignees_url":"https://api.github.com/repos/RIOT-OS/RIOT/assignees{/user}","branches_url":"https://api.github.com/repos/RIOT-OS/RIOT/branches{/branch}","tags_url":"https://api.github.com/repos/RIOT-OS/RIOT/tags","blobs_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/refs{/sha}","trees_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/{sha}","languages_url":"https://api.github.com/repos/RIOT-OS/RIOT/languages","stargazers_url":"https://api.github.com/repos/RIOT-OS/RIOT/stargazers","contributors_url":"https://api.github.com/repos/RIOT-OS/RIOT/contributors","subscribers_url":"https://api.github.com/repos/RIOT-OS/RIOT/subscribers","subscription_url":"https://api.github.com/repos/RIOT-OS/RIOT/subscription","commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/commits{/sha}","git_commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/commits{/sha}","comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/comments{/number}","issue_comment_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/comments{/number}","contents_url":"https://api.github.com/repos/RIOT-OS/RIOT/contents/{+path}","compare_url":"https://api.github.com/repos/RIOT-OS/RIOT/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RIOT-OS/RIOT/merges","archive_url":"https://api.github.com/repos/RIOT-OS/RIOT/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RIOT-OS/RIOT/downloads","issues_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues{/number}","pulls_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls{/number}","milestones_url":"https://api.github.com/repos/RIOT-OS/RIOT/milestones{/number}","notifications_url":"https://api.github.com/repos/RIOT-OS/RIOT/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RIOT-OS/RIOT/labels{/name}","releases_url":"https://api.github.com/repos/RIOT-OS/RIOT/releases{/id}","created_at":"2012-12-29T20:38:40Z","updated_at":"2015-10-26T06:25:55Z","pushed_at":"2015-10-27T16:02:31Z","git_url":"git://github.com/RIOT-OS/RIOT.git","ssh_url":"git@github.com:RIOT-OS/RIOT.git","clone_url":"https://github.com/RIOT-OS/RIOT.git","svn_url":"https://github.com/RIOT-OS/RIOT","homepage":"https://github.com/RIOT-OS/RIOT/wiki","size":136132,"stargazers_count":535,"watchers_count":535,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":419,"mirror_url":null,"open_issues_count":401,"forks":419,"open_issues":401,"watchers":535,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/3984"},"html":{"href":"https://github.com/RIOT-OS/RIOT/pull/3984"},"issue":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/issues/3984"},"comments":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/issues/3984/comments"},"review_comments":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/3984/comments"},"review_comment":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/3984/commits"},"statuses":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/011a6e14bf25f45a0409556f73b0256e46379987"}}}}