{"action":"created","comment":{"url":"https://api.github.com/repos/NuGet/NuGet3/pulls/comments/38161554","id":38161554,"diff_hunk":"@@ -83,12 +77,12 @@ public ServiceIndexResourceV3Provider()\n \n                         if (credentials == null)\n                         {\n-                            return null;\n+                            response.EnsureSuccessStatusCode();\n                         }\n                     }\n                     else\n                     {\n-                        return null;\n+                        response.EnsureSuccessStatusCode();","path":"src/NuGet.Protocol.Core.v3/ServiceIndexResourceV3Provider.cs","position":46,"original_position":46,"commit_id":"8cbf11a9c0350fa7f21b6462e927149f8a1ac037","original_commit_id":"8cbf11a9c0350fa7f21b6462e927149f8a1ac037","user":{"login":"feiling","id":2679220,"avatar_url":"https://avatars.githubusercontent.com/u/2679220?v=3","gravatar_id":"","url":"https://api.github.com/users/feiling","html_url":"https://github.com/feiling","followers_url":"https://api.github.com/users/feiling/followers","following_url":"https://api.github.com/users/feiling/following{/other_user}","gists_url":"https://api.github.com/users/feiling/gists{/gist_id}","starred_url":"https://api.github.com/users/feiling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feiling/subscriptions","organizations_url":"https://api.github.com/users/feiling/orgs","repos_url":"https://api.github.com/users/feiling/repos","events_url":"https://api.github.com/users/feiling/events{/privacy}","received_events_url":"https://api.github.com/users/feiling/received_events","type":"User","site_admin":false},"body":"This, plus the previous EnsureSuccessStatusCode(), makes sure that this method returns only when Index.Json is successfully fetched and parsed, otherwise an exception will get thrown.","created_at":"2015-08-28T00:21:40Z","updated_at":"2015-08-28T00:21:40Z","html_url":"https://github.com/NuGet/NuGet3/pull/122#discussion_r38161554","pull_request_url":"https://api.github.com/repos/NuGet/NuGet3/pulls/122","_links":{"self":{"href":"https://api.github.com/repos/NuGet/NuGet3/pulls/comments/38161554"},"html":{"href":"https://github.com/NuGet/NuGet3/pull/122#discussion_r38161554"},"pull_request":{"href":"https://api.github.com/repos/NuGet/NuGet3/pulls/122"}}},"pull_request":{"url":"https://api.github.com/repos/NuGet/NuGet3/pulls/122","id":43582091,"html_url":"https://github.com/NuGet/NuGet3/pull/122","diff_url":"https://github.com/NuGet/NuGet3/pull/122.diff","patch_url":"https://github.com/NuGet/NuGet3/pull/122.patch","issue_url":"https://api.github.com/repos/NuGet/NuGet3/issues/122","number":122,"state":"open","locked":false,"title":"Fix of NuGet/Home#1253: Don't fall thru when v3 feed failed","user":{"login":"feiling","id":2679220,"avatar_url":"https://avatars.githubusercontent.com/u/2679220?v=3","gravatar_id":"","url":"https://api.github.com/users/feiling","html_url":"https://github.com/feiling","followers_url":"https://api.github.com/users/feiling/followers","following_url":"https://api.github.com/users/feiling/following{/other_user}","gists_url":"https://api.github.com/users/feiling/gists{/gist_id}","starred_url":"https://api.github.com/users/feiling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feiling/subscriptions","organizations_url":"https://api.github.com/users/feiling/orgs","repos_url":"https://api.github.com/users/feiling/repos","events_url":"https://api.github.com/users/feiling/events{/privacy}","received_events_url":"https://api.github.com/users/feiling/received_events","type":"User","site_admin":false},"body":"Now if there is a failure, an exception will get thrown so GetResource fails immediately so no fall thru will happens. Also the V3 resource is cached only when it is successfully created.\r\n\r\n@deepakaravindr @emgarten @yishaigalatzer @zhili1208 ","created_at":"2015-08-28T00:20:03Z","updated_at":"2015-08-28T00:21:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"845a650547f2732d2ca16d96b36ee4216c10653e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/NuGet/NuGet3/pulls/122/commits","review_comments_url":"https://api.github.com/repos/NuGet/NuGet3/pulls/122/comments","review_comment_url":"https://api.github.com/repos/NuGet/NuGet3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NuGet/NuGet3/issues/122/comments","statuses_url":"https://api.github.com/repos/NuGet/NuGet3/statuses/8cbf11a9c0350fa7f21b6462e927149f8a1ac037","head":{"label":"NuGet:fix_1253","ref":"fix_1253","sha":"8cbf11a9c0350fa7f21b6462e927149f8a1ac037","user":{"login":"NuGet","id":968310,"avatar_url":"https://avatars.githubusercontent.com/u/968310?v=3","gravatar_id":"","url":"https://api.github.com/users/NuGet","html_url":"https://github.com/NuGet","followers_url":"https://api.github.com/users/NuGet/followers","following_url":"https://api.github.com/users/NuGet/following{/other_user}","gists_url":"https://api.github.com/users/NuGet/gists{/gist_id}","starred_url":"https://api.github.com/users/NuGet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NuGet/subscriptions","organizations_url":"https://api.github.com/users/NuGet/orgs","repos_url":"https://api.github.com/users/NuGet/repos","events_url":"https://api.github.com/users/NuGet/events{/privacy}","received_events_url":"https://api.github.com/users/NuGet/received_events","type":"Organization","site_admin":false},"repo":{"id":31300058,"name":"NuGet3","full_name":"NuGet/NuGet3","owner":{"login":"NuGet","id":968310,"avatar_url":"https://avatars.githubusercontent.com/u/968310?v=3","gravatar_id":"","url":"https://api.github.com/users/NuGet","html_url":"https://github.com/NuGet","followers_url":"https://api.github.com/users/NuGet/followers","following_url":"https://api.github.com/users/NuGet/following{/other_user}","gists_url":"https://api.github.com/users/NuGet/gists{/gist_id}","starred_url":"https://api.github.com/users/NuGet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NuGet/subscriptions","organizations_url":"https://api.github.com/users/NuGet/orgs","repos_url":"https://api.github.com/users/NuGet/repos","events_url":"https://api.github.com/users/NuGet/events{/privacy}","received_events_url":"https://api.github.com/users/NuGet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NuGet/NuGet3","description":"","fork":false,"url":"https://api.github.com/repos/NuGet/NuGet3","forks_url":"https://api.github.com/repos/NuGet/NuGet3/forks","keys_url":"https://api.github.com/repos/NuGet/NuGet3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NuGet/NuGet3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NuGet/NuGet3/teams","hooks_url":"https://api.github.com/repos/NuGet/NuGet3/hooks","issue_events_url":"https://api.github.com/repos/NuGet/NuGet3/issues/events{/number}","events_url":"https://api.github.com/repos/NuGet/NuGet3/events","assignees_url":"https://api.github.com/repos/NuGet/NuGet3/assignees{/user}","branches_url":"https://api.github.com/repos/NuGet/NuGet3/branches{/branch}","tags_url":"https://api.github.com/repos/NuGet/NuGet3/tags","blobs_url":"https://api.github.com/repos/NuGet/NuGet3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NuGet/NuGet3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NuGet/NuGet3/git/refs{/sha}","trees_url":"https://api.github.com/repos/NuGet/NuGet3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NuGet/NuGet3/statuses/{sha}","languages_url":"https://api.github.com/repos/NuGet/NuGet3/languages","stargazers_url":"https://api.github.com/repos/NuGet/NuGet3/stargazers","contributors_url":"https://api.github.com/repos/NuGet/NuGet3/contributors","subscribers_url":"https://api.github.com/repos/NuGet/NuGet3/subscribers","subscription_url":"https://api.github.com/repos/NuGet/NuGet3/subscription","commits_url":"https://api.github.com/repos/NuGet/NuGet3/commits{/sha}","git_commits_url":"https://api.github.com/repos/NuGet/NuGet3/git/commits{/sha}","comments_url":"https://api.github.com/repos/NuGet/NuGet3/comments{/number}","issue_comment_url":"https://api.github.com/repos/NuGet/NuGet3/issues/comments{/number}","contents_url":"https://api.github.com/repos/NuGet/NuGet3/contents/{+path}","compare_url":"https://api.github.com/repos/NuGet/NuGet3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NuGet/NuGet3/merges","archive_url":"https://api.github.com/repos/NuGet/NuGet3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NuGet/NuGet3/downloads","issues_url":"https://api.github.com/repos/NuGet/NuGet3/issues{/number}","pulls_url":"https://api.github.com/repos/NuGet/NuGet3/pulls{/number}","milestones_url":"https://api.github.com/repos/NuGet/NuGet3/milestones{/number}","notifications_url":"https://api.github.com/repos/NuGet/NuGet3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NuGet/NuGet3/labels{/name}","releases_url":"https://api.github.com/repos/NuGet/NuGet3/releases{/id}","created_at":"2015-02-25T06:15:00Z","updated_at":"2015-08-27T04:08:54Z","pushed_at":"2015-08-28T00:20:03Z","git_url":"git://github.com/NuGet/NuGet3.git","ssh_url":"git@github.com:NuGet/NuGet3.git","clone_url":"https://github.com/NuGet/NuGet3.git","svn_url":"https://github.com/NuGet/NuGet3","homepage":null,"size":7828,"stargazers_count":40,"watchers_count":40,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":7,"forks":17,"open_issues":7,"watchers":40,"default_branch":"dev"}},"base":{"label":"NuGet:dev","ref":"dev","sha":"8e3f14168d6b152a577f0fe473dce0eaff04cef8","user":{"login":"NuGet","id":968310,"avatar_url":"https://avatars.githubusercontent.com/u/968310?v=3","gravatar_id":"","url":"https://api.github.com/users/NuGet","html_url":"https://github.com/NuGet","followers_url":"https://api.github.com/users/NuGet/followers","following_url":"https://api.github.com/users/NuGet/following{/other_user}","gists_url":"https://api.github.com/users/NuGet/gists{/gist_id}","starred_url":"https://api.github.com/users/NuGet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NuGet/subscriptions","organizations_url":"https://api.github.com/users/NuGet/orgs","repos_url":"https://api.github.com/users/NuGet/repos","events_url":"https://api.github.com/users/NuGet/events{/privacy}","received_events_url":"https://api.github.com/users/NuGet/received_events","type":"Organization","site_admin":false},"repo":{"id":31300058,"name":"NuGet3","full_name":"NuGet/NuGet3","owner":{"login":"NuGet","id":968310,"avatar_url":"https://avatars.githubusercontent.com/u/968310?v=3","gravatar_id":"","url":"https://api.github.com/users/NuGet","html_url":"https://github.com/NuGet","followers_url":"https://api.github.com/users/NuGet/followers","following_url":"https://api.github.com/users/NuGet/following{/other_user}","gists_url":"https://api.github.com/users/NuGet/gists{/gist_id}","starred_url":"https://api.github.com/users/NuGet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NuGet/subscriptions","organizations_url":"https://api.github.com/users/NuGet/orgs","repos_url":"https://api.github.com/users/NuGet/repos","events_url":"https://api.github.com/users/NuGet/events{/privacy}","received_events_url":"https://api.github.com/users/NuGet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NuGet/NuGet3","description":"","fork":false,"url":"https://api.github.com/repos/NuGet/NuGet3","forks_url":"https://api.github.com/repos/NuGet/NuGet3/forks","keys_url":"https://api.github.com/repos/NuGet/NuGet3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NuGet/NuGet3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NuGet/NuGet3/teams","hooks_url":"https://api.github.com/repos/NuGet/NuGet3/hooks","issue_events_url":"https://api.github.com/repos/NuGet/NuGet3/issues/events{/number}","events_url":"https://api.github.com/repos/NuGet/NuGet3/events","assignees_url":"https://api.github.com/repos/NuGet/NuGet3/assignees{/user}","branches_url":"https://api.github.com/repos/NuGet/NuGet3/branches{/branch}","tags_url":"https://api.github.com/repos/NuGet/NuGet3/tags","blobs_url":"https://api.github.com/repos/NuGet/NuGet3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NuGet/NuGet3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NuGet/NuGet3/git/refs{/sha}","trees_url":"https://api.github.com/repos/NuGet/NuGet3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NuGet/NuGet3/statuses/{sha}","languages_url":"https://api.github.com/repos/NuGet/NuGet3/languages","stargazers_url":"https://api.github.com/repos/NuGet/NuGet3/stargazers","contributors_url":"https://api.github.com/repos/NuGet/NuGet3/contributors","subscribers_url":"https://api.github.com/repos/NuGet/NuGet3/subscribers","subscription_url":"https://api.github.com/repos/NuGet/NuGet3/subscription","commits_url":"https://api.github.com/repos/NuGet/NuGet3/commits{/sha}","git_commits_url":"https://api.github.com/repos/NuGet/NuGet3/git/commits{/sha}","comments_url":"https://api.github.com/repos/NuGet/NuGet3/comments{/number}","issue_comment_url":"https://api.github.com/repos/NuGet/NuGet3/issues/comments{/number}","contents_url":"https://api.github.com/repos/NuGet/NuGet3/contents/{+path}","compare_url":"https://api.github.com/repos/NuGet/NuGet3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NuGet/NuGet3/merges","archive_url":"https://api.github.com/repos/NuGet/NuGet3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NuGet/NuGet3/downloads","issues_url":"https://api.github.com/repos/NuGet/NuGet3/issues{/number}","pulls_url":"https://api.github.com/repos/NuGet/NuGet3/pulls{/number}","milestones_url":"https://api.github.com/repos/NuGet/NuGet3/milestones{/number}","notifications_url":"https://api.github.com/repos/NuGet/NuGet3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NuGet/NuGet3/labels{/name}","releases_url":"https://api.github.com/repos/NuGet/NuGet3/releases{/id}","created_at":"2015-02-25T06:15:00Z","updated_at":"2015-08-27T04:08:54Z","pushed_at":"2015-08-28T00:20:03Z","git_url":"git://github.com/NuGet/NuGet3.git","ssh_url":"git@github.com:NuGet/NuGet3.git","clone_url":"https://github.com/NuGet/NuGet3.git","svn_url":"https://github.com/NuGet/NuGet3","homepage":null,"size":7828,"stargazers_count":40,"watchers_count":40,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":7,"forks":17,"open_issues":7,"watchers":40,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/NuGet/NuGet3/pulls/122"},"html":{"href":"https://github.com/NuGet/NuGet3/pull/122"},"issue":{"href":"https://api.github.com/repos/NuGet/NuGet3/issues/122"},"comments":{"href":"https://api.github.com/repos/NuGet/NuGet3/issues/122/comments"},"review_comments":{"href":"https://api.github.com/repos/NuGet/NuGet3/pulls/122/comments"},"review_comment":{"href":"https://api.github.com/repos/NuGet/NuGet3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NuGet/NuGet3/pulls/122/commits"},"statuses":{"href":"https://api.github.com/repos/NuGet/NuGet3/statuses/8cbf11a9c0350fa7f21b6462e927149f8a1ac037"}}}}