{"action":"created","issue":{"url":"https://api.github.com/repos/buildbot/buildbot/issues/1699","labels_url":"https://api.github.com/repos/buildbot/buildbot/issues/1699/labels{/name}","comments_url":"https://api.github.com/repos/buildbot/buildbot/issues/1699/comments","events_url":"https://api.github.com/repos/buildbot/buildbot/issues/1699/events","html_url":"https://github.com/buildbot/buildbot/pull/1699","id":83517184,"number":1699,"title":"[Material Design] Recent builds panel's content","user":{"login":"shanzi","id":557294,"avatar_url":"https://avatars.githubusercontent.com/u/557294?v=3","gravatar_id":"","url":"https://api.github.com/users/shanzi","html_url":"https://github.com/shanzi","followers_url":"https://api.github.com/users/shanzi/followers","following_url":"https://api.github.com/users/shanzi/following{/other_user}","gists_url":"https://api.github.com/users/shanzi/gists{/gist_id}","starred_url":"https://api.github.com/users/shanzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shanzi/subscriptions","organizations_url":"https://api.github.com/users/shanzi/orgs","repos_url":"https://api.github.com/users/shanzi/repos","events_url":"https://api.github.com/users/shanzi/events{/privacy}","received_events_url":"https://api.github.com/users/shanzi/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/buildbot/buildbot/labels/needs%20more%20review","name":"needs more review","color":"bfe5bf"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":10,"created_at":"2015-06-01T14:08:42Z","updated_at":"2015-06-03T09:28:36Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/buildbot/buildbot/pulls/1699","html_url":"https://github.com/buildbot/buildbot/pull/1699","diff_url":"https://github.com/buildbot/buildbot/pull/1699.diff","patch_url":"https://github.com/buildbot/buildbot/pull/1699.patch"},"body":"Here is the contents of recent builds panel.\r\n\r\nAlong with this PR are also two new directives to inspect builds. One is `build-status` that display build status as icons with different colors. The other one is `build-item` that displays a build in a bar with some text such as builder name and build number. The latter directive should also link to the corresponding page but as those pages and routers has not yet finished, so I haven't added it now.\r\n\r\n![recent_builds](https://cloud.githubusercontent.com/assets/557294/7914199/1714af10-08a8-11e5-91ec-5e2b64375469.png)\r\n\r\nIn addition to the recent builds panel, I also make several other important modifications:\r\n\r\n1. Updated the version of Angular Material to latest version and resolved some compatible problems.\r\n2. Added `angular-moment` for convenient date time formatting\r\n\r\nTests for `build-status` and `build-item` has already been finished but I didn't include a test for `recent-builds` yet. As that directive is just simply using `build-item` to display builds, it is hard to make substantial tests. Do you have any suggestions on this?\r\n\r\nThere are some other problems too. For example, the panel can not update its content when new builds become completed, I see no elegant solution under current `service` framework, maybe we may need to wait for @tothandras 's new services that could provide a shortcuts for this. Also, each `build-item` will fetch the builder themselves, I added a switch for this but there might be a better solution.\r\n\r\nPlease review and give your comments :)"},"comment":{"url":"https://api.github.com/repos/buildbot/buildbot/issues/comments/108265046","html_url":"https://github.com/buildbot/buildbot/pull/1699#issuecomment-108265046","issue_url":"https://api.github.com/repos/buildbot/buildbot/issues/1699","id":108265046,"user":{"login":"shanzi","id":557294,"avatar_url":"https://avatars.githubusercontent.com/u/557294?v=3","gravatar_id":"","url":"https://api.github.com/users/shanzi","html_url":"https://github.com/shanzi","followers_url":"https://api.github.com/users/shanzi/followers","following_url":"https://api.github.com/users/shanzi/following{/other_user}","gists_url":"https://api.github.com/users/shanzi/gists{/gist_id}","starred_url":"https://api.github.com/users/shanzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shanzi/subscriptions","organizations_url":"https://api.github.com/users/shanzi/orgs","repos_url":"https://api.github.com/users/shanzi/repos","events_url":"https://api.github.com/users/shanzi/events{/privacy}","received_events_url":"https://api.github.com/users/shanzi/received_events","type":"User","site_admin":false},"created_at":"2015-06-03T09:28:36Z","updated_at":"2015-06-03T09:28:36Z","body":"You lose nothing put this on the dashboard, isn't it?\n\nAnd yes, maybe the most important function of the overview panel is to take\nsome space on the screen, but I think it is necessary as it makes the page\nlooks better. Although it will cost some http request, I'd rather keep it\nthere. We may try to find a way to reduce the HTTP request cost, update it\nwith more useful information such as displaying a total number of builds,\nor we replace it with other panel if we finally have a better idea. :)\n\nOn Wed, Jun 3, 2015 at 1:19 PM Mikhail Sobolev <notifications@github.com>\nwrote:\n\n> I thought a bit and I do not have any suggestions for overview that'd look\n> useful (you have that 'current' and 'recent' builds panels, which I find\n> more useful). So my question is do we need at all this kind of overview\n> panel? I'd rather see this information on the about page...\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/buildbot/buildbot/pull/1699#issuecomment-108196606>.\n>\n"}}