{"action":"created","issue":{"url":"https://api.github.com/repos/quri/react-bootstrap-datetimepicker/issues/54","labels_url":"https://api.github.com/repos/quri/react-bootstrap-datetimepicker/issues/54/labels{/name}","comments_url":"https://api.github.com/repos/quri/react-bootstrap-datetimepicker/issues/54/comments","events_url":"https://api.github.com/repos/quri/react-bootstrap-datetimepicker/issues/54/events","html_url":"https://github.com/quri/react-bootstrap-datetimepicker/pull/54","id":82822270,"number":54,"title":"Adding possibility to clear the selector and the properties clearable, disabled and placeholder. ","user":{"login":"alex1712","id":408460,"avatar_url":"https://avatars.githubusercontent.com/u/408460?v=3","gravatar_id":"","url":"https://api.github.com/users/alex1712","html_url":"https://github.com/alex1712","followers_url":"https://api.github.com/users/alex1712/followers","following_url":"https://api.github.com/users/alex1712/following{/other_user}","gists_url":"https://api.github.com/users/alex1712/gists{/gist_id}","starred_url":"https://api.github.com/users/alex1712/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alex1712/subscriptions","organizations_url":"https://api.github.com/users/alex1712/orgs","repos_url":"https://api.github.com/users/alex1712/repos","events_url":"https://api.github.com/users/alex1712/events{/privacy}","received_events_url":"https://api.github.com/users/alex1712/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-05-30T14:14:07Z","updated_at":"2015-09-25T00:59:50Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/quri/react-bootstrap-datetimepicker/pulls/54","html_url":"https://github.com/quri/react-bootstrap-datetimepicker/pull/54","diff_url":"https://github.com/quri/react-bootstrap-datetimepicker/pull/54.diff","patch_url":"https://github.com/quri/react-bootstrap-datetimepicker/pull/54.patch"},"body":"Hello again,\r\n\r\nI did some changes which I needed in my current project and hope that could help you to keep improving :).\r\n\r\nHere a resume of the changes:\r\n\r\n- Added the property 'value' as now it is possible that the selector doesn't have any value at the beginning or that the developar want to change the value fro outside the selector.\r\n- Added the property 'placeholder' instead of 'defaultText'. As the datepicker can be empty now, I think it would be useful to make use of the standard html placeholder attribute instead of setting the value with defaulText.\r\n- Added the property 'clearable'. This property set if the selector should show a clickable '×' where the user would be able to clean the selecte date*.\r\n- Added the property 'disabled'. Gives the developer the possibility to show the datetimepicker but not allowing the use of it.\r\n- React.Addons.classSet was also removed in favor of https://github.com/JedWatson/classnames as the old one it's deprecated in last versions of react (https://facebook.github.io/react/docs/class-name-manipulation.html). \r\n\r\n\\*To be able to have selectedDate empty, I had to completely split viewDate and selectedDate along the code.\r\n\r\nI think they are all my changes. We needed them really fast and maybe I didn't take long enought time to really check the code. But I hope that you get an idea of the features which I did and the code is helpful.\r\n\r\nAgain, thank you very much for all your work :)\r\n\r\nRegards"},"comment":{"url":"https://api.github.com/repos/quri/react-bootstrap-datetimepicker/issues/comments/143094777","html_url":"https://github.com/quri/react-bootstrap-datetimepicker/pull/54#issuecomment-143094777","issue_url":"https://api.github.com/repos/quri/react-bootstrap-datetimepicker/issues/54","id":143094777,"user":{"login":"larry-cook","id":1694588,"avatar_url":"https://avatars.githubusercontent.com/u/1694588?v=3","gravatar_id":"","url":"https://api.github.com/users/larry-cook","html_url":"https://github.com/larry-cook","followers_url":"https://api.github.com/users/larry-cook/followers","following_url":"https://api.github.com/users/larry-cook/following{/other_user}","gists_url":"https://api.github.com/users/larry-cook/gists{/gist_id}","starred_url":"https://api.github.com/users/larry-cook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/larry-cook/subscriptions","organizations_url":"https://api.github.com/users/larry-cook/orgs","repos_url":"https://api.github.com/users/larry-cook/repos","events_url":"https://api.github.com/users/larry-cook/events{/privacy}","received_events_url":"https://api.github.com/users/larry-cook/received_events","type":"User","site_admin":false},"created_at":"2015-09-25T00:59:50Z","updated_at":"2015-09-25T00:59:50Z","body":"+1 from us. A datepicker which can have it's selectedDate value emptied is a must-have feature. Any prospects of a merge of alex1712's changes into the quri mainstream?"}}