{"action":"created","comment":{"url":"https://api.github.com/repos/FAForever/server/pulls/comments/27355822","id":27355822,"diff_hunk":"@@ -65,3 +65,16 @@ Use `py.test` to execute the unit tests.\n # License\n \n GPLv3. See the [license](license.txt) file.\n+\n+# Network Protocol","path":"README.md","position":5,"original_position":5,"commit_id":"f842fd5da9a76f6c7b9d02728bd63237562ab8a8","original_commit_id":"f842fd5da9a76f6c7b9d02728bd63237562ab8a8","user":{"login":"Sheeo","id":37968,"avatar_url":"https://avatars.githubusercontent.com/u/37968?v=3","gravatar_id":"","url":"https://api.github.com/users/Sheeo","html_url":"https://github.com/Sheeo","followers_url":"https://api.github.com/users/Sheeo/followers","following_url":"https://api.github.com/users/Sheeo/following{/other_user}","gists_url":"https://api.github.com/users/Sheeo/gists{/gist_id}","starred_url":"https://api.github.com/users/Sheeo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sheeo/subscriptions","organizations_url":"https://api.github.com/users/Sheeo/orgs","repos_url":"https://api.github.com/users/Sheeo/repos","events_url":"https://api.github.com/users/Sheeo/events{/privacy}","received_events_url":"https://api.github.com/users/Sheeo/received_events","type":"User","site_admin":false},"body":"So regarding detailing the network protocol in `README.md`, I think it's better left to a seperate document (Perhaps the wiki?)","created_at":"2015-03-29T16:15:15Z","updated_at":"2015-03-29T16:15:15Z","html_url":"https://github.com/FAForever/server/pull/55#discussion_r27355822","pull_request_url":"https://api.github.com/repos/FAForever/server/pulls/55","_links":{"self":{"href":"https://api.github.com/repos/FAForever/server/pulls/comments/27355822"},"html":{"href":"https://github.com/FAForever/server/pull/55#discussion_r27355822"},"pull_request":{"href":"https://api.github.com/repos/FAForever/server/pulls/55"}}},"pull_request":{"url":"https://api.github.com/repos/FAForever/server/pulls/55","id":32183459,"html_url":"https://github.com/FAForever/server/pull/55","diff_url":"https://github.com/FAForever/server/pull/55.diff","patch_url":"https://github.com/FAForever/server/pull/55.patch","issue_url":"https://api.github.com/repos/FAForever/server/issues/55","number":55,"state":"open","locked":false,"title":"Test/modvault","user":{"login":"IDragonfire","id":1217999,"avatar_url":"https://avatars.githubusercontent.com/u/1217999?v=3","gravatar_id":"","url":"https://api.github.com/users/IDragonfire","html_url":"https://github.com/IDragonfire","followers_url":"https://api.github.com/users/IDragonfire/followers","following_url":"https://api.github.com/users/IDragonfire/following{/other_user}","gists_url":"https://api.github.com/users/IDragonfire/gists{/gist_id}","starred_url":"https://api.github.com/users/IDragonfire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IDragonfire/subscriptions","organizations_url":"https://api.github.com/users/IDragonfire/orgs","repos_url":"https://api.github.com/users/IDragonfire/repos","events_url":"https://api.github.com/users/IDragonfire/events{/privacy}","received_events_url":"https://api.github.com/users/IDragonfire/received_events","type":"User","site_admin":false},"body":"I added some basic tests for the modvault ...\r\n\r\nOpen: Add Comment\r\nFixed: Vote on invalid mod produce an db query","created_at":"2015-03-29T15:46:09Z","updated_at":"2015-03-29T16:15:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f8c4abe6032b6e20b01bdc0b6ef441785d63103a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/FAForever/server/pulls/55/commits","review_comments_url":"https://api.github.com/repos/FAForever/server/pulls/55/comments","review_comment_url":"https://api.github.com/repos/FAForever/server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FAForever/server/issues/55/comments","statuses_url":"https://api.github.com/repos/FAForever/server/statuses/f842fd5da9a76f6c7b9d02728bd63237562ab8a8","head":{"label":"IDragonfire:test/modvault","ref":"test/modvault","sha":"f842fd5da9a76f6c7b9d02728bd63237562ab8a8","user":{"login":"IDragonfire","id":1217999,"avatar_url":"https://avatars.githubusercontent.com/u/1217999?v=3","gravatar_id":"","url":"https://api.github.com/users/IDragonfire","html_url":"https://github.com/IDragonfire","followers_url":"https://api.github.com/users/IDragonfire/followers","following_url":"https://api.github.com/users/IDragonfire/following{/other_user}","gists_url":"https://api.github.com/users/IDragonfire/gists{/gist_id}","starred_url":"https://api.github.com/users/IDragonfire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IDragonfire/subscriptions","organizations_url":"https://api.github.com/users/IDragonfire/orgs","repos_url":"https://api.github.com/users/IDragonfire/repos","events_url":"https://api.github.com/users/IDragonfire/events{/privacy}","received_events_url":"https://api.github.com/users/IDragonfire/received_events","type":"User","site_admin":false},"repo":{"id":32980351,"name":"server","full_name":"IDragonfire/server","owner":{"login":"IDragonfire","id":1217999,"avatar_url":"https://avatars.githubusercontent.com/u/1217999?v=3","gravatar_id":"","url":"https://api.github.com/users/IDragonfire","html_url":"https://github.com/IDragonfire","followers_url":"https://api.github.com/users/IDragonfire/followers","following_url":"https://api.github.com/users/IDragonfire/following{/other_user}","gists_url":"https://api.github.com/users/IDragonfire/gists{/gist_id}","starred_url":"https://api.github.com/users/IDragonfire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IDragonfire/subscriptions","organizations_url":"https://api.github.com/users/IDragonfire/orgs","repos_url":"https://api.github.com/users/IDragonfire/repos","events_url":"https://api.github.com/users/IDragonfire/events{/privacy}","received_events_url":"https://api.github.com/users/IDragonfire/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/IDragonfire/server","description":"The servercode for the Forged Alliance Forever lobby","fork":true,"url":"https://api.github.com/repos/IDragonfire/server","forks_url":"https://api.github.com/repos/IDragonfire/server/forks","keys_url":"https://api.github.com/repos/IDragonfire/server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/IDragonfire/server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/IDragonfire/server/teams","hooks_url":"https://api.github.com/repos/IDragonfire/server/hooks","issue_events_url":"https://api.github.com/repos/IDragonfire/server/issues/events{/number}","events_url":"https://api.github.com/repos/IDragonfire/server/events","assignees_url":"https://api.github.com/repos/IDragonfire/server/assignees{/user}","branches_url":"https://api.github.com/repos/IDragonfire/server/branches{/branch}","tags_url":"https://api.github.com/repos/IDragonfire/server/tags","blobs_url":"https://api.github.com/repos/IDragonfire/server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/IDragonfire/server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/IDragonfire/server/git/refs{/sha}","trees_url":"https://api.github.com/repos/IDragonfire/server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/IDragonfire/server/statuses/{sha}","languages_url":"https://api.github.com/repos/IDragonfire/server/languages","stargazers_url":"https://api.github.com/repos/IDragonfire/server/stargazers","contributors_url":"https://api.github.com/repos/IDragonfire/server/contributors","subscribers_url":"https://api.github.com/repos/IDragonfire/server/subscribers","subscription_url":"https://api.github.com/repos/IDragonfire/server/subscription","commits_url":"https://api.github.com/repos/IDragonfire/server/commits{/sha}","git_commits_url":"https://api.github.com/repos/IDragonfire/server/git/commits{/sha}","comments_url":"https://api.github.com/repos/IDragonfire/server/comments{/number}","issue_comment_url":"https://api.github.com/repos/IDragonfire/server/issues/comments{/number}","contents_url":"https://api.github.com/repos/IDragonfire/server/contents/{+path}","compare_url":"https://api.github.com/repos/IDragonfire/server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/IDragonfire/server/merges","archive_url":"https://api.github.com/repos/IDragonfire/server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/IDragonfire/server/downloads","issues_url":"https://api.github.com/repos/IDragonfire/server/issues{/number}","pulls_url":"https://api.github.com/repos/IDragonfire/server/pulls{/number}","milestones_url":"https://api.github.com/repos/IDragonfire/server/milestones{/number}","notifications_url":"https://api.github.com/repos/IDragonfire/server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/IDragonfire/server/labels{/name}","releases_url":"https://api.github.com/repos/IDragonfire/server/releases{/id}","created_at":"2015-03-27T10:30:33Z","updated_at":"2015-03-29T15:38:27Z","pushed_at":"2015-03-29T15:42:04Z","git_url":"git://github.com/IDragonfire/server.git","ssh_url":"git@github.com:IDragonfire/server.git","clone_url":"https://github.com/IDragonfire/server.git","svn_url":"https://github.com/IDragonfire/server","homepage":"http://www.faforever.com","size":2881,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"FAForever:develop","ref":"develop","sha":"2a0729b0c01e1b73ac6ddf3fae29ec8aa3de7c00","user":{"login":"FAForever","id":8887184,"avatar_url":"https://avatars.githubusercontent.com/u/8887184?v=3","gravatar_id":"","url":"https://api.github.com/users/FAForever","html_url":"https://github.com/FAForever","followers_url":"https://api.github.com/users/FAForever/followers","following_url":"https://api.github.com/users/FAForever/following{/other_user}","gists_url":"https://api.github.com/users/FAForever/gists{/gist_id}","starred_url":"https://api.github.com/users/FAForever/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FAForever/subscriptions","organizations_url":"https://api.github.com/users/FAForever/orgs","repos_url":"https://api.github.com/users/FAForever/repos","events_url":"https://api.github.com/users/FAForever/events{/privacy}","received_events_url":"https://api.github.com/users/FAForever/received_events","type":"Organization","site_admin":false},"repo":{"id":25841126,"name":"server","full_name":"FAForever/server","owner":{"login":"FAForever","id":8887184,"avatar_url":"https://avatars.githubusercontent.com/u/8887184?v=3","gravatar_id":"","url":"https://api.github.com/users/FAForever","html_url":"https://github.com/FAForever","followers_url":"https://api.github.com/users/FAForever/followers","following_url":"https://api.github.com/users/FAForever/following{/other_user}","gists_url":"https://api.github.com/users/FAForever/gists{/gist_id}","starred_url":"https://api.github.com/users/FAForever/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FAForever/subscriptions","organizations_url":"https://api.github.com/users/FAForever/orgs","repos_url":"https://api.github.com/users/FAForever/repos","events_url":"https://api.github.com/users/FAForever/events{/privacy}","received_events_url":"https://api.github.com/users/FAForever/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FAForever/server","description":"The servercode for the Forged Alliance Forever lobby","fork":false,"url":"https://api.github.com/repos/FAForever/server","forks_url":"https://api.github.com/repos/FAForever/server/forks","keys_url":"https://api.github.com/repos/FAForever/server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FAForever/server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FAForever/server/teams","hooks_url":"https://api.github.com/repos/FAForever/server/hooks","issue_events_url":"https://api.github.com/repos/FAForever/server/issues/events{/number}","events_url":"https://api.github.com/repos/FAForever/server/events","assignees_url":"https://api.github.com/repos/FAForever/server/assignees{/user}","branches_url":"https://api.github.com/repos/FAForever/server/branches{/branch}","tags_url":"https://api.github.com/repos/FAForever/server/tags","blobs_url":"https://api.github.com/repos/FAForever/server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FAForever/server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FAForever/server/git/refs{/sha}","trees_url":"https://api.github.com/repos/FAForever/server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FAForever/server/statuses/{sha}","languages_url":"https://api.github.com/repos/FAForever/server/languages","stargazers_url":"https://api.github.com/repos/FAForever/server/stargazers","contributors_url":"https://api.github.com/repos/FAForever/server/contributors","subscribers_url":"https://api.github.com/repos/FAForever/server/subscribers","subscription_url":"https://api.github.com/repos/FAForever/server/subscription","commits_url":"https://api.github.com/repos/FAForever/server/commits{/sha}","git_commits_url":"https://api.github.com/repos/FAForever/server/git/commits{/sha}","comments_url":"https://api.github.com/repos/FAForever/server/comments{/number}","issue_comment_url":"https://api.github.com/repos/FAForever/server/issues/comments{/number}","contents_url":"https://api.github.com/repos/FAForever/server/contents/{+path}","compare_url":"https://api.github.com/repos/FAForever/server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FAForever/server/merges","archive_url":"https://api.github.com/repos/FAForever/server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FAForever/server/downloads","issues_url":"https://api.github.com/repos/FAForever/server/issues{/number}","pulls_url":"https://api.github.com/repos/FAForever/server/pulls{/number}","milestones_url":"https://api.github.com/repos/FAForever/server/milestones{/number}","notifications_url":"https://api.github.com/repos/FAForever/server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FAForever/server/labels{/name}","releases_url":"https://api.github.com/repos/FAForever/server/releases{/id}","created_at":"2014-10-27T21:58:37Z","updated_at":"2015-03-28T21:44:37Z","pushed_at":"2015-03-29T15:46:09Z","git_url":"git://github.com/FAForever/server.git","ssh_url":"git@github.com:FAForever/server.git","clone_url":"https://github.com/FAForever/server.git","svn_url":"https://github.com/FAForever/server","homepage":"http://www.faforever.com","size":4265,"stargazers_count":5,"watchers_count":5,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":17,"forks":7,"open_issues":17,"watchers":5,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/FAForever/server/pulls/55"},"html":{"href":"https://github.com/FAForever/server/pull/55"},"issue":{"href":"https://api.github.com/repos/FAForever/server/issues/55"},"comments":{"href":"https://api.github.com/repos/FAForever/server/issues/55/comments"},"review_comments":{"href":"https://api.github.com/repos/FAForever/server/pulls/55/comments"},"review_comment":{"href":"https://api.github.com/repos/FAForever/server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FAForever/server/pulls/55/commits"},"statuses":{"href":"https://api.github.com/repos/FAForever/server/statuses/f842fd5da9a76f6c7b9d02728bd63237562ab8a8"}}}}