{"action":"created","issue":{"url":"https://api.github.com/repos/sympy/sympy/issues/8877","labels_url":"https://api.github.com/repos/sympy/sympy/issues/8877/labels{/name}","comments_url":"https://api.github.com/repos/sympy/sympy/issues/8877/comments","events_url":"https://api.github.com/repos/sympy/sympy/issues/8877/events","html_url":"https://github.com/sympy/sympy/pull/8877","id":55345063,"number":8877,"title":"Issue #8828: G now also gives real solutions","user":{"login":"mihir-w","id":6362463,"avatar_url":"https://avatars.githubusercontent.com/u/6362463?v=3","gravatar_id":"","url":"https://api.github.com/users/mihir-w","html_url":"https://github.com/mihir-w","followers_url":"https://api.github.com/users/mihir-w/followers","following_url":"https://api.github.com/users/mihir-w/following{/other_user}","gists_url":"https://api.github.com/users/mihir-w/gists{/gist_id}","starred_url":"https://api.github.com/users/mihir-w/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mihir-w/subscriptions","organizations_url":"https://api.github.com/users/mihir-w/orgs","repos_url":"https://api.github.com/users/mihir-w/repos","events_url":"https://api.github.com/users/mihir-w/events{/privacy}","received_events_url":"https://api.github.com/users/mihir-w/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-01-23T23:09:42Z","updated_at":"2015-01-24T05:54:22Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/sympy/sympy/pulls/8877","html_url":"https://github.com/sympy/sympy/pull/8877","diff_url":"https://github.com/sympy/sympy/pull/8877.diff","patch_url":"https://github.com/sympy/sympy/pull/8877.patch"},"body":"Fixed formatting of verification of solution at the end. Removed one instance of `bad_result` in the code.\r\n\r\nAlthough I do still think that `got_s` logically should be inside the for loop, but since everything seems to working fine for now, I have kept it outside. Will try to come up with a test case later.\r\n\r\nOne of the test case function `test_issue_5849()` has solutions which do not satisfy the equations. Substitution of the given answer does not result in zero and hence `solve` was getting the required answer but returned the empty list since verification failed. So I changed the test case.\r\n\r\nSorry for the mess, in the last [PR](https://github.com/sympy/sympy/pull/8869). Have cherry-picked the commits from the last pull request.\r\n\r\nThanks for all the help!"},"comment":{"url":"https://api.github.com/repos/sympy/sympy/issues/comments/71301869","html_url":"https://github.com/sympy/sympy/pull/8877#issuecomment-71301869","issue_url":"https://api.github.com/repos/sympy/sympy/issues/8877","id":71301869,"user":{"login":"smichr","id":90703,"avatar_url":"https://avatars.githubusercontent.com/u/90703?v=3","gravatar_id":"","url":"https://api.github.com/users/smichr","html_url":"https://github.com/smichr","followers_url":"https://api.github.com/users/smichr/followers","following_url":"https://api.github.com/users/smichr/following{/other_user}","gists_url":"https://api.github.com/users/smichr/gists{/gist_id}","starred_url":"https://api.github.com/users/smichr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smichr/subscriptions","organizations_url":"https://api.github.com/users/smichr/orgs","repos_url":"https://api.github.com/users/smichr/repos","events_url":"https://api.github.com/users/smichr/events{/privacy}","received_events_url":"https://api.github.com/users/smichr/received_events","type":"User","site_admin":false},"created_at":"2015-01-24T05:54:22Z","updated_at":"2015-01-24T05:54:22Z","body":"[New PR](https://github.com/mihir-w/sympy/pull/3)."}}