{"action":"closed","number":2031,"pull_request":{"url":"https://api.github.com/repos/shuyangzhou/liferay-portal/pulls/2031","id":50896932,"html_url":"https://github.com/shuyangzhou/liferay-portal/pull/2031","diff_url":"https://github.com/shuyangzhou/liferay-portal/pull/2031.diff","patch_url":"https://github.com/shuyangzhou/liferay-portal/pull/2031.patch","issue_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/issues/2031","number":2031,"state":"closed","locked":false,"title":"Lps 60415","user":{"login":"tinatian","id":860623,"avatar_url":"https://avatars.githubusercontent.com/u/860623?v=3","gravatar_id":"","url":"https://api.github.com/users/tinatian","html_url":"https://github.com/tinatian","followers_url":"https://api.github.com/users/tinatian/followers","following_url":"https://api.github.com/users/tinatian/following{/other_user}","gists_url":"https://api.github.com/users/tinatian/gists{/gist_id}","starred_url":"https://api.github.com/users/tinatian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tinatian/subscriptions","organizations_url":"https://api.github.com/users/tinatian/orgs","repos_url":"https://api.github.com/users/tinatian/repos","events_url":"https://api.github.com/users/tinatian/events{/privacy}","received_events_url":"https://api.github.com/users/tinatian/received_events","type":"User","site_admin":false},"body":"Hi Shuyang,\r\n\r\nI debuged the code, without that PortalExecutorManager dependency, there is no NPE coming up in BaseAsyncDestination.open() line 146. The reason is that BaseAsyncDestination.open() only invoked in BaseAsyncDestination line 382 when PortalExecutorManager service is ready. It would be safe as long as there is no message sent on that destination.\r\n\r\nHowever, I added PortalExecutorManager dependency back to clarify the dependency between services in case some potential bugs in future.\r\n\r\n\r\nTina.\r\n\r\nTina.","created_at":"2015-11-17T02:33:06Z","updated_at":"2015-11-18T03:27:12Z","closed_at":"2015-11-18T03:27:12Z","merged_at":null,"merge_commit_sha":"eb85e72538e612bf8705d235277f53664b32024e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/pulls/2031/commits","review_comments_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/pulls/2031/comments","review_comment_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/issues/2031/comments","statuses_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/statuses/45407c478f7f32a80844ae44a1ae69b5e4ee1efe","head":{"label":"tinatian:LPS-60415-11-17","ref":"LPS-60415-11-17","sha":"45407c478f7f32a80844ae44a1ae69b5e4ee1efe","user":{"login":"tinatian","id":860623,"avatar_url":"https://avatars.githubusercontent.com/u/860623?v=3","gravatar_id":"","url":"https://api.github.com/users/tinatian","html_url":"https://github.com/tinatian","followers_url":"https://api.github.com/users/tinatian/followers","following_url":"https://api.github.com/users/tinatian/following{/other_user}","gists_url":"https://api.github.com/users/tinatian/gists{/gist_id}","starred_url":"https://api.github.com/users/tinatian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tinatian/subscriptions","organizations_url":"https://api.github.com/users/tinatian/orgs","repos_url":"https://api.github.com/users/tinatian/repos","events_url":"https://api.github.com/users/tinatian/events{/privacy}","received_events_url":"https://api.github.com/users/tinatian/received_events","type":"User","site_admin":false},"repo":{"id":45103999,"name":"liferay-portal","full_name":"tinatian/liferay-portal","owner":{"login":"tinatian","id":860623,"avatar_url":"https://avatars.githubusercontent.com/u/860623?v=3","gravatar_id":"","url":"https://api.github.com/users/tinatian","html_url":"https://github.com/tinatian","followers_url":"https://api.github.com/users/tinatian/followers","following_url":"https://api.github.com/users/tinatian/following{/other_user}","gists_url":"https://api.github.com/users/tinatian/gists{/gist_id}","starred_url":"https://api.github.com/users/tinatian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tinatian/subscriptions","organizations_url":"https://api.github.com/users/tinatian/orgs","repos_url":"https://api.github.com/users/tinatian/repos","events_url":"https://api.github.com/users/tinatian/events{/privacy}","received_events_url":"https://api.github.com/users/tinatian/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tinatian/liferay-portal","description":"","fork":true,"url":"https://api.github.com/repos/tinatian/liferay-portal","forks_url":"https://api.github.com/repos/tinatian/liferay-portal/forks","keys_url":"https://api.github.com/repos/tinatian/liferay-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tinatian/liferay-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tinatian/liferay-portal/teams","hooks_url":"https://api.github.com/repos/tinatian/liferay-portal/hooks","issue_events_url":"https://api.github.com/repos/tinatian/liferay-portal/issues/events{/number}","events_url":"https://api.github.com/repos/tinatian/liferay-portal/events","assignees_url":"https://api.github.com/repos/tinatian/liferay-portal/assignees{/user}","branches_url":"https://api.github.com/repos/tinatian/liferay-portal/branches{/branch}","tags_url":"https://api.github.com/repos/tinatian/liferay-portal/tags","blobs_url":"https://api.github.com/repos/tinatian/liferay-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tinatian/liferay-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tinatian/liferay-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/tinatian/liferay-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tinatian/liferay-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/tinatian/liferay-portal/languages","stargazers_url":"https://api.github.com/repos/tinatian/liferay-portal/stargazers","contributors_url":"https://api.github.com/repos/tinatian/liferay-portal/contributors","subscribers_url":"https://api.github.com/repos/tinatian/liferay-portal/subscribers","subscription_url":"https://api.github.com/repos/tinatian/liferay-portal/subscription","commits_url":"https://api.github.com/repos/tinatian/liferay-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/tinatian/liferay-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/tinatian/liferay-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/tinatian/liferay-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/tinatian/liferay-portal/contents/{+path}","compare_url":"https://api.github.com/repos/tinatian/liferay-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tinatian/liferay-portal/merges","archive_url":"https://api.github.com/repos/tinatian/liferay-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tinatian/liferay-portal/downloads","issues_url":"https://api.github.com/repos/tinatian/liferay-portal/issues{/number}","pulls_url":"https://api.github.com/repos/tinatian/liferay-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/tinatian/liferay-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/tinatian/liferay-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tinatian/liferay-portal/labels{/name}","releases_url":"https://api.github.com/repos/tinatian/liferay-portal/releases{/id}","created_at":"2015-10-28T10:08:34Z","updated_at":"2015-10-28T10:16:07Z","pushed_at":"2015-11-17T10:03:30Z","git_url":"git://github.com/tinatian/liferay-portal.git","ssh_url":"git@github.com:tinatian/liferay-portal.git","clone_url":"https://github.com/tinatian/liferay-portal.git","svn_url":"https://github.com/tinatian/liferay-portal","homepage":"http://liferay.com","size":5335747,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"shuyangzhou:master","ref":"master","sha":"be6fa739d5b30070dbbd0b1d24a2ed6ffe7e5c65","user":{"login":"shuyangzhou","id":173369,"avatar_url":"https://avatars.githubusercontent.com/u/173369?v=3","gravatar_id":"","url":"https://api.github.com/users/shuyangzhou","html_url":"https://github.com/shuyangzhou","followers_url":"https://api.github.com/users/shuyangzhou/followers","following_url":"https://api.github.com/users/shuyangzhou/following{/other_user}","gists_url":"https://api.github.com/users/shuyangzhou/gists{/gist_id}","starred_url":"https://api.github.com/users/shuyangzhou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shuyangzhou/subscriptions","organizations_url":"https://api.github.com/users/shuyangzhou/orgs","repos_url":"https://api.github.com/users/shuyangzhou/repos","events_url":"https://api.github.com/users/shuyangzhou/events{/privacy}","received_events_url":"https://api.github.com/users/shuyangzhou/received_events","type":"User","site_admin":false},"repo":{"id":1921247,"name":"liferay-portal","full_name":"shuyangzhou/liferay-portal","owner":{"login":"shuyangzhou","id":173369,"avatar_url":"https://avatars.githubusercontent.com/u/173369?v=3","gravatar_id":"","url":"https://api.github.com/users/shuyangzhou","html_url":"https://github.com/shuyangzhou","followers_url":"https://api.github.com/users/shuyangzhou/followers","following_url":"https://api.github.com/users/shuyangzhou/following{/other_user}","gists_url":"https://api.github.com/users/shuyangzhou/gists{/gist_id}","starred_url":"https://api.github.com/users/shuyangzhou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shuyangzhou/subscriptions","organizations_url":"https://api.github.com/users/shuyangzhou/orgs","repos_url":"https://api.github.com/users/shuyangzhou/repos","events_url":"https://api.github.com/users/shuyangzhou/events{/privacy}","received_events_url":"https://api.github.com/users/shuyangzhou/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shuyangzhou/liferay-portal","description":"","fork":true,"url":"https://api.github.com/repos/shuyangzhou/liferay-portal","forks_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/forks","keys_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/teams","hooks_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/hooks","issue_events_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/issues/events{/number}","events_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/events","assignees_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/assignees{/user}","branches_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/branches{/branch}","tags_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/tags","blobs_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/languages","stargazers_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/stargazers","contributors_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/contributors","subscribers_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/subscribers","subscription_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/subscription","commits_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/contents/{+path}","compare_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/merges","archive_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/downloads","issues_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/issues{/number}","pulls_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/labels{/name}","releases_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/releases{/id}","created_at":"2011-06-20T00:16:27Z","updated_at":"2015-05-08T16:25:44Z","pushed_at":"2015-11-18T03:26:32Z","git_url":"git://github.com/shuyangzhou/liferay-portal.git","ssh_url":"git@github.com:shuyangzhou/liferay-portal.git","clone_url":"https://github.com/shuyangzhou/liferay-portal.git","svn_url":"https://github.com/shuyangzhou/liferay-portal","homepage":"http://liferay.com","size":5367187,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":14,"forks":1,"open_issues":14,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/shuyangzhou/liferay-portal/pulls/2031"},"html":{"href":"https://github.com/shuyangzhou/liferay-portal/pull/2031"},"issue":{"href":"https://api.github.com/repos/shuyangzhou/liferay-portal/issues/2031"},"comments":{"href":"https://api.github.com/repos/shuyangzhou/liferay-portal/issues/2031/comments"},"review_comments":{"href":"https://api.github.com/repos/shuyangzhou/liferay-portal/pulls/2031/comments"},"review_comment":{"href":"https://api.github.com/repos/shuyangzhou/liferay-portal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/shuyangzhou/liferay-portal/pulls/2031/commits"},"statuses":{"href":"https://api.github.com/repos/shuyangzhou/liferay-portal/statuses/45407c478f7f32a80844ae44a1ae69b5e4ee1efe"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":2,"review_comments":0,"commits":51,"additions":2064,"deletions":888,"changed_files":162}}