{"action":"created","issue":{"url":"https://api.github.com/repos/webcomponents/webcomponentsjs/issues/339","labels_url":"https://api.github.com/repos/webcomponents/webcomponentsjs/issues/339/labels{/name}","comments_url":"https://api.github.com/repos/webcomponents/webcomponentsjs/issues/339/comments","events_url":"https://api.github.com/repos/webcomponents/webcomponentsjs/issues/339/events","html_url":"https://github.com/webcomponents/webcomponentsjs/pull/339","id":92233293,"number":339,"title":"Define CustomEvents shim wherever it's missing, not just in IE","user":{"login":"jre-g","id":9858748,"avatar_url":"https://avatars.githubusercontent.com/u/9858748?v=3","gravatar_id":"","url":"https://api.github.com/users/jre-g","html_url":"https://github.com/jre-g","followers_url":"https://api.github.com/users/jre-g/followers","following_url":"https://api.github.com/users/jre-g/following{/other_user}","gists_url":"https://api.github.com/users/jre-g/gists{/gist_id}","starred_url":"https://api.github.com/users/jre-g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jre-g/subscriptions","organizations_url":"https://api.github.com/users/jre-g/orgs","repos_url":"https://api.github.com/users/jre-g/repos","events_url":"https://api.github.com/users/jre-g/events{/privacy}","received_events_url":"https://api.github.com/users/jre-g/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-07-01T00:53:44Z","updated_at":"2015-09-28T23:44:50Z","closed_at":"2015-09-23T17:57:19Z","pull_request":{"url":"https://api.github.com/repos/webcomponents/webcomponentsjs/pulls/339","html_url":"https://github.com/webcomponents/webcomponentsjs/pull/339","diff_url":"https://github.com/webcomponents/webcomponentsjs/pull/339.diff","patch_url":"https://github.com/webcomponents/webcomponentsjs/pull/339.patch"},"body":"8d6a38a added a check confirming that we're running in IE before defining the `CustomEvent` shim. The purpose was to compensate for the fact that the previous `typeof window.CustomEvent !== 'function'` check behaved incorrectly in Safari, because their CustomEvent constructor had type `object`. However, this shim wasn't just required for Internet Explorer. It was also required for older versions of the Android Open Source Project browser, so the change broke support for that browser.\r\n\r\nThis PR instead just checks that `window.CustomEvent` is falsey, fixing the behaviour in the AOSP browser without breaking Safari.\r\n"},"comment":{"url":"https://api.github.com/repos/webcomponents/webcomponentsjs/issues/comments/143903230","html_url":"https://github.com/webcomponents/webcomponentsjs/pull/339#issuecomment-143903230","issue_url":"https://api.github.com/repos/webcomponents/webcomponentsjs/issues/339","id":143903230,"user":{"login":"azakus","id":46725,"avatar_url":"https://avatars.githubusercontent.com/u/46725?v=3","gravatar_id":"","url":"https://api.github.com/users/azakus","html_url":"https://github.com/azakus","followers_url":"https://api.github.com/users/azakus/followers","following_url":"https://api.github.com/users/azakus/following{/other_user}","gists_url":"https://api.github.com/users/azakus/gists{/gist_id}","starred_url":"https://api.github.com/users/azakus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azakus/subscriptions","organizations_url":"https://api.github.com/users/azakus/orgs","repos_url":"https://api.github.com/users/azakus/repos","events_url":"https://api.github.com/users/azakus/events{/privacy}","received_events_url":"https://api.github.com/users/azakus/received_events","type":"User","site_admin":false},"created_at":"2015-09-28T23:44:50Z","updated_at":"2015-09-28T23:44:50Z","body":"Yeah I was testing that and it seems to work."}}