{"action":"created","issue":{"url":"https://api.github.com/repos/cinder/Cinder/issues/767","labels_url":"https://api.github.com/repos/cinder/Cinder/issues/767/labels{/name}","comments_url":"https://api.github.com/repos/cinder/Cinder/issues/767/comments","events_url":"https://api.github.com/repos/cinder/Cinder/issues/767/events","html_url":"https://github.com/cinder/Cinder/pull/767","id":64257909,"number":767,"title":"Added GlslProg::Format getters for the shader paths","user":{"login":"simongeilfus","id":241098,"avatar_url":"https://avatars.githubusercontent.com/u/241098?v=3","gravatar_id":"","url":"https://api.github.com/users/simongeilfus","html_url":"https://github.com/simongeilfus","followers_url":"https://api.github.com/users/simongeilfus/followers","following_url":"https://api.github.com/users/simongeilfus/following{/other_user}","gists_url":"https://api.github.com/users/simongeilfus/gists{/gist_id}","starred_url":"https://api.github.com/users/simongeilfus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simongeilfus/subscriptions","organizations_url":"https://api.github.com/users/simongeilfus/orgs","repos_url":"https://api.github.com/users/simongeilfus/repos","events_url":"https://api.github.com/users/simongeilfus/events{/privacy}","received_events_url":"https://api.github.com/users/simongeilfus/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-03-25T12:33:01Z","updated_at":"2015-03-26T02:35:52Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cinder/Cinder/pulls/767","html_url":"https://github.com/cinder/Cinder/pull/767","diff_url":"https://github.com/cinder/Cinder/pull/767.diff","patch_url":"https://github.com/cinder/Cinder/pull/767.patch"},"body":"Would this be something interesting to add to the current GlslProg::Format implementation?\r\nThis is probably not going to be used a lot but I can definitely see this being useful in some specific cases.\r\n\r\nLet me know what you think.\r\nCheers,\r\nSimon."},"comment":{"url":"https://api.github.com/repos/cinder/Cinder/issues/comments/86303903","html_url":"https://github.com/cinder/Cinder/pull/767#issuecomment-86303903","issue_url":"https://api.github.com/repos/cinder/Cinder/issues/767","id":86303903,"user":{"login":"richardeakin","id":5132127,"avatar_url":"https://avatars.githubusercontent.com/u/5132127?v=3","gravatar_id":"","url":"https://api.github.com/users/richardeakin","html_url":"https://github.com/richardeakin","followers_url":"https://api.github.com/users/richardeakin/followers","following_url":"https://api.github.com/users/richardeakin/following{/other_user}","gists_url":"https://api.github.com/users/richardeakin/gists{/gist_id}","starred_url":"https://api.github.com/users/richardeakin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardeakin/subscriptions","organizations_url":"https://api.github.com/users/richardeakin/orgs","repos_url":"https://api.github.com/users/richardeakin/repos","events_url":"https://api.github.com/users/richardeakin/events{/privacy}","received_events_url":"https://api.github.com/users/richardeakin/received_events","type":"User","site_admin":false},"created_at":"2015-03-26T02:35:52Z","updated_at":"2015-03-26T02:35:52Z","body":"I can't see how it would hurt anything, although technically us storing shader paths is an implementation detail to enable searching for includes relative to the shader. Internally, it would probably mean that GlslProg::Format didn't have to friend GlslProg, if that matters to anyone.\r\n\r\nHave you found already found a usage for these getters?  One thing to note, is that the paths are currently forgotten once the GlslProg is constructed (they only live in GlslProg::Format). This may have to change if / when we support live shader updates, but that won't be this release.\r\n\r\nBtw, looks to need one more tab for each of the added lines."}}