{"action":"created","issue":{"url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/issues/974","labels_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/issues/974/labels{/name}","comments_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/issues/974/comments","events_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/issues/974/events","html_url":"https://github.com/WhisperSystems/Signal-iOS/pull/974","id":119380385,"number":974,"title":"Refactoring conditional directives that split up parts of statements.","user":{"login":"flaviommedeiros","id":4147365,"avatar_url":"https://avatars.githubusercontent.com/u/4147365?v=3","gravatar_id":"","url":"https://api.github.com/users/flaviommedeiros","html_url":"https://github.com/flaviommedeiros","followers_url":"https://api.github.com/users/flaviommedeiros/followers","following_url":"https://api.github.com/users/flaviommedeiros/following{/other_user}","gists_url":"https://api.github.com/users/flaviommedeiros/gists{/gist_id}","starred_url":"https://api.github.com/users/flaviommedeiros/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flaviommedeiros/subscriptions","organizations_url":"https://api.github.com/users/flaviommedeiros/orgs","repos_url":"https://api.github.com/users/flaviommedeiros/repos","events_url":"https://api.github.com/users/flaviommedeiros/events{/privacy}","received_events_url":"https://api.github.com/users/flaviommedeiros/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-11-29T19:19:10Z","updated_at":"2015-11-29T20:42:35Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/pulls/974","html_url":"https://github.com/WhisperSystems/Signal-iOS/pull/974","diff_url":"https://github.com/WhisperSystems/Signal-iOS/pull/974.diff","patch_url":"https://github.com/WhisperSystems/Signal-iOS/pull/974.patch"},"body":"A suggestion to compile entire statements and expressions, as suggested by code style guidelines from the Linux Kernel and practitioners.\r\n\r\n- https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/CodingStyle#n892\r\n- https://www.cqse.eu/en/blog/living-in-the-ifdef-hell/\r\n\r\nIt might improve code understanding, maintainability and error-proneness."},"comment":{"url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/issues/comments/160469334","html_url":"https://github.com/WhisperSystems/Signal-iOS/pull/974#issuecomment-160469334","issue_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/issues/974","id":160469334,"user":{"login":"haffenloher","id":264472,"avatar_url":"https://avatars.githubusercontent.com/u/264472?v=3","gravatar_id":"","url":"https://api.github.com/users/haffenloher","html_url":"https://github.com/haffenloher","followers_url":"https://api.github.com/users/haffenloher/followers","following_url":"https://api.github.com/users/haffenloher/following{/other_user}","gists_url":"https://api.github.com/users/haffenloher/gists{/gist_id}","starred_url":"https://api.github.com/users/haffenloher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haffenloher/subscriptions","organizations_url":"https://api.github.com/users/haffenloher/orgs","repos_url":"https://api.github.com/users/haffenloher/repos","events_url":"https://api.github.com/users/haffenloher/events{/privacy}","received_events_url":"https://api.github.com/users/haffenloher/received_events","type":"User","site_admin":false},"created_at":"2015-11-29T20:42:35Z","updated_at":"2015-11-29T20:42:35Z","body":"I don't think it's useful to start making code style fixes to third-party library code."}}