{"action":"closed","number":1172,"pull_request":{"url":"https://api.github.com/repos/dotnet/orleans/pulls/1172","id":54066947,"html_url":"https://github.com/dotnet/orleans/pull/1172","diff_url":"https://github.com/dotnet/orleans/pull/1172.diff","patch_url":"https://github.com/dotnet/orleans/pull/1172.patch","issue_url":"https://api.github.com/repos/dotnet/orleans/issues/1172","number":1172,"state":"closed","locked":false,"title":"Performance tweak for generic types","user":{"login":"Carlm-MS","id":7471063,"avatar_url":"https://avatars.githubusercontent.com/u/7471063?v=3","gravatar_id":"","url":"https://api.github.com/users/Carlm-MS","html_url":"https://github.com/Carlm-MS","followers_url":"https://api.github.com/users/Carlm-MS/followers","following_url":"https://api.github.com/users/Carlm-MS/following{/other_user}","gists_url":"https://api.github.com/users/Carlm-MS/gists{/gist_id}","starred_url":"https://api.github.com/users/Carlm-MS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Carlm-MS/subscriptions","organizations_url":"https://api.github.com/users/Carlm-MS/orgs","repos_url":"https://api.github.com/users/Carlm-MS/repos","events_url":"https://api.github.com/users/Carlm-MS/events{/privacy}","received_events_url":"https://api.github.com/users/Carlm-MS/received_events","type":"User","site_admin":false},"body":"in \r\n```csharp\r\nSerializationManager.Register(Type, Type)\r\n```\r\nthe delegates created for copy/serialize/deserialize with generic types all always call RegisterConcreteSerializer()\r\n\r\nThis is bad because every time RegisterConcreteSerializer is called, it uses reflection discover serializer/deserializer/copy methods, then re-registers the serializer (forced override) even if it hasn't changed.\r\n\r\nThe fix is to see if the concrete type has already been registered and use the existing serializer/deserializer/copier instead.","created_at":"2015-12-18T05:39:38Z","updated_at":"2015-12-19T19:44:38Z","closed_at":"2015-12-19T19:44:38Z","merged_at":"2015-12-19T19:44:38Z","merge_commit_sha":"bc212e197f18c3bc4503b9e94561a33253890b8b","assignee":{"login":"gabikliot","id":10171207,"avatar_url":"https://avatars.githubusercontent.com/u/10171207?v=3","gravatar_id":"","url":"https://api.github.com/users/gabikliot","html_url":"https://github.com/gabikliot","followers_url":"https://api.github.com/users/gabikliot/followers","following_url":"https://api.github.com/users/gabikliot/following{/other_user}","gists_url":"https://api.github.com/users/gabikliot/gists{/gist_id}","starred_url":"https://api.github.com/users/gabikliot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabikliot/subscriptions","organizations_url":"https://api.github.com/users/gabikliot/orgs","repos_url":"https://api.github.com/users/gabikliot/repos","events_url":"https://api.github.com/users/gabikliot/events{/privacy}","received_events_url":"https://api.github.com/users/gabikliot/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/orleans/pulls/1172/commits","review_comments_url":"https://api.github.com/repos/dotnet/orleans/pulls/1172/comments","review_comment_url":"https://api.github.com/repos/dotnet/orleans/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/orleans/issues/1172/comments","statuses_url":"https://api.github.com/repos/dotnet/orleans/statuses/419ee4dafe08750aaa9ed0c2cb15cb4ba57fdb36","head":{"label":"Carlm-MS:Carlm-PerfTweak","ref":"Carlm-PerfTweak","sha":"419ee4dafe08750aaa9ed0c2cb15cb4ba57fdb36","user":{"login":"Carlm-MS","id":7471063,"avatar_url":"https://avatars.githubusercontent.com/u/7471063?v=3","gravatar_id":"","url":"https://api.github.com/users/Carlm-MS","html_url":"https://github.com/Carlm-MS","followers_url":"https://api.github.com/users/Carlm-MS/followers","following_url":"https://api.github.com/users/Carlm-MS/following{/other_user}","gists_url":"https://api.github.com/users/Carlm-MS/gists{/gist_id}","starred_url":"https://api.github.com/users/Carlm-MS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Carlm-MS/subscriptions","organizations_url":"https://api.github.com/users/Carlm-MS/orgs","repos_url":"https://api.github.com/users/Carlm-MS/repos","events_url":"https://api.github.com/users/Carlm-MS/events{/privacy}","received_events_url":"https://api.github.com/users/Carlm-MS/received_events","type":"User","site_admin":false},"repo":{"id":45006245,"name":"orleans","full_name":"Carlm-MS/orleans","owner":{"login":"Carlm-MS","id":7471063,"avatar_url":"https://avatars.githubusercontent.com/u/7471063?v=3","gravatar_id":"","url":"https://api.github.com/users/Carlm-MS","html_url":"https://github.com/Carlm-MS","followers_url":"https://api.github.com/users/Carlm-MS/followers","following_url":"https://api.github.com/users/Carlm-MS/following{/other_user}","gists_url":"https://api.github.com/users/Carlm-MS/gists{/gist_id}","starred_url":"https://api.github.com/users/Carlm-MS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Carlm-MS/subscriptions","organizations_url":"https://api.github.com/users/Carlm-MS/orgs","repos_url":"https://api.github.com/users/Carlm-MS/repos","events_url":"https://api.github.com/users/Carlm-MS/events{/privacy}","received_events_url":"https://api.github.com/users/Carlm-MS/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Carlm-MS/orleans","description":"Orleans - Distributed Virtual Actor Model","fork":true,"url":"https://api.github.com/repos/Carlm-MS/orleans","forks_url":"https://api.github.com/repos/Carlm-MS/orleans/forks","keys_url":"https://api.github.com/repos/Carlm-MS/orleans/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Carlm-MS/orleans/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Carlm-MS/orleans/teams","hooks_url":"https://api.github.com/repos/Carlm-MS/orleans/hooks","issue_events_url":"https://api.github.com/repos/Carlm-MS/orleans/issues/events{/number}","events_url":"https://api.github.com/repos/Carlm-MS/orleans/events","assignees_url":"https://api.github.com/repos/Carlm-MS/orleans/assignees{/user}","branches_url":"https://api.github.com/repos/Carlm-MS/orleans/branches{/branch}","tags_url":"https://api.github.com/repos/Carlm-MS/orleans/tags","blobs_url":"https://api.github.com/repos/Carlm-MS/orleans/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Carlm-MS/orleans/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Carlm-MS/orleans/git/refs{/sha}","trees_url":"https://api.github.com/repos/Carlm-MS/orleans/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Carlm-MS/orleans/statuses/{sha}","languages_url":"https://api.github.com/repos/Carlm-MS/orleans/languages","stargazers_url":"https://api.github.com/repos/Carlm-MS/orleans/stargazers","contributors_url":"https://api.github.com/repos/Carlm-MS/orleans/contributors","subscribers_url":"https://api.github.com/repos/Carlm-MS/orleans/subscribers","subscription_url":"https://api.github.com/repos/Carlm-MS/orleans/subscription","commits_url":"https://api.github.com/repos/Carlm-MS/orleans/commits{/sha}","git_commits_url":"https://api.github.com/repos/Carlm-MS/orleans/git/commits{/sha}","comments_url":"https://api.github.com/repos/Carlm-MS/orleans/comments{/number}","issue_comment_url":"https://api.github.com/repos/Carlm-MS/orleans/issues/comments{/number}","contents_url":"https://api.github.com/repos/Carlm-MS/orleans/contents/{+path}","compare_url":"https://api.github.com/repos/Carlm-MS/orleans/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Carlm-MS/orleans/merges","archive_url":"https://api.github.com/repos/Carlm-MS/orleans/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Carlm-MS/orleans/downloads","issues_url":"https://api.github.com/repos/Carlm-MS/orleans/issues{/number}","pulls_url":"https://api.github.com/repos/Carlm-MS/orleans/pulls{/number}","milestones_url":"https://api.github.com/repos/Carlm-MS/orleans/milestones{/number}","notifications_url":"https://api.github.com/repos/Carlm-MS/orleans/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Carlm-MS/orleans/labels{/name}","releases_url":"https://api.github.com/repos/Carlm-MS/orleans/releases{/id}","created_at":"2015-10-27T00:16:59Z","updated_at":"2015-10-27T00:17:03Z","pushed_at":"2015-12-19T08:19:31Z","git_url":"git://github.com/Carlm-MS/orleans.git","ssh_url":"git@github.com:Carlm-MS/orleans.git","clone_url":"https://github.com/Carlm-MS/orleans.git","svn_url":"https://github.com/Carlm-MS/orleans","homepage":"http://dotnet.github.io/orleans","size":11496,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"42232b74435a628bad7f999a0c7e33adbbbafc1d","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":28232663,"name":"orleans","full_name":"dotnet/orleans","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/orleans","description":"Orleans - Distributed Virtual Actor Model","fork":false,"url":"https://api.github.com/repos/dotnet/orleans","forks_url":"https://api.github.com/repos/dotnet/orleans/forks","keys_url":"https://api.github.com/repos/dotnet/orleans/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/orleans/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/orleans/teams","hooks_url":"https://api.github.com/repos/dotnet/orleans/hooks","issue_events_url":"https://api.github.com/repos/dotnet/orleans/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/orleans/events","assignees_url":"https://api.github.com/repos/dotnet/orleans/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/orleans/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/orleans/tags","blobs_url":"https://api.github.com/repos/dotnet/orleans/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/orleans/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/orleans/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/orleans/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/orleans/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/orleans/languages","stargazers_url":"https://api.github.com/repos/dotnet/orleans/stargazers","contributors_url":"https://api.github.com/repos/dotnet/orleans/contributors","subscribers_url":"https://api.github.com/repos/dotnet/orleans/subscribers","subscription_url":"https://api.github.com/repos/dotnet/orleans/subscription","commits_url":"https://api.github.com/repos/dotnet/orleans/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/orleans/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/orleans/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/orleans/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/orleans/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/orleans/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/orleans/merges","archive_url":"https://api.github.com/repos/dotnet/orleans/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/orleans/downloads","issues_url":"https://api.github.com/repos/dotnet/orleans/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/orleans/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/orleans/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/orleans/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/orleans/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/orleans/releases{/id}","created_at":"2014-12-19T14:32:50Z","updated_at":"2015-12-19T14:22:33Z","pushed_at":"2015-12-19T19:44:38Z","git_url":"git://github.com/dotnet/orleans.git","ssh_url":"git@github.com:dotnet/orleans.git","clone_url":"https://github.com/dotnet/orleans.git","svn_url":"https://github.com/dotnet/orleans","homepage":"http://dotnet.github.io/orleans","size":29329,"stargazers_count":1389,"watchers_count":1389,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":332,"mirror_url":null,"open_issues_count":116,"forks":332,"open_issues":116,"watchers":1389,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/orleans/pulls/1172"},"html":{"href":"https://github.com/dotnet/orleans/pull/1172"},"issue":{"href":"https://api.github.com/repos/dotnet/orleans/issues/1172"},"comments":{"href":"https://api.github.com/repos/dotnet/orleans/issues/1172/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/orleans/pulls/1172/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/orleans/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/orleans/pulls/1172/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/orleans/statuses/419ee4dafe08750aaa9ed0c2cb15cb4ba57fdb36"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"gabikliot","id":10171207,"avatar_url":"https://avatars.githubusercontent.com/u/10171207?v=3","gravatar_id":"","url":"https://api.github.com/users/gabikliot","html_url":"https://github.com/gabikliot","followers_url":"https://api.github.com/users/gabikliot/followers","following_url":"https://api.github.com/users/gabikliot/following{/other_user}","gists_url":"https://api.github.com/users/gabikliot/gists{/gist_id}","starred_url":"https://api.github.com/users/gabikliot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabikliot/subscriptions","organizations_url":"https://api.github.com/users/gabikliot/orgs","repos_url":"https://api.github.com/users/gabikliot/repos","events_url":"https://api.github.com/users/gabikliot/events{/privacy}","received_events_url":"https://api.github.com/users/gabikliot/received_events","type":"User","site_admin":false},"comments":4,"review_comments":0,"commits":1,"additions":15,"deletions":0,"changed_files":1}}