{"action":"created","issue":{"url":"https://api.github.com/repos/oracle/node-oracledb/issues/227","labels_url":"https://api.github.com/repos/oracle/node-oracledb/issues/227/labels{/name}","comments_url":"https://api.github.com/repos/oracle/node-oracledb/issues/227/comments","events_url":"https://api.github.com/repos/oracle/node-oracledb/issues/227/events","html_url":"https://github.com/oracle/node-oracledb/pull/227","id":108438221,"number":227,"title":"Upgrade Nan to ^2.1.0","user":{"login":"Bigous","id":6886560,"avatar_url":"https://avatars.githubusercontent.com/u/6886560?v=3","gravatar_id":"","url":"https://api.github.com/users/Bigous","html_url":"https://github.com/Bigous","followers_url":"https://api.github.com/users/Bigous/followers","following_url":"https://api.github.com/users/Bigous/following{/other_user}","gists_url":"https://api.github.com/users/Bigous/gists{/gist_id}","starred_url":"https://api.github.com/users/Bigous/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bigous/subscriptions","organizations_url":"https://api.github.com/users/Bigous/orgs","repos_url":"https://api.github.com/users/Bigous/repos","events_url":"https://api.github.com/users/Bigous/events{/privacy}","received_events_url":"https://api.github.com/users/Bigous/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":43,"created_at":"2015-09-26T04:02:16Z","updated_at":"2015-11-04T18:59:57Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/oracle/node-oracledb/pulls/227","html_url":"https://github.com/oracle/node-oracledb/pull/227","diff_url":"https://github.com/oracle/node-oracledb/pull/227.diff","patch_url":"https://github.com/oracle/node-oracledb/pull/227.patch"},"body":"Hi,\r\n\r\nI've upgraded Nan to 2.x (sorry about the delay).\r\nIt's working on node 0.10.38, 0.12.7 and 4.1.1 on Windows 10 x64 - compiled with VS2015 community.\r\n\r\nRunning all mocha tests at once is breaking mocha in my environment, but it is breaking with previous Nan too, so I think this version is as stable as the prior.\r\n\r\nRunning tests one by one, It points me to test\\dataTypeRaw.js, but i think it has something to do with async in my environment.\r\n\r\nI'm releasing it so more people can test and confirm the stability and we can merge to the main repository.\r\n\r\n[]'s\r\nBigous"},"comment":{"url":"https://api.github.com/repos/oracle/node-oracledb/issues/comments/153830949","html_url":"https://github.com/oracle/node-oracledb/pull/227#issuecomment-153830949","issue_url":"https://api.github.com/repos/oracle/node-oracledb/issues/227","id":153830949,"user":{"login":"Bigous","id":6886560,"avatar_url":"https://avatars.githubusercontent.com/u/6886560?v=3","gravatar_id":"","url":"https://api.github.com/users/Bigous","html_url":"https://github.com/Bigous","followers_url":"https://api.github.com/users/Bigous/followers","following_url":"https://api.github.com/users/Bigous/following{/other_user}","gists_url":"https://api.github.com/users/Bigous/gists{/gist_id}","starred_url":"https://api.github.com/users/Bigous/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bigous/subscriptions","organizations_url":"https://api.github.com/users/Bigous/orgs","repos_url":"https://api.github.com/users/Bigous/repos","events_url":"https://api.github.com/users/Bigous/events{/privacy}","received_events_url":"https://api.github.com/users/Bigous/received_events","type":"User","site_admin":false},"created_at":"2015-11-04T18:59:57Z","updated_at":"2015-11-04T18:59:57Z","body":"Ok, tested the @jrop testcase here - windows 10 x64 - with both node 0.12.7 and 4.2.1 - this problem does not happens.\r\n\r\nI'm trying to figure out the leak problem yet."}}