{"action":"created","comment":{"url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments/41258096","id":41258096,"diff_hunk":"@@ -18,60 +18,57 @@\n \n import com.hazelcast.client.impl.protocol.ClientMessage;\n import com.hazelcast.client.impl.protocol.codec.MapEntrySetCodec;\n-import com.hazelcast.client.impl.protocol.task.AbstractAllPartitionsMessageTask;\n import com.hazelcast.instance.Node;\n-import com.hazelcast.map.impl.MapEntries;\n-import com.hazelcast.map.impl.MapService;\n-import com.hazelcast.map.impl.operation.EntrySetOperationFactory;\n+import com.hazelcast.map.impl.query.QueryResultRow;\n import com.hazelcast.nio.Connection;\n import com.hazelcast.nio.serialization.Data;\n+import com.hazelcast.query.Predicate;\n+import com.hazelcast.query.TruePredicate;\n import com.hazelcast.security.permission.ActionConstants;\n import com.hazelcast.security.permission.MapPermission;\n-import com.hazelcast.spi.OperationFactory;\n+import com.hazelcast.util.IterationType;\n \n import java.security.Permission;\n-import java.util.HashSet;\n+import java.util.AbstractMap;\n+import java.util.ArrayList;\n+import java.util.Collection;\n+import java.util.List;\n import java.util.Map;\n-import java.util.Set;\n \n public class MapEntrySetMessageTask\n-        extends AbstractAllPartitionsMessageTask<MapEntrySetCodec.RequestParameters> {\n+        extends AbstractMapQueryMessageTask<MapEntrySetCodec.RequestParameters> {\n \n     public MapEntrySetMessageTask(ClientMessage clientMessage, Node node, Connection connection) {\n         super(clientMessage, node, connection);\n     }\n \n     @Override\n-    protected OperationFactory createOperationFactory() {\n-        return new EntrySetOperationFactory(parameters.name);\n+    protected Object reduce(Collection<QueryResultRow> result) {\n+        List<Map.Entry<Data, Data>> entries = new ArrayList<Map.Entry<Data, Data>>(result.size());\n+        for (QueryResultRow row : result) {\n+            entries.add(new AbstractMap.SimpleEntry<Data, Data>(row.getKey(), row.getValue()));","path":"hazelcast/src/main/java/com/hazelcast/client/impl/protocol/task/map/MapEntrySetMessageTask.java","position":42,"original_position":42,"commit_id":"748f742ce10817c67353e78462dc4759071942cf","original_commit_id":"748f742ce10817c67353e78462dc4759071942cf","user":{"login":"sancar","id":570462,"avatar_url":"https://avatars.githubusercontent.com/u/570462?v=3","gravatar_id":"","url":"https://api.github.com/users/sancar","html_url":"https://github.com/sancar","followers_url":"https://api.github.com/users/sancar/followers","following_url":"https://api.github.com/users/sancar/following{/other_user}","gists_url":"https://api.github.com/users/sancar/gists{/gist_id}","starred_url":"https://api.github.com/users/sancar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sancar/subscriptions","organizations_url":"https://api.github.com/users/sancar/orgs","repos_url":"https://api.github.com/users/sancar/repos","events_url":"https://api.github.com/users/sancar/events{/privacy}","received_events_url":"https://api.github.com/users/sancar/received_events","type":"User","site_admin":false},"body":"Upps. I forget to change this. QueryResultRow is already Map.Entry<Data, Data>. \r\nI mean I made it so that I don't have to create object here. I will update it. ","created_at":"2015-10-06T12:42:38Z","updated_at":"2015-10-06T12:42:38Z","html_url":"https://github.com/hazelcast/hazelcast/pull/6384#discussion_r41258096","pull_request_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/6384","_links":{"self":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments/41258096"},"html":{"href":"https://github.com/hazelcast/hazelcast/pull/6384#discussion_r41258096"},"pull_request":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/6384"}}},"pull_request":{"url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/6384","id":46887533,"html_url":"https://github.com/hazelcast/hazelcast/pull/6384","diff_url":"https://github.com/hazelcast/hazelcast/pull/6384.diff","patch_url":"https://github.com/hazelcast/hazelcast/pull/6384.patch","issue_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/6384","number":6384,"state":"open","locked":false,"title":"Performance: keyset/values download too much applied to new client","user":{"login":"sancar","id":570462,"avatar_url":"https://avatars.githubusercontent.com/u/570462?v=3","gravatar_id":"","url":"https://api.github.com/users/sancar","html_url":"https://github.com/sancar","followers_url":"https://api.github.com/users/sancar/followers","following_url":"https://api.github.com/users/sancar/following{/other_user}","gists_url":"https://api.github.com/users/sancar/gists{/gist_id}","starred_url":"https://api.github.com/users/sancar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sancar/subscriptions","organizations_url":"https://api.github.com/users/sancar/orgs","repos_url":"https://api.github.com/users/sancar/repos","events_url":"https://api.github.com/users/sancar/events{/privacy}","received_events_url":"https://api.github.com/users/sancar/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-10-06T10:50:16Z","updated_at":"2015-10-06T12:42:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f8bce44c55fcfd2bd09819dba34d24fc0688b9dd","assignee":{"login":"sancar","id":570462,"avatar_url":"https://avatars.githubusercontent.com/u/570462?v=3","gravatar_id":"","url":"https://api.github.com/users/sancar","html_url":"https://github.com/sancar","followers_url":"https://api.github.com/users/sancar/followers","following_url":"https://api.github.com/users/sancar/following{/other_user}","gists_url":"https://api.github.com/users/sancar/gists{/gist_id}","starred_url":"https://api.github.com/users/sancar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sancar/subscriptions","organizations_url":"https://api.github.com/users/sancar/orgs","repos_url":"https://api.github.com/users/sancar/repos","events_url":"https://api.github.com/users/sancar/events{/privacy}","received_events_url":"https://api.github.com/users/sancar/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/hazelcast/hazelcast/milestones/61","html_url":"https://github.com/hazelcast/hazelcast/milestones/3.6","labels_url":"https://api.github.com/repos/hazelcast/hazelcast/milestones/61/labels","id":982584,"number":61,"title":"3.6","description":"","creator":{"login":"enesakar","id":234086,"avatar_url":"https://avatars.githubusercontent.com/u/234086?v=3","gravatar_id":"","url":"https://api.github.com/users/enesakar","html_url":"https://github.com/enesakar","followers_url":"https://api.github.com/users/enesakar/followers","following_url":"https://api.github.com/users/enesakar/following{/other_user}","gists_url":"https://api.github.com/users/enesakar/gists{/gist_id}","starred_url":"https://api.github.com/users/enesakar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enesakar/subscriptions","organizations_url":"https://api.github.com/users/enesakar/orgs","repos_url":"https://api.github.com/users/enesakar/repos","events_url":"https://api.github.com/users/enesakar/events{/privacy}","received_events_url":"https://api.github.com/users/enesakar/received_events","type":"User","site_admin":false},"open_issues":162,"closed_issues":516,"state":"open","created_at":"2015-02-17T09:27:09Z","updated_at":"2015-10-06T11:39:17Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/6384/commits","review_comments_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/6384/comments","review_comment_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/6384/comments","statuses_url":"https://api.github.com/repos/hazelcast/hazelcast/statuses/748f742ce10817c67353e78462dc4759071942cf","head":{"label":"sancar:performance/queryChanges/newClient","ref":"performance/queryChanges/newClient","sha":"748f742ce10817c67353e78462dc4759071942cf","user":{"login":"sancar","id":570462,"avatar_url":"https://avatars.githubusercontent.com/u/570462?v=3","gravatar_id":"","url":"https://api.github.com/users/sancar","html_url":"https://github.com/sancar","followers_url":"https://api.github.com/users/sancar/followers","following_url":"https://api.github.com/users/sancar/following{/other_user}","gists_url":"https://api.github.com/users/sancar/gists{/gist_id}","starred_url":"https://api.github.com/users/sancar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sancar/subscriptions","organizations_url":"https://api.github.com/users/sancar/orgs","repos_url":"https://api.github.com/users/sancar/repos","events_url":"https://api.github.com/users/sancar/events{/privacy}","received_events_url":"https://api.github.com/users/sancar/received_events","type":"User","site_admin":false},"repo":{"id":12152804,"name":"hazelcast","full_name":"sancar/hazelcast","owner":{"login":"sancar","id":570462,"avatar_url":"https://avatars.githubusercontent.com/u/570462?v=3","gravatar_id":"","url":"https://api.github.com/users/sancar","html_url":"https://github.com/sancar","followers_url":"https://api.github.com/users/sancar/followers","following_url":"https://api.github.com/users/sancar/following{/other_user}","gists_url":"https://api.github.com/users/sancar/gists{/gist_id}","starred_url":"https://api.github.com/users/sancar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sancar/subscriptions","organizations_url":"https://api.github.com/users/sancar/orgs","repos_url":"https://api.github.com/users/sancar/repos","events_url":"https://api.github.com/users/sancar/events{/privacy}","received_events_url":"https://api.github.com/users/sancar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sancar/hazelcast","description":"Open Source In-Memory Data Grid","fork":true,"url":"https://api.github.com/repos/sancar/hazelcast","forks_url":"https://api.github.com/repos/sancar/hazelcast/forks","keys_url":"https://api.github.com/repos/sancar/hazelcast/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sancar/hazelcast/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sancar/hazelcast/teams","hooks_url":"https://api.github.com/repos/sancar/hazelcast/hooks","issue_events_url":"https://api.github.com/repos/sancar/hazelcast/issues/events{/number}","events_url":"https://api.github.com/repos/sancar/hazelcast/events","assignees_url":"https://api.github.com/repos/sancar/hazelcast/assignees{/user}","branches_url":"https://api.github.com/repos/sancar/hazelcast/branches{/branch}","tags_url":"https://api.github.com/repos/sancar/hazelcast/tags","blobs_url":"https://api.github.com/repos/sancar/hazelcast/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sancar/hazelcast/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sancar/hazelcast/git/refs{/sha}","trees_url":"https://api.github.com/repos/sancar/hazelcast/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sancar/hazelcast/statuses/{sha}","languages_url":"https://api.github.com/repos/sancar/hazelcast/languages","stargazers_url":"https://api.github.com/repos/sancar/hazelcast/stargazers","contributors_url":"https://api.github.com/repos/sancar/hazelcast/contributors","subscribers_url":"https://api.github.com/repos/sancar/hazelcast/subscribers","subscription_url":"https://api.github.com/repos/sancar/hazelcast/subscription","commits_url":"https://api.github.com/repos/sancar/hazelcast/commits{/sha}","git_commits_url":"https://api.github.com/repos/sancar/hazelcast/git/commits{/sha}","comments_url":"https://api.github.com/repos/sancar/hazelcast/comments{/number}","issue_comment_url":"https://api.github.com/repos/sancar/hazelcast/issues/comments{/number}","contents_url":"https://api.github.com/repos/sancar/hazelcast/contents/{+path}","compare_url":"https://api.github.com/repos/sancar/hazelcast/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sancar/hazelcast/merges","archive_url":"https://api.github.com/repos/sancar/hazelcast/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sancar/hazelcast/downloads","issues_url":"https://api.github.com/repos/sancar/hazelcast/issues{/number}","pulls_url":"https://api.github.com/repos/sancar/hazelcast/pulls{/number}","milestones_url":"https://api.github.com/repos/sancar/hazelcast/milestones{/number}","notifications_url":"https://api.github.com/repos/sancar/hazelcast/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sancar/hazelcast/labels{/name}","releases_url":"https://api.github.com/repos/sancar/hazelcast/releases{/id}","created_at":"2013-08-16T06:59:07Z","updated_at":"2015-04-23T16:11:55Z","pushed_at":"2015-10-06T10:51:36Z","git_url":"git://github.com/sancar/hazelcast.git","ssh_url":"git@github.com:sancar/hazelcast.git","clone_url":"https://github.com/sancar/hazelcast.git","svn_url":"https://github.com/sancar/hazelcast","homepage":"www.hazelcast.com","size":87447,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hazelcast:master","ref":"master","sha":"fa45bdaf21a50c57edd26af1ec0dc651948c5235","user":{"login":"hazelcast","id":1453152,"avatar_url":"https://avatars.githubusercontent.com/u/1453152?v=3","gravatar_id":"","url":"https://api.github.com/users/hazelcast","html_url":"https://github.com/hazelcast","followers_url":"https://api.github.com/users/hazelcast/followers","following_url":"https://api.github.com/users/hazelcast/following{/other_user}","gists_url":"https://api.github.com/users/hazelcast/gists{/gist_id}","starred_url":"https://api.github.com/users/hazelcast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hazelcast/subscriptions","organizations_url":"https://api.github.com/users/hazelcast/orgs","repos_url":"https://api.github.com/users/hazelcast/repos","events_url":"https://api.github.com/users/hazelcast/events{/privacy}","received_events_url":"https://api.github.com/users/hazelcast/received_events","type":"Organization","site_admin":false},"repo":{"id":3786237,"name":"hazelcast","full_name":"hazelcast/hazelcast","owner":{"login":"hazelcast","id":1453152,"avatar_url":"https://avatars.githubusercontent.com/u/1453152?v=3","gravatar_id":"","url":"https://api.github.com/users/hazelcast","html_url":"https://github.com/hazelcast","followers_url":"https://api.github.com/users/hazelcast/followers","following_url":"https://api.github.com/users/hazelcast/following{/other_user}","gists_url":"https://api.github.com/users/hazelcast/gists{/gist_id}","starred_url":"https://api.github.com/users/hazelcast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hazelcast/subscriptions","organizations_url":"https://api.github.com/users/hazelcast/orgs","repos_url":"https://api.github.com/users/hazelcast/repos","events_url":"https://api.github.com/users/hazelcast/events{/privacy}","received_events_url":"https://api.github.com/users/hazelcast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hazelcast/hazelcast","description":"Open Source In-Memory Data Grid","fork":false,"url":"https://api.github.com/repos/hazelcast/hazelcast","forks_url":"https://api.github.com/repos/hazelcast/hazelcast/forks","keys_url":"https://api.github.com/repos/hazelcast/hazelcast/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hazelcast/hazelcast/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hazelcast/hazelcast/teams","hooks_url":"https://api.github.com/repos/hazelcast/hazelcast/hooks","issue_events_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/events{/number}","events_url":"https://api.github.com/repos/hazelcast/hazelcast/events","assignees_url":"https://api.github.com/repos/hazelcast/hazelcast/assignees{/user}","branches_url":"https://api.github.com/repos/hazelcast/hazelcast/branches{/branch}","tags_url":"https://api.github.com/repos/hazelcast/hazelcast/tags","blobs_url":"https://api.github.com/repos/hazelcast/hazelcast/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hazelcast/hazelcast/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hazelcast/hazelcast/git/refs{/sha}","trees_url":"https://api.github.com/repos/hazelcast/hazelcast/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hazelcast/hazelcast/statuses/{sha}","languages_url":"https://api.github.com/repos/hazelcast/hazelcast/languages","stargazers_url":"https://api.github.com/repos/hazelcast/hazelcast/stargazers","contributors_url":"https://api.github.com/repos/hazelcast/hazelcast/contributors","subscribers_url":"https://api.github.com/repos/hazelcast/hazelcast/subscribers","subscription_url":"https://api.github.com/repos/hazelcast/hazelcast/subscription","commits_url":"https://api.github.com/repos/hazelcast/hazelcast/commits{/sha}","git_commits_url":"https://api.github.com/repos/hazelcast/hazelcast/git/commits{/sha}","comments_url":"https://api.github.com/repos/hazelcast/hazelcast/comments{/number}","issue_comment_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/comments{/number}","contents_url":"https://api.github.com/repos/hazelcast/hazelcast/contents/{+path}","compare_url":"https://api.github.com/repos/hazelcast/hazelcast/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hazelcast/hazelcast/merges","archive_url":"https://api.github.com/repos/hazelcast/hazelcast/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hazelcast/hazelcast/downloads","issues_url":"https://api.github.com/repos/hazelcast/hazelcast/issues{/number}","pulls_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls{/number}","milestones_url":"https://api.github.com/repos/hazelcast/hazelcast/milestones{/number}","notifications_url":"https://api.github.com/repos/hazelcast/hazelcast/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hazelcast/hazelcast/labels{/name}","releases_url":"https://api.github.com/repos/hazelcast/hazelcast/releases{/id}","created_at":"2012-03-21T12:25:18Z","updated_at":"2015-10-06T06:03:08Z","pushed_at":"2015-10-06T12:17:45Z","git_url":"git://github.com/hazelcast/hazelcast.git","ssh_url":"git@github.com:hazelcast/hazelcast.git","clone_url":"https://github.com/hazelcast/hazelcast.git","svn_url":"https://github.com/hazelcast/hazelcast","homepage":"www.hazelcast.com","size":154633,"stargazers_count":1251,"watchers_count":1251,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":607,"mirror_url":null,"open_issues_count":527,"forks":607,"open_issues":527,"watchers":1251,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/6384"},"html":{"href":"https://github.com/hazelcast/hazelcast/pull/6384"},"issue":{"href":"https://api.github.com/repos/hazelcast/hazelcast/issues/6384"},"comments":{"href":"https://api.github.com/repos/hazelcast/hazelcast/issues/6384/comments"},"review_comments":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/6384/comments"},"review_comment":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/6384/commits"},"statuses":{"href":"https://api.github.com/repos/hazelcast/hazelcast/statuses/748f742ce10817c67353e78462dc4759071942cf"}}}}