{"action":"created","issue":{"url":"https://api.github.com/repos/JuliaDSP/DSP.jl/issues/101","labels_url":"https://api.github.com/repos/JuliaDSP/DSP.jl/issues/101/labels{/name}","comments_url":"https://api.github.com/repos/JuliaDSP/DSP.jl/issues/101/comments","events_url":"https://api.github.com/repos/JuliaDSP/DSP.jl/issues/101/events","html_url":"https://github.com/JuliaDSP/DSP.jl/pull/101","id":67231702,"number":101,"title":"Merge Multirate, pt. 2","user":{"login":"simonster","id":470884,"avatar_url":"https://avatars.githubusercontent.com/u/470884?v=3","gravatar_id":"","url":"https://api.github.com/users/simonster","html_url":"https://github.com/simonster","followers_url":"https://api.github.com/users/simonster/followers","following_url":"https://api.github.com/users/simonster/following{/other_user}","gists_url":"https://api.github.com/users/simonster/gists{/gist_id}","starred_url":"https://api.github.com/users/simonster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simonster/subscriptions","organizations_url":"https://api.github.com/users/simonster/orgs","repos_url":"https://api.github.com/users/simonster/repos","events_url":"https://api.github.com/users/simonster/events{/privacy}","received_events_url":"https://api.github.com/users/simonster/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":16,"created_at":"2015-04-08T22:14:37Z","updated_at":"2015-04-27T20:48:30Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/JuliaDSP/DSP.jl/pulls/101","html_url":"https://github.com/JuliaDSP/DSP.jl/pull/101","diff_url":"https://github.com/JuliaDSP/DSP.jl/pull/101.diff","patch_url":"https://github.com/JuliaDSP/DSP.jl/pull/101.patch"},"body":"@JayKickliter I did some work to try to get your multirate changes ready to merge. Overall, the code looks really good. The biggest thing I did was to change around the filter design API to make it more like the IIR design APIs. I also changed the code style to match what the rest of the package (I hope you don't mind) and fixed some deprecation warnings. If you disagree with any of this or if you see anything I've broken, let me know.\r\n\r\nI'll look over this again and I may make a few more changes. Thanks again for all your work on this!"},"comment":{"url":"https://api.github.com/repos/JuliaDSP/DSP.jl/issues/comments/96815342","html_url":"https://github.com/JuliaDSP/DSP.jl/pull/101#issuecomment-96815342","issue_url":"https://api.github.com/repos/JuliaDSP/DSP.jl/issues/101","id":96815342,"user":{"login":"simonster","id":470884,"avatar_url":"https://avatars.githubusercontent.com/u/470884?v=3","gravatar_id":"","url":"https://api.github.com/users/simonster","html_url":"https://github.com/simonster","followers_url":"https://api.github.com/users/simonster/followers","following_url":"https://api.github.com/users/simonster/following{/other_user}","gists_url":"https://api.github.com/users/simonster/gists{/gist_id}","starred_url":"https://api.github.com/users/simonster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simonster/subscriptions","organizations_url":"https://api.github.com/users/simonster/orgs","repos_url":"https://api.github.com/users/simonster/repos","events_url":"https://api.github.com/users/simonster/events{/privacy}","received_events_url":"https://api.github.com/users/simonster/received_events","type":"User","site_admin":false},"created_at":"2015-04-27T20:48:30Z","updated_at":"2015-04-27T20:48:30Z","body":"I looked into FIR filter design myself so as not to keep pestering you. It seemed like bandpass and bandstop design were effectively swapped, and I now avoid computing `sinc` in places where it will only be 0 or 1. Please double-check to make sure that this is right, but I guess it should be since it appears to match SciPy.\r\n\r\nI think we're almost ready to pull the trigger, but there are a few other questions that have arisen in my mind:\r\n\r\n- As I guess you've noticed, SciPy has a `scale` kwarg that rescales the filter so that it gives unity response somewhere, and it's enabled by default. Is this something we should have as well?\r\n- Perhaps `FIRWindow` is a better name than `WindowFIR`? What do you think?\r\n- I noticed that `naivefilt` isn't documented. Am I correct in assuming it's only really useful for checking the correctness of the more efficient multirate implementations, and we could just move it to the tests?"}}