{"action":"created","issue":{"url":"https://api.github.com/repos/chef/chef/issues/2084","labels_url":"https://api.github.com/repos/chef/chef/issues/2084/labels{/name}","comments_url":"https://api.github.com/repos/chef/chef/issues/2084/comments","events_url":"https://api.github.com/repos/chef/chef/issues/2084/events","html_url":"https://github.com/chef/chef/issues/2084","id":43115466,"number":2084,"title":"Delayed notifications running after failed chef run can cause broken configuration","user":{"login":"micmac","id":206625,"avatar_url":"https://avatars.githubusercontent.com/u/206625?v=3","gravatar_id":"","url":"https://api.github.com/users/micmac","html_url":"https://github.com/micmac","followers_url":"https://api.github.com/users/micmac/followers","following_url":"https://api.github.com/users/micmac/following{/other_user}","gists_url":"https://api.github.com/users/micmac/gists{/gist_id}","starred_url":"https://api.github.com/users/micmac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micmac/subscriptions","organizations_url":"https://api.github.com/users/micmac/orgs","repos_url":"https://api.github.com/users/micmac/repos","events_url":"https://api.github.com/users/micmac/events{/privacy}","received_events_url":"https://api.github.com/users/micmac/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/chef/chef/labels/Chef%20Core","name":"Chef Core","color":"c7def8"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2014-09-18T09:56:21Z","updated_at":"2015-04-29T17:11:15Z","closed_at":"2015-04-29T17:11:15Z","body":"If I generate a config file calling the template's :create action delayed after collecting all the needed parts during the chef run, calling the template after a failed chef run can cause some config parts missing, turning a mostly harmless chef breakage into a potential service outage.\r\n\r\nI've created a proof-of-concept fix, creating an additional option :only_on_success for notifications that causes them to not run if there was an exception earlier: https://github.com/micmac/chef/pull/1"},"comment":{"url":"https://api.github.com/repos/chef/chef/issues/comments/97506926","html_url":"https://github.com/chef/chef/issues/2084#issuecomment-97506926","issue_url":"https://api.github.com/repos/chef/chef/issues/2084","id":97506926,"user":{"login":"smurawski","id":4006985,"avatar_url":"https://avatars.githubusercontent.com/u/4006985?v=3","gravatar_id":"","url":"https://api.github.com/users/smurawski","html_url":"https://github.com/smurawski","followers_url":"https://api.github.com/users/smurawski/followers","following_url":"https://api.github.com/users/smurawski/following{/other_user}","gists_url":"https://api.github.com/users/smurawski/gists{/gist_id}","starred_url":"https://api.github.com/users/smurawski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smurawski/subscriptions","organizations_url":"https://api.github.com/users/smurawski/orgs","repos_url":"https://api.github.com/users/smurawski/repos","events_url":"https://api.github.com/users/smurawski/events{/privacy}","received_events_url":"https://api.github.com/users/smurawski/received_events","type":"User","site_admin":false},"created_at":"2015-04-29T17:11:15Z","updated_at":"2015-04-29T17:11:15Z","body":"@micmac You are welcome to submit a PR addressing this behavior, but this feels more like a workflow solution than a change in code.  This is not something we intend to pick up as a change.  Thanks!"}}