{"action":"created","comment":{"url":"https://api.github.com/repos/crowbar/barclamp-provisioner/pulls/comments/27340678","id":27340678,"diff_hunk":"@@ -359,8 +365,16 @@ fi\n # Steps from sledgehammer\n # -----------------------\n \n+MAC=$(cat /sys/class/net/$BOOTDEV/address)\n if test $KEEP_EXISTING_HOSTNAME -ne 1; then\n+  HOSTNAME=\"d${MAC//:/-}.${DOMAIN}\"\n   echo \"$HOSTNAME\" > /etc/HOSTNAME\n+else\n+  HOSTNAME=$(cat /etc/HOSTNAME)\n+  if ! echo \"$HOSTNAME\" | grep -q -o \"\\.$DOMAIN$\" || echo \"${HOSTNAME%%.$DOMAIN}\" | grep -q -o \"\\.\"; then\n+    echo \"The fully qualified domain name did not contain the $DOMAIN cloud domain.\"\n+    exit 1\n+  fi","path":"chef/cookbooks/provisioner/templates/suse/crowbar_register.erb","position":47,"original_position":35,"commit_id":"0210cbd3d33abb599959e254fdc5d47be0cc80f5","original_commit_id":"0f68723138fdfc94902e1ec00fa591f84f3ee1b8","user":{"login":"vuntz","id":1758783,"avatar_url":"https://avatars.githubusercontent.com/u/1758783?v=3","gravatar_id":"","url":"https://api.github.com/users/vuntz","html_url":"https://github.com/vuntz","followers_url":"https://api.github.com/users/vuntz/followers","following_url":"https://api.github.com/users/vuntz/following{/other_user}","gists_url":"https://api.github.com/users/vuntz/gists{/gist_id}","starred_url":"https://api.github.com/users/vuntz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vuntz/subscriptions","organizations_url":"https://api.github.com/users/vuntz/orgs","repos_url":"https://api.github.com/users/vuntz/repos","events_url":"https://api.github.com/users/vuntz/events{/privacy}","received_events_url":"https://api.github.com/users/vuntz/received_events","type":"User","site_admin":false},"body":"It's not removed, it's at https://github.com/rsalevsky/barclamp-provisioner/blob/keep_hostname_improvments/chef/cookbooks/provisioner/templates/suse/crowbar_register.erb#L254\r\n\r\nSo you need to update the code there.","created_at":"2015-03-28T01:00:40Z","updated_at":"2015-03-28T01:00:40Z","html_url":"https://github.com/crowbar/barclamp-provisioner/pull/403#discussion_r27340678","pull_request_url":"https://api.github.com/repos/crowbar/barclamp-provisioner/pulls/403","_links":{"self":{"href":"https://api.github.com/repos/crowbar/barclamp-provisioner/pulls/comments/27340678"},"html":{"href":"https://github.com/crowbar/barclamp-provisioner/pull/403#discussion_r27340678"},"pull_request":{"href":"https://api.github.com/repos/crowbar/barclamp-provisioner/pulls/403"}}},"pull_request":{"url":"https://api.github.com/repos/crowbar/barclamp-provisioner/pulls/403","id":30546514,"html_url":"https://github.com/crowbar/barclamp-provisioner/pull/403","diff_url":"https://github.com/crowbar/barclamp-provisioner/pull/403.diff","patch_url":"https://github.com/crowbar/barclamp-provisioner/pull/403.patch","issue_url":"https://api.github.com/repos/crowbar/barclamp-provisioner/issues/403","number":403,"state":"open","locked":false,"title":"Improve keep_existing_hostname handling in crowbar_register","user":{"login":"rsalevsky","id":4128547,"avatar_url":"https://avatars.githubusercontent.com/u/4128547?v=3","gravatar_id":"","url":"https://api.github.com/users/rsalevsky","html_url":"https://github.com/rsalevsky","followers_url":"https://api.github.com/users/rsalevsky/followers","following_url":"https://api.github.com/users/rsalevsky/following{/other_user}","gists_url":"https://api.github.com/users/rsalevsky/gists{/gist_id}","starred_url":"https://api.github.com/users/rsalevsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsalevsky/subscriptions","organizations_url":"https://api.github.com/users/rsalevsky/orgs","repos_url":"https://api.github.com/users/rsalevsky/repos","events_url":"https://api.github.com/users/rsalevsky/events{/privacy}","received_events_url":"https://api.github.com/users/rsalevsky/received_events","type":"User","site_admin":false},"body":"Improvements for #398","created_at":"2015-03-05T10:44:12Z","updated_at":"2015-03-28T01:00:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"32593c92e0e69959a5edb55de279dacbbcd9e4b1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/crowbar/barclamp-provisioner/pulls/403/commits","review_comments_url":"https://api.github.com/repos/crowbar/barclamp-provisioner/pulls/403/comments","review_comment_url":"https://api.github.com/repos/crowbar/barclamp-provisioner/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crowbar/barclamp-provisioner/issues/403/comments","statuses_url":"https://api.github.com/repos/crowbar/barclamp-provisioner/statuses/0210cbd3d33abb599959e254fdc5d47be0cc80f5","head":{"label":"rsalevsky:keep_hostname_improvments","ref":"keep_hostname_improvments","sha":"0210cbd3d33abb599959e254fdc5d47be0cc80f5","user":{"login":"rsalevsky","id":4128547,"avatar_url":"https://avatars.githubusercontent.com/u/4128547?v=3","gravatar_id":"","url":"https://api.github.com/users/rsalevsky","html_url":"https://github.com/rsalevsky","followers_url":"https://api.github.com/users/rsalevsky/followers","following_url":"https://api.github.com/users/rsalevsky/following{/other_user}","gists_url":"https://api.github.com/users/rsalevsky/gists{/gist_id}","starred_url":"https://api.github.com/users/rsalevsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsalevsky/subscriptions","organizations_url":"https://api.github.com/users/rsalevsky/orgs","repos_url":"https://api.github.com/users/rsalevsky/repos","events_url":"https://api.github.com/users/rsalevsky/events{/privacy}","received_events_url":"https://api.github.com/users/rsalevsky/received_events","type":"User","site_admin":false},"repo":{"id":31014904,"name":"barclamp-provisioner","full_name":"rsalevsky/barclamp-provisioner","owner":{"login":"rsalevsky","id":4128547,"avatar_url":"https://avatars.githubusercontent.com/u/4128547?v=3","gravatar_id":"","url":"https://api.github.com/users/rsalevsky","html_url":"https://github.com/rsalevsky","followers_url":"https://api.github.com/users/rsalevsky/followers","following_url":"https://api.github.com/users/rsalevsky/following{/other_user}","gists_url":"https://api.github.com/users/rsalevsky/gists{/gist_id}","starred_url":"https://api.github.com/users/rsalevsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsalevsky/subscriptions","organizations_url":"https://api.github.com/users/rsalevsky/orgs","repos_url":"https://api.github.com/users/rsalevsky/repos","events_url":"https://api.github.com/users/rsalevsky/events{/privacy}","received_events_url":"https://api.github.com/users/rsalevsky/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rsalevsky/barclamp-provisioner","description":"Crowbar Provisioner: Install Operating Systems","fork":true,"url":"https://api.github.com/repos/rsalevsky/barclamp-provisioner","forks_url":"https://api.github.com/repos/rsalevsky/barclamp-provisioner/forks","keys_url":"https://api.github.com/repos/rsalevsky/barclamp-provisioner/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rsalevsky/barclamp-provisioner/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rsalevsky/barclamp-provisioner/teams","hooks_url":"https://api.github.com/repos/rsalevsky/barclamp-provisioner/hooks","issue_events_url":"https://api.github.com/repos/rsalevsky/barclamp-provisioner/issues/events{/number}","events_url":"https://api.github.com/repos/rsalevsky/barclamp-provisioner/events","assignees_url":"https://api.github.com/repos/rsalevsky/barclamp-provisioner/assignees{/user}","branches_url":"https://api.github.com/repos/rsalevsky/barclamp-provisioner/branches{/branch}","tags_url":"https://api.github.com/repos/rsalevsky/barclamp-provisioner/tags","blobs_url":"https://api.github.com/repos/rsalevsky/barclamp-provisioner/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rsalevsky/barclamp-provisioner/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rsalevsky/barclamp-provisioner/git/refs{/sha}","trees_url":"https://api.github.com/repos/rsalevsky/barclamp-provisioner/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rsalevsky/barclamp-provisioner/statuses/{sha}","languages_url":"https://api.github.com/repos/rsalevsky/barclamp-provisioner/languages","stargazers_url":"https://api.github.com/repos/rsalevsky/barclamp-provisioner/stargazers","contributors_url":"https://api.github.com/repos/rsalevsky/barclamp-provisioner/contributors","subscribers_url":"https://api.github.com/repos/rsalevsky/barclamp-provisioner/subscribers","subscription_url":"https://api.github.com/repos/rsalevsky/barclamp-provisioner/subscription","commits_url":"https://api.github.com/repos/rsalevsky/barclamp-provisioner/commits{/sha}","git_commits_url":"https://api.github.com/repos/rsalevsky/barclamp-provisioner/git/commits{/sha}","comments_url":"https://api.github.com/repos/rsalevsky/barclamp-provisioner/comments{/number}","issue_comment_url":"https://api.github.com/repos/rsalevsky/barclamp-provisioner/issues/comments{/number}","contents_url":"https://api.github.com/repos/rsalevsky/barclamp-provisioner/contents/{+path}","compare_url":"https://api.github.com/repos/rsalevsky/barclamp-provisioner/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rsalevsky/barclamp-provisioner/merges","archive_url":"https://api.github.com/repos/rsalevsky/barclamp-provisioner/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rsalevsky/barclamp-provisioner/downloads","issues_url":"https://api.github.com/repos/rsalevsky/barclamp-provisioner/issues{/number}","pulls_url":"https://api.github.com/repos/rsalevsky/barclamp-provisioner/pulls{/number}","milestones_url":"https://api.github.com/repos/rsalevsky/barclamp-provisioner/milestones{/number}","notifications_url":"https://api.github.com/repos/rsalevsky/barclamp-provisioner/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rsalevsky/barclamp-provisioner/labels{/name}","releases_url":"https://api.github.com/repos/rsalevsky/barclamp-provisioner/releases{/id}","created_at":"2015-02-19T12:47:31Z","updated_at":"2015-03-06T15:14:57Z","pushed_at":"2015-03-27T12:08:23Z","git_url":"git://github.com/rsalevsky/barclamp-provisioner.git","ssh_url":"git@github.com:rsalevsky/barclamp-provisioner.git","clone_url":"https://github.com/rsalevsky/barclamp-provisioner.git","svn_url":"https://github.com/rsalevsky/barclamp-provisioner","homepage":"https://github.com/crowbar/crowbar","size":64461,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"crowbar:master","ref":"master","sha":"94417885fdcce309bd43694541a13ea63324010c","user":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars.githubusercontent.com/u/2910205?v=3","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"repo":{"id":2351609,"name":"barclamp-provisioner","full_name":"crowbar/barclamp-provisioner","owner":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars.githubusercontent.com/u/2910205?v=3","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crowbar/barclamp-provisioner","description":"Crowbar Provisioner: Install Operating Systems","fork":false,"url":"https://api.github.com/repos/crowbar/barclamp-provisioner","forks_url":"https://api.github.com/repos/crowbar/barclamp-provisioner/forks","keys_url":"https://api.github.com/repos/crowbar/barclamp-provisioner/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crowbar/barclamp-provisioner/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crowbar/barclamp-provisioner/teams","hooks_url":"https://api.github.com/repos/crowbar/barclamp-provisioner/hooks","issue_events_url":"https://api.github.com/repos/crowbar/barclamp-provisioner/issues/events{/number}","events_url":"https://api.github.com/repos/crowbar/barclamp-provisioner/events","assignees_url":"https://api.github.com/repos/crowbar/barclamp-provisioner/assignees{/user}","branches_url":"https://api.github.com/repos/crowbar/barclamp-provisioner/branches{/branch}","tags_url":"https://api.github.com/repos/crowbar/barclamp-provisioner/tags","blobs_url":"https://api.github.com/repos/crowbar/barclamp-provisioner/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crowbar/barclamp-provisioner/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crowbar/barclamp-provisioner/git/refs{/sha}","trees_url":"https://api.github.com/repos/crowbar/barclamp-provisioner/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crowbar/barclamp-provisioner/statuses/{sha}","languages_url":"https://api.github.com/repos/crowbar/barclamp-provisioner/languages","stargazers_url":"https://api.github.com/repos/crowbar/barclamp-provisioner/stargazers","contributors_url":"https://api.github.com/repos/crowbar/barclamp-provisioner/contributors","subscribers_url":"https://api.github.com/repos/crowbar/barclamp-provisioner/subscribers","subscription_url":"https://api.github.com/repos/crowbar/barclamp-provisioner/subscription","commits_url":"https://api.github.com/repos/crowbar/barclamp-provisioner/commits{/sha}","git_commits_url":"https://api.github.com/repos/crowbar/barclamp-provisioner/git/commits{/sha}","comments_url":"https://api.github.com/repos/crowbar/barclamp-provisioner/comments{/number}","issue_comment_url":"https://api.github.com/repos/crowbar/barclamp-provisioner/issues/comments{/number}","contents_url":"https://api.github.com/repos/crowbar/barclamp-provisioner/contents/{+path}","compare_url":"https://api.github.com/repos/crowbar/barclamp-provisioner/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crowbar/barclamp-provisioner/merges","archive_url":"https://api.github.com/repos/crowbar/barclamp-provisioner/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crowbar/barclamp-provisioner/downloads","issues_url":"https://api.github.com/repos/crowbar/barclamp-provisioner/issues{/number}","pulls_url":"https://api.github.com/repos/crowbar/barclamp-provisioner/pulls{/number}","milestones_url":"https://api.github.com/repos/crowbar/barclamp-provisioner/milestones{/number}","notifications_url":"https://api.github.com/repos/crowbar/barclamp-provisioner/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crowbar/barclamp-provisioner/labels{/name}","releases_url":"https://api.github.com/repos/crowbar/barclamp-provisioner/releases{/id}","created_at":"2011-09-08T21:20:51Z","updated_at":"2015-03-26T09:46:20Z","pushed_at":"2015-03-27T16:07:03Z","git_url":"git://github.com/crowbar/barclamp-provisioner.git","ssh_url":"git@github.com:crowbar/barclamp-provisioner.git","clone_url":"https://github.com/crowbar/barclamp-provisioner.git","svn_url":"https://github.com/crowbar/barclamp-provisioner","homepage":"https://github.com/crowbar/crowbar","size":66493,"stargazers_count":61,"watchers_count":61,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":185,"mirror_url":null,"open_issues_count":9,"forks":185,"open_issues":9,"watchers":61,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crowbar/barclamp-provisioner/pulls/403"},"html":{"href":"https://github.com/crowbar/barclamp-provisioner/pull/403"},"issue":{"href":"https://api.github.com/repos/crowbar/barclamp-provisioner/issues/403"},"comments":{"href":"https://api.github.com/repos/crowbar/barclamp-provisioner/issues/403/comments"},"review_comments":{"href":"https://api.github.com/repos/crowbar/barclamp-provisioner/pulls/403/comments"},"review_comment":{"href":"https://api.github.com/repos/crowbar/barclamp-provisioner/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crowbar/barclamp-provisioner/pulls/403/commits"},"statuses":{"href":"https://api.github.com/repos/crowbar/barclamp-provisioner/statuses/0210cbd3d33abb599959e254fdc5d47be0cc80f5"}}}}