{"action":"created","issue":{"url":"https://api.github.com/repos/netty/netty/issues/3740","labels_url":"https://api.github.com/repos/netty/netty/issues/3740/labels{/name}","comments_url":"https://api.github.com/repos/netty/netty/issues/3740/comments","events_url":"https://api.github.com/repos/netty/netty/issues/3740/events","html_url":"https://github.com/netty/netty/pull/3740","id":73507728,"number":3740,"title":"Not trigger channelWritabilityChanged if fail messages before close Chan...","user":{"login":"normanmaurer","id":439362,"avatar_url":"https://avatars.githubusercontent.com/u/439362?v=3","gravatar_id":"","url":"https://api.github.com/users/normanmaurer","html_url":"https://github.com/normanmaurer","followers_url":"https://api.github.com/users/normanmaurer/followers","following_url":"https://api.github.com/users/normanmaurer/following{/other_user}","gists_url":"https://api.github.com/users/normanmaurer/gists{/gist_id}","starred_url":"https://api.github.com/users/normanmaurer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/normanmaurer/subscriptions","organizations_url":"https://api.github.com/users/normanmaurer/orgs","repos_url":"https://api.github.com/users/normanmaurer/repos","events_url":"https://api.github.com/users/normanmaurer/events{/privacy}","received_events_url":"https://api.github.com/users/normanmaurer/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-05-06T04:07:05Z","updated_at":"2015-05-06T05:50:19Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/netty/netty/pulls/3740","html_url":"https://github.com/netty/netty/pull/3740","diff_url":"https://github.com/netty/netty/pull/3740.diff","patch_url":"https://github.com/netty/netty/pull/3740.patch"},"body":"...nel.\r\n\r\nMotivation:\r\n\r\nWe should not trigger channelWritabilityChanged during failing message when we are about to close the Channel as otherwise the use may try again writing even if the Channel is about to get closed.\r\n\r\nModifications:\r\n\r\nAdd new boolean param to ChannelOutboundBuffer.failFlushed(...) which allows to specify if we should notify or not.\r\n\r\nResult:\r\n\r\nchannelWritabilityChanged is not triggered anymore if we cloe the Channel because of an IOException during write."},"comment":{"url":"https://api.github.com/repos/netty/netty/issues/comments/99331414","html_url":"https://github.com/netty/netty/pull/3740#issuecomment-99331414","issue_url":"https://api.github.com/repos/netty/netty/issues/3740","id":99331414,"user":{"login":"trustin","id":173918,"avatar_url":"https://avatars.githubusercontent.com/u/173918?v=3","gravatar_id":"","url":"https://api.github.com/users/trustin","html_url":"https://github.com/trustin","followers_url":"https://api.github.com/users/trustin/followers","following_url":"https://api.github.com/users/trustin/following{/other_user}","gists_url":"https://api.github.com/users/trustin/gists{/gist_id}","starred_url":"https://api.github.com/users/trustin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trustin/subscriptions","organizations_url":"https://api.github.com/users/trustin/orgs","repos_url":"https://api.github.com/users/trustin/repos","events_url":"https://api.github.com/users/trustin/events{/privacy}","received_events_url":"https://api.github.com/users/trustin/received_events","type":"User","site_admin":false},"created_at":"2015-05-06T05:50:19Z","updated_at":"2015-05-06T05:50:19Z","body":"Please feel free to cherry-pick after addressing the comments."}}