{"action":"created","comment":{"url":"https://api.github.com/repos/guardian/membership-frontend/pulls/comments/42104888","id":42104888,"diff_hunk":"@@ -0,0 +1,65 @@\n+/**\n+ * This file:\n+ * Controls the listeners for the identity icon menu found in the header\n+ * Controls the html document listener to close the identity icon menu\n+ * Sets the identity icon returnUrl when a user needs to sign in (controlled via JavaScript for caching reasons)\n+ */\n+define([\n+    '$',\n+    'bean'\n+], function ($, bean) {\n+    'use strict';\n+\n+    var HOVER_CLASS = 'is-hover';\n+    var ACTIVE_CLASS = 'is-active';\n+    var COMPARISON_TABLE = document.querySelector('.comparison-table');\n+\n+    function init() {\n+        addHoverListeners();\n+        addClickListeners();\n+    }\n+\n+    function addClassToTier(clazz, tier) {\n+        var tierElems = COMPARISON_TABLE.querySelectorAll('.comparison-table--clickable[data-tier=\"'+tier+'\"]');","path":"frontend/assets/javascripts/src/modules/comparisonTable.js","position":23,"original_position":23,"commit_id":"e2984ef60eeb8fa413380ae3d21c42386901714a","original_commit_id":"e2984ef60eeb8fa413380ae3d21c42386901714a","user":{"login":"davidrapson","id":123386,"avatar_url":"https://avatars.githubusercontent.com/u/123386?v=3","gravatar_id":"","url":"https://api.github.com/users/davidrapson","html_url":"https://github.com/davidrapson","followers_url":"https://api.github.com/users/davidrapson/followers","following_url":"https://api.github.com/users/davidrapson/following{/other_user}","gists_url":"https://api.github.com/users/davidrapson/gists{/gist_id}","starred_url":"https://api.github.com/users/davidrapson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidrapson/subscriptions","organizations_url":"https://api.github.com/users/davidrapson/orgs","repos_url":"https://api.github.com/users/davidrapson/repos","events_url":"https://api.github.com/users/davidrapson/events{/privacy}","received_events_url":"https://api.github.com/users/davidrapson/received_events","type":"User","site_admin":false},"body":"Also, use a [`js-` prefixed class](https://github.com/guardian/membership-frontend/blob/master/docs/client-side-principles.md#javascript) here please","created_at":"2015-10-15T10:10:21Z","updated_at":"2015-10-15T10:10:21Z","html_url":"https://github.com/guardian/membership-frontend/pull/804#discussion_r42104888","pull_request_url":"https://api.github.com/repos/guardian/membership-frontend/pulls/804","_links":{"self":{"href":"https://api.github.com/repos/guardian/membership-frontend/pulls/comments/42104888"},"html":{"href":"https://github.com/guardian/membership-frontend/pull/804#discussion_r42104888"},"pull_request":{"href":"https://api.github.com/repos/guardian/membership-frontend/pulls/804"}}},"pull_request":{"url":"https://api.github.com/repos/guardian/membership-frontend/pulls/804","id":47757403,"html_url":"https://github.com/guardian/membership-frontend/pull/804","diff_url":"https://github.com/guardian/membership-frontend/pull/804.diff","patch_url":"https://github.com/guardian/membership-frontend/pull/804.patch","issue_url":"https://api.github.com/repos/guardian/membership-frontend/issues/804","number":804,"state":"open","locked":false,"title":"Add patron column","user":{"login":"joelochlann","id":5122968,"avatar_url":"https://avatars.githubusercontent.com/u/5122968?v=3","gravatar_id":"","url":"https://api.github.com/users/joelochlann","html_url":"https://github.com/joelochlann","followers_url":"https://api.github.com/users/joelochlann/followers","following_url":"https://api.github.com/users/joelochlann/following{/other_user}","gists_url":"https://api.github.com/users/joelochlann/gists{/gist_id}","starred_url":"https://api.github.com/users/joelochlann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joelochlann/subscriptions","organizations_url":"https://api.github.com/users/joelochlann/orgs","repos_url":"https://api.github.com/users/joelochlann/repos","events_url":"https://api.github.com/users/joelochlann/events{/privacy}","received_events_url":"https://api.github.com/users/joelochlann/received_events","type":"User","site_admin":false},"body":"This PR adds a patron column to the comparison table on the homepage and to the package promos above it. Along with this, it makes wide-reaching changes to the layout of the package promo component which affect every page where that component appears. Broadly these are:\r\n\r\n- Mobile view will change to include full details, everywhere this component appears in the site\r\n- Desktop view will be stacked vertically (as per design) on the homepage only. Elsewhere we will leave the column view in place.\r\n\r\nI've also fixed the an issue with the 3-column promo layout. On tablet, previously these tried to stay as columns despite the fact that there wasn't enough space for their contents. Now they change as follows:\r\n\r\n- Mobile = stacked (previously without details, now with details)\r\n- Tablet = stacked with details\r\n- Desktop = three columns\r\n\r\nTable before:\r\n![picture 10](https://cloud.githubusercontent.com/assets/5122968/10508420/ff66cf2e-731e-11e5-8513-7096d6d7df7d.png)\r\n\r\nTable after:\r\n![picture 12](https://cloud.githubusercontent.com/assets/5122968/10508427/06f422fa-731f-11e5-9f2b-cb4f6a6e7ca5.png)\r\n\r\nPackage promos before:\r\n![picture 9](https://cloud.githubusercontent.com/assets/5122968/10508440/11227e98-731f-11e5-8be0-00c9ae115867.png)\r\n\r\nPackage promos after:\r\n![picture 11](https://cloud.githubusercontent.com/assets/5122968/10508453/1c04ed5a-731f-11e5-8d2a-ee500ac7afaa.png)\r\n\r\nMobile before:\r\n![picture 13](https://cloud.githubusercontent.com/assets/5122968/10508471/358b369e-731f-11e5-925b-99be57a31600.png)\r\n\r\nMobile after:\r\n![picture 14](https://cloud.githubusercontent.com/assets/5122968/10508481/4ecb4982-731f-11e5-8a08-ab978513b679.png)\r\n![picture 15](https://cloud.githubusercontent.com/assets/5122968/10508482/50707d3e-731f-11e5-9562-c7a30ec1610a.png)\r\n\r\nBroken tablet view before:\r\n![picture 17](https://cloud.githubusercontent.com/assets/5122968/10508498/642cce0e-731f-11e5-9ad8-6663ed7db20d.png)\r\n\r\nFixed tablet view:\r\n![picture 18](https://cloud.githubusercontent.com/assets/5122968/10508510/74ebaf08-731f-11e5-942c-2caba133a687.png)\r\n\r\n@davidrapson \r\n\r\n\r\n\r\n","created_at":"2015-10-15T08:31:46Z","updated_at":"2015-10-15T10:10:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a31f35d7189c51dbea717486be9e5e90e2c1ba4a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/guardian/membership-frontend/pulls/804/commits","review_comments_url":"https://api.github.com/repos/guardian/membership-frontend/pulls/804/comments","review_comment_url":"https://api.github.com/repos/guardian/membership-frontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/guardian/membership-frontend/issues/804/comments","statuses_url":"https://api.github.com/repos/guardian/membership-frontend/statuses/e2984ef60eeb8fa413380ae3d21c42386901714a","head":{"label":"guardian:add-patron-column","ref":"add-patron-column","sha":"e2984ef60eeb8fa413380ae3d21c42386901714a","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":28401521,"name":"membership-frontend","full_name":"guardian/membership-frontend","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/membership-frontend","description":"Bringing the Guardian to life through live events and meet-ups","fork":false,"url":"https://api.github.com/repos/guardian/membership-frontend","forks_url":"https://api.github.com/repos/guardian/membership-frontend/forks","keys_url":"https://api.github.com/repos/guardian/membership-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/membership-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/membership-frontend/teams","hooks_url":"https://api.github.com/repos/guardian/membership-frontend/hooks","issue_events_url":"https://api.github.com/repos/guardian/membership-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/membership-frontend/events","assignees_url":"https://api.github.com/repos/guardian/membership-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/membership-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/membership-frontend/tags","blobs_url":"https://api.github.com/repos/guardian/membership-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/membership-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/membership-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/membership-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/membership-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/membership-frontend/languages","stargazers_url":"https://api.github.com/repos/guardian/membership-frontend/stargazers","contributors_url":"https://api.github.com/repos/guardian/membership-frontend/contributors","subscribers_url":"https://api.github.com/repos/guardian/membership-frontend/subscribers","subscription_url":"https://api.github.com/repos/guardian/membership-frontend/subscription","commits_url":"https://api.github.com/repos/guardian/membership-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/membership-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/membership-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/membership-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/guardian/membership-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/membership-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/membership-frontend/merges","archive_url":"https://api.github.com/repos/guardian/membership-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/membership-frontend/downloads","issues_url":"https://api.github.com/repos/guardian/membership-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/membership-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/membership-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/membership-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/membership-frontend/labels{/name}","releases_url":"https://api.github.com/repos/guardian/membership-frontend/releases{/id}","created_at":"2014-12-23T14:14:38Z","updated_at":"2015-10-14T23:06:45Z","pushed_at":"2015-10-15T10:09:41Z","git_url":"git://github.com/guardian/membership-frontend.git","ssh_url":"git@github.com:guardian/membership-frontend.git","clone_url":"https://github.com/guardian/membership-frontend.git","svn_url":"https://github.com/guardian/membership-frontend","homepage":"https://membership.theguardian.com/","size":44237,"stargazers_count":15,"watchers_count":15,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":3,"forks":6,"open_issues":3,"watchers":15,"default_branch":"master"}},"base":{"label":"guardian:master","ref":"master","sha":"41450808c560facc8f0c7a04f0fb7b6de33e5908","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":28401521,"name":"membership-frontend","full_name":"guardian/membership-frontend","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/membership-frontend","description":"Bringing the Guardian to life through live events and meet-ups","fork":false,"url":"https://api.github.com/repos/guardian/membership-frontend","forks_url":"https://api.github.com/repos/guardian/membership-frontend/forks","keys_url":"https://api.github.com/repos/guardian/membership-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/membership-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/membership-frontend/teams","hooks_url":"https://api.github.com/repos/guardian/membership-frontend/hooks","issue_events_url":"https://api.github.com/repos/guardian/membership-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/membership-frontend/events","assignees_url":"https://api.github.com/repos/guardian/membership-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/membership-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/membership-frontend/tags","blobs_url":"https://api.github.com/repos/guardian/membership-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/membership-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/membership-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/membership-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/membership-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/membership-frontend/languages","stargazers_url":"https://api.github.com/repos/guardian/membership-frontend/stargazers","contributors_url":"https://api.github.com/repos/guardian/membership-frontend/contributors","subscribers_url":"https://api.github.com/repos/guardian/membership-frontend/subscribers","subscription_url":"https://api.github.com/repos/guardian/membership-frontend/subscription","commits_url":"https://api.github.com/repos/guardian/membership-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/membership-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/membership-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/membership-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/guardian/membership-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/membership-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/membership-frontend/merges","archive_url":"https://api.github.com/repos/guardian/membership-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/membership-frontend/downloads","issues_url":"https://api.github.com/repos/guardian/membership-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/membership-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/membership-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/membership-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/membership-frontend/labels{/name}","releases_url":"https://api.github.com/repos/guardian/membership-frontend/releases{/id}","created_at":"2014-12-23T14:14:38Z","updated_at":"2015-10-14T23:06:45Z","pushed_at":"2015-10-15T10:09:41Z","git_url":"git://github.com/guardian/membership-frontend.git","ssh_url":"git@github.com:guardian/membership-frontend.git","clone_url":"https://github.com/guardian/membership-frontend.git","svn_url":"https://github.com/guardian/membership-frontend","homepage":"https://membership.theguardian.com/","size":44237,"stargazers_count":15,"watchers_count":15,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":3,"forks":6,"open_issues":3,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/guardian/membership-frontend/pulls/804"},"html":{"href":"https://github.com/guardian/membership-frontend/pull/804"},"issue":{"href":"https://api.github.com/repos/guardian/membership-frontend/issues/804"},"comments":{"href":"https://api.github.com/repos/guardian/membership-frontend/issues/804/comments"},"review_comments":{"href":"https://api.github.com/repos/guardian/membership-frontend/pulls/804/comments"},"review_comment":{"href":"https://api.github.com/repos/guardian/membership-frontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/guardian/membership-frontend/pulls/804/commits"},"statuses":{"href":"https://api.github.com/repos/guardian/membership-frontend/statuses/e2984ef60eeb8fa413380ae3d21c42386901714a"}}}}