{"action":"created","comment":{"url":"https://api.github.com/repos/francisco-dlp/hyperspy/pulls/comments/47259453","id":47259453,"diff_hunk":"@@ -54,16 +103,51 @@ def suppress(self):\n             obj.val_b = b\n         obj.events.values_changed.trigger()\n         \"\"\"\n-        return EventSuppressionContext(self)\n+        return EventsSuppressionContext(self)\n \n \n class Event(object):\n \n     def __init__(self):\n         self._connected = {}\n-        self.suppress = False\n+        self._suppress = False\n+\n+    def suppress(self, function=None):","path":"hyperspy/events.py","position":118,"original_position":118,"commit_id":"5b3bffe48dba33635223afb72122d63c0e88d896","original_commit_id":"5b3bffe48dba33635223afb72122d63c0e88d896","user":{"login":"francisco-dlp","id":989719,"avatar_url":"https://avatars.githubusercontent.com/u/989719?v=3","gravatar_id":"","url":"https://api.github.com/users/francisco-dlp","html_url":"https://github.com/francisco-dlp","followers_url":"https://api.github.com/users/francisco-dlp/followers","following_url":"https://api.github.com/users/francisco-dlp/following{/other_user}","gists_url":"https://api.github.com/users/francisco-dlp/gists{/gist_id}","starred_url":"https://api.github.com/users/francisco-dlp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/francisco-dlp/subscriptions","organizations_url":"https://api.github.com/users/francisco-dlp/orgs","repos_url":"https://api.github.com/users/francisco-dlp/repos","events_url":"https://api.github.com/users/francisco-dlp/events{/privacy}","received_events_url":"https://api.github.com/users/francisco-dlp/received_events","type":"User","site_admin":false},"body":"I think that it'll be better to explit this method in two: `supressed` and `callback_supressed`. In this way `supressed` can be a property just like `Events.suppress`.","created_at":"2015-12-10T17:53:21Z","updated_at":"2015-12-10T17:53:21Z","html_url":"https://github.com/francisco-dlp/hyperspy/pull/21#discussion_r47259453","pull_request_url":"https://api.github.com/repos/francisco-dlp/hyperspy/pulls/21","_links":{"self":{"href":"https://api.github.com/repos/francisco-dlp/hyperspy/pulls/comments/47259453"},"html":{"href":"https://github.com/francisco-dlp/hyperspy/pull/21#discussion_r47259453"},"pull_request":{"href":"https://api.github.com/repos/francisco-dlp/hyperspy/pulls/21"}}},"pull_request":{"url":"https://api.github.com/repos/francisco-dlp/hyperspy/pulls/21","id":53281777,"html_url":"https://github.com/francisco-dlp/hyperspy/pull/21","diff_url":"https://github.com/francisco-dlp/hyperspy/pull/21.diff","patch_url":"https://github.com/francisco-dlp/hyperspy/pull/21.patch","issue_url":"https://api.github.com/repos/francisco-dlp/hyperspy/issues/21","number":21,"state":"open","locked":false,"title":"Events improvements","user":{"login":"vidartf","id":510760,"avatar_url":"https://avatars.githubusercontent.com/u/510760?v=3","gravatar_id":"","url":"https://api.github.com/users/vidartf","html_url":"https://github.com/vidartf","followers_url":"https://api.github.com/users/vidartf/followers","following_url":"https://api.github.com/users/vidartf/following{/other_user}","gists_url":"https://api.github.com/users/vidartf/gists{/gist_id}","starred_url":"https://api.github.com/users/vidartf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vidartf/subscriptions","organizations_url":"https://api.github.com/users/vidartf/orgs","repos_url":"https://api.github.com/users/vidartf/repos","events_url":"https://api.github.com/users/vidartf/events{/privacy}","received_events_url":"https://api.github.com/users/vidartf/received_events","type":"User","site_admin":false},"body":"Adds some additional suppression controls, fixes one or two bugs, and adds a `close` event to markers.","created_at":"2015-12-10T16:28:38Z","updated_at":"2015-12-10T17:53:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f736492bc72dc560484b560c7cfd735bade20c0e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/francisco-dlp/hyperspy/pulls/21/commits","review_comments_url":"https://api.github.com/repos/francisco-dlp/hyperspy/pulls/21/comments","review_comment_url":"https://api.github.com/repos/francisco-dlp/hyperspy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/francisco-dlp/hyperspy/issues/21/comments","statuses_url":"https://api.github.com/repos/francisco-dlp/hyperspy/statuses/5b3bffe48dba33635223afb72122d63c0e88d896","head":{"label":"vidartf:NEW_Events_PR","ref":"NEW_Events_PR","sha":"5b3bffe48dba33635223afb72122d63c0e88d896","user":{"login":"vidartf","id":510760,"avatar_url":"https://avatars.githubusercontent.com/u/510760?v=3","gravatar_id":"","url":"https://api.github.com/users/vidartf","html_url":"https://github.com/vidartf","followers_url":"https://api.github.com/users/vidartf/followers","following_url":"https://api.github.com/users/vidartf/following{/other_user}","gists_url":"https://api.github.com/users/vidartf/gists{/gist_id}","starred_url":"https://api.github.com/users/vidartf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vidartf/subscriptions","organizations_url":"https://api.github.com/users/vidartf/orgs","repos_url":"https://api.github.com/users/vidartf/repos","events_url":"https://api.github.com/users/vidartf/events{/privacy}","received_events_url":"https://api.github.com/users/vidartf/received_events","type":"User","site_admin":false},"repo":{"id":17872313,"name":"hyperspy","full_name":"vidartf/hyperspy","owner":{"login":"vidartf","id":510760,"avatar_url":"https://avatars.githubusercontent.com/u/510760?v=3","gravatar_id":"","url":"https://api.github.com/users/vidartf","html_url":"https://github.com/vidartf","followers_url":"https://api.github.com/users/vidartf/followers","following_url":"https://api.github.com/users/vidartf/following{/other_user}","gists_url":"https://api.github.com/users/vidartf/gists{/gist_id}","starred_url":"https://api.github.com/users/vidartf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vidartf/subscriptions","organizations_url":"https://api.github.com/users/vidartf/orgs","repos_url":"https://api.github.com/users/vidartf/repos","events_url":"https://api.github.com/users/vidartf/events{/privacy}","received_events_url":"https://api.github.com/users/vidartf/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vidartf/hyperspy","description":"Multidimensional data analysis","fork":true,"url":"https://api.github.com/repos/vidartf/hyperspy","forks_url":"https://api.github.com/repos/vidartf/hyperspy/forks","keys_url":"https://api.github.com/repos/vidartf/hyperspy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vidartf/hyperspy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vidartf/hyperspy/teams","hooks_url":"https://api.github.com/repos/vidartf/hyperspy/hooks","issue_events_url":"https://api.github.com/repos/vidartf/hyperspy/issues/events{/number}","events_url":"https://api.github.com/repos/vidartf/hyperspy/events","assignees_url":"https://api.github.com/repos/vidartf/hyperspy/assignees{/user}","branches_url":"https://api.github.com/repos/vidartf/hyperspy/branches{/branch}","tags_url":"https://api.github.com/repos/vidartf/hyperspy/tags","blobs_url":"https://api.github.com/repos/vidartf/hyperspy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vidartf/hyperspy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vidartf/hyperspy/git/refs{/sha}","trees_url":"https://api.github.com/repos/vidartf/hyperspy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vidartf/hyperspy/statuses/{sha}","languages_url":"https://api.github.com/repos/vidartf/hyperspy/languages","stargazers_url":"https://api.github.com/repos/vidartf/hyperspy/stargazers","contributors_url":"https://api.github.com/repos/vidartf/hyperspy/contributors","subscribers_url":"https://api.github.com/repos/vidartf/hyperspy/subscribers","subscription_url":"https://api.github.com/repos/vidartf/hyperspy/subscription","commits_url":"https://api.github.com/repos/vidartf/hyperspy/commits{/sha}","git_commits_url":"https://api.github.com/repos/vidartf/hyperspy/git/commits{/sha}","comments_url":"https://api.github.com/repos/vidartf/hyperspy/comments{/number}","issue_comment_url":"https://api.github.com/repos/vidartf/hyperspy/issues/comments{/number}","contents_url":"https://api.github.com/repos/vidartf/hyperspy/contents/{+path}","compare_url":"https://api.github.com/repos/vidartf/hyperspy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vidartf/hyperspy/merges","archive_url":"https://api.github.com/repos/vidartf/hyperspy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vidartf/hyperspy/downloads","issues_url":"https://api.github.com/repos/vidartf/hyperspy/issues{/number}","pulls_url":"https://api.github.com/repos/vidartf/hyperspy/pulls{/number}","milestones_url":"https://api.github.com/repos/vidartf/hyperspy/milestones{/number}","notifications_url":"https://api.github.com/repos/vidartf/hyperspy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vidartf/hyperspy/labels{/name}","releases_url":"https://api.github.com/repos/vidartf/hyperspy/releases{/id}","created_at":"2014-03-18T16:04:56Z","updated_at":"2015-09-24T14:23:06Z","pushed_at":"2015-12-10T16:34:23Z","git_url":"git://github.com/vidartf/hyperspy.git","ssh_url":"git@github.com:vidartf/hyperspy.git","clone_url":"https://github.com/vidartf/hyperspy.git","svn_url":"https://github.com/vidartf/hyperspy","homepage":"http://www.hyperspy.org","size":71060,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"francisco-dlp:NEW_Events","ref":"NEW_Events","sha":"6c8b857a585146aef6880f41c990cd67e8c5686a","user":{"login":"francisco-dlp","id":989719,"avatar_url":"https://avatars.githubusercontent.com/u/989719?v=3","gravatar_id":"","url":"https://api.github.com/users/francisco-dlp","html_url":"https://github.com/francisco-dlp","followers_url":"https://api.github.com/users/francisco-dlp/followers","following_url":"https://api.github.com/users/francisco-dlp/following{/other_user}","gists_url":"https://api.github.com/users/francisco-dlp/gists{/gist_id}","starred_url":"https://api.github.com/users/francisco-dlp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/francisco-dlp/subscriptions","organizations_url":"https://api.github.com/users/francisco-dlp/orgs","repos_url":"https://api.github.com/users/francisco-dlp/repos","events_url":"https://api.github.com/users/francisco-dlp/events{/privacy}","received_events_url":"https://api.github.com/users/francisco-dlp/received_events","type":"User","site_admin":false},"repo":{"id":10522613,"name":"hyperspy","full_name":"francisco-dlp/hyperspy","owner":{"login":"francisco-dlp","id":989719,"avatar_url":"https://avatars.githubusercontent.com/u/989719?v=3","gravatar_id":"","url":"https://api.github.com/users/francisco-dlp","html_url":"https://github.com/francisco-dlp","followers_url":"https://api.github.com/users/francisco-dlp/followers","following_url":"https://api.github.com/users/francisco-dlp/following{/other_user}","gists_url":"https://api.github.com/users/francisco-dlp/gists{/gist_id}","starred_url":"https://api.github.com/users/francisco-dlp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/francisco-dlp/subscriptions","organizations_url":"https://api.github.com/users/francisco-dlp/orgs","repos_url":"https://api.github.com/users/francisco-dlp/repos","events_url":"https://api.github.com/users/francisco-dlp/events{/privacy}","received_events_url":"https://api.github.com/users/francisco-dlp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/francisco-dlp/hyperspy","description":"A toolbox for hyperspectra data analysis","fork":true,"url":"https://api.github.com/repos/francisco-dlp/hyperspy","forks_url":"https://api.github.com/repos/francisco-dlp/hyperspy/forks","keys_url":"https://api.github.com/repos/francisco-dlp/hyperspy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/francisco-dlp/hyperspy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/francisco-dlp/hyperspy/teams","hooks_url":"https://api.github.com/repos/francisco-dlp/hyperspy/hooks","issue_events_url":"https://api.github.com/repos/francisco-dlp/hyperspy/issues/events{/number}","events_url":"https://api.github.com/repos/francisco-dlp/hyperspy/events","assignees_url":"https://api.github.com/repos/francisco-dlp/hyperspy/assignees{/user}","branches_url":"https://api.github.com/repos/francisco-dlp/hyperspy/branches{/branch}","tags_url":"https://api.github.com/repos/francisco-dlp/hyperspy/tags","blobs_url":"https://api.github.com/repos/francisco-dlp/hyperspy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/francisco-dlp/hyperspy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/francisco-dlp/hyperspy/git/refs{/sha}","trees_url":"https://api.github.com/repos/francisco-dlp/hyperspy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/francisco-dlp/hyperspy/statuses/{sha}","languages_url":"https://api.github.com/repos/francisco-dlp/hyperspy/languages","stargazers_url":"https://api.github.com/repos/francisco-dlp/hyperspy/stargazers","contributors_url":"https://api.github.com/repos/francisco-dlp/hyperspy/contributors","subscribers_url":"https://api.github.com/repos/francisco-dlp/hyperspy/subscribers","subscription_url":"https://api.github.com/repos/francisco-dlp/hyperspy/subscription","commits_url":"https://api.github.com/repos/francisco-dlp/hyperspy/commits{/sha}","git_commits_url":"https://api.github.com/repos/francisco-dlp/hyperspy/git/commits{/sha}","comments_url":"https://api.github.com/repos/francisco-dlp/hyperspy/comments{/number}","issue_comment_url":"https://api.github.com/repos/francisco-dlp/hyperspy/issues/comments{/number}","contents_url":"https://api.github.com/repos/francisco-dlp/hyperspy/contents/{+path}","compare_url":"https://api.github.com/repos/francisco-dlp/hyperspy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/francisco-dlp/hyperspy/merges","archive_url":"https://api.github.com/repos/francisco-dlp/hyperspy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/francisco-dlp/hyperspy/downloads","issues_url":"https://api.github.com/repos/francisco-dlp/hyperspy/issues{/number}","pulls_url":"https://api.github.com/repos/francisco-dlp/hyperspy/pulls{/number}","milestones_url":"https://api.github.com/repos/francisco-dlp/hyperspy/milestones{/number}","notifications_url":"https://api.github.com/repos/francisco-dlp/hyperspy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/francisco-dlp/hyperspy/labels{/name}","releases_url":"https://api.github.com/repos/francisco-dlp/hyperspy/releases{/id}","created_at":"2013-06-06T09:01:00Z","updated_at":"2015-04-07T09:32:13Z","pushed_at":"2015-12-10T16:34:23Z","git_url":"git://github.com/francisco-dlp/hyperspy.git","ssh_url":"git@github.com:francisco-dlp/hyperspy.git","clone_url":"https://github.com/francisco-dlp/hyperspy.git","svn_url":"https://github.com/francisco-dlp/hyperspy","homepage":"http://www.hyperspy.org","size":71251,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/francisco-dlp/hyperspy/pulls/21"},"html":{"href":"https://github.com/francisco-dlp/hyperspy/pull/21"},"issue":{"href":"https://api.github.com/repos/francisco-dlp/hyperspy/issues/21"},"comments":{"href":"https://api.github.com/repos/francisco-dlp/hyperspy/issues/21/comments"},"review_comments":{"href":"https://api.github.com/repos/francisco-dlp/hyperspy/pulls/21/comments"},"review_comment":{"href":"https://api.github.com/repos/francisco-dlp/hyperspy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/francisco-dlp/hyperspy/pulls/21/commits"},"statuses":{"href":"https://api.github.com/repos/francisco-dlp/hyperspy/statuses/5b3bffe48dba33635223afb72122d63c0e88d896"}}}}