{"action":"created","comment":{"url":"https://api.github.com/repos/docker/libcontainer/pulls/comments/25440160","id":25440160,"diff_hunk":"@@ -26,7 +26,7 @@ func (s *MemoryGroup) Set(d *data) error {\n \t}()\n \n \t// Only set values if some config was specified.\n-\tif d.c.Memory != 0 || d.c.MemoryReservation != 0 || d.c.MemorySwap != 0 {\n+\tif d.c.Memory != 0 || d.c.MemoryReservation != 0 || d.c.MemorySwap != 0 || d.c.OomKillDisable {","path":"cgroups/fs/memory.go","position":5,"original_position":5,"commit_id":"2aa4175b2b8edcfc70f435f8f7a4a8a22f3d5227","original_commit_id":"2aa4175b2b8edcfc70f435f8f7a4a8a22f3d5227","user":{"login":"vmarmol","id":985208,"avatar_url":"https://avatars.githubusercontent.com/u/985208?v=3","gravatar_id":"","url":"https://api.github.com/users/vmarmol","html_url":"https://github.com/vmarmol","followers_url":"https://api.github.com/users/vmarmol/followers","following_url":"https://api.github.com/users/vmarmol/following{/other_user}","gists_url":"https://api.github.com/users/vmarmol/gists{/gist_id}","starred_url":"https://api.github.com/users/vmarmol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmarmol/subscriptions","organizations_url":"https://api.github.com/users/vmarmol/orgs","repos_url":"https://api.github.com/users/vmarmol/repos","events_url":"https://api.github.com/users/vmarmol/events{/privacy}","received_events_url":"https://api.github.com/users/vmarmol/received_events","type":"User","site_admin":false},"body":"Break out OomKillDisable into its own if statement. It shouldn't be bundled with these here (neither should Reservation and Memory for that matter, but that's out of scope :) ).","created_at":"2015-02-26T16:22:26Z","updated_at":"2015-02-26T16:22:26Z","html_url":"https://github.com/docker/libcontainer/pull/412#discussion_r25440160","pull_request_url":"https://api.github.com/repos/docker/libcontainer/pulls/412","_links":{"self":{"href":"https://api.github.com/repos/docker/libcontainer/pulls/comments/25440160"},"html":{"href":"https://github.com/docker/libcontainer/pull/412#discussion_r25440160"},"pull_request":{"href":"https://api.github.com/repos/docker/libcontainer/pulls/412"}}},"pull_request":{"url":"https://api.github.com/repos/docker/libcontainer/pulls/412","id":30067419,"html_url":"https://github.com/docker/libcontainer/pull/412","diff_url":"https://github.com/docker/libcontainer/pull/412.diff","patch_url":"https://github.com/docker/libcontainer/pull/412.patch","issue_url":"https://api.github.com/repos/docker/libcontainer/issues/412","number":412,"state":"open","locked":false,"title":"cgroups: add support for oom control","user":{"login":"HuKeping","id":9958621,"avatar_url":"https://avatars.githubusercontent.com/u/9958621?v=3","gravatar_id":"","url":"https://api.github.com/users/HuKeping","html_url":"https://github.com/HuKeping","followers_url":"https://api.github.com/users/HuKeping/followers","following_url":"https://api.github.com/users/HuKeping/following{/other_user}","gists_url":"https://api.github.com/users/HuKeping/gists{/gist_id}","starred_url":"https://api.github.com/users/HuKeping/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HuKeping/subscriptions","organizations_url":"https://api.github.com/users/HuKeping/orgs","repos_url":"https://api.github.com/users/HuKeping/repos","events_url":"https://api.github.com/users/HuKeping/events{/privacy}","received_events_url":"https://api.github.com/users/HuKeping/received_events","type":"User","site_admin":false},"body":"Redo #411 ","created_at":"2015-02-26T10:51:30Z","updated_at":"2015-02-26T16:22:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"089908a1de759ef659a2a78b219f2f5ccd1d22b4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/docker/libcontainer/pulls/412/commits","review_comments_url":"https://api.github.com/repos/docker/libcontainer/pulls/412/comments","review_comment_url":"https://api.github.com/repos/docker/libcontainer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/libcontainer/issues/412/comments","statuses_url":"https://api.github.com/repos/docker/libcontainer/statuses/2aa4175b2b8edcfc70f435f8f7a4a8a22f3d5227","head":{"label":"HuKeping:master","ref":"master","sha":"2aa4175b2b8edcfc70f435f8f7a4a8a22f3d5227","user":{"login":"HuKeping","id":9958621,"avatar_url":"https://avatars.githubusercontent.com/u/9958621?v=3","gravatar_id":"","url":"https://api.github.com/users/HuKeping","html_url":"https://github.com/HuKeping","followers_url":"https://api.github.com/users/HuKeping/followers","following_url":"https://api.github.com/users/HuKeping/following{/other_user}","gists_url":"https://api.github.com/users/HuKeping/gists{/gist_id}","starred_url":"https://api.github.com/users/HuKeping/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HuKeping/subscriptions","organizations_url":"https://api.github.com/users/HuKeping/orgs","repos_url":"https://api.github.com/users/HuKeping/repos","events_url":"https://api.github.com/users/HuKeping/events{/privacy}","received_events_url":"https://api.github.com/users/HuKeping/received_events","type":"User","site_admin":false},"repo":{"id":31354664,"name":"libcontainer","full_name":"HuKeping/libcontainer","owner":{"login":"HuKeping","id":9958621,"avatar_url":"https://avatars.githubusercontent.com/u/9958621?v=3","gravatar_id":"","url":"https://api.github.com/users/HuKeping","html_url":"https://github.com/HuKeping","followers_url":"https://api.github.com/users/HuKeping/followers","following_url":"https://api.github.com/users/HuKeping/following{/other_user}","gists_url":"https://api.github.com/users/HuKeping/gists{/gist_id}","starred_url":"https://api.github.com/users/HuKeping/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HuKeping/subscriptions","organizations_url":"https://api.github.com/users/HuKeping/orgs","repos_url":"https://api.github.com/users/HuKeping/repos","events_url":"https://api.github.com/users/HuKeping/events{/privacy}","received_events_url":"https://api.github.com/users/HuKeping/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/HuKeping/libcontainer","description":"Linux Containers","fork":true,"url":"https://api.github.com/repos/HuKeping/libcontainer","forks_url":"https://api.github.com/repos/HuKeping/libcontainer/forks","keys_url":"https://api.github.com/repos/HuKeping/libcontainer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HuKeping/libcontainer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HuKeping/libcontainer/teams","hooks_url":"https://api.github.com/repos/HuKeping/libcontainer/hooks","issue_events_url":"https://api.github.com/repos/HuKeping/libcontainer/issues/events{/number}","events_url":"https://api.github.com/repos/HuKeping/libcontainer/events","assignees_url":"https://api.github.com/repos/HuKeping/libcontainer/assignees{/user}","branches_url":"https://api.github.com/repos/HuKeping/libcontainer/branches{/branch}","tags_url":"https://api.github.com/repos/HuKeping/libcontainer/tags","blobs_url":"https://api.github.com/repos/HuKeping/libcontainer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HuKeping/libcontainer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HuKeping/libcontainer/git/refs{/sha}","trees_url":"https://api.github.com/repos/HuKeping/libcontainer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HuKeping/libcontainer/statuses/{sha}","languages_url":"https://api.github.com/repos/HuKeping/libcontainer/languages","stargazers_url":"https://api.github.com/repos/HuKeping/libcontainer/stargazers","contributors_url":"https://api.github.com/repos/HuKeping/libcontainer/contributors","subscribers_url":"https://api.github.com/repos/HuKeping/libcontainer/subscribers","subscription_url":"https://api.github.com/repos/HuKeping/libcontainer/subscription","commits_url":"https://api.github.com/repos/HuKeping/libcontainer/commits{/sha}","git_commits_url":"https://api.github.com/repos/HuKeping/libcontainer/git/commits{/sha}","comments_url":"https://api.github.com/repos/HuKeping/libcontainer/comments{/number}","issue_comment_url":"https://api.github.com/repos/HuKeping/libcontainer/issues/comments{/number}","contents_url":"https://api.github.com/repos/HuKeping/libcontainer/contents/{+path}","compare_url":"https://api.github.com/repos/HuKeping/libcontainer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HuKeping/libcontainer/merges","archive_url":"https://api.github.com/repos/HuKeping/libcontainer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HuKeping/libcontainer/downloads","issues_url":"https://api.github.com/repos/HuKeping/libcontainer/issues{/number}","pulls_url":"https://api.github.com/repos/HuKeping/libcontainer/pulls{/number}","milestones_url":"https://api.github.com/repos/HuKeping/libcontainer/milestones{/number}","notifications_url":"https://api.github.com/repos/HuKeping/libcontainer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HuKeping/libcontainer/labels{/name}","releases_url":"https://api.github.com/repos/HuKeping/libcontainer/releases{/id}","created_at":"2015-02-26T06:59:22Z","updated_at":"2015-02-26T10:46:24Z","pushed_at":"2015-02-26T10:46:24Z","git_url":"git://github.com/HuKeping/libcontainer.git","ssh_url":"git@github.com:HuKeping/libcontainer.git","clone_url":"https://github.com/HuKeping/libcontainer.git","svn_url":"https://github.com/HuKeping/libcontainer","homepage":"http://www.docker.com/","size":5303,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"9d91f080ced0bbfcbd3c003e2a20c9cdc81bc4ff","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":15693680,"name":"libcontainer","full_name":"docker/libcontainer","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/libcontainer","description":"Linux Containers","fork":false,"url":"https://api.github.com/repos/docker/libcontainer","forks_url":"https://api.github.com/repos/docker/libcontainer/forks","keys_url":"https://api.github.com/repos/docker/libcontainer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/libcontainer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/libcontainer/teams","hooks_url":"https://api.github.com/repos/docker/libcontainer/hooks","issue_events_url":"https://api.github.com/repos/docker/libcontainer/issues/events{/number}","events_url":"https://api.github.com/repos/docker/libcontainer/events","assignees_url":"https://api.github.com/repos/docker/libcontainer/assignees{/user}","branches_url":"https://api.github.com/repos/docker/libcontainer/branches{/branch}","tags_url":"https://api.github.com/repos/docker/libcontainer/tags","blobs_url":"https://api.github.com/repos/docker/libcontainer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/libcontainer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/libcontainer/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/libcontainer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/libcontainer/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/libcontainer/languages","stargazers_url":"https://api.github.com/repos/docker/libcontainer/stargazers","contributors_url":"https://api.github.com/repos/docker/libcontainer/contributors","subscribers_url":"https://api.github.com/repos/docker/libcontainer/subscribers","subscription_url":"https://api.github.com/repos/docker/libcontainer/subscription","commits_url":"https://api.github.com/repos/docker/libcontainer/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/libcontainer/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/libcontainer/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/libcontainer/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/libcontainer/contents/{+path}","compare_url":"https://api.github.com/repos/docker/libcontainer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/libcontainer/merges","archive_url":"https://api.github.com/repos/docker/libcontainer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/libcontainer/downloads","issues_url":"https://api.github.com/repos/docker/libcontainer/issues{/number}","pulls_url":"https://api.github.com/repos/docker/libcontainer/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/libcontainer/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/libcontainer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/libcontainer/labels{/name}","releases_url":"https://api.github.com/repos/docker/libcontainer/releases{/id}","created_at":"2014-01-07T03:05:05Z","updated_at":"2015-02-26T08:10:51Z","pushed_at":"2015-02-26T03:09:23Z","git_url":"git://github.com/docker/libcontainer.git","ssh_url":"git@github.com:docker/libcontainer.git","clone_url":"https://github.com/docker/libcontainer.git","svn_url":"https://github.com/docker/libcontainer","homepage":"http://www.docker.com/","size":5303,"stargazers_count":688,"watchers_count":688,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":182,"mirror_url":null,"open_issues_count":44,"forks":182,"open_issues":44,"watchers":688,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/libcontainer/pulls/412"},"html":{"href":"https://github.com/docker/libcontainer/pull/412"},"issue":{"href":"https://api.github.com/repos/docker/libcontainer/issues/412"},"comments":{"href":"https://api.github.com/repos/docker/libcontainer/issues/412/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/libcontainer/pulls/412/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/libcontainer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/libcontainer/pulls/412/commits"},"statuses":{"href":"https://api.github.com/repos/docker/libcontainer/statuses/2aa4175b2b8edcfc70f435f8f7a4a8a22f3d5227"}}}}