{"action":"created","comment":{"url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments/46043772","id":46043772,"diff_hunk":"@@ -674,15 +679,66 @@ public boolean isNearCacheEnabled() {\n         return nearCacheConfig != null;\n     }\n \n+    /**\n+     *\n+     * @return\n+     * @deprecated user {@link #getQueryCacheConfigs()} instead.\n+     */\n     public boolean isOptimizeQueries() {\n-        return optimizeQueries;\n+        return cacheDeserializedValues == CacheDeserializedValues.ALWAYS;\n     }\n \n+    /**\n+     *\n+     * Enable de-serialized value caching when evaluating predicates.\n+     *\n+     * @param optimizeQueries\n+     * @return this {@code MapConfig} instance.\n+     * @deprecated use {@link #setCacheDeserializedValues(CacheDeserializedValues)} instead\n+     */\n     public MapConfig setOptimizeQueries(boolean optimizeQueries) {\n-        this.optimizeQueries = optimizeQueries;\n+        if (optimizeQueries) {\n+            if (cacheDeserializedValues == DEFAULT_CACHED_DESERIALIZED_VALUES) {\n+                cacheDeserializedValues = CacheDeserializedValues.ALWAYS;\n+            } else if (cacheDeserializedValues == CacheDeserializedValues.NEVER) {\n+                throw new ConfigurationException(\"Deprecated option 'optimize-queries' is set to true, \"\n+                        + \"but 'cacheDeserializedValues' is set to NEVER. These are conflicting options. Please \"\n+                        + \"remove the `optimize-queries'\");\n+            }\n+        } else {\n+            if (cacheDeserializedValues == CacheDeserializedValues.ALWAYS) {\n+                throw new ConfigurationException(\"Deprecated option 'optimize-queries' is set to false, \"\n+                        + \"but 'cacheDeserializedValues' is set to ALWAYS. These are conflicting options. Please \"\n+                        + \"remove the `optimize-queries'\");\n+            }\n+        }\n         return this;\n     }\n \n+    /**\n+     * Configure value de-serialized value caching.\n+     * Default: {@link CacheDeserializedValues#INDEX_ONLY}\n+     *\n+     * @param cacheDeserializedValues\n+     * @return this {@code MapConfig} instance.\n+     * @since 3.6\n+     * @see {@link CacheDeserializedValues}\n+     */\n+    public MapConfig setCacheDeserializedValues(CacheDeserializedValues cacheDeserializedValues) {","path":"hazelcast/src/main/java/com/hazelcast/config/MapConfig.java","position":81,"original_position":81,"commit_id":"d646e63306e0bb62d2f61c23d83e143a2ca8ef0a","original_commit_id":"d646e63306e0bb62d2f61c23d83e143a2ca8ef0a","user":{"login":"ahmetmircik","id":2960360,"avatar_url":"https://avatars.githubusercontent.com/u/2960360?v=3","gravatar_id":"","url":"https://api.github.com/users/ahmetmircik","html_url":"https://github.com/ahmetmircik","followers_url":"https://api.github.com/users/ahmetmircik/followers","following_url":"https://api.github.com/users/ahmetmircik/following{/other_user}","gists_url":"https://api.github.com/users/ahmetmircik/gists{/gist_id}","starred_url":"https://api.github.com/users/ahmetmircik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahmetmircik/subscriptions","organizations_url":"https://api.github.com/users/ahmetmircik/orgs","repos_url":"https://api.github.com/users/ahmetmircik/repos","events_url":"https://api.github.com/users/ahmetmircik/events{/privacy}","received_events_url":"https://api.github.com/users/ahmetmircik/received_events","type":"User","site_admin":false},"body":"ops just saw it","created_at":"2015-11-27T12:45:40Z","updated_at":"2015-11-27T12:45:40Z","html_url":"https://github.com/hazelcast/hazelcast/pull/6831#discussion_r46043772","pull_request_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/6831","_links":{"self":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments/46043772"},"html":{"href":"https://github.com/hazelcast/hazelcast/pull/6831#discussion_r46043772"},"pull_request":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/6831"}}},"pull_request":{"url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/6831","id":51529786,"html_url":"https://github.com/hazelcast/hazelcast/pull/6831","diff_url":"https://github.com/hazelcast/hazelcast/pull/6831.diff","patch_url":"https://github.com/hazelcast/hazelcast/pull/6831.patch","issue_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/6831","number":6831,"state":"open","locked":false,"title":"Introduces CacheDeserializedValues into MapConfig","user":{"login":"jerrinot","id":158619,"avatar_url":"https://avatars.githubusercontent.com/u/158619?v=3","gravatar_id":"","url":"https://api.github.com/users/jerrinot","html_url":"https://github.com/jerrinot","followers_url":"https://api.github.com/users/jerrinot/followers","following_url":"https://api.github.com/users/jerrinot/following{/other_user}","gists_url":"https://api.github.com/users/jerrinot/gists{/gist_id}","starred_url":"https://api.github.com/users/jerrinot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerrinot/subscriptions","organizations_url":"https://api.github.com/users/jerrinot/orgs","repos_url":"https://api.github.com/users/jerrinot/repos","events_url":"https://api.github.com/users/jerrinot/events{/privacy}","received_events_url":"https://api.github.com/users/jerrinot/received_events","type":"User","site_admin":false},"body":"Allows to configure caching with finer granularity\r\nthan (now deprecated) optimizeQueries boolean flag.","created_at":"2015-11-23T14:32:17Z","updated_at":"2015-11-27T12:45:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c51760ea86310e217343d4934c62291a2073cb19","assignee":null,"milestone":{"url":"https://api.github.com/repos/hazelcast/hazelcast/milestones/61","html_url":"https://github.com/hazelcast/hazelcast/milestones/3.6","labels_url":"https://api.github.com/repos/hazelcast/hazelcast/milestones/61/labels","id":982584,"number":61,"title":"3.6","description":"","creator":{"login":"enesakar","id":234086,"avatar_url":"https://avatars.githubusercontent.com/u/234086?v=3","gravatar_id":"","url":"https://api.github.com/users/enesakar","html_url":"https://github.com/enesakar","followers_url":"https://api.github.com/users/enesakar/followers","following_url":"https://api.github.com/users/enesakar/following{/other_user}","gists_url":"https://api.github.com/users/enesakar/gists{/gist_id}","starred_url":"https://api.github.com/users/enesakar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enesakar/subscriptions","organizations_url":"https://api.github.com/users/enesakar/orgs","repos_url":"https://api.github.com/users/enesakar/repos","events_url":"https://api.github.com/users/enesakar/events{/privacy}","received_events_url":"https://api.github.com/users/enesakar/received_events","type":"User","site_admin":false},"open_issues":67,"closed_issues":923,"state":"open","created_at":"2015-02-17T09:27:09Z","updated_at":"2015-11-27T12:20:31Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/6831/commits","review_comments_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/6831/comments","review_comment_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/6831/comments","statuses_url":"https://api.github.com/repos/hazelcast/hazelcast/statuses/d646e63306e0bb62d2f61c23d83e143a2ca8ef0a","head":{"label":"jerrinot:fix/optimize-query-depracation/master","ref":"fix/optimize-query-depracation/master","sha":"d646e63306e0bb62d2f61c23d83e143a2ca8ef0a","user":{"login":"jerrinot","id":158619,"avatar_url":"https://avatars.githubusercontent.com/u/158619?v=3","gravatar_id":"","url":"https://api.github.com/users/jerrinot","html_url":"https://github.com/jerrinot","followers_url":"https://api.github.com/users/jerrinot/followers","following_url":"https://api.github.com/users/jerrinot/following{/other_user}","gists_url":"https://api.github.com/users/jerrinot/gists{/gist_id}","starred_url":"https://api.github.com/users/jerrinot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerrinot/subscriptions","organizations_url":"https://api.github.com/users/jerrinot/orgs","repos_url":"https://api.github.com/users/jerrinot/repos","events_url":"https://api.github.com/users/jerrinot/events{/privacy}","received_events_url":"https://api.github.com/users/jerrinot/received_events","type":"User","site_admin":false},"repo":{"id":14844579,"name":"hazelcast","full_name":"jerrinot/hazelcast","owner":{"login":"jerrinot","id":158619,"avatar_url":"https://avatars.githubusercontent.com/u/158619?v=3","gravatar_id":"","url":"https://api.github.com/users/jerrinot","html_url":"https://github.com/jerrinot","followers_url":"https://api.github.com/users/jerrinot/followers","following_url":"https://api.github.com/users/jerrinot/following{/other_user}","gists_url":"https://api.github.com/users/jerrinot/gists{/gist_id}","starred_url":"https://api.github.com/users/jerrinot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerrinot/subscriptions","organizations_url":"https://api.github.com/users/jerrinot/orgs","repos_url":"https://api.github.com/users/jerrinot/repos","events_url":"https://api.github.com/users/jerrinot/events{/privacy}","received_events_url":"https://api.github.com/users/jerrinot/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jerrinot/hazelcast","description":"Open Source In-Memory Data Grid","fork":true,"url":"https://api.github.com/repos/jerrinot/hazelcast","forks_url":"https://api.github.com/repos/jerrinot/hazelcast/forks","keys_url":"https://api.github.com/repos/jerrinot/hazelcast/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jerrinot/hazelcast/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jerrinot/hazelcast/teams","hooks_url":"https://api.github.com/repos/jerrinot/hazelcast/hooks","issue_events_url":"https://api.github.com/repos/jerrinot/hazelcast/issues/events{/number}","events_url":"https://api.github.com/repos/jerrinot/hazelcast/events","assignees_url":"https://api.github.com/repos/jerrinot/hazelcast/assignees{/user}","branches_url":"https://api.github.com/repos/jerrinot/hazelcast/branches{/branch}","tags_url":"https://api.github.com/repos/jerrinot/hazelcast/tags","blobs_url":"https://api.github.com/repos/jerrinot/hazelcast/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jerrinot/hazelcast/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jerrinot/hazelcast/git/refs{/sha}","trees_url":"https://api.github.com/repos/jerrinot/hazelcast/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jerrinot/hazelcast/statuses/{sha}","languages_url":"https://api.github.com/repos/jerrinot/hazelcast/languages","stargazers_url":"https://api.github.com/repos/jerrinot/hazelcast/stargazers","contributors_url":"https://api.github.com/repos/jerrinot/hazelcast/contributors","subscribers_url":"https://api.github.com/repos/jerrinot/hazelcast/subscribers","subscription_url":"https://api.github.com/repos/jerrinot/hazelcast/subscription","commits_url":"https://api.github.com/repos/jerrinot/hazelcast/commits{/sha}","git_commits_url":"https://api.github.com/repos/jerrinot/hazelcast/git/commits{/sha}","comments_url":"https://api.github.com/repos/jerrinot/hazelcast/comments{/number}","issue_comment_url":"https://api.github.com/repos/jerrinot/hazelcast/issues/comments{/number}","contents_url":"https://api.github.com/repos/jerrinot/hazelcast/contents/{+path}","compare_url":"https://api.github.com/repos/jerrinot/hazelcast/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jerrinot/hazelcast/merges","archive_url":"https://api.github.com/repos/jerrinot/hazelcast/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jerrinot/hazelcast/downloads","issues_url":"https://api.github.com/repos/jerrinot/hazelcast/issues{/number}","pulls_url":"https://api.github.com/repos/jerrinot/hazelcast/pulls{/number}","milestones_url":"https://api.github.com/repos/jerrinot/hazelcast/milestones{/number}","notifications_url":"https://api.github.com/repos/jerrinot/hazelcast/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jerrinot/hazelcast/labels{/name}","releases_url":"https://api.github.com/repos/jerrinot/hazelcast/releases{/id}","created_at":"2013-12-01T19:18:56Z","updated_at":"2015-04-27T20:28:12Z","pushed_at":"2015-11-26T15:25:29Z","git_url":"git://github.com/jerrinot/hazelcast.git","ssh_url":"git@github.com:jerrinot/hazelcast.git","clone_url":"https://github.com/jerrinot/hazelcast.git","svn_url":"https://github.com/jerrinot/hazelcast","homepage":"www.hazelcast.com","size":82626,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"hazelcast:master","ref":"master","sha":"e46a90af5e9af5514f14550d13b126bd890998fa","user":{"login":"hazelcast","id":1453152,"avatar_url":"https://avatars.githubusercontent.com/u/1453152?v=3","gravatar_id":"","url":"https://api.github.com/users/hazelcast","html_url":"https://github.com/hazelcast","followers_url":"https://api.github.com/users/hazelcast/followers","following_url":"https://api.github.com/users/hazelcast/following{/other_user}","gists_url":"https://api.github.com/users/hazelcast/gists{/gist_id}","starred_url":"https://api.github.com/users/hazelcast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hazelcast/subscriptions","organizations_url":"https://api.github.com/users/hazelcast/orgs","repos_url":"https://api.github.com/users/hazelcast/repos","events_url":"https://api.github.com/users/hazelcast/events{/privacy}","received_events_url":"https://api.github.com/users/hazelcast/received_events","type":"Organization","site_admin":false},"repo":{"id":3786237,"name":"hazelcast","full_name":"hazelcast/hazelcast","owner":{"login":"hazelcast","id":1453152,"avatar_url":"https://avatars.githubusercontent.com/u/1453152?v=3","gravatar_id":"","url":"https://api.github.com/users/hazelcast","html_url":"https://github.com/hazelcast","followers_url":"https://api.github.com/users/hazelcast/followers","following_url":"https://api.github.com/users/hazelcast/following{/other_user}","gists_url":"https://api.github.com/users/hazelcast/gists{/gist_id}","starred_url":"https://api.github.com/users/hazelcast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hazelcast/subscriptions","organizations_url":"https://api.github.com/users/hazelcast/orgs","repos_url":"https://api.github.com/users/hazelcast/repos","events_url":"https://api.github.com/users/hazelcast/events{/privacy}","received_events_url":"https://api.github.com/users/hazelcast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hazelcast/hazelcast","description":"Open Source In-Memory Data Grid","fork":false,"url":"https://api.github.com/repos/hazelcast/hazelcast","forks_url":"https://api.github.com/repos/hazelcast/hazelcast/forks","keys_url":"https://api.github.com/repos/hazelcast/hazelcast/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hazelcast/hazelcast/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hazelcast/hazelcast/teams","hooks_url":"https://api.github.com/repos/hazelcast/hazelcast/hooks","issue_events_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/events{/number}","events_url":"https://api.github.com/repos/hazelcast/hazelcast/events","assignees_url":"https://api.github.com/repos/hazelcast/hazelcast/assignees{/user}","branches_url":"https://api.github.com/repos/hazelcast/hazelcast/branches{/branch}","tags_url":"https://api.github.com/repos/hazelcast/hazelcast/tags","blobs_url":"https://api.github.com/repos/hazelcast/hazelcast/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hazelcast/hazelcast/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hazelcast/hazelcast/git/refs{/sha}","trees_url":"https://api.github.com/repos/hazelcast/hazelcast/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hazelcast/hazelcast/statuses/{sha}","languages_url":"https://api.github.com/repos/hazelcast/hazelcast/languages","stargazers_url":"https://api.github.com/repos/hazelcast/hazelcast/stargazers","contributors_url":"https://api.github.com/repos/hazelcast/hazelcast/contributors","subscribers_url":"https://api.github.com/repos/hazelcast/hazelcast/subscribers","subscription_url":"https://api.github.com/repos/hazelcast/hazelcast/subscription","commits_url":"https://api.github.com/repos/hazelcast/hazelcast/commits{/sha}","git_commits_url":"https://api.github.com/repos/hazelcast/hazelcast/git/commits{/sha}","comments_url":"https://api.github.com/repos/hazelcast/hazelcast/comments{/number}","issue_comment_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/comments{/number}","contents_url":"https://api.github.com/repos/hazelcast/hazelcast/contents/{+path}","compare_url":"https://api.github.com/repos/hazelcast/hazelcast/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hazelcast/hazelcast/merges","archive_url":"https://api.github.com/repos/hazelcast/hazelcast/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hazelcast/hazelcast/downloads","issues_url":"https://api.github.com/repos/hazelcast/hazelcast/issues{/number}","pulls_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls{/number}","milestones_url":"https://api.github.com/repos/hazelcast/hazelcast/milestones{/number}","notifications_url":"https://api.github.com/repos/hazelcast/hazelcast/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hazelcast/hazelcast/labels{/name}","releases_url":"https://api.github.com/repos/hazelcast/hazelcast/releases{/id}","created_at":"2012-03-21T12:25:18Z","updated_at":"2015-11-27T10:23:26Z","pushed_at":"2015-11-27T12:20:31Z","git_url":"git://github.com/hazelcast/hazelcast.git","ssh_url":"git@github.com:hazelcast/hazelcast.git","clone_url":"https://github.com/hazelcast/hazelcast.git","svn_url":"https://github.com/hazelcast/hazelcast","homepage":"www.hazelcast.com","size":93068,"stargazers_count":1327,"watchers_count":1327,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":643,"mirror_url":null,"open_issues_count":513,"forks":643,"open_issues":513,"watchers":1327,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/6831"},"html":{"href":"https://github.com/hazelcast/hazelcast/pull/6831"},"issue":{"href":"https://api.github.com/repos/hazelcast/hazelcast/issues/6831"},"comments":{"href":"https://api.github.com/repos/hazelcast/hazelcast/issues/6831/comments"},"review_comments":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/6831/comments"},"review_comment":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/6831/commits"},"statuses":{"href":"https://api.github.com/repos/hazelcast/hazelcast/statuses/d646e63306e0bb62d2f61c23d83e143a2ca8ef0a"}}}}