{"action":"created","issue":{"url":"https://api.github.com/repos/robbyrussell/oh-my-zsh/issues/3869","labels_url":"https://api.github.com/repos/robbyrussell/oh-my-zsh/issues/3869/labels{/name}","comments_url":"https://api.github.com/repos/robbyrussell/oh-my-zsh/issues/3869/comments","events_url":"https://api.github.com/repos/robbyrussell/oh-my-zsh/issues/3869/events","html_url":"https://github.com/robbyrussell/oh-my-zsh/pull/3869","id":74456777,"number":3869,"title":"Don't clobber default LSCOLORS, if DISABLE_LS_COLORS is set to true.","user":{"login":"shreevatsa","id":767530,"avatar_url":"https://avatars.githubusercontent.com/u/767530?v=3","gravatar_id":"","url":"https://api.github.com/users/shreevatsa","html_url":"https://github.com/shreevatsa","followers_url":"https://api.github.com/users/shreevatsa/followers","following_url":"https://api.github.com/users/shreevatsa/following{/other_user}","gists_url":"https://api.github.com/users/shreevatsa/gists{/gist_id}","starred_url":"https://api.github.com/users/shreevatsa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shreevatsa/subscriptions","organizations_url":"https://api.github.com/users/shreevatsa/orgs","repos_url":"https://api.github.com/users/shreevatsa/repos","events_url":"https://api.github.com/users/shreevatsa/events{/privacy}","received_events_url":"https://api.github.com/users/shreevatsa/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-05-08T18:44:06Z","updated_at":"2015-09-28T16:48:27Z","closed_at":"2015-09-28T15:47:13Z","pull_request":{"url":"https://api.github.com/repos/robbyrussell/oh-my-zsh/pulls/3869","html_url":"https://github.com/robbyrussell/oh-my-zsh/pull/3869","diff_url":"https://github.com/robbyrussell/oh-my-zsh/pull/3869.diff","patch_url":"https://github.com/robbyrussell/oh-my-zsh/pull/3869.patch"},"body":"This change makes oh-my-zsh touch the LSCOLORS variable only if DISABLE_LS_COLORS is not set.\r\n\r\nBackground:\r\nI don't want colors by default, and I manually run `ls -G` (on Mac OS X) when I want colors.\r\n\r\nFor users who've grown accustomed to the default `ls` colors, it's a bit jarring to have oh-my-zsh show everything in new colors, even when they think they've turned off this setting with `DISABLE_LS_COLORS=true`.\r\n\r\nAnyway, there is no good reason to `export LSCOLORS` when `DISABLE_LS_COLORS` is set, so this change should be strictly better."},"comment":{"url":"https://api.github.com/repos/robbyrussell/oh-my-zsh/issues/comments/143801319","html_url":"https://github.com/robbyrussell/oh-my-zsh/pull/3869#issuecomment-143801319","issue_url":"https://api.github.com/repos/robbyrussell/oh-my-zsh/issues/3869","id":143801319,"user":{"login":"shreevatsa","id":767530,"avatar_url":"https://avatars.githubusercontent.com/u/767530?v=3","gravatar_id":"","url":"https://api.github.com/users/shreevatsa","html_url":"https://github.com/shreevatsa","followers_url":"https://api.github.com/users/shreevatsa/followers","following_url":"https://api.github.com/users/shreevatsa/following{/other_user}","gists_url":"https://api.github.com/users/shreevatsa/gists{/gist_id}","starred_url":"https://api.github.com/users/shreevatsa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shreevatsa/subscriptions","organizations_url":"https://api.github.com/users/shreevatsa/orgs","repos_url":"https://api.github.com/users/shreevatsa/repos","events_url":"https://api.github.com/users/shreevatsa/events{/privacy}","received_events_url":"https://api.github.com/users/shreevatsa/received_events","type":"User","site_admin":false},"created_at":"2015-09-28T16:48:27Z","updated_at":"2015-09-28T16:48:27Z","body":"(Done, closed this... just adding a comment in case there was no notification earlier.)"}}