{"action":"created","issue":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/2552","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/2552/labels{/name}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/2552/comments","events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/2552/events","html_url":"https://github.com/cockroachdb/cockroach/pull/2552","id":107117494,"number":2552,"title":"Add support for SIMILAR TO and NOT SIMILAR TO pattern matching commands","user":{"login":"nvanbenschoten","id":5438456,"avatar_url":"https://avatars.githubusercontent.com/u/5438456?v=3","gravatar_id":"","url":"https://api.github.com/users/nvanbenschoten","html_url":"https://github.com/nvanbenschoten","followers_url":"https://api.github.com/users/nvanbenschoten/followers","following_url":"https://api.github.com/users/nvanbenschoten/following{/other_user}","gists_url":"https://api.github.com/users/nvanbenschoten/gists{/gist_id}","starred_url":"https://api.github.com/users/nvanbenschoten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nvanbenschoten/subscriptions","organizations_url":"https://api.github.com/users/nvanbenschoten/orgs","repos_url":"https://api.github.com/users/nvanbenschoten/repos","events_url":"https://api.github.com/users/nvanbenschoten/events{/privacy}","received_events_url":"https://api.github.com/users/nvanbenschoten/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"petermattis","id":6201335,"avatar_url":"https://avatars.githubusercontent.com/u/6201335?v=3","gravatar_id":"","url":"https://api.github.com/users/petermattis","html_url":"https://github.com/petermattis","followers_url":"https://api.github.com/users/petermattis/followers","following_url":"https://api.github.com/users/petermattis/following{/other_user}","gists_url":"https://api.github.com/users/petermattis/gists{/gist_id}","starred_url":"https://api.github.com/users/petermattis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petermattis/subscriptions","organizations_url":"https://api.github.com/users/petermattis/orgs","repos_url":"https://api.github.com/users/petermattis/repos","events_url":"https://api.github.com/users/petermattis/events{/privacy}","received_events_url":"https://api.github.com/users/petermattis/received_events","type":"User","site_admin":false},"milestone":null,"comments":3,"created_at":"2015-09-18T02:28:32Z","updated_at":"2015-09-21T00:32:59Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/2552","html_url":"https://github.com/cockroachdb/cockroach/pull/2552","diff_url":"https://github.com/cockroachdb/cockroach/pull/2552.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/2552.patch"},"body":"See #2242.\r\nBased on the [PostgreSQL docs](http://www.postgresql.org/docs/9.0/static/functions-matching.html) and [Firebird docs](http://www.firebirdsql.org/refdocs/langrefupd25-similar-to.html), it looks like the the only variation between SQL-style regular expressions and POSIX regular expressions is their handling of wildcards. I haven't been able to find any other differences, so it's pretty simple to make the translation to standard regexp patterns.\r\n\r\nQuestions:\r\n- Because errors while compiling the regexp are a very real possibility here, should I do anything more than just returning a regexp compilation error here?\r\n- For here and above with LIKE, I'm wondering if [`regexp.Compile`](https://golang.org/pkg/regexp/#Compile) or [`regexp.CompilePOSIX`](https://golang.org/pkg/regexp/#CompilePOSIX) is the right choice. I haven't seen any specific reasons why the extra restrictions placed on the POSIX regular expressions would be needed, but I wanted to run the issue by someone anyway."},"comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments/141850690","html_url":"https://github.com/cockroachdb/cockroach/pull/2552#issuecomment-141850690","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/2552","id":141850690,"user":{"login":"nvanbenschoten","id":5438456,"avatar_url":"https://avatars.githubusercontent.com/u/5438456?v=3","gravatar_id":"","url":"https://api.github.com/users/nvanbenschoten","html_url":"https://github.com/nvanbenschoten","followers_url":"https://api.github.com/users/nvanbenschoten/followers","following_url":"https://api.github.com/users/nvanbenschoten/following{/other_user}","gists_url":"https://api.github.com/users/nvanbenschoten/gists{/gist_id}","starred_url":"https://api.github.com/users/nvanbenschoten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nvanbenschoten/subscriptions","organizations_url":"https://api.github.com/users/nvanbenschoten/orgs","repos_url":"https://api.github.com/users/nvanbenschoten/repos","events_url":"https://api.github.com/users/nvanbenschoten/events{/privacy}","received_events_url":"https://api.github.com/users/nvanbenschoten/received_events","type":"User","site_admin":false},"created_at":"2015-09-21T00:32:59Z","updated_at":"2015-09-21T00:32:59Z","body":"It looks like a pair of unrelated unit tests failed (TestStoreRangeDownReplicate and TestStoreZoneUpdateAndRangeSplit). Is it possible to rerun the tests on CircleCI?"}}