{"action":"created","issue":{"url":"https://api.github.com/repos/clientIO/joint/issues/153","labels_url":"https://api.github.com/repos/clientIO/joint/issues/153/labels{/name}","comments_url":"https://api.github.com/repos/clientIO/joint/issues/153/comments","events_url":"https://api.github.com/repos/clientIO/joint/issues/153/events","html_url":"https://github.com/clientIO/joint/pull/153","id":93635994,"number":153,"title":"CommonJS / AMD Issues","user":{"login":"rfastturnlow","id":649599,"avatar_url":"https://avatars.githubusercontent.com/u/649599?v=3","gravatar_id":"","url":"https://api.github.com/users/rfastturnlow","html_url":"https://github.com/rfastturnlow","followers_url":"https://api.github.com/users/rfastturnlow/followers","following_url":"https://api.github.com/users/rfastturnlow/following{/other_user}","gists_url":"https://api.github.com/users/rfastturnlow/gists{/gist_id}","starred_url":"https://api.github.com/users/rfastturnlow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rfastturnlow/subscriptions","organizations_url":"https://api.github.com/users/rfastturnlow/orgs","repos_url":"https://api.github.com/users/rfastturnlow/repos","events_url":"https://api.github.com/users/rfastturnlow/events{/privacy}","received_events_url":"https://api.github.com/users/rfastturnlow/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-07-07T21:42:10Z","updated_at":"2015-07-08T13:15:58Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/clientIO/joint/pulls/153","html_url":"https://github.com/clientIO/joint/pull/153","diff_url":"https://github.com/clientIO/joint/pull/153.diff","patch_url":"https://github.com/clientIO/joint/pull/153.patch"},"body":"I pulled down the latest to try out the new module support and ran into a few minor issues with WebPack:\r\n\r\n1. The library paths in the grunt config file have not been updated since switching to bower.  This isn't really an issue with module support, but just something I noticed when trying to decide which output file to use.\r\n2. The two new concat tasks for the build script output files were missing parts of their template strings because grunt was trying to substitute in replacement values during the concat task.  I've updated the tasks to use the 'square' delimiter only and the template strings made it it to the output intact.\r\n3. The vectorizer module was not properly importing the geometry library.  I'm not quite sure why vectorizer and geometry weren't named for AMD, but I went ahead and gave them default names to match their global names and then added g as an import to vectorizer.  Doing so meant that g is coming from the closure now so the geometry file must be included before the vectorizer file in most situations.  To remedy that I swapped the file order in the concat tasks and any html file that included the files through script tags.\r\n\r\n  Lastly I added a sad test to demonstrate the issue in the requirejs test file.  I call it sad because the only way I could think to demonstrate the issue was to access a method in vectorizer that depended on the geometry library.  Obviously implementation details could change that will invalidate that so its long term value is pretty low.\r\n\r\nThat's it.  A couple minor fixes and the modules are working great.  Thanks for all your hard work on a great library!"},"comment":{"url":"https://api.github.com/repos/clientIO/joint/issues/comments/119575097","html_url":"https://github.com/clientIO/joint/pull/153#issuecomment-119575097","issue_url":"https://api.github.com/repos/clientIO/joint/issues/153","id":119575097,"user":{"login":"kumilingus","id":3967880,"avatar_url":"https://avatars.githubusercontent.com/u/3967880?v=3","gravatar_id":"","url":"https://api.github.com/users/kumilingus","html_url":"https://github.com/kumilingus","followers_url":"https://api.github.com/users/kumilingus/followers","following_url":"https://api.github.com/users/kumilingus/following{/other_user}","gists_url":"https://api.github.com/users/kumilingus/gists{/gist_id}","starred_url":"https://api.github.com/users/kumilingus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kumilingus/subscriptions","organizations_url":"https://api.github.com/users/kumilingus/orgs","repos_url":"https://api.github.com/users/kumilingus/repos","events_url":"https://api.github.com/users/kumilingus/events{/privacy}","received_events_url":"https://api.github.com/users/kumilingus/received_events","type":"User","site_admin":false},"created_at":"2015-07-08T13:15:58Z","updated_at":"2015-07-08T13:15:58Z","body":"Hi Randy,\r\n\r\nNote that `vectorizer` supposed to have no `geometry` dependency at all. Your changes and the test is a perfect solution before making `vectorizer` standalone takes a place.\r\n\r\nThumb up for all changes you've made. Thank you."}}