{"action":"created","issue":{"url":"https://api.github.com/repos/remiprev/her/issues/336","labels_url":"https://api.github.com/repos/remiprev/her/issues/336/labels{/name}","comments_url":"https://api.github.com/repos/remiprev/her/issues/336/comments","events_url":"https://api.github.com/repos/remiprev/her/issues/336/events","html_url":"https://github.com/remiprev/her/pull/336","id":72316206,"number":336,"title":"use a set rather than array to test existance of instance methods","user":{"login":"faisalmansoor","id":2112049,"avatar_url":"https://avatars.githubusercontent.com/u/2112049?v=3","gravatar_id":"","url":"https://api.github.com/users/faisalmansoor","html_url":"https://github.com/faisalmansoor","followers_url":"https://api.github.com/users/faisalmansoor/followers","following_url":"https://api.github.com/users/faisalmansoor/following{/other_user}","gists_url":"https://api.github.com/users/faisalmansoor/gists{/gist_id}","starred_url":"https://api.github.com/users/faisalmansoor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/faisalmansoor/subscriptions","organizations_url":"https://api.github.com/users/faisalmansoor/orgs","repos_url":"https://api.github.com/users/faisalmansoor/repos","events_url":"https://api.github.com/users/faisalmansoor/events{/privacy}","received_events_url":"https://api.github.com/users/faisalmansoor/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-05-01T00:13:57Z","updated_at":"2015-05-04T20:30:08Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/remiprev/her/pulls/336","html_url":"https://github.com/remiprev/her/pull/336","diff_url":"https://github.com/remiprev/her/pull/336.diff","patch_url":"https://github.com/remiprev/her/pull/336.patch"},"body":"Her::Model::Attributes#attributes searches an array in a loop which causes a lot of performance overhead in large object graphs. \r\n\r\nUsing a set rather than an array for lookup should significantly improve performance. "},"comment":{"url":"https://api.github.com/repos/remiprev/her/issues/comments/98842324","html_url":"https://github.com/remiprev/her/pull/336#issuecomment-98842324","issue_url":"https://api.github.com/repos/remiprev/her/issues/336","id":98842324,"user":{"login":"hubert","id":106995,"avatar_url":"https://avatars.githubusercontent.com/u/106995?v=3","gravatar_id":"","url":"https://api.github.com/users/hubert","html_url":"https://github.com/hubert","followers_url":"https://api.github.com/users/hubert/followers","following_url":"https://api.github.com/users/hubert/following{/other_user}","gists_url":"https://api.github.com/users/hubert/gists{/gist_id}","starred_url":"https://api.github.com/users/hubert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hubert/subscriptions","organizations_url":"https://api.github.com/users/hubert/orgs","repos_url":"https://api.github.com/users/hubert/repos","events_url":"https://api.github.com/users/hubert/events{/privacy}","received_events_url":"https://api.github.com/users/hubert/received_events","type":"User","site_admin":false},"created_at":"2015-05-04T20:30:08Z","updated_at":"2015-05-04T20:30:08Z","body":"hi faisal. how does using a set, rather than an array, improve search performance? it also takes O(n) time to find something in a set."}}