{"action":"created","issue":{"url":"https://api.github.com/repos/neovim/neovim/issues/2227","labels_url":"https://api.github.com/repos/neovim/neovim/issues/2227/labels{/name}","comments_url":"https://api.github.com/repos/neovim/neovim/issues/2227/comments","events_url":"https://api.github.com/repos/neovim/neovim/issues/2227/events","html_url":"https://github.com/neovim/neovim/pull/2227","id":63716694,"number":2227,"title":"[RFC] Enable -Wconversion: if_cscope.c","user":{"login":"glindste","id":1015224,"avatar_url":"https://avatars.githubusercontent.com/u/1015224?v=3","gravatar_id":"","url":"https://api.github.com/users/glindste","html_url":"https://github.com/glindste","followers_url":"https://api.github.com/users/glindste/followers","following_url":"https://api.github.com/users/glindste/following{/other_user}","gists_url":"https://api.github.com/users/glindste/gists{/gist_id}","starred_url":"https://api.github.com/users/glindste/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glindste/subscriptions","organizations_url":"https://api.github.com/users/glindste/orgs","repos_url":"https://api.github.com/users/glindste/repos","events_url":"https://api.github.com/users/glindste/events{/privacy}","received_events_url":"https://api.github.com/users/glindste/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/neovim/neovim/labels/refactor","name":"refactor","color":"bfe5bf"},{"url":"https://api.github.com/repos/neovim/neovim/labels/RFC","name":"RFC","color":"ededed"},{"url":"https://api.github.com/repos/neovim/neovim/labels/robustness","name":"robustness","color":"207de5"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-03-23T12:56:32Z","updated_at":"2015-03-24T10:40:27Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/neovim/neovim/pulls/2227","html_url":"https://github.com/neovim/neovim/pull/2227","diff_url":"https://github.com/neovim/neovim/pull/2227.diff","patch_url":"https://github.com/neovim/neovim/pull/2227.patch"},"body":"Enable -Wconversion for if_cscope.c as per #567. Mostly includes some casts and type-changes from `int` to `size_t`, where I've added asserts to make sure the value is non-negative.\r\n\r\nI chose to keep the global variable `csinfo_size` as an `int` since it's used extensively within loops and the amount of casts are relatively small.\r\n\r\nIn the function `cs_add_common()` I've left the `len` variable as an `int` for now since it is used as such in a call to `modify_fname()` on line 469. `modify_fname()` is defined in `eval.c` and only invoked 4 times in the source. The parameter is a length and is not used in any loops, so I would suggest changing the parameter to `size_t` instead. If that sounds like a good idea I can take care of it, it doesn't seem like anyone is messing with eval.c yet."},"comment":{"url":"https://api.github.com/repos/neovim/neovim/issues/comments/85445092","html_url":"https://github.com/neovim/neovim/pull/2227#issuecomment-85445092","issue_url":"https://api.github.com/repos/neovim/neovim/issues/2227","id":85445092,"user":{"login":"glindste","id":1015224,"avatar_url":"https://avatars.githubusercontent.com/u/1015224?v=3","gravatar_id":"","url":"https://api.github.com/users/glindste","html_url":"https://github.com/glindste","followers_url":"https://api.github.com/users/glindste/followers","following_url":"https://api.github.com/users/glindste/following{/other_user}","gists_url":"https://api.github.com/users/glindste/gists{/gist_id}","starred_url":"https://api.github.com/users/glindste/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glindste/subscriptions","organizations_url":"https://api.github.com/users/glindste/orgs","repos_url":"https://api.github.com/users/glindste/repos","events_url":"https://api.github.com/users/glindste/events{/privacy}","received_events_url":"https://api.github.com/users/glindste/received_events","type":"User","site_admin":false},"created_at":"2015-03-24T10:40:27Z","updated_at":"2015-03-24T10:40:27Z","body":"Ok, I'll try and refactor them. I'll leave `modify_fname` to you then, thanks for the heads up!"}}