{"action":"created","issue":{"url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/1556","labels_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/1556/labels{/name}","comments_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/1556/comments","events_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/1556/events","html_url":"https://github.com/MarlinFirmware/Marlin/pull/1556","id":59592121,"number":1556,"title":"Enhanced G29","user":{"login":"thinkyhead","id":698003,"avatar_url":"https://avatars.githubusercontent.com/u/698003?v=3","gravatar_id":"","url":"https://api.github.com/users/thinkyhead","html_url":"https://github.com/thinkyhead","followers_url":"https://api.github.com/users/thinkyhead/followers","following_url":"https://api.github.com/users/thinkyhead/following{/other_user}","gists_url":"https://api.github.com/users/thinkyhead/gists{/gist_id}","starred_url":"https://api.github.com/users/thinkyhead/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thinkyhead/subscriptions","organizations_url":"https://api.github.com/users/thinkyhead/orgs","repos_url":"https://api.github.com/users/thinkyhead/repos","events_url":"https://api.github.com/users/thinkyhead/events{/privacy}","received_events_url":"https://api.github.com/users/thinkyhead/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/MarlinFirmware/Marlin/labels/Improvement","name":"Improvement","color":"009800"},{"url":"https://api.github.com/repos/MarlinFirmware/Marlin/labels/Needs%20more%20work","name":"Needs more work","color":"c7def8"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":31,"created_at":"2015-03-03T04:00:39Z","updated_at":"2015-03-24T22:07:53Z","closed_at":"2015-03-05T11:54:54Z","pull_request":{"url":"https://api.github.com/repos/MarlinFirmware/Marlin/pulls/1556","html_url":"https://github.com/MarlinFirmware/Marlin/pull/1556","diff_url":"https://github.com/MarlinFirmware/Marlin/pull/1556.diff","patch_url":"https://github.com/MarlinFirmware/Marlin/pull/1556.patch"},"body":"- Adapted “Enhanced G29” code referred to in #1499 and posted at\r\n[3dprintboard.com](http://3dprintboard.com/showthread.php?3105-Auto_Bed_\r\nLeveling-Enhanced-G29-command)\r\n- Compatible with current G29 while adding some new arguments\r\n  - `V` sets the verbose level for serial out\r\n  - `T` (or `V` > 2) sends a Topology report to serial out\r\n  - `E` works the same way as before\r\n  - `P` works as before (source used `n` or `U`/`u`)\r\n  - `L`, `R`, `B`, `F` work as before\r\n- Added sanity checking for `LRBF`\r\n- Added enum constants for `probe_pt()`'s `retract_action` parameter"},"comment":{"url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/comments/85712012","html_url":"https://github.com/MarlinFirmware/Marlin/pull/1556#issuecomment-85712012","issue_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/1556","id":85712012,"user":{"login":"Roxy-3DPrintBoard","id":8404322,"avatar_url":"https://avatars.githubusercontent.com/u/8404322?v=3","gravatar_id":"","url":"https://api.github.com/users/Roxy-3DPrintBoard","html_url":"https://github.com/Roxy-3DPrintBoard","followers_url":"https://api.github.com/users/Roxy-3DPrintBoard/followers","following_url":"https://api.github.com/users/Roxy-3DPrintBoard/following{/other_user}","gists_url":"https://api.github.com/users/Roxy-3DPrintBoard/gists{/gist_id}","starred_url":"https://api.github.com/users/Roxy-3DPrintBoard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Roxy-3DPrintBoard/subscriptions","organizations_url":"https://api.github.com/users/Roxy-3DPrintBoard/orgs","repos_url":"https://api.github.com/users/Roxy-3DPrintBoard/repos","events_url":"https://api.github.com/users/Roxy-3DPrintBoard/events{/privacy}","received_events_url":"https://api.github.com/users/Roxy-3DPrintBoard/received_events","type":"User","site_admin":false},"created_at":"2015-03-24T22:07:53Z","updated_at":"2015-03-24T22:07:53Z","body":"> Im sorry, this is all pretty new to me and its bit confusing. Im not sure if i understand you correctly... So did Roxy reverse the G29 E behaviour? \r\n\r\nNo...  My code to leave the Z_PROBE engaged was there first.   Later, similar code got added to the main Marlin code base but it was reversed.  When I did the original code I figured there was good benefit to leaving the Z_PROBE engaged and decided to make that the default behavior.  But I wanted to allow the original behavior.\r\n\r\nWhen the similar functionality got added to the main Marlin code base, the opposite thinking must have happened.  They wanted to preserve the original behavior but provided the option to over ride that action.\r\n\r\nEither approach is fine.  The important fact is the main line code base handles either behavior now!\r\n \r\n"}}