{"action":"created","issue":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/3810","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/3810/labels{/name}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/3810/comments","events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/3810/events","html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/3810","id":55542499,"number":3810,"title":"WIP support namespacing in cache.Store","user":{"login":"ironcladlou","id":298299,"avatar_url":"https://avatars.githubusercontent.com/u/298299?v=3","gravatar_id":"","url":"https://api.github.com/users/ironcladlou","html_url":"https://github.com/ironcladlou","followers_url":"https://api.github.com/users/ironcladlou/followers","following_url":"https://api.github.com/users/ironcladlou/following{/other_user}","gists_url":"https://api.github.com/users/ironcladlou/gists{/gist_id}","starred_url":"https://api.github.com/users/ironcladlou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ironcladlou/subscriptions","organizations_url":"https://api.github.com/users/ironcladlou/orgs","repos_url":"https://api.github.com/users/ironcladlou/repos","events_url":"https://api.github.com/users/ironcladlou/events{/privacy}","received_events_url":"https://api.github.com/users/ironcladlou/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2015-01-26T21:48:48Z","updated_at":"2015-01-27T19:29:31Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/3810","html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/3810","diff_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/3810.diff","patch_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/3810.patch"},"body":"**INCOMPLETE**: This PR is currently open for discussion purposes and is still a work in progress. I'd like to discuss the general approach before cementing it further with test case fixes and documentation.\r\n\r\nSupport namespacing in cache.Store by framing the interface functions\r\naround interface{} and providing a key function to each Store implementation.\r\n\r\nImplementation of a fix for #2294.\r\n"},"comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/comments/71711365","html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/3810#issuecomment-71711365","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/3810","id":71711365,"user":{"login":"ironcladlou","id":298299,"avatar_url":"https://avatars.githubusercontent.com/u/298299?v=3","gravatar_id":"","url":"https://api.github.com/users/ironcladlou","html_url":"https://github.com/ironcladlou","followers_url":"https://api.github.com/users/ironcladlou/followers","following_url":"https://api.github.com/users/ironcladlou/following{/other_user}","gists_url":"https://api.github.com/users/ironcladlou/gists{/gist_id}","starred_url":"https://api.github.com/users/ironcladlou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ironcladlou/subscriptions","organizations_url":"https://api.github.com/users/ironcladlou/orgs","repos_url":"https://api.github.com/users/ironcladlou/repos","events_url":"https://api.github.com/users/ironcladlou/events{/privacy}","received_events_url":"https://api.github.com/users/ironcladlou/received_events","type":"User","site_admin":false},"created_at":"2015-01-27T19:29:31Z","updated_at":"2015-01-27T19:29:31Z","body":"@smarterclayton \r\n>Store should have a place to report errors (a channel or func).  Arguably next item should return error - I don't think it's appropriate for store to hide errors from all consumers (for instance, store should probably allow an EOF like function to indicate to consumers they won't get any more events).  But taking an optional func on store creation might work.  Technically that func may need to terminate the loop behavior, but that's a future thing.\r\nIn the event user doesn't provide an error func, we will have a generic error spout for that.\r\n\r\nThe functions in question are synchronous, and callers need to know immediately whether the a certain call to Add fails, for instance. Why not just make each function return `error`?\r\n"}}