{"action":"created","comment":{"url":"https://api.github.com/repos/WebAssembly/spec/pulls/comments/42197875","id":42197875,"diff_hunk":"@@ -109,7 +109,7 @@ let mem_size v at =\n  * we currently only support i32, just test that.\n  *)\n let mem_overflow x =\n-  I64.gt_u x (Int64.of_int32 Int32.max_int)\n+  I64.gt_u x (I64_convert.extend_u_i32 Int32.minus_one)","path":"ml-proto/spec/eval.ml","position":5,"original_position":5,"commit_id":"f8cbdac1220e5721ed48fb77ec4002b1a1e3dac4","original_commit_id":"f8cbdac1220e5721ed48fb77ec4002b1a1e3dac4","user":{"login":"sunfishcode","id":4503403,"avatar_url":"https://avatars.githubusercontent.com/u/4503403?v=3","gravatar_id":"","url":"https://api.github.com/users/sunfishcode","html_url":"https://github.com/sunfishcode","followers_url":"https://api.github.com/users/sunfishcode/followers","following_url":"https://api.github.com/users/sunfishcode/following{/other_user}","gists_url":"https://api.github.com/users/sunfishcode/gists{/gist_id}","starred_url":"https://api.github.com/users/sunfishcode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sunfishcode/subscriptions","organizations_url":"https://api.github.com/users/sunfishcode/orgs","repos_url":"https://api.github.com/users/sunfishcode/repos","events_url":"https://api.github.com/users/sunfishcode/events{/privacy}","received_events_url":"https://api.github.com/users/sunfishcode/received_events","type":"User","site_admin":false},"body":"When I make that change, I get:\r\n\r\nFile \"spec/eval.ml\", line 117, characters 14-38:\r\nError: This expression has type I32.t -> I64.t\r\n       but an expression was expected of type int\r\n\r\nwhich I don't understand.","created_at":"2015-10-16T00:23:23Z","updated_at":"2015-10-16T00:23:23Z","html_url":"https://github.com/WebAssembly/spec/pull/138#discussion_r42197875","pull_request_url":"https://api.github.com/repos/WebAssembly/spec/pulls/138","_links":{"self":{"href":"https://api.github.com/repos/WebAssembly/spec/pulls/comments/42197875"},"html":{"href":"https://github.com/WebAssembly/spec/pull/138#discussion_r42197875"},"pull_request":{"href":"https://api.github.com/repos/WebAssembly/spec/pulls/138"}}},"pull_request":{"url":"https://api.github.com/repos/WebAssembly/spec/pulls/138","id":47727214,"html_url":"https://github.com/WebAssembly/spec/pull/138","diff_url":"https://github.com/WebAssembly/spec/pull/138.diff","patch_url":"https://github.com/WebAssembly/spec/pull/138.patch","issue_url":"https://api.github.com/repos/WebAssembly/spec/issues/138","number":138,"state":"open","locked":false,"title":"Fix i32 unsigned range tests.","user":{"login":"sunfishcode","id":4503403,"avatar_url":"https://avatars.githubusercontent.com/u/4503403?v=3","gravatar_id":"","url":"https://api.github.com/users/sunfishcode","html_url":"https://github.com/sunfishcode","followers_url":"https://api.github.com/users/sunfishcode/followers","following_url":"https://api.github.com/users/sunfishcode/following{/other_user}","gists_url":"https://api.github.com/users/sunfishcode/gists{/gist_id}","starred_url":"https://api.github.com/users/sunfishcode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sunfishcode/subscriptions","organizations_url":"https://api.github.com/users/sunfishcode/orgs","repos_url":"https://api.github.com/users/sunfishcode/repos","events_url":"https://api.github.com/users/sunfishcode/events{/privacy}","received_events_url":"https://api.github.com/users/sunfishcode/received_events","type":"User","site_admin":false},"body":"When testing whether a value is in the i32 unsigned range, use the\r\nunsigned max value (aka minus_one), rather than max_int, which is the\r\nsigned max value.","created_at":"2015-10-14T23:15:20Z","updated_at":"2015-10-16T00:23:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6a6659485ba22b6fcd4950c8618b31d2f5084b2d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/WebAssembly/spec/pulls/138/commits","review_comments_url":"https://api.github.com/repos/WebAssembly/spec/pulls/138/comments","review_comment_url":"https://api.github.com/repos/WebAssembly/spec/pulls/comments{/number}","comments_url":"https://api.github.com/repos/WebAssembly/spec/issues/138/comments","statuses_url":"https://api.github.com/repos/WebAssembly/spec/statuses/f8cbdac1220e5721ed48fb77ec4002b1a1e3dac4","head":{"label":"WebAssembly:really-unsigned","ref":"really-unsigned","sha":"f8cbdac1220e5721ed48fb77ec4002b1a1e3dac4","user":{"login":"WebAssembly","id":11578470,"avatar_url":"https://avatars.githubusercontent.com/u/11578470?v=3","gravatar_id":"","url":"https://api.github.com/users/WebAssembly","html_url":"https://github.com/WebAssembly","followers_url":"https://api.github.com/users/WebAssembly/followers","following_url":"https://api.github.com/users/WebAssembly/following{/other_user}","gists_url":"https://api.github.com/users/WebAssembly/gists{/gist_id}","starred_url":"https://api.github.com/users/WebAssembly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WebAssembly/subscriptions","organizations_url":"https://api.github.com/users/WebAssembly/orgs","repos_url":"https://api.github.com/users/WebAssembly/repos","events_url":"https://api.github.com/users/WebAssembly/events{/privacy}","received_events_url":"https://api.github.com/users/WebAssembly/received_events","type":"Organization","site_admin":false},"repo":{"id":40598815,"name":"spec","full_name":"WebAssembly/spec","owner":{"login":"WebAssembly","id":11578470,"avatar_url":"https://avatars.githubusercontent.com/u/11578470?v=3","gravatar_id":"","url":"https://api.github.com/users/WebAssembly","html_url":"https://github.com/WebAssembly","followers_url":"https://api.github.com/users/WebAssembly/followers","following_url":"https://api.github.com/users/WebAssembly/following{/other_user}","gists_url":"https://api.github.com/users/WebAssembly/gists{/gist_id}","starred_url":"https://api.github.com/users/WebAssembly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WebAssembly/subscriptions","organizations_url":"https://api.github.com/users/WebAssembly/orgs","repos_url":"https://api.github.com/users/WebAssembly/repos","events_url":"https://api.github.com/users/WebAssembly/events{/privacy}","received_events_url":"https://api.github.com/users/WebAssembly/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/WebAssembly/spec","description":"Staging ground for artifacts related to an MVP spec","fork":false,"url":"https://api.github.com/repos/WebAssembly/spec","forks_url":"https://api.github.com/repos/WebAssembly/spec/forks","keys_url":"https://api.github.com/repos/WebAssembly/spec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WebAssembly/spec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WebAssembly/spec/teams","hooks_url":"https://api.github.com/repos/WebAssembly/spec/hooks","issue_events_url":"https://api.github.com/repos/WebAssembly/spec/issues/events{/number}","events_url":"https://api.github.com/repos/WebAssembly/spec/events","assignees_url":"https://api.github.com/repos/WebAssembly/spec/assignees{/user}","branches_url":"https://api.github.com/repos/WebAssembly/spec/branches{/branch}","tags_url":"https://api.github.com/repos/WebAssembly/spec/tags","blobs_url":"https://api.github.com/repos/WebAssembly/spec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WebAssembly/spec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WebAssembly/spec/git/refs{/sha}","trees_url":"https://api.github.com/repos/WebAssembly/spec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WebAssembly/spec/statuses/{sha}","languages_url":"https://api.github.com/repos/WebAssembly/spec/languages","stargazers_url":"https://api.github.com/repos/WebAssembly/spec/stargazers","contributors_url":"https://api.github.com/repos/WebAssembly/spec/contributors","subscribers_url":"https://api.github.com/repos/WebAssembly/spec/subscribers","subscription_url":"https://api.github.com/repos/WebAssembly/spec/subscription","commits_url":"https://api.github.com/repos/WebAssembly/spec/commits{/sha}","git_commits_url":"https://api.github.com/repos/WebAssembly/spec/git/commits{/sha}","comments_url":"https://api.github.com/repos/WebAssembly/spec/comments{/number}","issue_comment_url":"https://api.github.com/repos/WebAssembly/spec/issues/comments{/number}","contents_url":"https://api.github.com/repos/WebAssembly/spec/contents/{+path}","compare_url":"https://api.github.com/repos/WebAssembly/spec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WebAssembly/spec/merges","archive_url":"https://api.github.com/repos/WebAssembly/spec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WebAssembly/spec/downloads","issues_url":"https://api.github.com/repos/WebAssembly/spec/issues{/number}","pulls_url":"https://api.github.com/repos/WebAssembly/spec/pulls{/number}","milestones_url":"https://api.github.com/repos/WebAssembly/spec/milestones{/number}","notifications_url":"https://api.github.com/repos/WebAssembly/spec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WebAssembly/spec/labels{/name}","releases_url":"https://api.github.com/repos/WebAssembly/spec/releases{/id}","created_at":"2015-08-12T12:15:16Z","updated_at":"2015-10-15T04:47:12Z","pushed_at":"2015-10-15T23:50:04Z","git_url":"git://github.com/WebAssembly/spec.git","ssh_url":"git@github.com:WebAssembly/spec.git","clone_url":"https://github.com/WebAssembly/spec.git","svn_url":"https://github.com/WebAssembly/spec","homepage":null,"size":2011,"stargazers_count":74,"watchers_count":74,"language":"OCaml","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":22,"mirror_url":null,"open_issues_count":21,"forks":22,"open_issues":21,"watchers":74,"default_branch":"master"}},"base":{"label":"WebAssembly:master","ref":"master","sha":"ff81167ec48e7345374124ea6fca6d5ef2a7679c","user":{"login":"WebAssembly","id":11578470,"avatar_url":"https://avatars.githubusercontent.com/u/11578470?v=3","gravatar_id":"","url":"https://api.github.com/users/WebAssembly","html_url":"https://github.com/WebAssembly","followers_url":"https://api.github.com/users/WebAssembly/followers","following_url":"https://api.github.com/users/WebAssembly/following{/other_user}","gists_url":"https://api.github.com/users/WebAssembly/gists{/gist_id}","starred_url":"https://api.github.com/users/WebAssembly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WebAssembly/subscriptions","organizations_url":"https://api.github.com/users/WebAssembly/orgs","repos_url":"https://api.github.com/users/WebAssembly/repos","events_url":"https://api.github.com/users/WebAssembly/events{/privacy}","received_events_url":"https://api.github.com/users/WebAssembly/received_events","type":"Organization","site_admin":false},"repo":{"id":40598815,"name":"spec","full_name":"WebAssembly/spec","owner":{"login":"WebAssembly","id":11578470,"avatar_url":"https://avatars.githubusercontent.com/u/11578470?v=3","gravatar_id":"","url":"https://api.github.com/users/WebAssembly","html_url":"https://github.com/WebAssembly","followers_url":"https://api.github.com/users/WebAssembly/followers","following_url":"https://api.github.com/users/WebAssembly/following{/other_user}","gists_url":"https://api.github.com/users/WebAssembly/gists{/gist_id}","starred_url":"https://api.github.com/users/WebAssembly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WebAssembly/subscriptions","organizations_url":"https://api.github.com/users/WebAssembly/orgs","repos_url":"https://api.github.com/users/WebAssembly/repos","events_url":"https://api.github.com/users/WebAssembly/events{/privacy}","received_events_url":"https://api.github.com/users/WebAssembly/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/WebAssembly/spec","description":"Staging ground for artifacts related to an MVP spec","fork":false,"url":"https://api.github.com/repos/WebAssembly/spec","forks_url":"https://api.github.com/repos/WebAssembly/spec/forks","keys_url":"https://api.github.com/repos/WebAssembly/spec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WebAssembly/spec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WebAssembly/spec/teams","hooks_url":"https://api.github.com/repos/WebAssembly/spec/hooks","issue_events_url":"https://api.github.com/repos/WebAssembly/spec/issues/events{/number}","events_url":"https://api.github.com/repos/WebAssembly/spec/events","assignees_url":"https://api.github.com/repos/WebAssembly/spec/assignees{/user}","branches_url":"https://api.github.com/repos/WebAssembly/spec/branches{/branch}","tags_url":"https://api.github.com/repos/WebAssembly/spec/tags","blobs_url":"https://api.github.com/repos/WebAssembly/spec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WebAssembly/spec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WebAssembly/spec/git/refs{/sha}","trees_url":"https://api.github.com/repos/WebAssembly/spec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WebAssembly/spec/statuses/{sha}","languages_url":"https://api.github.com/repos/WebAssembly/spec/languages","stargazers_url":"https://api.github.com/repos/WebAssembly/spec/stargazers","contributors_url":"https://api.github.com/repos/WebAssembly/spec/contributors","subscribers_url":"https://api.github.com/repos/WebAssembly/spec/subscribers","subscription_url":"https://api.github.com/repos/WebAssembly/spec/subscription","commits_url":"https://api.github.com/repos/WebAssembly/spec/commits{/sha}","git_commits_url":"https://api.github.com/repos/WebAssembly/spec/git/commits{/sha}","comments_url":"https://api.github.com/repos/WebAssembly/spec/comments{/number}","issue_comment_url":"https://api.github.com/repos/WebAssembly/spec/issues/comments{/number}","contents_url":"https://api.github.com/repos/WebAssembly/spec/contents/{+path}","compare_url":"https://api.github.com/repos/WebAssembly/spec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WebAssembly/spec/merges","archive_url":"https://api.github.com/repos/WebAssembly/spec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WebAssembly/spec/downloads","issues_url":"https://api.github.com/repos/WebAssembly/spec/issues{/number}","pulls_url":"https://api.github.com/repos/WebAssembly/spec/pulls{/number}","milestones_url":"https://api.github.com/repos/WebAssembly/spec/milestones{/number}","notifications_url":"https://api.github.com/repos/WebAssembly/spec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WebAssembly/spec/labels{/name}","releases_url":"https://api.github.com/repos/WebAssembly/spec/releases{/id}","created_at":"2015-08-12T12:15:16Z","updated_at":"2015-10-15T04:47:12Z","pushed_at":"2015-10-15T23:50:04Z","git_url":"git://github.com/WebAssembly/spec.git","ssh_url":"git@github.com:WebAssembly/spec.git","clone_url":"https://github.com/WebAssembly/spec.git","svn_url":"https://github.com/WebAssembly/spec","homepage":null,"size":2011,"stargazers_count":74,"watchers_count":74,"language":"OCaml","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":22,"mirror_url":null,"open_issues_count":21,"forks":22,"open_issues":21,"watchers":74,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/WebAssembly/spec/pulls/138"},"html":{"href":"https://github.com/WebAssembly/spec/pull/138"},"issue":{"href":"https://api.github.com/repos/WebAssembly/spec/issues/138"},"comments":{"href":"https://api.github.com/repos/WebAssembly/spec/issues/138/comments"},"review_comments":{"href":"https://api.github.com/repos/WebAssembly/spec/pulls/138/comments"},"review_comment":{"href":"https://api.github.com/repos/WebAssembly/spec/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/WebAssembly/spec/pulls/138/commits"},"statuses":{"href":"https://api.github.com/repos/WebAssembly/spec/statuses/f8cbdac1220e5721ed48fb77ec4002b1a1e3dac4"}}}}