{"action":"opened","number":36,"pull_request":{"url":"https://api.github.com/repos/cfpb/cms-toolkit/pulls/36","id":29105395,"html_url":"https://github.com/cfpb/cms-toolkit/pull/36","diff_url":"https://github.com/cfpb/cms-toolkit/pull/36.diff","patch_url":"https://github.com/cfpb/cms-toolkit/pull/36.patch","issue_url":"https://api.github.com/repos/cfpb/cms-toolkit/issues/36","number":36,"state":"open","locked":false,"title":"Add tests for HTML and refactor accordingly","user":{"login":"kurtw","id":1412978,"avatar_url":"https://avatars.githubusercontent.com/u/1412978?v=3","gravatar_id":"","url":"https://api.github.com/users/kurtw","html_url":"https://github.com/kurtw","followers_url":"https://api.github.com/users/kurtw/followers","following_url":"https://api.github.com/users/kurtw/following{/other_user}","gists_url":"https://api.github.com/users/kurtw/gists{/gist_id}","starred_url":"https://api.github.com/users/kurtw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kurtw/subscriptions","organizations_url":"https://api.github.com/users/kurtw/orgs","repos_url":"https://api.github.com/users/kurtw/repos","events_url":"https://api.github.com/users/kurtw/events{/privacy}","received_events_url":"https://api.github.com/users/kurtw/received_events","type":"User","site_admin":false},"body":"The HTML was _virtually_ untested for the life of this plugin. Now, there are 67 tests for it! For anyone reviewing this, I'm sorry there are so many. This needed to get done though. \r\n\r\nMany of these tests are unfortunately brittle. Many of these tests rely on a specific output of HTML in order to pass. Any change to the HTML output could result in failing tests. There should be a discussion on whether or not tests of this level of output accuracy are needed/wanted.\r\n\r\nIF these tests get pulled in, any developer making changes to the HTML should be **cautioned** of this and test frequently during development.\r\n ![selfie-0](http://i.imgur.com/QCkdN0E.gif)","created_at":"2015-02-11T16:29:26Z","updated_at":"2015-02-11T16:29:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cfpb/cms-toolkit/pulls/36/commits","review_comments_url":"https://api.github.com/repos/cfpb/cms-toolkit/pulls/36/comments","review_comment_url":"https://api.github.com/repos/cfpb/cms-toolkit/pulls/comments/{number}","comments_url":"https://api.github.com/repos/cfpb/cms-toolkit/issues/36/comments","statuses_url":"https://api.github.com/repos/cfpb/cms-toolkit/statuses/b381c334f8103e830e43080a428d57d5e9571c8d","head":{"label":"kurtw:testandrefactor","ref":"testandrefactor","sha":"b381c334f8103e830e43080a428d57d5e9571c8d","user":{"login":"kurtw","id":1412978,"avatar_url":"https://avatars.githubusercontent.com/u/1412978?v=3","gravatar_id":"","url":"https://api.github.com/users/kurtw","html_url":"https://github.com/kurtw","followers_url":"https://api.github.com/users/kurtw/followers","following_url":"https://api.github.com/users/kurtw/following{/other_user}","gists_url":"https://api.github.com/users/kurtw/gists{/gist_id}","starred_url":"https://api.github.com/users/kurtw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kurtw/subscriptions","organizations_url":"https://api.github.com/users/kurtw/orgs","repos_url":"https://api.github.com/users/kurtw/repos","events_url":"https://api.github.com/users/kurtw/events{/privacy}","received_events_url":"https://api.github.com/users/kurtw/received_events","type":"User","site_admin":false},"repo":{"id":26027429,"name":"cms-toolkit","full_name":"kurtw/cms-toolkit","owner":{"login":"kurtw","id":1412978,"avatar_url":"https://avatars.githubusercontent.com/u/1412978?v=3","gravatar_id":"","url":"https://api.github.com/users/kurtw","html_url":"https://github.com/kurtw","followers_url":"https://api.github.com/users/kurtw/followers","following_url":"https://api.github.com/users/kurtw/following{/other_user}","gists_url":"https://api.github.com/users/kurtw/gists{/gist_id}","starred_url":"https://api.github.com/users/kurtw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kurtw/subscriptions","organizations_url":"https://api.github.com/users/kurtw/orgs","repos_url":"https://api.github.com/users/kurtw/repos","events_url":"https://api.github.com/users/kurtw/events{/privacy}","received_events_url":"https://api.github.com/users/kurtw/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kurtw/cms-toolkit","description":"","fork":true,"url":"https://api.github.com/repos/kurtw/cms-toolkit","forks_url":"https://api.github.com/repos/kurtw/cms-toolkit/forks","keys_url":"https://api.github.com/repos/kurtw/cms-toolkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kurtw/cms-toolkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kurtw/cms-toolkit/teams","hooks_url":"https://api.github.com/repos/kurtw/cms-toolkit/hooks","issue_events_url":"https://api.github.com/repos/kurtw/cms-toolkit/issues/events{/number}","events_url":"https://api.github.com/repos/kurtw/cms-toolkit/events","assignees_url":"https://api.github.com/repos/kurtw/cms-toolkit/assignees{/user}","branches_url":"https://api.github.com/repos/kurtw/cms-toolkit/branches{/branch}","tags_url":"https://api.github.com/repos/kurtw/cms-toolkit/tags","blobs_url":"https://api.github.com/repos/kurtw/cms-toolkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kurtw/cms-toolkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kurtw/cms-toolkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/kurtw/cms-toolkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kurtw/cms-toolkit/statuses/{sha}","languages_url":"https://api.github.com/repos/kurtw/cms-toolkit/languages","stargazers_url":"https://api.github.com/repos/kurtw/cms-toolkit/stargazers","contributors_url":"https://api.github.com/repos/kurtw/cms-toolkit/contributors","subscribers_url":"https://api.github.com/repos/kurtw/cms-toolkit/subscribers","subscription_url":"https://api.github.com/repos/kurtw/cms-toolkit/subscription","commits_url":"https://api.github.com/repos/kurtw/cms-toolkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/kurtw/cms-toolkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/kurtw/cms-toolkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/kurtw/cms-toolkit/issues/comments/{number}","contents_url":"https://api.github.com/repos/kurtw/cms-toolkit/contents/{+path}","compare_url":"https://api.github.com/repos/kurtw/cms-toolkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kurtw/cms-toolkit/merges","archive_url":"https://api.github.com/repos/kurtw/cms-toolkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kurtw/cms-toolkit/downloads","issues_url":"https://api.github.com/repos/kurtw/cms-toolkit/issues{/number}","pulls_url":"https://api.github.com/repos/kurtw/cms-toolkit/pulls{/number}","milestones_url":"https://api.github.com/repos/kurtw/cms-toolkit/milestones{/number}","notifications_url":"https://api.github.com/repos/kurtw/cms-toolkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kurtw/cms-toolkit/labels{/name}","releases_url":"https://api.github.com/repos/kurtw/cms-toolkit/releases{/id}","created_at":"2014-10-31T18:04:15Z","updated_at":"2015-02-10T23:40:55Z","pushed_at":"2015-02-11T00:12:28Z","git_url":"git://github.com/kurtw/cms-toolkit.git","ssh_url":"git@github.com:kurtw/cms-toolkit.git","clone_url":"https://github.com/kurtw/cms-toolkit.git","svn_url":"https://github.com/kurtw/cms-toolkit","homepage":null,"size":595,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cfpb:master","ref":"master","sha":"e0d2d6ab11ca68337198982e217b774ed8ef336c","user":{"login":"cfpb","id":1071563,"avatar_url":"https://avatars.githubusercontent.com/u/1071563?v=3","gravatar_id":"","url":"https://api.github.com/users/cfpb","html_url":"https://github.com/cfpb","followers_url":"https://api.github.com/users/cfpb/followers","following_url":"https://api.github.com/users/cfpb/following{/other_user}","gists_url":"https://api.github.com/users/cfpb/gists{/gist_id}","starred_url":"https://api.github.com/users/cfpb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfpb/subscriptions","organizations_url":"https://api.github.com/users/cfpb/orgs","repos_url":"https://api.github.com/users/cfpb/repos","events_url":"https://api.github.com/users/cfpb/events{/privacy}","received_events_url":"https://api.github.com/users/cfpb/received_events","type":"Organization","site_admin":false},"repo":{"id":20657754,"name":"cms-toolkit","full_name":"cfpb/cms-toolkit","owner":{"login":"cfpb","id":1071563,"avatar_url":"https://avatars.githubusercontent.com/u/1071563?v=3","gravatar_id":"","url":"https://api.github.com/users/cfpb","html_url":"https://github.com/cfpb","followers_url":"https://api.github.com/users/cfpb/followers","following_url":"https://api.github.com/users/cfpb/following{/other_user}","gists_url":"https://api.github.com/users/cfpb/gists{/gist_id}","starred_url":"https://api.github.com/users/cfpb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfpb/subscriptions","organizations_url":"https://api.github.com/users/cfpb/orgs","repos_url":"https://api.github.com/users/cfpb/repos","events_url":"https://api.github.com/users/cfpb/events{/privacy}","received_events_url":"https://api.github.com/users/cfpb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cfpb/cms-toolkit","description":"","fork":false,"url":"https://api.github.com/repos/cfpb/cms-toolkit","forks_url":"https://api.github.com/repos/cfpb/cms-toolkit/forks","keys_url":"https://api.github.com/repos/cfpb/cms-toolkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cfpb/cms-toolkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cfpb/cms-toolkit/teams","hooks_url":"https://api.github.com/repos/cfpb/cms-toolkit/hooks","issue_events_url":"https://api.github.com/repos/cfpb/cms-toolkit/issues/events{/number}","events_url":"https://api.github.com/repos/cfpb/cms-toolkit/events","assignees_url":"https://api.github.com/repos/cfpb/cms-toolkit/assignees{/user}","branches_url":"https://api.github.com/repos/cfpb/cms-toolkit/branches{/branch}","tags_url":"https://api.github.com/repos/cfpb/cms-toolkit/tags","blobs_url":"https://api.github.com/repos/cfpb/cms-toolkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cfpb/cms-toolkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cfpb/cms-toolkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/cfpb/cms-toolkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cfpb/cms-toolkit/statuses/{sha}","languages_url":"https://api.github.com/repos/cfpb/cms-toolkit/languages","stargazers_url":"https://api.github.com/repos/cfpb/cms-toolkit/stargazers","contributors_url":"https://api.github.com/repos/cfpb/cms-toolkit/contributors","subscribers_url":"https://api.github.com/repos/cfpb/cms-toolkit/subscribers","subscription_url":"https://api.github.com/repos/cfpb/cms-toolkit/subscription","commits_url":"https://api.github.com/repos/cfpb/cms-toolkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/cfpb/cms-toolkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/cfpb/cms-toolkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/cfpb/cms-toolkit/issues/comments/{number}","contents_url":"https://api.github.com/repos/cfpb/cms-toolkit/contents/{+path}","compare_url":"https://api.github.com/repos/cfpb/cms-toolkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cfpb/cms-toolkit/merges","archive_url":"https://api.github.com/repos/cfpb/cms-toolkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cfpb/cms-toolkit/downloads","issues_url":"https://api.github.com/repos/cfpb/cms-toolkit/issues{/number}","pulls_url":"https://api.github.com/repos/cfpb/cms-toolkit/pulls{/number}","milestones_url":"https://api.github.com/repos/cfpb/cms-toolkit/milestones{/number}","notifications_url":"https://api.github.com/repos/cfpb/cms-toolkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cfpb/cms-toolkit/labels{/name}","releases_url":"https://api.github.com/repos/cfpb/cms-toolkit/releases{/id}","created_at":"2014-06-09T18:37:25Z","updated_at":"2015-02-02T18:09:11Z","pushed_at":"2015-02-02T18:09:11Z","git_url":"git://github.com/cfpb/cms-toolkit.git","ssh_url":"git@github.com:cfpb/cms-toolkit.git","clone_url":"https://github.com/cfpb/cms-toolkit.git","svn_url":"https://github.com/cfpb/cms-toolkit","homepage":null,"size":732,"stargazers_count":3,"watchers_count":3,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"open_issues_count":2,"forks":23,"open_issues":2,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cfpb/cms-toolkit/pulls/36"},"html":{"href":"https://github.com/cfpb/cms-toolkit/pull/36"},"issue":{"href":"https://api.github.com/repos/cfpb/cms-toolkit/issues/36"},"comments":{"href":"https://api.github.com/repos/cfpb/cms-toolkit/issues/36/comments"},"review_comments":{"href":"https://api.github.com/repos/cfpb/cms-toolkit/pulls/36/comments"},"review_comment":{"href":"https://api.github.com/repos/cfpb/cms-toolkit/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/cfpb/cms-toolkit/pulls/36/commits"},"statuses":{"href":"https://api.github.com/repos/cfpb/cms-toolkit/statuses/b381c334f8103e830e43080a428d57d5e9571c8d"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":6,"additions":1934,"deletions":216,"changed_files":6}}