{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/23065867","id":23065867,"diff_hunk":"@@ -146,6 +185,10 @@ class TaskMetrics extends Serializable {\n     }\n     _shuffleReadMetrics = Some(merged)\n   }\n+\n+  private[spark] def updateInputMetrics() = synchronized {","path":"core/src/main/scala/org/apache/spark/executor/TaskMetrics.scala","position":67,"original_position":67,"commit_id":"54e6658d937f2da1c7ab9a2f8412e3a0cfc420b3","original_commit_id":"54e6658d937f2da1c7ab9a2f8412e3a0cfc420b3","user":{"login":"rxin","id":323388,"avatar_url":"https://avatars.githubusercontent.com/u/323388?v=3","gravatar_id":"","url":"https://api.github.com/users/rxin","html_url":"https://github.com/rxin","followers_url":"https://api.github.com/users/rxin/followers","following_url":"https://api.github.com/users/rxin/following{/other_user}","gists_url":"https://api.github.com/users/rxin/gists{/gist_id}","starred_url":"https://api.github.com/users/rxin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rxin/subscriptions","organizations_url":"https://api.github.com/users/rxin/orgs","repos_url":"https://api.github.com/users/rxin/repos","events_url":"https://api.github.com/users/rxin/events{/privacy}","received_events_url":"https://api.github.com/users/rxin/received_events","type":"User","site_admin":false},"body":"in your next pr, can u fix this by adding a return type explicitly?","created_at":"2015-01-16T07:10:15Z","updated_at":"2015-01-16T07:10:15Z","html_url":"https://github.com/apache/spark/pull/3120#discussion_r23065867","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/3120","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/23065867"},"html":{"href":"https://github.com/apache/spark/pull/3120#discussion_r23065867"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/3120"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/3120","id":23941086,"html_url":"https://github.com/apache/spark/pull/3120","diff_url":"https://github.com/apache/spark/pull/3120.diff","patch_url":"https://github.com/apache/spark/pull/3120.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/3120","number":3120,"state":"closed","locked":false,"title":"[SPARK-4092] [CORE] Fix InputMetrics for coalesce'd Rdds","user":{"login":"ksakellis","id":6590087,"avatar_url":"https://avatars.githubusercontent.com/u/6590087?v=3","gravatar_id":"","url":"https://api.github.com/users/ksakellis","html_url":"https://github.com/ksakellis","followers_url":"https://api.github.com/users/ksakellis/followers","following_url":"https://api.github.com/users/ksakellis/following{/other_user}","gists_url":"https://api.github.com/users/ksakellis/gists{/gist_id}","starred_url":"https://api.github.com/users/ksakellis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ksakellis/subscriptions","organizations_url":"https://api.github.com/users/ksakellis/orgs","repos_url":"https://api.github.com/users/ksakellis/repos","events_url":"https://api.github.com/users/ksakellis/events{/privacy}","received_events_url":"https://api.github.com/users/ksakellis/received_events","type":"User","site_admin":false},"body":"When calculating the input metrics there was an assumption that one task only reads from one block - this is not true for some operations including coalesce. This patch simply increments the task's input metrics if previous ones existed of the same read method.\r\n\r\nA limitation to this patch is that if a task reads from two different blocks of different read methods, one will override the other.","created_at":"2014-11-05T21:52:35Z","updated_at":"2015-01-16T07:10:15Z","closed_at":"2015-01-16T02:49:37Z","merged_at":null,"merge_commit_sha":"ef8b26bff12aab408d70e3b4a318ef105024f195","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/3120/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/3120/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments/{number}","comments_url":"https://api.github.com/repos/apache/spark/issues/3120/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/54e6658d937f2da1c7ab9a2f8412e3a0cfc420b3","head":{"label":"ksakellis:kostas-spark-4092","ref":"kostas-spark-4092","sha":"54e6658d937f2da1c7ab9a2f8412e3a0cfc420b3","user":{"login":"ksakellis","id":6590087,"avatar_url":"https://avatars.githubusercontent.com/u/6590087?v=3","gravatar_id":"","url":"https://api.github.com/users/ksakellis","html_url":"https://github.com/ksakellis","followers_url":"https://api.github.com/users/ksakellis/followers","following_url":"https://api.github.com/users/ksakellis/following{/other_user}","gists_url":"https://api.github.com/users/ksakellis/gists{/gist_id}","starred_url":"https://api.github.com/users/ksakellis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ksakellis/subscriptions","organizations_url":"https://api.github.com/users/ksakellis/orgs","repos_url":"https://api.github.com/users/ksakellis/repos","events_url":"https://api.github.com/users/ksakellis/events{/privacy}","received_events_url":"https://api.github.com/users/ksakellis/received_events","type":"User","site_admin":false},"repo":{"id":23167909,"name":"spark","full_name":"ksakellis/spark","owner":{"login":"ksakellis","id":6590087,"avatar_url":"https://avatars.githubusercontent.com/u/6590087?v=3","gravatar_id":"","url":"https://api.github.com/users/ksakellis","html_url":"https://github.com/ksakellis","followers_url":"https://api.github.com/users/ksakellis/followers","following_url":"https://api.github.com/users/ksakellis/following{/other_user}","gists_url":"https://api.github.com/users/ksakellis/gists{/gist_id}","starred_url":"https://api.github.com/users/ksakellis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ksakellis/subscriptions","organizations_url":"https://api.github.com/users/ksakellis/orgs","repos_url":"https://api.github.com/users/ksakellis/repos","events_url":"https://api.github.com/users/ksakellis/events{/privacy}","received_events_url":"https://api.github.com/users/ksakellis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ksakellis/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/ksakellis/spark","forks_url":"https://api.github.com/repos/ksakellis/spark/forks","keys_url":"https://api.github.com/repos/ksakellis/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ksakellis/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ksakellis/spark/teams","hooks_url":"https://api.github.com/repos/ksakellis/spark/hooks","issue_events_url":"https://api.github.com/repos/ksakellis/spark/issues/events{/number}","events_url":"https://api.github.com/repos/ksakellis/spark/events","assignees_url":"https://api.github.com/repos/ksakellis/spark/assignees{/user}","branches_url":"https://api.github.com/repos/ksakellis/spark/branches{/branch}","tags_url":"https://api.github.com/repos/ksakellis/spark/tags","blobs_url":"https://api.github.com/repos/ksakellis/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ksakellis/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ksakellis/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/ksakellis/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ksakellis/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/ksakellis/spark/languages","stargazers_url":"https://api.github.com/repos/ksakellis/spark/stargazers","contributors_url":"https://api.github.com/repos/ksakellis/spark/contributors","subscribers_url":"https://api.github.com/repos/ksakellis/spark/subscribers","subscription_url":"https://api.github.com/repos/ksakellis/spark/subscription","commits_url":"https://api.github.com/repos/ksakellis/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/ksakellis/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/ksakellis/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/ksakellis/spark/issues/comments/{number}","contents_url":"https://api.github.com/repos/ksakellis/spark/contents/{+path}","compare_url":"https://api.github.com/repos/ksakellis/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ksakellis/spark/merges","archive_url":"https://api.github.com/repos/ksakellis/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ksakellis/spark/downloads","issues_url":"https://api.github.com/repos/ksakellis/spark/issues{/number}","pulls_url":"https://api.github.com/repos/ksakellis/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/ksakellis/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/ksakellis/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ksakellis/spark/labels{/name}","releases_url":"https://api.github.com/repos/ksakellis/spark/releases{/id}","created_at":"2014-08-20T23:45:14Z","updated_at":"2015-01-16T06:59:02Z","pushed_at":"2015-01-16T06:59:00Z","git_url":"git://github.com/ksakellis/spark.git","ssh_url":"git@github.com:ksakellis/spark.git","clone_url":"https://github.com/ksakellis/spark.git","svn_url":"https://github.com/ksakellis/spark","homepage":null,"size":86945,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"d5eeb35167e1ab72fab7778757163ff0aacaef2c","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments/{number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","created_at":"2014-02-25T08:00:08Z","updated_at":"2015-01-16T06:56:51Z","pushed_at":"2015-01-16T02:48:52Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":1144290,"stargazers_count":2575,"watchers_count":2575,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2275,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":311,"forks":2275,"open_issues":311,"watchers":2575,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/3120"},"html":{"href":"https://github.com/apache/spark/pull/3120"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/3120"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/3120/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/3120/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/3120/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/54e6658d937f2da1c7ab9a2f8412e3a0cfc420b3"}}}}