{"action":"created","comment":{"url":"https://api.github.com/repos/openmicroscopy/bioformats/pulls/comments/29922609","id":29922609,"diff_hunk":"@@ -317,13 +325,23 @@ public void testParseLongException() {\n     // NumberFormatException should be catched internally when parsing\n     // milliseconds but the method should still return \n     String date1 = REFERENCE_DATE + \".a11\";\n-    String referenceDateISO8601 = \"1970-01-01T00:00:00\";\n     assertEquals(0L, DateTools.getTime(date1, DATE_FORMAT, \".\"));\n-    assertEquals(referenceDateISO8601, DateTools.formatDate(date1, DATE_FORMAT, \".\"));\n-    assertEquals(referenceDateISO8601, DateTools.formatDate(date1, DATE_FORMAT, false, \".\"));\n+    assertEquals(REFERENCE_ISO8601, DateTools.formatDate(date1, DATE_FORMAT, \".\"));\n+    assertEquals(REFERENCE_ISO8601, DateTools.formatDate(date1, DATE_FORMAT, false, \".\"));\n     String date2 = REFERENCE_DATE + \".a11 aa\";\n     assertEquals(0L, DateTools.getTime(date2, DATE_FORMAT, \".\"));\n-    assertEquals(referenceDateISO8601, DateTools.formatDate(date2, DATE_FORMAT, \".\"));\n-    assertEquals(referenceDateISO8601, DateTools.formatDate(date2, DATE_FORMAT, false, \".\"));\n+    assertEquals(REFERENCE_ISO8601, DateTools.formatDate(date2, DATE_FORMAT, \".\"));\n+    assertEquals(REFERENCE_ISO8601, DateTools.formatDate(date2, DATE_FORMAT, false, \".\"));\n+  }\n+\n+  @Test\n+  public void testTrim() {\n+      String date1 = \" \" + REFERENCE_DATE;\n+      assertEquals(0L, DateTools.getTime(date1, DATE_FORMAT));\n+      assertEquals(REFERENCE_ISO8601, DateTools.formatDate(date1, DATE_FORMAT));","path":"components/formats-common/test/loci/common/utests/DateToolsTest.java","position":62,"original_position":62,"commit_id":"2675df793d2903be484b63b7198cbac4b4ab392c","original_commit_id":"2675df793d2903be484b63b7198cbac4b4ab392c","user":{"login":"mtbc","id":2630707,"avatar_url":"https://avatars.githubusercontent.com/u/2630707?v=3","gravatar_id":"","url":"https://api.github.com/users/mtbc","html_url":"https://github.com/mtbc","followers_url":"https://api.github.com/users/mtbc/followers","following_url":"https://api.github.com/users/mtbc/following{/other_user}","gists_url":"https://api.github.com/users/mtbc/gists{/gist_id}","starred_url":"https://api.github.com/users/mtbc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtbc/subscriptions","organizations_url":"https://api.github.com/users/mtbc/orgs","repos_url":"https://api.github.com/users/mtbc/repos","events_url":"https://api.github.com/users/mtbc/events{/privacy}","received_events_url":"https://api.github.com/users/mtbc/received_events","type":"User","site_admin":false},"body":"inconsistent indent in this method","created_at":"2015-05-08T08:02:56Z","updated_at":"2015-05-08T08:02:56Z","html_url":"https://github.com/openmicroscopy/bioformats/pull/1786#discussion_r29922609","pull_request_url":"https://api.github.com/repos/openmicroscopy/bioformats/pulls/1786","_links":{"self":{"href":"https://api.github.com/repos/openmicroscopy/bioformats/pulls/comments/29922609"},"html":{"href":"https://github.com/openmicroscopy/bioformats/pull/1786#discussion_r29922609"},"pull_request":{"href":"https://api.github.com/repos/openmicroscopy/bioformats/pulls/1786"}}},"pull_request":{"url":"https://api.github.com/repos/openmicroscopy/bioformats/pulls/1786","id":34916716,"html_url":"https://github.com/openmicroscopy/bioformats/pull/1786","diff_url":"https://github.com/openmicroscopy/bioformats/pull/1786.diff","patch_url":"https://github.com/openmicroscopy/bioformats/pull/1786.patch","issue_url":"https://api.github.com/repos/openmicroscopy/bioformats/issues/1786","number":1786,"state":"open","locked":false,"title":"Joda milliseconds parsing (tests)","user":{"login":"sbesson","id":1355463,"avatar_url":"https://avatars.githubusercontent.com/u/1355463?v=3","gravatar_id":"","url":"https://api.github.com/users/sbesson","html_url":"https://github.com/sbesson","followers_url":"https://api.github.com/users/sbesson/followers","following_url":"https://api.github.com/users/sbesson/following{/other_user}","gists_url":"https://api.github.com/users/sbesson/gists{/gist_id}","starred_url":"https://api.github.com/users/sbesson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbesson/subscriptions","organizations_url":"https://api.github.com/users/sbesson/orgs","repos_url":"https://api.github.com/users/sbesson/repos","events_url":"https://api.github.com/users/sbesson/events{/privacy}","received_events_url":"https://api.github.com/users/sbesson/received_events","type":"User","site_admin":false},"body":"Follow up of https://github.com/openmicroscopy/bioformats/pull/1764\r\n\r\nTwo unit tests commits that were not pushed to the previous PR but should extend the test coverage for:\r\n- handling of different patterns (` aa`, `Z`) post milliseconds\r\n- trimming of the date string before date parsing\r\n","created_at":"2015-05-07T13:46:22Z","updated_at":"2015-05-08T08:02:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b68471a035caf63b57bd823d81161db321529461","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openmicroscopy/bioformats/pulls/1786/commits","review_comments_url":"https://api.github.com/repos/openmicroscopy/bioformats/pulls/1786/comments","review_comment_url":"https://api.github.com/repos/openmicroscopy/bioformats/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openmicroscopy/bioformats/issues/1786/comments","statuses_url":"https://api.github.com/repos/openmicroscopy/bioformats/statuses/2675df793d2903be484b63b7198cbac4b4ab392c","head":{"label":"sbesson:joda_parse_date","ref":"joda_parse_date","sha":"2675df793d2903be484b63b7198cbac4b4ab392c","user":{"login":"sbesson","id":1355463,"avatar_url":"https://avatars.githubusercontent.com/u/1355463?v=3","gravatar_id":"","url":"https://api.github.com/users/sbesson","html_url":"https://github.com/sbesson","followers_url":"https://api.github.com/users/sbesson/followers","following_url":"https://api.github.com/users/sbesson/following{/other_user}","gists_url":"https://api.github.com/users/sbesson/gists{/gist_id}","starred_url":"https://api.github.com/users/sbesson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbesson/subscriptions","organizations_url":"https://api.github.com/users/sbesson/orgs","repos_url":"https://api.github.com/users/sbesson/repos","events_url":"https://api.github.com/users/sbesson/events{/privacy}","received_events_url":"https://api.github.com/users/sbesson/received_events","type":"User","site_admin":false},"repo":{"id":3541327,"name":"bioformats","full_name":"sbesson/bioformats","owner":{"login":"sbesson","id":1355463,"avatar_url":"https://avatars.githubusercontent.com/u/1355463?v=3","gravatar_id":"","url":"https://api.github.com/users/sbesson","html_url":"https://github.com/sbesson","followers_url":"https://api.github.com/users/sbesson/followers","following_url":"https://api.github.com/users/sbesson/following{/other_user}","gists_url":"https://api.github.com/users/sbesson/gists{/gist_id}","starred_url":"https://api.github.com/users/sbesson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbesson/subscriptions","organizations_url":"https://api.github.com/users/sbesson/orgs","repos_url":"https://api.github.com/users/sbesson/repos","events_url":"https://api.github.com/users/sbesson/events{/privacy}","received_events_url":"https://api.github.com/users/sbesson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sbesson/bioformats","description":"Bio-Formats is a Java library for reading and writing data in life sciences image file formats. It is developed by the  Open Microscopy Environment (particularly  UW-Madison LOCI and  Glencoe Software). Bio-Formats is released under the  GNU General Public License (GPL); commercial licenses are available from  Glencoe Software. ","fork":true,"url":"https://api.github.com/repos/sbesson/bioformats","forks_url":"https://api.github.com/repos/sbesson/bioformats/forks","keys_url":"https://api.github.com/repos/sbesson/bioformats/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sbesson/bioformats/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sbesson/bioformats/teams","hooks_url":"https://api.github.com/repos/sbesson/bioformats/hooks","issue_events_url":"https://api.github.com/repos/sbesson/bioformats/issues/events{/number}","events_url":"https://api.github.com/repos/sbesson/bioformats/events","assignees_url":"https://api.github.com/repos/sbesson/bioformats/assignees{/user}","branches_url":"https://api.github.com/repos/sbesson/bioformats/branches{/branch}","tags_url":"https://api.github.com/repos/sbesson/bioformats/tags","blobs_url":"https://api.github.com/repos/sbesson/bioformats/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sbesson/bioformats/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sbesson/bioformats/git/refs{/sha}","trees_url":"https://api.github.com/repos/sbesson/bioformats/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sbesson/bioformats/statuses/{sha}","languages_url":"https://api.github.com/repos/sbesson/bioformats/languages","stargazers_url":"https://api.github.com/repos/sbesson/bioformats/stargazers","contributors_url":"https://api.github.com/repos/sbesson/bioformats/contributors","subscribers_url":"https://api.github.com/repos/sbesson/bioformats/subscribers","subscription_url":"https://api.github.com/repos/sbesson/bioformats/subscription","commits_url":"https://api.github.com/repos/sbesson/bioformats/commits{/sha}","git_commits_url":"https://api.github.com/repos/sbesson/bioformats/git/commits{/sha}","comments_url":"https://api.github.com/repos/sbesson/bioformats/comments{/number}","issue_comment_url":"https://api.github.com/repos/sbesson/bioformats/issues/comments{/number}","contents_url":"https://api.github.com/repos/sbesson/bioformats/contents/{+path}","compare_url":"https://api.github.com/repos/sbesson/bioformats/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sbesson/bioformats/merges","archive_url":"https://api.github.com/repos/sbesson/bioformats/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sbesson/bioformats/downloads","issues_url":"https://api.github.com/repos/sbesson/bioformats/issues{/number}","pulls_url":"https://api.github.com/repos/sbesson/bioformats/pulls{/number}","milestones_url":"https://api.github.com/repos/sbesson/bioformats/milestones{/number}","notifications_url":"https://api.github.com/repos/sbesson/bioformats/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sbesson/bioformats/labels{/name}","releases_url":"https://api.github.com/repos/sbesson/bioformats/releases{/id}","created_at":"2012-02-25T00:50:54Z","updated_at":"2015-05-07T13:40:01Z","pushed_at":"2015-05-07T13:43:27Z","git_url":"git://github.com/sbesson/bioformats.git","ssh_url":"git@github.com:sbesson/bioformats.git","clone_url":"https://github.com/sbesson/bioformats.git","svn_url":"https://github.com/sbesson/bioformats","homepage":"http://trac.openmicroscopy.org.uk/ome/wiki/BioFormats","size":255088,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"develop"}},"base":{"label":"openmicroscopy:develop","ref":"develop","sha":"5042f22f4e932ecc53410c8df5ea8325efb8bc22","user":{"login":"openmicroscopy","id":975861,"avatar_url":"https://avatars.githubusercontent.com/u/975861?v=3","gravatar_id":"","url":"https://api.github.com/users/openmicroscopy","html_url":"https://github.com/openmicroscopy","followers_url":"https://api.github.com/users/openmicroscopy/followers","following_url":"https://api.github.com/users/openmicroscopy/following{/other_user}","gists_url":"https://api.github.com/users/openmicroscopy/gists{/gist_id}","starred_url":"https://api.github.com/users/openmicroscopy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openmicroscopy/subscriptions","organizations_url":"https://api.github.com/users/openmicroscopy/orgs","repos_url":"https://api.github.com/users/openmicroscopy/repos","events_url":"https://api.github.com/users/openmicroscopy/events{/privacy}","received_events_url":"https://api.github.com/users/openmicroscopy/received_events","type":"Organization","site_admin":false},"repo":{"id":2510503,"name":"bioformats","full_name":"openmicroscopy/bioformats","owner":{"login":"openmicroscopy","id":975861,"avatar_url":"https://avatars.githubusercontent.com/u/975861?v=3","gravatar_id":"","url":"https://api.github.com/users/openmicroscopy","html_url":"https://github.com/openmicroscopy","followers_url":"https://api.github.com/users/openmicroscopy/followers","following_url":"https://api.github.com/users/openmicroscopy/following{/other_user}","gists_url":"https://api.github.com/users/openmicroscopy/gists{/gist_id}","starred_url":"https://api.github.com/users/openmicroscopy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openmicroscopy/subscriptions","organizations_url":"https://api.github.com/users/openmicroscopy/orgs","repos_url":"https://api.github.com/users/openmicroscopy/repos","events_url":"https://api.github.com/users/openmicroscopy/events{/privacy}","received_events_url":"https://api.github.com/users/openmicroscopy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openmicroscopy/bioformats","description":"Bio-Formats is a Java library for reading and writing data in life sciences image file formats. It is developed by the  Open Microscopy Environment (particularly  UW-Madison LOCI and  Glencoe Software). Bio-Formats is released under the  GNU General Public License (GPL); commercial licenses are available from  Glencoe Software. ","fork":false,"url":"https://api.github.com/repos/openmicroscopy/bioformats","forks_url":"https://api.github.com/repos/openmicroscopy/bioformats/forks","keys_url":"https://api.github.com/repos/openmicroscopy/bioformats/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openmicroscopy/bioformats/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openmicroscopy/bioformats/teams","hooks_url":"https://api.github.com/repos/openmicroscopy/bioformats/hooks","issue_events_url":"https://api.github.com/repos/openmicroscopy/bioformats/issues/events{/number}","events_url":"https://api.github.com/repos/openmicroscopy/bioformats/events","assignees_url":"https://api.github.com/repos/openmicroscopy/bioformats/assignees{/user}","branches_url":"https://api.github.com/repos/openmicroscopy/bioformats/branches{/branch}","tags_url":"https://api.github.com/repos/openmicroscopy/bioformats/tags","blobs_url":"https://api.github.com/repos/openmicroscopy/bioformats/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openmicroscopy/bioformats/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openmicroscopy/bioformats/git/refs{/sha}","trees_url":"https://api.github.com/repos/openmicroscopy/bioformats/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openmicroscopy/bioformats/statuses/{sha}","languages_url":"https://api.github.com/repos/openmicroscopy/bioformats/languages","stargazers_url":"https://api.github.com/repos/openmicroscopy/bioformats/stargazers","contributors_url":"https://api.github.com/repos/openmicroscopy/bioformats/contributors","subscribers_url":"https://api.github.com/repos/openmicroscopy/bioformats/subscribers","subscription_url":"https://api.github.com/repos/openmicroscopy/bioformats/subscription","commits_url":"https://api.github.com/repos/openmicroscopy/bioformats/commits{/sha}","git_commits_url":"https://api.github.com/repos/openmicroscopy/bioformats/git/commits{/sha}","comments_url":"https://api.github.com/repos/openmicroscopy/bioformats/comments{/number}","issue_comment_url":"https://api.github.com/repos/openmicroscopy/bioformats/issues/comments{/number}","contents_url":"https://api.github.com/repos/openmicroscopy/bioformats/contents/{+path}","compare_url":"https://api.github.com/repos/openmicroscopy/bioformats/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openmicroscopy/bioformats/merges","archive_url":"https://api.github.com/repos/openmicroscopy/bioformats/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openmicroscopy/bioformats/downloads","issues_url":"https://api.github.com/repos/openmicroscopy/bioformats/issues{/number}","pulls_url":"https://api.github.com/repos/openmicroscopy/bioformats/pulls{/number}","milestones_url":"https://api.github.com/repos/openmicroscopy/bioformats/milestones{/number}","notifications_url":"https://api.github.com/repos/openmicroscopy/bioformats/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openmicroscopy/bioformats/labels{/name}","releases_url":"https://api.github.com/repos/openmicroscopy/bioformats/releases{/id}","created_at":"2011-10-04T08:06:14Z","updated_at":"2015-05-07T13:37:23Z","pushed_at":"2015-05-07T22:26:21Z","git_url":"git://github.com/openmicroscopy/bioformats.git","ssh_url":"git@github.com:openmicroscopy/bioformats.git","clone_url":"https://github.com/openmicroscopy/bioformats.git","svn_url":"https://github.com/openmicroscopy/bioformats","homepage":"http://www.openmicroscopy.org/site/products/bio-formats","size":282723,"stargazers_count":82,"watchers_count":82,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":105,"mirror_url":null,"open_issues_count":18,"forks":105,"open_issues":18,"watchers":82,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/openmicroscopy/bioformats/pulls/1786"},"html":{"href":"https://github.com/openmicroscopy/bioformats/pull/1786"},"issue":{"href":"https://api.github.com/repos/openmicroscopy/bioformats/issues/1786"},"comments":{"href":"https://api.github.com/repos/openmicroscopy/bioformats/issues/1786/comments"},"review_comments":{"href":"https://api.github.com/repos/openmicroscopy/bioformats/pulls/1786/comments"},"review_comment":{"href":"https://api.github.com/repos/openmicroscopy/bioformats/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openmicroscopy/bioformats/pulls/1786/commits"},"statuses":{"href":"https://api.github.com/repos/openmicroscopy/bioformats/statuses/2675df793d2903be484b63b7198cbac4b4ab392c"}}}}