{"action":"created","comment":{"url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/comments/40887760","id":40887760,"diff_hunk":"@@ -18,12 +18,12 @@\n \n include_recipe \"utils\"\n \n-unless node[:platform] == \"windows\" or ::File.exists?(\"/usr/sbin/ipmitool\") or ::File.exists?(\"/usr/bin/ipmitool\")\n+unless node[:platform_family] == \"windows\" or ::File.exists?(\"/usr/sbin/ipmitool\") or ::File.exists?(\"/usr/bin/ipmitool\")","path":"chef/cookbooks/ipmi/recipes/ipmi-discover.rb","position":5,"original_position":5,"commit_id":"9fd1339805bfec3c02628180e8866c64b9fbe9d0","original_commit_id":"9fd1339805bfec3c02628180e8866c64b9fbe9d0","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Style/AndOr: Use `||` instead of `or`.","created_at":"2015-10-01T08:04:07Z","updated_at":"2015-10-01T08:04:07Z","html_url":"https://github.com/crowbar/crowbar-core/pull/53#discussion_r40887760","pull_request_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/53","_links":{"self":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/comments/40887760"},"html":{"href":"https://github.com/crowbar/crowbar-core/pull/53#discussion_r40887760"},"pull_request":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/53"}}},"pull_request":{"url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/53","id":46489945,"html_url":"https://github.com/crowbar/crowbar-core/pull/53","diff_url":"https://github.com/crowbar/crowbar-core/pull/53.diff","patch_url":"https://github.com/crowbar/crowbar-core/pull/53.patch","issue_url":"https://api.github.com/repos/crowbar/crowbar-core/issues/53","number":53,"state":"open","locked":false,"title":"replace checks for platform with checks for platform_family","user":{"login":"jsuchome","id":910000,"avatar_url":"https://avatars.githubusercontent.com/u/910000?v=3","gravatar_id":"","url":"https://api.github.com/users/jsuchome","html_url":"https://github.com/jsuchome","followers_url":"https://api.github.com/users/jsuchome/followers","following_url":"https://api.github.com/users/jsuchome/following{/other_user}","gists_url":"https://api.github.com/users/jsuchome/gists{/gist_id}","starred_url":"https://api.github.com/users/jsuchome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsuchome/subscriptions","organizations_url":"https://api.github.com/users/jsuchome/orgs","repos_url":"https://api.github.com/users/jsuchome/repos","events_url":"https://api.github.com/users/jsuchome/events{/privacy}","received_events_url":"https://api.github.com/users/jsuchome/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-10-01T06:48:26Z","updated_at":"2015-10-01T08:04:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7b2b3b7894a70d71034059c2e4326e241a6d6e37","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/53/commits","review_comments_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/53/comments","review_comment_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crowbar/crowbar-core/issues/53/comments","statuses_url":"https://api.github.com/repos/crowbar/crowbar-core/statuses/9fd1339805bfec3c02628180e8866c64b9fbe9d0","head":{"label":"jsuchome:platform_family","ref":"platform_family","sha":"9fd1339805bfec3c02628180e8866c64b9fbe9d0","user":{"login":"jsuchome","id":910000,"avatar_url":"https://avatars.githubusercontent.com/u/910000?v=3","gravatar_id":"","url":"https://api.github.com/users/jsuchome","html_url":"https://github.com/jsuchome","followers_url":"https://api.github.com/users/jsuchome/followers","following_url":"https://api.github.com/users/jsuchome/following{/other_user}","gists_url":"https://api.github.com/users/jsuchome/gists{/gist_id}","starred_url":"https://api.github.com/users/jsuchome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsuchome/subscriptions","organizations_url":"https://api.github.com/users/jsuchome/orgs","repos_url":"https://api.github.com/users/jsuchome/repos","events_url":"https://api.github.com/users/jsuchome/events{/privacy}","received_events_url":"https://api.github.com/users/jsuchome/received_events","type":"User","site_admin":false},"repo":{"id":42096406,"name":"crowbar-core","full_name":"jsuchome/crowbar-core","owner":{"login":"jsuchome","id":910000,"avatar_url":"https://avatars.githubusercontent.com/u/910000?v=3","gravatar_id":"","url":"https://api.github.com/users/jsuchome","html_url":"https://github.com/jsuchome","followers_url":"https://api.github.com/users/jsuchome/followers","following_url":"https://api.github.com/users/jsuchome/following{/other_user}","gists_url":"https://api.github.com/users/jsuchome/gists{/gist_id}","starred_url":"https://api.github.com/users/jsuchome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsuchome/subscriptions","organizations_url":"https://api.github.com/users/jsuchome/orgs","repos_url":"https://api.github.com/users/jsuchome/repos","events_url":"https://api.github.com/users/jsuchome/events{/privacy}","received_events_url":"https://api.github.com/users/jsuchome/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jsuchome/crowbar-core","description":"Core deployment for Crowbar","fork":true,"url":"https://api.github.com/repos/jsuchome/crowbar-core","forks_url":"https://api.github.com/repos/jsuchome/crowbar-core/forks","keys_url":"https://api.github.com/repos/jsuchome/crowbar-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jsuchome/crowbar-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jsuchome/crowbar-core/teams","hooks_url":"https://api.github.com/repos/jsuchome/crowbar-core/hooks","issue_events_url":"https://api.github.com/repos/jsuchome/crowbar-core/issues/events{/number}","events_url":"https://api.github.com/repos/jsuchome/crowbar-core/events","assignees_url":"https://api.github.com/repos/jsuchome/crowbar-core/assignees{/user}","branches_url":"https://api.github.com/repos/jsuchome/crowbar-core/branches{/branch}","tags_url":"https://api.github.com/repos/jsuchome/crowbar-core/tags","blobs_url":"https://api.github.com/repos/jsuchome/crowbar-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jsuchome/crowbar-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jsuchome/crowbar-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/jsuchome/crowbar-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jsuchome/crowbar-core/statuses/{sha}","languages_url":"https://api.github.com/repos/jsuchome/crowbar-core/languages","stargazers_url":"https://api.github.com/repos/jsuchome/crowbar-core/stargazers","contributors_url":"https://api.github.com/repos/jsuchome/crowbar-core/contributors","subscribers_url":"https://api.github.com/repos/jsuchome/crowbar-core/subscribers","subscription_url":"https://api.github.com/repos/jsuchome/crowbar-core/subscription","commits_url":"https://api.github.com/repos/jsuchome/crowbar-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/jsuchome/crowbar-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/jsuchome/crowbar-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/jsuchome/crowbar-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/jsuchome/crowbar-core/contents/{+path}","compare_url":"https://api.github.com/repos/jsuchome/crowbar-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jsuchome/crowbar-core/merges","archive_url":"https://api.github.com/repos/jsuchome/crowbar-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jsuchome/crowbar-core/downloads","issues_url":"https://api.github.com/repos/jsuchome/crowbar-core/issues{/number}","pulls_url":"https://api.github.com/repos/jsuchome/crowbar-core/pulls{/number}","milestones_url":"https://api.github.com/repos/jsuchome/crowbar-core/milestones{/number}","notifications_url":"https://api.github.com/repos/jsuchome/crowbar-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jsuchome/crowbar-core/labels{/name}","releases_url":"https://api.github.com/repos/jsuchome/crowbar-core/releases{/id}","created_at":"2015-09-08T07:18:38Z","updated_at":"2015-09-08T07:18:40Z","pushed_at":"2015-10-01T08:04:00Z","git_url":"git://github.com/jsuchome/crowbar-core.git","ssh_url":"git@github.com:jsuchome/crowbar-core.git","clone_url":"https://github.com/jsuchome/crowbar-core.git","svn_url":"https://github.com/jsuchome/crowbar-core","homepage":null,"size":102653,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"crowbar:master","ref":"master","sha":"6facefb52f7bb28a1228e36091d53af3688c1c92","user":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars.githubusercontent.com/u/2910205?v=3","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"repo":{"id":39003227,"name":"crowbar-core","full_name":"crowbar/crowbar-core","owner":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars.githubusercontent.com/u/2910205?v=3","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crowbar/crowbar-core","description":"Core deployment for Crowbar","fork":false,"url":"https://api.github.com/repos/crowbar/crowbar-core","forks_url":"https://api.github.com/repos/crowbar/crowbar-core/forks","keys_url":"https://api.github.com/repos/crowbar/crowbar-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crowbar/crowbar-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crowbar/crowbar-core/teams","hooks_url":"https://api.github.com/repos/crowbar/crowbar-core/hooks","issue_events_url":"https://api.github.com/repos/crowbar/crowbar-core/issues/events{/number}","events_url":"https://api.github.com/repos/crowbar/crowbar-core/events","assignees_url":"https://api.github.com/repos/crowbar/crowbar-core/assignees{/user}","branches_url":"https://api.github.com/repos/crowbar/crowbar-core/branches{/branch}","tags_url":"https://api.github.com/repos/crowbar/crowbar-core/tags","blobs_url":"https://api.github.com/repos/crowbar/crowbar-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crowbar/crowbar-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crowbar/crowbar-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/crowbar/crowbar-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crowbar/crowbar-core/statuses/{sha}","languages_url":"https://api.github.com/repos/crowbar/crowbar-core/languages","stargazers_url":"https://api.github.com/repos/crowbar/crowbar-core/stargazers","contributors_url":"https://api.github.com/repos/crowbar/crowbar-core/contributors","subscribers_url":"https://api.github.com/repos/crowbar/crowbar-core/subscribers","subscription_url":"https://api.github.com/repos/crowbar/crowbar-core/subscription","commits_url":"https://api.github.com/repos/crowbar/crowbar-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/crowbar/crowbar-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/crowbar/crowbar-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/crowbar/crowbar-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/crowbar/crowbar-core/contents/{+path}","compare_url":"https://api.github.com/repos/crowbar/crowbar-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crowbar/crowbar-core/merges","archive_url":"https://api.github.com/repos/crowbar/crowbar-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crowbar/crowbar-core/downloads","issues_url":"https://api.github.com/repos/crowbar/crowbar-core/issues{/number}","pulls_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls{/number}","milestones_url":"https://api.github.com/repos/crowbar/crowbar-core/milestones{/number}","notifications_url":"https://api.github.com/repos/crowbar/crowbar-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crowbar/crowbar-core/labels{/name}","releases_url":"https://api.github.com/repos/crowbar/crowbar-core/releases{/id}","created_at":"2015-07-13T09:31:28Z","updated_at":"2015-09-17T17:48:52Z","pushed_at":"2015-10-01T08:04:01Z","git_url":"git://github.com/crowbar/crowbar-core.git","ssh_url":"git@github.com:crowbar/crowbar-core.git","clone_url":"https://github.com/crowbar/crowbar-core.git","svn_url":"https://github.com/crowbar/crowbar-core","homepage":null,"size":118521,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":13,"forks":18,"open_issues":13,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/53"},"html":{"href":"https://github.com/crowbar/crowbar-core/pull/53"},"issue":{"href":"https://api.github.com/repos/crowbar/crowbar-core/issues/53"},"comments":{"href":"https://api.github.com/repos/crowbar/crowbar-core/issues/53/comments"},"review_comments":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/53/comments"},"review_comment":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/53/commits"},"statuses":{"href":"https://api.github.com/repos/crowbar/crowbar-core/statuses/9fd1339805bfec3c02628180e8866c64b9fbe9d0"}}}}