{"action":"created","issue":{"url":"https://api.github.com/repos/garemoko/moodle-mod_tincanlaunch/issues/38","labels_url":"https://api.github.com/repos/garemoko/moodle-mod_tincanlaunch/issues/38/labels{/name}","comments_url":"https://api.github.com/repos/garemoko/moodle-mod_tincanlaunch/issues/38/comments","events_url":"https://api.github.com/repos/garemoko/moodle-mod_tincanlaunch/issues/38/events","html_url":"https://github.com/garemoko/moodle-mod_tincanlaunch/pull/38","id":59479478,"number":38,"title":"Migrate add_to_log() to Event classes","user":{"login":"nadavkav","id":231168,"avatar_url":"https://avatars.githubusercontent.com/u/231168?v=3","gravatar_id":"","url":"https://api.github.com/users/nadavkav","html_url":"https://github.com/nadavkav","followers_url":"https://api.github.com/users/nadavkav/followers","following_url":"https://api.github.com/users/nadavkav/following{/other_user}","gists_url":"https://api.github.com/users/nadavkav/gists{/gist_id}","starred_url":"https://api.github.com/users/nadavkav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nadavkav/subscriptions","organizations_url":"https://api.github.com/users/nadavkav/orgs","repos_url":"https://api.github.com/users/nadavkav/repos","events_url":"https://api.github.com/users/nadavkav/events{/privacy}","received_events_url":"https://api.github.com/users/nadavkav/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":25,"created_at":"2015-03-02T13:14:04Z","updated_at":"2015-03-05T08:01:40Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/garemoko/moodle-mod_tincanlaunch/pulls/38","html_url":"https://github.com/garemoko/moodle-mod_tincanlaunch/pull/38","diff_url":"https://github.com/garemoko/moodle-mod_tincanlaunch/pull/38.diff","patch_url":"https://github.com/garemoko/moodle-mod_tincanlaunch/pull/38.patch"},"body":"Hi Andrew,\r\n\r\nWhile trying to revive your project, I needed to update the module to support Events\r\nSo here is a patch to update module's events. Hope I did not miss anything :-)\r\n\r\nPlease review and consider updating your repo.\r\n\r\nNadav"},"comment":{"url":"https://api.github.com/repos/garemoko/moodle-mod_tincanlaunch/issues/comments/77321938","html_url":"https://github.com/garemoko/moodle-mod_tincanlaunch/pull/38#issuecomment-77321938","issue_url":"https://api.github.com/repos/garemoko/moodle-mod_tincanlaunch/issues/38","id":77321938,"user":{"login":"garemoko","id":1363163,"avatar_url":"https://avatars.githubusercontent.com/u/1363163?v=3","gravatar_id":"","url":"https://api.github.com/users/garemoko","html_url":"https://github.com/garemoko","followers_url":"https://api.github.com/users/garemoko/followers","following_url":"https://api.github.com/users/garemoko/following{/other_user}","gists_url":"https://api.github.com/users/garemoko/gists{/gist_id}","starred_url":"https://api.github.com/users/garemoko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garemoko/subscriptions","organizations_url":"https://api.github.com/users/garemoko/orgs","repos_url":"https://api.github.com/users/garemoko/repos","events_url":"https://api.github.com/users/garemoko/events{/privacy}","received_events_url":"https://api.github.com/users/garemoko/received_events","type":"User","site_admin":false},"created_at":"2015-03-05T08:01:40Z","updated_at":"2015-03-05T08:01:40Z","body":"@nadavkav thanks - that code looks like it should resolve the issue @davidpesce reported. @davidpesce - are you able to retest to make sure completion is only triggering when it should? \r\n\r\nOn the JS timer, agreed it's not an ideal solution; it also leads to a lot of calls to the LRS. The cron solution might also be less calls as you could get a bunch of statements about ALL users in one hit and then cycle through that. \r\n\r\nStill, as I mentioned, an even better solution is to have an endpoint that can receive incoming statements from an LRS and mark completion of activities. Ideally this would be a separate plugin that adds fields to the global completion settings so that ALL activities have the facility to be marked complete via incoming Tin Can statements. "}}