{"action":"created","comment":{"url":"https://api.github.com/repos/grpc/grpc/pulls/comments/43360119","id":43360119,"diff_hunk":"@@ -0,0 +1,154 @@\n+// Copyright 2015, Google Inc.\n+// All rights reserved.\n+//\n+// Redistribution and use in source and binary forms, with or without\n+// modification, are permitted provided that the following conditions are\n+// met:\n+//\n+//     * Redistributions of source code must retain the above copyright\n+// notice, this list of conditions and the following disclaimer.\n+//     * Redistributions in binary form must reproduce the above\n+// copyright notice, this list of conditions and the following disclaimer\n+// in the documentation and/or other materials provided with the\n+// distribution.\n+//     * Neither the name of Google Inc. nor the names of its\n+// contributors may be used to endorse or promote products derived from\n+// this software without specific prior written permission.\n+//\n+// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS\n+// \"AS IS\" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT\n+// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR\n+// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT\n+// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,\n+// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT\n+// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,\n+// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY\n+// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT\n+// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE\n+// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.\n+\n+// An integration test service that covers all the method signature permutations\n+// of unary/streaming requests/responses.\n+syntax = \"proto3\";","path":"test/proto/perf_control.proto","position":null,"original_position":32,"commit_id":"119c103ab00f309a66de6f1cb78c648eb3c4e2cc","original_commit_id":"4870de2367adde1c4089f8af14f9fd5d74520e63","user":{"login":"vjpai","id":8864912,"avatar_url":"https://avatars.githubusercontent.com/u/8864912?v=3","gravatar_id":"","url":"https://api.github.com/users/vjpai","html_url":"https://github.com/vjpai","followers_url":"https://api.github.com/users/vjpai/followers","following_url":"https://api.github.com/users/vjpai/following{/other_user}","gists_url":"https://api.github.com/users/vjpai/gists{/gist_id}","starred_url":"https://api.github.com/users/vjpai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vjpai/subscriptions","organizations_url":"https://api.github.com/users/vjpai/orgs","repos_url":"https://api.github.com/users/vjpai/repos","events_url":"https://api.github.com/users/vjpai/events{/privacy}","received_events_url":"https://api.github.com/users/vjpai/received_events","type":"User","site_admin":false},"body":"Any changes to this benchmark support PHP can be pushed to lower priority, to avoid having too many special cases. We can benchmark N-1 language bindings, which should be ok for now. We can benchmark PHP outside the scope of this benchmark suite.\r\n\r\n","created_at":"2015-10-29T08:32:26Z","updated_at":"2015-10-29T08:32:26Z","html_url":"https://github.com/grpc/grpc/pull/3905#discussion_r43360119","pull_request_url":"https://api.github.com/repos/grpc/grpc/pulls/3905","_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc/pulls/comments/43360119"},"html":{"href":"https://github.com/grpc/grpc/pull/3905#discussion_r43360119"},"pull_request":{"href":"https://api.github.com/repos/grpc/grpc/pulls/3905"}}},"pull_request":{"url":"https://api.github.com/repos/grpc/grpc/pulls/3905","id":48343364,"html_url":"https://github.com/grpc/grpc/pull/3905","diff_url":"https://github.com/grpc/grpc/pull/3905.diff","patch_url":"https://github.com/grpc/grpc/pull/3905.patch","issue_url":"https://api.github.com/repos/grpc/grpc/issues/3905","number":3905,"state":"open","locked":false,"title":"Separate portions of qpstest.proto for readability and maintainability","user":{"login":"vjpai","id":8864912,"avatar_url":"https://avatars.githubusercontent.com/u/8864912?v=3","gravatar_id":"","url":"https://api.github.com/users/vjpai","html_url":"https://github.com/vjpai","followers_url":"https://api.github.com/users/vjpai/followers","following_url":"https://api.github.com/users/vjpai/following{/other_user}","gists_url":"https://api.github.com/users/vjpai/gists{/gist_id}","starred_url":"https://api.github.com/users/vjpai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vjpai/subscriptions","organizations_url":"https://api.github.com/users/vjpai/orgs","repos_url":"https://api.github.com/users/vjpai/repos","events_url":"https://api.github.com/users/vjpai/events{/privacy}","received_events_url":"https://api.github.com/users/vjpai/received_events","type":"User","site_admin":false},"body":"Also start using message proto from end2end test so that we can then more easily integrate security, etc., which is already accounted for in those protos.\r\n\r\nRenamed RunTest to RunClient for parallelism and clarity\r\n\r\nSide issue: straightened out sign conversion issues on low-level network benchmark.\r\n\r\nDynamic generation of server port will come in a different PR: the proto already supports a port field in the response from RunServer.\r\n","created_at":"2015-10-21T15:01:30Z","updated_at":"2015-10-29T08:32:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fd70fe93df4cdb72f098a002d76532a0c7b97dea","assignee":{"login":"jtattermusch","id":9939684,"avatar_url":"https://avatars.githubusercontent.com/u/9939684?v=3","gravatar_id":"","url":"https://api.github.com/users/jtattermusch","html_url":"https://github.com/jtattermusch","followers_url":"https://api.github.com/users/jtattermusch/followers","following_url":"https://api.github.com/users/jtattermusch/following{/other_user}","gists_url":"https://api.github.com/users/jtattermusch/gists{/gist_id}","starred_url":"https://api.github.com/users/jtattermusch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtattermusch/subscriptions","organizations_url":"https://api.github.com/users/jtattermusch/orgs","repos_url":"https://api.github.com/users/jtattermusch/repos","events_url":"https://api.github.com/users/jtattermusch/events{/privacy}","received_events_url":"https://api.github.com/users/jtattermusch/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/grpc/grpc/pulls/3905/commits","review_comments_url":"https://api.github.com/repos/grpc/grpc/pulls/3905/comments","review_comment_url":"https://api.github.com/repos/grpc/grpc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/grpc/grpc/issues/3905/comments","statuses_url":"https://api.github.com/repos/grpc/grpc/statuses/119c103ab00f309a66de6f1cb78c648eb3c4e2cc","head":{"label":"vjpai:protosplit","ref":"protosplit","sha":"119c103ab00f309a66de6f1cb78c648eb3c4e2cc","user":{"login":"vjpai","id":8864912,"avatar_url":"https://avatars.githubusercontent.com/u/8864912?v=3","gravatar_id":"","url":"https://api.github.com/users/vjpai","html_url":"https://github.com/vjpai","followers_url":"https://api.github.com/users/vjpai/followers","following_url":"https://api.github.com/users/vjpai/following{/other_user}","gists_url":"https://api.github.com/users/vjpai/gists{/gist_id}","starred_url":"https://api.github.com/users/vjpai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vjpai/subscriptions","organizations_url":"https://api.github.com/users/vjpai/orgs","repos_url":"https://api.github.com/users/vjpai/repos","events_url":"https://api.github.com/users/vjpai/events{/privacy}","received_events_url":"https://api.github.com/users/vjpai/received_events","type":"User","site_admin":false},"repo":{"id":43449564,"name":"grpc","full_name":"vjpai/grpc","owner":{"login":"vjpai","id":8864912,"avatar_url":"https://avatars.githubusercontent.com/u/8864912?v=3","gravatar_id":"","url":"https://api.github.com/users/vjpai","html_url":"https://github.com/vjpai","followers_url":"https://api.github.com/users/vjpai/followers","following_url":"https://api.github.com/users/vjpai/following{/other_user}","gists_url":"https://api.github.com/users/vjpai/gists{/gist_id}","starred_url":"https://api.github.com/users/vjpai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vjpai/subscriptions","organizations_url":"https://api.github.com/users/vjpai/orgs","repos_url":"https://api.github.com/users/vjpai/repos","events_url":"https://api.github.com/users/vjpai/events{/privacy}","received_events_url":"https://api.github.com/users/vjpai/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vjpai/grpc","description":"The C based gRPC (C++, Node.js, Python, Ruby, Objective-C, PHP, C#)","fork":true,"url":"https://api.github.com/repos/vjpai/grpc","forks_url":"https://api.github.com/repos/vjpai/grpc/forks","keys_url":"https://api.github.com/repos/vjpai/grpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vjpai/grpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vjpai/grpc/teams","hooks_url":"https://api.github.com/repos/vjpai/grpc/hooks","issue_events_url":"https://api.github.com/repos/vjpai/grpc/issues/events{/number}","events_url":"https://api.github.com/repos/vjpai/grpc/events","assignees_url":"https://api.github.com/repos/vjpai/grpc/assignees{/user}","branches_url":"https://api.github.com/repos/vjpai/grpc/branches{/branch}","tags_url":"https://api.github.com/repos/vjpai/grpc/tags","blobs_url":"https://api.github.com/repos/vjpai/grpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vjpai/grpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vjpai/grpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/vjpai/grpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vjpai/grpc/statuses/{sha}","languages_url":"https://api.github.com/repos/vjpai/grpc/languages","stargazers_url":"https://api.github.com/repos/vjpai/grpc/stargazers","contributors_url":"https://api.github.com/repos/vjpai/grpc/contributors","subscribers_url":"https://api.github.com/repos/vjpai/grpc/subscribers","subscription_url":"https://api.github.com/repos/vjpai/grpc/subscription","commits_url":"https://api.github.com/repos/vjpai/grpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/vjpai/grpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/vjpai/grpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/vjpai/grpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/vjpai/grpc/contents/{+path}","compare_url":"https://api.github.com/repos/vjpai/grpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vjpai/grpc/merges","archive_url":"https://api.github.com/repos/vjpai/grpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vjpai/grpc/downloads","issues_url":"https://api.github.com/repos/vjpai/grpc/issues{/number}","pulls_url":"https://api.github.com/repos/vjpai/grpc/pulls{/number}","milestones_url":"https://api.github.com/repos/vjpai/grpc/milestones{/number}","notifications_url":"https://api.github.com/repos/vjpai/grpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vjpai/grpc/labels{/name}","releases_url":"https://api.github.com/repos/vjpai/grpc/releases{/id}","created_at":"2015-09-30T17:59:22Z","updated_at":"2015-09-30T17:59:39Z","pushed_at":"2015-10-29T08:21:53Z","git_url":"git://github.com/vjpai/grpc.git","ssh_url":"git@github.com:vjpai/grpc.git","clone_url":"https://github.com/vjpai/grpc.git","svn_url":"https://github.com/vjpai/grpc","homepage":"","size":58130,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"grpc:master","ref":"master","sha":"509088bd8bb375e703fe8e4a6c229bae1bacc349","user":{"login":"grpc","id":7802525,"avatar_url":"https://avatars.githubusercontent.com/u/7802525?v=3","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"repo":{"id":27729880,"name":"grpc","full_name":"grpc/grpc","owner":{"login":"grpc","id":7802525,"avatar_url":"https://avatars.githubusercontent.com/u/7802525?v=3","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/grpc/grpc","description":"The C based gRPC (C++, Node.js, Python, Ruby, Objective-C, PHP, C#)","fork":false,"url":"https://api.github.com/repos/grpc/grpc","forks_url":"https://api.github.com/repos/grpc/grpc/forks","keys_url":"https://api.github.com/repos/grpc/grpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grpc/grpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grpc/grpc/teams","hooks_url":"https://api.github.com/repos/grpc/grpc/hooks","issue_events_url":"https://api.github.com/repos/grpc/grpc/issues/events{/number}","events_url":"https://api.github.com/repos/grpc/grpc/events","assignees_url":"https://api.github.com/repos/grpc/grpc/assignees{/user}","branches_url":"https://api.github.com/repos/grpc/grpc/branches{/branch}","tags_url":"https://api.github.com/repos/grpc/grpc/tags","blobs_url":"https://api.github.com/repos/grpc/grpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grpc/grpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grpc/grpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/grpc/grpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grpc/grpc/statuses/{sha}","languages_url":"https://api.github.com/repos/grpc/grpc/languages","stargazers_url":"https://api.github.com/repos/grpc/grpc/stargazers","contributors_url":"https://api.github.com/repos/grpc/grpc/contributors","subscribers_url":"https://api.github.com/repos/grpc/grpc/subscribers","subscription_url":"https://api.github.com/repos/grpc/grpc/subscription","commits_url":"https://api.github.com/repos/grpc/grpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/grpc/grpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/grpc/grpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/grpc/grpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/grpc/grpc/contents/{+path}","compare_url":"https://api.github.com/repos/grpc/grpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grpc/grpc/merges","archive_url":"https://api.github.com/repos/grpc/grpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grpc/grpc/downloads","issues_url":"https://api.github.com/repos/grpc/grpc/issues{/number}","pulls_url":"https://api.github.com/repos/grpc/grpc/pulls{/number}","milestones_url":"https://api.github.com/repos/grpc/grpc/milestones{/number}","notifications_url":"https://api.github.com/repos/grpc/grpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grpc/grpc/labels{/name}","releases_url":"https://api.github.com/repos/grpc/grpc/releases{/id}","created_at":"2014-12-08T18:58:53Z","updated_at":"2015-10-29T07:43:11Z","pushed_at":"2015-10-29T08:21:54Z","git_url":"git://github.com/grpc/grpc.git","ssh_url":"git@github.com:grpc/grpc.git","clone_url":"https://github.com/grpc/grpc.git","svn_url":"https://github.com/grpc/grpc","homepage":"","size":195641,"stargazers_count":3512,"watchers_count":3512,"language":"C","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":534,"mirror_url":null,"open_issues_count":519,"forks":534,"open_issues":519,"watchers":3512,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc/pulls/3905"},"html":{"href":"https://github.com/grpc/grpc/pull/3905"},"issue":{"href":"https://api.github.com/repos/grpc/grpc/issues/3905"},"comments":{"href":"https://api.github.com/repos/grpc/grpc/issues/3905/comments"},"review_comments":{"href":"https://api.github.com/repos/grpc/grpc/pulls/3905/comments"},"review_comment":{"href":"https://api.github.com/repos/grpc/grpc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/grpc/grpc/pulls/3905/commits"},"statuses":{"href":"https://api.github.com/repos/grpc/grpc/statuses/119c103ab00f309a66de6f1cb78c648eb3c4e2cc"}}}}