{"action":"created","comment":{"url":"https://api.github.com/repos/hypothesis/annotator/pulls/comments/23124926","id":23124926,"diff_hunk":"@@ -6,9 +6,11 @@ class Annotator.Plugin.DomTextMapper extends Annotator.Plugin\n       console.log \"Not registering DOM-Text-Mapper.\"\n       return\n \n-    @annotator.documentAccessStrategies.unshift\n+    @anchoring = @annotator.anchoring\n+\n+    @anchoring.documentAccessStrategies.unshift\n       # Document access strategy for simple HTML documents,\n       # with enhanced text extraction and mapping features.\n       name: \"DOM-Text-Mapper\"\n       mapper: window.DomTextMapper\n-      init: => @annotator.domMapper.setRootNode @annotator.wrapper[0]\n+      init: => @anchoring.document.setRootNode @anchoring.annotator.wrapper[0]","path":"src/plugin/domtextmapper.coffee","position":13,"original_position":13,"commit_id":"19913b89f6ebdc918fb1a9d204d6f1f7d14ead7f","original_commit_id":"11118fb7d2ab425d2c5db8773279f32d6ac42d92","user":{"login":"aron","id":47144,"avatar_url":"https://avatars.githubusercontent.com/u/47144?v=3","gravatar_id":"","url":"https://api.github.com/users/aron","html_url":"https://github.com/aron","followers_url":"https://api.github.com/users/aron/followers","following_url":"https://api.github.com/users/aron/following{/other_user}","gists_url":"https://api.github.com/users/aron/gists{/gist_id}","starred_url":"https://api.github.com/users/aron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aron/subscriptions","organizations_url":"https://api.github.com/users/aron/orgs","repos_url":"https://api.github.com/users/aron/repos","events_url":"https://api.github.com/users/aron/events{/privacy}","received_events_url":"https://api.github.com/users/aron/received_events","type":"User","site_admin":false},"body":"Right but while they are all still plugins we can just use the local `@annotator` property rather than accessing the same object through another plugin.","created_at":"2015-01-17T12:25:16Z","updated_at":"2015-01-17T12:25:16Z","html_url":"https://github.com/hypothesis/annotator/pull/99#discussion_r23124926","pull_request_url":"https://api.github.com/repos/hypothesis/annotator/pulls/99","_links":{"self":{"href":"https://api.github.com/repos/hypothesis/annotator/pulls/comments/23124926"},"html":{"href":"https://github.com/hypothesis/annotator/pull/99#discussion_r23124926"},"pull_request":{"href":"https://api.github.com/repos/hypothesis/annotator/pulls/99"}}},"pull_request":{"url":"https://api.github.com/repos/hypothesis/annotator/pulls/99","id":27556006,"html_url":"https://github.com/hypothesis/annotator/pull/99","diff_url":"https://github.com/hypothesis/annotator/pull/99.diff","patch_url":"https://github.com/hypothesis/annotator/pull/99.patch","issue_url":"https://api.github.com/repos/hypothesis/annotator/issues/99","number":99,"state":"open","locked":false,"title":"Extract anchoring","user":{"login":"aron","id":47144,"avatar_url":"https://avatars.githubusercontent.com/u/47144?v=3","gravatar_id":"","url":"https://api.github.com/users/aron","html_url":"https://github.com/aron","followers_url":"https://api.github.com/users/aron/followers","following_url":"https://api.github.com/users/aron/following{/other_user}","gists_url":"https://api.github.com/users/aron/gists{/gist_id}","starred_url":"https://api.github.com/users/aron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aron/subscriptions","organizations_url":"https://api.github.com/users/aron/orgs","repos_url":"https://api.github.com/users/aron/repos","events_url":"https://api.github.com/users/aron/events{/privacy}","received_events_url":"https://api.github.com/users/aron/received_events","type":"User","site_admin":false},"body":"TBC\r\n","created_at":"2015-01-17T12:09:40Z","updated_at":"2015-01-17T12:25:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"874a9fc6971a39f9d2d9a38dadb25c72e46304cb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hypothesis/annotator/pulls/99/commits","review_comments_url":"https://api.github.com/repos/hypothesis/annotator/pulls/99/comments","review_comment_url":"https://api.github.com/repos/hypothesis/annotator/pulls/comments/{number}","comments_url":"https://api.github.com/repos/hypothesis/annotator/issues/99/comments","statuses_url":"https://api.github.com/repos/hypothesis/annotator/statuses/19913b89f6ebdc918fb1a9d204d6f1f7d14ead7f","head":{"label":"hypothesis:extract-anchoring-1","ref":"extract-anchoring-1","sha":"19913b89f6ebdc918fb1a9d204d6f1f7d14ead7f","user":{"login":"hypothesis","id":1243215,"avatar_url":"https://avatars.githubusercontent.com/u/1243215?v=3","gravatar_id":"","url":"https://api.github.com/users/hypothesis","html_url":"https://github.com/hypothesis","followers_url":"https://api.github.com/users/hypothesis/followers","following_url":"https://api.github.com/users/hypothesis/following{/other_user}","gists_url":"https://api.github.com/users/hypothesis/gists{/gist_id}","starred_url":"https://api.github.com/users/hypothesis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hypothesis/subscriptions","organizations_url":"https://api.github.com/users/hypothesis/orgs","repos_url":"https://api.github.com/users/hypothesis/repos","events_url":"https://api.github.com/users/hypothesis/events{/privacy}","received_events_url":"https://api.github.com/users/hypothesis/received_events","type":"Organization","site_admin":false},"repo":{"id":3464551,"name":"annotator","full_name":"hypothesis/annotator","owner":{"login":"hypothesis","id":1243215,"avatar_url":"https://avatars.githubusercontent.com/u/1243215?v=3","gravatar_id":"","url":"https://api.github.com/users/hypothesis","html_url":"https://github.com/hypothesis","followers_url":"https://api.github.com/users/hypothesis/followers","following_url":"https://api.github.com/users/hypothesis/following{/other_user}","gists_url":"https://api.github.com/users/hypothesis/gists{/gist_id}","starred_url":"https://api.github.com/users/hypothesis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hypothesis/subscriptions","organizations_url":"https://api.github.com/users/hypothesis/orgs","repos_url":"https://api.github.com/users/hypothesis/repos","events_url":"https://api.github.com/users/hypothesis/events{/privacy}","received_events_url":"https://api.github.com/users/hypothesis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hypothesis/annotator","description":"Inline annotation for the web. Select text, images, or (nearly) anything else, and add your notes.","fork":true,"url":"https://api.github.com/repos/hypothesis/annotator","forks_url":"https://api.github.com/repos/hypothesis/annotator/forks","keys_url":"https://api.github.com/repos/hypothesis/annotator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hypothesis/annotator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hypothesis/annotator/teams","hooks_url":"https://api.github.com/repos/hypothesis/annotator/hooks","issue_events_url":"https://api.github.com/repos/hypothesis/annotator/issues/events{/number}","events_url":"https://api.github.com/repos/hypothesis/annotator/events","assignees_url":"https://api.github.com/repos/hypothesis/annotator/assignees{/user}","branches_url":"https://api.github.com/repos/hypothesis/annotator/branches{/branch}","tags_url":"https://api.github.com/repos/hypothesis/annotator/tags","blobs_url":"https://api.github.com/repos/hypothesis/annotator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hypothesis/annotator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hypothesis/annotator/git/refs{/sha}","trees_url":"https://api.github.com/repos/hypothesis/annotator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hypothesis/annotator/statuses/{sha}","languages_url":"https://api.github.com/repos/hypothesis/annotator/languages","stargazers_url":"https://api.github.com/repos/hypothesis/annotator/stargazers","contributors_url":"https://api.github.com/repos/hypothesis/annotator/contributors","subscribers_url":"https://api.github.com/repos/hypothesis/annotator/subscribers","subscription_url":"https://api.github.com/repos/hypothesis/annotator/subscription","commits_url":"https://api.github.com/repos/hypothesis/annotator/commits{/sha}","git_commits_url":"https://api.github.com/repos/hypothesis/annotator/git/commits{/sha}","comments_url":"https://api.github.com/repos/hypothesis/annotator/comments{/number}","issue_comment_url":"https://api.github.com/repos/hypothesis/annotator/issues/comments/{number}","contents_url":"https://api.github.com/repos/hypothesis/annotator/contents/{+path}","compare_url":"https://api.github.com/repos/hypothesis/annotator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hypothesis/annotator/merges","archive_url":"https://api.github.com/repos/hypothesis/annotator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hypothesis/annotator/downloads","issues_url":"https://api.github.com/repos/hypothesis/annotator/issues{/number}","pulls_url":"https://api.github.com/repos/hypothesis/annotator/pulls{/number}","milestones_url":"https://api.github.com/repos/hypothesis/annotator/milestones{/number}","notifications_url":"https://api.github.com/repos/hypothesis/annotator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hypothesis/annotator/labels{/name}","releases_url":"https://api.github.com/repos/hypothesis/annotator/releases{/id}","created_at":"2012-02-16T22:10:47Z","updated_at":"2015-01-16T14:50:58Z","pushed_at":"2015-01-17T12:13:48Z","git_url":"git://github.com/hypothesis/annotator.git","ssh_url":"git@github.com:hypothesis/annotator.git","clone_url":"https://github.com/hypothesis/annotator.git","svn_url":"https://github.com/hypothesis/annotator","homepage":"http://okfn.org/projects/annotator/","size":7061,"stargazers_count":35,"watchers_count":35,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":10,"mirror_url":null,"open_issues_count":27,"forks":10,"open_issues":27,"watchers":35,"default_branch":"typed-packaging"}},"base":{"label":"hypothesis:typed-packaging","ref":"typed-packaging","sha":"f111824bb433556058602c3a767b9736edcb7507","user":{"login":"hypothesis","id":1243215,"avatar_url":"https://avatars.githubusercontent.com/u/1243215?v=3","gravatar_id":"","url":"https://api.github.com/users/hypothesis","html_url":"https://github.com/hypothesis","followers_url":"https://api.github.com/users/hypothesis/followers","following_url":"https://api.github.com/users/hypothesis/following{/other_user}","gists_url":"https://api.github.com/users/hypothesis/gists{/gist_id}","starred_url":"https://api.github.com/users/hypothesis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hypothesis/subscriptions","organizations_url":"https://api.github.com/users/hypothesis/orgs","repos_url":"https://api.github.com/users/hypothesis/repos","events_url":"https://api.github.com/users/hypothesis/events{/privacy}","received_events_url":"https://api.github.com/users/hypothesis/received_events","type":"Organization","site_admin":false},"repo":{"id":3464551,"name":"annotator","full_name":"hypothesis/annotator","owner":{"login":"hypothesis","id":1243215,"avatar_url":"https://avatars.githubusercontent.com/u/1243215?v=3","gravatar_id":"","url":"https://api.github.com/users/hypothesis","html_url":"https://github.com/hypothesis","followers_url":"https://api.github.com/users/hypothesis/followers","following_url":"https://api.github.com/users/hypothesis/following{/other_user}","gists_url":"https://api.github.com/users/hypothesis/gists{/gist_id}","starred_url":"https://api.github.com/users/hypothesis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hypothesis/subscriptions","organizations_url":"https://api.github.com/users/hypothesis/orgs","repos_url":"https://api.github.com/users/hypothesis/repos","events_url":"https://api.github.com/users/hypothesis/events{/privacy}","received_events_url":"https://api.github.com/users/hypothesis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hypothesis/annotator","description":"Inline annotation for the web. Select text, images, or (nearly) anything else, and add your notes.","fork":true,"url":"https://api.github.com/repos/hypothesis/annotator","forks_url":"https://api.github.com/repos/hypothesis/annotator/forks","keys_url":"https://api.github.com/repos/hypothesis/annotator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hypothesis/annotator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hypothesis/annotator/teams","hooks_url":"https://api.github.com/repos/hypothesis/annotator/hooks","issue_events_url":"https://api.github.com/repos/hypothesis/annotator/issues/events{/number}","events_url":"https://api.github.com/repos/hypothesis/annotator/events","assignees_url":"https://api.github.com/repos/hypothesis/annotator/assignees{/user}","branches_url":"https://api.github.com/repos/hypothesis/annotator/branches{/branch}","tags_url":"https://api.github.com/repos/hypothesis/annotator/tags","blobs_url":"https://api.github.com/repos/hypothesis/annotator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hypothesis/annotator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hypothesis/annotator/git/refs{/sha}","trees_url":"https://api.github.com/repos/hypothesis/annotator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hypothesis/annotator/statuses/{sha}","languages_url":"https://api.github.com/repos/hypothesis/annotator/languages","stargazers_url":"https://api.github.com/repos/hypothesis/annotator/stargazers","contributors_url":"https://api.github.com/repos/hypothesis/annotator/contributors","subscribers_url":"https://api.github.com/repos/hypothesis/annotator/subscribers","subscription_url":"https://api.github.com/repos/hypothesis/annotator/subscription","commits_url":"https://api.github.com/repos/hypothesis/annotator/commits{/sha}","git_commits_url":"https://api.github.com/repos/hypothesis/annotator/git/commits{/sha}","comments_url":"https://api.github.com/repos/hypothesis/annotator/comments{/number}","issue_comment_url":"https://api.github.com/repos/hypothesis/annotator/issues/comments/{number}","contents_url":"https://api.github.com/repos/hypothesis/annotator/contents/{+path}","compare_url":"https://api.github.com/repos/hypothesis/annotator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hypothesis/annotator/merges","archive_url":"https://api.github.com/repos/hypothesis/annotator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hypothesis/annotator/downloads","issues_url":"https://api.github.com/repos/hypothesis/annotator/issues{/number}","pulls_url":"https://api.github.com/repos/hypothesis/annotator/pulls{/number}","milestones_url":"https://api.github.com/repos/hypothesis/annotator/milestones{/number}","notifications_url":"https://api.github.com/repos/hypothesis/annotator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hypothesis/annotator/labels{/name}","releases_url":"https://api.github.com/repos/hypothesis/annotator/releases{/id}","created_at":"2012-02-16T22:10:47Z","updated_at":"2015-01-16T14:50:58Z","pushed_at":"2015-01-17T12:13:48Z","git_url":"git://github.com/hypothesis/annotator.git","ssh_url":"git@github.com:hypothesis/annotator.git","clone_url":"https://github.com/hypothesis/annotator.git","svn_url":"https://github.com/hypothesis/annotator","homepage":"http://okfn.org/projects/annotator/","size":7061,"stargazers_count":35,"watchers_count":35,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":10,"mirror_url":null,"open_issues_count":27,"forks":10,"open_issues":27,"watchers":35,"default_branch":"typed-packaging"}},"_links":{"self":{"href":"https://api.github.com/repos/hypothesis/annotator/pulls/99"},"html":{"href":"https://github.com/hypothesis/annotator/pull/99"},"issue":{"href":"https://api.github.com/repos/hypothesis/annotator/issues/99"},"comments":{"href":"https://api.github.com/repos/hypothesis/annotator/issues/99/comments"},"review_comments":{"href":"https://api.github.com/repos/hypothesis/annotator/pulls/99/comments"},"review_comment":{"href":"https://api.github.com/repos/hypothesis/annotator/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/hypothesis/annotator/pulls/99/commits"},"statuses":{"href":"https://api.github.com/repos/hypothesis/annotator/statuses/19913b89f6ebdc918fb1a9d204d6f1f7d14ead7f"}}}}