{"action":"closed","number":251,"pull_request":{"url":"https://api.github.com/repos/joblib/joblib/pulls/251","id":47013781,"html_url":"https://github.com/joblib/joblib/pull/251","diff_url":"https://github.com/joblib/joblib/pull/251.diff","patch_url":"https://github.com/joblib/joblib/pull/251.patch","issue_url":"https://api.github.com/repos/joblib/joblib/issues/251","number":251,"state":"closed","locked":false,"title":"Fix joblib.test.test_hashing.test_dtype random failure","user":{"login":"lesteve","id":1680079,"avatar_url":"https://avatars.githubusercontent.com/u/1680079?v=3","gravatar_id":"","url":"https://api.github.com/users/lesteve","html_url":"https://github.com/lesteve","followers_url":"https://api.github.com/users/lesteve/followers","following_url":"https://api.github.com/users/lesteve/following{/other_user}","gists_url":"https://api.github.com/users/lesteve/gists{/gist_id}","starred_url":"https://api.github.com/users/lesteve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lesteve/subscriptions","organizations_url":"https://api.github.com/users/lesteve/orgs","repos_url":"https://api.github.com/users/lesteve/repos","events_url":"https://api.github.com/users/lesteve/events{/privacy}","received_events_url":"https://api.github.com/users/lesteve/received_events","type":"User","site_admin":false},"body":"with python 3. Fix #250.\r\n\r\nRather than trying to pickle numpy.dtype objects, which\r\ngive rise to multiple problems with hashing, we used its .desr\r\nattribute which is a full description of the dtype.\r\n\r\nThis allow not to rely on the persistent_id workaround. The reason it\r\nwasn't working in the first place is that because joblib.dumps(dt) is\r\nnot stable across python runs, because the order of dt.fields\r\nchanges (dict order randomization in python3).\r\n\r\n@arthurmensch if you want to have a look.","created_at":"2015-10-07T11:08:22Z","updated_at":"2015-10-07T14:38:28Z","closed_at":"2015-10-07T14:38:28Z","merged_at":"2015-10-07T14:38:28Z","merge_commit_sha":"708b1feb6cf1d134ccc2a50e28caa811a6182837","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/joblib/joblib/pulls/251/commits","review_comments_url":"https://api.github.com/repos/joblib/joblib/pulls/251/comments","review_comment_url":"https://api.github.com/repos/joblib/joblib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/joblib/joblib/issues/251/comments","statuses_url":"https://api.github.com/repos/joblib/joblib/statuses/27aeea2e6638c89a0c4823ee9a9bbe6e01d8882f","head":{"label":"lesteve:fix-random-test-dtype-hash-failure","ref":"fix-random-test-dtype-hash-failure","sha":"27aeea2e6638c89a0c4823ee9a9bbe6e01d8882f","user":{"login":"lesteve","id":1680079,"avatar_url":"https://avatars.githubusercontent.com/u/1680079?v=3","gravatar_id":"","url":"https://api.github.com/users/lesteve","html_url":"https://github.com/lesteve","followers_url":"https://api.github.com/users/lesteve/followers","following_url":"https://api.github.com/users/lesteve/following{/other_user}","gists_url":"https://api.github.com/users/lesteve/gists{/gist_id}","starred_url":"https://api.github.com/users/lesteve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lesteve/subscriptions","organizations_url":"https://api.github.com/users/lesteve/orgs","repos_url":"https://api.github.com/users/lesteve/repos","events_url":"https://api.github.com/users/lesteve/events{/privacy}","received_events_url":"https://api.github.com/users/lesteve/received_events","type":"User","site_admin":false},"repo":{"id":31776372,"name":"joblib","full_name":"lesteve/joblib","owner":{"login":"lesteve","id":1680079,"avatar_url":"https://avatars.githubusercontent.com/u/1680079?v=3","gravatar_id":"","url":"https://api.github.com/users/lesteve","html_url":"https://github.com/lesteve","followers_url":"https://api.github.com/users/lesteve/followers","following_url":"https://api.github.com/users/lesteve/following{/other_user}","gists_url":"https://api.github.com/users/lesteve/gists{/gist_id}","starred_url":"https://api.github.com/users/lesteve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lesteve/subscriptions","organizations_url":"https://api.github.com/users/lesteve/orgs","repos_url":"https://api.github.com/users/lesteve/repos","events_url":"https://api.github.com/users/lesteve/events{/privacy}","received_events_url":"https://api.github.com/users/lesteve/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lesteve/joblib","description":"Python function as pipeline jobs.","fork":true,"url":"https://api.github.com/repos/lesteve/joblib","forks_url":"https://api.github.com/repos/lesteve/joblib/forks","keys_url":"https://api.github.com/repos/lesteve/joblib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lesteve/joblib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lesteve/joblib/teams","hooks_url":"https://api.github.com/repos/lesteve/joblib/hooks","issue_events_url":"https://api.github.com/repos/lesteve/joblib/issues/events{/number}","events_url":"https://api.github.com/repos/lesteve/joblib/events","assignees_url":"https://api.github.com/repos/lesteve/joblib/assignees{/user}","branches_url":"https://api.github.com/repos/lesteve/joblib/branches{/branch}","tags_url":"https://api.github.com/repos/lesteve/joblib/tags","blobs_url":"https://api.github.com/repos/lesteve/joblib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lesteve/joblib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lesteve/joblib/git/refs{/sha}","trees_url":"https://api.github.com/repos/lesteve/joblib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lesteve/joblib/statuses/{sha}","languages_url":"https://api.github.com/repos/lesteve/joblib/languages","stargazers_url":"https://api.github.com/repos/lesteve/joblib/stargazers","contributors_url":"https://api.github.com/repos/lesteve/joblib/contributors","subscribers_url":"https://api.github.com/repos/lesteve/joblib/subscribers","subscription_url":"https://api.github.com/repos/lesteve/joblib/subscription","commits_url":"https://api.github.com/repos/lesteve/joblib/commits{/sha}","git_commits_url":"https://api.github.com/repos/lesteve/joblib/git/commits{/sha}","comments_url":"https://api.github.com/repos/lesteve/joblib/comments{/number}","issue_comment_url":"https://api.github.com/repos/lesteve/joblib/issues/comments{/number}","contents_url":"https://api.github.com/repos/lesteve/joblib/contents/{+path}","compare_url":"https://api.github.com/repos/lesteve/joblib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lesteve/joblib/merges","archive_url":"https://api.github.com/repos/lesteve/joblib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lesteve/joblib/downloads","issues_url":"https://api.github.com/repos/lesteve/joblib/issues{/number}","pulls_url":"https://api.github.com/repos/lesteve/joblib/pulls{/number}","milestones_url":"https://api.github.com/repos/lesteve/joblib/milestones{/number}","notifications_url":"https://api.github.com/repos/lesteve/joblib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lesteve/joblib/labels{/name}","releases_url":"https://api.github.com/repos/lesteve/joblib/releases{/id}","created_at":"2015-03-06T15:49:01Z","updated_at":"2015-04-30T13:42:37Z","pushed_at":"2015-10-07T14:20:33Z","git_url":"git://github.com/lesteve/joblib.git","ssh_url":"git@github.com:lesteve/joblib.git","clone_url":"https://github.com/lesteve/joblib.git","svn_url":"https://github.com/lesteve/joblib","homepage":"http://packages.python.org/joblib/","size":2600,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"joblib:master","ref":"master","sha":"2353c0b85f883a2c91eb6f861b511c7494f38d74","user":{"login":"joblib","id":332661,"avatar_url":"https://avatars.githubusercontent.com/u/332661?v=3","gravatar_id":"","url":"https://api.github.com/users/joblib","html_url":"https://github.com/joblib","followers_url":"https://api.github.com/users/joblib/followers","following_url":"https://api.github.com/users/joblib/following{/other_user}","gists_url":"https://api.github.com/users/joblib/gists{/gist_id}","starred_url":"https://api.github.com/users/joblib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joblib/subscriptions","organizations_url":"https://api.github.com/users/joblib/orgs","repos_url":"https://api.github.com/users/joblib/repos","events_url":"https://api.github.com/users/joblib/events{/privacy}","received_events_url":"https://api.github.com/users/joblib/received_events","type":"Organization","site_admin":false},"repo":{"id":654608,"name":"joblib","full_name":"joblib/joblib","owner":{"login":"joblib","id":332661,"avatar_url":"https://avatars.githubusercontent.com/u/332661?v=3","gravatar_id":"","url":"https://api.github.com/users/joblib","html_url":"https://github.com/joblib","followers_url":"https://api.github.com/users/joblib/followers","following_url":"https://api.github.com/users/joblib/following{/other_user}","gists_url":"https://api.github.com/users/joblib/gists{/gist_id}","starred_url":"https://api.github.com/users/joblib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joblib/subscriptions","organizations_url":"https://api.github.com/users/joblib/orgs","repos_url":"https://api.github.com/users/joblib/repos","events_url":"https://api.github.com/users/joblib/events{/privacy}","received_events_url":"https://api.github.com/users/joblib/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/joblib/joblib","description":"Python function as pipeline jobs.","fork":false,"url":"https://api.github.com/repos/joblib/joblib","forks_url":"https://api.github.com/repos/joblib/joblib/forks","keys_url":"https://api.github.com/repos/joblib/joblib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joblib/joblib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joblib/joblib/teams","hooks_url":"https://api.github.com/repos/joblib/joblib/hooks","issue_events_url":"https://api.github.com/repos/joblib/joblib/issues/events{/number}","events_url":"https://api.github.com/repos/joblib/joblib/events","assignees_url":"https://api.github.com/repos/joblib/joblib/assignees{/user}","branches_url":"https://api.github.com/repos/joblib/joblib/branches{/branch}","tags_url":"https://api.github.com/repos/joblib/joblib/tags","blobs_url":"https://api.github.com/repos/joblib/joblib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joblib/joblib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joblib/joblib/git/refs{/sha}","trees_url":"https://api.github.com/repos/joblib/joblib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joblib/joblib/statuses/{sha}","languages_url":"https://api.github.com/repos/joblib/joblib/languages","stargazers_url":"https://api.github.com/repos/joblib/joblib/stargazers","contributors_url":"https://api.github.com/repos/joblib/joblib/contributors","subscribers_url":"https://api.github.com/repos/joblib/joblib/subscribers","subscription_url":"https://api.github.com/repos/joblib/joblib/subscription","commits_url":"https://api.github.com/repos/joblib/joblib/commits{/sha}","git_commits_url":"https://api.github.com/repos/joblib/joblib/git/commits{/sha}","comments_url":"https://api.github.com/repos/joblib/joblib/comments{/number}","issue_comment_url":"https://api.github.com/repos/joblib/joblib/issues/comments{/number}","contents_url":"https://api.github.com/repos/joblib/joblib/contents/{+path}","compare_url":"https://api.github.com/repos/joblib/joblib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joblib/joblib/merges","archive_url":"https://api.github.com/repos/joblib/joblib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joblib/joblib/downloads","issues_url":"https://api.github.com/repos/joblib/joblib/issues{/number}","pulls_url":"https://api.github.com/repos/joblib/joblib/pulls{/number}","milestones_url":"https://api.github.com/repos/joblib/joblib/milestones{/number}","notifications_url":"https://api.github.com/repos/joblib/joblib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joblib/joblib/labels{/name}","releases_url":"https://api.github.com/repos/joblib/joblib/releases{/id}","created_at":"2010-05-07T06:48:26Z","updated_at":"2015-10-06T17:49:48Z","pushed_at":"2015-10-07T14:38:29Z","git_url":"git://github.com/joblib/joblib.git","ssh_url":"git@github.com:joblib/joblib.git","clone_url":"https://github.com/joblib/joblib.git","svn_url":"https://github.com/joblib/joblib","homepage":"http://packages.python.org/joblib/","size":4044,"stargazers_count":420,"watchers_count":420,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":86,"mirror_url":null,"open_issues_count":80,"forks":86,"open_issues":80,"watchers":420,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/joblib/joblib/pulls/251"},"html":{"href":"https://github.com/joblib/joblib/pull/251"},"issue":{"href":"https://api.github.com/repos/joblib/joblib/issues/251"},"comments":{"href":"https://api.github.com/repos/joblib/joblib/issues/251/comments"},"review_comments":{"href":"https://api.github.com/repos/joblib/joblib/pulls/251/comments"},"review_comment":{"href":"https://api.github.com/repos/joblib/joblib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/joblib/joblib/pulls/251/commits"},"statuses":{"href":"https://api.github.com/repos/joblib/joblib/statuses/27aeea2e6638c89a0c4823ee9a9bbe6e01d8882f"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"ogrisel","id":89061,"avatar_url":"https://avatars.githubusercontent.com/u/89061?v=3","gravatar_id":"","url":"https://api.github.com/users/ogrisel","html_url":"https://github.com/ogrisel","followers_url":"https://api.github.com/users/ogrisel/followers","following_url":"https://api.github.com/users/ogrisel/following{/other_user}","gists_url":"https://api.github.com/users/ogrisel/gists{/gist_id}","starred_url":"https://api.github.com/users/ogrisel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ogrisel/subscriptions","organizations_url":"https://api.github.com/users/ogrisel/orgs","repos_url":"https://api.github.com/users/ogrisel/repos","events_url":"https://api.github.com/users/ogrisel/events{/privacy}","received_events_url":"https://api.github.com/users/ogrisel/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":1,"additions":19,"deletions":9,"changed_files":1}}