{"action":"closed","number":1955,"pull_request":{"url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/pulls/1955","id":29288965,"html_url":"https://github.com/concrete5/concrete5-5.7.0/pull/1955","diff_url":"https://github.com/concrete5/concrete5-5.7.0/pull/1955.diff","patch_url":"https://github.com/concrete5/concrete5-5.7.0/pull/1955.patch","issue_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/issues/1955","number":1955,"state":"closed","locked":false,"title":"Use PermissionKeyCategory for pkgID in load()","user":{"login":"mkly","id":965353,"avatar_url":"https://avatars.githubusercontent.com/u/965353?v=3","gravatar_id":"","url":"https://api.github.com/users/mkly","html_url":"https://github.com/mkly","followers_url":"https://api.github.com/users/mkly/followers","following_url":"https://api.github.com/users/mkly/following{/other_user}","gists_url":"https://api.github.com/users/mkly/gists{/gist_id}","starred_url":"https://api.github.com/users/mkly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkly/subscriptions","organizations_url":"https://api.github.com/users/mkly/orgs","repos_url":"https://api.github.com/users/mkly/repos","events_url":"https://api.github.com/users/mkly/events{/privacy}","received_events_url":"https://api.github.com/users/mkly/received_events","type":"User","site_admin":false},"body":"Query takes in the `pkgID` from `PermissionKeys` which causes an\r\nException as a permission key uses the `PermissionKeyCategory` if there\r\nis not a custom permission key class set.\r\n\r\nFor example a new permission Key that is set to the `admin` permission\r\nkey category uses the `AdminKey` class by default. The current code\r\nlooks for `AdminKey` class in the package path if the permission key(not\r\nthe permission key category) belongs to a package.\r\n\r\n- Use `PermissionKeyCategory.pkgID` for `pkgID` instead of\r\n`PermissionKey.pkgID` in `PermissionKey::load()` and\r\n`PermissionKey::loadAll()` queries.","created_at":"2015-02-13T18:52:04Z","updated_at":"2015-02-17T16:13:14Z","closed_at":"2015-02-17T16:13:14Z","merged_at":"2015-02-17T16:13:14Z","merge_commit_sha":"a3a60f82c2a2b059f2ce487f20856678d2b328c6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/pulls/1955/commits","review_comments_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/pulls/1955/comments","review_comment_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/pulls/comments/{number}","comments_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/issues/1955/comments","statuses_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/statuses/74c912bd05ee0f34fe31580048d0dce37da351bb","head":{"label":"mkly:fix_permission_key_load_loadall","ref":"fix_permission_key_load_loadall","sha":"74c912bd05ee0f34fe31580048d0dce37da351bb","user":{"login":"mkly","id":965353,"avatar_url":"https://avatars.githubusercontent.com/u/965353?v=3","gravatar_id":"","url":"https://api.github.com/users/mkly","html_url":"https://github.com/mkly","followers_url":"https://api.github.com/users/mkly/followers","following_url":"https://api.github.com/users/mkly/following{/other_user}","gists_url":"https://api.github.com/users/mkly/gists{/gist_id}","starred_url":"https://api.github.com/users/mkly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkly/subscriptions","organizations_url":"https://api.github.com/users/mkly/orgs","repos_url":"https://api.github.com/users/mkly/repos","events_url":"https://api.github.com/users/mkly/events{/privacy}","received_events_url":"https://api.github.com/users/mkly/received_events","type":"User","site_admin":false},"repo":{"id":19072931,"name":"concrete5-5.7.0","full_name":"mkly/concrete5-5.7.0","owner":{"login":"mkly","id":965353,"avatar_url":"https://avatars.githubusercontent.com/u/965353?v=3","gravatar_id":"","url":"https://api.github.com/users/mkly","html_url":"https://github.com/mkly","followers_url":"https://api.github.com/users/mkly/followers","following_url":"https://api.github.com/users/mkly/following{/other_user}","gists_url":"https://api.github.com/users/mkly/gists{/gist_id}","starred_url":"https://api.github.com/users/mkly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkly/subscriptions","organizations_url":"https://api.github.com/users/mkly/orgs","repos_url":"https://api.github.com/users/mkly/repos","events_url":"https://api.github.com/users/mkly/events{/privacy}","received_events_url":"https://api.github.com/users/mkly/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mkly/concrete5-5.7.0","description":"Official repository for concrete5 5.7 development","fork":true,"url":"https://api.github.com/repos/mkly/concrete5-5.7.0","forks_url":"https://api.github.com/repos/mkly/concrete5-5.7.0/forks","keys_url":"https://api.github.com/repos/mkly/concrete5-5.7.0/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mkly/concrete5-5.7.0/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mkly/concrete5-5.7.0/teams","hooks_url":"https://api.github.com/repos/mkly/concrete5-5.7.0/hooks","issue_events_url":"https://api.github.com/repos/mkly/concrete5-5.7.0/issues/events{/number}","events_url":"https://api.github.com/repos/mkly/concrete5-5.7.0/events","assignees_url":"https://api.github.com/repos/mkly/concrete5-5.7.0/assignees{/user}","branches_url":"https://api.github.com/repos/mkly/concrete5-5.7.0/branches{/branch}","tags_url":"https://api.github.com/repos/mkly/concrete5-5.7.0/tags","blobs_url":"https://api.github.com/repos/mkly/concrete5-5.7.0/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mkly/concrete5-5.7.0/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mkly/concrete5-5.7.0/git/refs{/sha}","trees_url":"https://api.github.com/repos/mkly/concrete5-5.7.0/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mkly/concrete5-5.7.0/statuses/{sha}","languages_url":"https://api.github.com/repos/mkly/concrete5-5.7.0/languages","stargazers_url":"https://api.github.com/repos/mkly/concrete5-5.7.0/stargazers","contributors_url":"https://api.github.com/repos/mkly/concrete5-5.7.0/contributors","subscribers_url":"https://api.github.com/repos/mkly/concrete5-5.7.0/subscribers","subscription_url":"https://api.github.com/repos/mkly/concrete5-5.7.0/subscription","commits_url":"https://api.github.com/repos/mkly/concrete5-5.7.0/commits{/sha}","git_commits_url":"https://api.github.com/repos/mkly/concrete5-5.7.0/git/commits{/sha}","comments_url":"https://api.github.com/repos/mkly/concrete5-5.7.0/comments{/number}","issue_comment_url":"https://api.github.com/repos/mkly/concrete5-5.7.0/issues/comments/{number}","contents_url":"https://api.github.com/repos/mkly/concrete5-5.7.0/contents/{+path}","compare_url":"https://api.github.com/repos/mkly/concrete5-5.7.0/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mkly/concrete5-5.7.0/merges","archive_url":"https://api.github.com/repos/mkly/concrete5-5.7.0/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mkly/concrete5-5.7.0/downloads","issues_url":"https://api.github.com/repos/mkly/concrete5-5.7.0/issues{/number}","pulls_url":"https://api.github.com/repos/mkly/concrete5-5.7.0/pulls{/number}","milestones_url":"https://api.github.com/repos/mkly/concrete5-5.7.0/milestones{/number}","notifications_url":"https://api.github.com/repos/mkly/concrete5-5.7.0/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mkly/concrete5-5.7.0/labels{/name}","releases_url":"https://api.github.com/repos/mkly/concrete5-5.7.0/releases{/id}","created_at":"2014-04-23T14:35:05Z","updated_at":"2014-11-25T20:52:47Z","pushed_at":"2015-02-16T23:18:58Z","git_url":"git://github.com/mkly/concrete5-5.7.0.git","ssh_url":"git@github.com:mkly/concrete5-5.7.0.git","clone_url":"https://github.com/mkly/concrete5-5.7.0.git","svn_url":"https://github.com/mkly/concrete5-5.7.0","homepage":null,"size":73884,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"concrete5:develop","ref":"develop","sha":"4a3d6431d64a28e34068072a0e7ff6e55b132e68","user":{"login":"concrete5","id":657929,"avatar_url":"https://avatars.githubusercontent.com/u/657929?v=3","gravatar_id":"","url":"https://api.github.com/users/concrete5","html_url":"https://github.com/concrete5","followers_url":"https://api.github.com/users/concrete5/followers","following_url":"https://api.github.com/users/concrete5/following{/other_user}","gists_url":"https://api.github.com/users/concrete5/gists{/gist_id}","starred_url":"https://api.github.com/users/concrete5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/concrete5/subscriptions","organizations_url":"https://api.github.com/users/concrete5/orgs","repos_url":"https://api.github.com/users/concrete5/repos","events_url":"https://api.github.com/users/concrete5/events{/privacy}","received_events_url":"https://api.github.com/users/concrete5/received_events","type":"Organization","site_admin":false},"repo":{"id":19040482,"name":"concrete5-5.7.0","full_name":"concrete5/concrete5-5.7.0","owner":{"login":"concrete5","id":657929,"avatar_url":"https://avatars.githubusercontent.com/u/657929?v=3","gravatar_id":"","url":"https://api.github.com/users/concrete5","html_url":"https://github.com/concrete5","followers_url":"https://api.github.com/users/concrete5/followers","following_url":"https://api.github.com/users/concrete5/following{/other_user}","gists_url":"https://api.github.com/users/concrete5/gists{/gist_id}","starred_url":"https://api.github.com/users/concrete5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/concrete5/subscriptions","organizations_url":"https://api.github.com/users/concrete5/orgs","repos_url":"https://api.github.com/users/concrete5/repos","events_url":"https://api.github.com/users/concrete5/events{/privacy}","received_events_url":"https://api.github.com/users/concrete5/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/concrete5/concrete5-5.7.0","description":"Official repository for concrete5 5.7 development","fork":false,"url":"https://api.github.com/repos/concrete5/concrete5-5.7.0","forks_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/forks","keys_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/keys{/key_id}","collaborators_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/teams","hooks_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/hooks","issue_events_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/issues/events{/number}","events_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/events","assignees_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/assignees{/user}","branches_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/branches{/branch}","tags_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/tags","blobs_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/git/refs{/sha}","trees_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/git/trees{/sha}","statuses_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/statuses/{sha}","languages_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/languages","stargazers_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/stargazers","contributors_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/contributors","subscribers_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/subscribers","subscription_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/subscription","commits_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/commits{/sha}","git_commits_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/git/commits{/sha}","comments_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/comments{/number}","issue_comment_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/issues/comments/{number}","contents_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/contents/{+path}","compare_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/compare/{base}...{head}","merges_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/merges","archive_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/downloads","issues_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/issues{/number}","pulls_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/pulls{/number}","milestones_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/milestones{/number}","notifications_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/labels{/name}","releases_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/releases{/id}","created_at":"2014-04-22T18:12:28Z","updated_at":"2015-02-17T16:11:01Z","pushed_at":"2015-02-17T16:13:14Z","git_url":"git://github.com/concrete5/concrete5-5.7.0.git","ssh_url":"git@github.com:concrete5/concrete5-5.7.0.git","clone_url":"https://github.com/concrete5/concrete5-5.7.0.git","svn_url":"https://github.com/concrete5/concrete5-5.7.0","homepage":"","size":116583,"stargazers_count":117,"watchers_count":117,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":136,"mirror_url":null,"open_issues_count":251,"forks":136,"open_issues":251,"watchers":117,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/concrete5/concrete5-5.7.0/pulls/1955"},"html":{"href":"https://github.com/concrete5/concrete5-5.7.0/pull/1955"},"issue":{"href":"https://api.github.com/repos/concrete5/concrete5-5.7.0/issues/1955"},"comments":{"href":"https://api.github.com/repos/concrete5/concrete5-5.7.0/issues/1955/comments"},"review_comments":{"href":"https://api.github.com/repos/concrete5/concrete5-5.7.0/pulls/1955/comments"},"review_comment":{"href":"https://api.github.com/repos/concrete5/concrete5-5.7.0/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/concrete5/concrete5-5.7.0/pulls/1955/commits"},"statuses":{"href":"https://api.github.com/repos/concrete5/concrete5-5.7.0/statuses/74c912bd05ee0f34fe31580048d0dce37da351bb"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"aembler","id":527809,"avatar_url":"https://avatars.githubusercontent.com/u/527809?v=3","gravatar_id":"","url":"https://api.github.com/users/aembler","html_url":"https://github.com/aembler","followers_url":"https://api.github.com/users/aembler/followers","following_url":"https://api.github.com/users/aembler/following{/other_user}","gists_url":"https://api.github.com/users/aembler/gists{/gist_id}","starred_url":"https://api.github.com/users/aembler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aembler/subscriptions","organizations_url":"https://api.github.com/users/aembler/orgs","repos_url":"https://api.github.com/users/aembler/repos","events_url":"https://api.github.com/users/aembler/events{/privacy}","received_events_url":"https://api.github.com/users/aembler/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":3,"deletions":2,"changed_files":2}}