{"action":"created","comment":{"url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/pulls/comments/30706330","id":30706330,"diff_hunk":"@@ -296,7 +296,9 @@ func Discharge(key *KeyPair, checker ThirdPartyChecker, id string) (*macaroon.Ma\n \t\treturn nil, nil, errgo.Mask(err, errgo.Any)\n \t}\n \t// Note that the discharge macaroon does not need to\n-\t// be stored persistently.\n+\t// be stored persistently. Indeed, it would be a problem if","path":"bakery/service.go","position":5,"original_position":5,"commit_id":"7391e01e8628d27d871e4d8ca2e344f31dd44621","original_commit_id":"7391e01e8628d27d871e4d8ca2e344f31dd44621","user":{"login":"rogpeppe","id":66491,"avatar_url":"https://avatars.githubusercontent.com/u/66491?v=3","gravatar_id":"","url":"https://api.github.com/users/rogpeppe","html_url":"https://github.com/rogpeppe","followers_url":"https://api.github.com/users/rogpeppe/followers","following_url":"https://api.github.com/users/rogpeppe/following{/other_user}","gists_url":"https://api.github.com/users/rogpeppe/gists{/gist_id}","starred_url":"https://api.github.com/users/rogpeppe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rogpeppe/subscriptions","organizations_url":"https://api.github.com/users/rogpeppe/orgs","repos_url":"https://api.github.com/users/rogpeppe/repos","events_url":"https://api.github.com/users/rogpeppe/events{/privacy}","received_events_url":"https://api.github.com/users/rogpeppe/received_events","type":"User","site_admin":false},"body":"As discussed online, this test is here in part to protect against that bug possibility.","created_at":"2015-05-20T14:19:52Z","updated_at":"2015-05-20T14:19:52Z","html_url":"https://github.com/go-macaroon-bakery/macaroon-bakery/pull/49#discussion_r30706330","pull_request_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/pulls/49","_links":{"self":{"href":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/pulls/comments/30706330"},"html":{"href":"https://github.com/go-macaroon-bakery/macaroon-bakery/pull/49#discussion_r30706330"},"pull_request":{"href":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/pulls/49"}}},"pull_request":{"url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/pulls/49","id":35829616,"html_url":"https://github.com/go-macaroon-bakery/macaroon-bakery/pull/49","diff_url":"https://github.com/go-macaroon-bakery/macaroon-bakery/pull/49.diff","patch_url":"https://github.com/go-macaroon-bakery/macaroon-bakery/pull/49.patch","issue_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/issues/49","number":49,"state":"open","locked":false,"title":"bakery: add test to make sure discharge macaroons cannot be used for normal authorization","user":{"login":"rogpeppe","id":66491,"avatar_url":"https://avatars.githubusercontent.com/u/66491?v=3","gravatar_id":"","url":"https://api.github.com/users/rogpeppe","html_url":"https://github.com/rogpeppe","followers_url":"https://api.github.com/users/rogpeppe/followers","following_url":"https://api.github.com/users/rogpeppe/following{/other_user}","gists_url":"https://api.github.com/users/rogpeppe/gists{/gist_id}","starred_url":"https://api.github.com/users/rogpeppe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rogpeppe/subscriptions","organizations_url":"https://api.github.com/users/rogpeppe/orgs","repos_url":"https://api.github.com/users/rogpeppe/repos","events_url":"https://api.github.com/users/rogpeppe/events{/privacy}","received_events_url":"https://api.github.com/users/rogpeppe/received_events","type":"User","site_admin":false},"body":"A conversation on IRC left me with a lingering doubt as to whether this\r\nmight be a problem. The test reassures me that it's not.\r\n","created_at":"2015-05-20T13:09:51Z","updated_at":"2015-05-20T14:19:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"548c52e62526603fe9ca62d6dab894c224fbe5aa","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/pulls/49/commits","review_comments_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/pulls/49/comments","review_comment_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/pulls/comments{/number}","comments_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/issues/49/comments","statuses_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/statuses/7391e01e8628d27d871e4d8ca2e344f31dd44621","head":{"label":"rogpeppe:035-discharge-test-case","ref":"035-discharge-test-case","sha":"7391e01e8628d27d871e4d8ca2e344f31dd44621","user":{"login":"rogpeppe","id":66491,"avatar_url":"https://avatars.githubusercontent.com/u/66491?v=3","gravatar_id":"","url":"https://api.github.com/users/rogpeppe","html_url":"https://github.com/rogpeppe","followers_url":"https://api.github.com/users/rogpeppe/followers","following_url":"https://api.github.com/users/rogpeppe/following{/other_user}","gists_url":"https://api.github.com/users/rogpeppe/gists{/gist_id}","starred_url":"https://api.github.com/users/rogpeppe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rogpeppe/subscriptions","organizations_url":"https://api.github.com/users/rogpeppe/orgs","repos_url":"https://api.github.com/users/rogpeppe/repos","events_url":"https://api.github.com/users/rogpeppe/events{/privacy}","received_events_url":"https://api.github.com/users/rogpeppe/received_events","type":"User","site_admin":false},"repo":{"id":26593657,"name":"macaroon-bakery","full_name":"rogpeppe/macaroon-bakery","owner":{"login":"rogpeppe","id":66491,"avatar_url":"https://avatars.githubusercontent.com/u/66491?v=3","gravatar_id":"","url":"https://api.github.com/users/rogpeppe","html_url":"https://github.com/rogpeppe","followers_url":"https://api.github.com/users/rogpeppe/followers","following_url":"https://api.github.com/users/rogpeppe/following{/other_user}","gists_url":"https://api.github.com/users/rogpeppe/gists{/gist_id}","starred_url":"https://api.github.com/users/rogpeppe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rogpeppe/subscriptions","organizations_url":"https://api.github.com/users/rogpeppe/orgs","repos_url":"https://api.github.com/users/rogpeppe/repos","events_url":"https://api.github.com/users/rogpeppe/events{/privacy}","received_events_url":"https://api.github.com/users/rogpeppe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rogpeppe/macaroon-bakery","description":"We bake 'em sweet, we bake 'em nice","fork":true,"url":"https://api.github.com/repos/rogpeppe/macaroon-bakery","forks_url":"https://api.github.com/repos/rogpeppe/macaroon-bakery/forks","keys_url":"https://api.github.com/repos/rogpeppe/macaroon-bakery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rogpeppe/macaroon-bakery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rogpeppe/macaroon-bakery/teams","hooks_url":"https://api.github.com/repos/rogpeppe/macaroon-bakery/hooks","issue_events_url":"https://api.github.com/repos/rogpeppe/macaroon-bakery/issues/events{/number}","events_url":"https://api.github.com/repos/rogpeppe/macaroon-bakery/events","assignees_url":"https://api.github.com/repos/rogpeppe/macaroon-bakery/assignees{/user}","branches_url":"https://api.github.com/repos/rogpeppe/macaroon-bakery/branches{/branch}","tags_url":"https://api.github.com/repos/rogpeppe/macaroon-bakery/tags","blobs_url":"https://api.github.com/repos/rogpeppe/macaroon-bakery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rogpeppe/macaroon-bakery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rogpeppe/macaroon-bakery/git/refs{/sha}","trees_url":"https://api.github.com/repos/rogpeppe/macaroon-bakery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rogpeppe/macaroon-bakery/statuses/{sha}","languages_url":"https://api.github.com/repos/rogpeppe/macaroon-bakery/languages","stargazers_url":"https://api.github.com/repos/rogpeppe/macaroon-bakery/stargazers","contributors_url":"https://api.github.com/repos/rogpeppe/macaroon-bakery/contributors","subscribers_url":"https://api.github.com/repos/rogpeppe/macaroon-bakery/subscribers","subscription_url":"https://api.github.com/repos/rogpeppe/macaroon-bakery/subscription","commits_url":"https://api.github.com/repos/rogpeppe/macaroon-bakery/commits{/sha}","git_commits_url":"https://api.github.com/repos/rogpeppe/macaroon-bakery/git/commits{/sha}","comments_url":"https://api.github.com/repos/rogpeppe/macaroon-bakery/comments{/number}","issue_comment_url":"https://api.github.com/repos/rogpeppe/macaroon-bakery/issues/comments{/number}","contents_url":"https://api.github.com/repos/rogpeppe/macaroon-bakery/contents/{+path}","compare_url":"https://api.github.com/repos/rogpeppe/macaroon-bakery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rogpeppe/macaroon-bakery/merges","archive_url":"https://api.github.com/repos/rogpeppe/macaroon-bakery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rogpeppe/macaroon-bakery/downloads","issues_url":"https://api.github.com/repos/rogpeppe/macaroon-bakery/issues{/number}","pulls_url":"https://api.github.com/repos/rogpeppe/macaroon-bakery/pulls{/number}","milestones_url":"https://api.github.com/repos/rogpeppe/macaroon-bakery/milestones{/number}","notifications_url":"https://api.github.com/repos/rogpeppe/macaroon-bakery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rogpeppe/macaroon-bakery/labels{/name}","releases_url":"https://api.github.com/repos/rogpeppe/macaroon-bakery/releases{/id}","created_at":"2014-11-13T15:18:37Z","updated_at":"2014-12-11T03:12:38Z","pushed_at":"2015-05-20T13:08:31Z","git_url":"git://github.com/rogpeppe/macaroon-bakery.git","ssh_url":"git@github.com:rogpeppe/macaroon-bakery.git","clone_url":"https://github.com/rogpeppe/macaroon-bakery.git","svn_url":"https://github.com/rogpeppe/macaroon-bakery","homepage":null,"size":791,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"v0"}},"base":{"label":"go-macaroon-bakery:v1","ref":"v1","sha":"139fd50b8fa8ef8bb7c0ae70ce17b5675c8aff7d","user":{"login":"go-macaroon-bakery","id":9721471,"avatar_url":"https://avatars.githubusercontent.com/u/9721471?v=3","gravatar_id":"","url":"https://api.github.com/users/go-macaroon-bakery","html_url":"https://github.com/go-macaroon-bakery","followers_url":"https://api.github.com/users/go-macaroon-bakery/followers","following_url":"https://api.github.com/users/go-macaroon-bakery/following{/other_user}","gists_url":"https://api.github.com/users/go-macaroon-bakery/gists{/gist_id}","starred_url":"https://api.github.com/users/go-macaroon-bakery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/go-macaroon-bakery/subscriptions","organizations_url":"https://api.github.com/users/go-macaroon-bakery/orgs","repos_url":"https://api.github.com/users/go-macaroon-bakery/repos","events_url":"https://api.github.com/users/go-macaroon-bakery/events{/privacy}","received_events_url":"https://api.github.com/users/go-macaroon-bakery/received_events","type":"Organization","site_admin":false},"repo":{"id":26593206,"name":"macaroon-bakery","full_name":"go-macaroon-bakery/macaroon-bakery","owner":{"login":"go-macaroon-bakery","id":9721471,"avatar_url":"https://avatars.githubusercontent.com/u/9721471?v=3","gravatar_id":"","url":"https://api.github.com/users/go-macaroon-bakery","html_url":"https://github.com/go-macaroon-bakery","followers_url":"https://api.github.com/users/go-macaroon-bakery/followers","following_url":"https://api.github.com/users/go-macaroon-bakery/following{/other_user}","gists_url":"https://api.github.com/users/go-macaroon-bakery/gists{/gist_id}","starred_url":"https://api.github.com/users/go-macaroon-bakery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/go-macaroon-bakery/subscriptions","organizations_url":"https://api.github.com/users/go-macaroon-bakery/orgs","repos_url":"https://api.github.com/users/go-macaroon-bakery/repos","events_url":"https://api.github.com/users/go-macaroon-bakery/events{/privacy}","received_events_url":"https://api.github.com/users/go-macaroon-bakery/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/go-macaroon-bakery/macaroon-bakery","description":"We bake 'em sweet, we bake 'em nice","fork":false,"url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery","forks_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/forks","keys_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/teams","hooks_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/hooks","issue_events_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/issues/events{/number}","events_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/events","assignees_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/assignees{/user}","branches_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/branches{/branch}","tags_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/tags","blobs_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/git/refs{/sha}","trees_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/statuses/{sha}","languages_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/languages","stargazers_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/stargazers","contributors_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/contributors","subscribers_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/subscribers","subscription_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/subscription","commits_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/commits{/sha}","git_commits_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/git/commits{/sha}","comments_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/comments{/number}","issue_comment_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/issues/comments{/number}","contents_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/contents/{+path}","compare_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/merges","archive_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/downloads","issues_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/issues{/number}","pulls_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/pulls{/number}","milestones_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/milestones{/number}","notifications_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/labels{/name}","releases_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/releases{/id}","created_at":"2014-11-13T15:08:41Z","updated_at":"2015-05-20T12:08:20Z","pushed_at":"2015-05-20T13:09:52Z","git_url":"git://github.com/go-macaroon-bakery/macaroon-bakery.git","ssh_url":"git@github.com:go-macaroon-bakery/macaroon-bakery.git","clone_url":"https://github.com/go-macaroon-bakery/macaroon-bakery.git","svn_url":"https://github.com/go-macaroon-bakery/macaroon-bakery","homepage":null,"size":1069,"stargazers_count":12,"watchers_count":12,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":2,"forks":5,"open_issues":2,"watchers":12,"default_branch":"v1"}},"_links":{"self":{"href":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/pulls/49"},"html":{"href":"https://github.com/go-macaroon-bakery/macaroon-bakery/pull/49"},"issue":{"href":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/issues/49"},"comments":{"href":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/issues/49/comments"},"review_comments":{"href":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/pulls/49/comments"},"review_comment":{"href":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/pulls/49/commits"},"statuses":{"href":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/statuses/7391e01e8628d27d871e4d8ca2e344f31dd44621"}}}}