{"action":"created","issue":{"url":"https://api.github.com/repos/eggs-cpp/variant/issues/11","labels_url":"https://api.github.com/repos/eggs-cpp/variant/issues/11/labels{/name}","comments_url":"https://api.github.com/repos/eggs-cpp/variant/issues/11/comments","events_url":"https://api.github.com/repos/eggs-cpp/variant/issues/11/events","html_url":"https://github.com/eggs-cpp/variant/pull/11","id":100161860,"number":11,"title":"Support building without RTTI and exceptions","user":{"login":"blastrock","id":1370530,"avatar_url":"https://avatars.githubusercontent.com/u/1370530?v=3","gravatar_id":"","url":"https://api.github.com/users/blastrock","html_url":"https://github.com/blastrock","followers_url":"https://api.github.com/users/blastrock/followers","following_url":"https://api.github.com/users/blastrock/following{/other_user}","gists_url":"https://api.github.com/users/blastrock/gists{/gist_id}","starred_url":"https://api.github.com/users/blastrock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blastrock/subscriptions","organizations_url":"https://api.github.com/users/blastrock/orgs","repos_url":"https://api.github.com/users/blastrock/repos","events_url":"https://api.github.com/users/blastrock/events{/privacy}","received_events_url":"https://api.github.com/users/blastrock/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-08-10T20:28:53Z","updated_at":"2015-08-12T18:23:40Z","closed_at":"2015-08-11T16:45:17Z","pull_request":{"url":"https://api.github.com/repos/eggs-cpp/variant/pulls/11","html_url":"https://github.com/eggs-cpp/variant/pull/11","diff_url":"https://github.com/eggs-cpp/variant/pull/11.diff","patch_url":"https://github.com/eggs-cpp/variant/pull/11.patch"},"body":"Same as #10 but on develop.\r\n\r\nHere are the differences:\r\n- fix the include for bad_variant_access\r\n- rename macros\r\n- try to give them default values in prefix.hpp\r\n- undefine them in suffix.hpp\r\n- document them in config.md\r\n\r\nAbout the guesses, the macro I took are from https://gcc.gnu.org/onlinedocs/cpp/Common-Predefined-Macros.html for gcc. These macros are supported by clang (tested on clang 3.6 only though).\r\nFor MSVC, I took them from https://msdn.microsoft.com/en-us/library/b0084kay.aspx .\r\n\r\nI don't have any MSVC installed, I couldn't test compiling on it.\r\n\r\nBtw, the tests do not compile with these flags on (as expected), but I'm not sure it's worth the effort making them compatible."},"comment":{"url":"https://api.github.com/repos/eggs-cpp/variant/issues/comments/130400859","html_url":"https://github.com/eggs-cpp/variant/pull/11#issuecomment-130400859","issue_url":"https://api.github.com/repos/eggs-cpp/variant/issues/11","id":130400859,"user":{"login":"blastrock","id":1370530,"avatar_url":"https://avatars.githubusercontent.com/u/1370530?v=3","gravatar_id":"","url":"https://api.github.com/users/blastrock","html_url":"https://github.com/blastrock","followers_url":"https://api.github.com/users/blastrock/followers","following_url":"https://api.github.com/users/blastrock/following{/other_user}","gists_url":"https://api.github.com/users/blastrock/gists{/gist_id}","starred_url":"https://api.github.com/users/blastrock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blastrock/subscriptions","organizations_url":"https://api.github.com/users/blastrock/orgs","repos_url":"https://api.github.com/users/blastrock/repos","events_url":"https://api.github.com/users/blastrock/events{/privacy}","received_events_url":"https://api.github.com/users/blastrock/received_events","type":"User","site_admin":false},"created_at":"2015-08-12T18:23:40Z","updated_at":"2015-08-12T18:23:40Z","body":"> This has been now merged to master.\r\n\r\nGreat, thanks!\r\n\r\n> Unfortunately Catch does not compile when exceptions are disabled\r\n\r\nOh indeed, that's more troublesome. If you break that configuration, I'll make another PR anyway :)"}}