{"action":"created","comment":{"url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/pulls/comments/29541094","id":29541094,"diff_hunk":"@@ -34,11 +34,11 @@ -(id) init\n         [NSBundle loadNibNamed:@\"ADCredentialViewController\" owner:self];\n //        loaded = [[NSBundle mainBundle] loadNibNamed:@\"ADCredentialViewController\" owner:self topLevelObjects:nil];\n         \n-        SAFE_ARC_RETAIN(_customView);\n-        SAFE_ARC_RETAIN(_usernameField);\n-        SAFE_ARC_RETAIN(_passwordField);\n-        SAFE_ARC_RETAIN(_usernameLabel);\n-        SAFE_ARC_RETAIN(_passwordLabel);\n+//        SAFE_ARC_RETAIN(_customView);\n+//        SAFE_ARC_RETAIN(_usernameField);\n+//        SAFE_ARC_RETAIN(_passwordField);\n+//        SAFE_ARC_RETAIN(_usernameLabel);\n+//        SAFE_ARC_RETAIN(_passwordLabel);","path":"ADAL-OSX/ADAL-OSX/ADCredentialCollectionController.m","position":13,"original_position":13,"commit_id":"0a13f57f70ef395c3ff480b2fb63935b89a5f245","original_commit_id":"0a13f57f70ef395c3ff480b2fb63935b89a5f245","user":{"login":"RPangrle-MS","id":7004783,"avatar_url":"https://avatars.githubusercontent.com/u/7004783?v=3","gravatar_id":"","url":"https://api.github.com/users/RPangrle-MS","html_url":"https://github.com/RPangrle-MS","followers_url":"https://api.github.com/users/RPangrle-MS/followers","following_url":"https://api.github.com/users/RPangrle-MS/following{/other_user}","gists_url":"https://api.github.com/users/RPangrle-MS/gists{/gist_id}","starred_url":"https://api.github.com/users/RPangrle-MS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RPangrle-MS/subscriptions","organizations_url":"https://api.github.com/users/RPangrle-MS/orgs","repos_url":"https://api.github.com/users/RPangrle-MS/repos","events_url":"https://api.github.com/users/RPangrle-MS/events{/privacy}","received_events_url":"https://api.github.com/users/RPangrle-MS/received_events","type":"User","site_admin":false},"body":"Delete these lines entirely. We don't need them laying around.","created_at":"2015-05-01T23:33:02Z","updated_at":"2015-05-01T23:33:02Z","html_url":"https://github.com/AzureAD/azure-activedirectory-library-for-objc/pull/309#discussion_r29541094","pull_request_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/pulls/309","_links":{"self":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/pulls/comments/29541094"},"html":{"href":"https://github.com/AzureAD/azure-activedirectory-library-for-objc/pull/309#discussion_r29541094"},"pull_request":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/pulls/309"}}},"pull_request":{"url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/pulls/309","id":34571754,"html_url":"https://github.com/AzureAD/azure-activedirectory-library-for-objc/pull/309","diff_url":"https://github.com/AzureAD/azure-activedirectory-library-for-objc/pull/309.diff","patch_url":"https://github.com/AzureAD/azure-activedirectory-library-for-objc/pull/309.patch","issue_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/issues/309","number":309,"state":"open","locked":false,"title":"Osxuniversal leak check","user":{"login":"kpanwar","id":5713915,"avatar_url":"https://avatars.githubusercontent.com/u/5713915?v=3","gravatar_id":"","url":"https://api.github.com/users/kpanwar","html_url":"https://github.com/kpanwar","followers_url":"https://api.github.com/users/kpanwar/followers","following_url":"https://api.github.com/users/kpanwar/following{/other_user}","gists_url":"https://api.github.com/users/kpanwar/gists{/gist_id}","starred_url":"https://api.github.com/users/kpanwar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kpanwar/subscriptions","organizations_url":"https://api.github.com/users/kpanwar/orgs","repos_url":"https://api.github.com/users/kpanwar/repos","events_url":"https://api.github.com/users/kpanwar/events{/privacy}","received_events_url":"https://api.github.com/users/kpanwar/received_events","type":"User","site_admin":false},"body":"leak cleanups\n<a href='#crh-start'></a><a href='#crh-data-%7B%7D'></a>\n<a href='https://www.codereviewhub.com/'><img src='http://www.codereviewhub.com/site/github-bar.png' height=40></a>\n<a href='https://www.codereviewhub.com/AzureAD/azure-activedirectory-library-for-objc/pull/309?approve=1'><img src='http://www.codereviewhub.com/site/github-approve.png' height=26></a>&nbsp;<a href='https://github.com/AzureAD/azure-activedirectory-library-for-objc/pull/309'><img src='http://www.codereviewhub.com/site/github-refresh.png' height=26></a>\n<a href='#crh-end'></a>","created_at":"2015-05-01T22:12:25Z","updated_at":"2015-05-01T23:33:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1ee4b74ee37ed0f95323911739c33db9e9902c50","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/pulls/309/commits","review_comments_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/pulls/309/comments","review_comment_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/issues/309/comments","statuses_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/statuses/0a13f57f70ef395c3ff480b2fb63935b89a5f245","head":{"label":"AzureAD:osxuniversal-leak-check","ref":"osxuniversal-leak-check","sha":"0a13f57f70ef395c3ff480b2fb63935b89a5f245","user":{"login":"AzureAD","id":2966316,"avatar_url":"https://avatars.githubusercontent.com/u/2966316?v=3","gravatar_id":"","url":"https://api.github.com/users/AzureAD","html_url":"https://github.com/AzureAD","followers_url":"https://api.github.com/users/AzureAD/followers","following_url":"https://api.github.com/users/AzureAD/following{/other_user}","gists_url":"https://api.github.com/users/AzureAD/gists{/gist_id}","starred_url":"https://api.github.com/users/AzureAD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AzureAD/subscriptions","organizations_url":"https://api.github.com/users/AzureAD/orgs","repos_url":"https://api.github.com/users/AzureAD/repos","events_url":"https://api.github.com/users/AzureAD/events{/privacy}","received_events_url":"https://api.github.com/users/AzureAD/received_events","type":"Organization","site_admin":false},"repo":{"id":14703038,"name":"azure-activedirectory-library-for-objc","full_name":"AzureAD/azure-activedirectory-library-for-objc","owner":{"login":"AzureAD","id":2966316,"avatar_url":"https://avatars.githubusercontent.com/u/2966316?v=3","gravatar_id":"","url":"https://api.github.com/users/AzureAD","html_url":"https://github.com/AzureAD","followers_url":"https://api.github.com/users/AzureAD/followers","following_url":"https://api.github.com/users/AzureAD/following{/other_user}","gists_url":"https://api.github.com/users/AzureAD/gists{/gist_id}","starred_url":"https://api.github.com/users/AzureAD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AzureAD/subscriptions","organizations_url":"https://api.github.com/users/AzureAD/orgs","repos_url":"https://api.github.com/users/AzureAD/repos","events_url":"https://api.github.com/users/AzureAD/events{/privacy}","received_events_url":"https://api.github.com/users/AzureAD/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AzureAD/azure-activedirectory-library-for-objc","description":"The ADAL SDK for Objective C gives you the ability to add support for Work Accounts to your iOS and OS X applications with just a few lines of additional code. This SDK gives your application the full functionality of Microsoft Azure AD, including industry standard protocol support for OAuth2, Web API integration with user level consent, and two factor authentication support.","fork":false,"url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc","forks_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/forks","keys_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/teams","hooks_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/hooks","issue_events_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/issues/events{/number}","events_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/events","assignees_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/assignees{/user}","branches_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/branches{/branch}","tags_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/tags","blobs_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/git/refs{/sha}","trees_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/statuses/{sha}","languages_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/languages","stargazers_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/stargazers","contributors_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/contributors","subscribers_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/subscribers","subscription_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/subscription","commits_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/commits{/sha}","git_commits_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/git/commits{/sha}","comments_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/comments{/number}","issue_comment_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/issues/comments{/number}","contents_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/contents/{+path}","compare_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/merges","archive_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/downloads","issues_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/issues{/number}","pulls_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/pulls{/number}","milestones_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/milestones{/number}","notifications_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/labels{/name}","releases_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/releases{/id}","created_at":"2013-11-26T00:46:00Z","updated_at":"2015-04-30T22:32:19Z","pushed_at":"2015-05-01T22:12:25Z","git_url":"git://github.com/AzureAD/azure-activedirectory-library-for-objc.git","ssh_url":"git@github.com:AzureAD/azure-activedirectory-library-for-objc.git","clone_url":"https://github.com/AzureAD/azure-activedirectory-library-for-objc.git","svn_url":"https://github.com/AzureAD/azure-activedirectory-library-for-objc","homepage":"","size":11838,"stargazers_count":48,"watchers_count":48,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":31,"mirror_url":null,"open_issues_count":31,"forks":31,"open_issues":31,"watchers":48,"default_branch":"master"}},"base":{"label":"AzureAD:OSXUniversal-dev","ref":"OSXUniversal-dev","sha":"65d6b623cd43c0e139315e6a816ec6940ce2ad18","user":{"login":"AzureAD","id":2966316,"avatar_url":"https://avatars.githubusercontent.com/u/2966316?v=3","gravatar_id":"","url":"https://api.github.com/users/AzureAD","html_url":"https://github.com/AzureAD","followers_url":"https://api.github.com/users/AzureAD/followers","following_url":"https://api.github.com/users/AzureAD/following{/other_user}","gists_url":"https://api.github.com/users/AzureAD/gists{/gist_id}","starred_url":"https://api.github.com/users/AzureAD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AzureAD/subscriptions","organizations_url":"https://api.github.com/users/AzureAD/orgs","repos_url":"https://api.github.com/users/AzureAD/repos","events_url":"https://api.github.com/users/AzureAD/events{/privacy}","received_events_url":"https://api.github.com/users/AzureAD/received_events","type":"Organization","site_admin":false},"repo":{"id":14703038,"name":"azure-activedirectory-library-for-objc","full_name":"AzureAD/azure-activedirectory-library-for-objc","owner":{"login":"AzureAD","id":2966316,"avatar_url":"https://avatars.githubusercontent.com/u/2966316?v=3","gravatar_id":"","url":"https://api.github.com/users/AzureAD","html_url":"https://github.com/AzureAD","followers_url":"https://api.github.com/users/AzureAD/followers","following_url":"https://api.github.com/users/AzureAD/following{/other_user}","gists_url":"https://api.github.com/users/AzureAD/gists{/gist_id}","starred_url":"https://api.github.com/users/AzureAD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AzureAD/subscriptions","organizations_url":"https://api.github.com/users/AzureAD/orgs","repos_url":"https://api.github.com/users/AzureAD/repos","events_url":"https://api.github.com/users/AzureAD/events{/privacy}","received_events_url":"https://api.github.com/users/AzureAD/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AzureAD/azure-activedirectory-library-for-objc","description":"The ADAL SDK for Objective C gives you the ability to add support for Work Accounts to your iOS and OS X applications with just a few lines of additional code. This SDK gives your application the full functionality of Microsoft Azure AD, including industry standard protocol support for OAuth2, Web API integration with user level consent, and two factor authentication support.","fork":false,"url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc","forks_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/forks","keys_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/teams","hooks_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/hooks","issue_events_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/issues/events{/number}","events_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/events","assignees_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/assignees{/user}","branches_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/branches{/branch}","tags_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/tags","blobs_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/git/refs{/sha}","trees_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/statuses/{sha}","languages_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/languages","stargazers_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/stargazers","contributors_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/contributors","subscribers_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/subscribers","subscription_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/subscription","commits_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/commits{/sha}","git_commits_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/git/commits{/sha}","comments_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/comments{/number}","issue_comment_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/issues/comments{/number}","contents_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/contents/{+path}","compare_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/merges","archive_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/downloads","issues_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/issues{/number}","pulls_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/pulls{/number}","milestones_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/milestones{/number}","notifications_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/labels{/name}","releases_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/releases{/id}","created_at":"2013-11-26T00:46:00Z","updated_at":"2015-04-30T22:32:19Z","pushed_at":"2015-05-01T22:12:25Z","git_url":"git://github.com/AzureAD/azure-activedirectory-library-for-objc.git","ssh_url":"git@github.com:AzureAD/azure-activedirectory-library-for-objc.git","clone_url":"https://github.com/AzureAD/azure-activedirectory-library-for-objc.git","svn_url":"https://github.com/AzureAD/azure-activedirectory-library-for-objc","homepage":"","size":11838,"stargazers_count":48,"watchers_count":48,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":31,"mirror_url":null,"open_issues_count":31,"forks":31,"open_issues":31,"watchers":48,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/pulls/309"},"html":{"href":"https://github.com/AzureAD/azure-activedirectory-library-for-objc/pull/309"},"issue":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/issues/309"},"comments":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/issues/309/comments"},"review_comments":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/pulls/309/comments"},"review_comment":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/pulls/309/commits"},"statuses":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/statuses/0a13f57f70ef395c3ff480b2fb63935b89a5f245"}}}}