{"action":"created","issue":{"url":"https://api.github.com/repos/openzfs/openzfs/issues/17","labels_url":"https://api.github.com/repos/openzfs/openzfs/issues/17/labels{/name}","comments_url":"https://api.github.com/repos/openzfs/openzfs/issues/17/comments","events_url":"https://api.github.com/repos/openzfs/openzfs/issues/17/events","html_url":"https://github.com/openzfs/openzfs/pull/17","id":112777855,"number":17,"title":"IllumOS 6183 upgrade soft panic","user":{"login":"lundman","id":637168,"avatar_url":"https://avatars.githubusercontent.com/u/637168?v=3","gravatar_id":"","url":"https://api.github.com/users/lundman","html_url":"https://github.com/lundman","followers_url":"https://api.github.com/users/lundman/followers","following_url":"https://api.github.com/users/lundman/following{/other_user}","gists_url":"https://api.github.com/users/lundman/gists{/gist_id}","starred_url":"https://api.github.com/users/lundman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lundman/subscriptions","organizations_url":"https://api.github.com/users/lundman/orgs","repos_url":"https://api.github.com/users/lundman/repos","events_url":"https://api.github.com/users/lundman/events{/privacy}","received_events_url":"https://api.github.com/users/lundman/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/openzfs/openzfs/labels/question","name":"question","color":"cc317c"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2015-10-22T10:54:16Z","updated_at":"2015-11-04T23:56:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/openzfs/openzfs/pulls/17","html_url":"https://github.com/openzfs/openzfs/pull/17","diff_url":"https://github.com/openzfs/openzfs/pull/17.diff","patch_url":"https://github.com/openzfs/openzfs/pull/17.patch"},"body":"\"Fixing\" a problem by removing the VERIFY() call that panics is a bit weak, but I am hoping to start a discussion on this problem to see what should be done. This pull request includes zfs-tester file `zpool_upgrade_010_pos.ksh` which triggers it.\r\n\r\nVery old dataset upgrade path, fails with:\r\n\r\nVERIFY3 \" \"failed (\"\r\n\"0xffffff824e87a100\" \" \" \"==\" \" \" \"0xffffff824e87b980\" \")\\n\"@dmu_objset.c:579\r\n\r\nCan be triggered with:\r\n\r\nmkfile 256m filepool.bin\r\nzpool create -o version=1 -O version=1 fp `pwd`/filepool.bin\r\nzfs upgrade -V 2 fp\r\nzfs upgrade -V 3 fp\r\nzpool upgrade -V 9 fp\r\nzfs upgrade -V 3 fp\r\nzfs upgrade -V 4 fp\r\nzpool upgrade -V 15 fp\r\nzfs upgrade -V 4 fp\r\n\r\ntriggers on IllumOS, ZOL, FreeBSD and OS X.\r\n\r\nRemoving the VERIFY does technically stop it from causing a panic, and the\r\npool/dataset is upgraded, but, well, I don't know if there are side-effects\r\nfrom doing that."},"comment":{"url":"https://api.github.com/repos/openzfs/openzfs/issues/comments/153908599","html_url":"https://github.com/openzfs/openzfs/pull/17#issuecomment-153908599","issue_url":"https://api.github.com/repos/openzfs/openzfs/issues/17","id":153908599,"user":{"login":"ahrens","id":799124,"avatar_url":"https://avatars.githubusercontent.com/u/799124?v=3","gravatar_id":"","url":"https://api.github.com/users/ahrens","html_url":"https://github.com/ahrens","followers_url":"https://api.github.com/users/ahrens/followers","following_url":"https://api.github.com/users/ahrens/following{/other_user}","gists_url":"https://api.github.com/users/ahrens/gists{/gist_id}","starred_url":"https://api.github.com/users/ahrens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahrens/subscriptions","organizations_url":"https://api.github.com/users/ahrens/orgs","repos_url":"https://api.github.com/users/ahrens/repos","events_url":"https://api.github.com/users/ahrens/events{/privacy}","received_events_url":"https://api.github.com/users/ahrens/received_events","type":"User","site_admin":false},"created_at":"2015-11-04T23:56:11Z","updated_at":"2015-11-04T23:56:11Z","body":"@lundman Are you interested in implementing the fix that @scsiguy and I described?"}}