{"action":"created","comment":{"url":"https://api.github.com/repos/polydawn/repeatr/pulls/comments/26054164","id":26054164,"diff_hunk":"@@ -58,9 +15,30 @@ func (m Metadata) MarshalBinary() ([]byte, error) {\n */\n type Bucket interface {\n \tRecord(metadata Metadata, contentHash []byte)\n+\tIterator() (rootRecord RecordIterator)","path":"lib/fshash/bucket.go","position":59,"original_position":59,"commit_id":"cf8994f91e51696bfa603387419aac97a14284e0","original_commit_id":"cf8994f91e51696bfa603387419aac97a14284e0","user":{"login":"kofalt","id":265071,"avatar_url":"https://avatars.githubusercontent.com/u/265071?v=3","gravatar_id":"","url":"https://api.github.com/users/kofalt","html_url":"https://github.com/kofalt","followers_url":"https://api.github.com/users/kofalt/followers","following_url":"https://api.github.com/users/kofalt/following{/other_user}","gists_url":"https://api.github.com/users/kofalt/gists{/gist_id}","starred_url":"https://api.github.com/users/kofalt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kofalt/subscriptions","organizations_url":"https://api.github.com/users/kofalt/orgs","repos_url":"https://api.github.com/users/kofalt/repos","events_url":"https://api.github.com/users/kofalt/events{/privacy}","received_events_url":"https://api.github.com/users/kofalt/received_events","type":"User","site_admin":false},"body":"Some one-liner docstrings here would be nice, in particular clarifying (unless I misunderstand) that Iterator walks an assembled bucket for purposes of hashing after assembly.\r\n\r\nIn fact, nothing here seems to deal with the assembly of a bucket, that's punted to implementations, yes?","created_at":"2015-03-09T17:04:32Z","updated_at":"2015-03-09T17:04:32Z","html_url":"https://github.com/polydawn/repeatr/pull/11#discussion_r26054164","pull_request_url":"https://api.github.com/repos/polydawn/repeatr/pulls/11","_links":{"self":{"href":"https://api.github.com/repos/polydawn/repeatr/pulls/comments/26054164"},"html":{"href":"https://github.com/polydawn/repeatr/pull/11#discussion_r26054164"},"pull_request":{"href":"https://api.github.com/repos/polydawn/repeatr/pulls/11"}}},"pull_request":{"url":"https://api.github.com/repos/polydawn/repeatr/pulls/11","id":30736264,"html_url":"https://github.com/polydawn/repeatr/pull/11","diff_url":"https://github.com/polydawn/repeatr/pull/11.diff","patch_url":"https://github.com/polydawn/repeatr/pull/11.patch","issue_url":"https://api.github.com/repos/polydawn/repeatr/issues/11","number":11,"state":"open","locked":false,"title":"Hashing the bucket","user":{"login":"heavenlyhash","id":627638,"avatar_url":"https://avatars.githubusercontent.com/u/627638?v=3","gravatar_id":"","url":"https://api.github.com/users/heavenlyhash","html_url":"https://github.com/heavenlyhash","followers_url":"https://api.github.com/users/heavenlyhash/followers","following_url":"https://api.github.com/users/heavenlyhash/following{/other_user}","gists_url":"https://api.github.com/users/heavenlyhash/gists{/gist_id}","starred_url":"https://api.github.com/users/heavenlyhash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heavenlyhash/subscriptions","organizations_url":"https://api.github.com/users/heavenlyhash/orgs","repos_url":"https://api.github.com/users/heavenlyhash/repos","events_url":"https://api.github.com/users/heavenlyhash/events{/privacy}","received_events_url":"https://api.github.com/users/heavenlyhash/received_events","type":"User","site_admin":false},"body":"Headline: The `dir` input system is now essentially functional!\r\n\r\nFull metadata, deterministic serialization, tree hash over the whole set.  Any potentially meaningful changes result in a change in the hash.\r\n\r\nThis'll also be almost entirely reused by the tar input types momentarily, and of course all the hashing systems will also be reusable for any outputs that don't have their own built-in content-addressability.\r\n\r\nWe'll probably want to strap the fshash functions for generating this into some sort of cli \"scan\" command for getting the `Hash` of data that's being entered to the system for the first time, but details of that can be hashed out in the future.\r\n\r\n(Diff is large and there's at least one reorg commit buried in here so it may be easier to review commitwise via `git log -p`.)","created_at":"2015-03-09T04:55:19Z","updated_at":"2015-03-09T17:04:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5b45d57b249172dc7bc5a6474c80e6759b53105b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/polydawn/repeatr/pulls/11/commits","review_comments_url":"https://api.github.com/repos/polydawn/repeatr/pulls/11/comments","review_comment_url":"https://api.github.com/repos/polydawn/repeatr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/polydawn/repeatr/issues/11/comments","statuses_url":"https://api.github.com/repos/polydawn/repeatr/statuses/cf8994f91e51696bfa603387419aac97a14284e0","head":{"label":"polydawn:hashing-the-bucket","ref":"hashing-the-bucket","sha":"cf8994f91e51696bfa603387419aac97a14284e0","user":{"login":"polydawn","id":5307883,"avatar_url":"https://avatars.githubusercontent.com/u/5307883?v=3","gravatar_id":"","url":"https://api.github.com/users/polydawn","html_url":"https://github.com/polydawn","followers_url":"https://api.github.com/users/polydawn/followers","following_url":"https://api.github.com/users/polydawn/following{/other_user}","gists_url":"https://api.github.com/users/polydawn/gists{/gist_id}","starred_url":"https://api.github.com/users/polydawn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/polydawn/subscriptions","organizations_url":"https://api.github.com/users/polydawn/orgs","repos_url":"https://api.github.com/users/polydawn/repos","events_url":"https://api.github.com/users/polydawn/events{/privacy}","received_events_url":"https://api.github.com/users/polydawn/received_events","type":"Organization","site_admin":false},"repo":{"id":31432509,"name":"repeatr","full_name":"polydawn/repeatr","owner":{"login":"polydawn","id":5307883,"avatar_url":"https://avatars.githubusercontent.com/u/5307883?v=3","gravatar_id":"","url":"https://api.github.com/users/polydawn","html_url":"https://github.com/polydawn","followers_url":"https://api.github.com/users/polydawn/followers","following_url":"https://api.github.com/users/polydawn/following{/other_user}","gists_url":"https://api.github.com/users/polydawn/gists{/gist_id}","starred_url":"https://api.github.com/users/polydawn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/polydawn/subscriptions","organizations_url":"https://api.github.com/users/polydawn/orgs","repos_url":"https://api.github.com/users/polydawn/repos","events_url":"https://api.github.com/users/polydawn/events{/privacy}","received_events_url":"https://api.github.com/users/polydawn/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/polydawn/repeatr","description":"Run it. Run it again.","fork":false,"url":"https://api.github.com/repos/polydawn/repeatr","forks_url":"https://api.github.com/repos/polydawn/repeatr/forks","keys_url":"https://api.github.com/repos/polydawn/repeatr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/polydawn/repeatr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/polydawn/repeatr/teams","hooks_url":"https://api.github.com/repos/polydawn/repeatr/hooks","issue_events_url":"https://api.github.com/repos/polydawn/repeatr/issues/events{/number}","events_url":"https://api.github.com/repos/polydawn/repeatr/events","assignees_url":"https://api.github.com/repos/polydawn/repeatr/assignees{/user}","branches_url":"https://api.github.com/repos/polydawn/repeatr/branches{/branch}","tags_url":"https://api.github.com/repos/polydawn/repeatr/tags","blobs_url":"https://api.github.com/repos/polydawn/repeatr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/polydawn/repeatr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/polydawn/repeatr/git/refs{/sha}","trees_url":"https://api.github.com/repos/polydawn/repeatr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/polydawn/repeatr/statuses/{sha}","languages_url":"https://api.github.com/repos/polydawn/repeatr/languages","stargazers_url":"https://api.github.com/repos/polydawn/repeatr/stargazers","contributors_url":"https://api.github.com/repos/polydawn/repeatr/contributors","subscribers_url":"https://api.github.com/repos/polydawn/repeatr/subscribers","subscription_url":"https://api.github.com/repos/polydawn/repeatr/subscription","commits_url":"https://api.github.com/repos/polydawn/repeatr/commits{/sha}","git_commits_url":"https://api.github.com/repos/polydawn/repeatr/git/commits{/sha}","comments_url":"https://api.github.com/repos/polydawn/repeatr/comments{/number}","issue_comment_url":"https://api.github.com/repos/polydawn/repeatr/issues/comments{/number}","contents_url":"https://api.github.com/repos/polydawn/repeatr/contents/{+path}","compare_url":"https://api.github.com/repos/polydawn/repeatr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/polydawn/repeatr/merges","archive_url":"https://api.github.com/repos/polydawn/repeatr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/polydawn/repeatr/downloads","issues_url":"https://api.github.com/repos/polydawn/repeatr/issues{/number}","pulls_url":"https://api.github.com/repos/polydawn/repeatr/pulls{/number}","milestones_url":"https://api.github.com/repos/polydawn/repeatr/milestones{/number}","notifications_url":"https://api.github.com/repos/polydawn/repeatr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/polydawn/repeatr/labels{/name}","releases_url":"https://api.github.com/repos/polydawn/repeatr/releases{/id}","created_at":"2015-02-27T18:12:08Z","updated_at":"2015-03-06T21:37:13Z","pushed_at":"2015-03-09T16:04:04Z","git_url":"git://github.com/polydawn/repeatr.git","ssh_url":"git@github.com:polydawn/repeatr.git","clone_url":"https://github.com/polydawn/repeatr.git","svn_url":"https://github.com/polydawn/repeatr","homepage":null,"size":508,"stargazers_count":2,"watchers_count":2,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":2,"default_branch":"master"}},"base":{"label":"polydawn:master","ref":"master","sha":"2442129f903fd6b1092b4d46850529769cae3928","user":{"login":"polydawn","id":5307883,"avatar_url":"https://avatars.githubusercontent.com/u/5307883?v=3","gravatar_id":"","url":"https://api.github.com/users/polydawn","html_url":"https://github.com/polydawn","followers_url":"https://api.github.com/users/polydawn/followers","following_url":"https://api.github.com/users/polydawn/following{/other_user}","gists_url":"https://api.github.com/users/polydawn/gists{/gist_id}","starred_url":"https://api.github.com/users/polydawn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/polydawn/subscriptions","organizations_url":"https://api.github.com/users/polydawn/orgs","repos_url":"https://api.github.com/users/polydawn/repos","events_url":"https://api.github.com/users/polydawn/events{/privacy}","received_events_url":"https://api.github.com/users/polydawn/received_events","type":"Organization","site_admin":false},"repo":{"id":31432509,"name":"repeatr","full_name":"polydawn/repeatr","owner":{"login":"polydawn","id":5307883,"avatar_url":"https://avatars.githubusercontent.com/u/5307883?v=3","gravatar_id":"","url":"https://api.github.com/users/polydawn","html_url":"https://github.com/polydawn","followers_url":"https://api.github.com/users/polydawn/followers","following_url":"https://api.github.com/users/polydawn/following{/other_user}","gists_url":"https://api.github.com/users/polydawn/gists{/gist_id}","starred_url":"https://api.github.com/users/polydawn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/polydawn/subscriptions","organizations_url":"https://api.github.com/users/polydawn/orgs","repos_url":"https://api.github.com/users/polydawn/repos","events_url":"https://api.github.com/users/polydawn/events{/privacy}","received_events_url":"https://api.github.com/users/polydawn/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/polydawn/repeatr","description":"Run it. Run it again.","fork":false,"url":"https://api.github.com/repos/polydawn/repeatr","forks_url":"https://api.github.com/repos/polydawn/repeatr/forks","keys_url":"https://api.github.com/repos/polydawn/repeatr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/polydawn/repeatr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/polydawn/repeatr/teams","hooks_url":"https://api.github.com/repos/polydawn/repeatr/hooks","issue_events_url":"https://api.github.com/repos/polydawn/repeatr/issues/events{/number}","events_url":"https://api.github.com/repos/polydawn/repeatr/events","assignees_url":"https://api.github.com/repos/polydawn/repeatr/assignees{/user}","branches_url":"https://api.github.com/repos/polydawn/repeatr/branches{/branch}","tags_url":"https://api.github.com/repos/polydawn/repeatr/tags","blobs_url":"https://api.github.com/repos/polydawn/repeatr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/polydawn/repeatr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/polydawn/repeatr/git/refs{/sha}","trees_url":"https://api.github.com/repos/polydawn/repeatr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/polydawn/repeatr/statuses/{sha}","languages_url":"https://api.github.com/repos/polydawn/repeatr/languages","stargazers_url":"https://api.github.com/repos/polydawn/repeatr/stargazers","contributors_url":"https://api.github.com/repos/polydawn/repeatr/contributors","subscribers_url":"https://api.github.com/repos/polydawn/repeatr/subscribers","subscription_url":"https://api.github.com/repos/polydawn/repeatr/subscription","commits_url":"https://api.github.com/repos/polydawn/repeatr/commits{/sha}","git_commits_url":"https://api.github.com/repos/polydawn/repeatr/git/commits{/sha}","comments_url":"https://api.github.com/repos/polydawn/repeatr/comments{/number}","issue_comment_url":"https://api.github.com/repos/polydawn/repeatr/issues/comments{/number}","contents_url":"https://api.github.com/repos/polydawn/repeatr/contents/{+path}","compare_url":"https://api.github.com/repos/polydawn/repeatr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/polydawn/repeatr/merges","archive_url":"https://api.github.com/repos/polydawn/repeatr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/polydawn/repeatr/downloads","issues_url":"https://api.github.com/repos/polydawn/repeatr/issues{/number}","pulls_url":"https://api.github.com/repos/polydawn/repeatr/pulls{/number}","milestones_url":"https://api.github.com/repos/polydawn/repeatr/milestones{/number}","notifications_url":"https://api.github.com/repos/polydawn/repeatr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/polydawn/repeatr/labels{/name}","releases_url":"https://api.github.com/repos/polydawn/repeatr/releases{/id}","created_at":"2015-02-27T18:12:08Z","updated_at":"2015-03-06T21:37:13Z","pushed_at":"2015-03-09T16:04:04Z","git_url":"git://github.com/polydawn/repeatr.git","ssh_url":"git@github.com:polydawn/repeatr.git","clone_url":"https://github.com/polydawn/repeatr.git","svn_url":"https://github.com/polydawn/repeatr","homepage":null,"size":508,"stargazers_count":2,"watchers_count":2,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/polydawn/repeatr/pulls/11"},"html":{"href":"https://github.com/polydawn/repeatr/pull/11"},"issue":{"href":"https://api.github.com/repos/polydawn/repeatr/issues/11"},"comments":{"href":"https://api.github.com/repos/polydawn/repeatr/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/polydawn/repeatr/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/polydawn/repeatr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/polydawn/repeatr/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/polydawn/repeatr/statuses/cf8994f91e51696bfa603387419aac97a14284e0"}}}}