{"action":"created","issue":{"url":"https://api.github.com/repos/okamstudio/godot/issues/2037","labels_url":"https://api.github.com/repos/okamstudio/godot/issues/2037/labels{/name}","comments_url":"https://api.github.com/repos/okamstudio/godot/issues/2037/comments","events_url":"https://api.github.com/repos/okamstudio/godot/issues/2037/events","html_url":"https://github.com/okamstudio/godot/pull/2037","id":85689304,"number":2037,"title":"Time zone support","user":{"login":"est31","id":8872119,"avatar_url":"https://avatars.githubusercontent.com/u/8872119?v=3","gravatar_id":"","url":"https://api.github.com/users/est31","html_url":"https://github.com/est31","followers_url":"https://api.github.com/users/est31/followers","following_url":"https://api.github.com/users/est31/following{/other_user}","gists_url":"https://api.github.com/users/est31/gists{/gist_id}","starred_url":"https://api.github.com/users/est31/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/est31/subscriptions","organizations_url":"https://api.github.com/users/est31/orgs","repos_url":"https://api.github.com/users/est31/repos","events_url":"https://api.github.com/users/est31/events{/privacy}","received_events_url":"https://api.github.com/users/est31/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-06-06T03:37:22Z","updated_at":"2015-06-07T07:41:49Z","closed_at":"2015-06-07T03:32:30Z","pull_request":{"url":"https://api.github.com/repos/okamstudio/godot/pulls/2037","html_url":"https://github.com/okamstudio/godot/pull/2037","diff_url":"https://github.com/okamstudio/godot/pull/2037.diff","patch_url":"https://github.com/okamstudio/godot/pull/2037.patch"},"body":"Adds proper time zone support for the time retrieving functions.\r\nI've tested it for linux, but no other platforms. I don't even know whether it compiles for windows (don't have a win box around)."},"comment":{"url":"https://api.github.com/repos/okamstudio/godot/issues/comments/109713937","html_url":"https://github.com/okamstudio/godot/pull/2037#issuecomment-109713937","issue_url":"https://api.github.com/repos/okamstudio/godot/issues/2037","id":109713937,"user":{"login":"volzhs","id":8281454,"avatar_url":"https://avatars.githubusercontent.com/u/8281454?v=3","gravatar_id":"","url":"https://api.github.com/users/volzhs","html_url":"https://github.com/volzhs","followers_url":"https://api.github.com/users/volzhs/followers","following_url":"https://api.github.com/users/volzhs/following{/other_user}","gists_url":"https://api.github.com/users/volzhs/gists{/gist_id}","starred_url":"https://api.github.com/users/volzhs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/volzhs/subscriptions","organizations_url":"https://api.github.com/users/volzhs/orgs","repos_url":"https://api.github.com/users/volzhs/repos","events_url":"https://api.github.com/users/volzhs/events{/privacy}","received_events_url":"https://api.github.com/users/volzhs/received_events","type":"User","site_admin":false},"created_at":"2015-06-07T07:41:49Z","updated_at":"2015-06-07T07:41:49Z","body":"I have compile error to build windows tool on linux.\r\n\r\n```\r\nplatform/windows/godot_win.cpp:128:13: error: cannot declare variable 'os' to be of abstract type 'OS_Windows'\r\n  OS_Windows os(NULL);\r\n             ^\r\nIn file included from platform/windows/godot_win.cpp:29:0:\r\nplatform/windows/os_windows.h:62:7: note:   because the following virtual functions are pure within 'OS_Windows':\r\n class OS_Windows : public OS {\r\n       ^\r\nIn file included from platform/windows/os_windows.h:35:0,\r\n                 from platform/windows/godot_win.cpp:29:\r\ncore/os/os.h:255:23: note: \tvirtual OS::TimeZoneInfo OS::get_time_zone_info() const\r\n  virtual TimeZoneInfo get_time_zone_info() const=0;\r\n                       ^\r\nscons: *** [platform/windows/godot_win.windows.opt.tools.64.o] Error 1\r\nplatform/windows/os_windows.cpp:1832:10: error: prototype for 'OS::Date OS_Windows::get_date() const' does not match any in class 'OS_Windows'\r\n OS::Date OS_Windows::get_date() const {\r\n          ^\r\nIn file included from platform/windows/os_windows.cpp:31:0:\r\nplatform/windows/os_windows.h:262:15: error: candidate is: virtual OS::Date OS_Windows::get_date(bool) const\r\n  virtual Date get_date(bool utc) const;\r\n               ^\r\nplatform/windows/os_windows.cpp:1861:10: error: redefinition of 'OS::Time OS_Windows::get_time(bool) const'\r\n OS::Time OS_Windows::get_time(bool utc) const {\r\n          ^\r\nplatform/windows/os_windows.cpp:1847:10: error: 'virtual OS::Time OS_Windows::get_time(bool) const' previously defined here\r\n OS::Time OS_Windows::get_time(bool utc) const {\r\n          ^\r\nplatform/windows/os_windows.cpp:1876:51: error: no 'OS::TimeZoneInfo OS_Windows::get_time_zone_info() const' member function declared in class 'OS_Windows'\r\n OS::TimeZoneInfo OS_Windows::get_time_zone_info() const {\r\n                                                   ^\r\nplatform/windows/os_windows.cpp:1892:10: error: prototype for 'uint64_t OS_Windows::get_unix_time(bool) const' does not match any in class 'OS_Windows'\r\n uint64_t OS_Windows::get_unix_time(bool local) const {\r\n          ^\r\nIn file included from platform/windows/os_windows.cpp:31:0:\r\nplatform/windows/os_windows.h:264:19: error: candidate is: virtual uint64_t OS_Windows::get_unix_time() const\r\n  virtual uint64_t get_unix_time() const;\r\n                   ^\r\nscons: *** [platform/windows/os_windows.windows.opt.tools.64.o] Error 1\r\nscons: building terminated because of errors.\r\n```"}}