{"action":"created","issue":{"url":"https://api.github.com/repos/NOVA-Team/NOVA-Core/issues/141","labels_url":"https://api.github.com/repos/NOVA-Team/NOVA-Core/issues/141/labels{/name}","comments_url":"https://api.github.com/repos/NOVA-Team/NOVA-Core/issues/141/comments","events_url":"https://api.github.com/repos/NOVA-Team/NOVA-Core/issues/141/events","html_url":"https://github.com/NOVA-Team/NOVA-Core/issues/141","id":97102892,"number":141,"title":"Mod initialization functions","user":{"login":"copygirl","id":272586,"avatar_url":"https://avatars.githubusercontent.com/u/272586?v=3","gravatar_id":"","url":"https://api.github.com/users/copygirl","html_url":"https://github.com/copygirl","followers_url":"https://api.github.com/users/copygirl/followers","following_url":"https://api.github.com/users/copygirl/following{/other_user}","gists_url":"https://api.github.com/users/copygirl/gists{/gist_id}","starred_url":"https://api.github.com/users/copygirl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/copygirl/subscriptions","organizations_url":"https://api.github.com/users/copygirl/orgs","repos_url":"https://api.github.com/users/copygirl/repos","events_url":"https://api.github.com/users/copygirl/events{/privacy}","received_events_url":"https://api.github.com/users/copygirl/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/NOVA-Team/NOVA-Core/labels/enhancement","name":"enhancement","color":"84b6eb"},{"url":"https://api.github.com/repos/NOVA-Team/NOVA-Core/labels/ready","name":"ready","color":"bfe5bf"}],"state":"open","locked":false,"assignee":{"login":"calclavia","id":1828968,"avatar_url":"https://avatars.githubusercontent.com/u/1828968?v=3","gravatar_id":"","url":"https://api.github.com/users/calclavia","html_url":"https://github.com/calclavia","followers_url":"https://api.github.com/users/calclavia/followers","following_url":"https://api.github.com/users/calclavia/following{/other_user}","gists_url":"https://api.github.com/users/calclavia/gists{/gist_id}","starred_url":"https://api.github.com/users/calclavia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calclavia/subscriptions","organizations_url":"https://api.github.com/users/calclavia/orgs","repos_url":"https://api.github.com/users/calclavia/repos","events_url":"https://api.github.com/users/calclavia/events{/privacy}","received_events_url":"https://api.github.com/users/calclavia/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/NOVA-Team/NOVA-Core/milestones/2","html_url":"https://github.com/NOVA-Team/NOVA-Core/milestones/v0.1.0","labels_url":"https://api.github.com/repos/NOVA-Team/NOVA-Core/milestones/2/labels","id":1226450,"number":2,"title":"v0.1.0","description":"","creator":{"login":"RX14","id":2788811,"avatar_url":"https://avatars.githubusercontent.com/u/2788811?v=3","gravatar_id":"","url":"https://api.github.com/users/RX14","html_url":"https://github.com/RX14","followers_url":"https://api.github.com/users/RX14/followers","following_url":"https://api.github.com/users/RX14/following{/other_user}","gists_url":"https://api.github.com/users/RX14/gists{/gist_id}","starred_url":"https://api.github.com/users/RX14/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RX14/subscriptions","organizations_url":"https://api.github.com/users/RX14/orgs","repos_url":"https://api.github.com/users/RX14/repos","events_url":"https://api.github.com/users/RX14/events{/privacy}","received_events_url":"https://api.github.com/users/RX14/received_events","type":"User","site_admin":false},"open_issues":12,"closed_issues":3,"state":"open","created_at":"2015-07-26T19:39:55Z","updated_at":"2015-07-29T15:20:27Z","due_on":"2015-08-02T04:00:00Z","closed_at":null},"comments":37,"created_at":"2015-07-24T17:49:46Z","updated_at":"2015-07-30T17:36:30Z","closed_at":null,"body":"Looking at the example code.\r\n\r\n> Any class which implements Loadable has three methods, `preInit()`, `init()`, and `postInit()`.\r\n\r\nI think this is a bad design choice for a couple of reasons:\r\n\r\n- Seems to just be copied from Minecraft Forge\r\n- Undescriptive of what's supposed to go where\r\n- Why allow doing the same thing in different places (block initialization in preInit or init?)\r\n- Unknown state of other mods at different points (recipes added in init or postInit?)\r\n- What would need to go into initialization code that couldn't be automated?\r\n\r\nThere should either be methods for handling specific initialization code (config, blocks, items, recipes, ...) or even have it done automatically using reflection, and let the wrapper decide the proper time to do everything."},"comment":{"url":"https://api.github.com/repos/NOVA-Team/NOVA-Core/issues/comments/126412937","html_url":"https://github.com/NOVA-Team/NOVA-Core/issues/141#issuecomment-126412937","issue_url":"https://api.github.com/repos/NOVA-Team/NOVA-Core/issues/141","id":126412937,"user":{"login":"Victorious3","id":3749322,"avatar_url":"https://avatars.githubusercontent.com/u/3749322?v=3","gravatar_id":"","url":"https://api.github.com/users/Victorious3","html_url":"https://github.com/Victorious3","followers_url":"https://api.github.com/users/Victorious3/followers","following_url":"https://api.github.com/users/Victorious3/following{/other_user}","gists_url":"https://api.github.com/users/Victorious3/gists{/gist_id}","starred_url":"https://api.github.com/users/Victorious3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Victorious3/subscriptions","organizations_url":"https://api.github.com/users/Victorious3/orgs","repos_url":"https://api.github.com/users/Victorious3/repos","events_url":"https://api.github.com/users/Victorious3/events{/privacy}","received_events_url":"https://api.github.com/users/Victorious3/received_events","type":"User","site_admin":false},"created_at":"2015-07-30T17:36:30Z","updated_at":"2015-07-30T17:36:30Z","body":"@RX14 What would you need callbacks for? If you want to undo a mod's registration just hook behind it."}}