{"action":"created","comment":{"url":"https://api.github.com/repos/filipegoncalves/rust-config/pulls/comments/42936846","id":42936846,"diff_hunk":"@@ -127,7 +127,7 @@ pub fn from_file(path: &Path) -> Result<Config, ConfigError> {\n /// use config::reader::from_str;\n /// use config::error::ConfigErrorKind;\n ///\n-/// let parsed = from_str(\"windows=NO\\n\");\n+/// let parsed = from_str(\"windows=NO SPACE\\n\");","path":"src/reader.rs","position":14,"original_position":14,"commit_id":"433cbdb2dc2db6fb7abb18aa7e1fdb8ff2a5b1a3","original_commit_id":"433cbdb2dc2db6fb7abb18aa7e1fdb8ff2a5b1a3","user":{"login":"filipegoncalves","id":1469447,"avatar_url":"https://avatars.githubusercontent.com/u/1469447?v=3","gravatar_id":"","url":"https://api.github.com/users/filipegoncalves","html_url":"https://github.com/filipegoncalves","followers_url":"https://api.github.com/users/filipegoncalves/followers","following_url":"https://api.github.com/users/filipegoncalves/following{/other_user}","gists_url":"https://api.github.com/users/filipegoncalves/gists{/gist_id}","starred_url":"https://api.github.com/users/filipegoncalves/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/filipegoncalves/subscriptions","organizations_url":"https://api.github.com/users/filipegoncalves/orgs","repos_url":"https://api.github.com/users/filipegoncalves/repos","events_url":"https://api.github.com/users/filipegoncalves/events{/privacy}","received_events_url":"https://api.github.com/users/filipegoncalves/received_events","type":"User","site_admin":false},"body":"I understand that with this patch `windows=NO\\n` is a valid line and as such it breaks the example. But replacing it with `windows=NO SPACE` seems a bit misleading to me, maybe we should find a better example? I think this would make the reader confused, don't you agree?\r\n","created_at":"2015-10-24T18:36:37Z","updated_at":"2015-10-24T18:36:37Z","html_url":"https://github.com/filipegoncalves/rust-config/pull/7#discussion_r42936846","pull_request_url":"https://api.github.com/repos/filipegoncalves/rust-config/pulls/7","_links":{"self":{"href":"https://api.github.com/repos/filipegoncalves/rust-config/pulls/comments/42936846"},"html":{"href":"https://github.com/filipegoncalves/rust-config/pull/7#discussion_r42936846"},"pull_request":{"href":"https://api.github.com/repos/filipegoncalves/rust-config/pulls/7"}}},"pull_request":{"url":"https://api.github.com/repos/filipegoncalves/rust-config/pulls/7","id":48569170,"html_url":"https://github.com/filipegoncalves/rust-config/pull/7","diff_url":"https://github.com/filipegoncalves/rust-config/pull/7.diff","patch_url":"https://github.com/filipegoncalves/rust-config/pull/7.patch","issue_url":"https://api.github.com/repos/filipegoncalves/rust-config/issues/7","number":7,"state":"open","locked":false,"title":"Allow comma and space delimited values","user":{"login":"scowcron","id":712068,"avatar_url":"https://avatars.githubusercontent.com/u/712068?v=3","gravatar_id":"","url":"https://api.github.com/users/scowcron","html_url":"https://github.com/scowcron","followers_url":"https://api.github.com/users/scowcron/followers","following_url":"https://api.github.com/users/scowcron/following{/other_user}","gists_url":"https://api.github.com/users/scowcron/gists{/gist_id}","starred_url":"https://api.github.com/users/scowcron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scowcron/subscriptions","organizations_url":"https://api.github.com/users/scowcron/orgs","repos_url":"https://api.github.com/users/scowcron/repos","events_url":"https://api.github.com/users/scowcron/events{/privacy}","received_events_url":"https://api.github.com/users/scowcron/received_events","type":"User","site_admin":false},"body":"According to the libconfig grammar, comma and space are valid\r\nseparators for settings as well as semicolons. Allow them.\r\n\r\nsetting = name (\":\" | \"=\") value (\";\" | \",\" | empty)","created_at":"2015-10-23T11:27:47Z","updated_at":"2015-10-24T18:36:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f587631121cff0231119a71cbb010e3d19915b88","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/filipegoncalves/rust-config/pulls/7/commits","review_comments_url":"https://api.github.com/repos/filipegoncalves/rust-config/pulls/7/comments","review_comment_url":"https://api.github.com/repos/filipegoncalves/rust-config/pulls/comments{/number}","comments_url":"https://api.github.com/repos/filipegoncalves/rust-config/issues/7/comments","statuses_url":"https://api.github.com/repos/filipegoncalves/rust-config/statuses/433cbdb2dc2db6fb7abb18aa7e1fdb8ff2a5b1a3","head":{"label":"scowcron:master","ref":"master","sha":"433cbdb2dc2db6fb7abb18aa7e1fdb8ff2a5b1a3","user":{"login":"scowcron","id":712068,"avatar_url":"https://avatars.githubusercontent.com/u/712068?v=3","gravatar_id":"","url":"https://api.github.com/users/scowcron","html_url":"https://github.com/scowcron","followers_url":"https://api.github.com/users/scowcron/followers","following_url":"https://api.github.com/users/scowcron/following{/other_user}","gists_url":"https://api.github.com/users/scowcron/gists{/gist_id}","starred_url":"https://api.github.com/users/scowcron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scowcron/subscriptions","organizations_url":"https://api.github.com/users/scowcron/orgs","repos_url":"https://api.github.com/users/scowcron/repos","events_url":"https://api.github.com/users/scowcron/events{/privacy}","received_events_url":"https://api.github.com/users/scowcron/received_events","type":"User","site_admin":false},"repo":{"id":44807457,"name":"rust-config","full_name":"scowcron/rust-config","owner":{"login":"scowcron","id":712068,"avatar_url":"https://avatars.githubusercontent.com/u/712068?v=3","gravatar_id":"","url":"https://api.github.com/users/scowcron","html_url":"https://github.com/scowcron","followers_url":"https://api.github.com/users/scowcron/followers","following_url":"https://api.github.com/users/scowcron/following{/other_user}","gists_url":"https://api.github.com/users/scowcron/gists{/gist_id}","starred_url":"https://api.github.com/users/scowcron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scowcron/subscriptions","organizations_url":"https://api.github.com/users/scowcron/orgs","repos_url":"https://api.github.com/users/scowcron/repos","events_url":"https://api.github.com/users/scowcron/events{/privacy}","received_events_url":"https://api.github.com/users/scowcron/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/scowcron/rust-config","description":"Configuration file library in Rust similar to C/C++'s libconfig","fork":true,"url":"https://api.github.com/repos/scowcron/rust-config","forks_url":"https://api.github.com/repos/scowcron/rust-config/forks","keys_url":"https://api.github.com/repos/scowcron/rust-config/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scowcron/rust-config/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scowcron/rust-config/teams","hooks_url":"https://api.github.com/repos/scowcron/rust-config/hooks","issue_events_url":"https://api.github.com/repos/scowcron/rust-config/issues/events{/number}","events_url":"https://api.github.com/repos/scowcron/rust-config/events","assignees_url":"https://api.github.com/repos/scowcron/rust-config/assignees{/user}","branches_url":"https://api.github.com/repos/scowcron/rust-config/branches{/branch}","tags_url":"https://api.github.com/repos/scowcron/rust-config/tags","blobs_url":"https://api.github.com/repos/scowcron/rust-config/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scowcron/rust-config/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scowcron/rust-config/git/refs{/sha}","trees_url":"https://api.github.com/repos/scowcron/rust-config/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scowcron/rust-config/statuses/{sha}","languages_url":"https://api.github.com/repos/scowcron/rust-config/languages","stargazers_url":"https://api.github.com/repos/scowcron/rust-config/stargazers","contributors_url":"https://api.github.com/repos/scowcron/rust-config/contributors","subscribers_url":"https://api.github.com/repos/scowcron/rust-config/subscribers","subscription_url":"https://api.github.com/repos/scowcron/rust-config/subscription","commits_url":"https://api.github.com/repos/scowcron/rust-config/commits{/sha}","git_commits_url":"https://api.github.com/repos/scowcron/rust-config/git/commits{/sha}","comments_url":"https://api.github.com/repos/scowcron/rust-config/comments{/number}","issue_comment_url":"https://api.github.com/repos/scowcron/rust-config/issues/comments{/number}","contents_url":"https://api.github.com/repos/scowcron/rust-config/contents/{+path}","compare_url":"https://api.github.com/repos/scowcron/rust-config/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scowcron/rust-config/merges","archive_url":"https://api.github.com/repos/scowcron/rust-config/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scowcron/rust-config/downloads","issues_url":"https://api.github.com/repos/scowcron/rust-config/issues{/number}","pulls_url":"https://api.github.com/repos/scowcron/rust-config/pulls{/number}","milestones_url":"https://api.github.com/repos/scowcron/rust-config/milestones{/number}","notifications_url":"https://api.github.com/repos/scowcron/rust-config/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scowcron/rust-config/labels{/name}","releases_url":"https://api.github.com/repos/scowcron/rust-config/releases{/id}","created_at":"2015-10-23T10:52:40Z","updated_at":"2015-10-23T10:52:41Z","pushed_at":"2015-10-23T11:21:51Z","git_url":"git://github.com/scowcron/rust-config.git","ssh_url":"git@github.com:scowcron/rust-config.git","clone_url":"https://github.com/scowcron/rust-config.git","svn_url":"https://github.com/scowcron/rust-config","homepage":"","size":976,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"filipegoncalves:master","ref":"master","sha":"7cf993255405c08bc186c7b6e3ed20dcc6158344","user":{"login":"filipegoncalves","id":1469447,"avatar_url":"https://avatars.githubusercontent.com/u/1469447?v=3","gravatar_id":"","url":"https://api.github.com/users/filipegoncalves","html_url":"https://github.com/filipegoncalves","followers_url":"https://api.github.com/users/filipegoncalves/followers","following_url":"https://api.github.com/users/filipegoncalves/following{/other_user}","gists_url":"https://api.github.com/users/filipegoncalves/gists{/gist_id}","starred_url":"https://api.github.com/users/filipegoncalves/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/filipegoncalves/subscriptions","organizations_url":"https://api.github.com/users/filipegoncalves/orgs","repos_url":"https://api.github.com/users/filipegoncalves/repos","events_url":"https://api.github.com/users/filipegoncalves/events{/privacy}","received_events_url":"https://api.github.com/users/filipegoncalves/received_events","type":"User","site_admin":false},"repo":{"id":32944406,"name":"rust-config","full_name":"filipegoncalves/rust-config","owner":{"login":"filipegoncalves","id":1469447,"avatar_url":"https://avatars.githubusercontent.com/u/1469447?v=3","gravatar_id":"","url":"https://api.github.com/users/filipegoncalves","html_url":"https://github.com/filipegoncalves","followers_url":"https://api.github.com/users/filipegoncalves/followers","following_url":"https://api.github.com/users/filipegoncalves/following{/other_user}","gists_url":"https://api.github.com/users/filipegoncalves/gists{/gist_id}","starred_url":"https://api.github.com/users/filipegoncalves/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/filipegoncalves/subscriptions","organizations_url":"https://api.github.com/users/filipegoncalves/orgs","repos_url":"https://api.github.com/users/filipegoncalves/repos","events_url":"https://api.github.com/users/filipegoncalves/events{/privacy}","received_events_url":"https://api.github.com/users/filipegoncalves/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/filipegoncalves/rust-config","description":"Configuration file library in Rust similar to C/C++'s libconfig","fork":false,"url":"https://api.github.com/repos/filipegoncalves/rust-config","forks_url":"https://api.github.com/repos/filipegoncalves/rust-config/forks","keys_url":"https://api.github.com/repos/filipegoncalves/rust-config/keys{/key_id}","collaborators_url":"https://api.github.com/repos/filipegoncalves/rust-config/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/filipegoncalves/rust-config/teams","hooks_url":"https://api.github.com/repos/filipegoncalves/rust-config/hooks","issue_events_url":"https://api.github.com/repos/filipegoncalves/rust-config/issues/events{/number}","events_url":"https://api.github.com/repos/filipegoncalves/rust-config/events","assignees_url":"https://api.github.com/repos/filipegoncalves/rust-config/assignees{/user}","branches_url":"https://api.github.com/repos/filipegoncalves/rust-config/branches{/branch}","tags_url":"https://api.github.com/repos/filipegoncalves/rust-config/tags","blobs_url":"https://api.github.com/repos/filipegoncalves/rust-config/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/filipegoncalves/rust-config/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/filipegoncalves/rust-config/git/refs{/sha}","trees_url":"https://api.github.com/repos/filipegoncalves/rust-config/git/trees{/sha}","statuses_url":"https://api.github.com/repos/filipegoncalves/rust-config/statuses/{sha}","languages_url":"https://api.github.com/repos/filipegoncalves/rust-config/languages","stargazers_url":"https://api.github.com/repos/filipegoncalves/rust-config/stargazers","contributors_url":"https://api.github.com/repos/filipegoncalves/rust-config/contributors","subscribers_url":"https://api.github.com/repos/filipegoncalves/rust-config/subscribers","subscription_url":"https://api.github.com/repos/filipegoncalves/rust-config/subscription","commits_url":"https://api.github.com/repos/filipegoncalves/rust-config/commits{/sha}","git_commits_url":"https://api.github.com/repos/filipegoncalves/rust-config/git/commits{/sha}","comments_url":"https://api.github.com/repos/filipegoncalves/rust-config/comments{/number}","issue_comment_url":"https://api.github.com/repos/filipegoncalves/rust-config/issues/comments{/number}","contents_url":"https://api.github.com/repos/filipegoncalves/rust-config/contents/{+path}","compare_url":"https://api.github.com/repos/filipegoncalves/rust-config/compare/{base}...{head}","merges_url":"https://api.github.com/repos/filipegoncalves/rust-config/merges","archive_url":"https://api.github.com/repos/filipegoncalves/rust-config/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/filipegoncalves/rust-config/downloads","issues_url":"https://api.github.com/repos/filipegoncalves/rust-config/issues{/number}","pulls_url":"https://api.github.com/repos/filipegoncalves/rust-config/pulls{/number}","milestones_url":"https://api.github.com/repos/filipegoncalves/rust-config/milestones{/number}","notifications_url":"https://api.github.com/repos/filipegoncalves/rust-config/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/filipegoncalves/rust-config/labels{/name}","releases_url":"https://api.github.com/repos/filipegoncalves/rust-config/releases{/id}","created_at":"2015-03-26T18:18:54Z","updated_at":"2015-10-13T04:27:45Z","pushed_at":"2015-10-23T11:27:47Z","git_url":"git://github.com/filipegoncalves/rust-config.git","ssh_url":"git@github.com:filipegoncalves/rust-config.git","clone_url":"https://github.com/filipegoncalves/rust-config.git","svn_url":"https://github.com/filipegoncalves/rust-config","homepage":"","size":1128,"stargazers_count":3,"watchers_count":3,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"open_issues_count":1,"forks":3,"open_issues":1,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/filipegoncalves/rust-config/pulls/7"},"html":{"href":"https://github.com/filipegoncalves/rust-config/pull/7"},"issue":{"href":"https://api.github.com/repos/filipegoncalves/rust-config/issues/7"},"comments":{"href":"https://api.github.com/repos/filipegoncalves/rust-config/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/filipegoncalves/rust-config/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/filipegoncalves/rust-config/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/filipegoncalves/rust-config/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/filipegoncalves/rust-config/statuses/433cbdb2dc2db6fb7abb18aa7e1fdb8ff2a5b1a3"}}}}