{"action":"created","issue":{"url":"https://api.github.com/repos/rspec/rspec-core/issues/2065","labels_url":"https://api.github.com/repos/rspec/rspec-core/issues/2065/labels{/name}","comments_url":"https://api.github.com/repos/rspec/rspec-core/issues/2065/comments","events_url":"https://api.github.com/repos/rspec/rspec-core/issues/2065/events","html_url":"https://github.com/rspec/rspec-core/pull/2065","id":102511483,"number":2065,"title":"WIP/RFC - Configurable fail fast","user":{"login":"jackscotti","id":5038475,"avatar_url":"https://avatars.githubusercontent.com/u/5038475?v=3","gravatar_id":"","url":"https://api.github.com/users/jackscotti","html_url":"https://github.com/jackscotti","followers_url":"https://api.github.com/users/jackscotti/followers","following_url":"https://api.github.com/users/jackscotti/following{/other_user}","gists_url":"https://api.github.com/users/jackscotti/gists{/gist_id}","starred_url":"https://api.github.com/users/jackscotti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackscotti/subscriptions","organizations_url":"https://api.github.com/users/jackscotti/orgs","repos_url":"https://api.github.com/users/jackscotti/repos","events_url":"https://api.github.com/users/jackscotti/events{/privacy}","received_events_url":"https://api.github.com/users/jackscotti/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":14,"created_at":"2015-08-22T07:33:07Z","updated_at":"2015-10-08T23:13:37Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/rspec/rspec-core/pulls/2065","html_url":"https://github.com/rspec/rspec-core/pull/2065","diff_url":"https://github.com/rspec/rspec-core/pull/2065.diff","patch_url":"https://github.com/rspec/rspec-core/pull/2065.patch"},"body":"After spending a long time on this, I decided to open a WIP pull request to ask for some feedback/advice.\r\n\r\nThe aim of this PR is making `fail-fast` configurable, as per requested here: https://github.com/rspec/rspec-core/issues/1874\r\n\r\nNotes:\r\n- ~~The first commit has been added only for silencing failures locally and to add a debugging gem, I will delete it. I had the failures only locally, this commit will make your CI unhappy because it renames some methods.~~ [Updated and removed]\r\n- I will reword/squash the commits where appropriate\r\n- I had not manage to make the parser happy with a space character between `fail-fast` and the parameter. I had to add a \"=\". Is that alright?\r\n- The last commit has been added for making Rubocop happy (by extracting the fail-fast logic into its own class). It made things better but it is still not enough:\r\n\r\n<img width=\"835\" alt=\"screen shot 2015-08-22 at 08 15 03\" src=\"https://cloud.githubusercontent.com/assets/5038475/9423002/3c300620-48a7-11e5-83a4-1b40c54c1a2a.png\">\r\n\r\nThe 4 extra lines could be removed by removing the getter I've created at line 554 in `lib/rspec/core/example_group.rb`. The only reason I've done this it's because I did not know how to test that everything worked in `example_group` without having a method to mock in `example_group_spec`.\r\n\r\nAdding a new class also required me to import it from `lib/rspec/core.rb`. Is this alright?"},"comment":{"url":"https://api.github.com/repos/rspec/rspec-core/issues/comments/146713241","html_url":"https://github.com/rspec/rspec-core/pull/2065#issuecomment-146713241","issue_url":"https://api.github.com/repos/rspec/rspec-core/issues/2065","id":146713241,"user":{"login":"JonRowe","id":162976,"avatar_url":"https://avatars.githubusercontent.com/u/162976?v=3","gravatar_id":"","url":"https://api.github.com/users/JonRowe","html_url":"https://github.com/JonRowe","followers_url":"https://api.github.com/users/JonRowe/followers","following_url":"https://api.github.com/users/JonRowe/following{/other_user}","gists_url":"https://api.github.com/users/JonRowe/gists{/gist_id}","starred_url":"https://api.github.com/users/JonRowe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JonRowe/subscriptions","organizations_url":"https://api.github.com/users/JonRowe/orgs","repos_url":"https://api.github.com/users/JonRowe/repos","events_url":"https://api.github.com/users/JonRowe/events{/privacy}","received_events_url":"https://api.github.com/users/JonRowe/received_events","type":"User","site_admin":false},"created_at":"2015-10-08T23:13:37Z","updated_at":"2015-10-08T23:13:37Z","body":">To note that if I address @JonRowe comment about removing self. the warnings come back.\r\n\r\n>This PR is now ready for review, I will squash/rename/reword the commits ASAP. \r\n\r\nJust a few final tweaks, and yep if you could squash the commits that'd be great :)"}}