{"action":"created","comment":{"url":"https://api.github.com/repos/netty/netty/pulls/comments/40247025","id":40247025,"diff_hunk":"@@ -1,5 +1,5 @@\n /*\n- * Copyright 2014 The Netty Project\n+ * Copyright 2015 The Netty Project","path":"codec-http/src/main/java/io/netty/handler/codec/rtsp/RtspHeaderValues.java","position":3,"original_position":3,"commit_id":"56887d953177cfe05b6ac3ad25a2ff0878c42ba2","original_commit_id":"56887d953177cfe05b6ac3ad25a2ff0878c42ba2","user":{"login":"normanmaurer","id":439362,"avatar_url":"https://avatars.githubusercontent.com/u/439362?v=3","gravatar_id":"","url":"https://api.github.com/users/normanmaurer","html_url":"https://github.com/normanmaurer","followers_url":"https://api.github.com/users/normanmaurer/followers","following_url":"https://api.github.com/users/normanmaurer/following{/other_user}","gists_url":"https://api.github.com/users/normanmaurer/gists{/gist_id}","starred_url":"https://api.github.com/users/normanmaurer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/normanmaurer/subscriptions","organizations_url":"https://api.github.com/users/normanmaurer/orgs","repos_url":"https://api.github.com/users/normanmaurer/repos","events_url":"https://api.github.com/users/normanmaurer/events{/privacy}","received_events_url":"https://api.github.com/users/normanmaurer/received_events","type":"User","site_admin":false},"body":"revert","created_at":"2015-09-23T19:33:52Z","updated_at":"2015-09-23T19:33:52Z","html_url":"https://github.com/netty/netty/pull/4243#discussion_r40247025","pull_request_url":"https://api.github.com/repos/netty/netty/pulls/4243","_links":{"self":{"href":"https://api.github.com/repos/netty/netty/pulls/comments/40247025"},"html":{"href":"https://github.com/netty/netty/pull/4243#discussion_r40247025"},"pull_request":{"href":"https://api.github.com/repos/netty/netty/pulls/4243"}}},"pull_request":{"url":"https://api.github.com/repos/netty/netty/pulls/4243","id":45504080,"html_url":"https://github.com/netty/netty/pull/4243","diff_url":"https://github.com/netty/netty/pull/4243.diff","patch_url":"https://github.com/netty/netty/pull/4243.patch","issue_url":"https://api.github.com/repos/netty/netty/issues/4243","number":4243,"state":"open","locked":false,"title":"Fix for RTSP protocol encoding and ecoding","user":{"login":"sverkera","id":347473,"avatar_url":"https://avatars.githubusercontent.com/u/347473?v=3","gravatar_id":"","url":"https://api.github.com/users/sverkera","html_url":"https://github.com/sverkera","followers_url":"https://api.github.com/users/sverkera/followers","following_url":"https://api.github.com/users/sverkera/following{/other_user}","gists_url":"https://api.github.com/users/sverkera/gists{/gist_id}","starred_url":"https://api.github.com/users/sverkera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sverkera/subscriptions","organizations_url":"https://api.github.com/users/sverkera/orgs","repos_url":"https://api.github.com/users/sverkera/repos","events_url":"https://api.github.com/users/sverkera/events{/privacy}","received_events_url":"https://api.github.com/users/sverkera/received_events","type":"User","site_admin":false},"body":"The RTSP protocol isn't strict that only client issues requests and server gives responses, like http protocol. Specifically the server side of a connection may isssue an ANNOUNCE request to the client, which cased the RTSP decoder to go out of sync and fail to decode any more request/responses from the other side.\r\n\r\nTo solve that issue I've made RtspEncoder and RtspDecoder generic so that they can handle both requests and responses. For compatibility the previous classes RtspRequestEncoder and RtspResponseEncoder now just extends RtspEncoder but are deprecated, likewise for RtspRequestDecoder and RtspResponseDecoder which now extends RtspDecoder.\r\n\r\nIn RtspDecoderTest there is that specific use case which previously were failing where first an ANNOUNCE request was received and then any other response which made the decoder go out of sync but is now working fine. ","created_at":"2015-09-20T21:03:31Z","updated_at":"2015-09-23T19:33:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e33773f2894f4e1e7ed8800db82fde5327a48e78","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/netty/netty/pulls/4243/commits","review_comments_url":"https://api.github.com/repos/netty/netty/pulls/4243/comments","review_comment_url":"https://api.github.com/repos/netty/netty/pulls/comments{/number}","comments_url":"https://api.github.com/repos/netty/netty/issues/4243/comments","statuses_url":"https://api.github.com/repos/netty/netty/statuses/56887d953177cfe05b6ac3ad25a2ff0878c42ba2","head":{"label":"sverkera:4.1","ref":"4.1","sha":"56887d953177cfe05b6ac3ad25a2ff0878c42ba2","user":{"login":"sverkera","id":347473,"avatar_url":"https://avatars.githubusercontent.com/u/347473?v=3","gravatar_id":"","url":"https://api.github.com/users/sverkera","html_url":"https://github.com/sverkera","followers_url":"https://api.github.com/users/sverkera/followers","following_url":"https://api.github.com/users/sverkera/following{/other_user}","gists_url":"https://api.github.com/users/sverkera/gists{/gist_id}","starred_url":"https://api.github.com/users/sverkera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sverkera/subscriptions","organizations_url":"https://api.github.com/users/sverkera/orgs","repos_url":"https://api.github.com/users/sverkera/repos","events_url":"https://api.github.com/users/sverkera/events{/privacy}","received_events_url":"https://api.github.com/users/sverkera/received_events","type":"User","site_admin":false},"repo":{"id":42751647,"name":"netty","full_name":"sverkera/netty","owner":{"login":"sverkera","id":347473,"avatar_url":"https://avatars.githubusercontent.com/u/347473?v=3","gravatar_id":"","url":"https://api.github.com/users/sverkera","html_url":"https://github.com/sverkera","followers_url":"https://api.github.com/users/sverkera/followers","following_url":"https://api.github.com/users/sverkera/following{/other_user}","gists_url":"https://api.github.com/users/sverkera/gists{/gist_id}","starred_url":"https://api.github.com/users/sverkera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sverkera/subscriptions","organizations_url":"https://api.github.com/users/sverkera/orgs","repos_url":"https://api.github.com/users/sverkera/repos","events_url":"https://api.github.com/users/sverkera/events{/privacy}","received_events_url":"https://api.github.com/users/sverkera/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sverkera/netty","description":"Netty project - an event-driven asynchronous network application framework","fork":true,"url":"https://api.github.com/repos/sverkera/netty","forks_url":"https://api.github.com/repos/sverkera/netty/forks","keys_url":"https://api.github.com/repos/sverkera/netty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sverkera/netty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sverkera/netty/teams","hooks_url":"https://api.github.com/repos/sverkera/netty/hooks","issue_events_url":"https://api.github.com/repos/sverkera/netty/issues/events{/number}","events_url":"https://api.github.com/repos/sverkera/netty/events","assignees_url":"https://api.github.com/repos/sverkera/netty/assignees{/user}","branches_url":"https://api.github.com/repos/sverkera/netty/branches{/branch}","tags_url":"https://api.github.com/repos/sverkera/netty/tags","blobs_url":"https://api.github.com/repos/sverkera/netty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sverkera/netty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sverkera/netty/git/refs{/sha}","trees_url":"https://api.github.com/repos/sverkera/netty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sverkera/netty/statuses/{sha}","languages_url":"https://api.github.com/repos/sverkera/netty/languages","stargazers_url":"https://api.github.com/repos/sverkera/netty/stargazers","contributors_url":"https://api.github.com/repos/sverkera/netty/contributors","subscribers_url":"https://api.github.com/repos/sverkera/netty/subscribers","subscription_url":"https://api.github.com/repos/sverkera/netty/subscription","commits_url":"https://api.github.com/repos/sverkera/netty/commits{/sha}","git_commits_url":"https://api.github.com/repos/sverkera/netty/git/commits{/sha}","comments_url":"https://api.github.com/repos/sverkera/netty/comments{/number}","issue_comment_url":"https://api.github.com/repos/sverkera/netty/issues/comments{/number}","contents_url":"https://api.github.com/repos/sverkera/netty/contents/{+path}","compare_url":"https://api.github.com/repos/sverkera/netty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sverkera/netty/merges","archive_url":"https://api.github.com/repos/sverkera/netty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sverkera/netty/downloads","issues_url":"https://api.github.com/repos/sverkera/netty/issues{/number}","pulls_url":"https://api.github.com/repos/sverkera/netty/pulls{/number}","milestones_url":"https://api.github.com/repos/sverkera/netty/milestones{/number}","notifications_url":"https://api.github.com/repos/sverkera/netty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sverkera/netty/labels{/name}","releases_url":"https://api.github.com/repos/sverkera/netty/releases{/id}","created_at":"2015-09-18T23:28:33Z","updated_at":"2015-09-18T23:28:41Z","pushed_at":"2015-09-23T07:29:57Z","git_url":"git://github.com/sverkera/netty.git","ssh_url":"git@github.com:sverkera/netty.git","clone_url":"https://github.com/sverkera/netty.git","svn_url":"https://github.com/sverkera/netty","homepage":"http://netty.io/","size":45071,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"netty:4.1","ref":"4.1","sha":"a1d0207ec52639f3ce65801a869565af53d19731","user":{"login":"netty","id":473791,"avatar_url":"https://avatars.githubusercontent.com/u/473791?v=3","gravatar_id":"","url":"https://api.github.com/users/netty","html_url":"https://github.com/netty","followers_url":"https://api.github.com/users/netty/followers","following_url":"https://api.github.com/users/netty/following{/other_user}","gists_url":"https://api.github.com/users/netty/gists{/gist_id}","starred_url":"https://api.github.com/users/netty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netty/subscriptions","organizations_url":"https://api.github.com/users/netty/orgs","repos_url":"https://api.github.com/users/netty/repos","events_url":"https://api.github.com/users/netty/events{/privacy}","received_events_url":"https://api.github.com/users/netty/received_events","type":"Organization","site_admin":false},"repo":{"id":1064563,"name":"netty","full_name":"netty/netty","owner":{"login":"netty","id":473791,"avatar_url":"https://avatars.githubusercontent.com/u/473791?v=3","gravatar_id":"","url":"https://api.github.com/users/netty","html_url":"https://github.com/netty","followers_url":"https://api.github.com/users/netty/followers","following_url":"https://api.github.com/users/netty/following{/other_user}","gists_url":"https://api.github.com/users/netty/gists{/gist_id}","starred_url":"https://api.github.com/users/netty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netty/subscriptions","organizations_url":"https://api.github.com/users/netty/orgs","repos_url":"https://api.github.com/users/netty/repos","events_url":"https://api.github.com/users/netty/events{/privacy}","received_events_url":"https://api.github.com/users/netty/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/netty/netty","description":"Netty project - an event-driven asynchronous network application framework","fork":false,"url":"https://api.github.com/repos/netty/netty","forks_url":"https://api.github.com/repos/netty/netty/forks","keys_url":"https://api.github.com/repos/netty/netty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/netty/netty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/netty/netty/teams","hooks_url":"https://api.github.com/repos/netty/netty/hooks","issue_events_url":"https://api.github.com/repos/netty/netty/issues/events{/number}","events_url":"https://api.github.com/repos/netty/netty/events","assignees_url":"https://api.github.com/repos/netty/netty/assignees{/user}","branches_url":"https://api.github.com/repos/netty/netty/branches{/branch}","tags_url":"https://api.github.com/repos/netty/netty/tags","blobs_url":"https://api.github.com/repos/netty/netty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/netty/netty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/netty/netty/git/refs{/sha}","trees_url":"https://api.github.com/repos/netty/netty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/netty/netty/statuses/{sha}","languages_url":"https://api.github.com/repos/netty/netty/languages","stargazers_url":"https://api.github.com/repos/netty/netty/stargazers","contributors_url":"https://api.github.com/repos/netty/netty/contributors","subscribers_url":"https://api.github.com/repos/netty/netty/subscribers","subscription_url":"https://api.github.com/repos/netty/netty/subscription","commits_url":"https://api.github.com/repos/netty/netty/commits{/sha}","git_commits_url":"https://api.github.com/repos/netty/netty/git/commits{/sha}","comments_url":"https://api.github.com/repos/netty/netty/comments{/number}","issue_comment_url":"https://api.github.com/repos/netty/netty/issues/comments{/number}","contents_url":"https://api.github.com/repos/netty/netty/contents/{+path}","compare_url":"https://api.github.com/repos/netty/netty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/netty/netty/merges","archive_url":"https://api.github.com/repos/netty/netty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/netty/netty/downloads","issues_url":"https://api.github.com/repos/netty/netty/issues{/number}","pulls_url":"https://api.github.com/repos/netty/netty/pulls{/number}","milestones_url":"https://api.github.com/repos/netty/netty/milestones{/number}","notifications_url":"https://api.github.com/repos/netty/netty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/netty/netty/labels{/name}","releases_url":"https://api.github.com/repos/netty/netty/releases{/id}","created_at":"2010-11-09T09:22:21Z","updated_at":"2015-09-23T19:15:11Z","pushed_at":"2015-09-23T17:26:05Z","git_url":"git://github.com/netty/netty.git","ssh_url":"git@github.com:netty/netty.git","clone_url":"https://github.com/netty/netty.git","svn_url":"https://github.com/netty/netty","homepage":"http://netty.io/","size":132075,"stargazers_count":5254,"watchers_count":5254,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2676,"mirror_url":null,"open_issues_count":303,"forks":2676,"open_issues":303,"watchers":5254,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/netty/netty/pulls/4243"},"html":{"href":"https://github.com/netty/netty/pull/4243"},"issue":{"href":"https://api.github.com/repos/netty/netty/issues/4243"},"comments":{"href":"https://api.github.com/repos/netty/netty/issues/4243/comments"},"review_comments":{"href":"https://api.github.com/repos/netty/netty/pulls/4243/comments"},"review_comment":{"href":"https://api.github.com/repos/netty/netty/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/netty/netty/pulls/4243/commits"},"statuses":{"href":"https://api.github.com/repos/netty/netty/statuses/56887d953177cfe05b6ac3ad25a2ff0878c42ba2"}}}}