{"action":"created","issue":{"url":"https://api.github.com/repos/hilverd/vagrant-ubuntu-oracle-xe/issues/20","labels_url":"https://api.github.com/repos/hilverd/vagrant-ubuntu-oracle-xe/issues/20/labels{/name}","comments_url":"https://api.github.com/repos/hilverd/vagrant-ubuntu-oracle-xe/issues/20/comments","events_url":"https://api.github.com/repos/hilverd/vagrant-ubuntu-oracle-xe/issues/20/events","html_url":"https://github.com/hilverd/vagrant-ubuntu-oracle-xe/pull/20","id":56045500,"number":20,"title":"Add flyway","user":{"login":"nblair","id":1041730,"avatar_url":"https://avatars.githubusercontent.com/u/1041730?v=3","gravatar_id":"","url":"https://api.github.com/users/nblair","html_url":"https://github.com/nblair","followers_url":"https://api.github.com/users/nblair/followers","following_url":"https://api.github.com/users/nblair/following{/other_user}","gists_url":"https://api.github.com/users/nblair/gists{/gist_id}","starred_url":"https://api.github.com/users/nblair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nblair/subscriptions","organizations_url":"https://api.github.com/users/nblair/orgs","repos_url":"https://api.github.com/users/nblair/repos","events_url":"https://api.github.com/users/nblair/events{/privacy}","received_events_url":"https://api.github.com/users/nblair/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-01-30T15:19:14Z","updated_at":"2015-02-01T10:35:05Z","closed_at":"2015-02-01T10:34:10Z","pull_request":{"url":"https://api.github.com/repos/hilverd/vagrant-ubuntu-oracle-xe/pulls/20","html_url":"https://github.com/hilverd/vagrant-ubuntu-oracle-xe/pull/20","diff_url":"https://github.com/hilverd/vagrant-ubuntu-oracle-xe/pull/20.diff","patch_url":"https://github.com/hilverd/vagrant-ubuntu-oracle-xe/pull/20.patch"},"body":"This pull request adds [Flyway](http://flywaydb.org) to the provisioning process to automate creation of tables and insertion of data.\r\n\r\nFlyway is a Java application, so it does depend on the installation of Java and Maven. In order to connect Java with Oracle, one needs a JDBC driver, which of course Oracle does not distribute freely. That does mean the addition of one more download, which I've covered on the root README.\r\n\r\nSome bits I'm not sure about:\r\n\r\n1. There are steps required on the host to install the Puppet forge modules for Java and/or Maven. Is there a way we can automate that? Do we need to includes those modules in git (I've gitignored them for now)?\r\n2. I was thinking it might be desirable to skip the Flyway provisioning steps if the customer chooses. Perhaps we can craft a way to skip those steps if oracle-jdbc/ojdbc6.jar is not present?"},"comment":{"url":"https://api.github.com/repos/hilverd/vagrant-ubuntu-oracle-xe/issues/comments/72359594","html_url":"https://github.com/hilverd/vagrant-ubuntu-oracle-xe/pull/20#issuecomment-72359594","issue_url":"https://api.github.com/repos/hilverd/vagrant-ubuntu-oracle-xe/issues/20","id":72359594,"user":{"login":"hilverd","id":551077,"avatar_url":"https://avatars.githubusercontent.com/u/551077?v=3","gravatar_id":"","url":"https://api.github.com/users/hilverd","html_url":"https://github.com/hilverd","followers_url":"https://api.github.com/users/hilverd/followers","following_url":"https://api.github.com/users/hilverd/following{/other_user}","gists_url":"https://api.github.com/users/hilverd/gists{/gist_id}","starred_url":"https://api.github.com/users/hilverd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hilverd/subscriptions","organizations_url":"https://api.github.com/users/hilverd/orgs","repos_url":"https://api.github.com/users/hilverd/repos","events_url":"https://api.github.com/users/hilverd/events{/privacy}","received_events_url":"https://api.github.com/users/hilverd/received_events","type":"User","site_admin":false},"created_at":"2015-02-01T10:35:05Z","updated_at":"2015-02-01T10:35:05Z","body":"This is great, thanks very much!\r\n\r\nIn response to your questions:\r\n\r\n1. We can actually install those modules on the VM, as that is where Puppet runs. I have added a small shell script to the `Vagrantfile` to do this *before* the Puppet provisioning.\r\n2. I agree. I have added some logic so that if `ojdbc6.jar` is not present, the steps to install the Java and Maven modules and run Flyway provisioning are skipped.\r\n\r\nThanks again :-)."}}