{"action":"created","comment":{"url":"https://api.github.com/repos/McDowellLab/loadflex/pulls/comments/32252823","id":32252823,"diff_hunk":"@@ -19,6 +19,10 @@\n #'   tolerance set by {tol}, FALSE otherwise.\n #' @export\n isTimestepRegular <- function(dates, hist=TRUE, tol=.Machine$double.eps^0.5, handler=stop) {\n+  #silly thing needed to pass R CMD check\n+  # from http://stackoverflow.com/questions/8096313/no-visible-binding-for-global-variable-note-in-r-cmd-check\n+  aes=TimeInterval=geom_histogram=xlab=NULL","path":"R/diagnostics.R","position":6,"original_position":6,"commit_id":"23a8db52ea9674407cd9c6bf0a5bac5ff544b3a6","original_commit_id":"23a8db52ea9674407cd9c6bf0a5bac5ff544b3a6","user":{"login":"miguelcleon","id":5941108,"avatar_url":"https://avatars.githubusercontent.com/u/5941108?v=3","gravatar_id":"","url":"https://api.github.com/users/miguelcleon","html_url":"https://github.com/miguelcleon","followers_url":"https://api.github.com/users/miguelcleon/followers","following_url":"https://api.github.com/users/miguelcleon/following{/other_user}","gists_url":"https://api.github.com/users/miguelcleon/gists{/gist_id}","starred_url":"https://api.github.com/users/miguelcleon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miguelcleon/subscriptions","organizations_url":"https://api.github.com/users/miguelcleon/orgs","repos_url":"https://api.github.com/users/miguelcleon/repos","events_url":"https://api.github.com/users/miguelcleon/events{/privacy}","received_events_url":"https://api.github.com/users/miguelcleon/received_events","type":"User","site_admin":false},"body":"Ok, there are two issues at play here. 1) sometimes roxygen doesn't find elements from other packages which you fixed with the @importFrom instead of my =NULL which I agree that makes sense and is better. 2) sometimes roxygen thinks local variables are global variables which is what is happening I believe with s.hat and maybe TimeInterval but I'm not sure if TimeInterval is a local variable or maybe it comes from somewhere else? Then where does it come from? I think the right thing to do in case 2) is still to do the =NULL trick. ","created_at":"2015-06-11T18:32:26Z","updated_at":"2015-06-11T18:32:26Z","html_url":"https://github.com/McDowellLab/loadflex/pull/61#discussion_r32252823","pull_request_url":"https://api.github.com/repos/McDowellLab/loadflex/pulls/61","_links":{"self":{"href":"https://api.github.com/repos/McDowellLab/loadflex/pulls/comments/32252823"},"html":{"href":"https://github.com/McDowellLab/loadflex/pull/61#discussion_r32252823"},"pull_request":{"href":"https://api.github.com/repos/McDowellLab/loadflex/pulls/61"}}},"pull_request":{"url":"https://api.github.com/repos/McDowellLab/loadflex/pulls/61","id":37485463,"html_url":"https://github.com/McDowellLab/loadflex/pull/61","diff_url":"https://github.com/McDowellLab/loadflex/pull/61.diff","patch_url":"https://github.com/McDowellLab/loadflex/pull/61.patch","issue_url":"https://api.github.com/repos/McDowellLab/loadflex/issues/61","number":61,"state":"open","locked":false,"title":"resolves issues #16 and #17.","user":{"login":"miguelcleon","id":5941108,"avatar_url":"https://avatars.githubusercontent.com/u/5941108?v=3","gravatar_id":"","url":"https://api.github.com/users/miguelcleon","html_url":"https://github.com/miguelcleon","followers_url":"https://api.github.com/users/miguelcleon/followers","following_url":"https://api.github.com/users/miguelcleon/following{/other_user}","gists_url":"https://api.github.com/users/miguelcleon/gists{/gist_id}","starred_url":"https://api.github.com/users/miguelcleon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miguelcleon/subscriptions","organizations_url":"https://api.github.com/users/miguelcleon/orgs","repos_url":"https://api.github.com/users/miguelcleon/repos","events_url":"https://api.github.com/users/miguelcleon/events{/privacy}","received_events_url":"https://api.github.com/users/miguelcleon/received_events","type":"User","site_admin":false},"body":"no more warnings or NOTE messages from R CMD check","created_at":"2015-06-11T16:59:17Z","updated_at":"2015-06-11T18:32:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b141ea58a3710fea654e66a352e14ba476476f9d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/McDowellLab/loadflex/pulls/61/commits","review_comments_url":"https://api.github.com/repos/McDowellLab/loadflex/pulls/61/comments","review_comment_url":"https://api.github.com/repos/McDowellLab/loadflex/pulls/comments{/number}","comments_url":"https://api.github.com/repos/McDowellLab/loadflex/issues/61/comments","statuses_url":"https://api.github.com/repos/McDowellLab/loadflex/statuses/23a8db52ea9674407cd9c6bf0a5bac5ff544b3a6","head":{"label":"miguelcleon:master","ref":"master","sha":"23a8db52ea9674407cd9c6bf0a5bac5ff544b3a6","user":{"login":"miguelcleon","id":5941108,"avatar_url":"https://avatars.githubusercontent.com/u/5941108?v=3","gravatar_id":"","url":"https://api.github.com/users/miguelcleon","html_url":"https://github.com/miguelcleon","followers_url":"https://api.github.com/users/miguelcleon/followers","following_url":"https://api.github.com/users/miguelcleon/following{/other_user}","gists_url":"https://api.github.com/users/miguelcleon/gists{/gist_id}","starred_url":"https://api.github.com/users/miguelcleon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miguelcleon/subscriptions","organizations_url":"https://api.github.com/users/miguelcleon/orgs","repos_url":"https://api.github.com/users/miguelcleon/repos","events_url":"https://api.github.com/users/miguelcleon/events{/privacy}","received_events_url":"https://api.github.com/users/miguelcleon/received_events","type":"User","site_admin":false},"repo":{"id":37072033,"name":"loadflex","full_name":"miguelcleon/loadflex","owner":{"login":"miguelcleon","id":5941108,"avatar_url":"https://avatars.githubusercontent.com/u/5941108?v=3","gravatar_id":"","url":"https://api.github.com/users/miguelcleon","html_url":"https://github.com/miguelcleon","followers_url":"https://api.github.com/users/miguelcleon/followers","following_url":"https://api.github.com/users/miguelcleon/following{/other_user}","gists_url":"https://api.github.com/users/miguelcleon/gists{/gist_id}","starred_url":"https://api.github.com/users/miguelcleon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miguelcleon/subscriptions","organizations_url":"https://api.github.com/users/miguelcleon/orgs","repos_url":"https://api.github.com/users/miguelcleon/repos","events_url":"https://api.github.com/users/miguelcleon/events{/privacy}","received_events_url":"https://api.github.com/users/miguelcleon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/miguelcleon/loadflex","description":"Models and Tools for Watershed Flux Estimates","fork":true,"url":"https://api.github.com/repos/miguelcleon/loadflex","forks_url":"https://api.github.com/repos/miguelcleon/loadflex/forks","keys_url":"https://api.github.com/repos/miguelcleon/loadflex/keys{/key_id}","collaborators_url":"https://api.github.com/repos/miguelcleon/loadflex/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/miguelcleon/loadflex/teams","hooks_url":"https://api.github.com/repos/miguelcleon/loadflex/hooks","issue_events_url":"https://api.github.com/repos/miguelcleon/loadflex/issues/events{/number}","events_url":"https://api.github.com/repos/miguelcleon/loadflex/events","assignees_url":"https://api.github.com/repos/miguelcleon/loadflex/assignees{/user}","branches_url":"https://api.github.com/repos/miguelcleon/loadflex/branches{/branch}","tags_url":"https://api.github.com/repos/miguelcleon/loadflex/tags","blobs_url":"https://api.github.com/repos/miguelcleon/loadflex/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/miguelcleon/loadflex/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/miguelcleon/loadflex/git/refs{/sha}","trees_url":"https://api.github.com/repos/miguelcleon/loadflex/git/trees{/sha}","statuses_url":"https://api.github.com/repos/miguelcleon/loadflex/statuses/{sha}","languages_url":"https://api.github.com/repos/miguelcleon/loadflex/languages","stargazers_url":"https://api.github.com/repos/miguelcleon/loadflex/stargazers","contributors_url":"https://api.github.com/repos/miguelcleon/loadflex/contributors","subscribers_url":"https://api.github.com/repos/miguelcleon/loadflex/subscribers","subscription_url":"https://api.github.com/repos/miguelcleon/loadflex/subscription","commits_url":"https://api.github.com/repos/miguelcleon/loadflex/commits{/sha}","git_commits_url":"https://api.github.com/repos/miguelcleon/loadflex/git/commits{/sha}","comments_url":"https://api.github.com/repos/miguelcleon/loadflex/comments{/number}","issue_comment_url":"https://api.github.com/repos/miguelcleon/loadflex/issues/comments{/number}","contents_url":"https://api.github.com/repos/miguelcleon/loadflex/contents/{+path}","compare_url":"https://api.github.com/repos/miguelcleon/loadflex/compare/{base}...{head}","merges_url":"https://api.github.com/repos/miguelcleon/loadflex/merges","archive_url":"https://api.github.com/repos/miguelcleon/loadflex/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/miguelcleon/loadflex/downloads","issues_url":"https://api.github.com/repos/miguelcleon/loadflex/issues{/number}","pulls_url":"https://api.github.com/repos/miguelcleon/loadflex/pulls{/number}","milestones_url":"https://api.github.com/repos/miguelcleon/loadflex/milestones{/number}","notifications_url":"https://api.github.com/repos/miguelcleon/loadflex/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/miguelcleon/loadflex/labels{/name}","releases_url":"https://api.github.com/repos/miguelcleon/loadflex/releases{/id}","created_at":"2015-06-08T14:31:22Z","updated_at":"2015-06-08T14:31:22Z","pushed_at":"2015-06-11T16:57:48Z","git_url":"git://github.com/miguelcleon/loadflex.git","ssh_url":"git@github.com:miguelcleon/loadflex.git","clone_url":"https://github.com/miguelcleon/loadflex.git","svn_url":"https://github.com/miguelcleon/loadflex","homepage":"","size":2151,"stargazers_count":0,"watchers_count":0,"language":"R","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"McDowellLab:master","ref":"master","sha":"3f27dabbef26118e9186a3dcb058e4239a3e0a72","user":{"login":"McDowellLab","id":10223819,"avatar_url":"https://avatars.githubusercontent.com/u/10223819?v=3","gravatar_id":"","url":"https://api.github.com/users/McDowellLab","html_url":"https://github.com/McDowellLab","followers_url":"https://api.github.com/users/McDowellLab/followers","following_url":"https://api.github.com/users/McDowellLab/following{/other_user}","gists_url":"https://api.github.com/users/McDowellLab/gists{/gist_id}","starred_url":"https://api.github.com/users/McDowellLab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/McDowellLab/subscriptions","organizations_url":"https://api.github.com/users/McDowellLab/orgs","repos_url":"https://api.github.com/users/McDowellLab/repos","events_url":"https://api.github.com/users/McDowellLab/events{/privacy}","received_events_url":"https://api.github.com/users/McDowellLab/received_events","type":"Organization","site_admin":false},"repo":{"id":28149424,"name":"loadflex","full_name":"McDowellLab/loadflex","owner":{"login":"McDowellLab","id":10223819,"avatar_url":"https://avatars.githubusercontent.com/u/10223819?v=3","gravatar_id":"","url":"https://api.github.com/users/McDowellLab","html_url":"https://github.com/McDowellLab","followers_url":"https://api.github.com/users/McDowellLab/followers","following_url":"https://api.github.com/users/McDowellLab/following{/other_user}","gists_url":"https://api.github.com/users/McDowellLab/gists{/gist_id}","starred_url":"https://api.github.com/users/McDowellLab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/McDowellLab/subscriptions","organizations_url":"https://api.github.com/users/McDowellLab/orgs","repos_url":"https://api.github.com/users/McDowellLab/repos","events_url":"https://api.github.com/users/McDowellLab/events{/privacy}","received_events_url":"https://api.github.com/users/McDowellLab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/McDowellLab/loadflex","description":"Models and Tools for Watershed Flux Estimates","fork":false,"url":"https://api.github.com/repos/McDowellLab/loadflex","forks_url":"https://api.github.com/repos/McDowellLab/loadflex/forks","keys_url":"https://api.github.com/repos/McDowellLab/loadflex/keys{/key_id}","collaborators_url":"https://api.github.com/repos/McDowellLab/loadflex/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/McDowellLab/loadflex/teams","hooks_url":"https://api.github.com/repos/McDowellLab/loadflex/hooks","issue_events_url":"https://api.github.com/repos/McDowellLab/loadflex/issues/events{/number}","events_url":"https://api.github.com/repos/McDowellLab/loadflex/events","assignees_url":"https://api.github.com/repos/McDowellLab/loadflex/assignees{/user}","branches_url":"https://api.github.com/repos/McDowellLab/loadflex/branches{/branch}","tags_url":"https://api.github.com/repos/McDowellLab/loadflex/tags","blobs_url":"https://api.github.com/repos/McDowellLab/loadflex/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/McDowellLab/loadflex/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/McDowellLab/loadflex/git/refs{/sha}","trees_url":"https://api.github.com/repos/McDowellLab/loadflex/git/trees{/sha}","statuses_url":"https://api.github.com/repos/McDowellLab/loadflex/statuses/{sha}","languages_url":"https://api.github.com/repos/McDowellLab/loadflex/languages","stargazers_url":"https://api.github.com/repos/McDowellLab/loadflex/stargazers","contributors_url":"https://api.github.com/repos/McDowellLab/loadflex/contributors","subscribers_url":"https://api.github.com/repos/McDowellLab/loadflex/subscribers","subscription_url":"https://api.github.com/repos/McDowellLab/loadflex/subscription","commits_url":"https://api.github.com/repos/McDowellLab/loadflex/commits{/sha}","git_commits_url":"https://api.github.com/repos/McDowellLab/loadflex/git/commits{/sha}","comments_url":"https://api.github.com/repos/McDowellLab/loadflex/comments{/number}","issue_comment_url":"https://api.github.com/repos/McDowellLab/loadflex/issues/comments{/number}","contents_url":"https://api.github.com/repos/McDowellLab/loadflex/contents/{+path}","compare_url":"https://api.github.com/repos/McDowellLab/loadflex/compare/{base}...{head}","merges_url":"https://api.github.com/repos/McDowellLab/loadflex/merges","archive_url":"https://api.github.com/repos/McDowellLab/loadflex/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/McDowellLab/loadflex/downloads","issues_url":"https://api.github.com/repos/McDowellLab/loadflex/issues{/number}","pulls_url":"https://api.github.com/repos/McDowellLab/loadflex/pulls{/number}","milestones_url":"https://api.github.com/repos/McDowellLab/loadflex/milestones{/number}","notifications_url":"https://api.github.com/repos/McDowellLab/loadflex/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/McDowellLab/loadflex/labels{/name}","releases_url":"https://api.github.com/repos/McDowellLab/loadflex/releases{/id}","created_at":"2014-12-17T18:17:09Z","updated_at":"2014-12-18T22:04:00Z","pushed_at":"2015-06-11T16:59:17Z","git_url":"git://github.com/McDowellLab/loadflex.git","ssh_url":"git@github.com:McDowellLab/loadflex.git","clone_url":"https://github.com/McDowellLab/loadflex.git","svn_url":"https://github.com/McDowellLab/loadflex","homepage":"","size":2151,"stargazers_count":2,"watchers_count":2,"language":"R","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":27,"forks":2,"open_issues":27,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/McDowellLab/loadflex/pulls/61"},"html":{"href":"https://github.com/McDowellLab/loadflex/pull/61"},"issue":{"href":"https://api.github.com/repos/McDowellLab/loadflex/issues/61"},"comments":{"href":"https://api.github.com/repos/McDowellLab/loadflex/issues/61/comments"},"review_comments":{"href":"https://api.github.com/repos/McDowellLab/loadflex/pulls/61/comments"},"review_comment":{"href":"https://api.github.com/repos/McDowellLab/loadflex/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/McDowellLab/loadflex/pulls/61/commits"},"statuses":{"href":"https://api.github.com/repos/McDowellLab/loadflex/statuses/23a8db52ea9674407cd9c6bf0a5bac5ff544b3a6"}}}}