{"action":"created","comment":{"url":"https://api.github.com/repos/eslint/eslint/pulls/comments/33980320","id":33980320,"diff_hunk":"@@ -0,0 +1,10 @@\n+{\n+    \"rules\": {\n+        \"no-comma-dangle\": {\n+            \"replacedBy\": [\"comma-dangle\"]","path":"conf/deprecations.json","position":4,"original_position":4,"commit_id":"8b92527f67cd80c7b1e4039a82435fc82cdfec67","original_commit_id":"8b92527f67cd80c7b1e4039a82435fc82cdfec67","user":{"login":"nzakas","id":38546,"avatar_url":"https://avatars.githubusercontent.com/u/38546?v=3","gravatar_id":"","url":"https://api.github.com/users/nzakas","html_url":"https://github.com/nzakas","followers_url":"https://api.github.com/users/nzakas/followers","following_url":"https://api.github.com/users/nzakas/following{/other_user}","gists_url":"https://api.github.com/users/nzakas/gists{/gist_id}","starred_url":"https://api.github.com/users/nzakas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nzakas/subscriptions","organizations_url":"https://api.github.com/users/nzakas/orgs","repos_url":"https://api.github.com/users/nzakas/repos","events_url":"https://api.github.com/users/nzakas/events{/privacy}","received_events_url":"https://api.github.com/users/nzakas/received_events","type":"User","site_admin":false},"body":"Maybe we can simplify and do:\r\n\r\n```\r\nno-comma-dangle: [\"comma-dangle\"]\r\n```\r\n\r\nI'm not sure the property is needed.","created_at":"2015-07-06T20:47:30Z","updated_at":"2015-07-06T20:47:30Z","html_url":"https://github.com/eslint/eslint/pull/2920#discussion_r33980320","pull_request_url":"https://api.github.com/repos/eslint/eslint/pulls/2920","_links":{"self":{"href":"https://api.github.com/repos/eslint/eslint/pulls/comments/33980320"},"html":{"href":"https://github.com/eslint/eslint/pull/2920#discussion_r33980320"},"pull_request":{"href":"https://api.github.com/repos/eslint/eslint/pulls/2920"}}},"pull_request":{"url":"https://api.github.com/repos/eslint/eslint/pulls/2920","id":39201956,"html_url":"https://github.com/eslint/eslint/pull/2920","diff_url":"https://github.com/eslint/eslint/pull/2920.diff","patch_url":"https://github.com/eslint/eslint/pull/2920.patch","issue_url":"https://api.github.com/repos/eslint/eslint/issues/2920","number":2920,"state":"open","locked":false,"title":"Add: Warn on missing rule definition or deprecation (fixes #1549)","user":{"login":"IanVS","id":4616705,"avatar_url":"https://avatars.githubusercontent.com/u/4616705?v=3","gravatar_id":"","url":"https://api.github.com/users/IanVS","html_url":"https://github.com/IanVS","followers_url":"https://api.github.com/users/IanVS/followers","following_url":"https://api.github.com/users/IanVS/following{/other_user}","gists_url":"https://api.github.com/users/IanVS/gists{/gist_id}","starred_url":"https://api.github.com/users/IanVS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IanVS/subscriptions","organizations_url":"https://api.github.com/users/IanVS/orgs","repos_url":"https://api.github.com/users/IanVS/repos","events_url":"https://api.github.com/users/IanVS/events{/privacy}","received_events_url":"https://api.github.com/users/IanVS/received_events","type":"User","site_admin":false},"body":"So far, this address one half of #1549, printing a message if a rule is not defined.\r\n\r\nI had trouble with the tests for the new `rule-stub` module, maybe someone has some more thorough test ideas?  The module gets pretty well tested in the tests for `eslint.js`, but it would be good to have some better unit tests as well.\r\n\r\nAnother thing I'm not sure about: the severity of the resulting rule depends on how the (undefined) rule is configured.  If for example:\r\n\r\n```\r\n\"notarule\": 2\r\n// =>  1:1   error  Definition for rule 'notarule' was not found             notarule\r\n\r\n\"notarule\": 1\r\n// =>  1:1   warning  Definition for rule 'notarule' was not found             notarule\r\n```\r\n\r\nIs this the best way, or should it always be overridden to either a warning or an error?  I think I'm leaning towards the way it is now, because the effect will be determined by how much the user supposedly cares about that rule.  \r\n\r\n- [X] Print message if a rule is undefined\r\n- [x] Print message if a rule is deprecated","created_at":"2015-07-04T03:24:12Z","updated_at":"2015-07-06T20:47:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e9e378cba15be51f994629c370b60d235906b938","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/eslint/eslint/pulls/2920/commits","review_comments_url":"https://api.github.com/repos/eslint/eslint/pulls/2920/comments","review_comment_url":"https://api.github.com/repos/eslint/eslint/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eslint/eslint/issues/2920/comments","statuses_url":"https://api.github.com/repos/eslint/eslint/statuses/8b92527f67cd80c7b1e4039a82435fc82cdfec67","head":{"label":"IanVS:fix_1549","ref":"fix_1549","sha":"8b92527f67cd80c7b1e4039a82435fc82cdfec67","user":{"login":"IanVS","id":4616705,"avatar_url":"https://avatars.githubusercontent.com/u/4616705?v=3","gravatar_id":"","url":"https://api.github.com/users/IanVS","html_url":"https://github.com/IanVS","followers_url":"https://api.github.com/users/IanVS/followers","following_url":"https://api.github.com/users/IanVS/following{/other_user}","gists_url":"https://api.github.com/users/IanVS/gists{/gist_id}","starred_url":"https://api.github.com/users/IanVS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IanVS/subscriptions","organizations_url":"https://api.github.com/users/IanVS/orgs","repos_url":"https://api.github.com/users/IanVS/repos","events_url":"https://api.github.com/users/IanVS/events{/privacy}","received_events_url":"https://api.github.com/users/IanVS/received_events","type":"User","site_admin":false},"repo":{"id":32155347,"name":"eslint","full_name":"IanVS/eslint","owner":{"login":"IanVS","id":4616705,"avatar_url":"https://avatars.githubusercontent.com/u/4616705?v=3","gravatar_id":"","url":"https://api.github.com/users/IanVS","html_url":"https://github.com/IanVS","followers_url":"https://api.github.com/users/IanVS/followers","following_url":"https://api.github.com/users/IanVS/following{/other_user}","gists_url":"https://api.github.com/users/IanVS/gists{/gist_id}","starred_url":"https://api.github.com/users/IanVS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IanVS/subscriptions","organizations_url":"https://api.github.com/users/IanVS/orgs","repos_url":"https://api.github.com/users/IanVS/repos","events_url":"https://api.github.com/users/IanVS/events{/privacy}","received_events_url":"https://api.github.com/users/IanVS/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/IanVS/eslint","description":"A fully pluggable tool for identifying and reporting on patterns in JavaScript.","fork":true,"url":"https://api.github.com/repos/IanVS/eslint","forks_url":"https://api.github.com/repos/IanVS/eslint/forks","keys_url":"https://api.github.com/repos/IanVS/eslint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/IanVS/eslint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/IanVS/eslint/teams","hooks_url":"https://api.github.com/repos/IanVS/eslint/hooks","issue_events_url":"https://api.github.com/repos/IanVS/eslint/issues/events{/number}","events_url":"https://api.github.com/repos/IanVS/eslint/events","assignees_url":"https://api.github.com/repos/IanVS/eslint/assignees{/user}","branches_url":"https://api.github.com/repos/IanVS/eslint/branches{/branch}","tags_url":"https://api.github.com/repos/IanVS/eslint/tags","blobs_url":"https://api.github.com/repos/IanVS/eslint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/IanVS/eslint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/IanVS/eslint/git/refs{/sha}","trees_url":"https://api.github.com/repos/IanVS/eslint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/IanVS/eslint/statuses/{sha}","languages_url":"https://api.github.com/repos/IanVS/eslint/languages","stargazers_url":"https://api.github.com/repos/IanVS/eslint/stargazers","contributors_url":"https://api.github.com/repos/IanVS/eslint/contributors","subscribers_url":"https://api.github.com/repos/IanVS/eslint/subscribers","subscription_url":"https://api.github.com/repos/IanVS/eslint/subscription","commits_url":"https://api.github.com/repos/IanVS/eslint/commits{/sha}","git_commits_url":"https://api.github.com/repos/IanVS/eslint/git/commits{/sha}","comments_url":"https://api.github.com/repos/IanVS/eslint/comments{/number}","issue_comment_url":"https://api.github.com/repos/IanVS/eslint/issues/comments{/number}","contents_url":"https://api.github.com/repos/IanVS/eslint/contents/{+path}","compare_url":"https://api.github.com/repos/IanVS/eslint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/IanVS/eslint/merges","archive_url":"https://api.github.com/repos/IanVS/eslint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/IanVS/eslint/downloads","issues_url":"https://api.github.com/repos/IanVS/eslint/issues{/number}","pulls_url":"https://api.github.com/repos/IanVS/eslint/pulls{/number}","milestones_url":"https://api.github.com/repos/IanVS/eslint/milestones{/number}","notifications_url":"https://api.github.com/repos/IanVS/eslint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/IanVS/eslint/labels{/name}","releases_url":"https://api.github.com/repos/IanVS/eslint/releases{/id}","created_at":"2015-03-13T12:45:47Z","updated_at":"2015-04-25T04:22:05Z","pushed_at":"2015-07-06T17:51:03Z","git_url":"git://github.com/IanVS/eslint.git","ssh_url":"git@github.com:IanVS/eslint.git","clone_url":"https://github.com/IanVS/eslint.git","svn_url":"https://github.com/IanVS/eslint","homepage":"http://eslint.org","size":5938,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"eslint:master","ref":"master","sha":"f45e85ab28e0451994d2b5fc0e1312366834c719","user":{"login":"eslint","id":6019716,"avatar_url":"https://avatars.githubusercontent.com/u/6019716?v=3","gravatar_id":"","url":"https://api.github.com/users/eslint","html_url":"https://github.com/eslint","followers_url":"https://api.github.com/users/eslint/followers","following_url":"https://api.github.com/users/eslint/following{/other_user}","gists_url":"https://api.github.com/users/eslint/gists{/gist_id}","starred_url":"https://api.github.com/users/eslint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eslint/subscriptions","organizations_url":"https://api.github.com/users/eslint/orgs","repos_url":"https://api.github.com/users/eslint/repos","events_url":"https://api.github.com/users/eslint/events{/privacy}","received_events_url":"https://api.github.com/users/eslint/received_events","type":"Organization","site_admin":false},"repo":{"id":11061773,"name":"eslint","full_name":"eslint/eslint","owner":{"login":"eslint","id":6019716,"avatar_url":"https://avatars.githubusercontent.com/u/6019716?v=3","gravatar_id":"","url":"https://api.github.com/users/eslint","html_url":"https://github.com/eslint","followers_url":"https://api.github.com/users/eslint/followers","following_url":"https://api.github.com/users/eslint/following{/other_user}","gists_url":"https://api.github.com/users/eslint/gists{/gist_id}","starred_url":"https://api.github.com/users/eslint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eslint/subscriptions","organizations_url":"https://api.github.com/users/eslint/orgs","repos_url":"https://api.github.com/users/eslint/repos","events_url":"https://api.github.com/users/eslint/events{/privacy}","received_events_url":"https://api.github.com/users/eslint/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eslint/eslint","description":"A fully pluggable tool for identifying and reporting on patterns in JavaScript.","fork":false,"url":"https://api.github.com/repos/eslint/eslint","forks_url":"https://api.github.com/repos/eslint/eslint/forks","keys_url":"https://api.github.com/repos/eslint/eslint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eslint/eslint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eslint/eslint/teams","hooks_url":"https://api.github.com/repos/eslint/eslint/hooks","issue_events_url":"https://api.github.com/repos/eslint/eslint/issues/events{/number}","events_url":"https://api.github.com/repos/eslint/eslint/events","assignees_url":"https://api.github.com/repos/eslint/eslint/assignees{/user}","branches_url":"https://api.github.com/repos/eslint/eslint/branches{/branch}","tags_url":"https://api.github.com/repos/eslint/eslint/tags","blobs_url":"https://api.github.com/repos/eslint/eslint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eslint/eslint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eslint/eslint/git/refs{/sha}","trees_url":"https://api.github.com/repos/eslint/eslint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eslint/eslint/statuses/{sha}","languages_url":"https://api.github.com/repos/eslint/eslint/languages","stargazers_url":"https://api.github.com/repos/eslint/eslint/stargazers","contributors_url":"https://api.github.com/repos/eslint/eslint/contributors","subscribers_url":"https://api.github.com/repos/eslint/eslint/subscribers","subscription_url":"https://api.github.com/repos/eslint/eslint/subscription","commits_url":"https://api.github.com/repos/eslint/eslint/commits{/sha}","git_commits_url":"https://api.github.com/repos/eslint/eslint/git/commits{/sha}","comments_url":"https://api.github.com/repos/eslint/eslint/comments{/number}","issue_comment_url":"https://api.github.com/repos/eslint/eslint/issues/comments{/number}","contents_url":"https://api.github.com/repos/eslint/eslint/contents/{+path}","compare_url":"https://api.github.com/repos/eslint/eslint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eslint/eslint/merges","archive_url":"https://api.github.com/repos/eslint/eslint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eslint/eslint/downloads","issues_url":"https://api.github.com/repos/eslint/eslint/issues{/number}","pulls_url":"https://api.github.com/repos/eslint/eslint/pulls{/number}","milestones_url":"https://api.github.com/repos/eslint/eslint/milestones{/number}","notifications_url":"https://api.github.com/repos/eslint/eslint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eslint/eslint/labels{/name}","releases_url":"https://api.github.com/repos/eslint/eslint/releases{/id}","created_at":"2013-06-29T23:59:48Z","updated_at":"2015-07-06T18:44:58Z","pushed_at":"2015-07-06T19:30:56Z","git_url":"git://github.com/eslint/eslint.git","ssh_url":"git@github.com:eslint/eslint.git","clone_url":"https://github.com/eslint/eslint.git","svn_url":"https://github.com/eslint/eslint","homepage":"http://eslint.org","size":17838,"stargazers_count":2459,"watchers_count":2459,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":455,"mirror_url":null,"open_issues_count":144,"forks":455,"open_issues":144,"watchers":2459,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eslint/eslint/pulls/2920"},"html":{"href":"https://github.com/eslint/eslint/pull/2920"},"issue":{"href":"https://api.github.com/repos/eslint/eslint/issues/2920"},"comments":{"href":"https://api.github.com/repos/eslint/eslint/issues/2920/comments"},"review_comments":{"href":"https://api.github.com/repos/eslint/eslint/pulls/2920/comments"},"review_comment":{"href":"https://api.github.com/repos/eslint/eslint/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eslint/eslint/pulls/2920/commits"},"statuses":{"href":"https://api.github.com/repos/eslint/eslint/statuses/8b92527f67cd80c7b1e4039a82435fc82cdfec67"}}}}