{"action":"created","comment":{"url":"https://api.github.com/repos/mlubin/NaNMath.jl/pulls/comments/37146114","id":37146114,"diff_hunk":"@@ -9,5 +9,17 @@ NaNMath.log(-100) # NaN\n NaNMath.pow(-1.5,2.3) # NaN\n ```\n \n+In addition this package provides functions, that aggregate one dimensional arrays and ignore elements, that are NaN.","path":"README.md","position":4,"original_position":4,"commit_id":"ca8cadda9c1c1200e58f71e44d59b32020afd48f","original_commit_id":"ca8cadda9c1c1200e58f71e44d59b32020afd48f","user":{"login":"mlubin","id":1733683,"avatar_url":"https://avatars.githubusercontent.com/u/1733683?v=3","gravatar_id":"","url":"https://api.github.com/users/mlubin","html_url":"https://github.com/mlubin","followers_url":"https://api.github.com/users/mlubin/followers","following_url":"https://api.github.com/users/mlubin/following{/other_user}","gists_url":"https://api.github.com/users/mlubin/gists{/gist_id}","starred_url":"https://api.github.com/users/mlubin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlubin/subscriptions","organizations_url":"https://api.github.com/users/mlubin/orgs","repos_url":"https://api.github.com/users/mlubin/repos","events_url":"https://api.github.com/users/mlubin/events{/privacy}","received_events_url":"https://api.github.com/users/mlubin/received_events","type":"User","site_admin":false},"body":"Slight nitpick but I think the sentence would read better without the two commas here.","created_at":"2015-08-16T13:58:57Z","updated_at":"2015-08-16T13:58:57Z","html_url":"https://github.com/mlubin/NaNMath.jl/pull/3#discussion_r37146114","pull_request_url":"https://api.github.com/repos/mlubin/NaNMath.jl/pulls/3","_links":{"self":{"href":"https://api.github.com/repos/mlubin/NaNMath.jl/pulls/comments/37146114"},"html":{"href":"https://github.com/mlubin/NaNMath.jl/pull/3#discussion_r37146114"},"pull_request":{"href":"https://api.github.com/repos/mlubin/NaNMath.jl/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/mlubin/NaNMath.jl/pulls/3","id":42520612,"html_url":"https://github.com/mlubin/NaNMath.jl/pull/3","diff_url":"https://github.com/mlubin/NaNMath.jl/pull/3.diff","patch_url":"https://github.com/mlubin/NaNMath.jl/pull/3.patch","issue_url":"https://api.github.com/repos/mlubin/NaNMath.jl/issues/3","number":3,"state":"open","locked":false,"title":"Added function NaNMath.sum for Float64 arrays","user":{"login":"ufechner7","id":4235229,"avatar_url":"https://avatars.githubusercontent.com/u/4235229?v=3","gravatar_id":"","url":"https://api.github.com/users/ufechner7","html_url":"https://github.com/ufechner7","followers_url":"https://api.github.com/users/ufechner7/followers","following_url":"https://api.github.com/users/ufechner7/following{/other_user}","gists_url":"https://api.github.com/users/ufechner7/gists{/gist_id}","starred_url":"https://api.github.com/users/ufechner7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ufechner7/subscriptions","organizations_url":"https://api.github.com/users/ufechner7/orgs","repos_url":"https://api.github.com/users/ufechner7/repos","events_url":"https://api.github.com/users/ufechner7/events{/privacy}","received_events_url":"https://api.github.com/users/ufechner7/received_events","type":"User","site_admin":false},"body":"I added the function sum. Currently, it is implemented for one dimensional Float64 arrays, which is all what I need. Before I continue to implement the other array functions, I would like to get feedback if my approach is acceptable, or how to improve it.","created_at":"2015-08-15T15:11:06Z","updated_at":"2015-08-16T13:58:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c04f9f510e37eca729508adc0a2468e374c38369","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mlubin/NaNMath.jl/pulls/3/commits","review_comments_url":"https://api.github.com/repos/mlubin/NaNMath.jl/pulls/3/comments","review_comment_url":"https://api.github.com/repos/mlubin/NaNMath.jl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mlubin/NaNMath.jl/issues/3/comments","statuses_url":"https://api.github.com/repos/mlubin/NaNMath.jl/statuses/ca8cadda9c1c1200e58f71e44d59b32020afd48f","head":{"label":"ufechner7:master","ref":"master","sha":"ca8cadda9c1c1200e58f71e44d59b32020afd48f","user":{"login":"ufechner7","id":4235229,"avatar_url":"https://avatars.githubusercontent.com/u/4235229?v=3","gravatar_id":"","url":"https://api.github.com/users/ufechner7","html_url":"https://github.com/ufechner7","followers_url":"https://api.github.com/users/ufechner7/followers","following_url":"https://api.github.com/users/ufechner7/following{/other_user}","gists_url":"https://api.github.com/users/ufechner7/gists{/gist_id}","starred_url":"https://api.github.com/users/ufechner7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ufechner7/subscriptions","organizations_url":"https://api.github.com/users/ufechner7/orgs","repos_url":"https://api.github.com/users/ufechner7/repos","events_url":"https://api.github.com/users/ufechner7/events{/privacy}","received_events_url":"https://api.github.com/users/ufechner7/received_events","type":"User","site_admin":false},"repo":{"id":40761691,"name":"NaNMath.jl","full_name":"ufechner7/NaNMath.jl","owner":{"login":"ufechner7","id":4235229,"avatar_url":"https://avatars.githubusercontent.com/u/4235229?v=3","gravatar_id":"","url":"https://api.github.com/users/ufechner7","html_url":"https://github.com/ufechner7","followers_url":"https://api.github.com/users/ufechner7/followers","following_url":"https://api.github.com/users/ufechner7/following{/other_user}","gists_url":"https://api.github.com/users/ufechner7/gists{/gist_id}","starred_url":"https://api.github.com/users/ufechner7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ufechner7/subscriptions","organizations_url":"https://api.github.com/users/ufechner7/orgs","repos_url":"https://api.github.com/users/ufechner7/repos","events_url":"https://api.github.com/users/ufechner7/events{/privacy}","received_events_url":"https://api.github.com/users/ufechner7/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ufechner7/NaNMath.jl","description":"Julia math built-ins which return or ignore NaN","fork":true,"url":"https://api.github.com/repos/ufechner7/NaNMath.jl","forks_url":"https://api.github.com/repos/ufechner7/NaNMath.jl/forks","keys_url":"https://api.github.com/repos/ufechner7/NaNMath.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ufechner7/NaNMath.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ufechner7/NaNMath.jl/teams","hooks_url":"https://api.github.com/repos/ufechner7/NaNMath.jl/hooks","issue_events_url":"https://api.github.com/repos/ufechner7/NaNMath.jl/issues/events{/number}","events_url":"https://api.github.com/repos/ufechner7/NaNMath.jl/events","assignees_url":"https://api.github.com/repos/ufechner7/NaNMath.jl/assignees{/user}","branches_url":"https://api.github.com/repos/ufechner7/NaNMath.jl/branches{/branch}","tags_url":"https://api.github.com/repos/ufechner7/NaNMath.jl/tags","blobs_url":"https://api.github.com/repos/ufechner7/NaNMath.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ufechner7/NaNMath.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ufechner7/NaNMath.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/ufechner7/NaNMath.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ufechner7/NaNMath.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/ufechner7/NaNMath.jl/languages","stargazers_url":"https://api.github.com/repos/ufechner7/NaNMath.jl/stargazers","contributors_url":"https://api.github.com/repos/ufechner7/NaNMath.jl/contributors","subscribers_url":"https://api.github.com/repos/ufechner7/NaNMath.jl/subscribers","subscription_url":"https://api.github.com/repos/ufechner7/NaNMath.jl/subscription","commits_url":"https://api.github.com/repos/ufechner7/NaNMath.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/ufechner7/NaNMath.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/ufechner7/NaNMath.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/ufechner7/NaNMath.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/ufechner7/NaNMath.jl/contents/{+path}","compare_url":"https://api.github.com/repos/ufechner7/NaNMath.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ufechner7/NaNMath.jl/merges","archive_url":"https://api.github.com/repos/ufechner7/NaNMath.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ufechner7/NaNMath.jl/downloads","issues_url":"https://api.github.com/repos/ufechner7/NaNMath.jl/issues{/number}","pulls_url":"https://api.github.com/repos/ufechner7/NaNMath.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/ufechner7/NaNMath.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/ufechner7/NaNMath.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ufechner7/NaNMath.jl/labels{/name}","releases_url":"https://api.github.com/repos/ufechner7/NaNMath.jl/releases{/id}","created_at":"2015-08-15T13:39:15Z","updated_at":"2015-08-15T14:42:11Z","pushed_at":"2015-08-16T09:36:02Z","git_url":"git://github.com/ufechner7/NaNMath.jl.git","ssh_url":"git@github.com:ufechner7/NaNMath.jl.git","clone_url":"https://github.com/ufechner7/NaNMath.jl.git","svn_url":"https://github.com/ufechner7/NaNMath.jl","homepage":"","size":84,"stargazers_count":0,"watchers_count":0,"language":"Julia","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mlubin:master","ref":"master","sha":"adb02521f6fd7dfa7c64bbb38611d1f017e026f1","user":{"login":"mlubin","id":1733683,"avatar_url":"https://avatars.githubusercontent.com/u/1733683?v=3","gravatar_id":"","url":"https://api.github.com/users/mlubin","html_url":"https://github.com/mlubin","followers_url":"https://api.github.com/users/mlubin/followers","following_url":"https://api.github.com/users/mlubin/following{/other_user}","gists_url":"https://api.github.com/users/mlubin/gists{/gist_id}","starred_url":"https://api.github.com/users/mlubin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlubin/subscriptions","organizations_url":"https://api.github.com/users/mlubin/orgs","repos_url":"https://api.github.com/users/mlubin/repos","events_url":"https://api.github.com/users/mlubin/events{/privacy}","received_events_url":"https://api.github.com/users/mlubin/received_events","type":"User","site_admin":false},"repo":{"id":27005518,"name":"NaNMath.jl","full_name":"mlubin/NaNMath.jl","owner":{"login":"mlubin","id":1733683,"avatar_url":"https://avatars.githubusercontent.com/u/1733683?v=3","gravatar_id":"","url":"https://api.github.com/users/mlubin","html_url":"https://github.com/mlubin","followers_url":"https://api.github.com/users/mlubin/followers","following_url":"https://api.github.com/users/mlubin/following{/other_user}","gists_url":"https://api.github.com/users/mlubin/gists{/gist_id}","starred_url":"https://api.github.com/users/mlubin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlubin/subscriptions","organizations_url":"https://api.github.com/users/mlubin/orgs","repos_url":"https://api.github.com/users/mlubin/repos","events_url":"https://api.github.com/users/mlubin/events{/privacy}","received_events_url":"https://api.github.com/users/mlubin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mlubin/NaNMath.jl","description":"Julia math built-ins which return NaN","fork":false,"url":"https://api.github.com/repos/mlubin/NaNMath.jl","forks_url":"https://api.github.com/repos/mlubin/NaNMath.jl/forks","keys_url":"https://api.github.com/repos/mlubin/NaNMath.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mlubin/NaNMath.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mlubin/NaNMath.jl/teams","hooks_url":"https://api.github.com/repos/mlubin/NaNMath.jl/hooks","issue_events_url":"https://api.github.com/repos/mlubin/NaNMath.jl/issues/events{/number}","events_url":"https://api.github.com/repos/mlubin/NaNMath.jl/events","assignees_url":"https://api.github.com/repos/mlubin/NaNMath.jl/assignees{/user}","branches_url":"https://api.github.com/repos/mlubin/NaNMath.jl/branches{/branch}","tags_url":"https://api.github.com/repos/mlubin/NaNMath.jl/tags","blobs_url":"https://api.github.com/repos/mlubin/NaNMath.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mlubin/NaNMath.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mlubin/NaNMath.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/mlubin/NaNMath.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mlubin/NaNMath.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/mlubin/NaNMath.jl/languages","stargazers_url":"https://api.github.com/repos/mlubin/NaNMath.jl/stargazers","contributors_url":"https://api.github.com/repos/mlubin/NaNMath.jl/contributors","subscribers_url":"https://api.github.com/repos/mlubin/NaNMath.jl/subscribers","subscription_url":"https://api.github.com/repos/mlubin/NaNMath.jl/subscription","commits_url":"https://api.github.com/repos/mlubin/NaNMath.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/mlubin/NaNMath.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/mlubin/NaNMath.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/mlubin/NaNMath.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/mlubin/NaNMath.jl/contents/{+path}","compare_url":"https://api.github.com/repos/mlubin/NaNMath.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mlubin/NaNMath.jl/merges","archive_url":"https://api.github.com/repos/mlubin/NaNMath.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mlubin/NaNMath.jl/downloads","issues_url":"https://api.github.com/repos/mlubin/NaNMath.jl/issues{/number}","pulls_url":"https://api.github.com/repos/mlubin/NaNMath.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/mlubin/NaNMath.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/mlubin/NaNMath.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mlubin/NaNMath.jl/labels{/name}","releases_url":"https://api.github.com/repos/mlubin/NaNMath.jl/releases{/id}","created_at":"2014-11-22T16:56:17Z","updated_at":"2014-11-24T16:13:11Z","pushed_at":"2015-08-16T09:36:03Z","git_url":"git://github.com/mlubin/NaNMath.jl.git","ssh_url":"git@github.com:mlubin/NaNMath.jl.git","clone_url":"https://github.com/mlubin/NaNMath.jl.git","svn_url":"https://github.com/mlubin/NaNMath.jl","homepage":null,"size":132,"stargazers_count":0,"watchers_count":0,"language":"Julia","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mlubin/NaNMath.jl/pulls/3"},"html":{"href":"https://github.com/mlubin/NaNMath.jl/pull/3"},"issue":{"href":"https://api.github.com/repos/mlubin/NaNMath.jl/issues/3"},"comments":{"href":"https://api.github.com/repos/mlubin/NaNMath.jl/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/mlubin/NaNMath.jl/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/mlubin/NaNMath.jl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mlubin/NaNMath.jl/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/mlubin/NaNMath.jl/statuses/ca8cadda9c1c1200e58f71e44d59b32020afd48f"}}}}