{"action":"opened","number":414,"pull_request":{"url":"https://api.github.com/repos/KeepSafe/aiohttp/pulls/414","id":37842841,"html_url":"https://github.com/KeepSafe/aiohttp/pull/414","diff_url":"https://github.com/KeepSafe/aiohttp/pull/414.diff","patch_url":"https://github.com/KeepSafe/aiohttp/pull/414.patch","issue_url":"https://api.github.com/repos/KeepSafe/aiohttp/issues/414","number":414,"state":"open","locked":false,"title":"Add support for url dispatching using unquoted path.","user":{"login":"Lothiraldan","id":243665,"avatar_url":"https://avatars.githubusercontent.com/u/243665?v=3","gravatar_id":"","url":"https://api.github.com/users/Lothiraldan","html_url":"https://github.com/Lothiraldan","followers_url":"https://api.github.com/users/Lothiraldan/followers","following_url":"https://api.github.com/users/Lothiraldan/following{/other_user}","gists_url":"https://api.github.com/users/Lothiraldan/gists{/gist_id}","starred_url":"https://api.github.com/users/Lothiraldan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lothiraldan/subscriptions","organizations_url":"https://api.github.com/users/Lothiraldan/orgs","repos_url":"https://api.github.com/users/Lothiraldan/repos","events_url":"https://api.github.com/users/Lothiraldan/events{/privacy}","received_events_url":"https://api.github.com/users/Lothiraldan/received_events","type":"User","site_admin":false},"body":"It's necessary when trying to call the server with quoted /. Indeed with\r\nexample:\r\n\r\n```\r\napp = Application(loop=loop)\r\napp.router.add_route('GET', '/{route}', handler)\r\n```\r\n\r\nFollowing query will fail with a 404 status:\r\n\r\n```\r\ncurl -I http://127.0.0.1:8080/route%2Fslash\r\nHTTP/1.1 404 Not Found\r\n...\r\n```\r\n\r\nBecause ```%2F``` is unquoted and the path tested for match is then\r\n```route/slash```.\r\n\r\nThe proposed solution is to allow a ```unquoted_path``` argument in\r\nUrlDispatcher:\r\n\r\n```\r\napp = Application(loop=loop)\r\napp.router.add_route('GET', '/{route}', handler)\r\n```\r\n\r\nAnd now the request match the route:\r\n\r\n```\r\ncurl -I http://127.0.0.1:8080/route%2Fslash\r\nHTTP/1.1 200 OK\r\n...\r\n```","created_at":"2015-06-16T21:19:25Z","updated_at":"2015-06-16T21:19:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/KeepSafe/aiohttp/pulls/414/commits","review_comments_url":"https://api.github.com/repos/KeepSafe/aiohttp/pulls/414/comments","review_comment_url":"https://api.github.com/repos/KeepSafe/aiohttp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/KeepSafe/aiohttp/issues/414/comments","statuses_url":"https://api.github.com/repos/KeepSafe/aiohttp/statuses/6508e33512ac4b15f9ddf86868af954659a46451","head":{"label":"Lothiraldan:feature/unquoted-path-url-dispatching","ref":"feature/unquoted-path-url-dispatching","sha":"6508e33512ac4b15f9ddf86868af954659a46451","user":{"login":"Lothiraldan","id":243665,"avatar_url":"https://avatars.githubusercontent.com/u/243665?v=3","gravatar_id":"","url":"https://api.github.com/users/Lothiraldan","html_url":"https://github.com/Lothiraldan","followers_url":"https://api.github.com/users/Lothiraldan/followers","following_url":"https://api.github.com/users/Lothiraldan/following{/other_user}","gists_url":"https://api.github.com/users/Lothiraldan/gists{/gist_id}","starred_url":"https://api.github.com/users/Lothiraldan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lothiraldan/subscriptions","organizations_url":"https://api.github.com/users/Lothiraldan/orgs","repos_url":"https://api.github.com/users/Lothiraldan/repos","events_url":"https://api.github.com/users/Lothiraldan/events{/privacy}","received_events_url":"https://api.github.com/users/Lothiraldan/received_events","type":"User","site_admin":false},"repo":{"id":37554223,"name":"aiohttp","full_name":"Lothiraldan/aiohttp","owner":{"login":"Lothiraldan","id":243665,"avatar_url":"https://avatars.githubusercontent.com/u/243665?v=3","gravatar_id":"","url":"https://api.github.com/users/Lothiraldan","html_url":"https://github.com/Lothiraldan","followers_url":"https://api.github.com/users/Lothiraldan/followers","following_url":"https://api.github.com/users/Lothiraldan/following{/other_user}","gists_url":"https://api.github.com/users/Lothiraldan/gists{/gist_id}","starred_url":"https://api.github.com/users/Lothiraldan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lothiraldan/subscriptions","organizations_url":"https://api.github.com/users/Lothiraldan/orgs","repos_url":"https://api.github.com/users/Lothiraldan/repos","events_url":"https://api.github.com/users/Lothiraldan/events{/privacy}","received_events_url":"https://api.github.com/users/Lothiraldan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Lothiraldan/aiohttp","description":"http client/server for asyncio (PEP-3156)","fork":true,"url":"https://api.github.com/repos/Lothiraldan/aiohttp","forks_url":"https://api.github.com/repos/Lothiraldan/aiohttp/forks","keys_url":"https://api.github.com/repos/Lothiraldan/aiohttp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Lothiraldan/aiohttp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Lothiraldan/aiohttp/teams","hooks_url":"https://api.github.com/repos/Lothiraldan/aiohttp/hooks","issue_events_url":"https://api.github.com/repos/Lothiraldan/aiohttp/issues/events{/number}","events_url":"https://api.github.com/repos/Lothiraldan/aiohttp/events","assignees_url":"https://api.github.com/repos/Lothiraldan/aiohttp/assignees{/user}","branches_url":"https://api.github.com/repos/Lothiraldan/aiohttp/branches{/branch}","tags_url":"https://api.github.com/repos/Lothiraldan/aiohttp/tags","blobs_url":"https://api.github.com/repos/Lothiraldan/aiohttp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Lothiraldan/aiohttp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Lothiraldan/aiohttp/git/refs{/sha}","trees_url":"https://api.github.com/repos/Lothiraldan/aiohttp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Lothiraldan/aiohttp/statuses/{sha}","languages_url":"https://api.github.com/repos/Lothiraldan/aiohttp/languages","stargazers_url":"https://api.github.com/repos/Lothiraldan/aiohttp/stargazers","contributors_url":"https://api.github.com/repos/Lothiraldan/aiohttp/contributors","subscribers_url":"https://api.github.com/repos/Lothiraldan/aiohttp/subscribers","subscription_url":"https://api.github.com/repos/Lothiraldan/aiohttp/subscription","commits_url":"https://api.github.com/repos/Lothiraldan/aiohttp/commits{/sha}","git_commits_url":"https://api.github.com/repos/Lothiraldan/aiohttp/git/commits{/sha}","comments_url":"https://api.github.com/repos/Lothiraldan/aiohttp/comments{/number}","issue_comment_url":"https://api.github.com/repos/Lothiraldan/aiohttp/issues/comments{/number}","contents_url":"https://api.github.com/repos/Lothiraldan/aiohttp/contents/{+path}","compare_url":"https://api.github.com/repos/Lothiraldan/aiohttp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Lothiraldan/aiohttp/merges","archive_url":"https://api.github.com/repos/Lothiraldan/aiohttp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Lothiraldan/aiohttp/downloads","issues_url":"https://api.github.com/repos/Lothiraldan/aiohttp/issues{/number}","pulls_url":"https://api.github.com/repos/Lothiraldan/aiohttp/pulls{/number}","milestones_url":"https://api.github.com/repos/Lothiraldan/aiohttp/milestones{/number}","notifications_url":"https://api.github.com/repos/Lothiraldan/aiohttp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Lothiraldan/aiohttp/labels{/name}","releases_url":"https://api.github.com/repos/Lothiraldan/aiohttp/releases{/id}","created_at":"2015-06-16T20:28:20Z","updated_at":"2015-06-16T20:28:21Z","pushed_at":"2015-06-16T21:19:03Z","git_url":"git://github.com/Lothiraldan/aiohttp.git","ssh_url":"git@github.com:Lothiraldan/aiohttp.git","clone_url":"https://github.com/Lothiraldan/aiohttp.git","svn_url":"https://github.com/Lothiraldan/aiohttp","homepage":"http://aiohttp.readthedocs.org","size":6831,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"KeepSafe:master","ref":"master","sha":"d1b7e1cb638ea6ece554b4cbe8c8b470737a2cd7","user":{"login":"KeepSafe","id":1377248,"avatar_url":"https://avatars.githubusercontent.com/u/1377248?v=3","gravatar_id":"","url":"https://api.github.com/users/KeepSafe","html_url":"https://github.com/KeepSafe","followers_url":"https://api.github.com/users/KeepSafe/followers","following_url":"https://api.github.com/users/KeepSafe/following{/other_user}","gists_url":"https://api.github.com/users/KeepSafe/gists{/gist_id}","starred_url":"https://api.github.com/users/KeepSafe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KeepSafe/subscriptions","organizations_url":"https://api.github.com/users/KeepSafe/orgs","repos_url":"https://api.github.com/users/KeepSafe/repos","events_url":"https://api.github.com/users/KeepSafe/events{/privacy}","received_events_url":"https://api.github.com/users/KeepSafe/received_events","type":"Organization","site_admin":false},"repo":{"id":13258039,"name":"aiohttp","full_name":"KeepSafe/aiohttp","owner":{"login":"KeepSafe","id":1377248,"avatar_url":"https://avatars.githubusercontent.com/u/1377248?v=3","gravatar_id":"","url":"https://api.github.com/users/KeepSafe","html_url":"https://github.com/KeepSafe","followers_url":"https://api.github.com/users/KeepSafe/followers","following_url":"https://api.github.com/users/KeepSafe/following{/other_user}","gists_url":"https://api.github.com/users/KeepSafe/gists{/gist_id}","starred_url":"https://api.github.com/users/KeepSafe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KeepSafe/subscriptions","organizations_url":"https://api.github.com/users/KeepSafe/orgs","repos_url":"https://api.github.com/users/KeepSafe/repos","events_url":"https://api.github.com/users/KeepSafe/events{/privacy}","received_events_url":"https://api.github.com/users/KeepSafe/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/KeepSafe/aiohttp","description":"http client/server for asyncio (PEP-3156)","fork":false,"url":"https://api.github.com/repos/KeepSafe/aiohttp","forks_url":"https://api.github.com/repos/KeepSafe/aiohttp/forks","keys_url":"https://api.github.com/repos/KeepSafe/aiohttp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KeepSafe/aiohttp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KeepSafe/aiohttp/teams","hooks_url":"https://api.github.com/repos/KeepSafe/aiohttp/hooks","issue_events_url":"https://api.github.com/repos/KeepSafe/aiohttp/issues/events{/number}","events_url":"https://api.github.com/repos/KeepSafe/aiohttp/events","assignees_url":"https://api.github.com/repos/KeepSafe/aiohttp/assignees{/user}","branches_url":"https://api.github.com/repos/KeepSafe/aiohttp/branches{/branch}","tags_url":"https://api.github.com/repos/KeepSafe/aiohttp/tags","blobs_url":"https://api.github.com/repos/KeepSafe/aiohttp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KeepSafe/aiohttp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KeepSafe/aiohttp/git/refs{/sha}","trees_url":"https://api.github.com/repos/KeepSafe/aiohttp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KeepSafe/aiohttp/statuses/{sha}","languages_url":"https://api.github.com/repos/KeepSafe/aiohttp/languages","stargazers_url":"https://api.github.com/repos/KeepSafe/aiohttp/stargazers","contributors_url":"https://api.github.com/repos/KeepSafe/aiohttp/contributors","subscribers_url":"https://api.github.com/repos/KeepSafe/aiohttp/subscribers","subscription_url":"https://api.github.com/repos/KeepSafe/aiohttp/subscription","commits_url":"https://api.github.com/repos/KeepSafe/aiohttp/commits{/sha}","git_commits_url":"https://api.github.com/repos/KeepSafe/aiohttp/git/commits{/sha}","comments_url":"https://api.github.com/repos/KeepSafe/aiohttp/comments{/number}","issue_comment_url":"https://api.github.com/repos/KeepSafe/aiohttp/issues/comments{/number}","contents_url":"https://api.github.com/repos/KeepSafe/aiohttp/contents/{+path}","compare_url":"https://api.github.com/repos/KeepSafe/aiohttp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KeepSafe/aiohttp/merges","archive_url":"https://api.github.com/repos/KeepSafe/aiohttp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KeepSafe/aiohttp/downloads","issues_url":"https://api.github.com/repos/KeepSafe/aiohttp/issues{/number}","pulls_url":"https://api.github.com/repos/KeepSafe/aiohttp/pulls{/number}","milestones_url":"https://api.github.com/repos/KeepSafe/aiohttp/milestones{/number}","notifications_url":"https://api.github.com/repos/KeepSafe/aiohttp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KeepSafe/aiohttp/labels{/name}","releases_url":"https://api.github.com/repos/KeepSafe/aiohttp/releases{/id}","created_at":"2013-10-01T23:04:01Z","updated_at":"2015-06-16T21:04:37Z","pushed_at":"2015-06-16T15:18:49Z","git_url":"git://github.com/KeepSafe/aiohttp.git","ssh_url":"git@github.com:KeepSafe/aiohttp.git","clone_url":"https://github.com/KeepSafe/aiohttp.git","svn_url":"https://github.com/KeepSafe/aiohttp","homepage":"http://aiohttp.readthedocs.org","size":6831,"stargazers_count":828,"watchers_count":828,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":134,"mirror_url":null,"open_issues_count":34,"forks":134,"open_issues":34,"watchers":828,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/KeepSafe/aiohttp/pulls/414"},"html":{"href":"https://github.com/KeepSafe/aiohttp/pull/414"},"issue":{"href":"https://api.github.com/repos/KeepSafe/aiohttp/issues/414"},"comments":{"href":"https://api.github.com/repos/KeepSafe/aiohttp/issues/414/comments"},"review_comments":{"href":"https://api.github.com/repos/KeepSafe/aiohttp/pulls/414/comments"},"review_comment":{"href":"https://api.github.com/repos/KeepSafe/aiohttp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/KeepSafe/aiohttp/pulls/414/commits"},"statuses":{"href":"https://api.github.com/repos/KeepSafe/aiohttp/statuses/6508e33512ac4b15f9ddf86868af954659a46451"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":43,"deletions":3,"changed_files":6}}