{"push_id":735438805,"size":1,"distinct_size":1,"ref":"refs/heads/make-abort-on-fatal-error-not-flaky","head":"a8e2a7652958ef036be77ea7809aa8c5d55bc8fc","before":"d1ea2450f5c7f8485c35aa2524cc8c16dbe95b60","commits":[{"sha":"a8e2a7652958ef036be77ea7809aa8c5d55bc8fc","author":{"email":"86afcc11905a16fc7f55f47e39f4f6f84944afea@joyent.com","name":"Julien Gilli"},"message":"test: make test-abort-fatal-error non flaky\n\nBefore this change, test/simple/test-abort-fatal-error.js would fail in\nsome environments for reasons I wasn't able to fully understand. It was\nmarked as flaky on some systems, but not on others on which it was\nfailing sometimes (OSX).\n\nThis change basically syncs test-abort-fatal-error with how it's\nimplemented in v0.12. It back ports 429b5870 (or rather the parts that\napply to it since it's a merge commit), 2f5e77f and 114bff4.\n\nAfter backporting these changes in v0.10, test-abort-fatal-error is not\nflaky anymore in environments for which it was flaky. It also has the\nadded benefit of being more robust because it checks exit codes and\nsignals instead of error messages.\n\nTested on OSX and SmartOS, the only platforms on which I could reproduce\nthe flakiness of this test.\n\nThis change also removes test-abort-fatal-error from the list of flaky\ntests in test/simple/simple.status.\n\nFixes #25720.","distinct":true,"url":"https://api.github.com/repos/misterdjules/node/commits/a8e2a7652958ef036be77ea7809aa8c5d55bc8fc"}]}