{"action":"created","comment":{"url":"https://api.github.com/repos/DataTorrent/Malhar/pulls/comments/36593160","id":36593160,"diff_hunk":"@@ -0,0 +1,58 @@\n+/**\n+ * Copyright (C) 2015 DataTorrent, Inc.\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ *         http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+package com.datatorrent.contrib.redis;\n+\n+import java.util.ArrayList;\n+import java.util.List;\n+import com.datatorrent.lib.util.KeyValPair;\n+\n+/**\n+ * This is the an implementation of a Redis input operator for fetching\n+ * Key-Value pair stored in Redis. It takes in keys to fetch and emits\n+ * corresponding <Key, Value> Pair. Value data type is String in this case.\n+ * <p>\n+ * </p> \n+ * @displayName Redis Input Operator for Key Value pair\n+ * @category Store\n+ * @tags input operator, key value\n+ *\n+ */\n+public class RedisKeyValueInputOperator extends\n+    AbstractRedisInputOperator<KeyValPair<String, String>> {\n+\n+  private List<Object> keysObjectList = new ArrayList<Object>();\n+\n+  @Override\n+  public void beginWindow(long windowId) {\n+    super.beginWindow(windowId);","path":"contrib/src/main/java/com/datatorrent/contrib/redis/RedisKeyValueInputOperator.java","position":41,"original_position":41,"commit_id":"ea3067ce0f4a1eb0995f6ddb15d2472c39899684","original_commit_id":"ea3067ce0f4a1eb0995f6ddb15d2472c39899684","user":{"login":"chandnisingh","id":4690923,"avatar_url":"https://avatars.githubusercontent.com/u/4690923?v=3","gravatar_id":"","url":"https://api.github.com/users/chandnisingh","html_url":"https://github.com/chandnisingh","followers_url":"https://api.github.com/users/chandnisingh/followers","following_url":"https://api.github.com/users/chandnisingh/following{/other_user}","gists_url":"https://api.github.com/users/chandnisingh/gists{/gist_id}","starred_url":"https://api.github.com/users/chandnisingh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chandnisingh/subscriptions","organizations_url":"https://api.github.com/users/chandnisingh/orgs","repos_url":"https://api.github.com/users/chandnisingh/repos","events_url":"https://api.github.com/users/chandnisingh/events{/privacy}","received_events_url":"https://api.github.com/users/chandnisingh/received_events","type":"User","site_admin":false},"body":"There is nothing additional being done so why to override?","created_at":"2015-08-09T20:20:09Z","updated_at":"2015-08-09T20:20:09Z","html_url":"https://github.com/DataTorrent/Malhar/pull/1459#discussion_r36593160","pull_request_url":"https://api.github.com/repos/DataTorrent/Malhar/pulls/1459","_links":{"self":{"href":"https://api.github.com/repos/DataTorrent/Malhar/pulls/comments/36593160"},"html":{"href":"https://github.com/DataTorrent/Malhar/pull/1459#discussion_r36593160"},"pull_request":{"href":"https://api.github.com/repos/DataTorrent/Malhar/pulls/1459"}}},"pull_request":{"url":"https://api.github.com/repos/DataTorrent/Malhar/pulls/1459","id":38826629,"html_url":"https://github.com/DataTorrent/Malhar/pull/1459","diff_url":"https://github.com/DataTorrent/Malhar/pull/1459.diff","patch_url":"https://github.com/DataTorrent/Malhar/pull/1459.patch","issue_url":"https://api.github.com/repos/DataTorrent/Malhar/issues/1459","number":1459,"state":"open","locked":false,"title":"MLHR-1748 Created concrete input and output operators for Redis Store","user":{"login":"ishark","id":723624,"avatar_url":"https://avatars.githubusercontent.com/u/723624?v=3","gravatar_id":"","url":"https://api.github.com/users/ishark","html_url":"https://github.com/ishark","followers_url":"https://api.github.com/users/ishark/followers","following_url":"https://api.github.com/users/ishark/following{/other_user}","gists_url":"https://api.github.com/users/ishark/gists{/gist_id}","starred_url":"https://api.github.com/users/ishark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ishark/subscriptions","organizations_url":"https://api.github.com/users/ishark/orgs","repos_url":"https://api.github.com/users/ishark/repos","events_url":"https://api.github.com/users/ishark/events{/privacy}","received_events_url":"https://api.github.com/users/ishark/received_events","type":"User","site_admin":false},"body":"Added test cases for the same.","created_at":"2015-06-29T22:54:51Z","updated_at":"2015-08-09T20:20:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b7ea7f206e0716148c54275313a510c7e4737327","assignee":{"login":"chandnisingh","id":4690923,"avatar_url":"https://avatars.githubusercontent.com/u/4690923?v=3","gravatar_id":"","url":"https://api.github.com/users/chandnisingh","html_url":"https://github.com/chandnisingh","followers_url":"https://api.github.com/users/chandnisingh/followers","following_url":"https://api.github.com/users/chandnisingh/following{/other_user}","gists_url":"https://api.github.com/users/chandnisingh/gists{/gist_id}","starred_url":"https://api.github.com/users/chandnisingh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chandnisingh/subscriptions","organizations_url":"https://api.github.com/users/chandnisingh/orgs","repos_url":"https://api.github.com/users/chandnisingh/repos","events_url":"https://api.github.com/users/chandnisingh/events{/privacy}","received_events_url":"https://api.github.com/users/chandnisingh/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/DataTorrent/Malhar/pulls/1459/commits","review_comments_url":"https://api.github.com/repos/DataTorrent/Malhar/pulls/1459/comments","review_comment_url":"https://api.github.com/repos/DataTorrent/Malhar/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DataTorrent/Malhar/issues/1459/comments","statuses_url":"https://api.github.com/repos/DataTorrent/Malhar/statuses/ea3067ce0f4a1eb0995f6ddb15d2472c39899684","head":{"label":"ishark:MLHR-1748","ref":"MLHR-1748","sha":"ea3067ce0f4a1eb0995f6ddb15d2472c39899684","user":{"login":"ishark","id":723624,"avatar_url":"https://avatars.githubusercontent.com/u/723624?v=3","gravatar_id":"","url":"https://api.github.com/users/ishark","html_url":"https://github.com/ishark","followers_url":"https://api.github.com/users/ishark/followers","following_url":"https://api.github.com/users/ishark/following{/other_user}","gists_url":"https://api.github.com/users/ishark/gists{/gist_id}","starred_url":"https://api.github.com/users/ishark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ishark/subscriptions","organizations_url":"https://api.github.com/users/ishark/orgs","repos_url":"https://api.github.com/users/ishark/repos","events_url":"https://api.github.com/users/ishark/events{/privacy}","received_events_url":"https://api.github.com/users/ishark/received_events","type":"User","site_admin":false},"repo":{"id":38264906,"name":"Malhar","full_name":"ishark/Malhar","owner":{"login":"ishark","id":723624,"avatar_url":"https://avatars.githubusercontent.com/u/723624?v=3","gravatar_id":"","url":"https://api.github.com/users/ishark","html_url":"https://github.com/ishark","followers_url":"https://api.github.com/users/ishark/followers","following_url":"https://api.github.com/users/ishark/following{/other_user}","gists_url":"https://api.github.com/users/ishark/gists{/gist_id}","starred_url":"https://api.github.com/users/ishark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ishark/subscriptions","organizations_url":"https://api.github.com/users/ishark/orgs","repos_url":"https://api.github.com/users/ishark/repos","events_url":"https://api.github.com/users/ishark/events{/privacy}","received_events_url":"https://api.github.com/users/ishark/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ishark/Malhar","description":"DataTorrent open source code.","fork":true,"url":"https://api.github.com/repos/ishark/Malhar","forks_url":"https://api.github.com/repos/ishark/Malhar/forks","keys_url":"https://api.github.com/repos/ishark/Malhar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ishark/Malhar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ishark/Malhar/teams","hooks_url":"https://api.github.com/repos/ishark/Malhar/hooks","issue_events_url":"https://api.github.com/repos/ishark/Malhar/issues/events{/number}","events_url":"https://api.github.com/repos/ishark/Malhar/events","assignees_url":"https://api.github.com/repos/ishark/Malhar/assignees{/user}","branches_url":"https://api.github.com/repos/ishark/Malhar/branches{/branch}","tags_url":"https://api.github.com/repos/ishark/Malhar/tags","blobs_url":"https://api.github.com/repos/ishark/Malhar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ishark/Malhar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ishark/Malhar/git/refs{/sha}","trees_url":"https://api.github.com/repos/ishark/Malhar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ishark/Malhar/statuses/{sha}","languages_url":"https://api.github.com/repos/ishark/Malhar/languages","stargazers_url":"https://api.github.com/repos/ishark/Malhar/stargazers","contributors_url":"https://api.github.com/repos/ishark/Malhar/contributors","subscribers_url":"https://api.github.com/repos/ishark/Malhar/subscribers","subscription_url":"https://api.github.com/repos/ishark/Malhar/subscription","commits_url":"https://api.github.com/repos/ishark/Malhar/commits{/sha}","git_commits_url":"https://api.github.com/repos/ishark/Malhar/git/commits{/sha}","comments_url":"https://api.github.com/repos/ishark/Malhar/comments{/number}","issue_comment_url":"https://api.github.com/repos/ishark/Malhar/issues/comments{/number}","contents_url":"https://api.github.com/repos/ishark/Malhar/contents/{+path}","compare_url":"https://api.github.com/repos/ishark/Malhar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ishark/Malhar/merges","archive_url":"https://api.github.com/repos/ishark/Malhar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ishark/Malhar/downloads","issues_url":"https://api.github.com/repos/ishark/Malhar/issues{/number}","pulls_url":"https://api.github.com/repos/ishark/Malhar/pulls{/number}","milestones_url":"https://api.github.com/repos/ishark/Malhar/milestones{/number}","notifications_url":"https://api.github.com/repos/ishark/Malhar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ishark/Malhar/labels{/name}","releases_url":"https://api.github.com/repos/ishark/Malhar/releases{/id}","created_at":"2015-06-29T18:51:53Z","updated_at":"2015-06-29T18:51:58Z","pushed_at":"2015-07-30T21:11:02Z","git_url":"git://github.com/ishark/Malhar.git","ssh_url":"git@github.com:ishark/Malhar.git","clone_url":"https://github.com/ishark/Malhar.git","svn_url":"https://github.com/ishark/Malhar","homepage":null,"size":76189,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DataTorrent:master","ref":"master","sha":"4016dde88a98e8d8ae0386b3bcb68e73561308f6","user":{"login":"DataTorrent","id":4400063,"avatar_url":"https://avatars.githubusercontent.com/u/4400063?v=3","gravatar_id":"","url":"https://api.github.com/users/DataTorrent","html_url":"https://github.com/DataTorrent","followers_url":"https://api.github.com/users/DataTorrent/followers","following_url":"https://api.github.com/users/DataTorrent/following{/other_user}","gists_url":"https://api.github.com/users/DataTorrent/gists{/gist_id}","starred_url":"https://api.github.com/users/DataTorrent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataTorrent/subscriptions","organizations_url":"https://api.github.com/users/DataTorrent/orgs","repos_url":"https://api.github.com/users/DataTorrent/repos","events_url":"https://api.github.com/users/DataTorrent/events{/privacy}","received_events_url":"https://api.github.com/users/DataTorrent/received_events","type":"Organization","site_admin":false},"repo":{"id":11749698,"name":"Malhar","full_name":"DataTorrent/Malhar","owner":{"login":"DataTorrent","id":4400063,"avatar_url":"https://avatars.githubusercontent.com/u/4400063?v=3","gravatar_id":"","url":"https://api.github.com/users/DataTorrent","html_url":"https://github.com/DataTorrent","followers_url":"https://api.github.com/users/DataTorrent/followers","following_url":"https://api.github.com/users/DataTorrent/following{/other_user}","gists_url":"https://api.github.com/users/DataTorrent/gists{/gist_id}","starred_url":"https://api.github.com/users/DataTorrent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataTorrent/subscriptions","organizations_url":"https://api.github.com/users/DataTorrent/orgs","repos_url":"https://api.github.com/users/DataTorrent/repos","events_url":"https://api.github.com/users/DataTorrent/events{/privacy}","received_events_url":"https://api.github.com/users/DataTorrent/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DataTorrent/Malhar","description":"DataTorrent open source code.","fork":false,"url":"https://api.github.com/repos/DataTorrent/Malhar","forks_url":"https://api.github.com/repos/DataTorrent/Malhar/forks","keys_url":"https://api.github.com/repos/DataTorrent/Malhar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DataTorrent/Malhar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DataTorrent/Malhar/teams","hooks_url":"https://api.github.com/repos/DataTorrent/Malhar/hooks","issue_events_url":"https://api.github.com/repos/DataTorrent/Malhar/issues/events{/number}","events_url":"https://api.github.com/repos/DataTorrent/Malhar/events","assignees_url":"https://api.github.com/repos/DataTorrent/Malhar/assignees{/user}","branches_url":"https://api.github.com/repos/DataTorrent/Malhar/branches{/branch}","tags_url":"https://api.github.com/repos/DataTorrent/Malhar/tags","blobs_url":"https://api.github.com/repos/DataTorrent/Malhar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DataTorrent/Malhar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DataTorrent/Malhar/git/refs{/sha}","trees_url":"https://api.github.com/repos/DataTorrent/Malhar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DataTorrent/Malhar/statuses/{sha}","languages_url":"https://api.github.com/repos/DataTorrent/Malhar/languages","stargazers_url":"https://api.github.com/repos/DataTorrent/Malhar/stargazers","contributors_url":"https://api.github.com/repos/DataTorrent/Malhar/contributors","subscribers_url":"https://api.github.com/repos/DataTorrent/Malhar/subscribers","subscription_url":"https://api.github.com/repos/DataTorrent/Malhar/subscription","commits_url":"https://api.github.com/repos/DataTorrent/Malhar/commits{/sha}","git_commits_url":"https://api.github.com/repos/DataTorrent/Malhar/git/commits{/sha}","comments_url":"https://api.github.com/repos/DataTorrent/Malhar/comments{/number}","issue_comment_url":"https://api.github.com/repos/DataTorrent/Malhar/issues/comments{/number}","contents_url":"https://api.github.com/repos/DataTorrent/Malhar/contents/{+path}","compare_url":"https://api.github.com/repos/DataTorrent/Malhar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DataTorrent/Malhar/merges","archive_url":"https://api.github.com/repos/DataTorrent/Malhar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DataTorrent/Malhar/downloads","issues_url":"https://api.github.com/repos/DataTorrent/Malhar/issues{/number}","pulls_url":"https://api.github.com/repos/DataTorrent/Malhar/pulls{/number}","milestones_url":"https://api.github.com/repos/DataTorrent/Malhar/milestones{/number}","notifications_url":"https://api.github.com/repos/DataTorrent/Malhar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DataTorrent/Malhar/labels{/name}","releases_url":"https://api.github.com/repos/DataTorrent/Malhar/releases{/id}","created_at":"2013-07-29T21:00:05Z","updated_at":"2015-07-22T21:48:15Z","pushed_at":"2015-08-08T00:10:12Z","git_url":"git://github.com/DataTorrent/Malhar.git","ssh_url":"git@github.com:DataTorrent/Malhar.git","clone_url":"https://github.com/DataTorrent/Malhar.git","svn_url":"https://github.com/DataTorrent/Malhar","homepage":null,"size":114351,"stargazers_count":61,"watchers_count":61,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":72,"mirror_url":null,"open_issues_count":134,"forks":72,"open_issues":134,"watchers":61,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DataTorrent/Malhar/pulls/1459"},"html":{"href":"https://github.com/DataTorrent/Malhar/pull/1459"},"issue":{"href":"https://api.github.com/repos/DataTorrent/Malhar/issues/1459"},"comments":{"href":"https://api.github.com/repos/DataTorrent/Malhar/issues/1459/comments"},"review_comments":{"href":"https://api.github.com/repos/DataTorrent/Malhar/pulls/1459/comments"},"review_comment":{"href":"https://api.github.com/repos/DataTorrent/Malhar/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DataTorrent/Malhar/pulls/1459/commits"},"statuses":{"href":"https://api.github.com/repos/DataTorrent/Malhar/statuses/ea3067ce0f4a1eb0995f6ddb15d2472c39899684"}}}}