{"action":"created","issue":{"url":"https://api.github.com/repos/thefactory/marathon-python/issues/44","labels_url":"https://api.github.com/repos/thefactory/marathon-python/issues/44/labels{/name}","comments_url":"https://api.github.com/repos/thefactory/marathon-python/issues/44/comments","events_url":"https://api.github.com/repos/thefactory/marathon-python/issues/44/events","html_url":"https://github.com/thefactory/marathon-python/pull/44","id":93393129,"number":44,"title":"Use the regex from upstream marathon as-is","user":{"login":"solarkennedy","id":370205,"avatar_url":"https://avatars.githubusercontent.com/u/370205?v=3","gravatar_id":"","url":"https://api.github.com/users/solarkennedy","html_url":"https://github.com/solarkennedy","followers_url":"https://api.github.com/users/solarkennedy/followers","following_url":"https://api.github.com/users/solarkennedy/following{/other_user}","gists_url":"https://api.github.com/users/solarkennedy/gists{/gist_id}","starred_url":"https://api.github.com/users/solarkennedy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solarkennedy/subscriptions","organizations_url":"https://api.github.com/users/solarkennedy/orgs","repos_url":"https://api.github.com/users/solarkennedy/repos","events_url":"https://api.github.com/users/solarkennedy/events{/privacy}","received_events_url":"https://api.github.com/users/solarkennedy/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-07-06T22:36:23Z","updated_at":"2015-07-06T22:59:56Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/thefactory/marathon-python/pulls/44","html_url":"https://github.com/thefactory/marathon-python/pull/44","diff_url":"https://github.com/thefactory/marathon-python/pull/44.diff","patch_url":"https://github.com/thefactory/marathon-python/pull/44.patch"},"body":"I don't really understand why this wasn't copied in as-is from upstream, @mattrobenolt ?\r\n\r\nBut the tests do not pass with it like this.\r\n\r\nI ran the tests per the readme, they failed right away because the regex didn't match.\r\nI adjusted the regex to what is upstream, and now they.. fail because I wasn't running a callback_url server, but at least the regex works.\r\n\r\nAlso the test runner now actually pulls MARATHON_SERVER from the environment as the readme advertises.\r\n\r\ncc @mrtyler @evankrall"},"comment":{"url":"https://api.github.com/repos/thefactory/marathon-python/issues/comments/119022741","html_url":"https://github.com/thefactory/marathon-python/pull/44#issuecomment-119022741","issue_url":"https://api.github.com/repos/thefactory/marathon-python/issues/44","id":119022741,"user":{"login":"solarkennedy","id":370205,"avatar_url":"https://avatars.githubusercontent.com/u/370205?v=3","gravatar_id":"","url":"https://api.github.com/users/solarkennedy","html_url":"https://github.com/solarkennedy","followers_url":"https://api.github.com/users/solarkennedy/followers","following_url":"https://api.github.com/users/solarkennedy/following{/other_user}","gists_url":"https://api.github.com/users/solarkennedy/gists{/gist_id}","starred_url":"https://api.github.com/users/solarkennedy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solarkennedy/subscriptions","organizations_url":"https://api.github.com/users/solarkennedy/orgs","repos_url":"https://api.github.com/users/solarkennedy/repos","events_url":"https://api.github.com/users/solarkennedy/events{/privacy}","received_events_url":"https://api.github.com/users/solarkennedy/received_events","type":"User","site_admin":false},"created_at":"2015-07-06T22:59:56Z","updated_at":"2015-07-06T22:59:56Z","body":"How much of performance penalty are we talking about? Because I can add `?:` on all the parens (4 sets?) to ignore capture groups, but it makes it much more likely I or others will make a mistake again if the regex changes.\r\n\r\nAlso the prefixing with `r` seems to break the tests again. "}}