{"push_id":628443726,"size":7,"distinct_size":7,"ref":"refs/heads/i965-disable-aux-buffers-for-EGLImages","head":"5bdbf5fd1d77251a5c7b44648b0eeb61f53e02ba","before":"84c93e4493593d59e4d75dda3e5107733b54a185","commits":[{"sha":"b2a5c038ab97949ca952ce862cdf994f3b78c4df","author":{"email":"a557f7f75bf28dc19ac99107f5cc7cd6b3fbdb1a@intel.com","name":"Chad Versace"},"message":"i965: Declare intel_miptree_alloc_mcs() as static\n\nIt's not used outside of intel_mipmap_tree.c, nor should it ever be.\n\nCc: Jordan Justen <jordan.l.justen@intel.com>\nCc: Tapani Pälli <tapani.palli@intel.com>\nCc: Zach Reizner <zachr@google.com>\nCc: Frank Henigman <fjhenigman@google.com>\nCc: Marta Lofstedt <marta.lofstedt@intel.com>\nCc: Haixia Shi <hshi@chromium.org>","distinct":true,"url":"https://api.github.com/repos/chadversary/mesa/commits/b2a5c038ab97949ca952ce862cdf994f3b78c4df"},{"sha":"4c28df868d8357ca605de0e9b3abff06c90761dc","author":{"email":"a557f7f75bf28dc19ac99107f5cc7cd6b3fbdb1a@intel.com","name":"Chad Versace"},"message":"i965: Declare intel_miptree_create_layout() as static\n\nIt's not used outside intel_mipmap_tree.c.\n\nCc: Jordan Justen <jordan.l.justen@intel.com>\nCc: Tapani Pälli <tapani.palli@intel.com>\nCc: Zach Reizner <zachr@google.com>\nCc: Frank Henigman <fjhenigman@google.com>\nCc: Marta Lofstedt <marta.lofstedt@intel.com>\nCc: Haixia Shi <hshi@chromium.org>","distinct":true,"url":"https://api.github.com/repos/chadversary/mesa/commits/4c28df868d8357ca605de0e9b3abff06c90761dc"},{"sha":"b3353421d1b920585b22d481592b05cc04d0acf8","author":{"email":"a557f7f75bf28dc19ac99107f5cc7cd6b3fbdb1a@intel.com","name":"Chad Versace"},"message":"i965: Refactor brw_is_hiz_depth_format()\n\nEvery caller of this function uses it to determine if the current\nmiptree needs a hiz buffer to be allocated. Strangely, the function\ndoesn't take a miptree argument. So, this function effectively decides\nif and when a miptree's hiz buffer gets allocated without inspecting the\nmiptree itself.  Luckily, the driver behaves correctly despite the\nbrw_is_hiz_depth_format's quirk.\n\nI will soon make some changes to the miptree that will require\ninspecting the miptree to determine if it needs a hiz buffer. So this\npatch renames\n    brw_is_hiz_depth_format -> intel_miptree_wants_hiz_buffer\nand gives it a miptree parameter.\n\nThis patch shouldn't change any behavior.\n\nCc: Jordan Justen <jordan.l.justen@intel.com>\nCc: Tapani Pälli <tapani.palli@intel.com>\nCc: Zach Reizner <zachr@google.com>\nCc: Frank Henigman <fjhenigman@google.com>\nCc: Marta Lofstedt <marta.lofstedt@intel.com>\nCc: Haixia Shi <hshi@chromium.org>","distinct":true,"url":"https://api.github.com/repos/chadversary/mesa/commits/b3353421d1b920585b22d481592b05cc04d0acf8"},{"sha":"6015fe97bcfb654bdf358f984e4ff9397a393396","author":{"email":"a557f7f75bf28dc19ac99107f5cc7cd6b3fbdb1a@intel.com","name":"Chad Versace"},"message":"i965: Add field intel_mipmap_tree::disable_aux_buffers\n\nThe new field disables allocation of auxiliary buffers, such as the HiZ\nbuffer and MCS buffer. This is useful for sharing the miptree bo with an\nexternal client that doesn't understand auxiliary buffers.\n\nWe need this field to safely render to a buffer that was imported with\nEGL_EXT_image_dma_buf_import, because EGL does not yet have extensions\nto manage flushing and invalidating auxiliary buffers.\n\nNothing yet enables this field. That's left to follow-up patches.\n\nTesting:\n  - Tested on Ivybridge Chromebook Pixel with WebGL Aquarium and\n    YouTube.\n  - No Piglit regressions on Broadwell with `piglit run -p gbm\n    tests/quick.py`.\n\nCc: Jordan Justen <jordan.l.justen@intel.com>\nCc: Tapani Pälli <tapani.palli@intel.com>\nCc: Zach Reizner <zachr@google.com>\nCc: Frank Henigman <fjhenigman@google.com>\nCc: Marta Lofstedt <marta.lofstedt@intel.com>\nCc: Haixia Shi <hshi@chromium.org>","distinct":true,"url":"https://api.github.com/repos/chadversary/mesa/commits/6015fe97bcfb654bdf358f984e4ff9397a393396"},{"sha":"b6b637baea584caadce50f3a78ef99d6b2f20dfc","author":{"email":"a557f7f75bf28dc19ac99107f5cc7cd6b3fbdb1a@intel.com","name":"Chad Versace"},"message":"i965: Change intel_miptree_create_for_bo() signature\n\nAdd parameter 'bool disable_aux_buffers'.\n\nThis is a refactor patch. The patch changes no behavior because the new\nparameter is false in every call.\n\nCc: Jordan Justen <jordan.l.justen@intel.com>\nCc: Tapani Pälli <tapani.palli@intel.com>\nCc: Zach Reizner <zachr@google.com>\nCc: Frank Henigman <fjhenigman@google.com>\nCc: Marta Lofstedt <marta.lofstedt@intel.com>\nCc: Haixia Shi <hshi@chromium.org>","distinct":true,"url":"https://api.github.com/repos/chadversary/mesa/commits/b6b637baea584caadce50f3a78ef99d6b2f20dfc"},{"sha":"144c1baf1299f08a0073d2b23f4aade1ad2a2d3a","author":{"email":"a557f7f75bf28dc19ac99107f5cc7cd6b3fbdb1a@intel.com","name":"Chad Versace"},"message":"i965: Disable aux buffers for EGLImage-backed miptrees\n\nEGL does not yet have extensions to manage the flushing and invalidating\nof driver-internal aux buffers. So we must disable aux buffers of\ndma_buf-backed EGLImages in order to safely render into them.\n\nThis patch is obviously needed for renderbufers. It's also needed for\ntextures because the user can attach the texture to a framebuffer and\nbecause the driver sometimes renders to textures for internal reasons.\n\nTesting:\n  - Tested on Ivybridge Chromebook Pixel with WebGL Aquarium and\n    YouTube.\n  - No Piglit regressions on Broadwell with `piglit run -p gbm\n    tests/quick.py`.\n\nCc: Jordan Justen <jordan.l.justen@intel.com>\nCc: Tapani Pälli <tapani.palli@intel.com>\nCc: Zach Reizner <zachr@google.com>\nCc: Frank Henigman <fjhenigman@google.com>\nCc: Marta Lofstedt <marta.lofstedt@intel.com>\nCc: Haixia Shi <hshi@chromium.org>","distinct":true,"url":"https://api.github.com/repos/chadversary/mesa/commits/144c1baf1299f08a0073d2b23f4aade1ad2a2d3a"},{"sha":"5bdbf5fd1d77251a5c7b44648b0eeb61f53e02ba","author":{"email":"a557f7f75bf28dc19ac99107f5cc7cd6b3fbdb1a@intel.com","name":"Chad Versace"},"message":"i965: Lift some restrictions on dma_buf EGLImages\n\nAllow glEGLImageTargetRenderbufferStorageOES and\nglEGLImageTargetTexture2DOES for dma_buf EGLImages if the image is\na single RGBA8 unorm plane. This is safe, despite fast color clears,\nbecause i965 disables allocation of auxiliary buffers for EGLImages.\n\nChrome OS needs this, because its compositor uses dma_buf EGLImages for\nits scanout buffers.\n\nTesting:\n  - Tested on Ivybridge Chromebook Pixel with WebGL Aquarium and\n    YouTube.\n  - No Piglit regressions on Broadwell with `piglit run -p gbm\n    tests/quick.py`, with my Piglit patches that update the\n    EGL_EXT_image_dma_buf_import tests.\n\nCc: Jordan Justen <jordan.l.justen@intel.com>\nCc: Tapani PÃ¤lli <tapani.palli@intel.com>\nCc: Topi Pohjolainen <topi.pohjolainen@intel.com>\nCc: Zach Reizner <zachr@google.com>\nCc: Frank Henigman <fjhenigman@google.com>\nCc: Marta Lofstedt <marta.lofstedt@intel.com>\nCc: Haixia Shi <hshi@chromium.org>","distinct":true,"url":"https://api.github.com/repos/chadversary/mesa/commits/5bdbf5fd1d77251a5c7b44648b0eeb61f53e02ba"}]}