{"action":"opened","number":319,"pull_request":{"url":"https://api.github.com/repos/maidsafe/routing/pulls/319","id":37362896,"html_url":"https://github.com/maidsafe/routing/pull/319","diff_url":"https://github.com/maidsafe/routing/pull/319.diff","patch_url":"https://github.com/maidsafe/routing/pull/319.patch","issue_url":"https://api.github.com/repos/maidsafe/routing/issues/319","number":319,"state":"open","locked":false,"title":"Directly add to relay_map on connect_request","user":{"login":"benjaminbollen","id":5057507,"avatar_url":"https://avatars.githubusercontent.com/u/5057507?v=3","gravatar_id":"","url":"https://api.github.com/users/benjaminbollen","html_url":"https://github.com/benjaminbollen","followers_url":"https://api.github.com/users/benjaminbollen/followers","following_url":"https://api.github.com/users/benjaminbollen/following{/other_user}","gists_url":"https://api.github.com/users/benjaminbollen/gists{/gist_id}","starred_url":"https://api.github.com/users/benjaminbollen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjaminbollen/subscriptions","organizations_url":"https://api.github.com/users/benjaminbollen/orgs","repos_url":"https://api.github.com/users/benjaminbollen/repos","events_url":"https://api.github.com/users/benjaminbollen/events{/privacy}","received_events_url":"https://api.github.com/users/benjaminbollen/received_events","type":"User","site_admin":false},"body":"Patch: on connect_request, directly add to relay_map - bypass the \"remember public_id\"\r\nThe assumption was that first a connect_request was received on our listening port, and when both sides 'connection_manager.connect' a 'CRUST::NewConnection' would be triggered.\r\n\r\nTurns out that CRUST gives a new CRUST::NewConnection for every single sided connect, and the NewMessage comes after that, for a given endpoint.  This patch should do, but post-sprint this logic needs to be reworked.","created_at":"2015-06-10T14:14:50Z","updated_at":"2015-06-10T14:14:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/maidsafe/routing/pulls/319/commits","review_comments_url":"https://api.github.com/repos/maidsafe/routing/pulls/319/comments","review_comment_url":"https://api.github.com/repos/maidsafe/routing/pulls/comments{/number}","comments_url":"https://api.github.com/repos/maidsafe/routing/issues/319/comments","statuses_url":"https://api.github.com/repos/maidsafe/routing/statuses/75568185d4f61c090429804f519099d5f502ba45","head":{"label":"benjaminbollen:issue_318","ref":"issue_318","sha":"75568185d4f61c090429804f519099d5f502ba45","user":{"login":"benjaminbollen","id":5057507,"avatar_url":"https://avatars.githubusercontent.com/u/5057507?v=3","gravatar_id":"","url":"https://api.github.com/users/benjaminbollen","html_url":"https://github.com/benjaminbollen","followers_url":"https://api.github.com/users/benjaminbollen/followers","following_url":"https://api.github.com/users/benjaminbollen/following{/other_user}","gists_url":"https://api.github.com/users/benjaminbollen/gists{/gist_id}","starred_url":"https://api.github.com/users/benjaminbollen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjaminbollen/subscriptions","organizations_url":"https://api.github.com/users/benjaminbollen/orgs","repos_url":"https://api.github.com/users/benjaminbollen/repos","events_url":"https://api.github.com/users/benjaminbollen/events{/privacy}","received_events_url":"https://api.github.com/users/benjaminbollen/received_events","type":"User","site_admin":false},"repo":{"id":31930999,"name":"routing","full_name":"benjaminbollen/routing","owner":{"login":"benjaminbollen","id":5057507,"avatar_url":"https://avatars.githubusercontent.com/u/5057507?v=3","gravatar_id":"","url":"https://api.github.com/users/benjaminbollen","html_url":"https://github.com/benjaminbollen","followers_url":"https://api.github.com/users/benjaminbollen/followers","following_url":"https://api.github.com/users/benjaminbollen/following{/other_user}","gists_url":"https://api.github.com/users/benjaminbollen/gists{/gist_id}","starred_url":"https://api.github.com/users/benjaminbollen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjaminbollen/subscriptions","organizations_url":"https://api.github.com/users/benjaminbollen/orgs","repos_url":"https://api.github.com/users/benjaminbollen/repos","events_url":"https://api.github.com/users/benjaminbollen/events{/privacy}","received_events_url":"https://api.github.com/users/benjaminbollen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/benjaminbollen/routing","description":"Routing - specialised storage DHT","fork":true,"url":"https://api.github.com/repos/benjaminbollen/routing","forks_url":"https://api.github.com/repos/benjaminbollen/routing/forks","keys_url":"https://api.github.com/repos/benjaminbollen/routing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/benjaminbollen/routing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/benjaminbollen/routing/teams","hooks_url":"https://api.github.com/repos/benjaminbollen/routing/hooks","issue_events_url":"https://api.github.com/repos/benjaminbollen/routing/issues/events{/number}","events_url":"https://api.github.com/repos/benjaminbollen/routing/events","assignees_url":"https://api.github.com/repos/benjaminbollen/routing/assignees{/user}","branches_url":"https://api.github.com/repos/benjaminbollen/routing/branches{/branch}","tags_url":"https://api.github.com/repos/benjaminbollen/routing/tags","blobs_url":"https://api.github.com/repos/benjaminbollen/routing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/benjaminbollen/routing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/benjaminbollen/routing/git/refs{/sha}","trees_url":"https://api.github.com/repos/benjaminbollen/routing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/benjaminbollen/routing/statuses/{sha}","languages_url":"https://api.github.com/repos/benjaminbollen/routing/languages","stargazers_url":"https://api.github.com/repos/benjaminbollen/routing/stargazers","contributors_url":"https://api.github.com/repos/benjaminbollen/routing/contributors","subscribers_url":"https://api.github.com/repos/benjaminbollen/routing/subscribers","subscription_url":"https://api.github.com/repos/benjaminbollen/routing/subscription","commits_url":"https://api.github.com/repos/benjaminbollen/routing/commits{/sha}","git_commits_url":"https://api.github.com/repos/benjaminbollen/routing/git/commits{/sha}","comments_url":"https://api.github.com/repos/benjaminbollen/routing/comments{/number}","issue_comment_url":"https://api.github.com/repos/benjaminbollen/routing/issues/comments{/number}","contents_url":"https://api.github.com/repos/benjaminbollen/routing/contents/{+path}","compare_url":"https://api.github.com/repos/benjaminbollen/routing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/benjaminbollen/routing/merges","archive_url":"https://api.github.com/repos/benjaminbollen/routing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/benjaminbollen/routing/downloads","issues_url":"https://api.github.com/repos/benjaminbollen/routing/issues{/number}","pulls_url":"https://api.github.com/repos/benjaminbollen/routing/pulls{/number}","milestones_url":"https://api.github.com/repos/benjaminbollen/routing/milestones{/number}","notifications_url":"https://api.github.com/repos/benjaminbollen/routing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/benjaminbollen/routing/labels{/name}","releases_url":"https://api.github.com/repos/benjaminbollen/routing/releases{/id}","created_at":"2015-03-10T01:00:26Z","updated_at":"2015-05-03T23:18:20Z","pushed_at":"2015-06-10T14:10:30Z","git_url":"git://github.com/benjaminbollen/routing.git","ssh_url":"git@github.com:benjaminbollen/routing.git","clone_url":"https://github.com/benjaminbollen/routing.git","svn_url":"https://github.com/benjaminbollen/routing","homepage":null,"size":3423,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"maidsafe:master","ref":"master","sha":"f5d33f1909434ae2368618100c830764b638d7df","user":{"login":"maidsafe","id":536423,"avatar_url":"https://avatars.githubusercontent.com/u/536423?v=3","gravatar_id":"","url":"https://api.github.com/users/maidsafe","html_url":"https://github.com/maidsafe","followers_url":"https://api.github.com/users/maidsafe/followers","following_url":"https://api.github.com/users/maidsafe/following{/other_user}","gists_url":"https://api.github.com/users/maidsafe/gists{/gist_id}","starred_url":"https://api.github.com/users/maidsafe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maidsafe/subscriptions","organizations_url":"https://api.github.com/users/maidsafe/orgs","repos_url":"https://api.github.com/users/maidsafe/repos","events_url":"https://api.github.com/users/maidsafe/events{/privacy}","received_events_url":"https://api.github.com/users/maidsafe/received_events","type":"Organization","site_admin":false},"repo":{"id":31270514,"name":"routing","full_name":"maidsafe/routing","owner":{"login":"maidsafe","id":536423,"avatar_url":"https://avatars.githubusercontent.com/u/536423?v=3","gravatar_id":"","url":"https://api.github.com/users/maidsafe","html_url":"https://github.com/maidsafe","followers_url":"https://api.github.com/users/maidsafe/followers","following_url":"https://api.github.com/users/maidsafe/following{/other_user}","gists_url":"https://api.github.com/users/maidsafe/gists{/gist_id}","starred_url":"https://api.github.com/users/maidsafe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maidsafe/subscriptions","organizations_url":"https://api.github.com/users/maidsafe/orgs","repos_url":"https://api.github.com/users/maidsafe/repos","events_url":"https://api.github.com/users/maidsafe/events{/privacy}","received_events_url":"https://api.github.com/users/maidsafe/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/maidsafe/routing","description":"Routing - specialised storage DHT","fork":false,"url":"https://api.github.com/repos/maidsafe/routing","forks_url":"https://api.github.com/repos/maidsafe/routing/forks","keys_url":"https://api.github.com/repos/maidsafe/routing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maidsafe/routing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maidsafe/routing/teams","hooks_url":"https://api.github.com/repos/maidsafe/routing/hooks","issue_events_url":"https://api.github.com/repos/maidsafe/routing/issues/events{/number}","events_url":"https://api.github.com/repos/maidsafe/routing/events","assignees_url":"https://api.github.com/repos/maidsafe/routing/assignees{/user}","branches_url":"https://api.github.com/repos/maidsafe/routing/branches{/branch}","tags_url":"https://api.github.com/repos/maidsafe/routing/tags","blobs_url":"https://api.github.com/repos/maidsafe/routing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maidsafe/routing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maidsafe/routing/git/refs{/sha}","trees_url":"https://api.github.com/repos/maidsafe/routing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maidsafe/routing/statuses/{sha}","languages_url":"https://api.github.com/repos/maidsafe/routing/languages","stargazers_url":"https://api.github.com/repos/maidsafe/routing/stargazers","contributors_url":"https://api.github.com/repos/maidsafe/routing/contributors","subscribers_url":"https://api.github.com/repos/maidsafe/routing/subscribers","subscription_url":"https://api.github.com/repos/maidsafe/routing/subscription","commits_url":"https://api.github.com/repos/maidsafe/routing/commits{/sha}","git_commits_url":"https://api.github.com/repos/maidsafe/routing/git/commits{/sha}","comments_url":"https://api.github.com/repos/maidsafe/routing/comments{/number}","issue_comment_url":"https://api.github.com/repos/maidsafe/routing/issues/comments{/number}","contents_url":"https://api.github.com/repos/maidsafe/routing/contents/{+path}","compare_url":"https://api.github.com/repos/maidsafe/routing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maidsafe/routing/merges","archive_url":"https://api.github.com/repos/maidsafe/routing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maidsafe/routing/downloads","issues_url":"https://api.github.com/repos/maidsafe/routing/issues{/number}","pulls_url":"https://api.github.com/repos/maidsafe/routing/pulls{/number}","milestones_url":"https://api.github.com/repos/maidsafe/routing/milestones{/number}","notifications_url":"https://api.github.com/repos/maidsafe/routing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maidsafe/routing/labels{/name}","releases_url":"https://api.github.com/repos/maidsafe/routing/releases{/id}","created_at":"2015-02-24T16:52:53Z","updated_at":"2015-06-10T01:00:41Z","pushed_at":"2015-06-10T12:52:33Z","git_url":"git://github.com/maidsafe/routing.git","ssh_url":"git@github.com:maidsafe/routing.git","clone_url":"https://github.com/maidsafe/routing.git","svn_url":"https://github.com/maidsafe/routing","homepage":null,"size":7224,"stargazers_count":18,"watchers_count":18,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":20,"mirror_url":null,"open_issues_count":25,"forks":20,"open_issues":25,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/maidsafe/routing/pulls/319"},"html":{"href":"https://github.com/maidsafe/routing/pull/319"},"issue":{"href":"https://api.github.com/repos/maidsafe/routing/issues/319"},"comments":{"href":"https://api.github.com/repos/maidsafe/routing/issues/319/comments"},"review_comments":{"href":"https://api.github.com/repos/maidsafe/routing/pulls/319/comments"},"review_comment":{"href":"https://api.github.com/repos/maidsafe/routing/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/maidsafe/routing/pulls/319/commits"},"statuses":{"href":"https://api.github.com/repos/maidsafe/routing/statuses/75568185d4f61c090429804f519099d5f502ba45"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":25,"deletions":13,"changed_files":2}}