{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/treeherder/pulls/comments/31391625","id":31391625,"diff_hunk":"@@ -158,17 +158,25 @@ logViewerApp.controller('LogviewerCtrl', [\n                 if(artifactList.length > 0){\n                     $scope.artifact = artifactList[0].blob;\n \n-                    var revision = $scope.artifact.header.revision.substr(0,12);\n-                    $scope.logRevisionFilterUrl = $scope.urlBasePath\n-                        + \"#/jobs?repo=\"\n-                        + $scope.repoName + \"&revision=\" + revision;\n-\n-                    // Store the artifact epoch date string in a real date object for use\n-                    var startTime = $scope.artifact.header.starttime;\n-                    var startDate = new Date(0);\n-                    startDate.setUTCSeconds(startTime);\n-\n-                    $scope.logDisplayDate = startDate.toString();\n+                    $scope.logProperties = _.map(\n+                        _.keys($scope.artifact.header).sort(), function(label) {\n+                            var value = $scope.artifact.header[label];\n+                            if (label === 'starttime') {\n+                                // present start time as a human readable date\n+                                var startDate = new Date(0);\n+                                startDate.setUTCSeconds(value);\n+                                value = startDate.toString();\n+                            }\n+                            return {label: label, value: value}\n+                        });\n+\n+                    // linkify revision\n+                    if ($scope.artifact.header.revision) {\n+                        var revision = $scope.artifact.header.revision.substr(0,12);\n+                        $scope.logRevisionFilterUrl = $scope.urlBasePath\n+                            + \"#/jobs?repo=\"\n+                            + $scope.repoName + \"&revision=\" + revision;","path":"ui/js/controllers/logviewer.js","position":32,"original_position":32,"commit_id":"5fe7ca5cb09b46b81ee8360d8b4ba3bbd67134c5","original_commit_id":"5fe7ca5cb09b46b81ee8360d8b4ba3bbd67134c5","user":{"login":"tojonmz","id":3660661,"avatar_url":"https://avatars.githubusercontent.com/u/3660661?v=3","gravatar_id":"","url":"https://api.github.com/users/tojonmz","html_url":"https://github.com/tojonmz","followers_url":"https://api.github.com/users/tojonmz/followers","following_url":"https://api.github.com/users/tojonmz/following{/other_user}","gists_url":"https://api.github.com/users/tojonmz/gists{/gist_id}","starred_url":"https://api.github.com/users/tojonmz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tojonmz/subscriptions","organizations_url":"https://api.github.com/users/tojonmz/orgs","repos_url":"https://api.github.com/users/tojonmz/repos","events_url":"https://api.github.com/users/tojonmz/events{/privacy}","received_events_url":"https://api.github.com/users/tojonmz/received_events","type":"User","site_admin":false},"body":"It's inherited from the existing code, but I wonder if [177-178] can be economized to a single line?\r\n\r\nI checked the style of gluing via leading `+`'s but current linters don't seem to complain :) Our oft referenced [style guide](http://google-styleguide.googlecode.com/svn/trunk/javascriptguide.xml#Code_formatting) seems to imply trailing `+`'s when wrapping, but I defer to you guys.","created_at":"2015-05-31T16:07:49Z","updated_at":"2015-05-31T16:07:49Z","html_url":"https://github.com/mozilla/treeherder/pull/581#discussion_r31391625","pull_request_url":"https://api.github.com/repos/mozilla/treeherder/pulls/581","_links":{"self":{"href":"https://api.github.com/repos/mozilla/treeherder/pulls/comments/31391625"},"html":{"href":"https://github.com/mozilla/treeherder/pull/581#discussion_r31391625"},"pull_request":{"href":"https://api.github.com/repos/mozilla/treeherder/pulls/581"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/treeherder/pulls/581","id":36544938,"html_url":"https://github.com/mozilla/treeherder/pull/581","diff_url":"https://github.com/mozilla/treeherder/pull/581.diff","patch_url":"https://github.com/mozilla/treeherder/pull/581.patch","issue_url":"https://api.github.com/repos/mozilla/treeherder/issues/581","number":581,"state":"open","locked":false,"title":" \tBug 1160082 - Log properties were unsorted with port to angular 1.4","user":{"login":"wlach","id":20569,"avatar_url":"https://avatars.githubusercontent.com/u/20569?v=3","gravatar_id":"","url":"https://api.github.com/users/wlach","html_url":"https://github.com/wlach","followers_url":"https://api.github.com/users/wlach/followers","following_url":"https://api.github.com/users/wlach/following{/other_user}","gists_url":"https://api.github.com/users/wlach/gists{/gist_id}","starred_url":"https://api.github.com/users/wlach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wlach/subscriptions","organizations_url":"https://api.github.com/users/wlach/orgs","repos_url":"https://api.github.com/users/wlach/repos","events_url":"https://api.github.com/users/wlach/events{/privacy}","received_events_url":"https://api.github.com/users/wlach/received_events","type":"User","site_admin":false},"body":"\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/mozilla/treeherder/581)\n<!-- Reviewable:end -->\n","created_at":"2015-05-29T21:05:17Z","updated_at":"2015-05-31T16:07:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"70e7d3f8b5b8d54dc71b488efe5457a94377c239","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/treeherder/pulls/581/commits","review_comments_url":"https://api.github.com/repos/mozilla/treeherder/pulls/581/comments","review_comment_url":"https://api.github.com/repos/mozilla/treeherder/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/treeherder/issues/581/comments","statuses_url":"https://api.github.com/repos/mozilla/treeherder/statuses/5fe7ca5cb09b46b81ee8360d8b4ba3bbd67134c5","head":{"label":"wlach:1160082","ref":"1160082","sha":"5fe7ca5cb09b46b81ee8360d8b4ba3bbd67134c5","user":{"login":"wlach","id":20569,"avatar_url":"https://avatars.githubusercontent.com/u/20569?v=3","gravatar_id":"","url":"https://api.github.com/users/wlach","html_url":"https://github.com/wlach","followers_url":"https://api.github.com/users/wlach/followers","following_url":"https://api.github.com/users/wlach/following{/other_user}","gists_url":"https://api.github.com/users/wlach/gists{/gist_id}","starred_url":"https://api.github.com/users/wlach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wlach/subscriptions","organizations_url":"https://api.github.com/users/wlach/orgs","repos_url":"https://api.github.com/users/wlach/repos","events_url":"https://api.github.com/users/wlach/events{/privacy}","received_events_url":"https://api.github.com/users/wlach/received_events","type":"User","site_admin":false},"repo":{"id":25893449,"name":"treeherder","full_name":"wlach/treeherder","owner":{"login":"wlach","id":20569,"avatar_url":"https://avatars.githubusercontent.com/u/20569?v=3","gravatar_id":"","url":"https://api.github.com/users/wlach","html_url":"https://github.com/wlach","followers_url":"https://api.github.com/users/wlach/followers","following_url":"https://api.github.com/users/wlach/following{/other_user}","gists_url":"https://api.github.com/users/wlach/gists{/gist_id}","starred_url":"https://api.github.com/users/wlach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wlach/subscriptions","organizations_url":"https://api.github.com/users/wlach/orgs","repos_url":"https://api.github.com/users/wlach/repos","events_url":"https://api.github.com/users/wlach/events{/privacy}","received_events_url":"https://api.github.com/users/wlach/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wlach/treeherder","description":"The backend of treeherder, a replacement for TBPL. See wiki page for where to file bugs.","fork":true,"url":"https://api.github.com/repos/wlach/treeherder","forks_url":"https://api.github.com/repos/wlach/treeherder/forks","keys_url":"https://api.github.com/repos/wlach/treeherder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wlach/treeherder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wlach/treeherder/teams","hooks_url":"https://api.github.com/repos/wlach/treeherder/hooks","issue_events_url":"https://api.github.com/repos/wlach/treeherder/issues/events{/number}","events_url":"https://api.github.com/repos/wlach/treeherder/events","assignees_url":"https://api.github.com/repos/wlach/treeherder/assignees{/user}","branches_url":"https://api.github.com/repos/wlach/treeherder/branches{/branch}","tags_url":"https://api.github.com/repos/wlach/treeherder/tags","blobs_url":"https://api.github.com/repos/wlach/treeherder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wlach/treeherder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wlach/treeherder/git/refs{/sha}","trees_url":"https://api.github.com/repos/wlach/treeherder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wlach/treeherder/statuses/{sha}","languages_url":"https://api.github.com/repos/wlach/treeherder/languages","stargazers_url":"https://api.github.com/repos/wlach/treeherder/stargazers","contributors_url":"https://api.github.com/repos/wlach/treeherder/contributors","subscribers_url":"https://api.github.com/repos/wlach/treeherder/subscribers","subscription_url":"https://api.github.com/repos/wlach/treeherder/subscription","commits_url":"https://api.github.com/repos/wlach/treeherder/commits{/sha}","git_commits_url":"https://api.github.com/repos/wlach/treeherder/git/commits{/sha}","comments_url":"https://api.github.com/repos/wlach/treeherder/comments{/number}","issue_comment_url":"https://api.github.com/repos/wlach/treeherder/issues/comments{/number}","contents_url":"https://api.github.com/repos/wlach/treeherder/contents/{+path}","compare_url":"https://api.github.com/repos/wlach/treeherder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wlach/treeherder/merges","archive_url":"https://api.github.com/repos/wlach/treeherder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wlach/treeherder/downloads","issues_url":"https://api.github.com/repos/wlach/treeherder/issues{/number}","pulls_url":"https://api.github.com/repos/wlach/treeherder/pulls{/number}","milestones_url":"https://api.github.com/repos/wlach/treeherder/milestones{/number}","notifications_url":"https://api.github.com/repos/wlach/treeherder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wlach/treeherder/labels{/name}","releases_url":"https://api.github.com/repos/wlach/treeherder/releases{/id}","created_at":"2014-10-28T22:37:53Z","updated_at":"2015-04-29T20:36:16Z","pushed_at":"2015-05-29T21:28:24Z","git_url":"git://github.com/wlach/treeherder.git","ssh_url":"git@github.com:wlach/treeherder.git","clone_url":"https://github.com/wlach/treeherder.git","svn_url":"https://github.com/wlach/treeherder","homepage":"https://wiki.mozilla.org/Auto-tools/Projects/Treeherder","size":29862,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"d5ae8deb9f041ce538eee1a5d8d05c60f09e56be","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":8463294,"name":"treeherder","full_name":"mozilla/treeherder","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/treeherder","description":"The backend of treeherder, a replacement for TBPL. See wiki page for where to file bugs.","fork":false,"url":"https://api.github.com/repos/mozilla/treeherder","forks_url":"https://api.github.com/repos/mozilla/treeherder/forks","keys_url":"https://api.github.com/repos/mozilla/treeherder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/treeherder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/treeherder/teams","hooks_url":"https://api.github.com/repos/mozilla/treeherder/hooks","issue_events_url":"https://api.github.com/repos/mozilla/treeherder/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/treeherder/events","assignees_url":"https://api.github.com/repos/mozilla/treeherder/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/treeherder/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/treeherder/tags","blobs_url":"https://api.github.com/repos/mozilla/treeherder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/treeherder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/treeherder/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/treeherder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/treeherder/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/treeherder/languages","stargazers_url":"https://api.github.com/repos/mozilla/treeherder/stargazers","contributors_url":"https://api.github.com/repos/mozilla/treeherder/contributors","subscribers_url":"https://api.github.com/repos/mozilla/treeherder/subscribers","subscription_url":"https://api.github.com/repos/mozilla/treeherder/subscription","commits_url":"https://api.github.com/repos/mozilla/treeherder/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/treeherder/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/treeherder/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/treeherder/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/treeherder/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/treeherder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/treeherder/merges","archive_url":"https://api.github.com/repos/mozilla/treeherder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/treeherder/downloads","issues_url":"https://api.github.com/repos/mozilla/treeherder/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/treeherder/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/treeherder/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/treeherder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/treeherder/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/treeherder/releases{/id}","created_at":"2013-02-27T19:17:37Z","updated_at":"2015-05-27T14:17:58Z","pushed_at":"2015-05-31T13:16:27Z","git_url":"git://github.com/mozilla/treeherder.git","ssh_url":"git@github.com:mozilla/treeherder.git","clone_url":"https://github.com/mozilla/treeherder.git","svn_url":"https://github.com/mozilla/treeherder","homepage":"https://wiki.mozilla.org/Auto-tools/Projects/Treeherder","size":394605,"stargazers_count":19,"watchers_count":19,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":42,"mirror_url":null,"open_issues_count":17,"forks":42,"open_issues":17,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/treeherder/pulls/581"},"html":{"href":"https://github.com/mozilla/treeherder/pull/581"},"issue":{"href":"https://api.github.com/repos/mozilla/treeherder/issues/581"},"comments":{"href":"https://api.github.com/repos/mozilla/treeherder/issues/581/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/treeherder/pulls/581/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/treeherder/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/treeherder/pulls/581/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/treeherder/statuses/5fe7ca5cb09b46b81ee8360d8b4ba3bbd67134c5"}}}}