{"action":"created","issue":{"url":"https://api.github.com/repos/OmniLayer/omnicore/issues/16","labels_url":"https://api.github.com/repos/OmniLayer/omnicore/issues/16/labels{/name}","comments_url":"https://api.github.com/repos/OmniLayer/omnicore/issues/16/comments","events_url":"https://api.github.com/repos/OmniLayer/omnicore/issues/16/events","html_url":"https://github.com/OmniLayer/omnicore/pull/16","id":68020445,"number":16,"title":"Move project files into src/omnicore","user":{"login":"dexX7","id":5836089,"avatar_url":"https://avatars.githubusercontent.com/u/5836089?v=3","gravatar_id":"","url":"https://api.github.com/users/dexX7","html_url":"https://github.com/dexX7","followers_url":"https://api.github.com/users/dexX7/followers","following_url":"https://api.github.com/users/dexX7/following{/other_user}","gists_url":"https://api.github.com/users/dexX7/gists{/gist_id}","starred_url":"https://api.github.com/users/dexX7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dexX7/subscriptions","organizations_url":"https://api.github.com/users/dexX7/orgs","repos_url":"https://api.github.com/users/dexX7/repos","events_url":"https://api.github.com/users/dexX7/events{/privacy}","received_events_url":"https://api.github.com/users/dexX7/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/OmniLayer/omnicore/labels/request%20for%20comments","name":"request for comments","color":"fbca04"},{"url":"https://api.github.com/repos/OmniLayer/omnicore/labels/work%20in%20progress","name":"work in progress","color":"207de5"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-04-13T06:42:29Z","updated_at":"2015-04-16T00:51:03Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/OmniLayer/omnicore/pulls/16","html_url":"https://github.com/OmniLayer/omnicore/pull/16","diff_url":"https://github.com/OmniLayer/omnicore/pull/16.diff","patch_url":"https://github.com/OmniLayer/omnicore/pull/16.patch"},"body":"As result of the previous discussion, this PR moves the Omni Core files into `src/omnicore` and `src/omnicore/test`, without `mastercore_` or `omnicore_` file prefix.\r\n\r\nAdditional grouping within the subdir would probably make sense, and in the longer run I could imagine to split files and have less classes per file, for example in the case of the traditional DEx and meta DEx, or to have a dedicated file solely for transaction decoding, and another one for the actual logic.\r\n\r\nI wouldn't prioritize this, but it should visualize the changes and the file structure:\r\n\r\n- https://github.com/dexX7/bitcoin/tree/oc-0.10-project-move-subdir/src/omnicore\r\n\r\nThe QT files should probably live in `src/omnicore/qt`, but I'm not 100 % sure at this point, how well this can be integrated.\r\n\r\nAlternatively, it could also be possible to move the files early, then integrate #13, but leave all UI and QT files in `src/qt`, to reduce the impact, and address it later. Nevertheless it would be required to update the `mastercore_` references, and maybe resolve other conflicts.\r\n\r\nWhile I could convert #13, I assume getting this in significantly affects the UI development, and unless @zathras-crypto thinks it would absolutely be no issue, I suggest to just move the discussion from #15 to this place, and postpone the actual move, given that it's only \"nice to have\", but without immediat gain."},"comment":{"url":"https://api.github.com/repos/OmniLayer/omnicore/issues/comments/93607985","html_url":"https://github.com/OmniLayer/omnicore/pull/16#issuecomment-93607985","issue_url":"https://api.github.com/repos/OmniLayer/omnicore/issues/16","id":93607985,"user":{"login":"zathras-crypto","id":5633351,"avatar_url":"https://avatars.githubusercontent.com/u/5633351?v=3","gravatar_id":"","url":"https://api.github.com/users/zathras-crypto","html_url":"https://github.com/zathras-crypto","followers_url":"https://api.github.com/users/zathras-crypto/followers","following_url":"https://api.github.com/users/zathras-crypto/following{/other_user}","gists_url":"https://api.github.com/users/zathras-crypto/gists{/gist_id}","starred_url":"https://api.github.com/users/zathras-crypto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zathras-crypto/subscriptions","organizations_url":"https://api.github.com/users/zathras-crypto/orgs","repos_url":"https://api.github.com/users/zathras-crypto/repos","events_url":"https://api.github.com/users/zathras-crypto/events{/privacy}","received_events_url":"https://api.github.com/users/zathras-crypto/received_events","type":"User","site_admin":false},"created_at":"2015-04-16T00:51:03Z","updated_at":"2015-04-16T00:51:03Z","body":"Sorry, must have missed commenting on this - I support the idea - re the UI I don't think it would be too much of a hardship to fix that up to respect the new naming convention :)"}}