{"action":"created","comment":{"url":"https://api.github.com/repos/spring-projects/spring-xd/pulls/comments/28202775","id":28202775,"diff_hunk":"@@ -0,0 +1,33 @@\n+<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n+<beans:beans xmlns=\"http://www.springframework.org/schema/integration\"\n+\txmlns:xsi=\"http://www.w3.org/2001/XMLSchema-instance\" \n+\txmlns:beans=\"http://www.springframework.org/schema/beans\"\n+\txmlns:int-ftp=\"http://www.springframework.org/schema/integration/ftp\"\n+\txsi:schemaLocation=\"http://www.springframework.org/schema/beans\n+\t\thttp://www.springframework.org/schema/beans/spring-beans.xsd\n+\t\thttp://www.springframework.org/schema/integration\n+\t\thttp://www.springframework.org/schema/integration/spring-integration.xsd\n+\t\thttp://www.springframework.org/schema/integration/ftp\n+\t\thttp://www.springframework.org/schema/integration/ftp/spring-integration-ftp.xsd\">\n+\n+\t<beans:bean id=\"ftpSessionFactory\" class=\"org.springframework.integration.ftp.session.DefaultFtpSessionFactory\">\n+\t\t<beans:property name=\"host\" value=\"${host:localhost}\" />\n+        \t<beans:property name=\"port\" value=\"${port:21}\" />\n+        \t<beans:property name=\"username\" value=\"${username}\"/>\n+        \t<beans:property name=\"password\" value=\"${password}\"/>\n+        \t<beans:property name=\"clientMode\" value=\"${clientMode:0}\"/>\n+\t</beans:bean>\n+\n+\t<int-ftp:inbound-channel-adapter auto-startup=\"true\" channel=\"output\" session-factory=\"ftpSessionFactory\"\n+\t\tfilename-pattern=\"${filenamePattern:*}\" remote-directory=\"${remoteDir}\" local-directory=\"${localDir:/tmp/xd/output}\"","path":"modules/source/ftp/config/ftp.xml","position":22,"original_position":22,"commit_id":"1301897bbc21755b9650473dda4d46a3b1956ef5","original_commit_id":"1301897bbc21755b9650473dda4d46a3b1956ef5","user":{"login":"ericbottard","id":313494,"avatar_url":"https://avatars.githubusercontent.com/u/313494?v=3","gravatar_id":"","url":"https://api.github.com/users/ericbottard","html_url":"https://github.com/ericbottard","followers_url":"https://api.github.com/users/ericbottard/followers","following_url":"https://api.github.com/users/ericbottard/following{/other_user}","gists_url":"https://api.github.com/users/ericbottard/gists{/gist_id}","starred_url":"https://api.github.com/users/ericbottard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericbottard/subscriptions","organizations_url":"https://api.github.com/users/ericbottard/orgs","repos_url":"https://api.github.com/users/ericbottard/repos","events_url":"https://api.github.com/users/ericbottard/events{/privacy}","received_events_url":"https://api.github.com/users/ericbottard/received_events","type":"User","site_admin":false},"body":"Try to provide as much sensible defaults as possible. A common pattern in XD is to use the stream name as a distinguisher for directories for example (this would apply here to remote and local dir)","created_at":"2015-04-12T11:43:46Z","updated_at":"2015-04-12T11:43:46Z","html_url":"https://github.com/spring-projects/spring-xd/pull/1554#discussion_r28202775","pull_request_url":"https://api.github.com/repos/spring-projects/spring-xd/pulls/1554","_links":{"self":{"href":"https://api.github.com/repos/spring-projects/spring-xd/pulls/comments/28202775"},"html":{"href":"https://github.com/spring-projects/spring-xd/pull/1554#discussion_r28202775"},"pull_request":{"href":"https://api.github.com/repos/spring-projects/spring-xd/pulls/1554"}}},"pull_request":{"url":"https://api.github.com/repos/spring-projects/spring-xd/pulls/1554","id":33111307,"html_url":"https://github.com/spring-projects/spring-xd/pull/1554","diff_url":"https://github.com/spring-projects/spring-xd/pull/1554.diff","patch_url":"https://github.com/spring-projects/spring-xd/pull/1554.patch","issue_url":"https://api.github.com/repos/spring-projects/spring-xd/issues/1554","number":1554,"state":"open","locked":false,"title":"XD-2942 - add ftp source module","user":{"login":"fmarchand","id":3935306,"avatar_url":"https://avatars.githubusercontent.com/u/3935306?v=3","gravatar_id":"","url":"https://api.github.com/users/fmarchand","html_url":"https://github.com/fmarchand","followers_url":"https://api.github.com/users/fmarchand/followers","following_url":"https://api.github.com/users/fmarchand/following{/other_user}","gists_url":"https://api.github.com/users/fmarchand/gists{/gist_id}","starred_url":"https://api.github.com/users/fmarchand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fmarchand/subscriptions","organizations_url":"https://api.github.com/users/fmarchand/orgs","repos_url":"https://api.github.com/users/fmarchand/repos","events_url":"https://api.github.com/users/fmarchand/events{/privacy}","received_events_url":"https://api.github.com/users/fmarchand/received_events","type":"User","site_admin":false},"body":"I have signed and agree to the terms of the SpringSource Individual\r\nContributor License Agreement.\r\n\r\nTell me if I forgot something. Thx","created_at":"2015-04-11T22:44:02Z","updated_at":"2015-04-12T11:43:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d5805f7b24b7e575d004f835434a26347fec3f2d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/spring-projects/spring-xd/pulls/1554/commits","review_comments_url":"https://api.github.com/repos/spring-projects/spring-xd/pulls/1554/comments","review_comment_url":"https://api.github.com/repos/spring-projects/spring-xd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spring-projects/spring-xd/issues/1554/comments","statuses_url":"https://api.github.com/repos/spring-projects/spring-xd/statuses/1301897bbc21755b9650473dda4d46a3b1956ef5","head":{"label":"fmarchand:XD-2942","ref":"XD-2942","sha":"1301897bbc21755b9650473dda4d46a3b1956ef5","user":{"login":"fmarchand","id":3935306,"avatar_url":"https://avatars.githubusercontent.com/u/3935306?v=3","gravatar_id":"","url":"https://api.github.com/users/fmarchand","html_url":"https://github.com/fmarchand","followers_url":"https://api.github.com/users/fmarchand/followers","following_url":"https://api.github.com/users/fmarchand/following{/other_user}","gists_url":"https://api.github.com/users/fmarchand/gists{/gist_id}","starred_url":"https://api.github.com/users/fmarchand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fmarchand/subscriptions","organizations_url":"https://api.github.com/users/fmarchand/orgs","repos_url":"https://api.github.com/users/fmarchand/repos","events_url":"https://api.github.com/users/fmarchand/events{/privacy}","received_events_url":"https://api.github.com/users/fmarchand/received_events","type":"User","site_admin":false},"repo":{"id":23961942,"name":"spring-xd","full_name":"fmarchand/spring-xd","owner":{"login":"fmarchand","id":3935306,"avatar_url":"https://avatars.githubusercontent.com/u/3935306?v=3","gravatar_id":"","url":"https://api.github.com/users/fmarchand","html_url":"https://github.com/fmarchand","followers_url":"https://api.github.com/users/fmarchand/followers","following_url":"https://api.github.com/users/fmarchand/following{/other_user}","gists_url":"https://api.github.com/users/fmarchand/gists{/gist_id}","starred_url":"https://api.github.com/users/fmarchand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fmarchand/subscriptions","organizations_url":"https://api.github.com/users/fmarchand/orgs","repos_url":"https://api.github.com/users/fmarchand/repos","events_url":"https://api.github.com/users/fmarchand/events{/privacy}","received_events_url":"https://api.github.com/users/fmarchand/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fmarchand/spring-xd","description":"Spring XD makes it easy to solve common big data problems such as data ingestion and export, real-time analytics, and batch workflow orchestration","fork":true,"url":"https://api.github.com/repos/fmarchand/spring-xd","forks_url":"https://api.github.com/repos/fmarchand/spring-xd/forks","keys_url":"https://api.github.com/repos/fmarchand/spring-xd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fmarchand/spring-xd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fmarchand/spring-xd/teams","hooks_url":"https://api.github.com/repos/fmarchand/spring-xd/hooks","issue_events_url":"https://api.github.com/repos/fmarchand/spring-xd/issues/events{/number}","events_url":"https://api.github.com/repos/fmarchand/spring-xd/events","assignees_url":"https://api.github.com/repos/fmarchand/spring-xd/assignees{/user}","branches_url":"https://api.github.com/repos/fmarchand/spring-xd/branches{/branch}","tags_url":"https://api.github.com/repos/fmarchand/spring-xd/tags","blobs_url":"https://api.github.com/repos/fmarchand/spring-xd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fmarchand/spring-xd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fmarchand/spring-xd/git/refs{/sha}","trees_url":"https://api.github.com/repos/fmarchand/spring-xd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fmarchand/spring-xd/statuses/{sha}","languages_url":"https://api.github.com/repos/fmarchand/spring-xd/languages","stargazers_url":"https://api.github.com/repos/fmarchand/spring-xd/stargazers","contributors_url":"https://api.github.com/repos/fmarchand/spring-xd/contributors","subscribers_url":"https://api.github.com/repos/fmarchand/spring-xd/subscribers","subscription_url":"https://api.github.com/repos/fmarchand/spring-xd/subscription","commits_url":"https://api.github.com/repos/fmarchand/spring-xd/commits{/sha}","git_commits_url":"https://api.github.com/repos/fmarchand/spring-xd/git/commits{/sha}","comments_url":"https://api.github.com/repos/fmarchand/spring-xd/comments{/number}","issue_comment_url":"https://api.github.com/repos/fmarchand/spring-xd/issues/comments{/number}","contents_url":"https://api.github.com/repos/fmarchand/spring-xd/contents/{+path}","compare_url":"https://api.github.com/repos/fmarchand/spring-xd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fmarchand/spring-xd/merges","archive_url":"https://api.github.com/repos/fmarchand/spring-xd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fmarchand/spring-xd/downloads","issues_url":"https://api.github.com/repos/fmarchand/spring-xd/issues{/number}","pulls_url":"https://api.github.com/repos/fmarchand/spring-xd/pulls{/number}","milestones_url":"https://api.github.com/repos/fmarchand/spring-xd/milestones{/number}","notifications_url":"https://api.github.com/repos/fmarchand/spring-xd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fmarchand/spring-xd/labels{/name}","releases_url":"https://api.github.com/repos/fmarchand/spring-xd/releases{/id}","created_at":"2014-09-12T13:34:56Z","updated_at":"2015-04-10T18:58:25Z","pushed_at":"2015-04-11T22:39:35Z","git_url":"git://github.com/fmarchand/spring-xd.git","ssh_url":"git@github.com:fmarchand/spring-xd.git","clone_url":"https://github.com/fmarchand/spring-xd.git","svn_url":"https://github.com/fmarchand/spring-xd","homepage":"http://projects.spring.io/spring-xd","size":21340,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spring-projects:master","ref":"master","sha":"fdcccd867c67eb71ef61a06fe6cc78be54660ad8","user":{"login":"spring-projects","id":317776,"avatar_url":"https://avatars.githubusercontent.com/u/317776?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-projects","html_url":"https://github.com/spring-projects","followers_url":"https://api.github.com/users/spring-projects/followers","following_url":"https://api.github.com/users/spring-projects/following{/other_user}","gists_url":"https://api.github.com/users/spring-projects/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-projects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-projects/subscriptions","organizations_url":"https://api.github.com/users/spring-projects/orgs","repos_url":"https://api.github.com/users/spring-projects/repos","events_url":"https://api.github.com/users/spring-projects/events{/privacy}","received_events_url":"https://api.github.com/users/spring-projects/received_events","type":"Organization","site_admin":false},"repo":{"id":9349347,"name":"spring-xd","full_name":"spring-projects/spring-xd","owner":{"login":"spring-projects","id":317776,"avatar_url":"https://avatars.githubusercontent.com/u/317776?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-projects","html_url":"https://github.com/spring-projects","followers_url":"https://api.github.com/users/spring-projects/followers","following_url":"https://api.github.com/users/spring-projects/following{/other_user}","gists_url":"https://api.github.com/users/spring-projects/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-projects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-projects/subscriptions","organizations_url":"https://api.github.com/users/spring-projects/orgs","repos_url":"https://api.github.com/users/spring-projects/repos","events_url":"https://api.github.com/users/spring-projects/events{/privacy}","received_events_url":"https://api.github.com/users/spring-projects/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spring-projects/spring-xd","description":"Spring XD makes it easy to solve common big data problems such as data ingestion and export, real-time analytics, and batch workflow orchestration","fork":false,"url":"https://api.github.com/repos/spring-projects/spring-xd","forks_url":"https://api.github.com/repos/spring-projects/spring-xd/forks","keys_url":"https://api.github.com/repos/spring-projects/spring-xd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spring-projects/spring-xd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spring-projects/spring-xd/teams","hooks_url":"https://api.github.com/repos/spring-projects/spring-xd/hooks","issue_events_url":"https://api.github.com/repos/spring-projects/spring-xd/issues/events{/number}","events_url":"https://api.github.com/repos/spring-projects/spring-xd/events","assignees_url":"https://api.github.com/repos/spring-projects/spring-xd/assignees{/user}","branches_url":"https://api.github.com/repos/spring-projects/spring-xd/branches{/branch}","tags_url":"https://api.github.com/repos/spring-projects/spring-xd/tags","blobs_url":"https://api.github.com/repos/spring-projects/spring-xd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spring-projects/spring-xd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spring-projects/spring-xd/git/refs{/sha}","trees_url":"https://api.github.com/repos/spring-projects/spring-xd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spring-projects/spring-xd/statuses/{sha}","languages_url":"https://api.github.com/repos/spring-projects/spring-xd/languages","stargazers_url":"https://api.github.com/repos/spring-projects/spring-xd/stargazers","contributors_url":"https://api.github.com/repos/spring-projects/spring-xd/contributors","subscribers_url":"https://api.github.com/repos/spring-projects/spring-xd/subscribers","subscription_url":"https://api.github.com/repos/spring-projects/spring-xd/subscription","commits_url":"https://api.github.com/repos/spring-projects/spring-xd/commits{/sha}","git_commits_url":"https://api.github.com/repos/spring-projects/spring-xd/git/commits{/sha}","comments_url":"https://api.github.com/repos/spring-projects/spring-xd/comments{/number}","issue_comment_url":"https://api.github.com/repos/spring-projects/spring-xd/issues/comments{/number}","contents_url":"https://api.github.com/repos/spring-projects/spring-xd/contents/{+path}","compare_url":"https://api.github.com/repos/spring-projects/spring-xd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spring-projects/spring-xd/merges","archive_url":"https://api.github.com/repos/spring-projects/spring-xd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spring-projects/spring-xd/downloads","issues_url":"https://api.github.com/repos/spring-projects/spring-xd/issues{/number}","pulls_url":"https://api.github.com/repos/spring-projects/spring-xd/pulls{/number}","milestones_url":"https://api.github.com/repos/spring-projects/spring-xd/milestones{/number}","notifications_url":"https://api.github.com/repos/spring-projects/spring-xd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spring-projects/spring-xd/labels{/name}","releases_url":"https://api.github.com/repos/spring-projects/spring-xd/releases{/id}","created_at":"2013-04-10T15:31:44Z","updated_at":"2015-04-10T19:00:58Z","pushed_at":"2015-04-11T22:44:02Z","git_url":"git://github.com/spring-projects/spring-xd.git","ssh_url":"git@github.com:spring-projects/spring-xd.git","clone_url":"https://github.com/spring-projects/spring-xd.git","svn_url":"https://github.com/spring-projects/spring-xd","homepage":"http://projects.spring.io/spring-xd","size":58631,"stargazers_count":247,"watchers_count":247,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":194,"mirror_url":null,"open_issues_count":35,"forks":194,"open_issues":35,"watchers":247,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spring-projects/spring-xd/pulls/1554"},"html":{"href":"https://github.com/spring-projects/spring-xd/pull/1554"},"issue":{"href":"https://api.github.com/repos/spring-projects/spring-xd/issues/1554"},"comments":{"href":"https://api.github.com/repos/spring-projects/spring-xd/issues/1554/comments"},"review_comments":{"href":"https://api.github.com/repos/spring-projects/spring-xd/pulls/1554/comments"},"review_comment":{"href":"https://api.github.com/repos/spring-projects/spring-xd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spring-projects/spring-xd/pulls/1554/commits"},"statuses":{"href":"https://api.github.com/repos/spring-projects/spring-xd/statuses/1301897bbc21755b9650473dda4d46a3b1956ef5"}}}}