{"action":"closed","number":5,"pull_request":{"url":"https://api.github.com/repos/cucumber/gherkin3/pulls/5","id":30993066,"html_url":"https://github.com/cucumber/gherkin3/pull/5","diff_url":"https://github.com/cucumber/gherkin3/pull/5.diff","patch_url":"https://github.com/cucumber/gherkin3/pull/5.patch","issue_url":"https://api.github.com/repos/cucumber/gherkin3/issues/5","number":5,"state":"closed","locked":false,"title":"Removed dependency on info.cukes:gherkin-jvm-deps and placed GenerateAst under test","user":{"login":"tsundberg","id":541840,"avatar_url":"https://avatars.githubusercontent.com/u/541840?v=3","gravatar_id":"","url":"https://api.github.com/users/tsundberg","html_url":"https://github.com/tsundberg","followers_url":"https://api.github.com/users/tsundberg/followers","following_url":"https://api.github.com/users/tsundberg/following{/other_user}","gists_url":"https://api.github.com/users/tsundberg/gists{/gist_id}","starred_url":"https://api.github.com/users/tsundberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsundberg/subscriptions","organizations_url":"https://api.github.com/users/tsundberg/orgs","repos_url":"https://api.github.com/users/tsundberg/repos","events_url":"https://api.github.com/users/tsundberg/events{/privacy}","received_events_url":"https://api.github.com/users/tsundberg/received_events","type":"User","site_admin":false},"body":"I am not sure if it was this way you intended to remove the dependency on info.cukes:gherkin-jvm-deps, but it is one way to do it.\r\n\r\nWhile I was at it, I added some unit tests for GenerateAst and noticed that I think there are two bugs. There are two cases where a NullPointerException is thrown when the bad features are parsed. I am pretty certain that it should be some other exception. I am, however, not entirely sure where these other exceptions should be thrown. Look into the GenerateAstTest and you will see that NullPointerException is expected for two tests. This feels very wrong, but it is a documentation on the current behavior.","created_at":"2015-03-11T22:46:32Z","updated_at":"2015-03-12T21:24:28Z","closed_at":"2015-03-12T21:24:28Z","merged_at":null,"merge_commit_sha":"c124493d57633f375e6d7b4c775c8b81bdba86fd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cucumber/gherkin3/pulls/5/commits","review_comments_url":"https://api.github.com/repos/cucumber/gherkin3/pulls/5/comments","review_comment_url":"https://api.github.com/repos/cucumber/gherkin3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cucumber/gherkin3/issues/5/comments","statuses_url":"https://api.github.com/repos/cucumber/gherkin3/statuses/a0e8bec1b9288516c062e97e084ad697b0f4f254","head":{"label":"tsundberg:master","ref":"master","sha":"a0e8bec1b9288516c062e97e084ad697b0f4f254","user":{"login":"tsundberg","id":541840,"avatar_url":"https://avatars.githubusercontent.com/u/541840?v=3","gravatar_id":"","url":"https://api.github.com/users/tsundberg","html_url":"https://github.com/tsundberg","followers_url":"https://api.github.com/users/tsundberg/followers","following_url":"https://api.github.com/users/tsundberg/following{/other_user}","gists_url":"https://api.github.com/users/tsundberg/gists{/gist_id}","starred_url":"https://api.github.com/users/tsundberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsundberg/subscriptions","organizations_url":"https://api.github.com/users/tsundberg/orgs","repos_url":"https://api.github.com/users/tsundberg/repos","events_url":"https://api.github.com/users/tsundberg/events{/privacy}","received_events_url":"https://api.github.com/users/tsundberg/received_events","type":"User","site_admin":false},"repo":{"id":32042094,"name":"gherkin3","full_name":"tsundberg/gherkin3","owner":{"login":"tsundberg","id":541840,"avatar_url":"https://avatars.githubusercontent.com/u/541840?v=3","gravatar_id":"","url":"https://api.github.com/users/tsundberg","html_url":"https://github.com/tsundberg","followers_url":"https://api.github.com/users/tsundberg/followers","following_url":"https://api.github.com/users/tsundberg/following{/other_user}","gists_url":"https://api.github.com/users/tsundberg/gists{/gist_id}","starred_url":"https://api.github.com/users/tsundberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsundberg/subscriptions","organizations_url":"https://api.github.com/users/tsundberg/orgs","repos_url":"https://api.github.com/users/tsundberg/repos","events_url":"https://api.github.com/users/tsundberg/events{/privacy}","received_events_url":"https://api.github.com/users/tsundberg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tsundberg/gherkin3","description":"Cross platform parser for the Gherkin language. Used by Cucumber to parse .feature files.","fork":true,"url":"https://api.github.com/repos/tsundberg/gherkin3","forks_url":"https://api.github.com/repos/tsundberg/gherkin3/forks","keys_url":"https://api.github.com/repos/tsundberg/gherkin3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tsundberg/gherkin3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tsundberg/gherkin3/teams","hooks_url":"https://api.github.com/repos/tsundberg/gherkin3/hooks","issue_events_url":"https://api.github.com/repos/tsundberg/gherkin3/issues/events{/number}","events_url":"https://api.github.com/repos/tsundberg/gherkin3/events","assignees_url":"https://api.github.com/repos/tsundberg/gherkin3/assignees{/user}","branches_url":"https://api.github.com/repos/tsundberg/gherkin3/branches{/branch}","tags_url":"https://api.github.com/repos/tsundberg/gherkin3/tags","blobs_url":"https://api.github.com/repos/tsundberg/gherkin3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tsundberg/gherkin3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tsundberg/gherkin3/git/refs{/sha}","trees_url":"https://api.github.com/repos/tsundberg/gherkin3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tsundberg/gherkin3/statuses/{sha}","languages_url":"https://api.github.com/repos/tsundberg/gherkin3/languages","stargazers_url":"https://api.github.com/repos/tsundberg/gherkin3/stargazers","contributors_url":"https://api.github.com/repos/tsundberg/gherkin3/contributors","subscribers_url":"https://api.github.com/repos/tsundberg/gherkin3/subscribers","subscription_url":"https://api.github.com/repos/tsundberg/gherkin3/subscription","commits_url":"https://api.github.com/repos/tsundberg/gherkin3/commits{/sha}","git_commits_url":"https://api.github.com/repos/tsundberg/gherkin3/git/commits{/sha}","comments_url":"https://api.github.com/repos/tsundberg/gherkin3/comments{/number}","issue_comment_url":"https://api.github.com/repos/tsundberg/gherkin3/issues/comments{/number}","contents_url":"https://api.github.com/repos/tsundberg/gherkin3/contents/{+path}","compare_url":"https://api.github.com/repos/tsundberg/gherkin3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tsundberg/gherkin3/merges","archive_url":"https://api.github.com/repos/tsundberg/gherkin3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tsundberg/gherkin3/downloads","issues_url":"https://api.github.com/repos/tsundberg/gherkin3/issues{/number}","pulls_url":"https://api.github.com/repos/tsundberg/gherkin3/pulls{/number}","milestones_url":"https://api.github.com/repos/tsundberg/gherkin3/milestones{/number}","notifications_url":"https://api.github.com/repos/tsundberg/gherkin3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tsundberg/gherkin3/labels{/name}","releases_url":"https://api.github.com/repos/tsundberg/gherkin3/releases{/id}","created_at":"2015-03-11T21:26:33Z","updated_at":"2015-03-11T22:37:17Z","pushed_at":"2015-03-11T22:37:16Z","git_url":"git://github.com/tsundberg/gherkin3.git","ssh_url":"git@github.com:tsundberg/gherkin3.git","clone_url":"https://github.com/tsundberg/gherkin3.git","svn_url":"https://github.com/tsundberg/gherkin3","homepage":null,"size":2510,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cucumber:master","ref":"master","sha":"8fba62aa2f485261251f53935291de04307c6c77","user":{"login":"cucumber","id":320565,"avatar_url":"https://avatars.githubusercontent.com/u/320565?v=3","gravatar_id":"","url":"https://api.github.com/users/cucumber","html_url":"https://github.com/cucumber","followers_url":"https://api.github.com/users/cucumber/followers","following_url":"https://api.github.com/users/cucumber/following{/other_user}","gists_url":"https://api.github.com/users/cucumber/gists{/gist_id}","starred_url":"https://api.github.com/users/cucumber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cucumber/subscriptions","organizations_url":"https://api.github.com/users/cucumber/orgs","repos_url":"https://api.github.com/users/cucumber/repos","events_url":"https://api.github.com/users/cucumber/events{/privacy}","received_events_url":"https://api.github.com/users/cucumber/received_events","type":"Organization","site_admin":false},"repo":{"id":17832726,"name":"gherkin3","full_name":"cucumber/gherkin3","owner":{"login":"cucumber","id":320565,"avatar_url":"https://avatars.githubusercontent.com/u/320565?v=3","gravatar_id":"","url":"https://api.github.com/users/cucumber","html_url":"https://github.com/cucumber","followers_url":"https://api.github.com/users/cucumber/followers","following_url":"https://api.github.com/users/cucumber/following{/other_user}","gists_url":"https://api.github.com/users/cucumber/gists{/gist_id}","starred_url":"https://api.github.com/users/cucumber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cucumber/subscriptions","organizations_url":"https://api.github.com/users/cucumber/orgs","repos_url":"https://api.github.com/users/cucumber/repos","events_url":"https://api.github.com/users/cucumber/events{/privacy}","received_events_url":"https://api.github.com/users/cucumber/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cucumber/gherkin3","description":"Cross platform parser for the Gherkin language. Used by Cucumber to parse .feature files.","fork":false,"url":"https://api.github.com/repos/cucumber/gherkin3","forks_url":"https://api.github.com/repos/cucumber/gherkin3/forks","keys_url":"https://api.github.com/repos/cucumber/gherkin3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cucumber/gherkin3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cucumber/gherkin3/teams","hooks_url":"https://api.github.com/repos/cucumber/gherkin3/hooks","issue_events_url":"https://api.github.com/repos/cucumber/gherkin3/issues/events{/number}","events_url":"https://api.github.com/repos/cucumber/gherkin3/events","assignees_url":"https://api.github.com/repos/cucumber/gherkin3/assignees{/user}","branches_url":"https://api.github.com/repos/cucumber/gherkin3/branches{/branch}","tags_url":"https://api.github.com/repos/cucumber/gherkin3/tags","blobs_url":"https://api.github.com/repos/cucumber/gherkin3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cucumber/gherkin3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cucumber/gherkin3/git/refs{/sha}","trees_url":"https://api.github.com/repos/cucumber/gherkin3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cucumber/gherkin3/statuses/{sha}","languages_url":"https://api.github.com/repos/cucumber/gherkin3/languages","stargazers_url":"https://api.github.com/repos/cucumber/gherkin3/stargazers","contributors_url":"https://api.github.com/repos/cucumber/gherkin3/contributors","subscribers_url":"https://api.github.com/repos/cucumber/gherkin3/subscribers","subscription_url":"https://api.github.com/repos/cucumber/gherkin3/subscription","commits_url":"https://api.github.com/repos/cucumber/gherkin3/commits{/sha}","git_commits_url":"https://api.github.com/repos/cucumber/gherkin3/git/commits{/sha}","comments_url":"https://api.github.com/repos/cucumber/gherkin3/comments{/number}","issue_comment_url":"https://api.github.com/repos/cucumber/gherkin3/issues/comments{/number}","contents_url":"https://api.github.com/repos/cucumber/gherkin3/contents/{+path}","compare_url":"https://api.github.com/repos/cucumber/gherkin3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cucumber/gherkin3/merges","archive_url":"https://api.github.com/repos/cucumber/gherkin3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cucumber/gherkin3/downloads","issues_url":"https://api.github.com/repos/cucumber/gherkin3/issues{/number}","pulls_url":"https://api.github.com/repos/cucumber/gherkin3/pulls{/number}","milestones_url":"https://api.github.com/repos/cucumber/gherkin3/milestones{/number}","notifications_url":"https://api.github.com/repos/cucumber/gherkin3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cucumber/gherkin3/labels{/name}","releases_url":"https://api.github.com/repos/cucumber/gherkin3/releases{/id}","created_at":"2014-03-17T15:25:00Z","updated_at":"2015-03-11T10:30:17Z","pushed_at":"2015-03-11T10:30:17Z","git_url":"git://github.com/cucumber/gherkin3.git","ssh_url":"git@github.com:cucumber/gherkin3.git","clone_url":"https://github.com/cucumber/gherkin3.git","svn_url":"https://github.com/cucumber/gherkin3","homepage":null,"size":2510,"stargazers_count":12,"watchers_count":12,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":1,"forks":3,"open_issues":1,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cucumber/gherkin3/pulls/5"},"html":{"href":"https://github.com/cucumber/gherkin3/pull/5"},"issue":{"href":"https://api.github.com/repos/cucumber/gherkin3/issues/5"},"comments":{"href":"https://api.github.com/repos/cucumber/gherkin3/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/cucumber/gherkin3/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/cucumber/gherkin3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cucumber/gherkin3/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/cucumber/gherkin3/statuses/a0e8bec1b9288516c062e97e084ad697b0f4f254"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":7,"review_comments":2,"commits":2,"additions":76,"deletions":18,"changed_files":5}}