{"action":"created","issue":{"url":"https://api.github.com/repos/civicrm/civicrm-core/issues/5678","labels_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/5678/labels{/name}","comments_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/5678/comments","events_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/5678/events","html_url":"https://github.com/civicrm/civicrm-core/pull/5678","id":70437344,"number":5678,"title":"Actually validate prices; check for admin visibility;set defaults for pr...","user":{"login":"zorgalina","id":5482479,"avatar_url":"https://avatars.githubusercontent.com/u/5482479?v=3","gravatar_id":"","url":"https://api.github.com/users/zorgalina","html_url":"https://github.com/zorgalina","followers_url":"https://api.github.com/users/zorgalina/followers","following_url":"https://api.github.com/users/zorgalina/following{/other_user}","gists_url":"https://api.github.com/users/zorgalina/gists{/gist_id}","starred_url":"https://api.github.com/users/zorgalina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zorgalina/subscriptions","organizations_url":"https://api.github.com/users/zorgalina/orgs","repos_url":"https://api.github.com/users/zorgalina/repos","events_url":"https://api.github.com/users/zorgalina/events{/privacy}","received_events_url":"https://api.github.com/users/zorgalina/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-04-23T15:12:51Z","updated_at":"2015-05-09T03:06:29Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/civicrm/civicrm-core/pulls/5678","html_url":"https://github.com/civicrm/civicrm-core/pull/5678","diff_url":"https://github.com/civicrm/civicrm-core/pull/5678.diff","patch_url":"https://github.com/civicrm/civicrm-core/pull/5678.patch"},"body":"...ice, participant\r\n\r\n1.) Adding 'discount' textbox doesn't do discounting - I submitted changes to CiviDiscount which adds the form name for ParticipantsAndPrices which will check if event is discountable and display the Discount code textbox\r\n2.) Validation on array _values['fees'] didn't do validation, that array seems to be null\r\n3.)  In build_price_options, add check for price fields that are meant to be 'admin only'\r\n4.) In setDefaultValues, if participant is new, set their name, email if entered; set price defaults if they exist"},"comment":{"url":"https://api.github.com/repos/civicrm/civicrm-core/issues/comments/100414623","html_url":"https://github.com/civicrm/civicrm-core/pull/5678#issuecomment-100414623","issue_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/5678","id":100414623,"user":{"login":"zorgalina","id":5482479,"avatar_url":"https://avatars.githubusercontent.com/u/5482479?v=3","gravatar_id":"","url":"https://api.github.com/users/zorgalina","html_url":"https://github.com/zorgalina","followers_url":"https://api.github.com/users/zorgalina/followers","following_url":"https://api.github.com/users/zorgalina/following{/other_user}","gists_url":"https://api.github.com/users/zorgalina/gists{/gist_id}","starred_url":"https://api.github.com/users/zorgalina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zorgalina/subscriptions","organizations_url":"https://api.github.com/users/zorgalina/orgs","repos_url":"https://api.github.com/users/zorgalina/repos","events_url":"https://api.github.com/users/zorgalina/events{/privacy}","received_events_url":"https://api.github.com/users/zorgalina/received_events","type":"User","site_admin":false},"created_at":"2015-05-09T03:06:29Z","updated_at":"2015-05-09T03:06:29Z","body":"Thank you - I submitted an Issue, CRM-16481 (I had submitted PRs in\nCividiscount w/out creating Issues, perhaps that was not the right\nprocedure but they were merged in anyway).\nI get a page not found/404 on the link you sent me for the style checking.\nBrowsing the build history on page\nhttps://test.civicrm.org/job/CiviCRM-Core-PR/, I seem only to be able to go\nback to build 3273; so I will submit another commit for these changes and\npresume that'll give me a new result page for fixing the code.\n\n\nOn Wed, Apr 29, 2015 at 3:57 PM, Dave Greenberg <notifications@github.com>\nwrote:\n\n> You don't need to resubmit - you can push new commits to the same PR. The\n> initial test failures are all related to code style issues such as\n> superfluous white space at the end of lines. You can click the Details tab\n> on this page to see what needs to be fixed line by line:\n> https://test.civicrm.org/job/CiviCRM-Core-PR/3185/checkstyleResult/new/\n>\n> Also, is there a related issue for this in the Issue Tracker? If not,\n> please create one and reference this PR. If there is already an issue, or\n> after you've created one, please include it in your next commit message\n> using this format: 'CRM-XXXX - description of commit goes here'\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/civicrm/civicrm-core/pull/5678#issuecomment-97609726>.\n>\n\n\n\n-- \nزورگلنه ءء لسلی\n"}}