{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/42111134","id":42111134,"diff_hunk":"@@ -31,11 +31,39 @@ import (\n \t\"k8s.io/kubernetes/pkg/fields\"\n \t\"k8s.io/kubernetes/pkg/labels\"\n \t\"k8s.io/kubernetes/pkg/registry/generic\"\n+\tnodeetcd \"k8s.io/kubernetes/pkg/registry/node/etcd\"\n \t\"k8s.io/kubernetes/pkg/runtime\"\n \t\"k8s.io/kubernetes/pkg/util\"\n \t\"k8s.io/kubernetes/pkg/util/fielderrors\"\n )\n \n+type HostLocator interface {","path":"pkg/registry/pod/strategy.go","position":10,"original_position":10,"commit_id":"ef981d8d76857b4351da06849103abe6bd10e245","original_commit_id":"ef981d8d76857b4351da06849103abe6bd10e245","user":{"login":"gmarek","id":1703842,"avatar_url":"https://avatars.githubusercontent.com/u/1703842?v=3","gravatar_id":"","url":"https://api.github.com/users/gmarek","html_url":"https://github.com/gmarek","followers_url":"https://api.github.com/users/gmarek/followers","following_url":"https://api.github.com/users/gmarek/following{/other_user}","gists_url":"https://api.github.com/users/gmarek/gists{/gist_id}","starred_url":"https://api.github.com/users/gmarek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmarek/subscriptions","organizations_url":"https://api.github.com/users/gmarek/orgs","repos_url":"https://api.github.com/users/gmarek/repos","events_url":"https://api.github.com/users/gmarek/events{/privacy}","received_events_url":"https://api.github.com/users/gmarek/received_events","type":"User","site_admin":false},"body":"Well, if I move it to the Node package I'll need to import it as well. But yes - probably it's a better place for it.","created_at":"2015-10-15T11:16:03Z","updated_at":"2015-10-15T11:16:03Z","html_url":"https://github.com/kubernetes/kubernetes/pull/12919#discussion_r42111134","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/12919","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/42111134"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/12919#discussion_r42111134"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/12919"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/12919","id":42815448,"html_url":"https://github.com/kubernetes/kubernetes/pull/12919","diff_url":"https://github.com/kubernetes/kubernetes/pull/12919.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/12919.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/12919","number":12919,"state":"open","locked":false,"title":"Use KubeletPort reported in NodeStatus instead of cluster-wide master config","user":{"login":"gmarek","id":1703842,"avatar_url":"https://avatars.githubusercontent.com/u/1703842?v=3","gravatar_id":"","url":"https://api.github.com/users/gmarek","html_url":"https://github.com/gmarek","followers_url":"https://api.github.com/users/gmarek/followers","following_url":"https://api.github.com/users/gmarek/following{/other_user}","gists_url":"https://api.github.com/users/gmarek/gists{/gist_id}","starred_url":"https://api.github.com/users/gmarek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmarek/subscriptions","organizations_url":"https://api.github.com/users/gmarek/orgs","repos_url":"https://api.github.com/users/gmarek/repos","events_url":"https://api.github.com/users/gmarek/events{/privacy}","received_events_url":"https://api.github.com/users/gmarek/received_events","type":"User","site_admin":false},"body":"Fixes to #12912. Depends on #12655, currently includes #12913\r\n\r\ncc @dchen1107 @yujuhong @wojtek-t @fgrzadkowski @bgrant0607 @davidopp ","created_at":"2015-08-19T13:42:41Z","updated_at":"2015-10-15T11:16:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"89a17e8a86394f94ba7baac112dabf30c737928b","assignee":{"login":"lavalamp","id":647318,"avatar_url":"https://avatars.githubusercontent.com/u/647318?v=3","gravatar_id":"","url":"https://api.github.com/users/lavalamp","html_url":"https://github.com/lavalamp","followers_url":"https://api.github.com/users/lavalamp/followers","following_url":"https://api.github.com/users/lavalamp/following{/other_user}","gists_url":"https://api.github.com/users/lavalamp/gists{/gist_id}","starred_url":"https://api.github.com/users/lavalamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lavalamp/subscriptions","organizations_url":"https://api.github.com/users/lavalamp/orgs","repos_url":"https://api.github.com/users/lavalamp/repos","events_url":"https://api.github.com/users/lavalamp/events{/privacy}","received_events_url":"https://api.github.com/users/lavalamp/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/12919/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/12919/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/12919/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/ef981d8d76857b4351da06849103abe6bd10e245","head":{"label":"gmarek:use_api_ports","ref":"use_api_ports","sha":"ef981d8d76857b4351da06849103abe6bd10e245","user":{"login":"gmarek","id":1703842,"avatar_url":"https://avatars.githubusercontent.com/u/1703842?v=3","gravatar_id":"","url":"https://api.github.com/users/gmarek","html_url":"https://github.com/gmarek","followers_url":"https://api.github.com/users/gmarek/followers","following_url":"https://api.github.com/users/gmarek/following{/other_user}","gists_url":"https://api.github.com/users/gmarek/gists{/gist_id}","starred_url":"https://api.github.com/users/gmarek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmarek/subscriptions","organizations_url":"https://api.github.com/users/gmarek/orgs","repos_url":"https://api.github.com/users/gmarek/repos","events_url":"https://api.github.com/users/gmarek/events{/privacy}","received_events_url":"https://api.github.com/users/gmarek/received_events","type":"User","site_admin":false},"repo":{"id":30216777,"name":"kubernetes","full_name":"gmarek/kubernetes","owner":{"login":"gmarek","id":1703842,"avatar_url":"https://avatars.githubusercontent.com/u/1703842?v=3","gravatar_id":"","url":"https://api.github.com/users/gmarek","html_url":"https://github.com/gmarek","followers_url":"https://api.github.com/users/gmarek/followers","following_url":"https://api.github.com/users/gmarek/following{/other_user}","gists_url":"https://api.github.com/users/gmarek/gists{/gist_id}","starred_url":"https://api.github.com/users/gmarek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmarek/subscriptions","organizations_url":"https://api.github.com/users/gmarek/orgs","repos_url":"https://api.github.com/users/gmarek/repos","events_url":"https://api.github.com/users/gmarek/events{/privacy}","received_events_url":"https://api.github.com/users/gmarek/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gmarek/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/gmarek/kubernetes","forks_url":"https://api.github.com/repos/gmarek/kubernetes/forks","keys_url":"https://api.github.com/repos/gmarek/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gmarek/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gmarek/kubernetes/teams","hooks_url":"https://api.github.com/repos/gmarek/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/gmarek/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/gmarek/kubernetes/events","assignees_url":"https://api.github.com/repos/gmarek/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/gmarek/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/gmarek/kubernetes/tags","blobs_url":"https://api.github.com/repos/gmarek/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gmarek/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gmarek/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/gmarek/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gmarek/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/gmarek/kubernetes/languages","stargazers_url":"https://api.github.com/repos/gmarek/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/gmarek/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/gmarek/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/gmarek/kubernetes/subscription","commits_url":"https://api.github.com/repos/gmarek/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/gmarek/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/gmarek/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/gmarek/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/gmarek/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/gmarek/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gmarek/kubernetes/merges","archive_url":"https://api.github.com/repos/gmarek/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gmarek/kubernetes/downloads","issues_url":"https://api.github.com/repos/gmarek/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/gmarek/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/gmarek/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/gmarek/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gmarek/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/gmarek/kubernetes/releases{/id}","created_at":"2015-02-03T00:37:49Z","updated_at":"2015-03-10T14:50:28Z","pushed_at":"2015-10-15T09:24:34Z","git_url":"git://github.com/gmarek/kubernetes.git","ssh_url":"git@github.com:gmarek/kubernetes.git","clone_url":"https://github.com/gmarek/kubernetes.git","svn_url":"https://github.com/gmarek/kubernetes","homepage":"http://kubernetes.io","size":115418,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"979ca2b3fe5554e2126e7ba2d846e094cc6513b6","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","created_at":"2014-06-06T22:56:04Z","updated_at":"2015-10-15T10:17:52Z","pushed_at":"2015-10-15T10:37:39Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":462058,"stargazers_count":10714,"watchers_count":10714,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2715,"mirror_url":null,"open_issues_count":2055,"forks":2715,"open_issues":2055,"watchers":10714,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/12919"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/12919"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/12919"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/12919/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/12919/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/12919/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/ef981d8d76857b4351da06849103abe6bd10e245"}}}}