{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/roslyn/issues/6139","labels_url":"https://api.github.com/repos/dotnet/roslyn/issues/6139/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/6139/comments","events_url":"https://api.github.com/repos/dotnet/roslyn/issues/6139/events","html_url":"https://github.com/dotnet/roslyn/pull/6139","id":112133194,"number":6139,"title":"Added quotes to filepath variables in GenerateCompilerInternals.targets","user":{"login":"tenor","id":526262,"avatar_url":"https://avatars.githubusercontent.com/u/526262?v=3","gravatar_id":"","url":"https://api.github.com/users/tenor","html_url":"https://github.com/tenor","followers_url":"https://api.github.com/users/tenor/followers","following_url":"https://api.github.com/users/tenor/following{/other_user}","gists_url":"https://api.github.com/users/tenor/gists{/gist_id}","starred_url":"https://api.github.com/users/tenor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tenor/subscriptions","organizations_url":"https://api.github.com/users/tenor/orgs","repos_url":"https://api.github.com/users/tenor/repos","events_url":"https://api.github.com/users/tenor/events{/privacy}","received_events_url":"https://api.github.com/users/tenor/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/dotnet/roslyn/labels/cla-not-required","name":"cla-not-required","color":"90EE90"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2015-10-19T12:22:17Z","updated_at":"2015-10-19T12:23:12Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/6139","html_url":"https://github.com/dotnet/roslyn/pull/6139","diff_url":"https://github.com/dotnet/roslyn/pull/6139.diff","patch_url":"https://github.com/dotnet/roslyn/pull/6139.patch"},"body":"While building CSharpCodeAnalysis.csproj, calls to SyntaxGenerator, BoundTreeGenerator and ErrorFactsGenerator fails when input or output filepaths have spaces in file or folder names.\r\n\r\nThis fix adds quotes around the filename variables in the Exec elements so that those generators can find source files in paths that have spaces.\r\n\r\nExamples of build errors encountered are:\r\n\r\n5>------ Rebuild All started: Project: CSharpCodeAnalysis, Configuration: Release Any CPU ------\r\n5>  Invalid usage\r\n5>  CSharpSyntaxGenerator.exe input-file output-file [/write-test]\r\n5>CSC : error CS2001: Source file 'C:\\Users\\sunny\\Source\\Roslyn Remix\\Roslyn\\roslyn\\Binaries\\Obj\\CSharpCodeAnalysis\\Release\\Syntax.xml.Generated.cs' could not be found.\r\n\r\n\r\n5>------ Rebuild All started: Project: CSharpCodeAnalysis, Configuration: Release Any CPU ------\r\n5>  Wrote C:\\Users\\sunny\\Source\\Roslyn Remix\\Roslyn\\roslyn\\Binaries\\Obj\\CSharpCodeAnalysis\\Release\\Syntax.xml.Generated.cs\r\n5>  Usage: \"BoundTreeGenerator <language> <input> <output>\", where <language> is \"VB\" or \"CSharp\"\r\n5>C:\\Users\\sunny\\Source\\Roslyn Remix\\Roslyn\\roslyn\\build\\Targets\\GenerateCompilerInternals.targets(146,5): error MSB3073: The command \" \"..\\..\\..\\..\\Binaries\\Release\\BoundTreeGenerator.exe\" C# BoundTree\\BoundNodes.xml C:\\Users\\sunny\\Source\\Roslyn Remix\\Roslyn\\roslyn\\Binaries\\Obj\\CSharpCodeAnalysis\\Release\\BoundNodes.xml.Generated.cs\" exited with code 1.\r\n\r\n\r\n5>------ Rebuild All started: Project: CSharpCodeAnalysis, Configuration: Release Any CPU ------\r\n5>  Wrote C:\\Users\\sunny\\Source\\Roslyn Remix\\Roslyn\\roslyn\\Binaries\\Obj\\CSharpCodeAnalysis\\Release\\Syntax.xml.Generated.cs\r\n5>  Usage: CSharpErrorFactsGenerator input output\r\n5>    input     The path to ErrorCode.cs\r\n5>    output    The path to GeneratedErrorFacts.cs\r\n5>C:\\Users\\sunny\\Source\\Roslyn Remix\\Roslyn\\roslyn\\build\\Targets\\GenerateCompilerInternals.targets(183,5): error MSB3073: The command \" \"..\\..\\..\\..\\Binaries\\Release\\CSharpErrorFactsGenerator.exe\" Errors\\ErrorCode.cs C:\\Users\\sunny\\Source\\Roslyn Remix\\Roslyn\\roslyn\\Binaries\\Obj\\CSharpCodeAnalysis\\Release\\ErrorFacts.Generated.cs\" exited with code -1.\r\n"},"comment":{"url":"https://api.github.com/repos/dotnet/roslyn/issues/comments/149199171","html_url":"https://github.com/dotnet/roslyn/pull/6139#issuecomment-149199171","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/6139","id":149199171,"user":{"login":"dotnet-bot","id":9011267,"avatar_url":"https://avatars.githubusercontent.com/u/9011267?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet-bot","html_url":"https://github.com/dotnet-bot","followers_url":"https://api.github.com/users/dotnet-bot/followers","following_url":"https://api.github.com/users/dotnet-bot/following{/other_user}","gists_url":"https://api.github.com/users/dotnet-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet-bot/subscriptions","organizations_url":"https://api.github.com/users/dotnet-bot/orgs","repos_url":"https://api.github.com/users/dotnet-bot/repos","events_url":"https://api.github.com/users/dotnet-bot/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet-bot/received_events","type":"User","site_admin":false},"created_at":"2015-10-19T12:23:12Z","updated_at":"2015-10-19T12:23:12Z","body":"Can one of the admins approve this PR test or permanently add this user to those allowed to submit a PR?"}}