{"action":"created","issue":{"url":"https://api.github.com/repos/joshday/OnlineStats.jl/issues/23","labels_url":"https://api.github.com/repos/joshday/OnlineStats.jl/issues/23/labels{/name}","comments_url":"https://api.github.com/repos/joshday/OnlineStats.jl/issues/23/comments","events_url":"https://api.github.com/repos/joshday/OnlineStats.jl/issues/23/events","html_url":"https://github.com/joshday/OnlineStats.jl/issues/23","id":92680095,"number":23,"title":"use AbstractArray","user":{"login":"tbreloff","id":933338,"avatar_url":"https://avatars.githubusercontent.com/u/933338?v=3","gravatar_id":"","url":"https://api.github.com/users/tbreloff","html_url":"https://github.com/tbreloff","followers_url":"https://api.github.com/users/tbreloff/followers","following_url":"https://api.github.com/users/tbreloff/following{/other_user}","gists_url":"https://api.github.com/users/tbreloff/gists{/gist_id}","starred_url":"https://api.github.com/users/tbreloff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbreloff/subscriptions","organizations_url":"https://api.github.com/users/tbreloff/orgs","repos_url":"https://api.github.com/users/tbreloff/repos","events_url":"https://api.github.com/users/tbreloff/events{/privacy}","received_events_url":"https://api.github.com/users/tbreloff/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/joshday/OnlineStats.jl/labels/enhancement","name":"enhancement","color":"84b6eb"},{"url":"https://api.github.com/repos/joshday/OnlineStats.jl/labels/optimization","name":"optimization","color":"006b75"}],"state":"open","locked":false,"assignee":{"login":"tbreloff","id":933338,"avatar_url":"https://avatars.githubusercontent.com/u/933338?v=3","gravatar_id":"","url":"https://api.github.com/users/tbreloff","html_url":"https://github.com/tbreloff","followers_url":"https://api.github.com/users/tbreloff/followers","following_url":"https://api.github.com/users/tbreloff/following{/other_user}","gists_url":"https://api.github.com/users/tbreloff/gists{/gist_id}","starred_url":"https://api.github.com/users/tbreloff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbreloff/subscriptions","organizations_url":"https://api.github.com/users/tbreloff/orgs","repos_url":"https://api.github.com/users/tbreloff/repos","events_url":"https://api.github.com/users/tbreloff/events{/privacy}","received_events_url":"https://api.github.com/users/tbreloff/received_events","type":"User","site_admin":false},"milestone":null,"comments":9,"created_at":"2015-07-02T16:32:47Z","updated_at":"2015-07-11T15:48:41Z","closed_at":null,"body":"Consider changing VecF/MatF to:\r\n```\r\ntypealias VecF AbstractVector{Float64}\r\ntypealias MatF AbstractMatrix{Float64}\r\n```\r\n\r\nand use `view`s freely to avoid temporary copies.  If we need a copy, require explicit call to `copy`"},"comment":{"url":"https://api.github.com/repos/joshday/OnlineStats.jl/issues/comments/120635315","html_url":"https://github.com/joshday/OnlineStats.jl/issues/23#issuecomment-120635315","issue_url":"https://api.github.com/repos/joshday/OnlineStats.jl/issues/23","id":120635315,"user":{"login":"tbreloff","id":933338,"avatar_url":"https://avatars.githubusercontent.com/u/933338?v=3","gravatar_id":"","url":"https://api.github.com/users/tbreloff","html_url":"https://github.com/tbreloff","followers_url":"https://api.github.com/users/tbreloff/followers","following_url":"https://api.github.com/users/tbreloff/following{/other_user}","gists_url":"https://api.github.com/users/tbreloff/gists{/gist_id}","starred_url":"https://api.github.com/users/tbreloff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbreloff/subscriptions","organizations_url":"https://api.github.com/users/tbreloff/orgs","repos_url":"https://api.github.com/users/tbreloff/repos","events_url":"https://api.github.com/users/tbreloff/events{/privacy}","received_events_url":"https://api.github.com/users/tbreloff/received_events","type":"User","site_admin":false},"created_at":"2015-07-11T15:48:41Z","updated_at":"2015-07-11T15:48:41Z","body":"I think smooth! can accept AVecF and AMatF. \n\n\n\n> On Jul 11, 2015, at 10:13 AM, Josh Day <notifications@github.com> wrote:\n> \n> I was going to write some more tests for OnlinePCA and it looks like changing the definition of row to use AMatF has broken a thing or two. Even if smooth!() didn't restrict the vectors you're smoothing to contain the same type, this would be trying to assign values to a StridedView.\n> \n> julia> o = OnlineStats.OnlinePCA(x, 5)\n> ERROR: `smooth!` has no method matching smooth!(::StridedView{Float64,1,0,Array{Float64,2}}, ::Array{Float64,1}, ::Float64)\n>  in update! at /Users/jtday/.julia/v0.3/OnlineStats/src/linearmodel/opca.jl:84\n>  in update! at /Users/jtday/.julia/v0.3/OnlineStats/src/linearmodel/opca.jl:106\n>  in OnlinePCA at /Users/jtday/.julia/v0.3/OnlineStats/src/linearmodel/opca.jl:45\n> —\n> Reply to this email directly or view it on GitHub.\n> \n"}}