{"action":"created","comment":{"url":"https://api.github.com/repos/BigNoid/script.skinshortcuts/pulls/comments/36587207","id":36587207,"diff_hunk":"@@ -238,6 +263,27 @@ def retrieveContent( self, content ):\n             items = self.checkForFolder( items )\n         else:\n             items = []\n+\n+        # Add widget information for video/audio nodes\n+        if content == \"video\" or content == \"music\":","path":"resources/lib/library.py","position":88,"original_position":88,"commit_id":"214c48d419233afd9dbdace0511fa9cbf489641c","original_commit_id":"214c48d419233afd9dbdace0511fa9cbf489641c","user":{"login":"phil65","id":110931,"avatar_url":"https://avatars.githubusercontent.com/u/110931?v=3","gravatar_id":"","url":"https://api.github.com/users/phil65","html_url":"https://github.com/phil65","followers_url":"https://api.github.com/users/phil65/followers","following_url":"https://api.github.com/users/phil65/following{/other_user}","gists_url":"https://api.github.com/users/phil65/gists{/gist_id}","starred_url":"https://api.github.com/users/phil65/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phil65/subscriptions","organizations_url":"https://api.github.com/users/phil65/orgs","repos_url":"https://api.github.com/users/phil65/repos","events_url":"https://api.github.com/users/phil65/events{/privacy}","received_events_url":"https://api.github.com/users/phil65/received_events","type":"User","site_admin":false},"body":"I always prefer \"if content in [\"video\", \"music\"]\" for stuff like this.","created_at":"2015-08-09T12:17:49Z","updated_at":"2015-08-09T12:17:49Z","html_url":"https://github.com/BigNoid/script.skinshortcuts/pull/37#discussion_r36587207","pull_request_url":"https://api.github.com/repos/BigNoid/script.skinshortcuts/pulls/37","_links":{"self":{"href":"https://api.github.com/repos/BigNoid/script.skinshortcuts/pulls/comments/36587207"},"html":{"href":"https://github.com/BigNoid/script.skinshortcuts/pull/37#discussion_r36587207"},"pull_request":{"href":"https://api.github.com/repos/BigNoid/script.skinshortcuts/pulls/37"}}},"pull_request":{"url":"https://api.github.com/repos/BigNoid/script.skinshortcuts/pulls/37","id":41957389,"html_url":"https://github.com/BigNoid/script.skinshortcuts/pull/37","diff_url":"https://github.com/BigNoid/script.skinshortcuts/pull/37.diff","patch_url":"https://github.com/BigNoid/script.skinshortcuts/pull/37.patch","issue_url":"https://api.github.com/repos/BigNoid/script.skinshortcuts/issues/37","number":37,"state":"open","locked":false,"title":"Add button 312 for new selection of widgets","user":{"login":"Ignoble61","id":12768752,"avatar_url":"https://avatars.githubusercontent.com/u/12768752?v=3","gravatar_id":"","url":"https://api.github.com/users/Ignoble61","html_url":"https://github.com/Ignoble61","followers_url":"https://api.github.com/users/Ignoble61/followers","following_url":"https://api.github.com/users/Ignoble61/following{/other_user}","gists_url":"https://api.github.com/users/Ignoble61/gists{/gist_id}","starred_url":"https://api.github.com/users/Ignoble61/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ignoble61/subscriptions","organizations_url":"https://api.github.com/users/Ignoble61/orgs","repos_url":"https://api.github.com/users/Ignoble61/repos","events_url":"https://api.github.com/users/Ignoble61/events{/privacy}","received_events_url":"https://api.github.com/users/Ignoble61/received_events","type":"User","site_admin":false},"body":"Incomplete list of changes included:-\r\n* GUI button 312 added to select widgets including custom widgets, library nodes, sources, add-ons, playlists\r\n* Deprecate GUI button 309 (old method to select widget)\r\n* All the code needed for the new widgets to return 5 properties - widget, widgetName, widgetType, widgetTarget, widgetPath\r\n* New widgetdefaultnode override\r\n* Support for additional custom groupings of available shortcuts for Just Select method + GUI buttons 401 & 307\r\n* Remove choice of action in select dialog when using widget groupings (will always return ActivateWindow path rather than giving choice of, for example, starting a slideshow)\r\n* Fixes for browsing/selecting audio nodes (notably, correct window returned, fix potential crash, fix log errors)\r\n* Move code to load skin-defined widgets to library.py\r\n* Allow exploring of plugin elements provided by program add-ons\r\n* Add ability to go 'back' when selecting a shortcut/widget\r\n* Template improvements - ability to match any condition rather than all, more fine control of getting/setting properties, ability to use an include in a property, ability to build multiple Other templates per main menu item, minor fixes\r\n* Fix security vulnerability in .hash files (arbitrary python code could be run)\r\n* Minor fixes\r\n\r\nThanks to @marcelveldt and @Nessus85100 for testing, and marcelveldt for the code letting add-ons return the new widgetType property.\r\n\r\nMarcelveldt, I know it's a lot of code, but do you fancy a code review :grinning:","created_at":"2015-08-08T17:27:46Z","updated_at":"2015-08-09T12:17:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"53993c8b04aad3332bad657742b99efd0b672dc8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/BigNoid/script.skinshortcuts/pulls/37/commits","review_comments_url":"https://api.github.com/repos/BigNoid/script.skinshortcuts/pulls/37/comments","review_comment_url":"https://api.github.com/repos/BigNoid/script.skinshortcuts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/BigNoid/script.skinshortcuts/issues/37/comments","statuses_url":"https://api.github.com/repos/BigNoid/script.skinshortcuts/statuses/214c48d419233afd9dbdace0511fa9cbf489641c","head":{"label":"Ignoble61:widgets","ref":"widgets","sha":"214c48d419233afd9dbdace0511fa9cbf489641c","user":{"login":"Ignoble61","id":12768752,"avatar_url":"https://avatars.githubusercontent.com/u/12768752?v=3","gravatar_id":"","url":"https://api.github.com/users/Ignoble61","html_url":"https://github.com/Ignoble61","followers_url":"https://api.github.com/users/Ignoble61/followers","following_url":"https://api.github.com/users/Ignoble61/following{/other_user}","gists_url":"https://api.github.com/users/Ignoble61/gists{/gist_id}","starred_url":"https://api.github.com/users/Ignoble61/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ignoble61/subscriptions","organizations_url":"https://api.github.com/users/Ignoble61/orgs","repos_url":"https://api.github.com/users/Ignoble61/repos","events_url":"https://api.github.com/users/Ignoble61/events{/privacy}","received_events_url":"https://api.github.com/users/Ignoble61/received_events","type":"User","site_admin":false},"repo":{"id":36958065,"name":"script.skinshortcuts","full_name":"Ignoble61/script.skinshortcuts","owner":{"login":"Ignoble61","id":12768752,"avatar_url":"https://avatars.githubusercontent.com/u/12768752?v=3","gravatar_id":"","url":"https://api.github.com/users/Ignoble61","html_url":"https://github.com/Ignoble61","followers_url":"https://api.github.com/users/Ignoble61/followers","following_url":"https://api.github.com/users/Ignoble61/following{/other_user}","gists_url":"https://api.github.com/users/Ignoble61/gists{/gist_id}","starred_url":"https://api.github.com/users/Ignoble61/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ignoble61/subscriptions","organizations_url":"https://api.github.com/users/Ignoble61/orgs","repos_url":"https://api.github.com/users/Ignoble61/repos","events_url":"https://api.github.com/users/Ignoble61/events{/privacy}","received_events_url":"https://api.github.com/users/Ignoble61/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Ignoble61/script.skinshortcuts","description":null,"fork":true,"url":"https://api.github.com/repos/Ignoble61/script.skinshortcuts","forks_url":"https://api.github.com/repos/Ignoble61/script.skinshortcuts/forks","keys_url":"https://api.github.com/repos/Ignoble61/script.skinshortcuts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ignoble61/script.skinshortcuts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ignoble61/script.skinshortcuts/teams","hooks_url":"https://api.github.com/repos/Ignoble61/script.skinshortcuts/hooks","issue_events_url":"https://api.github.com/repos/Ignoble61/script.skinshortcuts/issues/events{/number}","events_url":"https://api.github.com/repos/Ignoble61/script.skinshortcuts/events","assignees_url":"https://api.github.com/repos/Ignoble61/script.skinshortcuts/assignees{/user}","branches_url":"https://api.github.com/repos/Ignoble61/script.skinshortcuts/branches{/branch}","tags_url":"https://api.github.com/repos/Ignoble61/script.skinshortcuts/tags","blobs_url":"https://api.github.com/repos/Ignoble61/script.skinshortcuts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ignoble61/script.skinshortcuts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ignoble61/script.skinshortcuts/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ignoble61/script.skinshortcuts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ignoble61/script.skinshortcuts/statuses/{sha}","languages_url":"https://api.github.com/repos/Ignoble61/script.skinshortcuts/languages","stargazers_url":"https://api.github.com/repos/Ignoble61/script.skinshortcuts/stargazers","contributors_url":"https://api.github.com/repos/Ignoble61/script.skinshortcuts/contributors","subscribers_url":"https://api.github.com/repos/Ignoble61/script.skinshortcuts/subscribers","subscription_url":"https://api.github.com/repos/Ignoble61/script.skinshortcuts/subscription","commits_url":"https://api.github.com/repos/Ignoble61/script.skinshortcuts/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ignoble61/script.skinshortcuts/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ignoble61/script.skinshortcuts/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ignoble61/script.skinshortcuts/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ignoble61/script.skinshortcuts/contents/{+path}","compare_url":"https://api.github.com/repos/Ignoble61/script.skinshortcuts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ignoble61/script.skinshortcuts/merges","archive_url":"https://api.github.com/repos/Ignoble61/script.skinshortcuts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ignoble61/script.skinshortcuts/downloads","issues_url":"https://api.github.com/repos/Ignoble61/script.skinshortcuts/issues{/number}","pulls_url":"https://api.github.com/repos/Ignoble61/script.skinshortcuts/pulls{/number}","milestones_url":"https://api.github.com/repos/Ignoble61/script.skinshortcuts/milestones{/number}","notifications_url":"https://api.github.com/repos/Ignoble61/script.skinshortcuts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ignoble61/script.skinshortcuts/labels{/name}","releases_url":"https://api.github.com/repos/Ignoble61/script.skinshortcuts/releases{/id}","created_at":"2015-06-05T22:15:49Z","updated_at":"2015-06-10T19:03:09Z","pushed_at":"2015-08-08T18:49:31Z","git_url":"git://github.com/Ignoble61/script.skinshortcuts.git","ssh_url":"git@github.com:Ignoble61/script.skinshortcuts.git","clone_url":"https://github.com/Ignoble61/script.skinshortcuts.git","svn_url":"https://github.com/Ignoble61/script.skinshortcuts","homepage":null,"size":2141,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"BigNoid:master","ref":"master","sha":"6cd6808478bfc26858b71c21409b41e78987e69e","user":{"login":"BigNoid","id":447067,"avatar_url":"https://avatars.githubusercontent.com/u/447067?v=3","gravatar_id":"","url":"https://api.github.com/users/BigNoid","html_url":"https://github.com/BigNoid","followers_url":"https://api.github.com/users/BigNoid/followers","following_url":"https://api.github.com/users/BigNoid/following{/other_user}","gists_url":"https://api.github.com/users/BigNoid/gists{/gist_id}","starred_url":"https://api.github.com/users/BigNoid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BigNoid/subscriptions","organizations_url":"https://api.github.com/users/BigNoid/orgs","repos_url":"https://api.github.com/users/BigNoid/repos","events_url":"https://api.github.com/users/BigNoid/events{/privacy}","received_events_url":"https://api.github.com/users/BigNoid/received_events","type":"User","site_admin":false},"repo":{"id":14962063,"name":"script.skinshortcuts","full_name":"BigNoid/script.skinshortcuts","owner":{"login":"BigNoid","id":447067,"avatar_url":"https://avatars.githubusercontent.com/u/447067?v=3","gravatar_id":"","url":"https://api.github.com/users/BigNoid","html_url":"https://github.com/BigNoid","followers_url":"https://api.github.com/users/BigNoid/followers","following_url":"https://api.github.com/users/BigNoid/following{/other_user}","gists_url":"https://api.github.com/users/BigNoid/gists{/gist_id}","starred_url":"https://api.github.com/users/BigNoid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BigNoid/subscriptions","organizations_url":"https://api.github.com/users/BigNoid/orgs","repos_url":"https://api.github.com/users/BigNoid/repos","events_url":"https://api.github.com/users/BigNoid/events{/privacy}","received_events_url":"https://api.github.com/users/BigNoid/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/BigNoid/script.skinshortcuts","description":null,"fork":false,"url":"https://api.github.com/repos/BigNoid/script.skinshortcuts","forks_url":"https://api.github.com/repos/BigNoid/script.skinshortcuts/forks","keys_url":"https://api.github.com/repos/BigNoid/script.skinshortcuts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BigNoid/script.skinshortcuts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BigNoid/script.skinshortcuts/teams","hooks_url":"https://api.github.com/repos/BigNoid/script.skinshortcuts/hooks","issue_events_url":"https://api.github.com/repos/BigNoid/script.skinshortcuts/issues/events{/number}","events_url":"https://api.github.com/repos/BigNoid/script.skinshortcuts/events","assignees_url":"https://api.github.com/repos/BigNoid/script.skinshortcuts/assignees{/user}","branches_url":"https://api.github.com/repos/BigNoid/script.skinshortcuts/branches{/branch}","tags_url":"https://api.github.com/repos/BigNoid/script.skinshortcuts/tags","blobs_url":"https://api.github.com/repos/BigNoid/script.skinshortcuts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BigNoid/script.skinshortcuts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BigNoid/script.skinshortcuts/git/refs{/sha}","trees_url":"https://api.github.com/repos/BigNoid/script.skinshortcuts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BigNoid/script.skinshortcuts/statuses/{sha}","languages_url":"https://api.github.com/repos/BigNoid/script.skinshortcuts/languages","stargazers_url":"https://api.github.com/repos/BigNoid/script.skinshortcuts/stargazers","contributors_url":"https://api.github.com/repos/BigNoid/script.skinshortcuts/contributors","subscribers_url":"https://api.github.com/repos/BigNoid/script.skinshortcuts/subscribers","subscription_url":"https://api.github.com/repos/BigNoid/script.skinshortcuts/subscription","commits_url":"https://api.github.com/repos/BigNoid/script.skinshortcuts/commits{/sha}","git_commits_url":"https://api.github.com/repos/BigNoid/script.skinshortcuts/git/commits{/sha}","comments_url":"https://api.github.com/repos/BigNoid/script.skinshortcuts/comments{/number}","issue_comment_url":"https://api.github.com/repos/BigNoid/script.skinshortcuts/issues/comments{/number}","contents_url":"https://api.github.com/repos/BigNoid/script.skinshortcuts/contents/{+path}","compare_url":"https://api.github.com/repos/BigNoid/script.skinshortcuts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BigNoid/script.skinshortcuts/merges","archive_url":"https://api.github.com/repos/BigNoid/script.skinshortcuts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BigNoid/script.skinshortcuts/downloads","issues_url":"https://api.github.com/repos/BigNoid/script.skinshortcuts/issues{/number}","pulls_url":"https://api.github.com/repos/BigNoid/script.skinshortcuts/pulls{/number}","milestones_url":"https://api.github.com/repos/BigNoid/script.skinshortcuts/milestones{/number}","notifications_url":"https://api.github.com/repos/BigNoid/script.skinshortcuts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BigNoid/script.skinshortcuts/labels{/name}","releases_url":"https://api.github.com/repos/BigNoid/script.skinshortcuts/releases{/id}","created_at":"2013-12-05T18:25:32Z","updated_at":"2015-08-03T00:51:23Z","pushed_at":"2015-08-08T18:52:31Z","git_url":"git://github.com/BigNoid/script.skinshortcuts.git","ssh_url":"git@github.com:BigNoid/script.skinshortcuts.git","clone_url":"https://github.com/BigNoid/script.skinshortcuts.git","svn_url":"https://github.com/BigNoid/script.skinshortcuts","homepage":null,"size":2420,"stargazers_count":5,"watchers_count":5,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":4,"forks":13,"open_issues":4,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/BigNoid/script.skinshortcuts/pulls/37"},"html":{"href":"https://github.com/BigNoid/script.skinshortcuts/pull/37"},"issue":{"href":"https://api.github.com/repos/BigNoid/script.skinshortcuts/issues/37"},"comments":{"href":"https://api.github.com/repos/BigNoid/script.skinshortcuts/issues/37/comments"},"review_comments":{"href":"https://api.github.com/repos/BigNoid/script.skinshortcuts/pulls/37/comments"},"review_comment":{"href":"https://api.github.com/repos/BigNoid/script.skinshortcuts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/BigNoid/script.skinshortcuts/pulls/37/commits"},"statuses":{"href":"https://api.github.com/repos/BigNoid/script.skinshortcuts/statuses/214c48d419233afd9dbdace0511fa9cbf489641c"}}}}