{"action":"created","issue":{"url":"https://api.github.com/repos/openshift/origin-server/issues/6216","labels_url":"https://api.github.com/repos/openshift/origin-server/issues/6216/labels{/name}","comments_url":"https://api.github.com/repos/openshift/origin-server/issues/6216/comments","events_url":"https://api.github.com/repos/openshift/origin-server/issues/6216/events","html_url":"https://github.com/openshift/origin-server/pull/6216","id":100099140,"number":6216,"title":"Improve error reporting for member add/remove/update through oo-admin-ctl-domain","user":{"login":"tiwillia","id":5197933,"avatar_url":"https://avatars.githubusercontent.com/u/5197933?v=3","gravatar_id":"","url":"https://api.github.com/users/tiwillia","html_url":"https://github.com/tiwillia","followers_url":"https://api.github.com/users/tiwillia/followers","following_url":"https://api.github.com/users/tiwillia/following{/other_user}","gists_url":"https://api.github.com/users/tiwillia/gists{/gist_id}","starred_url":"https://api.github.com/users/tiwillia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiwillia/subscriptions","organizations_url":"https://api.github.com/users/tiwillia/orgs","repos_url":"https://api.github.com/users/tiwillia/repos","events_url":"https://api.github.com/users/tiwillia/events{/privacy}","received_events_url":"https://api.github.com/users/tiwillia/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-08-10T15:48:46Z","updated_at":"2015-09-08T18:14:16Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/openshift/origin-server/pulls/6216","html_url":"https://github.com/openshift/origin-server/pull/6216","diff_url":"https://github.com/openshift/origin-server/pull/6216.diff","patch_url":"https://github.com/openshift/origin-server/pull/6216.patch"},"body":"When an error occurs in `domain.save`, an exception is not returned. Instead, the method does not return true to indicate a failure. These failures were not being caught previously.\r\n\r\nAdditionally, errors encountered in `domain.run_jobs` did not populate `domain.errors`, resulting in an empty hash being reported when an error does occur.\r\n\r\nThis should resolve both issues."},"comment":{"url":"https://api.github.com/repos/openshift/origin-server/issues/comments/138654440","html_url":"https://github.com/openshift/origin-server/pull/6216#issuecomment-138654440","issue_url":"https://api.github.com/repos/openshift/origin-server/issues/6216","id":138654440,"user":{"login":"abhgupta","id":1211613,"avatar_url":"https://avatars.githubusercontent.com/u/1211613?v=3","gravatar_id":"","url":"https://api.github.com/users/abhgupta","html_url":"https://github.com/abhgupta","followers_url":"https://api.github.com/users/abhgupta/followers","following_url":"https://api.github.com/users/abhgupta/following{/other_user}","gists_url":"https://api.github.com/users/abhgupta/gists{/gist_id}","starred_url":"https://api.github.com/users/abhgupta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abhgupta/subscriptions","organizations_url":"https://api.github.com/users/abhgupta/orgs","repos_url":"https://api.github.com/users/abhgupta/repos","events_url":"https://api.github.com/users/abhgupta/events{/privacy}","received_events_url":"https://api.github.com/users/abhgupta/received_events","type":"User","site_admin":false},"created_at":"2015-09-08T18:14:16Z","updated_at":"2015-09-08T18:14:16Z","body":"Other than the comment that applies in 3 places, LGTM"}}