{"action":"created","comment":{"url":"https://api.github.com/repos/docker/docker/pulls/comments/30472745","id":30472745,"diff_hunk":"@@ -111,6 +111,8 @@ func loginV1(authConfig *cliconfig.AuthConfig, registryEndpoint *Endpoint, facto\n \t\tserverAddress = authConfig.ServerAddress\n \t)\n \n+\tclient.Transport = transport.NewTransport(client.Transport, DockerHeaders(nil)...)","path":"registry/auth.go","position":52,"original_position":52,"commit_id":"028b5623479cbef4be2f4b8e691794d69b392e0b","original_commit_id":"028b5623479cbef4be2f4b8e691794d69b392e0b","user":{"login":"tiborvass","id":827131,"avatar_url":"https://avatars.githubusercontent.com/u/827131?v=3","gravatar_id":"","url":"https://api.github.com/users/tiborvass","html_url":"https://github.com/tiborvass","followers_url":"https://api.github.com/users/tiborvass/followers","following_url":"https://api.github.com/users/tiborvass/following{/other_user}","gists_url":"https://api.github.com/users/tiborvass/gists{/gist_id}","starred_url":"https://api.github.com/users/tiborvass/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiborvass/subscriptions","organizations_url":"https://api.github.com/users/tiborvass/orgs","repos_url":"https://api.github.com/users/tiborvass/repos","events_url":"https://api.github.com/users/tiborvass/events{/privacy}","received_events_url":"https://api.github.com/users/tiborvass/received_events","type":"User","site_admin":false},"body":"`DockerHeaders` comes from https://github.com/docker/docker/pull/13265/files#diff-2b07b8a4e93be324f246494ec743cde2L35 where a call to `HTTPRequestFactory` is made and passed down to `Login()` and then to `loginV1()` (this function)","created_at":"2015-05-17T17:58:53Z","updated_at":"2015-05-17T17:58:53Z","html_url":"https://github.com/docker/docker/pull/13265#discussion_r30472745","pull_request_url":"https://api.github.com/repos/docker/docker/pulls/13265","_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/comments/30472745"},"html":{"href":"https://github.com/docker/docker/pull/13265#discussion_r30472745"},"pull_request":{"href":"https://api.github.com/repos/docker/docker/pulls/13265"}}},"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/13265","id":35552552,"html_url":"https://github.com/docker/docker/pull/13265","diff_url":"https://github.com/docker/docker/pull/13265.diff","patch_url":"https://github.com/docker/docker/pull/13265.patch","issue_url":"https://api.github.com/repos/docker/docker/issues/13265","number":13265,"state":"open","locked":false,"title":"registry: Refactor requestfactory to use http.RoundTrippers","user":{"login":"tiborvass","id":827131,"avatar_url":"https://avatars.githubusercontent.com/u/827131?v=3","gravatar_id":"","url":"https://api.github.com/users/tiborvass","html_url":"https://github.com/tiborvass","followers_url":"https://api.github.com/users/tiborvass/followers","following_url":"https://api.github.com/users/tiborvass/following{/other_user}","gists_url":"https://api.github.com/users/tiborvass/gists{/gist_id}","starred_url":"https://api.github.com/users/tiborvass/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiborvass/subscriptions","organizations_url":"https://api.github.com/users/tiborvass/orgs","repos_url":"https://api.github.com/users/tiborvass/repos","events_url":"https://api.github.com/users/tiborvass/events{/privacy}","received_events_url":"https://api.github.com/users/tiborvass/received_events","type":"User","site_admin":false},"body":"Replaces #13254 (messed up github)\r\n\r\nThis patch removes the need for requestFactories and decorators\r\nby implementing http.RoundTripper transports instead.\r\n\r\nIt refactors some challenging-to-read code.\r\n\r\nNewSession now takes an *http.Client that can already have a\r\ncustom Transport, it will add its own auth transport by wrapping\r\nit.\r\n\r\nThe idea is that callers of http.Client should not bother\r\nsetting custom headers for every handler but instead it should\r\nbe transparent to the callers of a same context.\r\n\r\nThis patch is needed for future refactorings of registry,\r\nnamely refactoring of the v1 client code.\r\n\r\nSigned-off-by: Tibor Vass <tibor@docker.com>","created_at":"2015-05-15T21:28:34Z","updated_at":"2015-05-17T17:58:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2334107b179267fdc581c381ac0ee893eeaafe9a","assignee":null,"milestone":{"url":"https://api.github.com/repos/docker/docker/milestones/38","html_url":"https://github.com/docker/docker/milestones/1.7.0","labels_url":"https://api.github.com/repos/docker/docker/milestones/38/labels","id":1010239,"number":38,"title":"1.7.0","description":"Freeze May 26\r\nRelease  June 16","creator":{"login":"dmcgowan","id":169601,"avatar_url":"https://avatars.githubusercontent.com/u/169601?v=3","gravatar_id":"","url":"https://api.github.com/users/dmcgowan","html_url":"https://github.com/dmcgowan","followers_url":"https://api.github.com/users/dmcgowan/followers","following_url":"https://api.github.com/users/dmcgowan/following{/other_user}","gists_url":"https://api.github.com/users/dmcgowan/gists{/gist_id}","starred_url":"https://api.github.com/users/dmcgowan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmcgowan/subscriptions","organizations_url":"https://api.github.com/users/dmcgowan/orgs","repos_url":"https://api.github.com/users/dmcgowan/repos","events_url":"https://api.github.com/users/dmcgowan/events{/privacy}","received_events_url":"https://api.github.com/users/dmcgowan/received_events","type":"User","site_admin":false},"open_issues":19,"closed_issues":20,"state":"open","created_at":"2015-03-07T01:54:49Z","updated_at":"2015-05-16T06:26:18Z","due_on":"2015-05-26T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/docker/docker/pulls/13265/commits","review_comments_url":"https://api.github.com/repos/docker/docker/pulls/13265/comments","review_comment_url":"https://api.github.com/repos/docker/docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/docker/issues/13265/comments","statuses_url":"https://api.github.com/repos/docker/docker/statuses/028b5623479cbef4be2f4b8e691794d69b392e0b","head":{"label":"tiborvass:refactor-v1-auth","ref":"refactor-v1-auth","sha":"028b5623479cbef4be2f4b8e691794d69b392e0b","user":{"login":"tiborvass","id":827131,"avatar_url":"https://avatars.githubusercontent.com/u/827131?v=3","gravatar_id":"","url":"https://api.github.com/users/tiborvass","html_url":"https://github.com/tiborvass","followers_url":"https://api.github.com/users/tiborvass/followers","following_url":"https://api.github.com/users/tiborvass/following{/other_user}","gists_url":"https://api.github.com/users/tiborvass/gists{/gist_id}","starred_url":"https://api.github.com/users/tiborvass/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiborvass/subscriptions","organizations_url":"https://api.github.com/users/tiborvass/orgs","repos_url":"https://api.github.com/users/tiborvass/repos","events_url":"https://api.github.com/users/tiborvass/events{/privacy}","received_events_url":"https://api.github.com/users/tiborvass/received_events","type":"User","site_admin":false},"repo":{"id":16678776,"name":"docker","full_name":"tiborvass/docker","owner":{"login":"tiborvass","id":827131,"avatar_url":"https://avatars.githubusercontent.com/u/827131?v=3","gravatar_id":"","url":"https://api.github.com/users/tiborvass","html_url":"https://github.com/tiborvass","followers_url":"https://api.github.com/users/tiborvass/followers","following_url":"https://api.github.com/users/tiborvass/following{/other_user}","gists_url":"https://api.github.com/users/tiborvass/gists{/gist_id}","starred_url":"https://api.github.com/users/tiborvass/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiborvass/subscriptions","organizations_url":"https://api.github.com/users/tiborvass/orgs","repos_url":"https://api.github.com/users/tiborvass/repos","events_url":"https://api.github.com/users/tiborvass/events{/privacy}","received_events_url":"https://api.github.com/users/tiborvass/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tiborvass/docker","description":"Docker - the open-source application container engine","fork":true,"url":"https://api.github.com/repos/tiborvass/docker","forks_url":"https://api.github.com/repos/tiborvass/docker/forks","keys_url":"https://api.github.com/repos/tiborvass/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tiborvass/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tiborvass/docker/teams","hooks_url":"https://api.github.com/repos/tiborvass/docker/hooks","issue_events_url":"https://api.github.com/repos/tiborvass/docker/issues/events{/number}","events_url":"https://api.github.com/repos/tiborvass/docker/events","assignees_url":"https://api.github.com/repos/tiborvass/docker/assignees{/user}","branches_url":"https://api.github.com/repos/tiborvass/docker/branches{/branch}","tags_url":"https://api.github.com/repos/tiborvass/docker/tags","blobs_url":"https://api.github.com/repos/tiborvass/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tiborvass/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tiborvass/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/tiborvass/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tiborvass/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/tiborvass/docker/languages","stargazers_url":"https://api.github.com/repos/tiborvass/docker/stargazers","contributors_url":"https://api.github.com/repos/tiborvass/docker/contributors","subscribers_url":"https://api.github.com/repos/tiborvass/docker/subscribers","subscription_url":"https://api.github.com/repos/tiborvass/docker/subscription","commits_url":"https://api.github.com/repos/tiborvass/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/tiborvass/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/tiborvass/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/tiborvass/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/tiborvass/docker/contents/{+path}","compare_url":"https://api.github.com/repos/tiborvass/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tiborvass/docker/merges","archive_url":"https://api.github.com/repos/tiborvass/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tiborvass/docker/downloads","issues_url":"https://api.github.com/repos/tiborvass/docker/issues{/number}","pulls_url":"https://api.github.com/repos/tiborvass/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/tiborvass/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/tiborvass/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tiborvass/docker/labels{/name}","releases_url":"https://api.github.com/repos/tiborvass/docker/releases{/id}","created_at":"2014-02-09T23:31:28Z","updated_at":"2014-07-24T21:22:38Z","pushed_at":"2015-05-17T17:42:37Z","git_url":"git://github.com/tiborvass/docker.git","ssh_url":"git@github.com:tiborvass/docker.git","clone_url":"https://github.com/tiborvass/docker.git","svn_url":"https://github.com/tiborvass/docker","homepage":"http://www.docker.io","size":56855,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"9c5635a2a08029d440aca6179fb5cd1ffcda6f0e","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":7691631,"name":"docker","full_name":"docker/docker","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/docker","description":"Docker - the open-source application container engine","fork":false,"url":"https://api.github.com/repos/docker/docker","forks_url":"https://api.github.com/repos/docker/docker/forks","keys_url":"https://api.github.com/repos/docker/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/docker/teams","hooks_url":"https://api.github.com/repos/docker/docker/hooks","issue_events_url":"https://api.github.com/repos/docker/docker/issues/events{/number}","events_url":"https://api.github.com/repos/docker/docker/events","assignees_url":"https://api.github.com/repos/docker/docker/assignees{/user}","branches_url":"https://api.github.com/repos/docker/docker/branches{/branch}","tags_url":"https://api.github.com/repos/docker/docker/tags","blobs_url":"https://api.github.com/repos/docker/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/docker/languages","stargazers_url":"https://api.github.com/repos/docker/docker/stargazers","contributors_url":"https://api.github.com/repos/docker/docker/contributors","subscribers_url":"https://api.github.com/repos/docker/docker/subscribers","subscription_url":"https://api.github.com/repos/docker/docker/subscription","commits_url":"https://api.github.com/repos/docker/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/docker/contents/{+path}","compare_url":"https://api.github.com/repos/docker/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/docker/merges","archive_url":"https://api.github.com/repos/docker/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/docker/downloads","issues_url":"https://api.github.com/repos/docker/docker/issues{/number}","pulls_url":"https://api.github.com/repos/docker/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/docker/labels{/name}","releases_url":"https://api.github.com/repos/docker/docker/releases{/id}","created_at":"2013-01-18T18:10:57Z","updated_at":"2015-05-17T17:09:38Z","pushed_at":"2015-05-17T17:42:41Z","git_url":"git://github.com/docker/docker.git","ssh_url":"git@github.com:docker/docker.git","clone_url":"https://github.com/docker/docker.git","svn_url":"https://github.com/docker/docker","homepage":"http://www.docker.com","size":207587,"stargazers_count":21707,"watchers_count":21707,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5085,"mirror_url":null,"open_issues_count":999,"forks":5085,"open_issues":999,"watchers":21707,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/13265"},"html":{"href":"https://github.com/docker/docker/pull/13265"},"issue":{"href":"https://api.github.com/repos/docker/docker/issues/13265"},"comments":{"href":"https://api.github.com/repos/docker/docker/issues/13265/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/docker/pulls/13265/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/docker/pulls/13265/commits"},"statuses":{"href":"https://api.github.com/repos/docker/docker/statuses/028b5623479cbef4be2f4b8e691794d69b392e0b"}}}}