{"action":"created","issue":{"url":"https://api.github.com/repos/skanaar/nomnoml/issues/19","labels_url":"https://api.github.com/repos/skanaar/nomnoml/issues/19/labels{/name}","comments_url":"https://api.github.com/repos/skanaar/nomnoml/issues/19/comments","events_url":"https://api.github.com/repos/skanaar/nomnoml/issues/19/events","html_url":"https://github.com/skanaar/nomnoml/issues/19","id":84193047,"number":19,"title":"Confusion when using save button on edited shareable link diagram","user":{"login":"amoosbr","id":1031218,"avatar_url":"https://avatars.githubusercontent.com/u/1031218?v=3","gravatar_id":"","url":"https://api.github.com/users/amoosbr","html_url":"https://github.com/amoosbr","followers_url":"https://api.github.com/users/amoosbr/followers","following_url":"https://api.github.com/users/amoosbr/following{/other_user}","gists_url":"https://api.github.com/users/amoosbr/gists{/gist_id}","starred_url":"https://api.github.com/users/amoosbr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amoosbr/subscriptions","organizations_url":"https://api.github.com/users/amoosbr/orgs","repos_url":"https://api.github.com/users/amoosbr/repos","events_url":"https://api.github.com/users/amoosbr/events{/privacy}","received_events_url":"https://api.github.com/users/amoosbr/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-06-02T20:18:09Z","updated_at":"2015-06-04T07:30:20Z","closed_at":null,"body":"Hi Skanaar,\r\n\r\nthank you for starting this great project. I really like using it.\r\nWhile using nomnoml in the team, one function lead to some confusion. It is related to the 'save' button functionality on a shareable link diagram (the one at the top middle).\r\n\r\nThe one interpretation is, that no changes are saved to local storage after clicking on ok.\r\nAnd the other, in my team, more common interpretation, was that changes 'by default' are not saved automatically to local storage, but will be saved when clicking on the save button.\r\nPart of the confusion is probably related to the confirm message dialog, which reads as\r\n\"Do you want to overwrite the diagram in localStorage with the currently viewed diagram?\".\r\nSo, most of us thought that by clicking save the modified document would then be saved to local storage. Instead, the local storage was set to the content of the shareable link.\r\n\r\nI just wanted to give you some feedback, from what we experienced by using nomnoml.\r\n\r\nIn my fork, I modified the save button to save the edited content to local storage. But if you want to keep functionality as is, perhaps you can modify the confirm message and make clear, that possible changes will be lost.\r\n\r\nThanks"},"comment":{"url":"https://api.github.com/repos/skanaar/nomnoml/issues/comments/108765473","html_url":"https://github.com/skanaar/nomnoml/issues/19#issuecomment-108765473","issue_url":"https://api.github.com/repos/skanaar/nomnoml/issues/19","id":108765473,"user":{"login":"skanaar","id":641015,"avatar_url":"https://avatars.githubusercontent.com/u/641015?v=3","gravatar_id":"","url":"https://api.github.com/users/skanaar","html_url":"https://github.com/skanaar","followers_url":"https://api.github.com/users/skanaar/followers","following_url":"https://api.github.com/users/skanaar/following{/other_user}","gists_url":"https://api.github.com/users/skanaar/gists{/gist_id}","starred_url":"https://api.github.com/users/skanaar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skanaar/subscriptions","organizations_url":"https://api.github.com/users/skanaar/orgs","repos_url":"https://api.github.com/users/skanaar/repos","events_url":"https://api.github.com/users/skanaar/events{/privacy}","received_events_url":"https://api.github.com/users/skanaar/received_events","type":"User","site_admin":false},"created_at":"2015-06-04T07:30:20Z","updated_at":"2015-06-04T07:30:20Z","body":"Thanks for reporting, will look into this"}}