{"action":"created","issue":{"url":"https://api.github.com/repos/mmoss/cryptopp/issues/3","labels_url":"https://api.github.com/repos/mmoss/cryptopp/issues/3/labels{/name}","comments_url":"https://api.github.com/repos/mmoss/cryptopp/issues/3/comments","events_url":"https://api.github.com/repos/mmoss/cryptopp/issues/3/events","html_url":"https://github.com/mmoss/cryptopp/issues/3","id":123840048,"number":3,"title":"Crypto++ is accepting contributions","user":{"login":"noloader","id":3538226,"avatar_url":"https://avatars.githubusercontent.com/u/3538226?v=3","gravatar_id":"","url":"https://api.github.com/users/noloader","html_url":"https://github.com/noloader","followers_url":"https://api.github.com/users/noloader/followers","following_url":"https://api.github.com/users/noloader/following{/other_user}","gists_url":"https://api.github.com/users/noloader/gists{/gist_id}","starred_url":"https://api.github.com/users/noloader/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noloader/subscriptions","organizations_url":"https://api.github.com/users/noloader/orgs","repos_url":"https://api.github.com/users/noloader/repos","events_url":"https://api.github.com/users/noloader/events{/privacy}","received_events_url":"https://api.github.com/users/noloader/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-12-24T23:47:29Z","updated_at":"2015-12-26T23:19:04Z","closed_at":null,"body":"Please mark this as a non-bug. Scons caught my eye, and I did not know how to reach out to you.\r\n\r\nWei Dai, the author of Crypto++, has basically turned control of the library over to the community. If you feel `scons` wold be a helpful addition, then please clone Wei's [Crypto++ GitHub](https://github.com/weidai11/cryptopp) and make a pull request.\r\n\r\nThe [latest GNUmakefile](http://github.com/weidai11/cryptopp/blob/master/GNUmakefile#L300) has the following recipe. You should be able to use it to update your file list.\r\n\r\n```\r\n# Used to generate list of source files for Autotools, CMakeList and Android.mk\r\n.PHONY: sources\r\nsources:\r\n\t$(info Library sources: $(filter-out fipstest.cpp $(TESTSRCS),$(SRCS)))\r\n\t$(info )\r\n\t$(info Test sources: $(TESTSRCS))\r\n```\r\n\r\nYou can use it to generate the source list because here's the rule to build the shared object. `LIBOBJS` is derived with `LIBOBJS := $(filter-out $(TESTOBJS),$(OBJS))`. \r\n\r\n```\r\nlibcryptopp.so: public_service | $(LIBOBJS)\r\n\t$(CXX) -shared -o $@ $(CXXFLAGS) $(GOLD_OPTION) $(LIBOBJS) $(LDLIBS)\r\n```\r\n\r\nCrypto++ 5.6.3 also squahed the Type Limits/Tautological compare warnings, so you will not need the `-Wtautological-compare` in:\r\n\r\n    env.AppendUnique(CCFLAGS = '-g -Wtautological-compare')\r\n\r\nHowever, you *usually* want `-DNDEBUG` for release builds. Its stops an occasional `assert` that's meant to provide additional debug information (and not crash a production program).\r\n\r\nI'm one of the folks who have check-in privileges, so I can say for certain it will be checked-in if no one objects. The pull request ensure you will receive the proper credit for your contributions. I'm happy to drop the file by hand and perform the check-in if you want to avoid the recognition."},"comment":{"url":"https://api.github.com/repos/mmoss/cryptopp/issues/comments/167371078","html_url":"https://github.com/mmoss/cryptopp/issues/3#issuecomment-167371078","issue_url":"https://api.github.com/repos/mmoss/cryptopp/issues/3","id":167371078,"user":{"login":"noloader","id":3538226,"avatar_url":"https://avatars.githubusercontent.com/u/3538226?v=3","gravatar_id":"","url":"https://api.github.com/users/noloader","html_url":"https://github.com/noloader","followers_url":"https://api.github.com/users/noloader/followers","following_url":"https://api.github.com/users/noloader/following{/other_user}","gists_url":"https://api.github.com/users/noloader/gists{/gist_id}","starred_url":"https://api.github.com/users/noloader/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noloader/subscriptions","organizations_url":"https://api.github.com/users/noloader/orgs","repos_url":"https://api.github.com/users/noloader/repos","events_url":"https://api.github.com/users/noloader/events{/privacy}","received_events_url":"https://api.github.com/users/noloader/received_events","type":"User","site_admin":false},"created_at":"2015-12-26T23:19:04Z","updated_at":"2015-12-26T23:19:04Z","body":"> I'll take a look and find some time to try and contribute. I know a few folks have found this version of the project to be helpful, and I'd love to contribute.\r\n\r\nWe'd love to see you at [Crypto++ | Contributors](https://github.com/weidai11/cryptopp/graphs/contributors).\r\n\r\nA lot of projects shy away from community contributions. I have no problem with them because I'll work it into the testing regime. If there's a weak spot, then [cryptest.sh](https://github.com/weidai11/cryptopp/blob/master/cryptest.sh) on [20 or 30 platforms](http://cryptopp.com/wiki/Release_process#The_Mashup) will uncover it. In this case, I send you the feedback and you make another pull request to address the issue. If there's no complaints from the testing process, then we are done and everyone is happy :) "}}