{"action":"created","comment":{"url":"https://api.github.com/repos/MAP-NCU2015/Lesson-03-JavaScriptBestPratice-HW/pulls/comments/42836549","id":42836549,"diff_hunk":"@@ -52,28 +45,48 @@\n       buff.appendChild(li);\n     });\n     ul.appendChild(buff);\n-    _wrapper.appendChild(ul);\n-  }\n+    this._wrapper.appendChild(ul);\n+  },\n \n-  function fetchList(afterFetch) {\n-    var xhr = new XMLHttpRequest();\n-    xhr.open('GET', 'http://127.0.0.1:8000/demo-list-notes.json', true);\n-    xhr.responseType = 'json';\n-    xhr.onreadystatechange = function(e) {\n-      // Watch out: we have a mysterious unknown 'this'.\n-      if (this.readyState === 4 && this.status === 200) {\n-        var listData = this.response;\n-        // The flow ends here.\n-        afterFetch(listData);\n-      } else if (this.status !== 200 ){\n-        // Ignore error in this case.\n-      }\n-    };\n-    xhr.send();\n-  }\n+  fetchList(url) {\n+    return new Promise(function(reslove, reject) {","path":"homework/list.js","position":88,"original_position":88,"commit_id":"a4cca73bf4979cd039050a9991ab0fe886036290","original_commit_id":"a4cca73bf4979cd039050a9991ab0fe886036290","user":{"login":"snowmantw","id":129153,"avatar_url":"https://avatars.githubusercontent.com/u/129153?v=3","gravatar_id":"","url":"https://api.github.com/users/snowmantw","html_url":"https://github.com/snowmantw","followers_url":"https://api.github.com/users/snowmantw/followers","following_url":"https://api.github.com/users/snowmantw/following{/other_user}","gists_url":"https://api.github.com/users/snowmantw/gists{/gist_id}","starred_url":"https://api.github.com/users/snowmantw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snowmantw/subscriptions","organizations_url":"https://api.github.com/users/snowmantw/orgs","repos_url":"https://api.github.com/users/snowmantw/repos","events_url":"https://api.github.com/users/snowmantw/events{/privacy}","received_events_url":"https://api.github.com/users/snowmantw/received_events","type":"User","site_admin":false},"body":"Typo: reslove -> resolve\r\n\r\n(Although as an argument name it still works well)","created_at":"2015-10-23T06:29:55Z","updated_at":"2015-10-23T06:29:55Z","html_url":"https://github.com/MAP-NCU2015/Lesson-03-JavaScriptBestPratice-HW/pull/8#discussion_r42836549","pull_request_url":"https://api.github.com/repos/MAP-NCU2015/Lesson-03-JavaScriptBestPratice-HW/pulls/8","_links":{"self":{"href":"https://api.github.com/repos/MAP-NCU2015/Lesson-03-JavaScriptBestPratice-HW/pulls/comments/42836549"},"html":{"href":"https://github.com/MAP-NCU2015/Lesson-03-JavaScriptBestPratice-HW/pull/8#discussion_r42836549"},"pull_request":{"href":"https://api.github.com/repos/MAP-NCU2015/Lesson-03-JavaScriptBestPratice-HW/pulls/8"}}},"pull_request":{"url":"https://api.github.com/repos/MAP-NCU2015/Lesson-03-JavaScriptBestPratice-HW/pulls/8","id":47859712,"html_url":"https://github.com/MAP-NCU2015/Lesson-03-JavaScriptBestPratice-HW/pull/8","diff_url":"https://github.com/MAP-NCU2015/Lesson-03-JavaScriptBestPratice-HW/pull/8.diff","patch_url":"https://github.com/MAP-NCU2015/Lesson-03-JavaScriptBestPratice-HW/pull/8.patch","issue_url":"https://api.github.com/repos/MAP-NCU2015/Lesson-03-JavaScriptBestPratice-HW/issues/8","number":8,"state":"open","locked":false,"title":"Homework","user":{"login":"rockwyc992","id":5278108,"avatar_url":"https://avatars.githubusercontent.com/u/5278108?v=3","gravatar_id":"","url":"https://api.github.com/users/rockwyc992","html_url":"https://github.com/rockwyc992","followers_url":"https://api.github.com/users/rockwyc992/followers","following_url":"https://api.github.com/users/rockwyc992/following{/other_user}","gists_url":"https://api.github.com/users/rockwyc992/gists{/gist_id}","starred_url":"https://api.github.com/users/rockwyc992/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rockwyc992/subscriptions","organizations_url":"https://api.github.com/users/rockwyc992/orgs","repos_url":"https://api.github.com/users/rockwyc992/repos","events_url":"https://api.github.com/users/rockwyc992/events{/privacy}","received_events_url":"https://api.github.com/users/rockwyc992/received_events","type":"User","site_admin":false},"body":"review=?@snowmantw,@FlowerHop,@chungya \r\n\r\n已完成Tier1，不同的point建立個別的commit\r\n\r\n使用上課教的Manager module重新編寫部分的程式碼","created_at":"2015-10-16T00:42:22Z","updated_at":"2015-10-23T06:29:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a726c248b4e464ac3b7b49325b8998f250331b51","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/MAP-NCU2015/Lesson-03-JavaScriptBestPratice-HW/pulls/8/commits","review_comments_url":"https://api.github.com/repos/MAP-NCU2015/Lesson-03-JavaScriptBestPratice-HW/pulls/8/comments","review_comment_url":"https://api.github.com/repos/MAP-NCU2015/Lesson-03-JavaScriptBestPratice-HW/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MAP-NCU2015/Lesson-03-JavaScriptBestPratice-HW/issues/8/comments","statuses_url":"https://api.github.com/repos/MAP-NCU2015/Lesson-03-JavaScriptBestPratice-HW/statuses/a4cca73bf4979cd039050a9991ab0fe886036290","head":{"label":"rockwyc992:homework","ref":"homework","sha":"a4cca73bf4979cd039050a9991ab0fe886036290","user":{"login":"rockwyc992","id":5278108,"avatar_url":"https://avatars.githubusercontent.com/u/5278108?v=3","gravatar_id":"","url":"https://api.github.com/users/rockwyc992","html_url":"https://github.com/rockwyc992","followers_url":"https://api.github.com/users/rockwyc992/followers","following_url":"https://api.github.com/users/rockwyc992/following{/other_user}","gists_url":"https://api.github.com/users/rockwyc992/gists{/gist_id}","starred_url":"https://api.github.com/users/rockwyc992/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rockwyc992/subscriptions","organizations_url":"https://api.github.com/users/rockwyc992/orgs","repos_url":"https://api.github.com/users/rockwyc992/repos","events_url":"https://api.github.com/users/rockwyc992/events{/privacy}","received_events_url":"https://api.github.com/users/rockwyc992/received_events","type":"User","site_admin":false},"repo":{"id":43813941,"name":"Lesson-03-JavaScriptBestPratice-HW","full_name":"rockwyc992/Lesson-03-JavaScriptBestPratice-HW","owner":{"login":"rockwyc992","id":5278108,"avatar_url":"https://avatars.githubusercontent.com/u/5278108?v=3","gravatar_id":"","url":"https://api.github.com/users/rockwyc992","html_url":"https://github.com/rockwyc992","followers_url":"https://api.github.com/users/rockwyc992/followers","following_url":"https://api.github.com/users/rockwyc992/following{/other_user}","gists_url":"https://api.github.com/users/rockwyc992/gists{/gist_id}","starred_url":"https://api.github.com/users/rockwyc992/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rockwyc992/subscriptions","organizations_url":"https://api.github.com/users/rockwyc992/orgs","repos_url":"https://api.github.com/users/rockwyc992/repos","events_url":"https://api.github.com/users/rockwyc992/events{/privacy}","received_events_url":"https://api.github.com/users/rockwyc992/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rockwyc992/Lesson-03-JavaScriptBestPratice-HW","description":"Homework","fork":true,"url":"https://api.github.com/repos/rockwyc992/Lesson-03-JavaScriptBestPratice-HW","forks_url":"https://api.github.com/repos/rockwyc992/Lesson-03-JavaScriptBestPratice-HW/forks","keys_url":"https://api.github.com/repos/rockwyc992/Lesson-03-JavaScriptBestPratice-HW/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rockwyc992/Lesson-03-JavaScriptBestPratice-HW/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rockwyc992/Lesson-03-JavaScriptBestPratice-HW/teams","hooks_url":"https://api.github.com/repos/rockwyc992/Lesson-03-JavaScriptBestPratice-HW/hooks","issue_events_url":"https://api.github.com/repos/rockwyc992/Lesson-03-JavaScriptBestPratice-HW/issues/events{/number}","events_url":"https://api.github.com/repos/rockwyc992/Lesson-03-JavaScriptBestPratice-HW/events","assignees_url":"https://api.github.com/repos/rockwyc992/Lesson-03-JavaScriptBestPratice-HW/assignees{/user}","branches_url":"https://api.github.com/repos/rockwyc992/Lesson-03-JavaScriptBestPratice-HW/branches{/branch}","tags_url":"https://api.github.com/repos/rockwyc992/Lesson-03-JavaScriptBestPratice-HW/tags","blobs_url":"https://api.github.com/repos/rockwyc992/Lesson-03-JavaScriptBestPratice-HW/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rockwyc992/Lesson-03-JavaScriptBestPratice-HW/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rockwyc992/Lesson-03-JavaScriptBestPratice-HW/git/refs{/sha}","trees_url":"https://api.github.com/repos/rockwyc992/Lesson-03-JavaScriptBestPratice-HW/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rockwyc992/Lesson-03-JavaScriptBestPratice-HW/statuses/{sha}","languages_url":"https://api.github.com/repos/rockwyc992/Lesson-03-JavaScriptBestPratice-HW/languages","stargazers_url":"https://api.github.com/repos/rockwyc992/Lesson-03-JavaScriptBestPratice-HW/stargazers","contributors_url":"https://api.github.com/repos/rockwyc992/Lesson-03-JavaScriptBestPratice-HW/contributors","subscribers_url":"https://api.github.com/repos/rockwyc992/Lesson-03-JavaScriptBestPratice-HW/subscribers","subscription_url":"https://api.github.com/repos/rockwyc992/Lesson-03-JavaScriptBestPratice-HW/subscription","commits_url":"https://api.github.com/repos/rockwyc992/Lesson-03-JavaScriptBestPratice-HW/commits{/sha}","git_commits_url":"https://api.github.com/repos/rockwyc992/Lesson-03-JavaScriptBestPratice-HW/git/commits{/sha}","comments_url":"https://api.github.com/repos/rockwyc992/Lesson-03-JavaScriptBestPratice-HW/comments{/number}","issue_comment_url":"https://api.github.com/repos/rockwyc992/Lesson-03-JavaScriptBestPratice-HW/issues/comments{/number}","contents_url":"https://api.github.com/repos/rockwyc992/Lesson-03-JavaScriptBestPratice-HW/contents/{+path}","compare_url":"https://api.github.com/repos/rockwyc992/Lesson-03-JavaScriptBestPratice-HW/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rockwyc992/Lesson-03-JavaScriptBestPratice-HW/merges","archive_url":"https://api.github.com/repos/rockwyc992/Lesson-03-JavaScriptBestPratice-HW/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rockwyc992/Lesson-03-JavaScriptBestPratice-HW/downloads","issues_url":"https://api.github.com/repos/rockwyc992/Lesson-03-JavaScriptBestPratice-HW/issues{/number}","pulls_url":"https://api.github.com/repos/rockwyc992/Lesson-03-JavaScriptBestPratice-HW/pulls{/number}","milestones_url":"https://api.github.com/repos/rockwyc992/Lesson-03-JavaScriptBestPratice-HW/milestones{/number}","notifications_url":"https://api.github.com/repos/rockwyc992/Lesson-03-JavaScriptBestPratice-HW/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rockwyc992/Lesson-03-JavaScriptBestPratice-HW/labels{/name}","releases_url":"https://api.github.com/repos/rockwyc992/Lesson-03-JavaScriptBestPratice-HW/releases{/id}","created_at":"2015-10-07T12:22:33Z","updated_at":"2015-10-07T12:22:33Z","pushed_at":"2015-10-15T02:48:49Z","git_url":"git://github.com/rockwyc992/Lesson-03-JavaScriptBestPratice-HW.git","ssh_url":"git@github.com:rockwyc992/Lesson-03-JavaScriptBestPratice-HW.git","clone_url":"https://github.com/rockwyc992/Lesson-03-JavaScriptBestPratice-HW.git","svn_url":"https://github.com/rockwyc992/Lesson-03-JavaScriptBestPratice-HW","homepage":null,"size":107,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"MAP-NCU2015:homework","ref":"homework","sha":"f5793106932580f974907d375e4765576fc923f4","user":{"login":"MAP-NCU2015","id":14105726,"avatar_url":"https://avatars.githubusercontent.com/u/14105726?v=3","gravatar_id":"","url":"https://api.github.com/users/MAP-NCU2015","html_url":"https://github.com/MAP-NCU2015","followers_url":"https://api.github.com/users/MAP-NCU2015/followers","following_url":"https://api.github.com/users/MAP-NCU2015/following{/other_user}","gists_url":"https://api.github.com/users/MAP-NCU2015/gists{/gist_id}","starred_url":"https://api.github.com/users/MAP-NCU2015/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MAP-NCU2015/subscriptions","organizations_url":"https://api.github.com/users/MAP-NCU2015/orgs","repos_url":"https://api.github.com/users/MAP-NCU2015/repos","events_url":"https://api.github.com/users/MAP-NCU2015/events{/privacy}","received_events_url":"https://api.github.com/users/MAP-NCU2015/received_events","type":"Organization","site_admin":false},"repo":{"id":42401840,"name":"Lesson-03-JavaScriptBestPratice-HW","full_name":"MAP-NCU2015/Lesson-03-JavaScriptBestPratice-HW","owner":{"login":"MAP-NCU2015","id":14105726,"avatar_url":"https://avatars.githubusercontent.com/u/14105726?v=3","gravatar_id":"","url":"https://api.github.com/users/MAP-NCU2015","html_url":"https://github.com/MAP-NCU2015","followers_url":"https://api.github.com/users/MAP-NCU2015/followers","following_url":"https://api.github.com/users/MAP-NCU2015/following{/other_user}","gists_url":"https://api.github.com/users/MAP-NCU2015/gists{/gist_id}","starred_url":"https://api.github.com/users/MAP-NCU2015/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MAP-NCU2015/subscriptions","organizations_url":"https://api.github.com/users/MAP-NCU2015/orgs","repos_url":"https://api.github.com/users/MAP-NCU2015/repos","events_url":"https://api.github.com/users/MAP-NCU2015/events{/privacy}","received_events_url":"https://api.github.com/users/MAP-NCU2015/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MAP-NCU2015/Lesson-03-JavaScriptBestPratice-HW","description":"Homework","fork":false,"url":"https://api.github.com/repos/MAP-NCU2015/Lesson-03-JavaScriptBestPratice-HW","forks_url":"https://api.github.com/repos/MAP-NCU2015/Lesson-03-JavaScriptBestPratice-HW/forks","keys_url":"https://api.github.com/repos/MAP-NCU2015/Lesson-03-JavaScriptBestPratice-HW/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MAP-NCU2015/Lesson-03-JavaScriptBestPratice-HW/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MAP-NCU2015/Lesson-03-JavaScriptBestPratice-HW/teams","hooks_url":"https://api.github.com/repos/MAP-NCU2015/Lesson-03-JavaScriptBestPratice-HW/hooks","issue_events_url":"https://api.github.com/repos/MAP-NCU2015/Lesson-03-JavaScriptBestPratice-HW/issues/events{/number}","events_url":"https://api.github.com/repos/MAP-NCU2015/Lesson-03-JavaScriptBestPratice-HW/events","assignees_url":"https://api.github.com/repos/MAP-NCU2015/Lesson-03-JavaScriptBestPratice-HW/assignees{/user}","branches_url":"https://api.github.com/repos/MAP-NCU2015/Lesson-03-JavaScriptBestPratice-HW/branches{/branch}","tags_url":"https://api.github.com/repos/MAP-NCU2015/Lesson-03-JavaScriptBestPratice-HW/tags","blobs_url":"https://api.github.com/repos/MAP-NCU2015/Lesson-03-JavaScriptBestPratice-HW/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MAP-NCU2015/Lesson-03-JavaScriptBestPratice-HW/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MAP-NCU2015/Lesson-03-JavaScriptBestPratice-HW/git/refs{/sha}","trees_url":"https://api.github.com/repos/MAP-NCU2015/Lesson-03-JavaScriptBestPratice-HW/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MAP-NCU2015/Lesson-03-JavaScriptBestPratice-HW/statuses/{sha}","languages_url":"https://api.github.com/repos/MAP-NCU2015/Lesson-03-JavaScriptBestPratice-HW/languages","stargazers_url":"https://api.github.com/repos/MAP-NCU2015/Lesson-03-JavaScriptBestPratice-HW/stargazers","contributors_url":"https://api.github.com/repos/MAP-NCU2015/Lesson-03-JavaScriptBestPratice-HW/contributors","subscribers_url":"https://api.github.com/repos/MAP-NCU2015/Lesson-03-JavaScriptBestPratice-HW/subscribers","subscription_url":"https://api.github.com/repos/MAP-NCU2015/Lesson-03-JavaScriptBestPratice-HW/subscription","commits_url":"https://api.github.com/repos/MAP-NCU2015/Lesson-03-JavaScriptBestPratice-HW/commits{/sha}","git_commits_url":"https://api.github.com/repos/MAP-NCU2015/Lesson-03-JavaScriptBestPratice-HW/git/commits{/sha}","comments_url":"https://api.github.com/repos/MAP-NCU2015/Lesson-03-JavaScriptBestPratice-HW/comments{/number}","issue_comment_url":"https://api.github.com/repos/MAP-NCU2015/Lesson-03-JavaScriptBestPratice-HW/issues/comments{/number}","contents_url":"https://api.github.com/repos/MAP-NCU2015/Lesson-03-JavaScriptBestPratice-HW/contents/{+path}","compare_url":"https://api.github.com/repos/MAP-NCU2015/Lesson-03-JavaScriptBestPratice-HW/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MAP-NCU2015/Lesson-03-JavaScriptBestPratice-HW/merges","archive_url":"https://api.github.com/repos/MAP-NCU2015/Lesson-03-JavaScriptBestPratice-HW/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MAP-NCU2015/Lesson-03-JavaScriptBestPratice-HW/downloads","issues_url":"https://api.github.com/repos/MAP-NCU2015/Lesson-03-JavaScriptBestPratice-HW/issues{/number}","pulls_url":"https://api.github.com/repos/MAP-NCU2015/Lesson-03-JavaScriptBestPratice-HW/pulls{/number}","milestones_url":"https://api.github.com/repos/MAP-NCU2015/Lesson-03-JavaScriptBestPratice-HW/milestones{/number}","notifications_url":"https://api.github.com/repos/MAP-NCU2015/Lesson-03-JavaScriptBestPratice-HW/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MAP-NCU2015/Lesson-03-JavaScriptBestPratice-HW/labels{/name}","releases_url":"https://api.github.com/repos/MAP-NCU2015/Lesson-03-JavaScriptBestPratice-HW/releases{/id}","created_at":"2015-09-13T15:48:05Z","updated_at":"2015-09-27T15:29:42Z","pushed_at":"2015-10-23T05:31:37Z","git_url":"git://github.com/MAP-NCU2015/Lesson-03-JavaScriptBestPratice-HW.git","ssh_url":"git@github.com:MAP-NCU2015/Lesson-03-JavaScriptBestPratice-HW.git","clone_url":"https://github.com/MAP-NCU2015/Lesson-03-JavaScriptBestPratice-HW.git","svn_url":"https://github.com/MAP-NCU2015/Lesson-03-JavaScriptBestPratice-HW","homepage":null,"size":1033,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":51,"mirror_url":null,"open_issues_count":16,"forks":51,"open_issues":16,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MAP-NCU2015/Lesson-03-JavaScriptBestPratice-HW/pulls/8"},"html":{"href":"https://github.com/MAP-NCU2015/Lesson-03-JavaScriptBestPratice-HW/pull/8"},"issue":{"href":"https://api.github.com/repos/MAP-NCU2015/Lesson-03-JavaScriptBestPratice-HW/issues/8"},"comments":{"href":"https://api.github.com/repos/MAP-NCU2015/Lesson-03-JavaScriptBestPratice-HW/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/MAP-NCU2015/Lesson-03-JavaScriptBestPratice-HW/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/MAP-NCU2015/Lesson-03-JavaScriptBestPratice-HW/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MAP-NCU2015/Lesson-03-JavaScriptBestPratice-HW/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/MAP-NCU2015/Lesson-03-JavaScriptBestPratice-HW/statuses/a4cca73bf4979cd039050a9991ab0fe886036290"}}}}