{"action":"created","comment":{"url":"https://api.github.com/repos/AbleTech/addressfinder-ruby/pulls/comments/45691025","id":45691025,"diff_hunk":"@@ -5,7 +5,7 @@ class Cleanse\n \n     attr_reader :result\n \n-    def initialize(q:, country: nil, delivered: nil, post_box: nil, rural: nil, region_code: nil, domain: nil, http:)\n+    def initialize(q:, key: nil, secret: nil, country: nil, delivered: nil, post_box: nil, rural: nil, region_code: nil, domain: nil, http:)","path":"lib/addressfinder/cleanse.rb","position":5,"original_position":5,"commit_id":"5f773d41ee154a0358cf7bf16d0d2f9714e69e0a","original_commit_id":"5f773d41ee154a0358cf7bf16d0d2f9714e69e0a","user":{"login":"nigelramsay","id":6838,"avatar_url":"https://avatars.githubusercontent.com/u/6838?v=3","gravatar_id":"","url":"https://api.github.com/users/nigelramsay","html_url":"https://github.com/nigelramsay","followers_url":"https://api.github.com/users/nigelramsay/followers","following_url":"https://api.github.com/users/nigelramsay/following{/other_user}","gists_url":"https://api.github.com/users/nigelramsay/gists{/gist_id}","starred_url":"https://api.github.com/users/nigelramsay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nigelramsay/subscriptions","organizations_url":"https://api.github.com/users/nigelramsay/orgs","repos_url":"https://api.github.com/users/nigelramsay/repos","events_url":"https://api.github.com/users/nigelramsay/events{/privacy}","received_events_url":"https://api.github.com/users/nigelramsay/received_events","type":"User","site_admin":false},"body":"move key and secret to last in the list of params (least important)","created_at":"2015-11-24T02:31:43Z","updated_at":"2015-11-24T02:31:43Z","html_url":"https://github.com/AbleTech/addressfinder-ruby/pull/8#discussion_r45691025","pull_request_url":"https://api.github.com/repos/AbleTech/addressfinder-ruby/pulls/8","_links":{"self":{"href":"https://api.github.com/repos/AbleTech/addressfinder-ruby/pulls/comments/45691025"},"html":{"href":"https://github.com/AbleTech/addressfinder-ruby/pull/8#discussion_r45691025"},"pull_request":{"href":"https://api.github.com/repos/AbleTech/addressfinder-ruby/pulls/8"}}},"pull_request":{"url":"https://api.github.com/repos/AbleTech/addressfinder-ruby/pulls/8","id":51605214,"html_url":"https://github.com/AbleTech/addressfinder-ruby/pull/8","diff_url":"https://github.com/AbleTech/addressfinder-ruby/pull/8.diff","patch_url":"https://github.com/AbleTech/addressfinder-ruby/pull/8.patch","issue_url":"https://api.github.com/repos/AbleTech/addressfinder-ruby/issues/8","number":8,"state":"open","locked":false,"title":"Feature/key secret override","user":{"login":"AlexB52","id":7149034,"avatar_url":"https://avatars.githubusercontent.com/u/7149034?v=3","gravatar_id":"","url":"https://api.github.com/users/AlexB52","html_url":"https://github.com/AlexB52","followers_url":"https://api.github.com/users/AlexB52/followers","following_url":"https://api.github.com/users/AlexB52/following{/other_user}","gists_url":"https://api.github.com/users/AlexB52/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexB52/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexB52/subscriptions","organizations_url":"https://api.github.com/users/AlexB52/orgs","repos_url":"https://api.github.com/users/AlexB52/repos","events_url":"https://api.github.com/users/AlexB52/events{/privacy}","received_events_url":"https://api.github.com/users/AlexB52/received_events","type":"User","site_admin":false},"body":"@nigelramsay \r\n\r\nHere is my take on the gem update.","created_at":"2015-11-24T01:21:30Z","updated_at":"2015-11-24T02:31:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"41843b2043db133042b8be92745e5ceecf8c4f33","assignee":{"login":"nigelramsay","id":6838,"avatar_url":"https://avatars.githubusercontent.com/u/6838?v=3","gravatar_id":"","url":"https://api.github.com/users/nigelramsay","html_url":"https://github.com/nigelramsay","followers_url":"https://api.github.com/users/nigelramsay/followers","following_url":"https://api.github.com/users/nigelramsay/following{/other_user}","gists_url":"https://api.github.com/users/nigelramsay/gists{/gist_id}","starred_url":"https://api.github.com/users/nigelramsay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nigelramsay/subscriptions","organizations_url":"https://api.github.com/users/nigelramsay/orgs","repos_url":"https://api.github.com/users/nigelramsay/repos","events_url":"https://api.github.com/users/nigelramsay/events{/privacy}","received_events_url":"https://api.github.com/users/nigelramsay/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/AbleTech/addressfinder-ruby/pulls/8/commits","review_comments_url":"https://api.github.com/repos/AbleTech/addressfinder-ruby/pulls/8/comments","review_comment_url":"https://api.github.com/repos/AbleTech/addressfinder-ruby/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AbleTech/addressfinder-ruby/issues/8/comments","statuses_url":"https://api.github.com/repos/AbleTech/addressfinder-ruby/statuses/5f773d41ee154a0358cf7bf16d0d2f9714e69e0a","head":{"label":"AbleTech:feature/key_secret_override","ref":"feature/key_secret_override","sha":"5f773d41ee154a0358cf7bf16d0d2f9714e69e0a","user":{"login":"AbleTech","id":504051,"avatar_url":"https://avatars.githubusercontent.com/u/504051?v=3","gravatar_id":"","url":"https://api.github.com/users/AbleTech","html_url":"https://github.com/AbleTech","followers_url":"https://api.github.com/users/AbleTech/followers","following_url":"https://api.github.com/users/AbleTech/following{/other_user}","gists_url":"https://api.github.com/users/AbleTech/gists{/gist_id}","starred_url":"https://api.github.com/users/AbleTech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AbleTech/subscriptions","organizations_url":"https://api.github.com/users/AbleTech/orgs","repos_url":"https://api.github.com/users/AbleTech/repos","events_url":"https://api.github.com/users/AbleTech/events{/privacy}","received_events_url":"https://api.github.com/users/AbleTech/received_events","type":"Organization","site_admin":false},"repo":{"id":42221153,"name":"addressfinder-ruby","full_name":"AbleTech/addressfinder-ruby","owner":{"login":"AbleTech","id":504051,"avatar_url":"https://avatars.githubusercontent.com/u/504051?v=3","gravatar_id":"","url":"https://api.github.com/users/AbleTech","html_url":"https://github.com/AbleTech","followers_url":"https://api.github.com/users/AbleTech/followers","following_url":"https://api.github.com/users/AbleTech/following{/other_user}","gists_url":"https://api.github.com/users/AbleTech/gists{/gist_id}","starred_url":"https://api.github.com/users/AbleTech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AbleTech/subscriptions","organizations_url":"https://api.github.com/users/AbleTech/orgs","repos_url":"https://api.github.com/users/AbleTech/repos","events_url":"https://api.github.com/users/AbleTech/events{/privacy}","received_events_url":"https://api.github.com/users/AbleTech/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AbleTech/addressfinder-ruby","description":"Ruby client gem for AddressFinder","fork":false,"url":"https://api.github.com/repos/AbleTech/addressfinder-ruby","forks_url":"https://api.github.com/repos/AbleTech/addressfinder-ruby/forks","keys_url":"https://api.github.com/repos/AbleTech/addressfinder-ruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AbleTech/addressfinder-ruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AbleTech/addressfinder-ruby/teams","hooks_url":"https://api.github.com/repos/AbleTech/addressfinder-ruby/hooks","issue_events_url":"https://api.github.com/repos/AbleTech/addressfinder-ruby/issues/events{/number}","events_url":"https://api.github.com/repos/AbleTech/addressfinder-ruby/events","assignees_url":"https://api.github.com/repos/AbleTech/addressfinder-ruby/assignees{/user}","branches_url":"https://api.github.com/repos/AbleTech/addressfinder-ruby/branches{/branch}","tags_url":"https://api.github.com/repos/AbleTech/addressfinder-ruby/tags","blobs_url":"https://api.github.com/repos/AbleTech/addressfinder-ruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AbleTech/addressfinder-ruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AbleTech/addressfinder-ruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/AbleTech/addressfinder-ruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AbleTech/addressfinder-ruby/statuses/{sha}","languages_url":"https://api.github.com/repos/AbleTech/addressfinder-ruby/languages","stargazers_url":"https://api.github.com/repos/AbleTech/addressfinder-ruby/stargazers","contributors_url":"https://api.github.com/repos/AbleTech/addressfinder-ruby/contributors","subscribers_url":"https://api.github.com/repos/AbleTech/addressfinder-ruby/subscribers","subscription_url":"https://api.github.com/repos/AbleTech/addressfinder-ruby/subscription","commits_url":"https://api.github.com/repos/AbleTech/addressfinder-ruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/AbleTech/addressfinder-ruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/AbleTech/addressfinder-ruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/AbleTech/addressfinder-ruby/issues/comments{/number}","contents_url":"https://api.github.com/repos/AbleTech/addressfinder-ruby/contents/{+path}","compare_url":"https://api.github.com/repos/AbleTech/addressfinder-ruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AbleTech/addressfinder-ruby/merges","archive_url":"https://api.github.com/repos/AbleTech/addressfinder-ruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AbleTech/addressfinder-ruby/downloads","issues_url":"https://api.github.com/repos/AbleTech/addressfinder-ruby/issues{/number}","pulls_url":"https://api.github.com/repos/AbleTech/addressfinder-ruby/pulls{/number}","milestones_url":"https://api.github.com/repos/AbleTech/addressfinder-ruby/milestones{/number}","notifications_url":"https://api.github.com/repos/AbleTech/addressfinder-ruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AbleTech/addressfinder-ruby/labels{/name}","releases_url":"https://api.github.com/repos/AbleTech/addressfinder-ruby/releases{/id}","created_at":"2015-09-10T04:02:04Z","updated_at":"2015-11-22T08:02:30Z","pushed_at":"2015-11-24T01:21:30Z","git_url":"git://github.com/AbleTech/addressfinder-ruby.git","ssh_url":"git@github.com:AbleTech/addressfinder-ruby.git","clone_url":"https://github.com/AbleTech/addressfinder-ruby.git","svn_url":"https://github.com/AbleTech/addressfinder-ruby","homepage":null,"size":46,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":1,"default_branch":"master"}},"base":{"label":"AbleTech:master","ref":"master","sha":"3c6a8c503a7adae5cba0c9b1cf58b18d62a67c44","user":{"login":"AbleTech","id":504051,"avatar_url":"https://avatars.githubusercontent.com/u/504051?v=3","gravatar_id":"","url":"https://api.github.com/users/AbleTech","html_url":"https://github.com/AbleTech","followers_url":"https://api.github.com/users/AbleTech/followers","following_url":"https://api.github.com/users/AbleTech/following{/other_user}","gists_url":"https://api.github.com/users/AbleTech/gists{/gist_id}","starred_url":"https://api.github.com/users/AbleTech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AbleTech/subscriptions","organizations_url":"https://api.github.com/users/AbleTech/orgs","repos_url":"https://api.github.com/users/AbleTech/repos","events_url":"https://api.github.com/users/AbleTech/events{/privacy}","received_events_url":"https://api.github.com/users/AbleTech/received_events","type":"Organization","site_admin":false},"repo":{"id":42221153,"name":"addressfinder-ruby","full_name":"AbleTech/addressfinder-ruby","owner":{"login":"AbleTech","id":504051,"avatar_url":"https://avatars.githubusercontent.com/u/504051?v=3","gravatar_id":"","url":"https://api.github.com/users/AbleTech","html_url":"https://github.com/AbleTech","followers_url":"https://api.github.com/users/AbleTech/followers","following_url":"https://api.github.com/users/AbleTech/following{/other_user}","gists_url":"https://api.github.com/users/AbleTech/gists{/gist_id}","starred_url":"https://api.github.com/users/AbleTech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AbleTech/subscriptions","organizations_url":"https://api.github.com/users/AbleTech/orgs","repos_url":"https://api.github.com/users/AbleTech/repos","events_url":"https://api.github.com/users/AbleTech/events{/privacy}","received_events_url":"https://api.github.com/users/AbleTech/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AbleTech/addressfinder-ruby","description":"Ruby client gem for AddressFinder","fork":false,"url":"https://api.github.com/repos/AbleTech/addressfinder-ruby","forks_url":"https://api.github.com/repos/AbleTech/addressfinder-ruby/forks","keys_url":"https://api.github.com/repos/AbleTech/addressfinder-ruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AbleTech/addressfinder-ruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AbleTech/addressfinder-ruby/teams","hooks_url":"https://api.github.com/repos/AbleTech/addressfinder-ruby/hooks","issue_events_url":"https://api.github.com/repos/AbleTech/addressfinder-ruby/issues/events{/number}","events_url":"https://api.github.com/repos/AbleTech/addressfinder-ruby/events","assignees_url":"https://api.github.com/repos/AbleTech/addressfinder-ruby/assignees{/user}","branches_url":"https://api.github.com/repos/AbleTech/addressfinder-ruby/branches{/branch}","tags_url":"https://api.github.com/repos/AbleTech/addressfinder-ruby/tags","blobs_url":"https://api.github.com/repos/AbleTech/addressfinder-ruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AbleTech/addressfinder-ruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AbleTech/addressfinder-ruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/AbleTech/addressfinder-ruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AbleTech/addressfinder-ruby/statuses/{sha}","languages_url":"https://api.github.com/repos/AbleTech/addressfinder-ruby/languages","stargazers_url":"https://api.github.com/repos/AbleTech/addressfinder-ruby/stargazers","contributors_url":"https://api.github.com/repos/AbleTech/addressfinder-ruby/contributors","subscribers_url":"https://api.github.com/repos/AbleTech/addressfinder-ruby/subscribers","subscription_url":"https://api.github.com/repos/AbleTech/addressfinder-ruby/subscription","commits_url":"https://api.github.com/repos/AbleTech/addressfinder-ruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/AbleTech/addressfinder-ruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/AbleTech/addressfinder-ruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/AbleTech/addressfinder-ruby/issues/comments{/number}","contents_url":"https://api.github.com/repos/AbleTech/addressfinder-ruby/contents/{+path}","compare_url":"https://api.github.com/repos/AbleTech/addressfinder-ruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AbleTech/addressfinder-ruby/merges","archive_url":"https://api.github.com/repos/AbleTech/addressfinder-ruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AbleTech/addressfinder-ruby/downloads","issues_url":"https://api.github.com/repos/AbleTech/addressfinder-ruby/issues{/number}","pulls_url":"https://api.github.com/repos/AbleTech/addressfinder-ruby/pulls{/number}","milestones_url":"https://api.github.com/repos/AbleTech/addressfinder-ruby/milestones{/number}","notifications_url":"https://api.github.com/repos/AbleTech/addressfinder-ruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AbleTech/addressfinder-ruby/labels{/name}","releases_url":"https://api.github.com/repos/AbleTech/addressfinder-ruby/releases{/id}","created_at":"2015-09-10T04:02:04Z","updated_at":"2015-11-22T08:02:30Z","pushed_at":"2015-11-24T01:21:30Z","git_url":"git://github.com/AbleTech/addressfinder-ruby.git","ssh_url":"git@github.com:AbleTech/addressfinder-ruby.git","clone_url":"https://github.com/AbleTech/addressfinder-ruby.git","svn_url":"https://github.com/AbleTech/addressfinder-ruby","homepage":null,"size":46,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AbleTech/addressfinder-ruby/pulls/8"},"html":{"href":"https://github.com/AbleTech/addressfinder-ruby/pull/8"},"issue":{"href":"https://api.github.com/repos/AbleTech/addressfinder-ruby/issues/8"},"comments":{"href":"https://api.github.com/repos/AbleTech/addressfinder-ruby/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/AbleTech/addressfinder-ruby/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/AbleTech/addressfinder-ruby/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AbleTech/addressfinder-ruby/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/AbleTech/addressfinder-ruby/statuses/5f773d41ee154a0358cf7bf16d0d2f9714e69e0a"}}}}