{"action":"created","comment":{"url":"https://api.github.com/repos/iojs/io.js/pulls/comments/23216498","id":23216498,"diff_hunk":"@@ -15,5 +15,20 @@\n 'use strict';\n \n var v8binding = process.binding('v8');\n-exports.getHeapStatistics = v8binding.getHeapStatistics;\n+var smalloc = require('smalloc');\n+\n+var data = smalloc.alloc(5, smalloc.Types.Uint32);","path":"lib/v8.js","position":7,"original_position":7,"commit_id":"c95f6a4fab00198f238839293362ff21bcecae15","original_commit_id":"c95f6a4fab00198f238839293362ff21bcecae15","user":{"login":"trevnorris","id":289174,"avatar_url":"https://avatars.githubusercontent.com/u/289174?v=3","gravatar_id":"","url":"https://api.github.com/users/trevnorris","html_url":"https://github.com/trevnorris","followers_url":"https://api.github.com/users/trevnorris/followers","following_url":"https://api.github.com/users/trevnorris/following{/other_user}","gists_url":"https://api.github.com/users/trevnorris/gists{/gist_id}","starred_url":"https://api.github.com/users/trevnorris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trevnorris/subscriptions","organizations_url":"https://api.github.com/users/trevnorris/orgs","repos_url":"https://api.github.com/users/trevnorris/repos","events_url":"https://api.github.com/users/trevnorris/events{/privacy}","received_events_url":"https://api.github.com/users/trevnorris/received_events","type":"User","site_admin":false},"body":"@bnoordhuis This isn't to say I don't like the idea of having a common way to cleanup memory on exit that's been allocated. It is annoying to constantly have to sort through so many extra lines in valgrind. Do you have those documented? Could use that as a starting point and possibly create a class or something that is used for allocations that need to be cleaned up on exit.","created_at":"2015-01-20T11:40:05Z","updated_at":"2015-01-20T11:40:05Z","html_url":"https://github.com/iojs/io.js/pull/469#discussion_r23216498","pull_request_url":"https://api.github.com/repos/iojs/io.js/pulls/469","_links":{"self":{"href":"https://api.github.com/repos/iojs/io.js/pulls/comments/23216498"},"html":{"href":"https://github.com/iojs/io.js/pull/469#discussion_r23216498"},"pull_request":{"href":"https://api.github.com/repos/iojs/io.js/pulls/469"}}},"pull_request":{"url":"https://api.github.com/repos/iojs/io.js/pulls/469","id":27517604,"html_url":"https://github.com/iojs/io.js/pull/469","diff_url":"https://github.com/iojs/io.js/pull/469.diff","patch_url":"https://github.com/iojs/io.js/pull/469.patch","issue_url":"https://api.github.com/repos/iojs/io.js/issues/469","number":469,"state":"open","locked":false,"title":"v8: optimize `getHeapStatistics`","user":{"login":"vkurchatkin","id":2993861,"avatar_url":"https://avatars.githubusercontent.com/u/2993861?v=3","gravatar_id":"","url":"https://api.github.com/users/vkurchatkin","html_url":"https://github.com/vkurchatkin","followers_url":"https://api.github.com/users/vkurchatkin/followers","following_url":"https://api.github.com/users/vkurchatkin/following{/other_user}","gists_url":"https://api.github.com/users/vkurchatkin/gists{/gist_id}","starred_url":"https://api.github.com/users/vkurchatkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vkurchatkin/subscriptions","organizations_url":"https://api.github.com/users/vkurchatkin/orgs","repos_url":"https://api.github.com/users/vkurchatkin/repos","events_url":"https://api.github.com/users/vkurchatkin/events{/privacy}","received_events_url":"https://api.github.com/users/vkurchatkin/received_events","type":"User","site_admin":false},"body":"Set statistics data to external uint32 array instead of creating object.\r\n\r\nR=@trevnorris or @bnoordhuis ?","created_at":"2015-01-16T16:32:59Z","updated_at":"2015-01-20T11:40:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"69797637d1338885b821f1ef45b964a08d56c538","assignee":{"login":"trevnorris","id":289174,"avatar_url":"https://avatars.githubusercontent.com/u/289174?v=3","gravatar_id":"","url":"https://api.github.com/users/trevnorris","html_url":"https://github.com/trevnorris","followers_url":"https://api.github.com/users/trevnorris/followers","following_url":"https://api.github.com/users/trevnorris/following{/other_user}","gists_url":"https://api.github.com/users/trevnorris/gists{/gist_id}","starred_url":"https://api.github.com/users/trevnorris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trevnorris/subscriptions","organizations_url":"https://api.github.com/users/trevnorris/orgs","repos_url":"https://api.github.com/users/trevnorris/repos","events_url":"https://api.github.com/users/trevnorris/events{/privacy}","received_events_url":"https://api.github.com/users/trevnorris/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/iojs/io.js/pulls/469/commits","review_comments_url":"https://api.github.com/repos/iojs/io.js/pulls/469/comments","review_comment_url":"https://api.github.com/repos/iojs/io.js/pulls/comments/{number}","comments_url":"https://api.github.com/repos/iojs/io.js/issues/469/comments","statuses_url":"https://api.github.com/repos/iojs/io.js/statuses/c95f6a4fab00198f238839293362ff21bcecae15","head":{"label":"vkurchatkin:heap-stats-opt","ref":"heap-stats-opt","sha":"c95f6a4fab00198f238839293362ff21bcecae15","user":{"login":"vkurchatkin","id":2993861,"avatar_url":"https://avatars.githubusercontent.com/u/2993861?v=3","gravatar_id":"","url":"https://api.github.com/users/vkurchatkin","html_url":"https://github.com/vkurchatkin","followers_url":"https://api.github.com/users/vkurchatkin/followers","following_url":"https://api.github.com/users/vkurchatkin/following{/other_user}","gists_url":"https://api.github.com/users/vkurchatkin/gists{/gist_id}","starred_url":"https://api.github.com/users/vkurchatkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vkurchatkin/subscriptions","organizations_url":"https://api.github.com/users/vkurchatkin/orgs","repos_url":"https://api.github.com/users/vkurchatkin/repos","events_url":"https://api.github.com/users/vkurchatkin/events{/privacy}","received_events_url":"https://api.github.com/users/vkurchatkin/received_events","type":"User","site_admin":false},"repo":{"id":28152690,"name":"io.js","full_name":"vkurchatkin/io.js","owner":{"login":"vkurchatkin","id":2993861,"avatar_url":"https://avatars.githubusercontent.com/u/2993861?v=3","gravatar_id":"","url":"https://api.github.com/users/vkurchatkin","html_url":"https://github.com/vkurchatkin","followers_url":"https://api.github.com/users/vkurchatkin/followers","following_url":"https://api.github.com/users/vkurchatkin/following{/other_user}","gists_url":"https://api.github.com/users/vkurchatkin/gists{/gist_id}","starred_url":"https://api.github.com/users/vkurchatkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vkurchatkin/subscriptions","organizations_url":"https://api.github.com/users/vkurchatkin/orgs","repos_url":"https://api.github.com/users/vkurchatkin/repos","events_url":"https://api.github.com/users/vkurchatkin/events{/privacy}","received_events_url":"https://api.github.com/users/vkurchatkin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vkurchatkin/io.js","description":"Evented IO for V8 JavaScript","fork":true,"url":"https://api.github.com/repos/vkurchatkin/io.js","forks_url":"https://api.github.com/repos/vkurchatkin/io.js/forks","keys_url":"https://api.github.com/repos/vkurchatkin/io.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vkurchatkin/io.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vkurchatkin/io.js/teams","hooks_url":"https://api.github.com/repos/vkurchatkin/io.js/hooks","issue_events_url":"https://api.github.com/repos/vkurchatkin/io.js/issues/events{/number}","events_url":"https://api.github.com/repos/vkurchatkin/io.js/events","assignees_url":"https://api.github.com/repos/vkurchatkin/io.js/assignees{/user}","branches_url":"https://api.github.com/repos/vkurchatkin/io.js/branches{/branch}","tags_url":"https://api.github.com/repos/vkurchatkin/io.js/tags","blobs_url":"https://api.github.com/repos/vkurchatkin/io.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vkurchatkin/io.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vkurchatkin/io.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/vkurchatkin/io.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vkurchatkin/io.js/statuses/{sha}","languages_url":"https://api.github.com/repos/vkurchatkin/io.js/languages","stargazers_url":"https://api.github.com/repos/vkurchatkin/io.js/stargazers","contributors_url":"https://api.github.com/repos/vkurchatkin/io.js/contributors","subscribers_url":"https://api.github.com/repos/vkurchatkin/io.js/subscribers","subscription_url":"https://api.github.com/repos/vkurchatkin/io.js/subscription","commits_url":"https://api.github.com/repos/vkurchatkin/io.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/vkurchatkin/io.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/vkurchatkin/io.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/vkurchatkin/io.js/issues/comments/{number}","contents_url":"https://api.github.com/repos/vkurchatkin/io.js/contents/{+path}","compare_url":"https://api.github.com/repos/vkurchatkin/io.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vkurchatkin/io.js/merges","archive_url":"https://api.github.com/repos/vkurchatkin/io.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vkurchatkin/io.js/downloads","issues_url":"https://api.github.com/repos/vkurchatkin/io.js/issues{/number}","pulls_url":"https://api.github.com/repos/vkurchatkin/io.js/pulls{/number}","milestones_url":"https://api.github.com/repos/vkurchatkin/io.js/milestones{/number}","notifications_url":"https://api.github.com/repos/vkurchatkin/io.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vkurchatkin/io.js/labels{/name}","releases_url":"https://api.github.com/repos/vkurchatkin/io.js/releases{/id}","created_at":"2014-12-17T19:47:50Z","updated_at":"2014-12-23T18:30:27Z","pushed_at":"2015-01-19T15:50:54Z","git_url":"git://github.com/vkurchatkin/io.js.git","ssh_url":"git@github.com:vkurchatkin/io.js.git","clone_url":"https://github.com/vkurchatkin/io.js.git","svn_url":"https://github.com/vkurchatkin/io.js","homepage":null,"size":118837,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"v0.12"}},"base":{"label":"iojs:v1.x","ref":"v1.x","sha":"ab04a434761cf66d107481d58798f36d3cb49d46","user":{"login":"iojs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/iojs","html_url":"https://github.com/iojs","followers_url":"https://api.github.com/users/iojs/followers","following_url":"https://api.github.com/users/iojs/following{/other_user}","gists_url":"https://api.github.com/users/iojs/gists{/gist_id}","starred_url":"https://api.github.com/users/iojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iojs/subscriptions","organizations_url":"https://api.github.com/users/iojs/orgs","repos_url":"https://api.github.com/users/iojs/repos","events_url":"https://api.github.com/users/iojs/events{/privacy}","received_events_url":"https://api.github.com/users/iojs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"io.js","full_name":"iojs/io.js","owner":{"login":"iojs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/iojs","html_url":"https://github.com/iojs","followers_url":"https://api.github.com/users/iojs/followers","following_url":"https://api.github.com/users/iojs/following{/other_user}","gists_url":"https://api.github.com/users/iojs/gists{/gist_id}","starred_url":"https://api.github.com/users/iojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iojs/subscriptions","organizations_url":"https://api.github.com/users/iojs/orgs","repos_url":"https://api.github.com/users/iojs/repos","events_url":"https://api.github.com/users/iojs/events{/privacy}","received_events_url":"https://api.github.com/users/iojs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/iojs/io.js","description":"A spork of Node.js with an open governance model","fork":false,"url":"https://api.github.com/repos/iojs/io.js","forks_url":"https://api.github.com/repos/iojs/io.js/forks","keys_url":"https://api.github.com/repos/iojs/io.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iojs/io.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iojs/io.js/teams","hooks_url":"https://api.github.com/repos/iojs/io.js/hooks","issue_events_url":"https://api.github.com/repos/iojs/io.js/issues/events{/number}","events_url":"https://api.github.com/repos/iojs/io.js/events","assignees_url":"https://api.github.com/repos/iojs/io.js/assignees{/user}","branches_url":"https://api.github.com/repos/iojs/io.js/branches{/branch}","tags_url":"https://api.github.com/repos/iojs/io.js/tags","blobs_url":"https://api.github.com/repos/iojs/io.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iojs/io.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iojs/io.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/iojs/io.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iojs/io.js/statuses/{sha}","languages_url":"https://api.github.com/repos/iojs/io.js/languages","stargazers_url":"https://api.github.com/repos/iojs/io.js/stargazers","contributors_url":"https://api.github.com/repos/iojs/io.js/contributors","subscribers_url":"https://api.github.com/repos/iojs/io.js/subscribers","subscription_url":"https://api.github.com/repos/iojs/io.js/subscription","commits_url":"https://api.github.com/repos/iojs/io.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/iojs/io.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/iojs/io.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/iojs/io.js/issues/comments/{number}","contents_url":"https://api.github.com/repos/iojs/io.js/contents/{+path}","compare_url":"https://api.github.com/repos/iojs/io.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iojs/io.js/merges","archive_url":"https://api.github.com/repos/iojs/io.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iojs/io.js/downloads","issues_url":"https://api.github.com/repos/iojs/io.js/issues{/number}","pulls_url":"https://api.github.com/repos/iojs/io.js/pulls{/number}","milestones_url":"https://api.github.com/repos/iojs/io.js/milestones{/number}","notifications_url":"https://api.github.com/repos/iojs/io.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iojs/io.js/labels{/name}","releases_url":"https://api.github.com/repos/iojs/io.js/releases{/id}","created_at":"2014-11-26T19:57:11Z","updated_at":"2015-01-20T11:31:40Z","pushed_at":"2015-01-20T01:40:10Z","git_url":"git://github.com/iojs/io.js.git","ssh_url":"git@github.com:iojs/io.js.git","clone_url":"https://github.com/iojs/io.js.git","svn_url":"https://github.com/iojs/io.js","homepage":"https://iojs.org","size":139724,"stargazers_count":8714,"watchers_count":8714,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":487,"mirror_url":null,"open_issues_count":127,"forks":487,"open_issues":127,"watchers":8714,"default_branch":"v1.x"}},"_links":{"self":{"href":"https://api.github.com/repos/iojs/io.js/pulls/469"},"html":{"href":"https://github.com/iojs/io.js/pull/469"},"issue":{"href":"https://api.github.com/repos/iojs/io.js/issues/469"},"comments":{"href":"https://api.github.com/repos/iojs/io.js/issues/469/comments"},"review_comments":{"href":"https://api.github.com/repos/iojs/io.js/pulls/469/comments"},"review_comment":{"href":"https://api.github.com/repos/iojs/io.js/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/iojs/io.js/pulls/469/commits"},"statuses":{"href":"https://api.github.com/repos/iojs/io.js/statuses/c95f6a4fab00198f238839293362ff21bcecae15"}}}}