{"action":"closed","number":1423,"pull_request":{"url":"https://api.github.com/repos/FreeRADIUS/freeradius-server/pulls/1423","id":52746665,"html_url":"https://github.com/FreeRADIUS/freeradius-server/pull/1423","diff_url":"https://github.com/FreeRADIUS/freeradius-server/pull/1423.diff","patch_url":"https://github.com/FreeRADIUS/freeradius-server/pull/1423.patch","issue_url":"https://api.github.com/repos/FreeRADIUS/freeradius-server/issues/1423","number":1423,"state":"closed","locked":false,"title":"Refactoring conditional directives for incomplete if conditions and else if wrappers.","user":{"login":"wmarquesr","id":7017961,"avatar_url":"https://avatars.githubusercontent.com/u/7017961?v=3","gravatar_id":"","url":"https://api.github.com/users/wmarquesr","html_url":"https://github.com/wmarquesr","followers_url":"https://api.github.com/users/wmarquesr/followers","following_url":"https://api.github.com/users/wmarquesr/following{/other_user}","gists_url":"https://api.github.com/users/wmarquesr/gists{/gist_id}","starred_url":"https://api.github.com/users/wmarquesr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmarquesr/subscriptions","organizations_url":"https://api.github.com/users/wmarquesr/orgs","repos_url":"https://api.github.com/users/wmarquesr/repos","events_url":"https://api.github.com/users/wmarquesr/events{/privacy}","received_events_url":"https://api.github.com/users/wmarquesr/received_events","type":"User","site_admin":false},"body":"A suggestion to compile entire statements and expressions, as suggested by code style guidelines from the Linux Kernel and practitioners.\r\n\r\n* [Linux kernel coding style](https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/CodingStyle#n892)\r\n* [Living in the #ifdef Hell](https://www.cqse.eu/en/blog/living-in-the-ifdef-hell/)\r\n\r\nIt might improve code understanding, maintainability and error-proneness.","created_at":"2015-12-05T04:29:59Z","updated_at":"2015-12-20T21:25:41Z","closed_at":"2015-12-20T21:25:41Z","merged_at":null,"merge_commit_sha":"c0374f5796f56d76d346356a47fc689811a75ef9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/FreeRADIUS/freeradius-server/pulls/1423/commits","review_comments_url":"https://api.github.com/repos/FreeRADIUS/freeradius-server/pulls/1423/comments","review_comment_url":"https://api.github.com/repos/FreeRADIUS/freeradius-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FreeRADIUS/freeradius-server/issues/1423/comments","statuses_url":"https://api.github.com/repos/FreeRADIUS/freeradius-server/statuses/6690fccae0400bdebbaad2415f272db3be74e448","head":{"label":"wmarquesr:v3.1.x","ref":"v3.1.x","sha":"6690fccae0400bdebbaad2415f272db3be74e448","user":{"login":"wmarquesr","id":7017961,"avatar_url":"https://avatars.githubusercontent.com/u/7017961?v=3","gravatar_id":"","url":"https://api.github.com/users/wmarquesr","html_url":"https://github.com/wmarquesr","followers_url":"https://api.github.com/users/wmarquesr/followers","following_url":"https://api.github.com/users/wmarquesr/following{/other_user}","gists_url":"https://api.github.com/users/wmarquesr/gists{/gist_id}","starred_url":"https://api.github.com/users/wmarquesr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmarquesr/subscriptions","organizations_url":"https://api.github.com/users/wmarquesr/orgs","repos_url":"https://api.github.com/users/wmarquesr/repos","events_url":"https://api.github.com/users/wmarquesr/events{/privacy}","received_events_url":"https://api.github.com/users/wmarquesr/received_events","type":"User","site_admin":false},"repo":{"id":47387659,"name":"freeradius-server","full_name":"wmarquesr/freeradius-server","owner":{"login":"wmarquesr","id":7017961,"avatar_url":"https://avatars.githubusercontent.com/u/7017961?v=3","gravatar_id":"","url":"https://api.github.com/users/wmarquesr","html_url":"https://github.com/wmarquesr","followers_url":"https://api.github.com/users/wmarquesr/followers","following_url":"https://api.github.com/users/wmarquesr/following{/other_user}","gists_url":"https://api.github.com/users/wmarquesr/gists{/gist_id}","starred_url":"https://api.github.com/users/wmarquesr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmarquesr/subscriptions","organizations_url":"https://api.github.com/users/wmarquesr/orgs","repos_url":"https://api.github.com/users/wmarquesr/repos","events_url":"https://api.github.com/users/wmarquesr/events{/privacy}","received_events_url":"https://api.github.com/users/wmarquesr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wmarquesr/freeradius-server","description":"The FreeRADIUS Server.  RADIUS, DHCP, and VMPS.","fork":true,"url":"https://api.github.com/repos/wmarquesr/freeradius-server","forks_url":"https://api.github.com/repos/wmarquesr/freeradius-server/forks","keys_url":"https://api.github.com/repos/wmarquesr/freeradius-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wmarquesr/freeradius-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wmarquesr/freeradius-server/teams","hooks_url":"https://api.github.com/repos/wmarquesr/freeradius-server/hooks","issue_events_url":"https://api.github.com/repos/wmarquesr/freeradius-server/issues/events{/number}","events_url":"https://api.github.com/repos/wmarquesr/freeradius-server/events","assignees_url":"https://api.github.com/repos/wmarquesr/freeradius-server/assignees{/user}","branches_url":"https://api.github.com/repos/wmarquesr/freeradius-server/branches{/branch}","tags_url":"https://api.github.com/repos/wmarquesr/freeradius-server/tags","blobs_url":"https://api.github.com/repos/wmarquesr/freeradius-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wmarquesr/freeradius-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wmarquesr/freeradius-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/wmarquesr/freeradius-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wmarquesr/freeradius-server/statuses/{sha}","languages_url":"https://api.github.com/repos/wmarquesr/freeradius-server/languages","stargazers_url":"https://api.github.com/repos/wmarquesr/freeradius-server/stargazers","contributors_url":"https://api.github.com/repos/wmarquesr/freeradius-server/contributors","subscribers_url":"https://api.github.com/repos/wmarquesr/freeradius-server/subscribers","subscription_url":"https://api.github.com/repos/wmarquesr/freeradius-server/subscription","commits_url":"https://api.github.com/repos/wmarquesr/freeradius-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/wmarquesr/freeradius-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/wmarquesr/freeradius-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/wmarquesr/freeradius-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/wmarquesr/freeradius-server/contents/{+path}","compare_url":"https://api.github.com/repos/wmarquesr/freeradius-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wmarquesr/freeradius-server/merges","archive_url":"https://api.github.com/repos/wmarquesr/freeradius-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wmarquesr/freeradius-server/downloads","issues_url":"https://api.github.com/repos/wmarquesr/freeradius-server/issues{/number}","pulls_url":"https://api.github.com/repos/wmarquesr/freeradius-server/pulls{/number}","milestones_url":"https://api.github.com/repos/wmarquesr/freeradius-server/milestones{/number}","notifications_url":"https://api.github.com/repos/wmarquesr/freeradius-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wmarquesr/freeradius-server/labels{/name}","releases_url":"https://api.github.com/repos/wmarquesr/freeradius-server/releases{/id}","created_at":"2015-12-04T07:07:38Z","updated_at":"2015-12-04T07:07:43Z","pushed_at":"2015-12-05T04:19:32Z","git_url":"git://github.com/wmarquesr/freeradius-server.git","ssh_url":"git@github.com:wmarquesr/freeradius-server.git","clone_url":"https://github.com/wmarquesr/freeradius-server.git","svn_url":"https://github.com/wmarquesr/freeradius-server","homepage":"http://freeradius.org","size":66098,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"v3.1.x"}},"base":{"label":"FreeRADIUS:v3.1.x","ref":"v3.1.x","sha":"23f7ed2fe444c8fc482833570341ea0fcca2bd78","user":{"login":"FreeRADIUS","id":2430370,"avatar_url":"https://avatars.githubusercontent.com/u/2430370?v=3","gravatar_id":"","url":"https://api.github.com/users/FreeRADIUS","html_url":"https://github.com/FreeRADIUS","followers_url":"https://api.github.com/users/FreeRADIUS/followers","following_url":"https://api.github.com/users/FreeRADIUS/following{/other_user}","gists_url":"https://api.github.com/users/FreeRADIUS/gists{/gist_id}","starred_url":"https://api.github.com/users/FreeRADIUS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FreeRADIUS/subscriptions","organizations_url":"https://api.github.com/users/FreeRADIUS/orgs","repos_url":"https://api.github.com/users/FreeRADIUS/repos","events_url":"https://api.github.com/users/FreeRADIUS/events{/privacy}","received_events_url":"https://api.github.com/users/FreeRADIUS/received_events","type":"Organization","site_admin":false},"repo":{"id":35649,"name":"freeradius-server","full_name":"FreeRADIUS/freeradius-server","owner":{"login":"FreeRADIUS","id":2430370,"avatar_url":"https://avatars.githubusercontent.com/u/2430370?v=3","gravatar_id":"","url":"https://api.github.com/users/FreeRADIUS","html_url":"https://github.com/FreeRADIUS","followers_url":"https://api.github.com/users/FreeRADIUS/followers","following_url":"https://api.github.com/users/FreeRADIUS/following{/other_user}","gists_url":"https://api.github.com/users/FreeRADIUS/gists{/gist_id}","starred_url":"https://api.github.com/users/FreeRADIUS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FreeRADIUS/subscriptions","organizations_url":"https://api.github.com/users/FreeRADIUS/orgs","repos_url":"https://api.github.com/users/FreeRADIUS/repos","events_url":"https://api.github.com/users/FreeRADIUS/events{/privacy}","received_events_url":"https://api.github.com/users/FreeRADIUS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FreeRADIUS/freeradius-server","description":"The FreeRADIUS Server.  RADIUS, DHCP, and VMPS.","fork":false,"url":"https://api.github.com/repos/FreeRADIUS/freeradius-server","forks_url":"https://api.github.com/repos/FreeRADIUS/freeradius-server/forks","keys_url":"https://api.github.com/repos/FreeRADIUS/freeradius-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FreeRADIUS/freeradius-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FreeRADIUS/freeradius-server/teams","hooks_url":"https://api.github.com/repos/FreeRADIUS/freeradius-server/hooks","issue_events_url":"https://api.github.com/repos/FreeRADIUS/freeradius-server/issues/events{/number}","events_url":"https://api.github.com/repos/FreeRADIUS/freeradius-server/events","assignees_url":"https://api.github.com/repos/FreeRADIUS/freeradius-server/assignees{/user}","branches_url":"https://api.github.com/repos/FreeRADIUS/freeradius-server/branches{/branch}","tags_url":"https://api.github.com/repos/FreeRADIUS/freeradius-server/tags","blobs_url":"https://api.github.com/repos/FreeRADIUS/freeradius-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FreeRADIUS/freeradius-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FreeRADIUS/freeradius-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/FreeRADIUS/freeradius-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FreeRADIUS/freeradius-server/statuses/{sha}","languages_url":"https://api.github.com/repos/FreeRADIUS/freeradius-server/languages","stargazers_url":"https://api.github.com/repos/FreeRADIUS/freeradius-server/stargazers","contributors_url":"https://api.github.com/repos/FreeRADIUS/freeradius-server/contributors","subscribers_url":"https://api.github.com/repos/FreeRADIUS/freeradius-server/subscribers","subscription_url":"https://api.github.com/repos/FreeRADIUS/freeradius-server/subscription","commits_url":"https://api.github.com/repos/FreeRADIUS/freeradius-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/FreeRADIUS/freeradius-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/FreeRADIUS/freeradius-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/FreeRADIUS/freeradius-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/FreeRADIUS/freeradius-server/contents/{+path}","compare_url":"https://api.github.com/repos/FreeRADIUS/freeradius-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FreeRADIUS/freeradius-server/merges","archive_url":"https://api.github.com/repos/FreeRADIUS/freeradius-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FreeRADIUS/freeradius-server/downloads","issues_url":"https://api.github.com/repos/FreeRADIUS/freeradius-server/issues{/number}","pulls_url":"https://api.github.com/repos/FreeRADIUS/freeradius-server/pulls{/number}","milestones_url":"https://api.github.com/repos/FreeRADIUS/freeradius-server/milestones{/number}","notifications_url":"https://api.github.com/repos/FreeRADIUS/freeradius-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FreeRADIUS/freeradius-server/labels{/name}","releases_url":"https://api.github.com/repos/FreeRADIUS/freeradius-server/releases{/id}","created_at":"2008-07-20T18:04:09Z","updated_at":"2015-12-17T19:38:39Z","pushed_at":"2015-12-20T21:16:28Z","git_url":"git://github.com/FreeRADIUS/freeradius-server.git","ssh_url":"git@github.com:FreeRADIUS/freeradius-server.git","clone_url":"https://github.com/FreeRADIUS/freeradius-server.git","svn_url":"https://github.com/FreeRADIUS/freeradius-server","homepage":"http://freeradius.org","size":68739,"stargazers_count":343,"watchers_count":343,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":323,"mirror_url":null,"open_issues_count":39,"forks":323,"open_issues":39,"watchers":343,"default_branch":"v3.1.x"}},"_links":{"self":{"href":"https://api.github.com/repos/FreeRADIUS/freeradius-server/pulls/1423"},"html":{"href":"https://github.com/FreeRADIUS/freeradius-server/pull/1423"},"issue":{"href":"https://api.github.com/repos/FreeRADIUS/freeradius-server/issues/1423"},"comments":{"href":"https://api.github.com/repos/FreeRADIUS/freeradius-server/issues/1423/comments"},"review_comments":{"href":"https://api.github.com/repos/FreeRADIUS/freeradius-server/pulls/1423/comments"},"review_comment":{"href":"https://api.github.com/repos/FreeRADIUS/freeradius-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FreeRADIUS/freeradius-server/pulls/1423/commits"},"statuses":{"href":"https://api.github.com/repos/FreeRADIUS/freeradius-server/statuses/6690fccae0400bdebbaad2415f272db3be74e448"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":8,"review_comments":0,"commits":15,"additions":99,"deletions":74,"changed_files":13}}