{"action":"created","issue":{"url":"https://api.github.com/repos/mpv-player/mpv/issues/2195","labels_url":"https://api.github.com/repos/mpv-player/mpv/issues/2195/labels{/name}","comments_url":"https://api.github.com/repos/mpv-player/mpv/issues/2195/comments","events_url":"https://api.github.com/repos/mpv-player/mpv/issues/2195/events","html_url":"https://github.com/mpv-player/mpv/pull/2195","id":99008647,"number":2195,"title":"charset_conv: remove custom UTF-8 detection.","user":{"login":"Jehan","id":794997,"avatar_url":"https://avatars.githubusercontent.com/u/794997?v=3","gravatar_id":"","url":"https://api.github.com/users/Jehan","html_url":"https://github.com/Jehan","followers_url":"https://api.github.com/users/Jehan/followers","following_url":"https://api.github.com/users/Jehan/following{/other_user}","gists_url":"https://api.github.com/users/Jehan/gists{/gist_id}","starred_url":"https://api.github.com/users/Jehan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jehan/subscriptions","organizations_url":"https://api.github.com/users/Jehan/orgs","repos_url":"https://api.github.com/users/Jehan/repos","events_url":"https://api.github.com/users/Jehan/events{/privacy}","received_events_url":"https://api.github.com/users/Jehan/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-08-04T16:34:40Z","updated_at":"2015-08-04T17:02:07Z","closed_at":"2015-08-04T16:59:18Z","pull_request":{"url":"https://api.github.com/repos/mpv-player/mpv/pulls/2195","html_url":"https://github.com/mpv-player/mpv/pull/2195","diff_url":"https://github.com/mpv-player/mpv/pull/2195.diff","patch_url":"https://github.com/mpv-player/mpv/pull/2195.patch"},"body":"I was testing a little more and this time with a Japanese subtitle in ISO-2022-JP.\r\nMPV would detect it as UTF-8 because of the custom UTF-8 validation in current mpv code: bstr_validate_utf8().\r\n\r\nThe comment says that ENCA sometimes get it wrong. Well now ENCA is not the default anymore, so that's good. Also obviously this custom code also gets it wrong sometimes.\r\nIf needed for anyone wanting to validate, I can send a copy of the subtitle file in ISO-2022-JP (github does not even accept attachments other than images. I will never understand this for a bug tracker!).\r\n\r\nMy commit does not remove the implementation of bstr_validate_utf8() itself, even though I see it is used nowhere else, since maybe you were still planning to improve it or use it elsewhere. But I can remove it if you don't care.\r\n"},"comment":{"url":"https://api.github.com/repos/mpv-player/mpv/issues/comments/127676464","html_url":"https://github.com/mpv-player/mpv/pull/2195#issuecomment-127676464","issue_url":"https://api.github.com/repos/mpv-player/mpv/issues/2195","id":127676464,"user":{"login":"Jehan","id":794997,"avatar_url":"https://avatars.githubusercontent.com/u/794997?v=3","gravatar_id":"","url":"https://api.github.com/users/Jehan","html_url":"https://github.com/Jehan","followers_url":"https://api.github.com/users/Jehan/followers","following_url":"https://api.github.com/users/Jehan/following{/other_user}","gists_url":"https://api.github.com/users/Jehan/gists{/gist_id}","starred_url":"https://api.github.com/users/Jehan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jehan/subscriptions","organizations_url":"https://api.github.com/users/Jehan/orgs","repos_url":"https://api.github.com/users/Jehan/repos","events_url":"https://api.github.com/users/Jehan/events{/privacy}","received_events_url":"https://api.github.com/users/Jehan/received_events","type":"User","site_admin":false},"created_at":"2015-08-04T17:02:07Z","updated_at":"2015-08-04T17:02:07Z","body":"Ok."}}