{"push_id":588426457,"size":76,"distinct_size":76,"ref":"refs/heads/mine","head":"17047eae315d43fabd59115cfb2638e4f1189eaa","before":"872e9bdec11a943faeeeb9d583069f3c9817f762","commits":[{"sha":"1f23cfe0ef5b2634a7b911a8b6dc4eff7f78ba5d","author":{"email":"b57189c5f2fd5b3daf3350a77fde90def1080fa5@gmail.com","name":"Jonathan Nieder"},"message":"doc: document error handling functions and conventions\n\nSigned-off-by: Jonathan Nieder <jrnieder@gmail.com>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","distinct":true,"url":"https://api.github.com/repos/nathdwek/git/commits/1f23cfe0ef5b2634a7b911a8b6dc4eff7f78ba5d"},{"sha":"aa7710e064a9ee644e1e86bd6f89193200ac4ccd","author":{"email":"024f400cd820cb2ddbe54c7fecfd01e45f30bb96@gmail.com","name":"Nguyễn Thái Ngọc Duy"},"message":"attr.c: rename arg name attr_nr to avoid shadowing the global one\n\nHelped-by: Junio C Hamano <gitster@pobox.com>\nSigned-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","distinct":true,"url":"https://api.github.com/repos/nathdwek/git/commits/aa7710e064a9ee644e1e86bd6f89193200ac4ccd"},{"sha":"fad32bcd83ec4e4f88013e4a0b05f42e32e2c6f5","author":{"email":"024f400cd820cb2ddbe54c7fecfd01e45f30bb96@gmail.com","name":"Nguyễn Thái Ngọc Duy"},"message":"attr: do not attempt to expand when we know it's not a macro\n\nKeep track of all recognized macros in the new \"maybe_macro\" field.\nIf this field is true, it _may_ be a macro (depending on what's in the\ncurrent attr stack). But if the field is false, it's definitely not a\nmacro, no need to go through the whole attr stack in macroexpand_one()\nto search for one.\n\nWithout this, \"git grep abcdefghi\" on git.git hits the inner loop in\nmacroexpand_one() 2481 times. With this, it's 66 times.\n\nHelped-by: Eric Sunshine <sunshine@sunshineco.com>\nSigned-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","distinct":true,"url":"https://api.github.com/repos/nathdwek/git/commits/fad32bcd83ec4e4f88013e4a0b05f42e32e2c6f5"},{"sha":"06a604e67051b9342c158432a49e42a5440f9280","author":{"email":"024f400cd820cb2ddbe54c7fecfd01e45f30bb96@gmail.com","name":"Nguyễn Thái Ngọc Duy"},"message":"attr: avoid heavy work when we know the specified attr is not defined\n\nIf we have never seen attr 'X' in any .gitattributes file we have\nexamined so far, we can be sure that 'X' is not defined. So no need to\ngo over all the attr stack to look for attr 'X'. This is the purpose\nbehind this new field maybe_real.\n\nThis optimization breaks down if macros are involved because we can't\nknow for sure what macro would expand to 'X' at attr parsing time. But\nif we go the pessimistic way and assume all macros are expanded, we hit\nthe builtin \"binary\" macro. At least the \"diff\" attr defined in this\nmacro will disable this optimization for git-grep. So we wait until\nany attr lines _may_ reference to a macro before we turn this off.\n\nIn git.git, this reduces the number of fill_one() call for \"git grep\nabcdefghi\" from ~5348 to 2955. The optimization stops when it reads\nt/.gitattributes, which uses 'binary' macro. We could probably reduce\nit further by limiting the 'binary' reference to t/ and subdirs only\nin this case.\n\n\"git grep\" is actually a good example to justify this patch. The\ncommand checks \"diff\" attribute on every file. People usually don't\ndefine this attribute. But they pay the attr lookup penalty anyway\nwithout this patch, proportional to the number of attr lines they have\nin repo.\n\nHelped-by: Junio C Hamano <gitster@pobox.com>\nSigned-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","distinct":true,"url":"https://api.github.com/repos/nathdwek/git/commits/06a604e67051b9342c158432a49e42a5440f9280"},{"sha":"1767c51787f2a9aaf99716a48e8928618c1c9481","author":{"email":"696e3fbcf235d40b6ea1ebd61c87cbea79d444e7@peff.net","name":"Jeff King"},"message":"t/lib-httpd: switch SANITY check for NOT_ROOT\n\nThe SANITY prerequisite is really about whether the\nfilesystem will respect the permissions we set, and being\nroot is only one part of that. But the httpd tests really\njust care about not being root, as they are trying to avoid\nweirdness in apache (see a1a3011 for details).\n\nLet's switch out SANITY for a new NOT_ROOT prerequisite,\nwhich will let us tweak SANITY more freely.\n\nWe implement NOT_ROOT by checking `id -u`, which is in POSIX\nand seems to be available even on MSYS.  Note that we cannot\njust call this \"ROOT\" and ask for \"!ROOT\". The possible\noutcomes are:\n\n  1. we know we are root\n\n  2. we know we are not root\n\n  3. we could not tell, because `id` was not available\n\nWe should conservatively treat (3) as \"does not have the\nprerequisite\", which means that a naive negation would not\nwork.\n\nHelped-by: Kyle J. McKay <mackyle@gmail.com>\nSigned-off-by: Jeff King <peff@peff.net>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","distinct":true,"url":"https://api.github.com/repos/nathdwek/git/commits/1767c51787f2a9aaf99716a48e8928618c1c9481"},{"sha":"eae69530ae3915d54f660d56cc3f92dd6bed03ae","author":{"email":"a6723cc3f76163bf7adb636a73ac3b0ceb3e6b9b@pobox.com","name":"Junio C Hamano"},"message":"tests: correct misuses of POSIXPERM\n\nPOSIXPERM requires that a later call to stat(2) (hence \"ls -l\")\nfaithfully reproduces what an earlier chmod(2) did.  Some\nfilesystems cannot satisify this.\n\nSANITY requires that a file or a directory is indeed accessible (or\ninaccessible) when its permission bits would say it ought to be\naccessible (or inaccessible).  Running tests as root would lose this\nprerequisite for obvious reasons.\n\nFix a few tests that misuse POSIXPERM.\n\nt0061-run-command.sh has two uses of POSIXPERM.\n\n - One checks that an attempt to execute a file that is marked as\n   unexecutable results in a failure with EACCES; I do not think\n   having root-ness or any other capability that busts the\n   filesystem permission mode bits will make you run an unexecutable\n   file, so this should be left as-is.  The test does not have\n   anything to do with SANITY.\n\n - The other one expects 'git nitfol' runs the alias when an\n   alias.nitfol is defined and a directory on the PATH is marked as\n   unreadable and unsearchable.  I _think_ the test tries to reject\n   the alternative expectation that we want to refuse to run the\n   alias because it would break \"no alias may mask a command\" rule\n   if a file 'git-nitfol' exists in the unreadable directory but we\n   cannot even determine if that is the case.  Under !SANITY that\n   busts the permission bits, this test no longer checks that, so it\n   must be protected with SANITY.\n\nt1509-root-worktree.sh expects to be run on a / that is writable by\nthe user and sees if Git behaves \"sensibly\" when /.git is the\nrepository to govern a worktree that is the whole filesystem, and\nalso if Git behaves \"sensibly\" when / itself is a bare repository\nwith refs, objects, and friends (I find the definition of \"behaves\nsensibly\" under these conditions hard to fathom, but it is a\ndifferent matter).\n\nThe implementation of the test is very much problematic.\n\n - It requires POSIXPERM, but it does not do chmod or checks modes\n   in any way.\n\n - It runs \"rm /*\" and \"rm -fr /refs /objects ...\" in one of the\n   tests, and also does \"cd / && git init --bare\".  If done on a\n   live system that takes advantages of the \"feature\" being tested,\n   these obviously will clobber the system.  But there is no guard\n   against such a breakage.\n\n - It uses \"test $UID = 0\" to see rootness, which now should be\n   spelled \"! test_have_prereq NOT_ROOT\"\n\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","distinct":true,"url":"https://api.github.com/repos/nathdwek/git/commits/eae69530ae3915d54f660d56cc3f92dd6bed03ae"},{"sha":"bdfdaa4978dd92992737e662f25adc01d32d0774","author":{"email":"696e3fbcf235d40b6ea1ebd61c87cbea79d444e7@peff.net","name":"Jeff King"},"message":"strbuf.h: integrate api-strbuf.txt documentation\n\nSome of strbuf is documented as comments above functions,\nand some is separate in Documentation/technical/api-strbuf.txt.\nThis makes it annoying to find the appropriate documentation.\nWe'd rather have it all in one place, which means all in the\ntext document, or all in the header.\n\nLet's choose the header as that place. Even though the\nformatting is not quite as pretty, this keeps the\ndocumentation close to the related code.  The hope is that\nthis makes it easier to find what you want (human-readable\ncomments are right next to the C declarations), and easier\nfor writers to keep the documentation up to date.\n\nThis is more or less a straight import of the text from\napi-strbuf.txt into C comments, complete with asciidoc\nformatting. The exceptions are:\n\n 1. All comments created in this way are started with \"/**\"\n    to indicate they are part of the API documentation. This\n    may help later with extracting the text to pretty-print\n    it.\n\n 2. Function descriptions do not repeat the function name,\n    as it is available in the context directly below.  So:\n\n      `strbuf_add`::\n\n          Add data of given length to the buffer.\n\n    from api-strbuf.txt becomes:\n\n      /**\n       * Add data of given length to the buffer.\n       */\n      void strbuf_add(struct strbuf *sb, const void *, size_t);\n\n    As a result, any block-continuation required in asciidoc\n    for that list item was dropped in favor of straight\n    blank-line paragraph (since it is not necessary when we\n    are not in a list item).\n\n 3. There is minor re-wording to integrate existing comments\n    and api-strbuf text. In each case, I took whichever\n    version was more descriptive, and eliminated any\n    redundancies. In one case, for strbuf_addstr, the api\n    documentation gave its inline definition; I eliminated\n    this as redundant with the actual definition, which can\n    be seen directly below the comment.\n\n 4. The functions in the header file are re-ordered to match\n    the ordering of the API documentation, under the\n    assumption that more thought went into the grouping\n    there.\n\nHelped-by: Jonathan Nieder <jrnieder@gmail.com>\nSigned-off-by: Jeff King <peff@peff.net>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","distinct":true,"url":"https://api.github.com/repos/nathdwek/git/commits/bdfdaa4978dd92992737e662f25adc01d32d0774"},{"sha":"6afbbdda3339349feae91161f4e530d511c4db76","author":{"email":"a7f3b1612c245dae606b3b9617b4f52187fddb65@google.com","name":"Stefan Beller"},"message":"strbuf.h: unify documentation comments beginnings\n\nThe prior patch uses \"/**\" to denote \"documentation\"\ncomments that we pulled from api-strbuf.txt. Let's use a\nconsistent style for similar comments that were already in\nstrbuf.h.\n\nSigned-off-by: Stefan Beller <sbeller@google.com>\nSigned-off-by: Jeff King <peff@peff.net>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","distinct":true,"url":"https://api.github.com/repos/nathdwek/git/commits/6afbbdda3339349feae91161f4e530d511c4db76"},{"sha":"aa07cac43fb03a01bcbcdffdaa49bf72a9eb06d1","author":{"email":"696e3fbcf235d40b6ea1ebd61c87cbea79d444e7@peff.net","name":"Jeff King"},"message":"strbuf.h: drop asciidoc list formatting from API docs\n\nUsing a hanging indent is much more readable. This means we\nwon't format as asciidoc anymore, but since we don't have a\nworking system for extracting these comments anyway, it's\nprobably more important to just make the source readable.\n\nSigned-off-by: Jeff King <peff@peff.net>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","distinct":true,"url":"https://api.github.com/repos/nathdwek/git/commits/aa07cac43fb03a01bcbcdffdaa49bf72a9eb06d1"},{"sha":"088c9a86ff5332ee15415be3408ccf34687bc2d2","author":{"email":"696e3fbcf235d40b6ea1ebd61c87cbea79d444e7@peff.net","name":"Jeff King"},"message":"strbuf.h: format asciidoc code blocks as 4-space indent\n\nThis is much easier to read when the whole thing is stuffed\ninside a comment block. And there is precedent for this\nconvention in markdown (and just in general ascii text).\n\nSigned-off-by: Jeff King <peff@peff.net>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","distinct":true,"url":"https://api.github.com/repos/nathdwek/git/commits/088c9a86ff5332ee15415be3408ccf34687bc2d2"},{"sha":"14e2177a40ca5861f0518cb6bbe0a6856ffa7552","author":{"email":"696e3fbcf235d40b6ea1ebd61c87cbea79d444e7@peff.net","name":"Jeff King"},"message":"strbuf.h: reorganize api function grouping headers\n\nThe original API doc had something like:\n\n    Functions\n    ---------\n\n    * Life cycle\n\n      ... some life-cycle functions ...\n\n    * Related to the contents of the buffer\n\n      ... functions related to contents ....\n\n    etc\n\nThis grouping can be hard to read in the comment sources,\ngiven the \"*\" in the comment lines, and the amount of text\nbetween each section.\n\nInstead, let's make a flat list of groupings, and underline\neach as a section header. That makes them stand out, and\neliminates the weird half-phrase of \"Related to...\". Like:\n\n    Functions related to the contents of the buffer\n    -----------------------------------------------\n\nSigned-off-by: Jeff King <peff@peff.net>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","distinct":true,"url":"https://api.github.com/repos/nathdwek/git/commits/14e2177a40ca5861f0518cb6bbe0a6856ffa7552"},{"sha":"f20e56e202fa2a6cd3faa1710ed9f600ba58ce1d","author":{"email":"696e3fbcf235d40b6ea1ebd61c87cbea79d444e7@peff.net","name":"Jeff King"},"message":"strbuf.h: drop boilerplate descriptions of strbuf_split_*\n\nThe description of strbuf_split_buf says most of what\nneeds to be said for all of the split variants that take\nstrings, raw memory, etc. We have a boilerplate comment\nabove each that points to the first. This boilerplate\nends up making it harder to read, because it spaces out the\nfunctions, which could otherwise be read as a group.\n\nLet's drop the boilerplate completely, and mention the\nvariants in the top comment. This is perhaps slightly worse\nfor a hypothetical system which pulls the documentation for\neach function out of the comment immediately preceding it.\nBut such a system does not yet exist, and anyway, the end\nresult of extracting the boilerplate comments would not lead\nto a very easy-to-read result.  We would do better in the\nlong run to teach the extraction system about groups of\nrelated functions.\n\nSigned-off-by: Jeff King <peff@peff.net>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","distinct":true,"url":"https://api.github.com/repos/nathdwek/git/commits/f20e56e202fa2a6cd3faa1710ed9f600ba58ce1d"},{"sha":"d468fa2721d1ff918c0991e9e1f762872b3f82ae","author":{"email":"696e3fbcf235d40b6ea1ebd61c87cbea79d444e7@peff.net","name":"Jeff King"},"message":"strbuf.h: group documentation for trim functions\n\nThe relationship between these makes more sense if you read\nthem as a group, which can help people who are looking for\nthe right function. Let's give them a single comment.\n\nSigned-off-by: Jeff King <peff@peff.net>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","distinct":true,"url":"https://api.github.com/repos/nathdwek/git/commits/d468fa2721d1ff918c0991e9e1f762872b3f82ae"},{"sha":"394e1505b8c359461c4b7cbbd204f86b185c64a0","author":{"email":"a6723cc3f76163bf7adb636a73ac3b0ceb3e6b9b@pobox.com","name":"Junio C Hamano"},"message":"config.txt: clarify that add.ignore-errors is deprecated\n\nThe old text gave an impression that even in a new repository using\nold form might be safer.  Only Git from pre 1.7.0 days choke on the\ncorrectly named variable, which is ancient by today's standard.\n\nWe have no intention to remove the support for deprecated ones, but\nlet's make sure that we do not give room for confused questions such\nas \"why does core.sparse-checkout not work, when add.ignore-errors\ndoes?\"\n\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","distinct":true,"url":"https://api.github.com/repos/nathdwek/git/commits/394e1505b8c359461c4b7cbbd204f86b185c64a0"},{"sha":"502e7f9851768974a5b45a9dc00882231dac5c90","author":{"email":"a6723cc3f76163bf7adb636a73ac3b0ceb3e6b9b@pobox.com","name":"Junio C Hamano"},"message":"config.txt: mark deprecated variables more prominently\n\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","distinct":true,"url":"https://api.github.com/repos/nathdwek/git/commits/502e7f9851768974a5b45a9dc00882231dac5c90"},{"sha":"35840a3e789dd67528caefc146deb698bd6ac7a5","author":{"email":"a6723cc3f76163bf7adb636a73ac3b0ceb3e6b9b@pobox.com","name":"Junio C Hamano"},"message":"CodingGuidelines: describe naming rules for configuration variables\n\nWe may want to say something about command line option names in the\nnew section as well, but for now, let's make sure everybody is clear\non how to structure and name their configuration variables.\n\nThe text for the rules are partly taken from the log message of\nJonathan's 6b3020a2 (add: introduce add.ignoreerrors synonym for\nadd.ignore-errors, 2010-12-01).\n\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","distinct":true,"url":"https://api.github.com/repos/nathdwek/git/commits/35840a3e789dd67528caefc146deb698bd6ac7a5"},{"sha":"8196e728955a084303e99affff2ebc1120112516","author":{"email":"c67f1ee17880030ce11821dcc9be7af90b863d9b@pks.im","name":"Patrick Steinhardt"},"message":"git-submodule.sh: fix '/././' path normalization\n\nWhen we add a new submodule the path of the submodule is being\nnormalized. We fail to normalize multiple adjacent '/./', though.\nThus 'path/to/././submodule' will become 'path/to/./submodule' where\nit should be 'path/to/submodule' instead.\n\nSigned-off-by: Patrick Steinhardt <ps@pks.im>\nAcked-by: Jens Lehmann <Jens.Lehmann@web.de>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","distinct":true,"url":"https://api.github.com/repos/nathdwek/git/commits/8196e728955a084303e99affff2ebc1120112516"},{"sha":"1c2dbf2095beb5227d963a1541e356bd2e834dff","author":{"email":"1c1659c8b732dbc7a2ecc185c98f9f178154b466@statsbiblioteket.dk","name":"Tom G. Christensen"},"message":"http: support curl < 7.10.7\n\nCommit dd61399 introduced support for http proxies that require\nauthentication but it relies on the CURL_PROXYAUTH option which was\nadded in curl 7.10.7.\nThis makes sure proxy authentication is only enabled if libcurl can\nsupport it.\n\nSigned-off-by: Tom G. Christensen <tgc@statsbiblioteket.dk>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","distinct":true,"url":"https://api.github.com/repos/nathdwek/git/commits/1c2dbf2095beb5227d963a1541e356bd2e834dff"},{"sha":"3af67924e03ddb29a2b698266a9f27ef30cd663b","author":{"email":"1c1659c8b732dbc7a2ecc185c98f9f178154b466@statsbiblioteket.dk","name":"Tom G. Christensen"},"message":"Makefile: handle broken curl version number in version check\n\ncurl 7.11.0 through 7.12.2 when built from their official release\narchives will present a 5 digit version number instead of the documented\n6 digits which breaks the version check in the Makefile.\nCorrect these broken version numbers on the fly when extracting them to\nensure the comparison works correctly.\n\n[jc: shortened the new sed scripts a bit]\n\nSigned-off-by: Tom G. Christensen <tgc@statsbiblioteket.dk>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","distinct":true,"url":"https://api.github.com/repos/nathdwek/git/commits/3af67924e03ddb29a2b698266a9f27ef30cd663b"},{"sha":"0b86fe8923c25639f77d5f18f086c3346a5ccd61","author":{"email":"a6723cc3f76163bf7adb636a73ac3b0ceb3e6b9b@pobox.com","name":"Junio C Hamano"},"message":"run_diff_files(): clarify computation of sha1 validity\n\nRemove the need to have duplicated \"if there is a change then feed\nnull_sha1 and otherwise sha1 from the cache entry\" for the \"new\"\nside of the diff by introducing two temporary variables to point\nat the object name of the old and the new side of the blobs.\n\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","distinct":true,"url":"https://api.github.com/repos/nathdwek/git/commits/0b86fe8923c25639f77d5f18f086c3346a5ccd61"}]}