{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/browser.html/pulls/comments/36821428","id":36821428,"diff_hunk":"@@ -28,7 +55,99 @@\n \n   // View\n \n-  const viewSetting = (name, value) => html.div({\n+  const viewField = props => {\n+    return html.span({\n+      key: 'field',\n+      style: {\n+        position: 'relative',\n+        overflow: 'hidden'\n+      }\n+    },[\n+      html.span({\n+        key: 'sizer',\n+        style: {\n+          left: 0,\n+          color: 'red',\n+          whiteSpace: 'pre',\n+          opacity: 0,\n+        }\n+      }, props.value),","path":"src/about/settings/index.js","position":55,"original_position":55,"commit_id":"b5a52845725b1ddb37d24e97020bb9b6a498016a","original_commit_id":"b5a52845725b1ddb37d24e97020bb9b6a498016a","user":{"login":"paulrouget","id":373579,"avatar_url":"https://avatars.githubusercontent.com/u/373579?v=3","gravatar_id":"","url":"https://api.github.com/users/paulrouget","html_url":"https://github.com/paulrouget","followers_url":"https://api.github.com/users/paulrouget/followers","following_url":"https://api.github.com/users/paulrouget/following{/other_user}","gists_url":"https://api.github.com/users/paulrouget/gists{/gist_id}","starred_url":"https://api.github.com/users/paulrouget/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulrouget/subscriptions","organizations_url":"https://api.github.com/users/paulrouget/orgs","repos_url":"https://api.github.com/users/paulrouget/repos","events_url":"https://api.github.com/users/paulrouget/events{/privacy}","received_events_url":"https://api.github.com/users/paulrouget/received_events","type":"User","site_admin":false},"body":"Why do you need that?","created_at":"2015-08-12T02:18:51Z","updated_at":"2015-08-12T02:18:51Z","html_url":"https://github.com/mozilla/browser.html/pull/573#discussion_r36821428","pull_request_url":"https://api.github.com/repos/mozilla/browser.html/pulls/573","_links":{"self":{"href":"https://api.github.com/repos/mozilla/browser.html/pulls/comments/36821428"},"html":{"href":"https://github.com/mozilla/browser.html/pull/573#discussion_r36821428"},"pull_request":{"href":"https://api.github.com/repos/mozilla/browser.html/pulls/573"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/browser.html/pulls/573","id":42158039,"html_url":"https://github.com/mozilla/browser.html/pull/573","diff_url":"https://github.com/mozilla/browser.html/pull/573.diff","patch_url":"https://github.com/mozilla/browser.html/pull/573.patch","issue_url":"https://api.github.com/repos/mozilla/browser.html/issues/573","number":573,"state":"open","locked":false,"title":"Make settings editable.","user":{"login":"Gozala","id":21236,"avatar_url":"https://avatars.githubusercontent.com/u/21236?v=3","gravatar_id":"","url":"https://api.github.com/users/Gozala","html_url":"https://github.com/Gozala","followers_url":"https://api.github.com/users/Gozala/followers","following_url":"https://api.github.com/users/Gozala/following{/other_user}","gists_url":"https://api.github.com/users/Gozala/gists{/gist_id}","starred_url":"https://api.github.com/users/Gozala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gozala/subscriptions","organizations_url":"https://api.github.com/users/Gozala/orgs","repos_url":"https://api.github.com/users/Gozala/repos","events_url":"https://api.github.com/users/Gozala/events{/privacy}","received_events_url":"https://api.github.com/users/Gozala/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-08-11T17:58:16Z","updated_at":"2015-08-12T02:18:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d5bb83702d61d670638e426016ea1b1fe76b077b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/browser.html/pulls/573/commits","review_comments_url":"https://api.github.com/repos/mozilla/browser.html/pulls/573/comments","review_comment_url":"https://api.github.com/repos/mozilla/browser.html/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/browser.html/issues/573/comments","statuses_url":"https://api.github.com/repos/mozilla/browser.html/statuses/b5a52845725b1ddb37d24e97020bb9b6a498016a","head":{"label":"Gozala:editable-settings","ref":"editable-settings","sha":"b5a52845725b1ddb37d24e97020bb9b6a498016a","user":{"login":"Gozala","id":21236,"avatar_url":"https://avatars.githubusercontent.com/u/21236?v=3","gravatar_id":"","url":"https://api.github.com/users/Gozala","html_url":"https://github.com/Gozala","followers_url":"https://api.github.com/users/Gozala/followers","following_url":"https://api.github.com/users/Gozala/following{/other_user}","gists_url":"https://api.github.com/users/Gozala/gists{/gist_id}","starred_url":"https://api.github.com/users/Gozala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gozala/subscriptions","organizations_url":"https://api.github.com/users/Gozala/orgs","repos_url":"https://api.github.com/users/Gozala/repos","events_url":"https://api.github.com/users/Gozala/events{/privacy}","received_events_url":"https://api.github.com/users/Gozala/received_events","type":"User","site_admin":false},"repo":{"id":28829395,"name":"browser.html","full_name":"Gozala/browser.html","owner":{"login":"Gozala","id":21236,"avatar_url":"https://avatars.githubusercontent.com/u/21236?v=3","gravatar_id":"","url":"https://api.github.com/users/Gozala","html_url":"https://github.com/Gozala","followers_url":"https://api.github.com/users/Gozala/followers","following_url":"https://api.github.com/users/Gozala/following{/other_user}","gists_url":"https://api.github.com/users/Gozala/gists{/gist_id}","starred_url":"https://api.github.com/users/Gozala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gozala/subscriptions","organizations_url":"https://api.github.com/users/Gozala/orgs","repos_url":"https://api.github.com/users/Gozala/repos","events_url":"https://api.github.com/users/Gozala/events{/privacy}","received_events_url":"https://api.github.com/users/Gozala/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Gozala/browser.html","description":"Experimental browser built in HTML","fork":true,"url":"https://api.github.com/repos/Gozala/browser.html","forks_url":"https://api.github.com/repos/Gozala/browser.html/forks","keys_url":"https://api.github.com/repos/Gozala/browser.html/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Gozala/browser.html/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Gozala/browser.html/teams","hooks_url":"https://api.github.com/repos/Gozala/browser.html/hooks","issue_events_url":"https://api.github.com/repos/Gozala/browser.html/issues/events{/number}","events_url":"https://api.github.com/repos/Gozala/browser.html/events","assignees_url":"https://api.github.com/repos/Gozala/browser.html/assignees{/user}","branches_url":"https://api.github.com/repos/Gozala/browser.html/branches{/branch}","tags_url":"https://api.github.com/repos/Gozala/browser.html/tags","blobs_url":"https://api.github.com/repos/Gozala/browser.html/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Gozala/browser.html/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Gozala/browser.html/git/refs{/sha}","trees_url":"https://api.github.com/repos/Gozala/browser.html/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Gozala/browser.html/statuses/{sha}","languages_url":"https://api.github.com/repos/Gozala/browser.html/languages","stargazers_url":"https://api.github.com/repos/Gozala/browser.html/stargazers","contributors_url":"https://api.github.com/repos/Gozala/browser.html/contributors","subscribers_url":"https://api.github.com/repos/Gozala/browser.html/subscribers","subscription_url":"https://api.github.com/repos/Gozala/browser.html/subscription","commits_url":"https://api.github.com/repos/Gozala/browser.html/commits{/sha}","git_commits_url":"https://api.github.com/repos/Gozala/browser.html/git/commits{/sha}","comments_url":"https://api.github.com/repos/Gozala/browser.html/comments{/number}","issue_comment_url":"https://api.github.com/repos/Gozala/browser.html/issues/comments{/number}","contents_url":"https://api.github.com/repos/Gozala/browser.html/contents/{+path}","compare_url":"https://api.github.com/repos/Gozala/browser.html/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Gozala/browser.html/merges","archive_url":"https://api.github.com/repos/Gozala/browser.html/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Gozala/browser.html/downloads","issues_url":"https://api.github.com/repos/Gozala/browser.html/issues{/number}","pulls_url":"https://api.github.com/repos/Gozala/browser.html/pulls{/number}","milestones_url":"https://api.github.com/repos/Gozala/browser.html/milestones{/number}","notifications_url":"https://api.github.com/repos/Gozala/browser.html/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Gozala/browser.html/labels{/name}","releases_url":"https://api.github.com/repos/Gozala/browser.html/releases{/id}","created_at":"2015-01-05T20:07:15Z","updated_at":"2015-02-26T07:22:55Z","pushed_at":"2015-08-12T02:12:41Z","git_url":"git://github.com/Gozala/browser.html.git","ssh_url":"git@github.com:Gozala/browser.html.git","clone_url":"https://github.com/Gozala/browser.html.git","svn_url":"https://github.com/Gozala/browser.html","homepage":null,"size":6939,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"939607629e34726670094d9c77b4d372a869ee2a","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":28800891,"name":"browser.html","full_name":"mozilla/browser.html","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/browser.html","description":"Experimental browser built in HTML","fork":false,"url":"https://api.github.com/repos/mozilla/browser.html","forks_url":"https://api.github.com/repos/mozilla/browser.html/forks","keys_url":"https://api.github.com/repos/mozilla/browser.html/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/browser.html/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/browser.html/teams","hooks_url":"https://api.github.com/repos/mozilla/browser.html/hooks","issue_events_url":"https://api.github.com/repos/mozilla/browser.html/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/browser.html/events","assignees_url":"https://api.github.com/repos/mozilla/browser.html/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/browser.html/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/browser.html/tags","blobs_url":"https://api.github.com/repos/mozilla/browser.html/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/browser.html/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/browser.html/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/browser.html/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/browser.html/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/browser.html/languages","stargazers_url":"https://api.github.com/repos/mozilla/browser.html/stargazers","contributors_url":"https://api.github.com/repos/mozilla/browser.html/contributors","subscribers_url":"https://api.github.com/repos/mozilla/browser.html/subscribers","subscription_url":"https://api.github.com/repos/mozilla/browser.html/subscription","commits_url":"https://api.github.com/repos/mozilla/browser.html/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/browser.html/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/browser.html/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/browser.html/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/browser.html/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/browser.html/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/browser.html/merges","archive_url":"https://api.github.com/repos/mozilla/browser.html/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/browser.html/downloads","issues_url":"https://api.github.com/repos/mozilla/browser.html/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/browser.html/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/browser.html/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/browser.html/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/browser.html/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/browser.html/releases{/id}","created_at":"2015-01-05T06:39:24Z","updated_at":"2015-08-09T16:41:05Z","pushed_at":"2015-08-12T02:13:09Z","git_url":"git://github.com/mozilla/browser.html.git","ssh_url":"git@github.com:mozilla/browser.html.git","clone_url":"https://github.com/mozilla/browser.html.git","svn_url":"https://github.com/mozilla/browser.html","homepage":null,"size":47196,"stargazers_count":769,"watchers_count":769,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":68,"mirror_url":null,"open_issues_count":132,"forks":68,"open_issues":132,"watchers":769,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/browser.html/pulls/573"},"html":{"href":"https://github.com/mozilla/browser.html/pull/573"},"issue":{"href":"https://api.github.com/repos/mozilla/browser.html/issues/573"},"comments":{"href":"https://api.github.com/repos/mozilla/browser.html/issues/573/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/browser.html/pulls/573/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/browser.html/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/browser.html/pulls/573/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/browser.html/statuses/b5a52845725b1ddb37d24e97020bb9b6a498016a"}}}}