{"action":"created","issue":{"url":"https://api.github.com/repos/Ayolland/2015-01-29-rockpaperscissor/issues/5","labels_url":"https://api.github.com/repos/Ayolland/2015-01-29-rockpaperscissor/issues/5/labels{/name}","comments_url":"https://api.github.com/repos/Ayolland/2015-01-29-rockpaperscissor/issues/5/comments","events_url":"https://api.github.com/repos/Ayolland/2015-01-29-rockpaperscissor/issues/5/events","html_url":"https://github.com/Ayolland/2015-01-29-rockpaperscissor/issues/5","id":56312552,"number":5,"title":"rps_game.rb reflection >> changed to >> save_round","user":{"login":"ioscowboi","id":8541328,"avatar_url":"https://avatars.githubusercontent.com/u/8541328?v=3","gravatar_id":"","url":"https://api.github.com/users/ioscowboi","html_url":"https://github.com/ioscowboi","followers_url":"https://api.github.com/users/ioscowboi/followers","following_url":"https://api.github.com/users/ioscowboi/following{/other_user}","gists_url":"https://api.github.com/users/ioscowboi/gists{/gist_id}","starred_url":"https://api.github.com/users/ioscowboi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ioscowboi/subscriptions","organizations_url":"https://api.github.com/users/ioscowboi/orgs","repos_url":"https://api.github.com/users/ioscowboi/repos","events_url":"https://api.github.com/users/ioscowboi/events{/privacy}","received_events_url":"https://api.github.com/users/ioscowboi/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-02-02T23:54:23Z","updated_at":"2015-02-03T03:12:37Z","closed_at":null,"body":"b)rps_game.rb\r\nI just realized that you only need to 2 out of three to win a best of 3 series, so there’s no need to play the third round if say, player 2 wins rounds one and two. In that case we should make an exception and end the game. The way your code is written on lines 70-80, the player would need 3 wins in a series of 3 when in actuality the winner should be decided at as little as 1 round won. The game should check if the winners score is higher than the losers score after 2 rounds. I think this is a general rule. Variable somevariableyouchoose = end_score -1"},"comment":{"url":"https://api.github.com/repos/Ayolland/2015-01-29-rockpaperscissor/issues/comments/72585131","html_url":"https://github.com/Ayolland/2015-01-29-rockpaperscissor/issues/5#issuecomment-72585131","issue_url":"https://api.github.com/repos/Ayolland/2015-01-29-rockpaperscissor/issues/5","id":72585131,"user":{"login":"Ayolland","id":10699280,"avatar_url":"https://avatars.githubusercontent.com/u/10699280?v=3","gravatar_id":"","url":"https://api.github.com/users/Ayolland","html_url":"https://github.com/Ayolland","followers_url":"https://api.github.com/users/Ayolland/followers","following_url":"https://api.github.com/users/Ayolland/following{/other_user}","gists_url":"https://api.github.com/users/Ayolland/gists{/gist_id}","starred_url":"https://api.github.com/users/Ayolland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ayolland/subscriptions","organizations_url":"https://api.github.com/users/Ayolland/orgs","repos_url":"https://api.github.com/users/Ayolland/repos","events_url":"https://api.github.com/users/Ayolland/events{/privacy}","received_events_url":"https://api.github.com/users/Ayolland/received_events","type":"User","site_admin":false},"created_at":"2015-02-03T03:12:37Z","updated_at":"2015-02-03T03:12:37Z","body":"The reason it's repeated is because the Player and AI_player are different classes. So, if I didn't have the blank method in the Player class when I went to run\r\n<pre><code>p1.save_round(p1.move,p2.move,winner)</code></pre>\r\nI would get an error if p1 was a Player object, and I need the Ai_Player to be separate class so that when\r\n<pre><code>    \r\np1.set_move\r\np2.set_move\r\n</code></pre>\r\nIt will handle #set_move differently depending on what kind of object it is, avoiding the need for an IF statement.\r\n\r\nIt's a good point though, because I think it's a choice between SRP (don't have a method that handles how human do one thing and ALSO how computer do it) and DRY (don't have a blank method lying around your class doing nothing.) It's probably a good example to bring up tomorrow. "}}