{"action":"opened","number":2,"pull_request":{"url":"https://api.github.com/repos/ivanmb/ims-lti/pulls/2","id":37797702,"html_url":"https://github.com/ivanmb/ims-lti/pull/2","diff_url":"https://github.com/ivanmb/ims-lti/pull/2.diff","patch_url":"https://github.com/ivanmb/ims-lti/pull/2.patch","issue_url":"https://api.github.com/repos/ivanmb/ims-lti/issues/2","number":2,"state":"open","locked":false,"title":"Update unit tests and improve README","user":{"login":"jmealo","id":1066536,"avatar_url":"https://avatars.githubusercontent.com/u/1066536?v=3","gravatar_id":"","url":"https://api.github.com/users/jmealo","html_url":"https://github.com/jmealo","followers_url":"https://api.github.com/users/jmealo/followers","following_url":"https://api.github.com/users/jmealo/following{/other_user}","gists_url":"https://api.github.com/users/jmealo/gists{/gist_id}","starred_url":"https://api.github.com/users/jmealo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmealo/subscriptions","organizations_url":"https://api.github.com/users/jmealo/orgs","repos_url":"https://api.github.com/users/jmealo/repos","events_url":"https://api.github.com/users/jmealo/events{/privacy}","received_events_url":"https://api.github.com/users/jmealo/received_events","type":"User","site_admin":false},"body":"Ivan,\r\n\r\nI noticed that the vendor information isn't being populated correctly in the ``ToolConfiguration``.\r\n\r\nI set up continuous integration and test coverage on my repo using Travis and Coveralls, if you want to do the same on yours you'll be set using these config files.\r\n\r\nI tested the XPath query outside of PHP and it appears like it should work, however, the query never returns a vendor (when querying against ``$root`` or ``$doc``);\r\n\r\nI didn't bother troubleshooting for too long because the XML handling will need a refactor in order to output XML from a configuration as well as supporting custom properties.\r\n\r\nWould you consider this production ready or feature complete against the ruby version at the time it was published?\r\n\r\nThanks,\r\nJeff","created_at":"2015-06-16T13:59:50Z","updated_at":"2015-06-16T13:59:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ivanmb/ims-lti/pulls/2/commits","review_comments_url":"https://api.github.com/repos/ivanmb/ims-lti/pulls/2/comments","review_comment_url":"https://api.github.com/repos/ivanmb/ims-lti/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ivanmb/ims-lti/issues/2/comments","statuses_url":"https://api.github.com/repos/ivanmb/ims-lti/statuses/44141ac45a9361b5b4098bfb6d3ac255a527121b","head":{"label":"jmealo:develop","ref":"develop","sha":"44141ac45a9361b5b4098bfb6d3ac255a527121b","user":{"login":"jmealo","id":1066536,"avatar_url":"https://avatars.githubusercontent.com/u/1066536?v=3","gravatar_id":"","url":"https://api.github.com/users/jmealo","html_url":"https://github.com/jmealo","followers_url":"https://api.github.com/users/jmealo/followers","following_url":"https://api.github.com/users/jmealo/following{/other_user}","gists_url":"https://api.github.com/users/jmealo/gists{/gist_id}","starred_url":"https://api.github.com/users/jmealo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmealo/subscriptions","organizations_url":"https://api.github.com/users/jmealo/orgs","repos_url":"https://api.github.com/users/jmealo/repos","events_url":"https://api.github.com/users/jmealo/events{/privacy}","received_events_url":"https://api.github.com/users/jmealo/received_events","type":"User","site_admin":false},"repo":{"id":37526186,"name":"ims-lti","full_name":"jmealo/ims-lti","owner":{"login":"jmealo","id":1066536,"avatar_url":"https://avatars.githubusercontent.com/u/1066536?v=3","gravatar_id":"","url":"https://api.github.com/users/jmealo","html_url":"https://github.com/jmealo","followers_url":"https://api.github.com/users/jmealo/followers","following_url":"https://api.github.com/users/jmealo/following{/other_user}","gists_url":"https://api.github.com/users/jmealo/gists{/gist_id}","starred_url":"https://api.github.com/users/jmealo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmealo/subscriptions","organizations_url":"https://api.github.com/users/jmealo/orgs","repos_url":"https://api.github.com/users/jmealo/repos","events_url":"https://api.github.com/users/jmealo/events{/privacy}","received_events_url":"https://api.github.com/users/jmealo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jmealo/ims-lti","description":"PHP library to help create Tool Providers and Tool Consumers for the IMS LTI standard.","fork":true,"url":"https://api.github.com/repos/jmealo/ims-lti","forks_url":"https://api.github.com/repos/jmealo/ims-lti/forks","keys_url":"https://api.github.com/repos/jmealo/ims-lti/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jmealo/ims-lti/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jmealo/ims-lti/teams","hooks_url":"https://api.github.com/repos/jmealo/ims-lti/hooks","issue_events_url":"https://api.github.com/repos/jmealo/ims-lti/issues/events{/number}","events_url":"https://api.github.com/repos/jmealo/ims-lti/events","assignees_url":"https://api.github.com/repos/jmealo/ims-lti/assignees{/user}","branches_url":"https://api.github.com/repos/jmealo/ims-lti/branches{/branch}","tags_url":"https://api.github.com/repos/jmealo/ims-lti/tags","blobs_url":"https://api.github.com/repos/jmealo/ims-lti/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jmealo/ims-lti/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jmealo/ims-lti/git/refs{/sha}","trees_url":"https://api.github.com/repos/jmealo/ims-lti/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jmealo/ims-lti/statuses/{sha}","languages_url":"https://api.github.com/repos/jmealo/ims-lti/languages","stargazers_url":"https://api.github.com/repos/jmealo/ims-lti/stargazers","contributors_url":"https://api.github.com/repos/jmealo/ims-lti/contributors","subscribers_url":"https://api.github.com/repos/jmealo/ims-lti/subscribers","subscription_url":"https://api.github.com/repos/jmealo/ims-lti/subscription","commits_url":"https://api.github.com/repos/jmealo/ims-lti/commits{/sha}","git_commits_url":"https://api.github.com/repos/jmealo/ims-lti/git/commits{/sha}","comments_url":"https://api.github.com/repos/jmealo/ims-lti/comments{/number}","issue_comment_url":"https://api.github.com/repos/jmealo/ims-lti/issues/comments{/number}","contents_url":"https://api.github.com/repos/jmealo/ims-lti/contents/{+path}","compare_url":"https://api.github.com/repos/jmealo/ims-lti/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jmealo/ims-lti/merges","archive_url":"https://api.github.com/repos/jmealo/ims-lti/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jmealo/ims-lti/downloads","issues_url":"https://api.github.com/repos/jmealo/ims-lti/issues{/number}","pulls_url":"https://api.github.com/repos/jmealo/ims-lti/pulls{/number}","milestones_url":"https://api.github.com/repos/jmealo/ims-lti/milestones{/number}","notifications_url":"https://api.github.com/repos/jmealo/ims-lti/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jmealo/ims-lti/labels{/name}","releases_url":"https://api.github.com/repos/jmealo/ims-lti/releases{/id}","created_at":"2015-06-16T11:30:43Z","updated_at":"2015-06-16T11:30:43Z","pushed_at":"2015-06-16T13:53:32Z","git_url":"git://github.com/jmealo/ims-lti.git","ssh_url":"git@github.com:jmealo/ims-lti.git","clone_url":"https://github.com/jmealo/ims-lti.git","svn_url":"https://github.com/jmealo/ims-lti","homepage":null,"size":101,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ivanmb:master","ref":"master","sha":"52353183506aefc5beb63793105ec0ab29396e63","user":{"login":"ivanmb","id":1909410,"avatar_url":"https://avatars.githubusercontent.com/u/1909410?v=3","gravatar_id":"","url":"https://api.github.com/users/ivanmb","html_url":"https://github.com/ivanmb","followers_url":"https://api.github.com/users/ivanmb/followers","following_url":"https://api.github.com/users/ivanmb/following{/other_user}","gists_url":"https://api.github.com/users/ivanmb/gists{/gist_id}","starred_url":"https://api.github.com/users/ivanmb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivanmb/subscriptions","organizations_url":"https://api.github.com/users/ivanmb/orgs","repos_url":"https://api.github.com/users/ivanmb/repos","events_url":"https://api.github.com/users/ivanmb/events{/privacy}","received_events_url":"https://api.github.com/users/ivanmb/received_events","type":"User","site_admin":false},"repo":{"id":20268098,"name":"ims-lti","full_name":"ivanmb/ims-lti","owner":{"login":"ivanmb","id":1909410,"avatar_url":"https://avatars.githubusercontent.com/u/1909410?v=3","gravatar_id":"","url":"https://api.github.com/users/ivanmb","html_url":"https://github.com/ivanmb","followers_url":"https://api.github.com/users/ivanmb/followers","following_url":"https://api.github.com/users/ivanmb/following{/other_user}","gists_url":"https://api.github.com/users/ivanmb/gists{/gist_id}","starred_url":"https://api.github.com/users/ivanmb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivanmb/subscriptions","organizations_url":"https://api.github.com/users/ivanmb/orgs","repos_url":"https://api.github.com/users/ivanmb/repos","events_url":"https://api.github.com/users/ivanmb/events{/privacy}","received_events_url":"https://api.github.com/users/ivanmb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ivanmb/ims-lti","description":"PHP library to help create Tool Providers and Tool Consumers for the IMS LTI standard.","fork":false,"url":"https://api.github.com/repos/ivanmb/ims-lti","forks_url":"https://api.github.com/repos/ivanmb/ims-lti/forks","keys_url":"https://api.github.com/repos/ivanmb/ims-lti/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ivanmb/ims-lti/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ivanmb/ims-lti/teams","hooks_url":"https://api.github.com/repos/ivanmb/ims-lti/hooks","issue_events_url":"https://api.github.com/repos/ivanmb/ims-lti/issues/events{/number}","events_url":"https://api.github.com/repos/ivanmb/ims-lti/events","assignees_url":"https://api.github.com/repos/ivanmb/ims-lti/assignees{/user}","branches_url":"https://api.github.com/repos/ivanmb/ims-lti/branches{/branch}","tags_url":"https://api.github.com/repos/ivanmb/ims-lti/tags","blobs_url":"https://api.github.com/repos/ivanmb/ims-lti/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ivanmb/ims-lti/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ivanmb/ims-lti/git/refs{/sha}","trees_url":"https://api.github.com/repos/ivanmb/ims-lti/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ivanmb/ims-lti/statuses/{sha}","languages_url":"https://api.github.com/repos/ivanmb/ims-lti/languages","stargazers_url":"https://api.github.com/repos/ivanmb/ims-lti/stargazers","contributors_url":"https://api.github.com/repos/ivanmb/ims-lti/contributors","subscribers_url":"https://api.github.com/repos/ivanmb/ims-lti/subscribers","subscription_url":"https://api.github.com/repos/ivanmb/ims-lti/subscription","commits_url":"https://api.github.com/repos/ivanmb/ims-lti/commits{/sha}","git_commits_url":"https://api.github.com/repos/ivanmb/ims-lti/git/commits{/sha}","comments_url":"https://api.github.com/repos/ivanmb/ims-lti/comments{/number}","issue_comment_url":"https://api.github.com/repos/ivanmb/ims-lti/issues/comments{/number}","contents_url":"https://api.github.com/repos/ivanmb/ims-lti/contents/{+path}","compare_url":"https://api.github.com/repos/ivanmb/ims-lti/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ivanmb/ims-lti/merges","archive_url":"https://api.github.com/repos/ivanmb/ims-lti/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ivanmb/ims-lti/downloads","issues_url":"https://api.github.com/repos/ivanmb/ims-lti/issues{/number}","pulls_url":"https://api.github.com/repos/ivanmb/ims-lti/pulls{/number}","milestones_url":"https://api.github.com/repos/ivanmb/ims-lti/milestones{/number}","notifications_url":"https://api.github.com/repos/ivanmb/ims-lti/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ivanmb/ims-lti/labels{/name}","releases_url":"https://api.github.com/repos/ivanmb/ims-lti/releases{/id}","created_at":"2014-05-28T18:34:02Z","updated_at":"2015-06-16T13:02:34Z","pushed_at":"2015-06-16T13:02:34Z","git_url":"git://github.com/ivanmb/ims-lti.git","ssh_url":"git@github.com:ivanmb/ims-lti.git","clone_url":"https://github.com/ivanmb/ims-lti.git","svn_url":"https://github.com/ivanmb/ims-lti","homepage":null,"size":222,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ivanmb/ims-lti/pulls/2"},"html":{"href":"https://github.com/ivanmb/ims-lti/pull/2"},"issue":{"href":"https://api.github.com/repos/ivanmb/ims-lti/issues/2"},"comments":{"href":"https://api.github.com/repos/ivanmb/ims-lti/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/ivanmb/ims-lti/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/ivanmb/ims-lti/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ivanmb/ims-lti/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/ivanmb/ims-lti/statuses/44141ac45a9361b5b4098bfb6d3ac255a527121b"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":8,"additions":772,"deletions":153,"changed_files":6}}