{"action":"created","issue":{"url":"https://api.github.com/repos/Elgg/Elgg/issues/8123","labels_url":"https://api.github.com/repos/Elgg/Elgg/issues/8123/labels{/name}","comments_url":"https://api.github.com/repos/Elgg/Elgg/issues/8123/comments","events_url":"https://api.github.com/repos/Elgg/Elgg/issues/8123/events","html_url":"https://github.com/Elgg/Elgg/issues/8123","id":67169886,"number":8123,"title":"Tags for discussion topics are saved with a leading space","user":{"login":"brettp","id":43375,"avatar_url":"https://avatars.githubusercontent.com/u/43375?v=3","gravatar_id":"","url":"https://api.github.com/users/brettp","html_url":"https://github.com/brettp","followers_url":"https://api.github.com/users/brettp/followers","following_url":"https://api.github.com/users/brettp/following{/other_user}","gists_url":"https://api.github.com/users/brettp/gists{/gist_id}","starred_url":"https://api.github.com/users/brettp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brettp/subscriptions","organizations_url":"https://api.github.com/users/brettp/orgs","repos_url":"https://api.github.com/users/brettp/repos","events_url":"https://api.github.com/users/brettp/events{/privacy}","received_events_url":"https://api.github.com/users/brettp/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Elgg/Elgg/labels/bug","name":"bug","color":"DDDDDD"},{"url":"https://api.github.com/repos/Elgg/Elgg/labels/in%20progress","name":"in progress","color":"ededed"}],"state":"open","locked":false,"assignee":{"login":"brettp","id":43375,"avatar_url":"https://avatars.githubusercontent.com/u/43375?v=3","gravatar_id":"","url":"https://api.github.com/users/brettp","html_url":"https://github.com/brettp","followers_url":"https://api.github.com/users/brettp/followers","following_url":"https://api.github.com/users/brettp/following{/other_user}","gists_url":"https://api.github.com/users/brettp/gists{/gist_id}","starred_url":"https://api.github.com/users/brettp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brettp/subscriptions","organizations_url":"https://api.github.com/users/brettp/orgs","repos_url":"https://api.github.com/users/brettp/repos","events_url":"https://api.github.com/users/brettp/events{/privacy}","received_events_url":"https://api.github.com/users/brettp/received_events","type":"User","site_admin":false},"milestone":null,"comments":1,"created_at":"2015-04-08T16:37:27Z","updated_at":"2015-04-08T20:36:27Z","closed_at":null,"body":"The discussion/save action uses split(\",\", $tags) instead of string_to_tag_array(), so surrounding whitespace is saved as part of the tag.\r\n\r\nThis looks like it was introduced in 1.8, so fixing it will require an update to trim whitespace on existing tags."},"comment":{"url":"https://api.github.com/repos/Elgg/Elgg/issues/comments/91029774","html_url":"https://github.com/Elgg/Elgg/issues/8123#issuecomment-91029774","issue_url":"https://api.github.com/repos/Elgg/Elgg/issues/8123","id":91029774,"user":{"login":"brettp","id":43375,"avatar_url":"https://avatars.githubusercontent.com/u/43375?v=3","gravatar_id":"","url":"https://api.github.com/users/brettp","html_url":"https://github.com/brettp","followers_url":"https://api.github.com/users/brettp/followers","following_url":"https://api.github.com/users/brettp/following{/other_user}","gists_url":"https://api.github.com/users/brettp/gists{/gist_id}","starred_url":"https://api.github.com/users/brettp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brettp/subscriptions","organizations_url":"https://api.github.com/users/brettp/orgs","repos_url":"https://api.github.com/users/brettp/repos","events_url":"https://api.github.com/users/brettp/events{/privacy}","received_events_url":"https://api.github.com/users/brettp/received_events","type":"User","site_admin":false},"created_at":"2015-04-08T20:36:27Z","updated_at":"2015-04-08T20:36:27Z","body":"This was actually introduced in 1.9. 1.9's Elgg_Database::sanitizeString() doesn't trim but <= 1.8's sanitise_string() did. This means all metastrings added since 1.9 are not trimmed.\r\n\r\nIMHO this is regression with at least adding metastrings, and possibly with sanitizeString(). Are there any use cases for metastrings with whitespace padding?"}}