{"action":"closed","number":5778,"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/5778","id":53191513,"html_url":"https://github.com/ManageIQ/manageiq/pull/5778","diff_url":"https://github.com/ManageIQ/manageiq/pull/5778.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/5778.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/5778","number":5778,"state":"closed","locked":false,"title":"RSpec 'expect' syntax for automation specs","user":{"login":"chrisarcand","id":2430490,"avatar_url":"https://avatars.githubusercontent.com/u/2430490?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisarcand","html_url":"https://github.com/chrisarcand","followers_url":"https://api.github.com/users/chrisarcand/followers","following_url":"https://api.github.com/users/chrisarcand/following{/other_user}","gists_url":"https://api.github.com/users/chrisarcand/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisarcand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisarcand/subscriptions","organizations_url":"https://api.github.com/users/chrisarcand/orgs","repos_url":"https://api.github.com/users/chrisarcand/repos","events_url":"https://api.github.com/users/chrisarcand/events{/privacy}","received_events_url":"https://api.github.com/users/chrisarcand/received_events","type":"User","site_admin":false},"body":"* Converts all automation specs to the new (Not really new anymore, is it?) `expect` syntax\r\n* Enables the inferring of test type by rspec-rails (no need to specify `type => :controller` for instance) (keeps currently functionality we use in RSpec2)\r\n* Also removes all Rubocop violations from automation specs\r\n\r\n**Note**: There are still two deprecations present when running automation specs. These specs are tied to our use of rspec-fire, which is obsolete with RSpec 3 doubles. rspec-fire allows for NOOP functionality in RSpec3, so I'm waiting to remove it until we actually move to RSpec 3 and can do it cleanly. \r\n\r\ncc/ @jrafanie @Fryguy ","created_at":"2015-12-09T22:59:28Z","updated_at":"2015-12-10T18:47:01Z","closed_at":"2015-12-10T18:47:01Z","merged_at":"2015-12-10T18:47:01Z","merge_commit_sha":"e15392ac03ee29e08c9bb7d98d361cab62a231cc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/5778/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/5778/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/5778/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/75b43a57b060be18fe4321c2617cc8242c3ba7e0","head":{"label":"chrisarcand:rspec3-automation","ref":"rspec3-automation","sha":"75b43a57b060be18fe4321c2617cc8242c3ba7e0","user":{"login":"chrisarcand","id":2430490,"avatar_url":"https://avatars.githubusercontent.com/u/2430490?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisarcand","html_url":"https://github.com/chrisarcand","followers_url":"https://api.github.com/users/chrisarcand/followers","following_url":"https://api.github.com/users/chrisarcand/following{/other_user}","gists_url":"https://api.github.com/users/chrisarcand/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisarcand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisarcand/subscriptions","organizations_url":"https://api.github.com/users/chrisarcand/orgs","repos_url":"https://api.github.com/users/chrisarcand/repos","events_url":"https://api.github.com/users/chrisarcand/events{/privacy}","received_events_url":"https://api.github.com/users/chrisarcand/received_events","type":"User","site_admin":false},"repo":{"id":43688847,"name":"manageiq","full_name":"chrisarcand/manageiq","owner":{"login":"chrisarcand","id":2430490,"avatar_url":"https://avatars.githubusercontent.com/u/2430490?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisarcand","html_url":"https://github.com/chrisarcand","followers_url":"https://api.github.com/users/chrisarcand/followers","following_url":"https://api.github.com/users/chrisarcand/following{/other_user}","gists_url":"https://api.github.com/users/chrisarcand/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisarcand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisarcand/subscriptions","organizations_url":"https://api.github.com/users/chrisarcand/orgs","repos_url":"https://api.github.com/users/chrisarcand/repos","events_url":"https://api.github.com/users/chrisarcand/events{/privacy}","received_events_url":"https://api.github.com/users/chrisarcand/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chrisarcand/manageiq","description":"ManageIQ Cloud Management Platform","fork":true,"url":"https://api.github.com/repos/chrisarcand/manageiq","forks_url":"https://api.github.com/repos/chrisarcand/manageiq/forks","keys_url":"https://api.github.com/repos/chrisarcand/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chrisarcand/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chrisarcand/manageiq/teams","hooks_url":"https://api.github.com/repos/chrisarcand/manageiq/hooks","issue_events_url":"https://api.github.com/repos/chrisarcand/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/chrisarcand/manageiq/events","assignees_url":"https://api.github.com/repos/chrisarcand/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/chrisarcand/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/chrisarcand/manageiq/tags","blobs_url":"https://api.github.com/repos/chrisarcand/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chrisarcand/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chrisarcand/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/chrisarcand/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chrisarcand/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/chrisarcand/manageiq/languages","stargazers_url":"https://api.github.com/repos/chrisarcand/manageiq/stargazers","contributors_url":"https://api.github.com/repos/chrisarcand/manageiq/contributors","subscribers_url":"https://api.github.com/repos/chrisarcand/manageiq/subscribers","subscription_url":"https://api.github.com/repos/chrisarcand/manageiq/subscription","commits_url":"https://api.github.com/repos/chrisarcand/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/chrisarcand/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/chrisarcand/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/chrisarcand/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/chrisarcand/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/chrisarcand/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chrisarcand/manageiq/merges","archive_url":"https://api.github.com/repos/chrisarcand/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chrisarcand/manageiq/downloads","issues_url":"https://api.github.com/repos/chrisarcand/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/chrisarcand/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/chrisarcand/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/chrisarcand/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chrisarcand/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/chrisarcand/manageiq/releases{/id}","created_at":"2015-10-05T14:22:26Z","updated_at":"2015-10-05T14:22:49Z","pushed_at":"2015-12-10T16:39:58Z","git_url":"git://github.com/chrisarcand/manageiq.git","ssh_url":"git@github.com:chrisarcand/manageiq.git","clone_url":"https://github.com/chrisarcand/manageiq.git","svn_url":"https://github.com/chrisarcand/manageiq","homepage":"manageiq.org","size":97950,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"3f6966555f89b575144f5e6ab69c5682e1165c70","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":20789757,"name":"manageiq","full_name":"ManageIQ/manageiq","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq","description":"ManageIQ Cloud Management Platform","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq","forks_url":"https://api.github.com/repos/ManageIQ/manageiq/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq/releases{/id}","created_at":"2014-06-13T02:31:26Z","updated_at":"2015-12-08T16:36:03Z","pushed_at":"2015-12-10T18:47:01Z","git_url":"git://github.com/ManageIQ/manageiq.git","ssh_url":"git@github.com:ManageIQ/manageiq.git","clone_url":"https://github.com/ManageIQ/manageiq.git","svn_url":"https://github.com/ManageIQ/manageiq","homepage":"manageiq.org","size":131961,"stargazers_count":175,"watchers_count":175,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":195,"mirror_url":null,"open_issues_count":466,"forks":195,"open_issues":466,"watchers":175,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/5778"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/5778"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/5778"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/5778/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/5778/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/5778/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq/statuses/75b43a57b060be18fe4321c2617cc8242c3ba7e0"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jrafanie","id":19339,"avatar_url":"https://avatars.githubusercontent.com/u/19339?v=3","gravatar_id":"","url":"https://api.github.com/users/jrafanie","html_url":"https://github.com/jrafanie","followers_url":"https://api.github.com/users/jrafanie/followers","following_url":"https://api.github.com/users/jrafanie/following{/other_user}","gists_url":"https://api.github.com/users/jrafanie/gists{/gist_id}","starred_url":"https://api.github.com/users/jrafanie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrafanie/subscriptions","organizations_url":"https://api.github.com/users/jrafanie/orgs","repos_url":"https://api.github.com/users/jrafanie/repos","events_url":"https://api.github.com/users/jrafanie/events{/privacy}","received_events_url":"https://api.github.com/users/jrafanie/received_events","type":"User","site_admin":false},"comments":5,"review_comments":12,"commits":3,"additions":174,"deletions":158,"changed_files":27}}