{"action":"created","comment":{"url":"https://api.github.com/repos/chef/omnibus-software/pulls/comments/43559241","id":43559241,"diff_hunk":"@@ -0,0 +1,992 @@\n+--- config.guess_OLD\t2015-10-30 21:16:33.910969812 +0000\n++++ config.guess\t2015-10-30 21:16:39.771905250 +0000\n+@@ -1,14 +1,12 @@\n+ #! /bin/sh\n+ # Attempt to guess a canonical system name.\n+-#   Copyright (C) 1992, 1993, 1994, 1995, 1996, 1997, 1998, 1999,\n+-#   2000, 2001, 2002, 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010\n+-#   Free Software Foundation, Inc.\n++#   Copyright 1992-2015 Free Software Foundation, Inc.\n+ \n+-timestamp='2009-12-30'\n++timestamp='2015-10-21'\n+ \n+ # This file is free software; you can redistribute it and/or modify it\n+ # under the terms of the GNU General Public License as published by\n+-# the Free Software Foundation; either version 2 of the License, or\n++# the Free Software Foundation; either version 3 of the License, or","path":"config/patches/pkg-config-lite/pkg-config-lite-0.28-1.config.guess.patch","position":17,"original_position":17,"commit_id":"17b1cddc7dfba8b68e4e12f5a3562efa03da1544","original_commit_id":"97037c5c92e256bcf0d8abc34279852821c5f95d","user":{"login":"lamont-granquist","id":454857,"avatar_url":"https://avatars.githubusercontent.com/u/454857?v=3","gravatar_id":"","url":"https://api.github.com/users/lamont-granquist","html_url":"https://github.com/lamont-granquist","followers_url":"https://api.github.com/users/lamont-granquist/followers","following_url":"https://api.github.com/users/lamont-granquist/following{/other_user}","gists_url":"https://api.github.com/users/lamont-granquist/gists{/gist_id}","starred_url":"https://api.github.com/users/lamont-granquist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lamont-granquist/subscriptions","organizations_url":"https://api.github.com/users/lamont-granquist/orgs","repos_url":"https://api.github.com/users/lamont-granquist/repos","events_url":"https://api.github.com/users/lamont-granquist/events{/privacy}","received_events_url":"https://api.github.com/users/lamont-granquist/received_events","type":"User","site_admin":false},"body":"My argument was for both of those...\r\n\r\nAnd actually its most likely much more sustainable for us to bake modern autoconf into our build images (not in omnibus-software/omnibus-chef but into the omnibus cookbook or that omnibus package that @scotthain setup for build deps for omnibus itself).  Then instead of patching config.guess, we simply re-autoconf the software and regenerate configure+friends and run from there.\r\n\r\nThat is both less hacky, less patchy and won't show up as scary GPLv3 banners checked into our codebase, so its probably the right thing to do.  The patches to config.guess are being generated by this process by people making with the typey-typey to generate config.guess and then they create a patch and generate a PR and put it here.  That process seems broken and we should just automate it...","created_at":"2015-10-30T22:30:43Z","updated_at":"2015-10-30T22:30:43Z","html_url":"https://github.com/chef/omnibus-software/pull/510#discussion_r43559241","pull_request_url":"https://api.github.com/repos/chef/omnibus-software/pulls/510","_links":{"self":{"href":"https://api.github.com/repos/chef/omnibus-software/pulls/comments/43559241"},"html":{"href":"https://github.com/chef/omnibus-software/pull/510#discussion_r43559241"},"pull_request":{"href":"https://api.github.com/repos/chef/omnibus-software/pulls/510"}}},"pull_request":{"url":"https://api.github.com/repos/chef/omnibus-software/pulls/510","id":49324183,"html_url":"https://github.com/chef/omnibus-software/pull/510","diff_url":"https://github.com/chef/omnibus-software/pull/510.diff","patch_url":"https://github.com/chef/omnibus-software/pull/510.patch","issue_url":"https://api.github.com/repos/chef/omnibus-software/issues/510","number":510,"state":"open","locked":false,"title":"Remove GDBM, add pkg-config-lite and update things to use it","user":{"login":"scotthain","id":2817921,"avatar_url":"https://avatars.githubusercontent.com/u/2817921?v=3","gravatar_id":"","url":"https://api.github.com/users/scotthain","html_url":"https://github.com/scotthain","followers_url":"https://api.github.com/users/scotthain/followers","following_url":"https://api.github.com/users/scotthain/following{/other_user}","gists_url":"https://api.github.com/users/scotthain/gists{/gist_id}","starred_url":"https://api.github.com/users/scotthain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scotthain/subscriptions","organizations_url":"https://api.github.com/users/scotthain/orgs","repos_url":"https://api.github.com/users/scotthain/repos","events_url":"https://api.github.com/users/scotthain/events{/privacy}","received_events_url":"https://api.github.com/users/scotthain/received_events","type":"User","site_admin":false},"body":"@chef/omnibus-maintainers @edolnx @lamont-granquist ","created_at":"2015-10-30T21:23:20Z","updated_at":"2015-10-30T22:30:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"011f2ddf5ccbf1df94d3bf00abe2258da97f1335","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/chef/omnibus-software/pulls/510/commits","review_comments_url":"https://api.github.com/repos/chef/omnibus-software/pulls/510/comments","review_comment_url":"https://api.github.com/repos/chef/omnibus-software/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chef/omnibus-software/issues/510/comments","statuses_url":"https://api.github.com/repos/chef/omnibus-software/statuses/17b1cddc7dfba8b68e4e12f5a3562efa03da1544","head":{"label":"chef:shain/dep_cleanup_test","ref":"shain/dep_cleanup_test","sha":"17b1cddc7dfba8b68e4e12f5a3562efa03da1544","user":{"login":"chef","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?v=3","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"repo":{"id":4046291,"name":"omnibus-software","full_name":"chef/omnibus-software","owner":{"login":"chef","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?v=3","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chef/omnibus-software","description":"Open Source Software for use in Omnibus built packages","fork":false,"url":"https://api.github.com/repos/chef/omnibus-software","forks_url":"https://api.github.com/repos/chef/omnibus-software/forks","keys_url":"https://api.github.com/repos/chef/omnibus-software/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chef/omnibus-software/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chef/omnibus-software/teams","hooks_url":"https://api.github.com/repos/chef/omnibus-software/hooks","issue_events_url":"https://api.github.com/repos/chef/omnibus-software/issues/events{/number}","events_url":"https://api.github.com/repos/chef/omnibus-software/events","assignees_url":"https://api.github.com/repos/chef/omnibus-software/assignees{/user}","branches_url":"https://api.github.com/repos/chef/omnibus-software/branches{/branch}","tags_url":"https://api.github.com/repos/chef/omnibus-software/tags","blobs_url":"https://api.github.com/repos/chef/omnibus-software/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chef/omnibus-software/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chef/omnibus-software/git/refs{/sha}","trees_url":"https://api.github.com/repos/chef/omnibus-software/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chef/omnibus-software/statuses/{sha}","languages_url":"https://api.github.com/repos/chef/omnibus-software/languages","stargazers_url":"https://api.github.com/repos/chef/omnibus-software/stargazers","contributors_url":"https://api.github.com/repos/chef/omnibus-software/contributors","subscribers_url":"https://api.github.com/repos/chef/omnibus-software/subscribers","subscription_url":"https://api.github.com/repos/chef/omnibus-software/subscription","commits_url":"https://api.github.com/repos/chef/omnibus-software/commits{/sha}","git_commits_url":"https://api.github.com/repos/chef/omnibus-software/git/commits{/sha}","comments_url":"https://api.github.com/repos/chef/omnibus-software/comments{/number}","issue_comment_url":"https://api.github.com/repos/chef/omnibus-software/issues/comments{/number}","contents_url":"https://api.github.com/repos/chef/omnibus-software/contents/{+path}","compare_url":"https://api.github.com/repos/chef/omnibus-software/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chef/omnibus-software/merges","archive_url":"https://api.github.com/repos/chef/omnibus-software/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chef/omnibus-software/downloads","issues_url":"https://api.github.com/repos/chef/omnibus-software/issues{/number}","pulls_url":"https://api.github.com/repos/chef/omnibus-software/pulls{/number}","milestones_url":"https://api.github.com/repos/chef/omnibus-software/milestones{/number}","notifications_url":"https://api.github.com/repos/chef/omnibus-software/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chef/omnibus-software/labels{/name}","releases_url":"https://api.github.com/repos/chef/omnibus-software/releases{/id}","created_at":"2012-04-16T21:48:51Z","updated_at":"2015-08-15T18:46:34Z","pushed_at":"2015-10-30T21:48:03Z","git_url":"git://github.com/chef/omnibus-software.git","ssh_url":"git@github.com:chef/omnibus-software.git","clone_url":"https://github.com/chef/omnibus-software.git","svn_url":"https://github.com/chef/omnibus-software","homepage":"","size":6225,"stargazers_count":80,"watchers_count":80,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":168,"mirror_url":null,"open_issues_count":30,"forks":168,"open_issues":30,"watchers":80,"default_branch":"master"}},"base":{"label":"chef:master","ref":"master","sha":"2571d69789d99679da48a071db11f1b143f20ccc","user":{"login":"chef","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?v=3","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"repo":{"id":4046291,"name":"omnibus-software","full_name":"chef/omnibus-software","owner":{"login":"chef","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?v=3","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chef/omnibus-software","description":"Open Source Software for use in Omnibus built packages","fork":false,"url":"https://api.github.com/repos/chef/omnibus-software","forks_url":"https://api.github.com/repos/chef/omnibus-software/forks","keys_url":"https://api.github.com/repos/chef/omnibus-software/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chef/omnibus-software/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chef/omnibus-software/teams","hooks_url":"https://api.github.com/repos/chef/omnibus-software/hooks","issue_events_url":"https://api.github.com/repos/chef/omnibus-software/issues/events{/number}","events_url":"https://api.github.com/repos/chef/omnibus-software/events","assignees_url":"https://api.github.com/repos/chef/omnibus-software/assignees{/user}","branches_url":"https://api.github.com/repos/chef/omnibus-software/branches{/branch}","tags_url":"https://api.github.com/repos/chef/omnibus-software/tags","blobs_url":"https://api.github.com/repos/chef/omnibus-software/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chef/omnibus-software/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chef/omnibus-software/git/refs{/sha}","trees_url":"https://api.github.com/repos/chef/omnibus-software/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chef/omnibus-software/statuses/{sha}","languages_url":"https://api.github.com/repos/chef/omnibus-software/languages","stargazers_url":"https://api.github.com/repos/chef/omnibus-software/stargazers","contributors_url":"https://api.github.com/repos/chef/omnibus-software/contributors","subscribers_url":"https://api.github.com/repos/chef/omnibus-software/subscribers","subscription_url":"https://api.github.com/repos/chef/omnibus-software/subscription","commits_url":"https://api.github.com/repos/chef/omnibus-software/commits{/sha}","git_commits_url":"https://api.github.com/repos/chef/omnibus-software/git/commits{/sha}","comments_url":"https://api.github.com/repos/chef/omnibus-software/comments{/number}","issue_comment_url":"https://api.github.com/repos/chef/omnibus-software/issues/comments{/number}","contents_url":"https://api.github.com/repos/chef/omnibus-software/contents/{+path}","compare_url":"https://api.github.com/repos/chef/omnibus-software/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chef/omnibus-software/merges","archive_url":"https://api.github.com/repos/chef/omnibus-software/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chef/omnibus-software/downloads","issues_url":"https://api.github.com/repos/chef/omnibus-software/issues{/number}","pulls_url":"https://api.github.com/repos/chef/omnibus-software/pulls{/number}","milestones_url":"https://api.github.com/repos/chef/omnibus-software/milestones{/number}","notifications_url":"https://api.github.com/repos/chef/omnibus-software/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chef/omnibus-software/labels{/name}","releases_url":"https://api.github.com/repos/chef/omnibus-software/releases{/id}","created_at":"2012-04-16T21:48:51Z","updated_at":"2015-08-15T18:46:34Z","pushed_at":"2015-10-30T21:48:03Z","git_url":"git://github.com/chef/omnibus-software.git","ssh_url":"git@github.com:chef/omnibus-software.git","clone_url":"https://github.com/chef/omnibus-software.git","svn_url":"https://github.com/chef/omnibus-software","homepage":"","size":6225,"stargazers_count":80,"watchers_count":80,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":168,"mirror_url":null,"open_issues_count":30,"forks":168,"open_issues":30,"watchers":80,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chef/omnibus-software/pulls/510"},"html":{"href":"https://github.com/chef/omnibus-software/pull/510"},"issue":{"href":"https://api.github.com/repos/chef/omnibus-software/issues/510"},"comments":{"href":"https://api.github.com/repos/chef/omnibus-software/issues/510/comments"},"review_comments":{"href":"https://api.github.com/repos/chef/omnibus-software/pulls/510/comments"},"review_comment":{"href":"https://api.github.com/repos/chef/omnibus-software/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chef/omnibus-software/pulls/510/commits"},"statuses":{"href":"https://api.github.com/repos/chef/omnibus-software/statuses/17b1cddc7dfba8b68e4e12f5a3562efa03da1544"}}}}