{"action":"closed","number":17,"pull_request":{"url":"https://api.github.com/repos/arioch/puppet-redis/pulls/17","id":27098003,"html_url":"https://github.com/arioch/puppet-redis/pull/17","diff_url":"https://github.com/arioch/puppet-redis/pull/17.diff","patch_url":"https://github.com/arioch/puppet-redis/pull/17.patch","issue_url":"https://api.github.com/repos/arioch/puppet-redis/issues/17","number":17,"state":"closed","locked":false,"title":"Make config file owner dependency on redis package explicit","user":{"login":"cdent","id":34498,"avatar_url":"https://avatars.githubusercontent.com/u/34498?v=3","gravatar_id":"","url":"https://api.github.com/users/cdent","html_url":"https://github.com/cdent","followers_url":"https://api.github.com/users/cdent/followers","following_url":"https://api.github.com/users/cdent/following{/other_user}","gists_url":"https://api.github.com/users/cdent/gists{/gist_id}","starred_url":"https://api.github.com/users/cdent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdent/subscriptions","organizations_url":"https://api.github.com/users/cdent/orgs","repos_url":"https://api.github.com/users/cdent/repos","events_url":"https://api.github.com/users/cdent/events{/privacy}","received_events_url":"https://api.github.com/users/cdent/received_events","type":"User","site_admin":false},"body":"Without this it's possible that on a clean machine where only sentinel\r\nis being installed the install will fail because the 'redis' user\r\n(who owns the *.puppet config file) will not yet exist.\r\n\r\nBy ensuring that the redis package is installed explicitly first the\r\nuser will be there.\r\n\r\nThe previous pull request related to this problem added the package\r\ndependency but did not make the ordering explicity.","created_at":"2015-01-09T12:53:36Z","updated_at":"2015-01-09T13:10:45Z","closed_at":"2015-01-09T13:10:45Z","merged_at":"2015-01-09T13:10:45Z","merge_commit_sha":"3f97201b738985c9feca3b8550b938f1880a153a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/arioch/puppet-redis/pulls/17/commits","review_comments_url":"https://api.github.com/repos/arioch/puppet-redis/pulls/17/comments","review_comment_url":"https://api.github.com/repos/arioch/puppet-redis/pulls/comments/{number}","comments_url":"https://api.github.com/repos/arioch/puppet-redis/issues/17/comments","statuses_url":"https://api.github.com/repos/arioch/puppet-redis/statuses/d72af9ab3c2911b6dc18c5cc12e700630ebdcfb2","head":{"label":"cdent:sentinel-dependency-ordering","ref":"sentinel-dependency-ordering","sha":"d72af9ab3c2911b6dc18c5cc12e700630ebdcfb2","user":{"login":"cdent","id":34498,"avatar_url":"https://avatars.githubusercontent.com/u/34498?v=3","gravatar_id":"","url":"https://api.github.com/users/cdent","html_url":"https://github.com/cdent","followers_url":"https://api.github.com/users/cdent/followers","following_url":"https://api.github.com/users/cdent/following{/other_user}","gists_url":"https://api.github.com/users/cdent/gists{/gist_id}","starred_url":"https://api.github.com/users/cdent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdent/subscriptions","organizations_url":"https://api.github.com/users/cdent/orgs","repos_url":"https://api.github.com/users/cdent/repos","events_url":"https://api.github.com/users/cdent/events{/privacy}","received_events_url":"https://api.github.com/users/cdent/received_events","type":"User","site_admin":false},"repo":{"id":27823387,"name":"puppet-redis","full_name":"cdent/puppet-redis","owner":{"login":"cdent","id":34498,"avatar_url":"https://avatars.githubusercontent.com/u/34498?v=3","gravatar_id":"","url":"https://api.github.com/users/cdent","html_url":"https://github.com/cdent","followers_url":"https://api.github.com/users/cdent/followers","following_url":"https://api.github.com/users/cdent/following{/other_user}","gists_url":"https://api.github.com/users/cdent/gists{/gist_id}","starred_url":"https://api.github.com/users/cdent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdent/subscriptions","organizations_url":"https://api.github.com/users/cdent/orgs","repos_url":"https://api.github.com/users/cdent/repos","events_url":"https://api.github.com/users/cdent/events{/privacy}","received_events_url":"https://api.github.com/users/cdent/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cdent/puppet-redis","description":"","fork":true,"url":"https://api.github.com/repos/cdent/puppet-redis","forks_url":"https://api.github.com/repos/cdent/puppet-redis/forks","keys_url":"https://api.github.com/repos/cdent/puppet-redis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cdent/puppet-redis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cdent/puppet-redis/teams","hooks_url":"https://api.github.com/repos/cdent/puppet-redis/hooks","issue_events_url":"https://api.github.com/repos/cdent/puppet-redis/issues/events{/number}","events_url":"https://api.github.com/repos/cdent/puppet-redis/events","assignees_url":"https://api.github.com/repos/cdent/puppet-redis/assignees{/user}","branches_url":"https://api.github.com/repos/cdent/puppet-redis/branches{/branch}","tags_url":"https://api.github.com/repos/cdent/puppet-redis/tags","blobs_url":"https://api.github.com/repos/cdent/puppet-redis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cdent/puppet-redis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cdent/puppet-redis/git/refs{/sha}","trees_url":"https://api.github.com/repos/cdent/puppet-redis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cdent/puppet-redis/statuses/{sha}","languages_url":"https://api.github.com/repos/cdent/puppet-redis/languages","stargazers_url":"https://api.github.com/repos/cdent/puppet-redis/stargazers","contributors_url":"https://api.github.com/repos/cdent/puppet-redis/contributors","subscribers_url":"https://api.github.com/repos/cdent/puppet-redis/subscribers","subscription_url":"https://api.github.com/repos/cdent/puppet-redis/subscription","commits_url":"https://api.github.com/repos/cdent/puppet-redis/commits{/sha}","git_commits_url":"https://api.github.com/repos/cdent/puppet-redis/git/commits{/sha}","comments_url":"https://api.github.com/repos/cdent/puppet-redis/comments{/number}","issue_comment_url":"https://api.github.com/repos/cdent/puppet-redis/issues/comments/{number}","contents_url":"https://api.github.com/repos/cdent/puppet-redis/contents/{+path}","compare_url":"https://api.github.com/repos/cdent/puppet-redis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cdent/puppet-redis/merges","archive_url":"https://api.github.com/repos/cdent/puppet-redis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cdent/puppet-redis/downloads","issues_url":"https://api.github.com/repos/cdent/puppet-redis/issues{/number}","pulls_url":"https://api.github.com/repos/cdent/puppet-redis/pulls{/number}","milestones_url":"https://api.github.com/repos/cdent/puppet-redis/milestones{/number}","notifications_url":"https://api.github.com/repos/cdent/puppet-redis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cdent/puppet-redis/labels{/name}","releases_url":"https://api.github.com/repos/cdent/puppet-redis/releases{/id}","created_at":"2014-12-10T14:27:48Z","updated_at":"2015-01-07T17:45:09Z","pushed_at":"2015-01-09T12:53:09Z","git_url":"git://github.com/cdent/puppet-redis.git","ssh_url":"git@github.com:cdent/puppet-redis.git","clone_url":"https://github.com/cdent/puppet-redis.git","svn_url":"https://github.com/cdent/puppet-redis","homepage":"http://arioch.github.io/puppet-redis/","size":217,"stargazers_count":0,"watchers_count":0,"language":"Puppet","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"arioch:master","ref":"master","sha":"0e5bd1e5f0000fd2d1fa63936e2e013021dbadc4","user":{"login":"arioch","id":289522,"avatar_url":"https://avatars.githubusercontent.com/u/289522?v=3","gravatar_id":"","url":"https://api.github.com/users/arioch","html_url":"https://github.com/arioch","followers_url":"https://api.github.com/users/arioch/followers","following_url":"https://api.github.com/users/arioch/following{/other_user}","gists_url":"https://api.github.com/users/arioch/gists{/gist_id}","starred_url":"https://api.github.com/users/arioch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arioch/subscriptions","organizations_url":"https://api.github.com/users/arioch/orgs","repos_url":"https://api.github.com/users/arioch/repos","events_url":"https://api.github.com/users/arioch/events{/privacy}","received_events_url":"https://api.github.com/users/arioch/received_events","type":"User","site_admin":false},"repo":{"id":5808081,"name":"puppet-redis","full_name":"arioch/puppet-redis","owner":{"login":"arioch","id":289522,"avatar_url":"https://avatars.githubusercontent.com/u/289522?v=3","gravatar_id":"","url":"https://api.github.com/users/arioch","html_url":"https://github.com/arioch","followers_url":"https://api.github.com/users/arioch/followers","following_url":"https://api.github.com/users/arioch/following{/other_user}","gists_url":"https://api.github.com/users/arioch/gists{/gist_id}","starred_url":"https://api.github.com/users/arioch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arioch/subscriptions","organizations_url":"https://api.github.com/users/arioch/orgs","repos_url":"https://api.github.com/users/arioch/repos","events_url":"https://api.github.com/users/arioch/events{/privacy}","received_events_url":"https://api.github.com/users/arioch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/arioch/puppet-redis","description":"","fork":false,"url":"https://api.github.com/repos/arioch/puppet-redis","forks_url":"https://api.github.com/repos/arioch/puppet-redis/forks","keys_url":"https://api.github.com/repos/arioch/puppet-redis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arioch/puppet-redis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arioch/puppet-redis/teams","hooks_url":"https://api.github.com/repos/arioch/puppet-redis/hooks","issue_events_url":"https://api.github.com/repos/arioch/puppet-redis/issues/events{/number}","events_url":"https://api.github.com/repos/arioch/puppet-redis/events","assignees_url":"https://api.github.com/repos/arioch/puppet-redis/assignees{/user}","branches_url":"https://api.github.com/repos/arioch/puppet-redis/branches{/branch}","tags_url":"https://api.github.com/repos/arioch/puppet-redis/tags","blobs_url":"https://api.github.com/repos/arioch/puppet-redis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arioch/puppet-redis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arioch/puppet-redis/git/refs{/sha}","trees_url":"https://api.github.com/repos/arioch/puppet-redis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arioch/puppet-redis/statuses/{sha}","languages_url":"https://api.github.com/repos/arioch/puppet-redis/languages","stargazers_url":"https://api.github.com/repos/arioch/puppet-redis/stargazers","contributors_url":"https://api.github.com/repos/arioch/puppet-redis/contributors","subscribers_url":"https://api.github.com/repos/arioch/puppet-redis/subscribers","subscription_url":"https://api.github.com/repos/arioch/puppet-redis/subscription","commits_url":"https://api.github.com/repos/arioch/puppet-redis/commits{/sha}","git_commits_url":"https://api.github.com/repos/arioch/puppet-redis/git/commits{/sha}","comments_url":"https://api.github.com/repos/arioch/puppet-redis/comments{/number}","issue_comment_url":"https://api.github.com/repos/arioch/puppet-redis/issues/comments/{number}","contents_url":"https://api.github.com/repos/arioch/puppet-redis/contents/{+path}","compare_url":"https://api.github.com/repos/arioch/puppet-redis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arioch/puppet-redis/merges","archive_url":"https://api.github.com/repos/arioch/puppet-redis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arioch/puppet-redis/downloads","issues_url":"https://api.github.com/repos/arioch/puppet-redis/issues{/number}","pulls_url":"https://api.github.com/repos/arioch/puppet-redis/pulls{/number}","milestones_url":"https://api.github.com/repos/arioch/puppet-redis/milestones{/number}","notifications_url":"https://api.github.com/repos/arioch/puppet-redis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arioch/puppet-redis/labels{/name}","releases_url":"https://api.github.com/repos/arioch/puppet-redis/releases{/id}","created_at":"2012-09-14T10:42:59Z","updated_at":"2015-01-07T22:33:24Z","pushed_at":"2015-01-09T13:10:45Z","git_url":"git://github.com/arioch/puppet-redis.git","ssh_url":"git@github.com:arioch/puppet-redis.git","clone_url":"https://github.com/arioch/puppet-redis.git","svn_url":"https://github.com/arioch/puppet-redis","homepage":"http://arioch.github.io/puppet-redis/","size":566,"stargazers_count":7,"watchers_count":7,"language":"Puppet","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":9,"mirror_url":null,"open_issues_count":0,"forks":9,"open_issues":0,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/arioch/puppet-redis/pulls/17"},"html":{"href":"https://github.com/arioch/puppet-redis/pull/17"},"issue":{"href":"https://api.github.com/repos/arioch/puppet-redis/issues/17"},"comments":{"href":"https://api.github.com/repos/arioch/puppet-redis/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/arioch/puppet-redis/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/arioch/puppet-redis/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/arioch/puppet-redis/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/arioch/puppet-redis/statuses/d72af9ab3c2911b6dc18c5cc12e700630ebdcfb2"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"arioch","id":289522,"avatar_url":"https://avatars.githubusercontent.com/u/289522?v=3","gravatar_id":"","url":"https://api.github.com/users/arioch","html_url":"https://github.com/arioch","followers_url":"https://api.github.com/users/arioch/followers","following_url":"https://api.github.com/users/arioch/following{/other_user}","gists_url":"https://api.github.com/users/arioch/gists{/gist_id}","starred_url":"https://api.github.com/users/arioch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arioch/subscriptions","organizations_url":"https://api.github.com/users/arioch/orgs","repos_url":"https://api.github.com/users/arioch/repos","events_url":"https://api.github.com/users/arioch/events{/privacy}","received_events_url":"https://api.github.com/users/arioch/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":10,"deletions":8,"changed_files":1}}