{"action":"opened","number":229,"pull_request":{"url":"https://api.github.com/repos/django-admin-bootstrapped/django-admin-bootstrapped/pulls/229","id":50104989,"html_url":"https://github.com/django-admin-bootstrapped/django-admin-bootstrapped/pull/229","diff_url":"https://github.com/django-admin-bootstrapped/django-admin-bootstrapped/pull/229.diff","patch_url":"https://github.com/django-admin-bootstrapped/django-admin-bootstrapped/pull/229.patch","issue_url":"https://api.github.com/repos/django-admin-bootstrapped/django-admin-bootstrapped/issues/229","number":229,"state":"open","locked":false,"title":"Fix an uncaught exception in form_fieldset_column_width templatetag","user":{"login":"kevingu1003","id":897246,"avatar_url":"https://avatars.githubusercontent.com/u/897246?v=3","gravatar_id":"","url":"https://api.github.com/users/kevingu1003","html_url":"https://github.com/kevingu1003","followers_url":"https://api.github.com/users/kevingu1003/followers","following_url":"https://api.github.com/users/kevingu1003/following{/other_user}","gists_url":"https://api.github.com/users/kevingu1003/gists{/gist_id}","starred_url":"https://api.github.com/users/kevingu1003/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevingu1003/subscriptions","organizations_url":"https://api.github.com/users/kevingu1003/orgs","repos_url":"https://api.github.com/users/kevingu1003/repos","events_url":"https://api.github.com/users/kevingu1003/events{/privacy}","received_events_url":"https://api.github.com/users/kevingu1003/received_events","type":"User","site_admin":false},"body":"**Fore Sure Part:**\r\n\r\nFix an uncaught exception in `form_fieldset_column_width` templatetag that will cause the admin won't allow `fieldsets` display multiple fields on the same line in some rare situation(for example empty `fields` value for `fieldset`).\r\n\r\nFor example consider following example of `fieldsets` attr of a `ModelAdmin`:\r\n```python\r\nfieldsets = (\r\n    (None, {'fields': ('username', 'password')}),\r\n    ('Empty section', {'fields': ()}),\r\n)\r\n```\r\nWhile this is indeed a very rare situation but it's considered valid in Django Admin.\r\n\r\nIn this case the `max_line` will prematurely throw an Exception and resulting `form_fieldset_column_width` returns `12` regardless of the values from other fieldsets.\r\n\r\n**Debatable Part:**\r\n\r\nAnd after reading the code a little more I found that code in `change_form.html` will make every field in the admin page short if there's any \"multi field on one line\" situation, which is not default Django admin behavior. Thus I changed the filter in `change_form.html`.\r\n\r\nI notice that this line is the only part in code that used `form_fieldset_column_width` templatetag so this is probably an intended behavior but I don't really buy this behavior, please let me know  your idea.","created_at":"2015-11-09T10:18:56Z","updated_at":"2015-11-09T10:18:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/django-admin-bootstrapped/django-admin-bootstrapped/pulls/229/commits","review_comments_url":"https://api.github.com/repos/django-admin-bootstrapped/django-admin-bootstrapped/pulls/229/comments","review_comment_url":"https://api.github.com/repos/django-admin-bootstrapped/django-admin-bootstrapped/pulls/comments{/number}","comments_url":"https://api.github.com/repos/django-admin-bootstrapped/django-admin-bootstrapped/issues/229/comments","statuses_url":"https://api.github.com/repos/django-admin-bootstrapped/django-admin-bootstrapped/statuses/30e25f7f8fb516438ff5ffdd8f54b0ee79f9c16e","head":{"label":"kevingu1003:master","ref":"master","sha":"30e25f7f8fb516438ff5ffdd8f54b0ee79f9c16e","user":{"login":"kevingu1003","id":897246,"avatar_url":"https://avatars.githubusercontent.com/u/897246?v=3","gravatar_id":"","url":"https://api.github.com/users/kevingu1003","html_url":"https://github.com/kevingu1003","followers_url":"https://api.github.com/users/kevingu1003/followers","following_url":"https://api.github.com/users/kevingu1003/following{/other_user}","gists_url":"https://api.github.com/users/kevingu1003/gists{/gist_id}","starred_url":"https://api.github.com/users/kevingu1003/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevingu1003/subscriptions","organizations_url":"https://api.github.com/users/kevingu1003/orgs","repos_url":"https://api.github.com/users/kevingu1003/repos","events_url":"https://api.github.com/users/kevingu1003/events{/privacy}","received_events_url":"https://api.github.com/users/kevingu1003/received_events","type":"User","site_admin":false},"repo":{"id":45827892,"name":"django-admin-bootstrapped","full_name":"kevingu1003/django-admin-bootstrapped","owner":{"login":"kevingu1003","id":897246,"avatar_url":"https://avatars.githubusercontent.com/u/897246?v=3","gravatar_id":"","url":"https://api.github.com/users/kevingu1003","html_url":"https://github.com/kevingu1003","followers_url":"https://api.github.com/users/kevingu1003/followers","following_url":"https://api.github.com/users/kevingu1003/following{/other_user}","gists_url":"https://api.github.com/users/kevingu1003/gists{/gist_id}","starred_url":"https://api.github.com/users/kevingu1003/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevingu1003/subscriptions","organizations_url":"https://api.github.com/users/kevingu1003/orgs","repos_url":"https://api.github.com/users/kevingu1003/repos","events_url":"https://api.github.com/users/kevingu1003/events{/privacy}","received_events_url":"https://api.github.com/users/kevingu1003/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kevingu1003/django-admin-bootstrapped","description":"A Django admin theme using Twitter Bootstrap. It doesn't need any kind of modification on your side, just add it to the installed apps.","fork":true,"url":"https://api.github.com/repos/kevingu1003/django-admin-bootstrapped","forks_url":"https://api.github.com/repos/kevingu1003/django-admin-bootstrapped/forks","keys_url":"https://api.github.com/repos/kevingu1003/django-admin-bootstrapped/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kevingu1003/django-admin-bootstrapped/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kevingu1003/django-admin-bootstrapped/teams","hooks_url":"https://api.github.com/repos/kevingu1003/django-admin-bootstrapped/hooks","issue_events_url":"https://api.github.com/repos/kevingu1003/django-admin-bootstrapped/issues/events{/number}","events_url":"https://api.github.com/repos/kevingu1003/django-admin-bootstrapped/events","assignees_url":"https://api.github.com/repos/kevingu1003/django-admin-bootstrapped/assignees{/user}","branches_url":"https://api.github.com/repos/kevingu1003/django-admin-bootstrapped/branches{/branch}","tags_url":"https://api.github.com/repos/kevingu1003/django-admin-bootstrapped/tags","blobs_url":"https://api.github.com/repos/kevingu1003/django-admin-bootstrapped/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kevingu1003/django-admin-bootstrapped/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kevingu1003/django-admin-bootstrapped/git/refs{/sha}","trees_url":"https://api.github.com/repos/kevingu1003/django-admin-bootstrapped/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kevingu1003/django-admin-bootstrapped/statuses/{sha}","languages_url":"https://api.github.com/repos/kevingu1003/django-admin-bootstrapped/languages","stargazers_url":"https://api.github.com/repos/kevingu1003/django-admin-bootstrapped/stargazers","contributors_url":"https://api.github.com/repos/kevingu1003/django-admin-bootstrapped/contributors","subscribers_url":"https://api.github.com/repos/kevingu1003/django-admin-bootstrapped/subscribers","subscription_url":"https://api.github.com/repos/kevingu1003/django-admin-bootstrapped/subscription","commits_url":"https://api.github.com/repos/kevingu1003/django-admin-bootstrapped/commits{/sha}","git_commits_url":"https://api.github.com/repos/kevingu1003/django-admin-bootstrapped/git/commits{/sha}","comments_url":"https://api.github.com/repos/kevingu1003/django-admin-bootstrapped/comments{/number}","issue_comment_url":"https://api.github.com/repos/kevingu1003/django-admin-bootstrapped/issues/comments{/number}","contents_url":"https://api.github.com/repos/kevingu1003/django-admin-bootstrapped/contents/{+path}","compare_url":"https://api.github.com/repos/kevingu1003/django-admin-bootstrapped/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kevingu1003/django-admin-bootstrapped/merges","archive_url":"https://api.github.com/repos/kevingu1003/django-admin-bootstrapped/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kevingu1003/django-admin-bootstrapped/downloads","issues_url":"https://api.github.com/repos/kevingu1003/django-admin-bootstrapped/issues{/number}","pulls_url":"https://api.github.com/repos/kevingu1003/django-admin-bootstrapped/pulls{/number}","milestones_url":"https://api.github.com/repos/kevingu1003/django-admin-bootstrapped/milestones{/number}","notifications_url":"https://api.github.com/repos/kevingu1003/django-admin-bootstrapped/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kevingu1003/django-admin-bootstrapped/labels{/name}","releases_url":"https://api.github.com/repos/kevingu1003/django-admin-bootstrapped/releases{/id}","created_at":"2015-11-09T09:24:29Z","updated_at":"2015-11-09T09:24:30Z","pushed_at":"2015-11-09T09:58:19Z","git_url":"git://github.com/kevingu1003/django-admin-bootstrapped.git","ssh_url":"git@github.com:kevingu1003/django-admin-bootstrapped.git","clone_url":"https://github.com/kevingu1003/django-admin-bootstrapped.git","svn_url":"https://github.com/kevingu1003/django-admin-bootstrapped","homepage":"","size":1685,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"django-admin-bootstrapped:master","ref":"master","sha":"45a8d5ee65521a140e94d229844afe80344a4d74","user":{"login":"django-admin-bootstrapped","id":6607971,"avatar_url":"https://avatars.githubusercontent.com/u/6607971?v=3","gravatar_id":"","url":"https://api.github.com/users/django-admin-bootstrapped","html_url":"https://github.com/django-admin-bootstrapped","followers_url":"https://api.github.com/users/django-admin-bootstrapped/followers","following_url":"https://api.github.com/users/django-admin-bootstrapped/following{/other_user}","gists_url":"https://api.github.com/users/django-admin-bootstrapped/gists{/gist_id}","starred_url":"https://api.github.com/users/django-admin-bootstrapped/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/django-admin-bootstrapped/subscriptions","organizations_url":"https://api.github.com/users/django-admin-bootstrapped/orgs","repos_url":"https://api.github.com/users/django-admin-bootstrapped/repos","events_url":"https://api.github.com/users/django-admin-bootstrapped/events{/privacy}","received_events_url":"https://api.github.com/users/django-admin-bootstrapped/received_events","type":"Organization","site_admin":false},"repo":{"id":6347889,"name":"django-admin-bootstrapped","full_name":"django-admin-bootstrapped/django-admin-bootstrapped","owner":{"login":"django-admin-bootstrapped","id":6607971,"avatar_url":"https://avatars.githubusercontent.com/u/6607971?v=3","gravatar_id":"","url":"https://api.github.com/users/django-admin-bootstrapped","html_url":"https://github.com/django-admin-bootstrapped","followers_url":"https://api.github.com/users/django-admin-bootstrapped/followers","following_url":"https://api.github.com/users/django-admin-bootstrapped/following{/other_user}","gists_url":"https://api.github.com/users/django-admin-bootstrapped/gists{/gist_id}","starred_url":"https://api.github.com/users/django-admin-bootstrapped/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/django-admin-bootstrapped/subscriptions","organizations_url":"https://api.github.com/users/django-admin-bootstrapped/orgs","repos_url":"https://api.github.com/users/django-admin-bootstrapped/repos","events_url":"https://api.github.com/users/django-admin-bootstrapped/events{/privacy}","received_events_url":"https://api.github.com/users/django-admin-bootstrapped/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/django-admin-bootstrapped/django-admin-bootstrapped","description":"A Django admin theme using Twitter Bootstrap. It doesn't need any kind of modification on your side, just add it to the installed apps.","fork":false,"url":"https://api.github.com/repos/django-admin-bootstrapped/django-admin-bootstrapped","forks_url":"https://api.github.com/repos/django-admin-bootstrapped/django-admin-bootstrapped/forks","keys_url":"https://api.github.com/repos/django-admin-bootstrapped/django-admin-bootstrapped/keys{/key_id}","collaborators_url":"https://api.github.com/repos/django-admin-bootstrapped/django-admin-bootstrapped/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/django-admin-bootstrapped/django-admin-bootstrapped/teams","hooks_url":"https://api.github.com/repos/django-admin-bootstrapped/django-admin-bootstrapped/hooks","issue_events_url":"https://api.github.com/repos/django-admin-bootstrapped/django-admin-bootstrapped/issues/events{/number}","events_url":"https://api.github.com/repos/django-admin-bootstrapped/django-admin-bootstrapped/events","assignees_url":"https://api.github.com/repos/django-admin-bootstrapped/django-admin-bootstrapped/assignees{/user}","branches_url":"https://api.github.com/repos/django-admin-bootstrapped/django-admin-bootstrapped/branches{/branch}","tags_url":"https://api.github.com/repos/django-admin-bootstrapped/django-admin-bootstrapped/tags","blobs_url":"https://api.github.com/repos/django-admin-bootstrapped/django-admin-bootstrapped/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/django-admin-bootstrapped/django-admin-bootstrapped/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/django-admin-bootstrapped/django-admin-bootstrapped/git/refs{/sha}","trees_url":"https://api.github.com/repos/django-admin-bootstrapped/django-admin-bootstrapped/git/trees{/sha}","statuses_url":"https://api.github.com/repos/django-admin-bootstrapped/django-admin-bootstrapped/statuses/{sha}","languages_url":"https://api.github.com/repos/django-admin-bootstrapped/django-admin-bootstrapped/languages","stargazers_url":"https://api.github.com/repos/django-admin-bootstrapped/django-admin-bootstrapped/stargazers","contributors_url":"https://api.github.com/repos/django-admin-bootstrapped/django-admin-bootstrapped/contributors","subscribers_url":"https://api.github.com/repos/django-admin-bootstrapped/django-admin-bootstrapped/subscribers","subscription_url":"https://api.github.com/repos/django-admin-bootstrapped/django-admin-bootstrapped/subscription","commits_url":"https://api.github.com/repos/django-admin-bootstrapped/django-admin-bootstrapped/commits{/sha}","git_commits_url":"https://api.github.com/repos/django-admin-bootstrapped/django-admin-bootstrapped/git/commits{/sha}","comments_url":"https://api.github.com/repos/django-admin-bootstrapped/django-admin-bootstrapped/comments{/number}","issue_comment_url":"https://api.github.com/repos/django-admin-bootstrapped/django-admin-bootstrapped/issues/comments{/number}","contents_url":"https://api.github.com/repos/django-admin-bootstrapped/django-admin-bootstrapped/contents/{+path}","compare_url":"https://api.github.com/repos/django-admin-bootstrapped/django-admin-bootstrapped/compare/{base}...{head}","merges_url":"https://api.github.com/repos/django-admin-bootstrapped/django-admin-bootstrapped/merges","archive_url":"https://api.github.com/repos/django-admin-bootstrapped/django-admin-bootstrapped/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/django-admin-bootstrapped/django-admin-bootstrapped/downloads","issues_url":"https://api.github.com/repos/django-admin-bootstrapped/django-admin-bootstrapped/issues{/number}","pulls_url":"https://api.github.com/repos/django-admin-bootstrapped/django-admin-bootstrapped/pulls{/number}","milestones_url":"https://api.github.com/repos/django-admin-bootstrapped/django-admin-bootstrapped/milestones{/number}","notifications_url":"https://api.github.com/repos/django-admin-bootstrapped/django-admin-bootstrapped/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/django-admin-bootstrapped/django-admin-bootstrapped/labels{/name}","releases_url":"https://api.github.com/repos/django-admin-bootstrapped/django-admin-bootstrapped/releases{/id}","created_at":"2012-10-23T06:35:27Z","updated_at":"2015-11-09T07:05:11Z","pushed_at":"2015-10-14T11:55:13Z","git_url":"git://github.com/django-admin-bootstrapped/django-admin-bootstrapped.git","ssh_url":"git@github.com:django-admin-bootstrapped/django-admin-bootstrapped.git","clone_url":"https://github.com/django-admin-bootstrapped/django-admin-bootstrapped.git","svn_url":"https://github.com/django-admin-bootstrapped/django-admin-bootstrapped","homepage":"","size":3344,"stargazers_count":1138,"watchers_count":1138,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":277,"mirror_url":null,"open_issues_count":16,"forks":277,"open_issues":16,"watchers":1138,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/django-admin-bootstrapped/django-admin-bootstrapped/pulls/229"},"html":{"href":"https://github.com/django-admin-bootstrapped/django-admin-bootstrapped/pull/229"},"issue":{"href":"https://api.github.com/repos/django-admin-bootstrapped/django-admin-bootstrapped/issues/229"},"comments":{"href":"https://api.github.com/repos/django-admin-bootstrapped/django-admin-bootstrapped/issues/229/comments"},"review_comments":{"href":"https://api.github.com/repos/django-admin-bootstrapped/django-admin-bootstrapped/pulls/229/comments"},"review_comment":{"href":"https://api.github.com/repos/django-admin-bootstrapped/django-admin-bootstrapped/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/django-admin-bootstrapped/django-admin-bootstrapped/pulls/229/commits"},"statuses":{"href":"https://api.github.com/repos/django-admin-bootstrapped/django-admin-bootstrapped/statuses/30e25f7f8fb516438ff5ffdd8f54b0ee79f9c16e"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":6,"deletions":2,"changed_files":2}}