{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/io.js/issues/2205","labels_url":"https://api.github.com/repos/nodejs/io.js/issues/2205/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/io.js/issues/2205/comments","events_url":"https://api.github.com/repos/nodejs/io.js/issues/2205/events","html_url":"https://github.com/nodejs/io.js/pull/2205","id":95915485,"number":2205,"title":"tools: enable semicolon-related rules in eslint","user":{"login":"targos","id":2352663,"avatar_url":"https://avatars.githubusercontent.com/u/2352663?v=3","gravatar_id":"","url":"https://api.github.com/users/targos","html_url":"https://github.com/targos","followers_url":"https://api.github.com/users/targos/followers","following_url":"https://api.github.com/users/targos/following{/other_user}","gists_url":"https://api.github.com/users/targos/gists{/gist_id}","starred_url":"https://api.github.com/users/targos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/targos/subscriptions","organizations_url":"https://api.github.com/users/targos/orgs","repos_url":"https://api.github.com/users/targos/repos","events_url":"https://api.github.com/users/targos/events{/privacy}","received_events_url":"https://api.github.com/users/targos/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/nodejs/io.js/labels/test","name":"test","color":"990099"},{"url":"https://api.github.com/repos/nodejs/io.js/labels/tools","name":"tools","color":"d4c5f9"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":20,"created_at":"2015-07-19T13:24:23Z","updated_at":"2015-07-27T20:36:51Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nodejs/io.js/pulls/2205","html_url":"https://github.com/nodejs/io.js/pull/2205","diff_url":"https://github.com/nodejs/io.js/pull/2205.diff","patch_url":"https://github.com/nodejs/io.js/pull/2205.patch"},"body":"This CL adds two rules:\r\n\r\n### no-extra-semi\r\n\r\n* Removed obvious extra semicolons\r\n* Had to change some loops to add an empty body\r\n\r\n### semi-spacing (removed)\r\n\r\nThis one is up for discussion because the changes I had to make feel wrong to me. \r\nFor instance in `try {fs.rmdirSync(tmp(folder)); } catch (ex) {}` the space isn't really improving readability. Maybe it would better if we added a space as well at the beginning of the `try` block, but I can't find a rule for that.\r\nBecause of that I would prefer to explicitly disable this rule in `.eslintrc` but it is the one that enforces spaces in code like `for(let i = 0; i < x; i++)` so we'd lose that check."},"comment":{"url":"https://api.github.com/repos/nodejs/io.js/issues/comments/125335314","html_url":"https://github.com/nodejs/io.js/pull/2205#issuecomment-125335314","issue_url":"https://api.github.com/repos/nodejs/io.js/issues/2205","id":125335314,"user":{"login":"silverwind","id":115237,"avatar_url":"https://avatars.githubusercontent.com/u/115237?v=3","gravatar_id":"","url":"https://api.github.com/users/silverwind","html_url":"https://github.com/silverwind","followers_url":"https://api.github.com/users/silverwind/followers","following_url":"https://api.github.com/users/silverwind/following{/other_user}","gists_url":"https://api.github.com/users/silverwind/gists{/gist_id}","starred_url":"https://api.github.com/users/silverwind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/silverwind/subscriptions","organizations_url":"https://api.github.com/users/silverwind/orgs","repos_url":"https://api.github.com/users/silverwind/repos","events_url":"https://api.github.com/users/silverwind/events{/privacy}","received_events_url":"https://api.github.com/users/silverwind/received_events","type":"User","site_admin":false},"created_at":"2015-07-27T20:36:51Z","updated_at":"2015-07-27T20:36:51Z","body":"Looking through the 592 indent errors reported by rc-3, it looks like some of these are unrelated and seem bugged (especially cases after an `if` condition). We might be able to reduce the number of changes to like 300-400 lines, but that indentation style looks to be pretty common."}}