{"action":"created","comment":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/comments/36652530","id":36652530,"diff_hunk":"@@ -1532,6 +1533,66 @@ QByteArray fileOnUrl(const QByteArray& filenameString, const QString& url) {\n     return filename;\n }\n \n+string getFileExtension(const string& filename) {\n+    int i = filename.rfind('.', filename.length());\n+    if (i != string::npos) {\n+        return (filename.substr(i + 1, filename.length() - i));\n+    }\n+    return (\"\");\n+}\n+\n+// This function checks whether the alpha channel of the image is used or not.\n+// (If the alpha channel is not present, the function still works fine: hasAlphaChannel() would be redundant)\n+bool checkAlpha(QImage image) {\n+    int width = image.width();\n+    int height = image.height();\n+    bool isUsed = false;\n+\n+    for (int i = 0; i < width && !isUsed; i++) {\n+        for (int j = 0; j < height && !isUsed; j++) {\n+            QRgb color = image.pixel(i, j);\n+            int alpha = qAlpha(color);\n+            if (alpha != 255){","path":"libraries/fbx/src/FBXReader.cpp","position":31,"original_position":31,"commit_id":"7c08946076242df0f277ac63b25fcc9f27ee6a5f","original_commit_id":"7c08946076242df0f277ac63b25fcc9f27ee6a5f","user":{"login":"samcake","id":2230265,"avatar_url":"https://avatars.githubusercontent.com/u/2230265?v=3","gravatar_id":"","url":"https://api.github.com/users/samcake","html_url":"https://github.com/samcake","followers_url":"https://api.github.com/users/samcake/followers","following_url":"https://api.github.com/users/samcake/following{/other_user}","gists_url":"https://api.github.com/users/samcake/gists{/gist_id}","starred_url":"https://api.github.com/users/samcake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samcake/subscriptions","organizations_url":"https://api.github.com/users/samcake/orgs","repos_url":"https://api.github.com/users/samcake/repos","events_url":"https://api.github.com/users/samcake/events{/privacy}","received_events_url":"https://api.github.com/users/samcake/received_events","type":"User","site_admin":false},"body":"Coding standard: 255 is a Magic number, declare a const Var that you will use instead","created_at":"2015-08-10T16:37:29Z","updated_at":"2015-08-10T16:37:29Z","html_url":"https://github.com/highfidelity/hifi/pull/5541#discussion_r36652530","pull_request_url":"https://api.github.com/repos/highfidelity/hifi/pulls/5541","_links":{"self":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/comments/36652530"},"html":{"href":"https://github.com/highfidelity/hifi/pull/5541#discussion_r36652530"},"pull_request":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/5541"}}},"pull_request":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/5541","id":42030967,"html_url":"https://github.com/highfidelity/hifi/pull/5541","diff_url":"https://github.com/highfidelity/hifi/pull/5541.diff","patch_url":"https://github.com/highfidelity/hifi/pull/5541.patch","issue_url":"https://api.github.com/repos/highfidelity/hifi/issues/5541","number":5541,"state":"open","locked":false,"title":"Texture improvements (Opacity maps)","user":{"login":"EdgarPironti","id":13393674,"avatar_url":"https://avatars.githubusercontent.com/u/13393674?v=3","gravatar_id":"","url":"https://api.github.com/users/EdgarPironti","html_url":"https://github.com/EdgarPironti","followers_url":"https://api.github.com/users/EdgarPironti/followers","following_url":"https://api.github.com/users/EdgarPironti/following{/other_user}","gists_url":"https://api.github.com/users/EdgarPironti/gists{/gist_id}","starred_url":"https://api.github.com/users/EdgarPironti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EdgarPironti/subscriptions","organizations_url":"https://api.github.com/users/EdgarPironti/orgs","repos_url":"https://api.github.com/users/EdgarPironti/repos","events_url":"https://api.github.com/users/EdgarPironti/events{/privacy}","received_events_url":"https://api.github.com/users/EdgarPironti/received_events","type":"User","site_admin":false},"body":"FBXReader.cpp - Added functionalities for the combination of diffuse and opacity maps.","created_at":"2015-08-10T15:15:05Z","updated_at":"2015-08-10T16:37:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"58559c2dd509bc78d2b459b1d1d6cfc3c71e694f","assignee":{"login":"samcake","id":2230265,"avatar_url":"https://avatars.githubusercontent.com/u/2230265?v=3","gravatar_id":"","url":"https://api.github.com/users/samcake","html_url":"https://github.com/samcake","followers_url":"https://api.github.com/users/samcake/followers","following_url":"https://api.github.com/users/samcake/following{/other_user}","gists_url":"https://api.github.com/users/samcake/gists{/gist_id}","starred_url":"https://api.github.com/users/samcake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samcake/subscriptions","organizations_url":"https://api.github.com/users/samcake/orgs","repos_url":"https://api.github.com/users/samcake/repos","events_url":"https://api.github.com/users/samcake/events{/privacy}","received_events_url":"https://api.github.com/users/samcake/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/highfidelity/hifi/pulls/5541/commits","review_comments_url":"https://api.github.com/repos/highfidelity/hifi/pulls/5541/comments","review_comment_url":"https://api.github.com/repos/highfidelity/hifi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/highfidelity/hifi/issues/5541/comments","statuses_url":"https://api.github.com/repos/highfidelity/hifi/statuses/7c08946076242df0f277ac63b25fcc9f27ee6a5f","head":{"label":"EdgarPironti:patch-1","ref":"patch-1","sha":"7c08946076242df0f277ac63b25fcc9f27ee6a5f","user":{"login":"EdgarPironti","id":13393674,"avatar_url":"https://avatars.githubusercontent.com/u/13393674?v=3","gravatar_id":"","url":"https://api.github.com/users/EdgarPironti","html_url":"https://github.com/EdgarPironti","followers_url":"https://api.github.com/users/EdgarPironti/followers","following_url":"https://api.github.com/users/EdgarPironti/following{/other_user}","gists_url":"https://api.github.com/users/EdgarPironti/gists{/gist_id}","starred_url":"https://api.github.com/users/EdgarPironti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EdgarPironti/subscriptions","organizations_url":"https://api.github.com/users/EdgarPironti/orgs","repos_url":"https://api.github.com/users/EdgarPironti/repos","events_url":"https://api.github.com/users/EdgarPironti/events{/privacy}","received_events_url":"https://api.github.com/users/EdgarPironti/received_events","type":"User","site_admin":false},"repo":{"id":39301266,"name":"hifi","full_name":"EdgarPironti/hifi","owner":{"login":"EdgarPironti","id":13393674,"avatar_url":"https://avatars.githubusercontent.com/u/13393674?v=3","gravatar_id":"","url":"https://api.github.com/users/EdgarPironti","html_url":"https://github.com/EdgarPironti","followers_url":"https://api.github.com/users/EdgarPironti/followers","following_url":"https://api.github.com/users/EdgarPironti/following{/other_user}","gists_url":"https://api.github.com/users/EdgarPironti/gists{/gist_id}","starred_url":"https://api.github.com/users/EdgarPironti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EdgarPironti/subscriptions","organizations_url":"https://api.github.com/users/EdgarPironti/orgs","repos_url":"https://api.github.com/users/EdgarPironti/repos","events_url":"https://api.github.com/users/EdgarPironti/events{/privacy}","received_events_url":"https://api.github.com/users/EdgarPironti/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/EdgarPironti/hifi","description":"Open source software for shared virtual worlds using HMDs and dynamically assigned devices as servers.  San Francisco based startup, we are hiring: http://highfidelity.com/jobs  Documentation at http://docs.highfidelity.com  Contribute by reporting bugs & doing jobs on http://worklist.net","fork":true,"url":"https://api.github.com/repos/EdgarPironti/hifi","forks_url":"https://api.github.com/repos/EdgarPironti/hifi/forks","keys_url":"https://api.github.com/repos/EdgarPironti/hifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/EdgarPironti/hifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/EdgarPironti/hifi/teams","hooks_url":"https://api.github.com/repos/EdgarPironti/hifi/hooks","issue_events_url":"https://api.github.com/repos/EdgarPironti/hifi/issues/events{/number}","events_url":"https://api.github.com/repos/EdgarPironti/hifi/events","assignees_url":"https://api.github.com/repos/EdgarPironti/hifi/assignees{/user}","branches_url":"https://api.github.com/repos/EdgarPironti/hifi/branches{/branch}","tags_url":"https://api.github.com/repos/EdgarPironti/hifi/tags","blobs_url":"https://api.github.com/repos/EdgarPironti/hifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/EdgarPironti/hifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/EdgarPironti/hifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/EdgarPironti/hifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/EdgarPironti/hifi/statuses/{sha}","languages_url":"https://api.github.com/repos/EdgarPironti/hifi/languages","stargazers_url":"https://api.github.com/repos/EdgarPironti/hifi/stargazers","contributors_url":"https://api.github.com/repos/EdgarPironti/hifi/contributors","subscribers_url":"https://api.github.com/repos/EdgarPironti/hifi/subscribers","subscription_url":"https://api.github.com/repos/EdgarPironti/hifi/subscription","commits_url":"https://api.github.com/repos/EdgarPironti/hifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/EdgarPironti/hifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/EdgarPironti/hifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/EdgarPironti/hifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/EdgarPironti/hifi/contents/{+path}","compare_url":"https://api.github.com/repos/EdgarPironti/hifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/EdgarPironti/hifi/merges","archive_url":"https://api.github.com/repos/EdgarPironti/hifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/EdgarPironti/hifi/downloads","issues_url":"https://api.github.com/repos/EdgarPironti/hifi/issues{/number}","pulls_url":"https://api.github.com/repos/EdgarPironti/hifi/pulls{/number}","milestones_url":"https://api.github.com/repos/EdgarPironti/hifi/milestones{/number}","notifications_url":"https://api.github.com/repos/EdgarPironti/hifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/EdgarPironti/hifi/labels{/name}","releases_url":"https://api.github.com/repos/EdgarPironti/hifi/releases{/id}","created_at":"2015-07-18T14:41:48Z","updated_at":"2015-07-18T14:41:53Z","pushed_at":"2015-08-10T15:14:53Z","git_url":"git://github.com/EdgarPironti/hifi.git","ssh_url":"git@github.com:EdgarPironti/hifi.git","clone_url":"https://github.com/EdgarPironti/hifi.git","svn_url":"https://github.com/EdgarPironti/hifi","homepage":"","size":165940,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"highfidelity:master","ref":"master","sha":"862be9a1f0338cc0e984d54fa10d6643d885a299","user":{"login":"highfidelity","id":1565370,"avatar_url":"https://avatars.githubusercontent.com/u/1565370?v=3","gravatar_id":"","url":"https://api.github.com/users/highfidelity","html_url":"https://github.com/highfidelity","followers_url":"https://api.github.com/users/highfidelity/followers","following_url":"https://api.github.com/users/highfidelity/following{/other_user}","gists_url":"https://api.github.com/users/highfidelity/gists{/gist_id}","starred_url":"https://api.github.com/users/highfidelity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highfidelity/subscriptions","organizations_url":"https://api.github.com/users/highfidelity/orgs","repos_url":"https://api.github.com/users/highfidelity/repos","events_url":"https://api.github.com/users/highfidelity/events{/privacy}","received_events_url":"https://api.github.com/users/highfidelity/received_events","type":"Organization","site_admin":false},"repo":{"id":5372872,"name":"hifi","full_name":"highfidelity/hifi","owner":{"login":"highfidelity","id":1565370,"avatar_url":"https://avatars.githubusercontent.com/u/1565370?v=3","gravatar_id":"","url":"https://api.github.com/users/highfidelity","html_url":"https://github.com/highfidelity","followers_url":"https://api.github.com/users/highfidelity/followers","following_url":"https://api.github.com/users/highfidelity/following{/other_user}","gists_url":"https://api.github.com/users/highfidelity/gists{/gist_id}","starred_url":"https://api.github.com/users/highfidelity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highfidelity/subscriptions","organizations_url":"https://api.github.com/users/highfidelity/orgs","repos_url":"https://api.github.com/users/highfidelity/repos","events_url":"https://api.github.com/users/highfidelity/events{/privacy}","received_events_url":"https://api.github.com/users/highfidelity/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/highfidelity/hifi","description":"Open source software for shared virtual worlds using HMDs and dynamically assigned devices as servers.  San Francisco based startup, we are hiring: http://highfidelity.com/jobs  Documentation at http://docs.highfidelity.com  Contribute by reporting bugs & doing jobs on http://worklist.net","fork":false,"url":"https://api.github.com/repos/highfidelity/hifi","forks_url":"https://api.github.com/repos/highfidelity/hifi/forks","keys_url":"https://api.github.com/repos/highfidelity/hifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/highfidelity/hifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/highfidelity/hifi/teams","hooks_url":"https://api.github.com/repos/highfidelity/hifi/hooks","issue_events_url":"https://api.github.com/repos/highfidelity/hifi/issues/events{/number}","events_url":"https://api.github.com/repos/highfidelity/hifi/events","assignees_url":"https://api.github.com/repos/highfidelity/hifi/assignees{/user}","branches_url":"https://api.github.com/repos/highfidelity/hifi/branches{/branch}","tags_url":"https://api.github.com/repos/highfidelity/hifi/tags","blobs_url":"https://api.github.com/repos/highfidelity/hifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/highfidelity/hifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/highfidelity/hifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/highfidelity/hifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/highfidelity/hifi/statuses/{sha}","languages_url":"https://api.github.com/repos/highfidelity/hifi/languages","stargazers_url":"https://api.github.com/repos/highfidelity/hifi/stargazers","contributors_url":"https://api.github.com/repos/highfidelity/hifi/contributors","subscribers_url":"https://api.github.com/repos/highfidelity/hifi/subscribers","subscription_url":"https://api.github.com/repos/highfidelity/hifi/subscription","commits_url":"https://api.github.com/repos/highfidelity/hifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/highfidelity/hifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/highfidelity/hifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/highfidelity/hifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/highfidelity/hifi/contents/{+path}","compare_url":"https://api.github.com/repos/highfidelity/hifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/highfidelity/hifi/merges","archive_url":"https://api.github.com/repos/highfidelity/hifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/highfidelity/hifi/downloads","issues_url":"https://api.github.com/repos/highfidelity/hifi/issues{/number}","pulls_url":"https://api.github.com/repos/highfidelity/hifi/pulls{/number}","milestones_url":"https://api.github.com/repos/highfidelity/hifi/milestones{/number}","notifications_url":"https://api.github.com/repos/highfidelity/hifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/highfidelity/hifi/labels{/name}","releases_url":"https://api.github.com/repos/highfidelity/hifi/releases{/id}","created_at":"2012-08-10T18:26:22Z","updated_at":"2015-08-06T23:47:26Z","pushed_at":"2015-08-10T15:15:05Z","git_url":"git://github.com/highfidelity/hifi.git","ssh_url":"git@github.com:highfidelity/hifi.git","clone_url":"https://github.com/highfidelity/hifi.git","svn_url":"https://github.com/highfidelity/hifi","homepage":"","size":227295,"stargazers_count":290,"watchers_count":290,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":168,"mirror_url":null,"open_issues_count":57,"forks":168,"open_issues":57,"watchers":290,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/5541"},"html":{"href":"https://github.com/highfidelity/hifi/pull/5541"},"issue":{"href":"https://api.github.com/repos/highfidelity/hifi/issues/5541"},"comments":{"href":"https://api.github.com/repos/highfidelity/hifi/issues/5541/comments"},"review_comments":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/5541/comments"},"review_comment":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/5541/commits"},"statuses":{"href":"https://api.github.com/repos/highfidelity/hifi/statuses/7c08946076242df0f277ac63b25fcc9f27ee6a5f"}}}}