{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/2309","labels_url":"https://api.github.com/repos/nodejs/node/issues/2309/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/2309/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/2309/events","html_url":"https://github.com/nodejs/node/issues/2309","id":99259530,"number":2309,"title":"assert.deepEqual & post-ES5 Data Types e.g. Map, Set, Iterables, etc","user":{"login":"timoxley","id":43438,"avatar_url":"https://avatars.githubusercontent.com/u/43438?v=3","gravatar_id":"","url":"https://api.github.com/users/timoxley","html_url":"https://github.com/timoxley","followers_url":"https://api.github.com/users/timoxley/followers","following_url":"https://api.github.com/users/timoxley/following{/other_user}","gists_url":"https://api.github.com/users/timoxley/gists{/gist_id}","starred_url":"https://api.github.com/users/timoxley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timoxley/subscriptions","organizations_url":"https://api.github.com/users/timoxley/orgs","repos_url":"https://api.github.com/users/timoxley/repos","events_url":"https://api.github.com/users/timoxley/events{/privacy}","received_events_url":"https://api.github.com/users/timoxley/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/nodejs/node/labels/assert","name":"assert","color":"d4c5f9"},{"url":"https://api.github.com/repos/nodejs/node/labels/feature%20request","name":"feature request","color":"0D7BDE"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-08-05T17:40:28Z","updated_at":"2015-09-16T16:19:05Z","closed_at":null,"body":"Currently `assert.deepEquals` is ignorant of any new native data types introduced in ES6.\r\n\r\nFor example, this should probably throw, yet it does not:\r\n\r\n```js\r\nassert.deepEqual(new Set([1, 2]), new Set([1]))\r\n```\r\n\r\nA good method might be to `deepEqual` against `.keys()` and `.values()`.\r\n`deepEqual` should also probably work with generic Iterables too."},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/140792443","html_url":"https://github.com/nodejs/node/issues/2309#issuecomment-140792443","issue_url":"https://api.github.com/repos/nodejs/node/issues/2309","id":140792443,"user":{"login":"timoxley","id":43438,"avatar_url":"https://avatars.githubusercontent.com/u/43438?v=3","gravatar_id":"","url":"https://api.github.com/users/timoxley","html_url":"https://github.com/timoxley","followers_url":"https://api.github.com/users/timoxley/followers","following_url":"https://api.github.com/users/timoxley/following{/other_user}","gists_url":"https://api.github.com/users/timoxley/gists{/gist_id}","starred_url":"https://api.github.com/users/timoxley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timoxley/subscriptions","organizations_url":"https://api.github.com/users/timoxley/orgs","repos_url":"https://api.github.com/users/timoxley/repos","events_url":"https://api.github.com/users/timoxley/events{/privacy}","received_events_url":"https://api.github.com/users/timoxley/received_events","type":"User","site_admin":false},"created_at":"2015-09-16T16:19:05Z","updated_at":"2015-09-16T16:19:05Z","body":"Copying in @domenic's comment regarding this from https://github.com/nodejs/node/pull/2315\r\n\r\n> I don't think we should do this (or anything else in #2309). Assert should remain used only for testing io.js itself, and not try to be a good general assertion library. If io.js tests need this ability enough times that we need to factor it out, we should, but until then, just adding it because it'd be nice isn't a good idea IMO."}}