{"action":"created","comment":{"url":"https://api.github.com/repos/alphagov/pp-puppet/pulls/comments/24360012","id":24360012,"diff_hunk":"@@ -53,6 +53,13 @@\n \n   $graphite_servername = regsubst($servername, '\\.', '_', 'G')\n \n+  if ($serveraliases != undef) {\n+    validate_array($serveraliases)\n+    $vhost_names = $serveraliases\n+  } else {\n+    $vhost_names = [$servername]","path":"modules/performanceplatform/manifests/proxy_vhost.pp","position":8,"original_position":8,"commit_id":"61369684cc5b7bd7b0e8a662df35958277c570c9","original_commit_id":"61369684cc5b7bd7b0e8a662df35958277c570c9","user":{"login":"jabley","id":16205,"avatar_url":"https://avatars.githubusercontent.com/u/16205?v=3","gravatar_id":"","url":"https://api.github.com/users/jabley","html_url":"https://github.com/jabley","followers_url":"https://api.github.com/users/jabley/followers","following_url":"https://api.github.com/users/jabley/following{/other_user}","gists_url":"https://api.github.com/users/jabley/gists{/gist_id}","starred_url":"https://api.github.com/users/jabley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jabley/subscriptions","organizations_url":"https://api.github.com/users/jabley/orgs","repos_url":"https://api.github.com/users/jabley/repos","events_url":"https://api.github.com/users/jabley/events{/privacy}","received_events_url":"https://api.github.com/users/jabley/received_events","type":"User","site_admin":false},"body":"Not sure I follow. If it's defined, it should be an array.\r\n\r\nIf it's not defined, it will explicitly do the default that the nginx module already does (and the existing behaviour prior to this addition). If I add the diff below, this is how it should be used.\r\n\r\n```diff\r\ndiff --git a/hieradata/role-development.yaml b/hieradata/role-development.yaml\r\nindex e56970c..6ed6d96 100644\r\n--- a/hieradata/role-development.yaml\r\n+++ b/hieradata/role-development.yaml\r\n@@ -75,6 +75,9 @@ vhost_proxies:\r\n   # For spotlight\r\n   spotlight:\r\n     servername:    \"%{::spotlight_vhost}\"\r\n+    serveraliases:\r\n+      - \"%{::spotlight_vhost}\"\r\n+      - \"jabley.%{::spotlight_vhost}\"\r\n     ssl:           true\r\n     upstream_port: 3057\r\n   # For backdrop\r\n```","created_at":"2015-02-09T20:01:46Z","updated_at":"2015-02-09T20:01:46Z","html_url":"https://github.com/alphagov/pp-puppet/pull/726#discussion_r24360012","pull_request_url":"https://api.github.com/repos/alphagov/pp-puppet/pulls/726","_links":{"self":{"href":"https://api.github.com/repos/alphagov/pp-puppet/pulls/comments/24360012"},"html":{"href":"https://github.com/alphagov/pp-puppet/pull/726#discussion_r24360012"},"pull_request":{"href":"https://api.github.com/repos/alphagov/pp-puppet/pulls/726"}}},"pull_request":{"url":"https://api.github.com/repos/alphagov/pp-puppet/pulls/726","id":28916694,"html_url":"https://github.com/alphagov/pp-puppet/pull/726","diff_url":"https://github.com/alphagov/pp-puppet/pull/726.diff","patch_url":"https://github.com/alphagov/pp-puppet/pull/726.patch","issue_url":"https://api.github.com/repos/alphagov/pp-puppet/issues/726","number":726,"state":"open","locked":false,"title":"Pass the `$serveraliases` param to nginx","user":{"login":"jabley","id":16205,"avatar_url":"https://avatars.githubusercontent.com/u/16205?v=3","gravatar_id":"","url":"https://api.github.com/users/jabley","html_url":"https://github.com/jabley","followers_url":"https://api.github.com/users/jabley/followers","following_url":"https://api.github.com/users/jabley/following{/other_user}","gists_url":"https://api.github.com/users/jabley/gists{/gist_id}","starred_url":"https://api.github.com/users/jabley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jabley/subscriptions","organizations_url":"https://api.github.com/users/jabley/orgs","repos_url":"https://api.github.com/users/jabley/repos","events_url":"https://api.github.com/users/jabley/events{/privacy}","received_events_url":"https://api.github.com/users/jabley/received_events","type":"User","site_admin":false},"body":"We want to introduce admin-beta and admin pointing at the same thing.\n\nThis change enables that temporary step to happen.\n\nSee https://www.agileplannerapp.com/boards/15088/cards/9316","created_at":"2015-02-09T12:32:38Z","updated_at":"2015-02-09T20:01:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"345f7875efb066b151931540dd2bb7669a28f48b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/pp-puppet/pulls/726/commits","review_comments_url":"https://api.github.com/repos/alphagov/pp-puppet/pulls/726/comments","review_comment_url":"https://api.github.com/repos/alphagov/pp-puppet/pulls/comments/{number}","comments_url":"https://api.github.com/repos/alphagov/pp-puppet/issues/726/comments","statuses_url":"https://api.github.com/repos/alphagov/pp-puppet/statuses/61369684cc5b7bd7b0e8a662df35958277c570c9","head":{"label":"alphagov:feature/use-serveralias","ref":"feature/use-serveralias","sha":"61369684cc5b7bd7b0e8a662df35958277c570c9","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":10238423,"name":"pp-puppet","full_name":"alphagov/pp-puppet","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/pp-puppet","description":"Contains the Puppet code to provision environments for Performance Platform","fork":false,"url":"https://api.github.com/repos/alphagov/pp-puppet","forks_url":"https://api.github.com/repos/alphagov/pp-puppet/forks","keys_url":"https://api.github.com/repos/alphagov/pp-puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/pp-puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/pp-puppet/teams","hooks_url":"https://api.github.com/repos/alphagov/pp-puppet/hooks","issue_events_url":"https://api.github.com/repos/alphagov/pp-puppet/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/pp-puppet/events","assignees_url":"https://api.github.com/repos/alphagov/pp-puppet/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/pp-puppet/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/pp-puppet/tags","blobs_url":"https://api.github.com/repos/alphagov/pp-puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/pp-puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/pp-puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/pp-puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/pp-puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/pp-puppet/languages","stargazers_url":"https://api.github.com/repos/alphagov/pp-puppet/stargazers","contributors_url":"https://api.github.com/repos/alphagov/pp-puppet/contributors","subscribers_url":"https://api.github.com/repos/alphagov/pp-puppet/subscribers","subscription_url":"https://api.github.com/repos/alphagov/pp-puppet/subscription","commits_url":"https://api.github.com/repos/alphagov/pp-puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/pp-puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/pp-puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/pp-puppet/issues/comments/{number}","contents_url":"https://api.github.com/repos/alphagov/pp-puppet/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/pp-puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/pp-puppet/merges","archive_url":"https://api.github.com/repos/alphagov/pp-puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/pp-puppet/downloads","issues_url":"https://api.github.com/repos/alphagov/pp-puppet/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/pp-puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/pp-puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/pp-puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/pp-puppet/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/pp-puppet/releases{/id}","created_at":"2013-05-23T07:37:37Z","updated_at":"2015-02-09T16:29:48Z","pushed_at":"2015-02-09T17:10:34Z","git_url":"git://github.com/alphagov/pp-puppet.git","ssh_url":"git@github.com:alphagov/pp-puppet.git","clone_url":"https://github.com/alphagov/pp-puppet.git","svn_url":"https://github.com/alphagov/pp-puppet","homepage":"","size":77313,"stargazers_count":13,"watchers_count":13,"language":"Puppet","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":6,"forks":2,"open_issues":6,"watchers":13,"default_branch":"master"}},"base":{"label":"alphagov:master","ref":"master","sha":"aa58e179cd4d387265779be0c742bdec85a1dfee","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":10238423,"name":"pp-puppet","full_name":"alphagov/pp-puppet","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/pp-puppet","description":"Contains the Puppet code to provision environments for Performance Platform","fork":false,"url":"https://api.github.com/repos/alphagov/pp-puppet","forks_url":"https://api.github.com/repos/alphagov/pp-puppet/forks","keys_url":"https://api.github.com/repos/alphagov/pp-puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/pp-puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/pp-puppet/teams","hooks_url":"https://api.github.com/repos/alphagov/pp-puppet/hooks","issue_events_url":"https://api.github.com/repos/alphagov/pp-puppet/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/pp-puppet/events","assignees_url":"https://api.github.com/repos/alphagov/pp-puppet/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/pp-puppet/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/pp-puppet/tags","blobs_url":"https://api.github.com/repos/alphagov/pp-puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/pp-puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/pp-puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/pp-puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/pp-puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/pp-puppet/languages","stargazers_url":"https://api.github.com/repos/alphagov/pp-puppet/stargazers","contributors_url":"https://api.github.com/repos/alphagov/pp-puppet/contributors","subscribers_url":"https://api.github.com/repos/alphagov/pp-puppet/subscribers","subscription_url":"https://api.github.com/repos/alphagov/pp-puppet/subscription","commits_url":"https://api.github.com/repos/alphagov/pp-puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/pp-puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/pp-puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/pp-puppet/issues/comments/{number}","contents_url":"https://api.github.com/repos/alphagov/pp-puppet/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/pp-puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/pp-puppet/merges","archive_url":"https://api.github.com/repos/alphagov/pp-puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/pp-puppet/downloads","issues_url":"https://api.github.com/repos/alphagov/pp-puppet/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/pp-puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/pp-puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/pp-puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/pp-puppet/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/pp-puppet/releases{/id}","created_at":"2013-05-23T07:37:37Z","updated_at":"2015-02-09T16:29:48Z","pushed_at":"2015-02-09T17:10:34Z","git_url":"git://github.com/alphagov/pp-puppet.git","ssh_url":"git@github.com:alphagov/pp-puppet.git","clone_url":"https://github.com/alphagov/pp-puppet.git","svn_url":"https://github.com/alphagov/pp-puppet","homepage":"","size":77313,"stargazers_count":13,"watchers_count":13,"language":"Puppet","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":6,"forks":2,"open_issues":6,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/pp-puppet/pulls/726"},"html":{"href":"https://github.com/alphagov/pp-puppet/pull/726"},"issue":{"href":"https://api.github.com/repos/alphagov/pp-puppet/issues/726"},"comments":{"href":"https://api.github.com/repos/alphagov/pp-puppet/issues/726/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/pp-puppet/pulls/726/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/pp-puppet/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/alphagov/pp-puppet/pulls/726/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/pp-puppet/statuses/61369684cc5b7bd7b0e8a662df35958277c570c9"}}}}