{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/comments/28609197","id":28609197,"diff_hunk":"@@ -331,13 +331,14 @@\n   {:post [(valid-jdbc-query? %)]}\n   (let [{:keys [where params]} (compile-term ops query)\n         sql (format \"SELECT %s\n-                       FROM (SELECT c.hash as catalog, e.name as environment, catalog_id, resource,\n+                       FROM (SELECT %s as catalog, e.name as environment, catalog_id, resource,\n                                     type, title, tags, exported, file, line\n                              FROM catalog_resources cr, catalogs c LEFT OUTER JOIN environments e\n                                   on c.environment_id = e.id\n                              WHERE c.id = cr.catalog_id) AS catalog_resources\n                        JOIN catalogs ON catalog_resources.catalog_id = catalogs.id\n                      WHERE %s\"\n+                    (sutils/sql-hash-as-str \"c.hash\")","path":"src/puppetlabs/puppetdb/query.clj","position":21,"original_position":21,"commit_id":"b89f81b987ae406ca788ea9d023fcc9127c5e6e3","original_commit_id":"bcc3cb2685b274de7d8ab4002f2b3df122990a41","user":{"login":"ajroetker","id":3198124,"avatar_url":"https://avatars.githubusercontent.com/u/3198124?v=3","gravatar_id":"","url":"https://api.github.com/users/ajroetker","html_url":"https://github.com/ajroetker","followers_url":"https://api.github.com/users/ajroetker/followers","following_url":"https://api.github.com/users/ajroetker/following{/other_user}","gists_url":"https://api.github.com/users/ajroetker/gists{/gist_id}","starred_url":"https://api.github.com/users/ajroetker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajroetker/subscriptions","organizations_url":"https://api.github.com/users/ajroetker/orgs","repos_url":"https://api.github.com/users/ajroetker/repos","events_url":"https://api.github.com/users/ajroetker/events{/privacy}","received_events_url":"https://api.github.com/users/ajroetker/received_events","type":"User","site_admin":false},"body":"Oh nice catch","created_at":"2015-04-17T16:32:56Z","updated_at":"2015-04-17T16:32:56Z","html_url":"https://github.com/puppetlabs/puppetdb/pull/1357#discussion_r28609197","pull_request_url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/1357","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/comments/28609197"},"html":{"href":"https://github.com/puppetlabs/puppetdb/pull/1357#discussion_r28609197"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/1357"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/1357","id":33505808,"html_url":"https://github.com/puppetlabs/puppetdb/pull/1357","diff_url":"https://github.com/puppetlabs/puppetdb/pull/1357.diff","patch_url":"https://github.com/puppetlabs/puppetdb/pull/1357.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppetdb/issues/1357","number":1357,"state":"open","locked":false,"title":"(PDB-1416) Change the postgres type for hashes and uuids","user":{"login":"ajroetker","id":3198124,"avatar_url":"https://avatars.githubusercontent.com/u/3198124?v=3","gravatar_id":"","url":"https://api.github.com/users/ajroetker","html_url":"https://github.com/ajroetker","followers_url":"https://api.github.com/users/ajroetker/followers","following_url":"https://api.github.com/users/ajroetker/following{/other_user}","gists_url":"https://api.github.com/users/ajroetker/gists{/gist_id}","starred_url":"https://api.github.com/users/ajroetker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajroetker/subscriptions","organizations_url":"https://api.github.com/users/ajroetker/orgs","repos_url":"https://api.github.com/users/ajroetker/repos","events_url":"https://api.github.com/users/ajroetker/events{/privacy}","received_events_url":"https://api.github.com/users/ajroetker/received_events","type":"User","site_admin":false},"body":"UUIDs stored as strings are about 36 bytes, and are 16 bytes stored as\r\nthe native type. Hashes are 40 bytes as characters, but only 20 has a\r\nbytea field.\r\nThis commit changes PuppetDB to store the uuid's as their native type\r\nand hashes as the bytea type (we can easily interact with the bytea type\r\nby using the hexidecimal shorthand, prefixing hashes with '\\x'.\r\nThis commit also enforces that our uuids be non-nil as all supported\r\nversions of puppet enforce this.","created_at":"2015-04-17T00:32:51Z","updated_at":"2015-04-17T16:32:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9d3b23a919db444a71f9660f0ba2efc13750d4a6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/1357/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/1357/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/puppetdb/issues/1357/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppetdb/statuses/b89f81b987ae406ca788ea9d023fcc9127c5e6e3","head":{"label":"ajroetker:ticket/master/pdb-1416/change_db_type_for_hashes_and_uuid","ref":"ticket/master/pdb-1416/change_db_type_for_hashes_and_uuid","sha":"b89f81b987ae406ca788ea9d023fcc9127c5e6e3","user":{"login":"ajroetker","id":3198124,"avatar_url":"https://avatars.githubusercontent.com/u/3198124?v=3","gravatar_id":"","url":"https://api.github.com/users/ajroetker","html_url":"https://github.com/ajroetker","followers_url":"https://api.github.com/users/ajroetker/followers","following_url":"https://api.github.com/users/ajroetker/following{/other_user}","gists_url":"https://api.github.com/users/ajroetker/gists{/gist_id}","starred_url":"https://api.github.com/users/ajroetker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajroetker/subscriptions","organizations_url":"https://api.github.com/users/ajroetker/orgs","repos_url":"https://api.github.com/users/ajroetker/repos","events_url":"https://api.github.com/users/ajroetker/events{/privacy}","received_events_url":"https://api.github.com/users/ajroetker/received_events","type":"User","site_admin":false},"repo":{"id":10415180,"name":"puppetdb","full_name":"ajroetker/puppetdb","owner":{"login":"ajroetker","id":3198124,"avatar_url":"https://avatars.githubusercontent.com/u/3198124?v=3","gravatar_id":"","url":"https://api.github.com/users/ajroetker","html_url":"https://github.com/ajroetker","followers_url":"https://api.github.com/users/ajroetker/followers","following_url":"https://api.github.com/users/ajroetker/following{/other_user}","gists_url":"https://api.github.com/users/ajroetker/gists{/gist_id}","starred_url":"https://api.github.com/users/ajroetker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajroetker/subscriptions","organizations_url":"https://api.github.com/users/ajroetker/orgs","repos_url":"https://api.github.com/users/ajroetker/repos","events_url":"https://api.github.com/users/ajroetker/events{/privacy}","received_events_url":"https://api.github.com/users/ajroetker/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ajroetker/puppetdb","description":"Centralized Puppet Storage","fork":true,"url":"https://api.github.com/repos/ajroetker/puppetdb","forks_url":"https://api.github.com/repos/ajroetker/puppetdb/forks","keys_url":"https://api.github.com/repos/ajroetker/puppetdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ajroetker/puppetdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ajroetker/puppetdb/teams","hooks_url":"https://api.github.com/repos/ajroetker/puppetdb/hooks","issue_events_url":"https://api.github.com/repos/ajroetker/puppetdb/issues/events{/number}","events_url":"https://api.github.com/repos/ajroetker/puppetdb/events","assignees_url":"https://api.github.com/repos/ajroetker/puppetdb/assignees{/user}","branches_url":"https://api.github.com/repos/ajroetker/puppetdb/branches{/branch}","tags_url":"https://api.github.com/repos/ajroetker/puppetdb/tags","blobs_url":"https://api.github.com/repos/ajroetker/puppetdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ajroetker/puppetdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ajroetker/puppetdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/ajroetker/puppetdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ajroetker/puppetdb/statuses/{sha}","languages_url":"https://api.github.com/repos/ajroetker/puppetdb/languages","stargazers_url":"https://api.github.com/repos/ajroetker/puppetdb/stargazers","contributors_url":"https://api.github.com/repos/ajroetker/puppetdb/contributors","subscribers_url":"https://api.github.com/repos/ajroetker/puppetdb/subscribers","subscription_url":"https://api.github.com/repos/ajroetker/puppetdb/subscription","commits_url":"https://api.github.com/repos/ajroetker/puppetdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/ajroetker/puppetdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/ajroetker/puppetdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/ajroetker/puppetdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/ajroetker/puppetdb/contents/{+path}","compare_url":"https://api.github.com/repos/ajroetker/puppetdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ajroetker/puppetdb/merges","archive_url":"https://api.github.com/repos/ajroetker/puppetdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ajroetker/puppetdb/downloads","issues_url":"https://api.github.com/repos/ajroetker/puppetdb/issues{/number}","pulls_url":"https://api.github.com/repos/ajroetker/puppetdb/pulls{/number}","milestones_url":"https://api.github.com/repos/ajroetker/puppetdb/milestones{/number}","notifications_url":"https://api.github.com/repos/ajroetker/puppetdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ajroetker/puppetdb/labels{/name}","releases_url":"https://api.github.com/repos/ajroetker/puppetdb/releases{/id}","created_at":"2013-05-31T23:59:00Z","updated_at":"2015-02-25T18:35:24Z","pushed_at":"2015-04-17T16:20:09Z","git_url":"git://github.com/ajroetker/puppetdb.git","ssh_url":"git@github.com:ajroetker/puppetdb.git","clone_url":"https://github.com/ajroetker/puppetdb.git","svn_url":"https://github.com/ajroetker/puppetdb","homepage":"http://docs.puppetlabs.com/puppetdb","size":12697,"stargazers_count":0,"watchers_count":0,"language":"Clojure","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"fe6358dd55718d1589baf7550b6c0afbcf3d3330","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":2193032,"name":"puppetdb","full_name":"puppetlabs/puppetdb","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/puppetdb","description":"Centralized Puppet Storage","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppetdb","forks_url":"https://api.github.com/repos/puppetlabs/puppetdb/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppetdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppetdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppetdb/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppetdb/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppetdb/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppetdb/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppetdb/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppetdb/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppetdb/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppetdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppetdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppetdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppetdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppetdb/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppetdb/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppetdb/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppetdb/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppetdb/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppetdb/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppetdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppetdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppetdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppetdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/puppetdb/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppetdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppetdb/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppetdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppetdb/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppetdb/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppetdb/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppetdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppetdb/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppetdb/releases{/id}","created_at":"2011-08-11T18:54:46Z","updated_at":"2015-04-17T11:35:38Z","pushed_at":"2015-04-17T16:20:10Z","git_url":"git://github.com/puppetlabs/puppetdb.git","ssh_url":"git@github.com:puppetlabs/puppetdb.git","clone_url":"https://github.com/puppetlabs/puppetdb.git","svn_url":"https://github.com/puppetlabs/puppetdb","homepage":"http://docs.puppetlabs.com/puppetdb","size":20127,"stargazers_count":154,"watchers_count":154,"language":"Clojure","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":128,"mirror_url":null,"open_issues_count":6,"forks":128,"open_issues":6,"watchers":154,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/1357"},"html":{"href":"https://github.com/puppetlabs/puppetdb/pull/1357"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/issues/1357"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/issues/1357/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/1357/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/1357/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/statuses/b89f81b987ae406ca788ea9d023fcc9127c5e6e3"}}}}