{"action":"created","issue":{"url":"https://api.github.com/repos/mozilla/fxa-auth-db-server/issues/116","labels_url":"https://api.github.com/repos/mozilla/fxa-auth-db-server/issues/116/labels{/name}","comments_url":"https://api.github.com/repos/mozilla/fxa-auth-db-server/issues/116/comments","events_url":"https://api.github.com/repos/mozilla/fxa-auth-db-server/issues/116/events","html_url":"https://github.com/mozilla/fxa-auth-db-server/pull/116","id":55689485,"number":116,"title":"Reverse with tests","user":{"login":"chilts","id":3048,"avatar_url":"https://avatars.githubusercontent.com/u/3048?v=3","gravatar_id":"","url":"https://api.github.com/users/chilts","html_url":"https://github.com/chilts","followers_url":"https://api.github.com/users/chilts/followers","following_url":"https://api.github.com/users/chilts/following{/other_user}","gists_url":"https://api.github.com/users/chilts/gists{/gist_id}","starred_url":"https://api.github.com/users/chilts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chilts/subscriptions","organizations_url":"https://api.github.com/users/chilts/orgs","repos_url":"https://api.github.com/users/chilts/repos","events_url":"https://api.github.com/users/chilts/events{/privacy}","received_events_url":"https://api.github.com/users/chilts/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/mozilla/fxa-auth-db-server/labels/waffle:needs%20review","name":"waffle:needs review","color":"ededed"}],"state":"open","locked":false,"assignee":{"login":"rfk","id":34695,"avatar_url":"https://avatars.githubusercontent.com/u/34695?v=3","gravatar_id":"","url":"https://api.github.com/users/rfk","html_url":"https://github.com/rfk","followers_url":"https://api.github.com/users/rfk/followers","following_url":"https://api.github.com/users/rfk/following{/other_user}","gists_url":"https://api.github.com/users/rfk/gists{/gist_id}","starred_url":"https://api.github.com/users/rfk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rfk/subscriptions","organizations_url":"https://api.github.com/users/rfk/orgs","repos_url":"https://api.github.com/users/rfk/repos","events_url":"https://api.github.com/users/rfk/events{/privacy}","received_events_url":"https://api.github.com/users/rfk/received_events","type":"User","site_admin":false},"milestone":null,"comments":1,"created_at":"2015-01-27T23:12:02Z","updated_at":"2015-01-27T23:16:55Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mozilla/fxa-auth-db-server/pulls/116","html_url":"https://github.com/mozilla/fxa-auth-db-server/pull/116","diff_url":"https://github.com/mozilla/fxa-auth-db-server/pull/116.diff","patch_url":"https://github.com/mozilla/fxa-auth-db-server/pull/116.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/mozilla/fxa-auth-db-server/issues/comments/71749371","html_url":"https://github.com/mozilla/fxa-auth-db-server/pull/116#issuecomment-71749371","issue_url":"https://api.github.com/repos/mozilla/fxa-auth-db-server/issues/116","id":71749371,"user":{"login":"chilts","id":3048,"avatar_url":"https://avatars.githubusercontent.com/u/3048?v=3","gravatar_id":"","url":"https://api.github.com/users/chilts","html_url":"https://github.com/chilts","followers_url":"https://api.github.com/users/chilts/followers","following_url":"https://api.github.com/users/chilts/following{/other_user}","gists_url":"https://api.github.com/users/chilts/gists{/gist_id}","starred_url":"https://api.github.com/users/chilts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chilts/subscriptions","organizations_url":"https://api.github.com/users/chilts/orgs","repos_url":"https://api.github.com/users/chilts/repos","events_url":"https://api.github.com/users/chilts/events{/privacy}","received_events_url":"https://api.github.com/users/chilts/received_events","type":"User","site_admin":false},"created_at":"2015-01-27T23:16:54Z","updated_at":"2015-01-27T23:16:54Z","body":"This PR is linked to these:\r\n\r\n* https://github.com/mozilla/fxa-auth-db-mem/pull/12\r\n* https://github.com/mozilla/fxa-auth-db-mysql/pull/4\r\n\r\nAm going to comment on this PR here, but it related to all three PRs. Some things I tried to make sure:\r\n\r\n1. both mysql/mem configs are consistent\r\n2. server startup was pretty similar in both storage repos\r\n3. all tests from the auth-db-server are run in both repos (specifically `backend/db_tests.js` and `backend/remote.js`)\r\n4. all infrastructure stuff is there e.g. Travis/Grunt. I may need more `README`.\r\n5. the dependencies are a bit weird when doing `npm install`, since the `devDepencies` are installed for the top-level project (mem/mysql) but not for it's dependencies, ie. fxa-auth-db-server, hence `uuid` has been added to both storage projects. Perhaps it is better that this is added to the `dependencies` in the fxa-auth-db-server instead of what I did here.\r\n\r\nThanks @rfk.\r\n"}}