{"action":"opened","number":145,"pull_request":{"url":"https://api.github.com/repos/WickyNilliams/headroom.js/pulls/145","id":27903170,"html_url":"https://github.com/WickyNilliams/headroom.js/pull/145","diff_url":"https://github.com/WickyNilliams/headroom.js/pull/145.diff","patch_url":"https://github.com/WickyNilliams/headroom.js/pull/145.patch","issue_url":"https://api.github.com/repos/WickyNilliams/headroom.js/issues/145","number":145,"state":"open","locked":false,"title":"fix isOutOfBounds when using a custom scroller","user":{"login":"TravisTX","id":934490,"avatar_url":"https://avatars.githubusercontent.com/u/934490?v=3","gravatar_id":"","url":"https://api.github.com/users/TravisTX","html_url":"https://github.com/TravisTX","followers_url":"https://api.github.com/users/TravisTX/followers","following_url":"https://api.github.com/users/TravisTX/following{/other_user}","gists_url":"https://api.github.com/users/TravisTX/gists{/gist_id}","starred_url":"https://api.github.com/users/TravisTX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TravisTX/subscriptions","organizations_url":"https://api.github.com/users/TravisTX/orgs","repos_url":"https://api.github.com/users/TravisTX/repos","events_url":"https://api.github.com/users/TravisTX/events{/privacy}","received_events_url":"https://api.github.com/users/TravisTX/received_events","type":"User","site_admin":false},"body":"The isOutOfBounds function was taking viewport height into consideration, even when using a custom scroller DOM element.  When using a custom scroller, viewport height should be irrelevant, and instead the size of the scroller should be considered.  To avoid confusion, I created a new property called \"physical height.\" which represents this.\r\n\r\nCloses #143 and #144 ","created_at":"2015-01-23T06:05:38Z","updated_at":"2015-01-23T06:05:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/WickyNilliams/headroom.js/pulls/145/commits","review_comments_url":"https://api.github.com/repos/WickyNilliams/headroom.js/pulls/145/comments","review_comment_url":"https://api.github.com/repos/WickyNilliams/headroom.js/pulls/comments/{number}","comments_url":"https://api.github.com/repos/WickyNilliams/headroom.js/issues/145/comments","statuses_url":"https://api.github.com/repos/WickyNilliams/headroom.js/statuses/41d8cf6cd2227a5c748acdf3247951ef5c8565be","head":{"label":"TravisTX:fix-isOutOfBounds-for-scroller","ref":"fix-isOutOfBounds-for-scroller","sha":"41d8cf6cd2227a5c748acdf3247951ef5c8565be","user":{"login":"TravisTX","id":934490,"avatar_url":"https://avatars.githubusercontent.com/u/934490?v=3","gravatar_id":"","url":"https://api.github.com/users/TravisTX","html_url":"https://github.com/TravisTX","followers_url":"https://api.github.com/users/TravisTX/followers","following_url":"https://api.github.com/users/TravisTX/following{/other_user}","gists_url":"https://api.github.com/users/TravisTX/gists{/gist_id}","starred_url":"https://api.github.com/users/TravisTX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TravisTX/subscriptions","organizations_url":"https://api.github.com/users/TravisTX/orgs","repos_url":"https://api.github.com/users/TravisTX/repos","events_url":"https://api.github.com/users/TravisTX/events{/privacy}","received_events_url":"https://api.github.com/users/TravisTX/received_events","type":"User","site_admin":false},"repo":{"id":29715138,"name":"headroom.js","full_name":"TravisTX/headroom.js","owner":{"login":"TravisTX","id":934490,"avatar_url":"https://avatars.githubusercontent.com/u/934490?v=3","gravatar_id":"","url":"https://api.github.com/users/TravisTX","html_url":"https://github.com/TravisTX","followers_url":"https://api.github.com/users/TravisTX/followers","following_url":"https://api.github.com/users/TravisTX/following{/other_user}","gists_url":"https://api.github.com/users/TravisTX/gists{/gist_id}","starred_url":"https://api.github.com/users/TravisTX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TravisTX/subscriptions","organizations_url":"https://api.github.com/users/TravisTX/orgs","repos_url":"https://api.github.com/users/TravisTX/repos","events_url":"https://api.github.com/users/TravisTX/events{/privacy}","received_events_url":"https://api.github.com/users/TravisTX/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TravisTX/headroom.js","description":"Give your pages some headroom. Hide your header until you need it","fork":true,"url":"https://api.github.com/repos/TravisTX/headroom.js","forks_url":"https://api.github.com/repos/TravisTX/headroom.js/forks","keys_url":"https://api.github.com/repos/TravisTX/headroom.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TravisTX/headroom.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TravisTX/headroom.js/teams","hooks_url":"https://api.github.com/repos/TravisTX/headroom.js/hooks","issue_events_url":"https://api.github.com/repos/TravisTX/headroom.js/issues/events{/number}","events_url":"https://api.github.com/repos/TravisTX/headroom.js/events","assignees_url":"https://api.github.com/repos/TravisTX/headroom.js/assignees{/user}","branches_url":"https://api.github.com/repos/TravisTX/headroom.js/branches{/branch}","tags_url":"https://api.github.com/repos/TravisTX/headroom.js/tags","blobs_url":"https://api.github.com/repos/TravisTX/headroom.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TravisTX/headroom.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TravisTX/headroom.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/TravisTX/headroom.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TravisTX/headroom.js/statuses/{sha}","languages_url":"https://api.github.com/repos/TravisTX/headroom.js/languages","stargazers_url":"https://api.github.com/repos/TravisTX/headroom.js/stargazers","contributors_url":"https://api.github.com/repos/TravisTX/headroom.js/contributors","subscribers_url":"https://api.github.com/repos/TravisTX/headroom.js/subscribers","subscription_url":"https://api.github.com/repos/TravisTX/headroom.js/subscription","commits_url":"https://api.github.com/repos/TravisTX/headroom.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/TravisTX/headroom.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/TravisTX/headroom.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/TravisTX/headroom.js/issues/comments/{number}","contents_url":"https://api.github.com/repos/TravisTX/headroom.js/contents/{+path}","compare_url":"https://api.github.com/repos/TravisTX/headroom.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TravisTX/headroom.js/merges","archive_url":"https://api.github.com/repos/TravisTX/headroom.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TravisTX/headroom.js/downloads","issues_url":"https://api.github.com/repos/TravisTX/headroom.js/issues{/number}","pulls_url":"https://api.github.com/repos/TravisTX/headroom.js/pulls{/number}","milestones_url":"https://api.github.com/repos/TravisTX/headroom.js/milestones{/number}","notifications_url":"https://api.github.com/repos/TravisTX/headroom.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TravisTX/headroom.js/labels{/name}","releases_url":"https://api.github.com/repos/TravisTX/headroom.js/releases{/id}","created_at":"2015-01-23T03:41:26Z","updated_at":"2015-01-23T03:41:27Z","pushed_at":"2015-01-23T06:03:22Z","git_url":"git://github.com/TravisTX/headroom.js.git","ssh_url":"git@github.com:TravisTX/headroom.js.git","clone_url":"https://github.com/TravisTX/headroom.js.git","svn_url":"https://github.com/TravisTX/headroom.js","homepage":"http://wicky.nillia.ms/headroom.js/","size":1139,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"WickyNilliams:master","ref":"master","sha":"dea49f5b9dbccdc6f00952e28a86c02b360f5a7e","user":{"login":"WickyNilliams","id":1091390,"avatar_url":"https://avatars.githubusercontent.com/u/1091390?v=3","gravatar_id":"","url":"https://api.github.com/users/WickyNilliams","html_url":"https://github.com/WickyNilliams","followers_url":"https://api.github.com/users/WickyNilliams/followers","following_url":"https://api.github.com/users/WickyNilliams/following{/other_user}","gists_url":"https://api.github.com/users/WickyNilliams/gists{/gist_id}","starred_url":"https://api.github.com/users/WickyNilliams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WickyNilliams/subscriptions","organizations_url":"https://api.github.com/users/WickyNilliams/orgs","repos_url":"https://api.github.com/users/WickyNilliams/repos","events_url":"https://api.github.com/users/WickyNilliams/events{/privacy}","received_events_url":"https://api.github.com/users/WickyNilliams/received_events","type":"User","site_admin":false},"repo":{"id":11960085,"name":"headroom.js","full_name":"WickyNilliams/headroom.js","owner":{"login":"WickyNilliams","id":1091390,"avatar_url":"https://avatars.githubusercontent.com/u/1091390?v=3","gravatar_id":"","url":"https://api.github.com/users/WickyNilliams","html_url":"https://github.com/WickyNilliams","followers_url":"https://api.github.com/users/WickyNilliams/followers","following_url":"https://api.github.com/users/WickyNilliams/following{/other_user}","gists_url":"https://api.github.com/users/WickyNilliams/gists{/gist_id}","starred_url":"https://api.github.com/users/WickyNilliams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WickyNilliams/subscriptions","organizations_url":"https://api.github.com/users/WickyNilliams/orgs","repos_url":"https://api.github.com/users/WickyNilliams/repos","events_url":"https://api.github.com/users/WickyNilliams/events{/privacy}","received_events_url":"https://api.github.com/users/WickyNilliams/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/WickyNilliams/headroom.js","description":"Give your pages some headroom. Hide your header until you need it","fork":false,"url":"https://api.github.com/repos/WickyNilliams/headroom.js","forks_url":"https://api.github.com/repos/WickyNilliams/headroom.js/forks","keys_url":"https://api.github.com/repos/WickyNilliams/headroom.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WickyNilliams/headroom.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WickyNilliams/headroom.js/teams","hooks_url":"https://api.github.com/repos/WickyNilliams/headroom.js/hooks","issue_events_url":"https://api.github.com/repos/WickyNilliams/headroom.js/issues/events{/number}","events_url":"https://api.github.com/repos/WickyNilliams/headroom.js/events","assignees_url":"https://api.github.com/repos/WickyNilliams/headroom.js/assignees{/user}","branches_url":"https://api.github.com/repos/WickyNilliams/headroom.js/branches{/branch}","tags_url":"https://api.github.com/repos/WickyNilliams/headroom.js/tags","blobs_url":"https://api.github.com/repos/WickyNilliams/headroom.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WickyNilliams/headroom.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WickyNilliams/headroom.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/WickyNilliams/headroom.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WickyNilliams/headroom.js/statuses/{sha}","languages_url":"https://api.github.com/repos/WickyNilliams/headroom.js/languages","stargazers_url":"https://api.github.com/repos/WickyNilliams/headroom.js/stargazers","contributors_url":"https://api.github.com/repos/WickyNilliams/headroom.js/contributors","subscribers_url":"https://api.github.com/repos/WickyNilliams/headroom.js/subscribers","subscription_url":"https://api.github.com/repos/WickyNilliams/headroom.js/subscription","commits_url":"https://api.github.com/repos/WickyNilliams/headroom.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/WickyNilliams/headroom.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/WickyNilliams/headroom.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/WickyNilliams/headroom.js/issues/comments/{number}","contents_url":"https://api.github.com/repos/WickyNilliams/headroom.js/contents/{+path}","compare_url":"https://api.github.com/repos/WickyNilliams/headroom.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WickyNilliams/headroom.js/merges","archive_url":"https://api.github.com/repos/WickyNilliams/headroom.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WickyNilliams/headroom.js/downloads","issues_url":"https://api.github.com/repos/WickyNilliams/headroom.js/issues{/number}","pulls_url":"https://api.github.com/repos/WickyNilliams/headroom.js/pulls{/number}","milestones_url":"https://api.github.com/repos/WickyNilliams/headroom.js/milestones{/number}","notifications_url":"https://api.github.com/repos/WickyNilliams/headroom.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WickyNilliams/headroom.js/labels{/name}","releases_url":"https://api.github.com/repos/WickyNilliams/headroom.js/releases{/id}","created_at":"2013-08-07T20:42:58Z","updated_at":"2015-01-22T23:08:08Z","pushed_at":"2015-01-12T19:35:30Z","git_url":"git://github.com/WickyNilliams/headroom.js.git","ssh_url":"git@github.com:WickyNilliams/headroom.js.git","clone_url":"https://github.com/WickyNilliams/headroom.js.git","svn_url":"https://github.com/WickyNilliams/headroom.js","homepage":"http://wicky.nillia.ms/headroom.js/","size":1139,"stargazers_count":6718,"watchers_count":6718,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":437,"mirror_url":null,"open_issues_count":19,"forks":437,"open_issues":19,"watchers":6718,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/WickyNilliams/headroom.js/pulls/145"},"html":{"href":"https://github.com/WickyNilliams/headroom.js/pull/145"},"issue":{"href":"https://api.github.com/repos/WickyNilliams/headroom.js/issues/145"},"comments":{"href":"https://api.github.com/repos/WickyNilliams/headroom.js/issues/145/comments"},"review_comments":{"href":"https://api.github.com/repos/WickyNilliams/headroom.js/pulls/145/comments"},"review_comment":{"href":"https://api.github.com/repos/WickyNilliams/headroom.js/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/WickyNilliams/headroom.js/pulls/145/commits"},"statuses":{"href":"https://api.github.com/repos/WickyNilliams/headroom.js/statuses/41d8cf6cd2227a5c748acdf3247951ef5c8565be"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":114,"deletions":14,"changed_files":8}}