{"action":"created","comment":{"url":"https://api.github.com/repos/ufz/ogs/pulls/comments/47762574","id":47762574,"diff_hunk":"@@ -150,19 +178,60 @@ class AABB\n \t\tstd::numeric_limits<double>::lowest(),\n \t\tstd::numeric_limits<double>::lowest()}}};\n private:\n+\t/// Enlarge the bounding box the smallest possible amount (modifying the\n+\t/// unit in the last place). Only the coordinates of the maximum point are\n+\t/// changed such that the half-open property will be preserved.\n+\tvoid enlarge(std::bitset<3> to_update = 7)\n+\t{\n+\t\tfor (std::size_t k=0; k<3; ++k) {\n+\t\t\tif (to_update[k]) {\n+\t\t\t\t_max_pnt[k] = std::nextafter(_max_pnt[k],\n+\t\t\t\t\tstd::numeric_limits<double>::max());\n+\t\t\t}\n+\t\t}\n+\t}\n+\n+\ttemplate <typename PNT_TYPE>\n \tvoid init(PNT_TYPE const & pnt)\n \t{\n \t\t_min_pnt[0] = _max_pnt[0] = pnt[0];\n \t\t_min_pnt[1] = _max_pnt[1] = pnt[1];\n \t\t_min_pnt[2] = _max_pnt[2] = pnt[2];\n \t}\n-\tvoid init(PNT_TYPE const * pnt)\n+\n+\ttemplate <typename PNT_TYPE>\n+\tvoid init(PNT_TYPE * const & pnt)\n \t{\n \t\tinit(*pnt);\n \t}\n+\n+\t/// Private method that is used internally to update the min and max point\n+\t/// of the bounding box using point \\f$p\\f$ without enlarging the bounding\n+\t/// box.\n+\t/// @param p point that will possibly change the bounding box points\n+\ttemplate <typename PNT_TYPE>\n+\tvoid  updateWithoutEnlarge(PNT_TYPE const & p)\n+\t{\n+\t\tfor (std::size_t k(0); k<3; k++) {\n+\t\t\tif (p[k] < _min_pnt[k]) {\n+\t\t\t\t_min_pnt[k] = p[k];\n+\t\t\t}\n+\t\t\tif (p[k] >= _max_pnt[k]) {\n+\t\t\t\t_max_pnt[k] = p[k];\n+\t\t\t}\n+\t\t}\n+\t}\n+\n+\ttemplate <typename PNT_TYPE>\n+\tvoid updateWithoutEnlarge(PNT_TYPE * const & pnt)","path":"GeoLib/AABB.h","position":197,"original_position":197,"commit_id":"222f4c68032340ea10212e494c663152b81ed208","original_commit_id":"222f4c68032340ea10212e494c663152b81ed208","user":{"login":"chleh","id":10530151,"avatar_url":"https://avatars.githubusercontent.com/u/10530151?v=3","gravatar_id":"","url":"https://api.github.com/users/chleh","html_url":"https://github.com/chleh","followers_url":"https://api.github.com/users/chleh/followers","following_url":"https://api.github.com/users/chleh/following{/other_user}","gists_url":"https://api.github.com/users/chleh/gists{/gist_id}","starred_url":"https://api.github.com/users/chleh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chleh/subscriptions","organizations_url":"https://api.github.com/users/chleh/orgs","repos_url":"https://api.github.com/users/chleh/repos","events_url":"https://api.github.com/users/chleh/events{/privacy}","received_events_url":"https://api.github.com/users/chleh/received_events","type":"User","site_admin":false},"body":"Is the pointer version needed?","created_at":"2015-12-16T11:02:02Z","updated_at":"2015-12-16T11:02:02Z","html_url":"https://github.com/ufz/ogs/pull/929#discussion_r47762574","pull_request_url":"https://api.github.com/repos/ufz/ogs/pulls/929","_links":{"self":{"href":"https://api.github.com/repos/ufz/ogs/pulls/comments/47762574"},"html":{"href":"https://github.com/ufz/ogs/pull/929#discussion_r47762574"},"pull_request":{"href":"https://api.github.com/repos/ufz/ogs/pulls/929"}}},"pull_request":{"url":"https://api.github.com/repos/ufz/ogs/pulls/929","id":53805695,"html_url":"https://github.com/ufz/ogs/pull/929","diff_url":"https://github.com/ufz/ogs/pull/929.diff","patch_url":"https://github.com/ufz/ogs/pull/929.patch","issue_url":"https://api.github.com/repos/ufz/ogs/issues/929","number":929,"state":"open","locked":false,"title":"Transformed class template AABB -> class AABB","user":{"login":"TomFischer","id":800065,"avatar_url":"https://avatars.githubusercontent.com/u/800065?v=3","gravatar_id":"","url":"https://api.github.com/users/TomFischer","html_url":"https://github.com/TomFischer","followers_url":"https://api.github.com/users/TomFischer/followers","following_url":"https://api.github.com/users/TomFischer/following{/other_user}","gists_url":"https://api.github.com/users/TomFischer/gists{/gist_id}","starred_url":"https://api.github.com/users/TomFischer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomFischer/subscriptions","organizations_url":"https://api.github.com/users/TomFischer/orgs","repos_url":"https://api.github.com/users/TomFischer/repos","events_url":"https://api.github.com/users/TomFischer/events{/privacy}","received_events_url":"https://api.github.com/users/TomFischer/received_events","type":"User","site_admin":false},"body":"Removing the template stuff makes \r\n- AABB more flexible and\r\n- easier to use.\r\n\r\nThis PR is based on the PR #911 and must not be merged before PR #911.","created_at":"2015-12-16T06:58:31Z","updated_at":"2015-12-16T11:02:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b379dd49764b964360ef30cade129cd0418d7fdd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ufz/ogs/pulls/929/commits","review_comments_url":"https://api.github.com/repos/ufz/ogs/pulls/929/comments","review_comment_url":"https://api.github.com/repos/ufz/ogs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ufz/ogs/issues/929/comments","statuses_url":"https://api.github.com/repos/ufz/ogs/statuses/222f4c68032340ea10212e494c663152b81ed208","head":{"label":"TomFischer:ReworkAABBII","ref":"ReworkAABBII","sha":"222f4c68032340ea10212e494c663152b81ed208","user":{"login":"TomFischer","id":800065,"avatar_url":"https://avatars.githubusercontent.com/u/800065?v=3","gravatar_id":"","url":"https://api.github.com/users/TomFischer","html_url":"https://github.com/TomFischer","followers_url":"https://api.github.com/users/TomFischer/followers","following_url":"https://api.github.com/users/TomFischer/following{/other_user}","gists_url":"https://api.github.com/users/TomFischer/gists{/gist_id}","starred_url":"https://api.github.com/users/TomFischer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomFischer/subscriptions","organizations_url":"https://api.github.com/users/TomFischer/orgs","repos_url":"https://api.github.com/users/TomFischer/repos","events_url":"https://api.github.com/users/TomFischer/events{/privacy}","received_events_url":"https://api.github.com/users/TomFischer/received_events","type":"User","site_admin":false},"repo":{"id":6882427,"name":"ogs","full_name":"TomFischer/ogs","owner":{"login":"TomFischer","id":800065,"avatar_url":"https://avatars.githubusercontent.com/u/800065?v=3","gravatar_id":"","url":"https://api.github.com/users/TomFischer","html_url":"https://github.com/TomFischer","followers_url":"https://api.github.com/users/TomFischer/followers","following_url":"https://api.github.com/users/TomFischer/following{/other_user}","gists_url":"https://api.github.com/users/TomFischer/gists{/gist_id}","starred_url":"https://api.github.com/users/TomFischer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomFischer/subscriptions","organizations_url":"https://api.github.com/users/TomFischer/orgs","repos_url":"https://api.github.com/users/TomFischer/repos","events_url":"https://api.github.com/users/TomFischer/events{/privacy}","received_events_url":"https://api.github.com/users/TomFischer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TomFischer/ogs","description":"OGS source code","fork":true,"url":"https://api.github.com/repos/TomFischer/ogs","forks_url":"https://api.github.com/repos/TomFischer/ogs/forks","keys_url":"https://api.github.com/repos/TomFischer/ogs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TomFischer/ogs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TomFischer/ogs/teams","hooks_url":"https://api.github.com/repos/TomFischer/ogs/hooks","issue_events_url":"https://api.github.com/repos/TomFischer/ogs/issues/events{/number}","events_url":"https://api.github.com/repos/TomFischer/ogs/events","assignees_url":"https://api.github.com/repos/TomFischer/ogs/assignees{/user}","branches_url":"https://api.github.com/repos/TomFischer/ogs/branches{/branch}","tags_url":"https://api.github.com/repos/TomFischer/ogs/tags","blobs_url":"https://api.github.com/repos/TomFischer/ogs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TomFischer/ogs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TomFischer/ogs/git/refs{/sha}","trees_url":"https://api.github.com/repos/TomFischer/ogs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TomFischer/ogs/statuses/{sha}","languages_url":"https://api.github.com/repos/TomFischer/ogs/languages","stargazers_url":"https://api.github.com/repos/TomFischer/ogs/stargazers","contributors_url":"https://api.github.com/repos/TomFischer/ogs/contributors","subscribers_url":"https://api.github.com/repos/TomFischer/ogs/subscribers","subscription_url":"https://api.github.com/repos/TomFischer/ogs/subscription","commits_url":"https://api.github.com/repos/TomFischer/ogs/commits{/sha}","git_commits_url":"https://api.github.com/repos/TomFischer/ogs/git/commits{/sha}","comments_url":"https://api.github.com/repos/TomFischer/ogs/comments{/number}","issue_comment_url":"https://api.github.com/repos/TomFischer/ogs/issues/comments{/number}","contents_url":"https://api.github.com/repos/TomFischer/ogs/contents/{+path}","compare_url":"https://api.github.com/repos/TomFischer/ogs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TomFischer/ogs/merges","archive_url":"https://api.github.com/repos/TomFischer/ogs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TomFischer/ogs/downloads","issues_url":"https://api.github.com/repos/TomFischer/ogs/issues{/number}","pulls_url":"https://api.github.com/repos/TomFischer/ogs/pulls{/number}","milestones_url":"https://api.github.com/repos/TomFischer/ogs/milestones{/number}","notifications_url":"https://api.github.com/repos/TomFischer/ogs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TomFischer/ogs/labels{/name}","releases_url":"https://api.github.com/repos/TomFischer/ogs/releases{/id}","created_at":"2012-11-27T11:49:36Z","updated_at":"2015-05-08T04:13:45Z","pushed_at":"2015-12-16T08:38:01Z","git_url":"git://github.com/TomFischer/ogs.git","ssh_url":"git@github.com:TomFischer/ogs.git","clone_url":"https://github.com/TomFischer/ogs.git","svn_url":"https://github.com/TomFischer/ogs","homepage":"www.opengeosys.org","size":10875,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ufz:master","ref":"master","sha":"1145b875dba823a0bf424ae8eb13e091f6564212","user":{"login":"ufz","id":767517,"avatar_url":"https://avatars.githubusercontent.com/u/767517?v=3","gravatar_id":"","url":"https://api.github.com/users/ufz","html_url":"https://github.com/ufz","followers_url":"https://api.github.com/users/ufz/followers","following_url":"https://api.github.com/users/ufz/following{/other_user}","gists_url":"https://api.github.com/users/ufz/gists{/gist_id}","starred_url":"https://api.github.com/users/ufz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ufz/subscriptions","organizations_url":"https://api.github.com/users/ufz/orgs","repos_url":"https://api.github.com/users/ufz/repos","events_url":"https://api.github.com/users/ufz/events{/privacy}","received_events_url":"https://api.github.com/users/ufz/received_events","type":"Organization","site_admin":false},"repo":{"id":1701384,"name":"ogs","full_name":"ufz/ogs","owner":{"login":"ufz","id":767517,"avatar_url":"https://avatars.githubusercontent.com/u/767517?v=3","gravatar_id":"","url":"https://api.github.com/users/ufz","html_url":"https://github.com/ufz","followers_url":"https://api.github.com/users/ufz/followers","following_url":"https://api.github.com/users/ufz/following{/other_user}","gists_url":"https://api.github.com/users/ufz/gists{/gist_id}","starred_url":"https://api.github.com/users/ufz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ufz/subscriptions","organizations_url":"https://api.github.com/users/ufz/orgs","repos_url":"https://api.github.com/users/ufz/repos","events_url":"https://api.github.com/users/ufz/events{/privacy}","received_events_url":"https://api.github.com/users/ufz/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ufz/ogs","description":"Experimental OGS-6 source code","fork":false,"url":"https://api.github.com/repos/ufz/ogs","forks_url":"https://api.github.com/repos/ufz/ogs/forks","keys_url":"https://api.github.com/repos/ufz/ogs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ufz/ogs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ufz/ogs/teams","hooks_url":"https://api.github.com/repos/ufz/ogs/hooks","issue_events_url":"https://api.github.com/repos/ufz/ogs/issues/events{/number}","events_url":"https://api.github.com/repos/ufz/ogs/events","assignees_url":"https://api.github.com/repos/ufz/ogs/assignees{/user}","branches_url":"https://api.github.com/repos/ufz/ogs/branches{/branch}","tags_url":"https://api.github.com/repos/ufz/ogs/tags","blobs_url":"https://api.github.com/repos/ufz/ogs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ufz/ogs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ufz/ogs/git/refs{/sha}","trees_url":"https://api.github.com/repos/ufz/ogs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ufz/ogs/statuses/{sha}","languages_url":"https://api.github.com/repos/ufz/ogs/languages","stargazers_url":"https://api.github.com/repos/ufz/ogs/stargazers","contributors_url":"https://api.github.com/repos/ufz/ogs/contributors","subscribers_url":"https://api.github.com/repos/ufz/ogs/subscribers","subscription_url":"https://api.github.com/repos/ufz/ogs/subscription","commits_url":"https://api.github.com/repos/ufz/ogs/commits{/sha}","git_commits_url":"https://api.github.com/repos/ufz/ogs/git/commits{/sha}","comments_url":"https://api.github.com/repos/ufz/ogs/comments{/number}","issue_comment_url":"https://api.github.com/repos/ufz/ogs/issues/comments{/number}","contents_url":"https://api.github.com/repos/ufz/ogs/contents/{+path}","compare_url":"https://api.github.com/repos/ufz/ogs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ufz/ogs/merges","archive_url":"https://api.github.com/repos/ufz/ogs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ufz/ogs/downloads","issues_url":"https://api.github.com/repos/ufz/ogs/issues{/number}","pulls_url":"https://api.github.com/repos/ufz/ogs/pulls{/number}","milestones_url":"https://api.github.com/repos/ufz/ogs/milestones{/number}","notifications_url":"https://api.github.com/repos/ufz/ogs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ufz/ogs/labels{/name}","releases_url":"https://api.github.com/repos/ufz/ogs/releases{/id}","created_at":"2011-05-04T14:09:57Z","updated_at":"2015-10-23T03:43:52Z","pushed_at":"2015-12-16T08:38:48Z","git_url":"git://github.com/ufz/ogs.git","ssh_url":"git@github.com:ufz/ogs.git","clone_url":"https://github.com/ufz/ogs.git","svn_url":"https://github.com/ufz/ogs","homepage":"www.opengeosys.org","size":11711,"stargazers_count":18,"watchers_count":18,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":37,"mirror_url":null,"open_issues_count":75,"forks":37,"open_issues":75,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ufz/ogs/pulls/929"},"html":{"href":"https://github.com/ufz/ogs/pull/929"},"issue":{"href":"https://api.github.com/repos/ufz/ogs/issues/929"},"comments":{"href":"https://api.github.com/repos/ufz/ogs/issues/929/comments"},"review_comments":{"href":"https://api.github.com/repos/ufz/ogs/pulls/929/comments"},"review_comment":{"href":"https://api.github.com/repos/ufz/ogs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ufz/ogs/pulls/929/commits"},"statuses":{"href":"https://api.github.com/repos/ufz/ogs/statuses/222f4c68032340ea10212e494c663152b81ed208"}}}}