{"action":"created","comment":{"url":"https://api.github.com/repos/reddit/reddit-mobile/pulls/comments/40483000","id":40483000,"diff_hunk":"@@ -163,7 +166,7 @@ class TopNav extends BaseComponent {\n       });\n \n       this.setState({\n-        subreddit: Object.assign(subreddit, {\n+        subreddit: Object.assign({}, state.subreddit, {","path":"src/views/components/TopNav.jsx","position":82,"original_position":82,"commit_id":"a7acd43e7d4eeeba08c9ca2d1746b668b8c57b74","original_commit_id":"a7acd43e7d4eeeba08c9ca2d1746b668b8c57b74","user":{"login":"curioussavage","id":7064600,"avatar_url":"https://avatars.githubusercontent.com/u/7064600?v=3","gravatar_id":"","url":"https://api.github.com/users/curioussavage","html_url":"https://github.com/curioussavage","followers_url":"https://api.github.com/users/curioussavage/followers","following_url":"https://api.github.com/users/curioussavage/following{/other_user}","gists_url":"https://api.github.com/users/curioussavage/gists{/gist_id}","starred_url":"https://api.github.com/users/curioussavage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/curioussavage/subscriptions","organizations_url":"https://api.github.com/users/curioussavage/orgs","repos_url":"https://api.github.com/users/curioussavage/repos","events_url":"https://api.github.com/users/curioussavage/events{/privacy}","received_events_url":"https://api.github.com/users/curioussavage/received_events","type":"User","site_admin":false},"body":"This was screwing up `componentDidMount` on the `baseComponent`. Since a reference to state was being modified the nextState and this.state were already equal.  The React docs warn about this exact bug [here](https://facebook.github.io/react/docs/advanced-performance.html). It's possible we might have other bugs related to this and even if not it would be easy to cause again.\r\n\r\nDocs also point out how expensive doing deep comparisons are for perf. With how often this method is running in our app this might be a net loss for perf. Based on that It would probably be a good idea to consider removing `baseComponent`. ","created_at":"2015-09-25T22:51:00Z","updated_at":"2015-09-25T22:51:00Z","html_url":"https://github.com/reddit/reddit-mobile/pull/319#discussion_r40483000","pull_request_url":"https://api.github.com/repos/reddit/reddit-mobile/pulls/319","_links":{"self":{"href":"https://api.github.com/repos/reddit/reddit-mobile/pulls/comments/40483000"},"html":{"href":"https://github.com/reddit/reddit-mobile/pull/319#discussion_r40483000"},"pull_request":{"href":"https://api.github.com/repos/reddit/reddit-mobile/pulls/319"}}},"pull_request":{"url":"https://api.github.com/repos/reddit/reddit-mobile/pulls/319","id":46065451,"html_url":"https://github.com/reddit/reddit-mobile/pull/319","diff_url":"https://github.com/reddit/reddit-mobile/pull/319.diff","patch_url":"https://github.com/reddit/reddit-mobile/pull/319.patch","issue_url":"https://api.github.com/repos/reddit/reddit-mobile/issues/319","number":319,"state":"open","locked":false,"title":"TopNav: refactor component","user":{"login":"curioussavage","id":7064600,"avatar_url":"https://avatars.githubusercontent.com/u/7064600?v=3","gravatar_id":"","url":"https://api.github.com/users/curioussavage","html_url":"https://github.com/curioussavage","followers_url":"https://api.github.com/users/curioussavage/followers","following_url":"https://api.github.com/users/curioussavage/following{/other_user}","gists_url":"https://api.github.com/users/curioussavage/gists{/gist_id}","starred_url":"https://api.github.com/users/curioussavage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/curioussavage/subscriptions","organizations_url":"https://api.github.com/users/curioussavage/orgs","repos_url":"https://api.github.com/users/curioussavage/repos","events_url":"https://api.github.com/users/curioussavage/events{/privacy}","received_events_url":"https://api.github.com/users/curioussavage/received_events","type":"User","site_admin":false},"body":"Remove event for topnav change, relies on\r\nnew props instead. Fixes subscription toggle bug\r\nand multi name also.\r\n\r\n:eyeglasses: @ajacksified \r\n\r\nfixes following bugs in prod:\r\n\r\n* no subreddit title in comments page\r\n* multi name is not displayed in the topnav\r\n* subscribing is broken\r\n","created_at":"2015-09-25T22:38:39Z","updated_at":"2015-09-25T22:51:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"382a9716b04b26f3c9c2f2522f36e01f5f3f6592","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/reddit/reddit-mobile/pulls/319/commits","review_comments_url":"https://api.github.com/repos/reddit/reddit-mobile/pulls/319/comments","review_comment_url":"https://api.github.com/repos/reddit/reddit-mobile/pulls/comments{/number}","comments_url":"https://api.github.com/repos/reddit/reddit-mobile/issues/319/comments","statuses_url":"https://api.github.com/repos/reddit/reddit-mobile/statuses/a7acd43e7d4eeeba08c9ca2d1746b668b8c57b74","head":{"label":"curioussavage:topnav-refactor","ref":"topnav-refactor","sha":"a7acd43e7d4eeeba08c9ca2d1746b668b8c57b74","user":{"login":"curioussavage","id":7064600,"avatar_url":"https://avatars.githubusercontent.com/u/7064600?v=3","gravatar_id":"","url":"https://api.github.com/users/curioussavage","html_url":"https://github.com/curioussavage","followers_url":"https://api.github.com/users/curioussavage/followers","following_url":"https://api.github.com/users/curioussavage/following{/other_user}","gists_url":"https://api.github.com/users/curioussavage/gists{/gist_id}","starred_url":"https://api.github.com/users/curioussavage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/curioussavage/subscriptions","organizations_url":"https://api.github.com/users/curioussavage/orgs","repos_url":"https://api.github.com/users/curioussavage/repos","events_url":"https://api.github.com/users/curioussavage/events{/privacy}","received_events_url":"https://api.github.com/users/curioussavage/received_events","type":"User","site_admin":false},"repo":{"id":35171597,"name":"reddit-mobile","full_name":"curioussavage/reddit-mobile","owner":{"login":"curioussavage","id":7064600,"avatar_url":"https://avatars.githubusercontent.com/u/7064600?v=3","gravatar_id":"","url":"https://api.github.com/users/curioussavage","html_url":"https://github.com/curioussavage","followers_url":"https://api.github.com/users/curioussavage/followers","following_url":"https://api.github.com/users/curioussavage/following{/other_user}","gists_url":"https://api.github.com/users/curioussavage/gists{/gist_id}","starred_url":"https://api.github.com/users/curioussavage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/curioussavage/subscriptions","organizations_url":"https://api.github.com/users/curioussavage/orgs","repos_url":"https://api.github.com/users/curioussavage/repos","events_url":"https://api.github.com/users/curioussavage/events{/privacy}","received_events_url":"https://api.github.com/users/curioussavage/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/curioussavage/reddit-mobile","description":"","fork":true,"url":"https://api.github.com/repos/curioussavage/reddit-mobile","forks_url":"https://api.github.com/repos/curioussavage/reddit-mobile/forks","keys_url":"https://api.github.com/repos/curioussavage/reddit-mobile/keys{/key_id}","collaborators_url":"https://api.github.com/repos/curioussavage/reddit-mobile/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/curioussavage/reddit-mobile/teams","hooks_url":"https://api.github.com/repos/curioussavage/reddit-mobile/hooks","issue_events_url":"https://api.github.com/repos/curioussavage/reddit-mobile/issues/events{/number}","events_url":"https://api.github.com/repos/curioussavage/reddit-mobile/events","assignees_url":"https://api.github.com/repos/curioussavage/reddit-mobile/assignees{/user}","branches_url":"https://api.github.com/repos/curioussavage/reddit-mobile/branches{/branch}","tags_url":"https://api.github.com/repos/curioussavage/reddit-mobile/tags","blobs_url":"https://api.github.com/repos/curioussavage/reddit-mobile/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/curioussavage/reddit-mobile/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/curioussavage/reddit-mobile/git/refs{/sha}","trees_url":"https://api.github.com/repos/curioussavage/reddit-mobile/git/trees{/sha}","statuses_url":"https://api.github.com/repos/curioussavage/reddit-mobile/statuses/{sha}","languages_url":"https://api.github.com/repos/curioussavage/reddit-mobile/languages","stargazers_url":"https://api.github.com/repos/curioussavage/reddit-mobile/stargazers","contributors_url":"https://api.github.com/repos/curioussavage/reddit-mobile/contributors","subscribers_url":"https://api.github.com/repos/curioussavage/reddit-mobile/subscribers","subscription_url":"https://api.github.com/repos/curioussavage/reddit-mobile/subscription","commits_url":"https://api.github.com/repos/curioussavage/reddit-mobile/commits{/sha}","git_commits_url":"https://api.github.com/repos/curioussavage/reddit-mobile/git/commits{/sha}","comments_url":"https://api.github.com/repos/curioussavage/reddit-mobile/comments{/number}","issue_comment_url":"https://api.github.com/repos/curioussavage/reddit-mobile/issues/comments{/number}","contents_url":"https://api.github.com/repos/curioussavage/reddit-mobile/contents/{+path}","compare_url":"https://api.github.com/repos/curioussavage/reddit-mobile/compare/{base}...{head}","merges_url":"https://api.github.com/repos/curioussavage/reddit-mobile/merges","archive_url":"https://api.github.com/repos/curioussavage/reddit-mobile/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/curioussavage/reddit-mobile/downloads","issues_url":"https://api.github.com/repos/curioussavage/reddit-mobile/issues{/number}","pulls_url":"https://api.github.com/repos/curioussavage/reddit-mobile/pulls{/number}","milestones_url":"https://api.github.com/repos/curioussavage/reddit-mobile/milestones{/number}","notifications_url":"https://api.github.com/repos/curioussavage/reddit-mobile/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/curioussavage/reddit-mobile/labels{/name}","releases_url":"https://api.github.com/repos/curioussavage/reddit-mobile/releases{/id}","created_at":"2015-05-06T16:55:50Z","updated_at":"2015-05-06T16:55:51Z","pushed_at":"2015-09-25T22:37:34Z","git_url":"git://github.com/curioussavage/reddit-mobile.git","ssh_url":"git@github.com:curioussavage/reddit-mobile.git","clone_url":"https://github.com/curioussavage/reddit-mobile.git","svn_url":"https://github.com/curioussavage/reddit-mobile","homepage":null,"size":2553,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"reddit:master","ref":"master","sha":"9169c1d05a35d4c58a0d7a9b3b64cfa50efaba48","user":{"login":"reddit","id":14248,"avatar_url":"https://avatars.githubusercontent.com/u/14248?v=3","gravatar_id":"","url":"https://api.github.com/users/reddit","html_url":"https://github.com/reddit","followers_url":"https://api.github.com/users/reddit/followers","following_url":"https://api.github.com/users/reddit/following{/other_user}","gists_url":"https://api.github.com/users/reddit/gists{/gist_id}","starred_url":"https://api.github.com/users/reddit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reddit/subscriptions","organizations_url":"https://api.github.com/users/reddit/orgs","repos_url":"https://api.github.com/users/reddit/repos","events_url":"https://api.github.com/users/reddit/events{/privacy}","received_events_url":"https://api.github.com/users/reddit/received_events","type":"Organization","site_admin":false},"repo":{"id":23087554,"name":"reddit-mobile","full_name":"reddit/reddit-mobile","owner":{"login":"reddit","id":14248,"avatar_url":"https://avatars.githubusercontent.com/u/14248?v=3","gravatar_id":"","url":"https://api.github.com/users/reddit","html_url":"https://github.com/reddit","followers_url":"https://api.github.com/users/reddit/followers","following_url":"https://api.github.com/users/reddit/following{/other_user}","gists_url":"https://api.github.com/users/reddit/gists{/gist_id}","starred_url":"https://api.github.com/users/reddit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reddit/subscriptions","organizations_url":"https://api.github.com/users/reddit/orgs","repos_url":"https://api.github.com/users/reddit/repos","events_url":"https://api.github.com/users/reddit/events{/privacy}","received_events_url":"https://api.github.com/users/reddit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/reddit/reddit-mobile","description":"","fork":false,"url":"https://api.github.com/repos/reddit/reddit-mobile","forks_url":"https://api.github.com/repos/reddit/reddit-mobile/forks","keys_url":"https://api.github.com/repos/reddit/reddit-mobile/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reddit/reddit-mobile/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reddit/reddit-mobile/teams","hooks_url":"https://api.github.com/repos/reddit/reddit-mobile/hooks","issue_events_url":"https://api.github.com/repos/reddit/reddit-mobile/issues/events{/number}","events_url":"https://api.github.com/repos/reddit/reddit-mobile/events","assignees_url":"https://api.github.com/repos/reddit/reddit-mobile/assignees{/user}","branches_url":"https://api.github.com/repos/reddit/reddit-mobile/branches{/branch}","tags_url":"https://api.github.com/repos/reddit/reddit-mobile/tags","blobs_url":"https://api.github.com/repos/reddit/reddit-mobile/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reddit/reddit-mobile/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reddit/reddit-mobile/git/refs{/sha}","trees_url":"https://api.github.com/repos/reddit/reddit-mobile/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reddit/reddit-mobile/statuses/{sha}","languages_url":"https://api.github.com/repos/reddit/reddit-mobile/languages","stargazers_url":"https://api.github.com/repos/reddit/reddit-mobile/stargazers","contributors_url":"https://api.github.com/repos/reddit/reddit-mobile/contributors","subscribers_url":"https://api.github.com/repos/reddit/reddit-mobile/subscribers","subscription_url":"https://api.github.com/repos/reddit/reddit-mobile/subscription","commits_url":"https://api.github.com/repos/reddit/reddit-mobile/commits{/sha}","git_commits_url":"https://api.github.com/repos/reddit/reddit-mobile/git/commits{/sha}","comments_url":"https://api.github.com/repos/reddit/reddit-mobile/comments{/number}","issue_comment_url":"https://api.github.com/repos/reddit/reddit-mobile/issues/comments{/number}","contents_url":"https://api.github.com/repos/reddit/reddit-mobile/contents/{+path}","compare_url":"https://api.github.com/repos/reddit/reddit-mobile/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reddit/reddit-mobile/merges","archive_url":"https://api.github.com/repos/reddit/reddit-mobile/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reddit/reddit-mobile/downloads","issues_url":"https://api.github.com/repos/reddit/reddit-mobile/issues{/number}","pulls_url":"https://api.github.com/repos/reddit/reddit-mobile/pulls{/number}","milestones_url":"https://api.github.com/repos/reddit/reddit-mobile/milestones{/number}","notifications_url":"https://api.github.com/repos/reddit/reddit-mobile/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reddit/reddit-mobile/labels{/name}","releases_url":"https://api.github.com/repos/reddit/reddit-mobile/releases{/id}","created_at":"2014-08-18T21:42:05Z","updated_at":"2015-09-22T16:42:05Z","pushed_at":"2015-09-25T22:38:40Z","git_url":"git://github.com/reddit/reddit-mobile.git","ssh_url":"git@github.com:reddit/reddit-mobile.git","clone_url":"https://github.com/reddit/reddit-mobile.git","svn_url":"https://github.com/reddit/reddit-mobile","homepage":null,"size":8011,"stargazers_count":538,"watchers_count":538,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":75,"mirror_url":null,"open_issues_count":26,"forks":75,"open_issues":26,"watchers":538,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/reddit/reddit-mobile/pulls/319"},"html":{"href":"https://github.com/reddit/reddit-mobile/pull/319"},"issue":{"href":"https://api.github.com/repos/reddit/reddit-mobile/issues/319"},"comments":{"href":"https://api.github.com/repos/reddit/reddit-mobile/issues/319/comments"},"review_comments":{"href":"https://api.github.com/repos/reddit/reddit-mobile/pulls/319/comments"},"review_comment":{"href":"https://api.github.com/repos/reddit/reddit-mobile/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/reddit/reddit-mobile/pulls/319/commits"},"statuses":{"href":"https://api.github.com/repos/reddit/reddit-mobile/statuses/a7acd43e7d4eeeba08c9ca2d1746b668b8c57b74"}}}}