{"action":"opened","number":310,"pull_request":{"url":"https://api.github.com/repos/ScottLogic/d3-financial-components/pulls/310","id":34183201,"html_url":"https://github.com/ScottLogic/d3-financial-components/pull/310","diff_url":"https://github.com/ScottLogic/d3-financial-components/pull/310.diff","patch_url":"https://github.com/ScottLogic/d3-financial-components/pull/310.patch","issue_url":"https://api.github.com/repos/ScottLogic/d3-financial-components/issues/310","number":310,"state":"open","locked":false,"title":"Removed chartLayout / chartBuilder from functional visual tests - DO NOT MERGE","user":{"login":"ColinEberhardt","id":1098110,"avatar_url":"https://avatars.githubusercontent.com/u/1098110?v=3","gravatar_id":"","url":"https://api.github.com/users/ColinEberhardt","html_url":"https://github.com/ColinEberhardt","followers_url":"https://api.github.com/users/ColinEberhardt/followers","following_url":"https://api.github.com/users/ColinEberhardt/following{/other_user}","gists_url":"https://api.github.com/users/ColinEberhardt/gists{/gist_id}","starred_url":"https://api.github.com/users/ColinEberhardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ColinEberhardt/subscriptions","organizations_url":"https://api.github.com/users/ColinEberhardt/orgs","repos_url":"https://api.github.com/users/ColinEberhardt/repos","events_url":"https://api.github.com/users/ColinEberhardt/events{/privacy}","received_events_url":"https://api.github.com/users/ColinEberhardt/received_events","type":"User","site_admin":false},"body":"Thought I'd share my work-in-progress. I'm removing chartLayout & chartBuilder, starting by removing them from the visual tests.\r\n\r\nTo hopefully remove test-cross over I am not replacing them with the new layout, instead I am stripping away any visual components that are not relevant to the given test.\r\n\r\n![image](https://cloud.githubusercontent.com/assets/1098110/7351672/8c13889c-ecfe-11e4-987d-0f9bf9e74b42.png)\r\n\r\nIt also means that charts in the test no longer re-size with the browser.\r\n\r\nLet me know if you have any thoughts? I'll just keep trudging onwards!\r\n","created_at":"2015-04-27T15:59:34Z","updated_at":"2015-04-27T15:59:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ScottLogic/d3-financial-components/pulls/310/commits","review_comments_url":"https://api.github.com/repos/ScottLogic/d3-financial-components/pulls/310/comments","review_comment_url":"https://api.github.com/repos/ScottLogic/d3-financial-components/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ScottLogic/d3-financial-components/issues/310/comments","statuses_url":"https://api.github.com/repos/ScottLogic/d3-financial-components/statuses/7543bfd982447923fe2ef0517e3c5219f64538ac","head":{"label":"ColinEberhardt:remove-old-layout","ref":"remove-old-layout","sha":"7543bfd982447923fe2ef0517e3c5219f64538ac","user":{"login":"ColinEberhardt","id":1098110,"avatar_url":"https://avatars.githubusercontent.com/u/1098110?v=3","gravatar_id":"","url":"https://api.github.com/users/ColinEberhardt","html_url":"https://github.com/ColinEberhardt","followers_url":"https://api.github.com/users/ColinEberhardt/followers","following_url":"https://api.github.com/users/ColinEberhardt/following{/other_user}","gists_url":"https://api.github.com/users/ColinEberhardt/gists{/gist_id}","starred_url":"https://api.github.com/users/ColinEberhardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ColinEberhardt/subscriptions","organizations_url":"https://api.github.com/users/ColinEberhardt/orgs","repos_url":"https://api.github.com/users/ColinEberhardt/repos","events_url":"https://api.github.com/users/ColinEberhardt/events{/privacy}","received_events_url":"https://api.github.com/users/ColinEberhardt/received_events","type":"User","site_admin":false},"repo":{"id":26486000,"name":"d3-financial-components","full_name":"ColinEberhardt/d3-financial-components","owner":{"login":"ColinEberhardt","id":1098110,"avatar_url":"https://avatars.githubusercontent.com/u/1098110?v=3","gravatar_id":"","url":"https://api.github.com/users/ColinEberhardt","html_url":"https://github.com/ColinEberhardt","followers_url":"https://api.github.com/users/ColinEberhardt/followers","following_url":"https://api.github.com/users/ColinEberhardt/following{/other_user}","gists_url":"https://api.github.com/users/ColinEberhardt/gists{/gist_id}","starred_url":"https://api.github.com/users/ColinEberhardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ColinEberhardt/subscriptions","organizations_url":"https://api.github.com/users/ColinEberhardt/orgs","repos_url":"https://api.github.com/users/ColinEberhardt/repos","events_url":"https://api.github.com/users/ColinEberhardt/events{/privacy}","received_events_url":"https://api.github.com/users/ColinEberhardt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ColinEberhardt/d3-financial-components","description":"A set of re-useable components for building financial charts with D3","fork":true,"url":"https://api.github.com/repos/ColinEberhardt/d3-financial-components","forks_url":"https://api.github.com/repos/ColinEberhardt/d3-financial-components/forks","keys_url":"https://api.github.com/repos/ColinEberhardt/d3-financial-components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ColinEberhardt/d3-financial-components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ColinEberhardt/d3-financial-components/teams","hooks_url":"https://api.github.com/repos/ColinEberhardt/d3-financial-components/hooks","issue_events_url":"https://api.github.com/repos/ColinEberhardt/d3-financial-components/issues/events{/number}","events_url":"https://api.github.com/repos/ColinEberhardt/d3-financial-components/events","assignees_url":"https://api.github.com/repos/ColinEberhardt/d3-financial-components/assignees{/user}","branches_url":"https://api.github.com/repos/ColinEberhardt/d3-financial-components/branches{/branch}","tags_url":"https://api.github.com/repos/ColinEberhardt/d3-financial-components/tags","blobs_url":"https://api.github.com/repos/ColinEberhardt/d3-financial-components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ColinEberhardt/d3-financial-components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ColinEberhardt/d3-financial-components/git/refs{/sha}","trees_url":"https://api.github.com/repos/ColinEberhardt/d3-financial-components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ColinEberhardt/d3-financial-components/statuses/{sha}","languages_url":"https://api.github.com/repos/ColinEberhardt/d3-financial-components/languages","stargazers_url":"https://api.github.com/repos/ColinEberhardt/d3-financial-components/stargazers","contributors_url":"https://api.github.com/repos/ColinEberhardt/d3-financial-components/contributors","subscribers_url":"https://api.github.com/repos/ColinEberhardt/d3-financial-components/subscribers","subscription_url":"https://api.github.com/repos/ColinEberhardt/d3-financial-components/subscription","commits_url":"https://api.github.com/repos/ColinEberhardt/d3-financial-components/commits{/sha}","git_commits_url":"https://api.github.com/repos/ColinEberhardt/d3-financial-components/git/commits{/sha}","comments_url":"https://api.github.com/repos/ColinEberhardt/d3-financial-components/comments{/number}","issue_comment_url":"https://api.github.com/repos/ColinEberhardt/d3-financial-components/issues/comments{/number}","contents_url":"https://api.github.com/repos/ColinEberhardt/d3-financial-components/contents/{+path}","compare_url":"https://api.github.com/repos/ColinEberhardt/d3-financial-components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ColinEberhardt/d3-financial-components/merges","archive_url":"https://api.github.com/repos/ColinEberhardt/d3-financial-components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ColinEberhardt/d3-financial-components/downloads","issues_url":"https://api.github.com/repos/ColinEberhardt/d3-financial-components/issues{/number}","pulls_url":"https://api.github.com/repos/ColinEberhardt/d3-financial-components/pulls{/number}","milestones_url":"https://api.github.com/repos/ColinEberhardt/d3-financial-components/milestones{/number}","notifications_url":"https://api.github.com/repos/ColinEberhardt/d3-financial-components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ColinEberhardt/d3-financial-components/labels{/name}","releases_url":"https://api.github.com/repos/ColinEberhardt/d3-financial-components/releases{/id}","created_at":"2014-11-11T13:25:33Z","updated_at":"2015-02-11T16:05:01Z","pushed_at":"2015-04-27T15:57:06Z","git_url":"git://github.com/ColinEberhardt/d3-financial-components.git","ssh_url":"git@github.com:ColinEberhardt/d3-financial-components.git","clone_url":"https://github.com/ColinEberhardt/d3-financial-components.git","svn_url":"https://github.com/ColinEberhardt/d3-financial-components","homepage":"","size":2683,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"ScottLogic:master","ref":"master","sha":"c9ec86a8ba9767434f8a87f91ff62500d75db9c7","user":{"login":"ScottLogic","id":2046037,"avatar_url":"https://avatars.githubusercontent.com/u/2046037?v=3","gravatar_id":"","url":"https://api.github.com/users/ScottLogic","html_url":"https://github.com/ScottLogic","followers_url":"https://api.github.com/users/ScottLogic/followers","following_url":"https://api.github.com/users/ScottLogic/following{/other_user}","gists_url":"https://api.github.com/users/ScottLogic/gists{/gist_id}","starred_url":"https://api.github.com/users/ScottLogic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ScottLogic/subscriptions","organizations_url":"https://api.github.com/users/ScottLogic/orgs","repos_url":"https://api.github.com/users/ScottLogic/repos","events_url":"https://api.github.com/users/ScottLogic/events{/privacy}","received_events_url":"https://api.github.com/users/ScottLogic/received_events","type":"Organization","site_admin":false},"repo":{"id":24850617,"name":"d3-financial-components","full_name":"ScottLogic/d3-financial-components","owner":{"login":"ScottLogic","id":2046037,"avatar_url":"https://avatars.githubusercontent.com/u/2046037?v=3","gravatar_id":"","url":"https://api.github.com/users/ScottLogic","html_url":"https://github.com/ScottLogic","followers_url":"https://api.github.com/users/ScottLogic/followers","following_url":"https://api.github.com/users/ScottLogic/following{/other_user}","gists_url":"https://api.github.com/users/ScottLogic/gists{/gist_id}","starred_url":"https://api.github.com/users/ScottLogic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ScottLogic/subscriptions","organizations_url":"https://api.github.com/users/ScottLogic/orgs","repos_url":"https://api.github.com/users/ScottLogic/repos","events_url":"https://api.github.com/users/ScottLogic/events{/privacy}","received_events_url":"https://api.github.com/users/ScottLogic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ScottLogic/d3-financial-components","description":"A set of re-useable components for building financial charts with D3","fork":false,"url":"https://api.github.com/repos/ScottLogic/d3-financial-components","forks_url":"https://api.github.com/repos/ScottLogic/d3-financial-components/forks","keys_url":"https://api.github.com/repos/ScottLogic/d3-financial-components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ScottLogic/d3-financial-components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ScottLogic/d3-financial-components/teams","hooks_url":"https://api.github.com/repos/ScottLogic/d3-financial-components/hooks","issue_events_url":"https://api.github.com/repos/ScottLogic/d3-financial-components/issues/events{/number}","events_url":"https://api.github.com/repos/ScottLogic/d3-financial-components/events","assignees_url":"https://api.github.com/repos/ScottLogic/d3-financial-components/assignees{/user}","branches_url":"https://api.github.com/repos/ScottLogic/d3-financial-components/branches{/branch}","tags_url":"https://api.github.com/repos/ScottLogic/d3-financial-components/tags","blobs_url":"https://api.github.com/repos/ScottLogic/d3-financial-components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ScottLogic/d3-financial-components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ScottLogic/d3-financial-components/git/refs{/sha}","trees_url":"https://api.github.com/repos/ScottLogic/d3-financial-components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ScottLogic/d3-financial-components/statuses/{sha}","languages_url":"https://api.github.com/repos/ScottLogic/d3-financial-components/languages","stargazers_url":"https://api.github.com/repos/ScottLogic/d3-financial-components/stargazers","contributors_url":"https://api.github.com/repos/ScottLogic/d3-financial-components/contributors","subscribers_url":"https://api.github.com/repos/ScottLogic/d3-financial-components/subscribers","subscription_url":"https://api.github.com/repos/ScottLogic/d3-financial-components/subscription","commits_url":"https://api.github.com/repos/ScottLogic/d3-financial-components/commits{/sha}","git_commits_url":"https://api.github.com/repos/ScottLogic/d3-financial-components/git/commits{/sha}","comments_url":"https://api.github.com/repos/ScottLogic/d3-financial-components/comments{/number}","issue_comment_url":"https://api.github.com/repos/ScottLogic/d3-financial-components/issues/comments{/number}","contents_url":"https://api.github.com/repos/ScottLogic/d3-financial-components/contents/{+path}","compare_url":"https://api.github.com/repos/ScottLogic/d3-financial-components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ScottLogic/d3-financial-components/merges","archive_url":"https://api.github.com/repos/ScottLogic/d3-financial-components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ScottLogic/d3-financial-components/downloads","issues_url":"https://api.github.com/repos/ScottLogic/d3-financial-components/issues{/number}","pulls_url":"https://api.github.com/repos/ScottLogic/d3-financial-components/pulls{/number}","milestones_url":"https://api.github.com/repos/ScottLogic/d3-financial-components/milestones{/number}","notifications_url":"https://api.github.com/repos/ScottLogic/d3-financial-components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ScottLogic/d3-financial-components/labels{/name}","releases_url":"https://api.github.com/repos/ScottLogic/d3-financial-components/releases{/id}","created_at":"2014-10-06T15:03:11Z","updated_at":"2015-04-27T14:43:29Z","pushed_at":"2015-04-27T15:03:52Z","git_url":"git://github.com/ScottLogic/d3-financial-components.git","ssh_url":"git@github.com:ScottLogic/d3-financial-components.git","clone_url":"https://github.com/ScottLogic/d3-financial-components.git","svn_url":"https://github.com/ScottLogic/d3-financial-components","homepage":"","size":4685,"stargazers_count":56,"watchers_count":56,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":31,"forks":14,"open_issues":31,"watchers":56,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ScottLogic/d3-financial-components/pulls/310"},"html":{"href":"https://github.com/ScottLogic/d3-financial-components/pull/310"},"issue":{"href":"https://api.github.com/repos/ScottLogic/d3-financial-components/issues/310"},"comments":{"href":"https://api.github.com/repos/ScottLogic/d3-financial-components/issues/310/comments"},"review_comments":{"href":"https://api.github.com/repos/ScottLogic/d3-financial-components/pulls/310/comments"},"review_comment":{"href":"https://api.github.com/repos/ScottLogic/d3-financial-components/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ScottLogic/d3-financial-components/pulls/310/commits"},"statuses":{"href":"https://api.github.com/repos/ScottLogic/d3-financial-components/statuses/7543bfd982447923fe2ef0517e3c5219f64538ac"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":85,"deletions":60,"changed_files":4}}