{"action":"created","issue":{"url":"https://api.github.com/repos/docker/docker/issues/10798","labels_url":"https://api.github.com/repos/docker/docker/issues/10798/labels{/name}","comments_url":"https://api.github.com/repos/docker/docker/issues/10798/comments","events_url":"https://api.github.com/repos/docker/docker/issues/10798/events","html_url":"https://github.com/docker/docker/pull/10798","id":57687660,"number":10798,"title":"integration-cli: Remove timeout dependency on TestEventsUntag","user":{"login":"ahmetalpbalkan","id":159209,"avatar_url":"https://avatars.githubusercontent.com/u/159209?v=3","gravatar_id":"","url":"https://api.github.com/users/ahmetalpbalkan","html_url":"https://github.com/ahmetalpbalkan","followers_url":"https://api.github.com/users/ahmetalpbalkan/followers","following_url":"https://api.github.com/users/ahmetalpbalkan/following{/other_user}","gists_url":"https://api.github.com/users/ahmetalpbalkan/gists{/gist_id}","starred_url":"https://api.github.com/users/ahmetalpbalkan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahmetalpbalkan/subscriptions","organizations_url":"https://api.github.com/users/ahmetalpbalkan/orgs","repos_url":"https://api.github.com/users/ahmetalpbalkan/repos","events_url":"https://api.github.com/users/ahmetalpbalkan/events{/privacy}","received_events_url":"https://api.github.com/users/ahmetalpbalkan/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/docker/docker/labels/2-code-review","name":"2-code-review","color":"f7c6c7"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":12,"created_at":"2015-02-14T09:33:22Z","updated_at":"2015-02-24T00:17:39Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/10798","html_url":"https://github.com/docker/docker/pull/10798","diff_url":"https://github.com/docker/docker/pull/10798.diff","patch_url":"https://github.com/docker/docker/pull/10798.patch"},"body":"TestEventsUntag requires a `timeout` command which does not\r\nexist on OS X or Windows (in fact, windows has a totally different\r\ntimeout program and this test was accidentally using it, which is\r\nway worse in terms of finding out why it was failing).\r\n\r\n- Created `runCommandWithOutputForDuration`.\r\n  This entirely replaces `runDockerCommandWithTimeout` and\r\n  removes dependency to `timeout` command.\r\n- ~~Turned out `runDockerCommandWithTimeout` is only used by\r\n  `dockerCmdWithTimeout`/`dockerCmdInDirWithTimeout`.~~ \r\n- ~~Apparently `dockerCmdWithTimeout`/`dockerCmdInDirWithTimeout`\r\n  are dead code. I cleaned them while I'm at it.~~ \r\n- Made runDockerCommandWithTimeout reuse runDockerCommandForDuration.\r\n  This fixes its bugs mentioned above.\r\n\r\n\r\nTestEventsUntag works now on Windows.\r\n\r\nSigned-off-by: Ahmet Alp Balkan <ahmetalpbalkan@gmail.com>\r\nLabel: `#windows`\r\ncc: @unclejack @gsalgado @jfrazelle @icecrime @tiborvass "},"comment":{"url":"https://api.github.com/repos/docker/docker/issues/comments/75670018","html_url":"https://github.com/docker/docker/pull/10798#issuecomment-75670018","issue_url":"https://api.github.com/repos/docker/docker/issues/10798","id":75670018,"user":{"login":"jfrazelle","id":1445228,"avatar_url":"https://avatars.githubusercontent.com/u/1445228?v=3","gravatar_id":"","url":"https://api.github.com/users/jfrazelle","html_url":"https://github.com/jfrazelle","followers_url":"https://api.github.com/users/jfrazelle/followers","following_url":"https://api.github.com/users/jfrazelle/following{/other_user}","gists_url":"https://api.github.com/users/jfrazelle/gists{/gist_id}","starred_url":"https://api.github.com/users/jfrazelle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfrazelle/subscriptions","organizations_url":"https://api.github.com/users/jfrazelle/orgs","repos_url":"https://api.github.com/users/jfrazelle/repos","events_url":"https://api.github.com/users/jfrazelle/events{/privacy}","received_events_url":"https://api.github.com/users/jfrazelle/received_events","type":"User","site_admin":false},"created_at":"2015-02-24T00:17:39Z","updated_at":"2015-02-24T00:17:39Z","body":"I guess that is fine since they have 2 different purposes LGTM"}}