{"action":"created","issue":{"url":"https://api.github.com/repos/ADOdb/ADOdb/issues/149","labels_url":"https://api.github.com/repos/ADOdb/ADOdb/issues/149/labels{/name}","comments_url":"https://api.github.com/repos/ADOdb/ADOdb/issues/149/comments","events_url":"https://api.github.com/repos/ADOdb/ADOdb/issues/149/events","html_url":"https://github.com/ADOdb/ADOdb/pull/149","id":105957468,"number":149,"title":"table <opt> for mysqli, enable ALTER TABLE queries","user":{"login":"peterdd","id":1839154,"avatar_url":"https://avatars.githubusercontent.com/u/1839154?v=3","gravatar_id":"","url":"https://api.github.com/users/peterdd","html_url":"https://github.com/peterdd","followers_url":"https://api.github.com/users/peterdd/followers","following_url":"https://api.github.com/users/peterdd/following{/other_user}","gists_url":"https://api.github.com/users/peterdd/gists{/gist_id}","starred_url":"https://api.github.com/users/peterdd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterdd/subscriptions","organizations_url":"https://api.github.com/users/peterdd/orgs","repos_url":"https://api.github.com/users/peterdd/repos","events_url":"https://api.github.com/users/peterdd/events{/privacy}","received_events_url":"https://api.github.com/users/peterdd/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-09-11T07:21:03Z","updated_at":"2015-09-19T15:16:37Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ADOdb/ADOdb/pulls/149","html_url":"https://github.com/ADOdb/ADOdb/pull/149","diff_url":"https://github.com/ADOdb/ADOdb/pull/149.diff","patch_url":"https://github.com/ADOdb/ADOdb/pull/149.patch"},"body":"When a driver was used were $databaseType != $dataProvider (for instance mysqli vs. mysql) , the <opt></opt> tags in xml were ignored.\r\n\r\nSo this was ignored in the xml:\r\n```xml\r\n<table name=\"example\">\r\n<field name=\"content\" type=\"C\" size=\"100\"></field>\r\n<opt>DEFAULT CHARSET=utf8</opt>\r\n</table>\r\n```\r\nOr this because the opt of example is dbspecific:\r\n```xml\r\n<table name=\"example\">\r\n<field name=\"content\" type=\"C\" size=\"100\"></field>\r\n<opt platform=\"mysql\">DEFAULT CHARSET=utf8</opt>\r\n</table>\r\n```\r\n\r\nFor fixing a table on install if table <opt> not used/possible or on a upgrade the ALTER TABLE schould be possible within the xmlschema03.\r\n```xml\r\n<sql>\r\n<query platform=\"mysql\">ALTER TABLE example CONVERT TO CHARACTER SET utf8 COLLATE utf8_general_ci</query>\r\n</sql>\r\n```"},"comment":{"url":"https://api.github.com/repos/ADOdb/ADOdb/issues/comments/141679006","html_url":"https://github.com/ADOdb/ADOdb/pull/149#issuecomment-141679006","issue_url":"https://api.github.com/repos/ADOdb/ADOdb/issues/149","id":141679006,"user":{"login":"mnewnham","id":4359245,"avatar_url":"https://avatars.githubusercontent.com/u/4359245?v=3","gravatar_id":"","url":"https://api.github.com/users/mnewnham","html_url":"https://github.com/mnewnham","followers_url":"https://api.github.com/users/mnewnham/followers","following_url":"https://api.github.com/users/mnewnham/following{/other_user}","gists_url":"https://api.github.com/users/mnewnham/gists{/gist_id}","starred_url":"https://api.github.com/users/mnewnham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mnewnham/subscriptions","organizations_url":"https://api.github.com/users/mnewnham/orgs","repos_url":"https://api.github.com/users/mnewnham/repos","events_url":"https://api.github.com/users/mnewnham/events{/privacy}","received_events_url":"https://api.github.com/users/mnewnham/received_events","type":"User","site_admin":false},"created_at":"2015-09-19T15:16:37Z","updated_at":"2015-09-19T15:16:37Z","body":"I have not reviewed this in depth, is there a possibility that will be a mismatch here between this change, and supportedPlatform() in the same file, which also used databaseType"}}