{"action":"created","issue":{"url":"https://api.github.com/repos/lightblue-platform/lightblue-ldap/issues/29","labels_url":"https://api.github.com/repos/lightblue-platform/lightblue-ldap/issues/29/labels{/name}","comments_url":"https://api.github.com/repos/lightblue-platform/lightblue-ldap/issues/29/comments","events_url":"https://api.github.com/repos/lightblue-platform/lightblue-ldap/issues/29/events","html_url":"https://github.com/lightblue-platform/lightblue-ldap/pull/29","id":54591830,"number":29,"title":"Issue #17 type system","user":{"login":"dcrissman","id":1878960,"avatar_url":"https://avatars.githubusercontent.com/u/1878960?v=3","gravatar_id":"","url":"https://api.github.com/users/dcrissman","html_url":"https://github.com/dcrissman","followers_url":"https://api.github.com/users/dcrissman/followers","following_url":"https://api.github.com/users/dcrissman/following{/other_user}","gists_url":"https://api.github.com/users/dcrissman/gists{/gist_id}","starred_url":"https://api.github.com/users/dcrissman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcrissman/subscriptions","organizations_url":"https://api.github.com/users/dcrissman/orgs","repos_url":"https://api.github.com/users/dcrissman/repos","events_url":"https://api.github.com/users/dcrissman/events{/privacy}","received_events_url":"https://api.github.com/users/dcrissman/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/lightblue-platform/lightblue-ldap/labels/ready+for+review","name":"ready for review","color":"fbca04"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/lightblue-platform/lightblue-ldap/milestones/1","labels_url":"https://api.github.com/repos/lightblue-platform/lightblue-ldap/milestones/1/labels","id":942001,"number":1,"title":"Ana","description":"","creator":{"login":"jewzaam","id":480388,"avatar_url":"https://avatars.githubusercontent.com/u/480388?v=3","gravatar_id":"","url":"https://api.github.com/users/jewzaam","html_url":"https://github.com/jewzaam","followers_url":"https://api.github.com/users/jewzaam/followers","following_url":"https://api.github.com/users/jewzaam/following{/other_user}","gists_url":"https://api.github.com/users/jewzaam/gists{/gist_id}","starred_url":"https://api.github.com/users/jewzaam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jewzaam/subscriptions","organizations_url":"https://api.github.com/users/jewzaam/orgs","repos_url":"https://api.github.com/users/jewzaam/repos","events_url":"https://api.github.com/users/jewzaam/events{/privacy}","received_events_url":"https://api.github.com/users/jewzaam/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":9,"state":"open","created_at":"2015-01-19T15:15:23Z","updated_at":"2015-01-19T18:46:10Z","due_on":null,"closed_at":null},"comments":4,"created_at":"2015-01-16T16:05:10Z","updated_at":"2015-01-19T19:01:04Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/lightblue-platform/lightblue-ldap/pulls/29","html_url":"https://github.com/lightblue-platform/lightblue-ldap/pull/29","diff_url":"https://github.com/lightblue-platform/lightblue-ldap/pull/29.diff","patch_url":"https://github.com/lightblue-platform/lightblue-ldap/pull/29.patch"},"body":"There are some big changes in this PR.\r\n\r\nHighlights:\r\n* entitymetadata is now being used to translate json to an ldap Entry.\r\n* Created generic TranslatorFromJson with the hope that it possibly be moved to core and reused\r\n* Created EntryBuilder as an implementation of TranslatorFromJson for Ldap\r\n* Created integration tests to ensure date and binary types work properly\r\n* Abstracted some of the CRUDController test code which could possibly be promoted to core.test and reused"},"comment":{"url":"https://api.github.com/repos/lightblue-platform/lightblue-ldap/issues/comments/70543394","html_url":"https://github.com/lightblue-platform/lightblue-ldap/pull/29#issuecomment-70543394","issue_url":"https://api.github.com/repos/lightblue-platform/lightblue-ldap/issues/29","id":70543394,"user":{"login":"bserdar","id":3670797,"avatar_url":"https://avatars.githubusercontent.com/u/3670797?v=3","gravatar_id":"","url":"https://api.github.com/users/bserdar","html_url":"https://github.com/bserdar","followers_url":"https://api.github.com/users/bserdar/followers","following_url":"https://api.github.com/users/bserdar/following{/other_user}","gists_url":"https://api.github.com/users/bserdar/gists{/gist_id}","starred_url":"https://api.github.com/users/bserdar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bserdar/subscriptions","organizations_url":"https://api.github.com/users/bserdar/orgs","repos_url":"https://api.github.com/users/bserdar/repos","events_url":"https://api.github.com/users/bserdar/events{/privacy}","received_events_url":"https://api.github.com/users/bserdar/received_events","type":"User","site_admin":false},"created_at":"2015-01-19T19:01:04Z","updated_at":"2015-01-19T19:01:04Z","body":"Do you have a separate PR for this, or do you want another review of the\r\ncomplete source tree?\r\n\r\nOn Mon, Jan 19, 2015 at 11:57 AM, Dennis Crissman <notifications@github.com>\r\nwrote:\r\n\r\n> @bserdar <https://github.com/bserdar> This is ready for another CR. I\r\n> believe your above concerns have been addressed or spun off into another\r\n> issue.\r\n>\r\n> —\r\n> Reply to this email directly or view it on GitHub\r\n> <https://github.com/lightblue-platform/lightblue-ldap/pull/29#issuecomment-70542873>\r\n> .\r\n>"}}