{"action":"created","issue":{"url":"https://api.github.com/repos/ossec/ossec-hids/issues/502","labels_url":"https://api.github.com/repos/ossec/ossec-hids/issues/502/labels{/name}","comments_url":"https://api.github.com/repos/ossec/ossec-hids/issues/502/comments","events_url":"https://api.github.com/repos/ossec/ossec-hids/issues/502/events","html_url":"https://github.com/ossec/ossec-hids/pull/502","id":55035312,"number":502,"title":"Giant code-formatting patch","user":{"login":"wclarie","id":2357225,"avatar_url":"https://avatars.githubusercontent.com/u/2357225?v=3","gravatar_id":"","url":"https://api.github.com/users/wclarie","html_url":"https://github.com/wclarie","followers_url":"https://api.github.com/users/wclarie/followers","following_url":"https://api.github.com/users/wclarie/following{/other_user}","gists_url":"https://api.github.com/users/wclarie/gists{/gist_id}","starred_url":"https://api.github.com/users/wclarie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wclarie/subscriptions","organizations_url":"https://api.github.com/users/wclarie/orgs","repos_url":"https://api.github.com/users/wclarie/repos","events_url":"https://api.github.com/users/wclarie/events{/privacy}","received_events_url":"https://api.github.com/users/wclarie/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/ossec/ossec-hids/milestones/2","labels_url":"https://api.github.com/repos/ossec/ossec-hids/milestones/2/labels","id":554849,"number":2,"title":"ossec-hids-2.8","description":null,"creator":{"login":"jrossi","id":58556,"avatar_url":"https://avatars.githubusercontent.com/u/58556?v=3","gravatar_id":"","url":"https://api.github.com/users/jrossi","html_url":"https://github.com/jrossi","followers_url":"https://api.github.com/users/jrossi/followers","following_url":"https://api.github.com/users/jrossi/following{/other_user}","gists_url":"https://api.github.com/users/jrossi/gists{/gist_id}","starred_url":"https://api.github.com/users/jrossi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrossi/subscriptions","organizations_url":"https://api.github.com/users/jrossi/orgs","repos_url":"https://api.github.com/users/jrossi/repos","events_url":"https://api.github.com/users/jrossi/events{/privacy}","received_events_url":"https://api.github.com/users/jrossi/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":81,"state":"open","created_at":"2014-01-31T15:18:47Z","updated_at":"2015-01-21T17:53:23Z","due_on":null,"closed_at":null},"comments":6,"created_at":"2015-01-21T15:43:14Z","updated_at":"2015-01-21T18:26:59Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ossec/ossec-hids/pulls/502","html_url":"https://github.com/ossec/ossec-hids/pull/502","diff_url":"https://github.com/ossec/ossec-hids/pull/502.diff","patch_url":"https://github.com/ossec/ossec-hids/pull/502.patch"},"body":"Initial version of a gigantic code-formatting patch for the src directory (I have done the other directories too, but let's see first how this goes).\r\n\r\nThis is an attempt at creating a somewhat consistent base, so that it's easier and more fun for everyone to work on the ossec codebase. This is not an attempt at starting a holy war about code formatting, \r\n\r\nI've started from https://github.com/ossec/ossec-docs/blob/master/docs/development/oRFC/orfc-2.rst but found the way the formatting rules were described to be very strict and hard to read, so I tried to summarize the principles in this document, which is inspired by multiple places: https://gist.github.com/wclarie/cd05132574fb0191c58a\r\n\r\nThe summary of what I did is:\r\n- Fixed permissions on all the files (most of the code files were executable for some reason)\r\n- Reformatted using astyle with the settings described in https://gist.github.com/wclarie/cd05132574fb0191c58a\r\n- Cleaned up licences\r\n- Cleaned up use of whitespace (too much vertical whitespace + at end of lines etc)\r\n- Cleaned up / rephrased a lot of the comments in the code (this codebase is slightly over-commented)\r\n- Removed all the $Id$ tags\r\n- More stuff I forgot\r\n\r\nTesting was done on OS X 10.9.5 with clang, and on CentOS 6 64bit with gcc. On Mac there is no change to the object files whatsoever, in all normal Makefile targets. On Linux there are some differences because of gcc, but they should be purely gcc code-generation differences, no actual functional differences. I have no other platforms to test this on at the moment.\r\n\r\nHappy to hear constructive comments, suggestions etc."},"comment":{"url":"https://api.github.com/repos/ossec/ossec-hids/issues/comments/70892741","html_url":"https://github.com/ossec/ossec-hids/pull/502#issuecomment-70892741","issue_url":"https://api.github.com/repos/ossec/ossec-hids/issues/502","id":70892741,"user":{"login":"wclarie","id":2357225,"avatar_url":"https://avatars.githubusercontent.com/u/2357225?v=3","gravatar_id":"","url":"https://api.github.com/users/wclarie","html_url":"https://github.com/wclarie","followers_url":"https://api.github.com/users/wclarie/followers","following_url":"https://api.github.com/users/wclarie/following{/other_user}","gists_url":"https://api.github.com/users/wclarie/gists{/gist_id}","starred_url":"https://api.github.com/users/wclarie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wclarie/subscriptions","organizations_url":"https://api.github.com/users/wclarie/orgs","repos_url":"https://api.github.com/users/wclarie/repos","events_url":"https://api.github.com/users/wclarie/events{/privacy}","received_events_url":"https://api.github.com/users/wclarie/received_events","type":"User","site_admin":false},"created_at":"2015-01-21T18:26:59Z","updated_at":"2015-01-21T18:26:59Z","body":"Haven't tested this, but I think this should fix the build, as in: no errors."}}