{"action":"created","issue":{"url":"https://api.github.com/repos/devinus/poolboy/issues/72","labels_url":"https://api.github.com/repos/devinus/poolboy/issues/72/labels{/name}","comments_url":"https://api.github.com/repos/devinus/poolboy/issues/72/comments","events_url":"https://api.github.com/repos/devinus/poolboy/issues/72/events","html_url":"https://github.com/devinus/poolboy/issues/72","id":68255572,"number":72,"title":"new_worker failed cause poolby crashed","user":{"login":"linbo","id":1374391,"avatar_url":"https://avatars.githubusercontent.com/u/1374391?v=3","gravatar_id":"","url":"https://api.github.com/users/linbo","html_url":"https://github.com/linbo","followers_url":"https://api.github.com/users/linbo/followers","following_url":"https://api.github.com/users/linbo/following{/other_user}","gists_url":"https://api.github.com/users/linbo/gists{/gist_id}","starred_url":"https://api.github.com/users/linbo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linbo/subscriptions","organizations_url":"https://api.github.com/users/linbo/orgs","repos_url":"https://api.github.com/users/linbo/repos","events_url":"https://api.github.com/users/linbo/events{/privacy}","received_events_url":"https://api.github.com/users/linbo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-04-14T03:57:27Z","updated_at":"2015-04-14T04:19:27Z","closed_at":null,"body":"Hi,\r\n\r\nWe use poolboy to manage redis connection pool, in production environment find redis connection closed sometimes.  \r\n\r\nChecked code in [poolboy.erl line 275](https://github.com/devinus/poolboy/blob/master/src/poolboy.erl#L275),  find if new_worker failed, in our example, maybe redis start failed due to network error, it will cause poolboy crashed, all other existing redis connections will be closed.\r\n\r\nMaybe new_worker should deal with failed case, and shouldn't affect the other processes managed by poolboy. "},"comment":{"url":"https://api.github.com/repos/devinus/poolboy/issues/comments/92594448","html_url":"https://github.com/devinus/poolboy/issues/72#issuecomment-92594448","issue_url":"https://api.github.com/repos/devinus/poolboy/issues/72","id":92594448,"user":{"login":"devinus","id":4836,"avatar_url":"https://avatars.githubusercontent.com/u/4836?v=3","gravatar_id":"","url":"https://api.github.com/users/devinus","html_url":"https://github.com/devinus","followers_url":"https://api.github.com/users/devinus/followers","following_url":"https://api.github.com/users/devinus/following{/other_user}","gists_url":"https://api.github.com/users/devinus/gists{/gist_id}","starred_url":"https://api.github.com/users/devinus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devinus/subscriptions","organizations_url":"https://api.github.com/users/devinus/orgs","repos_url":"https://api.github.com/users/devinus/repos","events_url":"https://api.github.com/users/devinus/events{/privacy}","received_events_url":"https://api.github.com/users/devinus/received_events","type":"User","site_admin":false},"created_at":"2015-04-14T04:19:27Z","updated_at":"2015-04-14T04:19:27Z","body":"@linbo Add smarts to your worker to handle disconnects. This is not for the pool itself to handle. See https://github.com/interline/epgsql_pool/blob/master/src/epgsql_pool_worker.erl#L58 for inspiration."}}