{"action":"created","comment":{"url":"https://api.github.com/repos/18F/hub/pulls/comments/24261282","id":24261282,"diff_hunk":"@@ -0,0 +1,41 @@\n+svg.map {\n+  display: block;\n+  width: 100%;\n+  min-height: 400px;\n+  margin: 1em;\n+}\n+\n+svg.map .background path {","path":"assets/css/map.css","position":8,"original_position":8,"commit_id":"29214628feea39748535f8d3f49a6c6dd7258c3e","original_commit_id":"a84d86b62031fb43277a78ae384d80432990f289","user":{"login":"shawnbot","id":113896,"avatar_url":"https://avatars.githubusercontent.com/u/113896?v=3","gravatar_id":"","url":"https://api.github.com/users/shawnbot","html_url":"https://github.com/shawnbot","followers_url":"https://api.github.com/users/shawnbot/followers","following_url":"https://api.github.com/users/shawnbot/following{/other_user}","gists_url":"https://api.github.com/users/shawnbot/gists{/gist_id}","starred_url":"https://api.github.com/users/shawnbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shawnbot/subscriptions","organizations_url":"https://api.github.com/users/shawnbot/orgs","repos_url":"https://api.github.com/users/shawnbot/repos","events_url":"https://api.github.com/users/shawnbot/events{/privacy}","received_events_url":"https://api.github.com/users/shawnbot/received_events","type":"User","site_admin":false},"body":"No, the rest of the selectors are SVG-specific, though. So I figured `svg.map` made sense for \"grouping\" them.","created_at":"2015-02-06T18:41:36Z","updated_at":"2015-02-06T18:41:36Z","html_url":"https://github.com/18F/hub/pull/94#discussion_r24261282","pull_request_url":"https://api.github.com/repos/18F/hub/pulls/94","_links":{"self":{"href":"https://api.github.com/repos/18F/hub/pulls/comments/24261282"},"html":{"href":"https://github.com/18F/hub/pull/94#discussion_r24261282"},"pull_request":{"href":"https://api.github.com/repos/18F/hub/pulls/94"}}},"pull_request":{"url":"https://api.github.com/repos/18F/hub/pulls/94","id":28691376,"html_url":"https://github.com/18F/hub/pull/94","diff_url":"https://github.com/18F/hub/pull/94.diff","patch_url":"https://github.com/18F/hub/pull/94.patch","issue_url":"https://api.github.com/repos/18F/hub/issues/94","number":94,"state":"open","locked":false,"title":"Add team map to locations page","user":{"login":"shawnbot","id":113896,"avatar_url":"https://avatars.githubusercontent.com/u/113896?v=3","gravatar_id":"","url":"https://api.github.com/users/shawnbot","html_url":"https://github.com/shawnbot","followers_url":"https://api.github.com/users/shawnbot/followers","following_url":"https://api.github.com/users/shawnbot/following{/other_user}","gists_url":"https://api.github.com/users/shawnbot/gists{/gist_id}","starred_url":"https://api.github.com/users/shawnbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shawnbot/subscriptions","organizations_url":"https://api.github.com/users/shawnbot/orgs","repos_url":"https://api.github.com/users/shawnbot/repos","events_url":"https://api.github.com/users/shawnbot/events{/privacy}","received_events_url":"https://api.github.com/users/shawnbot/received_events","type":"User","site_admin":false},"body":"This PR introduces a team map to the `/locations/` page, and some conventions for per-page scripts and CSS. Namely, the head and scripts includes now look for `page.stylesheets` and `page.scripts`, respectively, and add the relevant `<link>` and `<script>` tags for each one. You can see this in action on the [locations page](https://github.com/18F/hub/blob/feature/team-map/pages/locations.html#L4-L9):\r\n\r\n```yaml\r\nscripts:\r\n- /assets/js/vendor/d3.v3.min.js\r\n- /assets/js/vendor/queue.v1.min.js\r\n- /assets/js/vendor/topojson.v1.min.js\r\n- /assets/js/map.js\r\nstylesheets:\r\n- /assets/css/map.css\r\n```\r\n\r\n[map.js](https://github.com/18F/hub/blob/feature/team-map/assets/js/map.js) then looks for `#team-map`, loads some [US states in TopoJSON](https://github.com/18F/hub/blob/feature/team-map/assets/data/us-states.json) and the team data from `/api/team/`, groups members by location (these are [hard-coded](https://github.com/18F/hub/blob/feature/team-map/assets/js/map.js#L9-L20)), and makes a map.\r\n\r\nEach location on the map is wrapped in an `<a>` that naïvely links to `/locations/{code}/`, some of which may not exist. We could eliminate the hard-coded locations by moving their coordinates and city names into a new YAML data file, and exposing that info in the `/api/locations/` endpoint. cc: @mbland","created_at":"2015-02-05T01:16:30Z","updated_at":"2015-02-06T18:41:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e61cc846756035c525bab600823aace49ff1e4e8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/18F/hub/pulls/94/commits","review_comments_url":"https://api.github.com/repos/18F/hub/pulls/94/comments","review_comment_url":"https://api.github.com/repos/18F/hub/pulls/comments/{number}","comments_url":"https://api.github.com/repos/18F/hub/issues/94/comments","statuses_url":"https://api.github.com/repos/18F/hub/statuses/29214628feea39748535f8d3f49a6c6dd7258c3e","head":{"label":"18F:feature/team-map","ref":"feature/team-map","sha":"29214628feea39748535f8d3f49a6c6dd7258c3e","user":{"login":"18F","id":6233994,"avatar_url":"https://avatars.githubusercontent.com/u/6233994?v=3","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"repo":{"id":27776551,"name":"hub","full_name":"18F/hub","owner":{"login":"18F","id":6233994,"avatar_url":"https://avatars.githubusercontent.com/u/6233994?v=3","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/18F/hub","description":"Documentation hub for the 18F team","fork":false,"url":"https://api.github.com/repos/18F/hub","forks_url":"https://api.github.com/repos/18F/hub/forks","keys_url":"https://api.github.com/repos/18F/hub/keys{/key_id}","collaborators_url":"https://api.github.com/repos/18F/hub/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/18F/hub/teams","hooks_url":"https://api.github.com/repos/18F/hub/hooks","issue_events_url":"https://api.github.com/repos/18F/hub/issues/events{/number}","events_url":"https://api.github.com/repos/18F/hub/events","assignees_url":"https://api.github.com/repos/18F/hub/assignees{/user}","branches_url":"https://api.github.com/repos/18F/hub/branches{/branch}","tags_url":"https://api.github.com/repos/18F/hub/tags","blobs_url":"https://api.github.com/repos/18F/hub/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/18F/hub/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/18F/hub/git/refs{/sha}","trees_url":"https://api.github.com/repos/18F/hub/git/trees{/sha}","statuses_url":"https://api.github.com/repos/18F/hub/statuses/{sha}","languages_url":"https://api.github.com/repos/18F/hub/languages","stargazers_url":"https://api.github.com/repos/18F/hub/stargazers","contributors_url":"https://api.github.com/repos/18F/hub/contributors","subscribers_url":"https://api.github.com/repos/18F/hub/subscribers","subscription_url":"https://api.github.com/repos/18F/hub/subscription","commits_url":"https://api.github.com/repos/18F/hub/commits{/sha}","git_commits_url":"https://api.github.com/repos/18F/hub/git/commits{/sha}","comments_url":"https://api.github.com/repos/18F/hub/comments{/number}","issue_comment_url":"https://api.github.com/repos/18F/hub/issues/comments/{number}","contents_url":"https://api.github.com/repos/18F/hub/contents/{+path}","compare_url":"https://api.github.com/repos/18F/hub/compare/{base}...{head}","merges_url":"https://api.github.com/repos/18F/hub/merges","archive_url":"https://api.github.com/repos/18F/hub/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/18F/hub/downloads","issues_url":"https://api.github.com/repos/18F/hub/issues{/number}","pulls_url":"https://api.github.com/repos/18F/hub/pulls{/number}","milestones_url":"https://api.github.com/repos/18F/hub/milestones{/number}","notifications_url":"https://api.github.com/repos/18F/hub/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/18F/hub/labels{/name}","releases_url":"https://api.github.com/repos/18F/hub/releases{/id}","created_at":"2014-12-09T16:48:37Z","updated_at":"2015-02-06T18:37:57Z","pushed_at":"2015-02-06T18:40:08Z","git_url":"git://github.com/18F/hub.git","ssh_url":"git@github.com:18F/hub.git","clone_url":"https://github.com/18F/hub.git","svn_url":"https://github.com/18F/hub","homepage":"https://18f.gsa.gov/hub/","size":5499,"stargazers_count":10,"watchers_count":10,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":24,"forks":9,"open_issues":24,"watchers":10,"default_branch":"master"}},"base":{"label":"18F:feature/clean-up-layouts","ref":"feature/clean-up-layouts","sha":"8fb1a0a2bebba92f91d976b91000e792daf8bb21","user":{"login":"18F","id":6233994,"avatar_url":"https://avatars.githubusercontent.com/u/6233994?v=3","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"repo":{"id":27776551,"name":"hub","full_name":"18F/hub","owner":{"login":"18F","id":6233994,"avatar_url":"https://avatars.githubusercontent.com/u/6233994?v=3","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/18F/hub","description":"Documentation hub for the 18F team","fork":false,"url":"https://api.github.com/repos/18F/hub","forks_url":"https://api.github.com/repos/18F/hub/forks","keys_url":"https://api.github.com/repos/18F/hub/keys{/key_id}","collaborators_url":"https://api.github.com/repos/18F/hub/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/18F/hub/teams","hooks_url":"https://api.github.com/repos/18F/hub/hooks","issue_events_url":"https://api.github.com/repos/18F/hub/issues/events{/number}","events_url":"https://api.github.com/repos/18F/hub/events","assignees_url":"https://api.github.com/repos/18F/hub/assignees{/user}","branches_url":"https://api.github.com/repos/18F/hub/branches{/branch}","tags_url":"https://api.github.com/repos/18F/hub/tags","blobs_url":"https://api.github.com/repos/18F/hub/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/18F/hub/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/18F/hub/git/refs{/sha}","trees_url":"https://api.github.com/repos/18F/hub/git/trees{/sha}","statuses_url":"https://api.github.com/repos/18F/hub/statuses/{sha}","languages_url":"https://api.github.com/repos/18F/hub/languages","stargazers_url":"https://api.github.com/repos/18F/hub/stargazers","contributors_url":"https://api.github.com/repos/18F/hub/contributors","subscribers_url":"https://api.github.com/repos/18F/hub/subscribers","subscription_url":"https://api.github.com/repos/18F/hub/subscription","commits_url":"https://api.github.com/repos/18F/hub/commits{/sha}","git_commits_url":"https://api.github.com/repos/18F/hub/git/commits{/sha}","comments_url":"https://api.github.com/repos/18F/hub/comments{/number}","issue_comment_url":"https://api.github.com/repos/18F/hub/issues/comments/{number}","contents_url":"https://api.github.com/repos/18F/hub/contents/{+path}","compare_url":"https://api.github.com/repos/18F/hub/compare/{base}...{head}","merges_url":"https://api.github.com/repos/18F/hub/merges","archive_url":"https://api.github.com/repos/18F/hub/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/18F/hub/downloads","issues_url":"https://api.github.com/repos/18F/hub/issues{/number}","pulls_url":"https://api.github.com/repos/18F/hub/pulls{/number}","milestones_url":"https://api.github.com/repos/18F/hub/milestones{/number}","notifications_url":"https://api.github.com/repos/18F/hub/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/18F/hub/labels{/name}","releases_url":"https://api.github.com/repos/18F/hub/releases{/id}","created_at":"2014-12-09T16:48:37Z","updated_at":"2015-02-06T18:37:57Z","pushed_at":"2015-02-06T18:40:08Z","git_url":"git://github.com/18F/hub.git","ssh_url":"git@github.com:18F/hub.git","clone_url":"https://github.com/18F/hub.git","svn_url":"https://github.com/18F/hub","homepage":"https://18f.gsa.gov/hub/","size":5499,"stargazers_count":10,"watchers_count":10,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":24,"forks":9,"open_issues":24,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/18F/hub/pulls/94"},"html":{"href":"https://github.com/18F/hub/pull/94"},"issue":{"href":"https://api.github.com/repos/18F/hub/issues/94"},"comments":{"href":"https://api.github.com/repos/18F/hub/issues/94/comments"},"review_comments":{"href":"https://api.github.com/repos/18F/hub/pulls/94/comments"},"review_comment":{"href":"https://api.github.com/repos/18F/hub/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/18F/hub/pulls/94/commits"},"statuses":{"href":"https://api.github.com/repos/18F/hub/statuses/29214628feea39748535f8d3f49a6c6dd7258c3e"}}}}