{"comment":{"url":"https://api.github.com/repos/nathanielherman/sto/comments/13852375","html_url":"https://github.com/nathanielherman/sto/commit/b296620f49d643b10e3fb270bcb2dabd375f6688#commitcomment-13852375","id":13852375,"user":{"login":"huangyihe","id":3239204,"avatar_url":"https://avatars.githubusercontent.com/u/3239204?v=3","gravatar_id":"","url":"https://api.github.com/users/huangyihe","html_url":"https://github.com/huangyihe","followers_url":"https://api.github.com/users/huangyihe/followers","following_url":"https://api.github.com/users/huangyihe/following{/other_user}","gists_url":"https://api.github.com/users/huangyihe/gists{/gist_id}","starred_url":"https://api.github.com/users/huangyihe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huangyihe/subscriptions","organizations_url":"https://api.github.com/users/huangyihe/orgs","repos_url":"https://api.github.com/users/huangyihe/repos","events_url":"https://api.github.com/users/huangyihe/events{/privacy}","received_events_url":"https://api.github.com/users/huangyihe/received_events","type":"User","site_admin":false},"position":25,"line":257,"path":"RBTree.hh","commit_id":"b296620f49d643b10e3fb270bcb2dabd375f6688","created_at":"2015-10-19T15:58:10Z","updated_at":"2015-10-19T15:58:10Z","body":"Wait I don't think we should return `item.write_value()` here; it will fail assertions if it's a read-only `operator[]`. It's actually fine to just return `x->writeable_value()` here because:\r\n1. If it's a write, then the caller doesn't care about the return value...\r\n2. If it's a read, then we are not overwriting the old value so it's also fine to return the node value directly (read-my-writes handled earlier I think?)"}}