{"action":"closed","number":7242,"pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/7242","id":38234107,"html_url":"https://github.com/joomla/joomla-cms/pull/7242","diff_url":"https://github.com/joomla/joomla-cms/pull/7242.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/7242.patch","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/7242","number":7242,"state":"closed","locked":false,"title":"Remove CSS rules for specific icons","user":{"login":"Bakual","id":1018684,"avatar_url":"https://avatars.githubusercontent.com/u/1018684?v=3","gravatar_id":"","url":"https://api.github.com/users/Bakual","html_url":"https://github.com/Bakual","followers_url":"https://api.github.com/users/Bakual/followers","following_url":"https://api.github.com/users/Bakual/following{/other_user}","gists_url":"https://api.github.com/users/Bakual/gists{/gist_id}","starred_url":"https://api.github.com/users/Bakual/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bakual/subscriptions","organizations_url":"https://api.github.com/users/Bakual/orgs","repos_url":"https://api.github.com/users/Bakual/repos","events_url":"https://api.github.com/users/Bakual/events{/privacy}","received_events_url":"https://api.github.com/users/Bakual/received_events","type":"User","site_admin":false},"body":"### Issue\r\nOur icomoon.less file contains some CSS rules which have no business in that file. The same CSS rules also are added to sprites.less where they even make less sense (we don't use that file at all) and in the bootstrap-rtl.less file.\r\nSince we generate our template CSS files based on the LESS files, those rules also are present in Hathor, Isis and Protostar template.css files.\r\n\r\nI saw this when I tried to update our media/jui/css/icomoon.css based on its media/jui/less/icomoon.less file as it was badly out of sync.\r\n\r\nAfter investigating I found that it was introduced with #5512 (which is based on #4372). That PR did apply those rules wrongly in the icomoon.less file, when it should have been done in the template.less file for Protostar instead.\r\nNext step was to figure out what the rules are effectively doing, and I found that they can be safely removed. I guess this is something which eventually got fixed elsewhere as well, making those rules unneeded.\r\n\r\nThis PR proposes to remove the following CSS rules quite specific to certain icon useage from the global LESS files.\r\n````\r\ndd > span[class^=\"icon-\"] + time,\r\ndd > span[class*=\" icon-\"] + time{\r\n\tmargin-left: -.25em;\r\n}\r\ndl.article-info dd.hits span[class^=\"icon-\"],\r\ndl.article-info dd.hits span[class*=\" icon-\"]{\r\n\tmargin-right: 0;\r\n}\r\n````\r\nThere is only a small difference in the spacing however since it's the same space for all icons I don't see an issue.\r\nCurrently:\r\n![before](https://cloud.githubusercontent.com/assets/1018684/8283156/c0a33cba-18f5-11e5-9430-db4b6b6095bb.PNG)\r\nAfter:\r\n![after](https://cloud.githubusercontent.com/assets/1018684/8283165/d587371c-18f5-11e5-8f5d-433871e12c2a.PNG)\r\nThat being said, in RTL it looks currently like this:\r\n![rtl-before](https://cloud.githubusercontent.com/assets/1018684/8283169/e26c4d14-18f5-11e5-8158-67786c17275c.PNG)\r\nand with my PR:\r\n![rtl-after](https://cloud.githubusercontent.com/assets/1018684/8283170/e73d20d4-18f5-11e5-980e-d1b130b92026.PNG)\r\n\r\n### Testing\r\nThe only place where I found this rules being active is the \"Article Details\" section in frontend. One rule targets the calendar type entries (`<time>` tags) , the other is the hits icon.\r\nI couldn't find any use of it in the backend, so Isis and Hathor should be unaffected..\r\n\r\n### Backward Compatibility\r\nAs that file is surely is used by some 3rd party templates, it will change the spacing there as well as soon as the template.css is generated again from LESS. Which usually is when the template provided creates a new release. Other than that, nothing will \"break\".","created_at":"2015-06-22T13:58:16Z","updated_at":"2015-07-09T20:04:22Z","closed_at":"2015-07-09T20:04:22Z","merged_at":null,"merge_commit_sha":"62974ec37b43540a89159b3dc50700ee2afef372","assignee":null,"milestone":{"url":"https://api.github.com/repos/joomla/joomla-cms/milestones/10","html_url":"https://github.com/joomla/joomla-cms/milestones/Joomla!%203.4.4","labels_url":"https://api.github.com/repos/joomla/joomla-cms/milestones/10/labels","id":1190334,"number":10,"title":"Joomla! 3.4.4","description":"","creator":{"login":"zero-24","id":2596554,"avatar_url":"https://avatars.githubusercontent.com/u/2596554?v=3","gravatar_id":"","url":"https://api.github.com/users/zero-24","html_url":"https://github.com/zero-24","followers_url":"https://api.github.com/users/zero-24/followers","following_url":"https://api.github.com/users/zero-24/following{/other_user}","gists_url":"https://api.github.com/users/zero-24/gists{/gist_id}","starred_url":"https://api.github.com/users/zero-24/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zero-24/subscriptions","organizations_url":"https://api.github.com/users/zero-24/orgs","repos_url":"https://api.github.com/users/zero-24/repos","events_url":"https://api.github.com/users/zero-24/events{/privacy}","received_events_url":"https://api.github.com/users/zero-24/received_events","type":"User","site_admin":false},"open_issues":20,"closed_issues":46,"state":"open","created_at":"2015-07-02T09:44:31Z","updated_at":"2015-07-09T20:04:22Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/7242/commits","review_comments_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/7242/comments","review_comment_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/7242/comments","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/a5edf0f71518a997ad073e23ca9ca9d84cc27bda","head":{"label":"Bakual:RemoveIconSpecificCSS2","ref":"RemoveIconSpecificCSS2","sha":"a5edf0f71518a997ad073e23ca9ca9d84cc27bda","user":{"login":"Bakual","id":1018684,"avatar_url":"https://avatars.githubusercontent.com/u/1018684?v=3","gravatar_id":"","url":"https://api.github.com/users/Bakual","html_url":"https://github.com/Bakual","followers_url":"https://api.github.com/users/Bakual/followers","following_url":"https://api.github.com/users/Bakual/following{/other_user}","gists_url":"https://api.github.com/users/Bakual/gists{/gist_id}","starred_url":"https://api.github.com/users/Bakual/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bakual/subscriptions","organizations_url":"https://api.github.com/users/Bakual/orgs","repos_url":"https://api.github.com/users/Bakual/repos","events_url":"https://api.github.com/users/Bakual/events{/privacy}","received_events_url":"https://api.github.com/users/Bakual/received_events","type":"User","site_admin":false},"repo":{"id":5132763,"name":"joomla-cms","full_name":"Bakual/joomla-cms","owner":{"login":"Bakual","id":1018684,"avatar_url":"https://avatars.githubusercontent.com/u/1018684?v=3","gravatar_id":"","url":"https://api.github.com/users/Bakual","html_url":"https://github.com/Bakual","followers_url":"https://api.github.com/users/Bakual/followers","following_url":"https://api.github.com/users/Bakual/following{/other_user}","gists_url":"https://api.github.com/users/Bakual/gists{/gist_id}","starred_url":"https://api.github.com/users/Bakual/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bakual/subscriptions","organizations_url":"https://api.github.com/users/Bakual/orgs","repos_url":"https://api.github.com/users/Bakual/repos","events_url":"https://api.github.com/users/Bakual/events{/privacy}","received_events_url":"https://api.github.com/users/Bakual/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Bakual/joomla-cms","description":"Home of the Joomla! Content Management System","fork":true,"url":"https://api.github.com/repos/Bakual/joomla-cms","forks_url":"https://api.github.com/repos/Bakual/joomla-cms/forks","keys_url":"https://api.github.com/repos/Bakual/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Bakual/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Bakual/joomla-cms/teams","hooks_url":"https://api.github.com/repos/Bakual/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/Bakual/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/Bakual/joomla-cms/events","assignees_url":"https://api.github.com/repos/Bakual/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/Bakual/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/Bakual/joomla-cms/tags","blobs_url":"https://api.github.com/repos/Bakual/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Bakual/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Bakual/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/Bakual/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Bakual/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/Bakual/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/Bakual/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/Bakual/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/Bakual/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/Bakual/joomla-cms/subscription","commits_url":"https://api.github.com/repos/Bakual/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/Bakual/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/Bakual/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/Bakual/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/Bakual/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/Bakual/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Bakual/joomla-cms/merges","archive_url":"https://api.github.com/repos/Bakual/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Bakual/joomla-cms/downloads","issues_url":"https://api.github.com/repos/Bakual/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/Bakual/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/Bakual/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/Bakual/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Bakual/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/Bakual/joomla-cms/releases{/id}","created_at":"2012-07-21T10:15:11Z","updated_at":"2015-07-02T09:18:18Z","pushed_at":"2015-07-09T14:23:40Z","git_url":"git://github.com/Bakual/joomla-cms.git","ssh_url":"git@github.com:Bakual/joomla-cms.git","clone_url":"https://github.com/Bakual/joomla-cms.git","svn_url":"https://github.com/Bakual/joomla-cms","homepage":"http://joomla.org","size":132334,"stargazers_count":2,"watchers_count":2,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":2,"default_branch":"staging"}},"base":{"label":"joomla:staging","ref":"staging","sha":"d6f6cc45c199922811d46f3feffec9a6a309f74d","user":{"login":"joomla","id":751633,"avatar_url":"https://avatars.githubusercontent.com/u/751633?v=3","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"repo":{"id":2464908,"name":"joomla-cms","full_name":"joomla/joomla-cms","owner":{"login":"joomla","id":751633,"avatar_url":"https://avatars.githubusercontent.com/u/751633?v=3","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/joomla/joomla-cms","description":"Home of the Joomla! Content Management System","fork":false,"url":"https://api.github.com/repos/joomla/joomla-cms","forks_url":"https://api.github.com/repos/joomla/joomla-cms/forks","keys_url":"https://api.github.com/repos/joomla/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joomla/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joomla/joomla-cms/teams","hooks_url":"https://api.github.com/repos/joomla/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/joomla/joomla-cms/events","assignees_url":"https://api.github.com/repos/joomla/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/joomla/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/joomla/joomla-cms/tags","blobs_url":"https://api.github.com/repos/joomla/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joomla/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joomla/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/joomla/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/joomla/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/joomla/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/joomla/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/joomla/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/joomla/joomla-cms/subscription","commits_url":"https://api.github.com/repos/joomla/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/joomla/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/joomla/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/joomla/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joomla/joomla-cms/merges","archive_url":"https://api.github.com/repos/joomla/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joomla/joomla-cms/downloads","issues_url":"https://api.github.com/repos/joomla/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/joomla/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/joomla/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/joomla/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joomla/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/joomla/joomla-cms/releases{/id}","created_at":"2011-09-27T02:07:38Z","updated_at":"2015-07-09T12:31:01Z","pushed_at":"2015-07-09T20:03:47Z","git_url":"git://github.com/joomla/joomla-cms.git","ssh_url":"git@github.com:joomla/joomla-cms.git","clone_url":"https://github.com/joomla/joomla-cms.git","svn_url":"https://github.com/joomla/joomla-cms","homepage":"http://joomla.org","size":327583,"stargazers_count":1600,"watchers_count":1600,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1776,"mirror_url":null,"open_issues_count":562,"forks":1776,"open_issues":562,"watchers":1600,"default_branch":"staging"}},"_links":{"self":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/7242"},"html":{"href":"https://github.com/joomla/joomla-cms/pull/7242"},"issue":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/7242"},"comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/7242/comments"},"review_comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/7242/comments"},"review_comment":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/7242/commits"},"statuses":{"href":"https://api.github.com/repos/joomla/joomla-cms/statuses/a5edf0f71518a997ad073e23ca9ca9d84cc27bda"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":14,"review_comments":0,"commits":1,"additions":0,"deletions":74,"changed_files":8}}