{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/37370208","id":37370208,"diff_hunk":"@@ -0,0 +1,53 @@\n+apiVersion: v1\n+kind: ReplicationController\n+metadata:\n+  name: kube-registry-v0\n+  namespace: kube-system\n+  labels:\n+    k8s-app: kube-registry\n+    version: v0\n+    kubernetes.io/cluster-service: \"true\"\n+spec:\n+  replicas: 1\n+  selector:\n+    k8s-app: kube-registry\n+    version: v0\n+  template:\n+    metadata:\n+      labels:\n+        k8s-app: kube-registry\n+        version: v0\n+        kubernetes.io/cluster-service: \"true\"\n+    spec:\n+      containers:\n+      - name: registry\n+        image: registry:2\n+        resources:\n+          limits:\n+            cpu: 100m\n+            memory: 100Mi\n+        env:\n+        - name: REGISTRY_HTTP_ADDR\n+          value: :5000\n+        - name: REGISTRY_STORAGE_FILESYSTEM_ROOTDIRECTORY\n+          value: /var/lib/registry\n+        volumeMounts:\n+        - name: image-store\n+          mountPath: /var/lib/registry\n+        ports:\n+        - containerPort: 5000\n+          name: registry\n+          protocol: TCP\n+      # TODO: use a persistent volume claim\n+      volumes:\n+      - name: image-store\n+      {%- if pillar.get('cluster_registry_disk', '') != '' -%}","path":"cluster/addons/registry/registry-rc.yaml.in","position":44,"original_position":44,"commit_id":"b8b5b2c14ada082222a763635d336f2273004334","original_commit_id":"b8b5b2c14ada082222a763635d336f2273004334","user":{"login":"thockin","id":5595220,"avatar_url":"https://avatars.githubusercontent.com/u/5595220?v=3","gravatar_id":"","url":"https://api.github.com/users/thockin","html_url":"https://github.com/thockin","followers_url":"https://api.github.com/users/thockin/followers","following_url":"https://api.github.com/users/thockin/following{/other_user}","gists_url":"https://api.github.com/users/thockin/gists{/gist_id}","starred_url":"https://api.github.com/users/thockin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thockin/subscriptions","organizations_url":"https://api.github.com/users/thockin/orgs","repos_url":"https://api.github.com/users/thockin/repos","events_url":"https://api.github.com/users/thockin/events{/privacy}","received_events_url":"https://api.github.com/users/thockin/received_events","type":"User","site_admin":false},"body":"The right way to do this would be to create a PV backed by this registry disk, then a claim that would ostensibly be satisfied by that PV, then reference the claim here.  \r\n\r\nIt might be worth trying to do it \"right\" to see how much harder it is.","created_at":"2015-08-19T00:41:38Z","updated_at":"2015-08-19T00:41:38Z","html_url":"https://github.com/kubernetes/kubernetes/pull/12833#discussion_r37370208","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/12833","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/37370208"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/12833#discussion_r37370208"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/12833"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/12833","id":42647183,"html_url":"https://github.com/kubernetes/kubernetes/pull/12833","diff_url":"https://github.com/kubernetes/kubernetes/pull/12833.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/12833.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/12833","number":12833,"state":"open","locked":false,"title":"Launch a cluster-local registry.","user":{"login":"uluyol","id":4128872,"avatar_url":"https://avatars.githubusercontent.com/u/4128872?v=3","gravatar_id":"","url":"https://api.github.com/users/uluyol","html_url":"https://github.com/uluyol","followers_url":"https://api.github.com/users/uluyol/followers","following_url":"https://api.github.com/users/uluyol/following{/other_user}","gists_url":"https://api.github.com/users/uluyol/gists{/gist_id}","starred_url":"https://api.github.com/users/uluyol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uluyol/subscriptions","organizations_url":"https://api.github.com/users/uluyol/orgs","repos_url":"https://api.github.com/users/uluyol/repos","events_url":"https://api.github.com/users/uluyol/events{/privacy}","received_events_url":"https://api.github.com/users/uluyol/received_events","type":"User","site_admin":false},"body":"This registry can be accessed through proxies that run on each node listening on port 5000. We send the proxy images to the nodes directly to avoid requests that hit the network during cluster launch. For now, we continue to pull the registry itself over the network, especially given its large size (we should be able to dramatically shrink the image). On GCE we create a PD and use that for storage, otherwise we use an emptyDir. The registry is not enabled outside of GCE. All communication is currently plain HTTP. In order to use SSL, we will need to be able to request a certificate/key from the apiserver signed by the apiserver's CA cert.\r\n\r\n@thockin","created_at":"2015-08-17T23:44:35Z","updated_at":"2015-08-19T00:41:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e1578d9063c0bae997abde4094b44e4d68f7352c","assignee":{"login":"thockin","id":5595220,"avatar_url":"https://avatars.githubusercontent.com/u/5595220?v=3","gravatar_id":"","url":"https://api.github.com/users/thockin","html_url":"https://github.com/thockin","followers_url":"https://api.github.com/users/thockin/followers","following_url":"https://api.github.com/users/thockin/following{/other_user}","gists_url":"https://api.github.com/users/thockin/gists{/gist_id}","starred_url":"https://api.github.com/users/thockin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thockin/subscriptions","organizations_url":"https://api.github.com/users/thockin/orgs","repos_url":"https://api.github.com/users/thockin/repos","events_url":"https://api.github.com/users/thockin/events{/privacy}","received_events_url":"https://api.github.com/users/thockin/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/12833/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/12833/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/12833/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/b8b5b2c14ada082222a763635d336f2273004334","head":{"label":"uluyol:insecure-reg","ref":"insecure-reg","sha":"b8b5b2c14ada082222a763635d336f2273004334","user":{"login":"uluyol","id":4128872,"avatar_url":"https://avatars.githubusercontent.com/u/4128872?v=3","gravatar_id":"","url":"https://api.github.com/users/uluyol","html_url":"https://github.com/uluyol","followers_url":"https://api.github.com/users/uluyol/followers","following_url":"https://api.github.com/users/uluyol/following{/other_user}","gists_url":"https://api.github.com/users/uluyol/gists{/gist_id}","starred_url":"https://api.github.com/users/uluyol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uluyol/subscriptions","organizations_url":"https://api.github.com/users/uluyol/orgs","repos_url":"https://api.github.com/users/uluyol/repos","events_url":"https://api.github.com/users/uluyol/events{/privacy}","received_events_url":"https://api.github.com/users/uluyol/received_events","type":"User","site_admin":false},"repo":{"id":36756702,"name":"kubernetes","full_name":"uluyol/kubernetes","owner":{"login":"uluyol","id":4128872,"avatar_url":"https://avatars.githubusercontent.com/u/4128872?v=3","gravatar_id":"","url":"https://api.github.com/users/uluyol","html_url":"https://github.com/uluyol","followers_url":"https://api.github.com/users/uluyol/followers","following_url":"https://api.github.com/users/uluyol/following{/other_user}","gists_url":"https://api.github.com/users/uluyol/gists{/gist_id}","starred_url":"https://api.github.com/users/uluyol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uluyol/subscriptions","organizations_url":"https://api.github.com/users/uluyol/orgs","repos_url":"https://api.github.com/users/uluyol/repos","events_url":"https://api.github.com/users/uluyol/events{/privacy}","received_events_url":"https://api.github.com/users/uluyol/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/uluyol/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/uluyol/kubernetes","forks_url":"https://api.github.com/repos/uluyol/kubernetes/forks","keys_url":"https://api.github.com/repos/uluyol/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uluyol/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uluyol/kubernetes/teams","hooks_url":"https://api.github.com/repos/uluyol/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/uluyol/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/uluyol/kubernetes/events","assignees_url":"https://api.github.com/repos/uluyol/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/uluyol/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/uluyol/kubernetes/tags","blobs_url":"https://api.github.com/repos/uluyol/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uluyol/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uluyol/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/uluyol/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uluyol/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/uluyol/kubernetes/languages","stargazers_url":"https://api.github.com/repos/uluyol/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/uluyol/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/uluyol/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/uluyol/kubernetes/subscription","commits_url":"https://api.github.com/repos/uluyol/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/uluyol/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/uluyol/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/uluyol/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/uluyol/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/uluyol/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uluyol/kubernetes/merges","archive_url":"https://api.github.com/repos/uluyol/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uluyol/kubernetes/downloads","issues_url":"https://api.github.com/repos/uluyol/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/uluyol/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/uluyol/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/uluyol/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uluyol/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/uluyol/kubernetes/releases{/id}","created_at":"2015-06-02T19:30:19Z","updated_at":"2015-06-02T19:30:24Z","pushed_at":"2015-08-18T21:29:36Z","git_url":"git://github.com/uluyol/kubernetes.git","ssh_url":"git@github.com:uluyol/kubernetes.git","clone_url":"https://github.com/uluyol/kubernetes.git","svn_url":"https://github.com/uluyol/kubernetes","homepage":"http://kubernetes.io","size":100917,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"736945faba87b40dfc29dac790b389b070c26718","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","created_at":"2014-06-06T22:56:04Z","updated_at":"2015-08-18T23:08:28Z","pushed_at":"2015-08-19T00:41:38Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":351193,"stargazers_count":9764,"watchers_count":9764,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2348,"mirror_url":null,"open_issues_count":1792,"forks":2348,"open_issues":1792,"watchers":9764,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/12833"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/12833"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/12833"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/12833/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/12833/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/12833/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/b8b5b2c14ada082222a763635d336f2273004334"}}}}