{"action":"created","comment":{"url":"https://api.github.com/repos/ethereum/ethash/pulls/comments/29143709","id":29143709,"diff_hunk":"@@ -168,31 +150,30 @@ ethash_cache* ethash_light_get_cache(ethash_light_t light);\n  *                 After this function concludes it will no longer have a cache.\n  * @return         A pointer to the moved cache or NULL if there was no cache in the first place\n  */\n-ethash_cache* ethash_light_acquire_cache(ethash_light_t light);\n+ethash_cache_t* ethash_light_acquire_cache(ethash_light_t light);\n \n /**\n  * Allocate and initialize a new ethash_full handler\n  *\n- * @param dirname   The directory in which to put the DAG file.\n- * @param seedhash  The seed hash of the block. Used in the DAG file naming.\n- * @param params    The parameters to initialize it with. We are interested in\n- *                  the full_size from here\n- * @param cache     A cache object to use that was allocated with @ref ethash_cache_new().\n- *                  Iff this function succeeds the ethash_full_t will take memory\n- *                  ownership of the cache and free it at deletion. If not then the user\n- *                  still has to handle freeing of the cache himself.\n- * @param callback  A callback function with signature of @ref ethash_callback_t\n- *                  It accepts an unsigned with which a progress of DAG calculation\n- *                  can be displayed. If all goes well the callback should return 0.\n- *                  If a non-zero value is returned then DAG generation will stop.\n- * @return          Newly allocated ethash_full handler or NULL in case of\n- *                  ERRNOMEM or invalid parameters used for @ref ethash_compute_full_data()\n+ * @param dirname        The directory in which to put the DAG file.\n+ * @param seedhash       The seed hash of the block. Used in the DAG file naming.\n+ * @param full_size      The size of the full data in bytes.\n+ * @param cache          A cache object to use that was allocated with @ref ethash_cache_new().\n+ *                       Iff this function succeeds the ethash_full_t will take memory\n+ *                       memory ownership of the cache and free it at deletion. If\n+ *                       not then the user still has to handle freeing of the cache himself.\n+ * @param callback       A callback function with signature of @ref ethash_callback_t\n+ *                       It accepts an unsigned with which a progress of DAG calculation\n+ *                       can be displayed. If all goes well the callback should return 0.\n+ *                       If a non-zero value is returned then DAG generation will stop.\n+ * @return               Newly allocated ethash_full handler or NULL in case of\n+ *                       ERRNOMEM or invalid parameters used for @ref ethash_compute_full_data()\n  */\n ethash_full_t ethash_full_new(\n \tchar const* dirname,\n \tethash_h256_t const* seed_hash,","path":"src/libethash/ethash.h","position":158,"original_position":158,"commit_id":"c8215f1ba9a1b40d7a28dd6e4e303c2bb61d90fd","original_commit_id":"cd4a47c0200433cb48447d49944e3ba74d06729b","user":{"login":"gavofyork","id":138296,"avatar_url":"https://avatars.githubusercontent.com/u/138296?v=3","gravatar_id":"","url":"https://api.github.com/users/gavofyork","html_url":"https://github.com/gavofyork","followers_url":"https://api.github.com/users/gavofyork/followers","following_url":"https://api.github.com/users/gavofyork/following{/other_user}","gists_url":"https://api.github.com/users/gavofyork/gists{/gist_id}","starred_url":"https://api.github.com/users/gavofyork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gavofyork/subscriptions","organizations_url":"https://api.github.com/users/gavofyork/orgs","repos_url":"https://api.github.com/users/gavofyork/repos","events_url":"https://api.github.com/users/gavofyork/events{/privacy}","received_events_url":"https://api.github.com/users/gavofyork/received_events","type":"User","site_admin":false},"body":"meh. no point having two.","created_at":"2015-04-27T13:04:47Z","updated_at":"2015-04-27T13:04:47Z","html_url":"https://github.com/ethereum/ethash/pull/41#discussion_r29143709","pull_request_url":"https://api.github.com/repos/ethereum/ethash/pulls/41","_links":{"self":{"href":"https://api.github.com/repos/ethereum/ethash/pulls/comments/29143709"},"html":{"href":"https://github.com/ethereum/ethash/pull/41#discussion_r29143709"},"pull_request":{"href":"https://api.github.com/repos/ethereum/ethash/pulls/41"}}},"pull_request":{"url":"https://api.github.com/repos/ethereum/ethash/pulls/41","id":33775668,"html_url":"https://github.com/ethereum/ethash/pull/41","diff_url":"https://github.com/ethereum/ethash/pull/41.diff","patch_url":"https://github.com/ethereum/ethash/pull/41.patch","issue_url":"https://api.github.com/repos/ethereum/ethash/issues/41","number":41,"state":"open","locked":false,"title":"Finalize and use new api","user":{"login":"LefterisJP","id":1658405,"avatar_url":"https://avatars.githubusercontent.com/u/1658405?v=3","gravatar_id":"","url":"https://api.github.com/users/LefterisJP","html_url":"https://github.com/LefterisJP","followers_url":"https://api.github.com/users/LefterisJP/followers","following_url":"https://api.github.com/users/LefterisJP/following{/other_user}","gists_url":"https://api.github.com/users/LefterisJP/gists{/gist_id}","starred_url":"https://api.github.com/users/LefterisJP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LefterisJP/subscriptions","organizations_url":"https://api.github.com/users/LefterisJP/orgs","repos_url":"https://api.github.com/users/LefterisJP/repos","events_url":"https://api.github.com/users/LefterisJP/events{/privacy}","received_events_url":"https://api.github.com/users/LefterisJP/received_events","type":"User","site_admin":false},"body":"This PR needs a thumbs up by both @obscuren and @gavofyork in order to be merged. \r\n\r\n### Addresses\r\n+ Big step towards finalization of the new API\r\n+ Rewritting of the go bridge with help from @fjl \r\n+ Addition of Go tests to Travis\r\n\r\n### Breaks\r\n+ This will break the python wrapper. Should be addressed in a separate PR.\r\n+ before pulling into cpp-ethereum minor changes in ethasher would be needed\r\n\r\n### Defers for later\r\n+ Better syncronization strategy for the freeing of the DAG in the GO bridge. @fjl and/or I can probably address this in a subsequent PR.\r\n+ More tests for the GO bridge","created_at":"2015-04-21T15:53:56Z","updated_at":"2015-04-27T13:04:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d626c2aaa302fb9b3e2b53d155bc1a60d5a67c5d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ethereum/ethash/pulls/41/commits","review_comments_url":"https://api.github.com/repos/ethereum/ethash/pulls/41/comments","review_comment_url":"https://api.github.com/repos/ethereum/ethash/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ethereum/ethash/issues/41/comments","statuses_url":"https://api.github.com/repos/ethereum/ethash/statuses/c8215f1ba9a1b40d7a28dd6e4e303c2bb61d90fd","head":{"label":"LefterisJP:finalize_and_use_new_api","ref":"finalize_and_use_new_api","sha":"c8215f1ba9a1b40d7a28dd6e4e303c2bb61d90fd","user":{"login":"LefterisJP","id":1658405,"avatar_url":"https://avatars.githubusercontent.com/u/1658405?v=3","gravatar_id":"","url":"https://api.github.com/users/LefterisJP","html_url":"https://github.com/LefterisJP","followers_url":"https://api.github.com/users/LefterisJP/followers","following_url":"https://api.github.com/users/LefterisJP/following{/other_user}","gists_url":"https://api.github.com/users/LefterisJP/gists{/gist_id}","starred_url":"https://api.github.com/users/LefterisJP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LefterisJP/subscriptions","organizations_url":"https://api.github.com/users/LefterisJP/orgs","repos_url":"https://api.github.com/users/LefterisJP/repos","events_url":"https://api.github.com/users/LefterisJP/events{/privacy}","received_events_url":"https://api.github.com/users/LefterisJP/received_events","type":"User","site_admin":false},"repo":{"id":32791356,"name":"ethash","full_name":"LefterisJP/ethash","owner":{"login":"LefterisJP","id":1658405,"avatar_url":"https://avatars.githubusercontent.com/u/1658405?v=3","gravatar_id":"","url":"https://api.github.com/users/LefterisJP","html_url":"https://github.com/LefterisJP","followers_url":"https://api.github.com/users/LefterisJP/followers","following_url":"https://api.github.com/users/LefterisJP/following{/other_user}","gists_url":"https://api.github.com/users/LefterisJP/gists{/gist_id}","starred_url":"https://api.github.com/users/LefterisJP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LefterisJP/subscriptions","organizations_url":"https://api.github.com/users/LefterisJP/orgs","repos_url":"https://api.github.com/users/LefterisJP/repos","events_url":"https://api.github.com/users/LefterisJP/events{/privacy}","received_events_url":"https://api.github.com/users/LefterisJP/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/LefterisJP/ethash","description":"","fork":true,"url":"https://api.github.com/repos/LefterisJP/ethash","forks_url":"https://api.github.com/repos/LefterisJP/ethash/forks","keys_url":"https://api.github.com/repos/LefterisJP/ethash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LefterisJP/ethash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LefterisJP/ethash/teams","hooks_url":"https://api.github.com/repos/LefterisJP/ethash/hooks","issue_events_url":"https://api.github.com/repos/LefterisJP/ethash/issues/events{/number}","events_url":"https://api.github.com/repos/LefterisJP/ethash/events","assignees_url":"https://api.github.com/repos/LefterisJP/ethash/assignees{/user}","branches_url":"https://api.github.com/repos/LefterisJP/ethash/branches{/branch}","tags_url":"https://api.github.com/repos/LefterisJP/ethash/tags","blobs_url":"https://api.github.com/repos/LefterisJP/ethash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LefterisJP/ethash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LefterisJP/ethash/git/refs{/sha}","trees_url":"https://api.github.com/repos/LefterisJP/ethash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LefterisJP/ethash/statuses/{sha}","languages_url":"https://api.github.com/repos/LefterisJP/ethash/languages","stargazers_url":"https://api.github.com/repos/LefterisJP/ethash/stargazers","contributors_url":"https://api.github.com/repos/LefterisJP/ethash/contributors","subscribers_url":"https://api.github.com/repos/LefterisJP/ethash/subscribers","subscription_url":"https://api.github.com/repos/LefterisJP/ethash/subscription","commits_url":"https://api.github.com/repos/LefterisJP/ethash/commits{/sha}","git_commits_url":"https://api.github.com/repos/LefterisJP/ethash/git/commits{/sha}","comments_url":"https://api.github.com/repos/LefterisJP/ethash/comments{/number}","issue_comment_url":"https://api.github.com/repos/LefterisJP/ethash/issues/comments{/number}","contents_url":"https://api.github.com/repos/LefterisJP/ethash/contents/{+path}","compare_url":"https://api.github.com/repos/LefterisJP/ethash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LefterisJP/ethash/merges","archive_url":"https://api.github.com/repos/LefterisJP/ethash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LefterisJP/ethash/downloads","issues_url":"https://api.github.com/repos/LefterisJP/ethash/issues{/number}","pulls_url":"https://api.github.com/repos/LefterisJP/ethash/pulls{/number}","milestones_url":"https://api.github.com/repos/LefterisJP/ethash/milestones{/number}","notifications_url":"https://api.github.com/repos/LefterisJP/ethash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LefterisJP/ethash/labels{/name}","releases_url":"https://api.github.com/repos/LefterisJP/ethash/releases{/id}","created_at":"2015-03-24T10:20:51Z","updated_at":"2015-04-20T08:54:26Z","pushed_at":"2015-04-27T11:52:35Z","git_url":"git://github.com/LefterisJP/ethash.git","ssh_url":"git@github.com:LefterisJP/ethash.git","clone_url":"https://github.com/LefterisJP/ethash.git","svn_url":"https://github.com/LefterisJP/ethash","homepage":null,"size":1589,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ethereum:master","ref":"master","sha":"c2dc1bf594536bc221a302af0bff05e9988dadf0","user":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars.githubusercontent.com/u/6250754?v=3","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"repo":{"id":30313032,"name":"ethash","full_name":"ethereum/ethash","owner":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars.githubusercontent.com/u/6250754?v=3","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ethereum/ethash","description":"","fork":false,"url":"https://api.github.com/repos/ethereum/ethash","forks_url":"https://api.github.com/repos/ethereum/ethash/forks","keys_url":"https://api.github.com/repos/ethereum/ethash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereum/ethash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereum/ethash/teams","hooks_url":"https://api.github.com/repos/ethereum/ethash/hooks","issue_events_url":"https://api.github.com/repos/ethereum/ethash/issues/events{/number}","events_url":"https://api.github.com/repos/ethereum/ethash/events","assignees_url":"https://api.github.com/repos/ethereum/ethash/assignees{/user}","branches_url":"https://api.github.com/repos/ethereum/ethash/branches{/branch}","tags_url":"https://api.github.com/repos/ethereum/ethash/tags","blobs_url":"https://api.github.com/repos/ethereum/ethash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereum/ethash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereum/ethash/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereum/ethash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereum/ethash/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereum/ethash/languages","stargazers_url":"https://api.github.com/repos/ethereum/ethash/stargazers","contributors_url":"https://api.github.com/repos/ethereum/ethash/contributors","subscribers_url":"https://api.github.com/repos/ethereum/ethash/subscribers","subscription_url":"https://api.github.com/repos/ethereum/ethash/subscription","commits_url":"https://api.github.com/repos/ethereum/ethash/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereum/ethash/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereum/ethash/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereum/ethash/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethereum/ethash/contents/{+path}","compare_url":"https://api.github.com/repos/ethereum/ethash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereum/ethash/merges","archive_url":"https://api.github.com/repos/ethereum/ethash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereum/ethash/downloads","issues_url":"https://api.github.com/repos/ethereum/ethash/issues{/number}","pulls_url":"https://api.github.com/repos/ethereum/ethash/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereum/ethash/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereum/ethash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereum/ethash/labels{/name}","releases_url":"https://api.github.com/repos/ethereum/ethash/releases{/id}","created_at":"2015-02-04T18:02:45Z","updated_at":"2015-04-18T17:37:17Z","pushed_at":"2015-04-27T11:52:35Z","git_url":"git://github.com/ethereum/ethash.git","ssh_url":"git@github.com:ethereum/ethash.git","clone_url":"https://github.com/ethereum/ethash.git","svn_url":"https://github.com/ethereum/ethash","homepage":null,"size":2567,"stargazers_count":8,"watchers_count":8,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":6,"forks":15,"open_issues":6,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ethereum/ethash/pulls/41"},"html":{"href":"https://github.com/ethereum/ethash/pull/41"},"issue":{"href":"https://api.github.com/repos/ethereum/ethash/issues/41"},"comments":{"href":"https://api.github.com/repos/ethereum/ethash/issues/41/comments"},"review_comments":{"href":"https://api.github.com/repos/ethereum/ethash/pulls/41/comments"},"review_comment":{"href":"https://api.github.com/repos/ethereum/ethash/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ethereum/ethash/pulls/41/commits"},"statuses":{"href":"https://api.github.com/repos/ethereum/ethash/statuses/c8215f1ba9a1b40d7a28dd6e4e303c2bb61d90fd"}}}}