{"action":"created","issue":{"url":"https://api.github.com/repos/rapid7/recog/issues/30","labels_url":"https://api.github.com/repos/rapid7/recog/issues/30/labels{/name}","comments_url":"https://api.github.com/repos/rapid7/recog/issues/30/comments","events_url":"https://api.github.com/repos/rapid7/recog/issues/30/events","html_url":"https://github.com/rapid7/recog/pull/30","id":58057556,"number":30,"title":"Add initial MySQL banner support","user":{"login":"TomSellers","id":6500426,"avatar_url":"https://avatars.githubusercontent.com/u/6500426?v=3","gravatar_id":"","url":"https://api.github.com/users/TomSellers","html_url":"https://github.com/TomSellers","followers_url":"https://api.github.com/users/TomSellers/followers","following_url":"https://api.github.com/users/TomSellers/following{/other_user}","gists_url":"https://api.github.com/users/TomSellers/gists{/gist_id}","starred_url":"https://api.github.com/users/TomSellers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomSellers/subscriptions","organizations_url":"https://api.github.com/users/TomSellers/orgs","repos_url":"https://api.github.com/users/TomSellers/repos","events_url":"https://api.github.com/users/TomSellers/events{/privacy}","received_events_url":"https://api.github.com/users/TomSellers/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"jhart-r7","id":3869433,"avatar_url":"https://avatars.githubusercontent.com/u/3869433?v=3","gravatar_id":"","url":"https://api.github.com/users/jhart-r7","html_url":"https://github.com/jhart-r7","followers_url":"https://api.github.com/users/jhart-r7/followers","following_url":"https://api.github.com/users/jhart-r7/following{/other_user}","gists_url":"https://api.github.com/users/jhart-r7/gists{/gist_id}","starred_url":"https://api.github.com/users/jhart-r7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhart-r7/subscriptions","organizations_url":"https://api.github.com/users/jhart-r7/orgs","repos_url":"https://api.github.com/users/jhart-r7/repos","events_url":"https://api.github.com/users/jhart-r7/events{/privacy}","received_events_url":"https://api.github.com/users/jhart-r7/received_events","type":"User","site_admin":false},"milestone":null,"comments":2,"created_at":"2015-02-18T11:42:00Z","updated_at":"2015-03-23T03:32:21Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/rapid7/recog/pulls/30","html_url":"https://github.com/rapid7/recog/pull/30","diff_url":"https://github.com/rapid7/recog/pull/30.diff","patch_url":"https://github.com/rapid7/recog/pull/30.patch"},"body":"Add initial MySQL banner support"},"comment":{"url":"https://api.github.com/repos/rapid7/recog/issues/comments/84779366","html_url":"https://github.com/rapid7/recog/pull/30#issuecomment-84779366","issue_url":"https://api.github.com/repos/rapid7/recog/issues/30","id":84779366,"user":{"login":"TomSellers","id":6500426,"avatar_url":"https://avatars.githubusercontent.com/u/6500426?v=3","gravatar_id":"","url":"https://api.github.com/users/TomSellers","html_url":"https://github.com/TomSellers","followers_url":"https://api.github.com/users/TomSellers/followers","following_url":"https://api.github.com/users/TomSellers/following{/other_user}","gists_url":"https://api.github.com/users/TomSellers/gists{/gist_id}","starred_url":"https://api.github.com/users/TomSellers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomSellers/subscriptions","organizations_url":"https://api.github.com/users/TomSellers/orgs","repos_url":"https://api.github.com/users/TomSellers/repos","events_url":"https://api.github.com/users/TomSellers/events{/privacy}","received_events_url":"https://api.github.com/users/TomSellers/received_events","type":"User","site_admin":false},"created_at":"2015-03-23T03:32:21Z","updated_at":"2015-03-23T03:32:21Z","body":"@jhart-r7\r\n\r\n* I have left out the generic match.  I had been leaning towards leaving it out, but wasn't sure of the best fit for your use case. Your comments cleared that up for me.\r\n\r\n* Fingerprint optimization was a reference to changing the order of the fingerprints with the goal of having the most common earlier in the file so that matches occurred faster.  The downside of this is that similar fingerprints would no longer be grouped which would complicate the effort of maintaining fingerprints.   With 1 exception, testing indicate that the benefit across the 5.2 million banner test set was not significant enough to change the FP order.  That change, in the mysql_errors, has been made.\r\n\r\n* The review of the regex trailing terminator was at the request of HD.  I prefer to use the $ anchor where possible when I am fairly certain that I have all the string accounted for.  This reduces the chance of inadvertently matching and loosing an opportunity to gather more information about a target service.  \r\n  * The end of line anchor needs to be added to the 'MariaDB MariaDB' fingerprint around line 595 and retested.  That is next on my list.  It will allow us to add a few fingerprints for MariaDB on certain flavors of Ubuntu and Debian.\r\n\r\nCurrent match metrics against the 2015.02.01 dataset:\r\n\r\nMySQL records           5,258,834\r\nMySQL match count   5,255,535    99.937%\r\nUnmatched:                       3,229\r\n\r\nAdditional metrics can be seen in this gits:\r\n  https://gist.github.com/TomSellers/d1749e7b993a1270a526\r\n"}}