{"action":"created","comment":{"url":"https://api.github.com/repos/hardening-io/ansible-os-hardening/pulls/comments/33013132","id":33013132,"diff_hunk":"@@ -83,7 +83,7 @@ sysctl_config:\n   # This settings controls how the kernel behaves towards module changes at\n   # runtime. Setting to 1 will disable module loading at runtime.\n   # Setting it to 0 is actually never supported.\n-  kernel.modules_disabled: 1\n+  # kernel.modules_disabled: 1","path":"roles/ansible-os-hardening/vars/sysctl.yml","position":14,"original_position":14,"commit_id":"c2d66cc9dd76223db714950cec1b7b6a1e86df7d","original_commit_id":"c2d66cc9dd76223db714950cec1b7b6a1e86df7d","user":{"login":"rndmh3ro","id":3198961,"avatar_url":"https://avatars.githubusercontent.com/u/3198961?v=3","gravatar_id":"","url":"https://api.github.com/users/rndmh3ro","html_url":"https://github.com/rndmh3ro","followers_url":"https://api.github.com/users/rndmh3ro/followers","following_url":"https://api.github.com/users/rndmh3ro/following{/other_user}","gists_url":"https://api.github.com/users/rndmh3ro/gists{/gist_id}","starred_url":"https://api.github.com/users/rndmh3ro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rndmh3ro/subscriptions","organizations_url":"https://api.github.com/users/rndmh3ro/orgs","repos_url":"https://api.github.com/users/rndmh3ro/repos","events_url":"https://api.github.com/users/rndmh3ro/events{/privacy}","received_events_url":"https://api.github.com/users/rndmh3ro/received_events","type":"User","site_admin":false},"body":"The tests specify that this value should be zero:\r\n```\r\n  context linux_kernel_parameter('kernel.modules_disabled') do\r\n    its(:value) { should eq 0 }\r\n  end\r\n```\r\nHowever setting this variable to 0 with Ansible results in an error, because 0 is not supported. That's why I commented it out. The user has to enable the setting by himself.","created_at":"2015-06-23T06:32:19Z","updated_at":"2015-06-23T06:32:19Z","html_url":"https://github.com/hardening-io/ansible-os-hardening/pull/27#discussion_r33013132","pull_request_url":"https://api.github.com/repos/hardening-io/ansible-os-hardening/pulls/27","_links":{"self":{"href":"https://api.github.com/repos/hardening-io/ansible-os-hardening/pulls/comments/33013132"},"html":{"href":"https://github.com/hardening-io/ansible-os-hardening/pull/27#discussion_r33013132"},"pull_request":{"href":"https://api.github.com/repos/hardening-io/ansible-os-hardening/pulls/27"}}},"pull_request":{"url":"https://api.github.com/repos/hardening-io/ansible-os-hardening/pulls/27","id":38238708,"html_url":"https://github.com/hardening-io/ansible-os-hardening/pull/27","diff_url":"https://github.com/hardening-io/ansible-os-hardening/pull/27.diff","patch_url":"https://github.com/hardening-io/ansible-os-hardening/pull/27.patch","issue_url":"https://api.github.com/repos/hardening-io/ansible-os-hardening/issues/27","number":27,"state":"open","locked":false,"title":"Fix two sysctl-settings","user":{"login":"rndmh3ro","id":3198961,"avatar_url":"https://avatars.githubusercontent.com/u/3198961?v=3","gravatar_id":"","url":"https://api.github.com/users/rndmh3ro","html_url":"https://github.com/rndmh3ro","followers_url":"https://api.github.com/users/rndmh3ro/followers","following_url":"https://api.github.com/users/rndmh3ro/following{/other_user}","gists_url":"https://api.github.com/users/rndmh3ro/gists{/gist_id}","starred_url":"https://api.github.com/users/rndmh3ro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rndmh3ro/subscriptions","organizations_url":"https://api.github.com/users/rndmh3ro/orgs","repos_url":"https://api.github.com/users/rndmh3ro/repos","events_url":"https://api.github.com/users/rndmh3ro/events{/privacy}","received_events_url":"https://api.github.com/users/rndmh3ro/received_events","type":"User","site_admin":false},"body":"arp_announce should be 2.\r\nI commented out `kernel.modules_disabled` so it doesn't get set at all.\r\n","created_at":"2015-06-22T14:42:20Z","updated_at":"2015-06-23T06:32:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1b71f56f0b7419ad8237c9ca2774425a08c30edf","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hardening-io/ansible-os-hardening/pulls/27/commits","review_comments_url":"https://api.github.com/repos/hardening-io/ansible-os-hardening/pulls/27/comments","review_comment_url":"https://api.github.com/repos/hardening-io/ansible-os-hardening/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hardening-io/ansible-os-hardening/issues/27/comments","statuses_url":"https://api.github.com/repos/hardening-io/ansible-os-hardening/statuses/c2d66cc9dd76223db714950cec1b7b6a1e86df7d","head":{"label":"hardening-io:sysctl_bugfix","ref":"sysctl_bugfix","sha":"c2d66cc9dd76223db714950cec1b7b6a1e86df7d","user":{"login":"hardening-io","id":11883542,"avatar_url":"https://avatars.githubusercontent.com/u/11883542?v=3","gravatar_id":"","url":"https://api.github.com/users/hardening-io","html_url":"https://github.com/hardening-io","followers_url":"https://api.github.com/users/hardening-io/followers","following_url":"https://api.github.com/users/hardening-io/following{/other_user}","gists_url":"https://api.github.com/users/hardening-io/gists{/gist_id}","starred_url":"https://api.github.com/users/hardening-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hardening-io/subscriptions","organizations_url":"https://api.github.com/users/hardening-io/orgs","repos_url":"https://api.github.com/users/hardening-io/repos","events_url":"https://api.github.com/users/hardening-io/events{/privacy}","received_events_url":"https://api.github.com/users/hardening-io/received_events","type":"Organization","site_admin":false},"repo":{"id":35051828,"name":"ansible-os-hardening","full_name":"hardening-io/ansible-os-hardening","owner":{"login":"hardening-io","id":11883542,"avatar_url":"https://avatars.githubusercontent.com/u/11883542?v=3","gravatar_id":"","url":"https://api.github.com/users/hardening-io","html_url":"https://github.com/hardening-io","followers_url":"https://api.github.com/users/hardening-io/followers","following_url":"https://api.github.com/users/hardening-io/following{/other_user}","gists_url":"https://api.github.com/users/hardening-io/gists{/gist_id}","starred_url":"https://api.github.com/users/hardening-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hardening-io/subscriptions","organizations_url":"https://api.github.com/users/hardening-io/orgs","repos_url":"https://api.github.com/users/hardening-io/repos","events_url":"https://api.github.com/users/hardening-io/events{/privacy}","received_events_url":"https://api.github.com/users/hardening-io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hardening-io/ansible-os-hardening","description":"This Ansible playbook provides numerous security-related configurations, providing all-round base protection.","fork":false,"url":"https://api.github.com/repos/hardening-io/ansible-os-hardening","forks_url":"https://api.github.com/repos/hardening-io/ansible-os-hardening/forks","keys_url":"https://api.github.com/repos/hardening-io/ansible-os-hardening/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hardening-io/ansible-os-hardening/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hardening-io/ansible-os-hardening/teams","hooks_url":"https://api.github.com/repos/hardening-io/ansible-os-hardening/hooks","issue_events_url":"https://api.github.com/repos/hardening-io/ansible-os-hardening/issues/events{/number}","events_url":"https://api.github.com/repos/hardening-io/ansible-os-hardening/events","assignees_url":"https://api.github.com/repos/hardening-io/ansible-os-hardening/assignees{/user}","branches_url":"https://api.github.com/repos/hardening-io/ansible-os-hardening/branches{/branch}","tags_url":"https://api.github.com/repos/hardening-io/ansible-os-hardening/tags","blobs_url":"https://api.github.com/repos/hardening-io/ansible-os-hardening/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hardening-io/ansible-os-hardening/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hardening-io/ansible-os-hardening/git/refs{/sha}","trees_url":"https://api.github.com/repos/hardening-io/ansible-os-hardening/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hardening-io/ansible-os-hardening/statuses/{sha}","languages_url":"https://api.github.com/repos/hardening-io/ansible-os-hardening/languages","stargazers_url":"https://api.github.com/repos/hardening-io/ansible-os-hardening/stargazers","contributors_url":"https://api.github.com/repos/hardening-io/ansible-os-hardening/contributors","subscribers_url":"https://api.github.com/repos/hardening-io/ansible-os-hardening/subscribers","subscription_url":"https://api.github.com/repos/hardening-io/ansible-os-hardening/subscription","commits_url":"https://api.github.com/repos/hardening-io/ansible-os-hardening/commits{/sha}","git_commits_url":"https://api.github.com/repos/hardening-io/ansible-os-hardening/git/commits{/sha}","comments_url":"https://api.github.com/repos/hardening-io/ansible-os-hardening/comments{/number}","issue_comment_url":"https://api.github.com/repos/hardening-io/ansible-os-hardening/issues/comments{/number}","contents_url":"https://api.github.com/repos/hardening-io/ansible-os-hardening/contents/{+path}","compare_url":"https://api.github.com/repos/hardening-io/ansible-os-hardening/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hardening-io/ansible-os-hardening/merges","archive_url":"https://api.github.com/repos/hardening-io/ansible-os-hardening/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hardening-io/ansible-os-hardening/downloads","issues_url":"https://api.github.com/repos/hardening-io/ansible-os-hardening/issues{/number}","pulls_url":"https://api.github.com/repos/hardening-io/ansible-os-hardening/pulls{/number}","milestones_url":"https://api.github.com/repos/hardening-io/ansible-os-hardening/milestones{/number}","notifications_url":"https://api.github.com/repos/hardening-io/ansible-os-hardening/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hardening-io/ansible-os-hardening/labels{/name}","releases_url":"https://api.github.com/repos/hardening-io/ansible-os-hardening/releases{/id}","created_at":"2015-05-04T18:26:56Z","updated_at":"2015-06-22T22:47:34Z","pushed_at":"2015-06-23T06:23:38Z","git_url":"git://github.com/hardening-io/ansible-os-hardening.git","ssh_url":"git@github.com:hardening-io/ansible-os-hardening.git","clone_url":"https://github.com/hardening-io/ansible-os-hardening.git","svn_url":"https://github.com/hardening-io/ansible-os-hardening","homepage":null,"size":653,"stargazers_count":7,"watchers_count":7,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":7,"default_branch":"master"}},"base":{"label":"hardening-io:master","ref":"master","sha":"10267eb5094eeaeddc0d0e82fd868118f8b28516","user":{"login":"hardening-io","id":11883542,"avatar_url":"https://avatars.githubusercontent.com/u/11883542?v=3","gravatar_id":"","url":"https://api.github.com/users/hardening-io","html_url":"https://github.com/hardening-io","followers_url":"https://api.github.com/users/hardening-io/followers","following_url":"https://api.github.com/users/hardening-io/following{/other_user}","gists_url":"https://api.github.com/users/hardening-io/gists{/gist_id}","starred_url":"https://api.github.com/users/hardening-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hardening-io/subscriptions","organizations_url":"https://api.github.com/users/hardening-io/orgs","repos_url":"https://api.github.com/users/hardening-io/repos","events_url":"https://api.github.com/users/hardening-io/events{/privacy}","received_events_url":"https://api.github.com/users/hardening-io/received_events","type":"Organization","site_admin":false},"repo":{"id":35051828,"name":"ansible-os-hardening","full_name":"hardening-io/ansible-os-hardening","owner":{"login":"hardening-io","id":11883542,"avatar_url":"https://avatars.githubusercontent.com/u/11883542?v=3","gravatar_id":"","url":"https://api.github.com/users/hardening-io","html_url":"https://github.com/hardening-io","followers_url":"https://api.github.com/users/hardening-io/followers","following_url":"https://api.github.com/users/hardening-io/following{/other_user}","gists_url":"https://api.github.com/users/hardening-io/gists{/gist_id}","starred_url":"https://api.github.com/users/hardening-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hardening-io/subscriptions","organizations_url":"https://api.github.com/users/hardening-io/orgs","repos_url":"https://api.github.com/users/hardening-io/repos","events_url":"https://api.github.com/users/hardening-io/events{/privacy}","received_events_url":"https://api.github.com/users/hardening-io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hardening-io/ansible-os-hardening","description":"This Ansible playbook provides numerous security-related configurations, providing all-round base protection.","fork":false,"url":"https://api.github.com/repos/hardening-io/ansible-os-hardening","forks_url":"https://api.github.com/repos/hardening-io/ansible-os-hardening/forks","keys_url":"https://api.github.com/repos/hardening-io/ansible-os-hardening/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hardening-io/ansible-os-hardening/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hardening-io/ansible-os-hardening/teams","hooks_url":"https://api.github.com/repos/hardening-io/ansible-os-hardening/hooks","issue_events_url":"https://api.github.com/repos/hardening-io/ansible-os-hardening/issues/events{/number}","events_url":"https://api.github.com/repos/hardening-io/ansible-os-hardening/events","assignees_url":"https://api.github.com/repos/hardening-io/ansible-os-hardening/assignees{/user}","branches_url":"https://api.github.com/repos/hardening-io/ansible-os-hardening/branches{/branch}","tags_url":"https://api.github.com/repos/hardening-io/ansible-os-hardening/tags","blobs_url":"https://api.github.com/repos/hardening-io/ansible-os-hardening/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hardening-io/ansible-os-hardening/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hardening-io/ansible-os-hardening/git/refs{/sha}","trees_url":"https://api.github.com/repos/hardening-io/ansible-os-hardening/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hardening-io/ansible-os-hardening/statuses/{sha}","languages_url":"https://api.github.com/repos/hardening-io/ansible-os-hardening/languages","stargazers_url":"https://api.github.com/repos/hardening-io/ansible-os-hardening/stargazers","contributors_url":"https://api.github.com/repos/hardening-io/ansible-os-hardening/contributors","subscribers_url":"https://api.github.com/repos/hardening-io/ansible-os-hardening/subscribers","subscription_url":"https://api.github.com/repos/hardening-io/ansible-os-hardening/subscription","commits_url":"https://api.github.com/repos/hardening-io/ansible-os-hardening/commits{/sha}","git_commits_url":"https://api.github.com/repos/hardening-io/ansible-os-hardening/git/commits{/sha}","comments_url":"https://api.github.com/repos/hardening-io/ansible-os-hardening/comments{/number}","issue_comment_url":"https://api.github.com/repos/hardening-io/ansible-os-hardening/issues/comments{/number}","contents_url":"https://api.github.com/repos/hardening-io/ansible-os-hardening/contents/{+path}","compare_url":"https://api.github.com/repos/hardening-io/ansible-os-hardening/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hardening-io/ansible-os-hardening/merges","archive_url":"https://api.github.com/repos/hardening-io/ansible-os-hardening/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hardening-io/ansible-os-hardening/downloads","issues_url":"https://api.github.com/repos/hardening-io/ansible-os-hardening/issues{/number}","pulls_url":"https://api.github.com/repos/hardening-io/ansible-os-hardening/pulls{/number}","milestones_url":"https://api.github.com/repos/hardening-io/ansible-os-hardening/milestones{/number}","notifications_url":"https://api.github.com/repos/hardening-io/ansible-os-hardening/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hardening-io/ansible-os-hardening/labels{/name}","releases_url":"https://api.github.com/repos/hardening-io/ansible-os-hardening/releases{/id}","created_at":"2015-05-04T18:26:56Z","updated_at":"2015-06-22T22:47:34Z","pushed_at":"2015-06-23T06:23:38Z","git_url":"git://github.com/hardening-io/ansible-os-hardening.git","ssh_url":"git@github.com:hardening-io/ansible-os-hardening.git","clone_url":"https://github.com/hardening-io/ansible-os-hardening.git","svn_url":"https://github.com/hardening-io/ansible-os-hardening","homepage":null,"size":653,"stargazers_count":7,"watchers_count":7,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hardening-io/ansible-os-hardening/pulls/27"},"html":{"href":"https://github.com/hardening-io/ansible-os-hardening/pull/27"},"issue":{"href":"https://api.github.com/repos/hardening-io/ansible-os-hardening/issues/27"},"comments":{"href":"https://api.github.com/repos/hardening-io/ansible-os-hardening/issues/27/comments"},"review_comments":{"href":"https://api.github.com/repos/hardening-io/ansible-os-hardening/pulls/27/comments"},"review_comment":{"href":"https://api.github.com/repos/hardening-io/ansible-os-hardening/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hardening-io/ansible-os-hardening/pulls/27/commits"},"statuses":{"href":"https://api.github.com/repos/hardening-io/ansible-os-hardening/statuses/c2d66cc9dd76223db714950cec1b7b6a1e86df7d"}}}}