{"action":"created","issue":{"url":"https://api.github.com/repos/ClusterHQ/flocker/issues/1184","labels_url":"https://api.github.com/repos/ClusterHQ/flocker/issues/1184/labels{/name}","comments_url":"https://api.github.com/repos/ClusterHQ/flocker/issues/1184/comments","events_url":"https://api.github.com/repos/ClusterHQ/flocker/issues/1184/events","html_url":"https://github.com/ClusterHQ/flocker/pull/1184","id":58954883,"number":1184,"title":"[FLOC-1465] Dataset deletion endpoint","user":{"login":"itamarst","id":3266662,"avatar_url":"https://avatars.githubusercontent.com/u/3266662?v=3","gravatar_id":"","url":"https://api.github.com/users/itamarst","html_url":"https://github.com/itamarst","followers_url":"https://api.github.com/users/itamarst/followers","following_url":"https://api.github.com/users/itamarst/following{/other_user}","gists_url":"https://api.github.com/users/itamarst/gists{/gist_id}","starred_url":"https://api.github.com/users/itamarst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/itamarst/subscriptions","organizations_url":"https://api.github.com/users/itamarst/orgs","repos_url":"https://api.github.com/users/itamarst/repos","events_url":"https://api.github.com/users/itamarst/events{/privacy}","received_events_url":"https://api.github.com/users/itamarst/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-02-25T19:20:21Z","updated_at":"2015-03-03T12:27:47Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ClusterHQ/flocker/pulls/1184","html_url":"https://github.com/ClusterHQ/flocker/pull/1184","diff_url":"https://github.com/ClusterHQ/flocker/pull/1184.diff","patch_url":"https://github.com/ClusterHQ/flocker/pull/1184.patch"},"body":"https://clusterhq.atlassian.net/browse/FLOC-1465"},"comment":{"url":"https://api.github.com/repos/ClusterHQ/flocker/issues/comments/76936451","html_url":"https://github.com/ClusterHQ/flocker/pull/1184#issuecomment-76936451","issue_url":"https://api.github.com/repos/ClusterHQ/flocker/issues/1184","id":76936451,"user":{"login":"wallrj","id":978965,"avatar_url":"https://avatars.githubusercontent.com/u/978965?v=3","gravatar_id":"","url":"https://api.github.com/users/wallrj","html_url":"https://github.com/wallrj","followers_url":"https://api.github.com/users/wallrj/followers","following_url":"https://api.github.com/users/wallrj/following{/other_user}","gists_url":"https://api.github.com/users/wallrj/gists{/gist_id}","starred_url":"https://api.github.com/users/wallrj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wallrj/subscriptions","organizations_url":"https://api.github.com/users/wallrj/orgs","repos_url":"https://api.github.com/users/wallrj/repos","events_url":"https://api.github.com/users/wallrj/events{/privacy}","received_events_url":"https://api.github.com/users/wallrj/received_events","type":"User","site_admin":false},"created_at":"2015-03-03T12:27:47Z","updated_at":"2015-03-03T12:27:47Z","body":"Thanks @itamarst \r\n\r\nThis makes sense.\r\n\r\nI'm still not sure about the idempotent DELETE behaviour. I left some comments about that above, in particular about what should happen if I attempt to update a deleted dataset.\r\n\r\nThere were a few typos.\r\n\r\nThe PR diff seems to contain changes from various other branches, probably just because it needs merging forward.\r\n\r\nDELETE API examples contain some request bodies, which seems wrong.\r\n\r\nThere's missing coverage of the IndexError when there are no primary manifestations, but I think we deliberately removed the test for that behaviour in the UPDATE datasets API branch.\r\n * http://build.clusterhq.com/results/complete-coverage/delete-dataset-API-FLOC-1465/flocker_control_httpapi.html#n237\r\n\r\n...so I guess it can wait until we do https://clusterhq.atlassian.net/browse/FLOC-1403\r\n\r\nAnswer or address those points, file followup issues then merge, or put it back up for review if you decide to change the DELETE deleted datasets behaviour.\r\n\r\n"}}