{"comment":{"url":"https://api.github.com/repos/lyrixx/ansiblediamond/comments/11340723","html_url":"https://github.com/lyrixx/ansiblediamond/commit/a20e78e190138925732a291b6f6059cf5a327ea7#commitcomment-11340723","id":11340723,"user":{"login":"pythianliappis","id":6865261,"avatar_url":"https://avatars.githubusercontent.com/u/6865261?v=3","gravatar_id":"","url":"https://api.github.com/users/pythianliappis","html_url":"https://github.com/pythianliappis","followers_url":"https://api.github.com/users/pythianliappis/followers","following_url":"https://api.github.com/users/pythianliappis/following{/other_user}","gists_url":"https://api.github.com/users/pythianliappis/gists{/gist_id}","starred_url":"https://api.github.com/users/pythianliappis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pythianliappis/subscriptions","organizations_url":"https://api.github.com/users/pythianliappis/orgs","repos_url":"https://api.github.com/users/pythianliappis/repos","events_url":"https://api.github.com/users/pythianliappis/events{/privacy}","received_events_url":"https://api.github.com/users/pythianliappis/received_events","type":"User","site_admin":false},"position":null,"line":null,"path":"","commit_id":"a20e78e190138925732a291b6f6059cf5a327ea7","created_at":"2015-05-23T21:04:36Z","updated_at":"2015-05-23T21:04:36Z","body":"Sorry for the delay reviewing this and thank you for your interest and work!\r\n\r\nI would like to understand a little more, the reasoning behind deprecating the jinja2 code that generates the collector conf files replacing it with an ansible module.\r\n\r\nWhile there's nothing wrong with the use of an ansible module, if there is no need to introduce extra components/dependencies I would like to avoid that path -- additionally using custom modules from Ansible Tower, until recently at least, was not such a straightforward task and involves manually copying the module to an awx directory.\r\n\r\nI run both versions of the role, with the jinja2 template and with the module and checked the differences between the generated conf files but didn't find any. See below. I am sure you had a reason for writing a python ansible module though, so would you care to elaborate what extra functionality were you trying to accomplish or what am I missing?\r\n\r\nDiff:\r\n\r\n```\r\nvagrant@vagrant:/etc/diamond/collectors$ diff -y DiskUsageCollector.conf DiskUsageCollector.conf.dimitris \r\nbyte_unit=byte,\t\t\t\t\t\t      |\tbyte_unit=byte,  \r\ndevices=PhysicalDrive[0-9]+$|md[0-9]+$|sd[a-z]+[0-9]*$|x?vd[a |\tdevices=PhysicalDrive[0-9]+$|md[0-9]+$|sd[a-z]+[0-9]*$|x?vd[a\r\nenabled=True\t\t\t\t\t\t      |\tenabled=True  \r\nmeasure_collector_time=False\t\t\t\t      |\tmeasure_collector_time=False  \r\npath_suffix=\t\t\t\t\t\t      |\tpath_suffix=  \r\nsector_size=512\t\t\t\t\t\t      |\tsector_size=512  \r\nsend_zero=False\t\t\t\t\t\t      |\tsend_zero=False  \r\nttl_multiplier=2\t\t\t\t\t      |\tttl_multiplier=2  \r\n```\r\n\r\nDiff ignoring whitespaces:\r\n```\r\nvagrant@vagrant:/etc/diamond/collectors$ diff -w -u DiskUsageCollector.conf DiskUsageCollector.conf.dimitris \r\n```\r\n"}}