{"action":"created","comment":{"url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/comments/41204170","id":41204170,"diff_hunk":"@@ -1,32 +1,52 @@\n+require 'pry'\n class NameCollisionError < RuntimeError; end\n \n+ERROR = 'There was a problem generating the robot name!'\n+\n class Robot\n   attr_accessor :name\n \n   @@registry\n \n-  def initialize(args = {})\n+  def initialize(name_generator = nil)\n     @@registry ||= []\n-    @name_generator = args[:name_generator]\n+    @name = name_generator ? name_generator.call : generate_name\n+    duplication_check\n+  end\n+\n+  def generate_name\n+    name = \"\"\n+    2.times {name << generate_char}\n+    3.times {name << generate_num.to_s}\n+    name\n+  end\n+\n+  def generate_char\n+    ('A'..'Z').to_a.sample\n+  end\n \n-    if @name_generator\n-      @name = @name_generator.call\n-    else\n-      generate_char = -> { ('A'..'Z').to_a.sample }\n-      generate_num = -> { rand(10) }\n+  def generate_num\n+    rand(10)\n+  end\n \n-      @name = \"#{generate_char.call}#{generate_char.call}#{generate_num.call}#{generate_num.call}#{generate_num.call}\"\n-    end\n+  def duplication_check\n+    raise NameCollisionError, ERROR if incorrect_name_pattern? || name_taken?\n+    @@registry << name\n+  end\n+\n+  def name_taken?\n+    @@registry.include?(name)\n+  end\n \n-    raise NameCollisionError, 'There was a problem generating the robot name!' if !(name =~ /[[:alpha:]]{2}[[:digit:]]{3}/) || @@registry.include?(name)\n-    @@registry << @name\n+  def incorrect_name_pattern?\n+    !(name =~ /[[:alpha:]]{2}[[:digit:]]{3}/)\n   end\n end\n \n robot = Robot.new\n puts \"My pet robot's name is #{robot.name}, but we usually call him sparky.\"\n \n-# Errors!\n-# generator = -> { 'AA111' }\n-# Robot.new(name_generator: generator)\n-# Robot.new(name_generator: generator)\n+generator = -> { 'AA011' }\n+robot1 = Robot.new(generator)\n+puts \"My pet robot's name is #{robot1.name}, but we usually call him sparky.\"\n+#robot2 = Robot.new(generator)","path":"robot_name/robot_name.rb","position":67,"original_position":67,"commit_id":"de65ba36cd5c557085be4869ff1c7cece1c98fbb","original_commit_id":"de65ba36cd5c557085be4869ff1c7cece1c98fbb","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Missing space after #.","created_at":"2015-10-05T22:07:44Z","updated_at":"2015-10-05T22:07:44Z","html_url":"https://github.com/jmmastey/level_up_exercises/pull/997#discussion_r41204170","pull_request_url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/997","_links":{"self":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/comments/41204170"},"html":{"href":"https://github.com/jmmastey/level_up_exercises/pull/997#discussion_r41204170"},"pull_request":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/997"}}},"pull_request":{"url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/997","id":46830225,"html_url":"https://github.com/jmmastey/level_up_exercises/pull/997","diff_url":"https://github.com/jmmastey/level_up_exercises/pull/997.diff","patch_url":"https://github.com/jmmastey/level_up_exercises/pull/997.patch","issue_url":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/997","number":997,"state":"open","locked":false,"title":"Robot","user":{"login":"arpanp1986","id":3536808,"avatar_url":"https://avatars.githubusercontent.com/u/3536808?v=3","gravatar_id":"","url":"https://api.github.com/users/arpanp1986","html_url":"https://github.com/arpanp1986","followers_url":"https://api.github.com/users/arpanp1986/followers","following_url":"https://api.github.com/users/arpanp1986/following{/other_user}","gists_url":"https://api.github.com/users/arpanp1986/gists{/gist_id}","starred_url":"https://api.github.com/users/arpanp1986/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arpanp1986/subscriptions","organizations_url":"https://api.github.com/users/arpanp1986/orgs","repos_url":"https://api.github.com/users/arpanp1986/repos","events_url":"https://api.github.com/users/arpanp1986/events{/privacy}","received_events_url":"https://api.github.com/users/arpanp1986/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-10-05T20:36:52Z","updated_at":"2015-10-05T22:07:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"285f8705b3f340cd1d5b65ff7cfb560d7e48c4b0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/997/commits","review_comments_url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/997/comments","review_comment_url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/997/comments","statuses_url":"https://api.github.com/repos/jmmastey/level_up_exercises/statuses/de65ba36cd5c557085be4869ff1c7cece1c98fbb","head":{"label":"arpanp1986:robot_exercise","ref":"robot_exercise","sha":"de65ba36cd5c557085be4869ff1c7cece1c98fbb","user":{"login":"arpanp1986","id":3536808,"avatar_url":"https://avatars.githubusercontent.com/u/3536808?v=3","gravatar_id":"","url":"https://api.github.com/users/arpanp1986","html_url":"https://github.com/arpanp1986","followers_url":"https://api.github.com/users/arpanp1986/followers","following_url":"https://api.github.com/users/arpanp1986/following{/other_user}","gists_url":"https://api.github.com/users/arpanp1986/gists{/gist_id}","starred_url":"https://api.github.com/users/arpanp1986/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arpanp1986/subscriptions","organizations_url":"https://api.github.com/users/arpanp1986/orgs","repos_url":"https://api.github.com/users/arpanp1986/repos","events_url":"https://api.github.com/users/arpanp1986/events{/privacy}","received_events_url":"https://api.github.com/users/arpanp1986/received_events","type":"User","site_admin":false},"repo":{"id":43711680,"name":"level_up_exercises","full_name":"arpanp1986/level_up_exercises","owner":{"login":"arpanp1986","id":3536808,"avatar_url":"https://avatars.githubusercontent.com/u/3536808?v=3","gravatar_id":"","url":"https://api.github.com/users/arpanp1986","html_url":"https://github.com/arpanp1986","followers_url":"https://api.github.com/users/arpanp1986/followers","following_url":"https://api.github.com/users/arpanp1986/following{/other_user}","gists_url":"https://api.github.com/users/arpanp1986/gists{/gist_id}","starred_url":"https://api.github.com/users/arpanp1986/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arpanp1986/subscriptions","organizations_url":"https://api.github.com/users/arpanp1986/orgs","repos_url":"https://api.github.com/users/arpanp1986/repos","events_url":"https://api.github.com/users/arpanp1986/events{/privacy}","received_events_url":"https://api.github.com/users/arpanp1986/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/arpanp1986/level_up_exercises","description":"A series of code-related assignments to challenge starting engineers","fork":true,"url":"https://api.github.com/repos/arpanp1986/level_up_exercises","forks_url":"https://api.github.com/repos/arpanp1986/level_up_exercises/forks","keys_url":"https://api.github.com/repos/arpanp1986/level_up_exercises/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arpanp1986/level_up_exercises/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arpanp1986/level_up_exercises/teams","hooks_url":"https://api.github.com/repos/arpanp1986/level_up_exercises/hooks","issue_events_url":"https://api.github.com/repos/arpanp1986/level_up_exercises/issues/events{/number}","events_url":"https://api.github.com/repos/arpanp1986/level_up_exercises/events","assignees_url":"https://api.github.com/repos/arpanp1986/level_up_exercises/assignees{/user}","branches_url":"https://api.github.com/repos/arpanp1986/level_up_exercises/branches{/branch}","tags_url":"https://api.github.com/repos/arpanp1986/level_up_exercises/tags","blobs_url":"https://api.github.com/repos/arpanp1986/level_up_exercises/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arpanp1986/level_up_exercises/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arpanp1986/level_up_exercises/git/refs{/sha}","trees_url":"https://api.github.com/repos/arpanp1986/level_up_exercises/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arpanp1986/level_up_exercises/statuses/{sha}","languages_url":"https://api.github.com/repos/arpanp1986/level_up_exercises/languages","stargazers_url":"https://api.github.com/repos/arpanp1986/level_up_exercises/stargazers","contributors_url":"https://api.github.com/repos/arpanp1986/level_up_exercises/contributors","subscribers_url":"https://api.github.com/repos/arpanp1986/level_up_exercises/subscribers","subscription_url":"https://api.github.com/repos/arpanp1986/level_up_exercises/subscription","commits_url":"https://api.github.com/repos/arpanp1986/level_up_exercises/commits{/sha}","git_commits_url":"https://api.github.com/repos/arpanp1986/level_up_exercises/git/commits{/sha}","comments_url":"https://api.github.com/repos/arpanp1986/level_up_exercises/comments{/number}","issue_comment_url":"https://api.github.com/repos/arpanp1986/level_up_exercises/issues/comments{/number}","contents_url":"https://api.github.com/repos/arpanp1986/level_up_exercises/contents/{+path}","compare_url":"https://api.github.com/repos/arpanp1986/level_up_exercises/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arpanp1986/level_up_exercises/merges","archive_url":"https://api.github.com/repos/arpanp1986/level_up_exercises/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arpanp1986/level_up_exercises/downloads","issues_url":"https://api.github.com/repos/arpanp1986/level_up_exercises/issues{/number}","pulls_url":"https://api.github.com/repos/arpanp1986/level_up_exercises/pulls{/number}","milestones_url":"https://api.github.com/repos/arpanp1986/level_up_exercises/milestones{/number}","notifications_url":"https://api.github.com/repos/arpanp1986/level_up_exercises/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arpanp1986/level_up_exercises/labels{/name}","releases_url":"https://api.github.com/repos/arpanp1986/level_up_exercises/releases{/id}","created_at":"2015-10-05T20:23:26Z","updated_at":"2015-10-05T20:23:29Z","pushed_at":"2015-10-05T22:07:40Z","git_url":"git://github.com/arpanp1986/level_up_exercises.git","ssh_url":"git@github.com:arpanp1986/level_up_exercises.git","clone_url":"https://github.com/arpanp1986/level_up_exercises.git","svn_url":"https://github.com/arpanp1986/level_up_exercises","homepage":"https://leveluprails.com","size":328,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jmmastey:master","ref":"master","sha":"573aed5af1dff6995e407c7c9c16cdaa9aa183ca","user":{"login":"jmmastey","id":302011,"avatar_url":"https://avatars.githubusercontent.com/u/302011?v=3","gravatar_id":"","url":"https://api.github.com/users/jmmastey","html_url":"https://github.com/jmmastey","followers_url":"https://api.github.com/users/jmmastey/followers","following_url":"https://api.github.com/users/jmmastey/following{/other_user}","gists_url":"https://api.github.com/users/jmmastey/gists{/gist_id}","starred_url":"https://api.github.com/users/jmmastey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmmastey/subscriptions","organizations_url":"https://api.github.com/users/jmmastey/orgs","repos_url":"https://api.github.com/users/jmmastey/repos","events_url":"https://api.github.com/users/jmmastey/events{/privacy}","received_events_url":"https://api.github.com/users/jmmastey/received_events","type":"User","site_admin":false},"repo":{"id":20705648,"name":"level_up_exercises","full_name":"jmmastey/level_up_exercises","owner":{"login":"jmmastey","id":302011,"avatar_url":"https://avatars.githubusercontent.com/u/302011?v=3","gravatar_id":"","url":"https://api.github.com/users/jmmastey","html_url":"https://github.com/jmmastey","followers_url":"https://api.github.com/users/jmmastey/followers","following_url":"https://api.github.com/users/jmmastey/following{/other_user}","gists_url":"https://api.github.com/users/jmmastey/gists{/gist_id}","starred_url":"https://api.github.com/users/jmmastey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmmastey/subscriptions","organizations_url":"https://api.github.com/users/jmmastey/orgs","repos_url":"https://api.github.com/users/jmmastey/repos","events_url":"https://api.github.com/users/jmmastey/events{/privacy}","received_events_url":"https://api.github.com/users/jmmastey/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jmmastey/level_up_exercises","description":"A series of code-related assignments to challenge starting engineers","fork":false,"url":"https://api.github.com/repos/jmmastey/level_up_exercises","forks_url":"https://api.github.com/repos/jmmastey/level_up_exercises/forks","keys_url":"https://api.github.com/repos/jmmastey/level_up_exercises/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jmmastey/level_up_exercises/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jmmastey/level_up_exercises/teams","hooks_url":"https://api.github.com/repos/jmmastey/level_up_exercises/hooks","issue_events_url":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/events{/number}","events_url":"https://api.github.com/repos/jmmastey/level_up_exercises/events","assignees_url":"https://api.github.com/repos/jmmastey/level_up_exercises/assignees{/user}","branches_url":"https://api.github.com/repos/jmmastey/level_up_exercises/branches{/branch}","tags_url":"https://api.github.com/repos/jmmastey/level_up_exercises/tags","blobs_url":"https://api.github.com/repos/jmmastey/level_up_exercises/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jmmastey/level_up_exercises/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jmmastey/level_up_exercises/git/refs{/sha}","trees_url":"https://api.github.com/repos/jmmastey/level_up_exercises/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jmmastey/level_up_exercises/statuses/{sha}","languages_url":"https://api.github.com/repos/jmmastey/level_up_exercises/languages","stargazers_url":"https://api.github.com/repos/jmmastey/level_up_exercises/stargazers","contributors_url":"https://api.github.com/repos/jmmastey/level_up_exercises/contributors","subscribers_url":"https://api.github.com/repos/jmmastey/level_up_exercises/subscribers","subscription_url":"https://api.github.com/repos/jmmastey/level_up_exercises/subscription","commits_url":"https://api.github.com/repos/jmmastey/level_up_exercises/commits{/sha}","git_commits_url":"https://api.github.com/repos/jmmastey/level_up_exercises/git/commits{/sha}","comments_url":"https://api.github.com/repos/jmmastey/level_up_exercises/comments{/number}","issue_comment_url":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/comments{/number}","contents_url":"https://api.github.com/repos/jmmastey/level_up_exercises/contents/{+path}","compare_url":"https://api.github.com/repos/jmmastey/level_up_exercises/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jmmastey/level_up_exercises/merges","archive_url":"https://api.github.com/repos/jmmastey/level_up_exercises/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jmmastey/level_up_exercises/downloads","issues_url":"https://api.github.com/repos/jmmastey/level_up_exercises/issues{/number}","pulls_url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls{/number}","milestones_url":"https://api.github.com/repos/jmmastey/level_up_exercises/milestones{/number}","notifications_url":"https://api.github.com/repos/jmmastey/level_up_exercises/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jmmastey/level_up_exercises/labels{/name}","releases_url":"https://api.github.com/repos/jmmastey/level_up_exercises/releases{/id}","created_at":"2014-06-10T23:42:24Z","updated_at":"2015-09-27T15:41:45Z","pushed_at":"2015-10-05T22:07:40Z","git_url":"git://github.com/jmmastey/level_up_exercises.git","ssh_url":"git@github.com:jmmastey/level_up_exercises.git","clone_url":"https://github.com/jmmastey/level_up_exercises.git","svn_url":"https://github.com/jmmastey/level_up_exercises","homepage":"https://leveluprails.com","size":223227,"stargazers_count":28,"watchers_count":28,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":145,"mirror_url":null,"open_issues_count":9,"forks":145,"open_issues":9,"watchers":28,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/997"},"html":{"href":"https://github.com/jmmastey/level_up_exercises/pull/997"},"issue":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/997"},"comments":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/997/comments"},"review_comments":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/997/comments"},"review_comment":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/997/commits"},"statuses":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/statuses/de65ba36cd5c557085be4869ff1c7cece1c98fbb"}}}}