{"action":"created","comment":{"url":"https://api.github.com/repos/Manishearth/rust-clippy/pulls/comments/41381044","id":41381044,"diff_hunk":"@@ -0,0 +1,139 @@\n+use rustc::lint::*;\n+use rustc_front::hir::{Expr, ExprMethodCall, ExprLit};\n+use utils::{walk_ptrs_ty_depth, match_type, span_lint, OPEN_OPTIONS_PATH};\n+use syntax::codemap::{Span, Spanned};\n+use syntax::ast::Lit_::LitBool;\n+\n+declare_lint! {\n+    pub NONSENSICAL_OPEN_OPTIONS,\n+    Warn,\n+    \"The options used for opening a file are nonsensical\"","path":"src/open_options.rs","position":10,"original_position":10,"commit_id":"7644f8e2a1774c426f520efc50fe3626b31e028c","original_commit_id":"7644f8e2a1774c426f520efc50fe3626b31e028c","user":{"login":"llogiq","id":4200835,"avatar_url":"https://avatars.githubusercontent.com/u/4200835?v=3","gravatar_id":"","url":"https://api.github.com/users/llogiq","html_url":"https://github.com/llogiq","followers_url":"https://api.github.com/users/llogiq/followers","following_url":"https://api.github.com/users/llogiq/following{/other_user}","gists_url":"https://api.github.com/users/llogiq/gists{/gist_id}","starred_url":"https://api.github.com/users/llogiq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/llogiq/subscriptions","organizations_url":"https://api.github.com/users/llogiq/orgs","repos_url":"https://api.github.com/users/llogiq/repos","events_url":"https://api.github.com/users/llogiq/events{/privacy}","received_events_url":"https://api.github.com/users/llogiq/received_events","type":"User","site_admin":false},"body":"This should describe the lint, not the error. Something along the lines of \"nonsensical combination of options for opening a file\" would be fitting.","created_at":"2015-10-07T11:57:25Z","updated_at":"2015-10-07T11:57:25Z","html_url":"https://github.com/Manishearth/rust-clippy/pull/366#discussion_r41381044","pull_request_url":"https://api.github.com/repos/Manishearth/rust-clippy/pulls/366","_links":{"self":{"href":"https://api.github.com/repos/Manishearth/rust-clippy/pulls/comments/41381044"},"html":{"href":"https://github.com/Manishearth/rust-clippy/pull/366#discussion_r41381044"},"pull_request":{"href":"https://api.github.com/repos/Manishearth/rust-clippy/pulls/366"}}},"pull_request":{"url":"https://api.github.com/repos/Manishearth/rust-clippy/pulls/366","id":47017251,"html_url":"https://github.com/Manishearth/rust-clippy/pull/366","diff_url":"https://github.com/Manishearth/rust-clippy/pull/366.diff","patch_url":"https://github.com/Manishearth/rust-clippy/pull/366.patch","issue_url":"https://api.github.com/repos/Manishearth/rust-clippy/issues/366","number":366,"state":"open","locked":false,"title":"Add \"nonsensical OpenOptions\" lint","user":{"login":"Pyriphlegethon","id":13908830,"avatar_url":"https://avatars.githubusercontent.com/u/13908830?v=3","gravatar_id":"","url":"https://api.github.com/users/Pyriphlegethon","html_url":"https://github.com/Pyriphlegethon","followers_url":"https://api.github.com/users/Pyriphlegethon/followers","following_url":"https://api.github.com/users/Pyriphlegethon/following{/other_user}","gists_url":"https://api.github.com/users/Pyriphlegethon/gists{/gist_id}","starred_url":"https://api.github.com/users/Pyriphlegethon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pyriphlegethon/subscriptions","organizations_url":"https://api.github.com/users/Pyriphlegethon/orgs","repos_url":"https://api.github.com/users/Pyriphlegethon/repos","events_url":"https://api.github.com/users/Pyriphlegethon/events{/privacy}","received_events_url":"https://api.github.com/users/Pyriphlegethon/received_events","type":"User","site_admin":false},"body":"This PR closes issue #297. I'm not sure about the error messages though. I would appreciate any feedback. :smile:","created_at":"2015-10-07T11:50:36Z","updated_at":"2015-10-07T11:57:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4b2ef5a55194495c138de57f116ede9763856b34","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Manishearth/rust-clippy/pulls/366/commits","review_comments_url":"https://api.github.com/repos/Manishearth/rust-clippy/pulls/366/comments","review_comment_url":"https://api.github.com/repos/Manishearth/rust-clippy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Manishearth/rust-clippy/issues/366/comments","statuses_url":"https://api.github.com/repos/Manishearth/rust-clippy/statuses/7644f8e2a1774c426f520efc50fe3626b31e028c","head":{"label":"Pyriphlegethon:master","ref":"master","sha":"7644f8e2a1774c426f520efc50fe3626b31e028c","user":{"login":"Pyriphlegethon","id":13908830,"avatar_url":"https://avatars.githubusercontent.com/u/13908830?v=3","gravatar_id":"","url":"https://api.github.com/users/Pyriphlegethon","html_url":"https://github.com/Pyriphlegethon","followers_url":"https://api.github.com/users/Pyriphlegethon/followers","following_url":"https://api.github.com/users/Pyriphlegethon/following{/other_user}","gists_url":"https://api.github.com/users/Pyriphlegethon/gists{/gist_id}","starred_url":"https://api.github.com/users/Pyriphlegethon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pyriphlegethon/subscriptions","organizations_url":"https://api.github.com/users/Pyriphlegethon/orgs","repos_url":"https://api.github.com/users/Pyriphlegethon/repos","events_url":"https://api.github.com/users/Pyriphlegethon/events{/privacy}","received_events_url":"https://api.github.com/users/Pyriphlegethon/received_events","type":"User","site_admin":false},"repo":{"id":43362197,"name":"rust-clippy","full_name":"Pyriphlegethon/rust-clippy","owner":{"login":"Pyriphlegethon","id":13908830,"avatar_url":"https://avatars.githubusercontent.com/u/13908830?v=3","gravatar_id":"","url":"https://api.github.com/users/Pyriphlegethon","html_url":"https://github.com/Pyriphlegethon","followers_url":"https://api.github.com/users/Pyriphlegethon/followers","following_url":"https://api.github.com/users/Pyriphlegethon/following{/other_user}","gists_url":"https://api.github.com/users/Pyriphlegethon/gists{/gist_id}","starred_url":"https://api.github.com/users/Pyriphlegethon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pyriphlegethon/subscriptions","organizations_url":"https://api.github.com/users/Pyriphlegethon/orgs","repos_url":"https://api.github.com/users/Pyriphlegethon/repos","events_url":"https://api.github.com/users/Pyriphlegethon/events{/privacy}","received_events_url":"https://api.github.com/users/Pyriphlegethon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Pyriphlegethon/rust-clippy","description":"A bunch of lints to catch common mistakes and improve your Rust code","fork":true,"url":"https://api.github.com/repos/Pyriphlegethon/rust-clippy","forks_url":"https://api.github.com/repos/Pyriphlegethon/rust-clippy/forks","keys_url":"https://api.github.com/repos/Pyriphlegethon/rust-clippy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Pyriphlegethon/rust-clippy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Pyriphlegethon/rust-clippy/teams","hooks_url":"https://api.github.com/repos/Pyriphlegethon/rust-clippy/hooks","issue_events_url":"https://api.github.com/repos/Pyriphlegethon/rust-clippy/issues/events{/number}","events_url":"https://api.github.com/repos/Pyriphlegethon/rust-clippy/events","assignees_url":"https://api.github.com/repos/Pyriphlegethon/rust-clippy/assignees{/user}","branches_url":"https://api.github.com/repos/Pyriphlegethon/rust-clippy/branches{/branch}","tags_url":"https://api.github.com/repos/Pyriphlegethon/rust-clippy/tags","blobs_url":"https://api.github.com/repos/Pyriphlegethon/rust-clippy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Pyriphlegethon/rust-clippy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Pyriphlegethon/rust-clippy/git/refs{/sha}","trees_url":"https://api.github.com/repos/Pyriphlegethon/rust-clippy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Pyriphlegethon/rust-clippy/statuses/{sha}","languages_url":"https://api.github.com/repos/Pyriphlegethon/rust-clippy/languages","stargazers_url":"https://api.github.com/repos/Pyriphlegethon/rust-clippy/stargazers","contributors_url":"https://api.github.com/repos/Pyriphlegethon/rust-clippy/contributors","subscribers_url":"https://api.github.com/repos/Pyriphlegethon/rust-clippy/subscribers","subscription_url":"https://api.github.com/repos/Pyriphlegethon/rust-clippy/subscription","commits_url":"https://api.github.com/repos/Pyriphlegethon/rust-clippy/commits{/sha}","git_commits_url":"https://api.github.com/repos/Pyriphlegethon/rust-clippy/git/commits{/sha}","comments_url":"https://api.github.com/repos/Pyriphlegethon/rust-clippy/comments{/number}","issue_comment_url":"https://api.github.com/repos/Pyriphlegethon/rust-clippy/issues/comments{/number}","contents_url":"https://api.github.com/repos/Pyriphlegethon/rust-clippy/contents/{+path}","compare_url":"https://api.github.com/repos/Pyriphlegethon/rust-clippy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Pyriphlegethon/rust-clippy/merges","archive_url":"https://api.github.com/repos/Pyriphlegethon/rust-clippy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Pyriphlegethon/rust-clippy/downloads","issues_url":"https://api.github.com/repos/Pyriphlegethon/rust-clippy/issues{/number}","pulls_url":"https://api.github.com/repos/Pyriphlegethon/rust-clippy/pulls{/number}","milestones_url":"https://api.github.com/repos/Pyriphlegethon/rust-clippy/milestones{/number}","notifications_url":"https://api.github.com/repos/Pyriphlegethon/rust-clippy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Pyriphlegethon/rust-clippy/labels{/name}","releases_url":"https://api.github.com/repos/Pyriphlegethon/rust-clippy/releases{/id}","created_at":"2015-09-29T10:57:54Z","updated_at":"2015-09-29T10:57:55Z","pushed_at":"2015-10-07T11:47:55Z","git_url":"git://github.com/Pyriphlegethon/rust-clippy.git","ssh_url":"git@github.com:Pyriphlegethon/rust-clippy.git","clone_url":"https://github.com/Pyriphlegethon/rust-clippy.git","svn_url":"https://github.com/Pyriphlegethon/rust-clippy","homepage":"","size":686,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Manishearth:master","ref":"master","sha":"3e475e9588bbd0235a85b2b30b42e34b0bbdf36a","user":{"login":"Manishearth","id":1617736,"avatar_url":"https://avatars.githubusercontent.com/u/1617736?v=3","gravatar_id":"","url":"https://api.github.com/users/Manishearth","html_url":"https://github.com/Manishearth","followers_url":"https://api.github.com/users/Manishearth/followers","following_url":"https://api.github.com/users/Manishearth/following{/other_user}","gists_url":"https://api.github.com/users/Manishearth/gists{/gist_id}","starred_url":"https://api.github.com/users/Manishearth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Manishearth/subscriptions","organizations_url":"https://api.github.com/users/Manishearth/orgs","repos_url":"https://api.github.com/users/Manishearth/repos","events_url":"https://api.github.com/users/Manishearth/events{/privacy}","received_events_url":"https://api.github.com/users/Manishearth/received_events","type":"User","site_admin":false},"repo":{"id":26850443,"name":"rust-clippy","full_name":"Manishearth/rust-clippy","owner":{"login":"Manishearth","id":1617736,"avatar_url":"https://avatars.githubusercontent.com/u/1617736?v=3","gravatar_id":"","url":"https://api.github.com/users/Manishearth","html_url":"https://github.com/Manishearth","followers_url":"https://api.github.com/users/Manishearth/followers","following_url":"https://api.github.com/users/Manishearth/following{/other_user}","gists_url":"https://api.github.com/users/Manishearth/gists{/gist_id}","starred_url":"https://api.github.com/users/Manishearth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Manishearth/subscriptions","organizations_url":"https://api.github.com/users/Manishearth/orgs","repos_url":"https://api.github.com/users/Manishearth/repos","events_url":"https://api.github.com/users/Manishearth/events{/privacy}","received_events_url":"https://api.github.com/users/Manishearth/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Manishearth/rust-clippy","description":"A bunch of lints to catch common mistakes and improve your Rust code","fork":false,"url":"https://api.github.com/repos/Manishearth/rust-clippy","forks_url":"https://api.github.com/repos/Manishearth/rust-clippy/forks","keys_url":"https://api.github.com/repos/Manishearth/rust-clippy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Manishearth/rust-clippy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Manishearth/rust-clippy/teams","hooks_url":"https://api.github.com/repos/Manishearth/rust-clippy/hooks","issue_events_url":"https://api.github.com/repos/Manishearth/rust-clippy/issues/events{/number}","events_url":"https://api.github.com/repos/Manishearth/rust-clippy/events","assignees_url":"https://api.github.com/repos/Manishearth/rust-clippy/assignees{/user}","branches_url":"https://api.github.com/repos/Manishearth/rust-clippy/branches{/branch}","tags_url":"https://api.github.com/repos/Manishearth/rust-clippy/tags","blobs_url":"https://api.github.com/repos/Manishearth/rust-clippy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Manishearth/rust-clippy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Manishearth/rust-clippy/git/refs{/sha}","trees_url":"https://api.github.com/repos/Manishearth/rust-clippy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Manishearth/rust-clippy/statuses/{sha}","languages_url":"https://api.github.com/repos/Manishearth/rust-clippy/languages","stargazers_url":"https://api.github.com/repos/Manishearth/rust-clippy/stargazers","contributors_url":"https://api.github.com/repos/Manishearth/rust-clippy/contributors","subscribers_url":"https://api.github.com/repos/Manishearth/rust-clippy/subscribers","subscription_url":"https://api.github.com/repos/Manishearth/rust-clippy/subscription","commits_url":"https://api.github.com/repos/Manishearth/rust-clippy/commits{/sha}","git_commits_url":"https://api.github.com/repos/Manishearth/rust-clippy/git/commits{/sha}","comments_url":"https://api.github.com/repos/Manishearth/rust-clippy/comments{/number}","issue_comment_url":"https://api.github.com/repos/Manishearth/rust-clippy/issues/comments{/number}","contents_url":"https://api.github.com/repos/Manishearth/rust-clippy/contents/{+path}","compare_url":"https://api.github.com/repos/Manishearth/rust-clippy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Manishearth/rust-clippy/merges","archive_url":"https://api.github.com/repos/Manishearth/rust-clippy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Manishearth/rust-clippy/downloads","issues_url":"https://api.github.com/repos/Manishearth/rust-clippy/issues{/number}","pulls_url":"https://api.github.com/repos/Manishearth/rust-clippy/pulls{/number}","milestones_url":"https://api.github.com/repos/Manishearth/rust-clippy/milestones{/number}","notifications_url":"https://api.github.com/repos/Manishearth/rust-clippy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Manishearth/rust-clippy/labels{/name}","releases_url":"https://api.github.com/repos/Manishearth/rust-clippy/releases{/id}","created_at":"2014-11-19T07:49:21Z","updated_at":"2015-10-06T19:07:18Z","pushed_at":"2015-10-07T11:50:36Z","git_url":"git://github.com/Manishearth/rust-clippy.git","ssh_url":"git@github.com:Manishearth/rust-clippy.git","clone_url":"https://github.com/Manishearth/rust-clippy.git","svn_url":"https://github.com/Manishearth/rust-clippy","homepage":"","size":2210,"stargazers_count":311,"watchers_count":311,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":35,"mirror_url":null,"open_issues_count":69,"forks":35,"open_issues":69,"watchers":311,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Manishearth/rust-clippy/pulls/366"},"html":{"href":"https://github.com/Manishearth/rust-clippy/pull/366"},"issue":{"href":"https://api.github.com/repos/Manishearth/rust-clippy/issues/366"},"comments":{"href":"https://api.github.com/repos/Manishearth/rust-clippy/issues/366/comments"},"review_comments":{"href":"https://api.github.com/repos/Manishearth/rust-clippy/pulls/366/comments"},"review_comment":{"href":"https://api.github.com/repos/Manishearth/rust-clippy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Manishearth/rust-clippy/pulls/366/commits"},"statuses":{"href":"https://api.github.com/repos/Manishearth/rust-clippy/statuses/7644f8e2a1774c426f520efc50fe3626b31e028c"}}}}