{"action":"closed","number":22299,"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/22299","id":29296510,"html_url":"https://github.com/rust-lang/rust/pull/22299","diff_url":"https://github.com/rust-lang/rust/pull/22299.diff","patch_url":"https://github.com/rust-lang/rust/pull/22299.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/22299","number":22299,"state":"closed","locked":false,"title":"Remove ExactSizeIterator from 64-bit ranges.","user":{"login":"bluss","id":3209739,"avatar_url":"https://avatars.githubusercontent.com/u/3209739?v=3","gravatar_id":"","url":"https://api.github.com/users/bluss","html_url":"https://github.com/bluss","followers_url":"https://api.github.com/users/bluss/followers","following_url":"https://api.github.com/users/bluss/following{/other_user}","gists_url":"https://api.github.com/users/bluss/gists{/gist_id}","starred_url":"https://api.github.com/users/bluss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bluss/subscriptions","organizations_url":"https://api.github.com/users/bluss/orgs","repos_url":"https://api.github.com/users/bluss/repos","events_url":"https://api.github.com/users/bluss/events{/privacy}","received_events_url":"https://api.github.com/users/bluss/received_events","type":"User","site_admin":false},"body":"Fixes #22047\r\n\r\n`Range<u64>` and `Range<i64>` may be longer than usize::MAX on 32-bit\r\nplatforms, and thus they cannot fulfill the protocol for\r\nExactSizeIterator. We don't want a nonobvious platform dependency in\r\nbasic iterator traits, so the trait impl is removed.\r\n\r\nThe logic of this change assumes that usize is at least 32-bit.\r\n\r\nThis is technically a breaking change; note that `Range<usize>` and\r\n`Range<isize>` are always ExactSizeIterators.\r\n\r\n[breaking-change]","created_at":"2015-02-13T20:29:32Z","updated_at":"2015-02-16T03:52:37Z","closed_at":"2015-02-16T03:52:37Z","merged_at":"2015-02-16T03:52:37Z","merge_commit_sha":"9fd5383246467b762969c46571064752843b403e","assignee":{"login":"aturon","id":709807,"avatar_url":"https://avatars.githubusercontent.com/u/709807?v=3","gravatar_id":"","url":"https://api.github.com/users/aturon","html_url":"https://github.com/aturon","followers_url":"https://api.github.com/users/aturon/followers","following_url":"https://api.github.com/users/aturon/following{/other_user}","gists_url":"https://api.github.com/users/aturon/gists{/gist_id}","starred_url":"https://api.github.com/users/aturon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aturon/subscriptions","organizations_url":"https://api.github.com/users/aturon/orgs","repos_url":"https://api.github.com/users/aturon/repos","events_url":"https://api.github.com/users/aturon/events{/privacy}","received_events_url":"https://api.github.com/users/aturon/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/22299/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/22299/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments/{number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/22299/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/b19fda0ceb820af57f00976951dba95a3c0419aa","head":{"label":"bluss:range-64-is-not-exact-size","ref":"range-64-is-not-exact-size","sha":"b19fda0ceb820af57f00976951dba95a3c0419aa","user":{"login":"bluss","id":3209739,"avatar_url":"https://avatars.githubusercontent.com/u/3209739?v=3","gravatar_id":"","url":"https://api.github.com/users/bluss","html_url":"https://github.com/bluss","followers_url":"https://api.github.com/users/bluss/followers","following_url":"https://api.github.com/users/bluss/following{/other_user}","gists_url":"https://api.github.com/users/bluss/gists{/gist_id}","starred_url":"https://api.github.com/users/bluss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bluss/subscriptions","organizations_url":"https://api.github.com/users/bluss/orgs","repos_url":"https://api.github.com/users/bluss/repos","events_url":"https://api.github.com/users/bluss/events{/privacy}","received_events_url":"https://api.github.com/users/bluss/received_events","type":"User","site_admin":false},"repo":{"id":27685739,"name":"rust","full_name":"bluss/rust","owner":{"login":"bluss","id":3209739,"avatar_url":"https://avatars.githubusercontent.com/u/3209739?v=3","gravatar_id":"","url":"https://api.github.com/users/bluss","html_url":"https://github.com/bluss","followers_url":"https://api.github.com/users/bluss/followers","following_url":"https://api.github.com/users/bluss/following{/other_user}","gists_url":"https://api.github.com/users/bluss/gists{/gist_id}","starred_url":"https://api.github.com/users/bluss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bluss/subscriptions","organizations_url":"https://api.github.com/users/bluss/orgs","repos_url":"https://api.github.com/users/bluss/repos","events_url":"https://api.github.com/users/bluss/events{/privacy}","received_events_url":"https://api.github.com/users/bluss/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bluss/rust","description":"a safe, concurrent, practical language","fork":true,"url":"https://api.github.com/repos/bluss/rust","forks_url":"https://api.github.com/repos/bluss/rust/forks","keys_url":"https://api.github.com/repos/bluss/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bluss/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bluss/rust/teams","hooks_url":"https://api.github.com/repos/bluss/rust/hooks","issue_events_url":"https://api.github.com/repos/bluss/rust/issues/events{/number}","events_url":"https://api.github.com/repos/bluss/rust/events","assignees_url":"https://api.github.com/repos/bluss/rust/assignees{/user}","branches_url":"https://api.github.com/repos/bluss/rust/branches{/branch}","tags_url":"https://api.github.com/repos/bluss/rust/tags","blobs_url":"https://api.github.com/repos/bluss/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bluss/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bluss/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/bluss/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bluss/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/bluss/rust/languages","stargazers_url":"https://api.github.com/repos/bluss/rust/stargazers","contributors_url":"https://api.github.com/repos/bluss/rust/contributors","subscribers_url":"https://api.github.com/repos/bluss/rust/subscribers","subscription_url":"https://api.github.com/repos/bluss/rust/subscription","commits_url":"https://api.github.com/repos/bluss/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/bluss/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/bluss/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/bluss/rust/issues/comments/{number}","contents_url":"https://api.github.com/repos/bluss/rust/contents/{+path}","compare_url":"https://api.github.com/repos/bluss/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bluss/rust/merges","archive_url":"https://api.github.com/repos/bluss/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bluss/rust/downloads","issues_url":"https://api.github.com/repos/bluss/rust/issues{/number}","pulls_url":"https://api.github.com/repos/bluss/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/bluss/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/bluss/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bluss/rust/labels{/name}","releases_url":"https://api.github.com/repos/bluss/rust/releases{/id}","created_at":"2014-12-07T21:37:14Z","updated_at":"2014-12-07T21:37:24Z","pushed_at":"2015-02-13T20:27:30Z","git_url":"git://github.com/bluss/rust.git","ssh_url":"git@github.com:bluss/rust.git","clone_url":"https://github.com/bluss/rust.git","svn_url":"https://github.com/bluss/rust","homepage":"http://www.rust-lang.org","size":232951,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"cf636c233dfeef5abf0de8fb35e23c0a161810d2","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"name":"rust","full_name":"rust-lang/rust","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/rust","description":"a safe, concurrent, practical language","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments/{number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","created_at":"2010-06-16T20:39:03Z","updated_at":"2015-02-16T03:52:22Z","pushed_at":"2015-02-16T03:52:24Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"http://www.rust-lang.org","size":476329,"stargazers_count":9394,"watchers_count":9394,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1798,"mirror_url":null,"open_issues_count":1978,"forks":1798,"open_issues":1978,"watchers":9394,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/22299"},"html":{"href":"https://github.com/rust-lang/rust/pull/22299"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/22299"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/22299/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/22299/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/22299/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/b19fda0ceb820af57f00976951dba95a3c0419aa"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"bors","id":3372342,"avatar_url":"https://avatars.githubusercontent.com/u/3372342?v=3","gravatar_id":"","url":"https://api.github.com/users/bors","html_url":"https://github.com/bors","followers_url":"https://api.github.com/users/bors/followers","following_url":"https://api.github.com/users/bors/following{/other_user}","gists_url":"https://api.github.com/users/bors/gists{/gist_id}","starred_url":"https://api.github.com/users/bors/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bors/subscriptions","organizations_url":"https://api.github.com/users/bors/orgs","repos_url":"https://api.github.com/users/bors/repos","events_url":"https://api.github.com/users/bors/events{/privacy}","received_events_url":"https://api.github.com/users/bors/received_events","type":"User","site_admin":false},"comments":5,"review_comments":0,"commits":1,"additions":2,"deletions":2,"changed_files":1}}