{"action":"created","issue":{"url":"https://api.github.com/repos/WASdev/ci.maven/issues/45","labels_url":"https://api.github.com/repos/WASdev/ci.maven/issues/45/labels{/name}","comments_url":"https://api.github.com/repos/WASdev/ci.maven/issues/45/comments","events_url":"https://api.github.com/repos/WASdev/ci.maven/issues/45/events","html_url":"https://github.com/WASdev/ci.maven/issues/45","id":107533296,"number":45,"title":"Change install to be a goal rather than a configuration setting","user":{"login":"katheris","id":11195226,"avatar_url":"https://avatars.githubusercontent.com/u/11195226?v=3","gravatar_id":"","url":"https://api.github.com/users/katheris","html_url":"https://github.com/katheris","followers_url":"https://api.github.com/users/katheris/followers","following_url":"https://api.github.com/users/katheris/following{/other_user}","gists_url":"https://api.github.com/users/katheris/gists{/gist_id}","starred_url":"https://api.github.com/users/katheris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/katheris/subscriptions","organizations_url":"https://api.github.com/users/katheris/orgs","repos_url":"https://api.github.com/users/katheris/repos","events_url":"https://api.github.com/users/katheris/events{/privacy}","received_events_url":"https://api.github.com/users/katheris/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-09-21T15:08:33Z","updated_at":"2015-09-21T15:58:32Z","closed_at":null,"body":"Currently installation of Liberty happens depending on what configuration properties you set. This means that you have to write a lot more code if you want the user to be able to choose per build whether they supply their own Liberty.\r\n\r\nIt would be better if we could supply one property e.g. installDir and then if we run the install goal Liberty is installed into installDir and if we don't then the plugin assumes that installDir points to our existing install.\r\n\r\nThe current way I am getting around this problem is creating profiles for each type of install which is a lot of code and added complexity that I would rather not force upon the user."},"comment":{"url":"https://api.github.com/repos/WASdev/ci.maven/issues/comments/142026444","html_url":"https://github.com/WASdev/ci.maven/issues/45#issuecomment-142026444","issue_url":"https://api.github.com/repos/WASdev/ci.maven/issues/45","id":142026444,"user":{"login":"katheris","id":11195226,"avatar_url":"https://avatars.githubusercontent.com/u/11195226?v=3","gravatar_id":"","url":"https://api.github.com/users/katheris","html_url":"https://github.com/katheris","followers_url":"https://api.github.com/users/katheris/followers","following_url":"https://api.github.com/users/katheris/following{/other_user}","gists_url":"https://api.github.com/users/katheris/gists{/gist_id}","starred_url":"https://api.github.com/users/katheris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/katheris/subscriptions","organizations_url":"https://api.github.com/users/katheris/orgs","repos_url":"https://api.github.com/users/katheris/repos","events_url":"https://api.github.com/users/katheris/events{/privacy}","received_events_url":"https://api.github.com/users/katheris/received_events","type":"User","site_admin":false},"created_at":"2015-09-21T15:58:32Z","updated_at":"2015-09-21T15:58:32Z","body":"So today I have to define:\r\n       <profile>\r\n           <id>install-liberty-from-plugin</id>\r\n             <activation>\r\n                 <property>\r\n                    <name>libertyLicense</name>\r\n                 </property>\r\n            </activation>\r\n            <build>\r\n                <plugins>\r\n                    <!-- Enable liberty-maven-plugin -->\r\n                    <plugin>\r\n                        <groupId>net.wasdev.wlp.maven.plugins</groupId>\r\n                        <artifactId>liberty-maven-plugin</artifactId>\r\n                        <version>1.1-SNAPSHOT</version>\r\n                        <configuration>\r\n                            <install>\r\n                                <licenseCode>${libertyLicense}</licenseCode>\r\n                                <version>8.5.5_06</version>\r\n                            </install>\r\n                           <assemblyInstallDirectory>${libertyBaseDir}</assemblyInstallDirectory>\r\n                        </configuration>\r\n                    </plugin>\r\n                 </plugins>\r\n             </build>\r\n        </profile>\r\n        <profile>\r\n            <!-- To install liberty set the current Liberty license code as the system\r\n                 property libertyLicense. See github docs for more details. -->\r\n            <id>not-installing-liberty</id>\r\n            <activation>\r\n                <property>\r\n                    <name>!libertyLicense</name>\r\n                </property>\r\n            </activation>\r\n            <build>\r\n                <plugins>\r\n                    <!-- Enable liberty-maven-plugin -->\r\n                    <plugin>\r\n                        <groupId>net.wasdev.wlp.maven.plugins</groupId>\r\n                        <artifactId>liberty-maven-plugin</artifactId>\r\n                        <version>1.1-SNAPSHOT</version>\r\n                        <configuration>\r\n                            <installDirectory>${libertyBaseDir}/wlp</installDirectory>\r\n                        </configuration>\r\n                    </plugin>\r\n                 </plugins>\r\n             </build>\r\n        </profile>\r\nbut actually I want:\r\n\r\n        <profile>\r\n            <id>install-liberty-from-plugin</id>\r\n            <activation>\r\n                 <property>\r\n                    <name>libertyLicense</name>\r\n                 </property>\r\n            </activation>\r\n            <build>\r\n                <plugins>\r\n                    <!-- Enable liberty-maven-plugin -->\r\n                    <plugin>\r\n                        <groupId>net.wasdev.wlp.maven.plugins</groupId>\r\n                        <artifactId>liberty-maven-plugin</artifactId>\r\n                       <version>1.1-SNAPSHOT</version>\r\n\t\t\t<executions>\r\n\t\t\t\t<execution>\r\n\t\t                   <goals>\r\n\t\t\t\t\t<goal>\r\n\t\t                            <install>\r\n\t\t                                <licenseCode>${libertyLicense}</licenseCode>\r\n\t\t                                <version>8.5.5_06</version>\r\n\t\t                            </install>\r\n\t\t                           </goal>\r\n\t\t                        </goals>\r\n\t\t\t\t    </execution>\r\n\t\t\t\t</executions>\r\n                      </plugin>\r\n                 </plugins>\r\n             </build>\r\n        </profile>"}}