{"action":"created","issue":{"url":"https://api.github.com/repos/rails/protected_attributes/issues/54","labels_url":"https://api.github.com/repos/rails/protected_attributes/issues/54/labels{/name}","comments_url":"https://api.github.com/repos/rails/protected_attributes/issues/54/comments","events_url":"https://api.github.com/repos/rails/protected_attributes/issues/54/events","html_url":"https://github.com/rails/protected_attributes/pull/54","id":53559599,"number":54,"title":"fix broken through_association from addition of build_record method in rails","user":{"login":"jGRUBBS","id":338605,"avatar_url":"https://avatars.githubusercontent.com/u/338605?v=3","gravatar_id":"","url":"https://api.github.com/users/jGRUBBS","html_url":"https://github.com/jGRUBBS","followers_url":"https://api.github.com/users/jGRUBBS/followers","following_url":"https://api.github.com/users/jGRUBBS/following{/other_user}","gists_url":"https://api.github.com/users/jGRUBBS/gists{/gist_id}","starred_url":"https://api.github.com/users/jGRUBBS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jGRUBBS/subscriptions","organizations_url":"https://api.github.com/users/jGRUBBS/orgs","repos_url":"https://api.github.com/users/jGRUBBS/repos","events_url":"https://api.github.com/users/jGRUBBS/events{/privacy}","received_events_url":"https://api.github.com/users/jGRUBBS/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-01-06T20:32:39Z","updated_at":"2015-01-22T03:39:46Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/rails/protected_attributes/pulls/54","html_url":"https://github.com/rails/protected_attributes/pull/54","diff_url":"https://github.com/rails/protected_attributes/pull/54.diff","patch_url":"https://github.com/rails/protected_attributes/pull/54.patch"},"body":"fixes #53 \r\n\r\n@rafaelfranca I noticed when I first commented on #53 that I was running from rails 4.2.0.beta2 locally and that was why there was 119 failures. I updated to Rails 4.2.0 and all tests were passing. I then set my Gemfile to Rails 4-2-stable and saw the `test_has_many_through_build_with_attr_accessible_attributes` fail with the same error as @dandlezzz:\r\n`ArgumentError (wrong number of arguments (2 for 1))`\r\n\r\nI looked back at Rails 3.2 to see how the `ThroughAssociation` was handling `build_record` and saw that it was just using the base `Association` class implementation so I copied that over into a monkey patch for `ThroughAssociation`. This fixes the failure and all tests now pass again. Let me know if this is good for you, happy to make updates."},"comment":{"url":"https://api.github.com/repos/rails/protected_attributes/issues/comments/70966985","html_url":"https://github.com/rails/protected_attributes/pull/54#issuecomment-70966985","issue_url":"https://api.github.com/repos/rails/protected_attributes/issues/54","id":70966985,"user":{"login":"mcfiredrill","id":66243,"avatar_url":"https://avatars.githubusercontent.com/u/66243?v=3","gravatar_id":"","url":"https://api.github.com/users/mcfiredrill","html_url":"https://github.com/mcfiredrill","followers_url":"https://api.github.com/users/mcfiredrill/followers","following_url":"https://api.github.com/users/mcfiredrill/following{/other_user}","gists_url":"https://api.github.com/users/mcfiredrill/gists{/gist_id}","starred_url":"https://api.github.com/users/mcfiredrill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcfiredrill/subscriptions","organizations_url":"https://api.github.com/users/mcfiredrill/orgs","repos_url":"https://api.github.com/users/mcfiredrill/repos","events_url":"https://api.github.com/users/mcfiredrill/events{/privacy}","received_events_url":"https://api.github.com/users/mcfiredrill/received_events","type":"User","site_admin":false},"created_at":"2015-01-22T03:39:46Z","updated_at":"2015-01-22T03:39:46Z","body":"Ah ok got it, assumed the default Gemfile was for 4.2. :+1: "}}