{"action":"closed","number":141,"pull_request":{"url":"https://api.github.com/repos/chessmasterhong/WaterEmblem/pulls/141","id":28614182,"html_url":"https://github.com/chessmasterhong/WaterEmblem/pull/141","diff_url":"https://github.com/chessmasterhong/WaterEmblem/pull/141.diff","patch_url":"https://github.com/chessmasterhong/WaterEmblem/pull/141.patch","issue_url":"https://api.github.com/repos/chessmasterhong/WaterEmblem/issues/141","number":141,"state":"closed","locked":false,"title":"Implemented shop enhancements","user":{"login":"DrkSephy","id":1226900,"avatar_url":"https://avatars.githubusercontent.com/u/1226900?v=3","gravatar_id":"","url":"https://api.github.com/users/DrkSephy","html_url":"https://github.com/DrkSephy","followers_url":"https://api.github.com/users/DrkSephy/followers","following_url":"https://api.github.com/users/DrkSephy/following{/other_user}","gists_url":"https://api.github.com/users/DrkSephy/gists{/gist_id}","starred_url":"https://api.github.com/users/DrkSephy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DrkSephy/subscriptions","organizations_url":"https://api.github.com/users/DrkSephy/orgs","repos_url":"https://api.github.com/users/DrkSephy/repos","events_url":"https://api.github.com/users/DrkSephy/events{/privacy}","received_events_url":"https://api.github.com/users/DrkSephy/received_events","type":"User","site_admin":false},"body":"You will need the latest media from https://bitbucket.org/chessmasterhong/wateremblem-media/downloads to run this. \r\n\r\nThis pull request addresses issue #133. On top of enhancing the shop system, I went ahead and also implemented a confirmation system too. Clicking an item will prompt the player with a `Yes` or `No` option, both for buy and sell. Almost all messages are on a timer, to make it feel a little more real. \r\nAlso covered cases where the player cannot afford to buy the item in question, or has a full inventory - the appropriate text is displayed on a timer. \r\n\r\nEDIT: I've also added some new properties that space out messages in the shop. For example, purchasing an item will:\r\n\r\n* Show a message saying you have purchased `<item>`, then after 1.5 seconds, it will re-display the buy/sell/exit buttons. \r\n\r\nThis behavior occurs for both buying and selling, to add some flow and separation between buying, selling, waiting for the user to press yes/no to confirm their choice, etc. As of now, the shop system fully resembles a shop in an actual Fire Emblem game (or any game with a shop, in general). ","created_at":"2015-02-04T05:23:03Z","updated_at":"2015-02-04T17:21:50Z","closed_at":"2015-02-04T17:21:50Z","merged_at":"2015-02-04T17:21:50Z","merge_commit_sha":"0d8223192598b19a627f5de6e97052a31a1688fb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/chessmasterhong/WaterEmblem/pulls/141/commits","review_comments_url":"https://api.github.com/repos/chessmasterhong/WaterEmblem/pulls/141/comments","review_comment_url":"https://api.github.com/repos/chessmasterhong/WaterEmblem/pulls/comments/{number}","comments_url":"https://api.github.com/repos/chessmasterhong/WaterEmblem/issues/141/comments","statuses_url":"https://api.github.com/repos/chessmasterhong/WaterEmblem/statuses/8b82c86ba3cd373dce5749568edb2319f5caed6f","head":{"label":"DrkSephy:dev","ref":"dev","sha":"8b82c86ba3cd373dce5749568edb2319f5caed6f","user":{"login":"DrkSephy","id":1226900,"avatar_url":"https://avatars.githubusercontent.com/u/1226900?v=3","gravatar_id":"","url":"https://api.github.com/users/DrkSephy","html_url":"https://github.com/DrkSephy","followers_url":"https://api.github.com/users/DrkSephy/followers","following_url":"https://api.github.com/users/DrkSephy/following{/other_user}","gists_url":"https://api.github.com/users/DrkSephy/gists{/gist_id}","starred_url":"https://api.github.com/users/DrkSephy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DrkSephy/subscriptions","organizations_url":"https://api.github.com/users/DrkSephy/orgs","repos_url":"https://api.github.com/users/DrkSephy/repos","events_url":"https://api.github.com/users/DrkSephy/events{/privacy}","received_events_url":"https://api.github.com/users/DrkSephy/received_events","type":"User","site_admin":false},"repo":{"id":29379133,"name":"WaterEmblem","full_name":"DrkSephy/WaterEmblem","owner":{"login":"DrkSephy","id":1226900,"avatar_url":"https://avatars.githubusercontent.com/u/1226900?v=3","gravatar_id":"","url":"https://api.github.com/users/DrkSephy","html_url":"https://github.com/DrkSephy","followers_url":"https://api.github.com/users/DrkSephy/followers","following_url":"https://api.github.com/users/DrkSephy/following{/other_user}","gists_url":"https://api.github.com/users/DrkSephy/gists{/gist_id}","starred_url":"https://api.github.com/users/DrkSephy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DrkSephy/subscriptions","organizations_url":"https://api.github.com/users/DrkSephy/orgs","repos_url":"https://api.github.com/users/DrkSephy/repos","events_url":"https://api.github.com/users/DrkSephy/events{/privacy}","received_events_url":"https://api.github.com/users/DrkSephy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DrkSephy/WaterEmblem","description":"","fork":true,"url":"https://api.github.com/repos/DrkSephy/WaterEmblem","forks_url":"https://api.github.com/repos/DrkSephy/WaterEmblem/forks","keys_url":"https://api.github.com/repos/DrkSephy/WaterEmblem/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DrkSephy/WaterEmblem/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DrkSephy/WaterEmblem/teams","hooks_url":"https://api.github.com/repos/DrkSephy/WaterEmblem/hooks","issue_events_url":"https://api.github.com/repos/DrkSephy/WaterEmblem/issues/events{/number}","events_url":"https://api.github.com/repos/DrkSephy/WaterEmblem/events","assignees_url":"https://api.github.com/repos/DrkSephy/WaterEmblem/assignees{/user}","branches_url":"https://api.github.com/repos/DrkSephy/WaterEmblem/branches{/branch}","tags_url":"https://api.github.com/repos/DrkSephy/WaterEmblem/tags","blobs_url":"https://api.github.com/repos/DrkSephy/WaterEmblem/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DrkSephy/WaterEmblem/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DrkSephy/WaterEmblem/git/refs{/sha}","trees_url":"https://api.github.com/repos/DrkSephy/WaterEmblem/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DrkSephy/WaterEmblem/statuses/{sha}","languages_url":"https://api.github.com/repos/DrkSephy/WaterEmblem/languages","stargazers_url":"https://api.github.com/repos/DrkSephy/WaterEmblem/stargazers","contributors_url":"https://api.github.com/repos/DrkSephy/WaterEmblem/contributors","subscribers_url":"https://api.github.com/repos/DrkSephy/WaterEmblem/subscribers","subscription_url":"https://api.github.com/repos/DrkSephy/WaterEmblem/subscription","commits_url":"https://api.github.com/repos/DrkSephy/WaterEmblem/commits{/sha}","git_commits_url":"https://api.github.com/repos/DrkSephy/WaterEmblem/git/commits{/sha}","comments_url":"https://api.github.com/repos/DrkSephy/WaterEmblem/comments{/number}","issue_comment_url":"https://api.github.com/repos/DrkSephy/WaterEmblem/issues/comments/{number}","contents_url":"https://api.github.com/repos/DrkSephy/WaterEmblem/contents/{+path}","compare_url":"https://api.github.com/repos/DrkSephy/WaterEmblem/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DrkSephy/WaterEmblem/merges","archive_url":"https://api.github.com/repos/DrkSephy/WaterEmblem/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DrkSephy/WaterEmblem/downloads","issues_url":"https://api.github.com/repos/DrkSephy/WaterEmblem/issues{/number}","pulls_url":"https://api.github.com/repos/DrkSephy/WaterEmblem/pulls{/number}","milestones_url":"https://api.github.com/repos/DrkSephy/WaterEmblem/milestones{/number}","notifications_url":"https://api.github.com/repos/DrkSephy/WaterEmblem/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DrkSephy/WaterEmblem/labels{/name}","releases_url":"https://api.github.com/repos/DrkSephy/WaterEmblem/releases{/id}","created_at":"2015-01-17T03:59:25Z","updated_at":"2015-02-04T05:34:30Z","pushed_at":"2015-02-04T16:43:38Z","git_url":"git://github.com/DrkSephy/WaterEmblem.git","ssh_url":"git@github.com:DrkSephy/WaterEmblem.git","clone_url":"https://github.com/DrkSephy/WaterEmblem.git","svn_url":"https://github.com/DrkSephy/WaterEmblem","homepage":null,"size":2563,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"chessmasterhong:dev","ref":"dev","sha":"9c720f73174a19ef7e2a0435ae2223247133bb6f","user":{"login":"chessmasterhong","id":1214945,"avatar_url":"https://avatars.githubusercontent.com/u/1214945?v=3","gravatar_id":"","url":"https://api.github.com/users/chessmasterhong","html_url":"https://github.com/chessmasterhong","followers_url":"https://api.github.com/users/chessmasterhong/followers","following_url":"https://api.github.com/users/chessmasterhong/following{/other_user}","gists_url":"https://api.github.com/users/chessmasterhong/gists{/gist_id}","starred_url":"https://api.github.com/users/chessmasterhong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chessmasterhong/subscriptions","organizations_url":"https://api.github.com/users/chessmasterhong/orgs","repos_url":"https://api.github.com/users/chessmasterhong/repos","events_url":"https://api.github.com/users/chessmasterhong/events{/privacy}","received_events_url":"https://api.github.com/users/chessmasterhong/received_events","type":"User","site_admin":false},"repo":{"id":16974706,"name":"WaterEmblem","full_name":"chessmasterhong/WaterEmblem","owner":{"login":"chessmasterhong","id":1214945,"avatar_url":"https://avatars.githubusercontent.com/u/1214945?v=3","gravatar_id":"","url":"https://api.github.com/users/chessmasterhong","html_url":"https://github.com/chessmasterhong","followers_url":"https://api.github.com/users/chessmasterhong/followers","following_url":"https://api.github.com/users/chessmasterhong/following{/other_user}","gists_url":"https://api.github.com/users/chessmasterhong/gists{/gist_id}","starred_url":"https://api.github.com/users/chessmasterhong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chessmasterhong/subscriptions","organizations_url":"https://api.github.com/users/chessmasterhong/orgs","repos_url":"https://api.github.com/users/chessmasterhong/repos","events_url":"https://api.github.com/users/chessmasterhong/events{/privacy}","received_events_url":"https://api.github.com/users/chessmasterhong/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chessmasterhong/WaterEmblem","description":"","fork":false,"url":"https://api.github.com/repos/chessmasterhong/WaterEmblem","forks_url":"https://api.github.com/repos/chessmasterhong/WaterEmblem/forks","keys_url":"https://api.github.com/repos/chessmasterhong/WaterEmblem/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chessmasterhong/WaterEmblem/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chessmasterhong/WaterEmblem/teams","hooks_url":"https://api.github.com/repos/chessmasterhong/WaterEmblem/hooks","issue_events_url":"https://api.github.com/repos/chessmasterhong/WaterEmblem/issues/events{/number}","events_url":"https://api.github.com/repos/chessmasterhong/WaterEmblem/events","assignees_url":"https://api.github.com/repos/chessmasterhong/WaterEmblem/assignees{/user}","branches_url":"https://api.github.com/repos/chessmasterhong/WaterEmblem/branches{/branch}","tags_url":"https://api.github.com/repos/chessmasterhong/WaterEmblem/tags","blobs_url":"https://api.github.com/repos/chessmasterhong/WaterEmblem/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chessmasterhong/WaterEmblem/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chessmasterhong/WaterEmblem/git/refs{/sha}","trees_url":"https://api.github.com/repos/chessmasterhong/WaterEmblem/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chessmasterhong/WaterEmblem/statuses/{sha}","languages_url":"https://api.github.com/repos/chessmasterhong/WaterEmblem/languages","stargazers_url":"https://api.github.com/repos/chessmasterhong/WaterEmblem/stargazers","contributors_url":"https://api.github.com/repos/chessmasterhong/WaterEmblem/contributors","subscribers_url":"https://api.github.com/repos/chessmasterhong/WaterEmblem/subscribers","subscription_url":"https://api.github.com/repos/chessmasterhong/WaterEmblem/subscription","commits_url":"https://api.github.com/repos/chessmasterhong/WaterEmblem/commits{/sha}","git_commits_url":"https://api.github.com/repos/chessmasterhong/WaterEmblem/git/commits{/sha}","comments_url":"https://api.github.com/repos/chessmasterhong/WaterEmblem/comments{/number}","issue_comment_url":"https://api.github.com/repos/chessmasterhong/WaterEmblem/issues/comments/{number}","contents_url":"https://api.github.com/repos/chessmasterhong/WaterEmblem/contents/{+path}","compare_url":"https://api.github.com/repos/chessmasterhong/WaterEmblem/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chessmasterhong/WaterEmblem/merges","archive_url":"https://api.github.com/repos/chessmasterhong/WaterEmblem/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chessmasterhong/WaterEmblem/downloads","issues_url":"https://api.github.com/repos/chessmasterhong/WaterEmblem/issues{/number}","pulls_url":"https://api.github.com/repos/chessmasterhong/WaterEmblem/pulls{/number}","milestones_url":"https://api.github.com/repos/chessmasterhong/WaterEmblem/milestones{/number}","notifications_url":"https://api.github.com/repos/chessmasterhong/WaterEmblem/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chessmasterhong/WaterEmblem/labels{/name}","releases_url":"https://api.github.com/repos/chessmasterhong/WaterEmblem/releases{/id}","created_at":"2014-02-19T05:29:13Z","updated_at":"2015-02-04T02:50:52Z","pushed_at":"2015-02-04T17:21:50Z","git_url":"git://github.com/chessmasterhong/WaterEmblem.git","ssh_url":"git@github.com:chessmasterhong/WaterEmblem.git","clone_url":"https://github.com/chessmasterhong/WaterEmblem.git","svn_url":"https://github.com/chessmasterhong/WaterEmblem","homepage":null,"size":58483,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":8,"forks":4,"open_issues":8,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chessmasterhong/WaterEmblem/pulls/141"},"html":{"href":"https://github.com/chessmasterhong/WaterEmblem/pull/141"},"issue":{"href":"https://api.github.com/repos/chessmasterhong/WaterEmblem/issues/141"},"comments":{"href":"https://api.github.com/repos/chessmasterhong/WaterEmblem/issues/141/comments"},"review_comments":{"href":"https://api.github.com/repos/chessmasterhong/WaterEmblem/pulls/141/comments"},"review_comment":{"href":"https://api.github.com/repos/chessmasterhong/WaterEmblem/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/chessmasterhong/WaterEmblem/pulls/141/commits"},"statuses":{"href":"https://api.github.com/repos/chessmasterhong/WaterEmblem/statuses/8b82c86ba3cd373dce5749568edb2319f5caed6f"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"chessmasterhong","id":1214945,"avatar_url":"https://avatars.githubusercontent.com/u/1214945?v=3","gravatar_id":"","url":"https://api.github.com/users/chessmasterhong","html_url":"https://github.com/chessmasterhong","followers_url":"https://api.github.com/users/chessmasterhong/followers","following_url":"https://api.github.com/users/chessmasterhong/following{/other_user}","gists_url":"https://api.github.com/users/chessmasterhong/gists{/gist_id}","starred_url":"https://api.github.com/users/chessmasterhong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chessmasterhong/subscriptions","organizations_url":"https://api.github.com/users/chessmasterhong/orgs","repos_url":"https://api.github.com/users/chessmasterhong/repos","events_url":"https://api.github.com/users/chessmasterhong/events{/privacy}","received_events_url":"https://api.github.com/users/chessmasterhong/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":14,"additions":341,"deletions":50,"changed_files":11}}