{"action":"closed","number":379,"pull_request":{"url":"https://api.github.com/repos/pradels/vagrant-libvirt/pulls/379","id":36291448,"html_url":"https://github.com/pradels/vagrant-libvirt/pull/379","diff_url":"https://github.com/pradels/vagrant-libvirt/pull/379.diff","patch_url":"https://github.com/pradels/vagrant-libvirt/pull/379.patch","issue_url":"https://api.github.com/repos/pradels/vagrant-libvirt/issues/379","number":379,"state":"closed","locked":false,"title":"Don't raise an error when ip address is not found when calling ssh_info","user":{"login":"iNecas","id":190443,"avatar_url":"https://avatars.githubusercontent.com/u/190443?v=3","gravatar_id":"","url":"https://api.github.com/users/iNecas","html_url":"https://github.com/iNecas","followers_url":"https://api.github.com/users/iNecas/followers","following_url":"https://api.github.com/users/iNecas/following{/other_user}","gists_url":"https://api.github.com/users/iNecas/gists{/gist_id}","starred_url":"https://api.github.com/users/iNecas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iNecas/subscriptions","organizations_url":"https://api.github.com/users/iNecas/orgs","repos_url":"https://api.github.com/users/iNecas/repos","events_url":"https://api.github.com/users/iNecas/events{/privacy}","received_events_url":"https://api.github.com/users/iNecas/received_events","type":"User","site_admin":false},"body":"Vagrant defines that, when the ssh info is not available, the method should\nreturn nil, instead of raising exception: \nhttps://github.com/mitchellh/vagrant/blob/v1.7.2/lib/vagrant/plugin/v2/provider.rb#L52-L75\n\nAlso, as per \nhttps://github.com/mitchellh/vagrant/blob/efd1d5e11bfc5a72c7a1d1eae294b4751d841544/plugins/providers/virtualbox/provider.rb#L60\n, not getting into waiting for the ssh info when the machine is not running.\n\nThe motivation for this patch is the ansible integration issues when raising \nthe errors and waiting for the ssh info. See also: \nhttps://github.com/mitchellh/vagrant/pull/5743","created_at":"2015-05-27T10:56:23Z","updated_at":"2015-05-28T08:03:33Z","closed_at":"2015-05-28T08:03:33Z","merged_at":"2015-05-28T08:03:33Z","merge_commit_sha":"d948b0466cc4ccf1b916f1f128c977489e8572f2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/pradels/vagrant-libvirt/pulls/379/commits","review_comments_url":"https://api.github.com/repos/pradels/vagrant-libvirt/pulls/379/comments","review_comment_url":"https://api.github.com/repos/pradels/vagrant-libvirt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pradels/vagrant-libvirt/issues/379/comments","statuses_url":"https://api.github.com/repos/pradels/vagrant-libvirt/statuses/ba619e04bb007a48d9f6656eeb1f331aa8392ce8","head":{"label":"iNecas:no-exception-when-ip-not-ready","ref":"no-exception-when-ip-not-ready","sha":"ba619e04bb007a48d9f6656eeb1f331aa8392ce8","user":{"login":"iNecas","id":190443,"avatar_url":"https://avatars.githubusercontent.com/u/190443?v=3","gravatar_id":"","url":"https://api.github.com/users/iNecas","html_url":"https://github.com/iNecas","followers_url":"https://api.github.com/users/iNecas/followers","following_url":"https://api.github.com/users/iNecas/following{/other_user}","gists_url":"https://api.github.com/users/iNecas/gists{/gist_id}","starred_url":"https://api.github.com/users/iNecas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iNecas/subscriptions","organizations_url":"https://api.github.com/users/iNecas/orgs","repos_url":"https://api.github.com/users/iNecas/repos","events_url":"https://api.github.com/users/iNecas/events{/privacy}","received_events_url":"https://api.github.com/users/iNecas/received_events","type":"User","site_admin":false},"repo":{"id":36307080,"name":"vagrant-libvirt","full_name":"iNecas/vagrant-libvirt","owner":{"login":"iNecas","id":190443,"avatar_url":"https://avatars.githubusercontent.com/u/190443?v=3","gravatar_id":"","url":"https://api.github.com/users/iNecas","html_url":"https://github.com/iNecas","followers_url":"https://api.github.com/users/iNecas/followers","following_url":"https://api.github.com/users/iNecas/following{/other_user}","gists_url":"https://api.github.com/users/iNecas/gists{/gist_id}","starred_url":"https://api.github.com/users/iNecas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iNecas/subscriptions","organizations_url":"https://api.github.com/users/iNecas/orgs","repos_url":"https://api.github.com/users/iNecas/repos","events_url":"https://api.github.com/users/iNecas/events{/privacy}","received_events_url":"https://api.github.com/users/iNecas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/iNecas/vagrant-libvirt","description":"Vagrant provider for libvirt.","fork":true,"url":"https://api.github.com/repos/iNecas/vagrant-libvirt","forks_url":"https://api.github.com/repos/iNecas/vagrant-libvirt/forks","keys_url":"https://api.github.com/repos/iNecas/vagrant-libvirt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iNecas/vagrant-libvirt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iNecas/vagrant-libvirt/teams","hooks_url":"https://api.github.com/repos/iNecas/vagrant-libvirt/hooks","issue_events_url":"https://api.github.com/repos/iNecas/vagrant-libvirt/issues/events{/number}","events_url":"https://api.github.com/repos/iNecas/vagrant-libvirt/events","assignees_url":"https://api.github.com/repos/iNecas/vagrant-libvirt/assignees{/user}","branches_url":"https://api.github.com/repos/iNecas/vagrant-libvirt/branches{/branch}","tags_url":"https://api.github.com/repos/iNecas/vagrant-libvirt/tags","blobs_url":"https://api.github.com/repos/iNecas/vagrant-libvirt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iNecas/vagrant-libvirt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iNecas/vagrant-libvirt/git/refs{/sha}","trees_url":"https://api.github.com/repos/iNecas/vagrant-libvirt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iNecas/vagrant-libvirt/statuses/{sha}","languages_url":"https://api.github.com/repos/iNecas/vagrant-libvirt/languages","stargazers_url":"https://api.github.com/repos/iNecas/vagrant-libvirt/stargazers","contributors_url":"https://api.github.com/repos/iNecas/vagrant-libvirt/contributors","subscribers_url":"https://api.github.com/repos/iNecas/vagrant-libvirt/subscribers","subscription_url":"https://api.github.com/repos/iNecas/vagrant-libvirt/subscription","commits_url":"https://api.github.com/repos/iNecas/vagrant-libvirt/commits{/sha}","git_commits_url":"https://api.github.com/repos/iNecas/vagrant-libvirt/git/commits{/sha}","comments_url":"https://api.github.com/repos/iNecas/vagrant-libvirt/comments{/number}","issue_comment_url":"https://api.github.com/repos/iNecas/vagrant-libvirt/issues/comments{/number}","contents_url":"https://api.github.com/repos/iNecas/vagrant-libvirt/contents/{+path}","compare_url":"https://api.github.com/repos/iNecas/vagrant-libvirt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iNecas/vagrant-libvirt/merges","archive_url":"https://api.github.com/repos/iNecas/vagrant-libvirt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iNecas/vagrant-libvirt/downloads","issues_url":"https://api.github.com/repos/iNecas/vagrant-libvirt/issues{/number}","pulls_url":"https://api.github.com/repos/iNecas/vagrant-libvirt/pulls{/number}","milestones_url":"https://api.github.com/repos/iNecas/vagrant-libvirt/milestones{/number}","notifications_url":"https://api.github.com/repos/iNecas/vagrant-libvirt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iNecas/vagrant-libvirt/labels{/name}","releases_url":"https://api.github.com/repos/iNecas/vagrant-libvirt/releases{/id}","created_at":"2015-05-26T15:57:15Z","updated_at":"2015-05-26T15:57:15Z","pushed_at":"2015-05-27T10:57:13Z","git_url":"git://github.com/iNecas/vagrant-libvirt.git","ssh_url":"git@github.com:iNecas/vagrant-libvirt.git","clone_url":"https://github.com/iNecas/vagrant-libvirt.git","svn_url":"https://github.com/iNecas/vagrant-libvirt","homepage":null,"size":2171,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pradels:master","ref":"master","sha":"27710febe5c9c33307fdb10e2290bd64a13f68bd","user":{"login":"pradels","id":3978266,"avatar_url":"https://avatars.githubusercontent.com/u/3978266?v=3","gravatar_id":"","url":"https://api.github.com/users/pradels","html_url":"https://github.com/pradels","followers_url":"https://api.github.com/users/pradels/followers","following_url":"https://api.github.com/users/pradels/following{/other_user}","gists_url":"https://api.github.com/users/pradels/gists{/gist_id}","starred_url":"https://api.github.com/users/pradels/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pradels/subscriptions","organizations_url":"https://api.github.com/users/pradels/orgs","repos_url":"https://api.github.com/users/pradels/repos","events_url":"https://api.github.com/users/pradels/events{/privacy}","received_events_url":"https://api.github.com/users/pradels/received_events","type":"User","site_admin":false},"repo":{"id":9043012,"name":"vagrant-libvirt","full_name":"pradels/vagrant-libvirt","owner":{"login":"pradels","id":3978266,"avatar_url":"https://avatars.githubusercontent.com/u/3978266?v=3","gravatar_id":"","url":"https://api.github.com/users/pradels","html_url":"https://github.com/pradels","followers_url":"https://api.github.com/users/pradels/followers","following_url":"https://api.github.com/users/pradels/following{/other_user}","gists_url":"https://api.github.com/users/pradels/gists{/gist_id}","starred_url":"https://api.github.com/users/pradels/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pradels/subscriptions","organizations_url":"https://api.github.com/users/pradels/orgs","repos_url":"https://api.github.com/users/pradels/repos","events_url":"https://api.github.com/users/pradels/events{/privacy}","received_events_url":"https://api.github.com/users/pradels/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pradels/vagrant-libvirt","description":"Vagrant provider for libvirt.","fork":false,"url":"https://api.github.com/repos/pradels/vagrant-libvirt","forks_url":"https://api.github.com/repos/pradels/vagrant-libvirt/forks","keys_url":"https://api.github.com/repos/pradels/vagrant-libvirt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pradels/vagrant-libvirt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pradels/vagrant-libvirt/teams","hooks_url":"https://api.github.com/repos/pradels/vagrant-libvirt/hooks","issue_events_url":"https://api.github.com/repos/pradels/vagrant-libvirt/issues/events{/number}","events_url":"https://api.github.com/repos/pradels/vagrant-libvirt/events","assignees_url":"https://api.github.com/repos/pradels/vagrant-libvirt/assignees{/user}","branches_url":"https://api.github.com/repos/pradels/vagrant-libvirt/branches{/branch}","tags_url":"https://api.github.com/repos/pradels/vagrant-libvirt/tags","blobs_url":"https://api.github.com/repos/pradels/vagrant-libvirt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pradels/vagrant-libvirt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pradels/vagrant-libvirt/git/refs{/sha}","trees_url":"https://api.github.com/repos/pradels/vagrant-libvirt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pradels/vagrant-libvirt/statuses/{sha}","languages_url":"https://api.github.com/repos/pradels/vagrant-libvirt/languages","stargazers_url":"https://api.github.com/repos/pradels/vagrant-libvirt/stargazers","contributors_url":"https://api.github.com/repos/pradels/vagrant-libvirt/contributors","subscribers_url":"https://api.github.com/repos/pradels/vagrant-libvirt/subscribers","subscription_url":"https://api.github.com/repos/pradels/vagrant-libvirt/subscription","commits_url":"https://api.github.com/repos/pradels/vagrant-libvirt/commits{/sha}","git_commits_url":"https://api.github.com/repos/pradels/vagrant-libvirt/git/commits{/sha}","comments_url":"https://api.github.com/repos/pradels/vagrant-libvirt/comments{/number}","issue_comment_url":"https://api.github.com/repos/pradels/vagrant-libvirt/issues/comments{/number}","contents_url":"https://api.github.com/repos/pradels/vagrant-libvirt/contents/{+path}","compare_url":"https://api.github.com/repos/pradels/vagrant-libvirt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pradels/vagrant-libvirt/merges","archive_url":"https://api.github.com/repos/pradels/vagrant-libvirt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pradels/vagrant-libvirt/downloads","issues_url":"https://api.github.com/repos/pradels/vagrant-libvirt/issues{/number}","pulls_url":"https://api.github.com/repos/pradels/vagrant-libvirt/pulls{/number}","milestones_url":"https://api.github.com/repos/pradels/vagrant-libvirt/milestones{/number}","notifications_url":"https://api.github.com/repos/pradels/vagrant-libvirt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pradels/vagrant-libvirt/labels{/name}","releases_url":"https://api.github.com/repos/pradels/vagrant-libvirt/releases{/id}","created_at":"2013-03-26T23:54:32Z","updated_at":"2015-05-27T16:28:53Z","pushed_at":"2015-05-28T08:03:33Z","git_url":"git://github.com/pradels/vagrant-libvirt.git","ssh_url":"git@github.com:pradels/vagrant-libvirt.git","clone_url":"https://github.com/pradels/vagrant-libvirt.git","svn_url":"https://github.com/pradels/vagrant-libvirt","homepage":null,"size":2171,"stargazers_count":434,"watchers_count":434,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":132,"mirror_url":null,"open_issues_count":45,"forks":132,"open_issues":45,"watchers":434,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pradels/vagrant-libvirt/pulls/379"},"html":{"href":"https://github.com/pradels/vagrant-libvirt/pull/379"},"issue":{"href":"https://api.github.com/repos/pradels/vagrant-libvirt/issues/379"},"comments":{"href":"https://api.github.com/repos/pradels/vagrant-libvirt/issues/379/comments"},"review_comments":{"href":"https://api.github.com/repos/pradels/vagrant-libvirt/pulls/379/comments"},"review_comment":{"href":"https://api.github.com/repos/pradels/vagrant-libvirt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pradels/vagrant-libvirt/pulls/379/commits"},"statuses":{"href":"https://api.github.com/repos/pradels/vagrant-libvirt/statuses/ba619e04bb007a48d9f6656eeb1f331aa8392ce8"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"pronix","id":86234,"avatar_url":"https://avatars.githubusercontent.com/u/86234?v=3","gravatar_id":"","url":"https://api.github.com/users/pronix","html_url":"https://github.com/pronix","followers_url":"https://api.github.com/users/pronix/followers","following_url":"https://api.github.com/users/pronix/following{/other_user}","gists_url":"https://api.github.com/users/pronix/gists{/gist_id}","starred_url":"https://api.github.com/users/pronix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pronix/subscriptions","organizations_url":"https://api.github.com/users/pronix/orgs","repos_url":"https://api.github.com/users/pronix/repos","events_url":"https://api.github.com/users/pronix/events{/privacy}","received_events_url":"https://api.github.com/users/pronix/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":17,"deletions":8,"changed_files":1}}