{"action":"closed","issue":{"url":"https://api.github.com/repos/golang/go/issues/12834","labels_url":"https://api.github.com/repos/golang/go/issues/12834/labels{/name}","comments_url":"https://api.github.com/repos/golang/go/issues/12834/comments","events_url":"https://api.github.com/repos/golang/go/issues/12834/events","html_url":"https://github.com/golang/go/issues/12834","id":109656637,"number":12834,"title":"proposal: cmd/vet: check for unused return value from testing/quick.Check","user":{"login":"minux","id":135652,"avatar_url":"https://avatars.githubusercontent.com/u/135652?v=3","gravatar_id":"","url":"https://api.github.com/users/minux","html_url":"https://github.com/minux","followers_url":"https://api.github.com/users/minux/followers","following_url":"https://api.github.com/users/minux/following{/other_user}","gists_url":"https://api.github.com/users/minux/gists{/gist_id}","starred_url":"https://api.github.com/users/minux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minux/subscriptions","organizations_url":"https://api.github.com/users/minux/orgs","repos_url":"https://api.github.com/users/minux/repos","events_url":"https://api.github.com/users/minux/events{/privacy}","received_events_url":"https://api.github.com/users/minux/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/golang/go/labels/Proposal","name":"Proposal","color":"ededed"},{"url":"https://api.github.com/repos/golang/go/labels/Proposal-Declined","name":"Proposal-Declined","color":"eb6420"}],"state":"closed","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/golang/go/milestones/30","html_url":"https://github.com/golang/go/milestones/Proposal","labels_url":"https://api.github.com/repos/golang/go/milestones/30/labels","id":1373555,"number":30,"title":"Proposal","description":"Proposals that are pending (not yet accepted/rejected).\r\n","creator":{"login":"rsc","id":104030,"avatar_url":"https://avatars.githubusercontent.com/u/104030?v=3","gravatar_id":"","url":"https://api.github.com/users/rsc","html_url":"https://github.com/rsc","followers_url":"https://api.github.com/users/rsc/followers","following_url":"https://api.github.com/users/rsc/following{/other_user}","gists_url":"https://api.github.com/users/rsc/gists{/gist_id}","starred_url":"https://api.github.com/users/rsc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsc/subscriptions","organizations_url":"https://api.github.com/users/rsc/orgs","repos_url":"https://api.github.com/users/rsc/repos","events_url":"https://api.github.com/users/rsc/events{/privacy}","received_events_url":"https://api.github.com/users/rsc/received_events","type":"User","site_admin":false},"open_issues":30,"closed_issues":5,"state":"open","created_at":"2015-10-24T01:40:49Z","updated_at":"2015-10-30T13:35:55Z","due_on":null,"closed_at":null},"comments":8,"created_at":"2015-10-04T01:54:47Z","updated_at":"2015-10-30T13:35:55Z","closed_at":"2015-10-30T13:35:55Z","body":"https://golang.org/cl/15263 fixed a place where `quick.Check` is\r\nused without its return value being checked for non-nil.\r\n\r\nI did a quick search, and found that unfortunately, there are 6 more\r\nsimilar cases in standard library alone. (see https://golang.org/cl/15381)\r\n\r\nI'm wondering if cmd/vet should check for this case as not checking\r\nthe result from quick.Check means the automated checks are useless.\r\n\r\nAnd perhaps cmd/vet should also check for other functions whose\r\nreturned value must not be ignored.\r\n\r\nI imagine that we don't want a source code annotation is similar to\r\ngcc's `__attribute__((warn_unused_result))`?\r\n(How about project specific cmd/vet rules? If there are enough\r\ninterest, we might be able to start a discussion on this topic too.\r\nI'm thinking about an example based approach, aka eg.)"}}