{"action":"closed","number":198,"pull_request":{"url":"https://api.github.com/repos/zerotier/ZeroTierOne/pulls/198","id":38685317,"html_url":"https://github.com/zerotier/ZeroTierOne/pull/198","diff_url":"https://github.com/zerotier/ZeroTierOne/pull/198.diff","patch_url":"https://github.com/zerotier/ZeroTierOne/pull/198.patch","issue_url":"https://api.github.com/repos/zerotier/ZeroTierOne/issues/198","number":198,"state":"closed","locked":false,"title":"Set default accepted ethertypes if no rules are defined","user":{"login":"keesbos","id":478473,"avatar_url":"https://avatars.githubusercontent.com/u/478473?v=3","gravatar_id":"","url":"https://api.github.com/users/keesbos","html_url":"https://github.com/keesbos","followers_url":"https://api.github.com/users/keesbos/followers","following_url":"https://api.github.com/users/keesbos/following{/other_user}","gists_url":"https://api.github.com/users/keesbos/gists{/gist_id}","starred_url":"https://api.github.com/users/keesbos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keesbos/subscriptions","organizations_url":"https://api.github.com/users/keesbos/orgs","repos_url":"https://api.github.com/users/keesbos/repos","events_url":"https://api.github.com/users/keesbos/events{/privacy}","received_events_url":"https://api.github.com/users/keesbos/received_events","type":"User","site_admin":false},"body":"When there are no rules defined, nothing is permitted. In principle a correct implementation, but a zt-net without traffic doesn't make sense. So, I propose to allow IPv4, ARP, and IPv6 ethernet frames when no rules are defined. I think that's kind of the 'standard' use case.","created_at":"2015-06-26T20:16:58Z","updated_at":"2015-06-26T20:18:16Z","closed_at":"2015-06-26T20:18:16Z","merged_at":null,"merge_commit_sha":"288e78f06316a73a17eca0c1d011b19a13db0b89","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/zerotier/ZeroTierOne/pulls/198/commits","review_comments_url":"https://api.github.com/repos/zerotier/ZeroTierOne/pulls/198/comments","review_comment_url":"https://api.github.com/repos/zerotier/ZeroTierOne/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zerotier/ZeroTierOne/issues/198/comments","statuses_url":"https://api.github.com/repos/zerotier/ZeroTierOne/statuses/8fa924861541c4cdbe8fa466dd8df3e657ce50b6","head":{"label":"keesbos:default-ethertypes","ref":"default-ethertypes","sha":"8fa924861541c4cdbe8fa466dd8df3e657ce50b6","user":{"login":"keesbos","id":478473,"avatar_url":"https://avatars.githubusercontent.com/u/478473?v=3","gravatar_id":"","url":"https://api.github.com/users/keesbos","html_url":"https://github.com/keesbos","followers_url":"https://api.github.com/users/keesbos/followers","following_url":"https://api.github.com/users/keesbos/following{/other_user}","gists_url":"https://api.github.com/users/keesbos/gists{/gist_id}","starred_url":"https://api.github.com/users/keesbos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keesbos/subscriptions","organizations_url":"https://api.github.com/users/keesbos/orgs","repos_url":"https://api.github.com/users/keesbos/repos","events_url":"https://api.github.com/users/keesbos/events{/privacy}","received_events_url":"https://api.github.com/users/keesbos/received_events","type":"User","site_admin":false},"repo":{"id":37250741,"name":"ZeroTierOne","full_name":"keesbos/ZeroTierOne","owner":{"login":"keesbos","id":478473,"avatar_url":"https://avatars.githubusercontent.com/u/478473?v=3","gravatar_id":"","url":"https://api.github.com/users/keesbos","html_url":"https://github.com/keesbos","followers_url":"https://api.github.com/users/keesbos/followers","following_url":"https://api.github.com/users/keesbos/following{/other_user}","gists_url":"https://api.github.com/users/keesbos/gists{/gist_id}","starred_url":"https://api.github.com/users/keesbos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keesbos/subscriptions","organizations_url":"https://api.github.com/users/keesbos/orgs","repos_url":"https://api.github.com/users/keesbos/repos","events_url":"https://api.github.com/users/keesbos/events{/privacy}","received_events_url":"https://api.github.com/users/keesbos/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/keesbos/ZeroTierOne","description":"Network Virtualization Everywhere","fork":true,"url":"https://api.github.com/repos/keesbos/ZeroTierOne","forks_url":"https://api.github.com/repos/keesbos/ZeroTierOne/forks","keys_url":"https://api.github.com/repos/keesbos/ZeroTierOne/keys{/key_id}","collaborators_url":"https://api.github.com/repos/keesbos/ZeroTierOne/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/keesbos/ZeroTierOne/teams","hooks_url":"https://api.github.com/repos/keesbos/ZeroTierOne/hooks","issue_events_url":"https://api.github.com/repos/keesbos/ZeroTierOne/issues/events{/number}","events_url":"https://api.github.com/repos/keesbos/ZeroTierOne/events","assignees_url":"https://api.github.com/repos/keesbos/ZeroTierOne/assignees{/user}","branches_url":"https://api.github.com/repos/keesbos/ZeroTierOne/branches{/branch}","tags_url":"https://api.github.com/repos/keesbos/ZeroTierOne/tags","blobs_url":"https://api.github.com/repos/keesbos/ZeroTierOne/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/keesbos/ZeroTierOne/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/keesbos/ZeroTierOne/git/refs{/sha}","trees_url":"https://api.github.com/repos/keesbos/ZeroTierOne/git/trees{/sha}","statuses_url":"https://api.github.com/repos/keesbos/ZeroTierOne/statuses/{sha}","languages_url":"https://api.github.com/repos/keesbos/ZeroTierOne/languages","stargazers_url":"https://api.github.com/repos/keesbos/ZeroTierOne/stargazers","contributors_url":"https://api.github.com/repos/keesbos/ZeroTierOne/contributors","subscribers_url":"https://api.github.com/repos/keesbos/ZeroTierOne/subscribers","subscription_url":"https://api.github.com/repos/keesbos/ZeroTierOne/subscription","commits_url":"https://api.github.com/repos/keesbos/ZeroTierOne/commits{/sha}","git_commits_url":"https://api.github.com/repos/keesbos/ZeroTierOne/git/commits{/sha}","comments_url":"https://api.github.com/repos/keesbos/ZeroTierOne/comments{/number}","issue_comment_url":"https://api.github.com/repos/keesbos/ZeroTierOne/issues/comments{/number}","contents_url":"https://api.github.com/repos/keesbos/ZeroTierOne/contents/{+path}","compare_url":"https://api.github.com/repos/keesbos/ZeroTierOne/compare/{base}...{head}","merges_url":"https://api.github.com/repos/keesbos/ZeroTierOne/merges","archive_url":"https://api.github.com/repos/keesbos/ZeroTierOne/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/keesbos/ZeroTierOne/downloads","issues_url":"https://api.github.com/repos/keesbos/ZeroTierOne/issues{/number}","pulls_url":"https://api.github.com/repos/keesbos/ZeroTierOne/pulls{/number}","milestones_url":"https://api.github.com/repos/keesbos/ZeroTierOne/milestones{/number}","notifications_url":"https://api.github.com/repos/keesbos/ZeroTierOne/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/keesbos/ZeroTierOne/labels{/name}","releases_url":"https://api.github.com/repos/keesbos/ZeroTierOne/releases{/id}","created_at":"2015-06-11T09:05:53Z","updated_at":"2015-06-11T09:05:55Z","pushed_at":"2015-06-26T20:09:39Z","git_url":"git://github.com/keesbos/ZeroTierOne.git","ssh_url":"git@github.com:keesbos/ZeroTierOne.git","clone_url":"https://github.com/keesbos/ZeroTierOne.git","svn_url":"https://github.com/keesbos/ZeroTierOne","homepage":"https://www.zerotier.com/","size":25775,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zerotier:adamierymenko-dev","ref":"adamierymenko-dev","sha":"221df5187581ae5721159a9118e302ec376a744b","user":{"login":"zerotier","id":4173285,"avatar_url":"https://avatars.githubusercontent.com/u/4173285?v=3","gravatar_id":"","url":"https://api.github.com/users/zerotier","html_url":"https://github.com/zerotier","followers_url":"https://api.github.com/users/zerotier/followers","following_url":"https://api.github.com/users/zerotier/following{/other_user}","gists_url":"https://api.github.com/users/zerotier/gists{/gist_id}","starred_url":"https://api.github.com/users/zerotier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zerotier/subscriptions","organizations_url":"https://api.github.com/users/zerotier/orgs","repos_url":"https://api.github.com/users/zerotier/repos","events_url":"https://api.github.com/users/zerotier/events{/privacy}","received_events_url":"https://api.github.com/users/zerotier/received_events","type":"Organization","site_admin":false},"repo":{"id":9647856,"name":"ZeroTierOne","full_name":"zerotier/ZeroTierOne","owner":{"login":"zerotier","id":4173285,"avatar_url":"https://avatars.githubusercontent.com/u/4173285?v=3","gravatar_id":"","url":"https://api.github.com/users/zerotier","html_url":"https://github.com/zerotier","followers_url":"https://api.github.com/users/zerotier/followers","following_url":"https://api.github.com/users/zerotier/following{/other_user}","gists_url":"https://api.github.com/users/zerotier/gists{/gist_id}","starred_url":"https://api.github.com/users/zerotier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zerotier/subscriptions","organizations_url":"https://api.github.com/users/zerotier/orgs","repos_url":"https://api.github.com/users/zerotier/repos","events_url":"https://api.github.com/users/zerotier/events{/privacy}","received_events_url":"https://api.github.com/users/zerotier/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zerotier/ZeroTierOne","description":"Network Virtualization Everywhere","fork":false,"url":"https://api.github.com/repos/zerotier/ZeroTierOne","forks_url":"https://api.github.com/repos/zerotier/ZeroTierOne/forks","keys_url":"https://api.github.com/repos/zerotier/ZeroTierOne/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zerotier/ZeroTierOne/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zerotier/ZeroTierOne/teams","hooks_url":"https://api.github.com/repos/zerotier/ZeroTierOne/hooks","issue_events_url":"https://api.github.com/repos/zerotier/ZeroTierOne/issues/events{/number}","events_url":"https://api.github.com/repos/zerotier/ZeroTierOne/events","assignees_url":"https://api.github.com/repos/zerotier/ZeroTierOne/assignees{/user}","branches_url":"https://api.github.com/repos/zerotier/ZeroTierOne/branches{/branch}","tags_url":"https://api.github.com/repos/zerotier/ZeroTierOne/tags","blobs_url":"https://api.github.com/repos/zerotier/ZeroTierOne/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zerotier/ZeroTierOne/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zerotier/ZeroTierOne/git/refs{/sha}","trees_url":"https://api.github.com/repos/zerotier/ZeroTierOne/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zerotier/ZeroTierOne/statuses/{sha}","languages_url":"https://api.github.com/repos/zerotier/ZeroTierOne/languages","stargazers_url":"https://api.github.com/repos/zerotier/ZeroTierOne/stargazers","contributors_url":"https://api.github.com/repos/zerotier/ZeroTierOne/contributors","subscribers_url":"https://api.github.com/repos/zerotier/ZeroTierOne/subscribers","subscription_url":"https://api.github.com/repos/zerotier/ZeroTierOne/subscription","commits_url":"https://api.github.com/repos/zerotier/ZeroTierOne/commits{/sha}","git_commits_url":"https://api.github.com/repos/zerotier/ZeroTierOne/git/commits{/sha}","comments_url":"https://api.github.com/repos/zerotier/ZeroTierOne/comments{/number}","issue_comment_url":"https://api.github.com/repos/zerotier/ZeroTierOne/issues/comments{/number}","contents_url":"https://api.github.com/repos/zerotier/ZeroTierOne/contents/{+path}","compare_url":"https://api.github.com/repos/zerotier/ZeroTierOne/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zerotier/ZeroTierOne/merges","archive_url":"https://api.github.com/repos/zerotier/ZeroTierOne/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zerotier/ZeroTierOne/downloads","issues_url":"https://api.github.com/repos/zerotier/ZeroTierOne/issues{/number}","pulls_url":"https://api.github.com/repos/zerotier/ZeroTierOne/pulls{/number}","milestones_url":"https://api.github.com/repos/zerotier/ZeroTierOne/milestones{/number}","notifications_url":"https://api.github.com/repos/zerotier/ZeroTierOne/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zerotier/ZeroTierOne/labels{/name}","releases_url":"https://api.github.com/repos/zerotier/ZeroTierOne/releases{/id}","created_at":"2013-04-24T13:21:10Z","updated_at":"2015-06-25T21:12:28Z","pushed_at":"2015-06-26T20:16:58Z","git_url":"git://github.com/zerotier/ZeroTierOne.git","ssh_url":"git@github.com:zerotier/ZeroTierOne.git","clone_url":"https://github.com/zerotier/ZeroTierOne.git","svn_url":"https://github.com/zerotier/ZeroTierOne","homepage":"https://www.zerotier.com/","size":29623,"stargazers_count":706,"watchers_count":706,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":55,"mirror_url":null,"open_issues_count":26,"forks":55,"open_issues":26,"watchers":706,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zerotier/ZeroTierOne/pulls/198"},"html":{"href":"https://github.com/zerotier/ZeroTierOne/pull/198"},"issue":{"href":"https://api.github.com/repos/zerotier/ZeroTierOne/issues/198"},"comments":{"href":"https://api.github.com/repos/zerotier/ZeroTierOne/issues/198/comments"},"review_comments":{"href":"https://api.github.com/repos/zerotier/ZeroTierOne/pulls/198/comments"},"review_comment":{"href":"https://api.github.com/repos/zerotier/ZeroTierOne/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zerotier/ZeroTierOne/pulls/198/commits"},"statuses":{"href":"https://api.github.com/repos/zerotier/ZeroTierOne/statuses/8fa924861541c4cdbe8fa466dd8df3e657ce50b6"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":2,"review_comments":0,"commits":1,"additions":9,"deletions":0,"changed_files":1}}