{"action":"created","issue":{"url":"https://api.github.com/repos/nengo/nengo/issues/642","labels_url":"https://api.github.com/repos/nengo/nengo/issues/642/labels{/name}","comments_url":"https://api.github.com/repos/nengo/nengo/issues/642/comments","events_url":"https://api.github.com/repos/nengo/nengo/issues/642/events","html_url":"https://github.com/nengo/nengo/pull/642","id":56574542,"number":642,"title":"Learning unmodulated","user":{"login":"hunse","id":1952250,"avatar_url":"https://avatars.githubusercontent.com/u/1952250?v=3","gravatar_id":"","url":"https://api.github.com/users/hunse","html_url":"https://github.com/hunse","followers_url":"https://api.github.com/users/hunse/followers","following_url":"https://api.github.com/users/hunse/following{/other_user}","gists_url":"https://api.github.com/users/hunse/gists{/gist_id}","starred_url":"https://api.github.com/users/hunse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hunse/subscriptions","organizations_url":"https://api.github.com/users/hunse/orgs","repos_url":"https://api.github.com/users/hunse/repos","events_url":"https://api.github.com/users/hunse/events{/privacy}","received_events_url":"https://api.github.com/users/hunse/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/nengo/nengo/labels/needs%20review","name":"needs review","color":"eb6420"}],"state":"open","locked":false,"assignee":{"login":"tbekolay","id":203709,"avatar_url":"https://avatars.githubusercontent.com/u/203709?v=3","gravatar_id":"","url":"https://api.github.com/users/tbekolay","html_url":"https://github.com/tbekolay","followers_url":"https://api.github.com/users/tbekolay/followers","following_url":"https://api.github.com/users/tbekolay/following{/other_user}","gists_url":"https://api.github.com/users/tbekolay/gists{/gist_id}","starred_url":"https://api.github.com/users/tbekolay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbekolay/subscriptions","organizations_url":"https://api.github.com/users/tbekolay/orgs","repos_url":"https://api.github.com/users/tbekolay/repos","events_url":"https://api.github.com/users/tbekolay/events{/privacy}","received_events_url":"https://api.github.com/users/tbekolay/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/nengo/nengo/milestones/6","html_url":"https://github.com/nengo/nengo/milestones/2.1.0%20release","labels_url":"https://api.github.com/repos/nengo/nengo/milestones/6/labels","id":747893,"number":6,"title":"2.1.0 release","description":"For changes that will affect model code.","creator":{"login":"tbekolay","id":203709,"avatar_url":"https://avatars.githubusercontent.com/u/203709?v=3","gravatar_id":"","url":"https://api.github.com/users/tbekolay","html_url":"https://github.com/tbekolay","followers_url":"https://api.github.com/users/tbekolay/followers","following_url":"https://api.github.com/users/tbekolay/following{/other_user}","gists_url":"https://api.github.com/users/tbekolay/gists{/gist_id}","starred_url":"https://api.github.com/users/tbekolay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbekolay/subscriptions","organizations_url":"https://api.github.com/users/tbekolay/orgs","repos_url":"https://api.github.com/users/tbekolay/repos","events_url":"https://api.github.com/users/tbekolay/events{/privacy}","received_events_url":"https://api.github.com/users/tbekolay/received_events","type":"User","site_admin":false},"open_issues":44,"closed_issues":29,"state":"open","created_at":"2014-08-08T17:42:35Z","updated_at":"2015-05-28T20:21:59Z","due_on":null,"closed_at":null},"comments":9,"created_at":"2015-02-04T19:25:23Z","updated_at":"2015-05-28T21:48:59Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nengo/nengo/pulls/642","html_url":"https://github.com/nengo/nengo/pull/642","diff_url":"https://github.com/nengo/nengo/pull/642.diff","patch_url":"https://github.com/nengo/nengo/pull/642.patch"},"body":"This makes it so that we connect directly to LearningRules instead of making modulatory connections, as discussed in #632. It fixes that problem.\r\n\r\nThe second commit switches the sign of the PES error, so that it is actually an error (i.e. the actual value minus the target value). This means that the PES learning rule moves in the opposite direction of the error, as one would expect (e.g., if the output is too large, make it smaller). This makes a lot more sense to me, and hopefully to everyone else as well. Now seemed like a good time to do it, because the changes from the first commit will require that everyone re-write their learning code anyway.\r\n\r\nEDIT: this also addresses #366."},"comment":{"url":"https://api.github.com/repos/nengo/nengo/issues/comments/106610478","html_url":"https://github.com/nengo/nengo/pull/642#issuecomment-106610478","issue_url":"https://api.github.com/repos/nengo/nengo/issues/642","id":106610478,"user":{"login":"arvoelke","id":5420057,"avatar_url":"https://avatars.githubusercontent.com/u/5420057?v=3","gravatar_id":"","url":"https://api.github.com/users/arvoelke","html_url":"https://github.com/arvoelke","followers_url":"https://api.github.com/users/arvoelke/followers","following_url":"https://api.github.com/users/arvoelke/following{/other_user}","gists_url":"https://api.github.com/users/arvoelke/gists{/gist_id}","starred_url":"https://api.github.com/users/arvoelke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arvoelke/subscriptions","organizations_url":"https://api.github.com/users/arvoelke/orgs","repos_url":"https://api.github.com/users/arvoelke/repos","events_url":"https://api.github.com/users/arvoelke/events{/privacy}","received_events_url":"https://api.github.com/users/arvoelke/received_events","type":"User","site_admin":false},"created_at":"2015-05-28T21:48:59Z","updated_at":"2015-05-28T21:48:59Z","body":"Should #643 be implemented here too, in order to contain these rather significant changes to PES to a single PR? "}}