{"action":"created","comment":{"url":"https://api.github.com/repos/guardian/frontend/pulls/comments/40326606","id":40326606,"diff_hunk":"@@ -236,6 +250,19 @@ define([\n         postDisplay = function () {\n             mediator.on('window:resize', windowResize);\n         },\n+        showAdsFreeSurvey = function (size, $adSlot) {\n+            fastdom.write(function () {\n+                var crossIcon = svgs('crossIcon'),\n+                    dataAttr = isAdfreeSurvey('variant') ? 'hide ads' : 'hide ads simple',\n+                    $adSlotRemove = $(document.createElement('div')).addClass('ad-slot--remove').attr('data-link-name', dataAttr)","path":"static/src/javascripts/projects/common/modules/commercial/dfp.js","position":54,"original_position":54,"commit_id":"6b148a279d2bfc8cd3c95a19b3a2e6a53e7b7b09","original_commit_id":"21673742013c831bdba57c9646c22b8d1723c5c2","user":{"login":"Calanthe","id":489567,"avatar_url":"https://avatars.githubusercontent.com/u/489567?v=3","gravatar_id":"","url":"https://api.github.com/users/Calanthe","html_url":"https://github.com/Calanthe","followers_url":"https://api.github.com/users/Calanthe/followers","following_url":"https://api.github.com/users/Calanthe/following{/other_user}","gists_url":"https://api.github.com/users/Calanthe/gists{/gist_id}","starred_url":"https://api.github.com/users/Calanthe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Calanthe/subscriptions","organizations_url":"https://api.github.com/users/Calanthe/orgs","repos_url":"https://api.github.com/users/Calanthe/repos","events_url":"https://api.github.com/users/Calanthe/events{/privacy}","received_events_url":"https://api.github.com/users/Calanthe/received_events","type":"User","site_admin":false},"body":"This is 404 survey, so I assume that in the future there will be a real option to remove those ads. I get your idea but don't think that it is necessary to change the css class now.","created_at":"2015-09-24T14:44:05Z","updated_at":"2015-09-24T14:44:05Z","html_url":"https://github.com/guardian/frontend/pull/10512#discussion_r40326606","pull_request_url":"https://api.github.com/repos/guardian/frontend/pulls/10512","_links":{"self":{"href":"https://api.github.com/repos/guardian/frontend/pulls/comments/40326606"},"html":{"href":"https://github.com/guardian/frontend/pull/10512#discussion_r40326606"},"pull_request":{"href":"https://api.github.com/repos/guardian/frontend/pulls/10512"}}},"pull_request":{"url":"https://api.github.com/repos/guardian/frontend/pulls/10512","id":44950305,"html_url":"https://github.com/guardian/frontend/pull/10512","diff_url":"https://github.com/guardian/frontend/pull/10512.diff","patch_url":"https://github.com/guardian/frontend/pull/10512.patch","issue_url":"https://api.github.com/repos/guardian/frontend/issues/10512","number":10512,"state":"open","locked":false,"title":"404 survey framework","user":{"login":"Calanthe","id":489567,"avatar_url":"https://avatars.githubusercontent.com/u/489567?v=3","gravatar_id":"","url":"https://api.github.com/users/Calanthe","html_url":"https://github.com/Calanthe","followers_url":"https://api.github.com/users/Calanthe/followers","following_url":"https://api.github.com/users/Calanthe/following{/other_user}","gists_url":"https://api.github.com/users/Calanthe/gists{/gist_id}","starred_url":"https://api.github.com/users/Calanthe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Calanthe/subscriptions","organizations_url":"https://api.github.com/users/Calanthe/orgs","repos_url":"https://api.github.com/users/Calanthe/repos","events_url":"https://api.github.com/users/Calanthe/events{/privacy}","received_events_url":"https://api.github.com/users/Calanthe/received_events","type":"User","site_admin":false},"body":"This is not ready to be merge yet. Still work in progress.\r\n\r\nThe idea behind the 404 survey framework:\r\nWithin AB test, on every 300x250 MPU there should be a 'Hide ads' label:\r\n![screen shot 2015-09-11 at 16 37 23](https://cloud.githubusercontent.com/assets/489567/9854812/a6dc473c-5b02-11e5-80c5-cbbe59488da3.png)\r\n\r\nOn fronts and articles there should be a thrasher with information about the 'ad free' membership option:\r\nDesktop:\r\n![screen shot 2015-09-14 at 17 07 37](https://cloud.githubusercontent.com/assets/489567/9854881/09a20b40-5b03-11e5-87f7-09a7b489f953.png)\r\n\r\nMobile:\r\n![screen shot 2015-09-14 at 17 07 54](https://cloud.githubusercontent.com/assets/489567/9854890/148ba3c2-5b03-11e5-84a2-4422b3d9ea20.png)\r\n\r\nAfter clicking on the whole thrasher or 'Hide ads' label, an overlay with more information about membership 'ad free' option should be displayed like here:\r\n![screen shot 2015-09-14 at 17 10 42](https://cloud.githubusercontent.com/assets/489567/9854956/69c5b788-5b03-11e5-800c-064edd9e8a58.png)\r\n\r\nThere should be proper landing pages prepared to show the user whole information about those membership benefits. They will be prepared probably as interactives.\r\n\r\n**TODO**:\r\n- [x] update proper 'X' icon on survey overlay - it has to be a link with proper `data-link attribute`\r\n- [x] finish styling survey overlay - focus on mobile\r\n- [x] update `common/modules/experiments/tests/adfree-survey.js` file with information about all data-link attributes used in AB test\r\n- [x] prepare another variant of the test? - with different links\r\n- [x] use proper links in survey overlay (remember about the `data-link attribute`)\r\n- [x] set proper z-index values (use properties?)\r\n","created_at":"2015-09-14T16:20:46Z","updated_at":"2015-09-24T14:44:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9786a3441a240bac6b1fa8702216432942197311","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/guardian/frontend/pulls/10512/commits","review_comments_url":"https://api.github.com/repos/guardian/frontend/pulls/10512/comments","review_comment_url":"https://api.github.com/repos/guardian/frontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/guardian/frontend/issues/10512/comments","statuses_url":"https://api.github.com/repos/guardian/frontend/statuses/6b148a279d2bfc8cd3c95a19b3a2e6a53e7b7b09","head":{"label":"guardian:404-survey-framework","ref":"404-survey-framework","sha":"6b148a279d2bfc8cd3c95a19b3a2e6a53e7b7b09","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":4370755,"name":"frontend","full_name":"guardian/frontend","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/frontend","description":"Source for theguardian.com","fork":false,"url":"https://api.github.com/repos/guardian/frontend","forks_url":"https://api.github.com/repos/guardian/frontend/forks","keys_url":"https://api.github.com/repos/guardian/frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/frontend/teams","hooks_url":"https://api.github.com/repos/guardian/frontend/hooks","issue_events_url":"https://api.github.com/repos/guardian/frontend/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/frontend/events","assignees_url":"https://api.github.com/repos/guardian/frontend/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/frontend/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/frontend/tags","blobs_url":"https://api.github.com/repos/guardian/frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/frontend/languages","stargazers_url":"https://api.github.com/repos/guardian/frontend/stargazers","contributors_url":"https://api.github.com/repos/guardian/frontend/contributors","subscribers_url":"https://api.github.com/repos/guardian/frontend/subscribers","subscription_url":"https://api.github.com/repos/guardian/frontend/subscription","commits_url":"https://api.github.com/repos/guardian/frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/guardian/frontend/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/frontend/merges","archive_url":"https://api.github.com/repos/guardian/frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/frontend/downloads","issues_url":"https://api.github.com/repos/guardian/frontend/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/frontend/labels{/name}","releases_url":"https://api.github.com/repos/guardian/frontend/releases{/id}","created_at":"2012-05-18T15:39:15Z","updated_at":"2015-09-24T14:42:14Z","pushed_at":"2015-09-24T14:40:06Z","git_url":"git://github.com/guardian/frontend.git","ssh_url":"git@github.com:guardian/frontend.git","clone_url":"https://github.com/guardian/frontend.git","svn_url":"https://github.com/guardian/frontend","homepage":"http://www.theguardian.com","size":514905,"stargazers_count":2944,"watchers_count":2944,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":284,"mirror_url":null,"open_issues_count":70,"forks":284,"open_issues":70,"watchers":2944,"default_branch":"master"}},"base":{"label":"guardian:master","ref":"master","sha":"dfc330394c433d55efc39a706714c0e1fa6899b2","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":4370755,"name":"frontend","full_name":"guardian/frontend","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/frontend","description":"Source for theguardian.com","fork":false,"url":"https://api.github.com/repos/guardian/frontend","forks_url":"https://api.github.com/repos/guardian/frontend/forks","keys_url":"https://api.github.com/repos/guardian/frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/frontend/teams","hooks_url":"https://api.github.com/repos/guardian/frontend/hooks","issue_events_url":"https://api.github.com/repos/guardian/frontend/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/frontend/events","assignees_url":"https://api.github.com/repos/guardian/frontend/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/frontend/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/frontend/tags","blobs_url":"https://api.github.com/repos/guardian/frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/frontend/languages","stargazers_url":"https://api.github.com/repos/guardian/frontend/stargazers","contributors_url":"https://api.github.com/repos/guardian/frontend/contributors","subscribers_url":"https://api.github.com/repos/guardian/frontend/subscribers","subscription_url":"https://api.github.com/repos/guardian/frontend/subscription","commits_url":"https://api.github.com/repos/guardian/frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/guardian/frontend/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/frontend/merges","archive_url":"https://api.github.com/repos/guardian/frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/frontend/downloads","issues_url":"https://api.github.com/repos/guardian/frontend/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/frontend/labels{/name}","releases_url":"https://api.github.com/repos/guardian/frontend/releases{/id}","created_at":"2012-05-18T15:39:15Z","updated_at":"2015-09-24T14:42:14Z","pushed_at":"2015-09-24T14:40:06Z","git_url":"git://github.com/guardian/frontend.git","ssh_url":"git@github.com:guardian/frontend.git","clone_url":"https://github.com/guardian/frontend.git","svn_url":"https://github.com/guardian/frontend","homepage":"http://www.theguardian.com","size":514905,"stargazers_count":2944,"watchers_count":2944,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":284,"mirror_url":null,"open_issues_count":70,"forks":284,"open_issues":70,"watchers":2944,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/guardian/frontend/pulls/10512"},"html":{"href":"https://github.com/guardian/frontend/pull/10512"},"issue":{"href":"https://api.github.com/repos/guardian/frontend/issues/10512"},"comments":{"href":"https://api.github.com/repos/guardian/frontend/issues/10512/comments"},"review_comments":{"href":"https://api.github.com/repos/guardian/frontend/pulls/10512/comments"},"review_comment":{"href":"https://api.github.com/repos/guardian/frontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/guardian/frontend/pulls/10512/commits"},"statuses":{"href":"https://api.github.com/repos/guardian/frontend/statuses/6b148a279d2bfc8cd3c95a19b3a2e6a53e7b7b09"}}}}