{"action":"closed","number":89,"pull_request":{"url":"https://api.github.com/repos/zenspider/enhanced-ruby-mode/pulls/89","id":46704208,"html_url":"https://github.com/zenspider/enhanced-ruby-mode/pull/89","diff_url":"https://github.com/zenspider/enhanced-ruby-mode/pull/89.diff","patch_url":"https://github.com/zenspider/enhanced-ruby-mode/pull/89.patch","issue_url":"https://api.github.com/repos/zenspider/enhanced-ruby-mode/issues/89","number":89,"state":"closed","locked":false,"title":"Set require-final-newline correctly.","user":{"login":"balajisivaraman","id":1876249,"avatar_url":"https://avatars.githubusercontent.com/u/1876249?v=3","gravatar_id":"","url":"https://api.github.com/users/balajisivaraman","html_url":"https://github.com/balajisivaraman","followers_url":"https://api.github.com/users/balajisivaraman/followers","following_url":"https://api.github.com/users/balajisivaraman/following{/other_user}","gists_url":"https://api.github.com/users/balajisivaraman/gists{/gist_id}","starred_url":"https://api.github.com/users/balajisivaraman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balajisivaraman/subscriptions","organizations_url":"https://api.github.com/users/balajisivaraman/orgs","repos_url":"https://api.github.com/users/balajisivaraman/repos","events_url":"https://api.github.com/users/balajisivaraman/events{/privacy}","received_events_url":"https://api.github.com/users/balajisivaraman/received_events","type":"User","site_admin":false},"body":"Right now, any user that has `global-ethan-wspace-mode` turned on faces warnings when opening a `.rb` file in Enhanced Ruby Mode. This is because `enh-ruby-mode` sets `require-final-newline` to `t` locally, which interferes with ethan-wspace mode.\r\n\r\nThis suggested fix is similar to fixes for other various modes, including Ruby Mode, [Dockerfile Mode](https://github.com/spotify/dockerfile-mode/pull/10/files), [Cucumber Mode](https://github.com/michaelklishin/cucumber.el/pull/51) and many others.\r\n\r\nFor more about the motivation, [this thread](https://github.com/glasserc/ethan-wspace/issues/22) over at ethan-wspace provides a lot of discussion and background.\r\n\r\nFalling back to `mode-require-final-newline` is preferred since users will be able to override that setting fairly easily.","created_at":"2015-10-03T11:35:10Z","updated_at":"2015-11-23T09:41:40Z","closed_at":"2015-11-23T09:41:40Z","merged_at":"2015-11-23T09:41:40Z","merge_commit_sha":"11a642d71fa677d062cc053803f4a742312274e9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/zenspider/enhanced-ruby-mode/pulls/89/commits","review_comments_url":"https://api.github.com/repos/zenspider/enhanced-ruby-mode/pulls/89/comments","review_comment_url":"https://api.github.com/repos/zenspider/enhanced-ruby-mode/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zenspider/enhanced-ruby-mode/issues/89/comments","statuses_url":"https://api.github.com/repos/zenspider/enhanced-ruby-mode/statuses/efe6a28bd7bba9361de8f3bac366d9c4d905e6b6","head":{"label":"balajisivaraman:ethan-wspace-fix","ref":"ethan-wspace-fix","sha":"efe6a28bd7bba9361de8f3bac366d9c4d905e6b6","user":{"login":"balajisivaraman","id":1876249,"avatar_url":"https://avatars.githubusercontent.com/u/1876249?v=3","gravatar_id":"","url":"https://api.github.com/users/balajisivaraman","html_url":"https://github.com/balajisivaraman","followers_url":"https://api.github.com/users/balajisivaraman/followers","following_url":"https://api.github.com/users/balajisivaraman/following{/other_user}","gists_url":"https://api.github.com/users/balajisivaraman/gists{/gist_id}","starred_url":"https://api.github.com/users/balajisivaraman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balajisivaraman/subscriptions","organizations_url":"https://api.github.com/users/balajisivaraman/orgs","repos_url":"https://api.github.com/users/balajisivaraman/repos","events_url":"https://api.github.com/users/balajisivaraman/events{/privacy}","received_events_url":"https://api.github.com/users/balajisivaraman/received_events","type":"User","site_admin":false},"repo":{"id":43596772,"name":"enhanced-ruby-mode","full_name":"balajisivaraman/enhanced-ruby-mode","owner":{"login":"balajisivaraman","id":1876249,"avatar_url":"https://avatars.githubusercontent.com/u/1876249?v=3","gravatar_id":"","url":"https://api.github.com/users/balajisivaraman","html_url":"https://github.com/balajisivaraman","followers_url":"https://api.github.com/users/balajisivaraman/followers","following_url":"https://api.github.com/users/balajisivaraman/following{/other_user}","gists_url":"https://api.github.com/users/balajisivaraman/gists{/gist_id}","starred_url":"https://api.github.com/users/balajisivaraman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balajisivaraman/subscriptions","organizations_url":"https://api.github.com/users/balajisivaraman/orgs","repos_url":"https://api.github.com/users/balajisivaraman/repos","events_url":"https://api.github.com/users/balajisivaraman/events{/privacy}","received_events_url":"https://api.github.com/users/balajisivaraman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/balajisivaraman/enhanced-ruby-mode","description":"An enhanced ruby-mode for Emacs that uses Ripper in ruby 1.9.2 to highlight and indent the source code","fork":true,"url":"https://api.github.com/repos/balajisivaraman/enhanced-ruby-mode","forks_url":"https://api.github.com/repos/balajisivaraman/enhanced-ruby-mode/forks","keys_url":"https://api.github.com/repos/balajisivaraman/enhanced-ruby-mode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/balajisivaraman/enhanced-ruby-mode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/balajisivaraman/enhanced-ruby-mode/teams","hooks_url":"https://api.github.com/repos/balajisivaraman/enhanced-ruby-mode/hooks","issue_events_url":"https://api.github.com/repos/balajisivaraman/enhanced-ruby-mode/issues/events{/number}","events_url":"https://api.github.com/repos/balajisivaraman/enhanced-ruby-mode/events","assignees_url":"https://api.github.com/repos/balajisivaraman/enhanced-ruby-mode/assignees{/user}","branches_url":"https://api.github.com/repos/balajisivaraman/enhanced-ruby-mode/branches{/branch}","tags_url":"https://api.github.com/repos/balajisivaraman/enhanced-ruby-mode/tags","blobs_url":"https://api.github.com/repos/balajisivaraman/enhanced-ruby-mode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/balajisivaraman/enhanced-ruby-mode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/balajisivaraman/enhanced-ruby-mode/git/refs{/sha}","trees_url":"https://api.github.com/repos/balajisivaraman/enhanced-ruby-mode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/balajisivaraman/enhanced-ruby-mode/statuses/{sha}","languages_url":"https://api.github.com/repos/balajisivaraman/enhanced-ruby-mode/languages","stargazers_url":"https://api.github.com/repos/balajisivaraman/enhanced-ruby-mode/stargazers","contributors_url":"https://api.github.com/repos/balajisivaraman/enhanced-ruby-mode/contributors","subscribers_url":"https://api.github.com/repos/balajisivaraman/enhanced-ruby-mode/subscribers","subscription_url":"https://api.github.com/repos/balajisivaraman/enhanced-ruby-mode/subscription","commits_url":"https://api.github.com/repos/balajisivaraman/enhanced-ruby-mode/commits{/sha}","git_commits_url":"https://api.github.com/repos/balajisivaraman/enhanced-ruby-mode/git/commits{/sha}","comments_url":"https://api.github.com/repos/balajisivaraman/enhanced-ruby-mode/comments{/number}","issue_comment_url":"https://api.github.com/repos/balajisivaraman/enhanced-ruby-mode/issues/comments{/number}","contents_url":"https://api.github.com/repos/balajisivaraman/enhanced-ruby-mode/contents/{+path}","compare_url":"https://api.github.com/repos/balajisivaraman/enhanced-ruby-mode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/balajisivaraman/enhanced-ruby-mode/merges","archive_url":"https://api.github.com/repos/balajisivaraman/enhanced-ruby-mode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/balajisivaraman/enhanced-ruby-mode/downloads","issues_url":"https://api.github.com/repos/balajisivaraman/enhanced-ruby-mode/issues{/number}","pulls_url":"https://api.github.com/repos/balajisivaraman/enhanced-ruby-mode/pulls{/number}","milestones_url":"https://api.github.com/repos/balajisivaraman/enhanced-ruby-mode/milestones{/number}","notifications_url":"https://api.github.com/repos/balajisivaraman/enhanced-ruby-mode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/balajisivaraman/enhanced-ruby-mode/labels{/name}","releases_url":"https://api.github.com/repos/balajisivaraman/enhanced-ruby-mode/releases{/id}","created_at":"2015-10-03T11:23:22Z","updated_at":"2015-10-03T11:23:22Z","pushed_at":"2015-10-03T11:28:37Z","git_url":"git://github.com/balajisivaraman/enhanced-ruby-mode.git","ssh_url":"git@github.com:balajisivaraman/enhanced-ruby-mode.git","clone_url":"https://github.com/balajisivaraman/enhanced-ruby-mode.git","svn_url":"https://github.com/balajisivaraman/enhanced-ruby-mode","homepage":"","size":246,"stargazers_count":0,"watchers_count":0,"language":"Emacs Lisp","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zenspider:master","ref":"master","sha":"f945cff5e784e23e0028bf0a5221f4f47a822fac","user":{"login":"zenspider","id":9832,"avatar_url":"https://avatars.githubusercontent.com/u/9832?v=3","gravatar_id":"","url":"https://api.github.com/users/zenspider","html_url":"https://github.com/zenspider","followers_url":"https://api.github.com/users/zenspider/followers","following_url":"https://api.github.com/users/zenspider/following{/other_user}","gists_url":"https://api.github.com/users/zenspider/gists{/gist_id}","starred_url":"https://api.github.com/users/zenspider/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zenspider/subscriptions","organizations_url":"https://api.github.com/users/zenspider/orgs","repos_url":"https://api.github.com/users/zenspider/repos","events_url":"https://api.github.com/users/zenspider/events{/privacy}","received_events_url":"https://api.github.com/users/zenspider/received_events","type":"User","site_admin":false},"repo":{"id":6947496,"name":"enhanced-ruby-mode","full_name":"zenspider/enhanced-ruby-mode","owner":{"login":"zenspider","id":9832,"avatar_url":"https://avatars.githubusercontent.com/u/9832?v=3","gravatar_id":"","url":"https://api.github.com/users/zenspider","html_url":"https://github.com/zenspider","followers_url":"https://api.github.com/users/zenspider/followers","following_url":"https://api.github.com/users/zenspider/following{/other_user}","gists_url":"https://api.github.com/users/zenspider/gists{/gist_id}","starred_url":"https://api.github.com/users/zenspider/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zenspider/subscriptions","organizations_url":"https://api.github.com/users/zenspider/orgs","repos_url":"https://api.github.com/users/zenspider/repos","events_url":"https://api.github.com/users/zenspider/events{/privacy}","received_events_url":"https://api.github.com/users/zenspider/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zenspider/enhanced-ruby-mode","description":"An enhanced ruby-mode for Emacs that uses Ripper in ruby 1.9.2 to highlight and indent the source code","fork":true,"url":"https://api.github.com/repos/zenspider/enhanced-ruby-mode","forks_url":"https://api.github.com/repos/zenspider/enhanced-ruby-mode/forks","keys_url":"https://api.github.com/repos/zenspider/enhanced-ruby-mode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zenspider/enhanced-ruby-mode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zenspider/enhanced-ruby-mode/teams","hooks_url":"https://api.github.com/repos/zenspider/enhanced-ruby-mode/hooks","issue_events_url":"https://api.github.com/repos/zenspider/enhanced-ruby-mode/issues/events{/number}","events_url":"https://api.github.com/repos/zenspider/enhanced-ruby-mode/events","assignees_url":"https://api.github.com/repos/zenspider/enhanced-ruby-mode/assignees{/user}","branches_url":"https://api.github.com/repos/zenspider/enhanced-ruby-mode/branches{/branch}","tags_url":"https://api.github.com/repos/zenspider/enhanced-ruby-mode/tags","blobs_url":"https://api.github.com/repos/zenspider/enhanced-ruby-mode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zenspider/enhanced-ruby-mode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zenspider/enhanced-ruby-mode/git/refs{/sha}","trees_url":"https://api.github.com/repos/zenspider/enhanced-ruby-mode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zenspider/enhanced-ruby-mode/statuses/{sha}","languages_url":"https://api.github.com/repos/zenspider/enhanced-ruby-mode/languages","stargazers_url":"https://api.github.com/repos/zenspider/enhanced-ruby-mode/stargazers","contributors_url":"https://api.github.com/repos/zenspider/enhanced-ruby-mode/contributors","subscribers_url":"https://api.github.com/repos/zenspider/enhanced-ruby-mode/subscribers","subscription_url":"https://api.github.com/repos/zenspider/enhanced-ruby-mode/subscription","commits_url":"https://api.github.com/repos/zenspider/enhanced-ruby-mode/commits{/sha}","git_commits_url":"https://api.github.com/repos/zenspider/enhanced-ruby-mode/git/commits{/sha}","comments_url":"https://api.github.com/repos/zenspider/enhanced-ruby-mode/comments{/number}","issue_comment_url":"https://api.github.com/repos/zenspider/enhanced-ruby-mode/issues/comments{/number}","contents_url":"https://api.github.com/repos/zenspider/enhanced-ruby-mode/contents/{+path}","compare_url":"https://api.github.com/repos/zenspider/enhanced-ruby-mode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zenspider/enhanced-ruby-mode/merges","archive_url":"https://api.github.com/repos/zenspider/enhanced-ruby-mode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zenspider/enhanced-ruby-mode/downloads","issues_url":"https://api.github.com/repos/zenspider/enhanced-ruby-mode/issues{/number}","pulls_url":"https://api.github.com/repos/zenspider/enhanced-ruby-mode/pulls{/number}","milestones_url":"https://api.github.com/repos/zenspider/enhanced-ruby-mode/milestones{/number}","notifications_url":"https://api.github.com/repos/zenspider/enhanced-ruby-mode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zenspider/enhanced-ruby-mode/labels{/name}","releases_url":"https://api.github.com/repos/zenspider/enhanced-ruby-mode/releases{/id}","created_at":"2012-11-30T23:14:43Z","updated_at":"2015-11-18T22:47:04Z","pushed_at":"2015-11-23T09:41:40Z","git_url":"git://github.com/zenspider/enhanced-ruby-mode.git","ssh_url":"git@github.com:zenspider/enhanced-ruby-mode.git","clone_url":"https://github.com/zenspider/enhanced-ruby-mode.git","svn_url":"https://github.com/zenspider/enhanced-ruby-mode","homepage":"","size":599,"stargazers_count":107,"watchers_count":107,"language":"Emacs Lisp","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":28,"mirror_url":null,"open_issues_count":13,"forks":28,"open_issues":13,"watchers":107,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zenspider/enhanced-ruby-mode/pulls/89"},"html":{"href":"https://github.com/zenspider/enhanced-ruby-mode/pull/89"},"issue":{"href":"https://api.github.com/repos/zenspider/enhanced-ruby-mode/issues/89"},"comments":{"href":"https://api.github.com/repos/zenspider/enhanced-ruby-mode/issues/89/comments"},"review_comments":{"href":"https://api.github.com/repos/zenspider/enhanced-ruby-mode/pulls/89/comments"},"review_comment":{"href":"https://api.github.com/repos/zenspider/enhanced-ruby-mode/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zenspider/enhanced-ruby-mode/pulls/89/commits"},"statuses":{"href":"https://api.github.com/repos/zenspider/enhanced-ruby-mode/statuses/efe6a28bd7bba9361de8f3bac366d9c4d905e6b6"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"zenspider","id":9832,"avatar_url":"https://avatars.githubusercontent.com/u/9832?v=3","gravatar_id":"","url":"https://api.github.com/users/zenspider","html_url":"https://github.com/zenspider","followers_url":"https://api.github.com/users/zenspider/followers","following_url":"https://api.github.com/users/zenspider/following{/other_user}","gists_url":"https://api.github.com/users/zenspider/gists{/gist_id}","starred_url":"https://api.github.com/users/zenspider/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zenspider/subscriptions","organizations_url":"https://api.github.com/users/zenspider/orgs","repos_url":"https://api.github.com/users/zenspider/repos","events_url":"https://api.github.com/users/zenspider/events{/privacy}","received_events_url":"https://api.github.com/users/zenspider/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}