{"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/48257157","id":48257157,"diff_hunk":"@@ -0,0 +1,10 @@\n+class ApplicationHelper::Button::ChargebackDownloadChoice < ApplicationHelper::Button::Basic\n+  def calculate_properties\n+    super\n+    if @view_context.x_active_tree == :cb_reports_tree &&\n+       @report && !@report.contains_records?\n+      props[\"enabled\"] = \"false\"\n+      props[\"title\"] = _(\"No records found for this report\")","path":"app/helpers/application_helper/button/chargeback_download_choice.rb","position":7,"original_position":7,"commit_id":"790369012d0ed38d9be3ba90b82619492e62314e","original_commit_id":"790369012d0ed38d9be3ba90b82619492e62314e","user":{"login":"martinpovolny","id":51095,"avatar_url":"https://avatars.githubusercontent.com/u/51095?v=3","gravatar_id":"","url":"https://api.github.com/users/martinpovolny","html_url":"https://github.com/martinpovolny","followers_url":"https://api.github.com/users/martinpovolny/followers","following_url":"https://api.github.com/users/martinpovolny/following{/other_user}","gists_url":"https://api.github.com/users/martinpovolny/gists{/gist_id}","starred_url":"https://api.github.com/users/martinpovolny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinpovolny/subscriptions","organizations_url":"https://api.github.com/users/martinpovolny/orgs","repos_url":"https://api.github.com/users/martinpovolny/repos","events_url":"https://api.github.com/users/martinpovolny/events{/privacy}","received_events_url":"https://api.github.com/users/martinpovolny/received_events","type":"User","site_admin":false},"body":"yes, thx","created_at":"2015-12-22T14:29:34Z","updated_at":"2015-12-22T14:29:34Z","html_url":"https://github.com/ManageIQ/manageiq/pull/5783#discussion_r48257157","pull_request_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/5783","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/48257157"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/5783#discussion_r48257157"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/5783"}}},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/5783","id":53267508,"html_url":"https://github.com/ManageIQ/manageiq/pull/5783","diff_url":"https://github.com/ManageIQ/manageiq/pull/5783.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/5783.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/5783","number":5783,"state":"open","locked":false,"title":"Toolbars: introduce classes for buttons.","user":{"login":"martinpovolny","id":51095,"avatar_url":"https://avatars.githubusercontent.com/u/51095?v=3","gravatar_id":"","url":"https://api.github.com/users/martinpovolny","html_url":"https://github.com/martinpovolny","followers_url":"https://api.github.com/users/martinpovolny/followers","following_url":"https://api.github.com/users/martinpovolny/following{/other_user}","gists_url":"https://api.github.com/users/martinpovolny/gists{/gist_id}","starred_url":"https://api.github.com/users/martinpovolny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinpovolny/subscriptions","organizations_url":"https://api.github.com/users/martinpovolny/orgs","repos_url":"https://api.github.com/users/martinpovolny/repos","events_url":"https://api.github.com/users/martinpovolny/events{/privacy}","received_events_url":"https://api.github.com/users/martinpovolny/received_events","type":"User","site_admin":false},"body":"The idea is to move the logic specific to particular buttons to classes representing the individual buttons.\r\n\r\nThen in `ApplicationHelper::ToolbarBuilder` only generic logic would remain and the task of adding buttons and toolbars in the future would not include changes to this class.","created_at":"2015-12-10T14:49:19Z","updated_at":"2015-12-22T14:29:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"adf150fb6ebbb22967b95030b62e307eae0abcc9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/5783/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/5783/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/5783/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/790369012d0ed38d9be3ba90b82619492e62314e","head":{"label":"martinpovolny:toolbar_button_classes","ref":"toolbar_button_classes","sha":"790369012d0ed38d9be3ba90b82619492e62314e","user":{"login":"martinpovolny","id":51095,"avatar_url":"https://avatars.githubusercontent.com/u/51095?v=3","gravatar_id":"","url":"https://api.github.com/users/martinpovolny","html_url":"https://github.com/martinpovolny","followers_url":"https://api.github.com/users/martinpovolny/followers","following_url":"https://api.github.com/users/martinpovolny/following{/other_user}","gists_url":"https://api.github.com/users/martinpovolny/gists{/gist_id}","starred_url":"https://api.github.com/users/martinpovolny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinpovolny/subscriptions","organizations_url":"https://api.github.com/users/martinpovolny/orgs","repos_url":"https://api.github.com/users/martinpovolny/repos","events_url":"https://api.github.com/users/martinpovolny/events{/privacy}","received_events_url":"https://api.github.com/users/martinpovolny/received_events","type":"User","site_admin":false},"repo":{"id":20877847,"name":"manageiq","full_name":"martinpovolny/manageiq","owner":{"login":"martinpovolny","id":51095,"avatar_url":"https://avatars.githubusercontent.com/u/51095?v=3","gravatar_id":"","url":"https://api.github.com/users/martinpovolny","html_url":"https://github.com/martinpovolny","followers_url":"https://api.github.com/users/martinpovolny/followers","following_url":"https://api.github.com/users/martinpovolny/following{/other_user}","gists_url":"https://api.github.com/users/martinpovolny/gists{/gist_id}","starred_url":"https://api.github.com/users/martinpovolny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinpovolny/subscriptions","organizations_url":"https://api.github.com/users/martinpovolny/orgs","repos_url":"https://api.github.com/users/martinpovolny/repos","events_url":"https://api.github.com/users/martinpovolny/events{/privacy}","received_events_url":"https://api.github.com/users/martinpovolny/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/martinpovolny/manageiq","description":"ManageIQ Cloud Management Platform","fork":true,"url":"https://api.github.com/repos/martinpovolny/manageiq","forks_url":"https://api.github.com/repos/martinpovolny/manageiq/forks","keys_url":"https://api.github.com/repos/martinpovolny/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/martinpovolny/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/martinpovolny/manageiq/teams","hooks_url":"https://api.github.com/repos/martinpovolny/manageiq/hooks","issue_events_url":"https://api.github.com/repos/martinpovolny/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/martinpovolny/manageiq/events","assignees_url":"https://api.github.com/repos/martinpovolny/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/martinpovolny/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/martinpovolny/manageiq/tags","blobs_url":"https://api.github.com/repos/martinpovolny/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/martinpovolny/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/martinpovolny/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/martinpovolny/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/martinpovolny/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/martinpovolny/manageiq/languages","stargazers_url":"https://api.github.com/repos/martinpovolny/manageiq/stargazers","contributors_url":"https://api.github.com/repos/martinpovolny/manageiq/contributors","subscribers_url":"https://api.github.com/repos/martinpovolny/manageiq/subscribers","subscription_url":"https://api.github.com/repos/martinpovolny/manageiq/subscription","commits_url":"https://api.github.com/repos/martinpovolny/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/martinpovolny/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/martinpovolny/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/martinpovolny/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/martinpovolny/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/martinpovolny/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/martinpovolny/manageiq/merges","archive_url":"https://api.github.com/repos/martinpovolny/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/martinpovolny/manageiq/downloads","issues_url":"https://api.github.com/repos/martinpovolny/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/martinpovolny/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/martinpovolny/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/martinpovolny/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/martinpovolny/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/martinpovolny/manageiq/releases{/id}","created_at":"2014-06-16T08:30:21Z","updated_at":"2015-04-03T17:04:59Z","pushed_at":"2015-12-22T13:00:43Z","git_url":"git://github.com/martinpovolny/manageiq.git","ssh_url":"git@github.com:martinpovolny/manageiq.git","clone_url":"https://github.com/martinpovolny/manageiq.git","svn_url":"https://github.com/martinpovolny/manageiq","homepage":null,"size":114947,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"48c9c8e52a5f5794539cb987943757a6e4da0abc","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":20789757,"name":"manageiq","full_name":"ManageIQ/manageiq","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq","description":"ManageIQ Cloud Management Platform","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq","forks_url":"https://api.github.com/repos/ManageIQ/manageiq/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq/releases{/id}","created_at":"2014-06-13T02:31:26Z","updated_at":"2015-12-22T13:43:45Z","pushed_at":"2015-12-22T14:27:46Z","git_url":"git://github.com/ManageIQ/manageiq.git","ssh_url":"git@github.com:ManageIQ/manageiq.git","clone_url":"https://github.com/ManageIQ/manageiq.git","svn_url":"https://github.com/ManageIQ/manageiq","homepage":"manageiq.org","size":133892,"stargazers_count":183,"watchers_count":183,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":197,"mirror_url":null,"open_issues_count":481,"forks":197,"open_issues":481,"watchers":183,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/5783"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/5783"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/5783"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/5783/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/5783/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/5783/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq/statuses/790369012d0ed38d9be3ba90b82619492e62314e"}}}}