{"action":"created","comment":{"url":"https://api.github.com/repos/vimeo/VIMNetworking/pulls/comments/37203766","id":37203766,"diff_hunk":"@@ -31,13 +31,24 @@ extern NSString *const __nonnull VIMTaskQueueTaskSucceededNotification;\n \n @class VIMTask;\n \n+@protocol VIMTaskQueueArchiverProtocol <NSObject>\n+\n+@required\n+- (nullable id)loadObjectForKey:(nonnull NSString *)key;\n+- (void)saveObject:(nonnull id)object forKey:(nonnull NSString *)key;\n+- (void)deleteObjectForKey:(nonnull NSString *)key;\n+\n+@end\n+\n @interface VIMTaskQueue : NSObject\n \n @property (nonatomic, strong, readonly, nullable) NSString *name;\n \n+@property (nonatomic, strong, readonly, nullable) id<VIMTaskQueueArchiverProtocol> archiver;","path":"VIMNetworking/Networking/Upload/TaskQueue/VIMTaskQueue.h","position":17,"original_position":17,"commit_id":"a6117f028145a184f35dfeef3e1678cfe2fd8f6d","original_commit_id":"a6117f028145a184f35dfeef3e1678cfe2fd8f6d","user":{"login":"huebnerob","id":4182788,"avatar_url":"https://avatars.githubusercontent.com/u/4182788?v=3","gravatar_id":"","url":"https://api.github.com/users/huebnerob","html_url":"https://github.com/huebnerob","followers_url":"https://api.github.com/users/huebnerob/followers","following_url":"https://api.github.com/users/huebnerob/following{/other_user}","gists_url":"https://api.github.com/users/huebnerob/gists{/gist_id}","starred_url":"https://api.github.com/users/huebnerob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huebnerob/subscriptions","organizations_url":"https://api.github.com/users/huebnerob/orgs","repos_url":"https://api.github.com/users/huebnerob/repos","events_url":"https://api.github.com/users/huebnerob/events{/privacy}","received_events_url":"https://api.github.com/users/huebnerob/received_events","type":"User","site_admin":false},"body":"shouldn't this be `nonnull` since the initializer below accepts a `nonnull` archiver var?","created_at":"2015-08-17T16:03:10Z","updated_at":"2015-08-17T16:03:10Z","html_url":"https://github.com/vimeo/VIMNetworking/pull/105#discussion_r37203766","pull_request_url":"https://api.github.com/repos/vimeo/VIMNetworking/pulls/105","_links":{"self":{"href":"https://api.github.com/repos/vimeo/VIMNetworking/pulls/comments/37203766"},"html":{"href":"https://github.com/vimeo/VIMNetworking/pull/105#discussion_r37203766"},"pull_request":{"href":"https://api.github.com/repos/vimeo/VIMNetworking/pulls/105"}}},"pull_request":{"url":"https://api.github.com/repos/vimeo/VIMNetworking/pulls/105","id":42513300,"html_url":"https://github.com/vimeo/VIMNetworking/pull/105","diff_url":"https://github.com/vimeo/VIMNetworking/pull/105.diff","patch_url":"https://github.com/vimeo/VIMNetworking/pull/105.patch","issue_url":"https://api.github.com/repos/vimeo/VIMNetworking/issues/105","number":105,"state":"closed","locked":false,"title":"VIM-2692","user":{"login":"alfiehanssen","id":991059,"avatar_url":"https://avatars.githubusercontent.com/u/991059?v=3","gravatar_id":"","url":"https://api.github.com/users/alfiehanssen","html_url":"https://github.com/alfiehanssen","followers_url":"https://api.github.com/users/alfiehanssen/followers","following_url":"https://api.github.com/users/alfiehanssen/following{/other_user}","gists_url":"https://api.github.com/users/alfiehanssen/gists{/gist_id}","starred_url":"https://api.github.com/users/alfiehanssen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alfiehanssen/subscriptions","organizations_url":"https://api.github.com/users/alfiehanssen/orgs","repos_url":"https://api.github.com/users/alfiehanssen/repos","events_url":"https://api.github.com/users/alfiehanssen/events{/privacy}","received_events_url":"https://api.github.com/users/alfiehanssen/received_events","type":"User","site_admin":false},"body":"https://vimean.atlassian.net/browse/VIM-2692","created_at":"2015-08-15T04:03:43Z","updated_at":"2015-08-17T16:03:10Z","closed_at":"2015-08-15T04:07:43Z","merged_at":"2015-08-15T04:07:43Z","merge_commit_sha":"6ebc4df67d6c5456985100ecf8e25708d9302660","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/vimeo/VIMNetworking/pulls/105/commits","review_comments_url":"https://api.github.com/repos/vimeo/VIMNetworking/pulls/105/comments","review_comment_url":"https://api.github.com/repos/vimeo/VIMNetworking/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vimeo/VIMNetworking/issues/105/comments","statuses_url":"https://api.github.com/repos/vimeo/VIMNetworking/statuses/a6117f028145a184f35dfeef3e1678cfe2fd8f6d","head":{"label":"vimeo:vim-2692","ref":"vim-2692","sha":"a6117f028145a184f35dfeef3e1678cfe2fd8f6d","user":{"login":"vimeo","id":317769,"avatar_url":"https://avatars.githubusercontent.com/u/317769?v=3","gravatar_id":"","url":"https://api.github.com/users/vimeo","html_url":"https://github.com/vimeo","followers_url":"https://api.github.com/users/vimeo/followers","following_url":"https://api.github.com/users/vimeo/following{/other_user}","gists_url":"https://api.github.com/users/vimeo/gists{/gist_id}","starred_url":"https://api.github.com/users/vimeo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vimeo/subscriptions","organizations_url":"https://api.github.com/users/vimeo/orgs","repos_url":"https://api.github.com/users/vimeo/repos","events_url":"https://api.github.com/users/vimeo/events{/privacy}","received_events_url":"https://api.github.com/users/vimeo/received_events","type":"Organization","site_admin":false},"repo":{"id":33740468,"name":"VIMNetworking","full_name":"vimeo/VIMNetworking","owner":{"login":"vimeo","id":317769,"avatar_url":"https://avatars.githubusercontent.com/u/317769?v=3","gravatar_id":"","url":"https://api.github.com/users/vimeo","html_url":"https://github.com/vimeo","followers_url":"https://api.github.com/users/vimeo/followers","following_url":"https://api.github.com/users/vimeo/following{/other_user}","gists_url":"https://api.github.com/users/vimeo/gists{/gist_id}","starred_url":"https://api.github.com/users/vimeo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vimeo/subscriptions","organizations_url":"https://api.github.com/users/vimeo/orgs","repos_url":"https://api.github.com/users/vimeo/repos","events_url":"https://api.github.com/users/vimeo/events{/privacy}","received_events_url":"https://api.github.com/users/vimeo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vimeo/VIMNetworking","description":"The Vimeo iOS SDK","fork":false,"url":"https://api.github.com/repos/vimeo/VIMNetworking","forks_url":"https://api.github.com/repos/vimeo/VIMNetworking/forks","keys_url":"https://api.github.com/repos/vimeo/VIMNetworking/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vimeo/VIMNetworking/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vimeo/VIMNetworking/teams","hooks_url":"https://api.github.com/repos/vimeo/VIMNetworking/hooks","issue_events_url":"https://api.github.com/repos/vimeo/VIMNetworking/issues/events{/number}","events_url":"https://api.github.com/repos/vimeo/VIMNetworking/events","assignees_url":"https://api.github.com/repos/vimeo/VIMNetworking/assignees{/user}","branches_url":"https://api.github.com/repos/vimeo/VIMNetworking/branches{/branch}","tags_url":"https://api.github.com/repos/vimeo/VIMNetworking/tags","blobs_url":"https://api.github.com/repos/vimeo/VIMNetworking/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vimeo/VIMNetworking/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vimeo/VIMNetworking/git/refs{/sha}","trees_url":"https://api.github.com/repos/vimeo/VIMNetworking/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vimeo/VIMNetworking/statuses/{sha}","languages_url":"https://api.github.com/repos/vimeo/VIMNetworking/languages","stargazers_url":"https://api.github.com/repos/vimeo/VIMNetworking/stargazers","contributors_url":"https://api.github.com/repos/vimeo/VIMNetworking/contributors","subscribers_url":"https://api.github.com/repos/vimeo/VIMNetworking/subscribers","subscription_url":"https://api.github.com/repos/vimeo/VIMNetworking/subscription","commits_url":"https://api.github.com/repos/vimeo/VIMNetworking/commits{/sha}","git_commits_url":"https://api.github.com/repos/vimeo/VIMNetworking/git/commits{/sha}","comments_url":"https://api.github.com/repos/vimeo/VIMNetworking/comments{/number}","issue_comment_url":"https://api.github.com/repos/vimeo/VIMNetworking/issues/comments{/number}","contents_url":"https://api.github.com/repos/vimeo/VIMNetworking/contents/{+path}","compare_url":"https://api.github.com/repos/vimeo/VIMNetworking/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vimeo/VIMNetworking/merges","archive_url":"https://api.github.com/repos/vimeo/VIMNetworking/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vimeo/VIMNetworking/downloads","issues_url":"https://api.github.com/repos/vimeo/VIMNetworking/issues{/number}","pulls_url":"https://api.github.com/repos/vimeo/VIMNetworking/pulls{/number}","milestones_url":"https://api.github.com/repos/vimeo/VIMNetworking/milestones{/number}","notifications_url":"https://api.github.com/repos/vimeo/VIMNetworking/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vimeo/VIMNetworking/labels{/name}","releases_url":"https://api.github.com/repos/vimeo/VIMNetworking/releases{/id}","created_at":"2015-04-10T17:08:40Z","updated_at":"2015-06-16T02:12:12Z","pushed_at":"2015-08-15T04:09:01Z","git_url":"git://github.com/vimeo/VIMNetworking.git","ssh_url":"git@github.com:vimeo/VIMNetworking.git","clone_url":"https://github.com/vimeo/VIMNetworking.git","svn_url":"https://github.com/vimeo/VIMNetworking","homepage":null,"size":1721,"stargazers_count":16,"watchers_count":16,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":1,"forks":8,"open_issues":1,"watchers":16,"default_branch":"master"}},"base":{"label":"vimeo:master","ref":"master","sha":"2f41b18619e978303552cca720304d99f3a67c4b","user":{"login":"vimeo","id":317769,"avatar_url":"https://avatars.githubusercontent.com/u/317769?v=3","gravatar_id":"","url":"https://api.github.com/users/vimeo","html_url":"https://github.com/vimeo","followers_url":"https://api.github.com/users/vimeo/followers","following_url":"https://api.github.com/users/vimeo/following{/other_user}","gists_url":"https://api.github.com/users/vimeo/gists{/gist_id}","starred_url":"https://api.github.com/users/vimeo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vimeo/subscriptions","organizations_url":"https://api.github.com/users/vimeo/orgs","repos_url":"https://api.github.com/users/vimeo/repos","events_url":"https://api.github.com/users/vimeo/events{/privacy}","received_events_url":"https://api.github.com/users/vimeo/received_events","type":"Organization","site_admin":false},"repo":{"id":33740468,"name":"VIMNetworking","full_name":"vimeo/VIMNetworking","owner":{"login":"vimeo","id":317769,"avatar_url":"https://avatars.githubusercontent.com/u/317769?v=3","gravatar_id":"","url":"https://api.github.com/users/vimeo","html_url":"https://github.com/vimeo","followers_url":"https://api.github.com/users/vimeo/followers","following_url":"https://api.github.com/users/vimeo/following{/other_user}","gists_url":"https://api.github.com/users/vimeo/gists{/gist_id}","starred_url":"https://api.github.com/users/vimeo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vimeo/subscriptions","organizations_url":"https://api.github.com/users/vimeo/orgs","repos_url":"https://api.github.com/users/vimeo/repos","events_url":"https://api.github.com/users/vimeo/events{/privacy}","received_events_url":"https://api.github.com/users/vimeo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vimeo/VIMNetworking","description":"The Vimeo iOS SDK","fork":false,"url":"https://api.github.com/repos/vimeo/VIMNetworking","forks_url":"https://api.github.com/repos/vimeo/VIMNetworking/forks","keys_url":"https://api.github.com/repos/vimeo/VIMNetworking/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vimeo/VIMNetworking/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vimeo/VIMNetworking/teams","hooks_url":"https://api.github.com/repos/vimeo/VIMNetworking/hooks","issue_events_url":"https://api.github.com/repos/vimeo/VIMNetworking/issues/events{/number}","events_url":"https://api.github.com/repos/vimeo/VIMNetworking/events","assignees_url":"https://api.github.com/repos/vimeo/VIMNetworking/assignees{/user}","branches_url":"https://api.github.com/repos/vimeo/VIMNetworking/branches{/branch}","tags_url":"https://api.github.com/repos/vimeo/VIMNetworking/tags","blobs_url":"https://api.github.com/repos/vimeo/VIMNetworking/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vimeo/VIMNetworking/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vimeo/VIMNetworking/git/refs{/sha}","trees_url":"https://api.github.com/repos/vimeo/VIMNetworking/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vimeo/VIMNetworking/statuses/{sha}","languages_url":"https://api.github.com/repos/vimeo/VIMNetworking/languages","stargazers_url":"https://api.github.com/repos/vimeo/VIMNetworking/stargazers","contributors_url":"https://api.github.com/repos/vimeo/VIMNetworking/contributors","subscribers_url":"https://api.github.com/repos/vimeo/VIMNetworking/subscribers","subscription_url":"https://api.github.com/repos/vimeo/VIMNetworking/subscription","commits_url":"https://api.github.com/repos/vimeo/VIMNetworking/commits{/sha}","git_commits_url":"https://api.github.com/repos/vimeo/VIMNetworking/git/commits{/sha}","comments_url":"https://api.github.com/repos/vimeo/VIMNetworking/comments{/number}","issue_comment_url":"https://api.github.com/repos/vimeo/VIMNetworking/issues/comments{/number}","contents_url":"https://api.github.com/repos/vimeo/VIMNetworking/contents/{+path}","compare_url":"https://api.github.com/repos/vimeo/VIMNetworking/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vimeo/VIMNetworking/merges","archive_url":"https://api.github.com/repos/vimeo/VIMNetworking/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vimeo/VIMNetworking/downloads","issues_url":"https://api.github.com/repos/vimeo/VIMNetworking/issues{/number}","pulls_url":"https://api.github.com/repos/vimeo/VIMNetworking/pulls{/number}","milestones_url":"https://api.github.com/repos/vimeo/VIMNetworking/milestones{/number}","notifications_url":"https://api.github.com/repos/vimeo/VIMNetworking/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vimeo/VIMNetworking/labels{/name}","releases_url":"https://api.github.com/repos/vimeo/VIMNetworking/releases{/id}","created_at":"2015-04-10T17:08:40Z","updated_at":"2015-06-16T02:12:12Z","pushed_at":"2015-08-15T04:09:01Z","git_url":"git://github.com/vimeo/VIMNetworking.git","ssh_url":"git@github.com:vimeo/VIMNetworking.git","clone_url":"https://github.com/vimeo/VIMNetworking.git","svn_url":"https://github.com/vimeo/VIMNetworking","homepage":null,"size":1721,"stargazers_count":16,"watchers_count":16,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":1,"forks":8,"open_issues":1,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vimeo/VIMNetworking/pulls/105"},"html":{"href":"https://github.com/vimeo/VIMNetworking/pull/105"},"issue":{"href":"https://api.github.com/repos/vimeo/VIMNetworking/issues/105"},"comments":{"href":"https://api.github.com/repos/vimeo/VIMNetworking/issues/105/comments"},"review_comments":{"href":"https://api.github.com/repos/vimeo/VIMNetworking/pulls/105/comments"},"review_comment":{"href":"https://api.github.com/repos/vimeo/VIMNetworking/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vimeo/VIMNetworking/pulls/105/commits"},"statuses":{"href":"https://api.github.com/repos/vimeo/VIMNetworking/statuses/a6117f028145a184f35dfeef3e1678cfe2fd8f6d"}}}}