{"action":"created","issue":{"url":"https://api.github.com/repos/emberjs/ember-collection/issues/3","labels_url":"https://api.github.com/repos/emberjs/ember-collection/issues/3/labels{/name}","comments_url":"https://api.github.com/repos/emberjs/ember-collection/issues/3/comments","events_url":"https://api.github.com/repos/emberjs/ember-collection/issues/3/events","html_url":"https://github.com/emberjs/ember-collection/pull/3","id":101134132,"number":3,"title":"Fixes offset bug; adds actions; fixes (more) tests","user":{"login":"shaunc","id":193170,"avatar_url":"https://avatars.githubusercontent.com/u/193170?v=3","gravatar_id":"","url":"https://api.github.com/users/shaunc","html_url":"https://github.com/shaunc","followers_url":"https://api.github.com/users/shaunc/followers","following_url":"https://api.github.com/users/shaunc/following{/other_user}","gists_url":"https://api.github.com/users/shaunc/gists{/gist_id}","starred_url":"https://api.github.com/users/shaunc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shaunc/subscriptions","organizations_url":"https://api.github.com/users/shaunc/orgs","repos_url":"https://api.github.com/users/shaunc/repos","events_url":"https://api.github.com/users/shaunc/events{/privacy}","received_events_url":"https://api.github.com/users/shaunc/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":23,"created_at":"2015-08-15T03:01:43Z","updated_at":"2015-08-19T14:39:22Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/emberjs/ember-collection/pulls/3","html_url":"https://github.com/emberjs/ember-collection/pull/3","diff_url":"https://github.com/emberjs/ember-collection/pull/3.diff","patch_url":"https://github.com/emberjs/ember-collection/pull/3.patch"},"body":"The offset bug is fixed now; I've changed the layout-bin-packer dependency temporarily pending action from @stefanpenner.\r\n\r\nThe old tests checked startingIndex computed property (which is the first visible item). It seemed to me the corresponding 2.0 interface would be to allow an action to observe this -- so have added `startingIndexDidChange` and `visibleCountDidChange` (number of items visible). \r\n\r\nI had difficulty testing these. You can't just use `<integration-test-context>.set('action-name', function())` ... I tried various things and in the end wrote a wrapper object in the dummy application, which I think is quite awkward. If there is a better way to test, please let me know! :)\r\n\r\nAll the tests for \"fixedGrid\" are now working. I still need to write tests for \"mixedGrid\"."},"comment":{"url":"https://api.github.com/repos/emberjs/ember-collection/issues/comments/132622727","html_url":"https://github.com/emberjs/ember-collection/pull/3#issuecomment-132622727","issue_url":"https://api.github.com/repos/emberjs/ember-collection/issues/3","id":132622727,"user":{"login":"mmun","id":1151810,"avatar_url":"https://avatars.githubusercontent.com/u/1151810?v=3","gravatar_id":"","url":"https://api.github.com/users/mmun","html_url":"https://github.com/mmun","followers_url":"https://api.github.com/users/mmun/followers","following_url":"https://api.github.com/users/mmun/following{/other_user}","gists_url":"https://api.github.com/users/mmun/gists{/gist_id}","starred_url":"https://api.github.com/users/mmun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmun/subscriptions","organizations_url":"https://api.github.com/users/mmun/orgs","repos_url":"https://api.github.com/users/mmun/repos","events_url":"https://api.github.com/users/mmun/events{/privacy}","received_events_url":"https://api.github.com/users/mmun/received_events","type":"User","site_admin":false},"created_at":"2015-08-19T14:39:22Z","updated_at":"2015-08-19T14:39:22Z","body":"@shaunc Can you make an issue about sliceDidChange? You're right that conceptually it fits DDAU just fine. We were looking for use cases.\r\n\r\nPlease know that I feel bad this didn't go smoothly. I tried to make up for it with the cherry-pick of the first commit. Thank you for your hard work."}}