{"action":"created","issue":{"url":"https://api.github.com/repos/finn-no/maven-deploy/issues/17","labels_url":"https://api.github.com/repos/finn-no/maven-deploy/issues/17/labels{/name}","comments_url":"https://api.github.com/repos/finn-no/maven-deploy/issues/17/comments","events_url":"https://api.github.com/repos/finn-no/maven-deploy/issues/17/events","html_url":"https://github.com/finn-no/maven-deploy/pull/17","id":77605189,"number":17,"title":"fix path for windows user, make tests pass on windows","user":{"login":"antoniopuero","id":1562509,"avatar_url":"https://avatars.githubusercontent.com/u/1562509?v=3","gravatar_id":"","url":"https://api.github.com/users/antoniopuero","html_url":"https://github.com/antoniopuero","followers_url":"https://api.github.com/users/antoniopuero/followers","following_url":"https://api.github.com/users/antoniopuero/following{/other_user}","gists_url":"https://api.github.com/users/antoniopuero/gists{/gist_id}","starred_url":"https://api.github.com/users/antoniopuero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antoniopuero/subscriptions","organizations_url":"https://api.github.com/users/antoniopuero/orgs","repos_url":"https://api.github.com/users/antoniopuero/repos","events_url":"https://api.github.com/users/antoniopuero/events{/privacy}","received_events_url":"https://api.github.com/users/antoniopuero/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-05-18T10:45:23Z","updated_at":"2015-05-18T12:21:29Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/finn-no/maven-deploy/pulls/17","html_url":"https://github.com/finn-no/maven-deploy/pull/17","diff_url":"https://github.com/finn-no/maven-deploy/pull/17.diff","patch_url":"https://github.com/finn-no/maven-deploy/pull/17.patch"},"body":"There was a problem with creating archive on windows: it created files with foldername\\filename names instead of creating actual folder which contains thess files. That's caused by node path module. I havn't seen any better solution for cross-platform compatibility than just replace backslashes with slashes."},"comment":{"url":"https://api.github.com/repos/finn-no/maven-deploy/issues/comments/103041221","html_url":"https://github.com/finn-no/maven-deploy/pull/17#issuecomment-103041221","issue_url":"https://api.github.com/repos/finn-no/maven-deploy/issues/17","id":103041221,"user":{"login":"gregersrygg","id":149725,"avatar_url":"https://avatars.githubusercontent.com/u/149725?v=3","gravatar_id":"","url":"https://api.github.com/users/gregersrygg","html_url":"https://github.com/gregersrygg","followers_url":"https://api.github.com/users/gregersrygg/followers","following_url":"https://api.github.com/users/gregersrygg/following{/other_user}","gists_url":"https://api.github.com/users/gregersrygg/gists{/gist_id}","starred_url":"https://api.github.com/users/gregersrygg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregersrygg/subscriptions","organizations_url":"https://api.github.com/users/gregersrygg/orgs","repos_url":"https://api.github.com/users/gregersrygg/repos","events_url":"https://api.github.com/users/gregersrygg/events{/privacy}","received_events_url":"https://api.github.com/users/gregersrygg/received_events","type":"User","site_admin":false},"created_at":"2015-05-18T12:21:29Z","updated_at":"2015-05-18T12:21:29Z","body":"Can you please explain a bit more about why this fails on Windows? Is it because JSZip expects forward-slashes in the path even on Windows? Or is it because of the shell you're using? path.join is supposed to use the correct path for the OS, but if JSZip doesn't handle Windows-paths it would be better to skip using path.join for the path we pass to JSZip."}}