{"action":"created","comment":{"url":"https://api.github.com/repos/silexphp/Silex/pulls/comments/23064776","id":23064776,"diff_hunk":"@@ -23,8 +23,6 @@\n      *\n      * This method should only be used to configure services and parameters.\n      * It should not get services.\n-     *\n-     * @param Application $app An Application instance","path":"src/Silex/ServiceProviderInterface.php","position":5,"original_position":5,"commit_id":"bfe00545e90eb4a5fdf7633796c3a5d22e1d5eb6","original_commit_id":"bfe00545e90eb4a5fdf7633796c3a5d22e1d5eb6","user":{"login":"fabpot","id":47313,"avatar_url":"https://avatars.githubusercontent.com/u/47313?v=3","gravatar_id":"","url":"https://api.github.com/users/fabpot","html_url":"https://github.com/fabpot","followers_url":"https://api.github.com/users/fabpot/followers","following_url":"https://api.github.com/users/fabpot/following{/other_user}","gists_url":"https://api.github.com/users/fabpot/gists{/gist_id}","starred_url":"https://api.github.com/users/fabpot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabpot/subscriptions","organizations_url":"https://api.github.com/users/fabpot/orgs","repos_url":"https://api.github.com/users/fabpot/repos","events_url":"https://api.github.com/users/fabpot/events{/privacy}","received_events_url":"https://api.github.com/users/fabpot/received_events","type":"User","site_admin":false},"body":"No, it does not add any value, the method signature already tell you the same.","created_at":"2015-01-16T06:10:28Z","updated_at":"2015-01-16T06:10:28Z","html_url":"https://github.com/silexphp/Silex/pull/1091#discussion_r23064776","pull_request_url":"https://api.github.com/repos/silexphp/Silex/pulls/1091","_links":{"self":{"href":"https://api.github.com/repos/silexphp/Silex/pulls/comments/23064776"},"html":{"href":"https://github.com/silexphp/Silex/pull/1091#discussion_r23064776"},"pull_request":{"href":"https://api.github.com/repos/silexphp/Silex/pulls/1091"}}},"pull_request":{"url":"https://api.github.com/repos/silexphp/Silex/pulls/1091","id":27396649,"html_url":"https://github.com/silexphp/Silex/pull/1091","diff_url":"https://github.com/silexphp/Silex/pull/1091.diff","patch_url":"https://github.com/silexphp/Silex/pull/1091.patch","issue_url":"https://api.github.com/repos/silexphp/Silex/issues/1091","number":1091,"state":"open","locked":false,"title":"[Minor] Remove dead code & fix phpdoc","user":{"login":"SofHad","id":1835430,"avatar_url":"https://avatars.githubusercontent.com/u/1835430?v=3","gravatar_id":"","url":"https://api.github.com/users/SofHad","html_url":"https://github.com/SofHad","followers_url":"https://api.github.com/users/SofHad/followers","following_url":"https://api.github.com/users/SofHad/following{/other_user}","gists_url":"https://api.github.com/users/SofHad/gists{/gist_id}","starred_url":"https://api.github.com/users/SofHad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SofHad/subscriptions","organizations_url":"https://api.github.com/users/SofHad/orgs","repos_url":"https://api.github.com/users/SofHad/repos","events_url":"https://api.github.com/users/SofHad/events{/privacy}","received_events_url":"https://api.github.com/users/SofHad/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-01-15T00:27:40Z","updated_at":"2015-01-16T06:10:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"567dfb4246d8aa5053ea5bca239d359099082f31","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/silexphp/Silex/pulls/1091/commits","review_comments_url":"https://api.github.com/repos/silexphp/Silex/pulls/1091/comments","review_comment_url":"https://api.github.com/repos/silexphp/Silex/pulls/comments/{number}","comments_url":"https://api.github.com/repos/silexphp/Silex/issues/1091/comments","statuses_url":"https://api.github.com/repos/silexphp/Silex/statuses/bfe00545e90eb4a5fdf7633796c3a5d22e1d5eb6","head":{"label":"SofHad:fix-dead-code","ref":"fix-dead-code","sha":"bfe00545e90eb4a5fdf7633796c3a5d22e1d5eb6","user":{"login":"SofHad","id":1835430,"avatar_url":"https://avatars.githubusercontent.com/u/1835430?v=3","gravatar_id":"","url":"https://api.github.com/users/SofHad","html_url":"https://github.com/SofHad","followers_url":"https://api.github.com/users/SofHad/followers","following_url":"https://api.github.com/users/SofHad/following{/other_user}","gists_url":"https://api.github.com/users/SofHad/gists{/gist_id}","starred_url":"https://api.github.com/users/SofHad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SofHad/subscriptions","organizations_url":"https://api.github.com/users/SofHad/orgs","repos_url":"https://api.github.com/users/SofHad/repos","events_url":"https://api.github.com/users/SofHad/events{/privacy}","received_events_url":"https://api.github.com/users/SofHad/received_events","type":"User","site_admin":false},"repo":{"id":29267106,"name":"Silex","full_name":"SofHad/Silex","owner":{"login":"SofHad","id":1835430,"avatar_url":"https://avatars.githubusercontent.com/u/1835430?v=3","gravatar_id":"","url":"https://api.github.com/users/SofHad","html_url":"https://github.com/SofHad","followers_url":"https://api.github.com/users/SofHad/followers","following_url":"https://api.github.com/users/SofHad/following{/other_user}","gists_url":"https://api.github.com/users/SofHad/gists{/gist_id}","starred_url":"https://api.github.com/users/SofHad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SofHad/subscriptions","organizations_url":"https://api.github.com/users/SofHad/orgs","repos_url":"https://api.github.com/users/SofHad/repos","events_url":"https://api.github.com/users/SofHad/events{/privacy}","received_events_url":"https://api.github.com/users/SofHad/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SofHad/Silex","description":"The PHP micro-framework based on the Symfony2 Components ","fork":true,"url":"https://api.github.com/repos/SofHad/Silex","forks_url":"https://api.github.com/repos/SofHad/Silex/forks","keys_url":"https://api.github.com/repos/SofHad/Silex/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SofHad/Silex/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SofHad/Silex/teams","hooks_url":"https://api.github.com/repos/SofHad/Silex/hooks","issue_events_url":"https://api.github.com/repos/SofHad/Silex/issues/events{/number}","events_url":"https://api.github.com/repos/SofHad/Silex/events","assignees_url":"https://api.github.com/repos/SofHad/Silex/assignees{/user}","branches_url":"https://api.github.com/repos/SofHad/Silex/branches{/branch}","tags_url":"https://api.github.com/repos/SofHad/Silex/tags","blobs_url":"https://api.github.com/repos/SofHad/Silex/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SofHad/Silex/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SofHad/Silex/git/refs{/sha}","trees_url":"https://api.github.com/repos/SofHad/Silex/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SofHad/Silex/statuses/{sha}","languages_url":"https://api.github.com/repos/SofHad/Silex/languages","stargazers_url":"https://api.github.com/repos/SofHad/Silex/stargazers","contributors_url":"https://api.github.com/repos/SofHad/Silex/contributors","subscribers_url":"https://api.github.com/repos/SofHad/Silex/subscribers","subscription_url":"https://api.github.com/repos/SofHad/Silex/subscription","commits_url":"https://api.github.com/repos/SofHad/Silex/commits{/sha}","git_commits_url":"https://api.github.com/repos/SofHad/Silex/git/commits{/sha}","comments_url":"https://api.github.com/repos/SofHad/Silex/comments{/number}","issue_comment_url":"https://api.github.com/repos/SofHad/Silex/issues/comments/{number}","contents_url":"https://api.github.com/repos/SofHad/Silex/contents/{+path}","compare_url":"https://api.github.com/repos/SofHad/Silex/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SofHad/Silex/merges","archive_url":"https://api.github.com/repos/SofHad/Silex/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SofHad/Silex/downloads","issues_url":"https://api.github.com/repos/SofHad/Silex/issues{/number}","pulls_url":"https://api.github.com/repos/SofHad/Silex/pulls{/number}","milestones_url":"https://api.github.com/repos/SofHad/Silex/milestones{/number}","notifications_url":"https://api.github.com/repos/SofHad/Silex/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SofHad/Silex/labels{/name}","releases_url":"https://api.github.com/repos/SofHad/Silex/releases{/id}","created_at":"2015-01-14T21:37:57Z","updated_at":"2015-01-14T21:37:58Z","pushed_at":"2015-01-15T23:27:50Z","git_url":"git://github.com/SofHad/Silex.git","ssh_url":"git@github.com:SofHad/Silex.git","clone_url":"https://github.com/SofHad/Silex.git","svn_url":"https://github.com/SofHad/Silex","homepage":"silex.sensiolabs.org","size":2879,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"1.2"}},"base":{"label":"silexphp:1.2","ref":"1.2","sha":"ed8423b94b01edcd058fc645057016f6bc75c030","user":{"login":"silexphp","id":3840103,"avatar_url":"https://avatars.githubusercontent.com/u/3840103?v=3","gravatar_id":"","url":"https://api.github.com/users/silexphp","html_url":"https://github.com/silexphp","followers_url":"https://api.github.com/users/silexphp/followers","following_url":"https://api.github.com/users/silexphp/following{/other_user}","gists_url":"https://api.github.com/users/silexphp/gists{/gist_id}","starred_url":"https://api.github.com/users/silexphp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/silexphp/subscriptions","organizations_url":"https://api.github.com/users/silexphp/orgs","repos_url":"https://api.github.com/users/silexphp/repos","events_url":"https://api.github.com/users/silexphp/events{/privacy}","received_events_url":"https://api.github.com/users/silexphp/received_events","type":"Organization","site_admin":false},"repo":{"id":914985,"name":"Silex","full_name":"silexphp/Silex","owner":{"login":"silexphp","id":3840103,"avatar_url":"https://avatars.githubusercontent.com/u/3840103?v=3","gravatar_id":"","url":"https://api.github.com/users/silexphp","html_url":"https://github.com/silexphp","followers_url":"https://api.github.com/users/silexphp/followers","following_url":"https://api.github.com/users/silexphp/following{/other_user}","gists_url":"https://api.github.com/users/silexphp/gists{/gist_id}","starred_url":"https://api.github.com/users/silexphp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/silexphp/subscriptions","organizations_url":"https://api.github.com/users/silexphp/orgs","repos_url":"https://api.github.com/users/silexphp/repos","events_url":"https://api.github.com/users/silexphp/events{/privacy}","received_events_url":"https://api.github.com/users/silexphp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/silexphp/Silex","description":"The PHP micro-framework based on the Symfony2 Components ","fork":false,"url":"https://api.github.com/repos/silexphp/Silex","forks_url":"https://api.github.com/repos/silexphp/Silex/forks","keys_url":"https://api.github.com/repos/silexphp/Silex/keys{/key_id}","collaborators_url":"https://api.github.com/repos/silexphp/Silex/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/silexphp/Silex/teams","hooks_url":"https://api.github.com/repos/silexphp/Silex/hooks","issue_events_url":"https://api.github.com/repos/silexphp/Silex/issues/events{/number}","events_url":"https://api.github.com/repos/silexphp/Silex/events","assignees_url":"https://api.github.com/repos/silexphp/Silex/assignees{/user}","branches_url":"https://api.github.com/repos/silexphp/Silex/branches{/branch}","tags_url":"https://api.github.com/repos/silexphp/Silex/tags","blobs_url":"https://api.github.com/repos/silexphp/Silex/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/silexphp/Silex/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/silexphp/Silex/git/refs{/sha}","trees_url":"https://api.github.com/repos/silexphp/Silex/git/trees{/sha}","statuses_url":"https://api.github.com/repos/silexphp/Silex/statuses/{sha}","languages_url":"https://api.github.com/repos/silexphp/Silex/languages","stargazers_url":"https://api.github.com/repos/silexphp/Silex/stargazers","contributors_url":"https://api.github.com/repos/silexphp/Silex/contributors","subscribers_url":"https://api.github.com/repos/silexphp/Silex/subscribers","subscription_url":"https://api.github.com/repos/silexphp/Silex/subscription","commits_url":"https://api.github.com/repos/silexphp/Silex/commits{/sha}","git_commits_url":"https://api.github.com/repos/silexphp/Silex/git/commits{/sha}","comments_url":"https://api.github.com/repos/silexphp/Silex/comments{/number}","issue_comment_url":"https://api.github.com/repos/silexphp/Silex/issues/comments/{number}","contents_url":"https://api.github.com/repos/silexphp/Silex/contents/{+path}","compare_url":"https://api.github.com/repos/silexphp/Silex/compare/{base}...{head}","merges_url":"https://api.github.com/repos/silexphp/Silex/merges","archive_url":"https://api.github.com/repos/silexphp/Silex/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/silexphp/Silex/downloads","issues_url":"https://api.github.com/repos/silexphp/Silex/issues{/number}","pulls_url":"https://api.github.com/repos/silexphp/Silex/pulls{/number}","milestones_url":"https://api.github.com/repos/silexphp/Silex/milestones{/number}","notifications_url":"https://api.github.com/repos/silexphp/Silex/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/silexphp/Silex/labels{/name}","releases_url":"https://api.github.com/repos/silexphp/Silex/releases{/id}","created_at":"2010-09-16T09:47:20Z","updated_at":"2015-01-16T04:11:42Z","pushed_at":"2015-01-09T17:06:37Z","git_url":"git://github.com/silexphp/Silex.git","ssh_url":"git@github.com:silexphp/Silex.git","clone_url":"https://github.com/silexphp/Silex.git","svn_url":"https://github.com/silexphp/Silex","homepage":"silex.sensiolabs.org","size":7357,"stargazers_count":2496,"watchers_count":2496,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":531,"mirror_url":null,"open_issues_count":73,"forks":531,"open_issues":73,"watchers":2496,"default_branch":"1.2"}},"_links":{"self":{"href":"https://api.github.com/repos/silexphp/Silex/pulls/1091"},"html":{"href":"https://github.com/silexphp/Silex/pull/1091"},"issue":{"href":"https://api.github.com/repos/silexphp/Silex/issues/1091"},"comments":{"href":"https://api.github.com/repos/silexphp/Silex/issues/1091/comments"},"review_comments":{"href":"https://api.github.com/repos/silexphp/Silex/pulls/1091/comments"},"review_comment":{"href":"https://api.github.com/repos/silexphp/Silex/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/silexphp/Silex/pulls/1091/commits"},"statuses":{"href":"https://api.github.com/repos/silexphp/Silex/statuses/bfe00545e90eb4a5fdf7633796c3a5d22e1d5eb6"}}}}