{"action":"created","comment":{"url":"https://api.github.com/repos/broadinstitute/rawls/pulls/comments/36338405","id":36338405,"diff_hunk":"@@ -39,6 +39,11 @@ class GraphEntityDAO extends EntityDAO with GraphDAO {\n   }\n \n   private def createVertex(workspace: Vertex, workspaceNamespace: String, workspaceName: String, entity: Entity, txn: RawlsTransaction): Vertex = txn withGraph { db =>\n+    // check for illegal dot characters\n+    validateUserDefinedString(entity.entityType)\n+    validateUserDefinedString(entity.name)\n+    entity.attributes.keys.foreach(validateUserDefinedString)\n+","path":"src/main/scala/org/broadinstitute/dsde/rawls/dataaccess/GraphEntityDAO.scala","position":8,"original_position":8,"commit_id":"65a75d2a92fac431826f26ab139cde88d3e9d763","original_commit_id":"65a75d2a92fac431826f26ab139cde88d3e9d763","user":{"login":"mattsooknah","id":2549178,"avatar_url":"https://avatars.githubusercontent.com/u/2549178?v=3","gravatar_id":"","url":"https://api.github.com/users/mattsooknah","html_url":"https://github.com/mattsooknah","followers_url":"https://api.github.com/users/mattsooknah/followers","following_url":"https://api.github.com/users/mattsooknah/following{/other_user}","gists_url":"https://api.github.com/users/mattsooknah/gists{/gist_id}","starred_url":"https://api.github.com/users/mattsooknah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattsooknah/subscriptions","organizations_url":"https://api.github.com/users/mattsooknah/orgs","repos_url":"https://api.github.com/users/mattsooknah/repos","events_url":"https://api.github.com/users/mattsooknah/events{/privacy}","received_events_url":"https://api.github.com/users/mattsooknah/received_events","type":"User","site_admin":false},"body":"The code block is here because we create entities in two places - ```save``` and ```cloneTheseEntities```. You could argue that if the entities already exist in another workspace, they've already been validated, but that seems like a silly reason to not do it.\r\n\r\nWe validate ```entityType``` and ```name``` because the story says to. It seems reasonable, and it might save us sometime in the future. It limits users by a slight amount, but they're already forbidden from using dots in attribute keys, so we might as well discourage them from using dots at all.","created_at":"2015-08-05T18:42:34Z","updated_at":"2015-08-05T18:42:34Z","html_url":"https://github.com/broadinstitute/rawls/pull/69#discussion_r36338405","pull_request_url":"https://api.github.com/repos/broadinstitute/rawls/pulls/69","_links":{"self":{"href":"https://api.github.com/repos/broadinstitute/rawls/pulls/comments/36338405"},"html":{"href":"https://github.com/broadinstitute/rawls/pull/69#discussion_r36338405"},"pull_request":{"href":"https://api.github.com/repos/broadinstitute/rawls/pulls/69"}}},"pull_request":{"url":"https://api.github.com/repos/broadinstitute/rawls/pulls/69","id":41691201,"html_url":"https://github.com/broadinstitute/rawls/pull/69","diff_url":"https://github.com/broadinstitute/rawls/pull/69.diff","patch_url":"https://github.com/broadinstitute/rawls/pull/69.patch","issue_url":"https://api.github.com/repos/broadinstitute/rawls/issues/69","number":69,"state":"open","locked":false,"title":"Disallow dot in user defined strings","user":{"login":"mattsooknah","id":2549178,"avatar_url":"https://avatars.githubusercontent.com/u/2549178?v=3","gravatar_id":"","url":"https://api.github.com/users/mattsooknah","html_url":"https://github.com/mattsooknah","followers_url":"https://api.github.com/users/mattsooknah/followers","following_url":"https://api.github.com/users/mattsooknah/following{/other_user}","gists_url":"https://api.github.com/users/mattsooknah/gists{/gist_id}","starred_url":"https://api.github.com/users/mattsooknah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattsooknah/subscriptions","organizations_url":"https://api.github.com/users/mattsooknah/orgs","repos_url":"https://api.github.com/users/mattsooknah/repos","events_url":"https://api.github.com/users/mattsooknah/events{/privacy}","received_events_url":"https://api.github.com/users/mattsooknah/received_events","type":"User","site_admin":false},"body":"Also rename ```SubmissionDAOSpec``` -> ```GraphSubmissionDAOSpec``` , since that's what it is.","created_at":"2015-08-05T15:22:29Z","updated_at":"2015-08-05T18:42:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"67c84542dfd6e2c25055f99e89091325fa360322","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/broadinstitute/rawls/pulls/69/commits","review_comments_url":"https://api.github.com/repos/broadinstitute/rawls/pulls/69/comments","review_comment_url":"https://api.github.com/repos/broadinstitute/rawls/pulls/comments{/number}","comments_url":"https://api.github.com/repos/broadinstitute/rawls/issues/69/comments","statuses_url":"https://api.github.com/repos/broadinstitute/rawls/statuses/65a75d2a92fac431826f26ab139cde88d3e9d763","head":{"label":"broadinstitute:mds_disallow_dot","ref":"mds_disallow_dot","sha":"65a75d2a92fac431826f26ab139cde88d3e9d763","user":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars.githubusercontent.com/u/393552?v=3","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"repo":{"id":34129770,"name":"rawls","full_name":"broadinstitute/rawls","owner":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars.githubusercontent.com/u/393552?v=3","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/broadinstitute/rawls","description":"Rawls service for DSDE","fork":false,"url":"https://api.github.com/repos/broadinstitute/rawls","forks_url":"https://api.github.com/repos/broadinstitute/rawls/forks","keys_url":"https://api.github.com/repos/broadinstitute/rawls/keys{/key_id}","collaborators_url":"https://api.github.com/repos/broadinstitute/rawls/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/broadinstitute/rawls/teams","hooks_url":"https://api.github.com/repos/broadinstitute/rawls/hooks","issue_events_url":"https://api.github.com/repos/broadinstitute/rawls/issues/events{/number}","events_url":"https://api.github.com/repos/broadinstitute/rawls/events","assignees_url":"https://api.github.com/repos/broadinstitute/rawls/assignees{/user}","branches_url":"https://api.github.com/repos/broadinstitute/rawls/branches{/branch}","tags_url":"https://api.github.com/repos/broadinstitute/rawls/tags","blobs_url":"https://api.github.com/repos/broadinstitute/rawls/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/broadinstitute/rawls/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/broadinstitute/rawls/git/refs{/sha}","trees_url":"https://api.github.com/repos/broadinstitute/rawls/git/trees{/sha}","statuses_url":"https://api.github.com/repos/broadinstitute/rawls/statuses/{sha}","languages_url":"https://api.github.com/repos/broadinstitute/rawls/languages","stargazers_url":"https://api.github.com/repos/broadinstitute/rawls/stargazers","contributors_url":"https://api.github.com/repos/broadinstitute/rawls/contributors","subscribers_url":"https://api.github.com/repos/broadinstitute/rawls/subscribers","subscription_url":"https://api.github.com/repos/broadinstitute/rawls/subscription","commits_url":"https://api.github.com/repos/broadinstitute/rawls/commits{/sha}","git_commits_url":"https://api.github.com/repos/broadinstitute/rawls/git/commits{/sha}","comments_url":"https://api.github.com/repos/broadinstitute/rawls/comments{/number}","issue_comment_url":"https://api.github.com/repos/broadinstitute/rawls/issues/comments{/number}","contents_url":"https://api.github.com/repos/broadinstitute/rawls/contents/{+path}","compare_url":"https://api.github.com/repos/broadinstitute/rawls/compare/{base}...{head}","merges_url":"https://api.github.com/repos/broadinstitute/rawls/merges","archive_url":"https://api.github.com/repos/broadinstitute/rawls/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/broadinstitute/rawls/downloads","issues_url":"https://api.github.com/repos/broadinstitute/rawls/issues{/number}","pulls_url":"https://api.github.com/repos/broadinstitute/rawls/pulls{/number}","milestones_url":"https://api.github.com/repos/broadinstitute/rawls/milestones{/number}","notifications_url":"https://api.github.com/repos/broadinstitute/rawls/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/broadinstitute/rawls/labels{/name}","releases_url":"https://api.github.com/repos/broadinstitute/rawls/releases{/id}","created_at":"2015-04-17T17:16:07Z","updated_at":"2015-06-12T15:10:03Z","pushed_at":"2015-08-05T15:44:31Z","git_url":"git://github.com/broadinstitute/rawls.git","ssh_url":"git@github.com:broadinstitute/rawls.git","clone_url":"https://github.com/broadinstitute/rawls.git","svn_url":"https://github.com/broadinstitute/rawls","homepage":null,"size":2167,"stargazers_count":3,"watchers_count":3,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":3,"default_branch":"master"}},"base":{"label":"broadinstitute:master","ref":"master","sha":"f658990e9ac7562fc84e2b3a7af5500808e9cbf2","user":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars.githubusercontent.com/u/393552?v=3","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"repo":{"id":34129770,"name":"rawls","full_name":"broadinstitute/rawls","owner":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars.githubusercontent.com/u/393552?v=3","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/broadinstitute/rawls","description":"Rawls service for DSDE","fork":false,"url":"https://api.github.com/repos/broadinstitute/rawls","forks_url":"https://api.github.com/repos/broadinstitute/rawls/forks","keys_url":"https://api.github.com/repos/broadinstitute/rawls/keys{/key_id}","collaborators_url":"https://api.github.com/repos/broadinstitute/rawls/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/broadinstitute/rawls/teams","hooks_url":"https://api.github.com/repos/broadinstitute/rawls/hooks","issue_events_url":"https://api.github.com/repos/broadinstitute/rawls/issues/events{/number}","events_url":"https://api.github.com/repos/broadinstitute/rawls/events","assignees_url":"https://api.github.com/repos/broadinstitute/rawls/assignees{/user}","branches_url":"https://api.github.com/repos/broadinstitute/rawls/branches{/branch}","tags_url":"https://api.github.com/repos/broadinstitute/rawls/tags","blobs_url":"https://api.github.com/repos/broadinstitute/rawls/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/broadinstitute/rawls/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/broadinstitute/rawls/git/refs{/sha}","trees_url":"https://api.github.com/repos/broadinstitute/rawls/git/trees{/sha}","statuses_url":"https://api.github.com/repos/broadinstitute/rawls/statuses/{sha}","languages_url":"https://api.github.com/repos/broadinstitute/rawls/languages","stargazers_url":"https://api.github.com/repos/broadinstitute/rawls/stargazers","contributors_url":"https://api.github.com/repos/broadinstitute/rawls/contributors","subscribers_url":"https://api.github.com/repos/broadinstitute/rawls/subscribers","subscription_url":"https://api.github.com/repos/broadinstitute/rawls/subscription","commits_url":"https://api.github.com/repos/broadinstitute/rawls/commits{/sha}","git_commits_url":"https://api.github.com/repos/broadinstitute/rawls/git/commits{/sha}","comments_url":"https://api.github.com/repos/broadinstitute/rawls/comments{/number}","issue_comment_url":"https://api.github.com/repos/broadinstitute/rawls/issues/comments{/number}","contents_url":"https://api.github.com/repos/broadinstitute/rawls/contents/{+path}","compare_url":"https://api.github.com/repos/broadinstitute/rawls/compare/{base}...{head}","merges_url":"https://api.github.com/repos/broadinstitute/rawls/merges","archive_url":"https://api.github.com/repos/broadinstitute/rawls/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/broadinstitute/rawls/downloads","issues_url":"https://api.github.com/repos/broadinstitute/rawls/issues{/number}","pulls_url":"https://api.github.com/repos/broadinstitute/rawls/pulls{/number}","milestones_url":"https://api.github.com/repos/broadinstitute/rawls/milestones{/number}","notifications_url":"https://api.github.com/repos/broadinstitute/rawls/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/broadinstitute/rawls/labels{/name}","releases_url":"https://api.github.com/repos/broadinstitute/rawls/releases{/id}","created_at":"2015-04-17T17:16:07Z","updated_at":"2015-06-12T15:10:03Z","pushed_at":"2015-08-05T15:44:31Z","git_url":"git://github.com/broadinstitute/rawls.git","ssh_url":"git@github.com:broadinstitute/rawls.git","clone_url":"https://github.com/broadinstitute/rawls.git","svn_url":"https://github.com/broadinstitute/rawls","homepage":null,"size":2167,"stargazers_count":3,"watchers_count":3,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/broadinstitute/rawls/pulls/69"},"html":{"href":"https://github.com/broadinstitute/rawls/pull/69"},"issue":{"href":"https://api.github.com/repos/broadinstitute/rawls/issues/69"},"comments":{"href":"https://api.github.com/repos/broadinstitute/rawls/issues/69/comments"},"review_comments":{"href":"https://api.github.com/repos/broadinstitute/rawls/pulls/69/comments"},"review_comment":{"href":"https://api.github.com/repos/broadinstitute/rawls/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/broadinstitute/rawls/pulls/69/commits"},"statuses":{"href":"https://api.github.com/repos/broadinstitute/rawls/statuses/65a75d2a92fac431826f26ab139cde88d3e9d763"}}}}