{"action":"created","issue":{"url":"https://api.github.com/repos/praekelt/goddard-hub-server/issues/27","labels_url":"https://api.github.com/repos/praekelt/goddard-hub-server/issues/27/labels{/name}","comments_url":"https://api.github.com/repos/praekelt/goddard-hub-server/issues/27/comments","events_url":"https://api.github.com/repos/praekelt/goddard-hub-server/issues/27/events","html_url":"https://github.com/praekelt/goddard-hub-server/pull/27","id":91721417,"number":27,"title":"Added a downloads url that also handles login","user":{"login":"Johanndutoit","id":496448,"avatar_url":"https://avatars.githubusercontent.com/u/496448?v=3","gravatar_id":"","url":"https://api.github.com/users/Johanndutoit","html_url":"https://github.com/Johanndutoit","followers_url":"https://api.github.com/users/Johanndutoit/followers","following_url":"https://api.github.com/users/Johanndutoit/following{/other_user}","gists_url":"https://api.github.com/users/Johanndutoit/gists{/gist_id}","starred_url":"https://api.github.com/users/Johanndutoit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Johanndutoit/subscriptions","organizations_url":"https://api.github.com/users/Johanndutoit/orgs","repos_url":"https://api.github.com/users/Johanndutoit/repos","events_url":"https://api.github.com/users/Johanndutoit/events{/privacy}","received_events_url":"https://api.github.com/users/Johanndutoit/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-06-29T07:20:33Z","updated_at":"2015-07-23T18:09:50Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/praekelt/goddard-hub-server/pulls/27","html_url":"https://github.com/praekelt/goddard-hub-server/pull/27","diff_url":"https://github.com/praekelt/goddard-hub-server/pull/27.diff","patch_url":"https://github.com/praekelt/goddard-hub-server/pull/27.patch"},"body":"Allows you to download the builds through the web interface that first checks if you are logged in to then download the file. This is the url that users will be notified about when a build is built. Meant to pull this Friday, day got away from me.\r\n\r\nStayed away from a actual token as that would mean we'd have to add a token to each user and that you'll have to somehow send a link with the correct token for each user when sending the link for download. Keep track of tokens seems a bit counter productive.\r\n\r\nSo the flow here now consists of go to url -> login if not (redirected if not) -> pipe and download the file (pipping just allows local testing).\r\n\r\n@jonathanendersby @smn thoughts ?"},"comment":{"url":"https://api.github.com/repos/praekelt/goddard-hub-server/issues/comments/124190479","html_url":"https://github.com/praekelt/goddard-hub-server/pull/27#issuecomment-124190479","issue_url":"https://api.github.com/repos/praekelt/goddard-hub-server/issues/27","id":124190479,"user":{"login":"smn","id":1065,"avatar_url":"https://avatars.githubusercontent.com/u/1065?v=3","gravatar_id":"","url":"https://api.github.com/users/smn","html_url":"https://github.com/smn","followers_url":"https://api.github.com/users/smn/followers","following_url":"https://api.github.com/users/smn/following{/other_user}","gists_url":"https://api.github.com/users/smn/gists{/gist_id}","starred_url":"https://api.github.com/users/smn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smn/subscriptions","organizations_url":"https://api.github.com/users/smn/orgs","repos_url":"https://api.github.com/users/smn/repos","events_url":"https://api.github.com/users/smn/events{/privacy}","received_events_url":"https://api.github.com/users/smn/received_events","type":"User","site_admin":false},"created_at":"2015-07-23T18:09:50Z","updated_at":"2015-07-23T18:09:50Z","body":"On the coverage, please continue in the coverage branch on the test coverage work. If you want / need help on getting travis + automatic coverage checking setup then we're more than happy to help get it set up. I'm +1 on this landing (if you think this is complete) and start a new PR for the webhooks & possible auth changes that would be needed."}}