{"action":"created","comment":{"url":"https://api.github.com/repos/aetrion/pdns/pulls/comments/23795883","id":23795883,"diff_hunk":"@@ -1,4 +1,4 @@\n-<% node['pdns']['authoritative']['config'].sort.each do |key, value| %>\n+<% node['pdns'][ @node['pdns']['flavor'] ]['config'].sort.each do |key, value| %>","path":"templates/default/pdns.conf.erb","position":2,"original_position":2,"commit_id":"753124b82a5ba42a7ddcf44963e926e0caf1eaef","original_commit_id":"753124b82a5ba42a7ddcf44963e926e0caf1eaef","user":{"login":"martinisoft","id":724,"avatar_url":"https://avatars.githubusercontent.com/u/724?v=3","gravatar_id":"","url":"https://api.github.com/users/martinisoft","html_url":"https://github.com/martinisoft","followers_url":"https://api.github.com/users/martinisoft/followers","following_url":"https://api.github.com/users/martinisoft/following{/other_user}","gists_url":"https://api.github.com/users/martinisoft/gists{/gist_id}","starred_url":"https://api.github.com/users/martinisoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinisoft/subscriptions","organizations_url":"https://api.github.com/users/martinisoft/orgs","repos_url":"https://api.github.com/users/martinisoft/repos","events_url":"https://api.github.com/users/martinisoft/events{/privacy}","received_events_url":"https://api.github.com/users/martinisoft/received_events","type":"User","site_admin":false},"body":"Why the additional spacing for these brackets?","created_at":"2015-01-29T19:36:36Z","updated_at":"2015-01-29T19:36:36Z","html_url":"https://github.com/aetrion/pdns/pull/25#discussion_r23795883","pull_request_url":"https://api.github.com/repos/aetrion/pdns/pulls/25","_links":{"self":{"href":"https://api.github.com/repos/aetrion/pdns/pulls/comments/23795883"},"html":{"href":"https://github.com/aetrion/pdns/pull/25#discussion_r23795883"},"pull_request":{"href":"https://api.github.com/repos/aetrion/pdns/pulls/25"}}},"pull_request":{"url":"https://api.github.com/repos/aetrion/pdns/pulls/25","id":28298623,"html_url":"https://github.com/aetrion/pdns/pull/25","diff_url":"https://github.com/aetrion/pdns/pull/25.diff","patch_url":"https://github.com/aetrion/pdns/pull/25.patch","issue_url":"https://api.github.com/repos/aetrion/pdns/issues/25","number":25,"state":"open","locked":false,"title":"Code refactor and added functionalities","user":{"login":"therobot","id":16634,"avatar_url":"https://avatars.githubusercontent.com/u/16634?v=3","gravatar_id":"","url":"https://api.github.com/users/therobot","html_url":"https://github.com/therobot","followers_url":"https://api.github.com/users/therobot/followers","following_url":"https://api.github.com/users/therobot/following{/other_user}","gists_url":"https://api.github.com/users/therobot/gists{/gist_id}","starred_url":"https://api.github.com/users/therobot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/therobot/subscriptions","organizations_url":"https://api.github.com/users/therobot/orgs","repos_url":"https://api.github.com/users/therobot/repos","events_url":"https://api.github.com/users/therobot/events{/privacy}","received_events_url":"https://api.github.com/users/therobot/received_events","type":"User","site_admin":false},"body":"This PR aims to add a new functionality to the cookbook: deploying slave servers, since there is a lot of shared code between all of the different \"flavors\" of PowerDNS installations I've been trying to accommodate them in the code so it is more modular, less redundant, etc.\r\n\r\nI'm opening this PR in order to discuss certain implementation details such us\r\n\r\n- Improving naming schema: flavor + install_method or the opossite?.\r\n- Breaking changes in recursor recipe.\r\n- Coding aspects, elegant ways to deal the backend attributes that are disseminated in 4 attribute files.\r\n- Additional refactoring: add DRYness on the main recipes.\r\n- Sane defaults: install a recursor by default instead?.\r\n\r\n","created_at":"2015-01-29T17:37:05Z","updated_at":"2015-01-29T19:36:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"88809e0fd3b8c9c56ac6ca631597664a1ae04784","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/aetrion/pdns/pulls/25/commits","review_comments_url":"https://api.github.com/repos/aetrion/pdns/pulls/25/comments","review_comment_url":"https://api.github.com/repos/aetrion/pdns/pulls/comments/{number}","comments_url":"https://api.github.com/repos/aetrion/pdns/issues/25/comments","statuses_url":"https://api.github.com/repos/aetrion/pdns/statuses/753124b82a5ba42a7ddcf44963e926e0caf1eaef","head":{"label":"aetrion:feature/pdns-slave-server","ref":"feature/pdns-slave-server","sha":"753124b82a5ba42a7ddcf44963e926e0caf1eaef","user":{"login":"aetrion","id":323774,"avatar_url":"https://avatars.githubusercontent.com/u/323774?v=3","gravatar_id":"","url":"https://api.github.com/users/aetrion","html_url":"https://github.com/aetrion","followers_url":"https://api.github.com/users/aetrion/followers","following_url":"https://api.github.com/users/aetrion/following{/other_user}","gists_url":"https://api.github.com/users/aetrion/gists{/gist_id}","starred_url":"https://api.github.com/users/aetrion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aetrion/subscriptions","organizations_url":"https://api.github.com/users/aetrion/orgs","repos_url":"https://api.github.com/users/aetrion/repos","events_url":"https://api.github.com/users/aetrion/events{/privacy}","received_events_url":"https://api.github.com/users/aetrion/received_events","type":"Organization","site_admin":false},"repo":{"id":3720889,"name":"pdns","full_name":"aetrion/pdns","owner":{"login":"aetrion","id":323774,"avatar_url":"https://avatars.githubusercontent.com/u/323774?v=3","gravatar_id":"","url":"https://api.github.com/users/aetrion","html_url":"https://github.com/aetrion","followers_url":"https://api.github.com/users/aetrion/followers","following_url":"https://api.github.com/users/aetrion/following{/other_user}","gists_url":"https://api.github.com/users/aetrion/gists{/gist_id}","starred_url":"https://api.github.com/users/aetrion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aetrion/subscriptions","organizations_url":"https://api.github.com/users/aetrion/orgs","repos_url":"https://api.github.com/users/aetrion/repos","events_url":"https://api.github.com/users/aetrion/events{/privacy}","received_events_url":"https://api.github.com/users/aetrion/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aetrion/pdns","description":"Development repository for DNSimple Cookbook pdns","fork":false,"url":"https://api.github.com/repos/aetrion/pdns","forks_url":"https://api.github.com/repos/aetrion/pdns/forks","keys_url":"https://api.github.com/repos/aetrion/pdns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aetrion/pdns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aetrion/pdns/teams","hooks_url":"https://api.github.com/repos/aetrion/pdns/hooks","issue_events_url":"https://api.github.com/repos/aetrion/pdns/issues/events{/number}","events_url":"https://api.github.com/repos/aetrion/pdns/events","assignees_url":"https://api.github.com/repos/aetrion/pdns/assignees{/user}","branches_url":"https://api.github.com/repos/aetrion/pdns/branches{/branch}","tags_url":"https://api.github.com/repos/aetrion/pdns/tags","blobs_url":"https://api.github.com/repos/aetrion/pdns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aetrion/pdns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aetrion/pdns/git/refs{/sha}","trees_url":"https://api.github.com/repos/aetrion/pdns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aetrion/pdns/statuses/{sha}","languages_url":"https://api.github.com/repos/aetrion/pdns/languages","stargazers_url":"https://api.github.com/repos/aetrion/pdns/stargazers","contributors_url":"https://api.github.com/repos/aetrion/pdns/contributors","subscribers_url":"https://api.github.com/repos/aetrion/pdns/subscribers","subscription_url":"https://api.github.com/repos/aetrion/pdns/subscription","commits_url":"https://api.github.com/repos/aetrion/pdns/commits{/sha}","git_commits_url":"https://api.github.com/repos/aetrion/pdns/git/commits{/sha}","comments_url":"https://api.github.com/repos/aetrion/pdns/comments{/number}","issue_comment_url":"https://api.github.com/repos/aetrion/pdns/issues/comments/{number}","contents_url":"https://api.github.com/repos/aetrion/pdns/contents/{+path}","compare_url":"https://api.github.com/repos/aetrion/pdns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aetrion/pdns/merges","archive_url":"https://api.github.com/repos/aetrion/pdns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aetrion/pdns/downloads","issues_url":"https://api.github.com/repos/aetrion/pdns/issues{/number}","pulls_url":"https://api.github.com/repos/aetrion/pdns/pulls{/number}","milestones_url":"https://api.github.com/repos/aetrion/pdns/milestones{/number}","notifications_url":"https://api.github.com/repos/aetrion/pdns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aetrion/pdns/labels{/name}","releases_url":"https://api.github.com/repos/aetrion/pdns/releases{/id}","created_at":"2012-03-14T18:36:38Z","updated_at":"2014-12-31T08:20:29Z","pushed_at":"2015-01-29T16:53:02Z","git_url":"git://github.com/aetrion/pdns.git","ssh_url":"git@github.com:aetrion/pdns.git","clone_url":"https://github.com/aetrion/pdns.git","svn_url":"https://github.com/aetrion/pdns","homepage":"https://supermarket.chef.io/cookbooks/pdns","size":627,"stargazers_count":12,"watchers_count":12,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":31,"mirror_url":null,"open_issues_count":12,"forks":31,"open_issues":12,"watchers":12,"default_branch":"master"}},"base":{"label":"aetrion:master","ref":"master","sha":"5fcdf4ab2a9b9859e94f046257d32b1c372fcaa3","user":{"login":"aetrion","id":323774,"avatar_url":"https://avatars.githubusercontent.com/u/323774?v=3","gravatar_id":"","url":"https://api.github.com/users/aetrion","html_url":"https://github.com/aetrion","followers_url":"https://api.github.com/users/aetrion/followers","following_url":"https://api.github.com/users/aetrion/following{/other_user}","gists_url":"https://api.github.com/users/aetrion/gists{/gist_id}","starred_url":"https://api.github.com/users/aetrion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aetrion/subscriptions","organizations_url":"https://api.github.com/users/aetrion/orgs","repos_url":"https://api.github.com/users/aetrion/repos","events_url":"https://api.github.com/users/aetrion/events{/privacy}","received_events_url":"https://api.github.com/users/aetrion/received_events","type":"Organization","site_admin":false},"repo":{"id":3720889,"name":"pdns","full_name":"aetrion/pdns","owner":{"login":"aetrion","id":323774,"avatar_url":"https://avatars.githubusercontent.com/u/323774?v=3","gravatar_id":"","url":"https://api.github.com/users/aetrion","html_url":"https://github.com/aetrion","followers_url":"https://api.github.com/users/aetrion/followers","following_url":"https://api.github.com/users/aetrion/following{/other_user}","gists_url":"https://api.github.com/users/aetrion/gists{/gist_id}","starred_url":"https://api.github.com/users/aetrion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aetrion/subscriptions","organizations_url":"https://api.github.com/users/aetrion/orgs","repos_url":"https://api.github.com/users/aetrion/repos","events_url":"https://api.github.com/users/aetrion/events{/privacy}","received_events_url":"https://api.github.com/users/aetrion/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aetrion/pdns","description":"Development repository for DNSimple Cookbook pdns","fork":false,"url":"https://api.github.com/repos/aetrion/pdns","forks_url":"https://api.github.com/repos/aetrion/pdns/forks","keys_url":"https://api.github.com/repos/aetrion/pdns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aetrion/pdns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aetrion/pdns/teams","hooks_url":"https://api.github.com/repos/aetrion/pdns/hooks","issue_events_url":"https://api.github.com/repos/aetrion/pdns/issues/events{/number}","events_url":"https://api.github.com/repos/aetrion/pdns/events","assignees_url":"https://api.github.com/repos/aetrion/pdns/assignees{/user}","branches_url":"https://api.github.com/repos/aetrion/pdns/branches{/branch}","tags_url":"https://api.github.com/repos/aetrion/pdns/tags","blobs_url":"https://api.github.com/repos/aetrion/pdns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aetrion/pdns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aetrion/pdns/git/refs{/sha}","trees_url":"https://api.github.com/repos/aetrion/pdns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aetrion/pdns/statuses/{sha}","languages_url":"https://api.github.com/repos/aetrion/pdns/languages","stargazers_url":"https://api.github.com/repos/aetrion/pdns/stargazers","contributors_url":"https://api.github.com/repos/aetrion/pdns/contributors","subscribers_url":"https://api.github.com/repos/aetrion/pdns/subscribers","subscription_url":"https://api.github.com/repos/aetrion/pdns/subscription","commits_url":"https://api.github.com/repos/aetrion/pdns/commits{/sha}","git_commits_url":"https://api.github.com/repos/aetrion/pdns/git/commits{/sha}","comments_url":"https://api.github.com/repos/aetrion/pdns/comments{/number}","issue_comment_url":"https://api.github.com/repos/aetrion/pdns/issues/comments/{number}","contents_url":"https://api.github.com/repos/aetrion/pdns/contents/{+path}","compare_url":"https://api.github.com/repos/aetrion/pdns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aetrion/pdns/merges","archive_url":"https://api.github.com/repos/aetrion/pdns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aetrion/pdns/downloads","issues_url":"https://api.github.com/repos/aetrion/pdns/issues{/number}","pulls_url":"https://api.github.com/repos/aetrion/pdns/pulls{/number}","milestones_url":"https://api.github.com/repos/aetrion/pdns/milestones{/number}","notifications_url":"https://api.github.com/repos/aetrion/pdns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aetrion/pdns/labels{/name}","releases_url":"https://api.github.com/repos/aetrion/pdns/releases{/id}","created_at":"2012-03-14T18:36:38Z","updated_at":"2014-12-31T08:20:29Z","pushed_at":"2015-01-29T16:53:02Z","git_url":"git://github.com/aetrion/pdns.git","ssh_url":"git@github.com:aetrion/pdns.git","clone_url":"https://github.com/aetrion/pdns.git","svn_url":"https://github.com/aetrion/pdns","homepage":"https://supermarket.chef.io/cookbooks/pdns","size":627,"stargazers_count":12,"watchers_count":12,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":31,"mirror_url":null,"open_issues_count":12,"forks":31,"open_issues":12,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aetrion/pdns/pulls/25"},"html":{"href":"https://github.com/aetrion/pdns/pull/25"},"issue":{"href":"https://api.github.com/repos/aetrion/pdns/issues/25"},"comments":{"href":"https://api.github.com/repos/aetrion/pdns/issues/25/comments"},"review_comments":{"href":"https://api.github.com/repos/aetrion/pdns/pulls/25/comments"},"review_comment":{"href":"https://api.github.com/repos/aetrion/pdns/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/aetrion/pdns/pulls/25/commits"},"statuses":{"href":"https://api.github.com/repos/aetrion/pdns/statuses/753124b82a5ba42a7ddcf44963e926e0caf1eaef"}}}}