{"action":"created","comment":{"url":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls/comments/40255205","id":40255205,"diff_hunk":"@@ -402,6 +402,10 @@ def data(readonly=False):\n              \"Whether to shrink the completion to be smaller than the \"\n              \"configured size if there are no scrollbars.\"),\n \n+            ('match-type',\n+             SettingValue(typ.String(none_ok=True), 'contain'),","path":"qutebrowser/config/configdata.py","position":5,"original_position":5,"commit_id":"8c3f45af4f638fe2becf848d5c779d213b905c3e","original_commit_id":"8c3f45af4f638fe2becf848d5c779d213b905c3e","user":{"login":"The-Compiler","id":625793,"avatar_url":"https://avatars.githubusercontent.com/u/625793?v=3","gravatar_id":"","url":"https://api.github.com/users/The-Compiler","html_url":"https://github.com/The-Compiler","followers_url":"https://api.github.com/users/The-Compiler/followers","following_url":"https://api.github.com/users/The-Compiler/following{/other_user}","gists_url":"https://api.github.com/users/The-Compiler/gists{/gist_id}","starred_url":"https://api.github.com/users/The-Compiler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/The-Compiler/subscriptions","organizations_url":"https://api.github.com/users/The-Compiler/orgs","repos_url":"https://api.github.com/users/The-Compiler/repos","events_url":"https://api.github.com/users/The-Compiler/events{/privacy}","received_events_url":"https://api.github.com/users/The-Compiler/received_events","type":"User","site_admin":false},"body":"Ah, now I see why you checked for invalid values earlier - this should be its own config type which validates and documents the possible values.\r\n\r\nAdd something like this at the bottom of `config/configtypes.py`:\r\n\r\n```python\r\nclass MatchType(BaseType):\r\n\r\n    \"\"\"How to match values in the completion.\"\"\"\r\n\r\n    valid_values = ValidValues(('contain', \"Match items which contain the \"\r\n                                           \"entered text.\"),\r\n                               ('fuzzy', \"Match items with a fuzzy matching \"\r\n                                         \"logic.\"),\r\n                               ('start', \"Only match items starting with the \"\r\n                                         \"entered text.\"),\r\n```\r\n\r\nAnd then use `typ.MatchType()`.\r\n","created_at":"2015-09-23T20:44:18Z","updated_at":"2015-09-23T20:44:18Z","html_url":"https://github.com/The-Compiler/qutebrowser/pull/950#discussion_r40255205","pull_request_url":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls/950","_links":{"self":{"href":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls/comments/40255205"},"html":{"href":"https://github.com/The-Compiler/qutebrowser/pull/950#discussion_r40255205"},"pull_request":{"href":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls/950"}}},"pull_request":{"url":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls/950","id":45171236,"html_url":"https://github.com/The-Compiler/qutebrowser/pull/950","diff_url":"https://github.com/The-Compiler/qutebrowser/pull/950.diff","patch_url":"https://github.com/The-Compiler/qutebrowser/pull/950.patch","issue_url":"https://api.github.com/repos/The-Compiler/qutebrowser/issues/950","number":950,"state":"open","locked":false,"title":"add fuzzy search to autocompletion","user":{"login":"averrin","id":426007,"avatar_url":"https://avatars.githubusercontent.com/u/426007?v=3","gravatar_id":"","url":"https://api.github.com/users/averrin","html_url":"https://github.com/averrin","followers_url":"https://api.github.com/users/averrin/followers","following_url":"https://api.github.com/users/averrin/following{/other_user}","gists_url":"https://api.github.com/users/averrin/gists{/gist_id}","starred_url":"https://api.github.com/users/averrin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/averrin/subscriptions","organizations_url":"https://api.github.com/users/averrin/orgs","repos_url":"https://api.github.com/users/averrin/repos","events_url":"https://api.github.com/users/averrin/events{/privacy}","received_events_url":"https://api.github.com/users/averrin/received_events","type":"User","site_admin":false},"body":"But it has no letter highlights","created_at":"2015-09-16T13:30:50Z","updated_at":"2015-09-23T20:44:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"598241e2d406f6fc1519d3fac0cdabeb6374dcf1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls/950/commits","review_comments_url":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls/950/comments","review_comment_url":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls/comments{/number}","comments_url":"https://api.github.com/repos/The-Compiler/qutebrowser/issues/950/comments","statuses_url":"https://api.github.com/repos/The-Compiler/qutebrowser/statuses/8c3f45af4f638fe2becf848d5c779d213b905c3e","head":{"label":"averrin:fuzzy","ref":"fuzzy","sha":"8c3f45af4f638fe2becf848d5c779d213b905c3e","user":{"login":"averrin","id":426007,"avatar_url":"https://avatars.githubusercontent.com/u/426007?v=3","gravatar_id":"","url":"https://api.github.com/users/averrin","html_url":"https://github.com/averrin","followers_url":"https://api.github.com/users/averrin/followers","following_url":"https://api.github.com/users/averrin/following{/other_user}","gists_url":"https://api.github.com/users/averrin/gists{/gist_id}","starred_url":"https://api.github.com/users/averrin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/averrin/subscriptions","organizations_url":"https://api.github.com/users/averrin/orgs","repos_url":"https://api.github.com/users/averrin/repos","events_url":"https://api.github.com/users/averrin/events{/privacy}","received_events_url":"https://api.github.com/users/averrin/received_events","type":"User","site_admin":false},"repo":{"id":42314584,"name":"qutebrowser","full_name":"averrin/qutebrowser","owner":{"login":"averrin","id":426007,"avatar_url":"https://avatars.githubusercontent.com/u/426007?v=3","gravatar_id":"","url":"https://api.github.com/users/averrin","html_url":"https://github.com/averrin","followers_url":"https://api.github.com/users/averrin/followers","following_url":"https://api.github.com/users/averrin/following{/other_user}","gists_url":"https://api.github.com/users/averrin/gists{/gist_id}","starred_url":"https://api.github.com/users/averrin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/averrin/subscriptions","organizations_url":"https://api.github.com/users/averrin/orgs","repos_url":"https://api.github.com/users/averrin/repos","events_url":"https://api.github.com/users/averrin/events{/privacy}","received_events_url":"https://api.github.com/users/averrin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/averrin/qutebrowser","description":"A keyboard-driven, vim-like browser based on PyQt5 and QtWebKit.","fork":true,"url":"https://api.github.com/repos/averrin/qutebrowser","forks_url":"https://api.github.com/repos/averrin/qutebrowser/forks","keys_url":"https://api.github.com/repos/averrin/qutebrowser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/averrin/qutebrowser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/averrin/qutebrowser/teams","hooks_url":"https://api.github.com/repos/averrin/qutebrowser/hooks","issue_events_url":"https://api.github.com/repos/averrin/qutebrowser/issues/events{/number}","events_url":"https://api.github.com/repos/averrin/qutebrowser/events","assignees_url":"https://api.github.com/repos/averrin/qutebrowser/assignees{/user}","branches_url":"https://api.github.com/repos/averrin/qutebrowser/branches{/branch}","tags_url":"https://api.github.com/repos/averrin/qutebrowser/tags","blobs_url":"https://api.github.com/repos/averrin/qutebrowser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/averrin/qutebrowser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/averrin/qutebrowser/git/refs{/sha}","trees_url":"https://api.github.com/repos/averrin/qutebrowser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/averrin/qutebrowser/statuses/{sha}","languages_url":"https://api.github.com/repos/averrin/qutebrowser/languages","stargazers_url":"https://api.github.com/repos/averrin/qutebrowser/stargazers","contributors_url":"https://api.github.com/repos/averrin/qutebrowser/contributors","subscribers_url":"https://api.github.com/repos/averrin/qutebrowser/subscribers","subscription_url":"https://api.github.com/repos/averrin/qutebrowser/subscription","commits_url":"https://api.github.com/repos/averrin/qutebrowser/commits{/sha}","git_commits_url":"https://api.github.com/repos/averrin/qutebrowser/git/commits{/sha}","comments_url":"https://api.github.com/repos/averrin/qutebrowser/comments{/number}","issue_comment_url":"https://api.github.com/repos/averrin/qutebrowser/issues/comments{/number}","contents_url":"https://api.github.com/repos/averrin/qutebrowser/contents/{+path}","compare_url":"https://api.github.com/repos/averrin/qutebrowser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/averrin/qutebrowser/merges","archive_url":"https://api.github.com/repos/averrin/qutebrowser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/averrin/qutebrowser/downloads","issues_url":"https://api.github.com/repos/averrin/qutebrowser/issues{/number}","pulls_url":"https://api.github.com/repos/averrin/qutebrowser/pulls{/number}","milestones_url":"https://api.github.com/repos/averrin/qutebrowser/milestones{/number}","notifications_url":"https://api.github.com/repos/averrin/qutebrowser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/averrin/qutebrowser/labels{/name}","releases_url":"https://api.github.com/repos/averrin/qutebrowser/releases{/id}","created_at":"2015-09-11T14:53:53Z","updated_at":"2015-09-11T14:53:54Z","pushed_at":"2015-09-22T12:59:05Z","git_url":"git://github.com/averrin/qutebrowser.git","ssh_url":"git@github.com:averrin/qutebrowser.git","clone_url":"https://github.com/averrin/qutebrowser.git","svn_url":"https://github.com/averrin/qutebrowser","homepage":null,"size":8102,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"The-Compiler:master","ref":"master","sha":"0fa9da56bf1ef1bda0634f15c0745e54786106a0","user":{"login":"The-Compiler","id":625793,"avatar_url":"https://avatars.githubusercontent.com/u/625793?v=3","gravatar_id":"","url":"https://api.github.com/users/The-Compiler","html_url":"https://github.com/The-Compiler","followers_url":"https://api.github.com/users/The-Compiler/followers","following_url":"https://api.github.com/users/The-Compiler/following{/other_user}","gists_url":"https://api.github.com/users/The-Compiler/gists{/gist_id}","starred_url":"https://api.github.com/users/The-Compiler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/The-Compiler/subscriptions","organizations_url":"https://api.github.com/users/The-Compiler/orgs","repos_url":"https://api.github.com/users/The-Compiler/repos","events_url":"https://api.github.com/users/The-Compiler/events{/privacy}","received_events_url":"https://api.github.com/users/The-Compiler/received_events","type":"User","site_admin":false},"repo":{"id":21244505,"name":"qutebrowser","full_name":"The-Compiler/qutebrowser","owner":{"login":"The-Compiler","id":625793,"avatar_url":"https://avatars.githubusercontent.com/u/625793?v=3","gravatar_id":"","url":"https://api.github.com/users/The-Compiler","html_url":"https://github.com/The-Compiler","followers_url":"https://api.github.com/users/The-Compiler/followers","following_url":"https://api.github.com/users/The-Compiler/following{/other_user}","gists_url":"https://api.github.com/users/The-Compiler/gists{/gist_id}","starred_url":"https://api.github.com/users/The-Compiler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/The-Compiler/subscriptions","organizations_url":"https://api.github.com/users/The-Compiler/orgs","repos_url":"https://api.github.com/users/The-Compiler/repos","events_url":"https://api.github.com/users/The-Compiler/events{/privacy}","received_events_url":"https://api.github.com/users/The-Compiler/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/The-Compiler/qutebrowser","description":"A keyboard-driven, vim-like browser based on PyQt5 and QtWebKit.","fork":false,"url":"https://api.github.com/repos/The-Compiler/qutebrowser","forks_url":"https://api.github.com/repos/The-Compiler/qutebrowser/forks","keys_url":"https://api.github.com/repos/The-Compiler/qutebrowser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/The-Compiler/qutebrowser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/The-Compiler/qutebrowser/teams","hooks_url":"https://api.github.com/repos/The-Compiler/qutebrowser/hooks","issue_events_url":"https://api.github.com/repos/The-Compiler/qutebrowser/issues/events{/number}","events_url":"https://api.github.com/repos/The-Compiler/qutebrowser/events","assignees_url":"https://api.github.com/repos/The-Compiler/qutebrowser/assignees{/user}","branches_url":"https://api.github.com/repos/The-Compiler/qutebrowser/branches{/branch}","tags_url":"https://api.github.com/repos/The-Compiler/qutebrowser/tags","blobs_url":"https://api.github.com/repos/The-Compiler/qutebrowser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/The-Compiler/qutebrowser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/The-Compiler/qutebrowser/git/refs{/sha}","trees_url":"https://api.github.com/repos/The-Compiler/qutebrowser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/The-Compiler/qutebrowser/statuses/{sha}","languages_url":"https://api.github.com/repos/The-Compiler/qutebrowser/languages","stargazers_url":"https://api.github.com/repos/The-Compiler/qutebrowser/stargazers","contributors_url":"https://api.github.com/repos/The-Compiler/qutebrowser/contributors","subscribers_url":"https://api.github.com/repos/The-Compiler/qutebrowser/subscribers","subscription_url":"https://api.github.com/repos/The-Compiler/qutebrowser/subscription","commits_url":"https://api.github.com/repos/The-Compiler/qutebrowser/commits{/sha}","git_commits_url":"https://api.github.com/repos/The-Compiler/qutebrowser/git/commits{/sha}","comments_url":"https://api.github.com/repos/The-Compiler/qutebrowser/comments{/number}","issue_comment_url":"https://api.github.com/repos/The-Compiler/qutebrowser/issues/comments{/number}","contents_url":"https://api.github.com/repos/The-Compiler/qutebrowser/contents/{+path}","compare_url":"https://api.github.com/repos/The-Compiler/qutebrowser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/The-Compiler/qutebrowser/merges","archive_url":"https://api.github.com/repos/The-Compiler/qutebrowser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/The-Compiler/qutebrowser/downloads","issues_url":"https://api.github.com/repos/The-Compiler/qutebrowser/issues{/number}","pulls_url":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls{/number}","milestones_url":"https://api.github.com/repos/The-Compiler/qutebrowser/milestones{/number}","notifications_url":"https://api.github.com/repos/The-Compiler/qutebrowser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/The-Compiler/qutebrowser/labels{/name}","releases_url":"https://api.github.com/repos/The-Compiler/qutebrowser/releases{/id}","created_at":"2014-06-26T14:59:34Z","updated_at":"2015-09-22T12:23:33Z","pushed_at":"2015-09-23T17:10:09Z","git_url":"git://github.com/The-Compiler/qutebrowser.git","ssh_url":"git@github.com:The-Compiler/qutebrowser.git","clone_url":"https://github.com/The-Compiler/qutebrowser.git","svn_url":"https://github.com/The-Compiler/qutebrowser","homepage":null,"size":13655,"stargazers_count":716,"watchers_count":716,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":92,"mirror_url":null,"open_issues_count":314,"forks":92,"open_issues":314,"watchers":716,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls/950"},"html":{"href":"https://github.com/The-Compiler/qutebrowser/pull/950"},"issue":{"href":"https://api.github.com/repos/The-Compiler/qutebrowser/issues/950"},"comments":{"href":"https://api.github.com/repos/The-Compiler/qutebrowser/issues/950/comments"},"review_comments":{"href":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls/950/comments"},"review_comment":{"href":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls/950/commits"},"statuses":{"href":"https://api.github.com/repos/The-Compiler/qutebrowser/statuses/8c3f45af4f638fe2becf848d5c779d213b905c3e"}}}}