{"action":"created","comment":{"url":"https://api.github.com/repos/official-stockfish/Stockfish/pulls/comments/24243577","id":24243577,"diff_hunk":"@@ -207,7 +194,7 @@ Entry* probe(const Position& pos) {\n \n   // Zero or just one pawn makes it difficult to win, even with a small material\n   // advantage. This catches some trivial draws like KK, KBK and KNK and gives a\n-  // drawish scale factor for cases such as KRKBP and KmmKm (except for KBBKN).","path":"src/material.cpp","position":124,"original_position":124,"commit_id":"ca016fe9fc483b5bc46cd70b7f880c657a4614eb","original_commit_id":"ca016fe9fc483b5bc46cd70b7f880c657a4614eb","user":{"login":"ceebo","id":5588286,"avatar_url":"https://avatars.githubusercontent.com/u/5588286?v=3","gravatar_id":"","url":"https://api.github.com/users/ceebo","html_url":"https://github.com/ceebo","followers_url":"https://api.github.com/users/ceebo/followers","following_url":"https://api.github.com/users/ceebo/following{/other_user}","gists_url":"https://api.github.com/users/ceebo/gists{/gist_id}","starred_url":"https://api.github.com/users/ceebo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceebo/subscriptions","organizations_url":"https://api.github.com/users/ceebo/orgs","repos_url":"https://api.github.com/users/ceebo/repos","events_url":"https://api.github.com/users/ceebo/events{/privacy}","received_events_url":"https://api.github.com/users/ceebo/received_events","type":"User","site_admin":false},"body":"I don't see a problem with this comment. The code gives drawish scale factors to the cases KBBKB, KBNKB, KNNKB, KBNKN, KNNKN but not KBBKN.\r\n\r\nLater, if you do end up removing the special endgame functions for KRKB and KRKN then it would make sense to replace the comment about KRKBP with the simpler KRKm.","created_at":"2015-02-06T14:37:30Z","updated_at":"2015-02-06T14:37:30Z","html_url":"https://github.com/official-stockfish/Stockfish/pull/245#discussion_r24243577","pull_request_url":"https://api.github.com/repos/official-stockfish/Stockfish/pulls/245","_links":{"self":{"href":"https://api.github.com/repos/official-stockfish/Stockfish/pulls/comments/24243577"},"html":{"href":"https://github.com/official-stockfish/Stockfish/pull/245#discussion_r24243577"},"pull_request":{"href":"https://api.github.com/repos/official-stockfish/Stockfish/pulls/245"}}},"pull_request":{"url":"https://api.github.com/repos/official-stockfish/Stockfish/pulls/245","id":28781188,"html_url":"https://github.com/official-stockfish/Stockfish/pull/245","diff_url":"https://github.com/official-stockfish/Stockfish/pull/245.diff","patch_url":"https://github.com/official-stockfish/Stockfish/pull/245.patch","issue_url":"https://api.github.com/repos/official-stockfish/Stockfish/issues/245","number":245,"state":"open","locked":false,"title":"Detempletize Material","user":{"login":"lucasart","id":2278294,"avatar_url":"https://avatars.githubusercontent.com/u/2278294?v=3","gravatar_id":"","url":"https://api.github.com/users/lucasart","html_url":"https://github.com/lucasart","followers_url":"https://api.github.com/users/lucasart/followers","following_url":"https://api.github.com/users/lucasart/following{/other_user}","gists_url":"https://api.github.com/users/lucasart/gists{/gist_id}","starred_url":"https://api.github.com/users/lucasart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucasart/subscriptions","organizations_url":"https://api.github.com/users/lucasart/orgs","repos_url":"https://api.github.com/users/lucasart/repos","events_url":"https://api.github.com/users/lucasart/events{/privacy}","received_events_url":"https://api.github.com/users/lucasart/received_events","type":"User","site_admin":false},"body":"Removes useless templates, some of which lead to code duplication (`is_K*()`).\r\n\r\nThis is even a **speedup** on my machine (i7-3770k, lunix, gcc 4.9.1):\r\n\r\n    stat        test     master    diff\r\n    mean   2,360,796  2,348,259  12,537\r\n    stdev      9,692      9,194   3,576\r\n\r\n    speedup        0.53%\r\n    P(speedup>0)  100.0%\r\n\r\nNo functional change.","created_at":"2015-02-06T02:43:33Z","updated_at":"2015-02-06T14:37:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"55f6001532ed585de886b0adace9113260006e73","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/official-stockfish/Stockfish/pulls/245/commits","review_comments_url":"https://api.github.com/repos/official-stockfish/Stockfish/pulls/245/comments","review_comment_url":"https://api.github.com/repos/official-stockfish/Stockfish/pulls/comments/{number}","comments_url":"https://api.github.com/repos/official-stockfish/Stockfish/issues/245/comments","statuses_url":"https://api.github.com/repos/official-stockfish/Stockfish/statuses/ca016fe9fc483b5bc46cd70b7f880c657a4614eb","head":{"label":"lucasart:detempletize","ref":"detempletize","sha":"ca016fe9fc483b5bc46cd70b7f880c657a4614eb","user":{"login":"lucasart","id":2278294,"avatar_url":"https://avatars.githubusercontent.com/u/2278294?v=3","gravatar_id":"","url":"https://api.github.com/users/lucasart","html_url":"https://github.com/lucasart","followers_url":"https://api.github.com/users/lucasart/followers","following_url":"https://api.github.com/users/lucasart/following{/other_user}","gists_url":"https://api.github.com/users/lucasart/gists{/gist_id}","starred_url":"https://api.github.com/users/lucasart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucasart/subscriptions","organizations_url":"https://api.github.com/users/lucasart/orgs","repos_url":"https://api.github.com/users/lucasart/repos","events_url":"https://api.github.com/users/lucasart/events{/privacy}","received_events_url":"https://api.github.com/users/lucasart/received_events","type":"User","site_admin":false},"repo":{"id":28033200,"name":"Stockfish","full_name":"lucasart/Stockfish","owner":{"login":"lucasart","id":2278294,"avatar_url":"https://avatars.githubusercontent.com/u/2278294?v=3","gravatar_id":"","url":"https://api.github.com/users/lucasart","html_url":"https://github.com/lucasart","followers_url":"https://api.github.com/users/lucasart/followers","following_url":"https://api.github.com/users/lucasart/following{/other_user}","gists_url":"https://api.github.com/users/lucasart/gists{/gist_id}","starred_url":"https://api.github.com/users/lucasart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucasart/subscriptions","organizations_url":"https://api.github.com/users/lucasart/orgs","repos_url":"https://api.github.com/users/lucasart/repos","events_url":"https://api.github.com/users/lucasart/events{/privacy}","received_events_url":"https://api.github.com/users/lucasart/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lucasart/Stockfish","description":"UCI chess engine","fork":true,"url":"https://api.github.com/repos/lucasart/Stockfish","forks_url":"https://api.github.com/repos/lucasart/Stockfish/forks","keys_url":"https://api.github.com/repos/lucasart/Stockfish/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lucasart/Stockfish/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lucasart/Stockfish/teams","hooks_url":"https://api.github.com/repos/lucasart/Stockfish/hooks","issue_events_url":"https://api.github.com/repos/lucasart/Stockfish/issues/events{/number}","events_url":"https://api.github.com/repos/lucasart/Stockfish/events","assignees_url":"https://api.github.com/repos/lucasart/Stockfish/assignees{/user}","branches_url":"https://api.github.com/repos/lucasart/Stockfish/branches{/branch}","tags_url":"https://api.github.com/repos/lucasart/Stockfish/tags","blobs_url":"https://api.github.com/repos/lucasart/Stockfish/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lucasart/Stockfish/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lucasart/Stockfish/git/refs{/sha}","trees_url":"https://api.github.com/repos/lucasart/Stockfish/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lucasart/Stockfish/statuses/{sha}","languages_url":"https://api.github.com/repos/lucasart/Stockfish/languages","stargazers_url":"https://api.github.com/repos/lucasart/Stockfish/stargazers","contributors_url":"https://api.github.com/repos/lucasart/Stockfish/contributors","subscribers_url":"https://api.github.com/repos/lucasart/Stockfish/subscribers","subscription_url":"https://api.github.com/repos/lucasart/Stockfish/subscription","commits_url":"https://api.github.com/repos/lucasart/Stockfish/commits{/sha}","git_commits_url":"https://api.github.com/repos/lucasart/Stockfish/git/commits{/sha}","comments_url":"https://api.github.com/repos/lucasart/Stockfish/comments{/number}","issue_comment_url":"https://api.github.com/repos/lucasart/Stockfish/issues/comments/{number}","contents_url":"https://api.github.com/repos/lucasart/Stockfish/contents/{+path}","compare_url":"https://api.github.com/repos/lucasart/Stockfish/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lucasart/Stockfish/merges","archive_url":"https://api.github.com/repos/lucasart/Stockfish/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lucasart/Stockfish/downloads","issues_url":"https://api.github.com/repos/lucasart/Stockfish/issues{/number}","pulls_url":"https://api.github.com/repos/lucasart/Stockfish/pulls{/number}","milestones_url":"https://api.github.com/repos/lucasart/Stockfish/milestones{/number}","notifications_url":"https://api.github.com/repos/lucasart/Stockfish/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lucasart/Stockfish/labels{/name}","releases_url":"https://api.github.com/repos/lucasart/Stockfish/releases{/id}","created_at":"2014-12-15T11:10:19Z","updated_at":"2015-02-03T12:20:51Z","pushed_at":"2015-02-06T03:46:08Z","git_url":"git://github.com/lucasart/Stockfish.git","ssh_url":"git@github.com:lucasart/Stockfish.git","clone_url":"https://github.com/lucasart/Stockfish.git","svn_url":"https://github.com/lucasart/Stockfish","homepage":"http://www.stockfishchess.com/","size":6001,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"official-stockfish:master","ref":"master","sha":"18b08096399c0e316baa1999f8cc6ce56bc7f616","user":{"login":"official-stockfish","id":7926882,"avatar_url":"https://avatars.githubusercontent.com/u/7926882?v=3","gravatar_id":"","url":"https://api.github.com/users/official-stockfish","html_url":"https://github.com/official-stockfish","followers_url":"https://api.github.com/users/official-stockfish/followers","following_url":"https://api.github.com/users/official-stockfish/following{/other_user}","gists_url":"https://api.github.com/users/official-stockfish/gists{/gist_id}","starred_url":"https://api.github.com/users/official-stockfish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/official-stockfish/subscriptions","organizations_url":"https://api.github.com/users/official-stockfish/orgs","repos_url":"https://api.github.com/users/official-stockfish/repos","events_url":"https://api.github.com/users/official-stockfish/events{/privacy}","received_events_url":"https://api.github.com/users/official-stockfish/received_events","type":"Organization","site_admin":false},"repo":{"id":20976138,"name":"Stockfish","full_name":"official-stockfish/Stockfish","owner":{"login":"official-stockfish","id":7926882,"avatar_url":"https://avatars.githubusercontent.com/u/7926882?v=3","gravatar_id":"","url":"https://api.github.com/users/official-stockfish","html_url":"https://github.com/official-stockfish","followers_url":"https://api.github.com/users/official-stockfish/followers","following_url":"https://api.github.com/users/official-stockfish/following{/other_user}","gists_url":"https://api.github.com/users/official-stockfish/gists{/gist_id}","starred_url":"https://api.github.com/users/official-stockfish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/official-stockfish/subscriptions","organizations_url":"https://api.github.com/users/official-stockfish/orgs","repos_url":"https://api.github.com/users/official-stockfish/repos","events_url":"https://api.github.com/users/official-stockfish/events{/privacy}","received_events_url":"https://api.github.com/users/official-stockfish/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/official-stockfish/Stockfish","description":"UCI chess engine","fork":true,"url":"https://api.github.com/repos/official-stockfish/Stockfish","forks_url":"https://api.github.com/repos/official-stockfish/Stockfish/forks","keys_url":"https://api.github.com/repos/official-stockfish/Stockfish/keys{/key_id}","collaborators_url":"https://api.github.com/repos/official-stockfish/Stockfish/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/official-stockfish/Stockfish/teams","hooks_url":"https://api.github.com/repos/official-stockfish/Stockfish/hooks","issue_events_url":"https://api.github.com/repos/official-stockfish/Stockfish/issues/events{/number}","events_url":"https://api.github.com/repos/official-stockfish/Stockfish/events","assignees_url":"https://api.github.com/repos/official-stockfish/Stockfish/assignees{/user}","branches_url":"https://api.github.com/repos/official-stockfish/Stockfish/branches{/branch}","tags_url":"https://api.github.com/repos/official-stockfish/Stockfish/tags","blobs_url":"https://api.github.com/repos/official-stockfish/Stockfish/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/official-stockfish/Stockfish/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/official-stockfish/Stockfish/git/refs{/sha}","trees_url":"https://api.github.com/repos/official-stockfish/Stockfish/git/trees{/sha}","statuses_url":"https://api.github.com/repos/official-stockfish/Stockfish/statuses/{sha}","languages_url":"https://api.github.com/repos/official-stockfish/Stockfish/languages","stargazers_url":"https://api.github.com/repos/official-stockfish/Stockfish/stargazers","contributors_url":"https://api.github.com/repos/official-stockfish/Stockfish/contributors","subscribers_url":"https://api.github.com/repos/official-stockfish/Stockfish/subscribers","subscription_url":"https://api.github.com/repos/official-stockfish/Stockfish/subscription","commits_url":"https://api.github.com/repos/official-stockfish/Stockfish/commits{/sha}","git_commits_url":"https://api.github.com/repos/official-stockfish/Stockfish/git/commits{/sha}","comments_url":"https://api.github.com/repos/official-stockfish/Stockfish/comments{/number}","issue_comment_url":"https://api.github.com/repos/official-stockfish/Stockfish/issues/comments/{number}","contents_url":"https://api.github.com/repos/official-stockfish/Stockfish/contents/{+path}","compare_url":"https://api.github.com/repos/official-stockfish/Stockfish/compare/{base}...{head}","merges_url":"https://api.github.com/repos/official-stockfish/Stockfish/merges","archive_url":"https://api.github.com/repos/official-stockfish/Stockfish/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/official-stockfish/Stockfish/downloads","issues_url":"https://api.github.com/repos/official-stockfish/Stockfish/issues{/number}","pulls_url":"https://api.github.com/repos/official-stockfish/Stockfish/pulls{/number}","milestones_url":"https://api.github.com/repos/official-stockfish/Stockfish/milestones{/number}","notifications_url":"https://api.github.com/repos/official-stockfish/Stockfish/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/official-stockfish/Stockfish/labels{/name}","releases_url":"https://api.github.com/repos/official-stockfish/Stockfish/releases{/id}","created_at":"2014-06-18T19:59:53Z","updated_at":"2015-02-06T09:16:17Z","pushed_at":"2015-02-03T03:20:08Z","git_url":"git://github.com/official-stockfish/Stockfish.git","ssh_url":"git@github.com:official-stockfish/Stockfish.git","clone_url":"https://github.com/official-stockfish/Stockfish.git","svn_url":"https://github.com/official-stockfish/Stockfish","homepage":"http://www.stockfishchess.com/","size":9738,"stargazers_count":195,"watchers_count":195,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":110,"mirror_url":null,"open_issues_count":6,"forks":110,"open_issues":6,"watchers":195,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/official-stockfish/Stockfish/pulls/245"},"html":{"href":"https://github.com/official-stockfish/Stockfish/pull/245"},"issue":{"href":"https://api.github.com/repos/official-stockfish/Stockfish/issues/245"},"comments":{"href":"https://api.github.com/repos/official-stockfish/Stockfish/issues/245/comments"},"review_comments":{"href":"https://api.github.com/repos/official-stockfish/Stockfish/pulls/245/comments"},"review_comment":{"href":"https://api.github.com/repos/official-stockfish/Stockfish/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/official-stockfish/Stockfish/pulls/245/commits"},"statuses":{"href":"https://api.github.com/repos/official-stockfish/Stockfish/statuses/ca016fe9fc483b5bc46cd70b7f880c657a4614eb"}}}}