{"action":"opened","number":1034,"pull_request":{"url":"https://api.github.com/repos/PerlDancer/Dancer2/pulls/1034","id":47956829,"html_url":"https://github.com/PerlDancer/Dancer2/pull/1034","diff_url":"https://github.com/PerlDancer/Dancer2/pull/1034.diff","patch_url":"https://github.com/PerlDancer/Dancer2/pull/1034.patch","issue_url":"https://api.github.com/repos/PerlDancer/Dancer2/issues/1034","number":1034,"state":"open","locked":false,"title":"Change default cookie name from 'dancer.session' to 'dancer2.session'.","user":{"login":"cromedome","id":61165,"avatar_url":"https://avatars.githubusercontent.com/u/61165?v=3","gravatar_id":"","url":"https://api.github.com/users/cromedome","html_url":"https://github.com/cromedome","followers_url":"https://api.github.com/users/cromedome/followers","following_url":"https://api.github.com/users/cromedome/following{/other_user}","gists_url":"https://api.github.com/users/cromedome/gists{/gist_id}","starred_url":"https://api.github.com/users/cromedome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cromedome/subscriptions","organizations_url":"https://api.github.com/users/cromedome/orgs","repos_url":"https://api.github.com/users/cromedome/repos","events_url":"https://api.github.com/users/cromedome/events{/privacy}","received_events_url":"https://api.github.com/users/cromedome/received_events","type":"User","site_admin":false},"body":"I'm not sure this is a bug per se, but since so many other things were\r\nrenamed to be Dancer2, the cookie name seemed like an oversight. For the\r\nsake of being consistent, I changed the name.\r\n\r\nThis discussion prompted the change:\r\nhttp://paste.perldancer.org/1kccHcbfIsYNX\r\n\r\nIn this case, there was a Dancer1 and Dancer2 app on the same host using\r\nthe default cookie, and inadvertently ended up sharing the same cookies\r\n(not desirable). Racke posted a solid workaround, but this seemed like\r\nsomething we should also fix.","created_at":"2015-10-16T20:33:49Z","updated_at":"2015-10-16T20:33:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/PerlDancer/Dancer2/pulls/1034/commits","review_comments_url":"https://api.github.com/repos/PerlDancer/Dancer2/pulls/1034/comments","review_comment_url":"https://api.github.com/repos/PerlDancer/Dancer2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PerlDancer/Dancer2/issues/1034/comments","statuses_url":"https://api.github.com/repos/PerlDancer/Dancer2/statuses/c15cd76a9744fa2e1152154f5fac2d487b29ddf0","head":{"label":"cromedome:bugfix/session-name","ref":"bugfix/session-name","sha":"c15cd76a9744fa2e1152154f5fac2d487b29ddf0","user":{"login":"cromedome","id":61165,"avatar_url":"https://avatars.githubusercontent.com/u/61165?v=3","gravatar_id":"","url":"https://api.github.com/users/cromedome","html_url":"https://github.com/cromedome","followers_url":"https://api.github.com/users/cromedome/followers","following_url":"https://api.github.com/users/cromedome/following{/other_user}","gists_url":"https://api.github.com/users/cromedome/gists{/gist_id}","starred_url":"https://api.github.com/users/cromedome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cromedome/subscriptions","organizations_url":"https://api.github.com/users/cromedome/orgs","repos_url":"https://api.github.com/users/cromedome/repos","events_url":"https://api.github.com/users/cromedome/events{/privacy}","received_events_url":"https://api.github.com/users/cromedome/received_events","type":"User","site_admin":false},"repo":{"id":43519016,"name":"Dancer2","full_name":"cromedome/Dancer2","owner":{"login":"cromedome","id":61165,"avatar_url":"https://avatars.githubusercontent.com/u/61165?v=3","gravatar_id":"","url":"https://api.github.com/users/cromedome","html_url":"https://github.com/cromedome","followers_url":"https://api.github.com/users/cromedome/followers","following_url":"https://api.github.com/users/cromedome/following{/other_user}","gists_url":"https://api.github.com/users/cromedome/gists{/gist_id}","starred_url":"https://api.github.com/users/cromedome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cromedome/subscriptions","organizations_url":"https://api.github.com/users/cromedome/orgs","repos_url":"https://api.github.com/users/cromedome/repos","events_url":"https://api.github.com/users/cromedome/events{/privacy}","received_events_url":"https://api.github.com/users/cromedome/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cromedome/Dancer2","description":"Perl Dancer Next Generation (rewrite of Perl Dancer)","fork":true,"url":"https://api.github.com/repos/cromedome/Dancer2","forks_url":"https://api.github.com/repos/cromedome/Dancer2/forks","keys_url":"https://api.github.com/repos/cromedome/Dancer2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cromedome/Dancer2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cromedome/Dancer2/teams","hooks_url":"https://api.github.com/repos/cromedome/Dancer2/hooks","issue_events_url":"https://api.github.com/repos/cromedome/Dancer2/issues/events{/number}","events_url":"https://api.github.com/repos/cromedome/Dancer2/events","assignees_url":"https://api.github.com/repos/cromedome/Dancer2/assignees{/user}","branches_url":"https://api.github.com/repos/cromedome/Dancer2/branches{/branch}","tags_url":"https://api.github.com/repos/cromedome/Dancer2/tags","blobs_url":"https://api.github.com/repos/cromedome/Dancer2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cromedome/Dancer2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cromedome/Dancer2/git/refs{/sha}","trees_url":"https://api.github.com/repos/cromedome/Dancer2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cromedome/Dancer2/statuses/{sha}","languages_url":"https://api.github.com/repos/cromedome/Dancer2/languages","stargazers_url":"https://api.github.com/repos/cromedome/Dancer2/stargazers","contributors_url":"https://api.github.com/repos/cromedome/Dancer2/contributors","subscribers_url":"https://api.github.com/repos/cromedome/Dancer2/subscribers","subscription_url":"https://api.github.com/repos/cromedome/Dancer2/subscription","commits_url":"https://api.github.com/repos/cromedome/Dancer2/commits{/sha}","git_commits_url":"https://api.github.com/repos/cromedome/Dancer2/git/commits{/sha}","comments_url":"https://api.github.com/repos/cromedome/Dancer2/comments{/number}","issue_comment_url":"https://api.github.com/repos/cromedome/Dancer2/issues/comments{/number}","contents_url":"https://api.github.com/repos/cromedome/Dancer2/contents/{+path}","compare_url":"https://api.github.com/repos/cromedome/Dancer2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cromedome/Dancer2/merges","archive_url":"https://api.github.com/repos/cromedome/Dancer2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cromedome/Dancer2/downloads","issues_url":"https://api.github.com/repos/cromedome/Dancer2/issues{/number}","pulls_url":"https://api.github.com/repos/cromedome/Dancer2/pulls{/number}","milestones_url":"https://api.github.com/repos/cromedome/Dancer2/milestones{/number}","notifications_url":"https://api.github.com/repos/cromedome/Dancer2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cromedome/Dancer2/labels{/name}","releases_url":"https://api.github.com/repos/cromedome/Dancer2/releases{/id}","created_at":"2015-10-01T20:23:02Z","updated_at":"2015-10-01T20:23:04Z","pushed_at":"2015-10-16T20:32:45Z","git_url":"git://github.com/cromedome/Dancer2.git","ssh_url":"git@github.com:cromedome/Dancer2.git","clone_url":"https://github.com/cromedome/Dancer2.git","svn_url":"https://github.com/cromedome/Dancer2","homepage":"http://perldancer.org/","size":4901,"stargazers_count":0,"watchers_count":0,"language":"Perl","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PerlDancer:master","ref":"master","sha":"a500b7875ec04eae208c30d74143d16ce5220887","user":{"login":"PerlDancer","id":409763,"avatar_url":"https://avatars.githubusercontent.com/u/409763?v=3","gravatar_id":"","url":"https://api.github.com/users/PerlDancer","html_url":"https://github.com/PerlDancer","followers_url":"https://api.github.com/users/PerlDancer/followers","following_url":"https://api.github.com/users/PerlDancer/following{/other_user}","gists_url":"https://api.github.com/users/PerlDancer/gists{/gist_id}","starred_url":"https://api.github.com/users/PerlDancer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PerlDancer/subscriptions","organizations_url":"https://api.github.com/users/PerlDancer/orgs","repos_url":"https://api.github.com/users/PerlDancer/repos","events_url":"https://api.github.com/users/PerlDancer/events{/privacy}","received_events_url":"https://api.github.com/users/PerlDancer/received_events","type":"Organization","site_admin":false},"repo":{"id":2488436,"name":"Dancer2","full_name":"PerlDancer/Dancer2","owner":{"login":"PerlDancer","id":409763,"avatar_url":"https://avatars.githubusercontent.com/u/409763?v=3","gravatar_id":"","url":"https://api.github.com/users/PerlDancer","html_url":"https://github.com/PerlDancer","followers_url":"https://api.github.com/users/PerlDancer/followers","following_url":"https://api.github.com/users/PerlDancer/following{/other_user}","gists_url":"https://api.github.com/users/PerlDancer/gists{/gist_id}","starred_url":"https://api.github.com/users/PerlDancer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PerlDancer/subscriptions","organizations_url":"https://api.github.com/users/PerlDancer/orgs","repos_url":"https://api.github.com/users/PerlDancer/repos","events_url":"https://api.github.com/users/PerlDancer/events{/privacy}","received_events_url":"https://api.github.com/users/PerlDancer/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PerlDancer/Dancer2","description":"Perl Dancer Next Generation (rewrite of Perl Dancer)","fork":false,"url":"https://api.github.com/repos/PerlDancer/Dancer2","forks_url":"https://api.github.com/repos/PerlDancer/Dancer2/forks","keys_url":"https://api.github.com/repos/PerlDancer/Dancer2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PerlDancer/Dancer2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PerlDancer/Dancer2/teams","hooks_url":"https://api.github.com/repos/PerlDancer/Dancer2/hooks","issue_events_url":"https://api.github.com/repos/PerlDancer/Dancer2/issues/events{/number}","events_url":"https://api.github.com/repos/PerlDancer/Dancer2/events","assignees_url":"https://api.github.com/repos/PerlDancer/Dancer2/assignees{/user}","branches_url":"https://api.github.com/repos/PerlDancer/Dancer2/branches{/branch}","tags_url":"https://api.github.com/repos/PerlDancer/Dancer2/tags","blobs_url":"https://api.github.com/repos/PerlDancer/Dancer2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PerlDancer/Dancer2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PerlDancer/Dancer2/git/refs{/sha}","trees_url":"https://api.github.com/repos/PerlDancer/Dancer2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PerlDancer/Dancer2/statuses/{sha}","languages_url":"https://api.github.com/repos/PerlDancer/Dancer2/languages","stargazers_url":"https://api.github.com/repos/PerlDancer/Dancer2/stargazers","contributors_url":"https://api.github.com/repos/PerlDancer/Dancer2/contributors","subscribers_url":"https://api.github.com/repos/PerlDancer/Dancer2/subscribers","subscription_url":"https://api.github.com/repos/PerlDancer/Dancer2/subscription","commits_url":"https://api.github.com/repos/PerlDancer/Dancer2/commits{/sha}","git_commits_url":"https://api.github.com/repos/PerlDancer/Dancer2/git/commits{/sha}","comments_url":"https://api.github.com/repos/PerlDancer/Dancer2/comments{/number}","issue_comment_url":"https://api.github.com/repos/PerlDancer/Dancer2/issues/comments{/number}","contents_url":"https://api.github.com/repos/PerlDancer/Dancer2/contents/{+path}","compare_url":"https://api.github.com/repos/PerlDancer/Dancer2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PerlDancer/Dancer2/merges","archive_url":"https://api.github.com/repos/PerlDancer/Dancer2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PerlDancer/Dancer2/downloads","issues_url":"https://api.github.com/repos/PerlDancer/Dancer2/issues{/number}","pulls_url":"https://api.github.com/repos/PerlDancer/Dancer2/pulls{/number}","milestones_url":"https://api.github.com/repos/PerlDancer/Dancer2/milestones{/number}","notifications_url":"https://api.github.com/repos/PerlDancer/Dancer2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PerlDancer/Dancer2/labels{/name}","releases_url":"https://api.github.com/repos/PerlDancer/Dancer2/releases{/id}","created_at":"2011-09-30T10:26:56Z","updated_at":"2015-10-15T13:21:11Z","pushed_at":"2015-10-16T16:20:53Z","git_url":"git://github.com/PerlDancer/Dancer2.git","ssh_url":"git@github.com:PerlDancer/Dancer2.git","clone_url":"https://github.com/PerlDancer/Dancer2.git","svn_url":"https://github.com/PerlDancer/Dancer2","homepage":"http://perldancer.org/","size":11168,"stargazers_count":290,"watchers_count":290,"language":"Perl","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":174,"mirror_url":null,"open_issues_count":77,"forks":174,"open_issues":77,"watchers":290,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PerlDancer/Dancer2/pulls/1034"},"html":{"href":"https://github.com/PerlDancer/Dancer2/pull/1034"},"issue":{"href":"https://api.github.com/repos/PerlDancer/Dancer2/issues/1034"},"comments":{"href":"https://api.github.com/repos/PerlDancer/Dancer2/issues/1034/comments"},"review_comments":{"href":"https://api.github.com/repos/PerlDancer/Dancer2/pulls/1034/comments"},"review_comment":{"href":"https://api.github.com/repos/PerlDancer/Dancer2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PerlDancer/Dancer2/pulls/1034/commits"},"statuses":{"href":"https://api.github.com/repos/PerlDancer/Dancer2/statuses/c15cd76a9744fa2e1152154f5fac2d487b29ddf0"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":3,"deletions":3,"changed_files":2}}