{"action":"created","issue":{"url":"https://api.github.com/repos/zendesk/maxwell/issues/138","labels_url":"https://api.github.com/repos/zendesk/maxwell/issues/138/labels{/name}","comments_url":"https://api.github.com/repos/zendesk/maxwell/issues/138/comments","events_url":"https://api.github.com/repos/zendesk/maxwell/issues/138/events","html_url":"https://github.com/zendesk/maxwell/pull/138","id":114029362,"number":138,"title":"Fix potential NPE in TableDrop","user":{"login":"davidsheldon","id":37772,"avatar_url":"https://avatars.githubusercontent.com/u/37772?v=3","gravatar_id":"","url":"https://api.github.com/users/davidsheldon","html_url":"https://github.com/davidsheldon","followers_url":"https://api.github.com/users/davidsheldon/followers","following_url":"https://api.github.com/users/davidsheldon/following{/other_user}","gists_url":"https://api.github.com/users/davidsheldon/gists{/gist_id}","starred_url":"https://api.github.com/users/davidsheldon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidsheldon/subscriptions","organizations_url":"https://api.github.com/users/davidsheldon/orgs","repos_url":"https://api.github.com/users/davidsheldon/repos","events_url":"https://api.github.com/users/davidsheldon/events{/privacy}","received_events_url":"https://api.github.com/users/davidsheldon/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-10-29T11:22:37Z","updated_at":"2015-10-29T11:30:55Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/zendesk/maxwell/pulls/138","html_url":"https://github.com/zendesk/maxwell/pull/138","diff_url":"https://github.com/zendesk/maxwell/pull/138.diff","patch_url":"https://github.com/zendesk/maxwell/pull/138.patch"},"body":"I suspect that this will not get through a working MySQL server, but if we've just tested the database for being null, calling a method on it is quite dangerous.\r\n\r\nThis code will still return \"newSchema\" if d == null && ifExists, but will use the existing return.\r\n\r\nIncidentally, is there any difference between returning originalSchema or newSchema in this case? Should we return originalSchema if nothing's changed?"},"comment":{"url":"https://api.github.com/repos/zendesk/maxwell/issues/comments/152152770","html_url":"https://github.com/zendesk/maxwell/pull/138#issuecomment-152152770","issue_url":"https://api.github.com/repos/zendesk/maxwell/issues/138","id":152152770,"user":{"login":"codecov-io","id":8655789,"avatar_url":"https://avatars.githubusercontent.com/u/8655789?v=3","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2015-10-29T11:30:55Z","updated_at":"2015-10-29T11:30:55Z","body":"## [Current coverage][1] is `67.73%`\n> Merging **#138** into **master** will increase coverage by **+0.15%** as of [`69f99a3`][3]\n\n\n```diff\n@@            master    #138   diff @@\n======================================\n  Files           56      56       \n  Stmts         1962    1962       \n  Branches       331     331       \n  Methods          0       0       \n======================================\n+ Hit           1326    1329     +3\n+ Partial         96      95     -1\n+ Missed         540     538     -2\n```\n\n> Review entire [Coverage Diff][4] as of [`69f99a3`][3]\n\n\n[1]: https://codecov.io/github/zendesk/maxwell?ref=69f99a3fc30ea330aebeab0e648cfddbff96a24e\n[2]: https://codecov.io/github/zendesk/maxwell/features/suggestions?ref=69f99a3fc30ea330aebeab0e648cfddbff96a24e\n[3]: https://codecov.io/github/zendesk/maxwell/commit/69f99a3fc30ea330aebeab0e648cfddbff96a24e\n[4]: https://codecov.io/github/zendesk/maxwell/compare/e6c89bd6add62168e030ca01ba6ed258b56f0b0e...69f99a3fc30ea330aebeab0e648cfddbff96a24e\n\n> Powered by [Codecov](https://codecov.io). Updated on successful CI builds."}}