{"action":"created","issue":{"url":"https://api.github.com/repos/nitlang/nit/issues/1821","labels_url":"https://api.github.com/repos/nitlang/nit/issues/1821/labels{/name}","comments_url":"https://api.github.com/repos/nitlang/nit/issues/1821/comments","events_url":"https://api.github.com/repos/nitlang/nit/issues/1821/events","html_url":"https://github.com/nitlang/nit/pull/1821","id":115706110,"number":1821,"title":"serialization: serialize the Error class and avoid  abstract classes with factories","user":{"login":"xymus","id":208057,"avatar_url":"https://avatars.githubusercontent.com/u/208057?v=3","gravatar_id":"","url":"https://api.github.com/users/xymus","html_url":"https://github.com/xymus","followers_url":"https://api.github.com/users/xymus/followers","following_url":"https://api.github.com/users/xymus/following{/other_user}","gists_url":"https://api.github.com/users/xymus/gists{/gist_id}","starred_url":"https://api.github.com/users/xymus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xymus/subscriptions","organizations_url":"https://api.github.com/users/xymus/orgs","repos_url":"https://api.github.com/users/xymus/repos","events_url":"https://api.github.com/users/xymus/events{/privacy}","received_events_url":"https://api.github.com/users/xymus/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/nitlang/nit/labels/need_review","name":"need_review","color":"fbca04"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-11-08T02:54:00Z","updated_at":"2015-11-08T17:30:10Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nitlang/nit/pulls/1821","html_url":"https://github.com/nitlang/nit/pull/1821","diff_url":"https://github.com/nitlang/nit/pull/1821.diff","patch_url":"https://github.com/nitlang/nit/pull/1821.patch"},"body":"This PR implements the serialization of the `Error` class manually, it is declared in `core` above the `serialization` module.\r\n\r\nAlso updates `nitserial` so that it does not attempt to instantiate abstract classes with factories.\r\n\r\n@privat I have doubts about the use of `is_abstract` and `is_class`, is it appropriate?"},"comment":{"url":"https://api.github.com/repos/nitlang/nit/issues/comments/154847228","html_url":"https://github.com/nitlang/nit/pull/1821#issuecomment-154847228","issue_url":"https://api.github.com/repos/nitlang/nit/issues/1821","id":154847228,"user":{"login":"privat","id":135828,"avatar_url":"https://avatars.githubusercontent.com/u/135828?v=3","gravatar_id":"","url":"https://api.github.com/users/privat","html_url":"https://github.com/privat","followers_url":"https://api.github.com/users/privat/followers","following_url":"https://api.github.com/users/privat/following{/other_user}","gists_url":"https://api.github.com/users/privat/gists{/gist_id}","starred_url":"https://api.github.com/users/privat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/privat/subscriptions","organizations_url":"https://api.github.com/users/privat/orgs","repos_url":"https://api.github.com/users/privat/repos","events_url":"https://api.github.com/users/privat/events{/privacy}","received_events_url":"https://api.github.com/users/privat/received_events","type":"User","site_admin":false},"created_at":"2015-11-08T17:30:09Z","updated_at":"2015-11-08T17:30:09Z","body":"why a manual serialization or Error is necessary?\r\n\r\nabout your doubts, if you just want to filter only concrete class then something like `if mtype.mclass.kind == concrete_kind then ...` should be enough"}}