{"action":"opened","number":840,"pull_request":{"url":"https://api.github.com/repos/NodeRedis/node_redis/pulls/840","id":44930820,"html_url":"https://github.com/NodeRedis/node_redis/pull/840","diff_url":"https://github.com/NodeRedis/node_redis/pull/840.diff","patch_url":"https://github.com/NodeRedis/node_redis/pull/840.patch","issue_url":"https://api.github.com/repos/NodeRedis/node_redis/issues/840","number":840,"state":"open","locked":false,"title":"This fixes two TODOs in combination with exec","user":{"login":"BridgeAR","id":8822573,"avatar_url":"https://avatars.githubusercontent.com/u/8822573?v=3","gravatar_id":"","url":"https://api.github.com/users/BridgeAR","html_url":"https://github.com/BridgeAR","followers_url":"https://api.github.com/users/BridgeAR/followers","following_url":"https://api.github.com/users/BridgeAR/following{/other_user}","gists_url":"https://api.github.com/users/BridgeAR/gists{/gist_id}","starred_url":"https://api.github.com/users/BridgeAR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BridgeAR/subscriptions","organizations_url":"https://api.github.com/users/BridgeAR/orgs","repos_url":"https://api.github.com/users/BridgeAR/repos","events_url":"https://api.github.com/users/BridgeAR/events{/privacy}","received_events_url":"https://api.github.com/users/BridgeAR/received_events","type":"User","site_admin":false},"body":"I refactored exec so it won't recreate the big callback each time. I'd like to take this a step further at some point and to refactor the callback to be handled in .return_reply but this should be done at a later point.\r\n\r\nThere was some dead code in there too.\r\n\r\nI removed one statement to accept arrays as arguments, since this should be handled the same spot all the time instead of being spread around different functions. So we have to wait until another fix (#838) has landed until is can be merged.","created_at":"2015-09-14T13:39:47Z","updated_at":"2015-09-14T13:39:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/NodeRedis/node_redis/pulls/840/commits","review_comments_url":"https://api.github.com/repos/NodeRedis/node_redis/pulls/840/comments","review_comment_url":"https://api.github.com/repos/NodeRedis/node_redis/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NodeRedis/node_redis/issues/840/comments","statuses_url":"https://api.github.com/repos/NodeRedis/node_redis/statuses/32361e6f369bf336f1863bddeb7eff7300cbd9fa","head":{"label":"fintura:refactor-exec","ref":"refactor-exec","sha":"32361e6f369bf336f1863bddeb7eff7300cbd9fa","user":{"login":"fintura","id":11907812,"avatar_url":"https://avatars.githubusercontent.com/u/11907812?v=3","gravatar_id":"","url":"https://api.github.com/users/fintura","html_url":"https://github.com/fintura","followers_url":"https://api.github.com/users/fintura/followers","following_url":"https://api.github.com/users/fintura/following{/other_user}","gists_url":"https://api.github.com/users/fintura/gists{/gist_id}","starred_url":"https://api.github.com/users/fintura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fintura/subscriptions","organizations_url":"https://api.github.com/users/fintura/orgs","repos_url":"https://api.github.com/users/fintura/repos","events_url":"https://api.github.com/users/fintura/events{/privacy}","received_events_url":"https://api.github.com/users/fintura/received_events","type":"Organization","site_admin":false},"repo":{"id":39509488,"name":"node_redis","full_name":"fintura/node_redis","owner":{"login":"fintura","id":11907812,"avatar_url":"https://avatars.githubusercontent.com/u/11907812?v=3","gravatar_id":"","url":"https://api.github.com/users/fintura","html_url":"https://github.com/fintura","followers_url":"https://api.github.com/users/fintura/followers","following_url":"https://api.github.com/users/fintura/following{/other_user}","gists_url":"https://api.github.com/users/fintura/gists{/gist_id}","starred_url":"https://api.github.com/users/fintura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fintura/subscriptions","organizations_url":"https://api.github.com/users/fintura/orgs","repos_url":"https://api.github.com/users/fintura/repos","events_url":"https://api.github.com/users/fintura/events{/privacy}","received_events_url":"https://api.github.com/users/fintura/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fintura/node_redis","description":"redis client for node","fork":true,"url":"https://api.github.com/repos/fintura/node_redis","forks_url":"https://api.github.com/repos/fintura/node_redis/forks","keys_url":"https://api.github.com/repos/fintura/node_redis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fintura/node_redis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fintura/node_redis/teams","hooks_url":"https://api.github.com/repos/fintura/node_redis/hooks","issue_events_url":"https://api.github.com/repos/fintura/node_redis/issues/events{/number}","events_url":"https://api.github.com/repos/fintura/node_redis/events","assignees_url":"https://api.github.com/repos/fintura/node_redis/assignees{/user}","branches_url":"https://api.github.com/repos/fintura/node_redis/branches{/branch}","tags_url":"https://api.github.com/repos/fintura/node_redis/tags","blobs_url":"https://api.github.com/repos/fintura/node_redis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fintura/node_redis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fintura/node_redis/git/refs{/sha}","trees_url":"https://api.github.com/repos/fintura/node_redis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fintura/node_redis/statuses/{sha}","languages_url":"https://api.github.com/repos/fintura/node_redis/languages","stargazers_url":"https://api.github.com/repos/fintura/node_redis/stargazers","contributors_url":"https://api.github.com/repos/fintura/node_redis/contributors","subscribers_url":"https://api.github.com/repos/fintura/node_redis/subscribers","subscription_url":"https://api.github.com/repos/fintura/node_redis/subscription","commits_url":"https://api.github.com/repos/fintura/node_redis/commits{/sha}","git_commits_url":"https://api.github.com/repos/fintura/node_redis/git/commits{/sha}","comments_url":"https://api.github.com/repos/fintura/node_redis/comments{/number}","issue_comment_url":"https://api.github.com/repos/fintura/node_redis/issues/comments{/number}","contents_url":"https://api.github.com/repos/fintura/node_redis/contents/{+path}","compare_url":"https://api.github.com/repos/fintura/node_redis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fintura/node_redis/merges","archive_url":"https://api.github.com/repos/fintura/node_redis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fintura/node_redis/downloads","issues_url":"https://api.github.com/repos/fintura/node_redis/issues{/number}","pulls_url":"https://api.github.com/repos/fintura/node_redis/pulls{/number}","milestones_url":"https://api.github.com/repos/fintura/node_redis/milestones{/number}","notifications_url":"https://api.github.com/repos/fintura/node_redis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fintura/node_redis/labels{/name}","releases_url":"https://api.github.com/repos/fintura/node_redis/releases{/id}","created_at":"2015-07-22T14:03:27Z","updated_at":"2015-09-11T01:33:52Z","pushed_at":"2015-09-14T13:29:27Z","git_url":"git://github.com/fintura/node_redis.git","ssh_url":"git@github.com:fintura/node_redis.git","clone_url":"https://github.com/fintura/node_redis.git","svn_url":"https://github.com/fintura/node_redis","homepage":"","size":1408,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NodeRedis:master","ref":"master","sha":"06121a65c476a16e18e59b139319f07dc91bcdad","user":{"login":"NodeRedis","id":5845577,"avatar_url":"https://avatars.githubusercontent.com/u/5845577?v=3","gravatar_id":"","url":"https://api.github.com/users/NodeRedis","html_url":"https://github.com/NodeRedis","followers_url":"https://api.github.com/users/NodeRedis/followers","following_url":"https://api.github.com/users/NodeRedis/following{/other_user}","gists_url":"https://api.github.com/users/NodeRedis/gists{/gist_id}","starred_url":"https://api.github.com/users/NodeRedis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NodeRedis/subscriptions","organizations_url":"https://api.github.com/users/NodeRedis/orgs","repos_url":"https://api.github.com/users/NodeRedis/repos","events_url":"https://api.github.com/users/NodeRedis/events{/privacy}","received_events_url":"https://api.github.com/users/NodeRedis/received_events","type":"Organization","site_admin":false},"repo":{"id":908893,"name":"node_redis","full_name":"NodeRedis/node_redis","owner":{"login":"NodeRedis","id":5845577,"avatar_url":"https://avatars.githubusercontent.com/u/5845577?v=3","gravatar_id":"","url":"https://api.github.com/users/NodeRedis","html_url":"https://github.com/NodeRedis","followers_url":"https://api.github.com/users/NodeRedis/followers","following_url":"https://api.github.com/users/NodeRedis/following{/other_user}","gists_url":"https://api.github.com/users/NodeRedis/gists{/gist_id}","starred_url":"https://api.github.com/users/NodeRedis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NodeRedis/subscriptions","organizations_url":"https://api.github.com/users/NodeRedis/orgs","repos_url":"https://api.github.com/users/NodeRedis/repos","events_url":"https://api.github.com/users/NodeRedis/events{/privacy}","received_events_url":"https://api.github.com/users/NodeRedis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NodeRedis/node_redis","description":"redis client for node","fork":false,"url":"https://api.github.com/repos/NodeRedis/node_redis","forks_url":"https://api.github.com/repos/NodeRedis/node_redis/forks","keys_url":"https://api.github.com/repos/NodeRedis/node_redis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NodeRedis/node_redis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NodeRedis/node_redis/teams","hooks_url":"https://api.github.com/repos/NodeRedis/node_redis/hooks","issue_events_url":"https://api.github.com/repos/NodeRedis/node_redis/issues/events{/number}","events_url":"https://api.github.com/repos/NodeRedis/node_redis/events","assignees_url":"https://api.github.com/repos/NodeRedis/node_redis/assignees{/user}","branches_url":"https://api.github.com/repos/NodeRedis/node_redis/branches{/branch}","tags_url":"https://api.github.com/repos/NodeRedis/node_redis/tags","blobs_url":"https://api.github.com/repos/NodeRedis/node_redis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NodeRedis/node_redis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NodeRedis/node_redis/git/refs{/sha}","trees_url":"https://api.github.com/repos/NodeRedis/node_redis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NodeRedis/node_redis/statuses/{sha}","languages_url":"https://api.github.com/repos/NodeRedis/node_redis/languages","stargazers_url":"https://api.github.com/repos/NodeRedis/node_redis/stargazers","contributors_url":"https://api.github.com/repos/NodeRedis/node_redis/contributors","subscribers_url":"https://api.github.com/repos/NodeRedis/node_redis/subscribers","subscription_url":"https://api.github.com/repos/NodeRedis/node_redis/subscription","commits_url":"https://api.github.com/repos/NodeRedis/node_redis/commits{/sha}","git_commits_url":"https://api.github.com/repos/NodeRedis/node_redis/git/commits{/sha}","comments_url":"https://api.github.com/repos/NodeRedis/node_redis/comments{/number}","issue_comment_url":"https://api.github.com/repos/NodeRedis/node_redis/issues/comments{/number}","contents_url":"https://api.github.com/repos/NodeRedis/node_redis/contents/{+path}","compare_url":"https://api.github.com/repos/NodeRedis/node_redis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NodeRedis/node_redis/merges","archive_url":"https://api.github.com/repos/NodeRedis/node_redis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NodeRedis/node_redis/downloads","issues_url":"https://api.github.com/repos/NodeRedis/node_redis/issues{/number}","pulls_url":"https://api.github.com/repos/NodeRedis/node_redis/pulls{/number}","milestones_url":"https://api.github.com/repos/NodeRedis/node_redis/milestones{/number}","notifications_url":"https://api.github.com/repos/NodeRedis/node_redis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NodeRedis/node_redis/labels{/name}","releases_url":"https://api.github.com/repos/NodeRedis/node_redis/releases{/id}","created_at":"2010-09-14T02:05:09Z","updated_at":"2015-09-14T09:46:29Z","pushed_at":"2015-09-14T13:35:55Z","git_url":"git://github.com/NodeRedis/node_redis.git","ssh_url":"git@github.com:NodeRedis/node_redis.git","clone_url":"https://github.com/NodeRedis/node_redis.git","svn_url":"https://github.com/NodeRedis/node_redis","homepage":"http://redis.js.org/","size":3823,"stargazers_count":5052,"watchers_count":5052,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":721,"mirror_url":null,"open_issues_count":91,"forks":721,"open_issues":91,"watchers":5052,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NodeRedis/node_redis/pulls/840"},"html":{"href":"https://github.com/NodeRedis/node_redis/pull/840"},"issue":{"href":"https://api.github.com/repos/NodeRedis/node_redis/issues/840"},"comments":{"href":"https://api.github.com/repos/NodeRedis/node_redis/issues/840/comments"},"review_comments":{"href":"https://api.github.com/repos/NodeRedis/node_redis/pulls/840/comments"},"review_comment":{"href":"https://api.github.com/repos/NodeRedis/node_redis/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NodeRedis/node_redis/pulls/840/commits"},"statuses":{"href":"https://api.github.com/repos/NodeRedis/node_redis/statuses/32361e6f369bf336f1863bddeb7eff7300cbd9fa"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":74,"deletions":75,"changed_files":2}}