{"action":"created","issue":{"url":"https://api.github.com/repos/appc/spec/issues/462","labels_url":"https://api.github.com/repos/appc/spec/issues/462/labels{/name}","comments_url":"https://api.github.com/repos/appc/spec/issues/462/comments","events_url":"https://api.github.com/repos/appc/spec/issues/462/events","html_url":"https://github.com/appc/spec/pull/462","id":98608527,"number":462,"title":"aci: make XzReader implement io.ReadCloser","user":{"login":"sgotti","id":1690273,"avatar_url":"https://avatars.githubusercontent.com/u/1690273?v=3","gravatar_id":"","url":"https://api.github.com/users/sgotti","html_url":"https://github.com/sgotti","followers_url":"https://api.github.com/users/sgotti/followers","following_url":"https://api.github.com/users/sgotti/following{/other_user}","gists_url":"https://api.github.com/users/sgotti/gists{/gist_id}","starred_url":"https://api.github.com/users/sgotti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgotti/subscriptions","organizations_url":"https://api.github.com/users/sgotti/orgs","repos_url":"https://api.github.com/users/sgotti/repos","events_url":"https://api.github.com/users/sgotti/events{/privacy}","received_events_url":"https://api.github.com/users/sgotti/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-08-02T13:15:07Z","updated_at":"2015-08-09T14:43:03Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/appc/spec/pulls/462","html_url":"https://github.com/appc/spec/pull/462","diff_url":"https://github.com/appc/spec/pull/462.diff","patch_url":"https://github.com/appc/spec/pull/462.patch"},"body":"this depends on #461. The relevant patch is `aci: make XzReader implement io.ReadCloser`\r\n\r\nthis is needed as the XzReader, now calling an external process, needs to be\r\nclosed or the underlying process will continue to read from the passed file\r\ndescriptor, creating a race with subsequent methods calling another XzReader.\r\n\r\nThe Close method closes the output pipe, kills the process and then waits for\r\nit to exit.\r\n\r\nA possible fix after/substituting this will be to migrate to a pure go xz decompressor like the one proposed in #455\r\n\r\nThis is a part of the fix for coreos/rkt#1224 (missing the rkt part using the right functions)"},"comment":{"url":"https://api.github.com/repos/appc/spec/issues/comments/129192640","html_url":"https://github.com/appc/spec/pull/462#issuecomment-129192640","issue_url":"https://api.github.com/repos/appc/spec/issues/462","id":129192640,"user":{"login":"philips","id":33544,"avatar_url":"https://avatars.githubusercontent.com/u/33544?v=3","gravatar_id":"","url":"https://api.github.com/users/philips","html_url":"https://github.com/philips","followers_url":"https://api.github.com/users/philips/followers","following_url":"https://api.github.com/users/philips/following{/other_user}","gists_url":"https://api.github.com/users/philips/gists{/gist_id}","starred_url":"https://api.github.com/users/philips/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philips/subscriptions","organizations_url":"https://api.github.com/users/philips/orgs","repos_url":"https://api.github.com/users/philips/repos","events_url":"https://api.github.com/users/philips/events{/privacy}","received_events_url":"https://api.github.com/users/philips/received_events","type":"User","site_admin":false},"created_at":"2015-08-09T14:43:03Z","updated_at":"2015-08-09T14:43:03Z","body":"lgtm but blocked on @jonboulle "}}