{"action":"created","issue":{"url":"https://api.github.com/repos/puppetlabs/cfacter/issues/340","labels_url":"https://api.github.com/repos/puppetlabs/cfacter/issues/340/labels{/name}","comments_url":"https://api.github.com/repos/puppetlabs/cfacter/issues/340/comments","events_url":"https://api.github.com/repos/puppetlabs/cfacter/issues/340/events","html_url":"https://github.com/puppetlabs/cfacter/pull/340","id":63120951,"number":340,"title":"(CFACT-258) Add a timeout option to Facter::Core::Execution#execute.","user":{"login":"peterhuene","id":509666,"avatar_url":"https://avatars.githubusercontent.com/u/509666?v=3","gravatar_id":"","url":"https://api.github.com/users/peterhuene","html_url":"https://github.com/peterhuene","followers_url":"https://api.github.com/users/peterhuene/followers","following_url":"https://api.github.com/users/peterhuene/following{/other_user}","gists_url":"https://api.github.com/users/peterhuene/gists{/gist_id}","starred_url":"https://api.github.com/users/peterhuene/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterhuene/subscriptions","organizations_url":"https://api.github.com/users/peterhuene/orgs","repos_url":"https://api.github.com/users/peterhuene/repos","events_url":"https://api.github.com/users/peterhuene/events{/privacy}","received_events_url":"https://api.github.com/users/peterhuene/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-03-20T00:07:44Z","updated_at":"2015-03-20T20:26:44Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/puppetlabs/cfacter/pulls/340","html_url":"https://github.com/puppetlabs/cfacter/pull/340","diff_url":"https://github.com/puppetlabs/cfacter/pull/340.diff","patch_url":"https://github.com/puppetlabs/cfacter/pull/340.patch"},"body":"This adds support in the Ruby Facter API to pass a timeout option to\r\nFacter::Core::Execution#execute.  If the timeout elapses, a\r\nFacter::Core::Execution::ExecutionFailure is raised.\r\n\r\nThe timeout option is given in seconds.\r\n\r\nExample:\r\n```ruby\r\nFacter::Core::Execution.execute('foo', timeout: 5)\r\n```"},"comment":{"url":"https://api.github.com/repos/puppetlabs/cfacter/issues/comments/84135469","html_url":"https://github.com/puppetlabs/cfacter/pull/340#issuecomment-84135469","issue_url":"https://api.github.com/repos/puppetlabs/cfacter/issues/340","id":84135469,"user":{"login":"peterhuene","id":509666,"avatar_url":"https://avatars.githubusercontent.com/u/509666?v=3","gravatar_id":"","url":"https://api.github.com/users/peterhuene","html_url":"https://github.com/peterhuene","followers_url":"https://api.github.com/users/peterhuene/followers","following_url":"https://api.github.com/users/peterhuene/following{/other_user}","gists_url":"https://api.github.com/users/peterhuene/gists{/gist_id}","starred_url":"https://api.github.com/users/peterhuene/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterhuene/subscriptions","organizations_url":"https://api.github.com/users/peterhuene/orgs","repos_url":"https://api.github.com/users/peterhuene/repos","events_url":"https://api.github.com/users/peterhuene/events{/privacy}","received_events_url":"https://api.github.com/users/peterhuene/received_events","type":"User","site_admin":false},"created_at":"2015-03-20T20:26:44Z","updated_at":"2015-03-20T20:26:44Z","body":"Looks like it was failing because the command in the test was not correct and it was causing a broken pipe.  We had a check under the overlapped I/O result to check for broken pipe, but were missing one if the read wasn't overlapped.  I've added one."}}