{"action":"closed","number":542,"pull_request":{"url":"https://api.github.com/repos/lxc/lxd/pulls/542","id":34128611,"html_url":"https://github.com/lxc/lxd/pull/542","diff_url":"https://github.com/lxc/lxd/pull/542.diff","patch_url":"https://github.com/lxc/lxd/pull/542.patch","issue_url":"https://api.github.com/repos/lxc/lxd/issues/542","number":542,"state":"closed","locked":false,"title":"Fix a race in hwaddr setting","user":{"login":"hallyn","id":1359441,"avatar_url":"https://avatars.githubusercontent.com/u/1359441?v=3","gravatar_id":"","url":"https://api.github.com/users/hallyn","html_url":"https://github.com/hallyn","followers_url":"https://api.github.com/users/hallyn/followers","following_url":"https://api.github.com/users/hallyn/following{/other_user}","gists_url":"https://api.github.com/users/hallyn/gists{/gist_id}","starred_url":"https://api.github.com/users/hallyn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hallyn/subscriptions","organizations_url":"https://api.github.com/users/hallyn/orgs","repos_url":"https://api.github.com/users/hallyn/repos","events_url":"https://api.github.com/users/hallyn/events{/privacy}","received_events_url":"https://api.github.com/users/hallyn/received_events","type":"User","site_admin":false},"body":"Two competing newLxdContainers (for instance) can race setting a\r\nhwaddr for a device.  This leads to a db error because the containerid\r\nand config key must together be unique.\r\n\r\nalso add a new testcase, which is not automatically run.  We can\r\nreconsider that and rename it, but for now it's intended to keep\r\ngrowing into the most painful testcaes for lxd.\r\n\r\nIt launches 100 containers (5 waves of 20) while doing other things\r\nin parallel.  In particular, adding 'exec' would cause this to fail\r\nbecause the 'start' part of 'launch' is still unreliable.  That is\r\nobviously next on my list.\r\n\r\nSigned-off-by: Serge Hallyn <serge.hallyn@ubuntu.com>","created_at":"2015-04-26T19:42:36Z","updated_at":"2015-04-27T12:12:22Z","closed_at":"2015-04-27T12:12:22Z","merged_at":"2015-04-27T12:12:22Z","merge_commit_sha":"1951515ea5cd7796a4e9bfcf04e1068bc8feda5a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/lxc/lxd/pulls/542/commits","review_comments_url":"https://api.github.com/repos/lxc/lxd/pulls/542/comments","review_comment_url":"https://api.github.com/repos/lxc/lxd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lxc/lxd/issues/542/comments","statuses_url":"https://api.github.com/repos/lxc/lxd/statuses/aceeddf454ddd0614ed6cb7f1773ab1b3246bae3","head":{"label":"hallyn:2015-04-26/debug1","ref":"2015-04-26/debug1","sha":"aceeddf454ddd0614ed6cb7f1773ab1b3246bae3","user":{"login":"hallyn","id":1359441,"avatar_url":"https://avatars.githubusercontent.com/u/1359441?v=3","gravatar_id":"","url":"https://api.github.com/users/hallyn","html_url":"https://github.com/hallyn","followers_url":"https://api.github.com/users/hallyn/followers","following_url":"https://api.github.com/users/hallyn/following{/other_user}","gists_url":"https://api.github.com/users/hallyn/gists{/gist_id}","starred_url":"https://api.github.com/users/hallyn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hallyn/subscriptions","organizations_url":"https://api.github.com/users/hallyn/orgs","repos_url":"https://api.github.com/users/hallyn/repos","events_url":"https://api.github.com/users/hallyn/events{/privacy}","received_events_url":"https://api.github.com/users/hallyn/received_events","type":"User","site_admin":false},"repo":{"id":26297086,"name":"lxd","full_name":"hallyn/lxd","owner":{"login":"hallyn","id":1359441,"avatar_url":"https://avatars.githubusercontent.com/u/1359441?v=3","gravatar_id":"","url":"https://api.github.com/users/hallyn","html_url":"https://github.com/hallyn","followers_url":"https://api.github.com/users/hallyn/followers","following_url":"https://api.github.com/users/hallyn/following{/other_user}","gists_url":"https://api.github.com/users/hallyn/gists{/gist_id}","starred_url":"https://api.github.com/users/hallyn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hallyn/subscriptions","organizations_url":"https://api.github.com/users/hallyn/orgs","repos_url":"https://api.github.com/users/hallyn/repos","events_url":"https://api.github.com/users/hallyn/events{/privacy}","received_events_url":"https://api.github.com/users/hallyn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hallyn/lxd","description":"lxd (pronounced lex-dee) is a REST API, command line tool and OpenStack plugin based on liblxc","fork":true,"url":"https://api.github.com/repos/hallyn/lxd","forks_url":"https://api.github.com/repos/hallyn/lxd/forks","keys_url":"https://api.github.com/repos/hallyn/lxd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hallyn/lxd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hallyn/lxd/teams","hooks_url":"https://api.github.com/repos/hallyn/lxd/hooks","issue_events_url":"https://api.github.com/repos/hallyn/lxd/issues/events{/number}","events_url":"https://api.github.com/repos/hallyn/lxd/events","assignees_url":"https://api.github.com/repos/hallyn/lxd/assignees{/user}","branches_url":"https://api.github.com/repos/hallyn/lxd/branches{/branch}","tags_url":"https://api.github.com/repos/hallyn/lxd/tags","blobs_url":"https://api.github.com/repos/hallyn/lxd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hallyn/lxd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hallyn/lxd/git/refs{/sha}","trees_url":"https://api.github.com/repos/hallyn/lxd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hallyn/lxd/statuses/{sha}","languages_url":"https://api.github.com/repos/hallyn/lxd/languages","stargazers_url":"https://api.github.com/repos/hallyn/lxd/stargazers","contributors_url":"https://api.github.com/repos/hallyn/lxd/contributors","subscribers_url":"https://api.github.com/repos/hallyn/lxd/subscribers","subscription_url":"https://api.github.com/repos/hallyn/lxd/subscription","commits_url":"https://api.github.com/repos/hallyn/lxd/commits{/sha}","git_commits_url":"https://api.github.com/repos/hallyn/lxd/git/commits{/sha}","comments_url":"https://api.github.com/repos/hallyn/lxd/comments{/number}","issue_comment_url":"https://api.github.com/repos/hallyn/lxd/issues/comments{/number}","contents_url":"https://api.github.com/repos/hallyn/lxd/contents/{+path}","compare_url":"https://api.github.com/repos/hallyn/lxd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hallyn/lxd/merges","archive_url":"https://api.github.com/repos/hallyn/lxd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hallyn/lxd/downloads","issues_url":"https://api.github.com/repos/hallyn/lxd/issues{/number}","pulls_url":"https://api.github.com/repos/hallyn/lxd/pulls{/number}","milestones_url":"https://api.github.com/repos/hallyn/lxd/milestones{/number}","notifications_url":"https://api.github.com/repos/hallyn/lxd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hallyn/lxd/labels{/name}","releases_url":"https://api.github.com/repos/hallyn/lxd/releases{/id}","created_at":"2014-11-07T00:48:12Z","updated_at":"2014-11-06T23:52:05Z","pushed_at":"2015-04-27T10:25:12Z","git_url":"git://github.com/hallyn/lxd.git","ssh_url":"git@github.com:hallyn/lxd.git","clone_url":"https://github.com/hallyn/lxd.git","svn_url":"https://github.com/hallyn/lxd","homepage":"https://linuxcontainers.org","size":2456,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"lxc:master","ref":"master","sha":"b046fe9b248728027149e2d8c061a5fcfe94ca0a","user":{"login":"lxc","id":2301756,"avatar_url":"https://avatars.githubusercontent.com/u/2301756?v=3","gravatar_id":"","url":"https://api.github.com/users/lxc","html_url":"https://github.com/lxc","followers_url":"https://api.github.com/users/lxc/followers","following_url":"https://api.github.com/users/lxc/following{/other_user}","gists_url":"https://api.github.com/users/lxc/gists{/gist_id}","starred_url":"https://api.github.com/users/lxc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lxc/subscriptions","organizations_url":"https://api.github.com/users/lxc/orgs","repos_url":"https://api.github.com/users/lxc/repos","events_url":"https://api.github.com/users/lxc/events{/privacy}","received_events_url":"https://api.github.com/users/lxc/received_events","type":"Organization","site_admin":false},"repo":{"id":26192117,"name":"lxd","full_name":"lxc/lxd","owner":{"login":"lxc","id":2301756,"avatar_url":"https://avatars.githubusercontent.com/u/2301756?v=3","gravatar_id":"","url":"https://api.github.com/users/lxc","html_url":"https://github.com/lxc","followers_url":"https://api.github.com/users/lxc/followers","following_url":"https://api.github.com/users/lxc/following{/other_user}","gists_url":"https://api.github.com/users/lxc/gists{/gist_id}","starred_url":"https://api.github.com/users/lxc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lxc/subscriptions","organizations_url":"https://api.github.com/users/lxc/orgs","repos_url":"https://api.github.com/users/lxc/repos","events_url":"https://api.github.com/users/lxc/events{/privacy}","received_events_url":"https://api.github.com/users/lxc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lxc/lxd","description":"Daemon based on liblxc offering a REST API to manage containers","fork":false,"url":"https://api.github.com/repos/lxc/lxd","forks_url":"https://api.github.com/repos/lxc/lxd/forks","keys_url":"https://api.github.com/repos/lxc/lxd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lxc/lxd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lxc/lxd/teams","hooks_url":"https://api.github.com/repos/lxc/lxd/hooks","issue_events_url":"https://api.github.com/repos/lxc/lxd/issues/events{/number}","events_url":"https://api.github.com/repos/lxc/lxd/events","assignees_url":"https://api.github.com/repos/lxc/lxd/assignees{/user}","branches_url":"https://api.github.com/repos/lxc/lxd/branches{/branch}","tags_url":"https://api.github.com/repos/lxc/lxd/tags","blobs_url":"https://api.github.com/repos/lxc/lxd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lxc/lxd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lxc/lxd/git/refs{/sha}","trees_url":"https://api.github.com/repos/lxc/lxd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lxc/lxd/statuses/{sha}","languages_url":"https://api.github.com/repos/lxc/lxd/languages","stargazers_url":"https://api.github.com/repos/lxc/lxd/stargazers","contributors_url":"https://api.github.com/repos/lxc/lxd/contributors","subscribers_url":"https://api.github.com/repos/lxc/lxd/subscribers","subscription_url":"https://api.github.com/repos/lxc/lxd/subscription","commits_url":"https://api.github.com/repos/lxc/lxd/commits{/sha}","git_commits_url":"https://api.github.com/repos/lxc/lxd/git/commits{/sha}","comments_url":"https://api.github.com/repos/lxc/lxd/comments{/number}","issue_comment_url":"https://api.github.com/repos/lxc/lxd/issues/comments{/number}","contents_url":"https://api.github.com/repos/lxc/lxd/contents/{+path}","compare_url":"https://api.github.com/repos/lxc/lxd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lxc/lxd/merges","archive_url":"https://api.github.com/repos/lxc/lxd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lxc/lxd/downloads","issues_url":"https://api.github.com/repos/lxc/lxd/issues{/number}","pulls_url":"https://api.github.com/repos/lxc/lxd/pulls{/number}","milestones_url":"https://api.github.com/repos/lxc/lxd/milestones{/number}","notifications_url":"https://api.github.com/repos/lxc/lxd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lxc/lxd/labels{/name}","releases_url":"https://api.github.com/repos/lxc/lxd/releases{/id}","created_at":"2014-11-04T22:40:52Z","updated_at":"2015-04-27T12:12:23Z","pushed_at":"2015-04-27T12:12:23Z","git_url":"git://github.com/lxc/lxd.git","ssh_url":"git@github.com:lxc/lxd.git","clone_url":"https://github.com/lxc/lxd.git","svn_url":"https://github.com/lxc/lxd","homepage":"https://linuxcontainers.org","size":5216,"stargazers_count":362,"watchers_count":362,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":47,"mirror_url":null,"open_issues_count":43,"forks":47,"open_issues":43,"watchers":362,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lxc/lxd/pulls/542"},"html":{"href":"https://github.com/lxc/lxd/pull/542"},"issue":{"href":"https://api.github.com/repos/lxc/lxd/issues/542"},"comments":{"href":"https://api.github.com/repos/lxc/lxd/issues/542/comments"},"review_comments":{"href":"https://api.github.com/repos/lxc/lxd/pulls/542/comments"},"review_comment":{"href":"https://api.github.com/repos/lxc/lxd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lxc/lxd/pulls/542/commits"},"statuses":{"href":"https://api.github.com/repos/lxc/lxd/statuses/aceeddf454ddd0614ed6cb7f1773ab1b3246bae3"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"stgraber","id":2230599,"avatar_url":"https://avatars.githubusercontent.com/u/2230599?v=3","gravatar_id":"","url":"https://api.github.com/users/stgraber","html_url":"https://github.com/stgraber","followers_url":"https://api.github.com/users/stgraber/followers","following_url":"https://api.github.com/users/stgraber/following{/other_user}","gists_url":"https://api.github.com/users/stgraber/gists{/gist_id}","starred_url":"https://api.github.com/users/stgraber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stgraber/subscriptions","organizations_url":"https://api.github.com/users/stgraber/orgs","repos_url":"https://api.github.com/users/stgraber/repos","events_url":"https://api.github.com/users/stgraber/events{/privacy}","received_events_url":"https://api.github.com/users/stgraber/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":294,"deletions":2,"changed_files":2}}