{"action":"created","comment":{"url":"https://api.github.com/repos/youtube/vitess/pulls/comments/27078523","id":27078523,"diff_hunk":"@@ -164,10 +165,10 @@ func (dbcfgs *DBConfigs) String() string {\n \n // Redact will remove the password, so the object can be logged\n func (dbcfgs *DBConfigs) Redact() {\n-\tdbcfgs.App.ConnectionParams.Redact()\n-\tdbcfgs.Dba.Redact()\n-\tdbcfgs.Filtered.Redact()\n-\tdbcfgs.Repl.Redact()\n+\tdbcfgs.App.ConnectionParams.Pass = mysql.RedactedPassword","path":"go/vt/dbconfigs/dbconfigs.go","position":65,"original_position":65,"commit_id":"6391ef5a07198a6bea81dcf8d62cd5b7dd410465","original_commit_id":"6391ef5a07198a6bea81dcf8d62cd5b7dd410465","user":{"login":"enisoc","id":6733629,"avatar_url":"https://avatars.githubusercontent.com/u/6733629?v=3","gravatar_id":"","url":"https://api.github.com/users/enisoc","html_url":"https://github.com/enisoc","followers_url":"https://api.github.com/users/enisoc/followers","following_url":"https://api.github.com/users/enisoc/following{/other_user}","gists_url":"https://api.github.com/users/enisoc/gists{/gist_id}","starred_url":"https://api.github.com/users/enisoc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enisoc/subscriptions","organizations_url":"https://api.github.com/users/enisoc/orgs","repos_url":"https://api.github.com/users/enisoc/repos","events_url":"https://api.github.com/users/enisoc/events{/privacy}","received_events_url":"https://api.github.com/users/enisoc/received_events","type":"User","site_admin":false},"body":"Redacting passwords seems like a higher-level function than the level of the mysql connection driver. Maybe we should move mysql.RedactedPassword into package dbconfigs? Is mysql.RedactedPassword used anywhere else?","created_at":"2015-03-24T22:06:52Z","updated_at":"2015-03-24T22:06:52Z","html_url":"https://github.com/youtube/vitess/pull/515#discussion_r27078523","pull_request_url":"https://api.github.com/repos/youtube/vitess/pulls/515","_links":{"self":{"href":"https://api.github.com/repos/youtube/vitess/pulls/comments/27078523"},"html":{"href":"https://github.com/youtube/vitess/pull/515#discussion_r27078523"},"pull_request":{"href":"https://api.github.com/repos/youtube/vitess/pulls/515"}}},"pull_request":{"url":"https://api.github.com/repos/youtube/vitess/pulls/515","id":31801517,"html_url":"https://github.com/youtube/vitess/pull/515","diff_url":"https://github.com/youtube/vitess/pull/515.diff","patch_url":"https://github.com/youtube/vitess/pull/515.patch","issue_url":"https://api.github.com/repos/youtube/vitess/issues/515","number":515,"state":"open","locked":false,"title":"add SqlDBConn interface for low level db connection","user":{"login":"yaoshengzhe","id":626280,"avatar_url":"https://avatars.githubusercontent.com/u/626280?v=3","gravatar_id":"","url":"https://api.github.com/users/yaoshengzhe","html_url":"https://github.com/yaoshengzhe","followers_url":"https://api.github.com/users/yaoshengzhe/followers","following_url":"https://api.github.com/users/yaoshengzhe/following{/other_user}","gists_url":"https://api.github.com/users/yaoshengzhe/gists{/gist_id}","starred_url":"https://api.github.com/users/yaoshengzhe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yaoshengzhe/subscriptions","organizations_url":"https://api.github.com/users/yaoshengzhe/orgs","repos_url":"https://api.github.com/users/yaoshengzhe/repos","events_url":"https://api.github.com/users/yaoshengzhe/events{/privacy}","received_events_url":"https://api.github.com/users/yaoshengzhe/received_events","type":"User","site_admin":false},"body":"1. add SqlDBConn and move mysql.ConnectionParams to sqldbconn package\r\n2. change mysql.Connect function to return sqldbconn.SqlDBConn\r\n3. update places using *mysql.Connection to sqldbconn.SqlDBConn\r\n4. update places using *mysql.ConnectionParams to *sqldbconn.ConnectionParams\r\n5. define sqldbconn.NewSqlDBConnFunc factory method\r\n6. Some randome go style fix (suggested by golint)\r\n7. define package level variable NewSqlDBConn in sqldbconn\r\n8. create package mysqldbconn which inits sqldbconn.NewSqlDBConn to mysql.Connect","created_at":"2015-03-24T06:58:50Z","updated_at":"2015-03-24T22:06:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2786dc7b8f8bdc117cf33a33986605ffcd2c780a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/youtube/vitess/pulls/515/commits","review_comments_url":"https://api.github.com/repos/youtube/vitess/pulls/515/comments","review_comment_url":"https://api.github.com/repos/youtube/vitess/pulls/comments{/number}","comments_url":"https://api.github.com/repos/youtube/vitess/issues/515/comments","statuses_url":"https://api.github.com/repos/youtube/vitess/statuses/6391ef5a07198a6bea81dcf8d62cd5b7dd410465","head":{"label":"yaoshengzhe:fix_queryservice_unit_test_package_level_variable","ref":"fix_queryservice_unit_test_package_level_variable","sha":"6391ef5a07198a6bea81dcf8d62cd5b7dd410465","user":{"login":"yaoshengzhe","id":626280,"avatar_url":"https://avatars.githubusercontent.com/u/626280?v=3","gravatar_id":"","url":"https://api.github.com/users/yaoshengzhe","html_url":"https://github.com/yaoshengzhe","followers_url":"https://api.github.com/users/yaoshengzhe/followers","following_url":"https://api.github.com/users/yaoshengzhe/following{/other_user}","gists_url":"https://api.github.com/users/yaoshengzhe/gists{/gist_id}","starred_url":"https://api.github.com/users/yaoshengzhe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yaoshengzhe/subscriptions","organizations_url":"https://api.github.com/users/yaoshengzhe/orgs","repos_url":"https://api.github.com/users/yaoshengzhe/repos","events_url":"https://api.github.com/users/yaoshengzhe/events{/privacy}","received_events_url":"https://api.github.com/users/yaoshengzhe/received_events","type":"User","site_admin":false},"repo":{"id":27459467,"name":"vitess","full_name":"yaoshengzhe/vitess","owner":{"login":"yaoshengzhe","id":626280,"avatar_url":"https://avatars.githubusercontent.com/u/626280?v=3","gravatar_id":"","url":"https://api.github.com/users/yaoshengzhe","html_url":"https://github.com/yaoshengzhe","followers_url":"https://api.github.com/users/yaoshengzhe/followers","following_url":"https://api.github.com/users/yaoshengzhe/following{/other_user}","gists_url":"https://api.github.com/users/yaoshengzhe/gists{/gist_id}","starred_url":"https://api.github.com/users/yaoshengzhe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yaoshengzhe/subscriptions","organizations_url":"https://api.github.com/users/yaoshengzhe/orgs","repos_url":"https://api.github.com/users/yaoshengzhe/repos","events_url":"https://api.github.com/users/yaoshengzhe/events{/privacy}","received_events_url":"https://api.github.com/users/yaoshengzhe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yaoshengzhe/vitess","description":"vitess provides servers and tools which facilitate scaling of MySQL databases for large scale web services.","fork":true,"url":"https://api.github.com/repos/yaoshengzhe/vitess","forks_url":"https://api.github.com/repos/yaoshengzhe/vitess/forks","keys_url":"https://api.github.com/repos/yaoshengzhe/vitess/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yaoshengzhe/vitess/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yaoshengzhe/vitess/teams","hooks_url":"https://api.github.com/repos/yaoshengzhe/vitess/hooks","issue_events_url":"https://api.github.com/repos/yaoshengzhe/vitess/issues/events{/number}","events_url":"https://api.github.com/repos/yaoshengzhe/vitess/events","assignees_url":"https://api.github.com/repos/yaoshengzhe/vitess/assignees{/user}","branches_url":"https://api.github.com/repos/yaoshengzhe/vitess/branches{/branch}","tags_url":"https://api.github.com/repos/yaoshengzhe/vitess/tags","blobs_url":"https://api.github.com/repos/yaoshengzhe/vitess/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yaoshengzhe/vitess/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yaoshengzhe/vitess/git/refs{/sha}","trees_url":"https://api.github.com/repos/yaoshengzhe/vitess/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yaoshengzhe/vitess/statuses/{sha}","languages_url":"https://api.github.com/repos/yaoshengzhe/vitess/languages","stargazers_url":"https://api.github.com/repos/yaoshengzhe/vitess/stargazers","contributors_url":"https://api.github.com/repos/yaoshengzhe/vitess/contributors","subscribers_url":"https://api.github.com/repos/yaoshengzhe/vitess/subscribers","subscription_url":"https://api.github.com/repos/yaoshengzhe/vitess/subscription","commits_url":"https://api.github.com/repos/yaoshengzhe/vitess/commits{/sha}","git_commits_url":"https://api.github.com/repos/yaoshengzhe/vitess/git/commits{/sha}","comments_url":"https://api.github.com/repos/yaoshengzhe/vitess/comments{/number}","issue_comment_url":"https://api.github.com/repos/yaoshengzhe/vitess/issues/comments{/number}","contents_url":"https://api.github.com/repos/yaoshengzhe/vitess/contents/{+path}","compare_url":"https://api.github.com/repos/yaoshengzhe/vitess/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yaoshengzhe/vitess/merges","archive_url":"https://api.github.com/repos/yaoshengzhe/vitess/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yaoshengzhe/vitess/downloads","issues_url":"https://api.github.com/repos/yaoshengzhe/vitess/issues{/number}","pulls_url":"https://api.github.com/repos/yaoshengzhe/vitess/pulls{/number}","milestones_url":"https://api.github.com/repos/yaoshengzhe/vitess/milestones{/number}","notifications_url":"https://api.github.com/repos/yaoshengzhe/vitess/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yaoshengzhe/vitess/labels{/name}","releases_url":"https://api.github.com/repos/yaoshengzhe/vitess/releases{/id}","created_at":"2014-12-02T23:45:03Z","updated_at":"2015-03-24T17:54:45Z","pushed_at":"2015-03-24T21:29:32Z","git_url":"git://github.com/yaoshengzhe/vitess.git","ssh_url":"git@github.com:yaoshengzhe/vitess.git","clone_url":"https://github.com/yaoshengzhe/vitess.git","svn_url":"https://github.com/yaoshengzhe/vitess","homepage":null,"size":43425,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"youtube:master","ref":"master","sha":"8e15c4c78063418538f6b381f0226c55343529ec","user":{"login":"youtube","id":4052902,"avatar_url":"https://avatars.githubusercontent.com/u/4052902?v=3","gravatar_id":"","url":"https://api.github.com/users/youtube","html_url":"https://github.com/youtube","followers_url":"https://api.github.com/users/youtube/followers","following_url":"https://api.github.com/users/youtube/following{/other_user}","gists_url":"https://api.github.com/users/youtube/gists{/gist_id}","starred_url":"https://api.github.com/users/youtube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/youtube/subscriptions","organizations_url":"https://api.github.com/users/youtube/orgs","repos_url":"https://api.github.com/users/youtube/repos","events_url":"https://api.github.com/users/youtube/events{/privacy}","received_events_url":"https://api.github.com/users/youtube/received_events","type":"Organization","site_admin":false},"repo":{"id":11008207,"name":"vitess","full_name":"youtube/vitess","owner":{"login":"youtube","id":4052902,"avatar_url":"https://avatars.githubusercontent.com/u/4052902?v=3","gravatar_id":"","url":"https://api.github.com/users/youtube","html_url":"https://github.com/youtube","followers_url":"https://api.github.com/users/youtube/followers","following_url":"https://api.github.com/users/youtube/following{/other_user}","gists_url":"https://api.github.com/users/youtube/gists{/gist_id}","starred_url":"https://api.github.com/users/youtube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/youtube/subscriptions","organizations_url":"https://api.github.com/users/youtube/orgs","repos_url":"https://api.github.com/users/youtube/repos","events_url":"https://api.github.com/users/youtube/events{/privacy}","received_events_url":"https://api.github.com/users/youtube/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/youtube/vitess","description":"vitess provides servers and tools which facilitate scaling of MySQL databases for large scale web services.","fork":false,"url":"https://api.github.com/repos/youtube/vitess","forks_url":"https://api.github.com/repos/youtube/vitess/forks","keys_url":"https://api.github.com/repos/youtube/vitess/keys{/key_id}","collaborators_url":"https://api.github.com/repos/youtube/vitess/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/youtube/vitess/teams","hooks_url":"https://api.github.com/repos/youtube/vitess/hooks","issue_events_url":"https://api.github.com/repos/youtube/vitess/issues/events{/number}","events_url":"https://api.github.com/repos/youtube/vitess/events","assignees_url":"https://api.github.com/repos/youtube/vitess/assignees{/user}","branches_url":"https://api.github.com/repos/youtube/vitess/branches{/branch}","tags_url":"https://api.github.com/repos/youtube/vitess/tags","blobs_url":"https://api.github.com/repos/youtube/vitess/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/youtube/vitess/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/youtube/vitess/git/refs{/sha}","trees_url":"https://api.github.com/repos/youtube/vitess/git/trees{/sha}","statuses_url":"https://api.github.com/repos/youtube/vitess/statuses/{sha}","languages_url":"https://api.github.com/repos/youtube/vitess/languages","stargazers_url":"https://api.github.com/repos/youtube/vitess/stargazers","contributors_url":"https://api.github.com/repos/youtube/vitess/contributors","subscribers_url":"https://api.github.com/repos/youtube/vitess/subscribers","subscription_url":"https://api.github.com/repos/youtube/vitess/subscription","commits_url":"https://api.github.com/repos/youtube/vitess/commits{/sha}","git_commits_url":"https://api.github.com/repos/youtube/vitess/git/commits{/sha}","comments_url":"https://api.github.com/repos/youtube/vitess/comments{/number}","issue_comment_url":"https://api.github.com/repos/youtube/vitess/issues/comments{/number}","contents_url":"https://api.github.com/repos/youtube/vitess/contents/{+path}","compare_url":"https://api.github.com/repos/youtube/vitess/compare/{base}...{head}","merges_url":"https://api.github.com/repos/youtube/vitess/merges","archive_url":"https://api.github.com/repos/youtube/vitess/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/youtube/vitess/downloads","issues_url":"https://api.github.com/repos/youtube/vitess/issues{/number}","pulls_url":"https://api.github.com/repos/youtube/vitess/pulls{/number}","milestones_url":"https://api.github.com/repos/youtube/vitess/milestones{/number}","notifications_url":"https://api.github.com/repos/youtube/vitess/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/youtube/vitess/labels{/name}","releases_url":"https://api.github.com/repos/youtube/vitess/releases{/id}","created_at":"2013-06-27T21:20:28Z","updated_at":"2015-03-24T19:41:44Z","pushed_at":"2015-03-24T21:29:33Z","git_url":"git://github.com/youtube/vitess.git","ssh_url":"git@github.com:youtube/vitess.git","clone_url":"https://github.com/youtube/vitess.git","svn_url":"https://github.com/youtube/vitess","homepage":null,"size":64196,"stargazers_count":2336,"watchers_count":2336,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":270,"mirror_url":null,"open_issues_count":15,"forks":270,"open_issues":15,"watchers":2336,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/youtube/vitess/pulls/515"},"html":{"href":"https://github.com/youtube/vitess/pull/515"},"issue":{"href":"https://api.github.com/repos/youtube/vitess/issues/515"},"comments":{"href":"https://api.github.com/repos/youtube/vitess/issues/515/comments"},"review_comments":{"href":"https://api.github.com/repos/youtube/vitess/pulls/515/comments"},"review_comment":{"href":"https://api.github.com/repos/youtube/vitess/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/youtube/vitess/pulls/515/commits"},"statuses":{"href":"https://api.github.com/repos/youtube/vitess/statuses/6391ef5a07198a6bea81dcf8d62cd5b7dd410465"}}}}