{"action":"closed","number":866,"pull_request":{"url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/pulls/866","id":45166298,"html_url":"https://github.com/Geoportail-Luxembourg/geoportailv3/pull/866","diff_url":"https://github.com/Geoportail-Luxembourg/geoportailv3/pull/866.diff","patch_url":"https://github.com/Geoportail-Luxembourg/geoportailv3/pull/866.patch","issue_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/issues/866","number":866,"state":"closed","locked":false,"title":"Feature popup","user":{"login":"pgiraud","id":319774,"avatar_url":"https://avatars.githubusercontent.com/u/319774?v=3","gravatar_id":"","url":"https://api.github.com/users/pgiraud","html_url":"https://github.com/pgiraud","followers_url":"https://api.github.com/users/pgiraud/followers","following_url":"https://api.github.com/users/pgiraud/following{/other_user}","gists_url":"https://api.github.com/users/pgiraud/gists{/gist_id}","starred_url":"https://api.github.com/users/pgiraud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pgiraud/subscriptions","organizations_url":"https://api.github.com/users/pgiraud/orgs","repos_url":"https://api.github.com/users/pgiraud/repos","events_url":"https://api.github.com/users/pgiraud/events{/privacy}","received_events_url":"https://api.github.com/users/pgiraud/received_events","type":"User","site_admin":false},"body":"This pull request main goal is to display a popup when a feature is selected (on the map or via the list in mymaps block).\r\nAs for now, the popup shows name and title in a read only mode and user is able to modify those attributes.\r\n\r\nNext steps are :\r\n - add style editing,\r\n - enable feature geometry modification,\r\n - allow user to remove feature.\r\n\r\nA first review would be much appreciated.\r\n","created_at":"2015-09-16T12:42:52Z","updated_at":"2015-09-23T12:38:02Z","closed_at":"2015-09-23T12:38:02Z","merged_at":"2015-09-23T12:38:02Z","merge_commit_sha":"5e5a6a1d6a9031d07cfbbcef3007e691244c79b9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/pulls/866/commits","review_comments_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/pulls/866/comments","review_comment_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/issues/866/comments","statuses_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/statuses/b8489b3a6cd581a3b6a317b7637b83f63f8f285e","head":{"label":"Geoportail-Luxembourg:pgiraud_feature_popup","ref":"pgiraud_feature_popup","sha":"b8489b3a6cd581a3b6a317b7637b83f63f8f285e","user":{"login":"Geoportail-Luxembourg","id":5592884,"avatar_url":"https://avatars.githubusercontent.com/u/5592884?v=3","gravatar_id":"","url":"https://api.github.com/users/Geoportail-Luxembourg","html_url":"https://github.com/Geoportail-Luxembourg","followers_url":"https://api.github.com/users/Geoportail-Luxembourg/followers","following_url":"https://api.github.com/users/Geoportail-Luxembourg/following{/other_user}","gists_url":"https://api.github.com/users/Geoportail-Luxembourg/gists{/gist_id}","starred_url":"https://api.github.com/users/Geoportail-Luxembourg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Geoportail-Luxembourg/subscriptions","organizations_url":"https://api.github.com/users/Geoportail-Luxembourg/orgs","repos_url":"https://api.github.com/users/Geoportail-Luxembourg/repos","events_url":"https://api.github.com/users/Geoportail-Luxembourg/events{/privacy}","received_events_url":"https://api.github.com/users/Geoportail-Luxembourg/received_events","type":"Organization","site_admin":false},"repo":{"id":24669372,"name":"geoportailv3","full_name":"Geoportail-Luxembourg/geoportailv3","owner":{"login":"Geoportail-Luxembourg","id":5592884,"avatar_url":"https://avatars.githubusercontent.com/u/5592884?v=3","gravatar_id":"","url":"https://api.github.com/users/Geoportail-Luxembourg","html_url":"https://github.com/Geoportail-Luxembourg","followers_url":"https://api.github.com/users/Geoportail-Luxembourg/followers","following_url":"https://api.github.com/users/Geoportail-Luxembourg/following{/other_user}","gists_url":"https://api.github.com/users/Geoportail-Luxembourg/gists{/gist_id}","starred_url":"https://api.github.com/users/Geoportail-Luxembourg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Geoportail-Luxembourg/subscriptions","organizations_url":"https://api.github.com/users/Geoportail-Luxembourg/orgs","repos_url":"https://api.github.com/users/Geoportail-Luxembourg/repos","events_url":"https://api.github.com/users/Geoportail-Luxembourg/events{/privacy}","received_events_url":"https://api.github.com/users/Geoportail-Luxembourg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Geoportail-Luxembourg/geoportailv3","description":"geoportailv3 is the implementation of the v3 of the map viewer of the luxembourgish geoportal","fork":false,"url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3","forks_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/forks","keys_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/teams","hooks_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/hooks","issue_events_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/issues/events{/number}","events_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/events","assignees_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/assignees{/user}","branches_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/branches{/branch}","tags_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/tags","blobs_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/git/refs{/sha}","trees_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/statuses/{sha}","languages_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/languages","stargazers_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/stargazers","contributors_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/contributors","subscribers_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/subscribers","subscription_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/subscription","commits_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/commits{/sha}","git_commits_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/git/commits{/sha}","comments_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/comments{/number}","issue_comment_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/issues/comments{/number}","contents_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/contents/{+path}","compare_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/merges","archive_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/downloads","issues_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/issues{/number}","pulls_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/pulls{/number}","milestones_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/milestones{/number}","notifications_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/labels{/name}","releases_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/releases{/id}","created_at":"2014-10-01T07:23:27Z","updated_at":"2015-08-11T14:30:31Z","pushed_at":"2015-09-23T12:38:02Z","git_url":"git://github.com/Geoportail-Luxembourg/geoportailv3.git","ssh_url":"git@github.com:Geoportail-Luxembourg/geoportailv3.git","clone_url":"https://github.com/Geoportail-Luxembourg/geoportailv3.git","svn_url":"https://github.com/Geoportail-Luxembourg/geoportailv3","homepage":"","size":114126,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":84,"forks":1,"open_issues":84,"watchers":5,"default_branch":"master"}},"base":{"label":"Geoportail-Luxembourg:master","ref":"master","sha":"4724bb31ef16a7d503fd89612e1376cdaabebc79","user":{"login":"Geoportail-Luxembourg","id":5592884,"avatar_url":"https://avatars.githubusercontent.com/u/5592884?v=3","gravatar_id":"","url":"https://api.github.com/users/Geoportail-Luxembourg","html_url":"https://github.com/Geoportail-Luxembourg","followers_url":"https://api.github.com/users/Geoportail-Luxembourg/followers","following_url":"https://api.github.com/users/Geoportail-Luxembourg/following{/other_user}","gists_url":"https://api.github.com/users/Geoportail-Luxembourg/gists{/gist_id}","starred_url":"https://api.github.com/users/Geoportail-Luxembourg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Geoportail-Luxembourg/subscriptions","organizations_url":"https://api.github.com/users/Geoportail-Luxembourg/orgs","repos_url":"https://api.github.com/users/Geoportail-Luxembourg/repos","events_url":"https://api.github.com/users/Geoportail-Luxembourg/events{/privacy}","received_events_url":"https://api.github.com/users/Geoportail-Luxembourg/received_events","type":"Organization","site_admin":false},"repo":{"id":24669372,"name":"geoportailv3","full_name":"Geoportail-Luxembourg/geoportailv3","owner":{"login":"Geoportail-Luxembourg","id":5592884,"avatar_url":"https://avatars.githubusercontent.com/u/5592884?v=3","gravatar_id":"","url":"https://api.github.com/users/Geoportail-Luxembourg","html_url":"https://github.com/Geoportail-Luxembourg","followers_url":"https://api.github.com/users/Geoportail-Luxembourg/followers","following_url":"https://api.github.com/users/Geoportail-Luxembourg/following{/other_user}","gists_url":"https://api.github.com/users/Geoportail-Luxembourg/gists{/gist_id}","starred_url":"https://api.github.com/users/Geoportail-Luxembourg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Geoportail-Luxembourg/subscriptions","organizations_url":"https://api.github.com/users/Geoportail-Luxembourg/orgs","repos_url":"https://api.github.com/users/Geoportail-Luxembourg/repos","events_url":"https://api.github.com/users/Geoportail-Luxembourg/events{/privacy}","received_events_url":"https://api.github.com/users/Geoportail-Luxembourg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Geoportail-Luxembourg/geoportailv3","description":"geoportailv3 is the implementation of the v3 of the map viewer of the luxembourgish geoportal","fork":false,"url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3","forks_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/forks","keys_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/teams","hooks_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/hooks","issue_events_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/issues/events{/number}","events_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/events","assignees_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/assignees{/user}","branches_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/branches{/branch}","tags_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/tags","blobs_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/git/refs{/sha}","trees_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/statuses/{sha}","languages_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/languages","stargazers_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/stargazers","contributors_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/contributors","subscribers_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/subscribers","subscription_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/subscription","commits_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/commits{/sha}","git_commits_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/git/commits{/sha}","comments_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/comments{/number}","issue_comment_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/issues/comments{/number}","contents_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/contents/{+path}","compare_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/merges","archive_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/downloads","issues_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/issues{/number}","pulls_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/pulls{/number}","milestones_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/milestones{/number}","notifications_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/labels{/name}","releases_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/releases{/id}","created_at":"2014-10-01T07:23:27Z","updated_at":"2015-08-11T14:30:31Z","pushed_at":"2015-09-23T12:38:02Z","git_url":"git://github.com/Geoportail-Luxembourg/geoportailv3.git","ssh_url":"git@github.com:Geoportail-Luxembourg/geoportailv3.git","clone_url":"https://github.com/Geoportail-Luxembourg/geoportailv3.git","svn_url":"https://github.com/Geoportail-Luxembourg/geoportailv3","homepage":"","size":114126,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":84,"forks":1,"open_issues":84,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/pulls/866"},"html":{"href":"https://github.com/Geoportail-Luxembourg/geoportailv3/pull/866"},"issue":{"href":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/issues/866"},"comments":{"href":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/issues/866/comments"},"review_comments":{"href":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/pulls/866/comments"},"review_comment":{"href":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/pulls/866/commits"},"statuses":{"href":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/statuses/b8489b3a6cd581a3b6a317b7637b83f63f8f285e"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"pgiraud","id":319774,"avatar_url":"https://avatars.githubusercontent.com/u/319774?v=3","gravatar_id":"","url":"https://api.github.com/users/pgiraud","html_url":"https://github.com/pgiraud","followers_url":"https://api.github.com/users/pgiraud/followers","following_url":"https://api.github.com/users/pgiraud/following{/other_user}","gists_url":"https://api.github.com/users/pgiraud/gists{/gist_id}","starred_url":"https://api.github.com/users/pgiraud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pgiraud/subscriptions","organizations_url":"https://api.github.com/users/pgiraud/orgs","repos_url":"https://api.github.com/users/pgiraud/repos","events_url":"https://api.github.com/users/pgiraud/events{/privacy}","received_events_url":"https://api.github.com/users/pgiraud/received_events","type":"User","site_admin":false},"comments":6,"review_comments":19,"commits":26,"additions":1007,"deletions":64,"changed_files":15}}