{"action":"created","comment":{"url":"https://api.github.com/repos/jimweirich/rake/pulls/comments/43435926","id":43435926,"diff_hunk":"@@ -604,5 +604,9 @@ def rakefile_location backtrace = caller\n \n       backtrace.find { |str| str =~ re } || ''\n     end\n+\n+  private\n+    FIXNUM_MAX = (2**(0.size * 8 - 2) - 1) # :nodoc:\n+    ","path":"lib/rake/application.rb","position":16,"original_position":16,"commit_id":"70f2b26aa8991cf6822d7b1330fdb9362ce7a524","original_commit_id":"70f2b26aa8991cf6822d7b1330fdb9362ce7a524","user":{"login":"pvdb","id":17322,"avatar_url":"https://avatars.githubusercontent.com/u/17322?v=3","gravatar_id":"","url":"https://api.github.com/users/pvdb","html_url":"https://github.com/pvdb","followers_url":"https://api.github.com/users/pvdb/followers","following_url":"https://api.github.com/users/pvdb/following{/other_user}","gists_url":"https://api.github.com/users/pvdb/gists{/gist_id}","starred_url":"https://api.github.com/users/pvdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pvdb/subscriptions","organizations_url":"https://api.github.com/users/pvdb/orgs","repos_url":"https://api.github.com/users/pvdb/repos","events_url":"https://api.github.com/users/pvdb/events{/privacy}","received_events_url":"https://api.github.com/users/pvdb/received_events","type":"User","site_admin":false},"body":"Or go straight to ruby/rake#82 for a more future-proof implementation of the constant!","created_at":"2015-10-29T19:54:45Z","updated_at":"2015-10-29T19:54:45Z","html_url":"https://github.com/jimweirich/rake/pull/135#discussion_r43435926","pull_request_url":"https://api.github.com/repos/jimweirich/rake/pulls/135","_links":{"self":{"href":"https://api.github.com/repos/jimweirich/rake/pulls/comments/43435926"},"html":{"href":"https://github.com/jimweirich/rake/pull/135#discussion_r43435926"},"pull_request":{"href":"https://api.github.com/repos/jimweirich/rake/pulls/135"}}},"pull_request":{"url":"https://api.github.com/repos/jimweirich/rake/pulls/135","id":2750773,"html_url":"https://github.com/jimweirich/rake/pull/135","diff_url":"https://github.com/jimweirich/rake/pull/135.diff","patch_url":"https://github.com/jimweirich/rake/pull/135.patch","issue_url":"https://api.github.com/repos/jimweirich/rake/issues/135","number":135,"state":"closed","locked":false,"title":"Cleaned up the ThreadPool interface","user":{"login":"michaeljbishop","id":1656845,"avatar_url":"https://avatars.githubusercontent.com/u/1656845?v=3","gravatar_id":"","url":"https://api.github.com/users/michaeljbishop","html_url":"https://github.com/michaeljbishop","followers_url":"https://api.github.com/users/michaeljbishop/followers","following_url":"https://api.github.com/users/michaeljbishop/following{/other_user}","gists_url":"https://api.github.com/users/michaeljbishop/gists{/gist_id}","starred_url":"https://api.github.com/users/michaeljbishop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaeljbishop/subscriptions","organizations_url":"https://api.github.com/users/michaeljbishop/orgs","repos_url":"https://api.github.com/users/michaeljbishop/repos","events_url":"https://api.github.com/users/michaeljbishop/events{/privacy}","received_events_url":"https://api.github.com/users/michaeljbishop/received_events","type":"User","site_admin":false},"body":"Since the `ThreadPool` as currently checked into Rake 0.9.3.beta.2 is a public api, this change ensures that api is minimal, documented, and exposes the fewest dependencies necessary to function, allowing for future and gradual, expansion.\r\n\r\nMost notably, the interface is completely documented and certain private things are hidden from documentation.\r\n\r\nThe futures returned by `ThreadPool#future` are of an undocumented type, but are guaranteed to have a `#value` method which will return the value of the future.\r\n","created_at":"2012-10-24T00:28:52Z","updated_at":"2015-10-29T19:54:45Z","closed_at":"2012-10-24T14:39:44Z","merged_at":"2012-10-24T14:39:44Z","merge_commit_sha":"","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jimweirich/rake/pulls/135/commits","review_comments_url":"https://api.github.com/repos/jimweirich/rake/pulls/135/comments","review_comment_url":"https://api.github.com/repos/jimweirich/rake/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jimweirich/rake/issues/135/comments","statuses_url":"https://api.github.com/repos/jimweirich/rake/statuses/70f2b26aa8991cf6822d7b1330fdb9362ce7a524","head":{"label":"michaeljbishop:added-thread-pool-to-multitask","ref":"added-thread-pool-to-multitask","sha":"70f2b26aa8991cf6822d7b1330fdb9362ce7a524","user":{"login":"michaeljbishop","id":1656845,"avatar_url":"https://avatars.githubusercontent.com/u/1656845?v=3","gravatar_id":"","url":"https://api.github.com/users/michaeljbishop","html_url":"https://github.com/michaeljbishop","followers_url":"https://api.github.com/users/michaeljbishop/followers","following_url":"https://api.github.com/users/michaeljbishop/following{/other_user}","gists_url":"https://api.github.com/users/michaeljbishop/gists{/gist_id}","starred_url":"https://api.github.com/users/michaeljbishop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaeljbishop/subscriptions","organizations_url":"https://api.github.com/users/michaeljbishop/orgs","repos_url":"https://api.github.com/users/michaeljbishop/repos","events_url":"https://api.github.com/users/michaeljbishop/events{/privacy}","received_events_url":"https://api.github.com/users/michaeljbishop/received_events","type":"User","site_admin":false},"repo":{"id":6210242,"name":"rake","full_name":"michaeljbishop/rake","owner":{"login":"michaeljbishop","id":1656845,"avatar_url":"https://avatars.githubusercontent.com/u/1656845?v=3","gravatar_id":"","url":"https://api.github.com/users/michaeljbishop","html_url":"https://github.com/michaeljbishop","followers_url":"https://api.github.com/users/michaeljbishop/followers","following_url":"https://api.github.com/users/michaeljbishop/following{/other_user}","gists_url":"https://api.github.com/users/michaeljbishop/gists{/gist_id}","starred_url":"https://api.github.com/users/michaeljbishop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaeljbishop/subscriptions","organizations_url":"https://api.github.com/users/michaeljbishop/orgs","repos_url":"https://api.github.com/users/michaeljbishop/repos","events_url":"https://api.github.com/users/michaeljbishop/events{/privacy}","received_events_url":"https://api.github.com/users/michaeljbishop/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/michaeljbishop/rake","description":"A make-like build utility for Ruby.","fork":true,"url":"https://api.github.com/repos/michaeljbishop/rake","forks_url":"https://api.github.com/repos/michaeljbishop/rake/forks","keys_url":"https://api.github.com/repos/michaeljbishop/rake/keys{/key_id}","collaborators_url":"https://api.github.com/repos/michaeljbishop/rake/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/michaeljbishop/rake/teams","hooks_url":"https://api.github.com/repos/michaeljbishop/rake/hooks","issue_events_url":"https://api.github.com/repos/michaeljbishop/rake/issues/events{/number}","events_url":"https://api.github.com/repos/michaeljbishop/rake/events","assignees_url":"https://api.github.com/repos/michaeljbishop/rake/assignees{/user}","branches_url":"https://api.github.com/repos/michaeljbishop/rake/branches{/branch}","tags_url":"https://api.github.com/repos/michaeljbishop/rake/tags","blobs_url":"https://api.github.com/repos/michaeljbishop/rake/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/michaeljbishop/rake/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/michaeljbishop/rake/git/refs{/sha}","trees_url":"https://api.github.com/repos/michaeljbishop/rake/git/trees{/sha}","statuses_url":"https://api.github.com/repos/michaeljbishop/rake/statuses/{sha}","languages_url":"https://api.github.com/repos/michaeljbishop/rake/languages","stargazers_url":"https://api.github.com/repos/michaeljbishop/rake/stargazers","contributors_url":"https://api.github.com/repos/michaeljbishop/rake/contributors","subscribers_url":"https://api.github.com/repos/michaeljbishop/rake/subscribers","subscription_url":"https://api.github.com/repos/michaeljbishop/rake/subscription","commits_url":"https://api.github.com/repos/michaeljbishop/rake/commits{/sha}","git_commits_url":"https://api.github.com/repos/michaeljbishop/rake/git/commits{/sha}","comments_url":"https://api.github.com/repos/michaeljbishop/rake/comments{/number}","issue_comment_url":"https://api.github.com/repos/michaeljbishop/rake/issues/comments{/number}","contents_url":"https://api.github.com/repos/michaeljbishop/rake/contents/{+path}","compare_url":"https://api.github.com/repos/michaeljbishop/rake/compare/{base}...{head}","merges_url":"https://api.github.com/repos/michaeljbishop/rake/merges","archive_url":"https://api.github.com/repos/michaeljbishop/rake/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/michaeljbishop/rake/downloads","issues_url":"https://api.github.com/repos/michaeljbishop/rake/issues{/number}","pulls_url":"https://api.github.com/repos/michaeljbishop/rake/pulls{/number}","milestones_url":"https://api.github.com/repos/michaeljbishop/rake/milestones{/number}","notifications_url":"https://api.github.com/repos/michaeljbishop/rake/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/michaeljbishop/rake/labels{/name}","releases_url":"https://api.github.com/repos/michaeljbishop/rake/releases{/id}","created_at":"2012-10-14T03:36:29Z","updated_at":"2014-11-26T09:53:18Z","pushed_at":"2012-11-24T17:54:46Z","git_url":"git://github.com/michaeljbishop/rake.git","ssh_url":"git@github.com:michaeljbishop/rake.git","clone_url":"https://github.com/michaeljbishop/rake.git","svn_url":"https://github.com/michaeljbishop/rake","homepage":"http://rake.rubyforge.org/","size":2919,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jimweirich:master","ref":"master","sha":"f234932626d5c2e3896b6fe7983b579d3254c168","user":{"login":"jimweirich","id":4017,"avatar_url":"https://avatars.githubusercontent.com/u/4017?v=3","gravatar_id":"","url":"https://api.github.com/users/jimweirich","html_url":"https://github.com/jimweirich","followers_url":"https://api.github.com/users/jimweirich/followers","following_url":"https://api.github.com/users/jimweirich/following{/other_user}","gists_url":"https://api.github.com/users/jimweirich/gists{/gist_id}","starred_url":"https://api.github.com/users/jimweirich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimweirich/subscriptions","organizations_url":"https://api.github.com/users/jimweirich/orgs","repos_url":"https://api.github.com/users/jimweirich/repos","events_url":"https://api.github.com/users/jimweirich/events{/privacy}","received_events_url":"https://api.github.com/users/jimweirich/received_events","type":"User","site_admin":false},"repo":{"id":30745,"name":"rake","full_name":"jimweirich/rake","owner":{"login":"jimweirich","id":4017,"avatar_url":"https://avatars.githubusercontent.com/u/4017?v=3","gravatar_id":"","url":"https://api.github.com/users/jimweirich","html_url":"https://github.com/jimweirich","followers_url":"https://api.github.com/users/jimweirich/followers","following_url":"https://api.github.com/users/jimweirich/following{/other_user}","gists_url":"https://api.github.com/users/jimweirich/gists{/gist_id}","starred_url":"https://api.github.com/users/jimweirich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimweirich/subscriptions","organizations_url":"https://api.github.com/users/jimweirich/orgs","repos_url":"https://api.github.com/users/jimweirich/repos","events_url":"https://api.github.com/users/jimweirich/events{/privacy}","received_events_url":"https://api.github.com/users/jimweirich/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jimweirich/rake","description":"A make-like build utility for Ruby.","fork":true,"url":"https://api.github.com/repos/jimweirich/rake","forks_url":"https://api.github.com/repos/jimweirich/rake/forks","keys_url":"https://api.github.com/repos/jimweirich/rake/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jimweirich/rake/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jimweirich/rake/teams","hooks_url":"https://api.github.com/repos/jimweirich/rake/hooks","issue_events_url":"https://api.github.com/repos/jimweirich/rake/issues/events{/number}","events_url":"https://api.github.com/repos/jimweirich/rake/events","assignees_url":"https://api.github.com/repos/jimweirich/rake/assignees{/user}","branches_url":"https://api.github.com/repos/jimweirich/rake/branches{/branch}","tags_url":"https://api.github.com/repos/jimweirich/rake/tags","blobs_url":"https://api.github.com/repos/jimweirich/rake/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jimweirich/rake/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jimweirich/rake/git/refs{/sha}","trees_url":"https://api.github.com/repos/jimweirich/rake/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jimweirich/rake/statuses/{sha}","languages_url":"https://api.github.com/repos/jimweirich/rake/languages","stargazers_url":"https://api.github.com/repos/jimweirich/rake/stargazers","contributors_url":"https://api.github.com/repos/jimweirich/rake/contributors","subscribers_url":"https://api.github.com/repos/jimweirich/rake/subscribers","subscription_url":"https://api.github.com/repos/jimweirich/rake/subscription","commits_url":"https://api.github.com/repos/jimweirich/rake/commits{/sha}","git_commits_url":"https://api.github.com/repos/jimweirich/rake/git/commits{/sha}","comments_url":"https://api.github.com/repos/jimweirich/rake/comments{/number}","issue_comment_url":"https://api.github.com/repos/jimweirich/rake/issues/comments{/number}","contents_url":"https://api.github.com/repos/jimweirich/rake/contents/{+path}","compare_url":"https://api.github.com/repos/jimweirich/rake/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jimweirich/rake/merges","archive_url":"https://api.github.com/repos/jimweirich/rake/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jimweirich/rake/downloads","issues_url":"https://api.github.com/repos/jimweirich/rake/issues{/number}","pulls_url":"https://api.github.com/repos/jimweirich/rake/pulls{/number}","milestones_url":"https://api.github.com/repos/jimweirich/rake/milestones{/number}","notifications_url":"https://api.github.com/repos/jimweirich/rake/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jimweirich/rake/labels{/name}","releases_url":"https://api.github.com/repos/jimweirich/rake/releases{/id}","created_at":"2008-07-03T00:32:25Z","updated_at":"2015-10-25T18:54:27Z","pushed_at":"2014-11-25T02:07:23Z","git_url":"git://github.com/jimweirich/rake.git","ssh_url":"git@github.com:jimweirich/rake.git","clone_url":"https://github.com/jimweirich/rake.git","svn_url":"https://github.com/jimweirich/rake","homepage":"http://rake.rubyforge.org/","size":6789,"stargazers_count":1186,"watchers_count":1186,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"open_issues_count":5,"forks":2,"open_issues":5,"watchers":1186,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jimweirich/rake/pulls/135"},"html":{"href":"https://github.com/jimweirich/rake/pull/135"},"issue":{"href":"https://api.github.com/repos/jimweirich/rake/issues/135"},"comments":{"href":"https://api.github.com/repos/jimweirich/rake/issues/135/comments"},"review_comments":{"href":"https://api.github.com/repos/jimweirich/rake/pulls/135/comments"},"review_comment":{"href":"https://api.github.com/repos/jimweirich/rake/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jimweirich/rake/pulls/135/commits"},"statuses":{"href":"https://api.github.com/repos/jimweirich/rake/statuses/70f2b26aa8991cf6822d7b1330fdb9362ce7a524"}}}}