{"action":"created","comment":{"url":"https://api.github.com/repos/DeDiS/cothority/pulls/comments/45045686","id":45045686,"diff_hunk":"@@ -18,31 +18,51 @@ import (\n var Sink = \"0.0.0.0\"","path":"lib/monitor/monitor.go","position":1,"original_position":1,"commit_id":"4cad4d55bd8acdba30e1886cd59ed347a088da62","original_commit_id":"00d493ae88afab1d9f2e7c0e3e7a106bfbbc1fed","user":{"login":"nikkolasg","id":2564747,"avatar_url":"https://avatars.githubusercontent.com/u/2564747?v=3","gravatar_id":"","url":"https://api.github.com/users/nikkolasg","html_url":"https://github.com/nikkolasg","followers_url":"https://api.github.com/users/nikkolasg/followers","following_url":"https://api.github.com/users/nikkolasg/following{/other_user}","gists_url":"https://api.github.com/users/nikkolasg/gists{/gist_id}","starred_url":"https://api.github.com/users/nikkolasg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikkolasg/subscriptions","organizations_url":"https://api.github.com/users/nikkolasg/orgs","repos_url":"https://api.github.com/users/nikkolasg/repos","events_url":"https://api.github.com/users/nikkolasg/events{/privacy}","received_events_url":"https://api.github.com/users/nikkolasg/received_events","type":"User","site_admin":false},"body":"I did not find a adequate name between what is sent from the client (a measure) and what the monitor actually measures/takes/stores/computes (a \"measurement\"). Please if you have any ideas...","created_at":"2015-11-17T10:54:21Z","updated_at":"2015-11-17T10:54:21Z","html_url":"https://github.com/DeDiS/cothority/pull/94#discussion_r45045686","pull_request_url":"https://api.github.com/repos/DeDiS/cothority/pulls/94","_links":{"self":{"href":"https://api.github.com/repos/DeDiS/cothority/pulls/comments/45045686"},"html":{"href":"https://github.com/DeDiS/cothority/pull/94#discussion_r45045686"},"pull_request":{"href":"https://api.github.com/repos/DeDiS/cothority/pulls/94"}}},"pull_request":{"url":"https://api.github.com/repos/DeDiS/cothority/pulls/94","id":50871248,"html_url":"https://github.com/DeDiS/cothority/pull/94","diff_url":"https://github.com/DeDiS/cothority/pull/94.diff","patch_url":"https://github.com/DeDiS/cothority/pull/94.patch","issue_url":"https://api.github.com/repos/DeDiS/cothority/issues/94","number":94,"state":"open","locked":false,"title":"reworked monitor + test working","user":{"login":"nikkolasg","id":2564747,"avatar_url":"https://avatars.githubusercontent.com/u/2564747?v=3","gravatar_id":"","url":"https://api.github.com/users/nikkolasg","html_url":"https://github.com/nikkolasg","followers_url":"https://api.github.com/users/nikkolasg/followers","following_url":"https://api.github.com/users/nikkolasg/following{/other_user}","gists_url":"https://api.github.com/users/nikkolasg/gists{/gist_id}","starred_url":"https://api.github.com/users/nikkolasg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikkolasg/subscriptions","organizations_url":"https://api.github.com/users/nikkolasg/orgs","repos_url":"https://api.github.com/users/nikkolasg/repos","events_url":"https://api.github.com/users/nikkolasg/events{/privacy}","received_events_url":"https://api.github.com/users/nikkolasg/received_events","type":"User","site_admin":false},"body":"monitor now is used iwth a structure for more control on the concurrency. Test added + working (included the TestMonitor !)","created_at":"2015-11-16T21:50:04Z","updated_at":"2015-11-17T10:54:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ab32e714a77f6d6346d9d98e8956ad86f1d0a412","assignee":{"login":"nikkolasg","id":2564747,"avatar_url":"https://avatars.githubusercontent.com/u/2564747?v=3","gravatar_id":"","url":"https://api.github.com/users/nikkolasg","html_url":"https://github.com/nikkolasg","followers_url":"https://api.github.com/users/nikkolasg/followers","following_url":"https://api.github.com/users/nikkolasg/following{/other_user}","gists_url":"https://api.github.com/users/nikkolasg/gists{/gist_id}","starred_url":"https://api.github.com/users/nikkolasg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikkolasg/subscriptions","organizations_url":"https://api.github.com/users/nikkolasg/orgs","repos_url":"https://api.github.com/users/nikkolasg/repos","events_url":"https://api.github.com/users/nikkolasg/events{/privacy}","received_events_url":"https://api.github.com/users/nikkolasg/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/DeDiS/cothority/pulls/94/commits","review_comments_url":"https://api.github.com/repos/DeDiS/cothority/pulls/94/comments","review_comment_url":"https://api.github.com/repos/DeDiS/cothority/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DeDiS/cothority/issues/94/comments","statuses_url":"https://api.github.com/repos/DeDiS/cothority/statuses/4cad4d55bd8acdba30e1886cd59ed347a088da62","head":{"label":"DeDiS:monitor_stateful","ref":"monitor_stateful","sha":"4cad4d55bd8acdba30e1886cd59ed347a088da62","user":{"login":"DeDiS","id":3638331,"avatar_url":"https://avatars.githubusercontent.com/u/3638331?v=3","gravatar_id":"","url":"https://api.github.com/users/DeDiS","html_url":"https://github.com/DeDiS","followers_url":"https://api.github.com/users/DeDiS/followers","following_url":"https://api.github.com/users/DeDiS/following{/other_user}","gists_url":"https://api.github.com/users/DeDiS/gists{/gist_id}","starred_url":"https://api.github.com/users/DeDiS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DeDiS/subscriptions","organizations_url":"https://api.github.com/users/DeDiS/orgs","repos_url":"https://api.github.com/users/DeDiS/repos","events_url":"https://api.github.com/users/DeDiS/events{/privacy}","received_events_url":"https://api.github.com/users/DeDiS/received_events","type":"Organization","site_admin":false},"repo":{"id":41791684,"name":"cothority","full_name":"DeDiS/cothority","owner":{"login":"DeDiS","id":3638331,"avatar_url":"https://avatars.githubusercontent.com/u/3638331?v=3","gravatar_id":"","url":"https://api.github.com/users/DeDiS","html_url":"https://github.com/DeDiS","followers_url":"https://api.github.com/users/DeDiS/followers","following_url":"https://api.github.com/users/DeDiS/following{/other_user}","gists_url":"https://api.github.com/users/DeDiS/gists{/gist_id}","starred_url":"https://api.github.com/users/DeDiS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DeDiS/subscriptions","organizations_url":"https://api.github.com/users/DeDiS/orgs","repos_url":"https://api.github.com/users/DeDiS/repos","events_url":"https://api.github.com/users/DeDiS/events{/privacy}","received_events_url":"https://api.github.com/users/DeDiS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DeDiS/cothority","description":"Scalable collective authority prototype","fork":false,"url":"https://api.github.com/repos/DeDiS/cothority","forks_url":"https://api.github.com/repos/DeDiS/cothority/forks","keys_url":"https://api.github.com/repos/DeDiS/cothority/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DeDiS/cothority/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DeDiS/cothority/teams","hooks_url":"https://api.github.com/repos/DeDiS/cothority/hooks","issue_events_url":"https://api.github.com/repos/DeDiS/cothority/issues/events{/number}","events_url":"https://api.github.com/repos/DeDiS/cothority/events","assignees_url":"https://api.github.com/repos/DeDiS/cothority/assignees{/user}","branches_url":"https://api.github.com/repos/DeDiS/cothority/branches{/branch}","tags_url":"https://api.github.com/repos/DeDiS/cothority/tags","blobs_url":"https://api.github.com/repos/DeDiS/cothority/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DeDiS/cothority/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DeDiS/cothority/git/refs{/sha}","trees_url":"https://api.github.com/repos/DeDiS/cothority/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DeDiS/cothority/statuses/{sha}","languages_url":"https://api.github.com/repos/DeDiS/cothority/languages","stargazers_url":"https://api.github.com/repos/DeDiS/cothority/stargazers","contributors_url":"https://api.github.com/repos/DeDiS/cothority/contributors","subscribers_url":"https://api.github.com/repos/DeDiS/cothority/subscribers","subscription_url":"https://api.github.com/repos/DeDiS/cothority/subscription","commits_url":"https://api.github.com/repos/DeDiS/cothority/commits{/sha}","git_commits_url":"https://api.github.com/repos/DeDiS/cothority/git/commits{/sha}","comments_url":"https://api.github.com/repos/DeDiS/cothority/comments{/number}","issue_comment_url":"https://api.github.com/repos/DeDiS/cothority/issues/comments{/number}","contents_url":"https://api.github.com/repos/DeDiS/cothority/contents/{+path}","compare_url":"https://api.github.com/repos/DeDiS/cothority/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DeDiS/cothority/merges","archive_url":"https://api.github.com/repos/DeDiS/cothority/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DeDiS/cothority/downloads","issues_url":"https://api.github.com/repos/DeDiS/cothority/issues{/number}","pulls_url":"https://api.github.com/repos/DeDiS/cothority/pulls{/number}","milestones_url":"https://api.github.com/repos/DeDiS/cothority/milestones{/number}","notifications_url":"https://api.github.com/repos/DeDiS/cothority/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DeDiS/cothority/labels{/name}","releases_url":"https://api.github.com/repos/DeDiS/cothority/releases{/id}","created_at":"2015-09-02T09:13:57Z","updated_at":"2015-11-05T15:41:02Z","pushed_at":"2015-11-17T08:50:47Z","git_url":"git://github.com/DeDiS/cothority.git","ssh_url":"git@github.com:DeDiS/cothority.git","clone_url":"https://github.com/DeDiS/cothority.git","svn_url":"https://github.com/DeDiS/cothority","homepage":"","size":46790,"stargazers_count":7,"watchers_count":7,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":20,"forks":4,"open_issues":20,"watchers":7,"default_branch":"master"}},"base":{"label":"DeDiS:development","ref":"development","sha":"113db182b9fdebb59c0cb114307b486752ee42b1","user":{"login":"DeDiS","id":3638331,"avatar_url":"https://avatars.githubusercontent.com/u/3638331?v=3","gravatar_id":"","url":"https://api.github.com/users/DeDiS","html_url":"https://github.com/DeDiS","followers_url":"https://api.github.com/users/DeDiS/followers","following_url":"https://api.github.com/users/DeDiS/following{/other_user}","gists_url":"https://api.github.com/users/DeDiS/gists{/gist_id}","starred_url":"https://api.github.com/users/DeDiS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DeDiS/subscriptions","organizations_url":"https://api.github.com/users/DeDiS/orgs","repos_url":"https://api.github.com/users/DeDiS/repos","events_url":"https://api.github.com/users/DeDiS/events{/privacy}","received_events_url":"https://api.github.com/users/DeDiS/received_events","type":"Organization","site_admin":false},"repo":{"id":41791684,"name":"cothority","full_name":"DeDiS/cothority","owner":{"login":"DeDiS","id":3638331,"avatar_url":"https://avatars.githubusercontent.com/u/3638331?v=3","gravatar_id":"","url":"https://api.github.com/users/DeDiS","html_url":"https://github.com/DeDiS","followers_url":"https://api.github.com/users/DeDiS/followers","following_url":"https://api.github.com/users/DeDiS/following{/other_user}","gists_url":"https://api.github.com/users/DeDiS/gists{/gist_id}","starred_url":"https://api.github.com/users/DeDiS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DeDiS/subscriptions","organizations_url":"https://api.github.com/users/DeDiS/orgs","repos_url":"https://api.github.com/users/DeDiS/repos","events_url":"https://api.github.com/users/DeDiS/events{/privacy}","received_events_url":"https://api.github.com/users/DeDiS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DeDiS/cothority","description":"Scalable collective authority prototype","fork":false,"url":"https://api.github.com/repos/DeDiS/cothority","forks_url":"https://api.github.com/repos/DeDiS/cothority/forks","keys_url":"https://api.github.com/repos/DeDiS/cothority/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DeDiS/cothority/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DeDiS/cothority/teams","hooks_url":"https://api.github.com/repos/DeDiS/cothority/hooks","issue_events_url":"https://api.github.com/repos/DeDiS/cothority/issues/events{/number}","events_url":"https://api.github.com/repos/DeDiS/cothority/events","assignees_url":"https://api.github.com/repos/DeDiS/cothority/assignees{/user}","branches_url":"https://api.github.com/repos/DeDiS/cothority/branches{/branch}","tags_url":"https://api.github.com/repos/DeDiS/cothority/tags","blobs_url":"https://api.github.com/repos/DeDiS/cothority/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DeDiS/cothority/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DeDiS/cothority/git/refs{/sha}","trees_url":"https://api.github.com/repos/DeDiS/cothority/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DeDiS/cothority/statuses/{sha}","languages_url":"https://api.github.com/repos/DeDiS/cothority/languages","stargazers_url":"https://api.github.com/repos/DeDiS/cothority/stargazers","contributors_url":"https://api.github.com/repos/DeDiS/cothority/contributors","subscribers_url":"https://api.github.com/repos/DeDiS/cothority/subscribers","subscription_url":"https://api.github.com/repos/DeDiS/cothority/subscription","commits_url":"https://api.github.com/repos/DeDiS/cothority/commits{/sha}","git_commits_url":"https://api.github.com/repos/DeDiS/cothority/git/commits{/sha}","comments_url":"https://api.github.com/repos/DeDiS/cothority/comments{/number}","issue_comment_url":"https://api.github.com/repos/DeDiS/cothority/issues/comments{/number}","contents_url":"https://api.github.com/repos/DeDiS/cothority/contents/{+path}","compare_url":"https://api.github.com/repos/DeDiS/cothority/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DeDiS/cothority/merges","archive_url":"https://api.github.com/repos/DeDiS/cothority/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DeDiS/cothority/downloads","issues_url":"https://api.github.com/repos/DeDiS/cothority/issues{/number}","pulls_url":"https://api.github.com/repos/DeDiS/cothority/pulls{/number}","milestones_url":"https://api.github.com/repos/DeDiS/cothority/milestones{/number}","notifications_url":"https://api.github.com/repos/DeDiS/cothority/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DeDiS/cothority/labels{/name}","releases_url":"https://api.github.com/repos/DeDiS/cothority/releases{/id}","created_at":"2015-09-02T09:13:57Z","updated_at":"2015-11-05T15:41:02Z","pushed_at":"2015-11-17T08:50:47Z","git_url":"git://github.com/DeDiS/cothority.git","ssh_url":"git@github.com:DeDiS/cothority.git","clone_url":"https://github.com/DeDiS/cothority.git","svn_url":"https://github.com/DeDiS/cothority","homepage":"","size":46790,"stargazers_count":7,"watchers_count":7,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":20,"forks":4,"open_issues":20,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DeDiS/cothority/pulls/94"},"html":{"href":"https://github.com/DeDiS/cothority/pull/94"},"issue":{"href":"https://api.github.com/repos/DeDiS/cothority/issues/94"},"comments":{"href":"https://api.github.com/repos/DeDiS/cothority/issues/94/comments"},"review_comments":{"href":"https://api.github.com/repos/DeDiS/cothority/pulls/94/comments"},"review_comment":{"href":"https://api.github.com/repos/DeDiS/cothority/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DeDiS/cothority/pulls/94/commits"},"statuses":{"href":"https://api.github.com/repos/DeDiS/cothority/statuses/4cad4d55bd8acdba30e1886cd59ed347a088da62"}}}}