{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/40545923","id":40545923,"diff_hunk":"@@ -17,6 +17,7 @@\n \n #if defined(NODE_HAVE_I18N_SUPPORT)\n #include \"node_i18n.h\"\n+#include <unicode/putil.h>","path":"src/node.cc","position":4,"original_position":4,"commit_id":"02283e2876df1acd2704a952090720d55fbdc4f7","original_commit_id":"02283e2876df1acd2704a952090720d55fbdc4f7","user":{"login":"bnoordhuis","id":275871,"avatar_url":"https://avatars.githubusercontent.com/u/275871?v=3","gravatar_id":"","url":"https://api.github.com/users/bnoordhuis","html_url":"https://github.com/bnoordhuis","followers_url":"https://api.github.com/users/bnoordhuis/followers","following_url":"https://api.github.com/users/bnoordhuis/following{/other_user}","gists_url":"https://api.github.com/users/bnoordhuis/gists{/gist_id}","starred_url":"https://api.github.com/users/bnoordhuis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bnoordhuis/subscriptions","organizations_url":"https://api.github.com/users/bnoordhuis/orgs","repos_url":"https://api.github.com/users/bnoordhuis/repos","events_url":"https://api.github.com/users/bnoordhuis/events{/privacy}","received_events_url":"https://api.github.com/users/bnoordhuis/received_events","type":"User","site_admin":false},"body":"I think this should be unicode/uversion.h?","created_at":"2015-09-28T12:30:55Z","updated_at":"2015-09-28T12:30:55Z","html_url":"https://github.com/nodejs/node/pull/3102#discussion_r40545923","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/3102","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/40545923"},"html":{"href":"https://github.com/nodejs/node/pull/3102#discussion_r40545923"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/3102"}}},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/3102","id":46148729,"html_url":"https://github.com/nodejs/node/pull/3102","diff_url":"https://github.com/nodejs/node/pull/3102.diff","patch_url":"https://github.com/nodejs/node/pull/3102.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/3102","number":3102,"state":"open","locked":false,"title":"src: add process.versions.icu","user":{"login":"evanlucas","id":677994,"avatar_url":"https://avatars.githubusercontent.com/u/677994?v=3","gravatar_id":"","url":"https://api.github.com/users/evanlucas","html_url":"https://github.com/evanlucas","followers_url":"https://api.github.com/users/evanlucas/followers","following_url":"https://api.github.com/users/evanlucas/following{/other_user}","gists_url":"https://api.github.com/users/evanlucas/gists{/gist_id}","starred_url":"https://api.github.com/users/evanlucas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evanlucas/subscriptions","organizations_url":"https://api.github.com/users/evanlucas/orgs","repos_url":"https://api.github.com/users/evanlucas/repos","events_url":"https://api.github.com/users/evanlucas/events{/privacy}","received_events_url":"https://api.github.com/users/evanlucas/received_events","type":"User","site_admin":false},"body":"If i18n support is present, add the icu version\r\nto process.versions\r\n\r\nFixes: https://github.com/nodejs/node/issues/3089\r\n\r\nR= @silverwind / @srl295 ?","created_at":"2015-09-28T12:04:19Z","updated_at":"2015-09-28T12:30:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4826d643c25106c6fe36d60322b9d5ebe841cd51","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/3102/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/3102/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/3102/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/02283e2876df1acd2704a952090720d55fbdc4f7","head":{"label":"evanlucas:addicu","ref":"addicu","sha":"02283e2876df1acd2704a952090720d55fbdc4f7","user":{"login":"evanlucas","id":677994,"avatar_url":"https://avatars.githubusercontent.com/u/677994?v=3","gravatar_id":"","url":"https://api.github.com/users/evanlucas","html_url":"https://github.com/evanlucas","followers_url":"https://api.github.com/users/evanlucas/followers","following_url":"https://api.github.com/users/evanlucas/following{/other_user}","gists_url":"https://api.github.com/users/evanlucas/gists{/gist_id}","starred_url":"https://api.github.com/users/evanlucas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evanlucas/subscriptions","organizations_url":"https://api.github.com/users/evanlucas/orgs","repos_url":"https://api.github.com/users/evanlucas/repos","events_url":"https://api.github.com/users/evanlucas/events{/privacy}","received_events_url":"https://api.github.com/users/evanlucas/received_events","type":"User","site_admin":false},"repo":{"id":27466639,"name":"io.js","full_name":"evanlucas/io.js","owner":{"login":"evanlucas","id":677994,"avatar_url":"https://avatars.githubusercontent.com/u/677994?v=3","gravatar_id":"","url":"https://api.github.com/users/evanlucas","html_url":"https://github.com/evanlucas","followers_url":"https://api.github.com/users/evanlucas/followers","following_url":"https://api.github.com/users/evanlucas/following{/other_user}","gists_url":"https://api.github.com/users/evanlucas/gists{/gist_id}","starred_url":"https://api.github.com/users/evanlucas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evanlucas/subscriptions","organizations_url":"https://api.github.com/users/evanlucas/orgs","repos_url":"https://api.github.com/users/evanlucas/repos","events_url":"https://api.github.com/users/evanlucas/events{/privacy}","received_events_url":"https://api.github.com/users/evanlucas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/evanlucas/io.js","description":"Evented IO for V8 JavaScript","fork":true,"url":"https://api.github.com/repos/evanlucas/io.js","forks_url":"https://api.github.com/repos/evanlucas/io.js/forks","keys_url":"https://api.github.com/repos/evanlucas/io.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/evanlucas/io.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/evanlucas/io.js/teams","hooks_url":"https://api.github.com/repos/evanlucas/io.js/hooks","issue_events_url":"https://api.github.com/repos/evanlucas/io.js/issues/events{/number}","events_url":"https://api.github.com/repos/evanlucas/io.js/events","assignees_url":"https://api.github.com/repos/evanlucas/io.js/assignees{/user}","branches_url":"https://api.github.com/repos/evanlucas/io.js/branches{/branch}","tags_url":"https://api.github.com/repos/evanlucas/io.js/tags","blobs_url":"https://api.github.com/repos/evanlucas/io.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/evanlucas/io.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/evanlucas/io.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/evanlucas/io.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/evanlucas/io.js/statuses/{sha}","languages_url":"https://api.github.com/repos/evanlucas/io.js/languages","stargazers_url":"https://api.github.com/repos/evanlucas/io.js/stargazers","contributors_url":"https://api.github.com/repos/evanlucas/io.js/contributors","subscribers_url":"https://api.github.com/repos/evanlucas/io.js/subscribers","subscription_url":"https://api.github.com/repos/evanlucas/io.js/subscription","commits_url":"https://api.github.com/repos/evanlucas/io.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/evanlucas/io.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/evanlucas/io.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/evanlucas/io.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/evanlucas/io.js/contents/{+path}","compare_url":"https://api.github.com/repos/evanlucas/io.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/evanlucas/io.js/merges","archive_url":"https://api.github.com/repos/evanlucas/io.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/evanlucas/io.js/downloads","issues_url":"https://api.github.com/repos/evanlucas/io.js/issues{/number}","pulls_url":"https://api.github.com/repos/evanlucas/io.js/pulls{/number}","milestones_url":"https://api.github.com/repos/evanlucas/io.js/milestones{/number}","notifications_url":"https://api.github.com/repos/evanlucas/io.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/evanlucas/io.js/labels{/name}","releases_url":"https://api.github.com/repos/evanlucas/io.js/releases{/id}","created_at":"2014-12-03T03:07:41Z","updated_at":"2014-12-20T01:04:31Z","pushed_at":"2015-09-28T12:03:57Z","git_url":"git://github.com/evanlucas/io.js.git","ssh_url":"git@github.com:evanlucas/io.js.git","clone_url":"https://github.com/evanlucas/io.js.git","svn_url":"https://github.com/evanlucas/io.js","homepage":null,"size":144517,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"680dda802393ef1513a8a84a353dfc2ecfacacb2","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"✨Node.js  ✨","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","created_at":"2014-11-26T19:57:11Z","updated_at":"2015-09-28T11:27:49Z","pushed_at":"2015-09-28T12:04:21Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":338427,"stargazers_count":15568,"watchers_count":15568,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1407,"mirror_url":null,"open_issues_count":486,"forks":1407,"open_issues":486,"watchers":15568,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/3102"},"html":{"href":"https://github.com/nodejs/node/pull/3102"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/3102"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/3102/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/3102/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/3102/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/02283e2876df1acd2704a952090720d55fbdc4f7"}}}}