{"action":"created","issue":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/1443","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/1443/labels{/name}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/1443/comments","events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/1443/events","html_url":"https://github.com/cockroachdb/cockroach/pull/1443","id":90262490,"number":1443,"title":"Add sql_api.proto to structured package.","user":{"login":"vivekmenezes","id":11774212,"avatar_url":"https://avatars.githubusercontent.com/u/11774212?v=3","gravatar_id":"","url":"https://api.github.com/users/vivekmenezes","html_url":"https://github.com/vivekmenezes","followers_url":"https://api.github.com/users/vivekmenezes/followers","following_url":"https://api.github.com/users/vivekmenezes/following{/other_user}","gists_url":"https://api.github.com/users/vivekmenezes/gists{/gist_id}","starred_url":"https://api.github.com/users/vivekmenezes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vivekmenezes/subscriptions","organizations_url":"https://api.github.com/users/vivekmenezes/orgs","repos_url":"https://api.github.com/users/vivekmenezes/repos","events_url":"https://api.github.com/users/vivekmenezes/events{/privacy}","received_events_url":"https://api.github.com/users/vivekmenezes/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":11,"created_at":"2015-06-23T01:50:29Z","updated_at":"2015-06-23T17:18:04Z","closed_at":"2015-06-23T02:08:13Z","pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/1443","html_url":"https://github.com/cockroachdb/cockroach/pull/1443","diff_url":"https://github.com/cockroachdb/cockroach/pull/1443.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/1443.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments/114576639","html_url":"https://github.com/cockroachdb/cockroach/pull/1443#issuecomment-114576639","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/1443","id":114576639,"user":{"login":"bdarnell","id":160562,"avatar_url":"https://avatars.githubusercontent.com/u/160562?v=3","gravatar_id":"","url":"https://api.github.com/users/bdarnell","html_url":"https://github.com/bdarnell","followers_url":"https://api.github.com/users/bdarnell/followers","following_url":"https://api.github.com/users/bdarnell/following{/other_user}","gists_url":"https://api.github.com/users/bdarnell/gists{/gist_id}","starred_url":"https://api.github.com/users/bdarnell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdarnell/subscriptions","organizations_url":"https://api.github.com/users/bdarnell/orgs","repos_url":"https://api.github.com/users/bdarnell/repos","events_url":"https://api.github.com/users/bdarnell/events{/privacy}","received_events_url":"https://api.github.com/users/bdarnell/received_events","type":"User","site_admin":false},"created_at":"2015-06-23T17:18:04Z","updated_at":"2015-06-23T17:18:04Z","body":"The urge to put (RPC-related) protos in a separate package is because they are dependencies of both server and client, so whatever package contains protos should have as few dependencies as possible, and should not contain large amounts of code that is server-only (so the protos should not live in the same package as the sql parser). \r\n\r\nReplacing cockroach/proto with cockroach/structured/proto is an improvement: the problem with the old proto package was that it had too much loosely-related stuff, not that it was distinct from other packages. If we split `proto` in to five separate `proto` subpackages that would still be a win."}}