{"action":"closed","number":205,"pull_request":{"url":"https://api.github.com/repos/exaile/exaile/pulls/205","id":54183909,"html_url":"https://github.com/exaile/exaile/pull/205","diff_url":"https://github.com/exaile/exaile/pull/205.diff","patch_url":"https://github.com/exaile/exaile/pull/205.patch","issue_url":"https://api.github.com/repos/exaile/exaile/issues/205","number":205,"state":"closed","locked":false,"title":"[Jamendo plugin] Retire bundled simplejson","user":{"login":"genodeftest","id":934401,"avatar_url":"https://avatars.githubusercontent.com/u/934401?v=3","gravatar_id":"","url":"https://api.github.com/users/genodeftest","html_url":"https://github.com/genodeftest","followers_url":"https://api.github.com/users/genodeftest/followers","following_url":"https://api.github.com/users/genodeftest/following{/other_user}","gists_url":"https://api.github.com/users/genodeftest/gists{/gist_id}","starred_url":"https://api.github.com/users/genodeftest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/genodeftest/subscriptions","organizations_url":"https://api.github.com/users/genodeftest/orgs","repos_url":"https://api.github.com/users/genodeftest/repos","events_url":"https://api.github.com/users/genodeftest/events{/privacy}","received_events_url":"https://api.github.com/users/genodeftest/received_events","type":"User","site_admin":false},"body":"The jamendo plugin is currently [shipping its own copy](https://github.com/exaile/exaile/tree/master/plugins/jamendo/simplejson) of [simplejson](https://github.com/simplejson/simplejson). This copy is 6 years old.\r\n\r\nSimplejson was [included in Python 2.6](https://docs.python.org/2/whatsnew/2.6.html#the-json-module-javascript-object-notation) as module `json`. There is no need to ship a separate copy. I guess there won't be anyone using exaile 4.x with python 2.5 or older (and I doubt that would work with GObject). So I think we can just rely on json bundled with python.\r\n\r\nI've tested the jamendo plugin and it works fine with json and simplejson.\r\n\r\n(Yes, finally removing some hundred lines of code ;) )","created_at":"2015-12-19T18:33:01Z","updated_at":"2015-12-19T18:34:56Z","closed_at":"2015-12-19T18:34:56Z","merged_at":"2015-12-19T18:34:56Z","merge_commit_sha":"3b4e4fdd885311eb9466e2c7dc483b96d7ae6237","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/exaile/exaile/pulls/205/commits","review_comments_url":"https://api.github.com/repos/exaile/exaile/pulls/205/comments","review_comment_url":"https://api.github.com/repos/exaile/exaile/pulls/comments{/number}","comments_url":"https://api.github.com/repos/exaile/exaile/issues/205/comments","statuses_url":"https://api.github.com/repos/exaile/exaile/statuses/a1078ad589947e556066301710a9d7ab15bf723a","head":{"label":"genodeftest:remove-simplejson","ref":"remove-simplejson","sha":"a1078ad589947e556066301710a9d7ab15bf723a","user":{"login":"genodeftest","id":934401,"avatar_url":"https://avatars.githubusercontent.com/u/934401?v=3","gravatar_id":"","url":"https://api.github.com/users/genodeftest","html_url":"https://github.com/genodeftest","followers_url":"https://api.github.com/users/genodeftest/followers","following_url":"https://api.github.com/users/genodeftest/following{/other_user}","gists_url":"https://api.github.com/users/genodeftest/gists{/gist_id}","starred_url":"https://api.github.com/users/genodeftest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/genodeftest/subscriptions","organizations_url":"https://api.github.com/users/genodeftest/orgs","repos_url":"https://api.github.com/users/genodeftest/repos","events_url":"https://api.github.com/users/genodeftest/events{/privacy}","received_events_url":"https://api.github.com/users/genodeftest/received_events","type":"User","site_admin":false},"repo":{"id":36904762,"name":"exaile","full_name":"genodeftest/exaile","owner":{"login":"genodeftest","id":934401,"avatar_url":"https://avatars.githubusercontent.com/u/934401?v=3","gravatar_id":"","url":"https://api.github.com/users/genodeftest","html_url":"https://github.com/genodeftest","followers_url":"https://api.github.com/users/genodeftest/followers","following_url":"https://api.github.com/users/genodeftest/following{/other_user}","gists_url":"https://api.github.com/users/genodeftest/gists{/gist_id}","starred_url":"https://api.github.com/users/genodeftest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/genodeftest/subscriptions","organizations_url":"https://api.github.com/users/genodeftest/orgs","repos_url":"https://api.github.com/users/genodeftest/repos","events_url":"https://api.github.com/users/genodeftest/events{/privacy}","received_events_url":"https://api.github.com/users/genodeftest/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/genodeftest/exaile","description":"Cross-platform music player","fork":true,"url":"https://api.github.com/repos/genodeftest/exaile","forks_url":"https://api.github.com/repos/genodeftest/exaile/forks","keys_url":"https://api.github.com/repos/genodeftest/exaile/keys{/key_id}","collaborators_url":"https://api.github.com/repos/genodeftest/exaile/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/genodeftest/exaile/teams","hooks_url":"https://api.github.com/repos/genodeftest/exaile/hooks","issue_events_url":"https://api.github.com/repos/genodeftest/exaile/issues/events{/number}","events_url":"https://api.github.com/repos/genodeftest/exaile/events","assignees_url":"https://api.github.com/repos/genodeftest/exaile/assignees{/user}","branches_url":"https://api.github.com/repos/genodeftest/exaile/branches{/branch}","tags_url":"https://api.github.com/repos/genodeftest/exaile/tags","blobs_url":"https://api.github.com/repos/genodeftest/exaile/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/genodeftest/exaile/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/genodeftest/exaile/git/refs{/sha}","trees_url":"https://api.github.com/repos/genodeftest/exaile/git/trees{/sha}","statuses_url":"https://api.github.com/repos/genodeftest/exaile/statuses/{sha}","languages_url":"https://api.github.com/repos/genodeftest/exaile/languages","stargazers_url":"https://api.github.com/repos/genodeftest/exaile/stargazers","contributors_url":"https://api.github.com/repos/genodeftest/exaile/contributors","subscribers_url":"https://api.github.com/repos/genodeftest/exaile/subscribers","subscription_url":"https://api.github.com/repos/genodeftest/exaile/subscription","commits_url":"https://api.github.com/repos/genodeftest/exaile/commits{/sha}","git_commits_url":"https://api.github.com/repos/genodeftest/exaile/git/commits{/sha}","comments_url":"https://api.github.com/repos/genodeftest/exaile/comments{/number}","issue_comment_url":"https://api.github.com/repos/genodeftest/exaile/issues/comments{/number}","contents_url":"https://api.github.com/repos/genodeftest/exaile/contents/{+path}","compare_url":"https://api.github.com/repos/genodeftest/exaile/compare/{base}...{head}","merges_url":"https://api.github.com/repos/genodeftest/exaile/merges","archive_url":"https://api.github.com/repos/genodeftest/exaile/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/genodeftest/exaile/downloads","issues_url":"https://api.github.com/repos/genodeftest/exaile/issues{/number}","pulls_url":"https://api.github.com/repos/genodeftest/exaile/pulls{/number}","milestones_url":"https://api.github.com/repos/genodeftest/exaile/milestones{/number}","notifications_url":"https://api.github.com/repos/genodeftest/exaile/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/genodeftest/exaile/labels{/name}","releases_url":"https://api.github.com/repos/genodeftest/exaile/releases{/id}","created_at":"2015-06-05T01:19:10Z","updated_at":"2015-06-05T01:19:12Z","pushed_at":"2015-12-19T18:31:31Z","git_url":"git://github.com/genodeftest/exaile.git","ssh_url":"git@github.com:genodeftest/exaile.git","clone_url":"https://github.com/genodeftest/exaile.git","svn_url":"https://github.com/genodeftest/exaile","homepage":"http://www.exaile.org/","size":74904,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"gi"}},"base":{"label":"exaile:master","ref":"master","sha":"55b8b4bfca988662fa6ead057a7a2c2a2d6bacb7","user":{"login":"exaile","id":8432897,"avatar_url":"https://avatars.githubusercontent.com/u/8432897?v=3","gravatar_id":"","url":"https://api.github.com/users/exaile","html_url":"https://github.com/exaile","followers_url":"https://api.github.com/users/exaile/followers","following_url":"https://api.github.com/users/exaile/following{/other_user}","gists_url":"https://api.github.com/users/exaile/gists{/gist_id}","starred_url":"https://api.github.com/users/exaile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exaile/subscriptions","organizations_url":"https://api.github.com/users/exaile/orgs","repos_url":"https://api.github.com/users/exaile/repos","events_url":"https://api.github.com/users/exaile/events{/privacy}","received_events_url":"https://api.github.com/users/exaile/received_events","type":"Organization","site_admin":false},"repo":{"id":23480519,"name":"exaile","full_name":"exaile/exaile","owner":{"login":"exaile","id":8432897,"avatar_url":"https://avatars.githubusercontent.com/u/8432897?v=3","gravatar_id":"","url":"https://api.github.com/users/exaile","html_url":"https://github.com/exaile","followers_url":"https://api.github.com/users/exaile/followers","following_url":"https://api.github.com/users/exaile/following{/other_user}","gists_url":"https://api.github.com/users/exaile/gists{/gist_id}","starred_url":"https://api.github.com/users/exaile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exaile/subscriptions","organizations_url":"https://api.github.com/users/exaile/orgs","repos_url":"https://api.github.com/users/exaile/repos","events_url":"https://api.github.com/users/exaile/events{/privacy}","received_events_url":"https://api.github.com/users/exaile/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/exaile/exaile","description":"Cross-platform music player","fork":false,"url":"https://api.github.com/repos/exaile/exaile","forks_url":"https://api.github.com/repos/exaile/exaile/forks","keys_url":"https://api.github.com/repos/exaile/exaile/keys{/key_id}","collaborators_url":"https://api.github.com/repos/exaile/exaile/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/exaile/exaile/teams","hooks_url":"https://api.github.com/repos/exaile/exaile/hooks","issue_events_url":"https://api.github.com/repos/exaile/exaile/issues/events{/number}","events_url":"https://api.github.com/repos/exaile/exaile/events","assignees_url":"https://api.github.com/repos/exaile/exaile/assignees{/user}","branches_url":"https://api.github.com/repos/exaile/exaile/branches{/branch}","tags_url":"https://api.github.com/repos/exaile/exaile/tags","blobs_url":"https://api.github.com/repos/exaile/exaile/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/exaile/exaile/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/exaile/exaile/git/refs{/sha}","trees_url":"https://api.github.com/repos/exaile/exaile/git/trees{/sha}","statuses_url":"https://api.github.com/repos/exaile/exaile/statuses/{sha}","languages_url":"https://api.github.com/repos/exaile/exaile/languages","stargazers_url":"https://api.github.com/repos/exaile/exaile/stargazers","contributors_url":"https://api.github.com/repos/exaile/exaile/contributors","subscribers_url":"https://api.github.com/repos/exaile/exaile/subscribers","subscription_url":"https://api.github.com/repos/exaile/exaile/subscription","commits_url":"https://api.github.com/repos/exaile/exaile/commits{/sha}","git_commits_url":"https://api.github.com/repos/exaile/exaile/git/commits{/sha}","comments_url":"https://api.github.com/repos/exaile/exaile/comments{/number}","issue_comment_url":"https://api.github.com/repos/exaile/exaile/issues/comments{/number}","contents_url":"https://api.github.com/repos/exaile/exaile/contents/{+path}","compare_url":"https://api.github.com/repos/exaile/exaile/compare/{base}...{head}","merges_url":"https://api.github.com/repos/exaile/exaile/merges","archive_url":"https://api.github.com/repos/exaile/exaile/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/exaile/exaile/downloads","issues_url":"https://api.github.com/repos/exaile/exaile/issues{/number}","pulls_url":"https://api.github.com/repos/exaile/exaile/pulls{/number}","milestones_url":"https://api.github.com/repos/exaile/exaile/milestones{/number}","notifications_url":"https://api.github.com/repos/exaile/exaile/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/exaile/exaile/labels{/name}","releases_url":"https://api.github.com/repos/exaile/exaile/releases{/id}","created_at":"2014-08-29T23:26:55Z","updated_at":"2015-12-11T18:28:22Z","pushed_at":"2015-12-19T18:34:56Z","git_url":"git://github.com/exaile/exaile.git","ssh_url":"git@github.com:exaile/exaile.git","clone_url":"https://github.com/exaile/exaile.git","svn_url":"https://github.com/exaile/exaile","homepage":"http://www.exaile.org/","size":77689,"stargazers_count":72,"watchers_count":72,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"open_issues_count":49,"forks":26,"open_issues":49,"watchers":72,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/exaile/exaile/pulls/205"},"html":{"href":"https://github.com/exaile/exaile/pull/205"},"issue":{"href":"https://api.github.com/repos/exaile/exaile/issues/205"},"comments":{"href":"https://api.github.com/repos/exaile/exaile/issues/205/comments"},"review_comments":{"href":"https://api.github.com/repos/exaile/exaile/pulls/205/comments"},"review_comment":{"href":"https://api.github.com/repos/exaile/exaile/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/exaile/exaile/pulls/205/commits"},"statuses":{"href":"https://api.github.com/repos/exaile/exaile/statuses/a1078ad589947e556066301710a9d7ab15bf723a"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"virtuald","id":567900,"avatar_url":"https://avatars.githubusercontent.com/u/567900?v=3","gravatar_id":"","url":"https://api.github.com/users/virtuald","html_url":"https://github.com/virtuald","followers_url":"https://api.github.com/users/virtuald/followers","following_url":"https://api.github.com/users/virtuald/following{/other_user}","gists_url":"https://api.github.com/users/virtuald/gists{/gist_id}","starred_url":"https://api.github.com/users/virtuald/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/virtuald/subscriptions","organizations_url":"https://api.github.com/users/virtuald/orgs","repos_url":"https://api.github.com/users/virtuald/repos","events_url":"https://api.github.com/users/virtuald/events{/privacy}","received_events_url":"https://api.github.com/users/virtuald/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":2,"deletions":1884,"changed_files":23}}