{"action":"created","issue":{"url":"https://api.github.com/repos/angular/protractor/issues/1898","labels_url":"https://api.github.com/repos/angular/protractor/issues/1898/labels{/name}","comments_url":"https://api.github.com/repos/angular/protractor/issues/1898/comments","events_url":"https://api.github.com/repos/angular/protractor/issues/1898/events","html_url":"https://github.com/angular/protractor/pull/1898","id":59858996,"number":1898,"title":"experimental(debugger): make element explorer work with node 0.12.0","user":{"login":"hankduan","id":1059345,"avatar_url":"https://avatars.githubusercontent.com/u/1059345?v=3","gravatar_id":"","url":"https://api.github.com/users/hankduan","html_url":"https://github.com/hankduan","followers_url":"https://api.github.com/users/hankduan/followers","following_url":"https://api.github.com/users/hankduan/following{/other_user}","gists_url":"https://api.github.com/users/hankduan/gists{/gist_id}","starred_url":"https://api.github.com/users/hankduan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hankduan/subscriptions","organizations_url":"https://api.github.com/users/hankduan/orgs","repos_url":"https://api.github.com/users/hankduan/repos","events_url":"https://api.github.com/users/hankduan/events{/privacy}","received_events_url":"https://api.github.com/users/hankduan/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/angular/protractor/labels/cla:%20yes","name":"cla: yes","color":"c7def8"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-03-04T20:45:23Z","updated_at":"2015-03-10T01:47:07Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/angular/protractor/pulls/1898","html_url":"https://github.com/angular/protractor/pull/1898","diff_url":"https://github.com/angular/protractor/pull/1898.diff","patch_url":"https://github.com/angular/protractor/pull/1898.patch"},"body":"Node has changed its debugger significantly in 0.12.0, and these changes are necessary to get it to work now.\r\n\r\nSpecifically here are the key points to take note:\r\n\r\n* Before, the process continues running after `process._debugProcess(pid);` is called, but now, the process stops. \r\nTo over come this, the call to `process._debugProcess(pid)` is moved from protractor into the debugger client. Secondly, because the process stops after the call, we call `reqContinue` once the debugger connection is established, so that protractor continues into the first break point (for backwards compatibility, we added an extra empty webdriver command so that in earlier versions of node, protractor doesn't go past the first break point from the reqContinue). \r\n\r\n* Before repl provides '(foobar\\n)' when an user inputs 'foobar'. Now it is just 'foobar\\n'.\r\nWe will parse and strip away both the parenthesis and '\\n' to support all versions of node. "},"comment":{"url":"https://api.github.com/repos/angular/protractor/issues/comments/77981578","html_url":"https://github.com/angular/protractor/pull/1898#issuecomment-77981578","issue_url":"https://api.github.com/repos/angular/protractor/issues/1898","id":77981578,"user":{"login":"hankduan","id":1059345,"avatar_url":"https://avatars.githubusercontent.com/u/1059345?v=3","gravatar_id":"","url":"https://api.github.com/users/hankduan","html_url":"https://github.com/hankduan","followers_url":"https://api.github.com/users/hankduan/followers","following_url":"https://api.github.com/users/hankduan/following{/other_user}","gists_url":"https://api.github.com/users/hankduan/gists{/gist_id}","starred_url":"https://api.github.com/users/hankduan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hankduan/subscriptions","organizations_url":"https://api.github.com/users/hankduan/orgs","repos_url":"https://api.github.com/users/hankduan/repos","events_url":"https://api.github.com/users/hankduan/events{/privacy}","received_events_url":"https://api.github.com/users/hankduan/received_events","type":"User","site_admin":false},"created_at":"2015-03-10T01:47:07Z","updated_at":"2015-03-10T01:47:07Z","body":"Node versions above 0.10.30 is affected by the nodejs bug described here: https://github.com/angular/protractor/issues/1890"}}