{"action":"opened","number":22,"pull_request":{"url":"https://api.github.com/repos/StileEducation/fabric.js/pulls/22","id":38511793,"html_url":"https://github.com/StileEducation/fabric.js/pull/22","diff_url":"https://github.com/StileEducation/fabric.js/pull/22.diff","patch_url":"https://github.com/StileEducation/fabric.js/pull/22.patch","issue_url":"https://api.github.com/repos/StileEducation/fabric.js/issues/22","number":22,"state":"open","locked":false,"title":"Group selection deselection","user":{"login":"Alysander","id":9831748,"avatar_url":"https://avatars.githubusercontent.com/u/9831748?v=3","gravatar_id":"","url":"https://api.github.com/users/Alysander","html_url":"https://github.com/Alysander","followers_url":"https://api.github.com/users/Alysander/followers","following_url":"https://api.github.com/users/Alysander/following{/other_user}","gists_url":"https://api.github.com/users/Alysander/gists{/gist_id}","starred_url":"https://api.github.com/users/Alysander/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alysander/subscriptions","organizations_url":"https://api.github.com/users/Alysander/orgs","repos_url":"https://api.github.com/users/Alysander/repos","events_url":"https://api.github.com/users/Alysander/events{/privacy}","received_events_url":"https://api.github.com/users/Alysander/received_events","type":"User","site_admin":false},"body":"This allows adding/removing objects from the selection properly.\r\n\r\nFirstly fabric wasn't compensating for coordinates of objects inside of groups, it then had various\r\ncontrol flow problems that prevented the code from executing properly such as a fast path that wouldn't allow \r\nchecking if a click intersected with something inside of a group if another object or the group itself was the last thing rendered.\r\n\r\nAlso, reseting the transform on the group wasn't being done early enough in addWithUpdate and removeWithUpdate and was causing a horrible jank.","created_at":"2015-06-25T04:49:30Z","updated_at":"2015-06-25T04:49:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e461d438aa5068c8c69db1cf5f0380014513d407","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/StileEducation/fabric.js/pulls/22/commits","review_comments_url":"https://api.github.com/repos/StileEducation/fabric.js/pulls/22/comments","review_comment_url":"https://api.github.com/repos/StileEducation/fabric.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/StileEducation/fabric.js/issues/22/comments","statuses_url":"https://api.github.com/repos/StileEducation/fabric.js/statuses/be09154aab01a908a5df47b6d6730b37a434744d","head":{"label":"StileEducation:group_selection_deselection","ref":"group_selection_deselection","sha":"be09154aab01a908a5df47b6d6730b37a434744d","user":{"login":"StileEducation","id":2775114,"avatar_url":"https://avatars.githubusercontent.com/u/2775114?v=3","gravatar_id":"","url":"https://api.github.com/users/StileEducation","html_url":"https://github.com/StileEducation","followers_url":"https://api.github.com/users/StileEducation/followers","following_url":"https://api.github.com/users/StileEducation/following{/other_user}","gists_url":"https://api.github.com/users/StileEducation/gists{/gist_id}","starred_url":"https://api.github.com/users/StileEducation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StileEducation/subscriptions","organizations_url":"https://api.github.com/users/StileEducation/orgs","repos_url":"https://api.github.com/users/StileEducation/repos","events_url":"https://api.github.com/users/StileEducation/events{/privacy}","received_events_url":"https://api.github.com/users/StileEducation/received_events","type":"Organization","site_admin":false},"repo":{"id":31195116,"name":"fabric.js","full_name":"StileEducation/fabric.js","owner":{"login":"StileEducation","id":2775114,"avatar_url":"https://avatars.githubusercontent.com/u/2775114?v=3","gravatar_id":"","url":"https://api.github.com/users/StileEducation","html_url":"https://github.com/StileEducation","followers_url":"https://api.github.com/users/StileEducation/followers","following_url":"https://api.github.com/users/StileEducation/following{/other_user}","gists_url":"https://api.github.com/users/StileEducation/gists{/gist_id}","starred_url":"https://api.github.com/users/StileEducation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StileEducation/subscriptions","organizations_url":"https://api.github.com/users/StileEducation/orgs","repos_url":"https://api.github.com/users/StileEducation/repos","events_url":"https://api.github.com/users/StileEducation/events{/privacy}","received_events_url":"https://api.github.com/users/StileEducation/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/StileEducation/fabric.js","description":"Javascript Canvas Library, SVG-to-Canvas (& canvas-to-SVG) Parser","fork":true,"url":"https://api.github.com/repos/StileEducation/fabric.js","forks_url":"https://api.github.com/repos/StileEducation/fabric.js/forks","keys_url":"https://api.github.com/repos/StileEducation/fabric.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/StileEducation/fabric.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/StileEducation/fabric.js/teams","hooks_url":"https://api.github.com/repos/StileEducation/fabric.js/hooks","issue_events_url":"https://api.github.com/repos/StileEducation/fabric.js/issues/events{/number}","events_url":"https://api.github.com/repos/StileEducation/fabric.js/events","assignees_url":"https://api.github.com/repos/StileEducation/fabric.js/assignees{/user}","branches_url":"https://api.github.com/repos/StileEducation/fabric.js/branches{/branch}","tags_url":"https://api.github.com/repos/StileEducation/fabric.js/tags","blobs_url":"https://api.github.com/repos/StileEducation/fabric.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/StileEducation/fabric.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/StileEducation/fabric.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/StileEducation/fabric.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/StileEducation/fabric.js/statuses/{sha}","languages_url":"https://api.github.com/repos/StileEducation/fabric.js/languages","stargazers_url":"https://api.github.com/repos/StileEducation/fabric.js/stargazers","contributors_url":"https://api.github.com/repos/StileEducation/fabric.js/contributors","subscribers_url":"https://api.github.com/repos/StileEducation/fabric.js/subscribers","subscription_url":"https://api.github.com/repos/StileEducation/fabric.js/subscription","commits_url":"https://api.github.com/repos/StileEducation/fabric.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/StileEducation/fabric.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/StileEducation/fabric.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/StileEducation/fabric.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/StileEducation/fabric.js/contents/{+path}","compare_url":"https://api.github.com/repos/StileEducation/fabric.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/StileEducation/fabric.js/merges","archive_url":"https://api.github.com/repos/StileEducation/fabric.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/StileEducation/fabric.js/downloads","issues_url":"https://api.github.com/repos/StileEducation/fabric.js/issues{/number}","pulls_url":"https://api.github.com/repos/StileEducation/fabric.js/pulls{/number}","milestones_url":"https://api.github.com/repos/StileEducation/fabric.js/milestones{/number}","notifications_url":"https://api.github.com/repos/StileEducation/fabric.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/StileEducation/fabric.js/labels{/name}","releases_url":"https://api.github.com/repos/StileEducation/fabric.js/releases{/id}","created_at":"2015-02-23T05:20:51Z","updated_at":"2015-04-14T04:03:00Z","pushed_at":"2015-06-25T04:49:32Z","git_url":"git://github.com/StileEducation/fabric.js.git","ssh_url":"git@github.com:StileEducation/fabric.js.git","clone_url":"https://github.com/StileEducation/fabric.js.git","svn_url":"https://github.com/StileEducation/fabric.js","homepage":"http://fabricjs.com","size":95323,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"StileEducation:stile_release_cut","ref":"stile_release_cut","sha":"8a83b99332889d2b33bc7988ec256dff1c98df55","user":{"login":"StileEducation","id":2775114,"avatar_url":"https://avatars.githubusercontent.com/u/2775114?v=3","gravatar_id":"","url":"https://api.github.com/users/StileEducation","html_url":"https://github.com/StileEducation","followers_url":"https://api.github.com/users/StileEducation/followers","following_url":"https://api.github.com/users/StileEducation/following{/other_user}","gists_url":"https://api.github.com/users/StileEducation/gists{/gist_id}","starred_url":"https://api.github.com/users/StileEducation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StileEducation/subscriptions","organizations_url":"https://api.github.com/users/StileEducation/orgs","repos_url":"https://api.github.com/users/StileEducation/repos","events_url":"https://api.github.com/users/StileEducation/events{/privacy}","received_events_url":"https://api.github.com/users/StileEducation/received_events","type":"Organization","site_admin":false},"repo":{"id":31195116,"name":"fabric.js","full_name":"StileEducation/fabric.js","owner":{"login":"StileEducation","id":2775114,"avatar_url":"https://avatars.githubusercontent.com/u/2775114?v=3","gravatar_id":"","url":"https://api.github.com/users/StileEducation","html_url":"https://github.com/StileEducation","followers_url":"https://api.github.com/users/StileEducation/followers","following_url":"https://api.github.com/users/StileEducation/following{/other_user}","gists_url":"https://api.github.com/users/StileEducation/gists{/gist_id}","starred_url":"https://api.github.com/users/StileEducation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StileEducation/subscriptions","organizations_url":"https://api.github.com/users/StileEducation/orgs","repos_url":"https://api.github.com/users/StileEducation/repos","events_url":"https://api.github.com/users/StileEducation/events{/privacy}","received_events_url":"https://api.github.com/users/StileEducation/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/StileEducation/fabric.js","description":"Javascript Canvas Library, SVG-to-Canvas (& canvas-to-SVG) Parser","fork":true,"url":"https://api.github.com/repos/StileEducation/fabric.js","forks_url":"https://api.github.com/repos/StileEducation/fabric.js/forks","keys_url":"https://api.github.com/repos/StileEducation/fabric.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/StileEducation/fabric.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/StileEducation/fabric.js/teams","hooks_url":"https://api.github.com/repos/StileEducation/fabric.js/hooks","issue_events_url":"https://api.github.com/repos/StileEducation/fabric.js/issues/events{/number}","events_url":"https://api.github.com/repos/StileEducation/fabric.js/events","assignees_url":"https://api.github.com/repos/StileEducation/fabric.js/assignees{/user}","branches_url":"https://api.github.com/repos/StileEducation/fabric.js/branches{/branch}","tags_url":"https://api.github.com/repos/StileEducation/fabric.js/tags","blobs_url":"https://api.github.com/repos/StileEducation/fabric.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/StileEducation/fabric.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/StileEducation/fabric.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/StileEducation/fabric.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/StileEducation/fabric.js/statuses/{sha}","languages_url":"https://api.github.com/repos/StileEducation/fabric.js/languages","stargazers_url":"https://api.github.com/repos/StileEducation/fabric.js/stargazers","contributors_url":"https://api.github.com/repos/StileEducation/fabric.js/contributors","subscribers_url":"https://api.github.com/repos/StileEducation/fabric.js/subscribers","subscription_url":"https://api.github.com/repos/StileEducation/fabric.js/subscription","commits_url":"https://api.github.com/repos/StileEducation/fabric.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/StileEducation/fabric.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/StileEducation/fabric.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/StileEducation/fabric.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/StileEducation/fabric.js/contents/{+path}","compare_url":"https://api.github.com/repos/StileEducation/fabric.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/StileEducation/fabric.js/merges","archive_url":"https://api.github.com/repos/StileEducation/fabric.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/StileEducation/fabric.js/downloads","issues_url":"https://api.github.com/repos/StileEducation/fabric.js/issues{/number}","pulls_url":"https://api.github.com/repos/StileEducation/fabric.js/pulls{/number}","milestones_url":"https://api.github.com/repos/StileEducation/fabric.js/milestones{/number}","notifications_url":"https://api.github.com/repos/StileEducation/fabric.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/StileEducation/fabric.js/labels{/name}","releases_url":"https://api.github.com/repos/StileEducation/fabric.js/releases{/id}","created_at":"2015-02-23T05:20:51Z","updated_at":"2015-04-14T04:03:00Z","pushed_at":"2015-06-25T04:49:32Z","git_url":"git://github.com/StileEducation/fabric.js.git","ssh_url":"git@github.com:StileEducation/fabric.js.git","clone_url":"https://github.com/StileEducation/fabric.js.git","svn_url":"https://github.com/StileEducation/fabric.js","homepage":"http://fabricjs.com","size":95323,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/StileEducation/fabric.js/pulls/22"},"html":{"href":"https://github.com/StileEducation/fabric.js/pull/22"},"issue":{"href":"https://api.github.com/repos/StileEducation/fabric.js/issues/22"},"comments":{"href":"https://api.github.com/repos/StileEducation/fabric.js/issues/22/comments"},"review_comments":{"href":"https://api.github.com/repos/StileEducation/fabric.js/pulls/22/comments"},"review_comment":{"href":"https://api.github.com/repos/StileEducation/fabric.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/StileEducation/fabric.js/pulls/22/commits"},"statuses":{"href":"https://api.github.com/repos/StileEducation/fabric.js/statuses/be09154aab01a908a5df47b6d6730b37a434744d"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":4,"additions":77,"deletions":51,"changed_files":4}}