{"action":"closed","number":3080,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/3080","id":46090979,"html_url":"https://github.com/nodejs/node/pull/3080","diff_url":"https://github.com/nodejs/node/pull/3080.diff","patch_url":"https://github.com/nodejs/node/pull/3080.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/3080","number":3080,"state":"closed","locked":false,"title":"Native buf checks","user":{"login":"trevnorris","id":289174,"avatar_url":"https://avatars.githubusercontent.com/u/289174?v=3","gravatar_id":"","url":"https://api.github.com/users/trevnorris","html_url":"https://github.com/trevnorris","followers_url":"https://api.github.com/users/trevnorris/followers","following_url":"https://api.github.com/users/trevnorris/following{/other_user}","gists_url":"https://api.github.com/users/trevnorris/gists{/gist_id}","starred_url":"https://api.github.com/users/trevnorris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trevnorris/subscriptions","organizations_url":"https://api.github.com/users/trevnorris/orgs","repos_url":"https://api.github.com/users/trevnorris/repos","events_url":"https://api.github.com/users/trevnorris/events{/privacy}","received_events_url":"https://api.github.com/users/trevnorris/received_events","type":"User","site_admin":false},"body":"Native Buffer method calls do not require anything from the prototype.\r\nSo it is unnecessary to check if the Object's prototype is equal to\r\nBuffer.prototype.\r\n\r\nThis fixes an issue that prevents Buffer from being inherited the ES5\r\nway. Now the following will work:\r\n\r\n    function A(n) {\r\n      const b = new Buffer(n);\r\n      Object.setPrototypeOf(b, A.prototype);\r\n      return b;\r\n    }\r\n\r\n    Object.setPrototypeOf(A.prototype, Buffer.prototype);\r\n    Object.setPrototypeOf(A, Buffer);\r\n\r\n    console.log(new A(4));\r\n\r\nR=@bnoordhuis \r\nAlso, will those native buffer functions need to be re-added for this to land on v4?","created_at":"2015-09-26T22:33:55Z","updated_at":"2015-10-06T21:42:30Z","closed_at":"2015-10-06T21:42:30Z","merged_at":null,"merge_commit_sha":"419e4e7a6c509a535afa47c8e57e39490c9d582a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/3080/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/3080/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/3080/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/b7eb4f1acff7f01efd1f0a5a1c7ad1a2ea6c2631","head":{"label":"trevnorris:native-buf-checks","ref":"native-buf-checks","sha":"b7eb4f1acff7f01efd1f0a5a1c7ad1a2ea6c2631","user":{"login":"trevnorris","id":289174,"avatar_url":"https://avatars.githubusercontent.com/u/289174?v=3","gravatar_id":"","url":"https://api.github.com/users/trevnorris","html_url":"https://github.com/trevnorris","followers_url":"https://api.github.com/users/trevnorris/followers","following_url":"https://api.github.com/users/trevnorris/following{/other_user}","gists_url":"https://api.github.com/users/trevnorris/gists{/gist_id}","starred_url":"https://api.github.com/users/trevnorris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trevnorris/subscriptions","organizations_url":"https://api.github.com/users/trevnorris/orgs","repos_url":"https://api.github.com/users/trevnorris/repos","events_url":"https://api.github.com/users/trevnorris/events{/privacy}","received_events_url":"https://api.github.com/users/trevnorris/received_events","type":"User","site_admin":false},"repo":{"id":29560577,"name":"node","full_name":"trevnorris/node","owner":{"login":"trevnorris","id":289174,"avatar_url":"https://avatars.githubusercontent.com/u/289174?v=3","gravatar_id":"","url":"https://api.github.com/users/trevnorris","html_url":"https://github.com/trevnorris","followers_url":"https://api.github.com/users/trevnorris/followers","following_url":"https://api.github.com/users/trevnorris/following{/other_user}","gists_url":"https://api.github.com/users/trevnorris/gists{/gist_id}","starred_url":"https://api.github.com/users/trevnorris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trevnorris/subscriptions","organizations_url":"https://api.github.com/users/trevnorris/orgs","repos_url":"https://api.github.com/users/trevnorris/repos","events_url":"https://api.github.com/users/trevnorris/events{/privacy}","received_events_url":"https://api.github.com/users/trevnorris/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/trevnorris/node","description":"A spork of Node.js with an open governance model","fork":true,"url":"https://api.github.com/repos/trevnorris/node","forks_url":"https://api.github.com/repos/trevnorris/node/forks","keys_url":"https://api.github.com/repos/trevnorris/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/trevnorris/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/trevnorris/node/teams","hooks_url":"https://api.github.com/repos/trevnorris/node/hooks","issue_events_url":"https://api.github.com/repos/trevnorris/node/issues/events{/number}","events_url":"https://api.github.com/repos/trevnorris/node/events","assignees_url":"https://api.github.com/repos/trevnorris/node/assignees{/user}","branches_url":"https://api.github.com/repos/trevnorris/node/branches{/branch}","tags_url":"https://api.github.com/repos/trevnorris/node/tags","blobs_url":"https://api.github.com/repos/trevnorris/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/trevnorris/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/trevnorris/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/trevnorris/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/trevnorris/node/statuses/{sha}","languages_url":"https://api.github.com/repos/trevnorris/node/languages","stargazers_url":"https://api.github.com/repos/trevnorris/node/stargazers","contributors_url":"https://api.github.com/repos/trevnorris/node/contributors","subscribers_url":"https://api.github.com/repos/trevnorris/node/subscribers","subscription_url":"https://api.github.com/repos/trevnorris/node/subscription","commits_url":"https://api.github.com/repos/trevnorris/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/trevnorris/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/trevnorris/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/trevnorris/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/trevnorris/node/contents/{+path}","compare_url":"https://api.github.com/repos/trevnorris/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/trevnorris/node/merges","archive_url":"https://api.github.com/repos/trevnorris/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/trevnorris/node/downloads","issues_url":"https://api.github.com/repos/trevnorris/node/issues{/number}","pulls_url":"https://api.github.com/repos/trevnorris/node/pulls{/number}","milestones_url":"https://api.github.com/repos/trevnorris/node/milestones{/number}","notifications_url":"https://api.github.com/repos/trevnorris/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/trevnorris/node/labels{/name}","releases_url":"https://api.github.com/repos/trevnorris/node/releases{/id}","created_at":"2015-01-20T23:22:42Z","updated_at":"2015-08-12T23:53:05Z","pushed_at":"2015-10-06T21:19:58Z","git_url":"git://github.com/trevnorris/node.git","ssh_url":"git@github.com:trevnorris/node.git","clone_url":"https://github.com/trevnorris/node.git","svn_url":"https://github.com/trevnorris/node","homepage":"https://iojs.org","size":144812,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"v1.x"}},"base":{"label":"nodejs:master","ref":"master","sha":"87d26152b4a0869deac5d23813ac8b0ee697ec5f","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"✨Node.js  ✨","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","created_at":"2014-11-26T19:57:11Z","updated_at":"2015-10-06T21:31:09Z","pushed_at":"2015-10-06T21:41:55Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":366660,"stargazers_count":15853,"watchers_count":15853,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1472,"mirror_url":null,"open_issues_count":510,"forks":1472,"open_issues":510,"watchers":15853,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/3080"},"html":{"href":"https://github.com/nodejs/node/pull/3080"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/3080"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/3080/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/3080/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/3080/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/b7eb4f1acff7f01efd1f0a5a1c7ad1a2ea6c2631"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":8,"review_comments":1,"commits":2,"additions":51,"deletions":16,"changed_files":3}}