{"action":"created","comment":{"url":"https://api.github.com/repos/docker/docker/pulls/comments/43461480","id":43461480,"diff_hunk":"@@ -32,30 +33,23 @@ func setupImageWithTag(c *check.C, tag string) (digest.Digest, error) {\n \n \t// tag the image to upload it to the private registry\n \trepoAndTag := utils.ImageReference(repoName, tag)\n-\tif out, _, err := dockerCmdWithError(\"commit\", containerName, repoAndTag); err != nil {\n-\t\treturn \"\", fmt.Errorf(\"image tagging failed: %s, %v\", out, err)\n-\t}\n+\tout, _, err := dockerCmdWithError(\"commit\", containerName, repoAndTag)\n+\tc.Assert(err, checker.IsNil, check.Commentf(\"image tagging failed: %s, %v\", out, err))\n \n \t// delete the container as we don't need it any more\n-\tif err := deleteContainer(containerName); err != nil {\n-\t\treturn \"\", err\n-\t}\n+\terr = deleteContainer(containerName)\n+\tc.Assert(err, checker.IsNil)\n \n \t// push the image\n-\tout, _, err := dockerCmdWithError(\"push\", repoAndTag)\n-\tif err != nil {\n-\t\treturn \"\", fmt.Errorf(\"pushing the image to the private registry has failed: %s, %v\", out, err)\n-\t}\n+\tout, _, err = dockerCmdWithError(\"push\", repoAndTag)\n+\tc.Assert(err, checker.IsNil, check.Commentf(\"pushing the image to the private registry has failed: %s, %v\", out, err))\n \n \t// delete our local repo that we previously tagged\n-\tif rmiout, _, err := dockerCmdWithError(\"rmi\", repoAndTag); err != nil {\n-\t\treturn \"\", fmt.Errorf(\"error deleting images prior to real test: %s, %v\", rmiout, err)\n-\t}\n+\trmiout, _, err := dockerCmdWithError(\"rmi\", repoAndTag)\n+\tc.Assert(err, checker.IsNil, check.Commentf(\"error deleting images prior to real test: %s, %v\", rmiout, err))\n \n \tmatches := pushDigestRegex.FindStringSubmatch(out)\n-\tif len(matches) != 2 {\n-\t\treturn \"\", fmt.Errorf(\"unable to parse digest from push output: %s\", out)\n-\t}\n+\tc.Assert(len(matches), checker.Equals, 2, check.Commentf(\"unable to parse digest from push output: %s\", out))","path":"integration-cli/docker_cli_by_digest_test.go","position":44,"original_position":44,"commit_id":"2a417e438702d21a868e0f53d5fd2b84e0fda4c9","original_commit_id":"2a417e438702d21a868e0f53d5fd2b84e0fda4c9","user":{"login":"cpuguy83","id":799078,"avatar_url":"https://avatars.githubusercontent.com/u/799078?v=3","gravatar_id":"","url":"https://api.github.com/users/cpuguy83","html_url":"https://github.com/cpuguy83","followers_url":"https://api.github.com/users/cpuguy83/followers","following_url":"https://api.github.com/users/cpuguy83/following{/other_user}","gists_url":"https://api.github.com/users/cpuguy83/gists{/gist_id}","starred_url":"https://api.github.com/users/cpuguy83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpuguy83/subscriptions","organizations_url":"https://api.github.com/users/cpuguy83/orgs","repos_url":"https://api.github.com/users/cpuguy83/repos","events_url":"https://api.github.com/users/cpuguy83/events{/privacy}","received_events_url":"https://api.github.com/users/cpuguy83/received_events","type":"User","site_admin":false},"body":"`c.Assert(matches, checker.HasLen, 2, check.Commentf(out))`","created_at":"2015-10-30T00:31:27Z","updated_at":"2015-10-30T00:31:27Z","html_url":"https://github.com/docker/docker/pull/17452#discussion_r43461480","pull_request_url":"https://api.github.com/repos/docker/docker/pulls/17452","_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/comments/43461480"},"html":{"href":"https://github.com/docker/docker/pull/17452#discussion_r43461480"},"pull_request":{"href":"https://api.github.com/repos/docker/docker/pulls/17452"}}},"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/17452","id":49066890,"html_url":"https://github.com/docker/docker/pull/17452","diff_url":"https://github.com/docker/docker/pull/17452.diff","patch_url":"https://github.com/docker/docker/pull/17452.patch","issue_url":"https://api.github.com/repos/docker/docker/issues/17452","number":17452,"state":"open","locked":false,"title":"Checkers on docker_cli_by_digest_test","user":{"login":"aditirajagopal","id":4432704,"avatar_url":"https://avatars.githubusercontent.com/u/4432704?v=3","gravatar_id":"","url":"https://api.github.com/users/aditirajagopal","html_url":"https://github.com/aditirajagopal","followers_url":"https://api.github.com/users/aditirajagopal/followers","following_url":"https://api.github.com/users/aditirajagopal/following{/other_user}","gists_url":"https://api.github.com/users/aditirajagopal/gists{/gist_id}","starred_url":"https://api.github.com/users/aditirajagopal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aditirajagopal/subscriptions","organizations_url":"https://api.github.com/users/aditirajagopal/orgs","repos_url":"https://api.github.com/users/aditirajagopal/repos","events_url":"https://api.github.com/users/aditirajagopal/events{/privacy}","received_events_url":"https://api.github.com/users/aditirajagopal/received_events","type":"User","site_admin":false},"body":"Applying #16756 to integration-cli/docker_cli_by_digest_test.go\r\n\r\nSigned-off-by: Aditi Rajagopal arajagopal@us.ibm.com","created_at":"2015-10-28T21:05:43Z","updated_at":"2015-10-30T00:31:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"33b1eebe45bce200f7ecc60307a4f67de0793efa","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/docker/docker/pulls/17452/commits","review_comments_url":"https://api.github.com/repos/docker/docker/pulls/17452/comments","review_comment_url":"https://api.github.com/repos/docker/docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/docker/issues/17452/comments","statuses_url":"https://api.github.com/repos/docker/docker/statuses/2a417e438702d21a868e0f53d5fd2b84e0fda4c9","head":{"label":"aditirajagopal:16756-docker_cli_by_digest_test","ref":"16756-docker_cli_by_digest_test","sha":"2a417e438702d21a868e0f53d5fd2b84e0fda4c9","user":{"login":"aditirajagopal","id":4432704,"avatar_url":"https://avatars.githubusercontent.com/u/4432704?v=3","gravatar_id":"","url":"https://api.github.com/users/aditirajagopal","html_url":"https://github.com/aditirajagopal","followers_url":"https://api.github.com/users/aditirajagopal/followers","following_url":"https://api.github.com/users/aditirajagopal/following{/other_user}","gists_url":"https://api.github.com/users/aditirajagopal/gists{/gist_id}","starred_url":"https://api.github.com/users/aditirajagopal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aditirajagopal/subscriptions","organizations_url":"https://api.github.com/users/aditirajagopal/orgs","repos_url":"https://api.github.com/users/aditirajagopal/repos","events_url":"https://api.github.com/users/aditirajagopal/events{/privacy}","received_events_url":"https://api.github.com/users/aditirajagopal/received_events","type":"User","site_admin":false},"repo":{"id":44126227,"name":"docker","full_name":"aditirajagopal/docker","owner":{"login":"aditirajagopal","id":4432704,"avatar_url":"https://avatars.githubusercontent.com/u/4432704?v=3","gravatar_id":"","url":"https://api.github.com/users/aditirajagopal","html_url":"https://github.com/aditirajagopal","followers_url":"https://api.github.com/users/aditirajagopal/followers","following_url":"https://api.github.com/users/aditirajagopal/following{/other_user}","gists_url":"https://api.github.com/users/aditirajagopal/gists{/gist_id}","starred_url":"https://api.github.com/users/aditirajagopal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aditirajagopal/subscriptions","organizations_url":"https://api.github.com/users/aditirajagopal/orgs","repos_url":"https://api.github.com/users/aditirajagopal/repos","events_url":"https://api.github.com/users/aditirajagopal/events{/privacy}","received_events_url":"https://api.github.com/users/aditirajagopal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aditirajagopal/docker","description":"Docker - the open-source application container engine","fork":true,"url":"https://api.github.com/repos/aditirajagopal/docker","forks_url":"https://api.github.com/repos/aditirajagopal/docker/forks","keys_url":"https://api.github.com/repos/aditirajagopal/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aditirajagopal/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aditirajagopal/docker/teams","hooks_url":"https://api.github.com/repos/aditirajagopal/docker/hooks","issue_events_url":"https://api.github.com/repos/aditirajagopal/docker/issues/events{/number}","events_url":"https://api.github.com/repos/aditirajagopal/docker/events","assignees_url":"https://api.github.com/repos/aditirajagopal/docker/assignees{/user}","branches_url":"https://api.github.com/repos/aditirajagopal/docker/branches{/branch}","tags_url":"https://api.github.com/repos/aditirajagopal/docker/tags","blobs_url":"https://api.github.com/repos/aditirajagopal/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aditirajagopal/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aditirajagopal/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/aditirajagopal/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aditirajagopal/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/aditirajagopal/docker/languages","stargazers_url":"https://api.github.com/repos/aditirajagopal/docker/stargazers","contributors_url":"https://api.github.com/repos/aditirajagopal/docker/contributors","subscribers_url":"https://api.github.com/repos/aditirajagopal/docker/subscribers","subscription_url":"https://api.github.com/repos/aditirajagopal/docker/subscription","commits_url":"https://api.github.com/repos/aditirajagopal/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/aditirajagopal/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/aditirajagopal/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/aditirajagopal/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/aditirajagopal/docker/contents/{+path}","compare_url":"https://api.github.com/repos/aditirajagopal/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aditirajagopal/docker/merges","archive_url":"https://api.github.com/repos/aditirajagopal/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aditirajagopal/docker/downloads","issues_url":"https://api.github.com/repos/aditirajagopal/docker/issues{/number}","pulls_url":"https://api.github.com/repos/aditirajagopal/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/aditirajagopal/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/aditirajagopal/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aditirajagopal/docker/labels{/name}","releases_url":"https://api.github.com/repos/aditirajagopal/docker/releases{/id}","created_at":"2015-10-12T18:29:27Z","updated_at":"2015-10-12T18:48:09Z","pushed_at":"2015-10-29T17:10:37Z","git_url":"git://github.com/aditirajagopal/docker.git","ssh_url":"git@github.com:aditirajagopal/docker.git","clone_url":"https://github.com/aditirajagopal/docker.git","svn_url":"https://github.com/aditirajagopal/docker","homepage":"http://www.docker.com","size":72242,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"54d42f4a107641c2755ea1d6e55ca41d8945f4f8","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":7691631,"name":"docker","full_name":"docker/docker","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/docker","description":"Docker - the open-source application container engine","fork":false,"url":"https://api.github.com/repos/docker/docker","forks_url":"https://api.github.com/repos/docker/docker/forks","keys_url":"https://api.github.com/repos/docker/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/docker/teams","hooks_url":"https://api.github.com/repos/docker/docker/hooks","issue_events_url":"https://api.github.com/repos/docker/docker/issues/events{/number}","events_url":"https://api.github.com/repos/docker/docker/events","assignees_url":"https://api.github.com/repos/docker/docker/assignees{/user}","branches_url":"https://api.github.com/repos/docker/docker/branches{/branch}","tags_url":"https://api.github.com/repos/docker/docker/tags","blobs_url":"https://api.github.com/repos/docker/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/docker/languages","stargazers_url":"https://api.github.com/repos/docker/docker/stargazers","contributors_url":"https://api.github.com/repos/docker/docker/contributors","subscribers_url":"https://api.github.com/repos/docker/docker/subscribers","subscription_url":"https://api.github.com/repos/docker/docker/subscription","commits_url":"https://api.github.com/repos/docker/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/docker/contents/{+path}","compare_url":"https://api.github.com/repos/docker/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/docker/merges","archive_url":"https://api.github.com/repos/docker/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/docker/downloads","issues_url":"https://api.github.com/repos/docker/docker/issues{/number}","pulls_url":"https://api.github.com/repos/docker/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/docker/labels{/name}","releases_url":"https://api.github.com/repos/docker/docker/releases{/id}","created_at":"2013-01-18T18:10:57Z","updated_at":"2015-10-30T00:12:12Z","pushed_at":"2015-10-30T00:26:57Z","git_url":"git://github.com/docker/docker.git","ssh_url":"git@github.com:docker/docker.git","clone_url":"https://github.com/docker/docker.git","svn_url":"https://github.com/docker/docker","homepage":"http://www.docker.com","size":277423,"stargazers_count":25769,"watchers_count":25769,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6867,"mirror_url":null,"open_issues_count":1169,"forks":6867,"open_issues":1169,"watchers":25769,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/17452"},"html":{"href":"https://github.com/docker/docker/pull/17452"},"issue":{"href":"https://api.github.com/repos/docker/docker/issues/17452"},"comments":{"href":"https://api.github.com/repos/docker/docker/issues/17452/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/docker/pulls/17452/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/docker/pulls/17452/commits"},"statuses":{"href":"https://api.github.com/repos/docker/docker/statuses/2a417e438702d21a868e0f53d5fd2b84e0fda4c9"}}}}