{"action":"created","comment":{"url":"https://api.github.com/repos/npm/newww/pulls/comments/30709774","id":30709774,"diff_hunk":"@@ -63,10 +63,20 @@ Cache._fingerprint = function _fingerprint(obj)\n     }\n     delete cleaned.ttl;\n \n+    return JSON.stringify(cleaned);\n+};\n+\n+Cache._fingerprint = function _fingerprint(key)\n+{\n+    if (!_.isString(key)) {\n+        key = this._cleanObj(key);\n+    }\n+","path":"lib/cache.js","position":21,"original_position":21,"commit_id":"3ff8032e4c38e4bd8e810dbf6071e349f4e9e5f6","original_commit_id":"3ff8032e4c38e4bd8e810dbf6071e349f4e9e5f6","user":{"login":"ceejbot","id":757502,"avatar_url":"https://avatars.githubusercontent.com/u/757502?v=3","gravatar_id":"","url":"https://api.github.com/users/ceejbot","html_url":"https://github.com/ceejbot","followers_url":"https://api.github.com/users/ceejbot/followers","following_url":"https://api.github.com/users/ceejbot/following{/other_user}","gists_url":"https://api.github.com/users/ceejbot/gists{/gist_id}","starred_url":"https://api.github.com/users/ceejbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceejbot/subscriptions","organizations_url":"https://api.github.com/users/ceejbot/orgs","repos_url":"https://api.github.com/users/ceejbot/repos","events_url":"https://api.github.com/users/ceejbot/events{/privacy}","received_events_url":"https://api.github.com/users/ceejbot/received_events","type":"User","site_admin":false},"body":"Nice touch here: hashes + prepends the name space but only mangles an object if needed.","created_at":"2015-05-20T14:48:15Z","updated_at":"2015-05-20T14:48:15Z","html_url":"https://github.com/npm/newww/pull/983#discussion_r30709774","pull_request_url":"https://api.github.com/repos/npm/newww/pulls/983","_links":{"self":{"href":"https://api.github.com/repos/npm/newww/pulls/comments/30709774"},"html":{"href":"https://github.com/npm/newww/pull/983#discussion_r30709774"},"pull_request":{"href":"https://api.github.com/repos/npm/newww/pulls/983"}}},"pull_request":{"url":"https://api.github.com/repos/npm/newww/pulls/983","id":35790457,"html_url":"https://github.com/npm/newww/pull/983","diff_url":"https://github.com/npm/newww/pull/983.diff","patch_url":"https://github.com/npm/newww/pull/983.patch","issue_url":"https://api.github.com/repos/npm/newww/issues/983","number":983,"state":"open","locked":false,"title":"cache is-paid status","user":{"login":"rockbot","id":954269,"avatar_url":"https://avatars.githubusercontent.com/u/954269?v=3","gravatar_id":"","url":"https://api.github.com/users/rockbot","html_url":"https://github.com/rockbot","followers_url":"https://api.github.com/users/rockbot/followers","following_url":"https://api.github.com/users/rockbot/following{/other_user}","gists_url":"https://api.github.com/users/rockbot/gists{/gist_id}","starred_url":"https://api.github.com/users/rockbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rockbot/subscriptions","organizations_url":"https://api.github.com/users/rockbot/orgs","repos_url":"https://api.github.com/users/rockbot/repos","events_url":"https://api.github.com/users/rockbot/events{/privacy}","received_events_url":"https://api.github.com/users/rockbot/received_events","type":"User","site_admin":false},"body":"It took a while due to yaks needing shaving, but finally we have cached isPaid information!\r\n\r\n(The biggest issue was getting all the tests to pass - they should be doing so now.)\r\n\r\nThe included commits give a pretty good idea of what went down in the process of putting together this PR.","created_at":"2015-05-20T01:15:36Z","updated_at":"2015-05-20T14:48:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f3db4889e7ce7e4ba086e7fe2d69994a64b06353","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/npm/newww/pulls/983/commits","review_comments_url":"https://api.github.com/repos/npm/newww/pulls/983/comments","review_comment_url":"https://api.github.com/repos/npm/newww/pulls/comments{/number}","comments_url":"https://api.github.com/repos/npm/newww/issues/983/comments","statuses_url":"https://api.github.com/repos/npm/newww/statuses/3ff8032e4c38e4bd8e810dbf6071e349f4e9e5f6","head":{"label":"npm:ceej/cache-is-paid","ref":"ceej/cache-is-paid","sha":"3ff8032e4c38e4bd8e810dbf6071e349f4e9e5f6","user":{"login":"npm","id":6078720,"avatar_url":"https://avatars.githubusercontent.com/u/6078720?v=3","gravatar_id":"","url":"https://api.github.com/users/npm","html_url":"https://github.com/npm","followers_url":"https://api.github.com/users/npm/followers","following_url":"https://api.github.com/users/npm/following{/other_user}","gists_url":"https://api.github.com/users/npm/gists{/gist_id}","starred_url":"https://api.github.com/users/npm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/npm/subscriptions","organizations_url":"https://api.github.com/users/npm/orgs","repos_url":"https://api.github.com/users/npm/repos","events_url":"https://api.github.com/users/npm/events{/privacy}","received_events_url":"https://api.github.com/users/npm/received_events","type":"Organization","site_admin":false},"repo":{"id":19872239,"name":"newww","full_name":"npm/newww","owner":{"login":"npm","id":6078720,"avatar_url":"https://avatars.githubusercontent.com/u/6078720?v=3","gravatar_id":"","url":"https://api.github.com/users/npm","html_url":"https://github.com/npm","followers_url":"https://api.github.com/users/npm/followers","following_url":"https://api.github.com/users/npm/following{/other_user}","gists_url":"https://api.github.com/users/npm/gists{/gist_id}","starred_url":"https://api.github.com/users/npm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/npm/subscriptions","organizations_url":"https://api.github.com/users/npm/orgs","repos_url":"https://api.github.com/users/npm/repos","events_url":"https://api.github.com/users/npm/events{/privacy}","received_events_url":"https://api.github.com/users/npm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/npm/newww","description":"The npm website","fork":false,"url":"https://api.github.com/repos/npm/newww","forks_url":"https://api.github.com/repos/npm/newww/forks","keys_url":"https://api.github.com/repos/npm/newww/keys{/key_id}","collaborators_url":"https://api.github.com/repos/npm/newww/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/npm/newww/teams","hooks_url":"https://api.github.com/repos/npm/newww/hooks","issue_events_url":"https://api.github.com/repos/npm/newww/issues/events{/number}","events_url":"https://api.github.com/repos/npm/newww/events","assignees_url":"https://api.github.com/repos/npm/newww/assignees{/user}","branches_url":"https://api.github.com/repos/npm/newww/branches{/branch}","tags_url":"https://api.github.com/repos/npm/newww/tags","blobs_url":"https://api.github.com/repos/npm/newww/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/npm/newww/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/npm/newww/git/refs{/sha}","trees_url":"https://api.github.com/repos/npm/newww/git/trees{/sha}","statuses_url":"https://api.github.com/repos/npm/newww/statuses/{sha}","languages_url":"https://api.github.com/repos/npm/newww/languages","stargazers_url":"https://api.github.com/repos/npm/newww/stargazers","contributors_url":"https://api.github.com/repos/npm/newww/contributors","subscribers_url":"https://api.github.com/repos/npm/newww/subscribers","subscription_url":"https://api.github.com/repos/npm/newww/subscription","commits_url":"https://api.github.com/repos/npm/newww/commits{/sha}","git_commits_url":"https://api.github.com/repos/npm/newww/git/commits{/sha}","comments_url":"https://api.github.com/repos/npm/newww/comments{/number}","issue_comment_url":"https://api.github.com/repos/npm/newww/issues/comments{/number}","contents_url":"https://api.github.com/repos/npm/newww/contents/{+path}","compare_url":"https://api.github.com/repos/npm/newww/compare/{base}...{head}","merges_url":"https://api.github.com/repos/npm/newww/merges","archive_url":"https://api.github.com/repos/npm/newww/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/npm/newww/downloads","issues_url":"https://api.github.com/repos/npm/newww/issues{/number}","pulls_url":"https://api.github.com/repos/npm/newww/pulls{/number}","milestones_url":"https://api.github.com/repos/npm/newww/milestones{/number}","notifications_url":"https://api.github.com/repos/npm/newww/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/npm/newww/labels{/name}","releases_url":"https://api.github.com/repos/npm/newww/releases{/id}","created_at":"2014-05-16T22:12:47Z","updated_at":"2015-05-16T05:20:37Z","pushed_at":"2015-05-20T01:15:37Z","git_url":"git://github.com/npm/newww.git","ssh_url":"git@github.com:npm/newww.git","clone_url":"https://github.com/npm/newww.git","svn_url":"https://github.com/npm/newww","homepage":"http://npmjs.com","size":15626,"stargazers_count":324,"watchers_count":324,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":101,"mirror_url":null,"open_issues_count":146,"forks":101,"open_issues":146,"watchers":324,"default_branch":"master"}},"base":{"label":"npm:master","ref":"master","sha":"627531d7f5fbfdd9006e46fadaed2aa066f0795e","user":{"login":"npm","id":6078720,"avatar_url":"https://avatars.githubusercontent.com/u/6078720?v=3","gravatar_id":"","url":"https://api.github.com/users/npm","html_url":"https://github.com/npm","followers_url":"https://api.github.com/users/npm/followers","following_url":"https://api.github.com/users/npm/following{/other_user}","gists_url":"https://api.github.com/users/npm/gists{/gist_id}","starred_url":"https://api.github.com/users/npm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/npm/subscriptions","organizations_url":"https://api.github.com/users/npm/orgs","repos_url":"https://api.github.com/users/npm/repos","events_url":"https://api.github.com/users/npm/events{/privacy}","received_events_url":"https://api.github.com/users/npm/received_events","type":"Organization","site_admin":false},"repo":{"id":19872239,"name":"newww","full_name":"npm/newww","owner":{"login":"npm","id":6078720,"avatar_url":"https://avatars.githubusercontent.com/u/6078720?v=3","gravatar_id":"","url":"https://api.github.com/users/npm","html_url":"https://github.com/npm","followers_url":"https://api.github.com/users/npm/followers","following_url":"https://api.github.com/users/npm/following{/other_user}","gists_url":"https://api.github.com/users/npm/gists{/gist_id}","starred_url":"https://api.github.com/users/npm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/npm/subscriptions","organizations_url":"https://api.github.com/users/npm/orgs","repos_url":"https://api.github.com/users/npm/repos","events_url":"https://api.github.com/users/npm/events{/privacy}","received_events_url":"https://api.github.com/users/npm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/npm/newww","description":"The npm website","fork":false,"url":"https://api.github.com/repos/npm/newww","forks_url":"https://api.github.com/repos/npm/newww/forks","keys_url":"https://api.github.com/repos/npm/newww/keys{/key_id}","collaborators_url":"https://api.github.com/repos/npm/newww/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/npm/newww/teams","hooks_url":"https://api.github.com/repos/npm/newww/hooks","issue_events_url":"https://api.github.com/repos/npm/newww/issues/events{/number}","events_url":"https://api.github.com/repos/npm/newww/events","assignees_url":"https://api.github.com/repos/npm/newww/assignees{/user}","branches_url":"https://api.github.com/repos/npm/newww/branches{/branch}","tags_url":"https://api.github.com/repos/npm/newww/tags","blobs_url":"https://api.github.com/repos/npm/newww/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/npm/newww/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/npm/newww/git/refs{/sha}","trees_url":"https://api.github.com/repos/npm/newww/git/trees{/sha}","statuses_url":"https://api.github.com/repos/npm/newww/statuses/{sha}","languages_url":"https://api.github.com/repos/npm/newww/languages","stargazers_url":"https://api.github.com/repos/npm/newww/stargazers","contributors_url":"https://api.github.com/repos/npm/newww/contributors","subscribers_url":"https://api.github.com/repos/npm/newww/subscribers","subscription_url":"https://api.github.com/repos/npm/newww/subscription","commits_url":"https://api.github.com/repos/npm/newww/commits{/sha}","git_commits_url":"https://api.github.com/repos/npm/newww/git/commits{/sha}","comments_url":"https://api.github.com/repos/npm/newww/comments{/number}","issue_comment_url":"https://api.github.com/repos/npm/newww/issues/comments{/number}","contents_url":"https://api.github.com/repos/npm/newww/contents/{+path}","compare_url":"https://api.github.com/repos/npm/newww/compare/{base}...{head}","merges_url":"https://api.github.com/repos/npm/newww/merges","archive_url":"https://api.github.com/repos/npm/newww/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/npm/newww/downloads","issues_url":"https://api.github.com/repos/npm/newww/issues{/number}","pulls_url":"https://api.github.com/repos/npm/newww/pulls{/number}","milestones_url":"https://api.github.com/repos/npm/newww/milestones{/number}","notifications_url":"https://api.github.com/repos/npm/newww/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/npm/newww/labels{/name}","releases_url":"https://api.github.com/repos/npm/newww/releases{/id}","created_at":"2014-05-16T22:12:47Z","updated_at":"2015-05-16T05:20:37Z","pushed_at":"2015-05-20T01:15:37Z","git_url":"git://github.com/npm/newww.git","ssh_url":"git@github.com:npm/newww.git","clone_url":"https://github.com/npm/newww.git","svn_url":"https://github.com/npm/newww","homepage":"http://npmjs.com","size":15626,"stargazers_count":324,"watchers_count":324,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":101,"mirror_url":null,"open_issues_count":146,"forks":101,"open_issues":146,"watchers":324,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/npm/newww/pulls/983"},"html":{"href":"https://github.com/npm/newww/pull/983"},"issue":{"href":"https://api.github.com/repos/npm/newww/issues/983"},"comments":{"href":"https://api.github.com/repos/npm/newww/issues/983/comments"},"review_comments":{"href":"https://api.github.com/repos/npm/newww/pulls/983/comments"},"review_comment":{"href":"https://api.github.com/repos/npm/newww/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/npm/newww/pulls/983/commits"},"statuses":{"href":"https://api.github.com/repos/npm/newww/statuses/3ff8032e4c38e4bd8e810dbf6071e349f4e9e5f6"}}}}