{"action":"created","issue":{"url":"https://api.github.com/repos/callemall/material-ui/issues/2473","labels_url":"https://api.github.com/repos/callemall/material-ui/issues/2473/labels{/name}","comments_url":"https://api.github.com/repos/callemall/material-ui/issues/2473/comments","events_url":"https://api.github.com/repos/callemall/material-ui/issues/2473/events","html_url":"https://github.com/callemall/material-ui/pull/2473","id":121612840,"number":2473,"title":"[WIP] Initial implementation of divider component","user":{"login":"newoga","id":344018,"avatar_url":"https://avatars.githubusercontent.com/u/344018?v=3","gravatar_id":"","url":"https://api.github.com/users/newoga","html_url":"https://github.com/newoga","followers_url":"https://api.github.com/users/newoga/followers","following_url":"https://api.github.com/users/newoga/following{/other_user}","gists_url":"https://api.github.com/users/newoga/gists{/gist_id}","starred_url":"https://api.github.com/users/newoga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/newoga/subscriptions","organizations_url":"https://api.github.com/users/newoga/orgs","repos_url":"https://api.github.com/users/newoga/repos","events_url":"https://api.github.com/users/newoga/events{/privacy}","received_events_url":"https://api.github.com/users/newoga/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-12-11T01:05:05Z","updated_at":"2015-12-11T01:11:28Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/callemall/material-ui/pulls/2473","html_url":"https://github.com/callemall/material-ui/pull/2473","diff_url":"https://github.com/callemall/material-ui/pull/2473.diff","patch_url":"https://github.com/callemall/material-ui/pull/2473.patch"},"body":"This resolves #2457. \r\n\r\n**Done:**\r\n- Implemented a `divider.jsx` in root with same implementation as original `list-divider.jsx`\r\n- Reimplemented `list-divider.jsx` and `menu-divider.jsx` as stateless components that wrap `divider.jsx` and emit warnings when used. (`menu-divider.jsx` applies original style overrides for backwards compatibility).\r\n\r\n**Todo:**\r\n- Remove dependencies on `list-divider.jsx` and `menu-divider.jsx` in internal components and documentation.\r\n- Consider adding documentation on `<Divider />` component when used independently of other components."},"comment":{"url":"https://api.github.com/repos/callemall/material-ui/issues/comments/163801301","html_url":"https://github.com/callemall/material-ui/pull/2473#issuecomment-163801301","issue_url":"https://api.github.com/repos/callemall/material-ui/issues/2473","id":163801301,"user":{"login":"newoga","id":344018,"avatar_url":"https://avatars.githubusercontent.com/u/344018?v=3","gravatar_id":"","url":"https://api.github.com/users/newoga","html_url":"https://github.com/newoga","followers_url":"https://api.github.com/users/newoga/followers","following_url":"https://api.github.com/users/newoga/following{/other_user}","gists_url":"https://api.github.com/users/newoga/gists{/gist_id}","starred_url":"https://api.github.com/users/newoga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/newoga/subscriptions","organizations_url":"https://api.github.com/users/newoga/orgs","repos_url":"https://api.github.com/users/newoga/repos","events_url":"https://api.github.com/users/newoga/events{/privacy}","received_events_url":"https://api.github.com/users/newoga/received_events","type":"User","site_admin":false},"created_at":"2015-12-11T01:11:28Z","updated_at":"2015-12-11T01:11:28Z","body":"Side thought, I noticed we have `./util/styles.js` and `./util/immutability-helper.js`. \r\n\r\n`./util/styles.js` uses `./util/immutability-helper.js` heavily but is missing the `merge()` method. There are a few components that don't use the style mixin but import `immutability-helper`. These components are examples of that:\r\n\r\n- flat-button.jsx\r\n- nested-list.jsx\r\n- touch-ripple.jsx\r\n\r\nI think components that aren't using the mixin should be switched to use the style util class instead of importing the immutability helper."}}