{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/46184192","id":46184192,"diff_hunk":"@@ -107,7 +107,7 @@ var Dialog = function(params) {\n     event.preventDefault();\n   });\n \n-  this.form.addEventListener('transitionend', function(event) {\n+  window.eventSafety(this.form, 'transitionend', function(event) {\n     var form = event.target;","path":"apps/sms/views/shared/js/dialog.js","position":6,"original_position":6,"commit_id":"8fc24ef1c853cd575940dfc3903f066762f6829f","original_commit_id":"8fc24ef1c853cd575940dfc3903f066762f6829f","user":{"login":"julienw","id":454175,"avatar_url":"https://avatars.githubusercontent.com/u/454175?v=3","gravatar_id":"","url":"https://api.github.com/users/julienw","html_url":"https://github.com/julienw","followers_url":"https://api.github.com/users/julienw/followers","following_url":"https://api.github.com/users/julienw/following{/other_user}","gists_url":"https://api.github.com/users/julienw/gists{/gist_id}","starred_url":"https://api.github.com/users/julienw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julienw/subscriptions","organizations_url":"https://api.github.com/users/julienw/orgs","repos_url":"https://api.github.com/users/julienw/repos","events_url":"https://api.github.com/users/julienw/events{/privacy}","received_events_url":"https://api.github.com/users/julienw/received_events","type":"User","site_admin":false},"body":"I think the eventSafety lib should never pass the event, it brings an expectation that's not always fulfilled unfortunately. Or it could create a TransitionEvent.","created_at":"2015-11-30T18:45:57Z","updated_at":"2015-11-30T18:45:57Z","html_url":"https://github.com/mozilla-b2g/gaia/pull/33433#discussion_r46184192","pull_request_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/33433","_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/46184192"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/33433#discussion_r46184192"},"pull_request":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/33433"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/33433","id":52070428,"html_url":"https://github.com/mozilla-b2g/gaia/pull/33433","diff_url":"https://github.com/mozilla-b2g/gaia/pull/33433.diff","patch_url":"https://github.com/mozilla-b2g/gaia/pull/33433.patch","issue_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/33433","number":33433,"state":"open","locked":false,"title":"Bug 1227424 - [Sms] Use event_safety lib for dialogs","user":{"login":"KevinGrandon","id":122602,"avatar_url":"https://avatars.githubusercontent.com/u/122602?v=3","gravatar_id":"","url":"https://api.github.com/users/KevinGrandon","html_url":"https://github.com/KevinGrandon","followers_url":"https://api.github.com/users/KevinGrandon/followers","following_url":"https://api.github.com/users/KevinGrandon/following{/other_user}","gists_url":"https://api.github.com/users/KevinGrandon/gists{/gist_id}","starred_url":"https://api.github.com/users/KevinGrandon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KevinGrandon/subscriptions","organizations_url":"https://api.github.com/users/KevinGrandon/orgs","repos_url":"https://api.github.com/users/KevinGrandon/repos","events_url":"https://api.github.com/users/KevinGrandon/events{/privacy}","received_events_url":"https://api.github.com/users/KevinGrandon/received_events","type":"User","site_admin":false},"body":"https://bugzilla.mozilla.org/show_bug.cgi?id=1227424","created_at":"2015-11-29T20:40:17Z","updated_at":"2015-11-30T18:45:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b675292997536e12c58f0d7f68a82cce131a2236","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/33433/commits","review_comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/33433/comments","review_comment_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/33433/comments","statuses_url":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/8fc24ef1c853cd575940dfc3903f066762f6829f","head":{"label":"KevinGrandon:bug_1227424_sms_dialog_use_event_safety","ref":"bug_1227424_sms_dialog_use_event_safety","sha":"8fc24ef1c853cd575940dfc3903f066762f6829f","user":{"login":"KevinGrandon","id":122602,"avatar_url":"https://avatars.githubusercontent.com/u/122602?v=3","gravatar_id":"","url":"https://api.github.com/users/KevinGrandon","html_url":"https://github.com/KevinGrandon","followers_url":"https://api.github.com/users/KevinGrandon/followers","following_url":"https://api.github.com/users/KevinGrandon/following{/other_user}","gists_url":"https://api.github.com/users/KevinGrandon/gists{/gist_id}","starred_url":"https://api.github.com/users/KevinGrandon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KevinGrandon/subscriptions","organizations_url":"https://api.github.com/users/KevinGrandon/orgs","repos_url":"https://api.github.com/users/KevinGrandon/repos","events_url":"https://api.github.com/users/KevinGrandon/events{/privacy}","received_events_url":"https://api.github.com/users/KevinGrandon/received_events","type":"User","site_admin":false},"repo":{"id":6770930,"name":"gaia","full_name":"KevinGrandon/gaia","owner":{"login":"KevinGrandon","id":122602,"avatar_url":"https://avatars.githubusercontent.com/u/122602?v=3","gravatar_id":"","url":"https://api.github.com/users/KevinGrandon","html_url":"https://github.com/KevinGrandon","followers_url":"https://api.github.com/users/KevinGrandon/followers","following_url":"https://api.github.com/users/KevinGrandon/following{/other_user}","gists_url":"https://api.github.com/users/KevinGrandon/gists{/gist_id}","starred_url":"https://api.github.com/users/KevinGrandon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KevinGrandon/subscriptions","organizations_url":"https://api.github.com/users/KevinGrandon/orgs","repos_url":"https://api.github.com/users/KevinGrandon/repos","events_url":"https://api.github.com/users/KevinGrandon/events{/privacy}","received_events_url":"https://api.github.com/users/KevinGrandon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/KevinGrandon/gaia","description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project","fork":true,"url":"https://api.github.com/repos/KevinGrandon/gaia","forks_url":"https://api.github.com/repos/KevinGrandon/gaia/forks","keys_url":"https://api.github.com/repos/KevinGrandon/gaia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KevinGrandon/gaia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KevinGrandon/gaia/teams","hooks_url":"https://api.github.com/repos/KevinGrandon/gaia/hooks","issue_events_url":"https://api.github.com/repos/KevinGrandon/gaia/issues/events{/number}","events_url":"https://api.github.com/repos/KevinGrandon/gaia/events","assignees_url":"https://api.github.com/repos/KevinGrandon/gaia/assignees{/user}","branches_url":"https://api.github.com/repos/KevinGrandon/gaia/branches{/branch}","tags_url":"https://api.github.com/repos/KevinGrandon/gaia/tags","blobs_url":"https://api.github.com/repos/KevinGrandon/gaia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KevinGrandon/gaia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KevinGrandon/gaia/git/refs{/sha}","trees_url":"https://api.github.com/repos/KevinGrandon/gaia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KevinGrandon/gaia/statuses/{sha}","languages_url":"https://api.github.com/repos/KevinGrandon/gaia/languages","stargazers_url":"https://api.github.com/repos/KevinGrandon/gaia/stargazers","contributors_url":"https://api.github.com/repos/KevinGrandon/gaia/contributors","subscribers_url":"https://api.github.com/repos/KevinGrandon/gaia/subscribers","subscription_url":"https://api.github.com/repos/KevinGrandon/gaia/subscription","commits_url":"https://api.github.com/repos/KevinGrandon/gaia/commits{/sha}","git_commits_url":"https://api.github.com/repos/KevinGrandon/gaia/git/commits{/sha}","comments_url":"https://api.github.com/repos/KevinGrandon/gaia/comments{/number}","issue_comment_url":"https://api.github.com/repos/KevinGrandon/gaia/issues/comments{/number}","contents_url":"https://api.github.com/repos/KevinGrandon/gaia/contents/{+path}","compare_url":"https://api.github.com/repos/KevinGrandon/gaia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KevinGrandon/gaia/merges","archive_url":"https://api.github.com/repos/KevinGrandon/gaia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KevinGrandon/gaia/downloads","issues_url":"https://api.github.com/repos/KevinGrandon/gaia/issues{/number}","pulls_url":"https://api.github.com/repos/KevinGrandon/gaia/pulls{/number}","milestones_url":"https://api.github.com/repos/KevinGrandon/gaia/milestones{/number}","notifications_url":"https://api.github.com/repos/KevinGrandon/gaia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KevinGrandon/gaia/labels{/name}","releases_url":"https://api.github.com/repos/KevinGrandon/gaia/releases{/id}","created_at":"2012-11-20T02:22:33Z","updated_at":"2015-05-08T19:36:20Z","pushed_at":"2015-11-30T16:20:48Z","git_url":"git://github.com/KevinGrandon/gaia.git","ssh_url":"git@github.com:KevinGrandon/gaia.git","clone_url":"https://github.com/KevinGrandon/gaia.git","svn_url":"https://github.com/KevinGrandon/gaia","homepage":"https://wiki.mozilla.org/B2G","size":979316,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla-b2g:master","ref":"master","sha":"fa9b88501c84cbb171db9d778cca74b70d80f433","user":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"repo":{"id":2317369,"name":"gaia","full_name":"mozilla-b2g/gaia","owner":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-b2g/gaia","description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see","fork":false,"url":"https://api.github.com/repos/mozilla-b2g/gaia","forks_url":"https://api.github.com/repos/mozilla-b2g/gaia/forks","keys_url":"https://api.github.com/repos/mozilla-b2g/gaia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-b2g/gaia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-b2g/gaia/teams","hooks_url":"https://api.github.com/repos/mozilla-b2g/gaia/hooks","issue_events_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-b2g/gaia/events","assignees_url":"https://api.github.com/repos/mozilla-b2g/gaia/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-b2g/gaia/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-b2g/gaia/tags","blobs_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-b2g/gaia/languages","stargazers_url":"https://api.github.com/repos/mozilla-b2g/gaia/stargazers","contributors_url":"https://api.github.com/repos/mozilla-b2g/gaia/contributors","subscribers_url":"https://api.github.com/repos/mozilla-b2g/gaia/subscribers","subscription_url":"https://api.github.com/repos/mozilla-b2g/gaia/subscription","commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla-b2g/gaia/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-b2g/gaia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-b2g/gaia/merges","archive_url":"https://api.github.com/repos/mozilla-b2g/gaia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-b2g/gaia/downloads","issues_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-b2g/gaia/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-b2g/gaia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-b2g/gaia/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-b2g/gaia/releases{/id}","created_at":"2011-09-03T01:38:46Z","updated_at":"2015-11-30T18:01:09Z","pushed_at":"2015-11-30T18:28:06Z","git_url":"git://github.com/mozilla-b2g/gaia.git","ssh_url":"git@github.com:mozilla-b2g/gaia.git","clone_url":"https://github.com/mozilla-b2g/gaia.git","svn_url":"https://github.com/mozilla-b2g/gaia","homepage":"https://wiki.mozilla.org/B2G","size":1186365,"stargazers_count":2012,"watchers_count":2012,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":2562,"mirror_url":null,"open_issues_count":1283,"forks":2562,"open_issues":1283,"watchers":2012,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/33433"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/33433"},"issue":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/issues/33433"},"comments":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/issues/33433/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/33433/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/33433/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/8fc24ef1c853cd575940dfc3903f066762f6829f"}}}}