{"action":"created","comment":{"url":"https://api.github.com/repos/chef/chef-server/pulls/comments/43336493","id":43336493,"diff_hunk":"@@ -11,6 +11,6 @@ require \"dvm\"\n \n begin\n   DVM::Application.start(ARGV)\n-rescue DVM::DVMArgumentError => e","path":"dev/dvm/bin/dvm","position":4,"original_position":4,"commit_id":"9b811f27de71df41a471e9a863bd451906ae3aa4","original_commit_id":"9b811f27de71df41a471e9a863bd451906ae3aa4","user":{"login":"sdelano","id":76847,"avatar_url":"https://avatars.githubusercontent.com/u/76847?v=3","gravatar_id":"","url":"https://api.github.com/users/sdelano","html_url":"https://github.com/sdelano","followers_url":"https://api.github.com/users/sdelano/followers","following_url":"https://api.github.com/users/sdelano/following{/other_user}","gists_url":"https://api.github.com/users/sdelano/gists{/gist_id}","starred_url":"https://api.github.com/users/sdelano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdelano/subscriptions","organizations_url":"https://api.github.com/users/sdelano/orgs","repos_url":"https://api.github.com/users/sdelano/repos","events_url":"https://api.github.com/users/sdelano/events{/privacy}","received_events_url":"https://api.github.com/users/sdelano/received_events","type":"User","site_admin":false},"body":"If it wasn't getting rescued before, where did it end up?","created_at":"2015-10-29T00:23:34Z","updated_at":"2015-10-29T00:23:34Z","html_url":"https://github.com/chef/chef-server/pull/588#discussion_r43336493","pull_request_url":"https://api.github.com/repos/chef/chef-server/pulls/588","_links":{"self":{"href":"https://api.github.com/repos/chef/chef-server/pulls/comments/43336493"},"html":{"href":"https://github.com/chef/chef-server/pull/588#discussion_r43336493"},"pull_request":{"href":"https://api.github.com/repos/chef/chef-server/pulls/588"}}},"pull_request":{"url":"https://api.github.com/repos/chef/chef-server/pulls/588","id":49080772,"html_url":"https://github.com/chef/chef-server/pull/588","diff_url":"https://github.com/chef/chef-server/pull/588.diff","patch_url":"https://github.com/chef/chef-server/pull/588.patch","issue_url":"https://api.github.com/repos/chef/chef-server/issues/588","number":588,"state":"open","locked":false,"title":"dvm fixes to fix unhelpful error messages and enable successful loading of bifrost","user":{"login":"irvingpop","id":1616328,"avatar_url":"https://avatars.githubusercontent.com/u/1616328?v=3","gravatar_id":"","url":"https://api.github.com/users/irvingpop","html_url":"https://github.com/irvingpop","followers_url":"https://api.github.com/users/irvingpop/followers","following_url":"https://api.github.com/users/irvingpop/following{/other_user}","gists_url":"https://api.github.com/users/irvingpop/gists{/gist_id}","starred_url":"https://api.github.com/users/irvingpop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/irvingpop/subscriptions","organizations_url":"https://api.github.com/users/irvingpop/orgs","repos_url":"https://api.github.com/users/irvingpop/repos","events_url":"https://api.github.com/users/irvingpop/events{/privacy}","received_events_url":"https://api.github.com/users/irvingpop/received_events","type":"User","site_admin":false},"body":"Thanks to @marcparadise for help with these.   3 specific fixes that got me unstuck:\r\n\r\n1. `dev/dvm/bin/dvm`:   The rescue was masking the underlying failure -  loosen up what we rescue in order to always show the underlying failure\r\n2. `dev/dvm/lib/dvm.rb`:  a class definition went missing which was masking the `raise` messages with an unhelpful message\r\n3.  `src/oc_bifrost/Makefile`:  remove an errant `bundle` target from `oc_bifrost` so that it can be successfully loaded","created_at":"2015-10-28T23:21:23Z","updated_at":"2015-10-29T00:23:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b363e3afdf1e4ddb4ee0461e7b56b3946d10d970","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/chef/chef-server/pulls/588/commits","review_comments_url":"https://api.github.com/repos/chef/chef-server/pulls/588/comments","review_comment_url":"https://api.github.com/repos/chef/chef-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chef/chef-server/issues/588/comments","statuses_url":"https://api.github.com/repos/chef/chef-server/statuses/9b811f27de71df41a471e9a863bd451906ae3aa4","head":{"label":"chef:irving/dvm-fixes","ref":"irving/dvm-fixes","sha":"9b811f27de71df41a471e9a863bd451906ae3aa4","user":{"login":"chef","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?v=3","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"repo":{"id":24732433,"name":"chef-server","full_name":"chef/chef-server","owner":{"login":"chef","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?v=3","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chef/chef-server","description":"The Chef Server ","fork":false,"url":"https://api.github.com/repos/chef/chef-server","forks_url":"https://api.github.com/repos/chef/chef-server/forks","keys_url":"https://api.github.com/repos/chef/chef-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chef/chef-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chef/chef-server/teams","hooks_url":"https://api.github.com/repos/chef/chef-server/hooks","issue_events_url":"https://api.github.com/repos/chef/chef-server/issues/events{/number}","events_url":"https://api.github.com/repos/chef/chef-server/events","assignees_url":"https://api.github.com/repos/chef/chef-server/assignees{/user}","branches_url":"https://api.github.com/repos/chef/chef-server/branches{/branch}","tags_url":"https://api.github.com/repos/chef/chef-server/tags","blobs_url":"https://api.github.com/repos/chef/chef-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chef/chef-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chef/chef-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/chef/chef-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chef/chef-server/statuses/{sha}","languages_url":"https://api.github.com/repos/chef/chef-server/languages","stargazers_url":"https://api.github.com/repos/chef/chef-server/stargazers","contributors_url":"https://api.github.com/repos/chef/chef-server/contributors","subscribers_url":"https://api.github.com/repos/chef/chef-server/subscribers","subscription_url":"https://api.github.com/repos/chef/chef-server/subscription","commits_url":"https://api.github.com/repos/chef/chef-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/chef/chef-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/chef/chef-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/chef/chef-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/chef/chef-server/contents/{+path}","compare_url":"https://api.github.com/repos/chef/chef-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chef/chef-server/merges","archive_url":"https://api.github.com/repos/chef/chef-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chef/chef-server/downloads","issues_url":"https://api.github.com/repos/chef/chef-server/issues{/number}","pulls_url":"https://api.github.com/repos/chef/chef-server/pulls{/number}","milestones_url":"https://api.github.com/repos/chef/chef-server/milestones{/number}","notifications_url":"https://api.github.com/repos/chef/chef-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chef/chef-server/labels{/name}","releases_url":"https://api.github.com/repos/chef/chef-server/releases{/id}","created_at":"2014-10-02T19:04:18Z","updated_at":"2015-10-26T23:25:12Z","pushed_at":"2015-10-28T23:21:23Z","git_url":"git://github.com/chef/chef-server.git","ssh_url":"git@github.com:chef/chef-server.git","clone_url":"https://github.com/chef/chef-server.git","svn_url":"https://github.com/chef/chef-server","homepage":"https://www.chef.io/chef/","size":20872,"stargazers_count":54,"watchers_count":54,"language":"Erlang","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":36,"mirror_url":null,"open_issues_count":208,"forks":36,"open_issues":208,"watchers":54,"default_branch":"master"}},"base":{"label":"chef:master","ref":"master","sha":"ee954606293c3cc8c4b27c7617b8fdcfb76aa6d2","user":{"login":"chef","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?v=3","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"repo":{"id":24732433,"name":"chef-server","full_name":"chef/chef-server","owner":{"login":"chef","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?v=3","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chef/chef-server","description":"The Chef Server ","fork":false,"url":"https://api.github.com/repos/chef/chef-server","forks_url":"https://api.github.com/repos/chef/chef-server/forks","keys_url":"https://api.github.com/repos/chef/chef-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chef/chef-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chef/chef-server/teams","hooks_url":"https://api.github.com/repos/chef/chef-server/hooks","issue_events_url":"https://api.github.com/repos/chef/chef-server/issues/events{/number}","events_url":"https://api.github.com/repos/chef/chef-server/events","assignees_url":"https://api.github.com/repos/chef/chef-server/assignees{/user}","branches_url":"https://api.github.com/repos/chef/chef-server/branches{/branch}","tags_url":"https://api.github.com/repos/chef/chef-server/tags","blobs_url":"https://api.github.com/repos/chef/chef-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chef/chef-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chef/chef-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/chef/chef-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chef/chef-server/statuses/{sha}","languages_url":"https://api.github.com/repos/chef/chef-server/languages","stargazers_url":"https://api.github.com/repos/chef/chef-server/stargazers","contributors_url":"https://api.github.com/repos/chef/chef-server/contributors","subscribers_url":"https://api.github.com/repos/chef/chef-server/subscribers","subscription_url":"https://api.github.com/repos/chef/chef-server/subscription","commits_url":"https://api.github.com/repos/chef/chef-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/chef/chef-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/chef/chef-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/chef/chef-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/chef/chef-server/contents/{+path}","compare_url":"https://api.github.com/repos/chef/chef-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chef/chef-server/merges","archive_url":"https://api.github.com/repos/chef/chef-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chef/chef-server/downloads","issues_url":"https://api.github.com/repos/chef/chef-server/issues{/number}","pulls_url":"https://api.github.com/repos/chef/chef-server/pulls{/number}","milestones_url":"https://api.github.com/repos/chef/chef-server/milestones{/number}","notifications_url":"https://api.github.com/repos/chef/chef-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chef/chef-server/labels{/name}","releases_url":"https://api.github.com/repos/chef/chef-server/releases{/id}","created_at":"2014-10-02T19:04:18Z","updated_at":"2015-10-26T23:25:12Z","pushed_at":"2015-10-28T23:21:23Z","git_url":"git://github.com/chef/chef-server.git","ssh_url":"git@github.com:chef/chef-server.git","clone_url":"https://github.com/chef/chef-server.git","svn_url":"https://github.com/chef/chef-server","homepage":"https://www.chef.io/chef/","size":20872,"stargazers_count":54,"watchers_count":54,"language":"Erlang","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":36,"mirror_url":null,"open_issues_count":208,"forks":36,"open_issues":208,"watchers":54,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chef/chef-server/pulls/588"},"html":{"href":"https://github.com/chef/chef-server/pull/588"},"issue":{"href":"https://api.github.com/repos/chef/chef-server/issues/588"},"comments":{"href":"https://api.github.com/repos/chef/chef-server/issues/588/comments"},"review_comments":{"href":"https://api.github.com/repos/chef/chef-server/pulls/588/comments"},"review_comment":{"href":"https://api.github.com/repos/chef/chef-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chef/chef-server/pulls/588/commits"},"statuses":{"href":"https://api.github.com/repos/chef/chef-server/statuses/9b811f27de71df41a471e9a863bd451906ae3aa4"}}}}