{"action":"created","issue":{"url":"https://api.github.com/repos/jupyter/jupyter-js-output-area/issues/16","labels_url":"https://api.github.com/repos/jupyter/jupyter-js-output-area/issues/16/labels{/name}","comments_url":"https://api.github.com/repos/jupyter/jupyter-js-output-area/issues/16/comments","events_url":"https://api.github.com/repos/jupyter/jupyter-js-output-area/issues/16/events","html_url":"https://github.com/jupyter/jupyter-js-output-area/pull/16","id":107282111,"number":16,"title":"[WIP] Added tests for jupyter-js-output-area","user":{"login":"captainsafia","id":1857993,"avatar_url":"https://avatars.githubusercontent.com/u/1857993?v=3","gravatar_id":"","url":"https://api.github.com/users/captainsafia","html_url":"https://github.com/captainsafia","followers_url":"https://api.github.com/users/captainsafia/followers","following_url":"https://api.github.com/users/captainsafia/following{/other_user}","gists_url":"https://api.github.com/users/captainsafia/gists{/gist_id}","starred_url":"https://api.github.com/users/captainsafia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/captainsafia/subscriptions","organizations_url":"https://api.github.com/users/captainsafia/orgs","repos_url":"https://api.github.com/users/captainsafia/repos","events_url":"https://api.github.com/users/captainsafia/events{/privacy}","received_events_url":"https://api.github.com/users/captainsafia/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-09-18T21:31:33Z","updated_at":"2015-09-20T21:45:18Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jupyter/jupyter-js-output-area/pulls/16","html_url":"https://github.com/jupyter/jupyter-js-output-area/pull/16","diff_url":"https://github.com/jupyter/jupyter-js-output-area/pull/16.diff","patch_url":"https://github.com/jupyter/jupyter-js-output-area/pull/16.patch"},"body":"Closes #5.\r\n\r\nOpening up a WIP PR for this.\r\n\r\nLet me know what things you want covered with tests.\r\n\r\ncc/ @rgbkrk @jdfreder "},"comment":{"url":"https://api.github.com/repos/jupyter/jupyter-js-output-area/issues/comments/141837760","html_url":"https://github.com/jupyter/jupyter-js-output-area/pull/16#issuecomment-141837760","issue_url":"https://api.github.com/repos/jupyter/jupyter-js-output-area/issues/16","id":141837760,"user":{"login":"captainsafia","id":1857993,"avatar_url":"https://avatars.githubusercontent.com/u/1857993?v=3","gravatar_id":"","url":"https://api.github.com/users/captainsafia","html_url":"https://github.com/captainsafia","followers_url":"https://api.github.com/users/captainsafia/followers","following_url":"https://api.github.com/users/captainsafia/following{/other_user}","gists_url":"https://api.github.com/users/captainsafia/gists{/gist_id}","starred_url":"https://api.github.com/users/captainsafia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/captainsafia/subscriptions","organizations_url":"https://api.github.com/users/captainsafia/orgs","repos_url":"https://api.github.com/users/captainsafia/repos","events_url":"https://api.github.com/users/captainsafia/events{/privacy}","received_events_url":"https://api.github.com/users/captainsafia/received_events","type":"User","site_admin":false},"created_at":"2015-09-20T21:45:18Z","updated_at":"2015-09-20T21:45:18Z","body":"Ah. OK. Thanks for the clarification that makes a lot of sense.\n\nI'll replace the current test with one that tests getter/setter and commit\nthe other tests I made as soon as I'm on solid ground for more than 16\nhours!\n\n*insert picture of jet lagged kitten here because I ran out of free\nInternet minutes* :'(\nOn Sep 20, 2015 2:22 PM, \"Kyle Kelley\" <notifications@github.com> wrote:\n\n> That cat picture is very apropos.\n>\n> What I'm saying is that the unit tests should go after functions. The test\n> on _state tests that the internal structure is an array with array\n> properties. It's basically testing (correctly) that we're consistently\n> using an array for _state and that JavaScript's Array behaves like an\n> Array (effectively testing that JS works). A simplified version of that\n> test would be Array.isArray(this._state). Which, at that point you'd want\n> to tear that test out.\n>\n> Instead test model.state which does operations on top of that internal\n> data structure.\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/jupyter/jupyter-js-output-area/pull/16#issuecomment-141822830>\n> .\n>\n"}}