{"action":"created","issue":{"url":"https://api.github.com/repos/assemble/assemble/issues/612","labels_url":"https://api.github.com/repos/assemble/assemble/issues/612/labels{/name}","comments_url":"https://api.github.com/repos/assemble/assemble/issues/612/comments","events_url":"https://api.github.com/repos/assemble/assemble/issues/612/events","html_url":"https://github.com/assemble/assemble/pull/612","id":52737846,"number":612,"title":"Add check into the assemble.options.pages build step to ensure pages only get built once","user":{"login":"andymantell","id":134642,"avatar_url":"https://avatars.githubusercontent.com/u/134642?v=3","gravatar_id":"","url":"https://api.github.com/users/andymantell","html_url":"https://github.com/andymantell","followers_url":"https://api.github.com/users/andymantell/followers","following_url":"https://api.github.com/users/andymantell/following{/other_user}","gists_url":"https://api.github.com/users/andymantell/gists{/gist_id}","starred_url":"https://api.github.com/users/andymantell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andymantell/subscriptions","organizations_url":"https://api.github.com/users/andymantell/orgs","repos_url":"https://api.github.com/users/andymantell/repos","events_url":"https://api.github.com/users/andymantell/events{/privacy}","received_events_url":"https://api.github.com/users/andymantell/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2014-12-23T12:46:24Z","updated_at":"2015-01-13T09:14:12Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/assemble/assemble/pulls/612","html_url":"https://github.com/assemble/assemble/pull/612","diff_url":"https://github.com/assemble/assemble/pull/612.diff","patch_url":"https://github.com/assemble/assemble/pull/612.patch"},"body":"Add check into the assemble.options.pages build step to ensure pages only get built once, instead of once for each item in assemble.task.files. Fixes assemble/assemble#611"},"comment":{"url":"https://api.github.com/repos/assemble/assemble/issues/comments/69715455","html_url":"https://github.com/assemble/assemble/pull/612#issuecomment-69715455","issue_url":"https://api.github.com/repos/assemble/assemble/issues/612","id":69715455,"user":{"login":"andymantell","id":134642,"avatar_url":"https://avatars.githubusercontent.com/u/134642?v=3","gravatar_id":"","url":"https://api.github.com/users/andymantell","html_url":"https://github.com/andymantell","followers_url":"https://api.github.com/users/andymantell/followers","following_url":"https://api.github.com/users/andymantell/following{/other_user}","gists_url":"https://api.github.com/users/andymantell/gists{/gist_id}","starred_url":"https://api.github.com/users/andymantell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andymantell/subscriptions","organizations_url":"https://api.github.com/users/andymantell/orgs","repos_url":"https://api.github.com/users/andymantell/repos","events_url":"https://api.github.com/users/andymantell/events{/privacy}","received_events_url":"https://api.github.com/users/andymantell/received_events","type":"User","site_admin":false},"created_at":"2015-01-13T09:14:12Z","updated_at":"2015-01-13T09:14:12Z","body":"@jonschlinkert @doowb  No worries. I completely understand your concern and agree there's a need to be cautious here - my knowledge of assemble's internals is obviously extremely limited so my fix should certainly be scrutinized. It essentially amounts to a \"hack\" as un-nesting this code would have been a much larger refactor.\r\n\r\nTo what extent does the TravisCI green light constitute an assurance that the core features of assemble remain working after my change? Is assemble's test coverage sufficiently broad?\r\n\r\nMy argument for merging it would be that this is a mechanic that is slightly broken at this point, and due to the multiplicative nature of the bug it cripples my work, leaving me with a build step that runs for an inordinate amount of time. My options for delivering this site to my client are therefore to:\r\n\r\n* Ship it with a permanent fork of Assemble 0.4.x _(not ideal)_\r\n* Get this commit into Assemble 0.4.x and get back onto the mainline. _(Easiest for me)_\r\n* Upgrade my site to Assemble 0.6.x _(More work for me, but if this is the \"right\" thing to do and upgrading is \"possible\", then I am ok with that)_\r\n\r\nWhat is your gut feeling about the nature of the upgrade process from 0.4 to 0.6? Are there sweeping API changes? Or, despite the large scale refactor internally, is it largely the same as 0.4 from the outside? If 0.6 is \"ready enough\" I could consider an upgrade to it at this point provided I don't need to re-do huge amounts of my work. Essentially my site comprises:\r\n\r\n* Two grunt targets (i.e. two \"sites\")\r\n* .hbs partials and layouts\r\n* Various custom handlebars helpers\r\n* Pages on disk in .hbs files with some YAML frontmatter\r\n* Pages injected into the `assemble.pages` option, fed from a REST api.\r\n\r\nThanks!"}}