{"action":"created","issue":{"url":"https://api.github.com/repos/bordaigorl/sublime-evernote/issues/42","labels_url":"https://api.github.com/repos/bordaigorl/sublime-evernote/issues/42/labels{/name}","comments_url":"https://api.github.com/repos/bordaigorl/sublime-evernote/issues/42/comments","events_url":"https://api.github.com/repos/bordaigorl/sublime-evernote/issues/42/events","html_url":"https://github.com/bordaigorl/sublime-evernote/issues/42","id":42395435,"number":42,"title":"Plugin isn't working behind proxy","user":{"login":"stese","id":423150,"avatar_url":"https://avatars.githubusercontent.com/u/423150?v=3","gravatar_id":"","url":"https://api.github.com/users/stese","html_url":"https://github.com/stese","followers_url":"https://api.github.com/users/stese/followers","following_url":"https://api.github.com/users/stese/following{/other_user}","gists_url":"https://api.github.com/users/stese/gists{/gist_id}","starred_url":"https://api.github.com/users/stese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stese/subscriptions","organizations_url":"https://api.github.com/users/stese/orgs","repos_url":"https://api.github.com/users/stese/repos","events_url":"https://api.github.com/users/stese/events{/privacy}","received_events_url":"https://api.github.com/users/stese/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/bordaigorl/sublime-evernote/labels/bug","name":"bug","color":"fc2929"},{"url":"https://api.github.com/repos/bordaigorl/sublime-evernote/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/bordaigorl/sublime-evernote/milestones/2","labels_url":"https://api.github.com/repos/bordaigorl/sublime-evernote/milestones/2/labels","id":587145,"number":2,"title":"Version 3","description":"New improved version with advanced features","creator":{"login":"bordaigorl","id":2098241,"avatar_url":"https://avatars.githubusercontent.com/u/2098241?v=3","gravatar_id":"","url":"https://api.github.com/users/bordaigorl","html_url":"https://github.com/bordaigorl","followers_url":"https://api.github.com/users/bordaigorl/followers","following_url":"https://api.github.com/users/bordaigorl/following{/other_user}","gists_url":"https://api.github.com/users/bordaigorl/gists{/gist_id}","starred_url":"https://api.github.com/users/bordaigorl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bordaigorl/subscriptions","organizations_url":"https://api.github.com/users/bordaigorl/orgs","repos_url":"https://api.github.com/users/bordaigorl/repos","events_url":"https://api.github.com/users/bordaigorl/events{/privacy}","received_events_url":"https://api.github.com/users/bordaigorl/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":0,"state":"open","created_at":"2014-03-04T16:37:21Z","updated_at":"2014-11-19T11:48:17Z","due_on":null,"closed_at":null},"comments":18,"created_at":"2014-09-10T09:48:34Z","updated_at":"2015-01-13T14:14:28Z","closed_at":null,"body":"If you are using sublime text behind a company proxy, you basically have to set the proxy settings per module right to get this module working right now.\r\n\r\nI had to set the company proxy for example for the plugin package control in the settings of the package control, because the sublime own proxy settings were ignored (see https://sublime.wbond.net/docs/settings#setting-http_proxy).\r\n\r\nThe possibility to set custom proxy settings for this module would be nice. For now, the plugin isn't working behind a proxy, even if the .bash_profile of the user or something similar is set up correctly."},"comment":{"url":"https://api.github.com/repos/bordaigorl/sublime-evernote/issues/comments/69749309","html_url":"https://github.com/bordaigorl/sublime-evernote/issues/42#issuecomment-69749309","issue_url":"https://api.github.com/repos/bordaigorl/sublime-evernote/issues/42","id":69749309,"user":{"login":"BattoorCjorn","id":1516035,"avatar_url":"https://avatars.githubusercontent.com/u/1516035?v=3","gravatar_id":"","url":"https://api.github.com/users/BattoorCjorn","html_url":"https://github.com/BattoorCjorn","followers_url":"https://api.github.com/users/BattoorCjorn/followers","following_url":"https://api.github.com/users/BattoorCjorn/following{/other_user}","gists_url":"https://api.github.com/users/BattoorCjorn/gists{/gist_id}","starred_url":"https://api.github.com/users/BattoorCjorn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BattoorCjorn/subscriptions","organizations_url":"https://api.github.com/users/BattoorCjorn/orgs","repos_url":"https://api.github.com/users/BattoorCjorn/repos","events_url":"https://api.github.com/users/BattoorCjorn/events{/privacy}","received_events_url":"https://api.github.com/users/BattoorCjorn/received_events","type":"User","site_admin":false},"created_at":"2015-01-13T14:14:28Z","updated_at":"2015-01-13T14:14:28Z","body":"No, it won't help becouse the thrift (Phyton 3.x) library used in the evernote [API](https://github.com/evernote/evernote-sdk-python3), does not use these settings. \r\n\r\nThe problem is that when they Ported thrift to 3.x, they left proxy support out of it. \r\n\r\n\r\n### Constructors THttpClient\r\nLets look at the [old 2.x implementation of the Thttpclient](https://github.com/evernote/evernote-sdk-python/blob/master/lib/thrift/transport/THttpClient.py):\r\n\r\n```python\r\nclass THttpClient(TTransportBase):\r\n\r\n    \"\"\"Http implementation of TTransport base.\"\"\"\r\n\r\n    def __init__(\r\n        self,\r\n        uri_or_host,\r\n        port=None,\r\n        path=None,\r\n        proxy_host=None,\r\n        proxy_port=None\r\n    ):\r\n        \"\"\"THttpClient supports two different types constructor parameters.\r\n        THttpClient(host, port, path) - deprecated\r\n        THttpClient(uri)\r\n        Only the second supports https.\"\"\"\r\n\r\n        \"\"\"THttpClient supports proxy\r\n        THttpClient(host, port, path, proxy_host, proxy_port) - deprecated\r\n        ThttpClient(uri, None, None, proxy_host, proxy_port)\"\"\"\r\n```\r\n\r\nSo if we look at the constructor u can clearly see that in Python 2 support for proxy's was added, and used.\r\n\r\nNow if u look at [the 3.x constructor](https://github.com/evernote/evernote-sdk-python3/blob/master/lib/thrift/transport/THttpClient.py) u notice that support has been teared down:\r\n\r\n```python\r\nclass THttpClient(TTransportBase):\r\n  \"\"\"Http implementation of TTransport base.\"\"\"\r\n\r\n  def __init__(self, uri_or_host, port=None, path=None):\r\n    \"\"\"THttpClient supports two different types constructor parameters.\r\n    THttpClient(host, port, path) - deprecated\r\n    THttpClient(uri)\r\n    Only the second supports https.\r\n    \"\"\"\r\n```\r\n\r\nSo that means even if u would be able to set the environment `HTTP_PROXY` variable, you would __not be able to pass it to the constructor__ of the ThttpClient.\r\n\r\n### Where is Thrift Python?\r\nSo now that we know what needs to be changed, __where do we change it__?\r\n\r\nI notice [Thrift is compiled from this website](https://www.apache.org/dyn/closer.cgi?path=/thrift/0.9.2/thrift-0.9.2.exe), maybe just updating to the latest may already contain a fix?"}}