{"action":"created","issue":{"url":"https://api.github.com/repos/scala-js/scala-js/issues/1460","labels_url":"https://api.github.com/repos/scala-js/scala-js/issues/1460/labels{/name}","comments_url":"https://api.github.com/repos/scala-js/scala-js/issues/1460/comments","events_url":"https://api.github.com/repos/scala-js/scala-js/issues/1460/events","html_url":"https://github.com/scala-js/scala-js/pull/1460","id":54451596,"number":1460,"title":"Fix #1452: PhantomJS sometimes doesn't shut down properly.","user":{"login":"sjrd","id":535934,"avatar_url":"https://avatars.githubusercontent.com/u/535934?v=3","gravatar_id":"","url":"https://api.github.com/users/sjrd","html_url":"https://github.com/sjrd","followers_url":"https://api.github.com/users/sjrd/followers","following_url":"https://api.github.com/users/sjrd/following{/other_user}","gists_url":"https://api.github.com/users/sjrd/gists{/gist_id}","starred_url":"https://api.github.com/users/sjrd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjrd/subscriptions","organizations_url":"https://api.github.com/users/sjrd/orgs","repos_url":"https://api.github.com/users/sjrd/repos","events_url":"https://api.github.com/users/sjrd/events{/privacy}","received_events_url":"https://api.github.com/users/sjrd/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":37,"created_at":"2015-01-15T13:57:15Z","updated_at":"2015-01-18T02:35:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/scala-js/scala-js/pulls/1460","html_url":"https://github.com/scala-js/scala-js/pull/1460","diff_url":"https://github.com/scala-js/scala-js/pull/1460.diff","patch_url":"https://github.com/scala-js/scala-js/pull/1460.patch"},"body":"In fact, I believe this could have applied as well to other environments. Anyway, now the whole shutdown process protects against any exception that is being thrown, and still proceeds with terminating all the VMs. Any thrown exception is recorded and rethrown at the end."},"comment":{"url":"https://api.github.com/repos/scala-js/scala-js/issues/comments/70394081","html_url":"https://github.com/scala-js/scala-js/pull/1460#issuecomment-70394081","issue_url":"https://api.github.com/repos/scala-js/scala-js/issues/1460","id":70394081,"user":{"login":"gzm0","id":1140323,"avatar_url":"https://avatars.githubusercontent.com/u/1140323?v=3","gravatar_id":"","url":"https://api.github.com/users/gzm0","html_url":"https://github.com/gzm0","followers_url":"https://api.github.com/users/gzm0/followers","following_url":"https://api.github.com/users/gzm0/following{/other_user}","gists_url":"https://api.github.com/users/gzm0/gists{/gist_id}","starred_url":"https://api.github.com/users/gzm0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gzm0/subscriptions","organizations_url":"https://api.github.com/users/gzm0/orgs","repos_url":"https://api.github.com/users/gzm0/repos","events_url":"https://api.github.com/users/gzm0/events{/privacy}","received_events_url":"https://api.github.com/users/gzm0/received_events","type":"User","site_admin":false},"created_at":"2015-01-18T02:35:54Z","updated_at":"2015-01-18T02:35:54Z","body":"I think squashing is fine. But I'd like to review this one if you don't mind. "}}