{"comment":{"url":"https://api.github.com/repos/seanf/maven-surefire/comments/14736271","html_url":"https://github.com/seanf/maven-surefire/commit/f1518a1b4f8ce87cc6f3884550af24594cd98c59#commitcomment-14736271","id":14736271,"user":{"login":"Tibor17","id":1045063,"avatar_url":"https://avatars.githubusercontent.com/u/1045063?v=3","gravatar_id":"","url":"https://api.github.com/users/Tibor17","html_url":"https://github.com/Tibor17","followers_url":"https://api.github.com/users/Tibor17/followers","following_url":"https://api.github.com/users/Tibor17/following{/other_user}","gists_url":"https://api.github.com/users/Tibor17/gists{/gist_id}","starred_url":"https://api.github.com/users/Tibor17/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tibor17/subscriptions","organizations_url":"https://api.github.com/users/Tibor17/orgs","repos_url":"https://api.github.com/users/Tibor17/repos","events_url":"https://api.github.com/users/Tibor17/events{/privacy}","received_events_url":"https://api.github.com/users/Tibor17/received_events","type":"User","site_admin":false},"position":22,"line":2377,"path":"maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java","commit_id":"f1518a1b4f8ce87cc6f3884550af24594cd98c59","created_at":"2015-12-02T14:07:03Z","updated_at":"2015-12-02T14:07:03Z","body":"Try to build IT with your code with more realistic counts, but the\nfail-fast feature would not be coherent due to concurrency problem across\nforks.\n\nOn Wed, Dec 2, 2015 at 3:03 PM, Tibor Digana <tibor.digana@googlemail.com>\nwrote:\n\n> I don't thing so these two features may work together.\n> It was safe enough to disallow both a time.\n>\n> On Wed, Dec 2, 2015 at 2:19 PM, Sean Flanigan <notifications@github.com>\n> wrote:\n>\n>> Hi Tibor,\n>>\n>> Sorry, but I don't understand exactly what you're asking for here. But\n>> regardless, isn't rerunCount counting *runs* (eg run each test an extra 3\n>> times if it is failing), whereas failureCount is counting *tests* (eg if\n>> 10\n>> tests have failed all their runs - however many reruns that is - then skip\n>> the rest of the tests)? Unless I've misunderstood failureCount? Is\n>> failureCount counting runs or tests?\n>>\n>> I don't think it even makes sense to compare rerunCount with failureCount,\n>> because the units are not the same. Are they?\n>>\n>> On 2 December 2015 at 23:03, Tibor Digana <notifications@github.com>\n>> wrote:\n>>\n>> > Pls take this back and add additional check when this condition makes\n>> > sense && rerunCount >= failureCount.\n>> >\n>> > —\n>> > Reply to this email directly or view it on GitHub\n>> > <\n>> https://github.com/seanf/maven-surefire/commit/f1518a1b4f8ce87cc6f3884550af24594cd98c59#commitcomment-14734966\n>> >\n>> > .\n>> >\n>>\n>> —\n>> Reply to this email directly or view it on GitHub\n>> <https://github.com/seanf/maven-surefire/commit/f1518a1b4f8ce87cc6f3884550af24594cd98c59#commitcomment-14735243>\n>> .\n>>\n>\n>\n>\n> --\n> Cheers\n> Tibor\n>\n\n\n\n-- \nCheers\nTibor\n"}}