{"action":"created","comment":{"url":"https://api.github.com/repos/atom/text-buffer/pulls/comments/24688052","id":24688052,"diff_hunk":"@@ -1011,6 +1011,7 @@ describe \"TextBuffer\", ->\n       filePath = join(temp.dir, 'atom-file-to-delete.txt')\n       writeFileSync(filePath, 'delete me')\n       bufferToDelete = new TextBuffer({filePath, load: true})\n+      bufferToDelete.onDidDelete -> didDelete = true","path":"spec/text-buffer-spec.coffee","position":4,"original_position":4,"commit_id":"a3a278ae41e6c90b9f1fa056266dae0c153b0500","original_commit_id":"a3a278ae41e6c90b9f1fa056266dae0c153b0500","user":{"login":"kevinsawicki","id":671378,"avatar_url":"https://avatars.githubusercontent.com/u/671378?v=3","gravatar_id":"","url":"https://api.github.com/users/kevinsawicki","html_url":"https://github.com/kevinsawicki","followers_url":"https://api.github.com/users/kevinsawicki/followers","following_url":"https://api.github.com/users/kevinsawicki/following{/other_user}","gists_url":"https://api.github.com/users/kevinsawicki/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinsawicki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinsawicki/subscriptions","organizations_url":"https://api.github.com/users/kevinsawicki/orgs","repos_url":"https://api.github.com/users/kevinsawicki/repos","events_url":"https://api.github.com/users/kevinsawicki/events{/privacy}","received_events_url":"https://api.github.com/users/kevinsawicki/received_events","type":"User","site_admin":true},"body":"Is this `didDelete` variable use anywhere?","created_at":"2015-02-13T19:10:12Z","updated_at":"2015-02-13T19:10:12Z","html_url":"https://github.com/atom/text-buffer/pull/46#discussion_r24688052","pull_request_url":"https://api.github.com/repos/atom/text-buffer/pulls/46","_links":{"self":{"href":"https://api.github.com/repos/atom/text-buffer/pulls/comments/24688052"},"html":{"href":"https://github.com/atom/text-buffer/pull/46#discussion_r24688052"},"pull_request":{"href":"https://api.github.com/repos/atom/text-buffer/pulls/46"}}},"pull_request":{"url":"https://api.github.com/repos/atom/text-buffer/pulls/46","id":29220935,"html_url":"https://github.com/atom/text-buffer/pull/46","diff_url":"https://github.com/atom/text-buffer/pull/46.diff","patch_url":"https://github.com/atom/text-buffer/pull/46.patch","issue_url":"https://api.github.com/repos/atom/text-buffer/issues/46","number":46,"state":"open","locked":false,"title":"add did-delete event:","user":{"login":"kans","id":986627,"avatar_url":"https://avatars.githubusercontent.com/u/986627?v=3","gravatar_id":"","url":"https://api.github.com/users/kans","html_url":"https://github.com/kans","followers_url":"https://api.github.com/users/kans/followers","following_url":"https://api.github.com/users/kans/following{/other_user}","gists_url":"https://api.github.com/users/kans/gists{/gist_id}","starred_url":"https://api.github.com/users/kans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kans/subscriptions","organizations_url":"https://api.github.com/users/kans/orgs","repos_url":"https://api.github.com/users/kans/repos","events_url":"https://api.github.com/users/kans/events{/privacy}","received_events_url":"https://api.github.com/users/kans/received_events","type":"User","site_admin":false},"body":"Adds did-delete event and dispatcher as well as a simple unit test.\r\n\r\nCurrently, plugins must rely on the file's did-delete event, but the underlying file can change or itself be deleted which makes the existing implementation cumbersome.","created_at":"2015-02-12T22:05:41Z","updated_at":"2015-02-13T19:10:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e55a0f7ca48aa3605065f507f83fa777b0f92ff9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/atom/text-buffer/pulls/46/commits","review_comments_url":"https://api.github.com/repos/atom/text-buffer/pulls/46/comments","review_comment_url":"https://api.github.com/repos/atom/text-buffer/pulls/comments/{number}","comments_url":"https://api.github.com/repos/atom/text-buffer/issues/46/comments","statuses_url":"https://api.github.com/repos/atom/text-buffer/statuses/a3a278ae41e6c90b9f1fa056266dae0c153b0500","head":{"label":"kans:add-did-delete","ref":"add-did-delete","sha":"a3a278ae41e6c90b9f1fa056266dae0c153b0500","user":{"login":"kans","id":986627,"avatar_url":"https://avatars.githubusercontent.com/u/986627?v=3","gravatar_id":"","url":"https://api.github.com/users/kans","html_url":"https://github.com/kans","followers_url":"https://api.github.com/users/kans/followers","following_url":"https://api.github.com/users/kans/following{/other_user}","gists_url":"https://api.github.com/users/kans/gists{/gist_id}","starred_url":"https://api.github.com/users/kans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kans/subscriptions","organizations_url":"https://api.github.com/users/kans/orgs","repos_url":"https://api.github.com/users/kans/repos","events_url":"https://api.github.com/users/kans/events{/privacy}","received_events_url":"https://api.github.com/users/kans/received_events","type":"User","site_admin":false},"repo":{"id":30724684,"name":"text-buffer","full_name":"kans/text-buffer","owner":{"login":"kans","id":986627,"avatar_url":"https://avatars.githubusercontent.com/u/986627?v=3","gravatar_id":"","url":"https://api.github.com/users/kans","html_url":"https://github.com/kans","followers_url":"https://api.github.com/users/kans/followers","following_url":"https://api.github.com/users/kans/following{/other_user}","gists_url":"https://api.github.com/users/kans/gists{/gist_id}","starred_url":"https://api.github.com/users/kans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kans/subscriptions","organizations_url":"https://api.github.com/users/kans/orgs","repos_url":"https://api.github.com/users/kans/repos","events_url":"https://api.github.com/users/kans/events{/privacy}","received_events_url":"https://api.github.com/users/kans/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kans/text-buffer","description":"Atom's underlying text buffer","fork":true,"url":"https://api.github.com/repos/kans/text-buffer","forks_url":"https://api.github.com/repos/kans/text-buffer/forks","keys_url":"https://api.github.com/repos/kans/text-buffer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kans/text-buffer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kans/text-buffer/teams","hooks_url":"https://api.github.com/repos/kans/text-buffer/hooks","issue_events_url":"https://api.github.com/repos/kans/text-buffer/issues/events{/number}","events_url":"https://api.github.com/repos/kans/text-buffer/events","assignees_url":"https://api.github.com/repos/kans/text-buffer/assignees{/user}","branches_url":"https://api.github.com/repos/kans/text-buffer/branches{/branch}","tags_url":"https://api.github.com/repos/kans/text-buffer/tags","blobs_url":"https://api.github.com/repos/kans/text-buffer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kans/text-buffer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kans/text-buffer/git/refs{/sha}","trees_url":"https://api.github.com/repos/kans/text-buffer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kans/text-buffer/statuses/{sha}","languages_url":"https://api.github.com/repos/kans/text-buffer/languages","stargazers_url":"https://api.github.com/repos/kans/text-buffer/stargazers","contributors_url":"https://api.github.com/repos/kans/text-buffer/contributors","subscribers_url":"https://api.github.com/repos/kans/text-buffer/subscribers","subscription_url":"https://api.github.com/repos/kans/text-buffer/subscription","commits_url":"https://api.github.com/repos/kans/text-buffer/commits{/sha}","git_commits_url":"https://api.github.com/repos/kans/text-buffer/git/commits{/sha}","comments_url":"https://api.github.com/repos/kans/text-buffer/comments{/number}","issue_comment_url":"https://api.github.com/repos/kans/text-buffer/issues/comments/{number}","contents_url":"https://api.github.com/repos/kans/text-buffer/contents/{+path}","compare_url":"https://api.github.com/repos/kans/text-buffer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kans/text-buffer/merges","archive_url":"https://api.github.com/repos/kans/text-buffer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kans/text-buffer/downloads","issues_url":"https://api.github.com/repos/kans/text-buffer/issues{/number}","pulls_url":"https://api.github.com/repos/kans/text-buffer/pulls{/number}","milestones_url":"https://api.github.com/repos/kans/text-buffer/milestones{/number}","notifications_url":"https://api.github.com/repos/kans/text-buffer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kans/text-buffer/labels{/name}","releases_url":"https://api.github.com/repos/kans/text-buffer/releases{/id}","created_at":"2015-02-12T21:26:09Z","updated_at":"2015-02-12T21:26:10Z","pushed_at":"2015-02-12T22:05:07Z","git_url":"git://github.com/kans/text-buffer.git","ssh_url":"git@github.com:kans/text-buffer.git","clone_url":"https://github.com/kans/text-buffer.git","svn_url":"https://github.com/kans/text-buffer","homepage":"","size":1764,"stargazers_count":0,"watchers_count":0,"language":"CoffeeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"atom:master","ref":"master","sha":"6634993499da7c7b3e5819d3bff0fbc8a7440e0f","user":{"login":"atom","id":1089146,"avatar_url":"https://avatars.githubusercontent.com/u/1089146?v=3","gravatar_id":"","url":"https://api.github.com/users/atom","html_url":"https://github.com/atom","followers_url":"https://api.github.com/users/atom/followers","following_url":"https://api.github.com/users/atom/following{/other_user}","gists_url":"https://api.github.com/users/atom/gists{/gist_id}","starred_url":"https://api.github.com/users/atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atom/subscriptions","organizations_url":"https://api.github.com/users/atom/orgs","repos_url":"https://api.github.com/users/atom/repos","events_url":"https://api.github.com/users/atom/events{/privacy}","received_events_url":"https://api.github.com/users/atom/received_events","type":"Organization","site_admin":false},"repo":{"id":15379098,"name":"text-buffer","full_name":"atom/text-buffer","owner":{"login":"atom","id":1089146,"avatar_url":"https://avatars.githubusercontent.com/u/1089146?v=3","gravatar_id":"","url":"https://api.github.com/users/atom","html_url":"https://github.com/atom","followers_url":"https://api.github.com/users/atom/followers","following_url":"https://api.github.com/users/atom/following{/other_user}","gists_url":"https://api.github.com/users/atom/gists{/gist_id}","starred_url":"https://api.github.com/users/atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atom/subscriptions","organizations_url":"https://api.github.com/users/atom/orgs","repos_url":"https://api.github.com/users/atom/repos","events_url":"https://api.github.com/users/atom/events{/privacy}","received_events_url":"https://api.github.com/users/atom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/atom/text-buffer","description":"Atom's underlying text buffer","fork":false,"url":"https://api.github.com/repos/atom/text-buffer","forks_url":"https://api.github.com/repos/atom/text-buffer/forks","keys_url":"https://api.github.com/repos/atom/text-buffer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/atom/text-buffer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/atom/text-buffer/teams","hooks_url":"https://api.github.com/repos/atom/text-buffer/hooks","issue_events_url":"https://api.github.com/repos/atom/text-buffer/issues/events{/number}","events_url":"https://api.github.com/repos/atom/text-buffer/events","assignees_url":"https://api.github.com/repos/atom/text-buffer/assignees{/user}","branches_url":"https://api.github.com/repos/atom/text-buffer/branches{/branch}","tags_url":"https://api.github.com/repos/atom/text-buffer/tags","blobs_url":"https://api.github.com/repos/atom/text-buffer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/atom/text-buffer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/atom/text-buffer/git/refs{/sha}","trees_url":"https://api.github.com/repos/atom/text-buffer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/atom/text-buffer/statuses/{sha}","languages_url":"https://api.github.com/repos/atom/text-buffer/languages","stargazers_url":"https://api.github.com/repos/atom/text-buffer/stargazers","contributors_url":"https://api.github.com/repos/atom/text-buffer/contributors","subscribers_url":"https://api.github.com/repos/atom/text-buffer/subscribers","subscription_url":"https://api.github.com/repos/atom/text-buffer/subscription","commits_url":"https://api.github.com/repos/atom/text-buffer/commits{/sha}","git_commits_url":"https://api.github.com/repos/atom/text-buffer/git/commits{/sha}","comments_url":"https://api.github.com/repos/atom/text-buffer/comments{/number}","issue_comment_url":"https://api.github.com/repos/atom/text-buffer/issues/comments/{number}","contents_url":"https://api.github.com/repos/atom/text-buffer/contents/{+path}","compare_url":"https://api.github.com/repos/atom/text-buffer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/atom/text-buffer/merges","archive_url":"https://api.github.com/repos/atom/text-buffer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/atom/text-buffer/downloads","issues_url":"https://api.github.com/repos/atom/text-buffer/issues{/number}","pulls_url":"https://api.github.com/repos/atom/text-buffer/pulls{/number}","milestones_url":"https://api.github.com/repos/atom/text-buffer/milestones{/number}","notifications_url":"https://api.github.com/repos/atom/text-buffer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/atom/text-buffer/labels{/name}","releases_url":"https://api.github.com/repos/atom/text-buffer/releases{/id}","created_at":"2013-12-22T17:20:21Z","updated_at":"2015-02-13T01:38:55Z","pushed_at":"2015-02-13T01:38:55Z","git_url":"git://github.com/atom/text-buffer.git","ssh_url":"git@github.com:atom/text-buffer.git","clone_url":"https://github.com/atom/text-buffer.git","svn_url":"https://github.com/atom/text-buffer","homepage":"","size":1764,"stargazers_count":31,"watchers_count":31,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":9,"forks":13,"open_issues":9,"watchers":31,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/atom/text-buffer/pulls/46"},"html":{"href":"https://github.com/atom/text-buffer/pull/46"},"issue":{"href":"https://api.github.com/repos/atom/text-buffer/issues/46"},"comments":{"href":"https://api.github.com/repos/atom/text-buffer/issues/46/comments"},"review_comments":{"href":"https://api.github.com/repos/atom/text-buffer/pulls/46/comments"},"review_comment":{"href":"https://api.github.com/repos/atom/text-buffer/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/atom/text-buffer/pulls/46/commits"},"statuses":{"href":"https://api.github.com/repos/atom/text-buffer/statuses/a3a278ae41e6c90b9f1fa056266dae0c153b0500"}}}}