{"action":"closed","number":219,"pull_request":{"url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/pulls/219","id":33323400,"html_url":"https://github.com/appcelerator/titanium_mobile_windows/pull/219","diff_url":"https://github.com/appcelerator/titanium_mobile_windows/pull/219.diff","patch_url":"https://github.com/appcelerator/titanium_mobile_windows/pull/219.patch","issue_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/issues/219","number":219,"state":"closed","locked":false,"title":"Fix: Remove \"virtual\" from Database modules","user":{"login":"infosia","id":1661068,"avatar_url":"https://avatars.githubusercontent.com/u/1661068?v=3","gravatar_id":"","url":"https://api.github.com/users/infosia","html_url":"https://github.com/infosia","followers_url":"https://api.github.com/users/infosia/followers","following_url":"https://api.github.com/users/infosia/following{/other_user}","gists_url":"https://api.github.com/users/infosia/gists{/gist_id}","starred_url":"https://api.github.com/users/infosia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infosia/subscriptions","organizations_url":"https://api.github.com/users/infosia/orgs","repos_url":"https://api.github.com/users/infosia/repos","events_url":"https://api.github.com/users/infosia/events{/privacy}","received_events_url":"https://api.github.com/users/infosia/received_events","type":"User","site_admin":false},"body":"Fix for [TIMOB-18696](https://jira.appcelerator.org/browse/TIMOB-18696) and [TIMOB-18695](https://jira.appcelerator.org/browse/TIMOB-18695). I noticed that you don't have to make them `virtual` and just use HAL types as it is because Database module is cross-platform and thus nobody extends it. Because original purpose of \"removing HAL types\" is meant to separate TitaniumKit from platform-specific modules, I think this fix fits the requirement.\r\n","created_at":"2015-04-15T05:17:36Z","updated_at":"2015-04-15T08:57:43Z","closed_at":"2015-04-15T08:57:43Z","merged_at":null,"merge_commit_sha":"15b33706cd1c734cf863f1b5ce1688f5426460d4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/pulls/219/commits","review_comments_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/pulls/219/comments","review_comment_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/pulls/comments{/number}","comments_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/issues/219/comments","statuses_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/statuses/d26fe937b6e362ecaab96375d9e156e8084e080f","head":{"label":"infosia:TIMOB-18696","ref":"TIMOB-18696","sha":"d26fe937b6e362ecaab96375d9e156e8084e080f","user":{"login":"infosia","id":1661068,"avatar_url":"https://avatars.githubusercontent.com/u/1661068?v=3","gravatar_id":"","url":"https://api.github.com/users/infosia","html_url":"https://github.com/infosia","followers_url":"https://api.github.com/users/infosia/followers","following_url":"https://api.github.com/users/infosia/following{/other_user}","gists_url":"https://api.github.com/users/infosia/gists{/gist_id}","starred_url":"https://api.github.com/users/infosia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infosia/subscriptions","organizations_url":"https://api.github.com/users/infosia/orgs","repos_url":"https://api.github.com/users/infosia/repos","events_url":"https://api.github.com/users/infosia/events{/privacy}","received_events_url":"https://api.github.com/users/infosia/received_events","type":"User","site_admin":false},"repo":{"id":33272635,"name":"titanium_mobile_windows","full_name":"infosia/titanium_mobile_windows","owner":{"login":"infosia","id":1661068,"avatar_url":"https://avatars.githubusercontent.com/u/1661068?v=3","gravatar_id":"","url":"https://api.github.com/users/infosia","html_url":"https://github.com/infosia","followers_url":"https://api.github.com/users/infosia/followers","following_url":"https://api.github.com/users/infosia/following{/other_user}","gists_url":"https://api.github.com/users/infosia/gists{/gist_id}","starred_url":"https://api.github.com/users/infosia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infosia/subscriptions","organizations_url":"https://api.github.com/users/infosia/orgs","repos_url":"https://api.github.com/users/infosia/repos","events_url":"https://api.github.com/users/infosia/events{/privacy}","received_events_url":"https://api.github.com/users/infosia/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/infosia/titanium_mobile_windows","description":"Windows platform for Titanium Mobile","fork":true,"url":"https://api.github.com/repos/infosia/titanium_mobile_windows","forks_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/forks","keys_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/keys{/key_id}","collaborators_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/teams","hooks_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/hooks","issue_events_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/issues/events{/number}","events_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/events","assignees_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/assignees{/user}","branches_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/branches{/branch}","tags_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/tags","blobs_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/git/refs{/sha}","trees_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/git/trees{/sha}","statuses_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/statuses/{sha}","languages_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/languages","stargazers_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/stargazers","contributors_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/contributors","subscribers_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/subscribers","subscription_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/subscription","commits_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/commits{/sha}","git_commits_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/git/commits{/sha}","comments_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/comments{/number}","issue_comment_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/issues/comments{/number}","contents_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/contents/{+path}","compare_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/compare/{base}...{head}","merges_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/merges","archive_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/downloads","issues_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/issues{/number}","pulls_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/pulls{/number}","milestones_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/milestones{/number}","notifications_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/labels{/name}","releases_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/releases{/id}","created_at":"2015-04-01T20:57:51Z","updated_at":"2015-04-15T04:06:02Z","pushed_at":"2015-04-15T08:53:28Z","git_url":"git://github.com/infosia/titanium_mobile_windows.git","ssh_url":"git@github.com:infosia/titanium_mobile_windows.git","clone_url":"https://github.com/infosia/titanium_mobile_windows.git","svn_url":"https://github.com/infosia/titanium_mobile_windows","homepage":null,"size":35797,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"appcelerator:master","ref":"master","sha":"eefcaaa3b96a9e53ef56bd0fc3bc171b71bdd48e","user":{"login":"appcelerator","id":82188,"avatar_url":"https://avatars.githubusercontent.com/u/82188?v=3","gravatar_id":"","url":"https://api.github.com/users/appcelerator","html_url":"https://github.com/appcelerator","followers_url":"https://api.github.com/users/appcelerator/followers","following_url":"https://api.github.com/users/appcelerator/following{/other_user}","gists_url":"https://api.github.com/users/appcelerator/gists{/gist_id}","starred_url":"https://api.github.com/users/appcelerator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appcelerator/subscriptions","organizations_url":"https://api.github.com/users/appcelerator/orgs","repos_url":"https://api.github.com/users/appcelerator/repos","events_url":"https://api.github.com/users/appcelerator/events{/privacy}","received_events_url":"https://api.github.com/users/appcelerator/received_events","type":"Organization","site_admin":false},"repo":{"id":27684398,"name":"titanium_mobile_windows","full_name":"appcelerator/titanium_mobile_windows","owner":{"login":"appcelerator","id":82188,"avatar_url":"https://avatars.githubusercontent.com/u/82188?v=3","gravatar_id":"","url":"https://api.github.com/users/appcelerator","html_url":"https://github.com/appcelerator","followers_url":"https://api.github.com/users/appcelerator/followers","following_url":"https://api.github.com/users/appcelerator/following{/other_user}","gists_url":"https://api.github.com/users/appcelerator/gists{/gist_id}","starred_url":"https://api.github.com/users/appcelerator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appcelerator/subscriptions","organizations_url":"https://api.github.com/users/appcelerator/orgs","repos_url":"https://api.github.com/users/appcelerator/repos","events_url":"https://api.github.com/users/appcelerator/events{/privacy}","received_events_url":"https://api.github.com/users/appcelerator/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/appcelerator/titanium_mobile_windows","description":"Windows platform for Titanium Mobile","fork":false,"url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows","forks_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/forks","keys_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/keys{/key_id}","collaborators_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/teams","hooks_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/hooks","issue_events_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/issues/events{/number}","events_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/events","assignees_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/assignees{/user}","branches_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/branches{/branch}","tags_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/tags","blobs_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/git/refs{/sha}","trees_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/git/trees{/sha}","statuses_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/statuses/{sha}","languages_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/languages","stargazers_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/stargazers","contributors_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/contributors","subscribers_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/subscribers","subscription_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/subscription","commits_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/commits{/sha}","git_commits_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/git/commits{/sha}","comments_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/comments{/number}","issue_comment_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/issues/comments{/number}","contents_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/contents/{+path}","compare_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/compare/{base}...{head}","merges_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/merges","archive_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/downloads","issues_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/issues{/number}","pulls_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/pulls{/number}","milestones_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/milestones{/number}","notifications_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/labels{/name}","releases_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/releases{/id}","created_at":"2014-12-07T20:55:18Z","updated_at":"2015-04-15T03:55:03Z","pushed_at":"2015-04-15T08:57:16Z","git_url":"git://github.com/appcelerator/titanium_mobile_windows.git","ssh_url":"git@github.com:appcelerator/titanium_mobile_windows.git","clone_url":"https://github.com/appcelerator/titanium_mobile_windows.git","svn_url":"https://github.com/appcelerator/titanium_mobile_windows","homepage":null,"size":39055,"stargazers_count":4,"watchers_count":4,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":3,"forks":5,"open_issues":3,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/pulls/219"},"html":{"href":"https://github.com/appcelerator/titanium_mobile_windows/pull/219"},"issue":{"href":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/issues/219"},"comments":{"href":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/issues/219/comments"},"review_comments":{"href":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/pulls/219/comments"},"review_comment":{"href":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/pulls/219/commits"},"statuses":{"href":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/statuses/d26fe937b6e362ecaab96375d9e156e8084e080f"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":2,"review_comments":0,"commits":1,"additions":19,"deletions":19,"changed_files":2}}