{"action":"created","comment":{"url":"https://api.github.com/repos/Dolibarr/dolibarr/pulls/comments/45327675","id":45327675,"diff_hunk":"@@ -1689,7 +1689,11 @@ function dol_substr($string,$start,$length,$stringencoding='')\n \tif (empty($stringencoding)) $stringencoding=$langs->charset_output;\n \n \t$ret='';\n-\tif (function_exists('mb_substr'))\n+\tif (function_exists('iconv_substr'))\n+\t{\n+\t\t$ret=iconv_substr($string,$start,$length,$stringencoding);\n+\t}\n+\telse if (function_exists('mb_substr'))","path":"htdocs/core/lib/functions.lib.php","position":9,"original_position":9,"commit_id":"12e3612e3aff447f140e8ffe47d4c79c4ec4d555","original_commit_id":"12e3612e3aff447f140e8ffe47d4c79c4ec4d555","user":{"login":"atm-arnaud","id":14542208,"avatar_url":"https://avatars.githubusercontent.com/u/14542208?v=3","gravatar_id":"","url":"https://api.github.com/users/atm-arnaud","html_url":"https://github.com/atm-arnaud","followers_url":"https://api.github.com/users/atm-arnaud/followers","following_url":"https://api.github.com/users/atm-arnaud/following{/other_user}","gists_url":"https://api.github.com/users/atm-arnaud/gists{/gist_id}","starred_url":"https://api.github.com/users/atm-arnaud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atm-arnaud/subscriptions","organizations_url":"https://api.github.com/users/atm-arnaud/orgs","repos_url":"https://api.github.com/users/atm-arnaud/repos","events_url":"https://api.github.com/users/atm-arnaud/events{/privacy}","received_events_url":"https://api.github.com/users/atm-arnaud/received_events","type":"User","site_admin":false},"body":"That's right i used the else if instead of elseif... In fact this file has 42 else if  and 64 elseif.\r\nI don't really think that's so important here. But i promise that i'll be carefuly for my next devs.","created_at":"2015-11-19T11:10:28Z","updated_at":"2015-11-19T11:10:28Z","html_url":"https://github.com/Dolibarr/dolibarr/pull/4029#discussion_r45327675","pull_request_url":"https://api.github.com/repos/Dolibarr/dolibarr/pulls/4029","_links":{"self":{"href":"https://api.github.com/repos/Dolibarr/dolibarr/pulls/comments/45327675"},"html":{"href":"https://github.com/Dolibarr/dolibarr/pull/4029#discussion_r45327675"},"pull_request":{"href":"https://api.github.com/repos/Dolibarr/dolibarr/pulls/4029"}}},"pull_request":{"url":"https://api.github.com/repos/Dolibarr/dolibarr/pulls/4029","id":51069946,"html_url":"https://github.com/Dolibarr/dolibarr/pull/4029","diff_url":"https://github.com/Dolibarr/dolibarr/pull/4029.diff","patch_url":"https://github.com/Dolibarr/dolibarr/pull/4029.patch","issue_url":"https://api.github.com/repos/Dolibarr/dolibarr/issues/4029","number":4029,"state":"open","locked":false,"title":"FIX new updated function for clients without mb_substr function","user":{"login":"atm-arnaud","id":14542208,"avatar_url":"https://avatars.githubusercontent.com/u/14542208?v=3","gravatar_id":"","url":"https://api.github.com/users/atm-arnaud","html_url":"https://github.com/atm-arnaud","followers_url":"https://api.github.com/users/atm-arnaud/followers","following_url":"https://api.github.com/users/atm-arnaud/following{/other_user}","gists_url":"https://api.github.com/users/atm-arnaud/gists{/gist_id}","starred_url":"https://api.github.com/users/atm-arnaud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atm-arnaud/subscriptions","organizations_url":"https://api.github.com/users/atm-arnaud/orgs","repos_url":"https://api.github.com/users/atm-arnaud/repos","events_url":"https://api.github.com/users/atm-arnaud/events{/privacy}","received_events_url":"https://api.github.com/users/atm-arnaud/received_events","type":"User","site_admin":false},"body":"Fix for php server without mb_substr function activate. This fix will use an other function more supported by php.","created_at":"2015-11-18T11:01:59Z","updated_at":"2015-11-19T11:10:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"287563ca3ecac6ae135e21a32bc3ca6e3fffeed3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Dolibarr/dolibarr/pulls/4029/commits","review_comments_url":"https://api.github.com/repos/Dolibarr/dolibarr/pulls/4029/comments","review_comment_url":"https://api.github.com/repos/Dolibarr/dolibarr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Dolibarr/dolibarr/issues/4029/comments","statuses_url":"https://api.github.com/repos/Dolibarr/dolibarr/statuses/12e3612e3aff447f140e8ffe47d4c79c4ec4d555","head":{"label":"atm-arnaud:3.8_fix_dol_substr","ref":"3.8_fix_dol_substr","sha":"12e3612e3aff447f140e8ffe47d4c79c4ec4d555","user":{"login":"atm-arnaud","id":14542208,"avatar_url":"https://avatars.githubusercontent.com/u/14542208?v=3","gravatar_id":"","url":"https://api.github.com/users/atm-arnaud","html_url":"https://github.com/atm-arnaud","followers_url":"https://api.github.com/users/atm-arnaud/followers","following_url":"https://api.github.com/users/atm-arnaud/following{/other_user}","gists_url":"https://api.github.com/users/atm-arnaud/gists{/gist_id}","starred_url":"https://api.github.com/users/atm-arnaud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atm-arnaud/subscriptions","organizations_url":"https://api.github.com/users/atm-arnaud/orgs","repos_url":"https://api.github.com/users/atm-arnaud/repos","events_url":"https://api.github.com/users/atm-arnaud/events{/privacy}","received_events_url":"https://api.github.com/users/atm-arnaud/received_events","type":"User","site_admin":false},"repo":{"id":43306983,"name":"dolibarr","full_name":"atm-arnaud/dolibarr","owner":{"login":"atm-arnaud","id":14542208,"avatar_url":"https://avatars.githubusercontent.com/u/14542208?v=3","gravatar_id":"","url":"https://api.github.com/users/atm-arnaud","html_url":"https://github.com/atm-arnaud","followers_url":"https://api.github.com/users/atm-arnaud/followers","following_url":"https://api.github.com/users/atm-arnaud/following{/other_user}","gists_url":"https://api.github.com/users/atm-arnaud/gists{/gist_id}","starred_url":"https://api.github.com/users/atm-arnaud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atm-arnaud/subscriptions","organizations_url":"https://api.github.com/users/atm-arnaud/orgs","repos_url":"https://api.github.com/users/atm-arnaud/repos","events_url":"https://api.github.com/users/atm-arnaud/events{/privacy}","received_events_url":"https://api.github.com/users/atm-arnaud/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/atm-arnaud/dolibarr","description":"Dolibarr ERP CRM is a modern software to manage your company or foundation activity (contacts, suppliers, invoices, orders, stocks, agenda, ...).It's an opensource software (wrote with PHP language) designed for small and medium companies, foundation and freelances. You can freely install, use and distribute it as a standalone application or as a web application to use it from every internet access and media.","fork":true,"url":"https://api.github.com/repos/atm-arnaud/dolibarr","forks_url":"https://api.github.com/repos/atm-arnaud/dolibarr/forks","keys_url":"https://api.github.com/repos/atm-arnaud/dolibarr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/atm-arnaud/dolibarr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/atm-arnaud/dolibarr/teams","hooks_url":"https://api.github.com/repos/atm-arnaud/dolibarr/hooks","issue_events_url":"https://api.github.com/repos/atm-arnaud/dolibarr/issues/events{/number}","events_url":"https://api.github.com/repos/atm-arnaud/dolibarr/events","assignees_url":"https://api.github.com/repos/atm-arnaud/dolibarr/assignees{/user}","branches_url":"https://api.github.com/repos/atm-arnaud/dolibarr/branches{/branch}","tags_url":"https://api.github.com/repos/atm-arnaud/dolibarr/tags","blobs_url":"https://api.github.com/repos/atm-arnaud/dolibarr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/atm-arnaud/dolibarr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/atm-arnaud/dolibarr/git/refs{/sha}","trees_url":"https://api.github.com/repos/atm-arnaud/dolibarr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/atm-arnaud/dolibarr/statuses/{sha}","languages_url":"https://api.github.com/repos/atm-arnaud/dolibarr/languages","stargazers_url":"https://api.github.com/repos/atm-arnaud/dolibarr/stargazers","contributors_url":"https://api.github.com/repos/atm-arnaud/dolibarr/contributors","subscribers_url":"https://api.github.com/repos/atm-arnaud/dolibarr/subscribers","subscription_url":"https://api.github.com/repos/atm-arnaud/dolibarr/subscription","commits_url":"https://api.github.com/repos/atm-arnaud/dolibarr/commits{/sha}","git_commits_url":"https://api.github.com/repos/atm-arnaud/dolibarr/git/commits{/sha}","comments_url":"https://api.github.com/repos/atm-arnaud/dolibarr/comments{/number}","issue_comment_url":"https://api.github.com/repos/atm-arnaud/dolibarr/issues/comments{/number}","contents_url":"https://api.github.com/repos/atm-arnaud/dolibarr/contents/{+path}","compare_url":"https://api.github.com/repos/atm-arnaud/dolibarr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/atm-arnaud/dolibarr/merges","archive_url":"https://api.github.com/repos/atm-arnaud/dolibarr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/atm-arnaud/dolibarr/downloads","issues_url":"https://api.github.com/repos/atm-arnaud/dolibarr/issues{/number}","pulls_url":"https://api.github.com/repos/atm-arnaud/dolibarr/pulls{/number}","milestones_url":"https://api.github.com/repos/atm-arnaud/dolibarr/milestones{/number}","notifications_url":"https://api.github.com/repos/atm-arnaud/dolibarr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/atm-arnaud/dolibarr/labels{/name}","releases_url":"https://api.github.com/repos/atm-arnaud/dolibarr/releases{/id}","created_at":"2015-09-28T14:46:23Z","updated_at":"2015-09-28T14:47:29Z","pushed_at":"2015-11-19T10:27:13Z","git_url":"git://github.com/atm-arnaud/dolibarr.git","ssh_url":"git@github.com:atm-arnaud/dolibarr.git","clone_url":"https://github.com/atm-arnaud/dolibarr.git","svn_url":"https://github.com/atm-arnaud/dolibarr","homepage":"http://www.dolibarr.org","size":292902,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"Dolibarr:3.8","ref":"3.8","sha":"508b11733af4ab76fd14536135a953fcaf03cd51","user":{"login":"Dolibarr","id":877491,"avatar_url":"https://avatars.githubusercontent.com/u/877491?v=3","gravatar_id":"","url":"https://api.github.com/users/Dolibarr","html_url":"https://github.com/Dolibarr","followers_url":"https://api.github.com/users/Dolibarr/followers","following_url":"https://api.github.com/users/Dolibarr/following{/other_user}","gists_url":"https://api.github.com/users/Dolibarr/gists{/gist_id}","starred_url":"https://api.github.com/users/Dolibarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dolibarr/subscriptions","organizations_url":"https://api.github.com/users/Dolibarr/orgs","repos_url":"https://api.github.com/users/Dolibarr/repos","events_url":"https://api.github.com/users/Dolibarr/events{/privacy}","received_events_url":"https://api.github.com/users/Dolibarr/received_events","type":"Organization","site_admin":false},"repo":{"id":1957456,"name":"dolibarr","full_name":"Dolibarr/dolibarr","owner":{"login":"Dolibarr","id":877491,"avatar_url":"https://avatars.githubusercontent.com/u/877491?v=3","gravatar_id":"","url":"https://api.github.com/users/Dolibarr","html_url":"https://github.com/Dolibarr","followers_url":"https://api.github.com/users/Dolibarr/followers","following_url":"https://api.github.com/users/Dolibarr/following{/other_user}","gists_url":"https://api.github.com/users/Dolibarr/gists{/gist_id}","starred_url":"https://api.github.com/users/Dolibarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dolibarr/subscriptions","organizations_url":"https://api.github.com/users/Dolibarr/orgs","repos_url":"https://api.github.com/users/Dolibarr/repos","events_url":"https://api.github.com/users/Dolibarr/events{/privacy}","received_events_url":"https://api.github.com/users/Dolibarr/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Dolibarr/dolibarr","description":"Dolibarr ERP CRM is a modern software to manage your company or foundation activity (contacts, suppliers, invoices, orders, stocks, agenda, ...).It's an opensource software (wrote with PHP language) designed for small and medium companies, foundation and freelances. You can freely install, use and distribute it as a standalone application or as a web application to use it from every internet access and media.","fork":false,"url":"https://api.github.com/repos/Dolibarr/dolibarr","forks_url":"https://api.github.com/repos/Dolibarr/dolibarr/forks","keys_url":"https://api.github.com/repos/Dolibarr/dolibarr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Dolibarr/dolibarr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Dolibarr/dolibarr/teams","hooks_url":"https://api.github.com/repos/Dolibarr/dolibarr/hooks","issue_events_url":"https://api.github.com/repos/Dolibarr/dolibarr/issues/events{/number}","events_url":"https://api.github.com/repos/Dolibarr/dolibarr/events","assignees_url":"https://api.github.com/repos/Dolibarr/dolibarr/assignees{/user}","branches_url":"https://api.github.com/repos/Dolibarr/dolibarr/branches{/branch}","tags_url":"https://api.github.com/repos/Dolibarr/dolibarr/tags","blobs_url":"https://api.github.com/repos/Dolibarr/dolibarr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Dolibarr/dolibarr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Dolibarr/dolibarr/git/refs{/sha}","trees_url":"https://api.github.com/repos/Dolibarr/dolibarr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Dolibarr/dolibarr/statuses/{sha}","languages_url":"https://api.github.com/repos/Dolibarr/dolibarr/languages","stargazers_url":"https://api.github.com/repos/Dolibarr/dolibarr/stargazers","contributors_url":"https://api.github.com/repos/Dolibarr/dolibarr/contributors","subscribers_url":"https://api.github.com/repos/Dolibarr/dolibarr/subscribers","subscription_url":"https://api.github.com/repos/Dolibarr/dolibarr/subscription","commits_url":"https://api.github.com/repos/Dolibarr/dolibarr/commits{/sha}","git_commits_url":"https://api.github.com/repos/Dolibarr/dolibarr/git/commits{/sha}","comments_url":"https://api.github.com/repos/Dolibarr/dolibarr/comments{/number}","issue_comment_url":"https://api.github.com/repos/Dolibarr/dolibarr/issues/comments{/number}","contents_url":"https://api.github.com/repos/Dolibarr/dolibarr/contents/{+path}","compare_url":"https://api.github.com/repos/Dolibarr/dolibarr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Dolibarr/dolibarr/merges","archive_url":"https://api.github.com/repos/Dolibarr/dolibarr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Dolibarr/dolibarr/downloads","issues_url":"https://api.github.com/repos/Dolibarr/dolibarr/issues{/number}","pulls_url":"https://api.github.com/repos/Dolibarr/dolibarr/pulls{/number}","milestones_url":"https://api.github.com/repos/Dolibarr/dolibarr/milestones{/number}","notifications_url":"https://api.github.com/repos/Dolibarr/dolibarr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Dolibarr/dolibarr/labels{/name}","releases_url":"https://api.github.com/repos/Dolibarr/dolibarr/releases{/id}","created_at":"2011-06-26T21:55:03Z","updated_at":"2015-11-18T15:55:14Z","pushed_at":"2015-11-19T10:27:15Z","git_url":"git://github.com/Dolibarr/dolibarr.git","ssh_url":"git@github.com:Dolibarr/dolibarr.git","clone_url":"https://github.com/Dolibarr/dolibarr.git","svn_url":"https://github.com/Dolibarr/dolibarr","homepage":"http://www.dolibarr.org","size":307108,"stargazers_count":419,"watchers_count":419,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":384,"mirror_url":null,"open_issues_count":277,"forks":384,"open_issues":277,"watchers":419,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/Dolibarr/dolibarr/pulls/4029"},"html":{"href":"https://github.com/Dolibarr/dolibarr/pull/4029"},"issue":{"href":"https://api.github.com/repos/Dolibarr/dolibarr/issues/4029"},"comments":{"href":"https://api.github.com/repos/Dolibarr/dolibarr/issues/4029/comments"},"review_comments":{"href":"https://api.github.com/repos/Dolibarr/dolibarr/pulls/4029/comments"},"review_comment":{"href":"https://api.github.com/repos/Dolibarr/dolibarr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Dolibarr/dolibarr/pulls/4029/commits"},"statuses":{"href":"https://api.github.com/repos/Dolibarr/dolibarr/statuses/12e3612e3aff447f140e8ffe47d4c79c4ec4d555"}}}}