{"action":"opened","number":1979,"pull_request":{"url":"https://api.github.com/repos/mono/mono/pulls/1979","id":42513863,"html_url":"https://github.com/mono/mono/pull/1979","diff_url":"https://github.com/mono/mono/pull/1979.diff","patch_url":"https://github.com/mono/mono/pull/1979.patch","issue_url":"https://api.github.com/repos/mono/mono/issues/1979","number":1979,"state":"open","locked":false,"title":"[utils] Change mono_conc_hashtable write operations to rely on external locking.","user":{"login":"kumpera","id":5738,"avatar_url":"https://avatars.githubusercontent.com/u/5738?v=3","gravatar_id":"","url":"https://api.github.com/users/kumpera","html_url":"https://github.com/kumpera","followers_url":"https://api.github.com/users/kumpera/followers","following_url":"https://api.github.com/users/kumpera/following{/other_user}","gists_url":"https://api.github.com/users/kumpera/gists{/gist_id}","starred_url":"https://api.github.com/users/kumpera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kumpera/subscriptions","organizations_url":"https://api.github.com/users/kumpera/orgs","repos_url":"https://api.github.com/users/kumpera/repos","events_url":"https://api.github.com/users/kumpera/events{/privacy}","received_events_url":"https://api.github.com/users/kumpera/received_events","type":"User","site_admin":false},"body":"The original design was to pass a lock to the mono_conc_hashtable constructor and\nthen the write operations would do locking themselves.\n\nThat turned out to be a problem for two reasons:\n\nFirst, it hidden the fact that locking was happening. Every other data structure in\nthe runtime rely on the caller to perform locking - thus that design ended up been\na lie.\n\nSecond, under coop, taking the lock became a problem as leak locks should be taken\nin GC Safe mode and other locks should be taken under GC Unsafe mode. Taking a lock\nin the wrong GC mode makes the suspend watchdog bark really loudly.\n\nThe runtime, funny enough has 2 usages of the conc hashtable, one with the image lock\nand one with the domain lock - and each must be taken in a different GC mode. That\nmeant that either overcomplicating the design, or just removing locking from it.\n\nThis commit does that. It removes the mutex from mono_conc_hashtable and hoist locking\naround the calls that used to do it.","created_at":"2015-08-15T04:48:23Z","updated_at":"2015-08-15T04:48:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mono/mono/pulls/1979/commits","review_comments_url":"https://api.github.com/repos/mono/mono/pulls/1979/comments","review_comment_url":"https://api.github.com/repos/mono/mono/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mono/mono/issues/1979/comments","statuses_url":"https://api.github.com/repos/mono/mono/statuses/d164e49e079a95ae8998f2e487a8a841fd9c0148","head":{"label":"kumpera:conc_fix","ref":"conc_fix","sha":"d164e49e079a95ae8998f2e487a8a841fd9c0148","user":{"login":"kumpera","id":5738,"avatar_url":"https://avatars.githubusercontent.com/u/5738?v=3","gravatar_id":"","url":"https://api.github.com/users/kumpera","html_url":"https://github.com/kumpera","followers_url":"https://api.github.com/users/kumpera/followers","following_url":"https://api.github.com/users/kumpera/following{/other_user}","gists_url":"https://api.github.com/users/kumpera/gists{/gist_id}","starred_url":"https://api.github.com/users/kumpera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kumpera/subscriptions","organizations_url":"https://api.github.com/users/kumpera/orgs","repos_url":"https://api.github.com/users/kumpera/repos","events_url":"https://api.github.com/users/kumpera/events{/privacy}","received_events_url":"https://api.github.com/users/kumpera/received_events","type":"User","site_admin":false},"repo":{"id":793663,"name":"mono","full_name":"kumpera/mono","owner":{"login":"kumpera","id":5738,"avatar_url":"https://avatars.githubusercontent.com/u/5738?v=3","gravatar_id":"","url":"https://api.github.com/users/kumpera","html_url":"https://github.com/kumpera","followers_url":"https://api.github.com/users/kumpera/followers","following_url":"https://api.github.com/users/kumpera/following{/other_user}","gists_url":"https://api.github.com/users/kumpera/gists{/gist_id}","starred_url":"https://api.github.com/users/kumpera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kumpera/subscriptions","organizations_url":"https://api.github.com/users/kumpera/orgs","repos_url":"https://api.github.com/users/kumpera/repos","events_url":"https://api.github.com/users/kumpera/events{/privacy}","received_events_url":"https://api.github.com/users/kumpera/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kumpera/mono","description":"Home of the Mono runtime, the Mono C# compiler, and the Mono class libraries.","fork":true,"url":"https://api.github.com/repos/kumpera/mono","forks_url":"https://api.github.com/repos/kumpera/mono/forks","keys_url":"https://api.github.com/repos/kumpera/mono/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kumpera/mono/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kumpera/mono/teams","hooks_url":"https://api.github.com/repos/kumpera/mono/hooks","issue_events_url":"https://api.github.com/repos/kumpera/mono/issues/events{/number}","events_url":"https://api.github.com/repos/kumpera/mono/events","assignees_url":"https://api.github.com/repos/kumpera/mono/assignees{/user}","branches_url":"https://api.github.com/repos/kumpera/mono/branches{/branch}","tags_url":"https://api.github.com/repos/kumpera/mono/tags","blobs_url":"https://api.github.com/repos/kumpera/mono/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kumpera/mono/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kumpera/mono/git/refs{/sha}","trees_url":"https://api.github.com/repos/kumpera/mono/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kumpera/mono/statuses/{sha}","languages_url":"https://api.github.com/repos/kumpera/mono/languages","stargazers_url":"https://api.github.com/repos/kumpera/mono/stargazers","contributors_url":"https://api.github.com/repos/kumpera/mono/contributors","subscribers_url":"https://api.github.com/repos/kumpera/mono/subscribers","subscription_url":"https://api.github.com/repos/kumpera/mono/subscription","commits_url":"https://api.github.com/repos/kumpera/mono/commits{/sha}","git_commits_url":"https://api.github.com/repos/kumpera/mono/git/commits{/sha}","comments_url":"https://api.github.com/repos/kumpera/mono/comments{/number}","issue_comment_url":"https://api.github.com/repos/kumpera/mono/issues/comments{/number}","contents_url":"https://api.github.com/repos/kumpera/mono/contents/{+path}","compare_url":"https://api.github.com/repos/kumpera/mono/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kumpera/mono/merges","archive_url":"https://api.github.com/repos/kumpera/mono/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kumpera/mono/downloads","issues_url":"https://api.github.com/repos/kumpera/mono/issues{/number}","pulls_url":"https://api.github.com/repos/kumpera/mono/pulls{/number}","milestones_url":"https://api.github.com/repos/kumpera/mono/milestones{/number}","notifications_url":"https://api.github.com/repos/kumpera/mono/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kumpera/mono/labels{/name}","releases_url":"https://api.github.com/repos/kumpera/mono/releases{/id}","created_at":"2010-07-23T17:31:15Z","updated_at":"2015-07-29T23:05:25Z","pushed_at":"2015-08-15T04:47:06Z","git_url":"git://github.com/kumpera/mono.git","ssh_url":"git@github.com:kumpera/mono.git","clone_url":"https://github.com/kumpera/mono.git","svn_url":"https://github.com/kumpera/mono","homepage":"http://www.mono-project.com/","size":427851,"stargazers_count":3,"watchers_count":3,"language":"C#","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":3,"default_branch":"master"}},"base":{"label":"mono:master","ref":"master","sha":"321e08e5eee54cdab4db5b3199f0ef187965060b","user":{"login":"mono","id":53395,"avatar_url":"https://avatars.githubusercontent.com/u/53395?v=3","gravatar_id":"","url":"https://api.github.com/users/mono","html_url":"https://github.com/mono","followers_url":"https://api.github.com/users/mono/followers","following_url":"https://api.github.com/users/mono/following{/other_user}","gists_url":"https://api.github.com/users/mono/gists{/gist_id}","starred_url":"https://api.github.com/users/mono/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mono/subscriptions","organizations_url":"https://api.github.com/users/mono/orgs","repos_url":"https://api.github.com/users/mono/repos","events_url":"https://api.github.com/users/mono/events{/privacy}","received_events_url":"https://api.github.com/users/mono/received_events","type":"Organization","site_admin":false},"repo":{"id":791611,"name":"mono","full_name":"mono/mono","owner":{"login":"mono","id":53395,"avatar_url":"https://avatars.githubusercontent.com/u/53395?v=3","gravatar_id":"","url":"https://api.github.com/users/mono","html_url":"https://github.com/mono","followers_url":"https://api.github.com/users/mono/followers","following_url":"https://api.github.com/users/mono/following{/other_user}","gists_url":"https://api.github.com/users/mono/gists{/gist_id}","starred_url":"https://api.github.com/users/mono/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mono/subscriptions","organizations_url":"https://api.github.com/users/mono/orgs","repos_url":"https://api.github.com/users/mono/repos","events_url":"https://api.github.com/users/mono/events{/privacy}","received_events_url":"https://api.github.com/users/mono/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mono/mono","description":"Mono open source ECMA CLI, C# and .NET implementation.","fork":false,"url":"https://api.github.com/repos/mono/mono","forks_url":"https://api.github.com/repos/mono/mono/forks","keys_url":"https://api.github.com/repos/mono/mono/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mono/mono/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mono/mono/teams","hooks_url":"https://api.github.com/repos/mono/mono/hooks","issue_events_url":"https://api.github.com/repos/mono/mono/issues/events{/number}","events_url":"https://api.github.com/repos/mono/mono/events","assignees_url":"https://api.github.com/repos/mono/mono/assignees{/user}","branches_url":"https://api.github.com/repos/mono/mono/branches{/branch}","tags_url":"https://api.github.com/repos/mono/mono/tags","blobs_url":"https://api.github.com/repos/mono/mono/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mono/mono/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mono/mono/git/refs{/sha}","trees_url":"https://api.github.com/repos/mono/mono/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mono/mono/statuses/{sha}","languages_url":"https://api.github.com/repos/mono/mono/languages","stargazers_url":"https://api.github.com/repos/mono/mono/stargazers","contributors_url":"https://api.github.com/repos/mono/mono/contributors","subscribers_url":"https://api.github.com/repos/mono/mono/subscribers","subscription_url":"https://api.github.com/repos/mono/mono/subscription","commits_url":"https://api.github.com/repos/mono/mono/commits{/sha}","git_commits_url":"https://api.github.com/repos/mono/mono/git/commits{/sha}","comments_url":"https://api.github.com/repos/mono/mono/comments{/number}","issue_comment_url":"https://api.github.com/repos/mono/mono/issues/comments{/number}","contents_url":"https://api.github.com/repos/mono/mono/contents/{+path}","compare_url":"https://api.github.com/repos/mono/mono/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mono/mono/merges","archive_url":"https://api.github.com/repos/mono/mono/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mono/mono/downloads","issues_url":"https://api.github.com/repos/mono/mono/issues{/number}","pulls_url":"https://api.github.com/repos/mono/mono/pulls{/number}","milestones_url":"https://api.github.com/repos/mono/mono/milestones{/number}","notifications_url":"https://api.github.com/repos/mono/mono/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mono/mono/labels{/name}","releases_url":"https://api.github.com/repos/mono/mono/releases{/id}","created_at":"2010-07-22T18:06:36Z","updated_at":"2015-08-15T03:22:26Z","pushed_at":"2015-08-15T04:36:35Z","git_url":"git://github.com/mono/mono.git","ssh_url":"git@github.com:mono/mono.git","clone_url":"https://github.com/mono/mono.git","svn_url":"https://github.com/mono/mono","homepage":"http://www.mono-project.com/","size":1474752,"stargazers_count":3727,"watchers_count":3727,"language":"C#","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1857,"mirror_url":null,"open_issues_count":121,"forks":1857,"open_issues":121,"watchers":3727,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mono/mono/pulls/1979"},"html":{"href":"https://github.com/mono/mono/pull/1979"},"issue":{"href":"https://api.github.com/repos/mono/mono/issues/1979"},"comments":{"href":"https://api.github.com/repos/mono/mono/issues/1979/comments"},"review_comments":{"href":"https://api.github.com/repos/mono/mono/pulls/1979/comments"},"review_comment":{"href":"https://api.github.com/repos/mono/mono/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mono/mono/pulls/1979/commits"},"statuses":{"href":"https://api.github.com/repos/mono/mono/statuses/d164e49e079a95ae8998f2e487a8a841fd9c0148"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":114,"deletions":86,"changed_files":8}}