{"action":"closed","number":1444,"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/1444","id":27870462,"html_url":"https://github.com/ManageIQ/manageiq/pull/1444","diff_url":"https://github.com/ManageIQ/manageiq/pull/1444.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/1444.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/1444","number":1444,"state":"closed","locked":false,"title":"Bz1114656 rhev events ignore history","user":{"login":"blomquisg","id":14183,"avatar_url":"https://avatars.githubusercontent.com/u/14183?v=3","gravatar_id":"","url":"https://api.github.com/users/blomquisg","html_url":"https://github.com/blomquisg","followers_url":"https://api.github.com/users/blomquisg/followers","following_url":"https://api.github.com/users/blomquisg/following{/other_user}","gists_url":"https://api.github.com/users/blomquisg/gists{/gist_id}","starred_url":"https://api.github.com/users/blomquisg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blomquisg/subscriptions","organizations_url":"https://api.github.com/users/blomquisg/orgs","repos_url":"https://api.github.com/users/blomquisg/repos","events_url":"https://api.github.com/users/blomquisg/events{/privacy}","received_events_url":"https://api.github.com/users/blomquisg/received_events","type":"User","site_admin":false},"body":"When querying for events, the event monitor needs to be able to specify a maximum number of events to retrieve on the first attempt to retrieve events.  Without this capability, the event monitor will grab *all* of the events from the Ovirt server.  In some cases, this could amount to tens of thousands of historical events.\r\n\r\nBefore this change, previous versions of the Ovirt REST API would interpret a request for events with no query parameters as a request for the most recent event only.  The latest Ovirt REST API version interprets the same request as wanting *all* historical events.\r\n\r\nThis change ensures that queries against newer Ovirt REST APIs will react the same as if it were querying the older Ovirt REST API.\r\n\r\nAlso, the ovirt event monitor is specific to the ManageIQ application and should remain in the ManageIQ codebase instead of in the ovirt gem.\r\n\r\nDepends on https://github.com/ManageIQ/ovirt/pull/17\r\nThis should also likely generate a gemfile change since the ovirt gem will probably bump versions.\r\n\r\nhttps://bugzilla.redhat.com/show_bug.cgi?id=1114656","created_at":"2015-01-22T19:31:44Z","updated_at":"2015-01-23T16:35:02Z","closed_at":"2015-01-23T16:35:02Z","merged_at":"2015-01-23T16:35:02Z","merge_commit_sha":"d1ba8b8bd94785a9087a9a00912f417c2e171b80","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/1444/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/1444/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/1444/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/f75acd20cea5d98cd099155d7467209de32b3f61","head":{"label":"blomquisg:bz1114656-rhev-events-ignore-history","ref":"bz1114656-rhev-events-ignore-history","sha":"f75acd20cea5d98cd099155d7467209de32b3f61","user":{"login":"blomquisg","id":14183,"avatar_url":"https://avatars.githubusercontent.com/u/14183?v=3","gravatar_id":"","url":"https://api.github.com/users/blomquisg","html_url":"https://github.com/blomquisg","followers_url":"https://api.github.com/users/blomquisg/followers","following_url":"https://api.github.com/users/blomquisg/following{/other_user}","gists_url":"https://api.github.com/users/blomquisg/gists{/gist_id}","starred_url":"https://api.github.com/users/blomquisg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blomquisg/subscriptions","organizations_url":"https://api.github.com/users/blomquisg/orgs","repos_url":"https://api.github.com/users/blomquisg/repos","events_url":"https://api.github.com/users/blomquisg/events{/privacy}","received_events_url":"https://api.github.com/users/blomquisg/received_events","type":"User","site_admin":false},"repo":{"id":20887624,"name":"manageiq","full_name":"blomquisg/manageiq","owner":{"login":"blomquisg","id":14183,"avatar_url":"https://avatars.githubusercontent.com/u/14183?v=3","gravatar_id":"","url":"https://api.github.com/users/blomquisg","html_url":"https://github.com/blomquisg","followers_url":"https://api.github.com/users/blomquisg/followers","following_url":"https://api.github.com/users/blomquisg/following{/other_user}","gists_url":"https://api.github.com/users/blomquisg/gists{/gist_id}","starred_url":"https://api.github.com/users/blomquisg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blomquisg/subscriptions","organizations_url":"https://api.github.com/users/blomquisg/orgs","repos_url":"https://api.github.com/users/blomquisg/repos","events_url":"https://api.github.com/users/blomquisg/events{/privacy}","received_events_url":"https://api.github.com/users/blomquisg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/blomquisg/manageiq","description":"ManageIQ Cloud Management Platform","fork":true,"url":"https://api.github.com/repos/blomquisg/manageiq","forks_url":"https://api.github.com/repos/blomquisg/manageiq/forks","keys_url":"https://api.github.com/repos/blomquisg/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/blomquisg/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/blomquisg/manageiq/teams","hooks_url":"https://api.github.com/repos/blomquisg/manageiq/hooks","issue_events_url":"https://api.github.com/repos/blomquisg/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/blomquisg/manageiq/events","assignees_url":"https://api.github.com/repos/blomquisg/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/blomquisg/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/blomquisg/manageiq/tags","blobs_url":"https://api.github.com/repos/blomquisg/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/blomquisg/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/blomquisg/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/blomquisg/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/blomquisg/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/blomquisg/manageiq/languages","stargazers_url":"https://api.github.com/repos/blomquisg/manageiq/stargazers","contributors_url":"https://api.github.com/repos/blomquisg/manageiq/contributors","subscribers_url":"https://api.github.com/repos/blomquisg/manageiq/subscribers","subscription_url":"https://api.github.com/repos/blomquisg/manageiq/subscription","commits_url":"https://api.github.com/repos/blomquisg/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/blomquisg/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/blomquisg/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/blomquisg/manageiq/issues/comments/{number}","contents_url":"https://api.github.com/repos/blomquisg/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/blomquisg/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/blomquisg/manageiq/merges","archive_url":"https://api.github.com/repos/blomquisg/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/blomquisg/manageiq/downloads","issues_url":"https://api.github.com/repos/blomquisg/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/blomquisg/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/blomquisg/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/blomquisg/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/blomquisg/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/blomquisg/manageiq/releases{/id}","created_at":"2014-06-16T14:22:04Z","updated_at":"2014-06-24T21:02:56Z","pushed_at":"2015-01-23T14:12:43Z","git_url":"git://github.com/blomquisg/manageiq.git","ssh_url":"git@github.com:blomquisg/manageiq.git","clone_url":"https://github.com/blomquisg/manageiq.git","svn_url":"https://github.com/blomquisg/manageiq","homepage":null,"size":60489,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"f6adf4fc8273db9d03b2e3bacdd4274514944902","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":20789757,"name":"manageiq","full_name":"ManageIQ/manageiq","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq","description":"ManageIQ Cloud Management Platform","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq","forks_url":"https://api.github.com/repos/ManageIQ/manageiq/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments/{number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq/releases{/id}","created_at":"2014-06-13T02:31:26Z","updated_at":"2015-01-23T14:10:11Z","pushed_at":"2015-01-23T16:35:02Z","git_url":"git://github.com/ManageIQ/manageiq.git","ssh_url":"git@github.com:ManageIQ/manageiq.git","clone_url":"https://github.com/ManageIQ/manageiq.git","svn_url":"https://github.com/ManageIQ/manageiq","homepage":"manageiq.org","size":85954,"stargazers_count":79,"watchers_count":79,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":83,"mirror_url":null,"open_issues_count":239,"forks":83,"open_issues":239,"watchers":79,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/1444"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/1444"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/1444"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/1444/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/1444/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/1444/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq/statuses/f75acd20cea5d98cd099155d7467209de32b3f61"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"Fryguy","id":52120,"avatar_url":"https://avatars.githubusercontent.com/u/52120?v=3","gravatar_id":"","url":"https://api.github.com/users/Fryguy","html_url":"https://github.com/Fryguy","followers_url":"https://api.github.com/users/Fryguy/followers","following_url":"https://api.github.com/users/Fryguy/following{/other_user}","gists_url":"https://api.github.com/users/Fryguy/gists{/gist_id}","starred_url":"https://api.github.com/users/Fryguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fryguy/subscriptions","organizations_url":"https://api.github.com/users/Fryguy/orgs","repos_url":"https://api.github.com/users/Fryguy/repos","events_url":"https://api.github.com/users/Fryguy/events{/privacy}","received_events_url":"https://api.github.com/users/Fryguy/received_events","type":"User","site_admin":false},"comments":4,"review_comments":4,"commits":5,"additions":41,"deletions":3,"changed_files":3}}