{"action":"created","comment":{"url":"https://api.github.com/repos/mit-crpg/openmc/pulls/comments/24497543","id":24497543,"diff_hunk":"@@ -127,6 +127,9 @@ module constants\n        SURF_CONE_Y = 10, & ! Cone parallel to y-axis\n        SURF_CONE_Z = 11    ! Cone parallel to z-axis\n \n+  ! Flag to say that the outside of a lattice is not defined\n+  integer, parameter :: NO_OUTER_UNIV = -22","path":"src/constants.F90","position":5,"original_position":5,"commit_id":"eaa149b7ad04abf2a4a3d8b7a4a277ae3ccd5b65","original_commit_id":"eaa149b7ad04abf2a4a3d8b7a4a277ae3ccd5b65","user":{"login":"paulromano","id":743095,"avatar_url":"https://avatars.githubusercontent.com/u/743095?v=3","gravatar_id":"","url":"https://api.github.com/users/paulromano","html_url":"https://github.com/paulromano","followers_url":"https://api.github.com/users/paulromano/followers","following_url":"https://api.github.com/users/paulromano/following{/other_user}","gists_url":"https://api.github.com/users/paulromano/gists{/gist_id}","starred_url":"https://api.github.com/users/paulromano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulromano/subscriptions","organizations_url":"https://api.github.com/users/paulromano/orgs","repos_url":"https://api.github.com/users/paulromano/repos","events_url":"https://api.github.com/users/paulromano/events{/privacy}","received_events_url":"https://api.github.com/users/paulromano/received_events","type":"User","site_admin":false},"body":"I'd prefer the slightly more verbose `NO_OUTER_UNIVERSE`. And is there a reason you chose -22 as opposed to, say, -1?","created_at":"2015-02-11T14:21:57Z","updated_at":"2015-02-11T14:21:57Z","html_url":"https://github.com/mit-crpg/openmc/pull/359#discussion_r24497543","pull_request_url":"https://api.github.com/repos/mit-crpg/openmc/pulls/359","_links":{"self":{"href":"https://api.github.com/repos/mit-crpg/openmc/pulls/comments/24497543"},"html":{"href":"https://github.com/mit-crpg/openmc/pull/359#discussion_r24497543"},"pull_request":{"href":"https://api.github.com/repos/mit-crpg/openmc/pulls/359"}}},"pull_request":{"url":"https://api.github.com/repos/mit-crpg/openmc/pulls/359","id":29029323,"html_url":"https://github.com/mit-crpg/openmc/pull/359","diff_url":"https://github.com/mit-crpg/openmc/pull/359.diff","patch_url":"https://github.com/mit-crpg/openmc/pull/359.patch","issue_url":"https://api.github.com/repos/mit-crpg/openmc/issues/359","number":359,"state":"open","locked":false,"title":"Replace lattice outside materials with outer universes","user":{"login":"smharper","id":4622797,"avatar_url":"https://avatars.githubusercontent.com/u/4622797?v=3","gravatar_id":"","url":"https://api.github.com/users/smharper","html_url":"https://github.com/smharper","followers_url":"https://api.github.com/users/smharper/followers","following_url":"https://api.github.com/users/smharper/following{/other_user}","gists_url":"https://api.github.com/users/smharper/gists{/gist_id}","starred_url":"https://api.github.com/users/smharper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smharper/subscriptions","organizations_url":"https://api.github.com/users/smharper/orgs","repos_url":"https://api.github.com/users/smharper/repos","events_url":"https://api.github.com/users/smharper/events{/privacy}","received_events_url":"https://api.github.com/users/smharper/received_events","type":"User","site_admin":false},"body":"This PR removes the 'outside' material specification for lattices and replaces it with 'outer' universes.  These outer universes are placed in lattice positions so they form an infinite lattice.  For example, a geometry.xml file containing this lattice (universe 11 is a pin cell):\r\n\r\n```xml\r\n  <lattice id=\"21\" type=\"rect\" dimension=\"1 1\" outer=\"11\"\r\n    lower_left=\"0.0 0.0\" width=\"1.26 1.26\">\r\n    <universes>11</universes>\r\n  </lattice>\r\n```\r\n\r\nwill produce a geometry that looks like this:\r\n![periodic](https://cloud.githubusercontent.com/assets/4622797/6132328/d3e46472-b11f-11e4-8682-7aac825cb5a9.png)\r\n\r\nThis PR fixes issue #358.  Note that in addition to fixing that bug, this PR allows us to fake periodic boundary conditions, and @wbinventor has pointed out that it can help with tallying outside lattices.\r\n\r\nFor V&V purposes, I compared the eigenvalues of a periodic pin cell geometry (defined using 'outer') to a reflective pin cell geometry.  A run with 5000 particles and 5000 batches found a difference in k_eff of 22 +/- 25 e-05.\r\n\r\nThis PR necessarily breaks backwards-compatibility, but to ease the blow, I made a utility script which can update geometry.xml files.\r\n\r\nI would prefer that this PR take precedence over #313.","created_at":"2015-02-10T17:57:04Z","updated_at":"2015-02-11T14:21:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ef8bc25c298e11e6770214abc076bfb871990d8f","assignee":null,"milestone":{"url":"https://api.github.com/repos/mit-crpg/openmc/milestones/11","labels_url":"https://api.github.com/repos/mit-crpg/openmc/milestones/11/labels","id":769762,"number":11,"title":"v0.7","description":"","creator":{"login":"paulromano","id":743095,"avatar_url":"https://avatars.githubusercontent.com/u/743095?v=3","gravatar_id":"","url":"https://api.github.com/users/paulromano","html_url":"https://github.com/paulromano","followers_url":"https://api.github.com/users/paulromano/followers","following_url":"https://api.github.com/users/paulromano/following{/other_user}","gists_url":"https://api.github.com/users/paulromano/gists{/gist_id}","starred_url":"https://api.github.com/users/paulromano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulromano/subscriptions","organizations_url":"https://api.github.com/users/paulromano/orgs","repos_url":"https://api.github.com/users/paulromano/repos","events_url":"https://api.github.com/users/paulromano/events{/privacy}","received_events_url":"https://api.github.com/users/paulromano/received_events","type":"User","site_admin":false},"open_issues":9,"closed_issues":1,"state":"open","created_at":"2014-08-28T15:56:37Z","updated_at":"2015-02-11T04:39:45Z","due_on":"2015-03-31T04:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/mit-crpg/openmc/pulls/359/commits","review_comments_url":"https://api.github.com/repos/mit-crpg/openmc/pulls/359/comments","review_comment_url":"https://api.github.com/repos/mit-crpg/openmc/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mit-crpg/openmc/issues/359/comments","statuses_url":"https://api.github.com/repos/mit-crpg/openmc/statuses/eaa149b7ad04abf2a4a3d8b7a4a277ae3ccd5b65","head":{"label":"smharper:lattice_outside","ref":"lattice_outside","sha":"eaa149b7ad04abf2a4a3d8b7a4a277ae3ccd5b65","user":{"login":"smharper","id":4622797,"avatar_url":"https://avatars.githubusercontent.com/u/4622797?v=3","gravatar_id":"","url":"https://api.github.com/users/smharper","html_url":"https://github.com/smharper","followers_url":"https://api.github.com/users/smharper/followers","following_url":"https://api.github.com/users/smharper/following{/other_user}","gists_url":"https://api.github.com/users/smharper/gists{/gist_id}","starred_url":"https://api.github.com/users/smharper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smharper/subscriptions","organizations_url":"https://api.github.com/users/smharper/orgs","repos_url":"https://api.github.com/users/smharper/repos","events_url":"https://api.github.com/users/smharper/events{/privacy}","received_events_url":"https://api.github.com/users/smharper/received_events","type":"User","site_admin":false},"repo":{"id":10507820,"name":"openmc","full_name":"smharper/openmc","owner":{"login":"smharper","id":4622797,"avatar_url":"https://avatars.githubusercontent.com/u/4622797?v=3","gravatar_id":"","url":"https://api.github.com/users/smharper","html_url":"https://github.com/smharper","followers_url":"https://api.github.com/users/smharper/followers","following_url":"https://api.github.com/users/smharper/following{/other_user}","gists_url":"https://api.github.com/users/smharper/gists{/gist_id}","starred_url":"https://api.github.com/users/smharper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smharper/subscriptions","organizations_url":"https://api.github.com/users/smharper/orgs","repos_url":"https://api.github.com/users/smharper/repos","events_url":"https://api.github.com/users/smharper/events{/privacy}","received_events_url":"https://api.github.com/users/smharper/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/smharper/openmc","description":"OpenMC Monte Carlo Code","fork":true,"url":"https://api.github.com/repos/smharper/openmc","forks_url":"https://api.github.com/repos/smharper/openmc/forks","keys_url":"https://api.github.com/repos/smharper/openmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smharper/openmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smharper/openmc/teams","hooks_url":"https://api.github.com/repos/smharper/openmc/hooks","issue_events_url":"https://api.github.com/repos/smharper/openmc/issues/events{/number}","events_url":"https://api.github.com/repos/smharper/openmc/events","assignees_url":"https://api.github.com/repos/smharper/openmc/assignees{/user}","branches_url":"https://api.github.com/repos/smharper/openmc/branches{/branch}","tags_url":"https://api.github.com/repos/smharper/openmc/tags","blobs_url":"https://api.github.com/repos/smharper/openmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smharper/openmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smharper/openmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/smharper/openmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smharper/openmc/statuses/{sha}","languages_url":"https://api.github.com/repos/smharper/openmc/languages","stargazers_url":"https://api.github.com/repos/smharper/openmc/stargazers","contributors_url":"https://api.github.com/repos/smharper/openmc/contributors","subscribers_url":"https://api.github.com/repos/smharper/openmc/subscribers","subscription_url":"https://api.github.com/repos/smharper/openmc/subscription","commits_url":"https://api.github.com/repos/smharper/openmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/smharper/openmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/smharper/openmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/smharper/openmc/issues/comments/{number}","contents_url":"https://api.github.com/repos/smharper/openmc/contents/{+path}","compare_url":"https://api.github.com/repos/smharper/openmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smharper/openmc/merges","archive_url":"https://api.github.com/repos/smharper/openmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smharper/openmc/downloads","issues_url":"https://api.github.com/repos/smharper/openmc/issues{/number}","pulls_url":"https://api.github.com/repos/smharper/openmc/pulls{/number}","milestones_url":"https://api.github.com/repos/smharper/openmc/milestones{/number}","notifications_url":"https://api.github.com/repos/smharper/openmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smharper/openmc/labels{/name}","releases_url":"https://api.github.com/repos/smharper/openmc/releases{/id}","created_at":"2013-06-05T16:55:01Z","updated_at":"2015-02-07T21:54:53Z","pushed_at":"2015-02-10T17:14:35Z","git_url":"git://github.com/smharper/openmc.git","ssh_url":"git@github.com:smharper/openmc.git","clone_url":"https://github.com/smharper/openmc.git","svn_url":"https://github.com/smharper/openmc","homepage":"http://mit-crpg.github.io/openmc/","size":20127,"stargazers_count":0,"watchers_count":0,"language":"FORTRAN","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"mit-crpg:develop","ref":"develop","sha":"fa775430133cc9915b2c3431cf96aec2d6e57c6f","user":{"login":"mit-crpg","id":1247634,"avatar_url":"https://avatars.githubusercontent.com/u/1247634?v=3","gravatar_id":"","url":"https://api.github.com/users/mit-crpg","html_url":"https://github.com/mit-crpg","followers_url":"https://api.github.com/users/mit-crpg/followers","following_url":"https://api.github.com/users/mit-crpg/following{/other_user}","gists_url":"https://api.github.com/users/mit-crpg/gists{/gist_id}","starred_url":"https://api.github.com/users/mit-crpg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mit-crpg/subscriptions","organizations_url":"https://api.github.com/users/mit-crpg/orgs","repos_url":"https://api.github.com/users/mit-crpg/repos","events_url":"https://api.github.com/users/mit-crpg/events{/privacy}","received_events_url":"https://api.github.com/users/mit-crpg/received_events","type":"Organization","site_admin":false},"repo":{"id":2081118,"name":"openmc","full_name":"mit-crpg/openmc","owner":{"login":"mit-crpg","id":1247634,"avatar_url":"https://avatars.githubusercontent.com/u/1247634?v=3","gravatar_id":"","url":"https://api.github.com/users/mit-crpg","html_url":"https://github.com/mit-crpg","followers_url":"https://api.github.com/users/mit-crpg/followers","following_url":"https://api.github.com/users/mit-crpg/following{/other_user}","gists_url":"https://api.github.com/users/mit-crpg/gists{/gist_id}","starred_url":"https://api.github.com/users/mit-crpg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mit-crpg/subscriptions","organizations_url":"https://api.github.com/users/mit-crpg/orgs","repos_url":"https://api.github.com/users/mit-crpg/repos","events_url":"https://api.github.com/users/mit-crpg/events{/privacy}","received_events_url":"https://api.github.com/users/mit-crpg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mit-crpg/openmc","description":"OpenMC Monte Carlo Code","fork":false,"url":"https://api.github.com/repos/mit-crpg/openmc","forks_url":"https://api.github.com/repos/mit-crpg/openmc/forks","keys_url":"https://api.github.com/repos/mit-crpg/openmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mit-crpg/openmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mit-crpg/openmc/teams","hooks_url":"https://api.github.com/repos/mit-crpg/openmc/hooks","issue_events_url":"https://api.github.com/repos/mit-crpg/openmc/issues/events{/number}","events_url":"https://api.github.com/repos/mit-crpg/openmc/events","assignees_url":"https://api.github.com/repos/mit-crpg/openmc/assignees{/user}","branches_url":"https://api.github.com/repos/mit-crpg/openmc/branches{/branch}","tags_url":"https://api.github.com/repos/mit-crpg/openmc/tags","blobs_url":"https://api.github.com/repos/mit-crpg/openmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mit-crpg/openmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mit-crpg/openmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/mit-crpg/openmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mit-crpg/openmc/statuses/{sha}","languages_url":"https://api.github.com/repos/mit-crpg/openmc/languages","stargazers_url":"https://api.github.com/repos/mit-crpg/openmc/stargazers","contributors_url":"https://api.github.com/repos/mit-crpg/openmc/contributors","subscribers_url":"https://api.github.com/repos/mit-crpg/openmc/subscribers","subscription_url":"https://api.github.com/repos/mit-crpg/openmc/subscription","commits_url":"https://api.github.com/repos/mit-crpg/openmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/mit-crpg/openmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/mit-crpg/openmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/mit-crpg/openmc/issues/comments/{number}","contents_url":"https://api.github.com/repos/mit-crpg/openmc/contents/{+path}","compare_url":"https://api.github.com/repos/mit-crpg/openmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mit-crpg/openmc/merges","archive_url":"https://api.github.com/repos/mit-crpg/openmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mit-crpg/openmc/downloads","issues_url":"https://api.github.com/repos/mit-crpg/openmc/issues{/number}","pulls_url":"https://api.github.com/repos/mit-crpg/openmc/pulls{/number}","milestones_url":"https://api.github.com/repos/mit-crpg/openmc/milestones{/number}","notifications_url":"https://api.github.com/repos/mit-crpg/openmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mit-crpg/openmc/labels{/name}","releases_url":"https://api.github.com/repos/mit-crpg/openmc/releases{/id}","created_at":"2011-07-21T00:33:27Z","updated_at":"2015-02-11T04:21:41Z","pushed_at":"2015-02-11T04:51:29Z","git_url":"git://github.com/mit-crpg/openmc.git","ssh_url":"git@github.com:mit-crpg/openmc.git","clone_url":"https://github.com/mit-crpg/openmc.git","svn_url":"https://github.com/mit-crpg/openmc","homepage":"http://mit-crpg.github.io/openmc/","size":30618,"stargazers_count":47,"watchers_count":47,"language":"FORTRAN","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":65,"mirror_url":null,"open_issues_count":49,"forks":65,"open_issues":49,"watchers":47,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/mit-crpg/openmc/pulls/359"},"html":{"href":"https://github.com/mit-crpg/openmc/pull/359"},"issue":{"href":"https://api.github.com/repos/mit-crpg/openmc/issues/359"},"comments":{"href":"https://api.github.com/repos/mit-crpg/openmc/issues/359/comments"},"review_comments":{"href":"https://api.github.com/repos/mit-crpg/openmc/pulls/359/comments"},"review_comment":{"href":"https://api.github.com/repos/mit-crpg/openmc/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mit-crpg/openmc/pulls/359/commits"},"statuses":{"href":"https://api.github.com/repos/mit-crpg/openmc/statuses/eaa149b7ad04abf2a4a3d8b7a4a277ae3ccd5b65"}}}}