{"action":"created","issue":{"url":"https://api.github.com/repos/hadley/devtools/issues/723","labels_url":"https://api.github.com/repos/hadley/devtools/issues/723/labels{/name}","comments_url":"https://api.github.com/repos/hadley/devtools/issues/723/comments","events_url":"https://api.github.com/repos/hadley/devtools/issues/723/events","html_url":"https://github.com/hadley/devtools/issues/723","id":58577018,"number":723,"title":"load_all should not touch the DESCRIPTION file with roxygen2::update_collate","user":{"login":"renozao","id":1070589,"avatar_url":"https://avatars.githubusercontent.com/u/1070589?v=3","gravatar_id":"","url":"https://api.github.com/users/renozao","html_url":"https://github.com/renozao","followers_url":"https://api.github.com/users/renozao/followers","following_url":"https://api.github.com/users/renozao/following{/other_user}","gists_url":"https://api.github.com/users/renozao/gists{/gist_id}","starred_url":"https://api.github.com/users/renozao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/renozao/subscriptions","organizations_url":"https://api.github.com/users/renozao/orgs","repos_url":"https://api.github.com/users/renozao/repos","events_url":"https://api.github.com/users/renozao/events{/privacy}","received_events_url":"https://api.github.com/users/renozao/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-02-23T12:01:03Z","updated_at":"2015-02-23T19:03:03Z","closed_at":null,"body":"Hi,\r\n\r\nthe recent change in ``load_all`` using ``update_collate``  (PR #649) has a deep impact when loading the package on parallel jobs, has it simply creates a massively invalid ``DESCRIPTION`` file, with each job writing bits of the file in random places.\r\n\r\nMore generally, I think ``load_all`` should not touch any of the package files: it is meant to load the package as is, and by all means should honor what the user wrote in the DESCRIPTION file, even if it is incorrect.\r\n\r\nIf collate order must be updated, the user can call ``collate_update``, and may be suggested to do so if a computed collate order is not as in the original file.\r\n\r\nI would really stick to the rule: ``load_all`` emulates what library does, i.e., **read/load** package files without trying to fix things, roxygen2 helps **writing/generating** package files.\r\n\r\nThank you.\r\n"},"comment":{"url":"https://api.github.com/repos/hadley/devtools/issues/comments/75608369","html_url":"https://github.com/hadley/devtools/issues/723#issuecomment-75608369","issue_url":"https://api.github.com/repos/hadley/devtools/issues/723","id":75608369,"user":{"login":"Geoff99","id":8340230,"avatar_url":"https://avatars.githubusercontent.com/u/8340230?v=3","gravatar_id":"","url":"https://api.github.com/users/Geoff99","html_url":"https://github.com/Geoff99","followers_url":"https://api.github.com/users/Geoff99/followers","following_url":"https://api.github.com/users/Geoff99/following{/other_user}","gists_url":"https://api.github.com/users/Geoff99/gists{/gist_id}","starred_url":"https://api.github.com/users/Geoff99/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Geoff99/subscriptions","organizations_url":"https://api.github.com/users/Geoff99/orgs","repos_url":"https://api.github.com/users/Geoff99/repos","events_url":"https://api.github.com/users/Geoff99/events{/privacy}","received_events_url":"https://api.github.com/users/Geoff99/received_events","type":"User","site_admin":false},"created_at":"2015-02-23T19:03:03Z","updated_at":"2015-02-23T19:03:03Z","body":"Thanks.  I'll have to think a bit.\r\n \r\nThe problem I was having is that underneath the hood, `document` uses `load_all` --- it needs to source the R code, or (as `load_all` does) load the result of running it into an environment / namespace, so that roxygen2  has the information it needs about the package when running the roclets.  And if the Collate order in the DESCRIPTION file was wrong, then `load_all` didn't work, so `document` didn't work, so `load_all` didn't work, so ...\r\n\r\nI was enormously confused when it first happened to me because I resorted to commenting out new bits of my code to try and track down the error - at some stage `document` would suddenly work - which would fix the collate entry (which I didn't realise) - once my code was working I removed the comments, one by one, and then got all the way back to my original code - which suddenly was fine :-(\r\n\r\n'nuff of my issue, I'll have a think about your problem."}}