{"action":"closed","number":213,"pull_request":{"url":"https://api.github.com/repos/snoyberg/conduit/pulls/213","id":35185284,"html_url":"https://github.com/snoyberg/conduit/pull/213","diff_url":"https://github.com/snoyberg/conduit/pull/213.diff","patch_url":"https://github.com/snoyberg/conduit/pull/213.patch","issue_url":"https://api.github.com/repos/snoyberg/conduit/issues/213","number":213,"state":"closed","locked":false,"title":"Adding buffer size to sourceHandleRange","user":{"login":"nhibberd","id":447873,"avatar_url":"https://avatars.githubusercontent.com/u/447873?v=3","gravatar_id":"","url":"https://api.github.com/users/nhibberd","html_url":"https://github.com/nhibberd","followers_url":"https://api.github.com/users/nhibberd/followers","following_url":"https://api.github.com/users/nhibberd/following{/other_user}","gists_url":"https://api.github.com/users/nhibberd/gists{/gist_id}","starred_url":"https://api.github.com/users/nhibberd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nhibberd/subscriptions","organizations_url":"https://api.github.com/users/nhibberd/orgs","repos_url":"https://api.github.com/users/nhibberd/repos","events_url":"https://api.github.com/users/nhibberd/events{/privacy}","received_events_url":"https://api.github.com/users/nhibberd/received_events","type":"User","site_admin":false},"body":"We're reading from disk and uploading parts of files using http-conduit and we've observed that the buffer size has significant impact on performance. On certain machines going from a 4k buffer to a 1mb buffer results in a 4x speed up.\r\n\r\nNot 100% on the signature that you would prefer, this lets us achieve what we need. If you would like it in a slightly different form just let me know.","created_at":"2015-05-12T01:13:18Z","updated_at":"2015-05-12T07:09:10Z","closed_at":"2015-05-12T07:09:10Z","merged_at":"2015-05-12T07:09:10Z","merge_commit_sha":"bdf20b63712b5c51dcc3f3c9f8fefd2c4732b646","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/snoyberg/conduit/pulls/213/commits","review_comments_url":"https://api.github.com/repos/snoyberg/conduit/pulls/213/comments","review_comment_url":"https://api.github.com/repos/snoyberg/conduit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/snoyberg/conduit/issues/213/comments","statuses_url":"https://api.github.com/repos/snoyberg/conduit/statuses/4addec73d6de45bd2741785479545280f6ef3fbb","head":{"label":"nhibberd:buffer","ref":"buffer","sha":"4addec73d6de45bd2741785479545280f6ef3fbb","user":{"login":"nhibberd","id":447873,"avatar_url":"https://avatars.githubusercontent.com/u/447873?v=3","gravatar_id":"","url":"https://api.github.com/users/nhibberd","html_url":"https://github.com/nhibberd","followers_url":"https://api.github.com/users/nhibberd/followers","following_url":"https://api.github.com/users/nhibberd/following{/other_user}","gists_url":"https://api.github.com/users/nhibberd/gists{/gist_id}","starred_url":"https://api.github.com/users/nhibberd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nhibberd/subscriptions","organizations_url":"https://api.github.com/users/nhibberd/orgs","repos_url":"https://api.github.com/users/nhibberd/repos","events_url":"https://api.github.com/users/nhibberd/events{/privacy}","received_events_url":"https://api.github.com/users/nhibberd/received_events","type":"User","site_admin":false},"repo":{"id":35458032,"name":"conduit","full_name":"nhibberd/conduit","owner":{"login":"nhibberd","id":447873,"avatar_url":"https://avatars.githubusercontent.com/u/447873?v=3","gravatar_id":"","url":"https://api.github.com/users/nhibberd","html_url":"https://github.com/nhibberd","followers_url":"https://api.github.com/users/nhibberd/followers","following_url":"https://api.github.com/users/nhibberd/following{/other_user}","gists_url":"https://api.github.com/users/nhibberd/gists{/gist_id}","starred_url":"https://api.github.com/users/nhibberd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nhibberd/subscriptions","organizations_url":"https://api.github.com/users/nhibberd/orgs","repos_url":"https://api.github.com/users/nhibberd/repos","events_url":"https://api.github.com/users/nhibberd/events{/privacy}","received_events_url":"https://api.github.com/users/nhibberd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nhibberd/conduit","description":"A streaming data library","fork":true,"url":"https://api.github.com/repos/nhibberd/conduit","forks_url":"https://api.github.com/repos/nhibberd/conduit/forks","keys_url":"https://api.github.com/repos/nhibberd/conduit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nhibberd/conduit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nhibberd/conduit/teams","hooks_url":"https://api.github.com/repos/nhibberd/conduit/hooks","issue_events_url":"https://api.github.com/repos/nhibberd/conduit/issues/events{/number}","events_url":"https://api.github.com/repos/nhibberd/conduit/events","assignees_url":"https://api.github.com/repos/nhibberd/conduit/assignees{/user}","branches_url":"https://api.github.com/repos/nhibberd/conduit/branches{/branch}","tags_url":"https://api.github.com/repos/nhibberd/conduit/tags","blobs_url":"https://api.github.com/repos/nhibberd/conduit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nhibberd/conduit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nhibberd/conduit/git/refs{/sha}","trees_url":"https://api.github.com/repos/nhibberd/conduit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nhibberd/conduit/statuses/{sha}","languages_url":"https://api.github.com/repos/nhibberd/conduit/languages","stargazers_url":"https://api.github.com/repos/nhibberd/conduit/stargazers","contributors_url":"https://api.github.com/repos/nhibberd/conduit/contributors","subscribers_url":"https://api.github.com/repos/nhibberd/conduit/subscribers","subscription_url":"https://api.github.com/repos/nhibberd/conduit/subscription","commits_url":"https://api.github.com/repos/nhibberd/conduit/commits{/sha}","git_commits_url":"https://api.github.com/repos/nhibberd/conduit/git/commits{/sha}","comments_url":"https://api.github.com/repos/nhibberd/conduit/comments{/number}","issue_comment_url":"https://api.github.com/repos/nhibberd/conduit/issues/comments{/number}","contents_url":"https://api.github.com/repos/nhibberd/conduit/contents/{+path}","compare_url":"https://api.github.com/repos/nhibberd/conduit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nhibberd/conduit/merges","archive_url":"https://api.github.com/repos/nhibberd/conduit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nhibberd/conduit/downloads","issues_url":"https://api.github.com/repos/nhibberd/conduit/issues{/number}","pulls_url":"https://api.github.com/repos/nhibberd/conduit/pulls{/number}","milestones_url":"https://api.github.com/repos/nhibberd/conduit/milestones{/number}","notifications_url":"https://api.github.com/repos/nhibberd/conduit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nhibberd/conduit/labels{/name}","releases_url":"https://api.github.com/repos/nhibberd/conduit/releases{/id}","created_at":"2015-05-12T00:44:15Z","updated_at":"2015-05-12T00:44:16Z","pushed_at":"2015-05-12T01:07:32Z","git_url":"git://github.com/nhibberd/conduit.git","ssh_url":"git@github.com:nhibberd/conduit.git","clone_url":"https://github.com/nhibberd/conduit.git","svn_url":"https://github.com/nhibberd/conduit","homepage":"","size":5613,"stargazers_count":0,"watchers_count":0,"language":"Haskell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"snoyberg:master","ref":"master","sha":"5aa93ba68711b61b567efd3e196bfadce214530d","user":{"login":"snoyberg","id":49415,"avatar_url":"https://avatars.githubusercontent.com/u/49415?v=3","gravatar_id":"","url":"https://api.github.com/users/snoyberg","html_url":"https://github.com/snoyberg","followers_url":"https://api.github.com/users/snoyberg/followers","following_url":"https://api.github.com/users/snoyberg/following{/other_user}","gists_url":"https://api.github.com/users/snoyberg/gists{/gist_id}","starred_url":"https://api.github.com/users/snoyberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snoyberg/subscriptions","organizations_url":"https://api.github.com/users/snoyberg/orgs","repos_url":"https://api.github.com/users/snoyberg/repos","events_url":"https://api.github.com/users/snoyberg/events{/privacy}","received_events_url":"https://api.github.com/users/snoyberg/received_events","type":"User","site_admin":false},"repo":{"id":2956839,"name":"conduit","full_name":"snoyberg/conduit","owner":{"login":"snoyberg","id":49415,"avatar_url":"https://avatars.githubusercontent.com/u/49415?v=3","gravatar_id":"","url":"https://api.github.com/users/snoyberg","html_url":"https://github.com/snoyberg","followers_url":"https://api.github.com/users/snoyberg/followers","following_url":"https://api.github.com/users/snoyberg/following{/other_user}","gists_url":"https://api.github.com/users/snoyberg/gists{/gist_id}","starred_url":"https://api.github.com/users/snoyberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snoyberg/subscriptions","organizations_url":"https://api.github.com/users/snoyberg/orgs","repos_url":"https://api.github.com/users/snoyberg/repos","events_url":"https://api.github.com/users/snoyberg/events{/privacy}","received_events_url":"https://api.github.com/users/snoyberg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/snoyberg/conduit","description":"A streaming data library","fork":false,"url":"https://api.github.com/repos/snoyberg/conduit","forks_url":"https://api.github.com/repos/snoyberg/conduit/forks","keys_url":"https://api.github.com/repos/snoyberg/conduit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/snoyberg/conduit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/snoyberg/conduit/teams","hooks_url":"https://api.github.com/repos/snoyberg/conduit/hooks","issue_events_url":"https://api.github.com/repos/snoyberg/conduit/issues/events{/number}","events_url":"https://api.github.com/repos/snoyberg/conduit/events","assignees_url":"https://api.github.com/repos/snoyberg/conduit/assignees{/user}","branches_url":"https://api.github.com/repos/snoyberg/conduit/branches{/branch}","tags_url":"https://api.github.com/repos/snoyberg/conduit/tags","blobs_url":"https://api.github.com/repos/snoyberg/conduit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/snoyberg/conduit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/snoyberg/conduit/git/refs{/sha}","trees_url":"https://api.github.com/repos/snoyberg/conduit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/snoyberg/conduit/statuses/{sha}","languages_url":"https://api.github.com/repos/snoyberg/conduit/languages","stargazers_url":"https://api.github.com/repos/snoyberg/conduit/stargazers","contributors_url":"https://api.github.com/repos/snoyberg/conduit/contributors","subscribers_url":"https://api.github.com/repos/snoyberg/conduit/subscribers","subscription_url":"https://api.github.com/repos/snoyberg/conduit/subscription","commits_url":"https://api.github.com/repos/snoyberg/conduit/commits{/sha}","git_commits_url":"https://api.github.com/repos/snoyberg/conduit/git/commits{/sha}","comments_url":"https://api.github.com/repos/snoyberg/conduit/comments{/number}","issue_comment_url":"https://api.github.com/repos/snoyberg/conduit/issues/comments{/number}","contents_url":"https://api.github.com/repos/snoyberg/conduit/contents/{+path}","compare_url":"https://api.github.com/repos/snoyberg/conduit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/snoyberg/conduit/merges","archive_url":"https://api.github.com/repos/snoyberg/conduit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/snoyberg/conduit/downloads","issues_url":"https://api.github.com/repos/snoyberg/conduit/issues{/number}","pulls_url":"https://api.github.com/repos/snoyberg/conduit/pulls{/number}","milestones_url":"https://api.github.com/repos/snoyberg/conduit/milestones{/number}","notifications_url":"https://api.github.com/repos/snoyberg/conduit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/snoyberg/conduit/labels{/name}","releases_url":"https://api.github.com/repos/snoyberg/conduit/releases{/id}","created_at":"2011-12-11T04:55:45Z","updated_at":"2015-05-02T18:02:10Z","pushed_at":"2015-05-12T07:09:10Z","git_url":"git://github.com/snoyberg/conduit.git","ssh_url":"git@github.com:snoyberg/conduit.git","clone_url":"https://github.com/snoyberg/conduit.git","svn_url":"https://github.com/snoyberg/conduit","homepage":"","size":5613,"stargazers_count":217,"watchers_count":217,"language":"Haskell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":77,"mirror_url":null,"open_issues_count":12,"forks":77,"open_issues":12,"watchers":217,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/snoyberg/conduit/pulls/213"},"html":{"href":"https://github.com/snoyberg/conduit/pull/213"},"issue":{"href":"https://api.github.com/repos/snoyberg/conduit/issues/213"},"comments":{"href":"https://api.github.com/repos/snoyberg/conduit/issues/213/comments"},"review_comments":{"href":"https://api.github.com/repos/snoyberg/conduit/pulls/213/comments"},"review_comment":{"href":"https://api.github.com/repos/snoyberg/conduit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/snoyberg/conduit/pulls/213/commits"},"statuses":{"href":"https://api.github.com/repos/snoyberg/conduit/statuses/4addec73d6de45bd2741785479545280f6ef3fbb"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"snoyberg","id":49415,"avatar_url":"https://avatars.githubusercontent.com/u/49415?v=3","gravatar_id":"","url":"https://api.github.com/users/snoyberg","html_url":"https://github.com/snoyberg","followers_url":"https://api.github.com/users/snoyberg/followers","following_url":"https://api.github.com/users/snoyberg/following{/other_user}","gists_url":"https://api.github.com/users/snoyberg/gists{/gist_id}","starred_url":"https://api.github.com/users/snoyberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snoyberg/subscriptions","organizations_url":"https://api.github.com/users/snoyberg/orgs","repos_url":"https://api.github.com/users/snoyberg/repos","events_url":"https://api.github.com/users/snoyberg/events{/privacy}","received_events_url":"https://api.github.com/users/snoyberg/received_events","type":"User","site_admin":false},"comments":0,"review_comments":1,"commits":1,"additions":17,"deletions":3,"changed_files":1}}