{"action":"closed","number":329,"pull_request":{"url":"https://api.github.com/repos/linkedin/naarad/pulls/329","id":32736526,"html_url":"https://github.com/linkedin/naarad/pull/329","diff_url":"https://github.com/linkedin/naarad/pull/329.diff","patch_url":"https://github.com/linkedin/naarad/pull/329.patch","issue_url":"https://api.github.com/repos/linkedin/naarad/issues/329","number":329,"state":"closed","locked":false,"title":"Fix per Zen's suggestion: disable aggregation in default","user":{"login":"feng-tao","id":3223098,"avatar_url":"https://avatars.githubusercontent.com/u/3223098?v=3","gravatar_id":"","url":"https://api.github.com/users/feng-tao","html_url":"https://github.com/feng-tao","followers_url":"https://api.github.com/users/feng-tao/followers","following_url":"https://api.github.com/users/feng-tao/following{/other_user}","gists_url":"https://api.github.com/users/feng-tao/gists{/gist_id}","starred_url":"https://api.github.com/users/feng-tao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feng-tao/subscriptions","organizations_url":"https://api.github.com/users/feng-tao/orgs","repos_url":"https://api.github.com/users/feng-tao/repos","events_url":"https://api.github.com/users/feng-tao/events{/privacy}","received_events_url":"https://api.github.com/users/feng-tao/received_events","type":"User","site_admin":false},"body":"In current Naarad, there is a bug in the code that even if user wants to aggregate metric in \"minute\" or \"hour\", the code wont pick up this option. And it aggregate value in \"second\" per default.  Per Zen's suggestion, if we have sub-second value, the code will only print out the average value.\r\n\r\nThis pull request disable this per-second aggregation unless user specify \"aggr_metrics=second/minute/hour\" in metric section. I try the fix which works on the config provided by Zen. ","created_at":"2015-04-07T06:23:07Z","updated_at":"2015-06-04T20:20:58Z","closed_at":"2015-06-04T20:20:58Z","merged_at":"2015-06-04T20:20:58Z","merge_commit_sha":"4267df7f16a91281d80e391961ecc71e79dbc585","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/linkedin/naarad/pulls/329/commits","review_comments_url":"https://api.github.com/repos/linkedin/naarad/pulls/329/comments","review_comment_url":"https://api.github.com/repos/linkedin/naarad/pulls/comments{/number}","comments_url":"https://api.github.com/repos/linkedin/naarad/issues/329/comments","statuses_url":"https://api.github.com/repos/linkedin/naarad/statuses/bde15279620964e1107f0221e9b5e1a066aa3f56","head":{"label":"feng-tao:bug_default_disable_aggr","ref":"bug_default_disable_aggr","sha":"bde15279620964e1107f0221e9b5e1a066aa3f56","user":{"login":"feng-tao","id":3223098,"avatar_url":"https://avatars.githubusercontent.com/u/3223098?v=3","gravatar_id":"","url":"https://api.github.com/users/feng-tao","html_url":"https://github.com/feng-tao","followers_url":"https://api.github.com/users/feng-tao/followers","following_url":"https://api.github.com/users/feng-tao/following{/other_user}","gists_url":"https://api.github.com/users/feng-tao/gists{/gist_id}","starred_url":"https://api.github.com/users/feng-tao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feng-tao/subscriptions","organizations_url":"https://api.github.com/users/feng-tao/orgs","repos_url":"https://api.github.com/users/feng-tao/repos","events_url":"https://api.github.com/users/feng-tao/events{/privacy}","received_events_url":"https://api.github.com/users/feng-tao/received_events","type":"User","site_admin":false},"repo":{"id":32831460,"name":"naarad","full_name":"feng-tao/naarad","owner":{"login":"feng-tao","id":3223098,"avatar_url":"https://avatars.githubusercontent.com/u/3223098?v=3","gravatar_id":"","url":"https://api.github.com/users/feng-tao","html_url":"https://github.com/feng-tao","followers_url":"https://api.github.com/users/feng-tao/followers","following_url":"https://api.github.com/users/feng-tao/following{/other_user}","gists_url":"https://api.github.com/users/feng-tao/gists{/gist_id}","starred_url":"https://api.github.com/users/feng-tao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feng-tao/subscriptions","organizations_url":"https://api.github.com/users/feng-tao/orgs","repos_url":"https://api.github.com/users/feng-tao/repos","events_url":"https://api.github.com/users/feng-tao/events{/privacy}","received_events_url":"https://api.github.com/users/feng-tao/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/feng-tao/naarad","description":"Naarad is a highly configurable system analysis tool that parses and plots timeseries data for better visual correlation. Naarad was built to help in performance analysis and investigations.","fork":true,"url":"https://api.github.com/repos/feng-tao/naarad","forks_url":"https://api.github.com/repos/feng-tao/naarad/forks","keys_url":"https://api.github.com/repos/feng-tao/naarad/keys{/key_id}","collaborators_url":"https://api.github.com/repos/feng-tao/naarad/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/feng-tao/naarad/teams","hooks_url":"https://api.github.com/repos/feng-tao/naarad/hooks","issue_events_url":"https://api.github.com/repos/feng-tao/naarad/issues/events{/number}","events_url":"https://api.github.com/repos/feng-tao/naarad/events","assignees_url":"https://api.github.com/repos/feng-tao/naarad/assignees{/user}","branches_url":"https://api.github.com/repos/feng-tao/naarad/branches{/branch}","tags_url":"https://api.github.com/repos/feng-tao/naarad/tags","blobs_url":"https://api.github.com/repos/feng-tao/naarad/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/feng-tao/naarad/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/feng-tao/naarad/git/refs{/sha}","trees_url":"https://api.github.com/repos/feng-tao/naarad/git/trees{/sha}","statuses_url":"https://api.github.com/repos/feng-tao/naarad/statuses/{sha}","languages_url":"https://api.github.com/repos/feng-tao/naarad/languages","stargazers_url":"https://api.github.com/repos/feng-tao/naarad/stargazers","contributors_url":"https://api.github.com/repos/feng-tao/naarad/contributors","subscribers_url":"https://api.github.com/repos/feng-tao/naarad/subscribers","subscription_url":"https://api.github.com/repos/feng-tao/naarad/subscription","commits_url":"https://api.github.com/repos/feng-tao/naarad/commits{/sha}","git_commits_url":"https://api.github.com/repos/feng-tao/naarad/git/commits{/sha}","comments_url":"https://api.github.com/repos/feng-tao/naarad/comments{/number}","issue_comment_url":"https://api.github.com/repos/feng-tao/naarad/issues/comments{/number}","contents_url":"https://api.github.com/repos/feng-tao/naarad/contents/{+path}","compare_url":"https://api.github.com/repos/feng-tao/naarad/compare/{base}...{head}","merges_url":"https://api.github.com/repos/feng-tao/naarad/merges","archive_url":"https://api.github.com/repos/feng-tao/naarad/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/feng-tao/naarad/downloads","issues_url":"https://api.github.com/repos/feng-tao/naarad/issues{/number}","pulls_url":"https://api.github.com/repos/feng-tao/naarad/pulls{/number}","milestones_url":"https://api.github.com/repos/feng-tao/naarad/milestones{/number}","notifications_url":"https://api.github.com/repos/feng-tao/naarad/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/feng-tao/naarad/labels{/name}","releases_url":"https://api.github.com/repos/feng-tao/naarad/releases{/id}","created_at":"2015-03-24T23:40:08Z","updated_at":"2015-04-07T18:17:26Z","pushed_at":"2015-04-10T21:07:40Z","git_url":"git://github.com/feng-tao/naarad.git","ssh_url":"git@github.com:feng-tao/naarad.git","clone_url":"https://github.com/feng-tao/naarad.git","svn_url":"https://github.com/feng-tao/naarad","homepage":"","size":25631,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"linkedin:master","ref":"master","sha":"6bdf4a882a55ea24024f63f7fbbd985957f2f05b","user":{"login":"linkedin","id":357098,"avatar_url":"https://avatars.githubusercontent.com/u/357098?v=3","gravatar_id":"","url":"https://api.github.com/users/linkedin","html_url":"https://github.com/linkedin","followers_url":"https://api.github.com/users/linkedin/followers","following_url":"https://api.github.com/users/linkedin/following{/other_user}","gists_url":"https://api.github.com/users/linkedin/gists{/gist_id}","starred_url":"https://api.github.com/users/linkedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkedin/subscriptions","organizations_url":"https://api.github.com/users/linkedin/orgs","repos_url":"https://api.github.com/users/linkedin/repos","events_url":"https://api.github.com/users/linkedin/events{/privacy}","received_events_url":"https://api.github.com/users/linkedin/received_events","type":"Organization","site_admin":false},"repo":{"id":14056753,"name":"naarad","full_name":"linkedin/naarad","owner":{"login":"linkedin","id":357098,"avatar_url":"https://avatars.githubusercontent.com/u/357098?v=3","gravatar_id":"","url":"https://api.github.com/users/linkedin","html_url":"https://github.com/linkedin","followers_url":"https://api.github.com/users/linkedin/followers","following_url":"https://api.github.com/users/linkedin/following{/other_user}","gists_url":"https://api.github.com/users/linkedin/gists{/gist_id}","starred_url":"https://api.github.com/users/linkedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkedin/subscriptions","organizations_url":"https://api.github.com/users/linkedin/orgs","repos_url":"https://api.github.com/users/linkedin/repos","events_url":"https://api.github.com/users/linkedin/events{/privacy}","received_events_url":"https://api.github.com/users/linkedin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/linkedin/naarad","description":"Naarad is a highly configurable system analysis tool that parses and plots timeseries data for better visual correlation. Naarad was built to help in performance analysis and investigations.","fork":false,"url":"https://api.github.com/repos/linkedin/naarad","forks_url":"https://api.github.com/repos/linkedin/naarad/forks","keys_url":"https://api.github.com/repos/linkedin/naarad/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linkedin/naarad/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linkedin/naarad/teams","hooks_url":"https://api.github.com/repos/linkedin/naarad/hooks","issue_events_url":"https://api.github.com/repos/linkedin/naarad/issues/events{/number}","events_url":"https://api.github.com/repos/linkedin/naarad/events","assignees_url":"https://api.github.com/repos/linkedin/naarad/assignees{/user}","branches_url":"https://api.github.com/repos/linkedin/naarad/branches{/branch}","tags_url":"https://api.github.com/repos/linkedin/naarad/tags","blobs_url":"https://api.github.com/repos/linkedin/naarad/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linkedin/naarad/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linkedin/naarad/git/refs{/sha}","trees_url":"https://api.github.com/repos/linkedin/naarad/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linkedin/naarad/statuses/{sha}","languages_url":"https://api.github.com/repos/linkedin/naarad/languages","stargazers_url":"https://api.github.com/repos/linkedin/naarad/stargazers","contributors_url":"https://api.github.com/repos/linkedin/naarad/contributors","subscribers_url":"https://api.github.com/repos/linkedin/naarad/subscribers","subscription_url":"https://api.github.com/repos/linkedin/naarad/subscription","commits_url":"https://api.github.com/repos/linkedin/naarad/commits{/sha}","git_commits_url":"https://api.github.com/repos/linkedin/naarad/git/commits{/sha}","comments_url":"https://api.github.com/repos/linkedin/naarad/comments{/number}","issue_comment_url":"https://api.github.com/repos/linkedin/naarad/issues/comments{/number}","contents_url":"https://api.github.com/repos/linkedin/naarad/contents/{+path}","compare_url":"https://api.github.com/repos/linkedin/naarad/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linkedin/naarad/merges","archive_url":"https://api.github.com/repos/linkedin/naarad/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linkedin/naarad/downloads","issues_url":"https://api.github.com/repos/linkedin/naarad/issues{/number}","pulls_url":"https://api.github.com/repos/linkedin/naarad/pulls{/number}","milestones_url":"https://api.github.com/repos/linkedin/naarad/milestones{/number}","notifications_url":"https://api.github.com/repos/linkedin/naarad/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linkedin/naarad/labels{/name}","releases_url":"https://api.github.com/repos/linkedin/naarad/releases{/id}","created_at":"2013-11-01T23:34:54Z","updated_at":"2015-06-04T03:57:07Z","pushed_at":"2015-06-04T20:20:58Z","git_url":"git://github.com/linkedin/naarad.git","ssh_url":"git@github.com:linkedin/naarad.git","clone_url":"https://github.com/linkedin/naarad.git","svn_url":"https://github.com/linkedin/naarad","homepage":"","size":25701,"stargazers_count":99,"watchers_count":99,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":32,"mirror_url":null,"open_issues_count":56,"forks":32,"open_issues":56,"watchers":99,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/linkedin/naarad/pulls/329"},"html":{"href":"https://github.com/linkedin/naarad/pull/329"},"issue":{"href":"https://api.github.com/repos/linkedin/naarad/issues/329"},"comments":{"href":"https://api.github.com/repos/linkedin/naarad/issues/329/comments"},"review_comments":{"href":"https://api.github.com/repos/linkedin/naarad/pulls/329/comments"},"review_comment":{"href":"https://api.github.com/repos/linkedin/naarad/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/linkedin/naarad/pulls/329/commits"},"statuses":{"href":"https://api.github.com/repos/linkedin/naarad/statuses/bde15279620964e1107f0221e9b5e1a066aa3f56"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"richardhsu","id":906880,"avatar_url":"https://avatars.githubusercontent.com/u/906880?v=3","gravatar_id":"","url":"https://api.github.com/users/richardhsu","html_url":"https://github.com/richardhsu","followers_url":"https://api.github.com/users/richardhsu/followers","following_url":"https://api.github.com/users/richardhsu/following{/other_user}","gists_url":"https://api.github.com/users/richardhsu/gists{/gist_id}","starred_url":"https://api.github.com/users/richardhsu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardhsu/subscriptions","organizations_url":"https://api.github.com/users/richardhsu/orgs","repos_url":"https://api.github.com/users/richardhsu/repos","events_url":"https://api.github.com/users/richardhsu/events{/privacy}","received_events_url":"https://api.github.com/users/richardhsu/received_events","type":"User","site_admin":false},"comments":9,"review_comments":1,"commits":8,"additions":37,"deletions":37,"changed_files":14}}