{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/olympia/pulls/comments/30214957","id":30214957,"diff_hunk":"@@ -27,7 +27,8 @@ class SigningError(Exception):\n def get_endpoint(file_obj):\n     \"\"\"Get the endpoint to sign the file, depending on its review status.\"\"\"\n     server = settings.SIGNING_SERVER\n-    if file_obj.version.addon.status != amo.STATUS_PUBLIC:\n+    if (file_obj.status == amo.STATUS_BETA or\n+            file_obj.version.addon.status != amo.STATUS_PUBLIC):","path":"lib/crypto/packaged.py","position":6,"original_position":6,"commit_id":"fd0bf1cc53b3c552bb10274ec1e7e6272090d55b","original_commit_id":"fd0bf1cc53b3c552bb10274ec1e7e6272090d55b","user":{"login":"magopian","id":167767,"avatar_url":"https://avatars.githubusercontent.com/u/167767?v=3","gravatar_id":"","url":"https://api.github.com/users/magopian","html_url":"https://github.com/magopian","followers_url":"https://api.github.com/users/magopian/followers","following_url":"https://api.github.com/users/magopian/following{/other_user}","gists_url":"https://api.github.com/users/magopian/gists{/gist_id}","starred_url":"https://api.github.com/users/magopian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magopian/subscriptions","organizations_url":"https://api.github.com/users/magopian/orgs","repos_url":"https://api.github.com/users/magopian/repos","events_url":"https://api.github.com/users/magopian/events{/privacy}","received_events_url":"https://api.github.com/users/magopian/received_events","type":"User","site_admin":false},"body":"This will change as soon as I merge #524, and will need some rebasing in this PR","created_at":"2015-05-13T09:25:41Z","updated_at":"2015-05-13T09:25:41Z","html_url":"https://github.com/mozilla/olympia/pull/555#discussion_r30214957","pull_request_url":"https://api.github.com/repos/mozilla/olympia/pulls/555","_links":{"self":{"href":"https://api.github.com/repos/mozilla/olympia/pulls/comments/30214957"},"html":{"href":"https://github.com/mozilla/olympia/pull/555#discussion_r30214957"},"pull_request":{"href":"https://api.github.com/repos/mozilla/olympia/pulls/555"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/olympia/pulls/555","id":35279187,"html_url":"https://github.com/mozilla/olympia/pull/555","diff_url":"https://github.com/mozilla/olympia/pull/555.diff","patch_url":"https://github.com/mozilla/olympia/pull/555.patch","issue_url":"https://api.github.com/repos/mozilla/olympia/issues/555","number":555,"state":"open","locked":false,"title":"[WIP] Handle new beta versions with signing (bug 1160593)","user":{"login":"robhudson","id":1106,"avatar_url":"https://avatars.githubusercontent.com/u/1106?v=3","gravatar_id":"","url":"https://api.github.com/users/robhudson","html_url":"https://github.com/robhudson","followers_url":"https://api.github.com/users/robhudson/followers","following_url":"https://api.github.com/users/robhudson/following{/other_user}","gists_url":"https://api.github.com/users/robhudson/gists{/gist_id}","starred_url":"https://api.github.com/users/robhudson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robhudson/subscriptions","organizations_url":"https://api.github.com/users/robhudson/orgs","repos_url":"https://api.github.com/users/robhudson/repos","events_url":"https://api.github.com/users/robhudson/events{/privacy}","received_events_url":"https://api.github.com/users/robhudson/received_events","type":"User","site_admin":false},"body":"TODO:\r\n* [ ] Handle toggling of `is_beta` checkbox.\r\n","created_at":"2015-05-12T22:53:29Z","updated_at":"2015-05-13T09:25:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"751fa3b87708135f2d1f8093b37b55e7d743f6d4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/olympia/pulls/555/commits","review_comments_url":"https://api.github.com/repos/mozilla/olympia/pulls/555/comments","review_comment_url":"https://api.github.com/repos/mozilla/olympia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/olympia/issues/555/comments","statuses_url":"https://api.github.com/repos/mozilla/olympia/statuses/fd0bf1cc53b3c552bb10274ec1e7e6272090d55b","head":{"label":"robhudson:1160593-sign-beta-versions","ref":"1160593-sign-beta-versions","sha":"fd0bf1cc53b3c552bb10274ec1e7e6272090d55b","user":{"login":"robhudson","id":1106,"avatar_url":"https://avatars.githubusercontent.com/u/1106?v=3","gravatar_id":"","url":"https://api.github.com/users/robhudson","html_url":"https://github.com/robhudson","followers_url":"https://api.github.com/users/robhudson/followers","following_url":"https://api.github.com/users/robhudson/following{/other_user}","gists_url":"https://api.github.com/users/robhudson/gists{/gist_id}","starred_url":"https://api.github.com/users/robhudson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robhudson/subscriptions","organizations_url":"https://api.github.com/users/robhudson/orgs","repos_url":"https://api.github.com/users/robhudson/repos","events_url":"https://api.github.com/users/robhudson/events{/privacy}","received_events_url":"https://api.github.com/users/robhudson/received_events","type":"User","site_admin":false},"repo":{"id":17037604,"name":"olympia","full_name":"robhudson/olympia","owner":{"login":"robhudson","id":1106,"avatar_url":"https://avatars.githubusercontent.com/u/1106?v=3","gravatar_id":"","url":"https://api.github.com/users/robhudson","html_url":"https://github.com/robhudson","followers_url":"https://api.github.com/users/robhudson/followers","following_url":"https://api.github.com/users/robhudson/following{/other_user}","gists_url":"https://api.github.com/users/robhudson/gists{/gist_id}","starred_url":"https://api.github.com/users/robhudson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robhudson/subscriptions","organizations_url":"https://api.github.com/users/robhudson/orgs","repos_url":"https://api.github.com/users/robhudson/repos","events_url":"https://api.github.com/users/robhudson/events{/privacy}","received_events_url":"https://api.github.com/users/robhudson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/robhudson/olympia","description":"AMO, reloaded.","fork":true,"url":"https://api.github.com/repos/robhudson/olympia","forks_url":"https://api.github.com/repos/robhudson/olympia/forks","keys_url":"https://api.github.com/repos/robhudson/olympia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/robhudson/olympia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/robhudson/olympia/teams","hooks_url":"https://api.github.com/repos/robhudson/olympia/hooks","issue_events_url":"https://api.github.com/repos/robhudson/olympia/issues/events{/number}","events_url":"https://api.github.com/repos/robhudson/olympia/events","assignees_url":"https://api.github.com/repos/robhudson/olympia/assignees{/user}","branches_url":"https://api.github.com/repos/robhudson/olympia/branches{/branch}","tags_url":"https://api.github.com/repos/robhudson/olympia/tags","blobs_url":"https://api.github.com/repos/robhudson/olympia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/robhudson/olympia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/robhudson/olympia/git/refs{/sha}","trees_url":"https://api.github.com/repos/robhudson/olympia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/robhudson/olympia/statuses/{sha}","languages_url":"https://api.github.com/repos/robhudson/olympia/languages","stargazers_url":"https://api.github.com/repos/robhudson/olympia/stargazers","contributors_url":"https://api.github.com/repos/robhudson/olympia/contributors","subscribers_url":"https://api.github.com/repos/robhudson/olympia/subscribers","subscription_url":"https://api.github.com/repos/robhudson/olympia/subscription","commits_url":"https://api.github.com/repos/robhudson/olympia/commits{/sha}","git_commits_url":"https://api.github.com/repos/robhudson/olympia/git/commits{/sha}","comments_url":"https://api.github.com/repos/robhudson/olympia/comments{/number}","issue_comment_url":"https://api.github.com/repos/robhudson/olympia/issues/comments{/number}","contents_url":"https://api.github.com/repos/robhudson/olympia/contents/{+path}","compare_url":"https://api.github.com/repos/robhudson/olympia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/robhudson/olympia/merges","archive_url":"https://api.github.com/repos/robhudson/olympia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/robhudson/olympia/downloads","issues_url":"https://api.github.com/repos/robhudson/olympia/issues{/number}","pulls_url":"https://api.github.com/repos/robhudson/olympia/pulls{/number}","milestones_url":"https://api.github.com/repos/robhudson/olympia/milestones{/number}","notifications_url":"https://api.github.com/repos/robhudson/olympia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/robhudson/olympia/labels{/name}","releases_url":"https://api.github.com/repos/robhudson/olympia/releases{/id}","created_at":"2014-02-20T22:18:23Z","updated_at":"2014-05-07T17:01:02Z","pushed_at":"2015-05-13T00:06:33Z","git_url":"git://github.com/robhudson/olympia.git","ssh_url":"git@github.com:robhudson/olympia.git","clone_url":"https://github.com/robhudson/olympia.git","svn_url":"https://github.com/robhudson/olympia","homepage":"","size":354607,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"ea10b8f61bde5a19114f62be21201fc0175cdba2","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":16416867,"name":"olympia","full_name":"mozilla/olympia","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/olympia","description":"addons.mozilla.org, reloaded.","fork":false,"url":"https://api.github.com/repos/mozilla/olympia","forks_url":"https://api.github.com/repos/mozilla/olympia/forks","keys_url":"https://api.github.com/repos/mozilla/olympia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/olympia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/olympia/teams","hooks_url":"https://api.github.com/repos/mozilla/olympia/hooks","issue_events_url":"https://api.github.com/repos/mozilla/olympia/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/olympia/events","assignees_url":"https://api.github.com/repos/mozilla/olympia/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/olympia/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/olympia/tags","blobs_url":"https://api.github.com/repos/mozilla/olympia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/olympia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/olympia/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/olympia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/olympia/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/olympia/languages","stargazers_url":"https://api.github.com/repos/mozilla/olympia/stargazers","contributors_url":"https://api.github.com/repos/mozilla/olympia/contributors","subscribers_url":"https://api.github.com/repos/mozilla/olympia/subscribers","subscription_url":"https://api.github.com/repos/mozilla/olympia/subscription","commits_url":"https://api.github.com/repos/mozilla/olympia/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/olympia/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/olympia/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/olympia/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/olympia/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/olympia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/olympia/merges","archive_url":"https://api.github.com/repos/mozilla/olympia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/olympia/downloads","issues_url":"https://api.github.com/repos/mozilla/olympia/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/olympia/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/olympia/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/olympia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/olympia/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/olympia/releases{/id}","created_at":"2014-01-31T18:44:15Z","updated_at":"2015-05-07T23:38:48Z","pushed_at":"2015-05-13T08:36:10Z","git_url":"git://github.com/mozilla/olympia.git","ssh_url":"git@github.com:mozilla/olympia.git","clone_url":"https://github.com/mozilla/olympia.git","svn_url":"https://github.com/mozilla/olympia","homepage":"https://addons.mozilla.org/","size":406260,"stargazers_count":31,"watchers_count":31,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":83,"mirror_url":null,"open_issues_count":13,"forks":83,"open_issues":13,"watchers":31,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/olympia/pulls/555"},"html":{"href":"https://github.com/mozilla/olympia/pull/555"},"issue":{"href":"https://api.github.com/repos/mozilla/olympia/issues/555"},"comments":{"href":"https://api.github.com/repos/mozilla/olympia/issues/555/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/olympia/pulls/555/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/olympia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/olympia/pulls/555/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/olympia/statuses/fd0bf1cc53b3c552bb10274ec1e7e6272090d55b"}}}}