{"action":"created","issue":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/4294","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/4294/labels{/name}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/4294/comments","events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/4294/events","html_url":"https://github.com/scikit-learn/scikit-learn/pull/4294","id":58896940,"number":4294,"title":"[WIP] Reorganize grid_search, cross_validation and learning_curve into model_selection","user":{"login":"rvraghav93","id":9487348,"avatar_url":"https://avatars.githubusercontent.com/u/9487348?v=3","gravatar_id":"","url":"https://api.github.com/users/rvraghav93","html_url":"https://github.com/rvraghav93","followers_url":"https://api.github.com/users/rvraghav93/followers","following_url":"https://api.github.com/users/rvraghav93/following{/other_user}","gists_url":"https://api.github.com/users/rvraghav93/gists{/gist_id}","starred_url":"https://api.github.com/users/rvraghav93/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rvraghav93/subscriptions","organizations_url":"https://api.github.com/users/rvraghav93/orgs","repos_url":"https://api.github.com/users/rvraghav93/repos","events_url":"https://api.github.com/users/rvraghav93/events{/privacy}","received_events_url":"https://api.github.com/users/rvraghav93/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":138,"created_at":"2015-02-25T12:54:52Z","updated_at":"2015-07-29T19:11:18Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/4294","html_url":"https://github.com/scikit-learn/scikit-learn/pull/4294","diff_url":"https://github.com/scikit-learn/scikit-learn/pull/4294.diff","patch_url":"https://github.com/scikit-learn/scikit-learn/pull/4294.patch"},"body":"fixes #1848, #2904 \r\n<hr>\r\n**TODO**\r\n- [x] Reorganize the classes / functions into the `model_selection` module.\r\n- [x] Remove all deprecation from new style classes.\r\n- [x] Use split in all the files that use cv ? (or fix `check_cv` so both old style and new style classes can be used)\r\n- [x] Refactor the tests.\r\n- [x] Fix all the imports\r\n- [x] Make all the general tests pass\r\n- [x] Make all the `model_selction` tests pass\r\n- [x] Clean up the old style classes to use as much from the new members as possible. (duplicate as little code as possible) - https://github.com/rvraghav93/scikit-learn/pull/2\r\n- [x]  Fix the examples - https://github.com/rvraghav93/scikit-learn/pull/3\r\n- [ ] Clean up the documentation - https://github.com/rvraghav93/scikit-learn/pull/4\r\n\r\n<hr>\r\n**MINOR**\r\n- [ ] Rename `p` to a better name.\r\n- [x] Rename `_check_is_partition`-->`_check_is_permutation`?\r\n- [x] Remove `_empty_mask`\r\n- [x] As Joel said [here](https://github.com/scikit-learn/scikit-learn/pull/4621/files#r33238307), use binomial coefficient instead of factorial.\r\n\r\n<hr>\r\n**NOTE:**\r\nThe current implementation will still not support nesting `EstimatorCV` inside `GridSearchCV`... This will become possible only after allowing `sample_properties` to pass from `GridSearchCV` to `EstimatorCV`...\r\n<hr>\r\n**PRs whose changes to g_s / c_v / l_c have been manually incorporated into this:**\r\n\r\n#4714 - Svm decision function shape - 1 commit\r\n#4829 - merge _check_cv into check_cv ... -  1 commit\r\n#4857 - Document missing attribute `random_state` in `RandomizedSearchCV` - 1 commit\r\n#4840 - FIX avoid memory cost when sampling from large parameter grids - 1 commit\r\n<hr>\r\nThis PR is slightly based upon @pignacio's work in #3340.\r\n<hr>\r\n\r\n**Other model selection issues to be tackled after this PR is merged**\r\n\r\n(I am just listing all the issues/improvements that are out of scope for this PR but related to the `model_selection`)\r\n\r\n* General tests for CV objects\r\n* Whether `_permutation_test_score` can be replaced by `cross_val_score`?"},"comment":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/comments/126061995","html_url":"https://github.com/scikit-learn/scikit-learn/pull/4294#issuecomment-126061995","issue_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/4294","id":126061995,"user":{"login":"amueller","id":449558,"avatar_url":"https://avatars.githubusercontent.com/u/449558?v=3","gravatar_id":"","url":"https://api.github.com/users/amueller","html_url":"https://github.com/amueller","followers_url":"https://api.github.com/users/amueller/followers","following_url":"https://api.github.com/users/amueller/following{/other_user}","gists_url":"https://api.github.com/users/amueller/gists{/gist_id}","starred_url":"https://api.github.com/users/amueller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amueller/subscriptions","organizations_url":"https://api.github.com/users/amueller/orgs","repos_url":"https://api.github.com/users/amueller/repos","events_url":"https://api.github.com/users/amueller/events{/privacy}","received_events_url":"https://api.github.com/users/amueller/received_events","type":"User","site_admin":false},"created_at":"2015-07-29T19:11:17Z","updated_at":"2015-07-29T19:11:17Z","body":"I just realized I'm one month behind in reviewing this. I apologize."}}