{"action":"created","issue":{"url":"https://api.github.com/repos/owncloud/core/issues/13952","labels_url":"https://api.github.com/repos/owncloud/core/issues/13952/labels{/name}","comments_url":"https://api.github.com/repos/owncloud/core/issues/13952/comments","events_url":"https://api.github.com/repos/owncloud/core/issues/13952/events","html_url":"https://github.com/owncloud/core/pull/13952","id":56831107,"number":13952,"title":"[encryption] don't check if we have a valid user during migration","user":{"login":"schiesbn","id":1589737,"avatar_url":"https://avatars.githubusercontent.com/u/1589737?v=3","gravatar_id":"","url":"https://api.github.com/users/schiesbn","html_url":"https://github.com/schiesbn","followers_url":"https://api.github.com/users/schiesbn/followers","following_url":"https://api.github.com/users/schiesbn/following{/other_user}","gists_url":"https://api.github.com/users/schiesbn/gists{/gist_id}","starred_url":"https://api.github.com/users/schiesbn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schiesbn/subscriptions","organizations_url":"https://api.github.com/users/schiesbn/orgs","repos_url":"https://api.github.com/users/schiesbn/repos","events_url":"https://api.github.com/users/schiesbn/events{/privacy}","received_events_url":"https://api.github.com/users/schiesbn/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/owncloud/core/labels/5%20-%20To%20review","name":"5 - To review","color":"ededed"},{"url":"https://api.github.com/repos/owncloud/core/labels/app:files_encryption","name":"app:files_encryption","color":"02d7e1"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/owncloud/core/milestones/29","labels_url":"https://api.github.com/repos/owncloud/core/milestones/29/labels","id":841322,"number":29,"title":"8.0-current","description":null,"creator":{"login":"craigpg","id":160667,"avatar_url":"https://avatars.githubusercontent.com/u/160667?v=3","gravatar_id":"","url":"https://api.github.com/users/craigpg","html_url":"https://github.com/craigpg","followers_url":"https://api.github.com/users/craigpg/followers","following_url":"https://api.github.com/users/craigpg/following{/other_user}","gists_url":"https://api.github.com/users/craigpg/gists{/gist_id}","starred_url":"https://api.github.com/users/craigpg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/craigpg/subscriptions","organizations_url":"https://api.github.com/users/craigpg/orgs","repos_url":"https://api.github.com/users/craigpg/repos","events_url":"https://api.github.com/users/craigpg/events{/privacy}","received_events_url":"https://api.github.com/users/craigpg/received_events","type":"User","site_admin":false},"open_issues":8,"closed_issues":785,"state":"open","created_at":"2014-10-27T01:20:05Z","updated_at":"2015-02-06T16:58:43Z","due_on":"2015-01-02T22:00:00Z","closed_at":null},"comments":11,"created_at":"2015-02-06T16:10:17Z","updated_at":"2015-02-06T17:04:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/owncloud/core/pulls/13952","html_url":"https://github.com/owncloud/core/pull/13952","diff_url":"https://github.com/owncloud/core/pull/13952.diff","patch_url":"https://github.com/owncloud/core/pull/13952.patch"},"body":"This problem happens if a system has local users and ldap users.\r\n\r\nThe first time the user opens ownCloud on the web interface the upgrade will be triggered. In this case we will only find the local users, not the ldap users, so we will migrate the local users only.\r\nBut now for any share from a local user to a ldap user the userExists() check will fail (because the ldap backend isn't loaded) and we will skip the share key.\r\n\r\nThis PR removes the check, in 99% of all use cases we will have a valid user. This is only problematic in the corner case where we have user names and file names where we are no longer able to detect the user name correctly which should happen really seldom. Even in this case nothing will be lost. The key will be only in the wrong folder and the admin will still have the backup we create before the migration. So he will be able to fix it manually. He will have to do this anyway if this corner-case happens, also with the old code where we skipped the key completely.\r\n\r\nissue: https://github.com/owncloud/core/issues/13950\r\n\r\ncc @PVince81 @DeepDiver1975 "},"comment":{"url":"https://api.github.com/repos/owncloud/core/issues/comments/73272351","html_url":"https://github.com/owncloud/core/pull/13952#issuecomment-73272351","issue_url":"https://api.github.com/repos/owncloud/core/issues/13952","id":73272351,"user":{"login":"blizzz","id":2184312,"avatar_url":"https://avatars.githubusercontent.com/u/2184312?v=3","gravatar_id":"","url":"https://api.github.com/users/blizzz","html_url":"https://github.com/blizzz","followers_url":"https://api.github.com/users/blizzz/followers","following_url":"https://api.github.com/users/blizzz/following{/other_user}","gists_url":"https://api.github.com/users/blizzz/gists{/gist_id}","starred_url":"https://api.github.com/users/blizzz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blizzz/subscriptions","organizations_url":"https://api.github.com/users/blizzz/orgs","repos_url":"https://api.github.com/users/blizzz/repos","events_url":"https://api.github.com/users/blizzz/events{/privacy}","received_events_url":"https://api.github.com/users/blizzz/received_events","type":"User","site_admin":false},"created_at":"2015-02-06T17:04:00Z","updated_at":"2015-02-06T17:04:00Z","body":"if they are found by getUsers, userExists shouldn't be a problem either?"}}