{"action":"created","issue":{"url":"https://api.github.com/repos/marl/jams/issues/26","labels_url":"https://api.github.com/repos/marl/jams/issues/26/labels{/name}","comments_url":"https://api.github.com/repos/marl/jams/issues/26/comments","events_url":"https://api.github.com/repos/marl/jams/issues/26/events","html_url":"https://github.com/marl/jams/issues/26","id":59085174,"number":26,"title":"rewrite unit tests","user":{"login":"bmcfee","id":1190540,"avatar_url":"https://avatars.githubusercontent.com/u/1190540?v=3","gravatar_id":"","url":"https://api.github.com/users/bmcfee","html_url":"https://github.com/bmcfee","followers_url":"https://api.github.com/users/bmcfee/followers","following_url":"https://api.github.com/users/bmcfee/following{/other_user}","gists_url":"https://api.github.com/users/bmcfee/gists{/gist_id}","starred_url":"https://api.github.com/users/bmcfee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmcfee/subscriptions","organizations_url":"https://api.github.com/users/bmcfee/orgs","repos_url":"https://api.github.com/users/bmcfee/repos","events_url":"https://api.github.com/users/bmcfee/events{/privacy}","received_events_url":"https://api.github.com/users/bmcfee/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/marl/jams/labels/enhancement","name":"enhancement","color":"84b6eb"},{"url":"https://api.github.com/repos/marl/jams/labels/pyjams","name":"pyjams","color":"bfe5bf"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":12,"created_at":"2015-02-26T15:05:32Z","updated_at":"2015-05-13T18:52:13Z","closed_at":null,"body":"... since the schema's all different, and much of the (python) codebase has been simplified or rewritten, this is probably necessary.\r\n\r\n@ejhumphrey Any objection to switching from `unittest.TestCase` objects (old and busted) over to nosetest functions (new hotness)?  This will make tests easier to write, and play nicely with #25 ."},"comment":{"url":"https://api.github.com/repos/marl/jams/issues/comments/101775569","html_url":"https://github.com/marl/jams/issues/26#issuecomment-101775569","issue_url":"https://api.github.com/repos/marl/jams/issues/26","id":101775569,"user":{"login":"ejhumphrey","id":926379,"avatar_url":"https://avatars.githubusercontent.com/u/926379?v=3","gravatar_id":"","url":"https://api.github.com/users/ejhumphrey","html_url":"https://github.com/ejhumphrey","followers_url":"https://api.github.com/users/ejhumphrey/followers","following_url":"https://api.github.com/users/ejhumphrey/following{/other_user}","gists_url":"https://api.github.com/users/ejhumphrey/gists{/gist_id}","starred_url":"https://api.github.com/users/ejhumphrey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ejhumphrey/subscriptions","organizations_url":"https://api.github.com/users/ejhumphrey/orgs","repos_url":"https://api.github.com/users/ejhumphrey/repos","events_url":"https://api.github.com/users/ejhumphrey/events{/privacy}","received_events_url":"https://api.github.com/users/ejhumphrey/received_events","type":"User","site_admin":false},"created_at":"2015-05-13T18:52:13Z","updated_at":"2015-05-13T18:52:13Z","body":"++\n\nOn Wed, May 13, 2015 at 2:40 PM, Brian McFee <notifications@github.com>\nwrote:\n\n> Coming back to this thread now.\n>\n> What are people's thoughts on dropping load_textlist as well? It's a\n> one-liner that gets used twice in the (old) import scripts. It sucks an\n> entire text file into an array of strings, in memory.\n>\n> I'd like to drop it, since it's A) simple enough to reimplement as needed\n> (with increased clarity in the resulting code), and B) kind of a bad\n> pattern, since it could crash out of memory if executed on a very large\n> file. I think, in all cases, we can replace it with calls to pandas\n> csv/table parsers with no loss of functionality.\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/marl/jams/issues/26#issuecomment-101771823>.\n>\n"}}