{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/38242094","id":38242094,"diff_hunk":"@@ -194,12 +194,19 @@ func (e *Streamer) doStream() error {\n \t\tif err != nil {\n \t\t\treturn err\n \t\t}\n-\t\tdefer remoteStdin.Reset()","path":"pkg/client/unversioned/remotecommand/remotecommand.go","position":4,"original_position":4,"commit_id":"969e3dc30b424732e00ff500e045a02d24f1ca9c","original_commit_id":"969e3dc30b424732e00ff500e045a02d24f1ca9c","user":{"login":"liggitt","id":980082,"avatar_url":"https://avatars.githubusercontent.com/u/980082?v=3","gravatar_id":"","url":"https://api.github.com/users/liggitt","html_url":"https://github.com/liggitt","followers_url":"https://api.github.com/users/liggitt/followers","following_url":"https://api.github.com/users/liggitt/following{/other_user}","gists_url":"https://api.github.com/users/liggitt/gists{/gist_id}","starred_url":"https://api.github.com/users/liggitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liggitt/subscriptions","organizations_url":"https://api.github.com/users/liggitt/orgs","repos_url":"https://api.github.com/users/liggitt/repos","events_url":"https://api.github.com/users/liggitt/events{/privacy}","received_events_url":"https://api.github.com/users/liggitt/received_events","type":"User","site_admin":false},"body":"interesting, the `cp` essentially \"intercepts\" the EOF, so the remote command never sees it.","created_at":"2015-08-28T20:42:08Z","updated_at":"2015-08-28T20:42:08Z","html_url":"https://github.com/kubernetes/kubernetes/pull/13322#discussion_r38242094","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/13322","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/38242094"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/13322#discussion_r38242094"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/13322"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/13322","id":43665949,"html_url":"https://github.com/kubernetes/kubernetes/pull/13322","diff_url":"https://github.com/kubernetes/kubernetes/pull/13322.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/13322.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/13322","number":13322,"state":"open","locked":false,"title":"Ensure remote stdin stream is closed","user":{"login":"ncdc","id":354,"avatar_url":"https://avatars.githubusercontent.com/u/354?v=3","gravatar_id":"","url":"https://api.github.com/users/ncdc","html_url":"https://github.com/ncdc","followers_url":"https://api.github.com/users/ncdc/followers","following_url":"https://api.github.com/users/ncdc/following{/other_user}","gists_url":"https://api.github.com/users/ncdc/gists{/gist_id}","starred_url":"https://api.github.com/users/ncdc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ncdc/subscriptions","organizations_url":"https://api.github.com/users/ncdc/orgs","repos_url":"https://api.github.com/users/ncdc/repos","events_url":"https://api.github.com/users/ncdc/events{/privacy}","received_events_url":"https://api.github.com/users/ncdc/received_events","type":"User","site_admin":false},"body":"If stdin is noninteractive, the io.Copy from stdin to remoteStdin will\r\nunblock when it finishes reading from stdin. In this case, make sure to\r\nclose remoteStdin so the server knows the client won't be sending any\r\nmore data. This ensures that the remote process terminates. For example:\r\n\r\necho foo | kubectl exec -i <pod> -- cat\r\n\r\nWithout this change, the `cat` process never terminates and `kubectl\r\nexec` hangs.","created_at":"2015-08-28T19:58:11Z","updated_at":"2015-08-28T20:42:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1a87d1325e12be51fe2e4dd743e1d685c3b49677","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/13322/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/13322/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/13322/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/969e3dc30b424732e00ff500e045a02d24f1ca9c","head":{"label":"ncdc:fix-noninteractive-stdin-exec","ref":"fix-noninteractive-stdin-exec","sha":"969e3dc30b424732e00ff500e045a02d24f1ca9c","user":{"login":"ncdc","id":354,"avatar_url":"https://avatars.githubusercontent.com/u/354?v=3","gravatar_id":"","url":"https://api.github.com/users/ncdc","html_url":"https://github.com/ncdc","followers_url":"https://api.github.com/users/ncdc/followers","following_url":"https://api.github.com/users/ncdc/following{/other_user}","gists_url":"https://api.github.com/users/ncdc/gists{/gist_id}","starred_url":"https://api.github.com/users/ncdc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ncdc/subscriptions","organizations_url":"https://api.github.com/users/ncdc/orgs","repos_url":"https://api.github.com/users/ncdc/repos","events_url":"https://api.github.com/users/ncdc/events{/privacy}","received_events_url":"https://api.github.com/users/ncdc/received_events","type":"User","site_admin":false},"repo":{"id":22116483,"name":"kubernetes","full_name":"ncdc/kubernetes","owner":{"login":"ncdc","id":354,"avatar_url":"https://avatars.githubusercontent.com/u/354?v=3","gravatar_id":"","url":"https://api.github.com/users/ncdc","html_url":"https://github.com/ncdc","followers_url":"https://api.github.com/users/ncdc/followers","following_url":"https://api.github.com/users/ncdc/following{/other_user}","gists_url":"https://api.github.com/users/ncdc/gists{/gist_id}","starred_url":"https://api.github.com/users/ncdc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ncdc/subscriptions","organizations_url":"https://api.github.com/users/ncdc/orgs","repos_url":"https://api.github.com/users/ncdc/repos","events_url":"https://api.github.com/users/ncdc/events{/privacy}","received_events_url":"https://api.github.com/users/ncdc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ncdc/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/ncdc/kubernetes","forks_url":"https://api.github.com/repos/ncdc/kubernetes/forks","keys_url":"https://api.github.com/repos/ncdc/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ncdc/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ncdc/kubernetes/teams","hooks_url":"https://api.github.com/repos/ncdc/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/ncdc/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/ncdc/kubernetes/events","assignees_url":"https://api.github.com/repos/ncdc/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/ncdc/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/ncdc/kubernetes/tags","blobs_url":"https://api.github.com/repos/ncdc/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ncdc/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ncdc/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/ncdc/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ncdc/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/ncdc/kubernetes/languages","stargazers_url":"https://api.github.com/repos/ncdc/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/ncdc/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/ncdc/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/ncdc/kubernetes/subscription","commits_url":"https://api.github.com/repos/ncdc/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/ncdc/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/ncdc/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/ncdc/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/ncdc/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/ncdc/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ncdc/kubernetes/merges","archive_url":"https://api.github.com/repos/ncdc/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ncdc/kubernetes/downloads","issues_url":"https://api.github.com/repos/ncdc/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/ncdc/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/ncdc/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/ncdc/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ncdc/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/ncdc/kubernetes/releases{/id}","created_at":"2014-07-22T18:49:30Z","updated_at":"2015-04-13T16:38:08Z","pushed_at":"2015-08-28T20:18:32Z","git_url":"git://github.com/ncdc/kubernetes.git","ssh_url":"git@github.com:ncdc/kubernetes.git","clone_url":"https://github.com/ncdc/kubernetes.git","svn_url":"https://github.com/ncdc/kubernetes","homepage":null,"size":101231,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"98801225d6c42b65515d0c303f6cc414fbdda0b9","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","created_at":"2014-06-06T22:56:04Z","updated_at":"2015-08-28T19:30:42Z","pushed_at":"2015-08-28T20:41:56Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":363954,"stargazers_count":9929,"watchers_count":9929,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2420,"mirror_url":null,"open_issues_count":1660,"forks":2420,"open_issues":1660,"watchers":9929,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/13322"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/13322"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/13322"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/13322/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/13322/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/13322/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/969e3dc30b424732e00ff500e045a02d24f1ca9c"}}}}