{"push_id":610899955,"size":12,"distinct_size":2,"ref":"refs/heads/master","head":"a3c6c6fa7313c08694009e99863da2c7755a9e32","before":"648b6b03118538a155a4613dccd956dc67706680","commits":[{"sha":"5df8d7193ebaa236a46141c8fff134d0053d2534","author":{"email":"91de990240e6abc00928035c476e6ad54ab72b92@gmail.com","name":"Dylan Baker"},"message":"framework tests: use grouptools for joining groups\n\nSince the format is subject to change, it is a bad idea to not use\ngrouptools. Since grouptools is already well tested this should not be\nproblematic.\n\nThis produces no changes in the unit tests, but it does make them more\nrobust.\n\nSigned-off-by: Dylan Baker <dylanx.c.baker@intel.com>\nReviewed-by: Jose Fonseca <jfonseca@vmware.com>","distinct":false,"url":"https://api.github.com/repos/dcbaker/piglit/commits/5df8d7193ebaa236a46141c8fff134d0053d2534"},{"sha":"63d70bd797eae6255f21baf3026623a7d4d18c5a","author":{"email":"91de990240e6abc00928035c476e6ad54ab72b92@gmail.com","name":"Dylan Baker"},"message":"grouptools.py: drop relgroup function\n\nThis function isn't actually used, and implementing a version that\ndoesn't rely on posixpath is a not very appealing. Since it's not used,\nand one can easily use grouptools.from_path to implement the same\nbehavior (one could even revert this patch and wrap the implementation),\nit's going away.\n\nSigned-off-by: Dylan Baker <dylanx.c.baker@intel.com>\nReviewed-by: Jose Fonseca <jfonseca@vmware.com>","distinct":false,"url":"https://api.github.com/repos/dcbaker/piglit/commits/63d70bd797eae6255f21baf3026623a7d4d18c5a"},{"sha":"7213ca9c81776cb67683806f87535e098526a79f","author":{"email":"91de990240e6abc00928035c476e6ad54ab72b92@gmail.com","name":"Dylan Baker"},"message":"grouptools_tests.py: Drop some very complex testing mechanisms\n\nThese mechanisms were very much of the vein, \"I found this cool new\nidea\", and as often as not, they're bad ideas. This one especially.\n\nThis reduces the number of tests, but really doesn't reduce coverage,\nsince most of what is covered by these tests will disappear in the\nfollowing patches of this series.\n\nSigned-off-by: Dylan Baker <dylanx.c.baker@intel.com>\nReviewed-by: Jose Fonseca <jfonseca@vmware.com>","distinct":false,"url":"https://api.github.com/repos/dcbaker/piglit/commits/7213ca9c81776cb67683806f87535e098526a79f"},{"sha":"ae5022bc951e4e77ed8f2d3ca0d6ab6f2ae4f4d1","author":{"email":"91de990240e6abc00928035c476e6ad54ab72b92@gmail.com","name":"Dylan Baker"},"message":"results.py: use posixpath instead of grouptools\n\nOn the surface this looks like a step backwards. But it's not. Because\nposixpath doesn't change, while grouptools might (will) change it's\nseparator in the future, but v4 results never will. Since we use an\nincremental approach to updating (ie, 1 -> 2 -> 3 -> 4 -> inf) we need\nto be sure that results of v4 are correct always, even when grouptools\nchanges.\n\nSigned-off-by: Dylan Baker <dylanx.c.baker@intel.com>\nReviewed-by: Jose Fonseca <jfonseca@vmware.com>","distinct":false,"url":"https://api.github.com/repos/dcbaker/piglit/commits/ae5022bc951e4e77ed8f2d3ca0d6ab6f2ae4f4d1"},{"sha":"81ec0400873e4a890be8e61294afb1242083436d","author":{"email":"91de990240e6abc00928035c476e6ad54ab72b92@gmail.com","name":"Dylan Baker"},"message":"grouptools.py: make group separator a constant value\n\nThis patch makes two changes to the way grouptools works, one as a\nresult of the other. The primary change is that this uses a constant\nSEPARATOR to set the value used by the various functions to work with\ngroups.\n\nThe second change is that this no longer wraps posixpath, which is\nnecessary since posixpath doesn't allow the constant to be changed.\n(well, it does, but that's very fragile and not worth the pain.)\n\nThis also changes some of the tests to use the separator in their names\nusing the DocFormatter decorator. This will allow changing the separator\nfor groups with one trivial change (and the necessary JSON version\nupdates of course)\n\nAlso converts the junit backend to use grouptools.SEPERATOR instead of a\nhardcoded value, and adds a testcase for this potential problem.\n\nv2: - fix spelling error. SEPERATOR -> SEPARATOR (Emil)\n\nSigned-off-by: Dylan Baker <dylanx.c.baker@intel.com>\nReviewed-by: Jose Fonseca <jfonseca@vmware.com>","distinct":false,"url":"https://api.github.com/repos/dcbaker/piglit/commits/81ec0400873e4a890be8e61294afb1242083436d"},{"sha":"e18e969cf9b796231d05e0935e62efa612109b6d","author":{"email":"91de990240e6abc00928035c476e6ad54ab72b92@gmail.com","name":"Dylan Baker"},"message":"summary.py: Use posixpath in one place instead of grouptools\n\nThis was an incorrect change in commit bb712253d3c7b6 that happened to\nwork because the separator was '/', however in this case it should have\nbeen posixpath, and not grouptools or os.path, because posixpath's '/'\nworks across both windows and *nix. Essentially this reverts to the\nbehavior of commit 26642a186bf9, where this line was changed from\nos.path to posixpath, except this commit adds a comment to explain why\nthis is needed.\n\nSigned-off-by: Dylan Baker <dylanx.c.baker@intel.com>","distinct":false,"url":"https://api.github.com/repos/dcbaker/piglit/commits/e18e969cf9b796231d05e0935e62efa612109b6d"},{"sha":"f6c7a3992e2797325c16d3987c1d817fa7edf7c1","author":{"email":"91de990240e6abc00928035c476e6ad54ab72b92@gmail.com","name":"Dylan Baker"},"message":"framework: change group separator from '/' to '@'\n\nWhile / is convenient, since python provides a convenient posixpath\nmodule for working with paths, which was to our advantage too. The\nproblem of course is that for posix users os.path.join and\ngrouptools.join are equivalent, so they happily mix the two. This\ndoesn't work out so well for windows users though, for whom os.path.join\nand grouptools.join are not equivalent.\n\nThis patch replaces the use of / and \\ with @, a character that no os\nuses for paths. This will hopefully put an end to the accidental mixing,\nor at least force people to use grouptools.from_path.\n\nv2: - Also replace \\ with @ (Emil)\n\nSigned-off-by: Dylan Baker <dylanx.c.baker@intel.com>\nReviewed-by: Jose Fonseca <jfonseca@vmware.com>","distinct":false,"url":"https://api.github.com/repos/dcbaker/piglit/commits/f6c7a3992e2797325c16d3987c1d817fa7edf7c1"},{"sha":"9ecfed53a74f764e362196e28672ae229614da67","author":{"email":"91de990240e6abc00928035c476e6ad54ab72b92@gmail.com","name":"Dylan Baker"},"message":"grouptools.py: Drop _normalize and _assert_illegal helpers.\n\nThe _normalize function is no longer necessary because it replaces '\\\\'\nwith '/'. Since the SEPARATOR isn't '/' anymore it isn't useful.\n\nThe _assert_illegal function isn't very useful at this point, since\nhaving '\\\\' or '/' in a test name should be perfectly legal at this\npoint, and the only thing it's doing is type checking, which isn't that\ninteresting.\n\nSigned-off-by: Dylan Baker <dylanx.c.baker@intel.com>","distinct":false,"url":"https://api.github.com/repos/dcbaker/piglit/commits/9ecfed53a74f764e362196e28672ae229614da67"},{"sha":"8d12cb073126ffc9d16aa38b6efcb6b2c15a7c29","author":{"email":"25a259f709b0f1b620605d2518271a846d8826e5@freedesktop.org","name":"Vinson Lee"},"message":"backends_tests.py: Fix PEP 8 issues.\n\nSigned-off-by: Vinson Lee <vlee@freedesktop.org>\nReviewed-by: Dylan Baker <baker.dylan.c@gmail.com>","distinct":false,"url":"https://api.github.com/repos/dcbaker/piglit/commits/8d12cb073126ffc9d16aa38b6efcb6b2c15a7c29"},{"sha":"57426de16862a16578cd4975a406ea60114ff69b","author":{"email":"25a259f709b0f1b620605d2518271a846d8826e5@freedesktop.org","name":"Vinson Lee"},"message":"junit.py: Fix PEP 8 issues.\n\nSigned-off-by: Vinson Lee <vlee@freedesktop.org>\nReviewed-by: Dylan Baker <baker.dylan.c@gmail.com>","distinct":false,"url":"https://api.github.com/repos/dcbaker/piglit/commits/57426de16862a16578cd4975a406ea60114ff69b"},{"sha":"f02cd7c1fc7280aaf17f4df61c2abb745adc13f0","author":{"email":"91de990240e6abc00928035c476e6ad54ab72b92@gmail.com","name":"Dylan Baker"},"message":"summary: Add an aggregate function\n\nThis summarizer can be used to aggregate a set of individual tests\ntogether into a single results file.\n\nSigned-off-by: Dylan Baker <dylanx.c.baker@intel.com>\nReviewed-by: Brian Paul <brianp@vmware.com>","distinct":true,"url":"https://api.github.com/repos/dcbaker/piglit/commits/f02cd7c1fc7280aaf17f4df61c2abb745adc13f0"},{"sha":"a3c6c6fa7313c08694009e99863da2c7755a9e32","author":{"email":"91de990240e6abc00928035c476e6ad54ab72b92@gmail.com","name":"Dylan Baker"},"message":"framework; Catch \"No results found\" exception\n\nThis adds a couple of catches for results not found and cleanly exits\nwithout a traceback when this is an expected error condition.\n\nSigned-off-by: Dylan Baker <dylanx.c.baker@intel.com>\nReviewed-by: Brian Paul <brianp@vmware.com>","distinct":true,"url":"https://api.github.com/repos/dcbaker/piglit/commits/a3c6c6fa7313c08694009e99863da2c7755a9e32"}]}