{"action":"created","comment":{"url":"https://api.github.com/repos/camptocamp/ngeo/pulls/comments/46277491","id":46277491,"diff_hunk":"@@ -0,0 +1,187 @@\n+goog.provide('gmf.MobileGeolocationController');\n+goog.provide('gmf.mobileGeolocationDirective');\n+\n+goog.require('gmf');\n+goog.require('ngeo.DecorateGeolocation');\n+goog.require('ngeo.FeatureOverlay');\n+goog.require('ngeo.FeatureOverlayMgr');\n+goog.require('ol.Feature');\n+goog.require('ol.Geolocation');\n+goog.require('ol.Map');\n+goog.require('ol.geom.Point');\n+goog.require('ol.proj');\n+\n+\n+/**\n+ * Provide a \"mobile geolocation\" directive.\n+ *\n+ * @example\n+ * <gmf-mobile-geolocation\n+ *     gmf-mobile-geolocation-map=\"ctrl.map\"\n+ *     gmf-mobile-geolocation-options=\"ctrl.mobileGeolocationOptions\">\n+ * </gmf-mobile-geolocation>\n+ *\n+ * @return {angular.Directive} The Directive Definition Object.\n+ * @ngInject\n+ */\n+gmf.mobileGeolocationDirective = function() {\n+  return {\n+    restrict: 'E',\n+    scope: {\n+      'getMobileMapFn': '&gmfMobileGeolocationMap',\n+      'getMobileGeolocationOptionsFn': '&gmfMobileGeolocationOptions'\n+    },\n+    controller: 'GmfMobileGeolocationController',\n+    controllerAs: 'ctrl',\n+    templateUrl: 'partials/mobilegeolocation.html'","path":"contribs/gmf/src/directives/mobilegeolocation.js","position":36,"original_position":36,"commit_id":"d07c78f0deadbacfe076eef666242dbf638969f2","original_commit_id":"d07c78f0deadbacfe076eef666242dbf638969f2","user":{"login":"fgravin","id":1491924,"avatar_url":"https://avatars.githubusercontent.com/u/1491924?v=3","gravatar_id":"","url":"https://api.github.com/users/fgravin","html_url":"https://github.com/fgravin","followers_url":"https://api.github.com/users/fgravin/followers","following_url":"https://api.github.com/users/fgravin/following{/other_user}","gists_url":"https://api.github.com/users/fgravin/gists{/gist_id}","starred_url":"https://api.github.com/users/fgravin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fgravin/subscriptions","organizations_url":"https://api.github.com/users/fgravin/orgs","repos_url":"https://api.github.com/users/fgravin/repos","events_url":"https://api.github.com/users/fgravin/events{/privacy}","received_events_url":"https://api.github.com/users/fgravin/received_events","type":"User","site_admin":false},"body":"I personnally don't really care, but we need to be coherent. I just saw that there was inline template in other gmf directives, wondering if there were any reason ?\r\n\r\nIf you change the makefile for those templates to be managed by `$templateCache`, it's gonna be the same in the end.\r\nSo you can keep it like this, maybe we should update other directives like https://github.com/camptocamp/ngeo/blob/master/contribs/gmf/src/directives/search.js#L44","created_at":"2015-12-01T13:33:22Z","updated_at":"2015-12-01T13:33:22Z","html_url":"https://github.com/camptocamp/ngeo/pull/420#discussion_r46277491","pull_request_url":"https://api.github.com/repos/camptocamp/ngeo/pulls/420","_links":{"self":{"href":"https://api.github.com/repos/camptocamp/ngeo/pulls/comments/46277491"},"html":{"href":"https://github.com/camptocamp/ngeo/pull/420#discussion_r46277491"},"pull_request":{"href":"https://api.github.com/repos/camptocamp/ngeo/pulls/420"}}},"pull_request":{"url":"https://api.github.com/repos/camptocamp/ngeo/pulls/420","id":52177064,"html_url":"https://github.com/camptocamp/ngeo/pull/420","diff_url":"https://github.com/camptocamp/ngeo/pull/420.diff","patch_url":"https://github.com/camptocamp/ngeo/pull/420.patch","issue_url":"https://api.github.com/repos/camptocamp/ngeo/issues/420","number":420,"state":"open","locked":false,"title":"Gmf geolocation mobile","user":{"login":"adube","id":432436,"avatar_url":"https://avatars.githubusercontent.com/u/432436?v=3","gravatar_id":"","url":"https://api.github.com/users/adube","html_url":"https://github.com/adube","followers_url":"https://api.github.com/users/adube/followers","following_url":"https://api.github.com/users/adube/following{/other_user}","gists_url":"https://api.github.com/users/adube/gists{/gist_id}","starred_url":"https://api.github.com/users/adube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adube/subscriptions","organizations_url":"https://api.github.com/users/adube/orgs","repos_url":"https://api.github.com/users/adube/repos","events_url":"https://api.github.com/users/adube/events{/privacy}","received_events_url":"https://api.github.com/users/adube/received_events","type":"User","site_admin":false},"body":"This PR introduces the GMF mobile geolocation directive.  When clicked, if inactive, the inner geolocation gets activated.  A point feature is added on the map for the location and an other regular polygon feature is added for the precision.  If clicked again, if the position is at the center of the map, then the tracking is deactivated.  Otherwise, a new tracking position is obtained.\r\n\r\nIt also introduces an example in which it is featured.\r\n\r\nIt is possible to define 3 options:\r\n\r\n * `accuracyFeatureStyle`\r\n * `positionFeatureStyle`\r\n * `zoom`","created_at":"2015-11-30T20:48:57Z","updated_at":"2015-12-01T13:33:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2d449ca9ee693079477217b461129e93a444b18e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/camptocamp/ngeo/pulls/420/commits","review_comments_url":"https://api.github.com/repos/camptocamp/ngeo/pulls/420/comments","review_comment_url":"https://api.github.com/repos/camptocamp/ngeo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/camptocamp/ngeo/issues/420/comments","statuses_url":"https://api.github.com/repos/camptocamp/ngeo/statuses/d07c78f0deadbacfe076eef666242dbf638969f2","head":{"label":"adube:gmf-geolocation-mobile","ref":"gmf-geolocation-mobile","sha":"d07c78f0deadbacfe076eef666242dbf638969f2","user":{"login":"adube","id":432436,"avatar_url":"https://avatars.githubusercontent.com/u/432436?v=3","gravatar_id":"","url":"https://api.github.com/users/adube","html_url":"https://github.com/adube","followers_url":"https://api.github.com/users/adube/followers","following_url":"https://api.github.com/users/adube/following{/other_user}","gists_url":"https://api.github.com/users/adube/gists{/gist_id}","starred_url":"https://api.github.com/users/adube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adube/subscriptions","organizations_url":"https://api.github.com/users/adube/orgs","repos_url":"https://api.github.com/users/adube/repos","events_url":"https://api.github.com/users/adube/events{/privacy}","received_events_url":"https://api.github.com/users/adube/received_events","type":"User","site_admin":false},"repo":{"id":46440520,"name":"ngeo","full_name":"adube/ngeo","owner":{"login":"adube","id":432436,"avatar_url":"https://avatars.githubusercontent.com/u/432436?v=3","gravatar_id":"","url":"https://api.github.com/users/adube","html_url":"https://github.com/adube","followers_url":"https://api.github.com/users/adube/followers","following_url":"https://api.github.com/users/adube/following{/other_user}","gists_url":"https://api.github.com/users/adube/gists{/gist_id}","starred_url":"https://api.github.com/users/adube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adube/subscriptions","organizations_url":"https://api.github.com/users/adube/orgs","repos_url":"https://api.github.com/users/adube/repos","events_url":"https://api.github.com/users/adube/events{/privacy}","received_events_url":"https://api.github.com/users/adube/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adube/ngeo","description":"Library combining OpenLayers 3 and AngularJS","fork":true,"url":"https://api.github.com/repos/adube/ngeo","forks_url":"https://api.github.com/repos/adube/ngeo/forks","keys_url":"https://api.github.com/repos/adube/ngeo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adube/ngeo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adube/ngeo/teams","hooks_url":"https://api.github.com/repos/adube/ngeo/hooks","issue_events_url":"https://api.github.com/repos/adube/ngeo/issues/events{/number}","events_url":"https://api.github.com/repos/adube/ngeo/events","assignees_url":"https://api.github.com/repos/adube/ngeo/assignees{/user}","branches_url":"https://api.github.com/repos/adube/ngeo/branches{/branch}","tags_url":"https://api.github.com/repos/adube/ngeo/tags","blobs_url":"https://api.github.com/repos/adube/ngeo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adube/ngeo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adube/ngeo/git/refs{/sha}","trees_url":"https://api.github.com/repos/adube/ngeo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adube/ngeo/statuses/{sha}","languages_url":"https://api.github.com/repos/adube/ngeo/languages","stargazers_url":"https://api.github.com/repos/adube/ngeo/stargazers","contributors_url":"https://api.github.com/repos/adube/ngeo/contributors","subscribers_url":"https://api.github.com/repos/adube/ngeo/subscribers","subscription_url":"https://api.github.com/repos/adube/ngeo/subscription","commits_url":"https://api.github.com/repos/adube/ngeo/commits{/sha}","git_commits_url":"https://api.github.com/repos/adube/ngeo/git/commits{/sha}","comments_url":"https://api.github.com/repos/adube/ngeo/comments{/number}","issue_comment_url":"https://api.github.com/repos/adube/ngeo/issues/comments{/number}","contents_url":"https://api.github.com/repos/adube/ngeo/contents/{+path}","compare_url":"https://api.github.com/repos/adube/ngeo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adube/ngeo/merges","archive_url":"https://api.github.com/repos/adube/ngeo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adube/ngeo/downloads","issues_url":"https://api.github.com/repos/adube/ngeo/issues{/number}","pulls_url":"https://api.github.com/repos/adube/ngeo/pulls{/number}","milestones_url":"https://api.github.com/repos/adube/ngeo/milestones{/number}","notifications_url":"https://api.github.com/repos/adube/ngeo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adube/ngeo/labels{/name}","releases_url":"https://api.github.com/repos/adube/ngeo/releases{/id}","created_at":"2015-11-18T18:59:08Z","updated_at":"2015-11-18T18:59:11Z","pushed_at":"2015-11-30T21:14:38Z","git_url":"git://github.com/adube/ngeo.git","ssh_url":"git@github.com:adube/ngeo.git","clone_url":"https://github.com/adube/ngeo.git","svn_url":"https://github.com/adube/ngeo","homepage":null,"size":13861,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"camptocamp:master","ref":"master","sha":"6ad13e2a1900d1dfbf4d515904885f86d1350a8f","user":{"login":"camptocamp","id":28109,"avatar_url":"https://avatars.githubusercontent.com/u/28109?v=3","gravatar_id":"","url":"https://api.github.com/users/camptocamp","html_url":"https://github.com/camptocamp","followers_url":"https://api.github.com/users/camptocamp/followers","following_url":"https://api.github.com/users/camptocamp/following{/other_user}","gists_url":"https://api.github.com/users/camptocamp/gists{/gist_id}","starred_url":"https://api.github.com/users/camptocamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/camptocamp/subscriptions","organizations_url":"https://api.github.com/users/camptocamp/orgs","repos_url":"https://api.github.com/users/camptocamp/repos","events_url":"https://api.github.com/users/camptocamp/events{/privacy}","received_events_url":"https://api.github.com/users/camptocamp/received_events","type":"Organization","site_admin":false},"repo":{"id":20212761,"name":"ngeo","full_name":"camptocamp/ngeo","owner":{"login":"camptocamp","id":28109,"avatar_url":"https://avatars.githubusercontent.com/u/28109?v=3","gravatar_id":"","url":"https://api.github.com/users/camptocamp","html_url":"https://github.com/camptocamp","followers_url":"https://api.github.com/users/camptocamp/followers","following_url":"https://api.github.com/users/camptocamp/following{/other_user}","gists_url":"https://api.github.com/users/camptocamp/gists{/gist_id}","starred_url":"https://api.github.com/users/camptocamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/camptocamp/subscriptions","organizations_url":"https://api.github.com/users/camptocamp/orgs","repos_url":"https://api.github.com/users/camptocamp/repos","events_url":"https://api.github.com/users/camptocamp/events{/privacy}","received_events_url":"https://api.github.com/users/camptocamp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/camptocamp/ngeo","description":"Library combining OpenLayers 3 and AngularJS","fork":false,"url":"https://api.github.com/repos/camptocamp/ngeo","forks_url":"https://api.github.com/repos/camptocamp/ngeo/forks","keys_url":"https://api.github.com/repos/camptocamp/ngeo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/camptocamp/ngeo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/camptocamp/ngeo/teams","hooks_url":"https://api.github.com/repos/camptocamp/ngeo/hooks","issue_events_url":"https://api.github.com/repos/camptocamp/ngeo/issues/events{/number}","events_url":"https://api.github.com/repos/camptocamp/ngeo/events","assignees_url":"https://api.github.com/repos/camptocamp/ngeo/assignees{/user}","branches_url":"https://api.github.com/repos/camptocamp/ngeo/branches{/branch}","tags_url":"https://api.github.com/repos/camptocamp/ngeo/tags","blobs_url":"https://api.github.com/repos/camptocamp/ngeo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/camptocamp/ngeo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/camptocamp/ngeo/git/refs{/sha}","trees_url":"https://api.github.com/repos/camptocamp/ngeo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/camptocamp/ngeo/statuses/{sha}","languages_url":"https://api.github.com/repos/camptocamp/ngeo/languages","stargazers_url":"https://api.github.com/repos/camptocamp/ngeo/stargazers","contributors_url":"https://api.github.com/repos/camptocamp/ngeo/contributors","subscribers_url":"https://api.github.com/repos/camptocamp/ngeo/subscribers","subscription_url":"https://api.github.com/repos/camptocamp/ngeo/subscription","commits_url":"https://api.github.com/repos/camptocamp/ngeo/commits{/sha}","git_commits_url":"https://api.github.com/repos/camptocamp/ngeo/git/commits{/sha}","comments_url":"https://api.github.com/repos/camptocamp/ngeo/comments{/number}","issue_comment_url":"https://api.github.com/repos/camptocamp/ngeo/issues/comments{/number}","contents_url":"https://api.github.com/repos/camptocamp/ngeo/contents/{+path}","compare_url":"https://api.github.com/repos/camptocamp/ngeo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/camptocamp/ngeo/merges","archive_url":"https://api.github.com/repos/camptocamp/ngeo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/camptocamp/ngeo/downloads","issues_url":"https://api.github.com/repos/camptocamp/ngeo/issues{/number}","pulls_url":"https://api.github.com/repos/camptocamp/ngeo/pulls{/number}","milestones_url":"https://api.github.com/repos/camptocamp/ngeo/milestones{/number}","notifications_url":"https://api.github.com/repos/camptocamp/ngeo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/camptocamp/ngeo/labels{/name}","releases_url":"https://api.github.com/repos/camptocamp/ngeo/releases{/id}","created_at":"2014-05-27T08:34:54Z","updated_at":"2015-11-19T10:38:37Z","pushed_at":"2015-11-30T21:14:39Z","git_url":"git://github.com/camptocamp/ngeo.git","ssh_url":"git@github.com:camptocamp/ngeo.git","clone_url":"https://github.com/camptocamp/ngeo.git","svn_url":"https://github.com/camptocamp/ngeo","homepage":null,"size":17201,"stargazers_count":50,"watchers_count":50,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":30,"mirror_url":null,"open_issues_count":17,"forks":30,"open_issues":17,"watchers":50,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/camptocamp/ngeo/pulls/420"},"html":{"href":"https://github.com/camptocamp/ngeo/pull/420"},"issue":{"href":"https://api.github.com/repos/camptocamp/ngeo/issues/420"},"comments":{"href":"https://api.github.com/repos/camptocamp/ngeo/issues/420/comments"},"review_comments":{"href":"https://api.github.com/repos/camptocamp/ngeo/pulls/420/comments"},"review_comment":{"href":"https://api.github.com/repos/camptocamp/ngeo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/camptocamp/ngeo/pulls/420/commits"},"statuses":{"href":"https://api.github.com/repos/camptocamp/ngeo/statuses/d07c78f0deadbacfe076eef666242dbf638969f2"}}}}