{"action":"created","comment":{"url":"https://api.github.com/repos/ethereum/go-ethereum/pulls/comments/47504730","id":47504730,"diff_hunk":"@@ -70,6 +71,9 @@ type Service interface {\n \t// Protocol retrieves the P2P protocols the service wishes to start.\n \tProtocols() []p2p.Protocol\n \n+\t// Apis retrieves the list of RPC descriptors the service provides\n+\tApis() []rpc.API","path":"node/service.go","position":13,"original_position":13,"commit_id":"f3fcf670c0f4f9f427a733fc6b2501e06016e4f0","original_commit_id":"f3fcf670c0f4f9f427a733fc6b2501e06016e4f0","user":{"login":"fjl","id":6915,"avatar_url":"https://avatars.githubusercontent.com/u/6915?v=3","gravatar_id":"","url":"https://api.github.com/users/fjl","html_url":"https://github.com/fjl","followers_url":"https://api.github.com/users/fjl/followers","following_url":"https://api.github.com/users/fjl/following{/other_user}","gists_url":"https://api.github.com/users/fjl/gists{/gist_id}","starred_url":"https://api.github.com/users/fjl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fjl/subscriptions","organizations_url":"https://api.github.com/users/fjl/orgs","repos_url":"https://api.github.com/users/fjl/repos","events_url":"https://api.github.com/users/fjl/events{/privacy}","received_events_url":"https://api.github.com/users/fjl/received_events","type":"User","site_admin":false},"body":"`APIs`.","created_at":"2015-12-14T14:46:36Z","updated_at":"2015-12-14T14:46:36Z","html_url":"https://github.com/ethereum/go-ethereum/pull/2035#discussion_r47504730","pull_request_url":"https://api.github.com/repos/ethereum/go-ethereum/pulls/2035","_links":{"self":{"href":"https://api.github.com/repos/ethereum/go-ethereum/pulls/comments/47504730"},"html":{"href":"https://github.com/ethereum/go-ethereum/pull/2035#discussion_r47504730"},"pull_request":{"href":"https://api.github.com/repos/ethereum/go-ethereum/pulls/2035"}}},"pull_request":{"url":"https://api.github.com/repos/ethereum/go-ethereum/pulls/2035","id":52521925,"html_url":"https://github.com/ethereum/go-ethereum/pull/2035","diff_url":"https://github.com/ethereum/go-ethereum/pull/2035.diff","patch_url":"https://github.com/ethereum/go-ethereum/pull/2035.patch","issue_url":"https://api.github.com/repos/ethereum/go-ethereum/issues/2035","number":2035,"state":"open","locked":false,"title":"rpc: new RPC implementation with pub/sub support","user":{"login":"bas-vk","id":4280775,"avatar_url":"https://avatars.githubusercontent.com/u/4280775?v=3","gravatar_id":"","url":"https://api.github.com/users/bas-vk","html_url":"https://github.com/bas-vk","followers_url":"https://api.github.com/users/bas-vk/followers","following_url":"https://api.github.com/users/bas-vk/following{/other_user}","gists_url":"https://api.github.com/users/bas-vk/gists{/gist_id}","starred_url":"https://api.github.com/users/bas-vk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bas-vk/subscriptions","organizations_url":"https://api.github.com/users/bas-vk/orgs","repos_url":"https://api.github.com/users/bas-vk/repos","events_url":"https://api.github.com/users/bas-vk/events{/privacy}","received_events_url":"https://api.github.com/users/bas-vk/received_events","type":"User","site_admin":false},"body":"This PR includes a new RPC implementation that is build on top of the new node architecture in the node. It adds support for pub/sub.\r\n\r\nThe new implementation lacks support for the `admin` and `debug` modules which the current interface provides since there is a debate how we can accommodate these in the new architecture.\r\n\r\nTherefore a new flag `--ipcexp` flag is added. This will start the new RPC implementation. By default the old IPC interface is started.\r\n\r\ncloses #1935","created_at":"2015-12-03T11:25:14Z","updated_at":"2015-12-14T14:46:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"73f138d6428360ed3fd38f7f031911bfd005d480","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ethereum/go-ethereum/pulls/2035/commits","review_comments_url":"https://api.github.com/repos/ethereum/go-ethereum/pulls/2035/comments","review_comment_url":"https://api.github.com/repos/ethereum/go-ethereum/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ethereum/go-ethereum/issues/2035/comments","statuses_url":"https://api.github.com/repos/ethereum/go-ethereum/statuses/f3fcf670c0f4f9f427a733fc6b2501e06016e4f0","head":{"label":"bas-vk:rcp-v2-rebase","ref":"rcp-v2-rebase","sha":"f3fcf670c0f4f9f427a733fc6b2501e06016e4f0","user":{"login":"bas-vk","id":4280775,"avatar_url":"https://avatars.githubusercontent.com/u/4280775?v=3","gravatar_id":"","url":"https://api.github.com/users/bas-vk","html_url":"https://github.com/bas-vk","followers_url":"https://api.github.com/users/bas-vk/followers","following_url":"https://api.github.com/users/bas-vk/following{/other_user}","gists_url":"https://api.github.com/users/bas-vk/gists{/gist_id}","starred_url":"https://api.github.com/users/bas-vk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bas-vk/subscriptions","organizations_url":"https://api.github.com/users/bas-vk/orgs","repos_url":"https://api.github.com/users/bas-vk/repos","events_url":"https://api.github.com/users/bas-vk/events{/privacy}","received_events_url":"https://api.github.com/users/bas-vk/received_events","type":"User","site_admin":false},"repo":{"id":33240025,"name":"go-ethereum","full_name":"bas-vk/go-ethereum","owner":{"login":"bas-vk","id":4280775,"avatar_url":"https://avatars.githubusercontent.com/u/4280775?v=3","gravatar_id":"","url":"https://api.github.com/users/bas-vk","html_url":"https://github.com/bas-vk","followers_url":"https://api.github.com/users/bas-vk/followers","following_url":"https://api.github.com/users/bas-vk/following{/other_user}","gists_url":"https://api.github.com/users/bas-vk/gists{/gist_id}","starred_url":"https://api.github.com/users/bas-vk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bas-vk/subscriptions","organizations_url":"https://api.github.com/users/bas-vk/orgs","repos_url":"https://api.github.com/users/bas-vk/repos","events_url":"https://api.github.com/users/bas-vk/events{/privacy}","received_events_url":"https://api.github.com/users/bas-vk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bas-vk/go-ethereum","description":"Jeffrey Wilcke's Go implementation of the Ethereum y/w paper","fork":true,"url":"https://api.github.com/repos/bas-vk/go-ethereum","forks_url":"https://api.github.com/repos/bas-vk/go-ethereum/forks","keys_url":"https://api.github.com/repos/bas-vk/go-ethereum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bas-vk/go-ethereum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bas-vk/go-ethereum/teams","hooks_url":"https://api.github.com/repos/bas-vk/go-ethereum/hooks","issue_events_url":"https://api.github.com/repos/bas-vk/go-ethereum/issues/events{/number}","events_url":"https://api.github.com/repos/bas-vk/go-ethereum/events","assignees_url":"https://api.github.com/repos/bas-vk/go-ethereum/assignees{/user}","branches_url":"https://api.github.com/repos/bas-vk/go-ethereum/branches{/branch}","tags_url":"https://api.github.com/repos/bas-vk/go-ethereum/tags","blobs_url":"https://api.github.com/repos/bas-vk/go-ethereum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bas-vk/go-ethereum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bas-vk/go-ethereum/git/refs{/sha}","trees_url":"https://api.github.com/repos/bas-vk/go-ethereum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bas-vk/go-ethereum/statuses/{sha}","languages_url":"https://api.github.com/repos/bas-vk/go-ethereum/languages","stargazers_url":"https://api.github.com/repos/bas-vk/go-ethereum/stargazers","contributors_url":"https://api.github.com/repos/bas-vk/go-ethereum/contributors","subscribers_url":"https://api.github.com/repos/bas-vk/go-ethereum/subscribers","subscription_url":"https://api.github.com/repos/bas-vk/go-ethereum/subscription","commits_url":"https://api.github.com/repos/bas-vk/go-ethereum/commits{/sha}","git_commits_url":"https://api.github.com/repos/bas-vk/go-ethereum/git/commits{/sha}","comments_url":"https://api.github.com/repos/bas-vk/go-ethereum/comments{/number}","issue_comment_url":"https://api.github.com/repos/bas-vk/go-ethereum/issues/comments{/number}","contents_url":"https://api.github.com/repos/bas-vk/go-ethereum/contents/{+path}","compare_url":"https://api.github.com/repos/bas-vk/go-ethereum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bas-vk/go-ethereum/merges","archive_url":"https://api.github.com/repos/bas-vk/go-ethereum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bas-vk/go-ethereum/downloads","issues_url":"https://api.github.com/repos/bas-vk/go-ethereum/issues{/number}","pulls_url":"https://api.github.com/repos/bas-vk/go-ethereum/pulls{/number}","milestones_url":"https://api.github.com/repos/bas-vk/go-ethereum/milestones{/number}","notifications_url":"https://api.github.com/repos/bas-vk/go-ethereum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bas-vk/go-ethereum/labels{/name}","releases_url":"https://api.github.com/repos/bas-vk/go-ethereum/releases{/id}","created_at":"2015-04-01T09:53:33Z","updated_at":"2015-05-04T10:25:06Z","pushed_at":"2015-12-14T12:49:05Z","git_url":"git://github.com/bas-vk/go-ethereum.git","ssh_url":"git@github.com:bas-vk/go-ethereum.git","clone_url":"https://github.com/bas-vk/go-ethereum.git","svn_url":"https://github.com/bas-vk/go-ethereum","homepage":"","size":51675,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"base":{"label":"ethereum:develop","ref":"develop","sha":"787d71d6595df98586c625e82f4decb034215203","user":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars.githubusercontent.com/u/6250754?v=3","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"repo":{"id":15452919,"name":"go-ethereum","full_name":"ethereum/go-ethereum","owner":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars.githubusercontent.com/u/6250754?v=3","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ethereum/go-ethereum","description":"Official golang implementation of the Ethereum protocol","fork":false,"url":"https://api.github.com/repos/ethereum/go-ethereum","forks_url":"https://api.github.com/repos/ethereum/go-ethereum/forks","keys_url":"https://api.github.com/repos/ethereum/go-ethereum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereum/go-ethereum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereum/go-ethereum/teams","hooks_url":"https://api.github.com/repos/ethereum/go-ethereum/hooks","issue_events_url":"https://api.github.com/repos/ethereum/go-ethereum/issues/events{/number}","events_url":"https://api.github.com/repos/ethereum/go-ethereum/events","assignees_url":"https://api.github.com/repos/ethereum/go-ethereum/assignees{/user}","branches_url":"https://api.github.com/repos/ethereum/go-ethereum/branches{/branch}","tags_url":"https://api.github.com/repos/ethereum/go-ethereum/tags","blobs_url":"https://api.github.com/repos/ethereum/go-ethereum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereum/go-ethereum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereum/go-ethereum/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereum/go-ethereum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereum/go-ethereum/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereum/go-ethereum/languages","stargazers_url":"https://api.github.com/repos/ethereum/go-ethereum/stargazers","contributors_url":"https://api.github.com/repos/ethereum/go-ethereum/contributors","subscribers_url":"https://api.github.com/repos/ethereum/go-ethereum/subscribers","subscription_url":"https://api.github.com/repos/ethereum/go-ethereum/subscription","commits_url":"https://api.github.com/repos/ethereum/go-ethereum/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereum/go-ethereum/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereum/go-ethereum/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereum/go-ethereum/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethereum/go-ethereum/contents/{+path}","compare_url":"https://api.github.com/repos/ethereum/go-ethereum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereum/go-ethereum/merges","archive_url":"https://api.github.com/repos/ethereum/go-ethereum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereum/go-ethereum/downloads","issues_url":"https://api.github.com/repos/ethereum/go-ethereum/issues{/number}","pulls_url":"https://api.github.com/repos/ethereum/go-ethereum/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereum/go-ethereum/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereum/go-ethereum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereum/go-ethereum/labels{/name}","releases_url":"https://api.github.com/repos/ethereum/go-ethereum/releases{/id}","created_at":"2013-12-26T13:05:46Z","updated_at":"2015-12-14T06:55:40Z","pushed_at":"2015-12-14T12:49:06Z","git_url":"git://github.com/ethereum/go-ethereum.git","ssh_url":"git@github.com:ethereum/go-ethereum.git","clone_url":"https://github.com/ethereum/go-ethereum.git","svn_url":"https://github.com/ethereum/go-ethereum","homepage":"http://ethereum.github.io/go-ethereum/","size":64082,"stargazers_count":765,"watchers_count":765,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":265,"mirror_url":null,"open_issues_count":145,"forks":265,"open_issues":145,"watchers":765,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ethereum/go-ethereum/pulls/2035"},"html":{"href":"https://github.com/ethereum/go-ethereum/pull/2035"},"issue":{"href":"https://api.github.com/repos/ethereum/go-ethereum/issues/2035"},"comments":{"href":"https://api.github.com/repos/ethereum/go-ethereum/issues/2035/comments"},"review_comments":{"href":"https://api.github.com/repos/ethereum/go-ethereum/pulls/2035/comments"},"review_comment":{"href":"https://api.github.com/repos/ethereum/go-ethereum/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ethereum/go-ethereum/pulls/2035/commits"},"statuses":{"href":"https://api.github.com/repos/ethereum/go-ethereum/statuses/f3fcf670c0f4f9f427a733fc6b2501e06016e4f0"}}}}