{"action":"created","comment":{"url":"https://api.github.com/repos/openzipkin/zipkin/pulls/comments/35546383","id":35546383,"diff_hunk":"@@ -0,0 +1,21 @@\n+buildscript {\n+\trepositories {\n+\t\tmaven {\n+\t\t\turl \"https://plugins.gradle.org/m2/\"\n+\t\t}\n+\t}\n+\tdependencies {\n+\t\tclasspath \"com.github.maiflai:gradle-scalatest:0.8\"\n+\t}\n+}\n+\n+if (!project.plugins.findPlugin(com.github.maiflai.ScalaTestPlugin)) {","path":"gradle-scalatest.plugin","position":12,"original_position":12,"commit_id":"5df2d8b306e1d79ee0ac21ec26a76893ff0a4fc3","original_commit_id":"d0af4f4b520e4ab494ab36ff59f92a90ecb66f2b","user":{"login":"abesto","id":59982,"avatar_url":"https://avatars.githubusercontent.com/u/59982?v=3","gravatar_id":"","url":"https://api.github.com/users/abesto","html_url":"https://github.com/abesto","followers_url":"https://api.github.com/users/abesto/followers","following_url":"https://api.github.com/users/abesto/following{/other_user}","gists_url":"https://api.github.com/users/abesto/gists{/gist_id}","starred_url":"https://api.github.com/users/abesto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abesto/subscriptions","organizations_url":"https://api.github.com/users/abesto/orgs","repos_url":"https://api.github.com/users/abesto/repos","events_url":"https://api.github.com/users/abesto/events{/privacy}","received_events_url":"https://api.github.com/users/abesto/received_events","type":"User","site_admin":false},"body":"First saw this in https://raw.githubusercontent.com/akhikhl/gradle-onejar/master/pluginScripts/gradle-onejar.plugin, looked like good practice. Is there a down-side to this being here?","created_at":"2015-07-27T15:08:49Z","updated_at":"2015-07-27T15:08:49Z","html_url":"https://github.com/openzipkin/zipkin/pull/503#discussion_r35546383","pull_request_url":"https://api.github.com/repos/openzipkin/zipkin/pulls/503","_links":{"self":{"href":"https://api.github.com/repos/openzipkin/zipkin/pulls/comments/35546383"},"html":{"href":"https://github.com/openzipkin/zipkin/pull/503#discussion_r35546383"},"pull_request":{"href":"https://api.github.com/repos/openzipkin/zipkin/pulls/503"}}},"pull_request":{"url":"https://api.github.com/repos/openzipkin/zipkin/pulls/503","id":40761412,"html_url":"https://github.com/openzipkin/zipkin/pull/503","diff_url":"https://github.com/openzipkin/zipkin/pull/503.diff","patch_url":"https://github.com/openzipkin/zipkin/pull/503.patch","issue_url":"https://api.github.com/repos/openzipkin/zipkin/issues/503","number":503,"state":"open","locked":false,"title":"Gradle.","user":{"login":"abesto","id":59982,"avatar_url":"https://avatars.githubusercontent.com/u/59982?v=3","gravatar_id":"","url":"https://api.github.com/users/abesto","html_url":"https://github.com/abesto","followers_url":"https://api.github.com/users/abesto/followers","following_url":"https://api.github.com/users/abesto/following{/other_user}","gists_url":"https://api.github.com/users/abesto/gists{/gist_id}","starred_url":"https://api.github.com/users/abesto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abesto/subscriptions","organizations_url":"https://api.github.com/users/abesto/orgs","repos_url":"https://api.github.com/users/abesto/repos","events_url":"https://api.github.com/users/abesto/events{/privacy}","received_events_url":"https://api.github.com/users/abesto/received_events","type":"User","site_admin":false},"body":"### Why?\r\n\r\nBecause the SBT build is a pain.\r\n\r\n### What works\r\n * `./gradlew check` runs tests using [maiflai/gradle-scalatest](https://github.com/maiflai/gradle-scalatest) and they pass.\r\n * `./gradlew build` builds normal jars, and an IDL jar for `zipkin-thrift`.\r\n * `./gradlew distTar` builds a tar distribution for the stand-alone services\r\n * `./gradlew installDist` generates a runnable version of the services (basically the contents of the output of `distTar`)\r\n\r\n### What doesn't work\r\nI'd appreciate thoughts on how important these are.\r\n\r\n * The `doc` project isn't ported yet. I can take a stab at it, but if someone knows what actually happens there, they'll probably have an easier time.\r\n * `BuildProperties` is not ported. Do we need it?\r\n\r\n### What might not work\r\nI'd appreciate experienced eyes on these\r\n\r\n * Maybe some tests are not picked up by Gradle\r\n * Maybe some artifacts don't look like they should (especially IDL and standalone service stuff)\r\n\r\n### Integration test\r\n\r\nI used https://github.com/openzipkin/docker-zipkin/tree/gradle to bring up Zipkin, and sent traces to it using\r\n\r\n```sh\r\n./zipkin-tracegen/build/install/zipkin-tracegen/bin/zipkin-tracegen -scribeDest=$(docker-machine ip):9410\r\n```\r\n\r\nAnd I saw traces :smile: \r\n\r\n### Notes\r\n * The SBT build system is still in place to make comparison easy. Check out the code, play with it locally, try to break it however you can.\r\n * Will squash before merging\r\n\r\n","created_at":"2015-07-24T10:20:11Z","updated_at":"2015-07-27T15:08:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"674d964b00f87c0a493eb10bb2220c22e893d5ba","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openzipkin/zipkin/pulls/503/commits","review_comments_url":"https://api.github.com/repos/openzipkin/zipkin/pulls/503/comments","review_comment_url":"https://api.github.com/repos/openzipkin/zipkin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openzipkin/zipkin/issues/503/comments","statuses_url":"https://api.github.com/repos/openzipkin/zipkin/statuses/5df2d8b306e1d79ee0ac21ec26a76893ff0a4fc3","head":{"label":"openzipkin:gradle","ref":"gradle","sha":"5df2d8b306e1d79ee0ac21ec26a76893ff0a4fc3","user":{"login":"openzipkin","id":11860887,"avatar_url":"https://avatars.githubusercontent.com/u/11860887?v=3","gravatar_id":"","url":"https://api.github.com/users/openzipkin","html_url":"https://github.com/openzipkin","followers_url":"https://api.github.com/users/openzipkin/followers","following_url":"https://api.github.com/users/openzipkin/following{/other_user}","gists_url":"https://api.github.com/users/openzipkin/gists{/gist_id}","starred_url":"https://api.github.com/users/openzipkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openzipkin/subscriptions","organizations_url":"https://api.github.com/users/openzipkin/orgs","repos_url":"https://api.github.com/users/openzipkin/repos","events_url":"https://api.github.com/users/openzipkin/events{/privacy}","received_events_url":"https://api.github.com/users/openzipkin/received_events","type":"Organization","site_admin":false},"repo":{"id":4576305,"name":"zipkin","full_name":"openzipkin/zipkin","owner":{"login":"openzipkin","id":11860887,"avatar_url":"https://avatars.githubusercontent.com/u/11860887?v=3","gravatar_id":"","url":"https://api.github.com/users/openzipkin","html_url":"https://github.com/openzipkin","followers_url":"https://api.github.com/users/openzipkin/followers","following_url":"https://api.github.com/users/openzipkin/following{/other_user}","gists_url":"https://api.github.com/users/openzipkin/gists{/gist_id}","starred_url":"https://api.github.com/users/openzipkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openzipkin/subscriptions","organizations_url":"https://api.github.com/users/openzipkin/orgs","repos_url":"https://api.github.com/users/openzipkin/repos","events_url":"https://api.github.com/users/openzipkin/events{/privacy}","received_events_url":"https://api.github.com/users/openzipkin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openzipkin/zipkin","description":"Zipkin is a distributed tracing system","fork":false,"url":"https://api.github.com/repos/openzipkin/zipkin","forks_url":"https://api.github.com/repos/openzipkin/zipkin/forks","keys_url":"https://api.github.com/repos/openzipkin/zipkin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openzipkin/zipkin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openzipkin/zipkin/teams","hooks_url":"https://api.github.com/repos/openzipkin/zipkin/hooks","issue_events_url":"https://api.github.com/repos/openzipkin/zipkin/issues/events{/number}","events_url":"https://api.github.com/repos/openzipkin/zipkin/events","assignees_url":"https://api.github.com/repos/openzipkin/zipkin/assignees{/user}","branches_url":"https://api.github.com/repos/openzipkin/zipkin/branches{/branch}","tags_url":"https://api.github.com/repos/openzipkin/zipkin/tags","blobs_url":"https://api.github.com/repos/openzipkin/zipkin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openzipkin/zipkin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openzipkin/zipkin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openzipkin/zipkin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openzipkin/zipkin/statuses/{sha}","languages_url":"https://api.github.com/repos/openzipkin/zipkin/languages","stargazers_url":"https://api.github.com/repos/openzipkin/zipkin/stargazers","contributors_url":"https://api.github.com/repos/openzipkin/zipkin/contributors","subscribers_url":"https://api.github.com/repos/openzipkin/zipkin/subscribers","subscription_url":"https://api.github.com/repos/openzipkin/zipkin/subscription","commits_url":"https://api.github.com/repos/openzipkin/zipkin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openzipkin/zipkin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openzipkin/zipkin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openzipkin/zipkin/issues/comments{/number}","contents_url":"https://api.github.com/repos/openzipkin/zipkin/contents/{+path}","compare_url":"https://api.github.com/repos/openzipkin/zipkin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openzipkin/zipkin/merges","archive_url":"https://api.github.com/repos/openzipkin/zipkin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openzipkin/zipkin/downloads","issues_url":"https://api.github.com/repos/openzipkin/zipkin/issues{/number}","pulls_url":"https://api.github.com/repos/openzipkin/zipkin/pulls{/number}","milestones_url":"https://api.github.com/repos/openzipkin/zipkin/milestones{/number}","notifications_url":"https://api.github.com/repos/openzipkin/zipkin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openzipkin/zipkin/labels{/name}","releases_url":"https://api.github.com/repos/openzipkin/zipkin/releases{/id}","created_at":"2012-06-06T18:26:16Z","updated_at":"2015-07-27T09:23:56Z","pushed_at":"2015-07-27T15:07:40Z","git_url":"git://github.com/openzipkin/zipkin.git","ssh_url":"git@github.com:openzipkin/zipkin.git","clone_url":"https://github.com/openzipkin/zipkin.git","svn_url":"https://github.com/openzipkin/zipkin","homepage":"http://openzipkin.github.io/zipkin","size":10663,"stargazers_count":2522,"watchers_count":2522,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":343,"mirror_url":null,"open_issues_count":65,"forks":343,"open_issues":65,"watchers":2522,"default_branch":"master"}},"base":{"label":"openzipkin:master","ref":"master","sha":"81679d99139f6a4221eb7cc7481282dc46361078","user":{"login":"openzipkin","id":11860887,"avatar_url":"https://avatars.githubusercontent.com/u/11860887?v=3","gravatar_id":"","url":"https://api.github.com/users/openzipkin","html_url":"https://github.com/openzipkin","followers_url":"https://api.github.com/users/openzipkin/followers","following_url":"https://api.github.com/users/openzipkin/following{/other_user}","gists_url":"https://api.github.com/users/openzipkin/gists{/gist_id}","starred_url":"https://api.github.com/users/openzipkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openzipkin/subscriptions","organizations_url":"https://api.github.com/users/openzipkin/orgs","repos_url":"https://api.github.com/users/openzipkin/repos","events_url":"https://api.github.com/users/openzipkin/events{/privacy}","received_events_url":"https://api.github.com/users/openzipkin/received_events","type":"Organization","site_admin":false},"repo":{"id":4576305,"name":"zipkin","full_name":"openzipkin/zipkin","owner":{"login":"openzipkin","id":11860887,"avatar_url":"https://avatars.githubusercontent.com/u/11860887?v=3","gravatar_id":"","url":"https://api.github.com/users/openzipkin","html_url":"https://github.com/openzipkin","followers_url":"https://api.github.com/users/openzipkin/followers","following_url":"https://api.github.com/users/openzipkin/following{/other_user}","gists_url":"https://api.github.com/users/openzipkin/gists{/gist_id}","starred_url":"https://api.github.com/users/openzipkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openzipkin/subscriptions","organizations_url":"https://api.github.com/users/openzipkin/orgs","repos_url":"https://api.github.com/users/openzipkin/repos","events_url":"https://api.github.com/users/openzipkin/events{/privacy}","received_events_url":"https://api.github.com/users/openzipkin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openzipkin/zipkin","description":"Zipkin is a distributed tracing system","fork":false,"url":"https://api.github.com/repos/openzipkin/zipkin","forks_url":"https://api.github.com/repos/openzipkin/zipkin/forks","keys_url":"https://api.github.com/repos/openzipkin/zipkin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openzipkin/zipkin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openzipkin/zipkin/teams","hooks_url":"https://api.github.com/repos/openzipkin/zipkin/hooks","issue_events_url":"https://api.github.com/repos/openzipkin/zipkin/issues/events{/number}","events_url":"https://api.github.com/repos/openzipkin/zipkin/events","assignees_url":"https://api.github.com/repos/openzipkin/zipkin/assignees{/user}","branches_url":"https://api.github.com/repos/openzipkin/zipkin/branches{/branch}","tags_url":"https://api.github.com/repos/openzipkin/zipkin/tags","blobs_url":"https://api.github.com/repos/openzipkin/zipkin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openzipkin/zipkin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openzipkin/zipkin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openzipkin/zipkin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openzipkin/zipkin/statuses/{sha}","languages_url":"https://api.github.com/repos/openzipkin/zipkin/languages","stargazers_url":"https://api.github.com/repos/openzipkin/zipkin/stargazers","contributors_url":"https://api.github.com/repos/openzipkin/zipkin/contributors","subscribers_url":"https://api.github.com/repos/openzipkin/zipkin/subscribers","subscription_url":"https://api.github.com/repos/openzipkin/zipkin/subscription","commits_url":"https://api.github.com/repos/openzipkin/zipkin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openzipkin/zipkin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openzipkin/zipkin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openzipkin/zipkin/issues/comments{/number}","contents_url":"https://api.github.com/repos/openzipkin/zipkin/contents/{+path}","compare_url":"https://api.github.com/repos/openzipkin/zipkin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openzipkin/zipkin/merges","archive_url":"https://api.github.com/repos/openzipkin/zipkin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openzipkin/zipkin/downloads","issues_url":"https://api.github.com/repos/openzipkin/zipkin/issues{/number}","pulls_url":"https://api.github.com/repos/openzipkin/zipkin/pulls{/number}","milestones_url":"https://api.github.com/repos/openzipkin/zipkin/milestones{/number}","notifications_url":"https://api.github.com/repos/openzipkin/zipkin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openzipkin/zipkin/labels{/name}","releases_url":"https://api.github.com/repos/openzipkin/zipkin/releases{/id}","created_at":"2012-06-06T18:26:16Z","updated_at":"2015-07-27T09:23:56Z","pushed_at":"2015-07-27T15:07:40Z","git_url":"git://github.com/openzipkin/zipkin.git","ssh_url":"git@github.com:openzipkin/zipkin.git","clone_url":"https://github.com/openzipkin/zipkin.git","svn_url":"https://github.com/openzipkin/zipkin","homepage":"http://openzipkin.github.io/zipkin","size":10663,"stargazers_count":2522,"watchers_count":2522,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":343,"mirror_url":null,"open_issues_count":65,"forks":343,"open_issues":65,"watchers":2522,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openzipkin/zipkin/pulls/503"},"html":{"href":"https://github.com/openzipkin/zipkin/pull/503"},"issue":{"href":"https://api.github.com/repos/openzipkin/zipkin/issues/503"},"comments":{"href":"https://api.github.com/repos/openzipkin/zipkin/issues/503/comments"},"review_comments":{"href":"https://api.github.com/repos/openzipkin/zipkin/pulls/503/comments"},"review_comment":{"href":"https://api.github.com/repos/openzipkin/zipkin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openzipkin/zipkin/pulls/503/commits"},"statuses":{"href":"https://api.github.com/repos/openzipkin/zipkin/statuses/5df2d8b306e1d79ee0ac21ec26a76893ff0a4fc3"}}}}