{"action":"created","comment":{"url":"https://api.github.com/repos/mishoo/UglifyJS2/pulls/comments/42557654","id":42557654,"diff_hunk":"@@ -88,13 +88,14 @@ function OutputStream(options) {\n \n     function make_string(str, quote) {\n         var dq = 0, sq = 0;\n-        str = str.replace(/[\\\\\\b\\f\\n\\r\\t\\x22\\x27\\u2028\\u2029\\0\\ufeff]/g, function(s){\n+        str = str.replace(/[\\\\\\b\\f\\n\\r\\v\\t\\x22\\x27\\u2028\\u2029\\0\\ufeff]/g, function(s){\n             switch (s) {\n               case \"\\\\\": return \"\\\\\\\\\";\n               case \"\\b\": return \"\\\\b\";\n               case \"\\f\": return \"\\\\f\";\n               case \"\\n\": return \"\\\\n\";\n               case \"\\r\": return \"\\\\r\";\n+              case \"\\v\": return \"\\\\v\";","path":"lib/output.js","position":12,"original_position":12,"commit_id":"6b2861e0861968f1f7acae5cf964cc0e6244b0be","original_commit_id":"6b2861e0861968f1f7acae5cf964cc0e6244b0be","user":{"login":"michaelficarra","id":218840,"avatar_url":"https://avatars.githubusercontent.com/u/218840?v=3","gravatar_id":"","url":"https://api.github.com/users/michaelficarra","html_url":"https://github.com/michaelficarra","followers_url":"https://api.github.com/users/michaelficarra/followers","following_url":"https://api.github.com/users/michaelficarra/following{/other_user}","gists_url":"https://api.github.com/users/michaelficarra/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelficarra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelficarra/subscriptions","organizations_url":"https://api.github.com/users/michaelficarra/orgs","repos_url":"https://api.github.com/users/michaelficarra/repos","events_url":"https://api.github.com/users/michaelficarra/events{/privacy}","received_events_url":"https://api.github.com/users/michaelficarra/received_events","type":"User","site_admin":false},"body":"Do we care that this works in old/broken environments? If so, this should be `\"\\\\x0B\"` instead of `\"\\\\v\"`. See https://github.com/mishoo/UglifyJS2/issues/6.","created_at":"2015-10-20T21:33:32Z","updated_at":"2015-10-20T21:33:32Z","html_url":"https://github.com/mishoo/UglifyJS2/pull/833#discussion_r42557654","pull_request_url":"https://api.github.com/repos/mishoo/UglifyJS2/pulls/833","_links":{"self":{"href":"https://api.github.com/repos/mishoo/UglifyJS2/pulls/comments/42557654"},"html":{"href":"https://github.com/mishoo/UglifyJS2/pull/833#discussion_r42557654"},"pull_request":{"href":"https://api.github.com/repos/mishoo/UglifyJS2/pulls/833"}}},"pull_request":{"url":"https://api.github.com/repos/mishoo/UglifyJS2/pulls/833","id":47754919,"html_url":"https://github.com/mishoo/UglifyJS2/pull/833","diff_url":"https://github.com/mishoo/UglifyJS2/pull/833.diff","patch_url":"https://github.com/mishoo/UglifyJS2/pull/833.patch","issue_url":"https://api.github.com/repos/mishoo/UglifyJS2/issues/833","number":833,"state":"closed","locked":false,"title":"Escape \\v like other special characters ","user":{"login":"startswithaj","id":3658522,"avatar_url":"https://avatars.githubusercontent.com/u/3658522?v=3","gravatar_id":"","url":"https://api.github.com/users/startswithaj","html_url":"https://github.com/startswithaj","followers_url":"https://api.github.com/users/startswithaj/followers","following_url":"https://api.github.com/users/startswithaj/following{/other_user}","gists_url":"https://api.github.com/users/startswithaj/gists{/gist_id}","starred_url":"https://api.github.com/users/startswithaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/startswithaj/subscriptions","organizations_url":"https://api.github.com/users/startswithaj/orgs","repos_url":"https://api.github.com/users/startswithaj/repos","events_url":"https://api.github.com/users/startswithaj/events{/privacy}","received_events_url":"https://api.github.com/users/startswithaj/received_events","type":"User","site_admin":false},"body":"In parse.js read_escaped_char reads converts \\v but output.js doesnt escape it back out meaning that actual Vertical Tabs are places in the code when they are read back in by some browsers. Meaning that ofter the sourcemaps are off by 1 or multiple lines depending on how many VT's are in the code.\r\n\r\nAngular.js contains two and when currently minifed and source maped with uglify its breaks the the source maps are off by a couple of lines.\r\n\r\nThis one really does need merging. @ezzatron for pear programming and mostly finding the bug while i ate a pear.","created_at":"2015-10-15T08:02:29Z","updated_at":"2015-10-20T21:33:32Z","closed_at":"2015-10-20T18:10:23Z","merged_at":"2015-10-20T18:10:22Z","merge_commit_sha":"baf20be7180785f1acf007d07a819a4e9af9c42a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mishoo/UglifyJS2/pulls/833/commits","review_comments_url":"https://api.github.com/repos/mishoo/UglifyJS2/pulls/833/comments","review_comment_url":"https://api.github.com/repos/mishoo/UglifyJS2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mishoo/UglifyJS2/issues/833/comments","statuses_url":"https://api.github.com/repos/mishoo/UglifyJS2/statuses/6b2861e0861968f1f7acae5cf964cc0e6244b0be","head":{"label":"startswithaj:verticalTabs","ref":"verticalTabs","sha":"6b2861e0861968f1f7acae5cf964cc0e6244b0be","user":{"login":"startswithaj","id":3658522,"avatar_url":"https://avatars.githubusercontent.com/u/3658522?v=3","gravatar_id":"","url":"https://api.github.com/users/startswithaj","html_url":"https://github.com/startswithaj","followers_url":"https://api.github.com/users/startswithaj/followers","following_url":"https://api.github.com/users/startswithaj/following{/other_user}","gists_url":"https://api.github.com/users/startswithaj/gists{/gist_id}","starred_url":"https://api.github.com/users/startswithaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/startswithaj/subscriptions","organizations_url":"https://api.github.com/users/startswithaj/orgs","repos_url":"https://api.github.com/users/startswithaj/repos","events_url":"https://api.github.com/users/startswithaj/events{/privacy}","received_events_url":"https://api.github.com/users/startswithaj/received_events","type":"User","site_admin":false},"repo":{"id":44301100,"name":"UglifyJS2","full_name":"startswithaj/UglifyJS2","owner":{"login":"startswithaj","id":3658522,"avatar_url":"https://avatars.githubusercontent.com/u/3658522?v=3","gravatar_id":"","url":"https://api.github.com/users/startswithaj","html_url":"https://github.com/startswithaj","followers_url":"https://api.github.com/users/startswithaj/followers","following_url":"https://api.github.com/users/startswithaj/following{/other_user}","gists_url":"https://api.github.com/users/startswithaj/gists{/gist_id}","starred_url":"https://api.github.com/users/startswithaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/startswithaj/subscriptions","organizations_url":"https://api.github.com/users/startswithaj/orgs","repos_url":"https://api.github.com/users/startswithaj/repos","events_url":"https://api.github.com/users/startswithaj/events{/privacy}","received_events_url":"https://api.github.com/users/startswithaj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/startswithaj/UglifyJS2","description":" JavaScript parser / mangler / compressor / beautifier toolkit","fork":true,"url":"https://api.github.com/repos/startswithaj/UglifyJS2","forks_url":"https://api.github.com/repos/startswithaj/UglifyJS2/forks","keys_url":"https://api.github.com/repos/startswithaj/UglifyJS2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/startswithaj/UglifyJS2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/startswithaj/UglifyJS2/teams","hooks_url":"https://api.github.com/repos/startswithaj/UglifyJS2/hooks","issue_events_url":"https://api.github.com/repos/startswithaj/UglifyJS2/issues/events{/number}","events_url":"https://api.github.com/repos/startswithaj/UglifyJS2/events","assignees_url":"https://api.github.com/repos/startswithaj/UglifyJS2/assignees{/user}","branches_url":"https://api.github.com/repos/startswithaj/UglifyJS2/branches{/branch}","tags_url":"https://api.github.com/repos/startswithaj/UglifyJS2/tags","blobs_url":"https://api.github.com/repos/startswithaj/UglifyJS2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/startswithaj/UglifyJS2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/startswithaj/UglifyJS2/git/refs{/sha}","trees_url":"https://api.github.com/repos/startswithaj/UglifyJS2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/startswithaj/UglifyJS2/statuses/{sha}","languages_url":"https://api.github.com/repos/startswithaj/UglifyJS2/languages","stargazers_url":"https://api.github.com/repos/startswithaj/UglifyJS2/stargazers","contributors_url":"https://api.github.com/repos/startswithaj/UglifyJS2/contributors","subscribers_url":"https://api.github.com/repos/startswithaj/UglifyJS2/subscribers","subscription_url":"https://api.github.com/repos/startswithaj/UglifyJS2/subscription","commits_url":"https://api.github.com/repos/startswithaj/UglifyJS2/commits{/sha}","git_commits_url":"https://api.github.com/repos/startswithaj/UglifyJS2/git/commits{/sha}","comments_url":"https://api.github.com/repos/startswithaj/UglifyJS2/comments{/number}","issue_comment_url":"https://api.github.com/repos/startswithaj/UglifyJS2/issues/comments{/number}","contents_url":"https://api.github.com/repos/startswithaj/UglifyJS2/contents/{+path}","compare_url":"https://api.github.com/repos/startswithaj/UglifyJS2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/startswithaj/UglifyJS2/merges","archive_url":"https://api.github.com/repos/startswithaj/UglifyJS2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/startswithaj/UglifyJS2/downloads","issues_url":"https://api.github.com/repos/startswithaj/UglifyJS2/issues{/number}","pulls_url":"https://api.github.com/repos/startswithaj/UglifyJS2/pulls{/number}","milestones_url":"https://api.github.com/repos/startswithaj/UglifyJS2/milestones{/number}","notifications_url":"https://api.github.com/repos/startswithaj/UglifyJS2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/startswithaj/UglifyJS2/labels{/name}","releases_url":"https://api.github.com/repos/startswithaj/UglifyJS2/releases{/id}","created_at":"2015-10-15T07:33:50Z","updated_at":"2015-10-15T07:33:51Z","pushed_at":"2015-10-16T02:09:48Z","git_url":"git://github.com/startswithaj/UglifyJS2.git","ssh_url":"git@github.com:startswithaj/UglifyJS2.git","clone_url":"https://github.com/startswithaj/UglifyJS2.git","svn_url":"https://github.com/startswithaj/UglifyJS2","homepage":"http://lisperator.net/uglifyjs/","size":5137,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mishoo:master","ref":"master","sha":"d5138f74677012b301636cad6d218486e53265e2","user":{"login":"mishoo","id":334725,"avatar_url":"https://avatars.githubusercontent.com/u/334725?v=3","gravatar_id":"","url":"https://api.github.com/users/mishoo","html_url":"https://github.com/mishoo","followers_url":"https://api.github.com/users/mishoo/followers","following_url":"https://api.github.com/users/mishoo/following{/other_user}","gists_url":"https://api.github.com/users/mishoo/gists{/gist_id}","starred_url":"https://api.github.com/users/mishoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mishoo/subscriptions","organizations_url":"https://api.github.com/users/mishoo/orgs","repos_url":"https://api.github.com/users/mishoo/repos","events_url":"https://api.github.com/users/mishoo/events{/privacy}","received_events_url":"https://api.github.com/users/mishoo/received_events","type":"User","site_admin":false},"repo":{"id":5569059,"name":"UglifyJS2","full_name":"mishoo/UglifyJS2","owner":{"login":"mishoo","id":334725,"avatar_url":"https://avatars.githubusercontent.com/u/334725?v=3","gravatar_id":"","url":"https://api.github.com/users/mishoo","html_url":"https://github.com/mishoo","followers_url":"https://api.github.com/users/mishoo/followers","following_url":"https://api.github.com/users/mishoo/following{/other_user}","gists_url":"https://api.github.com/users/mishoo/gists{/gist_id}","starred_url":"https://api.github.com/users/mishoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mishoo/subscriptions","organizations_url":"https://api.github.com/users/mishoo/orgs","repos_url":"https://api.github.com/users/mishoo/repos","events_url":"https://api.github.com/users/mishoo/events{/privacy}","received_events_url":"https://api.github.com/users/mishoo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mishoo/UglifyJS2","description":" JavaScript parser / mangler / compressor / beautifier toolkit","fork":false,"url":"https://api.github.com/repos/mishoo/UglifyJS2","forks_url":"https://api.github.com/repos/mishoo/UglifyJS2/forks","keys_url":"https://api.github.com/repos/mishoo/UglifyJS2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mishoo/UglifyJS2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mishoo/UglifyJS2/teams","hooks_url":"https://api.github.com/repos/mishoo/UglifyJS2/hooks","issue_events_url":"https://api.github.com/repos/mishoo/UglifyJS2/issues/events{/number}","events_url":"https://api.github.com/repos/mishoo/UglifyJS2/events","assignees_url":"https://api.github.com/repos/mishoo/UglifyJS2/assignees{/user}","branches_url":"https://api.github.com/repos/mishoo/UglifyJS2/branches{/branch}","tags_url":"https://api.github.com/repos/mishoo/UglifyJS2/tags","blobs_url":"https://api.github.com/repos/mishoo/UglifyJS2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mishoo/UglifyJS2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mishoo/UglifyJS2/git/refs{/sha}","trees_url":"https://api.github.com/repos/mishoo/UglifyJS2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mishoo/UglifyJS2/statuses/{sha}","languages_url":"https://api.github.com/repos/mishoo/UglifyJS2/languages","stargazers_url":"https://api.github.com/repos/mishoo/UglifyJS2/stargazers","contributors_url":"https://api.github.com/repos/mishoo/UglifyJS2/contributors","subscribers_url":"https://api.github.com/repos/mishoo/UglifyJS2/subscribers","subscription_url":"https://api.github.com/repos/mishoo/UglifyJS2/subscription","commits_url":"https://api.github.com/repos/mishoo/UglifyJS2/commits{/sha}","git_commits_url":"https://api.github.com/repos/mishoo/UglifyJS2/git/commits{/sha}","comments_url":"https://api.github.com/repos/mishoo/UglifyJS2/comments{/number}","issue_comment_url":"https://api.github.com/repos/mishoo/UglifyJS2/issues/comments{/number}","contents_url":"https://api.github.com/repos/mishoo/UglifyJS2/contents/{+path}","compare_url":"https://api.github.com/repos/mishoo/UglifyJS2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mishoo/UglifyJS2/merges","archive_url":"https://api.github.com/repos/mishoo/UglifyJS2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mishoo/UglifyJS2/downloads","issues_url":"https://api.github.com/repos/mishoo/UglifyJS2/issues{/number}","pulls_url":"https://api.github.com/repos/mishoo/UglifyJS2/pulls{/number}","milestones_url":"https://api.github.com/repos/mishoo/UglifyJS2/milestones{/number}","notifications_url":"https://api.github.com/repos/mishoo/UglifyJS2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mishoo/UglifyJS2/labels{/name}","releases_url":"https://api.github.com/repos/mishoo/UglifyJS2/releases{/id}","created_at":"2012-08-27T09:31:03Z","updated_at":"2015-10-20T10:37:22Z","pushed_at":"2015-10-20T20:01:12Z","git_url":"git://github.com/mishoo/UglifyJS2.git","ssh_url":"git@github.com:mishoo/UglifyJS2.git","clone_url":"https://github.com/mishoo/UglifyJS2.git","svn_url":"https://github.com/mishoo/UglifyJS2","homepage":"http://lisperator.net/uglifyjs/","size":5137,"stargazers_count":3938,"watchers_count":3938,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":451,"mirror_url":null,"open_issues_count":223,"forks":451,"open_issues":223,"watchers":3938,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mishoo/UglifyJS2/pulls/833"},"html":{"href":"https://github.com/mishoo/UglifyJS2/pull/833"},"issue":{"href":"https://api.github.com/repos/mishoo/UglifyJS2/issues/833"},"comments":{"href":"https://api.github.com/repos/mishoo/UglifyJS2/issues/833/comments"},"review_comments":{"href":"https://api.github.com/repos/mishoo/UglifyJS2/pulls/833/comments"},"review_comment":{"href":"https://api.github.com/repos/mishoo/UglifyJS2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mishoo/UglifyJS2/pulls/833/commits"},"statuses":{"href":"https://api.github.com/repos/mishoo/UglifyJS2/statuses/6b2861e0861968f1f7acae5cf964cc0e6244b0be"}}}}