{"push_id":591098976,"size":9,"distinct_size":9,"ref":"refs/heads/master","head":"bba9cd5097e68a8d9dc46e93e910e0271e24395c","before":"a06f8b90897bb47a85361744c2555ab385d67c66","commits":[{"sha":"968ecf79e8235e3521bde6fc81f8b9f30e12214e","author":{"email":"40fc0cb507030a081616f25547d9cd1b104aae47@apple.com","name":"bfulgham@apple.com"},"message":"Move scroll animating functions from ScrollAnimator to ScrollController\nhttps://bugs.webkit.org/show_bug.cgi?id=142102\n<rdar://problem/20007161>\n\nReviewed by Simon Fraser.\n\nSource/WebCore:\n\nTested by platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-mainframe-zoom.html.\n\nDo some refactoring of the various scrolling classes:\n1. Consolidate animation times to RunLoop::Timer instead of a combination of WebCore::Timer\n   and CFRunLoopTimers. Do this for Scroll Snap Point and Rubberband animations.\n2. Move ScrollController from platform/mac to platform/cocoa to enable sharing with iOS.\n3. Move code from ScrollAnimator{Mac} -> ScrollController.\n4. Rename scrollOffsetInAxis -> scrollOffsetOnAxis\n5. Rename immediateScrollInAxis -> immediateScrollOnAxis\n\n* WebCore.xcodeproj/project.pbxproj: Move ScrollController to 'platform/cocoa'\n* page/mac/EventHandlerMac.mm: Make sure the scroll controller is notified of end-of-scroll\nevents, just as is done for the \"event not handled\" case in EventHandler.cpp. \n(WebCore::EventHandler::platformCompleteWheelEvent):\n* page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.h: Remove timer and some delegate\nmethods, now that ScrollController is controlling this state.\n* page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm:\n(WebCore::ScrollingTreeFrameScrollingNodeMac::~ScrollingTreeFrameScrollingNodeMac): We no longer\nneed to clean up the CFRunLoopTimer.\n(WebCore::ScrollingTreeFrameScrollingNodeMac::stopSnapRubberbandTimer): Make sure scroll\nstate is updated after rubber band snap.\n(WebCore::ScrollingTreeFrameScrollingNodeMac::scrollOffsetOnAxis): Add temporary stub needed\nuntil Bug1973 is completed.).\n(WebCore::ScrollingTreeFrameScrollingNodeMac::immediateScrollOnAxis): Ditto.\n(WebCore::ScrollingTreeFrameScrollingNodeMac::startSnapRubberbandTimer): Deleted.\n* platform/ScrollAnimator.cpp:\n(WebCore::ScrollAnimator::ScrollAnimator):\n(WebCore::ScrollAnimator::processWheelEventForScrollSnap): Just call the ScrollController method.\n(WebCore::ScrollAnimator::handleWheelEvent): Ditto.\n(WebCore::ScrollAnimator::updateScrollAnimatorsAndTimers): Ditto.\n(WebCore::ScrollAnimator::scrollOffsetOnAxis): Renamed from scrollOffsetInAxis.\n(WebCore::ScrollAnimator::immediateScrollOnAxis): Renamed from immediateScrollInAxis.\n(WebCore::ScrollAnimator::scrollOffsetInAxis): Deleted.\n(WebCore::ScrollAnimator::immediateScrollInAxis): Deleted.\n(WebCore::ScrollAnimator::startScrollSnapTimer): Deleted.\n(WebCore::ScrollAnimator::stopScrollSnapTimer): Deleted.\n(WebCore::ScrollAnimator::horizontalScrollSnapTimerFired): Deleted.\n(WebCore::ScrollAnimator::verticalScrollSnapTimerFired): Deleted.\n* platform/ScrollAnimator.h:\n* platform/cocoa/ScrollController.h: Copied from platform/mac/ScrollController.h.\n(WebCore::ScrollControllerClient::startSnapRubberbandTimer):\n(WebCore::ScrollControllerClient::stopSnapRubberbandTimer):\n(WebCore::ScrollControllerClient::startScrollSnapTimer):\n(WebCore::ScrollControllerClient::stopScrollSnapTimer):\n* platform/cocoa/ScrollController.mm: Copied from platform/mac/ScrollController.mm.\n(WebCore::ScrollController::ScrollController): Update to initialize new timers.\n(WebCore::ScrollController::handleWheelEvent): Update to handle Scroll Snap Point events.\n(WebCore::ScrollController::startSnapRubberbandTimer): Added.\n(WebCore::ScrollController::stopSnapRubberbandTimer): Manage animation timers locally, do not\nrequire client to maintain timers.\n(WebCore::ScrollController::snapRubberBand): Ditto.\n(WebCore::ScrollController::processWheelEventForScrollSnap): Added. (Moved from ScrollAnimatorMac)\n(WebCore::ScrollController::updateScrollAnimatorsAndTimers): Ditto. Also updated to use RunLoop::Timer.\n(WebCore::ScrollController::startScrollSnapTimer): Ditto. Also updated to use RunLoop::Timer.\n(WebCore::ScrollController::stopScrollSnapTimer): Ditto. Also updated to use RunLoop::Timer.\n(WebCore::ScrollController::horizontalScrollSnapTimerFired): Ditto.\n(WebCore::ScrollController::verticalScrollSnapTimerFired): Ditto.\n(WebCore::ScrollController::scrollOffsetOnAxis): Moved from ScrollAnimatorMac.\n(WebCore::ScrollController::immediateScrollOnAxis): Ditto.\n* platform/mac/AxisScrollSnapAnimator.h: Rename methods from 'InAxis' to 'OnAxis'\n* platform/mac/AxisScrollSnapAnimator.mm:\n(WebCore::AxisScrollSnapAnimator::handleWheelEvent): Update for 'InAxis' to 'OnAxis' renaming.\n(WebCore::AxisScrollSnapAnimator::scrollSnapAnimationUpdate): Ditto.\n(WebCore::AxisScrollSnapAnimator::beginScrollSnapAnimation): Ditto.\n(WebCore::AxisScrollSnapAnimator::computeSnapDelta): Ditto.\n(WebCore::AxisScrollSnapAnimator::computeGlideDelta): Ditto.\n* platform/mac/ScrollAnimatorMac.h:\n* platform/mac/ScrollAnimatorMac.mm:\n(WebCore::ScrollAnimatorMac::ScrollAnimatorMac): Remove unused Rubberband timers (now that this is\ncontrolled in the ScrollController)\n(WebCore::ScrollAnimatorMac::startSnapRubberbandTimer): Deleted.\n(WebCore::ScrollAnimatorMac::stopSnapRubberbandTimer): Deleted.\n(WebCore::ScrollAnimatorMac::snapRubberBandTimerFired): Deleted.\n* platform/mac/ScrollController.h: Removed.\n* platform/mac/ScrollController.mm: Removed.\n\nLayoutTests:\n\nAdd a new test that confirms that rubberband snap animations work properly when combined\nwith text zooming.\n\n* platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-mainframe-zoom-expected.txt: Added.\n* platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-mainframe-zoom.html: Added.\n\n\ngit-svn-id: http://svn.webkit.org/repository/webkit/trunk@180974 268f45cc-cd09-0410-ab3c-d52691b4dbfc","distinct":true,"url":"https://api.github.com/repos/WebKit/webkit/commits/968ecf79e8235e3521bde6fc81f8b9f30e12214e"},{"sha":"26ef5a686f8bf9e61799cee1204bff4300195c32","author":{"email":"f6a40302e70d3875826ddafd7e450bcee2d7be56@apple.com","name":"timothy_horton@apple.com"},"message":"<attachment> label can get very wide, doesn't wrap/truncate\nhttps://bugs.webkit.org/show_bug.cgi?id=142214\n<rdar://problem/19982499>\n\n* fast/attachment/attachment-label-highlight-expected.png: Added.\n* fast/attachment/attachment-label-highlight-expected.txt: Added.\nAdd (empty) platform independent baselines.\n\n\ngit-svn-id: http://svn.webkit.org/repository/webkit/trunk@180975 268f45cc-cd09-0410-ab3c-d52691b4dbfc","distinct":true,"url":"https://api.github.com/repos/WebKit/webkit/commits/26ef5a686f8bf9e61799cee1204bff4300195c32"},{"sha":"4870f14acc575dee438d6ddd0e7f882705dbceaa","author":{"email":"40fc0cb507030a081616f25547d9cd1b104aae47@apple.com","name":"bfulgham@apple.com"},"message":"[Win] Add baseline for new legacy-event-handler test.\n\n* platform/win/fast/dom/legacy-event-handler-attributes-expected.txt: Added.\n\n\n\ngit-svn-id: http://svn.webkit.org/repository/webkit/trunk@180976 268f45cc-cd09-0410-ab3c-d52691b4dbfc","distinct":true,"url":"https://api.github.com/repos/WebKit/webkit/commits/4870f14acc575dee438d6ddd0e7f882705dbceaa"},{"sha":"674a041ac9a94db2854260b88e022aba51dabbb1","author":{"email":"0466057d80f1c72346801a071a5f40ef58eb3de6@cs.washington.edu","name":"burg@cs.washington.edu"},"message":"Web Inspector: selecting overview timeline tree elements without source locations doesn't update selection components\nhttps://bugs.webkit.org/show_bug.cgi?id=142248\n\nReviewed by Timothy Hatcher.\n\nAdd a missing event dispatch to trigger recalculation of path components when showing the overview timeline view.\n\n* UserInterface/Views/OverviewTimelineView.js:\n(WebInspector.OverviewTimelineView.prototype._treeElementSelected):\n\n\ngit-svn-id: http://svn.webkit.org/repository/webkit/trunk@180977 268f45cc-cd09-0410-ab3c-d52691b4dbfc","distinct":true,"url":"https://api.github.com/repos/WebKit/webkit/commits/674a041ac9a94db2854260b88e022aba51dabbb1"},{"sha":"364f0cfb7f4d3ad32b75f8075d506b61dedd449e","author":{"email":"ee265a39ce1096c7aa719c384cf7e22c626df10a@apple.com","name":"achristensen@apple.com"},"message":"Prepare to use CSS selectors in content extensions.\nhttps://bugs.webkit.org/show_bug.cgi?id=142227\n\nReviewed by Benjamin Poulain.\n\nSource/WebCore:\n\nTest: http/tests/usercontentfilter/css-display-none.html\n\n* CMakeLists.txt:\n* WebCore.xcodeproj/project.pbxproj:\n* contentextensions/ContentExtensionActions.h: Added.\n* contentextensions/ContentExtensionRule.cpp:\n(WebCore::ContentExtensions::Action::deserialize):\n* contentextensions/ContentExtensionRule.h:\n(WebCore::ContentExtensions::Action::Action):\n(WebCore::ContentExtensions::Action::type):\n(WebCore::ContentExtensions::Action::cssSelector):\n* contentextensions/ContentExtensionsBackend.cpp:\n(WebCore::ContentExtensions::ContentExtensionsBackend::serializeActions):\nPut action descriptions into a compact format in a Vector \nto be able to be put into one block of shared read-only memory.\n(WebCore::ContentExtensions::ContentExtensionsBackend::setRuleList):\nPut an index of the beginning of the description into the NFA instead of the index of the rule\nbecause we will be sharing the descriptions of the actions and not the rules.\n(WebCore::ContentExtensions::ContentExtensionsBackend::actionsForURL):\n(WebCore::ContentExtensions::ContentExtensionsBackend::actionForURL): Deleted.\nReturn a vector of actions to be able to do multiple actions for one URL.\n* contentextensions/ContentExtensionsBackend.h:\n* contentextensions/ContentExtensionsManager.cpp:\n(WebCore::ContentExtensions::ExtensionsManager::loadTrigger):\n(WebCore::ContentExtensions::ExtensionsManager::loadAction):\nAdded the css-display-none action type, which requires a selector.\n(WebCore::ContentExtensions::ExtensionsManager::loadRule):\n* loader/cache/CachedResourceLoader.cpp:\n(WebCore::CachedResourceLoader::requestResource):\n* page/UserContentController.cpp:\n(WebCore::UserContentController::actionsForURL):\n(WebCore::UserContentController::actionForURL): Deleted.\n* page/UserContentController.h:\n\nLayoutTests:\n\n* http/tests/usercontentfilter/css-display-none-expected.txt: Added.\n* http/tests/usercontentfilter/css-display-none.html: Added.\n* http/tests/usercontentfilter/css-display-none.html.json: Added.\n\n\n\ngit-svn-id: http://svn.webkit.org/repository/webkit/trunk@180978 268f45cc-cd09-0410-ab3c-d52691b4dbfc","distinct":true,"url":"https://api.github.com/repos/WebKit/webkit/commits/364f0cfb7f4d3ad32b75f8075d506b61dedd449e"},{"sha":"79c55447c4bcad6c0f8f7943fc972ecfa1ed6365","author":{"email":"ee265a39ce1096c7aa719c384cf7e22c626df10a@apple.com","name":"achristensen@apple.com"},"message":"[Win] Unreviewed build fix.\n\n* WebCore.vcxproj/WebCoreIncludeCommon.props:\nInclude contentextensions subdirectory.\n\n\n\ngit-svn-id: http://svn.webkit.org/repository/webkit/trunk@180979 268f45cc-cd09-0410-ab3c-d52691b4dbfc","distinct":true,"url":"https://api.github.com/repos/WebKit/webkit/commits/79c55447c4bcad6c0f8f7943fc972ecfa1ed6365"},{"sha":"7baeae90f14058df5102390f92c84976b5a48cb4","author":{"email":"9dddda5b47459e138db3e48e9e36e3396d29c6c1@apple.com","name":"ddkilzer@apple.com"},"message":"check-webkit-style: Add exception for FrameworkSoftLink.h header order\n<http://webkit.org/b/141872>\n\nReviewed by Alex Christensen.\n\n* Scripts/webkitpy/style/checkers/cpp.py: Remove unneeded\nsemi-colons in various places and fix whitespace.\n(_IncludeState): Add _SOFT_LINK_HEADER and _SOFT_LINK_SECTION\nconstants.\n(_IncludeState.__init__): Add self._visited_soft_link_section\nboolean state variable.\n(_IncludeState.visited_soft_link_section): Getter for\nself._visited_soft_link_section.\n(_IncludeState.check_next_include_order): Update state machine\nfor soft-link headers.  Add check that soft-link headers always\nappear last.\n(_classify_include): Add check for soft-link header type.\n(check_include_line): Return early if there is a soft-link\nheader error.\n\n* Scripts/webkitpy/style/checkers/cpp_unittest.py:\n(OrderOfIncludesTest.test_public_primary_header): Add tests for\nincluding soft-link headers.\n(OrderOfIncludesTest.test_classify_include): Add test for\n_SOFT_LINK_HEADER type.\n\n\ngit-svn-id: http://svn.webkit.org/repository/webkit/trunk@180981 268f45cc-cd09-0410-ab3c-d52691b4dbfc","distinct":true,"url":"https://api.github.com/repos/WebKit/webkit/commits/7baeae90f14058df5102390f92c84976b5a48cb4"},{"sha":"976bb7d133a20e1a4ad1a99527f451aa2b79abd5","author":{"email":"083d44ce61b1f946a3aa6fbd704954e0195d0658@apple.com","name":"cdumez@apple.com"},"message":"[WK2] Fix memory leak in _getCookieHeadersForTask\nhttps://bugs.webkit.org/show_bug.cgi?id=142245\n\nReviewed by Alexey Proskuryakov.\n\nFix memory leak in _getCookieHeadersForTask. We are leaking the CFDictionary\nreturned by webKitCookieStorageCopyRequestHeaderFieldsForURL().\n\nThis patch addresses the issue by storing the return CFDictionary in a\nRetainPtr<CFDictionaryRef>.\n\n* Shared/mac/CookieStorageShim.mm:\n(-[WKNSURLSessionLocal _getCookieHeadersForTask:completionHandler:]):\n\n\ngit-svn-id: http://svn.webkit.org/repository/webkit/trunk@180982 268f45cc-cd09-0410-ab3c-d52691b4dbfc","distinct":true,"url":"https://api.github.com/repos/WebKit/webkit/commits/976bb7d133a20e1a4ad1a99527f451aa2b79abd5"},{"sha":"bba9cd5097e68a8d9dc46e93e910e0271e24395c","author":{"email":"9dddda5b47459e138db3e48e9e36e3396d29c6c1@apple.com","name":"ddkilzer@apple.com"},"message":"[iOS] Crash logs can't be found on ios-simulator because WebKitTestRunner returns the wrong process name\n<http://webkit.org/b/142243>\n\nReviewed by Alexey Proskuryakov.\n\n* WebKitTestRunner/TestController.cpp:\n(WTR::TestController::webProcessName):\n(WTR::TestController::networkProcessName):\n- Return the same process name on iOS and Mac because they both\n  use the same process name for local engineering builds.\n\n\ngit-svn-id: http://svn.webkit.org/repository/webkit/trunk@180983 268f45cc-cd09-0410-ab3c-d52691b4dbfc","distinct":true,"url":"https://api.github.com/repos/WebKit/webkit/commits/bba9cd5097e68a8d9dc46e93e910e0271e24395c"}]}