{"action":"created","comment":{"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments/35193276","id":35193276,"diff_hunk":"@@ -11224,7 +11225,7 @@ class CRoxieServerXmlWriteActivity : public CRoxieServerDiskWriteActivity\n         CRoxieServerDiskWriteActivity::start(parentExtractSize, parentExtract, paused);\n         OwnedRoxieString xmlpath(xmlHelper.getXmlIteratorPath());\n         if (!xmlpath)\n-            rowTag.set(\"Row\");\n+            rowTag.set(DEFAULTXMLHEADER);","path":"roxie/ccd/ccdserver.cpp","position":13,"original_position":13,"commit_id":"f0b4f60ad683c98be79c61082cc40c75877e0979","original_commit_id":"f0b4f60ad683c98be79c61082cc40c75877e0979","user":{"login":"AttilaVamos","id":3518475,"avatar_url":"https://avatars.githubusercontent.com/u/3518475?v=3","gravatar_id":"","url":"https://api.github.com/users/AttilaVamos","html_url":"https://github.com/AttilaVamos","followers_url":"https://api.github.com/users/AttilaVamos/followers","following_url":"https://api.github.com/users/AttilaVamos/following{/other_user}","gists_url":"https://api.github.com/users/AttilaVamos/gists{/gist_id}","starred_url":"https://api.github.com/users/AttilaVamos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AttilaVamos/subscriptions","organizations_url":"https://api.github.com/users/AttilaVamos/orgs","repos_url":"https://api.github.com/users/AttilaVamos/repos","events_url":"https://api.github.com/users/AttilaVamos/events{/privacy}","received_events_url":"https://api.github.com/users/AttilaVamos/received_events","type":"User","site_admin":false},"body":"Yes, you are right. (That could be a kind of midnight mistake.)","created_at":"2015-07-22T08:58:53Z","updated_at":"2015-07-22T08:58:53Z","html_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/7265#discussion_r35193276","pull_request_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/7265","_links":{"self":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments/35193276"},"html":{"href":"https://github.com/hpcc-systems/HPCC-Platform/pull/7265#discussion_r35193276"},"pull_request":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/7265"}}},"pull_request":{"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/7265","id":34530389,"html_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/7265","diff_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/7265.diff","patch_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/7265.patch","issue_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/7265","number":7265,"state":"open","locked":false,"title":"HPCC-13331 Should be able to despray XML without rowTag specification.","user":{"login":"AttilaVamos","id":3518475,"avatar_url":"https://avatars.githubusercontent.com/u/3518475?v=3","gravatar_id":"","url":"https://api.github.com/users/AttilaVamos","html_url":"https://github.com/AttilaVamos","followers_url":"https://api.github.com/users/AttilaVamos/followers","following_url":"https://api.github.com/users/AttilaVamos/following{/other_user}","gists_url":"https://api.github.com/users/AttilaVamos/gists{/gist_id}","starred_url":"https://api.github.com/users/AttilaVamos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AttilaVamos/subscriptions","organizations_url":"https://api.github.com/users/AttilaVamos/orgs","repos_url":"https://api.github.com/users/AttilaVamos/repos","events_url":"https://api.github.com/users/AttilaVamos/events{/privacy}","received_events_url":"https://api.github.com/users/AttilaVamos/received_events","type":"User","site_admin":false},"body":"Add code to store xml header/footer lenght into the file part metadata on\r\nhthor, thor and roxie when:\r\n- spray xml file or files (with different xml header/footer)\r\n- output data in XML format w/wo custom header/footer/ row tag\r\n\r\nAdd code to use stored header/footer lenght in despray XML data\r\n\r\nSigned-off-by: Attila Vamos <attila.vamos@gmail.com>","created_at":"2015-05-01T10:14:11Z","updated_at":"2015-07-22T08:58:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e03a0ace3a7f741eb38b95f52cfc6ccb97a91961","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/7265/commits","review_comments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/7265/comments","review_comment_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/7265/comments","statuses_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/statuses/f0b4f60ad683c98be79c61082cc40c75877e0979","head":{"label":"AttilaVamos:HPCC-13331-improvement-5_4","ref":"HPCC-13331-improvement-5_4","sha":"f0b4f60ad683c98be79c61082cc40c75877e0979","user":{"login":"AttilaVamos","id":3518475,"avatar_url":"https://avatars.githubusercontent.com/u/3518475?v=3","gravatar_id":"","url":"https://api.github.com/users/AttilaVamos","html_url":"https://github.com/AttilaVamos","followers_url":"https://api.github.com/users/AttilaVamos/followers","following_url":"https://api.github.com/users/AttilaVamos/following{/other_user}","gists_url":"https://api.github.com/users/AttilaVamos/gists{/gist_id}","starred_url":"https://api.github.com/users/AttilaVamos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AttilaVamos/subscriptions","organizations_url":"https://api.github.com/users/AttilaVamos/orgs","repos_url":"https://api.github.com/users/AttilaVamos/repos","events_url":"https://api.github.com/users/AttilaVamos/events{/privacy}","received_events_url":"https://api.github.com/users/AttilaVamos/received_events","type":"User","site_admin":false},"repo":{"id":9005214,"name":"HPCC-Platform","full_name":"AttilaVamos/HPCC-Platform","owner":{"login":"AttilaVamos","id":3518475,"avatar_url":"https://avatars.githubusercontent.com/u/3518475?v=3","gravatar_id":"","url":"https://api.github.com/users/AttilaVamos","html_url":"https://github.com/AttilaVamos","followers_url":"https://api.github.com/users/AttilaVamos/followers","following_url":"https://api.github.com/users/AttilaVamos/following{/other_user}","gists_url":"https://api.github.com/users/AttilaVamos/gists{/gist_id}","starred_url":"https://api.github.com/users/AttilaVamos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AttilaVamos/subscriptions","organizations_url":"https://api.github.com/users/AttilaVamos/orgs","repos_url":"https://api.github.com/users/AttilaVamos/repos","events_url":"https://api.github.com/users/AttilaVamos/events{/privacy}","received_events_url":"https://api.github.com/users/AttilaVamos/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AttilaVamos/HPCC-Platform","description":"IMPORTANT - Issue tracking has been migrated to JIRA - use your github ID and password reset mechanism to log in","fork":true,"url":"https://api.github.com/repos/AttilaVamos/HPCC-Platform","forks_url":"https://api.github.com/repos/AttilaVamos/HPCC-Platform/forks","keys_url":"https://api.github.com/repos/AttilaVamos/HPCC-Platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AttilaVamos/HPCC-Platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AttilaVamos/HPCC-Platform/teams","hooks_url":"https://api.github.com/repos/AttilaVamos/HPCC-Platform/hooks","issue_events_url":"https://api.github.com/repos/AttilaVamos/HPCC-Platform/issues/events{/number}","events_url":"https://api.github.com/repos/AttilaVamos/HPCC-Platform/events","assignees_url":"https://api.github.com/repos/AttilaVamos/HPCC-Platform/assignees{/user}","branches_url":"https://api.github.com/repos/AttilaVamos/HPCC-Platform/branches{/branch}","tags_url":"https://api.github.com/repos/AttilaVamos/HPCC-Platform/tags","blobs_url":"https://api.github.com/repos/AttilaVamos/HPCC-Platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AttilaVamos/HPCC-Platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AttilaVamos/HPCC-Platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/AttilaVamos/HPCC-Platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AttilaVamos/HPCC-Platform/statuses/{sha}","languages_url":"https://api.github.com/repos/AttilaVamos/HPCC-Platform/languages","stargazers_url":"https://api.github.com/repos/AttilaVamos/HPCC-Platform/stargazers","contributors_url":"https://api.github.com/repos/AttilaVamos/HPCC-Platform/contributors","subscribers_url":"https://api.github.com/repos/AttilaVamos/HPCC-Platform/subscribers","subscription_url":"https://api.github.com/repos/AttilaVamos/HPCC-Platform/subscription","commits_url":"https://api.github.com/repos/AttilaVamos/HPCC-Platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/AttilaVamos/HPCC-Platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/AttilaVamos/HPCC-Platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/AttilaVamos/HPCC-Platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/AttilaVamos/HPCC-Platform/contents/{+path}","compare_url":"https://api.github.com/repos/AttilaVamos/HPCC-Platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AttilaVamos/HPCC-Platform/merges","archive_url":"https://api.github.com/repos/AttilaVamos/HPCC-Platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AttilaVamos/HPCC-Platform/downloads","issues_url":"https://api.github.com/repos/AttilaVamos/HPCC-Platform/issues{/number}","pulls_url":"https://api.github.com/repos/AttilaVamos/HPCC-Platform/pulls{/number}","milestones_url":"https://api.github.com/repos/AttilaVamos/HPCC-Platform/milestones{/number}","notifications_url":"https://api.github.com/repos/AttilaVamos/HPCC-Platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AttilaVamos/HPCC-Platform/labels{/name}","releases_url":"https://api.github.com/repos/AttilaVamos/HPCC-Platform/releases{/id}","created_at":"2013-03-25T12:04:47Z","updated_at":"2015-05-08T09:58:18Z","pushed_at":"2015-07-21T17:40:32Z","git_url":"git://github.com/AttilaVamos/HPCC-Platform.git","ssh_url":"git@github.com:AttilaVamos/HPCC-Platform.git","clone_url":"https://github.com/AttilaVamos/HPCC-Platform.git","svn_url":"https://github.com/AttilaVamos/HPCC-Platform","homepage":"track.hpccsystems.com","size":153548,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hpcc-systems:candidate-5.4.0","ref":"candidate-5.4.0","sha":"6b718792fda11b3b2d85749afd796ccb5eefc3a6","user":{"login":"hpcc-systems","id":900867,"avatar_url":"https://avatars.githubusercontent.com/u/900867?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcc-systems","html_url":"https://github.com/hpcc-systems","followers_url":"https://api.github.com/users/hpcc-systems/followers","following_url":"https://api.github.com/users/hpcc-systems/following{/other_user}","gists_url":"https://api.github.com/users/hpcc-systems/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcc-systems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcc-systems/subscriptions","organizations_url":"https://api.github.com/users/hpcc-systems/orgs","repos_url":"https://api.github.com/users/hpcc-systems/repos","events_url":"https://api.github.com/users/hpcc-systems/events{/privacy}","received_events_url":"https://api.github.com/users/hpcc-systems/received_events","type":"Organization","site_admin":false},"repo":{"id":2030681,"name":"HPCC-Platform","full_name":"hpcc-systems/HPCC-Platform","owner":{"login":"hpcc-systems","id":900867,"avatar_url":"https://avatars.githubusercontent.com/u/900867?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcc-systems","html_url":"https://github.com/hpcc-systems","followers_url":"https://api.github.com/users/hpcc-systems/followers","following_url":"https://api.github.com/users/hpcc-systems/following{/other_user}","gists_url":"https://api.github.com/users/hpcc-systems/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcc-systems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcc-systems/subscriptions","organizations_url":"https://api.github.com/users/hpcc-systems/orgs","repos_url":"https://api.github.com/users/hpcc-systems/repos","events_url":"https://api.github.com/users/hpcc-systems/events{/privacy}","received_events_url":"https://api.github.com/users/hpcc-systems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hpcc-systems/HPCC-Platform","description":"IMPORTANT - Issue tracking has been migrated to JIRA - use your github ID and password reset mechanism to log in","fork":false,"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform","forks_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/forks","keys_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/teams","hooks_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/hooks","issue_events_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/events{/number}","events_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/events","assignees_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/assignees{/user}","branches_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/branches{/branch}","tags_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/tags","blobs_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/statuses/{sha}","languages_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/languages","stargazers_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/stargazers","contributors_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/contributors","subscribers_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/subscribers","subscription_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/subscription","commits_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/contents/{+path}","compare_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/merges","archive_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/downloads","issues_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues{/number}","pulls_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls{/number}","milestones_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/milestones{/number}","notifications_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/labels{/name}","releases_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/releases{/id}","created_at":"2011-07-11T14:29:51Z","updated_at":"2015-07-21T10:02:19Z","pushed_at":"2015-07-22T08:56:34Z","git_url":"git://github.com/hpcc-systems/HPCC-Platform.git","ssh_url":"git@github.com:hpcc-systems/HPCC-Platform.git","clone_url":"https://github.com/hpcc-systems/HPCC-Platform.git","svn_url":"https://github.com/hpcc-systems/HPCC-Platform","homepage":"track.hpccsystems.com","size":339535,"stargazers_count":253,"watchers_count":253,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":118,"mirror_url":null,"open_issues_count":425,"forks":118,"open_issues":425,"watchers":253,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/7265"},"html":{"href":"https://github.com/hpcc-systems/HPCC-Platform/pull/7265"},"issue":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/7265"},"comments":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/7265/comments"},"review_comments":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/7265/comments"},"review_comment":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/7265/commits"},"statuses":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/statuses/f0b4f60ad683c98be79c61082cc40c75877e0979"}}}}