{"action":"created","comment":{"url":"https://api.github.com/repos/apache/nifi/pulls/comments/45942561","id":45942561,"diff_hunk":"@@ -102,6 +177,94 @@ protected PropertyDescriptor getSupportedDynamicPropertyDescriptor(final String\n             .build();\r\n     }\r\n \r\n+    protected File getPersistenceFile() {\r\n+        return new File(PERSISTENCE_ROOT + getIdentifier());\r\n+    }\r\n+\r\n+    @Override\r\n+    public void onPropertyModified(final PropertyDescriptor descriptor, final String oldValue, final String newValue) {\r\n+        if (descriptor.equals(KEY)\r\n+                || descriptor.equals(BUCKET)\r\n+                || descriptor.equals(ENDPOINT_OVERRIDE)\r\n+                || descriptor.equals(STORAGE_CLASS)\r\n+                || descriptor.equals(REGION)) {\r\n+            destroyState();\r\n+        }\r\n+    }\r\n+\r\n+    protected MultipartState getState(final String s3ObjectKey) throws IOException {\r","path":"nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/PutS3Object.java","position":157,"original_position":157,"commit_id":"52fd4180c7e929cbbdd3647d1b7aad68174b2f9c","original_commit_id":"52fd4180c7e929cbbdd3647d1b7aad68174b2f9c","user":{"login":"trkurc","id":3050642,"avatar_url":"https://avatars.githubusercontent.com/u/3050642?v=3","gravatar_id":"","url":"https://api.github.com/users/trkurc","html_url":"https://github.com/trkurc","followers_url":"https://api.github.com/users/trkurc/followers","following_url":"https://api.github.com/users/trkurc/following{/other_user}","gists_url":"https://api.github.com/users/trkurc/gists{/gist_id}","starred_url":"https://api.github.com/users/trkurc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trkurc/subscriptions","organizations_url":"https://api.github.com/users/trkurc/orgs","repos_url":"https://api.github.com/users/trkurc/repos","events_url":"https://api.github.com/users/trkurc/events{/privacy}","received_events_url":"https://api.github.com/users/trkurc/received_events","type":"User","site_admin":false},"body":"I believe these methods could be problematic if multiple threads are monkeying with the persistence file at the same time. ","created_at":"2015-11-26T03:57:05Z","updated_at":"2015-11-26T03:57:05Z","html_url":"https://github.com/apache/nifi/pull/132#discussion_r45942561","pull_request_url":"https://api.github.com/repos/apache/nifi/pulls/132","_links":{"self":{"href":"https://api.github.com/repos/apache/nifi/pulls/comments/45942561"},"html":{"href":"https://github.com/apache/nifi/pull/132#discussion_r45942561"},"pull_request":{"href":"https://api.github.com/repos/apache/nifi/pulls/132"}}},"pull_request":{"url":"https://api.github.com/repos/apache/nifi/pulls/132","id":51690905,"html_url":"https://github.com/apache/nifi/pull/132","diff_url":"https://github.com/apache/nifi/pull/132.diff","patch_url":"https://github.com/apache/nifi/pull/132.patch","issue_url":"https://api.github.com/repos/apache/nifi/issues/132","number":132,"state":"open","locked":false,"title":"NIFI-1107 - Integrate Multipart uploads into the PutS3Object processor.","user":{"login":"jskora","id":181587,"avatar_url":"https://avatars.githubusercontent.com/u/181587?v=3","gravatar_id":"","url":"https://api.github.com/users/jskora","html_url":"https://github.com/jskora","followers_url":"https://api.github.com/users/jskora/followers","following_url":"https://api.github.com/users/jskora/following{/other_user}","gists_url":"https://api.github.com/users/jskora/gists{/gist_id}","starred_url":"https://api.github.com/users/jskora/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jskora/subscriptions","organizations_url":"https://api.github.com/users/jskora/orgs","repos_url":"https://api.github.com/users/jskora/repos","events_url":"https://api.github.com/users/jskora/events{/privacy}","received_events_url":"https://api.github.com/users/jskora/received_events","type":"User","site_admin":false},"body":"* Add nifi-ssl-context-service-nar to nifi-aws-nar pom.\r\n* Add nifi-ssl-context-service-api to nifi-aws-processors pom.\r\n* Add SSL context service and endpoint override properties to AbstractAWSProcessor to support non-Amazon S3-compatible endpoints.\r\n* Added Multipart upload API support, multipart threshold and size properties, state tracking for multipart upload, and expanded flow file attributes to PutS3Object.\r\n* Updated annotations and property list for FetchS3Object and DeleteS3Object.\r\n* Added region to bucket in AbstractS3Test to minimize AWS propogation issues during testing.\r\n* Expanded tests in TestPutS3Object to validate new multipart logic.","created_at":"2015-11-24T17:29:08Z","updated_at":"2015-11-26T03:57:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"91a95d2850111a73651d05976111a4445f981682","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/nifi/pulls/132/commits","review_comments_url":"https://api.github.com/repos/apache/nifi/pulls/132/comments","review_comment_url":"https://api.github.com/repos/apache/nifi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/nifi/issues/132/comments","statuses_url":"https://api.github.com/repos/apache/nifi/statuses/52fd4180c7e929cbbdd3647d1b7aad68174b2f9c","head":{"label":"jskora:NIFI-1107","ref":"NIFI-1107","sha":"52fd4180c7e929cbbdd3647d1b7aad68174b2f9c","user":{"login":"jskora","id":181587,"avatar_url":"https://avatars.githubusercontent.com/u/181587?v=3","gravatar_id":"","url":"https://api.github.com/users/jskora","html_url":"https://github.com/jskora","followers_url":"https://api.github.com/users/jskora/followers","following_url":"https://api.github.com/users/jskora/following{/other_user}","gists_url":"https://api.github.com/users/jskora/gists{/gist_id}","starred_url":"https://api.github.com/users/jskora/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jskora/subscriptions","organizations_url":"https://api.github.com/users/jskora/orgs","repos_url":"https://api.github.com/users/jskora/repos","events_url":"https://api.github.com/users/jskora/events{/privacy}","received_events_url":"https://api.github.com/users/jskora/received_events","type":"User","site_admin":false},"repo":{"id":45012567,"name":"nifi","full_name":"jskora/nifi","owner":{"login":"jskora","id":181587,"avatar_url":"https://avatars.githubusercontent.com/u/181587?v=3","gravatar_id":"","url":"https://api.github.com/users/jskora","html_url":"https://github.com/jskora","followers_url":"https://api.github.com/users/jskora/followers","following_url":"https://api.github.com/users/jskora/following{/other_user}","gists_url":"https://api.github.com/users/jskora/gists{/gist_id}","starred_url":"https://api.github.com/users/jskora/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jskora/subscriptions","organizations_url":"https://api.github.com/users/jskora/orgs","repos_url":"https://api.github.com/users/jskora/repos","events_url":"https://api.github.com/users/jskora/events{/privacy}","received_events_url":"https://api.github.com/users/jskora/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jskora/nifi","description":"Mirror of Apache NiFi","fork":true,"url":"https://api.github.com/repos/jskora/nifi","forks_url":"https://api.github.com/repos/jskora/nifi/forks","keys_url":"https://api.github.com/repos/jskora/nifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jskora/nifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jskora/nifi/teams","hooks_url":"https://api.github.com/repos/jskora/nifi/hooks","issue_events_url":"https://api.github.com/repos/jskora/nifi/issues/events{/number}","events_url":"https://api.github.com/repos/jskora/nifi/events","assignees_url":"https://api.github.com/repos/jskora/nifi/assignees{/user}","branches_url":"https://api.github.com/repos/jskora/nifi/branches{/branch}","tags_url":"https://api.github.com/repos/jskora/nifi/tags","blobs_url":"https://api.github.com/repos/jskora/nifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jskora/nifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jskora/nifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/jskora/nifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jskora/nifi/statuses/{sha}","languages_url":"https://api.github.com/repos/jskora/nifi/languages","stargazers_url":"https://api.github.com/repos/jskora/nifi/stargazers","contributors_url":"https://api.github.com/repos/jskora/nifi/contributors","subscribers_url":"https://api.github.com/repos/jskora/nifi/subscribers","subscription_url":"https://api.github.com/repos/jskora/nifi/subscription","commits_url":"https://api.github.com/repos/jskora/nifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/jskora/nifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/jskora/nifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/jskora/nifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/jskora/nifi/contents/{+path}","compare_url":"https://api.github.com/repos/jskora/nifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jskora/nifi/merges","archive_url":"https://api.github.com/repos/jskora/nifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jskora/nifi/downloads","issues_url":"https://api.github.com/repos/jskora/nifi/issues{/number}","pulls_url":"https://api.github.com/repos/jskora/nifi/pulls{/number}","milestones_url":"https://api.github.com/repos/jskora/nifi/milestones{/number}","notifications_url":"https://api.github.com/repos/jskora/nifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jskora/nifi/labels{/name}","releases_url":"https://api.github.com/repos/jskora/nifi/releases{/id}","created_at":"2015-10-27T02:46:40Z","updated_at":"2015-10-27T02:46:50Z","pushed_at":"2015-11-24T17:15:53Z","git_url":"git://github.com/jskora/nifi.git","ssh_url":"git@github.com:jskora/nifi.git","clone_url":"https://github.com/jskora/nifi.git","svn_url":"https://github.com/jskora/nifi","homepage":"","size":34854,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"4281a51c83c45382b828d4bdcd621b2972057d78","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":27911088,"name":"nifi","full_name":"apache/nifi","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/nifi","description":"Mirror of Apache NiFi","fork":false,"url":"https://api.github.com/repos/apache/nifi","forks_url":"https://api.github.com/repos/apache/nifi/forks","keys_url":"https://api.github.com/repos/apache/nifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/nifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/nifi/teams","hooks_url":"https://api.github.com/repos/apache/nifi/hooks","issue_events_url":"https://api.github.com/repos/apache/nifi/issues/events{/number}","events_url":"https://api.github.com/repos/apache/nifi/events","assignees_url":"https://api.github.com/repos/apache/nifi/assignees{/user}","branches_url":"https://api.github.com/repos/apache/nifi/branches{/branch}","tags_url":"https://api.github.com/repos/apache/nifi/tags","blobs_url":"https://api.github.com/repos/apache/nifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/nifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/nifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/nifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/nifi/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/nifi/languages","stargazers_url":"https://api.github.com/repos/apache/nifi/stargazers","contributors_url":"https://api.github.com/repos/apache/nifi/contributors","subscribers_url":"https://api.github.com/repos/apache/nifi/subscribers","subscription_url":"https://api.github.com/repos/apache/nifi/subscription","commits_url":"https://api.github.com/repos/apache/nifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/nifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/nifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/nifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/nifi/contents/{+path}","compare_url":"https://api.github.com/repos/apache/nifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/nifi/merges","archive_url":"https://api.github.com/repos/apache/nifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/nifi/downloads","issues_url":"https://api.github.com/repos/apache/nifi/issues{/number}","pulls_url":"https://api.github.com/repos/apache/nifi/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/nifi/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/nifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/nifi/labels{/name}","releases_url":"https://api.github.com/repos/apache/nifi/releases{/id}","created_at":"2014-12-12T08:00:05Z","updated_at":"2015-11-25T08:32:21Z","pushed_at":"2015-11-26T03:08:36Z","git_url":"git://github.com/apache/nifi.git","ssh_url":"git@github.com:apache/nifi.git","clone_url":"https://github.com/apache/nifi.git","svn_url":"https://github.com/apache/nifi","homepage":"","size":38783,"stargazers_count":172,"watchers_count":172,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":135,"mirror_url":"git://git.apache.org/incubator-nifi.git","open_issues_count":10,"forks":135,"open_issues":10,"watchers":172,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/nifi/pulls/132"},"html":{"href":"https://github.com/apache/nifi/pull/132"},"issue":{"href":"https://api.github.com/repos/apache/nifi/issues/132"},"comments":{"href":"https://api.github.com/repos/apache/nifi/issues/132/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/nifi/pulls/132/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/nifi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/nifi/pulls/132/commits"},"statuses":{"href":"https://api.github.com/repos/apache/nifi/statuses/52fd4180c7e929cbbdd3647d1b7aad68174b2f9c"}}}}