{"action":"created","comment":{"url":"https://api.github.com/repos/clearpathrobotics/LMS1xx/pulls/comments/32477639","id":32477639,"diff_hunk":"@@ -69,18 +79,58 @@ int main(int argc, char **argv)\n       scan_msg.scan_time = 100.0/cfg.scaningFrequency;\n \n       scan_msg.angle_increment = (double)outputRange.angleResolution/10000.0 * DEG2RAD;\n-      scan_msg.angle_min = (double)outputRange.startAngle/10000.0 * DEG2RAD - M_PI/2;\n-      scan_msg.angle_max = (double)outputRange.stopAngle/10000.0 * DEG2RAD - M_PI/2;\n+      old_start_angle = (double)outputRange.startAngle/10000.0 * DEG2RAD - M_PI/2;\n+      old_stop_angle = (double)outputRange.stopAngle/10000.0 * DEG2RAD - M_PI/2;","path":"src/LMS1xx_node.cpp","position":31,"original_position":31,"commit_id":"53cb2da632aac0194b4d165ac2b6ccb9ef92d40b","original_commit_id":"8d5564ddc455ad6d2f7baf9515304d7a200614c0","user":{"login":"NCharabaruk","id":3742143,"avatar_url":"https://avatars.githubusercontent.com/u/3742143?v=3","gravatar_id":"","url":"https://api.github.com/users/NCharabaruk","html_url":"https://github.com/NCharabaruk","followers_url":"https://api.github.com/users/NCharabaruk/followers","following_url":"https://api.github.com/users/NCharabaruk/following{/other_user}","gists_url":"https://api.github.com/users/NCharabaruk/gists{/gist_id}","starred_url":"https://api.github.com/users/NCharabaruk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NCharabaruk/subscriptions","organizations_url":"https://api.github.com/users/NCharabaruk/orgs","repos_url":"https://api.github.com/users/NCharabaruk/repos","events_url":"https://api.github.com/users/NCharabaruk/events{/privacy}","received_events_url":"https://api.github.com/users/NCharabaruk/received_events","type":"User","site_admin":false},"body":"Those lines are converting the LMS output, in degrees, into radians. ","created_at":"2015-06-15T23:15:49Z","updated_at":"2015-06-15T23:15:49Z","html_url":"https://github.com/clearpathrobotics/LMS1xx/pull/15#discussion_r32477639","pull_request_url":"https://api.github.com/repos/clearpathrobotics/LMS1xx/pulls/15","_links":{"self":{"href":"https://api.github.com/repos/clearpathrobotics/LMS1xx/pulls/comments/32477639"},"html":{"href":"https://github.com/clearpathrobotics/LMS1xx/pull/15#discussion_r32477639"},"pull_request":{"href":"https://api.github.com/repos/clearpathrobotics/LMS1xx/pulls/15"}}},"pull_request":{"url":"https://api.github.com/repos/clearpathrobotics/LMS1xx/pulls/15","id":37722599,"html_url":"https://github.com/clearpathrobotics/LMS1xx/pull/15","diff_url":"https://github.com/clearpathrobotics/LMS1xx/pull/15.diff","patch_url":"https://github.com/clearpathrobotics/LMS1xx/pull/15.patch","issue_url":"https://api.github.com/repos/clearpathrobotics/LMS1xx/issues/15","number":15,"state":"open","locked":false,"title":"Added functionality so users can specify the start and stop angles","user":{"login":"NCharabaruk","id":3742143,"avatar_url":"https://avatars.githubusercontent.com/u/3742143?v=3","gravatar_id":"","url":"https://api.github.com/users/NCharabaruk","html_url":"https://github.com/NCharabaruk","followers_url":"https://api.github.com/users/NCharabaruk/followers","following_url":"https://api.github.com/users/NCharabaruk/following{/other_user}","gists_url":"https://api.github.com/users/NCharabaruk/gists{/gist_id}","starred_url":"https://api.github.com/users/NCharabaruk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NCharabaruk/subscriptions","organizations_url":"https://api.github.com/users/NCharabaruk/orgs","repos_url":"https://api.github.com/users/NCharabaruk/repos","events_url":"https://api.github.com/users/NCharabaruk/events{/privacy}","received_events_url":"https://api.github.com/users/NCharabaruk/received_events","type":"User","site_admin":false},"body":"I've updated the lms1xx package to give the user the ability to specify the start and stop angles they want to use. This way if someone wants to limit the scans they can do so through ROS.","created_at":"2015-06-15T18:47:13Z","updated_at":"2015-06-15T23:15:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2f2d4561bae358940a2d2a9b2d90d0eb57c9ea6e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/clearpathrobotics/LMS1xx/pulls/15/commits","review_comments_url":"https://api.github.com/repos/clearpathrobotics/LMS1xx/pulls/15/comments","review_comment_url":"https://api.github.com/repos/clearpathrobotics/LMS1xx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/clearpathrobotics/LMS1xx/issues/15/comments","statuses_url":"https://api.github.com/repos/clearpathrobotics/LMS1xx/statuses/53cb2da632aac0194b4d165ac2b6ccb9ef92d40b","head":{"label":"mars-uoit:master","ref":"master","sha":"53cb2da632aac0194b4d165ac2b6ccb9ef92d40b","user":{"login":"mars-uoit","id":4852647,"avatar_url":"https://avatars.githubusercontent.com/u/4852647?v=3","gravatar_id":"","url":"https://api.github.com/users/mars-uoit","html_url":"https://github.com/mars-uoit","followers_url":"https://api.github.com/users/mars-uoit/followers","following_url":"https://api.github.com/users/mars-uoit/following{/other_user}","gists_url":"https://api.github.com/users/mars-uoit/gists{/gist_id}","starred_url":"https://api.github.com/users/mars-uoit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mars-uoit/subscriptions","organizations_url":"https://api.github.com/users/mars-uoit/orgs","repos_url":"https://api.github.com/users/mars-uoit/repos","events_url":"https://api.github.com/users/mars-uoit/events{/privacy}","received_events_url":"https://api.github.com/users/mars-uoit/received_events","type":"Organization","site_admin":false},"repo":{"id":37269413,"name":"LMS1xx","full_name":"mars-uoit/LMS1xx","owner":{"login":"mars-uoit","id":4852647,"avatar_url":"https://avatars.githubusercontent.com/u/4852647?v=3","gravatar_id":"","url":"https://api.github.com/users/mars-uoit","html_url":"https://github.com/mars-uoit","followers_url":"https://api.github.com/users/mars-uoit/followers","following_url":"https://api.github.com/users/mars-uoit/following{/other_user}","gists_url":"https://api.github.com/users/mars-uoit/gists{/gist_id}","starred_url":"https://api.github.com/users/mars-uoit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mars-uoit/subscriptions","organizations_url":"https://api.github.com/users/mars-uoit/orgs","repos_url":"https://api.github.com/users/mars-uoit/repos","events_url":"https://api.github.com/users/mars-uoit/events{/privacy}","received_events_url":"https://api.github.com/users/mars-uoit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mars-uoit/LMS1xx","description":"Driver for SICK LMS1xx. Based on https://github.com/RCPRG-ros-pkg/RCPRG_laser_drivers","fork":true,"url":"https://api.github.com/repos/mars-uoit/LMS1xx","forks_url":"https://api.github.com/repos/mars-uoit/LMS1xx/forks","keys_url":"https://api.github.com/repos/mars-uoit/LMS1xx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mars-uoit/LMS1xx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mars-uoit/LMS1xx/teams","hooks_url":"https://api.github.com/repos/mars-uoit/LMS1xx/hooks","issue_events_url":"https://api.github.com/repos/mars-uoit/LMS1xx/issues/events{/number}","events_url":"https://api.github.com/repos/mars-uoit/LMS1xx/events","assignees_url":"https://api.github.com/repos/mars-uoit/LMS1xx/assignees{/user}","branches_url":"https://api.github.com/repos/mars-uoit/LMS1xx/branches{/branch}","tags_url":"https://api.github.com/repos/mars-uoit/LMS1xx/tags","blobs_url":"https://api.github.com/repos/mars-uoit/LMS1xx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mars-uoit/LMS1xx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mars-uoit/LMS1xx/git/refs{/sha}","trees_url":"https://api.github.com/repos/mars-uoit/LMS1xx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mars-uoit/LMS1xx/statuses/{sha}","languages_url":"https://api.github.com/repos/mars-uoit/LMS1xx/languages","stargazers_url":"https://api.github.com/repos/mars-uoit/LMS1xx/stargazers","contributors_url":"https://api.github.com/repos/mars-uoit/LMS1xx/contributors","subscribers_url":"https://api.github.com/repos/mars-uoit/LMS1xx/subscribers","subscription_url":"https://api.github.com/repos/mars-uoit/LMS1xx/subscription","commits_url":"https://api.github.com/repos/mars-uoit/LMS1xx/commits{/sha}","git_commits_url":"https://api.github.com/repos/mars-uoit/LMS1xx/git/commits{/sha}","comments_url":"https://api.github.com/repos/mars-uoit/LMS1xx/comments{/number}","issue_comment_url":"https://api.github.com/repos/mars-uoit/LMS1xx/issues/comments{/number}","contents_url":"https://api.github.com/repos/mars-uoit/LMS1xx/contents/{+path}","compare_url":"https://api.github.com/repos/mars-uoit/LMS1xx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mars-uoit/LMS1xx/merges","archive_url":"https://api.github.com/repos/mars-uoit/LMS1xx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mars-uoit/LMS1xx/downloads","issues_url":"https://api.github.com/repos/mars-uoit/LMS1xx/issues{/number}","pulls_url":"https://api.github.com/repos/mars-uoit/LMS1xx/pulls{/number}","milestones_url":"https://api.github.com/repos/mars-uoit/LMS1xx/milestones{/number}","notifications_url":"https://api.github.com/repos/mars-uoit/LMS1xx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mars-uoit/LMS1xx/labels{/name}","releases_url":"https://api.github.com/repos/mars-uoit/LMS1xx/releases{/id}","created_at":"2015-06-11T15:27:06Z","updated_at":"2015-06-11T15:27:07Z","pushed_at":"2015-06-15T23:10:06Z","git_url":"git://github.com/mars-uoit/LMS1xx.git","ssh_url":"git@github.com:mars-uoit/LMS1xx.git","clone_url":"https://github.com/mars-uoit/LMS1xx.git","svn_url":"https://github.com/mars-uoit/LMS1xx","homepage":null,"size":116,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"clearpathrobotics:master","ref":"master","sha":"51ab9178832392486cc51beb81124b89da3f966c","user":{"login":"clearpathrobotics","id":1552891,"avatar_url":"https://avatars.githubusercontent.com/u/1552891?v=3","gravatar_id":"","url":"https://api.github.com/users/clearpathrobotics","html_url":"https://github.com/clearpathrobotics","followers_url":"https://api.github.com/users/clearpathrobotics/followers","following_url":"https://api.github.com/users/clearpathrobotics/following{/other_user}","gists_url":"https://api.github.com/users/clearpathrobotics/gists{/gist_id}","starred_url":"https://api.github.com/users/clearpathrobotics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clearpathrobotics/subscriptions","organizations_url":"https://api.github.com/users/clearpathrobotics/orgs","repos_url":"https://api.github.com/users/clearpathrobotics/repos","events_url":"https://api.github.com/users/clearpathrobotics/events{/privacy}","received_events_url":"https://api.github.com/users/clearpathrobotics/received_events","type":"Organization","site_admin":false},"repo":{"id":14073945,"name":"LMS1xx","full_name":"clearpathrobotics/LMS1xx","owner":{"login":"clearpathrobotics","id":1552891,"avatar_url":"https://avatars.githubusercontent.com/u/1552891?v=3","gravatar_id":"","url":"https://api.github.com/users/clearpathrobotics","html_url":"https://github.com/clearpathrobotics","followers_url":"https://api.github.com/users/clearpathrobotics/followers","following_url":"https://api.github.com/users/clearpathrobotics/following{/other_user}","gists_url":"https://api.github.com/users/clearpathrobotics/gists{/gist_id}","starred_url":"https://api.github.com/users/clearpathrobotics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clearpathrobotics/subscriptions","organizations_url":"https://api.github.com/users/clearpathrobotics/orgs","repos_url":"https://api.github.com/users/clearpathrobotics/repos","events_url":"https://api.github.com/users/clearpathrobotics/events{/privacy}","received_events_url":"https://api.github.com/users/clearpathrobotics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/clearpathrobotics/LMS1xx","description":"Driver for SICK LMS1xx. Based on https://github.com/RCPRG-ros-pkg/RCPRG_laser_drivers","fork":false,"url":"https://api.github.com/repos/clearpathrobotics/LMS1xx","forks_url":"https://api.github.com/repos/clearpathrobotics/LMS1xx/forks","keys_url":"https://api.github.com/repos/clearpathrobotics/LMS1xx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/clearpathrobotics/LMS1xx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/clearpathrobotics/LMS1xx/teams","hooks_url":"https://api.github.com/repos/clearpathrobotics/LMS1xx/hooks","issue_events_url":"https://api.github.com/repos/clearpathrobotics/LMS1xx/issues/events{/number}","events_url":"https://api.github.com/repos/clearpathrobotics/LMS1xx/events","assignees_url":"https://api.github.com/repos/clearpathrobotics/LMS1xx/assignees{/user}","branches_url":"https://api.github.com/repos/clearpathrobotics/LMS1xx/branches{/branch}","tags_url":"https://api.github.com/repos/clearpathrobotics/LMS1xx/tags","blobs_url":"https://api.github.com/repos/clearpathrobotics/LMS1xx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/clearpathrobotics/LMS1xx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/clearpathrobotics/LMS1xx/git/refs{/sha}","trees_url":"https://api.github.com/repos/clearpathrobotics/LMS1xx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/clearpathrobotics/LMS1xx/statuses/{sha}","languages_url":"https://api.github.com/repos/clearpathrobotics/LMS1xx/languages","stargazers_url":"https://api.github.com/repos/clearpathrobotics/LMS1xx/stargazers","contributors_url":"https://api.github.com/repos/clearpathrobotics/LMS1xx/contributors","subscribers_url":"https://api.github.com/repos/clearpathrobotics/LMS1xx/subscribers","subscription_url":"https://api.github.com/repos/clearpathrobotics/LMS1xx/subscription","commits_url":"https://api.github.com/repos/clearpathrobotics/LMS1xx/commits{/sha}","git_commits_url":"https://api.github.com/repos/clearpathrobotics/LMS1xx/git/commits{/sha}","comments_url":"https://api.github.com/repos/clearpathrobotics/LMS1xx/comments{/number}","issue_comment_url":"https://api.github.com/repos/clearpathrobotics/LMS1xx/issues/comments{/number}","contents_url":"https://api.github.com/repos/clearpathrobotics/LMS1xx/contents/{+path}","compare_url":"https://api.github.com/repos/clearpathrobotics/LMS1xx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/clearpathrobotics/LMS1xx/merges","archive_url":"https://api.github.com/repos/clearpathrobotics/LMS1xx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/clearpathrobotics/LMS1xx/downloads","issues_url":"https://api.github.com/repos/clearpathrobotics/LMS1xx/issues{/number}","pulls_url":"https://api.github.com/repos/clearpathrobotics/LMS1xx/pulls{/number}","milestones_url":"https://api.github.com/repos/clearpathrobotics/LMS1xx/milestones{/number}","notifications_url":"https://api.github.com/repos/clearpathrobotics/LMS1xx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/clearpathrobotics/LMS1xx/labels{/name}","releases_url":"https://api.github.com/repos/clearpathrobotics/LMS1xx/releases{/id}","created_at":"2013-11-02T19:57:32Z","updated_at":"2015-05-07T14:37:25Z","pushed_at":"2015-06-15T23:10:06Z","git_url":"git://github.com/clearpathrobotics/LMS1xx.git","ssh_url":"git@github.com:clearpathrobotics/LMS1xx.git","clone_url":"https://github.com/clearpathrobotics/LMS1xx.git","svn_url":"https://github.com/clearpathrobotics/LMS1xx","homepage":null,"size":338,"stargazers_count":3,"watchers_count":3,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":4,"forks":7,"open_issues":4,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/clearpathrobotics/LMS1xx/pulls/15"},"html":{"href":"https://github.com/clearpathrobotics/LMS1xx/pull/15"},"issue":{"href":"https://api.github.com/repos/clearpathrobotics/LMS1xx/issues/15"},"comments":{"href":"https://api.github.com/repos/clearpathrobotics/LMS1xx/issues/15/comments"},"review_comments":{"href":"https://api.github.com/repos/clearpathrobotics/LMS1xx/pulls/15/comments"},"review_comment":{"href":"https://api.github.com/repos/clearpathrobotics/LMS1xx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/clearpathrobotics/LMS1xx/pulls/15/commits"},"statuses":{"href":"https://api.github.com/repos/clearpathrobotics/LMS1xx/statuses/53cb2da632aac0194b4d165ac2b6ccb9ef92d40b"}}}}