{"action":"created","issue":{"url":"https://api.github.com/repos/jonschlinkert/remarkable/issues/155","labels_url":"https://api.github.com/repos/jonschlinkert/remarkable/issues/155/labels{/name}","comments_url":"https://api.github.com/repos/jonschlinkert/remarkable/issues/155/comments","events_url":"https://api.github.com/repos/jonschlinkert/remarkable/issues/155/events","html_url":"https://github.com/jonschlinkert/remarkable/pull/155","id":75271799,"number":155,"title":"Option to not alter links provided for href","user":{"login":"medikoo","id":122434,"avatar_url":"https://avatars.githubusercontent.com/u/122434?v=3","gravatar_id":"","url":"https://api.github.com/users/medikoo","html_url":"https://github.com/medikoo","followers_url":"https://api.github.com/users/medikoo/followers","following_url":"https://api.github.com/users/medikoo/following{/other_user}","gists_url":"https://api.github.com/users/medikoo/gists{/gist_id}","starred_url":"https://api.github.com/users/medikoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/medikoo/subscriptions","organizations_url":"https://api.github.com/users/medikoo/orgs","repos_url":"https://api.github.com/users/medikoo/repos","events_url":"https://api.github.com/users/medikoo/events{/privacy}","received_events_url":"https://api.github.com/users/medikoo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-05-11T16:05:27Z","updated_at":"2015-05-13T08:29:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jonschlinkert/remarkable/pulls/155","html_url":"https://github.com/jonschlinkert/remarkable/pull/155","diff_url":"https://github.com/jonschlinkert/remarkable/pull/155.diff","patch_url":"https://github.com/jonschlinkert/remarkable/pull/155.patch"},"body":"In my setup in markdown I initially provide values for hrefs as token markers, which after html is resolved to DOM are replaced with accurate links.\r\n\r\nUnfortunately it can't work with how currently remarkable resolves html, as `[text](link)` doesn't resolve to `<a href=\"\">text</a>`, if _link_ is not seen as valid URL.\r\n\r\nI believe it should be more agnostic to user input.\r\n\r\nProblem lies in following parts:\r\n\r\n1. It should pass through space or control characters in links (e.g. I use control characters as markers).\r\nSo following should be removed:\r\nhttps://github.com/jonschlinkert/remarkable/blob/f1de27b203eb4e169ed40954061b76f0803b14e7/lib/helpers/parse_link_destination.js#L53-L56\r\n\r\n2. It should not normalize link texts. Naturally valid url should be provided. For that  _normalizeLink_ call should not take place here:\r\nhttps://github.com/jonschlinkert/remarkable/blob/f1de27b203eb4e169ed40954061b76f0803b14e7/lib/helpers/parse_link_destination.js#L78\r\n\r\nI can provide a pull request that addresses that, but first I would like to know, wether you're ok with such change"},"comment":{"url":"https://api.github.com/repos/jonschlinkert/remarkable/issues/comments/101572043","html_url":"https://github.com/jonschlinkert/remarkable/pull/155#issuecomment-101572043","issue_url":"https://api.github.com/repos/jonschlinkert/remarkable/issues/155","id":101572043,"user":{"login":"medikoo","id":122434,"avatar_url":"https://avatars.githubusercontent.com/u/122434?v=3","gravatar_id":"","url":"https://api.github.com/users/medikoo","html_url":"https://github.com/medikoo","followers_url":"https://api.github.com/users/medikoo/followers","following_url":"https://api.github.com/users/medikoo/following{/other_user}","gists_url":"https://api.github.com/users/medikoo/gists{/gist_id}","starred_url":"https://api.github.com/users/medikoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/medikoo/subscriptions","organizations_url":"https://api.github.com/users/medikoo/orgs","repos_url":"https://api.github.com/users/medikoo/repos","events_url":"https://api.github.com/users/medikoo/events{/privacy}","received_events_url":"https://api.github.com/users/medikoo/received_events","type":"User","site_admin":false},"created_at":"2015-05-13T08:29:20Z","updated_at":"2015-05-13T08:29:20Z","body":"@jonschlinkert I've converted this issue to PR then.\r\n\r\nI think those links just should be taken as they are, and not try to be _fixed_. I think in most cases it's unwanted. Then only thing that should be assured naturally is html escape, that's it."}}