{"action":"created","comment":{"url":"https://api.github.com/repos/pulp/pulp/pulls/comments/22423226","id":22423226,"diff_hunk":"@@ -11,6 +11,15 @@\n PROJECT_DIR = os.path.dirname(__file__)\n subprocess.call(['find', PROJECT_DIR, '-name', '*.pyc', '-delete'])\n \n+# Check for style\n+config_file = os.path.join(PROJECT_DIR, 'flake8.cfg')\n+# These paths should all pass PEP-8 checks\n+paths_to_check = [\n+    os.path.join(PROJECT_DIR, 'server', 'pulp', 'server', 'tasks'),\n+    os.path.join(PROJECT_DIR, 'server', 'test', 'unit', 'server')]","path":"run-tests.py","position":9,"original_position":9,"commit_id":"8c7c5017fa68faecaf7cd902166473a20b59a505","original_commit_id":"8c7c5017fa68faecaf7cd902166473a20b59a505","user":{"login":"beav","id":563254,"avatar_url":"https://avatars.githubusercontent.com/u/563254?v=3","gravatar_id":"","url":"https://api.github.com/users/beav","html_url":"https://github.com/beav","followers_url":"https://api.github.com/users/beav/followers","following_url":"https://api.github.com/users/beav/following{/other_user}","gists_url":"https://api.github.com/users/beav/gists{/gist_id}","starred_url":"https://api.github.com/users/beav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beav/subscriptions","organizations_url":"https://api.github.com/users/beav/orgs","repos_url":"https://api.github.com/users/beav/repos","events_url":"https://api.github.com/users/beav/events{/privacy}","received_events_url":"https://api.github.com/users/beav/received_events","type":"User","site_admin":false},"body":"Can this be a list of strings instead? That would be easier to edit as we fix stuff, even if it's just like\r\n\r\n```python\r\npaths_to_check [os.path.join(PROJECT_DIR, partial_path) for partial_path in list_of_pep8_dirs)]\r\n```","created_at":"2015-01-02T21:18:44Z","updated_at":"2015-01-02T21:18:44Z","html_url":"https://github.com/pulp/pulp/pull/1470#discussion_r22423226","pull_request_url":"https://api.github.com/repos/pulp/pulp/pulls/1470","_links":{"self":{"href":"https://api.github.com/repos/pulp/pulp/pulls/comments/22423226"},"html":{"href":"https://github.com/pulp/pulp/pull/1470#discussion_r22423226"},"pull_request":{"href":"https://api.github.com/repos/pulp/pulp/pulls/1470"}}},"pull_request":{"url":"https://api.github.com/repos/pulp/pulp/pulls/1470","id":26570044,"html_url":"https://github.com/pulp/pulp/pull/1470","diff_url":"https://github.com/pulp/pulp/pull/1470.diff","patch_url":"https://github.com/pulp/pulp/pull/1470.patch","issue_url":"https://api.github.com/repos/pulp/pulp/issues/1470","number":1470,"state":"open","locked":false,"title":"Run flake8 in run-tests.py.","user":{"login":"rbarlow","id":354506,"avatar_url":"https://avatars.githubusercontent.com/u/354506?v=3","gravatar_id":"","url":"https://api.github.com/users/rbarlow","html_url":"https://github.com/rbarlow","followers_url":"https://api.github.com/users/rbarlow/followers","following_url":"https://api.github.com/users/rbarlow/following{/other_user}","gists_url":"https://api.github.com/users/rbarlow/gists{/gist_id}","starred_url":"https://api.github.com/users/rbarlow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rbarlow/subscriptions","organizations_url":"https://api.github.com/users/rbarlow/orgs","repos_url":"https://api.github.com/users/rbarlow/repos","events_url":"https://api.github.com/users/rbarlow/events{/privacy}","received_events_url":"https://api.github.com/users/rbarlow/received_events","type":"User","site_admin":false},"body":"This commit adds support for flake8 to run-tests.py. It currently only\r\nchecks the files that I've already made sure were PEP-8 to catch PEP-8\r\nregressions.","created_at":"2014-12-24T22:48:28Z","updated_at":"2015-01-02T21:18:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9d57660bf57d98397f3950db34bfb1456ab4774e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/pulp/pulp/pulls/1470/commits","review_comments_url":"https://api.github.com/repos/pulp/pulp/pulls/1470/comments","review_comment_url":"https://api.github.com/repos/pulp/pulp/pulls/comments/{number}","comments_url":"https://api.github.com/repos/pulp/pulp/issues/1470/comments","statuses_url":"https://api.github.com/repos/pulp/pulp/statuses/8c7c5017fa68faecaf7cd902166473a20b59a505","head":{"label":"rbarlow:auto_flake8","ref":"auto_flake8","sha":"8c7c5017fa68faecaf7cd902166473a20b59a505","user":{"login":"rbarlow","id":354506,"avatar_url":"https://avatars.githubusercontent.com/u/354506?v=3","gravatar_id":"","url":"https://api.github.com/users/rbarlow","html_url":"https://github.com/rbarlow","followers_url":"https://api.github.com/users/rbarlow/followers","following_url":"https://api.github.com/users/rbarlow/following{/other_user}","gists_url":"https://api.github.com/users/rbarlow/gists{/gist_id}","starred_url":"https://api.github.com/users/rbarlow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rbarlow/subscriptions","organizations_url":"https://api.github.com/users/rbarlow/orgs","repos_url":"https://api.github.com/users/rbarlow/repos","events_url":"https://api.github.com/users/rbarlow/events{/privacy}","received_events_url":"https://api.github.com/users/rbarlow/received_events","type":"User","site_admin":false},"repo":{"id":24110007,"name":"pulp","full_name":"rbarlow/pulp","owner":{"login":"rbarlow","id":354506,"avatar_url":"https://avatars.githubusercontent.com/u/354506?v=3","gravatar_id":"","url":"https://api.github.com/users/rbarlow","html_url":"https://github.com/rbarlow","followers_url":"https://api.github.com/users/rbarlow/followers","following_url":"https://api.github.com/users/rbarlow/following{/other_user}","gists_url":"https://api.github.com/users/rbarlow/gists{/gist_id}","starred_url":"https://api.github.com/users/rbarlow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rbarlow/subscriptions","organizations_url":"https://api.github.com/users/rbarlow/orgs","repos_url":"https://api.github.com/users/rbarlow/repos","events_url":"https://api.github.com/users/rbarlow/events{/privacy}","received_events_url":"https://api.github.com/users/rbarlow/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rbarlow/pulp","description":"Repository for Pulp platform code, including the server and base admin and consumer clients","fork":true,"url":"https://api.github.com/repos/rbarlow/pulp","forks_url":"https://api.github.com/repos/rbarlow/pulp/forks","keys_url":"https://api.github.com/repos/rbarlow/pulp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rbarlow/pulp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rbarlow/pulp/teams","hooks_url":"https://api.github.com/repos/rbarlow/pulp/hooks","issue_events_url":"https://api.github.com/repos/rbarlow/pulp/issues/events{/number}","events_url":"https://api.github.com/repos/rbarlow/pulp/events","assignees_url":"https://api.github.com/repos/rbarlow/pulp/assignees{/user}","branches_url":"https://api.github.com/repos/rbarlow/pulp/branches{/branch}","tags_url":"https://api.github.com/repos/rbarlow/pulp/tags","blobs_url":"https://api.github.com/repos/rbarlow/pulp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rbarlow/pulp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rbarlow/pulp/git/refs{/sha}","trees_url":"https://api.github.com/repos/rbarlow/pulp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rbarlow/pulp/statuses/{sha}","languages_url":"https://api.github.com/repos/rbarlow/pulp/languages","stargazers_url":"https://api.github.com/repos/rbarlow/pulp/stargazers","contributors_url":"https://api.github.com/repos/rbarlow/pulp/contributors","subscribers_url":"https://api.github.com/repos/rbarlow/pulp/subscribers","subscription_url":"https://api.github.com/repos/rbarlow/pulp/subscription","commits_url":"https://api.github.com/repos/rbarlow/pulp/commits{/sha}","git_commits_url":"https://api.github.com/repos/rbarlow/pulp/git/commits{/sha}","comments_url":"https://api.github.com/repos/rbarlow/pulp/comments{/number}","issue_comment_url":"https://api.github.com/repos/rbarlow/pulp/issues/comments/{number}","contents_url":"https://api.github.com/repos/rbarlow/pulp/contents/{+path}","compare_url":"https://api.github.com/repos/rbarlow/pulp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rbarlow/pulp/merges","archive_url":"https://api.github.com/repos/rbarlow/pulp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rbarlow/pulp/downloads","issues_url":"https://api.github.com/repos/rbarlow/pulp/issues{/number}","pulls_url":"https://api.github.com/repos/rbarlow/pulp/pulls{/number}","milestones_url":"https://api.github.com/repos/rbarlow/pulp/milestones{/number}","notifications_url":"https://api.github.com/repos/rbarlow/pulp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rbarlow/pulp/labels{/name}","releases_url":"https://api.github.com/repos/rbarlow/pulp/releases{/id}","created_at":"2014-09-16T17:30:02Z","updated_at":"2014-12-22T19:51:14Z","pushed_at":"2014-12-24T23:02:48Z","git_url":"git://github.com/rbarlow/pulp.git","ssh_url":"git@github.com:rbarlow/pulp.git","clone_url":"https://github.com/rbarlow/pulp.git","svn_url":"https://github.com/rbarlow/pulp","homepage":"","size":79375,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pulp:master","ref":"master","sha":"ac69e46b843693fecb241c4745f7ff35b864b90f","user":{"login":"pulp","id":2103606,"avatar_url":"https://avatars.githubusercontent.com/u/2103606?v=3","gravatar_id":"","url":"https://api.github.com/users/pulp","html_url":"https://github.com/pulp","followers_url":"https://api.github.com/users/pulp/followers","following_url":"https://api.github.com/users/pulp/following{/other_user}","gists_url":"https://api.github.com/users/pulp/gists{/gist_id}","starred_url":"https://api.github.com/users/pulp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pulp/subscriptions","organizations_url":"https://api.github.com/users/pulp/orgs","repos_url":"https://api.github.com/users/pulp/repos","events_url":"https://api.github.com/users/pulp/events{/privacy}","received_events_url":"https://api.github.com/users/pulp/received_events","type":"Organization","site_admin":false},"repo":{"id":5314652,"name":"pulp","full_name":"pulp/pulp","owner":{"login":"pulp","id":2103606,"avatar_url":"https://avatars.githubusercontent.com/u/2103606?v=3","gravatar_id":"","url":"https://api.github.com/users/pulp","html_url":"https://github.com/pulp","followers_url":"https://api.github.com/users/pulp/followers","following_url":"https://api.github.com/users/pulp/following{/other_user}","gists_url":"https://api.github.com/users/pulp/gists{/gist_id}","starred_url":"https://api.github.com/users/pulp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pulp/subscriptions","organizations_url":"https://api.github.com/users/pulp/orgs","repos_url":"https://api.github.com/users/pulp/repos","events_url":"https://api.github.com/users/pulp/events{/privacy}","received_events_url":"https://api.github.com/users/pulp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pulp/pulp","description":"Repository for Pulp platform code, including the server and base admin and consumer clients","fork":false,"url":"https://api.github.com/repos/pulp/pulp","forks_url":"https://api.github.com/repos/pulp/pulp/forks","keys_url":"https://api.github.com/repos/pulp/pulp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pulp/pulp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pulp/pulp/teams","hooks_url":"https://api.github.com/repos/pulp/pulp/hooks","issue_events_url":"https://api.github.com/repos/pulp/pulp/issues/events{/number}","events_url":"https://api.github.com/repos/pulp/pulp/events","assignees_url":"https://api.github.com/repos/pulp/pulp/assignees{/user}","branches_url":"https://api.github.com/repos/pulp/pulp/branches{/branch}","tags_url":"https://api.github.com/repos/pulp/pulp/tags","blobs_url":"https://api.github.com/repos/pulp/pulp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pulp/pulp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pulp/pulp/git/refs{/sha}","trees_url":"https://api.github.com/repos/pulp/pulp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pulp/pulp/statuses/{sha}","languages_url":"https://api.github.com/repos/pulp/pulp/languages","stargazers_url":"https://api.github.com/repos/pulp/pulp/stargazers","contributors_url":"https://api.github.com/repos/pulp/pulp/contributors","subscribers_url":"https://api.github.com/repos/pulp/pulp/subscribers","subscription_url":"https://api.github.com/repos/pulp/pulp/subscription","commits_url":"https://api.github.com/repos/pulp/pulp/commits{/sha}","git_commits_url":"https://api.github.com/repos/pulp/pulp/git/commits{/sha}","comments_url":"https://api.github.com/repos/pulp/pulp/comments{/number}","issue_comment_url":"https://api.github.com/repos/pulp/pulp/issues/comments/{number}","contents_url":"https://api.github.com/repos/pulp/pulp/contents/{+path}","compare_url":"https://api.github.com/repos/pulp/pulp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pulp/pulp/merges","archive_url":"https://api.github.com/repos/pulp/pulp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pulp/pulp/downloads","issues_url":"https://api.github.com/repos/pulp/pulp/issues{/number}","pulls_url":"https://api.github.com/repos/pulp/pulp/pulls{/number}","milestones_url":"https://api.github.com/repos/pulp/pulp/milestones{/number}","notifications_url":"https://api.github.com/repos/pulp/pulp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pulp/pulp/labels{/name}","releases_url":"https://api.github.com/repos/pulp/pulp/releases{/id}","created_at":"2012-08-06T13:49:20Z","updated_at":"2014-12-31T00:36:58Z","pushed_at":"2014-12-23T20:46:31Z","git_url":"git://github.com/pulp/pulp.git","ssh_url":"git@github.com:pulp/pulp.git","clone_url":"https://github.com/pulp/pulp.git","svn_url":"https://github.com/pulp/pulp","homepage":"","size":197875,"stargazers_count":169,"watchers_count":169,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":73,"mirror_url":null,"open_issues_count":34,"forks":73,"open_issues":34,"watchers":169,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pulp/pulp/pulls/1470"},"html":{"href":"https://github.com/pulp/pulp/pull/1470"},"issue":{"href":"https://api.github.com/repos/pulp/pulp/issues/1470"},"comments":{"href":"https://api.github.com/repos/pulp/pulp/issues/1470/comments"},"review_comments":{"href":"https://api.github.com/repos/pulp/pulp/pulls/1470/comments"},"review_comment":{"href":"https://api.github.com/repos/pulp/pulp/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/pulp/pulp/pulls/1470/commits"},"statuses":{"href":"https://api.github.com/repos/pulp/pulp/statuses/8c7c5017fa68faecaf7cd902166473a20b59a505"}}}}