{"action":"created","issue":{"url":"https://api.github.com/repos/fatih/structs/issues/24","labels_url":"https://api.github.com/repos/fatih/structs/issues/24/labels{/name}","comments_url":"https://api.github.com/repos/fatih/structs/issues/24/comments","events_url":"https://api.github.com/repos/fatih/structs/issues/24/events","html_url":"https://github.com/fatih/structs/pull/24","id":59777274,"number":24,"title":"Custom default tag name for each struct","user":{"login":"nullbus","id":7009407,"avatar_url":"https://avatars.githubusercontent.com/u/7009407?v=3","gravatar_id":"","url":"https://api.github.com/users/nullbus","html_url":"https://github.com/nullbus","followers_url":"https://api.github.com/users/nullbus/followers","following_url":"https://api.github.com/users/nullbus/following{/other_user}","gists_url":"https://api.github.com/users/nullbus/gists{/gist_id}","starred_url":"https://api.github.com/users/nullbus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nullbus/subscriptions","organizations_url":"https://api.github.com/users/nullbus/orgs","repos_url":"https://api.github.com/users/nullbus/repos","events_url":"https://api.github.com/users/nullbus/events{/privacy}","received_events_url":"https://api.github.com/users/nullbus/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-03-04T10:22:50Z","updated_at":"2015-03-04T15:50:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/fatih/structs/pulls/24","html_url":"https://github.com/fatih/structs/pull/24","diff_url":"https://github.com/fatih/structs/pull/24.diff","patch_url":"https://github.com/fatih/structs/pull/24.patch"},"body":"I think modifying and using global variable is bad practice. If using this with many custom field tags, it can cause race condition.\r\nSo I made change to each struct to have default tag name. It will increase more goroutine safety.\r\n\r\nI wanted to eliminate the global DefaultTagName variable, but I didn't since it affects all users watching.\r\nTake a look and advice me if I did wrong.\r\nThank you!"},"comment":{"url":"https://api.github.com/repos/fatih/structs/issues/comments/77182979","html_url":"https://github.com/fatih/structs/pull/24#issuecomment-77182979","issue_url":"https://api.github.com/repos/fatih/structs/issues/24","id":77182979,"user":{"login":"fatih","id":438920,"avatar_url":"https://avatars.githubusercontent.com/u/438920?v=3","gravatar_id":"","url":"https://api.github.com/users/fatih","html_url":"https://github.com/fatih","followers_url":"https://api.github.com/users/fatih/followers","following_url":"https://api.github.com/users/fatih/following{/other_user}","gists_url":"https://api.github.com/users/fatih/gists{/gist_id}","starred_url":"https://api.github.com/users/fatih/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fatih/subscriptions","organizations_url":"https://api.github.com/users/fatih/orgs","repos_url":"https://api.github.com/users/fatih/repos","events_url":"https://api.github.com/users/fatih/events{/privacy}","received_events_url":"https://api.github.com/users/fatih/received_events","type":"User","site_admin":false},"created_at":"2015-03-04T15:50:00Z","updated_at":"2015-03-04T15:50:00Z","body":"Nice contribution :+1:  I agree of not having global variables. This also backwards compatible as the defaultTagName is still being used in the constructor. "}}