{"action":"created","comment":{"url":"https://api.github.com/repos/mesosphere/universe/pulls/comments/29645981","id":29645981,"diff_hunk":"@@ -1,104 +1,135 @@\n {\n   \"type\": \"object\",\n   \"properties\": {\n-    \"mesos/master\": {\n-      \"description\": \"The URL of the Mesos master. The format is a comma-delimited list of hosts like zk://host1:port,host2:port/mesos. If using ZooKeeper, pay particular attention to the leading zk:// and trailing /mesos! If not using ZooKeeper, standard URLs like http://localhost are also acceptable.\",\n-      \"type\": \"string\",\n-      \"default\": \"zk://master.mesos:2181/mesos\"\n-    },\n-\n-    \"framework/failover-timeout-seconds\": {\n-      \"description\": \"The failover_timeout for Mesos in seconds. If the framework instance has not re-registered with Mesos this long after a failover, Mesos will shut down all running tasks started by the framework.\",\n-      \"type\": \"integer\",\n-      \"minimum\": 0,\n-      \"default\": 604800\n-    },\n-    \"framework/role\": {\n-      \"description\": \"Mesos role for this framework.\",\n-      \"type\": \"string\",\n-      \"default\": \"*\"\n-    },\n-    \"framework/authentication/enabled\": {\n-      \"description\": \"Whether framework authentication should be used\",\n-      \"type\": \"boolean\",\n-      \"default\": false\n-    },\n-    \"framework/authentication/principal\": {\n-      \"description\": \"The Mesos principal used for authentication.\",\n-      \"type\": \"string\"\n-    },\n-    \"framework/authentication/secret\": {\n-      \"description\": \"The path to the Mesos secret file containing the authentication secret.\",\n-      \"type\": \"string\"\n-    },\n+    \"mesos\": {\n+      \"description\": \"Mesos specific configuration properties\",\n+      \"type\": \"object\",\n+      \"properties\": {\n+        \"master\": {\n+          \"default\": \"zk://master.mesos:2181/mesos\",\n+          \"description\": \"The URL of the Mesos master. The format is a comma-delimited list of hosts like zk://host1:port,host2:port/mesos. If using ZooKeeper, pay particular attention to the leading zk:// and trailing /mesos! If not using ZooKeeper, standard host:port patterns, like localhost:5050 or 10.0.0.5:5050,10.0.0.6:5050, are also acceptable.\",\n+          \"type\": \"string\"\n+        }\n+      },\n+      \"required\": [\n+        \"master\"\n+      ]\n+    },\n+    \"cassandra\": {\n+      \"description\": \"Cassandra Framework Configuration Properties\",\n+      \"type\": \"object\",\n+      \"properties\": {\n+        \"framework\": {\n+          \"description\": \"Framework Scheduler specific Configuration Properties\",\n+          \"type\": \"object\",\n+          \"properties\": {\n+            \"failover-timeout-seconds\": {\n+              \"description\": \"The failover_timeout for Mesos in seconds. If the framework instance has not re-registered with Mesos this long after a failover, Mesos will shut down all running tasks started by the framework.\",\n+              \"type\": \"integer\",\n+              \"minimum\": 0,\n+              \"default\": 604800\n+            },\n+            \"role\": {\n+              \"description\": \"Mesos role for this framework.\",\n+              \"type\": \"string\",\n+              \"default\": \"*\"\n+            },\n+            \"authentication\": {","path":"repo/packages/C/cassandra/0/config.json","position":67,"original_position":67,"commit_id":"c8e8426c4575af81a8833944b0f789e6251cef24","original_commit_id":"c8e8426c4575af81a8833944b0f789e6251cef24","user":{"login":"ConnorDoyle","id":379372,"avatar_url":"https://avatars.githubusercontent.com/u/379372?v=3","gravatar_id":"","url":"https://api.github.com/users/ConnorDoyle","html_url":"https://github.com/ConnorDoyle","followers_url":"https://api.github.com/users/ConnorDoyle/followers","following_url":"https://api.github.com/users/ConnorDoyle/following{/other_user}","gists_url":"https://api.github.com/users/ConnorDoyle/gists{/gist_id}","starred_url":"https://api.github.com/users/ConnorDoyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ConnorDoyle/subscriptions","organizations_url":"https://api.github.com/users/ConnorDoyle/orgs","repos_url":"https://api.github.com/users/ConnorDoyle/repos","events_url":"https://api.github.com/users/ConnorDoyle/events{/privacy}","received_events_url":"https://api.github.com/users/ConnorDoyle/received_events","type":"User","site_admin":false},"body":"I'd recommend setting `additionalProperties` to false, at least for this nested object.  That will make typos fail the validation step.  Imagine you had mis-spelled `enabled`...","created_at":"2015-05-05T06:23:29Z","updated_at":"2015-05-05T06:23:29Z","html_url":"https://github.com/mesosphere/universe/pull/106#discussion_r29645981","pull_request_url":"https://api.github.com/repos/mesosphere/universe/pulls/106","_links":{"self":{"href":"https://api.github.com/repos/mesosphere/universe/pulls/comments/29645981"},"html":{"href":"https://github.com/mesosphere/universe/pull/106#discussion_r29645981"},"pull_request":{"href":"https://api.github.com/repos/mesosphere/universe/pulls/106"}}},"pull_request":{"url":"https://api.github.com/repos/mesosphere/universe/pulls/106","id":34686677,"html_url":"https://github.com/mesosphere/universe/pull/106","diff_url":"https://github.com/mesosphere/universe/pull/106.diff","patch_url":"https://github.com/mesosphere/universe/pull/106.patch","issue_url":"https://api.github.com/repos/mesosphere/universe/issues/106","number":106,"state":"open","locked":false,"title":"Update cassandra config to use new nested object support.","user":{"login":"BenWhitehead","id":1754037,"avatar_url":"https://avatars.githubusercontent.com/u/1754037?v=3","gravatar_id":"","url":"https://api.github.com/users/BenWhitehead","html_url":"https://github.com/BenWhitehead","followers_url":"https://api.github.com/users/BenWhitehead/followers","following_url":"https://api.github.com/users/BenWhitehead/following{/other_user}","gists_url":"https://api.github.com/users/BenWhitehead/gists{/gist_id}","starred_url":"https://api.github.com/users/BenWhitehead/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BenWhitehead/subscriptions","organizations_url":"https://api.github.com/users/BenWhitehead/orgs","repos_url":"https://api.github.com/users/BenWhitehead/repos","events_url":"https://api.github.com/users/BenWhitehead/events{/privacy}","received_events_url":"https://api.github.com/users/BenWhitehead/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-05-04T23:54:24Z","updated_at":"2015-05-05T06:23:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a835a75de898324b7927d346f8ac419d015299b0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mesosphere/universe/pulls/106/commits","review_comments_url":"https://api.github.com/repos/mesosphere/universe/pulls/106/comments","review_comment_url":"https://api.github.com/repos/mesosphere/universe/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mesosphere/universe/issues/106/comments","statuses_url":"https://api.github.com/repos/mesosphere/universe/statuses/c8e8426c4575af81a8833944b0f789e6251cef24","head":{"label":"mesosphere:cassandra-config-rewrite","ref":"cassandra-config-rewrite","sha":"c8e8426c4575af81a8833944b0f789e6251cef24","user":{"login":"mesosphere","id":3458585,"avatar_url":"https://avatars.githubusercontent.com/u/3458585?v=3","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"repo":{"id":26291234,"name":"universe","full_name":"mesosphere/universe","owner":{"login":"mesosphere","id":3458585,"avatar_url":"https://avatars.githubusercontent.com/u/3458585?v=3","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mesosphere/universe","description":"The Mesos package repository.","fork":false,"url":"https://api.github.com/repos/mesosphere/universe","forks_url":"https://api.github.com/repos/mesosphere/universe/forks","keys_url":"https://api.github.com/repos/mesosphere/universe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mesosphere/universe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mesosphere/universe/teams","hooks_url":"https://api.github.com/repos/mesosphere/universe/hooks","issue_events_url":"https://api.github.com/repos/mesosphere/universe/issues/events{/number}","events_url":"https://api.github.com/repos/mesosphere/universe/events","assignees_url":"https://api.github.com/repos/mesosphere/universe/assignees{/user}","branches_url":"https://api.github.com/repos/mesosphere/universe/branches{/branch}","tags_url":"https://api.github.com/repos/mesosphere/universe/tags","blobs_url":"https://api.github.com/repos/mesosphere/universe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mesosphere/universe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mesosphere/universe/git/refs{/sha}","trees_url":"https://api.github.com/repos/mesosphere/universe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mesosphere/universe/statuses/{sha}","languages_url":"https://api.github.com/repos/mesosphere/universe/languages","stargazers_url":"https://api.github.com/repos/mesosphere/universe/stargazers","contributors_url":"https://api.github.com/repos/mesosphere/universe/contributors","subscribers_url":"https://api.github.com/repos/mesosphere/universe/subscribers","subscription_url":"https://api.github.com/repos/mesosphere/universe/subscription","commits_url":"https://api.github.com/repos/mesosphere/universe/commits{/sha}","git_commits_url":"https://api.github.com/repos/mesosphere/universe/git/commits{/sha}","comments_url":"https://api.github.com/repos/mesosphere/universe/comments{/number}","issue_comment_url":"https://api.github.com/repos/mesosphere/universe/issues/comments{/number}","contents_url":"https://api.github.com/repos/mesosphere/universe/contents/{+path}","compare_url":"https://api.github.com/repos/mesosphere/universe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mesosphere/universe/merges","archive_url":"https://api.github.com/repos/mesosphere/universe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mesosphere/universe/downloads","issues_url":"https://api.github.com/repos/mesosphere/universe/issues{/number}","pulls_url":"https://api.github.com/repos/mesosphere/universe/pulls{/number}","milestones_url":"https://api.github.com/repos/mesosphere/universe/milestones{/number}","notifications_url":"https://api.github.com/repos/mesosphere/universe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mesosphere/universe/labels{/name}","releases_url":"https://api.github.com/repos/mesosphere/universe/releases{/id}","created_at":"2014-11-06T21:37:31Z","updated_at":"2015-05-02T04:02:23Z","pushed_at":"2015-05-04T23:54:24Z","git_url":"git://github.com/mesosphere/universe.git","ssh_url":"git@github.com:mesosphere/universe.git","clone_url":"https://github.com/mesosphere/universe.git","svn_url":"https://github.com/mesosphere/universe","homepage":"http://mesosphere.github.io/universe","size":2115,"stargazers_count":11,"watchers_count":11,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6,"mirror_url":null,"open_issues_count":16,"forks":6,"open_issues":16,"watchers":11,"default_branch":"master"}},"base":{"label":"mesosphere:master","ref":"master","sha":"1521dc69d03d57af76fc28b7e9fa907935675a6c","user":{"login":"mesosphere","id":3458585,"avatar_url":"https://avatars.githubusercontent.com/u/3458585?v=3","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"repo":{"id":26291234,"name":"universe","full_name":"mesosphere/universe","owner":{"login":"mesosphere","id":3458585,"avatar_url":"https://avatars.githubusercontent.com/u/3458585?v=3","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mesosphere/universe","description":"The Mesos package repository.","fork":false,"url":"https://api.github.com/repos/mesosphere/universe","forks_url":"https://api.github.com/repos/mesosphere/universe/forks","keys_url":"https://api.github.com/repos/mesosphere/universe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mesosphere/universe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mesosphere/universe/teams","hooks_url":"https://api.github.com/repos/mesosphere/universe/hooks","issue_events_url":"https://api.github.com/repos/mesosphere/universe/issues/events{/number}","events_url":"https://api.github.com/repos/mesosphere/universe/events","assignees_url":"https://api.github.com/repos/mesosphere/universe/assignees{/user}","branches_url":"https://api.github.com/repos/mesosphere/universe/branches{/branch}","tags_url":"https://api.github.com/repos/mesosphere/universe/tags","blobs_url":"https://api.github.com/repos/mesosphere/universe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mesosphere/universe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mesosphere/universe/git/refs{/sha}","trees_url":"https://api.github.com/repos/mesosphere/universe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mesosphere/universe/statuses/{sha}","languages_url":"https://api.github.com/repos/mesosphere/universe/languages","stargazers_url":"https://api.github.com/repos/mesosphere/universe/stargazers","contributors_url":"https://api.github.com/repos/mesosphere/universe/contributors","subscribers_url":"https://api.github.com/repos/mesosphere/universe/subscribers","subscription_url":"https://api.github.com/repos/mesosphere/universe/subscription","commits_url":"https://api.github.com/repos/mesosphere/universe/commits{/sha}","git_commits_url":"https://api.github.com/repos/mesosphere/universe/git/commits{/sha}","comments_url":"https://api.github.com/repos/mesosphere/universe/comments{/number}","issue_comment_url":"https://api.github.com/repos/mesosphere/universe/issues/comments{/number}","contents_url":"https://api.github.com/repos/mesosphere/universe/contents/{+path}","compare_url":"https://api.github.com/repos/mesosphere/universe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mesosphere/universe/merges","archive_url":"https://api.github.com/repos/mesosphere/universe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mesosphere/universe/downloads","issues_url":"https://api.github.com/repos/mesosphere/universe/issues{/number}","pulls_url":"https://api.github.com/repos/mesosphere/universe/pulls{/number}","milestones_url":"https://api.github.com/repos/mesosphere/universe/milestones{/number}","notifications_url":"https://api.github.com/repos/mesosphere/universe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mesosphere/universe/labels{/name}","releases_url":"https://api.github.com/repos/mesosphere/universe/releases{/id}","created_at":"2014-11-06T21:37:31Z","updated_at":"2015-05-02T04:02:23Z","pushed_at":"2015-05-04T23:54:24Z","git_url":"git://github.com/mesosphere/universe.git","ssh_url":"git@github.com:mesosphere/universe.git","clone_url":"https://github.com/mesosphere/universe.git","svn_url":"https://github.com/mesosphere/universe","homepage":"http://mesosphere.github.io/universe","size":2115,"stargazers_count":11,"watchers_count":11,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6,"mirror_url":null,"open_issues_count":16,"forks":6,"open_issues":16,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mesosphere/universe/pulls/106"},"html":{"href":"https://github.com/mesosphere/universe/pull/106"},"issue":{"href":"https://api.github.com/repos/mesosphere/universe/issues/106"},"comments":{"href":"https://api.github.com/repos/mesosphere/universe/issues/106/comments"},"review_comments":{"href":"https://api.github.com/repos/mesosphere/universe/pulls/106/comments"},"review_comment":{"href":"https://api.github.com/repos/mesosphere/universe/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mesosphere/universe/pulls/106/commits"},"statuses":{"href":"https://api.github.com/repos/mesosphere/universe/statuses/c8e8426c4575af81a8833944b0f789e6251cef24"}}}}