{"action":"created","comment":{"url":"https://api.github.com/repos/boostorg/geometry/pulls/comments/26190932","id":26190932,"diff_hunk":"@@ -50,19 +57,21 @@ void test_single_type_result()\n     ));\n }\n \n-\n-int test_main(int, char* [])\n+BOOST_AUTO_TEST_CASE(multiple_type)\n {\n     test_variant_result<\n         boost::variant<int, float, double>,\n-        boost::mpl::vector<int, float, double>\n+        boost::mpl::vector < int, float, double >","path":"test/util/compress_variant.cpp","position":35,"original_position":35,"commit_id":"994945d3bb667cb55d0b83ccf44debbabdf2b1e7","original_commit_id":"994945d3bb667cb55d0b83ccf44debbabdf2b1e7","user":{"login":"mkaravel","id":6397014,"avatar_url":"https://avatars.githubusercontent.com/u/6397014?v=3","gravatar_id":"","url":"https://api.github.com/users/mkaravel","html_url":"https://github.com/mkaravel","followers_url":"https://api.github.com/users/mkaravel/followers","following_url":"https://api.github.com/users/mkaravel/following{/other_user}","gists_url":"https://api.github.com/users/mkaravel/gists{/gist_id}","starred_url":"https://api.github.com/users/mkaravel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkaravel/subscriptions","organizations_url":"https://api.github.com/users/mkaravel/orgs","repos_url":"https://api.github.com/users/mkaravel/repos","events_url":"https://api.github.com/users/mkaravel/events{/privacy}","received_events_url":"https://api.github.com/users/mkaravel/received_events","type":"User","site_admin":false},"body":"Why did you make this change? AFAIU, what was written was consistent with our coding standards.","created_at":"2015-03-11T06:14:15Z","updated_at":"2015-03-11T06:14:15Z","html_url":"https://github.com/boostorg/geometry/pull/258#discussion_r26190932","pull_request_url":"https://api.github.com/repos/boostorg/geometry/pulls/258","_links":{"self":{"href":"https://api.github.com/repos/boostorg/geometry/pulls/comments/26190932"},"html":{"href":"https://github.com/boostorg/geometry/pull/258#discussion_r26190932"},"pull_request":{"href":"https://api.github.com/repos/boostorg/geometry/pulls/258"}}},"pull_request":{"url":"https://api.github.com/repos/boostorg/geometry/pulls/258","id":30898442,"html_url":"https://github.com/boostorg/geometry/pull/258","diff_url":"https://github.com/boostorg/geometry/pull/258.diff","patch_url":"https://github.com/boostorg/geometry/pull/258.patch","issue_url":"https://api.github.com/repos/boostorg/geometry/issues/258","number":258,"state":"open","locked":false,"title":"Improve testing of util","user":{"login":"sdebionne","id":4699120,"avatar_url":"https://avatars.githubusercontent.com/u/4699120?v=3","gravatar_id":"","url":"https://api.github.com/users/sdebionne","html_url":"https://github.com/sdebionne","followers_url":"https://api.github.com/users/sdebionne/followers","following_url":"https://api.github.com/users/sdebionne/following{/other_user}","gists_url":"https://api.github.com/users/sdebionne/gists{/gist_id}","starred_url":"https://api.github.com/users/sdebionne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdebionne/subscriptions","organizations_url":"https://api.github.com/users/sdebionne/orgs","repos_url":"https://api.github.com/users/sdebionne/repos","events_url":"https://api.github.com/users/sdebionne/events{/privacy}","received_events_url":"https://api.github.com/users/sdebionne/received_events","type":"User","site_admin":false},"body":"This PR aims to improve the testing of the util part of the library.\r\n- Use the pre-build UTF when building with b2 (default remains inline UTF) to improve compile time.\r\n- Adapt Jamfile to use the `unit-test` rule rather than the deprecated `test-suite` rule to improve error reporting.\r\n- Make every test suites a separate target so that, for example, `b2 range` will build and run the range test suite only.\r\n- Use BOOST_TEST_MODULE, BOOST_AUTO_TEST_SUITE and BOOST_AUTO_TEST_CASE to better identify the tests and improve the test report.\r\n- Add unused but valid tests for variant (compress_variant, transform_variant)\r\n- Remove unused (not in the Jamfile) tests (as_range and is_implemented).\r\n","created_at":"2015-03-10T22:18:26Z","updated_at":"2015-03-11T06:14:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"153bc59111f02ad3bd50c171cd5661ea71ef56ec","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/boostorg/geometry/pulls/258/commits","review_comments_url":"https://api.github.com/repos/boostorg/geometry/pulls/258/comments","review_comment_url":"https://api.github.com/repos/boostorg/geometry/pulls/comments{/number}","comments_url":"https://api.github.com/repos/boostorg/geometry/issues/258/comments","statuses_url":"https://api.github.com/repos/boostorg/geometry/statuses/994945d3bb667cb55d0b83ccf44debbabdf2b1e7","head":{"label":"sdebionne:fix/test_util","ref":"fix/test_util","sha":"994945d3bb667cb55d0b83ccf44debbabdf2b1e7","user":{"login":"sdebionne","id":4699120,"avatar_url":"https://avatars.githubusercontent.com/u/4699120?v=3","gravatar_id":"","url":"https://api.github.com/users/sdebionne","html_url":"https://github.com/sdebionne","followers_url":"https://api.github.com/users/sdebionne/followers","following_url":"https://api.github.com/users/sdebionne/following{/other_user}","gists_url":"https://api.github.com/users/sdebionne/gists{/gist_id}","starred_url":"https://api.github.com/users/sdebionne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdebionne/subscriptions","organizations_url":"https://api.github.com/users/sdebionne/orgs","repos_url":"https://api.github.com/users/sdebionne/repos","events_url":"https://api.github.com/users/sdebionne/events{/privacy}","received_events_url":"https://api.github.com/users/sdebionne/received_events","type":"User","site_admin":false},"repo":{"id":30655482,"name":"geometry","full_name":"sdebionne/geometry","owner":{"login":"sdebionne","id":4699120,"avatar_url":"https://avatars.githubusercontent.com/u/4699120?v=3","gravatar_id":"","url":"https://api.github.com/users/sdebionne","html_url":"https://github.com/sdebionne","followers_url":"https://api.github.com/users/sdebionne/followers","following_url":"https://api.github.com/users/sdebionne/following{/other_user}","gists_url":"https://api.github.com/users/sdebionne/gists{/gist_id}","starred_url":"https://api.github.com/users/sdebionne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdebionne/subscriptions","organizations_url":"https://api.github.com/users/sdebionne/orgs","repos_url":"https://api.github.com/users/sdebionne/repos","events_url":"https://api.github.com/users/sdebionne/events{/privacy}","received_events_url":"https://api.github.com/users/sdebionne/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sdebionne/geometry","description":"Boost.org geometry module","fork":true,"url":"https://api.github.com/repos/sdebionne/geometry","forks_url":"https://api.github.com/repos/sdebionne/geometry/forks","keys_url":"https://api.github.com/repos/sdebionne/geometry/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sdebionne/geometry/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sdebionne/geometry/teams","hooks_url":"https://api.github.com/repos/sdebionne/geometry/hooks","issue_events_url":"https://api.github.com/repos/sdebionne/geometry/issues/events{/number}","events_url":"https://api.github.com/repos/sdebionne/geometry/events","assignees_url":"https://api.github.com/repos/sdebionne/geometry/assignees{/user}","branches_url":"https://api.github.com/repos/sdebionne/geometry/branches{/branch}","tags_url":"https://api.github.com/repos/sdebionne/geometry/tags","blobs_url":"https://api.github.com/repos/sdebionne/geometry/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sdebionne/geometry/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sdebionne/geometry/git/refs{/sha}","trees_url":"https://api.github.com/repos/sdebionne/geometry/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sdebionne/geometry/statuses/{sha}","languages_url":"https://api.github.com/repos/sdebionne/geometry/languages","stargazers_url":"https://api.github.com/repos/sdebionne/geometry/stargazers","contributors_url":"https://api.github.com/repos/sdebionne/geometry/contributors","subscribers_url":"https://api.github.com/repos/sdebionne/geometry/subscribers","subscription_url":"https://api.github.com/repos/sdebionne/geometry/subscription","commits_url":"https://api.github.com/repos/sdebionne/geometry/commits{/sha}","git_commits_url":"https://api.github.com/repos/sdebionne/geometry/git/commits{/sha}","comments_url":"https://api.github.com/repos/sdebionne/geometry/comments{/number}","issue_comment_url":"https://api.github.com/repos/sdebionne/geometry/issues/comments{/number}","contents_url":"https://api.github.com/repos/sdebionne/geometry/contents/{+path}","compare_url":"https://api.github.com/repos/sdebionne/geometry/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sdebionne/geometry/merges","archive_url":"https://api.github.com/repos/sdebionne/geometry/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sdebionne/geometry/downloads","issues_url":"https://api.github.com/repos/sdebionne/geometry/issues{/number}","pulls_url":"https://api.github.com/repos/sdebionne/geometry/pulls{/number}","milestones_url":"https://api.github.com/repos/sdebionne/geometry/milestones{/number}","notifications_url":"https://api.github.com/repos/sdebionne/geometry/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sdebionne/geometry/labels{/name}","releases_url":"https://api.github.com/repos/sdebionne/geometry/releases{/id}","created_at":"2015-02-11T15:52:13Z","updated_at":"2015-02-11T15:52:17Z","pushed_at":"2015-03-10T22:14:11Z","git_url":"git://github.com/sdebionne/geometry.git","ssh_url":"git@github.com:sdebionne/geometry.git","clone_url":"https://github.com/sdebionne/geometry.git","svn_url":"https://github.com/sdebionne/geometry","homepage":"http://boost.org/libs/geometry","size":33951,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"boostorg:develop","ref":"develop","sha":"666837bcb96ce5c5fa3b25ec677dc6be80cb2afb","user":{"login":"boostorg","id":3170529,"avatar_url":"https://avatars.githubusercontent.com/u/3170529?v=3","gravatar_id":"","url":"https://api.github.com/users/boostorg","html_url":"https://github.com/boostorg","followers_url":"https://api.github.com/users/boostorg/followers","following_url":"https://api.github.com/users/boostorg/following{/other_user}","gists_url":"https://api.github.com/users/boostorg/gists{/gist_id}","starred_url":"https://api.github.com/users/boostorg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boostorg/subscriptions","organizations_url":"https://api.github.com/users/boostorg/orgs","repos_url":"https://api.github.com/users/boostorg/repos","events_url":"https://api.github.com/users/boostorg/events{/privacy}","received_events_url":"https://api.github.com/users/boostorg/received_events","type":"Organization","site_admin":false},"repo":{"id":7590021,"name":"geometry","full_name":"boostorg/geometry","owner":{"login":"boostorg","id":3170529,"avatar_url":"https://avatars.githubusercontent.com/u/3170529?v=3","gravatar_id":"","url":"https://api.github.com/users/boostorg","html_url":"https://github.com/boostorg","followers_url":"https://api.github.com/users/boostorg/followers","following_url":"https://api.github.com/users/boostorg/following{/other_user}","gists_url":"https://api.github.com/users/boostorg/gists{/gist_id}","starred_url":"https://api.github.com/users/boostorg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boostorg/subscriptions","organizations_url":"https://api.github.com/users/boostorg/orgs","repos_url":"https://api.github.com/users/boostorg/repos","events_url":"https://api.github.com/users/boostorg/events{/privacy}","received_events_url":"https://api.github.com/users/boostorg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/boostorg/geometry","description":"Boost.org geometry module","fork":false,"url":"https://api.github.com/repos/boostorg/geometry","forks_url":"https://api.github.com/repos/boostorg/geometry/forks","keys_url":"https://api.github.com/repos/boostorg/geometry/keys{/key_id}","collaborators_url":"https://api.github.com/repos/boostorg/geometry/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/boostorg/geometry/teams","hooks_url":"https://api.github.com/repos/boostorg/geometry/hooks","issue_events_url":"https://api.github.com/repos/boostorg/geometry/issues/events{/number}","events_url":"https://api.github.com/repos/boostorg/geometry/events","assignees_url":"https://api.github.com/repos/boostorg/geometry/assignees{/user}","branches_url":"https://api.github.com/repos/boostorg/geometry/branches{/branch}","tags_url":"https://api.github.com/repos/boostorg/geometry/tags","blobs_url":"https://api.github.com/repos/boostorg/geometry/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/boostorg/geometry/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/boostorg/geometry/git/refs{/sha}","trees_url":"https://api.github.com/repos/boostorg/geometry/git/trees{/sha}","statuses_url":"https://api.github.com/repos/boostorg/geometry/statuses/{sha}","languages_url":"https://api.github.com/repos/boostorg/geometry/languages","stargazers_url":"https://api.github.com/repos/boostorg/geometry/stargazers","contributors_url":"https://api.github.com/repos/boostorg/geometry/contributors","subscribers_url":"https://api.github.com/repos/boostorg/geometry/subscribers","subscription_url":"https://api.github.com/repos/boostorg/geometry/subscription","commits_url":"https://api.github.com/repos/boostorg/geometry/commits{/sha}","git_commits_url":"https://api.github.com/repos/boostorg/geometry/git/commits{/sha}","comments_url":"https://api.github.com/repos/boostorg/geometry/comments{/number}","issue_comment_url":"https://api.github.com/repos/boostorg/geometry/issues/comments{/number}","contents_url":"https://api.github.com/repos/boostorg/geometry/contents/{+path}","compare_url":"https://api.github.com/repos/boostorg/geometry/compare/{base}...{head}","merges_url":"https://api.github.com/repos/boostorg/geometry/merges","archive_url":"https://api.github.com/repos/boostorg/geometry/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/boostorg/geometry/downloads","issues_url":"https://api.github.com/repos/boostorg/geometry/issues{/number}","pulls_url":"https://api.github.com/repos/boostorg/geometry/pulls{/number}","milestones_url":"https://api.github.com/repos/boostorg/geometry/milestones{/number}","notifications_url":"https://api.github.com/repos/boostorg/geometry/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/boostorg/geometry/labels{/name}","releases_url":"https://api.github.com/repos/boostorg/geometry/releases{/id}","created_at":"2013-01-13T15:59:29Z","updated_at":"2015-03-04T18:46:07Z","pushed_at":"2015-03-11T02:56:20Z","git_url":"git://github.com/boostorg/geometry.git","ssh_url":"git@github.com:boostorg/geometry.git","clone_url":"https://github.com/boostorg/geometry.git","svn_url":"https://github.com/boostorg/geometry","homepage":"http://boost.org/libs/geometry","size":47003,"stargazers_count":42,"watchers_count":42,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"open_issues_count":10,"forks":25,"open_issues":10,"watchers":42,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/boostorg/geometry/pulls/258"},"html":{"href":"https://github.com/boostorg/geometry/pull/258"},"issue":{"href":"https://api.github.com/repos/boostorg/geometry/issues/258"},"comments":{"href":"https://api.github.com/repos/boostorg/geometry/issues/258/comments"},"review_comments":{"href":"https://api.github.com/repos/boostorg/geometry/pulls/258/comments"},"review_comment":{"href":"https://api.github.com/repos/boostorg/geometry/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/boostorg/geometry/pulls/258/commits"},"statuses":{"href":"https://api.github.com/repos/boostorg/geometry/statuses/994945d3bb667cb55d0b83ccf44debbabdf2b1e7"}}}}