{"action":"created","comment":{"url":"https://api.github.com/repos/cubing/ccm/pulls/comments/31396121","id":31396121,"diff_hunk":"@@ -30,6 +30,13 @@ _.extend(Round.prototype, {\n     assert(this.eventCode);\n     return wca.eventByCode[this.eventCode].solveTimeFields;\n   },\n+  roundCode: function() {\n+    if(this.isLast()) {\n+      return this.softCutoff ? 'c' : 'f';\n+    } else {\n+      return (this.softCutoff ? 'degc' : '123f')[this.nthRound-1];","path":"both/collections/round.js","position":17,"original_position":17,"commit_id":"6d13188f4eb59b8779f7c006de9abec44fe87e0e","original_commit_id":"d2bb650c0a13aadf7db6697c30386ab0d7db65dd","user":{"login":"jfly","id":277474,"avatar_url":"https://avatars.githubusercontent.com/u/277474?v=3","gravatar_id":"","url":"https://api.github.com/users/jfly","html_url":"https://github.com/jfly","followers_url":"https://api.github.com/users/jfly/followers","following_url":"https://api.github.com/users/jfly/following{/other_user}","gists_url":"https://api.github.com/users/jfly/gists{/gist_id}","starred_url":"https://api.github.com/users/jfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfly/subscriptions","organizations_url":"https://api.github.com/users/jfly/orgs","repos_url":"https://api.github.com/users/jfly/repos","events_url":"https://api.github.com/users/jfly/events{/privacy}","received_events_url":"https://api.github.com/users/jfly/received_events","type":"User","site_admin":false},"body":"I was thinking that `wca.js` is a place to put numbers that come from the regulations, and logic required to produce the [WCA competition JSON format](https://github.com/cubing/worldcubeassociation.org/wiki/WCA-Competition-JSON-Format).\r\n\r\nAfter thinking about this for longer, I would rather that the CCM codebase not deal with WCA round codes unless it is importing or exporting data. That's cleanup for another PR, though (I've created https://github.com/cubing/ccm/issues/247 to track this). Lets leave this code alone for now.","created_at":"2015-06-01T00:20:37Z","updated_at":"2015-06-01T00:20:37Z","html_url":"https://github.com/cubing/ccm/pull/241#discussion_r31396121","pull_request_url":"https://api.github.com/repos/cubing/ccm/pulls/241","_links":{"self":{"href":"https://api.github.com/repos/cubing/ccm/pulls/comments/31396121"},"html":{"href":"https://github.com/cubing/ccm/pull/241#discussion_r31396121"},"pull_request":{"href":"https://api.github.com/repos/cubing/ccm/pulls/241"}}},"pull_request":{"url":"https://api.github.com/repos/cubing/ccm/pulls/241","id":35986073,"html_url":"https://github.com/cubing/ccm/pull/241","diff_url":"https://github.com/cubing/ccm/pull/241.diff","patch_url":"https://github.com/cubing/ccm/pull/241.patch","issue_url":"https://api.github.com/repos/cubing/ccm/issues/241","number":241,"state":"open","locked":false,"title":"Added Rounds.totalCount, removed refreshRoundCodes, made Rounds.roundCode a function, and made better round names in the Schedule.","user":{"login":"larspetrus","id":755243,"avatar_url":"https://avatars.githubusercontent.com/u/755243?v=3","gravatar_id":"","url":"https://api.github.com/users/larspetrus","html_url":"https://github.com/larspetrus","followers_url":"https://api.github.com/users/larspetrus/followers","following_url":"https://api.github.com/users/larspetrus/following{/other_user}","gists_url":"https://api.github.com/users/larspetrus/gists{/gist_id}","starred_url":"https://api.github.com/users/larspetrus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/larspetrus/subscriptions","organizations_url":"https://api.github.com/users/larspetrus/orgs","repos_url":"https://api.github.com/users/larspetrus/repos","events_url":"https://api.github.com/users/larspetrus/events{/privacy}","received_events_url":"https://api.github.com/users/larspetrus/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-05-21T22:54:24Z","updated_at":"2015-06-01T00:20:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"22d0b359f80caa78a9c59b96cc7165e6e9d53ffb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cubing/ccm/pulls/241/commits","review_comments_url":"https://api.github.com/repos/cubing/ccm/pulls/241/comments","review_comment_url":"https://api.github.com/repos/cubing/ccm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cubing/ccm/issues/241/comments","statuses_url":"https://api.github.com/repos/cubing/ccm/statuses/6d13188f4eb59b8779f7c006de9abec44fe87e0e","head":{"label":"larspetrus:master","ref":"master","sha":"6d13188f4eb59b8779f7c006de9abec44fe87e0e","user":{"login":"larspetrus","id":755243,"avatar_url":"https://avatars.githubusercontent.com/u/755243?v=3","gravatar_id":"","url":"https://api.github.com/users/larspetrus","html_url":"https://github.com/larspetrus","followers_url":"https://api.github.com/users/larspetrus/followers","following_url":"https://api.github.com/users/larspetrus/following{/other_user}","gists_url":"https://api.github.com/users/larspetrus/gists{/gist_id}","starred_url":"https://api.github.com/users/larspetrus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/larspetrus/subscriptions","organizations_url":"https://api.github.com/users/larspetrus/orgs","repos_url":"https://api.github.com/users/larspetrus/repos","events_url":"https://api.github.com/users/larspetrus/events{/privacy}","received_events_url":"https://api.github.com/users/larspetrus/received_events","type":"User","site_admin":false},"repo":{"id":30138798,"name":"ccm","full_name":"larspetrus/ccm","owner":{"login":"larspetrus","id":755243,"avatar_url":"https://avatars.githubusercontent.com/u/755243?v=3","gravatar_id":"","url":"https://api.github.com/users/larspetrus","html_url":"https://github.com/larspetrus","followers_url":"https://api.github.com/users/larspetrus/followers","following_url":"https://api.github.com/users/larspetrus/following{/other_user}","gists_url":"https://api.github.com/users/larspetrus/gists{/gist_id}","starred_url":"https://api.github.com/users/larspetrus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/larspetrus/subscriptions","organizations_url":"https://api.github.com/users/larspetrus/orgs","repos_url":"https://api.github.com/users/larspetrus/repos","events_url":"https://api.github.com/users/larspetrus/events{/privacy}","received_events_url":"https://api.github.com/users/larspetrus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/larspetrus/ccm","description":"Cubing Competition Manager","fork":true,"url":"https://api.github.com/repos/larspetrus/ccm","forks_url":"https://api.github.com/repos/larspetrus/ccm/forks","keys_url":"https://api.github.com/repos/larspetrus/ccm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/larspetrus/ccm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/larspetrus/ccm/teams","hooks_url":"https://api.github.com/repos/larspetrus/ccm/hooks","issue_events_url":"https://api.github.com/repos/larspetrus/ccm/issues/events{/number}","events_url":"https://api.github.com/repos/larspetrus/ccm/events","assignees_url":"https://api.github.com/repos/larspetrus/ccm/assignees{/user}","branches_url":"https://api.github.com/repos/larspetrus/ccm/branches{/branch}","tags_url":"https://api.github.com/repos/larspetrus/ccm/tags","blobs_url":"https://api.github.com/repos/larspetrus/ccm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/larspetrus/ccm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/larspetrus/ccm/git/refs{/sha}","trees_url":"https://api.github.com/repos/larspetrus/ccm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/larspetrus/ccm/statuses/{sha}","languages_url":"https://api.github.com/repos/larspetrus/ccm/languages","stargazers_url":"https://api.github.com/repos/larspetrus/ccm/stargazers","contributors_url":"https://api.github.com/repos/larspetrus/ccm/contributors","subscribers_url":"https://api.github.com/repos/larspetrus/ccm/subscribers","subscription_url":"https://api.github.com/repos/larspetrus/ccm/subscription","commits_url":"https://api.github.com/repos/larspetrus/ccm/commits{/sha}","git_commits_url":"https://api.github.com/repos/larspetrus/ccm/git/commits{/sha}","comments_url":"https://api.github.com/repos/larspetrus/ccm/comments{/number}","issue_comment_url":"https://api.github.com/repos/larspetrus/ccm/issues/comments{/number}","contents_url":"https://api.github.com/repos/larspetrus/ccm/contents/{+path}","compare_url":"https://api.github.com/repos/larspetrus/ccm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/larspetrus/ccm/merges","archive_url":"https://api.github.com/repos/larspetrus/ccm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/larspetrus/ccm/downloads","issues_url":"https://api.github.com/repos/larspetrus/ccm/issues{/number}","pulls_url":"https://api.github.com/repos/larspetrus/ccm/pulls{/number}","milestones_url":"https://api.github.com/repos/larspetrus/ccm/milestones{/number}","notifications_url":"https://api.github.com/repos/larspetrus/ccm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/larspetrus/ccm/labels{/name}","releases_url":"https://api.github.com/repos/larspetrus/ccm/releases{/id}","created_at":"2015-02-01T06:47:36Z","updated_at":"2015-04-23T01:30:25Z","pushed_at":"2015-05-30T19:05:37Z","git_url":"git://github.com/larspetrus/ccm.git","ssh_url":"git@github.com:larspetrus/ccm.git","clone_url":"https://github.com/larspetrus/ccm.git","svn_url":"https://github.com/larspetrus/ccm","homepage":"http://live.jflei.com","size":2759,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cubing:master","ref":"master","sha":"5919c0f39436b04e280cc3400f2fd9af4a485993","user":{"login":"cubing","id":1092267,"avatar_url":"https://avatars.githubusercontent.com/u/1092267?v=3","gravatar_id":"","url":"https://api.github.com/users/cubing","html_url":"https://github.com/cubing","followers_url":"https://api.github.com/users/cubing/followers","following_url":"https://api.github.com/users/cubing/following{/other_user}","gists_url":"https://api.github.com/users/cubing/gists{/gist_id}","starred_url":"https://api.github.com/users/cubing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cubing/subscriptions","organizations_url":"https://api.github.com/users/cubing/orgs","repos_url":"https://api.github.com/users/cubing/repos","events_url":"https://api.github.com/users/cubing/events{/privacy}","received_events_url":"https://api.github.com/users/cubing/received_events","type":"Organization","site_admin":false},"repo":{"id":22803845,"name":"ccm","full_name":"cubing/ccm","owner":{"login":"cubing","id":1092267,"avatar_url":"https://avatars.githubusercontent.com/u/1092267?v=3","gravatar_id":"","url":"https://api.github.com/users/cubing","html_url":"https://github.com/cubing","followers_url":"https://api.github.com/users/cubing/followers","following_url":"https://api.github.com/users/cubing/following{/other_user}","gists_url":"https://api.github.com/users/cubing/gists{/gist_id}","starred_url":"https://api.github.com/users/cubing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cubing/subscriptions","organizations_url":"https://api.github.com/users/cubing/orgs","repos_url":"https://api.github.com/users/cubing/repos","events_url":"https://api.github.com/users/cubing/events{/privacy}","received_events_url":"https://api.github.com/users/cubing/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cubing/ccm","description":"Cubing Competition Manager","fork":false,"url":"https://api.github.com/repos/cubing/ccm","forks_url":"https://api.github.com/repos/cubing/ccm/forks","keys_url":"https://api.github.com/repos/cubing/ccm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cubing/ccm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cubing/ccm/teams","hooks_url":"https://api.github.com/repos/cubing/ccm/hooks","issue_events_url":"https://api.github.com/repos/cubing/ccm/issues/events{/number}","events_url":"https://api.github.com/repos/cubing/ccm/events","assignees_url":"https://api.github.com/repos/cubing/ccm/assignees{/user}","branches_url":"https://api.github.com/repos/cubing/ccm/branches{/branch}","tags_url":"https://api.github.com/repos/cubing/ccm/tags","blobs_url":"https://api.github.com/repos/cubing/ccm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cubing/ccm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cubing/ccm/git/refs{/sha}","trees_url":"https://api.github.com/repos/cubing/ccm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cubing/ccm/statuses/{sha}","languages_url":"https://api.github.com/repos/cubing/ccm/languages","stargazers_url":"https://api.github.com/repos/cubing/ccm/stargazers","contributors_url":"https://api.github.com/repos/cubing/ccm/contributors","subscribers_url":"https://api.github.com/repos/cubing/ccm/subscribers","subscription_url":"https://api.github.com/repos/cubing/ccm/subscription","commits_url":"https://api.github.com/repos/cubing/ccm/commits{/sha}","git_commits_url":"https://api.github.com/repos/cubing/ccm/git/commits{/sha}","comments_url":"https://api.github.com/repos/cubing/ccm/comments{/number}","issue_comment_url":"https://api.github.com/repos/cubing/ccm/issues/comments{/number}","contents_url":"https://api.github.com/repos/cubing/ccm/contents/{+path}","compare_url":"https://api.github.com/repos/cubing/ccm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cubing/ccm/merges","archive_url":"https://api.github.com/repos/cubing/ccm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cubing/ccm/downloads","issues_url":"https://api.github.com/repos/cubing/ccm/issues{/number}","pulls_url":"https://api.github.com/repos/cubing/ccm/pulls{/number}","milestones_url":"https://api.github.com/repos/cubing/ccm/milestones{/number}","notifications_url":"https://api.github.com/repos/cubing/ccm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cubing/ccm/labels{/name}","releases_url":"https://api.github.com/repos/cubing/ccm/releases{/id}","created_at":"2014-08-10T07:10:06Z","updated_at":"2015-05-09T11:55:24Z","pushed_at":"2015-05-30T19:05:37Z","git_url":"git://github.com/cubing/ccm.git","ssh_url":"git@github.com:cubing/ccm.git","clone_url":"https://github.com/cubing/ccm.git","svn_url":"https://github.com/cubing/ccm","homepage":"https://live.cubing.net","size":5731,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":99,"forks":7,"open_issues":99,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cubing/ccm/pulls/241"},"html":{"href":"https://github.com/cubing/ccm/pull/241"},"issue":{"href":"https://api.github.com/repos/cubing/ccm/issues/241"},"comments":{"href":"https://api.github.com/repos/cubing/ccm/issues/241/comments"},"review_comments":{"href":"https://api.github.com/repos/cubing/ccm/pulls/241/comments"},"review_comment":{"href":"https://api.github.com/repos/cubing/ccm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cubing/ccm/pulls/241/commits"},"statuses":{"href":"https://api.github.com/repos/cubing/ccm/statuses/6d13188f4eb59b8779f7c006de9abec44fe87e0e"}}}}