{"action":"created","comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/25875451","id":25875451,"diff_hunk":"@@ -31,6 +42,48 @@ EcalUncalibRecHitProducer::~EcalUncalibRecHitProducer()\n         delete worker_;\n }\n \n+void EcalUncalibRecHitProducer::fillDescriptions(edm::ConfigurationDescriptions& descriptions) {\n+\n+  EcalUncalibRecHitFillDescriptionWorkerFactory* factory = EcalUncalibRecHitFillDescriptionWorkerFactory::get(); \n+  std::vector<edmplugin::PluginInfo> infos = factory->available();\n+ \n+  {\n+    edm::ParameterSetDescription desc;\n+    desc.add<edm::InputTag>(\"EBdigiCollection\", edm::InputTag(\"ecalDigis\",\"ebDigis\"));\n+    desc.add<std::string>(\"EEhitCollection\", \"EcalUncalibRecHitsEE\");\n+    desc.add<edm::InputTag>(\"EEdigiCollection\", edm::InputTag(\"ecalDigis\",\"eeDigis\"));\n+    desc.add<std::string>(\"EBhitCollection\", \"EcalUncalibRecHitsEB\");\n+\n+    auto itInfos = infos.begin();\n+    assert(itInfos != infos.end());\n+\n+    std::auto_ptr<edm::ParameterDescriptionCases<std::string>> s;\n+    {\n+      s = itInfos->name_ >> edm::ParameterDescription<edm::ParameterSetDescription>(\"algoPSet\", EcalUncalibRecHitFillDescriptionWorkerFactory::get()->create(itInfos->name_)->getAlgoDescription(), true);\n+    }\n+    for (++itInfos; itInfos != infos.end(); ++itInfos)","path":"RecoLocalCalo/EcalRecProducers/plugins/EcalUncalibRecHitProducer.cc","position":61,"original_position":61,"commit_id":"c7fd614eebe35854fdcee3c780ddb9eccac3e707","original_commit_id":"c7fd614eebe35854fdcee3c780ddb9eccac3e707","user":{"login":"cvuosalo","id":5736159,"avatar_url":"https://avatars.githubusercontent.com/u/5736159?v=3","gravatar_id":"","url":"https://api.github.com/users/cvuosalo","html_url":"https://github.com/cvuosalo","followers_url":"https://api.github.com/users/cvuosalo/followers","following_url":"https://api.github.com/users/cvuosalo/following{/other_user}","gists_url":"https://api.github.com/users/cvuosalo/gists{/gist_id}","starred_url":"https://api.github.com/users/cvuosalo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cvuosalo/subscriptions","organizations_url":"https://api.github.com/users/cvuosalo/orgs","repos_url":"https://api.github.com/users/cvuosalo/repos","events_url":"https://api.github.com/users/cvuosalo/events{/privacy}","received_events_url":"https://api.github.com/users/cvuosalo/received_events","type":"User","site_admin":false},"body":"It would be helpful if a comment was added here explaining why this separate block ({}) is necessary.","created_at":"2015-03-05T16:11:18Z","updated_at":"2015-03-05T16:11:18Z","html_url":"https://github.com/cms-sw/cmssw/pull/8071#discussion_r25875451","pull_request_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/8071","_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/25875451"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/8071#discussion_r25875451"},"pull_request":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/8071"}}},"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/8071","id":30476731,"html_url":"https://github.com/cms-sw/cmssw/pull/8071","diff_url":"https://github.com/cms-sw/cmssw/pull/8071.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/8071.patch","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/8071","number":8071,"state":"open","locked":false,"title":"HLT menu updates 74X","user":{"login":"perrotta","id":4069749,"avatar_url":"https://avatars.githubusercontent.com/u/4069749?v=3","gravatar_id":"","url":"https://api.github.com/users/perrotta","html_url":"https://github.com/perrotta","followers_url":"https://api.github.com/users/perrotta/followers","following_url":"https://api.github.com/users/perrotta/following{/other_user}","gists_url":"https://api.github.com/users/perrotta/gists{/gist_id}","starred_url":"https://api.github.com/users/perrotta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/perrotta/subscriptions","organizations_url":"https://api.github.com/users/perrotta/orgs","repos_url":"https://api.github.com/users/perrotta/repos","events_url":"https://api.github.com/users/perrotta/events{/privacy}","received_events_url":"https://api.github.com/users/perrotta/received_events","type":"User","site_admin":false},"body":"Update the HLT menu for Run2 on top of #7915 with the following additions:\r\n- Fix two sequences from where HLTDoFullUnpackingEgammaEcalSequence was missing, after CMSHLT-246\r\n- Move muon PF isolation to regional PF isolation around muon, CMSHLT-272\r\n- Low-lumi single Electron paths, CMSHLT-269\r\n- Monitoring paths for Tracker and for DT's, CMSHLT-261\r\n- FSQ paths for LHCf run, CMSHLT-260\r\n- Fix two PSets for Tracking\r\n- Add hltESPChi2MeasurementEstimatorNN ESModules, to be used in the 50ns menu.\r\n- Threshold fix for two dilepton + HT trigger, CMSHLT-271\r\n- Rename the electron sequence of the Ele22+Tau20 path for 25ns, CMSHLT-270\r\n- More fixes from CMSHLT-246: change parameter value and remove HLTDoFullUnpackingEgammaEcalSequence from HLTPFClusteringForEgammaUnseeded\r\n\r\nThis is the 74X version of #8070\r\n\r\nThe other signatures besides HLT are only needed here because I had to merge the previous #7915, on which this pull request depends, and which is fully signed by now (even if not yet merged in 74X). If this pull request will be fully signed again before #7915 gets merged, then we can close the old one and continue with this one only. Otherwise, once #7915 is merged we will rebase this one and the need for the other signatures will disappear","created_at":"2015-03-04T15:51:21Z","updated_at":"2015-03-05T16:11:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"81c5f8baaf98207e9f563f711ba86c0c278cf7c4","assignee":null,"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/50","html_url":"https://github.com/cms-sw/cmssw/milestones/Next%20CMSSW_7_4_X","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/50/labels","id":875803,"number":50,"title":"Next CMSSW_7_4_X","description":"","creator":{"login":"nclopezo","id":1944922,"avatar_url":"https://avatars.githubusercontent.com/u/1944922?v=3","gravatar_id":"","url":"https://api.github.com/users/nclopezo","html_url":"https://github.com/nclopezo","followers_url":"https://api.github.com/users/nclopezo/followers","following_url":"https://api.github.com/users/nclopezo/following{/other_user}","gists_url":"https://api.github.com/users/nclopezo/gists{/gist_id}","starred_url":"https://api.github.com/users/nclopezo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nclopezo/subscriptions","organizations_url":"https://api.github.com/users/nclopezo/orgs","repos_url":"https://api.github.com/users/nclopezo/repos","events_url":"https://api.github.com/users/nclopezo/events{/privacy}","received_events_url":"https://api.github.com/users/nclopezo/received_events","type":"User","site_admin":false},"open_issues":37,"closed_issues":798,"state":"open","created_at":"2014-11-21T15:23:58Z","updated_at":"2015-03-05T15:42:08Z","due_on":"2015-01-26T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/8071/commits","review_comments_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/8071/comments","review_comment_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/8071/comments","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/c7fd614eebe35854fdcee3c780ddb9eccac3e707","head":{"label":"cms-tsg-storm:hltMenuUpdates_74X","ref":"hltMenuUpdates_74X","sha":"c7fd614eebe35854fdcee3c780ddb9eccac3e707","user":{"login":"cms-tsg-storm","id":10458313,"avatar_url":"https://avatars.githubusercontent.com/u/10458313?v=3","gravatar_id":"","url":"https://api.github.com/users/cms-tsg-storm","html_url":"https://github.com/cms-tsg-storm","followers_url":"https://api.github.com/users/cms-tsg-storm/followers","following_url":"https://api.github.com/users/cms-tsg-storm/following{/other_user}","gists_url":"https://api.github.com/users/cms-tsg-storm/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-tsg-storm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-tsg-storm/subscriptions","organizations_url":"https://api.github.com/users/cms-tsg-storm/orgs","repos_url":"https://api.github.com/users/cms-tsg-storm/repos","events_url":"https://api.github.com/users/cms-tsg-storm/events{/privacy}","received_events_url":"https://api.github.com/users/cms-tsg-storm/received_events","type":"Organization","site_admin":false},"repo":{"id":28998004,"name":"cmssw","full_name":"cms-tsg-storm/cmssw","owner":{"login":"cms-tsg-storm","id":10458313,"avatar_url":"https://avatars.githubusercontent.com/u/10458313?v=3","gravatar_id":"","url":"https://api.github.com/users/cms-tsg-storm","html_url":"https://github.com/cms-tsg-storm","followers_url":"https://api.github.com/users/cms-tsg-storm/followers","following_url":"https://api.github.com/users/cms-tsg-storm/following{/other_user}","gists_url":"https://api.github.com/users/cms-tsg-storm/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-tsg-storm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-tsg-storm/subscriptions","organizations_url":"https://api.github.com/users/cms-tsg-storm/orgs","repos_url":"https://api.github.com/users/cms-tsg-storm/repos","events_url":"https://api.github.com/users/cms-tsg-storm/events{/privacy}","received_events_url":"https://api.github.com/users/cms-tsg-storm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cms-tsg-storm/cmssw","description":"CMS Offline Software","fork":true,"url":"https://api.github.com/repos/cms-tsg-storm/cmssw","forks_url":"https://api.github.com/repos/cms-tsg-storm/cmssw/forks","keys_url":"https://api.github.com/repos/cms-tsg-storm/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cms-tsg-storm/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cms-tsg-storm/cmssw/teams","hooks_url":"https://api.github.com/repos/cms-tsg-storm/cmssw/hooks","issue_events_url":"https://api.github.com/repos/cms-tsg-storm/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/cms-tsg-storm/cmssw/events","assignees_url":"https://api.github.com/repos/cms-tsg-storm/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/cms-tsg-storm/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/cms-tsg-storm/cmssw/tags","blobs_url":"https://api.github.com/repos/cms-tsg-storm/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cms-tsg-storm/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cms-tsg-storm/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/cms-tsg-storm/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cms-tsg-storm/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/cms-tsg-storm/cmssw/languages","stargazers_url":"https://api.github.com/repos/cms-tsg-storm/cmssw/stargazers","contributors_url":"https://api.github.com/repos/cms-tsg-storm/cmssw/contributors","subscribers_url":"https://api.github.com/repos/cms-tsg-storm/cmssw/subscribers","subscription_url":"https://api.github.com/repos/cms-tsg-storm/cmssw/subscription","commits_url":"https://api.github.com/repos/cms-tsg-storm/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/cms-tsg-storm/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/cms-tsg-storm/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/cms-tsg-storm/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/cms-tsg-storm/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/cms-tsg-storm/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cms-tsg-storm/cmssw/merges","archive_url":"https://api.github.com/repos/cms-tsg-storm/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cms-tsg-storm/cmssw/downloads","issues_url":"https://api.github.com/repos/cms-tsg-storm/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/cms-tsg-storm/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/cms-tsg-storm/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/cms-tsg-storm/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cms-tsg-storm/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/cms-tsg-storm/cmssw/releases{/id}","created_at":"2015-01-09T03:05:43Z","updated_at":"2015-02-08T23:34:26Z","pushed_at":"2015-03-04T15:34:26Z","git_url":"git://github.com/cms-tsg-storm/cmssw.git","ssh_url":"git@github.com:cms-tsg-storm/cmssw.git","clone_url":"https://github.com/cms-tsg-storm/cmssw.git","svn_url":"https://github.com/cms-tsg-storm/cmssw","homepage":"http://cms-sw.github.io/","size":682421,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"CMSSW_7_4_X"}},"base":{"label":"cms-sw:CMSSW_7_4_X","ref":"CMSSW_7_4_X","sha":"2f37bb6cebc169afa3d73ec2cc7862df5e9824ea","user":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars.githubusercontent.com/u/3863500?v=3","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"repo":{"id":10969551,"name":"cmssw","full_name":"cms-sw/cmssw","owner":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars.githubusercontent.com/u/3863500?v=3","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cms-sw/cmssw","description":"CMS Offline Software","fork":false,"url":"https://api.github.com/repos/cms-sw/cmssw","forks_url":"https://api.github.com/repos/cms-sw/cmssw/forks","keys_url":"https://api.github.com/repos/cms-sw/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cms-sw/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cms-sw/cmssw/teams","hooks_url":"https://api.github.com/repos/cms-sw/cmssw/hooks","issue_events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/cms-sw/cmssw/events","assignees_url":"https://api.github.com/repos/cms-sw/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/cms-sw/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/cms-sw/cmssw/tags","blobs_url":"https://api.github.com/repos/cms-sw/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cms-sw/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cms-sw/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/cms-sw/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/cms-sw/cmssw/languages","stargazers_url":"https://api.github.com/repos/cms-sw/cmssw/stargazers","contributors_url":"https://api.github.com/repos/cms-sw/cmssw/contributors","subscribers_url":"https://api.github.com/repos/cms-sw/cmssw/subscribers","subscription_url":"https://api.github.com/repos/cms-sw/cmssw/subscription","commits_url":"https://api.github.com/repos/cms-sw/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/cms-sw/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/cms-sw/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/cms-sw/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cms-sw/cmssw/merges","archive_url":"https://api.github.com/repos/cms-sw/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cms-sw/cmssw/downloads","issues_url":"https://api.github.com/repos/cms-sw/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/cms-sw/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/cms-sw/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/cms-sw/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cms-sw/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/cms-sw/cmssw/releases{/id}","created_at":"2013-06-26T14:09:07Z","updated_at":"2015-03-04T20:06:49Z","pushed_at":"2015-03-05T14:56:26Z","git_url":"git://github.com/cms-sw/cmssw.git","ssh_url":"git@github.com:cms-sw/cmssw.git","clone_url":"https://github.com/cms-sw/cmssw.git","svn_url":"https://github.com/cms-sw/cmssw","homepage":"http://cms-sw.github.io/","size":878091,"stargazers_count":210,"watchers_count":210,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1280,"mirror_url":null,"open_issues_count":165,"forks":1280,"open_issues":165,"watchers":210,"default_branch":"CMSSW_7_5_X"}},"_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/8071"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/8071"},"issue":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/8071"},"comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/8071/comments"},"review_comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/8071/comments"},"review_comment":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/8071/commits"},"statuses":{"href":"https://api.github.com/repos/cms-sw/cmssw/statuses/c7fd614eebe35854fdcee3c780ddb9eccac3e707"}}}}