{"action":"closed","number":5771,"pull_request":{"url":"https://api.github.com/repos/TryGhost/Ghost/pulls/5771","id":43768940,"html_url":"https://github.com/TryGhost/Ghost/pull/5771","diff_url":"https://github.com/TryGhost/Ghost/pull/5771.diff","patch_url":"https://github.com/TryGhost/Ghost/pull/5771.patch","issue_url":"https://api.github.com/repos/TryGhost/Ghost/issues/5771","number":5771,"state":"closed","locked":false,"title":"[HOLD] Add dynamic client_id/client_secret","user":{"login":"sebgie","id":539213,"avatar_url":"https://avatars.githubusercontent.com/u/539213?v=3","gravatar_id":"","url":"https://api.github.com/users/sebgie","html_url":"https://github.com/sebgie","followers_url":"https://api.github.com/users/sebgie/followers","following_url":"https://api.github.com/users/sebgie/following{/other_user}","gists_url":"https://api.github.com/users/sebgie/gists{/gist_id}","starred_url":"https://api.github.com/users/sebgie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebgie/subscriptions","organizations_url":"https://api.github.com/users/sebgie/orgs","repos_url":"https://api.github.com/users/sebgie/repos","events_url":"https://api.github.com/users/sebgie/events{/privacy}","received_events_url":"https://api.github.com/users/sebgie/received_events","type":"User","site_admin":false},"body":"no issue\r\n- added ghost-admin client_id to admin\r\n- added ghost-admin client_secret to admin\r\n- added client.read() api endpoint\r\n- added random generation of client_secret to migration\r\n- removed addClientSecret method\r\n- updated tests\r\n\r\nThis PR is based on a rebased version of #5706.","created_at":"2015-08-31T14:19:05Z","updated_at":"2015-09-02T13:54:06Z","closed_at":"2015-09-02T13:54:06Z","merged_at":null,"merge_commit_sha":"b0aee3d2955f46285127c04a25729babec4398bd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/TryGhost/Ghost/pulls/5771/commits","review_comments_url":"https://api.github.com/repos/TryGhost/Ghost/pulls/5771/comments","review_comment_url":"https://api.github.com/repos/TryGhost/Ghost/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TryGhost/Ghost/issues/5771/comments","statuses_url":"https://api.github.com/repos/TryGhost/Ghost/statuses/85addf5d5c01b130e95a97018050f53bf63b0347","head":{"label":"sebgie:client-secret","ref":"client-secret","sha":"85addf5d5c01b130e95a97018050f53bf63b0347","user":{"login":"sebgie","id":539213,"avatar_url":"https://avatars.githubusercontent.com/u/539213?v=3","gravatar_id":"","url":"https://api.github.com/users/sebgie","html_url":"https://github.com/sebgie","followers_url":"https://api.github.com/users/sebgie/followers","following_url":"https://api.github.com/users/sebgie/following{/other_user}","gists_url":"https://api.github.com/users/sebgie/gists{/gist_id}","starred_url":"https://api.github.com/users/sebgie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebgie/subscriptions","organizations_url":"https://api.github.com/users/sebgie/orgs","repos_url":"https://api.github.com/users/sebgie/repos","events_url":"https://api.github.com/users/sebgie/events{/privacy}","received_events_url":"https://api.github.com/users/sebgie/received_events","type":"User","site_admin":false},"repo":{"id":12296178,"name":"Ghost","full_name":"sebgie/Ghost","owner":{"login":"sebgie","id":539213,"avatar_url":"https://avatars.githubusercontent.com/u/539213?v=3","gravatar_id":"","url":"https://api.github.com/users/sebgie","html_url":"https://github.com/sebgie","followers_url":"https://api.github.com/users/sebgie/followers","following_url":"https://api.github.com/users/sebgie/following{/other_user}","gists_url":"https://api.github.com/users/sebgie/gists{/gist_id}","starred_url":"https://api.github.com/users/sebgie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebgie/subscriptions","organizations_url":"https://api.github.com/users/sebgie/orgs","repos_url":"https://api.github.com/users/sebgie/repos","events_url":"https://api.github.com/users/sebgie/events{/privacy}","received_events_url":"https://api.github.com/users/sebgie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sebgie/Ghost","description":"Just a blogging platform","fork":true,"url":"https://api.github.com/repos/sebgie/Ghost","forks_url":"https://api.github.com/repos/sebgie/Ghost/forks","keys_url":"https://api.github.com/repos/sebgie/Ghost/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sebgie/Ghost/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sebgie/Ghost/teams","hooks_url":"https://api.github.com/repos/sebgie/Ghost/hooks","issue_events_url":"https://api.github.com/repos/sebgie/Ghost/issues/events{/number}","events_url":"https://api.github.com/repos/sebgie/Ghost/events","assignees_url":"https://api.github.com/repos/sebgie/Ghost/assignees{/user}","branches_url":"https://api.github.com/repos/sebgie/Ghost/branches{/branch}","tags_url":"https://api.github.com/repos/sebgie/Ghost/tags","blobs_url":"https://api.github.com/repos/sebgie/Ghost/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sebgie/Ghost/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sebgie/Ghost/git/refs{/sha}","trees_url":"https://api.github.com/repos/sebgie/Ghost/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sebgie/Ghost/statuses/{sha}","languages_url":"https://api.github.com/repos/sebgie/Ghost/languages","stargazers_url":"https://api.github.com/repos/sebgie/Ghost/stargazers","contributors_url":"https://api.github.com/repos/sebgie/Ghost/contributors","subscribers_url":"https://api.github.com/repos/sebgie/Ghost/subscribers","subscription_url":"https://api.github.com/repos/sebgie/Ghost/subscription","commits_url":"https://api.github.com/repos/sebgie/Ghost/commits{/sha}","git_commits_url":"https://api.github.com/repos/sebgie/Ghost/git/commits{/sha}","comments_url":"https://api.github.com/repos/sebgie/Ghost/comments{/number}","issue_comment_url":"https://api.github.com/repos/sebgie/Ghost/issues/comments{/number}","contents_url":"https://api.github.com/repos/sebgie/Ghost/contents/{+path}","compare_url":"https://api.github.com/repos/sebgie/Ghost/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sebgie/Ghost/merges","archive_url":"https://api.github.com/repos/sebgie/Ghost/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sebgie/Ghost/downloads","issues_url":"https://api.github.com/repos/sebgie/Ghost/issues{/number}","pulls_url":"https://api.github.com/repos/sebgie/Ghost/pulls{/number}","milestones_url":"https://api.github.com/repos/sebgie/Ghost/milestones{/number}","notifications_url":"https://api.github.com/repos/sebgie/Ghost/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sebgie/Ghost/labels{/name}","releases_url":"https://api.github.com/repos/sebgie/Ghost/releases{/id}","created_at":"2013-08-22T12:20:15Z","updated_at":"2015-04-30T15:49:11Z","pushed_at":"2015-09-02T06:55:42Z","git_url":"git://github.com/sebgie/Ghost.git","ssh_url":"git@github.com:sebgie/Ghost.git","clone_url":"https://github.com/sebgie/Ghost.git","svn_url":"https://github.com/sebgie/Ghost","homepage":"http://tryghost.org","size":21869,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"TryGhost:master","ref":"master","sha":"720c421e8bddd146ee79692cdf0e2cd474235f90","user":{"login":"TryGhost","id":2178663,"avatar_url":"https://avatars.githubusercontent.com/u/2178663?v=3","gravatar_id":"","url":"https://api.github.com/users/TryGhost","html_url":"https://github.com/TryGhost","followers_url":"https://api.github.com/users/TryGhost/followers","following_url":"https://api.github.com/users/TryGhost/following{/other_user}","gists_url":"https://api.github.com/users/TryGhost/gists{/gist_id}","starred_url":"https://api.github.com/users/TryGhost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TryGhost/subscriptions","organizations_url":"https://api.github.com/users/TryGhost/orgs","repos_url":"https://api.github.com/users/TryGhost/repos","events_url":"https://api.github.com/users/TryGhost/events{/privacy}","received_events_url":"https://api.github.com/users/TryGhost/received_events","type":"Organization","site_admin":false},"repo":{"id":9852918,"name":"Ghost","full_name":"TryGhost/Ghost","owner":{"login":"TryGhost","id":2178663,"avatar_url":"https://avatars.githubusercontent.com/u/2178663?v=3","gravatar_id":"","url":"https://api.github.com/users/TryGhost","html_url":"https://github.com/TryGhost","followers_url":"https://api.github.com/users/TryGhost/followers","following_url":"https://api.github.com/users/TryGhost/following{/other_user}","gists_url":"https://api.github.com/users/TryGhost/gists{/gist_id}","starred_url":"https://api.github.com/users/TryGhost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TryGhost/subscriptions","organizations_url":"https://api.github.com/users/TryGhost/orgs","repos_url":"https://api.github.com/users/TryGhost/repos","events_url":"https://api.github.com/users/TryGhost/events{/privacy}","received_events_url":"https://api.github.com/users/TryGhost/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TryGhost/Ghost","description":"Just a blogging platform","fork":false,"url":"https://api.github.com/repos/TryGhost/Ghost","forks_url":"https://api.github.com/repos/TryGhost/Ghost/forks","keys_url":"https://api.github.com/repos/TryGhost/Ghost/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TryGhost/Ghost/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TryGhost/Ghost/teams","hooks_url":"https://api.github.com/repos/TryGhost/Ghost/hooks","issue_events_url":"https://api.github.com/repos/TryGhost/Ghost/issues/events{/number}","events_url":"https://api.github.com/repos/TryGhost/Ghost/events","assignees_url":"https://api.github.com/repos/TryGhost/Ghost/assignees{/user}","branches_url":"https://api.github.com/repos/TryGhost/Ghost/branches{/branch}","tags_url":"https://api.github.com/repos/TryGhost/Ghost/tags","blobs_url":"https://api.github.com/repos/TryGhost/Ghost/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TryGhost/Ghost/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TryGhost/Ghost/git/refs{/sha}","trees_url":"https://api.github.com/repos/TryGhost/Ghost/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TryGhost/Ghost/statuses/{sha}","languages_url":"https://api.github.com/repos/TryGhost/Ghost/languages","stargazers_url":"https://api.github.com/repos/TryGhost/Ghost/stargazers","contributors_url":"https://api.github.com/repos/TryGhost/Ghost/contributors","subscribers_url":"https://api.github.com/repos/TryGhost/Ghost/subscribers","subscription_url":"https://api.github.com/repos/TryGhost/Ghost/subscription","commits_url":"https://api.github.com/repos/TryGhost/Ghost/commits{/sha}","git_commits_url":"https://api.github.com/repos/TryGhost/Ghost/git/commits{/sha}","comments_url":"https://api.github.com/repos/TryGhost/Ghost/comments{/number}","issue_comment_url":"https://api.github.com/repos/TryGhost/Ghost/issues/comments{/number}","contents_url":"https://api.github.com/repos/TryGhost/Ghost/contents/{+path}","compare_url":"https://api.github.com/repos/TryGhost/Ghost/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TryGhost/Ghost/merges","archive_url":"https://api.github.com/repos/TryGhost/Ghost/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TryGhost/Ghost/downloads","issues_url":"https://api.github.com/repos/TryGhost/Ghost/issues{/number}","pulls_url":"https://api.github.com/repos/TryGhost/Ghost/pulls{/number}","milestones_url":"https://api.github.com/repos/TryGhost/Ghost/milestones{/number}","notifications_url":"https://api.github.com/repos/TryGhost/Ghost/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TryGhost/Ghost/labels{/name}","releases_url":"https://api.github.com/repos/TryGhost/Ghost/releases{/id}","created_at":"2013-05-04T11:09:13Z","updated_at":"2015-09-02T08:07:04Z","pushed_at":"2015-09-02T12:39:34Z","git_url":"git://github.com/TryGhost/Ghost.git","ssh_url":"git@github.com:TryGhost/Ghost.git","clone_url":"https://github.com/TryGhost/Ghost.git","svn_url":"https://github.com/TryGhost/Ghost","homepage":"https://ghost.org","size":66944,"stargazers_count":16469,"watchers_count":16469,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3938,"mirror_url":null,"open_issues_count":208,"forks":3938,"open_issues":208,"watchers":16469,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TryGhost/Ghost/pulls/5771"},"html":{"href":"https://github.com/TryGhost/Ghost/pull/5771"},"issue":{"href":"https://api.github.com/repos/TryGhost/Ghost/issues/5771"},"comments":{"href":"https://api.github.com/repos/TryGhost/Ghost/issues/5771/comments"},"review_comments":{"href":"https://api.github.com/repos/TryGhost/Ghost/pulls/5771/comments"},"review_comment":{"href":"https://api.github.com/repos/TryGhost/Ghost/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TryGhost/Ghost/pulls/5771/commits"},"statuses":{"href":"https://api.github.com/repos/TryGhost/Ghost/statuses/85addf5d5c01b130e95a97018050f53bf63b0347"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"commits":9,"additions":388,"deletions":240,"changed_files":33}}