{"action":"created","comment":{"url":"https://api.github.com/repos/nipy/nibabel/pulls/comments/41433538","id":41433538,"diff_hunk":"@@ -427,14 +425,12 @@ def add_gifti_data_array(self, dataarr):\n         \"\"\"\n         if isinstance(dataarr, GiftiDataArray):\n             self.darrays.append(dataarr)\n-            self.numDA += 1","path":"nibabel/gifti/gifti.py","position":123,"original_position":123,"commit_id":"a7662ba9fa38d63232a81ec10f4a9e4644424b40","original_commit_id":"a7662ba9fa38d63232a81ec10f4a9e4644424b40","user":{"login":"matthew-brett","id":67612,"avatar_url":"https://avatars.githubusercontent.com/u/67612?v=3","gravatar_id":"","url":"https://api.github.com/users/matthew-brett","html_url":"https://github.com/matthew-brett","followers_url":"https://api.github.com/users/matthew-brett/followers","following_url":"https://api.github.com/users/matthew-brett/following{/other_user}","gists_url":"https://api.github.com/users/matthew-brett/gists{/gist_id}","starred_url":"https://api.github.com/users/matthew-brett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthew-brett/subscriptions","organizations_url":"https://api.github.com/users/matthew-brett/orgs","repos_url":"https://api.github.com/users/matthew-brett/repos","events_url":"https://api.github.com/users/matthew-brett/events{/privacy}","received_events_url":"https://api.github.com/users/matthew-brett/received_events","type":"User","site_admin":false},"body":"Yes, sorry to be confusing - I saw you didn't need the line, but I was wondering if there were tests to make sure the computation was working right.","created_at":"2015-10-07T19:19:29Z","updated_at":"2015-10-07T19:19:29Z","html_url":"https://github.com/nipy/nibabel/pull/353#discussion_r41433538","pull_request_url":"https://api.github.com/repos/nipy/nibabel/pulls/353","_links":{"self":{"href":"https://api.github.com/repos/nipy/nibabel/pulls/comments/41433538"},"html":{"href":"https://github.com/nipy/nibabel/pull/353#discussion_r41433538"},"pull_request":{"href":"https://api.github.com/repos/nipy/nibabel/pulls/353"}}},"pull_request":{"url":"https://api.github.com/repos/nipy/nibabel/pulls/353","id":46974428,"html_url":"https://github.com/nipy/nibabel/pull/353","diff_url":"https://github.com/nipy/nibabel/pull/353.diff","patch_url":"https://github.com/nipy/nibabel/pull/353.patch","issue_url":"https://api.github.com/repos/nipy/nibabel/issues/353","number":353,"state":"open","locked":false,"title":"Use python properties, rather than set/get methods","user":{"login":"bcipolli","id":4072455,"avatar_url":"https://avatars.githubusercontent.com/u/4072455?v=3","gravatar_id":"","url":"https://api.github.com/users/bcipolli","html_url":"https://github.com/bcipolli","followers_url":"https://api.github.com/users/bcipolli/followers","following_url":"https://api.github.com/users/bcipolli/following{/other_user}","gists_url":"https://api.github.com/users/bcipolli/gists{/gist_id}","starred_url":"https://api.github.com/users/bcipolli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcipolli/subscriptions","organizations_url":"https://api.github.com/users/bcipolli/orgs","repos_url":"https://api.github.com/users/bcipolli/repos","events_url":"https://api.github.com/users/bcipolli/events{/privacy}","received_events_url":"https://api.github.com/users/bcipolli/received_events","type":"User","site_admin":false},"body":"`numDA`, `version`, and `filename` properties on GIFTI have `set_` and `get_` methods. Seems cleaner (and more pythonic) to use Python properties instead.\r\n\r\nQuestion: is GIFTI support officially published? I.e. do I need to add deprecation warnings for the old methods, and deprecation tests?\r\n\r\nAlso renamed tests to be clear that they're testing the loading of these properties, not necessarily of their setting or saving.","created_at":"2015-10-07T00:16:05Z","updated_at":"2015-10-07T19:19:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ab4671719293ee12ac52055b45fd76ee0746a063","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nipy/nibabel/pulls/353/commits","review_comments_url":"https://api.github.com/repos/nipy/nibabel/pulls/353/comments","review_comment_url":"https://api.github.com/repos/nipy/nibabel/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nipy/nibabel/issues/353/comments","statuses_url":"https://api.github.com/repos/nipy/nibabel/statuses/a7662ba9fa38d63232a81ec10f4a9e4644424b40","head":{"label":"bcipolli:gifti-fix2","ref":"gifti-fix2","sha":"a7662ba9fa38d63232a81ec10f4a9e4644424b40","user":{"login":"bcipolli","id":4072455,"avatar_url":"https://avatars.githubusercontent.com/u/4072455?v=3","gravatar_id":"","url":"https://api.github.com/users/bcipolli","html_url":"https://github.com/bcipolli","followers_url":"https://api.github.com/users/bcipolli/followers","following_url":"https://api.github.com/users/bcipolli/following{/other_user}","gists_url":"https://api.github.com/users/bcipolli/gists{/gist_id}","starred_url":"https://api.github.com/users/bcipolli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcipolli/subscriptions","organizations_url":"https://api.github.com/users/bcipolli/orgs","repos_url":"https://api.github.com/users/bcipolli/repos","events_url":"https://api.github.com/users/bcipolli/events{/privacy}","received_events_url":"https://api.github.com/users/bcipolli/received_events","type":"User","site_admin":false},"repo":{"id":31253147,"name":"nibabel","full_name":"bcipolli/nibabel","owner":{"login":"bcipolli","id":4072455,"avatar_url":"https://avatars.githubusercontent.com/u/4072455?v=3","gravatar_id":"","url":"https://api.github.com/users/bcipolli","html_url":"https://github.com/bcipolli","followers_url":"https://api.github.com/users/bcipolli/followers","following_url":"https://api.github.com/users/bcipolli/following{/other_user}","gists_url":"https://api.github.com/users/bcipolli/gists{/gist_id}","starred_url":"https://api.github.com/users/bcipolli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcipolli/subscriptions","organizations_url":"https://api.github.com/users/bcipolli/orgs","repos_url":"https://api.github.com/users/bcipolli/repos","events_url":"https://api.github.com/users/bcipolli/events{/privacy}","received_events_url":"https://api.github.com/users/bcipolli/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bcipolli/nibabel","description":"Python package to access a cacophony of neuro-imaging file formats","fork":true,"url":"https://api.github.com/repos/bcipolli/nibabel","forks_url":"https://api.github.com/repos/bcipolli/nibabel/forks","keys_url":"https://api.github.com/repos/bcipolli/nibabel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bcipolli/nibabel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bcipolli/nibabel/teams","hooks_url":"https://api.github.com/repos/bcipolli/nibabel/hooks","issue_events_url":"https://api.github.com/repos/bcipolli/nibabel/issues/events{/number}","events_url":"https://api.github.com/repos/bcipolli/nibabel/events","assignees_url":"https://api.github.com/repos/bcipolli/nibabel/assignees{/user}","branches_url":"https://api.github.com/repos/bcipolli/nibabel/branches{/branch}","tags_url":"https://api.github.com/repos/bcipolli/nibabel/tags","blobs_url":"https://api.github.com/repos/bcipolli/nibabel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bcipolli/nibabel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bcipolli/nibabel/git/refs{/sha}","trees_url":"https://api.github.com/repos/bcipolli/nibabel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bcipolli/nibabel/statuses/{sha}","languages_url":"https://api.github.com/repos/bcipolli/nibabel/languages","stargazers_url":"https://api.github.com/repos/bcipolli/nibabel/stargazers","contributors_url":"https://api.github.com/repos/bcipolli/nibabel/contributors","subscribers_url":"https://api.github.com/repos/bcipolli/nibabel/subscribers","subscription_url":"https://api.github.com/repos/bcipolli/nibabel/subscription","commits_url":"https://api.github.com/repos/bcipolli/nibabel/commits{/sha}","git_commits_url":"https://api.github.com/repos/bcipolli/nibabel/git/commits{/sha}","comments_url":"https://api.github.com/repos/bcipolli/nibabel/comments{/number}","issue_comment_url":"https://api.github.com/repos/bcipolli/nibabel/issues/comments{/number}","contents_url":"https://api.github.com/repos/bcipolli/nibabel/contents/{+path}","compare_url":"https://api.github.com/repos/bcipolli/nibabel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bcipolli/nibabel/merges","archive_url":"https://api.github.com/repos/bcipolli/nibabel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bcipolli/nibabel/downloads","issues_url":"https://api.github.com/repos/bcipolli/nibabel/issues{/number}","pulls_url":"https://api.github.com/repos/bcipolli/nibabel/pulls{/number}","milestones_url":"https://api.github.com/repos/bcipolli/nibabel/milestones{/number}","notifications_url":"https://api.github.com/repos/bcipolli/nibabel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bcipolli/nibabel/labels{/name}","releases_url":"https://api.github.com/repos/bcipolli/nibabel/releases{/id}","created_at":"2015-02-24T09:35:11Z","updated_at":"2015-02-24T09:35:13Z","pushed_at":"2015-10-07T18:55:38Z","git_url":"git://github.com/bcipolli/nibabel.git","ssh_url":"git@github.com:bcipolli/nibabel.git","clone_url":"https://github.com/bcipolli/nibabel.git","svn_url":"https://github.com/bcipolli/nibabel","homepage":"http://nipy.org/nibabel/","size":8400,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nipy:master","ref":"master","sha":"f70961a3e9eca0d0af8d71ce03e3d444a8603eef","user":{"login":"nipy","id":233707,"avatar_url":"https://avatars.githubusercontent.com/u/233707?v=3","gravatar_id":"","url":"https://api.github.com/users/nipy","html_url":"https://github.com/nipy","followers_url":"https://api.github.com/users/nipy/followers","following_url":"https://api.github.com/users/nipy/following{/other_user}","gists_url":"https://api.github.com/users/nipy/gists{/gist_id}","starred_url":"https://api.github.com/users/nipy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nipy/subscriptions","organizations_url":"https://api.github.com/users/nipy/orgs","repos_url":"https://api.github.com/users/nipy/repos","events_url":"https://api.github.com/users/nipy/events{/privacy}","received_events_url":"https://api.github.com/users/nipy/received_events","type":"Organization","site_admin":false},"repo":{"id":791352,"name":"nibabel","full_name":"nipy/nibabel","owner":{"login":"nipy","id":233707,"avatar_url":"https://avatars.githubusercontent.com/u/233707?v=3","gravatar_id":"","url":"https://api.github.com/users/nipy","html_url":"https://github.com/nipy","followers_url":"https://api.github.com/users/nipy/followers","following_url":"https://api.github.com/users/nipy/following{/other_user}","gists_url":"https://api.github.com/users/nipy/gists{/gist_id}","starred_url":"https://api.github.com/users/nipy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nipy/subscriptions","organizations_url":"https://api.github.com/users/nipy/orgs","repos_url":"https://api.github.com/users/nipy/repos","events_url":"https://api.github.com/users/nipy/events{/privacy}","received_events_url":"https://api.github.com/users/nipy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nipy/nibabel","description":"Python package to access a cacophony of neuro-imaging file formats","fork":false,"url":"https://api.github.com/repos/nipy/nibabel","forks_url":"https://api.github.com/repos/nipy/nibabel/forks","keys_url":"https://api.github.com/repos/nipy/nibabel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nipy/nibabel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nipy/nibabel/teams","hooks_url":"https://api.github.com/repos/nipy/nibabel/hooks","issue_events_url":"https://api.github.com/repos/nipy/nibabel/issues/events{/number}","events_url":"https://api.github.com/repos/nipy/nibabel/events","assignees_url":"https://api.github.com/repos/nipy/nibabel/assignees{/user}","branches_url":"https://api.github.com/repos/nipy/nibabel/branches{/branch}","tags_url":"https://api.github.com/repos/nipy/nibabel/tags","blobs_url":"https://api.github.com/repos/nipy/nibabel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nipy/nibabel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nipy/nibabel/git/refs{/sha}","trees_url":"https://api.github.com/repos/nipy/nibabel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nipy/nibabel/statuses/{sha}","languages_url":"https://api.github.com/repos/nipy/nibabel/languages","stargazers_url":"https://api.github.com/repos/nipy/nibabel/stargazers","contributors_url":"https://api.github.com/repos/nipy/nibabel/contributors","subscribers_url":"https://api.github.com/repos/nipy/nibabel/subscribers","subscription_url":"https://api.github.com/repos/nipy/nibabel/subscription","commits_url":"https://api.github.com/repos/nipy/nibabel/commits{/sha}","git_commits_url":"https://api.github.com/repos/nipy/nibabel/git/commits{/sha}","comments_url":"https://api.github.com/repos/nipy/nibabel/comments{/number}","issue_comment_url":"https://api.github.com/repos/nipy/nibabel/issues/comments{/number}","contents_url":"https://api.github.com/repos/nipy/nibabel/contents/{+path}","compare_url":"https://api.github.com/repos/nipy/nibabel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nipy/nibabel/merges","archive_url":"https://api.github.com/repos/nipy/nibabel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nipy/nibabel/downloads","issues_url":"https://api.github.com/repos/nipy/nibabel/issues{/number}","pulls_url":"https://api.github.com/repos/nipy/nibabel/pulls{/number}","milestones_url":"https://api.github.com/repos/nipy/nibabel/milestones{/number}","notifications_url":"https://api.github.com/repos/nipy/nibabel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nipy/nibabel/labels{/name}","releases_url":"https://api.github.com/repos/nipy/nibabel/releases{/id}","created_at":"2010-07-22T16:28:30Z","updated_at":"2015-10-06T06:58:39Z","pushed_at":"2015-10-07T01:21:46Z","git_url":"git://github.com/nipy/nibabel.git","ssh_url":"git@github.com:nipy/nibabel.git","clone_url":"https://github.com/nipy/nibabel.git","svn_url":"https://github.com/nipy/nibabel","homepage":"http://nipy.org/nibabel/","size":17559,"stargazers_count":96,"watchers_count":96,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":93,"mirror_url":null,"open_issues_count":54,"forks":93,"open_issues":54,"watchers":96,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nipy/nibabel/pulls/353"},"html":{"href":"https://github.com/nipy/nibabel/pull/353"},"issue":{"href":"https://api.github.com/repos/nipy/nibabel/issues/353"},"comments":{"href":"https://api.github.com/repos/nipy/nibabel/issues/353/comments"},"review_comments":{"href":"https://api.github.com/repos/nipy/nibabel/pulls/353/comments"},"review_comment":{"href":"https://api.github.com/repos/nipy/nibabel/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nipy/nibabel/pulls/353/commits"},"statuses":{"href":"https://api.github.com/repos/nipy/nibabel/statuses/a7662ba9fa38d63232a81ec10f4a9e4644424b40"}}}}