{"action":"created","comment":{"url":"https://api.github.com/repos/crowbar/barclamp-neutron/pulls/comments/36181344","id":36181344,"diff_hunk":"@@ -157,53 +162,140 @@\n         Chef::Log.info(\"#{name} usurped #{res[1].join(\", \")} routes from #{bound_if}\") unless res[1].empty?\n       end\n     end\n+\n     source = ::Nic.new(bound_if)\n     # filter out cluster VIPs that a currently assigned to the interface\n     addresses = source.addresses.select { |address| my_addresses.include? address }\n     routes = source.routes\n-    template \"/etc/init.d/ovs-usurp-config-#{name}\" do\n-      source \"ovs-usurp-config.erb\"\n-      owner \"root\"\n-      group \"root\"\n-      mode \"0755\"\n-      variables(\n-        :source => bound_if,\n-        :dest => name,\n-        :addresses => addresses,\n-        :routes => routes\n-      )\n-      # After the ruby_block \"Have #{name} usurp config from #{bound_if}\" was\n-      # executed for the first time, the physical interface (eth) will not have\n-      # any addresses or routes assigned anymore. So we should not recreate the\n-      # init script in that case. Neither should it be removed.\n-      not_if { addresses.empty? and routes.empty? }\n-    end\n-    service \"ovs-usurp-config-#{name}\" do\n-      # Don't start it here. It only needs to be executed during boot.\n-      action [:nothing]\n-      subscribes :enable, resources(\"template[/etc/init.d/ovs-usurp-config-#{name}]\")\n+\n+    if node[:platform] == \"suse\" && node[:platform_version].to_f >= 12.0\n+      # on SLE12, we create proper network configuration for OVS bridges, see\n+      # https://en.opensuse.org/Portal:Wicked/OpenvSwitch\n+\n+      # We need to create a static ifcfg file so that wicked will know that the\n+      # ovs bridge usurps the interface address. This also means that we need\n+      # to override the variables we pass to the template for the ifcfg of the\n+      # interface.\n+      bound_if_resource = resources(:template => \"/etc/sysconfig/network/ifcfg-#{bound_if}\")","path":"chef/cookbooks/neutron/recipes/common_agent.rb","position":58,"original_position":58,"commit_id":"e6d3d94947e1528724750e3dbc9fc53c5df8356a","original_commit_id":"e6d3d94947e1528724750e3dbc9fc53c5df8356a","user":{"login":"vuntz","id":1758783,"avatar_url":"https://avatars.githubusercontent.com/u/1758783?v=3","gravatar_id":"","url":"https://api.github.com/users/vuntz","html_url":"https://github.com/vuntz","followers_url":"https://api.github.com/users/vuntz/followers","following_url":"https://api.github.com/users/vuntz/following{/other_user}","gists_url":"https://api.github.com/users/vuntz/gists{/gist_id}","starred_url":"https://api.github.com/users/vuntz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vuntz/subscriptions","organizations_url":"https://api.github.com/users/vuntz/orgs","repos_url":"https://api.github.com/users/vuntz/repos","events_url":"https://api.github.com/users/vuntz/events{/privacy}","received_events_url":"https://api.github.com/users/vuntz/received_events","type":"User","site_admin":false},"body":"> Isn't the creation and management of bridges and interfaces a responsibility of barclamp-network?\r\n\r\nYes and no. The issue is that the network cookbook doesn't have information about what is needed here, and that's information internal to the neutron cookbook.\r\n\r\n> I was testing that if I check the bridge option for in interface in the node information, and I include the recipe from network, this will update (wrongly) the interfaces.\r\n\r\nHrm, not sure I understand. Can you rephrase or give more details?\r\n\r\n> IIUC one of the risks of managing the interfaces here is that barclamp-network can undo this.\r\n\r\nWhen would this happen? As long as the neutron cookbook is being used, then it will not be undone.","created_at":"2015-08-04T12:22:59Z","updated_at":"2015-08-04T12:22:59Z","html_url":"https://github.com/crowbar/barclamp-neutron/pull/245#discussion_r36181344","pull_request_url":"https://api.github.com/repos/crowbar/barclamp-neutron/pulls/245","_links":{"self":{"href":"https://api.github.com/repos/crowbar/barclamp-neutron/pulls/comments/36181344"},"html":{"href":"https://github.com/crowbar/barclamp-neutron/pull/245#discussion_r36181344"},"pull_request":{"href":"https://api.github.com/repos/crowbar/barclamp-neutron/pulls/245"}}},"pull_request":{"url":"https://api.github.com/repos/crowbar/barclamp-neutron/pulls/245","id":41484016,"html_url":"https://github.com/crowbar/barclamp-neutron/pull/245","diff_url":"https://github.com/crowbar/barclamp-neutron/pull/245.diff","patch_url":"https://github.com/crowbar/barclamp-neutron/pull/245.patch","issue_url":"https://api.github.com/repos/crowbar/barclamp-neutron/issues/245","number":245,"state":"open","locked":false,"title":"Write network configuration to have wicked understand ovs (bsc#930986)","user":{"login":"vuntz","id":1758783,"avatar_url":"https://avatars.githubusercontent.com/u/1758783?v=3","gravatar_id":"","url":"https://api.github.com/users/vuntz","html_url":"https://github.com/vuntz","followers_url":"https://api.github.com/users/vuntz/followers","following_url":"https://api.github.com/users/vuntz/following{/other_user}","gists_url":"https://api.github.com/users/vuntz/gists{/gist_id}","starred_url":"https://api.github.com/users/vuntz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vuntz/subscriptions","organizations_url":"https://api.github.com/users/vuntz/orgs","repos_url":"https://api.github.com/users/vuntz/repos","events_url":"https://api.github.com/users/vuntz/events{/privacy}","received_events_url":"https://api.github.com/users/vuntz/received_events","type":"User","site_admin":false},"body":"This is based on https://en.opensuse.org/Portal:Wicked/OpenvSwitch and\r\ncomment 9 in the bug.\r\n\r\nhttps://bugzilla.suse.com/show_bug.cgi?id=930986\r\n\r\nDepends on https://github.com/crowbar/barclamp-network/pull/327","created_at":"2015-08-03T16:20:00Z","updated_at":"2015-08-04T12:22:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ccf5b50000a67e31e1263fdd19c34442916fcc43","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/crowbar/barclamp-neutron/pulls/245/commits","review_comments_url":"https://api.github.com/repos/crowbar/barclamp-neutron/pulls/245/comments","review_comment_url":"https://api.github.com/repos/crowbar/barclamp-neutron/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crowbar/barclamp-neutron/issues/245/comments","statuses_url":"https://api.github.com/repos/crowbar/barclamp-neutron/statuses/e6d3d94947e1528724750e3dbc9fc53c5df8356a","head":{"label":"vuntz:ovs-wicked","ref":"ovs-wicked","sha":"e6d3d94947e1528724750e3dbc9fc53c5df8356a","user":{"login":"vuntz","id":1758783,"avatar_url":"https://avatars.githubusercontent.com/u/1758783?v=3","gravatar_id":"","url":"https://api.github.com/users/vuntz","html_url":"https://github.com/vuntz","followers_url":"https://api.github.com/users/vuntz/followers","following_url":"https://api.github.com/users/vuntz/following{/other_user}","gists_url":"https://api.github.com/users/vuntz/gists{/gist_id}","starred_url":"https://api.github.com/users/vuntz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vuntz/subscriptions","organizations_url":"https://api.github.com/users/vuntz/orgs","repos_url":"https://api.github.com/users/vuntz/repos","events_url":"https://api.github.com/users/vuntz/events{/privacy}","received_events_url":"https://api.github.com/users/vuntz/received_events","type":"User","site_admin":false},"repo":{"id":15762255,"name":"barclamp-neutron","full_name":"vuntz/barclamp-neutron","owner":{"login":"vuntz","id":1758783,"avatar_url":"https://avatars.githubusercontent.com/u/1758783?v=3","gravatar_id":"","url":"https://api.github.com/users/vuntz","html_url":"https://github.com/vuntz","followers_url":"https://api.github.com/users/vuntz/followers","following_url":"https://api.github.com/users/vuntz/following{/other_user}","gists_url":"https://api.github.com/users/vuntz/gists{/gist_id}","starred_url":"https://api.github.com/users/vuntz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vuntz/subscriptions","organizations_url":"https://api.github.com/users/vuntz/orgs","repos_url":"https://api.github.com/users/vuntz/repos","events_url":"https://api.github.com/users/vuntz/events{/privacy}","received_events_url":"https://api.github.com/users/vuntz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vuntz/barclamp-neutron","description":"Neutron ","fork":true,"url":"https://api.github.com/repos/vuntz/barclamp-neutron","forks_url":"https://api.github.com/repos/vuntz/barclamp-neutron/forks","keys_url":"https://api.github.com/repos/vuntz/barclamp-neutron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vuntz/barclamp-neutron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vuntz/barclamp-neutron/teams","hooks_url":"https://api.github.com/repos/vuntz/barclamp-neutron/hooks","issue_events_url":"https://api.github.com/repos/vuntz/barclamp-neutron/issues/events{/number}","events_url":"https://api.github.com/repos/vuntz/barclamp-neutron/events","assignees_url":"https://api.github.com/repos/vuntz/barclamp-neutron/assignees{/user}","branches_url":"https://api.github.com/repos/vuntz/barclamp-neutron/branches{/branch}","tags_url":"https://api.github.com/repos/vuntz/barclamp-neutron/tags","blobs_url":"https://api.github.com/repos/vuntz/barclamp-neutron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vuntz/barclamp-neutron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vuntz/barclamp-neutron/git/refs{/sha}","trees_url":"https://api.github.com/repos/vuntz/barclamp-neutron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vuntz/barclamp-neutron/statuses/{sha}","languages_url":"https://api.github.com/repos/vuntz/barclamp-neutron/languages","stargazers_url":"https://api.github.com/repos/vuntz/barclamp-neutron/stargazers","contributors_url":"https://api.github.com/repos/vuntz/barclamp-neutron/contributors","subscribers_url":"https://api.github.com/repos/vuntz/barclamp-neutron/subscribers","subscription_url":"https://api.github.com/repos/vuntz/barclamp-neutron/subscription","commits_url":"https://api.github.com/repos/vuntz/barclamp-neutron/commits{/sha}","git_commits_url":"https://api.github.com/repos/vuntz/barclamp-neutron/git/commits{/sha}","comments_url":"https://api.github.com/repos/vuntz/barclamp-neutron/comments{/number}","issue_comment_url":"https://api.github.com/repos/vuntz/barclamp-neutron/issues/comments{/number}","contents_url":"https://api.github.com/repos/vuntz/barclamp-neutron/contents/{+path}","compare_url":"https://api.github.com/repos/vuntz/barclamp-neutron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vuntz/barclamp-neutron/merges","archive_url":"https://api.github.com/repos/vuntz/barclamp-neutron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vuntz/barclamp-neutron/downloads","issues_url":"https://api.github.com/repos/vuntz/barclamp-neutron/issues{/number}","pulls_url":"https://api.github.com/repos/vuntz/barclamp-neutron/pulls{/number}","milestones_url":"https://api.github.com/repos/vuntz/barclamp-neutron/milestones{/number}","notifications_url":"https://api.github.com/repos/vuntz/barclamp-neutron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vuntz/barclamp-neutron/labels{/name}","releases_url":"https://api.github.com/repos/vuntz/barclamp-neutron/releases{/id}","created_at":"2014-01-09T09:26:18Z","updated_at":"2015-02-18T23:11:47Z","pushed_at":"2015-08-03T16:27:38Z","git_url":"git://github.com/vuntz/barclamp-neutron.git","ssh_url":"git@github.com:vuntz/barclamp-neutron.git","clone_url":"https://github.com/vuntz/barclamp-neutron.git","svn_url":"https://github.com/vuntz/barclamp-neutron","homepage":null,"size":1835,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"crowbar:master","ref":"master","sha":"3c99509cc2eac2c1e74e95d30f75abe3cadffcc6","user":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars.githubusercontent.com/u/2910205?v=3","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"repo":{"id":13688641,"name":"barclamp-neutron","full_name":"crowbar/barclamp-neutron","owner":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars.githubusercontent.com/u/2910205?v=3","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crowbar/barclamp-neutron","description":"OpenStack Neutron: Networking component","fork":false,"url":"https://api.github.com/repos/crowbar/barclamp-neutron","forks_url":"https://api.github.com/repos/crowbar/barclamp-neutron/forks","keys_url":"https://api.github.com/repos/crowbar/barclamp-neutron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crowbar/barclamp-neutron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crowbar/barclamp-neutron/teams","hooks_url":"https://api.github.com/repos/crowbar/barclamp-neutron/hooks","issue_events_url":"https://api.github.com/repos/crowbar/barclamp-neutron/issues/events{/number}","events_url":"https://api.github.com/repos/crowbar/barclamp-neutron/events","assignees_url":"https://api.github.com/repos/crowbar/barclamp-neutron/assignees{/user}","branches_url":"https://api.github.com/repos/crowbar/barclamp-neutron/branches{/branch}","tags_url":"https://api.github.com/repos/crowbar/barclamp-neutron/tags","blobs_url":"https://api.github.com/repos/crowbar/barclamp-neutron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crowbar/barclamp-neutron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crowbar/barclamp-neutron/git/refs{/sha}","trees_url":"https://api.github.com/repos/crowbar/barclamp-neutron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crowbar/barclamp-neutron/statuses/{sha}","languages_url":"https://api.github.com/repos/crowbar/barclamp-neutron/languages","stargazers_url":"https://api.github.com/repos/crowbar/barclamp-neutron/stargazers","contributors_url":"https://api.github.com/repos/crowbar/barclamp-neutron/contributors","subscribers_url":"https://api.github.com/repos/crowbar/barclamp-neutron/subscribers","subscription_url":"https://api.github.com/repos/crowbar/barclamp-neutron/subscription","commits_url":"https://api.github.com/repos/crowbar/barclamp-neutron/commits{/sha}","git_commits_url":"https://api.github.com/repos/crowbar/barclamp-neutron/git/commits{/sha}","comments_url":"https://api.github.com/repos/crowbar/barclamp-neutron/comments{/number}","issue_comment_url":"https://api.github.com/repos/crowbar/barclamp-neutron/issues/comments{/number}","contents_url":"https://api.github.com/repos/crowbar/barclamp-neutron/contents/{+path}","compare_url":"https://api.github.com/repos/crowbar/barclamp-neutron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crowbar/barclamp-neutron/merges","archive_url":"https://api.github.com/repos/crowbar/barclamp-neutron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crowbar/barclamp-neutron/downloads","issues_url":"https://api.github.com/repos/crowbar/barclamp-neutron/issues{/number}","pulls_url":"https://api.github.com/repos/crowbar/barclamp-neutron/pulls{/number}","milestones_url":"https://api.github.com/repos/crowbar/barclamp-neutron/milestones{/number}","notifications_url":"https://api.github.com/repos/crowbar/barclamp-neutron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crowbar/barclamp-neutron/labels{/name}","releases_url":"https://api.github.com/repos/crowbar/barclamp-neutron/releases{/id}","created_at":"2013-10-18T20:39:52Z","updated_at":"2015-04-28T08:41:24Z","pushed_at":"2015-08-03T16:27:39Z","git_url":"git://github.com/crowbar/barclamp-neutron.git","ssh_url":"git@github.com:crowbar/barclamp-neutron.git","clone_url":"https://github.com/crowbar/barclamp-neutron.git","svn_url":"https://github.com/crowbar/barclamp-neutron","homepage":"https://github.com/crowbar/crowbar","size":3199,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":73,"mirror_url":null,"open_issues_count":8,"forks":73,"open_issues":8,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crowbar/barclamp-neutron/pulls/245"},"html":{"href":"https://github.com/crowbar/barclamp-neutron/pull/245"},"issue":{"href":"https://api.github.com/repos/crowbar/barclamp-neutron/issues/245"},"comments":{"href":"https://api.github.com/repos/crowbar/barclamp-neutron/issues/245/comments"},"review_comments":{"href":"https://api.github.com/repos/crowbar/barclamp-neutron/pulls/245/comments"},"review_comment":{"href":"https://api.github.com/repos/crowbar/barclamp-neutron/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crowbar/barclamp-neutron/pulls/245/commits"},"statuses":{"href":"https://api.github.com/repos/crowbar/barclamp-neutron/statuses/e6d3d94947e1528724750e3dbc9fc53c5df8356a"}}}}