{"action":"created","issue":{"url":"https://api.github.com/repos/apache/spark/issues/5236","labels_url":"https://api.github.com/repos/apache/spark/issues/5236/labels{/name}","comments_url":"https://api.github.com/repos/apache/spark/issues/5236/comments","events_url":"https://api.github.com/repos/apache/spark/issues/5236/events","html_url":"https://github.com/apache/spark/pull/5236","id":64853137,"number":5236,"title":"[SPARK-5931][CORE] Use consistent naming for time properties","user":{"login":"ilganeli","id":1483345,"avatar_url":"https://avatars.githubusercontent.com/u/1483345?v=3","gravatar_id":"","url":"https://api.github.com/users/ilganeli","html_url":"https://github.com/ilganeli","followers_url":"https://api.github.com/users/ilganeli/followers","following_url":"https://api.github.com/users/ilganeli/following{/other_user}","gists_url":"https://api.github.com/users/ilganeli/gists{/gist_id}","starred_url":"https://api.github.com/users/ilganeli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilganeli/subscriptions","organizations_url":"https://api.github.com/users/ilganeli/orgs","repos_url":"https://api.github.com/users/ilganeli/repos","events_url":"https://api.github.com/users/ilganeli/events{/privacy}","received_events_url":"https://api.github.com/users/ilganeli/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":157,"created_at":"2015-03-27T21:17:04Z","updated_at":"2015-04-13T22:07:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/5236","html_url":"https://github.com/apache/spark/pull/5236","diff_url":"https://github.com/apache/spark/pull/5236.diff","patch_url":"https://github.com/apache/spark/pull/5236.patch"},"body":"I've added new utility methods to do the conversion from times specified as e.g. 120s, 240ms, 360us to convert to a consistent internal representation. I've updated usage of these constants throughout the code to be consistent. \r\n\r\nI believe I've captured all usages of time-based properties throughout the code. I've also updated variable names in a number of places to reflect their units for clarity and updated documentation where appropriate. "},"comment":{"url":"https://api.github.com/repos/apache/spark/issues/comments/92514243","html_url":"https://github.com/apache/spark/pull/5236#issuecomment-92514243","issue_url":"https://api.github.com/repos/apache/spark/issues/5236","id":92514243,"user":{"login":"srowen","id":822522,"avatar_url":"https://avatars.githubusercontent.com/u/822522?v=3","gravatar_id":"","url":"https://api.github.com/users/srowen","html_url":"https://github.com/srowen","followers_url":"https://api.github.com/users/srowen/followers","following_url":"https://api.github.com/users/srowen/following{/other_user}","gists_url":"https://api.github.com/users/srowen/gists{/gist_id}","starred_url":"https://api.github.com/users/srowen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srowen/subscriptions","organizations_url":"https://api.github.com/users/srowen/orgs","repos_url":"https://api.github.com/users/srowen/repos","events_url":"https://api.github.com/users/srowen/events{/privacy}","received_events_url":"https://api.github.com/users/srowen/received_events","type":"User","site_admin":false},"created_at":"2015-04-13T22:07:49Z","updated_at":"2015-04-13T22:07:49Z","body":"Looking strong. I think that's all the comments addressed now. Going once, going twice?"}}