{"action":"closed","number":22,"pull_request":{"url":"https://api.github.com/repos/confluentinc/kafka-connect-hdfs/pulls/22","id":51872881,"html_url":"https://github.com/confluentinc/kafka-connect-hdfs/pull/22","diff_url":"https://github.com/confluentinc/kafka-connect-hdfs/pull/22.diff","patch_url":"https://github.com/confluentinc/kafka-connect-hdfs/pull/22.patch","issue_url":"https://api.github.com/repos/confluentinc/kafka-connect-hdfs/issues/22","number":22,"state":"closed","locked":false,"title":"Drop temp files during onPartitionsRevoked to correctly handle rebalance","user":{"login":"ewencp","id":47366,"avatar_url":"https://avatars.githubusercontent.com/u/47366?v=3","gravatar_id":"","url":"https://api.github.com/users/ewencp","html_url":"https://github.com/ewencp","followers_url":"https://api.github.com/users/ewencp/followers","following_url":"https://api.github.com/users/ewencp/following{/other_user}","gists_url":"https://api.github.com/users/ewencp/gists{/gist_id}","starred_url":"https://api.github.com/users/ewencp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ewencp/subscriptions","organizations_url":"https://api.github.com/users/ewencp/orgs","repos_url":"https://api.github.com/users/ewencp/repos","events_url":"https://api.github.com/users/ewencp/events{/privacy}","received_events_url":"https://api.github.com/users/ewencp/received_events","type":"User","site_admin":false},"body":"Instead of trying to hold onto temp files and continue using them if assigned the same partition after rebalance, just drop the temp files immediately because trying to reuse them requires a much more complicated approach and validation of the offsets since the consumer could have missed some generations of group membership.\r\n\r\nAs fallout of this change, we also no longer save in-progress work when cleanly shutting down the connector, instead always getting files of the requested size. We also validate offsets of records because of KAFKA-2894 which can result in incorrect delivery of messages to connectors that try to reset offsets during a rebalance operation.","created_at":"2015-11-26T05:01:02Z","updated_at":"2015-11-27T18:50:17Z","closed_at":"2015-11-27T18:50:17Z","merged_at":"2015-11-27T18:50:17Z","merge_commit_sha":"aa8b6d3de56bfe6936f767bd1c98b5a963c7e421","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/confluentinc/kafka-connect-hdfs/pulls/22/commits","review_comments_url":"https://api.github.com/repos/confluentinc/kafka-connect-hdfs/pulls/22/comments","review_comment_url":"https://api.github.com/repos/confluentinc/kafka-connect-hdfs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/confluentinc/kafka-connect-hdfs/issues/22/comments","statuses_url":"https://api.github.com/repos/confluentinc/kafka-connect-hdfs/statuses/c7329d8c73f6d307a79667863900e8b5412cd4b4","head":{"label":"confluentinc:drop-in-progress-on-rebalance-and-recover-immediately","ref":"drop-in-progress-on-rebalance-and-recover-immediately","sha":"c7329d8c73f6d307a79667863900e8b5412cd4b4","user":{"login":"confluentinc","id":9439498,"avatar_url":"https://avatars.githubusercontent.com/u/9439498?v=3","gravatar_id":"","url":"https://api.github.com/users/confluentinc","html_url":"https://github.com/confluentinc","followers_url":"https://api.github.com/users/confluentinc/followers","following_url":"https://api.github.com/users/confluentinc/following{/other_user}","gists_url":"https://api.github.com/users/confluentinc/gists{/gist_id}","starred_url":"https://api.github.com/users/confluentinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/confluentinc/subscriptions","organizations_url":"https://api.github.com/users/confluentinc/orgs","repos_url":"https://api.github.com/users/confluentinc/repos","events_url":"https://api.github.com/users/confluentinc/events{/privacy}","received_events_url":"https://api.github.com/users/confluentinc/received_events","type":"Organization","site_admin":false},"repo":{"id":35967803,"name":"kafka-connect-hdfs","full_name":"confluentinc/kafka-connect-hdfs","owner":{"login":"confluentinc","id":9439498,"avatar_url":"https://avatars.githubusercontent.com/u/9439498?v=3","gravatar_id":"","url":"https://api.github.com/users/confluentinc","html_url":"https://github.com/confluentinc","followers_url":"https://api.github.com/users/confluentinc/followers","following_url":"https://api.github.com/users/confluentinc/following{/other_user}","gists_url":"https://api.github.com/users/confluentinc/gists{/gist_id}","starred_url":"https://api.github.com/users/confluentinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/confluentinc/subscriptions","organizations_url":"https://api.github.com/users/confluentinc/orgs","repos_url":"https://api.github.com/users/confluentinc/repos","events_url":"https://api.github.com/users/confluentinc/events{/privacy}","received_events_url":"https://api.github.com/users/confluentinc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/confluentinc/kafka-connect-hdfs","description":"Kafka Connect HDFS connector","fork":false,"url":"https://api.github.com/repos/confluentinc/kafka-connect-hdfs","forks_url":"https://api.github.com/repos/confluentinc/kafka-connect-hdfs/forks","keys_url":"https://api.github.com/repos/confluentinc/kafka-connect-hdfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/confluentinc/kafka-connect-hdfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/confluentinc/kafka-connect-hdfs/teams","hooks_url":"https://api.github.com/repos/confluentinc/kafka-connect-hdfs/hooks","issue_events_url":"https://api.github.com/repos/confluentinc/kafka-connect-hdfs/issues/events{/number}","events_url":"https://api.github.com/repos/confluentinc/kafka-connect-hdfs/events","assignees_url":"https://api.github.com/repos/confluentinc/kafka-connect-hdfs/assignees{/user}","branches_url":"https://api.github.com/repos/confluentinc/kafka-connect-hdfs/branches{/branch}","tags_url":"https://api.github.com/repos/confluentinc/kafka-connect-hdfs/tags","blobs_url":"https://api.github.com/repos/confluentinc/kafka-connect-hdfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/confluentinc/kafka-connect-hdfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/confluentinc/kafka-connect-hdfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/confluentinc/kafka-connect-hdfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/confluentinc/kafka-connect-hdfs/statuses/{sha}","languages_url":"https://api.github.com/repos/confluentinc/kafka-connect-hdfs/languages","stargazers_url":"https://api.github.com/repos/confluentinc/kafka-connect-hdfs/stargazers","contributors_url":"https://api.github.com/repos/confluentinc/kafka-connect-hdfs/contributors","subscribers_url":"https://api.github.com/repos/confluentinc/kafka-connect-hdfs/subscribers","subscription_url":"https://api.github.com/repos/confluentinc/kafka-connect-hdfs/subscription","commits_url":"https://api.github.com/repos/confluentinc/kafka-connect-hdfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/confluentinc/kafka-connect-hdfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/confluentinc/kafka-connect-hdfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/confluentinc/kafka-connect-hdfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/confluentinc/kafka-connect-hdfs/contents/{+path}","compare_url":"https://api.github.com/repos/confluentinc/kafka-connect-hdfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/confluentinc/kafka-connect-hdfs/merges","archive_url":"https://api.github.com/repos/confluentinc/kafka-connect-hdfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/confluentinc/kafka-connect-hdfs/downloads","issues_url":"https://api.github.com/repos/confluentinc/kafka-connect-hdfs/issues{/number}","pulls_url":"https://api.github.com/repos/confluentinc/kafka-connect-hdfs/pulls{/number}","milestones_url":"https://api.github.com/repos/confluentinc/kafka-connect-hdfs/milestones{/number}","notifications_url":"https://api.github.com/repos/confluentinc/kafka-connect-hdfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/confluentinc/kafka-connect-hdfs/labels{/name}","releases_url":"https://api.github.com/repos/confluentinc/kafka-connect-hdfs/releases{/id}","created_at":"2015-05-20T18:54:34Z","updated_at":"2015-11-25T19:24:39Z","pushed_at":"2015-11-27T18:50:17Z","git_url":"git://github.com/confluentinc/kafka-connect-hdfs.git","ssh_url":"git@github.com:confluentinc/kafka-connect-hdfs.git","clone_url":"https://github.com/confluentinc/kafka-connect-hdfs.git","svn_url":"https://github.com/confluentinc/kafka-connect-hdfs","homepage":"","size":342,"stargazers_count":5,"watchers_count":5,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":3,"forks":1,"open_issues":3,"watchers":5,"default_branch":"master"}},"base":{"label":"confluentinc:master","ref":"master","sha":"981eab83574edcc8ac6d16deacdc46fe8c45d8b7","user":{"login":"confluentinc","id":9439498,"avatar_url":"https://avatars.githubusercontent.com/u/9439498?v=3","gravatar_id":"","url":"https://api.github.com/users/confluentinc","html_url":"https://github.com/confluentinc","followers_url":"https://api.github.com/users/confluentinc/followers","following_url":"https://api.github.com/users/confluentinc/following{/other_user}","gists_url":"https://api.github.com/users/confluentinc/gists{/gist_id}","starred_url":"https://api.github.com/users/confluentinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/confluentinc/subscriptions","organizations_url":"https://api.github.com/users/confluentinc/orgs","repos_url":"https://api.github.com/users/confluentinc/repos","events_url":"https://api.github.com/users/confluentinc/events{/privacy}","received_events_url":"https://api.github.com/users/confluentinc/received_events","type":"Organization","site_admin":false},"repo":{"id":35967803,"name":"kafka-connect-hdfs","full_name":"confluentinc/kafka-connect-hdfs","owner":{"login":"confluentinc","id":9439498,"avatar_url":"https://avatars.githubusercontent.com/u/9439498?v=3","gravatar_id":"","url":"https://api.github.com/users/confluentinc","html_url":"https://github.com/confluentinc","followers_url":"https://api.github.com/users/confluentinc/followers","following_url":"https://api.github.com/users/confluentinc/following{/other_user}","gists_url":"https://api.github.com/users/confluentinc/gists{/gist_id}","starred_url":"https://api.github.com/users/confluentinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/confluentinc/subscriptions","organizations_url":"https://api.github.com/users/confluentinc/orgs","repos_url":"https://api.github.com/users/confluentinc/repos","events_url":"https://api.github.com/users/confluentinc/events{/privacy}","received_events_url":"https://api.github.com/users/confluentinc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/confluentinc/kafka-connect-hdfs","description":"Kafka Connect HDFS connector","fork":false,"url":"https://api.github.com/repos/confluentinc/kafka-connect-hdfs","forks_url":"https://api.github.com/repos/confluentinc/kafka-connect-hdfs/forks","keys_url":"https://api.github.com/repos/confluentinc/kafka-connect-hdfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/confluentinc/kafka-connect-hdfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/confluentinc/kafka-connect-hdfs/teams","hooks_url":"https://api.github.com/repos/confluentinc/kafka-connect-hdfs/hooks","issue_events_url":"https://api.github.com/repos/confluentinc/kafka-connect-hdfs/issues/events{/number}","events_url":"https://api.github.com/repos/confluentinc/kafka-connect-hdfs/events","assignees_url":"https://api.github.com/repos/confluentinc/kafka-connect-hdfs/assignees{/user}","branches_url":"https://api.github.com/repos/confluentinc/kafka-connect-hdfs/branches{/branch}","tags_url":"https://api.github.com/repos/confluentinc/kafka-connect-hdfs/tags","blobs_url":"https://api.github.com/repos/confluentinc/kafka-connect-hdfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/confluentinc/kafka-connect-hdfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/confluentinc/kafka-connect-hdfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/confluentinc/kafka-connect-hdfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/confluentinc/kafka-connect-hdfs/statuses/{sha}","languages_url":"https://api.github.com/repos/confluentinc/kafka-connect-hdfs/languages","stargazers_url":"https://api.github.com/repos/confluentinc/kafka-connect-hdfs/stargazers","contributors_url":"https://api.github.com/repos/confluentinc/kafka-connect-hdfs/contributors","subscribers_url":"https://api.github.com/repos/confluentinc/kafka-connect-hdfs/subscribers","subscription_url":"https://api.github.com/repos/confluentinc/kafka-connect-hdfs/subscription","commits_url":"https://api.github.com/repos/confluentinc/kafka-connect-hdfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/confluentinc/kafka-connect-hdfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/confluentinc/kafka-connect-hdfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/confluentinc/kafka-connect-hdfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/confluentinc/kafka-connect-hdfs/contents/{+path}","compare_url":"https://api.github.com/repos/confluentinc/kafka-connect-hdfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/confluentinc/kafka-connect-hdfs/merges","archive_url":"https://api.github.com/repos/confluentinc/kafka-connect-hdfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/confluentinc/kafka-connect-hdfs/downloads","issues_url":"https://api.github.com/repos/confluentinc/kafka-connect-hdfs/issues{/number}","pulls_url":"https://api.github.com/repos/confluentinc/kafka-connect-hdfs/pulls{/number}","milestones_url":"https://api.github.com/repos/confluentinc/kafka-connect-hdfs/milestones{/number}","notifications_url":"https://api.github.com/repos/confluentinc/kafka-connect-hdfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/confluentinc/kafka-connect-hdfs/labels{/name}","releases_url":"https://api.github.com/repos/confluentinc/kafka-connect-hdfs/releases{/id}","created_at":"2015-05-20T18:54:34Z","updated_at":"2015-11-25T19:24:39Z","pushed_at":"2015-11-27T18:50:17Z","git_url":"git://github.com/confluentinc/kafka-connect-hdfs.git","ssh_url":"git@github.com:confluentinc/kafka-connect-hdfs.git","clone_url":"https://github.com/confluentinc/kafka-connect-hdfs.git","svn_url":"https://github.com/confluentinc/kafka-connect-hdfs","homepage":"","size":342,"stargazers_count":5,"watchers_count":5,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":3,"forks":1,"open_issues":3,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/confluentinc/kafka-connect-hdfs/pulls/22"},"html":{"href":"https://github.com/confluentinc/kafka-connect-hdfs/pull/22"},"issue":{"href":"https://api.github.com/repos/confluentinc/kafka-connect-hdfs/issues/22"},"comments":{"href":"https://api.github.com/repos/confluentinc/kafka-connect-hdfs/issues/22/comments"},"review_comments":{"href":"https://api.github.com/repos/confluentinc/kafka-connect-hdfs/pulls/22/comments"},"review_comment":{"href":"https://api.github.com/repos/confluentinc/kafka-connect-hdfs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/confluentinc/kafka-connect-hdfs/pulls/22/commits"},"statuses":{"href":"https://api.github.com/repos/confluentinc/kafka-connect-hdfs/statuses/c7329d8c73f6d307a79667863900e8b5412cd4b4"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"ewencp","id":47366,"avatar_url":"https://avatars.githubusercontent.com/u/47366?v=3","gravatar_id":"","url":"https://api.github.com/users/ewencp","html_url":"https://github.com/ewencp","followers_url":"https://api.github.com/users/ewencp/followers","following_url":"https://api.github.com/users/ewencp/following{/other_user}","gists_url":"https://api.github.com/users/ewencp/gists{/gist_id}","starred_url":"https://api.github.com/users/ewencp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ewencp/subscriptions","organizations_url":"https://api.github.com/users/ewencp/orgs","repos_url":"https://api.github.com/users/ewencp/repos","events_url":"https://api.github.com/users/ewencp/events{/privacy}","received_events_url":"https://api.github.com/users/ewencp/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":2,"additions":133,"deletions":73,"changed_files":7}}