{"action":"opened","number":15,"pull_request":{"url":"https://api.github.com/repos/TimBeyer/html-to-vdom/pulls/15","id":29757950,"html_url":"https://github.com/TimBeyer/html-to-vdom/pull/15","diff_url":"https://github.com/TimBeyer/html-to-vdom/pull/15.diff","patch_url":"https://github.com/TimBeyer/html-to-vdom/pull/15.patch","issue_url":"https://api.github.com/repos/TimBeyer/html-to-vdom/issues/15","number":15,"state":"open","locked":false,"title":"Custom attributes should be set on the \"attributes\" property","user":{"login":"jesseditson","id":370239,"avatar_url":"https://avatars.githubusercontent.com/u/370239?v=3","gravatar_id":"","url":"https://api.github.com/users/jesseditson","html_url":"https://github.com/jesseditson","followers_url":"https://api.github.com/users/jesseditson/followers","following_url":"https://api.github.com/users/jesseditson/following{/other_user}","gists_url":"https://api.github.com/users/jesseditson/gists{/gist_id}","starred_url":"https://api.github.com/users/jesseditson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jesseditson/subscriptions","organizations_url":"https://api.github.com/users/jesseditson/orgs","repos_url":"https://api.github.com/users/jesseditson/repos","events_url":"https://api.github.com/users/jesseditson/events{/privacy}","received_events_url":"https://api.github.com/users/jesseditson/received_events","type":"User","site_admin":false},"body":"I was exploring serialization and deserialization via this library and [vdom-to-html](), and there appears to be an inconsistency in the way custom attributes are parsed. After checking how the DOM renders elements created via virtual-dom's createElement, I believe the correct solution is to set custom attributes in the attributes hash when creating a new VNode.\r\n\r\nSome more background here: https://github.com/nthtran/vdom-to-html/issues/6","created_at":"2015-02-21T18:55:19Z","updated_at":"2015-02-21T18:55:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/TimBeyer/html-to-vdom/pulls/15/commits","review_comments_url":"https://api.github.com/repos/TimBeyer/html-to-vdom/pulls/15/comments","review_comment_url":"https://api.github.com/repos/TimBeyer/html-to-vdom/pulls/comments/{number}","comments_url":"https://api.github.com/repos/TimBeyer/html-to-vdom/issues/15/comments","statuses_url":"https://api.github.com/repos/TimBeyer/html-to-vdom/statuses/7e6ffdadab1ef0eb4f56e50b419d03aa10efb03a","head":{"label":"jesseditson:custom_attributes","ref":"custom_attributes","sha":"7e6ffdadab1ef0eb4f56e50b419d03aa10efb03a","user":{"login":"jesseditson","id":370239,"avatar_url":"https://avatars.githubusercontent.com/u/370239?v=3","gravatar_id":"","url":"https://api.github.com/users/jesseditson","html_url":"https://github.com/jesseditson","followers_url":"https://api.github.com/users/jesseditson/followers","following_url":"https://api.github.com/users/jesseditson/following{/other_user}","gists_url":"https://api.github.com/users/jesseditson/gists{/gist_id}","starred_url":"https://api.github.com/users/jesseditson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jesseditson/subscriptions","organizations_url":"https://api.github.com/users/jesseditson/orgs","repos_url":"https://api.github.com/users/jesseditson/repos","events_url":"https://api.github.com/users/jesseditson/events{/privacy}","received_events_url":"https://api.github.com/users/jesseditson/received_events","type":"User","site_admin":false},"repo":{"id":31104701,"name":"html-to-vdom","full_name":"jesseditson/html-to-vdom","owner":{"login":"jesseditson","id":370239,"avatar_url":"https://avatars.githubusercontent.com/u/370239?v=3","gravatar_id":"","url":"https://api.github.com/users/jesseditson","html_url":"https://github.com/jesseditson","followers_url":"https://api.github.com/users/jesseditson/followers","following_url":"https://api.github.com/users/jesseditson/following{/other_user}","gists_url":"https://api.github.com/users/jesseditson/gists{/gist_id}","starred_url":"https://api.github.com/users/jesseditson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jesseditson/subscriptions","organizations_url":"https://api.github.com/users/jesseditson/orgs","repos_url":"https://api.github.com/users/jesseditson/repos","events_url":"https://api.github.com/users/jesseditson/events{/privacy}","received_events_url":"https://api.github.com/users/jesseditson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jesseditson/html-to-vdom","description":"Converts an HTML string into a virtual DOM","fork":true,"url":"https://api.github.com/repos/jesseditson/html-to-vdom","forks_url":"https://api.github.com/repos/jesseditson/html-to-vdom/forks","keys_url":"https://api.github.com/repos/jesseditson/html-to-vdom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jesseditson/html-to-vdom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jesseditson/html-to-vdom/teams","hooks_url":"https://api.github.com/repos/jesseditson/html-to-vdom/hooks","issue_events_url":"https://api.github.com/repos/jesseditson/html-to-vdom/issues/events{/number}","events_url":"https://api.github.com/repos/jesseditson/html-to-vdom/events","assignees_url":"https://api.github.com/repos/jesseditson/html-to-vdom/assignees{/user}","branches_url":"https://api.github.com/repos/jesseditson/html-to-vdom/branches{/branch}","tags_url":"https://api.github.com/repos/jesseditson/html-to-vdom/tags","blobs_url":"https://api.github.com/repos/jesseditson/html-to-vdom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jesseditson/html-to-vdom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jesseditson/html-to-vdom/git/refs{/sha}","trees_url":"https://api.github.com/repos/jesseditson/html-to-vdom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jesseditson/html-to-vdom/statuses/{sha}","languages_url":"https://api.github.com/repos/jesseditson/html-to-vdom/languages","stargazers_url":"https://api.github.com/repos/jesseditson/html-to-vdom/stargazers","contributors_url":"https://api.github.com/repos/jesseditson/html-to-vdom/contributors","subscribers_url":"https://api.github.com/repos/jesseditson/html-to-vdom/subscribers","subscription_url":"https://api.github.com/repos/jesseditson/html-to-vdom/subscription","commits_url":"https://api.github.com/repos/jesseditson/html-to-vdom/commits{/sha}","git_commits_url":"https://api.github.com/repos/jesseditson/html-to-vdom/git/commits{/sha}","comments_url":"https://api.github.com/repos/jesseditson/html-to-vdom/comments{/number}","issue_comment_url":"https://api.github.com/repos/jesseditson/html-to-vdom/issues/comments/{number}","contents_url":"https://api.github.com/repos/jesseditson/html-to-vdom/contents/{+path}","compare_url":"https://api.github.com/repos/jesseditson/html-to-vdom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jesseditson/html-to-vdom/merges","archive_url":"https://api.github.com/repos/jesseditson/html-to-vdom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jesseditson/html-to-vdom/downloads","issues_url":"https://api.github.com/repos/jesseditson/html-to-vdom/issues{/number}","pulls_url":"https://api.github.com/repos/jesseditson/html-to-vdom/pulls{/number}","milestones_url":"https://api.github.com/repos/jesseditson/html-to-vdom/milestones{/number}","notifications_url":"https://api.github.com/repos/jesseditson/html-to-vdom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jesseditson/html-to-vdom/labels{/name}","releases_url":"https://api.github.com/repos/jesseditson/html-to-vdom/releases{/id}","created_at":"2015-02-21T01:36:13Z","updated_at":"2015-02-21T01:37:28Z","pushed_at":"2015-02-21T18:54:30Z","git_url":"git://github.com/jesseditson/html-to-vdom.git","ssh_url":"git@github.com:jesseditson/html-to-vdom.git","clone_url":"https://github.com/jesseditson/html-to-vdom.git","svn_url":"https://github.com/jesseditson/html-to-vdom","homepage":null,"size":406,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"TimBeyer:master","ref":"master","sha":"6897728a47b0c77b6820d76e777eb3429f6926e6","user":{"login":"TimBeyer","id":2362075,"avatar_url":"https://avatars.githubusercontent.com/u/2362075?v=3","gravatar_id":"","url":"https://api.github.com/users/TimBeyer","html_url":"https://github.com/TimBeyer","followers_url":"https://api.github.com/users/TimBeyer/followers","following_url":"https://api.github.com/users/TimBeyer/following{/other_user}","gists_url":"https://api.github.com/users/TimBeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/TimBeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TimBeyer/subscriptions","organizations_url":"https://api.github.com/users/TimBeyer/orgs","repos_url":"https://api.github.com/users/TimBeyer/repos","events_url":"https://api.github.com/users/TimBeyer/events{/privacy}","received_events_url":"https://api.github.com/users/TimBeyer/received_events","type":"User","site_admin":false},"repo":{"id":22070939,"name":"html-to-vdom","full_name":"TimBeyer/html-to-vdom","owner":{"login":"TimBeyer","id":2362075,"avatar_url":"https://avatars.githubusercontent.com/u/2362075?v=3","gravatar_id":"","url":"https://api.github.com/users/TimBeyer","html_url":"https://github.com/TimBeyer","followers_url":"https://api.github.com/users/TimBeyer/followers","following_url":"https://api.github.com/users/TimBeyer/following{/other_user}","gists_url":"https://api.github.com/users/TimBeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/TimBeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TimBeyer/subscriptions","organizations_url":"https://api.github.com/users/TimBeyer/orgs","repos_url":"https://api.github.com/users/TimBeyer/repos","events_url":"https://api.github.com/users/TimBeyer/events{/privacy}","received_events_url":"https://api.github.com/users/TimBeyer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TimBeyer/html-to-vdom","description":"Converts an HTML string into a virtual DOM","fork":false,"url":"https://api.github.com/repos/TimBeyer/html-to-vdom","forks_url":"https://api.github.com/repos/TimBeyer/html-to-vdom/forks","keys_url":"https://api.github.com/repos/TimBeyer/html-to-vdom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TimBeyer/html-to-vdom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TimBeyer/html-to-vdom/teams","hooks_url":"https://api.github.com/repos/TimBeyer/html-to-vdom/hooks","issue_events_url":"https://api.github.com/repos/TimBeyer/html-to-vdom/issues/events{/number}","events_url":"https://api.github.com/repos/TimBeyer/html-to-vdom/events","assignees_url":"https://api.github.com/repos/TimBeyer/html-to-vdom/assignees{/user}","branches_url":"https://api.github.com/repos/TimBeyer/html-to-vdom/branches{/branch}","tags_url":"https://api.github.com/repos/TimBeyer/html-to-vdom/tags","blobs_url":"https://api.github.com/repos/TimBeyer/html-to-vdom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TimBeyer/html-to-vdom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TimBeyer/html-to-vdom/git/refs{/sha}","trees_url":"https://api.github.com/repos/TimBeyer/html-to-vdom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TimBeyer/html-to-vdom/statuses/{sha}","languages_url":"https://api.github.com/repos/TimBeyer/html-to-vdom/languages","stargazers_url":"https://api.github.com/repos/TimBeyer/html-to-vdom/stargazers","contributors_url":"https://api.github.com/repos/TimBeyer/html-to-vdom/contributors","subscribers_url":"https://api.github.com/repos/TimBeyer/html-to-vdom/subscribers","subscription_url":"https://api.github.com/repos/TimBeyer/html-to-vdom/subscription","commits_url":"https://api.github.com/repos/TimBeyer/html-to-vdom/commits{/sha}","git_commits_url":"https://api.github.com/repos/TimBeyer/html-to-vdom/git/commits{/sha}","comments_url":"https://api.github.com/repos/TimBeyer/html-to-vdom/comments{/number}","issue_comment_url":"https://api.github.com/repos/TimBeyer/html-to-vdom/issues/comments/{number}","contents_url":"https://api.github.com/repos/TimBeyer/html-to-vdom/contents/{+path}","compare_url":"https://api.github.com/repos/TimBeyer/html-to-vdom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TimBeyer/html-to-vdom/merges","archive_url":"https://api.github.com/repos/TimBeyer/html-to-vdom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TimBeyer/html-to-vdom/downloads","issues_url":"https://api.github.com/repos/TimBeyer/html-to-vdom/issues{/number}","pulls_url":"https://api.github.com/repos/TimBeyer/html-to-vdom/pulls{/number}","milestones_url":"https://api.github.com/repos/TimBeyer/html-to-vdom/milestones{/number}","notifications_url":"https://api.github.com/repos/TimBeyer/html-to-vdom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TimBeyer/html-to-vdom/labels{/name}","releases_url":"https://api.github.com/repos/TimBeyer/html-to-vdom/releases{/id}","created_at":"2014-07-21T16:07:10Z","updated_at":"2015-02-14T16:16:30Z","pushed_at":"2015-02-14T16:16:30Z","git_url":"git://github.com/TimBeyer/html-to-vdom.git","ssh_url":"git@github.com:TimBeyer/html-to-vdom.git","clone_url":"https://github.com/TimBeyer/html-to-vdom.git","svn_url":"https://github.com/TimBeyer/html-to-vdom","homepage":null,"size":406,"stargazers_count":34,"watchers_count":34,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":3,"forks":10,"open_issues":3,"watchers":34,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TimBeyer/html-to-vdom/pulls/15"},"html":{"href":"https://github.com/TimBeyer/html-to-vdom/pull/15"},"issue":{"href":"https://api.github.com/repos/TimBeyer/html-to-vdom/issues/15"},"comments":{"href":"https://api.github.com/repos/TimBeyer/html-to-vdom/issues/15/comments"},"review_comments":{"href":"https://api.github.com/repos/TimBeyer/html-to-vdom/pulls/15/comments"},"review_comment":{"href":"https://api.github.com/repos/TimBeyer/html-to-vdom/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/TimBeyer/html-to-vdom/pulls/15/commits"},"statuses":{"href":"https://api.github.com/repos/TimBeyer/html-to-vdom/statuses/7e6ffdadab1ef0eb4f56e50b419d03aa10efb03a"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":176,"deletions":8,"changed_files":3}}