{"action":"created","issue":{"url":"https://api.github.com/repos/diegoceccarelli/json-wikipedia/issues/13","labels_url":"https://api.github.com/repos/diegoceccarelli/json-wikipedia/issues/13/labels{/name}","comments_url":"https://api.github.com/repos/diegoceccarelli/json-wikipedia/issues/13/comments","events_url":"https://api.github.com/repos/diegoceccarelli/json-wikipedia/issues/13/events","html_url":"https://github.com/diegoceccarelli/json-wikipedia/pull/13","id":112892786,"number":13,"title":"New article parser","user":{"login":"tgalery","id":1846448,"avatar_url":"https://avatars.githubusercontent.com/u/1846448?v=3","gravatar_id":"","url":"https://api.github.com/users/tgalery","html_url":"https://github.com/tgalery","followers_url":"https://api.github.com/users/tgalery/followers","following_url":"https://api.github.com/users/tgalery/following{/other_user}","gists_url":"https://api.github.com/users/tgalery/gists{/gist_id}","starred_url":"https://api.github.com/users/tgalery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgalery/subscriptions","organizations_url":"https://api.github.com/users/tgalery/orgs","repos_url":"https://api.github.com/users/tgalery/repos","events_url":"https://api.github.com/users/tgalery/events{/privacy}","received_events_url":"https://api.github.com/users/tgalery/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-10-22T21:12:53Z","updated_at":"2015-10-26T12:13:10Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/diegoceccarelli/json-wikipedia/pulls/13","html_url":"https://github.com/diegoceccarelli/json-wikipedia/pull/13","diff_url":"https://github.com/diegoceccarelli/json-wikipedia/pull/13.diff","patch_url":"https://github.com/diegoceccarelli/json-wikipedia/pull/13.patch"},"body":"Hi @diegoceccarelli, this is a PR that abstracts away some of the work done at Idio and by Gsoc on a new stats extractor for spotlight. I thought it would be nice to try to upstream some of the changes, so we can keep things centralised with you.\r\n\r\nA couple of things to note. We changed `description` to a more natural form of `anchor`, but if that breaks stuff (e.g. dexter), I'd be happy to change it back to the original.\r\n\r\nWe also made some of the article atributes transient, but we could revert that if some of them are necessary (e.g. I think this does some template unpacking, so they are not saved at the end result).\r\n\r\nI'm gonna make questions myself to people involved in this like @dav009 and @naveenmadhire , so please fire any questions away (I wouldn't merge this until they are properly discussed)."},"comment":{"url":"https://api.github.com/repos/diegoceccarelli/json-wikipedia/issues/comments/151114894","html_url":"https://github.com/diegoceccarelli/json-wikipedia/pull/13#issuecomment-151114894","issue_url":"https://api.github.com/repos/diegoceccarelli/json-wikipedia/issues/13","id":151114894,"user":{"login":"tgalery","id":1846448,"avatar_url":"https://avatars.githubusercontent.com/u/1846448?v=3","gravatar_id":"","url":"https://api.github.com/users/tgalery","html_url":"https://github.com/tgalery","followers_url":"https://api.github.com/users/tgalery/followers","following_url":"https://api.github.com/users/tgalery/following{/other_user}","gists_url":"https://api.github.com/users/tgalery/gists{/gist_id}","starred_url":"https://api.github.com/users/tgalery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgalery/subscriptions","organizations_url":"https://api.github.com/users/tgalery/orgs","repos_url":"https://api.github.com/users/tgalery/repos","events_url":"https://api.github.com/users/tgalery/events{/privacy}","received_events_url":"https://api.github.com/users/tgalery/received_events","type":"User","site_admin":false},"created_at":"2015-10-26T12:13:10Z","updated_at":"2015-10-26T12:13:10Z","body":"Hey guys thanks for the comments, so here is what I plan to do:\r\n\r\n- @diego: I like the idea of supporting what to serialize in a configuration object too, I'm not sure whether that is linked with the possible change of the library, but for the moment, I will just remove the transients and leave that as part of another PR.\r\n\r\n-  @dav009 @naveenmadhire: given @diegoceccarelli 's comments about the ParagraphWithLinks class, I wonder whether we should just keep the original Paragraph and have a method that puts the links in the paragraphs dynamically. It could be even something that returns a ParagraphsWithLinks, but that would be outside the schema? I'm also saying that because this method could be used in the generation of 'new links' for matches of the same surface form in the same article.\r\n\r\n- @dav009 The initial rebase that generated this PR just selected the commits of the Idio repo touching article and link classes. I think that another rebase to incorporate your commits that fix the tests would be quite painful, so I might take a look at your test fixing commits and add them here manually (since I am changing some stuff). That being said, your work on the parallel stuff would be a great contribution, I'm thinking of doing the same type or rebase and sending a PR over, but if any of you is faster than me, I won't be offended ;-).\r\n\r\nI'm gonna be in London in Jan, let's go for :beers: !"}}