{"action":"created","comment":{"url":"https://api.github.com/repos/ClusterHQ/CI-slave-images/pulls/comments/37978930","id":37978930,"diff_hunk":"@@ -577,24 +578,35 @@ def ubuntu14_required_packages(self):\n                 \"libsvn-perl\",\n                 \"ruby-dev\"]\n \n-    def check_for_missing_environment_variables(self):\n+    def check_for_missing_environment_variables(self, cloud_type=None):\n         \"\"\" double checks that the minimum environment variables have been\n             configured correctly.\n         \"\"\"\n+\n         env_var_missing = []\n-        for env_var in ['AWS_KEY_PAIR',\n-                        'AWS_KEY_FILENAME',\n-                        'RACKSPACE_KEY_PAIR',\n-                        'RACKSPACE_KEY_FILENAME',\n-                        'AWS_SECRET_ACCESS_KEY',\n-                        'AWS_ACCESS_KEY_ID',\n-                        'OS_USERNAME',\n-                        'OS_TENANT_NAME',\n-                        'OS_PASSWORD',\n-                        'OS_AUTH_URL',\n-                        'OS_AUTH_SYSTEM',\n-                        'OS_REGION_NAME',\n-                        'OS_NO_CACHE']:\n+\n+        cloud_vars = {'ec2': ['AWS_KEY_PAIR',\n+                              'AWS_KEY_FILENAME',\n+                              'RACKSPACE_KEY_PAIR',\n+                              'RACKSPACE_KEY_FILENAME',","path":"fabfile.py","position":36,"original_position":36,"commit_id":"4034923092886879e583161da0b4af9db2c9b3d9","original_commit_id":"4034923092886879e583161da0b4af9db2c9b3d9","user":{"login":"jml","id":125674,"avatar_url":"https://avatars.githubusercontent.com/u/125674?v=3","gravatar_id":"","url":"https://api.github.com/users/jml","html_url":"https://github.com/jml","followers_url":"https://api.github.com/users/jml/followers","following_url":"https://api.github.com/users/jml/following{/other_user}","gists_url":"https://api.github.com/users/jml/gists{/gist_id}","starred_url":"https://api.github.com/users/jml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jml/subscriptions","organizations_url":"https://api.github.com/users/jml/orgs","repos_url":"https://api.github.com/users/jml/repos","events_url":"https://api.github.com/users/jml/events{/privacy}","received_events_url":"https://api.github.com/users/jml/received_events","type":"User","site_admin":false},"body":"Should `RACKSPACE_*` be in the ec2 list? It seems wrong, or at least weird enough to require a comment explaining why.","created_at":"2015-08-26T13:12:06Z","updated_at":"2015-08-26T13:12:06Z","html_url":"https://github.com/ClusterHQ/CI-slave-images/pull/2#discussion_r37978930","pull_request_url":"https://api.github.com/repos/ClusterHQ/CI-slave-images/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/ClusterHQ/CI-slave-images/pulls/comments/37978930"},"html":{"href":"https://github.com/ClusterHQ/CI-slave-images/pull/2#discussion_r37978930"},"pull_request":{"href":"https://api.github.com/repos/ClusterHQ/CI-slave-images/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/ClusterHQ/CI-slave-images/pulls/2","id":43390557,"html_url":"https://github.com/ClusterHQ/CI-slave-images/pull/2","diff_url":"https://github.com/ClusterHQ/CI-slave-images/pull/2.diff","patch_url":"https://github.com/ClusterHQ/CI-slave-images/pull/2.patch","issue_url":"https://api.github.com/repos/ClusterHQ/CI-slave-images/issues/2","number":2,"state":"open","locked":false,"title":"[FLOC-2689] Fix environment checks floc 2689","user":{"login":"Azulinho","id":851757,"avatar_url":"https://avatars.githubusercontent.com/u/851757?v=3","gravatar_id":"","url":"https://api.github.com/users/Azulinho","html_url":"https://github.com/Azulinho","followers_url":"https://api.github.com/users/Azulinho/followers","following_url":"https://api.github.com/users/Azulinho/following{/other_user}","gists_url":"https://api.github.com/users/Azulinho/gists{/gist_id}","starred_url":"https://api.github.com/users/Azulinho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azulinho/subscriptions","organizations_url":"https://api.github.com/users/Azulinho/orgs","repos_url":"https://api.github.com/users/Azulinho/repos","events_url":"https://api.github.com/users/Azulinho/events{/privacy}","received_events_url":"https://api.github.com/users/Azulinho/received_events","type":"User","site_admin":false},"body":"Make sure it only checks for the environment variables for the cloud_type we are looking to provision","created_at":"2015-08-26T11:18:44Z","updated_at":"2015-08-26T13:12:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f8c3795d69134085d9db97ffb4a1814c2f5e7c1d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ClusterHQ/CI-slave-images/pulls/2/commits","review_comments_url":"https://api.github.com/repos/ClusterHQ/CI-slave-images/pulls/2/comments","review_comment_url":"https://api.github.com/repos/ClusterHQ/CI-slave-images/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ClusterHQ/CI-slave-images/issues/2/comments","statuses_url":"https://api.github.com/repos/ClusterHQ/CI-slave-images/statuses/4034923092886879e583161da0b4af9db2c9b3d9","head":{"label":"ClusterHQ:fix_environemnt_checks2_FLOC-2689","ref":"fix_environemnt_checks2_FLOC-2689","sha":"4034923092886879e583161da0b4af9db2c9b3d9","user":{"login":"ClusterHQ","id":7913449,"avatar_url":"https://avatars.githubusercontent.com/u/7913449?v=3","gravatar_id":"","url":"https://api.github.com/users/ClusterHQ","html_url":"https://github.com/ClusterHQ","followers_url":"https://api.github.com/users/ClusterHQ/followers","following_url":"https://api.github.com/users/ClusterHQ/following{/other_user}","gists_url":"https://api.github.com/users/ClusterHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ClusterHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ClusterHQ/subscriptions","organizations_url":"https://api.github.com/users/ClusterHQ/orgs","repos_url":"https://api.github.com/users/ClusterHQ/repos","events_url":"https://api.github.com/users/ClusterHQ/events{/privacy}","received_events_url":"https://api.github.com/users/ClusterHQ/received_events","type":"Organization","site_admin":false},"repo":{"id":40906341,"name":"CI-slave-images","full_name":"ClusterHQ/CI-slave-images","owner":{"login":"ClusterHQ","id":7913449,"avatar_url":"https://avatars.githubusercontent.com/u/7913449?v=3","gravatar_id":"","url":"https://api.github.com/users/ClusterHQ","html_url":"https://github.com/ClusterHQ","followers_url":"https://api.github.com/users/ClusterHQ/followers","following_url":"https://api.github.com/users/ClusterHQ/following{/other_user}","gists_url":"https://api.github.com/users/ClusterHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ClusterHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ClusterHQ/subscriptions","organizations_url":"https://api.github.com/users/ClusterHQ/orgs","repos_url":"https://api.github.com/users/ClusterHQ/repos","events_url":"https://api.github.com/users/ClusterHQ/events{/privacy}","received_events_url":"https://api.github.com/users/ClusterHQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ClusterHQ/CI-slave-images","description":"Contains the code to build our CI slave images","fork":false,"url":"https://api.github.com/repos/ClusterHQ/CI-slave-images","forks_url":"https://api.github.com/repos/ClusterHQ/CI-slave-images/forks","keys_url":"https://api.github.com/repos/ClusterHQ/CI-slave-images/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ClusterHQ/CI-slave-images/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ClusterHQ/CI-slave-images/teams","hooks_url":"https://api.github.com/repos/ClusterHQ/CI-slave-images/hooks","issue_events_url":"https://api.github.com/repos/ClusterHQ/CI-slave-images/issues/events{/number}","events_url":"https://api.github.com/repos/ClusterHQ/CI-slave-images/events","assignees_url":"https://api.github.com/repos/ClusterHQ/CI-slave-images/assignees{/user}","branches_url":"https://api.github.com/repos/ClusterHQ/CI-slave-images/branches{/branch}","tags_url":"https://api.github.com/repos/ClusterHQ/CI-slave-images/tags","blobs_url":"https://api.github.com/repos/ClusterHQ/CI-slave-images/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ClusterHQ/CI-slave-images/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ClusterHQ/CI-slave-images/git/refs{/sha}","trees_url":"https://api.github.com/repos/ClusterHQ/CI-slave-images/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ClusterHQ/CI-slave-images/statuses/{sha}","languages_url":"https://api.github.com/repos/ClusterHQ/CI-slave-images/languages","stargazers_url":"https://api.github.com/repos/ClusterHQ/CI-slave-images/stargazers","contributors_url":"https://api.github.com/repos/ClusterHQ/CI-slave-images/contributors","subscribers_url":"https://api.github.com/repos/ClusterHQ/CI-slave-images/subscribers","subscription_url":"https://api.github.com/repos/ClusterHQ/CI-slave-images/subscription","commits_url":"https://api.github.com/repos/ClusterHQ/CI-slave-images/commits{/sha}","git_commits_url":"https://api.github.com/repos/ClusterHQ/CI-slave-images/git/commits{/sha}","comments_url":"https://api.github.com/repos/ClusterHQ/CI-slave-images/comments{/number}","issue_comment_url":"https://api.github.com/repos/ClusterHQ/CI-slave-images/issues/comments{/number}","contents_url":"https://api.github.com/repos/ClusterHQ/CI-slave-images/contents/{+path}","compare_url":"https://api.github.com/repos/ClusterHQ/CI-slave-images/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ClusterHQ/CI-slave-images/merges","archive_url":"https://api.github.com/repos/ClusterHQ/CI-slave-images/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ClusterHQ/CI-slave-images/downloads","issues_url":"https://api.github.com/repos/ClusterHQ/CI-slave-images/issues{/number}","pulls_url":"https://api.github.com/repos/ClusterHQ/CI-slave-images/pulls{/number}","milestones_url":"https://api.github.com/repos/ClusterHQ/CI-slave-images/milestones{/number}","notifications_url":"https://api.github.com/repos/ClusterHQ/CI-slave-images/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ClusterHQ/CI-slave-images/labels{/name}","releases_url":"https://api.github.com/repos/ClusterHQ/CI-slave-images/releases{/id}","created_at":"2015-08-17T15:34:12Z","updated_at":"2015-08-23T18:52:33Z","pushed_at":"2015-08-26T11:18:44Z","git_url":"git://github.com/ClusterHQ/CI-slave-images.git","ssh_url":"git@github.com:ClusterHQ/CI-slave-images.git","clone_url":"https://github.com/ClusterHQ/CI-slave-images.git","svn_url":"https://github.com/ClusterHQ/CI-slave-images","homepage":null,"size":146,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"ClusterHQ:master","ref":"master","sha":"8625f2b084cdbeeaf9c35b44d850154d94e7202b","user":{"login":"ClusterHQ","id":7913449,"avatar_url":"https://avatars.githubusercontent.com/u/7913449?v=3","gravatar_id":"","url":"https://api.github.com/users/ClusterHQ","html_url":"https://github.com/ClusterHQ","followers_url":"https://api.github.com/users/ClusterHQ/followers","following_url":"https://api.github.com/users/ClusterHQ/following{/other_user}","gists_url":"https://api.github.com/users/ClusterHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ClusterHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ClusterHQ/subscriptions","organizations_url":"https://api.github.com/users/ClusterHQ/orgs","repos_url":"https://api.github.com/users/ClusterHQ/repos","events_url":"https://api.github.com/users/ClusterHQ/events{/privacy}","received_events_url":"https://api.github.com/users/ClusterHQ/received_events","type":"Organization","site_admin":false},"repo":{"id":40906341,"name":"CI-slave-images","full_name":"ClusterHQ/CI-slave-images","owner":{"login":"ClusterHQ","id":7913449,"avatar_url":"https://avatars.githubusercontent.com/u/7913449?v=3","gravatar_id":"","url":"https://api.github.com/users/ClusterHQ","html_url":"https://github.com/ClusterHQ","followers_url":"https://api.github.com/users/ClusterHQ/followers","following_url":"https://api.github.com/users/ClusterHQ/following{/other_user}","gists_url":"https://api.github.com/users/ClusterHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ClusterHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ClusterHQ/subscriptions","organizations_url":"https://api.github.com/users/ClusterHQ/orgs","repos_url":"https://api.github.com/users/ClusterHQ/repos","events_url":"https://api.github.com/users/ClusterHQ/events{/privacy}","received_events_url":"https://api.github.com/users/ClusterHQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ClusterHQ/CI-slave-images","description":"Contains the code to build our CI slave images","fork":false,"url":"https://api.github.com/repos/ClusterHQ/CI-slave-images","forks_url":"https://api.github.com/repos/ClusterHQ/CI-slave-images/forks","keys_url":"https://api.github.com/repos/ClusterHQ/CI-slave-images/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ClusterHQ/CI-slave-images/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ClusterHQ/CI-slave-images/teams","hooks_url":"https://api.github.com/repos/ClusterHQ/CI-slave-images/hooks","issue_events_url":"https://api.github.com/repos/ClusterHQ/CI-slave-images/issues/events{/number}","events_url":"https://api.github.com/repos/ClusterHQ/CI-slave-images/events","assignees_url":"https://api.github.com/repos/ClusterHQ/CI-slave-images/assignees{/user}","branches_url":"https://api.github.com/repos/ClusterHQ/CI-slave-images/branches{/branch}","tags_url":"https://api.github.com/repos/ClusterHQ/CI-slave-images/tags","blobs_url":"https://api.github.com/repos/ClusterHQ/CI-slave-images/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ClusterHQ/CI-slave-images/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ClusterHQ/CI-slave-images/git/refs{/sha}","trees_url":"https://api.github.com/repos/ClusterHQ/CI-slave-images/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ClusterHQ/CI-slave-images/statuses/{sha}","languages_url":"https://api.github.com/repos/ClusterHQ/CI-slave-images/languages","stargazers_url":"https://api.github.com/repos/ClusterHQ/CI-slave-images/stargazers","contributors_url":"https://api.github.com/repos/ClusterHQ/CI-slave-images/contributors","subscribers_url":"https://api.github.com/repos/ClusterHQ/CI-slave-images/subscribers","subscription_url":"https://api.github.com/repos/ClusterHQ/CI-slave-images/subscription","commits_url":"https://api.github.com/repos/ClusterHQ/CI-slave-images/commits{/sha}","git_commits_url":"https://api.github.com/repos/ClusterHQ/CI-slave-images/git/commits{/sha}","comments_url":"https://api.github.com/repos/ClusterHQ/CI-slave-images/comments{/number}","issue_comment_url":"https://api.github.com/repos/ClusterHQ/CI-slave-images/issues/comments{/number}","contents_url":"https://api.github.com/repos/ClusterHQ/CI-slave-images/contents/{+path}","compare_url":"https://api.github.com/repos/ClusterHQ/CI-slave-images/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ClusterHQ/CI-slave-images/merges","archive_url":"https://api.github.com/repos/ClusterHQ/CI-slave-images/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ClusterHQ/CI-slave-images/downloads","issues_url":"https://api.github.com/repos/ClusterHQ/CI-slave-images/issues{/number}","pulls_url":"https://api.github.com/repos/ClusterHQ/CI-slave-images/pulls{/number}","milestones_url":"https://api.github.com/repos/ClusterHQ/CI-slave-images/milestones{/number}","notifications_url":"https://api.github.com/repos/ClusterHQ/CI-slave-images/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ClusterHQ/CI-slave-images/labels{/name}","releases_url":"https://api.github.com/repos/ClusterHQ/CI-slave-images/releases{/id}","created_at":"2015-08-17T15:34:12Z","updated_at":"2015-08-23T18:52:33Z","pushed_at":"2015-08-26T11:18:44Z","git_url":"git://github.com/ClusterHQ/CI-slave-images.git","ssh_url":"git@github.com:ClusterHQ/CI-slave-images.git","clone_url":"https://github.com/ClusterHQ/CI-slave-images.git","svn_url":"https://github.com/ClusterHQ/CI-slave-images","homepage":null,"size":146,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ClusterHQ/CI-slave-images/pulls/2"},"html":{"href":"https://github.com/ClusterHQ/CI-slave-images/pull/2"},"issue":{"href":"https://api.github.com/repos/ClusterHQ/CI-slave-images/issues/2"},"comments":{"href":"https://api.github.com/repos/ClusterHQ/CI-slave-images/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/ClusterHQ/CI-slave-images/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/ClusterHQ/CI-slave-images/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ClusterHQ/CI-slave-images/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/ClusterHQ/CI-slave-images/statuses/4034923092886879e583161da0b4af9db2c9b3d9"}}}}