{"action":"created","comment":{"url":"https://api.github.com/repos/tc39/test262/pulls/comments/25103967","id":25103967,"diff_hunk":"@@ -0,0 +1,25 @@\n+// Copyright (C) Copyright 2014 the V8 project authors. All rights reserved.\n+// This code is governed by the BSD license found in the LICENSE file.\n+/*---\n+es6id: 14.5\n+description: >\n+    class strict mode\n+---*/\n+class C {}\n+\n+with ({a: 1}) {\n+  assert.sameValue(a, 1);\n+}\n+\n+assert.throws(SyntaxError,\n+             'class C extends function B() { with ({}); return B; }() {}');","path":"test/language/class/class-strict-mode.js","position":15,"original_position":15,"commit_id":"ccb24871642f97a594109b07977a6917ac66f80f","original_commit_id":"015c8a965ec18309196f3c93f6343b741b5f8493","user":{"login":"jugglinmike","id":677252,"avatar_url":"https://avatars.githubusercontent.com/u/677252?v=3","gravatar_id":"","url":"https://api.github.com/users/jugglinmike","html_url":"https://github.com/jugglinmike","followers_url":"https://api.github.com/users/jugglinmike/followers","following_url":"https://api.github.com/users/jugglinmike/following{/other_user}","gists_url":"https://api.github.com/users/jugglinmike/gists{/gist_id}","starred_url":"https://api.github.com/users/jugglinmike/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jugglinmike/subscriptions","organizations_url":"https://api.github.com/users/jugglinmike/orgs","repos_url":"https://api.github.com/users/jugglinmike/repos","events_url":"https://api.github.com/users/jugglinmike/events{/privacy}","received_events_url":"https://api.github.com/users/jugglinmike/received_events","type":"User","site_admin":false},"body":"It doesn't look like Test262's implementation of `assert.throws` accepts a string: https://github.com/tc39/test262/blob/ba3be4a575b453bd9792ecbfc5e4e844b2422434/harness/assert.js#L44-L64","created_at":"2015-02-20T21:20:31Z","updated_at":"2015-02-20T21:20:31Z","html_url":"https://github.com/tc39/test262/pull/175#discussion_r25103967","pull_request_url":"https://api.github.com/repos/tc39/test262/pulls/175","_links":{"self":{"href":"https://api.github.com/repos/tc39/test262/pulls/comments/25103967"},"html":{"href":"https://github.com/tc39/test262/pull/175#discussion_r25103967"},"pull_request":{"href":"https://api.github.com/repos/tc39/test262/pulls/175"}}},"pull_request":{"url":"https://api.github.com/repos/tc39/test262/pulls/175","id":29728082,"html_url":"https://github.com/tc39/test262/pull/175","diff_url":"https://github.com/tc39/test262/pull/175.diff","patch_url":"https://github.com/tc39/test262/pull/175.patch","issue_url":"https://api.github.com/repos/tc39/test262/issues/175","number":175,"state":"open","locked":false,"title":"Import tests from Google V8 (Class syntax & semantics)","user":{"login":"rwaldron","id":27985,"avatar_url":"https://avatars.githubusercontent.com/u/27985?v=3","gravatar_id":"","url":"https://api.github.com/users/rwaldron","html_url":"https://github.com/rwaldron","followers_url":"https://api.github.com/users/rwaldron/followers","following_url":"https://api.github.com/users/rwaldron/following{/other_user}","gists_url":"https://api.github.com/users/rwaldron/gists{/gist_id}","starred_url":"https://api.github.com/users/rwaldron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwaldron/subscriptions","organizations_url":"https://api.github.com/users/rwaldron/orgs","repos_url":"https://api.github.com/users/rwaldron/repos","events_url":"https://api.github.com/users/rwaldron/events{/privacy}","received_events_url":"https://api.github.com/users/rwaldron/received_events","type":"User","site_admin":false},"body":"These tests are derived from the following files within the Google V8\r\nproject:\r\n\r\n- test/mjsunit/harmony/class-computed-property-names-super.js\r\n- test/mjsunit/harmony/class-property-name-eval-arguments.js\r\n- test/mjsunit/harmony/classes-experimental.js\r\n- test/mjsunit/harmony/classes-lazy-parsing.js\r\n- test/mjsunit/harmony/classes.js\r\n\r\n\r\n\r\nI'd like to recommend adding the following to the harness: \r\n\r\n```js\r\nassert.methodDescriptor = function(object, name) {\r\n  var descr = Object.getOwnPropertyDescriptor(object, name);\r\n  assert.sameValue(descr.configurable, true);\r\n  assert.sameValue(descr.enumerable, false);\r\n  assert.sameValue(descr.writable, true);\r\n  assert.sameValue(typeof descr.value, 'function');\r\n  assert.sameValue('prototype' in descr.value, false);\r\n};\r\n\r\nassert.getterDescriptor = function(object, name) {\r\n  var descr = Object.getOwnPropertyDescriptor(object, name);\r\n  assert.sameValue(descr.configurable, true);\r\n  assert.sameValue(descr.enumerable, false);\r\n  assert.sameValue(typeof descr.get, 'function');\r\n  assert.sameValue('prototype' in descr.get, false);\r\n  assert.sameValue(descr.set, undefined);\r\n};\r\n\r\nassert.accessorDescriptor = function(object, name) {\r\n  var descr = Object.getOwnPropertyDescriptor(object, name);\r\n  assert.sameValue(descr.configurable, true);\r\n  assert.sameValue(descr.enumerable, false);\r\n  assert.sameValue(typeof descr.get, 'function');\r\n  assert.sameValue(typeof descr.set, 'function');\r\n  assert.sameValue('prototype' in descr.get, false);\r\n  assert.sameValue('prototype' in descr.set, false);\r\n};\r\n\r\nassert.setterDescriptor = function(object, name) {\r\n  var descr = Object.getOwnPropertyDescriptor(object, name);\r\n  assert.sameValue(descr.configurable, true);\r\n  assert.sameValue(descr.enumerable, false);\r\n  assert.sameValue(descr.get, undefined);\r\n  assert.sameValue(typeof descr.set, 'function');\r\n  assert.sameValue('prototype' in descr.set, false);\r\n};\r\n\r\n```\r\n\r\nI'm confident that there are plenty of places these could be used in the existing tests, as well as future tests. There is already some duplication among the tests here, but that could be eliminated by porting the V8 versions to test262 (as shown above)\r\n\r\n\r\n\r\n# Notes: \r\n\r\nThe frontmatter description field values are just the name of the file, which came from the IIFE they were originally wrapped in. I sincerely hope that I don't have to write 51 specific descriptions. The frontmatter es6id field values all point to the class section of the spec and no deeper. Locating the specific deep sections and writing descriptions should be written up as a new issue and offered as a \"good first bug\" to a community contributor. ","created_at":"2015-02-20T20:27:19Z","updated_at":"2015-02-20T21:20:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a7a99c55e11272fde9e1d565efcfd3e60103b0a3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/tc39/test262/pulls/175/commits","review_comments_url":"https://api.github.com/repos/tc39/test262/pulls/175/comments","review_comment_url":"https://api.github.com/repos/tc39/test262/pulls/comments/{number}","comments_url":"https://api.github.com/repos/tc39/test262/issues/175/comments","statuses_url":"https://api.github.com/repos/tc39/test262/statuses/ccb24871642f97a594109b07977a6917ac66f80f","head":{"label":"bocoup:harmony-classes","ref":"harmony-classes","sha":"ccb24871642f97a594109b07977a6917ac66f80f","user":{"login":"bocoup","id":497466,"avatar_url":"https://avatars.githubusercontent.com/u/497466?v=3","gravatar_id":"","url":"https://api.github.com/users/bocoup","html_url":"https://github.com/bocoup","followers_url":"https://api.github.com/users/bocoup/followers","following_url":"https://api.github.com/users/bocoup/following{/other_user}","gists_url":"https://api.github.com/users/bocoup/gists{/gist_id}","starred_url":"https://api.github.com/users/bocoup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bocoup/subscriptions","organizations_url":"https://api.github.com/users/bocoup/orgs","repos_url":"https://api.github.com/users/bocoup/repos","events_url":"https://api.github.com/users/bocoup/events{/privacy}","received_events_url":"https://api.github.com/users/bocoup/received_events","type":"Organization","site_admin":false},"repo":{"id":30556261,"name":"test262","full_name":"bocoup/test262","owner":{"login":"bocoup","id":497466,"avatar_url":"https://avatars.githubusercontent.com/u/497466?v=3","gravatar_id":"","url":"https://api.github.com/users/bocoup","html_url":"https://github.com/bocoup","followers_url":"https://api.github.com/users/bocoup/followers","following_url":"https://api.github.com/users/bocoup/following{/other_user}","gists_url":"https://api.github.com/users/bocoup/gists{/gist_id}","starred_url":"https://api.github.com/users/bocoup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bocoup/subscriptions","organizations_url":"https://api.github.com/users/bocoup/orgs","repos_url":"https://api.github.com/users/bocoup/repos","events_url":"https://api.github.com/users/bocoup/events{/privacy}","received_events_url":"https://api.github.com/users/bocoup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bocoup/test262","description":"Official ECMAScript Conformance Test Suite","fork":true,"url":"https://api.github.com/repos/bocoup/test262","forks_url":"https://api.github.com/repos/bocoup/test262/forks","keys_url":"https://api.github.com/repos/bocoup/test262/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bocoup/test262/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bocoup/test262/teams","hooks_url":"https://api.github.com/repos/bocoup/test262/hooks","issue_events_url":"https://api.github.com/repos/bocoup/test262/issues/events{/number}","events_url":"https://api.github.com/repos/bocoup/test262/events","assignees_url":"https://api.github.com/repos/bocoup/test262/assignees{/user}","branches_url":"https://api.github.com/repos/bocoup/test262/branches{/branch}","tags_url":"https://api.github.com/repos/bocoup/test262/tags","blobs_url":"https://api.github.com/repos/bocoup/test262/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bocoup/test262/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bocoup/test262/git/refs{/sha}","trees_url":"https://api.github.com/repos/bocoup/test262/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bocoup/test262/statuses/{sha}","languages_url":"https://api.github.com/repos/bocoup/test262/languages","stargazers_url":"https://api.github.com/repos/bocoup/test262/stargazers","contributors_url":"https://api.github.com/repos/bocoup/test262/contributors","subscribers_url":"https://api.github.com/repos/bocoup/test262/subscribers","subscription_url":"https://api.github.com/repos/bocoup/test262/subscription","commits_url":"https://api.github.com/repos/bocoup/test262/commits{/sha}","git_commits_url":"https://api.github.com/repos/bocoup/test262/git/commits{/sha}","comments_url":"https://api.github.com/repos/bocoup/test262/comments{/number}","issue_comment_url":"https://api.github.com/repos/bocoup/test262/issues/comments/{number}","contents_url":"https://api.github.com/repos/bocoup/test262/contents/{+path}","compare_url":"https://api.github.com/repos/bocoup/test262/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bocoup/test262/merges","archive_url":"https://api.github.com/repos/bocoup/test262/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bocoup/test262/downloads","issues_url":"https://api.github.com/repos/bocoup/test262/issues{/number}","pulls_url":"https://api.github.com/repos/bocoup/test262/pulls{/number}","milestones_url":"https://api.github.com/repos/bocoup/test262/milestones{/number}","notifications_url":"https://api.github.com/repos/bocoup/test262/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bocoup/test262/labels{/name}","releases_url":"https://api.github.com/repos/bocoup/test262/releases{/id}","created_at":"2015-02-09T20:17:23Z","updated_at":"2015-02-16T23:07:46Z","pushed_at":"2015-02-20T20:57:11Z","git_url":"git://github.com/bocoup/test262.git","ssh_url":"git@github.com:bocoup/test262.git","clone_url":"https://github.com/bocoup/test262.git","svn_url":"https://github.com/bocoup/test262","homepage":"test262.ecmascript.org","size":111358,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tc39:master","ref":"master","sha":"ba3be4a575b453bd9792ecbfc5e4e844b2422434","user":{"login":"tc39","id":1725583,"avatar_url":"https://avatars.githubusercontent.com/u/1725583?v=3","gravatar_id":"","url":"https://api.github.com/users/tc39","html_url":"https://github.com/tc39","followers_url":"https://api.github.com/users/tc39/followers","following_url":"https://api.github.com/users/tc39/following{/other_user}","gists_url":"https://api.github.com/users/tc39/gists{/gist_id}","starred_url":"https://api.github.com/users/tc39/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tc39/subscriptions","organizations_url":"https://api.github.com/users/tc39/orgs","repos_url":"https://api.github.com/users/tc39/repos","events_url":"https://api.github.com/users/tc39/events{/privacy}","received_events_url":"https://api.github.com/users/tc39/received_events","type":"Organization","site_admin":false},"repo":{"id":16147933,"name":"test262","full_name":"tc39/test262","owner":{"login":"tc39","id":1725583,"avatar_url":"https://avatars.githubusercontent.com/u/1725583?v=3","gravatar_id":"","url":"https://api.github.com/users/tc39","html_url":"https://github.com/tc39","followers_url":"https://api.github.com/users/tc39/followers","following_url":"https://api.github.com/users/tc39/following{/other_user}","gists_url":"https://api.github.com/users/tc39/gists{/gist_id}","starred_url":"https://api.github.com/users/tc39/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tc39/subscriptions","organizations_url":"https://api.github.com/users/tc39/orgs","repos_url":"https://api.github.com/users/tc39/repos","events_url":"https://api.github.com/users/tc39/events{/privacy}","received_events_url":"https://api.github.com/users/tc39/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tc39/test262","description":"Official ECMAScript Conformance Test Suite","fork":false,"url":"https://api.github.com/repos/tc39/test262","forks_url":"https://api.github.com/repos/tc39/test262/forks","keys_url":"https://api.github.com/repos/tc39/test262/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tc39/test262/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tc39/test262/teams","hooks_url":"https://api.github.com/repos/tc39/test262/hooks","issue_events_url":"https://api.github.com/repos/tc39/test262/issues/events{/number}","events_url":"https://api.github.com/repos/tc39/test262/events","assignees_url":"https://api.github.com/repos/tc39/test262/assignees{/user}","branches_url":"https://api.github.com/repos/tc39/test262/branches{/branch}","tags_url":"https://api.github.com/repos/tc39/test262/tags","blobs_url":"https://api.github.com/repos/tc39/test262/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tc39/test262/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tc39/test262/git/refs{/sha}","trees_url":"https://api.github.com/repos/tc39/test262/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tc39/test262/statuses/{sha}","languages_url":"https://api.github.com/repos/tc39/test262/languages","stargazers_url":"https://api.github.com/repos/tc39/test262/stargazers","contributors_url":"https://api.github.com/repos/tc39/test262/contributors","subscribers_url":"https://api.github.com/repos/tc39/test262/subscribers","subscription_url":"https://api.github.com/repos/tc39/test262/subscription","commits_url":"https://api.github.com/repos/tc39/test262/commits{/sha}","git_commits_url":"https://api.github.com/repos/tc39/test262/git/commits{/sha}","comments_url":"https://api.github.com/repos/tc39/test262/comments{/number}","issue_comment_url":"https://api.github.com/repos/tc39/test262/issues/comments/{number}","contents_url":"https://api.github.com/repos/tc39/test262/contents/{+path}","compare_url":"https://api.github.com/repos/tc39/test262/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tc39/test262/merges","archive_url":"https://api.github.com/repos/tc39/test262/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tc39/test262/downloads","issues_url":"https://api.github.com/repos/tc39/test262/issues{/number}","pulls_url":"https://api.github.com/repos/tc39/test262/pulls{/number}","milestones_url":"https://api.github.com/repos/tc39/test262/milestones{/number}","notifications_url":"https://api.github.com/repos/tc39/test262/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tc39/test262/labels{/name}","releases_url":"https://api.github.com/repos/tc39/test262/releases{/id}","created_at":"2014-01-22T18:20:05Z","updated_at":"2015-02-20T19:53:57Z","pushed_at":"2015-02-20T19:53:48Z","git_url":"git://github.com/tc39/test262.git","ssh_url":"git@github.com:tc39/test262.git","clone_url":"https://github.com/tc39/test262.git","svn_url":"https://github.com/tc39/test262","homepage":"test262.ecmascript.org","size":134407,"stargazers_count":112,"watchers_count":112,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":46,"mirror_url":null,"open_issues_count":35,"forks":46,"open_issues":35,"watchers":112,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tc39/test262/pulls/175"},"html":{"href":"https://github.com/tc39/test262/pull/175"},"issue":{"href":"https://api.github.com/repos/tc39/test262/issues/175"},"comments":{"href":"https://api.github.com/repos/tc39/test262/issues/175/comments"},"review_comments":{"href":"https://api.github.com/repos/tc39/test262/pulls/175/comments"},"review_comment":{"href":"https://api.github.com/repos/tc39/test262/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/tc39/test262/pulls/175/commits"},"statuses":{"href":"https://api.github.com/repos/tc39/test262/statuses/ccb24871642f97a594109b07977a6917ac66f80f"}}}}