{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla-services/autopush/pulls/comments/30350939","id":30350939,"diff_hunk":"@@ -45,6 +45,33 @@ class SimplePushServerProtocol(WebSocketServerProtocol):\n     # Testing purposes\n     parent_class = WebSocketServerProtocol\n \n+    # Defer helpers\n+    def deferToThread(self, func, *args, **kwargs):\n+        d = deferToThread(func, *args, **kwargs)\n+        self._callbacks.append(d)\n+\n+        def f(result):\n+            if d in self._callbacks:\n+                self._callbacks.remove(d)\n+            return result\n+        d.addBoth(f)","path":"autopush/websocket.py","position":13,"original_position":13,"commit_id":"825ab561538299f7ae44c900b42a844e6099c30f","original_commit_id":"825ab561538299f7ae44c900b42a844e6099c30f","user":{"login":"bbangert","id":100193,"avatar_url":"https://avatars.githubusercontent.com/u/100193?v=3","gravatar_id":"","url":"https://api.github.com/users/bbangert","html_url":"https://github.com/bbangert","followers_url":"https://api.github.com/users/bbangert/followers","following_url":"https://api.github.com/users/bbangert/following{/other_user}","gists_url":"https://api.github.com/users/bbangert/gists{/gist_id}","starred_url":"https://api.github.com/users/bbangert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbangert/subscriptions","organizations_url":"https://api.github.com/users/bbangert/orgs","repos_url":"https://api.github.com/users/bbangert/repos","events_url":"https://api.github.com/users/bbangert/events{/privacy}","received_events_url":"https://api.github.com/users/bbangert/received_events","type":"User","site_admin":false},"body":"It gets called whether its a failure passed in, or result, and since I return it, its passed regardless to the next in the chain.","created_at":"2015-05-14T18:55:40Z","updated_at":"2015-05-14T18:55:40Z","html_url":"https://github.com/mozilla-services/autopush/pull/68#discussion_r30350939","pull_request_url":"https://api.github.com/repos/mozilla-services/autopush/pulls/68","_links":{"self":{"href":"https://api.github.com/repos/mozilla-services/autopush/pulls/comments/30350939"},"html":{"href":"https://github.com/mozilla-services/autopush/pull/68#discussion_r30350939"},"pull_request":{"href":"https://api.github.com/repos/mozilla-services/autopush/pulls/68"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla-services/autopush/pulls/68","id":35449477,"html_url":"https://github.com/mozilla-services/autopush/pull/68","diff_url":"https://github.com/mozilla-services/autopush/pull/68.diff","patch_url":"https://github.com/mozilla-services/autopush/pull/68.patch","issue_url":"https://api.github.com/repos/mozilla-services/autopush/issues/68","number":68,"state":"open","locked":false,"title":"Track deferreds and remove them on client shutdown.","user":{"login":"bbangert","id":100193,"avatar_url":"https://avatars.githubusercontent.com/u/100193?v=3","gravatar_id":"","url":"https://api.github.com/users/bbangert","html_url":"https://github.com/bbangert","followers_url":"https://api.github.com/users/bbangert/followers","following_url":"https://api.github.com/users/bbangert/following{/other_user}","gists_url":"https://api.github.com/users/bbangert/gists{/gist_id}","starred_url":"https://api.github.com/users/bbangert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbangert/subscriptions","organizations_url":"https://api.github.com/users/bbangert/orgs","repos_url":"https://api.github.com/users/bbangert/repos","events_url":"https://api.github.com/users/bbangert/events{/privacy}","received_events_url":"https://api.github.com/users/bbangert/received_events","type":"User","site_admin":false},"body":"Fixes #66.","created_at":"2015-05-14T18:46:23Z","updated_at":"2015-05-14T18:55:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"08e07684c6c86fbb9a6f88772dafabd440c3a7d1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-services/autopush/pulls/68/commits","review_comments_url":"https://api.github.com/repos/mozilla-services/autopush/pulls/68/comments","review_comment_url":"https://api.github.com/repos/mozilla-services/autopush/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla-services/autopush/issues/68/comments","statuses_url":"https://api.github.com/repos/mozilla-services/autopush/statuses/825ab561538299f7ae44c900b42a844e6099c30f","head":{"label":"mozilla-services:bug/track-callbacks","ref":"bug/track-callbacks","sha":"825ab561538299f7ae44c900b42a844e6099c30f","user":{"login":"mozilla-services","id":1066228,"avatar_url":"https://avatars.githubusercontent.com/u/1066228?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-services","html_url":"https://github.com/mozilla-services","followers_url":"https://api.github.com/users/mozilla-services/followers","following_url":"https://api.github.com/users/mozilla-services/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-services/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-services/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-services/subscriptions","organizations_url":"https://api.github.com/users/mozilla-services/orgs","repos_url":"https://api.github.com/users/mozilla-services/repos","events_url":"https://api.github.com/users/mozilla-services/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-services/received_events","type":"Organization","site_admin":false},"repo":{"id":31746003,"name":"autopush","full_name":"mozilla-services/autopush","owner":{"login":"mozilla-services","id":1066228,"avatar_url":"https://avatars.githubusercontent.com/u/1066228?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-services","html_url":"https://github.com/mozilla-services","followers_url":"https://api.github.com/users/mozilla-services/followers","following_url":"https://api.github.com/users/mozilla-services/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-services/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-services/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-services/subscriptions","organizations_url":"https://api.github.com/users/mozilla-services/orgs","repos_url":"https://api.github.com/users/mozilla-services/repos","events_url":"https://api.github.com/users/mozilla-services/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-services/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-services/autopush","description":"Python Push Server","fork":false,"url":"https://api.github.com/repos/mozilla-services/autopush","forks_url":"https://api.github.com/repos/mozilla-services/autopush/forks","keys_url":"https://api.github.com/repos/mozilla-services/autopush/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-services/autopush/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-services/autopush/teams","hooks_url":"https://api.github.com/repos/mozilla-services/autopush/hooks","issue_events_url":"https://api.github.com/repos/mozilla-services/autopush/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-services/autopush/events","assignees_url":"https://api.github.com/repos/mozilla-services/autopush/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-services/autopush/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-services/autopush/tags","blobs_url":"https://api.github.com/repos/mozilla-services/autopush/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-services/autopush/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-services/autopush/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-services/autopush/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-services/autopush/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-services/autopush/languages","stargazers_url":"https://api.github.com/repos/mozilla-services/autopush/stargazers","contributors_url":"https://api.github.com/repos/mozilla-services/autopush/contributors","subscribers_url":"https://api.github.com/repos/mozilla-services/autopush/subscribers","subscription_url":"https://api.github.com/repos/mozilla-services/autopush/subscription","commits_url":"https://api.github.com/repos/mozilla-services/autopush/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-services/autopush/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-services/autopush/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-services/autopush/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla-services/autopush/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-services/autopush/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-services/autopush/merges","archive_url":"https://api.github.com/repos/mozilla-services/autopush/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-services/autopush/downloads","issues_url":"https://api.github.com/repos/mozilla-services/autopush/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-services/autopush/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-services/autopush/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-services/autopush/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-services/autopush/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-services/autopush/releases{/id}","created_at":"2015-03-06T01:19:24Z","updated_at":"2015-04-30T00:21:11Z","pushed_at":"2015-05-14T18:46:23Z","git_url":"git://github.com/mozilla-services/autopush.git","ssh_url":"git@github.com:mozilla-services/autopush.git","clone_url":"https://github.com/mozilla-services/autopush.git","svn_url":"https://github.com/mozilla-services/autopush","homepage":"","size":1124,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":10,"forks":0,"open_issues":10,"watchers":4,"default_branch":"master"}},"base":{"label":"mozilla-services:master","ref":"master","sha":"e376bc7fcf84435c3034cfda334e65b2a91a5263","user":{"login":"mozilla-services","id":1066228,"avatar_url":"https://avatars.githubusercontent.com/u/1066228?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-services","html_url":"https://github.com/mozilla-services","followers_url":"https://api.github.com/users/mozilla-services/followers","following_url":"https://api.github.com/users/mozilla-services/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-services/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-services/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-services/subscriptions","organizations_url":"https://api.github.com/users/mozilla-services/orgs","repos_url":"https://api.github.com/users/mozilla-services/repos","events_url":"https://api.github.com/users/mozilla-services/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-services/received_events","type":"Organization","site_admin":false},"repo":{"id":31746003,"name":"autopush","full_name":"mozilla-services/autopush","owner":{"login":"mozilla-services","id":1066228,"avatar_url":"https://avatars.githubusercontent.com/u/1066228?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-services","html_url":"https://github.com/mozilla-services","followers_url":"https://api.github.com/users/mozilla-services/followers","following_url":"https://api.github.com/users/mozilla-services/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-services/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-services/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-services/subscriptions","organizations_url":"https://api.github.com/users/mozilla-services/orgs","repos_url":"https://api.github.com/users/mozilla-services/repos","events_url":"https://api.github.com/users/mozilla-services/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-services/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-services/autopush","description":"Python Push Server","fork":false,"url":"https://api.github.com/repos/mozilla-services/autopush","forks_url":"https://api.github.com/repos/mozilla-services/autopush/forks","keys_url":"https://api.github.com/repos/mozilla-services/autopush/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-services/autopush/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-services/autopush/teams","hooks_url":"https://api.github.com/repos/mozilla-services/autopush/hooks","issue_events_url":"https://api.github.com/repos/mozilla-services/autopush/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-services/autopush/events","assignees_url":"https://api.github.com/repos/mozilla-services/autopush/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-services/autopush/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-services/autopush/tags","blobs_url":"https://api.github.com/repos/mozilla-services/autopush/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-services/autopush/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-services/autopush/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-services/autopush/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-services/autopush/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-services/autopush/languages","stargazers_url":"https://api.github.com/repos/mozilla-services/autopush/stargazers","contributors_url":"https://api.github.com/repos/mozilla-services/autopush/contributors","subscribers_url":"https://api.github.com/repos/mozilla-services/autopush/subscribers","subscription_url":"https://api.github.com/repos/mozilla-services/autopush/subscription","commits_url":"https://api.github.com/repos/mozilla-services/autopush/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-services/autopush/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-services/autopush/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-services/autopush/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla-services/autopush/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-services/autopush/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-services/autopush/merges","archive_url":"https://api.github.com/repos/mozilla-services/autopush/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-services/autopush/downloads","issues_url":"https://api.github.com/repos/mozilla-services/autopush/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-services/autopush/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-services/autopush/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-services/autopush/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-services/autopush/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-services/autopush/releases{/id}","created_at":"2015-03-06T01:19:24Z","updated_at":"2015-04-30T00:21:11Z","pushed_at":"2015-05-14T18:46:23Z","git_url":"git://github.com/mozilla-services/autopush.git","ssh_url":"git@github.com:mozilla-services/autopush.git","clone_url":"https://github.com/mozilla-services/autopush.git","svn_url":"https://github.com/mozilla-services/autopush","homepage":"","size":1124,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":10,"forks":0,"open_issues":10,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-services/autopush/pulls/68"},"html":{"href":"https://github.com/mozilla-services/autopush/pull/68"},"issue":{"href":"https://api.github.com/repos/mozilla-services/autopush/issues/68"},"comments":{"href":"https://api.github.com/repos/mozilla-services/autopush/issues/68/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-services/autopush/pulls/68/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-services/autopush/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla-services/autopush/pulls/68/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-services/autopush/statuses/825ab561538299f7ae44c900b42a844e6099c30f"}}}}