{"action":"created","comment":{"url":"https://api.github.com/repos/hpcugent/easybuild-framework/pulls/comments/36297521","id":36297521,"diff_hunk":"@@ -563,22 +551,85 @@ def include_defined_parameters(keyset):\n         ebtxt.extend(self.comments['header'])\n \n         # print easyconfig parameters ordered and in groups specified above\n-        include_defined_parameters(GROUPED_PARAMS)\n+        include_defined_parameters(ebtxt, GROUPED_PARAMS)\n \n         # print other easyconfig parameters at the end\n         keys_to_ignore = printed_keys + LAST_PARAMS\n         for key in default_values:\n             if key not in keys_to_ignore and self[key] != default_values[key]:\n-                add_key_and_comments(key, quote_py_str(self[key]))\n+                ebtxt = self._add_key_and_comments(ebtxt, key, quote_py_str(self[key]), templ_const, templ_val, formatting)\n         ebtxt.append('')\n \n         # print last parameters\n-        include_defined_parameters([[k] for k in LAST_PARAMS])\n+        include_defined_parameters(ebtxt, [[k] for k in LAST_PARAMS])\n \n         write_file(fp, ('\\n'.join(ebtxt)).strip()) # strip for newlines at the end\n \n+        dumped_text = ('\\n'.join(ebtxt))\n+        write_file(fp, (fix_code(dumped_text, options={'aggressive': 1, 'max_line_length':120})).strip())","path":"easybuild/framework/easyconfig/easyconfig.py","position":80,"original_position":80,"commit_id":"f7d5ed2ce93b5c91a7deee047d6084446cde8423","original_commit_id":"f7d5ed2ce93b5c91a7deee047d6084446cde8423","user":{"login":"boegel","id":620876,"avatar_url":"https://avatars.githubusercontent.com/u/620876?v=3","gravatar_id":"","url":"https://api.github.com/users/boegel","html_url":"https://github.com/boegel","followers_url":"https://api.github.com/users/boegel/followers","following_url":"https://api.github.com/users/boegel/following{/other_user}","gists_url":"https://api.github.com/users/boegel/gists{/gist_id}","starred_url":"https://api.github.com/users/boegel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boegel/subscriptions","organizations_url":"https://api.github.com/users/boegel/orgs","repos_url":"https://api.github.com/users/boegel/repos","events_url":"https://api.github.com/users/boegel/events{/privacy}","received_events_url":"https://api.github.com/users/boegel/received_events","type":"User","site_admin":false},"body":"only do this if both `autopep8` and `pep8` are available?","created_at":"2015-08-05T12:54:08Z","updated_at":"2015-08-05T12:54:08Z","html_url":"https://github.com/hpcugent/easybuild-framework/pull/1330#discussion_r36297521","pull_request_url":"https://api.github.com/repos/hpcugent/easybuild-framework/pulls/1330","_links":{"self":{"href":"https://api.github.com/repos/hpcugent/easybuild-framework/pulls/comments/36297521"},"html":{"href":"https://github.com/hpcugent/easybuild-framework/pull/1330#discussion_r36297521"},"pull_request":{"href":"https://api.github.com/repos/hpcugent/easybuild-framework/pulls/1330"}}},"pull_request":{"url":"https://api.github.com/repos/hpcugent/easybuild-framework/pulls/1330","id":41009062,"html_url":"https://github.com/hpcugent/easybuild-framework/pull/1330","diff_url":"https://github.com/hpcugent/easybuild-framework/pull/1330.diff","patch_url":"https://github.com/hpcugent/easybuild-framework/pull/1330.patch","issue_url":"https://api.github.com/repos/hpcugent/easybuild-framework/issues/1330","number":1330,"state":"open","locked":false,"title":"Dump formatting","user":{"login":"Caylo","id":3251843,"avatar_url":"https://avatars.githubusercontent.com/u/3251843?v=3","gravatar_id":"","url":"https://api.github.com/users/Caylo","html_url":"https://github.com/Caylo","followers_url":"https://api.github.com/users/Caylo/followers","following_url":"https://api.github.com/users/Caylo/following{/other_user}","gists_url":"https://api.github.com/users/Caylo/gists{/gist_id}","starred_url":"https://api.github.com/users/Caylo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Caylo/subscriptions","organizations_url":"https://api.github.com/users/Caylo/orgs","repos_url":"https://api.github.com/users/Caylo/repos","events_url":"https://api.github.com/users/Caylo/events{/privacy}","received_events_url":"https://api.github.com/users/Caylo/received_events","type":"User","site_admin":false},"body":"https://github.com/hpcugent/easybuild-framework/pull/1327 will have to be merged first.\r\n\r\nTakes care of formatting and inline comments for dump() method","created_at":"2015-07-28T13:08:55Z","updated_at":"2015-08-05T12:54:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"953e1b7fc4cf9772a645d2544bd02344bc059d7b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hpcugent/easybuild-framework/pulls/1330/commits","review_comments_url":"https://api.github.com/repos/hpcugent/easybuild-framework/pulls/1330/comments","review_comment_url":"https://api.github.com/repos/hpcugent/easybuild-framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hpcugent/easybuild-framework/issues/1330/comments","statuses_url":"https://api.github.com/repos/hpcugent/easybuild-framework/statuses/f7d5ed2ce93b5c91a7deee047d6084446cde8423","head":{"label":"Caylo:dump-formatting","ref":"dump-formatting","sha":"f7d5ed2ce93b5c91a7deee047d6084446cde8423","user":{"login":"Caylo","id":3251843,"avatar_url":"https://avatars.githubusercontent.com/u/3251843?v=3","gravatar_id":"","url":"https://api.github.com/users/Caylo","html_url":"https://github.com/Caylo","followers_url":"https://api.github.com/users/Caylo/followers","following_url":"https://api.github.com/users/Caylo/following{/other_user}","gists_url":"https://api.github.com/users/Caylo/gists{/gist_id}","starred_url":"https://api.github.com/users/Caylo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Caylo/subscriptions","organizations_url":"https://api.github.com/users/Caylo/orgs","repos_url":"https://api.github.com/users/Caylo/repos","events_url":"https://api.github.com/users/Caylo/events{/privacy}","received_events_url":"https://api.github.com/users/Caylo/received_events","type":"User","site_admin":false},"repo":{"id":38231913,"name":"easybuild-framework","full_name":"Caylo/easybuild-framework","owner":{"login":"Caylo","id":3251843,"avatar_url":"https://avatars.githubusercontent.com/u/3251843?v=3","gravatar_id":"","url":"https://api.github.com/users/Caylo","html_url":"https://github.com/Caylo","followers_url":"https://api.github.com/users/Caylo/followers","following_url":"https://api.github.com/users/Caylo/following{/other_user}","gists_url":"https://api.github.com/users/Caylo/gists{/gist_id}","starred_url":"https://api.github.com/users/Caylo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Caylo/subscriptions","organizations_url":"https://api.github.com/users/Caylo/orgs","repos_url":"https://api.github.com/users/Caylo/repos","events_url":"https://api.github.com/users/Caylo/events{/privacy}","received_events_url":"https://api.github.com/users/Caylo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Caylo/easybuild-framework","description":"EasyBuild is a software installation framework in Python that allows you to install software in a structured and robust way. ","fork":true,"url":"https://api.github.com/repos/Caylo/easybuild-framework","forks_url":"https://api.github.com/repos/Caylo/easybuild-framework/forks","keys_url":"https://api.github.com/repos/Caylo/easybuild-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Caylo/easybuild-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Caylo/easybuild-framework/teams","hooks_url":"https://api.github.com/repos/Caylo/easybuild-framework/hooks","issue_events_url":"https://api.github.com/repos/Caylo/easybuild-framework/issues/events{/number}","events_url":"https://api.github.com/repos/Caylo/easybuild-framework/events","assignees_url":"https://api.github.com/repos/Caylo/easybuild-framework/assignees{/user}","branches_url":"https://api.github.com/repos/Caylo/easybuild-framework/branches{/branch}","tags_url":"https://api.github.com/repos/Caylo/easybuild-framework/tags","blobs_url":"https://api.github.com/repos/Caylo/easybuild-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Caylo/easybuild-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Caylo/easybuild-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/Caylo/easybuild-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Caylo/easybuild-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/Caylo/easybuild-framework/languages","stargazers_url":"https://api.github.com/repos/Caylo/easybuild-framework/stargazers","contributors_url":"https://api.github.com/repos/Caylo/easybuild-framework/contributors","subscribers_url":"https://api.github.com/repos/Caylo/easybuild-framework/subscribers","subscription_url":"https://api.github.com/repos/Caylo/easybuild-framework/subscription","commits_url":"https://api.github.com/repos/Caylo/easybuild-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/Caylo/easybuild-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/Caylo/easybuild-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/Caylo/easybuild-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/Caylo/easybuild-framework/contents/{+path}","compare_url":"https://api.github.com/repos/Caylo/easybuild-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Caylo/easybuild-framework/merges","archive_url":"https://api.github.com/repos/Caylo/easybuild-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Caylo/easybuild-framework/downloads","issues_url":"https://api.github.com/repos/Caylo/easybuild-framework/issues{/number}","pulls_url":"https://api.github.com/repos/Caylo/easybuild-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/Caylo/easybuild-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/Caylo/easybuild-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Caylo/easybuild-framework/labels{/name}","releases_url":"https://api.github.com/repos/Caylo/easybuild-framework/releases{/id}","created_at":"2015-06-29T06:43:22Z","updated_at":"2015-06-29T06:43:23Z","pushed_at":"2015-08-05T11:43:47Z","git_url":"git://github.com/Caylo/easybuild-framework.git","ssh_url":"git@github.com:Caylo/easybuild-framework.git","clone_url":"https://github.com/Caylo/easybuild-framework.git","svn_url":"https://github.com/Caylo/easybuild-framework","homepage":"http://hpcugent.github.com/easybuild/","size":10693,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hpcugent:develop","ref":"develop","sha":"c7a3777e688358c6543b5beee74c40732e3eff37","user":{"login":"hpcugent","id":1515263,"avatar_url":"https://avatars.githubusercontent.com/u/1515263?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcugent","html_url":"https://github.com/hpcugent","followers_url":"https://api.github.com/users/hpcugent/followers","following_url":"https://api.github.com/users/hpcugent/following{/other_user}","gists_url":"https://api.github.com/users/hpcugent/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcugent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcugent/subscriptions","organizations_url":"https://api.github.com/users/hpcugent/orgs","repos_url":"https://api.github.com/users/hpcugent/repos","events_url":"https://api.github.com/users/hpcugent/events{/privacy}","received_events_url":"https://api.github.com/users/hpcugent/received_events","type":"Organization","site_admin":false},"repo":{"id":3662176,"name":"easybuild-framework","full_name":"hpcugent/easybuild-framework","owner":{"login":"hpcugent","id":1515263,"avatar_url":"https://avatars.githubusercontent.com/u/1515263?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcugent","html_url":"https://github.com/hpcugent","followers_url":"https://api.github.com/users/hpcugent/followers","following_url":"https://api.github.com/users/hpcugent/following{/other_user}","gists_url":"https://api.github.com/users/hpcugent/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcugent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcugent/subscriptions","organizations_url":"https://api.github.com/users/hpcugent/orgs","repos_url":"https://api.github.com/users/hpcugent/repos","events_url":"https://api.github.com/users/hpcugent/events{/privacy}","received_events_url":"https://api.github.com/users/hpcugent/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hpcugent/easybuild-framework","description":"EasyBuild is a software installation framework in Python that allows you to install software in a structured and robust way. ","fork":false,"url":"https://api.github.com/repos/hpcugent/easybuild-framework","forks_url":"https://api.github.com/repos/hpcugent/easybuild-framework/forks","keys_url":"https://api.github.com/repos/hpcugent/easybuild-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hpcugent/easybuild-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hpcugent/easybuild-framework/teams","hooks_url":"https://api.github.com/repos/hpcugent/easybuild-framework/hooks","issue_events_url":"https://api.github.com/repos/hpcugent/easybuild-framework/issues/events{/number}","events_url":"https://api.github.com/repos/hpcugent/easybuild-framework/events","assignees_url":"https://api.github.com/repos/hpcugent/easybuild-framework/assignees{/user}","branches_url":"https://api.github.com/repos/hpcugent/easybuild-framework/branches{/branch}","tags_url":"https://api.github.com/repos/hpcugent/easybuild-framework/tags","blobs_url":"https://api.github.com/repos/hpcugent/easybuild-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hpcugent/easybuild-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hpcugent/easybuild-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/hpcugent/easybuild-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hpcugent/easybuild-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/hpcugent/easybuild-framework/languages","stargazers_url":"https://api.github.com/repos/hpcugent/easybuild-framework/stargazers","contributors_url":"https://api.github.com/repos/hpcugent/easybuild-framework/contributors","subscribers_url":"https://api.github.com/repos/hpcugent/easybuild-framework/subscribers","subscription_url":"https://api.github.com/repos/hpcugent/easybuild-framework/subscription","commits_url":"https://api.github.com/repos/hpcugent/easybuild-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/hpcugent/easybuild-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/hpcugent/easybuild-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/hpcugent/easybuild-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/hpcugent/easybuild-framework/contents/{+path}","compare_url":"https://api.github.com/repos/hpcugent/easybuild-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hpcugent/easybuild-framework/merges","archive_url":"https://api.github.com/repos/hpcugent/easybuild-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hpcugent/easybuild-framework/downloads","issues_url":"https://api.github.com/repos/hpcugent/easybuild-framework/issues{/number}","pulls_url":"https://api.github.com/repos/hpcugent/easybuild-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/hpcugent/easybuild-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/hpcugent/easybuild-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hpcugent/easybuild-framework/labels{/name}","releases_url":"https://api.github.com/repos/hpcugent/easybuild-framework/releases{/id}","created_at":"2012-03-08T17:07:43Z","updated_at":"2015-07-07T13:06:42Z","pushed_at":"2015-08-05T11:43:48Z","git_url":"git://github.com/hpcugent/easybuild-framework.git","ssh_url":"git@github.com:hpcugent/easybuild-framework.git","clone_url":"https://github.com/hpcugent/easybuild-framework.git","svn_url":"https://github.com/hpcugent/easybuild-framework","homepage":"http://hpcugent.github.com/easybuild/","size":16225,"stargazers_count":47,"watchers_count":47,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":63,"mirror_url":null,"open_issues_count":242,"forks":63,"open_issues":242,"watchers":47,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hpcugent/easybuild-framework/pulls/1330"},"html":{"href":"https://github.com/hpcugent/easybuild-framework/pull/1330"},"issue":{"href":"https://api.github.com/repos/hpcugent/easybuild-framework/issues/1330"},"comments":{"href":"https://api.github.com/repos/hpcugent/easybuild-framework/issues/1330/comments"},"review_comments":{"href":"https://api.github.com/repos/hpcugent/easybuild-framework/pulls/1330/comments"},"review_comment":{"href":"https://api.github.com/repos/hpcugent/easybuild-framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hpcugent/easybuild-framework/pulls/1330/commits"},"statuses":{"href":"https://api.github.com/repos/hpcugent/easybuild-framework/statuses/f7d5ed2ce93b5c91a7deee047d6084446cde8423"}}}}