{"action":"closed","issue":{"url":"https://api.github.com/repos/deStrO/eBot-CSGO/issues/44","labels_url":"https://api.github.com/repos/deStrO/eBot-CSGO/issues/44/labels{/name}","comments_url":"https://api.github.com/repos/deStrO/eBot-CSGO/issues/44/comments","events_url":"https://api.github.com/repos/deStrO/eBot-CSGO/issues/44/events","html_url":"https://github.com/deStrO/eBot-CSGO/issues/44","id":90012528,"number":44,"title":"SQL Injection","user":{"login":"adamdecaf","id":120951,"avatar_url":"https://avatars.githubusercontent.com/u/120951?v=3","gravatar_id":"","url":"https://api.github.com/users/adamdecaf","html_url":"https://github.com/adamdecaf","followers_url":"https://api.github.com/users/adamdecaf/followers","following_url":"https://api.github.com/users/adamdecaf/following{/other_user}","gists_url":"https://api.github.com/users/adamdecaf/gists{/gist_id}","starred_url":"https://api.github.com/users/adamdecaf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamdecaf/subscriptions","organizations_url":"https://api.github.com/users/adamdecaf/orgs","repos_url":"https://api.github.com/users/adamdecaf/repos","events_url":"https://api.github.com/users/adamdecaf/events{/privacy}","received_events_url":"https://api.github.com/users/adamdecaf/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-06-22T05:02:13Z","updated_at":"2015-06-22T14:17:53Z","closed_at":"2015-06-22T14:17:53Z","body":"I was reading through the source recently and noticed some scary lines contained in here. Here's [an example](https://github.com/deStrO/eBot-CSGO/blob/threads/src/eBot/Match/Match.php#L132).\r\n\r\n```php\r\n$query = \\mysql_query(\"SELECT * FROM `matchs` WHERE id = '\" . $match_id . \"'\");\r\n```\r\n\r\nThis would be able to be defeated with a `$match_id` such as `'; <insert-bad-sql>;`. Is there something I'm missing with the usage of [mysql_real_escape_string](http://php.net/manual/en/function.mysql-real-escape-string.php) or some other form of sql injection protection? I see it in [only one](https://github.com/deStrO/eBot-CSGO/blob/threads/src/eBot/Match/Player.php#L224) line in the default branch on github."}}