{"action":"created","comment":{"url":"https://api.github.com/repos/akka/akka/pulls/comments/42585325","id":42585325,"diff_hunk":"@@ -121,6 +123,23 @@ class EventsByTagSpec extends AkkaSpec(EventsByTagSpec.config)\n         .expectNext(EventEnvelope(4L, \"c\", 1L, \"a green cucumber\"))\n         .expectComplete()\n     }\n+\n+    \"return empty stream for cleaned journal from 0 to MaxLong\" in {\n+      val a = system.actorOf(TestActor.props(\"a\"))\n+      a ! TestActor.DeleteCmd(Long.MaxValue)\n+      expectMsg(s\"${Long.MaxValue}-deleted\")\n+\n+      val b = system.actorOf(TestActor.props(\"b\"))\n+      b ! TestActor.DeleteCmd(Long.MaxValue)\n+      expectMsg(s\"${Long.MaxValue}-deleted\")\n+\n+      val c = system.actorOf(TestActor.props(\"c\"))\n+      c ! TestActor.DeleteCmd(Long.MaxValue)\n+      expectMsg(s\"${Long.MaxValue}-deleted\")\n+\n+      val src = queries.currentEventsByTag(\"green\", Long.MaxValue)\n+      src.map(_.event).runWith(TestSink.probe[Any]).request(1).expectComplete()","path":"akka-persistence-query/src/test/scala/akka/persistence/query/journal/leveldb/EventsByTagSpec.scala","position":28,"original_position":28,"commit_id":"50bf266215a369595741e636362077ebf70c4b51","original_commit_id":"81c2d176c8784d12b7c5163946236e7c282e078f","user":{"login":"patriknw","id":336161,"avatar_url":"https://avatars.githubusercontent.com/u/336161?v=3","gravatar_id":"","url":"https://api.github.com/users/patriknw","html_url":"https://github.com/patriknw","followers_url":"https://api.github.com/users/patriknw/followers","following_url":"https://api.github.com/users/patriknw/following{/other_user}","gists_url":"https://api.github.com/users/patriknw/gists{/gist_id}","starred_url":"https://api.github.com/users/patriknw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patriknw/subscriptions","organizations_url":"https://api.github.com/users/patriknw/orgs","repos_url":"https://api.github.com/users/patriknw/repos","events_url":"https://api.github.com/users/patriknw/events{/privacy}","received_events_url":"https://api.github.com/users/patriknw/received_events","type":"User","site_admin":false},"body":"note that `Long.MaxValue` is the starting offset, i.e. corresponding to `fromSequenceNr` so this test doesn't really do what the title says.\r\n\r\nTags work differently because events are not deleted from the tag-stream when you do `deleteMessages`. There is currently no support for deleting tagged events.\r\n\r\nAnyway, I suggest that you change the corresponding condition in the same way in `CurrentEventsByTagPublisher`, given that it does not break any other test.","created_at":"2015-10-21T05:49:49Z","updated_at":"2015-10-21T05:49:49Z","html_url":"https://github.com/akka/akka/pull/18698#discussion_r42585325","pull_request_url":"https://api.github.com/repos/akka/akka/pulls/18698","_links":{"self":{"href":"https://api.github.com/repos/akka/akka/pulls/comments/42585325"},"html":{"href":"https://github.com/akka/akka/pull/18698#discussion_r42585325"},"pull_request":{"href":"https://api.github.com/repos/akka/akka/pulls/18698"}}},"pull_request":{"url":"https://api.github.com/repos/akka/akka/pulls/18698","id":47340501,"html_url":"https://github.com/akka/akka/pull/18698","diff_url":"https://github.com/akka/akka/pull/18698.diff","patch_url":"https://github.com/akka/akka/pull/18698.patch","issue_url":"https://api.github.com/repos/akka/akka/issues/18698","number":18698,"state":"open","locked":false,"title":"=per Return empty current events stream for cleaned journal","user":{"login":"eshepelyuk","id":1279477,"avatar_url":"https://avatars.githubusercontent.com/u/1279477?v=3","gravatar_id":"","url":"https://api.github.com/users/eshepelyuk","html_url":"https://github.com/eshepelyuk","followers_url":"https://api.github.com/users/eshepelyuk/followers","following_url":"https://api.github.com/users/eshepelyuk/following{/other_user}","gists_url":"https://api.github.com/users/eshepelyuk/gists{/gist_id}","starred_url":"https://api.github.com/users/eshepelyuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eshepelyuk/subscriptions","organizations_url":"https://api.github.com/users/eshepelyuk/orgs","repos_url":"https://api.github.com/users/eshepelyuk/repos","events_url":"https://api.github.com/users/eshepelyuk/events{/privacy}","received_events_url":"https://api.github.com/users/eshepelyuk/received_events","type":"User","site_admin":false},"body":"This PR fixes the bug when calling `currentEventsByPersistenceId` on LevelDB journal that was completely cleaned just before.","created_at":"2015-10-10T08:07:52Z","updated_at":"2015-10-21T05:49:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"659c4bbc9bfaeaae6748d0c3155af522c3a80731","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/akka/akka/pulls/18698/commits","review_comments_url":"https://api.github.com/repos/akka/akka/pulls/18698/comments","review_comment_url":"https://api.github.com/repos/akka/akka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/akka/akka/issues/18698/comments","statuses_url":"https://api.github.com/repos/akka/akka/statuses/50bf266215a369595741e636362077ebf70c4b51","head":{"label":"eshepelyuk:emptyJournalEvents","ref":"emptyJournalEvents","sha":"50bf266215a369595741e636362077ebf70c4b51","user":{"login":"eshepelyuk","id":1279477,"avatar_url":"https://avatars.githubusercontent.com/u/1279477?v=3","gravatar_id":"","url":"https://api.github.com/users/eshepelyuk","html_url":"https://github.com/eshepelyuk","followers_url":"https://api.github.com/users/eshepelyuk/followers","following_url":"https://api.github.com/users/eshepelyuk/following{/other_user}","gists_url":"https://api.github.com/users/eshepelyuk/gists{/gist_id}","starred_url":"https://api.github.com/users/eshepelyuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eshepelyuk/subscriptions","organizations_url":"https://api.github.com/users/eshepelyuk/orgs","repos_url":"https://api.github.com/users/eshepelyuk/repos","events_url":"https://api.github.com/users/eshepelyuk/events{/privacy}","received_events_url":"https://api.github.com/users/eshepelyuk/received_events","type":"User","site_admin":false},"repo":{"id":43897444,"name":"akka","full_name":"eshepelyuk/akka","owner":{"login":"eshepelyuk","id":1279477,"avatar_url":"https://avatars.githubusercontent.com/u/1279477?v=3","gravatar_id":"","url":"https://api.github.com/users/eshepelyuk","html_url":"https://github.com/eshepelyuk","followers_url":"https://api.github.com/users/eshepelyuk/followers","following_url":"https://api.github.com/users/eshepelyuk/following{/other_user}","gists_url":"https://api.github.com/users/eshepelyuk/gists{/gist_id}","starred_url":"https://api.github.com/users/eshepelyuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eshepelyuk/subscriptions","organizations_url":"https://api.github.com/users/eshepelyuk/orgs","repos_url":"https://api.github.com/users/eshepelyuk/repos","events_url":"https://api.github.com/users/eshepelyuk/events{/privacy}","received_events_url":"https://api.github.com/users/eshepelyuk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eshepelyuk/akka","description":"Akka Project","fork":true,"url":"https://api.github.com/repos/eshepelyuk/akka","forks_url":"https://api.github.com/repos/eshepelyuk/akka/forks","keys_url":"https://api.github.com/repos/eshepelyuk/akka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eshepelyuk/akka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eshepelyuk/akka/teams","hooks_url":"https://api.github.com/repos/eshepelyuk/akka/hooks","issue_events_url":"https://api.github.com/repos/eshepelyuk/akka/issues/events{/number}","events_url":"https://api.github.com/repos/eshepelyuk/akka/events","assignees_url":"https://api.github.com/repos/eshepelyuk/akka/assignees{/user}","branches_url":"https://api.github.com/repos/eshepelyuk/akka/branches{/branch}","tags_url":"https://api.github.com/repos/eshepelyuk/akka/tags","blobs_url":"https://api.github.com/repos/eshepelyuk/akka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eshepelyuk/akka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eshepelyuk/akka/git/refs{/sha}","trees_url":"https://api.github.com/repos/eshepelyuk/akka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eshepelyuk/akka/statuses/{sha}","languages_url":"https://api.github.com/repos/eshepelyuk/akka/languages","stargazers_url":"https://api.github.com/repos/eshepelyuk/akka/stargazers","contributors_url":"https://api.github.com/repos/eshepelyuk/akka/contributors","subscribers_url":"https://api.github.com/repos/eshepelyuk/akka/subscribers","subscription_url":"https://api.github.com/repos/eshepelyuk/akka/subscription","commits_url":"https://api.github.com/repos/eshepelyuk/akka/commits{/sha}","git_commits_url":"https://api.github.com/repos/eshepelyuk/akka/git/commits{/sha}","comments_url":"https://api.github.com/repos/eshepelyuk/akka/comments{/number}","issue_comment_url":"https://api.github.com/repos/eshepelyuk/akka/issues/comments{/number}","contents_url":"https://api.github.com/repos/eshepelyuk/akka/contents/{+path}","compare_url":"https://api.github.com/repos/eshepelyuk/akka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eshepelyuk/akka/merges","archive_url":"https://api.github.com/repos/eshepelyuk/akka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eshepelyuk/akka/downloads","issues_url":"https://api.github.com/repos/eshepelyuk/akka/issues{/number}","pulls_url":"https://api.github.com/repos/eshepelyuk/akka/pulls{/number}","milestones_url":"https://api.github.com/repos/eshepelyuk/akka/milestones{/number}","notifications_url":"https://api.github.com/repos/eshepelyuk/akka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eshepelyuk/akka/labels{/name}","releases_url":"https://api.github.com/repos/eshepelyuk/akka/releases{/id}","created_at":"2015-10-08T15:13:58Z","updated_at":"2015-10-08T15:14:14Z","pushed_at":"2015-10-21T05:46:47Z","git_url":"git://github.com/eshepelyuk/akka.git","ssh_url":"git@github.com:eshepelyuk/akka.git","clone_url":"https://github.com/eshepelyuk/akka.git","svn_url":"https://github.com/eshepelyuk/akka","homepage":"http://akka.io","size":168634,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"akka:master","ref":"master","sha":"ba12c04026df90c58f728a54b27914b4ae7d085e","user":{"login":"akka","id":1496237,"avatar_url":"https://avatars.githubusercontent.com/u/1496237?v=3","gravatar_id":"","url":"https://api.github.com/users/akka","html_url":"https://github.com/akka","followers_url":"https://api.github.com/users/akka/followers","following_url":"https://api.github.com/users/akka/following{/other_user}","gists_url":"https://api.github.com/users/akka/gists{/gist_id}","starred_url":"https://api.github.com/users/akka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akka/subscriptions","organizations_url":"https://api.github.com/users/akka/orgs","repos_url":"https://api.github.com/users/akka/repos","events_url":"https://api.github.com/users/akka/events{/privacy}","received_events_url":"https://api.github.com/users/akka/received_events","type":"Organization","site_admin":false},"repo":{"id":130013,"name":"akka","full_name":"akka/akka","owner":{"login":"akka","id":1496237,"avatar_url":"https://avatars.githubusercontent.com/u/1496237?v=3","gravatar_id":"","url":"https://api.github.com/users/akka","html_url":"https://github.com/akka","followers_url":"https://api.github.com/users/akka/followers","following_url":"https://api.github.com/users/akka/following{/other_user}","gists_url":"https://api.github.com/users/akka/gists{/gist_id}","starred_url":"https://api.github.com/users/akka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akka/subscriptions","organizations_url":"https://api.github.com/users/akka/orgs","repos_url":"https://api.github.com/users/akka/repos","events_url":"https://api.github.com/users/akka/events{/privacy}","received_events_url":"https://api.github.com/users/akka/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/akka/akka","description":"Akka Project","fork":false,"url":"https://api.github.com/repos/akka/akka","forks_url":"https://api.github.com/repos/akka/akka/forks","keys_url":"https://api.github.com/repos/akka/akka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akka/akka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akka/akka/teams","hooks_url":"https://api.github.com/repos/akka/akka/hooks","issue_events_url":"https://api.github.com/repos/akka/akka/issues/events{/number}","events_url":"https://api.github.com/repos/akka/akka/events","assignees_url":"https://api.github.com/repos/akka/akka/assignees{/user}","branches_url":"https://api.github.com/repos/akka/akka/branches{/branch}","tags_url":"https://api.github.com/repos/akka/akka/tags","blobs_url":"https://api.github.com/repos/akka/akka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akka/akka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akka/akka/git/refs{/sha}","trees_url":"https://api.github.com/repos/akka/akka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akka/akka/statuses/{sha}","languages_url":"https://api.github.com/repos/akka/akka/languages","stargazers_url":"https://api.github.com/repos/akka/akka/stargazers","contributors_url":"https://api.github.com/repos/akka/akka/contributors","subscribers_url":"https://api.github.com/repos/akka/akka/subscribers","subscription_url":"https://api.github.com/repos/akka/akka/subscription","commits_url":"https://api.github.com/repos/akka/akka/commits{/sha}","git_commits_url":"https://api.github.com/repos/akka/akka/git/commits{/sha}","comments_url":"https://api.github.com/repos/akka/akka/comments{/number}","issue_comment_url":"https://api.github.com/repos/akka/akka/issues/comments{/number}","contents_url":"https://api.github.com/repos/akka/akka/contents/{+path}","compare_url":"https://api.github.com/repos/akka/akka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akka/akka/merges","archive_url":"https://api.github.com/repos/akka/akka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akka/akka/downloads","issues_url":"https://api.github.com/repos/akka/akka/issues{/number}","pulls_url":"https://api.github.com/repos/akka/akka/pulls{/number}","milestones_url":"https://api.github.com/repos/akka/akka/milestones{/number}","notifications_url":"https://api.github.com/repos/akka/akka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akka/akka/labels{/name}","releases_url":"https://api.github.com/repos/akka/akka/releases{/id}","created_at":"2009-02-16T12:51:54Z","updated_at":"2015-10-21T02:40:09Z","pushed_at":"2015-10-21T05:46:51Z","git_url":"git://github.com/akka/akka.git","ssh_url":"git@github.com:akka/akka.git","clone_url":"https://github.com/akka/akka.git","svn_url":"https://github.com/akka/akka","homepage":"http://akka.io","size":271979,"stargazers_count":4590,"watchers_count":4590,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1365,"mirror_url":null,"open_issues_count":759,"forks":1365,"open_issues":759,"watchers":4590,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/akka/akka/pulls/18698"},"html":{"href":"https://github.com/akka/akka/pull/18698"},"issue":{"href":"https://api.github.com/repos/akka/akka/issues/18698"},"comments":{"href":"https://api.github.com/repos/akka/akka/issues/18698/comments"},"review_comments":{"href":"https://api.github.com/repos/akka/akka/pulls/18698/comments"},"review_comment":{"href":"https://api.github.com/repos/akka/akka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/akka/akka/pulls/18698/commits"},"statuses":{"href":"https://api.github.com/repos/akka/akka/statuses/50bf266215a369595741e636362077ebf70c4b51"}}}}