{"action":"closed","number":1157,"pull_request":{"url":"https://api.github.com/repos/baudehlo/Haraka/pulls/1157","id":44810201,"html_url":"https://github.com/baudehlo/Haraka/pull/1157","diff_url":"https://github.com/baudehlo/Haraka/pull/1157.diff","patch_url":"https://github.com/baudehlo/Haraka/pull/1157.patch","issue_url":"https://api.github.com/repos/baudehlo/Haraka/issues/1157","number":1157,"state":"closed","locked":false,"title":"Improved outbound testability","user":{"login":"hatsebutz","id":4375121,"avatar_url":"https://avatars.githubusercontent.com/u/4375121?v=3","gravatar_id":"","url":"https://api.github.com/users/hatsebutz","html_url":"https://github.com/hatsebutz","followers_url":"https://api.github.com/users/hatsebutz/followers","following_url":"https://api.github.com/users/hatsebutz/following{/other_user}","gists_url":"https://api.github.com/users/hatsebutz/gists{/gist_id}","starred_url":"https://api.github.com/users/hatsebutz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hatsebutz/subscriptions","organizations_url":"https://api.github.com/users/hatsebutz/orgs","repos_url":"https://api.github.com/users/hatsebutz/repos","events_url":"https://api.github.com/users/hatsebutz/events{/privacy}","received_events_url":"https://api.github.com/users/hatsebutz/received_events","type":"User","site_admin":false},"body":"Added a basic outbound test here: Injecting an 5XX in outbound-mail-conversation and asserting that hmail.bounce gets called.\r\nDoes have (small) impact on outbound.js: try_deliver_host was splitted, so it is possible to inject a mocked socket.\r\n\r\nAs I am somewhat new to nodeunit/nodejs comments and feedback is highly appreciated. \r\n\r\nMaybe this basic testing of outbound could be helpful to write tests for #937 too.","created_at":"2015-09-11T17:51:31Z","updated_at":"2015-09-21T21:22:13Z","closed_at":"2015-09-21T21:22:13Z","merged_at":null,"merge_commit_sha":"35a98d379a055320fc6f6e4d8dea61e308806ebd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/baudehlo/Haraka/pulls/1157/commits","review_comments_url":"https://api.github.com/repos/baudehlo/Haraka/pulls/1157/comments","review_comment_url":"https://api.github.com/repos/baudehlo/Haraka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/baudehlo/Haraka/issues/1157/comments","statuses_url":"https://api.github.com/repos/baudehlo/Haraka/statuses/1beec973ed023f80f66813e15928ddba63540070","head":{"label":"hatsebutz:improve_outbound_testability","ref":"improve_outbound_testability","sha":"1beec973ed023f80f66813e15928ddba63540070","user":{"login":"hatsebutz","id":4375121,"avatar_url":"https://avatars.githubusercontent.com/u/4375121?v=3","gravatar_id":"","url":"https://api.github.com/users/hatsebutz","html_url":"https://github.com/hatsebutz","followers_url":"https://api.github.com/users/hatsebutz/followers","following_url":"https://api.github.com/users/hatsebutz/following{/other_user}","gists_url":"https://api.github.com/users/hatsebutz/gists{/gist_id}","starred_url":"https://api.github.com/users/hatsebutz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hatsebutz/subscriptions","organizations_url":"https://api.github.com/users/hatsebutz/orgs","repos_url":"https://api.github.com/users/hatsebutz/repos","events_url":"https://api.github.com/users/hatsebutz/events{/privacy}","received_events_url":"https://api.github.com/users/hatsebutz/received_events","type":"User","site_admin":false},"repo":{"id":40489187,"name":"Haraka","full_name":"hatsebutz/Haraka","owner":{"login":"hatsebutz","id":4375121,"avatar_url":"https://avatars.githubusercontent.com/u/4375121?v=3","gravatar_id":"","url":"https://api.github.com/users/hatsebutz","html_url":"https://github.com/hatsebutz","followers_url":"https://api.github.com/users/hatsebutz/followers","following_url":"https://api.github.com/users/hatsebutz/following{/other_user}","gists_url":"https://api.github.com/users/hatsebutz/gists{/gist_id}","starred_url":"https://api.github.com/users/hatsebutz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hatsebutz/subscriptions","organizations_url":"https://api.github.com/users/hatsebutz/orgs","repos_url":"https://api.github.com/users/hatsebutz/repos","events_url":"https://api.github.com/users/hatsebutz/events{/privacy}","received_events_url":"https://api.github.com/users/hatsebutz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hatsebutz/Haraka","description":"An event driven SMTP server","fork":true,"url":"https://api.github.com/repos/hatsebutz/Haraka","forks_url":"https://api.github.com/repos/hatsebutz/Haraka/forks","keys_url":"https://api.github.com/repos/hatsebutz/Haraka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hatsebutz/Haraka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hatsebutz/Haraka/teams","hooks_url":"https://api.github.com/repos/hatsebutz/Haraka/hooks","issue_events_url":"https://api.github.com/repos/hatsebutz/Haraka/issues/events{/number}","events_url":"https://api.github.com/repos/hatsebutz/Haraka/events","assignees_url":"https://api.github.com/repos/hatsebutz/Haraka/assignees{/user}","branches_url":"https://api.github.com/repos/hatsebutz/Haraka/branches{/branch}","tags_url":"https://api.github.com/repos/hatsebutz/Haraka/tags","blobs_url":"https://api.github.com/repos/hatsebutz/Haraka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hatsebutz/Haraka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hatsebutz/Haraka/git/refs{/sha}","trees_url":"https://api.github.com/repos/hatsebutz/Haraka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hatsebutz/Haraka/statuses/{sha}","languages_url":"https://api.github.com/repos/hatsebutz/Haraka/languages","stargazers_url":"https://api.github.com/repos/hatsebutz/Haraka/stargazers","contributors_url":"https://api.github.com/repos/hatsebutz/Haraka/contributors","subscribers_url":"https://api.github.com/repos/hatsebutz/Haraka/subscribers","subscription_url":"https://api.github.com/repos/hatsebutz/Haraka/subscription","commits_url":"https://api.github.com/repos/hatsebutz/Haraka/commits{/sha}","git_commits_url":"https://api.github.com/repos/hatsebutz/Haraka/git/commits{/sha}","comments_url":"https://api.github.com/repos/hatsebutz/Haraka/comments{/number}","issue_comment_url":"https://api.github.com/repos/hatsebutz/Haraka/issues/comments{/number}","contents_url":"https://api.github.com/repos/hatsebutz/Haraka/contents/{+path}","compare_url":"https://api.github.com/repos/hatsebutz/Haraka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hatsebutz/Haraka/merges","archive_url":"https://api.github.com/repos/hatsebutz/Haraka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hatsebutz/Haraka/downloads","issues_url":"https://api.github.com/repos/hatsebutz/Haraka/issues{/number}","pulls_url":"https://api.github.com/repos/hatsebutz/Haraka/pulls{/number}","milestones_url":"https://api.github.com/repos/hatsebutz/Haraka/milestones{/number}","notifications_url":"https://api.github.com/repos/hatsebutz/Haraka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hatsebutz/Haraka/labels{/name}","releases_url":"https://api.github.com/repos/hatsebutz/Haraka/releases{/id}","created_at":"2015-08-10T15:08:25Z","updated_at":"2015-08-10T15:08:26Z","pushed_at":"2015-09-21T19:55:33Z","git_url":"git://github.com/hatsebutz/Haraka.git","ssh_url":"git@github.com:hatsebutz/Haraka.git","clone_url":"https://github.com/hatsebutz/Haraka.git","svn_url":"https://github.com/hatsebutz/Haraka","homepage":"http://haraka.github.io/","size":3994,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"baudehlo:master","ref":"master","sha":"d6af422ceba08e6eaf0adc37ea69b22e310208b1","user":{"login":"baudehlo","id":662371,"avatar_url":"https://avatars.githubusercontent.com/u/662371?v=3","gravatar_id":"","url":"https://api.github.com/users/baudehlo","html_url":"https://github.com/baudehlo","followers_url":"https://api.github.com/users/baudehlo/followers","following_url":"https://api.github.com/users/baudehlo/following{/other_user}","gists_url":"https://api.github.com/users/baudehlo/gists{/gist_id}","starred_url":"https://api.github.com/users/baudehlo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baudehlo/subscriptions","organizations_url":"https://api.github.com/users/baudehlo/orgs","repos_url":"https://api.github.com/users/baudehlo/repos","events_url":"https://api.github.com/users/baudehlo/events{/privacy}","received_events_url":"https://api.github.com/users/baudehlo/received_events","type":"User","site_admin":false},"repo":{"id":1464380,"name":"Haraka","full_name":"baudehlo/Haraka","owner":{"login":"baudehlo","id":662371,"avatar_url":"https://avatars.githubusercontent.com/u/662371?v=3","gravatar_id":"","url":"https://api.github.com/users/baudehlo","html_url":"https://github.com/baudehlo","followers_url":"https://api.github.com/users/baudehlo/followers","following_url":"https://api.github.com/users/baudehlo/following{/other_user}","gists_url":"https://api.github.com/users/baudehlo/gists{/gist_id}","starred_url":"https://api.github.com/users/baudehlo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baudehlo/subscriptions","organizations_url":"https://api.github.com/users/baudehlo/orgs","repos_url":"https://api.github.com/users/baudehlo/repos","events_url":"https://api.github.com/users/baudehlo/events{/privacy}","received_events_url":"https://api.github.com/users/baudehlo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/baudehlo/Haraka","description":"An event driven SMTP server","fork":false,"url":"https://api.github.com/repos/baudehlo/Haraka","forks_url":"https://api.github.com/repos/baudehlo/Haraka/forks","keys_url":"https://api.github.com/repos/baudehlo/Haraka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/baudehlo/Haraka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/baudehlo/Haraka/teams","hooks_url":"https://api.github.com/repos/baudehlo/Haraka/hooks","issue_events_url":"https://api.github.com/repos/baudehlo/Haraka/issues/events{/number}","events_url":"https://api.github.com/repos/baudehlo/Haraka/events","assignees_url":"https://api.github.com/repos/baudehlo/Haraka/assignees{/user}","branches_url":"https://api.github.com/repos/baudehlo/Haraka/branches{/branch}","tags_url":"https://api.github.com/repos/baudehlo/Haraka/tags","blobs_url":"https://api.github.com/repos/baudehlo/Haraka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/baudehlo/Haraka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/baudehlo/Haraka/git/refs{/sha}","trees_url":"https://api.github.com/repos/baudehlo/Haraka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/baudehlo/Haraka/statuses/{sha}","languages_url":"https://api.github.com/repos/baudehlo/Haraka/languages","stargazers_url":"https://api.github.com/repos/baudehlo/Haraka/stargazers","contributors_url":"https://api.github.com/repos/baudehlo/Haraka/contributors","subscribers_url":"https://api.github.com/repos/baudehlo/Haraka/subscribers","subscription_url":"https://api.github.com/repos/baudehlo/Haraka/subscription","commits_url":"https://api.github.com/repos/baudehlo/Haraka/commits{/sha}","git_commits_url":"https://api.github.com/repos/baudehlo/Haraka/git/commits{/sha}","comments_url":"https://api.github.com/repos/baudehlo/Haraka/comments{/number}","issue_comment_url":"https://api.github.com/repos/baudehlo/Haraka/issues/comments{/number}","contents_url":"https://api.github.com/repos/baudehlo/Haraka/contents/{+path}","compare_url":"https://api.github.com/repos/baudehlo/Haraka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/baudehlo/Haraka/merges","archive_url":"https://api.github.com/repos/baudehlo/Haraka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/baudehlo/Haraka/downloads","issues_url":"https://api.github.com/repos/baudehlo/Haraka/issues{/number}","pulls_url":"https://api.github.com/repos/baudehlo/Haraka/pulls{/number}","milestones_url":"https://api.github.com/repos/baudehlo/Haraka/milestones{/number}","notifications_url":"https://api.github.com/repos/baudehlo/Haraka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/baudehlo/Haraka/labels{/name}","releases_url":"https://api.github.com/repos/baudehlo/Haraka/releases{/id}","created_at":"2011-03-10T17:00:20Z","updated_at":"2015-09-21T04:39:59Z","pushed_at":"2015-09-21T21:22:13Z","git_url":"git://github.com/baudehlo/Haraka.git","ssh_url":"git@github.com:baudehlo/Haraka.git","clone_url":"https://github.com/baudehlo/Haraka.git","svn_url":"https://github.com/baudehlo/Haraka","homepage":"http://haraka.github.io/","size":10992,"stargazers_count":1909,"watchers_count":1909,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":244,"mirror_url":null,"open_issues_count":49,"forks":244,"open_issues":49,"watchers":1909,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/baudehlo/Haraka/pulls/1157"},"html":{"href":"https://github.com/baudehlo/Haraka/pull/1157"},"issue":{"href":"https://api.github.com/repos/baudehlo/Haraka/issues/1157"},"comments":{"href":"https://api.github.com/repos/baudehlo/Haraka/issues/1157/comments"},"review_comments":{"href":"https://api.github.com/repos/baudehlo/Haraka/pulls/1157/comments"},"review_comment":{"href":"https://api.github.com/repos/baudehlo/Haraka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/baudehlo/Haraka/pulls/1157/commits"},"statuses":{"href":"https://api.github.com/repos/baudehlo/Haraka/statuses/1beec973ed023f80f66813e15928ddba63540070"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":3,"review_comments":0,"commits":5,"additions":291,"deletions":0,"changed_files":4}}