{"action":"opened","number":5170,"pull_request":{"url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/5170","id":43061680,"html_url":"https://github.com/DynamoDS/Dynamo/pull/5170","diff_url":"https://github.com/DynamoDS/Dynamo/pull/5170.diff","patch_url":"https://github.com/DynamoDS/Dynamo/pull/5170.patch","issue_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/5170","number":5170,"state":"open","locked":false,"title":"MAGN-8213 Dynamo does not load with any localized Windows","user":{"login":"ikeough","id":1139788,"avatar_url":"https://avatars.githubusercontent.com/u/1139788?v=3","gravatar_id":"","url":"https://api.github.com/users/ikeough","html_url":"https://github.com/ikeough","followers_url":"https://api.github.com/users/ikeough/followers","following_url":"https://api.github.com/users/ikeough/following{/other_user}","gists_url":"https://api.github.com/users/ikeough/gists{/gist_id}","starred_url":"https://api.github.com/users/ikeough/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ikeough/subscriptions","organizations_url":"https://api.github.com/users/ikeough/orgs","repos_url":"https://api.github.com/users/ikeough/repos","events_url":"https://api.github.com/users/ikeough/events{/privacy}","received_events_url":"https://api.github.com/users/ikeough/received_events","type":"User","site_admin":false},"body":"### Purpose\r\n\r\nThis PR fixes [MAGN-8213](http://adsk-oss.myjetbrains.com/youtrack/issue/MAGN-8213) by doing the following:\r\n\r\n- If search weight is an empty string, return an empty list of double.\r\n- Use CultureInfo.InvariantCulture when parsing the search weights.\r\n\r\n### Declarations\r\n\r\nCheck these if you believe they are true\r\n\r\n- [x] The code base is in a better state after this PR\r\n  - We can now run in foreign languages :)\r\n- [x] Is documented according to the [standards](https://github.com/DynamoDS/Dynamo/wiki/Coding-Standards)\r\n  - Expanded documentation has been added.\r\n- [ ] The level of testing this PR includes is appropriate\r\n- [x] User facing strings, if any, are extracted into `*.resx` files\r\n  - No user facing strings.\r\n\r\n### Reviewers\r\n\r\n@pboyer \r\n\r\n### FYIs\r\n\r\n@jnealb ","created_at":"2015-08-21T17:34:05Z","updated_at":"2015-08-21T17:34:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/5170/commits","review_comments_url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/5170/comments","review_comment_url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/5170/comments","statuses_url":"https://api.github.com/repos/DynamoDS/Dynamo/statuses/dcce7a3e639ba5a046deea28c1212a1b4bb86b92","head":{"label":"ikeough:MAGN-8213","ref":"MAGN-8213","sha":"dcce7a3e639ba5a046deea28c1212a1b4bb86b92","user":{"login":"ikeough","id":1139788,"avatar_url":"https://avatars.githubusercontent.com/u/1139788?v=3","gravatar_id":"","url":"https://api.github.com/users/ikeough","html_url":"https://github.com/ikeough","followers_url":"https://api.github.com/users/ikeough/followers","following_url":"https://api.github.com/users/ikeough/following{/other_user}","gists_url":"https://api.github.com/users/ikeough/gists{/gist_id}","starred_url":"https://api.github.com/users/ikeough/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ikeough/subscriptions","organizations_url":"https://api.github.com/users/ikeough/orgs","repos_url":"https://api.github.com/users/ikeough/repos","events_url":"https://api.github.com/users/ikeough/events{/privacy}","received_events_url":"https://api.github.com/users/ikeough/received_events","type":"User","site_admin":false},"repo":{"id":37068216,"name":"Dynamo","full_name":"ikeough/Dynamo","owner":{"login":"ikeough","id":1139788,"avatar_url":"https://avatars.githubusercontent.com/u/1139788?v=3","gravatar_id":"","url":"https://api.github.com/users/ikeough","html_url":"https://github.com/ikeough","followers_url":"https://api.github.com/users/ikeough/followers","following_url":"https://api.github.com/users/ikeough/following{/other_user}","gists_url":"https://api.github.com/users/ikeough/gists{/gist_id}","starred_url":"https://api.github.com/users/ikeough/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ikeough/subscriptions","organizations_url":"https://api.github.com/users/ikeough/orgs","repos_url":"https://api.github.com/users/ikeough/repos","events_url":"https://api.github.com/users/ikeough/events{/privacy}","received_events_url":"https://api.github.com/users/ikeough/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ikeough/Dynamo","description":"Visual Programming","fork":true,"url":"https://api.github.com/repos/ikeough/Dynamo","forks_url":"https://api.github.com/repos/ikeough/Dynamo/forks","keys_url":"https://api.github.com/repos/ikeough/Dynamo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ikeough/Dynamo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ikeough/Dynamo/teams","hooks_url":"https://api.github.com/repos/ikeough/Dynamo/hooks","issue_events_url":"https://api.github.com/repos/ikeough/Dynamo/issues/events{/number}","events_url":"https://api.github.com/repos/ikeough/Dynamo/events","assignees_url":"https://api.github.com/repos/ikeough/Dynamo/assignees{/user}","branches_url":"https://api.github.com/repos/ikeough/Dynamo/branches{/branch}","tags_url":"https://api.github.com/repos/ikeough/Dynamo/tags","blobs_url":"https://api.github.com/repos/ikeough/Dynamo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ikeough/Dynamo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ikeough/Dynamo/git/refs{/sha}","trees_url":"https://api.github.com/repos/ikeough/Dynamo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ikeough/Dynamo/statuses/{sha}","languages_url":"https://api.github.com/repos/ikeough/Dynamo/languages","stargazers_url":"https://api.github.com/repos/ikeough/Dynamo/stargazers","contributors_url":"https://api.github.com/repos/ikeough/Dynamo/contributors","subscribers_url":"https://api.github.com/repos/ikeough/Dynamo/subscribers","subscription_url":"https://api.github.com/repos/ikeough/Dynamo/subscription","commits_url":"https://api.github.com/repos/ikeough/Dynamo/commits{/sha}","git_commits_url":"https://api.github.com/repos/ikeough/Dynamo/git/commits{/sha}","comments_url":"https://api.github.com/repos/ikeough/Dynamo/comments{/number}","issue_comment_url":"https://api.github.com/repos/ikeough/Dynamo/issues/comments{/number}","contents_url":"https://api.github.com/repos/ikeough/Dynamo/contents/{+path}","compare_url":"https://api.github.com/repos/ikeough/Dynamo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ikeough/Dynamo/merges","archive_url":"https://api.github.com/repos/ikeough/Dynamo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ikeough/Dynamo/downloads","issues_url":"https://api.github.com/repos/ikeough/Dynamo/issues{/number}","pulls_url":"https://api.github.com/repos/ikeough/Dynamo/pulls{/number}","milestones_url":"https://api.github.com/repos/ikeough/Dynamo/milestones{/number}","notifications_url":"https://api.github.com/repos/ikeough/Dynamo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ikeough/Dynamo/labels{/name}","releases_url":"https://api.github.com/repos/ikeough/Dynamo/releases{/id}","created_at":"2015-06-08T13:21:59Z","updated_at":"2015-08-04T20:52:36Z","pushed_at":"2015-08-21T17:33:15Z","git_url":"git://github.com/ikeough/Dynamo.git","ssh_url":"git@github.com:ikeough/Dynamo.git","clone_url":"https://github.com/ikeough/Dynamo.git","svn_url":"https://github.com/ikeough/Dynamo","homepage":"http://dynamobim.org","size":796970,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"DynamoDS:master","ref":"master","sha":"dee6a36b26ca0597225452182d495b5757491782","user":{"login":"DynamoDS","id":6528209,"avatar_url":"https://avatars.githubusercontent.com/u/6528209?v=3","gravatar_id":"","url":"https://api.github.com/users/DynamoDS","html_url":"https://github.com/DynamoDS","followers_url":"https://api.github.com/users/DynamoDS/followers","following_url":"https://api.github.com/users/DynamoDS/following{/other_user}","gists_url":"https://api.github.com/users/DynamoDS/gists{/gist_id}","starred_url":"https://api.github.com/users/DynamoDS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DynamoDS/subscriptions","organizations_url":"https://api.github.com/users/DynamoDS/orgs","repos_url":"https://api.github.com/users/DynamoDS/repos","events_url":"https://api.github.com/users/DynamoDS/events{/privacy}","received_events_url":"https://api.github.com/users/DynamoDS/received_events","type":"Organization","site_admin":false},"repo":{"id":3395179,"name":"Dynamo","full_name":"DynamoDS/Dynamo","owner":{"login":"DynamoDS","id":6528209,"avatar_url":"https://avatars.githubusercontent.com/u/6528209?v=3","gravatar_id":"","url":"https://api.github.com/users/DynamoDS","html_url":"https://github.com/DynamoDS","followers_url":"https://api.github.com/users/DynamoDS/followers","following_url":"https://api.github.com/users/DynamoDS/following{/other_user}","gists_url":"https://api.github.com/users/DynamoDS/gists{/gist_id}","starred_url":"https://api.github.com/users/DynamoDS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DynamoDS/subscriptions","organizations_url":"https://api.github.com/users/DynamoDS/orgs","repos_url":"https://api.github.com/users/DynamoDS/repos","events_url":"https://api.github.com/users/DynamoDS/events{/privacy}","received_events_url":"https://api.github.com/users/DynamoDS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DynamoDS/Dynamo","description":"Visual Programming","fork":false,"url":"https://api.github.com/repos/DynamoDS/Dynamo","forks_url":"https://api.github.com/repos/DynamoDS/Dynamo/forks","keys_url":"https://api.github.com/repos/DynamoDS/Dynamo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DynamoDS/Dynamo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DynamoDS/Dynamo/teams","hooks_url":"https://api.github.com/repos/DynamoDS/Dynamo/hooks","issue_events_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/events{/number}","events_url":"https://api.github.com/repos/DynamoDS/Dynamo/events","assignees_url":"https://api.github.com/repos/DynamoDS/Dynamo/assignees{/user}","branches_url":"https://api.github.com/repos/DynamoDS/Dynamo/branches{/branch}","tags_url":"https://api.github.com/repos/DynamoDS/Dynamo/tags","blobs_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/refs{/sha}","trees_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DynamoDS/Dynamo/statuses/{sha}","languages_url":"https://api.github.com/repos/DynamoDS/Dynamo/languages","stargazers_url":"https://api.github.com/repos/DynamoDS/Dynamo/stargazers","contributors_url":"https://api.github.com/repos/DynamoDS/Dynamo/contributors","subscribers_url":"https://api.github.com/repos/DynamoDS/Dynamo/subscribers","subscription_url":"https://api.github.com/repos/DynamoDS/Dynamo/subscription","commits_url":"https://api.github.com/repos/DynamoDS/Dynamo/commits{/sha}","git_commits_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/commits{/sha}","comments_url":"https://api.github.com/repos/DynamoDS/Dynamo/comments{/number}","issue_comment_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/comments{/number}","contents_url":"https://api.github.com/repos/DynamoDS/Dynamo/contents/{+path}","compare_url":"https://api.github.com/repos/DynamoDS/Dynamo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DynamoDS/Dynamo/merges","archive_url":"https://api.github.com/repos/DynamoDS/Dynamo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DynamoDS/Dynamo/downloads","issues_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues{/number}","pulls_url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls{/number}","milestones_url":"https://api.github.com/repos/DynamoDS/Dynamo/milestones{/number}","notifications_url":"https://api.github.com/repos/DynamoDS/Dynamo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DynamoDS/Dynamo/labels{/name}","releases_url":"https://api.github.com/repos/DynamoDS/Dynamo/releases{/id}","created_at":"2012-02-09T07:35:33Z","updated_at":"2015-08-20T14:18:56Z","pushed_at":"2015-08-21T17:33:47Z","git_url":"git://github.com/DynamoDS/Dynamo.git","ssh_url":"git@github.com:DynamoDS/Dynamo.git","clone_url":"https://github.com/DynamoDS/Dynamo.git","svn_url":"https://github.com/DynamoDS/Dynamo","homepage":"http://dynamobim.org","size":1022818,"stargazers_count":251,"watchers_count":251,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":192,"mirror_url":null,"open_issues_count":723,"forks":192,"open_issues":723,"watchers":251,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/5170"},"html":{"href":"https://github.com/DynamoDS/Dynamo/pull/5170"},"issue":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/issues/5170"},"comments":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/issues/5170/comments"},"review_comments":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/5170/comments"},"review_comment":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/5170/commits"},"statuses":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/statuses/dcce7a3e639ba5a046deea28c1212a1b4bb86b92"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":46,"deletions":9,"changed_files":2}}