{"action":"created","issue":{"url":"https://api.github.com/repos/xbmc/xbmc/issues/7571","labels_url":"https://api.github.com/repos/xbmc/xbmc/issues/7571/labels{/name}","comments_url":"https://api.github.com/repos/xbmc/xbmc/issues/7571/comments","events_url":"https://api.github.com/repos/xbmc/xbmc/issues/7571/events","html_url":"https://github.com/xbmc/xbmc/pull/7571","id":96273450,"number":7571,"title":"[guilib] fix modality handling of dialog slider (fixes #16140)","user":{"login":"xhaggi","id":1878991,"avatar_url":"https://avatars.githubusercontent.com/u/1878991?v=3","gravatar_id":"","url":"https://api.github.com/users/xhaggi","html_url":"https://github.com/xhaggi","followers_url":"https://api.github.com/users/xhaggi/followers","following_url":"https://api.github.com/users/xhaggi/following{/other_user}","gists_url":"https://api.github.com/users/xhaggi/gists{/gist_id}","starred_url":"https://api.github.com/users/xhaggi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xhaggi/subscriptions","organizations_url":"https://api.github.com/users/xhaggi/orgs","repos_url":"https://api.github.com/users/xhaggi/repos","events_url":"https://api.github.com/users/xhaggi/events{/privacy}","received_events_url":"https://api.github.com/users/xhaggi/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/xbmc/xbmc/labels/Fix","name":"Fix","color":"02e10c"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-07-21T09:41:08Z","updated_at":"2015-07-21T14:01:38Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/7571","html_url":"https://github.com/xbmc/xbmc/pull/7571","diff_url":"https://github.com/xbmc/xbmc/pull/7571.diff","patch_url":"https://github.com/xbmc/xbmc/pull/7571.patch"},"body":"As reported at http://trac.kodi.tv/ticket/16140 the slider dialog does not work if it's used as overlay. This happens because we only support one modality type per dialog and the slider dialog is the only one which breaks this rule and is used as modal and overlay at the same time. \r\n\r\nThis PR will fix the issue by setting the modality type at runtime depending on the use-case.\r\n\r\n@uNiversaI it would be nice if you could confirm that it works\r\n@mkortstiege mind taking a look"},"comment":{"url":"https://api.github.com/repos/xbmc/xbmc/issues/comments/123318351","html_url":"https://github.com/xbmc/xbmc/pull/7571#issuecomment-123318351","issue_url":"https://api.github.com/repos/xbmc/xbmc/issues/7571","id":123318351,"user":{"login":"xhaggi","id":1878991,"avatar_url":"https://avatars.githubusercontent.com/u/1878991?v=3","gravatar_id":"","url":"https://api.github.com/users/xhaggi","html_url":"https://github.com/xhaggi","followers_url":"https://api.github.com/users/xhaggi/followers","following_url":"https://api.github.com/users/xhaggi/following{/other_user}","gists_url":"https://api.github.com/users/xhaggi/gists{/gist_id}","starred_url":"https://api.github.com/users/xhaggi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xhaggi/subscriptions","organizations_url":"https://api.github.com/users/xhaggi/orgs","repos_url":"https://api.github.com/users/xhaggi/repos","events_url":"https://api.github.com/users/xhaggi/events{/privacy}","received_events_url":"https://api.github.com/users/xhaggi/received_events","type":"User","site_admin":false},"created_at":"2015-07-21T14:01:38Z","updated_at":"2015-07-21T14:01:38Z","body":"@uNiversaI i've updated the PR, please do another test, thanks."}}