{"action":"created","issue":{"url":"https://api.github.com/repos/d-ronin/dRonin/issues/180","labels_url":"https://api.github.com/repos/d-ronin/dRonin/issues/180/labels{/name}","comments_url":"https://api.github.com/repos/d-ronin/dRonin/issues/180/comments","events_url":"https://api.github.com/repos/d-ronin/dRonin/issues/180/events","html_url":"https://github.com/d-ronin/dRonin/pull/180","id":120761507,"number":180,"title":"Logging Module Improvements V3","user":{"login":"mluessi","id":647005,"avatar_url":"https://avatars.githubusercontent.com/u/647005?v=3","gravatar_id":"","url":"https://api.github.com/users/mluessi","html_url":"https://github.com/mluessi","followers_url":"https://api.github.com/users/mluessi/followers","following_url":"https://api.github.com/users/mluessi/following{/other_user}","gists_url":"https://api.github.com/users/mluessi/gists{/gist_id}","starred_url":"https://api.github.com/users/mluessi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mluessi/subscriptions","organizations_url":"https://api.github.com/users/mluessi/orgs","repos_url":"https://api.github.com/users/mluessi/repos","events_url":"https://api.github.com/users/mluessi/events{/privacy}","received_events_url":"https://api.github.com/users/mluessi/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/d-ronin/dRonin/labels/enhancement","name":"enhancement","color":"84b6eb"},{"url":"https://api.github.com/repos/d-ronin/dRonin/labels/flight","name":"flight","color":"fbca04"},{"url":"https://api.github.com/repos/d-ronin/dRonin/labels/status/ready-for-review","name":"status/ready-for-review","color":"bfe5bf"},{"url":"https://api.github.com/repos/d-ronin/dRonin/labels/status/requires-test","name":"status/requires-test","color":"207de5"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":12,"created_at":"2015-12-07T12:13:39Z","updated_at":"2015-12-08T02:08:14Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/d-ronin/dRonin/pulls/180","html_url":"https://github.com/d-ronin/dRonin/pull/180","diff_url":"https://github.com/d-ronin/dRonin/pull/180.diff","patch_url":"https://github.com/d-ronin/dRonin/pull/180.patch"},"body":"This is an improved version of https://github.com/TauLabs/TauLabs/pull/2031 Improvements:\r\n\r\n- Configurable max logging frequency\r\n- Logging profiles: The Default profile will just log a small subset of UAVOs (as we did previously) and the Custom profile will use the per UAVO logging period. This is useful for development to e.g. log a few UAVOs with high rates. If we add a nice way to the GCS to configure the rates, we can remove the profiles in the future.\r\n- Modified the UAVO manager so that deregistering callbacks doesn't leak memory, i.e., the same memory can be reused for new callbacks\r\n\r\nThis WIP and has not yet been tested..\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/d-ronin/dronin/180)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/d-ronin/dRonin/issues/comments/162735921","html_url":"https://github.com/d-ronin/dRonin/pull/180#issuecomment-162735921","issue_url":"https://api.github.com/repos/d-ronin/dRonin/issues/180","id":162735921,"user":{"login":"droidicus","id":6981482,"avatar_url":"https://avatars.githubusercontent.com/u/6981482?v=3","gravatar_id":"","url":"https://api.github.com/users/droidicus","html_url":"https://github.com/droidicus","followers_url":"https://api.github.com/users/droidicus/followers","following_url":"https://api.github.com/users/droidicus/following{/other_user}","gists_url":"https://api.github.com/users/droidicus/gists{/gist_id}","starred_url":"https://api.github.com/users/droidicus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/droidicus/subscriptions","organizations_url":"https://api.github.com/users/droidicus/orgs","repos_url":"https://api.github.com/users/droidicus/repos","events_url":"https://api.github.com/users/droidicus/events{/privacy}","received_events_url":"https://api.github.com/users/droidicus/received_events","type":"User","site_admin":false},"created_at":"2015-12-08T02:08:14Z","updated_at":"2015-12-08T02:08:14Z","body":"Logs are being saved in Windows as \"dRonin-2015-12-07_21-00-46.drlog.tll\""}}