{"action":"created","issue":{"url":"https://api.github.com/repos/gnuradio/gnuradio/issues/574","labels_url":"https://api.github.com/repos/gnuradio/gnuradio/issues/574/labels{/name}","comments_url":"https://api.github.com/repos/gnuradio/gnuradio/issues/574/comments","events_url":"https://api.github.com/repos/gnuradio/gnuradio/issues/574/events","html_url":"https://github.com/gnuradio/gnuradio/pull/574","id":95645590,"number":574,"title":"fec block 'ber_bf' needs refactoring","user":{"login":"jdemel","id":2794611,"avatar_url":"https://avatars.githubusercontent.com/u/2794611?v=3","gravatar_id":"","url":"https://api.github.com/users/jdemel","html_url":"https://github.com/jdemel","followers_url":"https://api.github.com/users/jdemel/followers","following_url":"https://api.github.com/users/jdemel/following{/other_user}","gists_url":"https://api.github.com/users/jdemel/gists{/gist_id}","starred_url":"https://api.github.com/users/jdemel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdemel/subscriptions","organizations_url":"https://api.github.com/users/jdemel/orgs","repos_url":"https://api.github.com/users/jdemel/repos","events_url":"https://api.github.com/users/jdemel/events{/privacy}","received_events_url":"https://api.github.com/users/jdemel/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/gnuradio/gnuradio/labels/hold","name":"hold","color":"fbca04"},{"url":"https://api.github.com/repos/gnuradio/gnuradio/labels/master","name":"master","color":"5319e7"}],"state":"open","locked":false,"assignee":{"login":"trondeau","id":405014,"avatar_url":"https://avatars.githubusercontent.com/u/405014?v=3","gravatar_id":"","url":"https://api.github.com/users/trondeau","html_url":"https://github.com/trondeau","followers_url":"https://api.github.com/users/trondeau/followers","following_url":"https://api.github.com/users/trondeau/following{/other_user}","gists_url":"https://api.github.com/users/trondeau/gists{/gist_id}","starred_url":"https://api.github.com/users/trondeau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trondeau/subscriptions","organizations_url":"https://api.github.com/users/trondeau/orgs","repos_url":"https://api.github.com/users/trondeau/repos","events_url":"https://api.github.com/users/trondeau/events{/privacy}","received_events_url":"https://api.github.com/users/trondeau/received_events","type":"User","site_admin":false},"milestone":null,"comments":2,"created_at":"2015-07-17T12:15:20Z","updated_at":"2015-07-20T09:39:02Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/gnuradio/gnuradio/pulls/574","html_url":"https://github.com/gnuradio/gnuradio/pull/574","diff_url":"https://github.com/gnuradio/gnuradio/pull/574.diff","patch_url":"https://github.com/gnuradio/gnuradio/pull/574.patch"},"body":"This block has a test mode. In work this gets split in 2 large if-statements. They contain a lot of duplicate code. I moved some code out of the if-statement. All the other code is almost duplicate, but It has subtle differences when calling consume_each. This should be fixed, though.\r\nI issued this pull request in order to open a debate over this."},"comment":{"url":"https://api.github.com/repos/gnuradio/gnuradio/issues/comments/122826663","html_url":"https://github.com/gnuradio/gnuradio/pull/574#issuecomment-122826663","issue_url":"https://api.github.com/repos/gnuradio/gnuradio/issues/574","id":122826663,"user":{"login":"jdemel","id":2794611,"avatar_url":"https://avatars.githubusercontent.com/u/2794611?v=3","gravatar_id":"","url":"https://api.github.com/users/jdemel","html_url":"https://github.com/jdemel","followers_url":"https://api.github.com/users/jdemel/followers","following_url":"https://api.github.com/users/jdemel/following{/other_user}","gists_url":"https://api.github.com/users/jdemel/gists{/gist_id}","starred_url":"https://api.github.com/users/jdemel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdemel/subscriptions","organizations_url":"https://api.github.com/users/jdemel/orgs","repos_url":"https://api.github.com/users/jdemel/repos","events_url":"https://api.github.com/users/jdemel/events{/privacy}","received_events_url":"https://api.github.com/users/jdemel/received_events","type":"User","site_admin":false},"created_at":"2015-07-20T09:39:02Z","updated_at":"2015-07-20T09:39:02Z","body":"I went through this again. Created 2 new methods which sum up a lot of common functionality for the 2 modes. 'general_work' should be readable on one page now.\r\nAlso, I added a new test case which makes sure bit error calculation is done correctly in case more than one consecutive byte is affected."}}