{"action":"created","comment":{"url":"https://api.github.com/repos/ARMmbed/uvisor/pulls/comments/43504255","id":43504255,"diff_hunk":"@@ -317,6 +326,9 @@ int vmpu_fault_recovery_bus(uint32_t pc, uint32_t sp)\n     /* note: we assume the instruction is 16 bits wide and skip possible NOPs */\n     vmpu_unpriv_uint32_write(sp + (6 << 2), pc + ((UVISOR_NOP_CNT + 2 - cnt) << 1));\n \n+    /* clear BFSR only - reset BFARVALID bit to acknowledge fault */\n+    SCB_BFSR = 0x80;","path":"core/system/src/mpu/vmpu.c","position":37,"original_position":37,"commit_id":"466dc572f493b0aaea089e71a6b3af0e9e65d87d","original_commit_id":"466dc572f493b0aaea089e71a6b3af0e9e65d87d","user":{"login":"meriac","id":408576,"avatar_url":"https://avatars.githubusercontent.com/u/408576?v=3","gravatar_id":"","url":"https://api.github.com/users/meriac","html_url":"https://github.com/meriac","followers_url":"https://api.github.com/users/meriac/followers","following_url":"https://api.github.com/users/meriac/following{/other_user}","gists_url":"https://api.github.com/users/meriac/gists{/gist_id}","starred_url":"https://api.github.com/users/meriac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meriac/subscriptions","organizations_url":"https://api.github.com/users/meriac/orgs","repos_url":"https://api.github.com/users/meriac/repos","events_url":"https://api.github.com/users/meriac/events{/privacy}","received_events_url":"https://api.github.com/users/meriac/received_events","type":"User","site_admin":false},"body":"SCB_BFSR needs to be cleared even in case the function returns - we might want to consider in this function to clear it right after checking it at the top.","created_at":"2015-10-30T14:00:25Z","updated_at":"2015-10-30T14:00:25Z","html_url":"https://github.com/ARMmbed/uvisor/pull/97#discussion_r43504255","pull_request_url":"https://api.github.com/repos/ARMmbed/uvisor/pulls/97","_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/uvisor/pulls/comments/43504255"},"html":{"href":"https://github.com/ARMmbed/uvisor/pull/97#discussion_r43504255"},"pull_request":{"href":"https://api.github.com/repos/ARMmbed/uvisor/pulls/97"}}},"pull_request":{"url":"https://api.github.com/repos/ARMmbed/uvisor/pulls/97","id":49167348,"html_url":"https://github.com/ARMmbed/uvisor/pull/97","diff_url":"https://github.com/ARMmbed/uvisor/pull/97.diff","patch_url":"https://github.com/ARMmbed/uvisor/pull/97.patch","issue_url":"https://api.github.com/repos/ARMmbed/uvisor/issues/97","number":97,"state":"open","locked":false,"title":"Fixed bug for bus fault acknowledgment","user":{"login":"AlessandroA","id":8617445,"avatar_url":"https://avatars.githubusercontent.com/u/8617445?v=3","gravatar_id":"","url":"https://api.github.com/users/AlessandroA","html_url":"https://github.com/AlessandroA","followers_url":"https://api.github.com/users/AlessandroA/followers","following_url":"https://api.github.com/users/AlessandroA/following{/other_user}","gists_url":"https://api.github.com/users/AlessandroA/gists{/gist_id}","starred_url":"https://api.github.com/users/AlessandroA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlessandroA/subscriptions","organizations_url":"https://api.github.com/users/AlessandroA/orgs","repos_url":"https://api.github.com/users/AlessandroA/repos","events_url":"https://api.github.com/users/AlessandroA/events{/privacy}","received_events_url":"https://api.github.com/users/AlessandroA/received_events","type":"User","site_admin":false},"body":"Acknowledging the bus fault it is possible to recover from it and be ready for a new one in the future -- otherwise the syndrome register retains the old value.\r\n\r\nFixes https://github.com/ARMmbed/uvisor/issues/96\r\n@meriac ","created_at":"2015-10-29T16:49:43Z","updated_at":"2015-10-30T14:00:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dbbe0c368d0e6d70c62972cec01cf18ad03313df","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ARMmbed/uvisor/pulls/97/commits","review_comments_url":"https://api.github.com/repos/ARMmbed/uvisor/pulls/97/comments","review_comment_url":"https://api.github.com/repos/ARMmbed/uvisor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ARMmbed/uvisor/issues/97/comments","statuses_url":"https://api.github.com/repos/ARMmbed/uvisor/statuses/466dc572f493b0aaea089e71a6b3af0e9e65d87d","head":{"label":"ARMmbed:fix_bbfar_ack","ref":"fix_bbfar_ack","sha":"466dc572f493b0aaea089e71a6b3af0e9e65d87d","user":{"login":"ARMmbed","id":8916057,"avatar_url":"https://avatars.githubusercontent.com/u/8916057?v=3","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"repo":{"id":27869517,"name":"uvisor","full_name":"ARMmbed/uvisor","owner":{"login":"ARMmbed","id":8916057,"avatar_url":"https://avatars.githubusercontent.com/u/8916057?v=3","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ARMmbed/uvisor","description":"mbed OS uVisor -- device security layer for ARMv7M microcontrollers","fork":false,"url":"https://api.github.com/repos/ARMmbed/uvisor","forks_url":"https://api.github.com/repos/ARMmbed/uvisor/forks","keys_url":"https://api.github.com/repos/ARMmbed/uvisor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ARMmbed/uvisor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ARMmbed/uvisor/teams","hooks_url":"https://api.github.com/repos/ARMmbed/uvisor/hooks","issue_events_url":"https://api.github.com/repos/ARMmbed/uvisor/issues/events{/number}","events_url":"https://api.github.com/repos/ARMmbed/uvisor/events","assignees_url":"https://api.github.com/repos/ARMmbed/uvisor/assignees{/user}","branches_url":"https://api.github.com/repos/ARMmbed/uvisor/branches{/branch}","tags_url":"https://api.github.com/repos/ARMmbed/uvisor/tags","blobs_url":"https://api.github.com/repos/ARMmbed/uvisor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ARMmbed/uvisor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ARMmbed/uvisor/git/refs{/sha}","trees_url":"https://api.github.com/repos/ARMmbed/uvisor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ARMmbed/uvisor/statuses/{sha}","languages_url":"https://api.github.com/repos/ARMmbed/uvisor/languages","stargazers_url":"https://api.github.com/repos/ARMmbed/uvisor/stargazers","contributors_url":"https://api.github.com/repos/ARMmbed/uvisor/contributors","subscribers_url":"https://api.github.com/repos/ARMmbed/uvisor/subscribers","subscription_url":"https://api.github.com/repos/ARMmbed/uvisor/subscription","commits_url":"https://api.github.com/repos/ARMmbed/uvisor/commits{/sha}","git_commits_url":"https://api.github.com/repos/ARMmbed/uvisor/git/commits{/sha}","comments_url":"https://api.github.com/repos/ARMmbed/uvisor/comments{/number}","issue_comment_url":"https://api.github.com/repos/ARMmbed/uvisor/issues/comments{/number}","contents_url":"https://api.github.com/repos/ARMmbed/uvisor/contents/{+path}","compare_url":"https://api.github.com/repos/ARMmbed/uvisor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ARMmbed/uvisor/merges","archive_url":"https://api.github.com/repos/ARMmbed/uvisor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ARMmbed/uvisor/downloads","issues_url":"https://api.github.com/repos/ARMmbed/uvisor/issues{/number}","pulls_url":"https://api.github.com/repos/ARMmbed/uvisor/pulls{/number}","milestones_url":"https://api.github.com/repos/ARMmbed/uvisor/milestones{/number}","notifications_url":"https://api.github.com/repos/ARMmbed/uvisor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ARMmbed/uvisor/labels{/name}","releases_url":"https://api.github.com/repos/ARMmbed/uvisor/releases{/id}","created_at":"2014-12-11T11:59:50Z","updated_at":"2015-10-30T00:28:46Z","pushed_at":"2015-10-30T13:38:20Z","git_url":"git://github.com/ARMmbed/uvisor.git","ssh_url":"git@github.com:ARMmbed/uvisor.git","clone_url":"https://github.com/ARMmbed/uvisor.git","svn_url":"https://github.com/ARMmbed/uvisor","homepage":"","size":5049,"stargazers_count":23,"watchers_count":23,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":19,"forks":10,"open_issues":19,"watchers":23,"default_branch":"master"}},"base":{"label":"ARMmbed:master","ref":"master","sha":"c4f05c28ffd9b56a77dc18509b344525b02a24de","user":{"login":"ARMmbed","id":8916057,"avatar_url":"https://avatars.githubusercontent.com/u/8916057?v=3","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"repo":{"id":27869517,"name":"uvisor","full_name":"ARMmbed/uvisor","owner":{"login":"ARMmbed","id":8916057,"avatar_url":"https://avatars.githubusercontent.com/u/8916057?v=3","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ARMmbed/uvisor","description":"mbed OS uVisor -- device security layer for ARMv7M microcontrollers","fork":false,"url":"https://api.github.com/repos/ARMmbed/uvisor","forks_url":"https://api.github.com/repos/ARMmbed/uvisor/forks","keys_url":"https://api.github.com/repos/ARMmbed/uvisor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ARMmbed/uvisor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ARMmbed/uvisor/teams","hooks_url":"https://api.github.com/repos/ARMmbed/uvisor/hooks","issue_events_url":"https://api.github.com/repos/ARMmbed/uvisor/issues/events{/number}","events_url":"https://api.github.com/repos/ARMmbed/uvisor/events","assignees_url":"https://api.github.com/repos/ARMmbed/uvisor/assignees{/user}","branches_url":"https://api.github.com/repos/ARMmbed/uvisor/branches{/branch}","tags_url":"https://api.github.com/repos/ARMmbed/uvisor/tags","blobs_url":"https://api.github.com/repos/ARMmbed/uvisor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ARMmbed/uvisor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ARMmbed/uvisor/git/refs{/sha}","trees_url":"https://api.github.com/repos/ARMmbed/uvisor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ARMmbed/uvisor/statuses/{sha}","languages_url":"https://api.github.com/repos/ARMmbed/uvisor/languages","stargazers_url":"https://api.github.com/repos/ARMmbed/uvisor/stargazers","contributors_url":"https://api.github.com/repos/ARMmbed/uvisor/contributors","subscribers_url":"https://api.github.com/repos/ARMmbed/uvisor/subscribers","subscription_url":"https://api.github.com/repos/ARMmbed/uvisor/subscription","commits_url":"https://api.github.com/repos/ARMmbed/uvisor/commits{/sha}","git_commits_url":"https://api.github.com/repos/ARMmbed/uvisor/git/commits{/sha}","comments_url":"https://api.github.com/repos/ARMmbed/uvisor/comments{/number}","issue_comment_url":"https://api.github.com/repos/ARMmbed/uvisor/issues/comments{/number}","contents_url":"https://api.github.com/repos/ARMmbed/uvisor/contents/{+path}","compare_url":"https://api.github.com/repos/ARMmbed/uvisor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ARMmbed/uvisor/merges","archive_url":"https://api.github.com/repos/ARMmbed/uvisor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ARMmbed/uvisor/downloads","issues_url":"https://api.github.com/repos/ARMmbed/uvisor/issues{/number}","pulls_url":"https://api.github.com/repos/ARMmbed/uvisor/pulls{/number}","milestones_url":"https://api.github.com/repos/ARMmbed/uvisor/milestones{/number}","notifications_url":"https://api.github.com/repos/ARMmbed/uvisor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ARMmbed/uvisor/labels{/name}","releases_url":"https://api.github.com/repos/ARMmbed/uvisor/releases{/id}","created_at":"2014-12-11T11:59:50Z","updated_at":"2015-10-30T00:28:46Z","pushed_at":"2015-10-30T13:38:20Z","git_url":"git://github.com/ARMmbed/uvisor.git","ssh_url":"git@github.com:ARMmbed/uvisor.git","clone_url":"https://github.com/ARMmbed/uvisor.git","svn_url":"https://github.com/ARMmbed/uvisor","homepage":"","size":5049,"stargazers_count":23,"watchers_count":23,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":19,"forks":10,"open_issues":19,"watchers":23,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/uvisor/pulls/97"},"html":{"href":"https://github.com/ARMmbed/uvisor/pull/97"},"issue":{"href":"https://api.github.com/repos/ARMmbed/uvisor/issues/97"},"comments":{"href":"https://api.github.com/repos/ARMmbed/uvisor/issues/97/comments"},"review_comments":{"href":"https://api.github.com/repos/ARMmbed/uvisor/pulls/97/comments"},"review_comment":{"href":"https://api.github.com/repos/ARMmbed/uvisor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ARMmbed/uvisor/pulls/97/commits"},"statuses":{"href":"https://api.github.com/repos/ARMmbed/uvisor/statuses/466dc572f493b0aaea089e71a6b3af0e9e65d87d"}}}}