{"action":"created","comment":{"url":"https://api.github.com/repos/DIRACGrid/DIRAC/pulls/comments/31807171","id":31807171,"diff_hunk":"@@ -30,174 +30,151 @@ FLUSH PRIVILEGES;\n USE JobDB;\n \n -- ------------------------------------------------------------------------------\n-DROP TABLE IF EXISTS Jobs;\n-CREATE TABLE Jobs (\n-    JobID INTEGER NOT NULL AUTO_INCREMENT,\n-    JobType VARCHAR(32) NOT NULL DEFAULT 'normal',\n-    INDEX (JobType),\n-    DIRACSetup VARCHAR(32) NOT NULL,\n-    INDEX (DIRACSetup),\n-    JobGroup VARCHAR(32) NOT NULL DEFAULT 'NoGroup',\n-    INDEX (JobGroup),\n-    JobSplitType ENUM ('Single','Master','Subjob','DAGNode') NOT NULL DEFAULT 'Single',\n-    INDEX (JobSplitType),\n-    MasterJobID INTEGER NOT NULL DEFAULT 0,\n-    Site VARCHAR(100) NOT NULL DEFAULT 'ANY',\n-    INDEX (Site),\n-    JobName VARCHAR(128) NOT NULL DEFAULT 'Unknown',\n-    Owner VARCHAR(32) NOT NULL DEFAULT 'Unknown',\n-    INDEX (Owner),\n-    OwnerDN VARCHAR(255) NOT NULL DEFAULT 'Unknown',\n-    INDEX (OwnerDN),\n-    OwnerGroup varchar(128) NOT NULL DEFAULT 'lhcb_user',\n-    INDEX (OwnerGroup),\n-    SubmissionTime DATETIME,\n-    RescheduleTime DATETIME,\n-    LastUpdateTime DATETIME,\n-    StartExecTime DATETIME,\n-    HeartBeatTime DATETIME,\n-    EndExecTime DATETIME,\n-    Status VARCHAR(32) NOT NULL DEFAULT 'Received',\n-    INDEX (Status),\n-    INDEX (Status,Site),\n-    MinorStatus VARCHAR(128) NOT NULL DEFAULT 'Initial insertion',\n-    INDEX (MinorStatus),\n-    ApplicationStatus VARCHAR(255) NOT NULL DEFAULT 'Unknown',\n-    INDEX (ApplicationStatus),\n-    ApplicationNumStatus INTEGER NOT NULL DEFAULT 0,\n-    CPUTime FLOAT NOT NULL DEFAULT 0.0,\n-    UserPriority INTEGER NOT NULL DEFAULT 0,\n-    SystemPriority INTEGER NOT NULL DEFAULT 0,\n-    RescheduleCounter INTEGER NOT NULL DEFAULT 0,\n-    VerifiedFlag  ENUM ('True','False') NOT NULL DEFAULT 'False',\n-    DeletedFlag  ENUM ('True','False') NOT NULL DEFAULT 'False',\n-    KilledFlag ENUM ('True','False') NOT NULL DEFAULT 'False',\n-    FailedFlag ENUM ('True','False') NOT NULL DEFAULT 'False',\n-    ISandboxReadyFlag ENUM ('True','False') NOT NULL DEFAULT 'False',\n-    OSandboxReadyFlag ENUM ('True','False') NOT NULL DEFAULT 'False',\n-    RetrievedFlag ENUM ('True','False') NOT NULL DEFAULT 'False',\n-    AccountedFlag ENUM ('True','False','Failed') NOT NULL DEFAULT 'False',\n-    PRIMARY KEY (JobID)\n-) ENGINE = InnoDB;\n+DROP TABLE IF EXISTS `Jobs`;\n+CREATE TABLE `Jobs` (\n+  `JobID` INT(11) UNSIGNED NOT NULL DEFAULT 0,\n+  `JobType` VARCHAR(32) NOT NULL DEFAULT 'user',\n+  `DIRACSetup` VARCHAR(32) NOT NULL DEFAULT 'test',\n+  `JobGroup` VARCHAR(32) NOT NULL DEFAULT '00000000',\n+  `JobSplitType` ENUM('Single','Master','Subjob','DAGNode') NOT NULL DEFAULT 'Single',\n+  `MasterJobID` INT(11) UNSIGNED NOT NULL DEFAULT 0,\n+  `Site` VARCHAR(100) NOT NULL DEFAULT 'ANY',\n+  `JobName` VARCHAR(128) NOT NULL DEFAULT 'Unknown',\n+  `Owner` VARCHAR(32) NOT NULL DEFAULT 'Unknown',\n+  `OwnerDN` VARCHAR(255) NOT NULL DEFAULT 'Unknown',\n+  `OwnerGroup` VARCHAR(128) NOT NULL DEFAULT 'Unknown',\n+  `SubmissionTime` DATETIME DEFAULT NULL,\n+  `RescheduleTime` DATETIME DEFAULT NULL,\n+  `LastUpdateTime` DATETIME DEFAULT NULL,\n+  `StartExecTime` DATETIME DEFAULT NULL,\n+  `HeartBeatTime` DATETIME DEFAULT NULL,\n+  `EndExecTime` DATETIME DEFAULT NULL,\n+  `Status` VARCHAR(32) NOT NULL DEFAULT 'Received',\n+  `MinorStatus` VARCHAR(128) NOT NULL DEFAULT 'Unknown',\n+  `ApplicationStatus` VARCHAR(255) DEFAULT 'Unknown',","path":"WorkloadManagementSystem/DB/JobDB.sql","position":74,"original_position":74,"commit_id":"e2b5cc2f21a6dee78545a1dcd25a23bb63fefa07","original_commit_id":"e2b5cc2f21a6dee78545a1dcd25a23bb63fefa07","user":{"login":"fstagni","id":785576,"avatar_url":"https://avatars.githubusercontent.com/u/785576?v=3","gravatar_id":"","url":"https://api.github.com/users/fstagni","html_url":"https://github.com/fstagni","followers_url":"https://api.github.com/users/fstagni/followers","following_url":"https://api.github.com/users/fstagni/following{/other_user}","gists_url":"https://api.github.com/users/fstagni/gists{/gist_id}","starred_url":"https://api.github.com/users/fstagni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fstagni/subscriptions","organizations_url":"https://api.github.com/users/fstagni/orgs","repos_url":"https://api.github.com/users/fstagni/repos","events_url":"https://api.github.com/users/fstagni/events{/privacy}","received_events_url":"https://api.github.com/users/fstagni/received_events","type":"User","site_admin":false},"body":"I would say yes, but sincerely I forgot the reason why.","created_at":"2015-06-05T12:11:12Z","updated_at":"2015-06-05T12:11:12Z","html_url":"https://github.com/DIRACGrid/DIRAC/pull/2093#discussion_r31807171","pull_request_url":"https://api.github.com/repos/DIRACGrid/DIRAC/pulls/2093","_links":{"self":{"href":"https://api.github.com/repos/DIRACGrid/DIRAC/pulls/comments/31807171"},"html":{"href":"https://github.com/DIRACGrid/DIRAC/pull/2093#discussion_r31807171"},"pull_request":{"href":"https://api.github.com/repos/DIRACGrid/DIRAC/pulls/2093"}}},"pull_request":{"url":"https://api.github.com/repos/DIRACGrid/DIRAC/pulls/2093","id":21770955,"html_url":"https://github.com/DIRACGrid/DIRAC/pull/2093","diff_url":"https://github.com/DIRACGrid/DIRAC/pull/2093.diff","patch_url":"https://github.com/DIRACGrid/DIRAC/pull/2093.patch","issue_url":"https://api.github.com/repos/DIRACGrid/DIRAC/issues/2093","number":2093,"state":"closed","locked":false,"title":"[v6r11] Some fixes for WMS","user":{"login":"fstagni","id":785576,"avatar_url":"https://avatars.githubusercontent.com/u/785576?v=3","gravatar_id":"","url":"https://api.github.com/users/fstagni","html_url":"https://github.com/fstagni","followers_url":"https://api.github.com/users/fstagni/followers","following_url":"https://api.github.com/users/fstagni/following{/other_user}","gists_url":"https://api.github.com/users/fstagni/gists{/gist_id}","starred_url":"https://api.github.com/users/fstagni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fstagni/subscriptions","organizations_url":"https://api.github.com/users/fstagni/orgs","repos_url":"https://api.github.com/users/fstagni/repos","events_url":"https://api.github.com/users/fstagni/events{/privacy}","received_events_url":"https://api.github.com/users/fstagni/received_events","type":"User","site_admin":false},"body":"There are also changes to comply to the Data Model https://docs.python.org/2/reference/datamodel.html#object.__nonzero__ for the RMS and DMS, that was causing a real bug (RequestName was wrongly set in FailoverRequest.py)\r\n\r\nSome (old, broken) test files for WMS DBs have been removed and are now in TestDIRAC\r\n","created_at":"2014-09-25T09:34:38Z","updated_at":"2015-06-05T12:11:12Z","closed_at":"2014-10-01T16:34:12Z","merged_at":"2014-10-01T16:34:12Z","merge_commit_sha":"b9b2ac95d0607e94f0e0a4e464743620986ef16c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/DIRACGrid/DIRAC/pulls/2093/commits","review_comments_url":"https://api.github.com/repos/DIRACGrid/DIRAC/pulls/2093/comments","review_comment_url":"https://api.github.com/repos/DIRACGrid/DIRAC/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DIRACGrid/DIRAC/issues/2093/comments","statuses_url":"https://api.github.com/repos/DIRACGrid/DIRAC/statuses/e2b5cc2f21a6dee78545a1dcd25a23bb63fefa07","head":{"label":"fstagni:fixesWMSv6r11","ref":"fixesWMSv6r11","sha":"e2b5cc2f21a6dee78545a1dcd25a23bb63fefa07","user":{"login":"fstagni","id":785576,"avatar_url":"https://avatars.githubusercontent.com/u/785576?v=3","gravatar_id":"","url":"https://api.github.com/users/fstagni","html_url":"https://github.com/fstagni","followers_url":"https://api.github.com/users/fstagni/followers","following_url":"https://api.github.com/users/fstagni/following{/other_user}","gists_url":"https://api.github.com/users/fstagni/gists{/gist_id}","starred_url":"https://api.github.com/users/fstagni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fstagni/subscriptions","organizations_url":"https://api.github.com/users/fstagni/orgs","repos_url":"https://api.github.com/users/fstagni/repos","events_url":"https://api.github.com/users/fstagni/events{/privacy}","received_events_url":"https://api.github.com/users/fstagni/received_events","type":"User","site_admin":false},"repo":{"id":1742442,"name":"DIRAC","full_name":"fstagni/DIRAC","owner":{"login":"fstagni","id":785576,"avatar_url":"https://avatars.githubusercontent.com/u/785576?v=3","gravatar_id":"","url":"https://api.github.com/users/fstagni","html_url":"https://github.com/fstagni","followers_url":"https://api.github.com/users/fstagni/followers","following_url":"https://api.github.com/users/fstagni/following{/other_user}","gists_url":"https://api.github.com/users/fstagni/gists{/gist_id}","starred_url":"https://api.github.com/users/fstagni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fstagni/subscriptions","organizations_url":"https://api.github.com/users/fstagni/orgs","repos_url":"https://api.github.com/users/fstagni/repos","events_url":"https://api.github.com/users/fstagni/events{/privacy}","received_events_url":"https://api.github.com/users/fstagni/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fstagni/DIRAC","description":"DIRAC Grid","fork":true,"url":"https://api.github.com/repos/fstagni/DIRAC","forks_url":"https://api.github.com/repos/fstagni/DIRAC/forks","keys_url":"https://api.github.com/repos/fstagni/DIRAC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fstagni/DIRAC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fstagni/DIRAC/teams","hooks_url":"https://api.github.com/repos/fstagni/DIRAC/hooks","issue_events_url":"https://api.github.com/repos/fstagni/DIRAC/issues/events{/number}","events_url":"https://api.github.com/repos/fstagni/DIRAC/events","assignees_url":"https://api.github.com/repos/fstagni/DIRAC/assignees{/user}","branches_url":"https://api.github.com/repos/fstagni/DIRAC/branches{/branch}","tags_url":"https://api.github.com/repos/fstagni/DIRAC/tags","blobs_url":"https://api.github.com/repos/fstagni/DIRAC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fstagni/DIRAC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fstagni/DIRAC/git/refs{/sha}","trees_url":"https://api.github.com/repos/fstagni/DIRAC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fstagni/DIRAC/statuses/{sha}","languages_url":"https://api.github.com/repos/fstagni/DIRAC/languages","stargazers_url":"https://api.github.com/repos/fstagni/DIRAC/stargazers","contributors_url":"https://api.github.com/repos/fstagni/DIRAC/contributors","subscribers_url":"https://api.github.com/repos/fstagni/DIRAC/subscribers","subscription_url":"https://api.github.com/repos/fstagni/DIRAC/subscription","commits_url":"https://api.github.com/repos/fstagni/DIRAC/commits{/sha}","git_commits_url":"https://api.github.com/repos/fstagni/DIRAC/git/commits{/sha}","comments_url":"https://api.github.com/repos/fstagni/DIRAC/comments{/number}","issue_comment_url":"https://api.github.com/repos/fstagni/DIRAC/issues/comments{/number}","contents_url":"https://api.github.com/repos/fstagni/DIRAC/contents/{+path}","compare_url":"https://api.github.com/repos/fstagni/DIRAC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fstagni/DIRAC/merges","archive_url":"https://api.github.com/repos/fstagni/DIRAC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fstagni/DIRAC/downloads","issues_url":"https://api.github.com/repos/fstagni/DIRAC/issues{/number}","pulls_url":"https://api.github.com/repos/fstagni/DIRAC/pulls{/number}","milestones_url":"https://api.github.com/repos/fstagni/DIRAC/milestones{/number}","notifications_url":"https://api.github.com/repos/fstagni/DIRAC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fstagni/DIRAC/labels{/name}","releases_url":"https://api.github.com/repos/fstagni/DIRAC/releases{/id}","created_at":"2011-05-13T08:21:03Z","updated_at":"2014-06-23T16:48:03Z","pushed_at":"2015-06-04T13:55:57Z","git_url":"git://github.com/fstagni/DIRAC.git","ssh_url":"git@github.com:fstagni/DIRAC.git","clone_url":"https://github.com/fstagni/DIRAC.git","svn_url":"https://github.com/fstagni/DIRAC","homepage":"http://diracgrid.org","size":26401,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"integration"}},"base":{"label":"DIRACGrid:rel-v6r11","ref":"rel-v6r11","sha":"cb6b5db20eff2a8c5f04e9983221850f475b38e3","user":{"login":"DIRACGrid","id":694842,"avatar_url":"https://avatars.githubusercontent.com/u/694842?v=3","gravatar_id":"","url":"https://api.github.com/users/DIRACGrid","html_url":"https://github.com/DIRACGrid","followers_url":"https://api.github.com/users/DIRACGrid/followers","following_url":"https://api.github.com/users/DIRACGrid/following{/other_user}","gists_url":"https://api.github.com/users/DIRACGrid/gists{/gist_id}","starred_url":"https://api.github.com/users/DIRACGrid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DIRACGrid/subscriptions","organizations_url":"https://api.github.com/users/DIRACGrid/orgs","repos_url":"https://api.github.com/users/DIRACGrid/repos","events_url":"https://api.github.com/users/DIRACGrid/events{/privacy}","received_events_url":"https://api.github.com/users/DIRACGrid/received_events","type":"Organization","site_admin":false},"repo":{"id":1576831,"name":"DIRAC","full_name":"DIRACGrid/DIRAC","owner":{"login":"DIRACGrid","id":694842,"avatar_url":"https://avatars.githubusercontent.com/u/694842?v=3","gravatar_id":"","url":"https://api.github.com/users/DIRACGrid","html_url":"https://github.com/DIRACGrid","followers_url":"https://api.github.com/users/DIRACGrid/followers","following_url":"https://api.github.com/users/DIRACGrid/following{/other_user}","gists_url":"https://api.github.com/users/DIRACGrid/gists{/gist_id}","starred_url":"https://api.github.com/users/DIRACGrid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DIRACGrid/subscriptions","organizations_url":"https://api.github.com/users/DIRACGrid/orgs","repos_url":"https://api.github.com/users/DIRACGrid/repos","events_url":"https://api.github.com/users/DIRACGrid/events{/privacy}","received_events_url":"https://api.github.com/users/DIRACGrid/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DIRACGrid/DIRAC","description":"DIRAC Grid","fork":false,"url":"https://api.github.com/repos/DIRACGrid/DIRAC","forks_url":"https://api.github.com/repos/DIRACGrid/DIRAC/forks","keys_url":"https://api.github.com/repos/DIRACGrid/DIRAC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DIRACGrid/DIRAC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DIRACGrid/DIRAC/teams","hooks_url":"https://api.github.com/repos/DIRACGrid/DIRAC/hooks","issue_events_url":"https://api.github.com/repos/DIRACGrid/DIRAC/issues/events{/number}","events_url":"https://api.github.com/repos/DIRACGrid/DIRAC/events","assignees_url":"https://api.github.com/repos/DIRACGrid/DIRAC/assignees{/user}","branches_url":"https://api.github.com/repos/DIRACGrid/DIRAC/branches{/branch}","tags_url":"https://api.github.com/repos/DIRACGrid/DIRAC/tags","blobs_url":"https://api.github.com/repos/DIRACGrid/DIRAC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DIRACGrid/DIRAC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DIRACGrid/DIRAC/git/refs{/sha}","trees_url":"https://api.github.com/repos/DIRACGrid/DIRAC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DIRACGrid/DIRAC/statuses/{sha}","languages_url":"https://api.github.com/repos/DIRACGrid/DIRAC/languages","stargazers_url":"https://api.github.com/repos/DIRACGrid/DIRAC/stargazers","contributors_url":"https://api.github.com/repos/DIRACGrid/DIRAC/contributors","subscribers_url":"https://api.github.com/repos/DIRACGrid/DIRAC/subscribers","subscription_url":"https://api.github.com/repos/DIRACGrid/DIRAC/subscription","commits_url":"https://api.github.com/repos/DIRACGrid/DIRAC/commits{/sha}","git_commits_url":"https://api.github.com/repos/DIRACGrid/DIRAC/git/commits{/sha}","comments_url":"https://api.github.com/repos/DIRACGrid/DIRAC/comments{/number}","issue_comment_url":"https://api.github.com/repos/DIRACGrid/DIRAC/issues/comments{/number}","contents_url":"https://api.github.com/repos/DIRACGrid/DIRAC/contents/{+path}","compare_url":"https://api.github.com/repos/DIRACGrid/DIRAC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DIRACGrid/DIRAC/merges","archive_url":"https://api.github.com/repos/DIRACGrid/DIRAC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DIRACGrid/DIRAC/downloads","issues_url":"https://api.github.com/repos/DIRACGrid/DIRAC/issues{/number}","pulls_url":"https://api.github.com/repos/DIRACGrid/DIRAC/pulls{/number}","milestones_url":"https://api.github.com/repos/DIRACGrid/DIRAC/milestones{/number}","notifications_url":"https://api.github.com/repos/DIRACGrid/DIRAC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DIRACGrid/DIRAC/labels{/name}","releases_url":"https://api.github.com/repos/DIRACGrid/DIRAC/releases{/id}","created_at":"2011-04-06T11:47:53Z","updated_at":"2015-05-07T06:39:51Z","pushed_at":"2015-06-04T22:59:57Z","git_url":"git://github.com/DIRACGrid/DIRAC.git","ssh_url":"git@github.com:DIRACGrid/DIRAC.git","clone_url":"https://github.com/DIRACGrid/DIRAC.git","svn_url":"https://github.com/DIRACGrid/DIRAC","homepage":"http://diracgrid.org","size":64032,"stargazers_count":42,"watchers_count":42,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":77,"mirror_url":null,"open_issues_count":109,"forks":77,"open_issues":109,"watchers":42,"default_branch":"integration"}},"_links":{"self":{"href":"https://api.github.com/repos/DIRACGrid/DIRAC/pulls/2093"},"html":{"href":"https://github.com/DIRACGrid/DIRAC/pull/2093"},"issue":{"href":"https://api.github.com/repos/DIRACGrid/DIRAC/issues/2093"},"comments":{"href":"https://api.github.com/repos/DIRACGrid/DIRAC/issues/2093/comments"},"review_comments":{"href":"https://api.github.com/repos/DIRACGrid/DIRAC/pulls/2093/comments"},"review_comment":{"href":"https://api.github.com/repos/DIRACGrid/DIRAC/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DIRACGrid/DIRAC/pulls/2093/commits"},"statuses":{"href":"https://api.github.com/repos/DIRACGrid/DIRAC/statuses/e2b5cc2f21a6dee78545a1dcd25a23bb63fefa07"}}}}