{"action":"opened","number":251,"pull_request":{"url":"https://api.github.com/repos/jobovy/galpy/pulls/251","id":42675858,"html_url":"https://github.com/jobovy/galpy/pull/251","diff_url":"https://github.com/jobovy/galpy/pull/251.diff","patch_url":"https://github.com/jobovy/galpy/pull/251.patch","issue_url":"https://api.github.com/repos/jobovy/galpy/issues/251","number":251,"state":"open","locked":false,"title":"Kicks computed with full orbit path of stars","user":{"login":"jls713","id":12542535,"avatar_url":"https://avatars.githubusercontent.com/u/12542535?v=3","gravatar_id":"","url":"https://api.github.com/users/jls713","html_url":"https://github.com/jls713","followers_url":"https://api.github.com/users/jls713/followers","following_url":"https://api.github.com/users/jls713/following{/other_user}","gists_url":"https://api.github.com/users/jls713/gists{/gist_id}","starred_url":"https://api.github.com/users/jls713/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jls713/subscriptions","organizations_url":"https://api.github.com/users/jls713/orgs","repos_url":"https://api.github.com/users/jls713/repos","events_url":"https://api.github.com/users/jls713/events{/privacy}","received_events_url":"https://api.github.com/users/jls713/received_events","type":"User","site_admin":false},"body":"I have written two more impulse_deltav* routines. One uses pre-computed samples of an orbit at time samples, and the second uses a galpy potential to compute the orbits. This second one could certainly be improved by:\r\n1. Simplify the interface to galpy.orbit?\r\n2. Don't have the user choose the time samples but instead integrate (both forwards and backwards in time) until the acceleration from the sub-halo falls below some threshold and automatically choose a suitable resolution for the time sampling. ","created_at":"2015-08-18T09:04:18Z","updated_at":"2015-08-18T09:04:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jobovy/galpy/pulls/251/commits","review_comments_url":"https://api.github.com/repos/jobovy/galpy/pulls/251/comments","review_comment_url":"https://api.github.com/repos/jobovy/galpy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jobovy/galpy/issues/251/comments","statuses_url":"https://api.github.com/repos/jobovy/galpy/statuses/ee4ca9ad7078bb211a01207cbde155fea8ad0a55","head":{"label":"jls713:streamgap","ref":"streamgap","sha":"ee4ca9ad7078bb211a01207cbde155fea8ad0a55","user":{"login":"jls713","id":12542535,"avatar_url":"https://avatars.githubusercontent.com/u/12542535?v=3","gravatar_id":"","url":"https://api.github.com/users/jls713","html_url":"https://github.com/jls713","followers_url":"https://api.github.com/users/jls713/followers","following_url":"https://api.github.com/users/jls713/following{/other_user}","gists_url":"https://api.github.com/users/jls713/gists{/gist_id}","starred_url":"https://api.github.com/users/jls713/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jls713/subscriptions","organizations_url":"https://api.github.com/users/jls713/orgs","repos_url":"https://api.github.com/users/jls713/repos","events_url":"https://api.github.com/users/jls713/events{/privacy}","received_events_url":"https://api.github.com/users/jls713/received_events","type":"User","site_admin":false},"repo":{"id":36861637,"name":"galpy","full_name":"jls713/galpy","owner":{"login":"jls713","id":12542535,"avatar_url":"https://avatars.githubusercontent.com/u/12542535?v=3","gravatar_id":"","url":"https://api.github.com/users/jls713","html_url":"https://github.com/jls713","followers_url":"https://api.github.com/users/jls713/followers","following_url":"https://api.github.com/users/jls713/following{/other_user}","gists_url":"https://api.github.com/users/jls713/gists{/gist_id}","starred_url":"https://api.github.com/users/jls713/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jls713/subscriptions","organizations_url":"https://api.github.com/users/jls713/orgs","repos_url":"https://api.github.com/users/jls713/repos","events_url":"https://api.github.com/users/jls713/events{/privacy}","received_events_url":"https://api.github.com/users/jls713/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jls713/galpy","description":"Galactic Dynamics in python","fork":true,"url":"https://api.github.com/repos/jls713/galpy","forks_url":"https://api.github.com/repos/jls713/galpy/forks","keys_url":"https://api.github.com/repos/jls713/galpy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jls713/galpy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jls713/galpy/teams","hooks_url":"https://api.github.com/repos/jls713/galpy/hooks","issue_events_url":"https://api.github.com/repos/jls713/galpy/issues/events{/number}","events_url":"https://api.github.com/repos/jls713/galpy/events","assignees_url":"https://api.github.com/repos/jls713/galpy/assignees{/user}","branches_url":"https://api.github.com/repos/jls713/galpy/branches{/branch}","tags_url":"https://api.github.com/repos/jls713/galpy/tags","blobs_url":"https://api.github.com/repos/jls713/galpy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jls713/galpy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jls713/galpy/git/refs{/sha}","trees_url":"https://api.github.com/repos/jls713/galpy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jls713/galpy/statuses/{sha}","languages_url":"https://api.github.com/repos/jls713/galpy/languages","stargazers_url":"https://api.github.com/repos/jls713/galpy/stargazers","contributors_url":"https://api.github.com/repos/jls713/galpy/contributors","subscribers_url":"https://api.github.com/repos/jls713/galpy/subscribers","subscription_url":"https://api.github.com/repos/jls713/galpy/subscription","commits_url":"https://api.github.com/repos/jls713/galpy/commits{/sha}","git_commits_url":"https://api.github.com/repos/jls713/galpy/git/commits{/sha}","comments_url":"https://api.github.com/repos/jls713/galpy/comments{/number}","issue_comment_url":"https://api.github.com/repos/jls713/galpy/issues/comments{/number}","contents_url":"https://api.github.com/repos/jls713/galpy/contents/{+path}","compare_url":"https://api.github.com/repos/jls713/galpy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jls713/galpy/merges","archive_url":"https://api.github.com/repos/jls713/galpy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jls713/galpy/downloads","issues_url":"https://api.github.com/repos/jls713/galpy/issues{/number}","pulls_url":"https://api.github.com/repos/jls713/galpy/pulls{/number}","milestones_url":"https://api.github.com/repos/jls713/galpy/milestones{/number}","notifications_url":"https://api.github.com/repos/jls713/galpy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jls713/galpy/labels{/name}","releases_url":"https://api.github.com/repos/jls713/galpy/releases{/id}","created_at":"2015-06-04T09:40:43Z","updated_at":"2015-06-04T09:40:44Z","pushed_at":"2015-08-18T08:58:51Z","git_url":"git://github.com/jls713/galpy.git","ssh_url":"git@github.com:jls713/galpy.git","clone_url":"https://github.com/jls713/galpy.git","svn_url":"https://github.com/jls713/galpy","homepage":"http://galpy.readthedocs.org/","size":15335,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jobovy:streamgap","ref":"streamgap","sha":"0f80f4f3e5993449cd431fc2d7f2414fd0533b73","user":{"login":"jobovy","id":1044876,"avatar_url":"https://avatars.githubusercontent.com/u/1044876?v=3","gravatar_id":"","url":"https://api.github.com/users/jobovy","html_url":"https://github.com/jobovy","followers_url":"https://api.github.com/users/jobovy/followers","following_url":"https://api.github.com/users/jobovy/following{/other_user}","gists_url":"https://api.github.com/users/jobovy/gists{/gist_id}","starred_url":"https://api.github.com/users/jobovy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jobovy/subscriptions","organizations_url":"https://api.github.com/users/jobovy/orgs","repos_url":"https://api.github.com/users/jobovy/repos","events_url":"https://api.github.com/users/jobovy/events{/privacy}","received_events_url":"https://api.github.com/users/jobovy/received_events","type":"User","site_admin":false},"repo":{"id":2375854,"name":"galpy","full_name":"jobovy/galpy","owner":{"login":"jobovy","id":1044876,"avatar_url":"https://avatars.githubusercontent.com/u/1044876?v=3","gravatar_id":"","url":"https://api.github.com/users/jobovy","html_url":"https://github.com/jobovy","followers_url":"https://api.github.com/users/jobovy/followers","following_url":"https://api.github.com/users/jobovy/following{/other_user}","gists_url":"https://api.github.com/users/jobovy/gists{/gist_id}","starred_url":"https://api.github.com/users/jobovy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jobovy/subscriptions","organizations_url":"https://api.github.com/users/jobovy/orgs","repos_url":"https://api.github.com/users/jobovy/repos","events_url":"https://api.github.com/users/jobovy/events{/privacy}","received_events_url":"https://api.github.com/users/jobovy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jobovy/galpy","description":"Galactic Dynamics in python","fork":false,"url":"https://api.github.com/repos/jobovy/galpy","forks_url":"https://api.github.com/repos/jobovy/galpy/forks","keys_url":"https://api.github.com/repos/jobovy/galpy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jobovy/galpy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jobovy/galpy/teams","hooks_url":"https://api.github.com/repos/jobovy/galpy/hooks","issue_events_url":"https://api.github.com/repos/jobovy/galpy/issues/events{/number}","events_url":"https://api.github.com/repos/jobovy/galpy/events","assignees_url":"https://api.github.com/repos/jobovy/galpy/assignees{/user}","branches_url":"https://api.github.com/repos/jobovy/galpy/branches{/branch}","tags_url":"https://api.github.com/repos/jobovy/galpy/tags","blobs_url":"https://api.github.com/repos/jobovy/galpy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jobovy/galpy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jobovy/galpy/git/refs{/sha}","trees_url":"https://api.github.com/repos/jobovy/galpy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jobovy/galpy/statuses/{sha}","languages_url":"https://api.github.com/repos/jobovy/galpy/languages","stargazers_url":"https://api.github.com/repos/jobovy/galpy/stargazers","contributors_url":"https://api.github.com/repos/jobovy/galpy/contributors","subscribers_url":"https://api.github.com/repos/jobovy/galpy/subscribers","subscription_url":"https://api.github.com/repos/jobovy/galpy/subscription","commits_url":"https://api.github.com/repos/jobovy/galpy/commits{/sha}","git_commits_url":"https://api.github.com/repos/jobovy/galpy/git/commits{/sha}","comments_url":"https://api.github.com/repos/jobovy/galpy/comments{/number}","issue_comment_url":"https://api.github.com/repos/jobovy/galpy/issues/comments{/number}","contents_url":"https://api.github.com/repos/jobovy/galpy/contents/{+path}","compare_url":"https://api.github.com/repos/jobovy/galpy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jobovy/galpy/merges","archive_url":"https://api.github.com/repos/jobovy/galpy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jobovy/galpy/downloads","issues_url":"https://api.github.com/repos/jobovy/galpy/issues{/number}","pulls_url":"https://api.github.com/repos/jobovy/galpy/pulls{/number}","milestones_url":"https://api.github.com/repos/jobovy/galpy/milestones{/number}","notifications_url":"https://api.github.com/repos/jobovy/galpy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jobovy/galpy/labels{/name}","releases_url":"https://api.github.com/repos/jobovy/galpy/releases{/id}","created_at":"2011-09-13T03:20:30Z","updated_at":"2015-08-14T04:19:35Z","pushed_at":"2015-08-17T00:36:40Z","git_url":"git://github.com/jobovy/galpy.git","ssh_url":"git@github.com:jobovy/galpy.git","clone_url":"https://github.com/jobovy/galpy.git","svn_url":"https://github.com/jobovy/galpy","homepage":"http://galpy.readthedocs.org/","size":18483,"stargazers_count":30,"watchers_count":30,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":11,"mirror_url":null,"open_issues_count":23,"forks":11,"open_issues":23,"watchers":30,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jobovy/galpy/pulls/251"},"html":{"href":"https://github.com/jobovy/galpy/pull/251"},"issue":{"href":"https://api.github.com/repos/jobovy/galpy/issues/251"},"comments":{"href":"https://api.github.com/repos/jobovy/galpy/issues/251/comments"},"review_comments":{"href":"https://api.github.com/repos/jobovy/galpy/pulls/251/comments"},"review_comment":{"href":"https://api.github.com/repos/jobovy/galpy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jobovy/galpy/pulls/251/commits"},"statuses":{"href":"https://api.github.com/repos/jobovy/galpy/statuses/ee4ca9ad7078bb211a01207cbde155fea8ad0a55"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":3,"additions":208,"deletions":0,"changed_files":2}}