{"action":"created","comment":{"url":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/pulls/comments/34576899","id":34576899,"diff_hunk":"@@ -475,6 +479,48 @@\n             <argLine>-Xmx1024m -XX:MaxPermSize=128m -Dfile.encoding=UTF-8</argLine>\n           </configuration>\n         </plugin>\n+        <plugin>\n+          <groupId>org.jacoco</groupId>\n+          <artifactId>jacoco-maven-plugin</artifactId>\n+          <version>0.7.5.201505241946</version>\n+          <executions>\n+            <execution>\n+              <id>default-prepare-agent</id>\n+              <goals>\n+                <goal>prepare-agent</goal>\n+              </goals>\n+            </execution>\n+            <execution>\n+              <id>default-report</id>\n+              <phase>prepare-package</phase>\n+              <goals>\n+                <goal>report</goal>\n+              </goals>\n+            </execution>\n+            <execution>\n+              <id>default-check</id>\n+              <goals>\n+                <goal>check</goal>\n+              </goals>\n+              <configuration>\n+                <!-- Do not fail the build if rules are not met -->\n+                <haltOnFailure>false</haltOnFailure>\n+                <rules>\n+                  <rule>\n+                    <element>BUNDLE</element>\n+                    <limits>\n+                      <limit>\n+                        <counter>LINE</counter>\n+                        <value>COVEREDRATIO</value>\n+                        <minimum>0.9</minimum>","path":"pom.xml","position":75,"original_position":75,"commit_id":"6a26922dd507963257327af050d7f3da942ff728","original_commit_id":"6a26922dd507963257327af050d7f3da942ff728","user":{"login":"psiroky","id":670547,"avatar_url":"https://avatars.githubusercontent.com/u/670547?v=3","gravatar_id":"","url":"https://api.github.com/users/psiroky","html_url":"https://github.com/psiroky","followers_url":"https://api.github.com/users/psiroky/followers","following_url":"https://api.github.com/users/psiroky/following{/other_user}","gists_url":"https://api.github.com/users/psiroky/gists{/gist_id}","starred_url":"https://api.github.com/users/psiroky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psiroky/subscriptions","organizations_url":"https://api.github.com/users/psiroky/orgs","repos_url":"https://api.github.com/users/psiroky/repos","events_url":"https://api.github.com/users/psiroky/events{/privacy}","received_events_url":"https://api.github.com/users/psiroky/received_events","type":"User","site_admin":false},"body":"I think this is too strict. But since we are just reporting warnings, it probably does matter that much.","created_at":"2015-07-14T14:55:46Z","updated_at":"2015-07-14T14:55:46Z","html_url":"https://github.com/droolsjbpm/droolsjbpm-build-bootstrap/pull/77#discussion_r34576899","pull_request_url":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/pulls/77","_links":{"self":{"href":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/pulls/comments/34576899"},"html":{"href":"https://github.com/droolsjbpm/droolsjbpm-build-bootstrap/pull/77#discussion_r34576899"},"pull_request":{"href":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/pulls/77"}}},"pull_request":{"url":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/pulls/77","id":39689644,"html_url":"https://github.com/droolsjbpm/droolsjbpm-build-bootstrap/pull/77","diff_url":"https://github.com/droolsjbpm/droolsjbpm-build-bootstrap/pull/77.diff","patch_url":"https://github.com/droolsjbpm/droolsjbpm-build-bootstrap/pull/77.patch","issue_url":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/issues/77","number":77,"state":"open","locked":false,"title":"Enable code coverage analysis with JaCoCo","user":{"login":"yurloc","id":673386,"avatar_url":"https://avatars.githubusercontent.com/u/673386?v=3","gravatar_id":"","url":"https://api.github.com/users/yurloc","html_url":"https://github.com/yurloc","followers_url":"https://api.github.com/users/yurloc/followers","following_url":"https://api.github.com/users/yurloc/following{/other_user}","gists_url":"https://api.github.com/users/yurloc/gists{/gist_id}","starred_url":"https://api.github.com/users/yurloc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yurloc/subscriptions","organizations_url":"https://api.github.com/users/yurloc/orgs","repos_url":"https://api.github.com/users/yurloc/repos","events_url":"https://api.github.com/users/yurloc/events{/privacy}","received_events_url":"https://api.github.com/users/yurloc/received_events","type":"User","site_admin":false},"body":"Adding JaCoCo configuration to `kie-parent-metadata` makes code coverage analysis ready to use in any droolsjbpm project. I find this potentially useful for both QA engineers and developers who want to quickly find code pieces lacking test coverage.\r\n\r\nI have introduced a simple rule that requires 90% line coverage. The plugin wil print a warning if the requirement is not met. This can be changed or the check execution can be removed completely. More interesting is the HTML report of code coverage that is generated after running\r\n\r\n```shell\r\nmvn clean verify -Djacoco\r\n```\r\n\r\nThe reports can be found in `target/site/jacoco/index.html` in any module that executed some tests.\r\n\r\nThe test execution analysis and subsequent report generation may add some 10-50% to build time (very roughly) so I put JaCoCo plugin into a profile that is not active by default. It can be activated with `-Djacoco`.\r\n\r\nSurefire upgraded so that JaCoCo agent path passed in `argLine` can be\r\ncombined with memory options for test execution ([SUREFIRE-1047](https://issues.apache.org/jira/browse/SUREFIRE-1047) fixed in 2.17).","created_at":"2015-07-10T14:33:16Z","updated_at":"2015-07-14T14:55:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"03ff72cec2f9a3064f07764e74f45328707bc519","assignee":{"login":"psiroky","id":670547,"avatar_url":"https://avatars.githubusercontent.com/u/670547?v=3","gravatar_id":"","url":"https://api.github.com/users/psiroky","html_url":"https://github.com/psiroky","followers_url":"https://api.github.com/users/psiroky/followers","following_url":"https://api.github.com/users/psiroky/following{/other_user}","gists_url":"https://api.github.com/users/psiroky/gists{/gist_id}","starred_url":"https://api.github.com/users/psiroky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psiroky/subscriptions","organizations_url":"https://api.github.com/users/psiroky/orgs","repos_url":"https://api.github.com/users/psiroky/repos","events_url":"https://api.github.com/users/psiroky/events{/privacy}","received_events_url":"https://api.github.com/users/psiroky/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/pulls/77/commits","review_comments_url":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/pulls/77/comments","review_comment_url":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/pulls/comments{/number}","comments_url":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/issues/77/comments","statuses_url":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/statuses/6a26922dd507963257327af050d7f3da942ff728","head":{"label":"yurloc:jacoco","ref":"jacoco","sha":"6a26922dd507963257327af050d7f3da942ff728","user":{"login":"yurloc","id":673386,"avatar_url":"https://avatars.githubusercontent.com/u/673386?v=3","gravatar_id":"","url":"https://api.github.com/users/yurloc","html_url":"https://github.com/yurloc","followers_url":"https://api.github.com/users/yurloc/followers","following_url":"https://api.github.com/users/yurloc/following{/other_user}","gists_url":"https://api.github.com/users/yurloc/gists{/gist_id}","starred_url":"https://api.github.com/users/yurloc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yurloc/subscriptions","organizations_url":"https://api.github.com/users/yurloc/orgs","repos_url":"https://api.github.com/users/yurloc/repos","events_url":"https://api.github.com/users/yurloc/events{/privacy}","received_events_url":"https://api.github.com/users/yurloc/received_events","type":"User","site_admin":false},"repo":{"id":24722897,"name":"droolsjbpm-build-bootstrap","full_name":"yurloc/droolsjbpm-build-bootstrap","owner":{"login":"yurloc","id":673386,"avatar_url":"https://avatars.githubusercontent.com/u/673386?v=3","gravatar_id":"","url":"https://api.github.com/users/yurloc","html_url":"https://github.com/yurloc","followers_url":"https://api.github.com/users/yurloc/followers","following_url":"https://api.github.com/users/yurloc/following{/other_user}","gists_url":"https://api.github.com/users/yurloc/gists{/gist_id}","starred_url":"https://api.github.com/users/yurloc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yurloc/subscriptions","organizations_url":"https://api.github.com/users/yurloc/orgs","repos_url":"https://api.github.com/users/yurloc/repos","events_url":"https://api.github.com/users/yurloc/events{/privacy}","received_events_url":"https://api.github.com/users/yurloc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yurloc/droolsjbpm-build-bootstrap","description":"The build bootstrap contains the parent pom, guidelines and scripts for Drools and jBPM.","fork":true,"url":"https://api.github.com/repos/yurloc/droolsjbpm-build-bootstrap","forks_url":"https://api.github.com/repos/yurloc/droolsjbpm-build-bootstrap/forks","keys_url":"https://api.github.com/repos/yurloc/droolsjbpm-build-bootstrap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yurloc/droolsjbpm-build-bootstrap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yurloc/droolsjbpm-build-bootstrap/teams","hooks_url":"https://api.github.com/repos/yurloc/droolsjbpm-build-bootstrap/hooks","issue_events_url":"https://api.github.com/repos/yurloc/droolsjbpm-build-bootstrap/issues/events{/number}","events_url":"https://api.github.com/repos/yurloc/droolsjbpm-build-bootstrap/events","assignees_url":"https://api.github.com/repos/yurloc/droolsjbpm-build-bootstrap/assignees{/user}","branches_url":"https://api.github.com/repos/yurloc/droolsjbpm-build-bootstrap/branches{/branch}","tags_url":"https://api.github.com/repos/yurloc/droolsjbpm-build-bootstrap/tags","blobs_url":"https://api.github.com/repos/yurloc/droolsjbpm-build-bootstrap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yurloc/droolsjbpm-build-bootstrap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yurloc/droolsjbpm-build-bootstrap/git/refs{/sha}","trees_url":"https://api.github.com/repos/yurloc/droolsjbpm-build-bootstrap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yurloc/droolsjbpm-build-bootstrap/statuses/{sha}","languages_url":"https://api.github.com/repos/yurloc/droolsjbpm-build-bootstrap/languages","stargazers_url":"https://api.github.com/repos/yurloc/droolsjbpm-build-bootstrap/stargazers","contributors_url":"https://api.github.com/repos/yurloc/droolsjbpm-build-bootstrap/contributors","subscribers_url":"https://api.github.com/repos/yurloc/droolsjbpm-build-bootstrap/subscribers","subscription_url":"https://api.github.com/repos/yurloc/droolsjbpm-build-bootstrap/subscription","commits_url":"https://api.github.com/repos/yurloc/droolsjbpm-build-bootstrap/commits{/sha}","git_commits_url":"https://api.github.com/repos/yurloc/droolsjbpm-build-bootstrap/git/commits{/sha}","comments_url":"https://api.github.com/repos/yurloc/droolsjbpm-build-bootstrap/comments{/number}","issue_comment_url":"https://api.github.com/repos/yurloc/droolsjbpm-build-bootstrap/issues/comments{/number}","contents_url":"https://api.github.com/repos/yurloc/droolsjbpm-build-bootstrap/contents/{+path}","compare_url":"https://api.github.com/repos/yurloc/droolsjbpm-build-bootstrap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yurloc/droolsjbpm-build-bootstrap/merges","archive_url":"https://api.github.com/repos/yurloc/droolsjbpm-build-bootstrap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yurloc/droolsjbpm-build-bootstrap/downloads","issues_url":"https://api.github.com/repos/yurloc/droolsjbpm-build-bootstrap/issues{/number}","pulls_url":"https://api.github.com/repos/yurloc/droolsjbpm-build-bootstrap/pulls{/number}","milestones_url":"https://api.github.com/repos/yurloc/droolsjbpm-build-bootstrap/milestones{/number}","notifications_url":"https://api.github.com/repos/yurloc/droolsjbpm-build-bootstrap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yurloc/droolsjbpm-build-bootstrap/labels{/name}","releases_url":"https://api.github.com/repos/yurloc/droolsjbpm-build-bootstrap/releases{/id}","created_at":"2014-10-02T14:45:24Z","updated_at":"2015-05-08T17:59:40Z","pushed_at":"2015-07-10T13:17:24Z","git_url":"git://github.com/yurloc/droolsjbpm-build-bootstrap.git","ssh_url":"git@github.com:yurloc/droolsjbpm-build-bootstrap.git","clone_url":"https://github.com/yurloc/droolsjbpm-build-bootstrap.git","svn_url":"https://github.com/yurloc/droolsjbpm-build-bootstrap","homepage":"http://www.jboss.org/drools","size":3869,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"droolsjbpm:master","ref":"master","sha":"fd663c05b50510f6b64446b653e78baef42676bd","user":{"login":"droolsjbpm","id":517980,"avatar_url":"https://avatars.githubusercontent.com/u/517980?v=3","gravatar_id":"","url":"https://api.github.com/users/droolsjbpm","html_url":"https://github.com/droolsjbpm","followers_url":"https://api.github.com/users/droolsjbpm/followers","following_url":"https://api.github.com/users/droolsjbpm/following{/other_user}","gists_url":"https://api.github.com/users/droolsjbpm/gists{/gist_id}","starred_url":"https://api.github.com/users/droolsjbpm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/droolsjbpm/subscriptions","organizations_url":"https://api.github.com/users/droolsjbpm/orgs","repos_url":"https://api.github.com/users/droolsjbpm/repos","events_url":"https://api.github.com/users/droolsjbpm/events{/privacy}","received_events_url":"https://api.github.com/users/droolsjbpm/received_events","type":"Organization","site_admin":false},"repo":{"id":1382478,"name":"droolsjbpm-build-bootstrap","full_name":"droolsjbpm/droolsjbpm-build-bootstrap","owner":{"login":"droolsjbpm","id":517980,"avatar_url":"https://avatars.githubusercontent.com/u/517980?v=3","gravatar_id":"","url":"https://api.github.com/users/droolsjbpm","html_url":"https://github.com/droolsjbpm","followers_url":"https://api.github.com/users/droolsjbpm/followers","following_url":"https://api.github.com/users/droolsjbpm/following{/other_user}","gists_url":"https://api.github.com/users/droolsjbpm/gists{/gist_id}","starred_url":"https://api.github.com/users/droolsjbpm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/droolsjbpm/subscriptions","organizations_url":"https://api.github.com/users/droolsjbpm/orgs","repos_url":"https://api.github.com/users/droolsjbpm/repos","events_url":"https://api.github.com/users/droolsjbpm/events{/privacy}","received_events_url":"https://api.github.com/users/droolsjbpm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/droolsjbpm/droolsjbpm-build-bootstrap","description":"The build bootstrap contains the parent pom, guidelines and scripts for Drools, jBPM and OptaPlanner.","fork":false,"url":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap","forks_url":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/forks","keys_url":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/teams","hooks_url":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/hooks","issue_events_url":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/issues/events{/number}","events_url":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/events","assignees_url":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/assignees{/user}","branches_url":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/branches{/branch}","tags_url":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/tags","blobs_url":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/git/refs{/sha}","trees_url":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/statuses/{sha}","languages_url":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/languages","stargazers_url":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/stargazers","contributors_url":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/contributors","subscribers_url":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/subscribers","subscription_url":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/subscription","commits_url":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/commits{/sha}","git_commits_url":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/git/commits{/sha}","comments_url":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/comments{/number}","issue_comment_url":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/issues/comments{/number}","contents_url":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/contents/{+path}","compare_url":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/merges","archive_url":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/downloads","issues_url":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/issues{/number}","pulls_url":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/pulls{/number}","milestones_url":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/milestones{/number}","notifications_url":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/labels{/name}","releases_url":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/releases{/id}","created_at":"2011-02-18T13:12:01Z","updated_at":"2015-07-09T23:42:14Z","pushed_at":"2015-07-14T01:27:40Z","git_url":"git://github.com/droolsjbpm/droolsjbpm-build-bootstrap.git","ssh_url":"git@github.com:droolsjbpm/droolsjbpm-build-bootstrap.git","clone_url":"https://github.com/droolsjbpm/droolsjbpm-build-bootstrap.git","svn_url":"https://github.com/droolsjbpm/droolsjbpm-build-bootstrap","homepage":"http://www.kiegroup.org","size":7168,"stargazers_count":80,"watchers_count":80,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":163,"mirror_url":null,"open_issues_count":5,"forks":163,"open_issues":5,"watchers":80,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/pulls/77"},"html":{"href":"https://github.com/droolsjbpm/droolsjbpm-build-bootstrap/pull/77"},"issue":{"href":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/issues/77"},"comments":{"href":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/issues/77/comments"},"review_comments":{"href":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/pulls/77/comments"},"review_comment":{"href":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/pulls/77/commits"},"statuses":{"href":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/statuses/6a26922dd507963257327af050d7f3da942ff728"}}}}