{"action":"closed","number":35,"pull_request":{"url":"https://api.github.com/repos/alphagov/contacts-frontend/pulls/35","id":49160494,"html_url":"https://github.com/alphagov/contacts-frontend/pull/35","diff_url":"https://github.com/alphagov/contacts-frontend/pull/35.diff","patch_url":"https://github.com/alphagov/contacts-frontend/pull/35.patch","issue_url":"https://api.github.com/repos/alphagov/contacts-frontend/issues/35","number":35,"state":"closed","locked":false,"title":"Fix postal address print styles","user":{"login":"fofr","id":319055,"avatar_url":"https://avatars.githubusercontent.com/u/319055?v=3","gravatar_id":"","url":"https://api.github.com/users/fofr","html_url":"https://github.com/fofr","followers_url":"https://api.github.com/users/fofr/followers","following_url":"https://api.github.com/users/fofr/following{/other_user}","gists_url":"https://api.github.com/users/fofr/gists{/gist_id}","starred_url":"https://api.github.com/users/fofr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fofr/subscriptions","organizations_url":"https://api.github.com/users/fofr/orgs","repos_url":"https://api.github.com/users/fofr/repos","events_url":"https://api.github.com/users/fofr/events{/privacy}","received_events_url":"https://api.github.com/users/fofr/received_events","type":"User","site_admin":false},"body":"When printing, each part of the address was appearing on a single line, and the first line appeared above it as a header. Anyone printing these pages and then transcribing the address would likely send things to the wrong place.\r\n\r\n* Don’t use styled spans, use divs (empty divs will have a zero height, whereas spans with line breaks would create new lines for empty parts)\r\n* Don’t use a heading for the title\r\n* Bump govuk_frontend_toolkit\r\n\r\nhttps://trello.com/c/jT7QTzBb/145-fix-print-styles-on-addresses-medium\r\n\r\n## Before\r\n<img width=\"601\" alt=\"screen shot 2015-10-29 at 16 00 30\" src=\"https://cloud.githubusercontent.com/assets/319055/10824001/3ef26d14-7e56-11e5-83cb-d9f301639c4a.png\">\r\n\r\n## After\r\n<img width=\"599\" alt=\"screen shot 2015-10-29 at 16 00 14\" src=\"https://cloud.githubusercontent.com/assets/319055/10824000/3eef250a-7e56-11e5-83a7-ac95bab029bd.png\">","created_at":"2015-10-29T16:01:56Z","updated_at":"2015-10-30T11:25:30Z","closed_at":"2015-10-30T11:25:29Z","merged_at":"2015-10-30T11:25:29Z","merge_commit_sha":"5e0eceec08f72467f95462704206758d13a575dd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/contacts-frontend/pulls/35/commits","review_comments_url":"https://api.github.com/repos/alphagov/contacts-frontend/pulls/35/comments","review_comment_url":"https://api.github.com/repos/alphagov/contacts-frontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alphagov/contacts-frontend/issues/35/comments","statuses_url":"https://api.github.com/repos/alphagov/contacts-frontend/statuses/d811fcf0666d7b43f5dd7527fb284c0a798f5f5e","head":{"label":"alphagov:fix-address-print-styles","ref":"fix-address-print-styles","sha":"d811fcf0666d7b43f5dd7527fb284c0a798f5f5e","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":20798800,"name":"contacts-frontend","full_name":"alphagov/contacts-frontend","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/contacts-frontend","description":"Display organisation contact information on GOV.UK","fork":false,"url":"https://api.github.com/repos/alphagov/contacts-frontend","forks_url":"https://api.github.com/repos/alphagov/contacts-frontend/forks","keys_url":"https://api.github.com/repos/alphagov/contacts-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/contacts-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/contacts-frontend/teams","hooks_url":"https://api.github.com/repos/alphagov/contacts-frontend/hooks","issue_events_url":"https://api.github.com/repos/alphagov/contacts-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/contacts-frontend/events","assignees_url":"https://api.github.com/repos/alphagov/contacts-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/contacts-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/contacts-frontend/tags","blobs_url":"https://api.github.com/repos/alphagov/contacts-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/contacts-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/contacts-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/contacts-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/contacts-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/contacts-frontend/languages","stargazers_url":"https://api.github.com/repos/alphagov/contacts-frontend/stargazers","contributors_url":"https://api.github.com/repos/alphagov/contacts-frontend/contributors","subscribers_url":"https://api.github.com/repos/alphagov/contacts-frontend/subscribers","subscription_url":"https://api.github.com/repos/alphagov/contacts-frontend/subscription","commits_url":"https://api.github.com/repos/alphagov/contacts-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/contacts-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/contacts-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/contacts-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/contacts-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/contacts-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/contacts-frontend/merges","archive_url":"https://api.github.com/repos/alphagov/contacts-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/contacts-frontend/downloads","issues_url":"https://api.github.com/repos/alphagov/contacts-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/contacts-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/contacts-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/contacts-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/contacts-frontend/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/contacts-frontend/releases{/id}","created_at":"2014-06-13T09:16:00Z","updated_at":"2015-03-31T15:59:02Z","pushed_at":"2015-10-30T11:25:29Z","git_url":"git://github.com/alphagov/contacts-frontend.git","ssh_url":"git@github.com:alphagov/contacts-frontend.git","clone_url":"https://github.com/alphagov/contacts-frontend.git","svn_url":"https://github.com/alphagov/contacts-frontend","homepage":"https://www.gov.uk/government/organisations/hm-revenue-customs/contact/alcohol-duties-national-registration-unit","size":664,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"alphagov:master","ref":"master","sha":"384b729f3c9ffdbebc2b441cbf9c601251d66009","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":20798800,"name":"contacts-frontend","full_name":"alphagov/contacts-frontend","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/contacts-frontend","description":"Display organisation contact information on GOV.UK","fork":false,"url":"https://api.github.com/repos/alphagov/contacts-frontend","forks_url":"https://api.github.com/repos/alphagov/contacts-frontend/forks","keys_url":"https://api.github.com/repos/alphagov/contacts-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/contacts-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/contacts-frontend/teams","hooks_url":"https://api.github.com/repos/alphagov/contacts-frontend/hooks","issue_events_url":"https://api.github.com/repos/alphagov/contacts-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/contacts-frontend/events","assignees_url":"https://api.github.com/repos/alphagov/contacts-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/contacts-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/contacts-frontend/tags","blobs_url":"https://api.github.com/repos/alphagov/contacts-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/contacts-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/contacts-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/contacts-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/contacts-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/contacts-frontend/languages","stargazers_url":"https://api.github.com/repos/alphagov/contacts-frontend/stargazers","contributors_url":"https://api.github.com/repos/alphagov/contacts-frontend/contributors","subscribers_url":"https://api.github.com/repos/alphagov/contacts-frontend/subscribers","subscription_url":"https://api.github.com/repos/alphagov/contacts-frontend/subscription","commits_url":"https://api.github.com/repos/alphagov/contacts-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/contacts-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/contacts-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/contacts-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/contacts-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/contacts-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/contacts-frontend/merges","archive_url":"https://api.github.com/repos/alphagov/contacts-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/contacts-frontend/downloads","issues_url":"https://api.github.com/repos/alphagov/contacts-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/contacts-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/contacts-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/contacts-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/contacts-frontend/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/contacts-frontend/releases{/id}","created_at":"2014-06-13T09:16:00Z","updated_at":"2015-03-31T15:59:02Z","pushed_at":"2015-10-30T11:25:29Z","git_url":"git://github.com/alphagov/contacts-frontend.git","ssh_url":"git@github.com:alphagov/contacts-frontend.git","clone_url":"https://github.com/alphagov/contacts-frontend.git","svn_url":"https://github.com/alphagov/contacts-frontend","homepage":"https://www.gov.uk/government/organisations/hm-revenue-customs/contact/alcohol-duties-national-registration-unit","size":664,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/contacts-frontend/pulls/35"},"html":{"href":"https://github.com/alphagov/contacts-frontend/pull/35"},"issue":{"href":"https://api.github.com/repos/alphagov/contacts-frontend/issues/35"},"comments":{"href":"https://api.github.com/repos/alphagov/contacts-frontend/issues/35/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/contacts-frontend/pulls/35/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/contacts-frontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alphagov/contacts-frontend/pulls/35/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/contacts-frontend/statuses/d811fcf0666d7b43f5dd7527fb284c0a798f5f5e"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"boffbowsh","id":18276,"avatar_url":"https://avatars.githubusercontent.com/u/18276?v=3","gravatar_id":"","url":"https://api.github.com/users/boffbowsh","html_url":"https://github.com/boffbowsh","followers_url":"https://api.github.com/users/boffbowsh/followers","following_url":"https://api.github.com/users/boffbowsh/following{/other_user}","gists_url":"https://api.github.com/users/boffbowsh/gists{/gist_id}","starred_url":"https://api.github.com/users/boffbowsh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boffbowsh/subscriptions","organizations_url":"https://api.github.com/users/boffbowsh/orgs","repos_url":"https://api.github.com/users/boffbowsh/repos","events_url":"https://api.github.com/users/boffbowsh/events{/privacy}","received_events_url":"https://api.github.com/users/boffbowsh/received_events","type":"User","site_admin":false},"comments":5,"review_comments":0,"commits":2,"additions":11,"deletions":15,"changed_files":4}}