{"action":"created","comment":{"url":"https://api.github.com/repos/robquesada/misingo/pulls/comments/42183186","id":42183186,"diff_hunk":"@@ -65,11 +65,62 @@\n \n .lostPet__information__detail__text {","path":"app/assets/stylesheets/lost_pet.scss","position":2,"original_position":2,"commit_id":"dd0bc6aa3aded2343c2356c1b2d51ba163921f31","original_commit_id":"dd0bc6aa3aded2343c2356c1b2d51ba163921f31","user":{"login":"jramscr","id":2270737,"avatar_url":"https://avatars.githubusercontent.com/u/2270737?v=3","gravatar_id":"","url":"https://api.github.com/users/jramscr","html_url":"https://github.com/jramscr","followers_url":"https://api.github.com/users/jramscr/followers","following_url":"https://api.github.com/users/jramscr/following{/other_user}","gists_url":"https://api.github.com/users/jramscr/gists{/gist_id}","starred_url":"https://api.github.com/users/jramscr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jramscr/subscriptions","organizations_url":"https://api.github.com/users/jramscr/orgs","repos_url":"https://api.github.com/users/jramscr/repos","events_url":"https://api.github.com/users/jramscr/events{/privacy}","received_events_url":"https://api.github.com/users/jramscr/received_events","type":"User","site_admin":false},"body":"What happens with this class name? In css style guides, preferred ways are to use dashes instead of underscores, also, to keep consistent classes names we should continue using dashes syntax.","created_at":"2015-10-15T21:30:29Z","updated_at":"2015-10-15T21:30:29Z","html_url":"https://github.com/robquesada/misingo/pull/33#discussion_r42183186","pull_request_url":"https://api.github.com/repos/robquesada/misingo/pulls/33","_links":{"self":{"href":"https://api.github.com/repos/robquesada/misingo/pulls/comments/42183186"},"html":{"href":"https://github.com/robquesada/misingo/pull/33#discussion_r42183186"},"pull_request":{"href":"https://api.github.com/repos/robquesada/misingo/pulls/33"}}},"pull_request":{"url":"https://api.github.com/repos/robquesada/misingo/pulls/33","id":47460500,"html_url":"https://github.com/robquesada/misingo/pull/33","diff_url":"https://github.com/robquesada/misingo/pull/33.diff","patch_url":"https://github.com/robquesada/misingo/pull/33.patch","issue_url":"https://api.github.com/repos/robquesada/misingo/issues/33","number":33,"state":"open","locked":false,"title":"Ft 4 Lost reports module refactor","user":{"login":"robquesada","id":8563475,"avatar_url":"https://avatars.githubusercontent.com/u/8563475?v=3","gravatar_id":"","url":"https://api.github.com/users/robquesada","html_url":"https://github.com/robquesada","followers_url":"https://api.github.com/users/robquesada/followers","following_url":"https://api.github.com/users/robquesada/following{/other_user}","gists_url":"https://api.github.com/users/robquesada/gists{/gist_id}","starred_url":"https://api.github.com/users/robquesada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robquesada/subscriptions","organizations_url":"https://api.github.com/users/robquesada/orgs","repos_url":"https://api.github.com/users/robquesada/repos","events_url":"https://api.github.com/users/robquesada/events{/privacy}","received_events_url":"https://api.github.com/users/robquesada/received_events","type":"User","site_admin":false},"body":"- [x] Refactor pet, user and lost reports associations. Remove pet controller, only use lost report controller with nested attributes.\r\n- [x] Redesign lost pet 'show' page\r\n- [x] Update flyer design\r\n- [x] Fix styles when description is too large\r\n- [x] Fix JS issues with breed selection and Devise actions\r\n- [x] Fix Rspec tests\r\n- [x] Remove pet views and controller\r\n\r\nNew flyer:\r\n<img width=\"502\" alt=\"screen shot 2015-10-13 at 3 11 48 pm\" src=\"https://cloud.githubusercontent.com/assets/8563475/10468543/cd57e3d2-71bc-11e5-9934-03cda6cca4cc.png\">\r\n\r\nNew lost report 'show' page:\r\n<img width=\"977\" alt=\"screen shot 2015-10-14 at 4 55 04 pm\" src=\"https://cloud.githubusercontent.com/assets/8563475/10500313/6c113b04-7294-11e5-8579-4dba4d95eb34.png\">\r\n","created_at":"2015-10-12T20:23:50Z","updated_at":"2015-10-15T21:30:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6fc253f0ec106bd49b4b06583ec3b3ec34d9b199","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/robquesada/misingo/pulls/33/commits","review_comments_url":"https://api.github.com/repos/robquesada/misingo/pulls/33/comments","review_comment_url":"https://api.github.com/repos/robquesada/misingo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/robquesada/misingo/issues/33/comments","statuses_url":"https://api.github.com/repos/robquesada/misingo/statuses/dd0bc6aa3aded2343c2356c1b2d51ba163921f31","head":{"label":"robquesada:ft-4-change-lost-report-form","ref":"ft-4-change-lost-report-form","sha":"dd0bc6aa3aded2343c2356c1b2d51ba163921f31","user":{"login":"robquesada","id":8563475,"avatar_url":"https://avatars.githubusercontent.com/u/8563475?v=3","gravatar_id":"","url":"https://api.github.com/users/robquesada","html_url":"https://github.com/robquesada","followers_url":"https://api.github.com/users/robquesada/followers","following_url":"https://api.github.com/users/robquesada/following{/other_user}","gists_url":"https://api.github.com/users/robquesada/gists{/gist_id}","starred_url":"https://api.github.com/users/robquesada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robquesada/subscriptions","organizations_url":"https://api.github.com/users/robquesada/orgs","repos_url":"https://api.github.com/users/robquesada/repos","events_url":"https://api.github.com/users/robquesada/events{/privacy}","received_events_url":"https://api.github.com/users/robquesada/received_events","type":"User","site_admin":false},"repo":{"id":24775360,"name":"misingo","full_name":"robquesada/misingo","owner":{"login":"robquesada","id":8563475,"avatar_url":"https://avatars.githubusercontent.com/u/8563475?v=3","gravatar_id":"","url":"https://api.github.com/users/robquesada","html_url":"https://github.com/robquesada","followers_url":"https://api.github.com/users/robquesada/followers","following_url":"https://api.github.com/users/robquesada/following{/other_user}","gists_url":"https://api.github.com/users/robquesada/gists{/gist_id}","starred_url":"https://api.github.com/users/robquesada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robquesada/subscriptions","organizations_url":"https://api.github.com/users/robquesada/orgs","repos_url":"https://api.github.com/users/robquesada/repos","events_url":"https://api.github.com/users/robquesada/events{/privacy}","received_events_url":"https://api.github.com/users/robquesada/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/robquesada/misingo","description":"Ruby on Rails","fork":false,"url":"https://api.github.com/repos/robquesada/misingo","forks_url":"https://api.github.com/repos/robquesada/misingo/forks","keys_url":"https://api.github.com/repos/robquesada/misingo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/robquesada/misingo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/robquesada/misingo/teams","hooks_url":"https://api.github.com/repos/robquesada/misingo/hooks","issue_events_url":"https://api.github.com/repos/robquesada/misingo/issues/events{/number}","events_url":"https://api.github.com/repos/robquesada/misingo/events","assignees_url":"https://api.github.com/repos/robquesada/misingo/assignees{/user}","branches_url":"https://api.github.com/repos/robquesada/misingo/branches{/branch}","tags_url":"https://api.github.com/repos/robquesada/misingo/tags","blobs_url":"https://api.github.com/repos/robquesada/misingo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/robquesada/misingo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/robquesada/misingo/git/refs{/sha}","trees_url":"https://api.github.com/repos/robquesada/misingo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/robquesada/misingo/statuses/{sha}","languages_url":"https://api.github.com/repos/robquesada/misingo/languages","stargazers_url":"https://api.github.com/repos/robquesada/misingo/stargazers","contributors_url":"https://api.github.com/repos/robquesada/misingo/contributors","subscribers_url":"https://api.github.com/repos/robquesada/misingo/subscribers","subscription_url":"https://api.github.com/repos/robquesada/misingo/subscription","commits_url":"https://api.github.com/repos/robquesada/misingo/commits{/sha}","git_commits_url":"https://api.github.com/repos/robquesada/misingo/git/commits{/sha}","comments_url":"https://api.github.com/repos/robquesada/misingo/comments{/number}","issue_comment_url":"https://api.github.com/repos/robquesada/misingo/issues/comments{/number}","contents_url":"https://api.github.com/repos/robquesada/misingo/contents/{+path}","compare_url":"https://api.github.com/repos/robquesada/misingo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/robquesada/misingo/merges","archive_url":"https://api.github.com/repos/robquesada/misingo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/robquesada/misingo/downloads","issues_url":"https://api.github.com/repos/robquesada/misingo/issues{/number}","pulls_url":"https://api.github.com/repos/robquesada/misingo/pulls{/number}","milestones_url":"https://api.github.com/repos/robquesada/misingo/milestones{/number}","notifications_url":"https://api.github.com/repos/robquesada/misingo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/robquesada/misingo/labels{/name}","releases_url":"https://api.github.com/repos/robquesada/misingo/releases{/id}","created_at":"2014-10-03T22:09:26Z","updated_at":"2015-10-05T22:04:56Z","pushed_at":"2015-10-15T20:29:36Z","git_url":"git://github.com/robquesada/misingo.git","ssh_url":"git@github.com:robquesada/misingo.git","clone_url":"https://github.com/robquesada/misingo.git","svn_url":"https://github.com/robquesada/misingo","homepage":"http://www.misingo.com","size":4572,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"base":{"label":"robquesada:develop","ref":"develop","sha":"44198af4664aa28204b1e074eb181de05a4b43fd","user":{"login":"robquesada","id":8563475,"avatar_url":"https://avatars.githubusercontent.com/u/8563475?v=3","gravatar_id":"","url":"https://api.github.com/users/robquesada","html_url":"https://github.com/robquesada","followers_url":"https://api.github.com/users/robquesada/followers","following_url":"https://api.github.com/users/robquesada/following{/other_user}","gists_url":"https://api.github.com/users/robquesada/gists{/gist_id}","starred_url":"https://api.github.com/users/robquesada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robquesada/subscriptions","organizations_url":"https://api.github.com/users/robquesada/orgs","repos_url":"https://api.github.com/users/robquesada/repos","events_url":"https://api.github.com/users/robquesada/events{/privacy}","received_events_url":"https://api.github.com/users/robquesada/received_events","type":"User","site_admin":false},"repo":{"id":24775360,"name":"misingo","full_name":"robquesada/misingo","owner":{"login":"robquesada","id":8563475,"avatar_url":"https://avatars.githubusercontent.com/u/8563475?v=3","gravatar_id":"","url":"https://api.github.com/users/robquesada","html_url":"https://github.com/robquesada","followers_url":"https://api.github.com/users/robquesada/followers","following_url":"https://api.github.com/users/robquesada/following{/other_user}","gists_url":"https://api.github.com/users/robquesada/gists{/gist_id}","starred_url":"https://api.github.com/users/robquesada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robquesada/subscriptions","organizations_url":"https://api.github.com/users/robquesada/orgs","repos_url":"https://api.github.com/users/robquesada/repos","events_url":"https://api.github.com/users/robquesada/events{/privacy}","received_events_url":"https://api.github.com/users/robquesada/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/robquesada/misingo","description":"Ruby on Rails","fork":false,"url":"https://api.github.com/repos/robquesada/misingo","forks_url":"https://api.github.com/repos/robquesada/misingo/forks","keys_url":"https://api.github.com/repos/robquesada/misingo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/robquesada/misingo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/robquesada/misingo/teams","hooks_url":"https://api.github.com/repos/robquesada/misingo/hooks","issue_events_url":"https://api.github.com/repos/robquesada/misingo/issues/events{/number}","events_url":"https://api.github.com/repos/robquesada/misingo/events","assignees_url":"https://api.github.com/repos/robquesada/misingo/assignees{/user}","branches_url":"https://api.github.com/repos/robquesada/misingo/branches{/branch}","tags_url":"https://api.github.com/repos/robquesada/misingo/tags","blobs_url":"https://api.github.com/repos/robquesada/misingo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/robquesada/misingo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/robquesada/misingo/git/refs{/sha}","trees_url":"https://api.github.com/repos/robquesada/misingo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/robquesada/misingo/statuses/{sha}","languages_url":"https://api.github.com/repos/robquesada/misingo/languages","stargazers_url":"https://api.github.com/repos/robquesada/misingo/stargazers","contributors_url":"https://api.github.com/repos/robquesada/misingo/contributors","subscribers_url":"https://api.github.com/repos/robquesada/misingo/subscribers","subscription_url":"https://api.github.com/repos/robquesada/misingo/subscription","commits_url":"https://api.github.com/repos/robquesada/misingo/commits{/sha}","git_commits_url":"https://api.github.com/repos/robquesada/misingo/git/commits{/sha}","comments_url":"https://api.github.com/repos/robquesada/misingo/comments{/number}","issue_comment_url":"https://api.github.com/repos/robquesada/misingo/issues/comments{/number}","contents_url":"https://api.github.com/repos/robquesada/misingo/contents/{+path}","compare_url":"https://api.github.com/repos/robquesada/misingo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/robquesada/misingo/merges","archive_url":"https://api.github.com/repos/robquesada/misingo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/robquesada/misingo/downloads","issues_url":"https://api.github.com/repos/robquesada/misingo/issues{/number}","pulls_url":"https://api.github.com/repos/robquesada/misingo/pulls{/number}","milestones_url":"https://api.github.com/repos/robquesada/misingo/milestones{/number}","notifications_url":"https://api.github.com/repos/robquesada/misingo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/robquesada/misingo/labels{/name}","releases_url":"https://api.github.com/repos/robquesada/misingo/releases{/id}","created_at":"2014-10-03T22:09:26Z","updated_at":"2015-10-05T22:04:56Z","pushed_at":"2015-10-15T20:29:36Z","git_url":"git://github.com/robquesada/misingo.git","ssh_url":"git@github.com:robquesada/misingo.git","clone_url":"https://github.com/robquesada/misingo.git","svn_url":"https://github.com/robquesada/misingo","homepage":"http://www.misingo.com","size":4572,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/robquesada/misingo/pulls/33"},"html":{"href":"https://github.com/robquesada/misingo/pull/33"},"issue":{"href":"https://api.github.com/repos/robquesada/misingo/issues/33"},"comments":{"href":"https://api.github.com/repos/robquesada/misingo/issues/33/comments"},"review_comments":{"href":"https://api.github.com/repos/robquesada/misingo/pulls/33/comments"},"review_comment":{"href":"https://api.github.com/repos/robquesada/misingo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/robquesada/misingo/pulls/33/commits"},"statuses":{"href":"https://api.github.com/repos/robquesada/misingo/statuses/dd0bc6aa3aded2343c2356c1b2d51ba163921f31"}}}}