{"action":"created","comment":{"url":"https://api.github.com/repos/symfony/symfony/pulls/comments/36576992","id":36576992,"diff_hunk":"@@ -125,7 +125,7 @@ protected function getDumpHeader()\n     rxEsc = /([.*+?^${}()|\\[\\]\\/\\\\])/g,\n     idRx = /\\bsf-dump-\\d+-ref[012]\\w+\\b/;\n \n-doc.documentElement.firstChild.appendChild(refStyle);\n+doc.getElementsByTagName('head')[0].appendChild(refStyle);","path":"src/Symfony/Component/VarDumper/Dumper/HtmlDumper.php","position":5,"original_position":5,"commit_id":"fd9613c9630bc7e7364c3d7be71e3a3851bcd054","original_commit_id":"fd9613c9630bc7e7364c3d7be71e3a3851bcd054","user":{"login":"aitboudad","id":1753742,"avatar_url":"https://avatars.githubusercontent.com/u/1753742?v=3","gravatar_id":"","url":"https://api.github.com/users/aitboudad","html_url":"https://github.com/aitboudad","followers_url":"https://api.github.com/users/aitboudad/followers","following_url":"https://api.github.com/users/aitboudad/following{/other_user}","gists_url":"https://api.github.com/users/aitboudad/gists{/gist_id}","starred_url":"https://api.github.com/users/aitboudad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aitboudad/subscriptions","organizations_url":"https://api.github.com/users/aitboudad/orgs","repos_url":"https://api.github.com/users/aitboudad/repos","events_url":"https://api.github.com/users/aitboudad/events{/privacy}","received_events_url":"https://api.github.com/users/aitboudad/received_events","type":"User","site_admin":false},"body":"what's about:\r\n```js\r\n(doc.getElementsByTagName('head')[0] || doc.getElementsByTagName('body')[0]).appendChild(refStyle);\r\n```","created_at":"2015-08-08T10:06:08Z","updated_at":"2015-08-08T10:06:08Z","html_url":"https://github.com/symfony/symfony/pull/15493#discussion_r36576992","pull_request_url":"https://api.github.com/repos/symfony/symfony/pulls/15493","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/36576992"},"html":{"href":"https://github.com/symfony/symfony/pull/15493#discussion_r36576992"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony/pulls/15493"}}},"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/15493","id":41949828,"html_url":"https://github.com/symfony/symfony/pull/15493","diff_url":"https://github.com/symfony/symfony/pull/15493.diff","patch_url":"https://github.com/symfony/symfony/pull/15493.patch","issue_url":"https://api.github.com/repos/symfony/symfony/issues/15493","number":15493,"state":"open","locked":false,"title":"[VarDumper] fixed HtmlDumper to target specific the head tag","user":{"login":"SaschaDens","id":6088464,"avatar_url":"https://avatars.githubusercontent.com/u/6088464?v=3","gravatar_id":"","url":"https://api.github.com/users/SaschaDens","html_url":"https://github.com/SaschaDens","followers_url":"https://api.github.com/users/SaschaDens/followers","following_url":"https://api.github.com/users/SaschaDens/following{/other_user}","gists_url":"https://api.github.com/users/SaschaDens/gists{/gist_id}","starred_url":"https://api.github.com/users/SaschaDens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SaschaDens/subscriptions","organizations_url":"https://api.github.com/users/SaschaDens/orgs","repos_url":"https://api.github.com/users/SaschaDens/repos","events_url":"https://api.github.com/users/SaschaDens/events{/privacy}","received_events_url":"https://api.github.com/users/SaschaDens/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Bug fix?      | yes\r\n| New feature?  | no\r\n| BC breaks?    | no\r\n| Deprecations? | no\r\n| Tests pass?   | yes\r\n| Fixed tickets | -\r\n| License       | MIT\r\n| Doc PR        | -\r\n\r\nOn our webportals we faced the issue that we received the following js error: `Uncaught HierarchyRequestError: Failed to execute 'appendChild' on 'Node': This node type does not support this method.` and then the full dump is displaying without the arrows to collapse.\r\n\r\nTo simulate this error I've created a [Gist](https://gist.github.com/SaschaDens/0c5cc610ba168f6206d2) and as reference used [Adventures With document.documentElement.firstChild](https://robert.accettura.com/blog/2009/12/12/adventures-with-document-documentelement-firstchild/)\r\n\r\nThis PR specifically targets the head by using `document.getElementsByTagName('head')[0]` instead of `document.documentElement.firstChild`","created_at":"2015-08-08T06:50:06Z","updated_at":"2015-08-08T10:06:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b800d01a14622852df9c2757b3abc33e3a513127","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/symfony/symfony/pulls/15493/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony/pulls/15493/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/15493/comments","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/fd9613c9630bc7e7364c3d7be71e3a3851bcd054","head":{"label":"SaschaDens:2.6","ref":"2.6","sha":"fd9613c9630bc7e7364c3d7be71e3a3851bcd054","user":{"login":"SaschaDens","id":6088464,"avatar_url":"https://avatars.githubusercontent.com/u/6088464?v=3","gravatar_id":"","url":"https://api.github.com/users/SaschaDens","html_url":"https://github.com/SaschaDens","followers_url":"https://api.github.com/users/SaschaDens/followers","following_url":"https://api.github.com/users/SaschaDens/following{/other_user}","gists_url":"https://api.github.com/users/SaschaDens/gists{/gist_id}","starred_url":"https://api.github.com/users/SaschaDens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SaschaDens/subscriptions","organizations_url":"https://api.github.com/users/SaschaDens/orgs","repos_url":"https://api.github.com/users/SaschaDens/repos","events_url":"https://api.github.com/users/SaschaDens/events{/privacy}","received_events_url":"https://api.github.com/users/SaschaDens/received_events","type":"User","site_admin":false},"repo":{"id":40392335,"name":"symfony","full_name":"SaschaDens/symfony","owner":{"login":"SaschaDens","id":6088464,"avatar_url":"https://avatars.githubusercontent.com/u/6088464?v=3","gravatar_id":"","url":"https://api.github.com/users/SaschaDens","html_url":"https://github.com/SaschaDens","followers_url":"https://api.github.com/users/SaschaDens/followers","following_url":"https://api.github.com/users/SaschaDens/following{/other_user}","gists_url":"https://api.github.com/users/SaschaDens/gists{/gist_id}","starred_url":"https://api.github.com/users/SaschaDens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SaschaDens/subscriptions","organizations_url":"https://api.github.com/users/SaschaDens/orgs","repos_url":"https://api.github.com/users/SaschaDens/repos","events_url":"https://api.github.com/users/SaschaDens/events{/privacy}","received_events_url":"https://api.github.com/users/SaschaDens/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SaschaDens/symfony","description":"The Symfony PHP framework","fork":true,"url":"https://api.github.com/repos/SaschaDens/symfony","forks_url":"https://api.github.com/repos/SaschaDens/symfony/forks","keys_url":"https://api.github.com/repos/SaschaDens/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SaschaDens/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SaschaDens/symfony/teams","hooks_url":"https://api.github.com/repos/SaschaDens/symfony/hooks","issue_events_url":"https://api.github.com/repos/SaschaDens/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/SaschaDens/symfony/events","assignees_url":"https://api.github.com/repos/SaschaDens/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/SaschaDens/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/SaschaDens/symfony/tags","blobs_url":"https://api.github.com/repos/SaschaDens/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SaschaDens/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SaschaDens/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/SaschaDens/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SaschaDens/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/SaschaDens/symfony/languages","stargazers_url":"https://api.github.com/repos/SaschaDens/symfony/stargazers","contributors_url":"https://api.github.com/repos/SaschaDens/symfony/contributors","subscribers_url":"https://api.github.com/repos/SaschaDens/symfony/subscribers","subscription_url":"https://api.github.com/repos/SaschaDens/symfony/subscription","commits_url":"https://api.github.com/repos/SaschaDens/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/SaschaDens/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/SaschaDens/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/SaschaDens/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/SaschaDens/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/SaschaDens/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SaschaDens/symfony/merges","archive_url":"https://api.github.com/repos/SaschaDens/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SaschaDens/symfony/downloads","issues_url":"https://api.github.com/repos/SaschaDens/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/SaschaDens/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/SaschaDens/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/SaschaDens/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SaschaDens/symfony/labels{/name}","releases_url":"https://api.github.com/repos/SaschaDens/symfony/releases{/id}","created_at":"2015-08-08T05:13:10Z","updated_at":"2015-08-08T05:13:25Z","pushed_at":"2015-08-08T06:12:37Z","git_url":"git://github.com/SaschaDens/symfony.git","ssh_url":"git@github.com:SaschaDens/symfony.git","clone_url":"https://github.com/SaschaDens/symfony.git","svn_url":"https://github.com/SaschaDens/symfony","homepage":"symfony.com","size":1198640,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"2.8"}},"base":{"label":"symfony:2.6","ref":"2.6","sha":"c6ab380a577e7bfb8db6e6f3105f470f97c83235","user":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":458058,"name":"symfony","full_name":"symfony/symfony","owner":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/symfony","description":"The Symfony PHP framework","fork":false,"url":"https://api.github.com/repos/symfony/symfony","forks_url":"https://api.github.com/repos/symfony/symfony/forks","keys_url":"https://api.github.com/repos/symfony/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony/teams","hooks_url":"https://api.github.com/repos/symfony/symfony/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony/events","assignees_url":"https://api.github.com/repos/symfony/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony/tags","blobs_url":"https://api.github.com/repos/symfony/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony/subscription","commits_url":"https://api.github.com/repos/symfony/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony/merges","archive_url":"https://api.github.com/repos/symfony/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony/downloads","issues_url":"https://api.github.com/repos/symfony/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony/releases{/id}","created_at":"2010-01-04T14:21:21Z","updated_at":"2015-08-07T12:48:27Z","pushed_at":"2015-08-08T06:50:08Z","git_url":"git://github.com/symfony/symfony.git","ssh_url":"git@github.com:symfony/symfony.git","clone_url":"https://github.com/symfony/symfony.git","svn_url":"https://github.com/symfony/symfony","homepage":"symfony.com","size":1198640,"stargazers_count":10603,"watchers_count":10603,"language":"PHP","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":4202,"mirror_url":null,"open_issues_count":887,"forks":4202,"open_issues":887,"watchers":10603,"default_branch":"2.8"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/15493"},"html":{"href":"https://github.com/symfony/symfony/pull/15493"},"issue":{"href":"https://api.github.com/repos/symfony/symfony/issues/15493"},"comments":{"href":"https://api.github.com/repos/symfony/symfony/issues/15493/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony/pulls/15493/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony/pulls/15493/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony/statuses/fd9613c9630bc7e7364c3d7be71e3a3851bcd054"}}}}