{"action":"closed","number":4629,"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/4629","id":51442794,"html_url":"https://github.com/dotnet/corefx/pull/4629","diff_url":"https://github.com/dotnet/corefx/pull/4629.diff","patch_url":"https://github.com/dotnet/corefx/pull/4629.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/4629","number":4629,"state":"closed","locked":false,"title":"Handle overflow in BigInteger.Pow","user":{"login":"axelheer","id":3988385,"avatar_url":"https://avatars.githubusercontent.com/u/3988385?v=3","gravatar_id":"","url":"https://api.github.com/users/axelheer","html_url":"https://github.com/axelheer","followers_url":"https://api.github.com/users/axelheer/followers","following_url":"https://api.github.com/users/axelheer/following{/other_user}","gists_url":"https://api.github.com/users/axelheer/gists{/gist_id}","starred_url":"https://api.github.com/users/axelheer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/axelheer/subscriptions","organizations_url":"https://api.github.com/users/axelheer/orgs","repos_url":"https://api.github.com/users/axelheer/repos","events_url":"https://api.github.com/users/axelheer/events{/privacy}","received_events_url":"https://api.github.com/users/axelheer/received_events","type":"User","site_admin":false},"body":"Calling Pow on a big integer with a very large exponent leads naturally\r\nto an overflow, which should result in an ordinary OverflowException.\r\nThe current implementation estimates the result buffer, which leads to\r\nan unexpected behavior, since that estimate overflows silently. Adding\r\n`checked` to the estimate fixes this.","created_at":"2015-11-21T14:59:47Z","updated_at":"2015-11-21T16:38:12Z","closed_at":"2015-11-21T16:38:12Z","merged_at":"2015-11-21T16:38:12Z","merge_commit_sha":"5a0105d843ff2f840bc67e4fac48a6d69ffbdf74","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/4629/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/4629/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/4629/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/d50a00dbbddabb5bef8e41c26bac1d9ea799ddbd","head":{"label":"axelheer:biginteger-fixpow","ref":"biginteger-fixpow","sha":"d50a00dbbddabb5bef8e41c26bac1d9ea799ddbd","user":{"login":"axelheer","id":3988385,"avatar_url":"https://avatars.githubusercontent.com/u/3988385?v=3","gravatar_id":"","url":"https://api.github.com/users/axelheer","html_url":"https://github.com/axelheer","followers_url":"https://api.github.com/users/axelheer/followers","following_url":"https://api.github.com/users/axelheer/following{/other_user}","gists_url":"https://api.github.com/users/axelheer/gists{/gist_id}","starred_url":"https://api.github.com/users/axelheer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/axelheer/subscriptions","organizations_url":"https://api.github.com/users/axelheer/orgs","repos_url":"https://api.github.com/users/axelheer/repos","events_url":"https://api.github.com/users/axelheer/events{/privacy}","received_events_url":"https://api.github.com/users/axelheer/received_events","type":"User","site_admin":false},"repo":{"id":34116891,"name":"corefx","full_name":"axelheer/corefx","owner":{"login":"axelheer","id":3988385,"avatar_url":"https://avatars.githubusercontent.com/u/3988385?v=3","gravatar_id":"","url":"https://api.github.com/users/axelheer","html_url":"https://github.com/axelheer","followers_url":"https://api.github.com/users/axelheer/followers","following_url":"https://api.github.com/users/axelheer/following{/other_user}","gists_url":"https://api.github.com/users/axelheer/gists{/gist_id}","starred_url":"https://api.github.com/users/axelheer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/axelheer/subscriptions","organizations_url":"https://api.github.com/users/axelheer/orgs","repos_url":"https://api.github.com/users/axelheer/repos","events_url":"https://api.github.com/users/axelheer/events{/privacy}","received_events_url":"https://api.github.com/users/axelheer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/axelheer/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":true,"url":"https://api.github.com/repos/axelheer/corefx","forks_url":"https://api.github.com/repos/axelheer/corefx/forks","keys_url":"https://api.github.com/repos/axelheer/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/axelheer/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/axelheer/corefx/teams","hooks_url":"https://api.github.com/repos/axelheer/corefx/hooks","issue_events_url":"https://api.github.com/repos/axelheer/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/axelheer/corefx/events","assignees_url":"https://api.github.com/repos/axelheer/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/axelheer/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/axelheer/corefx/tags","blobs_url":"https://api.github.com/repos/axelheer/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/axelheer/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/axelheer/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/axelheer/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/axelheer/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/axelheer/corefx/languages","stargazers_url":"https://api.github.com/repos/axelheer/corefx/stargazers","contributors_url":"https://api.github.com/repos/axelheer/corefx/contributors","subscribers_url":"https://api.github.com/repos/axelheer/corefx/subscribers","subscription_url":"https://api.github.com/repos/axelheer/corefx/subscription","commits_url":"https://api.github.com/repos/axelheer/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/axelheer/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/axelheer/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/axelheer/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/axelheer/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/axelheer/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/axelheer/corefx/merges","archive_url":"https://api.github.com/repos/axelheer/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/axelheer/corefx/downloads","issues_url":"https://api.github.com/repos/axelheer/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/axelheer/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/axelheer/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/axelheer/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/axelheer/corefx/labels{/name}","releases_url":"https://api.github.com/repos/axelheer/corefx/releases{/id}","created_at":"2015-04-17T13:03:03Z","updated_at":"2015-04-30T09:05:49Z","pushed_at":"2015-11-21T14:59:05Z","git_url":"git://github.com/axelheer/corefx.git","ssh_url":"git@github.com:axelheer/corefx.git","clone_url":"https://github.com/axelheer/corefx.git","svn_url":"https://github.com/axelheer/corefx","homepage":"","size":40250,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"13746088c5fa61a028224582952c95e07ff2e633","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","created_at":"2014-11-06T23:42:48Z","updated_at":"2015-11-21T13:56:35Z","pushed_at":"2015-11-21T16:38:12Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"http://dotnet.github.io/","size":50012,"stargazers_count":8651,"watchers_count":8651,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1939,"mirror_url":null,"open_issues_count":704,"forks":1939,"open_issues":704,"watchers":8651,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/4629"},"html":{"href":"https://github.com/dotnet/corefx/pull/4629"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/4629"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/4629/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/4629/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/4629/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/d50a00dbbddabb5bef8e41c26bac1d9ea799ddbd"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"stephentoub","id":2642209,"avatar_url":"https://avatars.githubusercontent.com/u/2642209?v=3","gravatar_id":"","url":"https://api.github.com/users/stephentoub","html_url":"https://github.com/stephentoub","followers_url":"https://api.github.com/users/stephentoub/followers","following_url":"https://api.github.com/users/stephentoub/following{/other_user}","gists_url":"https://api.github.com/users/stephentoub/gists{/gist_id}","starred_url":"https://api.github.com/users/stephentoub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephentoub/subscriptions","organizations_url":"https://api.github.com/users/stephentoub/orgs","repos_url":"https://api.github.com/users/stephentoub/repos","events_url":"https://api.github.com/users/stephentoub/events{/privacy}","received_events_url":"https://api.github.com/users/stephentoub/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":1,"additions":17,"deletions":4,"changed_files":2}}