{"action":"closed","issue":{"url":"https://api.github.com/repos/tass-belgium/picotcp/issues/292","labels_url":"https://api.github.com/repos/tass-belgium/picotcp/issues/292/labels{/name}","comments_url":"https://api.github.com/repos/tass-belgium/picotcp/issues/292/comments","events_url":"https://api.github.com/repos/tass-belgium/picotcp/issues/292/events","html_url":"https://github.com/tass-belgium/picotcp/issues/292","id":96061965,"number":292,"title":"[PPP] Lcp configuration request after configuration reject message is not correct","user":{"login":"TassThomas","id":7223968,"avatar_url":"https://avatars.githubusercontent.com/u/7223968?v=3","gravatar_id":"","url":"https://api.github.com/users/TassThomas","html_url":"https://github.com/TassThomas","followers_url":"https://api.github.com/users/TassThomas/followers","following_url":"https://api.github.com/users/TassThomas/following{/other_user}","gists_url":"https://api.github.com/users/TassThomas/gists{/gist_id}","starred_url":"https://api.github.com/users/TassThomas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TassThomas/subscriptions","organizations_url":"https://api.github.com/users/TassThomas/orgs","repos_url":"https://api.github.com/users/TassThomas/repos","events_url":"https://api.github.com/users/TassThomas/events{/privacy}","received_events_url":"https://api.github.com/users/TassThomas/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/tass-belgium/picotcp/labels/bug","name":"bug","color":"fc2929"},{"url":"https://api.github.com/repos/tass-belgium/picotcp/labels/RFC%20Violation","name":"RFC Violation","color":"FF19e7"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2015-07-20T13:19:35Z","updated_at":"2015-09-22T12:54:34Z","closed_at":"2015-09-22T12:54:34Z","body":"When trying to negotiate an LCP connection with pico, when we send a configuration reject message to pico it sends a configuration request back still containing the LCP option that was put into the LCP configuration reject message. This is not correct according to RFC1661: 'Reception of a valid Configure-Reject indicates that when a new Configure-Request is sent, it MUST NOT include any of the Configuration Options listed in the Configure-Reject.'\r\n\r\nReproduce by writing a unit-test for this or by using the PPP RF implementation using:\r\n./run.sh --test LCPsetupACK/REJ testcases/lcp_test.txt\r\n"}}