{"action":"created","comment":{"url":"https://api.github.com/repos/alphasights/paint/pulls/comments/37517249","id":37517249,"diff_hunk":"@@ -41,8 +46,10 @@ $include-html-paint-tabs: true !default;\n \n   ul {\n     margin: 0;\n+    overflow-y: hidden;\n     padding: 0;\n     position: relative;\n+    white-space: nowrap;","path":"components/_tab.scss","position":22,"original_position":22,"commit_id":"d6b642cd323a56bbeb82e84a816c3352020dc55d","original_commit_id":"d6b642cd323a56bbeb82e84a816c3352020dc55d","user":{"login":"deioo","id":1321353,"avatar_url":"https://avatars.githubusercontent.com/u/1321353?v=3","gravatar_id":"","url":"https://api.github.com/users/deioo","html_url":"https://github.com/deioo","followers_url":"https://api.github.com/users/deioo/followers","following_url":"https://api.github.com/users/deioo/following{/other_user}","gists_url":"https://api.github.com/users/deioo/gists{/gist_id}","starred_url":"https://api.github.com/users/deioo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deioo/subscriptions","organizations_url":"https://api.github.com/users/deioo/orgs","repos_url":"https://api.github.com/users/deioo/repos","events_url":"https://api.github.com/users/deioo/events{/privacy}","received_events_url":"https://api.github.com/users/deioo/received_events","type":"User","site_admin":false},"body":"We already handle this for the small screens, should we remove the @media call below as well?","created_at":"2015-08-20T10:58:58Z","updated_at":"2015-08-20T10:58:58Z","html_url":"https://github.com/alphasights/paint/pull/105#discussion_r37517249","pull_request_url":"https://api.github.com/repos/alphasights/paint/pulls/105","_links":{"self":{"href":"https://api.github.com/repos/alphasights/paint/pulls/comments/37517249"},"html":{"href":"https://github.com/alphasights/paint/pull/105#discussion_r37517249"},"pull_request":{"href":"https://api.github.com/repos/alphasights/paint/pulls/105"}}},"pull_request":{"url":"https://api.github.com/repos/alphasights/paint/pulls/105","id":42882106,"html_url":"https://github.com/alphasights/paint/pull/105","diff_url":"https://github.com/alphasights/paint/pull/105.diff","patch_url":"https://github.com/alphasights/paint/pull/105.patch","issue_url":"https://api.github.com/repos/alphasights/paint/issues/105","number":105,"state":"open","locked":false,"title":"Improve tab component to be more flexible","user":{"login":"carlosepp","id":497142,"avatar_url":"https://avatars.githubusercontent.com/u/497142?v=3","gravatar_id":"","url":"https://api.github.com/users/carlosepp","html_url":"https://github.com/carlosepp","followers_url":"https://api.github.com/users/carlosepp/followers","following_url":"https://api.github.com/users/carlosepp/following{/other_user}","gists_url":"https://api.github.com/users/carlosepp/gists{/gist_id}","starred_url":"https://api.github.com/users/carlosepp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carlosepp/subscriptions","organizations_url":"https://api.github.com/users/carlosepp/orgs","repos_url":"https://api.github.com/users/carlosepp/repos","events_url":"https://api.github.com/users/carlosepp/events{/privacy}","received_events_url":"https://api.github.com/users/carlosepp/received_events","type":"User","site_admin":false},"body":"Turns out that some external plugins apply the active class in the li rather than on the anchor item, this PR allows to make the component flexible enough to handle such scenarios.\r\n\r\nAlso turns out that the active class also varies from project to project, so I added a setting to be able to customize it.","created_at":"2015-08-20T01:10:17Z","updated_at":"2015-08-20T10:58:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b30b68a02c620a609b41a20d49b516baaad4406a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/alphasights/paint/pulls/105/commits","review_comments_url":"https://api.github.com/repos/alphasights/paint/pulls/105/comments","review_comment_url":"https://api.github.com/repos/alphasights/paint/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alphasights/paint/issues/105/comments","statuses_url":"https://api.github.com/repos/alphasights/paint/statuses/d6b642cd323a56bbeb82e84a816c3352020dc55d","head":{"label":"alphasights:feature/cepp/improve-tab-component","ref":"feature/cepp/improve-tab-component","sha":"d6b642cd323a56bbeb82e84a816c3352020dc55d","user":{"login":"alphasights","id":41216,"avatar_url":"https://avatars.githubusercontent.com/u/41216?v=3","gravatar_id":"","url":"https://api.github.com/users/alphasights","html_url":"https://github.com/alphasights","followers_url":"https://api.github.com/users/alphasights/followers","following_url":"https://api.github.com/users/alphasights/following{/other_user}","gists_url":"https://api.github.com/users/alphasights/gists{/gist_id}","starred_url":"https://api.github.com/users/alphasights/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphasights/subscriptions","organizations_url":"https://api.github.com/users/alphasights/orgs","repos_url":"https://api.github.com/users/alphasights/repos","events_url":"https://api.github.com/users/alphasights/events{/privacy}","received_events_url":"https://api.github.com/users/alphasights/received_events","type":"Organization","site_admin":false},"repo":{"id":23459758,"name":"paint","full_name":"alphasights/paint","owner":{"login":"alphasights","id":41216,"avatar_url":"https://avatars.githubusercontent.com/u/41216?v=3","gravatar_id":"","url":"https://api.github.com/users/alphasights","html_url":"https://github.com/alphasights","followers_url":"https://api.github.com/users/alphasights/followers","following_url":"https://api.github.com/users/alphasights/following{/other_user}","gists_url":"https://api.github.com/users/alphasights/gists{/gist_id}","starred_url":"https://api.github.com/users/alphasights/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphasights/subscriptions","organizations_url":"https://api.github.com/users/alphasights/orgs","repos_url":"https://api.github.com/users/alphasights/repos","events_url":"https://api.github.com/users/alphasights/events{/privacy}","received_events_url":"https://api.github.com/users/alphasights/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphasights/paint","description":"CSS framework like Bootstrap but more modern and delivered through SCSS mixins","fork":false,"url":"https://api.github.com/repos/alphasights/paint","forks_url":"https://api.github.com/repos/alphasights/paint/forks","keys_url":"https://api.github.com/repos/alphasights/paint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphasights/paint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphasights/paint/teams","hooks_url":"https://api.github.com/repos/alphasights/paint/hooks","issue_events_url":"https://api.github.com/repos/alphasights/paint/issues/events{/number}","events_url":"https://api.github.com/repos/alphasights/paint/events","assignees_url":"https://api.github.com/repos/alphasights/paint/assignees{/user}","branches_url":"https://api.github.com/repos/alphasights/paint/branches{/branch}","tags_url":"https://api.github.com/repos/alphasights/paint/tags","blobs_url":"https://api.github.com/repos/alphasights/paint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphasights/paint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphasights/paint/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphasights/paint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphasights/paint/statuses/{sha}","languages_url":"https://api.github.com/repos/alphasights/paint/languages","stargazers_url":"https://api.github.com/repos/alphasights/paint/stargazers","contributors_url":"https://api.github.com/repos/alphasights/paint/contributors","subscribers_url":"https://api.github.com/repos/alphasights/paint/subscribers","subscription_url":"https://api.github.com/repos/alphasights/paint/subscription","commits_url":"https://api.github.com/repos/alphasights/paint/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphasights/paint/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphasights/paint/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphasights/paint/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphasights/paint/contents/{+path}","compare_url":"https://api.github.com/repos/alphasights/paint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphasights/paint/merges","archive_url":"https://api.github.com/repos/alphasights/paint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphasights/paint/downloads","issues_url":"https://api.github.com/repos/alphasights/paint/issues{/number}","pulls_url":"https://api.github.com/repos/alphasights/paint/pulls{/number}","milestones_url":"https://api.github.com/repos/alphasights/paint/milestones{/number}","notifications_url":"https://api.github.com/repos/alphasights/paint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphasights/paint/labels{/name}","releases_url":"https://api.github.com/repos/alphasights/paint/releases{/id}","created_at":"2014-08-29T09:44:58Z","updated_at":"2015-08-04T08:37:50Z","pushed_at":"2015-08-20T01:10:20Z","git_url":"git://github.com/alphasights/paint.git","ssh_url":"git@github.com:alphasights/paint.git","clone_url":"https://github.com/alphasights/paint.git","svn_url":"https://github.com/alphasights/paint","homepage":"","size":2519,"stargazers_count":5,"watchers_count":5,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":23,"forks":0,"open_issues":23,"watchers":5,"default_branch":"develop"}},"base":{"label":"alphasights:develop","ref":"develop","sha":"b6675a7c1c215ec0cf18aba5240fd08a38cb7150","user":{"login":"alphasights","id":41216,"avatar_url":"https://avatars.githubusercontent.com/u/41216?v=3","gravatar_id":"","url":"https://api.github.com/users/alphasights","html_url":"https://github.com/alphasights","followers_url":"https://api.github.com/users/alphasights/followers","following_url":"https://api.github.com/users/alphasights/following{/other_user}","gists_url":"https://api.github.com/users/alphasights/gists{/gist_id}","starred_url":"https://api.github.com/users/alphasights/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphasights/subscriptions","organizations_url":"https://api.github.com/users/alphasights/orgs","repos_url":"https://api.github.com/users/alphasights/repos","events_url":"https://api.github.com/users/alphasights/events{/privacy}","received_events_url":"https://api.github.com/users/alphasights/received_events","type":"Organization","site_admin":false},"repo":{"id":23459758,"name":"paint","full_name":"alphasights/paint","owner":{"login":"alphasights","id":41216,"avatar_url":"https://avatars.githubusercontent.com/u/41216?v=3","gravatar_id":"","url":"https://api.github.com/users/alphasights","html_url":"https://github.com/alphasights","followers_url":"https://api.github.com/users/alphasights/followers","following_url":"https://api.github.com/users/alphasights/following{/other_user}","gists_url":"https://api.github.com/users/alphasights/gists{/gist_id}","starred_url":"https://api.github.com/users/alphasights/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphasights/subscriptions","organizations_url":"https://api.github.com/users/alphasights/orgs","repos_url":"https://api.github.com/users/alphasights/repos","events_url":"https://api.github.com/users/alphasights/events{/privacy}","received_events_url":"https://api.github.com/users/alphasights/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphasights/paint","description":"CSS framework like Bootstrap but more modern and delivered through SCSS mixins","fork":false,"url":"https://api.github.com/repos/alphasights/paint","forks_url":"https://api.github.com/repos/alphasights/paint/forks","keys_url":"https://api.github.com/repos/alphasights/paint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphasights/paint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphasights/paint/teams","hooks_url":"https://api.github.com/repos/alphasights/paint/hooks","issue_events_url":"https://api.github.com/repos/alphasights/paint/issues/events{/number}","events_url":"https://api.github.com/repos/alphasights/paint/events","assignees_url":"https://api.github.com/repos/alphasights/paint/assignees{/user}","branches_url":"https://api.github.com/repos/alphasights/paint/branches{/branch}","tags_url":"https://api.github.com/repos/alphasights/paint/tags","blobs_url":"https://api.github.com/repos/alphasights/paint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphasights/paint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphasights/paint/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphasights/paint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphasights/paint/statuses/{sha}","languages_url":"https://api.github.com/repos/alphasights/paint/languages","stargazers_url":"https://api.github.com/repos/alphasights/paint/stargazers","contributors_url":"https://api.github.com/repos/alphasights/paint/contributors","subscribers_url":"https://api.github.com/repos/alphasights/paint/subscribers","subscription_url":"https://api.github.com/repos/alphasights/paint/subscription","commits_url":"https://api.github.com/repos/alphasights/paint/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphasights/paint/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphasights/paint/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphasights/paint/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphasights/paint/contents/{+path}","compare_url":"https://api.github.com/repos/alphasights/paint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphasights/paint/merges","archive_url":"https://api.github.com/repos/alphasights/paint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphasights/paint/downloads","issues_url":"https://api.github.com/repos/alphasights/paint/issues{/number}","pulls_url":"https://api.github.com/repos/alphasights/paint/pulls{/number}","milestones_url":"https://api.github.com/repos/alphasights/paint/milestones{/number}","notifications_url":"https://api.github.com/repos/alphasights/paint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphasights/paint/labels{/name}","releases_url":"https://api.github.com/repos/alphasights/paint/releases{/id}","created_at":"2014-08-29T09:44:58Z","updated_at":"2015-08-04T08:37:50Z","pushed_at":"2015-08-20T01:10:20Z","git_url":"git://github.com/alphasights/paint.git","ssh_url":"git@github.com:alphasights/paint.git","clone_url":"https://github.com/alphasights/paint.git","svn_url":"https://github.com/alphasights/paint","homepage":"","size":2519,"stargazers_count":5,"watchers_count":5,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":23,"forks":0,"open_issues":23,"watchers":5,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/alphasights/paint/pulls/105"},"html":{"href":"https://github.com/alphasights/paint/pull/105"},"issue":{"href":"https://api.github.com/repos/alphasights/paint/issues/105"},"comments":{"href":"https://api.github.com/repos/alphasights/paint/issues/105/comments"},"review_comments":{"href":"https://api.github.com/repos/alphasights/paint/pulls/105/comments"},"review_comment":{"href":"https://api.github.com/repos/alphasights/paint/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alphasights/paint/pulls/105/commits"},"statuses":{"href":"https://api.github.com/repos/alphasights/paint/statuses/d6b642cd323a56bbeb82e84a816c3352020dc55d"}}}}