{"action":"created","comment":{"url":"https://api.github.com/repos/ga4gh/schemas/pulls/comments/36884378","id":36884378,"diff_hunk":"@@ -81,21 +81,12 @@ record ReferenceSet {\n   string id;\n \n   /**\n-  The IDs of the `Reference` objects that are part of this set.\n-\n-  This field should be left null if the set contains a very large number of\n-  `Reference`s. The `Reference`s in the set may also be obtained through a","path":"src/main/resources/avro/references.avdl","position":7,"original_position":7,"commit_id":"e5b7917f8ed8248024b4fe87c86aea22c60131e7","original_commit_id":"e5b7917f8ed8248024b4fe87c86aea22c60131e7","user":{"login":"calbach","id":822298,"avatar_url":"https://avatars.githubusercontent.com/u/822298?v=3","gravatar_id":"","url":"https://api.github.com/users/calbach","html_url":"https://github.com/calbach","followers_url":"https://api.github.com/users/calbach/followers","following_url":"https://api.github.com/users/calbach/following{/other_user}","gists_url":"https://api.github.com/users/calbach/gists{/gist_id}","starred_url":"https://api.github.com/users/calbach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calbach/subscriptions","organizations_url":"https://api.github.com/users/calbach/orgs","repos_url":"https://api.github.com/users/calbach/repos","events_url":"https://api.github.com/users/calbach/events{/privacy}","received_events_url":"https://api.github.com/users/calbach/received_events","type":"User","site_admin":false},"body":"On second thought you're right, it's not necessary. Reference Set -< Reference has a natural hierarchy.\r\n\r\nTangential to this PR:\r\n'client' in my comment was referring to someone writing code against the API, in your view I guess this is a client library developer. If a client is going to be lost just looking at the docs that's probably a problem we should fix. I think depending on divergent sets of documentation in language-specific client libraries being better is not a good solution - in my opinion an ideal client library would be very thin and use as much autogenerated code from this schemas repo as possible (including docs).","created_at":"2015-08-12T16:56:35Z","updated_at":"2015-08-12T16:56:35Z","html_url":"https://github.com/ga4gh/schemas/pull/378#discussion_r36884378","pull_request_url":"https://api.github.com/repos/ga4gh/schemas/pulls/378","_links":{"self":{"href":"https://api.github.com/repos/ga4gh/schemas/pulls/comments/36884378"},"html":{"href":"https://github.com/ga4gh/schemas/pull/378#discussion_r36884378"},"pull_request":{"href":"https://api.github.com/repos/ga4gh/schemas/pulls/378"}}},"pull_request":{"url":"https://api.github.com/repos/ga4gh/schemas/pulls/378","id":42257524,"html_url":"https://github.com/ga4gh/schemas/pull/378","diff_url":"https://github.com/ga4gh/schemas/pull/378.diff","patch_url":"https://github.com/ga4gh/schemas/pull/378.patch","issue_url":"https://api.github.com/repos/ga4gh/schemas/issues/378","number":378,"state":"open","locked":false,"title":"Remove embedded references.","user":{"login":"jeromekelleher","id":2664569,"avatar_url":"https://avatars.githubusercontent.com/u/2664569?v=3","gravatar_id":"","url":"https://api.github.com/users/jeromekelleher","html_url":"https://github.com/jeromekelleher","followers_url":"https://api.github.com/users/jeromekelleher/followers","following_url":"https://api.github.com/users/jeromekelleher/following{/other_user}","gists_url":"https://api.github.com/users/jeromekelleher/gists{/gist_id}","starred_url":"https://api.github.com/users/jeromekelleher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeromekelleher/subscriptions","organizations_url":"https://api.github.com/users/jeromekelleher/orgs","repos_url":"https://api.github.com/users/jeromekelleher/repos","events_url":"https://api.github.com/users/jeromekelleher/events{/privacy}","received_events_url":"https://api.github.com/users/jeromekelleher/received_events","type":"User","site_admin":false},"body":"Removed the embedded ReferenceId list from the ReferenceSet object. These can easily be obtained using the SearchReferences API call.\r\n\r\nEmbedding the IDs for child objects is not done anywhere else in the API (there are some where we embed the child _objects_, like `ReadGroupSet` and `Variant`). ","created_at":"2015-08-12T16:06:45Z","updated_at":"2015-08-12T16:56:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"45a129420657a92595f418817d466aee646bf490","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ga4gh/schemas/pulls/378/commits","review_comments_url":"https://api.github.com/repos/ga4gh/schemas/pulls/378/comments","review_comment_url":"https://api.github.com/repos/ga4gh/schemas/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ga4gh/schemas/issues/378/comments","statuses_url":"https://api.github.com/repos/ga4gh/schemas/statuses/e5b7917f8ed8248024b4fe87c86aea22c60131e7","head":{"label":"jeromekelleher:remove-embedded-references","ref":"remove-embedded-references","sha":"e5b7917f8ed8248024b4fe87c86aea22c60131e7","user":{"login":"jeromekelleher","id":2664569,"avatar_url":"https://avatars.githubusercontent.com/u/2664569?v=3","gravatar_id":"","url":"https://api.github.com/users/jeromekelleher","html_url":"https://github.com/jeromekelleher","followers_url":"https://api.github.com/users/jeromekelleher/followers","following_url":"https://api.github.com/users/jeromekelleher/following{/other_user}","gists_url":"https://api.github.com/users/jeromekelleher/gists{/gist_id}","starred_url":"https://api.github.com/users/jeromekelleher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeromekelleher/subscriptions","organizations_url":"https://api.github.com/users/jeromekelleher/orgs","repos_url":"https://api.github.com/users/jeromekelleher/repos","events_url":"https://api.github.com/users/jeromekelleher/events{/privacy}","received_events_url":"https://api.github.com/users/jeromekelleher/received_events","type":"User","site_admin":false},"repo":{"id":20289864,"name":"schemas","full_name":"jeromekelleher/schemas","owner":{"login":"jeromekelleher","id":2664569,"avatar_url":"https://avatars.githubusercontent.com/u/2664569?v=3","gravatar_id":"","url":"https://api.github.com/users/jeromekelleher","html_url":"https://github.com/jeromekelleher","followers_url":"https://api.github.com/users/jeromekelleher/followers","following_url":"https://api.github.com/users/jeromekelleher/following{/other_user}","gists_url":"https://api.github.com/users/jeromekelleher/gists{/gist_id}","starred_url":"https://api.github.com/users/jeromekelleher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeromekelleher/subscriptions","organizations_url":"https://api.github.com/users/jeromekelleher/orgs","repos_url":"https://api.github.com/users/jeromekelleher/repos","events_url":"https://api.github.com/users/jeromekelleher/events{/privacy}","received_events_url":"https://api.github.com/users/jeromekelleher/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jeromekelleher/schemas","description":"Work on data models and APIs for Genomic data.","fork":true,"url":"https://api.github.com/repos/jeromekelleher/schemas","forks_url":"https://api.github.com/repos/jeromekelleher/schemas/forks","keys_url":"https://api.github.com/repos/jeromekelleher/schemas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jeromekelleher/schemas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jeromekelleher/schemas/teams","hooks_url":"https://api.github.com/repos/jeromekelleher/schemas/hooks","issue_events_url":"https://api.github.com/repos/jeromekelleher/schemas/issues/events{/number}","events_url":"https://api.github.com/repos/jeromekelleher/schemas/events","assignees_url":"https://api.github.com/repos/jeromekelleher/schemas/assignees{/user}","branches_url":"https://api.github.com/repos/jeromekelleher/schemas/branches{/branch}","tags_url":"https://api.github.com/repos/jeromekelleher/schemas/tags","blobs_url":"https://api.github.com/repos/jeromekelleher/schemas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jeromekelleher/schemas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jeromekelleher/schemas/git/refs{/sha}","trees_url":"https://api.github.com/repos/jeromekelleher/schemas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jeromekelleher/schemas/statuses/{sha}","languages_url":"https://api.github.com/repos/jeromekelleher/schemas/languages","stargazers_url":"https://api.github.com/repos/jeromekelleher/schemas/stargazers","contributors_url":"https://api.github.com/repos/jeromekelleher/schemas/contributors","subscribers_url":"https://api.github.com/repos/jeromekelleher/schemas/subscribers","subscription_url":"https://api.github.com/repos/jeromekelleher/schemas/subscription","commits_url":"https://api.github.com/repos/jeromekelleher/schemas/commits{/sha}","git_commits_url":"https://api.github.com/repos/jeromekelleher/schemas/git/commits{/sha}","comments_url":"https://api.github.com/repos/jeromekelleher/schemas/comments{/number}","issue_comment_url":"https://api.github.com/repos/jeromekelleher/schemas/issues/comments{/number}","contents_url":"https://api.github.com/repos/jeromekelleher/schemas/contents/{+path}","compare_url":"https://api.github.com/repos/jeromekelleher/schemas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jeromekelleher/schemas/merges","archive_url":"https://api.github.com/repos/jeromekelleher/schemas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jeromekelleher/schemas/downloads","issues_url":"https://api.github.com/repos/jeromekelleher/schemas/issues{/number}","pulls_url":"https://api.github.com/repos/jeromekelleher/schemas/pulls{/number}","milestones_url":"https://api.github.com/repos/jeromekelleher/schemas/milestones{/number}","notifications_url":"https://api.github.com/repos/jeromekelleher/schemas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jeromekelleher/schemas/labels{/name}","releases_url":"https://api.github.com/repos/jeromekelleher/schemas/releases{/id}","created_at":"2014-05-29T10:07:05Z","updated_at":"2014-05-30T08:31:59Z","pushed_at":"2015-08-12T15:57:12Z","git_url":"git://github.com/jeromekelleher/schemas.git","ssh_url":"git@github.com:jeromekelleher/schemas.git","clone_url":"https://github.com/jeromekelleher/schemas.git","svn_url":"https://github.com/jeromekelleher/schemas","homepage":"","size":855,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ga4gh:master","ref":"master","sha":"0b8533cb2a0559911bc5fbbffb5698d5749d4bb7","user":{"login":"ga4gh","id":6921777,"avatar_url":"https://avatars.githubusercontent.com/u/6921777?v=3","gravatar_id":"","url":"https://api.github.com/users/ga4gh","html_url":"https://github.com/ga4gh","followers_url":"https://api.github.com/users/ga4gh/followers","following_url":"https://api.github.com/users/ga4gh/following{/other_user}","gists_url":"https://api.github.com/users/ga4gh/gists{/gist_id}","starred_url":"https://api.github.com/users/ga4gh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ga4gh/subscriptions","organizations_url":"https://api.github.com/users/ga4gh/orgs","repos_url":"https://api.github.com/users/ga4gh/repos","events_url":"https://api.github.com/users/ga4gh/events{/privacy}","received_events_url":"https://api.github.com/users/ga4gh/received_events","type":"Organization","site_admin":false},"repo":{"id":17925227,"name":"schemas","full_name":"ga4gh/schemas","owner":{"login":"ga4gh","id":6921777,"avatar_url":"https://avatars.githubusercontent.com/u/6921777?v=3","gravatar_id":"","url":"https://api.github.com/users/ga4gh","html_url":"https://github.com/ga4gh","followers_url":"https://api.github.com/users/ga4gh/followers","following_url":"https://api.github.com/users/ga4gh/following{/other_user}","gists_url":"https://api.github.com/users/ga4gh/gists{/gist_id}","starred_url":"https://api.github.com/users/ga4gh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ga4gh/subscriptions","organizations_url":"https://api.github.com/users/ga4gh/orgs","repos_url":"https://api.github.com/users/ga4gh/repos","events_url":"https://api.github.com/users/ga4gh/events{/privacy}","received_events_url":"https://api.github.com/users/ga4gh/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ga4gh/schemas","description":"Work on data models and APIs for Genomic data.","fork":false,"url":"https://api.github.com/repos/ga4gh/schemas","forks_url":"https://api.github.com/repos/ga4gh/schemas/forks","keys_url":"https://api.github.com/repos/ga4gh/schemas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ga4gh/schemas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ga4gh/schemas/teams","hooks_url":"https://api.github.com/repos/ga4gh/schemas/hooks","issue_events_url":"https://api.github.com/repos/ga4gh/schemas/issues/events{/number}","events_url":"https://api.github.com/repos/ga4gh/schemas/events","assignees_url":"https://api.github.com/repos/ga4gh/schemas/assignees{/user}","branches_url":"https://api.github.com/repos/ga4gh/schemas/branches{/branch}","tags_url":"https://api.github.com/repos/ga4gh/schemas/tags","blobs_url":"https://api.github.com/repos/ga4gh/schemas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ga4gh/schemas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ga4gh/schemas/git/refs{/sha}","trees_url":"https://api.github.com/repos/ga4gh/schemas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ga4gh/schemas/statuses/{sha}","languages_url":"https://api.github.com/repos/ga4gh/schemas/languages","stargazers_url":"https://api.github.com/repos/ga4gh/schemas/stargazers","contributors_url":"https://api.github.com/repos/ga4gh/schemas/contributors","subscribers_url":"https://api.github.com/repos/ga4gh/schemas/subscribers","subscription_url":"https://api.github.com/repos/ga4gh/schemas/subscription","commits_url":"https://api.github.com/repos/ga4gh/schemas/commits{/sha}","git_commits_url":"https://api.github.com/repos/ga4gh/schemas/git/commits{/sha}","comments_url":"https://api.github.com/repos/ga4gh/schemas/comments{/number}","issue_comment_url":"https://api.github.com/repos/ga4gh/schemas/issues/comments{/number}","contents_url":"https://api.github.com/repos/ga4gh/schemas/contents/{+path}","compare_url":"https://api.github.com/repos/ga4gh/schemas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ga4gh/schemas/merges","archive_url":"https://api.github.com/repos/ga4gh/schemas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ga4gh/schemas/downloads","issues_url":"https://api.github.com/repos/ga4gh/schemas/issues{/number}","pulls_url":"https://api.github.com/repos/ga4gh/schemas/pulls{/number}","milestones_url":"https://api.github.com/repos/ga4gh/schemas/milestones{/number}","notifications_url":"https://api.github.com/repos/ga4gh/schemas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ga4gh/schemas/labels{/name}","releases_url":"https://api.github.com/repos/ga4gh/schemas/releases{/id}","created_at":"2014-03-20T00:13:40Z","updated_at":"2015-08-10T23:44:30Z","pushed_at":"2015-08-12T16:06:46Z","git_url":"git://github.com/ga4gh/schemas.git","ssh_url":"git@github.com:ga4gh/schemas.git","clone_url":"https://github.com/ga4gh/schemas.git","svn_url":"https://github.com/ga4gh/schemas","homepage":"http://ga4gh.org/#/api","size":14165,"stargazers_count":153,"watchers_count":153,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":72,"mirror_url":null,"open_issues_count":91,"forks":72,"open_issues":91,"watchers":153,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ga4gh/schemas/pulls/378"},"html":{"href":"https://github.com/ga4gh/schemas/pull/378"},"issue":{"href":"https://api.github.com/repos/ga4gh/schemas/issues/378"},"comments":{"href":"https://api.github.com/repos/ga4gh/schemas/issues/378/comments"},"review_comments":{"href":"https://api.github.com/repos/ga4gh/schemas/pulls/378/comments"},"review_comment":{"href":"https://api.github.com/repos/ga4gh/schemas/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ga4gh/schemas/pulls/378/commits"},"statuses":{"href":"https://api.github.com/repos/ga4gh/schemas/statuses/e5b7917f8ed8248024b4fe87c86aea22c60131e7"}}}}