{"action":"created","comment":{"url":"https://api.github.com/repos/formly-js/angular-formly/pulls/comments/33298384","id":33298384,"diff_hunk":"@@ -18,7 +18,10 @@ function addFormlyNgModelAttrsManipulator(formlyConfig, $interpolate) {\n       return template;\n     }\n     el.innerHTML = template;\n-    var modelNodes = el.querySelectorAll('[ng-model], [data-ng-model]');\n+    var elementFilter = ':not([formly-skip-ng-model-attrs-manipulator])' +\n+                        ':not(' + data.skipNgModelAttrsManipulator + ')';","path":"src/run/formlyNgModelAttrsManipulator.js","position":6,"original_position":6,"commit_id":"88f6e45dd846556c6567e234837498c5ce2661c9","original_commit_id":"88f6e45dd846556c6567e234837498c5ce2661c9","user":{"login":"kentcdodds","id":1500684,"avatar_url":"https://avatars.githubusercontent.com/u/1500684?v=3","gravatar_id":"","url":"https://api.github.com/users/kentcdodds","html_url":"https://github.com/kentcdodds","followers_url":"https://api.github.com/users/kentcdodds/followers","following_url":"https://api.github.com/users/kentcdodds/following{/other_user}","gists_url":"https://api.github.com/users/kentcdodds/gists{/gist_id}","starred_url":"https://api.github.com/users/kentcdodds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kentcdodds/subscriptions","organizations_url":"https://api.github.com/users/kentcdodds/orgs","repos_url":"https://api.github.com/users/kentcdodds/repos","events_url":"https://api.github.com/users/kentcdodds/events{/privacy}","received_events_url":"https://api.github.com/users/kentcdodds/received_events","type":"User","site_admin":false},"body":"Awesome! I should have covered this in the tests, but what if I pass `false ` as the skipNgModelAttrsManipulator? :-)","created_at":"2015-06-25T20:04:40Z","updated_at":"2015-06-25T20:04:40Z","html_url":"https://github.com/formly-js/angular-formly/pull/364#discussion_r33298384","pull_request_url":"https://api.github.com/repos/formly-js/angular-formly/pulls/364","_links":{"self":{"href":"https://api.github.com/repos/formly-js/angular-formly/pulls/comments/33298384"},"html":{"href":"https://github.com/formly-js/angular-formly/pull/364#discussion_r33298384"},"pull_request":{"href":"https://api.github.com/repos/formly-js/angular-formly/pulls/364"}}},"pull_request":{"url":"https://api.github.com/repos/formly-js/angular-formly/pulls/364","id":38587166,"html_url":"https://github.com/formly-js/angular-formly/pull/364","diff_url":"https://github.com/formly-js/angular-formly/pull/364.diff","patch_url":"https://github.com/formly-js/angular-formly/pull/364.patch","issue_url":"https://api.github.com/repos/formly-js/angular-formly/issues/364","number":364,"state":"open","locked":false,"title":"adds formly-skip-ng-model-attrs-manipulator attribute option and skip be selector option","user":{"login":"douglas-mason","id":1195453,"avatar_url":"https://avatars.githubusercontent.com/u/1195453?v=3","gravatar_id":"","url":"https://api.github.com/users/douglas-mason","html_url":"https://github.com/douglas-mason","followers_url":"https://api.github.com/users/douglas-mason/followers","following_url":"https://api.github.com/users/douglas-mason/following{/other_user}","gists_url":"https://api.github.com/users/douglas-mason/gists{/gist_id}","starred_url":"https://api.github.com/users/douglas-mason/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/douglas-mason/subscriptions","organizations_url":"https://api.github.com/users/douglas-mason/orgs","repos_url":"https://api.github.com/users/douglas-mason/repos","events_url":"https://api.github.com/users/douglas-mason/events{/privacy}","received_events_url":"https://api.github.com/users/douglas-mason/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-06-25T20:02:25Z","updated_at":"2015-06-25T20:04:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/formly-js/angular-formly/pulls/364/commits","review_comments_url":"https://api.github.com/repos/formly-js/angular-formly/pulls/364/comments","review_comment_url":"https://api.github.com/repos/formly-js/angular-formly/pulls/comments{/number}","comments_url":"https://api.github.com/repos/formly-js/angular-formly/issues/364/comments","statuses_url":"https://api.github.com/repos/formly-js/angular-formly/statuses/88f6e45dd846556c6567e234837498c5ce2661c9","head":{"label":"douglas-mason:dm-358-add-ignore-option-to-templateManipulator","ref":"dm-358-add-ignore-option-to-templateManipulator","sha":"88f6e45dd846556c6567e234837498c5ce2661c9","user":{"login":"douglas-mason","id":1195453,"avatar_url":"https://avatars.githubusercontent.com/u/1195453?v=3","gravatar_id":"","url":"https://api.github.com/users/douglas-mason","html_url":"https://github.com/douglas-mason","followers_url":"https://api.github.com/users/douglas-mason/followers","following_url":"https://api.github.com/users/douglas-mason/following{/other_user}","gists_url":"https://api.github.com/users/douglas-mason/gists{/gist_id}","starred_url":"https://api.github.com/users/douglas-mason/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/douglas-mason/subscriptions","organizations_url":"https://api.github.com/users/douglas-mason/orgs","repos_url":"https://api.github.com/users/douglas-mason/repos","events_url":"https://api.github.com/users/douglas-mason/events{/privacy}","received_events_url":"https://api.github.com/users/douglas-mason/received_events","type":"User","site_admin":false},"repo":{"id":38057985,"name":"angular-formly","full_name":"douglas-mason/angular-formly","owner":{"login":"douglas-mason","id":1195453,"avatar_url":"https://avatars.githubusercontent.com/u/1195453?v=3","gravatar_id":"","url":"https://api.github.com/users/douglas-mason","html_url":"https://github.com/douglas-mason","followers_url":"https://api.github.com/users/douglas-mason/followers","following_url":"https://api.github.com/users/douglas-mason/following{/other_user}","gists_url":"https://api.github.com/users/douglas-mason/gists{/gist_id}","starred_url":"https://api.github.com/users/douglas-mason/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/douglas-mason/subscriptions","organizations_url":"https://api.github.com/users/douglas-mason/orgs","repos_url":"https://api.github.com/users/douglas-mason/repos","events_url":"https://api.github.com/users/douglas-mason/events{/privacy}","received_events_url":"https://api.github.com/users/douglas-mason/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/douglas-mason/angular-formly","description":"JavaScript powered forms for AngularJS","fork":true,"url":"https://api.github.com/repos/douglas-mason/angular-formly","forks_url":"https://api.github.com/repos/douglas-mason/angular-formly/forks","keys_url":"https://api.github.com/repos/douglas-mason/angular-formly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/douglas-mason/angular-formly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/douglas-mason/angular-formly/teams","hooks_url":"https://api.github.com/repos/douglas-mason/angular-formly/hooks","issue_events_url":"https://api.github.com/repos/douglas-mason/angular-formly/issues/events{/number}","events_url":"https://api.github.com/repos/douglas-mason/angular-formly/events","assignees_url":"https://api.github.com/repos/douglas-mason/angular-formly/assignees{/user}","branches_url":"https://api.github.com/repos/douglas-mason/angular-formly/branches{/branch}","tags_url":"https://api.github.com/repos/douglas-mason/angular-formly/tags","blobs_url":"https://api.github.com/repos/douglas-mason/angular-formly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/douglas-mason/angular-formly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/douglas-mason/angular-formly/git/refs{/sha}","trees_url":"https://api.github.com/repos/douglas-mason/angular-formly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/douglas-mason/angular-formly/statuses/{sha}","languages_url":"https://api.github.com/repos/douglas-mason/angular-formly/languages","stargazers_url":"https://api.github.com/repos/douglas-mason/angular-formly/stargazers","contributors_url":"https://api.github.com/repos/douglas-mason/angular-formly/contributors","subscribers_url":"https://api.github.com/repos/douglas-mason/angular-formly/subscribers","subscription_url":"https://api.github.com/repos/douglas-mason/angular-formly/subscription","commits_url":"https://api.github.com/repos/douglas-mason/angular-formly/commits{/sha}","git_commits_url":"https://api.github.com/repos/douglas-mason/angular-formly/git/commits{/sha}","comments_url":"https://api.github.com/repos/douglas-mason/angular-formly/comments{/number}","issue_comment_url":"https://api.github.com/repos/douglas-mason/angular-formly/issues/comments{/number}","contents_url":"https://api.github.com/repos/douglas-mason/angular-formly/contents/{+path}","compare_url":"https://api.github.com/repos/douglas-mason/angular-formly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/douglas-mason/angular-formly/merges","archive_url":"https://api.github.com/repos/douglas-mason/angular-formly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/douglas-mason/angular-formly/downloads","issues_url":"https://api.github.com/repos/douglas-mason/angular-formly/issues{/number}","pulls_url":"https://api.github.com/repos/douglas-mason/angular-formly/pulls{/number}","milestones_url":"https://api.github.com/repos/douglas-mason/angular-formly/milestones{/number}","notifications_url":"https://api.github.com/repos/douglas-mason/angular-formly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/douglas-mason/angular-formly/labels{/name}","releases_url":"https://api.github.com/repos/douglas-mason/angular-formly/releases{/id}","created_at":"2015-06-25T15:34:33Z","updated_at":"2015-06-25T15:34:34Z","pushed_at":"2015-06-25T20:01:25Z","git_url":"git://github.com/douglas-mason/angular-formly.git","ssh_url":"git@github.com:douglas-mason/angular-formly.git","clone_url":"https://github.com/douglas-mason/angular-formly.git","svn_url":"https://github.com/douglas-mason/angular-formly","homepage":"http://docs.angular-formly.com","size":34564,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"formly-js:master","ref":"master","sha":"8690b7ebb27c840362ebdb139b6a71ba18b43c7d","user":{"login":"formly-js","id":8561755,"avatar_url":"https://avatars.githubusercontent.com/u/8561755?v=3","gravatar_id":"","url":"https://api.github.com/users/formly-js","html_url":"https://github.com/formly-js","followers_url":"https://api.github.com/users/formly-js/followers","following_url":"https://api.github.com/users/formly-js/following{/other_user}","gists_url":"https://api.github.com/users/formly-js/gists{/gist_id}","starred_url":"https://api.github.com/users/formly-js/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/formly-js/subscriptions","organizations_url":"https://api.github.com/users/formly-js/orgs","repos_url":"https://api.github.com/users/formly-js/repos","events_url":"https://api.github.com/users/formly-js/events{/privacy}","received_events_url":"https://api.github.com/users/formly-js/received_events","type":"Organization","site_admin":false},"repo":{"id":16396294,"name":"angular-formly","full_name":"formly-js/angular-formly","owner":{"login":"formly-js","id":8561755,"avatar_url":"https://avatars.githubusercontent.com/u/8561755?v=3","gravatar_id":"","url":"https://api.github.com/users/formly-js","html_url":"https://github.com/formly-js","followers_url":"https://api.github.com/users/formly-js/followers","following_url":"https://api.github.com/users/formly-js/following{/other_user}","gists_url":"https://api.github.com/users/formly-js/gists{/gist_id}","starred_url":"https://api.github.com/users/formly-js/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/formly-js/subscriptions","organizations_url":"https://api.github.com/users/formly-js/orgs","repos_url":"https://api.github.com/users/formly-js/repos","events_url":"https://api.github.com/users/formly-js/events{/privacy}","received_events_url":"https://api.github.com/users/formly-js/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/formly-js/angular-formly","description":"JavaScript powered forms for AngularJS","fork":false,"url":"https://api.github.com/repos/formly-js/angular-formly","forks_url":"https://api.github.com/repos/formly-js/angular-formly/forks","keys_url":"https://api.github.com/repos/formly-js/angular-formly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/formly-js/angular-formly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/formly-js/angular-formly/teams","hooks_url":"https://api.github.com/repos/formly-js/angular-formly/hooks","issue_events_url":"https://api.github.com/repos/formly-js/angular-formly/issues/events{/number}","events_url":"https://api.github.com/repos/formly-js/angular-formly/events","assignees_url":"https://api.github.com/repos/formly-js/angular-formly/assignees{/user}","branches_url":"https://api.github.com/repos/formly-js/angular-formly/branches{/branch}","tags_url":"https://api.github.com/repos/formly-js/angular-formly/tags","blobs_url":"https://api.github.com/repos/formly-js/angular-formly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/formly-js/angular-formly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/formly-js/angular-formly/git/refs{/sha}","trees_url":"https://api.github.com/repos/formly-js/angular-formly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/formly-js/angular-formly/statuses/{sha}","languages_url":"https://api.github.com/repos/formly-js/angular-formly/languages","stargazers_url":"https://api.github.com/repos/formly-js/angular-formly/stargazers","contributors_url":"https://api.github.com/repos/formly-js/angular-formly/contributors","subscribers_url":"https://api.github.com/repos/formly-js/angular-formly/subscribers","subscription_url":"https://api.github.com/repos/formly-js/angular-formly/subscription","commits_url":"https://api.github.com/repos/formly-js/angular-formly/commits{/sha}","git_commits_url":"https://api.github.com/repos/formly-js/angular-formly/git/commits{/sha}","comments_url":"https://api.github.com/repos/formly-js/angular-formly/comments{/number}","issue_comment_url":"https://api.github.com/repos/formly-js/angular-formly/issues/comments{/number}","contents_url":"https://api.github.com/repos/formly-js/angular-formly/contents/{+path}","compare_url":"https://api.github.com/repos/formly-js/angular-formly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/formly-js/angular-formly/merges","archive_url":"https://api.github.com/repos/formly-js/angular-formly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/formly-js/angular-formly/downloads","issues_url":"https://api.github.com/repos/formly-js/angular-formly/issues{/number}","pulls_url":"https://api.github.com/repos/formly-js/angular-formly/pulls{/number}","milestones_url":"https://api.github.com/repos/formly-js/angular-formly/milestones{/number}","notifications_url":"https://api.github.com/repos/formly-js/angular-formly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/formly-js/angular-formly/labels{/name}","releases_url":"https://api.github.com/repos/formly-js/angular-formly/releases{/id}","created_at":"2014-01-31T01:01:57Z","updated_at":"2015-06-25T16:10:27Z","pushed_at":"2015-06-25T20:02:25Z","git_url":"git://github.com/formly-js/angular-formly.git","ssh_url":"git@github.com:formly-js/angular-formly.git","clone_url":"https://github.com/formly-js/angular-formly.git","svn_url":"https://github.com/formly-js/angular-formly","homepage":"http://docs.angular-formly.com","size":34564,"stargazers_count":1159,"watchers_count":1159,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":165,"mirror_url":null,"open_issues_count":9,"forks":165,"open_issues":9,"watchers":1159,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/formly-js/angular-formly/pulls/364"},"html":{"href":"https://github.com/formly-js/angular-formly/pull/364"},"issue":{"href":"https://api.github.com/repos/formly-js/angular-formly/issues/364"},"comments":{"href":"https://api.github.com/repos/formly-js/angular-formly/issues/364/comments"},"review_comments":{"href":"https://api.github.com/repos/formly-js/angular-formly/pulls/364/comments"},"review_comment":{"href":"https://api.github.com/repos/formly-js/angular-formly/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/formly-js/angular-formly/pulls/364/commits"},"statuses":{"href":"https://api.github.com/repos/formly-js/angular-formly/statuses/88f6e45dd846556c6567e234837498c5ce2661c9"}}}}