{"action":"created","comment":{"url":"https://api.github.com/repos/biometrics/openbr/pulls/comments/36793642","id":36793642,"diff_hunk":"@@ -366,6 +366,7 @@ class BR_EXPORT CompositeTransform : public TimeVaryingTransform\n     CompositeTransform() : TimeVaryingTransform(false) {}\n };\n \n+#ifdef BR_WITH_QTNETWORK","path":"openbr/plugins/openbr_internal.h","position":4,"original_position":4,"commit_id":"76c6ac42aaa476925c3ed1a7417d88d976585a0b","original_commit_id":"76c6ac42aaa476925c3ed1a7417d88d976585a0b","user":{"login":"jklontz","id":682795,"avatar_url":"https://avatars.githubusercontent.com/u/682795?v=3","gravatar_id":"","url":"https://api.github.com/users/jklontz","html_url":"https://github.com/jklontz","followers_url":"https://api.github.com/users/jklontz/followers","following_url":"https://api.github.com/users/jklontz/following{/other_user}","gists_url":"https://api.github.com/users/jklontz/gists{/gist_id}","starred_url":"https://api.github.com/users/jklontz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jklontz/subscriptions","organizations_url":"https://api.github.com/users/jklontz/orgs","repos_url":"https://api.github.com/users/jklontz/repos","events_url":"https://api.github.com/users/jklontz/events{/privacy}","received_events_url":"https://api.github.com/users/jklontz/received_events","type":"User","site_admin":false},"body":"Strictly speaking, this doesn't seem necessary.","created_at":"2015-08-11T20:22:00Z","updated_at":"2015-08-11T20:22:00Z","html_url":"https://github.com/biometrics/openbr/pull/409#discussion_r36793642","pull_request_url":"https://api.github.com/repos/biometrics/openbr/pulls/409","_links":{"self":{"href":"https://api.github.com/repos/biometrics/openbr/pulls/comments/36793642"},"html":{"href":"https://github.com/biometrics/openbr/pull/409#discussion_r36793642"},"pull_request":{"href":"https://api.github.com/repos/biometrics/openbr/pulls/409"}}},"pull_request":{"url":"https://api.github.com/repos/biometrics/openbr/pulls/409","id":42169873,"html_url":"https://github.com/biometrics/openbr/pull/409","diff_url":"https://github.com/biometrics/openbr/pull/409.diff","patch_url":"https://github.com/biometrics/openbr/pull/409.patch","issue_url":"https://api.github.com/repos/biometrics/openbr/issues/409","number":409,"state":"open","locked":false,"title":"Network","user":{"login":"sklum","id":3186522,"avatar_url":"https://avatars.githubusercontent.com/u/3186522?v=3","gravatar_id":"","url":"https://api.github.com/users/sklum","html_url":"https://github.com/sklum","followers_url":"https://api.github.com/users/sklum/followers","following_url":"https://api.github.com/users/sklum/following{/other_user}","gists_url":"https://api.github.com/users/sklum/gists{/gist_id}","starred_url":"https://api.github.com/users/sklum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sklum/subscriptions","organizations_url":"https://api.github.com/users/sklum/orgs","repos_url":"https://api.github.com/users/sklum/repos","events_url":"https://api.github.com/users/sklum/events{/privacy}","received_events_url":"https://api.github.com/users/sklum/received_events","type":"User","site_admin":false},"body":"Even if one builds with `BR_EMBEDDED`, OpenBR still depends on the `QtNetwork` library.  This branch fixes that.  @jklontz?","created_at":"2015-08-11T19:50:30Z","updated_at":"2015-08-11T20:22:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1f735bc7c54d4d3b53dcd85e524857176aac3707","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/biometrics/openbr/pulls/409/commits","review_comments_url":"https://api.github.com/repos/biometrics/openbr/pulls/409/comments","review_comment_url":"https://api.github.com/repos/biometrics/openbr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/biometrics/openbr/issues/409/comments","statuses_url":"https://api.github.com/repos/biometrics/openbr/statuses/76c6ac42aaa476925c3ed1a7417d88d976585a0b","head":{"label":"biometrics:network","ref":"network","sha":"76c6ac42aaa476925c3ed1a7417d88d976585a0b","user":{"login":"biometrics","id":94188,"avatar_url":"https://avatars.githubusercontent.com/u/94188?v=3","gravatar_id":"","url":"https://api.github.com/users/biometrics","html_url":"https://github.com/biometrics","followers_url":"https://api.github.com/users/biometrics/followers","following_url":"https://api.github.com/users/biometrics/following{/other_user}","gists_url":"https://api.github.com/users/biometrics/gists{/gist_id}","starred_url":"https://api.github.com/users/biometrics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/biometrics/subscriptions","organizations_url":"https://api.github.com/users/biometrics/orgs","repos_url":"https://api.github.com/users/biometrics/repos","events_url":"https://api.github.com/users/biometrics/events{/privacy}","received_events_url":"https://api.github.com/users/biometrics/received_events","type":"Organization","site_admin":false},"repo":{"id":7251195,"name":"openbr","full_name":"biometrics/openbr","owner":{"login":"biometrics","id":94188,"avatar_url":"https://avatars.githubusercontent.com/u/94188?v=3","gravatar_id":"","url":"https://api.github.com/users/biometrics","html_url":"https://github.com/biometrics","followers_url":"https://api.github.com/users/biometrics/followers","following_url":"https://api.github.com/users/biometrics/following{/other_user}","gists_url":"https://api.github.com/users/biometrics/gists{/gist_id}","starred_url":"https://api.github.com/users/biometrics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/biometrics/subscriptions","organizations_url":"https://api.github.com/users/biometrics/orgs","repos_url":"https://api.github.com/users/biometrics/repos","events_url":"https://api.github.com/users/biometrics/events{/privacy}","received_events_url":"https://api.github.com/users/biometrics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/biometrics/openbr","description":"Open Source Biometrics, Face Recognition","fork":false,"url":"https://api.github.com/repos/biometrics/openbr","forks_url":"https://api.github.com/repos/biometrics/openbr/forks","keys_url":"https://api.github.com/repos/biometrics/openbr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/biometrics/openbr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/biometrics/openbr/teams","hooks_url":"https://api.github.com/repos/biometrics/openbr/hooks","issue_events_url":"https://api.github.com/repos/biometrics/openbr/issues/events{/number}","events_url":"https://api.github.com/repos/biometrics/openbr/events","assignees_url":"https://api.github.com/repos/biometrics/openbr/assignees{/user}","branches_url":"https://api.github.com/repos/biometrics/openbr/branches{/branch}","tags_url":"https://api.github.com/repos/biometrics/openbr/tags","blobs_url":"https://api.github.com/repos/biometrics/openbr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/biometrics/openbr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/biometrics/openbr/git/refs{/sha}","trees_url":"https://api.github.com/repos/biometrics/openbr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/biometrics/openbr/statuses/{sha}","languages_url":"https://api.github.com/repos/biometrics/openbr/languages","stargazers_url":"https://api.github.com/repos/biometrics/openbr/stargazers","contributors_url":"https://api.github.com/repos/biometrics/openbr/contributors","subscribers_url":"https://api.github.com/repos/biometrics/openbr/subscribers","subscription_url":"https://api.github.com/repos/biometrics/openbr/subscription","commits_url":"https://api.github.com/repos/biometrics/openbr/commits{/sha}","git_commits_url":"https://api.github.com/repos/biometrics/openbr/git/commits{/sha}","comments_url":"https://api.github.com/repos/biometrics/openbr/comments{/number}","issue_comment_url":"https://api.github.com/repos/biometrics/openbr/issues/comments{/number}","contents_url":"https://api.github.com/repos/biometrics/openbr/contents/{+path}","compare_url":"https://api.github.com/repos/biometrics/openbr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/biometrics/openbr/merges","archive_url":"https://api.github.com/repos/biometrics/openbr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/biometrics/openbr/downloads","issues_url":"https://api.github.com/repos/biometrics/openbr/issues{/number}","pulls_url":"https://api.github.com/repos/biometrics/openbr/pulls{/number}","milestones_url":"https://api.github.com/repos/biometrics/openbr/milestones{/number}","notifications_url":"https://api.github.com/repos/biometrics/openbr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/biometrics/openbr/labels{/name}","releases_url":"https://api.github.com/repos/biometrics/openbr/releases{/id}","created_at":"2012-12-20T02:52:37Z","updated_at":"2015-08-11T18:56:51Z","pushed_at":"2015-08-11T19:50:31Z","git_url":"git://github.com/biometrics/openbr.git","ssh_url":"git@github.com:biometrics/openbr.git","clone_url":"https://github.com/biometrics/openbr.git","svn_url":"https://github.com/biometrics/openbr","homepage":"www.openbiometrics.org","size":57194,"stargazers_count":1279,"watchers_count":1279,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":290,"mirror_url":null,"open_issues_count":19,"forks":290,"open_issues":19,"watchers":1279,"default_branch":"master"}},"base":{"label":"biometrics:master","ref":"master","sha":"b0627f34f87f1fd06bba516430779d5fe177f2d3","user":{"login":"biometrics","id":94188,"avatar_url":"https://avatars.githubusercontent.com/u/94188?v=3","gravatar_id":"","url":"https://api.github.com/users/biometrics","html_url":"https://github.com/biometrics","followers_url":"https://api.github.com/users/biometrics/followers","following_url":"https://api.github.com/users/biometrics/following{/other_user}","gists_url":"https://api.github.com/users/biometrics/gists{/gist_id}","starred_url":"https://api.github.com/users/biometrics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/biometrics/subscriptions","organizations_url":"https://api.github.com/users/biometrics/orgs","repos_url":"https://api.github.com/users/biometrics/repos","events_url":"https://api.github.com/users/biometrics/events{/privacy}","received_events_url":"https://api.github.com/users/biometrics/received_events","type":"Organization","site_admin":false},"repo":{"id":7251195,"name":"openbr","full_name":"biometrics/openbr","owner":{"login":"biometrics","id":94188,"avatar_url":"https://avatars.githubusercontent.com/u/94188?v=3","gravatar_id":"","url":"https://api.github.com/users/biometrics","html_url":"https://github.com/biometrics","followers_url":"https://api.github.com/users/biometrics/followers","following_url":"https://api.github.com/users/biometrics/following{/other_user}","gists_url":"https://api.github.com/users/biometrics/gists{/gist_id}","starred_url":"https://api.github.com/users/biometrics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/biometrics/subscriptions","organizations_url":"https://api.github.com/users/biometrics/orgs","repos_url":"https://api.github.com/users/biometrics/repos","events_url":"https://api.github.com/users/biometrics/events{/privacy}","received_events_url":"https://api.github.com/users/biometrics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/biometrics/openbr","description":"Open Source Biometrics, Face Recognition","fork":false,"url":"https://api.github.com/repos/biometrics/openbr","forks_url":"https://api.github.com/repos/biometrics/openbr/forks","keys_url":"https://api.github.com/repos/biometrics/openbr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/biometrics/openbr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/biometrics/openbr/teams","hooks_url":"https://api.github.com/repos/biometrics/openbr/hooks","issue_events_url":"https://api.github.com/repos/biometrics/openbr/issues/events{/number}","events_url":"https://api.github.com/repos/biometrics/openbr/events","assignees_url":"https://api.github.com/repos/biometrics/openbr/assignees{/user}","branches_url":"https://api.github.com/repos/biometrics/openbr/branches{/branch}","tags_url":"https://api.github.com/repos/biometrics/openbr/tags","blobs_url":"https://api.github.com/repos/biometrics/openbr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/biometrics/openbr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/biometrics/openbr/git/refs{/sha}","trees_url":"https://api.github.com/repos/biometrics/openbr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/biometrics/openbr/statuses/{sha}","languages_url":"https://api.github.com/repos/biometrics/openbr/languages","stargazers_url":"https://api.github.com/repos/biometrics/openbr/stargazers","contributors_url":"https://api.github.com/repos/biometrics/openbr/contributors","subscribers_url":"https://api.github.com/repos/biometrics/openbr/subscribers","subscription_url":"https://api.github.com/repos/biometrics/openbr/subscription","commits_url":"https://api.github.com/repos/biometrics/openbr/commits{/sha}","git_commits_url":"https://api.github.com/repos/biometrics/openbr/git/commits{/sha}","comments_url":"https://api.github.com/repos/biometrics/openbr/comments{/number}","issue_comment_url":"https://api.github.com/repos/biometrics/openbr/issues/comments{/number}","contents_url":"https://api.github.com/repos/biometrics/openbr/contents/{+path}","compare_url":"https://api.github.com/repos/biometrics/openbr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/biometrics/openbr/merges","archive_url":"https://api.github.com/repos/biometrics/openbr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/biometrics/openbr/downloads","issues_url":"https://api.github.com/repos/biometrics/openbr/issues{/number}","pulls_url":"https://api.github.com/repos/biometrics/openbr/pulls{/number}","milestones_url":"https://api.github.com/repos/biometrics/openbr/milestones{/number}","notifications_url":"https://api.github.com/repos/biometrics/openbr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/biometrics/openbr/labels{/name}","releases_url":"https://api.github.com/repos/biometrics/openbr/releases{/id}","created_at":"2012-12-20T02:52:37Z","updated_at":"2015-08-11T18:56:51Z","pushed_at":"2015-08-11T19:50:31Z","git_url":"git://github.com/biometrics/openbr.git","ssh_url":"git@github.com:biometrics/openbr.git","clone_url":"https://github.com/biometrics/openbr.git","svn_url":"https://github.com/biometrics/openbr","homepage":"www.openbiometrics.org","size":57194,"stargazers_count":1279,"watchers_count":1279,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":290,"mirror_url":null,"open_issues_count":19,"forks":290,"open_issues":19,"watchers":1279,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/biometrics/openbr/pulls/409"},"html":{"href":"https://github.com/biometrics/openbr/pull/409"},"issue":{"href":"https://api.github.com/repos/biometrics/openbr/issues/409"},"comments":{"href":"https://api.github.com/repos/biometrics/openbr/issues/409/comments"},"review_comments":{"href":"https://api.github.com/repos/biometrics/openbr/pulls/409/comments"},"review_comment":{"href":"https://api.github.com/repos/biometrics/openbr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/biometrics/openbr/pulls/409/commits"},"statuses":{"href":"https://api.github.com/repos/biometrics/openbr/statuses/76c6ac42aaa476925c3ed1a7417d88d976585a0b"}}}}