{"action":"created","issue":{"url":"https://api.github.com/repos/rilmodem/ofono/issues/191","labels_url":"https://api.github.com/repos/rilmodem/ofono/issues/191/labels{/name}","comments_url":"https://api.github.com/repos/rilmodem/ofono/issues/191/comments","events_url":"https://api.github.com/repos/rilmodem/ofono/issues/191/events","html_url":"https://github.com/rilmodem/ofono/pull/191","id":86531296,"number":191,"title":"gprs: Resolve MMS proxy/MMSC host name","user":{"login":"alfonsosanchezbeato","id":3833021,"avatar_url":"https://avatars.githubusercontent.com/u/3833021?v=3","gravatar_id":"","url":"https://api.github.com/users/alfonsosanchezbeato","html_url":"https://github.com/alfonsosanchezbeato","followers_url":"https://api.github.com/users/alfonsosanchezbeato/followers","following_url":"https://api.github.com/users/alfonsosanchezbeato/following{/other_user}","gists_url":"https://api.github.com/users/alfonsosanchezbeato/gists{/gist_id}","starred_url":"https://api.github.com/users/alfonsosanchezbeato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alfonsosanchezbeato/subscriptions","organizations_url":"https://api.github.com/users/alfonsosanchezbeato/orgs","repos_url":"https://api.github.com/users/alfonsosanchezbeato/repos","events_url":"https://api.github.com/users/alfonsosanchezbeato/events{/privacy}","received_events_url":"https://api.github.com/users/alfonsosanchezbeato/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-06-09T09:45:00Z","updated_at":"2015-06-12T13:33:05Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/rilmodem/ofono/pulls/191","html_url":"https://github.com/rilmodem/ofono/pull/191","diff_url":"https://github.com/rilmodem/ofono/pull/191.diff","patch_url":"https://github.com/rilmodem/ofono/pull/191.patch"},"body":"Resolve, in case the hostname is provided instead of the IP address, MMS proxy / MMSC name using the DNS servers provided by the context. We need the IP so we can set-up a route for them. Also, use the MMSC for the route in case we do not have a MMS proxy.\r\n\r\nThis solves\r\n\r\nhttps://bugs.launchpad.net/ubuntu/+source/nuntium/+bug/1417976"},"comment":{"url":"https://api.github.com/repos/rilmodem/ofono/issues/comments/111494069","html_url":"https://github.com/rilmodem/ofono/pull/191#issuecomment-111494069","issue_url":"https://api.github.com/repos/rilmodem/ofono/issues/191","id":111494069,"user":{"login":"tonyespy","id":5264713,"avatar_url":"https://avatars.githubusercontent.com/u/5264713?v=3","gravatar_id":"","url":"https://api.github.com/users/tonyespy","html_url":"https://github.com/tonyespy","followers_url":"https://api.github.com/users/tonyespy/followers","following_url":"https://api.github.com/users/tonyespy/following{/other_user}","gists_url":"https://api.github.com/users/tonyespy/gists{/gist_id}","starred_url":"https://api.github.com/users/tonyespy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tonyespy/subscriptions","organizations_url":"https://api.github.com/users/tonyespy/orgs","repos_url":"https://api.github.com/users/tonyespy/repos","events_url":"https://api.github.com/users/tonyespy/events{/privacy}","received_events_url":"https://api.github.com/users/tonyespy/received_events","type":"User","site_admin":false},"created_at":"2015-06-12T13:33:05Z","updated_at":"2015-06-12T13:33:05Z","body":"This approach looks good, however I have a couple of concerns regarding the implementation:\r\n\r\n * What happens if the DNS servers for the MMS context overlap those for an existing, active Internet context?\r\n\r\n * It doesn't appear that the host routes for the DNS servers are ever cleaned up?\r\n\r\n * It doesn't appear that the host route for the MMS proxy or MessageCenter are ever cleaned up?\r\n\r\nNote, the cleanup may happen implicitly as part of the ifupdown logic, however I don't know the details of the routing table well enough to know if this occurs.\r\n\r\nI have some other comments that I've added inline."}}