{"action":"created","issue":{"url":"https://api.github.com/repos/newrelic/puppet-nrsysmond/issues/6","labels_url":"https://api.github.com/repos/newrelic/puppet-nrsysmond/issues/6/labels{/name}","comments_url":"https://api.github.com/repos/newrelic/puppet-nrsysmond/issues/6/comments","events_url":"https://api.github.com/repos/newrelic/puppet-nrsysmond/issues/6/events","html_url":"https://github.com/newrelic/puppet-nrsysmond/pull/6","id":56817077,"number":6,"title":"rake, spec and CentOS 7 fixes","user":{"login":"jantman","id":273454,"avatar_url":"https://avatars.githubusercontent.com/u/273454?v=3","gravatar_id":"","url":"https://api.github.com/users/jantman","html_url":"https://github.com/jantman","followers_url":"https://api.github.com/users/jantman/followers","following_url":"https://api.github.com/users/jantman/following{/other_user}","gists_url":"https://api.github.com/users/jantman/gists{/gist_id}","starred_url":"https://api.github.com/users/jantman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jantman/subscriptions","organizations_url":"https://api.github.com/users/jantman/orgs","repos_url":"https://api.github.com/users/jantman/repos","events_url":"https://api.github.com/users/jantman/events{/privacy}","received_events_url":"https://api.github.com/users/jantman/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-02-06T14:22:44Z","updated_at":"2015-03-16T15:45:26Z","closed_at":"2015-03-16T15:45:26Z","pull_request":{"url":"https://api.github.com/repos/newrelic/puppet-nrsysmond/pulls/6","html_url":"https://github.com/newrelic/puppet-nrsysmond/pull/6","diff_url":"https://github.com/newrelic/puppet-nrsysmond/pull/6.diff","patch_url":"https://github.com/newrelic/puppet-nrsysmond/pull/6.patch"},"body":"(1) Fix a number of Rake and spec issues so the tests actually __work__.\r\n\r\n(2) Per https://support.newrelic.com/requests/130089, have Puppet manage the group and user on RedHat 7. This is because of a broken useradd command in the RPM that fails on distros using shadow-utils >= 4.1.5. I strongly disagree with fixing a broken RPM in a Puppet module, but this is what Support told me to do.\r\n\r\nOn a side note:\r\n(1) This module is way out of date in terms of Puppet module standards. It uses a number of deprecated patterns and the spec tests are woefully incomplete. When Puppet4 comes out (which is going to be soon), this module will no longer be functional.\r\n(2) There are a number of places for improvement, such as the exec used to install the Yum repository, when there's a native type for this."},"comment":{"url":"https://api.github.com/repos/newrelic/puppet-nrsysmond/issues/comments/81750770","html_url":"https://github.com/newrelic/puppet-nrsysmond/pull/6#issuecomment-81750770","issue_url":"https://api.github.com/repos/newrelic/puppet-nrsysmond/issues/6","id":81750770,"user":{"login":"jantman","id":273454,"avatar_url":"https://avatars.githubusercontent.com/u/273454?v=3","gravatar_id":"","url":"https://api.github.com/users/jantman","html_url":"https://github.com/jantman","followers_url":"https://api.github.com/users/jantman/followers","following_url":"https://api.github.com/users/jantman/following{/other_user}","gists_url":"https://api.github.com/users/jantman/gists{/gist_id}","starred_url":"https://api.github.com/users/jantman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jantman/subscriptions","organizations_url":"https://api.github.com/users/jantman/orgs","repos_url":"https://api.github.com/users/jantman/repos","events_url":"https://api.github.com/users/jantman/events{/privacy}","received_events_url":"https://api.github.com/users/jantman/received_events","type":"User","site_admin":false},"created_at":"2015-03-16T15:45:26Z","updated_at":"2015-03-16T15:45:26Z","body":"Closing in favor of #7 which has the rakefile/testing/spec fixes but none of the CentOS7/SELinux stuff."}}