{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-pipelines/pulls/comments/28473979","id":28473979,"diff_hunk":"@@ -28,6 +28,7 @@\n import unittest\n import urllib\n import urlparse\n+import pytz","path":"python/test/pipeline_test.py","position":4,"original_position":4,"commit_id":"6365a1d2fc25963f653852e1bf1364058e323a82","original_commit_id":"6365a1d2fc25963f653852e1bf1364058e323a82","user":{"login":"svpino","id":1126730,"avatar_url":"https://avatars.githubusercontent.com/u/1126730?v=3","gravatar_id":"","url":"https://api.github.com/users/svpino","html_url":"https://github.com/svpino","followers_url":"https://api.github.com/users/svpino/followers","following_url":"https://api.github.com/users/svpino/following{/other_user}","gists_url":"https://api.github.com/users/svpino/gists{/gist_id}","starred_url":"https://api.github.com/users/svpino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/svpino/subscriptions","organizations_url":"https://api.github.com/users/svpino/orgs","repos_url":"https://api.github.com/users/svpino/repos","events_url":"https://api.github.com/users/svpino/events{/privacy}","received_events_url":"https://api.github.com/users/svpino/received_events","type":"User","site_admin":false},"body":"It is bundled, yes. It's a standard library.","created_at":"2015-04-15T23:44:33Z","updated_at":"2015-04-15T23:44:33Z","html_url":"https://github.com/GoogleCloudPlatform/appengine-pipelines/pull/28#discussion_r28473979","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-pipelines/pulls/28","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/appengine-pipelines/pulls/comments/28473979"},"html":{"href":"https://github.com/GoogleCloudPlatform/appengine-pipelines/pull/28#discussion_r28473979"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/appengine-pipelines/pulls/28"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-pipelines/pulls/28","id":33315000,"html_url":"https://github.com/GoogleCloudPlatform/appengine-pipelines/pull/28","diff_url":"https://github.com/GoogleCloudPlatform/appengine-pipelines/pull/28.diff","patch_url":"https://github.com/GoogleCloudPlatform/appengine-pipelines/pull/28.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-pipelines/issues/28","number":28,"state":"open","locked":false,"title":"Fixing issue with timezones in unit tests","user":{"login":"svpino","id":1126730,"avatar_url":"https://avatars.githubusercontent.com/u/1126730?v=3","gravatar_id":"","url":"https://api.github.com/users/svpino","html_url":"https://github.com/svpino","followers_url":"https://api.github.com/users/svpino/followers","following_url":"https://api.github.com/users/svpino/following{/other_user}","gists_url":"https://api.github.com/users/svpino/gists{/gist_id}","starred_url":"https://api.github.com/users/svpino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/svpino/subscriptions","organizations_url":"https://api.github.com/users/svpino/orgs","repos_url":"https://api.github.com/users/svpino/repos","events_url":"https://api.github.com/users/svpino/events{/privacy}","received_events_url":"https://api.github.com/users/svpino/received_events","type":"User","site_admin":false},"body":"When you create a task in AppEngine, and you specify a specific ETA, the task will convert the supplied datetime to UTC.\r\n\r\nBy using `datetime.datetime.utcnow()` we get the correct UTC date, but `Task` will convert it internally to UTC again. For example:\r\n\r\n* It's 10:00 EST -05:00\r\n* datetime.datetime.utcnow() returns 14:00 (10:00 + 4h because daylight savings)\r\n* Using this 14:00 to create a `Task` will convert again and return 18:00.\r\n\r\nThe reason is because `datetime.datetime.utcnow()` doesn't add timezone information to the result date.\r\n\r\nA couple of tests aren't passing because of this problem.\r\n\r\nThe solution is to add timezone information to the datetime used to create the task.\r\n","created_at":"2015-04-15T01:14:00Z","updated_at":"2015-04-15T23:44:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2b38631dd8608040edf49ab6fd491dc98c18aab3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-pipelines/pulls/28/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-pipelines/pulls/28/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-pipelines/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-pipelines/issues/28/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-pipelines/statuses/6365a1d2fc25963f653852e1bf1364058e323a82","head":{"label":"svpino:master","ref":"master","sha":"6365a1d2fc25963f653852e1bf1364058e323a82","user":{"login":"svpino","id":1126730,"avatar_url":"https://avatars.githubusercontent.com/u/1126730?v=3","gravatar_id":"","url":"https://api.github.com/users/svpino","html_url":"https://github.com/svpino","followers_url":"https://api.github.com/users/svpino/followers","following_url":"https://api.github.com/users/svpino/following{/other_user}","gists_url":"https://api.github.com/users/svpino/gists{/gist_id}","starred_url":"https://api.github.com/users/svpino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/svpino/subscriptions","organizations_url":"https://api.github.com/users/svpino/orgs","repos_url":"https://api.github.com/users/svpino/repos","events_url":"https://api.github.com/users/svpino/events{/privacy}","received_events_url":"https://api.github.com/users/svpino/received_events","type":"User","site_admin":false},"repo":{"id":33280196,"name":"appengine-pipelines","full_name":"svpino/appengine-pipelines","owner":{"login":"svpino","id":1126730,"avatar_url":"https://avatars.githubusercontent.com/u/1126730?v=3","gravatar_id":"","url":"https://api.github.com/users/svpino","html_url":"https://github.com/svpino","followers_url":"https://api.github.com/users/svpino/followers","following_url":"https://api.github.com/users/svpino/following{/other_user}","gists_url":"https://api.github.com/users/svpino/gists{/gist_id}","starred_url":"https://api.github.com/users/svpino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/svpino/subscriptions","organizations_url":"https://api.github.com/users/svpino/orgs","repos_url":"https://api.github.com/users/svpino/repos","events_url":"https://api.github.com/users/svpino/events{/privacy}","received_events_url":"https://api.github.com/users/svpino/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/svpino/appengine-pipelines","description":null,"fork":true,"url":"https://api.github.com/repos/svpino/appengine-pipelines","forks_url":"https://api.github.com/repos/svpino/appengine-pipelines/forks","keys_url":"https://api.github.com/repos/svpino/appengine-pipelines/keys{/key_id}","collaborators_url":"https://api.github.com/repos/svpino/appengine-pipelines/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/svpino/appengine-pipelines/teams","hooks_url":"https://api.github.com/repos/svpino/appengine-pipelines/hooks","issue_events_url":"https://api.github.com/repos/svpino/appengine-pipelines/issues/events{/number}","events_url":"https://api.github.com/repos/svpino/appengine-pipelines/events","assignees_url":"https://api.github.com/repos/svpino/appengine-pipelines/assignees{/user}","branches_url":"https://api.github.com/repos/svpino/appengine-pipelines/branches{/branch}","tags_url":"https://api.github.com/repos/svpino/appengine-pipelines/tags","blobs_url":"https://api.github.com/repos/svpino/appengine-pipelines/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/svpino/appengine-pipelines/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/svpino/appengine-pipelines/git/refs{/sha}","trees_url":"https://api.github.com/repos/svpino/appengine-pipelines/git/trees{/sha}","statuses_url":"https://api.github.com/repos/svpino/appengine-pipelines/statuses/{sha}","languages_url":"https://api.github.com/repos/svpino/appengine-pipelines/languages","stargazers_url":"https://api.github.com/repos/svpino/appengine-pipelines/stargazers","contributors_url":"https://api.github.com/repos/svpino/appengine-pipelines/contributors","subscribers_url":"https://api.github.com/repos/svpino/appengine-pipelines/subscribers","subscription_url":"https://api.github.com/repos/svpino/appengine-pipelines/subscription","commits_url":"https://api.github.com/repos/svpino/appengine-pipelines/commits{/sha}","git_commits_url":"https://api.github.com/repos/svpino/appengine-pipelines/git/commits{/sha}","comments_url":"https://api.github.com/repos/svpino/appengine-pipelines/comments{/number}","issue_comment_url":"https://api.github.com/repos/svpino/appengine-pipelines/issues/comments{/number}","contents_url":"https://api.github.com/repos/svpino/appengine-pipelines/contents/{+path}","compare_url":"https://api.github.com/repos/svpino/appengine-pipelines/compare/{base}...{head}","merges_url":"https://api.github.com/repos/svpino/appengine-pipelines/merges","archive_url":"https://api.github.com/repos/svpino/appengine-pipelines/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/svpino/appengine-pipelines/downloads","issues_url":"https://api.github.com/repos/svpino/appengine-pipelines/issues{/number}","pulls_url":"https://api.github.com/repos/svpino/appengine-pipelines/pulls{/number}","milestones_url":"https://api.github.com/repos/svpino/appengine-pipelines/milestones{/number}","notifications_url":"https://api.github.com/repos/svpino/appengine-pipelines/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/svpino/appengine-pipelines/labels{/name}","releases_url":"https://api.github.com/repos/svpino/appengine-pipelines/releases{/id}","created_at":"2015-04-02T00:25:28Z","updated_at":"2015-04-15T01:26:41Z","pushed_at":"2015-04-15T01:26:40Z","git_url":"git://github.com/svpino/appengine-pipelines.git","ssh_url":"git@github.com:svpino/appengine-pipelines.git","clone_url":"https://github.com/svpino/appengine-pipelines.git","svn_url":"https://github.com/svpino/appengine-pipelines","homepage":null,"size":1355,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"6a8ca40401c941263190da9b375ee5c3f244b682","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":24478149,"name":"appengine-pipelines","full_name":"GoogleCloudPlatform/appengine-pipelines","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/appengine-pipelines","description":null,"fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-pipelines","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-pipelines/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-pipelines/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-pipelines/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-pipelines/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-pipelines/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-pipelines/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-pipelines/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-pipelines/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-pipelines/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-pipelines/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-pipelines/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-pipelines/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-pipelines/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-pipelines/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-pipelines/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-pipelines/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-pipelines/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-pipelines/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-pipelines/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-pipelines/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-pipelines/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-pipelines/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-pipelines/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-pipelines/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-pipelines/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-pipelines/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-pipelines/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-pipelines/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-pipelines/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-pipelines/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-pipelines/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-pipelines/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-pipelines/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-pipelines/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-pipelines/releases{/id}","created_at":"2014-09-25T22:54:17Z","updated_at":"2015-04-09T23:49:40Z","pushed_at":"2015-04-15T01:26:41Z","git_url":"git://github.com/GoogleCloudPlatform/appengine-pipelines.git","ssh_url":"git@github.com:GoogleCloudPlatform/appengine-pipelines.git","clone_url":"https://github.com/GoogleCloudPlatform/appengine-pipelines.git","svn_url":"https://github.com/GoogleCloudPlatform/appengine-pipelines","homepage":null,"size":2803,"stargazers_count":32,"watchers_count":32,"language":"Python","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":16,"forks":18,"open_issues":16,"watchers":32,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/appengine-pipelines/pulls/28"},"html":{"href":"https://github.com/GoogleCloudPlatform/appengine-pipelines/pull/28"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/appengine-pipelines/issues/28"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/appengine-pipelines/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/appengine-pipelines/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/appengine-pipelines/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/appengine-pipelines/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/appengine-pipelines/statuses/6365a1d2fc25963f653852e1bf1364058e323a82"}}}}