{"action":"created","comment":{"url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/comments/44089563","id":44089563,"diff_hunk":"@@ -1,58 +1,71 @@\n-# Killer facts about triangles AWW YEAH\n+require 'pry'\n+\n+PI = 3.14\n+\n class Triangle\n-\tattr_accessor :side1,:side2,:side3\n-\n-\tdef initialize(side1,side2,side3)\n-\t\t@side1,@side2,@side3 = side1,side2,side3\n-\tend\n-\n-\tdef equilateral()\n-\t\treturn side1 == side2 && side2 == side3\n-\tend\n-\n-\tdef isosceles()\n-\t\treturn [side1,side2,side3].uniq.length == 2\n-\tend\n-\n-\tdef scalene()\n-\t\tunless ! (equilateral || isosceles)\n-\t    false\n-\t  else\n-\t    true\n-\t  end\n-\tend\n-\n-\tdef recite_facts\n-\t\tputs 'This triangle is equilateral!' if equilateral\n-\t\tputs 'This triangle is isosceles! Also, that word is hard to type.' if isosceles \n-\t\tputs 'This triangle is scalene and mathematically boring.' if scalene \n-\n-\t\tangles = self.calculate_angles(side1,side2,side3)\n-\t\tputs 'The angles of this triangle are ' + angles.join(',')\n-\n-\t\tputs 'This triangle is also a right triangle!' if angles.include? 90\n-\t\tputs ''\n-\tend\n-\n-\tdef calculate_angles(a,b,c)\n-\t\tangleA = radians_to_degrees(Math.acos((b**2 + c**2 - a**2) / (2.0 * b * c)))\n-\t\tangleB = radians_to_degrees(Math.acos((a**2 + c**2 - b**2) / (2.0 * a * c)))\n-\t\tangleC = radians_to_degrees(Math.acos((a**2 + b**2 - c**2) / (2.0 * a * b)))\n-\n-\t\treturn [angleA, angleB, angleC]\n-\tend\n-\n-\tdef radians_to_degrees(rads)\n-\t\treturn (rads * 180 / Math::PI).round\n-\tend\n-end\n+  attr_accessor :side1, :side2, :side3, :all\n+  def initialize(side1, side2, side3)","path":"triangle_facts/triangle_facts.rb","position":54,"original_position":54,"commit_id":"f2ec738d8b2ffab901ab921f2cd3f6f078b10aaf","original_commit_id":"f2ec738d8b2ffab901ab921f2cd3f6f078b10aaf","user":{"login":"paulghaddad","id":1412714,"avatar_url":"https://avatars.githubusercontent.com/u/1412714?v=3","gravatar_id":"","url":"https://api.github.com/users/paulghaddad","html_url":"https://github.com/paulghaddad","followers_url":"https://api.github.com/users/paulghaddad/followers","following_url":"https://api.github.com/users/paulghaddad/following{/other_user}","gists_url":"https://api.github.com/users/paulghaddad/gists{/gist_id}","starred_url":"https://api.github.com/users/paulghaddad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulghaddad/subscriptions","organizations_url":"https://api.github.com/users/paulghaddad/orgs","repos_url":"https://api.github.com/users/paulghaddad/repos","events_url":"https://api.github.com/users/paulghaddad/events{/privacy}","received_events_url":"https://api.github.com/users/paulghaddad/received_events","type":"User","site_admin":false},"body":"Also check out keyword arguments; just another option. See:\r\n\r\nhttps://robots.thoughtbot.com/ruby-2-keyword-arguments","created_at":"2015-11-06T00:22:50Z","updated_at":"2015-11-06T00:22:50Z","html_url":"https://github.com/jmmastey/level_up_exercises/pull/1044#discussion_r44089563","pull_request_url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/1044","_links":{"self":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/comments/44089563"},"html":{"href":"https://github.com/jmmastey/level_up_exercises/pull/1044#discussion_r44089563"},"pull_request":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/1044"}}},"pull_request":{"url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/1044","id":49899231,"html_url":"https://github.com/jmmastey/level_up_exercises/pull/1044","diff_url":"https://github.com/jmmastey/level_up_exercises/pull/1044.diff","patch_url":"https://github.com/jmmastey/level_up_exercises/pull/1044.patch","issue_url":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/1044","number":1044,"state":"open","locked":false,"title":"Refactor Ruby code to reflect Style Guide; Add Rspec test","user":{"login":"creativisionist","id":10764566,"avatar_url":"https://avatars.githubusercontent.com/u/10764566?v=3","gravatar_id":"","url":"https://api.github.com/users/creativisionist","html_url":"https://github.com/creativisionist","followers_url":"https://api.github.com/users/creativisionist/followers","following_url":"https://api.github.com/users/creativisionist/following{/other_user}","gists_url":"https://api.github.com/users/creativisionist/gists{/gist_id}","starred_url":"https://api.github.com/users/creativisionist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/creativisionist/subscriptions","organizations_url":"https://api.github.com/users/creativisionist/orgs","repos_url":"https://api.github.com/users/creativisionist/repos","events_url":"https://api.github.com/users/creativisionist/events{/privacy}","received_events_url":"https://api.github.com/users/creativisionist/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-11-06T00:01:45Z","updated_at":"2015-11-06T00:22:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"db200ae3f1d68daaba53b62033d9a2cc36701f48","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/1044/commits","review_comments_url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/1044/comments","review_comment_url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/1044/comments","statuses_url":"https://api.github.com/repos/jmmastey/level_up_exercises/statuses/f2ec738d8b2ffab901ab921f2cd3f6f078b10aaf","head":{"label":"creativisionist:an-ruby","ref":"an-ruby","sha":"f2ec738d8b2ffab901ab921f2cd3f6f078b10aaf","user":{"login":"creativisionist","id":10764566,"avatar_url":"https://avatars.githubusercontent.com/u/10764566?v=3","gravatar_id":"","url":"https://api.github.com/users/creativisionist","html_url":"https://github.com/creativisionist","followers_url":"https://api.github.com/users/creativisionist/followers","following_url":"https://api.github.com/users/creativisionist/following{/other_user}","gists_url":"https://api.github.com/users/creativisionist/gists{/gist_id}","starred_url":"https://api.github.com/users/creativisionist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/creativisionist/subscriptions","organizations_url":"https://api.github.com/users/creativisionist/orgs","repos_url":"https://api.github.com/users/creativisionist/repos","events_url":"https://api.github.com/users/creativisionist/events{/privacy}","received_events_url":"https://api.github.com/users/creativisionist/received_events","type":"User","site_admin":false},"repo":{"id":45402867,"name":"level_up_exercises","full_name":"creativisionist/level_up_exercises","owner":{"login":"creativisionist","id":10764566,"avatar_url":"https://avatars.githubusercontent.com/u/10764566?v=3","gravatar_id":"","url":"https://api.github.com/users/creativisionist","html_url":"https://github.com/creativisionist","followers_url":"https://api.github.com/users/creativisionist/followers","following_url":"https://api.github.com/users/creativisionist/following{/other_user}","gists_url":"https://api.github.com/users/creativisionist/gists{/gist_id}","starred_url":"https://api.github.com/users/creativisionist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/creativisionist/subscriptions","organizations_url":"https://api.github.com/users/creativisionist/orgs","repos_url":"https://api.github.com/users/creativisionist/repos","events_url":"https://api.github.com/users/creativisionist/events{/privacy}","received_events_url":"https://api.github.com/users/creativisionist/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/creativisionist/level_up_exercises","description":"A series of code-related assignments to challenge starting engineers","fork":true,"url":"https://api.github.com/repos/creativisionist/level_up_exercises","forks_url":"https://api.github.com/repos/creativisionist/level_up_exercises/forks","keys_url":"https://api.github.com/repos/creativisionist/level_up_exercises/keys{/key_id}","collaborators_url":"https://api.github.com/repos/creativisionist/level_up_exercises/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/creativisionist/level_up_exercises/teams","hooks_url":"https://api.github.com/repos/creativisionist/level_up_exercises/hooks","issue_events_url":"https://api.github.com/repos/creativisionist/level_up_exercises/issues/events{/number}","events_url":"https://api.github.com/repos/creativisionist/level_up_exercises/events","assignees_url":"https://api.github.com/repos/creativisionist/level_up_exercises/assignees{/user}","branches_url":"https://api.github.com/repos/creativisionist/level_up_exercises/branches{/branch}","tags_url":"https://api.github.com/repos/creativisionist/level_up_exercises/tags","blobs_url":"https://api.github.com/repos/creativisionist/level_up_exercises/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/creativisionist/level_up_exercises/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/creativisionist/level_up_exercises/git/refs{/sha}","trees_url":"https://api.github.com/repos/creativisionist/level_up_exercises/git/trees{/sha}","statuses_url":"https://api.github.com/repos/creativisionist/level_up_exercises/statuses/{sha}","languages_url":"https://api.github.com/repos/creativisionist/level_up_exercises/languages","stargazers_url":"https://api.github.com/repos/creativisionist/level_up_exercises/stargazers","contributors_url":"https://api.github.com/repos/creativisionist/level_up_exercises/contributors","subscribers_url":"https://api.github.com/repos/creativisionist/level_up_exercises/subscribers","subscription_url":"https://api.github.com/repos/creativisionist/level_up_exercises/subscription","commits_url":"https://api.github.com/repos/creativisionist/level_up_exercises/commits{/sha}","git_commits_url":"https://api.github.com/repos/creativisionist/level_up_exercises/git/commits{/sha}","comments_url":"https://api.github.com/repos/creativisionist/level_up_exercises/comments{/number}","issue_comment_url":"https://api.github.com/repos/creativisionist/level_up_exercises/issues/comments{/number}","contents_url":"https://api.github.com/repos/creativisionist/level_up_exercises/contents/{+path}","compare_url":"https://api.github.com/repos/creativisionist/level_up_exercises/compare/{base}...{head}","merges_url":"https://api.github.com/repos/creativisionist/level_up_exercises/merges","archive_url":"https://api.github.com/repos/creativisionist/level_up_exercises/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/creativisionist/level_up_exercises/downloads","issues_url":"https://api.github.com/repos/creativisionist/level_up_exercises/issues{/number}","pulls_url":"https://api.github.com/repos/creativisionist/level_up_exercises/pulls{/number}","milestones_url":"https://api.github.com/repos/creativisionist/level_up_exercises/milestones{/number}","notifications_url":"https://api.github.com/repos/creativisionist/level_up_exercises/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/creativisionist/level_up_exercises/labels{/name}","releases_url":"https://api.github.com/repos/creativisionist/level_up_exercises/releases{/id}","created_at":"2015-11-02T15:24:51Z","updated_at":"2015-11-02T15:24:51Z","pushed_at":"2015-11-06T00:00:42Z","git_url":"git://github.com/creativisionist/level_up_exercises.git","ssh_url":"git@github.com:creativisionist/level_up_exercises.git","clone_url":"https://github.com/creativisionist/level_up_exercises.git","svn_url":"https://github.com/creativisionist/level_up_exercises","homepage":"https://leveluprails.com","size":311,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jmmastey:master","ref":"master","sha":"ee878bc2c9a3337ffa3372654f508733dd2f66c1","user":{"login":"jmmastey","id":302011,"avatar_url":"https://avatars.githubusercontent.com/u/302011?v=3","gravatar_id":"","url":"https://api.github.com/users/jmmastey","html_url":"https://github.com/jmmastey","followers_url":"https://api.github.com/users/jmmastey/followers","following_url":"https://api.github.com/users/jmmastey/following{/other_user}","gists_url":"https://api.github.com/users/jmmastey/gists{/gist_id}","starred_url":"https://api.github.com/users/jmmastey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmmastey/subscriptions","organizations_url":"https://api.github.com/users/jmmastey/orgs","repos_url":"https://api.github.com/users/jmmastey/repos","events_url":"https://api.github.com/users/jmmastey/events{/privacy}","received_events_url":"https://api.github.com/users/jmmastey/received_events","type":"User","site_admin":false},"repo":{"id":20705648,"name":"level_up_exercises","full_name":"jmmastey/level_up_exercises","owner":{"login":"jmmastey","id":302011,"avatar_url":"https://avatars.githubusercontent.com/u/302011?v=3","gravatar_id":"","url":"https://api.github.com/users/jmmastey","html_url":"https://github.com/jmmastey","followers_url":"https://api.github.com/users/jmmastey/followers","following_url":"https://api.github.com/users/jmmastey/following{/other_user}","gists_url":"https://api.github.com/users/jmmastey/gists{/gist_id}","starred_url":"https://api.github.com/users/jmmastey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmmastey/subscriptions","organizations_url":"https://api.github.com/users/jmmastey/orgs","repos_url":"https://api.github.com/users/jmmastey/repos","events_url":"https://api.github.com/users/jmmastey/events{/privacy}","received_events_url":"https://api.github.com/users/jmmastey/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jmmastey/level_up_exercises","description":"A series of code-related assignments to challenge starting engineers","fork":false,"url":"https://api.github.com/repos/jmmastey/level_up_exercises","forks_url":"https://api.github.com/repos/jmmastey/level_up_exercises/forks","keys_url":"https://api.github.com/repos/jmmastey/level_up_exercises/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jmmastey/level_up_exercises/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jmmastey/level_up_exercises/teams","hooks_url":"https://api.github.com/repos/jmmastey/level_up_exercises/hooks","issue_events_url":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/events{/number}","events_url":"https://api.github.com/repos/jmmastey/level_up_exercises/events","assignees_url":"https://api.github.com/repos/jmmastey/level_up_exercises/assignees{/user}","branches_url":"https://api.github.com/repos/jmmastey/level_up_exercises/branches{/branch}","tags_url":"https://api.github.com/repos/jmmastey/level_up_exercises/tags","blobs_url":"https://api.github.com/repos/jmmastey/level_up_exercises/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jmmastey/level_up_exercises/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jmmastey/level_up_exercises/git/refs{/sha}","trees_url":"https://api.github.com/repos/jmmastey/level_up_exercises/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jmmastey/level_up_exercises/statuses/{sha}","languages_url":"https://api.github.com/repos/jmmastey/level_up_exercises/languages","stargazers_url":"https://api.github.com/repos/jmmastey/level_up_exercises/stargazers","contributors_url":"https://api.github.com/repos/jmmastey/level_up_exercises/contributors","subscribers_url":"https://api.github.com/repos/jmmastey/level_up_exercises/subscribers","subscription_url":"https://api.github.com/repos/jmmastey/level_up_exercises/subscription","commits_url":"https://api.github.com/repos/jmmastey/level_up_exercises/commits{/sha}","git_commits_url":"https://api.github.com/repos/jmmastey/level_up_exercises/git/commits{/sha}","comments_url":"https://api.github.com/repos/jmmastey/level_up_exercises/comments{/number}","issue_comment_url":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/comments{/number}","contents_url":"https://api.github.com/repos/jmmastey/level_up_exercises/contents/{+path}","compare_url":"https://api.github.com/repos/jmmastey/level_up_exercises/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jmmastey/level_up_exercises/merges","archive_url":"https://api.github.com/repos/jmmastey/level_up_exercises/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jmmastey/level_up_exercises/downloads","issues_url":"https://api.github.com/repos/jmmastey/level_up_exercises/issues{/number}","pulls_url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls{/number}","milestones_url":"https://api.github.com/repos/jmmastey/level_up_exercises/milestones{/number}","notifications_url":"https://api.github.com/repos/jmmastey/level_up_exercises/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jmmastey/level_up_exercises/labels{/name}","releases_url":"https://api.github.com/repos/jmmastey/level_up_exercises/releases{/id}","created_at":"2014-06-10T23:42:24Z","updated_at":"2015-11-05T01:28:26Z","pushed_at":"2015-11-06T00:01:45Z","git_url":"git://github.com/jmmastey/level_up_exercises.git","ssh_url":"git@github.com:jmmastey/level_up_exercises.git","clone_url":"https://github.com/jmmastey/level_up_exercises.git","svn_url":"https://github.com/jmmastey/level_up_exercises","homepage":"https://leveluprails.com","size":223483,"stargazers_count":31,"watchers_count":31,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":152,"mirror_url":null,"open_issues_count":5,"forks":152,"open_issues":5,"watchers":31,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/1044"},"html":{"href":"https://github.com/jmmastey/level_up_exercises/pull/1044"},"issue":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/1044"},"comments":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/1044/comments"},"review_comments":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/1044/comments"},"review_comment":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/1044/commits"},"statuses":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/statuses/f2ec738d8b2ffab901ab921f2cd3f6f078b10aaf"}}}}