{"push_id":782903363,"size":8,"distinct_size":1,"ref":"refs/heads/pmattis/sql-auto-txn","head":"f03bb8dc0fe629ba322b895823a71f29a3ea0c9c","before":"cdb2a9c1545f5a87ccbe6d75931fb49037b28199","commits":[{"sha":"a6c8f096d8c0fbfca459e58122ac61d7c8d86a3a","author":{"email":"c96a05aaafbe4b3abc1841a4083a1b0f402c2ba6@gmail.com","name":"Tamir Duberstein"},"message":"sql/driver: misc cleanup\n\n- sql/driver/conn.go: variable renaming\n- sql/driver/conn.go: small refactoring\n- sql/driver/conn.go: avoid copying a slice\n- sql/driver/conn.go: Exec avoids conversion to rows\n- static interface implementation assertions\n- sql/driver.Value implements `driver.Valuer`","distinct":false,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/a6c8f096d8c0fbfca459e58122ac61d7c8d86a3a"},{"sha":"d4d8ea97653d5753c8e15c65371020cbef8d00ee","author":{"email":"c96a05aaafbe4b3abc1841a4083a1b0f402c2ba6@gmail.com","name":"Tamir Duberstein"},"message":"Merge pull request #2375 from tamird/sql-clean-up\n\nsql/driver: misc cleanup","distinct":false,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/d4d8ea97653d5753c8e15c65371020cbef8d00ee"},{"sha":"be0d893fe37163642db1fc2ff44d1920e3106ef0","author":{"email":"c96a05aaafbe4b3abc1841a4083a1b0f402c2ba6@gmail.com","name":"Tamir Duberstein"},"message":"sql: move errors closer to uses","distinct":false,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/be0d893fe37163642db1fc2ff44d1920e3106ef0"},{"sha":"e632ef2df35b83dd630b0936ab80d3feea76bf84","author":{"email":"c96a05aaafbe4b3abc1841a4083a1b0f402c2ba6@gmail.com","name":"Tamir Duberstein"},"message":"Merge pull request #2388 from tamird/sql-error-cleanup\n\nsql: move errors closer to uses","distinct":false,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/e632ef2df35b83dd630b0936ab80d3feea76bf84"},{"sha":"c4f03a11470a9b291ec45a2cffd4b9318993b225","author":{"email":"c96a05aaafbe4b3abc1841a4083a1b0f402c2ba6@gmail.com","name":"Tamir Duberstein"},"message":"client: speed up tests as was done in #2385","distinct":false,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/c4f03a11470a9b291ec45a2cffd4b9318993b225"},{"sha":"b667120d1f94c5c1af40e0205d9d4d02b968d226","author":{"email":"c96a05aaafbe4b3abc1841a4083a1b0f402c2ba6@gmail.com","name":"Tamir Duberstein"},"message":"Merge pull request #2389 from tamird/speed-up-client-tests\n\nclient: speed up tests as was done in #2385","distinct":false,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/b667120d1f94c5c1af40e0205d9d4d02b968d226"},{"sha":"acbc02b1f4c6f1f7bd6f3532e61c036dc7c7e8a2","author":{"email":"4b8373d016f277527198385ba72fda0feb5da015@cockroachlabs.com","name":"Peter Mattis"},"message":"Merge pull request #2380 from cockroachdb/pmattis/sql-txn\n\nFix handling of txn commit errors.","distinct":false,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/acbc02b1f4c6f1f7bd6f3532e61c036dc7c7e8a2"},{"sha":"f03bb8dc0fe629ba322b895823a71f29a3ea0c9c","author":{"email":"b25b72a65195e46aa49449589ffbea257ff840a3@gmail.com","name":"Peter Mattis"},"message":"Fix two bugs in auto-transactions.\n\nThe first bug was obvious and not currently harmful: we were creating\nthe plan node inside the retryable function passed to DB.Txn(), but then\nexecuting it outside. This happened to work because mutating plans\ncurrently do there work during plan creation and read-only\nplans (e.g. SELECT) were unsafely using a committed transaction record.\n\nThe second bug was much more subtle. When retrying an\nauto-transaction (i.e. an SQL statement executed outside of a BEGIN/END\nblock) we were passing the same parsed statement for execution. But\nstatement execution (i.e. SELECT) modifies the parsed statement,\nperforming normalization (ok) and resolving qualified names. The name\nresolution (scanNode.resolveQNames) was not properly handling a parsed\nstatement for which name resolution had already been performed. The\nresult was that qualified names were not properly looked up on retries,\nusing values determined during the first attempt at the transaction.\n\nAdded -transfer-style flag to sql_bank and a new optimized SQL style\nthat moves money in a single UPDATE statement. Removed the timing\nwarnings now that the egregious problems with statement execution have\nbeen fixed. The remaining warnings were mainly just annoyance.","distinct":true,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/f03bb8dc0fe629ba322b895823a71f29a3ea0c9c"}]}