{"action":"created","comment":{"url":"https://api.github.com/repos/UV-CDAT/uvcdat/pulls/comments/25820002","id":25820002,"diff_hunk":"@@ -26,21 +26,21 @@ list(APPEND vtk_build_args\n )\n \n # Use cdat zlib\n-if(NOT CDAT_USE_SYSTEM_ZLIB)\n-  list(APPEND vtk_build_args\n-    -DZLIB_INCLUDE_DIR:PATH=${cdat_EXTERNALS}/include\n-    -DZLIB_LIBRARY:FILEPATH=${cdat_EXTERNALS}/lib/libz${_LINK_LIBRARY_SUFFIX}\n-  )\n-endif()\n+#if(NOT CDAT_USE_SYSTEM_ZLIB)","path":"CMake/cdat_modules/vtk_external.cmake","position":10,"original_position":10,"commit_id":"b4f4d7ad88f97449baf2c62b9b33fe4d63026fac","original_commit_id":"b4f4d7ad88f97449baf2c62b9b33fe4d63026fac","user":{"login":"doutriaux1","id":2781425,"avatar_url":"https://avatars.githubusercontent.com/u/2781425?v=3","gravatar_id":"","url":"https://api.github.com/users/doutriaux1","html_url":"https://github.com/doutriaux1","followers_url":"https://api.github.com/users/doutriaux1/followers","following_url":"https://api.github.com/users/doutriaux1/following{/other_user}","gists_url":"https://api.github.com/users/doutriaux1/gists{/gist_id}","starred_url":"https://api.github.com/users/doutriaux1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doutriaux1/subscriptions","organizations_url":"https://api.github.com/users/doutriaux1/orgs","repos_url":"https://api.github.com/users/doutriaux1/repos","events_url":"https://api.github.com/users/doutriaux1/events{/privacy}","received_events_url":"https://api.github.com/users/doutriaux1/received_events","type":"User","site_admin":false},"body":"yes I turned off zlib and libxml2 libxslt etc.. there are on every system. I guess we can uncomment if you want but I'm not positive about what happen to CDAT_USE_SYSTEM_ZLIB now that we don't have include(libz_pkg)","created_at":"2015-03-04T22:15:35Z","updated_at":"2015-03-04T22:15:35Z","html_url":"https://github.com/UV-CDAT/uvcdat/pull/1110#discussion_r25820002","pull_request_url":"https://api.github.com/repos/UV-CDAT/uvcdat/pulls/1110","_links":{"self":{"href":"https://api.github.com/repos/UV-CDAT/uvcdat/pulls/comments/25820002"},"html":{"href":"https://github.com/UV-CDAT/uvcdat/pull/1110#discussion_r25820002"},"pull_request":{"href":"https://api.github.com/repos/UV-CDAT/uvcdat/pulls/1110"}}},"pull_request":{"url":"https://api.github.com/repos/UV-CDAT/uvcdat/pulls/1110","id":30430380,"html_url":"https://github.com/UV-CDAT/uvcdat/pull/1110","diff_url":"https://github.com/UV-CDAT/uvcdat/pull/1110.diff","patch_url":"https://github.com/UV-CDAT/uvcdat/pull/1110.patch","issue_url":"https://api.github.com/repos/UV-CDAT/uvcdat/issues/1110","number":1110,"state":"open","locked":false,"title":"Now we can build on Yosemite ","user":{"login":"doutriaux1","id":2781425,"avatar_url":"https://avatars.githubusercontent.com/u/2781425?v=3","gravatar_id":"","url":"https://api.github.com/users/doutriaux1","html_url":"https://github.com/doutriaux1","followers_url":"https://api.github.com/users/doutriaux1/followers","following_url":"https://api.github.com/users/doutriaux1/following{/other_user}","gists_url":"https://api.github.com/users/doutriaux1/gists{/gist_id}","starred_url":"https://api.github.com/users/doutriaux1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doutriaux1/subscriptions","organizations_url":"https://api.github.com/users/doutriaux1/orgs","repos_url":"https://api.github.com/users/doutriaux1/repos","events_url":"https://api.github.com/users/doutriaux1/events{/privacy}","received_events_url":"https://api.github.com/users/doutriaux1/received_events","type":"User","site_admin":false},"body":"@aashish24 @dlonie @jbeezley  @chaosphere2112 please test and review","created_at":"2015-03-04T01:25:37Z","updated_at":"2015-03-04T22:15:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"237186d04000838018a772626e2a6efdc603f996","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/UV-CDAT/uvcdat/pulls/1110/commits","review_comments_url":"https://api.github.com/repos/UV-CDAT/uvcdat/pulls/1110/comments","review_comment_url":"https://api.github.com/repos/UV-CDAT/uvcdat/pulls/comments{/number}","comments_url":"https://api.github.com/repos/UV-CDAT/uvcdat/issues/1110/comments","statuses_url":"https://api.github.com/repos/UV-CDAT/uvcdat/statuses/b4f4d7ad88f97449baf2c62b9b33fe4d63026fac","head":{"label":"UV-CDAT:Yosemite","ref":"Yosemite","sha":"b4f4d7ad88f97449baf2c62b9b33fe4d63026fac","user":{"login":"UV-CDAT","id":2781444,"avatar_url":"https://avatars.githubusercontent.com/u/2781444?v=3","gravatar_id":"","url":"https://api.github.com/users/UV-CDAT","html_url":"https://github.com/UV-CDAT","followers_url":"https://api.github.com/users/UV-CDAT/followers","following_url":"https://api.github.com/users/UV-CDAT/following{/other_user}","gists_url":"https://api.github.com/users/UV-CDAT/gists{/gist_id}","starred_url":"https://api.github.com/users/UV-CDAT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UV-CDAT/subscriptions","organizations_url":"https://api.github.com/users/UV-CDAT/orgs","repos_url":"https://api.github.com/users/UV-CDAT/repos","events_url":"https://api.github.com/users/UV-CDAT/events{/privacy}","received_events_url":"https://api.github.com/users/UV-CDAT/received_events","type":"Organization","site_admin":false},"repo":{"id":6660536,"name":"uvcdat","full_name":"UV-CDAT/uvcdat","owner":{"login":"UV-CDAT","id":2781444,"avatar_url":"https://avatars.githubusercontent.com/u/2781444?v=3","gravatar_id":"","url":"https://api.github.com/users/UV-CDAT","html_url":"https://github.com/UV-CDAT","followers_url":"https://api.github.com/users/UV-CDAT/followers","following_url":"https://api.github.com/users/UV-CDAT/following{/other_user}","gists_url":"https://api.github.com/users/UV-CDAT/gists{/gist_id}","starred_url":"https://api.github.com/users/UV-CDAT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UV-CDAT/subscriptions","organizations_url":"https://api.github.com/users/UV-CDAT/orgs","repos_url":"https://api.github.com/users/UV-CDAT/repos","events_url":"https://api.github.com/users/UV-CDAT/events{/privacy}","received_events_url":"https://api.github.com/users/UV-CDAT/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/UV-CDAT/uvcdat","description":"Ultrascale Visualization Climate Data Analysis Tools","fork":false,"url":"https://api.github.com/repos/UV-CDAT/uvcdat","forks_url":"https://api.github.com/repos/UV-CDAT/uvcdat/forks","keys_url":"https://api.github.com/repos/UV-CDAT/uvcdat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UV-CDAT/uvcdat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UV-CDAT/uvcdat/teams","hooks_url":"https://api.github.com/repos/UV-CDAT/uvcdat/hooks","issue_events_url":"https://api.github.com/repos/UV-CDAT/uvcdat/issues/events{/number}","events_url":"https://api.github.com/repos/UV-CDAT/uvcdat/events","assignees_url":"https://api.github.com/repos/UV-CDAT/uvcdat/assignees{/user}","branches_url":"https://api.github.com/repos/UV-CDAT/uvcdat/branches{/branch}","tags_url":"https://api.github.com/repos/UV-CDAT/uvcdat/tags","blobs_url":"https://api.github.com/repos/UV-CDAT/uvcdat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UV-CDAT/uvcdat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UV-CDAT/uvcdat/git/refs{/sha}","trees_url":"https://api.github.com/repos/UV-CDAT/uvcdat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UV-CDAT/uvcdat/statuses/{sha}","languages_url":"https://api.github.com/repos/UV-CDAT/uvcdat/languages","stargazers_url":"https://api.github.com/repos/UV-CDAT/uvcdat/stargazers","contributors_url":"https://api.github.com/repos/UV-CDAT/uvcdat/contributors","subscribers_url":"https://api.github.com/repos/UV-CDAT/uvcdat/subscribers","subscription_url":"https://api.github.com/repos/UV-CDAT/uvcdat/subscription","commits_url":"https://api.github.com/repos/UV-CDAT/uvcdat/commits{/sha}","git_commits_url":"https://api.github.com/repos/UV-CDAT/uvcdat/git/commits{/sha}","comments_url":"https://api.github.com/repos/UV-CDAT/uvcdat/comments{/number}","issue_comment_url":"https://api.github.com/repos/UV-CDAT/uvcdat/issues/comments{/number}","contents_url":"https://api.github.com/repos/UV-CDAT/uvcdat/contents/{+path}","compare_url":"https://api.github.com/repos/UV-CDAT/uvcdat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UV-CDAT/uvcdat/merges","archive_url":"https://api.github.com/repos/UV-CDAT/uvcdat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UV-CDAT/uvcdat/downloads","issues_url":"https://api.github.com/repos/UV-CDAT/uvcdat/issues{/number}","pulls_url":"https://api.github.com/repos/UV-CDAT/uvcdat/pulls{/number}","milestones_url":"https://api.github.com/repos/UV-CDAT/uvcdat/milestones{/number}","notifications_url":"https://api.github.com/repos/UV-CDAT/uvcdat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UV-CDAT/uvcdat/labels{/name}","releases_url":"https://api.github.com/repos/UV-CDAT/uvcdat/releases{/id}","created_at":"2012-11-12T20:58:18Z","updated_at":"2015-03-04T19:44:43Z","pushed_at":"2015-03-04T19:44:51Z","git_url":"git://github.com/UV-CDAT/uvcdat.git","ssh_url":"git@github.com:UV-CDAT/uvcdat.git","clone_url":"https://github.com/UV-CDAT/uvcdat.git","svn_url":"https://github.com/UV-CDAT/uvcdat","homepage":null,"size":300975,"stargazers_count":32,"watchers_count":32,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":27,"mirror_url":null,"open_issues_count":174,"forks":27,"open_issues":174,"watchers":32,"default_branch":"master"}},"base":{"label":"UV-CDAT:master","ref":"master","sha":"267e6cdc81f66b37f6592f4047d863dbb99d98b1","user":{"login":"UV-CDAT","id":2781444,"avatar_url":"https://avatars.githubusercontent.com/u/2781444?v=3","gravatar_id":"","url":"https://api.github.com/users/UV-CDAT","html_url":"https://github.com/UV-CDAT","followers_url":"https://api.github.com/users/UV-CDAT/followers","following_url":"https://api.github.com/users/UV-CDAT/following{/other_user}","gists_url":"https://api.github.com/users/UV-CDAT/gists{/gist_id}","starred_url":"https://api.github.com/users/UV-CDAT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UV-CDAT/subscriptions","organizations_url":"https://api.github.com/users/UV-CDAT/orgs","repos_url":"https://api.github.com/users/UV-CDAT/repos","events_url":"https://api.github.com/users/UV-CDAT/events{/privacy}","received_events_url":"https://api.github.com/users/UV-CDAT/received_events","type":"Organization","site_admin":false},"repo":{"id":6660536,"name":"uvcdat","full_name":"UV-CDAT/uvcdat","owner":{"login":"UV-CDAT","id":2781444,"avatar_url":"https://avatars.githubusercontent.com/u/2781444?v=3","gravatar_id":"","url":"https://api.github.com/users/UV-CDAT","html_url":"https://github.com/UV-CDAT","followers_url":"https://api.github.com/users/UV-CDAT/followers","following_url":"https://api.github.com/users/UV-CDAT/following{/other_user}","gists_url":"https://api.github.com/users/UV-CDAT/gists{/gist_id}","starred_url":"https://api.github.com/users/UV-CDAT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UV-CDAT/subscriptions","organizations_url":"https://api.github.com/users/UV-CDAT/orgs","repos_url":"https://api.github.com/users/UV-CDAT/repos","events_url":"https://api.github.com/users/UV-CDAT/events{/privacy}","received_events_url":"https://api.github.com/users/UV-CDAT/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/UV-CDAT/uvcdat","description":"Ultrascale Visualization Climate Data Analysis Tools","fork":false,"url":"https://api.github.com/repos/UV-CDAT/uvcdat","forks_url":"https://api.github.com/repos/UV-CDAT/uvcdat/forks","keys_url":"https://api.github.com/repos/UV-CDAT/uvcdat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UV-CDAT/uvcdat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UV-CDAT/uvcdat/teams","hooks_url":"https://api.github.com/repos/UV-CDAT/uvcdat/hooks","issue_events_url":"https://api.github.com/repos/UV-CDAT/uvcdat/issues/events{/number}","events_url":"https://api.github.com/repos/UV-CDAT/uvcdat/events","assignees_url":"https://api.github.com/repos/UV-CDAT/uvcdat/assignees{/user}","branches_url":"https://api.github.com/repos/UV-CDAT/uvcdat/branches{/branch}","tags_url":"https://api.github.com/repos/UV-CDAT/uvcdat/tags","blobs_url":"https://api.github.com/repos/UV-CDAT/uvcdat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UV-CDAT/uvcdat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UV-CDAT/uvcdat/git/refs{/sha}","trees_url":"https://api.github.com/repos/UV-CDAT/uvcdat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UV-CDAT/uvcdat/statuses/{sha}","languages_url":"https://api.github.com/repos/UV-CDAT/uvcdat/languages","stargazers_url":"https://api.github.com/repos/UV-CDAT/uvcdat/stargazers","contributors_url":"https://api.github.com/repos/UV-CDAT/uvcdat/contributors","subscribers_url":"https://api.github.com/repos/UV-CDAT/uvcdat/subscribers","subscription_url":"https://api.github.com/repos/UV-CDAT/uvcdat/subscription","commits_url":"https://api.github.com/repos/UV-CDAT/uvcdat/commits{/sha}","git_commits_url":"https://api.github.com/repos/UV-CDAT/uvcdat/git/commits{/sha}","comments_url":"https://api.github.com/repos/UV-CDAT/uvcdat/comments{/number}","issue_comment_url":"https://api.github.com/repos/UV-CDAT/uvcdat/issues/comments{/number}","contents_url":"https://api.github.com/repos/UV-CDAT/uvcdat/contents/{+path}","compare_url":"https://api.github.com/repos/UV-CDAT/uvcdat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UV-CDAT/uvcdat/merges","archive_url":"https://api.github.com/repos/UV-CDAT/uvcdat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UV-CDAT/uvcdat/downloads","issues_url":"https://api.github.com/repos/UV-CDAT/uvcdat/issues{/number}","pulls_url":"https://api.github.com/repos/UV-CDAT/uvcdat/pulls{/number}","milestones_url":"https://api.github.com/repos/UV-CDAT/uvcdat/milestones{/number}","notifications_url":"https://api.github.com/repos/UV-CDAT/uvcdat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UV-CDAT/uvcdat/labels{/name}","releases_url":"https://api.github.com/repos/UV-CDAT/uvcdat/releases{/id}","created_at":"2012-11-12T20:58:18Z","updated_at":"2015-03-04T19:44:43Z","pushed_at":"2015-03-04T19:44:51Z","git_url":"git://github.com/UV-CDAT/uvcdat.git","ssh_url":"git@github.com:UV-CDAT/uvcdat.git","clone_url":"https://github.com/UV-CDAT/uvcdat.git","svn_url":"https://github.com/UV-CDAT/uvcdat","homepage":null,"size":300975,"stargazers_count":32,"watchers_count":32,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":27,"mirror_url":null,"open_issues_count":174,"forks":27,"open_issues":174,"watchers":32,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/UV-CDAT/uvcdat/pulls/1110"},"html":{"href":"https://github.com/UV-CDAT/uvcdat/pull/1110"},"issue":{"href":"https://api.github.com/repos/UV-CDAT/uvcdat/issues/1110"},"comments":{"href":"https://api.github.com/repos/UV-CDAT/uvcdat/issues/1110/comments"},"review_comments":{"href":"https://api.github.com/repos/UV-CDAT/uvcdat/pulls/1110/comments"},"review_comment":{"href":"https://api.github.com/repos/UV-CDAT/uvcdat/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/UV-CDAT/uvcdat/pulls/1110/commits"},"statuses":{"href":"https://api.github.com/repos/UV-CDAT/uvcdat/statuses/b4f4d7ad88f97449baf2c62b9b33fe4d63026fac"}}}}