{"action":"closed","number":242,"pull_request":{"url":"https://api.github.com/repos/apache/cordova-lib/pulls/242","id":37279705,"html_url":"https://github.com/apache/cordova-lib/pull/242","diff_url":"https://github.com/apache/cordova-lib/pull/242.diff","patch_url":"https://github.com/apache/cordova-lib/pull/242.patch","issue_url":"https://api.github.com/repos/apache/cordova-lib/issues/242","number":242,"state":"closed","locked":false,"title":"fix CB-9145 prepare can lose data during config munge","user":{"login":"tony--","id":513830,"avatar_url":"https://avatars.githubusercontent.com/u/513830?v=3","gravatar_id":"","url":"https://api.github.com/users/tony--","html_url":"https://github.com/tony--","followers_url":"https://api.github.com/users/tony--/followers","following_url":"https://api.github.com/users/tony--/following{/other_user}","gists_url":"https://api.github.com/users/tony--/gists{/gist_id}","starred_url":"https://api.github.com/users/tony--/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tony--/subscriptions","organizations_url":"https://api.github.com/users/tony--/orgs","repos_url":"https://api.github.com/users/tony--/repos","events_url":"https://api.github.com/users/tony--/events{/privacy}","received_events_url":"https://api.github.com/users/tony--/received_events","type":"User","site_admin":false},"body":"I added a test that adds access tags as described in CB-9145.  This test fails when run against master.\r\nThis is because the current exact match detection assumes that the query returning a result is sufficient to identify an exact attribute match.  However, the query may also return results with additional attributes and these should be excluded.  \r\n\r\nOriginally I added a utility function that handles this case by performing a 2-way comparison.  However, we already know that foundChild.attr matches srcChild.attr because foundChild is a query result.  We only need to determine if foundChild has extra attributes, so simply comparing the number of attributes is sufficient.  \r\n\r\nAfter making this change, all tests are green - including the newly added test that fails against master.","created_at":"2015-06-09T17:44:03Z","updated_at":"2015-06-16T20:22:32Z","closed_at":"2015-06-16T20:22:32Z","merged_at":null,"merge_commit_sha":"21c4fdc861e13c9bcab9d23b78c13a20ad5a15c6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/cordova-lib/pulls/242/commits","review_comments_url":"https://api.github.com/repos/apache/cordova-lib/pulls/242/comments","review_comment_url":"https://api.github.com/repos/apache/cordova-lib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/cordova-lib/issues/242/comments","statuses_url":"https://api.github.com/repos/apache/cordova-lib/statuses/25982317b26c831dbea9d6b71dd57a90b933fc68","head":{"label":"tony--:CB-9145","ref":"CB-9145","sha":"25982317b26c831dbea9d6b71dd57a90b933fc68","user":{"login":"tony--","id":513830,"avatar_url":"https://avatars.githubusercontent.com/u/513830?v=3","gravatar_id":"","url":"https://api.github.com/users/tony--","html_url":"https://github.com/tony--","followers_url":"https://api.github.com/users/tony--/followers","following_url":"https://api.github.com/users/tony--/following{/other_user}","gists_url":"https://api.github.com/users/tony--/gists{/gist_id}","starred_url":"https://api.github.com/users/tony--/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tony--/subscriptions","organizations_url":"https://api.github.com/users/tony--/orgs","repos_url":"https://api.github.com/users/tony--/repos","events_url":"https://api.github.com/users/tony--/events{/privacy}","received_events_url":"https://api.github.com/users/tony--/received_events","type":"User","site_admin":false},"repo":{"id":37145549,"name":"cordova-lib","full_name":"tony--/cordova-lib","owner":{"login":"tony--","id":513830,"avatar_url":"https://avatars.githubusercontent.com/u/513830?v=3","gravatar_id":"","url":"https://api.github.com/users/tony--","html_url":"https://github.com/tony--","followers_url":"https://api.github.com/users/tony--/followers","following_url":"https://api.github.com/users/tony--/following{/other_user}","gists_url":"https://api.github.com/users/tony--/gists{/gist_id}","starred_url":"https://api.github.com/users/tony--/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tony--/subscriptions","organizations_url":"https://api.github.com/users/tony--/orgs","repos_url":"https://api.github.com/users/tony--/repos","events_url":"https://api.github.com/users/tony--/events{/privacy}","received_events_url":"https://api.github.com/users/tony--/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tony--/cordova-lib","description":"Mirror of Apache Cordova","fork":true,"url":"https://api.github.com/repos/tony--/cordova-lib","forks_url":"https://api.github.com/repos/tony--/cordova-lib/forks","keys_url":"https://api.github.com/repos/tony--/cordova-lib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tony--/cordova-lib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tony--/cordova-lib/teams","hooks_url":"https://api.github.com/repos/tony--/cordova-lib/hooks","issue_events_url":"https://api.github.com/repos/tony--/cordova-lib/issues/events{/number}","events_url":"https://api.github.com/repos/tony--/cordova-lib/events","assignees_url":"https://api.github.com/repos/tony--/cordova-lib/assignees{/user}","branches_url":"https://api.github.com/repos/tony--/cordova-lib/branches{/branch}","tags_url":"https://api.github.com/repos/tony--/cordova-lib/tags","blobs_url":"https://api.github.com/repos/tony--/cordova-lib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tony--/cordova-lib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tony--/cordova-lib/git/refs{/sha}","trees_url":"https://api.github.com/repos/tony--/cordova-lib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tony--/cordova-lib/statuses/{sha}","languages_url":"https://api.github.com/repos/tony--/cordova-lib/languages","stargazers_url":"https://api.github.com/repos/tony--/cordova-lib/stargazers","contributors_url":"https://api.github.com/repos/tony--/cordova-lib/contributors","subscribers_url":"https://api.github.com/repos/tony--/cordova-lib/subscribers","subscription_url":"https://api.github.com/repos/tony--/cordova-lib/subscription","commits_url":"https://api.github.com/repos/tony--/cordova-lib/commits{/sha}","git_commits_url":"https://api.github.com/repos/tony--/cordova-lib/git/commits{/sha}","comments_url":"https://api.github.com/repos/tony--/cordova-lib/comments{/number}","issue_comment_url":"https://api.github.com/repos/tony--/cordova-lib/issues/comments{/number}","contents_url":"https://api.github.com/repos/tony--/cordova-lib/contents/{+path}","compare_url":"https://api.github.com/repos/tony--/cordova-lib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tony--/cordova-lib/merges","archive_url":"https://api.github.com/repos/tony--/cordova-lib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tony--/cordova-lib/downloads","issues_url":"https://api.github.com/repos/tony--/cordova-lib/issues{/number}","pulls_url":"https://api.github.com/repos/tony--/cordova-lib/pulls{/number}","milestones_url":"https://api.github.com/repos/tony--/cordova-lib/milestones{/number}","notifications_url":"https://api.github.com/repos/tony--/cordova-lib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tony--/cordova-lib/labels{/name}","releases_url":"https://api.github.com/repos/tony--/cordova-lib/releases{/id}","created_at":"2015-06-09T16:56:20Z","updated_at":"2015-06-09T16:56:21Z","pushed_at":"2015-06-09T17:43:00Z","git_url":"git://github.com/tony--/cordova-lib.git","ssh_url":"git@github.com:tony--/cordova-lib.git","clone_url":"https://github.com/tony--/cordova-lib.git","svn_url":"https://github.com/tony--/cordova-lib","homepage":null,"size":43019,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"c3485e21412bbc73711cc6bd32a93a7ee2a1fe1f","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":19524397,"name":"cordova-lib","full_name":"apache/cordova-lib","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/cordova-lib","description":"Mirror of Apache Cordova","fork":false,"url":"https://api.github.com/repos/apache/cordova-lib","forks_url":"https://api.github.com/repos/apache/cordova-lib/forks","keys_url":"https://api.github.com/repos/apache/cordova-lib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/cordova-lib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/cordova-lib/teams","hooks_url":"https://api.github.com/repos/apache/cordova-lib/hooks","issue_events_url":"https://api.github.com/repos/apache/cordova-lib/issues/events{/number}","events_url":"https://api.github.com/repos/apache/cordova-lib/events","assignees_url":"https://api.github.com/repos/apache/cordova-lib/assignees{/user}","branches_url":"https://api.github.com/repos/apache/cordova-lib/branches{/branch}","tags_url":"https://api.github.com/repos/apache/cordova-lib/tags","blobs_url":"https://api.github.com/repos/apache/cordova-lib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/cordova-lib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/cordova-lib/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/cordova-lib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/cordova-lib/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/cordova-lib/languages","stargazers_url":"https://api.github.com/repos/apache/cordova-lib/stargazers","contributors_url":"https://api.github.com/repos/apache/cordova-lib/contributors","subscribers_url":"https://api.github.com/repos/apache/cordova-lib/subscribers","subscription_url":"https://api.github.com/repos/apache/cordova-lib/subscription","commits_url":"https://api.github.com/repos/apache/cordova-lib/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/cordova-lib/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/cordova-lib/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/cordova-lib/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/cordova-lib/contents/{+path}","compare_url":"https://api.github.com/repos/apache/cordova-lib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/cordova-lib/merges","archive_url":"https://api.github.com/repos/apache/cordova-lib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/cordova-lib/downloads","issues_url":"https://api.github.com/repos/apache/cordova-lib/issues{/number}","pulls_url":"https://api.github.com/repos/apache/cordova-lib/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/cordova-lib/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/cordova-lib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/cordova-lib/labels{/name}","releases_url":"https://api.github.com/repos/apache/cordova-lib/releases{/id}","created_at":"2014-05-07T07:00:06Z","updated_at":"2015-06-13T01:32:09Z","pushed_at":"2015-06-16T20:04:18Z","git_url":"git://github.com/apache/cordova-lib.git","ssh_url":"git@github.com:apache/cordova-lib.git","clone_url":"https://github.com/apache/cordova-lib.git","svn_url":"https://github.com/apache/cordova-lib","homepage":null,"size":47274,"stargazers_count":61,"watchers_count":61,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":131,"mirror_url":"git://git.apache.org/cordova-lib.git","open_issues_count":16,"forks":131,"open_issues":16,"watchers":61,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/cordova-lib/pulls/242"},"html":{"href":"https://github.com/apache/cordova-lib/pull/242"},"issue":{"href":"https://api.github.com/repos/apache/cordova-lib/issues/242"},"comments":{"href":"https://api.github.com/repos/apache/cordova-lib/issues/242/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/cordova-lib/pulls/242/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/cordova-lib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/cordova-lib/pulls/242/commits"},"statuses":{"href":"https://api.github.com/repos/apache/cordova-lib/statuses/25982317b26c831dbea9d6b71dd57a90b933fc68"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":4,"review_comments":0,"commits":1,"additions":30,"deletions":5,"changed_files":2}}