{"action":"created","issue":{"url":"https://api.github.com/repos/linux-can/can-utils/issues/1","labels_url":"https://api.github.com/repos/linux-can/can-utils/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/linux-can/can-utils/issues/1/comments","events_url":"https://api.github.com/repos/linux-can/can-utils/issues/1/events","html_url":"https://github.com/linux-can/can-utils/pull/1","id":66143691,"number":1,"title":"Added missing length check for strcpy(ifr.ifr_name, argv[x]).","user":{"login":"snewz","id":1443173,"avatar_url":"https://avatars.githubusercontent.com/u/1443173?v=3","gravatar_id":"","url":"https://api.github.com/users/snewz","html_url":"https://github.com/snewz","followers_url":"https://api.github.com/users/snewz/followers","following_url":"https://api.github.com/users/snewz/following{/other_user}","gists_url":"https://api.github.com/users/snewz/gists{/gist_id}","starred_url":"https://api.github.com/users/snewz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snewz/subscriptions","organizations_url":"https://api.github.com/users/snewz/orgs","repos_url":"https://api.github.com/users/snewz/repos","events_url":"https://api.github.com/users/snewz/events{/privacy}","received_events_url":"https://api.github.com/users/snewz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-04-03T13:09:20Z","updated_at":"2015-04-04T05:50:31Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/linux-can/can-utils/pulls/1","html_url":"https://github.com/linux-can/can-utils/pull/1","diff_url":"https://github.com/linux-can/can-utils/pull/1.diff","patch_url":"https://github.com/linux-can/can-utils/pull/1.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/linux-can/can-utils/issues/comments/89509329","html_url":"https://github.com/linux-can/can-utils/pull/1#issuecomment-89509329","issue_url":"https://api.github.com/repos/linux-can/can-utils/issues/1","id":89509329,"user":{"login":"hartkopp","id":9991276,"avatar_url":"https://avatars.githubusercontent.com/u/9991276?v=3","gravatar_id":"","url":"https://api.github.com/users/hartkopp","html_url":"https://github.com/hartkopp","followers_url":"https://api.github.com/users/hartkopp/followers","following_url":"https://api.github.com/users/hartkopp/following{/other_user}","gists_url":"https://api.github.com/users/hartkopp/gists{/gist_id}","starred_url":"https://api.github.com/users/hartkopp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hartkopp/subscriptions","organizations_url":"https://api.github.com/users/hartkopp/orgs","repos_url":"https://api.github.com/users/hartkopp/repos","events_url":"https://api.github.com/users/hartkopp/events{/privacy}","received_events_url":"https://api.github.com/users/hartkopp/received_events","type":"User","site_admin":false},"created_at":"2015-04-04T05:50:31Z","updated_at":"2015-04-04T05:50:31Z","body":"Hi Sven,\r\nthanks for your contribution! But instead of creating 'more' obviously duplicated code I would suggest to change the code to use if_nametoindex() instead of the open coded ioctl() stuff.\r\nYou can see examples of the if_nametoindex() usage in cangw.c and isotpperf.c .\r\nBtw. a proper check of a negative return check is missing there too and needs to be added before.\r\nAre you interested to provide a patch for this rework?\r\nBest regards,\r\nOliver\r\n"}}