{"action":"created","issue":{"url":"https://api.github.com/repos/matze/mtheme/issues/93","labels_url":"https://api.github.com/repos/matze/mtheme/issues/93/labels{/name}","comments_url":"https://api.github.com/repos/matze/mtheme/issues/93/comments","events_url":"https://api.github.com/repos/matze/mtheme/issues/93/events","html_url":"https://github.com/matze/mtheme/pull/93","id":89230850,"number":93,"title":"Split off and document inner and outer themes","user":{"login":"rchurchley","id":1131743,"avatar_url":"https://avatars.githubusercontent.com/u/1131743?v=3","gravatar_id":"","url":"https://api.github.com/users/rchurchley","html_url":"https://github.com/rchurchley","followers_url":"https://api.github.com/users/rchurchley/followers","following_url":"https://api.github.com/users/rchurchley/following{/other_user}","gists_url":"https://api.github.com/users/rchurchley/gists{/gist_id}","starred_url":"https://api.github.com/users/rchurchley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rchurchley/subscriptions","organizations_url":"https://api.github.com/users/rchurchley/orgs","repos_url":"https://api.github.com/users/rchurchley/repos","events_url":"https://api.github.com/users/rchurchley/events{/privacy}","received_events_url":"https://api.github.com/users/rchurchley/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":30,"created_at":"2015-06-18T08:21:39Z","updated_at":"2015-06-22T05:26:06Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/matze/mtheme/pulls/93","html_url":"https://github.com/matze/mtheme/pull/93","diff_url":"https://github.com/matze/mtheme/pull/93.diff","patch_url":"https://github.com/matze/mtheme/pull/93.patch"},"body":"This is the big reorganization discussed in #89 and in other issues. It's not quite ready to be merged yet; I still have to\r\n\r\n- tidy up the skeleton class `beamerthemem.dtx`,\r\n- add a bit more documentation to `mtheme.dtx`, and\r\n- reorganize the theme options so the inner and outer themes can be called independently of `beamerthemem.dtx`.\r\n\r\nI have tried to keep functional changes to a minimum. The most notable one I had to make was to `\\progressbar`, which has once again been broken up into two implementations, this time as custom beamer templates. The section page progress bar is defined in the inner theme as `progress bar in section page`, and the frametitle progress bar is defined in the outer theme as `progress bar in head/foot`. \r\n\r\nAlthough it is a bit annoying to have to split up the implementations because of the inner/outer theme distinction, we do get a side benefit from it. The colours of the two kinds of progress bar can now be changed independently:\r\n\r\n```latex\r\n\\setbeamercolor{progress bar in section page}{...}\r\n\\setbeamercolor{progress bar in head/foot}{...}\r\n```\r\n\r\nThe current functionality remains where `\\setbeamercolor{progress bar}{...}` will change both, although doing so will not override any changes made using the more specific declarations above.\r\n\r\nSince I'll be busy tomorrow and may not be able to finish this until the weekend, I thought I should make the pull request in the meantime so you all could start reviewing it. Apart from the known issues above, can you see anything I've missed or broken?"},"comment":{"url":"https://api.github.com/repos/matze/mtheme/issues/comments/114009505","html_url":"https://github.com/matze/mtheme/pull/93#issuecomment-114009505","issue_url":"https://api.github.com/repos/matze/mtheme/issues/93","id":114009505,"user":{"login":"rchurchley","id":1131743,"avatar_url":"https://avatars.githubusercontent.com/u/1131743?v=3","gravatar_id":"","url":"https://api.github.com/users/rchurchley","html_url":"https://github.com/rchurchley","followers_url":"https://api.github.com/users/rchurchley/followers","following_url":"https://api.github.com/users/rchurchley/following{/other_user}","gists_url":"https://api.github.com/users/rchurchley/gists{/gist_id}","starred_url":"https://api.github.com/users/rchurchley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rchurchley/subscriptions","organizations_url":"https://api.github.com/users/rchurchley/orgs","repos_url":"https://api.github.com/users/rchurchley/repos","events_url":"https://api.github.com/users/rchurchley/events{/privacy}","received_events_url":"https://api.github.com/users/rchurchley/received_events","type":"User","site_admin":false},"created_at":"2015-06-22T05:26:05Z","updated_at":"2015-06-22T05:26:05Z","body":"> What are we gonna do with your last two commits. AFAICT nearly all the changes you made are related to pgfotps, except of the documentation you added. So don't you think we should (soft) revert them and just merge this PR. As the file splitting is a major change I would like to see it integrated in the master branch asap.\r\n\r\nMany apologies! As this long diversion has shown, I was wrong to try to bring #90 into this.  Lesson learned — I'll try to keep to one major feature per PR. (I hope) I've got this one back to a mergeable state."}}