{"action":"created","issue":{"url":"https://api.github.com/repos/apache/spark/issues/5223","labels_url":"https://api.github.com/repos/apache/spark/issues/5223/labels{/name}","comments_url":"https://api.github.com/repos/apache/spark/issues/5223/comments","events_url":"https://api.github.com/repos/apache/spark/issues/5223/events","html_url":"https://github.com/apache/spark/pull/5223","id":64687928,"number":5223,"title":"[SPARK-6560][CORE] Do not suppress exceptions from writer.write.","user":{"login":"stephenh","id":6401,"avatar_url":"https://avatars.githubusercontent.com/u/6401?v=3","gravatar_id":"","url":"https://api.github.com/users/stephenh","html_url":"https://github.com/stephenh","followers_url":"https://api.github.com/users/stephenh/followers","following_url":"https://api.github.com/users/stephenh/following{/other_user}","gists_url":"https://api.github.com/users/stephenh/gists{/gist_id}","starred_url":"https://api.github.com/users/stephenh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephenh/subscriptions","organizations_url":"https://api.github.com/users/stephenh/orgs","repos_url":"https://api.github.com/users/stephenh/repos","events_url":"https://api.github.com/users/stephenh/events{/privacy}","received_events_url":"https://api.github.com/users/stephenh/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":32,"created_at":"2015-03-27T04:16:58Z","updated_at":"2015-04-02T18:39:28Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/5223","html_url":"https://github.com/apache/spark/pull/5223","diff_url":"https://github.com/apache/spark/pull/5223.diff","patch_url":"https://github.com/apache/spark/pull/5223.patch"},"body":"If there is a failure in the Hadoop backend while calling\r\nwriter.write, we should remember this original exception,\r\nand try to call writer.close(), but if that fails as well,\r\nstill report the original exception.\r\n\r\nNote that, if writer.write fails, it is likely that writer\r\nwas left in an invalid state, and so actually makes it more\r\nlikely that writer.close will also fail. Which just increases\r\nthe chances for writer.write's exception to be suppressed.\r\n\r\nThis patch introduces an admittedly potentially too cute\r\nUtils.tryWithSafeFinally method to handle the try/finally\r\ngyrations."},"comment":{"url":"https://api.github.com/repos/apache/spark/issues/comments/89004938","html_url":"https://github.com/apache/spark/pull/5223#issuecomment-89004938","issue_url":"https://api.github.com/repos/apache/spark/issues/5223","id":89004938,"user":{"login":"SparkQA","id":8108735,"avatar_url":"https://avatars.githubusercontent.com/u/8108735?v=3","gravatar_id":"","url":"https://api.github.com/users/SparkQA","html_url":"https://github.com/SparkQA","followers_url":"https://api.github.com/users/SparkQA/followers","following_url":"https://api.github.com/users/SparkQA/following{/other_user}","gists_url":"https://api.github.com/users/SparkQA/gists{/gist_id}","starred_url":"https://api.github.com/users/SparkQA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SparkQA/subscriptions","organizations_url":"https://api.github.com/users/SparkQA/orgs","repos_url":"https://api.github.com/users/SparkQA/repos","events_url":"https://api.github.com/users/SparkQA/events{/privacy}","received_events_url":"https://api.github.com/users/SparkQA/received_events","type":"User","site_admin":false},"created_at":"2015-04-02T18:39:28Z","updated_at":"2015-04-02T18:39:28Z","body":"  [Test build #29615 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29615/consoleFull) for   PR 5223 at commit [`c7ad53f`](https://github.com/apache/spark/commit/c7ad53f4a6a63c2e1353e36631de8ed69ba6ae58).\n * This patch **passes all tests**.\n * This patch merges cleanly.\n * This patch adds no public classes.\n * This patch does not change any dependencies."}}