{"action":"closed","number":85,"pull_request":{"url":"https://api.github.com/repos/alexdebril/rss-atom-bundle/pulls/85","id":38517350,"html_url":"https://github.com/alexdebril/rss-atom-bundle/pull/85","diff_url":"https://github.com/alexdebril/rss-atom-bundle/pull/85.diff","patch_url":"https://github.com/alexdebril/rss-atom-bundle/pull/85.patch","issue_url":"https://api.github.com/repos/alexdebril/rss-atom-bundle/issues/85","number":85,"state":"closed","locked":false,"title":"Fix: attributes are casted to strings","user":{"login":"romaricdrigon","id":919405,"avatar_url":"https://avatars.githubusercontent.com/u/919405?v=3","gravatar_id":"","url":"https://api.github.com/users/romaricdrigon","html_url":"https://github.com/romaricdrigon","followers_url":"https://api.github.com/users/romaricdrigon/followers","following_url":"https://api.github.com/users/romaricdrigon/following{/other_user}","gists_url":"https://api.github.com/users/romaricdrigon/gists{/gist_id}","starred_url":"https://api.github.com/users/romaricdrigon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romaricdrigon/subscriptions","organizations_url":"https://api.github.com/users/romaricdrigon/orgs","repos_url":"https://api.github.com/users/romaricdrigon/repos","events_url":"https://api.github.com/users/romaricdrigon/events{/privacy}","received_events_url":"https://api.github.com/users/romaricdrigon/received_events","type":"User","site_admin":false},"body":"Hi,\r\n\r\nUnder some cases, `getAttributeValue` and `searchAttributeValue` will return a `SimpleXMLElement` in place of a string.\r\nSuch an element casted to a string equals its values, so you want not see that one in tests (PHPUnit `assertEquals` does a loose check).\r\nIn there I just make sure we always return a string if we find a value.","created_at":"2015-06-25T06:59:55Z","updated_at":"2015-06-26T13:40:44Z","closed_at":"2015-06-26T13:40:44Z","merged_at":"2015-06-26T13:40:44Z","merge_commit_sha":"7258c38fd5e185de4f46546bd66b91e24cf8b311","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/alexdebril/rss-atom-bundle/pulls/85/commits","review_comments_url":"https://api.github.com/repos/alexdebril/rss-atom-bundle/pulls/85/comments","review_comment_url":"https://api.github.com/repos/alexdebril/rss-atom-bundle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alexdebril/rss-atom-bundle/issues/85/comments","statuses_url":"https://api.github.com/repos/alexdebril/rss-atom-bundle/statuses/3daadbbebe8a18fe9c11234ab543962efd3d774a","head":{"label":"romaricdrigon:fix-attr","ref":"fix-attr","sha":"3daadbbebe8a18fe9c11234ab543962efd3d774a","user":{"login":"romaricdrigon","id":919405,"avatar_url":"https://avatars.githubusercontent.com/u/919405?v=3","gravatar_id":"","url":"https://api.github.com/users/romaricdrigon","html_url":"https://github.com/romaricdrigon","followers_url":"https://api.github.com/users/romaricdrigon/followers","following_url":"https://api.github.com/users/romaricdrigon/following{/other_user}","gists_url":"https://api.github.com/users/romaricdrigon/gists{/gist_id}","starred_url":"https://api.github.com/users/romaricdrigon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romaricdrigon/subscriptions","organizations_url":"https://api.github.com/users/romaricdrigon/orgs","repos_url":"https://api.github.com/users/romaricdrigon/repos","events_url":"https://api.github.com/users/romaricdrigon/events{/privacy}","received_events_url":"https://api.github.com/users/romaricdrigon/received_events","type":"User","site_admin":false},"repo":{"id":37909485,"name":"rss-atom-bundle","full_name":"romaricdrigon/rss-atom-bundle","owner":{"login":"romaricdrigon","id":919405,"avatar_url":"https://avatars.githubusercontent.com/u/919405?v=3","gravatar_id":"","url":"https://api.github.com/users/romaricdrigon","html_url":"https://github.com/romaricdrigon","followers_url":"https://api.github.com/users/romaricdrigon/followers","following_url":"https://api.github.com/users/romaricdrigon/following{/other_user}","gists_url":"https://api.github.com/users/romaricdrigon/gists{/gist_id}","starred_url":"https://api.github.com/users/romaricdrigon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romaricdrigon/subscriptions","organizations_url":"https://api.github.com/users/romaricdrigon/orgs","repos_url":"https://api.github.com/users/romaricdrigon/repos","events_url":"https://api.github.com/users/romaricdrigon/events{/privacy}","received_events_url":"https://api.github.com/users/romaricdrigon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/romaricdrigon/rss-atom-bundle","description":"RSS and Atom Bundle for Symfony 2","fork":true,"url":"https://api.github.com/repos/romaricdrigon/rss-atom-bundle","forks_url":"https://api.github.com/repos/romaricdrigon/rss-atom-bundle/forks","keys_url":"https://api.github.com/repos/romaricdrigon/rss-atom-bundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/romaricdrigon/rss-atom-bundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/romaricdrigon/rss-atom-bundle/teams","hooks_url":"https://api.github.com/repos/romaricdrigon/rss-atom-bundle/hooks","issue_events_url":"https://api.github.com/repos/romaricdrigon/rss-atom-bundle/issues/events{/number}","events_url":"https://api.github.com/repos/romaricdrigon/rss-atom-bundle/events","assignees_url":"https://api.github.com/repos/romaricdrigon/rss-atom-bundle/assignees{/user}","branches_url":"https://api.github.com/repos/romaricdrigon/rss-atom-bundle/branches{/branch}","tags_url":"https://api.github.com/repos/romaricdrigon/rss-atom-bundle/tags","blobs_url":"https://api.github.com/repos/romaricdrigon/rss-atom-bundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/romaricdrigon/rss-atom-bundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/romaricdrigon/rss-atom-bundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/romaricdrigon/rss-atom-bundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/romaricdrigon/rss-atom-bundle/statuses/{sha}","languages_url":"https://api.github.com/repos/romaricdrigon/rss-atom-bundle/languages","stargazers_url":"https://api.github.com/repos/romaricdrigon/rss-atom-bundle/stargazers","contributors_url":"https://api.github.com/repos/romaricdrigon/rss-atom-bundle/contributors","subscribers_url":"https://api.github.com/repos/romaricdrigon/rss-atom-bundle/subscribers","subscription_url":"https://api.github.com/repos/romaricdrigon/rss-atom-bundle/subscription","commits_url":"https://api.github.com/repos/romaricdrigon/rss-atom-bundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/romaricdrigon/rss-atom-bundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/romaricdrigon/rss-atom-bundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/romaricdrigon/rss-atom-bundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/romaricdrigon/rss-atom-bundle/contents/{+path}","compare_url":"https://api.github.com/repos/romaricdrigon/rss-atom-bundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/romaricdrigon/rss-atom-bundle/merges","archive_url":"https://api.github.com/repos/romaricdrigon/rss-atom-bundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/romaricdrigon/rss-atom-bundle/downloads","issues_url":"https://api.github.com/repos/romaricdrigon/rss-atom-bundle/issues{/number}","pulls_url":"https://api.github.com/repos/romaricdrigon/rss-atom-bundle/pulls{/number}","milestones_url":"https://api.github.com/repos/romaricdrigon/rss-atom-bundle/milestones{/number}","notifications_url":"https://api.github.com/repos/romaricdrigon/rss-atom-bundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/romaricdrigon/rss-atom-bundle/labels{/name}","releases_url":"https://api.github.com/repos/romaricdrigon/rss-atom-bundle/releases{/id}","created_at":"2015-06-23T09:23:55Z","updated_at":"2015-06-23T09:23:56Z","pushed_at":"2015-06-25T06:57:59Z","git_url":"git://github.com/romaricdrigon/rss-atom-bundle.git","ssh_url":"git@github.com:romaricdrigon/rss-atom-bundle.git","clone_url":"https://github.com/romaricdrigon/rss-atom-bundle.git","svn_url":"https://github.com/romaricdrigon/rss-atom-bundle","homepage":null,"size":792,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"alexdebril:master","ref":"master","sha":"6b3bd69feaf5d22a175e92637f39a92738807154","user":{"login":"alexdebril","id":207048,"avatar_url":"https://avatars.githubusercontent.com/u/207048?v=3","gravatar_id":"","url":"https://api.github.com/users/alexdebril","html_url":"https://github.com/alexdebril","followers_url":"https://api.github.com/users/alexdebril/followers","following_url":"https://api.github.com/users/alexdebril/following{/other_user}","gists_url":"https://api.github.com/users/alexdebril/gists{/gist_id}","starred_url":"https://api.github.com/users/alexdebril/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexdebril/subscriptions","organizations_url":"https://api.github.com/users/alexdebril/orgs","repos_url":"https://api.github.com/users/alexdebril/repos","events_url":"https://api.github.com/users/alexdebril/events{/privacy}","received_events_url":"https://api.github.com/users/alexdebril/received_events","type":"User","site_admin":false},"repo":{"id":7921121,"name":"rss-atom-bundle","full_name":"alexdebril/rss-atom-bundle","owner":{"login":"alexdebril","id":207048,"avatar_url":"https://avatars.githubusercontent.com/u/207048?v=3","gravatar_id":"","url":"https://api.github.com/users/alexdebril","html_url":"https://github.com/alexdebril","followers_url":"https://api.github.com/users/alexdebril/followers","following_url":"https://api.github.com/users/alexdebril/following{/other_user}","gists_url":"https://api.github.com/users/alexdebril/gists{/gist_id}","starred_url":"https://api.github.com/users/alexdebril/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexdebril/subscriptions","organizations_url":"https://api.github.com/users/alexdebril/orgs","repos_url":"https://api.github.com/users/alexdebril/repos","events_url":"https://api.github.com/users/alexdebril/events{/privacy}","received_events_url":"https://api.github.com/users/alexdebril/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alexdebril/rss-atom-bundle","description":"RSS and Atom Bundle for Symfony 2","fork":false,"url":"https://api.github.com/repos/alexdebril/rss-atom-bundle","forks_url":"https://api.github.com/repos/alexdebril/rss-atom-bundle/forks","keys_url":"https://api.github.com/repos/alexdebril/rss-atom-bundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alexdebril/rss-atom-bundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alexdebril/rss-atom-bundle/teams","hooks_url":"https://api.github.com/repos/alexdebril/rss-atom-bundle/hooks","issue_events_url":"https://api.github.com/repos/alexdebril/rss-atom-bundle/issues/events{/number}","events_url":"https://api.github.com/repos/alexdebril/rss-atom-bundle/events","assignees_url":"https://api.github.com/repos/alexdebril/rss-atom-bundle/assignees{/user}","branches_url":"https://api.github.com/repos/alexdebril/rss-atom-bundle/branches{/branch}","tags_url":"https://api.github.com/repos/alexdebril/rss-atom-bundle/tags","blobs_url":"https://api.github.com/repos/alexdebril/rss-atom-bundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alexdebril/rss-atom-bundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alexdebril/rss-atom-bundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/alexdebril/rss-atom-bundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alexdebril/rss-atom-bundle/statuses/{sha}","languages_url":"https://api.github.com/repos/alexdebril/rss-atom-bundle/languages","stargazers_url":"https://api.github.com/repos/alexdebril/rss-atom-bundle/stargazers","contributors_url":"https://api.github.com/repos/alexdebril/rss-atom-bundle/contributors","subscribers_url":"https://api.github.com/repos/alexdebril/rss-atom-bundle/subscribers","subscription_url":"https://api.github.com/repos/alexdebril/rss-atom-bundle/subscription","commits_url":"https://api.github.com/repos/alexdebril/rss-atom-bundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/alexdebril/rss-atom-bundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/alexdebril/rss-atom-bundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/alexdebril/rss-atom-bundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/alexdebril/rss-atom-bundle/contents/{+path}","compare_url":"https://api.github.com/repos/alexdebril/rss-atom-bundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alexdebril/rss-atom-bundle/merges","archive_url":"https://api.github.com/repos/alexdebril/rss-atom-bundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alexdebril/rss-atom-bundle/downloads","issues_url":"https://api.github.com/repos/alexdebril/rss-atom-bundle/issues{/number}","pulls_url":"https://api.github.com/repos/alexdebril/rss-atom-bundle/pulls{/number}","milestones_url":"https://api.github.com/repos/alexdebril/rss-atom-bundle/milestones{/number}","notifications_url":"https://api.github.com/repos/alexdebril/rss-atom-bundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alexdebril/rss-atom-bundle/labels{/name}","releases_url":"https://api.github.com/repos/alexdebril/rss-atom-bundle/releases{/id}","created_at":"2013-01-30T18:42:39Z","updated_at":"2015-06-10T11:59:25Z","pushed_at":"2015-06-26T13:40:44Z","git_url":"git://github.com/alexdebril/rss-atom-bundle.git","ssh_url":"git@github.com:alexdebril/rss-atom-bundle.git","clone_url":"https://github.com/alexdebril/rss-atom-bundle.git","svn_url":"https://github.com/alexdebril/rss-atom-bundle","homepage":null,"size":2125,"stargazers_count":30,"watchers_count":30,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":20,"mirror_url":null,"open_issues_count":12,"forks":20,"open_issues":12,"watchers":30,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alexdebril/rss-atom-bundle/pulls/85"},"html":{"href":"https://github.com/alexdebril/rss-atom-bundle/pull/85"},"issue":{"href":"https://api.github.com/repos/alexdebril/rss-atom-bundle/issues/85"},"comments":{"href":"https://api.github.com/repos/alexdebril/rss-atom-bundle/issues/85/comments"},"review_comments":{"href":"https://api.github.com/repos/alexdebril/rss-atom-bundle/pulls/85/comments"},"review_comment":{"href":"https://api.github.com/repos/alexdebril/rss-atom-bundle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alexdebril/rss-atom-bundle/pulls/85/commits"},"statuses":{"href":"https://api.github.com/repos/alexdebril/rss-atom-bundle/statuses/3daadbbebe8a18fe9c11234ab543962efd3d774a"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"alexdebril","id":207048,"avatar_url":"https://avatars.githubusercontent.com/u/207048?v=3","gravatar_id":"","url":"https://api.github.com/users/alexdebril","html_url":"https://github.com/alexdebril","followers_url":"https://api.github.com/users/alexdebril/followers","following_url":"https://api.github.com/users/alexdebril/following{/other_user}","gists_url":"https://api.github.com/users/alexdebril/gists{/gist_id}","starred_url":"https://api.github.com/users/alexdebril/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexdebril/subscriptions","organizations_url":"https://api.github.com/users/alexdebril/orgs","repos_url":"https://api.github.com/users/alexdebril/repos","events_url":"https://api.github.com/users/alexdebril/events{/privacy}","received_events_url":"https://api.github.com/users/alexdebril/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":2,"deletions":2,"changed_files":1}}