{"action":"created","issue":{"url":"https://api.github.com/repos/atom/settings-view/issues/698","labels_url":"https://api.github.com/repos/atom/settings-view/issues/698/labels{/name}","comments_url":"https://api.github.com/repos/atom/settings-view/issues/698/comments","events_url":"https://api.github.com/repos/atom/settings-view/issues/698/events","html_url":"https://github.com/atom/settings-view/pull/698","id":116963887,"number":698,"title":"add optional sub-section heading if the settings group has an explicit title","user":{"login":"dirk-thomas","id":1335366,"avatar_url":"https://avatars.githubusercontent.com/u/1335366?v=3","gravatar_id":"","url":"https://api.github.com/users/dirk-thomas","html_url":"https://github.com/dirk-thomas","followers_url":"https://api.github.com/users/dirk-thomas/followers","following_url":"https://api.github.com/users/dirk-thomas/following{/other_user}","gists_url":"https://api.github.com/users/dirk-thomas/gists{/gist_id}","starred_url":"https://api.github.com/users/dirk-thomas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dirk-thomas/subscriptions","organizations_url":"https://api.github.com/users/dirk-thomas/orgs","repos_url":"https://api.github.com/users/dirk-thomas/repos","events_url":"https://api.github.com/users/dirk-thomas/events{/privacy}","received_events_url":"https://api.github.com/users/dirk-thomas/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/atom/settings-view/labels/needs-review","name":"needs-review","color":"bfe5bf"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":12,"created_at":"2015-11-15T00:45:05Z","updated_at":"2015-11-30T14:08:53Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/atom/settings-view/pulls/698","html_url":"https://github.com/atom/settings-view/pull/698","diff_url":"https://github.com/atom/settings-view/pull/698.diff","patch_url":"https://github.com/atom/settings-view/pull/698.patch"},"body":"While package settings can have grouped options (see the below example) they are not visually separated. This patch adds a `sub-section-headline` if the group has an explicit `title` set. The visual grouping together with a reasonable title provides a better overview over the settings of a package if the number of options increases.\r\n\r\nI didn't use `getSettingTitle` since that would introduce the new headlines where none have been before and I wanted to keep the changes to existing settings minimal.\r\n\r\n    config:\r\n      groupA:\r\n        type: 'object'\r\n        title: 'Options related to A'\r\n        properties:\r\n          optionA:\r\n            type: 'string'\r\n            default: 'default A'\r\n          optionB:\r\n            type: 'boolean'\r\n            default: false\r\n      groupB:\r\n        type: 'object'\r\n        title: 'Options related to B'\r\n        properties:\r\n          optionC:\r\n            type: 'string'\r\n            default: ''\r\n          optionD:\r\n            type: 'boolean'\r\n            default: false\r\n\r\nSince I haven't contributed to atom packages much yet I am not sure if the added html structure makes sense here or should not be changed in that way?"},"comment":{"url":"https://api.github.com/repos/atom/settings-view/issues/comments/160640575","html_url":"https://github.com/atom/settings-view/pull/698#issuecomment-160640575","issue_url":"https://api.github.com/repos/atom/settings-view/issues/698","id":160640575,"user":{"login":"thedaniel","id":1476,"avatar_url":"https://avatars.githubusercontent.com/u/1476?v=3","gravatar_id":"","url":"https://api.github.com/users/thedaniel","html_url":"https://github.com/thedaniel","followers_url":"https://api.github.com/users/thedaniel/followers","following_url":"https://api.github.com/users/thedaniel/following{/other_user}","gists_url":"https://api.github.com/users/thedaniel/gists{/gist_id}","starred_url":"https://api.github.com/users/thedaniel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thedaniel/subscriptions","organizations_url":"https://api.github.com/users/thedaniel/orgs","repos_url":"https://api.github.com/users/thedaniel/repos","events_url":"https://api.github.com/users/thedaniel/events{/privacy}","received_events_url":"https://api.github.com/users/thedaniel/received_events","type":"User","site_admin":true},"created_at":"2015-11-30T14:08:53Z","updated_at":"2015-11-30T14:08:53Z","body":"The spacing between a section title and the settings is pretty cramped. Can we space it out a bit? cc @simurai for further UI feedback.\r\n\r\n<img width=\"564\" alt=\"screen shot 2015-11-30 at 3 07 33 pm\" src=\"https://cloud.githubusercontent.com/assets/1476/11473705/4188d176-9774-11e5-8501-409c403a2bbe.png\">\r\n\r\n\r\n"}}