{"action":"created","comment":{"url":"https://api.github.com/repos/zendesk/rinku/pulls/comments/40286748","id":40286748,"diff_hunk":"@@ -136,19 +139,19 @@ static size_t\n autolink_delim_iter(uint8_t *data, size_t link_end, size_t offset, size_t size)\n {\n \tsize_t next_link_end;\n-        int iterations = 0;\n+\tint iterations = 0;\n \tlink_end = autolink_delim(data, link_end, offset, size);\n \n-        while(link_end != 0) {\n-          next_link_end = autolink_delim(data, link_end, offset, size);\n-          if (next_link_end == link_end || iterations > 5) {\n-            break;\n-          }\n-          link_end = next_link_end;\n-          iterations++;\n-        }\n+\twhile(link_end != 0) {\n+\t\tnext_link_end = autolink_delim(data, link_end, offset, size);","path":"ext/rinku/autolink.c","position":27,"original_position":27,"commit_id":"8703414d2872f3efb0f734d8b31fe939bf105d1c","original_commit_id":"8703414d2872f3efb0f734d8b31fe939bf105d1c","user":{"login":"jcheatham","id":1170999,"avatar_url":"https://avatars.githubusercontent.com/u/1170999?v=3","gravatar_id":"","url":"https://api.github.com/users/jcheatham","html_url":"https://github.com/jcheatham","followers_url":"https://api.github.com/users/jcheatham/followers","following_url":"https://api.github.com/users/jcheatham/following{/other_user}","gists_url":"https://api.github.com/users/jcheatham/gists{/gist_id}","starred_url":"https://api.github.com/users/jcheatham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcheatham/subscriptions","organizations_url":"https://api.github.com/users/jcheatham/orgs","repos_url":"https://api.github.com/users/jcheatham/repos","events_url":"https://api.github.com/users/jcheatham/events{/privacy}","received_events_url":"https://api.github.com/users/jcheatham/received_events","type":"User","site_admin":false},"body":"that's just the way things go sometimes.  Also, the file is riddled with tabs, while I'm betting @shajith had his editor set to use spaces... this brings it back into sync with the original style.  You can thank @barker1977 ","created_at":"2015-09-24T05:25:36Z","updated_at":"2015-09-24T05:25:36Z","html_url":"https://github.com/zendesk/rinku/pull/4#discussion_r40286748","pull_request_url":"https://api.github.com/repos/zendesk/rinku/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/zendesk/rinku/pulls/comments/40286748"},"html":{"href":"https://github.com/zendesk/rinku/pull/4#discussion_r40286748"},"pull_request":{"href":"https://api.github.com/repos/zendesk/rinku/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/zendesk/rinku/pulls/4","id":45860122,"html_url":"https://github.com/zendesk/rinku/pull/4","diff_url":"https://github.com/zendesk/rinku/pull/4.diff","patch_url":"https://github.com/zendesk/rinku/pull/4.patch","issue_url":"https://api.github.com/repos/zendesk/rinku/issues/4","number":4,"state":"open","locked":false,"title":"Clean up https://github.com/zendesk/rinku/pull/3","user":{"login":"jcheatham","id":1170999,"avatar_url":"https://avatars.githubusercontent.com/u/1170999?v=3","gravatar_id":"","url":"https://api.github.com/users/jcheatham","html_url":"https://github.com/jcheatham","followers_url":"https://api.github.com/users/jcheatham/followers","following_url":"https://api.github.com/users/jcheatham/following{/other_user}","gists_url":"https://api.github.com/users/jcheatham/gists{/gist_id}","starred_url":"https://api.github.com/users/jcheatham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcheatham/subscriptions","organizations_url":"https://api.github.com/users/jcheatham/orgs","repos_url":"https://api.github.com/users/jcheatham/repos","events_url":"https://api.github.com/users/jcheatham/events{/privacy}","received_events_url":"https://api.github.com/users/jcheatham/received_events","type":"User","site_admin":false},"body":"Paired with @barker1977 to fix the test and get this prepped to look into fixing a punycode autolinking vulnerability.  Clean up includes:\r\n\r\n * jumping back a character after encountering a terminal character in check_domain so that the test pass / code works\r\n * redefining the unicode space function declaration to eliminate:\r\n    `warning: implicit declaration of function 'isUnicodeSpace' is invalid in C99 [-Wimplicit-function-declaration]`\r\n * Renaming isUnicodeSpace to is_unicode_space to better fit in with existing code.\r\n\r\nConsidered reducing the strncmp check down to a collection of byte comparisons, since there's a bunch of redundancy in the unicode, but will leave that alone for now.\r\n\r\n/cc @zendesk/sustaining \r\n\r\n### Risks\r\nNone","created_at":"2015-09-24T05:17:23Z","updated_at":"2015-09-24T05:25:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c45a9ba29c5e925319ca831f4cb77341cdff0a9a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/zendesk/rinku/pulls/4/commits","review_comments_url":"https://api.github.com/repos/zendesk/rinku/pulls/4/comments","review_comment_url":"https://api.github.com/repos/zendesk/rinku/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zendesk/rinku/issues/4/comments","statuses_url":"https://api.github.com/repos/zendesk/rinku/statuses/8703414d2872f3efb0f734d8b31fe939bf105d1c","head":{"label":"zendesk:jcheatham/cleanup","ref":"jcheatham/cleanup","sha":"8703414d2872f3efb0f734d8b31fe939bf105d1c","user":{"login":"zendesk","id":11525,"avatar_url":"https://avatars.githubusercontent.com/u/11525?v=3","gravatar_id":"","url":"https://api.github.com/users/zendesk","html_url":"https://github.com/zendesk","followers_url":"https://api.github.com/users/zendesk/followers","following_url":"https://api.github.com/users/zendesk/following{/other_user}","gists_url":"https://api.github.com/users/zendesk/gists{/gist_id}","starred_url":"https://api.github.com/users/zendesk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zendesk/subscriptions","organizations_url":"https://api.github.com/users/zendesk/orgs","repos_url":"https://api.github.com/users/zendesk/repos","events_url":"https://api.github.com/users/zendesk/events{/privacy}","received_events_url":"https://api.github.com/users/zendesk/received_events","type":"Organization","site_admin":false},"repo":{"id":27446922,"name":"rinku","full_name":"zendesk/rinku","owner":{"login":"zendesk","id":11525,"avatar_url":"https://avatars.githubusercontent.com/u/11525?v=3","gravatar_id":"","url":"https://api.github.com/users/zendesk","html_url":"https://github.com/zendesk","followers_url":"https://api.github.com/users/zendesk/followers","following_url":"https://api.github.com/users/zendesk/following{/other_user}","gists_url":"https://api.github.com/users/zendesk/gists{/gist_id}","starred_url":"https://api.github.com/users/zendesk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zendesk/subscriptions","organizations_url":"https://api.github.com/users/zendesk/orgs","repos_url":"https://api.github.com/users/zendesk/repos","events_url":"https://api.github.com/users/zendesk/events{/privacy}","received_events_url":"https://api.github.com/users/zendesk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zendesk/rinku","description":"Autolinking. Ruby. Yes, that's pretty much it.","fork":true,"url":"https://api.github.com/repos/zendesk/rinku","forks_url":"https://api.github.com/repos/zendesk/rinku/forks","keys_url":"https://api.github.com/repos/zendesk/rinku/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zendesk/rinku/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zendesk/rinku/teams","hooks_url":"https://api.github.com/repos/zendesk/rinku/hooks","issue_events_url":"https://api.github.com/repos/zendesk/rinku/issues/events{/number}","events_url":"https://api.github.com/repos/zendesk/rinku/events","assignees_url":"https://api.github.com/repos/zendesk/rinku/assignees{/user}","branches_url":"https://api.github.com/repos/zendesk/rinku/branches{/branch}","tags_url":"https://api.github.com/repos/zendesk/rinku/tags","blobs_url":"https://api.github.com/repos/zendesk/rinku/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zendesk/rinku/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zendesk/rinku/git/refs{/sha}","trees_url":"https://api.github.com/repos/zendesk/rinku/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zendesk/rinku/statuses/{sha}","languages_url":"https://api.github.com/repos/zendesk/rinku/languages","stargazers_url":"https://api.github.com/repos/zendesk/rinku/stargazers","contributors_url":"https://api.github.com/repos/zendesk/rinku/contributors","subscribers_url":"https://api.github.com/repos/zendesk/rinku/subscribers","subscription_url":"https://api.github.com/repos/zendesk/rinku/subscription","commits_url":"https://api.github.com/repos/zendesk/rinku/commits{/sha}","git_commits_url":"https://api.github.com/repos/zendesk/rinku/git/commits{/sha}","comments_url":"https://api.github.com/repos/zendesk/rinku/comments{/number}","issue_comment_url":"https://api.github.com/repos/zendesk/rinku/issues/comments{/number}","contents_url":"https://api.github.com/repos/zendesk/rinku/contents/{+path}","compare_url":"https://api.github.com/repos/zendesk/rinku/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zendesk/rinku/merges","archive_url":"https://api.github.com/repos/zendesk/rinku/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zendesk/rinku/downloads","issues_url":"https://api.github.com/repos/zendesk/rinku/issues{/number}","pulls_url":"https://api.github.com/repos/zendesk/rinku/pulls{/number}","milestones_url":"https://api.github.com/repos/zendesk/rinku/milestones{/number}","notifications_url":"https://api.github.com/repos/zendesk/rinku/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zendesk/rinku/labels{/name}","releases_url":"https://api.github.com/repos/zendesk/rinku/releases{/id}","created_at":"2014-12-02T18:28:48Z","updated_at":"2014-12-02T19:53:52Z","pushed_at":"2015-09-24T05:23:34Z","git_url":"git://github.com/zendesk/rinku.git","ssh_url":"git@github.com:zendesk/rinku.git","clone_url":"https://github.com/zendesk/rinku.git","svn_url":"https://github.com/zendesk/rinku","homepage":"","size":286,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"zendesk:master","ref":"master","sha":"afb2ef2e15fb384aefee200f68ed318a135a3954","user":{"login":"zendesk","id":11525,"avatar_url":"https://avatars.githubusercontent.com/u/11525?v=3","gravatar_id":"","url":"https://api.github.com/users/zendesk","html_url":"https://github.com/zendesk","followers_url":"https://api.github.com/users/zendesk/followers","following_url":"https://api.github.com/users/zendesk/following{/other_user}","gists_url":"https://api.github.com/users/zendesk/gists{/gist_id}","starred_url":"https://api.github.com/users/zendesk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zendesk/subscriptions","organizations_url":"https://api.github.com/users/zendesk/orgs","repos_url":"https://api.github.com/users/zendesk/repos","events_url":"https://api.github.com/users/zendesk/events{/privacy}","received_events_url":"https://api.github.com/users/zendesk/received_events","type":"Organization","site_admin":false},"repo":{"id":27446922,"name":"rinku","full_name":"zendesk/rinku","owner":{"login":"zendesk","id":11525,"avatar_url":"https://avatars.githubusercontent.com/u/11525?v=3","gravatar_id":"","url":"https://api.github.com/users/zendesk","html_url":"https://github.com/zendesk","followers_url":"https://api.github.com/users/zendesk/followers","following_url":"https://api.github.com/users/zendesk/following{/other_user}","gists_url":"https://api.github.com/users/zendesk/gists{/gist_id}","starred_url":"https://api.github.com/users/zendesk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zendesk/subscriptions","organizations_url":"https://api.github.com/users/zendesk/orgs","repos_url":"https://api.github.com/users/zendesk/repos","events_url":"https://api.github.com/users/zendesk/events{/privacy}","received_events_url":"https://api.github.com/users/zendesk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zendesk/rinku","description":"Autolinking. Ruby. Yes, that's pretty much it.","fork":true,"url":"https://api.github.com/repos/zendesk/rinku","forks_url":"https://api.github.com/repos/zendesk/rinku/forks","keys_url":"https://api.github.com/repos/zendesk/rinku/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zendesk/rinku/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zendesk/rinku/teams","hooks_url":"https://api.github.com/repos/zendesk/rinku/hooks","issue_events_url":"https://api.github.com/repos/zendesk/rinku/issues/events{/number}","events_url":"https://api.github.com/repos/zendesk/rinku/events","assignees_url":"https://api.github.com/repos/zendesk/rinku/assignees{/user}","branches_url":"https://api.github.com/repos/zendesk/rinku/branches{/branch}","tags_url":"https://api.github.com/repos/zendesk/rinku/tags","blobs_url":"https://api.github.com/repos/zendesk/rinku/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zendesk/rinku/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zendesk/rinku/git/refs{/sha}","trees_url":"https://api.github.com/repos/zendesk/rinku/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zendesk/rinku/statuses/{sha}","languages_url":"https://api.github.com/repos/zendesk/rinku/languages","stargazers_url":"https://api.github.com/repos/zendesk/rinku/stargazers","contributors_url":"https://api.github.com/repos/zendesk/rinku/contributors","subscribers_url":"https://api.github.com/repos/zendesk/rinku/subscribers","subscription_url":"https://api.github.com/repos/zendesk/rinku/subscription","commits_url":"https://api.github.com/repos/zendesk/rinku/commits{/sha}","git_commits_url":"https://api.github.com/repos/zendesk/rinku/git/commits{/sha}","comments_url":"https://api.github.com/repos/zendesk/rinku/comments{/number}","issue_comment_url":"https://api.github.com/repos/zendesk/rinku/issues/comments{/number}","contents_url":"https://api.github.com/repos/zendesk/rinku/contents/{+path}","compare_url":"https://api.github.com/repos/zendesk/rinku/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zendesk/rinku/merges","archive_url":"https://api.github.com/repos/zendesk/rinku/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zendesk/rinku/downloads","issues_url":"https://api.github.com/repos/zendesk/rinku/issues{/number}","pulls_url":"https://api.github.com/repos/zendesk/rinku/pulls{/number}","milestones_url":"https://api.github.com/repos/zendesk/rinku/milestones{/number}","notifications_url":"https://api.github.com/repos/zendesk/rinku/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zendesk/rinku/labels{/name}","releases_url":"https://api.github.com/repos/zendesk/rinku/releases{/id}","created_at":"2014-12-02T18:28:48Z","updated_at":"2014-12-02T19:53:52Z","pushed_at":"2015-09-24T05:23:34Z","git_url":"git://github.com/zendesk/rinku.git","ssh_url":"git@github.com:zendesk/rinku.git","clone_url":"https://github.com/zendesk/rinku.git","svn_url":"https://github.com/zendesk/rinku","homepage":"","size":286,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zendesk/rinku/pulls/4"},"html":{"href":"https://github.com/zendesk/rinku/pull/4"},"issue":{"href":"https://api.github.com/repos/zendesk/rinku/issues/4"},"comments":{"href":"https://api.github.com/repos/zendesk/rinku/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/zendesk/rinku/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/zendesk/rinku/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zendesk/rinku/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/zendesk/rinku/statuses/8703414d2872f3efb0f734d8b31fe939bf105d1c"}}}}