{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-apex-core/pulls/comments/47788702","id":47788702,"diff_hunk":"@@ -0,0 +1,59 @@\n+/**\n+ * Licensed to the Apache Software Foundation (ASF) under one\n+ * or more contributor license agreements.  See the NOTICE file\n+ * distributed with this work for additional information\n+ * regarding copyright ownership.  The ASF licenses this file\n+ * to you under the Apache License, Version 2.0 (the\n+ * \"License\"); you may not use this file except in compliance\n+ * with the License.  You may obtain a copy of the License at\n+ *\n+ *   http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing,\n+ * software distributed under the License is distributed on an\n+ * \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY\n+ * KIND, either express or implied.  See the License for the\n+ * specific language governing permissions and limitations\n+ * under the License.\n+ */\n+package com.datatorrent.common.util;\n+\n+import com.datatorrent.api.DefaultInputPort;\n+import com.datatorrent.api.DefaultOutputPort;\n+import com.datatorrent.api.Operator;\n+\n+/**\n+ * SimpleDelayOperator. This is an implementation of the DelayOperator that has one input port and one output\n+ * port, and does a simple pass-through from the input port to the output port.  Subclass of this operator can\n+ * override this behavior by overriding processTuple(T tuple).\n+ *\n+ * Since the firstWindow method does not do anything, using this operator as-is means data loss during recovery.  In\n+ * order to achieve zero data loss during recovery, implementations must persist relevant tuples before the recovery\n+ * checkpoint for emitting during the first window after recovery.\n+ *\n+ * Note that the engine will automatically does a +1 on the output window ID since it is a DelayOperator.","path":"common/src/main/java/com/datatorrent/common/util/SimpleDelayOperator.java","position":34,"original_position":34,"commit_id":"45016f940f508fb18d9d6ed9807c01719a98d876","original_commit_id":"45016f940f508fb18d9d6ed9807c01719a98d876","user":{"login":"amberarrow","id":2498185,"avatar_url":"https://avatars.githubusercontent.com/u/2498185?v=3","gravatar_id":"","url":"https://api.github.com/users/amberarrow","html_url":"https://github.com/amberarrow","followers_url":"https://api.github.com/users/amberarrow/followers","following_url":"https://api.github.com/users/amberarrow/following{/other_user}","gists_url":"https://api.github.com/users/amberarrow/gists{/gist_id}","starred_url":"https://api.github.com/users/amberarrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amberarrow/subscriptions","organizations_url":"https://api.github.com/users/amberarrow/orgs","repos_url":"https://api.github.com/users/amberarrow/repos","events_url":"https://api.github.com/users/amberarrow/events{/privacy}","received_events_url":"https://api.github.com/users/amberarrow/received_events","type":"User","site_admin":false},"body":"Yes agree; I actually prefer \"engine automatically increments the output window ID\" but if we want a compact version I like your first alternative: \"engine automatically does\"","created_at":"2015-12-16T15:24:36Z","updated_at":"2015-12-16T15:24:36Z","html_url":"https://github.com/apache/incubator-apex-core/pull/185#discussion_r47788702","pull_request_url":"https://api.github.com/repos/apache/incubator-apex-core/pulls/185","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-apex-core/pulls/comments/47788702"},"html":{"href":"https://github.com/apache/incubator-apex-core/pull/185#discussion_r47788702"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-apex-core/pulls/185"}}},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-apex-core/pulls/185","id":53196832,"html_url":"https://github.com/apache/incubator-apex-core/pull/185","diff_url":"https://github.com/apache/incubator-apex-core/pull/185.diff","patch_url":"https://github.com/apache/incubator-apex-core/pull/185.patch","issue_url":"https://api.github.com/repos/apache/incubator-apex-core/issues/185","number":185,"state":"open","locked":false,"title":"APEXCORE-60 Iteration support in Apex Core","user":{"login":"davidyan74","id":4419148,"avatar_url":"https://avatars.githubusercontent.com/u/4419148?v=3","gravatar_id":"","url":"https://api.github.com/users/davidyan74","html_url":"https://github.com/davidyan74","followers_url":"https://api.github.com/users/davidyan74/followers","following_url":"https://api.github.com/users/davidyan74/following{/other_user}","gists_url":"https://api.github.com/users/davidyan74/gists{/gist_id}","starred_url":"https://api.github.com/users/davidyan74/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidyan74/subscriptions","organizations_url":"https://api.github.com/users/davidyan74/orgs","repos_url":"https://api.github.com/users/davidyan74/repos","events_url":"https://api.github.com/users/davidyan74/events{/privacy}","received_events_url":"https://api.github.com/users/davidyan74/received_events","type":"User","site_admin":false},"body":"Please review","created_at":"2015-12-09T23:54:18Z","updated_at":"2015-12-16T15:24:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"95db3acfe35f00633b71f683f34cc8042089c2a2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-apex-core/pulls/185/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-apex-core/pulls/185/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-apex-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-apex-core/issues/185/comments","statuses_url":"https://api.github.com/repos/apache/incubator-apex-core/statuses/45016f940f508fb18d9d6ed9807c01719a98d876","head":{"label":"davidyan74:APEXCORE-60","ref":"APEXCORE-60","sha":"45016f940f508fb18d9d6ed9807c01719a98d876","user":{"login":"davidyan74","id":4419148,"avatar_url":"https://avatars.githubusercontent.com/u/4419148?v=3","gravatar_id":"","url":"https://api.github.com/users/davidyan74","html_url":"https://github.com/davidyan74","followers_url":"https://api.github.com/users/davidyan74/followers","following_url":"https://api.github.com/users/davidyan74/following{/other_user}","gists_url":"https://api.github.com/users/davidyan74/gists{/gist_id}","starred_url":"https://api.github.com/users/davidyan74/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidyan74/subscriptions","organizations_url":"https://api.github.com/users/davidyan74/orgs","repos_url":"https://api.github.com/users/davidyan74/repos","events_url":"https://api.github.com/users/davidyan74/events{/privacy}","received_events_url":"https://api.github.com/users/davidyan74/received_events","type":"User","site_admin":false},"repo":{"id":41393462,"name":"incubator-apex-core","full_name":"davidyan74/incubator-apex-core","owner":{"login":"davidyan74","id":4419148,"avatar_url":"https://avatars.githubusercontent.com/u/4419148?v=3","gravatar_id":"","url":"https://api.github.com/users/davidyan74","html_url":"https://github.com/davidyan74","followers_url":"https://api.github.com/users/davidyan74/followers","following_url":"https://api.github.com/users/davidyan74/following{/other_user}","gists_url":"https://api.github.com/users/davidyan74/gists{/gist_id}","starred_url":"https://api.github.com/users/davidyan74/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidyan74/subscriptions","organizations_url":"https://api.github.com/users/davidyan74/orgs","repos_url":"https://api.github.com/users/davidyan74/repos","events_url":"https://api.github.com/users/davidyan74/events{/privacy}","received_events_url":"https://api.github.com/users/davidyan74/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/davidyan74/incubator-apex-core","description":"Mirror of Apache Apex core (Incubating)","fork":true,"url":"https://api.github.com/repos/davidyan74/incubator-apex-core","forks_url":"https://api.github.com/repos/davidyan74/incubator-apex-core/forks","keys_url":"https://api.github.com/repos/davidyan74/incubator-apex-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/davidyan74/incubator-apex-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/davidyan74/incubator-apex-core/teams","hooks_url":"https://api.github.com/repos/davidyan74/incubator-apex-core/hooks","issue_events_url":"https://api.github.com/repos/davidyan74/incubator-apex-core/issues/events{/number}","events_url":"https://api.github.com/repos/davidyan74/incubator-apex-core/events","assignees_url":"https://api.github.com/repos/davidyan74/incubator-apex-core/assignees{/user}","branches_url":"https://api.github.com/repos/davidyan74/incubator-apex-core/branches{/branch}","tags_url":"https://api.github.com/repos/davidyan74/incubator-apex-core/tags","blobs_url":"https://api.github.com/repos/davidyan74/incubator-apex-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/davidyan74/incubator-apex-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/davidyan74/incubator-apex-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/davidyan74/incubator-apex-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/davidyan74/incubator-apex-core/statuses/{sha}","languages_url":"https://api.github.com/repos/davidyan74/incubator-apex-core/languages","stargazers_url":"https://api.github.com/repos/davidyan74/incubator-apex-core/stargazers","contributors_url":"https://api.github.com/repos/davidyan74/incubator-apex-core/contributors","subscribers_url":"https://api.github.com/repos/davidyan74/incubator-apex-core/subscribers","subscription_url":"https://api.github.com/repos/davidyan74/incubator-apex-core/subscription","commits_url":"https://api.github.com/repos/davidyan74/incubator-apex-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/davidyan74/incubator-apex-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/davidyan74/incubator-apex-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/davidyan74/incubator-apex-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/davidyan74/incubator-apex-core/contents/{+path}","compare_url":"https://api.github.com/repos/davidyan74/incubator-apex-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/davidyan74/incubator-apex-core/merges","archive_url":"https://api.github.com/repos/davidyan74/incubator-apex-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/davidyan74/incubator-apex-core/downloads","issues_url":"https://api.github.com/repos/davidyan74/incubator-apex-core/issues{/number}","pulls_url":"https://api.github.com/repos/davidyan74/incubator-apex-core/pulls{/number}","milestones_url":"https://api.github.com/repos/davidyan74/incubator-apex-core/milestones{/number}","notifications_url":"https://api.github.com/repos/davidyan74/incubator-apex-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/davidyan74/incubator-apex-core/labels{/name}","releases_url":"https://api.github.com/repos/davidyan74/incubator-apex-core/releases{/id}","created_at":"2015-08-25T23:39:13Z","updated_at":"2015-08-25T23:39:18Z","pushed_at":"2015-12-16T02:20:03Z","git_url":"git://github.com/davidyan74/incubator-apex-core.git","ssh_url":"git@github.com:davidyan74/incubator-apex-core.git","clone_url":"https://github.com/davidyan74/incubator-apex-core.git","svn_url":"https://github.com/davidyan74/incubator-apex-core","homepage":null,"size":11102,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:devel-3","ref":"devel-3","sha":"0d5bfa5be27128de0be89335346c7c3cac40e31a","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":41348333,"name":"incubator-apex-core","full_name":"apache/incubator-apex-core","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-apex-core","description":"Mirror of Apache Apex core (Incubating)","fork":false,"url":"https://api.github.com/repos/apache/incubator-apex-core","forks_url":"https://api.github.com/repos/apache/incubator-apex-core/forks","keys_url":"https://api.github.com/repos/apache/incubator-apex-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-apex-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-apex-core/teams","hooks_url":"https://api.github.com/repos/apache/incubator-apex-core/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-apex-core/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-apex-core/events","assignees_url":"https://api.github.com/repos/apache/incubator-apex-core/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-apex-core/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-apex-core/tags","blobs_url":"https://api.github.com/repos/apache/incubator-apex-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-apex-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-apex-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-apex-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-apex-core/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-apex-core/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-apex-core/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-apex-core/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-apex-core/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-apex-core/subscription","commits_url":"https://api.github.com/repos/apache/incubator-apex-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-apex-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-apex-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-apex-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-apex-core/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-apex-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-apex-core/merges","archive_url":"https://api.github.com/repos/apache/incubator-apex-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-apex-core/downloads","issues_url":"https://api.github.com/repos/apache/incubator-apex-core/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-apex-core/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-apex-core/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-apex-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-apex-core/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-apex-core/releases{/id}","created_at":"2015-08-25T07:00:05Z","updated_at":"2015-12-15T21:13:43Z","pushed_at":"2015-12-16T02:20:04Z","git_url":"git://github.com/apache/incubator-apex-core.git","ssh_url":"git@github.com:apache/incubator-apex-core.git","clone_url":"https://github.com/apache/incubator-apex-core.git","svn_url":"https://github.com/apache/incubator-apex-core","homepage":null,"size":11352,"stargazers_count":44,"watchers_count":44,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":49,"mirror_url":"git://git.apache.org/incubator-apex-core.git","open_issues_count":15,"forks":49,"open_issues":15,"watchers":44,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-apex-core/pulls/185"},"html":{"href":"https://github.com/apache/incubator-apex-core/pull/185"},"issue":{"href":"https://api.github.com/repos/apache/incubator-apex-core/issues/185"},"comments":{"href":"https://api.github.com/repos/apache/incubator-apex-core/issues/185/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-apex-core/pulls/185/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-apex-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-apex-core/pulls/185/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-apex-core/statuses/45016f940f508fb18d9d6ed9807c01719a98d876"}}}}