{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/osquery/pulls/comments/22774558","id":22774558,"diff_hunk":"@@ -341,7 +347,7 @@ class EventPublisher : public EventPublisherCore {\n    *\n    * @return should the Subscription%'s EventCallback be called for this event.\n    */\n-  virtual bool shouldFire(const SCRef sc, const ECRef ec) { return true; }\n+  virtual bool shouldFire(const SCRef& sc, const ECRef& ec) { return true; }","path":"include/osquery/events.h","position":32,"original_position":32,"commit_id":"465db46628887e10ff71eccb681712f62338ef16","original_commit_id":"465db46628887e10ff71eccb681712f62338ef16","user":{"login":"theopolis","id":981645,"avatar_url":"https://avatars.githubusercontent.com/u/981645?v=3","gravatar_id":"","url":"https://api.github.com/users/theopolis","html_url":"https://github.com/theopolis","followers_url":"https://api.github.com/users/theopolis/followers","following_url":"https://api.github.com/users/theopolis/following{/other_user}","gists_url":"https://api.github.com/users/theopolis/gists{/gist_id}","starred_url":"https://api.github.com/users/theopolis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theopolis/subscriptions","organizations_url":"https://api.github.com/users/theopolis/orgs","repos_url":"https://api.github.com/users/theopolis/repos","events_url":"https://api.github.com/users/theopolis/events{/privacy}","received_events_url":"https://api.github.com/users/theopolis/received_events","type":"User","site_admin":false},"body":"This is a systemic oversight and may have caused unknown behavior with how event publishers implemented their shouldFire methods. For inotify, the `fire` method would not have called the publisher-specific method and thus returned true for every event.","created_at":"2015-01-12T04:03:44Z","updated_at":"2015-01-12T04:03:44Z","html_url":"https://github.com/facebook/osquery/pull/609#discussion_r22774558","pull_request_url":"https://api.github.com/repos/facebook/osquery/pulls/609","_links":{"self":{"href":"https://api.github.com/repos/facebook/osquery/pulls/comments/22774558"},"html":{"href":"https://github.com/facebook/osquery/pull/609#discussion_r22774558"},"pull_request":{"href":"https://api.github.com/repos/facebook/osquery/pulls/609"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/osquery/pulls/609","id":27173943,"html_url":"https://github.com/facebook/osquery/pull/609","diff_url":"https://github.com/facebook/osquery/pull/609.diff","patch_url":"https://github.com/facebook/osquery/pull/609.patch","issue_url":"https://api.github.com/repos/facebook/osquery/issues/609","number":609,"state":"open","locked":false,"title":"Fix shouldFire pubsub virtual","user":{"login":"theopolis","id":981645,"avatar_url":"https://avatars.githubusercontent.com/u/981645?v=3","gravatar_id":"","url":"https://api.github.com/users/theopolis","html_url":"https://github.com/theopolis","followers_url":"https://api.github.com/users/theopolis/followers","following_url":"https://api.github.com/users/theopolis/following{/other_user}","gists_url":"https://api.github.com/users/theopolis/gists{/gist_id}","starred_url":"https://api.github.com/users/theopolis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theopolis/subscriptions","organizations_url":"https://api.github.com/users/theopolis/orgs","repos_url":"https://api.github.com/users/theopolis/repos","events_url":"https://api.github.com/users/theopolis/events{/privacy}","received_events_url":"https://api.github.com/users/theopolis/received_events","type":"User","site_admin":false},"body":"This moves the ending decision/boolean into the publisher but also fixes a bug that caused inotify to log more often than. \r\n\r\nThe inotify publisher shouldFire method should be the cause of https://github.com/facebook/osquery/issues/559","created_at":"2015-01-12T03:45:39Z","updated_at":"2015-01-12T04:03:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d95dbcccc6b0d04f53a8d2ed17335885edbde443","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/facebook/osquery/pulls/609/commits","review_comments_url":"https://api.github.com/repos/facebook/osquery/pulls/609/comments","review_comment_url":"https://api.github.com/repos/facebook/osquery/pulls/comments/{number}","comments_url":"https://api.github.com/repos/facebook/osquery/issues/609/comments","statuses_url":"https://api.github.com/repos/facebook/osquery/statuses/465db46628887e10ff71eccb681712f62338ef16","head":{"label":"theopolis:events_fix","ref":"events_fix","sha":"465db46628887e10ff71eccb681712f62338ef16","user":{"login":"theopolis","id":981645,"avatar_url":"https://avatars.githubusercontent.com/u/981645?v=3","gravatar_id":"","url":"https://api.github.com/users/theopolis","html_url":"https://github.com/theopolis","followers_url":"https://api.github.com/users/theopolis/followers","following_url":"https://api.github.com/users/theopolis/following{/other_user}","gists_url":"https://api.github.com/users/theopolis/gists{/gist_id}","starred_url":"https://api.github.com/users/theopolis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theopolis/subscriptions","organizations_url":"https://api.github.com/users/theopolis/orgs","repos_url":"https://api.github.com/users/theopolis/repos","events_url":"https://api.github.com/users/theopolis/events{/privacy}","received_events_url":"https://api.github.com/users/theopolis/received_events","type":"User","site_admin":false},"repo":{"id":26103098,"name":"osquery","full_name":"theopolis/osquery","owner":{"login":"theopolis","id":981645,"avatar_url":"https://avatars.githubusercontent.com/u/981645?v=3","gravatar_id":"","url":"https://api.github.com/users/theopolis","html_url":"https://github.com/theopolis","followers_url":"https://api.github.com/users/theopolis/followers","following_url":"https://api.github.com/users/theopolis/following{/other_user}","gists_url":"https://api.github.com/users/theopolis/gists{/gist_id}","starred_url":"https://api.github.com/users/theopolis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theopolis/subscriptions","organizations_url":"https://api.github.com/users/theopolis/orgs","repos_url":"https://api.github.com/users/theopolis/repos","events_url":"https://api.github.com/users/theopolis/events{/privacy}","received_events_url":"https://api.github.com/users/theopolis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/theopolis/osquery","description":"SQL powered operating system instrumentation and monitoring.","fork":true,"url":"https://api.github.com/repos/theopolis/osquery","forks_url":"https://api.github.com/repos/theopolis/osquery/forks","keys_url":"https://api.github.com/repos/theopolis/osquery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theopolis/osquery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theopolis/osquery/teams","hooks_url":"https://api.github.com/repos/theopolis/osquery/hooks","issue_events_url":"https://api.github.com/repos/theopolis/osquery/issues/events{/number}","events_url":"https://api.github.com/repos/theopolis/osquery/events","assignees_url":"https://api.github.com/repos/theopolis/osquery/assignees{/user}","branches_url":"https://api.github.com/repos/theopolis/osquery/branches{/branch}","tags_url":"https://api.github.com/repos/theopolis/osquery/tags","blobs_url":"https://api.github.com/repos/theopolis/osquery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theopolis/osquery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theopolis/osquery/git/refs{/sha}","trees_url":"https://api.github.com/repos/theopolis/osquery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theopolis/osquery/statuses/{sha}","languages_url":"https://api.github.com/repos/theopolis/osquery/languages","stargazers_url":"https://api.github.com/repos/theopolis/osquery/stargazers","contributors_url":"https://api.github.com/repos/theopolis/osquery/contributors","subscribers_url":"https://api.github.com/repos/theopolis/osquery/subscribers","subscription_url":"https://api.github.com/repos/theopolis/osquery/subscription","commits_url":"https://api.github.com/repos/theopolis/osquery/commits{/sha}","git_commits_url":"https://api.github.com/repos/theopolis/osquery/git/commits{/sha}","comments_url":"https://api.github.com/repos/theopolis/osquery/comments{/number}","issue_comment_url":"https://api.github.com/repos/theopolis/osquery/issues/comments/{number}","contents_url":"https://api.github.com/repos/theopolis/osquery/contents/{+path}","compare_url":"https://api.github.com/repos/theopolis/osquery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theopolis/osquery/merges","archive_url":"https://api.github.com/repos/theopolis/osquery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theopolis/osquery/downloads","issues_url":"https://api.github.com/repos/theopolis/osquery/issues{/number}","pulls_url":"https://api.github.com/repos/theopolis/osquery/pulls{/number}","milestones_url":"https://api.github.com/repos/theopolis/osquery/milestones{/number}","notifications_url":"https://api.github.com/repos/theopolis/osquery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theopolis/osquery/labels{/name}","releases_url":"https://api.github.com/repos/theopolis/osquery/releases{/id}","created_at":"2014-11-03T03:56:14Z","updated_at":"2014-11-18T00:52:36Z","pushed_at":"2015-01-12T03:52:32Z","git_url":"git://github.com/theopolis/osquery.git","ssh_url":"git@github.com:theopolis/osquery.git","clone_url":"https://github.com/theopolis/osquery.git","svn_url":"https://github.com/theopolis/osquery","homepage":"http://osquery.io","size":3935,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"597b5ed4be2075a9f92ddfac4442859cf07a20f2","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":22394357,"name":"osquery","full_name":"facebook/osquery","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/osquery","description":"SQL powered operating system instrumentation, monitoring, and analytics.","fork":false,"url":"https://api.github.com/repos/facebook/osquery","forks_url":"https://api.github.com/repos/facebook/osquery/forks","keys_url":"https://api.github.com/repos/facebook/osquery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/osquery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/osquery/teams","hooks_url":"https://api.github.com/repos/facebook/osquery/hooks","issue_events_url":"https://api.github.com/repos/facebook/osquery/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/osquery/events","assignees_url":"https://api.github.com/repos/facebook/osquery/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/osquery/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/osquery/tags","blobs_url":"https://api.github.com/repos/facebook/osquery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/osquery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/osquery/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/osquery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/osquery/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/osquery/languages","stargazers_url":"https://api.github.com/repos/facebook/osquery/stargazers","contributors_url":"https://api.github.com/repos/facebook/osquery/contributors","subscribers_url":"https://api.github.com/repos/facebook/osquery/subscribers","subscription_url":"https://api.github.com/repos/facebook/osquery/subscription","commits_url":"https://api.github.com/repos/facebook/osquery/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/osquery/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/osquery/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/osquery/issues/comments/{number}","contents_url":"https://api.github.com/repos/facebook/osquery/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/osquery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/osquery/merges","archive_url":"https://api.github.com/repos/facebook/osquery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/osquery/downloads","issues_url":"https://api.github.com/repos/facebook/osquery/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/osquery/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/osquery/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/osquery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/osquery/labels{/name}","releases_url":"https://api.github.com/repos/facebook/osquery/releases{/id}","created_at":"2014-07-29T20:27:33Z","updated_at":"2015-01-11T22:40:24Z","pushed_at":"2015-01-11T22:40:24Z","git_url":"git://github.com/facebook/osquery.git","ssh_url":"git@github.com:facebook/osquery.git","clone_url":"https://github.com/facebook/osquery.git","svn_url":"https://github.com/facebook/osquery","homepage":"http://osquery.io","size":9731,"stargazers_count":3469,"watchers_count":3469,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":235,"mirror_url":null,"open_issues_count":67,"forks":235,"open_issues":67,"watchers":3469,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/osquery/pulls/609"},"html":{"href":"https://github.com/facebook/osquery/pull/609"},"issue":{"href":"https://api.github.com/repos/facebook/osquery/issues/609"},"comments":{"href":"https://api.github.com/repos/facebook/osquery/issues/609/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/osquery/pulls/609/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/osquery/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/facebook/osquery/pulls/609/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/osquery/statuses/465db46628887e10ff71eccb681712f62338ef16"}}}}