{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/35497003","id":35497003,"diff_hunk":"@@ -167,22 +167,29 @@ private void CheckDisposed()\n \n         private string GetHeaderValueAsString(IEnumerable<string> values)\n         {\n-            var buffer = new StringBuilder();\n-\n             // There is always at least one value even if it is an empty string.\n             var enumerator = values.GetEnumerator();\n             bool success = enumerator.MoveNext();\n             Debug.Assert(success, \"There should be at least one value\");\n-            buffer.Append(enumerator.Current);\n \n-            // Handle more values if present.\n-            while (enumerator.MoveNext())\n+            string headerValue = enumerator.Current;\n+\n+            if (enumerator.MoveNext())\n             {\n-                buffer.Append(\", \");\n-                buffer.Append(enumerator.Current);\n+                // Multi-valued header\n+                var buffer = new StringBuilder();\n+                buffer.Append(headerValue);","path":"src/System.Net.Requests/src/System/Net/HttpWebResponse.cs","position":22,"original_position":22,"commit_id":"82dbecf9e081eaa3532d66055386b28ee970a608","original_commit_id":"82dbecf9e081eaa3532d66055386b28ee970a608","user":{"login":"Maxwe11","id":1083827,"avatar_url":"https://avatars.githubusercontent.com/u/1083827?v=3","gravatar_id":"","url":"https://api.github.com/users/Maxwe11","html_url":"https://github.com/Maxwe11","followers_url":"https://api.github.com/users/Maxwe11/followers","following_url":"https://api.github.com/users/Maxwe11/following{/other_user}","gists_url":"https://api.github.com/users/Maxwe11/gists{/gist_id}","starred_url":"https://api.github.com/users/Maxwe11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Maxwe11/subscriptions","organizations_url":"https://api.github.com/users/Maxwe11/orgs","repos_url":"https://api.github.com/users/Maxwe11/repos","events_url":"https://api.github.com/users/Maxwe11/events{/privacy}","received_events_url":"https://api.github.com/users/Maxwe11/received_events","type":"User","site_admin":false},"body":":bulb:  `var buffer = new StringBuilder(headerValue);`","created_at":"2015-07-26T20:20:49Z","updated_at":"2015-07-26T20:20:49Z","html_url":"https://github.com/dotnet/corefx/pull/2524#discussion_r35497003","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/2524","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/35497003"},"html":{"href":"https://github.com/dotnet/corefx/pull/2524#discussion_r35497003"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/2524"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/2524","id":40832499,"html_url":"https://github.com/dotnet/corefx/pull/2524","diff_url":"https://github.com/dotnet/corefx/pull/2524.diff","patch_url":"https://github.com/dotnet/corefx/pull/2524.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/2524","number":2524,"state":"open","locked":false,"title":"Reduce HttpWebResponse header allocations","user":{"login":"bbowyersmyth","id":2482209,"avatar_url":"https://avatars.githubusercontent.com/u/2482209?v=3","gravatar_id":"","url":"https://api.github.com/users/bbowyersmyth","html_url":"https://github.com/bbowyersmyth","followers_url":"https://api.github.com/users/bbowyersmyth/followers","following_url":"https://api.github.com/users/bbowyersmyth/following{/other_user}","gists_url":"https://api.github.com/users/bbowyersmyth/gists{/gist_id}","starred_url":"https://api.github.com/users/bbowyersmyth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbowyersmyth/subscriptions","organizations_url":"https://api.github.com/users/bbowyersmyth/orgs","repos_url":"https://api.github.com/users/bbowyersmyth/repos","events_url":"https://api.github.com/users/bbowyersmyth/events{/privacy}","received_events_url":"https://api.github.com/users/bbowyersmyth/received_events","type":"User","site_admin":false},"body":"Removed unnecessary ToUpperInvariant allocation in WinHttpHandler.\r\n\r\nHttpWebResponse created a StringBuilder for every header in the response to handle possible multi-values. Common case is a single value so lazy create the buffer when there is more than 1.","created_at":"2015-07-25T07:03:40Z","updated_at":"2015-07-26T20:20:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3a13be9d98861f92f1be572c7a0cf0ab875383ed","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/2524/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/2524/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/2524/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/82dbecf9e081eaa3532d66055386b28ee970a608","head":{"label":"bbowyersmyth:NetRequests","ref":"NetRequests","sha":"82dbecf9e081eaa3532d66055386b28ee970a608","user":{"login":"bbowyersmyth","id":2482209,"avatar_url":"https://avatars.githubusercontent.com/u/2482209?v=3","gravatar_id":"","url":"https://api.github.com/users/bbowyersmyth","html_url":"https://github.com/bbowyersmyth","followers_url":"https://api.github.com/users/bbowyersmyth/followers","following_url":"https://api.github.com/users/bbowyersmyth/following{/other_user}","gists_url":"https://api.github.com/users/bbowyersmyth/gists{/gist_id}","starred_url":"https://api.github.com/users/bbowyersmyth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbowyersmyth/subscriptions","organizations_url":"https://api.github.com/users/bbowyersmyth/orgs","repos_url":"https://api.github.com/users/bbowyersmyth/repos","events_url":"https://api.github.com/users/bbowyersmyth/events{/privacy}","received_events_url":"https://api.github.com/users/bbowyersmyth/received_events","type":"User","site_admin":false},"repo":{"id":28426101,"name":"corefx","full_name":"bbowyersmyth/corefx","owner":{"login":"bbowyersmyth","id":2482209,"avatar_url":"https://avatars.githubusercontent.com/u/2482209?v=3","gravatar_id":"","url":"https://api.github.com/users/bbowyersmyth","html_url":"https://github.com/bbowyersmyth","followers_url":"https://api.github.com/users/bbowyersmyth/followers","following_url":"https://api.github.com/users/bbowyersmyth/following{/other_user}","gists_url":"https://api.github.com/users/bbowyersmyth/gists{/gist_id}","starred_url":"https://api.github.com/users/bbowyersmyth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbowyersmyth/subscriptions","organizations_url":"https://api.github.com/users/bbowyersmyth/orgs","repos_url":"https://api.github.com/users/bbowyersmyth/repos","events_url":"https://api.github.com/users/bbowyersmyth/events{/privacy}","received_events_url":"https://api.github.com/users/bbowyersmyth/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bbowyersmyth/corefx","description":"This repository contains the foundational libraries that make up the .NET Core development stack.","fork":true,"url":"https://api.github.com/repos/bbowyersmyth/corefx","forks_url":"https://api.github.com/repos/bbowyersmyth/corefx/forks","keys_url":"https://api.github.com/repos/bbowyersmyth/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bbowyersmyth/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bbowyersmyth/corefx/teams","hooks_url":"https://api.github.com/repos/bbowyersmyth/corefx/hooks","issue_events_url":"https://api.github.com/repos/bbowyersmyth/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/bbowyersmyth/corefx/events","assignees_url":"https://api.github.com/repos/bbowyersmyth/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/bbowyersmyth/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/bbowyersmyth/corefx/tags","blobs_url":"https://api.github.com/repos/bbowyersmyth/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bbowyersmyth/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bbowyersmyth/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/bbowyersmyth/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bbowyersmyth/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/bbowyersmyth/corefx/languages","stargazers_url":"https://api.github.com/repos/bbowyersmyth/corefx/stargazers","contributors_url":"https://api.github.com/repos/bbowyersmyth/corefx/contributors","subscribers_url":"https://api.github.com/repos/bbowyersmyth/corefx/subscribers","subscription_url":"https://api.github.com/repos/bbowyersmyth/corefx/subscription","commits_url":"https://api.github.com/repos/bbowyersmyth/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/bbowyersmyth/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/bbowyersmyth/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/bbowyersmyth/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/bbowyersmyth/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/bbowyersmyth/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bbowyersmyth/corefx/merges","archive_url":"https://api.github.com/repos/bbowyersmyth/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bbowyersmyth/corefx/downloads","issues_url":"https://api.github.com/repos/bbowyersmyth/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/bbowyersmyth/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/bbowyersmyth/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/bbowyersmyth/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bbowyersmyth/corefx/labels{/name}","releases_url":"https://api.github.com/repos/bbowyersmyth/corefx/releases{/id}","created_at":"2014-12-24T00:19:56Z","updated_at":"2015-05-08T20:54:02Z","pushed_at":"2015-07-25T06:48:42Z","git_url":"git://github.com/bbowyersmyth/corefx.git","ssh_url":"git@github.com:bbowyersmyth/corefx.git","clone_url":"https://github.com/bbowyersmyth/corefx.git","svn_url":"https://github.com/bbowyersmyth/corefx","homepage":"","size":25112,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"17a9de2961b658ee46b55dae1059c646383fd6b6","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","created_at":"2014-11-06T23:42:48Z","updated_at":"2015-07-26T17:54:53Z","pushed_at":"2015-07-26T17:36:42Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"http://dotnet.github.io/core/","size":55573,"stargazers_count":8124,"watchers_count":8124,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1696,"mirror_url":null,"open_issues_count":519,"forks":1696,"open_issues":519,"watchers":8124,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/2524"},"html":{"href":"https://github.com/dotnet/corefx/pull/2524"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/2524"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/2524/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/2524/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/2524/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/82dbecf9e081eaa3532d66055386b28ee970a608"}}}}