{"action":"created","comment":{"url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments/24751523","id":24751523,"diff_hunk":"@@ -240,7 +254,7 @@ protected static int getPartitionId(NodeEngine nodeEngine, Data key) {\n      */\n     public static <V> void validateConfiguredValueType(Class<V> valueType, V value)\n             throws ClassCastException {\n-        if (Object.class != valueType) {\n+        if (value != null && valueType != null && Object.class != valueType) {\n             //means type checks required\n             if (!valueType.isAssignableFrom(value.getClass())) {\n                 throw new ClassCastException(\"Value \" + value + \"is not assignable to \" + valueType);","path":"hazelcast/src/main/java/com/hazelcast/cache/impl/CacheProxyUtil.java","position":38,"original_position":38,"commit_id":"19e8a8261bbc8be2c224300cbe628d17da5ce5bc","original_commit_id":"19e8a8261bbc8be2c224300cbe628d17da5ce5bc","user":{"login":"serkan-ozal","id":3143425,"avatar_url":"https://avatars.githubusercontent.com/u/3143425?v=3","gravatar_id":"","url":"https://api.github.com/users/serkan-ozal","html_url":"https://github.com/serkan-ozal","followers_url":"https://api.github.com/users/serkan-ozal/followers","following_url":"https://api.github.com/users/serkan-ozal/following{/other_user}","gists_url":"https://api.github.com/users/serkan-ozal/gists{/gist_id}","starred_url":"https://api.github.com/users/serkan-ozal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serkan-ozal/subscriptions","organizations_url":"https://api.github.com/users/serkan-ozal/orgs","repos_url":"https://api.github.com/users/serkan-ozal/repos","events_url":"https://api.github.com/users/serkan-ozal/events{/privacy}","received_events_url":"https://api.github.com/users/serkan-ozal/received_events","type":"User","site_admin":false},"body":"I think, type of value should be logged to give more details since `int value  = 1` and `String value = \"1\"` are same output `1` but their types are different","created_at":"2015-02-16T13:53:35Z","updated_at":"2015-02-16T13:53:35Z","html_url":"https://github.com/hazelcast/hazelcast/pull/4586#discussion_r24751523","pull_request_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/4586","_links":{"self":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments/24751523"},"html":{"href":"https://github.com/hazelcast/hazelcast/pull/4586#discussion_r24751523"},"pull_request":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/4586"}}},"pull_request":{"url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/4586","id":29082619,"html_url":"https://github.com/hazelcast/hazelcast/pull/4586","diff_url":"https://github.com/hazelcast/hazelcast/pull/4586.diff","patch_url":"https://github.com/hazelcast/hazelcast/pull/4586.patch","issue_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/4586","number":4586,"state":"open","locked":false,"title":"Added unittests for typechecks according to javax.cache.Cache and the up...","user":{"login":"noctarius","id":1142801,"avatar_url":"https://avatars.githubusercontent.com/u/1142801?v=3","gravatar_id":"","url":"https://api.github.com/users/noctarius","html_url":"https://github.com/noctarius","followers_url":"https://api.github.com/users/noctarius/followers","following_url":"https://api.github.com/users/noctarius/following{/other_user}","gists_url":"https://api.github.com/users/noctarius/gists{/gist_id}","starred_url":"https://api.github.com/users/noctarius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noctarius/subscriptions","organizations_url":"https://api.github.com/users/noctarius/orgs","repos_url":"https://api.github.com/users/noctarius/repos","events_url":"https://api.github.com/users/noctarius/events{/privacy}","received_events_url":"https://api.github.com/users/noctarius/received_events","type":"User","site_admin":false},"body":"...dated ICache Javadocs - related #4504 #4583","created_at":"2015-02-11T11:07:51Z","updated_at":"2015-02-16T13:53:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"accfaee46cb8491688af2204b26c11875f4e9ce7","assignee":{"login":"serkan-ozal","id":3143425,"avatar_url":"https://avatars.githubusercontent.com/u/3143425?v=3","gravatar_id":"","url":"https://api.github.com/users/serkan-ozal","html_url":"https://github.com/serkan-ozal","followers_url":"https://api.github.com/users/serkan-ozal/followers","following_url":"https://api.github.com/users/serkan-ozal/following{/other_user}","gists_url":"https://api.github.com/users/serkan-ozal/gists{/gist_id}","starred_url":"https://api.github.com/users/serkan-ozal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serkan-ozal/subscriptions","organizations_url":"https://api.github.com/users/serkan-ozal/orgs","repos_url":"https://api.github.com/users/serkan-ozal/repos","events_url":"https://api.github.com/users/serkan-ozal/events{/privacy}","received_events_url":"https://api.github.com/users/serkan-ozal/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/hazelcast/hazelcast/milestones/60","labels_url":"https://api.github.com/repos/hazelcast/hazelcast/milestones/60/labels","id":973771,"number":60,"title":"3.4.2","description":"","creator":{"login":"degerhz","id":8373100,"avatar_url":"https://avatars.githubusercontent.com/u/8373100?v=3","gravatar_id":"","url":"https://api.github.com/users/degerhz","html_url":"https://github.com/degerhz","followers_url":"https://api.github.com/users/degerhz/followers","following_url":"https://api.github.com/users/degerhz/following{/other_user}","gists_url":"https://api.github.com/users/degerhz/gists{/gist_id}","starred_url":"https://api.github.com/users/degerhz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/degerhz/subscriptions","organizations_url":"https://api.github.com/users/degerhz/orgs","repos_url":"https://api.github.com/users/degerhz/repos","events_url":"https://api.github.com/users/degerhz/events{/privacy}","received_events_url":"https://api.github.com/users/degerhz/received_events","type":"User","site_admin":false},"open_issues":40,"closed_issues":13,"state":"open","created_at":"2015-02-10T15:22:26Z","updated_at":"2015-02-16T12:48:00Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/4586/commits","review_comments_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/4586/comments","review_comment_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments/{number}","comments_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/4586/comments","statuses_url":"https://api.github.com/repos/hazelcast/hazelcast/statuses/19e8a8261bbc8be2c224300cbe628d17da5ce5bc","head":{"label":"noctarius:jcache-typecheck-unittests","ref":"jcache-typecheck-unittests","sha":"19e8a8261bbc8be2c224300cbe628d17da5ce5bc","user":{"login":"noctarius","id":1142801,"avatar_url":"https://avatars.githubusercontent.com/u/1142801?v=3","gravatar_id":"","url":"https://api.github.com/users/noctarius","html_url":"https://github.com/noctarius","followers_url":"https://api.github.com/users/noctarius/followers","following_url":"https://api.github.com/users/noctarius/following{/other_user}","gists_url":"https://api.github.com/users/noctarius/gists{/gist_id}","starred_url":"https://api.github.com/users/noctarius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noctarius/subscriptions","organizations_url":"https://api.github.com/users/noctarius/orgs","repos_url":"https://api.github.com/users/noctarius/repos","events_url":"https://api.github.com/users/noctarius/events{/privacy}","received_events_url":"https://api.github.com/users/noctarius/received_events","type":"User","site_admin":false},"repo":{"id":10761627,"name":"hazelcast","full_name":"noctarius/hazelcast","owner":{"login":"noctarius","id":1142801,"avatar_url":"https://avatars.githubusercontent.com/u/1142801?v=3","gravatar_id":"","url":"https://api.github.com/users/noctarius","html_url":"https://github.com/noctarius","followers_url":"https://api.github.com/users/noctarius/followers","following_url":"https://api.github.com/users/noctarius/following{/other_user}","gists_url":"https://api.github.com/users/noctarius/gists{/gist_id}","starred_url":"https://api.github.com/users/noctarius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noctarius/subscriptions","organizations_url":"https://api.github.com/users/noctarius/orgs","repos_url":"https://api.github.com/users/noctarius/repos","events_url":"https://api.github.com/users/noctarius/events{/privacy}","received_events_url":"https://api.github.com/users/noctarius/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/noctarius/hazelcast","description":"Open Source In-Memory Data Grid","fork":true,"url":"https://api.github.com/repos/noctarius/hazelcast","forks_url":"https://api.github.com/repos/noctarius/hazelcast/forks","keys_url":"https://api.github.com/repos/noctarius/hazelcast/keys{/key_id}","collaborators_url":"https://api.github.com/repos/noctarius/hazelcast/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/noctarius/hazelcast/teams","hooks_url":"https://api.github.com/repos/noctarius/hazelcast/hooks","issue_events_url":"https://api.github.com/repos/noctarius/hazelcast/issues/events{/number}","events_url":"https://api.github.com/repos/noctarius/hazelcast/events","assignees_url":"https://api.github.com/repos/noctarius/hazelcast/assignees{/user}","branches_url":"https://api.github.com/repos/noctarius/hazelcast/branches{/branch}","tags_url":"https://api.github.com/repos/noctarius/hazelcast/tags","blobs_url":"https://api.github.com/repos/noctarius/hazelcast/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/noctarius/hazelcast/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/noctarius/hazelcast/git/refs{/sha}","trees_url":"https://api.github.com/repos/noctarius/hazelcast/git/trees{/sha}","statuses_url":"https://api.github.com/repos/noctarius/hazelcast/statuses/{sha}","languages_url":"https://api.github.com/repos/noctarius/hazelcast/languages","stargazers_url":"https://api.github.com/repos/noctarius/hazelcast/stargazers","contributors_url":"https://api.github.com/repos/noctarius/hazelcast/contributors","subscribers_url":"https://api.github.com/repos/noctarius/hazelcast/subscribers","subscription_url":"https://api.github.com/repos/noctarius/hazelcast/subscription","commits_url":"https://api.github.com/repos/noctarius/hazelcast/commits{/sha}","git_commits_url":"https://api.github.com/repos/noctarius/hazelcast/git/commits{/sha}","comments_url":"https://api.github.com/repos/noctarius/hazelcast/comments{/number}","issue_comment_url":"https://api.github.com/repos/noctarius/hazelcast/issues/comments/{number}","contents_url":"https://api.github.com/repos/noctarius/hazelcast/contents/{+path}","compare_url":"https://api.github.com/repos/noctarius/hazelcast/compare/{base}...{head}","merges_url":"https://api.github.com/repos/noctarius/hazelcast/merges","archive_url":"https://api.github.com/repos/noctarius/hazelcast/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/noctarius/hazelcast/downloads","issues_url":"https://api.github.com/repos/noctarius/hazelcast/issues{/number}","pulls_url":"https://api.github.com/repos/noctarius/hazelcast/pulls{/number}","milestones_url":"https://api.github.com/repos/noctarius/hazelcast/milestones{/number}","notifications_url":"https://api.github.com/repos/noctarius/hazelcast/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/noctarius/hazelcast/labels{/name}","releases_url":"https://api.github.com/repos/noctarius/hazelcast/releases{/id}","created_at":"2013-06-18T11:19:13Z","updated_at":"2014-06-26T07:29:47Z","pushed_at":"2015-02-16T13:27:11Z","git_url":"git://github.com/noctarius/hazelcast.git","ssh_url":"git@github.com:noctarius/hazelcast.git","clone_url":"https://github.com/noctarius/hazelcast.git","svn_url":"https://github.com/noctarius/hazelcast","homepage":"www.hazelcast.com","size":60069,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"hazelcast:master","ref":"master","sha":"27163ccbfe0a992b610922bdd44414d307ba96a6","user":{"login":"hazelcast","id":1453152,"avatar_url":"https://avatars.githubusercontent.com/u/1453152?v=3","gravatar_id":"","url":"https://api.github.com/users/hazelcast","html_url":"https://github.com/hazelcast","followers_url":"https://api.github.com/users/hazelcast/followers","following_url":"https://api.github.com/users/hazelcast/following{/other_user}","gists_url":"https://api.github.com/users/hazelcast/gists{/gist_id}","starred_url":"https://api.github.com/users/hazelcast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hazelcast/subscriptions","organizations_url":"https://api.github.com/users/hazelcast/orgs","repos_url":"https://api.github.com/users/hazelcast/repos","events_url":"https://api.github.com/users/hazelcast/events{/privacy}","received_events_url":"https://api.github.com/users/hazelcast/received_events","type":"Organization","site_admin":false},"repo":{"id":3786237,"name":"hazelcast","full_name":"hazelcast/hazelcast","owner":{"login":"hazelcast","id":1453152,"avatar_url":"https://avatars.githubusercontent.com/u/1453152?v=3","gravatar_id":"","url":"https://api.github.com/users/hazelcast","html_url":"https://github.com/hazelcast","followers_url":"https://api.github.com/users/hazelcast/followers","following_url":"https://api.github.com/users/hazelcast/following{/other_user}","gists_url":"https://api.github.com/users/hazelcast/gists{/gist_id}","starred_url":"https://api.github.com/users/hazelcast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hazelcast/subscriptions","organizations_url":"https://api.github.com/users/hazelcast/orgs","repos_url":"https://api.github.com/users/hazelcast/repos","events_url":"https://api.github.com/users/hazelcast/events{/privacy}","received_events_url":"https://api.github.com/users/hazelcast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hazelcast/hazelcast","description":"Open Source In-Memory Data Grid","fork":false,"url":"https://api.github.com/repos/hazelcast/hazelcast","forks_url":"https://api.github.com/repos/hazelcast/hazelcast/forks","keys_url":"https://api.github.com/repos/hazelcast/hazelcast/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hazelcast/hazelcast/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hazelcast/hazelcast/teams","hooks_url":"https://api.github.com/repos/hazelcast/hazelcast/hooks","issue_events_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/events{/number}","events_url":"https://api.github.com/repos/hazelcast/hazelcast/events","assignees_url":"https://api.github.com/repos/hazelcast/hazelcast/assignees{/user}","branches_url":"https://api.github.com/repos/hazelcast/hazelcast/branches{/branch}","tags_url":"https://api.github.com/repos/hazelcast/hazelcast/tags","blobs_url":"https://api.github.com/repos/hazelcast/hazelcast/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hazelcast/hazelcast/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hazelcast/hazelcast/git/refs{/sha}","trees_url":"https://api.github.com/repos/hazelcast/hazelcast/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hazelcast/hazelcast/statuses/{sha}","languages_url":"https://api.github.com/repos/hazelcast/hazelcast/languages","stargazers_url":"https://api.github.com/repos/hazelcast/hazelcast/stargazers","contributors_url":"https://api.github.com/repos/hazelcast/hazelcast/contributors","subscribers_url":"https://api.github.com/repos/hazelcast/hazelcast/subscribers","subscription_url":"https://api.github.com/repos/hazelcast/hazelcast/subscription","commits_url":"https://api.github.com/repos/hazelcast/hazelcast/commits{/sha}","git_commits_url":"https://api.github.com/repos/hazelcast/hazelcast/git/commits{/sha}","comments_url":"https://api.github.com/repos/hazelcast/hazelcast/comments{/number}","issue_comment_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/comments/{number}","contents_url":"https://api.github.com/repos/hazelcast/hazelcast/contents/{+path}","compare_url":"https://api.github.com/repos/hazelcast/hazelcast/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hazelcast/hazelcast/merges","archive_url":"https://api.github.com/repos/hazelcast/hazelcast/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hazelcast/hazelcast/downloads","issues_url":"https://api.github.com/repos/hazelcast/hazelcast/issues{/number}","pulls_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls{/number}","milestones_url":"https://api.github.com/repos/hazelcast/hazelcast/milestones{/number}","notifications_url":"https://api.github.com/repos/hazelcast/hazelcast/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hazelcast/hazelcast/labels{/name}","releases_url":"https://api.github.com/repos/hazelcast/hazelcast/releases{/id}","created_at":"2012-03-21T12:25:18Z","updated_at":"2015-02-16T12:48:02Z","pushed_at":"2015-02-16T12:48:01Z","git_url":"git://github.com/hazelcast/hazelcast.git","ssh_url":"git@github.com:hazelcast/hazelcast.git","clone_url":"https://github.com/hazelcast/hazelcast.git","svn_url":"https://github.com/hazelcast/hazelcast","homepage":"www.hazelcast.com","size":118275,"stargazers_count":1027,"watchers_count":1027,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":475,"mirror_url":null,"open_issues_count":385,"forks":475,"open_issues":385,"watchers":1027,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/4586"},"html":{"href":"https://github.com/hazelcast/hazelcast/pull/4586"},"issue":{"href":"https://api.github.com/repos/hazelcast/hazelcast/issues/4586"},"comments":{"href":"https://api.github.com/repos/hazelcast/hazelcast/issues/4586/comments"},"review_comments":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/4586/comments"},"review_comment":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/4586/commits"},"statuses":{"href":"https://api.github.com/repos/hazelcast/hazelcast/statuses/19e8a8261bbc8be2c224300cbe628d17da5ce5bc"}}}}