{"action":"created","comment":{"url":"https://api.github.com/repos/svaarala/duktape/pulls/comments/38314231","id":38314231,"diff_hunk":"@@ -107,10 +113,11 @@ DUK_INTERNAL void duk_err_create_and_throw(duk_hthread *thr, duk_errcode_t code)\n \t *  Finally, longjmp\n \t */\n \n-\tthr->heap->handling_error = 0;\n-\n \tduk_err_setup_heap_ljstate(thr, DUK_LJ_TYPE_THROW);\n \n+\tthr->callstack_max -= DUK_CALLSTACK_DEFAULT_MAX * 2;  /* reset reclimit */\n+\tthr->heap->handling_error = 0;","path":"src/duk_error_throw.c","position":22,"original_position":22,"commit_id":"8e35cdb10c0032d2739bf4c42a280f745d627cad","original_commit_id":"8e35cdb10c0032d2739bf4c42a280f745d627cad","user":{"login":"fatcerberus","id":4097841,"avatar_url":"https://avatars.githubusercontent.com/u/4097841?v=3","gravatar_id":"","url":"https://api.github.com/users/fatcerberus","html_url":"https://github.com/fatcerberus","followers_url":"https://api.github.com/users/fatcerberus/followers","following_url":"https://api.github.com/users/fatcerberus/following{/other_user}","gists_url":"https://api.github.com/users/fatcerberus/gists{/gist_id}","starred_url":"https://api.github.com/users/fatcerberus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fatcerberus/subscriptions","organizations_url":"https://api.github.com/users/fatcerberus/orgs","repos_url":"https://api.github.com/users/fatcerberus/repos","events_url":"https://api.github.com/users/fatcerberus/events{/privacy}","received_events_url":"https://api.github.com/users/fatcerberus/received_events","type":"User","site_admin":false},"body":"But keep in mind if the restore path is skipped, the assert will be also. :)","created_at":"2015-08-31T14:01:54Z","updated_at":"2015-08-31T14:01:54Z","html_url":"https://github.com/svaarala/duktape/pull/315#discussion_r38314231","pull_request_url":"https://api.github.com/repos/svaarala/duktape/pulls/315","_links":{"self":{"href":"https://api.github.com/repos/svaarala/duktape/pulls/comments/38314231"},"html":{"href":"https://github.com/svaarala/duktape/pull/315#discussion_r38314231"},"pull_request":{"href":"https://api.github.com/repos/svaarala/duktape/pulls/315"}}},"pull_request":{"url":"https://api.github.com/repos/svaarala/duktape/pulls/315","id":43731579,"html_url":"https://github.com/svaarala/duktape/pull/315","diff_url":"https://github.com/svaarala/duktape/pull/315.diff","patch_url":"https://github.com/svaarala/duktape/pull/315.patch","issue_url":"https://api.github.com/repos/svaarala/duktape/issues/315","number":315,"state":"open","locked":false,"title":"Error handler callstack bump to fix GH-191","user":{"login":"fatcerberus","id":4097841,"avatar_url":"https://avatars.githubusercontent.com/u/4097841?v=3","gravatar_id":"","url":"https://api.github.com/users/fatcerberus","html_url":"https://github.com/fatcerberus","followers_url":"https://api.github.com/users/fatcerberus/followers","following_url":"https://api.github.com/users/fatcerberus/following{/other_user}","gists_url":"https://api.github.com/users/fatcerberus/gists{/gist_id}","starred_url":"https://api.github.com/users/fatcerberus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fatcerberus/subscriptions","organizations_url":"https://api.github.com/users/fatcerberus/orgs","repos_url":"https://api.github.com/users/fatcerberus/repos","events_url":"https://api.github.com/users/fatcerberus/events{/privacy}","received_events_url":"https://api.github.com/users/fatcerberus/received_events","type":"User","site_admin":false},"body":"This fixes #191.  Note that I couldn't figure out how to run the tests, so I can't see whether the test actually passes or not (it did when I tried the test code in minisphere).","created_at":"2015-08-31T04:46:23Z","updated_at":"2015-08-31T14:01:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4399152c6c4e4dc8f404dfb6afd0f93d79be42f0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/svaarala/duktape/pulls/315/commits","review_comments_url":"https://api.github.com/repos/svaarala/duktape/pulls/315/comments","review_comment_url":"https://api.github.com/repos/svaarala/duktape/pulls/comments{/number}","comments_url":"https://api.github.com/repos/svaarala/duktape/issues/315/comments","statuses_url":"https://api.github.com/repos/svaarala/duktape/statuses/8e35cdb10c0032d2739bf4c42a280f745d627cad","head":{"label":"fatcerberus:error-handler-callstack-bump","ref":"error-handler-callstack-bump","sha":"8e35cdb10c0032d2739bf4c42a280f745d627cad","user":{"login":"fatcerberus","id":4097841,"avatar_url":"https://avatars.githubusercontent.com/u/4097841?v=3","gravatar_id":"","url":"https://api.github.com/users/fatcerberus","html_url":"https://github.com/fatcerberus","followers_url":"https://api.github.com/users/fatcerberus/followers","following_url":"https://api.github.com/users/fatcerberus/following{/other_user}","gists_url":"https://api.github.com/users/fatcerberus/gists{/gist_id}","starred_url":"https://api.github.com/users/fatcerberus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fatcerberus/subscriptions","organizations_url":"https://api.github.com/users/fatcerberus/orgs","repos_url":"https://api.github.com/users/fatcerberus/repos","events_url":"https://api.github.com/users/fatcerberus/events{/privacy}","received_events_url":"https://api.github.com/users/fatcerberus/received_events","type":"User","site_admin":false},"repo":{"id":35036428,"name":"duktape","full_name":"fatcerberus/duktape","owner":{"login":"fatcerberus","id":4097841,"avatar_url":"https://avatars.githubusercontent.com/u/4097841?v=3","gravatar_id":"","url":"https://api.github.com/users/fatcerberus","html_url":"https://github.com/fatcerberus","followers_url":"https://api.github.com/users/fatcerberus/followers","following_url":"https://api.github.com/users/fatcerberus/following{/other_user}","gists_url":"https://api.github.com/users/fatcerberus/gists{/gist_id}","starred_url":"https://api.github.com/users/fatcerberus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fatcerberus/subscriptions","organizations_url":"https://api.github.com/users/fatcerberus/orgs","repos_url":"https://api.github.com/users/fatcerberus/repos","events_url":"https://api.github.com/users/fatcerberus/events{/privacy}","received_events_url":"https://api.github.com/users/fatcerberus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fatcerberus/duktape","description":"Duktape - embeddable Javascript engine with a focus on portability and compact footprint","fork":true,"url":"https://api.github.com/repos/fatcerberus/duktape","forks_url":"https://api.github.com/repos/fatcerberus/duktape/forks","keys_url":"https://api.github.com/repos/fatcerberus/duktape/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fatcerberus/duktape/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fatcerberus/duktape/teams","hooks_url":"https://api.github.com/repos/fatcerberus/duktape/hooks","issue_events_url":"https://api.github.com/repos/fatcerberus/duktape/issues/events{/number}","events_url":"https://api.github.com/repos/fatcerberus/duktape/events","assignees_url":"https://api.github.com/repos/fatcerberus/duktape/assignees{/user}","branches_url":"https://api.github.com/repos/fatcerberus/duktape/branches{/branch}","tags_url":"https://api.github.com/repos/fatcerberus/duktape/tags","blobs_url":"https://api.github.com/repos/fatcerberus/duktape/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fatcerberus/duktape/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fatcerberus/duktape/git/refs{/sha}","trees_url":"https://api.github.com/repos/fatcerberus/duktape/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fatcerberus/duktape/statuses/{sha}","languages_url":"https://api.github.com/repos/fatcerberus/duktape/languages","stargazers_url":"https://api.github.com/repos/fatcerberus/duktape/stargazers","contributors_url":"https://api.github.com/repos/fatcerberus/duktape/contributors","subscribers_url":"https://api.github.com/repos/fatcerberus/duktape/subscribers","subscription_url":"https://api.github.com/repos/fatcerberus/duktape/subscription","commits_url":"https://api.github.com/repos/fatcerberus/duktape/commits{/sha}","git_commits_url":"https://api.github.com/repos/fatcerberus/duktape/git/commits{/sha}","comments_url":"https://api.github.com/repos/fatcerberus/duktape/comments{/number}","issue_comment_url":"https://api.github.com/repos/fatcerberus/duktape/issues/comments{/number}","contents_url":"https://api.github.com/repos/fatcerberus/duktape/contents/{+path}","compare_url":"https://api.github.com/repos/fatcerberus/duktape/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fatcerberus/duktape/merges","archive_url":"https://api.github.com/repos/fatcerberus/duktape/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fatcerberus/duktape/downloads","issues_url":"https://api.github.com/repos/fatcerberus/duktape/issues{/number}","pulls_url":"https://api.github.com/repos/fatcerberus/duktape/pulls{/number}","milestones_url":"https://api.github.com/repos/fatcerberus/duktape/milestones{/number}","notifications_url":"https://api.github.com/repos/fatcerberus/duktape/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fatcerberus/duktape/labels{/name}","releases_url":"https://api.github.com/repos/fatcerberus/duktape/releases{/id}","created_at":"2015-05-04T13:30:42Z","updated_at":"2015-05-04T13:30:46Z","pushed_at":"2015-08-31T04:43:42Z","git_url":"git://github.com/fatcerberus/duktape.git","ssh_url":"git@github.com:fatcerberus/duktape.git","clone_url":"https://github.com/fatcerberus/duktape.git","svn_url":"https://github.com/fatcerberus/duktape","homepage":null,"size":56790,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"svaarala:master","ref":"master","sha":"b21ffd32b396bab01c26c0d1f4456df015e76773","user":{"login":"svaarala","id":6377415,"avatar_url":"https://avatars.githubusercontent.com/u/6377415?v=3","gravatar_id":"","url":"https://api.github.com/users/svaarala","html_url":"https://github.com/svaarala","followers_url":"https://api.github.com/users/svaarala/followers","following_url":"https://api.github.com/users/svaarala/following{/other_user}","gists_url":"https://api.github.com/users/svaarala/gists{/gist_id}","starred_url":"https://api.github.com/users/svaarala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/svaarala/subscriptions","organizations_url":"https://api.github.com/users/svaarala/orgs","repos_url":"https://api.github.com/users/svaarala/repos","events_url":"https://api.github.com/users/svaarala/events{/privacy}","received_events_url":"https://api.github.com/users/svaarala/received_events","type":"User","site_admin":false},"repo":{"id":15852088,"name":"duktape","full_name":"svaarala/duktape","owner":{"login":"svaarala","id":6377415,"avatar_url":"https://avatars.githubusercontent.com/u/6377415?v=3","gravatar_id":"","url":"https://api.github.com/users/svaarala","html_url":"https://github.com/svaarala","followers_url":"https://api.github.com/users/svaarala/followers","following_url":"https://api.github.com/users/svaarala/following{/other_user}","gists_url":"https://api.github.com/users/svaarala/gists{/gist_id}","starred_url":"https://api.github.com/users/svaarala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/svaarala/subscriptions","organizations_url":"https://api.github.com/users/svaarala/orgs","repos_url":"https://api.github.com/users/svaarala/repos","events_url":"https://api.github.com/users/svaarala/events{/privacy}","received_events_url":"https://api.github.com/users/svaarala/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/svaarala/duktape","description":"Duktape - embeddable Javascript engine with a focus on portability and compact footprint","fork":false,"url":"https://api.github.com/repos/svaarala/duktape","forks_url":"https://api.github.com/repos/svaarala/duktape/forks","keys_url":"https://api.github.com/repos/svaarala/duktape/keys{/key_id}","collaborators_url":"https://api.github.com/repos/svaarala/duktape/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/svaarala/duktape/teams","hooks_url":"https://api.github.com/repos/svaarala/duktape/hooks","issue_events_url":"https://api.github.com/repos/svaarala/duktape/issues/events{/number}","events_url":"https://api.github.com/repos/svaarala/duktape/events","assignees_url":"https://api.github.com/repos/svaarala/duktape/assignees{/user}","branches_url":"https://api.github.com/repos/svaarala/duktape/branches{/branch}","tags_url":"https://api.github.com/repos/svaarala/duktape/tags","blobs_url":"https://api.github.com/repos/svaarala/duktape/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/svaarala/duktape/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/svaarala/duktape/git/refs{/sha}","trees_url":"https://api.github.com/repos/svaarala/duktape/git/trees{/sha}","statuses_url":"https://api.github.com/repos/svaarala/duktape/statuses/{sha}","languages_url":"https://api.github.com/repos/svaarala/duktape/languages","stargazers_url":"https://api.github.com/repos/svaarala/duktape/stargazers","contributors_url":"https://api.github.com/repos/svaarala/duktape/contributors","subscribers_url":"https://api.github.com/repos/svaarala/duktape/subscribers","subscription_url":"https://api.github.com/repos/svaarala/duktape/subscription","commits_url":"https://api.github.com/repos/svaarala/duktape/commits{/sha}","git_commits_url":"https://api.github.com/repos/svaarala/duktape/git/commits{/sha}","comments_url":"https://api.github.com/repos/svaarala/duktape/comments{/number}","issue_comment_url":"https://api.github.com/repos/svaarala/duktape/issues/comments{/number}","contents_url":"https://api.github.com/repos/svaarala/duktape/contents/{+path}","compare_url":"https://api.github.com/repos/svaarala/duktape/compare/{base}...{head}","merges_url":"https://api.github.com/repos/svaarala/duktape/merges","archive_url":"https://api.github.com/repos/svaarala/duktape/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/svaarala/duktape/downloads","issues_url":"https://api.github.com/repos/svaarala/duktape/issues{/number}","pulls_url":"https://api.github.com/repos/svaarala/duktape/pulls{/number}","milestones_url":"https://api.github.com/repos/svaarala/duktape/milestones{/number}","notifications_url":"https://api.github.com/repos/svaarala/duktape/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/svaarala/duktape/labels{/name}","releases_url":"https://api.github.com/repos/svaarala/duktape/releases{/id}","created_at":"2014-01-12T22:16:14Z","updated_at":"2015-08-30T13:09:03Z","pushed_at":"2015-08-31T13:30:22Z","git_url":"git://github.com/svaarala/duktape.git","ssh_url":"git@github.com:svaarala/duktape.git","clone_url":"https://github.com/svaarala/duktape.git","svn_url":"https://github.com/svaarala/duktape","homepage":null,"size":72154,"stargazers_count":1769,"watchers_count":1769,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":145,"mirror_url":null,"open_issues_count":115,"forks":145,"open_issues":115,"watchers":1769,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/svaarala/duktape/pulls/315"},"html":{"href":"https://github.com/svaarala/duktape/pull/315"},"issue":{"href":"https://api.github.com/repos/svaarala/duktape/issues/315"},"comments":{"href":"https://api.github.com/repos/svaarala/duktape/issues/315/comments"},"review_comments":{"href":"https://api.github.com/repos/svaarala/duktape/pulls/315/comments"},"review_comment":{"href":"https://api.github.com/repos/svaarala/duktape/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/svaarala/duktape/pulls/315/commits"},"statuses":{"href":"https://api.github.com/repos/svaarala/duktape/statuses/8e35cdb10c0032d2739bf4c42a280f745d627cad"}}}}