{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/34200930","id":34200930,"diff_hunk":"@@ -231,13 +231,19 @@ echo \"Test Environment:\"\n printenv | sort\n echo \"--------------------------------------------------------------------------------\"\n \n-if [[ \"${E2E_UP,,}\" == \"true\" ]]; then\n+# We get the kuberntes tarballs on either cluster creation or when we want to\n+# replace existing ones in a multi-step job (e.g. a cluster upgrade).\n+if [[ \"${E2E_UP,,}\" == \"true\" || \"${JENKINS_FORCE_GET_TARS:-}\" =~ ^[yY]$ ]]; then\n     if [[ ${KUBE_RUN_FROM_OUTPUT:-} =~ ^[yY]$ ]]; then\n         echo \"Found KUBE_RUN_FROM_OUTPUT=y; will use binaries from _output\"\n         cp _output/release-tars/kubernetes*.tar.gz .\n     else\n         echo \"Pulling binaries from GCS\"\n-        if [[ $(find . | wc -l) != 1 ]]; then\n+        # In a multi-step job, clean up just the kubernetes build files.\n+        # Otherwise, we want a completely empty directory.\n+        if [[ \"${JENKINS_FORCE_GET_TARS:-}\" =~ ^[yY]$ ]]; then\n+            rm -rf kubernetes*","path":"hack/jenkins/e2e.sh","position":17,"original_position":17,"commit_id":"7a0f3eb3ad4747bf97a99e7e0596d6acbe75ed6c","original_commit_id":"7a0f3eb3ad4747bf97a99e7e0596d6acbe75ed6c","user":{"login":"zmerlynn","id":4942464,"avatar_url":"https://avatars.githubusercontent.com/u/4942464?v=3","gravatar_id":"","url":"https://api.github.com/users/zmerlynn","html_url":"https://github.com/zmerlynn","followers_url":"https://api.github.com/users/zmerlynn/followers","following_url":"https://api.github.com/users/zmerlynn/following{/other_user}","gists_url":"https://api.github.com/users/zmerlynn/gists{/gist_id}","starred_url":"https://api.github.com/users/zmerlynn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zmerlynn/subscriptions","organizations_url":"https://api.github.com/users/zmerlynn/orgs","repos_url":"https://api.github.com/users/zmerlynn/repos","events_url":"https://api.github.com/users/zmerlynn/events{/privacy}","received_events_url":"https://api.github.com/users/zmerlynn/received_events","type":"User","site_admin":false},"body":"Oh, `.kube`. Details.\r\n","created_at":"2015-07-08T21:28:23Z","updated_at":"2015-07-08T21:28:23Z","html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/10940#discussion_r34200930","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/10940","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/34200930"},"html":{"href":"https://github.com/GoogleCloudPlatform/kubernetes/pull/10940#discussion_r34200930"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/10940"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/10940","id":39510064,"html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/10940","diff_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/10940.diff","patch_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/10940.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/10940","number":10940,"state":"open","locked":false,"title":"Jenkins: Allow fetching new tars for multi-job tests","user":{"login":"mbforbes","id":1170062,"avatar_url":"https://avatars.githubusercontent.com/u/1170062?v=3","gravatar_id":"","url":"https://api.github.com/users/mbforbes","html_url":"https://github.com/mbforbes","followers_url":"https://api.github.com/users/mbforbes/followers","following_url":"https://api.github.com/users/mbforbes/following{/other_user}","gists_url":"https://api.github.com/users/mbforbes/gists{/gist_id}","starred_url":"https://api.github.com/users/mbforbes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbforbes/subscriptions","organizations_url":"https://api.github.com/users/mbforbes/orgs","repos_url":"https://api.github.com/users/mbforbes/repos","events_url":"https://api.github.com/users/mbforbes/events{/privacy}","received_events_url":"https://api.github.com/users/mbforbes/received_events","type":"User","site_admin":false},"body":"This will allow us to do \"true\" upgrade testing by setting `JENKINS_FORCE_GET_TARS=y` in multi-step jobs where we want to retrieve a new binary.  This enables the following scenarios which currently cannot be exercised by Jenkins:\r\n\r\n#### Use \"new\" code to do a full upgrade and run e2es\r\n*This is how customers will likely do an upgrade. Also, it let's us correctly run e2es at the newer version, which fixes #10850 for our CI builds. Also, it let's us pin tests at release transitions, such as validating a 0.19.x&rarr;0.21.y upgrade.*\r\n\r\n0. Create cluster at version X (uses code at version X)\r\n0. Upgrade cluster (master + nodes) to version Y (uses code at version Y) **[this PR enables X&rarr;Y switch]**\r\n0. Run e2e tests at version Y (uses code at version Y)\r\n\r\n#### Use \"new\" code to upgrade master; use \"old\" code to run e2es\r\n*We can use this to ensure that upgrading only the master keeps the functionality at the old version of the cluster (as the nodes are still at the old version). This will mean we will still catch issues such as #10850, which was a true breaking behavioral change.*\r\n\r\n0. Create cluster at version X (uses code at version X)\r\n0. Upgrade *only the master* to version Y (uses code at version Y) **[this PR enables X&rarr;Y switch]**\r\n0. Run e2e tests at version X (uses code at version X) **[this PR enables Y&rarr;X switch]**","created_at":"2015-07-08T18:50:00Z","updated_at":"2015-07-08T21:28:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1efa8845694656efd6b258255e2e0336642d373f","assignee":{"login":"quinton-hoole","id":10390785,"avatar_url":"https://avatars.githubusercontent.com/u/10390785?v=3","gravatar_id":"","url":"https://api.github.com/users/quinton-hoole","html_url":"https://github.com/quinton-hoole","followers_url":"https://api.github.com/users/quinton-hoole/followers","following_url":"https://api.github.com/users/quinton-hoole/following{/other_user}","gists_url":"https://api.github.com/users/quinton-hoole/gists{/gist_id}","starred_url":"https://api.github.com/users/quinton-hoole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quinton-hoole/subscriptions","organizations_url":"https://api.github.com/users/quinton-hoole/orgs","repos_url":"https://api.github.com/users/quinton-hoole/repos","events_url":"https://api.github.com/users/quinton-hoole/events{/privacy}","received_events_url":"https://api.github.com/users/quinton-hoole/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/10940/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/10940/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/10940/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/7a0f3eb3ad4747bf97a99e7e0596d6acbe75ed6c","head":{"label":"mbforbes:jenkinsUpgradeVersion","ref":"jenkinsUpgradeVersion","sha":"7a0f3eb3ad4747bf97a99e7e0596d6acbe75ed6c","user":{"login":"mbforbes","id":1170062,"avatar_url":"https://avatars.githubusercontent.com/u/1170062?v=3","gravatar_id":"","url":"https://api.github.com/users/mbforbes","html_url":"https://github.com/mbforbes","followers_url":"https://api.github.com/users/mbforbes/followers","following_url":"https://api.github.com/users/mbforbes/following{/other_user}","gists_url":"https://api.github.com/users/mbforbes/gists{/gist_id}","starred_url":"https://api.github.com/users/mbforbes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbforbes/subscriptions","organizations_url":"https://api.github.com/users/mbforbes/orgs","repos_url":"https://api.github.com/users/mbforbes/repos","events_url":"https://api.github.com/users/mbforbes/events{/privacy}","received_events_url":"https://api.github.com/users/mbforbes/received_events","type":"User","site_admin":false},"repo":{"id":23891576,"name":"kubernetes","full_name":"mbforbes/kubernetes","owner":{"login":"mbforbes","id":1170062,"avatar_url":"https://avatars.githubusercontent.com/u/1170062?v=3","gravatar_id":"","url":"https://api.github.com/users/mbforbes","html_url":"https://github.com/mbforbes","followers_url":"https://api.github.com/users/mbforbes/followers","following_url":"https://api.github.com/users/mbforbes/following{/other_user}","gists_url":"https://api.github.com/users/mbforbes/gists{/gist_id}","starred_url":"https://api.github.com/users/mbforbes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbforbes/subscriptions","organizations_url":"https://api.github.com/users/mbforbes/orgs","repos_url":"https://api.github.com/users/mbforbes/repos","events_url":"https://api.github.com/users/mbforbes/events{/privacy}","received_events_url":"https://api.github.com/users/mbforbes/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mbforbes/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/mbforbes/kubernetes","forks_url":"https://api.github.com/repos/mbforbes/kubernetes/forks","keys_url":"https://api.github.com/repos/mbforbes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mbforbes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mbforbes/kubernetes/teams","hooks_url":"https://api.github.com/repos/mbforbes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/mbforbes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/mbforbes/kubernetes/events","assignees_url":"https://api.github.com/repos/mbforbes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/mbforbes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/mbforbes/kubernetes/tags","blobs_url":"https://api.github.com/repos/mbforbes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mbforbes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mbforbes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/mbforbes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mbforbes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/mbforbes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/mbforbes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/mbforbes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/mbforbes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/mbforbes/kubernetes/subscription","commits_url":"https://api.github.com/repos/mbforbes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/mbforbes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/mbforbes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/mbforbes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/mbforbes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/mbforbes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mbforbes/kubernetes/merges","archive_url":"https://api.github.com/repos/mbforbes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mbforbes/kubernetes/downloads","issues_url":"https://api.github.com/repos/mbforbes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/mbforbes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/mbforbes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/mbforbes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mbforbes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/mbforbes/kubernetes/releases{/id}","created_at":"2014-09-10T20:45:41Z","updated_at":"2015-04-24T19:28:40Z","pushed_at":"2015-07-08T21:09:08Z","git_url":"git://github.com/mbforbes/kubernetes.git","ssh_url":"git@github.com:mbforbes/kubernetes.git","clone_url":"https://github.com/mbforbes/kubernetes.git","svn_url":"https://github.com/mbforbes/kubernetes","homepage":null,"size":87251,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"fff24af86e563b682c627757651c0b2650d38718","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"GoogleCloudPlatform/kubernetes","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/releases{/id}","created_at":"2014-06-06T22:56:04Z","updated_at":"2015-07-08T21:19:25Z","pushed_at":"2015-07-08T21:16:56Z","git_url":"git://github.com/GoogleCloudPlatform/kubernetes.git","ssh_url":"git@github.com:GoogleCloudPlatform/kubernetes.git","clone_url":"https://github.com/GoogleCloudPlatform/kubernetes.git","svn_url":"https://github.com/GoogleCloudPlatform/kubernetes","homepage":"http://kubernetes.io","size":308765,"stargazers_count":8778,"watchers_count":8778,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1965,"mirror_url":null,"open_issues_count":1605,"forks":1965,"open_issues":1605,"watchers":8778,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/10940"},"html":{"href":"https://github.com/GoogleCloudPlatform/kubernetes/pull/10940"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/10940"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/10940/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/10940/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/10940/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/7a0f3eb3ad4747bf97a99e7e0596d6acbe75ed6c"}}}}