{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/35620870","id":35620870,"diff_hunk":"@@ -0,0 +1,114 @@\n+/*\n+ * Licensed to the Apache Software Foundation (ASF) under one or more\n+ * contributor license agreements.  See the NOTICE file distributed with\n+ * this work for additional information regarding copyright ownership.\n+ * The ASF licenses this file to You under the Apache License, Version 2.0\n+ * (the \"License\"); you may not use this file except in compliance with\n+ * the License.  You may obtain a copy of the License at\n+ *\n+ *    http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+package org.apache.spark.ml.feature\n+\n+import scala.util.parsing.combinator.RegexParsers\n+\n+import org.apache.spark.sql.types.StructType\n+\n+/**\n+ * Represents a parsed R formula.\n+ */\n+private[ml] case class ParsedRFormula(label: ColumnRef, terms: Seq[Term]) {\n+  def fit(schema: StructType): FittedRFormula = {\n+    var includedTerms = Seq[String]()\n+    terms.foreach {\n+      case Dot() =>\n+        includedTerms ++= schema.map(_.name).filter(_ != label.value)\n+      case ColumnRef(value) =>\n+        includedTerms :+= value\n+      case Deletion(term: Term) =>\n+        term match {\n+          case ColumnRef(value) =>\n+            includedTerms = includedTerms.filter(_ != value)\n+          case _: Dot =>","path":"mllib/src/main/scala/org/apache/spark/ml/feature/RFormulaParser.scala","position":39,"original_position":39,"commit_id":"a9350bb5bd6f0c916fa0676aafcc3b4fcc7af8f6","original_commit_id":"a9350bb5bd6f0c916fa0676aafcc3b4fcc7af8f6","user":{"login":"ericl","id":14922,"avatar_url":"https://avatars.githubusercontent.com/u/14922?v=3","gravatar_id":"","url":"https://api.github.com/users/ericl","html_url":"https://github.com/ericl","followers_url":"https://api.github.com/users/ericl/followers","following_url":"https://api.github.com/users/ericl/following{/other_user}","gists_url":"https://api.github.com/users/ericl/gists{/gist_id}","starred_url":"https://api.github.com/users/ericl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericl/subscriptions","organizations_url":"https://api.github.com/users/ericl/orgs","repos_url":"https://api.github.com/users/ericl/repos","events_url":"https://api.github.com/users/ericl/events{/privacy}","received_events_url":"https://api.github.com/users/ericl/received_events","type":"User","site_admin":false},"body":"Done","created_at":"2015-07-28T07:31:46Z","updated_at":"2015-07-28T07:31:46Z","html_url":"https://github.com/apache/spark/pull/7707#discussion_r35620870","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/7707","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/35620870"},"html":{"href":"https://github.com/apache/spark/pull/7707#discussion_r35620870"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/7707"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/7707","id":40964624,"html_url":"https://github.com/apache/spark/pull/7707","diff_url":"https://github.com/apache/spark/pull/7707.diff","patch_url":"https://github.com/apache/spark/pull/7707.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/7707","number":7707,"state":"open","locked":false,"title":"[SPARK-9391] [ML] Support minus, dot, and intercept operators in SparkR RFormula","user":{"login":"ericl","id":14922,"avatar_url":"https://avatars.githubusercontent.com/u/14922?v=3","gravatar_id":"","url":"https://api.github.com/users/ericl","html_url":"https://github.com/ericl","followers_url":"https://api.github.com/users/ericl/followers","following_url":"https://api.github.com/users/ericl/following{/other_user}","gists_url":"https://api.github.com/users/ericl/gists{/gist_id}","starred_url":"https://api.github.com/users/ericl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericl/subscriptions","organizations_url":"https://api.github.com/users/ericl/orgs","repos_url":"https://api.github.com/users/ericl/repos","events_url":"https://api.github.com/users/ericl/events{/privacy}","received_events_url":"https://api.github.com/users/ericl/received_events","type":"User","site_admin":false},"body":"Adds '.', '-', and intercept parsing to RFormula. Also splits RFormulaParser into a separate file.\r\n\r\nUmbrella design doc here: https://docs.google.com/document/d/10NZNSEurN2EdWM31uFYsgayIPfCFHiuIu3pCWrUmP_c/edit?usp=sharing\r\n\r\n@mengxr ","created_at":"2015-07-28T00:27:01Z","updated_at":"2015-07-28T07:31:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3821934530a74c8aade2b88fe4b5e66ee28776eb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/7707/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/7707/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/7707/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/8106ffe9ab66c0c0c8a0f587c0ec43e74df56b5b","head":{"label":"ericl:string-features-2","ref":"string-features-2","sha":"8106ffe9ab66c0c0c8a0f587c0ec43e74df56b5b","user":{"login":"ericl","id":14922,"avatar_url":"https://avatars.githubusercontent.com/u/14922?v=3","gravatar_id":"","url":"https://api.github.com/users/ericl","html_url":"https://github.com/ericl","followers_url":"https://api.github.com/users/ericl/followers","following_url":"https://api.github.com/users/ericl/following{/other_user}","gists_url":"https://api.github.com/users/ericl/gists{/gist_id}","starred_url":"https://api.github.com/users/ericl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericl/subscriptions","organizations_url":"https://api.github.com/users/ericl/orgs","repos_url":"https://api.github.com/users/ericl/repos","events_url":"https://api.github.com/users/ericl/events{/privacy}","received_events_url":"https://api.github.com/users/ericl/received_events","type":"User","site_admin":false},"repo":{"id":23644625,"name":"spark","full_name":"ericl/spark","owner":{"login":"ericl","id":14922,"avatar_url":"https://avatars.githubusercontent.com/u/14922?v=3","gravatar_id":"","url":"https://api.github.com/users/ericl","html_url":"https://github.com/ericl","followers_url":"https://api.github.com/users/ericl/followers","following_url":"https://api.github.com/users/ericl/following{/other_user}","gists_url":"https://api.github.com/users/ericl/gists{/gist_id}","starred_url":"https://api.github.com/users/ericl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericl/subscriptions","organizations_url":"https://api.github.com/users/ericl/orgs","repos_url":"https://api.github.com/users/ericl/repos","events_url":"https://api.github.com/users/ericl/events{/privacy}","received_events_url":"https://api.github.com/users/ericl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ericl/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/ericl/spark","forks_url":"https://api.github.com/repos/ericl/spark/forks","keys_url":"https://api.github.com/repos/ericl/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ericl/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ericl/spark/teams","hooks_url":"https://api.github.com/repos/ericl/spark/hooks","issue_events_url":"https://api.github.com/repos/ericl/spark/issues/events{/number}","events_url":"https://api.github.com/repos/ericl/spark/events","assignees_url":"https://api.github.com/repos/ericl/spark/assignees{/user}","branches_url":"https://api.github.com/repos/ericl/spark/branches{/branch}","tags_url":"https://api.github.com/repos/ericl/spark/tags","blobs_url":"https://api.github.com/repos/ericl/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ericl/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ericl/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/ericl/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ericl/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/ericl/spark/languages","stargazers_url":"https://api.github.com/repos/ericl/spark/stargazers","contributors_url":"https://api.github.com/repos/ericl/spark/contributors","subscribers_url":"https://api.github.com/repos/ericl/spark/subscribers","subscription_url":"https://api.github.com/repos/ericl/spark/subscription","commits_url":"https://api.github.com/repos/ericl/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/ericl/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/ericl/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/ericl/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/ericl/spark/contents/{+path}","compare_url":"https://api.github.com/repos/ericl/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ericl/spark/merges","archive_url":"https://api.github.com/repos/ericl/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ericl/spark/downloads","issues_url":"https://api.github.com/repos/ericl/spark/issues{/number}","pulls_url":"https://api.github.com/repos/ericl/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/ericl/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/ericl/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ericl/spark/labels{/name}","releases_url":"https://api.github.com/repos/ericl/spark/releases{/id}","created_at":"2014-09-04T01:48:06Z","updated_at":"2015-06-19T23:51:55Z","pushed_at":"2015-07-28T07:31:45Z","git_url":"git://github.com/ericl/spark.git","ssh_url":"git@github.com:ericl/spark.git","clone_url":"https://github.com/ericl/spark.git","svn_url":"https://github.com/ericl/spark","homepage":null,"size":109932,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"8ddfa52c208bf329c2b2c8909c6be04301e36083","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","created_at":"2014-02-25T08:00:08Z","updated_at":"2015-07-28T05:53:22Z","pushed_at":"2015-07-28T07:24:19Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":1605279,"stargazers_count":4876,"watchers_count":4876,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4405,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":353,"forks":4405,"open_issues":353,"watchers":4876,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/7707"},"html":{"href":"https://github.com/apache/spark/pull/7707"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/7707"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/7707/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/7707/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/7707/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/8106ffe9ab66c0c0c8a0f587c0ec43e74df56b5b"}}}}