{"action":"closed","number":85,"pull_request":{"url":"https://api.github.com/repos/KentorIT/authservices/pulls/85","id":16903829,"html_url":"https://github.com/KentorIT/authservices/pull/85","diff_url":"https://github.com/KentorIT/authservices/pull/85.diff","patch_url":"https://github.com/KentorIT/authservices/pull/85.patch","issue_url":"https://api.github.com/repos/KentorIT/authservices/issues/85","number":85,"state":"closed","locked":false,"title":"78 encrypted assertion","user":{"login":"gheeres","id":1309506,"avatar_url":"https://avatars.githubusercontent.com/u/1309506?v=3","gravatar_id":"","url":"https://api.github.com/users/gheeres","html_url":"https://github.com/gheeres","followers_url":"https://api.github.com/users/gheeres/followers","following_url":"https://api.github.com/users/gheeres/following{/other_user}","gists_url":"https://api.github.com/users/gheeres/gists{/gist_id}","starred_url":"https://api.github.com/users/gheeres/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gheeres/subscriptions","organizations_url":"https://api.github.com/users/gheeres/orgs","repos_url":"https://api.github.com/users/gheeres/repos","events_url":"https://api.github.com/users/gheeres/events{/privacy}","received_events_url":"https://api.github.com/users/gheeres/received_events","type":"User","site_admin":false},"body":"Implementation of issue #78.\r\n\r\nSummary\r\n-------------\r\n+ Refactored certification reading into helper class. \r\n+ Created custom exceptions for certificate handling. \r\n+ Created helper / static class to decrypt an EncryptedAssertion replacing the contents of the Saml2Response with the decrypted contents.\r\n\r\nQuestions\r\n-------------\r\nDue to the dependency on the Windows certificate store, I'm unsure how to proceed with writing unit tests without creating an unnecessary abstraction. The previous CertificateElement class didn't handle this code coverage either... are you OK with this?\r\n\r\nAlso unsure on how to proceed with testing of message decryption. If full testing is desired, then we need a test helper able to generate EncryptedAssertion messages. Does anything exist yet?","created_at":"2014-06-09T19:43:15Z","updated_at":"2015-10-19T19:50:35Z","closed_at":"2015-10-19T19:50:35Z","merged_at":null,"merge_commit_sha":"1768668c61e3ed1788a124cd70b27b8c644c5dcb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/KentorIT/authservices/pulls/85/commits","review_comments_url":"https://api.github.com/repos/KentorIT/authservices/pulls/85/comments","review_comment_url":"https://api.github.com/repos/KentorIT/authservices/pulls/comments{/number}","comments_url":"https://api.github.com/repos/KentorIT/authservices/issues/85/comments","statuses_url":"https://api.github.com/repos/KentorIT/authservices/statuses/de294bf343de83c3162bff7625da8a8c1f3c9a8d","head":{"label":"gheeres:78EncryptedAssertion","ref":"78EncryptedAssertion","sha":"de294bf343de83c3162bff7625da8a8c1f3c9a8d","user":{"login":"gheeres","id":1309506,"avatar_url":"https://avatars.githubusercontent.com/u/1309506?v=3","gravatar_id":"","url":"https://api.github.com/users/gheeres","html_url":"https://github.com/gheeres","followers_url":"https://api.github.com/users/gheeres/followers","following_url":"https://api.github.com/users/gheeres/following{/other_user}","gists_url":"https://api.github.com/users/gheeres/gists{/gist_id}","starred_url":"https://api.github.com/users/gheeres/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gheeres/subscriptions","organizations_url":"https://api.github.com/users/gheeres/orgs","repos_url":"https://api.github.com/users/gheeres/repos","events_url":"https://api.github.com/users/gheeres/events{/privacy}","received_events_url":"https://api.github.com/users/gheeres/received_events","type":"User","site_admin":false},"repo":{"id":20341071,"name":"authservices","full_name":"gheeres/authservices","owner":{"login":"gheeres","id":1309506,"avatar_url":"https://avatars.githubusercontent.com/u/1309506?v=3","gravatar_id":"","url":"https://api.github.com/users/gheeres","html_url":"https://github.com/gheeres","followers_url":"https://api.github.com/users/gheeres/followers","following_url":"https://api.github.com/users/gheeres/following{/other_user}","gists_url":"https://api.github.com/users/gheeres/gists{/gist_id}","starred_url":"https://api.github.com/users/gheeres/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gheeres/subscriptions","organizations_url":"https://api.github.com/users/gheeres/orgs","repos_url":"https://api.github.com/users/gheeres/repos","events_url":"https://api.github.com/users/gheeres/events{/privacy}","received_events_url":"https://api.github.com/users/gheeres/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gheeres/authservices","description":"Saml2 Authentication services for ASP.NET","fork":true,"url":"https://api.github.com/repos/gheeres/authservices","forks_url":"https://api.github.com/repos/gheeres/authservices/forks","keys_url":"https://api.github.com/repos/gheeres/authservices/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gheeres/authservices/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gheeres/authservices/teams","hooks_url":"https://api.github.com/repos/gheeres/authservices/hooks","issue_events_url":"https://api.github.com/repos/gheeres/authservices/issues/events{/number}","events_url":"https://api.github.com/repos/gheeres/authservices/events","assignees_url":"https://api.github.com/repos/gheeres/authservices/assignees{/user}","branches_url":"https://api.github.com/repos/gheeres/authservices/branches{/branch}","tags_url":"https://api.github.com/repos/gheeres/authservices/tags","blobs_url":"https://api.github.com/repos/gheeres/authservices/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gheeres/authservices/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gheeres/authservices/git/refs{/sha}","trees_url":"https://api.github.com/repos/gheeres/authservices/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gheeres/authservices/statuses/{sha}","languages_url":"https://api.github.com/repos/gheeres/authservices/languages","stargazers_url":"https://api.github.com/repos/gheeres/authservices/stargazers","contributors_url":"https://api.github.com/repos/gheeres/authservices/contributors","subscribers_url":"https://api.github.com/repos/gheeres/authservices/subscribers","subscription_url":"https://api.github.com/repos/gheeres/authservices/subscription","commits_url":"https://api.github.com/repos/gheeres/authservices/commits{/sha}","git_commits_url":"https://api.github.com/repos/gheeres/authservices/git/commits{/sha}","comments_url":"https://api.github.com/repos/gheeres/authservices/comments{/number}","issue_comment_url":"https://api.github.com/repos/gheeres/authservices/issues/comments{/number}","contents_url":"https://api.github.com/repos/gheeres/authservices/contents/{+path}","compare_url":"https://api.github.com/repos/gheeres/authservices/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gheeres/authservices/merges","archive_url":"https://api.github.com/repos/gheeres/authservices/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gheeres/authservices/downloads","issues_url":"https://api.github.com/repos/gheeres/authservices/issues{/number}","pulls_url":"https://api.github.com/repos/gheeres/authservices/pulls{/number}","milestones_url":"https://api.github.com/repos/gheeres/authservices/milestones{/number}","notifications_url":"https://api.github.com/repos/gheeres/authservices/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gheeres/authservices/labels{/name}","releases_url":"https://api.github.com/repos/gheeres/authservices/releases{/id}","created_at":"2014-05-30T20:08:20Z","updated_at":"2015-05-29T17:08:03Z","pushed_at":"2014-06-11T19:05:48Z","git_url":"git://github.com/gheeres/authservices.git","ssh_url":"git@github.com:gheeres/authservices.git","clone_url":"https://github.com/gheeres/authservices.git","svn_url":"https://github.com/gheeres/authservices","homepage":"","size":1112,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"KentorIT:master","ref":"master","sha":"e371d5937093ee898c71b2a44f4a9797a05a1783","user":{"login":"KentorIT","id":5381215,"avatar_url":"https://avatars.githubusercontent.com/u/5381215?v=3","gravatar_id":"","url":"https://api.github.com/users/KentorIT","html_url":"https://github.com/KentorIT","followers_url":"https://api.github.com/users/KentorIT/followers","following_url":"https://api.github.com/users/KentorIT/following{/other_user}","gists_url":"https://api.github.com/users/KentorIT/gists{/gist_id}","starred_url":"https://api.github.com/users/KentorIT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KentorIT/subscriptions","organizations_url":"https://api.github.com/users/KentorIT/orgs","repos_url":"https://api.github.com/users/KentorIT/repos","events_url":"https://api.github.com/users/KentorIT/events{/privacy}","received_events_url":"https://api.github.com/users/KentorIT/received_events","type":"Organization","site_admin":false},"repo":{"id":12864759,"name":"authservices","full_name":"KentorIT/authservices","owner":{"login":"KentorIT","id":5381215,"avatar_url":"https://avatars.githubusercontent.com/u/5381215?v=3","gravatar_id":"","url":"https://api.github.com/users/KentorIT","html_url":"https://github.com/KentorIT","followers_url":"https://api.github.com/users/KentorIT/followers","following_url":"https://api.github.com/users/KentorIT/following{/other_user}","gists_url":"https://api.github.com/users/KentorIT/gists{/gist_id}","starred_url":"https://api.github.com/users/KentorIT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KentorIT/subscriptions","organizations_url":"https://api.github.com/users/KentorIT/orgs","repos_url":"https://api.github.com/users/KentorIT/repos","events_url":"https://api.github.com/users/KentorIT/events{/privacy}","received_events_url":"https://api.github.com/users/KentorIT/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/KentorIT/authservices","description":"Saml2 Authentication services for ASP.NET","fork":false,"url":"https://api.github.com/repos/KentorIT/authservices","forks_url":"https://api.github.com/repos/KentorIT/authservices/forks","keys_url":"https://api.github.com/repos/KentorIT/authservices/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KentorIT/authservices/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KentorIT/authservices/teams","hooks_url":"https://api.github.com/repos/KentorIT/authservices/hooks","issue_events_url":"https://api.github.com/repos/KentorIT/authservices/issues/events{/number}","events_url":"https://api.github.com/repos/KentorIT/authservices/events","assignees_url":"https://api.github.com/repos/KentorIT/authservices/assignees{/user}","branches_url":"https://api.github.com/repos/KentorIT/authservices/branches{/branch}","tags_url":"https://api.github.com/repos/KentorIT/authservices/tags","blobs_url":"https://api.github.com/repos/KentorIT/authservices/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KentorIT/authservices/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KentorIT/authservices/git/refs{/sha}","trees_url":"https://api.github.com/repos/KentorIT/authservices/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KentorIT/authservices/statuses/{sha}","languages_url":"https://api.github.com/repos/KentorIT/authservices/languages","stargazers_url":"https://api.github.com/repos/KentorIT/authservices/stargazers","contributors_url":"https://api.github.com/repos/KentorIT/authservices/contributors","subscribers_url":"https://api.github.com/repos/KentorIT/authservices/subscribers","subscription_url":"https://api.github.com/repos/KentorIT/authservices/subscription","commits_url":"https://api.github.com/repos/KentorIT/authservices/commits{/sha}","git_commits_url":"https://api.github.com/repos/KentorIT/authservices/git/commits{/sha}","comments_url":"https://api.github.com/repos/KentorIT/authservices/comments{/number}","issue_comment_url":"https://api.github.com/repos/KentorIT/authservices/issues/comments{/number}","contents_url":"https://api.github.com/repos/KentorIT/authservices/contents/{+path}","compare_url":"https://api.github.com/repos/KentorIT/authservices/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KentorIT/authservices/merges","archive_url":"https://api.github.com/repos/KentorIT/authservices/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KentorIT/authservices/downloads","issues_url":"https://api.github.com/repos/KentorIT/authservices/issues{/number}","pulls_url":"https://api.github.com/repos/KentorIT/authservices/pulls{/number}","milestones_url":"https://api.github.com/repos/KentorIT/authservices/milestones{/number}","notifications_url":"https://api.github.com/repos/KentorIT/authservices/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KentorIT/authservices/labels{/name}","releases_url":"https://api.github.com/repos/KentorIT/authservices/releases{/id}","created_at":"2013-09-16T10:36:25Z","updated_at":"2015-10-19T03:30:49Z","pushed_at":"2015-10-19T19:49:52Z","git_url":"git://github.com/KentorIT/authservices.git","ssh_url":"git@github.com:KentorIT/authservices.git","clone_url":"https://github.com/KentorIT/authservices.git","svn_url":"https://github.com/KentorIT/authservices","homepage":"","size":4529,"stargazers_count":90,"watchers_count":90,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":88,"mirror_url":null,"open_issues_count":92,"forks":88,"open_issues":92,"watchers":90,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/KentorIT/authservices/pulls/85"},"html":{"href":"https://github.com/KentorIT/authservices/pull/85"},"issue":{"href":"https://api.github.com/repos/KentorIT/authservices/issues/85"},"comments":{"href":"https://api.github.com/repos/KentorIT/authservices/issues/85/comments"},"review_comments":{"href":"https://api.github.com/repos/KentorIT/authservices/pulls/85/comments"},"review_comment":{"href":"https://api.github.com/repos/KentorIT/authservices/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/KentorIT/authservices/pulls/85/commits"},"statuses":{"href":"https://api.github.com/repos/KentorIT/authservices/statuses/de294bf343de83c3162bff7625da8a8c1f3c9a8d"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":11,"review_comments":0,"commits":11,"additions":554,"deletions":20,"changed_files":9}}