{"action":"created","comment":{"url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/comments/24484433","id":24484433,"diff_hunk":"@@ -102,6 +102,27 @@ typedef Particles<ParticleDescription<\n \n /*--------------------------- ions -------------------------------------------*/\n \n+/*! Specify (chemical) element\n+ * \n+ * Proton and neutron numbers define the chemical element that the ion species\n+ * is based on. This value can be non-integer for physical models taking  \n+ * charge shielding effects into account. @see http://en.wikipedia.org/wiki/Effective_nuclear_charge\n+ * \n+ * It is wrapped into a struct because of C++ restricting floats from being \n+ * template arguments. \n+ * \n+ * Do not forget to set the correct mass of the atom in @see physicalConstants.param !\n+ */\n+struct NumberOfProtons\n+{\n+    static const float_X value = 2.0;\n+};\n+\n+struct NumberOfNeutrons","path":"examples/LaserWakefield/include/simulation_defines/param/speciesDefinition.param","position":20,"original_position":20,"commit_id":"d2cee8d5d184705d63962c62a32b30cef5d9e42a","original_commit_id":"d2cee8d5d184705d63962c62a32b30cef5d9e42a","user":{"login":"ax3l","id":1353258,"avatar_url":"https://avatars.githubusercontent.com/u/1353258?v=3","gravatar_id":"","url":"https://api.github.com/users/ax3l","html_url":"https://github.com/ax3l","followers_url":"https://api.github.com/users/ax3l/followers","following_url":"https://api.github.com/users/ax3l/following{/other_user}","gists_url":"https://api.github.com/users/ax3l/gists{/gist_id}","starred_url":"https://api.github.com/users/ax3l/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ax3l/subscriptions","organizations_url":"https://api.github.com/users/ax3l/orgs","repos_url":"https://api.github.com/users/ax3l/repos","events_url":"https://api.github.com/users/ax3l/events{/privacy}","received_events_url":"https://api.github.com/users/ax3l/received_events","type":"User","site_admin":false},"body":"just to clearify: \"coreElements\" is not an ideal name. we should just provide an environment to build what every type of particle/atom a user wants. the user should be able to call it however they like (e.g., they shall be able to create a neutron species, a tripple proton-no neutron atom and neutrinos).","created_at":"2015-02-11T10:13:15Z","updated_at":"2015-02-11T10:13:15Z","html_url":"https://github.com/ComputationalRadiationPhysics/picongpu/pull/687#discussion_r24484433","pull_request_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/687","_links":{"self":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/comments/24484433"},"html":{"href":"https://github.com/ComputationalRadiationPhysics/picongpu/pull/687#discussion_r24484433"},"pull_request":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/687"}}},"pull_request":{"url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/687","id":29006361,"html_url":"https://github.com/ComputationalRadiationPhysics/picongpu/pull/687","diff_url":"https://github.com/ComputationalRadiationPhysics/picongpu/pull/687.diff","patch_url":"https://github.com/ComputationalRadiationPhysics/picongpu/pull/687.patch","issue_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/issues/687","number":687,"state":"open","locked":false,"title":"Flag for proton and neutron number","user":{"login":"n01r","id":5416860,"avatar_url":"https://avatars.githubusercontent.com/u/5416860?v=3","gravatar_id":"","url":"https://api.github.com/users/n01r","html_url":"https://github.com/n01r","followers_url":"https://api.github.com/users/n01r/followers","following_url":"https://api.github.com/users/n01r/following{/other_user}","gists_url":"https://api.github.com/users/n01r/gists{/gist_id}","starred_url":"https://api.github.com/users/n01r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/n01r/subscriptions","organizations_url":"https://api.github.com/users/n01r/orgs","repos_url":"https://api.github.com/users/n01r/repos","events_url":"https://api.github.com/users/n01r/events{/privacy}","received_events_url":"https://api.github.com/users/n01r/received_events","type":"User","site_admin":false},"body":"Here is another topic concerning **multiple species** and **ionization**. \r\nThis PR adds a ***flag for proton and neutron number*** of the ion species.\r\n\r\nIn detail:\r\n- flags `protonNumber` and `neutronNumber`\r\n- traits `GetProtonNumber` and `GetNeutronNumber`   \r\n  (these contain a `static_assert` which is thrown if someone tries to get these numbers from, say, electrons)\r\n- ionization algorithm has been edited to ionize until `chargeState` = `protonNumber`\r\n- ionization is now always active if ions are enabled (deactivate by deleting the flags)\r\n\r\n### The last commit has not been runtime-tested due to the current maintenance\r\n(everything until *Make proton/neutronNumber a float* is safe)","created_at":"2015-02-10T13:24:36Z","updated_at":"2015-02-11T10:13:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e8e6b1a6982293a43e8d2a3eb94f59526f38c1c8","assignee":{"login":"ax3l","id":1353258,"avatar_url":"https://avatars.githubusercontent.com/u/1353258?v=3","gravatar_id":"","url":"https://api.github.com/users/ax3l","html_url":"https://github.com/ax3l","followers_url":"https://api.github.com/users/ax3l/followers","following_url":"https://api.github.com/users/ax3l/following{/other_user}","gists_url":"https://api.github.com/users/ax3l/gists{/gist_id}","starred_url":"https://api.github.com/users/ax3l/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ax3l/subscriptions","organizations_url":"https://api.github.com/users/ax3l/orgs","repos_url":"https://api.github.com/users/ax3l/repos","events_url":"https://api.github.com/users/ax3l/events{/privacy}","received_events_url":"https://api.github.com/users/ax3l/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/milestones/2","labels_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/milestones/2/labels","id":395839,"number":2,"title":"Open Beta","description":"Tasks to complete until the release of our open beta (version 0.1)\r\n\r\nThe [beta](https://en.wikipedia.org/wiki/Software_release_life_cycle#Beta) release shall be useful for *physicist* that used a Particle-in-Cell code *before*. Experience with *compiling libraries from source* and a *good Linux knowledge* is required for the initial installation.\r\n","creator":{"login":"ax3l","id":1353258,"avatar_url":"https://avatars.githubusercontent.com/u/1353258?v=3","gravatar_id":"","url":"https://api.github.com/users/ax3l","html_url":"https://github.com/ax3l","followers_url":"https://api.github.com/users/ax3l/followers","following_url":"https://api.github.com/users/ax3l/following{/other_user}","gists_url":"https://api.github.com/users/ax3l/gists{/gist_id}","starred_url":"https://api.github.com/users/ax3l/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ax3l/subscriptions","organizations_url":"https://api.github.com/users/ax3l/orgs","repos_url":"https://api.github.com/users/ax3l/repos","events_url":"https://api.github.com/users/ax3l/events{/privacy}","received_events_url":"https://api.github.com/users/ax3l/received_events","type":"User","site_admin":false},"open_issues":62,"closed_issues":555,"state":"open","created_at":"2013-08-06T16:38:57Z","updated_at":"2015-02-11T10:07:16Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/687/commits","review_comments_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/687/comments","review_comment_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/issues/687/comments","statuses_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/statuses/d2cee8d5d184705d63962c62a32b30cef5d9e42a","head":{"label":"n01r:topic-flagProtonNeutronNumber","ref":"topic-flagProtonNeutronNumber","sha":"d2cee8d5d184705d63962c62a32b30cef5d9e42a","user":{"login":"n01r","id":5416860,"avatar_url":"https://avatars.githubusercontent.com/u/5416860?v=3","gravatar_id":"","url":"https://api.github.com/users/n01r","html_url":"https://github.com/n01r","followers_url":"https://api.github.com/users/n01r/followers","following_url":"https://api.github.com/users/n01r/following{/other_user}","gists_url":"https://api.github.com/users/n01r/gists{/gist_id}","starred_url":"https://api.github.com/users/n01r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/n01r/subscriptions","organizations_url":"https://api.github.com/users/n01r/orgs","repos_url":"https://api.github.com/users/n01r/repos","events_url":"https://api.github.com/users/n01r/events{/privacy}","received_events_url":"https://api.github.com/users/n01r/received_events","type":"User","site_admin":false},"repo":{"id":12918493,"name":"picongpu","full_name":"n01r/picongpu","owner":{"login":"n01r","id":5416860,"avatar_url":"https://avatars.githubusercontent.com/u/5416860?v=3","gravatar_id":"","url":"https://api.github.com/users/n01r","html_url":"https://github.com/n01r","followers_url":"https://api.github.com/users/n01r/followers","following_url":"https://api.github.com/users/n01r/following{/other_user}","gists_url":"https://api.github.com/users/n01r/gists{/gist_id}","starred_url":"https://api.github.com/users/n01r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/n01r/subscriptions","organizations_url":"https://api.github.com/users/n01r/orgs","repos_url":"https://api.github.com/users/n01r/repos","events_url":"https://api.github.com/users/n01r/events{/privacy}","received_events_url":"https://api.github.com/users/n01r/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/n01r/picongpu","description":"PIConGPU - A particle-in-cell code for GPGPUs","fork":true,"url":"https://api.github.com/repos/n01r/picongpu","forks_url":"https://api.github.com/repos/n01r/picongpu/forks","keys_url":"https://api.github.com/repos/n01r/picongpu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/n01r/picongpu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/n01r/picongpu/teams","hooks_url":"https://api.github.com/repos/n01r/picongpu/hooks","issue_events_url":"https://api.github.com/repos/n01r/picongpu/issues/events{/number}","events_url":"https://api.github.com/repos/n01r/picongpu/events","assignees_url":"https://api.github.com/repos/n01r/picongpu/assignees{/user}","branches_url":"https://api.github.com/repos/n01r/picongpu/branches{/branch}","tags_url":"https://api.github.com/repos/n01r/picongpu/tags","blobs_url":"https://api.github.com/repos/n01r/picongpu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/n01r/picongpu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/n01r/picongpu/git/refs{/sha}","trees_url":"https://api.github.com/repos/n01r/picongpu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/n01r/picongpu/statuses/{sha}","languages_url":"https://api.github.com/repos/n01r/picongpu/languages","stargazers_url":"https://api.github.com/repos/n01r/picongpu/stargazers","contributors_url":"https://api.github.com/repos/n01r/picongpu/contributors","subscribers_url":"https://api.github.com/repos/n01r/picongpu/subscribers","subscription_url":"https://api.github.com/repos/n01r/picongpu/subscription","commits_url":"https://api.github.com/repos/n01r/picongpu/commits{/sha}","git_commits_url":"https://api.github.com/repos/n01r/picongpu/git/commits{/sha}","comments_url":"https://api.github.com/repos/n01r/picongpu/comments{/number}","issue_comment_url":"https://api.github.com/repos/n01r/picongpu/issues/comments/{number}","contents_url":"https://api.github.com/repos/n01r/picongpu/contents/{+path}","compare_url":"https://api.github.com/repos/n01r/picongpu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/n01r/picongpu/merges","archive_url":"https://api.github.com/repos/n01r/picongpu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/n01r/picongpu/downloads","issues_url":"https://api.github.com/repos/n01r/picongpu/issues{/number}","pulls_url":"https://api.github.com/repos/n01r/picongpu/pulls{/number}","milestones_url":"https://api.github.com/repos/n01r/picongpu/milestones{/number}","notifications_url":"https://api.github.com/repos/n01r/picongpu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/n01r/picongpu/labels{/name}","releases_url":"https://api.github.com/repos/n01r/picongpu/releases{/id}","created_at":"2013-09-18T08:57:42Z","updated_at":"2015-01-21T15:16:50Z","pushed_at":"2015-02-10T13:08:24Z","git_url":"git://github.com/n01r/picongpu.git","ssh_url":"git@github.com:n01r/picongpu.git","clone_url":"https://github.com/n01r/picongpu.git","svn_url":"https://github.com/n01r/picongpu","homepage":"http://picongpu.hzdr.de","size":7976,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":0,"default_branch":"dev"}},"base":{"label":"ComputationalRadiationPhysics:dev","ref":"dev","sha":"a7e0fcda6c7b68b6e275086574c0df7ea5fd38c4","user":{"login":"ComputationalRadiationPhysics","id":5120388,"avatar_url":"https://avatars.githubusercontent.com/u/5120388?v=3","gravatar_id":"","url":"https://api.github.com/users/ComputationalRadiationPhysics","html_url":"https://github.com/ComputationalRadiationPhysics","followers_url":"https://api.github.com/users/ComputationalRadiationPhysics/followers","following_url":"https://api.github.com/users/ComputationalRadiationPhysics/following{/other_user}","gists_url":"https://api.github.com/users/ComputationalRadiationPhysics/gists{/gist_id}","starred_url":"https://api.github.com/users/ComputationalRadiationPhysics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ComputationalRadiationPhysics/subscriptions","organizations_url":"https://api.github.com/users/ComputationalRadiationPhysics/orgs","repos_url":"https://api.github.com/users/ComputationalRadiationPhysics/repos","events_url":"https://api.github.com/users/ComputationalRadiationPhysics/events{/privacy}","received_events_url":"https://api.github.com/users/ComputationalRadiationPhysics/received_events","type":"Organization","site_admin":false},"repo":{"id":11764461,"name":"picongpu","full_name":"ComputationalRadiationPhysics/picongpu","owner":{"login":"ComputationalRadiationPhysics","id":5120388,"avatar_url":"https://avatars.githubusercontent.com/u/5120388?v=3","gravatar_id":"","url":"https://api.github.com/users/ComputationalRadiationPhysics","html_url":"https://github.com/ComputationalRadiationPhysics","followers_url":"https://api.github.com/users/ComputationalRadiationPhysics/followers","following_url":"https://api.github.com/users/ComputationalRadiationPhysics/following{/other_user}","gists_url":"https://api.github.com/users/ComputationalRadiationPhysics/gists{/gist_id}","starred_url":"https://api.github.com/users/ComputationalRadiationPhysics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ComputationalRadiationPhysics/subscriptions","organizations_url":"https://api.github.com/users/ComputationalRadiationPhysics/orgs","repos_url":"https://api.github.com/users/ComputationalRadiationPhysics/repos","events_url":"https://api.github.com/users/ComputationalRadiationPhysics/events{/privacy}","received_events_url":"https://api.github.com/users/ComputationalRadiationPhysics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ComputationalRadiationPhysics/picongpu","description":"PIConGPU - A particle-in-cell code for GPGPUs","fork":false,"url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu","forks_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/forks","keys_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/teams","hooks_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/hooks","issue_events_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/issues/events{/number}","events_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/events","assignees_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/assignees{/user}","branches_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/branches{/branch}","tags_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/tags","blobs_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/git/refs{/sha}","trees_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/statuses/{sha}","languages_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/languages","stargazers_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/stargazers","contributors_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/contributors","subscribers_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/subscribers","subscription_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/subscription","commits_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/commits{/sha}","git_commits_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/git/commits{/sha}","comments_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/comments{/number}","issue_comment_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/issues/comments/{number}","contents_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/contents/{+path}","compare_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/merges","archive_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/downloads","issues_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/issues{/number}","pulls_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls{/number}","milestones_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/milestones{/number}","notifications_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/labels{/name}","releases_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/releases{/id}","created_at":"2013-07-30T12:28:20Z","updated_at":"2015-02-09T18:07:02Z","pushed_at":"2015-02-09T22:47:00Z","git_url":"git://github.com/ComputationalRadiationPhysics/picongpu.git","ssh_url":"git@github.com:ComputationalRadiationPhysics/picongpu.git","clone_url":"https://github.com/ComputationalRadiationPhysics/picongpu.git","svn_url":"https://github.com/ComputationalRadiationPhysics/picongpu","homepage":"http://picongpu.hzdr.de","size":13823,"stargazers_count":86,"watchers_count":86,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":47,"mirror_url":null,"open_issues_count":104,"forks":47,"open_issues":104,"watchers":86,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/687"},"html":{"href":"https://github.com/ComputationalRadiationPhysics/picongpu/pull/687"},"issue":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/issues/687"},"comments":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/issues/687/comments"},"review_comments":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/687/comments"},"review_comment":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/687/commits"},"statuses":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/statuses/d2cee8d5d184705d63962c62a32b30cef5d9e42a"}}}}