{"action":"created","comment":{"url":"https://api.github.com/repos/ilayaperumalg/spring-xd/pulls/comments/23271995","id":23271995,"diff_hunk":"@@ -230,7 +231,9 @@ protected ContainerMatcher instantiateContainerMatcher(ModuleDescriptor moduleDe\n \t\t\t\t? getContainersForJobModule(moduleDescriptor)\n \t\t\t\t: getContainersForStreamModule(moduleDescriptor);\n \n-\t\treturn new RedeploymentContainerMatcher(containerMatcher, containers);\n+\t\tCollection<ContainerFilter> filters = this.containerMatcher.getContainerFilters();\n+\t\treturn new ContainerMatcher(ObjectUtils.addObjectToArray(\n+\t\t\t\tfilters.toArray(new ContainerFilter[filters.size()]), new RedeploymentContainerFilter(containers)));","path":"spring-xd-dirt/src/main/java/org/springframework/xd/dirt/server/ModuleRedeployer.java","position":38,"original_position":38,"commit_id":"423ce7beb0a14900eace2b14d7c8a2d6fc258673","original_commit_id":"423ce7beb0a14900eace2b14d7c8a2d6fc258673","user":{"login":"ilayaperumalg","id":151690,"avatar_url":"https://avatars.githubusercontent.com/u/151690?v=3","gravatar_id":"","url":"https://api.github.com/users/ilayaperumalg","html_url":"https://github.com/ilayaperumalg","followers_url":"https://api.github.com/users/ilayaperumalg/followers","following_url":"https://api.github.com/users/ilayaperumalg/following{/other_user}","gists_url":"https://api.github.com/users/ilayaperumalg/gists{/gist_id}","starred_url":"https://api.github.com/users/ilayaperumalg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilayaperumalg/subscriptions","organizations_url":"https://api.github.com/users/ilayaperumalg/orgs","repos_url":"https://api.github.com/users/ilayaperumalg/repos","events_url":"https://api.github.com/users/ilayaperumalg/events{/privacy}","received_events_url":"https://api.github.com/users/ilayaperumalg/received_events","type":"User","site_admin":false},"body":"may be ordering of filters could help in some cases?","created_at":"2015-01-21T01:20:35Z","updated_at":"2015-01-21T01:20:35Z","html_url":"https://github.com/ilayaperumalg/spring-xd/pull/7#discussion_r23271995","pull_request_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/pulls/7","_links":{"self":{"href":"https://api.github.com/repos/ilayaperumalg/spring-xd/pulls/comments/23271995"},"html":{"href":"https://github.com/ilayaperumalg/spring-xd/pull/7#discussion_r23271995"},"pull_request":{"href":"https://api.github.com/repos/ilayaperumalg/spring-xd/pulls/7"}}},"pull_request":{"url":"https://api.github.com/repos/ilayaperumalg/spring-xd/pulls/7","id":27722049,"html_url":"https://github.com/ilayaperumalg/spring-xd/pull/7","diff_url":"https://github.com/ilayaperumalg/spring-xd/pull/7.diff","patch_url":"https://github.com/ilayaperumalg/spring-xd/pull/7.patch","issue_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/issues/7","number":7,"state":"open","locked":false,"title":"ContainerMatcher and ContainerFilter refactoring","user":{"login":"markfisher","id":140784,"avatar_url":"https://avatars.githubusercontent.com/u/140784?v=3","gravatar_id":"","url":"https://api.github.com/users/markfisher","html_url":"https://github.com/markfisher","followers_url":"https://api.github.com/users/markfisher/followers","following_url":"https://api.github.com/users/markfisher/following{/other_user}","gists_url":"https://api.github.com/users/markfisher/gists{/gist_id}","starred_url":"https://api.github.com/users/markfisher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markfisher/subscriptions","organizations_url":"https://api.github.com/users/markfisher/orgs","repos_url":"https://api.github.com/users/markfisher/repos","events_url":"https://api.github.com/users/markfisher/events{/privacy}","received_events_url":"https://api.github.com/users/markfisher/received_events","type":"User","site_admin":false},"body":"- removed ContainerMatcher interface\r\n- renamed DefaultContainerMatcher to ContainerMatcher\r\n- ContainerMatcher is non-public\r\n- ContainerFilter is the new public interface\r\n- ContainerMatcher delegates to ContainerFilters\r\n- RedeploymentContainerMatcher is now RedeploymentContainerFilter\r\n- SparkStreamingContainerFilter is included by default in admin-server.xml","created_at":"2015-01-20T23:19:07Z","updated_at":"2015-01-21T01:20:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8fd7b29f664f523b47c7c2c24b747e362d00a6f3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/pulls/7/commits","review_comments_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/pulls/7/comments","review_comment_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/issues/7/comments","statuses_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/statuses/423ce7beb0a14900eace2b14d7c8a2d6fc258673","head":{"label":"markfisher:container-filter-updates","ref":"container-filter-updates","sha":"423ce7beb0a14900eace2b14d7c8a2d6fc258673","user":{"login":"markfisher","id":140784,"avatar_url":"https://avatars.githubusercontent.com/u/140784?v=3","gravatar_id":"","url":"https://api.github.com/users/markfisher","html_url":"https://github.com/markfisher","followers_url":"https://api.github.com/users/markfisher/followers","following_url":"https://api.github.com/users/markfisher/following{/other_user}","gists_url":"https://api.github.com/users/markfisher/gists{/gist_id}","starred_url":"https://api.github.com/users/markfisher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markfisher/subscriptions","organizations_url":"https://api.github.com/users/markfisher/orgs","repos_url":"https://api.github.com/users/markfisher/repos","events_url":"https://api.github.com/users/markfisher/events{/privacy}","received_events_url":"https://api.github.com/users/markfisher/received_events","type":"User","site_admin":false},"repo":{"id":9450896,"name":"spring-xd","full_name":"markfisher/spring-xd","owner":{"login":"markfisher","id":140784,"avatar_url":"https://avatars.githubusercontent.com/u/140784?v=3","gravatar_id":"","url":"https://api.github.com/users/markfisher","html_url":"https://github.com/markfisher","followers_url":"https://api.github.com/users/markfisher/followers","following_url":"https://api.github.com/users/markfisher/following{/other_user}","gists_url":"https://api.github.com/users/markfisher/gists{/gist_id}","starred_url":"https://api.github.com/users/markfisher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markfisher/subscriptions","organizations_url":"https://api.github.com/users/markfisher/orgs","repos_url":"https://api.github.com/users/markfisher/repos","events_url":"https://api.github.com/users/markfisher/events{/privacy}","received_events_url":"https://api.github.com/users/markfisher/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/markfisher/spring-xd","description":"Spring XD makes it easy to solve common big data problems such as data ingestion and export, real-time analytics, and batch workflow orchestration","fork":true,"url":"https://api.github.com/repos/markfisher/spring-xd","forks_url":"https://api.github.com/repos/markfisher/spring-xd/forks","keys_url":"https://api.github.com/repos/markfisher/spring-xd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/markfisher/spring-xd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/markfisher/spring-xd/teams","hooks_url":"https://api.github.com/repos/markfisher/spring-xd/hooks","issue_events_url":"https://api.github.com/repos/markfisher/spring-xd/issues/events{/number}","events_url":"https://api.github.com/repos/markfisher/spring-xd/events","assignees_url":"https://api.github.com/repos/markfisher/spring-xd/assignees{/user}","branches_url":"https://api.github.com/repos/markfisher/spring-xd/branches{/branch}","tags_url":"https://api.github.com/repos/markfisher/spring-xd/tags","blobs_url":"https://api.github.com/repos/markfisher/spring-xd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/markfisher/spring-xd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/markfisher/spring-xd/git/refs{/sha}","trees_url":"https://api.github.com/repos/markfisher/spring-xd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/markfisher/spring-xd/statuses/{sha}","languages_url":"https://api.github.com/repos/markfisher/spring-xd/languages","stargazers_url":"https://api.github.com/repos/markfisher/spring-xd/stargazers","contributors_url":"https://api.github.com/repos/markfisher/spring-xd/contributors","subscribers_url":"https://api.github.com/repos/markfisher/spring-xd/subscribers","subscription_url":"https://api.github.com/repos/markfisher/spring-xd/subscription","commits_url":"https://api.github.com/repos/markfisher/spring-xd/commits{/sha}","git_commits_url":"https://api.github.com/repos/markfisher/spring-xd/git/commits{/sha}","comments_url":"https://api.github.com/repos/markfisher/spring-xd/comments{/number}","issue_comment_url":"https://api.github.com/repos/markfisher/spring-xd/issues/comments/{number}","contents_url":"https://api.github.com/repos/markfisher/spring-xd/contents/{+path}","compare_url":"https://api.github.com/repos/markfisher/spring-xd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/markfisher/spring-xd/merges","archive_url":"https://api.github.com/repos/markfisher/spring-xd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/markfisher/spring-xd/downloads","issues_url":"https://api.github.com/repos/markfisher/spring-xd/issues{/number}","pulls_url":"https://api.github.com/repos/markfisher/spring-xd/pulls{/number}","milestones_url":"https://api.github.com/repos/markfisher/spring-xd/milestones{/number}","notifications_url":"https://api.github.com/repos/markfisher/spring-xd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/markfisher/spring-xd/labels{/name}","releases_url":"https://api.github.com/repos/markfisher/spring-xd/releases{/id}","created_at":"2013-04-15T14:42:48Z","updated_at":"2015-01-20T20:06:09Z","pushed_at":"2015-01-20T23:18:26Z","git_url":"git://github.com/markfisher/spring-xd.git","ssh_url":"git@github.com:markfisher/spring-xd.git","clone_url":"https://github.com/markfisher/spring-xd.git","svn_url":"https://github.com/markfisher/spring-xd","homepage":null,"size":21816,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"ilayaperumalg:spark-streaming","ref":"spark-streaming","sha":"30338fbc9211c361d14ea74f38dc039817310366","user":{"login":"ilayaperumalg","id":151690,"avatar_url":"https://avatars.githubusercontent.com/u/151690?v=3","gravatar_id":"","url":"https://api.github.com/users/ilayaperumalg","html_url":"https://github.com/ilayaperumalg","followers_url":"https://api.github.com/users/ilayaperumalg/followers","following_url":"https://api.github.com/users/ilayaperumalg/following{/other_user}","gists_url":"https://api.github.com/users/ilayaperumalg/gists{/gist_id}","starred_url":"https://api.github.com/users/ilayaperumalg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilayaperumalg/subscriptions","organizations_url":"https://api.github.com/users/ilayaperumalg/orgs","repos_url":"https://api.github.com/users/ilayaperumalg/repos","events_url":"https://api.github.com/users/ilayaperumalg/events{/privacy}","received_events_url":"https://api.github.com/users/ilayaperumalg/received_events","type":"User","site_admin":false},"repo":{"id":9632331,"name":"spring-xd","full_name":"ilayaperumalg/spring-xd","owner":{"login":"ilayaperumalg","id":151690,"avatar_url":"https://avatars.githubusercontent.com/u/151690?v=3","gravatar_id":"","url":"https://api.github.com/users/ilayaperumalg","html_url":"https://github.com/ilayaperumalg","followers_url":"https://api.github.com/users/ilayaperumalg/followers","following_url":"https://api.github.com/users/ilayaperumalg/following{/other_user}","gists_url":"https://api.github.com/users/ilayaperumalg/gists{/gist_id}","starred_url":"https://api.github.com/users/ilayaperumalg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilayaperumalg/subscriptions","organizations_url":"https://api.github.com/users/ilayaperumalg/orgs","repos_url":"https://api.github.com/users/ilayaperumalg/repos","events_url":"https://api.github.com/users/ilayaperumalg/events{/privacy}","received_events_url":"https://api.github.com/users/ilayaperumalg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ilayaperumalg/spring-xd","description":"Spring XD makes it easy to solve common big data problems such as data ingestion and export, real-time analytics, and batch workflow orchestration","fork":true,"url":"https://api.github.com/repos/ilayaperumalg/spring-xd","forks_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/forks","keys_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/teams","hooks_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/hooks","issue_events_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/issues/events{/number}","events_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/events","assignees_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/assignees{/user}","branches_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/branches{/branch}","tags_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/tags","blobs_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/git/refs{/sha}","trees_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/statuses/{sha}","languages_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/languages","stargazers_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/stargazers","contributors_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/contributors","subscribers_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/subscribers","subscription_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/subscription","commits_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/commits{/sha}","git_commits_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/git/commits{/sha}","comments_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/comments{/number}","issue_comment_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/issues/comments/{number}","contents_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/contents/{+path}","compare_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/merges","archive_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/downloads","issues_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/issues{/number}","pulls_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/pulls{/number}","milestones_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/milestones{/number}","notifications_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/labels{/name}","releases_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/releases{/id}","created_at":"2013-04-23T20:13:28Z","updated_at":"2014-11-17T20:36:21Z","pushed_at":"2015-01-20T20:21:28Z","git_url":"git://github.com/ilayaperumalg/spring-xd.git","ssh_url":"git@github.com:ilayaperumalg/spring-xd.git","clone_url":"https://github.com/ilayaperumalg/spring-xd.git","svn_url":"https://github.com/ilayaperumalg/spring-xd","homepage":null,"size":20624,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ilayaperumalg/spring-xd/pulls/7"},"html":{"href":"https://github.com/ilayaperumalg/spring-xd/pull/7"},"issue":{"href":"https://api.github.com/repos/ilayaperumalg/spring-xd/issues/7"},"comments":{"href":"https://api.github.com/repos/ilayaperumalg/spring-xd/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/ilayaperumalg/spring-xd/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/ilayaperumalg/spring-xd/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ilayaperumalg/spring-xd/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/ilayaperumalg/spring-xd/statuses/423ce7beb0a14900eace2b14d7c8a2d6fc258673"}}}}