{"action":"created","issue":{"url":"https://api.github.com/repos/OpenMW/openmw/issues/643","labels_url":"https://api.github.com/repos/OpenMW/openmw/issues/643/labels{/name}","comments_url":"https://api.github.com/repos/OpenMW/openmw/issues/643/comments","events_url":"https://api.github.com/repos/OpenMW/openmw/issues/643/events","html_url":"https://github.com/OpenMW/openmw/pull/643","id":92379084,"number":643,"title":"Fix build error and a pair of warnings","user":{"login":"ace13","id":534460,"avatar_url":"https://avatars.githubusercontent.com/u/534460?v=3","gravatar_id":"","url":"https://api.github.com/users/ace13","html_url":"https://github.com/ace13","followers_url":"https://api.github.com/users/ace13/followers","following_url":"https://api.github.com/users/ace13/following{/other_user}","gists_url":"https://api.github.com/users/ace13/gists{/gist_id}","starred_url":"https://api.github.com/users/ace13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ace13/subscriptions","organizations_url":"https://api.github.com/users/ace13/orgs","repos_url":"https://api.github.com/users/ace13/repos","events_url":"https://api.github.com/users/ace13/events{/privacy}","received_events_url":"https://api.github.com/users/ace13/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-07-01T13:08:31Z","updated_at":"2015-07-01T16:14:25Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/OpenMW/openmw/pulls/643","html_url":"https://github.com/OpenMW/openmw/pull/643","diff_url":"https://github.com/OpenMW/openmw/pull/643.diff","patch_url":"https://github.com/OpenMW/openmw/pull/643.patch"},"body":"The error was about casting between osg::Callback* and osg::NodeCallback*\r\nThe warnings are both about virtual classes with non-virtual destructors"},"comment":{"url":"https://api.github.com/repos/OpenMW/openmw/issues/comments/117733620","html_url":"https://github.com/OpenMW/openmw/pull/643#issuecomment-117733620","issue_url":"https://api.github.com/repos/OpenMW/openmw/issues/643","id":117733620,"user":{"login":"ace13","id":534460,"avatar_url":"https://avatars.githubusercontent.com/u/534460?v=3","gravatar_id":"","url":"https://api.github.com/users/ace13","html_url":"https://github.com/ace13","followers_url":"https://api.github.com/users/ace13/followers","following_url":"https://api.github.com/users/ace13/following{/other_user}","gists_url":"https://api.github.com/users/ace13/gists{/gist_id}","starred_url":"https://api.github.com/users/ace13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ace13/subscriptions","organizations_url":"https://api.github.com/users/ace13/orgs","repos_url":"https://api.github.com/users/ace13/repos","events_url":"https://api.github.com/users/ace13/events{/privacy}","received_events_url":"https://api.github.com/users/ace13/received_events","type":"User","site_admin":false},"created_at":"2015-07-01T16:14:25Z","updated_at":"2015-07-01T16:14:25Z","body":"Both of those classes contain member variables with non-trivial destructors; `boost::shared_ptr<float>` for AnimationTime and `std::string` for WeaponAnimationTime.\r\nSo if any of them gets subclassed then those two variables will not be destroyed properly, unless there's a virtual destructor.\r\n\r\nAdding a virtual destructor to SceneUtil::ControllerSource would be a good idea, but it wouldn't solve the warning."}}