{"action":"created","comment":{"url":"https://api.github.com/repos/ReactiveMongo/Play-ReactiveMongo/pulls/comments/32158938","id":32158938,"diff_hunk":"@@ -37,8 +37,8 @@ object BSONFormats {\n \n   implicit object BSONDoubleFormat extends PartialFormat[BSONDouble] {\n     val partialReads: PartialFunction[JsValue, JsResult[BSONDouble]] = {\n-      case JsNumber(f)                               => JsSuccess(BSONDouble(f.toDouble))\n-      case JsObject((\"$double\", JsNumber(v)) +: Nil) => JsSuccess(BSONDouble(v.toDouble))\n+      case JsNumber(f)                             => JsSuccess(BSONDouble(f.toDouble))\n+      case JsObject(Seq((\"$double\", JsNumber(v)))) => JsSuccess(BSONDouble(v.toDouble))","path":"src/main/scala/play/modules/reactivemongo/json.scala","position":7,"original_position":7,"commit_id":"b1fce2d71d3b6b9360c27c56b9fe779a4a9f8876","original_commit_id":"b1fce2d71d3b6b9360c27c56b9fe779a4a9f8876","user":{"login":"kailuowang","id":83257,"avatar_url":"https://avatars.githubusercontent.com/u/83257?v=3","gravatar_id":"","url":"https://api.github.com/users/kailuowang","html_url":"https://github.com/kailuowang","followers_url":"https://api.github.com/users/kailuowang/followers","following_url":"https://api.github.com/users/kailuowang/following{/other_user}","gists_url":"https://api.github.com/users/kailuowang/gists{/gist_id}","starred_url":"https://api.github.com/users/kailuowang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kailuowang/subscriptions","organizations_url":"https://api.github.com/users/kailuowang/orgs","repos_url":"https://api.github.com/users/kailuowang/repos","events_url":"https://api.github.com/users/kailuowang/events{/privacy}","received_events_url":"https://api.github.com/users/kailuowang/received_events","type":"User","site_admin":false},"body":"In our envirionment (play 2.4), JsObject(Seq(XX, XXX)) failed to patten match, so everything with JsObject goes to the default BSONDocument format","created_at":"2015-06-10T19:53:47Z","updated_at":"2015-06-10T19:53:47Z","html_url":"https://github.com/ReactiveMongo/Play-ReactiveMongo/pull/126#discussion_r32158938","pull_request_url":"https://api.github.com/repos/ReactiveMongo/Play-ReactiveMongo/pulls/126","_links":{"self":{"href":"https://api.github.com/repos/ReactiveMongo/Play-ReactiveMongo/pulls/comments/32158938"},"html":{"href":"https://github.com/ReactiveMongo/Play-ReactiveMongo/pull/126#discussion_r32158938"},"pull_request":{"href":"https://api.github.com/repos/ReactiveMongo/Play-ReactiveMongo/pulls/126"}}},"pull_request":{"url":"https://api.github.com/repos/ReactiveMongo/Play-ReactiveMongo/pulls/126","id":36093723,"html_url":"https://github.com/ReactiveMongo/Play-ReactiveMongo/pull/126","diff_url":"https://github.com/ReactiveMongo/Play-ReactiveMongo/pull/126.diff","patch_url":"https://github.com/ReactiveMongo/Play-ReactiveMongo/pull/126.patch","issue_url":"https://api.github.com/repos/ReactiveMongo/Play-ReactiveMongo/issues/126","number":126,"state":"open","locked":false,"title":"Play24 compatibility","user":{"login":"RavisMsk","id":1174785,"avatar_url":"https://avatars.githubusercontent.com/u/1174785?v=3","gravatar_id":"","url":"https://api.github.com/users/RavisMsk","html_url":"https://github.com/RavisMsk","followers_url":"https://api.github.com/users/RavisMsk/followers","following_url":"https://api.github.com/users/RavisMsk/following{/other_user}","gists_url":"https://api.github.com/users/RavisMsk/gists{/gist_id}","starred_url":"https://api.github.com/users/RavisMsk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RavisMsk/subscriptions","organizations_url":"https://api.github.com/users/RavisMsk/orgs","repos_url":"https://api.github.com/users/RavisMsk/repos","events_url":"https://api.github.com/users/RavisMsk/events{/privacy}","received_events_url":"https://api.github.com/users/RavisMsk/received_events","type":"User","site_admin":false},"body":"A fast Play 2.4.0-RC5 compatibility variant.\r\n\r\nWhat was accomplished:\r\n1) I couldn't `publish-local` current `0.11.0-SNAPSHOT`. The problem was in new classes, that were added in ReactiveMongo with `0.11.0-SNAPSHOT`. Some SerializationPacks etc. So, I decided to downgrade ReactiveMongo to `0.10.5.0-akka23`. I couldn't re-factor JSONCollection and other classes, because I just couldn't understand how (not enough comments etc.).\r\n2) Upgraded Play to 2.4.0-RC5;\r\n3) Due to changes in plays JSON API, I've fixed all the incompatibilities. At least, I think all of them.\r\nIn my project this fork works pretty well with Play 2.4.0-RC5. I wouldn't say that it's 100% stable, because I didn't test all the aspects. That's just a fast work-around, that allows to work with Play24.","created_at":"2015-05-23T21:08:10Z","updated_at":"2015-06-10T19:53:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"abd38edaf3ae6c3a64a784a3fb5cdade5e426922","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ReactiveMongo/Play-ReactiveMongo/pulls/126/commits","review_comments_url":"https://api.github.com/repos/ReactiveMongo/Play-ReactiveMongo/pulls/126/comments","review_comment_url":"https://api.github.com/repos/ReactiveMongo/Play-ReactiveMongo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ReactiveMongo/Play-ReactiveMongo/issues/126/comments","statuses_url":"https://api.github.com/repos/ReactiveMongo/Play-ReactiveMongo/statuses/b1fce2d71d3b6b9360c27c56b9fe779a4a9f8876","head":{"label":"RavisMsk:play24-compatibility","ref":"play24-compatibility","sha":"b1fce2d71d3b6b9360c27c56b9fe779a4a9f8876","user":{"login":"RavisMsk","id":1174785,"avatar_url":"https://avatars.githubusercontent.com/u/1174785?v=3","gravatar_id":"","url":"https://api.github.com/users/RavisMsk","html_url":"https://github.com/RavisMsk","followers_url":"https://api.github.com/users/RavisMsk/followers","following_url":"https://api.github.com/users/RavisMsk/following{/other_user}","gists_url":"https://api.github.com/users/RavisMsk/gists{/gist_id}","starred_url":"https://api.github.com/users/RavisMsk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RavisMsk/subscriptions","organizations_url":"https://api.github.com/users/RavisMsk/orgs","repos_url":"https://api.github.com/users/RavisMsk/repos","events_url":"https://api.github.com/users/RavisMsk/events{/privacy}","received_events_url":"https://api.github.com/users/RavisMsk/received_events","type":"User","site_admin":false},"repo":{"id":36064891,"name":"Play-ReactiveMongo","full_name":"RavisMsk/Play-ReactiveMongo","owner":{"login":"RavisMsk","id":1174785,"avatar_url":"https://avatars.githubusercontent.com/u/1174785?v=3","gravatar_id":"","url":"https://api.github.com/users/RavisMsk","html_url":"https://github.com/RavisMsk","followers_url":"https://api.github.com/users/RavisMsk/followers","following_url":"https://api.github.com/users/RavisMsk/following{/other_user}","gists_url":"https://api.github.com/users/RavisMsk/gists{/gist_id}","starred_url":"https://api.github.com/users/RavisMsk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RavisMsk/subscriptions","organizations_url":"https://api.github.com/users/RavisMsk/orgs","repos_url":"https://api.github.com/users/RavisMsk/repos","events_url":"https://api.github.com/users/RavisMsk/events{/privacy}","received_events_url":"https://api.github.com/users/RavisMsk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/RavisMsk/Play-ReactiveMongo","description":"ReactiveMongo plugin for Playframework","fork":true,"url":"https://api.github.com/repos/RavisMsk/Play-ReactiveMongo","forks_url":"https://api.github.com/repos/RavisMsk/Play-ReactiveMongo/forks","keys_url":"https://api.github.com/repos/RavisMsk/Play-ReactiveMongo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RavisMsk/Play-ReactiveMongo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RavisMsk/Play-ReactiveMongo/teams","hooks_url":"https://api.github.com/repos/RavisMsk/Play-ReactiveMongo/hooks","issue_events_url":"https://api.github.com/repos/RavisMsk/Play-ReactiveMongo/issues/events{/number}","events_url":"https://api.github.com/repos/RavisMsk/Play-ReactiveMongo/events","assignees_url":"https://api.github.com/repos/RavisMsk/Play-ReactiveMongo/assignees{/user}","branches_url":"https://api.github.com/repos/RavisMsk/Play-ReactiveMongo/branches{/branch}","tags_url":"https://api.github.com/repos/RavisMsk/Play-ReactiveMongo/tags","blobs_url":"https://api.github.com/repos/RavisMsk/Play-ReactiveMongo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RavisMsk/Play-ReactiveMongo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RavisMsk/Play-ReactiveMongo/git/refs{/sha}","trees_url":"https://api.github.com/repos/RavisMsk/Play-ReactiveMongo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RavisMsk/Play-ReactiveMongo/statuses/{sha}","languages_url":"https://api.github.com/repos/RavisMsk/Play-ReactiveMongo/languages","stargazers_url":"https://api.github.com/repos/RavisMsk/Play-ReactiveMongo/stargazers","contributors_url":"https://api.github.com/repos/RavisMsk/Play-ReactiveMongo/contributors","subscribers_url":"https://api.github.com/repos/RavisMsk/Play-ReactiveMongo/subscribers","subscription_url":"https://api.github.com/repos/RavisMsk/Play-ReactiveMongo/subscription","commits_url":"https://api.github.com/repos/RavisMsk/Play-ReactiveMongo/commits{/sha}","git_commits_url":"https://api.github.com/repos/RavisMsk/Play-ReactiveMongo/git/commits{/sha}","comments_url":"https://api.github.com/repos/RavisMsk/Play-ReactiveMongo/comments{/number}","issue_comment_url":"https://api.github.com/repos/RavisMsk/Play-ReactiveMongo/issues/comments{/number}","contents_url":"https://api.github.com/repos/RavisMsk/Play-ReactiveMongo/contents/{+path}","compare_url":"https://api.github.com/repos/RavisMsk/Play-ReactiveMongo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RavisMsk/Play-ReactiveMongo/merges","archive_url":"https://api.github.com/repos/RavisMsk/Play-ReactiveMongo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RavisMsk/Play-ReactiveMongo/downloads","issues_url":"https://api.github.com/repos/RavisMsk/Play-ReactiveMongo/issues{/number}","pulls_url":"https://api.github.com/repos/RavisMsk/Play-ReactiveMongo/pulls{/number}","milestones_url":"https://api.github.com/repos/RavisMsk/Play-ReactiveMongo/milestones{/number}","notifications_url":"https://api.github.com/repos/RavisMsk/Play-ReactiveMongo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RavisMsk/Play-ReactiveMongo/labels{/name}","releases_url":"https://api.github.com/repos/RavisMsk/Play-ReactiveMongo/releases{/id}","created_at":"2015-05-22T09:48:15Z","updated_at":"2015-05-31T14:54:07Z","pushed_at":"2015-05-23T08:48:04Z","git_url":"git://github.com/RavisMsk/Play-ReactiveMongo.git","ssh_url":"git@github.com:RavisMsk/Play-ReactiveMongo.git","clone_url":"https://github.com/RavisMsk/Play-ReactiveMongo.git","svn_url":"https://github.com/RavisMsk/Play-ReactiveMongo","homepage":null,"size":502,"stargazers_count":1,"watchers_count":1,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"ReactiveMongo:master","ref":"master","sha":"aa5b53ebeb494b2c7bb0c0f88fd6b8c2bf7fdf33","user":{"login":"ReactiveMongo","id":5060260,"avatar_url":"https://avatars.githubusercontent.com/u/5060260?v=3","gravatar_id":"","url":"https://api.github.com/users/ReactiveMongo","html_url":"https://github.com/ReactiveMongo","followers_url":"https://api.github.com/users/ReactiveMongo/followers","following_url":"https://api.github.com/users/ReactiveMongo/following{/other_user}","gists_url":"https://api.github.com/users/ReactiveMongo/gists{/gist_id}","starred_url":"https://api.github.com/users/ReactiveMongo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReactiveMongo/subscriptions","organizations_url":"https://api.github.com/users/ReactiveMongo/orgs","repos_url":"https://api.github.com/users/ReactiveMongo/repos","events_url":"https://api.github.com/users/ReactiveMongo/events{/privacy}","received_events_url":"https://api.github.com/users/ReactiveMongo/received_events","type":"Organization","site_admin":false},"repo":{"id":5613055,"name":"Play-ReactiveMongo","full_name":"ReactiveMongo/Play-ReactiveMongo","owner":{"login":"ReactiveMongo","id":5060260,"avatar_url":"https://avatars.githubusercontent.com/u/5060260?v=3","gravatar_id":"","url":"https://api.github.com/users/ReactiveMongo","html_url":"https://github.com/ReactiveMongo","followers_url":"https://api.github.com/users/ReactiveMongo/followers","following_url":"https://api.github.com/users/ReactiveMongo/following{/other_user}","gists_url":"https://api.github.com/users/ReactiveMongo/gists{/gist_id}","starred_url":"https://api.github.com/users/ReactiveMongo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReactiveMongo/subscriptions","organizations_url":"https://api.github.com/users/ReactiveMongo/orgs","repos_url":"https://api.github.com/users/ReactiveMongo/repos","events_url":"https://api.github.com/users/ReactiveMongo/events{/privacy}","received_events_url":"https://api.github.com/users/ReactiveMongo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ReactiveMongo/Play-ReactiveMongo","description":"ReactiveMongo plugin for Playframework","fork":false,"url":"https://api.github.com/repos/ReactiveMongo/Play-ReactiveMongo","forks_url":"https://api.github.com/repos/ReactiveMongo/Play-ReactiveMongo/forks","keys_url":"https://api.github.com/repos/ReactiveMongo/Play-ReactiveMongo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ReactiveMongo/Play-ReactiveMongo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ReactiveMongo/Play-ReactiveMongo/teams","hooks_url":"https://api.github.com/repos/ReactiveMongo/Play-ReactiveMongo/hooks","issue_events_url":"https://api.github.com/repos/ReactiveMongo/Play-ReactiveMongo/issues/events{/number}","events_url":"https://api.github.com/repos/ReactiveMongo/Play-ReactiveMongo/events","assignees_url":"https://api.github.com/repos/ReactiveMongo/Play-ReactiveMongo/assignees{/user}","branches_url":"https://api.github.com/repos/ReactiveMongo/Play-ReactiveMongo/branches{/branch}","tags_url":"https://api.github.com/repos/ReactiveMongo/Play-ReactiveMongo/tags","blobs_url":"https://api.github.com/repos/ReactiveMongo/Play-ReactiveMongo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ReactiveMongo/Play-ReactiveMongo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ReactiveMongo/Play-ReactiveMongo/git/refs{/sha}","trees_url":"https://api.github.com/repos/ReactiveMongo/Play-ReactiveMongo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ReactiveMongo/Play-ReactiveMongo/statuses/{sha}","languages_url":"https://api.github.com/repos/ReactiveMongo/Play-ReactiveMongo/languages","stargazers_url":"https://api.github.com/repos/ReactiveMongo/Play-ReactiveMongo/stargazers","contributors_url":"https://api.github.com/repos/ReactiveMongo/Play-ReactiveMongo/contributors","subscribers_url":"https://api.github.com/repos/ReactiveMongo/Play-ReactiveMongo/subscribers","subscription_url":"https://api.github.com/repos/ReactiveMongo/Play-ReactiveMongo/subscription","commits_url":"https://api.github.com/repos/ReactiveMongo/Play-ReactiveMongo/commits{/sha}","git_commits_url":"https://api.github.com/repos/ReactiveMongo/Play-ReactiveMongo/git/commits{/sha}","comments_url":"https://api.github.com/repos/ReactiveMongo/Play-ReactiveMongo/comments{/number}","issue_comment_url":"https://api.github.com/repos/ReactiveMongo/Play-ReactiveMongo/issues/comments{/number}","contents_url":"https://api.github.com/repos/ReactiveMongo/Play-ReactiveMongo/contents/{+path}","compare_url":"https://api.github.com/repos/ReactiveMongo/Play-ReactiveMongo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ReactiveMongo/Play-ReactiveMongo/merges","archive_url":"https://api.github.com/repos/ReactiveMongo/Play-ReactiveMongo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ReactiveMongo/Play-ReactiveMongo/downloads","issues_url":"https://api.github.com/repos/ReactiveMongo/Play-ReactiveMongo/issues{/number}","pulls_url":"https://api.github.com/repos/ReactiveMongo/Play-ReactiveMongo/pulls{/number}","milestones_url":"https://api.github.com/repos/ReactiveMongo/Play-ReactiveMongo/milestones{/number}","notifications_url":"https://api.github.com/repos/ReactiveMongo/Play-ReactiveMongo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ReactiveMongo/Play-ReactiveMongo/labels{/name}","releases_url":"https://api.github.com/repos/ReactiveMongo/Play-ReactiveMongo/releases{/id}","created_at":"2012-08-30T09:39:11Z","updated_at":"2015-06-05T04:51:52Z","pushed_at":"2015-06-10T09:27:27Z","git_url":"git://github.com/ReactiveMongo/Play-ReactiveMongo.git","ssh_url":"git@github.com:ReactiveMongo/Play-ReactiveMongo.git","clone_url":"https://github.com/ReactiveMongo/Play-ReactiveMongo.git","svn_url":"https://github.com/ReactiveMongo/Play-ReactiveMongo","homepage":null,"size":1177,"stargazers_count":328,"watchers_count":328,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":110,"mirror_url":null,"open_issues_count":34,"forks":110,"open_issues":34,"watchers":328,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ReactiveMongo/Play-ReactiveMongo/pulls/126"},"html":{"href":"https://github.com/ReactiveMongo/Play-ReactiveMongo/pull/126"},"issue":{"href":"https://api.github.com/repos/ReactiveMongo/Play-ReactiveMongo/issues/126"},"comments":{"href":"https://api.github.com/repos/ReactiveMongo/Play-ReactiveMongo/issues/126/comments"},"review_comments":{"href":"https://api.github.com/repos/ReactiveMongo/Play-ReactiveMongo/pulls/126/comments"},"review_comment":{"href":"https://api.github.com/repos/ReactiveMongo/Play-ReactiveMongo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ReactiveMongo/Play-ReactiveMongo/pulls/126/commits"},"statuses":{"href":"https://api.github.com/repos/ReactiveMongo/Play-ReactiveMongo/statuses/b1fce2d71d3b6b9360c27c56b9fe779a4a9f8876"}}}}