{"action":"created","comment":{"url":"https://api.github.com/repos/ufz/ogs/pulls/comments/28405208","id":28405208,"diff_hunk":"@@ -74,12 +74,13 @@ int CsvInterface::readPoints(std::string const& fname, char delim,\n \n \tstd::string line;\n \tgetline(in, line);\n-\tstd::array<std::size_t, 3> const column_idx = \n-\t\t{ CsvInterface::findColumn(line, delim, x_column_name),\n-\t\t  CsvInterface::findColumn(line, delim, y_column_name),\n-\t\t  (z_column_name.empty()) ? CsvInterface::findColumn(line, delim, y_column_name) : \n-\t\t                            CsvInterface::findColumn(line, delim, z_column_name) };\n-\t\n+\tstd::array<std::size_t, 3> const column_idx =\n+\t\t{{ CsvInterface::findColumn(line, delim, x_column_name),\n+\t\t\tCsvInterface::findColumn(line, delim, y_column_name),","path":"FileIO/CsvInterface.cpp","position":30,"original_position":30,"commit_id":"7c2571ba4edbbe8e8cc6504535b0af6214d1d18b","original_commit_id":"7c2571ba4edbbe8e8cc6504535b0af6214d1d18b","user":{"login":"TomFischer","id":800065,"avatar_url":"https://avatars.githubusercontent.com/u/800065?v=3","gravatar_id":"","url":"https://api.github.com/users/TomFischer","html_url":"https://github.com/TomFischer","followers_url":"https://api.github.com/users/TomFischer/followers","following_url":"https://api.github.com/users/TomFischer/following{/other_user}","gists_url":"https://api.github.com/users/TomFischer/gists{/gist_id}","starred_url":"https://api.github.com/users/TomFischer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomFischer/subscriptions","organizations_url":"https://api.github.com/users/TomFischer/orgs","repos_url":"https://api.github.com/users/TomFischer/repos","events_url":"https://api.github.com/users/TomFischer/events{/privacy}","received_events_url":"https://api.github.com/users/TomFischer/received_events","type":"User","site_admin":false},"body":"A discussion with Lars hopefully enlighted me. There is a difference between indentation and alignment. Imho indentation only is better than indentation + alignment. But here the opinions are different. I will revert changes above.","created_at":"2015-04-15T09:28:50Z","updated_at":"2015-04-15T09:28:50Z","html_url":"https://github.com/ufz/ogs/pull/637#discussion_r28405208","pull_request_url":"https://api.github.com/repos/ufz/ogs/pulls/637","_links":{"self":{"href":"https://api.github.com/repos/ufz/ogs/pulls/comments/28405208"},"html":{"href":"https://github.com/ufz/ogs/pull/637#discussion_r28405208"},"pull_request":{"href":"https://api.github.com/repos/ufz/ogs/pulls/637"}}},"pull_request":{"url":"https://api.github.com/repos/ufz/ogs/pulls/637","id":33156859,"html_url":"https://github.com/ufz/ogs/pull/637","diff_url":"https://github.com/ufz/ogs/pull/637.diff","patch_url":"https://github.com/ufz/ogs/pull/637.patch","issue_url":"https://api.github.com/repos/ufz/ogs/issues/637","number":637,"state":"open","locked":false,"title":"Csv interface issues","user":{"login":"TomFischer","id":800065,"avatar_url":"https://avatars.githubusercontent.com/u/800065?v=3","gravatar_id":"","url":"https://api.github.com/users/TomFischer","html_url":"https://github.com/TomFischer","followers_url":"https://api.github.com/users/TomFischer/followers","following_url":"https://api.github.com/users/TomFischer/following{/other_user}","gists_url":"https://api.github.com/users/TomFischer/gists{/gist_id}","starred_url":"https://api.github.com/users/TomFischer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomFischer/subscriptions","organizations_url":"https://api.github.com/users/TomFischer/orgs","repos_url":"https://api.github.com/users/TomFischer/repos","events_url":"https://api.github.com/users/TomFischer/events{/privacy}","received_events_url":"https://api.github.com/users/TomFischer/received_events","type":"User","site_admin":false},"body":"The locale at my environment was set to a comma instead of a period to separate the integer part from the non-integer part (for instance 1,2 instead of 1.2). Since some of the CsvInterface methods use locale dependend functions to read floating point numbers some of the CsvInterfaceTests failed. For this reason, I suggest to set the locale at start of the testrunner to the following: `setlocale(LC_NUMERIC,\"C\");`\r\n\r\nAdditional, there is one commit removing some warning in clang and one commit that remove some unnecessary whitespaces.","created_at":"2015-04-13T11:55:45Z","updated_at":"2015-04-15T09:28:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d9a3ab6d2133521693e2127867423e37f2f08cbf","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ufz/ogs/pulls/637/commits","review_comments_url":"https://api.github.com/repos/ufz/ogs/pulls/637/comments","review_comment_url":"https://api.github.com/repos/ufz/ogs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ufz/ogs/issues/637/comments","statuses_url":"https://api.github.com/repos/ufz/ogs/statuses/7c2571ba4edbbe8e8cc6504535b0af6214d1d18b","head":{"label":"TomFischer:CsvInterfaceIssues","ref":"CsvInterfaceIssues","sha":"7c2571ba4edbbe8e8cc6504535b0af6214d1d18b","user":{"login":"TomFischer","id":800065,"avatar_url":"https://avatars.githubusercontent.com/u/800065?v=3","gravatar_id":"","url":"https://api.github.com/users/TomFischer","html_url":"https://github.com/TomFischer","followers_url":"https://api.github.com/users/TomFischer/followers","following_url":"https://api.github.com/users/TomFischer/following{/other_user}","gists_url":"https://api.github.com/users/TomFischer/gists{/gist_id}","starred_url":"https://api.github.com/users/TomFischer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomFischer/subscriptions","organizations_url":"https://api.github.com/users/TomFischer/orgs","repos_url":"https://api.github.com/users/TomFischer/repos","events_url":"https://api.github.com/users/TomFischer/events{/privacy}","received_events_url":"https://api.github.com/users/TomFischer/received_events","type":"User","site_admin":false},"repo":{"id":6882427,"name":"ogs","full_name":"TomFischer/ogs","owner":{"login":"TomFischer","id":800065,"avatar_url":"https://avatars.githubusercontent.com/u/800065?v=3","gravatar_id":"","url":"https://api.github.com/users/TomFischer","html_url":"https://github.com/TomFischer","followers_url":"https://api.github.com/users/TomFischer/followers","following_url":"https://api.github.com/users/TomFischer/following{/other_user}","gists_url":"https://api.github.com/users/TomFischer/gists{/gist_id}","starred_url":"https://api.github.com/users/TomFischer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomFischer/subscriptions","organizations_url":"https://api.github.com/users/TomFischer/orgs","repos_url":"https://api.github.com/users/TomFischer/repos","events_url":"https://api.github.com/users/TomFischer/events{/privacy}","received_events_url":"https://api.github.com/users/TomFischer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TomFischer/ogs","description":"OGS source code","fork":true,"url":"https://api.github.com/repos/TomFischer/ogs","forks_url":"https://api.github.com/repos/TomFischer/ogs/forks","keys_url":"https://api.github.com/repos/TomFischer/ogs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TomFischer/ogs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TomFischer/ogs/teams","hooks_url":"https://api.github.com/repos/TomFischer/ogs/hooks","issue_events_url":"https://api.github.com/repos/TomFischer/ogs/issues/events{/number}","events_url":"https://api.github.com/repos/TomFischer/ogs/events","assignees_url":"https://api.github.com/repos/TomFischer/ogs/assignees{/user}","branches_url":"https://api.github.com/repos/TomFischer/ogs/branches{/branch}","tags_url":"https://api.github.com/repos/TomFischer/ogs/tags","blobs_url":"https://api.github.com/repos/TomFischer/ogs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TomFischer/ogs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TomFischer/ogs/git/refs{/sha}","trees_url":"https://api.github.com/repos/TomFischer/ogs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TomFischer/ogs/statuses/{sha}","languages_url":"https://api.github.com/repos/TomFischer/ogs/languages","stargazers_url":"https://api.github.com/repos/TomFischer/ogs/stargazers","contributors_url":"https://api.github.com/repos/TomFischer/ogs/contributors","subscribers_url":"https://api.github.com/repos/TomFischer/ogs/subscribers","subscription_url":"https://api.github.com/repos/TomFischer/ogs/subscription","commits_url":"https://api.github.com/repos/TomFischer/ogs/commits{/sha}","git_commits_url":"https://api.github.com/repos/TomFischer/ogs/git/commits{/sha}","comments_url":"https://api.github.com/repos/TomFischer/ogs/comments{/number}","issue_comment_url":"https://api.github.com/repos/TomFischer/ogs/issues/comments{/number}","contents_url":"https://api.github.com/repos/TomFischer/ogs/contents/{+path}","compare_url":"https://api.github.com/repos/TomFischer/ogs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TomFischer/ogs/merges","archive_url":"https://api.github.com/repos/TomFischer/ogs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TomFischer/ogs/downloads","issues_url":"https://api.github.com/repos/TomFischer/ogs/issues{/number}","pulls_url":"https://api.github.com/repos/TomFischer/ogs/pulls{/number}","milestones_url":"https://api.github.com/repos/TomFischer/ogs/milestones{/number}","notifications_url":"https://api.github.com/repos/TomFischer/ogs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TomFischer/ogs/labels{/name}","releases_url":"https://api.github.com/repos/TomFischer/ogs/releases{/id}","created_at":"2012-11-27T11:49:36Z","updated_at":"2015-04-13T03:53:19Z","pushed_at":"2015-04-15T08:54:46Z","git_url":"git://github.com/TomFischer/ogs.git","ssh_url":"git@github.com:TomFischer/ogs.git","clone_url":"https://github.com/TomFischer/ogs.git","svn_url":"https://github.com/TomFischer/ogs","homepage":"www.opengeosys.org","size":11927,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ufz:master","ref":"master","sha":"03b969c665aab16f24575a50669a5db455e2334f","user":{"login":"ufz","id":767517,"avatar_url":"https://avatars.githubusercontent.com/u/767517?v=3","gravatar_id":"","url":"https://api.github.com/users/ufz","html_url":"https://github.com/ufz","followers_url":"https://api.github.com/users/ufz/followers","following_url":"https://api.github.com/users/ufz/following{/other_user}","gists_url":"https://api.github.com/users/ufz/gists{/gist_id}","starred_url":"https://api.github.com/users/ufz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ufz/subscriptions","organizations_url":"https://api.github.com/users/ufz/orgs","repos_url":"https://api.github.com/users/ufz/repos","events_url":"https://api.github.com/users/ufz/events{/privacy}","received_events_url":"https://api.github.com/users/ufz/received_events","type":"Organization","site_admin":false},"repo":{"id":1701384,"name":"ogs","full_name":"ufz/ogs","owner":{"login":"ufz","id":767517,"avatar_url":"https://avatars.githubusercontent.com/u/767517?v=3","gravatar_id":"","url":"https://api.github.com/users/ufz","html_url":"https://github.com/ufz","followers_url":"https://api.github.com/users/ufz/followers","following_url":"https://api.github.com/users/ufz/following{/other_user}","gists_url":"https://api.github.com/users/ufz/gists{/gist_id}","starred_url":"https://api.github.com/users/ufz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ufz/subscriptions","organizations_url":"https://api.github.com/users/ufz/orgs","repos_url":"https://api.github.com/users/ufz/repos","events_url":"https://api.github.com/users/ufz/events{/privacy}","received_events_url":"https://api.github.com/users/ufz/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ufz/ogs","description":"OGS source code","fork":false,"url":"https://api.github.com/repos/ufz/ogs","forks_url":"https://api.github.com/repos/ufz/ogs/forks","keys_url":"https://api.github.com/repos/ufz/ogs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ufz/ogs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ufz/ogs/teams","hooks_url":"https://api.github.com/repos/ufz/ogs/hooks","issue_events_url":"https://api.github.com/repos/ufz/ogs/issues/events{/number}","events_url":"https://api.github.com/repos/ufz/ogs/events","assignees_url":"https://api.github.com/repos/ufz/ogs/assignees{/user}","branches_url":"https://api.github.com/repos/ufz/ogs/branches{/branch}","tags_url":"https://api.github.com/repos/ufz/ogs/tags","blobs_url":"https://api.github.com/repos/ufz/ogs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ufz/ogs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ufz/ogs/git/refs{/sha}","trees_url":"https://api.github.com/repos/ufz/ogs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ufz/ogs/statuses/{sha}","languages_url":"https://api.github.com/repos/ufz/ogs/languages","stargazers_url":"https://api.github.com/repos/ufz/ogs/stargazers","contributors_url":"https://api.github.com/repos/ufz/ogs/contributors","subscribers_url":"https://api.github.com/repos/ufz/ogs/subscribers","subscription_url":"https://api.github.com/repos/ufz/ogs/subscription","commits_url":"https://api.github.com/repos/ufz/ogs/commits{/sha}","git_commits_url":"https://api.github.com/repos/ufz/ogs/git/commits{/sha}","comments_url":"https://api.github.com/repos/ufz/ogs/comments{/number}","issue_comment_url":"https://api.github.com/repos/ufz/ogs/issues/comments{/number}","contents_url":"https://api.github.com/repos/ufz/ogs/contents/{+path}","compare_url":"https://api.github.com/repos/ufz/ogs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ufz/ogs/merges","archive_url":"https://api.github.com/repos/ufz/ogs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ufz/ogs/downloads","issues_url":"https://api.github.com/repos/ufz/ogs/issues{/number}","pulls_url":"https://api.github.com/repos/ufz/ogs/pulls{/number}","milestones_url":"https://api.github.com/repos/ufz/ogs/milestones{/number}","notifications_url":"https://api.github.com/repos/ufz/ogs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ufz/ogs/labels{/name}","releases_url":"https://api.github.com/repos/ufz/ogs/releases{/id}","created_at":"2011-05-04T14:09:57Z","updated_at":"2015-04-09T14:20:43Z","pushed_at":"2015-04-15T09:04:20Z","git_url":"git://github.com/ufz/ogs.git","ssh_url":"git@github.com:ufz/ogs.git","clone_url":"https://github.com/ufz/ogs.git","svn_url":"https://github.com/ufz/ogs","homepage":"www.opengeosys.org","size":15085,"stargazers_count":15,"watchers_count":15,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"open_issues_count":47,"forks":33,"open_issues":47,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ufz/ogs/pulls/637"},"html":{"href":"https://github.com/ufz/ogs/pull/637"},"issue":{"href":"https://api.github.com/repos/ufz/ogs/issues/637"},"comments":{"href":"https://api.github.com/repos/ufz/ogs/issues/637/comments"},"review_comments":{"href":"https://api.github.com/repos/ufz/ogs/pulls/637/comments"},"review_comment":{"href":"https://api.github.com/repos/ufz/ogs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ufz/ogs/pulls/637/commits"},"statuses":{"href":"https://api.github.com/repos/ufz/ogs/statuses/7c2571ba4edbbe8e8cc6504535b0af6214d1d18b"}}}}