{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/16238","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/16238/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/16238/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/16238/events","html_url":"https://github.com/kubernetes/kubernetes/issues/16238","id":113172441,"number":16238,"title":"godep restore failing due to Godep issue","user":{"login":"justinsb","id":100893,"avatar_url":"https://avatars.githubusercontent.com/u/100893?v=3","gravatar_id":"","url":"https://api.github.com/users/justinsb","html_url":"https://github.com/justinsb","followers_url":"https://api.github.com/users/justinsb/followers","following_url":"https://api.github.com/users/justinsb/following{/other_user}","gists_url":"https://api.github.com/users/justinsb/gists{/gist_id}","starred_url":"https://api.github.com/users/justinsb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinsb/subscriptions","organizations_url":"https://api.github.com/users/justinsb/orgs","repos_url":"https://api.github.com/users/justinsb/repos","events_url":"https://api.github.com/users/justinsb/events{/privacy}","received_events_url":"https://api.github.com/users/justinsb/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-10-24T17:09:16Z","updated_at":"2015-10-24T20:43:29Z","closed_at":null,"body":"The aws-sdk-go library just renamed a package from internal -> private to work around Go's vendoring experiment changes:\r\nhttps://github.com/aws/aws-sdk-go/commit/c09f1bb2f2270137bd1708d4668dc6beb2fb52f2\r\n\r\nBut we have a Godep dependency on some of these internal packages (we don't use them directly, but Godeps saves them anyway)\r\n\r\nThe problem is that godep ignores the branch when first pulling the code because it shells out to `go get`, so it tries to do a fetch on a package that doesn't exist on master: https://github.com/tools/godep/issues/186\r\n\r\nI think this combines to mean that `godep restore` is broken right now (or at least returning an exit code; I'm not sure if it actually is OK).  If you have a dirty Godeps tree, `hack/verify-godeps.sh` will also fail (but there is a short-circuit in there when the tree is clean which means that Shippable is still passing).\r\n\r\nI don't know really how we should fix this (properly).  A workaround is to manually:\r\n\r\n```\r\nrm -rf ${GOPATH}/src/github.com/aws/aws-sdk-go/\r\ngo get github.com/aws/aws-sdk-go\r\npushd ${GOPATH}/src/github.com/aws/aws-sdk-go/\r\ngit checkout v0.9.9\r\npopd\r\ngodep restore\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/150849471","html_url":"https://github.com/kubernetes/kubernetes/issues/16238#issuecomment-150849471","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/16238","id":150849471,"user":{"login":"justinsb","id":100893,"avatar_url":"https://avatars.githubusercontent.com/u/100893?v=3","gravatar_id":"","url":"https://api.github.com/users/justinsb","html_url":"https://github.com/justinsb","followers_url":"https://api.github.com/users/justinsb/followers","following_url":"https://api.github.com/users/justinsb/following{/other_user}","gists_url":"https://api.github.com/users/justinsb/gists{/gist_id}","starred_url":"https://api.github.com/users/justinsb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinsb/subscriptions","organizations_url":"https://api.github.com/users/justinsb/orgs","repos_url":"https://api.github.com/users/justinsb/repos","events_url":"https://api.github.com/users/justinsb/events{/privacy}","received_events_url":"https://api.github.com/users/justinsb/received_events","type":"User","site_admin":false},"created_at":"2015-10-24T20:43:29Z","updated_at":"2015-10-24T20:43:29Z","body":"I think it maybe only affects PRs that change Godeps (?).   My reading is that `hack/verify-godeps.sh` exits almost immediately if there are no changes in a PR to the Godeps dir: https://github.com/kubernetes/kubernetes/blob/master/hack/verify-godeps.sh#L42-L46\r\n\r\nAn alternative to the workaround I posted would be to fork aws-sdk-go and go back to the version where they didn't rename.  Or we could ask them to revert the change (it happened < 24 hours ago)"}}