{"action":"created","issue":{"url":"https://api.github.com/repos/codeclimate/codeclimate-services/issues/76","labels_url":"https://api.github.com/repos/codeclimate/codeclimate-services/issues/76/labels{/name}","comments_url":"https://api.github.com/repos/codeclimate/codeclimate-services/issues/76/comments","events_url":"https://api.github.com/repos/codeclimate/codeclimate-services/issues/76/events","html_url":"https://github.com/codeclimate/codeclimate-services/pull/76","id":92442167,"number":76,"title":"update failed pr message","user":{"login":"ABaldwinHunter","id":8718443,"avatar_url":"https://avatars.githubusercontent.com/u/8718443?v=3","gravatar_id":"","url":"https://api.github.com/users/ABaldwinHunter","html_url":"https://github.com/ABaldwinHunter","followers_url":"https://api.github.com/users/ABaldwinHunter/followers","following_url":"https://api.github.com/users/ABaldwinHunter/following{/other_user}","gists_url":"https://api.github.com/users/ABaldwinHunter/gists{/gist_id}","starred_url":"https://api.github.com/users/ABaldwinHunter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ABaldwinHunter/subscriptions","organizations_url":"https://api.github.com/users/ABaldwinHunter/orgs","repos_url":"https://api.github.com/users/ABaldwinHunter/repos","events_url":"https://api.github.com/users/ABaldwinHunter/events{/privacy}","received_events_url":"https://api.github.com/users/ABaldwinHunter/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-07-01T17:36:40Z","updated_at":"2015-07-01T20:26:44Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/codeclimate/codeclimate-services/pulls/76","html_url":"https://github.com/codeclimate/codeclimate-services/pull/76","diff_url":"https://github.com/codeclimate/codeclimate-services/pull/76.diff","patch_url":"https://github.com/codeclimate/codeclimate-services/pull/76.patch"},"body":"@codeclimate/review WIP. I wanted to create a more customized message for PR's that error due to incompatible worker versions- particularly engine related.\r\n\r\nSo, my solution was:\r\n\r\n1) add a key to payload that specifies if the worker version was changed (also updated in finalizer)\r\nPR: https://github.com/codeclimate/finalizer/pull/49\r\n2) create two constants for error messages: one default, one specific to worker version issue.\r\n\r\nEDIT: Feedback welcome. It's my first time working with `codeclimate-services`. If my approach seems right, I'll add tests. "},"comment":{"url":"https://api.github.com/repos/codeclimate/codeclimate-services/issues/comments/117816196","html_url":"https://github.com/codeclimate/codeclimate-services/pull/76#issuecomment-117816196","issue_url":"https://api.github.com/repos/codeclimate/codeclimate-services/issues/76","id":117816196,"user":{"login":"ABaldwinHunter","id":8718443,"avatar_url":"https://avatars.githubusercontent.com/u/8718443?v=3","gravatar_id":"","url":"https://api.github.com/users/ABaldwinHunter","html_url":"https://github.com/ABaldwinHunter","followers_url":"https://api.github.com/users/ABaldwinHunter/followers","following_url":"https://api.github.com/users/ABaldwinHunter/following{/other_user}","gists_url":"https://api.github.com/users/ABaldwinHunter/gists{/gist_id}","starred_url":"https://api.github.com/users/ABaldwinHunter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ABaldwinHunter/subscriptions","organizations_url":"https://api.github.com/users/ABaldwinHunter/orgs","repos_url":"https://api.github.com/users/ABaldwinHunter/repos","events_url":"https://api.github.com/users/ABaldwinHunter/events{/privacy}","received_events_url":"https://api.github.com/users/ABaldwinHunter/received_events","type":"User","site_admin":false},"created_at":"2015-07-01T20:26:44Z","updated_at":"2015-07-01T20:26:44Z","body":"@codeclimate/review I thought this PR was ready re-review - but now am not sure why Travis Build is failing (exploring). Tests pass locally when I run `bundle exec rake`.\r\n\r\nIt updates `pull_requests` to expect a payload with a `[:message]` key that is only used if the `state` is an error.\r\n\r\nGoal is to provide clearer feedback to users when PR fails due to incompatible worker versions. \r\n\r\nFirst draft message in that case: `\"Whoops. Code Climate cannot analyze a pull request against its base when only one is configured to use engines. We apologize for the inconvenience.\"`\r\n\r\nSee related changes in `finalizer`: https://github.com/codeclimate/finalizer/pull/50"}}