{"action":"created","comment":{"url":"https://api.github.com/repos/oalbiez/training/pulls/comments/46058498","id":46058498,"diff_hunk":"@@ -0,0 +1,58 @@\n+package com.katas.gameoflife;\n+\n+/**\n+ * @author Chloé Mahalin\n+ */\n+public class GameOfLife {\n+\n+\n+    public String live(int numberOfSteps, Universe universe) {\n+        if (universe != null && universe.getXSize() > 0 && universe.getYSize() > 0) {","path":"chloe/src/main/java/com/katas/gameoflife/GameOfLife.java","position":10,"original_position":10,"commit_id":"86d031c76c8319bd34cf55a135cf59137808b9ce","original_commit_id":"adf4445f504bf0f0ff23a57eb0c2e39e0dc3d0c2","user":{"login":"oalbiez","id":205184,"avatar_url":"https://avatars.githubusercontent.com/u/205184?v=3","gravatar_id":"","url":"https://api.github.com/users/oalbiez","html_url":"https://github.com/oalbiez","followers_url":"https://api.github.com/users/oalbiez/followers","following_url":"https://api.github.com/users/oalbiez/following{/other_user}","gists_url":"https://api.github.com/users/oalbiez/gists{/gist_id}","starred_url":"https://api.github.com/users/oalbiez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oalbiez/subscriptions","organizations_url":"https://api.github.com/users/oalbiez/orgs","repos_url":"https://api.github.com/users/oalbiez/repos","events_url":"https://api.github.com/users/oalbiez/events{/privacy}","received_events_url":"https://api.github.com/users/oalbiez/received_events","type":"User","site_admin":false},"body":"Cette méthode est une itération autour de evolve. Pour plus de cohérence dans l'API de ton système, garde le même ordre des paramètres. De plus tu peux utiliser le même nom de méthode pour simplifier le vocabulaire:\r\n- evolve(Universe u)\r\n- evolve(Universe u, int count)\r\n\r\nD'autre part, le terme live induit un mélange avec le status live/dead d'une cellule ;)\r\n","created_at":"2015-11-27T16:10:22Z","updated_at":"2015-11-27T16:10:22Z","html_url":"https://github.com/oalbiez/training/pull/1#discussion_r46058498","pull_request_url":"https://api.github.com/repos/oalbiez/training/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/oalbiez/training/pulls/comments/46058498"},"html":{"href":"https://github.com/oalbiez/training/pull/1#discussion_r46058498"},"pull_request":{"href":"https://api.github.com/repos/oalbiez/training/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/oalbiez/training/pulls/1","id":51976154,"html_url":"https://github.com/oalbiez/training/pull/1","diff_url":"https://github.com/oalbiez/training/pull/1.diff","patch_url":"https://github.com/oalbiez/training/pull/1.patch","issue_url":"https://api.github.com/repos/oalbiez/training/issues/1","number":1,"state":"open","locked":false,"title":"Questions","user":{"login":"Biquette","id":16031445,"avatar_url":"https://avatars.githubusercontent.com/u/16031445?v=3","gravatar_id":"","url":"https://api.github.com/users/Biquette","html_url":"https://github.com/Biquette","followers_url":"https://api.github.com/users/Biquette/followers","following_url":"https://api.github.com/users/Biquette/following{/other_user}","gists_url":"https://api.github.com/users/Biquette/gists{/gist_id}","starred_url":"https://api.github.com/users/Biquette/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Biquette/subscriptions","organizations_url":"https://api.github.com/users/Biquette/orgs","repos_url":"https://api.github.com/users/Biquette/repos","events_url":"https://api.github.com/users/Biquette/events{/privacy}","received_events_url":"https://api.github.com/users/Biquette/received_events","type":"User","site_admin":false},"body":"Salut Olivier,\r\n\r\nJe me demandais : est-ce que la méthode qui compte les voisins devrait être dans universe ou dans GameOfLife ?\r\nJe la mettrai plutôt dans Universe, puisqu'elle utilise cet univers. De même que les méthodes sur les états des cellules, je le mettrai bien dans universe mais j'ai peur qu'après elle contienne trop de choses.\r\n\r\nMerci.\r\nCdt,\r\nChloé.","created_at":"2015-11-27T09:47:28Z","updated_at":"2015-11-27T16:10:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"643112b19b4549241654f9e7f7f50064dc7e071a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/oalbiez/training/pulls/1/commits","review_comments_url":"https://api.github.com/repos/oalbiez/training/pulls/1/comments","review_comment_url":"https://api.github.com/repos/oalbiez/training/pulls/comments{/number}","comments_url":"https://api.github.com/repos/oalbiez/training/issues/1/comments","statuses_url":"https://api.github.com/repos/oalbiez/training/statuses/86d031c76c8319bd34cf55a135cf59137808b9ce","head":{"label":"Biquette:master","ref":"master","sha":"86d031c76c8319bd34cf55a135cf59137808b9ce","user":{"login":"Biquette","id":16031445,"avatar_url":"https://avatars.githubusercontent.com/u/16031445?v=3","gravatar_id":"","url":"https://api.github.com/users/Biquette","html_url":"https://github.com/Biquette","followers_url":"https://api.github.com/users/Biquette/followers","following_url":"https://api.github.com/users/Biquette/following{/other_user}","gists_url":"https://api.github.com/users/Biquette/gists{/gist_id}","starred_url":"https://api.github.com/users/Biquette/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Biquette/subscriptions","organizations_url":"https://api.github.com/users/Biquette/orgs","repos_url":"https://api.github.com/users/Biquette/repos","events_url":"https://api.github.com/users/Biquette/events{/privacy}","received_events_url":"https://api.github.com/users/Biquette/received_events","type":"User","site_admin":false},"repo":{"id":46922008,"name":"training","full_name":"Biquette/training","owner":{"login":"Biquette","id":16031445,"avatar_url":"https://avatars.githubusercontent.com/u/16031445?v=3","gravatar_id":"","url":"https://api.github.com/users/Biquette","html_url":"https://github.com/Biquette","followers_url":"https://api.github.com/users/Biquette/followers","following_url":"https://api.github.com/users/Biquette/following{/other_user}","gists_url":"https://api.github.com/users/Biquette/gists{/gist_id}","starred_url":"https://api.github.com/users/Biquette/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Biquette/subscriptions","organizations_url":"https://api.github.com/users/Biquette/orgs","repos_url":"https://api.github.com/users/Biquette/repos","events_url":"https://api.github.com/users/Biquette/events{/privacy}","received_events_url":"https://api.github.com/users/Biquette/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Biquette/training","description":"Exchange training stuffs","fork":true,"url":"https://api.github.com/repos/Biquette/training","forks_url":"https://api.github.com/repos/Biquette/training/forks","keys_url":"https://api.github.com/repos/Biquette/training/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Biquette/training/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Biquette/training/teams","hooks_url":"https://api.github.com/repos/Biquette/training/hooks","issue_events_url":"https://api.github.com/repos/Biquette/training/issues/events{/number}","events_url":"https://api.github.com/repos/Biquette/training/events","assignees_url":"https://api.github.com/repos/Biquette/training/assignees{/user}","branches_url":"https://api.github.com/repos/Biquette/training/branches{/branch}","tags_url":"https://api.github.com/repos/Biquette/training/tags","blobs_url":"https://api.github.com/repos/Biquette/training/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Biquette/training/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Biquette/training/git/refs{/sha}","trees_url":"https://api.github.com/repos/Biquette/training/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Biquette/training/statuses/{sha}","languages_url":"https://api.github.com/repos/Biquette/training/languages","stargazers_url":"https://api.github.com/repos/Biquette/training/stargazers","contributors_url":"https://api.github.com/repos/Biquette/training/contributors","subscribers_url":"https://api.github.com/repos/Biquette/training/subscribers","subscription_url":"https://api.github.com/repos/Biquette/training/subscription","commits_url":"https://api.github.com/repos/Biquette/training/commits{/sha}","git_commits_url":"https://api.github.com/repos/Biquette/training/git/commits{/sha}","comments_url":"https://api.github.com/repos/Biquette/training/comments{/number}","issue_comment_url":"https://api.github.com/repos/Biquette/training/issues/comments{/number}","contents_url":"https://api.github.com/repos/Biquette/training/contents/{+path}","compare_url":"https://api.github.com/repos/Biquette/training/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Biquette/training/merges","archive_url":"https://api.github.com/repos/Biquette/training/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Biquette/training/downloads","issues_url":"https://api.github.com/repos/Biquette/training/issues{/number}","pulls_url":"https://api.github.com/repos/Biquette/training/pulls{/number}","milestones_url":"https://api.github.com/repos/Biquette/training/milestones{/number}","notifications_url":"https://api.github.com/repos/Biquette/training/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Biquette/training/labels{/name}","releases_url":"https://api.github.com/repos/Biquette/training/releases{/id}","created_at":"2015-11-26T11:11:26Z","updated_at":"2015-11-27T10:36:15Z","pushed_at":"2015-11-27T16:06:11Z","git_url":"git://github.com/Biquette/training.git","ssh_url":"git@github.com:Biquette/training.git","clone_url":"https://github.com/Biquette/training.git","svn_url":"https://github.com/Biquette/training","homepage":null,"size":57,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"oalbiez:master","ref":"master","sha":"e10bc0aba3c9f79d9cabf3528804938100a70428","user":{"login":"oalbiez","id":205184,"avatar_url":"https://avatars.githubusercontent.com/u/205184?v=3","gravatar_id":"","url":"https://api.github.com/users/oalbiez","html_url":"https://github.com/oalbiez","followers_url":"https://api.github.com/users/oalbiez/followers","following_url":"https://api.github.com/users/oalbiez/following{/other_user}","gists_url":"https://api.github.com/users/oalbiez/gists{/gist_id}","starred_url":"https://api.github.com/users/oalbiez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oalbiez/subscriptions","organizations_url":"https://api.github.com/users/oalbiez/orgs","repos_url":"https://api.github.com/users/oalbiez/repos","events_url":"https://api.github.com/users/oalbiez/events{/privacy}","received_events_url":"https://api.github.com/users/oalbiez/received_events","type":"User","site_admin":false},"repo":{"id":46875100,"name":"training","full_name":"oalbiez/training","owner":{"login":"oalbiez","id":205184,"avatar_url":"https://avatars.githubusercontent.com/u/205184?v=3","gravatar_id":"","url":"https://api.github.com/users/oalbiez","html_url":"https://github.com/oalbiez","followers_url":"https://api.github.com/users/oalbiez/followers","following_url":"https://api.github.com/users/oalbiez/following{/other_user}","gists_url":"https://api.github.com/users/oalbiez/gists{/gist_id}","starred_url":"https://api.github.com/users/oalbiez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oalbiez/subscriptions","organizations_url":"https://api.github.com/users/oalbiez/orgs","repos_url":"https://api.github.com/users/oalbiez/repos","events_url":"https://api.github.com/users/oalbiez/events{/privacy}","received_events_url":"https://api.github.com/users/oalbiez/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/oalbiez/training","description":"Exchange training stuffs","fork":false,"url":"https://api.github.com/repos/oalbiez/training","forks_url":"https://api.github.com/repos/oalbiez/training/forks","keys_url":"https://api.github.com/repos/oalbiez/training/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oalbiez/training/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oalbiez/training/teams","hooks_url":"https://api.github.com/repos/oalbiez/training/hooks","issue_events_url":"https://api.github.com/repos/oalbiez/training/issues/events{/number}","events_url":"https://api.github.com/repos/oalbiez/training/events","assignees_url":"https://api.github.com/repos/oalbiez/training/assignees{/user}","branches_url":"https://api.github.com/repos/oalbiez/training/branches{/branch}","tags_url":"https://api.github.com/repos/oalbiez/training/tags","blobs_url":"https://api.github.com/repos/oalbiez/training/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oalbiez/training/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oalbiez/training/git/refs{/sha}","trees_url":"https://api.github.com/repos/oalbiez/training/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oalbiez/training/statuses/{sha}","languages_url":"https://api.github.com/repos/oalbiez/training/languages","stargazers_url":"https://api.github.com/repos/oalbiez/training/stargazers","contributors_url":"https://api.github.com/repos/oalbiez/training/contributors","subscribers_url":"https://api.github.com/repos/oalbiez/training/subscribers","subscription_url":"https://api.github.com/repos/oalbiez/training/subscription","commits_url":"https://api.github.com/repos/oalbiez/training/commits{/sha}","git_commits_url":"https://api.github.com/repos/oalbiez/training/git/commits{/sha}","comments_url":"https://api.github.com/repos/oalbiez/training/comments{/number}","issue_comment_url":"https://api.github.com/repos/oalbiez/training/issues/comments{/number}","contents_url":"https://api.github.com/repos/oalbiez/training/contents/{+path}","compare_url":"https://api.github.com/repos/oalbiez/training/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oalbiez/training/merges","archive_url":"https://api.github.com/repos/oalbiez/training/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oalbiez/training/downloads","issues_url":"https://api.github.com/repos/oalbiez/training/issues{/number}","pulls_url":"https://api.github.com/repos/oalbiez/training/pulls{/number}","milestones_url":"https://api.github.com/repos/oalbiez/training/milestones{/number}","notifications_url":"https://api.github.com/repos/oalbiez/training/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oalbiez/training/labels{/name}","releases_url":"https://api.github.com/repos/oalbiez/training/releases{/id}","created_at":"2015-11-25T16:58:53Z","updated_at":"2015-11-25T17:15:01Z","pushed_at":"2015-11-27T16:06:11Z","git_url":"git://github.com/oalbiez/training.git","ssh_url":"git@github.com:oalbiez/training.git","clone_url":"https://github.com/oalbiez/training.git","svn_url":"https://github.com/oalbiez/training","homepage":null,"size":5,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/oalbiez/training/pulls/1"},"html":{"href":"https://github.com/oalbiez/training/pull/1"},"issue":{"href":"https://api.github.com/repos/oalbiez/training/issues/1"},"comments":{"href":"https://api.github.com/repos/oalbiez/training/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/oalbiez/training/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/oalbiez/training/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/oalbiez/training/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/oalbiez/training/statuses/86d031c76c8319bd34cf55a135cf59137808b9ce"}}}}