{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/osquery/pulls/comments/31052120","id":31052120,"diff_hunk":"@@ -1,381 +0,0 @@\n-/*","path":"osquery/events/events_tests.cpp","position":1,"original_position":1,"commit_id":"fab40f7b70a8cc6c700966e77a581cbe8c26ca5d","original_commit_id":"fab40f7b70a8cc6c700966e77a581cbe8c26ca5d","user":{"login":"theopolis","id":981645,"avatar_url":"https://avatars.githubusercontent.com/u/981645?v=3","gravatar_id":"","url":"https://api.github.com/users/theopolis","html_url":"https://github.com/theopolis","followers_url":"https://api.github.com/users/theopolis/followers","following_url":"https://api.github.com/users/theopolis/following{/other_user}","gists_url":"https://api.github.com/users/theopolis/gists{/gist_id}","starred_url":"https://api.github.com/users/theopolis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theopolis/subscriptions","organizations_url":"https://api.github.com/users/theopolis/orgs","repos_url":"https://api.github.com/users/theopolis/repos","events_url":"https://api.github.com/users/theopolis/events{/privacy}","received_events_url":"https://api.github.com/users/theopolis/received_events","type":"User","site_admin":false},"body":"This file was duplicated, we're not removing tests. \r\nExisting set of tests: https://github.com/facebook/osquery/blob/master/osquery/events/tests/events_tests.cpp","created_at":"2015-05-26T16:23:59Z","updated_at":"2015-05-26T16:23:59Z","html_url":"https://github.com/facebook/osquery/pull/1158#discussion_r31052120","pull_request_url":"https://api.github.com/repos/facebook/osquery/pulls/1158","_links":{"self":{"href":"https://api.github.com/repos/facebook/osquery/pulls/comments/31052120"},"html":{"href":"https://github.com/facebook/osquery/pull/1158#discussion_r31052120"},"pull_request":{"href":"https://api.github.com/repos/facebook/osquery/pulls/1158"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/osquery/pulls/1158","id":36096790,"html_url":"https://github.com/facebook/osquery/pull/1158","diff_url":"https://github.com/facebook/osquery/pull/1158.diff","patch_url":"https://github.com/facebook/osquery/pull/1158.patch","issue_url":"https://api.github.com/repos/facebook/osquery/issues/1158","number":1158,"state":"open","locked":false,"title":"TLS/Enroll plugin workflow optimizations","user":{"login":"theopolis","id":981645,"avatar_url":"https://avatars.githubusercontent.com/u/981645?v=3","gravatar_id":"","url":"https://api.github.com/users/theopolis","html_url":"https://github.com/theopolis","followers_url":"https://api.github.com/users/theopolis/followers","following_url":"https://api.github.com/users/theopolis/following{/other_user}","gists_url":"https://api.github.com/users/theopolis/gists{/gist_id}","starred_url":"https://api.github.com/users/theopolis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theopolis/subscriptions","organizations_url":"https://api.github.com/users/theopolis/orgs","repos_url":"https://api.github.com/users/theopolis/repos","events_url":"https://api.github.com/users/theopolis/events{/privacy}","received_events_url":"https://api.github.com/users/theopolis/received_events","type":"User","site_admin":false},"body":"A work in progress stressing the config, enrollment, and eventually logging TLS-based plugins through integration testing.\r\n\r\n1. Move RocksDB/Internal-Query away from the SDK. There is still a dependency from EventSubscribers on the RocksDB API.\r\n2. Use a \"database\" registry to represent calls to the internal storage representation. In every instance this will remain RocksDB.\r\n3. Prefer to optimize for size. I've tried including link time optimizations and it does save near a half-MB of output but it may have unknown run-time impacts. Anecdotal, I've seen publisher-tests failing (so for now, NO `-flto` please).\r\n4. On some linux systems librt is provided in static-compilation form. We do not want to link librt statically.","created_at":"2015-05-24T01:54:31Z","updated_at":"2015-05-26T16:23:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a28f042130da098fe02bdb58d6e6d2ffc9fca81b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/facebook/osquery/pulls/1158/commits","review_comments_url":"https://api.github.com/repos/facebook/osquery/pulls/1158/comments","review_comment_url":"https://api.github.com/repos/facebook/osquery/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/osquery/issues/1158/comments","statuses_url":"https://api.github.com/repos/facebook/osquery/statuses/fab40f7b70a8cc6c700966e77a581cbe8c26ca5d","head":{"label":"theopolis:tls_workflow","ref":"tls_workflow","sha":"fab40f7b70a8cc6c700966e77a581cbe8c26ca5d","user":{"login":"theopolis","id":981645,"avatar_url":"https://avatars.githubusercontent.com/u/981645?v=3","gravatar_id":"","url":"https://api.github.com/users/theopolis","html_url":"https://github.com/theopolis","followers_url":"https://api.github.com/users/theopolis/followers","following_url":"https://api.github.com/users/theopolis/following{/other_user}","gists_url":"https://api.github.com/users/theopolis/gists{/gist_id}","starred_url":"https://api.github.com/users/theopolis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theopolis/subscriptions","organizations_url":"https://api.github.com/users/theopolis/orgs","repos_url":"https://api.github.com/users/theopolis/repos","events_url":"https://api.github.com/users/theopolis/events{/privacy}","received_events_url":"https://api.github.com/users/theopolis/received_events","type":"User","site_admin":false},"repo":{"id":26103098,"name":"osquery","full_name":"theopolis/osquery","owner":{"login":"theopolis","id":981645,"avatar_url":"https://avatars.githubusercontent.com/u/981645?v=3","gravatar_id":"","url":"https://api.github.com/users/theopolis","html_url":"https://github.com/theopolis","followers_url":"https://api.github.com/users/theopolis/followers","following_url":"https://api.github.com/users/theopolis/following{/other_user}","gists_url":"https://api.github.com/users/theopolis/gists{/gist_id}","starred_url":"https://api.github.com/users/theopolis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theopolis/subscriptions","organizations_url":"https://api.github.com/users/theopolis/orgs","repos_url":"https://api.github.com/users/theopolis/repos","events_url":"https://api.github.com/users/theopolis/events{/privacy}","received_events_url":"https://api.github.com/users/theopolis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/theopolis/osquery","description":"SQL powered operating system instrumentation and monitoring.","fork":true,"url":"https://api.github.com/repos/theopolis/osquery","forks_url":"https://api.github.com/repos/theopolis/osquery/forks","keys_url":"https://api.github.com/repos/theopolis/osquery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theopolis/osquery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theopolis/osquery/teams","hooks_url":"https://api.github.com/repos/theopolis/osquery/hooks","issue_events_url":"https://api.github.com/repos/theopolis/osquery/issues/events{/number}","events_url":"https://api.github.com/repos/theopolis/osquery/events","assignees_url":"https://api.github.com/repos/theopolis/osquery/assignees{/user}","branches_url":"https://api.github.com/repos/theopolis/osquery/branches{/branch}","tags_url":"https://api.github.com/repos/theopolis/osquery/tags","blobs_url":"https://api.github.com/repos/theopolis/osquery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theopolis/osquery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theopolis/osquery/git/refs{/sha}","trees_url":"https://api.github.com/repos/theopolis/osquery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theopolis/osquery/statuses/{sha}","languages_url":"https://api.github.com/repos/theopolis/osquery/languages","stargazers_url":"https://api.github.com/repos/theopolis/osquery/stargazers","contributors_url":"https://api.github.com/repos/theopolis/osquery/contributors","subscribers_url":"https://api.github.com/repos/theopolis/osquery/subscribers","subscription_url":"https://api.github.com/repos/theopolis/osquery/subscription","commits_url":"https://api.github.com/repos/theopolis/osquery/commits{/sha}","git_commits_url":"https://api.github.com/repos/theopolis/osquery/git/commits{/sha}","comments_url":"https://api.github.com/repos/theopolis/osquery/comments{/number}","issue_comment_url":"https://api.github.com/repos/theopolis/osquery/issues/comments{/number}","contents_url":"https://api.github.com/repos/theopolis/osquery/contents/{+path}","compare_url":"https://api.github.com/repos/theopolis/osquery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theopolis/osquery/merges","archive_url":"https://api.github.com/repos/theopolis/osquery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theopolis/osquery/downloads","issues_url":"https://api.github.com/repos/theopolis/osquery/issues{/number}","pulls_url":"https://api.github.com/repos/theopolis/osquery/pulls{/number}","milestones_url":"https://api.github.com/repos/theopolis/osquery/milestones{/number}","notifications_url":"https://api.github.com/repos/theopolis/osquery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theopolis/osquery/labels{/name}","releases_url":"https://api.github.com/repos/theopolis/osquery/releases{/id}","created_at":"2014-11-03T03:56:14Z","updated_at":"2015-04-26T10:54:32Z","pushed_at":"2015-05-26T05:33:30Z","git_url":"git://github.com/theopolis/osquery.git","ssh_url":"git@github.com:theopolis/osquery.git","clone_url":"https://github.com/theopolis/osquery.git","svn_url":"https://github.com/theopolis/osquery","homepage":"http://osquery.io","size":7643,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"8b21a4771085872f367a08e085d9b89a82a2b8fe","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":22394357,"name":"osquery","full_name":"facebook/osquery","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/osquery","description":"SQL powered operating system instrumentation, monitoring, and analytics.","fork":false,"url":"https://api.github.com/repos/facebook/osquery","forks_url":"https://api.github.com/repos/facebook/osquery/forks","keys_url":"https://api.github.com/repos/facebook/osquery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/osquery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/osquery/teams","hooks_url":"https://api.github.com/repos/facebook/osquery/hooks","issue_events_url":"https://api.github.com/repos/facebook/osquery/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/osquery/events","assignees_url":"https://api.github.com/repos/facebook/osquery/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/osquery/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/osquery/tags","blobs_url":"https://api.github.com/repos/facebook/osquery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/osquery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/osquery/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/osquery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/osquery/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/osquery/languages","stargazers_url":"https://api.github.com/repos/facebook/osquery/stargazers","contributors_url":"https://api.github.com/repos/facebook/osquery/contributors","subscribers_url":"https://api.github.com/repos/facebook/osquery/subscribers","subscription_url":"https://api.github.com/repos/facebook/osquery/subscription","commits_url":"https://api.github.com/repos/facebook/osquery/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/osquery/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/osquery/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/osquery/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/osquery/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/osquery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/osquery/merges","archive_url":"https://api.github.com/repos/facebook/osquery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/osquery/downloads","issues_url":"https://api.github.com/repos/facebook/osquery/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/osquery/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/osquery/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/osquery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/osquery/labels{/name}","releases_url":"https://api.github.com/repos/facebook/osquery/releases{/id}","created_at":"2014-07-29T20:27:33Z","updated_at":"2015-05-26T16:09:12Z","pushed_at":"2015-05-26T05:33:30Z","git_url":"git://github.com/facebook/osquery.git","ssh_url":"git@github.com:facebook/osquery.git","clone_url":"https://github.com/facebook/osquery.git","svn_url":"https://github.com/facebook/osquery","homepage":"https://osquery.io","size":17578,"stargazers_count":4228,"watchers_count":4228,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":338,"mirror_url":null,"open_issues_count":26,"forks":338,"open_issues":26,"watchers":4228,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/osquery/pulls/1158"},"html":{"href":"https://github.com/facebook/osquery/pull/1158"},"issue":{"href":"https://api.github.com/repos/facebook/osquery/issues/1158"},"comments":{"href":"https://api.github.com/repos/facebook/osquery/issues/1158/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/osquery/pulls/1158/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/osquery/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/osquery/pulls/1158/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/osquery/statuses/fab40f7b70a8cc6c700966e77a581cbe8c26ca5d"}}}}