{"action":"created","issue":{"url":"https://api.github.com/repos/ncb000gt/node.bcrypt.js/issues/324","labels_url":"https://api.github.com/repos/ncb000gt/node.bcrypt.js/issues/324/labels{/name}","comments_url":"https://api.github.com/repos/ncb000gt/node.bcrypt.js/issues/324/comments","events_url":"https://api.github.com/repos/ncb000gt/node.bcrypt.js/issues/324/events","html_url":"https://github.com/ncb000gt/node.bcrypt.js/pull/324","id":100379707,"number":324,"title":"update to nan v2 (adds support for iojs 3)","user":{"login":"defunctzombie","id":84792,"avatar_url":"https://avatars.githubusercontent.com/u/84792?v=3","gravatar_id":"","url":"https://api.github.com/users/defunctzombie","html_url":"https://github.com/defunctzombie","followers_url":"https://api.github.com/users/defunctzombie/followers","following_url":"https://api.github.com/users/defunctzombie/following{/other_user}","gists_url":"https://api.github.com/users/defunctzombie/gists{/gist_id}","starred_url":"https://api.github.com/users/defunctzombie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/defunctzombie/subscriptions","organizations_url":"https://api.github.com/users/defunctzombie/orgs","repos_url":"https://api.github.com/users/defunctzombie/repos","events_url":"https://api.github.com/users/defunctzombie/events{/privacy}","received_events_url":"https://api.github.com/users/defunctzombie/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-08-11T18:46:38Z","updated_at":"2015-08-13T08:59:17Z","closed_at":"2015-08-12T21:54:17Z","pull_request":{"url":"https://api.github.com/repos/ncb000gt/node.bcrypt.js/pulls/324","html_url":"https://github.com/ncb000gt/node.bcrypt.js/pull/324","diff_url":"https://github.com/ncb000gt/node.bcrypt.js/pull/324.diff","patch_url":"https://github.com/ncb000gt/node.bcrypt.js/pull/324.patch"},"body":"Nan v2 required more code changes but also adds support for iojs 3 and\r\nhopefully provides a more stable API which will not have to change as\r\nmuch going forward."},"comment":{"url":"https://api.github.com/repos/ncb000gt/node.bcrypt.js/issues/comments/130583722","html_url":"https://github.com/ncb000gt/node.bcrypt.js/pull/324#issuecomment-130583722","issue_url":"https://api.github.com/repos/ncb000gt/node.bcrypt.js/issues/324","id":130583722,"user":{"login":"kkoopa","id":4103081,"avatar_url":"https://avatars.githubusercontent.com/u/4103081?v=3","gravatar_id":"","url":"https://api.github.com/users/kkoopa","html_url":"https://github.com/kkoopa","followers_url":"https://api.github.com/users/kkoopa/followers","following_url":"https://api.github.com/users/kkoopa/following{/other_user}","gists_url":"https://api.github.com/users/kkoopa/gists{/gist_id}","starred_url":"https://api.github.com/users/kkoopa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kkoopa/subscriptions","organizations_url":"https://api.github.com/users/kkoopa/orgs","repos_url":"https://api.github.com/users/kkoopa/repos","events_url":"https://api.github.com/users/kkoopa/events{/privacy}","received_events_url":"https://api.github.com/users/kkoopa/received_events","type":"User","site_admin":false},"created_at":"2015-08-13T08:59:16Z","updated_at":"2015-08-13T08:59:16Z","body":"While this compiles for now, you still want to change all uses of `v8::Value::ToXXX` and `v8::Value::XXXValue` to `Nan::To<XXX>` https://github.com/nodejs/nan/blob/master/doc/converters.md#api_nan_to, since the former will be removed from V8 in coming versions.\r\n\r\nI would also recommend `Nan::Utf8String` as a drop-in replacement of `v8::String::Utf8Value`, which handles invalid UTF-8 in a consistent way."}}