{"action":"created","comment":{"url":"https://api.github.com/repos/vizorvr/vizor-create/pulls/comments/38805495","id":38805495,"diff_hunk":"@@ -0,0 +1,131 @@\n+(function() {\n+\tvar ThreeMaterialModifier = E2.plugins.three_material_modifier = function(core) {\n+\t\tPlugin.apply(this, arguments)\n+\n+\t\tthis.input_slots = [\n+\t\t\t{\n+\t\t\t\tname: 'material',\n+\t\t\t\tdt: core.datatypes.MATERIAL,\n+\t\t\t\tarray: true,\n+\t\t\t\tdef: [new THREE.MeshBasicMaterial({name: 'default material', color: 0x00FF00})]\n+\t\t\t}\n+\t\t]\n+\n+\t\tthis.output_slots = [\n+\t\t\t{\n+\t\t\t\tname: 'material',\n+\t\t\t\tdt: core.datatypes.MATERIAL,\n+\t\t\t\tarray: true\n+\t\t\t}\n+\t\t]\n+\t}\n+\n+\tThreeMaterialModifier.prototype = Object.create(Plugin.prototype)\n+\n+\tThreeMaterialModifier.prototype.reset = function() {\n+\t\tthis.in_material_array = []\n+\t\tthis.out_material_array = []\n+\t\tthis.material_override = {}\n+\n+\t\tthis.material_slots_dirty = false\n+\t\tthis.materials_dirty = false\n+\t}\n+\n+\tThreeMaterialModifier.prototype.update_input = function(slot, data) {\n+\t\tif (!slot.uid && slot.index == 0) {\n+\t\t\tif (data) {\n+\t\t\t\tif (this.in_material_array.length == data.length) {","path":"browser/plugins/three_material_modifier.plugin.js","position":37,"original_position":37,"commit_id":"79e64e73ff3ac44e745cee47c44214568846df1a","original_commit_id":"79e64e73ff3ac44e745cee47c44214568846df1a","user":{"login":"kkananen","id":1742765,"avatar_url":"https://avatars.githubusercontent.com/u/1742765?v=3","gravatar_id":"","url":"https://api.github.com/users/kkananen","html_url":"https://github.com/kkananen","followers_url":"https://api.github.com/users/kkananen/followers","following_url":"https://api.github.com/users/kkananen/following{/other_user}","gists_url":"https://api.github.com/users/kkananen/gists{/gist_id}","starred_url":"https://api.github.com/users/kkananen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kkananen/subscriptions","organizations_url":"https://api.github.com/users/kkananen/orgs","repos_url":"https://api.github.com/users/kkananen/repos","events_url":"https://api.github.com/users/kkananen/events{/privacy}","received_events_url":"https://api.github.com/users/kkananen/received_events","type":"User","site_admin":false},"body":"can't early out on !data as we need to remove stuff from the array in the else block","created_at":"2015-09-05T01:21:00Z","updated_at":"2015-09-05T01:21:00Z","html_url":"https://github.com/vizorvr/vizor-create/pull/341#discussion_r38805495","pull_request_url":"https://api.github.com/repos/vizorvr/vizor-create/pulls/341","_links":{"self":{"href":"https://api.github.com/repos/vizorvr/vizor-create/pulls/comments/38805495"},"html":{"href":"https://github.com/vizorvr/vizor-create/pull/341#discussion_r38805495"},"pull_request":{"href":"https://api.github.com/repos/vizorvr/vizor-create/pulls/341"}}},"pull_request":{"url":"https://api.github.com/repos/vizorvr/vizor-create/pulls/341","id":44178336,"html_url":"https://github.com/vizorvr/vizor-create/pull/341","diff_url":"https://github.com/vizorvr/vizor-create/pull/341.diff","patch_url":"https://github.com/vizorvr/vizor-create/pull/341.patch","issue_url":"https://api.github.com/repos/vizorvr/vizor-create/issues/341","number":341,"state":"open","locked":false,"title":"Three birdanim - resolves #304","user":{"login":"kkananen","id":1742765,"avatar_url":"https://avatars.githubusercontent.com/u/1742765?v=3","gravatar_id":"","url":"https://api.github.com/users/kkananen","html_url":"https://github.com/kkananen","followers_url":"https://api.github.com/users/kkananen/followers","following_url":"https://api.github.com/users/kkananen/following{/other_user}","gists_url":"https://api.github.com/users/kkananen/gists{/gist_id}","starred_url":"https://api.github.com/users/kkananen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kkananen/subscriptions","organizations_url":"https://api.github.com/users/kkananen/orgs","repos_url":"https://api.github.com/users/kkananen/repos","events_url":"https://api.github.com/users/kkananen/events{/privacy}","received_events_url":"https://api.github.com/users/kkananen/received_events","type":"User","site_admin":false},"body":"support for arrays of geometries and materials\r\nmaterial modifier node ","created_at":"2015-09-04T02:35:50Z","updated_at":"2015-09-05T01:21:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8d0b93e69450b2b25234a1cf81df7824eced1eef","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/vizorvr/vizor-create/pulls/341/commits","review_comments_url":"https://api.github.com/repos/vizorvr/vizor-create/pulls/341/comments","review_comment_url":"https://api.github.com/repos/vizorvr/vizor-create/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vizorvr/vizor-create/issues/341/comments","statuses_url":"https://api.github.com/repos/vizorvr/vizor-create/statuses/79e64e73ff3ac44e745cee47c44214568846df1a","head":{"label":"vizorvr:three-birdanim","ref":"three-birdanim","sha":"79e64e73ff3ac44e745cee47c44214568846df1a","user":{"login":"vizorvr","id":10456166,"avatar_url":"https://avatars.githubusercontent.com/u/10456166?v=3","gravatar_id":"","url":"https://api.github.com/users/vizorvr","html_url":"https://github.com/vizorvr","followers_url":"https://api.github.com/users/vizorvr/followers","following_url":"https://api.github.com/users/vizorvr/following{/other_user}","gists_url":"https://api.github.com/users/vizorvr/gists{/gist_id}","starred_url":"https://api.github.com/users/vizorvr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vizorvr/subscriptions","organizations_url":"https://api.github.com/users/vizorvr/orgs","repos_url":"https://api.github.com/users/vizorvr/repos","events_url":"https://api.github.com/users/vizorvr/events{/privacy}","received_events_url":"https://api.github.com/users/vizorvr/received_events","type":"Organization","site_admin":false},"repo":{"id":29096746,"name":"vizor-create","full_name":"vizorvr/vizor-create","owner":{"login":"vizorvr","id":10456166,"avatar_url":"https://avatars.githubusercontent.com/u/10456166?v=3","gravatar_id":"","url":"https://api.github.com/users/vizorvr","html_url":"https://github.com/vizorvr","followers_url":"https://api.github.com/users/vizorvr/followers","following_url":"https://api.github.com/users/vizorvr/following{/other_user}","gists_url":"https://api.github.com/users/vizorvr/gists{/gist_id}","starred_url":"https://api.github.com/users/vizorvr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vizorvr/subscriptions","organizations_url":"https://api.github.com/users/vizorvr/orgs","repos_url":"https://api.github.com/users/vizorvr/repos","events_url":"https://api.github.com/users/vizorvr/events{/privacy}","received_events_url":"https://api.github.com/users/vizorvr/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vizorvr/vizor-create","description":"Vizor Create is a visual programming tool for WebVR, WebGL and other HTML5 APIs","fork":false,"url":"https://api.github.com/repos/vizorvr/vizor-create","forks_url":"https://api.github.com/repos/vizorvr/vizor-create/forks","keys_url":"https://api.github.com/repos/vizorvr/vizor-create/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vizorvr/vizor-create/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vizorvr/vizor-create/teams","hooks_url":"https://api.github.com/repos/vizorvr/vizor-create/hooks","issue_events_url":"https://api.github.com/repos/vizorvr/vizor-create/issues/events{/number}","events_url":"https://api.github.com/repos/vizorvr/vizor-create/events","assignees_url":"https://api.github.com/repos/vizorvr/vizor-create/assignees{/user}","branches_url":"https://api.github.com/repos/vizorvr/vizor-create/branches{/branch}","tags_url":"https://api.github.com/repos/vizorvr/vizor-create/tags","blobs_url":"https://api.github.com/repos/vizorvr/vizor-create/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vizorvr/vizor-create/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vizorvr/vizor-create/git/refs{/sha}","trees_url":"https://api.github.com/repos/vizorvr/vizor-create/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vizorvr/vizor-create/statuses/{sha}","languages_url":"https://api.github.com/repos/vizorvr/vizor-create/languages","stargazers_url":"https://api.github.com/repos/vizorvr/vizor-create/stargazers","contributors_url":"https://api.github.com/repos/vizorvr/vizor-create/contributors","subscribers_url":"https://api.github.com/repos/vizorvr/vizor-create/subscribers","subscription_url":"https://api.github.com/repos/vizorvr/vizor-create/subscription","commits_url":"https://api.github.com/repos/vizorvr/vizor-create/commits{/sha}","git_commits_url":"https://api.github.com/repos/vizorvr/vizor-create/git/commits{/sha}","comments_url":"https://api.github.com/repos/vizorvr/vizor-create/comments{/number}","issue_comment_url":"https://api.github.com/repos/vizorvr/vizor-create/issues/comments{/number}","contents_url":"https://api.github.com/repos/vizorvr/vizor-create/contents/{+path}","compare_url":"https://api.github.com/repos/vizorvr/vizor-create/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vizorvr/vizor-create/merges","archive_url":"https://api.github.com/repos/vizorvr/vizor-create/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vizorvr/vizor-create/downloads","issues_url":"https://api.github.com/repos/vizorvr/vizor-create/issues{/number}","pulls_url":"https://api.github.com/repos/vizorvr/vizor-create/pulls{/number}","milestones_url":"https://api.github.com/repos/vizorvr/vizor-create/milestones{/number}","notifications_url":"https://api.github.com/repos/vizorvr/vizor-create/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vizorvr/vizor-create/labels{/name}","releases_url":"https://api.github.com/repos/vizorvr/vizor-create/releases{/id}","created_at":"2015-01-11T15:54:34Z","updated_at":"2015-09-02T08:28:02Z","pushed_at":"2015-09-05T01:19:54Z","git_url":"git://github.com/vizorvr/vizor-create.git","ssh_url":"git@github.com:vizorvr/vizor-create.git","clone_url":"https://github.com/vizorvr/vizor-create.git","svn_url":"https://github.com/vizorvr/vizor-create","homepage":"http://create.vizor.io","size":36778,"stargazers_count":40,"watchers_count":40,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":114,"forks":4,"open_issues":114,"watchers":40,"default_branch":"master"}},"base":{"label":"vizorvr:develop","ref":"develop","sha":"9836edb9541cb72adc846a351396d8b4552367e8","user":{"login":"vizorvr","id":10456166,"avatar_url":"https://avatars.githubusercontent.com/u/10456166?v=3","gravatar_id":"","url":"https://api.github.com/users/vizorvr","html_url":"https://github.com/vizorvr","followers_url":"https://api.github.com/users/vizorvr/followers","following_url":"https://api.github.com/users/vizorvr/following{/other_user}","gists_url":"https://api.github.com/users/vizorvr/gists{/gist_id}","starred_url":"https://api.github.com/users/vizorvr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vizorvr/subscriptions","organizations_url":"https://api.github.com/users/vizorvr/orgs","repos_url":"https://api.github.com/users/vizorvr/repos","events_url":"https://api.github.com/users/vizorvr/events{/privacy}","received_events_url":"https://api.github.com/users/vizorvr/received_events","type":"Organization","site_admin":false},"repo":{"id":29096746,"name":"vizor-create","full_name":"vizorvr/vizor-create","owner":{"login":"vizorvr","id":10456166,"avatar_url":"https://avatars.githubusercontent.com/u/10456166?v=3","gravatar_id":"","url":"https://api.github.com/users/vizorvr","html_url":"https://github.com/vizorvr","followers_url":"https://api.github.com/users/vizorvr/followers","following_url":"https://api.github.com/users/vizorvr/following{/other_user}","gists_url":"https://api.github.com/users/vizorvr/gists{/gist_id}","starred_url":"https://api.github.com/users/vizorvr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vizorvr/subscriptions","organizations_url":"https://api.github.com/users/vizorvr/orgs","repos_url":"https://api.github.com/users/vizorvr/repos","events_url":"https://api.github.com/users/vizorvr/events{/privacy}","received_events_url":"https://api.github.com/users/vizorvr/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vizorvr/vizor-create","description":"Vizor Create is a visual programming tool for WebVR, WebGL and other HTML5 APIs","fork":false,"url":"https://api.github.com/repos/vizorvr/vizor-create","forks_url":"https://api.github.com/repos/vizorvr/vizor-create/forks","keys_url":"https://api.github.com/repos/vizorvr/vizor-create/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vizorvr/vizor-create/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vizorvr/vizor-create/teams","hooks_url":"https://api.github.com/repos/vizorvr/vizor-create/hooks","issue_events_url":"https://api.github.com/repos/vizorvr/vizor-create/issues/events{/number}","events_url":"https://api.github.com/repos/vizorvr/vizor-create/events","assignees_url":"https://api.github.com/repos/vizorvr/vizor-create/assignees{/user}","branches_url":"https://api.github.com/repos/vizorvr/vizor-create/branches{/branch}","tags_url":"https://api.github.com/repos/vizorvr/vizor-create/tags","blobs_url":"https://api.github.com/repos/vizorvr/vizor-create/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vizorvr/vizor-create/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vizorvr/vizor-create/git/refs{/sha}","trees_url":"https://api.github.com/repos/vizorvr/vizor-create/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vizorvr/vizor-create/statuses/{sha}","languages_url":"https://api.github.com/repos/vizorvr/vizor-create/languages","stargazers_url":"https://api.github.com/repos/vizorvr/vizor-create/stargazers","contributors_url":"https://api.github.com/repos/vizorvr/vizor-create/contributors","subscribers_url":"https://api.github.com/repos/vizorvr/vizor-create/subscribers","subscription_url":"https://api.github.com/repos/vizorvr/vizor-create/subscription","commits_url":"https://api.github.com/repos/vizorvr/vizor-create/commits{/sha}","git_commits_url":"https://api.github.com/repos/vizorvr/vizor-create/git/commits{/sha}","comments_url":"https://api.github.com/repos/vizorvr/vizor-create/comments{/number}","issue_comment_url":"https://api.github.com/repos/vizorvr/vizor-create/issues/comments{/number}","contents_url":"https://api.github.com/repos/vizorvr/vizor-create/contents/{+path}","compare_url":"https://api.github.com/repos/vizorvr/vizor-create/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vizorvr/vizor-create/merges","archive_url":"https://api.github.com/repos/vizorvr/vizor-create/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vizorvr/vizor-create/downloads","issues_url":"https://api.github.com/repos/vizorvr/vizor-create/issues{/number}","pulls_url":"https://api.github.com/repos/vizorvr/vizor-create/pulls{/number}","milestones_url":"https://api.github.com/repos/vizorvr/vizor-create/milestones{/number}","notifications_url":"https://api.github.com/repos/vizorvr/vizor-create/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vizorvr/vizor-create/labels{/name}","releases_url":"https://api.github.com/repos/vizorvr/vizor-create/releases{/id}","created_at":"2015-01-11T15:54:34Z","updated_at":"2015-09-02T08:28:02Z","pushed_at":"2015-09-05T01:19:54Z","git_url":"git://github.com/vizorvr/vizor-create.git","ssh_url":"git@github.com:vizorvr/vizor-create.git","clone_url":"https://github.com/vizorvr/vizor-create.git","svn_url":"https://github.com/vizorvr/vizor-create","homepage":"http://create.vizor.io","size":36778,"stargazers_count":40,"watchers_count":40,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":114,"forks":4,"open_issues":114,"watchers":40,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vizorvr/vizor-create/pulls/341"},"html":{"href":"https://github.com/vizorvr/vizor-create/pull/341"},"issue":{"href":"https://api.github.com/repos/vizorvr/vizor-create/issues/341"},"comments":{"href":"https://api.github.com/repos/vizorvr/vizor-create/issues/341/comments"},"review_comments":{"href":"https://api.github.com/repos/vizorvr/vizor-create/pulls/341/comments"},"review_comment":{"href":"https://api.github.com/repos/vizorvr/vizor-create/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vizorvr/vizor-create/pulls/341/commits"},"statuses":{"href":"https://api.github.com/repos/vizorvr/vizor-create/statuses/79e64e73ff3ac44e745cee47c44214568846df1a"}}}}