{"action":"created","comment":{"url":"https://api.github.com/repos/MariaDB/server/pulls/comments/38736308","id":38736308,"diff_hunk":"@@ -21,9 +21,11 @@ mysqld_ld_library_path=\n flush_caches=0\n numa_interleave=0\n wsrep_on=0\n+simulate=0","path":"scripts/mysqld_safe.sh","position":4,"original_position":4,"commit_id":"f7abb1d8cd97db4c1dfab3f5d7bc1d0da8d3b7c6","original_commit_id":"f7abb1d8cd97db4c1dfab3f5d7bc1d0da8d3b7c6","user":{"login":"svoj","id":7700472,"avatar_url":"https://avatars.githubusercontent.com/u/7700472?v=3","gravatar_id":"","url":"https://api.github.com/users/svoj","html_url":"https://github.com/svoj","followers_url":"https://api.github.com/users/svoj/followers","following_url":"https://api.github.com/users/svoj/following{/other_user}","gists_url":"https://api.github.com/users/svoj/gists{/gist_id}","starred_url":"https://api.github.com/users/svoj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/svoj/subscriptions","organizations_url":"https://api.github.com/users/svoj/orgs","repos_url":"https://api.github.com/users/svoj/repos","events_url":"https://api.github.com/users/svoj/events{/privacy}","received_events_url":"https://api.github.com/users/svoj/received_events","type":"User","site_admin":false},"body":"I'm not sure I like this. What's the point of all this \"simulate\" stuff?\r\n\r\nThe problem is that it complicates future edits of this script: if one wants to add some action, he has to handle \"simulate\" case too. :(","created_at":"2015-09-04T09:43:21Z","updated_at":"2015-09-04T09:43:21Z","html_url":"https://github.com/MariaDB/server/pull/83#discussion_r38736308","pull_request_url":"https://api.github.com/repos/MariaDB/server/pulls/83","_links":{"self":{"href":"https://api.github.com/repos/MariaDB/server/pulls/comments/38736308"},"html":{"href":"https://github.com/MariaDB/server/pull/83#discussion_r38736308"},"pull_request":{"href":"https://api.github.com/repos/MariaDB/server/pulls/83"}}},"pull_request":{"url":"https://api.github.com/repos/MariaDB/server/pulls/83","id":39740830,"html_url":"https://github.com/MariaDB/server/pull/83","diff_url":"https://github.com/MariaDB/server/pull/83.diff","patch_url":"https://github.com/MariaDB/server/pull/83.patch","issue_url":"https://api.github.com/repos/MariaDB/server/issues/83","number":83,"state":"open","locked":false,"title":"Mdev 5536 Add systemd notify and socket activation capabilities to 10.1 branch","user":{"login":"grooverdan","id":462287,"avatar_url":"https://avatars.githubusercontent.com/u/462287?v=3","gravatar_id":"","url":"https://api.github.com/users/grooverdan","html_url":"https://github.com/grooverdan","followers_url":"https://api.github.com/users/grooverdan/followers","following_url":"https://api.github.com/users/grooverdan/following{/other_user}","gists_url":"https://api.github.com/users/grooverdan/gists{/gist_id}","starred_url":"https://api.github.com/users/grooverdan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grooverdan/subscriptions","organizations_url":"https://api.github.com/users/grooverdan/orgs","repos_url":"https://api.github.com/users/grooverdan/repos","events_url":"https://api.github.com/users/grooverdan/events{/privacy}","received_events_url":"https://api.github.com/users/grooverdan/received_events","type":"User","site_admin":false},"body":"from all the comments in #26 I've make a 10.1 PR here as, adding dependencies on systemd libs was problematic and socket activation was invasive.\r\n\r\nAdds optional compile option WITH_SYSTEMD to provide system functions\r\n\r\nDebian and Ubuntu packages include systemd libraries as dependencies\r\n\r\nmariadb-service-convert converts the [mysqld_safe] options into an\r\nequilivent systemd file which runs mysqld directly.\r\n\r\nmariadb-socket-convert takes the [mysqld] network and socket options\r\nand creates an equalivent mariadb.socket file.\r\n\r\nSystem service file can be either Type=notify or a socket activation.\r\n\r\nCompiling with systemd does not change any previous behaviour expected\r\nof mysqld.\r\n\r\nDevelopment funded by Open Source Developers Club (Australia)","created_at":"2015-07-11T05:50:40Z","updated_at":"2015-09-04T09:43:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e706e9f76ec21cb15f162c8933d94b6da6767cf9","assignee":{"login":"vuvova","id":2737648,"avatar_url":"https://avatars.githubusercontent.com/u/2737648?v=3","gravatar_id":"","url":"https://api.github.com/users/vuvova","html_url":"https://github.com/vuvova","followers_url":"https://api.github.com/users/vuvova/followers","following_url":"https://api.github.com/users/vuvova/following{/other_user}","gists_url":"https://api.github.com/users/vuvova/gists{/gist_id}","starred_url":"https://api.github.com/users/vuvova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vuvova/subscriptions","organizations_url":"https://api.github.com/users/vuvova/orgs","repos_url":"https://api.github.com/users/vuvova/repos","events_url":"https://api.github.com/users/vuvova/events{/privacy}","received_events_url":"https://api.github.com/users/vuvova/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/MariaDB/server/pulls/83/commits","review_comments_url":"https://api.github.com/repos/MariaDB/server/pulls/83/comments","review_comment_url":"https://api.github.com/repos/MariaDB/server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MariaDB/server/issues/83/comments","statuses_url":"https://api.github.com/repos/MariaDB/server/statuses/f7abb1d8cd97db4c1dfab3f5d7bc1d0da8d3b7c6","head":{"label":"openquery:MDEV-5536-systemd-socket-activation-notification-10.1_clean","ref":"MDEV-5536-systemd-socket-activation-notification-10.1_clean","sha":"f7abb1d8cd97db4c1dfab3f5d7bc1d0da8d3b7c6","user":{"login":"openquery","id":454132,"avatar_url":"https://avatars.githubusercontent.com/u/454132?v=3","gravatar_id":"","url":"https://api.github.com/users/openquery","html_url":"https://github.com/openquery","followers_url":"https://api.github.com/users/openquery/followers","following_url":"https://api.github.com/users/openquery/following{/other_user}","gists_url":"https://api.github.com/users/openquery/gists{/gist_id}","starred_url":"https://api.github.com/users/openquery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openquery/subscriptions","organizations_url":"https://api.github.com/users/openquery/orgs","repos_url":"https://api.github.com/users/openquery/repos","events_url":"https://api.github.com/users/openquery/events{/privacy}","received_events_url":"https://api.github.com/users/openquery/received_events","type":"Organization","site_admin":false},"repo":{"id":31842541,"name":"mariadb-server","full_name":"openquery/mariadb-server","owner":{"login":"openquery","id":454132,"avatar_url":"https://avatars.githubusercontent.com/u/454132?v=3","gravatar_id":"","url":"https://api.github.com/users/openquery","html_url":"https://github.com/openquery","followers_url":"https://api.github.com/users/openquery/followers","following_url":"https://api.github.com/users/openquery/following{/other_user}","gists_url":"https://api.github.com/users/openquery/gists{/gist_id}","starred_url":"https://api.github.com/users/openquery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openquery/subscriptions","organizations_url":"https://api.github.com/users/openquery/orgs","repos_url":"https://api.github.com/users/openquery/repos","events_url":"https://api.github.com/users/openquery/events{/privacy}","received_events_url":"https://api.github.com/users/openquery/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openquery/mariadb-server","description":"MariaDB server is a community developed fork of MySQL server. Started by core members of the original MySQL team, MariaDB actively works with outside developers to deliver the most featureful, stable, and sanely licensed open SQL server in the industry.","fork":true,"url":"https://api.github.com/repos/openquery/mariadb-server","forks_url":"https://api.github.com/repos/openquery/mariadb-server/forks","keys_url":"https://api.github.com/repos/openquery/mariadb-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openquery/mariadb-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openquery/mariadb-server/teams","hooks_url":"https://api.github.com/repos/openquery/mariadb-server/hooks","issue_events_url":"https://api.github.com/repos/openquery/mariadb-server/issues/events{/number}","events_url":"https://api.github.com/repos/openquery/mariadb-server/events","assignees_url":"https://api.github.com/repos/openquery/mariadb-server/assignees{/user}","branches_url":"https://api.github.com/repos/openquery/mariadb-server/branches{/branch}","tags_url":"https://api.github.com/repos/openquery/mariadb-server/tags","blobs_url":"https://api.github.com/repos/openquery/mariadb-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openquery/mariadb-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openquery/mariadb-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/openquery/mariadb-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openquery/mariadb-server/statuses/{sha}","languages_url":"https://api.github.com/repos/openquery/mariadb-server/languages","stargazers_url":"https://api.github.com/repos/openquery/mariadb-server/stargazers","contributors_url":"https://api.github.com/repos/openquery/mariadb-server/contributors","subscribers_url":"https://api.github.com/repos/openquery/mariadb-server/subscribers","subscription_url":"https://api.github.com/repos/openquery/mariadb-server/subscription","commits_url":"https://api.github.com/repos/openquery/mariadb-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/openquery/mariadb-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/openquery/mariadb-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/openquery/mariadb-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/openquery/mariadb-server/contents/{+path}","compare_url":"https://api.github.com/repos/openquery/mariadb-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openquery/mariadb-server/merges","archive_url":"https://api.github.com/repos/openquery/mariadb-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openquery/mariadb-server/downloads","issues_url":"https://api.github.com/repos/openquery/mariadb-server/issues{/number}","pulls_url":"https://api.github.com/repos/openquery/mariadb-server/pulls{/number}","milestones_url":"https://api.github.com/repos/openquery/mariadb-server/milestones{/number}","notifications_url":"https://api.github.com/repos/openquery/mariadb-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openquery/mariadb-server/labels{/name}","releases_url":"https://api.github.com/repos/openquery/mariadb-server/releases{/id}","created_at":"2015-03-08T07:53:45Z","updated_at":"2015-05-01T08:16:57Z","pushed_at":"2015-08-08T12:29:31Z","git_url":"git://github.com/openquery/mariadb-server.git","ssh_url":"git@github.com:openquery/mariadb-server.git","clone_url":"https://github.com/openquery/mariadb-server.git","svn_url":"https://github.com/openquery/mariadb-server","homepage":"","size":358741,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"10.0"}},"base":{"label":"MariaDB:10.1","ref":"10.1","sha":"35a019837e0290af45962484b4ddc1d6a92ac654","user":{"login":"MariaDB","id":4739304,"avatar_url":"https://avatars.githubusercontent.com/u/4739304?v=3","gravatar_id":"","url":"https://api.github.com/users/MariaDB","html_url":"https://github.com/MariaDB","followers_url":"https://api.github.com/users/MariaDB/followers","following_url":"https://api.github.com/users/MariaDB/following{/other_user}","gists_url":"https://api.github.com/users/MariaDB/gists{/gist_id}","starred_url":"https://api.github.com/users/MariaDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MariaDB/subscriptions","organizations_url":"https://api.github.com/users/MariaDB/orgs","repos_url":"https://api.github.com/users/MariaDB/repos","events_url":"https://api.github.com/users/MariaDB/events{/privacy}","received_events_url":"https://api.github.com/users/MariaDB/received_events","type":"Organization","site_admin":false},"repo":{"id":19816070,"name":"server","full_name":"MariaDB/server","owner":{"login":"MariaDB","id":4739304,"avatar_url":"https://avatars.githubusercontent.com/u/4739304?v=3","gravatar_id":"","url":"https://api.github.com/users/MariaDB","html_url":"https://github.com/MariaDB","followers_url":"https://api.github.com/users/MariaDB/followers","following_url":"https://api.github.com/users/MariaDB/following{/other_user}","gists_url":"https://api.github.com/users/MariaDB/gists{/gist_id}","starred_url":"https://api.github.com/users/MariaDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MariaDB/subscriptions","organizations_url":"https://api.github.com/users/MariaDB/orgs","repos_url":"https://api.github.com/users/MariaDB/repos","events_url":"https://api.github.com/users/MariaDB/events{/privacy}","received_events_url":"https://api.github.com/users/MariaDB/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MariaDB/server","description":"MariaDB server is a community developed fork of MySQL server. Started by core members of the original MySQL team, MariaDB actively works with outside developers to deliver the most featureful, stable, and sanely licensed open SQL server in the industry.","fork":false,"url":"https://api.github.com/repos/MariaDB/server","forks_url":"https://api.github.com/repos/MariaDB/server/forks","keys_url":"https://api.github.com/repos/MariaDB/server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MariaDB/server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MariaDB/server/teams","hooks_url":"https://api.github.com/repos/MariaDB/server/hooks","issue_events_url":"https://api.github.com/repos/MariaDB/server/issues/events{/number}","events_url":"https://api.github.com/repos/MariaDB/server/events","assignees_url":"https://api.github.com/repos/MariaDB/server/assignees{/user}","branches_url":"https://api.github.com/repos/MariaDB/server/branches{/branch}","tags_url":"https://api.github.com/repos/MariaDB/server/tags","blobs_url":"https://api.github.com/repos/MariaDB/server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MariaDB/server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MariaDB/server/git/refs{/sha}","trees_url":"https://api.github.com/repos/MariaDB/server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MariaDB/server/statuses/{sha}","languages_url":"https://api.github.com/repos/MariaDB/server/languages","stargazers_url":"https://api.github.com/repos/MariaDB/server/stargazers","contributors_url":"https://api.github.com/repos/MariaDB/server/contributors","subscribers_url":"https://api.github.com/repos/MariaDB/server/subscribers","subscription_url":"https://api.github.com/repos/MariaDB/server/subscription","commits_url":"https://api.github.com/repos/MariaDB/server/commits{/sha}","git_commits_url":"https://api.github.com/repos/MariaDB/server/git/commits{/sha}","comments_url":"https://api.github.com/repos/MariaDB/server/comments{/number}","issue_comment_url":"https://api.github.com/repos/MariaDB/server/issues/comments{/number}","contents_url":"https://api.github.com/repos/MariaDB/server/contents/{+path}","compare_url":"https://api.github.com/repos/MariaDB/server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MariaDB/server/merges","archive_url":"https://api.github.com/repos/MariaDB/server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MariaDB/server/downloads","issues_url":"https://api.github.com/repos/MariaDB/server/issues{/number}","pulls_url":"https://api.github.com/repos/MariaDB/server/pulls{/number}","milestones_url":"https://api.github.com/repos/MariaDB/server/milestones{/number}","notifications_url":"https://api.github.com/repos/MariaDB/server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MariaDB/server/labels{/name}","releases_url":"https://api.github.com/repos/MariaDB/server/releases{/id}","created_at":"2014-05-15T10:58:50Z","updated_at":"2015-09-01T13:07:35Z","pushed_at":"2015-09-04T09:40:18Z","git_url":"git://github.com/MariaDB/server.git","ssh_url":"git@github.com:MariaDB/server.git","clone_url":"https://github.com/MariaDB/server.git","svn_url":"https://github.com/MariaDB/server","homepage":"","size":1399497,"stargazers_count":557,"watchers_count":557,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":144,"mirror_url":null,"open_issues_count":29,"forks":144,"open_issues":29,"watchers":557,"default_branch":"10.1"}},"_links":{"self":{"href":"https://api.github.com/repos/MariaDB/server/pulls/83"},"html":{"href":"https://github.com/MariaDB/server/pull/83"},"issue":{"href":"https://api.github.com/repos/MariaDB/server/issues/83"},"comments":{"href":"https://api.github.com/repos/MariaDB/server/issues/83/comments"},"review_comments":{"href":"https://api.github.com/repos/MariaDB/server/pulls/83/comments"},"review_comment":{"href":"https://api.github.com/repos/MariaDB/server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MariaDB/server/pulls/83/commits"},"statuses":{"href":"https://api.github.com/repos/MariaDB/server/statuses/f7abb1d8cd97db4c1dfab3f5d7bc1d0da8d3b7c6"}}}}