{"action":"created","comment":{"url":"https://api.github.com/repos/uber/ringpop/pulls/comments/29605308","id":29605308,"diff_hunk":"@@ -0,0 +1,25 @@\n+struct Change {\n+    1: required string source;\n+    2: required string address;\n+    3: required string status;\n+    4: required double incarnationNumber;\n+}\n+\n+struct JoinResult {\n+    1: required list<Change> changes;\n+}\n+\n+struct PingResult {\n+    1: required list<Change> changes;\n+}\n+\n+struct PingReqResult {\n+    1: required bool pingStatus;\n+    2: required list<Change> changes;\n+}\n+\n+service Ringpop {\n+    JoinResult join(1:string app, 2:string source, 3:double incarnationNumber);\n+    PingResult ping(1:double checksum, 2:list<Change> changes);","path":"ringpop.thrift","position":23,"original_position":23,"commit_id":"52d992495f92e440226c8a4470d9088c5788ea1f","original_commit_id":"52d992495f92e440226c8a4470d9088c5788ea1f","user":{"login":"leizha","id":8961794,"avatar_url":"https://avatars.githubusercontent.com/u/8961794?v=3","gravatar_id":"","url":"https://api.github.com/users/leizha","html_url":"https://github.com/leizha","followers_url":"https://api.github.com/users/leizha/followers","following_url":"https://api.github.com/users/leizha/following{/other_user}","gists_url":"https://api.github.com/users/leizha/gists{/gist_id}","starred_url":"https://api.github.com/users/leizha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leizha/subscriptions","organizations_url":"https://api.github.com/users/leizha/orgs","repos_url":"https://api.github.com/users/leizha/repos","events_url":"https://api.github.com/users/leizha/events{/privacy}","received_events_url":"https://api.github.com/users/leizha/received_events","type":"User","site_admin":false},"body":"how is `checksum` calculated? why is it a double?\r\n\r\nequal check of double type just seems strange to me. I'm not sure how reliable it is when used across languages or platforms.","created_at":"2015-05-04T17:44:21Z","updated_at":"2015-05-04T17:44:21Z","html_url":"https://github.com/uber/ringpop/pull/76#discussion_r29605308","pull_request_url":"https://api.github.com/repos/uber/ringpop/pulls/76","_links":{"self":{"href":"https://api.github.com/repos/uber/ringpop/pulls/comments/29605308"},"html":{"href":"https://github.com/uber/ringpop/pull/76#discussion_r29605308"},"pull_request":{"href":"https://api.github.com/repos/uber/ringpop/pulls/76"}}},"pull_request":{"url":"https://api.github.com/repos/uber/ringpop/pulls/76","id":34432286,"html_url":"https://github.com/uber/ringpop/pull/76","diff_url":"https://github.com/uber/ringpop/pull/76.diff","patch_url":"https://github.com/uber/ringpop/pull/76.patch","issue_url":"https://api.github.com/repos/uber/ringpop/issues/76","number":76,"state":"open","locked":false,"title":"Thrift","user":{"login":"jwolski","id":16902,"avatar_url":"https://avatars.githubusercontent.com/u/16902?v=3","gravatar_id":"","url":"https://api.github.com/users/jwolski","html_url":"https://github.com/jwolski","followers_url":"https://api.github.com/users/jwolski/followers","following_url":"https://api.github.com/users/jwolski/following{/other_user}","gists_url":"https://api.github.com/users/jwolski/gists{/gist_id}","starred_url":"https://api.github.com/users/jwolski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwolski/subscriptions","organizations_url":"https://api.github.com/users/jwolski/orgs","repos_url":"https://api.github.com/users/jwolski/repos","events_url":"https://api.github.com/users/jwolski/events{/privacy}","received_events_url":"https://api.github.com/users/jwolski/received_events","type":"User","site_admin":false},"body":"This is no longer a work in progress and is ready for general review. I suspect that there may be further updates to the Ringpop Thrift definition, but this is good enough for some eyes.\r\n\r\nAs a part of this effort, I attempted to clean up the gossip protocol by removing some fields that were exchanged but unnecessary. That is why you may see more churn that you were expecting. The bulk of the actual Thrift integration centers around `lib/tchannel.js`\r\n@kriskowal @leizha @Raynos @mrhooray ","created_at":"2015-04-30T06:41:58Z","updated_at":"2015-05-04T17:44:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0d220a09c528e00174de750520ae4da976838b8b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/uber/ringpop/pulls/76/commits","review_comments_url":"https://api.github.com/repos/uber/ringpop/pulls/76/comments","review_comment_url":"https://api.github.com/repos/uber/ringpop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uber/ringpop/issues/76/comments","statuses_url":"https://api.github.com/repos/uber/ringpop/statuses/52d992495f92e440226c8a4470d9088c5788ea1f","head":{"label":"uber:thrift","ref":"thrift","sha":"52d992495f92e440226c8a4470d9088c5788ea1f","user":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"repo":{"id":29378455,"name":"ringpop","full_name":"uber/ringpop","owner":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uber/ringpop","description":"Scalable, fault-tolerant application-layer sharding","fork":false,"url":"https://api.github.com/repos/uber/ringpop","forks_url":"https://api.github.com/repos/uber/ringpop/forks","keys_url":"https://api.github.com/repos/uber/ringpop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber/ringpop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber/ringpop/teams","hooks_url":"https://api.github.com/repos/uber/ringpop/hooks","issue_events_url":"https://api.github.com/repos/uber/ringpop/issues/events{/number}","events_url":"https://api.github.com/repos/uber/ringpop/events","assignees_url":"https://api.github.com/repos/uber/ringpop/assignees{/user}","branches_url":"https://api.github.com/repos/uber/ringpop/branches{/branch}","tags_url":"https://api.github.com/repos/uber/ringpop/tags","blobs_url":"https://api.github.com/repos/uber/ringpop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber/ringpop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber/ringpop/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber/ringpop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber/ringpop/statuses/{sha}","languages_url":"https://api.github.com/repos/uber/ringpop/languages","stargazers_url":"https://api.github.com/repos/uber/ringpop/stargazers","contributors_url":"https://api.github.com/repos/uber/ringpop/contributors","subscribers_url":"https://api.github.com/repos/uber/ringpop/subscribers","subscription_url":"https://api.github.com/repos/uber/ringpop/subscription","commits_url":"https://api.github.com/repos/uber/ringpop/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber/ringpop/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber/ringpop/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber/ringpop/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber/ringpop/contents/{+path}","compare_url":"https://api.github.com/repos/uber/ringpop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber/ringpop/merges","archive_url":"https://api.github.com/repos/uber/ringpop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber/ringpop/downloads","issues_url":"https://api.github.com/repos/uber/ringpop/issues{/number}","pulls_url":"https://api.github.com/repos/uber/ringpop/pulls{/number}","milestones_url":"https://api.github.com/repos/uber/ringpop/milestones{/number}","notifications_url":"https://api.github.com/repos/uber/ringpop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber/ringpop/labels{/name}","releases_url":"https://api.github.com/repos/uber/ringpop/releases{/id}","created_at":"2015-01-17T03:26:35Z","updated_at":"2015-05-03T00:40:58Z","pushed_at":"2015-05-03T21:35:47Z","git_url":"git://github.com/uber/ringpop.git","ssh_url":"git@github.com:uber/ringpop.git","clone_url":"https://github.com/uber/ringpop.git","svn_url":"https://github.com/uber/ringpop","homepage":"","size":3314,"stargazers_count":78,"watchers_count":78,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":18,"forks":1,"open_issues":18,"watchers":78,"default_branch":"master"}},"base":{"label":"uber:tchannel-beta6","ref":"tchannel-beta6","sha":"19cb2d2539074fcebcd2983315c749dcebb515c6","user":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"repo":{"id":29378455,"name":"ringpop","full_name":"uber/ringpop","owner":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uber/ringpop","description":"Scalable, fault-tolerant application-layer sharding","fork":false,"url":"https://api.github.com/repos/uber/ringpop","forks_url":"https://api.github.com/repos/uber/ringpop/forks","keys_url":"https://api.github.com/repos/uber/ringpop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber/ringpop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber/ringpop/teams","hooks_url":"https://api.github.com/repos/uber/ringpop/hooks","issue_events_url":"https://api.github.com/repos/uber/ringpop/issues/events{/number}","events_url":"https://api.github.com/repos/uber/ringpop/events","assignees_url":"https://api.github.com/repos/uber/ringpop/assignees{/user}","branches_url":"https://api.github.com/repos/uber/ringpop/branches{/branch}","tags_url":"https://api.github.com/repos/uber/ringpop/tags","blobs_url":"https://api.github.com/repos/uber/ringpop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber/ringpop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber/ringpop/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber/ringpop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber/ringpop/statuses/{sha}","languages_url":"https://api.github.com/repos/uber/ringpop/languages","stargazers_url":"https://api.github.com/repos/uber/ringpop/stargazers","contributors_url":"https://api.github.com/repos/uber/ringpop/contributors","subscribers_url":"https://api.github.com/repos/uber/ringpop/subscribers","subscription_url":"https://api.github.com/repos/uber/ringpop/subscription","commits_url":"https://api.github.com/repos/uber/ringpop/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber/ringpop/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber/ringpop/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber/ringpop/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber/ringpop/contents/{+path}","compare_url":"https://api.github.com/repos/uber/ringpop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber/ringpop/merges","archive_url":"https://api.github.com/repos/uber/ringpop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber/ringpop/downloads","issues_url":"https://api.github.com/repos/uber/ringpop/issues{/number}","pulls_url":"https://api.github.com/repos/uber/ringpop/pulls{/number}","milestones_url":"https://api.github.com/repos/uber/ringpop/milestones{/number}","notifications_url":"https://api.github.com/repos/uber/ringpop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber/ringpop/labels{/name}","releases_url":"https://api.github.com/repos/uber/ringpop/releases{/id}","created_at":"2015-01-17T03:26:35Z","updated_at":"2015-05-03T00:40:58Z","pushed_at":"2015-05-03T21:35:47Z","git_url":"git://github.com/uber/ringpop.git","ssh_url":"git@github.com:uber/ringpop.git","clone_url":"https://github.com/uber/ringpop.git","svn_url":"https://github.com/uber/ringpop","homepage":"","size":3314,"stargazers_count":78,"watchers_count":78,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":18,"forks":1,"open_issues":18,"watchers":78,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uber/ringpop/pulls/76"},"html":{"href":"https://github.com/uber/ringpop/pull/76"},"issue":{"href":"https://api.github.com/repos/uber/ringpop/issues/76"},"comments":{"href":"https://api.github.com/repos/uber/ringpop/issues/76/comments"},"review_comments":{"href":"https://api.github.com/repos/uber/ringpop/pulls/76/comments"},"review_comment":{"href":"https://api.github.com/repos/uber/ringpop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uber/ringpop/pulls/76/commits"},"statuses":{"href":"https://api.github.com/repos/uber/ringpop/statuses/52d992495f92e440226c8a4470d9088c5788ea1f"}}}}