{"action":"created","comment":{"url":"https://api.github.com/repos/OpenMW/openmw/pulls/comments/37750654","id":37750654,"diff_hunk":"@@ -0,0 +1,47 @@\n+#ifndef GAME_MWCLASS_MOBILE_H\n+#define GAME_MWCLASS_MOBILE_H\n+\n+#include \"../mwworld/class.hpp\"\n+\n+namespace ESM\n+{\n+    struct GameSetting;\n+}\n+\n+namespace MWClass\n+{\n+    /// \\brief Class holding functionality common to Creature and NPC\n+    class Mobile : public MWWorld::Class\n+    {\n+    protected:\n+\n+        Mobile();\n+\n+    public:\n+        ~Mobile();","path":"apps/openmw/mwclass/mobile.hpp","position":21,"original_position":21,"commit_id":"bb54bbd2736d8440e639066bc459ec56173786de","original_commit_id":"bb54bbd2736d8440e639066bc459ec56173786de","user":{"login":"jeaye","id":1057635,"avatar_url":"https://avatars.githubusercontent.com/u/1057635?v=3","gravatar_id":"","url":"https://api.github.com/users/jeaye","html_url":"https://github.com/jeaye","followers_url":"https://api.github.com/users/jeaye/followers","following_url":"https://api.github.com/users/jeaye/following{/other_user}","gists_url":"https://api.github.com/users/jeaye/gists{/gist_id}","starred_url":"https://api.github.com/users/jeaye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeaye/subscriptions","organizations_url":"https://api.github.com/users/jeaye/orgs","repos_url":"https://api.github.com/users/jeaye/repos","events_url":"https://api.github.com/users/jeaye/events{/privacy}","received_events_url":"https://api.github.com/users/jeaye/received_events","type":"User","site_admin":false},"body":"On Mon, Aug 24, 2015 at 06:27:32AM -0700, Marc Zinnschlag wrote:\n>    The destructor is virtual, because the Class destructor is virtual. But\n>    yes, for the sake of clarity and consistency the destructor should be\n>    marked as virtual. I guess that's what you meant?\n\nOf course it's currently virtual, due to the base class' dtor being virtual. By \"future-proofing\" I mean marking it virtual so that, if the base class is ever changed/removed, we don't end up with broken dtors.\n\nTrying to save our future selves.\n","created_at":"2015-08-24T13:31:19Z","updated_at":"2015-08-24T13:31:19Z","html_url":"https://github.com/OpenMW/openmw/pull/745#discussion_r37750654","pull_request_url":"https://api.github.com/repos/OpenMW/openmw/pulls/745","_links":{"self":{"href":"https://api.github.com/repos/OpenMW/openmw/pulls/comments/37750654"},"html":{"href":"https://github.com/OpenMW/openmw/pull/745#discussion_r37750654"},"pull_request":{"href":"https://api.github.com/repos/OpenMW/openmw/pulls/745"}}},"pull_request":{"url":"https://api.github.com/repos/OpenMW/openmw/pulls/745","id":43148536,"html_url":"https://github.com/OpenMW/openmw/pull/745","diff_url":"https://github.com/OpenMW/openmw/pull/745.diff","patch_url":"https://github.com/OpenMW/openmw/pull/745.patch","issue_url":"https://api.github.com/repos/OpenMW/openmw/issues/745","number":745,"state":"open","locked":false,"title":"Pulled duplicated functions into common base class","user":{"login":"dteviot","id":5157081,"avatar_url":"https://avatars.githubusercontent.com/u/5157081?v=3","gravatar_id":"","url":"https://api.github.com/users/dteviot","html_url":"https://github.com/dteviot","followers_url":"https://api.github.com/users/dteviot/followers","following_url":"https://api.github.com/users/dteviot/following{/other_user}","gists_url":"https://api.github.com/users/dteviot/gists{/gist_id}","starred_url":"https://api.github.com/users/dteviot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dteviot/subscriptions","organizations_url":"https://api.github.com/users/dteviot/orgs","repos_url":"https://api.github.com/users/dteviot/repos","events_url":"https://api.github.com/users/dteviot/events{/privacy}","received_events_url":"https://api.github.com/users/dteviot/received_events","type":"User","site_admin":false},"body":"Factoring out common code from Npc and Creature into base class.\r\nThis is just starting with the functions that are the same.\r\nI thought I'd start with them and see what Scrawl & Zini think before I put in any more work.\r\n\r\nThere's obviously more that can be done.  e.g. getSpeed() , onHit(). etc.\r\n","created_at":"2015-08-24T07:57:32Z","updated_at":"2015-08-24T13:31:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4517e1db7bc6455e0b7af72cc9e91db327d2c926","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/OpenMW/openmw/pulls/745/commits","review_comments_url":"https://api.github.com/repos/OpenMW/openmw/pulls/745/comments","review_comment_url":"https://api.github.com/repos/OpenMW/openmw/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenMW/openmw/issues/745/comments","statuses_url":"https://api.github.com/repos/OpenMW/openmw/statuses/bb54bbd2736d8440e639066bc459ec56173786de","head":{"label":"dteviot:ExtractCommonCreatureDraft","ref":"ExtractCommonCreatureDraft","sha":"bb54bbd2736d8440e639066bc459ec56173786de","user":{"login":"dteviot","id":5157081,"avatar_url":"https://avatars.githubusercontent.com/u/5157081?v=3","gravatar_id":"","url":"https://api.github.com/users/dteviot","html_url":"https://github.com/dteviot","followers_url":"https://api.github.com/users/dteviot/followers","following_url":"https://api.github.com/users/dteviot/following{/other_user}","gists_url":"https://api.github.com/users/dteviot/gists{/gist_id}","starred_url":"https://api.github.com/users/dteviot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dteviot/subscriptions","organizations_url":"https://api.github.com/users/dteviot/orgs","repos_url":"https://api.github.com/users/dteviot/repos","events_url":"https://api.github.com/users/dteviot/events{/privacy}","received_events_url":"https://api.github.com/users/dteviot/received_events","type":"User","site_admin":false},"repo":{"id":27283529,"name":"openmw","full_name":"dteviot/openmw","owner":{"login":"dteviot","id":5157081,"avatar_url":"https://avatars.githubusercontent.com/u/5157081?v=3","gravatar_id":"","url":"https://api.github.com/users/dteviot","html_url":"https://github.com/dteviot","followers_url":"https://api.github.com/users/dteviot/followers","following_url":"https://api.github.com/users/dteviot/following{/other_user}","gists_url":"https://api.github.com/users/dteviot/gists{/gist_id}","starred_url":"https://api.github.com/users/dteviot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dteviot/subscriptions","organizations_url":"https://api.github.com/users/dteviot/orgs","repos_url":"https://api.github.com/users/dteviot/repos","events_url":"https://api.github.com/users/dteviot/events{/privacy}","received_events_url":"https://api.github.com/users/dteviot/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dteviot/openmw","description":"OpenMW is an unofficial open source engine reimplementation of the game Morrowind.","fork":true,"url":"https://api.github.com/repos/dteviot/openmw","forks_url":"https://api.github.com/repos/dteviot/openmw/forks","keys_url":"https://api.github.com/repos/dteviot/openmw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dteviot/openmw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dteviot/openmw/teams","hooks_url":"https://api.github.com/repos/dteviot/openmw/hooks","issue_events_url":"https://api.github.com/repos/dteviot/openmw/issues/events{/number}","events_url":"https://api.github.com/repos/dteviot/openmw/events","assignees_url":"https://api.github.com/repos/dteviot/openmw/assignees{/user}","branches_url":"https://api.github.com/repos/dteviot/openmw/branches{/branch}","tags_url":"https://api.github.com/repos/dteviot/openmw/tags","blobs_url":"https://api.github.com/repos/dteviot/openmw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dteviot/openmw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dteviot/openmw/git/refs{/sha}","trees_url":"https://api.github.com/repos/dteviot/openmw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dteviot/openmw/statuses/{sha}","languages_url":"https://api.github.com/repos/dteviot/openmw/languages","stargazers_url":"https://api.github.com/repos/dteviot/openmw/stargazers","contributors_url":"https://api.github.com/repos/dteviot/openmw/contributors","subscribers_url":"https://api.github.com/repos/dteviot/openmw/subscribers","subscription_url":"https://api.github.com/repos/dteviot/openmw/subscription","commits_url":"https://api.github.com/repos/dteviot/openmw/commits{/sha}","git_commits_url":"https://api.github.com/repos/dteviot/openmw/git/commits{/sha}","comments_url":"https://api.github.com/repos/dteviot/openmw/comments{/number}","issue_comment_url":"https://api.github.com/repos/dteviot/openmw/issues/comments{/number}","contents_url":"https://api.github.com/repos/dteviot/openmw/contents/{+path}","compare_url":"https://api.github.com/repos/dteviot/openmw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dteviot/openmw/merges","archive_url":"https://api.github.com/repos/dteviot/openmw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dteviot/openmw/downloads","issues_url":"https://api.github.com/repos/dteviot/openmw/issues{/number}","pulls_url":"https://api.github.com/repos/dteviot/openmw/pulls{/number}","milestones_url":"https://api.github.com/repos/dteviot/openmw/milestones{/number}","notifications_url":"https://api.github.com/repos/dteviot/openmw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dteviot/openmw/labels{/name}","releases_url":"https://api.github.com/repos/dteviot/openmw/releases{/id}","created_at":"2014-11-28T22:02:05Z","updated_at":"2015-05-03T20:24:28Z","pushed_at":"2015-08-24T07:54:31Z","git_url":"git://github.com/dteviot/openmw.git","ssh_url":"git@github.com:dteviot/openmw.git","clone_url":"https://github.com/dteviot/openmw.git","svn_url":"https://github.com/dteviot/openmw","homepage":"http://www.openmw.org/","size":47961,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OpenMW:master","ref":"master","sha":"e76401d5eaf16fa752d94019449d81f788bbaf8c","user":{"login":"OpenMW","id":6727417,"avatar_url":"https://avatars.githubusercontent.com/u/6727417?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenMW","html_url":"https://github.com/OpenMW","followers_url":"https://api.github.com/users/OpenMW/followers","following_url":"https://api.github.com/users/OpenMW/following{/other_user}","gists_url":"https://api.github.com/users/OpenMW/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenMW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenMW/subscriptions","organizations_url":"https://api.github.com/users/OpenMW/orgs","repos_url":"https://api.github.com/users/OpenMW/repos","events_url":"https://api.github.com/users/OpenMW/events{/privacy}","received_events_url":"https://api.github.com/users/OpenMW/received_events","type":"Organization","site_admin":false},"repo":{"id":285722,"name":"openmw","full_name":"OpenMW/openmw","owner":{"login":"OpenMW","id":6727417,"avatar_url":"https://avatars.githubusercontent.com/u/6727417?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenMW","html_url":"https://github.com/OpenMW","followers_url":"https://api.github.com/users/OpenMW/followers","following_url":"https://api.github.com/users/OpenMW/following{/other_user}","gists_url":"https://api.github.com/users/OpenMW/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenMW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenMW/subscriptions","organizations_url":"https://api.github.com/users/OpenMW/orgs","repos_url":"https://api.github.com/users/OpenMW/repos","events_url":"https://api.github.com/users/OpenMW/events{/privacy}","received_events_url":"https://api.github.com/users/OpenMW/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenMW/openmw","description":"OpenMW is an unofficial open source engine reimplementation of the game Morrowind.","fork":false,"url":"https://api.github.com/repos/OpenMW/openmw","forks_url":"https://api.github.com/repos/OpenMW/openmw/forks","keys_url":"https://api.github.com/repos/OpenMW/openmw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenMW/openmw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenMW/openmw/teams","hooks_url":"https://api.github.com/repos/OpenMW/openmw/hooks","issue_events_url":"https://api.github.com/repos/OpenMW/openmw/issues/events{/number}","events_url":"https://api.github.com/repos/OpenMW/openmw/events","assignees_url":"https://api.github.com/repos/OpenMW/openmw/assignees{/user}","branches_url":"https://api.github.com/repos/OpenMW/openmw/branches{/branch}","tags_url":"https://api.github.com/repos/OpenMW/openmw/tags","blobs_url":"https://api.github.com/repos/OpenMW/openmw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenMW/openmw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenMW/openmw/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenMW/openmw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenMW/openmw/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenMW/openmw/languages","stargazers_url":"https://api.github.com/repos/OpenMW/openmw/stargazers","contributors_url":"https://api.github.com/repos/OpenMW/openmw/contributors","subscribers_url":"https://api.github.com/repos/OpenMW/openmw/subscribers","subscription_url":"https://api.github.com/repos/OpenMW/openmw/subscription","commits_url":"https://api.github.com/repos/OpenMW/openmw/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenMW/openmw/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenMW/openmw/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenMW/openmw/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenMW/openmw/contents/{+path}","compare_url":"https://api.github.com/repos/OpenMW/openmw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenMW/openmw/merges","archive_url":"https://api.github.com/repos/OpenMW/openmw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenMW/openmw/downloads","issues_url":"https://api.github.com/repos/OpenMW/openmw/issues{/number}","pulls_url":"https://api.github.com/repos/OpenMW/openmw/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenMW/openmw/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenMW/openmw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenMW/openmw/labels{/name}","releases_url":"https://api.github.com/repos/OpenMW/openmw/releases{/id}","created_at":"2009-08-23T14:46:21Z","updated_at":"2015-08-24T04:48:07Z","pushed_at":"2015-08-24T13:02:13Z","git_url":"git://github.com/OpenMW/openmw.git","ssh_url":"git@github.com:OpenMW/openmw.git","clone_url":"https://github.com/OpenMW/openmw.git","svn_url":"https://github.com/OpenMW/openmw","homepage":"http://www.openmw.org/","size":61260,"stargazers_count":710,"watchers_count":710,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":378,"mirror_url":null,"open_issues_count":10,"forks":378,"open_issues":10,"watchers":710,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenMW/openmw/pulls/745"},"html":{"href":"https://github.com/OpenMW/openmw/pull/745"},"issue":{"href":"https://api.github.com/repos/OpenMW/openmw/issues/745"},"comments":{"href":"https://api.github.com/repos/OpenMW/openmw/issues/745/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenMW/openmw/pulls/745/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenMW/openmw/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenMW/openmw/pulls/745/commits"},"statuses":{"href":"https://api.github.com/repos/OpenMW/openmw/statuses/bb54bbd2736d8440e639066bc459ec56173786de"}}}}