{"action":"created","comment":{"url":"https://api.github.com/repos/azkaban/azkaban/pulls/comments/38972544","id":38972544,"diff_hunk":"@@ -539,80 +853,97 @@ private void applyDisabledJobs(List<Object> disabledJobs,\n \n   @Override\n   public String submitExecutableFlow(ExecutableFlow exflow, String userId)\n-      throws ExecutorManagerException {\n+    throws ExecutorManagerException {\n     synchronized (exflow) {\n-      logger.info(\"Submitting execution flow \" + exflow.getFlowId() + \" by \"\n-          + userId);\n-\n-      int projectId = exflow.getProjectId();\n       String flowId = exflow.getFlowId();\n-      exflow.setSubmitUser(userId);\n-      exflow.setSubmitTime(System.currentTimeMillis());\n \n-      List<Integer> running = getRunningFlows(projectId, flowId);\n-\n-      ExecutionOptions options = exflow.getExecutionOptions();\n-      if (options == null) {\n-        options = new ExecutionOptions();\n-      }\n+      logger.info(\"Submitting execution flow \" + flowId + \" by \" + userId);\n \n       String message = \"\";\n-      if (options.getDisabledJobs() != null) {\n-        applyDisabledJobs(options.getDisabledJobs(), exflow);\n-      }\n+      if (queuedFlows.isFull()) {\n+        message =","path":"azkaban-common/src/main/java/azkaban/executor/ExecutorManager.java","position":539,"original_position":539,"commit_id":"b835d0ec594bd8ee42ddb2933276feda7c5919dc","original_commit_id":"b835d0ec594bd8ee42ddb2933276feda7c5919dc","user":{"login":"hluu","id":533460,"avatar_url":"https://avatars.githubusercontent.com/u/533460?v=3","gravatar_id":"","url":"https://api.github.com/users/hluu","html_url":"https://github.com/hluu","followers_url":"https://api.github.com/users/hluu/followers","following_url":"https://api.github.com/users/hluu/following{/other_user}","gists_url":"https://api.github.com/users/hluu/gists{/gist_id}","starred_url":"https://api.github.com/users/hluu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hluu/subscriptions","organizations_url":"https://api.github.com/users/hluu/orgs","repos_url":"https://api.github.com/users/hluu/repos","events_url":"https://api.github.com/users/hluu/events{/privacy}","received_events_url":"https://api.github.com/users/hluu/received_events","type":"User","site_admin":false},"body":"If it is a manual submit, how can we report this error back to user?","created_at":"2015-09-08T20:02:00Z","updated_at":"2015-09-08T20:02:00Z","html_url":"https://github.com/azkaban/azkaban/pull/478#discussion_r38972544","pull_request_url":"https://api.github.com/repos/azkaban/azkaban/pulls/478","_links":{"self":{"href":"https://api.github.com/repos/azkaban/azkaban/pulls/comments/38972544"},"html":{"href":"https://github.com/azkaban/azkaban/pull/478#discussion_r38972544"},"pull_request":{"href":"https://api.github.com/repos/azkaban/azkaban/pulls/478"}}},"pull_request":{"url":"https://api.github.com/repos/azkaban/azkaban/pulls/478","id":43915905,"html_url":"https://github.com/azkaban/azkaban/pull/478","diff_url":"https://github.com/azkaban/azkaban/pull/478.diff","patch_url":"https://github.com/azkaban/azkaban/pull/478.patch","issue_url":"https://api.github.com/repos/azkaban/azkaban/issues/478","number":478,"state":"open","locked":false,"title":"AzkabanWebServer Modifications to support MultiExecutors","user":{"login":"logiclord","id":770329,"avatar_url":"https://avatars.githubusercontent.com/u/770329?v=3","gravatar_id":"","url":"https://api.github.com/users/logiclord","html_url":"https://github.com/logiclord","followers_url":"https://api.github.com/users/logiclord/followers","following_url":"https://api.github.com/users/logiclord/following{/other_user}","gists_url":"https://api.github.com/users/logiclord/gists{/gist_id}","starred_url":"https://api.github.com/users/logiclord/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/logiclord/subscriptions","organizations_url":"https://api.github.com/users/logiclord/orgs","repos_url":"https://api.github.com/users/logiclord/repos","events_url":"https://api.github.com/users/logiclord/events{/privacy}","received_events_url":"https://api.github.com/users/logiclord/received_events","type":"User","site_admin":false},"body":"* Added QueueProcessorThread to do the real dispatching and refreshing Executor stats\r\n  * JMX attributes added to /jmx servlet\r\n  * Pause and resume features\r\n  * Refreshing and basic queue processing to execute flows\r\n* Changes in executor manager to correct all existing methods and new methods to deal with deal with multiple executors\r\n* New methods in JDBCExecutorLoader to support the notion of queued flows.\r\n* Added functionality to make queued flows recoverable, now we can bounce webserver without loosing any flow queued at webserver side.\r\n* Modified Stats servlet and coresponding APIs to add executor option\r\n* Display executor_id on executions page\r\n* Cancel a flow which is not yet dispatched to any executor\r\n* DB modification scripts\r\n\r\nState representation in DB:\r\nQueued flow: This will have an entry in execution_flows table with NULL value for executor_id (i.e. not yet assigned) and will have have an entry in active_executing_flows\r\nRunning flow: This will have an entry in execution_flows table with the responsible executor its exxecuting and will have have also have an entry in active_executing_flows","created_at":"2015-09-01T19:25:35Z","updated_at":"2015-09-08T20:02:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6971d0071bac5b0c5f67d9107562799001d94c8a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/azkaban/azkaban/pulls/478/commits","review_comments_url":"https://api.github.com/repos/azkaban/azkaban/pulls/478/comments","review_comment_url":"https://api.github.com/repos/azkaban/azkaban/pulls/comments{/number}","comments_url":"https://api.github.com/repos/azkaban/azkaban/issues/478/comments","statuses_url":"https://api.github.com/repos/azkaban/azkaban/statuses/b835d0ec594bd8ee42ddb2933276feda7c5919dc","head":{"label":"logiclord:multipleexecutors2","ref":"multipleexecutors2","sha":"b835d0ec594bd8ee42ddb2933276feda7c5919dc","user":{"login":"logiclord","id":770329,"avatar_url":"https://avatars.githubusercontent.com/u/770329?v=3","gravatar_id":"","url":"https://api.github.com/users/logiclord","html_url":"https://github.com/logiclord","followers_url":"https://api.github.com/users/logiclord/followers","following_url":"https://api.github.com/users/logiclord/following{/other_user}","gists_url":"https://api.github.com/users/logiclord/gists{/gist_id}","starred_url":"https://api.github.com/users/logiclord/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/logiclord/subscriptions","organizations_url":"https://api.github.com/users/logiclord/orgs","repos_url":"https://api.github.com/users/logiclord/repos","events_url":"https://api.github.com/users/logiclord/events{/privacy}","received_events_url":"https://api.github.com/users/logiclord/received_events","type":"User","site_admin":false},"repo":{"id":26245135,"name":"azkaban","full_name":"logiclord/azkaban","owner":{"login":"logiclord","id":770329,"avatar_url":"https://avatars.githubusercontent.com/u/770329?v=3","gravatar_id":"","url":"https://api.github.com/users/logiclord","html_url":"https://github.com/logiclord","followers_url":"https://api.github.com/users/logiclord/followers","following_url":"https://api.github.com/users/logiclord/following{/other_user}","gists_url":"https://api.github.com/users/logiclord/gists{/gist_id}","starred_url":"https://api.github.com/users/logiclord/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/logiclord/subscriptions","organizations_url":"https://api.github.com/users/logiclord/orgs","repos_url":"https://api.github.com/users/logiclord/repos","events_url":"https://api.github.com/users/logiclord/events{/privacy}","received_events_url":"https://api.github.com/users/logiclord/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/logiclord/azkaban","description":"Azkaban workflow manager.","fork":true,"url":"https://api.github.com/repos/logiclord/azkaban","forks_url":"https://api.github.com/repos/logiclord/azkaban/forks","keys_url":"https://api.github.com/repos/logiclord/azkaban/keys{/key_id}","collaborators_url":"https://api.github.com/repos/logiclord/azkaban/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/logiclord/azkaban/teams","hooks_url":"https://api.github.com/repos/logiclord/azkaban/hooks","issue_events_url":"https://api.github.com/repos/logiclord/azkaban/issues/events{/number}","events_url":"https://api.github.com/repos/logiclord/azkaban/events","assignees_url":"https://api.github.com/repos/logiclord/azkaban/assignees{/user}","branches_url":"https://api.github.com/repos/logiclord/azkaban/branches{/branch}","tags_url":"https://api.github.com/repos/logiclord/azkaban/tags","blobs_url":"https://api.github.com/repos/logiclord/azkaban/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/logiclord/azkaban/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/logiclord/azkaban/git/refs{/sha}","trees_url":"https://api.github.com/repos/logiclord/azkaban/git/trees{/sha}","statuses_url":"https://api.github.com/repos/logiclord/azkaban/statuses/{sha}","languages_url":"https://api.github.com/repos/logiclord/azkaban/languages","stargazers_url":"https://api.github.com/repos/logiclord/azkaban/stargazers","contributors_url":"https://api.github.com/repos/logiclord/azkaban/contributors","subscribers_url":"https://api.github.com/repos/logiclord/azkaban/subscribers","subscription_url":"https://api.github.com/repos/logiclord/azkaban/subscription","commits_url":"https://api.github.com/repos/logiclord/azkaban/commits{/sha}","git_commits_url":"https://api.github.com/repos/logiclord/azkaban/git/commits{/sha}","comments_url":"https://api.github.com/repos/logiclord/azkaban/comments{/number}","issue_comment_url":"https://api.github.com/repos/logiclord/azkaban/issues/comments{/number}","contents_url":"https://api.github.com/repos/logiclord/azkaban/contents/{+path}","compare_url":"https://api.github.com/repos/logiclord/azkaban/compare/{base}...{head}","merges_url":"https://api.github.com/repos/logiclord/azkaban/merges","archive_url":"https://api.github.com/repos/logiclord/azkaban/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/logiclord/azkaban/downloads","issues_url":"https://api.github.com/repos/logiclord/azkaban/issues{/number}","pulls_url":"https://api.github.com/repos/logiclord/azkaban/pulls{/number}","milestones_url":"https://api.github.com/repos/logiclord/azkaban/milestones{/number}","notifications_url":"https://api.github.com/repos/logiclord/azkaban/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/logiclord/azkaban/labels{/name}","releases_url":"https://api.github.com/repos/logiclord/azkaban/releases{/id}","created_at":"2014-11-05T23:44:11Z","updated_at":"2015-02-11T21:42:12Z","pushed_at":"2015-09-07T08:20:09Z","git_url":"git://github.com/logiclord/azkaban.git","ssh_url":"git@github.com:logiclord/azkaban.git","clone_url":"https://github.com/logiclord/azkaban.git","svn_url":"https://github.com/logiclord/azkaban","homepage":"https://azkaban.github.io","size":33129,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"azkaban:multipleexecutors","ref":"multipleexecutors","sha":"e9c84a43fead5d7ed0dac0ff4034b4d98f2711a8","user":{"login":"azkaban","id":213618,"avatar_url":"https://avatars.githubusercontent.com/u/213618?v=3","gravatar_id":"","url":"https://api.github.com/users/azkaban","html_url":"https://github.com/azkaban","followers_url":"https://api.github.com/users/azkaban/followers","following_url":"https://api.github.com/users/azkaban/following{/other_user}","gists_url":"https://api.github.com/users/azkaban/gists{/gist_id}","starred_url":"https://api.github.com/users/azkaban/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azkaban/subscriptions","organizations_url":"https://api.github.com/users/azkaban/orgs","repos_url":"https://api.github.com/users/azkaban/repos","events_url":"https://api.github.com/users/azkaban/events{/privacy}","received_events_url":"https://api.github.com/users/azkaban/received_events","type":"Organization","site_admin":false},"repo":{"id":6271421,"name":"azkaban","full_name":"azkaban/azkaban","owner":{"login":"azkaban","id":213618,"avatar_url":"https://avatars.githubusercontent.com/u/213618?v=3","gravatar_id":"","url":"https://api.github.com/users/azkaban","html_url":"https://github.com/azkaban","followers_url":"https://api.github.com/users/azkaban/followers","following_url":"https://api.github.com/users/azkaban/following{/other_user}","gists_url":"https://api.github.com/users/azkaban/gists{/gist_id}","starred_url":"https://api.github.com/users/azkaban/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azkaban/subscriptions","organizations_url":"https://api.github.com/users/azkaban/orgs","repos_url":"https://api.github.com/users/azkaban/repos","events_url":"https://api.github.com/users/azkaban/events{/privacy}","received_events_url":"https://api.github.com/users/azkaban/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/azkaban/azkaban","description":"Azkaban workflow manager.","fork":false,"url":"https://api.github.com/repos/azkaban/azkaban","forks_url":"https://api.github.com/repos/azkaban/azkaban/forks","keys_url":"https://api.github.com/repos/azkaban/azkaban/keys{/key_id}","collaborators_url":"https://api.github.com/repos/azkaban/azkaban/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/azkaban/azkaban/teams","hooks_url":"https://api.github.com/repos/azkaban/azkaban/hooks","issue_events_url":"https://api.github.com/repos/azkaban/azkaban/issues/events{/number}","events_url":"https://api.github.com/repos/azkaban/azkaban/events","assignees_url":"https://api.github.com/repos/azkaban/azkaban/assignees{/user}","branches_url":"https://api.github.com/repos/azkaban/azkaban/branches{/branch}","tags_url":"https://api.github.com/repos/azkaban/azkaban/tags","blobs_url":"https://api.github.com/repos/azkaban/azkaban/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/azkaban/azkaban/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/azkaban/azkaban/git/refs{/sha}","trees_url":"https://api.github.com/repos/azkaban/azkaban/git/trees{/sha}","statuses_url":"https://api.github.com/repos/azkaban/azkaban/statuses/{sha}","languages_url":"https://api.github.com/repos/azkaban/azkaban/languages","stargazers_url":"https://api.github.com/repos/azkaban/azkaban/stargazers","contributors_url":"https://api.github.com/repos/azkaban/azkaban/contributors","subscribers_url":"https://api.github.com/repos/azkaban/azkaban/subscribers","subscription_url":"https://api.github.com/repos/azkaban/azkaban/subscription","commits_url":"https://api.github.com/repos/azkaban/azkaban/commits{/sha}","git_commits_url":"https://api.github.com/repos/azkaban/azkaban/git/commits{/sha}","comments_url":"https://api.github.com/repos/azkaban/azkaban/comments{/number}","issue_comment_url":"https://api.github.com/repos/azkaban/azkaban/issues/comments{/number}","contents_url":"https://api.github.com/repos/azkaban/azkaban/contents/{+path}","compare_url":"https://api.github.com/repos/azkaban/azkaban/compare/{base}...{head}","merges_url":"https://api.github.com/repos/azkaban/azkaban/merges","archive_url":"https://api.github.com/repos/azkaban/azkaban/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/azkaban/azkaban/downloads","issues_url":"https://api.github.com/repos/azkaban/azkaban/issues{/number}","pulls_url":"https://api.github.com/repos/azkaban/azkaban/pulls{/number}","milestones_url":"https://api.github.com/repos/azkaban/azkaban/milestones{/number}","notifications_url":"https://api.github.com/repos/azkaban/azkaban/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/azkaban/azkaban/labels{/name}","releases_url":"https://api.github.com/repos/azkaban/azkaban/releases{/id}","created_at":"2012-10-18T01:34:53Z","updated_at":"2015-09-08T07:45:49Z","pushed_at":"2015-09-07T08:20:10Z","git_url":"git://github.com/azkaban/azkaban.git","ssh_url":"git@github.com:azkaban/azkaban.git","clone_url":"https://github.com/azkaban/azkaban.git","svn_url":"https://github.com/azkaban/azkaban","homepage":"https://azkaban.github.io","size":36561,"stargazers_count":408,"watchers_count":408,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":233,"mirror_url":null,"open_issues_count":134,"forks":233,"open_issues":134,"watchers":408,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/azkaban/azkaban/pulls/478"},"html":{"href":"https://github.com/azkaban/azkaban/pull/478"},"issue":{"href":"https://api.github.com/repos/azkaban/azkaban/issues/478"},"comments":{"href":"https://api.github.com/repos/azkaban/azkaban/issues/478/comments"},"review_comments":{"href":"https://api.github.com/repos/azkaban/azkaban/pulls/478/comments"},"review_comment":{"href":"https://api.github.com/repos/azkaban/azkaban/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/azkaban/azkaban/pulls/478/commits"},"statuses":{"href":"https://api.github.com/repos/azkaban/azkaban/statuses/b835d0ec594bd8ee42ddb2933276feda7c5919dc"}}}}