{"action":"created","comment":{"url":"https://api.github.com/repos/ClusterHQ/build.clusterhq.com/pulls/comments/30365933","id":30365933,"diff_hunk":"@@ -34,57 +34,76 @@\n c['slavePortnum'] = 9989\n \n from flocker_bb.password import generate_password\n-from flocker_bb.ec2_buildslave import EC2BuildSlave\n+from flocker_bb.ec2 import rackspace_slave, ec2_slave\n from buildbot.buildslave import BuildSlave\n \n-cloudInit = FilePath(__file__).sibling(\"slave\").child(\"cloud-init.sh\").getContent()\n+cloudInit = FilePath(__file__).sibling(\"slave\").child(\n+    \"cloud-init.sh\").getContent()\n \n c['slaves'] = []\n SLAVENAMES = {}\n \n+\n+def get_cloud_init(name, base, password, provider, privateData, slavePortnum):\n+    return cloudInit % {\n+        \"github_token\": privateData['github']['token'],\n+        \"coveralls_token\": privateData['coveralls']['token'],\n+        \"name\": name,\n+        \"base\": base,\n+        \"password\": password,\n+        \"FLOCKER_FUNCTIONAL_TEST_CLOUD_PROVIDER\": provider,\n+        'buildmaster_host': privateData['buildmaster']['host'],\n+        'buildmaster_port': slavePortnum,\n+        'acceptance.yml': privateData['acceptance'].get('config', ''),\n+        'acceptance-ssh-key': privateData['acceptance'].get('ssh-key', ''),\n+    }","path":"config.py","position":28,"original_position":28,"commit_id":"acd6d6fa8c68e7bc4d8924110dca2fefda129d98","original_commit_id":"acd6d6fa8c68e7bc4d8924110dca2fefda129d98","user":{"login":"exarkun","id":254565,"avatar_url":"https://avatars.githubusercontent.com/u/254565?v=3","gravatar_id":"","url":"https://api.github.com/users/exarkun","html_url":"https://github.com/exarkun","followers_url":"https://api.github.com/users/exarkun/followers","following_url":"https://api.github.com/users/exarkun/following{/other_user}","gists_url":"https://api.github.com/users/exarkun/gists{/gist_id}","starred_url":"https://api.github.com/users/exarkun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exarkun/subscriptions","organizations_url":"https://api.github.com/users/exarkun/orgs","repos_url":"https://api.github.com/users/exarkun/repos","events_url":"https://api.github.com/users/exarkun/events{/privacy}","received_events_url":"https://api.github.com/users/exarkun/received_events","type":"User","site_admin":false},"body":"This is mostly the same as what was being passed inline to the EC2 slave previously - but with the new `FLOCKER_FUNCTIONAL_TEST_CLOUD_PROVIDER` variable interpolated so the cloud-init script actually knows what cloud we're on.","created_at":"2015-05-14T21:37:41Z","updated_at":"2015-05-14T21:37:41Z","html_url":"https://github.com/ClusterHQ/build.clusterhq.com/pull/81#discussion_r30365933","pull_request_url":"https://api.github.com/repos/ClusterHQ/build.clusterhq.com/pulls/81","_links":{"self":{"href":"https://api.github.com/repos/ClusterHQ/build.clusterhq.com/pulls/comments/30365933"},"html":{"href":"https://github.com/ClusterHQ/build.clusterhq.com/pull/81#discussion_r30365933"},"pull_request":{"href":"https://api.github.com/repos/ClusterHQ/build.clusterhq.com/pulls/81"}}},"pull_request":{"url":"https://api.github.com/repos/ClusterHQ/build.clusterhq.com/pulls/81","id":35464783,"html_url":"https://github.com/ClusterHQ/build.clusterhq.com/pull/81","diff_url":"https://github.com/ClusterHQ/build.clusterhq.com/pull/81.diff","patch_url":"https://github.com/ClusterHQ/build.clusterhq.com/pull/81.patch","issue_url":"https://api.github.com/repos/ClusterHQ/build.clusterhq.com/issues/81","number":81,"state":"open","locked":false,"title":"Add support for on-demand rackspace slaves","user":{"login":"exarkun","id":254565,"avatar_url":"https://avatars.githubusercontent.com/u/254565?v=3","gravatar_id":"","url":"https://api.github.com/users/exarkun","html_url":"https://github.com/exarkun","followers_url":"https://api.github.com/users/exarkun/followers","following_url":"https://api.github.com/users/exarkun/following{/other_user}","gists_url":"https://api.github.com/users/exarkun/gists{/gist_id}","starred_url":"https://api.github.com/users/exarkun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exarkun/subscriptions","organizations_url":"https://api.github.com/users/exarkun/orgs","repos_url":"https://api.github.com/users/exarkun/repos","events_url":"https://api.github.com/users/exarkun/events{/privacy}","received_events_url":"https://api.github.com/users/exarkun/received_events","type":"User","site_admin":false},"body":"Fixes https://clusterhq.atlassian.net/browse/FLOC-1871\r\n\r\nGeneralize the existing Flocker latent EC2 functionality and add Rackspace support to it.","created_at":"2015-05-14T21:35:45Z","updated_at":"2015-05-14T21:37:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ade9a444c8f2d748fa0b0a6cb6a08c31fb470c38","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ClusterHQ/build.clusterhq.com/pulls/81/commits","review_comments_url":"https://api.github.com/repos/ClusterHQ/build.clusterhq.com/pulls/81/comments","review_comment_url":"https://api.github.com/repos/ClusterHQ/build.clusterhq.com/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ClusterHQ/build.clusterhq.com/issues/81/comments","statuses_url":"https://api.github.com/repos/ClusterHQ/build.clusterhq.com/statuses/acd6d6fa8c68e7bc4d8924110dca2fefda129d98","head":{"label":"ClusterHQ:latent-rackspace-slave-FLOC-1871","ref":"latent-rackspace-slave-FLOC-1871","sha":"acd6d6fa8c68e7bc4d8924110dca2fefda129d98","user":{"login":"ClusterHQ","id":7913449,"avatar_url":"https://avatars.githubusercontent.com/u/7913449?v=3","gravatar_id":"","url":"https://api.github.com/users/ClusterHQ","html_url":"https://github.com/ClusterHQ","followers_url":"https://api.github.com/users/ClusterHQ/followers","following_url":"https://api.github.com/users/ClusterHQ/following{/other_user}","gists_url":"https://api.github.com/users/ClusterHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ClusterHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ClusterHQ/subscriptions","organizations_url":"https://api.github.com/users/ClusterHQ/orgs","repos_url":"https://api.github.com/users/ClusterHQ/repos","events_url":"https://api.github.com/users/ClusterHQ/events{/privacy}","received_events_url":"https://api.github.com/users/ClusterHQ/received_events","type":"Organization","site_admin":false},"repo":{"id":21618058,"name":"build.clusterhq.com","full_name":"ClusterHQ/build.clusterhq.com","owner":{"login":"ClusterHQ","id":7913449,"avatar_url":"https://avatars.githubusercontent.com/u/7913449?v=3","gravatar_id":"","url":"https://api.github.com/users/ClusterHQ","html_url":"https://github.com/ClusterHQ","followers_url":"https://api.github.com/users/ClusterHQ/followers","following_url":"https://api.github.com/users/ClusterHQ/following{/other_user}","gists_url":"https://api.github.com/users/ClusterHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ClusterHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ClusterHQ/subscriptions","organizations_url":"https://api.github.com/users/ClusterHQ/orgs","repos_url":"https://api.github.com/users/ClusterHQ/repos","events_url":"https://api.github.com/users/ClusterHQ/events{/privacy}","received_events_url":"https://api.github.com/users/ClusterHQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ClusterHQ/build.clusterhq.com","description":"Buildbot configuration for ClusterHQ.","fork":false,"url":"https://api.github.com/repos/ClusterHQ/build.clusterhq.com","forks_url":"https://api.github.com/repos/ClusterHQ/build.clusterhq.com/forks","keys_url":"https://api.github.com/repos/ClusterHQ/build.clusterhq.com/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ClusterHQ/build.clusterhq.com/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ClusterHQ/build.clusterhq.com/teams","hooks_url":"https://api.github.com/repos/ClusterHQ/build.clusterhq.com/hooks","issue_events_url":"https://api.github.com/repos/ClusterHQ/build.clusterhq.com/issues/events{/number}","events_url":"https://api.github.com/repos/ClusterHQ/build.clusterhq.com/events","assignees_url":"https://api.github.com/repos/ClusterHQ/build.clusterhq.com/assignees{/user}","branches_url":"https://api.github.com/repos/ClusterHQ/build.clusterhq.com/branches{/branch}","tags_url":"https://api.github.com/repos/ClusterHQ/build.clusterhq.com/tags","blobs_url":"https://api.github.com/repos/ClusterHQ/build.clusterhq.com/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ClusterHQ/build.clusterhq.com/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ClusterHQ/build.clusterhq.com/git/refs{/sha}","trees_url":"https://api.github.com/repos/ClusterHQ/build.clusterhq.com/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ClusterHQ/build.clusterhq.com/statuses/{sha}","languages_url":"https://api.github.com/repos/ClusterHQ/build.clusterhq.com/languages","stargazers_url":"https://api.github.com/repos/ClusterHQ/build.clusterhq.com/stargazers","contributors_url":"https://api.github.com/repos/ClusterHQ/build.clusterhq.com/contributors","subscribers_url":"https://api.github.com/repos/ClusterHQ/build.clusterhq.com/subscribers","subscription_url":"https://api.github.com/repos/ClusterHQ/build.clusterhq.com/subscription","commits_url":"https://api.github.com/repos/ClusterHQ/build.clusterhq.com/commits{/sha}","git_commits_url":"https://api.github.com/repos/ClusterHQ/build.clusterhq.com/git/commits{/sha}","comments_url":"https://api.github.com/repos/ClusterHQ/build.clusterhq.com/comments{/number}","issue_comment_url":"https://api.github.com/repos/ClusterHQ/build.clusterhq.com/issues/comments{/number}","contents_url":"https://api.github.com/repos/ClusterHQ/build.clusterhq.com/contents/{+path}","compare_url":"https://api.github.com/repos/ClusterHQ/build.clusterhq.com/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ClusterHQ/build.clusterhq.com/merges","archive_url":"https://api.github.com/repos/ClusterHQ/build.clusterhq.com/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ClusterHQ/build.clusterhq.com/downloads","issues_url":"https://api.github.com/repos/ClusterHQ/build.clusterhq.com/issues{/number}","pulls_url":"https://api.github.com/repos/ClusterHQ/build.clusterhq.com/pulls{/number}","milestones_url":"https://api.github.com/repos/ClusterHQ/build.clusterhq.com/milestones{/number}","notifications_url":"https://api.github.com/repos/ClusterHQ/build.clusterhq.com/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ClusterHQ/build.clusterhq.com/labels{/name}","releases_url":"https://api.github.com/repos/ClusterHQ/build.clusterhq.com/releases{/id}","created_at":"2014-07-08T15:24:36Z","updated_at":"2015-05-08T06:43:02Z","pushed_at":"2015-05-14T21:35:45Z","git_url":"git://github.com/ClusterHQ/build.clusterhq.com.git","ssh_url":"git@github.com:ClusterHQ/build.clusterhq.com.git","clone_url":"https://github.com/ClusterHQ/build.clusterhq.com.git","svn_url":"https://github.com/ClusterHQ/build.clusterhq.com","homepage":null,"size":2708,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":10,"forks":2,"open_issues":10,"watchers":3,"default_branch":"master"}},"base":{"label":"ClusterHQ:master","ref":"master","sha":"5ba74fbc66351789848897ff355f05d8ebc1f0ca","user":{"login":"ClusterHQ","id":7913449,"avatar_url":"https://avatars.githubusercontent.com/u/7913449?v=3","gravatar_id":"","url":"https://api.github.com/users/ClusterHQ","html_url":"https://github.com/ClusterHQ","followers_url":"https://api.github.com/users/ClusterHQ/followers","following_url":"https://api.github.com/users/ClusterHQ/following{/other_user}","gists_url":"https://api.github.com/users/ClusterHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ClusterHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ClusterHQ/subscriptions","organizations_url":"https://api.github.com/users/ClusterHQ/orgs","repos_url":"https://api.github.com/users/ClusterHQ/repos","events_url":"https://api.github.com/users/ClusterHQ/events{/privacy}","received_events_url":"https://api.github.com/users/ClusterHQ/received_events","type":"Organization","site_admin":false},"repo":{"id":21618058,"name":"build.clusterhq.com","full_name":"ClusterHQ/build.clusterhq.com","owner":{"login":"ClusterHQ","id":7913449,"avatar_url":"https://avatars.githubusercontent.com/u/7913449?v=3","gravatar_id":"","url":"https://api.github.com/users/ClusterHQ","html_url":"https://github.com/ClusterHQ","followers_url":"https://api.github.com/users/ClusterHQ/followers","following_url":"https://api.github.com/users/ClusterHQ/following{/other_user}","gists_url":"https://api.github.com/users/ClusterHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ClusterHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ClusterHQ/subscriptions","organizations_url":"https://api.github.com/users/ClusterHQ/orgs","repos_url":"https://api.github.com/users/ClusterHQ/repos","events_url":"https://api.github.com/users/ClusterHQ/events{/privacy}","received_events_url":"https://api.github.com/users/ClusterHQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ClusterHQ/build.clusterhq.com","description":"Buildbot configuration for ClusterHQ.","fork":false,"url":"https://api.github.com/repos/ClusterHQ/build.clusterhq.com","forks_url":"https://api.github.com/repos/ClusterHQ/build.clusterhq.com/forks","keys_url":"https://api.github.com/repos/ClusterHQ/build.clusterhq.com/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ClusterHQ/build.clusterhq.com/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ClusterHQ/build.clusterhq.com/teams","hooks_url":"https://api.github.com/repos/ClusterHQ/build.clusterhq.com/hooks","issue_events_url":"https://api.github.com/repos/ClusterHQ/build.clusterhq.com/issues/events{/number}","events_url":"https://api.github.com/repos/ClusterHQ/build.clusterhq.com/events","assignees_url":"https://api.github.com/repos/ClusterHQ/build.clusterhq.com/assignees{/user}","branches_url":"https://api.github.com/repos/ClusterHQ/build.clusterhq.com/branches{/branch}","tags_url":"https://api.github.com/repos/ClusterHQ/build.clusterhq.com/tags","blobs_url":"https://api.github.com/repos/ClusterHQ/build.clusterhq.com/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ClusterHQ/build.clusterhq.com/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ClusterHQ/build.clusterhq.com/git/refs{/sha}","trees_url":"https://api.github.com/repos/ClusterHQ/build.clusterhq.com/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ClusterHQ/build.clusterhq.com/statuses/{sha}","languages_url":"https://api.github.com/repos/ClusterHQ/build.clusterhq.com/languages","stargazers_url":"https://api.github.com/repos/ClusterHQ/build.clusterhq.com/stargazers","contributors_url":"https://api.github.com/repos/ClusterHQ/build.clusterhq.com/contributors","subscribers_url":"https://api.github.com/repos/ClusterHQ/build.clusterhq.com/subscribers","subscription_url":"https://api.github.com/repos/ClusterHQ/build.clusterhq.com/subscription","commits_url":"https://api.github.com/repos/ClusterHQ/build.clusterhq.com/commits{/sha}","git_commits_url":"https://api.github.com/repos/ClusterHQ/build.clusterhq.com/git/commits{/sha}","comments_url":"https://api.github.com/repos/ClusterHQ/build.clusterhq.com/comments{/number}","issue_comment_url":"https://api.github.com/repos/ClusterHQ/build.clusterhq.com/issues/comments{/number}","contents_url":"https://api.github.com/repos/ClusterHQ/build.clusterhq.com/contents/{+path}","compare_url":"https://api.github.com/repos/ClusterHQ/build.clusterhq.com/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ClusterHQ/build.clusterhq.com/merges","archive_url":"https://api.github.com/repos/ClusterHQ/build.clusterhq.com/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ClusterHQ/build.clusterhq.com/downloads","issues_url":"https://api.github.com/repos/ClusterHQ/build.clusterhq.com/issues{/number}","pulls_url":"https://api.github.com/repos/ClusterHQ/build.clusterhq.com/pulls{/number}","milestones_url":"https://api.github.com/repos/ClusterHQ/build.clusterhq.com/milestones{/number}","notifications_url":"https://api.github.com/repos/ClusterHQ/build.clusterhq.com/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ClusterHQ/build.clusterhq.com/labels{/name}","releases_url":"https://api.github.com/repos/ClusterHQ/build.clusterhq.com/releases{/id}","created_at":"2014-07-08T15:24:36Z","updated_at":"2015-05-08T06:43:02Z","pushed_at":"2015-05-14T21:35:45Z","git_url":"git://github.com/ClusterHQ/build.clusterhq.com.git","ssh_url":"git@github.com:ClusterHQ/build.clusterhq.com.git","clone_url":"https://github.com/ClusterHQ/build.clusterhq.com.git","svn_url":"https://github.com/ClusterHQ/build.clusterhq.com","homepage":null,"size":2708,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":10,"forks":2,"open_issues":10,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ClusterHQ/build.clusterhq.com/pulls/81"},"html":{"href":"https://github.com/ClusterHQ/build.clusterhq.com/pull/81"},"issue":{"href":"https://api.github.com/repos/ClusterHQ/build.clusterhq.com/issues/81"},"comments":{"href":"https://api.github.com/repos/ClusterHQ/build.clusterhq.com/issues/81/comments"},"review_comments":{"href":"https://api.github.com/repos/ClusterHQ/build.clusterhq.com/pulls/81/comments"},"review_comment":{"href":"https://api.github.com/repos/ClusterHQ/build.clusterhq.com/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ClusterHQ/build.clusterhq.com/pulls/81/commits"},"statuses":{"href":"https://api.github.com/repos/ClusterHQ/build.clusterhq.com/statuses/acd6d6fa8c68e7bc4d8924110dca2fefda129d98"}}}}