{"action":"created","issue":{"url":"https://api.github.com/repos/cloudant/CDTDatastore/issues/134","labels_url":"https://api.github.com/repos/cloudant/CDTDatastore/issues/134/labels{/name}","comments_url":"https://api.github.com/repos/cloudant/CDTDatastore/issues/134/comments","events_url":"https://api.github.com/repos/cloudant/CDTDatastore/issues/134/events","html_url":"https://github.com/cloudant/CDTDatastore/pull/134","id":70667698,"number":134,"title":"45570 Generate, retrieve & store a key: Use target specific functions to access keychain","user":{"login":"indisoluble","id":472832,"avatar_url":"https://avatars.githubusercontent.com/u/472832?v=3","gravatar_id":"","url":"https://api.github.com/users/indisoluble","html_url":"https://github.com/indisoluble","followers_url":"https://api.github.com/users/indisoluble/followers","following_url":"https://api.github.com/users/indisoluble/following{/other_user}","gists_url":"https://api.github.com/users/indisoluble/gists{/gist_id}","starred_url":"https://api.github.com/users/indisoluble/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indisoluble/subscriptions","organizations_url":"https://api.github.com/users/indisoluble/orgs","repos_url":"https://api.github.com/users/indisoluble/repos","events_url":"https://api.github.com/users/indisoluble/events{/privacy}","received_events_url":"https://api.github.com/users/indisoluble/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-04-24T11:40:07Z","updated_at":"2015-04-24T16:48:30Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cloudant/CDTDatastore/pulls/134","html_url":"https://github.com/cloudant/CDTDatastore/pull/134","diff_url":"https://github.com/cloudant/CDTDatastore/pull/134.diff","patch_url":"https://github.com/cloudant/CDTDatastore/pull/134.patch"},"body":"*What:*\r\nCode in PR #127 will not work on Mac OS X.\r\n\r\n*Why:*\r\nThe code to access the keychain, although it compiles in both targets, it is not going to work properly in Mac OS because iOS and Mac OS use different [paradigms](https://developer.apple.com/library/mac/documentation/Security/Conceptual/keychainServConcepts/02concepts/concepts.html).\r\n\r\n*How:*\r\nAs suggested in the documentation (under title *Keychain Services Ease of Use*), we are going to use the functions: `SecKeychainFindGenericPassword` and `SecKeychainAddGenericPassword`.\r\n\r\nreviewer @mikerhodes \r\nreviewer @rhyshort"},"comment":{"url":"https://api.github.com/repos/cloudant/CDTDatastore/issues/comments/95989314","html_url":"https://github.com/cloudant/CDTDatastore/pull/134#issuecomment-95989314","issue_url":"https://api.github.com/repos/cloudant/CDTDatastore/issues/134","id":95989314,"user":{"login":"mikerhodes","id":453210,"avatar_url":"https://avatars.githubusercontent.com/u/453210?v=3","gravatar_id":"","url":"https://api.github.com/users/mikerhodes","html_url":"https://github.com/mikerhodes","followers_url":"https://api.github.com/users/mikerhodes/followers","following_url":"https://api.github.com/users/mikerhodes/following{/other_user}","gists_url":"https://api.github.com/users/mikerhodes/gists{/gist_id}","starred_url":"https://api.github.com/users/mikerhodes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikerhodes/subscriptions","organizations_url":"https://api.github.com/users/mikerhodes/orgs","repos_url":"https://api.github.com/users/mikerhodes/repos","events_url":"https://api.github.com/users/mikerhodes/events{/privacy}","received_events_url":"https://api.github.com/users/mikerhodes/received_events","type":"User","site_admin":false},"created_at":"2015-04-24T16:48:30Z","updated_at":"2015-04-24T16:48:30Z","body":"This looks good to me, looking through the docs for the OS X stuff. I'm assuming the iOS stuff is sound. :+1:"}}