{"action":"created","comment":{"url":"https://api.github.com/repos/darktable-org/darktable/pulls/comments/23499733","id":23499733,"diff_hunk":"@@ -1222,6 +1226,85 @@ int dt_view_image_expose(dt_view_image_over_t *image_over, uint32_t imgid, cairo\n   return missing;\n }\n \n+void","path":"src/views/view.c","position":17,"original_position":17,"commit_id":"3a32613a807fe78a9741bf8498ceae6d00407319","original_commit_id":"3a32613a807fe78a9741bf8498ceae6d00407319","user":{"login":"TurboGit","id":467069,"avatar_url":"https://avatars.githubusercontent.com/u/467069?v=3","gravatar_id":"","url":"https://api.github.com/users/TurboGit","html_url":"https://github.com/TurboGit","followers_url":"https://api.github.com/users/TurboGit/followers","following_url":"https://api.github.com/users/TurboGit/following{/other_user}","gists_url":"https://api.github.com/users/TurboGit/gists{/gist_id}","starred_url":"https://api.github.com/users/TurboGit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TurboGit/subscriptions","organizations_url":"https://api.github.com/users/TurboGit/orgs","repos_url":"https://api.github.com/users/TurboGit/repos","events_url":"https://api.github.com/users/TurboGit/events{/privacy}","received_events_url":"https://api.github.com/users/TurboGit/received_events","type":"User","site_admin":false},"body":"I did that at first and it makes the dt_view_image_expose() even more unreadable. So to me it's a compromise between readability and code duplication. Would be good to have other point of view as I've no strong opinion and both solutions have pro and cons.","created_at":"2015-01-24T22:00:29Z","updated_at":"2015-01-24T22:00:29Z","html_url":"https://github.com/darktable-org/darktable/pull/829#discussion_r23499733","pull_request_url":"https://api.github.com/repos/darktable-org/darktable/pulls/829","_links":{"self":{"href":"https://api.github.com/repos/darktable-org/darktable/pulls/comments/23499733"},"html":{"href":"https://github.com/darktable-org/darktable/pull/829#discussion_r23499733"},"pull_request":{"href":"https://api.github.com/repos/darktable-org/darktable/pulls/829"}}},"pull_request":{"url":"https://api.github.com/repos/darktable-org/darktable/pulls/829","id":27906140,"html_url":"https://github.com/darktable-org/darktable/pull/829","diff_url":"https://github.com/darktable-org/darktable/pull/829.diff","patch_url":"https://github.com/darktable-org/darktable/pull/829.patch","issue_url":"https://api.github.com/repos/darktable-org/darktable/issues/829","number":829,"state":"open","locked":false,"title":"Print module","user":{"login":"TurboGit","id":467069,"avatar_url":"https://avatars.githubusercontent.com/u/467069?v=3","gravatar_id":"","url":"https://api.github.com/users/TurboGit","html_url":"https://github.com/TurboGit","followers_url":"https://api.github.com/users/TurboGit/followers","following_url":"https://api.github.com/users/TurboGit/following{/other_user}","gists_url":"https://api.github.com/users/TurboGit/gists{/gist_id}","starred_url":"https://api.github.com/users/TurboGit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TurboGit/subscriptions","organizations_url":"https://api.github.com/users/TurboGit/orgs","repos_url":"https://api.github.com/users/TurboGit/repos","events_url":"https://api.github.com/users/TurboGit/events{/privacy}","received_events_url":"https://api.github.com/users/TurboGit/received_events","type":"User","site_admin":false},"body":"This is latest version which is probably ready for merging. The code is ported to Gtk3 and using the PDF backend (thanks to Tobias!). After good report from the mailing-list I'm confident that it is ready.\r\n","created_at":"2015-01-23T07:39:03Z","updated_at":"2015-01-24T22:00:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3b9ab1be2e0180f1bbad1c714878df116143d224","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/darktable-org/darktable/pulls/829/commits","review_comments_url":"https://api.github.com/repos/darktable-org/darktable/pulls/829/comments","review_comment_url":"https://api.github.com/repos/darktable-org/darktable/pulls/comments/{number}","comments_url":"https://api.github.com/repos/darktable-org/darktable/issues/829/comments","statuses_url":"https://api.github.com/repos/darktable-org/darktable/statuses/3a32613a807fe78a9741bf8498ceae6d00407319","head":{"label":"darktable-org:print-module","ref":"print-module","sha":"3a32613a807fe78a9741bf8498ceae6d00407319","user":{"login":"darktable-org","id":1561544,"avatar_url":"https://avatars.githubusercontent.com/u/1561544?v=3","gravatar_id":"","url":"https://api.github.com/users/darktable-org","html_url":"https://github.com/darktable-org","followers_url":"https://api.github.com/users/darktable-org/followers","following_url":"https://api.github.com/users/darktable-org/following{/other_user}","gists_url":"https://api.github.com/users/darktable-org/gists{/gist_id}","starred_url":"https://api.github.com/users/darktable-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darktable-org/subscriptions","organizations_url":"https://api.github.com/users/darktable-org/orgs","repos_url":"https://api.github.com/users/darktable-org/repos","events_url":"https://api.github.com/users/darktable-org/events{/privacy}","received_events_url":"https://api.github.com/users/darktable-org/received_events","type":"Organization","site_admin":false},"repo":{"id":3791835,"name":"darktable","full_name":"darktable-org/darktable","owner":{"login":"darktable-org","id":1561544,"avatar_url":"https://avatars.githubusercontent.com/u/1561544?v=3","gravatar_id":"","url":"https://api.github.com/users/darktable-org","html_url":"https://github.com/darktable-org","followers_url":"https://api.github.com/users/darktable-org/followers","following_url":"https://api.github.com/users/darktable-org/following{/other_user}","gists_url":"https://api.github.com/users/darktable-org/gists{/gist_id}","starred_url":"https://api.github.com/users/darktable-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darktable-org/subscriptions","organizations_url":"https://api.github.com/users/darktable-org/orgs","repos_url":"https://api.github.com/users/darktable-org/repos","events_url":"https://api.github.com/users/darktable-org/events{/privacy}","received_events_url":"https://api.github.com/users/darktable-org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/darktable-org/darktable","description":"darktable main repository","fork":false,"url":"https://api.github.com/repos/darktable-org/darktable","forks_url":"https://api.github.com/repos/darktable-org/darktable/forks","keys_url":"https://api.github.com/repos/darktable-org/darktable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/darktable-org/darktable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/darktable-org/darktable/teams","hooks_url":"https://api.github.com/repos/darktable-org/darktable/hooks","issue_events_url":"https://api.github.com/repos/darktable-org/darktable/issues/events{/number}","events_url":"https://api.github.com/repos/darktable-org/darktable/events","assignees_url":"https://api.github.com/repos/darktable-org/darktable/assignees{/user}","branches_url":"https://api.github.com/repos/darktable-org/darktable/branches{/branch}","tags_url":"https://api.github.com/repos/darktable-org/darktable/tags","blobs_url":"https://api.github.com/repos/darktable-org/darktable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/darktable-org/darktable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/darktable-org/darktable/git/refs{/sha}","trees_url":"https://api.github.com/repos/darktable-org/darktable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/darktable-org/darktable/statuses/{sha}","languages_url":"https://api.github.com/repos/darktable-org/darktable/languages","stargazers_url":"https://api.github.com/repos/darktable-org/darktable/stargazers","contributors_url":"https://api.github.com/repos/darktable-org/darktable/contributors","subscribers_url":"https://api.github.com/repos/darktable-org/darktable/subscribers","subscription_url":"https://api.github.com/repos/darktable-org/darktable/subscription","commits_url":"https://api.github.com/repos/darktable-org/darktable/commits{/sha}","git_commits_url":"https://api.github.com/repos/darktable-org/darktable/git/commits{/sha}","comments_url":"https://api.github.com/repos/darktable-org/darktable/comments{/number}","issue_comment_url":"https://api.github.com/repos/darktable-org/darktable/issues/comments/{number}","contents_url":"https://api.github.com/repos/darktable-org/darktable/contents/{+path}","compare_url":"https://api.github.com/repos/darktable-org/darktable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/darktable-org/darktable/merges","archive_url":"https://api.github.com/repos/darktable-org/darktable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/darktable-org/darktable/downloads","issues_url":"https://api.github.com/repos/darktable-org/darktable/issues{/number}","pulls_url":"https://api.github.com/repos/darktable-org/darktable/pulls{/number}","milestones_url":"https://api.github.com/repos/darktable-org/darktable/milestones{/number}","notifications_url":"https://api.github.com/repos/darktable-org/darktable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/darktable-org/darktable/labels{/name}","releases_url":"https://api.github.com/repos/darktable-org/darktable/releases{/id}","created_at":"2012-03-21T21:53:04Z","updated_at":"2015-01-24T21:47:58Z","pushed_at":"2015-01-24T21:47:57Z","git_url":"git://github.com/darktable-org/darktable.git","ssh_url":"git@github.com:darktable-org/darktable.git","clone_url":"https://github.com/darktable-org/darktable.git","svn_url":"https://github.com/darktable-org/darktable","homepage":"http://www.darktable.org","size":201499,"stargazers_count":405,"watchers_count":405,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":180,"mirror_url":null,"open_issues_count":12,"forks":180,"open_issues":12,"watchers":405,"default_branch":"master"}},"base":{"label":"darktable-org:master","ref":"master","sha":"408248e756bfa0add57183b5087b5ddce98cf7e5","user":{"login":"darktable-org","id":1561544,"avatar_url":"https://avatars.githubusercontent.com/u/1561544?v=3","gravatar_id":"","url":"https://api.github.com/users/darktable-org","html_url":"https://github.com/darktable-org","followers_url":"https://api.github.com/users/darktable-org/followers","following_url":"https://api.github.com/users/darktable-org/following{/other_user}","gists_url":"https://api.github.com/users/darktable-org/gists{/gist_id}","starred_url":"https://api.github.com/users/darktable-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darktable-org/subscriptions","organizations_url":"https://api.github.com/users/darktable-org/orgs","repos_url":"https://api.github.com/users/darktable-org/repos","events_url":"https://api.github.com/users/darktable-org/events{/privacy}","received_events_url":"https://api.github.com/users/darktable-org/received_events","type":"Organization","site_admin":false},"repo":{"id":3791835,"name":"darktable","full_name":"darktable-org/darktable","owner":{"login":"darktable-org","id":1561544,"avatar_url":"https://avatars.githubusercontent.com/u/1561544?v=3","gravatar_id":"","url":"https://api.github.com/users/darktable-org","html_url":"https://github.com/darktable-org","followers_url":"https://api.github.com/users/darktable-org/followers","following_url":"https://api.github.com/users/darktable-org/following{/other_user}","gists_url":"https://api.github.com/users/darktable-org/gists{/gist_id}","starred_url":"https://api.github.com/users/darktable-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darktable-org/subscriptions","organizations_url":"https://api.github.com/users/darktable-org/orgs","repos_url":"https://api.github.com/users/darktable-org/repos","events_url":"https://api.github.com/users/darktable-org/events{/privacy}","received_events_url":"https://api.github.com/users/darktable-org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/darktable-org/darktable","description":"darktable main repository","fork":false,"url":"https://api.github.com/repos/darktable-org/darktable","forks_url":"https://api.github.com/repos/darktable-org/darktable/forks","keys_url":"https://api.github.com/repos/darktable-org/darktable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/darktable-org/darktable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/darktable-org/darktable/teams","hooks_url":"https://api.github.com/repos/darktable-org/darktable/hooks","issue_events_url":"https://api.github.com/repos/darktable-org/darktable/issues/events{/number}","events_url":"https://api.github.com/repos/darktable-org/darktable/events","assignees_url":"https://api.github.com/repos/darktable-org/darktable/assignees{/user}","branches_url":"https://api.github.com/repos/darktable-org/darktable/branches{/branch}","tags_url":"https://api.github.com/repos/darktable-org/darktable/tags","blobs_url":"https://api.github.com/repos/darktable-org/darktable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/darktable-org/darktable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/darktable-org/darktable/git/refs{/sha}","trees_url":"https://api.github.com/repos/darktable-org/darktable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/darktable-org/darktable/statuses/{sha}","languages_url":"https://api.github.com/repos/darktable-org/darktable/languages","stargazers_url":"https://api.github.com/repos/darktable-org/darktable/stargazers","contributors_url":"https://api.github.com/repos/darktable-org/darktable/contributors","subscribers_url":"https://api.github.com/repos/darktable-org/darktable/subscribers","subscription_url":"https://api.github.com/repos/darktable-org/darktable/subscription","commits_url":"https://api.github.com/repos/darktable-org/darktable/commits{/sha}","git_commits_url":"https://api.github.com/repos/darktable-org/darktable/git/commits{/sha}","comments_url":"https://api.github.com/repos/darktable-org/darktable/comments{/number}","issue_comment_url":"https://api.github.com/repos/darktable-org/darktable/issues/comments/{number}","contents_url":"https://api.github.com/repos/darktable-org/darktable/contents/{+path}","compare_url":"https://api.github.com/repos/darktable-org/darktable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/darktable-org/darktable/merges","archive_url":"https://api.github.com/repos/darktable-org/darktable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/darktable-org/darktable/downloads","issues_url":"https://api.github.com/repos/darktable-org/darktable/issues{/number}","pulls_url":"https://api.github.com/repos/darktable-org/darktable/pulls{/number}","milestones_url":"https://api.github.com/repos/darktable-org/darktable/milestones{/number}","notifications_url":"https://api.github.com/repos/darktable-org/darktable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/darktable-org/darktable/labels{/name}","releases_url":"https://api.github.com/repos/darktable-org/darktable/releases{/id}","created_at":"2012-03-21T21:53:04Z","updated_at":"2015-01-24T21:47:58Z","pushed_at":"2015-01-24T21:47:57Z","git_url":"git://github.com/darktable-org/darktable.git","ssh_url":"git@github.com:darktable-org/darktable.git","clone_url":"https://github.com/darktable-org/darktable.git","svn_url":"https://github.com/darktable-org/darktable","homepage":"http://www.darktable.org","size":201499,"stargazers_count":405,"watchers_count":405,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":180,"mirror_url":null,"open_issues_count":12,"forks":180,"open_issues":12,"watchers":405,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/darktable-org/darktable/pulls/829"},"html":{"href":"https://github.com/darktable-org/darktable/pull/829"},"issue":{"href":"https://api.github.com/repos/darktable-org/darktable/issues/829"},"comments":{"href":"https://api.github.com/repos/darktable-org/darktable/issues/829/comments"},"review_comments":{"href":"https://api.github.com/repos/darktable-org/darktable/pulls/829/comments"},"review_comment":{"href":"https://api.github.com/repos/darktable-org/darktable/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/darktable-org/darktable/pulls/829/commits"},"statuses":{"href":"https://api.github.com/repos/darktable-org/darktable/statuses/3a32613a807fe78a9741bf8498ceae6d00407319"}}}}