{"action":"created","comment":{"url":"https://api.github.com/repos/mochajs/mocha/pulls/comments/32574501","id":32574501,"diff_hunk":"@@ -0,0 +1,113 @@\n+{\n+  \"env\": {\n+    \"browser\": true,\n+    \"node\": true\n+  },\n+\n+  \"rules\": {\n+    // Maybe enable?\n+    \"one-var\": 0,\n+    \"vars-on-top\": 0,\n+    \"eqeqeq\": 0,\n+    \"yoda\": [0, \"never\"],","path":".eslintrc","position":12,"original_position":12,"commit_id":"dd2cd27ed81aeb41495a8197fb323d7fa87286ee","original_commit_id":"f07cf2d93c8085b545511eb4dd8ba14af5c83cd0","user":{"login":"ndhoule","id":1863990,"avatar_url":"https://avatars.githubusercontent.com/u/1863990?v=3","gravatar_id":"","url":"https://api.github.com/users/ndhoule","html_url":"https://github.com/ndhoule","followers_url":"https://api.github.com/users/ndhoule/followers","following_url":"https://api.github.com/users/ndhoule/following{/other_user}","gists_url":"https://api.github.com/users/ndhoule/gists{/gist_id}","starred_url":"https://api.github.com/users/ndhoule/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndhoule/subscriptions","organizations_url":"https://api.github.com/users/ndhoule/orgs","repos_url":"https://api.github.com/users/ndhoule/repos","events_url":"https://api.github.com/users/ndhoule/events{/privacy}","received_events_url":"https://api.github.com/users/ndhoule/received_events","type":"User","site_admin":false},"body":"Yeah totally, I generally enable the jshint/eslint rules that prohibit assignments inside of `if`s so I've never been bitten by this","created_at":"2015-06-16T21:42:22Z","updated_at":"2015-06-16T21:42:22Z","html_url":"https://github.com/mochajs/mocha/pull/1750#discussion_r32574501","pull_request_url":"https://api.github.com/repos/mochajs/mocha/pulls/1750","_links":{"self":{"href":"https://api.github.com/repos/mochajs/mocha/pulls/comments/32574501"},"html":{"href":"https://github.com/mochajs/mocha/pull/1750#discussion_r32574501"},"pull_request":{"href":"https://api.github.com/repos/mochajs/mocha/pulls/1750"}}},"pull_request":{"url":"https://api.github.com/repos/mochajs/mocha/pulls/1750","id":37841729,"html_url":"https://github.com/mochajs/mocha/pull/1750","diff_url":"https://github.com/mochajs/mocha/pull/1750.diff","patch_url":"https://github.com/mochajs/mocha/pull/1750.patch","issue_url":"https://api.github.com/repos/mochajs/mocha/issues/1750","number":1750,"state":"open","locked":false,"title":"Add linter","user":{"login":"ndhoule","id":1863990,"avatar_url":"https://avatars.githubusercontent.com/u/1863990?v=3","gravatar_id":"","url":"https://api.github.com/users/ndhoule","html_url":"https://github.com/ndhoule","followers_url":"https://api.github.com/users/ndhoule/followers","following_url":"https://api.github.com/users/ndhoule/following{/other_user}","gists_url":"https://api.github.com/users/ndhoule/gists{/gist_id}","starred_url":"https://api.github.com/users/ndhoule/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndhoule/subscriptions","organizations_url":"https://api.github.com/users/ndhoule/orgs","repos_url":"https://api.github.com/users/ndhoule/repos","events_url":"https://api.github.com/users/ndhoule/events{/privacy}","received_events_url":"https://api.github.com/users/ndhoule/received_events","type":"User","site_admin":false},"body":"@jbnicolai @boneskull \r\n\r\nAddresses https://github.com/mochajs/mocha/issues/1359\r\n\r\nThe Make task uses eslint's `--reset` flag to disable all default ESLint settings because [ESLint is planning on making that the default in the future](https://github.com/eslint/eslint/issues/2100#issuecomment-98030925) and I'd rather not have to go back through and change all the settings when that happens. I know there are a lot of settings here, but would be good to get some feedback on what's here. Most of the rules are pretty uncontroversial and we already follow them, but there are a few sections (labeled in `.eslintrc`) worth looking at.\r\n\r\nWe should also add more directories (e.g. `bin` and `test`), but I'm thinking we can do that in a separate PR to speed this one along to minimize merge conflicts. (Happy to handle that too.)\r\n","created_at":"2015-06-16T21:08:24Z","updated_at":"2015-06-16T21:42:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d3f7136e2b099650f34ee675008f77ae574e5290","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mochajs/mocha/pulls/1750/commits","review_comments_url":"https://api.github.com/repos/mochajs/mocha/pulls/1750/comments","review_comment_url":"https://api.github.com/repos/mochajs/mocha/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mochajs/mocha/issues/1750/comments","statuses_url":"https://api.github.com/repos/mochajs/mocha/statuses/dd2cd27ed81aeb41495a8197fb323d7fa87286ee","head":{"label":"ndhoule:chore/linting","ref":"chore/linting","sha":"dd2cd27ed81aeb41495a8197fb323d7fa87286ee","user":{"login":"ndhoule","id":1863990,"avatar_url":"https://avatars.githubusercontent.com/u/1863990?v=3","gravatar_id":"","url":"https://api.github.com/users/ndhoule","html_url":"https://github.com/ndhoule","followers_url":"https://api.github.com/users/ndhoule/followers","following_url":"https://api.github.com/users/ndhoule/following{/other_user}","gists_url":"https://api.github.com/users/ndhoule/gists{/gist_id}","starred_url":"https://api.github.com/users/ndhoule/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndhoule/subscriptions","organizations_url":"https://api.github.com/users/ndhoule/orgs","repos_url":"https://api.github.com/users/ndhoule/repos","events_url":"https://api.github.com/users/ndhoule/events{/privacy}","received_events_url":"https://api.github.com/users/ndhoule/received_events","type":"User","site_admin":false},"repo":{"id":36967901,"name":"mocha","full_name":"ndhoule/mocha","owner":{"login":"ndhoule","id":1863990,"avatar_url":"https://avatars.githubusercontent.com/u/1863990?v=3","gravatar_id":"","url":"https://api.github.com/users/ndhoule","html_url":"https://github.com/ndhoule","followers_url":"https://api.github.com/users/ndhoule/followers","following_url":"https://api.github.com/users/ndhoule/following{/other_user}","gists_url":"https://api.github.com/users/ndhoule/gists{/gist_id}","starred_url":"https://api.github.com/users/ndhoule/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndhoule/subscriptions","organizations_url":"https://api.github.com/users/ndhoule/orgs","repos_url":"https://api.github.com/users/ndhoule/repos","events_url":"https://api.github.com/users/ndhoule/events{/privacy}","received_events_url":"https://api.github.com/users/ndhoule/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ndhoule/mocha","description":"mocha - simple, flexible, fun javascript test framework for node.js & the browser. (BDD, TDD, QUnit styles via interfaces)","fork":true,"url":"https://api.github.com/repos/ndhoule/mocha","forks_url":"https://api.github.com/repos/ndhoule/mocha/forks","keys_url":"https://api.github.com/repos/ndhoule/mocha/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ndhoule/mocha/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ndhoule/mocha/teams","hooks_url":"https://api.github.com/repos/ndhoule/mocha/hooks","issue_events_url":"https://api.github.com/repos/ndhoule/mocha/issues/events{/number}","events_url":"https://api.github.com/repos/ndhoule/mocha/events","assignees_url":"https://api.github.com/repos/ndhoule/mocha/assignees{/user}","branches_url":"https://api.github.com/repos/ndhoule/mocha/branches{/branch}","tags_url":"https://api.github.com/repos/ndhoule/mocha/tags","blobs_url":"https://api.github.com/repos/ndhoule/mocha/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ndhoule/mocha/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ndhoule/mocha/git/refs{/sha}","trees_url":"https://api.github.com/repos/ndhoule/mocha/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ndhoule/mocha/statuses/{sha}","languages_url":"https://api.github.com/repos/ndhoule/mocha/languages","stargazers_url":"https://api.github.com/repos/ndhoule/mocha/stargazers","contributors_url":"https://api.github.com/repos/ndhoule/mocha/contributors","subscribers_url":"https://api.github.com/repos/ndhoule/mocha/subscribers","subscription_url":"https://api.github.com/repos/ndhoule/mocha/subscription","commits_url":"https://api.github.com/repos/ndhoule/mocha/commits{/sha}","git_commits_url":"https://api.github.com/repos/ndhoule/mocha/git/commits{/sha}","comments_url":"https://api.github.com/repos/ndhoule/mocha/comments{/number}","issue_comment_url":"https://api.github.com/repos/ndhoule/mocha/issues/comments{/number}","contents_url":"https://api.github.com/repos/ndhoule/mocha/contents/{+path}","compare_url":"https://api.github.com/repos/ndhoule/mocha/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ndhoule/mocha/merges","archive_url":"https://api.github.com/repos/ndhoule/mocha/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ndhoule/mocha/downloads","issues_url":"https://api.github.com/repos/ndhoule/mocha/issues{/number}","pulls_url":"https://api.github.com/repos/ndhoule/mocha/pulls{/number}","milestones_url":"https://api.github.com/repos/ndhoule/mocha/milestones{/number}","notifications_url":"https://api.github.com/repos/ndhoule/mocha/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ndhoule/mocha/labels{/name}","releases_url":"https://api.github.com/repos/ndhoule/mocha/releases{/id}","created_at":"2015-06-06T04:54:57Z","updated_at":"2015-06-06T04:54:59Z","pushed_at":"2015-06-16T21:20:39Z","git_url":"git://github.com/ndhoule/mocha.git","ssh_url":"git@github.com:ndhoule/mocha.git","clone_url":"https://github.com/ndhoule/mocha.git","svn_url":"https://github.com/ndhoule/mocha","homepage":"http://mochajs.org","size":5117,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mochajs:master","ref":"master","sha":"44b0045463907b1d7963a2e9560c24d9552aac5d","user":{"login":"mochajs","id":8770005,"avatar_url":"https://avatars.githubusercontent.com/u/8770005?v=3","gravatar_id":"","url":"https://api.github.com/users/mochajs","html_url":"https://github.com/mochajs","followers_url":"https://api.github.com/users/mochajs/followers","following_url":"https://api.github.com/users/mochajs/following{/other_user}","gists_url":"https://api.github.com/users/mochajs/gists{/gist_id}","starred_url":"https://api.github.com/users/mochajs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mochajs/subscriptions","organizations_url":"https://api.github.com/users/mochajs/orgs","repos_url":"https://api.github.com/users/mochajs/repos","events_url":"https://api.github.com/users/mochajs/events{/privacy}","received_events_url":"https://api.github.com/users/mochajs/received_events","type":"Organization","site_admin":false},"repo":{"id":1451352,"name":"mocha","full_name":"mochajs/mocha","owner":{"login":"mochajs","id":8770005,"avatar_url":"https://avatars.githubusercontent.com/u/8770005?v=3","gravatar_id":"","url":"https://api.github.com/users/mochajs","html_url":"https://github.com/mochajs","followers_url":"https://api.github.com/users/mochajs/followers","following_url":"https://api.github.com/users/mochajs/following{/other_user}","gists_url":"https://api.github.com/users/mochajs/gists{/gist_id}","starred_url":"https://api.github.com/users/mochajs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mochajs/subscriptions","organizations_url":"https://api.github.com/users/mochajs/orgs","repos_url":"https://api.github.com/users/mochajs/repos","events_url":"https://api.github.com/users/mochajs/events{/privacy}","received_events_url":"https://api.github.com/users/mochajs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mochajs/mocha","description":"mocha - simple, flexible, fun javascript test framework for node.js & the browser. (BDD, TDD, QUnit styles via interfaces)","fork":false,"url":"https://api.github.com/repos/mochajs/mocha","forks_url":"https://api.github.com/repos/mochajs/mocha/forks","keys_url":"https://api.github.com/repos/mochajs/mocha/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mochajs/mocha/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mochajs/mocha/teams","hooks_url":"https://api.github.com/repos/mochajs/mocha/hooks","issue_events_url":"https://api.github.com/repos/mochajs/mocha/issues/events{/number}","events_url":"https://api.github.com/repos/mochajs/mocha/events","assignees_url":"https://api.github.com/repos/mochajs/mocha/assignees{/user}","branches_url":"https://api.github.com/repos/mochajs/mocha/branches{/branch}","tags_url":"https://api.github.com/repos/mochajs/mocha/tags","blobs_url":"https://api.github.com/repos/mochajs/mocha/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mochajs/mocha/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mochajs/mocha/git/refs{/sha}","trees_url":"https://api.github.com/repos/mochajs/mocha/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mochajs/mocha/statuses/{sha}","languages_url":"https://api.github.com/repos/mochajs/mocha/languages","stargazers_url":"https://api.github.com/repos/mochajs/mocha/stargazers","contributors_url":"https://api.github.com/repos/mochajs/mocha/contributors","subscribers_url":"https://api.github.com/repos/mochajs/mocha/subscribers","subscription_url":"https://api.github.com/repos/mochajs/mocha/subscription","commits_url":"https://api.github.com/repos/mochajs/mocha/commits{/sha}","git_commits_url":"https://api.github.com/repos/mochajs/mocha/git/commits{/sha}","comments_url":"https://api.github.com/repos/mochajs/mocha/comments{/number}","issue_comment_url":"https://api.github.com/repos/mochajs/mocha/issues/comments{/number}","contents_url":"https://api.github.com/repos/mochajs/mocha/contents/{+path}","compare_url":"https://api.github.com/repos/mochajs/mocha/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mochajs/mocha/merges","archive_url":"https://api.github.com/repos/mochajs/mocha/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mochajs/mocha/downloads","issues_url":"https://api.github.com/repos/mochajs/mocha/issues{/number}","pulls_url":"https://api.github.com/repos/mochajs/mocha/pulls{/number}","milestones_url":"https://api.github.com/repos/mochajs/mocha/milestones{/number}","notifications_url":"https://api.github.com/repos/mochajs/mocha/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mochajs/mocha/labels{/name}","releases_url":"https://api.github.com/repos/mochajs/mocha/releases{/id}","created_at":"2011-03-07T18:44:25Z","updated_at":"2015-06-16T21:42:13Z","pushed_at":"2015-06-16T21:20:41Z","git_url":"git://github.com/mochajs/mocha.git","ssh_url":"git@github.com:mochajs/mocha.git","clone_url":"https://github.com/mochajs/mocha.git","svn_url":"https://github.com/mochajs/mocha","homepage":"http://mochajs.org","size":12690,"stargazers_count":6838,"watchers_count":6838,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1067,"mirror_url":null,"open_issues_count":155,"forks":1067,"open_issues":155,"watchers":6838,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mochajs/mocha/pulls/1750"},"html":{"href":"https://github.com/mochajs/mocha/pull/1750"},"issue":{"href":"https://api.github.com/repos/mochajs/mocha/issues/1750"},"comments":{"href":"https://api.github.com/repos/mochajs/mocha/issues/1750/comments"},"review_comments":{"href":"https://api.github.com/repos/mochajs/mocha/pulls/1750/comments"},"review_comment":{"href":"https://api.github.com/repos/mochajs/mocha/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mochajs/mocha/pulls/1750/commits"},"statuses":{"href":"https://api.github.com/repos/mochajs/mocha/statuses/dd2cd27ed81aeb41495a8197fb323d7fa87286ee"}}}}