{"action":"created","comment":{"url":"https://api.github.com/repos/Elgg/Elgg/pulls/comments/24294120","id":24294120,"diff_hunk":"@@ -58,60 +79,30 @@ CREATE TABLE `prefix_config` (\n   PRIMARY KEY (`name`,`site_guid`)\n ) ENGINE=MyISAM DEFAULT CHARSET=utf8;\n \n--- application specific configuration\n-CREATE TABLE `prefix_datalists` (\n-  `name` varchar(255) NOT NULL,\n-  `value` text NOT NULL,\n-  PRIMARY KEY (`name`)\n-) ENGINE=MyISAM DEFAULT CHARSET=utf8;\n-\n -- primary entity table\n CREATE TABLE `prefix_entities` (\n   `guid` bigint(20) unsigned NOT NULL AUTO_INCREMENT,\n-  `type` enum('object','user','group','site') NOT NULL,\n-  `subtype` int(11) DEFAULT NULL,\n+  `type_id` int(11) NOT NULL, -- type\n+  `subtype_id` int(11) DEFAULT NULL, -- type\n+  `title_id` int(11) unsigned NOT NULL, -- metastring\n+  `description_id` int(11) unsigned NOT NULL, -- metastring\n   `owner_guid` bigint(20) unsigned NOT NULL,\n   `site_guid` bigint(20) unsigned NOT NULL,\n   `container_guid` bigint(20) unsigned NOT NULL,\n-  `access_id` int(11) NOT NULL,\n   `time_created` int(11) NOT NULL,\n   `time_updated` int(11) NOT NULL,\n   `last_action` int(11) NOT NULL DEFAULT '0',\n   `enabled` enum('yes','no') NOT NULL DEFAULT 'yes',\n   PRIMARY KEY (`guid`),\n-  KEY `type` (`type`),\n-  KEY `subtype` (`subtype`),\n+  KEY `type_id` (`type_id`),\n+  KEY `subtype_id` (`subtype_id`),\n   KEY `owner_guid` (`owner_guid`),\n   KEY `site_guid` (`site_guid`),\n   KEY `container_guid` (`container_guid`),\n-  KEY `access_id` (`access_id`),","path":"engine/schema/mysql.sql","position":95,"original_position":95,"commit_id":"9514e546e1831f6730760b70723c3cce941fbd0c","original_commit_id":"9514e546e1831f6730760b70723c3cce941fbd0c","user":{"login":"mrclay","id":170687,"avatar_url":"https://avatars.githubusercontent.com/u/170687?v=3","gravatar_id":"","url":"https://api.github.com/users/mrclay","html_url":"https://github.com/mrclay","followers_url":"https://api.github.com/users/mrclay/followers","following_url":"https://api.github.com/users/mrclay/following{/other_user}","gists_url":"https://api.github.com/users/mrclay/gists{/gist_id}","starred_url":"https://api.github.com/users/mrclay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrclay/subscriptions","organizations_url":"https://api.github.com/users/mrclay/orgs","repos_url":"https://api.github.com/users/mrclay/repos","events_url":"https://api.github.com/users/mrclay/events{/privacy}","received_events_url":"https://api.github.com/users/mrclay/received_events","type":"User","site_admin":false},"body":"ACLs grant read perms to entities. Fixes a lot of problems","created_at":"2015-02-08T00:01:53Z","updated_at":"2015-02-08T00:01:53Z","html_url":"https://github.com/Elgg/Elgg/pull/7875#discussion_r24294120","pull_request_url":"https://api.github.com/repos/Elgg/Elgg/pulls/7875","_links":{"self":{"href":"https://api.github.com/repos/Elgg/Elgg/pulls/comments/24294120"},"html":{"href":"https://github.com/Elgg/Elgg/pull/7875#discussion_r24294120"},"pull_request":{"href":"https://api.github.com/repos/Elgg/Elgg/pulls/7875"}}},"pull_request":{"url":"https://api.github.com/repos/Elgg/Elgg/pulls/7875","id":28872414,"html_url":"https://github.com/Elgg/Elgg/pull/7875","diff_url":"https://github.com/Elgg/Elgg/pull/7875.diff","patch_url":"https://github.com/Elgg/Elgg/pull/7875.patch","issue_url":"https://api.github.com/repos/Elgg/Elgg/issues/7875","number":7875,"state":"open","locked":false,"title":"WIP: Ideas for schema changes","user":{"login":"mrclay","id":170687,"avatar_url":"https://avatars.githubusercontent.com/u/170687?v=3","gravatar_id":"","url":"https://api.github.com/users/mrclay","html_url":"https://github.com/mrclay","followers_url":"https://api.github.com/users/mrclay/followers","following_url":"https://api.github.com/users/mrclay/following{/other_user}","gists_url":"https://api.github.com/users/mrclay/gists{/gist_id}","starred_url":"https://api.github.com/users/mrclay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrclay/subscriptions","organizations_url":"https://api.github.com/users/mrclay/orgs","repos_url":"https://api.github.com/users/mrclay/repos","events_url":"https://api.github.com/users/mrclay/events{/privacy}","received_events_url":"https://api.github.com/users/mrclay/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-02-07T23:52:26Z","updated_at":"2015-02-08T00:01:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5f1d1e87f4124834b2344724779a9654366d29a0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Elgg/Elgg/pulls/7875/commits","review_comments_url":"https://api.github.com/repos/Elgg/Elgg/pulls/7875/comments","review_comment_url":"https://api.github.com/repos/Elgg/Elgg/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Elgg/Elgg/issues/7875/comments","statuses_url":"https://api.github.com/repos/Elgg/Elgg/statuses/9514e546e1831f6730760b70723c3cce941fbd0c","head":{"label":"mrclay:schema_changes","ref":"schema_changes","sha":"9514e546e1831f6730760b70723c3cce941fbd0c","user":{"login":"mrclay","id":170687,"avatar_url":"https://avatars.githubusercontent.com/u/170687?v=3","gravatar_id":"","url":"https://api.github.com/users/mrclay","html_url":"https://github.com/mrclay","followers_url":"https://api.github.com/users/mrclay/followers","following_url":"https://api.github.com/users/mrclay/following{/other_user}","gists_url":"https://api.github.com/users/mrclay/gists{/gist_id}","starred_url":"https://api.github.com/users/mrclay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrclay/subscriptions","organizations_url":"https://api.github.com/users/mrclay/orgs","repos_url":"https://api.github.com/users/mrclay/repos","events_url":"https://api.github.com/users/mrclay/events{/privacy}","received_events_url":"https://api.github.com/users/mrclay/received_events","type":"User","site_admin":false},"repo":{"id":2142685,"name":"Elgg-leaf","full_name":"mrclay/Elgg-leaf","owner":{"login":"mrclay","id":170687,"avatar_url":"https://avatars.githubusercontent.com/u/170687?v=3","gravatar_id":"","url":"https://api.github.com/users/mrclay","html_url":"https://github.com/mrclay","followers_url":"https://api.github.com/users/mrclay/followers","following_url":"https://api.github.com/users/mrclay/following{/other_user}","gists_url":"https://api.github.com/users/mrclay/gists{/gist_id}","starred_url":"https://api.github.com/users/mrclay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrclay/subscriptions","organizations_url":"https://api.github.com/users/mrclay/orgs","repos_url":"https://api.github.com/users/mrclay/repos","events_url":"https://api.github.com/users/mrclay/events{/privacy}","received_events_url":"https://api.github.com/users/mrclay/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mrclay/Elgg-leaf","description":"A social networking engine","fork":true,"url":"https://api.github.com/repos/mrclay/Elgg-leaf","forks_url":"https://api.github.com/repos/mrclay/Elgg-leaf/forks","keys_url":"https://api.github.com/repos/mrclay/Elgg-leaf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mrclay/Elgg-leaf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mrclay/Elgg-leaf/teams","hooks_url":"https://api.github.com/repos/mrclay/Elgg-leaf/hooks","issue_events_url":"https://api.github.com/repos/mrclay/Elgg-leaf/issues/events{/number}","events_url":"https://api.github.com/repos/mrclay/Elgg-leaf/events","assignees_url":"https://api.github.com/repos/mrclay/Elgg-leaf/assignees{/user}","branches_url":"https://api.github.com/repos/mrclay/Elgg-leaf/branches{/branch}","tags_url":"https://api.github.com/repos/mrclay/Elgg-leaf/tags","blobs_url":"https://api.github.com/repos/mrclay/Elgg-leaf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mrclay/Elgg-leaf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mrclay/Elgg-leaf/git/refs{/sha}","trees_url":"https://api.github.com/repos/mrclay/Elgg-leaf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mrclay/Elgg-leaf/statuses/{sha}","languages_url":"https://api.github.com/repos/mrclay/Elgg-leaf/languages","stargazers_url":"https://api.github.com/repos/mrclay/Elgg-leaf/stargazers","contributors_url":"https://api.github.com/repos/mrclay/Elgg-leaf/contributors","subscribers_url":"https://api.github.com/repos/mrclay/Elgg-leaf/subscribers","subscription_url":"https://api.github.com/repos/mrclay/Elgg-leaf/subscription","commits_url":"https://api.github.com/repos/mrclay/Elgg-leaf/commits{/sha}","git_commits_url":"https://api.github.com/repos/mrclay/Elgg-leaf/git/commits{/sha}","comments_url":"https://api.github.com/repos/mrclay/Elgg-leaf/comments{/number}","issue_comment_url":"https://api.github.com/repos/mrclay/Elgg-leaf/issues/comments/{number}","contents_url":"https://api.github.com/repos/mrclay/Elgg-leaf/contents/{+path}","compare_url":"https://api.github.com/repos/mrclay/Elgg-leaf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mrclay/Elgg-leaf/merges","archive_url":"https://api.github.com/repos/mrclay/Elgg-leaf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mrclay/Elgg-leaf/downloads","issues_url":"https://api.github.com/repos/mrclay/Elgg-leaf/issues{/number}","pulls_url":"https://api.github.com/repos/mrclay/Elgg-leaf/pulls{/number}","milestones_url":"https://api.github.com/repos/mrclay/Elgg-leaf/milestones{/number}","notifications_url":"https://api.github.com/repos/mrclay/Elgg-leaf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mrclay/Elgg-leaf/labels{/name}","releases_url":"https://api.github.com/repos/mrclay/Elgg-leaf/releases{/id}","created_at":"2011-08-02T13:45:11Z","updated_at":"2014-06-24T23:34:38Z","pushed_at":"2015-02-07T23:51:47Z","git_url":"git://github.com/mrclay/Elgg-leaf.git","ssh_url":"git@github.com:mrclay/Elgg-leaf.git","clone_url":"https://github.com/mrclay/Elgg-leaf.git","svn_url":"https://github.com/mrclay/Elgg-leaf","homepage":"http://elgg.org","size":39774,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"Elgg:master","ref":"master","sha":"0725f0b6e35f4985d8e3cecae6bbfd4302085150","user":{"login":"Elgg","id":79167,"avatar_url":"https://avatars.githubusercontent.com/u/79167?v=3","gravatar_id":"","url":"https://api.github.com/users/Elgg","html_url":"https://github.com/Elgg","followers_url":"https://api.github.com/users/Elgg/followers","following_url":"https://api.github.com/users/Elgg/following{/other_user}","gists_url":"https://api.github.com/users/Elgg/gists{/gist_id}","starred_url":"https://api.github.com/users/Elgg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Elgg/subscriptions","organizations_url":"https://api.github.com/users/Elgg/orgs","repos_url":"https://api.github.com/users/Elgg/repos","events_url":"https://api.github.com/users/Elgg/events{/privacy}","received_events_url":"https://api.github.com/users/Elgg/received_events","type":"Organization","site_admin":false},"repo":{"id":299271,"name":"Elgg","full_name":"Elgg/Elgg","owner":{"login":"Elgg","id":79167,"avatar_url":"https://avatars.githubusercontent.com/u/79167?v=3","gravatar_id":"","url":"https://api.github.com/users/Elgg","html_url":"https://github.com/Elgg","followers_url":"https://api.github.com/users/Elgg/followers","following_url":"https://api.github.com/users/Elgg/following{/other_user}","gists_url":"https://api.github.com/users/Elgg/gists{/gist_id}","starred_url":"https://api.github.com/users/Elgg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Elgg/subscriptions","organizations_url":"https://api.github.com/users/Elgg/orgs","repos_url":"https://api.github.com/users/Elgg/repos","events_url":"https://api.github.com/users/Elgg/events{/privacy}","received_events_url":"https://api.github.com/users/Elgg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Elgg/Elgg","description":"A social networking engine","fork":false,"url":"https://api.github.com/repos/Elgg/Elgg","forks_url":"https://api.github.com/repos/Elgg/Elgg/forks","keys_url":"https://api.github.com/repos/Elgg/Elgg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Elgg/Elgg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Elgg/Elgg/teams","hooks_url":"https://api.github.com/repos/Elgg/Elgg/hooks","issue_events_url":"https://api.github.com/repos/Elgg/Elgg/issues/events{/number}","events_url":"https://api.github.com/repos/Elgg/Elgg/events","assignees_url":"https://api.github.com/repos/Elgg/Elgg/assignees{/user}","branches_url":"https://api.github.com/repos/Elgg/Elgg/branches{/branch}","tags_url":"https://api.github.com/repos/Elgg/Elgg/tags","blobs_url":"https://api.github.com/repos/Elgg/Elgg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Elgg/Elgg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Elgg/Elgg/git/refs{/sha}","trees_url":"https://api.github.com/repos/Elgg/Elgg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Elgg/Elgg/statuses/{sha}","languages_url":"https://api.github.com/repos/Elgg/Elgg/languages","stargazers_url":"https://api.github.com/repos/Elgg/Elgg/stargazers","contributors_url":"https://api.github.com/repos/Elgg/Elgg/contributors","subscribers_url":"https://api.github.com/repos/Elgg/Elgg/subscribers","subscription_url":"https://api.github.com/repos/Elgg/Elgg/subscription","commits_url":"https://api.github.com/repos/Elgg/Elgg/commits{/sha}","git_commits_url":"https://api.github.com/repos/Elgg/Elgg/git/commits{/sha}","comments_url":"https://api.github.com/repos/Elgg/Elgg/comments{/number}","issue_comment_url":"https://api.github.com/repos/Elgg/Elgg/issues/comments/{number}","contents_url":"https://api.github.com/repos/Elgg/Elgg/contents/{+path}","compare_url":"https://api.github.com/repos/Elgg/Elgg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Elgg/Elgg/merges","archive_url":"https://api.github.com/repos/Elgg/Elgg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Elgg/Elgg/downloads","issues_url":"https://api.github.com/repos/Elgg/Elgg/issues{/number}","pulls_url":"https://api.github.com/repos/Elgg/Elgg/pulls{/number}","milestones_url":"https://api.github.com/repos/Elgg/Elgg/milestones{/number}","notifications_url":"https://api.github.com/repos/Elgg/Elgg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Elgg/Elgg/labels{/name}","releases_url":"https://api.github.com/repos/Elgg/Elgg/releases{/id}","created_at":"2009-09-06T17:10:11Z","updated_at":"2015-02-06T16:13:24Z","pushed_at":"2015-02-05T07:53:55Z","git_url":"git://github.com/Elgg/Elgg.git","ssh_url":"git@github.com:Elgg/Elgg.git","clone_url":"https://github.com/Elgg/Elgg.git","svn_url":"https://github.com/Elgg/Elgg","homepage":"http://elgg.org","size":59756,"stargazers_count":669,"watchers_count":669,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":407,"mirror_url":null,"open_issues_count":771,"forks":407,"open_issues":771,"watchers":669,"default_branch":"1.10"}},"_links":{"self":{"href":"https://api.github.com/repos/Elgg/Elgg/pulls/7875"},"html":{"href":"https://github.com/Elgg/Elgg/pull/7875"},"issue":{"href":"https://api.github.com/repos/Elgg/Elgg/issues/7875"},"comments":{"href":"https://api.github.com/repos/Elgg/Elgg/issues/7875/comments"},"review_comments":{"href":"https://api.github.com/repos/Elgg/Elgg/pulls/7875/comments"},"review_comment":{"href":"https://api.github.com/repos/Elgg/Elgg/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Elgg/Elgg/pulls/7875/commits"},"statuses":{"href":"https://api.github.com/repos/Elgg/Elgg/statuses/9514e546e1831f6730760b70723c3cce941fbd0c"}}}}