{"action":"closed","number":36,"pull_request":{"url":"https://api.github.com/repos/non/cats/pulls/36","id":28446166,"html_url":"https://github.com/non/cats/pull/36","diff_url":"https://github.com/non/cats/pull/36.diff","patch_url":"https://github.com/non/cats/pull/36.patch","issue_url":"https://api.github.com/repos/non/cats/issues/36","number":36,"state":"closed","locked":false,"title":"A mostly clean room reimplementation of Or.","user":{"login":"rossabaker","id":142698,"avatar_url":"https://avatars.githubusercontent.com/u/142698?v=3","gravatar_id":"","url":"https://api.github.com/users/rossabaker","html_url":"https://github.com/rossabaker","followers_url":"https://api.github.com/users/rossabaker/followers","following_url":"https://api.github.com/users/rossabaker/following{/other_user}","gists_url":"https://api.github.com/users/rossabaker/gists{/gist_id}","starred_url":"https://api.github.com/users/rossabaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rossabaker/subscriptions","organizations_url":"https://api.github.com/users/rossabaker/orgs","repos_url":"https://api.github.com/users/rossabaker/repos","events_url":"https://api.github.com/users/rossabaker/events{/privacy}","received_events_url":"https://api.github.com/users/rossabaker/received_events","type":"User","site_admin":false},"body":"Implements feedback from #11.  Specifically:\r\n1. LOr and ROr move to `Or.LeftOr` and `Or.RightOr`.\r\n2. Constructors are still public, but `left` and `right` preserved in\r\n   `OrFunctions` to infer `Or`.  Use what you like.\r\n3. Only the Scaladoc is ripped from Scalaz.\r\n\r\nAlso tries to adhere to the emerging consensus on #27.\r\n\r\nPreliminary benchmarking showed monomorphism is faster than polymorphism,\r\nand that implementing other operations using fold/bimap is immeasurable.\r\nThe second finding is dubious with respect to allocations.  If someone\r\ncan prove these guilty via benchmark, we can revisit.\r\n\r\nI'd like to add tests after #29 happens.\r\n\r\nFixes #11.","created_at":"2015-02-02T05:29:46Z","updated_at":"2015-02-04T23:55:18Z","closed_at":"2015-02-04T23:55:18Z","merged_at":"2015-02-04T23:55:18Z","merge_commit_sha":"80e3b348d5537788d52e14f257d048790041987c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/non/cats/pulls/36/commits","review_comments_url":"https://api.github.com/repos/non/cats/pulls/36/comments","review_comment_url":"https://api.github.com/repos/non/cats/pulls/comments/{number}","comments_url":"https://api.github.com/repos/non/cats/issues/36/comments","statuses_url":"https://api.github.com/repos/non/cats/statuses/bb26aeee5fa5721668c155f934010ee928d40ec1","head":{"label":"rossabaker:topic/or-rewrite","ref":"topic/or-rewrite","sha":"bb26aeee5fa5721668c155f934010ee928d40ec1","user":{"login":"rossabaker","id":142698,"avatar_url":"https://avatars.githubusercontent.com/u/142698?v=3","gravatar_id":"","url":"https://api.github.com/users/rossabaker","html_url":"https://github.com/rossabaker","followers_url":"https://api.github.com/users/rossabaker/followers","following_url":"https://api.github.com/users/rossabaker/following{/other_user}","gists_url":"https://api.github.com/users/rossabaker/gists{/gist_id}","starred_url":"https://api.github.com/users/rossabaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rossabaker/subscriptions","organizations_url":"https://api.github.com/users/rossabaker/orgs","repos_url":"https://api.github.com/users/rossabaker/repos","events_url":"https://api.github.com/users/rossabaker/events{/privacy}","received_events_url":"https://api.github.com/users/rossabaker/received_events","type":"User","site_admin":false},"repo":{"id":30035669,"name":"cats","full_name":"rossabaker/cats","owner":{"login":"rossabaker","id":142698,"avatar_url":"https://avatars.githubusercontent.com/u/142698?v=3","gravatar_id":"","url":"https://api.github.com/users/rossabaker","html_url":"https://github.com/rossabaker","followers_url":"https://api.github.com/users/rossabaker/followers","following_url":"https://api.github.com/users/rossabaker/following{/other_user}","gists_url":"https://api.github.com/users/rossabaker/gists{/gist_id}","starred_url":"https://api.github.com/users/rossabaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rossabaker/subscriptions","organizations_url":"https://api.github.com/users/rossabaker/orgs","repos_url":"https://api.github.com/users/rossabaker/repos","events_url":"https://api.github.com/users/rossabaker/events{/privacy}","received_events_url":"https://api.github.com/users/rossabaker/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rossabaker/cats","description":"","fork":true,"url":"https://api.github.com/repos/rossabaker/cats","forks_url":"https://api.github.com/repos/rossabaker/cats/forks","keys_url":"https://api.github.com/repos/rossabaker/cats/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rossabaker/cats/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rossabaker/cats/teams","hooks_url":"https://api.github.com/repos/rossabaker/cats/hooks","issue_events_url":"https://api.github.com/repos/rossabaker/cats/issues/events{/number}","events_url":"https://api.github.com/repos/rossabaker/cats/events","assignees_url":"https://api.github.com/repos/rossabaker/cats/assignees{/user}","branches_url":"https://api.github.com/repos/rossabaker/cats/branches{/branch}","tags_url":"https://api.github.com/repos/rossabaker/cats/tags","blobs_url":"https://api.github.com/repos/rossabaker/cats/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rossabaker/cats/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rossabaker/cats/git/refs{/sha}","trees_url":"https://api.github.com/repos/rossabaker/cats/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rossabaker/cats/statuses/{sha}","languages_url":"https://api.github.com/repos/rossabaker/cats/languages","stargazers_url":"https://api.github.com/repos/rossabaker/cats/stargazers","contributors_url":"https://api.github.com/repos/rossabaker/cats/contributors","subscribers_url":"https://api.github.com/repos/rossabaker/cats/subscribers","subscription_url":"https://api.github.com/repos/rossabaker/cats/subscription","commits_url":"https://api.github.com/repos/rossabaker/cats/commits{/sha}","git_commits_url":"https://api.github.com/repos/rossabaker/cats/git/commits{/sha}","comments_url":"https://api.github.com/repos/rossabaker/cats/comments{/number}","issue_comment_url":"https://api.github.com/repos/rossabaker/cats/issues/comments/{number}","contents_url":"https://api.github.com/repos/rossabaker/cats/contents/{+path}","compare_url":"https://api.github.com/repos/rossabaker/cats/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rossabaker/cats/merges","archive_url":"https://api.github.com/repos/rossabaker/cats/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rossabaker/cats/downloads","issues_url":"https://api.github.com/repos/rossabaker/cats/issues{/number}","pulls_url":"https://api.github.com/repos/rossabaker/cats/pulls{/number}","milestones_url":"https://api.github.com/repos/rossabaker/cats/milestones{/number}","notifications_url":"https://api.github.com/repos/rossabaker/cats/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rossabaker/cats/labels{/name}","releases_url":"https://api.github.com/repos/rossabaker/cats/releases{/id}","created_at":"2015-01-29T18:53:10Z","updated_at":"2015-01-30T20:37:38Z","pushed_at":"2015-02-04T22:16:05Z","git_url":"git://github.com/rossabaker/cats.git","ssh_url":"git@github.com:rossabaker/cats.git","clone_url":"https://github.com/rossabaker/cats.git","svn_url":"https://github.com/rossabaker/cats","homepage":null,"size":231,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"non:master","ref":"master","sha":"0957e0598f9dac3cb6c6356f78b1adc8599c4291","user":{"login":"non","id":218045,"avatar_url":"https://avatars.githubusercontent.com/u/218045?v=3","gravatar_id":"","url":"https://api.github.com/users/non","html_url":"https://github.com/non","followers_url":"https://api.github.com/users/non/followers","following_url":"https://api.github.com/users/non/following{/other_user}","gists_url":"https://api.github.com/users/non/gists{/gist_id}","starred_url":"https://api.github.com/users/non/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/non/subscriptions","organizations_url":"https://api.github.com/users/non/orgs","repos_url":"https://api.github.com/users/non/repos","events_url":"https://api.github.com/users/non/events{/privacy}","received_events_url":"https://api.github.com/users/non/received_events","type":"User","site_admin":false},"repo":{"id":29986727,"name":"cats","full_name":"non/cats","owner":{"login":"non","id":218045,"avatar_url":"https://avatars.githubusercontent.com/u/218045?v=3","gravatar_id":"","url":"https://api.github.com/users/non","html_url":"https://github.com/non","followers_url":"https://api.github.com/users/non/followers","following_url":"https://api.github.com/users/non/following{/other_user}","gists_url":"https://api.github.com/users/non/gists{/gist_id}","starred_url":"https://api.github.com/users/non/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/non/subscriptions","organizations_url":"https://api.github.com/users/non/orgs","repos_url":"https://api.github.com/users/non/repos","events_url":"https://api.github.com/users/non/events{/privacy}","received_events_url":"https://api.github.com/users/non/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/non/cats","description":"","fork":false,"url":"https://api.github.com/repos/non/cats","forks_url":"https://api.github.com/repos/non/cats/forks","keys_url":"https://api.github.com/repos/non/cats/keys{/key_id}","collaborators_url":"https://api.github.com/repos/non/cats/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/non/cats/teams","hooks_url":"https://api.github.com/repos/non/cats/hooks","issue_events_url":"https://api.github.com/repos/non/cats/issues/events{/number}","events_url":"https://api.github.com/repos/non/cats/events","assignees_url":"https://api.github.com/repos/non/cats/assignees{/user}","branches_url":"https://api.github.com/repos/non/cats/branches{/branch}","tags_url":"https://api.github.com/repos/non/cats/tags","blobs_url":"https://api.github.com/repos/non/cats/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/non/cats/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/non/cats/git/refs{/sha}","trees_url":"https://api.github.com/repos/non/cats/git/trees{/sha}","statuses_url":"https://api.github.com/repos/non/cats/statuses/{sha}","languages_url":"https://api.github.com/repos/non/cats/languages","stargazers_url":"https://api.github.com/repos/non/cats/stargazers","contributors_url":"https://api.github.com/repos/non/cats/contributors","subscribers_url":"https://api.github.com/repos/non/cats/subscribers","subscription_url":"https://api.github.com/repos/non/cats/subscription","commits_url":"https://api.github.com/repos/non/cats/commits{/sha}","git_commits_url":"https://api.github.com/repos/non/cats/git/commits{/sha}","comments_url":"https://api.github.com/repos/non/cats/comments{/number}","issue_comment_url":"https://api.github.com/repos/non/cats/issues/comments/{number}","contents_url":"https://api.github.com/repos/non/cats/contents/{+path}","compare_url":"https://api.github.com/repos/non/cats/compare/{base}...{head}","merges_url":"https://api.github.com/repos/non/cats/merges","archive_url":"https://api.github.com/repos/non/cats/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/non/cats/downloads","issues_url":"https://api.github.com/repos/non/cats/issues{/number}","pulls_url":"https://api.github.com/repos/non/cats/pulls{/number}","milestones_url":"https://api.github.com/repos/non/cats/milestones{/number}","notifications_url":"https://api.github.com/repos/non/cats/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/non/cats/labels{/name}","releases_url":"https://api.github.com/repos/non/cats/releases{/id}","created_at":"2015-01-28T20:26:48Z","updated_at":"2015-02-04T21:30:29Z","pushed_at":"2015-02-04T23:55:18Z","git_url":"git://github.com/non/cats.git","ssh_url":"git@github.com:non/cats.git","clone_url":"https://github.com/non/cats.git","svn_url":"https://github.com/non/cats","homepage":null,"size":807,"stargazers_count":179,"watchers_count":179,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":31,"mirror_url":null,"open_issues_count":33,"forks":31,"open_issues":33,"watchers":179,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/non/cats/pulls/36"},"html":{"href":"https://github.com/non/cats/pull/36"},"issue":{"href":"https://api.github.com/repos/non/cats/issues/36"},"comments":{"href":"https://api.github.com/repos/non/cats/issues/36/comments"},"review_comments":{"href":"https://api.github.com/repos/non/cats/pulls/36/comments"},"review_comment":{"href":"https://api.github.com/repos/non/cats/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/non/cats/pulls/36/commits"},"statuses":{"href":"https://api.github.com/repos/non/cats/statuses/bb26aeee5fa5721668c155f934010ee928d40ec1"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"non","id":218045,"avatar_url":"https://avatars.githubusercontent.com/u/218045?v=3","gravatar_id":"","url":"https://api.github.com/users/non","html_url":"https://github.com/non","followers_url":"https://api.github.com/users/non/followers","following_url":"https://api.github.com/users/non/following{/other_user}","gists_url":"https://api.github.com/users/non/gists{/gist_id}","starred_url":"https://api.github.com/users/non/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/non/subscriptions","organizations_url":"https://api.github.com/users/non/orgs","repos_url":"https://api.github.com/users/non/repos","events_url":"https://api.github.com/users/non/events{/privacy}","received_events_url":"https://api.github.com/users/non/received_events","type":"User","site_admin":false},"comments":17,"review_comments":17,"commits":9,"additions":107,"deletions":430,"changed_files":1}}