{"action":"created","comment":{"url":"https://api.github.com/repos/brettwooldridge/HikariCP/pulls/comments/37869331","id":37869331,"diff_hunk":"@@ -245,27 +245,32 @@ void resetConnectionState(final PoolBagEntry poolEntry) throws SQLException\n \n       if (poolEntry.isReadOnly != isReadOnly) {\n          poolEntry.connection.setReadOnly(isReadOnly);\n+         poolEntry.setReadOnly(isReadOnly);\n          resetBits |= 0b00001;\n       }\n \n       if (poolEntry.isAutoCommit != isAutoCommit) {\n          poolEntry.connection.setAutoCommit(isAutoCommit);\n+         poolEntry.setAutoCommit(isAutoCommit);\n          resetBits |= 0b00010;\n       }\n \n       if (poolEntry.transactionIsolation != transactionIsolation) {\n          poolEntry.connection.setTransactionIsolation(transactionIsolation);\n+         poolEntry.setTransactionIsolation(transactionIsolation);\n          resetBits |= 0b00100;\n       }\n \n       final String currentCatalog = poolEntry.catalog;\n       if ((currentCatalog != null && !currentCatalog.equals(catalog)) || (currentCatalog == null && catalog != null)) {\n          poolEntry.connection.setCatalog(catalog);\n+         poolEntry.setCatalog(catalog);\n          resetBits |= 0b01000;\n       }\n \n       if (poolEntry.networkTimeout != networkTimeout) {\n          setNetworkTimeout(poolEntry.connection, networkTimeout);\n+         poolEntry.setNetworkTimeout(networkTimeout);\n          resetBits |= 0b10000;\n       }\n       ","path":"src/main/java/com/zaxxer/hikari/pool/PoolElf.java","position":32,"original_position":32,"commit_id":"891b5cd93062b9cfe88b4a920b2007d745bb2ca7","original_commit_id":"891b5cd93062b9cfe88b4a920b2007d745bb2ca7","user":{"login":"brettwooldridge","id":1538661,"avatar_url":"https://avatars.githubusercontent.com/u/1538661?v=3","gravatar_id":"","url":"https://api.github.com/users/brettwooldridge","html_url":"https://github.com/brettwooldridge","followers_url":"https://api.github.com/users/brettwooldridge/followers","following_url":"https://api.github.com/users/brettwooldridge/following{/other_user}","gists_url":"https://api.github.com/users/brettwooldridge/gists{/gist_id}","starred_url":"https://api.github.com/users/brettwooldridge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brettwooldridge/subscriptions","organizations_url":"https://api.github.com/users/brettwooldridge/orgs","repos_url":"https://api.github.com/users/brettwooldridge/repos","events_url":"https://api.github.com/users/brettwooldridge/events{/privacy}","received_events_url":"https://api.github.com/users/brettwooldridge/received_events","type":"User","site_admin":false},"body":"I like this set of changes.","created_at":"2015-08-25T14:13:38Z","updated_at":"2015-08-25T14:13:38Z","html_url":"https://github.com/brettwooldridge/HikariCP/pull/395#discussion_r37869331","pull_request_url":"https://api.github.com/repos/brettwooldridge/HikariCP/pulls/395","_links":{"self":{"href":"https://api.github.com/repos/brettwooldridge/HikariCP/pulls/comments/37869331"},"html":{"href":"https://github.com/brettwooldridge/HikariCP/pull/395#discussion_r37869331"},"pull_request":{"href":"https://api.github.com/repos/brettwooldridge/HikariCP/pulls/395"}}},"pull_request":{"url":"https://api.github.com/repos/brettwooldridge/HikariCP/pulls/395","id":43274782,"html_url":"https://github.com/brettwooldridge/HikariCP/pull/395","diff_url":"https://github.com/brettwooldridge/HikariCP/pull/395.diff","patch_url":"https://github.com/brettwooldridge/HikariCP/pull/395.patch","issue_url":"https://api.github.com/repos/brettwooldridge/HikariCP/issues/395","number":395,"state":"open","locked":false,"title":"cleanup","user":{"login":"nitincchauhan","id":9585644,"avatar_url":"https://avatars.githubusercontent.com/u/9585644?v=3","gravatar_id":"","url":"https://api.github.com/users/nitincchauhan","html_url":"https://github.com/nitincchauhan","followers_url":"https://api.github.com/users/nitincchauhan/followers","following_url":"https://api.github.com/users/nitincchauhan/following{/other_user}","gists_url":"https://api.github.com/users/nitincchauhan/gists{/gist_id}","starred_url":"https://api.github.com/users/nitincchauhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nitincchauhan/subscriptions","organizations_url":"https://api.github.com/users/nitincchauhan/orgs","repos_url":"https://api.github.com/users/nitincchauhan/repos","events_url":"https://api.github.com/users/nitincchauhan/events{/privacy}","received_events_url":"https://api.github.com/users/nitincchauhan/received_events","type":"User","site_admin":false},"body":"set lastAccess only if rolled back\r\nmethod and var renamed,  closeStatements() moved out of try, already catching SQLExceptions\r\nremove resetPoolEntry(), calling individual method if changed\r\nunintentional logging","created_at":"2015-08-25T11:30:31Z","updated_at":"2015-08-25T14:13:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"68d9a6789bff93f22571a9fbe20beceb6ffeda48","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/brettwooldridge/HikariCP/pulls/395/commits","review_comments_url":"https://api.github.com/repos/brettwooldridge/HikariCP/pulls/395/comments","review_comment_url":"https://api.github.com/repos/brettwooldridge/HikariCP/pulls/comments{/number}","comments_url":"https://api.github.com/repos/brettwooldridge/HikariCP/issues/395/comments","statuses_url":"https://api.github.com/repos/brettwooldridge/HikariCP/statuses/891b5cd93062b9cfe88b4a920b2007d745bb2ca7","head":{"label":"nitincchauhan:dev","ref":"dev","sha":"891b5cd93062b9cfe88b4a920b2007d745bb2ca7","user":{"login":"nitincchauhan","id":9585644,"avatar_url":"https://avatars.githubusercontent.com/u/9585644?v=3","gravatar_id":"","url":"https://api.github.com/users/nitincchauhan","html_url":"https://github.com/nitincchauhan","followers_url":"https://api.github.com/users/nitincchauhan/followers","following_url":"https://api.github.com/users/nitincchauhan/following{/other_user}","gists_url":"https://api.github.com/users/nitincchauhan/gists{/gist_id}","starred_url":"https://api.github.com/users/nitincchauhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nitincchauhan/subscriptions","organizations_url":"https://api.github.com/users/nitincchauhan/orgs","repos_url":"https://api.github.com/users/nitincchauhan/repos","events_url":"https://api.github.com/users/nitincchauhan/events{/privacy}","received_events_url":"https://api.github.com/users/nitincchauhan/received_events","type":"User","site_admin":false},"repo":{"id":39389200,"name":"HikariCP","full_name":"nitincchauhan/HikariCP","owner":{"login":"nitincchauhan","id":9585644,"avatar_url":"https://avatars.githubusercontent.com/u/9585644?v=3","gravatar_id":"","url":"https://api.github.com/users/nitincchauhan","html_url":"https://github.com/nitincchauhan","followers_url":"https://api.github.com/users/nitincchauhan/followers","following_url":"https://api.github.com/users/nitincchauhan/following{/other_user}","gists_url":"https://api.github.com/users/nitincchauhan/gists{/gist_id}","starred_url":"https://api.github.com/users/nitincchauhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nitincchauhan/subscriptions","organizations_url":"https://api.github.com/users/nitincchauhan/orgs","repos_url":"https://api.github.com/users/nitincchauhan/repos","events_url":"https://api.github.com/users/nitincchauhan/events{/privacy}","received_events_url":"https://api.github.com/users/nitincchauhan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nitincchauhan/HikariCP","description":"光 HikariCP・A solid high-performance JDBC connection pool at last.","fork":true,"url":"https://api.github.com/repos/nitincchauhan/HikariCP","forks_url":"https://api.github.com/repos/nitincchauhan/HikariCP/forks","keys_url":"https://api.github.com/repos/nitincchauhan/HikariCP/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nitincchauhan/HikariCP/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nitincchauhan/HikariCP/teams","hooks_url":"https://api.github.com/repos/nitincchauhan/HikariCP/hooks","issue_events_url":"https://api.github.com/repos/nitincchauhan/HikariCP/issues/events{/number}","events_url":"https://api.github.com/repos/nitincchauhan/HikariCP/events","assignees_url":"https://api.github.com/repos/nitincchauhan/HikariCP/assignees{/user}","branches_url":"https://api.github.com/repos/nitincchauhan/HikariCP/branches{/branch}","tags_url":"https://api.github.com/repos/nitincchauhan/HikariCP/tags","blobs_url":"https://api.github.com/repos/nitincchauhan/HikariCP/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nitincchauhan/HikariCP/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nitincchauhan/HikariCP/git/refs{/sha}","trees_url":"https://api.github.com/repos/nitincchauhan/HikariCP/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nitincchauhan/HikariCP/statuses/{sha}","languages_url":"https://api.github.com/repos/nitincchauhan/HikariCP/languages","stargazers_url":"https://api.github.com/repos/nitincchauhan/HikariCP/stargazers","contributors_url":"https://api.github.com/repos/nitincchauhan/HikariCP/contributors","subscribers_url":"https://api.github.com/repos/nitincchauhan/HikariCP/subscribers","subscription_url":"https://api.github.com/repos/nitincchauhan/HikariCP/subscription","commits_url":"https://api.github.com/repos/nitincchauhan/HikariCP/commits{/sha}","git_commits_url":"https://api.github.com/repos/nitincchauhan/HikariCP/git/commits{/sha}","comments_url":"https://api.github.com/repos/nitincchauhan/HikariCP/comments{/number}","issue_comment_url":"https://api.github.com/repos/nitincchauhan/HikariCP/issues/comments{/number}","contents_url":"https://api.github.com/repos/nitincchauhan/HikariCP/contents/{+path}","compare_url":"https://api.github.com/repos/nitincchauhan/HikariCP/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nitincchauhan/HikariCP/merges","archive_url":"https://api.github.com/repos/nitincchauhan/HikariCP/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nitincchauhan/HikariCP/downloads","issues_url":"https://api.github.com/repos/nitincchauhan/HikariCP/issues{/number}","pulls_url":"https://api.github.com/repos/nitincchauhan/HikariCP/pulls{/number}","milestones_url":"https://api.github.com/repos/nitincchauhan/HikariCP/milestones{/number}","notifications_url":"https://api.github.com/repos/nitincchauhan/HikariCP/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nitincchauhan/HikariCP/labels{/name}","releases_url":"https://api.github.com/repos/nitincchauhan/HikariCP/releases{/id}","created_at":"2015-07-20T14:39:33Z","updated_at":"2015-07-20T14:39:34Z","pushed_at":"2015-08-25T14:07:32Z","git_url":"git://github.com/nitincchauhan/HikariCP.git","ssh_url":"git@github.com:nitincchauhan/HikariCP.git","clone_url":"https://github.com/nitincchauhan/HikariCP.git","svn_url":"https://github.com/nitincchauhan/HikariCP","homepage":"http://brettwooldridge.github.io/HikariCP","size":3434,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"2.3.x"}},"base":{"label":"brettwooldridge:dev","ref":"dev","sha":"a25d6f021385503277650fb86048c48808df8e92","user":{"login":"brettwooldridge","id":1538661,"avatar_url":"https://avatars.githubusercontent.com/u/1538661?v=3","gravatar_id":"","url":"https://api.github.com/users/brettwooldridge","html_url":"https://github.com/brettwooldridge","followers_url":"https://api.github.com/users/brettwooldridge/followers","following_url":"https://api.github.com/users/brettwooldridge/following{/other_user}","gists_url":"https://api.github.com/users/brettwooldridge/gists{/gist_id}","starred_url":"https://api.github.com/users/brettwooldridge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brettwooldridge/subscriptions","organizations_url":"https://api.github.com/users/brettwooldridge/orgs","repos_url":"https://api.github.com/users/brettwooldridge/repos","events_url":"https://api.github.com/users/brettwooldridge/events{/privacy}","received_events_url":"https://api.github.com/users/brettwooldridge/received_events","type":"User","site_admin":false},"repo":{"id":13404515,"name":"HikariCP","full_name":"brettwooldridge/HikariCP","owner":{"login":"brettwooldridge","id":1538661,"avatar_url":"https://avatars.githubusercontent.com/u/1538661?v=3","gravatar_id":"","url":"https://api.github.com/users/brettwooldridge","html_url":"https://github.com/brettwooldridge","followers_url":"https://api.github.com/users/brettwooldridge/followers","following_url":"https://api.github.com/users/brettwooldridge/following{/other_user}","gists_url":"https://api.github.com/users/brettwooldridge/gists{/gist_id}","starred_url":"https://api.github.com/users/brettwooldridge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brettwooldridge/subscriptions","organizations_url":"https://api.github.com/users/brettwooldridge/orgs","repos_url":"https://api.github.com/users/brettwooldridge/repos","events_url":"https://api.github.com/users/brettwooldridge/events{/privacy}","received_events_url":"https://api.github.com/users/brettwooldridge/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brettwooldridge/HikariCP","description":"光 HikariCP・A solid high-performance JDBC connection pool at last.","fork":false,"url":"https://api.github.com/repos/brettwooldridge/HikariCP","forks_url":"https://api.github.com/repos/brettwooldridge/HikariCP/forks","keys_url":"https://api.github.com/repos/brettwooldridge/HikariCP/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brettwooldridge/HikariCP/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brettwooldridge/HikariCP/teams","hooks_url":"https://api.github.com/repos/brettwooldridge/HikariCP/hooks","issue_events_url":"https://api.github.com/repos/brettwooldridge/HikariCP/issues/events{/number}","events_url":"https://api.github.com/repos/brettwooldridge/HikariCP/events","assignees_url":"https://api.github.com/repos/brettwooldridge/HikariCP/assignees{/user}","branches_url":"https://api.github.com/repos/brettwooldridge/HikariCP/branches{/branch}","tags_url":"https://api.github.com/repos/brettwooldridge/HikariCP/tags","blobs_url":"https://api.github.com/repos/brettwooldridge/HikariCP/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brettwooldridge/HikariCP/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brettwooldridge/HikariCP/git/refs{/sha}","trees_url":"https://api.github.com/repos/brettwooldridge/HikariCP/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brettwooldridge/HikariCP/statuses/{sha}","languages_url":"https://api.github.com/repos/brettwooldridge/HikariCP/languages","stargazers_url":"https://api.github.com/repos/brettwooldridge/HikariCP/stargazers","contributors_url":"https://api.github.com/repos/brettwooldridge/HikariCP/contributors","subscribers_url":"https://api.github.com/repos/brettwooldridge/HikariCP/subscribers","subscription_url":"https://api.github.com/repos/brettwooldridge/HikariCP/subscription","commits_url":"https://api.github.com/repos/brettwooldridge/HikariCP/commits{/sha}","git_commits_url":"https://api.github.com/repos/brettwooldridge/HikariCP/git/commits{/sha}","comments_url":"https://api.github.com/repos/brettwooldridge/HikariCP/comments{/number}","issue_comment_url":"https://api.github.com/repos/brettwooldridge/HikariCP/issues/comments{/number}","contents_url":"https://api.github.com/repos/brettwooldridge/HikariCP/contents/{+path}","compare_url":"https://api.github.com/repos/brettwooldridge/HikariCP/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brettwooldridge/HikariCP/merges","archive_url":"https://api.github.com/repos/brettwooldridge/HikariCP/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brettwooldridge/HikariCP/downloads","issues_url":"https://api.github.com/repos/brettwooldridge/HikariCP/issues{/number}","pulls_url":"https://api.github.com/repos/brettwooldridge/HikariCP/pulls{/number}","milestones_url":"https://api.github.com/repos/brettwooldridge/HikariCP/milestones{/number}","notifications_url":"https://api.github.com/repos/brettwooldridge/HikariCP/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brettwooldridge/HikariCP/labels{/name}","releases_url":"https://api.github.com/repos/brettwooldridge/HikariCP/releases{/id}","created_at":"2013-10-08T05:43:03Z","updated_at":"2015-08-25T08:09:49Z","pushed_at":"2015-08-25T14:07:32Z","git_url":"git://github.com/brettwooldridge/HikariCP.git","ssh_url":"git@github.com:brettwooldridge/HikariCP.git","clone_url":"https://github.com/brettwooldridge/HikariCP.git","svn_url":"https://github.com/brettwooldridge/HikariCP","homepage":"http://brettwooldridge.github.io/HikariCP","size":15676,"stargazers_count":1740,"watchers_count":1740,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":217,"mirror_url":null,"open_issues_count":6,"forks":217,"open_issues":6,"watchers":1740,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/brettwooldridge/HikariCP/pulls/395"},"html":{"href":"https://github.com/brettwooldridge/HikariCP/pull/395"},"issue":{"href":"https://api.github.com/repos/brettwooldridge/HikariCP/issues/395"},"comments":{"href":"https://api.github.com/repos/brettwooldridge/HikariCP/issues/395/comments"},"review_comments":{"href":"https://api.github.com/repos/brettwooldridge/HikariCP/pulls/395/comments"},"review_comment":{"href":"https://api.github.com/repos/brettwooldridge/HikariCP/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/brettwooldridge/HikariCP/pulls/395/commits"},"statuses":{"href":"https://api.github.com/repos/brettwooldridge/HikariCP/statuses/891b5cd93062b9cfe88b4a920b2007d745bb2ca7"}}}}