{"action":"created","comment":{"url":"https://api.github.com/repos/symfony/symfony/pulls/comments/27738972","id":27738972,"diff_hunk":"@@ -0,0 +1,52 @@\n+<?php\n+\n+/*\n+ * This file is part of the Symfony package.\n+ *\n+ * (c) Fabien Potencier <fabien@symfony.com>\n+ *\n+ * For the full copyright and license information, please view the LICENSE\n+ * file that was distributed with this source code.\n+ */\n+\n+namespace Symfony\\Component\\Config;\n+\n+/**\n+ * Interface for ConfigCache\n+ *\n+ * @author Matthias Pigulla <mp@webfactory.de>\n+ */\n+interface ConfigCacheInterface\n+{\n+    /**\n+     * Gets the cache file path.\n+     *\n+     * @deprecated since 2.7, to be removed in 3.0. Use getPath() instead.\n+     * @return string The cache file path\n+     */\n+    public function __toString();\n+\n+    /**\n+     * Gets the cache file path.\n+     *\n+     * @return string The cache file path\n+     */\n+    public function getPath();","path":"src/Symfony/Component/Config/ConfigCacheInterface.php","position":34,"original_position":34,"commit_id":"ecab6acdd96928dd6564d355b89623935286a4aa","original_commit_id":"ecab6acdd96928dd6564d355b89623935286a4aa","user":{"login":"aitboudad","id":1753742,"avatar_url":"https://avatars.githubusercontent.com/u/1753742?v=3","gravatar_id":"","url":"https://api.github.com/users/aitboudad","html_url":"https://github.com/aitboudad","followers_url":"https://api.github.com/users/aitboudad/followers","following_url":"https://api.github.com/users/aitboudad/following{/other_user}","gists_url":"https://api.github.com/users/aitboudad/gists{/gist_id}","starred_url":"https://api.github.com/users/aitboudad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aitboudad/subscriptions","organizations_url":"https://api.github.com/users/aitboudad/orgs","repos_url":"https://api.github.com/users/aitboudad/repos","events_url":"https://api.github.com/users/aitboudad/events{/privacy}","received_events_url":"https://api.github.com/users/aitboudad/received_events","type":"User","site_admin":false},"body":"I'd prefer ```load``` instead of  ```getPath```.","created_at":"2015-04-03T16:36:08Z","updated_at":"2015-04-03T16:36:08Z","html_url":"https://github.com/symfony/symfony/pull/14178#discussion_r27738972","pull_request_url":"https://api.github.com/repos/symfony/symfony/pulls/14178","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/27738972"},"html":{"href":"https://github.com/symfony/symfony/pull/14178#discussion_r27738972"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony/pulls/14178"}}},"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/14178","id":32511774,"html_url":"https://github.com/symfony/symfony/pull/14178","diff_url":"https://github.com/symfony/symfony/pull/14178.diff","patch_url":"https://github.com/symfony/symfony/pull/14178.patch","issue_url":"https://api.github.com/repos/symfony/symfony/issues/14178","number":14178,"state":"open","locked":false,"title":"[Config] Delegate creation of ConfigCache instances to a factory.","user":{"login":"mpdude","id":1202333,"avatar_url":"https://avatars.githubusercontent.com/u/1202333?v=3","gravatar_id":"","url":"https://api.github.com/users/mpdude","html_url":"https://github.com/mpdude","followers_url":"https://api.github.com/users/mpdude/followers","following_url":"https://api.github.com/users/mpdude/following{/other_user}","gists_url":"https://api.github.com/users/mpdude/gists{/gist_id}","starred_url":"https://api.github.com/users/mpdude/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpdude/subscriptions","organizations_url":"https://api.github.com/users/mpdude/orgs","repos_url":"https://api.github.com/users/mpdude/repos","events_url":"https://api.github.com/users/mpdude/events{/privacy}","received_events_url":"https://api.github.com/users/mpdude/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Bug fix?      | no\r\n| New feature?  | yes (refactoring, new flex point)\r\n| BC breaks?    | no\r\n| Deprecations? | no\r\n| Tests pass?   | we'll see :-)\r\n| Fixed tickets | n/a\r\n| License       | MIT\r\n| Doc PR        | symfony/symfony-docs#5136\r\n\r\nIn the Routing/Router and Translation/Translator, delegate creation of ConfigCache instances to a factory. The factory can be setter-injected but will default to a BC implementation.\r\n\r\nThe ```ConfigCacheFactoryInterface``` is designed in a way that captures the common ```$cache = new ...; if (!$cache->isFresh()) { ... do sth }``` pattern. But more importantly, this design allows factory implementations to take additional measures to avoid race conditions before actually filling the cache.\r\n\r\nBy using an exchangeable ConfigCache factory it becomes possible to implement different resource (freshness) checking strategies, especially service-based ones. \r\n\r\nThe goal is to be able to validate Translators and Routers generated by database-based loaders. It might also help with symfony/AsseticBundle#168. This PR only contains the minimum changes needed, so the rest could be implemented in a bundle outside the core (at least for the beginning).\r\n\r\nComponent/HttpKernel/Kernel::initializeContainer still uses the ConfigCache implementation directly as there is no sensible way of getting/injecting a factory service (chicken-egg).\r\n\r\nThis is a pick off #7230. It replaces #7781 which was against the master branch. Also see #7781 for additional comments/explanations.","created_at":"2015-04-02T13:37:00Z","updated_at":"2015-04-03T16:36:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"82c9bcace02a76ec10407b9935a0f8617074620d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/symfony/symfony/pulls/14178/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony/pulls/14178/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/14178/comments","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/ecab6acdd96928dd6564d355b89623935286a4aa","head":{"label":"webfactory:7781-on-2.7","ref":"7781-on-2.7","sha":"ecab6acdd96928dd6564d355b89623935286a4aa","user":{"login":"webfactory","id":135788,"avatar_url":"https://avatars.githubusercontent.com/u/135788?v=3","gravatar_id":"","url":"https://api.github.com/users/webfactory","html_url":"https://github.com/webfactory","followers_url":"https://api.github.com/users/webfactory/followers","following_url":"https://api.github.com/users/webfactory/following{/other_user}","gists_url":"https://api.github.com/users/webfactory/gists{/gist_id}","starred_url":"https://api.github.com/users/webfactory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webfactory/subscriptions","organizations_url":"https://api.github.com/users/webfactory/orgs","repos_url":"https://api.github.com/users/webfactory/repos","events_url":"https://api.github.com/users/webfactory/events{/privacy}","received_events_url":"https://api.github.com/users/webfactory/received_events","type":"Organization","site_admin":false},"repo":{"id":3041501,"name":"symfony","full_name":"webfactory/symfony","owner":{"login":"webfactory","id":135788,"avatar_url":"https://avatars.githubusercontent.com/u/135788?v=3","gravatar_id":"","url":"https://api.github.com/users/webfactory","html_url":"https://github.com/webfactory","followers_url":"https://api.github.com/users/webfactory/followers","following_url":"https://api.github.com/users/webfactory/following{/other_user}","gists_url":"https://api.github.com/users/webfactory/gists{/gist_id}","starred_url":"https://api.github.com/users/webfactory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webfactory/subscriptions","organizations_url":"https://api.github.com/users/webfactory/orgs","repos_url":"https://api.github.com/users/webfactory/repos","events_url":"https://api.github.com/users/webfactory/events{/privacy}","received_events_url":"https://api.github.com/users/webfactory/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/webfactory/symfony","description":"The Symfony2 PHP framework","fork":true,"url":"https://api.github.com/repos/webfactory/symfony","forks_url":"https://api.github.com/repos/webfactory/symfony/forks","keys_url":"https://api.github.com/repos/webfactory/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/webfactory/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/webfactory/symfony/teams","hooks_url":"https://api.github.com/repos/webfactory/symfony/hooks","issue_events_url":"https://api.github.com/repos/webfactory/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/webfactory/symfony/events","assignees_url":"https://api.github.com/repos/webfactory/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/webfactory/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/webfactory/symfony/tags","blobs_url":"https://api.github.com/repos/webfactory/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/webfactory/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/webfactory/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/webfactory/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/webfactory/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/webfactory/symfony/languages","stargazers_url":"https://api.github.com/repos/webfactory/symfony/stargazers","contributors_url":"https://api.github.com/repos/webfactory/symfony/contributors","subscribers_url":"https://api.github.com/repos/webfactory/symfony/subscribers","subscription_url":"https://api.github.com/repos/webfactory/symfony/subscription","commits_url":"https://api.github.com/repos/webfactory/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/webfactory/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/webfactory/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/webfactory/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/webfactory/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/webfactory/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/webfactory/symfony/merges","archive_url":"https://api.github.com/repos/webfactory/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/webfactory/symfony/downloads","issues_url":"https://api.github.com/repos/webfactory/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/webfactory/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/webfactory/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/webfactory/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/webfactory/symfony/labels{/name}","releases_url":"https://api.github.com/repos/webfactory/symfony/releases{/id}","created_at":"2011-12-23T17:57:42Z","updated_at":"2014-09-30T06:38:40Z","pushed_at":"2015-04-02T20:21:06Z","git_url":"git://github.com/webfactory/symfony.git","ssh_url":"git@github.com:webfactory/symfony.git","clone_url":"https://github.com/webfactory/symfony.git","svn_url":"https://github.com/webfactory/symfony","homepage":"symfony.com","size":53908,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"symfony:2.7","ref":"2.7","sha":"4b19daf1b0aef868efb7bcbb225c235f046d6cdb","user":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":458058,"name":"symfony","full_name":"symfony/symfony","owner":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/symfony","description":"The Symfony PHP framework","fork":false,"url":"https://api.github.com/repos/symfony/symfony","forks_url":"https://api.github.com/repos/symfony/symfony/forks","keys_url":"https://api.github.com/repos/symfony/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony/teams","hooks_url":"https://api.github.com/repos/symfony/symfony/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony/events","assignees_url":"https://api.github.com/repos/symfony/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony/tags","blobs_url":"https://api.github.com/repos/symfony/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony/subscription","commits_url":"https://api.github.com/repos/symfony/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony/merges","archive_url":"https://api.github.com/repos/symfony/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony/downloads","issues_url":"https://api.github.com/repos/symfony/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony/releases{/id}","created_at":"2010-01-04T14:21:21Z","updated_at":"2015-04-03T16:23:53Z","pushed_at":"2015-04-03T16:27:33Z","git_url":"git://github.com/symfony/symfony.git","ssh_url":"git@github.com:symfony/symfony.git","clone_url":"https://github.com/symfony/symfony.git","svn_url":"https://github.com/symfony/symfony","homepage":"symfony.com","size":215383,"stargazers_count":9952,"watchers_count":9952,"language":"PHP","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":3898,"mirror_url":null,"open_issues_count":792,"forks":3898,"open_issues":792,"watchers":9952,"default_branch":"2.7"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/14178"},"html":{"href":"https://github.com/symfony/symfony/pull/14178"},"issue":{"href":"https://api.github.com/repos/symfony/symfony/issues/14178"},"comments":{"href":"https://api.github.com/repos/symfony/symfony/issues/14178/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony/pulls/14178/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony/pulls/14178/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony/statuses/ecab6acdd96928dd6564d355b89623935286a4aa"}}}}