{"action":"created","comment":{"url":"https://api.github.com/repos/smudge202/clean-living/pulls/comments/38409162","id":38409162,"diff_hunk":"@@ -2,7 +2,7 @@\n \n namespace CleanLiving.Engine\n {\n-    public interface IEngine<TTime>\n+    public interface IEngine<TTime> : IDisposable","path":"src/Engine/IEngine.cs","position":5,"original_position":5,"commit_id":"a6fc565013fa58d20466d57b9a1db410683feab1","original_commit_id":"a6fc565013fa58d20466d57b9a1db410683feab1","user":{"login":"smudge202","id":2247869,"avatar_url":"https://avatars.githubusercontent.com/u/2247869?v=3","gravatar_id":"","url":"https://api.github.com/users/smudge202","html_url":"https://github.com/smudge202","followers_url":"https://api.github.com/users/smudge202/followers","following_url":"https://api.github.com/users/smudge202/following{/other_user}","gists_url":"https://api.github.com/users/smudge202/gists{/gist_id}","starred_url":"https://api.github.com/users/smudge202/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smudge202/subscriptions","organizations_url":"https://api.github.com/users/smudge202/orgs","repos_url":"https://api.github.com/users/smudge202/repos","events_url":"https://api.github.com/users/smudge202/events{/privacy}","received_events_url":"https://api.github.com/users/smudge202/received_events","type":"User","site_admin":false},"body":"I don't think the `IEngine` *needs* to be IDisposable. The implementation certainly does because it holds onto disposables... up for discussion but I don't consider it necessary here.","created_at":"2015-09-01T11:34:27Z","updated_at":"2015-09-01T11:34:27Z","html_url":"https://github.com/smudge202/clean-living/pull/27#discussion_r38409162","pull_request_url":"https://api.github.com/repos/smudge202/clean-living/pulls/27","_links":{"self":{"href":"https://api.github.com/repos/smudge202/clean-living/pulls/comments/38409162"},"html":{"href":"https://github.com/smudge202/clean-living/pull/27#discussion_r38409162"},"pull_request":{"href":"https://api.github.com/repos/smudge202/clean-living/pulls/27"}}},"pull_request":{"url":"https://api.github.com/repos/smudge202/clean-living/pulls/27","id":43858697,"html_url":"https://github.com/smudge202/clean-living/pull/27","diff_url":"https://github.com/smudge202/clean-living/pull/27.diff","patch_url":"https://github.com/smudge202/clean-living/pull/27.patch","issue_url":"https://api.github.com/repos/smudge202/clean-living/issues/27","number":27,"state":"open","locked":false,"title":"Issue #23 - GameEngine should implement IDisposable","user":{"login":"danielcirket","id":6743309,"avatar_url":"https://avatars.githubusercontent.com/u/6743309?v=3","gravatar_id":"","url":"https://api.github.com/users/danielcirket","html_url":"https://github.com/danielcirket","followers_url":"https://api.github.com/users/danielcirket/followers","following_url":"https://api.github.com/users/danielcirket/following{/other_user}","gists_url":"https://api.github.com/users/danielcirket/gists{/gist_id}","starred_url":"https://api.github.com/users/danielcirket/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielcirket/subscriptions","organizations_url":"https://api.github.com/users/danielcirket/orgs","repos_url":"https://api.github.com/users/danielcirket/repos","events_url":"https://api.github.com/users/danielcirket/events{/privacy}","received_events_url":"https://api.github.com/users/danielcirket/received_events","type":"User","site_admin":false},"body":"I think this will need some discussion before any actual PRs can happen.\r\n\r\nI've added a few comments surrounding the tests for the disposable, so any feedback on this would be welcome.\r\n\r\nAlso, I'm not 100% happy with the implementation at the moment, and probably don't need to do the Remove from the list either, but let me know either way.\r\n\r\nI'll be honest, in my 2 and a bit years of programming, I've not actually had to implement IDisposable at all, so this could be way off the mark in terms of what should happen but just went with what I thought, thought I might as well do something that I've not had to do before.","created_at":"2015-09-01T10:13:52Z","updated_at":"2015-09-01T11:34:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5e2c5ecef444757c7e0864f49b3049507812598c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/smudge202/clean-living/pulls/27/commits","review_comments_url":"https://api.github.com/repos/smudge202/clean-living/pulls/27/comments","review_comment_url":"https://api.github.com/repos/smudge202/clean-living/pulls/comments{/number}","comments_url":"https://api.github.com/repos/smudge202/clean-living/issues/27/comments","statuses_url":"https://api.github.com/repos/smudge202/clean-living/statuses/a6fc565013fa58d20466d57b9a1db410683feab1","head":{"label":"danielcirket:dev","ref":"dev","sha":"a6fc565013fa58d20466d57b9a1db410683feab1","user":{"login":"danielcirket","id":6743309,"avatar_url":"https://avatars.githubusercontent.com/u/6743309?v=3","gravatar_id":"","url":"https://api.github.com/users/danielcirket","html_url":"https://github.com/danielcirket","followers_url":"https://api.github.com/users/danielcirket/followers","following_url":"https://api.github.com/users/danielcirket/following{/other_user}","gists_url":"https://api.github.com/users/danielcirket/gists{/gist_id}","starred_url":"https://api.github.com/users/danielcirket/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielcirket/subscriptions","organizations_url":"https://api.github.com/users/danielcirket/orgs","repos_url":"https://api.github.com/users/danielcirket/repos","events_url":"https://api.github.com/users/danielcirket/events{/privacy}","received_events_url":"https://api.github.com/users/danielcirket/received_events","type":"User","site_admin":false},"repo":{"id":41705896,"name":"clean-living","full_name":"danielcirket/clean-living","owner":{"login":"danielcirket","id":6743309,"avatar_url":"https://avatars.githubusercontent.com/u/6743309?v=3","gravatar_id":"","url":"https://api.github.com/users/danielcirket","html_url":"https://github.com/danielcirket","followers_url":"https://api.github.com/users/danielcirket/followers","following_url":"https://api.github.com/users/danielcirket/following{/other_user}","gists_url":"https://api.github.com/users/danielcirket/gists{/gist_id}","starred_url":"https://api.github.com/users/danielcirket/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielcirket/subscriptions","organizations_url":"https://api.github.com/users/danielcirket/orgs","repos_url":"https://api.github.com/users/danielcirket/repos","events_url":"https://api.github.com/users/danielcirket/events{/privacy}","received_events_url":"https://api.github.com/users/danielcirket/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/danielcirket/clean-living","description":"Walking a mile in the shoes of a game developer.","fork":true,"url":"https://api.github.com/repos/danielcirket/clean-living","forks_url":"https://api.github.com/repos/danielcirket/clean-living/forks","keys_url":"https://api.github.com/repos/danielcirket/clean-living/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danielcirket/clean-living/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danielcirket/clean-living/teams","hooks_url":"https://api.github.com/repos/danielcirket/clean-living/hooks","issue_events_url":"https://api.github.com/repos/danielcirket/clean-living/issues/events{/number}","events_url":"https://api.github.com/repos/danielcirket/clean-living/events","assignees_url":"https://api.github.com/repos/danielcirket/clean-living/assignees{/user}","branches_url":"https://api.github.com/repos/danielcirket/clean-living/branches{/branch}","tags_url":"https://api.github.com/repos/danielcirket/clean-living/tags","blobs_url":"https://api.github.com/repos/danielcirket/clean-living/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danielcirket/clean-living/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danielcirket/clean-living/git/refs{/sha}","trees_url":"https://api.github.com/repos/danielcirket/clean-living/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danielcirket/clean-living/statuses/{sha}","languages_url":"https://api.github.com/repos/danielcirket/clean-living/languages","stargazers_url":"https://api.github.com/repos/danielcirket/clean-living/stargazers","contributors_url":"https://api.github.com/repos/danielcirket/clean-living/contributors","subscribers_url":"https://api.github.com/repos/danielcirket/clean-living/subscribers","subscription_url":"https://api.github.com/repos/danielcirket/clean-living/subscription","commits_url":"https://api.github.com/repos/danielcirket/clean-living/commits{/sha}","git_commits_url":"https://api.github.com/repos/danielcirket/clean-living/git/commits{/sha}","comments_url":"https://api.github.com/repos/danielcirket/clean-living/comments{/number}","issue_comment_url":"https://api.github.com/repos/danielcirket/clean-living/issues/comments{/number}","contents_url":"https://api.github.com/repos/danielcirket/clean-living/contents/{+path}","compare_url":"https://api.github.com/repos/danielcirket/clean-living/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danielcirket/clean-living/merges","archive_url":"https://api.github.com/repos/danielcirket/clean-living/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danielcirket/clean-living/downloads","issues_url":"https://api.github.com/repos/danielcirket/clean-living/issues{/number}","pulls_url":"https://api.github.com/repos/danielcirket/clean-living/pulls{/number}","milestones_url":"https://api.github.com/repos/danielcirket/clean-living/milestones{/number}","notifications_url":"https://api.github.com/repos/danielcirket/clean-living/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danielcirket/clean-living/labels{/name}","releases_url":"https://api.github.com/repos/danielcirket/clean-living/releases{/id}","created_at":"2015-08-31T23:34:48Z","updated_at":"2015-08-31T23:34:48Z","pushed_at":"2015-09-01T10:05:45Z","git_url":"git://github.com/danielcirket/clean-living.git","ssh_url":"git@github.com:danielcirket/clean-living.git","clone_url":"https://github.com/danielcirket/clean-living.git","svn_url":"https://github.com/danielcirket/clean-living","homepage":null,"size":225,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"smudge202:dev","ref":"dev","sha":"92c788073b1c017e5fcc6aa15ec7b07821a9db31","user":{"login":"smudge202","id":2247869,"avatar_url":"https://avatars.githubusercontent.com/u/2247869?v=3","gravatar_id":"","url":"https://api.github.com/users/smudge202","html_url":"https://github.com/smudge202","followers_url":"https://api.github.com/users/smudge202/followers","following_url":"https://api.github.com/users/smudge202/following{/other_user}","gists_url":"https://api.github.com/users/smudge202/gists{/gist_id}","starred_url":"https://api.github.com/users/smudge202/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smudge202/subscriptions","organizations_url":"https://api.github.com/users/smudge202/orgs","repos_url":"https://api.github.com/users/smudge202/repos","events_url":"https://api.github.com/users/smudge202/events{/privacy}","received_events_url":"https://api.github.com/users/smudge202/received_events","type":"User","site_admin":false},"repo":{"id":31956774,"name":"clean-living","full_name":"smudge202/clean-living","owner":{"login":"smudge202","id":2247869,"avatar_url":"https://avatars.githubusercontent.com/u/2247869?v=3","gravatar_id":"","url":"https://api.github.com/users/smudge202","html_url":"https://github.com/smudge202","followers_url":"https://api.github.com/users/smudge202/followers","following_url":"https://api.github.com/users/smudge202/following{/other_user}","gists_url":"https://api.github.com/users/smudge202/gists{/gist_id}","starred_url":"https://api.github.com/users/smudge202/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smudge202/subscriptions","organizations_url":"https://api.github.com/users/smudge202/orgs","repos_url":"https://api.github.com/users/smudge202/repos","events_url":"https://api.github.com/users/smudge202/events{/privacy}","received_events_url":"https://api.github.com/users/smudge202/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/smudge202/clean-living","description":"Walking a mile in the shoes of a game developer.","fork":false,"url":"https://api.github.com/repos/smudge202/clean-living","forks_url":"https://api.github.com/repos/smudge202/clean-living/forks","keys_url":"https://api.github.com/repos/smudge202/clean-living/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smudge202/clean-living/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smudge202/clean-living/teams","hooks_url":"https://api.github.com/repos/smudge202/clean-living/hooks","issue_events_url":"https://api.github.com/repos/smudge202/clean-living/issues/events{/number}","events_url":"https://api.github.com/repos/smudge202/clean-living/events","assignees_url":"https://api.github.com/repos/smudge202/clean-living/assignees{/user}","branches_url":"https://api.github.com/repos/smudge202/clean-living/branches{/branch}","tags_url":"https://api.github.com/repos/smudge202/clean-living/tags","blobs_url":"https://api.github.com/repos/smudge202/clean-living/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smudge202/clean-living/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smudge202/clean-living/git/refs{/sha}","trees_url":"https://api.github.com/repos/smudge202/clean-living/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smudge202/clean-living/statuses/{sha}","languages_url":"https://api.github.com/repos/smudge202/clean-living/languages","stargazers_url":"https://api.github.com/repos/smudge202/clean-living/stargazers","contributors_url":"https://api.github.com/repos/smudge202/clean-living/contributors","subscribers_url":"https://api.github.com/repos/smudge202/clean-living/subscribers","subscription_url":"https://api.github.com/repos/smudge202/clean-living/subscription","commits_url":"https://api.github.com/repos/smudge202/clean-living/commits{/sha}","git_commits_url":"https://api.github.com/repos/smudge202/clean-living/git/commits{/sha}","comments_url":"https://api.github.com/repos/smudge202/clean-living/comments{/number}","issue_comment_url":"https://api.github.com/repos/smudge202/clean-living/issues/comments{/number}","contents_url":"https://api.github.com/repos/smudge202/clean-living/contents/{+path}","compare_url":"https://api.github.com/repos/smudge202/clean-living/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smudge202/clean-living/merges","archive_url":"https://api.github.com/repos/smudge202/clean-living/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smudge202/clean-living/downloads","issues_url":"https://api.github.com/repos/smudge202/clean-living/issues{/number}","pulls_url":"https://api.github.com/repos/smudge202/clean-living/pulls{/number}","milestones_url":"https://api.github.com/repos/smudge202/clean-living/milestones{/number}","notifications_url":"https://api.github.com/repos/smudge202/clean-living/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smudge202/clean-living/labels{/name}","releases_url":"https://api.github.com/repos/smudge202/clean-living/releases{/id}","created_at":"2015-03-10T12:43:12Z","updated_at":"2015-07-08T21:58:10Z","pushed_at":"2015-09-01T10:13:55Z","git_url":"git://github.com/smudge202/clean-living.git","ssh_url":"git@github.com:smudge202/clean-living.git","clone_url":"https://github.com/smudge202/clean-living.git","svn_url":"https://github.com/smudge202/clean-living","homepage":null,"size":580,"stargazers_count":6,"watchers_count":6,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":12,"forks":3,"open_issues":12,"watchers":6,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/smudge202/clean-living/pulls/27"},"html":{"href":"https://github.com/smudge202/clean-living/pull/27"},"issue":{"href":"https://api.github.com/repos/smudge202/clean-living/issues/27"},"comments":{"href":"https://api.github.com/repos/smudge202/clean-living/issues/27/comments"},"review_comments":{"href":"https://api.github.com/repos/smudge202/clean-living/pulls/27/comments"},"review_comment":{"href":"https://api.github.com/repos/smudge202/clean-living/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/smudge202/clean-living/pulls/27/commits"},"statuses":{"href":"https://api.github.com/repos/smudge202/clean-living/statuses/a6fc565013fa58d20466d57b9a1db410683feab1"}}}}