{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/24780817","id":24780817,"diff_hunk":"@@ -754,6 +754,8 @@ type EndpointsList struct {\n type NodeSpec struct {\n \t// Capacity represents the available resources of a node\n \tCapacity ResourceList `json:\"capacity,omitempty\"`\n+\t// Cidr represents the IP range assigned to the node\n+\tCidr string `json:\"cidr,omitempty\"`","path":"pkg/api/types.go","position":5,"original_position":5,"commit_id":"40e9b72b9f76b3f7f6e8ab38a0c078d3a1411cfd","original_commit_id":"40e9b72b9f76b3f7f6e8ab38a0c078d3a1411cfd","user":{"login":"tkulczynski","id":10222338,"avatar_url":"https://avatars.githubusercontent.com/u/10222338?v=3","gravatar_id":"","url":"https://api.github.com/users/tkulczynski","html_url":"https://github.com/tkulczynski","followers_url":"https://api.github.com/users/tkulczynski/followers","following_url":"https://api.github.com/users/tkulczynski/following{/other_user}","gists_url":"https://api.github.com/users/tkulczynski/gists{/gist_id}","starred_url":"https://api.github.com/users/tkulczynski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkulczynski/subscriptions","organizations_url":"https://api.github.com/users/tkulczynski/orgs","repos_url":"https://api.github.com/users/tkulczynski/repos","events_url":"https://api.github.com/users/tkulczynski/events{/privacy}","received_events_url":"https://api.github.com/users/tkulczynski/received_events","type":"User","site_admin":false},"body":"Sure, I am happy to change it to \"CIDR\". Also, I was thinking about \"IPRange\" or \"PodIPRange\" etc., so I am hoping somebody makes a final call how this should actually be named.","created_at":"2015-02-16T22:42:55Z","updated_at":"2015-02-16T22:42:55Z","html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/4456#discussion_r24780817","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/4456","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/24780817"},"html":{"href":"https://github.com/GoogleCloudPlatform/kubernetes/pull/4456#discussion_r24780817"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/4456"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/4456","id":29371542,"html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/4456","diff_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/4456.diff","patch_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/4456.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/4456","number":4456,"state":"open","locked":false,"title":"Add node's IP range cidr to NodeSpec","user":{"login":"tkulczynski","id":10222338,"avatar_url":"https://avatars.githubusercontent.com/u/10222338?v=3","gravatar_id":"","url":"https://api.github.com/users/tkulczynski","html_url":"https://github.com/tkulczynski","followers_url":"https://api.github.com/users/tkulczynski/followers","following_url":"https://api.github.com/users/tkulczynski/following{/other_user}","gists_url":"https://api.github.com/users/tkulczynski/gists{/gist_id}","starred_url":"https://api.github.com/users/tkulczynski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkulczynski/subscriptions","organizations_url":"https://api.github.com/users/tkulczynski/orgs","repos_url":"https://api.github.com/users/tkulczynski/repos","events_url":"https://api.github.com/users/tkulczynski/events{/privacy}","received_events_url":"https://api.github.com/users/tkulczynski/received_events","type":"User","site_admin":false},"body":"@bgrant0607 @fbalejko: This is something you guys already talked about I believe.\r\n\r\nThe idea here is to add a new method to cloudprovider.Instances interface to push the range setting from api.NodeSpec to the actual node in the cloud. The goal being to allow adding more instances to a running cluster.\r\nPlease review the API part for now. ","created_at":"2015-02-16T13:08:22Z","updated_at":"2015-02-16T22:42:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a5dafa1de38ecb4729496124300b6b6939b806cd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/4456/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/4456/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/{number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/4456/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/40e9b72b9f76b3f7f6e8ab38a0c078d3a1411cfd","head":{"label":"tkulczynski:noderegistration","ref":"noderegistration","sha":"40e9b72b9f76b3f7f6e8ab38a0c078d3a1411cfd","user":{"login":"tkulczynski","id":10222338,"avatar_url":"https://avatars.githubusercontent.com/u/10222338?v=3","gravatar_id":"","url":"https://api.github.com/users/tkulczynski","html_url":"https://github.com/tkulczynski","followers_url":"https://api.github.com/users/tkulczynski/followers","following_url":"https://api.github.com/users/tkulczynski/following{/other_user}","gists_url":"https://api.github.com/users/tkulczynski/gists{/gist_id}","starred_url":"https://api.github.com/users/tkulczynski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkulczynski/subscriptions","organizations_url":"https://api.github.com/users/tkulczynski/orgs","repos_url":"https://api.github.com/users/tkulczynski/repos","events_url":"https://api.github.com/users/tkulczynski/events{/privacy}","received_events_url":"https://api.github.com/users/tkulczynski/received_events","type":"User","site_admin":false},"repo":{"id":28144881,"name":"kubernetes","full_name":"tkulczynski/kubernetes","owner":{"login":"tkulczynski","id":10222338,"avatar_url":"https://avatars.githubusercontent.com/u/10222338?v=3","gravatar_id":"","url":"https://api.github.com/users/tkulczynski","html_url":"https://github.com/tkulczynski","followers_url":"https://api.github.com/users/tkulczynski/followers","following_url":"https://api.github.com/users/tkulczynski/following{/other_user}","gists_url":"https://api.github.com/users/tkulczynski/gists{/gist_id}","starred_url":"https://api.github.com/users/tkulczynski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkulczynski/subscriptions","organizations_url":"https://api.github.com/users/tkulczynski/orgs","repos_url":"https://api.github.com/users/tkulczynski/repos","events_url":"https://api.github.com/users/tkulczynski/events{/privacy}","received_events_url":"https://api.github.com/users/tkulczynski/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tkulczynski/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/tkulczynski/kubernetes","forks_url":"https://api.github.com/repos/tkulczynski/kubernetes/forks","keys_url":"https://api.github.com/repos/tkulczynski/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tkulczynski/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tkulczynski/kubernetes/teams","hooks_url":"https://api.github.com/repos/tkulczynski/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/tkulczynski/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/tkulczynski/kubernetes/events","assignees_url":"https://api.github.com/repos/tkulczynski/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/tkulczynski/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/tkulczynski/kubernetes/tags","blobs_url":"https://api.github.com/repos/tkulczynski/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tkulczynski/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tkulczynski/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/tkulczynski/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tkulczynski/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/tkulczynski/kubernetes/languages","stargazers_url":"https://api.github.com/repos/tkulczynski/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/tkulczynski/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/tkulczynski/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/tkulczynski/kubernetes/subscription","commits_url":"https://api.github.com/repos/tkulczynski/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/tkulczynski/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/tkulczynski/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/tkulczynski/kubernetes/issues/comments/{number}","contents_url":"https://api.github.com/repos/tkulczynski/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/tkulczynski/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tkulczynski/kubernetes/merges","archive_url":"https://api.github.com/repos/tkulczynski/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tkulczynski/kubernetes/downloads","issues_url":"https://api.github.com/repos/tkulczynski/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/tkulczynski/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/tkulczynski/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/tkulczynski/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tkulczynski/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/tkulczynski/kubernetes/releases{/id}","created_at":"2014-12-17T16:16:54Z","updated_at":"2015-02-16T09:29:39Z","pushed_at":"2015-02-16T12:54:31Z","git_url":"git://github.com/tkulczynski/kubernetes.git","ssh_url":"git@github.com:tkulczynski/kubernetes.git","clone_url":"https://github.com/tkulczynski/kubernetes.git","svn_url":"https://github.com/tkulczynski/kubernetes","homepage":null,"size":29668,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"64678b71f32f79e355b7fb0100d4361e97ffd79b","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"GoogleCloudPlatform/kubernetes","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/kubernetes","description":"Container Cluster Manager","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/comments/{number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/releases{/id}","created_at":"2014-06-06T22:56:04Z","updated_at":"2015-02-16T21:53:59Z","pushed_at":"2015-02-16T21:53:58Z","git_url":"git://github.com/GoogleCloudPlatform/kubernetes.git","ssh_url":"git@github.com:GoogleCloudPlatform/kubernetes.git","clone_url":"https://github.com/GoogleCloudPlatform/kubernetes.git","svn_url":"https://github.com/GoogleCloudPlatform/kubernetes","homepage":"http://kubernetes.io","size":75782,"stargazers_count":6245,"watchers_count":6245,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1089,"mirror_url":null,"open_issues_count":696,"forks":1089,"open_issues":696,"watchers":6245,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/4456"},"html":{"href":"https://github.com/GoogleCloudPlatform/kubernetes/pull/4456"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/4456"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/4456/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/4456/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/4456/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/40e9b72b9f76b3f7f6e8ab38a0c078d3a1411cfd"}}}}