{"action":"created","comment":{"url":"https://api.github.com/repos/ska-sa/katcp-python/pulls/comments/35217914","id":35217914,"diff_hunk":"@@ -595,10 +595,15 @@ def parent_name(self):\n \n     @property\n     def name(self):\n-        \"\"\"Name of this KATCP resource\"\"\"\n+        \"\"\"Name of this KATCPSensor\"\"\"\n         return self._name\n \n     @property\n+    def python_id(self):","path":"katcp/resource.py","position":9,"original_position":9,"commit_id":"ab81c91dfd1325930061b64d82a519d9436e2825","original_commit_id":"ab81c91dfd1325930061b64d82a519d9436e2825","user":{"login":"lvdheever","id":6706252,"avatar_url":"https://avatars.githubusercontent.com/u/6706252?v=3","gravatar_id":"","url":"https://api.github.com/users/lvdheever","html_url":"https://github.com/lvdheever","followers_url":"https://api.github.com/users/lvdheever/followers","following_url":"https://api.github.com/users/lvdheever/following{/other_user}","gists_url":"https://api.github.com/users/lvdheever/gists{/gist_id}","starred_url":"https://api.github.com/users/lvdheever/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lvdheever/subscriptions","organizations_url":"https://api.github.com/users/lvdheever/orgs","repos_url":"https://api.github.com/users/lvdheever/repos","events_url":"https://api.github.com/users/lvdheever/events{/privacy}","received_events_url":"https://api.github.com/users/lvdheever/received_events","type":"User","site_admin":false},"body":"OK - so shall we go with 'normalised_name' then. Seems like there are 3 half-votes for that one.","created_at":"2015-07-22T14:25:03Z","updated_at":"2015-07-22T14:25:03Z","html_url":"https://github.com/ska-sa/katcp-python/pull/117#discussion_r35217914","pull_request_url":"https://api.github.com/repos/ska-sa/katcp-python/pulls/117","_links":{"self":{"href":"https://api.github.com/repos/ska-sa/katcp-python/pulls/comments/35217914"},"html":{"href":"https://github.com/ska-sa/katcp-python/pull/117#discussion_r35217914"},"pull_request":{"href":"https://api.github.com/repos/ska-sa/katcp-python/pulls/117"}}},"pull_request":{"url":"https://api.github.com/repos/ska-sa/katcp-python/pulls/117","id":40549628,"html_url":"https://github.com/ska-sa/katcp-python/pull/117","diff_url":"https://github.com/ska-sa/katcp-python/pull/117.diff","patch_url":"https://github.com/ska-sa/katcp-python/pull/117.patch","issue_url":"https://api.github.com/repos/ska-sa/katcp-python/issues/117","number":117,"state":"open","locked":false,"title":"Adding phython identifier to KATCPSensor object","user":{"login":"theunsa","id":95486,"avatar_url":"https://avatars.githubusercontent.com/u/95486?v=3","gravatar_id":"","url":"https://api.github.com/users/theunsa","html_url":"https://github.com/theunsa","followers_url":"https://api.github.com/users/theunsa/followers","following_url":"https://api.github.com/users/theunsa/following{/other_user}","gists_url":"https://api.github.com/users/theunsa/gists{/gist_id}","starred_url":"https://api.github.com/users/theunsa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theunsa/subscriptions","organizations_url":"https://api.github.com/users/theunsa/orgs","repos_url":"https://api.github.com/users/theunsa/repos","events_url":"https://api.github.com/users/theunsa/events{/privacy}","received_events_url":"https://api.github.com/users/theunsa/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-07-22T10:15:15Z","updated_at":"2015-07-22T14:25:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"95f647a1ada1b593b3c0c8fd7c39ac9b3a1e60d6","assignee":{"login":"theunsa","id":95486,"avatar_url":"https://avatars.githubusercontent.com/u/95486?v=3","gravatar_id":"","url":"https://api.github.com/users/theunsa","html_url":"https://github.com/theunsa","followers_url":"https://api.github.com/users/theunsa/followers","following_url":"https://api.github.com/users/theunsa/following{/other_user}","gists_url":"https://api.github.com/users/theunsa/gists{/gist_id}","starred_url":"https://api.github.com/users/theunsa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theunsa/subscriptions","organizations_url":"https://api.github.com/users/theunsa/orgs","repos_url":"https://api.github.com/users/theunsa/repos","events_url":"https://api.github.com/users/theunsa/events{/privacy}","received_events_url":"https://api.github.com/users/theunsa/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/ska-sa/katcp-python/pulls/117/commits","review_comments_url":"https://api.github.com/repos/ska-sa/katcp-python/pulls/117/comments","review_comment_url":"https://api.github.com/repos/ska-sa/katcp-python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ska-sa/katcp-python/issues/117/comments","statuses_url":"https://api.github.com/repos/ska-sa/katcp-python/statuses/ab81c91dfd1325930061b64d82a519d9436e2825","head":{"label":"ska-sa:add_python_id_property","ref":"add_python_id_property","sha":"ab81c91dfd1325930061b64d82a519d9436e2825","user":{"login":"ska-sa","id":1210238,"avatar_url":"https://avatars.githubusercontent.com/u/1210238?v=3","gravatar_id":"","url":"https://api.github.com/users/ska-sa","html_url":"https://github.com/ska-sa","followers_url":"https://api.github.com/users/ska-sa/followers","following_url":"https://api.github.com/users/ska-sa/following{/other_user}","gists_url":"https://api.github.com/users/ska-sa/gists{/gist_id}","starred_url":"https://api.github.com/users/ska-sa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ska-sa/subscriptions","organizations_url":"https://api.github.com/users/ska-sa/orgs","repos_url":"https://api.github.com/users/ska-sa/repos","events_url":"https://api.github.com/users/ska-sa/events{/privacy}","received_events_url":"https://api.github.com/users/ska-sa/received_events","type":"Organization","site_admin":false},"repo":{"id":5854299,"name":"katcp-python","full_name":"ska-sa/katcp-python","owner":{"login":"ska-sa","id":1210238,"avatar_url":"https://avatars.githubusercontent.com/u/1210238?v=3","gravatar_id":"","url":"https://api.github.com/users/ska-sa","html_url":"https://github.com/ska-sa","followers_url":"https://api.github.com/users/ska-sa/followers","following_url":"https://api.github.com/users/ska-sa/following{/other_user}","gists_url":"https://api.github.com/users/ska-sa/gists{/gist_id}","starred_url":"https://api.github.com/users/ska-sa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ska-sa/subscriptions","organizations_url":"https://api.github.com/users/ska-sa/orgs","repos_url":"https://api.github.com/users/ska-sa/repos","events_url":"https://api.github.com/users/ska-sa/events{/privacy}","received_events_url":"https://api.github.com/users/ska-sa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ska-sa/katcp-python","description":"Python client and server library for the Karoo Array Telescope Control Protocol (KATCP)","fork":false,"url":"https://api.github.com/repos/ska-sa/katcp-python","forks_url":"https://api.github.com/repos/ska-sa/katcp-python/forks","keys_url":"https://api.github.com/repos/ska-sa/katcp-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ska-sa/katcp-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ska-sa/katcp-python/teams","hooks_url":"https://api.github.com/repos/ska-sa/katcp-python/hooks","issue_events_url":"https://api.github.com/repos/ska-sa/katcp-python/issues/events{/number}","events_url":"https://api.github.com/repos/ska-sa/katcp-python/events","assignees_url":"https://api.github.com/repos/ska-sa/katcp-python/assignees{/user}","branches_url":"https://api.github.com/repos/ska-sa/katcp-python/branches{/branch}","tags_url":"https://api.github.com/repos/ska-sa/katcp-python/tags","blobs_url":"https://api.github.com/repos/ska-sa/katcp-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ska-sa/katcp-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ska-sa/katcp-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/ska-sa/katcp-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ska-sa/katcp-python/statuses/{sha}","languages_url":"https://api.github.com/repos/ska-sa/katcp-python/languages","stargazers_url":"https://api.github.com/repos/ska-sa/katcp-python/stargazers","contributors_url":"https://api.github.com/repos/ska-sa/katcp-python/contributors","subscribers_url":"https://api.github.com/repos/ska-sa/katcp-python/subscribers","subscription_url":"https://api.github.com/repos/ska-sa/katcp-python/subscription","commits_url":"https://api.github.com/repos/ska-sa/katcp-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/ska-sa/katcp-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/ska-sa/katcp-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/ska-sa/katcp-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/ska-sa/katcp-python/contents/{+path}","compare_url":"https://api.github.com/repos/ska-sa/katcp-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ska-sa/katcp-python/merges","archive_url":"https://api.github.com/repos/ska-sa/katcp-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ska-sa/katcp-python/downloads","issues_url":"https://api.github.com/repos/ska-sa/katcp-python/issues{/number}","pulls_url":"https://api.github.com/repos/ska-sa/katcp-python/pulls{/number}","milestones_url":"https://api.github.com/repos/ska-sa/katcp-python/milestones{/number}","notifications_url":"https://api.github.com/repos/ska-sa/katcp-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ska-sa/katcp-python/labels{/name}","releases_url":"https://api.github.com/repos/ska-sa/katcp-python/releases{/id}","created_at":"2012-09-18T09:52:58Z","updated_at":"2015-05-07T13:48:52Z","pushed_at":"2015-07-22T12:22:57Z","git_url":"git://github.com/ska-sa/katcp-python.git","ssh_url":"git@github.com:ska-sa/katcp-python.git","clone_url":"https://github.com/ska-sa/katcp-python.git","svn_url":"https://github.com/ska-sa/katcp-python","homepage":null,"size":3236,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":2,"forks":3,"open_issues":2,"watchers":2,"default_branch":"master"}},"base":{"label":"ska-sa:master","ref":"master","sha":"531a507a1b8677a0b84df1d809f577ad22033478","user":{"login":"ska-sa","id":1210238,"avatar_url":"https://avatars.githubusercontent.com/u/1210238?v=3","gravatar_id":"","url":"https://api.github.com/users/ska-sa","html_url":"https://github.com/ska-sa","followers_url":"https://api.github.com/users/ska-sa/followers","following_url":"https://api.github.com/users/ska-sa/following{/other_user}","gists_url":"https://api.github.com/users/ska-sa/gists{/gist_id}","starred_url":"https://api.github.com/users/ska-sa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ska-sa/subscriptions","organizations_url":"https://api.github.com/users/ska-sa/orgs","repos_url":"https://api.github.com/users/ska-sa/repos","events_url":"https://api.github.com/users/ska-sa/events{/privacy}","received_events_url":"https://api.github.com/users/ska-sa/received_events","type":"Organization","site_admin":false},"repo":{"id":5854299,"name":"katcp-python","full_name":"ska-sa/katcp-python","owner":{"login":"ska-sa","id":1210238,"avatar_url":"https://avatars.githubusercontent.com/u/1210238?v=3","gravatar_id":"","url":"https://api.github.com/users/ska-sa","html_url":"https://github.com/ska-sa","followers_url":"https://api.github.com/users/ska-sa/followers","following_url":"https://api.github.com/users/ska-sa/following{/other_user}","gists_url":"https://api.github.com/users/ska-sa/gists{/gist_id}","starred_url":"https://api.github.com/users/ska-sa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ska-sa/subscriptions","organizations_url":"https://api.github.com/users/ska-sa/orgs","repos_url":"https://api.github.com/users/ska-sa/repos","events_url":"https://api.github.com/users/ska-sa/events{/privacy}","received_events_url":"https://api.github.com/users/ska-sa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ska-sa/katcp-python","description":"Python client and server library for the Karoo Array Telescope Control Protocol (KATCP)","fork":false,"url":"https://api.github.com/repos/ska-sa/katcp-python","forks_url":"https://api.github.com/repos/ska-sa/katcp-python/forks","keys_url":"https://api.github.com/repos/ska-sa/katcp-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ska-sa/katcp-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ska-sa/katcp-python/teams","hooks_url":"https://api.github.com/repos/ska-sa/katcp-python/hooks","issue_events_url":"https://api.github.com/repos/ska-sa/katcp-python/issues/events{/number}","events_url":"https://api.github.com/repos/ska-sa/katcp-python/events","assignees_url":"https://api.github.com/repos/ska-sa/katcp-python/assignees{/user}","branches_url":"https://api.github.com/repos/ska-sa/katcp-python/branches{/branch}","tags_url":"https://api.github.com/repos/ska-sa/katcp-python/tags","blobs_url":"https://api.github.com/repos/ska-sa/katcp-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ska-sa/katcp-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ska-sa/katcp-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/ska-sa/katcp-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ska-sa/katcp-python/statuses/{sha}","languages_url":"https://api.github.com/repos/ska-sa/katcp-python/languages","stargazers_url":"https://api.github.com/repos/ska-sa/katcp-python/stargazers","contributors_url":"https://api.github.com/repos/ska-sa/katcp-python/contributors","subscribers_url":"https://api.github.com/repos/ska-sa/katcp-python/subscribers","subscription_url":"https://api.github.com/repos/ska-sa/katcp-python/subscription","commits_url":"https://api.github.com/repos/ska-sa/katcp-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/ska-sa/katcp-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/ska-sa/katcp-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/ska-sa/katcp-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/ska-sa/katcp-python/contents/{+path}","compare_url":"https://api.github.com/repos/ska-sa/katcp-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ska-sa/katcp-python/merges","archive_url":"https://api.github.com/repos/ska-sa/katcp-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ska-sa/katcp-python/downloads","issues_url":"https://api.github.com/repos/ska-sa/katcp-python/issues{/number}","pulls_url":"https://api.github.com/repos/ska-sa/katcp-python/pulls{/number}","milestones_url":"https://api.github.com/repos/ska-sa/katcp-python/milestones{/number}","notifications_url":"https://api.github.com/repos/ska-sa/katcp-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ska-sa/katcp-python/labels{/name}","releases_url":"https://api.github.com/repos/ska-sa/katcp-python/releases{/id}","created_at":"2012-09-18T09:52:58Z","updated_at":"2015-05-07T13:48:52Z","pushed_at":"2015-07-22T12:22:57Z","git_url":"git://github.com/ska-sa/katcp-python.git","ssh_url":"git@github.com:ska-sa/katcp-python.git","clone_url":"https://github.com/ska-sa/katcp-python.git","svn_url":"https://github.com/ska-sa/katcp-python","homepage":null,"size":3236,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":2,"forks":3,"open_issues":2,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ska-sa/katcp-python/pulls/117"},"html":{"href":"https://github.com/ska-sa/katcp-python/pull/117"},"issue":{"href":"https://api.github.com/repos/ska-sa/katcp-python/issues/117"},"comments":{"href":"https://api.github.com/repos/ska-sa/katcp-python/issues/117/comments"},"review_comments":{"href":"https://api.github.com/repos/ska-sa/katcp-python/pulls/117/comments"},"review_comment":{"href":"https://api.github.com/repos/ska-sa/katcp-python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ska-sa/katcp-python/pulls/117/commits"},"statuses":{"href":"https://api.github.com/repos/ska-sa/katcp-python/statuses/ab81c91dfd1325930061b64d82a519d9436e2825"}}}}