{"action":"opened","issue":{"url":"https://api.github.com/repos/elastic/elasticsearch/issues/10625","labels_url":"https://api.github.com/repos/elastic/elasticsearch/issues/10625/labels{/name}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/issues/10625/comments","events_url":"https://api.github.com/repos/elastic/elasticsearch/issues/10625/events","html_url":"https://github.com/elastic/elasticsearch/issues/10625","id":68873795,"number":10625,"title":"Remove XPostingsHighlighter","user":{"login":"jpountz","id":299848,"avatar_url":"https://avatars.githubusercontent.com/u/299848?v=3","gravatar_id":"","url":"https://api.github.com/users/jpountz","html_url":"https://github.com/jpountz","followers_url":"https://api.github.com/users/jpountz/followers","following_url":"https://api.github.com/users/jpountz/following{/other_user}","gists_url":"https://api.github.com/users/jpountz/gists{/gist_id}","starred_url":"https://api.github.com/users/jpountz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpountz/subscriptions","organizations_url":"https://api.github.com/users/jpountz/orgs","repos_url":"https://api.github.com/users/jpountz/repos","events_url":"https://api.github.com/users/jpountz/events{/privacy}","received_events_url":"https://api.github.com/users/jpountz/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/elastic/elasticsearch/labels/:Highlighting","name":":Highlighting","color":"009800"},{"url":"https://api.github.com/repos/elastic/elasticsearch/labels/PITA","name":"PITA","color":"e11d21"}],"state":"open","locked":false,"assignee":{"login":"javanna","id":832460,"avatar_url":"https://avatars.githubusercontent.com/u/832460?v=3","gravatar_id":"","url":"https://api.github.com/users/javanna","html_url":"https://github.com/javanna","followers_url":"https://api.github.com/users/javanna/followers","following_url":"https://api.github.com/users/javanna/following{/other_user}","gists_url":"https://api.github.com/users/javanna/gists{/gist_id}","starred_url":"https://api.github.com/users/javanna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javanna/subscriptions","organizations_url":"https://api.github.com/users/javanna/orgs","repos_url":"https://api.github.com/users/javanna/repos","events_url":"https://api.github.com/users/javanna/events{/privacy}","received_events_url":"https://api.github.com/users/javanna/received_events","type":"User","site_admin":false},"milestone":null,"comments":0,"created_at":"2015-04-16T08:36:00Z","updated_at":"2015-04-16T08:36:00Z","closed_at":null,"body":"This class is a fork of Lucene's PostingsHighlighter. Quoting its javadocs:\r\n\r\n```\r\nFORKED from Lucene 4.5 to be able to:\r\n1) support discrete highlighting for multiple values, so that we can return a different snippet per value when highlighting the whole text\r\n2) call the highlightField method directly from subclasses and provide the terms by ourselves\r\n3) Applied LUCENE-4906 to allow PassageFormatter to return arbitrary objects (LUCENE 4.6)\r\n\r\nAll our changes start with //BEGIN EDIT\r\n```\r\n\r\nI don't think we can maintain such forks in the long term as reconciliating changes that come from Lucene upgrades with changes that we did ourselves might even be impossible at some point. So I think it's important that everything that we need gets merged back to Lucene's PostingsHighlighter and that we remove XPostingsHighlighter from Elasticsearch."}}