{"action":"created","issue":{"url":"https://api.github.com/repos/munkki84/SailFreeCell/issues/7","labels_url":"https://api.github.com/repos/munkki84/SailFreeCell/issues/7/labels{/name}","comments_url":"https://api.github.com/repos/munkki84/SailFreeCell/issues/7/comments","events_url":"https://api.github.com/repos/munkki84/SailFreeCell/issues/7/events","html_url":"https://github.com/munkki84/SailFreeCell/pull/7","id":78039952,"number":7,"title":"Optimistic stack size","user":{"login":"TorgeH","id":12459835,"avatar_url":"https://avatars.githubusercontent.com/u/12459835?v=3","gravatar_id":"","url":"https://api.github.com/users/TorgeH","html_url":"https://github.com/TorgeH","followers_url":"https://api.github.com/users/TorgeH/followers","following_url":"https://api.github.com/users/TorgeH/following{/other_user}","gists_url":"https://api.github.com/users/TorgeH/gists{/gist_id}","starred_url":"https://api.github.com/users/TorgeH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TorgeH/subscriptions","organizations_url":"https://api.github.com/users/TorgeH/orgs","repos_url":"https://api.github.com/users/TorgeH/repos","events_url":"https://api.github.com/users/TorgeH/events{/privacy}","received_events_url":"https://api.github.com/users/TorgeH/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-05-19T11:00:38Z","updated_at":"2015-05-21T18:18:10Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/munkki84/SailFreeCell/pulls/7","html_url":"https://github.com/munkki84/SailFreeCell/pull/7","diff_url":"https://github.com/munkki84/SailFreeCell/pull/7.diff","patch_url":"https://github.com/munkki84/SailFreeCell/pull/7.patch"},"body":"As you can see, this is a hell of a change.\r\nHere is a short summary of what I did:\r\n- re-rooted classes Cell and Card in \"FreeCellItem\" (name to be discussed?)\r\n- factored some common behavior in this class\r\n- added a level of classes under \"Cell\"\r\n- factored out all Case-distinctions based on Cell.type\r\n\r\nThe only (intentional) change in behavior is that Qt.freeCells is split up in Qt.freeFieldCells and Qt.freeSingle cells, allowing for a more optimistic calculation maxMoveStack().\r\nI'm still struggling with the difference in maxMoveStack() between \"FieldCell\"s and all other \"Card\"s..."},"comment":{"url":"https://api.github.com/repos/munkki84/SailFreeCell/issues/comments/104376810","html_url":"https://github.com/munkki84/SailFreeCell/pull/7#issuecomment-104376810","issue_url":"https://api.github.com/repos/munkki84/SailFreeCell/issues/7","id":104376810,"user":{"login":"TorgeH","id":12459835,"avatar_url":"https://avatars.githubusercontent.com/u/12459835?v=3","gravatar_id":"","url":"https://api.github.com/users/TorgeH","html_url":"https://github.com/TorgeH","followers_url":"https://api.github.com/users/TorgeH/followers","following_url":"https://api.github.com/users/TorgeH/following{/other_user}","gists_url":"https://api.github.com/users/TorgeH/gists{/gist_id}","starred_url":"https://api.github.com/users/TorgeH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TorgeH/subscriptions","organizations_url":"https://api.github.com/users/TorgeH/orgs","repos_url":"https://api.github.com/users/TorgeH/repos","events_url":"https://api.github.com/users/TorgeH/events{/privacy}","received_events_url":"https://api.github.com/users/TorgeH/received_events","type":"User","site_admin":false},"created_at":"2015-05-21T18:18:10Z","updated_at":"2015-05-21T18:18:10Z","body":"No, you're right. Those are duplicates of the 2 merged ones. I'll try to create a new, auto-mergeable pr soon."}}