{"action":"created","comment":{"url":"https://api.github.com/repos/Strider-CD/core/pulls/comments/35349213","id":35349213,"diff_hunk":"@@ -0,0 +1,15 @@\n+var winston = require('winston')","path":"lib/log.js","position":1,"original_position":1,"commit_id":"fd6086674cb6ffaa7bc9ae75daa1b5210ebf1509","original_commit_id":"fd6086674cb6ffaa7bc9ae75daa1b5210ebf1509","user":{"login":"knownasilya","id":34726,"avatar_url":"https://avatars.githubusercontent.com/u/34726?v=3","gravatar_id":"","url":"https://api.github.com/users/knownasilya","html_url":"https://github.com/knownasilya","followers_url":"https://api.github.com/users/knownasilya/followers","following_url":"https://api.github.com/users/knownasilya/following{/other_user}","gists_url":"https://api.github.com/users/knownasilya/gists{/gist_id}","starred_url":"https://api.github.com/users/knownasilya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knownasilya/subscriptions","organizations_url":"https://api.github.com/users/knownasilya/orgs","repos_url":"https://api.github.com/users/knownasilya/repos","events_url":"https://api.github.com/users/knownasilya/events{/privacy}","received_events_url":"https://api.github.com/users/knownasilya/received_events","type":"User","site_admin":false},"body":"Please be generous with spacing.","created_at":"2015-07-23T17:40:57Z","updated_at":"2015-07-23T17:40:57Z","html_url":"https://github.com/Strider-CD/core/pull/6#discussion_r35349213","pull_request_url":"https://api.github.com/repos/Strider-CD/core/pulls/6","_links":{"self":{"href":"https://api.github.com/repos/Strider-CD/core/pulls/comments/35349213"},"html":{"href":"https://github.com/Strider-CD/core/pull/6#discussion_r35349213"},"pull_request":{"href":"https://api.github.com/repos/Strider-CD/core/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/Strider-CD/core/pulls/6","id":40693208,"html_url":"https://github.com/Strider-CD/core/pull/6","diff_url":"https://github.com/Strider-CD/core/pull/6.diff","patch_url":"https://github.com/Strider-CD/core/pull/6.patch","issue_url":"https://api.github.com/repos/Strider-CD/core/issues/6","number":6,"state":"open","locked":false,"title":"Refactored API routes and added logging","user":{"login":"phiros","id":16182,"avatar_url":"https://avatars.githubusercontent.com/u/16182?v=3","gravatar_id":"","url":"https://api.github.com/users/phiros","html_url":"https://github.com/phiros","followers_url":"https://api.github.com/users/phiros/followers","following_url":"https://api.github.com/users/phiros/following{/other_user}","gists_url":"https://api.github.com/users/phiros/gists{/gist_id}","starred_url":"https://api.github.com/users/phiros/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phiros/subscriptions","organizations_url":"https://api.github.com/users/phiros/orgs","repos_url":"https://api.github.com/users/phiros/repos","events_url":"https://api.github.com/users/phiros/events{/privacy}","received_events_url":"https://api.github.com/users/phiros/received_events","type":"User","site_admin":false},"body":"This PR changes the following:\r\n* move public API routes out of index.js into config/apiRoutes. You might find this one strange but it will make sense when you see my follow up PR. My idea is that hapi handles the public API. However, all the work in the system should be done by microservices (preferably using seneca). This is why the public API description should be located under config. In essence it is just a glorified proxy configuration (we can add some input validation etc to this 'proxy' configuration later). \r\n* The apiPrefix is now in the default config file\r\n* While I was at it I added a proper logger\r\n* ```standard``` tests will no longer cause a test to fail. Either I did something wrong or ```standard``` is a little bit to stupid to see that ```Drone``` is actually used (run ```npm test``` to see what I mean)","created_at":"2015-07-23T16:49:41Z","updated_at":"2015-07-23T17:40:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4afef255739ca6ba9530371a75ba20e51456a949","assignee":{"login":"phiros","id":16182,"avatar_url":"https://avatars.githubusercontent.com/u/16182?v=3","gravatar_id":"","url":"https://api.github.com/users/phiros","html_url":"https://github.com/phiros","followers_url":"https://api.github.com/users/phiros/followers","following_url":"https://api.github.com/users/phiros/following{/other_user}","gists_url":"https://api.github.com/users/phiros/gists{/gist_id}","starred_url":"https://api.github.com/users/phiros/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phiros/subscriptions","organizations_url":"https://api.github.com/users/phiros/orgs","repos_url":"https://api.github.com/users/phiros/repos","events_url":"https://api.github.com/users/phiros/events{/privacy}","received_events_url":"https://api.github.com/users/phiros/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/Strider-CD/core/pulls/6/commits","review_comments_url":"https://api.github.com/repos/Strider-CD/core/pulls/6/comments","review_comment_url":"https://api.github.com/repos/Strider-CD/core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Strider-CD/core/issues/6/comments","statuses_url":"https://api.github.com/repos/Strider-CD/core/statuses/fd6086674cb6ffaa7bc9ae75daa1b5210ebf1509","head":{"label":"phiros:refactored_api_routes_out_of_index","ref":"refactored_api_routes_out_of_index","sha":"fd6086674cb6ffaa7bc9ae75daa1b5210ebf1509","user":{"login":"phiros","id":16182,"avatar_url":"https://avatars.githubusercontent.com/u/16182?v=3","gravatar_id":"","url":"https://api.github.com/users/phiros","html_url":"https://github.com/phiros","followers_url":"https://api.github.com/users/phiros/followers","following_url":"https://api.github.com/users/phiros/following{/other_user}","gists_url":"https://api.github.com/users/phiros/gists{/gist_id}","starred_url":"https://api.github.com/users/phiros/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phiros/subscriptions","organizations_url":"https://api.github.com/users/phiros/orgs","repos_url":"https://api.github.com/users/phiros/repos","events_url":"https://api.github.com/users/phiros/events{/privacy}","received_events_url":"https://api.github.com/users/phiros/received_events","type":"User","site_admin":false},"repo":{"id":39307449,"name":"core","full_name":"phiros/core","owner":{"login":"phiros","id":16182,"avatar_url":"https://avatars.githubusercontent.com/u/16182?v=3","gravatar_id":"","url":"https://api.github.com/users/phiros","html_url":"https://github.com/phiros","followers_url":"https://api.github.com/users/phiros/followers","following_url":"https://api.github.com/users/phiros/following{/other_user}","gists_url":"https://api.github.com/users/phiros/gists{/gist_id}","starred_url":"https://api.github.com/users/phiros/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phiros/subscriptions","organizations_url":"https://api.github.com/users/phiros/orgs","repos_url":"https://api.github.com/users/phiros/repos","events_url":"https://api.github.com/users/phiros/events{/privacy}","received_events_url":"https://api.github.com/users/phiros/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/phiros/core","description":"Strider Core","fork":true,"url":"https://api.github.com/repos/phiros/core","forks_url":"https://api.github.com/repos/phiros/core/forks","keys_url":"https://api.github.com/repos/phiros/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phiros/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phiros/core/teams","hooks_url":"https://api.github.com/repos/phiros/core/hooks","issue_events_url":"https://api.github.com/repos/phiros/core/issues/events{/number}","events_url":"https://api.github.com/repos/phiros/core/events","assignees_url":"https://api.github.com/repos/phiros/core/assignees{/user}","branches_url":"https://api.github.com/repos/phiros/core/branches{/branch}","tags_url":"https://api.github.com/repos/phiros/core/tags","blobs_url":"https://api.github.com/repos/phiros/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phiros/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phiros/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/phiros/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phiros/core/statuses/{sha}","languages_url":"https://api.github.com/repos/phiros/core/languages","stargazers_url":"https://api.github.com/repos/phiros/core/stargazers","contributors_url":"https://api.github.com/repos/phiros/core/contributors","subscribers_url":"https://api.github.com/repos/phiros/core/subscribers","subscription_url":"https://api.github.com/repos/phiros/core/subscription","commits_url":"https://api.github.com/repos/phiros/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/phiros/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/phiros/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/phiros/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/phiros/core/contents/{+path}","compare_url":"https://api.github.com/repos/phiros/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phiros/core/merges","archive_url":"https://api.github.com/repos/phiros/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phiros/core/downloads","issues_url":"https://api.github.com/repos/phiros/core/issues{/number}","pulls_url":"https://api.github.com/repos/phiros/core/pulls{/number}","milestones_url":"https://api.github.com/repos/phiros/core/milestones{/number}","notifications_url":"https://api.github.com/repos/phiros/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phiros/core/labels{/name}","releases_url":"https://api.github.com/repos/phiros/core/releases{/id}","created_at":"2015-07-18T17:55:29Z","updated_at":"2015-07-18T17:55:30Z","pushed_at":"2015-07-23T17:36:29Z","git_url":"git://github.com/phiros/core.git","ssh_url":"git@github.com:phiros/core.git","clone_url":"https://github.com/phiros/core.git","svn_url":"https://github.com/phiros/core","homepage":null,"size":62,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Strider-CD:master","ref":"master","sha":"d7413a00b18657f2151390679a0649c1ec892b7f","user":{"login":"Strider-CD","id":2199591,"avatar_url":"https://avatars.githubusercontent.com/u/2199591?v=3","gravatar_id":"","url":"https://api.github.com/users/Strider-CD","html_url":"https://github.com/Strider-CD","followers_url":"https://api.github.com/users/Strider-CD/followers","following_url":"https://api.github.com/users/Strider-CD/following{/other_user}","gists_url":"https://api.github.com/users/Strider-CD/gists{/gist_id}","starred_url":"https://api.github.com/users/Strider-CD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Strider-CD/subscriptions","organizations_url":"https://api.github.com/users/Strider-CD/orgs","repos_url":"https://api.github.com/users/Strider-CD/repos","events_url":"https://api.github.com/users/Strider-CD/events{/privacy}","received_events_url":"https://api.github.com/users/Strider-CD/received_events","type":"Organization","site_admin":false},"repo":{"id":38991104,"name":"core","full_name":"Strider-CD/core","owner":{"login":"Strider-CD","id":2199591,"avatar_url":"https://avatars.githubusercontent.com/u/2199591?v=3","gravatar_id":"","url":"https://api.github.com/users/Strider-CD","html_url":"https://github.com/Strider-CD","followers_url":"https://api.github.com/users/Strider-CD/followers","following_url":"https://api.github.com/users/Strider-CD/following{/other_user}","gists_url":"https://api.github.com/users/Strider-CD/gists{/gist_id}","starred_url":"https://api.github.com/users/Strider-CD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Strider-CD/subscriptions","organizations_url":"https://api.github.com/users/Strider-CD/orgs","repos_url":"https://api.github.com/users/Strider-CD/repos","events_url":"https://api.github.com/users/Strider-CD/events{/privacy}","received_events_url":"https://api.github.com/users/Strider-CD/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Strider-CD/core","description":"Strider Core","fork":false,"url":"https://api.github.com/repos/Strider-CD/core","forks_url":"https://api.github.com/repos/Strider-CD/core/forks","keys_url":"https://api.github.com/repos/Strider-CD/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Strider-CD/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Strider-CD/core/teams","hooks_url":"https://api.github.com/repos/Strider-CD/core/hooks","issue_events_url":"https://api.github.com/repos/Strider-CD/core/issues/events{/number}","events_url":"https://api.github.com/repos/Strider-CD/core/events","assignees_url":"https://api.github.com/repos/Strider-CD/core/assignees{/user}","branches_url":"https://api.github.com/repos/Strider-CD/core/branches{/branch}","tags_url":"https://api.github.com/repos/Strider-CD/core/tags","blobs_url":"https://api.github.com/repos/Strider-CD/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Strider-CD/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Strider-CD/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/Strider-CD/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Strider-CD/core/statuses/{sha}","languages_url":"https://api.github.com/repos/Strider-CD/core/languages","stargazers_url":"https://api.github.com/repos/Strider-CD/core/stargazers","contributors_url":"https://api.github.com/repos/Strider-CD/core/contributors","subscribers_url":"https://api.github.com/repos/Strider-CD/core/subscribers","subscription_url":"https://api.github.com/repos/Strider-CD/core/subscription","commits_url":"https://api.github.com/repos/Strider-CD/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/Strider-CD/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/Strider-CD/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/Strider-CD/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/Strider-CD/core/contents/{+path}","compare_url":"https://api.github.com/repos/Strider-CD/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Strider-CD/core/merges","archive_url":"https://api.github.com/repos/Strider-CD/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Strider-CD/core/downloads","issues_url":"https://api.github.com/repos/Strider-CD/core/issues{/number}","pulls_url":"https://api.github.com/repos/Strider-CD/core/pulls{/number}","milestones_url":"https://api.github.com/repos/Strider-CD/core/milestones{/number}","notifications_url":"https://api.github.com/repos/Strider-CD/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Strider-CD/core/labels{/name}","releases_url":"https://api.github.com/repos/Strider-CD/core/releases{/id}","created_at":"2015-07-13T04:24:26Z","updated_at":"2015-07-15T07:55:34Z","pushed_at":"2015-07-23T17:36:29Z","git_url":"git://github.com/Strider-CD/core.git","ssh_url":"git@github.com:Strider-CD/core.git","clone_url":"https://github.com/Strider-CD/core.git","svn_url":"https://github.com/Strider-CD/core","homepage":null,"size":110,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":4,"forks":1,"open_issues":4,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Strider-CD/core/pulls/6"},"html":{"href":"https://github.com/Strider-CD/core/pull/6"},"issue":{"href":"https://api.github.com/repos/Strider-CD/core/issues/6"},"comments":{"href":"https://api.github.com/repos/Strider-CD/core/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/Strider-CD/core/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/Strider-CD/core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Strider-CD/core/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/Strider-CD/core/statuses/fd6086674cb6ffaa7bc9ae75daa1b5210ebf1509"}}}}