{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/48000549","id":48000549,"diff_hunk":"@@ -93,7 +93,7 @@ protected override object CreateCodeRefactoringProvider(Workspace workspace)\n             await TestAsync(\n @\"class Z { [|public int A { get ; private set ; } public string B { get ; private set ; }|] } \",\n @\"class Z { public Z ( int a , string b ) { this . A = a ; this . B = b ; } public int A { get ; private set ; } public string B { get ; private set ; } } \",\n-index: 0, options: new Dictionary<OptionKey, object> { { new OptionKey(SimplificationOptions.QualifyMemberAccessWithThisOrMe, \"C#\"), true } });\n+index: 0, options: Option(SimplificationOptions.QualifyPropertyAccess, true));","path":"src/EditorFeatures/CSharpTest/CodeActions/GenerateFromMembers/GenerateConstructor/GenerateConstructorTests.cs","position":5,"original_position":5,"commit_id":"887cfd31cb2102f11860d3ca5fcfb6f1ad742e68","original_commit_id":"887cfd31cb2102f11860d3ca5fcfb6f1ad742e68","user":{"login":"CyrusNajmabadi","id":4564579,"avatar_url":"https://avatars.githubusercontent.com/u/4564579?v=3","gravatar_id":"","url":"https://api.github.com/users/CyrusNajmabadi","html_url":"https://github.com/CyrusNajmabadi","followers_url":"https://api.github.com/users/CyrusNajmabadi/followers","following_url":"https://api.github.com/users/CyrusNajmabadi/following{/other_user}","gists_url":"https://api.github.com/users/CyrusNajmabadi/gists{/gist_id}","starred_url":"https://api.github.com/users/CyrusNajmabadi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CyrusNajmabadi/subscriptions","organizations_url":"https://api.github.com/users/CyrusNajmabadi/orgs","repos_url":"https://api.github.com/users/CyrusNajmabadi/repos","events_url":"https://api.github.com/users/CyrusNajmabadi/events{/privacy}","received_events_url":"https://api.github.com/users/CyrusNajmabadi/received_events","type":"User","site_admin":false},"body":"thanks!","created_at":"2015-12-18T07:29:35Z","updated_at":"2015-12-18T07:29:35Z","html_url":"https://github.com/dotnet/roslyn/pull/7540#discussion_r48000549","pull_request_url":"https://api.github.com/repos/dotnet/roslyn/pulls/7540","_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/48000549"},"html":{"href":"https://github.com/dotnet/roslyn/pull/7540#discussion_r48000549"},"pull_request":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/7540"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/7540","id":53902402,"html_url":"https://github.com/dotnet/roslyn/pull/7540","diff_url":"https://github.com/dotnet/roslyn/pull/7540.diff","patch_url":"https://github.com/dotnet/roslyn/pull/7540.patch","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/7540","number":7540,"state":"open","locked":false,"title":"add options to require this/Me for fields, properties, methods, and events","user":{"login":"brettfo","id":926281,"avatar_url":"https://avatars.githubusercontent.com/u/926281?v=3","gravatar_id":"","url":"https://api.github.com/users/brettfo","html_url":"https://github.com/brettfo","followers_url":"https://api.github.com/users/brettfo/followers","following_url":"https://api.github.com/users/brettfo/following{/other_user}","gists_url":"https://api.github.com/users/brettfo/gists{/gist_id}","starred_url":"https://api.github.com/users/brettfo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brettfo/subscriptions","organizations_url":"https://api.github.com/users/brettfo/orgs","repos_url":"https://api.github.com/users/brettfo/repos","events_url":"https://api.github.com/users/brettfo/events{/privacy}","received_events_url":"https://api.github.com/users/brettfo/received_events","type":"User","site_admin":false},"body":"This is a re-creation of PR #7296 to address feedback.  Since there are so many changes I opted to close the other PR and open a new one to preserve an easy comment history and enable a side-by-side diff.\r\n\r\n### Description\r\nSplits the option _\"Qualify member access with 'this' or 'Me'\"_ into four separate options (and marks the former as `[Obsolete]`):\r\n\r\n- Qualify **field** access.\r\n- Qualify **property** access.\r\n- Qualify **method** access.\r\n- Qualify **event** access.\r\n\r\n### Known Issues\r\n1. We've discussed giving the user a dial in how and when these properties should be applied, e.g., \"only apply this style on newly generated code\" all the way up to \"flag violations of this style as a build break\" and various steps in between.  That has not been addressed in this PR and is still an open discussion item that I filed as #7289.\r\n2. If a user currently has _\"Qualify member access with 'this' or 'Me'\"_ set to `true`, we need some way to upgrade/migrate that setting to the 4 new separate settings.\r\n\r\nFixes #7065.\r\nFixes #7090.\r\nAlso fixes an unrelated bug I found in Encapsulate Field in VB that caused `Me.` to be improperly included when an escaped keyword is used when the option wasn't set and also enables Encapsulate Field in C# for escaped identifiers.","created_at":"2015-12-16T21:39:51Z","updated_at":"2015-12-18T07:29:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"696860c2d5126f8edd13345d844957c53b170f62","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/roslyn/pulls/7540/commits","review_comments_url":"https://api.github.com/repos/dotnet/roslyn/pulls/7540/comments","review_comment_url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/7540/comments","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/887cfd31cb2102f11860d3ca5fcfb6f1ad742e68","head":{"label":"brettfo:require-prohibit-this-me2","ref":"require-prohibit-this-me2","sha":"887cfd31cb2102f11860d3ca5fcfb6f1ad742e68","user":{"login":"brettfo","id":926281,"avatar_url":"https://avatars.githubusercontent.com/u/926281?v=3","gravatar_id":"","url":"https://api.github.com/users/brettfo","html_url":"https://github.com/brettfo","followers_url":"https://api.github.com/users/brettfo/followers","following_url":"https://api.github.com/users/brettfo/following{/other_user}","gists_url":"https://api.github.com/users/brettfo/gists{/gist_id}","starred_url":"https://api.github.com/users/brettfo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brettfo/subscriptions","organizations_url":"https://api.github.com/users/brettfo/orgs","repos_url":"https://api.github.com/users/brettfo/repos","events_url":"https://api.github.com/users/brettfo/events{/privacy}","received_events_url":"https://api.github.com/users/brettfo/received_events","type":"User","site_admin":false},"repo":{"id":30557497,"name":"roslyn","full_name":"brettfo/roslyn","owner":{"login":"brettfo","id":926281,"avatar_url":"https://avatars.githubusercontent.com/u/926281?v=3","gravatar_id":"","url":"https://api.github.com/users/brettfo","html_url":"https://github.com/brettfo","followers_url":"https://api.github.com/users/brettfo/followers","following_url":"https://api.github.com/users/brettfo/following{/other_user}","gists_url":"https://api.github.com/users/brettfo/gists{/gist_id}","starred_url":"https://api.github.com/users/brettfo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brettfo/subscriptions","organizations_url":"https://api.github.com/users/brettfo/orgs","repos_url":"https://api.github.com/users/brettfo/repos","events_url":"https://api.github.com/users/brettfo/events{/privacy}","received_events_url":"https://api.github.com/users/brettfo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brettfo/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":true,"url":"https://api.github.com/repos/brettfo/roslyn","forks_url":"https://api.github.com/repos/brettfo/roslyn/forks","keys_url":"https://api.github.com/repos/brettfo/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brettfo/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brettfo/roslyn/teams","hooks_url":"https://api.github.com/repos/brettfo/roslyn/hooks","issue_events_url":"https://api.github.com/repos/brettfo/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/brettfo/roslyn/events","assignees_url":"https://api.github.com/repos/brettfo/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/brettfo/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/brettfo/roslyn/tags","blobs_url":"https://api.github.com/repos/brettfo/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brettfo/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brettfo/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/brettfo/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brettfo/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/brettfo/roslyn/languages","stargazers_url":"https://api.github.com/repos/brettfo/roslyn/stargazers","contributors_url":"https://api.github.com/repos/brettfo/roslyn/contributors","subscribers_url":"https://api.github.com/repos/brettfo/roslyn/subscribers","subscription_url":"https://api.github.com/repos/brettfo/roslyn/subscription","commits_url":"https://api.github.com/repos/brettfo/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/brettfo/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/brettfo/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/brettfo/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/brettfo/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/brettfo/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brettfo/roslyn/merges","archive_url":"https://api.github.com/repos/brettfo/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brettfo/roslyn/downloads","issues_url":"https://api.github.com/repos/brettfo/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/brettfo/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/brettfo/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/brettfo/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brettfo/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/brettfo/roslyn/releases{/id}","created_at":"2015-02-09T20:43:48Z","updated_at":"2015-05-06T18:17:34Z","pushed_at":"2015-12-18T05:55:46Z","git_url":"git://github.com/brettfo/roslyn.git","ssh_url":"git@github.com:brettfo/roslyn.git","clone_url":"https://github.com/brettfo/roslyn.git","svn_url":"https://github.com/brettfo/roslyn","homepage":"","size":121211,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"38ac20ed4168b3cc7d6d9d8cd617128fdd356988","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":29078997,"name":"roslyn","full_name":"dotnet/roslyn","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":false,"url":"https://api.github.com/repos/dotnet/roslyn","forks_url":"https://api.github.com/repos/dotnet/roslyn/forks","keys_url":"https://api.github.com/repos/dotnet/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/roslyn/teams","hooks_url":"https://api.github.com/repos/dotnet/roslyn/hooks","issue_events_url":"https://api.github.com/repos/dotnet/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/roslyn/events","assignees_url":"https://api.github.com/repos/dotnet/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/roslyn/tags","blobs_url":"https://api.github.com/repos/dotnet/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/roslyn/languages","stargazers_url":"https://api.github.com/repos/dotnet/roslyn/stargazers","contributors_url":"https://api.github.com/repos/dotnet/roslyn/contributors","subscribers_url":"https://api.github.com/repos/dotnet/roslyn/subscribers","subscription_url":"https://api.github.com/repos/dotnet/roslyn/subscription","commits_url":"https://api.github.com/repos/dotnet/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/roslyn/merges","archive_url":"https://api.github.com/repos/dotnet/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/roslyn/downloads","issues_url":"https://api.github.com/repos/dotnet/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/roslyn/releases{/id}","created_at":"2015-01-11T02:39:03Z","updated_at":"2015-12-18T04:49:20Z","pushed_at":"2015-12-18T06:34:25Z","git_url":"git://github.com/dotnet/roslyn.git","ssh_url":"git@github.com:dotnet/roslyn.git","clone_url":"https://github.com/dotnet/roslyn.git","svn_url":"https://github.com/dotnet/roslyn","homepage":"","size":146583,"stargazers_count":4035,"watchers_count":4035,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":990,"mirror_url":null,"open_issues_count":1803,"forks":990,"open_issues":1803,"watchers":4035,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/7540"},"html":{"href":"https://github.com/dotnet/roslyn/pull/7540"},"issue":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/7540"},"comments":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/7540/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/7540/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/7540/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/roslyn/statuses/887cfd31cb2102f11860d3ca5fcfb6f1ad742e68"}}}}