{"action":"closed","number":656,"pull_request":{"url":"https://api.github.com/repos/spark/firmware/pulls/656","id":46604661,"html_url":"https://github.com/spark/firmware/pull/656","diff_url":"https://github.com/spark/firmware/pull/656.diff","patch_url":"https://github.com/spark/firmware/pull/656.patch","issue_url":"https://api.github.com/repos/spark/firmware/issues/656","number":656,"state":"closed","locked":false,"title":"pulseIn() for Photon/P1/Core/Electron, with tests","user":{"login":"technobly","id":2249224,"avatar_url":"https://avatars.githubusercontent.com/u/2249224?v=3","gravatar_id":"","url":"https://api.github.com/users/technobly","html_url":"https://github.com/technobly","followers_url":"https://api.github.com/users/technobly/followers","following_url":"https://api.github.com/users/technobly/following{/other_user}","gists_url":"https://api.github.com/users/technobly/gists{/gist_id}","starred_url":"https://api.github.com/users/technobly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/technobly/subscriptions","organizations_url":"https://api.github.com/users/technobly/orgs","repos_url":"https://api.github.com/users/technobly/repos","events_url":"https://api.github.com/users/technobly/events{/privacy}","received_events_url":"https://api.github.com/users/technobly/received_events","type":"User","site_admin":false},"body":"Quick implementation of a [**pulseIn()**](https://www.arduino.cc/en/Reference/PulseIn) from Arduino/Wiring.\r\n* Times out automatically after 3 seconds to keep from blocking background tasks.\r\n* Tests ran and passed on Photon and Core, but Electron TEST=wiring/no_fixture has compiler errors from different tests, so could not run for E.  Ran tests for P1 and pulseIn() passed but about 8 other tests failed :(\r\n* Thought it might be hard to test pulseIn() without a fixture, but surprise... you can read the state of an output when the PWM peripheral is banging out bits :joy: ","created_at":"2015-10-02T05:44:13Z","updated_at":"2015-10-16T00:39:29Z","closed_at":"2015-10-16T00:39:29Z","merged_at":"2015-10-16T00:39:29Z","merge_commit_sha":"3b7edf2bbf4aee07bb7422a2e5501b4dca0a69e1","assignee":null,"milestone":{"url":"https://api.github.com/repos/spark/firmware/milestones/12","html_url":"https://github.com/spark/firmware/milestones/0.4.7","labels_url":"https://api.github.com/repos/spark/firmware/milestones/12/labels","id":1324888,"number":12,"title":"0.4.7","description":"","creator":{"login":"m-mcgowan","id":2465470,"avatar_url":"https://avatars.githubusercontent.com/u/2465470?v=3","gravatar_id":"","url":"https://api.github.com/users/m-mcgowan","html_url":"https://github.com/m-mcgowan","followers_url":"https://api.github.com/users/m-mcgowan/followers","following_url":"https://api.github.com/users/m-mcgowan/following{/other_user}","gists_url":"https://api.github.com/users/m-mcgowan/gists{/gist_id}","starred_url":"https://api.github.com/users/m-mcgowan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m-mcgowan/subscriptions","organizations_url":"https://api.github.com/users/m-mcgowan/orgs","repos_url":"https://api.github.com/users/m-mcgowan/repos","events_url":"https://api.github.com/users/m-mcgowan/events{/privacy}","received_events_url":"https://api.github.com/users/m-mcgowan/received_events","type":"User","site_admin":false},"open_issues":21,"closed_issues":7,"state":"open","created_at":"2015-09-26T11:32:42Z","updated_at":"2015-10-16T00:39:29Z","due_on":"2015-10-18T22:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/spark/firmware/pulls/656/commits","review_comments_url":"https://api.github.com/repos/spark/firmware/pulls/656/comments","review_comment_url":"https://api.github.com/repos/spark/firmware/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spark/firmware/issues/656/comments","statuses_url":"https://api.github.com/repos/spark/firmware/statuses/af77c9d9aa1e80074867c43d438527456c750a55","head":{"label":"spark:feature/pulsein","ref":"feature/pulsein","sha":"af77c9d9aa1e80074867c43d438527456c750a55","user":{"login":"spark","id":2348966,"avatar_url":"https://avatars.githubusercontent.com/u/2348966?v=3","gravatar_id":"","url":"https://api.github.com/users/spark","html_url":"https://github.com/spark","followers_url":"https://api.github.com/users/spark/followers","following_url":"https://api.github.com/users/spark/following{/other_user}","gists_url":"https://api.github.com/users/spark/gists{/gist_id}","starred_url":"https://api.github.com/users/spark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spark/subscriptions","organizations_url":"https://api.github.com/users/spark/orgs","repos_url":"https://api.github.com/users/spark/repos","events_url":"https://api.github.com/users/spark/events{/privacy}","received_events_url":"https://api.github.com/users/spark/received_events","type":"Organization","site_admin":false},"repo":{"id":8720130,"name":"firmware","full_name":"spark/firmware","owner":{"login":"spark","id":2348966,"avatar_url":"https://avatars.githubusercontent.com/u/2348966?v=3","gravatar_id":"","url":"https://api.github.com/users/spark","html_url":"https://github.com/spark","followers_url":"https://api.github.com/users/spark/followers","following_url":"https://api.github.com/users/spark/following{/other_user}","gists_url":"https://api.github.com/users/spark/gists{/gist_id}","starred_url":"https://api.github.com/users/spark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spark/subscriptions","organizations_url":"https://api.github.com/users/spark/orgs","repos_url":"https://api.github.com/users/spark/repos","events_url":"https://api.github.com/users/spark/events{/privacy}","received_events_url":"https://api.github.com/users/spark/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spark/firmware","description":"Firmware for Particle Devices: Spark Core (master branch) and Photon (latest branch)","fork":false,"url":"https://api.github.com/repos/spark/firmware","forks_url":"https://api.github.com/repos/spark/firmware/forks","keys_url":"https://api.github.com/repos/spark/firmware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spark/firmware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spark/firmware/teams","hooks_url":"https://api.github.com/repos/spark/firmware/hooks","issue_events_url":"https://api.github.com/repos/spark/firmware/issues/events{/number}","events_url":"https://api.github.com/repos/spark/firmware/events","assignees_url":"https://api.github.com/repos/spark/firmware/assignees{/user}","branches_url":"https://api.github.com/repos/spark/firmware/branches{/branch}","tags_url":"https://api.github.com/repos/spark/firmware/tags","blobs_url":"https://api.github.com/repos/spark/firmware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spark/firmware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spark/firmware/git/refs{/sha}","trees_url":"https://api.github.com/repos/spark/firmware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spark/firmware/statuses/{sha}","languages_url":"https://api.github.com/repos/spark/firmware/languages","stargazers_url":"https://api.github.com/repos/spark/firmware/stargazers","contributors_url":"https://api.github.com/repos/spark/firmware/contributors","subscribers_url":"https://api.github.com/repos/spark/firmware/subscribers","subscription_url":"https://api.github.com/repos/spark/firmware/subscription","commits_url":"https://api.github.com/repos/spark/firmware/commits{/sha}","git_commits_url":"https://api.github.com/repos/spark/firmware/git/commits{/sha}","comments_url":"https://api.github.com/repos/spark/firmware/comments{/number}","issue_comment_url":"https://api.github.com/repos/spark/firmware/issues/comments{/number}","contents_url":"https://api.github.com/repos/spark/firmware/contents/{+path}","compare_url":"https://api.github.com/repos/spark/firmware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spark/firmware/merges","archive_url":"https://api.github.com/repos/spark/firmware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spark/firmware/downloads","issues_url":"https://api.github.com/repos/spark/firmware/issues{/number}","pulls_url":"https://api.github.com/repos/spark/firmware/pulls{/number}","milestones_url":"https://api.github.com/repos/spark/firmware/milestones{/number}","notifications_url":"https://api.github.com/repos/spark/firmware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spark/firmware/labels{/name}","releases_url":"https://api.github.com/repos/spark/firmware/releases{/id}","created_at":"2013-03-12T04:42:33Z","updated_at":"2015-10-15T20:36:42Z","pushed_at":"2015-10-16T00:39:28Z","git_url":"git://github.com/spark/firmware.git","ssh_url":"git@github.com:spark/firmware.git","clone_url":"https://github.com/spark/firmware.git","svn_url":"https://github.com/spark/firmware","homepage":"https://www.particle.io/","size":111081,"stargazers_count":339,"watchers_count":339,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":234,"mirror_url":null,"open_issues_count":75,"forks":234,"open_issues":75,"watchers":339,"default_branch":"develop"}},"base":{"label":"spark:develop","ref":"develop","sha":"275466b32ca1131e72603653fd4e7f9d785d269e","user":{"login":"spark","id":2348966,"avatar_url":"https://avatars.githubusercontent.com/u/2348966?v=3","gravatar_id":"","url":"https://api.github.com/users/spark","html_url":"https://github.com/spark","followers_url":"https://api.github.com/users/spark/followers","following_url":"https://api.github.com/users/spark/following{/other_user}","gists_url":"https://api.github.com/users/spark/gists{/gist_id}","starred_url":"https://api.github.com/users/spark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spark/subscriptions","organizations_url":"https://api.github.com/users/spark/orgs","repos_url":"https://api.github.com/users/spark/repos","events_url":"https://api.github.com/users/spark/events{/privacy}","received_events_url":"https://api.github.com/users/spark/received_events","type":"Organization","site_admin":false},"repo":{"id":8720130,"name":"firmware","full_name":"spark/firmware","owner":{"login":"spark","id":2348966,"avatar_url":"https://avatars.githubusercontent.com/u/2348966?v=3","gravatar_id":"","url":"https://api.github.com/users/spark","html_url":"https://github.com/spark","followers_url":"https://api.github.com/users/spark/followers","following_url":"https://api.github.com/users/spark/following{/other_user}","gists_url":"https://api.github.com/users/spark/gists{/gist_id}","starred_url":"https://api.github.com/users/spark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spark/subscriptions","organizations_url":"https://api.github.com/users/spark/orgs","repos_url":"https://api.github.com/users/spark/repos","events_url":"https://api.github.com/users/spark/events{/privacy}","received_events_url":"https://api.github.com/users/spark/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spark/firmware","description":"Firmware for Particle Devices: Spark Core (master branch) and Photon (latest branch)","fork":false,"url":"https://api.github.com/repos/spark/firmware","forks_url":"https://api.github.com/repos/spark/firmware/forks","keys_url":"https://api.github.com/repos/spark/firmware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spark/firmware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spark/firmware/teams","hooks_url":"https://api.github.com/repos/spark/firmware/hooks","issue_events_url":"https://api.github.com/repos/spark/firmware/issues/events{/number}","events_url":"https://api.github.com/repos/spark/firmware/events","assignees_url":"https://api.github.com/repos/spark/firmware/assignees{/user}","branches_url":"https://api.github.com/repos/spark/firmware/branches{/branch}","tags_url":"https://api.github.com/repos/spark/firmware/tags","blobs_url":"https://api.github.com/repos/spark/firmware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spark/firmware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spark/firmware/git/refs{/sha}","trees_url":"https://api.github.com/repos/spark/firmware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spark/firmware/statuses/{sha}","languages_url":"https://api.github.com/repos/spark/firmware/languages","stargazers_url":"https://api.github.com/repos/spark/firmware/stargazers","contributors_url":"https://api.github.com/repos/spark/firmware/contributors","subscribers_url":"https://api.github.com/repos/spark/firmware/subscribers","subscription_url":"https://api.github.com/repos/spark/firmware/subscription","commits_url":"https://api.github.com/repos/spark/firmware/commits{/sha}","git_commits_url":"https://api.github.com/repos/spark/firmware/git/commits{/sha}","comments_url":"https://api.github.com/repos/spark/firmware/comments{/number}","issue_comment_url":"https://api.github.com/repos/spark/firmware/issues/comments{/number}","contents_url":"https://api.github.com/repos/spark/firmware/contents/{+path}","compare_url":"https://api.github.com/repos/spark/firmware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spark/firmware/merges","archive_url":"https://api.github.com/repos/spark/firmware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spark/firmware/downloads","issues_url":"https://api.github.com/repos/spark/firmware/issues{/number}","pulls_url":"https://api.github.com/repos/spark/firmware/pulls{/number}","milestones_url":"https://api.github.com/repos/spark/firmware/milestones{/number}","notifications_url":"https://api.github.com/repos/spark/firmware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spark/firmware/labels{/name}","releases_url":"https://api.github.com/repos/spark/firmware/releases{/id}","created_at":"2013-03-12T04:42:33Z","updated_at":"2015-10-15T20:36:42Z","pushed_at":"2015-10-16T00:39:28Z","git_url":"git://github.com/spark/firmware.git","ssh_url":"git@github.com:spark/firmware.git","clone_url":"https://github.com/spark/firmware.git","svn_url":"https://github.com/spark/firmware","homepage":"https://www.particle.io/","size":111081,"stargazers_count":339,"watchers_count":339,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":234,"mirror_url":null,"open_issues_count":75,"forks":234,"open_issues":75,"watchers":339,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/spark/firmware/pulls/656"},"html":{"href":"https://github.com/spark/firmware/pull/656"},"issue":{"href":"https://api.github.com/repos/spark/firmware/issues/656"},"comments":{"href":"https://api.github.com/repos/spark/firmware/issues/656/comments"},"review_comments":{"href":"https://api.github.com/repos/spark/firmware/pulls/656/comments"},"review_comment":{"href":"https://api.github.com/repos/spark/firmware/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spark/firmware/pulls/656/commits"},"statuses":{"href":"https://api.github.com/repos/spark/firmware/statuses/af77c9d9aa1e80074867c43d438527456c750a55"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"m-mcgowan","id":2465470,"avatar_url":"https://avatars.githubusercontent.com/u/2465470?v=3","gravatar_id":"","url":"https://api.github.com/users/m-mcgowan","html_url":"https://github.com/m-mcgowan","followers_url":"https://api.github.com/users/m-mcgowan/followers","following_url":"https://api.github.com/users/m-mcgowan/following{/other_user}","gists_url":"https://api.github.com/users/m-mcgowan/gists{/gist_id}","starred_url":"https://api.github.com/users/m-mcgowan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m-mcgowan/subscriptions","organizations_url":"https://api.github.com/users/m-mcgowan/orgs","repos_url":"https://api.github.com/users/m-mcgowan/repos","events_url":"https://api.github.com/users/m-mcgowan/events{/privacy}","received_events_url":"https://api.github.com/users/m-mcgowan/received_events","type":"User","site_admin":false},"comments":0,"review_comments":3,"commits":1,"additions":154,"deletions":3,"changed_files":8}}