{"action":"closed","issue":{"url":"https://api.github.com/repos/mantidproject/issue-migration-testing/issues/59","labels_url":"https://api.github.com/repos/mantidproject/issue-migration-testing/issues/59/labels{/name}","comments_url":"https://api.github.com/repos/mantidproject/issue-migration-testing/issues/59/comments","events_url":"https://api.github.com/repos/mantidproject/issue-migration-testing/issues/59/events","html_url":"https://github.com/mantidproject/issue-migration-testing/issues/59","id":76384414,"number":59,"title":"LoadEventNexus incorrect field sizes handling","user":{"login":"rosswhitfield","id":5595210,"avatar_url":"https://avatars.githubusercontent.com/u/5595210?v=3","gravatar_id":"","url":"https://api.github.com/users/rosswhitfield","html_url":"https://github.com/rosswhitfield","followers_url":"https://api.github.com/users/rosswhitfield/followers","following_url":"https://api.github.com/users/rosswhitfield/following{/other_user}","gists_url":"https://api.github.com/users/rosswhitfield/gists{/gist_id}","starred_url":"https://api.github.com/users/rosswhitfield/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rosswhitfield/subscriptions","organizations_url":"https://api.github.com/users/rosswhitfield/orgs","repos_url":"https://api.github.com/users/rosswhitfield/repos","events_url":"https://api.github.com/users/rosswhitfield/events{/privacy}","received_events_url":"https://api.github.com/users/rosswhitfield/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"peterfpeterson","id":404003,"avatar_url":"https://avatars.githubusercontent.com/u/404003?v=3","gravatar_id":"","url":"https://api.github.com/users/peterfpeterson","html_url":"https://github.com/peterfpeterson","followers_url":"https://api.github.com/users/peterfpeterson/followers","following_url":"https://api.github.com/users/peterfpeterson/following{/other_user}","gists_url":"https://api.github.com/users/peterfpeterson/gists{/gist_id}","starred_url":"https://api.github.com/users/peterfpeterson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterfpeterson/subscriptions","organizations_url":"https://api.github.com/users/peterfpeterson/orgs","repos_url":"https://api.github.com/users/peterfpeterson/repos","events_url":"https://api.github.com/users/peterfpeterson/events{/privacy}","received_events_url":"https://api.github.com/users/peterfpeterson/received_events","type":"User","site_admin":false},"milestone":null,"comments":1,"created_at":"2015-05-14T14:55:11Z","updated_at":"2015-05-15T19:43:20Z","closed_at":"2015-05-15T19:43:20Z","body":"In the following bit of code, while it detects the incorrect field sizes and skips looking for pulse times, it still assigns a (zero) pulse time. After the data is loaded there is no way to know that the pulseTime is bad, unless you compare the pulseTime() to a zero DataAndTime.\n\nPossible solution, if condition is True convert the events to WeightedNoTime.\n\n{{{\n    int numPulses = static_cast<int>(thisBankPulseTimes->numPulses);\n    if (numPulses > static_cast<int>(event_index->size()))\n    {\n      alg->getLogger().warning() << \"Entry \" << entry_name << \"'s event_index vector is smaller than the event_time_zero field. This is inconsistent, so we cannot find pulse times for this entry.\\n\";\n      //This'll make the code skip looking for any pulse times.\n      pulse_i = numPulses + 1;\n    }\n}}}\n"}}