{"action":"created","comment":{"url":"https://api.github.com/repos/Ian-Stewart-Binks/buildship/pulls/comments/33163555","id":33163555,"diff_hunk":"@@ -35,6 +37,7 @@\n \n     private final WorkspaceOperations workspaceOperations;\n     private final ProjectConfigurationPersistence projectConfigurationPersistence;\n+    private IProjectConfigurator[] projectConfigurators = {new JavaProjectConfigurator()};","path":"org.eclipse.buildship.core/src/main/java/org/eclipse/buildship/core/configuration/internal/DefaultProjectConfigurationManager.java","position":16,"original_position":16,"commit_id":"c8fb104e1e687bc33f49f685c52ae94d90af4654","original_commit_id":"c8fb104e1e687bc33f49f685c52ae94d90af4654","user":{"login":"Ian-Stewart-Binks","id":6301000,"avatar_url":"https://avatars.githubusercontent.com/u/6301000?v=3","gravatar_id":"","url":"https://api.github.com/users/Ian-Stewart-Binks","html_url":"https://github.com/Ian-Stewart-Binks","followers_url":"https://api.github.com/users/Ian-Stewart-Binks/followers","following_url":"https://api.github.com/users/Ian-Stewart-Binks/following{/other_user}","gists_url":"https://api.github.com/users/Ian-Stewart-Binks/gists{/gist_id}","starred_url":"https://api.github.com/users/Ian-Stewart-Binks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ian-Stewart-Binks/subscriptions","organizations_url":"https://api.github.com/users/Ian-Stewart-Binks/orgs","repos_url":"https://api.github.com/users/Ian-Stewart-Binks/repos","events_url":"https://api.github.com/users/Ian-Stewart-Binks/events{/privacy}","received_events_url":"https://api.github.com/users/Ian-Stewart-Binks/received_events","type":"User","site_admin":false},"body":"This will be changed such that each IProjectConfigurator implementation is specified in its own plugin in Buildship. Each configurator will then be resolved by some method in the ProjectConfigurationManager.","created_at":"2015-06-24T16:00:02Z","updated_at":"2015-06-24T16:00:02Z","html_url":"https://github.com/Ian-Stewart-Binks/buildship/pull/6#discussion_r33163555","pull_request_url":"https://api.github.com/repos/Ian-Stewart-Binks/buildship/pulls/6","_links":{"self":{"href":"https://api.github.com/repos/Ian-Stewart-Binks/buildship/pulls/comments/33163555"},"html":{"href":"https://github.com/Ian-Stewart-Binks/buildship/pull/6#discussion_r33163555"},"pull_request":{"href":"https://api.github.com/repos/Ian-Stewart-Binks/buildship/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/Ian-Stewart-Binks/buildship/pulls/6","id":38457861,"html_url":"https://github.com/Ian-Stewart-Binks/buildship/pull/6","diff_url":"https://github.com/Ian-Stewart-Binks/buildship/pull/6.diff","patch_url":"https://github.com/Ian-Stewart-Binks/buildship/pull/6.patch","issue_url":"https://api.github.com/repos/Ian-Stewart-Binks/buildship/issues/6","number":6,"state":"open","locked":false,"title":"Internal: Bug 468244 - Provide a project configurator API","user":{"login":"Ian-Stewart-Binks","id":6301000,"avatar_url":"https://avatars.githubusercontent.com/u/6301000?v=3","gravatar_id":"","url":"https://api.github.com/users/Ian-Stewart-Binks","html_url":"https://github.com/Ian-Stewart-Binks","followers_url":"https://api.github.com/users/Ian-Stewart-Binks/followers","following_url":"https://api.github.com/users/Ian-Stewart-Binks/following{/other_user}","gists_url":"https://api.github.com/users/Ian-Stewart-Binks/gists{/gist_id}","starred_url":"https://api.github.com/users/Ian-Stewart-Binks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ian-Stewart-Binks/subscriptions","organizations_url":"https://api.github.com/users/Ian-Stewart-Binks/orgs","repos_url":"https://api.github.com/users/Ian-Stewart-Binks/repos","events_url":"https://api.github.com/users/Ian-Stewart-Binks/events{/privacy}","received_events_url":"https://api.github.com/users/Ian-Stewart-Binks/received_events","type":"User","site_admin":false},"body":"Meant for internal review for @fbricon.\r\n\r\nThis is what we talked about yesterday. I have decoupled the Java configuration from the `ProjectImportJob.importProject` method. It's a rough implementation, but I believe it hits the targets that we laid out yesterday. I'll leave some comments throughout the code.\r\n\r\n*Step 1: Refactor existing buildship code such that the Java configuration is applied through a separate configurator, the configurator should be applied by a ProjectConfigurationManager of some sort, which should loop through a set of project configurators, check which ones should be applied, and then apply those configurators.*","created_at":"2015-06-24T15:58:18Z","updated_at":"2015-06-24T16:00:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"da434e2dbb8ccf4d7aec17184483e9dcd58216d6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Ian-Stewart-Binks/buildship/pulls/6/commits","review_comments_url":"https://api.github.com/repos/Ian-Stewart-Binks/buildship/pulls/6/comments","review_comment_url":"https://api.github.com/repos/Ian-Stewart-Binks/buildship/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Ian-Stewart-Binks/buildship/issues/6/comments","statuses_url":"https://api.github.com/repos/Ian-Stewart-Binks/buildship/statuses/c8fb104e1e687bc33f49f685c52ae94d90af4654","head":{"label":"Ian-Stewart-Binks:config-api","ref":"config-api","sha":"c8fb104e1e687bc33f49f685c52ae94d90af4654","user":{"login":"Ian-Stewart-Binks","id":6301000,"avatar_url":"https://avatars.githubusercontent.com/u/6301000?v=3","gravatar_id":"","url":"https://api.github.com/users/Ian-Stewart-Binks","html_url":"https://github.com/Ian-Stewart-Binks","followers_url":"https://api.github.com/users/Ian-Stewart-Binks/followers","following_url":"https://api.github.com/users/Ian-Stewart-Binks/following{/other_user}","gists_url":"https://api.github.com/users/Ian-Stewart-Binks/gists{/gist_id}","starred_url":"https://api.github.com/users/Ian-Stewart-Binks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ian-Stewart-Binks/subscriptions","organizations_url":"https://api.github.com/users/Ian-Stewart-Binks/orgs","repos_url":"https://api.github.com/users/Ian-Stewart-Binks/repos","events_url":"https://api.github.com/users/Ian-Stewart-Binks/events{/privacy}","received_events_url":"https://api.github.com/users/Ian-Stewart-Binks/received_events","type":"User","site_admin":false},"repo":{"id":36679417,"name":"buildship","full_name":"Ian-Stewart-Binks/buildship","owner":{"login":"Ian-Stewart-Binks","id":6301000,"avatar_url":"https://avatars.githubusercontent.com/u/6301000?v=3","gravatar_id":"","url":"https://api.github.com/users/Ian-Stewart-Binks","html_url":"https://github.com/Ian-Stewart-Binks","followers_url":"https://api.github.com/users/Ian-Stewart-Binks/followers","following_url":"https://api.github.com/users/Ian-Stewart-Binks/following{/other_user}","gists_url":"https://api.github.com/users/Ian-Stewart-Binks/gists{/gist_id}","starred_url":"https://api.github.com/users/Ian-Stewart-Binks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ian-Stewart-Binks/subscriptions","organizations_url":"https://api.github.com/users/Ian-Stewart-Binks/orgs","repos_url":"https://api.github.com/users/Ian-Stewart-Binks/repos","events_url":"https://api.github.com/users/Ian-Stewart-Binks/events{/privacy}","received_events_url":"https://api.github.com/users/Ian-Stewart-Binks/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Ian-Stewart-Binks/buildship","description":"The Eclipse Plug-ins for Gradle project.","fork":true,"url":"https://api.github.com/repos/Ian-Stewart-Binks/buildship","forks_url":"https://api.github.com/repos/Ian-Stewart-Binks/buildship/forks","keys_url":"https://api.github.com/repos/Ian-Stewart-Binks/buildship/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ian-Stewart-Binks/buildship/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ian-Stewart-Binks/buildship/teams","hooks_url":"https://api.github.com/repos/Ian-Stewart-Binks/buildship/hooks","issue_events_url":"https://api.github.com/repos/Ian-Stewart-Binks/buildship/issues/events{/number}","events_url":"https://api.github.com/repos/Ian-Stewart-Binks/buildship/events","assignees_url":"https://api.github.com/repos/Ian-Stewart-Binks/buildship/assignees{/user}","branches_url":"https://api.github.com/repos/Ian-Stewart-Binks/buildship/branches{/branch}","tags_url":"https://api.github.com/repos/Ian-Stewart-Binks/buildship/tags","blobs_url":"https://api.github.com/repos/Ian-Stewart-Binks/buildship/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ian-Stewart-Binks/buildship/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ian-Stewart-Binks/buildship/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ian-Stewart-Binks/buildship/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ian-Stewart-Binks/buildship/statuses/{sha}","languages_url":"https://api.github.com/repos/Ian-Stewart-Binks/buildship/languages","stargazers_url":"https://api.github.com/repos/Ian-Stewart-Binks/buildship/stargazers","contributors_url":"https://api.github.com/repos/Ian-Stewart-Binks/buildship/contributors","subscribers_url":"https://api.github.com/repos/Ian-Stewart-Binks/buildship/subscribers","subscription_url":"https://api.github.com/repos/Ian-Stewart-Binks/buildship/subscription","commits_url":"https://api.github.com/repos/Ian-Stewart-Binks/buildship/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ian-Stewart-Binks/buildship/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ian-Stewart-Binks/buildship/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ian-Stewart-Binks/buildship/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ian-Stewart-Binks/buildship/contents/{+path}","compare_url":"https://api.github.com/repos/Ian-Stewart-Binks/buildship/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ian-Stewart-Binks/buildship/merges","archive_url":"https://api.github.com/repos/Ian-Stewart-Binks/buildship/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ian-Stewart-Binks/buildship/downloads","issues_url":"https://api.github.com/repos/Ian-Stewart-Binks/buildship/issues{/number}","pulls_url":"https://api.github.com/repos/Ian-Stewart-Binks/buildship/pulls{/number}","milestones_url":"https://api.github.com/repos/Ian-Stewart-Binks/buildship/milestones{/number}","notifications_url":"https://api.github.com/repos/Ian-Stewart-Binks/buildship/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ian-Stewart-Binks/buildship/labels{/name}","releases_url":"https://api.github.com/repos/Ian-Stewart-Binks/buildship/releases{/id}","created_at":"2015-06-01T18:17:16Z","updated_at":"2015-06-01T18:17:17Z","pushed_at":"2015-06-24T15:58:18Z","git_url":"git://github.com/Ian-Stewart-Binks/buildship.git","ssh_url":"git@github.com:Ian-Stewart-Binks/buildship.git","clone_url":"https://github.com/Ian-Stewart-Binks/buildship.git","svn_url":"https://github.com/Ian-Stewart-Binks/buildship","homepage":"","size":22206,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"Ian-Stewart-Binks:master","ref":"master","sha":"437ee9c3c75c31eea960155447bc96dd045e9790","user":{"login":"Ian-Stewart-Binks","id":6301000,"avatar_url":"https://avatars.githubusercontent.com/u/6301000?v=3","gravatar_id":"","url":"https://api.github.com/users/Ian-Stewart-Binks","html_url":"https://github.com/Ian-Stewart-Binks","followers_url":"https://api.github.com/users/Ian-Stewart-Binks/followers","following_url":"https://api.github.com/users/Ian-Stewart-Binks/following{/other_user}","gists_url":"https://api.github.com/users/Ian-Stewart-Binks/gists{/gist_id}","starred_url":"https://api.github.com/users/Ian-Stewart-Binks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ian-Stewart-Binks/subscriptions","organizations_url":"https://api.github.com/users/Ian-Stewart-Binks/orgs","repos_url":"https://api.github.com/users/Ian-Stewart-Binks/repos","events_url":"https://api.github.com/users/Ian-Stewart-Binks/events{/privacy}","received_events_url":"https://api.github.com/users/Ian-Stewart-Binks/received_events","type":"User","site_admin":false},"repo":{"id":36679417,"name":"buildship","full_name":"Ian-Stewart-Binks/buildship","owner":{"login":"Ian-Stewart-Binks","id":6301000,"avatar_url":"https://avatars.githubusercontent.com/u/6301000?v=3","gravatar_id":"","url":"https://api.github.com/users/Ian-Stewart-Binks","html_url":"https://github.com/Ian-Stewart-Binks","followers_url":"https://api.github.com/users/Ian-Stewart-Binks/followers","following_url":"https://api.github.com/users/Ian-Stewart-Binks/following{/other_user}","gists_url":"https://api.github.com/users/Ian-Stewart-Binks/gists{/gist_id}","starred_url":"https://api.github.com/users/Ian-Stewart-Binks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ian-Stewart-Binks/subscriptions","organizations_url":"https://api.github.com/users/Ian-Stewart-Binks/orgs","repos_url":"https://api.github.com/users/Ian-Stewart-Binks/repos","events_url":"https://api.github.com/users/Ian-Stewart-Binks/events{/privacy}","received_events_url":"https://api.github.com/users/Ian-Stewart-Binks/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Ian-Stewart-Binks/buildship","description":"The Eclipse Plug-ins for Gradle project.","fork":true,"url":"https://api.github.com/repos/Ian-Stewart-Binks/buildship","forks_url":"https://api.github.com/repos/Ian-Stewart-Binks/buildship/forks","keys_url":"https://api.github.com/repos/Ian-Stewart-Binks/buildship/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ian-Stewart-Binks/buildship/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ian-Stewart-Binks/buildship/teams","hooks_url":"https://api.github.com/repos/Ian-Stewart-Binks/buildship/hooks","issue_events_url":"https://api.github.com/repos/Ian-Stewart-Binks/buildship/issues/events{/number}","events_url":"https://api.github.com/repos/Ian-Stewart-Binks/buildship/events","assignees_url":"https://api.github.com/repos/Ian-Stewart-Binks/buildship/assignees{/user}","branches_url":"https://api.github.com/repos/Ian-Stewart-Binks/buildship/branches{/branch}","tags_url":"https://api.github.com/repos/Ian-Stewart-Binks/buildship/tags","blobs_url":"https://api.github.com/repos/Ian-Stewart-Binks/buildship/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ian-Stewart-Binks/buildship/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ian-Stewart-Binks/buildship/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ian-Stewart-Binks/buildship/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ian-Stewart-Binks/buildship/statuses/{sha}","languages_url":"https://api.github.com/repos/Ian-Stewart-Binks/buildship/languages","stargazers_url":"https://api.github.com/repos/Ian-Stewart-Binks/buildship/stargazers","contributors_url":"https://api.github.com/repos/Ian-Stewart-Binks/buildship/contributors","subscribers_url":"https://api.github.com/repos/Ian-Stewart-Binks/buildship/subscribers","subscription_url":"https://api.github.com/repos/Ian-Stewart-Binks/buildship/subscription","commits_url":"https://api.github.com/repos/Ian-Stewart-Binks/buildship/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ian-Stewart-Binks/buildship/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ian-Stewart-Binks/buildship/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ian-Stewart-Binks/buildship/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ian-Stewart-Binks/buildship/contents/{+path}","compare_url":"https://api.github.com/repos/Ian-Stewart-Binks/buildship/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ian-Stewart-Binks/buildship/merges","archive_url":"https://api.github.com/repos/Ian-Stewart-Binks/buildship/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ian-Stewart-Binks/buildship/downloads","issues_url":"https://api.github.com/repos/Ian-Stewart-Binks/buildship/issues{/number}","pulls_url":"https://api.github.com/repos/Ian-Stewart-Binks/buildship/pulls{/number}","milestones_url":"https://api.github.com/repos/Ian-Stewart-Binks/buildship/milestones{/number}","notifications_url":"https://api.github.com/repos/Ian-Stewart-Binks/buildship/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ian-Stewart-Binks/buildship/labels{/name}","releases_url":"https://api.github.com/repos/Ian-Stewart-Binks/buildship/releases{/id}","created_at":"2015-06-01T18:17:16Z","updated_at":"2015-06-01T18:17:17Z","pushed_at":"2015-06-24T15:58:18Z","git_url":"git://github.com/Ian-Stewart-Binks/buildship.git","ssh_url":"git@github.com:Ian-Stewart-Binks/buildship.git","clone_url":"https://github.com/Ian-Stewart-Binks/buildship.git","svn_url":"https://github.com/Ian-Stewart-Binks/buildship","homepage":"","size":22206,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Ian-Stewart-Binks/buildship/pulls/6"},"html":{"href":"https://github.com/Ian-Stewart-Binks/buildship/pull/6"},"issue":{"href":"https://api.github.com/repos/Ian-Stewart-Binks/buildship/issues/6"},"comments":{"href":"https://api.github.com/repos/Ian-Stewart-Binks/buildship/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/Ian-Stewart-Binks/buildship/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/Ian-Stewart-Binks/buildship/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Ian-Stewart-Binks/buildship/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/Ian-Stewart-Binks/buildship/statuses/c8fb104e1e687bc33f49f685c52ae94d90af4654"}}}}