{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/folly/issues/112","labels_url":"https://api.github.com/repos/facebook/folly/issues/112/labels{/name}","comments_url":"https://api.github.com/repos/facebook/folly/issues/112/comments","events_url":"https://api.github.com/repos/facebook/folly/issues/112/events","html_url":"https://github.com/facebook/folly/pull/112","id":53118933,"number":112,"title":"Update README and configure.ac message concerning double-conversion","user":{"login":"nsuke","id":3064114,"avatar_url":"https://avatars.githubusercontent.com/u/3064114?v=3","gravatar_id":"","url":"https://api.github.com/users/nsuke","html_url":"https://github.com/nsuke","followers_url":"https://api.github.com/users/nsuke/followers","following_url":"https://api.github.com/users/nsuke/following{/other_user}","gists_url":"https://api.github.com/users/nsuke/gists{/gist_id}","starred_url":"https://api.github.com/users/nsuke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nsuke/subscriptions","organizations_url":"https://api.github.com/users/nsuke/orgs","repos_url":"https://api.github.com/users/nsuke/repos","events_url":"https://api.github.com/users/nsuke/events{/privacy}","received_events_url":"https://api.github.com/users/nsuke/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2014-12-30T14:30:10Z","updated_at":"2015-01-25T11:10:13Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/facebook/folly/pulls/112","html_url":"https://github.com/facebook/folly/pull/112","diff_url":"https://github.com/facebook/folly/pull/112.diff","patch_url":"https://github.com/facebook/folly/pull/112.patch"},"body":"Documentation about double-conversion seems outdated.\r\n\r\n* #include path has changed\r\n* SConstruct.double-conversion is no longer present, but was not necessary at all for successful `make`/`make check` for me.\r\n\r\nAs to the second point, the file was added years ago and removed last month.\r\nI tried with latest release (v.1.1.5) and current master and `make check` just worked with both."},"comment":{"url":"https://api.github.com/repos/facebook/folly/issues/comments/71366856","html_url":"https://github.com/facebook/folly/pull/112#issuecomment-71366856","issue_url":"https://api.github.com/repos/facebook/folly/issues/112","id":71366856,"user":{"login":"nsuke","id":3064114,"avatar_url":"https://avatars.githubusercontent.com/u/3064114?v=3","gravatar_id":"","url":"https://api.github.com/users/nsuke","html_url":"https://github.com/nsuke","followers_url":"https://api.github.com/users/nsuke/followers","following_url":"https://api.github.com/users/nsuke/following{/other_user}","gists_url":"https://api.github.com/users/nsuke/gists{/gist_id}","starred_url":"https://api.github.com/users/nsuke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nsuke/subscriptions","organizations_url":"https://api.github.com/users/nsuke/orgs","repos_url":"https://api.github.com/users/nsuke/repos","events_url":"https://api.github.com/users/nsuke/events{/privacy}","received_events_url":"https://api.github.com/users/nsuke/received_events","type":"User","site_admin":false},"created_at":"2015-01-25T11:10:13Z","updated_at":"2015-01-25T11:10:13Z","body":"No worries, just minor contribution back.\r\n\r\nI rebased it but there's one thing that original PR contains and is not discussed here:\r\nDuring the build, `./generate_fingerprint_tables` is invoked by `make` and it needs LD_LIBRARY_PATH, unless of course you have double-conversion installed.\r\n\r\nI supposed this is a valid problem and included to rebased version. Let me know if it's not the case."}}