{"action":"created","issue":{"url":"https://api.github.com/repos/avo1/Yelpy/issues/1","labels_url":"https://api.github.com/repos/avo1/Yelpy/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/avo1/Yelpy/issues/1/comments","events_url":"https://api.github.com/repos/avo1/Yelpy/issues/1/events","html_url":"https://github.com/avo1/Yelpy/issues/1","id":118259729,"number":1,"title":"Week 2 assignment submission - Yelpy","user":{"login":"avo1","id":10482065,"avatar_url":"https://avatars.githubusercontent.com/u/10482065?v=3","gravatar_id":"","url":"https://api.github.com/users/avo1","html_url":"https://github.com/avo1","followers_url":"https://api.github.com/users/avo1/followers","following_url":"https://api.github.com/users/avo1/following{/other_user}","gists_url":"https://api.github.com/users/avo1/gists{/gist_id}","starred_url":"https://api.github.com/users/avo1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avo1/subscriptions","organizations_url":"https://api.github.com/users/avo1/orgs","repos_url":"https://api.github.com/users/avo1/repos","events_url":"https://api.github.com/users/avo1/events{/privacy}","received_events_url":"https://api.github.com/users/avo1/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-11-22T12:05:35Z","updated_at":"2015-11-26T07:59:55Z","closed_at":null,"body":"Hi, here's my submission. Please review /cc @coderschoolreview\r\nThanks.\r\n\r\nP/S: \r\n1. I know there's a misplaced warning in the autoLayout for dimmingView, but I don't want to fix it, else it will cover everything and I can't select the items underneath\r\n2. There're still lots of thing to do with the map and I might spend time later :D "},"comment":{"url":"https://api.github.com/repos/avo1/Yelpy/issues/comments/159841161","html_url":"https://github.com/avo1/Yelpy/issues/1#issuecomment-159841161","issue_url":"https://api.github.com/repos/avo1/Yelpy/issues/1","id":159841161,"user":{"login":"chug2k","id":44512,"avatar_url":"https://avatars.githubusercontent.com/u/44512?v=3","gravatar_id":"","url":"https://api.github.com/users/chug2k","html_url":"https://github.com/chug2k","followers_url":"https://api.github.com/users/chug2k/followers","following_url":"https://api.github.com/users/chug2k/following{/other_user}","gists_url":"https://api.github.com/users/chug2k/gists{/gist_id}","starred_url":"https://api.github.com/users/chug2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chug2k/subscriptions","organizations_url":"https://api.github.com/users/chug2k/orgs","repos_url":"https://api.github.com/users/chug2k/repos","events_url":"https://api.github.com/users/chug2k/events{/privacy}","received_events_url":"https://api.github.com/users/chug2k/received_events","type":"User","site_admin":false},"created_at":"2015-11-26T07:59:55Z","updated_at":"2015-11-26T07:59:55Z","body":":+1: nice work. The primary challenge of this homework was to learn how to use UITableView to manage a complex form, establish communication between view controllers, and apply the correct Auto Layout constraints.\r\n\r\nThis was a challenging assignment, congrats on completing it successfully!\r\n\r\nNice work specifying the Auto Layout constraints. That warning is that the frame will be misplaced at runtime. Meaning that no matter what you do in Interface Builder with the frame (i..e where you place it) it will cover up the whole screen based on your constraints. So you should fix it, right? Let me know if I misunderstood.\r\n\r\n* Nice work linking the filter model with the controls. See this [popular form library](https://github.com/nicklockwood/FXForms) for an alternative to implementing forms manually.\r\n\r\n* Nice work connecting the view controllers via the custom filter delegate. This is a popular pattern for handling events between view controllers.\r\n\r\nI really like the fade you did. Looks very nice. And congratulations on getting most of the map functionality! Very good submission. :tada: "}}