{"action":"created","comment":{"url":"https://api.github.com/repos/thoughtbot/hound/pulls/comments/41483980","id":41483980,"diff_hunk":"@@ -0,0 +1,19 @@\n+module Config\n+  class Base\n+    pattr_initialize :hound_config, :linter","path":"app/models/config/base.rb","position":3,"original_position":3,"commit_id":"4f7b21478fa913e8f52a7784327743f82ac4b319","original_commit_id":"4f7b21478fa913e8f52a7784327743f82ac4b319","user":{"login":"teoljungberg","id":810650,"avatar_url":"https://avatars.githubusercontent.com/u/810650?v=3","gravatar_id":"","url":"https://api.github.com/users/teoljungberg","html_url":"https://github.com/teoljungberg","followers_url":"https://api.github.com/users/teoljungberg/followers","following_url":"https://api.github.com/users/teoljungberg/following{/other_user}","gists_url":"https://api.github.com/users/teoljungberg/gists{/gist_id}","starred_url":"https://api.github.com/users/teoljungberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teoljungberg/subscriptions","organizations_url":"https://api.github.com/users/teoljungberg/orgs","repos_url":"https://api.github.com/users/teoljungberg/repos","events_url":"https://api.github.com/users/teoljungberg/events{/privacy}","received_events_url":"https://api.github.com/users/teoljungberg/received_events","type":"User","site_admin":false},"body":"Good call1","created_at":"2015-10-08T07:40:16Z","updated_at":"2015-10-08T07:40:16Z","html_url":"https://github.com/thoughtbot/hound/pull/950#discussion_r41483980","pull_request_url":"https://api.github.com/repos/thoughtbot/hound/pulls/950","_links":{"self":{"href":"https://api.github.com/repos/thoughtbot/hound/pulls/comments/41483980"},"html":{"href":"https://github.com/thoughtbot/hound/pull/950#discussion_r41483980"},"pull_request":{"href":"https://api.github.com/repos/thoughtbot/hound/pulls/950"}}},"pull_request":{"url":"https://api.github.com/repos/thoughtbot/hound/pulls/950","id":46912215,"html_url":"https://github.com/thoughtbot/hound/pull/950","diff_url":"https://github.com/thoughtbot/hound/pull/950.diff","patch_url":"https://github.com/thoughtbot/hound/pull/950.patch","issue_url":"https://api.github.com/repos/thoughtbot/hound/issues/950","number":950,"state":"open","locked":false,"title":"Introduce a `Config` class for each `Linter`","user":{"login":"teoljungberg","id":810650,"avatar_url":"https://avatars.githubusercontent.com/u/810650?v=3","gravatar_id":"","url":"https://api.github.com/users/teoljungberg","html_url":"https://github.com/teoljungberg","followers_url":"https://api.github.com/users/teoljungberg/followers","following_url":"https://api.github.com/users/teoljungberg/following{/other_user}","gists_url":"https://api.github.com/users/teoljungberg/gists{/gist_id}","starred_url":"https://api.github.com/users/teoljungberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teoljungberg/subscriptions","organizations_url":"https://api.github.com/users/teoljungberg/orgs","repos_url":"https://api.github.com/users/teoljungberg/repos","events_url":"https://api.github.com/users/teoljungberg/events{/privacy}","received_events_url":"https://api.github.com/users/teoljungberg/received_events","type":"User","site_admin":false},"body":"To decouple the different kinds of configuration options Hound supports,\r\nlet each linter decide on how the specific kind of configuration it\r\nneeds. Both in what format, how to parse it, and how to access it.\r\n\r\nChanges:\r\n\r\n- Add `HoundConfig` to be the object representation of `.hound.yml`.\r\n- Add `Config::LINTER` to represent the configuration for the specific `LINTER`.\r\n- Add generic `Config::Parser` class to have the logic encapsualted on\r\n  how to fetch and parse different files and file types.\r\n- Replace, and remove, `RepoConfig` with `HoundConfig` and/or\r\n  `Config::LINTER` (where applicable).\r\n-  Remove `NAME` constant from `Linter::*`   \r\n    `NAME` was used to set `Linter::Base#_linter_name`, which can be\r\n    determined by `Linter::Base#name` instead.\r\n\r\nhttps://trello.com/c/PoRwwKIw","created_at":"2015-10-06T14:45:43Z","updated_at":"2015-10-08T07:40:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6aa12453b0066e6a82130a344a2c8f6196ee0534","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/thoughtbot/hound/pulls/950/commits","review_comments_url":"https://api.github.com/repos/thoughtbot/hound/pulls/950/comments","review_comment_url":"https://api.github.com/repos/thoughtbot/hound/pulls/comments{/number}","comments_url":"https://api.github.com/repos/thoughtbot/hound/issues/950/comments","statuses_url":"https://api.github.com/repos/thoughtbot/hound/statuses/4f7b21478fa913e8f52a7784327743f82ac4b319","head":{"label":"thoughtbot:linters-have-configs","ref":"linters-have-configs","sha":"4f7b21478fa913e8f52a7784327743f82ac4b319","user":{"login":"thoughtbot","id":6183,"avatar_url":"https://avatars.githubusercontent.com/u/6183?v=3","gravatar_id":"","url":"https://api.github.com/users/thoughtbot","html_url":"https://github.com/thoughtbot","followers_url":"https://api.github.com/users/thoughtbot/followers","following_url":"https://api.github.com/users/thoughtbot/following{/other_user}","gists_url":"https://api.github.com/users/thoughtbot/gists{/gist_id}","starred_url":"https://api.github.com/users/thoughtbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thoughtbot/subscriptions","organizations_url":"https://api.github.com/users/thoughtbot/orgs","repos_url":"https://api.github.com/users/thoughtbot/repos","events_url":"https://api.github.com/users/thoughtbot/events{/privacy}","received_events_url":"https://api.github.com/users/thoughtbot/received_events","type":"Organization","site_admin":false},"repo":{"id":7411076,"name":"hound","full_name":"thoughtbot/hound","owner":{"login":"thoughtbot","id":6183,"avatar_url":"https://avatars.githubusercontent.com/u/6183?v=3","gravatar_id":"","url":"https://api.github.com/users/thoughtbot","html_url":"https://github.com/thoughtbot","followers_url":"https://api.github.com/users/thoughtbot/followers","following_url":"https://api.github.com/users/thoughtbot/following{/other_user}","gists_url":"https://api.github.com/users/thoughtbot/gists{/gist_id}","starred_url":"https://api.github.com/users/thoughtbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thoughtbot/subscriptions","organizations_url":"https://api.github.com/users/thoughtbot/orgs","repos_url":"https://api.github.com/users/thoughtbot/repos","events_url":"https://api.github.com/users/thoughtbot/events{/privacy}","received_events_url":"https://api.github.com/users/thoughtbot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/thoughtbot/hound","description":"Automated review for code style.","fork":false,"url":"https://api.github.com/repos/thoughtbot/hound","forks_url":"https://api.github.com/repos/thoughtbot/hound/forks","keys_url":"https://api.github.com/repos/thoughtbot/hound/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thoughtbot/hound/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thoughtbot/hound/teams","hooks_url":"https://api.github.com/repos/thoughtbot/hound/hooks","issue_events_url":"https://api.github.com/repos/thoughtbot/hound/issues/events{/number}","events_url":"https://api.github.com/repos/thoughtbot/hound/events","assignees_url":"https://api.github.com/repos/thoughtbot/hound/assignees{/user}","branches_url":"https://api.github.com/repos/thoughtbot/hound/branches{/branch}","tags_url":"https://api.github.com/repos/thoughtbot/hound/tags","blobs_url":"https://api.github.com/repos/thoughtbot/hound/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thoughtbot/hound/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thoughtbot/hound/git/refs{/sha}","trees_url":"https://api.github.com/repos/thoughtbot/hound/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thoughtbot/hound/statuses/{sha}","languages_url":"https://api.github.com/repos/thoughtbot/hound/languages","stargazers_url":"https://api.github.com/repos/thoughtbot/hound/stargazers","contributors_url":"https://api.github.com/repos/thoughtbot/hound/contributors","subscribers_url":"https://api.github.com/repos/thoughtbot/hound/subscribers","subscription_url":"https://api.github.com/repos/thoughtbot/hound/subscription","commits_url":"https://api.github.com/repos/thoughtbot/hound/commits{/sha}","git_commits_url":"https://api.github.com/repos/thoughtbot/hound/git/commits{/sha}","comments_url":"https://api.github.com/repos/thoughtbot/hound/comments{/number}","issue_comment_url":"https://api.github.com/repos/thoughtbot/hound/issues/comments{/number}","contents_url":"https://api.github.com/repos/thoughtbot/hound/contents/{+path}","compare_url":"https://api.github.com/repos/thoughtbot/hound/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thoughtbot/hound/merges","archive_url":"https://api.github.com/repos/thoughtbot/hound/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thoughtbot/hound/downloads","issues_url":"https://api.github.com/repos/thoughtbot/hound/issues{/number}","pulls_url":"https://api.github.com/repos/thoughtbot/hound/pulls{/number}","milestones_url":"https://api.github.com/repos/thoughtbot/hound/milestones{/number}","notifications_url":"https://api.github.com/repos/thoughtbot/hound/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thoughtbot/hound/labels{/name}","releases_url":"https://api.github.com/repos/thoughtbot/hound/releases{/id}","created_at":"2013-01-02T18:12:40Z","updated_at":"2015-10-06T15:40:53Z","pushed_at":"2015-10-07T14:24:01Z","git_url":"git://github.com/thoughtbot/hound.git","ssh_url":"git@github.com:thoughtbot/hound.git","clone_url":"https://github.com/thoughtbot/hound.git","svn_url":"https://github.com/thoughtbot/hound","homepage":"https://houndci.com","size":16228,"stargazers_count":1046,"watchers_count":1046,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":218,"mirror_url":null,"open_issues_count":22,"forks":218,"open_issues":22,"watchers":1046,"default_branch":"master"}},"base":{"label":"thoughtbot:master","ref":"master","sha":"f5c7ea3f4dea7063e6af3c11e86cfa7707764fcd","user":{"login":"thoughtbot","id":6183,"avatar_url":"https://avatars.githubusercontent.com/u/6183?v=3","gravatar_id":"","url":"https://api.github.com/users/thoughtbot","html_url":"https://github.com/thoughtbot","followers_url":"https://api.github.com/users/thoughtbot/followers","following_url":"https://api.github.com/users/thoughtbot/following{/other_user}","gists_url":"https://api.github.com/users/thoughtbot/gists{/gist_id}","starred_url":"https://api.github.com/users/thoughtbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thoughtbot/subscriptions","organizations_url":"https://api.github.com/users/thoughtbot/orgs","repos_url":"https://api.github.com/users/thoughtbot/repos","events_url":"https://api.github.com/users/thoughtbot/events{/privacy}","received_events_url":"https://api.github.com/users/thoughtbot/received_events","type":"Organization","site_admin":false},"repo":{"id":7411076,"name":"hound","full_name":"thoughtbot/hound","owner":{"login":"thoughtbot","id":6183,"avatar_url":"https://avatars.githubusercontent.com/u/6183?v=3","gravatar_id":"","url":"https://api.github.com/users/thoughtbot","html_url":"https://github.com/thoughtbot","followers_url":"https://api.github.com/users/thoughtbot/followers","following_url":"https://api.github.com/users/thoughtbot/following{/other_user}","gists_url":"https://api.github.com/users/thoughtbot/gists{/gist_id}","starred_url":"https://api.github.com/users/thoughtbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thoughtbot/subscriptions","organizations_url":"https://api.github.com/users/thoughtbot/orgs","repos_url":"https://api.github.com/users/thoughtbot/repos","events_url":"https://api.github.com/users/thoughtbot/events{/privacy}","received_events_url":"https://api.github.com/users/thoughtbot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/thoughtbot/hound","description":"Automated review for code style.","fork":false,"url":"https://api.github.com/repos/thoughtbot/hound","forks_url":"https://api.github.com/repos/thoughtbot/hound/forks","keys_url":"https://api.github.com/repos/thoughtbot/hound/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thoughtbot/hound/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thoughtbot/hound/teams","hooks_url":"https://api.github.com/repos/thoughtbot/hound/hooks","issue_events_url":"https://api.github.com/repos/thoughtbot/hound/issues/events{/number}","events_url":"https://api.github.com/repos/thoughtbot/hound/events","assignees_url":"https://api.github.com/repos/thoughtbot/hound/assignees{/user}","branches_url":"https://api.github.com/repos/thoughtbot/hound/branches{/branch}","tags_url":"https://api.github.com/repos/thoughtbot/hound/tags","blobs_url":"https://api.github.com/repos/thoughtbot/hound/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thoughtbot/hound/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thoughtbot/hound/git/refs{/sha}","trees_url":"https://api.github.com/repos/thoughtbot/hound/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thoughtbot/hound/statuses/{sha}","languages_url":"https://api.github.com/repos/thoughtbot/hound/languages","stargazers_url":"https://api.github.com/repos/thoughtbot/hound/stargazers","contributors_url":"https://api.github.com/repos/thoughtbot/hound/contributors","subscribers_url":"https://api.github.com/repos/thoughtbot/hound/subscribers","subscription_url":"https://api.github.com/repos/thoughtbot/hound/subscription","commits_url":"https://api.github.com/repos/thoughtbot/hound/commits{/sha}","git_commits_url":"https://api.github.com/repos/thoughtbot/hound/git/commits{/sha}","comments_url":"https://api.github.com/repos/thoughtbot/hound/comments{/number}","issue_comment_url":"https://api.github.com/repos/thoughtbot/hound/issues/comments{/number}","contents_url":"https://api.github.com/repos/thoughtbot/hound/contents/{+path}","compare_url":"https://api.github.com/repos/thoughtbot/hound/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thoughtbot/hound/merges","archive_url":"https://api.github.com/repos/thoughtbot/hound/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thoughtbot/hound/downloads","issues_url":"https://api.github.com/repos/thoughtbot/hound/issues{/number}","pulls_url":"https://api.github.com/repos/thoughtbot/hound/pulls{/number}","milestones_url":"https://api.github.com/repos/thoughtbot/hound/milestones{/number}","notifications_url":"https://api.github.com/repos/thoughtbot/hound/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thoughtbot/hound/labels{/name}","releases_url":"https://api.github.com/repos/thoughtbot/hound/releases{/id}","created_at":"2013-01-02T18:12:40Z","updated_at":"2015-10-06T15:40:53Z","pushed_at":"2015-10-07T14:24:01Z","git_url":"git://github.com/thoughtbot/hound.git","ssh_url":"git@github.com:thoughtbot/hound.git","clone_url":"https://github.com/thoughtbot/hound.git","svn_url":"https://github.com/thoughtbot/hound","homepage":"https://houndci.com","size":16228,"stargazers_count":1046,"watchers_count":1046,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":218,"mirror_url":null,"open_issues_count":22,"forks":218,"open_issues":22,"watchers":1046,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/thoughtbot/hound/pulls/950"},"html":{"href":"https://github.com/thoughtbot/hound/pull/950"},"issue":{"href":"https://api.github.com/repos/thoughtbot/hound/issues/950"},"comments":{"href":"https://api.github.com/repos/thoughtbot/hound/issues/950/comments"},"review_comments":{"href":"https://api.github.com/repos/thoughtbot/hound/pulls/950/comments"},"review_comment":{"href":"https://api.github.com/repos/thoughtbot/hound/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/thoughtbot/hound/pulls/950/commits"},"statuses":{"href":"https://api.github.com/repos/thoughtbot/hound/statuses/4f7b21478fa913e8f52a7784327743f82ac4b319"}}}}