{"action":"created","issue":{"url":"https://api.github.com/repos/mbj/unparser/issues/56","labels_url":"https://api.github.com/repos/mbj/unparser/issues/56/labels{/name}","comments_url":"https://api.github.com/repos/mbj/unparser/issues/56/comments","events_url":"https://api.github.com/repos/mbj/unparser/issues/56/events","html_url":"https://github.com/mbj/unparser/pull/56","id":116173077,"number":56,"title":"Don't use parentheses around operator expressions when it is obvious they aren't needed","user":{"login":"alexdowad","id":1067359,"avatar_url":"https://avatars.githubusercontent.com/u/1067359?v=3","gravatar_id":"","url":"https://api.github.com/users/alexdowad","html_url":"https://github.com/alexdowad","followers_url":"https://api.github.com/users/alexdowad/followers","following_url":"https://api.github.com/users/alexdowad/following{/other_user}","gists_url":"https://api.github.com/users/alexdowad/gists{/gist_id}","starred_url":"https://api.github.com/users/alexdowad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexdowad/subscriptions","organizations_url":"https://api.github.com/users/alexdowad/orgs","repos_url":"https://api.github.com/users/alexdowad/repos","events_url":"https://api.github.com/users/alexdowad/events{/privacy}","received_events_url":"https://api.github.com/users/alexdowad/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-11-10T18:37:16Z","updated_at":"2015-11-10T18:52:51Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mbj/unparser/pulls/56","html_url":"https://github.com/mbj/unparser/pull/56","diff_url":"https://github.com/mbj/unparser/pull/56.diff","patch_url":"https://github.com/mbj/unparser/pull/56.patch"},"body":"To do this, we have to take operator precedence and associativity into account,\r\nto make sure we don't change the meaning of an expression by omitting the parens.\r\nMore then that, we need to consider what precedence rules are \"obvious\" to an\r\naverage Ruby programmer. In many cases, parens are not strictly necessary,\r\nbut may make the meaning clearer.\r\n\r\nOn the other hand, if we *always* emit parens, the code becomes littered with\r\nparens which are obviously redundant, and that sucks.\r\n\r\n@mbj, I'm sure there may be better ways to implement some parts of this PR.\r\nPlease have a look and share any suggestions!"},"comment":{"url":"https://api.github.com/repos/mbj/unparser/issues/comments/155529670","html_url":"https://github.com/mbj/unparser/pull/56#issuecomment-155529670","issue_url":"https://api.github.com/repos/mbj/unparser/issues/56","id":155529670,"user":{"login":"mbj","id":117966,"avatar_url":"https://avatars.githubusercontent.com/u/117966?v=3","gravatar_id":"","url":"https://api.github.com/users/mbj","html_url":"https://github.com/mbj","followers_url":"https://api.github.com/users/mbj/followers","following_url":"https://api.github.com/users/mbj/following{/other_user}","gists_url":"https://api.github.com/users/mbj/gists{/gist_id}","starred_url":"https://api.github.com/users/mbj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbj/subscriptions","organizations_url":"https://api.github.com/users/mbj/orgs","repos_url":"https://api.github.com/users/mbj/repos","events_url":"https://api.github.com/users/mbj/events{/privacy}","received_events_url":"https://api.github.com/users/mbj/received_events","type":"User","site_admin":false},"created_at":"2015-11-10T18:52:50Z","updated_at":"2015-11-10T18:52:50Z","body":"@alexdowad I did a quick code style only pass, and will do a semantic one on my next OSS cycle. I like the idea of this change."}}