{"action":"closed","number":257,"pull_request":{"url":"https://api.github.com/repos/artefactual/atom/pulls/257","id":51594770,"html_url":"https://github.com/artefactual/atom/pull/257","diff_url":"https://github.com/artefactual/atom/pull/257.diff","patch_url":"https://github.com/artefactual/atom/pull/257.patch","issue_url":"https://api.github.com/repos/artefactual/atom/issues/257","number":257,"state":"closed","locked":false,"title":"Move LOD check to Criteria to improve efficiency","user":{"login":"MikeFE","id":6102546,"avatar_url":"https://avatars.githubusercontent.com/u/6102546?v=3","gravatar_id":"","url":"https://api.github.com/users/MikeFE","html_url":"https://github.com/MikeFE","followers_url":"https://api.github.com/users/MikeFE/followers","following_url":"https://api.github.com/users/MikeFE/following{/other_user}","gists_url":"https://api.github.com/users/MikeFE/gists{/gist_id}","starred_url":"https://api.github.com/users/MikeFE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikeFE/subscriptions","organizations_url":"https://api.github.com/users/MikeFE/orgs","repos_url":"https://api.github.com/users/MikeFE/repos","events_url":"https://api.github.com/users/MikeFE/events{/privacy}","received_events_url":"https://api.github.com/users/MikeFE/received_events","type":"User","site_admin":false},"body":"Since the \"File List Report\" is only checking information objects with a level of description of \"file\", we can safely move that LOD check to the Criteria of the query. \r\n\r\nPreviously, the Criteria was broad enough to include all item level descriptions as well if they were children of the Files. This created performance issues in certain circumstances (several files but having thousands of child, item level descriptions).\r\n\r\nWe'll want to move these reports to use the job scheduler and combine the duplicate code between the item/list action files in the future.\r\n(see: ./apps/qubit/modules/informationobject/actions/fileListAction.class.php vs. ./apps/qubit/modules/informationobject/actions/itemListAction.class.php)","created_at":"2015-11-23T23:12:33Z","updated_at":"2015-11-25T19:03:25Z","closed_at":"2015-11-25T19:03:25Z","merged_at":null,"merge_commit_sha":"0f81b54b103d61efc9707f1532c305cfe8ca09f5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/artefactual/atom/pulls/257/commits","review_comments_url":"https://api.github.com/repos/artefactual/atom/pulls/257/comments","review_comment_url":"https://api.github.com/repos/artefactual/atom/pulls/comments{/number}","comments_url":"https://api.github.com/repos/artefactual/atom/issues/257/comments","statuses_url":"https://api.github.com/repos/artefactual/atom/statuses/520ae7554e1bdb5a04ec754a59af9b6e3d453536","head":{"label":"artefactual:dev/issue-9138-file-report-timeout","ref":"dev/issue-9138-file-report-timeout","sha":"520ae7554e1bdb5a04ec754a59af9b6e3d453536","user":{"login":"artefactual","id":1163545,"avatar_url":"https://avatars.githubusercontent.com/u/1163545?v=3","gravatar_id":"","url":"https://api.github.com/users/artefactual","html_url":"https://github.com/artefactual","followers_url":"https://api.github.com/users/artefactual/followers","following_url":"https://api.github.com/users/artefactual/following{/other_user}","gists_url":"https://api.github.com/users/artefactual/gists{/gist_id}","starred_url":"https://api.github.com/users/artefactual/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artefactual/subscriptions","organizations_url":"https://api.github.com/users/artefactual/orgs","repos_url":"https://api.github.com/users/artefactual/repos","events_url":"https://api.github.com/users/artefactual/events{/privacy}","received_events_url":"https://api.github.com/users/artefactual/received_events","type":"Organization","site_admin":false},"repo":{"id":5705943,"name":"atom","full_name":"artefactual/atom","owner":{"login":"artefactual","id":1163545,"avatar_url":"https://avatars.githubusercontent.com/u/1163545?v=3","gravatar_id":"","url":"https://api.github.com/users/artefactual","html_url":"https://github.com/artefactual","followers_url":"https://api.github.com/users/artefactual/followers","following_url":"https://api.github.com/users/artefactual/following{/other_user}","gists_url":"https://api.github.com/users/artefactual/gists{/gist_id}","starred_url":"https://api.github.com/users/artefactual/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artefactual/subscriptions","organizations_url":"https://api.github.com/users/artefactual/orgs","repos_url":"https://api.github.com/users/artefactual/repos","events_url":"https://api.github.com/users/artefactual/events{/privacy}","received_events_url":"https://api.github.com/users/artefactual/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/artefactual/atom","description":"Open-source, web application for archival description and public access.","fork":false,"url":"https://api.github.com/repos/artefactual/atom","forks_url":"https://api.github.com/repos/artefactual/atom/forks","keys_url":"https://api.github.com/repos/artefactual/atom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/artefactual/atom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/artefactual/atom/teams","hooks_url":"https://api.github.com/repos/artefactual/atom/hooks","issue_events_url":"https://api.github.com/repos/artefactual/atom/issues/events{/number}","events_url":"https://api.github.com/repos/artefactual/atom/events","assignees_url":"https://api.github.com/repos/artefactual/atom/assignees{/user}","branches_url":"https://api.github.com/repos/artefactual/atom/branches{/branch}","tags_url":"https://api.github.com/repos/artefactual/atom/tags","blobs_url":"https://api.github.com/repos/artefactual/atom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/artefactual/atom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/artefactual/atom/git/refs{/sha}","trees_url":"https://api.github.com/repos/artefactual/atom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/artefactual/atom/statuses/{sha}","languages_url":"https://api.github.com/repos/artefactual/atom/languages","stargazers_url":"https://api.github.com/repos/artefactual/atom/stargazers","contributors_url":"https://api.github.com/repos/artefactual/atom/contributors","subscribers_url":"https://api.github.com/repos/artefactual/atom/subscribers","subscription_url":"https://api.github.com/repos/artefactual/atom/subscription","commits_url":"https://api.github.com/repos/artefactual/atom/commits{/sha}","git_commits_url":"https://api.github.com/repos/artefactual/atom/git/commits{/sha}","comments_url":"https://api.github.com/repos/artefactual/atom/comments{/number}","issue_comment_url":"https://api.github.com/repos/artefactual/atom/issues/comments{/number}","contents_url":"https://api.github.com/repos/artefactual/atom/contents/{+path}","compare_url":"https://api.github.com/repos/artefactual/atom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/artefactual/atom/merges","archive_url":"https://api.github.com/repos/artefactual/atom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/artefactual/atom/downloads","issues_url":"https://api.github.com/repos/artefactual/atom/issues{/number}","pulls_url":"https://api.github.com/repos/artefactual/atom/pulls{/number}","milestones_url":"https://api.github.com/repos/artefactual/atom/milestones{/number}","notifications_url":"https://api.github.com/repos/artefactual/atom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/artefactual/atom/labels{/name}","releases_url":"https://api.github.com/repos/artefactual/atom/releases{/id}","created_at":"2012-09-06T17:35:28Z","updated_at":"2015-11-04T20:56:38Z","pushed_at":"2015-11-25T19:03:25Z","git_url":"git://github.com/artefactual/atom.git","ssh_url":"git@github.com:artefactual/atom.git","clone_url":"https://github.com/artefactual/atom.git","svn_url":"https://github.com/artefactual/atom","homepage":"http://www.accesstomemory.org","size":38157,"stargazers_count":39,"watchers_count":39,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":38,"mirror_url":null,"open_issues_count":5,"forks":38,"open_issues":5,"watchers":39,"default_branch":"qa/2.3.x"}},"base":{"label":"artefactual:qa/2.3.x","ref":"qa/2.3.x","sha":"6aebb7a5825349124ed642d59d453dabdefdfea1","user":{"login":"artefactual","id":1163545,"avatar_url":"https://avatars.githubusercontent.com/u/1163545?v=3","gravatar_id":"","url":"https://api.github.com/users/artefactual","html_url":"https://github.com/artefactual","followers_url":"https://api.github.com/users/artefactual/followers","following_url":"https://api.github.com/users/artefactual/following{/other_user}","gists_url":"https://api.github.com/users/artefactual/gists{/gist_id}","starred_url":"https://api.github.com/users/artefactual/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artefactual/subscriptions","organizations_url":"https://api.github.com/users/artefactual/orgs","repos_url":"https://api.github.com/users/artefactual/repos","events_url":"https://api.github.com/users/artefactual/events{/privacy}","received_events_url":"https://api.github.com/users/artefactual/received_events","type":"Organization","site_admin":false},"repo":{"id":5705943,"name":"atom","full_name":"artefactual/atom","owner":{"login":"artefactual","id":1163545,"avatar_url":"https://avatars.githubusercontent.com/u/1163545?v=3","gravatar_id":"","url":"https://api.github.com/users/artefactual","html_url":"https://github.com/artefactual","followers_url":"https://api.github.com/users/artefactual/followers","following_url":"https://api.github.com/users/artefactual/following{/other_user}","gists_url":"https://api.github.com/users/artefactual/gists{/gist_id}","starred_url":"https://api.github.com/users/artefactual/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artefactual/subscriptions","organizations_url":"https://api.github.com/users/artefactual/orgs","repos_url":"https://api.github.com/users/artefactual/repos","events_url":"https://api.github.com/users/artefactual/events{/privacy}","received_events_url":"https://api.github.com/users/artefactual/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/artefactual/atom","description":"Open-source, web application for archival description and public access.","fork":false,"url":"https://api.github.com/repos/artefactual/atom","forks_url":"https://api.github.com/repos/artefactual/atom/forks","keys_url":"https://api.github.com/repos/artefactual/atom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/artefactual/atom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/artefactual/atom/teams","hooks_url":"https://api.github.com/repos/artefactual/atom/hooks","issue_events_url":"https://api.github.com/repos/artefactual/atom/issues/events{/number}","events_url":"https://api.github.com/repos/artefactual/atom/events","assignees_url":"https://api.github.com/repos/artefactual/atom/assignees{/user}","branches_url":"https://api.github.com/repos/artefactual/atom/branches{/branch}","tags_url":"https://api.github.com/repos/artefactual/atom/tags","blobs_url":"https://api.github.com/repos/artefactual/atom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/artefactual/atom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/artefactual/atom/git/refs{/sha}","trees_url":"https://api.github.com/repos/artefactual/atom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/artefactual/atom/statuses/{sha}","languages_url":"https://api.github.com/repos/artefactual/atom/languages","stargazers_url":"https://api.github.com/repos/artefactual/atom/stargazers","contributors_url":"https://api.github.com/repos/artefactual/atom/contributors","subscribers_url":"https://api.github.com/repos/artefactual/atom/subscribers","subscription_url":"https://api.github.com/repos/artefactual/atom/subscription","commits_url":"https://api.github.com/repos/artefactual/atom/commits{/sha}","git_commits_url":"https://api.github.com/repos/artefactual/atom/git/commits{/sha}","comments_url":"https://api.github.com/repos/artefactual/atom/comments{/number}","issue_comment_url":"https://api.github.com/repos/artefactual/atom/issues/comments{/number}","contents_url":"https://api.github.com/repos/artefactual/atom/contents/{+path}","compare_url":"https://api.github.com/repos/artefactual/atom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/artefactual/atom/merges","archive_url":"https://api.github.com/repos/artefactual/atom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/artefactual/atom/downloads","issues_url":"https://api.github.com/repos/artefactual/atom/issues{/number}","pulls_url":"https://api.github.com/repos/artefactual/atom/pulls{/number}","milestones_url":"https://api.github.com/repos/artefactual/atom/milestones{/number}","notifications_url":"https://api.github.com/repos/artefactual/atom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/artefactual/atom/labels{/name}","releases_url":"https://api.github.com/repos/artefactual/atom/releases{/id}","created_at":"2012-09-06T17:35:28Z","updated_at":"2015-11-04T20:56:38Z","pushed_at":"2015-11-25T19:03:25Z","git_url":"git://github.com/artefactual/atom.git","ssh_url":"git@github.com:artefactual/atom.git","clone_url":"https://github.com/artefactual/atom.git","svn_url":"https://github.com/artefactual/atom","homepage":"http://www.accesstomemory.org","size":38157,"stargazers_count":39,"watchers_count":39,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":38,"mirror_url":null,"open_issues_count":5,"forks":38,"open_issues":5,"watchers":39,"default_branch":"qa/2.3.x"}},"_links":{"self":{"href":"https://api.github.com/repos/artefactual/atom/pulls/257"},"html":{"href":"https://github.com/artefactual/atom/pull/257"},"issue":{"href":"https://api.github.com/repos/artefactual/atom/issues/257"},"comments":{"href":"https://api.github.com/repos/artefactual/atom/issues/257/comments"},"review_comments":{"href":"https://api.github.com/repos/artefactual/atom/pulls/257/comments"},"review_comment":{"href":"https://api.github.com/repos/artefactual/atom/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/artefactual/atom/pulls/257/commits"},"statuses":{"href":"https://api.github.com/repos/artefactual/atom/statuses/520ae7554e1bdb5a04ec754a59af9b6e3d453536"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":16,"deletions":18,"changed_files":1}}