{"action":"closed","number":1780,"pull_request":{"url":"https://api.github.com/repos/SUSE/machinery/pulls/1780","id":54258275,"html_url":"https://github.com/SUSE/machinery/pull/1780","diff_url":"https://github.com/SUSE/machinery/pull/1780.diff","patch_url":"https://github.com/SUSE/machinery/pull/1780.patch","issue_url":"https://api.github.com/repos/SUSE/machinery/issues/1780","number":1780,"state":"closed","locked":false,"title":"[Review] Request from 'greygoo' @ 'SUSE/machinery/ubuntu_inspection'","user":{"login":"greygoo","id":1080430,"avatar_url":"https://avatars.githubusercontent.com/u/1080430?v=3","gravatar_id":"","url":"https://api.github.com/users/greygoo","html_url":"https://github.com/greygoo","followers_url":"https://api.github.com/users/greygoo/followers","following_url":"https://api.github.com/users/greygoo/following{/other_user}","gists_url":"https://api.github.com/users/greygoo/gists{/gist_id}","starred_url":"https://api.github.com/users/greygoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greygoo/subscriptions","organizations_url":"https://api.github.com/users/greygoo/orgs","repos_url":"https://api.github.com/users/greygoo/repos","events_url":"https://api.github.com/users/greygoo/events{/privacy}","received_events_url":"https://api.github.com/users/greygoo/received_events","type":"User","site_admin":false},"body":"Please review the following changes:\n  * 0cd5593 Add additional summary message for ubuntu systems lacking tasksel\n  * 17136b8 Refactor class attributes so that they are always initialized\n  * 79fa63e Add support for conditional element classes in Machinery::Array\n  * 1fab33b Remove dead code, it was never executed\n  * a6ada6a Merge pull request #1773 from SUSE/fix_ubuntu_integration_tests\n  * 84bdec7 Fix Ubuntu integration test: changed-managed-files\n  * 08aa41f Fix Ubuntu integration test: config-files\n  * 88a27ef Fix Ubuntu integration test: packages\n  * 472fca4 Fix Ubuntu integration test: groups\n  * e84dc32 Fix Ubuntu integration test: users\n  * 4211b03 Merge pull request #1754 from SUSE/ubuntu_pattern_inspection_2\n  * 2cc5207 Remove trailing whitespaces\n  * 8b22612 adjust indentation according to hound issues\n  * 3409e4a Regroup patterns inspection tests into tasksel and zypper based context\n  * 2edf2d2 Merge pull request #1770 from SUSE/review_151217_enable_provision_script_for_ubuntu_image\n  * 631e580 Add back missing tarball extraction step\n  * d256b81 Split up provision script into a RPM and a DPKG one\n  * 40cce35 Add test package for Ubuntu/Debian machines\n  * e032a62 Merge pull request #1767 from SUSE/fix_ubuntu_inspection_validate_expectation\n  * f3b2fd1 Adapt validation integration test to new schema\n  * 2356d82 Merge pull request #1765 from SUSE/ubuntu_managed_files_integration_tests5\n  * 62eec1a Improved example for run_*_with_progress()\n  * 141927e Improved to reduce redundancy in run_*_with_progress()\n  * 198b1dd Add integration tests for Ubuntu\n  * df564b8 Merge pull request #1761 from SUSE/supported_systems_changes_2\n  * 9a14c48 Introduce a ConfigBase#deprecated?(key) method\n  * 9886b9f Remove the arch check from validate_build_compatibility\n  * cc64ea5 Reorder validation on build task\n  * aaa7b8b Review fixes for kiwi config\n  * bbb6ad5 Validate that zypper is installed before checking compatibility\n  * 04e520b Add notion of deprecated config entries\n  * f33cec6 Remove export validation and do it on build command\n  * 9caa138 Calculate kiwi boot name for suse distros\n  * f7fcedc Allow for suse os models\n  * 699f84c Change the analyze command validation to be based on the zypper version\n  * 1ad8306 Move kiwi boot data to the os model\n  * 5d015ee Remove config options perform_support_check\n  * c124f01 Modify Cli.buildable_distributions\n  * 51c0ef8 By default OSes can run machinery\n  * b680c94 Remove the support statement in the README\n  * cab7f21 Remove LocalSystem#validate_machinery_compatibility\n  * 6419637 Reuse instance of Machinery::Config throughout the Cli class\n  * 1572b9b Merge branch 'doc-html-overview'\n  * 395a716 Fix typo in `serve` man page\n  * 8e14f5f Remove obsolete `serve` parameter from cli tests\n  * af04822 Remove obsolete parameter from tests for `serve`\n  * 45f154d Improve help for `--html` option of `list` command\n  * 44eee22 Add `--html` option of `list` command to man page\n  * c0af2ee Remove obsolete parameter from serve command\n  * 9150222 Detect deleted files as deleted, although dpkg reports md5sum changes\n  * f5a7f1e Add run_command_with_progress and adapt dpkg call to make use of it\n  * dcb9546 Remove commented lines and shorten description of a test\n  * 853da30 Add expected data for the patterns inspection integration test on ubuntu\n  * 50d2cba Modify patterns schema to allow patterns without version and release number\n  * c9e36c4 Add patterns inspector for ubuntu 14.04\n  * f9c782c Add unit test for ubuntu patterns inspector.\n  * 00f1d1c Merge pull request #1752 from SUSE/ubuntu_service_inspector_sysv\n  * e801508 Add an additional field to upstart services (legacy sysv flag)\n  * 1badcf8 Merge pull request #1739 from SUSE/issue_1674_3\n  * 2a74a8f Make test a little bit more robust\n  * a34a1fa Improve test name to make it sound more natural\n  * 745cb11 Merge pull request #1750 from SUSE/add_additional_yump_repo_attributes\n  * 53f811a Merge pull request #1743 from SUSE/ubuntu_inspection_with_repos_html\n  * 0c886a1 Improve description of repository migration spec\n  * 66553e5 Use equal or for Python Yum inspector\n  * b08e117 Adapt repository renderer to new relevant Yum attributes\n  * c8f6fac Extend yum repositories format with missing options\n  * c588239 Add sublist option to renderer \"list\" method\n  * 1d1d328 Merge pull request #1746 from SUSE/review_151204_implement_packages_instection_for_ubuntu\n  * fec7bac Add a non-installed package to the test data\n  * e2e19ee Incorporate suggestions from review\n  * 7aabc82 Make sure that apt-cache is available when inspecting dpkg base systems\n  * e51da1e Implement ubuntu packages inspection\n  * 18353bf Extend service inspector to also inspect sysv services not handled by upstart\n  * 74af258 Update expected data for integration test to include legacy systemV services\n  * 3b38b05 Unit test for inspecting all services on ubuntu, sysv and upstart\n  * f2cef91 Merge pull request #1741 from SUSE/ubuntu_inspection_with_repos2\n  * d19cc71 Change html repositories rendering to be done with partials\n  * d84c309 Add repository comparison for yum and apt types\n  * 53bab3a Merge remote-tracking branch 'origin/html_overview_3'\n  * 3e2b73a Move html cell conversion to server.rb\n  * 1ddfb60 Fix validation error message for repositories\n  * 336f54c Adapt upgrade repositories output expectation\n  * 8772e33 Fix validation-error manifest\n  * 5fb4a66 Fix test\n  * 23f9c3d Fix components part of the repository scope in factory\n  * 901f345 Change repositories show view to change depending on repo type\n  * b1fcf7f Adapt integration test data to new repository renderer\n  * 7756b49 Fix integration test\n  * 4cd474e Fix unmanaged files inspector\n  * 4f333a2 Adapt machinery matchers to changed data model\n  * 2f2aaad Adapt FilterOptionParser to the changed data model\n  * c469133 Use unless instead of \"if !\" in repositories renderer\n  * 6d26c1f Fix unit tests\n  * 5cbe99f Show \"N/A\" for unknown repository types\n  * f296b24 Remove Package Manager entry from repositories renderer\n  * e85421f Fix hound issues\n  * 3daa1ea Migrate fixture descriptions\n  * aac2670 Fix users array in the groups scope schema\n  * 3e1c74c Fix integration tests\n  * 8e2d0f1 Make Hound happy\n  * 9e43fb0 Fix Machinery::Array empty? method\n  * c2c368c Adapt repositories of descriptions to v6\n  * 3d285d6 Show repository type in renderer\n  * 4f19f30 Adapt repositories renderer to new repositories\n  * fb564a4 Add apt repository inspection\n  * 2d023f0 Adapt repositories inspector to new format v6\n  * 5a25928 Adapt repository model to v6\n  * 5721585 Convert Factory repositories to v6 and add apt repos\n  * 79a3f66 Remove package_manager attribute from yum Python script\n  * 485e9e1 Update openSUSE Leap build description repositories to v6\n  * cc89825 Update repository schema for v6\n  * ebe0e20 Changelog: Remove `show` hint for `inspect-container` when...\n  * ba098b7 Remove `show` hint when `--show` is used for `inspect-container`\n  * 1e9fd0e Merge pull request #1736 from SUSE/ubuntu_inspection_detect_deleted_files4\n  * d43e120 Detect deleted files as deleted, although dpkg reports md5sum changes\n  * 80d799c Fix Hound issue\n  * 4a286ff Fix test\n  * c738c3f Add landing page\n  * 00c62f6 Set up v6 migration for repositories\n  * a09aaf1 Merge pull request #1726 from SUSE/inspect_config_files_ubuntu5\n  * 4b29dd4 Enable inspection of config-files for Ubuntu hosts\n  * 5ebf83d Activate repository integration tests\n  * a6c2ad9 Merge pull request #1723 from SUSE/review_151126_adapt_packages_data_model4\n  * 079e3c1 Improve check for existance of comparison data (unamanaged files)\n  * 8a3d7e9 Improve check for existance of comparison data\n  * 8f53af6 Adapt comparison views to new data model\n  * 620de1e Fix test\n  * 20f1f37 Fix hound issues\n  * ed7a6de Adapt existing code in the branch to the new data model\n  * 5ac9e73 Migrate fixture descriptions\n  * d44eaa3 Adapt users, groups and patterns scopes to new data model\n  * 0308c9d Fix test\n  * 9744402 Adapt default filters to new data model\n  * 2c2761f Migrate fixture descriptions\n  * c55b6bd Adapt the services scope to the new array data model\n  * a942c8f Merge pull request #1722 from SUSE/review_151126_adapt_packages_data_model3\n  * 0b2178d Merge pull request #1721 from SUSE/revert-1720-review_151126_adapt_packages_data_model3\n  * 498001e Revert \"[Review] Request from 'aduffeck' @ 'SUSE/machinery/review_151126_adapt_packages_data_model3'\"\n  * d55f0ca Merge pull request #1720 from SUSE/review_151126_adapt_packages_data_model3\n  * 534edbd Merge pull request #1719 from SUSE/fix_log_test\n  * cbc31a5 Make the machinery log test more robust\n  * b9cc076 Merge pull request #1711 from SUSE/services_scope_for_ubuntu_systems\n  * a4fb6e5 Add integration test for ubuntu service inspection\n  * 2c648b3 Add ubuntu services inspector\n  * aa65493 Add unit test for ubuntu services inspector","created_at":"2015-12-21T13:52:20Z","updated_at":"2015-12-21T13:59:20Z","closed_at":"2015-12-21T13:59:20Z","merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/SUSE/machinery/pulls/1780/commits","review_comments_url":"https://api.github.com/repos/SUSE/machinery/pulls/1780/comments","review_comment_url":"https://api.github.com/repos/SUSE/machinery/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SUSE/machinery/issues/1780/comments","statuses_url":"https://api.github.com/repos/SUSE/machinery/statuses/13844308a04dd08d504bbe5c028c1b6628502ceb","head":{"label":"SUSE:ubuntu_inspection","ref":"ubuntu_inspection","sha":"13844308a04dd08d504bbe5c028c1b6628502ceb","user":{"login":"SUSE","id":1067733,"avatar_url":"https://avatars.githubusercontent.com/u/1067733?v=3","gravatar_id":"","url":"https://api.github.com/users/SUSE","html_url":"https://github.com/SUSE","followers_url":"https://api.github.com/users/SUSE/followers","following_url":"https://api.github.com/users/SUSE/following{/other_user}","gists_url":"https://api.github.com/users/SUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/SUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUSE/subscriptions","organizations_url":"https://api.github.com/users/SUSE/orgs","repos_url":"https://api.github.com/users/SUSE/repos","events_url":"https://api.github.com/users/SUSE/events{/privacy}","received_events_url":"https://api.github.com/users/SUSE/received_events","type":"Organization","site_admin":false},"repo":{"id":21424418,"name":"machinery","full_name":"SUSE/machinery","owner":{"login":"SUSE","id":1067733,"avatar_url":"https://avatars.githubusercontent.com/u/1067733?v=3","gravatar_id":"","url":"https://api.github.com/users/SUSE","html_url":"https://github.com/SUSE","followers_url":"https://api.github.com/users/SUSE/followers","following_url":"https://api.github.com/users/SUSE/following{/other_user}","gists_url":"https://api.github.com/users/SUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/SUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUSE/subscriptions","organizations_url":"https://api.github.com/users/SUSE/orgs","repos_url":"https://api.github.com/users/SUSE/repos","events_url":"https://api.github.com/users/SUSE/events{/privacy}","received_events_url":"https://api.github.com/users/SUSE/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SUSE/machinery","description":"A systems management toolkit for Linux","fork":false,"url":"https://api.github.com/repos/SUSE/machinery","forks_url":"https://api.github.com/repos/SUSE/machinery/forks","keys_url":"https://api.github.com/repos/SUSE/machinery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SUSE/machinery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SUSE/machinery/teams","hooks_url":"https://api.github.com/repos/SUSE/machinery/hooks","issue_events_url":"https://api.github.com/repos/SUSE/machinery/issues/events{/number}","events_url":"https://api.github.com/repos/SUSE/machinery/events","assignees_url":"https://api.github.com/repos/SUSE/machinery/assignees{/user}","branches_url":"https://api.github.com/repos/SUSE/machinery/branches{/branch}","tags_url":"https://api.github.com/repos/SUSE/machinery/tags","blobs_url":"https://api.github.com/repos/SUSE/machinery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SUSE/machinery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SUSE/machinery/git/refs{/sha}","trees_url":"https://api.github.com/repos/SUSE/machinery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SUSE/machinery/statuses/{sha}","languages_url":"https://api.github.com/repos/SUSE/machinery/languages","stargazers_url":"https://api.github.com/repos/SUSE/machinery/stargazers","contributors_url":"https://api.github.com/repos/SUSE/machinery/contributors","subscribers_url":"https://api.github.com/repos/SUSE/machinery/subscribers","subscription_url":"https://api.github.com/repos/SUSE/machinery/subscription","commits_url":"https://api.github.com/repos/SUSE/machinery/commits{/sha}","git_commits_url":"https://api.github.com/repos/SUSE/machinery/git/commits{/sha}","comments_url":"https://api.github.com/repos/SUSE/machinery/comments{/number}","issue_comment_url":"https://api.github.com/repos/SUSE/machinery/issues/comments{/number}","contents_url":"https://api.github.com/repos/SUSE/machinery/contents/{+path}","compare_url":"https://api.github.com/repos/SUSE/machinery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SUSE/machinery/merges","archive_url":"https://api.github.com/repos/SUSE/machinery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SUSE/machinery/downloads","issues_url":"https://api.github.com/repos/SUSE/machinery/issues{/number}","pulls_url":"https://api.github.com/repos/SUSE/machinery/pulls{/number}","milestones_url":"https://api.github.com/repos/SUSE/machinery/milestones{/number}","notifications_url":"https://api.github.com/repos/SUSE/machinery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SUSE/machinery/labels{/name}","releases_url":"https://api.github.com/repos/SUSE/machinery/releases{/id}","created_at":"2014-07-02T13:07:04Z","updated_at":"2015-12-16T10:55:34Z","pushed_at":"2015-12-21T13:57:08Z","git_url":"git://github.com/SUSE/machinery.git","ssh_url":"git@github.com:SUSE/machinery.git","clone_url":"https://github.com/SUSE/machinery.git","svn_url":"https://github.com/SUSE/machinery","homepage":"machinery-project.org","size":60973,"stargazers_count":81,"watchers_count":81,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":15,"mirror_url":null,"open_issues_count":52,"forks":15,"open_issues":52,"watchers":81,"default_branch":"master"}},"base":{"label":"SUSE:master","ref":"master","sha":"0041b31fe1f90dd6a7f4a58d5ee24dba3687fb89","user":{"login":"SUSE","id":1067733,"avatar_url":"https://avatars.githubusercontent.com/u/1067733?v=3","gravatar_id":"","url":"https://api.github.com/users/SUSE","html_url":"https://github.com/SUSE","followers_url":"https://api.github.com/users/SUSE/followers","following_url":"https://api.github.com/users/SUSE/following{/other_user}","gists_url":"https://api.github.com/users/SUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/SUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUSE/subscriptions","organizations_url":"https://api.github.com/users/SUSE/orgs","repos_url":"https://api.github.com/users/SUSE/repos","events_url":"https://api.github.com/users/SUSE/events{/privacy}","received_events_url":"https://api.github.com/users/SUSE/received_events","type":"Organization","site_admin":false},"repo":{"id":21424418,"name":"machinery","full_name":"SUSE/machinery","owner":{"login":"SUSE","id":1067733,"avatar_url":"https://avatars.githubusercontent.com/u/1067733?v=3","gravatar_id":"","url":"https://api.github.com/users/SUSE","html_url":"https://github.com/SUSE","followers_url":"https://api.github.com/users/SUSE/followers","following_url":"https://api.github.com/users/SUSE/following{/other_user}","gists_url":"https://api.github.com/users/SUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/SUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUSE/subscriptions","organizations_url":"https://api.github.com/users/SUSE/orgs","repos_url":"https://api.github.com/users/SUSE/repos","events_url":"https://api.github.com/users/SUSE/events{/privacy}","received_events_url":"https://api.github.com/users/SUSE/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SUSE/machinery","description":"A systems management toolkit for Linux","fork":false,"url":"https://api.github.com/repos/SUSE/machinery","forks_url":"https://api.github.com/repos/SUSE/machinery/forks","keys_url":"https://api.github.com/repos/SUSE/machinery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SUSE/machinery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SUSE/machinery/teams","hooks_url":"https://api.github.com/repos/SUSE/machinery/hooks","issue_events_url":"https://api.github.com/repos/SUSE/machinery/issues/events{/number}","events_url":"https://api.github.com/repos/SUSE/machinery/events","assignees_url":"https://api.github.com/repos/SUSE/machinery/assignees{/user}","branches_url":"https://api.github.com/repos/SUSE/machinery/branches{/branch}","tags_url":"https://api.github.com/repos/SUSE/machinery/tags","blobs_url":"https://api.github.com/repos/SUSE/machinery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SUSE/machinery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SUSE/machinery/git/refs{/sha}","trees_url":"https://api.github.com/repos/SUSE/machinery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SUSE/machinery/statuses/{sha}","languages_url":"https://api.github.com/repos/SUSE/machinery/languages","stargazers_url":"https://api.github.com/repos/SUSE/machinery/stargazers","contributors_url":"https://api.github.com/repos/SUSE/machinery/contributors","subscribers_url":"https://api.github.com/repos/SUSE/machinery/subscribers","subscription_url":"https://api.github.com/repos/SUSE/machinery/subscription","commits_url":"https://api.github.com/repos/SUSE/machinery/commits{/sha}","git_commits_url":"https://api.github.com/repos/SUSE/machinery/git/commits{/sha}","comments_url":"https://api.github.com/repos/SUSE/machinery/comments{/number}","issue_comment_url":"https://api.github.com/repos/SUSE/machinery/issues/comments{/number}","contents_url":"https://api.github.com/repos/SUSE/machinery/contents/{+path}","compare_url":"https://api.github.com/repos/SUSE/machinery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SUSE/machinery/merges","archive_url":"https://api.github.com/repos/SUSE/machinery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SUSE/machinery/downloads","issues_url":"https://api.github.com/repos/SUSE/machinery/issues{/number}","pulls_url":"https://api.github.com/repos/SUSE/machinery/pulls{/number}","milestones_url":"https://api.github.com/repos/SUSE/machinery/milestones{/number}","notifications_url":"https://api.github.com/repos/SUSE/machinery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SUSE/machinery/labels{/name}","releases_url":"https://api.github.com/repos/SUSE/machinery/releases{/id}","created_at":"2014-07-02T13:07:04Z","updated_at":"2015-12-16T10:55:34Z","pushed_at":"2015-12-21T13:57:08Z","git_url":"git://github.com/SUSE/machinery.git","ssh_url":"git@github.com:SUSE/machinery.git","clone_url":"https://github.com/SUSE/machinery.git","svn_url":"https://github.com/SUSE/machinery","homepage":"machinery-project.org","size":60973,"stargazers_count":81,"watchers_count":81,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":15,"mirror_url":null,"open_issues_count":52,"forks":15,"open_issues":52,"watchers":81,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SUSE/machinery/pulls/1780"},"html":{"href":"https://github.com/SUSE/machinery/pull/1780"},"issue":{"href":"https://api.github.com/repos/SUSE/machinery/issues/1780"},"comments":{"href":"https://api.github.com/repos/SUSE/machinery/issues/1780/comments"},"review_comments":{"href":"https://api.github.com/repos/SUSE/machinery/pulls/1780/comments"},"review_comment":{"href":"https://api.github.com/repos/SUSE/machinery/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SUSE/machinery/pulls/1780/commits"},"statuses":{"href":"https://api.github.com/repos/SUSE/machinery/statuses/13844308a04dd08d504bbe5c028c1b6628502ceb"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":0,"review_comments":16,"commits":109,"additions":5654,"deletions":2585,"changed_files":114}}