{"action":"created","issue":{"url":"https://api.github.com/repos/FINRAOS/MSL/issues/68","labels_url":"https://api.github.com/repos/FINRAOS/MSL/issues/68/labels{/name}","comments_url":"https://api.github.com/repos/FINRAOS/MSL/issues/68/comments","events_url":"https://api.github.com/repos/FINRAOS/MSL/issues/68/events","html_url":"https://github.com/FINRAOS/MSL/pull/68","id":54387489,"number":68,"title":"Escape quotes in eval(), unit tests, and others","user":{"login":"seoj","id":10010046,"avatar_url":"https://avatars.githubusercontent.com/u/10010046?v=3","gravatar_id":"","url":"https://api.github.com/users/seoj","html_url":"https://github.com/seoj","followers_url":"https://api.github.com/users/seoj/followers","following_url":"https://api.github.com/users/seoj/following{/other_user}","gists_url":"https://api.github.com/users/seoj/gists{/gist_id}","starred_url":"https://api.github.com/users/seoj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seoj/subscriptions","organizations_url":"https://api.github.com/users/seoj/orgs","repos_url":"https://api.github.com/users/seoj/repos","events_url":"https://api.github.com/users/seoj/events{/privacy}","received_events_url":"https://api.github.com/users/seoj/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-01-14T22:39:50Z","updated_at":"2015-01-15T17:27:28Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/FINRAOS/MSL/pulls/68","html_url":"https://github.com/FINRAOS/MSL/pull/68","diff_url":"https://github.com/FINRAOS/MSL/pull/68.diff","patch_url":"https://github.com/FINRAOS/MSL/pull/68.patch"},"body":"Added new function escapeString() in /msl-client-browser/appcontainer-driver.js and modified all calls to eval() to escape the string before concatenating into expression.\r\n\r\nAdded new karma test under /msl-client-browser/ to unit test this new functionality, along with a readme to explain how to run the unit test.\r\n\r\nAlso changed /msl-client-browser/package.json where the property \"repositories\" should have been \"repository.\" This was causing warning messages when npm install was run."},"comment":{"url":"https://api.github.com/repos/FINRAOS/MSL/issues/comments/70125096","html_url":"https://github.com/FINRAOS/MSL/pull/68#issuecomment-70125096","issue_url":"https://api.github.com/repos/FINRAOS/MSL/issues/68","id":70125096,"user":{"login":"seoj","id":10010046,"avatar_url":"https://avatars.githubusercontent.com/u/10010046?v=3","gravatar_id":"","url":"https://api.github.com/users/seoj","html_url":"https://github.com/seoj","followers_url":"https://api.github.com/users/seoj/followers","following_url":"https://api.github.com/users/seoj/following{/other_user}","gists_url":"https://api.github.com/users/seoj/gists{/gist_id}","starred_url":"https://api.github.com/users/seoj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seoj/subscriptions","organizations_url":"https://api.github.com/users/seoj/orgs","repos_url":"https://api.github.com/users/seoj/repos","events_url":"https://api.github.com/users/seoj/events{/privacy}","received_events_url":"https://api.github.com/users/seoj/received_events","type":"User","site_admin":false},"created_at":"2015-01-15T17:27:28Z","updated_at":"2015-01-15T17:27:28Z","body":"@kood1 I added a separate karma test under msl-client-browser directory which tests just the function to escape the quotes. We could probably try using a quote selector in one of the e2e to include this new functionality.\r\n\r\nJust thought that including the test ONLY in the e2e wouldn't have been enough to cover all cases for the new function, hence, the new unit test."}}