{"action":"created","comment":{"url":"https://api.github.com/repos/musescore/MuseScore/pulls/comments/30502071","id":30502071,"diff_hunk":"@@ -731,6 +735,478 @@ bool Score::isSubdivided(ChordRest* chord, int swingUnit)\n             return false;\n       }\n \n+void renderTremolo(Chord *chord, QList<NoteEventList> & ell){","path":"libmscore/rendermidi.cpp","position":18,"original_position":18,"commit_id":"98fb35b54452103cfd3f41d9f0f938f4b0a008eb","original_commit_id":"98fb35b54452103cfd3f41d9f0f938f4b0a008eb","user":{"login":"lasconic","id":234271,"avatar_url":"https://avatars.githubusercontent.com/u/234271?v=3","gravatar_id":"","url":"https://api.github.com/users/lasconic","html_url":"https://github.com/lasconic","followers_url":"https://api.github.com/users/lasconic/followers","following_url":"https://api.github.com/users/lasconic/following{/other_user}","gists_url":"https://api.github.com/users/lasconic/gists{/gist_id}","starred_url":"https://api.github.com/users/lasconic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lasconic/subscriptions","organizations_url":"https://api.github.com/users/lasconic/orgs","repos_url":"https://api.github.com/users/lasconic/repos","events_url":"https://api.github.com/users/lasconic/events{/privacy}","received_events_url":"https://api.github.com/users/lasconic/received_events","type":"User","site_admin":false},"body":"the factorization into functions is great. Thank you for making it. As you will see all around the code, every function has an header \r\n```\r\n//---------------------------------------------------------\r\n//   functionName\r\n//    optional explanation on multiple line if needed\r\n//---------------------------------------------------------\r\n```\r\n\r\nRegarding the indentation, we use 6 spaces to indent. (the code is 4 spaces indented in your PR) The { after a functionName are on a new line. We use `if (nospace) {` and idem for while, case etc... I started to reindent it so don't bother for this one.","created_at":"2015-05-18T12:20:04Z","updated_at":"2015-05-18T12:20:04Z","html_url":"https://github.com/musescore/MuseScore/pull/1946#discussion_r30502071","pull_request_url":"https://api.github.com/repos/musescore/MuseScore/pulls/1946","_links":{"self":{"href":"https://api.github.com/repos/musescore/MuseScore/pulls/comments/30502071"},"html":{"href":"https://github.com/musescore/MuseScore/pull/1946#discussion_r30502071"},"pull_request":{"href":"https://api.github.com/repos/musescore/MuseScore/pulls/1946"}}},"pull_request":{"url":"https://api.github.com/repos/musescore/MuseScore/pulls/1946","id":33184615,"html_url":"https://github.com/musescore/MuseScore/pull/1946","diff_url":"https://github.com/musescore/MuseScore/pull/1946.diff","patch_url":"https://github.com/musescore/MuseScore/pull/1946.patch","issue_url":"https://api.github.com/repos/musescore/MuseScore/issues/1946","number":1946,"state":"open","locked":false,"title":"1518 articulations","user":{"login":"jimka2001","id":6414129,"avatar_url":"https://avatars.githubusercontent.com/u/6414129?v=3","gravatar_id":"","url":"https://api.github.com/users/jimka2001","html_url":"https://github.com/jimka2001","followers_url":"https://api.github.com/users/jimka2001/followers","following_url":"https://api.github.com/users/jimka2001/following{/other_user}","gists_url":"https://api.github.com/users/jimka2001/gists{/gist_id}","starred_url":"https://api.github.com/users/jimka2001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimka2001/subscriptions","organizations_url":"https://api.github.com/users/jimka2001/orgs","repos_url":"https://api.github.com/users/jimka2001/repos","events_url":"https://api.github.com/users/jimka2001/events{/privacy}","received_events_url":"https://api.github.com/users/jimka2001/received_events","type":"User","site_admin":false},"body":"Implementation of several ornaments/articulations including Trill, Turn, ReverseTurn\r\nrefactored Mordent, and Prall to use the new function renderArticulation()","created_at":"2015-04-13T17:27:47Z","updated_at":"2015-05-18T12:20:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a0e89ea623b3bd85d7aedcbb4eaccc0969b4716b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/musescore/MuseScore/pulls/1946/commits","review_comments_url":"https://api.github.com/repos/musescore/MuseScore/pulls/1946/comments","review_comment_url":"https://api.github.com/repos/musescore/MuseScore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/musescore/MuseScore/issues/1946/comments","statuses_url":"https://api.github.com/repos/musescore/MuseScore/statuses/98fb35b54452103cfd3f41d9f0f938f4b0a008eb","head":{"label":"jimka2001:1518-articulations","ref":"1518-articulations","sha":"98fb35b54452103cfd3f41d9f0f938f4b0a008eb","user":{"login":"jimka2001","id":6414129,"avatar_url":"https://avatars.githubusercontent.com/u/6414129?v=3","gravatar_id":"","url":"https://api.github.com/users/jimka2001","html_url":"https://github.com/jimka2001","followers_url":"https://api.github.com/users/jimka2001/followers","following_url":"https://api.github.com/users/jimka2001/following{/other_user}","gists_url":"https://api.github.com/users/jimka2001/gists{/gist_id}","starred_url":"https://api.github.com/users/jimka2001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimka2001/subscriptions","organizations_url":"https://api.github.com/users/jimka2001/orgs","repos_url":"https://api.github.com/users/jimka2001/repos","events_url":"https://api.github.com/users/jimka2001/events{/privacy}","received_events_url":"https://api.github.com/users/jimka2001/received_events","type":"User","site_admin":false},"repo":{"id":15950624,"name":"MuseScore","full_name":"jimka2001/MuseScore","owner":{"login":"jimka2001","id":6414129,"avatar_url":"https://avatars.githubusercontent.com/u/6414129?v=3","gravatar_id":"","url":"https://api.github.com/users/jimka2001","html_url":"https://github.com/jimka2001","followers_url":"https://api.github.com/users/jimka2001/followers","following_url":"https://api.github.com/users/jimka2001/following{/other_user}","gists_url":"https://api.github.com/users/jimka2001/gists{/gist_id}","starred_url":"https://api.github.com/users/jimka2001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimka2001/subscriptions","organizations_url":"https://api.github.com/users/jimka2001/orgs","repos_url":"https://api.github.com/users/jimka2001/repos","events_url":"https://api.github.com/users/jimka2001/events{/privacy}","received_events_url":"https://api.github.com/users/jimka2001/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jimka2001/MuseScore","description":"MuseScore is a open source and free music notation software. For support, contribution, bug reports, visit MuseScore.org. Fork and make pull requests!","fork":true,"url":"https://api.github.com/repos/jimka2001/MuseScore","forks_url":"https://api.github.com/repos/jimka2001/MuseScore/forks","keys_url":"https://api.github.com/repos/jimka2001/MuseScore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jimka2001/MuseScore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jimka2001/MuseScore/teams","hooks_url":"https://api.github.com/repos/jimka2001/MuseScore/hooks","issue_events_url":"https://api.github.com/repos/jimka2001/MuseScore/issues/events{/number}","events_url":"https://api.github.com/repos/jimka2001/MuseScore/events","assignees_url":"https://api.github.com/repos/jimka2001/MuseScore/assignees{/user}","branches_url":"https://api.github.com/repos/jimka2001/MuseScore/branches{/branch}","tags_url":"https://api.github.com/repos/jimka2001/MuseScore/tags","blobs_url":"https://api.github.com/repos/jimka2001/MuseScore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jimka2001/MuseScore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jimka2001/MuseScore/git/refs{/sha}","trees_url":"https://api.github.com/repos/jimka2001/MuseScore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jimka2001/MuseScore/statuses/{sha}","languages_url":"https://api.github.com/repos/jimka2001/MuseScore/languages","stargazers_url":"https://api.github.com/repos/jimka2001/MuseScore/stargazers","contributors_url":"https://api.github.com/repos/jimka2001/MuseScore/contributors","subscribers_url":"https://api.github.com/repos/jimka2001/MuseScore/subscribers","subscription_url":"https://api.github.com/repos/jimka2001/MuseScore/subscription","commits_url":"https://api.github.com/repos/jimka2001/MuseScore/commits{/sha}","git_commits_url":"https://api.github.com/repos/jimka2001/MuseScore/git/commits{/sha}","comments_url":"https://api.github.com/repos/jimka2001/MuseScore/comments{/number}","issue_comment_url":"https://api.github.com/repos/jimka2001/MuseScore/issues/comments{/number}","contents_url":"https://api.github.com/repos/jimka2001/MuseScore/contents/{+path}","compare_url":"https://api.github.com/repos/jimka2001/MuseScore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jimka2001/MuseScore/merges","archive_url":"https://api.github.com/repos/jimka2001/MuseScore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jimka2001/MuseScore/downloads","issues_url":"https://api.github.com/repos/jimka2001/MuseScore/issues{/number}","pulls_url":"https://api.github.com/repos/jimka2001/MuseScore/pulls{/number}","milestones_url":"https://api.github.com/repos/jimka2001/MuseScore/milestones{/number}","notifications_url":"https://api.github.com/repos/jimka2001/MuseScore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jimka2001/MuseScore/labels{/name}","releases_url":"https://api.github.com/repos/jimka2001/MuseScore/releases{/id}","created_at":"2014-01-15T22:25:46Z","updated_at":"2015-04-16T17:49:45Z","pushed_at":"2015-05-16T08:57:34Z","git_url":"git://github.com/jimka2001/MuseScore.git","ssh_url":"git@github.com:jimka2001/MuseScore.git","clone_url":"https://github.com/jimka2001/MuseScore.git","svn_url":"https://github.com/jimka2001/MuseScore","homepage":"http://musescore.org","size":190935,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"musescore:master","ref":"master","sha":"8911cdd6c94faf8a0d569829fb885fa2ddcd0f7d","user":{"login":"musescore","id":380563,"avatar_url":"https://avatars.githubusercontent.com/u/380563?v=3","gravatar_id":"","url":"https://api.github.com/users/musescore","html_url":"https://github.com/musescore","followers_url":"https://api.github.com/users/musescore/followers","following_url":"https://api.github.com/users/musescore/following{/other_user}","gists_url":"https://api.github.com/users/musescore/gists{/gist_id}","starred_url":"https://api.github.com/users/musescore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/musescore/subscriptions","organizations_url":"https://api.github.com/users/musescore/orgs","repos_url":"https://api.github.com/users/musescore/repos","events_url":"https://api.github.com/users/musescore/events{/privacy}","received_events_url":"https://api.github.com/users/musescore/received_events","type":"Organization","site_admin":false},"repo":{"id":4454793,"name":"MuseScore","full_name":"musescore/MuseScore","owner":{"login":"musescore","id":380563,"avatar_url":"https://avatars.githubusercontent.com/u/380563?v=3","gravatar_id":"","url":"https://api.github.com/users/musescore","html_url":"https://github.com/musescore","followers_url":"https://api.github.com/users/musescore/followers","following_url":"https://api.github.com/users/musescore/following{/other_user}","gists_url":"https://api.github.com/users/musescore/gists{/gist_id}","starred_url":"https://api.github.com/users/musescore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/musescore/subscriptions","organizations_url":"https://api.github.com/users/musescore/orgs","repos_url":"https://api.github.com/users/musescore/repos","events_url":"https://api.github.com/users/musescore/events{/privacy}","received_events_url":"https://api.github.com/users/musescore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/musescore/MuseScore","description":"MuseScore is an open source and free music notation software. For support, contribution, bug reports, visit MuseScore.org. Fork and make pull requests!","fork":false,"url":"https://api.github.com/repos/musescore/MuseScore","forks_url":"https://api.github.com/repos/musescore/MuseScore/forks","keys_url":"https://api.github.com/repos/musescore/MuseScore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/musescore/MuseScore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/musescore/MuseScore/teams","hooks_url":"https://api.github.com/repos/musescore/MuseScore/hooks","issue_events_url":"https://api.github.com/repos/musescore/MuseScore/issues/events{/number}","events_url":"https://api.github.com/repos/musescore/MuseScore/events","assignees_url":"https://api.github.com/repos/musescore/MuseScore/assignees{/user}","branches_url":"https://api.github.com/repos/musescore/MuseScore/branches{/branch}","tags_url":"https://api.github.com/repos/musescore/MuseScore/tags","blobs_url":"https://api.github.com/repos/musescore/MuseScore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/musescore/MuseScore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/musescore/MuseScore/git/refs{/sha}","trees_url":"https://api.github.com/repos/musescore/MuseScore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/musescore/MuseScore/statuses/{sha}","languages_url":"https://api.github.com/repos/musescore/MuseScore/languages","stargazers_url":"https://api.github.com/repos/musescore/MuseScore/stargazers","contributors_url":"https://api.github.com/repos/musescore/MuseScore/contributors","subscribers_url":"https://api.github.com/repos/musescore/MuseScore/subscribers","subscription_url":"https://api.github.com/repos/musescore/MuseScore/subscription","commits_url":"https://api.github.com/repos/musescore/MuseScore/commits{/sha}","git_commits_url":"https://api.github.com/repos/musescore/MuseScore/git/commits{/sha}","comments_url":"https://api.github.com/repos/musescore/MuseScore/comments{/number}","issue_comment_url":"https://api.github.com/repos/musescore/MuseScore/issues/comments{/number}","contents_url":"https://api.github.com/repos/musescore/MuseScore/contents/{+path}","compare_url":"https://api.github.com/repos/musescore/MuseScore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/musescore/MuseScore/merges","archive_url":"https://api.github.com/repos/musescore/MuseScore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/musescore/MuseScore/downloads","issues_url":"https://api.github.com/repos/musescore/MuseScore/issues{/number}","pulls_url":"https://api.github.com/repos/musescore/MuseScore/pulls{/number}","milestones_url":"https://api.github.com/repos/musescore/MuseScore/milestones{/number}","notifications_url":"https://api.github.com/repos/musescore/MuseScore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/musescore/MuseScore/labels{/name}","releases_url":"https://api.github.com/repos/musescore/MuseScore/releases{/id}","created_at":"2012-05-26T12:46:33Z","updated_at":"2015-05-17T21:08:45Z","pushed_at":"2015-05-18T09:44:44Z","git_url":"git://github.com/musescore/MuseScore.git","ssh_url":"git@github.com:musescore/MuseScore.git","clone_url":"https://github.com/musescore/MuseScore.git","svn_url":"https://github.com/musescore/MuseScore","homepage":"http://musescore.org","size":366587,"stargazers_count":661,"watchers_count":661,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":394,"mirror_url":null,"open_issues_count":31,"forks":394,"open_issues":31,"watchers":661,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/musescore/MuseScore/pulls/1946"},"html":{"href":"https://github.com/musescore/MuseScore/pull/1946"},"issue":{"href":"https://api.github.com/repos/musescore/MuseScore/issues/1946"},"comments":{"href":"https://api.github.com/repos/musescore/MuseScore/issues/1946/comments"},"review_comments":{"href":"https://api.github.com/repos/musescore/MuseScore/pulls/1946/comments"},"review_comment":{"href":"https://api.github.com/repos/musescore/MuseScore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/musescore/MuseScore/pulls/1946/commits"},"statuses":{"href":"https://api.github.com/repos/musescore/MuseScore/statuses/98fb35b54452103cfd3f41d9f0f938f4b0a008eb"}}}}