{"action":"opened","number":390,"pull_request":{"url":"https://api.github.com/repos/mozilla-b2g/gaia-email-libs-and-more/pulls/390","id":36682838,"html_url":"https://github.com/mozilla-b2g/gaia-email-libs-and-more/pull/390","diff_url":"https://github.com/mozilla-b2g/gaia-email-libs-and-more/pull/390.diff","patch_url":"https://github.com/mozilla-b2g/gaia-email-libs-and-more/pull/390.patch","issue_url":"https://api.github.com/repos/mozilla-b2g/gaia-email-libs-and-more/issues/390","number":390,"state":"open","locked":false,"title":"Bug 1169589 - [email/backed] Folder depths are wrong because of mismatched argument call lists and type coercion.","user":{"login":"asutherland","id":212206,"avatar_url":"https://avatars.githubusercontent.com/u/212206?v=3","gravatar_id":"","url":"https://api.github.com/users/asutherland","html_url":"https://github.com/asutherland","followers_url":"https://api.github.com/users/asutherland/followers","following_url":"https://api.github.com/users/asutherland/following{/other_user}","gists_url":"https://api.github.com/users/asutherland/gists{/gist_id}","starred_url":"https://api.github.com/users/asutherland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asutherland/subscriptions","organizations_url":"https://api.github.com/users/asutherland/orgs","repos_url":"https://api.github.com/users/asutherland/repos","events_url":"https://api.github.com/users/asutherland/events{/privacy}","received_events_url":"https://api.github.com/users/asutherland/received_events","type":"User","site_admin":false},"body":"- Implements \"folderConfig\" support for hoodiecrow, which we had previously\r\n  punted on.  See the speculatively landed/released 0.41 at:\r\n  https://github.com/mozilla-b2g/mail-fakeservers/pull/33\r\n\r\n- Updates test_imap_create_folders.js (which was where I introduced\r\n  folderConfig) to be run now.  I did a minor hack enhancement where if we\r\n  get a \"NO\" to our createFolder command and the message includes \"already\"\r\n  that we treat it like we got an ALREADYEXISTS.  This was important because\r\n  imapd would say ALREADYEXISTS (after my changes? before?) but hoodiecrow\r\n  does not yet do this.\r\n\r\n- Fixes a bug in logic.js where we wouldn't start listening for events until\r\n  a future turn of the event loop.  (If this seems familiar, I'd raised a\r\n  point on this and you'd reworked the code to avoid the problem, but the\r\n  normalization with a \"|| Promise.resolve()\" at the top defeated a check\r\n  further down.  I've punted on the \"not\" case because I like keeping future\r\n  me on his toes.\r\n\r\n- Improves the logic.js logging for the debugging scenario by:\r\n  - logging failed matches on timeout as a proper event\r\n  - JSON stringifying the expectation on mis-match.  This probably would be\r\n    better as a full event, but this change is a big improvement over seeing\r\n    \"[object Object]\".\r\n\r\n- Adds a new non-legacy test (using folderConfig) that fails without the fix\r\n  and succeeds with it.\r\n\r\n- The fix for the depth bug.","created_at":"2015-06-01T23:50:18Z","updated_at":"2015-06-01T23:50:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-b2g/gaia-email-libs-and-more/pulls/390/commits","review_comments_url":"https://api.github.com/repos/mozilla-b2g/gaia-email-libs-and-more/pulls/390/comments","review_comment_url":"https://api.github.com/repos/mozilla-b2g/gaia-email-libs-and-more/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla-b2g/gaia-email-libs-and-more/issues/390/comments","statuses_url":"https://api.github.com/repos/mozilla-b2g/gaia-email-libs-and-more/statuses/b0118898e753f0097f08a0daafcd202f43e11071","head":{"label":"asutherland:bug1169589-folder-depths","ref":"bug1169589-folder-depths","sha":"b0118898e753f0097f08a0daafcd202f43e11071","user":{"login":"asutherland","id":212206,"avatar_url":"https://avatars.githubusercontent.com/u/212206?v=3","gravatar_id":"","url":"https://api.github.com/users/asutherland","html_url":"https://github.com/asutherland","followers_url":"https://api.github.com/users/asutherland/followers","following_url":"https://api.github.com/users/asutherland/following{/other_user}","gists_url":"https://api.github.com/users/asutherland/gists{/gist_id}","starred_url":"https://api.github.com/users/asutherland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asutherland/subscriptions","organizations_url":"https://api.github.com/users/asutherland/orgs","repos_url":"https://api.github.com/users/asutherland/repos","events_url":"https://api.github.com/users/asutherland/events{/privacy}","received_events_url":"https://api.github.com/users/asutherland/received_events","type":"User","site_admin":false},"repo":{"id":4577430,"name":"gaia-email-libs-and-more","full_name":"asutherland/gaia-email-libs-and-more","owner":{"login":"asutherland","id":212206,"avatar_url":"https://avatars.githubusercontent.com/u/212206?v=3","gravatar_id":"","url":"https://api.github.com/users/asutherland","html_url":"https://github.com/asutherland","followers_url":"https://api.github.com/users/asutherland/followers","following_url":"https://api.github.com/users/asutherland/following{/other_user}","gists_url":"https://api.github.com/users/asutherland/gists{/gist_id}","starred_url":"https://api.github.com/users/asutherland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asutherland/subscriptions","organizations_url":"https://api.github.com/users/asutherland/orgs","repos_url":"https://api.github.com/users/asutherland/repos","events_url":"https://api.github.com/users/asutherland/events{/privacy}","received_events_url":"https://api.github.com/users/asutherland/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/asutherland/gaia-email-libs-and-more","description":"","fork":true,"url":"https://api.github.com/repos/asutherland/gaia-email-libs-and-more","forks_url":"https://api.github.com/repos/asutherland/gaia-email-libs-and-more/forks","keys_url":"https://api.github.com/repos/asutherland/gaia-email-libs-and-more/keys{/key_id}","collaborators_url":"https://api.github.com/repos/asutherland/gaia-email-libs-and-more/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/asutherland/gaia-email-libs-and-more/teams","hooks_url":"https://api.github.com/repos/asutherland/gaia-email-libs-and-more/hooks","issue_events_url":"https://api.github.com/repos/asutherland/gaia-email-libs-and-more/issues/events{/number}","events_url":"https://api.github.com/repos/asutherland/gaia-email-libs-and-more/events","assignees_url":"https://api.github.com/repos/asutherland/gaia-email-libs-and-more/assignees{/user}","branches_url":"https://api.github.com/repos/asutherland/gaia-email-libs-and-more/branches{/branch}","tags_url":"https://api.github.com/repos/asutherland/gaia-email-libs-and-more/tags","blobs_url":"https://api.github.com/repos/asutherland/gaia-email-libs-and-more/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/asutherland/gaia-email-libs-and-more/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/asutherland/gaia-email-libs-and-more/git/refs{/sha}","trees_url":"https://api.github.com/repos/asutherland/gaia-email-libs-and-more/git/trees{/sha}","statuses_url":"https://api.github.com/repos/asutherland/gaia-email-libs-and-more/statuses/{sha}","languages_url":"https://api.github.com/repos/asutherland/gaia-email-libs-and-more/languages","stargazers_url":"https://api.github.com/repos/asutherland/gaia-email-libs-and-more/stargazers","contributors_url":"https://api.github.com/repos/asutherland/gaia-email-libs-and-more/contributors","subscribers_url":"https://api.github.com/repos/asutherland/gaia-email-libs-and-more/subscribers","subscription_url":"https://api.github.com/repos/asutherland/gaia-email-libs-and-more/subscription","commits_url":"https://api.github.com/repos/asutherland/gaia-email-libs-and-more/commits{/sha}","git_commits_url":"https://api.github.com/repos/asutherland/gaia-email-libs-and-more/git/commits{/sha}","comments_url":"https://api.github.com/repos/asutherland/gaia-email-libs-and-more/comments{/number}","issue_comment_url":"https://api.github.com/repos/asutherland/gaia-email-libs-and-more/issues/comments{/number}","contents_url":"https://api.github.com/repos/asutherland/gaia-email-libs-and-more/contents/{+path}","compare_url":"https://api.github.com/repos/asutherland/gaia-email-libs-and-more/compare/{base}...{head}","merges_url":"https://api.github.com/repos/asutherland/gaia-email-libs-and-more/merges","archive_url":"https://api.github.com/repos/asutherland/gaia-email-libs-and-more/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/asutherland/gaia-email-libs-and-more/downloads","issues_url":"https://api.github.com/repos/asutherland/gaia-email-libs-and-more/issues{/number}","pulls_url":"https://api.github.com/repos/asutherland/gaia-email-libs-and-more/pulls{/number}","milestones_url":"https://api.github.com/repos/asutherland/gaia-email-libs-and-more/milestones{/number}","notifications_url":"https://api.github.com/repos/asutherland/gaia-email-libs-and-more/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/asutherland/gaia-email-libs-and-more/labels{/name}","releases_url":"https://api.github.com/repos/asutherland/gaia-email-libs-and-more/releases{/id}","created_at":"2012-06-06T20:08:50Z","updated_at":"2015-01-15T18:38:32Z","pushed_at":"2015-06-01T23:49:59Z","git_url":"git://github.com/asutherland/gaia-email-libs-and-more.git","ssh_url":"git@github.com:asutherland/gaia-email-libs-and-more.git","clone_url":"https://github.com/asutherland/gaia-email-libs-and-more.git","svn_url":"https://github.com/asutherland/gaia-email-libs-and-more","homepage":"","size":12492,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":4,"default_branch":"master"}},"base":{"label":"mozilla-b2g:master","ref":"master","sha":"81386a419ffed42f08a0434ac019a3faefa0e310","user":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"repo":{"id":3890726,"name":"gaia-email-libs-and-more","full_name":"mozilla-b2g/gaia-email-libs-and-more","owner":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-b2g/gaia-email-libs-and-more","description":"E-mail libraries for the Firefox OS Gaia E-mail client","fork":false,"url":"https://api.github.com/repos/mozilla-b2g/gaia-email-libs-and-more","forks_url":"https://api.github.com/repos/mozilla-b2g/gaia-email-libs-and-more/forks","keys_url":"https://api.github.com/repos/mozilla-b2g/gaia-email-libs-and-more/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-b2g/gaia-email-libs-and-more/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-b2g/gaia-email-libs-and-more/teams","hooks_url":"https://api.github.com/repos/mozilla-b2g/gaia-email-libs-and-more/hooks","issue_events_url":"https://api.github.com/repos/mozilla-b2g/gaia-email-libs-and-more/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-b2g/gaia-email-libs-and-more/events","assignees_url":"https://api.github.com/repos/mozilla-b2g/gaia-email-libs-and-more/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-b2g/gaia-email-libs-and-more/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-b2g/gaia-email-libs-and-more/tags","blobs_url":"https://api.github.com/repos/mozilla-b2g/gaia-email-libs-and-more/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-b2g/gaia-email-libs-and-more/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-b2g/gaia-email-libs-and-more/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-b2g/gaia-email-libs-and-more/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-b2g/gaia-email-libs-and-more/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-b2g/gaia-email-libs-and-more/languages","stargazers_url":"https://api.github.com/repos/mozilla-b2g/gaia-email-libs-and-more/stargazers","contributors_url":"https://api.github.com/repos/mozilla-b2g/gaia-email-libs-and-more/contributors","subscribers_url":"https://api.github.com/repos/mozilla-b2g/gaia-email-libs-and-more/subscribers","subscription_url":"https://api.github.com/repos/mozilla-b2g/gaia-email-libs-and-more/subscription","commits_url":"https://api.github.com/repos/mozilla-b2g/gaia-email-libs-and-more/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-b2g/gaia-email-libs-and-more/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-b2g/gaia-email-libs-and-more/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-b2g/gaia-email-libs-and-more/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla-b2g/gaia-email-libs-and-more/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-b2g/gaia-email-libs-and-more/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-b2g/gaia-email-libs-and-more/merges","archive_url":"https://api.github.com/repos/mozilla-b2g/gaia-email-libs-and-more/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-b2g/gaia-email-libs-and-more/downloads","issues_url":"https://api.github.com/repos/mozilla-b2g/gaia-email-libs-and-more/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-b2g/gaia-email-libs-and-more/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-b2g/gaia-email-libs-and-more/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-b2g/gaia-email-libs-and-more/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-b2g/gaia-email-libs-and-more/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-b2g/gaia-email-libs-and-more/releases{/id}","created_at":"2012-04-01T06:21:02Z","updated_at":"2015-05-03T22:06:11Z","pushed_at":"2015-05-28T22:34:49Z","git_url":"git://github.com/mozilla-b2g/gaia-email-libs-and-more.git","ssh_url":"git@github.com:mozilla-b2g/gaia-email-libs-and-more.git","clone_url":"https://github.com/mozilla-b2g/gaia-email-libs-and-more.git","svn_url":"https://github.com/mozilla-b2g/gaia-email-libs-and-more","homepage":"https://wiki.mozilla.org/Gaia/Email","size":16869,"stargazers_count":34,"watchers_count":34,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":35,"mirror_url":null,"open_issues_count":4,"forks":35,"open_issues":4,"watchers":34,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia-email-libs-and-more/pulls/390"},"html":{"href":"https://github.com/mozilla-b2g/gaia-email-libs-and-more/pull/390"},"issue":{"href":"https://api.github.com/repos/mozilla-b2g/gaia-email-libs-and-more/issues/390"},"comments":{"href":"https://api.github.com/repos/mozilla-b2g/gaia-email-libs-and-more/issues/390/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-b2g/gaia-email-libs-and-more/pulls/390/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-b2g/gaia-email-libs-and-more/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla-b2g/gaia-email-libs-and-more/pulls/390/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-b2g/gaia-email-libs-and-more/statuses/b0118898e753f0097f08a0daafcd202f43e11071"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":199,"deletions":34,"changed_files":12}}