{"action":"created","comment":{"url":"https://api.github.com/repos/Icenium/icenium-cli/pulls/comments/31822681","id":31822681,"diff_hunk":"@@ -20,8 +21,12 @@ export class ResourceLoader implements IResourceLoader {\n \t\treturn this.$fs.readJson(this.resolvePath(resourcePath));\n \t}\n \n-\tpublic get appResourcesDir(): string {\n-\t\treturn this.resolvePath(\"App_Resources\");\n+\tpublic get cordovaAppResourcesDir(): string {","path":"lib/resource-loader.ts","position":16,"original_position":16,"commit_id":"3f708c74b8675a5689dc089ba857ce664fbb7240","original_commit_id":"3f708c74b8675a5689dc089ba857ce664fbb7240","user":{"login":"rosen-vladimirov","id":8351653,"avatar_url":"https://avatars.githubusercontent.com/u/8351653?v=3","gravatar_id":"","url":"https://api.github.com/users/rosen-vladimirov","html_url":"https://github.com/rosen-vladimirov","followers_url":"https://api.github.com/users/rosen-vladimirov/followers","following_url":"https://api.github.com/users/rosen-vladimirov/following{/other_user}","gists_url":"https://api.github.com/users/rosen-vladimirov/gists{/gist_id}","starred_url":"https://api.github.com/users/rosen-vladimirov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rosen-vladimirov/subscriptions","organizations_url":"https://api.github.com/users/rosen-vladimirov/orgs","repos_url":"https://api.github.com/users/rosen-vladimirov/repos","events_url":"https://api.github.com/users/rosen-vladimirov/events{/privacy}","received_events_url":"https://api.github.com/users/rosen-vladimirov/received_events","type":"User","site_admin":false},"body":"It's part of the resources, the directory itself is part of the resources and that's why I've placed it here. Placing it inside cordova project would mean it is part of any cordova project, while it is part of our own resources. \r\nThat was my logic, but in case you insist, I'll try moving this to cordova project (not sure what kind of mess will happen).","created_at":"2015-06-05T15:30:06Z","updated_at":"2015-06-05T15:30:06Z","html_url":"https://github.com/Icenium/icenium-cli/pull/1103#discussion_r31822681","pull_request_url":"https://api.github.com/repos/Icenium/icenium-cli/pulls/1103","_links":{"self":{"href":"https://api.github.com/repos/Icenium/icenium-cli/pulls/comments/31822681"},"html":{"href":"https://github.com/Icenium/icenium-cli/pull/1103#discussion_r31822681"},"pull_request":{"href":"https://api.github.com/repos/Icenium/icenium-cli/pulls/1103"}}},"pull_request":{"url":"https://api.github.com/repos/Icenium/icenium-cli/pulls/1103","id":37030906,"html_url":"https://github.com/Icenium/icenium-cli/pull/1103","diff_url":"https://github.com/Icenium/icenium-cli/pull/1103.diff","patch_url":"https://github.com/Icenium/icenium-cli/pull/1103.patch","issue_url":"https://api.github.com/repos/Icenium/icenium-cli/issues/1103","number":1103,"state":"open","locked":false,"title":"Use correct App_Resources","user":{"login":"rosen-vladimirov","id":8351653,"avatar_url":"https://avatars.githubusercontent.com/u/8351653?v=3","gravatar_id":"","url":"https://api.github.com/users/rosen-vladimirov","html_url":"https://github.com/rosen-vladimirov","followers_url":"https://api.github.com/users/rosen-vladimirov/followers","following_url":"https://api.github.com/users/rosen-vladimirov/following{/other_user}","gists_url":"https://api.github.com/users/rosen-vladimirov/gists{/gist_id}","starred_url":"https://api.github.com/users/rosen-vladimirov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rosen-vladimirov/subscriptions","organizations_url":"https://api.github.com/users/rosen-vladimirov/orgs","repos_url":"https://api.github.com/users/rosen-vladimirov/repos","events_url":"https://api.github.com/users/rosen-vladimirov/events{/privacy}","received_events_url":"https://api.github.com/users/rosen-vladimirov/received_events","type":"User","site_admin":false},"body":"Currently we have App_Resources in our resources folder. It is created on dev-prepackage command by extracting App_Resources directory from Cordova.Blank template. Now we need App_Resources for NativeScript projects. With the new templates, the App_Resources folder is under app folder of {N} templates. In order to handle this, I've modified templatesService unpackAppResources to extract cordova and ns App_Resources.\r\nMove App_Resources folder to be under Cordova and NativeScript directories. Also with the old code, we had App_Resources/App_Resources/Android..., now we have Cordova/App_Resources/Android...\r\nChange the name of NATIVESCRIPT_APP_RESOURCES_DIR_NAME to APP_RESOURCES_DIR_NAME as this name is not specific for NativeScript projects.\r\nReplace appResourcesDir property of resources with two new properties - cordovaAppResourcesDir and nativeScriptAppResourcesDir.\r\nInside prepackage, move the logic for unpacking app resources to be at the end as cordova migration data and nativescript migration data are deleting the directory where app resources are extracted.\r\nFixes http://teampulse.telerik.com/view#item/293506","created_at":"2015-06-05T13:26:16Z","updated_at":"2015-06-05T15:30:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f4123298542c2d6db81377dfdca466618a35dc9c","assignee":{"login":"rosen-vladimirov","id":8351653,"avatar_url":"https://avatars.githubusercontent.com/u/8351653?v=3","gravatar_id":"","url":"https://api.github.com/users/rosen-vladimirov","html_url":"https://github.com/rosen-vladimirov","followers_url":"https://api.github.com/users/rosen-vladimirov/followers","following_url":"https://api.github.com/users/rosen-vladimirov/following{/other_user}","gists_url":"https://api.github.com/users/rosen-vladimirov/gists{/gist_id}","starred_url":"https://api.github.com/users/rosen-vladimirov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rosen-vladimirov/subscriptions","organizations_url":"https://api.github.com/users/rosen-vladimirov/orgs","repos_url":"https://api.github.com/users/rosen-vladimirov/repos","events_url":"https://api.github.com/users/rosen-vladimirov/events{/privacy}","received_events_url":"https://api.github.com/users/rosen-vladimirov/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/Icenium/icenium-cli/milestones/8","html_url":"https://github.com/Icenium/icenium-cli/milestones/AB%202.10.0","labels_url":"https://api.github.com/repos/Icenium/icenium-cli/milestones/8/labels","id":1075173,"number":8,"title":"AB 2.10.0","description":"27 May\r\n01 June\r\n04 June","creator":{"login":"teobugslayer","id":5443453,"avatar_url":"https://avatars.githubusercontent.com/u/5443453?v=3","gravatar_id":"","url":"https://api.github.com/users/teobugslayer","html_url":"https://github.com/teobugslayer","followers_url":"https://api.github.com/users/teobugslayer/followers","following_url":"https://api.github.com/users/teobugslayer/following{/other_user}","gists_url":"https://api.github.com/users/teobugslayer/gists{/gist_id}","starred_url":"https://api.github.com/users/teobugslayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teobugslayer/subscriptions","organizations_url":"https://api.github.com/users/teobugslayer/orgs","repos_url":"https://api.github.com/users/teobugslayer/repos","events_url":"https://api.github.com/users/teobugslayer/events{/privacy}","received_events_url":"https://api.github.com/users/teobugslayer/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":79,"state":"open","created_at":"2015-04-20T13:04:25Z","updated_at":"2015-06-05T13:26:16Z","due_on":"2015-06-03T21:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/Icenium/icenium-cli/pulls/1103/commits","review_comments_url":"https://api.github.com/repos/Icenium/icenium-cli/pulls/1103/comments","review_comment_url":"https://api.github.com/repos/Icenium/icenium-cli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Icenium/icenium-cli/issues/1103/comments","statuses_url":"https://api.github.com/repos/Icenium/icenium-cli/statuses/3f708c74b8675a5689dc089ba857ce664fbb7240","head":{"label":"Icenium:vladimirov/fix-app-resources","ref":"vladimirov/fix-app-resources","sha":"3f708c74b8675a5689dc089ba857ce664fbb7240","user":{"login":"Icenium","id":1152554,"avatar_url":"https://avatars.githubusercontent.com/u/1152554?v=3","gravatar_id":"","url":"https://api.github.com/users/Icenium","html_url":"https://github.com/Icenium","followers_url":"https://api.github.com/users/Icenium/followers","following_url":"https://api.github.com/users/Icenium/following{/other_user}","gists_url":"https://api.github.com/users/Icenium/gists{/gist_id}","starred_url":"https://api.github.com/users/Icenium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Icenium/subscriptions","organizations_url":"https://api.github.com/users/Icenium/orgs","repos_url":"https://api.github.com/users/Icenium/repos","events_url":"https://api.github.com/users/Icenium/events{/privacy}","received_events_url":"https://api.github.com/users/Icenium/received_events","type":"Organization","site_admin":false},"repo":{"id":14398834,"name":"icenium-cli","full_name":"Icenium/icenium-cli","owner":{"login":"Icenium","id":1152554,"avatar_url":"https://avatars.githubusercontent.com/u/1152554?v=3","gravatar_id":"","url":"https://api.github.com/users/Icenium","html_url":"https://github.com/Icenium","followers_url":"https://api.github.com/users/Icenium/followers","following_url":"https://api.github.com/users/Icenium/following{/other_user}","gists_url":"https://api.github.com/users/Icenium/gists{/gist_id}","starred_url":"https://api.github.com/users/Icenium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Icenium/subscriptions","organizations_url":"https://api.github.com/users/Icenium/orgs","repos_url":"https://api.github.com/users/Icenium/repos","events_url":"https://api.github.com/users/Icenium/events{/privacy}","received_events_url":"https://api.github.com/users/Icenium/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Icenium/icenium-cli","description":"Cross Platform Command Line Interface for Telerik AppBuilder","fork":false,"url":"https://api.github.com/repos/Icenium/icenium-cli","forks_url":"https://api.github.com/repos/Icenium/icenium-cli/forks","keys_url":"https://api.github.com/repos/Icenium/icenium-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Icenium/icenium-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Icenium/icenium-cli/teams","hooks_url":"https://api.github.com/repos/Icenium/icenium-cli/hooks","issue_events_url":"https://api.github.com/repos/Icenium/icenium-cli/issues/events{/number}","events_url":"https://api.github.com/repos/Icenium/icenium-cli/events","assignees_url":"https://api.github.com/repos/Icenium/icenium-cli/assignees{/user}","branches_url":"https://api.github.com/repos/Icenium/icenium-cli/branches{/branch}","tags_url":"https://api.github.com/repos/Icenium/icenium-cli/tags","blobs_url":"https://api.github.com/repos/Icenium/icenium-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Icenium/icenium-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Icenium/icenium-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/Icenium/icenium-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Icenium/icenium-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/Icenium/icenium-cli/languages","stargazers_url":"https://api.github.com/repos/Icenium/icenium-cli/stargazers","contributors_url":"https://api.github.com/repos/Icenium/icenium-cli/contributors","subscribers_url":"https://api.github.com/repos/Icenium/icenium-cli/subscribers","subscription_url":"https://api.github.com/repos/Icenium/icenium-cli/subscription","commits_url":"https://api.github.com/repos/Icenium/icenium-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/Icenium/icenium-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/Icenium/icenium-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/Icenium/icenium-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/Icenium/icenium-cli/contents/{+path}","compare_url":"https://api.github.com/repos/Icenium/icenium-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Icenium/icenium-cli/merges","archive_url":"https://api.github.com/repos/Icenium/icenium-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Icenium/icenium-cli/downloads","issues_url":"https://api.github.com/repos/Icenium/icenium-cli/issues{/number}","pulls_url":"https://api.github.com/repos/Icenium/icenium-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/Icenium/icenium-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/Icenium/icenium-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Icenium/icenium-cli/labels{/name}","releases_url":"https://api.github.com/repos/Icenium/icenium-cli/releases{/id}","created_at":"2013-11-14T15:27:18Z","updated_at":"2015-06-02T10:06:18Z","pushed_at":"2015-06-05T13:47:07Z","git_url":"git://github.com/Icenium/icenium-cli.git","ssh_url":"git@github.com:Icenium/icenium-cli.git","clone_url":"https://github.com/Icenium/icenium-cli.git","svn_url":"https://github.com/Icenium/icenium-cli","homepage":"","size":39217,"stargazers_count":22,"watchers_count":22,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":8,"forks":5,"open_issues":8,"watchers":22,"default_branch":"master"}},"base":{"label":"Icenium:release","ref":"release","sha":"0a67b48a0b3dc81bec84e135633f282b7b38b1d7","user":{"login":"Icenium","id":1152554,"avatar_url":"https://avatars.githubusercontent.com/u/1152554?v=3","gravatar_id":"","url":"https://api.github.com/users/Icenium","html_url":"https://github.com/Icenium","followers_url":"https://api.github.com/users/Icenium/followers","following_url":"https://api.github.com/users/Icenium/following{/other_user}","gists_url":"https://api.github.com/users/Icenium/gists{/gist_id}","starred_url":"https://api.github.com/users/Icenium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Icenium/subscriptions","organizations_url":"https://api.github.com/users/Icenium/orgs","repos_url":"https://api.github.com/users/Icenium/repos","events_url":"https://api.github.com/users/Icenium/events{/privacy}","received_events_url":"https://api.github.com/users/Icenium/received_events","type":"Organization","site_admin":false},"repo":{"id":14398834,"name":"icenium-cli","full_name":"Icenium/icenium-cli","owner":{"login":"Icenium","id":1152554,"avatar_url":"https://avatars.githubusercontent.com/u/1152554?v=3","gravatar_id":"","url":"https://api.github.com/users/Icenium","html_url":"https://github.com/Icenium","followers_url":"https://api.github.com/users/Icenium/followers","following_url":"https://api.github.com/users/Icenium/following{/other_user}","gists_url":"https://api.github.com/users/Icenium/gists{/gist_id}","starred_url":"https://api.github.com/users/Icenium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Icenium/subscriptions","organizations_url":"https://api.github.com/users/Icenium/orgs","repos_url":"https://api.github.com/users/Icenium/repos","events_url":"https://api.github.com/users/Icenium/events{/privacy}","received_events_url":"https://api.github.com/users/Icenium/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Icenium/icenium-cli","description":"Cross Platform Command Line Interface for Telerik AppBuilder","fork":false,"url":"https://api.github.com/repos/Icenium/icenium-cli","forks_url":"https://api.github.com/repos/Icenium/icenium-cli/forks","keys_url":"https://api.github.com/repos/Icenium/icenium-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Icenium/icenium-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Icenium/icenium-cli/teams","hooks_url":"https://api.github.com/repos/Icenium/icenium-cli/hooks","issue_events_url":"https://api.github.com/repos/Icenium/icenium-cli/issues/events{/number}","events_url":"https://api.github.com/repos/Icenium/icenium-cli/events","assignees_url":"https://api.github.com/repos/Icenium/icenium-cli/assignees{/user}","branches_url":"https://api.github.com/repos/Icenium/icenium-cli/branches{/branch}","tags_url":"https://api.github.com/repos/Icenium/icenium-cli/tags","blobs_url":"https://api.github.com/repos/Icenium/icenium-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Icenium/icenium-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Icenium/icenium-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/Icenium/icenium-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Icenium/icenium-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/Icenium/icenium-cli/languages","stargazers_url":"https://api.github.com/repos/Icenium/icenium-cli/stargazers","contributors_url":"https://api.github.com/repos/Icenium/icenium-cli/contributors","subscribers_url":"https://api.github.com/repos/Icenium/icenium-cli/subscribers","subscription_url":"https://api.github.com/repos/Icenium/icenium-cli/subscription","commits_url":"https://api.github.com/repos/Icenium/icenium-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/Icenium/icenium-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/Icenium/icenium-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/Icenium/icenium-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/Icenium/icenium-cli/contents/{+path}","compare_url":"https://api.github.com/repos/Icenium/icenium-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Icenium/icenium-cli/merges","archive_url":"https://api.github.com/repos/Icenium/icenium-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Icenium/icenium-cli/downloads","issues_url":"https://api.github.com/repos/Icenium/icenium-cli/issues{/number}","pulls_url":"https://api.github.com/repos/Icenium/icenium-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/Icenium/icenium-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/Icenium/icenium-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Icenium/icenium-cli/labels{/name}","releases_url":"https://api.github.com/repos/Icenium/icenium-cli/releases{/id}","created_at":"2013-11-14T15:27:18Z","updated_at":"2015-06-02T10:06:18Z","pushed_at":"2015-06-05T13:47:07Z","git_url":"git://github.com/Icenium/icenium-cli.git","ssh_url":"git@github.com:Icenium/icenium-cli.git","clone_url":"https://github.com/Icenium/icenium-cli.git","svn_url":"https://github.com/Icenium/icenium-cli","homepage":"","size":39217,"stargazers_count":22,"watchers_count":22,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":8,"forks":5,"open_issues":8,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Icenium/icenium-cli/pulls/1103"},"html":{"href":"https://github.com/Icenium/icenium-cli/pull/1103"},"issue":{"href":"https://api.github.com/repos/Icenium/icenium-cli/issues/1103"},"comments":{"href":"https://api.github.com/repos/Icenium/icenium-cli/issues/1103/comments"},"review_comments":{"href":"https://api.github.com/repos/Icenium/icenium-cli/pulls/1103/comments"},"review_comment":{"href":"https://api.github.com/repos/Icenium/icenium-cli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Icenium/icenium-cli/pulls/1103/commits"},"statuses":{"href":"https://api.github.com/repos/Icenium/icenium-cli/statuses/3f708c74b8675a5689dc089ba857ce664fbb7240"}}}}