{"action":"closed","number":228,"pull_request":{"url":"https://api.github.com/repos/atom/language-javascript/pulls/228","id":45566257,"html_url":"https://github.com/atom/language-javascript/pull/228","diff_url":"https://github.com/atom/language-javascript/pull/228.diff","patch_url":"https://github.com/atom/language-javascript/pull/228.patch","issue_url":"https://api.github.com/repos/atom/language-javascript/issues/228","number":228,"state":"closed","locked":false,"title":"Fix tokenizing of various keywords within ternary expression","user":{"login":"mislav","id":887,"avatar_url":"https://avatars.githubusercontent.com/u/887?v=3","gravatar_id":"","url":"https://api.github.com/users/mislav","html_url":"https://github.com/mislav","followers_url":"https://api.github.com/users/mislav/followers","following_url":"https://api.github.com/users/mislav/following{/other_user}","gists_url":"https://api.github.com/users/mislav/gists{/gist_id}","starred_url":"https://api.github.com/users/mislav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mislav/subscriptions","organizations_url":"https://api.github.com/users/mislav/orgs","repos_url":"https://api.github.com/users/mislav/repos","events_url":"https://api.github.com/users/mislav/events{/privacy}","received_events_url":"https://api.github.com/users/mislav/received_events","type":"User","site_admin":true},"body":"Supports proper tokenizing of these keywords when they appear as subexpression `b` within ternary expression `a ? b : c`:\r\n\r\n    yield, true, false, null, [CONSTANT], super, this, debugger,\r\n    module, exports, __filename, __dirname, global, process\r\n\r\nThey are not tokenized because there was a rule that these keywords should not be followed by `:`. This was to compensate for JS key/value syntax `{ foo: bar }`.\r\n\r\nThe fix adds an alternate pattern for each of these keywords that explicitly allows these keywords to be followed by `:` if they were preceded by `?`.\r\n\r\nFixes #93","created_at":"2015-09-21T15:56:51Z","updated_at":"2015-09-25T00:23:48Z","closed_at":"2015-09-25T00:23:47Z","merged_at":"2015-09-25T00:23:47Z","merge_commit_sha":"8113916014118bdce44e6b7af44d10bae7c109a7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/atom/language-javascript/pulls/228/commits","review_comments_url":"https://api.github.com/repos/atom/language-javascript/pulls/228/comments","review_comment_url":"https://api.github.com/repos/atom/language-javascript/pulls/comments{/number}","comments_url":"https://api.github.com/repos/atom/language-javascript/issues/228/comments","statuses_url":"https://api.github.com/repos/atom/language-javascript/statuses/246bfea00ffecdf50d6e21e1dba6f739e1a339f3","head":{"label":"mislav:keywords-in-ternary","ref":"keywords-in-ternary","sha":"246bfea00ffecdf50d6e21e1dba6f739e1a339f3","user":{"login":"mislav","id":887,"avatar_url":"https://avatars.githubusercontent.com/u/887?v=3","gravatar_id":"","url":"https://api.github.com/users/mislav","html_url":"https://github.com/mislav","followers_url":"https://api.github.com/users/mislav/followers","following_url":"https://api.github.com/users/mislav/following{/other_user}","gists_url":"https://api.github.com/users/mislav/gists{/gist_id}","starred_url":"https://api.github.com/users/mislav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mislav/subscriptions","organizations_url":"https://api.github.com/users/mislav/orgs","repos_url":"https://api.github.com/users/mislav/repos","events_url":"https://api.github.com/users/mislav/events{/privacy}","received_events_url":"https://api.github.com/users/mislav/received_events","type":"User","site_admin":true},"repo":{"id":42876326,"name":"language-javascript","full_name":"mislav/language-javascript","owner":{"login":"mislav","id":887,"avatar_url":"https://avatars.githubusercontent.com/u/887?v=3","gravatar_id":"","url":"https://api.github.com/users/mislav","html_url":"https://github.com/mislav","followers_url":"https://api.github.com/users/mislav/followers","following_url":"https://api.github.com/users/mislav/following{/other_user}","gists_url":"https://api.github.com/users/mislav/gists{/gist_id}","starred_url":"https://api.github.com/users/mislav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mislav/subscriptions","organizations_url":"https://api.github.com/users/mislav/orgs","repos_url":"https://api.github.com/users/mislav/repos","events_url":"https://api.github.com/users/mislav/events{/privacy}","received_events_url":"https://api.github.com/users/mislav/received_events","type":"User","site_admin":true},"private":false,"html_url":"https://github.com/mislav/language-javascript","description":"JavaScript language package for Atom","fork":true,"url":"https://api.github.com/repos/mislav/language-javascript","forks_url":"https://api.github.com/repos/mislav/language-javascript/forks","keys_url":"https://api.github.com/repos/mislav/language-javascript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mislav/language-javascript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mislav/language-javascript/teams","hooks_url":"https://api.github.com/repos/mislav/language-javascript/hooks","issue_events_url":"https://api.github.com/repos/mislav/language-javascript/issues/events{/number}","events_url":"https://api.github.com/repos/mislav/language-javascript/events","assignees_url":"https://api.github.com/repos/mislav/language-javascript/assignees{/user}","branches_url":"https://api.github.com/repos/mislav/language-javascript/branches{/branch}","tags_url":"https://api.github.com/repos/mislav/language-javascript/tags","blobs_url":"https://api.github.com/repos/mislav/language-javascript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mislav/language-javascript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mislav/language-javascript/git/refs{/sha}","trees_url":"https://api.github.com/repos/mislav/language-javascript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mislav/language-javascript/statuses/{sha}","languages_url":"https://api.github.com/repos/mislav/language-javascript/languages","stargazers_url":"https://api.github.com/repos/mislav/language-javascript/stargazers","contributors_url":"https://api.github.com/repos/mislav/language-javascript/contributors","subscribers_url":"https://api.github.com/repos/mislav/language-javascript/subscribers","subscription_url":"https://api.github.com/repos/mislav/language-javascript/subscription","commits_url":"https://api.github.com/repos/mislav/language-javascript/commits{/sha}","git_commits_url":"https://api.github.com/repos/mislav/language-javascript/git/commits{/sha}","comments_url":"https://api.github.com/repos/mislav/language-javascript/comments{/number}","issue_comment_url":"https://api.github.com/repos/mislav/language-javascript/issues/comments{/number}","contents_url":"https://api.github.com/repos/mislav/language-javascript/contents/{+path}","compare_url":"https://api.github.com/repos/mislav/language-javascript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mislav/language-javascript/merges","archive_url":"https://api.github.com/repos/mislav/language-javascript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mislav/language-javascript/downloads","issues_url":"https://api.github.com/repos/mislav/language-javascript/issues{/number}","pulls_url":"https://api.github.com/repos/mislav/language-javascript/pulls{/number}","milestones_url":"https://api.github.com/repos/mislav/language-javascript/milestones{/number}","notifications_url":"https://api.github.com/repos/mislav/language-javascript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mislav/language-javascript/labels{/name}","releases_url":"https://api.github.com/repos/mislav/language-javascript/releases{/id}","created_at":"2015-09-21T15:47:57Z","updated_at":"2015-09-21T15:47:58Z","pushed_at":"2015-09-24T17:20:02Z","git_url":"git://github.com/mislav/language-javascript.git","ssh_url":"git@github.com:mislav/language-javascript.git","clone_url":"https://github.com/mislav/language-javascript.git","svn_url":"https://github.com/mislav/language-javascript","homepage":"","size":1970,"stargazers_count":0,"watchers_count":0,"language":"CoffeeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"atom:master","ref":"master","sha":"7b14bbb041abcb39522defceca509cd35b6a7449","user":{"login":"atom","id":1089146,"avatar_url":"https://avatars.githubusercontent.com/u/1089146?v=3","gravatar_id":"","url":"https://api.github.com/users/atom","html_url":"https://github.com/atom","followers_url":"https://api.github.com/users/atom/followers","following_url":"https://api.github.com/users/atom/following{/other_user}","gists_url":"https://api.github.com/users/atom/gists{/gist_id}","starred_url":"https://api.github.com/users/atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atom/subscriptions","organizations_url":"https://api.github.com/users/atom/orgs","repos_url":"https://api.github.com/users/atom/repos","events_url":"https://api.github.com/users/atom/events{/privacy}","received_events_url":"https://api.github.com/users/atom/received_events","type":"Organization","site_admin":false},"repo":{"id":13712111,"name":"language-javascript","full_name":"atom/language-javascript","owner":{"login":"atom","id":1089146,"avatar_url":"https://avatars.githubusercontent.com/u/1089146?v=3","gravatar_id":"","url":"https://api.github.com/users/atom","html_url":"https://github.com/atom","followers_url":"https://api.github.com/users/atom/followers","following_url":"https://api.github.com/users/atom/following{/other_user}","gists_url":"https://api.github.com/users/atom/gists{/gist_id}","starred_url":"https://api.github.com/users/atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atom/subscriptions","organizations_url":"https://api.github.com/users/atom/orgs","repos_url":"https://api.github.com/users/atom/repos","events_url":"https://api.github.com/users/atom/events{/privacy}","received_events_url":"https://api.github.com/users/atom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/atom/language-javascript","description":"JavaScript language package for Atom","fork":false,"url":"https://api.github.com/repos/atom/language-javascript","forks_url":"https://api.github.com/repos/atom/language-javascript/forks","keys_url":"https://api.github.com/repos/atom/language-javascript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/atom/language-javascript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/atom/language-javascript/teams","hooks_url":"https://api.github.com/repos/atom/language-javascript/hooks","issue_events_url":"https://api.github.com/repos/atom/language-javascript/issues/events{/number}","events_url":"https://api.github.com/repos/atom/language-javascript/events","assignees_url":"https://api.github.com/repos/atom/language-javascript/assignees{/user}","branches_url":"https://api.github.com/repos/atom/language-javascript/branches{/branch}","tags_url":"https://api.github.com/repos/atom/language-javascript/tags","blobs_url":"https://api.github.com/repos/atom/language-javascript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/atom/language-javascript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/atom/language-javascript/git/refs{/sha}","trees_url":"https://api.github.com/repos/atom/language-javascript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/atom/language-javascript/statuses/{sha}","languages_url":"https://api.github.com/repos/atom/language-javascript/languages","stargazers_url":"https://api.github.com/repos/atom/language-javascript/stargazers","contributors_url":"https://api.github.com/repos/atom/language-javascript/contributors","subscribers_url":"https://api.github.com/repos/atom/language-javascript/subscribers","subscription_url":"https://api.github.com/repos/atom/language-javascript/subscription","commits_url":"https://api.github.com/repos/atom/language-javascript/commits{/sha}","git_commits_url":"https://api.github.com/repos/atom/language-javascript/git/commits{/sha}","comments_url":"https://api.github.com/repos/atom/language-javascript/comments{/number}","issue_comment_url":"https://api.github.com/repos/atom/language-javascript/issues/comments{/number}","contents_url":"https://api.github.com/repos/atom/language-javascript/contents/{+path}","compare_url":"https://api.github.com/repos/atom/language-javascript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/atom/language-javascript/merges","archive_url":"https://api.github.com/repos/atom/language-javascript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/atom/language-javascript/downloads","issues_url":"https://api.github.com/repos/atom/language-javascript/issues{/number}","pulls_url":"https://api.github.com/repos/atom/language-javascript/pulls{/number}","milestones_url":"https://api.github.com/repos/atom/language-javascript/milestones{/number}","notifications_url":"https://api.github.com/repos/atom/language-javascript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/atom/language-javascript/labels{/name}","releases_url":"https://api.github.com/repos/atom/language-javascript/releases{/id}","created_at":"2013-10-20T02:03:20Z","updated_at":"2015-09-21T17:00:40Z","pushed_at":"2015-09-25T00:23:47Z","git_url":"git://github.com/atom/language-javascript.git","ssh_url":"git@github.com:atom/language-javascript.git","clone_url":"https://github.com/atom/language-javascript.git","svn_url":"https://github.com/atom/language-javascript","homepage":"","size":1970,"stargazers_count":61,"watchers_count":61,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":87,"mirror_url":null,"open_issues_count":26,"forks":87,"open_issues":26,"watchers":61,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/atom/language-javascript/pulls/228"},"html":{"href":"https://github.com/atom/language-javascript/pull/228"},"issue":{"href":"https://api.github.com/repos/atom/language-javascript/issues/228"},"comments":{"href":"https://api.github.com/repos/atom/language-javascript/issues/228/comments"},"review_comments":{"href":"https://api.github.com/repos/atom/language-javascript/pulls/228/comments"},"review_comment":{"href":"https://api.github.com/repos/atom/language-javascript/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/atom/language-javascript/pulls/228/commits"},"statuses":{"href":"https://api.github.com/repos/atom/language-javascript/statuses/246bfea00ffecdf50d6e21e1dba6f739e1a339f3"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"50Wliu","id":2766036,"avatar_url":"https://avatars.githubusercontent.com/u/2766036?v=3","gravatar_id":"","url":"https://api.github.com/users/50Wliu","html_url":"https://github.com/50Wliu","followers_url":"https://api.github.com/users/50Wliu/followers","following_url":"https://api.github.com/users/50Wliu/following{/other_user}","gists_url":"https://api.github.com/users/50Wliu/gists{/gist_id}","starred_url":"https://api.github.com/users/50Wliu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/50Wliu/subscriptions","organizations_url":"https://api.github.com/users/50Wliu/orgs","repos_url":"https://api.github.com/users/50Wliu/repos","events_url":"https://api.github.com/users/50Wliu/events{/privacy}","received_events_url":"https://api.github.com/users/50Wliu/received_events","type":"User","site_admin":false},"comments":3,"review_comments":13,"commits":2,"additions":94,"deletions":17,"changed_files":2}}