{"action":"created","comment":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/34959967","id":34959967,"diff_hunk":"@@ -231,9 +235,12 @@ class MinMaxScaler(BaseEstimator, TransformerMixin):\n         Per feature relative scaling of the data.\n     \"\"\"\n \n-    def __init__(self, feature_range=(0, 1), copy=True):\n+    def __init__(self, feature_range=(0, 1), copy=True,\n+                 continuous_features=None):\n         self.feature_range = feature_range\n         self.copy = copy\n+        self.continuous_features_ = continuous_features","path":"sklearn/preprocessing/data.py","position":20,"original_position":20,"commit_id":"a80bf2ecd8df6ae1895f7dbe1fc194cfe8dded6a","original_commit_id":"a80bf2ecd8df6ae1895f7dbe1fc194cfe8dded6a","user":{"login":"glouppe","id":477771,"avatar_url":"https://avatars.githubusercontent.com/u/477771?v=3","gravatar_id":"","url":"https://api.github.com/users/glouppe","html_url":"https://github.com/glouppe","followers_url":"https://api.github.com/users/glouppe/followers","following_url":"https://api.github.com/users/glouppe/following{/other_user}","gists_url":"https://api.github.com/users/glouppe/gists{/gist_id}","starred_url":"https://api.github.com/users/glouppe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glouppe/subscriptions","organizations_url":"https://api.github.com/users/glouppe/orgs","repos_url":"https://api.github.com/users/glouppe/repos","events_url":"https://api.github.com/users/glouppe/events{/privacy}","received_events_url":"https://api.github.com/users/glouppe/received_events","type":"User","site_admin":false},"body":"Attributes with a trailing underscore should, by our conventions, be learnt from data at `fit`. In this case, there is no need for such an attribute. You can instead save the value of `continuous_features` into `self.continuous_features` and use this instead of `self.continuous_features_`.","created_at":"2015-07-19T17:18:46Z","updated_at":"2015-07-19T17:18:46Z","html_url":"https://github.com/scikit-learn/scikit-learn/pull/5002#discussion_r34959967","pull_request_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/5002","_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/34959967"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/5002#discussion_r34959967"},"pull_request":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/5002"}}},"pull_request":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/5002","id":40304938,"html_url":"https://github.com/scikit-learn/scikit-learn/pull/5002","diff_url":"https://github.com/scikit-learn/scikit-learn/pull/5002.diff","patch_url":"https://github.com/scikit-learn/scikit-learn/pull/5002.patch","issue_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/5002","number":5002,"state":"open","locked":false,"title":"Allow MinMaxScaler to scale specified columns","user":{"login":"hlin117","id":1865885,"avatar_url":"https://avatars.githubusercontent.com/u/1865885?v=3","gravatar_id":"","url":"https://api.github.com/users/hlin117","html_url":"https://github.com/hlin117","followers_url":"https://api.github.com/users/hlin117/followers","following_url":"https://api.github.com/users/hlin117/following{/other_user}","gists_url":"https://api.github.com/users/hlin117/gists{/gist_id}","starred_url":"https://api.github.com/users/hlin117/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hlin117/subscriptions","organizations_url":"https://api.github.com/users/hlin117/orgs","repos_url":"https://api.github.com/users/hlin117/repos","events_url":"https://api.github.com/users/hlin117/events{/privacy}","received_events_url":"https://api.github.com/users/hlin117/received_events","type":"User","site_admin":false},"body":"Addresses #5000. This should allow users to specify which columns to scale. This allows categorical data to exist in the dataset.","created_at":"2015-07-19T08:11:58Z","updated_at":"2015-07-19T17:18:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d158a229d0bf725ac3aae5a31e0e9e917c536f49","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/5002/commits","review_comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/5002/comments","review_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/5002/comments","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/a80bf2ecd8df6ae1895f7dbe1fc194cfe8dded6a","head":{"label":"hlin117:minmaxscaler","ref":"minmaxscaler","sha":"a80bf2ecd8df6ae1895f7dbe1fc194cfe8dded6a","user":{"login":"hlin117","id":1865885,"avatar_url":"https://avatars.githubusercontent.com/u/1865885?v=3","gravatar_id":"","url":"https://api.github.com/users/hlin117","html_url":"https://github.com/hlin117","followers_url":"https://api.github.com/users/hlin117/followers","following_url":"https://api.github.com/users/hlin117/following{/other_user}","gists_url":"https://api.github.com/users/hlin117/gists{/gist_id}","starred_url":"https://api.github.com/users/hlin117/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hlin117/subscriptions","organizations_url":"https://api.github.com/users/hlin117/orgs","repos_url":"https://api.github.com/users/hlin117/repos","events_url":"https://api.github.com/users/hlin117/events{/privacy}","received_events_url":"https://api.github.com/users/hlin117/received_events","type":"User","site_admin":false},"repo":{"id":36590365,"name":"scikit-learn","full_name":"hlin117/scikit-learn","owner":{"login":"hlin117","id":1865885,"avatar_url":"https://avatars.githubusercontent.com/u/1865885?v=3","gravatar_id":"","url":"https://api.github.com/users/hlin117","html_url":"https://github.com/hlin117","followers_url":"https://api.github.com/users/hlin117/followers","following_url":"https://api.github.com/users/hlin117/following{/other_user}","gists_url":"https://api.github.com/users/hlin117/gists{/gist_id}","starred_url":"https://api.github.com/users/hlin117/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hlin117/subscriptions","organizations_url":"https://api.github.com/users/hlin117/orgs","repos_url":"https://api.github.com/users/hlin117/repos","events_url":"https://api.github.com/users/hlin117/events{/privacy}","received_events_url":"https://api.github.com/users/hlin117/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hlin117/scikit-learn","description":"scikit-learn: machine learning in Python","fork":true,"url":"https://api.github.com/repos/hlin117/scikit-learn","forks_url":"https://api.github.com/repos/hlin117/scikit-learn/forks","keys_url":"https://api.github.com/repos/hlin117/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hlin117/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hlin117/scikit-learn/teams","hooks_url":"https://api.github.com/repos/hlin117/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/hlin117/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/hlin117/scikit-learn/events","assignees_url":"https://api.github.com/repos/hlin117/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/hlin117/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/hlin117/scikit-learn/tags","blobs_url":"https://api.github.com/repos/hlin117/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hlin117/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hlin117/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/hlin117/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hlin117/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/hlin117/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/hlin117/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/hlin117/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/hlin117/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/hlin117/scikit-learn/subscription","commits_url":"https://api.github.com/repos/hlin117/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/hlin117/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/hlin117/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/hlin117/scikit-learn/issues/comments{/number}","contents_url":"https://api.github.com/repos/hlin117/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/hlin117/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hlin117/scikit-learn/merges","archive_url":"https://api.github.com/repos/hlin117/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hlin117/scikit-learn/downloads","issues_url":"https://api.github.com/repos/hlin117/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/hlin117/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/hlin117/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/hlin117/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hlin117/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/hlin117/scikit-learn/releases{/id}","created_at":"2015-05-31T06:06:00Z","updated_at":"2015-06-01T01:02:20Z","pushed_at":"2015-07-19T16:50:35Z","git_url":"git://github.com/hlin117/scikit-learn.git","ssh_url":"git@github.com:hlin117/scikit-learn.git","clone_url":"https://github.com/hlin117/scikit-learn.git","svn_url":"https://github.com/hlin117/scikit-learn","homepage":"http://scikit-learn.org","size":62376,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"scikit-learn:master","ref":"master","sha":"df0dadba300fca2171d928504ad668ae1d09b2cb","user":{"login":"scikit-learn","id":365630,"avatar_url":"https://avatars.githubusercontent.com/u/365630?v=3","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"repo":{"id":843222,"name":"scikit-learn","full_name":"scikit-learn/scikit-learn","owner":{"login":"scikit-learn","id":365630,"avatar_url":"https://avatars.githubusercontent.com/u/365630?v=3","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scikit-learn/scikit-learn","description":"scikit-learn: machine learning in Python","fork":false,"url":"https://api.github.com/repos/scikit-learn/scikit-learn","forks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/forks","keys_url":"https://api.github.com/repos/scikit-learn/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scikit-learn/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scikit-learn/scikit-learn/teams","hooks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/events","assignees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/scikit-learn/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/tags","blobs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/scikit-learn/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscription","commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/comments{/number}","contents_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/scikit-learn/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scikit-learn/scikit-learn/merges","archive_url":"https://api.github.com/repos/scikit-learn/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scikit-learn/scikit-learn/downloads","issues_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/scikit-learn/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/scikit-learn/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/scikit-learn/scikit-learn/releases{/id}","created_at":"2010-08-17T09:43:38Z","updated_at":"2015-07-19T17:17:51Z","pushed_at":"2015-07-19T16:48:17Z","git_url":"git://github.com/scikit-learn/scikit-learn.git","ssh_url":"git@github.com:scikit-learn/scikit-learn.git","clone_url":"https://github.com/scikit-learn/scikit-learn.git","svn_url":"https://github.com/scikit-learn/scikit-learn","homepage":"http://scikit-learn.org","size":126819,"stargazers_count":6779,"watchers_count":6779,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4067,"mirror_url":null,"open_issues_count":732,"forks":4067,"open_issues":732,"watchers":6779,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/5002"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/5002"},"issue":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/5002"},"comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/5002/comments"},"review_comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/5002/comments"},"review_comment":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/5002/commits"},"statuses":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/a80bf2ecd8df6ae1895f7dbe1fc194cfe8dded6a"}}}}