{"action":"created","issue":{"url":"https://api.github.com/repos/mupen64plus/mupen64plus-video-rice/issues/31","labels_url":"https://api.github.com/repos/mupen64plus/mupen64plus-video-rice/issues/31/labels{/name}","comments_url":"https://api.github.com/repos/mupen64plus/mupen64plus-video-rice/issues/31/comments","events_url":"https://api.github.com/repos/mupen64plus/mupen64plus-video-rice/issues/31/events","html_url":"https://github.com/mupen64plus/mupen64plus-video-rice/pull/31","id":51760408,"number":31,"title":"Color Combiner Refactoring","user":{"login":"Narann","id":659708,"avatar_url":"https://avatars.githubusercontent.com/u/659708?v=3","gravatar_id":"","url":"https://api.github.com/users/Narann","html_url":"https://github.com/Narann","followers_url":"https://api.github.com/users/Narann/followers","following_url":"https://api.github.com/users/Narann/following{/other_user}","gists_url":"https://api.github.com/users/Narann/gists{/gist_id}","starred_url":"https://api.github.com/users/Narann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Narann/subscriptions","organizations_url":"https://api.github.com/users/Narann/orgs","repos_url":"https://api.github.com/users/Narann/repos","events_url":"https://api.github.com/users/Narann/events{/privacy}","received_events_url":"https://api.github.com/users/Narann/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":47,"created_at":"2014-12-12T01:25:31Z","updated_at":"2015-03-29T21:59:22Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mupen64plus/mupen64plus-video-rice/pulls/31","html_url":"https://github.com/mupen64plus/mupen64plus-video-rice/pull/31","diff_url":"https://github.com/mupen64plus/mupen64plus-video-rice/pull/31.diff","patch_url":"https://github.com/mupen64plus/mupen64plus-video-rice/pull/31.patch"},"body":"And here we are.\r\n\r\nHere is the \"new\" Color Combiner. A __lot__ of old fixed pipeline gl calls have been remove. A lot of classes supporting various OpenGL version on have been removed and the main class OGLColorCombiner is now OpenGL 2.1/OpenGLES 2 and rely on GLSL.\r\n\r\nThis commit make Rice incompatible with < OpenGL2.1.\r\nOpenGLES 2 use the same code path than the OpenGL one. OpenGLES 2 still need some fixes but it compile and run [on OGLES 2 hardware](http://www.paulscode.com/forum/index.php?topic=1810.msg13515#msg13515).\r\n\r\nFrom my various regression tests we should not have lost anything.\r\n\r\nI've update config file update process so you should not lost anything regarding your config.\r\n\r\nThere is still some work to do. OGLFragmentShader and OGLESFragmentShader files are still here but should be removed safely. Demuxer is sooooo integrated deep into Rice code that I'm not able to remove yet but I'm not too far. Only few calls in the deep of Rice still need it.\r\n\r\nFeel free to discuss, compile, test, etc..."},"comment":{"url":"https://api.github.com/repos/mupen64plus/mupen64plus-video-rice/issues/comments/87486741","html_url":"https://github.com/mupen64plus/mupen64plus-video-rice/pull/31#issuecomment-87486741","issue_url":"https://api.github.com/repos/mupen64plus/mupen64plus-video-rice/issues/31","id":87486741,"user":{"login":"Narann","id":659708,"avatar_url":"https://avatars.githubusercontent.com/u/659708?v=3","gravatar_id":"","url":"https://api.github.com/users/Narann","html_url":"https://github.com/Narann","followers_url":"https://api.github.com/users/Narann/followers","following_url":"https://api.github.com/users/Narann/following{/other_user}","gists_url":"https://api.github.com/users/Narann/gists{/gist_id}","starred_url":"https://api.github.com/users/Narann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Narann/subscriptions","organizations_url":"https://api.github.com/users/Narann/orgs","repos_url":"https://api.github.com/users/Narann/repos","events_url":"https://api.github.com/users/Narann/events{/privacy}","received_events_url":"https://api.github.com/users/Narann/received_events","type":"User","site_admin":false},"created_at":"2015-03-29T21:59:22Z","updated_at":"2015-03-29T21:59:22Z","body":"Thanks:\r\n* Wrong colors: I guess is only on textures rights? (It's a known issue) If not could you tell me where?\r\n* Zelda crash: Is there any way for you to _connect_ a `gdb -p<PID>` instance on it and provide a backtrace? (reproduce the bug multiple time to ensure the backtrace is the same). This way we could at least point where the program crash.\r\n* Broken shading is the weirder If you tell me it appear in every rice version I've maybe an idea where the code is."}}