{"push_id":765594967,"size":13,"distinct_size":4,"ref":"refs/heads/launchpad","head":"c16ff970c2c4fb9859e5df4f8709eb0ce5ed4631","before":"d82b77a0b57766b7ad87369e313c151ecfc26d74","commits":[{"sha":"ad0003b48414c789a1191fd5f44fec41e694dfa0","author":{"email":"fa619136c81a8d5c7d07f16111b4b9c6c205b678@collabora.co.uk","name":"Philip Withnall"},"message":"socket: Handle ECONNRESET as EWOULDBLOCK on Windows\n\nSome versions of Windows can return ECONNRESET for UDP recvmsg() calls\nif they would otherwise block. Hence, handle the two equivalently; this\nshould not affect behaviour on Linux, which apparently does not return\nECONNRESET for UDP recvmsg() calls at all.\n\nhttps://phabricator.freedesktop.org/T121","distinct":false,"url":"https://api.github.com/repos/tieto/libnice/commits/ad0003b48414c789a1191fd5f44fec41e694dfa0"},{"sha":"6b3e59c5a670d5117ed293ae612082dcd047ba8a","author":{"email":"fa619136c81a8d5c7d07f16111b4b9c6c205b678@collabora.co.uk","name":"Philip Withnall"},"message":"agent: Remove unused inet_pton() function\n\nAs spotted by Felix <felixschlitter@gmail.com>. This is a static\nfunction which is totally unused in this compilation unit and is causing\nbuild failures with -Werror=unused-function.\n\nhttp://phabricator.freedesktop.org/T123","distinct":false,"url":"https://api.github.com/repos/tieto/libnice/commits/6b3e59c5a670d5117ed293ae612082dcd047ba8a"},{"sha":"6835e7b7f4a20078d508444659c636fc98e680fc","author":{"email":"fa619136c81a8d5c7d07f16111b4b9c6c205b678@collabora.co.uk","name":"Philip Withnall"},"message":"agent: Remove unused inet_pton() function\n\nSummary:\nAs spotted by Felix <felixschlitter@gmail.com>. This is a static\nfunction which is totally unused in this compilation unit and is causing\nbuild failures with `-Werror=unused-function`.\n\nManiphest Tasks: T123\n\nReviewers: felixSchl, ocrete\n\nProjects: #libnice\n\nDifferential Revision: https://phabricator.freedesktop.org/D221","distinct":false,"url":"https://api.github.com/repos/tieto/libnice/commits/6835e7b7f4a20078d508444659c636fc98e680fc"},{"sha":"a2e25cf49b24c2012e8e9058ecc7e62f1e027cb3","author":{"email":"fa619136c81a8d5c7d07f16111b4b9c6c205b678@collabora.co.uk","name":"Philip Withnall"},"message":"socket: Close base socket for a TCP passive socket when closing parent\n\nOtherwise the base socket will leak. Spotted by Vadim Genkin.\n\nhttps://phabricator.freedesktop.org/T125","distinct":false,"url":"https://api.github.com/repos/tieto/libnice/commits/a2e25cf49b24c2012e8e9058ecc7e62f1e027cb3"},{"sha":"e5e77b67fb6152dd9fb0af3d7410a428299504d3","author":{"email":"fa619136c81a8d5c7d07f16111b4b9c6c205b678@collabora.co.uk","name":"Philip Withnall"},"message":"socket: Close base socket for a TCP passive socket when closing parent\n\nSummary:\nOtherwise the base socket will leak. Spotted by Vadim Genkin.\n\nhttps://phabricator.freedesktop.org/T125\n\nManiphest Tasks: T125\n\nReviewers: ocrete\n\nProjects: #libnice\n\nReviewed By: ocrete\n\nSubscribers: vadimgenkin\n\nDifferential Revision: https://phabricator.freedesktop.org/D228","distinct":false,"url":"https://api.github.com/repos/tieto/libnice/commits/e5e77b67fb6152dd9fb0af3d7410a428299504d3"},{"sha":"8f2a14b1d6af73e91c5712898e8a3e97308920a6","author":{"email":"fa619136c81a8d5c7d07f16111b4b9c6c205b678@collabora.co.uk","name":"Philip Withnall"},"message":"socket: Handle ECONNRESET as EWOULDBLOCK on Windows\n\nSummary:\nSome versions of Windows can return ECONNRESET for UDP recvmsg() calls\nif they would otherwise block. Hence, handle the two equivalently; this\nshould not affect behaviour on Linux, which apparently does not return\nECONNRESET for UDP recvmsg() calls at all.\n\nhttps://phabricator.freedesktop.org/T121\n\nManiphest Tasks: T121\n\nReviewers: ocrete\n\nProjects: #libnice\n\nReviewed By: ocrete\n\nSubscribers: stwiname, felixSchl\n\nDifferential Revision: https://phabricator.freedesktop.org/D227","distinct":false,"url":"https://api.github.com/repos/tieto/libnice/commits/8f2a14b1d6af73e91c5712898e8a3e97308920a6"},{"sha":"041158c4fe36c4af6d56cd4445946d7f5e5be57d","author":{"email":"fa619136c81a8d5c7d07f16111b4b9c6c205b678@collabora.co.uk","name":"Philip Withnall"},"message":"build: Add .arcconfig file\n\nThis completes the transition to Phabricator; everyone should be using\nthe same project settings now.\n\nhttps://phabricator.freedesktop.org/tag/libnice/","distinct":false,"url":"https://api.github.com/repos/tieto/libnice/commits/041158c4fe36c4af6d56cd4445946d7f5e5be57d"},{"sha":"6c9afb4db35168cc699ff0aa2e56b127f3706083","author":{"email":"fa619136c81a8d5c7d07f16111b4b9c6c205b678@collabora.co.uk","name":"Philip Withnall"},"message":"build: Fix multiple definition of CLEANFILES\n\nIt’s already defined in common.mk.","distinct":false,"url":"https://api.github.com/repos/tieto/libnice/commits/6c9afb4db35168cc699ff0aa2e56b127f3706083"},{"sha":"dddca10ceff20e3578fc901b9919c3d20f87b7b6","author":{"email":"fa619136c81a8d5c7d07f16111b4b9c6c205b678@collabora.co.uk","name":"Philip Withnall"},"message":"build: Update .gitignore\n\nAdd stun/usages/.dirstamp.","distinct":false,"url":"https://api.github.com/repos/tieto/libnice/commits/dddca10ceff20e3578fc901b9919c3d20f87b7b6"},{"sha":"feed6df1dc8f551b56476a2d44260bb2edbba1f7","author":{"email":"9b47e4aba217ee01145064f81b6b26c217d7776f@ktknet.cz","name":"Jakub Adam"},"message":"conncheck: generate candidate pair for valid srflx candidate\n\nIn priv_process_response_check_for_peer_reflexive(), mere presence of\na candidate in local_candidates doesn't mean there's also some candidate\npair in conncheck_list using it - for instance that candidate may be\nserver reflexive, for which no check pairs are initially created (see\nconn_check_add_for_candidate_pair()).\n\nIf we fail to find corresponding pair upon receiving such candidate's IP\nin a conncheck response's XOR-MAPPED-ADDRESS attribute, we shall add a\nnew one in a similar way we would add a new pair for a just discovered\npeer reflexive candidate.\n\nPrevious priv_process_response_check_for_peer_reflexive() implementation\nwould return NULL, causing a CandidateCheckPair with local candidate of\ntype HOST to be wrongly selected even though the local host IP might not\nbe directly accessible by the remote counterpart (e.g. it's an address\non a private network segment). In practice this was coming through as\na duplex connection that libnice was reporting as properly established,\nbut only one direction of the communication was actually working.","distinct":true,"url":"https://api.github.com/repos/tieto/libnice/commits/feed6df1dc8f551b56476a2d44260bb2edbba1f7"},{"sha":"e05ee4ba3fb47ac98a232475d7d7b4b15db239df","author":{"email":"9b47e4aba217ee01145064f81b6b26c217d7776f@ktknet.cz","name":"Jakub Adam"},"message":"socket: add nice_socket_get_base()","distinct":true,"url":"https://api.github.com/repos/tieto/libnice/commits/e05ee4ba3fb47ac98a232475d7d7b4b15db239df"},{"sha":"fd4779319243488958340e7a8c4d612c419ce464","author":{"email":"9b47e4aba217ee01145064f81b6b26c217d7776f@ktknet.cz","name":"Jakub Adam"},"message":"agent: compare base sockets in _tcp_sock_is_writable()\n\nThe argument passed into the callback is always a base (TCP/UDP) socket,\nwhich can't be directly compared with local candidate's sockptr (may be\nTURN, http, or other socket wrapping another one). Thus, we have to\nfirst extract candidate's base socket.","distinct":true,"url":"https://api.github.com/repos/tieto/libnice/commits/fd4779319243488958340e7a8c4d612c419ce464"},{"sha":"c16ff970c2c4fb9859e5df4f8709eb0ce5ed4631","author":{"email":"9b47e4aba217ee01145064f81b6b26c217d7776f@ktknet.cz","name":"Jakub Adam"},"message":"ms-turn: don't wait for a reply to STUN_SEND request\n\nAs per [MS-TURN] Section 2.2.1, TURN message type 0x0104 \"Send request\nresponse\" isn't supported and the TURN server MUST NOT send them. Thus,\nlibnice should not remember Send requests in agent->sent_ids because\nwithout replies coming, the number of allowed pending transaction gets\nquickly exhausted, causing our data packets to be dropped until\na request timeout frees some space in the queue.\n\nThis behavior resulted in choppy reception of our audio on a Lync client\nwhen connected via Lync Edge (TURN) Server.","distinct":true,"url":"https://api.github.com/repos/tieto/libnice/commits/c16ff970c2c4fb9859e5df4f8709eb0ce5ed4631"}]}