{"action":"created","comment":{"url":"https://api.github.com/repos/jenkinsci/parallel-test-executor-plugin/pulls/comments/36798939","id":36798939,"diff_hunk":"@@ -42,14 +42,14 @@ public DescriptorImpl() {\n \n     }\n \n-    public static final class Execution extends AbstractSynchronousStepExecution<List<List<String>>> {\n+    public static final class Execution extends AbstractSynchronousStepExecution<List<InclusionExclusionPattern>> {\n \n         @Inject private SplitStep step;\n         @StepContextParameter private Run<?,?> build;\n         @StepContextParameter private TaskListener listener;\n \n-        @Override protected List<List<String>> run() throws Exception {\n-            return ParallelTestExecutor.findTestSplits(step.parallelism, build, listener);\n+        @Override protected List<InclusionExclusionPattern> run() throws Exception {","path":"src/main/java/org/jenkinsci/plugins/parallel_test_executor/SplitStep.java","position":13,"original_position":13,"commit_id":"e0deb7b922fe5f7470efa36862b627bf870374d1","original_commit_id":"e0deb7b922fe5f7470efa36862b627bf870374d1","user":{"login":"jglick","id":154109,"avatar_url":"https://avatars.githubusercontent.com/u/154109?v=3","gravatar_id":"","url":"https://api.github.com/users/jglick","html_url":"https://github.com/jglick","followers_url":"https://api.github.com/users/jglick/followers","following_url":"https://api.github.com/users/jglick/following{/other_user}","gists_url":"https://api.github.com/users/jglick/gists{/gist_id}","starred_url":"https://api.github.com/users/jglick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jglick/subscriptions","organizations_url":"https://api.github.com/users/jglick/orgs","repos_url":"https://api.github.com/users/jglick/repos","events_url":"https://api.github.com/users/jglick/events{/privacy}","received_events_url":"https://api.github.com/users/jglick/received_events","type":"User","site_admin":false},"body":"This is an incompatible change I think.\r\n\r\n[example](https://github.com/jenkinsci/parallel-test-executor-plugin/blob/7bdb270ffe02838a36f56d4de16ebe61cd3a9556/demo/JENKINS_HOME/jobs/flow/config.xml#L12-L15)","created_at":"2015-08-11T21:06:40Z","updated_at":"2015-08-11T21:06:40Z","html_url":"https://github.com/jenkinsci/parallel-test-executor-plugin/pull/14#discussion_r36798939","pull_request_url":"https://api.github.com/repos/jenkinsci/parallel-test-executor-plugin/pulls/14","_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/parallel-test-executor-plugin/pulls/comments/36798939"},"html":{"href":"https://github.com/jenkinsci/parallel-test-executor-plugin/pull/14#discussion_r36798939"},"pull_request":{"href":"https://api.github.com/repos/jenkinsci/parallel-test-executor-plugin/pulls/14"}}},"pull_request":{"url":"https://api.github.com/repos/jenkinsci/parallel-test-executor-plugin/pulls/14","id":42150975,"html_url":"https://github.com/jenkinsci/parallel-test-executor-plugin/pull/14","diff_url":"https://github.com/jenkinsci/parallel-test-executor-plugin/pull/14.diff","patch_url":"https://github.com/jenkinsci/parallel-test-executor-plugin/pull/14.patch","issue_url":"https://api.github.com/repos/jenkinsci/parallel-test-executor-plugin/issues/14","number":14,"state":"open","locked":false,"title":"[JENKINS-29894] Allow to specify includesPatternFile","user":{"login":"Vlatombe","id":171459,"avatar_url":"https://avatars.githubusercontent.com/u/171459?v=3","gravatar_id":"","url":"https://api.github.com/users/Vlatombe","html_url":"https://github.com/Vlatombe","followers_url":"https://api.github.com/users/Vlatombe/followers","following_url":"https://api.github.com/users/Vlatombe/following{/other_user}","gists_url":"https://api.github.com/users/Vlatombe/gists{/gist_id}","starred_url":"https://api.github.com/users/Vlatombe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vlatombe/subscriptions","organizations_url":"https://api.github.com/users/Vlatombe/orgs","repos_url":"https://api.github.com/users/Vlatombe/repos","events_url":"https://api.github.com/users/Vlatombe/events{/privacy}","received_events_url":"https://api.github.com/users/Vlatombe/received_events","type":"User","site_admin":false},"body":"[JENKINS-29894](https://issues.jenkins-ci.org/browse/JENKINS-29894)\r\n\r\nIf provided, only the first bucket will use the excludesPatternFile, the other buckets will use includesPatternFile\r\n\r\n@reviewbybees, @kohsuke especially.","created_at":"2015-08-11T16:46:36Z","updated_at":"2015-08-11T21:06:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"90f7ae1e19713b6eb2b36a4879edbba3c2818342","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jenkinsci/parallel-test-executor-plugin/pulls/14/commits","review_comments_url":"https://api.github.com/repos/jenkinsci/parallel-test-executor-plugin/pulls/14/comments","review_comment_url":"https://api.github.com/repos/jenkinsci/parallel-test-executor-plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jenkinsci/parallel-test-executor-plugin/issues/14/comments","statuses_url":"https://api.github.com/repos/jenkinsci/parallel-test-executor-plugin/statuses/e0deb7b922fe5f7470efa36862b627bf870374d1","head":{"label":"Vlatombe:JENKINS-29894","ref":"JENKINS-29894","sha":"e0deb7b922fe5f7470efa36862b627bf870374d1","user":{"login":"Vlatombe","id":171459,"avatar_url":"https://avatars.githubusercontent.com/u/171459?v=3","gravatar_id":"","url":"https://api.github.com/users/Vlatombe","html_url":"https://github.com/Vlatombe","followers_url":"https://api.github.com/users/Vlatombe/followers","following_url":"https://api.github.com/users/Vlatombe/following{/other_user}","gists_url":"https://api.github.com/users/Vlatombe/gists{/gist_id}","starred_url":"https://api.github.com/users/Vlatombe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vlatombe/subscriptions","organizations_url":"https://api.github.com/users/Vlatombe/orgs","repos_url":"https://api.github.com/users/Vlatombe/repos","events_url":"https://api.github.com/users/Vlatombe/events{/privacy}","received_events_url":"https://api.github.com/users/Vlatombe/received_events","type":"User","site_admin":false},"repo":{"id":40552488,"name":"parallel-test-executor-plugin","full_name":"Vlatombe/parallel-test-executor-plugin","owner":{"login":"Vlatombe","id":171459,"avatar_url":"https://avatars.githubusercontent.com/u/171459?v=3","gravatar_id":"","url":"https://api.github.com/users/Vlatombe","html_url":"https://github.com/Vlatombe","followers_url":"https://api.github.com/users/Vlatombe/followers","following_url":"https://api.github.com/users/Vlatombe/following{/other_user}","gists_url":"https://api.github.com/users/Vlatombe/gists{/gist_id}","starred_url":"https://api.github.com/users/Vlatombe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vlatombe/subscriptions","organizations_url":"https://api.github.com/users/Vlatombe/orgs","repos_url":"https://api.github.com/users/Vlatombe/repos","events_url":"https://api.github.com/users/Vlatombe/events{/privacy}","received_events_url":"https://api.github.com/users/Vlatombe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Vlatombe/parallel-test-executor-plugin","description":"Parallel test executor plugin","fork":true,"url":"https://api.github.com/repos/Vlatombe/parallel-test-executor-plugin","forks_url":"https://api.github.com/repos/Vlatombe/parallel-test-executor-plugin/forks","keys_url":"https://api.github.com/repos/Vlatombe/parallel-test-executor-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Vlatombe/parallel-test-executor-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Vlatombe/parallel-test-executor-plugin/teams","hooks_url":"https://api.github.com/repos/Vlatombe/parallel-test-executor-plugin/hooks","issue_events_url":"https://api.github.com/repos/Vlatombe/parallel-test-executor-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/Vlatombe/parallel-test-executor-plugin/events","assignees_url":"https://api.github.com/repos/Vlatombe/parallel-test-executor-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/Vlatombe/parallel-test-executor-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/Vlatombe/parallel-test-executor-plugin/tags","blobs_url":"https://api.github.com/repos/Vlatombe/parallel-test-executor-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Vlatombe/parallel-test-executor-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Vlatombe/parallel-test-executor-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/Vlatombe/parallel-test-executor-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Vlatombe/parallel-test-executor-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/Vlatombe/parallel-test-executor-plugin/languages","stargazers_url":"https://api.github.com/repos/Vlatombe/parallel-test-executor-plugin/stargazers","contributors_url":"https://api.github.com/repos/Vlatombe/parallel-test-executor-plugin/contributors","subscribers_url":"https://api.github.com/repos/Vlatombe/parallel-test-executor-plugin/subscribers","subscription_url":"https://api.github.com/repos/Vlatombe/parallel-test-executor-plugin/subscription","commits_url":"https://api.github.com/repos/Vlatombe/parallel-test-executor-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/Vlatombe/parallel-test-executor-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/Vlatombe/parallel-test-executor-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/Vlatombe/parallel-test-executor-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/Vlatombe/parallel-test-executor-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/Vlatombe/parallel-test-executor-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Vlatombe/parallel-test-executor-plugin/merges","archive_url":"https://api.github.com/repos/Vlatombe/parallel-test-executor-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Vlatombe/parallel-test-executor-plugin/downloads","issues_url":"https://api.github.com/repos/Vlatombe/parallel-test-executor-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/Vlatombe/parallel-test-executor-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/Vlatombe/parallel-test-executor-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/Vlatombe/parallel-test-executor-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Vlatombe/parallel-test-executor-plugin/labels{/name}","releases_url":"https://api.github.com/repos/Vlatombe/parallel-test-executor-plugin/releases{/id}","created_at":"2015-08-11T16:23:02Z","updated_at":"2015-08-11T16:23:04Z","pushed_at":"2015-08-11T19:23:01Z","git_url":"git://github.com/Vlatombe/parallel-test-executor-plugin.git","ssh_url":"git@github.com:Vlatombe/parallel-test-executor-plugin.git","clone_url":"https://github.com/Vlatombe/parallel-test-executor-plugin.git","svn_url":"https://github.com/Vlatombe/parallel-test-executor-plugin","homepage":"https://wiki.jenkins-ci.org/display/JENKINS/Parallel+Text+Executor+Plugin","size":158,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jenkinsci:master","ref":"master","sha":"f11a8e4f47bfe0b1fd935d4cff913e1d70c2e55f","user":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"repo":{"id":10414359,"name":"parallel-test-executor-plugin","full_name":"jenkinsci/parallel-test-executor-plugin","owner":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jenkinsci/parallel-test-executor-plugin","description":"Parallel test executor plugin","fork":false,"url":"https://api.github.com/repos/jenkinsci/parallel-test-executor-plugin","forks_url":"https://api.github.com/repos/jenkinsci/parallel-test-executor-plugin/forks","keys_url":"https://api.github.com/repos/jenkinsci/parallel-test-executor-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenkinsci/parallel-test-executor-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenkinsci/parallel-test-executor-plugin/teams","hooks_url":"https://api.github.com/repos/jenkinsci/parallel-test-executor-plugin/hooks","issue_events_url":"https://api.github.com/repos/jenkinsci/parallel-test-executor-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/jenkinsci/parallel-test-executor-plugin/events","assignees_url":"https://api.github.com/repos/jenkinsci/parallel-test-executor-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/jenkinsci/parallel-test-executor-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/jenkinsci/parallel-test-executor-plugin/tags","blobs_url":"https://api.github.com/repos/jenkinsci/parallel-test-executor-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenkinsci/parallel-test-executor-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenkinsci/parallel-test-executor-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenkinsci/parallel-test-executor-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenkinsci/parallel-test-executor-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/jenkinsci/parallel-test-executor-plugin/languages","stargazers_url":"https://api.github.com/repos/jenkinsci/parallel-test-executor-plugin/stargazers","contributors_url":"https://api.github.com/repos/jenkinsci/parallel-test-executor-plugin/contributors","subscribers_url":"https://api.github.com/repos/jenkinsci/parallel-test-executor-plugin/subscribers","subscription_url":"https://api.github.com/repos/jenkinsci/parallel-test-executor-plugin/subscription","commits_url":"https://api.github.com/repos/jenkinsci/parallel-test-executor-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenkinsci/parallel-test-executor-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenkinsci/parallel-test-executor-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenkinsci/parallel-test-executor-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/jenkinsci/parallel-test-executor-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/jenkinsci/parallel-test-executor-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenkinsci/parallel-test-executor-plugin/merges","archive_url":"https://api.github.com/repos/jenkinsci/parallel-test-executor-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenkinsci/parallel-test-executor-plugin/downloads","issues_url":"https://api.github.com/repos/jenkinsci/parallel-test-executor-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/jenkinsci/parallel-test-executor-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/jenkinsci/parallel-test-executor-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/jenkinsci/parallel-test-executor-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenkinsci/parallel-test-executor-plugin/labels{/name}","releases_url":"https://api.github.com/repos/jenkinsci/parallel-test-executor-plugin/releases{/id}","created_at":"2013-05-31T22:46:53Z","updated_at":"2015-03-25T16:54:20Z","pushed_at":"2015-08-11T19:23:01Z","git_url":"git://github.com/jenkinsci/parallel-test-executor-plugin.git","ssh_url":"git@github.com:jenkinsci/parallel-test-executor-plugin.git","clone_url":"https://github.com/jenkinsci/parallel-test-executor-plugin.git","svn_url":"https://github.com/jenkinsci/parallel-test-executor-plugin","homepage":"https://wiki.jenkins-ci.org/display/JENKINS/Parallel+Text+Executor+Plugin","size":442,"stargazers_count":5,"watchers_count":5,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":4,"forks":8,"open_issues":4,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/parallel-test-executor-plugin/pulls/14"},"html":{"href":"https://github.com/jenkinsci/parallel-test-executor-plugin/pull/14"},"issue":{"href":"https://api.github.com/repos/jenkinsci/parallel-test-executor-plugin/issues/14"},"comments":{"href":"https://api.github.com/repos/jenkinsci/parallel-test-executor-plugin/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/jenkinsci/parallel-test-executor-plugin/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/jenkinsci/parallel-test-executor-plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jenkinsci/parallel-test-executor-plugin/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/jenkinsci/parallel-test-executor-plugin/statuses/e0deb7b922fe5f7470efa36862b627bf870374d1"}}}}