{"action":"closed","number":2001,"pull_request":{"url":"https://api.github.com/repos/d3athrow/vgstation13/pulls/2001","id":25208882,"html_url":"https://github.com/d3athrow/vgstation13/pull/2001","diff_url":"https://github.com/d3athrow/vgstation13/pull/2001.diff","patch_url":"https://github.com/d3athrow/vgstation13/pull/2001.patch","issue_url":"https://api.github.com/repos/d3athrow/vgstation13/issues/2001","number":2001,"state":"closed","locked":false,"title":"Spell code rework","user":{"login":"ComicIronic","id":7339857,"avatar_url":"https://avatars.githubusercontent.com/u/7339857?v=3","gravatar_id":"","url":"https://api.github.com/users/ComicIronic","html_url":"https://github.com/ComicIronic","followers_url":"https://api.github.com/users/ComicIronic/followers","following_url":"https://api.github.com/users/ComicIronic/following{/other_user}","gists_url":"https://api.github.com/users/ComicIronic/gists{/gist_id}","starred_url":"https://api.github.com/users/ComicIronic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ComicIronic/subscriptions","organizations_url":"https://api.github.com/users/ComicIronic/orgs","repos_url":"https://api.github.com/users/ComicIronic/repos","events_url":"https://api.github.com/users/ComicIronic/events{/privacy}","received_events_url":"https://api.github.com/users/ComicIronic/received_events","type":"User","site_admin":false},"body":"- Moved some code into a new spells module for easier access and more sensible directory work, redid several spells to work under a standard system.\r\n- Switched spells from targeted to aoe_turf and aoe_turf to targeted (or removed them from either subtype completely) as appropriate.\r\n- Make spell projectiles actually be projectiles, with a special kind of spell projectile able to follow its original target. Spell projectiles call a spell's new proc when they get in range\r\n- Removed all instances of trigger spells. Inflict hander has been merged into targeted, with the destruction code divvied among the corresponding spells since it had no reason to be general other than a lack of sensible OOP.\r\n- Added baseline procs for quickening or empowering spells, which can now be limited in either way to a max level and in for a combined max level. Spells can now be quickened in a special way, or use the general system. Lays groundwork for items being able to edit spells\r\n\r\nFundamentally intended to be identical to current system at frontend.\r\n\r\nMainly opened this to have a look at.\r\nTODO:\r\n- [x] Comment new additions and systems, as well as clarify current code\r\n- [x] Apply bitflag system to certain vars in spells\r\n- [x] Test <s>all</s> transferred spells.\r\n- [ ] Test the untestable, do the undoable","created_at":"2014-11-28T17:50:05Z","updated_at":"2015-02-12T20:46:25Z","closed_at":"2015-02-12T20:46:25Z","merged_at":"2015-02-12T20:46:25Z","merge_commit_sha":"2e9c3150af3b953a4e72a90072a470c1297bce88","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/d3athrow/vgstation13/pulls/2001/commits","review_comments_url":"https://api.github.com/repos/d3athrow/vgstation13/pulls/2001/comments","review_comment_url":"https://api.github.com/repos/d3athrow/vgstation13/pulls/comments/{number}","comments_url":"https://api.github.com/repos/d3athrow/vgstation13/issues/2001/comments","statuses_url":"https://api.github.com/repos/d3athrow/vgstation13/statuses/b146932ce32cb057fc99f00f2567e154b3d1804e","head":{"label":"ComicIronic:WizzyCode","ref":"WizzyCode","sha":"b146932ce32cb057fc99f00f2567e154b3d1804e","user":{"login":"ComicIronic","id":7339857,"avatar_url":"https://avatars.githubusercontent.com/u/7339857?v=3","gravatar_id":"","url":"https://api.github.com/users/ComicIronic","html_url":"https://github.com/ComicIronic","followers_url":"https://api.github.com/users/ComicIronic/followers","following_url":"https://api.github.com/users/ComicIronic/following{/other_user}","gists_url":"https://api.github.com/users/ComicIronic/gists{/gist_id}","starred_url":"https://api.github.com/users/ComicIronic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ComicIronic/subscriptions","organizations_url":"https://api.github.com/users/ComicIronic/orgs","repos_url":"https://api.github.com/users/ComicIronic/repos","events_url":"https://api.github.com/users/ComicIronic/events{/privacy}","received_events_url":"https://api.github.com/users/ComicIronic/received_events","type":"User","site_admin":false},"repo":{"id":24029746,"name":"vgstation13","full_name":"ComicIronic/vgstation13","owner":{"login":"ComicIronic","id":7339857,"avatar_url":"https://avatars.githubusercontent.com/u/7339857?v=3","gravatar_id":"","url":"https://api.github.com/users/ComicIronic","html_url":"https://github.com/ComicIronic","followers_url":"https://api.github.com/users/ComicIronic/followers","following_url":"https://api.github.com/users/ComicIronic/following{/other_user}","gists_url":"https://api.github.com/users/ComicIronic/gists{/gist_id}","starred_url":"https://api.github.com/users/ComicIronic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ComicIronic/subscriptions","organizations_url":"https://api.github.com/users/ComicIronic/orgs","repos_url":"https://api.github.com/users/ComicIronic/repos","events_url":"https://api.github.com/users/ComicIronic/events{/privacy}","received_events_url":"https://api.github.com/users/ComicIronic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ComicIronic/vgstation13","description":"This is the vgstation's fork of baystation12's code.","fork":true,"url":"https://api.github.com/repos/ComicIronic/vgstation13","forks_url":"https://api.github.com/repos/ComicIronic/vgstation13/forks","keys_url":"https://api.github.com/repos/ComicIronic/vgstation13/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ComicIronic/vgstation13/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ComicIronic/vgstation13/teams","hooks_url":"https://api.github.com/repos/ComicIronic/vgstation13/hooks","issue_events_url":"https://api.github.com/repos/ComicIronic/vgstation13/issues/events{/number}","events_url":"https://api.github.com/repos/ComicIronic/vgstation13/events","assignees_url":"https://api.github.com/repos/ComicIronic/vgstation13/assignees{/user}","branches_url":"https://api.github.com/repos/ComicIronic/vgstation13/branches{/branch}","tags_url":"https://api.github.com/repos/ComicIronic/vgstation13/tags","blobs_url":"https://api.github.com/repos/ComicIronic/vgstation13/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ComicIronic/vgstation13/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ComicIronic/vgstation13/git/refs{/sha}","trees_url":"https://api.github.com/repos/ComicIronic/vgstation13/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ComicIronic/vgstation13/statuses/{sha}","languages_url":"https://api.github.com/repos/ComicIronic/vgstation13/languages","stargazers_url":"https://api.github.com/repos/ComicIronic/vgstation13/stargazers","contributors_url":"https://api.github.com/repos/ComicIronic/vgstation13/contributors","subscribers_url":"https://api.github.com/repos/ComicIronic/vgstation13/subscribers","subscription_url":"https://api.github.com/repos/ComicIronic/vgstation13/subscription","commits_url":"https://api.github.com/repos/ComicIronic/vgstation13/commits{/sha}","git_commits_url":"https://api.github.com/repos/ComicIronic/vgstation13/git/commits{/sha}","comments_url":"https://api.github.com/repos/ComicIronic/vgstation13/comments{/number}","issue_comment_url":"https://api.github.com/repos/ComicIronic/vgstation13/issues/comments/{number}","contents_url":"https://api.github.com/repos/ComicIronic/vgstation13/contents/{+path}","compare_url":"https://api.github.com/repos/ComicIronic/vgstation13/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ComicIronic/vgstation13/merges","archive_url":"https://api.github.com/repos/ComicIronic/vgstation13/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ComicIronic/vgstation13/downloads","issues_url":"https://api.github.com/repos/ComicIronic/vgstation13/issues{/number}","pulls_url":"https://api.github.com/repos/ComicIronic/vgstation13/pulls{/number}","milestones_url":"https://api.github.com/repos/ComicIronic/vgstation13/milestones{/number}","notifications_url":"https://api.github.com/repos/ComicIronic/vgstation13/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ComicIronic/vgstation13/labels{/name}","releases_url":"https://api.github.com/repos/ComicIronic/vgstation13/releases{/id}","created_at":"2014-09-14T18:33:39Z","updated_at":"2014-09-30T19:26:37Z","pushed_at":"2015-02-12T20:33:00Z","git_url":"git://github.com/ComicIronic/vgstation13.git","ssh_url":"git@github.com:ComicIronic/vgstation13.git","clone_url":"https://github.com/ComicIronic/vgstation13.git","svn_url":"https://github.com/ComicIronic/vgstation13","homepage":"","size":807471,"stargazers_count":0,"watchers_count":0,"language":"DM","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"d3athrow:Bleeding-Edge","ref":"Bleeding-Edge","sha":"9267cf3cdbcee53894b9b8d054931df21967efd0","user":{"login":"d3athrow","id":706947,"avatar_url":"https://avatars.githubusercontent.com/u/706947?v=3","gravatar_id":"","url":"https://api.github.com/users/d3athrow","html_url":"https://github.com/d3athrow","followers_url":"https://api.github.com/users/d3athrow/followers","following_url":"https://api.github.com/users/d3athrow/following{/other_user}","gists_url":"https://api.github.com/users/d3athrow/gists{/gist_id}","starred_url":"https://api.github.com/users/d3athrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d3athrow/subscriptions","organizations_url":"https://api.github.com/users/d3athrow/orgs","repos_url":"https://api.github.com/users/d3athrow/repos","events_url":"https://api.github.com/users/d3athrow/events{/privacy}","received_events_url":"https://api.github.com/users/d3athrow/received_events","type":"User","site_admin":false},"repo":{"id":10441188,"name":"vgstation13","full_name":"d3athrow/vgstation13","owner":{"login":"d3athrow","id":706947,"avatar_url":"https://avatars.githubusercontent.com/u/706947?v=3","gravatar_id":"","url":"https://api.github.com/users/d3athrow","html_url":"https://github.com/d3athrow","followers_url":"https://api.github.com/users/d3athrow/followers","following_url":"https://api.github.com/users/d3athrow/following{/other_user}","gists_url":"https://api.github.com/users/d3athrow/gists{/gist_id}","starred_url":"https://api.github.com/users/d3athrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d3athrow/subscriptions","organizations_url":"https://api.github.com/users/d3athrow/orgs","repos_url":"https://api.github.com/users/d3athrow/repos","events_url":"https://api.github.com/users/d3athrow/events{/privacy}","received_events_url":"https://api.github.com/users/d3athrow/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/d3athrow/vgstation13","description":"This is the vgstation's fork of baystation12's code.","fork":true,"url":"https://api.github.com/repos/d3athrow/vgstation13","forks_url":"https://api.github.com/repos/d3athrow/vgstation13/forks","keys_url":"https://api.github.com/repos/d3athrow/vgstation13/keys{/key_id}","collaborators_url":"https://api.github.com/repos/d3athrow/vgstation13/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/d3athrow/vgstation13/teams","hooks_url":"https://api.github.com/repos/d3athrow/vgstation13/hooks","issue_events_url":"https://api.github.com/repos/d3athrow/vgstation13/issues/events{/number}","events_url":"https://api.github.com/repos/d3athrow/vgstation13/events","assignees_url":"https://api.github.com/repos/d3athrow/vgstation13/assignees{/user}","branches_url":"https://api.github.com/repos/d3athrow/vgstation13/branches{/branch}","tags_url":"https://api.github.com/repos/d3athrow/vgstation13/tags","blobs_url":"https://api.github.com/repos/d3athrow/vgstation13/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/d3athrow/vgstation13/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/d3athrow/vgstation13/git/refs{/sha}","trees_url":"https://api.github.com/repos/d3athrow/vgstation13/git/trees{/sha}","statuses_url":"https://api.github.com/repos/d3athrow/vgstation13/statuses/{sha}","languages_url":"https://api.github.com/repos/d3athrow/vgstation13/languages","stargazers_url":"https://api.github.com/repos/d3athrow/vgstation13/stargazers","contributors_url":"https://api.github.com/repos/d3athrow/vgstation13/contributors","subscribers_url":"https://api.github.com/repos/d3athrow/vgstation13/subscribers","subscription_url":"https://api.github.com/repos/d3athrow/vgstation13/subscription","commits_url":"https://api.github.com/repos/d3athrow/vgstation13/commits{/sha}","git_commits_url":"https://api.github.com/repos/d3athrow/vgstation13/git/commits{/sha}","comments_url":"https://api.github.com/repos/d3athrow/vgstation13/comments{/number}","issue_comment_url":"https://api.github.com/repos/d3athrow/vgstation13/issues/comments/{number}","contents_url":"https://api.github.com/repos/d3athrow/vgstation13/contents/{+path}","compare_url":"https://api.github.com/repos/d3athrow/vgstation13/compare/{base}...{head}","merges_url":"https://api.github.com/repos/d3athrow/vgstation13/merges","archive_url":"https://api.github.com/repos/d3athrow/vgstation13/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/d3athrow/vgstation13/downloads","issues_url":"https://api.github.com/repos/d3athrow/vgstation13/issues{/number}","pulls_url":"https://api.github.com/repos/d3athrow/vgstation13/pulls{/number}","milestones_url":"https://api.github.com/repos/d3athrow/vgstation13/milestones{/number}","notifications_url":"https://api.github.com/repos/d3athrow/vgstation13/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/d3athrow/vgstation13/labels{/name}","releases_url":"https://api.github.com/repos/d3athrow/vgstation13/releases{/id}","created_at":"2013-06-02T19:39:54Z","updated_at":"2015-02-12T19:47:03Z","pushed_at":"2015-02-12T20:46:25Z","git_url":"git://github.com/d3athrow/vgstation13.git","ssh_url":"git@github.com:d3athrow/vgstation13.git","clone_url":"https://github.com/d3athrow/vgstation13.git","svn_url":"https://github.com/d3athrow/vgstation13","homepage":"","size":970480,"stargazers_count":50,"watchers_count":50,"language":"DM","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":146,"mirror_url":null,"open_issues_count":264,"forks":146,"open_issues":264,"watchers":50,"default_branch":"Bleeding-Edge"}},"_links":{"self":{"href":"https://api.github.com/repos/d3athrow/vgstation13/pulls/2001"},"html":{"href":"https://github.com/d3athrow/vgstation13/pull/2001"},"issue":{"href":"https://api.github.com/repos/d3athrow/vgstation13/issues/2001"},"comments":{"href":"https://api.github.com/repos/d3athrow/vgstation13/issues/2001/comments"},"review_comments":{"href":"https://api.github.com/repos/d3athrow/vgstation13/pulls/2001/comments"},"review_comment":{"href":"https://api.github.com/repos/d3athrow/vgstation13/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/d3athrow/vgstation13/pulls/2001/commits"},"statuses":{"href":"https://api.github.com/repos/d3athrow/vgstation13/statuses/b146932ce32cb057fc99f00f2567e154b3d1804e"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"ririchiyo","id":1674740,"avatar_url":"https://avatars.githubusercontent.com/u/1674740?v=3","gravatar_id":"","url":"https://api.github.com/users/ririchiyo","html_url":"https://github.com/ririchiyo","followers_url":"https://api.github.com/users/ririchiyo/followers","following_url":"https://api.github.com/users/ririchiyo/following{/other_user}","gists_url":"https://api.github.com/users/ririchiyo/gists{/gist_id}","starred_url":"https://api.github.com/users/ririchiyo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ririchiyo/subscriptions","organizations_url":"https://api.github.com/users/ririchiyo/orgs","repos_url":"https://api.github.com/users/ririchiyo/repos","events_url":"https://api.github.com/users/ririchiyo/events{/privacy}","received_events_url":"https://api.github.com/users/ririchiyo/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":9,"additions":1988,"deletions":2222,"changed_files":68}}