{"action":"created","comment":{"url":"https://api.github.com/repos/letsencrypt/acme-spec/pulls/comments/31883732","id":31883732,"diff_hunk":"@@ -222,6 +241,39 @@ To revoke a certificate, the client simply sends a revocation request, signed wi\n \n Note that while ACME is defined with enough flexibility to handle different types of identifiers in principle, the primary use case addressed by this document is the case where domain names are used as identifiers.  For example, all of the identifier validation challenges described in Section {identifier-validation-challenges} below address validation of domain names.  The use of ACME for other protocols will require further specification, in order to describe how these identifiers are encoded in the protocol, and what types of validation challenges the server might require.\n \n+# Replay protection","path":"draft-barnes-acme.md","position":57,"original_position":57,"commit_id":"d3aca742595cd0e380a22a455b245bb0ecb3cc1b","original_commit_id":"d3aca742595cd0e380a22a455b245bb0ecb3cc1b","user":{"login":"bifurcation","id":75597,"avatar_url":"https://avatars.githubusercontent.com/u/75597?v=3","gravatar_id":"","url":"https://api.github.com/users/bifurcation","html_url":"https://github.com/bifurcation","followers_url":"https://api.github.com/users/bifurcation/followers","following_url":"https://api.github.com/users/bifurcation/following{/other_user}","gists_url":"https://api.github.com/users/bifurcation/gists{/gist_id}","starred_url":"https://api.github.com/users/bifurcation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bifurcation/subscriptions","organizations_url":"https://api.github.com/users/bifurcation/orgs","repos_url":"https://api.github.com/users/bifurcation/repos","events_url":"https://api.github.com/users/bifurcation/events{/privacy}","received_events_url":"https://api.github.com/users/bifurcation/received_events","type":"User","site_admin":false},"body":"+1\r\n\r\nSuggest moving between \"Resources and Requests\" and \"Errors\"","created_at":"2015-06-08T01:36:03Z","updated_at":"2015-06-08T01:36:03Z","html_url":"https://github.com/letsencrypt/acme-spec/pull/140#discussion_r31883732","pull_request_url":"https://api.github.com/repos/letsencrypt/acme-spec/pulls/140","_links":{"self":{"href":"https://api.github.com/repos/letsencrypt/acme-spec/pulls/comments/31883732"},"html":{"href":"https://github.com/letsencrypt/acme-spec/pull/140#discussion_r31883732"},"pull_request":{"href":"https://api.github.com/repos/letsencrypt/acme-spec/pulls/140"}}},"pull_request":{"url":"https://api.github.com/repos/letsencrypt/acme-spec/pulls/140","id":37077201,"html_url":"https://github.com/letsencrypt/acme-spec/pull/140","diff_url":"https://github.com/letsencrypt/acme-spec/pull/140.diff","patch_url":"https://github.com/letsencrypt/acme-spec/pull/140.patch","issue_url":"https://api.github.com/repos/letsencrypt/acme-spec/issues/140","number":140,"state":"open","locked":false,"title":"Add replay protection and a threat model.","user":{"login":"jsha","id":220205,"avatar_url":"https://avatars.githubusercontent.com/u/220205?v=3","gravatar_id":"","url":"https://api.github.com/users/jsha","html_url":"https://github.com/jsha","followers_url":"https://api.github.com/users/jsha/followers","following_url":"https://api.github.com/users/jsha/following{/other_user}","gists_url":"https://api.github.com/users/jsha/gists{/gist_id}","starred_url":"https://api.github.com/users/jsha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsha/subscriptions","organizations_url":"https://api.github.com/users/jsha/orgs","repos_url":"https://api.github.com/users/jsha/repos","events_url":"https://api.github.com/users/jsha/events{/privacy}","received_events_url":"https://api.github.com/users/jsha/received_events","type":"User","site_admin":false},"body":"This is a first pass at the replay protection we discussed on the mailing list.\r\n\r\nFixes https://github.com/letsencrypt/acme-spec/issues/122\r\nRelated to https://github.com/letsencrypt/boulder/issues/165","created_at":"2015-06-05T22:55:42Z","updated_at":"2015-06-08T01:36:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cdcceb136224f09f697c434426305409f0aeb5a5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/letsencrypt/acme-spec/pulls/140/commits","review_comments_url":"https://api.github.com/repos/letsencrypt/acme-spec/pulls/140/comments","review_comment_url":"https://api.github.com/repos/letsencrypt/acme-spec/pulls/comments{/number}","comments_url":"https://api.github.com/repos/letsencrypt/acme-spec/issues/140/comments","statuses_url":"https://api.github.com/repos/letsencrypt/acme-spec/statuses/d3aca742595cd0e380a22a455b245bb0ecb3cc1b","head":{"label":"letsencrypt:replay","ref":"replay","sha":"d3aca742595cd0e380a22a455b245bb0ecb3cc1b","user":{"login":"letsencrypt","id":9289019,"avatar_url":"https://avatars.githubusercontent.com/u/9289019?v=3","gravatar_id":"","url":"https://api.github.com/users/letsencrypt","html_url":"https://github.com/letsencrypt","followers_url":"https://api.github.com/users/letsencrypt/followers","following_url":"https://api.github.com/users/letsencrypt/following{/other_user}","gists_url":"https://api.github.com/users/letsencrypt/gists{/gist_id}","starred_url":"https://api.github.com/users/letsencrypt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/letsencrypt/subscriptions","organizations_url":"https://api.github.com/users/letsencrypt/orgs","repos_url":"https://api.github.com/users/letsencrypt/repos","events_url":"https://api.github.com/users/letsencrypt/events{/privacy}","received_events_url":"https://api.github.com/users/letsencrypt/received_events","type":"Organization","site_admin":false},"repo":{"id":25449702,"name":"acme-spec","full_name":"letsencrypt/acme-spec","owner":{"login":"letsencrypt","id":9289019,"avatar_url":"https://avatars.githubusercontent.com/u/9289019?v=3","gravatar_id":"","url":"https://api.github.com/users/letsencrypt","html_url":"https://github.com/letsencrypt","followers_url":"https://api.github.com/users/letsencrypt/followers","following_url":"https://api.github.com/users/letsencrypt/following{/other_user}","gists_url":"https://api.github.com/users/letsencrypt/gists{/gist_id}","starred_url":"https://api.github.com/users/letsencrypt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/letsencrypt/subscriptions","organizations_url":"https://api.github.com/users/letsencrypt/orgs","repos_url":"https://api.github.com/users/letsencrypt/repos","events_url":"https://api.github.com/users/letsencrypt/events{/privacy}","received_events_url":"https://api.github.com/users/letsencrypt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/letsencrypt/acme-spec","description":"ACME Specification","fork":false,"url":"https://api.github.com/repos/letsencrypt/acme-spec","forks_url":"https://api.github.com/repos/letsencrypt/acme-spec/forks","keys_url":"https://api.github.com/repos/letsencrypt/acme-spec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/letsencrypt/acme-spec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/letsencrypt/acme-spec/teams","hooks_url":"https://api.github.com/repos/letsencrypt/acme-spec/hooks","issue_events_url":"https://api.github.com/repos/letsencrypt/acme-spec/issues/events{/number}","events_url":"https://api.github.com/repos/letsencrypt/acme-spec/events","assignees_url":"https://api.github.com/repos/letsencrypt/acme-spec/assignees{/user}","branches_url":"https://api.github.com/repos/letsencrypt/acme-spec/branches{/branch}","tags_url":"https://api.github.com/repos/letsencrypt/acme-spec/tags","blobs_url":"https://api.github.com/repos/letsencrypt/acme-spec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/letsencrypt/acme-spec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/letsencrypt/acme-spec/git/refs{/sha}","trees_url":"https://api.github.com/repos/letsencrypt/acme-spec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/letsencrypt/acme-spec/statuses/{sha}","languages_url":"https://api.github.com/repos/letsencrypt/acme-spec/languages","stargazers_url":"https://api.github.com/repos/letsencrypt/acme-spec/stargazers","contributors_url":"https://api.github.com/repos/letsencrypt/acme-spec/contributors","subscribers_url":"https://api.github.com/repos/letsencrypt/acme-spec/subscribers","subscription_url":"https://api.github.com/repos/letsencrypt/acme-spec/subscription","commits_url":"https://api.github.com/repos/letsencrypt/acme-spec/commits{/sha}","git_commits_url":"https://api.github.com/repos/letsencrypt/acme-spec/git/commits{/sha}","comments_url":"https://api.github.com/repos/letsencrypt/acme-spec/comments{/number}","issue_comment_url":"https://api.github.com/repos/letsencrypt/acme-spec/issues/comments{/number}","contents_url":"https://api.github.com/repos/letsencrypt/acme-spec/contents/{+path}","compare_url":"https://api.github.com/repos/letsencrypt/acme-spec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/letsencrypt/acme-spec/merges","archive_url":"https://api.github.com/repos/letsencrypt/acme-spec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/letsencrypt/acme-spec/downloads","issues_url":"https://api.github.com/repos/letsencrypt/acme-spec/issues{/number}","pulls_url":"https://api.github.com/repos/letsencrypt/acme-spec/pulls{/number}","milestones_url":"https://api.github.com/repos/letsencrypt/acme-spec/milestones{/number}","notifications_url":"https://api.github.com/repos/letsencrypt/acme-spec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/letsencrypt/acme-spec/labels{/name}","releases_url":"https://api.github.com/repos/letsencrypt/acme-spec/releases{/id}","created_at":"2014-10-20T03:43:00Z","updated_at":"2015-06-08T00:33:11Z","pushed_at":"2015-06-08T01:15:10Z","git_url":"git://github.com/letsencrypt/acme-spec.git","ssh_url":"git@github.com:letsencrypt/acme-spec.git","clone_url":"https://github.com/letsencrypt/acme-spec.git","svn_url":"https://github.com/letsencrypt/acme-spec","homepage":null,"size":1226,"stargazers_count":738,"watchers_count":738,"language":"Makefile","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":65,"mirror_url":null,"open_issues_count":68,"forks":65,"open_issues":68,"watchers":738,"default_branch":"master"}},"base":{"label":"letsencrypt:master","ref":"master","sha":"82bb374a6116f66a45a459857ca9463fe9df28d0","user":{"login":"letsencrypt","id":9289019,"avatar_url":"https://avatars.githubusercontent.com/u/9289019?v=3","gravatar_id":"","url":"https://api.github.com/users/letsencrypt","html_url":"https://github.com/letsencrypt","followers_url":"https://api.github.com/users/letsencrypt/followers","following_url":"https://api.github.com/users/letsencrypt/following{/other_user}","gists_url":"https://api.github.com/users/letsencrypt/gists{/gist_id}","starred_url":"https://api.github.com/users/letsencrypt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/letsencrypt/subscriptions","organizations_url":"https://api.github.com/users/letsencrypt/orgs","repos_url":"https://api.github.com/users/letsencrypt/repos","events_url":"https://api.github.com/users/letsencrypt/events{/privacy}","received_events_url":"https://api.github.com/users/letsencrypt/received_events","type":"Organization","site_admin":false},"repo":{"id":25449702,"name":"acme-spec","full_name":"letsencrypt/acme-spec","owner":{"login":"letsencrypt","id":9289019,"avatar_url":"https://avatars.githubusercontent.com/u/9289019?v=3","gravatar_id":"","url":"https://api.github.com/users/letsencrypt","html_url":"https://github.com/letsencrypt","followers_url":"https://api.github.com/users/letsencrypt/followers","following_url":"https://api.github.com/users/letsencrypt/following{/other_user}","gists_url":"https://api.github.com/users/letsencrypt/gists{/gist_id}","starred_url":"https://api.github.com/users/letsencrypt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/letsencrypt/subscriptions","organizations_url":"https://api.github.com/users/letsencrypt/orgs","repos_url":"https://api.github.com/users/letsencrypt/repos","events_url":"https://api.github.com/users/letsencrypt/events{/privacy}","received_events_url":"https://api.github.com/users/letsencrypt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/letsencrypt/acme-spec","description":"ACME Specification","fork":false,"url":"https://api.github.com/repos/letsencrypt/acme-spec","forks_url":"https://api.github.com/repos/letsencrypt/acme-spec/forks","keys_url":"https://api.github.com/repos/letsencrypt/acme-spec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/letsencrypt/acme-spec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/letsencrypt/acme-spec/teams","hooks_url":"https://api.github.com/repos/letsencrypt/acme-spec/hooks","issue_events_url":"https://api.github.com/repos/letsencrypt/acme-spec/issues/events{/number}","events_url":"https://api.github.com/repos/letsencrypt/acme-spec/events","assignees_url":"https://api.github.com/repos/letsencrypt/acme-spec/assignees{/user}","branches_url":"https://api.github.com/repos/letsencrypt/acme-spec/branches{/branch}","tags_url":"https://api.github.com/repos/letsencrypt/acme-spec/tags","blobs_url":"https://api.github.com/repos/letsencrypt/acme-spec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/letsencrypt/acme-spec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/letsencrypt/acme-spec/git/refs{/sha}","trees_url":"https://api.github.com/repos/letsencrypt/acme-spec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/letsencrypt/acme-spec/statuses/{sha}","languages_url":"https://api.github.com/repos/letsencrypt/acme-spec/languages","stargazers_url":"https://api.github.com/repos/letsencrypt/acme-spec/stargazers","contributors_url":"https://api.github.com/repos/letsencrypt/acme-spec/contributors","subscribers_url":"https://api.github.com/repos/letsencrypt/acme-spec/subscribers","subscription_url":"https://api.github.com/repos/letsencrypt/acme-spec/subscription","commits_url":"https://api.github.com/repos/letsencrypt/acme-spec/commits{/sha}","git_commits_url":"https://api.github.com/repos/letsencrypt/acme-spec/git/commits{/sha}","comments_url":"https://api.github.com/repos/letsencrypt/acme-spec/comments{/number}","issue_comment_url":"https://api.github.com/repos/letsencrypt/acme-spec/issues/comments{/number}","contents_url":"https://api.github.com/repos/letsencrypt/acme-spec/contents/{+path}","compare_url":"https://api.github.com/repos/letsencrypt/acme-spec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/letsencrypt/acme-spec/merges","archive_url":"https://api.github.com/repos/letsencrypt/acme-spec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/letsencrypt/acme-spec/downloads","issues_url":"https://api.github.com/repos/letsencrypt/acme-spec/issues{/number}","pulls_url":"https://api.github.com/repos/letsencrypt/acme-spec/pulls{/number}","milestones_url":"https://api.github.com/repos/letsencrypt/acme-spec/milestones{/number}","notifications_url":"https://api.github.com/repos/letsencrypt/acme-spec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/letsencrypt/acme-spec/labels{/name}","releases_url":"https://api.github.com/repos/letsencrypt/acme-spec/releases{/id}","created_at":"2014-10-20T03:43:00Z","updated_at":"2015-06-08T00:33:11Z","pushed_at":"2015-06-08T01:15:10Z","git_url":"git://github.com/letsencrypt/acme-spec.git","ssh_url":"git@github.com:letsencrypt/acme-spec.git","clone_url":"https://github.com/letsencrypt/acme-spec.git","svn_url":"https://github.com/letsencrypt/acme-spec","homepage":null,"size":1226,"stargazers_count":738,"watchers_count":738,"language":"Makefile","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":65,"mirror_url":null,"open_issues_count":68,"forks":65,"open_issues":68,"watchers":738,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/letsencrypt/acme-spec/pulls/140"},"html":{"href":"https://github.com/letsencrypt/acme-spec/pull/140"},"issue":{"href":"https://api.github.com/repos/letsencrypt/acme-spec/issues/140"},"comments":{"href":"https://api.github.com/repos/letsencrypt/acme-spec/issues/140/comments"},"review_comments":{"href":"https://api.github.com/repos/letsencrypt/acme-spec/pulls/140/comments"},"review_comment":{"href":"https://api.github.com/repos/letsencrypt/acme-spec/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/letsencrypt/acme-spec/pulls/140/commits"},"statuses":{"href":"https://api.github.com/repos/letsencrypt/acme-spec/statuses/d3aca742595cd0e380a22a455b245bb0ecb3cc1b"}}}}