{"action":"created","comment":{"url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/pulls/comments/34224340","id":34224340,"diff_hunk":"@@ -17,6 +17,10 @@ define(['angular'], function(angular) {\n             'crest' : 'img/uwcrest_web_sm.png',\n             'crestalt' : 'UW Crest'\n         })\n+        .constant('SEARCH',{\n+            'isWeb' : false,","path":"angularjs-portal-frame/src/main/webapp/js/app-config.js","position":5,"original_position":5,"commit_id":"c73ec517b4daab5311d1768ca5de5f44667f1cd9","original_commit_id":"c73ec517b4daab5311d1768ca5de5f44667f1cd9","user":{"login":"apetro","id":952283,"avatar_url":"https://avatars.githubusercontent.com/u/952283?v=3","gravatar_id":"","url":"https://api.github.com/users/apetro","html_url":"https://github.com/apetro","followers_url":"https://api.github.com/users/apetro/followers","following_url":"https://api.github.com/users/apetro/following{/other_user}","gists_url":"https://api.github.com/users/apetro/gists{/gist_id}","starred_url":"https://api.github.com/users/apetro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apetro/subscriptions","organizations_url":"https://api.github.com/users/apetro/orgs","repos_url":"https://api.github.com/users/apetro/repos","events_url":"https://api.github.com/users/apetro/events{/privacy}","received_events_url":"https://api.github.com/users/apetro/received_events","type":"User","site_admin":false},"body":"I wonder if web-ness is going to end up being a concept applicable more broadly than in search.  I'm fine with it starting here where angularjs-portal is prepared to take advantage of the concept today, and refactor it out if it ever turns out to be a wider thing.","created_at":"2015-07-09T05:18:19Z","updated_at":"2015-07-09T05:18:19Z","html_url":"https://github.com/UW-Madison-DoIT/angularjs-portal/pull/243#discussion_r34224340","pull_request_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/pulls/243","_links":{"self":{"href":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/pulls/comments/34224340"},"html":{"href":"https://github.com/UW-Madison-DoIT/angularjs-portal/pull/243#discussion_r34224340"},"pull_request":{"href":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/pulls/243"}}},"pull_request":{"url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/pulls/243","id":39530099,"html_url":"https://github.com/UW-Madison-DoIT/angularjs-portal/pull/243","diff_url":"https://github.com/UW-Madison-DoIT/angularjs-portal/pull/243.diff","patch_url":"https://github.com/UW-Madison-DoIT/angularjs-portal/pull/243.patch","issue_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/issues/243","number":243,"state":"open","locked":false,"title":"MUMUP-1943 : Add configuration to get frame apps search to work","user":{"login":"timlevett","id":3534544,"avatar_url":"https://avatars.githubusercontent.com/u/3534544?v=3","gravatar_id":"","url":"https://api.github.com/users/timlevett","html_url":"https://github.com/timlevett","followers_url":"https://api.github.com/users/timlevett/followers","following_url":"https://api.github.com/users/timlevett/following{/other_user}","gists_url":"https://api.github.com/users/timlevett/gists{/gist_id}","starred_url":"https://api.github.com/users/timlevett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timlevett/subscriptions","organizations_url":"https://api.github.com/users/timlevett/orgs","repos_url":"https://api.github.com/users/timlevett/repos","events_url":"https://api.github.com/users/timlevett/events{/privacy}","received_events_url":"https://api.github.com/users/timlevett/received_events","type":"User","site_admin":false},"body":"Basically adds a redirect if its a frame app.  Has a shortcut for `/web` to avoid page refresh.","created_at":"2015-07-08T22:21:26Z","updated_at":"2015-07-09T05:18:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f0f1bc36821f0b4f05f59d0716833f841795fe10","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/pulls/243/commits","review_comments_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/pulls/243/comments","review_comment_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/issues/243/comments","statuses_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/statuses/c73ec517b4daab5311d1768ca5de5f44667f1cd9","head":{"label":"UW-Madison-DoIT:make_search_work_on_frame","ref":"make_search_work_on_frame","sha":"c73ec517b4daab5311d1768ca5de5f44667f1cd9","user":{"login":"UW-Madison-DoIT","id":1629635,"avatar_url":"https://avatars.githubusercontent.com/u/1629635?v=3","gravatar_id":"","url":"https://api.github.com/users/UW-Madison-DoIT","html_url":"https://github.com/UW-Madison-DoIT","followers_url":"https://api.github.com/users/UW-Madison-DoIT/followers","following_url":"https://api.github.com/users/UW-Madison-DoIT/following{/other_user}","gists_url":"https://api.github.com/users/UW-Madison-DoIT/gists{/gist_id}","starred_url":"https://api.github.com/users/UW-Madison-DoIT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UW-Madison-DoIT/subscriptions","organizations_url":"https://api.github.com/users/UW-Madison-DoIT/orgs","repos_url":"https://api.github.com/users/UW-Madison-DoIT/repos","events_url":"https://api.github.com/users/UW-Madison-DoIT/events{/privacy}","received_events_url":"https://api.github.com/users/UW-Madison-DoIT/received_events","type":"Organization","site_admin":false},"repo":{"id":24428594,"name":"angularjs-portal","full_name":"UW-Madison-DoIT/angularjs-portal","owner":{"login":"UW-Madison-DoIT","id":1629635,"avatar_url":"https://avatars.githubusercontent.com/u/1629635?v=3","gravatar_id":"","url":"https://api.github.com/users/UW-Madison-DoIT","html_url":"https://github.com/UW-Madison-DoIT","followers_url":"https://api.github.com/users/UW-Madison-DoIT/followers","following_url":"https://api.github.com/users/UW-Madison-DoIT/following{/other_user}","gists_url":"https://api.github.com/users/UW-Madison-DoIT/gists{/gist_id}","starred_url":"https://api.github.com/users/UW-Madison-DoIT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UW-Madison-DoIT/subscriptions","organizations_url":"https://api.github.com/users/UW-Madison-DoIT/orgs","repos_url":"https://api.github.com/users/UW-Madison-DoIT/repos","events_url":"https://api.github.com/users/UW-Madison-DoIT/events{/privacy}","received_events_url":"https://api.github.com/users/UW-Madison-DoIT/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/UW-Madison-DoIT/angularjs-portal","description":"AngularJS alternative UI for MyUW portal (built for uPortal).","fork":false,"url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal","forks_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/forks","keys_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/teams","hooks_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/hooks","issue_events_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/issues/events{/number}","events_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/events","assignees_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/assignees{/user}","branches_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/branches{/branch}","tags_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/tags","blobs_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/languages","stargazers_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/stargazers","contributors_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/contributors","subscribers_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/subscribers","subscription_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/subscription","commits_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/contents/{+path}","compare_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/merges","archive_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/downloads","issues_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/issues{/number}","pulls_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/labels{/name}","releases_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/releases{/id}","created_at":"2014-09-24T19:04:44Z","updated_at":"2015-07-01T13:22:14Z","pushed_at":"2015-07-08T22:21:26Z","git_url":"git://github.com/UW-Madison-DoIT/angularjs-portal.git","ssh_url":"git@github.com:UW-Madison-DoIT/angularjs-portal.git","clone_url":"https://github.com/UW-Madison-DoIT/angularjs-portal.git","svn_url":"https://github.com/UW-Madison-DoIT/angularjs-portal","homepage":"","size":13326,"stargazers_count":6,"watchers_count":6,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":3,"forks":10,"open_issues":3,"watchers":6,"default_branch":"master"}},"base":{"label":"UW-Madison-DoIT:master","ref":"master","sha":"4916dd96fc906c0ca595abeb35d6b49d8c3ac7ad","user":{"login":"UW-Madison-DoIT","id":1629635,"avatar_url":"https://avatars.githubusercontent.com/u/1629635?v=3","gravatar_id":"","url":"https://api.github.com/users/UW-Madison-DoIT","html_url":"https://github.com/UW-Madison-DoIT","followers_url":"https://api.github.com/users/UW-Madison-DoIT/followers","following_url":"https://api.github.com/users/UW-Madison-DoIT/following{/other_user}","gists_url":"https://api.github.com/users/UW-Madison-DoIT/gists{/gist_id}","starred_url":"https://api.github.com/users/UW-Madison-DoIT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UW-Madison-DoIT/subscriptions","organizations_url":"https://api.github.com/users/UW-Madison-DoIT/orgs","repos_url":"https://api.github.com/users/UW-Madison-DoIT/repos","events_url":"https://api.github.com/users/UW-Madison-DoIT/events{/privacy}","received_events_url":"https://api.github.com/users/UW-Madison-DoIT/received_events","type":"Organization","site_admin":false},"repo":{"id":24428594,"name":"angularjs-portal","full_name":"UW-Madison-DoIT/angularjs-portal","owner":{"login":"UW-Madison-DoIT","id":1629635,"avatar_url":"https://avatars.githubusercontent.com/u/1629635?v=3","gravatar_id":"","url":"https://api.github.com/users/UW-Madison-DoIT","html_url":"https://github.com/UW-Madison-DoIT","followers_url":"https://api.github.com/users/UW-Madison-DoIT/followers","following_url":"https://api.github.com/users/UW-Madison-DoIT/following{/other_user}","gists_url":"https://api.github.com/users/UW-Madison-DoIT/gists{/gist_id}","starred_url":"https://api.github.com/users/UW-Madison-DoIT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UW-Madison-DoIT/subscriptions","organizations_url":"https://api.github.com/users/UW-Madison-DoIT/orgs","repos_url":"https://api.github.com/users/UW-Madison-DoIT/repos","events_url":"https://api.github.com/users/UW-Madison-DoIT/events{/privacy}","received_events_url":"https://api.github.com/users/UW-Madison-DoIT/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/UW-Madison-DoIT/angularjs-portal","description":"AngularJS alternative UI for MyUW portal (built for uPortal).","fork":false,"url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal","forks_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/forks","keys_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/teams","hooks_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/hooks","issue_events_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/issues/events{/number}","events_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/events","assignees_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/assignees{/user}","branches_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/branches{/branch}","tags_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/tags","blobs_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/languages","stargazers_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/stargazers","contributors_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/contributors","subscribers_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/subscribers","subscription_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/subscription","commits_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/contents/{+path}","compare_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/merges","archive_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/downloads","issues_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/issues{/number}","pulls_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/labels{/name}","releases_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/releases{/id}","created_at":"2014-09-24T19:04:44Z","updated_at":"2015-07-01T13:22:14Z","pushed_at":"2015-07-08T22:21:26Z","git_url":"git://github.com/UW-Madison-DoIT/angularjs-portal.git","ssh_url":"git@github.com:UW-Madison-DoIT/angularjs-portal.git","clone_url":"https://github.com/UW-Madison-DoIT/angularjs-portal.git","svn_url":"https://github.com/UW-Madison-DoIT/angularjs-portal","homepage":"","size":13326,"stargazers_count":6,"watchers_count":6,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":3,"forks":10,"open_issues":3,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/pulls/243"},"html":{"href":"https://github.com/UW-Madison-DoIT/angularjs-portal/pull/243"},"issue":{"href":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/issues/243"},"comments":{"href":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/issues/243/comments"},"review_comments":{"href":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/pulls/243/comments"},"review_comment":{"href":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/pulls/243/commits"},"statuses":{"href":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/statuses/c73ec517b4daab5311d1768ca5de5f44667f1cd9"}}}}