{"action":"created","issue":{"url":"https://api.github.com/repos/opencontainers/specs/issues/182","labels_url":"https://api.github.com/repos/opencontainers/specs/issues/182/labels{/name}","comments_url":"https://api.github.com/repos/opencontainers/specs/issues/182/comments","events_url":"https://api.github.com/repos/opencontainers/specs/issues/182/events","html_url":"https://github.com/opencontainers/specs/pull/182","id":106140798,"number":182,"title":".tools: Add per-commit Go checks (vet, fmt, and lint)","user":{"login":"wking","id":209920,"avatar_url":"https://avatars.githubusercontent.com/u/209920?v=3","gravatar_id":"","url":"https://api.github.com/users/wking","html_url":"https://github.com/wking","followers_url":"https://api.github.com/users/wking/followers","following_url":"https://api.github.com/users/wking/following{/other_user}","gists_url":"https://api.github.com/users/wking/gists{/gist_id}","starred_url":"https://api.github.com/users/wking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wking/subscriptions","organizations_url":"https://api.github.com/users/wking/orgs","repos_url":"https://api.github.com/users/wking/repos","events_url":"https://api.github.com/users/wking/events{/privacy}","received_events_url":"https://api.github.com/users/wking/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-09-12T08:12:49Z","updated_at":"2015-10-05T19:26:09Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/opencontainers/specs/pulls/182","html_url":"https://github.com/opencontainers/specs/pull/182","diff_url":"https://github.com/opencontainers/specs/pull/182.diff","patch_url":"https://github.com/opencontainers/specs/pull/182.patch"},"body":"Instead of just checking the tip, run the checks on each commit in the\nseries.  This makes sure we catch errors with earlier commits even if\nthey were fixed by subsequent commits.\n\nThere are some details about low-level choices in the commit messages\nthemselves, but nothing that seems generic enough to be worth copying\nout to the PR level.\n\nThis PR is based on #174, because as the output gets more verbose\n(e.g. YAML blocks for golint's stdout) you'll likely want to feed it\ninto a TAP harness for compaction.  The non-verbose output is still\npretty short, although there are now more tests which you can fail ;).\n\nIf the protobuf branch lands (#179), we can swap out the Go checkers\nand swap in [protoc-gen-lint][1].  I'm not aware of any protobuf\nequivalent to 'go fmt' though, which is unfortunate.\n\n[1]: https://github.com/ckaznocha/protoc-gen-lint"},"comment":{"url":"https://api.github.com/repos/opencontainers/specs/issues/comments/145639542","html_url":"https://github.com/opencontainers/specs/pull/182#issuecomment-145639542","issue_url":"https://api.github.com/repos/opencontainers/specs/issues/182","id":145639542,"user":{"login":"vbatts","id":67049,"avatar_url":"https://avatars.githubusercontent.com/u/67049?v=3","gravatar_id":"","url":"https://api.github.com/users/vbatts","html_url":"https://github.com/vbatts","followers_url":"https://api.github.com/users/vbatts/followers","following_url":"https://api.github.com/users/vbatts/following{/other_user}","gists_url":"https://api.github.com/users/vbatts/gists{/gist_id}","starred_url":"https://api.github.com/users/vbatts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vbatts/subscriptions","organizations_url":"https://api.github.com/users/vbatts/orgs","repos_url":"https://api.github.com/users/vbatts/repos","events_url":"https://api.github.com/users/vbatts/events{/privacy}","received_events_url":"https://api.github.com/users/vbatts/received_events","type":"User","site_admin":false},"created_at":"2015-10-05T19:26:09Z","updated_at":"2015-10-05T19:26:09Z","body":"Honestly, that is not something I see a big need for a change and would be\nfine with `$?` being not zero for failure, but it already prints out a\npass/fail as well.\n\nOn Mon, Oct 5, 2015 at 3:20 PM, W. Trevor King <notifications@github.com>\nwrote:\n\n> On Mon, Oct 05, 2015 at 12:16:37PM -0700, Vincent Batts wrote:\n> > honestly. Let's keep the TAP out for now.\n>\n> Ok (although I don't see a need to invent a different output syntax).\n> What syntax would you like for pass/fail (where TAP uses \"ok\" and \"not\n> ok\")?\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/opencontainers/specs/pull/182#issuecomment-145637388>.\n>\n"}}