{"action":"created","issue":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/3513","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/3513/labels{/name}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/3513/comments","events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/3513/events","html_url":"https://github.com/cockroachdb/cockroach/pull/3513","id":123758374,"number":3513,"title":"Do not allow splits within rows.","user":{"login":"petermattis","id":6201335,"avatar_url":"https://avatars.githubusercontent.com/u/6201335?v=3","gravatar_id":"","url":"https://api.github.com/users/petermattis","html_url":"https://github.com/petermattis","followers_url":"https://api.github.com/users/petermattis/followers","following_url":"https://api.github.com/users/petermattis/following{/other_user}","gists_url":"https://api.github.com/users/petermattis/gists{/gist_id}","starred_url":"https://api.github.com/users/petermattis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petermattis/subscriptions","organizations_url":"https://api.github.com/users/petermattis/orgs","repos_url":"https://api.github.com/users/petermattis/repos","events_url":"https://api.github.com/users/petermattis/events{/privacy}","received_events_url":"https://api.github.com/users/petermattis/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-12-24T04:56:32Z","updated_at":"2015-12-26T19:51:58Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/3513","html_url":"https://github.com/cockroachdb/cockroach/pull/3513","diff_url":"https://github.com/cockroachdb/cockroach/pull/3513.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/3513.patch"},"body":"Append the column ID length to SQL generated keys. Added\nkeys.MakeSplitKey() which strips off the column ID from SQL table\nkeys. Utilize from within AdminSplit to prevent splitting within an SQL\nrow.\n\nChanged the type of client.KeyValue.Key to roachpb.Key so that the Key\nfield pretty-prints without extra effort. Similarily, changed the type\nof sql.indexEntry.key to roachpb.Key.\n\nFixes #3461.\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/cockroachdb/cockroach/3513)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments/167356498","html_url":"https://github.com/cockroachdb/cockroach/pull/3513#issuecomment-167356498","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/3513","id":167356498,"user":{"login":"petermattis","id":6201335,"avatar_url":"https://avatars.githubusercontent.com/u/6201335?v=3","gravatar_id":"","url":"https://api.github.com/users/petermattis","html_url":"https://github.com/petermattis","followers_url":"https://api.github.com/users/petermattis/followers","following_url":"https://api.github.com/users/petermattis/following{/other_user}","gists_url":"https://api.github.com/users/petermattis/gists{/gist_id}","starred_url":"https://api.github.com/users/petermattis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petermattis/subscriptions","organizations_url":"https://api.github.com/users/petermattis/orgs","repos_url":"https://api.github.com/users/petermattis/repos","events_url":"https://api.github.com/users/petermattis/events{/privacy}","received_events_url":"https://api.github.com/users/petermattis/received_events","type":"User","site_admin":false},"created_at":"2015-12-26T19:51:58Z","updated_at":"2015-12-26T19:51:58Z","body":"\n\n\n\nReview status: all files reviewed at latest revision, 3 unresolved discussions.\n\n---\n\n*[keys/keys.go, line 398 \\[r2\\]](https://reviewable.io:443/reviews/cockroachdb/cockroach/3513#-K6UNK691-gLembPbmoJ:-K6UnhTXgs4SX3D_mVug:-1574613657) ([raw file](https://github.com/cockroachdb/cockroach/blob/ad0f7ec0091acd3092d77b430e7640ea5aeed7e9/keys/keys.go#L398)):*\nNot sure how that would help the final slice below as we're slicing into `key`, not `buf`. I've expanded the comments here. \n\n---\n\n*[keys/keys.go, line 399 \\[r2\\]](https://reviewable.io:443/reviews/cockroachdb/cockroach/3513#-K6UM_3K7_gd9hzHkEYo:-K6UnppsL43X4By_MeqP:1078909596) ([raw file](https://github.com/cockroachdb/cockroach/blob/ad0f7ec0091acd3092d77b430e7640ea5aeed7e9/keys/keys.go#L399)):*\nThere are table keys passed to this routine which do not have a column ID length suffix. In particular, keys generated by `SystemConfig.ComputeSplitKeys`. I suppose I could fix the keys generated there, but it seems easier to just be permissive of the keys passed in to this routine.\n\n---\n\n\n*Comments from the [review on Reviewable.io](https://reviewable.io:443/reviews/cockroachdb/cockroach/3513)*\n<!-- Sent from Reviewable.io -->\n"}}