{"action":"created","issue":{"url":"https://api.github.com/repos/jenkinsci/jenkins/issues/1815","labels_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/1815/labels{/name}","comments_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/1815/comments","events_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/1815/events","html_url":"https://github.com/jenkinsci/jenkins/pull/1815","id":104225255,"number":1815,"title":"[JENKINS-30084] flyweighttasks added to buildables list when the executor is not available","user":{"login":"varmenise","id":5398781,"avatar_url":"https://avatars.githubusercontent.com/u/5398781?v=3","gravatar_id":"","url":"https://api.github.com/users/varmenise","html_url":"https://github.com/varmenise","followers_url":"https://api.github.com/users/varmenise/followers","following_url":"https://api.github.com/users/varmenise/following{/other_user}","gists_url":"https://api.github.com/users/varmenise/gists{/gist_id}","starred_url":"https://api.github.com/users/varmenise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/varmenise/subscriptions","organizations_url":"https://api.github.com/users/varmenise/orgs","repos_url":"https://api.github.com/users/varmenise/repos","events_url":"https://api.github.com/users/varmenise/events{/privacy}","received_events_url":"https://api.github.com/users/varmenise/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":71,"created_at":"2015-09-01T09:29:08Z","updated_at":"2015-10-19T09:21:12Z","closed_at":"2015-10-02T08:19:40Z","pull_request":{"url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/1815","html_url":"https://github.com/jenkinsci/jenkins/pull/1815","diff_url":"https://github.com/jenkinsci/jenkins/pull/1815.diff","patch_url":"https://github.com/jenkinsci/jenkins/pull/1815.patch"},"body":"This is to make the flyweight tasks to be part of the buildable list if the executor they are restricted to run on (if any) is not available and needs to be provisioned. See: [JENKINS-30084](https://issues.jenkins-ci.org/browse/JENKINS-30084)\r\n\r\nAt the moment if a flyweight task is restricted to a specific node, but the node is offline, we put the task in blocked-state. At the next iteration we check if the node is online, if not we leave the task in the blocked queue. This means we never ask the node to be provisioned.\r\n\r\nThis fix creates a buildable item if no executors are available, so that the node can be provisioned. Once the node is provisioned, the task is executed and the item removed from the list."},"comment":{"url":"https://api.github.com/repos/jenkinsci/jenkins/issues/comments/149155422","html_url":"https://github.com/jenkinsci/jenkins/pull/1815#issuecomment-149155422","issue_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/1815","id":149155422,"user":{"login":"jtnord","id":494726,"avatar_url":"https://avatars.githubusercontent.com/u/494726?v=3","gravatar_id":"","url":"https://api.github.com/users/jtnord","html_url":"https://github.com/jtnord","followers_url":"https://api.github.com/users/jtnord/followers","following_url":"https://api.github.com/users/jtnord/following{/other_user}","gists_url":"https://api.github.com/users/jtnord/gists{/gist_id}","starred_url":"https://api.github.com/users/jtnord/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtnord/subscriptions","organizations_url":"https://api.github.com/users/jtnord/orgs","repos_url":"https://api.github.com/users/jtnord/repos","events_url":"https://api.github.com/users/jtnord/events{/privacy}","received_events_url":"https://api.github.com/users/jtnord/received_events","type":"User","site_admin":false},"created_at":"2015-10-19T09:21:12Z","updated_at":"2015-10-19T09:21:12Z","body":"Well github still doesnt have support for git blame --ignore-whitespace\nthat i filed several minths ago....\n\n--\nSent from my phone; please excuse any typos and brevity of this mail.\nOn 19 Oct 2015 11:17, \"Stephen Connolly\" <notifications@github.com> wrote:\n\n> @KostyaSha <https://github.com/KostyaSha> I agree that organizations and\n> repositories should be able to control the setting of merge.branchdesc\n> that is used by the GitHub UI. That would fix the issue of useless commit\n> messages when merging via mobile and would help people merging via the web.\n>\n> An argument to use a specific merge script, i.e. forcing people to use the\n> CLI to merge, just leads back to my argument that --first-parent gives\n> you the same view as a squashed commit.\n>\n> IOW the person merging the commit (whether merging straight or\n> squash+merge) is still responsible for ensuring that the commit messages\n> are good messages. In the case of 5a5f9c5\n> <https://github.com/jenkinsci/jenkins/commit/5a5f9c5d10f04cf47e37829979dfb2f4e57972af>\n> I put my hands up... I got confused in the web UI and rather than set the\n> first line of the commit message to [FIXED JENKINS-30084] FlyWeightTasks\n> tied to a label will not cause node provisioning and will be blocked\n> forever. I ended up leaving it as the default prompted by GitHub: Merge\n> pull request #1815 from varmenise/OSS-192. What that points me to is more\n> issues in the GitHub Web UI.\n>\n> I have created issues against that UI and I am making a case to get them\n> fixed as Git 2.6.2 is released and provides the fix for git blame\n> --first-parent\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/jenkinsci/jenkins/pull/1815#issuecomment-149154567>.\n>\n"}}