{"action":"created","comment":{"url":"https://api.github.com/repos/virtium/vtStor/pulls/comments/44895957","id":44895957,"diff_hunk":"@@ -0,0 +1,62 @@\n+/*\n+<License>\n+Copyright 2015 Virtium Technology\n+\n+Licensed under the Apache License, Version 2.0 (the \"License\");\n+you may not use this file except in compliance with the License.\n+You may obtain a copy of the License at\n+\n+http ://www.apache.org/licenses/LICENSE-2.0\n+\n+Unless required by applicable law or agreed to in writing, software\n+distributed under the License is distributed on an \"AS IS\" BASIS,\n+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+See the License for the specific language governing permissions and\n+limitations under the License.\n+</License>\n+*/\n+#ifndef __vtStorCommonPlatformDefines_h__\n+#define __vtStorCommonPlatformDefines_h__\n+#include <string>\n+using tstring = std::string;\n+using tchar = char;\n+/* comment by Minh Mai for build code\n+#include <string>\n+#include <Windows.h>\n+\n+#include \"vtStorPlatformDefines.h\"\n+\n+#ifdef _UNICODE\n+#define    __STORAPITEXT( s ) L##s\n+#define tstrlen wcslen\n+#define tmemcpy_s wmemcpy_s\n+using tchar = wchar_t;\n+using tstring = std::wstring;\n+#else\n+#define    __STORAPITEXT( s ) s\n+#define tstrlen strlen\n+#define tmemcpy_s memcpy_s\n+using tchar = char;\n+using tstring = std::string;\n+#endif\n+\n+namespace vtStor\n+{\n+\n+using DeviceHandle = HANDLE;\n+\n+}\n+\n+\n+*/\n+\n+namespace vtStor\n+{\n+\n+using DeviceHandle = int;","path":"Common/Platform/x86x64/Linux/PlatformDefines.h","position":56,"original_position":56,"commit_id":"f2da2e0766cb4279ffb6e01d18c931bc479a056f","original_commit_id":"f2da2e0766cb4279ffb6e01d18c931bc479a056f","user":{"login":"hai-tran","id":11866180,"avatar_url":"https://avatars.githubusercontent.com/u/11866180?v=3","gravatar_id":"","url":"https://api.github.com/users/hai-tran","html_url":"https://github.com/hai-tran","followers_url":"https://api.github.com/users/hai-tran/followers","following_url":"https://api.github.com/users/hai-tran/following{/other_user}","gists_url":"https://api.github.com/users/hai-tran/gists{/gist_id}","starred_url":"https://api.github.com/users/hai-tran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hai-tran/subscriptions","organizations_url":"https://api.github.com/users/hai-tran/orgs","repos_url":"https://api.github.com/users/hai-tran/repos","events_url":"https://api.github.com/users/hai-tran/events{/privacy}","received_events_url":"https://api.github.com/users/hai-tran/received_events","type":"User","site_admin":false},"body":"Why do you use the DeviceHandle and HANDLE as int?","created_at":"2015-11-16T07:59:03Z","updated_at":"2015-11-16T07:59:03Z","html_url":"https://github.com/virtium/vtStor/pull/42#discussion_r44895957","pull_request_url":"https://api.github.com/repos/virtium/vtStor/pulls/42","_links":{"self":{"href":"https://api.github.com/repos/virtium/vtStor/pulls/comments/44895957"},"html":{"href":"https://github.com/virtium/vtStor/pull/42#discussion_r44895957"},"pull_request":{"href":"https://api.github.com/repos/virtium/vtStor/pulls/42"}}},"pull_request":{"url":"https://api.github.com/repos/virtium/vtStor/pulls/42","id":50095217,"html_url":"https://github.com/virtium/vtStor/pull/42","diff_url":"https://github.com/virtium/vtStor/pull/42.diff","patch_url":"https://github.com/virtium/vtStor/pull/42.patch","issue_url":"https://api.github.com/repos/virtium/vtStor/issues/42","number":42,"state":"open","locked":false,"title":"Linux build","user":{"login":"MaiChiemMinh","id":15210308,"avatar_url":"https://avatars.githubusercontent.com/u/15210308?v=3","gravatar_id":"","url":"https://api.github.com/users/MaiChiemMinh","html_url":"https://github.com/MaiChiemMinh","followers_url":"https://api.github.com/users/MaiChiemMinh/followers","following_url":"https://api.github.com/users/MaiChiemMinh/following{/other_user}","gists_url":"https://api.github.com/users/MaiChiemMinh/gists{/gist_id}","starred_url":"https://api.github.com/users/MaiChiemMinh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaiChiemMinh/subscriptions","organizations_url":"https://api.github.com/users/MaiChiemMinh/orgs","repos_url":"https://api.github.com/users/MaiChiemMinh/repos","events_url":"https://api.github.com/users/MaiChiemMinh/events{/privacy}","received_events_url":"https://api.github.com/users/MaiChiemMinh/received_events","type":"User","site_admin":false},"body":"- Commit code VTStor (Build on Linux os), update projects build on QT Creator ","created_at":"2015-11-09T08:22:58Z","updated_at":"2015-11-16T07:59:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f3efc73be7f4f99c4cabb978fa0e610c0cf158e2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/virtium/vtStor/pulls/42/commits","review_comments_url":"https://api.github.com/repos/virtium/vtStor/pulls/42/comments","review_comment_url":"https://api.github.com/repos/virtium/vtStor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/virtium/vtStor/issues/42/comments","statuses_url":"https://api.github.com/repos/virtium/vtStor/statuses/f2da2e0766cb4279ffb6e01d18c931bc479a056f","head":{"label":"MaiChiemMinh:Linux_Build","ref":"Linux_Build","sha":"f2da2e0766cb4279ffb6e01d18c931bc479a056f","user":{"login":"MaiChiemMinh","id":15210308,"avatar_url":"https://avatars.githubusercontent.com/u/15210308?v=3","gravatar_id":"","url":"https://api.github.com/users/MaiChiemMinh","html_url":"https://github.com/MaiChiemMinh","followers_url":"https://api.github.com/users/MaiChiemMinh/followers","following_url":"https://api.github.com/users/MaiChiemMinh/following{/other_user}","gists_url":"https://api.github.com/users/MaiChiemMinh/gists{/gist_id}","starred_url":"https://api.github.com/users/MaiChiemMinh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaiChiemMinh/subscriptions","organizations_url":"https://api.github.com/users/MaiChiemMinh/orgs","repos_url":"https://api.github.com/users/MaiChiemMinh/repos","events_url":"https://api.github.com/users/MaiChiemMinh/events{/privacy}","received_events_url":"https://api.github.com/users/MaiChiemMinh/received_events","type":"User","site_admin":false},"repo":{"id":45511669,"name":"vtStor","full_name":"MaiChiemMinh/vtStor","owner":{"login":"MaiChiemMinh","id":15210308,"avatar_url":"https://avatars.githubusercontent.com/u/15210308?v=3","gravatar_id":"","url":"https://api.github.com/users/MaiChiemMinh","html_url":"https://github.com/MaiChiemMinh","followers_url":"https://api.github.com/users/MaiChiemMinh/followers","following_url":"https://api.github.com/users/MaiChiemMinh/following{/other_user}","gists_url":"https://api.github.com/users/MaiChiemMinh/gists{/gist_id}","starred_url":"https://api.github.com/users/MaiChiemMinh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaiChiemMinh/subscriptions","organizations_url":"https://api.github.com/users/MaiChiemMinh/orgs","repos_url":"https://api.github.com/users/MaiChiemMinh/repos","events_url":"https://api.github.com/users/MaiChiemMinh/events{/privacy}","received_events_url":"https://api.github.com/users/MaiChiemMinh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MaiChiemMinh/vtStor","description":"This is a library (or set of libraries) to allow easy access and communication to storage devices.","fork":true,"url":"https://api.github.com/repos/MaiChiemMinh/vtStor","forks_url":"https://api.github.com/repos/MaiChiemMinh/vtStor/forks","keys_url":"https://api.github.com/repos/MaiChiemMinh/vtStor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MaiChiemMinh/vtStor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MaiChiemMinh/vtStor/teams","hooks_url":"https://api.github.com/repos/MaiChiemMinh/vtStor/hooks","issue_events_url":"https://api.github.com/repos/MaiChiemMinh/vtStor/issues/events{/number}","events_url":"https://api.github.com/repos/MaiChiemMinh/vtStor/events","assignees_url":"https://api.github.com/repos/MaiChiemMinh/vtStor/assignees{/user}","branches_url":"https://api.github.com/repos/MaiChiemMinh/vtStor/branches{/branch}","tags_url":"https://api.github.com/repos/MaiChiemMinh/vtStor/tags","blobs_url":"https://api.github.com/repos/MaiChiemMinh/vtStor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MaiChiemMinh/vtStor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MaiChiemMinh/vtStor/git/refs{/sha}","trees_url":"https://api.github.com/repos/MaiChiemMinh/vtStor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MaiChiemMinh/vtStor/statuses/{sha}","languages_url":"https://api.github.com/repos/MaiChiemMinh/vtStor/languages","stargazers_url":"https://api.github.com/repos/MaiChiemMinh/vtStor/stargazers","contributors_url":"https://api.github.com/repos/MaiChiemMinh/vtStor/contributors","subscribers_url":"https://api.github.com/repos/MaiChiemMinh/vtStor/subscribers","subscription_url":"https://api.github.com/repos/MaiChiemMinh/vtStor/subscription","commits_url":"https://api.github.com/repos/MaiChiemMinh/vtStor/commits{/sha}","git_commits_url":"https://api.github.com/repos/MaiChiemMinh/vtStor/git/commits{/sha}","comments_url":"https://api.github.com/repos/MaiChiemMinh/vtStor/comments{/number}","issue_comment_url":"https://api.github.com/repos/MaiChiemMinh/vtStor/issues/comments{/number}","contents_url":"https://api.github.com/repos/MaiChiemMinh/vtStor/contents/{+path}","compare_url":"https://api.github.com/repos/MaiChiemMinh/vtStor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MaiChiemMinh/vtStor/merges","archive_url":"https://api.github.com/repos/MaiChiemMinh/vtStor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MaiChiemMinh/vtStor/downloads","issues_url":"https://api.github.com/repos/MaiChiemMinh/vtStor/issues{/number}","pulls_url":"https://api.github.com/repos/MaiChiemMinh/vtStor/pulls{/number}","milestones_url":"https://api.github.com/repos/MaiChiemMinh/vtStor/milestones{/number}","notifications_url":"https://api.github.com/repos/MaiChiemMinh/vtStor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MaiChiemMinh/vtStor/labels{/name}","releases_url":"https://api.github.com/repos/MaiChiemMinh/vtStor/releases{/id}","created_at":"2015-11-04T03:00:36Z","updated_at":"2015-11-04T03:00:37Z","pushed_at":"2015-11-16T05:08:56Z","git_url":"git://github.com/MaiChiemMinh/vtStor.git","ssh_url":"git@github.com:MaiChiemMinh/vtStor.git","clone_url":"https://github.com/MaiChiemMinh/vtStor.git","svn_url":"https://github.com/MaiChiemMinh/vtStor","homepage":"","size":668,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"virtium:master","ref":"master","sha":"8368ef0288a42b6c6ae8bc487f86bf6834162d19","user":{"login":"virtium","id":11761410,"avatar_url":"https://avatars.githubusercontent.com/u/11761410?v=3","gravatar_id":"","url":"https://api.github.com/users/virtium","html_url":"https://github.com/virtium","followers_url":"https://api.github.com/users/virtium/followers","following_url":"https://api.github.com/users/virtium/following{/other_user}","gists_url":"https://api.github.com/users/virtium/gists{/gist_id}","starred_url":"https://api.github.com/users/virtium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/virtium/subscriptions","organizations_url":"https://api.github.com/users/virtium/orgs","repos_url":"https://api.github.com/users/virtium/repos","events_url":"https://api.github.com/users/virtium/events{/privacy}","received_events_url":"https://api.github.com/users/virtium/received_events","type":"Organization","site_admin":false},"repo":{"id":33378855,"name":"vtStor","full_name":"virtium/vtStor","owner":{"login":"virtium","id":11761410,"avatar_url":"https://avatars.githubusercontent.com/u/11761410?v=3","gravatar_id":"","url":"https://api.github.com/users/virtium","html_url":"https://github.com/virtium","followers_url":"https://api.github.com/users/virtium/followers","following_url":"https://api.github.com/users/virtium/following{/other_user}","gists_url":"https://api.github.com/users/virtium/gists{/gist_id}","starred_url":"https://api.github.com/users/virtium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/virtium/subscriptions","organizations_url":"https://api.github.com/users/virtium/orgs","repos_url":"https://api.github.com/users/virtium/repos","events_url":"https://api.github.com/users/virtium/events{/privacy}","received_events_url":"https://api.github.com/users/virtium/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/virtium/vtStor","description":"This is a library (or set of libraries) to allow easy access and communication to storage devices.","fork":false,"url":"https://api.github.com/repos/virtium/vtStor","forks_url":"https://api.github.com/repos/virtium/vtStor/forks","keys_url":"https://api.github.com/repos/virtium/vtStor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/virtium/vtStor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/virtium/vtStor/teams","hooks_url":"https://api.github.com/repos/virtium/vtStor/hooks","issue_events_url":"https://api.github.com/repos/virtium/vtStor/issues/events{/number}","events_url":"https://api.github.com/repos/virtium/vtStor/events","assignees_url":"https://api.github.com/repos/virtium/vtStor/assignees{/user}","branches_url":"https://api.github.com/repos/virtium/vtStor/branches{/branch}","tags_url":"https://api.github.com/repos/virtium/vtStor/tags","blobs_url":"https://api.github.com/repos/virtium/vtStor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/virtium/vtStor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/virtium/vtStor/git/refs{/sha}","trees_url":"https://api.github.com/repos/virtium/vtStor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/virtium/vtStor/statuses/{sha}","languages_url":"https://api.github.com/repos/virtium/vtStor/languages","stargazers_url":"https://api.github.com/repos/virtium/vtStor/stargazers","contributors_url":"https://api.github.com/repos/virtium/vtStor/contributors","subscribers_url":"https://api.github.com/repos/virtium/vtStor/subscribers","subscription_url":"https://api.github.com/repos/virtium/vtStor/subscription","commits_url":"https://api.github.com/repos/virtium/vtStor/commits{/sha}","git_commits_url":"https://api.github.com/repos/virtium/vtStor/git/commits{/sha}","comments_url":"https://api.github.com/repos/virtium/vtStor/comments{/number}","issue_comment_url":"https://api.github.com/repos/virtium/vtStor/issues/comments{/number}","contents_url":"https://api.github.com/repos/virtium/vtStor/contents/{+path}","compare_url":"https://api.github.com/repos/virtium/vtStor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/virtium/vtStor/merges","archive_url":"https://api.github.com/repos/virtium/vtStor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/virtium/vtStor/downloads","issues_url":"https://api.github.com/repos/virtium/vtStor/issues{/number}","pulls_url":"https://api.github.com/repos/virtium/vtStor/pulls{/number}","milestones_url":"https://api.github.com/repos/virtium/vtStor/milestones{/number}","notifications_url":"https://api.github.com/repos/virtium/vtStor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/virtium/vtStor/labels{/name}","releases_url":"https://api.github.com/repos/virtium/vtStor/releases{/id}","created_at":"2015-04-03T19:21:31Z","updated_at":"2015-05-06T18:57:23Z","pushed_at":"2015-11-16T05:08:57Z","git_url":"git://github.com/virtium/vtStor.git","ssh_url":"git@github.com:virtium/vtStor.git","clone_url":"https://github.com/virtium/vtStor.git","svn_url":"https://github.com/virtium/vtStor","homepage":"","size":949,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":7,"forks":4,"open_issues":7,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/virtium/vtStor/pulls/42"},"html":{"href":"https://github.com/virtium/vtStor/pull/42"},"issue":{"href":"https://api.github.com/repos/virtium/vtStor/issues/42"},"comments":{"href":"https://api.github.com/repos/virtium/vtStor/issues/42/comments"},"review_comments":{"href":"https://api.github.com/repos/virtium/vtStor/pulls/42/comments"},"review_comment":{"href":"https://api.github.com/repos/virtium/vtStor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/virtium/vtStor/pulls/42/commits"},"statuses":{"href":"https://api.github.com/repos/virtium/vtStor/statuses/f2da2e0766cb4279ffb6e01d18c931bc479a056f"}}}}