{"action":"closed","number":251,"pull_request":{"url":"https://api.github.com/repos/opencontainers/specs/pulls/251","id":50949653,"html_url":"https://github.com/opencontainers/specs/pull/251","diff_url":"https://github.com/opencontainers/specs/pull/251.diff","patch_url":"https://github.com/opencontainers/specs/pull/251.patch","issue_url":"https://api.github.com/repos/opencontainers/specs/issues/251","number":251,"state":"closed","locked":false,"title":"Change the behavior when cgroupsPath is absent","user":{"login":"hqhq","id":6415670,"avatar_url":"https://avatars.githubusercontent.com/u/6415670?v=3","gravatar_id":"","url":"https://api.github.com/users/hqhq","html_url":"https://github.com/hqhq","followers_url":"https://api.github.com/users/hqhq/followers","following_url":"https://api.github.com/users/hqhq/following{/other_user}","gists_url":"https://api.github.com/users/hqhq/gists{/gist_id}","starred_url":"https://api.github.com/users/hqhq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hqhq/subscriptions","organizations_url":"https://api.github.com/users/hqhq/orgs","repos_url":"https://api.github.com/users/hqhq/repos","events_url":"https://api.github.com/users/hqhq/events{/privacy}","received_events_url":"https://api.github.com/users/hqhq/received_events","type":"User","site_admin":false},"body":"The former definition was join \"/\" when `cgroupsPath` is absent, it's\r\nnot clear whether to join the root cgroup or create a sub cgroup under \"/\".\r\n\r\nJoin root cgroup would be a bad idea cause that's not what a container\r\nshould do. And craete a sub cgroup would be missing definition about what\r\nthe cgroup name should that be.\r\n\r\nSo I think we should leave this to implementations what the default\r\ncgroup path should be.\r\n\r\nSigned-off-by: Qiang Huang <h.huangqiang@huawei.com>","created_at":"2015-11-17T13:59:10Z","updated_at":"2015-12-08T18:46:53Z","closed_at":"2015-12-08T18:46:53Z","merged_at":"2015-12-08T18:46:53Z","merge_commit_sha":"5e897e916bdcde20129e08ea93a87b9caa317d2c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/opencontainers/specs/pulls/251/commits","review_comments_url":"https://api.github.com/repos/opencontainers/specs/pulls/251/comments","review_comment_url":"https://api.github.com/repos/opencontainers/specs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opencontainers/specs/issues/251/comments","statuses_url":"https://api.github.com/repos/opencontainers/specs/statuses/d663a5b0222497ac371a5c5cff35fea55a3ad012","head":{"label":"hqhq:hq_change_cgroupsPath","ref":"hq_change_cgroupsPath","sha":"d663a5b0222497ac371a5c5cff35fea55a3ad012","user":{"login":"hqhq","id":6415670,"avatar_url":"https://avatars.githubusercontent.com/u/6415670?v=3","gravatar_id":"","url":"https://api.github.com/users/hqhq","html_url":"https://github.com/hqhq","followers_url":"https://api.github.com/users/hqhq/followers","following_url":"https://api.github.com/users/hqhq/following{/other_user}","gists_url":"https://api.github.com/users/hqhq/gists{/gist_id}","starred_url":"https://api.github.com/users/hqhq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hqhq/subscriptions","organizations_url":"https://api.github.com/users/hqhq/orgs","repos_url":"https://api.github.com/users/hqhq/repos","events_url":"https://api.github.com/users/hqhq/events{/privacy}","received_events_url":"https://api.github.com/users/hqhq/received_events","type":"User","site_admin":false},"repo":{"id":40219487,"name":"specs","full_name":"hqhq/specs","owner":{"login":"hqhq","id":6415670,"avatar_url":"https://avatars.githubusercontent.com/u/6415670?v=3","gravatar_id":"","url":"https://api.github.com/users/hqhq","html_url":"https://github.com/hqhq","followers_url":"https://api.github.com/users/hqhq/followers","following_url":"https://api.github.com/users/hqhq/following{/other_user}","gists_url":"https://api.github.com/users/hqhq/gists{/gist_id}","starred_url":"https://api.github.com/users/hqhq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hqhq/subscriptions","organizations_url":"https://api.github.com/users/hqhq/orgs","repos_url":"https://api.github.com/users/hqhq/repos","events_url":"https://api.github.com/users/hqhq/events{/privacy}","received_events_url":"https://api.github.com/users/hqhq/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hqhq/specs","description":"Open Container Specifications","fork":true,"url":"https://api.github.com/repos/hqhq/specs","forks_url":"https://api.github.com/repos/hqhq/specs/forks","keys_url":"https://api.github.com/repos/hqhq/specs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hqhq/specs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hqhq/specs/teams","hooks_url":"https://api.github.com/repos/hqhq/specs/hooks","issue_events_url":"https://api.github.com/repos/hqhq/specs/issues/events{/number}","events_url":"https://api.github.com/repos/hqhq/specs/events","assignees_url":"https://api.github.com/repos/hqhq/specs/assignees{/user}","branches_url":"https://api.github.com/repos/hqhq/specs/branches{/branch}","tags_url":"https://api.github.com/repos/hqhq/specs/tags","blobs_url":"https://api.github.com/repos/hqhq/specs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hqhq/specs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hqhq/specs/git/refs{/sha}","trees_url":"https://api.github.com/repos/hqhq/specs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hqhq/specs/statuses/{sha}","languages_url":"https://api.github.com/repos/hqhq/specs/languages","stargazers_url":"https://api.github.com/repos/hqhq/specs/stargazers","contributors_url":"https://api.github.com/repos/hqhq/specs/contributors","subscribers_url":"https://api.github.com/repos/hqhq/specs/subscribers","subscription_url":"https://api.github.com/repos/hqhq/specs/subscription","commits_url":"https://api.github.com/repos/hqhq/specs/commits{/sha}","git_commits_url":"https://api.github.com/repos/hqhq/specs/git/commits{/sha}","comments_url":"https://api.github.com/repos/hqhq/specs/comments{/number}","issue_comment_url":"https://api.github.com/repos/hqhq/specs/issues/comments{/number}","contents_url":"https://api.github.com/repos/hqhq/specs/contents/{+path}","compare_url":"https://api.github.com/repos/hqhq/specs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hqhq/specs/merges","archive_url":"https://api.github.com/repos/hqhq/specs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hqhq/specs/downloads","issues_url":"https://api.github.com/repos/hqhq/specs/issues{/number}","pulls_url":"https://api.github.com/repos/hqhq/specs/pulls{/number}","milestones_url":"https://api.github.com/repos/hqhq/specs/milestones{/number}","notifications_url":"https://api.github.com/repos/hqhq/specs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hqhq/specs/labels{/name}","releases_url":"https://api.github.com/repos/hqhq/specs/releases{/id}","created_at":"2015-08-05T02:12:48Z","updated_at":"2015-08-05T02:12:48Z","pushed_at":"2015-12-07T01:32:52Z","git_url":"git://github.com/hqhq/specs.git","ssh_url":"git@github.com:hqhq/specs.git","clone_url":"https://github.com/hqhq/specs.git","svn_url":"https://github.com/hqhq/specs","homepage":"http://www.opencontainers.org","size":214,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"opencontainers:master","ref":"master","sha":"4066d59d2902b3982860f0442b0b92f40a4d2d6c","user":{"login":"opencontainers","id":12563465,"avatar_url":"https://avatars.githubusercontent.com/u/12563465?v=3","gravatar_id":"","url":"https://api.github.com/users/opencontainers","html_url":"https://github.com/opencontainers","followers_url":"https://api.github.com/users/opencontainers/followers","following_url":"https://api.github.com/users/opencontainers/following{/other_user}","gists_url":"https://api.github.com/users/opencontainers/gists{/gist_id}","starred_url":"https://api.github.com/users/opencontainers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opencontainers/subscriptions","organizations_url":"https://api.github.com/users/opencontainers/orgs","repos_url":"https://api.github.com/users/opencontainers/repos","events_url":"https://api.github.com/users/opencontainers/events{/privacy}","received_events_url":"https://api.github.com/users/opencontainers/received_events","type":"Organization","site_admin":false},"repo":{"id":36960293,"name":"specs","full_name":"opencontainers/specs","owner":{"login":"opencontainers","id":12563465,"avatar_url":"https://avatars.githubusercontent.com/u/12563465?v=3","gravatar_id":"","url":"https://api.github.com/users/opencontainers","html_url":"https://github.com/opencontainers","followers_url":"https://api.github.com/users/opencontainers/followers","following_url":"https://api.github.com/users/opencontainers/following{/other_user}","gists_url":"https://api.github.com/users/opencontainers/gists{/gist_id}","starred_url":"https://api.github.com/users/opencontainers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opencontainers/subscriptions","organizations_url":"https://api.github.com/users/opencontainers/orgs","repos_url":"https://api.github.com/users/opencontainers/repos","events_url":"https://api.github.com/users/opencontainers/events{/privacy}","received_events_url":"https://api.github.com/users/opencontainers/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opencontainers/specs","description":"Open Container Specifications","fork":false,"url":"https://api.github.com/repos/opencontainers/specs","forks_url":"https://api.github.com/repos/opencontainers/specs/forks","keys_url":"https://api.github.com/repos/opencontainers/specs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opencontainers/specs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opencontainers/specs/teams","hooks_url":"https://api.github.com/repos/opencontainers/specs/hooks","issue_events_url":"https://api.github.com/repos/opencontainers/specs/issues/events{/number}","events_url":"https://api.github.com/repos/opencontainers/specs/events","assignees_url":"https://api.github.com/repos/opencontainers/specs/assignees{/user}","branches_url":"https://api.github.com/repos/opencontainers/specs/branches{/branch}","tags_url":"https://api.github.com/repos/opencontainers/specs/tags","blobs_url":"https://api.github.com/repos/opencontainers/specs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opencontainers/specs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opencontainers/specs/git/refs{/sha}","trees_url":"https://api.github.com/repos/opencontainers/specs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opencontainers/specs/statuses/{sha}","languages_url":"https://api.github.com/repos/opencontainers/specs/languages","stargazers_url":"https://api.github.com/repos/opencontainers/specs/stargazers","contributors_url":"https://api.github.com/repos/opencontainers/specs/contributors","subscribers_url":"https://api.github.com/repos/opencontainers/specs/subscribers","subscription_url":"https://api.github.com/repos/opencontainers/specs/subscription","commits_url":"https://api.github.com/repos/opencontainers/specs/commits{/sha}","git_commits_url":"https://api.github.com/repos/opencontainers/specs/git/commits{/sha}","comments_url":"https://api.github.com/repos/opencontainers/specs/comments{/number}","issue_comment_url":"https://api.github.com/repos/opencontainers/specs/issues/comments{/number}","contents_url":"https://api.github.com/repos/opencontainers/specs/contents/{+path}","compare_url":"https://api.github.com/repos/opencontainers/specs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opencontainers/specs/merges","archive_url":"https://api.github.com/repos/opencontainers/specs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opencontainers/specs/downloads","issues_url":"https://api.github.com/repos/opencontainers/specs/issues{/number}","pulls_url":"https://api.github.com/repos/opencontainers/specs/pulls{/number}","milestones_url":"https://api.github.com/repos/opencontainers/specs/milestones{/number}","notifications_url":"https://api.github.com/repos/opencontainers/specs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opencontainers/specs/labels{/name}","releases_url":"https://api.github.com/repos/opencontainers/specs/releases{/id}","created_at":"2015-06-05T23:30:10Z","updated_at":"2015-12-08T13:53:11Z","pushed_at":"2015-12-08T18:46:53Z","git_url":"git://github.com/opencontainers/specs.git","ssh_url":"git@github.com:opencontainers/specs.git","clone_url":"https://github.com/opencontainers/specs.git","svn_url":"https://github.com/opencontainers/specs","homepage":"http://www.opencontainers.org","size":1516,"stargazers_count":547,"watchers_count":547,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":96,"mirror_url":null,"open_issues_count":47,"forks":96,"open_issues":47,"watchers":547,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opencontainers/specs/pulls/251"},"html":{"href":"https://github.com/opencontainers/specs/pull/251"},"issue":{"href":"https://api.github.com/repos/opencontainers/specs/issues/251"},"comments":{"href":"https://api.github.com/repos/opencontainers/specs/issues/251/comments"},"review_comments":{"href":"https://api.github.com/repos/opencontainers/specs/pulls/251/comments"},"review_comment":{"href":"https://api.github.com/repos/opencontainers/specs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opencontainers/specs/pulls/251/commits"},"statuses":{"href":"https://api.github.com/repos/opencontainers/specs/statuses/d663a5b0222497ac371a5c5cff35fea55a3ad012"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"vbatts","id":67049,"avatar_url":"https://avatars.githubusercontent.com/u/67049?v=3","gravatar_id":"","url":"https://api.github.com/users/vbatts","html_url":"https://github.com/vbatts","followers_url":"https://api.github.com/users/vbatts/followers","following_url":"https://api.github.com/users/vbatts/following{/other_user}","gists_url":"https://api.github.com/users/vbatts/gists{/gist_id}","starred_url":"https://api.github.com/users/vbatts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vbatts/subscriptions","organizations_url":"https://api.github.com/users/vbatts/orgs","repos_url":"https://api.github.com/users/vbatts/repos","events_url":"https://api.github.com/users/vbatts/events{/privacy}","received_events_url":"https://api.github.com/users/vbatts/received_events","type":"User","site_admin":false},"comments":8,"review_comments":8,"commits":1,"additions":1,"deletions":1,"changed_files":1}}