{"action":"created","issue":{"url":"https://api.github.com/repos/aodn/aodn-portal/issues/1672","labels_url":"https://api.github.com/repos/aodn/aodn-portal/issues/1672/labels{/name}","comments_url":"https://api.github.com/repos/aodn/aodn-portal/issues/1672/comments","events_url":"https://api.github.com/repos/aodn/aodn-portal/issues/1672/events","html_url":"https://github.com/aodn/aodn-portal/pull/1672","id":64671372,"number":1672,"title":"Update ResettableDate","user":{"login":"dnahodil","id":2774917,"avatar_url":"https://avatars.githubusercontent.com/u/2774917?v=3","gravatar_id":"","url":"https://api.github.com/users/dnahodil","html_url":"https://github.com/dnahodil","followers_url":"https://api.github.com/users/dnahodil/followers","following_url":"https://api.github.com/users/dnahodil/following{/other_user}","gists_url":"https://api.github.com/users/dnahodil/gists{/gist_id}","starred_url":"https://api.github.com/users/dnahodil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnahodil/subscriptions","organizations_url":"https://api.github.com/users/dnahodil/orgs","repos_url":"https://api.github.com/users/dnahodil/repos","events_url":"https://api.github.com/users/dnahodil/events{/privacy}","received_events_url":"https://api.github.com/users/dnahodil/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/aodn/aodn-portal/labels/in%20progress","name":"in progress","color":"ededed"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-03-27T01:33:54Z","updated_at":"2015-03-27T02:34:26Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/aodn/aodn-portal/pulls/1672","html_url":"https://github.com/aodn/aodn-portal/pull/1672","diff_url":"https://github.com/aodn/aodn-portal/pull/1672.diff","patch_url":"https://github.com/aodn/aodn-portal/pull/1672.patch"},"body":"ResettableDate used to have hasValue() and getValue() functions. hasValue() took into account the fact that an empty date field had a value of the empty string. This meant that DateFilterPanel had to use hasValue() before it used getValue() which made code a bit messier than needed.\r\n\r\nThis suggested change removes hasValue() function and make getValue() return null instead of an empty string. This means that DateFilterPanel can have a cleaner interface because getValue() can be used in boolean conditionals as well."},"comment":{"url":"https://api.github.com/repos/aodn/aodn-portal/issues/comments/86790990","html_url":"https://github.com/aodn/aodn-portal/pull/1672#issuecomment-86790990","issue_url":"https://api.github.com/repos/aodn/aodn-portal/issues/1672","id":86790990,"user":{"login":"dnahodil","id":2774917,"avatar_url":"https://avatars.githubusercontent.com/u/2774917?v=3","gravatar_id":"","url":"https://api.github.com/users/dnahodil","html_url":"https://github.com/dnahodil","followers_url":"https://api.github.com/users/dnahodil/followers","following_url":"https://api.github.com/users/dnahodil/following{/other_user}","gists_url":"https://api.github.com/users/dnahodil/gists{/gist_id}","starred_url":"https://api.github.com/users/dnahodil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnahodil/subscriptions","organizations_url":"https://api.github.com/users/dnahodil/orgs","repos_url":"https://api.github.com/users/dnahodil/repos","events_url":"https://api.github.com/users/dnahodil/events{/privacy}","received_events_url":"https://api.github.com/users/dnahodil/received_events","type":"User","site_admin":false},"created_at":"2015-03-27T02:34:26Z","updated_at":"2015-03-27T02:34:26Z","body":"That's pretty fundamental. Let me have a look."}}