{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-trafodion/pulls/comments/36870896","id":36870896,"diff_hunk":"@@ -1315,32 +1192,30 @@ Lng32 ExpHbaseInterface_JNI::checkAndInsertRow(\n \t  const int64_t timestamp,\n           NABoolean asyncOperation)\n {\n-  HTableClient_JNI *htc = client_->getHTableClient((NAHeap *)heap_, tblName.val, useTRex_, hbs_);\n-  if (htc == NULL) {\n-    retCode_ = HBC_ERROR_GET_HTC_EXCEPTION;\n-    return HBASE_OPEN_ERROR;\n-  }\n-  \n-  Int64 transID;\n+  HTableClient_JNI *htc;\n+  Int64 transID; \n+  NABoolean checkAndPut = TRUE;\n+\n   if (noXn)\n-    transID = 0;\n-  else\n+    transID = 0; \n+  else \n     transID = getTransactionIDFromContext();\n- \n+  retCode_ = client_->insertRow((NAHeap *)heap_, tblName.val, hbs_,","path":"core/sql/exp/ExpHbaseInterface.cpp","position":385,"original_position":385,"commit_id":"9a013554fedc0e91976d7668f415b897398bb516","original_commit_id":"8e8fd9b2515cb354d076883906a614cc41084ba2","user":{"login":"selvaganesang","id":8702996,"avatar_url":"https://avatars.githubusercontent.com/u/8702996?v=3","gravatar_id":"","url":"https://api.github.com/users/selvaganesang","html_url":"https://github.com/selvaganesang","followers_url":"https://api.github.com/users/selvaganesang/followers","following_url":"https://api.github.com/users/selvaganesang/following{/other_user}","gists_url":"https://api.github.com/users/selvaganesang/gists{/gist_id}","starred_url":"https://api.github.com/users/selvaganesang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/selvaganesang/subscriptions","organizations_url":"https://api.github.com/users/selvaganesang/orgs","repos_url":"https://api.github.com/users/selvaganesang/repos","events_url":"https://api.github.com/users/selvaganesang/events{/privacy}","received_events_url":"https://api.github.com/users/selvaganesang/received_events","type":"User","site_admin":false},"body":"checkAndInsertRow and insertRow is implemented using the same method HBaseClient_JNI::insertRow. There is a parameter checkAndPut is used to determine if checkAndPut is needed","created_at":"2015-08-12T15:07:45Z","updated_at":"2015-08-12T15:07:45Z","html_url":"https://github.com/apache/incubator-trafodion/pull/52#discussion_r36870896","pull_request_url":"https://api.github.com/repos/apache/incubator-trafodion/pulls/52","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-trafodion/pulls/comments/36870896"},"html":{"href":"https://github.com/apache/incubator-trafodion/pull/52#discussion_r36870896"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-trafodion/pulls/52"}}},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-trafodion/pulls/52","id":42140877,"html_url":"https://github.com/apache/incubator-trafodion/pull/52","diff_url":"https://github.com/apache/incubator-trafodion/pull/52.diff","patch_url":"https://github.com/apache/incubator-trafodion/pull/52.patch","issue_url":"https://api.github.com/repos/apache/incubator-trafodion/issues/52","number":52,"state":"open","locked":false,"title":"[TRAFODION-1444] Reduced pathlength for IUD","user":{"login":"selvaganesang","id":8702996,"avatar_url":"https://avatars.githubusercontent.com/u/8702996?v=3","gravatar_id":"","url":"https://api.github.com/users/selvaganesang","html_url":"https://github.com/selvaganesang","followers_url":"https://api.github.com/users/selvaganesang/followers","following_url":"https://api.github.com/users/selvaganesang/following{/other_user}","gists_url":"https://api.github.com/users/selvaganesang/gists{/gist_id}","starred_url":"https://api.github.com/users/selvaganesang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/selvaganesang/subscriptions","organizations_url":"https://api.github.com/users/selvaganesang/orgs","repos_url":"https://api.github.com/users/selvaganesang/repos","events_url":"https://api.github.com/users/selvaganesang/events{/privacy}","received_events_url":"https://api.github.com/users/selvaganesang/received_events","type":"User","site_admin":false},"body":"Reduced the number of JNI to java transitions and\r\nmemory allocation by streamlining the Trafodion-HBase\r\nclient layer for IUD commands\r\n\r\nAlso removed unreferenced code and variables in this layer.","created_at":"2015-08-11T15:16:45Z","updated_at":"2015-08-12T15:07:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7504604d1775cdb0d0a7c47805235bb02a26bf35","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-trafodion/pulls/52/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-trafodion/pulls/52/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-trafodion/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-trafodion/issues/52/comments","statuses_url":"https://api.github.com/repos/apache/incubator-trafodion/statuses/9a013554fedc0e91976d7668f415b897398bb516","head":{"label":"selvaganesang:trafodion-1444","ref":"trafodion-1444","sha":"9a013554fedc0e91976d7668f415b897398bb516","user":{"login":"selvaganesang","id":8702996,"avatar_url":"https://avatars.githubusercontent.com/u/8702996?v=3","gravatar_id":"","url":"https://api.github.com/users/selvaganesang","html_url":"https://github.com/selvaganesang","followers_url":"https://api.github.com/users/selvaganesang/followers","following_url":"https://api.github.com/users/selvaganesang/following{/other_user}","gists_url":"https://api.github.com/users/selvaganesang/gists{/gist_id}","starred_url":"https://api.github.com/users/selvaganesang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/selvaganesang/subscriptions","organizations_url":"https://api.github.com/users/selvaganesang/orgs","repos_url":"https://api.github.com/users/selvaganesang/repos","events_url":"https://api.github.com/users/selvaganesang/events{/privacy}","received_events_url":"https://api.github.com/users/selvaganesang/received_events","type":"User","site_admin":false},"repo":{"id":37948798,"name":"incubator-trafodion","full_name":"selvaganesang/incubator-trafodion","owner":{"login":"selvaganesang","id":8702996,"avatar_url":"https://avatars.githubusercontent.com/u/8702996?v=3","gravatar_id":"","url":"https://api.github.com/users/selvaganesang","html_url":"https://github.com/selvaganesang","followers_url":"https://api.github.com/users/selvaganesang/followers","following_url":"https://api.github.com/users/selvaganesang/following{/other_user}","gists_url":"https://api.github.com/users/selvaganesang/gists{/gist_id}","starred_url":"https://api.github.com/users/selvaganesang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/selvaganesang/subscriptions","organizations_url":"https://api.github.com/users/selvaganesang/orgs","repos_url":"https://api.github.com/users/selvaganesang/repos","events_url":"https://api.github.com/users/selvaganesang/events{/privacy}","received_events_url":"https://api.github.com/users/selvaganesang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/selvaganesang/incubator-trafodion","description":"Mirror of Apache Trafodion (Incubating)","fork":true,"url":"https://api.github.com/repos/selvaganesang/incubator-trafodion","forks_url":"https://api.github.com/repos/selvaganesang/incubator-trafodion/forks","keys_url":"https://api.github.com/repos/selvaganesang/incubator-trafodion/keys{/key_id}","collaborators_url":"https://api.github.com/repos/selvaganesang/incubator-trafodion/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/selvaganesang/incubator-trafodion/teams","hooks_url":"https://api.github.com/repos/selvaganesang/incubator-trafodion/hooks","issue_events_url":"https://api.github.com/repos/selvaganesang/incubator-trafodion/issues/events{/number}","events_url":"https://api.github.com/repos/selvaganesang/incubator-trafodion/events","assignees_url":"https://api.github.com/repos/selvaganesang/incubator-trafodion/assignees{/user}","branches_url":"https://api.github.com/repos/selvaganesang/incubator-trafodion/branches{/branch}","tags_url":"https://api.github.com/repos/selvaganesang/incubator-trafodion/tags","blobs_url":"https://api.github.com/repos/selvaganesang/incubator-trafodion/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/selvaganesang/incubator-trafodion/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/selvaganesang/incubator-trafodion/git/refs{/sha}","trees_url":"https://api.github.com/repos/selvaganesang/incubator-trafodion/git/trees{/sha}","statuses_url":"https://api.github.com/repos/selvaganesang/incubator-trafodion/statuses/{sha}","languages_url":"https://api.github.com/repos/selvaganesang/incubator-trafodion/languages","stargazers_url":"https://api.github.com/repos/selvaganesang/incubator-trafodion/stargazers","contributors_url":"https://api.github.com/repos/selvaganesang/incubator-trafodion/contributors","subscribers_url":"https://api.github.com/repos/selvaganesang/incubator-trafodion/subscribers","subscription_url":"https://api.github.com/repos/selvaganesang/incubator-trafodion/subscription","commits_url":"https://api.github.com/repos/selvaganesang/incubator-trafodion/commits{/sha}","git_commits_url":"https://api.github.com/repos/selvaganesang/incubator-trafodion/git/commits{/sha}","comments_url":"https://api.github.com/repos/selvaganesang/incubator-trafodion/comments{/number}","issue_comment_url":"https://api.github.com/repos/selvaganesang/incubator-trafodion/issues/comments{/number}","contents_url":"https://api.github.com/repos/selvaganesang/incubator-trafodion/contents/{+path}","compare_url":"https://api.github.com/repos/selvaganesang/incubator-trafodion/compare/{base}...{head}","merges_url":"https://api.github.com/repos/selvaganesang/incubator-trafodion/merges","archive_url":"https://api.github.com/repos/selvaganesang/incubator-trafodion/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/selvaganesang/incubator-trafodion/downloads","issues_url":"https://api.github.com/repos/selvaganesang/incubator-trafodion/issues{/number}","pulls_url":"https://api.github.com/repos/selvaganesang/incubator-trafodion/pulls{/number}","milestones_url":"https://api.github.com/repos/selvaganesang/incubator-trafodion/milestones{/number}","notifications_url":"https://api.github.com/repos/selvaganesang/incubator-trafodion/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/selvaganesang/incubator-trafodion/labels{/name}","releases_url":"https://api.github.com/repos/selvaganesang/incubator-trafodion/releases{/id}","created_at":"2015-06-23T22:34:16Z","updated_at":"2015-06-23T22:34:56Z","pushed_at":"2015-08-12T04:24:18Z","git_url":"git://github.com/selvaganesang/incubator-trafodion.git","ssh_url":"git@github.com:selvaganesang/incubator-trafodion.git","clone_url":"https://github.com/selvaganesang/incubator-trafodion.git","svn_url":"https://github.com/selvaganesang/incubator-trafodion","homepage":null,"size":55248,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"b46b887bd90c9d8d250e7c0db3c599b3b72f0926","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":36349344,"name":"incubator-trafodion","full_name":"apache/incubator-trafodion","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-trafodion","description":"Mirror of Apache Trafodion (Incubating)","fork":false,"url":"https://api.github.com/repos/apache/incubator-trafodion","forks_url":"https://api.github.com/repos/apache/incubator-trafodion/forks","keys_url":"https://api.github.com/repos/apache/incubator-trafodion/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-trafodion/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-trafodion/teams","hooks_url":"https://api.github.com/repos/apache/incubator-trafodion/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-trafodion/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-trafodion/events","assignees_url":"https://api.github.com/repos/apache/incubator-trafodion/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-trafodion/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-trafodion/tags","blobs_url":"https://api.github.com/repos/apache/incubator-trafodion/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-trafodion/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-trafodion/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-trafodion/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-trafodion/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-trafodion/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-trafodion/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-trafodion/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-trafodion/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-trafodion/subscription","commits_url":"https://api.github.com/repos/apache/incubator-trafodion/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-trafodion/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-trafodion/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-trafodion/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-trafodion/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-trafodion/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-trafodion/merges","archive_url":"https://api.github.com/repos/apache/incubator-trafodion/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-trafodion/downloads","issues_url":"https://api.github.com/repos/apache/incubator-trafodion/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-trafodion/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-trafodion/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-trafodion/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-trafodion/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-trafodion/releases{/id}","created_at":"2015-05-27T07:00:05Z","updated_at":"2015-08-11T02:49:47Z","pushed_at":"2015-08-12T04:24:19Z","git_url":"git://github.com/apache/incubator-trafodion.git","ssh_url":"git@github.com:apache/incubator-trafodion.git","clone_url":"https://github.com/apache/incubator-trafodion.git","svn_url":"https://github.com/apache/incubator-trafodion","homepage":null,"size":59118,"stargazers_count":8,"watchers_count":8,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":35,"mirror_url":"git://git.apache.org/incubator-trafodion.git","open_issues_count":4,"forks":35,"open_issues":4,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-trafodion/pulls/52"},"html":{"href":"https://github.com/apache/incubator-trafodion/pull/52"},"issue":{"href":"https://api.github.com/repos/apache/incubator-trafodion/issues/52"},"comments":{"href":"https://api.github.com/repos/apache/incubator-trafodion/issues/52/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-trafodion/pulls/52/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-trafodion/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-trafodion/pulls/52/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-trafodion/statuses/9a013554fedc0e91976d7668f415b897398bb516"}}}}