{"action":"opened","issue":{"url":"https://api.github.com/repos/techwiz24/EECS2500/issues/20","labels_url":"https://api.github.com/repos/techwiz24/EECS2500/issues/20/labels{/name}","comments_url":"https://api.github.com/repos/techwiz24/EECS2500/issues/20/comments","events_url":"https://api.github.com/repos/techwiz24/EECS2500/issues/20/events","html_url":"https://github.com/techwiz24/EECS2500/issues/20","id":111993927,"number":20,"title":"Feedback for Assignment #1","user":{"login":"techwiz24","id":794251,"avatar_url":"https://avatars.githubusercontent.com/u/794251?v=3","gravatar_id":"","url":"https://api.github.com/users/techwiz24","html_url":"https://github.com/techwiz24","followers_url":"https://api.github.com/users/techwiz24/followers","following_url":"https://api.github.com/users/techwiz24/following{/other_user}","gists_url":"https://api.github.com/users/techwiz24/gists{/gist_id}","starred_url":"https://api.github.com/users/techwiz24/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/techwiz24/subscriptions","organizations_url":"https://api.github.com/users/techwiz24/orgs","repos_url":"https://api.github.com/users/techwiz24/repos","events_url":"https://api.github.com/users/techwiz24/events{/privacy}","received_events_url":"https://api.github.com/users/techwiz24/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/techwiz24/EECS2500/labels/Feedback","name":"Feedback","color":"cecece"}],"state":"open","locked":false,"assignee":{"login":"techwiz24","id":794251,"avatar_url":"https://avatars.githubusercontent.com/u/794251?v=3","gravatar_id":"","url":"https://api.github.com/users/techwiz24","html_url":"https://github.com/techwiz24","followers_url":"https://api.github.com/users/techwiz24/followers","following_url":"https://api.github.com/users/techwiz24/following{/other_user}","gists_url":"https://api.github.com/users/techwiz24/gists{/gist_id}","starred_url":"https://api.github.com/users/techwiz24/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/techwiz24/subscriptions","organizations_url":"https://api.github.com/users/techwiz24/orgs","repos_url":"https://api.github.com/users/techwiz24/repos","events_url":"https://api.github.com/users/techwiz24/events{/privacy}","received_events_url":"https://api.github.com/users/techwiz24/received_events","type":"User","site_admin":false},"milestone":null,"comments":0,"created_at":"2015-10-18T01:17:24Z","updated_at":"2015-10-18T01:17:24Z","closed_at":null,"body":"## Feedback to Learner\r\n10/17/15 2:42 PM\r\n\r\n> In the future, please build these in Eclipse.  I got it working, but it took a long time to download and install the needed components.  The assignment says, \"I should be able to unzip your workspace, point Eclipse to it, and run your code without modification.  You should be using the 32-bit versions of Eclipse Standard (Mars), with the (also 32-bit) JDK 8u60.\"  I shouldn't have to spend any extra time just starting your project.\r\n\r\nNot sure what's up with this. Tested with the final workspace export in both linux and windows and did not have any problems other than maven supposedly being out of sync, which did not prevent the main calculator from running. **TODO**: Test more in eclipse? Need to see what specific errors he encountered so I can test for them.\r\n\r\n> (-3) It crashed on q1296, but took Q1296 just fine.  It should be a bit more graceful with not handling undefined operators.  Same thing with C/c, but I won't take the same points off for both.  If your evaluator is going to throw exceptions for all of the malformed cases, then main should at least catch them and display a message that it was illegal; aborting it a pretty heavy-handed way of letting an exception occur\r\n\r\nNote to self, just print the exception message on standard error instead of throwing with a stack trace? I think this is personal preference, as there were no requirements for continuing after invalid input (see comments below) and an exception contains more specific information about the error to the user, but oh well.\r\n\r\n> (-3) It accepts \"+ 3 4\" as a valid infix expression, and produces the output of 7.\r\n\r\nMissed an edge case in testing. I did not have a test case for this, and the psuedo code provided does indeed (incorrectly) accept this as valid input.\r\n\r\n> It would have been nice if your program had prompted for \"would you like to do another\", but this wasn't a requirement.\r\n\r\n`94/100`"}}