{"action":"created","comment":{"url":"https://api.github.com/repos/sindresorhus/grunt-php/pulls/comments/28197260","id":28197260,"diff_hunk":"@@ -1 +1,3 @@\n node_modules\n+#IDE\n+.idea","path":".gitignore","position":3,"original_position":3,"commit_id":"2ad783948a1b31abedfd84c8fd55f20e26e139b3","original_commit_id":"2ad783948a1b31abedfd84c8fd55f20e26e139b3","user":{"login":"xavierpriour","id":2295912,"avatar_url":"https://avatars.githubusercontent.com/u/2295912?v=3","gravatar_id":"","url":"https://api.github.com/users/xavierpriour","html_url":"https://github.com/xavierpriour","followers_url":"https://api.github.com/users/xavierpriour/followers","following_url":"https://api.github.com/users/xavierpriour/following{/other_user}","gists_url":"https://api.github.com/users/xavierpriour/gists{/gist_id}","starred_url":"https://api.github.com/users/xavierpriour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xavierpriour/subscriptions","organizations_url":"https://api.github.com/users/xavierpriour/orgs","repos_url":"https://api.github.com/users/xavierpriour/repos","events_url":"https://api.github.com/users/xavierpriour/events{/privacy}","received_events_url":"https://api.github.com/users/xavierpriour/received_events","type":"User","site_admin":false},"body":"ok, I'll remove it","created_at":"2015-04-11T18:23:35Z","updated_at":"2015-04-11T18:23:35Z","html_url":"https://github.com/sindresorhus/grunt-php/pull/63#discussion_r28197260","pull_request_url":"https://api.github.com/repos/sindresorhus/grunt-php/pulls/63","_links":{"self":{"href":"https://api.github.com/repos/sindresorhus/grunt-php/pulls/comments/28197260"},"html":{"href":"https://github.com/sindresorhus/grunt-php/pull/63#discussion_r28197260"},"pull_request":{"href":"https://api.github.com/repos/sindresorhus/grunt-php/pulls/63"}}},"pull_request":{"url":"https://api.github.com/repos/sindresorhus/grunt-php/pulls/63","id":33106994,"html_url":"https://github.com/sindresorhus/grunt-php/pull/63","diff_url":"https://github.com/sindresorhus/grunt-php/pull/63.diff","patch_url":"https://github.com/sindresorhus/grunt-php/pull/63.patch","issue_url":"https://api.github.com/repos/sindresorhus/grunt-php/issues/63","number":63,"state":"open","locked":false,"title":"fix issue #17","user":{"login":"xavierpriour","id":2295912,"avatar_url":"https://avatars.githubusercontent.com/u/2295912?v=3","gravatar_id":"","url":"https://api.github.com/users/xavierpriour","html_url":"https://github.com/xavierpriour","followers_url":"https://api.github.com/users/xavierpriour/followers","following_url":"https://api.github.com/users/xavierpriour/following{/other_user}","gists_url":"https://api.github.com/users/xavierpriour/gists{/gist_id}","starred_url":"https://api.github.com/users/xavierpriour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xavierpriour/subscriptions","organizations_url":"https://api.github.com/users/xavierpriour/orgs","repos_url":"https://api.github.com/users/xavierpriour/repos","events_url":"https://api.github.com/users/xavierpriour/events{/privacy}","received_events_url":"https://api.github.com/users/xavierpriour/received_events","type":"User","site_admin":false},"body":"#17 was caused by a randomly occuring issue in checkServer: in *some* circumstances (sorry, did not manage to devise a reproducible test), `http.request({method: 'HEAD',...})` returns a statusCode of 2 but also an error ('HPE_INVALID_CONSTANT').\r\n\r\nAs a result this.async was called **twice** (once in the original request callback, and then again in the request, initiated by the error handler).\r\nI suppose grunt interpreted the second call as the end of the following task (watch) if it had already starded, and ended the build.\r\n\r\nI added a check so this.async is only ever called once. I also did a little renaming and used false/true value to signal task failure to grunt.","created_at":"2015-04-11T17:43:17Z","updated_at":"2015-04-11T18:23:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3e649358f45f0615aa1107a24c2028be47151d16","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sindresorhus/grunt-php/pulls/63/commits","review_comments_url":"https://api.github.com/repos/sindresorhus/grunt-php/pulls/63/comments","review_comment_url":"https://api.github.com/repos/sindresorhus/grunt-php/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sindresorhus/grunt-php/issues/63/comments","statuses_url":"https://api.github.com/repos/sindresorhus/grunt-php/statuses/2ad783948a1b31abedfd84c8fd55f20e26e139b3","head":{"label":"xavierpriour:master","ref":"master","sha":"2ad783948a1b31abedfd84c8fd55f20e26e139b3","user":{"login":"xavierpriour","id":2295912,"avatar_url":"https://avatars.githubusercontent.com/u/2295912?v=3","gravatar_id":"","url":"https://api.github.com/users/xavierpriour","html_url":"https://github.com/xavierpriour","followers_url":"https://api.github.com/users/xavierpriour/followers","following_url":"https://api.github.com/users/xavierpriour/following{/other_user}","gists_url":"https://api.github.com/users/xavierpriour/gists{/gist_id}","starred_url":"https://api.github.com/users/xavierpriour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xavierpriour/subscriptions","organizations_url":"https://api.github.com/users/xavierpriour/orgs","repos_url":"https://api.github.com/users/xavierpriour/repos","events_url":"https://api.github.com/users/xavierpriour/events{/privacy}","received_events_url":"https://api.github.com/users/xavierpriour/received_events","type":"User","site_admin":false},"repo":{"id":33785581,"name":"grunt-php","full_name":"xavierpriour/grunt-php","owner":{"login":"xavierpriour","id":2295912,"avatar_url":"https://avatars.githubusercontent.com/u/2295912?v=3","gravatar_id":"","url":"https://api.github.com/users/xavierpriour","html_url":"https://github.com/xavierpriour","followers_url":"https://api.github.com/users/xavierpriour/followers","following_url":"https://api.github.com/users/xavierpriour/following{/other_user}","gists_url":"https://api.github.com/users/xavierpriour/gists{/gist_id}","starred_url":"https://api.github.com/users/xavierpriour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xavierpriour/subscriptions","organizations_url":"https://api.github.com/users/xavierpriour/orgs","repos_url":"https://api.github.com/users/xavierpriour/repos","events_url":"https://api.github.com/users/xavierpriour/events{/privacy}","received_events_url":"https://api.github.com/users/xavierpriour/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xavierpriour/grunt-php","description":"Start a PHP-server","fork":true,"url":"https://api.github.com/repos/xavierpriour/grunt-php","forks_url":"https://api.github.com/repos/xavierpriour/grunt-php/forks","keys_url":"https://api.github.com/repos/xavierpriour/grunt-php/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xavierpriour/grunt-php/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xavierpriour/grunt-php/teams","hooks_url":"https://api.github.com/repos/xavierpriour/grunt-php/hooks","issue_events_url":"https://api.github.com/repos/xavierpriour/grunt-php/issues/events{/number}","events_url":"https://api.github.com/repos/xavierpriour/grunt-php/events","assignees_url":"https://api.github.com/repos/xavierpriour/grunt-php/assignees{/user}","branches_url":"https://api.github.com/repos/xavierpriour/grunt-php/branches{/branch}","tags_url":"https://api.github.com/repos/xavierpriour/grunt-php/tags","blobs_url":"https://api.github.com/repos/xavierpriour/grunt-php/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xavierpriour/grunt-php/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xavierpriour/grunt-php/git/refs{/sha}","trees_url":"https://api.github.com/repos/xavierpriour/grunt-php/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xavierpriour/grunt-php/statuses/{sha}","languages_url":"https://api.github.com/repos/xavierpriour/grunt-php/languages","stargazers_url":"https://api.github.com/repos/xavierpriour/grunt-php/stargazers","contributors_url":"https://api.github.com/repos/xavierpriour/grunt-php/contributors","subscribers_url":"https://api.github.com/repos/xavierpriour/grunt-php/subscribers","subscription_url":"https://api.github.com/repos/xavierpriour/grunt-php/subscription","commits_url":"https://api.github.com/repos/xavierpriour/grunt-php/commits{/sha}","git_commits_url":"https://api.github.com/repos/xavierpriour/grunt-php/git/commits{/sha}","comments_url":"https://api.github.com/repos/xavierpriour/grunt-php/comments{/number}","issue_comment_url":"https://api.github.com/repos/xavierpriour/grunt-php/issues/comments{/number}","contents_url":"https://api.github.com/repos/xavierpriour/grunt-php/contents/{+path}","compare_url":"https://api.github.com/repos/xavierpriour/grunt-php/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xavierpriour/grunt-php/merges","archive_url":"https://api.github.com/repos/xavierpriour/grunt-php/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xavierpriour/grunt-php/downloads","issues_url":"https://api.github.com/repos/xavierpriour/grunt-php/issues{/number}","pulls_url":"https://api.github.com/repos/xavierpriour/grunt-php/pulls{/number}","milestones_url":"https://api.github.com/repos/xavierpriour/grunt-php/milestones{/number}","notifications_url":"https://api.github.com/repos/xavierpriour/grunt-php/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xavierpriour/grunt-php/labels{/name}","releases_url":"https://api.github.com/repos/xavierpriour/grunt-php/releases{/id}","created_at":"2015-04-11T17:38:06Z","updated_at":"2015-04-11T17:40:48Z","pushed_at":"2015-04-11T17:40:48Z","git_url":"git://github.com/xavierpriour/grunt-php.git","ssh_url":"git@github.com:xavierpriour/grunt-php.git","clone_url":"https://github.com/xavierpriour/grunt-php.git","svn_url":"https://github.com/xavierpriour/grunt-php","homepage":"","size":639,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sindresorhus:master","ref":"master","sha":"089fa50afe1feee9b5a8355d2b9cc799109d91ea","user":{"login":"sindresorhus","id":170270,"avatar_url":"https://avatars.githubusercontent.com/u/170270?v=3","gravatar_id":"","url":"https://api.github.com/users/sindresorhus","html_url":"https://github.com/sindresorhus","followers_url":"https://api.github.com/users/sindresorhus/followers","following_url":"https://api.github.com/users/sindresorhus/following{/other_user}","gists_url":"https://api.github.com/users/sindresorhus/gists{/gist_id}","starred_url":"https://api.github.com/users/sindresorhus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sindresorhus/subscriptions","organizations_url":"https://api.github.com/users/sindresorhus/orgs","repos_url":"https://api.github.com/users/sindresorhus/repos","events_url":"https://api.github.com/users/sindresorhus/events{/privacy}","received_events_url":"https://api.github.com/users/sindresorhus/received_events","type":"User","site_admin":false},"repo":{"id":8659614,"name":"grunt-php","full_name":"sindresorhus/grunt-php","owner":{"login":"sindresorhus","id":170270,"avatar_url":"https://avatars.githubusercontent.com/u/170270?v=3","gravatar_id":"","url":"https://api.github.com/users/sindresorhus","html_url":"https://github.com/sindresorhus","followers_url":"https://api.github.com/users/sindresorhus/followers","following_url":"https://api.github.com/users/sindresorhus/following{/other_user}","gists_url":"https://api.github.com/users/sindresorhus/gists{/gist_id}","starred_url":"https://api.github.com/users/sindresorhus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sindresorhus/subscriptions","organizations_url":"https://api.github.com/users/sindresorhus/orgs","repos_url":"https://api.github.com/users/sindresorhus/repos","events_url":"https://api.github.com/users/sindresorhus/events{/privacy}","received_events_url":"https://api.github.com/users/sindresorhus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sindresorhus/grunt-php","description":"Start a PHP-server","fork":false,"url":"https://api.github.com/repos/sindresorhus/grunt-php","forks_url":"https://api.github.com/repos/sindresorhus/grunt-php/forks","keys_url":"https://api.github.com/repos/sindresorhus/grunt-php/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sindresorhus/grunt-php/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sindresorhus/grunt-php/teams","hooks_url":"https://api.github.com/repos/sindresorhus/grunt-php/hooks","issue_events_url":"https://api.github.com/repos/sindresorhus/grunt-php/issues/events{/number}","events_url":"https://api.github.com/repos/sindresorhus/grunt-php/events","assignees_url":"https://api.github.com/repos/sindresorhus/grunt-php/assignees{/user}","branches_url":"https://api.github.com/repos/sindresorhus/grunt-php/branches{/branch}","tags_url":"https://api.github.com/repos/sindresorhus/grunt-php/tags","blobs_url":"https://api.github.com/repos/sindresorhus/grunt-php/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sindresorhus/grunt-php/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sindresorhus/grunt-php/git/refs{/sha}","trees_url":"https://api.github.com/repos/sindresorhus/grunt-php/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sindresorhus/grunt-php/statuses/{sha}","languages_url":"https://api.github.com/repos/sindresorhus/grunt-php/languages","stargazers_url":"https://api.github.com/repos/sindresorhus/grunt-php/stargazers","contributors_url":"https://api.github.com/repos/sindresorhus/grunt-php/contributors","subscribers_url":"https://api.github.com/repos/sindresorhus/grunt-php/subscribers","subscription_url":"https://api.github.com/repos/sindresorhus/grunt-php/subscription","commits_url":"https://api.github.com/repos/sindresorhus/grunt-php/commits{/sha}","git_commits_url":"https://api.github.com/repos/sindresorhus/grunt-php/git/commits{/sha}","comments_url":"https://api.github.com/repos/sindresorhus/grunt-php/comments{/number}","issue_comment_url":"https://api.github.com/repos/sindresorhus/grunt-php/issues/comments{/number}","contents_url":"https://api.github.com/repos/sindresorhus/grunt-php/contents/{+path}","compare_url":"https://api.github.com/repos/sindresorhus/grunt-php/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sindresorhus/grunt-php/merges","archive_url":"https://api.github.com/repos/sindresorhus/grunt-php/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sindresorhus/grunt-php/downloads","issues_url":"https://api.github.com/repos/sindresorhus/grunt-php/issues{/number}","pulls_url":"https://api.github.com/repos/sindresorhus/grunt-php/pulls{/number}","milestones_url":"https://api.github.com/repos/sindresorhus/grunt-php/milestones{/number}","notifications_url":"https://api.github.com/repos/sindresorhus/grunt-php/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sindresorhus/grunt-php/labels{/name}","releases_url":"https://api.github.com/repos/sindresorhus/grunt-php/releases{/id}","created_at":"2013-03-08T20:51:40Z","updated_at":"2015-04-10T10:36:41Z","pushed_at":"2015-04-11T17:43:19Z","git_url":"git://github.com/sindresorhus/grunt-php.git","ssh_url":"git@github.com:sindresorhus/grunt-php.git","clone_url":"https://github.com/sindresorhus/grunt-php.git","svn_url":"https://github.com/sindresorhus/grunt-php","homepage":"","size":639,"stargazers_count":220,"watchers_count":220,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":32,"mirror_url":null,"open_issues_count":3,"forks":32,"open_issues":3,"watchers":220,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sindresorhus/grunt-php/pulls/63"},"html":{"href":"https://github.com/sindresorhus/grunt-php/pull/63"},"issue":{"href":"https://api.github.com/repos/sindresorhus/grunt-php/issues/63"},"comments":{"href":"https://api.github.com/repos/sindresorhus/grunt-php/issues/63/comments"},"review_comments":{"href":"https://api.github.com/repos/sindresorhus/grunt-php/pulls/63/comments"},"review_comment":{"href":"https://api.github.com/repos/sindresorhus/grunt-php/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sindresorhus/grunt-php/pulls/63/commits"},"statuses":{"href":"https://api.github.com/repos/sindresorhus/grunt-php/statuses/2ad783948a1b31abedfd84c8fd55f20e26e139b3"}}}}