{"action":"created","comment":{"url":"https://api.github.com/repos/MarkUsProject/Markus/pulls/comments/33478584","id":33478584,"diff_hunk":"@@ -90,6 +90,23 @@\n   # \\n or \\0. These are the only restrictions.\n   VALIDATE_FILE = \"#{::Rails.root.to_s}/config/dummy_validate.sh\"\n \n+  # Normally exit status 0 means successful, 1 means no such user,\n+  # and 2 means wrong password.\n+  # The following allows for one additional custom exit status which also\n+  # represents a failure to log in, but says so with a custom string.\n+  # It is commented out by default because there is no additional custom\n+  # exit status by default.\n+  #VALIDATE_CUSTOM_EXIT_STATUS = 38","path":"config/environments/production.rb","position":10,"original_position":10,"commit_id":"3b34e37eafd13cac9f181c9f4fdf47484aef864f","original_commit_id":"3b34e37eafd13cac9f181c9f4fdf47484aef864f","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Missing space after #.","created_at":"2015-06-29T15:52:08Z","updated_at":"2015-06-29T15:52:08Z","html_url":"https://github.com/MarkUsProject/Markus/pull/2192#discussion_r33478584","pull_request_url":"https://api.github.com/repos/MarkUsProject/Markus/pulls/2192","_links":{"self":{"href":"https://api.github.com/repos/MarkUsProject/Markus/pulls/comments/33478584"},"html":{"href":"https://github.com/MarkUsProject/Markus/pull/2192#discussion_r33478584"},"pull_request":{"href":"https://api.github.com/repos/MarkUsProject/Markus/pulls/2192"}}},"pull_request":{"url":"https://api.github.com/repos/MarkUsProject/Markus/pulls/2192","id":38788185,"html_url":"https://github.com/MarkUsProject/Markus/pull/2192","diff_url":"https://github.com/MarkUsProject/Markus/pull/2192.diff","patch_url":"https://github.com/MarkUsProject/Markus/pull/2192.patch","issue_url":"https://api.github.com/repos/MarkUsProject/Markus/issues/2192","number":2192,"state":"open","locked":false,"title":"Added custom validation messages","user":{"login":"david-yz-liu","id":3333115,"avatar_url":"https://avatars.githubusercontent.com/u/3333115?v=3","gravatar_id":"","url":"https://api.github.com/users/david-yz-liu","html_url":"https://github.com/david-yz-liu","followers_url":"https://api.github.com/users/david-yz-liu/followers","following_url":"https://api.github.com/users/david-yz-liu/following{/other_user}","gists_url":"https://api.github.com/users/david-yz-liu/gists{/gist_id}","starred_url":"https://api.github.com/users/david-yz-liu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/david-yz-liu/subscriptions","organizations_url":"https://api.github.com/users/david-yz-liu/orgs","repos_url":"https://api.github.com/users/david-yz-liu/repos","events_url":"https://api.github.com/users/david-yz-liu/events{/privacy}","received_events_url":"https://api.github.com/users/david-yz-liu/received_events","type":"User","site_admin":false},"body":"Basically adding configuration that Alan's done manually before this.\r\n\r\nAlso adds a custom message for a valid user login but who is not found in the MarkUs database, and an invalid password.","created_at":"2015-06-29T15:52:04Z","updated_at":"2015-06-29T15:52:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"33192fa7682373e29137a43e96a12b487dff0a7f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/MarkUsProject/Markus/pulls/2192/commits","review_comments_url":"https://api.github.com/repos/MarkUsProject/Markus/pulls/2192/comments","review_comment_url":"https://api.github.com/repos/MarkUsProject/Markus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MarkUsProject/Markus/issues/2192/comments","statuses_url":"https://api.github.com/repos/MarkUsProject/Markus/statuses/3b34e37eafd13cac9f181c9f4fdf47484aef864f","head":{"label":"david-yz-liu:config-updates","ref":"config-updates","sha":"3b34e37eafd13cac9f181c9f4fdf47484aef864f","user":{"login":"david-yz-liu","id":3333115,"avatar_url":"https://avatars.githubusercontent.com/u/3333115?v=3","gravatar_id":"","url":"https://api.github.com/users/david-yz-liu","html_url":"https://github.com/david-yz-liu","followers_url":"https://api.github.com/users/david-yz-liu/followers","following_url":"https://api.github.com/users/david-yz-liu/following{/other_user}","gists_url":"https://api.github.com/users/david-yz-liu/gists{/gist_id}","starred_url":"https://api.github.com/users/david-yz-liu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/david-yz-liu/subscriptions","organizations_url":"https://api.github.com/users/david-yz-liu/orgs","repos_url":"https://api.github.com/users/david-yz-liu/repos","events_url":"https://api.github.com/users/david-yz-liu/events{/privacy}","received_events_url":"https://api.github.com/users/david-yz-liu/received_events","type":"User","site_admin":false},"repo":{"id":18498345,"name":"Markus","full_name":"david-yz-liu/Markus","owner":{"login":"david-yz-liu","id":3333115,"avatar_url":"https://avatars.githubusercontent.com/u/3333115?v=3","gravatar_id":"","url":"https://api.github.com/users/david-yz-liu","html_url":"https://github.com/david-yz-liu","followers_url":"https://api.github.com/users/david-yz-liu/followers","following_url":"https://api.github.com/users/david-yz-liu/following{/other_user}","gists_url":"https://api.github.com/users/david-yz-liu/gists{/gist_id}","starred_url":"https://api.github.com/users/david-yz-liu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/david-yz-liu/subscriptions","organizations_url":"https://api.github.com/users/david-yz-liu/orgs","repos_url":"https://api.github.com/users/david-yz-liu/repos","events_url":"https://api.github.com/users/david-yz-liu/events{/privacy}","received_events_url":"https://api.github.com/users/david-yz-liu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/david-yz-liu/Markus","description":"Git repository of MarkUs","fork":true,"url":"https://api.github.com/repos/david-yz-liu/Markus","forks_url":"https://api.github.com/repos/david-yz-liu/Markus/forks","keys_url":"https://api.github.com/repos/david-yz-liu/Markus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/david-yz-liu/Markus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/david-yz-liu/Markus/teams","hooks_url":"https://api.github.com/repos/david-yz-liu/Markus/hooks","issue_events_url":"https://api.github.com/repos/david-yz-liu/Markus/issues/events{/number}","events_url":"https://api.github.com/repos/david-yz-liu/Markus/events","assignees_url":"https://api.github.com/repos/david-yz-liu/Markus/assignees{/user}","branches_url":"https://api.github.com/repos/david-yz-liu/Markus/branches{/branch}","tags_url":"https://api.github.com/repos/david-yz-liu/Markus/tags","blobs_url":"https://api.github.com/repos/david-yz-liu/Markus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/david-yz-liu/Markus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/david-yz-liu/Markus/git/refs{/sha}","trees_url":"https://api.github.com/repos/david-yz-liu/Markus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/david-yz-liu/Markus/statuses/{sha}","languages_url":"https://api.github.com/repos/david-yz-liu/Markus/languages","stargazers_url":"https://api.github.com/repos/david-yz-liu/Markus/stargazers","contributors_url":"https://api.github.com/repos/david-yz-liu/Markus/contributors","subscribers_url":"https://api.github.com/repos/david-yz-liu/Markus/subscribers","subscription_url":"https://api.github.com/repos/david-yz-liu/Markus/subscription","commits_url":"https://api.github.com/repos/david-yz-liu/Markus/commits{/sha}","git_commits_url":"https://api.github.com/repos/david-yz-liu/Markus/git/commits{/sha}","comments_url":"https://api.github.com/repos/david-yz-liu/Markus/comments{/number}","issue_comment_url":"https://api.github.com/repos/david-yz-liu/Markus/issues/comments{/number}","contents_url":"https://api.github.com/repos/david-yz-liu/Markus/contents/{+path}","compare_url":"https://api.github.com/repos/david-yz-liu/Markus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/david-yz-liu/Markus/merges","archive_url":"https://api.github.com/repos/david-yz-liu/Markus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/david-yz-liu/Markus/downloads","issues_url":"https://api.github.com/repos/david-yz-liu/Markus/issues{/number}","pulls_url":"https://api.github.com/repos/david-yz-liu/Markus/pulls{/number}","milestones_url":"https://api.github.com/repos/david-yz-liu/Markus/milestones{/number}","notifications_url":"https://api.github.com/repos/david-yz-liu/Markus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/david-yz-liu/Markus/labels{/name}","releases_url":"https://api.github.com/repos/david-yz-liu/Markus/releases{/id}","created_at":"2014-04-06T20:18:54Z","updated_at":"2014-11-07T03:11:01Z","pushed_at":"2015-06-29T15:49:49Z","git_url":"git://github.com/david-yz-liu/Markus.git","ssh_url":"git@github.com:david-yz-liu/Markus.git","clone_url":"https://github.com/david-yz-liu/Markus.git","svn_url":"https://github.com/david-yz-liu/Markus","homepage":"http://www.markusproject.org","size":30265,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"MarkUsProject:master","ref":"master","sha":"7378487d9fece01d39a7a89bc45b6bc1451e28d7","user":{"login":"MarkUsProject","id":415874,"avatar_url":"https://avatars.githubusercontent.com/u/415874?v=3","gravatar_id":"","url":"https://api.github.com/users/MarkUsProject","html_url":"https://github.com/MarkUsProject","followers_url":"https://api.github.com/users/MarkUsProject/followers","following_url":"https://api.github.com/users/MarkUsProject/following{/other_user}","gists_url":"https://api.github.com/users/MarkUsProject/gists{/gist_id}","starred_url":"https://api.github.com/users/MarkUsProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarkUsProject/subscriptions","organizations_url":"https://api.github.com/users/MarkUsProject/orgs","repos_url":"https://api.github.com/users/MarkUsProject/repos","events_url":"https://api.github.com/users/MarkUsProject/events{/privacy}","received_events_url":"https://api.github.com/users/MarkUsProject/received_events","type":"Organization","site_admin":false},"repo":{"id":940538,"name":"Markus","full_name":"MarkUsProject/Markus","owner":{"login":"MarkUsProject","id":415874,"avatar_url":"https://avatars.githubusercontent.com/u/415874?v=3","gravatar_id":"","url":"https://api.github.com/users/MarkUsProject","html_url":"https://github.com/MarkUsProject","followers_url":"https://api.github.com/users/MarkUsProject/followers","following_url":"https://api.github.com/users/MarkUsProject/following{/other_user}","gists_url":"https://api.github.com/users/MarkUsProject/gists{/gist_id}","starred_url":"https://api.github.com/users/MarkUsProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarkUsProject/subscriptions","organizations_url":"https://api.github.com/users/MarkUsProject/orgs","repos_url":"https://api.github.com/users/MarkUsProject/repos","events_url":"https://api.github.com/users/MarkUsProject/events{/privacy}","received_events_url":"https://api.github.com/users/MarkUsProject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MarkUsProject/Markus","description":"Git repository of MarkUs","fork":false,"url":"https://api.github.com/repos/MarkUsProject/Markus","forks_url":"https://api.github.com/repos/MarkUsProject/Markus/forks","keys_url":"https://api.github.com/repos/MarkUsProject/Markus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MarkUsProject/Markus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MarkUsProject/Markus/teams","hooks_url":"https://api.github.com/repos/MarkUsProject/Markus/hooks","issue_events_url":"https://api.github.com/repos/MarkUsProject/Markus/issues/events{/number}","events_url":"https://api.github.com/repos/MarkUsProject/Markus/events","assignees_url":"https://api.github.com/repos/MarkUsProject/Markus/assignees{/user}","branches_url":"https://api.github.com/repos/MarkUsProject/Markus/branches{/branch}","tags_url":"https://api.github.com/repos/MarkUsProject/Markus/tags","blobs_url":"https://api.github.com/repos/MarkUsProject/Markus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MarkUsProject/Markus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MarkUsProject/Markus/git/refs{/sha}","trees_url":"https://api.github.com/repos/MarkUsProject/Markus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MarkUsProject/Markus/statuses/{sha}","languages_url":"https://api.github.com/repos/MarkUsProject/Markus/languages","stargazers_url":"https://api.github.com/repos/MarkUsProject/Markus/stargazers","contributors_url":"https://api.github.com/repos/MarkUsProject/Markus/contributors","subscribers_url":"https://api.github.com/repos/MarkUsProject/Markus/subscribers","subscription_url":"https://api.github.com/repos/MarkUsProject/Markus/subscription","commits_url":"https://api.github.com/repos/MarkUsProject/Markus/commits{/sha}","git_commits_url":"https://api.github.com/repos/MarkUsProject/Markus/git/commits{/sha}","comments_url":"https://api.github.com/repos/MarkUsProject/Markus/comments{/number}","issue_comment_url":"https://api.github.com/repos/MarkUsProject/Markus/issues/comments{/number}","contents_url":"https://api.github.com/repos/MarkUsProject/Markus/contents/{+path}","compare_url":"https://api.github.com/repos/MarkUsProject/Markus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MarkUsProject/Markus/merges","archive_url":"https://api.github.com/repos/MarkUsProject/Markus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MarkUsProject/Markus/downloads","issues_url":"https://api.github.com/repos/MarkUsProject/Markus/issues{/number}","pulls_url":"https://api.github.com/repos/MarkUsProject/Markus/pulls{/number}","milestones_url":"https://api.github.com/repos/MarkUsProject/Markus/milestones{/number}","notifications_url":"https://api.github.com/repos/MarkUsProject/Markus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MarkUsProject/Markus/labels{/name}","releases_url":"https://api.github.com/repos/MarkUsProject/Markus/releases{/id}","created_at":"2010-09-26T16:18:08Z","updated_at":"2015-05-11T07:04:07Z","pushed_at":"2015-06-29T15:52:04Z","git_url":"git://github.com/MarkUsProject/Markus.git","ssh_url":"git@github.com:MarkUsProject/Markus.git","clone_url":"https://github.com/MarkUsProject/Markus.git","svn_url":"https://github.com/MarkUsProject/Markus","homepage":"http://www.markusproject.org","size":48538,"stargazers_count":125,"watchers_count":125,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":152,"mirror_url":null,"open_issues_count":89,"forks":152,"open_issues":89,"watchers":125,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MarkUsProject/Markus/pulls/2192"},"html":{"href":"https://github.com/MarkUsProject/Markus/pull/2192"},"issue":{"href":"https://api.github.com/repos/MarkUsProject/Markus/issues/2192"},"comments":{"href":"https://api.github.com/repos/MarkUsProject/Markus/issues/2192/comments"},"review_comments":{"href":"https://api.github.com/repos/MarkUsProject/Markus/pulls/2192/comments"},"review_comment":{"href":"https://api.github.com/repos/MarkUsProject/Markus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MarkUsProject/Markus/pulls/2192/commits"},"statuses":{"href":"https://api.github.com/repos/MarkUsProject/Markus/statuses/3b34e37eafd13cac9f181c9f4fdf47484aef864f"}}}}