{"action":"created","issue":{"url":"https://api.github.com/repos/LMMS/lmms/issues/1981","labels_url":"https://api.github.com/repos/LMMS/lmms/issues/1981/labels{/name}","comments_url":"https://api.github.com/repos/LMMS/lmms/issues/1981/comments","events_url":"https://api.github.com/repos/LMMS/lmms/issues/1981/events","html_url":"https://github.com/LMMS/lmms/issues/1981","id":69357628,"number":1981,"title":"Midi Import crash in master branch","user":{"login":"midi-pascal","id":6962451,"avatar_url":"https://avatars.githubusercontent.com/u/6962451?v=3","gravatar_id":"","url":"https://api.github.com/users/midi-pascal","html_url":"https://github.com/midi-pascal","followers_url":"https://api.github.com/users/midi-pascal/followers","following_url":"https://api.github.com/users/midi-pascal/following{/other_user}","gists_url":"https://api.github.com/users/midi-pascal/gists{/gist_id}","starred_url":"https://api.github.com/users/midi-pascal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/midi-pascal/subscriptions","organizations_url":"https://api.github.com/users/midi-pascal/orgs","repos_url":"https://api.github.com/users/midi-pascal/repos","events_url":"https://api.github.com/users/midi-pascal/events{/privacy}","received_events_url":"https://api.github.com/users/midi-pascal/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2015-04-18T23:01:58Z","updated_at":"2015-04-21T08:35:19Z","closed_at":null,"body":"Midi Import crash when importing some files in master branch.\r\nVersion 1.0 does not crash when importing the same files.\r\n\r\nThe bug lies within the MidiImport::readSMF method when tracing unhandled Midi events.\r\nThe crash occurs there:\r\n`\t\t\t\tif(!handled) {`\r\n`\t\t\t\t\tprintf(\"MISSING GLOBAL THINGY\\n\");`\r\n`\t\t\t\t\tprintf(\"     %d %d %f %s %s\\n\", (int) evt->chan,`\r\n`\t\t\t\t\t       evt->get_type_code(), evt->time,`\r\n`\t\t\t\t\t       evt->get_attribute(), evt->get_atom_value() );`\r\n`\t\t\t\t\t// Global stuff`\r\n`\t\t\t\t}`\r\n\r\nIt looks like at least one Midi event type is not decoded properly.\r\nAlso - if I remember well - we are not supposed to use printf() to make a trace, uh?\r\nActually I try to solve this issue.\r\nMore to come :-)"},"comment":{"url":"https://api.github.com/repos/LMMS/lmms/issues/comments/94702558","html_url":"https://github.com/LMMS/lmms/issues/1981#issuecomment-94702558","issue_url":"https://api.github.com/repos/LMMS/lmms/issues/1981","id":94702558,"user":{"login":"mikobuntu","id":335217,"avatar_url":"https://avatars.githubusercontent.com/u/335217?v=3","gravatar_id":"","url":"https://api.github.com/users/mikobuntu","html_url":"https://github.com/mikobuntu","followers_url":"https://api.github.com/users/mikobuntu/followers","following_url":"https://api.github.com/users/mikobuntu/following{/other_user}","gists_url":"https://api.github.com/users/mikobuntu/gists{/gist_id}","starred_url":"https://api.github.com/users/mikobuntu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikobuntu/subscriptions","organizations_url":"https://api.github.com/users/mikobuntu/orgs","repos_url":"https://api.github.com/users/mikobuntu/repos","events_url":"https://api.github.com/users/mikobuntu/events{/privacy}","received_events_url":"https://api.github.com/users/mikobuntu/received_events","type":"User","site_admin":false},"created_at":"2015-04-21T08:35:19Z","updated_at":"2015-04-21T08:35:19Z","body":"You can easily embed an audio file into a .gif by using \" cat some.gif some.mp3 > another.gif \" but for easy extraction I'm unsure."}}