{"action":"created","comment":{"url":"https://api.github.com/repos/angular/angular.js/pulls/comments/25612599","id":25612599,"diff_hunk":"@@ -625,12 +639,16 @@ var inputType = {\n              }]);\n          </script>\n          <form name=\"myForm\" ng-controller=\"ExampleController\">\n-           Number: <input type=\"number\" name=\"input\" ng-model=\"example.value\"\n-                          min=\"0\" max=\"99\" required>\n-           <span class=\"error\" ng-show=\"myForm.input.$error.required\">\n-             Required!</span>\n-           <span class=\"error\" ng-show=\"myForm.input.$error.number\">\n-             Not valid number!</span>\n+           <label>Number:\n+             <input type=\"number\" name=\"input\" ng-model=\"example.value\"\n+                  min=\"0\" max=\"99\" required>","path":"src/ng/directive/input.js","position":143,"original_position":143,"commit_id":"76cca2de00afaf7e2eb8eadb9dab444d032a7732","original_commit_id":"76cca2de00afaf7e2eb8eadb9dab444d032a7732","user":{"login":"ckundo","id":108163,"avatar_url":"https://avatars.githubusercontent.com/u/108163?v=3","gravatar_id":"","url":"https://api.github.com/users/ckundo","html_url":"https://github.com/ckundo","followers_url":"https://api.github.com/users/ckundo/followers","following_url":"https://api.github.com/users/ckundo/following{/other_user}","gists_url":"https://api.github.com/users/ckundo/gists{/gist_id}","starred_url":"https://api.github.com/users/ckundo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckundo/subscriptions","organizations_url":"https://api.github.com/users/ckundo/orgs","repos_url":"https://api.github.com/users/ckundo/repos","events_url":"https://api.github.com/users/ckundo/events{/privacy}","received_events_url":"https://api.github.com/users/ckundo/received_events","type":"User","site_admin":false},"body":"Attributes don't line up here.","created_at":"2015-03-02T16:35:42Z","updated_at":"2015-03-02T16:35:42Z","html_url":"https://github.com/angular/angular.js/pull/11079#discussion_r25612599","pull_request_url":"https://api.github.com/repos/angular/angular.js/pulls/11079","_links":{"self":{"href":"https://api.github.com/repos/angular/angular.js/pulls/comments/25612599"},"html":{"href":"https://github.com/angular/angular.js/pull/11079#discussion_r25612599"},"pull_request":{"href":"https://api.github.com/repos/angular/angular.js/pulls/11079"}}},"pull_request":{"url":"https://api.github.com/repos/angular/angular.js/pulls/11079","id":29410261,"html_url":"https://github.com/angular/angular.js/pull/11079","diff_url":"https://github.com/angular/angular.js/pull/11079.diff","patch_url":"https://github.com/angular/angular.js/pull/11079.patch","issue_url":"https://api.github.com/repos/angular/angular.js/issues/11079","number":11079,"state":"open","locked":false,"title":"docs(input): better accessibility in examples","user":{"login":"marcysutton","id":1045233,"avatar_url":"https://avatars.githubusercontent.com/u/1045233?v=3","gravatar_id":"","url":"https://api.github.com/users/marcysutton","html_url":"https://github.com/marcysutton","followers_url":"https://api.github.com/users/marcysutton/followers","following_url":"https://api.github.com/users/marcysutton/following{/other_user}","gists_url":"https://api.github.com/users/marcysutton/gists{/gist_id}","starred_url":"https://api.github.com/users/marcysutton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcysutton/subscriptions","organizations_url":"https://api.github.com/users/marcysutton/orgs","repos_url":"https://api.github.com/users/marcysutton/repos","events_url":"https://api.github.com/users/marcysutton/events{/privacy}","received_events_url":"https://api.github.com/users/marcysutton/received_events","type":"User","site_admin":false},"body":"The input and ngModel docs examples have no labels or accessible error handling. They could do more to encourage accessibility best practices. This change does two things:\r\n\r\n 1. Adds labels to each input.\r\n 1. Wraps error messages with `role=\"alert\" so they will announce in a screen reader.\r\n\r\nEven though Angular 2.0 is coming soon, these docs will live on with the 1.0 project so it makes sense to show more accessible examples. (Better late than never.)","created_at":"2015-02-17T00:37:28Z","updated_at":"2015-03-02T16:35:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d1dd3a7147824dbdceeb1263a030d05caa03938d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/angular/angular.js/pulls/11079/commits","review_comments_url":"https://api.github.com/repos/angular/angular.js/pulls/11079/comments","review_comment_url":"https://api.github.com/repos/angular/angular.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/angular.js/issues/11079/comments","statuses_url":"https://api.github.com/repos/angular/angular.js/statuses/76cca2de00afaf7e2eb8eadb9dab444d032a7732","head":{"label":"marcysutton:input-docs","ref":"input-docs","sha":"76cca2de00afaf7e2eb8eadb9dab444d032a7732","user":{"login":"marcysutton","id":1045233,"avatar_url":"https://avatars.githubusercontent.com/u/1045233?v=3","gravatar_id":"","url":"https://api.github.com/users/marcysutton","html_url":"https://github.com/marcysutton","followers_url":"https://api.github.com/users/marcysutton/followers","following_url":"https://api.github.com/users/marcysutton/following{/other_user}","gists_url":"https://api.github.com/users/marcysutton/gists{/gist_id}","starred_url":"https://api.github.com/users/marcysutton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcysutton/subscriptions","organizations_url":"https://api.github.com/users/marcysutton/orgs","repos_url":"https://api.github.com/users/marcysutton/repos","events_url":"https://api.github.com/users/marcysutton/events{/privacy}","received_events_url":"https://api.github.com/users/marcysutton/received_events","type":"User","site_admin":false},"repo":{"id":24772089,"name":"angular.js","full_name":"marcysutton/angular.js","owner":{"login":"marcysutton","id":1045233,"avatar_url":"https://avatars.githubusercontent.com/u/1045233?v=3","gravatar_id":"","url":"https://api.github.com/users/marcysutton","html_url":"https://github.com/marcysutton","followers_url":"https://api.github.com/users/marcysutton/followers","following_url":"https://api.github.com/users/marcysutton/following{/other_user}","gists_url":"https://api.github.com/users/marcysutton/gists{/gist_id}","starred_url":"https://api.github.com/users/marcysutton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcysutton/subscriptions","organizations_url":"https://api.github.com/users/marcysutton/orgs","repos_url":"https://api.github.com/users/marcysutton/repos","events_url":"https://api.github.com/users/marcysutton/events{/privacy}","received_events_url":"https://api.github.com/users/marcysutton/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/marcysutton/angular.js","description":"HTML enhanced for web apps","fork":true,"url":"https://api.github.com/repos/marcysutton/angular.js","forks_url":"https://api.github.com/repos/marcysutton/angular.js/forks","keys_url":"https://api.github.com/repos/marcysutton/angular.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marcysutton/angular.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marcysutton/angular.js/teams","hooks_url":"https://api.github.com/repos/marcysutton/angular.js/hooks","issue_events_url":"https://api.github.com/repos/marcysutton/angular.js/issues/events{/number}","events_url":"https://api.github.com/repos/marcysutton/angular.js/events","assignees_url":"https://api.github.com/repos/marcysutton/angular.js/assignees{/user}","branches_url":"https://api.github.com/repos/marcysutton/angular.js/branches{/branch}","tags_url":"https://api.github.com/repos/marcysutton/angular.js/tags","blobs_url":"https://api.github.com/repos/marcysutton/angular.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marcysutton/angular.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marcysutton/angular.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/marcysutton/angular.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marcysutton/angular.js/statuses/{sha}","languages_url":"https://api.github.com/repos/marcysutton/angular.js/languages","stargazers_url":"https://api.github.com/repos/marcysutton/angular.js/stargazers","contributors_url":"https://api.github.com/repos/marcysutton/angular.js/contributors","subscribers_url":"https://api.github.com/repos/marcysutton/angular.js/subscribers","subscription_url":"https://api.github.com/repos/marcysutton/angular.js/subscription","commits_url":"https://api.github.com/repos/marcysutton/angular.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/marcysutton/angular.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/marcysutton/angular.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/marcysutton/angular.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/marcysutton/angular.js/contents/{+path}","compare_url":"https://api.github.com/repos/marcysutton/angular.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marcysutton/angular.js/merges","archive_url":"https://api.github.com/repos/marcysutton/angular.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marcysutton/angular.js/downloads","issues_url":"https://api.github.com/repos/marcysutton/angular.js/issues{/number}","pulls_url":"https://api.github.com/repos/marcysutton/angular.js/pulls{/number}","milestones_url":"https://api.github.com/repos/marcysutton/angular.js/milestones{/number}","notifications_url":"https://api.github.com/repos/marcysutton/angular.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marcysutton/angular.js/labels{/name}","releases_url":"https://api.github.com/repos/marcysutton/angular.js/releases{/id}","created_at":"2014-10-03T20:09:52Z","updated_at":"2014-10-03T20:15:47Z","pushed_at":"2015-03-01T23:31:45Z","git_url":"git://github.com/marcysutton/angular.js.git","ssh_url":"git@github.com:marcysutton/angular.js.git","clone_url":"https://github.com/marcysutton/angular.js.git","svn_url":"https://github.com/marcysutton/angular.js","homepage":"http://angularjs.org","size":62847,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"7cfa79e98e54a7738722c0453432b70fbde1b6e7","user":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":460078,"name":"angular.js","full_name":"angular/angular.js","owner":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/angular.js","description":"HTML enhanced for web apps","fork":false,"url":"https://api.github.com/repos/angular/angular.js","forks_url":"https://api.github.com/repos/angular/angular.js/forks","keys_url":"https://api.github.com/repos/angular/angular.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/angular.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/angular.js/teams","hooks_url":"https://api.github.com/repos/angular/angular.js/hooks","issue_events_url":"https://api.github.com/repos/angular/angular.js/issues/events{/number}","events_url":"https://api.github.com/repos/angular/angular.js/events","assignees_url":"https://api.github.com/repos/angular/angular.js/assignees{/user}","branches_url":"https://api.github.com/repos/angular/angular.js/branches{/branch}","tags_url":"https://api.github.com/repos/angular/angular.js/tags","blobs_url":"https://api.github.com/repos/angular/angular.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/angular.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/angular.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/angular.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/angular.js/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/angular.js/languages","stargazers_url":"https://api.github.com/repos/angular/angular.js/stargazers","contributors_url":"https://api.github.com/repos/angular/angular.js/contributors","subscribers_url":"https://api.github.com/repos/angular/angular.js/subscribers","subscription_url":"https://api.github.com/repos/angular/angular.js/subscription","commits_url":"https://api.github.com/repos/angular/angular.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/angular.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/angular.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/angular.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/angular.js/contents/{+path}","compare_url":"https://api.github.com/repos/angular/angular.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/angular.js/merges","archive_url":"https://api.github.com/repos/angular/angular.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/angular.js/downloads","issues_url":"https://api.github.com/repos/angular/angular.js/issues{/number}","pulls_url":"https://api.github.com/repos/angular/angular.js/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/angular.js/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/angular.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/angular.js/labels{/name}","releases_url":"https://api.github.com/repos/angular/angular.js/releases{/id}","created_at":"2010-01-06T00:34:37Z","updated_at":"2015-03-02T16:32:02Z","pushed_at":"2015-03-02T13:49:29Z","git_url":"git://github.com/angular/angular.js.git","ssh_url":"git@github.com:angular/angular.js.git","clone_url":"https://github.com/angular/angular.js.git","svn_url":"https://github.com/angular/angular.js","homepage":"http://angularjs.org","size":219554,"stargazers_count":35767,"watchers_count":35767,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14582,"mirror_url":null,"open_issues_count":1150,"forks":14582,"open_issues":1150,"watchers":35767,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/angular.js/pulls/11079"},"html":{"href":"https://github.com/angular/angular.js/pull/11079"},"issue":{"href":"https://api.github.com/repos/angular/angular.js/issues/11079"},"comments":{"href":"https://api.github.com/repos/angular/angular.js/issues/11079/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/angular.js/pulls/11079/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/angular.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/angular.js/pulls/11079/commits"},"statuses":{"href":"https://api.github.com/repos/angular/angular.js/statuses/76cca2de00afaf7e2eb8eadb9dab444d032a7732"}}}}