{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/42761997","id":42761997,"diff_hunk":"@@ -18,6 +18,33 @@ WARNING:   When setting properties based on their current state (for example:\n -->\n <Project ToolsVersion=\"4.0\" xmlns=\"http://schemas.microsoft.com/developer/msbuild/2003\">\n \n+  <ItemGroup>\n+    <CLRTestEnvironmentVariable Condition=\"'$(CrossGen)' == 'true'\" Include=\"set complus_zaprequire=1\" />\n+    <CLRTestEnvironmentVariable Condition=\"'$(CrossGen)' == 'true'\" Include=\"set complus_zaprequireexcludelist=corerun\" />","path":"tests/src/CLRTest.Execute.Batch.targets","position":6,"original_position":6,"commit_id":"a3b6dba8747714df1d312fd998a17ef12945a55a","original_commit_id":"a3b6dba8747714df1d312fd998a17ef12945a55a","user":{"login":"JohnChen0","id":10659588,"avatar_url":"https://avatars.githubusercontent.com/u/10659588?v=3","gravatar_id":"","url":"https://api.github.com/users/JohnChen0","html_url":"https://github.com/JohnChen0","followers_url":"https://api.github.com/users/JohnChen0/followers","following_url":"https://api.github.com/users/JohnChen0/following{/other_user}","gists_url":"https://api.github.com/users/JohnChen0/gists{/gist_id}","starred_url":"https://api.github.com/users/JohnChen0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohnChen0/subscriptions","organizations_url":"https://api.github.com/users/JohnChen0/orgs","repos_url":"https://api.github.com/users/JohnChen0/repos","events_url":"https://api.github.com/users/JohnChen0/events{/privacy}","received_events_url":"https://api.github.com/users/JohnChen0/received_events","type":"User","site_admin":false},"body":"I'm surprised that it's necessary to add corerun to zaprequireexcludelist, since it's an unmanaged app.","created_at":"2015-10-22T15:19:23Z","updated_at":"2015-10-22T15:19:23Z","html_url":"https://github.com/dotnet/coreclr/pull/1832#discussion_r42761997","pull_request_url":"https://api.github.com/repos/dotnet/coreclr/pulls/1832","_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/42761997"},"html":{"href":"https://github.com/dotnet/coreclr/pull/1832#discussion_r42761997"},"pull_request":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/1832"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/1832","id":48413752,"html_url":"https://github.com/dotnet/coreclr/pull/1832","diff_url":"https://github.com/dotnet/coreclr/pull/1832.diff","patch_url":"https://github.com/dotnet/coreclr/pull/1832.patch","issue_url":"https://api.github.com/repos/dotnet/coreclr/issues/1832","number":1832,"state":"open","locked":false,"title":"[WIP] Changes required to enable crossgen on the tests.","user":{"login":"bryanar","id":7455322,"avatar_url":"https://avatars.githubusercontent.com/u/7455322?v=3","gravatar_id":"","url":"https://api.github.com/users/bryanar","html_url":"https://github.com/bryanar","followers_url":"https://api.github.com/users/bryanar/followers","following_url":"https://api.github.com/users/bryanar/following{/other_user}","gists_url":"https://api.github.com/users/bryanar/gists{/gist_id}","starred_url":"https://api.github.com/users/bryanar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bryanar/subscriptions","organizations_url":"https://api.github.com/users/bryanar/orgs","repos_url":"https://api.github.com/users/bryanar/repos","events_url":"https://api.github.com/users/bryanar/events{/privacy}","received_events_url":"https://api.github.com/users/bryanar/received_events","type":"User","site_admin":false},"body":"Known issues: \r\n- Remove excessive output from Crossgen messages in the build.","created_at":"2015-10-22T03:22:45Z","updated_at":"2015-10-22T15:19:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cc0d0485f34fa226c13a8aa5b83b9a036ea67da1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/coreclr/pulls/1832/commits","review_comments_url":"https://api.github.com/repos/dotnet/coreclr/pulls/1832/comments","review_comment_url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/coreclr/issues/1832/comments","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/a3b6dba8747714df1d312fd998a17ef12945a55a","head":{"label":"bryanar:enable_crossgen_tests","ref":"enable_crossgen_tests","sha":"a3b6dba8747714df1d312fd998a17ef12945a55a","user":{"login":"bryanar","id":7455322,"avatar_url":"https://avatars.githubusercontent.com/u/7455322?v=3","gravatar_id":"","url":"https://api.github.com/users/bryanar","html_url":"https://github.com/bryanar","followers_url":"https://api.github.com/users/bryanar/followers","following_url":"https://api.github.com/users/bryanar/following{/other_user}","gists_url":"https://api.github.com/users/bryanar/gists{/gist_id}","starred_url":"https://api.github.com/users/bryanar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bryanar/subscriptions","organizations_url":"https://api.github.com/users/bryanar/orgs","repos_url":"https://api.github.com/users/bryanar/repos","events_url":"https://api.github.com/users/bryanar/events{/privacy}","received_events_url":"https://api.github.com/users/bryanar/received_events","type":"User","site_admin":false},"repo":{"id":43458921,"name":"coreclr","full_name":"bryanar/coreclr","owner":{"login":"bryanar","id":7455322,"avatar_url":"https://avatars.githubusercontent.com/u/7455322?v=3","gravatar_id":"","url":"https://api.github.com/users/bryanar","html_url":"https://github.com/bryanar","followers_url":"https://api.github.com/users/bryanar/followers","following_url":"https://api.github.com/users/bryanar/following{/other_user}","gists_url":"https://api.github.com/users/bryanar/gists{/gist_id}","starred_url":"https://api.github.com/users/bryanar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bryanar/subscriptions","organizations_url":"https://api.github.com/users/bryanar/orgs","repos_url":"https://api.github.com/users/bryanar/repos","events_url":"https://api.github.com/users/bryanar/events{/privacy}","received_events_url":"https://api.github.com/users/bryanar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bryanar/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called mscorlib. It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes.","fork":true,"url":"https://api.github.com/repos/bryanar/coreclr","forks_url":"https://api.github.com/repos/bryanar/coreclr/forks","keys_url":"https://api.github.com/repos/bryanar/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bryanar/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bryanar/coreclr/teams","hooks_url":"https://api.github.com/repos/bryanar/coreclr/hooks","issue_events_url":"https://api.github.com/repos/bryanar/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/bryanar/coreclr/events","assignees_url":"https://api.github.com/repos/bryanar/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/bryanar/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/bryanar/coreclr/tags","blobs_url":"https://api.github.com/repos/bryanar/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bryanar/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bryanar/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/bryanar/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bryanar/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/bryanar/coreclr/languages","stargazers_url":"https://api.github.com/repos/bryanar/coreclr/stargazers","contributors_url":"https://api.github.com/repos/bryanar/coreclr/contributors","subscribers_url":"https://api.github.com/repos/bryanar/coreclr/subscribers","subscription_url":"https://api.github.com/repos/bryanar/coreclr/subscription","commits_url":"https://api.github.com/repos/bryanar/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/bryanar/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/bryanar/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/bryanar/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/bryanar/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/bryanar/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bryanar/coreclr/merges","archive_url":"https://api.github.com/repos/bryanar/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bryanar/coreclr/downloads","issues_url":"https://api.github.com/repos/bryanar/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/bryanar/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/bryanar/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/bryanar/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bryanar/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/bryanar/coreclr/releases{/id}","created_at":"2015-09-30T21:01:17Z","updated_at":"2015-09-30T21:02:00Z","pushed_at":"2015-10-22T03:20:33Z","git_url":"git://github.com/bryanar/coreclr.git","ssh_url":"git@github.com:bryanar/coreclr.git","clone_url":"https://github.com/bryanar/coreclr.git","svn_url":"https://github.com/bryanar/coreclr","homepage":"http://dotnet.github.io/core/","size":42111,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"ec209f65458ed447434d8b2186187c0444c8d227","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":30092893,"name":"coreclr","full_name":"dotnet/coreclr","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called mscorlib. It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes.","fork":false,"url":"https://api.github.com/repos/dotnet/coreclr","forks_url":"https://api.github.com/repos/dotnet/coreclr/forks","keys_url":"https://api.github.com/repos/dotnet/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/coreclr/teams","hooks_url":"https://api.github.com/repos/dotnet/coreclr/hooks","issue_events_url":"https://api.github.com/repos/dotnet/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/coreclr/events","assignees_url":"https://api.github.com/repos/dotnet/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/coreclr/tags","blobs_url":"https://api.github.com/repos/dotnet/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/coreclr/languages","stargazers_url":"https://api.github.com/repos/dotnet/coreclr/stargazers","contributors_url":"https://api.github.com/repos/dotnet/coreclr/contributors","subscribers_url":"https://api.github.com/repos/dotnet/coreclr/subscribers","subscription_url":"https://api.github.com/repos/dotnet/coreclr/subscription","commits_url":"https://api.github.com/repos/dotnet/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/coreclr/merges","archive_url":"https://api.github.com/repos/dotnet/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/coreclr/downloads","issues_url":"https://api.github.com/repos/dotnet/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/coreclr/releases{/id}","created_at":"2015-01-30T22:10:02Z","updated_at":"2015-10-22T11:06:26Z","pushed_at":"2015-10-22T05:43:33Z","git_url":"git://github.com/dotnet/coreclr.git","ssh_url":"git@github.com:dotnet/coreclr.git","clone_url":"https://github.com/dotnet/coreclr.git","svn_url":"https://github.com/dotnet/coreclr","homepage":"http://dotnet.github.io/core/","size":68167,"stargazers_count":5298,"watchers_count":5298,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1084,"mirror_url":null,"open_issues_count":330,"forks":1084,"open_issues":330,"watchers":5298,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/1832"},"html":{"href":"https://github.com/dotnet/coreclr/pull/1832"},"issue":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/1832"},"comments":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/1832/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/1832/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/1832/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/coreclr/statuses/a3b6dba8747714df1d312fd998a17ef12945a55a"}}}}