{"action":"created","issue":{"url":"https://api.github.com/repos/ember-cli/ember-cli/issues/4931","labels_url":"https://api.github.com/repos/ember-cli/ember-cli/issues/4931/labels{/name}","comments_url":"https://api.github.com/repos/ember-cli/ember-cli/issues/4931/comments","events_url":"https://api.github.com/repos/ember-cli/ember-cli/issues/4931/events","html_url":"https://github.com/ember-cli/ember-cli/pull/4931","id":109620024,"number":4931,"title":"[WIP][Feature] Clean command","user":{"login":"beatle","id":875361,"avatar_url":"https://avatars.githubusercontent.com/u/875361?v=3","gravatar_id":"","url":"https://api.github.com/users/beatle","html_url":"https://github.com/beatle","followers_url":"https://api.github.com/users/beatle/followers","following_url":"https://api.github.com/users/beatle/following{/other_user}","gists_url":"https://api.github.com/users/beatle/gists{/gist_id}","starred_url":"https://api.github.com/users/beatle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beatle/subscriptions","organizations_url":"https://api.github.com/users/beatle/orgs","repos_url":"https://api.github.com/users/beatle/repos","events_url":"https://api.github.com/users/beatle/events{/privacy}","received_events_url":"https://api.github.com/users/beatle/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-10-03T12:01:39Z","updated_at":"2015-10-06T18:01:13Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ember-cli/ember-cli/pulls/4931","html_url":"https://github.com/ember-cli/ember-cli/pull/4931","diff_url":"https://github.com/ember-cli/ember-cli/pull/4931.diff","patch_url":"https://github.com/ember-cli/ember-cli/pull/4931.patch"},"body":"Idea originated from here #4819 \r\n\r\nIt's an a raw implementation but it looks like most of work is done.\r\nCurrently clean command handles `--skip-npm` and `--skip-bower` flags.\r\nYou can also specify `--output-path` to customize dist/ folder path.\r\n\r\nHave few questions as for required tests.\r\n\r\nLooks like `node_modules/` and `tmp/` are not configurable paths. So it's not obvious for me whether it should be tested via acceptance tests or not.\r\nIf yes I'm happy to hear any directions on how to properly isolate project for acceptance test and play with directories inside(node_modules, bower directory, output-path and tmp).\r\n\r\nAlso cannot figure out how to effectively provide expected output for acceptance test \"ember help works\". \r\nIt looks really scary.\r\n\r\nThank you in advance"},"comment":{"url":"https://api.github.com/repos/ember-cli/ember-cli/issues/comments/145947459","html_url":"https://github.com/ember-cli/ember-cli/pull/4931#issuecomment-145947459","issue_url":"https://api.github.com/repos/ember-cli/ember-cli/issues/4931","id":145947459,"user":{"login":"elwayman02","id":1325482,"avatar_url":"https://avatars.githubusercontent.com/u/1325482?v=3","gravatar_id":"","url":"https://api.github.com/users/elwayman02","html_url":"https://github.com/elwayman02","followers_url":"https://api.github.com/users/elwayman02/followers","following_url":"https://api.github.com/users/elwayman02/following{/other_user}","gists_url":"https://api.github.com/users/elwayman02/gists{/gist_id}","starred_url":"https://api.github.com/users/elwayman02/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elwayman02/subscriptions","organizations_url":"https://api.github.com/users/elwayman02/orgs","repos_url":"https://api.github.com/users/elwayman02/repos","events_url":"https://api.github.com/users/elwayman02/events{/privacy}","received_events_url":"https://api.github.com/users/elwayman02/received_events","type":"User","site_admin":false},"created_at":"2015-10-06T18:01:13Z","updated_at":"2015-10-06T18:01:13Z","body":"@beatle thanks for taking up this work, I've been swamped with other projects lately! I'll take a look at this shortly. In the meantime, would you mind squashing your commits down? We probably don't want to merge 25 commits into master for this one feature. Thanks!"}}