{"action":"closed","number":188,"pull_request":{"url":"https://api.github.com/repos/shopware/shopware/pulls/188","id":22133021,"html_url":"https://github.com/shopware/shopware/pull/188","diff_url":"https://github.com/shopware/shopware/pull/188.diff","patch_url":"https://github.com/shopware/shopware/pull/188.patch","issue_url":"https://api.github.com/repos/shopware/shopware/issues/188","number":188,"state":"closed","locked":false,"title":"Include the country in the address comparison","user":{"login":"svenmuennich","id":1932115,"avatar_url":"https://avatars.githubusercontent.com/u/1932115?v=3","gravatar_id":"","url":"https://api.github.com/users/svenmuennich","html_url":"https://github.com/svenmuennich","followers_url":"https://api.github.com/users/svenmuennich/followers","following_url":"https://api.github.com/users/svenmuennich/following{/other_user}","gists_url":"https://api.github.com/users/svenmuennich/gists{/gist_id}","starred_url":"https://api.github.com/users/svenmuennich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/svenmuennich/subscriptions","organizations_url":"https://api.github.com/users/svenmuennich/orgs","repos_url":"https://api.github.com/users/svenmuennich/repos","events_url":"https://api.github.com/users/svenmuennich/events{/privacy}","received_events_url":"https://api.github.com/users/svenmuennich/received_events","type":"User","site_admin":false},"body":"Currently, the address comparison in the backend order details does not include the countries of the billing and shipping addresses. However, since some customers change the country to get around certain country restrictions, it is important to compare the countries, too. This PR adds this check, by comparing the `countryId`s of the two addresses.\r\n\r\nBecause this fix is located in the ExtJS backend order app, I didn't include test cases.","created_at":"2014-10-02T11:01:29Z","updated_at":"2015-06-05T09:54:32Z","closed_at":"2015-06-05T09:54:32Z","merged_at":null,"merge_commit_sha":"a5bf2af627b1217d7eb7584de6811d84a66c7cfe","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/shopware/shopware/pulls/188/commits","review_comments_url":"https://api.github.com/repos/shopware/shopware/pulls/188/comments","review_comment_url":"https://api.github.com/repos/shopware/shopware/pulls/comments{/number}","comments_url":"https://api.github.com/repos/shopware/shopware/issues/188/comments","statuses_url":"https://api.github.com/repos/shopware/shopware/statuses/3c463559ee98de6fa55cb4663a3ec34a50785531","head":{"label":"VIISON:fix-address-comparison-in-order-details","ref":"fix-address-comparison-in-order-details","sha":"3c463559ee98de6fa55cb4663a3ec34a50785531","user":{"login":"VIISON","id":710194,"avatar_url":"https://avatars.githubusercontent.com/u/710194?v=3","gravatar_id":"","url":"https://api.github.com/users/VIISON","html_url":"https://github.com/VIISON","followers_url":"https://api.github.com/users/VIISON/followers","following_url":"https://api.github.com/users/VIISON/following{/other_user}","gists_url":"https://api.github.com/users/VIISON/gists{/gist_id}","starred_url":"https://api.github.com/users/VIISON/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VIISON/subscriptions","organizations_url":"https://api.github.com/users/VIISON/orgs","repos_url":"https://api.github.com/users/VIISON/repos","events_url":"https://api.github.com/users/VIISON/events{/privacy}","received_events_url":"https://api.github.com/users/VIISON/received_events","type":"Organization","site_admin":false},"repo":{"id":13239451,"name":"shopware-4","full_name":"VIISON/shopware-4","owner":{"login":"VIISON","id":710194,"avatar_url":"https://avatars.githubusercontent.com/u/710194?v=3","gravatar_id":"","url":"https://api.github.com/users/VIISON","html_url":"https://github.com/VIISON","followers_url":"https://api.github.com/users/VIISON/followers","following_url":"https://api.github.com/users/VIISON/following{/other_user}","gists_url":"https://api.github.com/users/VIISON/gists{/gist_id}","starred_url":"https://api.github.com/users/VIISON/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VIISON/subscriptions","organizations_url":"https://api.github.com/users/VIISON/orgs","repos_url":"https://api.github.com/users/VIISON/repos","events_url":"https://api.github.com/users/VIISON/events{/privacy}","received_events_url":"https://api.github.com/users/VIISON/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/VIISON/shopware-4","description":"Shopware 4 Repository","fork":true,"url":"https://api.github.com/repos/VIISON/shopware-4","forks_url":"https://api.github.com/repos/VIISON/shopware-4/forks","keys_url":"https://api.github.com/repos/VIISON/shopware-4/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VIISON/shopware-4/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VIISON/shopware-4/teams","hooks_url":"https://api.github.com/repos/VIISON/shopware-4/hooks","issue_events_url":"https://api.github.com/repos/VIISON/shopware-4/issues/events{/number}","events_url":"https://api.github.com/repos/VIISON/shopware-4/events","assignees_url":"https://api.github.com/repos/VIISON/shopware-4/assignees{/user}","branches_url":"https://api.github.com/repos/VIISON/shopware-4/branches{/branch}","tags_url":"https://api.github.com/repos/VIISON/shopware-4/tags","blobs_url":"https://api.github.com/repos/VIISON/shopware-4/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VIISON/shopware-4/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VIISON/shopware-4/git/refs{/sha}","trees_url":"https://api.github.com/repos/VIISON/shopware-4/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VIISON/shopware-4/statuses/{sha}","languages_url":"https://api.github.com/repos/VIISON/shopware-4/languages","stargazers_url":"https://api.github.com/repos/VIISON/shopware-4/stargazers","contributors_url":"https://api.github.com/repos/VIISON/shopware-4/contributors","subscribers_url":"https://api.github.com/repos/VIISON/shopware-4/subscribers","subscription_url":"https://api.github.com/repos/VIISON/shopware-4/subscription","commits_url":"https://api.github.com/repos/VIISON/shopware-4/commits{/sha}","git_commits_url":"https://api.github.com/repos/VIISON/shopware-4/git/commits{/sha}","comments_url":"https://api.github.com/repos/VIISON/shopware-4/comments{/number}","issue_comment_url":"https://api.github.com/repos/VIISON/shopware-4/issues/comments{/number}","contents_url":"https://api.github.com/repos/VIISON/shopware-4/contents/{+path}","compare_url":"https://api.github.com/repos/VIISON/shopware-4/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VIISON/shopware-4/merges","archive_url":"https://api.github.com/repos/VIISON/shopware-4/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VIISON/shopware-4/downloads","issues_url":"https://api.github.com/repos/VIISON/shopware-4/issues{/number}","pulls_url":"https://api.github.com/repos/VIISON/shopware-4/pulls{/number}","milestones_url":"https://api.github.com/repos/VIISON/shopware-4/milestones{/number}","notifications_url":"https://api.github.com/repos/VIISON/shopware-4/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VIISON/shopware-4/labels{/name}","releases_url":"https://api.github.com/repos/VIISON/shopware-4/releases{/id}","created_at":"2013-10-01T09:15:42Z","updated_at":"2015-04-13T15:25:32Z","pushed_at":"2015-06-02T09:52:41Z","git_url":"git://github.com/VIISON/shopware-4.git","ssh_url":"git@github.com:VIISON/shopware-4.git","clone_url":"https://github.com/VIISON/shopware-4.git","svn_url":"https://github.com/VIISON/shopware-4","homepage":"http://www.shopware.de","size":103747,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"base":{"label":"shopware:master","ref":"master","sha":"85d7409be7e3dbeccdf40893c171cc95bbd84fa0","user":{"login":"shopware","id":612628,"avatar_url":"https://avatars.githubusercontent.com/u/612628?v=3","gravatar_id":"","url":"https://api.github.com/users/shopware","html_url":"https://github.com/shopware","followers_url":"https://api.github.com/users/shopware/followers","following_url":"https://api.github.com/users/shopware/following{/other_user}","gists_url":"https://api.github.com/users/shopware/gists{/gist_id}","starred_url":"https://api.github.com/users/shopware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shopware/subscriptions","organizations_url":"https://api.github.com/users/shopware/orgs","repos_url":"https://api.github.com/users/shopware/repos","events_url":"https://api.github.com/users/shopware/events{/privacy}","received_events_url":"https://api.github.com/users/shopware/received_events","type":"Organization","site_admin":false},"repo":{"id":5682970,"name":"shopware","full_name":"shopware/shopware","owner":{"login":"shopware","id":612628,"avatar_url":"https://avatars.githubusercontent.com/u/612628?v=3","gravatar_id":"","url":"https://api.github.com/users/shopware","html_url":"https://github.com/shopware","followers_url":"https://api.github.com/users/shopware/followers","following_url":"https://api.github.com/users/shopware/following{/other_user}","gists_url":"https://api.github.com/users/shopware/gists{/gist_id}","starred_url":"https://api.github.com/users/shopware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shopware/subscriptions","organizations_url":"https://api.github.com/users/shopware/orgs","repos_url":"https://api.github.com/users/shopware/repos","events_url":"https://api.github.com/users/shopware/events{/privacy}","received_events_url":"https://api.github.com/users/shopware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/shopware/shopware","description":"Shopware Repository","fork":false,"url":"https://api.github.com/repos/shopware/shopware","forks_url":"https://api.github.com/repos/shopware/shopware/forks","keys_url":"https://api.github.com/repos/shopware/shopware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shopware/shopware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shopware/shopware/teams","hooks_url":"https://api.github.com/repos/shopware/shopware/hooks","issue_events_url":"https://api.github.com/repos/shopware/shopware/issues/events{/number}","events_url":"https://api.github.com/repos/shopware/shopware/events","assignees_url":"https://api.github.com/repos/shopware/shopware/assignees{/user}","branches_url":"https://api.github.com/repos/shopware/shopware/branches{/branch}","tags_url":"https://api.github.com/repos/shopware/shopware/tags","blobs_url":"https://api.github.com/repos/shopware/shopware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shopware/shopware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shopware/shopware/git/refs{/sha}","trees_url":"https://api.github.com/repos/shopware/shopware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shopware/shopware/statuses/{sha}","languages_url":"https://api.github.com/repos/shopware/shopware/languages","stargazers_url":"https://api.github.com/repos/shopware/shopware/stargazers","contributors_url":"https://api.github.com/repos/shopware/shopware/contributors","subscribers_url":"https://api.github.com/repos/shopware/shopware/subscribers","subscription_url":"https://api.github.com/repos/shopware/shopware/subscription","commits_url":"https://api.github.com/repos/shopware/shopware/commits{/sha}","git_commits_url":"https://api.github.com/repos/shopware/shopware/git/commits{/sha}","comments_url":"https://api.github.com/repos/shopware/shopware/comments{/number}","issue_comment_url":"https://api.github.com/repos/shopware/shopware/issues/comments{/number}","contents_url":"https://api.github.com/repos/shopware/shopware/contents/{+path}","compare_url":"https://api.github.com/repos/shopware/shopware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shopware/shopware/merges","archive_url":"https://api.github.com/repos/shopware/shopware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shopware/shopware/downloads","issues_url":"https://api.github.com/repos/shopware/shopware/issues{/number}","pulls_url":"https://api.github.com/repos/shopware/shopware/pulls{/number}","milestones_url":"https://api.github.com/repos/shopware/shopware/milestones{/number}","notifications_url":"https://api.github.com/repos/shopware/shopware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shopware/shopware/labels{/name}","releases_url":"https://api.github.com/repos/shopware/shopware/releases{/id}","created_at":"2012-09-05T05:32:50Z","updated_at":"2015-06-04T11:25:49Z","pushed_at":"2015-06-02T12:11:29Z","git_url":"git://github.com/shopware/shopware.git","ssh_url":"git@github.com:shopware/shopware.git","clone_url":"https://github.com/shopware/shopware.git","svn_url":"https://github.com/shopware/shopware","homepage":"http://www.shopware.com","size":134167,"stargazers_count":248,"watchers_count":248,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":176,"mirror_url":null,"open_issues_count":40,"forks":176,"open_issues":40,"watchers":248,"default_branch":"next"}},"_links":{"self":{"href":"https://api.github.com/repos/shopware/shopware/pulls/188"},"html":{"href":"https://github.com/shopware/shopware/pull/188"},"issue":{"href":"https://api.github.com/repos/shopware/shopware/issues/188"},"comments":{"href":"https://api.github.com/repos/shopware/shopware/issues/188/comments"},"review_comments":{"href":"https://api.github.com/repos/shopware/shopware/pulls/188/comments"},"review_comment":{"href":"https://api.github.com/repos/shopware/shopware/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/shopware/shopware/pulls/188/commits"},"statuses":{"href":"https://api.github.com/repos/shopware/shopware/statuses/3c463559ee98de6fa55cb4663a3ec34a50785531"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":2,"review_comments":0,"commits":1,"additions":68,"deletions":54,"changed_files":2}}