{"action":"created","comment":{"url":"https://api.github.com/repos/marcojanssen/silex-routing-service-provider/pulls/comments/27696971","id":27696971,"diff_hunk":"@@ -30,12 +30,12 @@ public function testApplicationRoutes()\n         $app = new Application();","path":"tests/MJanssen/Provider/RoutingServiceProviderTest.php","position":1,"original_position":1,"commit_id":"9f7a5f8343151c4dd991e2d2d5f0610269b9db06","original_commit_id":"9f7a5f8343151c4dd991e2d2d5f0610269b9db06","user":{"login":"marcojanssen","id":2293642,"avatar_url":"https://avatars.githubusercontent.com/u/2293642?v=3","gravatar_id":"","url":"https://api.github.com/users/marcojanssen","html_url":"https://github.com/marcojanssen","followers_url":"https://api.github.com/users/marcojanssen/followers","following_url":"https://api.github.com/users/marcojanssen/following{/other_user}","gists_url":"https://api.github.com/users/marcojanssen/gists{/gist_id}","starred_url":"https://api.github.com/users/marcojanssen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcojanssen/subscriptions","organizations_url":"https://api.github.com/users/marcojanssen/orgs","repos_url":"https://api.github.com/users/marcojanssen/repos","events_url":"https://api.github.com/users/marcojanssen/events{/privacy}","received_events_url":"https://api.github.com/users/marcojanssen/received_events","type":"User","site_admin":false},"body":"I think your missing a test case asserting that the routename is actually what you specified","created_at":"2015-04-02T21:03:51Z","updated_at":"2015-04-02T21:03:51Z","html_url":"https://github.com/marcojanssen/silex-routing-service-provider/pull/5#discussion_r27696971","pull_request_url":"https://api.github.com/repos/marcojanssen/silex-routing-service-provider/pulls/5","_links":{"self":{"href":"https://api.github.com/repos/marcojanssen/silex-routing-service-provider/pulls/comments/27696971"},"html":{"href":"https://github.com/marcojanssen/silex-routing-service-provider/pull/5#discussion_r27696971"},"pull_request":{"href":"https://api.github.com/repos/marcojanssen/silex-routing-service-provider/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/marcojanssen/silex-routing-service-provider/pulls/5","id":32523872,"html_url":"https://github.com/marcojanssen/silex-routing-service-provider/pull/5","diff_url":"https://github.com/marcojanssen/silex-routing-service-provider/pull/5.diff","patch_url":"https://github.com/marcojanssen/silex-routing-service-provider/pull/5.patch","issue_url":"https://api.github.com/repos/marcojanssen/silex-routing-service-provider/issues/5","number":5,"state":"open","locked":false,"title":"Added named routes","user":{"login":"samir-plusb","id":4447755,"avatar_url":"https://avatars.githubusercontent.com/u/4447755?v=3","gravatar_id":"","url":"https://api.github.com/users/samir-plusb","html_url":"https://github.com/samir-plusb","followers_url":"https://api.github.com/users/samir-plusb/followers","following_url":"https://api.github.com/users/samir-plusb/following{/other_user}","gists_url":"https://api.github.com/users/samir-plusb/gists{/gist_id}","starred_url":"https://api.github.com/users/samir-plusb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samir-plusb/subscriptions","organizations_url":"https://api.github.com/users/samir-plusb/orgs","repos_url":"https://api.github.com/users/samir-plusb/repos","events_url":"https://api.github.com/users/samir-plusb/events{/privacy}","received_events_url":"https://api.github.com/users/samir-plusb/received_events","type":"User","site_admin":false},"body":"Hi,\r\n\r\nI added named routes to the RoutingServiceProvider. It may be related to the following issue: #4 \r\n\r\nCommit message:\r\n\r\nRefactored the RoutingServiceProvider\r\n\r\n- Implemented named Routes\r\n- Added sanitization for named routes\r\n- refactored the code\r\n- changed the documentation and the composer.json","created_at":"2015-04-02T15:47:32Z","updated_at":"2015-04-02T21:03:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ba390d89cd9beee110fe92ca3645ff5bb4a514e6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/marcojanssen/silex-routing-service-provider/pulls/5/commits","review_comments_url":"https://api.github.com/repos/marcojanssen/silex-routing-service-provider/pulls/5/comments","review_comment_url":"https://api.github.com/repos/marcojanssen/silex-routing-service-provider/pulls/comments{/number}","comments_url":"https://api.github.com/repos/marcojanssen/silex-routing-service-provider/issues/5/comments","statuses_url":"https://api.github.com/repos/marcojanssen/silex-routing-service-provider/statuses/9f7a5f8343151c4dd991e2d2d5f0610269b9db06","head":{"label":"samir-plusb:master","ref":"master","sha":"9f7a5f8343151c4dd991e2d2d5f0610269b9db06","user":{"login":"samir-plusb","id":4447755,"avatar_url":"https://avatars.githubusercontent.com/u/4447755?v=3","gravatar_id":"","url":"https://api.github.com/users/samir-plusb","html_url":"https://github.com/samir-plusb","followers_url":"https://api.github.com/users/samir-plusb/followers","following_url":"https://api.github.com/users/samir-plusb/following{/other_user}","gists_url":"https://api.github.com/users/samir-plusb/gists{/gist_id}","starred_url":"https://api.github.com/users/samir-plusb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samir-plusb/subscriptions","organizations_url":"https://api.github.com/users/samir-plusb/orgs","repos_url":"https://api.github.com/users/samir-plusb/repos","events_url":"https://api.github.com/users/samir-plusb/events{/privacy}","received_events_url":"https://api.github.com/users/samir-plusb/received_events","type":"User","site_admin":false},"repo":{"id":33302996,"name":"silex-routing-service-provider","full_name":"samir-plusb/silex-routing-service-provider","owner":{"login":"samir-plusb","id":4447755,"avatar_url":"https://avatars.githubusercontent.com/u/4447755?v=3","gravatar_id":"","url":"https://api.github.com/users/samir-plusb","html_url":"https://github.com/samir-plusb","followers_url":"https://api.github.com/users/samir-plusb/followers","following_url":"https://api.github.com/users/samir-plusb/following{/other_user}","gists_url":"https://api.github.com/users/samir-plusb/gists{/gist_id}","starred_url":"https://api.github.com/users/samir-plusb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samir-plusb/subscriptions","organizations_url":"https://api.github.com/users/samir-plusb/orgs","repos_url":"https://api.github.com/users/samir-plusb/repos","events_url":"https://api.github.com/users/samir-plusb/events{/privacy}","received_events_url":"https://api.github.com/users/samir-plusb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/samir-plusb/silex-routing-service-provider","description":"Provider for adding routes","fork":true,"url":"https://api.github.com/repos/samir-plusb/silex-routing-service-provider","forks_url":"https://api.github.com/repos/samir-plusb/silex-routing-service-provider/forks","keys_url":"https://api.github.com/repos/samir-plusb/silex-routing-service-provider/keys{/key_id}","collaborators_url":"https://api.github.com/repos/samir-plusb/silex-routing-service-provider/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/samir-plusb/silex-routing-service-provider/teams","hooks_url":"https://api.github.com/repos/samir-plusb/silex-routing-service-provider/hooks","issue_events_url":"https://api.github.com/repos/samir-plusb/silex-routing-service-provider/issues/events{/number}","events_url":"https://api.github.com/repos/samir-plusb/silex-routing-service-provider/events","assignees_url":"https://api.github.com/repos/samir-plusb/silex-routing-service-provider/assignees{/user}","branches_url":"https://api.github.com/repos/samir-plusb/silex-routing-service-provider/branches{/branch}","tags_url":"https://api.github.com/repos/samir-plusb/silex-routing-service-provider/tags","blobs_url":"https://api.github.com/repos/samir-plusb/silex-routing-service-provider/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/samir-plusb/silex-routing-service-provider/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/samir-plusb/silex-routing-service-provider/git/refs{/sha}","trees_url":"https://api.github.com/repos/samir-plusb/silex-routing-service-provider/git/trees{/sha}","statuses_url":"https://api.github.com/repos/samir-plusb/silex-routing-service-provider/statuses/{sha}","languages_url":"https://api.github.com/repos/samir-plusb/silex-routing-service-provider/languages","stargazers_url":"https://api.github.com/repos/samir-plusb/silex-routing-service-provider/stargazers","contributors_url":"https://api.github.com/repos/samir-plusb/silex-routing-service-provider/contributors","subscribers_url":"https://api.github.com/repos/samir-plusb/silex-routing-service-provider/subscribers","subscription_url":"https://api.github.com/repos/samir-plusb/silex-routing-service-provider/subscription","commits_url":"https://api.github.com/repos/samir-plusb/silex-routing-service-provider/commits{/sha}","git_commits_url":"https://api.github.com/repos/samir-plusb/silex-routing-service-provider/git/commits{/sha}","comments_url":"https://api.github.com/repos/samir-plusb/silex-routing-service-provider/comments{/number}","issue_comment_url":"https://api.github.com/repos/samir-plusb/silex-routing-service-provider/issues/comments{/number}","contents_url":"https://api.github.com/repos/samir-plusb/silex-routing-service-provider/contents/{+path}","compare_url":"https://api.github.com/repos/samir-plusb/silex-routing-service-provider/compare/{base}...{head}","merges_url":"https://api.github.com/repos/samir-plusb/silex-routing-service-provider/merges","archive_url":"https://api.github.com/repos/samir-plusb/silex-routing-service-provider/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/samir-plusb/silex-routing-service-provider/downloads","issues_url":"https://api.github.com/repos/samir-plusb/silex-routing-service-provider/issues{/number}","pulls_url":"https://api.github.com/repos/samir-plusb/silex-routing-service-provider/pulls{/number}","milestones_url":"https://api.github.com/repos/samir-plusb/silex-routing-service-provider/milestones{/number}","notifications_url":"https://api.github.com/repos/samir-plusb/silex-routing-service-provider/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/samir-plusb/silex-routing-service-provider/labels{/name}","releases_url":"https://api.github.com/repos/samir-plusb/silex-routing-service-provider/releases{/id}","created_at":"2015-04-02T10:25:55Z","updated_at":"2015-04-02T15:23:34Z","pushed_at":"2015-04-02T15:29:01Z","git_url":"git://github.com/samir-plusb/silex-routing-service-provider.git","ssh_url":"git@github.com:samir-plusb/silex-routing-service-provider.git","clone_url":"https://github.com/samir-plusb/silex-routing-service-provider.git","svn_url":"https://github.com/samir-plusb/silex-routing-service-provider","homepage":"","size":129,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"marcojanssen:master","ref":"master","sha":"c84bcadf6c4eeda7cd915b4ce9189a3fad45cbf4","user":{"login":"marcojanssen","id":2293642,"avatar_url":"https://avatars.githubusercontent.com/u/2293642?v=3","gravatar_id":"","url":"https://api.github.com/users/marcojanssen","html_url":"https://github.com/marcojanssen","followers_url":"https://api.github.com/users/marcojanssen/followers","following_url":"https://api.github.com/users/marcojanssen/following{/other_user}","gists_url":"https://api.github.com/users/marcojanssen/gists{/gist_id}","starred_url":"https://api.github.com/users/marcojanssen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcojanssen/subscriptions","organizations_url":"https://api.github.com/users/marcojanssen/orgs","repos_url":"https://api.github.com/users/marcojanssen/repos","events_url":"https://api.github.com/users/marcojanssen/events{/privacy}","received_events_url":"https://api.github.com/users/marcojanssen/received_events","type":"User","site_admin":false},"repo":{"id":13101314,"name":"silex-routing-service-provider","full_name":"marcojanssen/silex-routing-service-provider","owner":{"login":"marcojanssen","id":2293642,"avatar_url":"https://avatars.githubusercontent.com/u/2293642?v=3","gravatar_id":"","url":"https://api.github.com/users/marcojanssen","html_url":"https://github.com/marcojanssen","followers_url":"https://api.github.com/users/marcojanssen/followers","following_url":"https://api.github.com/users/marcojanssen/following{/other_user}","gists_url":"https://api.github.com/users/marcojanssen/gists{/gist_id}","starred_url":"https://api.github.com/users/marcojanssen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcojanssen/subscriptions","organizations_url":"https://api.github.com/users/marcojanssen/orgs","repos_url":"https://api.github.com/users/marcojanssen/repos","events_url":"https://api.github.com/users/marcojanssen/events{/privacy}","received_events_url":"https://api.github.com/users/marcojanssen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/marcojanssen/silex-routing-service-provider","description":"Provider for adding routes","fork":false,"url":"https://api.github.com/repos/marcojanssen/silex-routing-service-provider","forks_url":"https://api.github.com/repos/marcojanssen/silex-routing-service-provider/forks","keys_url":"https://api.github.com/repos/marcojanssen/silex-routing-service-provider/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marcojanssen/silex-routing-service-provider/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marcojanssen/silex-routing-service-provider/teams","hooks_url":"https://api.github.com/repos/marcojanssen/silex-routing-service-provider/hooks","issue_events_url":"https://api.github.com/repos/marcojanssen/silex-routing-service-provider/issues/events{/number}","events_url":"https://api.github.com/repos/marcojanssen/silex-routing-service-provider/events","assignees_url":"https://api.github.com/repos/marcojanssen/silex-routing-service-provider/assignees{/user}","branches_url":"https://api.github.com/repos/marcojanssen/silex-routing-service-provider/branches{/branch}","tags_url":"https://api.github.com/repos/marcojanssen/silex-routing-service-provider/tags","blobs_url":"https://api.github.com/repos/marcojanssen/silex-routing-service-provider/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marcojanssen/silex-routing-service-provider/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marcojanssen/silex-routing-service-provider/git/refs{/sha}","trees_url":"https://api.github.com/repos/marcojanssen/silex-routing-service-provider/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marcojanssen/silex-routing-service-provider/statuses/{sha}","languages_url":"https://api.github.com/repos/marcojanssen/silex-routing-service-provider/languages","stargazers_url":"https://api.github.com/repos/marcojanssen/silex-routing-service-provider/stargazers","contributors_url":"https://api.github.com/repos/marcojanssen/silex-routing-service-provider/contributors","subscribers_url":"https://api.github.com/repos/marcojanssen/silex-routing-service-provider/subscribers","subscription_url":"https://api.github.com/repos/marcojanssen/silex-routing-service-provider/subscription","commits_url":"https://api.github.com/repos/marcojanssen/silex-routing-service-provider/commits{/sha}","git_commits_url":"https://api.github.com/repos/marcojanssen/silex-routing-service-provider/git/commits{/sha}","comments_url":"https://api.github.com/repos/marcojanssen/silex-routing-service-provider/comments{/number}","issue_comment_url":"https://api.github.com/repos/marcojanssen/silex-routing-service-provider/issues/comments{/number}","contents_url":"https://api.github.com/repos/marcojanssen/silex-routing-service-provider/contents/{+path}","compare_url":"https://api.github.com/repos/marcojanssen/silex-routing-service-provider/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marcojanssen/silex-routing-service-provider/merges","archive_url":"https://api.github.com/repos/marcojanssen/silex-routing-service-provider/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marcojanssen/silex-routing-service-provider/downloads","issues_url":"https://api.github.com/repos/marcojanssen/silex-routing-service-provider/issues{/number}","pulls_url":"https://api.github.com/repos/marcojanssen/silex-routing-service-provider/pulls{/number}","milestones_url":"https://api.github.com/repos/marcojanssen/silex-routing-service-provider/milestones{/number}","notifications_url":"https://api.github.com/repos/marcojanssen/silex-routing-service-provider/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marcojanssen/silex-routing-service-provider/labels{/name}","releases_url":"https://api.github.com/repos/marcojanssen/silex-routing-service-provider/releases{/id}","created_at":"2013-09-25T18:05:31Z","updated_at":"2015-03-26T18:36:16Z","pushed_at":"2015-04-02T15:47:32Z","git_url":"git://github.com/marcojanssen/silex-routing-service-provider.git","ssh_url":"git@github.com:marcojanssen/silex-routing-service-provider.git","clone_url":"https://github.com/marcojanssen/silex-routing-service-provider.git","svn_url":"https://github.com/marcojanssen/silex-routing-service-provider","homepage":"","size":281,"stargazers_count":4,"watchers_count":4,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":2,"forks":5,"open_issues":2,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/marcojanssen/silex-routing-service-provider/pulls/5"},"html":{"href":"https://github.com/marcojanssen/silex-routing-service-provider/pull/5"},"issue":{"href":"https://api.github.com/repos/marcojanssen/silex-routing-service-provider/issues/5"},"comments":{"href":"https://api.github.com/repos/marcojanssen/silex-routing-service-provider/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/marcojanssen/silex-routing-service-provider/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/marcojanssen/silex-routing-service-provider/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/marcojanssen/silex-routing-service-provider/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/marcojanssen/silex-routing-service-provider/statuses/9f7a5f8343151c4dd991e2d2d5f0610269b9db06"}}}}