{"action":"closed","number":550,"pull_request":{"url":"https://api.github.com/repos/genome/genome/pulls/550","id":30804890,"html_url":"https://github.com/genome/genome/pull/550","diff_url":"https://github.com/genome/genome/pull/550.diff","patch_url":"https://github.com/genome/genome/pull/550.patch","issue_url":"https://api.github.com/repos/genome/genome/issues/550","number":550,"state":"closed","locked":false,"title":"Add option to vep expert to use use short_name instead of name column in feature list","user":{"login":"susannasiebert","id":6617192,"avatar_url":"https://avatars.githubusercontent.com/u/6617192?v=3","gravatar_id":"","url":"https://api.github.com/users/susannasiebert","html_url":"https://github.com/susannasiebert","followers_url":"https://api.github.com/users/susannasiebert/followers","following_url":"https://api.github.com/users/susannasiebert/following{/other_user}","gists_url":"https://api.github.com/users/susannasiebert/gists{/gist_id}","starred_url":"https://api.github.com/users/susannasiebert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/susannasiebert/subscriptions","organizations_url":"https://api.github.com/users/susannasiebert/orgs","repos_url":"https://api.github.com/users/susannasiebert/repos","events_url":"https://api.github.com/users/susannasiebert/events{/privacy}","received_events_url":"https://api.github.com/users/susannasiebert/received_events","type":"User","site_admin":false},"body":"Sometimes our feature lists contain special characters in the name column which makes joinx choke when it tries to run vcf-merge on a vep annotated vcf in the vep expert. This has previously been addressed here https://github.com/genome/genome/pull/471 by making the vep expert fail early with a helpful error message. In order to get the vep expert to run it would've been necessary to sanitize and reimport the feature list.\r\n\r\nIn RT https://rt.gsc.wustl.edu/Ticket/Display.html?id=104483 it has been requested that we find an option that doesn't require manual user intervention. This PR makes it so that the user can specify the short_name option in the vep expert which will result in the name column being replaced with region numbers. This works for all of our current reports because the reports don't actually use the content of the name columns that are getting annotated. For possible future reports that will use the annotations it would still be necessary to manually sanitize and reimport the feature list.","created_at":"2015-03-09T22:06:19Z","updated_at":"2015-03-11T17:28:29Z","closed_at":"2015-03-11T17:28:29Z","merged_at":"2015-03-11T17:28:29Z","merge_commit_sha":"617036406341a77908212ef7d4b6891da9e25d23","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/genome/genome/pulls/550/commits","review_comments_url":"https://api.github.com/repos/genome/genome/pulls/550/comments","review_comment_url":"https://api.github.com/repos/genome/genome/pulls/comments{/number}","comments_url":"https://api.github.com/repos/genome/genome/issues/550/comments","statuses_url":"https://api.github.com/repos/genome/genome/statuses/51e79169c95f321e7b0dd61b6c8385dd29eb7423","head":{"label":"susannasiebert:variant_reporting_vep","ref":"variant_reporting_vep","sha":"51e79169c95f321e7b0dd61b6c8385dd29eb7423","user":{"login":"susannasiebert","id":6617192,"avatar_url":"https://avatars.githubusercontent.com/u/6617192?v=3","gravatar_id":"","url":"https://api.github.com/users/susannasiebert","html_url":"https://github.com/susannasiebert","followers_url":"https://api.github.com/users/susannasiebert/followers","following_url":"https://api.github.com/users/susannasiebert/following{/other_user}","gists_url":"https://api.github.com/users/susannasiebert/gists{/gist_id}","starred_url":"https://api.github.com/users/susannasiebert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/susannasiebert/subscriptions","organizations_url":"https://api.github.com/users/susannasiebert/orgs","repos_url":"https://api.github.com/users/susannasiebert/repos","events_url":"https://api.github.com/users/susannasiebert/events{/privacy}","received_events_url":"https://api.github.com/users/susannasiebert/received_events","type":"User","site_admin":false},"repo":{"id":23836901,"name":"genome","full_name":"susannasiebert/genome","owner":{"login":"susannasiebert","id":6617192,"avatar_url":"https://avatars.githubusercontent.com/u/6617192?v=3","gravatar_id":"","url":"https://api.github.com/users/susannasiebert","html_url":"https://github.com/susannasiebert","followers_url":"https://api.github.com/users/susannasiebert/followers","following_url":"https://api.github.com/users/susannasiebert/following{/other_user}","gists_url":"https://api.github.com/users/susannasiebert/gists{/gist_id}","starred_url":"https://api.github.com/users/susannasiebert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/susannasiebert/subscriptions","organizations_url":"https://api.github.com/users/susannasiebert/orgs","repos_url":"https://api.github.com/users/susannasiebert/repos","events_url":"https://api.github.com/users/susannasiebert/events{/privacy}","received_events_url":"https://api.github.com/users/susannasiebert/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/susannasiebert/genome","description":"","fork":true,"url":"https://api.github.com/repos/susannasiebert/genome","forks_url":"https://api.github.com/repos/susannasiebert/genome/forks","keys_url":"https://api.github.com/repos/susannasiebert/genome/keys{/key_id}","collaborators_url":"https://api.github.com/repos/susannasiebert/genome/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/susannasiebert/genome/teams","hooks_url":"https://api.github.com/repos/susannasiebert/genome/hooks","issue_events_url":"https://api.github.com/repos/susannasiebert/genome/issues/events{/number}","events_url":"https://api.github.com/repos/susannasiebert/genome/events","assignees_url":"https://api.github.com/repos/susannasiebert/genome/assignees{/user}","branches_url":"https://api.github.com/repos/susannasiebert/genome/branches{/branch}","tags_url":"https://api.github.com/repos/susannasiebert/genome/tags","blobs_url":"https://api.github.com/repos/susannasiebert/genome/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/susannasiebert/genome/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/susannasiebert/genome/git/refs{/sha}","trees_url":"https://api.github.com/repos/susannasiebert/genome/git/trees{/sha}","statuses_url":"https://api.github.com/repos/susannasiebert/genome/statuses/{sha}","languages_url":"https://api.github.com/repos/susannasiebert/genome/languages","stargazers_url":"https://api.github.com/repos/susannasiebert/genome/stargazers","contributors_url":"https://api.github.com/repos/susannasiebert/genome/contributors","subscribers_url":"https://api.github.com/repos/susannasiebert/genome/subscribers","subscription_url":"https://api.github.com/repos/susannasiebert/genome/subscription","commits_url":"https://api.github.com/repos/susannasiebert/genome/commits{/sha}","git_commits_url":"https://api.github.com/repos/susannasiebert/genome/git/commits{/sha}","comments_url":"https://api.github.com/repos/susannasiebert/genome/comments{/number}","issue_comment_url":"https://api.github.com/repos/susannasiebert/genome/issues/comments{/number}","contents_url":"https://api.github.com/repos/susannasiebert/genome/contents/{+path}","compare_url":"https://api.github.com/repos/susannasiebert/genome/compare/{base}...{head}","merges_url":"https://api.github.com/repos/susannasiebert/genome/merges","archive_url":"https://api.github.com/repos/susannasiebert/genome/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/susannasiebert/genome/downloads","issues_url":"https://api.github.com/repos/susannasiebert/genome/issues{/number}","pulls_url":"https://api.github.com/repos/susannasiebert/genome/pulls{/number}","milestones_url":"https://api.github.com/repos/susannasiebert/genome/milestones{/number}","notifications_url":"https://api.github.com/repos/susannasiebert/genome/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/susannasiebert/genome/labels{/name}","releases_url":"https://api.github.com/repos/susannasiebert/genome/releases{/id}","created_at":"2014-09-09T14:30:47Z","updated_at":"2014-09-10T06:51:41Z","pushed_at":"2015-03-10T15:40:06Z","git_url":"git://github.com/susannasiebert/genome.git","ssh_url":"git@github.com:susannasiebert/genome.git","clone_url":"https://github.com/susannasiebert/genome.git","svn_url":"https://github.com/susannasiebert/genome","homepage":"","size":113025,"stargazers_count":0,"watchers_count":0,"language":"Perl","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"genome:master","ref":"master","sha":"7e4b64d5d8c8d11f543d458109cb28544bced902","user":{"login":"genome","id":318108,"avatar_url":"https://avatars.githubusercontent.com/u/318108?v=3","gravatar_id":"","url":"https://api.github.com/users/genome","html_url":"https://github.com/genome","followers_url":"https://api.github.com/users/genome/followers","following_url":"https://api.github.com/users/genome/following{/other_user}","gists_url":"https://api.github.com/users/genome/gists{/gist_id}","starred_url":"https://api.github.com/users/genome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/genome/subscriptions","organizations_url":"https://api.github.com/users/genome/orgs","repos_url":"https://api.github.com/users/genome/repos","events_url":"https://api.github.com/users/genome/events{/privacy}","received_events_url":"https://api.github.com/users/genome/received_events","type":"Organization","site_admin":false},"repo":{"id":23442737,"name":"genome","full_name":"genome/genome","owner":{"login":"genome","id":318108,"avatar_url":"https://avatars.githubusercontent.com/u/318108?v=3","gravatar_id":"","url":"https://api.github.com/users/genome","html_url":"https://github.com/genome","followers_url":"https://api.github.com/users/genome/followers","following_url":"https://api.github.com/users/genome/following{/other_user}","gists_url":"https://api.github.com/users/genome/gists{/gist_id}","starred_url":"https://api.github.com/users/genome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/genome/subscriptions","organizations_url":"https://api.github.com/users/genome/orgs","repos_url":"https://api.github.com/users/genome/repos","events_url":"https://api.github.com/users/genome/events{/privacy}","received_events_url":"https://api.github.com/users/genome/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/genome/genome","description":"Core modules used by the GMS","fork":false,"url":"https://api.github.com/repos/genome/genome","forks_url":"https://api.github.com/repos/genome/genome/forks","keys_url":"https://api.github.com/repos/genome/genome/keys{/key_id}","collaborators_url":"https://api.github.com/repos/genome/genome/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/genome/genome/teams","hooks_url":"https://api.github.com/repos/genome/genome/hooks","issue_events_url":"https://api.github.com/repos/genome/genome/issues/events{/number}","events_url":"https://api.github.com/repos/genome/genome/events","assignees_url":"https://api.github.com/repos/genome/genome/assignees{/user}","branches_url":"https://api.github.com/repos/genome/genome/branches{/branch}","tags_url":"https://api.github.com/repos/genome/genome/tags","blobs_url":"https://api.github.com/repos/genome/genome/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/genome/genome/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/genome/genome/git/refs{/sha}","trees_url":"https://api.github.com/repos/genome/genome/git/trees{/sha}","statuses_url":"https://api.github.com/repos/genome/genome/statuses/{sha}","languages_url":"https://api.github.com/repos/genome/genome/languages","stargazers_url":"https://api.github.com/repos/genome/genome/stargazers","contributors_url":"https://api.github.com/repos/genome/genome/contributors","subscribers_url":"https://api.github.com/repos/genome/genome/subscribers","subscription_url":"https://api.github.com/repos/genome/genome/subscription","commits_url":"https://api.github.com/repos/genome/genome/commits{/sha}","git_commits_url":"https://api.github.com/repos/genome/genome/git/commits{/sha}","comments_url":"https://api.github.com/repos/genome/genome/comments{/number}","issue_comment_url":"https://api.github.com/repos/genome/genome/issues/comments{/number}","contents_url":"https://api.github.com/repos/genome/genome/contents/{+path}","compare_url":"https://api.github.com/repos/genome/genome/compare/{base}...{head}","merges_url":"https://api.github.com/repos/genome/genome/merges","archive_url":"https://api.github.com/repos/genome/genome/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/genome/genome/downloads","issues_url":"https://api.github.com/repos/genome/genome/issues{/number}","pulls_url":"https://api.github.com/repos/genome/genome/pulls{/number}","milestones_url":"https://api.github.com/repos/genome/genome/milestones{/number}","notifications_url":"https://api.github.com/repos/genome/genome/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/genome/genome/labels{/name}","releases_url":"https://api.github.com/repos/genome/genome/releases{/id}","created_at":"2014-08-28T20:59:19Z","updated_at":"2015-03-11T17:15:29Z","pushed_at":"2015-03-11T17:28:29Z","git_url":"git://github.com/genome/genome.git","ssh_url":"git@github.com:genome/genome.git","clone_url":"https://github.com/genome/genome.git","svn_url":"https://github.com/genome/genome","homepage":"","size":125202,"stargazers_count":6,"watchers_count":6,"language":"Perl","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":35,"mirror_url":null,"open_issues_count":12,"forks":35,"open_issues":12,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/genome/genome/pulls/550"},"html":{"href":"https://github.com/genome/genome/pull/550"},"issue":{"href":"https://api.github.com/repos/genome/genome/issues/550"},"comments":{"href":"https://api.github.com/repos/genome/genome/issues/550/comments"},"review_comments":{"href":"https://api.github.com/repos/genome/genome/pulls/550/comments"},"review_comment":{"href":"https://api.github.com/repos/genome/genome/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/genome/genome/pulls/550/commits"},"statuses":{"href":"https://api.github.com/repos/genome/genome/statuses/51e79169c95f321e7b0dd61b6c8385dd29eb7423"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"susannasiebert","id":6617192,"avatar_url":"https://avatars.githubusercontent.com/u/6617192?v=3","gravatar_id":"","url":"https://api.github.com/users/susannasiebert","html_url":"https://github.com/susannasiebert","followers_url":"https://api.github.com/users/susannasiebert/followers","following_url":"https://api.github.com/users/susannasiebert/following{/other_user}","gists_url":"https://api.github.com/users/susannasiebert/gists{/gist_id}","starred_url":"https://api.github.com/users/susannasiebert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/susannasiebert/subscriptions","organizations_url":"https://api.github.com/users/susannasiebert/orgs","repos_url":"https://api.github.com/users/susannasiebert/repos","events_url":"https://api.github.com/users/susannasiebert/events{/privacy}","received_events_url":"https://api.github.com/users/susannasiebert/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"commits":6,"additions":47,"deletions":5,"changed_files":22}}