{"action":"created","comment":{"url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/comments/27669850","id":27669850,"diff_hunk":"@@ -376,7 +377,7 @@ class EnumValue: public Declaration\n \n \tvirtual void accept(ASTVisitor& _visitor) override;\n \tvirtual void accept(ASTConstVisitor& _visitor) const override;\n-\tTypePointer getType(ContractDefinition const* = nullptr) const;\n+\tTypePointer getType(ContractDefinition const* = nullptr) const override;","path":"libsolidity/AST.h","position":13,"original_position":13,"commit_id":"35567e4e7ac5c53e991bd0e0736bc1ed054cec03","original_commit_id":"adef274f7dee79716ba72e1fa73c410d93308aa9","user":{"login":"LefterisJP","id":1658405,"avatar_url":"https://avatars.githubusercontent.com/u/1658405?v=3","gravatar_id":"","url":"https://api.github.com/users/LefterisJP","html_url":"https://github.com/LefterisJP","followers_url":"https://api.github.com/users/LefterisJP/followers","following_url":"https://api.github.com/users/LefterisJP/following{/other_user}","gists_url":"https://api.github.com/users/LefterisJP/gists{/gist_id}","starred_url":"https://api.github.com/users/LefterisJP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LefterisJP/subscriptions","organizations_url":"https://api.github.com/users/LefterisJP/orgs","repos_url":"https://api.github.com/users/LefterisJP/repos","events_url":"https://api.github.com/users/LefterisJP/events{/privacy}","received_events_url":"https://api.github.com/users/LefterisJP/received_events","type":"User","site_admin":false},"body":"thanks! Will do","created_at":"2015-04-02T15:49:13Z","updated_at":"2015-04-02T15:49:13Z","html_url":"https://github.com/ethereum/cpp-ethereum/pull/1501#discussion_r27669850","pull_request_url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/1501","_links":{"self":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/comments/27669850"},"html":{"href":"https://github.com/ethereum/cpp-ethereum/pull/1501#discussion_r27669850"},"pull_request":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/1501"}}},"pull_request":{"url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/1501","id":32519200,"html_url":"https://github.com/ethereum/cpp-ethereum/pull/1501","diff_url":"https://github.com/ethereum/cpp-ethereum/pull/1501.diff","patch_url":"https://github.com/ethereum/cpp-ethereum/pull/1501.patch","issue_url":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/1501","number":1501,"state":"open","locked":false,"title":"Abstract contract contructors","user":{"login":"LefterisJP","id":1658405,"avatar_url":"https://avatars.githubusercontent.com/u/1658405?v=3","gravatar_id":"","url":"https://api.github.com/users/LefterisJP","html_url":"https://github.com/LefterisJP","followers_url":"https://api.github.com/users/LefterisJP/followers","following_url":"https://api.github.com/users/LefterisJP/following{/other_user}","gists_url":"https://api.github.com/users/LefterisJP/gists{/gist_id}","starred_url":"https://api.github.com/users/LefterisJP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LefterisJP/subscriptions","organizations_url":"https://api.github.com/users/LefterisJP/orgs","repos_url":"https://api.github.com/users/LefterisJP/repos","events_url":"https://api.github.com/users/LefterisJP/events{/privacy}","received_events_url":"https://api.github.com/users/LefterisJP/received_events","type":"User","site_admin":false},"body":"Implementing last bullet point of the [Abstract contracts story](https://www.pivotaltracker.com/story/show/88344782) converning constructors of base contracts and proper checks for providing all arguments. \r\n\r\nIf not all arguments to base constructors are provided the contract is marked as abstract.","created_at":"2015-04-02T15:00:31Z","updated_at":"2015-04-02T15:49:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0973478c23b5f0de89e7850cce18ab7096451942","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/1501/commits","review_comments_url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/1501/comments","review_comment_url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/1501/comments","statuses_url":"https://api.github.com/repos/ethereum/cpp-ethereum/statuses/35567e4e7ac5c53e991bd0e0736bc1ed054cec03","head":{"label":"LefterisJP:abstract_contract_contructors","ref":"abstract_contract_contructors","sha":"35567e4e7ac5c53e991bd0e0736bc1ed054cec03","user":{"login":"LefterisJP","id":1658405,"avatar_url":"https://avatars.githubusercontent.com/u/1658405?v=3","gravatar_id":"","url":"https://api.github.com/users/LefterisJP","html_url":"https://github.com/LefterisJP","followers_url":"https://api.github.com/users/LefterisJP/followers","following_url":"https://api.github.com/users/LefterisJP/following{/other_user}","gists_url":"https://api.github.com/users/LefterisJP/gists{/gist_id}","starred_url":"https://api.github.com/users/LefterisJP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LefterisJP/subscriptions","organizations_url":"https://api.github.com/users/LefterisJP/orgs","repos_url":"https://api.github.com/users/LefterisJP/repos","events_url":"https://api.github.com/users/LefterisJP/events{/privacy}","received_events_url":"https://api.github.com/users/LefterisJP/received_events","type":"User","site_admin":false},"repo":{"id":25381518,"name":"cpp-ethereum","full_name":"LefterisJP/cpp-ethereum","owner":{"login":"LefterisJP","id":1658405,"avatar_url":"https://avatars.githubusercontent.com/u/1658405?v=3","gravatar_id":"","url":"https://api.github.com/users/LefterisJP","html_url":"https://github.com/LefterisJP","followers_url":"https://api.github.com/users/LefterisJP/followers","following_url":"https://api.github.com/users/LefterisJP/following{/other_user}","gists_url":"https://api.github.com/users/LefterisJP/gists{/gist_id}","starred_url":"https://api.github.com/users/LefterisJP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LefterisJP/subscriptions","organizations_url":"https://api.github.com/users/LefterisJP/orgs","repos_url":"https://api.github.com/users/LefterisJP/repos","events_url":"https://api.github.com/users/LefterisJP/events{/privacy}","received_events_url":"https://api.github.com/users/LefterisJP/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/LefterisJP/cpp-ethereum","description":"Gavin Wood's C++ implementation of the Ethereum yellowpaper.","fork":true,"url":"https://api.github.com/repos/LefterisJP/cpp-ethereum","forks_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/forks","keys_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/teams","hooks_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/hooks","issue_events_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/issues/events{/number}","events_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/events","assignees_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/assignees{/user}","branches_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/branches{/branch}","tags_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/tags","blobs_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/git/refs{/sha}","trees_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/statuses/{sha}","languages_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/languages","stargazers_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/stargazers","contributors_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/contributors","subscribers_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/subscribers","subscription_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/subscription","commits_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/commits{/sha}","git_commits_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/git/commits{/sha}","comments_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/comments{/number}","issue_comment_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/issues/comments{/number}","contents_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/contents/{+path}","compare_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/merges","archive_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/downloads","issues_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/issues{/number}","pulls_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/pulls{/number}","milestones_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/milestones{/number}","notifications_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/labels{/name}","releases_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/releases{/id}","created_at":"2014-10-17T23:43:38Z","updated_at":"2015-04-02T11:27:53Z","pushed_at":"2015-04-02T15:43:15Z","git_url":"git://github.com/LefterisJP/cpp-ethereum.git","ssh_url":"git@github.com:LefterisJP/cpp-ethereum.git","clone_url":"https://github.com/LefterisJP/cpp-ethereum.git","svn_url":"https://github.com/LefterisJP/cpp-ethereum","homepage":"www.gavwood.com/Paper.pdf","size":19588,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"ethereum:develop","ref":"develop","sha":"76a2de718c4df0091c934f214bf2660ca27e1e14","user":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars.githubusercontent.com/u/6250754?v=3","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"repo":{"id":15460666,"name":"cpp-ethereum","full_name":"ethereum/cpp-ethereum","owner":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars.githubusercontent.com/u/6250754?v=3","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ethereum/cpp-ethereum","description":"Gavin Wood's C++ implementation of the Ethereum yellowpaper.","fork":false,"url":"https://api.github.com/repos/ethereum/cpp-ethereum","forks_url":"https://api.github.com/repos/ethereum/cpp-ethereum/forks","keys_url":"https://api.github.com/repos/ethereum/cpp-ethereum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereum/cpp-ethereum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereum/cpp-ethereum/teams","hooks_url":"https://api.github.com/repos/ethereum/cpp-ethereum/hooks","issue_events_url":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/events{/number}","events_url":"https://api.github.com/repos/ethereum/cpp-ethereum/events","assignees_url":"https://api.github.com/repos/ethereum/cpp-ethereum/assignees{/user}","branches_url":"https://api.github.com/repos/ethereum/cpp-ethereum/branches{/branch}","tags_url":"https://api.github.com/repos/ethereum/cpp-ethereum/tags","blobs_url":"https://api.github.com/repos/ethereum/cpp-ethereum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereum/cpp-ethereum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereum/cpp-ethereum/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereum/cpp-ethereum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereum/cpp-ethereum/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereum/cpp-ethereum/languages","stargazers_url":"https://api.github.com/repos/ethereum/cpp-ethereum/stargazers","contributors_url":"https://api.github.com/repos/ethereum/cpp-ethereum/contributors","subscribers_url":"https://api.github.com/repos/ethereum/cpp-ethereum/subscribers","subscription_url":"https://api.github.com/repos/ethereum/cpp-ethereum/subscription","commits_url":"https://api.github.com/repos/ethereum/cpp-ethereum/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereum/cpp-ethereum/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereum/cpp-ethereum/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethereum/cpp-ethereum/contents/{+path}","compare_url":"https://api.github.com/repos/ethereum/cpp-ethereum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereum/cpp-ethereum/merges","archive_url":"https://api.github.com/repos/ethereum/cpp-ethereum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereum/cpp-ethereum/downloads","issues_url":"https://api.github.com/repos/ethereum/cpp-ethereum/issues{/number}","pulls_url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereum/cpp-ethereum/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereum/cpp-ethereum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereum/cpp-ethereum/labels{/name}","releases_url":"https://api.github.com/repos/ethereum/cpp-ethereum/releases{/id}","created_at":"2013-12-26T21:26:06Z","updated_at":"2015-04-02T14:06:42Z","pushed_at":"2015-04-02T15:43:15Z","git_url":"git://github.com/ethereum/cpp-ethereum.git","ssh_url":"git@github.com:ethereum/cpp-ethereum.git","clone_url":"https://github.com/ethereum/cpp-ethereum.git","svn_url":"https://github.com/ethereum/cpp-ethereum","homepage":"www.gavwood.com/Paper.pdf","size":90080,"stargazers_count":438,"watchers_count":438,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":153,"mirror_url":null,"open_issues_count":133,"forks":153,"open_issues":133,"watchers":438,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/1501"},"html":{"href":"https://github.com/ethereum/cpp-ethereum/pull/1501"},"issue":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/1501"},"comments":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/1501/comments"},"review_comments":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/1501/comments"},"review_comment":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/1501/commits"},"statuses":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/statuses/35567e4e7ac5c53e991bd0e0736bc1ed054cec03"}}}}