{"action":"created","comment":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments/24585612","id":24585612,"diff_hunk":"@@ -81,8 +81,9 @@ typedef enum {\n     NETCONF_STATE_SLEEP,            /**< sleep mode */\n     NETCONF_STATE_IDLE,             /**< idle mode */\n     NETCONF_STATE_RX,               /**< receive mode */\n-    NETCONF_STATE_TX,               /**< transmit mode */\n-    NETCONF_STATE_RESET,            /**< reset mode */\n+    NETCONF_STATE_TX,               /**< triggers a transmition */\n+    NETCONF_STATE_RESET,            /**< triggers a hardware reset. The resulting\n+                                         state of the radio device is NETCONF_STATE_IDLE */","path":"sys/include/net/ng_netconf.h","position":17,"original_position":17,"commit_id":"fadc0cdb9872f8413afd3943fe90caef335c7463","original_commit_id":"fadc0cdb9872f8413afd3943fe90caef335c7463","user":{"login":"LudwigOrtmann","id":3739173,"avatar_url":"https://avatars.githubusercontent.com/u/3739173?v=3","gravatar_id":"","url":"https://api.github.com/users/LudwigOrtmann","html_url":"https://github.com/LudwigOrtmann","followers_url":"https://api.github.com/users/LudwigOrtmann/followers","following_url":"https://api.github.com/users/LudwigOrtmann/following{/other_user}","gists_url":"https://api.github.com/users/LudwigOrtmann/gists{/gist_id}","starred_url":"https://api.github.com/users/LudwigOrtmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LudwigOrtmann/subscriptions","organizations_url":"https://api.github.com/users/LudwigOrtmann/orgs","repos_url":"https://api.github.com/users/LudwigOrtmann/repos","events_url":"https://api.github.com/users/LudwigOrtmann/events{/privacy}","received_events_url":"https://api.github.com/users/LudwigOrtmann/received_events","type":"User","site_admin":false},"body":"I wouldn't even complain if this comment was put in its own line (before the subject of its content).","created_at":"2015-02-12T14:53:19Z","updated_at":"2015-02-12T14:53:19Z","html_url":"https://github.com/RIOT-OS/RIOT/pull/2446#discussion_r24585612","pull_request_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/2446","_links":{"self":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments/24585612"},"html":{"href":"https://github.com/RIOT-OS/RIOT/pull/2446#discussion_r24585612"},"pull_request":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/2446"}}},"pull_request":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/2446","id":29182423,"html_url":"https://github.com/RIOT-OS/RIOT/pull/2446","diff_url":"https://github.com/RIOT-OS/RIOT/pull/2446.diff","patch_url":"https://github.com/RIOT-OS/RIOT/pull/2446.patch","issue_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/2446","number":2446,"state":"open","locked":false,"title":"net/ng_netconf: fix doxygen comments","user":{"login":"thomaseichinger","id":56618,"avatar_url":"https://avatars.githubusercontent.com/u/56618?v=3","gravatar_id":"","url":"https://api.github.com/users/thomaseichinger","html_url":"https://github.com/thomaseichinger","followers_url":"https://api.github.com/users/thomaseichinger/followers","following_url":"https://api.github.com/users/thomaseichinger/following{/other_user}","gists_url":"https://api.github.com/users/thomaseichinger/gists{/gist_id}","starred_url":"https://api.github.com/users/thomaseichinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomaseichinger/subscriptions","organizations_url":"https://api.github.com/users/thomaseichinger/orgs","repos_url":"https://api.github.com/users/thomaseichinger/repos","events_url":"https://api.github.com/users/thomaseichinger/events{/privacy}","received_events_url":"https://api.github.com/users/thomaseichinger/received_events","type":"User","site_admin":false},"body":"followup to #2441 \r\n\r\nI think we have to be clear on `NETCONF_STATE_*`. If we interpret `NETCONF_STATE_TX` to **trigger** a transmission I think we need to state the expected state of the driver/device.\r\nBackground: from a driver perspective (at least for the at86rf2xx) the device is in \"tx mode\" already while loading the FIFO.\r\n\r\nAlso addressing @LudwigOrtmann's [comment](https://github.com/RIOT-OS/RIOT/pull/2441#issuecomment-74068776) and one typo.","created_at":"2015-02-12T14:24:21Z","updated_at":"2015-02-12T14:53:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c5ebb5799ce22aaf5727f0b30967b1f2ca6ee59e","assignee":{"login":"authmillenon","id":675644,"avatar_url":"https://avatars.githubusercontent.com/u/675644?v=3","gravatar_id":"","url":"https://api.github.com/users/authmillenon","html_url":"https://github.com/authmillenon","followers_url":"https://api.github.com/users/authmillenon/followers","following_url":"https://api.github.com/users/authmillenon/following{/other_user}","gists_url":"https://api.github.com/users/authmillenon/gists{/gist_id}","starred_url":"https://api.github.com/users/authmillenon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/authmillenon/subscriptions","organizations_url":"https://api.github.com/users/authmillenon/orgs","repos_url":"https://api.github.com/users/authmillenon/repos","events_url":"https://api.github.com/users/authmillenon/events{/privacy}","received_events_url":"https://api.github.com/users/authmillenon/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/milestones/11","labels_url":"https://api.github.com/repos/RIOT-OS/RIOT/milestones/11/labels","id":968921,"number":11,"title":"Network Stack Task Force","description":"The goal of this milestone is to implement the redesign of the network stack.\r\n\r\nTodo list at #2278.","creator":{"login":"OlegHahm","id":1590423,"avatar_url":"https://avatars.githubusercontent.com/u/1590423?v=3","gravatar_id":"","url":"https://api.github.com/users/OlegHahm","html_url":"https://github.com/OlegHahm","followers_url":"https://api.github.com/users/OlegHahm/followers","following_url":"https://api.github.com/users/OlegHahm/following{/other_user}","gists_url":"https://api.github.com/users/OlegHahm/gists{/gist_id}","starred_url":"https://api.github.com/users/OlegHahm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OlegHahm/subscriptions","organizations_url":"https://api.github.com/users/OlegHahm/orgs","repos_url":"https://api.github.com/users/OlegHahm/repos","events_url":"https://api.github.com/users/OlegHahm/events{/privacy}","received_events_url":"https://api.github.com/users/OlegHahm/received_events","type":"User","site_admin":false},"open_issues":9,"closed_issues":11,"state":"open","created_at":"2015-02-06T16:04:53Z","updated_at":"2015-02-12T14:24:46Z","due_on":"2015-04-07T22:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/2446/commits","review_comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/2446/comments","review_comment_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments/{number}","comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/2446/comments","statuses_url":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/fadc0cdb9872f8413afd3943fe90caef335c7463","head":{"label":"thomaseichinger:ng_netconf_reset","ref":"ng_netconf_reset","sha":"fadc0cdb9872f8413afd3943fe90caef335c7463","user":{"login":"thomaseichinger","id":56618,"avatar_url":"https://avatars.githubusercontent.com/u/56618?v=3","gravatar_id":"","url":"https://api.github.com/users/thomaseichinger","html_url":"https://github.com/thomaseichinger","followers_url":"https://api.github.com/users/thomaseichinger/followers","following_url":"https://api.github.com/users/thomaseichinger/following{/other_user}","gists_url":"https://api.github.com/users/thomaseichinger/gists{/gist_id}","starred_url":"https://api.github.com/users/thomaseichinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomaseichinger/subscriptions","organizations_url":"https://api.github.com/users/thomaseichinger/orgs","repos_url":"https://api.github.com/users/thomaseichinger/repos","events_url":"https://api.github.com/users/thomaseichinger/events{/privacy}","received_events_url":"https://api.github.com/users/thomaseichinger/received_events","type":"User","site_admin":false},"repo":{"id":11602439,"name":"RIOT","full_name":"thomaseichinger/RIOT","owner":{"login":"thomaseichinger","id":56618,"avatar_url":"https://avatars.githubusercontent.com/u/56618?v=3","gravatar_id":"","url":"https://api.github.com/users/thomaseichinger","html_url":"https://github.com/thomaseichinger","followers_url":"https://api.github.com/users/thomaseichinger/followers","following_url":"https://api.github.com/users/thomaseichinger/following{/other_user}","gists_url":"https://api.github.com/users/thomaseichinger/gists{/gist_id}","starred_url":"https://api.github.com/users/thomaseichinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomaseichinger/subscriptions","organizations_url":"https://api.github.com/users/thomaseichinger/orgs","repos_url":"https://api.github.com/users/thomaseichinger/repos","events_url":"https://api.github.com/users/thomaseichinger/events{/privacy}","received_events_url":"https://api.github.com/users/thomaseichinger/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/thomaseichinger/RIOT","description":"RIOT OS -  The revolutionary IoT OS","fork":true,"url":"https://api.github.com/repos/thomaseichinger/RIOT","forks_url":"https://api.github.com/repos/thomaseichinger/RIOT/forks","keys_url":"https://api.github.com/repos/thomaseichinger/RIOT/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thomaseichinger/RIOT/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thomaseichinger/RIOT/teams","hooks_url":"https://api.github.com/repos/thomaseichinger/RIOT/hooks","issue_events_url":"https://api.github.com/repos/thomaseichinger/RIOT/issues/events{/number}","events_url":"https://api.github.com/repos/thomaseichinger/RIOT/events","assignees_url":"https://api.github.com/repos/thomaseichinger/RIOT/assignees{/user}","branches_url":"https://api.github.com/repos/thomaseichinger/RIOT/branches{/branch}","tags_url":"https://api.github.com/repos/thomaseichinger/RIOT/tags","blobs_url":"https://api.github.com/repos/thomaseichinger/RIOT/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thomaseichinger/RIOT/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thomaseichinger/RIOT/git/refs{/sha}","trees_url":"https://api.github.com/repos/thomaseichinger/RIOT/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thomaseichinger/RIOT/statuses/{sha}","languages_url":"https://api.github.com/repos/thomaseichinger/RIOT/languages","stargazers_url":"https://api.github.com/repos/thomaseichinger/RIOT/stargazers","contributors_url":"https://api.github.com/repos/thomaseichinger/RIOT/contributors","subscribers_url":"https://api.github.com/repos/thomaseichinger/RIOT/subscribers","subscription_url":"https://api.github.com/repos/thomaseichinger/RIOT/subscription","commits_url":"https://api.github.com/repos/thomaseichinger/RIOT/commits{/sha}","git_commits_url":"https://api.github.com/repos/thomaseichinger/RIOT/git/commits{/sha}","comments_url":"https://api.github.com/repos/thomaseichinger/RIOT/comments{/number}","issue_comment_url":"https://api.github.com/repos/thomaseichinger/RIOT/issues/comments/{number}","contents_url":"https://api.github.com/repos/thomaseichinger/RIOT/contents/{+path}","compare_url":"https://api.github.com/repos/thomaseichinger/RIOT/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thomaseichinger/RIOT/merges","archive_url":"https://api.github.com/repos/thomaseichinger/RIOT/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thomaseichinger/RIOT/downloads","issues_url":"https://api.github.com/repos/thomaseichinger/RIOT/issues{/number}","pulls_url":"https://api.github.com/repos/thomaseichinger/RIOT/pulls{/number}","milestones_url":"https://api.github.com/repos/thomaseichinger/RIOT/milestones{/number}","notifications_url":"https://api.github.com/repos/thomaseichinger/RIOT/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thomaseichinger/RIOT/labels{/name}","releases_url":"https://api.github.com/repos/thomaseichinger/RIOT/releases{/id}","created_at":"2013-07-23T07:33:28Z","updated_at":"2014-06-23T08:50:01Z","pushed_at":"2015-02-12T14:23:47Z","git_url":"git://github.com/thomaseichinger/RIOT.git","ssh_url":"git@github.com:thomaseichinger/RIOT.git","clone_url":"https://github.com/thomaseichinger/RIOT.git","svn_url":"https://github.com/thomaseichinger/RIOT","homepage":"https://github.com/RIOT-OS/RIOT/wiki","size":19156,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"RIOT-OS:master","ref":"master","sha":"e6f21eee9784d718e913223ed35895d0218178eb","user":{"login":"RIOT-OS","id":3079480,"avatar_url":"https://avatars.githubusercontent.com/u/3079480?v=3","gravatar_id":"","url":"https://api.github.com/users/RIOT-OS","html_url":"https://github.com/RIOT-OS","followers_url":"https://api.github.com/users/RIOT-OS/followers","following_url":"https://api.github.com/users/RIOT-OS/following{/other_user}","gists_url":"https://api.github.com/users/RIOT-OS/gists{/gist_id}","starred_url":"https://api.github.com/users/RIOT-OS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RIOT-OS/subscriptions","organizations_url":"https://api.github.com/users/RIOT-OS/orgs","repos_url":"https://api.github.com/users/RIOT-OS/repos","events_url":"https://api.github.com/users/RIOT-OS/events{/privacy}","received_events_url":"https://api.github.com/users/RIOT-OS/received_events","type":"Organization","site_admin":false},"repo":{"id":7370241,"name":"RIOT","full_name":"RIOT-OS/RIOT","owner":{"login":"RIOT-OS","id":3079480,"avatar_url":"https://avatars.githubusercontent.com/u/3079480?v=3","gravatar_id":"","url":"https://api.github.com/users/RIOT-OS","html_url":"https://github.com/RIOT-OS","followers_url":"https://api.github.com/users/RIOT-OS/followers","following_url":"https://api.github.com/users/RIOT-OS/following{/other_user}","gists_url":"https://api.github.com/users/RIOT-OS/gists{/gist_id}","starred_url":"https://api.github.com/users/RIOT-OS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RIOT-OS/subscriptions","organizations_url":"https://api.github.com/users/RIOT-OS/orgs","repos_url":"https://api.github.com/users/RIOT-OS/repos","events_url":"https://api.github.com/users/RIOT-OS/events{/privacy}","received_events_url":"https://api.github.com/users/RIOT-OS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RIOT-OS/RIOT","description":"RIOT -  The friendly OS for IoT","fork":false,"url":"https://api.github.com/repos/RIOT-OS/RIOT","forks_url":"https://api.github.com/repos/RIOT-OS/RIOT/forks","keys_url":"https://api.github.com/repos/RIOT-OS/RIOT/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RIOT-OS/RIOT/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RIOT-OS/RIOT/teams","hooks_url":"https://api.github.com/repos/RIOT-OS/RIOT/hooks","issue_events_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/events{/number}","events_url":"https://api.github.com/repos/RIOT-OS/RIOT/events","assignees_url":"https://api.github.com/repos/RIOT-OS/RIOT/assignees{/user}","branches_url":"https://api.github.com/repos/RIOT-OS/RIOT/branches{/branch}","tags_url":"https://api.github.com/repos/RIOT-OS/RIOT/tags","blobs_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/refs{/sha}","trees_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/{sha}","languages_url":"https://api.github.com/repos/RIOT-OS/RIOT/languages","stargazers_url":"https://api.github.com/repos/RIOT-OS/RIOT/stargazers","contributors_url":"https://api.github.com/repos/RIOT-OS/RIOT/contributors","subscribers_url":"https://api.github.com/repos/RIOT-OS/RIOT/subscribers","subscription_url":"https://api.github.com/repos/RIOT-OS/RIOT/subscription","commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/commits{/sha}","git_commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/commits{/sha}","comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/comments{/number}","issue_comment_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/comments/{number}","contents_url":"https://api.github.com/repos/RIOT-OS/RIOT/contents/{+path}","compare_url":"https://api.github.com/repos/RIOT-OS/RIOT/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RIOT-OS/RIOT/merges","archive_url":"https://api.github.com/repos/RIOT-OS/RIOT/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RIOT-OS/RIOT/downloads","issues_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues{/number}","pulls_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls{/number}","milestones_url":"https://api.github.com/repos/RIOT-OS/RIOT/milestones{/number}","notifications_url":"https://api.github.com/repos/RIOT-OS/RIOT/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RIOT-OS/RIOT/labels{/name}","releases_url":"https://api.github.com/repos/RIOT-OS/RIOT/releases{/id}","created_at":"2012-12-29T20:38:40Z","updated_at":"2015-02-12T14:01:48Z","pushed_at":"2015-02-12T14:01:47Z","git_url":"git://github.com/RIOT-OS/RIOT.git","ssh_url":"git@github.com:RIOT-OS/RIOT.git","clone_url":"https://github.com/RIOT-OS/RIOT.git","svn_url":"https://github.com/RIOT-OS/RIOT","homepage":"https://github.com/RIOT-OS/RIOT/wiki","size":83575,"stargazers_count":257,"watchers_count":257,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":207,"mirror_url":null,"open_issues_count":285,"forks":207,"open_issues":285,"watchers":257,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/2446"},"html":{"href":"https://github.com/RIOT-OS/RIOT/pull/2446"},"issue":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/issues/2446"},"comments":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/issues/2446/comments"},"review_comments":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/2446/comments"},"review_comment":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/2446/commits"},"statuses":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/fadc0cdb9872f8413afd3943fe90caef335c7463"}}}}