{"action":"created","comment":{"url":"https://api.github.com/repos/reactphp/event-loop/pulls/comments/31869366","id":31869366,"diff_hunk":"@@ -59,11 +52,11 @@ public function isPeriodic()\n \n     public function isActive()\n     {\n-        return $this->loop->isTimerActive($this);\n+        return l\\loop()->isTimerActive($this);","path":"src/Timer/Timer.php","position":44,"original_position":44,"commit_id":"354cca73a9727bd81623ad8a4d99c4f392f3c4ad","original_commit_id":"354cca73a9727bd81623ad8a4d99c4f392f3c4ad","user":{"login":"clue","id":776829,"avatar_url":"https://avatars.githubusercontent.com/u/776829?v=3","gravatar_id":"","url":"https://api.github.com/users/clue","html_url":"https://github.com/clue","followers_url":"https://api.github.com/users/clue/followers","following_url":"https://api.github.com/users/clue/following{/other_user}","gists_url":"https://api.github.com/users/clue/gists{/gist_id}","starred_url":"https://api.github.com/users/clue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clue/subscriptions","organizations_url":"https://api.github.com/users/clue/orgs","repos_url":"https://api.github.com/users/clue/repos","events_url":"https://api.github.com/users/clue/events{/privacy}","received_events_url":"https://api.github.com/users/clue/received_events","type":"User","site_admin":false},"body":"IMHO it makes sense to no longer expose the loop as part of the timer interface (i.e. drop the `getLoop()` method).\r\n\r\nThough arguably, I'm also pro exposing the one loop via global state.\r\n\r\nHowever, I consider this very change a design flaw. Unless we move this logic to the timer itself, it *actually does* have a dependency on the loop. Accessing global state here means we're using a leaky abstraction and hiding the dependencies this particular class has. Also, this does make testing harder (no built-in mechanism to mock the loop).","created_at":"2015-06-06T16:26:05Z","updated_at":"2015-06-06T16:26:05Z","html_url":"https://github.com/reactphp/event-loop/pull/10#discussion_r31869366","pull_request_url":"https://api.github.com/repos/reactphp/event-loop/pulls/10","_links":{"self":{"href":"https://api.github.com/repos/reactphp/event-loop/pulls/comments/31869366"},"html":{"href":"https://github.com/reactphp/event-loop/pull/10#discussion_r31869366"},"pull_request":{"href":"https://api.github.com/repos/reactphp/event-loop/pulls/10"}}},"pull_request":{"url":"https://api.github.com/repos/reactphp/event-loop/pulls/10","id":19891838,"html_url":"https://github.com/reactphp/event-loop/pull/10","diff_url":"https://github.com/reactphp/event-loop/pull/10.diff","patch_url":"https://github.com/reactphp/event-loop/pull/10.patch","issue_url":"https://api.github.com/repos/reactphp/event-loop/issues/10","number":10,"state":"open","locked":false,"title":"Singularity","user":{"login":"igorw","id":88061,"avatar_url":"https://avatars.githubusercontent.com/u/88061?v=3","gravatar_id":"","url":"https://api.github.com/users/igorw","html_url":"https://github.com/igorw","followers_url":"https://api.github.com/users/igorw/followers","following_url":"https://api.github.com/users/igorw/following{/other_user}","gists_url":"https://api.github.com/users/igorw/gists{/gist_id}","starred_url":"https://api.github.com/users/igorw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/igorw/subscriptions","organizations_url":"https://api.github.com/users/igorw/orgs","repos_url":"https://api.github.com/users/igorw/repos","events_url":"https://api.github.com/users/igorw/events{/privacy}","received_events_url":"https://api.github.com/users/igorw/received_events","type":"User","site_admin":false},"body":"This pull request serves as a place for discussing some radical changes to the react API that I've been playing with. This is just a concept. It's just an idea. It needs a lot more work before the rest of react could use it.\r\n\r\nFeel free to share your thoughts here though.","created_at":"2014-08-17T18:14:49Z","updated_at":"2015-06-06T16:26:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7b35d2364875bfb2ba24d6a0e8710a242d8f288b","assignee":null,"milestone":{"url":"https://api.github.com/repos/reactphp/event-loop/milestones/2","html_url":"https://github.com/reactphp/event-loop/milestones/v0.5","labels_url":"https://api.github.com/repos/reactphp/event-loop/milestones/2/labels","id":675040,"number":2,"title":"v0.5","description":"","creator":{"login":"cboden","id":617694,"avatar_url":"https://avatars.githubusercontent.com/u/617694?v=3","gravatar_id":"","url":"https://api.github.com/users/cboden","html_url":"https://github.com/cboden","followers_url":"https://api.github.com/users/cboden/followers","following_url":"https://api.github.com/users/cboden/following{/other_user}","gists_url":"https://api.github.com/users/cboden/gists{/gist_id}","starred_url":"https://api.github.com/users/cboden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cboden/subscriptions","organizations_url":"https://api.github.com/users/cboden/orgs","repos_url":"https://api.github.com/users/cboden/repos","events_url":"https://api.github.com/users/cboden/events{/privacy}","received_events_url":"https://api.github.com/users/cboden/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":0,"state":"open","created_at":"2014-05-30T00:46:59Z","updated_at":"2014-10-28T22:14:48Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/reactphp/event-loop/pulls/10/commits","review_comments_url":"https://api.github.com/repos/reactphp/event-loop/pulls/10/comments","review_comment_url":"https://api.github.com/repos/reactphp/event-loop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/reactphp/event-loop/issues/10/comments","statuses_url":"https://api.github.com/repos/reactphp/event-loop/statuses/354cca73a9727bd81623ad8a4d99c4f392f3c4ad","head":{"label":"reactphp:singularity","ref":"singularity","sha":"354cca73a9727bd81623ad8a4d99c4f392f3c4ad","user":{"login":"reactphp","id":1696866,"avatar_url":"https://avatars.githubusercontent.com/u/1696866?v=3","gravatar_id":"","url":"https://api.github.com/users/reactphp","html_url":"https://github.com/reactphp","followers_url":"https://api.github.com/users/reactphp/followers","following_url":"https://api.github.com/users/reactphp/following{/other_user}","gists_url":"https://api.github.com/users/reactphp/gists{/gist_id}","starred_url":"https://api.github.com/users/reactphp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reactphp/subscriptions","organizations_url":"https://api.github.com/users/reactphp/orgs","repos_url":"https://api.github.com/users/reactphp/repos","events_url":"https://api.github.com/users/reactphp/events{/privacy}","received_events_url":"https://api.github.com/users/reactphp/received_events","type":"Organization","site_admin":false},"repo":{"id":4287598,"name":"event-loop","full_name":"reactphp/event-loop","owner":{"login":"reactphp","id":1696866,"avatar_url":"https://avatars.githubusercontent.com/u/1696866?v=3","gravatar_id":"","url":"https://api.github.com/users/reactphp","html_url":"https://github.com/reactphp","followers_url":"https://api.github.com/users/reactphp/followers","following_url":"https://api.github.com/users/reactphp/following{/other_user}","gists_url":"https://api.github.com/users/reactphp/gists{/gist_id}","starred_url":"https://api.github.com/users/reactphp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reactphp/subscriptions","organizations_url":"https://api.github.com/users/reactphp/orgs","repos_url":"https://api.github.com/users/reactphp/repos","events_url":"https://api.github.com/users/reactphp/events{/privacy}","received_events_url":"https://api.github.com/users/reactphp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/reactphp/event-loop","description":"React's core reactor event-loop","fork":false,"url":"https://api.github.com/repos/reactphp/event-loop","forks_url":"https://api.github.com/repos/reactphp/event-loop/forks","keys_url":"https://api.github.com/repos/reactphp/event-loop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reactphp/event-loop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reactphp/event-loop/teams","hooks_url":"https://api.github.com/repos/reactphp/event-loop/hooks","issue_events_url":"https://api.github.com/repos/reactphp/event-loop/issues/events{/number}","events_url":"https://api.github.com/repos/reactphp/event-loop/events","assignees_url":"https://api.github.com/repos/reactphp/event-loop/assignees{/user}","branches_url":"https://api.github.com/repos/reactphp/event-loop/branches{/branch}","tags_url":"https://api.github.com/repos/reactphp/event-loop/tags","blobs_url":"https://api.github.com/repos/reactphp/event-loop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reactphp/event-loop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reactphp/event-loop/git/refs{/sha}","trees_url":"https://api.github.com/repos/reactphp/event-loop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reactphp/event-loop/statuses/{sha}","languages_url":"https://api.github.com/repos/reactphp/event-loop/languages","stargazers_url":"https://api.github.com/repos/reactphp/event-loop/stargazers","contributors_url":"https://api.github.com/repos/reactphp/event-loop/contributors","subscribers_url":"https://api.github.com/repos/reactphp/event-loop/subscribers","subscription_url":"https://api.github.com/repos/reactphp/event-loop/subscription","commits_url":"https://api.github.com/repos/reactphp/event-loop/commits{/sha}","git_commits_url":"https://api.github.com/repos/reactphp/event-loop/git/commits{/sha}","comments_url":"https://api.github.com/repos/reactphp/event-loop/comments{/number}","issue_comment_url":"https://api.github.com/repos/reactphp/event-loop/issues/comments{/number}","contents_url":"https://api.github.com/repos/reactphp/event-loop/contents/{+path}","compare_url":"https://api.github.com/repos/reactphp/event-loop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reactphp/event-loop/merges","archive_url":"https://api.github.com/repos/reactphp/event-loop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reactphp/event-loop/downloads","issues_url":"https://api.github.com/repos/reactphp/event-loop/issues{/number}","pulls_url":"https://api.github.com/repos/reactphp/event-loop/pulls{/number}","milestones_url":"https://api.github.com/repos/reactphp/event-loop/milestones{/number}","notifications_url":"https://api.github.com/repos/reactphp/event-loop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reactphp/event-loop/labels{/name}","releases_url":"https://api.github.com/repos/reactphp/event-loop/releases{/id}","created_at":"2012-05-10T17:30:32Z","updated_at":"2015-05-28T01:23:45Z","pushed_at":"2015-06-04T08:23:52Z","git_url":"git://github.com/reactphp/event-loop.git","ssh_url":"git@github.com:reactphp/event-loop.git","clone_url":"https://github.com/reactphp/event-loop.git","svn_url":"https://github.com/reactphp/event-loop","homepage":"","size":899,"stargazers_count":76,"watchers_count":76,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":30,"mirror_url":null,"open_issues_count":15,"forks":30,"open_issues":15,"watchers":76,"default_branch":"master"}},"base":{"label":"reactphp:master","ref":"master","sha":"27c34c491c8588b1521cd42de4c3c5e21137456a","user":{"login":"reactphp","id":1696866,"avatar_url":"https://avatars.githubusercontent.com/u/1696866?v=3","gravatar_id":"","url":"https://api.github.com/users/reactphp","html_url":"https://github.com/reactphp","followers_url":"https://api.github.com/users/reactphp/followers","following_url":"https://api.github.com/users/reactphp/following{/other_user}","gists_url":"https://api.github.com/users/reactphp/gists{/gist_id}","starred_url":"https://api.github.com/users/reactphp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reactphp/subscriptions","organizations_url":"https://api.github.com/users/reactphp/orgs","repos_url":"https://api.github.com/users/reactphp/repos","events_url":"https://api.github.com/users/reactphp/events{/privacy}","received_events_url":"https://api.github.com/users/reactphp/received_events","type":"Organization","site_admin":false},"repo":{"id":4287598,"name":"event-loop","full_name":"reactphp/event-loop","owner":{"login":"reactphp","id":1696866,"avatar_url":"https://avatars.githubusercontent.com/u/1696866?v=3","gravatar_id":"","url":"https://api.github.com/users/reactphp","html_url":"https://github.com/reactphp","followers_url":"https://api.github.com/users/reactphp/followers","following_url":"https://api.github.com/users/reactphp/following{/other_user}","gists_url":"https://api.github.com/users/reactphp/gists{/gist_id}","starred_url":"https://api.github.com/users/reactphp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reactphp/subscriptions","organizations_url":"https://api.github.com/users/reactphp/orgs","repos_url":"https://api.github.com/users/reactphp/repos","events_url":"https://api.github.com/users/reactphp/events{/privacy}","received_events_url":"https://api.github.com/users/reactphp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/reactphp/event-loop","description":"React's core reactor event-loop","fork":false,"url":"https://api.github.com/repos/reactphp/event-loop","forks_url":"https://api.github.com/repos/reactphp/event-loop/forks","keys_url":"https://api.github.com/repos/reactphp/event-loop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reactphp/event-loop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reactphp/event-loop/teams","hooks_url":"https://api.github.com/repos/reactphp/event-loop/hooks","issue_events_url":"https://api.github.com/repos/reactphp/event-loop/issues/events{/number}","events_url":"https://api.github.com/repos/reactphp/event-loop/events","assignees_url":"https://api.github.com/repos/reactphp/event-loop/assignees{/user}","branches_url":"https://api.github.com/repos/reactphp/event-loop/branches{/branch}","tags_url":"https://api.github.com/repos/reactphp/event-loop/tags","blobs_url":"https://api.github.com/repos/reactphp/event-loop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reactphp/event-loop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reactphp/event-loop/git/refs{/sha}","trees_url":"https://api.github.com/repos/reactphp/event-loop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reactphp/event-loop/statuses/{sha}","languages_url":"https://api.github.com/repos/reactphp/event-loop/languages","stargazers_url":"https://api.github.com/repos/reactphp/event-loop/stargazers","contributors_url":"https://api.github.com/repos/reactphp/event-loop/contributors","subscribers_url":"https://api.github.com/repos/reactphp/event-loop/subscribers","subscription_url":"https://api.github.com/repos/reactphp/event-loop/subscription","commits_url":"https://api.github.com/repos/reactphp/event-loop/commits{/sha}","git_commits_url":"https://api.github.com/repos/reactphp/event-loop/git/commits{/sha}","comments_url":"https://api.github.com/repos/reactphp/event-loop/comments{/number}","issue_comment_url":"https://api.github.com/repos/reactphp/event-loop/issues/comments{/number}","contents_url":"https://api.github.com/repos/reactphp/event-loop/contents/{+path}","compare_url":"https://api.github.com/repos/reactphp/event-loop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reactphp/event-loop/merges","archive_url":"https://api.github.com/repos/reactphp/event-loop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reactphp/event-loop/downloads","issues_url":"https://api.github.com/repos/reactphp/event-loop/issues{/number}","pulls_url":"https://api.github.com/repos/reactphp/event-loop/pulls{/number}","milestones_url":"https://api.github.com/repos/reactphp/event-loop/milestones{/number}","notifications_url":"https://api.github.com/repos/reactphp/event-loop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reactphp/event-loop/labels{/name}","releases_url":"https://api.github.com/repos/reactphp/event-loop/releases{/id}","created_at":"2012-05-10T17:30:32Z","updated_at":"2015-05-28T01:23:45Z","pushed_at":"2015-06-04T08:23:52Z","git_url":"git://github.com/reactphp/event-loop.git","ssh_url":"git@github.com:reactphp/event-loop.git","clone_url":"https://github.com/reactphp/event-loop.git","svn_url":"https://github.com/reactphp/event-loop","homepage":"","size":899,"stargazers_count":76,"watchers_count":76,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":30,"mirror_url":null,"open_issues_count":15,"forks":30,"open_issues":15,"watchers":76,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/reactphp/event-loop/pulls/10"},"html":{"href":"https://github.com/reactphp/event-loop/pull/10"},"issue":{"href":"https://api.github.com/repos/reactphp/event-loop/issues/10"},"comments":{"href":"https://api.github.com/repos/reactphp/event-loop/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/reactphp/event-loop/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/reactphp/event-loop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/reactphp/event-loop/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/reactphp/event-loop/statuses/354cca73a9727bd81623ad8a4d99c4f392f3c4ad"}}}}