{"action":"created","comment":{"url":"https://api.github.com/repos/jquery/globalize/pulls/comments/37766475","id":37766475,"diff_hunk":"@@ -26,6 +26,33 @@ define([\n \tnumberFormatterFn, numberFormatProperties, numberNumberingSystem, numberParserFn,\n \tnumberParseProperties, numberPattern, numberSymbol, stringPad ) {\n \n+function validateDigits( properties ) {\n+\tvar minimumIntegerDigits = properties[ 2 ];\n+\tvar minimumFractionDigits = properties[ 3 ];\n+\tvar maximumFractionDigits = properties[ 4 ];\n+\n+\tvar minimumSignificantDigits = properties[ 5 ];\n+\tvar maximumSignificantDigits = properties[ 6 ];","path":"src/number.js","position":10,"original_position":10,"commit_id":"a88793d7a56b7d410576620ad611dcae7073ccbd","original_commit_id":"a88793d7a56b7d410576620ad611dcae7073ccbd","user":{"login":"jzaefferer","id":52585,"avatar_url":"https://avatars.githubusercontent.com/u/52585?v=3","gravatar_id":"","url":"https://api.github.com/users/jzaefferer","html_url":"https://github.com/jzaefferer","followers_url":"https://api.github.com/users/jzaefferer/followers","following_url":"https://api.github.com/users/jzaefferer/following{/other_user}","gists_url":"https://api.github.com/users/jzaefferer/gists{/gist_id}","starred_url":"https://api.github.com/users/jzaefferer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jzaefferer/subscriptions","organizations_url":"https://api.github.com/users/jzaefferer/orgs","repos_url":"https://api.github.com/users/jzaefferer/repos","events_url":"https://api.github.com/users/jzaefferer/events{/privacy}","received_events_url":"https://api.github.com/users/jzaefferer/received_events","type":"User","site_admin":false},"body":"For example:\r\n\r\nhttps://github.com/jquery/jquery-ui/commit/803eaf29f732a68793b806356096fe849b9f470b#diff-29e4c930be69ff962e7aee3f71878229R144\r\nhttps://github.com/jquery/qunit/commit/eaae69b822cb1410bd4c61eedd1b4a120757a5fe#diff-586f09c9d3a303fcf4f478bd0b1d5ca4R1","created_at":"2015-08-24T15:50:58Z","updated_at":"2015-08-24T15:50:58Z","html_url":"https://github.com/jquery/globalize/pull/484#discussion_r37766475","pull_request_url":"https://api.github.com/repos/jquery/globalize/pulls/484","_links":{"self":{"href":"https://api.github.com/repos/jquery/globalize/pulls/comments/37766475"},"html":{"href":"https://github.com/jquery/globalize/pull/484#discussion_r37766475"},"pull_request":{"href":"https://api.github.com/repos/jquery/globalize/pulls/484"}}},"pull_request":{"url":"https://api.github.com/repos/jquery/globalize/pulls/484","id":43104582,"html_url":"https://github.com/jquery/globalize/pull/484","diff_url":"https://github.com/jquery/globalize/pull/484.diff","patch_url":"https://github.com/jquery/globalize/pull/484.patch","issue_url":"https://api.github.com/repos/jquery/globalize/issues/484","number":484,"state":"open","locked":false,"title":"Number: Refactor formatter to extract lots of variables","user":{"login":"jzaefferer","id":52585,"avatar_url":"https://avatars.githubusercontent.com/u/52585?v=3","gravatar_id":"","url":"https://api.github.com/users/jzaefferer","html_url":"https://github.com/jzaefferer","followers_url":"https://api.github.com/users/jzaefferer/followers","following_url":"https://api.github.com/users/jzaefferer/following{/other_user}","gists_url":"https://api.github.com/users/jzaefferer/gists{/gist_id}","starred_url":"https://api.github.com/users/jzaefferer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jzaefferer/subscriptions","organizations_url":"https://api.github.com/users/jzaefferer/orgs","repos_url":"https://api.github.com/users/jzaefferer/repos","events_url":"https://api.github.com/users/jzaefferer/events{/privacy}","received_events_url":"https://api.github.com/users/jzaefferer/received_events","type":"User","site_admin":false},"body":"Ref https://github.com/jquery/globalize/pull/436#discussion_r36746515","created_at":"2015-08-22T14:49:13Z","updated_at":"2015-08-24T15:50:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a53d35b6a482f2f58c0bef6fbdc1e0fd7aafe597","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jquery/globalize/pulls/484/commits","review_comments_url":"https://api.github.com/repos/jquery/globalize/pulls/484/comments","review_comment_url":"https://api.github.com/repos/jquery/globalize/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jquery/globalize/issues/484/comments","statuses_url":"https://api.github.com/repos/jquery/globalize/statuses/a88793d7a56b7d410576620ad611dcae7073ccbd","head":{"label":"jzaefferer:mini-validate-refactor","ref":"mini-validate-refactor","sha":"a88793d7a56b7d410576620ad611dcae7073ccbd","user":{"login":"jzaefferer","id":52585,"avatar_url":"https://avatars.githubusercontent.com/u/52585?v=3","gravatar_id":"","url":"https://api.github.com/users/jzaefferer","html_url":"https://github.com/jzaefferer","followers_url":"https://api.github.com/users/jzaefferer/followers","following_url":"https://api.github.com/users/jzaefferer/following{/other_user}","gists_url":"https://api.github.com/users/jzaefferer/gists{/gist_id}","starred_url":"https://api.github.com/users/jzaefferer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jzaefferer/subscriptions","organizations_url":"https://api.github.com/users/jzaefferer/orgs","repos_url":"https://api.github.com/users/jzaefferer/repos","events_url":"https://api.github.com/users/jzaefferer/events{/privacy}","received_events_url":"https://api.github.com/users/jzaefferer/received_events","type":"User","site_admin":false},"repo":{"id":25356965,"name":"globalize","full_name":"jzaefferer/globalize","owner":{"login":"jzaefferer","id":52585,"avatar_url":"https://avatars.githubusercontent.com/u/52585?v=3","gravatar_id":"","url":"https://api.github.com/users/jzaefferer","html_url":"https://github.com/jzaefferer","followers_url":"https://api.github.com/users/jzaefferer/followers","following_url":"https://api.github.com/users/jzaefferer/following{/other_user}","gists_url":"https://api.github.com/users/jzaefferer/gists{/gist_id}","starred_url":"https://api.github.com/users/jzaefferer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jzaefferer/subscriptions","organizations_url":"https://api.github.com/users/jzaefferer/orgs","repos_url":"https://api.github.com/users/jzaefferer/repos","events_url":"https://api.github.com/users/jzaefferer/events{/privacy}","received_events_url":"https://api.github.com/users/jzaefferer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jzaefferer/globalize","description":"A JavaScript library for internationalization and localization that leverage the official Unicode CLDR JSON data","fork":true,"url":"https://api.github.com/repos/jzaefferer/globalize","forks_url":"https://api.github.com/repos/jzaefferer/globalize/forks","keys_url":"https://api.github.com/repos/jzaefferer/globalize/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jzaefferer/globalize/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jzaefferer/globalize/teams","hooks_url":"https://api.github.com/repos/jzaefferer/globalize/hooks","issue_events_url":"https://api.github.com/repos/jzaefferer/globalize/issues/events{/number}","events_url":"https://api.github.com/repos/jzaefferer/globalize/events","assignees_url":"https://api.github.com/repos/jzaefferer/globalize/assignees{/user}","branches_url":"https://api.github.com/repos/jzaefferer/globalize/branches{/branch}","tags_url":"https://api.github.com/repos/jzaefferer/globalize/tags","blobs_url":"https://api.github.com/repos/jzaefferer/globalize/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jzaefferer/globalize/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jzaefferer/globalize/git/refs{/sha}","trees_url":"https://api.github.com/repos/jzaefferer/globalize/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jzaefferer/globalize/statuses/{sha}","languages_url":"https://api.github.com/repos/jzaefferer/globalize/languages","stargazers_url":"https://api.github.com/repos/jzaefferer/globalize/stargazers","contributors_url":"https://api.github.com/repos/jzaefferer/globalize/contributors","subscribers_url":"https://api.github.com/repos/jzaefferer/globalize/subscribers","subscription_url":"https://api.github.com/repos/jzaefferer/globalize/subscription","commits_url":"https://api.github.com/repos/jzaefferer/globalize/commits{/sha}","git_commits_url":"https://api.github.com/repos/jzaefferer/globalize/git/commits{/sha}","comments_url":"https://api.github.com/repos/jzaefferer/globalize/comments{/number}","issue_comment_url":"https://api.github.com/repos/jzaefferer/globalize/issues/comments{/number}","contents_url":"https://api.github.com/repos/jzaefferer/globalize/contents/{+path}","compare_url":"https://api.github.com/repos/jzaefferer/globalize/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jzaefferer/globalize/merges","archive_url":"https://api.github.com/repos/jzaefferer/globalize/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jzaefferer/globalize/downloads","issues_url":"https://api.github.com/repos/jzaefferer/globalize/issues{/number}","pulls_url":"https://api.github.com/repos/jzaefferer/globalize/pulls{/number}","milestones_url":"https://api.github.com/repos/jzaefferer/globalize/milestones{/number}","notifications_url":"https://api.github.com/repos/jzaefferer/globalize/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jzaefferer/globalize/labels{/name}","releases_url":"https://api.github.com/repos/jzaefferer/globalize/releases{/id}","created_at":"2014-10-17T12:22:29Z","updated_at":"2014-10-16T12:42:18Z","pushed_at":"2015-08-24T13:41:11Z","git_url":"git://github.com/jzaefferer/globalize.git","ssh_url":"git@github.com:jzaefferer/globalize.git","clone_url":"https://github.com/jzaefferer/globalize.git","svn_url":"https://github.com/jzaefferer/globalize","homepage":"","size":5078,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jquery:master","ref":"master","sha":"ba53ea8b29227c9c8dd964f0e38beec2068bd11f","user":{"login":"jquery","id":70142,"avatar_url":"https://avatars.githubusercontent.com/u/70142?v=3","gravatar_id":"","url":"https://api.github.com/users/jquery","html_url":"https://github.com/jquery","followers_url":"https://api.github.com/users/jquery/followers","following_url":"https://api.github.com/users/jquery/following{/other_user}","gists_url":"https://api.github.com/users/jquery/gists{/gist_id}","starred_url":"https://api.github.com/users/jquery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jquery/subscriptions","organizations_url":"https://api.github.com/users/jquery/orgs","repos_url":"https://api.github.com/users/jquery/repos","events_url":"https://api.github.com/users/jquery/events{/privacy}","received_events_url":"https://api.github.com/users/jquery/received_events","type":"Organization","site_admin":false},"repo":{"id":946945,"name":"globalize","full_name":"jquery/globalize","owner":{"login":"jquery","id":70142,"avatar_url":"https://avatars.githubusercontent.com/u/70142?v=3","gravatar_id":"","url":"https://api.github.com/users/jquery","html_url":"https://github.com/jquery","followers_url":"https://api.github.com/users/jquery/followers","following_url":"https://api.github.com/users/jquery/following{/other_user}","gists_url":"https://api.github.com/users/jquery/gists{/gist_id}","starred_url":"https://api.github.com/users/jquery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jquery/subscriptions","organizations_url":"https://api.github.com/users/jquery/orgs","repos_url":"https://api.github.com/users/jquery/repos","events_url":"https://api.github.com/users/jquery/events{/privacy}","received_events_url":"https://api.github.com/users/jquery/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jquery/globalize","description":"A JavaScript library for internationalization and localization that leverages the official Unicode CLDR JSON data","fork":false,"url":"https://api.github.com/repos/jquery/globalize","forks_url":"https://api.github.com/repos/jquery/globalize/forks","keys_url":"https://api.github.com/repos/jquery/globalize/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jquery/globalize/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jquery/globalize/teams","hooks_url":"https://api.github.com/repos/jquery/globalize/hooks","issue_events_url":"https://api.github.com/repos/jquery/globalize/issues/events{/number}","events_url":"https://api.github.com/repos/jquery/globalize/events","assignees_url":"https://api.github.com/repos/jquery/globalize/assignees{/user}","branches_url":"https://api.github.com/repos/jquery/globalize/branches{/branch}","tags_url":"https://api.github.com/repos/jquery/globalize/tags","blobs_url":"https://api.github.com/repos/jquery/globalize/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jquery/globalize/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jquery/globalize/git/refs{/sha}","trees_url":"https://api.github.com/repos/jquery/globalize/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jquery/globalize/statuses/{sha}","languages_url":"https://api.github.com/repos/jquery/globalize/languages","stargazers_url":"https://api.github.com/repos/jquery/globalize/stargazers","contributors_url":"https://api.github.com/repos/jquery/globalize/contributors","subscribers_url":"https://api.github.com/repos/jquery/globalize/subscribers","subscription_url":"https://api.github.com/repos/jquery/globalize/subscription","commits_url":"https://api.github.com/repos/jquery/globalize/commits{/sha}","git_commits_url":"https://api.github.com/repos/jquery/globalize/git/commits{/sha}","comments_url":"https://api.github.com/repos/jquery/globalize/comments{/number}","issue_comment_url":"https://api.github.com/repos/jquery/globalize/issues/comments{/number}","contents_url":"https://api.github.com/repos/jquery/globalize/contents/{+path}","compare_url":"https://api.github.com/repos/jquery/globalize/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jquery/globalize/merges","archive_url":"https://api.github.com/repos/jquery/globalize/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jquery/globalize/downloads","issues_url":"https://api.github.com/repos/jquery/globalize/issues{/number}","pulls_url":"https://api.github.com/repos/jquery/globalize/pulls{/number}","milestones_url":"https://api.github.com/repos/jquery/globalize/milestones{/number}","notifications_url":"https://api.github.com/repos/jquery/globalize/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jquery/globalize/labels{/name}","releases_url":"https://api.github.com/repos/jquery/globalize/releases{/id}","created_at":"2010-09-28T23:01:58Z","updated_at":"2015-08-24T14:52:24Z","pushed_at":"2015-08-24T13:41:12Z","git_url":"git://github.com/jquery/globalize.git","ssh_url":"git@github.com:jquery/globalize.git","clone_url":"https://github.com/jquery/globalize.git","svn_url":"https://github.com/jquery/globalize","homepage":"","size":9354,"stargazers_count":2205,"watchers_count":2205,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":403,"mirror_url":null,"open_issues_count":87,"forks":403,"open_issues":87,"watchers":2205,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jquery/globalize/pulls/484"},"html":{"href":"https://github.com/jquery/globalize/pull/484"},"issue":{"href":"https://api.github.com/repos/jquery/globalize/issues/484"},"comments":{"href":"https://api.github.com/repos/jquery/globalize/issues/484/comments"},"review_comments":{"href":"https://api.github.com/repos/jquery/globalize/pulls/484/comments"},"review_comment":{"href":"https://api.github.com/repos/jquery/globalize/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jquery/globalize/pulls/484/commits"},"statuses":{"href":"https://api.github.com/repos/jquery/globalize/statuses/a88793d7a56b7d410576620ad611dcae7073ccbd"}}}}