{"action":"created","comment":{"url":"https://api.github.com/repos/pantsbuild/pants/pulls/comments/25959286","id":25959286,"diff_hunk":"@@ -145,15 +146,25 @@ def output(self, name):\n     if not m or m.group(0) != name:\n       raise Exception('Invalid output name: %s' % name)\n     if name not in self._outputs:\n-      path = os.path.join(self.run_tracker.run_info_dir, 'tool_outputs', '%s.%s' % (self.id, name))\n+      workunit_name = re.sub('[\\s/]', '_', self.name)","path":"src/python/pants/base/workunit.py","position":13,"original_position":13,"commit_id":"d8bfc7e282b685edefcf9a1a7f2e424890feaa67","original_commit_id":"d8bfc7e282b685edefcf9a1a7f2e424890feaa67","user":{"login":"ericzundel","id":119728,"avatar_url":"https://avatars.githubusercontent.com/u/119728?v=3","gravatar_id":"","url":"https://api.github.com/users/ericzundel","html_url":"https://github.com/ericzundel","followers_url":"https://api.github.com/users/ericzundel/followers","following_url":"https://api.github.com/users/ericzundel/following{/other_user}","gists_url":"https://api.github.com/users/ericzundel/gists{/gist_id}","starred_url":"https://api.github.com/users/ericzundel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericzundel/subscriptions","organizations_url":"https://api.github.com/users/ericzundel/orgs","repos_url":"https://api.github.com/users/ericzundel/repos","events_url":"https://api.github.com/users/ericzundel/events{/privacy}","received_events_url":"https://api.github.com/users/ericzundel/received_events","type":"User","site_admin":false},"body":"hmm, do I need to use a raw string here or escape the backslash in \\s ?","created_at":"2015-03-06T17:04:20Z","updated_at":"2015-03-06T17:04:20Z","html_url":"https://github.com/pantsbuild/pants/pull/1215#discussion_r25959286","pull_request_url":"https://api.github.com/repos/pantsbuild/pants/pulls/1215","_links":{"self":{"href":"https://api.github.com/repos/pantsbuild/pants/pulls/comments/25959286"},"html":{"href":"https://github.com/pantsbuild/pants/pull/1215#discussion_r25959286"},"pull_request":{"href":"https://api.github.com/repos/pantsbuild/pants/pulls/1215"}}},"pull_request":{"url":"https://api.github.com/repos/pantsbuild/pants/pulls/1215","id":30660910,"html_url":"https://github.com/pantsbuild/pants/pull/1215","diff_url":"https://github.com/pantsbuild/pants/pull/1215.diff","patch_url":"https://github.com/pantsbuild/pants/pull/1215.patch","issue_url":"https://api.github.com/repos/pantsbuild/pants/issues/1215","number":1215,"state":"open","locked":false,"title":"Make a nicer looking name for workunit output.","user":{"login":"ericzundel","id":119728,"avatar_url":"https://avatars.githubusercontent.com/u/119728?v=3","gravatar_id":"","url":"https://api.github.com/users/ericzundel","html_url":"https://github.com/ericzundel","followers_url":"https://api.github.com/users/ericzundel/followers","following_url":"https://api.github.com/users/ericzundel/following{/other_user}","gists_url":"https://api.github.com/users/ericzundel/gists{/gist_id}","starred_url":"https://api.github.com/users/ericzundel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericzundel/subscriptions","organizations_url":"https://api.github.com/users/ericzundel/orgs","repos_url":"https://api.github.com/users/ericzundel/repos","events_url":"https://api.github.com/users/ericzundel/events{/privacy}","received_events_url":"https://api.github.com/users/ericzundel/received_events","type":"User","site_admin":false},"body":"Also adds the capability to access the filename. I have wanted access to this in the past.","created_at":"2015-03-06T16:59:19Z","updated_at":"2015-03-06T17:04:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eb82171682421a680ec7a04fa74fc102d3742160","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/pantsbuild/pants/pulls/1215/commits","review_comments_url":"https://api.github.com/repos/pantsbuild/pants/pulls/1215/comments","review_comment_url":"https://api.github.com/repos/pantsbuild/pants/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pantsbuild/pants/issues/1215/comments","statuses_url":"https://api.github.com/repos/pantsbuild/pants/statuses/d8bfc7e282b685edefcf9a1a7f2e424890feaa67","head":{"label":"ericzundel:zundel/nice-names-task-output","ref":"zundel/nice-names-task-output","sha":"d8bfc7e282b685edefcf9a1a7f2e424890feaa67","user":{"login":"ericzundel","id":119728,"avatar_url":"https://avatars.githubusercontent.com/u/119728?v=3","gravatar_id":"","url":"https://api.github.com/users/ericzundel","html_url":"https://github.com/ericzundel","followers_url":"https://api.github.com/users/ericzundel/followers","following_url":"https://api.github.com/users/ericzundel/following{/other_user}","gists_url":"https://api.github.com/users/ericzundel/gists{/gist_id}","starred_url":"https://api.github.com/users/ericzundel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericzundel/subscriptions","organizations_url":"https://api.github.com/users/ericzundel/orgs","repos_url":"https://api.github.com/users/ericzundel/repos","events_url":"https://api.github.com/users/ericzundel/events{/privacy}","received_events_url":"https://api.github.com/users/ericzundel/received_events","type":"User","site_admin":false},"repo":{"id":19085989,"name":"pants","full_name":"ericzundel/pants","owner":{"login":"ericzundel","id":119728,"avatar_url":"https://avatars.githubusercontent.com/u/119728?v=3","gravatar_id":"","url":"https://api.github.com/users/ericzundel","html_url":"https://github.com/ericzundel","followers_url":"https://api.github.com/users/ericzundel/followers","following_url":"https://api.github.com/users/ericzundel/following{/other_user}","gists_url":"https://api.github.com/users/ericzundel/gists{/gist_id}","starred_url":"https://api.github.com/users/ericzundel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericzundel/subscriptions","organizations_url":"https://api.github.com/users/ericzundel/orgs","repos_url":"https://api.github.com/users/ericzundel/repos","events_url":"https://api.github.com/users/ericzundel/events{/privacy}","received_events_url":"https://api.github.com/users/ericzundel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ericzundel/pants","description":"Pants Build System","fork":true,"url":"https://api.github.com/repos/ericzundel/pants","forks_url":"https://api.github.com/repos/ericzundel/pants/forks","keys_url":"https://api.github.com/repos/ericzundel/pants/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ericzundel/pants/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ericzundel/pants/teams","hooks_url":"https://api.github.com/repos/ericzundel/pants/hooks","issue_events_url":"https://api.github.com/repos/ericzundel/pants/issues/events{/number}","events_url":"https://api.github.com/repos/ericzundel/pants/events","assignees_url":"https://api.github.com/repos/ericzundel/pants/assignees{/user}","branches_url":"https://api.github.com/repos/ericzundel/pants/branches{/branch}","tags_url":"https://api.github.com/repos/ericzundel/pants/tags","blobs_url":"https://api.github.com/repos/ericzundel/pants/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ericzundel/pants/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ericzundel/pants/git/refs{/sha}","trees_url":"https://api.github.com/repos/ericzundel/pants/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ericzundel/pants/statuses/{sha}","languages_url":"https://api.github.com/repos/ericzundel/pants/languages","stargazers_url":"https://api.github.com/repos/ericzundel/pants/stargazers","contributors_url":"https://api.github.com/repos/ericzundel/pants/contributors","subscribers_url":"https://api.github.com/repos/ericzundel/pants/subscribers","subscription_url":"https://api.github.com/repos/ericzundel/pants/subscription","commits_url":"https://api.github.com/repos/ericzundel/pants/commits{/sha}","git_commits_url":"https://api.github.com/repos/ericzundel/pants/git/commits{/sha}","comments_url":"https://api.github.com/repos/ericzundel/pants/comments{/number}","issue_comment_url":"https://api.github.com/repos/ericzundel/pants/issues/comments{/number}","contents_url":"https://api.github.com/repos/ericzundel/pants/contents/{+path}","compare_url":"https://api.github.com/repos/ericzundel/pants/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ericzundel/pants/merges","archive_url":"https://api.github.com/repos/ericzundel/pants/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ericzundel/pants/downloads","issues_url":"https://api.github.com/repos/ericzundel/pants/issues{/number}","pulls_url":"https://api.github.com/repos/ericzundel/pants/pulls{/number}","milestones_url":"https://api.github.com/repos/ericzundel/pants/milestones{/number}","notifications_url":"https://api.github.com/repos/ericzundel/pants/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ericzundel/pants/labels{/name}","releases_url":"https://api.github.com/repos/ericzundel/pants/releases{/id}","created_at":"2014-04-23T21:19:16Z","updated_at":"2015-02-18T19:01:39Z","pushed_at":"2015-03-06T16:59:01Z","git_url":"git://github.com/ericzundel/pants.git","ssh_url":"git@github.com:ericzundel/pants.git","clone_url":"https://github.com/ericzundel/pants.git","svn_url":"https://github.com/ericzundel/pants","homepage":"http://pantsbuild.github.io/","size":51711,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pantsbuild:master","ref":"master","sha":"7cf04171511c7aa5c47a7fe2094f9abdaa066d02","user":{"login":"pantsbuild","id":3065172,"avatar_url":"https://avatars.githubusercontent.com/u/3065172?v=3","gravatar_id":"","url":"https://api.github.com/users/pantsbuild","html_url":"https://github.com/pantsbuild","followers_url":"https://api.github.com/users/pantsbuild/followers","following_url":"https://api.github.com/users/pantsbuild/following{/other_user}","gists_url":"https://api.github.com/users/pantsbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/pantsbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pantsbuild/subscriptions","organizations_url":"https://api.github.com/users/pantsbuild/orgs","repos_url":"https://api.github.com/users/pantsbuild/repos","events_url":"https://api.github.com/users/pantsbuild/events{/privacy}","received_events_url":"https://api.github.com/users/pantsbuild/received_events","type":"Organization","site_admin":false},"repo":{"id":7209075,"name":"pants","full_name":"pantsbuild/pants","owner":{"login":"pantsbuild","id":3065172,"avatar_url":"https://avatars.githubusercontent.com/u/3065172?v=3","gravatar_id":"","url":"https://api.github.com/users/pantsbuild","html_url":"https://github.com/pantsbuild","followers_url":"https://api.github.com/users/pantsbuild/followers","following_url":"https://api.github.com/users/pantsbuild/following{/other_user}","gists_url":"https://api.github.com/users/pantsbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/pantsbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pantsbuild/subscriptions","organizations_url":"https://api.github.com/users/pantsbuild/orgs","repos_url":"https://api.github.com/users/pantsbuild/repos","events_url":"https://api.github.com/users/pantsbuild/events{/privacy}","received_events_url":"https://api.github.com/users/pantsbuild/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pantsbuild/pants","description":"Pants Build System","fork":false,"url":"https://api.github.com/repos/pantsbuild/pants","forks_url":"https://api.github.com/repos/pantsbuild/pants/forks","keys_url":"https://api.github.com/repos/pantsbuild/pants/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pantsbuild/pants/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pantsbuild/pants/teams","hooks_url":"https://api.github.com/repos/pantsbuild/pants/hooks","issue_events_url":"https://api.github.com/repos/pantsbuild/pants/issues/events{/number}","events_url":"https://api.github.com/repos/pantsbuild/pants/events","assignees_url":"https://api.github.com/repos/pantsbuild/pants/assignees{/user}","branches_url":"https://api.github.com/repos/pantsbuild/pants/branches{/branch}","tags_url":"https://api.github.com/repos/pantsbuild/pants/tags","blobs_url":"https://api.github.com/repos/pantsbuild/pants/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pantsbuild/pants/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pantsbuild/pants/git/refs{/sha}","trees_url":"https://api.github.com/repos/pantsbuild/pants/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pantsbuild/pants/statuses/{sha}","languages_url":"https://api.github.com/repos/pantsbuild/pants/languages","stargazers_url":"https://api.github.com/repos/pantsbuild/pants/stargazers","contributors_url":"https://api.github.com/repos/pantsbuild/pants/contributors","subscribers_url":"https://api.github.com/repos/pantsbuild/pants/subscribers","subscription_url":"https://api.github.com/repos/pantsbuild/pants/subscription","commits_url":"https://api.github.com/repos/pantsbuild/pants/commits{/sha}","git_commits_url":"https://api.github.com/repos/pantsbuild/pants/git/commits{/sha}","comments_url":"https://api.github.com/repos/pantsbuild/pants/comments{/number}","issue_comment_url":"https://api.github.com/repos/pantsbuild/pants/issues/comments{/number}","contents_url":"https://api.github.com/repos/pantsbuild/pants/contents/{+path}","compare_url":"https://api.github.com/repos/pantsbuild/pants/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pantsbuild/pants/merges","archive_url":"https://api.github.com/repos/pantsbuild/pants/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pantsbuild/pants/downloads","issues_url":"https://api.github.com/repos/pantsbuild/pants/issues{/number}","pulls_url":"https://api.github.com/repos/pantsbuild/pants/pulls{/number}","milestones_url":"https://api.github.com/repos/pantsbuild/pants/milestones{/number}","notifications_url":"https://api.github.com/repos/pantsbuild/pants/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pantsbuild/pants/labels{/name}","releases_url":"https://api.github.com/repos/pantsbuild/pants/releases{/id}","created_at":"2012-12-17T17:39:04Z","updated_at":"2015-03-06T13:45:26Z","pushed_at":"2015-03-06T13:45:26Z","git_url":"git://github.com/pantsbuild/pants.git","ssh_url":"git@github.com:pantsbuild/pants.git","clone_url":"https://github.com/pantsbuild/pants.git","svn_url":"https://github.com/pantsbuild/pants","homepage":"http://pantsbuild.github.io/","size":62932,"stargazers_count":318,"watchers_count":318,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":75,"mirror_url":null,"open_issues_count":202,"forks":75,"open_issues":202,"watchers":318,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pantsbuild/pants/pulls/1215"},"html":{"href":"https://github.com/pantsbuild/pants/pull/1215"},"issue":{"href":"https://api.github.com/repos/pantsbuild/pants/issues/1215"},"comments":{"href":"https://api.github.com/repos/pantsbuild/pants/issues/1215/comments"},"review_comments":{"href":"https://api.github.com/repos/pantsbuild/pants/pulls/1215/comments"},"review_comment":{"href":"https://api.github.com/repos/pantsbuild/pants/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pantsbuild/pants/pulls/1215/commits"},"statuses":{"href":"https://api.github.com/repos/pantsbuild/pants/statuses/d8bfc7e282b685edefcf9a1a7f2e424890feaa67"}}}}