{"action":"created","comment":{"url":"https://api.github.com/repos/symfony/symfony/pulls/comments/25932269","id":25932269,"diff_hunk":"@@ -26,6 +27,84 @@\n class IbanValidator extends ConstraintValidator\n {\n     /**\n+     * IBAN country specific formats\n+     *\n+     * The first 2 characters from an IBAN format are the two-character ISO country code.\n+     * The following 2 characters represent the check digits calculated from the rest of the IBAN characters.\n+     * The rest are up to thirty alphanumeric characters for\n+     * a BBAN (Basic Bank Account Number) which has a fixed length per country and,\n+     * included within it, a bank identifier with a fixed position and a fixed length per country\n+     *\n+     * @var array\n+     */\n+    protected $countryFormats = array(","path":"src/Symfony/Component/Validator/Constraints/IbanValidator.php","position":22,"original_position":22,"commit_id":"745abc74433f9ec1068882482d5ce40952a239b7","original_commit_id":"745abc74433f9ec1068882482d5ce40952a239b7","user":{"login":"stof","id":439401,"avatar_url":"https://avatars.githubusercontent.com/u/439401?v=3","gravatar_id":"","url":"https://api.github.com/users/stof","html_url":"https://github.com/stof","followers_url":"https://api.github.com/users/stof/followers","following_url":"https://api.github.com/users/stof/following{/other_user}","gists_url":"https://api.github.com/users/stof/gists{/gist_id}","starred_url":"https://api.github.com/users/stof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stof/subscriptions","organizations_url":"https://api.github.com/users/stof/orgs","repos_url":"https://api.github.com/users/stof/repos","events_url":"https://api.github.com/users/stof/events{/privacy}","received_events_url":"https://api.github.com/users/stof/received_events","type":"User","site_admin":false},"body":"should be private","created_at":"2015-03-06T08:57:31Z","updated_at":"2015-03-06T08:57:31Z","html_url":"https://github.com/symfony/symfony/pull/13828#discussion_r25932269","pull_request_url":"https://api.github.com/repos/symfony/symfony/pulls/13828","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/25932269"},"html":{"href":"https://github.com/symfony/symfony/pull/13828#discussion_r25932269"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony/pulls/13828"}}},"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/13828","id":30330270,"html_url":"https://github.com/symfony/symfony/pull/13828","diff_url":"https://github.com/symfony/symfony/pull/13828.diff","patch_url":"https://github.com/symfony/symfony/pull/13828.patch","issue_url":"https://api.github.com/repos/symfony/symfony/issues/13828","number":13828,"state":"open","locked":false,"title":"[Validator] Improve Iban Validation","user":{"login":"afurculita","id":3129631,"avatar_url":"https://avatars.githubusercontent.com/u/3129631?v=3","gravatar_id":"","url":"https://api.github.com/users/afurculita","html_url":"https://github.com/afurculita","followers_url":"https://api.github.com/users/afurculita/followers","following_url":"https://api.github.com/users/afurculita/following{/other_user}","gists_url":"https://api.github.com/users/afurculita/gists{/gist_id}","starred_url":"https://api.github.com/users/afurculita/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afurculita/subscriptions","organizations_url":"https://api.github.com/users/afurculita/orgs","repos_url":"https://api.github.com/users/afurculita/repos","events_url":"https://api.github.com/users/afurculita/events{/privacy}","received_events_url":"https://api.github.com/users/afurculita/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Bug fix?      | yes\r\n| New feature?  | no\r\n| BC breaks?    | no\r\n| Deprecations? | no\r\n| Tests pass?   | yes\r\n| Fixed tickets | https://github.com/symfony/symfony/issues/13802\r\n| License       | MIT\r\n| Doc PR        | \r\n\r\nThis PR adds 2 more checks for better IBAN validation: the validation of the country code (represented by the first 2 letters) and the format validation according to the country format regex based on http://www.swift.com/dsp/resources/documents/IBAN_Registry.pdf. \r\n\r\n","created_at":"2015-03-02T23:03:45Z","updated_at":"2015-03-06T08:57:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3544cc1d2f08726aeb0edc422443126302ba6bb2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/symfony/symfony/pulls/13828/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony/pulls/13828/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/13828/comments","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/745abc74433f9ec1068882482d5ce40952a239b7","head":{"label":"afurculita:better-iban-validation","ref":"better-iban-validation","sha":"745abc74433f9ec1068882482d5ce40952a239b7","user":{"login":"afurculita","id":3129631,"avatar_url":"https://avatars.githubusercontent.com/u/3129631?v=3","gravatar_id":"","url":"https://api.github.com/users/afurculita","html_url":"https://github.com/afurculita","followers_url":"https://api.github.com/users/afurculita/followers","following_url":"https://api.github.com/users/afurculita/following{/other_user}","gists_url":"https://api.github.com/users/afurculita/gists{/gist_id}","starred_url":"https://api.github.com/users/afurculita/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afurculita/subscriptions","organizations_url":"https://api.github.com/users/afurculita/orgs","repos_url":"https://api.github.com/users/afurculita/repos","events_url":"https://api.github.com/users/afurculita/events{/privacy}","received_events_url":"https://api.github.com/users/afurculita/received_events","type":"User","site_admin":false},"repo":{"id":31445966,"name":"symfony","full_name":"afurculita/symfony","owner":{"login":"afurculita","id":3129631,"avatar_url":"https://avatars.githubusercontent.com/u/3129631?v=3","gravatar_id":"","url":"https://api.github.com/users/afurculita","html_url":"https://github.com/afurculita","followers_url":"https://api.github.com/users/afurculita/followers","following_url":"https://api.github.com/users/afurculita/following{/other_user}","gists_url":"https://api.github.com/users/afurculita/gists{/gist_id}","starred_url":"https://api.github.com/users/afurculita/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afurculita/subscriptions","organizations_url":"https://api.github.com/users/afurculita/orgs","repos_url":"https://api.github.com/users/afurculita/repos","events_url":"https://api.github.com/users/afurculita/events{/privacy}","received_events_url":"https://api.github.com/users/afurculita/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/afurculita/symfony","description":"The Symfony PHP framework","fork":true,"url":"https://api.github.com/repos/afurculita/symfony","forks_url":"https://api.github.com/repos/afurculita/symfony/forks","keys_url":"https://api.github.com/repos/afurculita/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/afurculita/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/afurculita/symfony/teams","hooks_url":"https://api.github.com/repos/afurculita/symfony/hooks","issue_events_url":"https://api.github.com/repos/afurculita/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/afurculita/symfony/events","assignees_url":"https://api.github.com/repos/afurculita/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/afurculita/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/afurculita/symfony/tags","blobs_url":"https://api.github.com/repos/afurculita/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/afurculita/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/afurculita/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/afurculita/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/afurculita/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/afurculita/symfony/languages","stargazers_url":"https://api.github.com/repos/afurculita/symfony/stargazers","contributors_url":"https://api.github.com/repos/afurculita/symfony/contributors","subscribers_url":"https://api.github.com/repos/afurculita/symfony/subscribers","subscription_url":"https://api.github.com/repos/afurculita/symfony/subscription","commits_url":"https://api.github.com/repos/afurculita/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/afurculita/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/afurculita/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/afurculita/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/afurculita/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/afurculita/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/afurculita/symfony/merges","archive_url":"https://api.github.com/repos/afurculita/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/afurculita/symfony/downloads","issues_url":"https://api.github.com/repos/afurculita/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/afurculita/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/afurculita/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/afurculita/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/afurculita/symfony/labels{/name}","releases_url":"https://api.github.com/repos/afurculita/symfony/releases{/id}","created_at":"2015-02-28T00:56:48Z","updated_at":"2015-03-01T10:01:30Z","pushed_at":"2015-03-02T23:05:06Z","git_url":"git://github.com/afurculita/symfony.git","ssh_url":"git@github.com:afurculita/symfony.git","clone_url":"https://github.com/afurculita/symfony.git","svn_url":"https://github.com/afurculita/symfony","homepage":"symfony.com","size":52444,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"2.7"}},"base":{"label":"symfony:2.7","ref":"2.7","sha":"c491332e0fa802f87d9cdace0f680bf4509c8fb4","user":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":458058,"name":"symfony","full_name":"symfony/symfony","owner":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/symfony","description":"The Symfony PHP framework","fork":false,"url":"https://api.github.com/repos/symfony/symfony","forks_url":"https://api.github.com/repos/symfony/symfony/forks","keys_url":"https://api.github.com/repos/symfony/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony/teams","hooks_url":"https://api.github.com/repos/symfony/symfony/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony/events","assignees_url":"https://api.github.com/repos/symfony/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony/tags","blobs_url":"https://api.github.com/repos/symfony/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony/subscription","commits_url":"https://api.github.com/repos/symfony/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony/merges","archive_url":"https://api.github.com/repos/symfony/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony/downloads","issues_url":"https://api.github.com/repos/symfony/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony/releases{/id}","created_at":"2010-01-04T14:21:21Z","updated_at":"2015-03-06T06:56:47Z","pushed_at":"2015-03-05T17:01:07Z","git_url":"git://github.com/symfony/symfony.git","ssh_url":"git@github.com:symfony/symfony.git","clone_url":"https://github.com/symfony/symfony.git","svn_url":"https://github.com/symfony/symfony","homepage":"symfony.com","size":204704,"stargazers_count":9786,"watchers_count":9786,"language":"PHP","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":3822,"mirror_url":null,"open_issues_count":753,"forks":3822,"open_issues":753,"watchers":9786,"default_branch":"2.7"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/13828"},"html":{"href":"https://github.com/symfony/symfony/pull/13828"},"issue":{"href":"https://api.github.com/repos/symfony/symfony/issues/13828"},"comments":{"href":"https://api.github.com/repos/symfony/symfony/issues/13828/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony/pulls/13828/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony/pulls/13828/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony/statuses/745abc74433f9ec1068882482d5ce40952a239b7"}}}}