{"action":"created","issue":{"url":"https://api.github.com/repos/tgalal/yowsup/issues/1182","labels_url":"https://api.github.com/repos/tgalal/yowsup/issues/1182/labels{/name}","comments_url":"https://api.github.com/repos/tgalal/yowsup/issues/1182/comments","events_url":"https://api.github.com/repos/tgalal/yowsup/issues/1182/events","html_url":"https://github.com/tgalal/yowsup/pull/1182","id":121310506,"number":1182,"title":"#1181: Event callback feature implementation. YowInterfaceLayer","user":{"login":"jlmadurga","id":4689706,"avatar_url":"https://avatars.githubusercontent.com/u/4689706?v=3","gravatar_id":"","url":"https://api.github.com/users/jlmadurga","html_url":"https://github.com/jlmadurga","followers_url":"https://api.github.com/users/jlmadurga/followers","following_url":"https://api.github.com/users/jlmadurga/following{/other_user}","gists_url":"https://api.github.com/users/jlmadurga/gists{/gist_id}","starred_url":"https://api.github.com/users/jlmadurga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlmadurga/subscriptions","organizations_url":"https://api.github.com/users/jlmadurga/orgs","repos_url":"https://api.github.com/users/jlmadurga/repos","events_url":"https://api.github.com/users/jlmadurga/events{/privacy}","received_events_url":"https://api.github.com/users/jlmadurga/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-12-09T18:33:25Z","updated_at":"2015-12-13T17:57:16Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/tgalal/yowsup/pulls/1182","html_url":"https://github.com/tgalal/yowsup/pull/1182","diff_url":"https://github.com/tgalal/yowsup/pull/1182.diff","patch_url":"https://github.com/tgalal/yowsup/pull/1182.patch"},"body":"As described in #1181 decorator for event callbacks is implemented. Nothing reinvented just following the ProtocolEntity callback scheme for this implementation.\r\nEvent callback added to yowsup-cli.\r\n\r\nMoreover, I found `YowLayerTest` not enough for testing events. I have added some functionality for `emitEvent` and `broadcastEvent` testing. \r\n\r\n"},"comment":{"url":"https://api.github.com/repos/tgalal/yowsup/issues/comments/164283101","html_url":"https://github.com/tgalal/yowsup/pull/1182#issuecomment-164283101","issue_url":"https://api.github.com/repos/tgalal/yowsup/issues/1182","id":164283101,"user":{"login":"tgalal","id":895331,"avatar_url":"https://avatars.githubusercontent.com/u/895331?v=3","gravatar_id":"","url":"https://api.github.com/users/tgalal","html_url":"https://github.com/tgalal","followers_url":"https://api.github.com/users/tgalal/followers","following_url":"https://api.github.com/users/tgalal/following{/other_user}","gists_url":"https://api.github.com/users/tgalal/gists{/gist_id}","starred_url":"https://api.github.com/users/tgalal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgalal/subscriptions","organizations_url":"https://api.github.com/users/tgalal/orgs","repos_url":"https://api.github.com/users/tgalal/repos","events_url":"https://api.github.com/users/tgalal/events{/privacy}","received_events_url":"https://api.github.com/users/tgalal/received_events","type":"User","site_admin":false},"created_at":"2015-12-13T17:57:16Z","updated_at":"2015-12-13T17:57:16Z","body":"While I like that improvement as it would make code much readable, I think it makes sense to have decoration available on the YowLayer level, and not just on YowInterfaceLayer right ?  Because all layers are handling events, while in case of ProtocolEntityCallback it's YowInterfaceLayer specific"}}