{"action":"created","issue":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/11121","labels_url":"https://api.github.com/repos/cms-sw/cmssw/issues/11121/labels{/name}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/11121/comments","events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/11121/events","html_url":"https://github.com/cms-sw/cmssw/pull/11121","id":104859794,"number":11121,"title":"Fastsim newrechits rebase sep4","user":{"login":"lveldere","id":5065551,"avatar_url":"https://avatars.githubusercontent.com/u/5065551?v=3","gravatar_id":"","url":"https://api.github.com/users/lveldere","html_url":"https://github.com/lveldere","followers_url":"https://api.github.com/users/lveldere/followers","following_url":"https://api.github.com/users/lveldere/following{/other_user}","gists_url":"https://api.github.com/users/lveldere/gists{/gist_id}","starred_url":"https://api.github.com/users/lveldere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lveldere/subscriptions","organizations_url":"https://api.github.com/users/lveldere/orgs","repos_url":"https://api.github.com/users/lveldere/repos","events_url":"https://api.github.com/users/lveldere/events{/privacy}","received_events_url":"https://api.github.com/users/lveldere/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/analysis-pending","name":"analysis-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-available","name":"comparison-available","color":"009800"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/fastsim-approved","name":"fastsim-approved","color":"009800"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/geometry-approved","name":"geometry-approved","color":"009800"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/pending-signatures","name":"pending-signatures","color":"eb6420"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/reconstruction-approved","name":"reconstruction-approved","color":"009800"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/simulation-approved","name":"simulation-approved","color":"009800"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-approved","name":"tests-approved","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/55","html_url":"https://github.com/cms-sw/cmssw/milestones/Next%20CMSSW_7_6_X","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/55/labels","id":1176788,"number":55,"title":"Next CMSSW_7_6_X","description":"","creator":{"login":"smuzaffar","id":4115138,"avatar_url":"https://avatars.githubusercontent.com/u/4115138?v=3","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":97,"closed_issues":589,"state":"open","created_at":"2015-06-23T07:27:04Z","updated_at":"2015-09-09T05:51:07Z","due_on":null,"closed_at":null},"comments":9,"created_at":"2015-09-04T09:44:33Z","updated_at":"2015-09-09T08:35:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/11121","html_url":"https://github.com/cms-sw/cmssw/pull/11121","diff_url":"https://github.com/cms-sw/cmssw/pull/11121.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/11121.patch"},"body":"rebase of #11078\r\n\r\n* fastsim tracker rechit classes are replaced with\r\n   - a fastsim base class FastTrackerRecHit\r\n   - a fastsim class for single rechits FastSingleTrackerRecHit\r\n   (accomodates the fastsim equivalents of SiPixelRecHit, SiStripRecHit2D and SiStripRecHit1D)\r\n   - a fastsim equivalent of SiStripMatchedRecHit2D, FastMatchedTrackerRecHit\r\n   - a fastsim equivalent of ProjectedSiStripRecHit2D, FastProjectedTrackerRecHit\r\n\r\n* trackerHitRTTI::RTTI is extended to accommodate the new rechit containers\r\n\r\n* a new implementation of FastTrackerRecHit::sharesInput\r\n   ( will receive further study once merged)\r\n\r\n* rechit production is further modularised\r\n    - actual rechit production by the old SiTrackerGaussianSmearingRecHitConverter\r\n    - hit matching by new FastTrackerRecHitMatcher\r\n    - predefined combinations of hits by new FastTrackerRecHitCombiner\r\n\r\n* SiTrackerGaussianSmearingRecHitConverter produces now\r\n  OwnVector\\<FastTrackerRecHit\\>\r\n  vector<\\Ref\\<FastTrackerRecHitCollection\\> \\> with one entry per SimHit to find for each SimHit the corresponding RecHit\r\n\r\n* predefined combinations of hits are now in a new, simple format:\r\n  vector\\<vector\\<Ref\\<FastTrackerRecHitCollection\\> \\> \\>\r\n\r\n* model for hit splitting has been improved and moved to a separate class FastTrackerRecHitSplitter\r\n\r\n* model for masking of hits in iterative tracking improved\r\n   (see HitMaskHelper and FastTrackerRecHitMaskProducer)\r\n\r\n* GlobalPixelTracking is not fully migrated yet (it produces zero result):\r\n  it was not properly configured to begin with,\r\n  and we need to study the fullsim equivalent before fixing it\r\n\r\n* various code files were updated for the new rechit classes and the new rechit combination format\r\n\r\n* y position of strip hits is set to 0 (before it was the simhit y-position)\r\n\r\n* unit tests: a few fastsim events are generated on the fly, such to circumvent the backward incompatibility introduced by this pr. Unit tests to be restored when new relvals are available."},"comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments/138828362","html_url":"https://github.com/cms-sw/cmssw/pull/11121#issuecomment-138828362","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/11121","id":138828362,"user":{"login":"lveldere","id":5065551,"avatar_url":"https://avatars.githubusercontent.com/u/5065551?v=3","gravatar_id":"","url":"https://api.github.com/users/lveldere","html_url":"https://github.com/lveldere","followers_url":"https://api.github.com/users/lveldere/followers","following_url":"https://api.github.com/users/lveldere/following{/other_user}","gists_url":"https://api.github.com/users/lveldere/gists{/gist_id}","starred_url":"https://api.github.com/users/lveldere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lveldere/subscriptions","organizations_url":"https://api.github.com/users/lveldere/orgs","repos_url":"https://api.github.com/users/lveldere/repos","events_url":"https://api.github.com/users/lveldere/events{/privacy}","received_events_url":"https://api.github.com/users/lveldere/received_events","type":"User","site_admin":false},"created_at":"2015-09-09T08:35:48Z","updated_at":"2015-09-09T08:35:48Z","body":"@slava77 \r\nThanks for the comments!\r\nI will get rid of the exits as soon as this pr gets merged.\r\nAbout the log files: this is a known issue in the HLT paths.\r\nI have a branch with a fix, and I will make a pr when this one gets merged."}}