{"action":"created","issue":{"url":"https://api.github.com/repos/EventStore/EventStore/issues/618","labels_url":"https://api.github.com/repos/EventStore/EventStore/issues/618/labels{/name}","comments_url":"https://api.github.com/repos/EventStore/EventStore/issues/618/comments","events_url":"https://api.github.com/repos/EventStore/EventStore/issues/618/events","html_url":"https://github.com/EventStore/EventStore/pull/618","id":103232750,"number":618,"title":"refactored PesistentSubscriptionConsumer strategies (RoundRobin and S…","user":{"login":"riccardone","id":5390480,"avatar_url":"https://avatars.githubusercontent.com/u/5390480?v=3","gravatar_id":"","url":"https://api.github.com/users/riccardone","html_url":"https://github.com/riccardone","followers_url":"https://api.github.com/users/riccardone/followers","following_url":"https://api.github.com/users/riccardone/following{/other_user}","gists_url":"https://api.github.com/users/riccardone/gists{/gist_id}","starred_url":"https://api.github.com/users/riccardone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riccardone/subscriptions","organizations_url":"https://api.github.com/users/riccardone/orgs","repos_url":"https://api.github.com/users/riccardone/repos","events_url":"https://api.github.com/users/riccardone/events{/privacy}","received_events_url":"https://api.github.com/users/riccardone/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-08-26T10:32:01Z","updated_at":"2015-09-02T12:32:43Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/EventStore/EventStore/pulls/618","html_url":"https://github.com/EventStore/EventStore/pull/618","diff_url":"https://github.com/EventStore/EventStore/pull/618.diff","patch_url":"https://github.com/EventStore/EventStore/pull/618.patch"},"body":"I refactored RoundRobinPersistentSubscriptionConsumerStrategy and DispatchToSinglePersistentSubscriptionConsumerStrategy in order to use a Queue datastructure instead of a list. This remove the need to use a \"Move to next\" method, a class field _currentIndex and a class property CurrentIndex. I guess that performance are not negatively affected but this is something to test. I think that the new Round Robin implementation is executed in circular order. If we want to implement multithreading in the future we can just use the \"Cuncurrent\" version of the Queue data structure.\r\nHope this help."},"comment":{"url":"https://api.github.com/repos/EventStore/EventStore/issues/comments/137058552","html_url":"https://github.com/EventStore/EventStore/pull/618#issuecomment-137058552","issue_url":"https://api.github.com/repos/EventStore/EventStore/issues/618","id":137058552,"user":{"login":"riccardone","id":5390480,"avatar_url":"https://avatars.githubusercontent.com/u/5390480?v=3","gravatar_id":"","url":"https://api.github.com/users/riccardone","html_url":"https://github.com/riccardone","followers_url":"https://api.github.com/users/riccardone/followers","following_url":"https://api.github.com/users/riccardone/following{/other_user}","gists_url":"https://api.github.com/users/riccardone/gists{/gist_id}","starred_url":"https://api.github.com/users/riccardone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riccardone/subscriptions","organizations_url":"https://api.github.com/users/riccardone/orgs","repos_url":"https://api.github.com/users/riccardone/repos","events_url":"https://api.github.com/users/riccardone/events{/privacy}","received_events_url":"https://api.github.com/users/riccardone/received_events","type":"User","site_admin":false},"created_at":"2015-09-02T12:32:43Z","updated_at":"2015-09-02T12:32:43Z","body":"Please let me know if any additional information is required"}}