{"action":"created","issue":{"url":"https://api.github.com/repos/gotwarlost/istanbul/issues/286","labels_url":"https://api.github.com/repos/gotwarlost/istanbul/issues/286/labels{/name}","comments_url":"https://api.github.com/repos/gotwarlost/istanbul/issues/286/comments","events_url":"https://api.github.com/repos/gotwarlost/istanbul/issues/286/events","html_url":"https://github.com/gotwarlost/istanbul/pull/286","id":51563212,"number":286,"title":"support explicit includes for cover + tests","user":{"login":"tonylukasavage","id":594112,"avatar_url":"https://avatars.githubusercontent.com/u/594112?v=3","gravatar_id":"","url":"https://api.github.com/users/tonylukasavage","html_url":"https://github.com/tonylukasavage","followers_url":"https://api.github.com/users/tonylukasavage/followers","following_url":"https://api.github.com/users/tonylukasavage/following{/other_user}","gists_url":"https://api.github.com/users/tonylukasavage/gists{/gist_id}","starred_url":"https://api.github.com/users/tonylukasavage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tonylukasavage/subscriptions","organizations_url":"https://api.github.com/users/tonylukasavage/orgs","repos_url":"https://api.github.com/users/tonylukasavage/repos","events_url":"https://api.github.com/users/tonylukasavage/events{/privacy}","received_events_url":"https://api.github.com/users/tonylukasavage/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2014-12-10T14:21:46Z","updated_at":"2015-02-19T14:03:25Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/gotwarlost/istanbul/pulls/286","html_url":"https://github.com/gotwarlost/istanbul/pull/286","diff_url":"https://github.com/gotwarlost/istanbul/pull/286.diff","patch_url":"https://github.com/gotwarlost/istanbul/pull/286.patch"},"body":"I have a particular situation where I'd like more control over the included files filter with the `cover` command. The `cover` command has an non-configurable `fileset` filter of `['**/*.js']`. While this works in most cases, I am also trying to generate coverage reports for files in my `bin` folder, following the loose directions provided by @gotwarlost in [https://github.com/gotwarlost/istanbul/issues/97#issuecomment-25222169](https://github.com/gotwarlost/istanbul/issues/97#issuecomment-25222169). The composite report directions work, but only if I hack my local copy of istanbul and set that file filter from `['**/*.js']` to `['**/*']`. \r\n\r\nRather than providing a quick hack to provide an option to load all files, I added a corollary option to the `-x` excludes as `-i` for includes. It follows the same pattern and usage as `-x`, except that it allows you to explicitly define includes instead of excludes. Now if developers have Javascript files with extensions other than `.js`, which would be common in the case of testing node.js \"binaries\", they can specify their own include filters to have them included in the report.\r\n\r\nTest coverage was also slightly improved by the additional testing I added to cover this. Prior to this pull request the number were:\r\n\r\n```\r\nStatements: 96.69%\r\nBranches: 91%\r\nFunctions: 98.79%\r\nLines: 97.33%\r\n```\r\n\r\nWith this pull request they improve to:\r\n\r\n```\r\nStatements: 96.74%\r\nBranches: 91.13%\r\nFunctions: 98.79%\r\nLines: 97.37%\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/gotwarlost/istanbul/issues/comments/75056187","html_url":"https://github.com/gotwarlost/istanbul/pull/286#issuecomment-75056187","issue_url":"https://api.github.com/repos/gotwarlost/istanbul/issues/286","id":75056187,"user":{"login":"tonylukasavage","id":594112,"avatar_url":"https://avatars.githubusercontent.com/u/594112?v=3","gravatar_id":"","url":"https://api.github.com/users/tonylukasavage","html_url":"https://github.com/tonylukasavage","followers_url":"https://api.github.com/users/tonylukasavage/followers","following_url":"https://api.github.com/users/tonylukasavage/following{/other_user}","gists_url":"https://api.github.com/users/tonylukasavage/gists{/gist_id}","starred_url":"https://api.github.com/users/tonylukasavage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tonylukasavage/subscriptions","organizations_url":"https://api.github.com/users/tonylukasavage/orgs","repos_url":"https://api.github.com/users/tonylukasavage/repos","events_url":"https://api.github.com/users/tonylukasavage/events{/privacy}","received_events_url":"https://api.github.com/users/tonylukasavage/received_events","type":"User","site_admin":false},"created_at":"2015-02-19T14:03:25Z","updated_at":"2015-02-19T14:03:25Z","body":"OK, I fixed the typo that @gotwarlost mentioned. I didn't make the additional changes @lo1tuma suggested, though. I'll leave the instrumentation changes and yml option for someone else in a future PR."}}