{"action":"created","comment":{"url":"https://api.github.com/repos/italiangrid/storm/pulls/comments/27644833","id":27644833,"diff_hunk":"@@ -316,28 +319,39 @@ private void fakeSAtoAnalyze(List<String> absPaths) {\n \t\tlog.info(\"Background DU tasks size: {}\", bDUTasks.getTasks().size());\r\n \t}\r\n \r\n+\tprivate List<TSpaceToken> retrieveSTtoInitializeWithQuota() {\r\n+\t\tlog.debug(\"Retrieving the list of SpaceToken with quota to initialize\");\r\n+\t\tList<TSpaceToken> result = new ArrayList<TSpaceToken>();\r\n+\t\tList<StorageSpaceData> toInitialize = retrieveSSDtoInitializeWithQuota();\r\n+\t\tfor (StorageSpaceData ssd : toInitialize) {\r\n+\t\t\tif (ssd.getSpaceToken() == null) {\r\n+\t\t\t\tlog.debug(\"Null spacetoken found for {}\", ssd);\r\n+\t\t\t\tcontinue;\r\n+\t\t\t}\r\n+\t\t\tresult.add(ssd.getSpaceToken());\r\n+\t\t\tlog.debug(\"Added {}\", ssd.getSpaceToken());\r\n+\t\t}\r\n+\t\tlog.debug(\"Returned {} elements\", result.size());\r\n+\t\treturn result;\r\n+\t}\r\n+\t\r\n \tprivate void foundSAtoAnalyze() {\r\n \r\n \t\tList<StorageSpaceData> toAnalyze = spaceCatalog\r\n \t\t\t.getStorageSpaceNotInitialized();\r\n+\t\tList<TSpaceToken> quotaEnabledST = retrieveSTtoInitializeWithQuota();\r","path":"src/main/java/it/grid/storm/info/SpaceInfoManager.java","position":40,"original_position":40,"commit_id":"cd2962b81e6f1d4a769f6b9bc887aeb3cc0e01ff","original_commit_id":"cd2962b81e6f1d4a769f6b9bc887aeb3cc0e01ff","user":{"login":"andreaceccanti","id":1152853,"avatar_url":"https://avatars.githubusercontent.com/u/1152853?v=3","gravatar_id":"","url":"https://api.github.com/users/andreaceccanti","html_url":"https://github.com/andreaceccanti","followers_url":"https://api.github.com/users/andreaceccanti/followers","following_url":"https://api.github.com/users/andreaceccanti/following{/other_user}","gists_url":"https://api.github.com/users/andreaceccanti/gists{/gist_id}","starred_url":"https://api.github.com/users/andreaceccanti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreaceccanti/subscriptions","organizations_url":"https://api.github.com/users/andreaceccanti/orgs","repos_url":"https://api.github.com/users/andreaceccanti/repos","events_url":"https://api.github.com/users/andreaceccanti/events{/privacy}","received_events_url":"https://api.github.com/users/andreaceccanti/received_events","type":"User","site_admin":false},"body":"Use collection filtering with a comparator instead of building another collection with only the tokens.","created_at":"2015-04-02T10:02:39Z","updated_at":"2015-04-02T10:02:39Z","html_url":"https://github.com/italiangrid/storm/pull/60#discussion_r27644833","pull_request_url":"https://api.github.com/repos/italiangrid/storm/pulls/60","_links":{"self":{"href":"https://api.github.com/repos/italiangrid/storm/pulls/comments/27644833"},"html":{"href":"https://github.com/italiangrid/storm/pull/60#discussion_r27644833"},"pull_request":{"href":"https://api.github.com/repos/italiangrid/storm/pulls/60"}}},"pull_request":{"url":"https://api.github.com/repos/italiangrid/storm/pulls/60","id":32490102,"html_url":"https://github.com/italiangrid/storm/pull/60","diff_url":"https://github.com/italiangrid/storm/pull/60.diff","patch_url":"https://github.com/italiangrid/storm/pull/60.patch","issue_url":"https://api.github.com/repos/italiangrid/storm/issues/60","number":60,"state":"open","locked":false,"title":"Fix for https://issues.infn.it/jira/browse/STOR-792","user":{"login":"enricovianello","id":1914039,"avatar_url":"https://avatars.githubusercontent.com/u/1914039?v=3","gravatar_id":"","url":"https://api.github.com/users/enricovianello","html_url":"https://github.com/enricovianello","followers_url":"https://api.github.com/users/enricovianello/followers","following_url":"https://api.github.com/users/enricovianello/following{/other_user}","gists_url":"https://api.github.com/users/enricovianello/gists{/gist_id}","starred_url":"https://api.github.com/users/enricovianello/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enricovianello/subscriptions","organizations_url":"https://api.github.com/users/enricovianello/orgs","repos_url":"https://api.github.com/users/enricovianello/repos","events_url":"https://api.github.com/users/enricovianello/events{/privacy}","received_events_url":"https://api.github.com/users/enricovianello/received_events","type":"User","site_admin":false},"body":"At launch, StoRM Backend calls a DU for each storage area which have no storage space info initialized (used-space is -1), even if the storage area is on GPFS with quota enabled and there's a thread that updates periodically the info. Analyzing the code, I found that the DU were called only after the check on the used space. By removing from the list of the storage areas not initialized the ones which have quota enabled, the problem was solved.\r\nAbout the storage areas which have no quota enabled and not initialized info, the launch of the DU can't currently be avoided at StoRM Backend launch. However there's a way to statically initialize via YAIM the space info to avoid them (used-space won't be found -1).","created_at":"2015-04-02T07:58:18Z","updated_at":"2015-04-02T10:02:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7c4749212f11e62cef3746e8335901f8097c813a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/italiangrid/storm/pulls/60/commits","review_comments_url":"https://api.github.com/repos/italiangrid/storm/pulls/60/comments","review_comment_url":"https://api.github.com/repos/italiangrid/storm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/italiangrid/storm/issues/60/comments","statuses_url":"https://api.github.com/repos/italiangrid/storm/statuses/cd2962b81e6f1d4a769f6b9bc887aeb3cc0e01ff","head":{"label":"italiangrid:fix/STOR-792","ref":"fix/STOR-792","sha":"cd2962b81e6f1d4a769f6b9bc887aeb3cc0e01ff","user":{"login":"italiangrid","id":1155825,"avatar_url":"https://avatars.githubusercontent.com/u/1155825?v=3","gravatar_id":"","url":"https://api.github.com/users/italiangrid","html_url":"https://github.com/italiangrid","followers_url":"https://api.github.com/users/italiangrid/followers","following_url":"https://api.github.com/users/italiangrid/following{/other_user}","gists_url":"https://api.github.com/users/italiangrid/gists{/gist_id}","starred_url":"https://api.github.com/users/italiangrid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/italiangrid/subscriptions","organizations_url":"https://api.github.com/users/italiangrid/orgs","repos_url":"https://api.github.com/users/italiangrid/repos","events_url":"https://api.github.com/users/italiangrid/events{/privacy}","received_events_url":"https://api.github.com/users/italiangrid/received_events","type":"Organization","site_admin":false},"repo":{"id":8199683,"name":"storm","full_name":"italiangrid/storm","owner":{"login":"italiangrid","id":1155825,"avatar_url":"https://avatars.githubusercontent.com/u/1155825?v=3","gravatar_id":"","url":"https://api.github.com/users/italiangrid","html_url":"https://github.com/italiangrid","followers_url":"https://api.github.com/users/italiangrid/followers","following_url":"https://api.github.com/users/italiangrid/following{/other_user}","gists_url":"https://api.github.com/users/italiangrid/gists{/gist_id}","starred_url":"https://api.github.com/users/italiangrid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/italiangrid/subscriptions","organizations_url":"https://api.github.com/users/italiangrid/orgs","repos_url":"https://api.github.com/users/italiangrid/repos","events_url":"https://api.github.com/users/italiangrid/events{/privacy}","received_events_url":"https://api.github.com/users/italiangrid/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/italiangrid/storm","description":"StoRM (STOrage Resource Manager) is a light, scalable, flexible, high-performance, file system-independent storage manager service (SRM) for generic disk based storage system, compliant with the standard SRM interface version 2.2.","fork":false,"url":"https://api.github.com/repos/italiangrid/storm","forks_url":"https://api.github.com/repos/italiangrid/storm/forks","keys_url":"https://api.github.com/repos/italiangrid/storm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/italiangrid/storm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/italiangrid/storm/teams","hooks_url":"https://api.github.com/repos/italiangrid/storm/hooks","issue_events_url":"https://api.github.com/repos/italiangrid/storm/issues/events{/number}","events_url":"https://api.github.com/repos/italiangrid/storm/events","assignees_url":"https://api.github.com/repos/italiangrid/storm/assignees{/user}","branches_url":"https://api.github.com/repos/italiangrid/storm/branches{/branch}","tags_url":"https://api.github.com/repos/italiangrid/storm/tags","blobs_url":"https://api.github.com/repos/italiangrid/storm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/italiangrid/storm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/italiangrid/storm/git/refs{/sha}","trees_url":"https://api.github.com/repos/italiangrid/storm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/italiangrid/storm/statuses/{sha}","languages_url":"https://api.github.com/repos/italiangrid/storm/languages","stargazers_url":"https://api.github.com/repos/italiangrid/storm/stargazers","contributors_url":"https://api.github.com/repos/italiangrid/storm/contributors","subscribers_url":"https://api.github.com/repos/italiangrid/storm/subscribers","subscription_url":"https://api.github.com/repos/italiangrid/storm/subscription","commits_url":"https://api.github.com/repos/italiangrid/storm/commits{/sha}","git_commits_url":"https://api.github.com/repos/italiangrid/storm/git/commits{/sha}","comments_url":"https://api.github.com/repos/italiangrid/storm/comments{/number}","issue_comment_url":"https://api.github.com/repos/italiangrid/storm/issues/comments{/number}","contents_url":"https://api.github.com/repos/italiangrid/storm/contents/{+path}","compare_url":"https://api.github.com/repos/italiangrid/storm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/italiangrid/storm/merges","archive_url":"https://api.github.com/repos/italiangrid/storm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/italiangrid/storm/downloads","issues_url":"https://api.github.com/repos/italiangrid/storm/issues{/number}","pulls_url":"https://api.github.com/repos/italiangrid/storm/pulls{/number}","milestones_url":"https://api.github.com/repos/italiangrid/storm/milestones{/number}","notifications_url":"https://api.github.com/repos/italiangrid/storm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/italiangrid/storm/labels{/name}","releases_url":"https://api.github.com/repos/italiangrid/storm/releases{/id}","created_at":"2013-02-14T13:16:22Z","updated_at":"2015-03-16T11:33:08Z","pushed_at":"2015-04-02T07:58:19Z","git_url":"git://github.com/italiangrid/storm.git","ssh_url":"git@github.com:italiangrid/storm.git","clone_url":"https://github.com/italiangrid/storm.git","svn_url":"https://github.com/italiangrid/storm","homepage":"http://italiangrid.github.io/storm/","size":51092,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"italiangrid:develop","ref":"develop","sha":"eec424610d77aa468d9f0ddd14d6fd93d4efaba6","user":{"login":"italiangrid","id":1155825,"avatar_url":"https://avatars.githubusercontent.com/u/1155825?v=3","gravatar_id":"","url":"https://api.github.com/users/italiangrid","html_url":"https://github.com/italiangrid","followers_url":"https://api.github.com/users/italiangrid/followers","following_url":"https://api.github.com/users/italiangrid/following{/other_user}","gists_url":"https://api.github.com/users/italiangrid/gists{/gist_id}","starred_url":"https://api.github.com/users/italiangrid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/italiangrid/subscriptions","organizations_url":"https://api.github.com/users/italiangrid/orgs","repos_url":"https://api.github.com/users/italiangrid/repos","events_url":"https://api.github.com/users/italiangrid/events{/privacy}","received_events_url":"https://api.github.com/users/italiangrid/received_events","type":"Organization","site_admin":false},"repo":{"id":8199683,"name":"storm","full_name":"italiangrid/storm","owner":{"login":"italiangrid","id":1155825,"avatar_url":"https://avatars.githubusercontent.com/u/1155825?v=3","gravatar_id":"","url":"https://api.github.com/users/italiangrid","html_url":"https://github.com/italiangrid","followers_url":"https://api.github.com/users/italiangrid/followers","following_url":"https://api.github.com/users/italiangrid/following{/other_user}","gists_url":"https://api.github.com/users/italiangrid/gists{/gist_id}","starred_url":"https://api.github.com/users/italiangrid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/italiangrid/subscriptions","organizations_url":"https://api.github.com/users/italiangrid/orgs","repos_url":"https://api.github.com/users/italiangrid/repos","events_url":"https://api.github.com/users/italiangrid/events{/privacy}","received_events_url":"https://api.github.com/users/italiangrid/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/italiangrid/storm","description":"StoRM (STOrage Resource Manager) is a light, scalable, flexible, high-performance, file system-independent storage manager service (SRM) for generic disk based storage system, compliant with the standard SRM interface version 2.2.","fork":false,"url":"https://api.github.com/repos/italiangrid/storm","forks_url":"https://api.github.com/repos/italiangrid/storm/forks","keys_url":"https://api.github.com/repos/italiangrid/storm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/italiangrid/storm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/italiangrid/storm/teams","hooks_url":"https://api.github.com/repos/italiangrid/storm/hooks","issue_events_url":"https://api.github.com/repos/italiangrid/storm/issues/events{/number}","events_url":"https://api.github.com/repos/italiangrid/storm/events","assignees_url":"https://api.github.com/repos/italiangrid/storm/assignees{/user}","branches_url":"https://api.github.com/repos/italiangrid/storm/branches{/branch}","tags_url":"https://api.github.com/repos/italiangrid/storm/tags","blobs_url":"https://api.github.com/repos/italiangrid/storm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/italiangrid/storm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/italiangrid/storm/git/refs{/sha}","trees_url":"https://api.github.com/repos/italiangrid/storm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/italiangrid/storm/statuses/{sha}","languages_url":"https://api.github.com/repos/italiangrid/storm/languages","stargazers_url":"https://api.github.com/repos/italiangrid/storm/stargazers","contributors_url":"https://api.github.com/repos/italiangrid/storm/contributors","subscribers_url":"https://api.github.com/repos/italiangrid/storm/subscribers","subscription_url":"https://api.github.com/repos/italiangrid/storm/subscription","commits_url":"https://api.github.com/repos/italiangrid/storm/commits{/sha}","git_commits_url":"https://api.github.com/repos/italiangrid/storm/git/commits{/sha}","comments_url":"https://api.github.com/repos/italiangrid/storm/comments{/number}","issue_comment_url":"https://api.github.com/repos/italiangrid/storm/issues/comments{/number}","contents_url":"https://api.github.com/repos/italiangrid/storm/contents/{+path}","compare_url":"https://api.github.com/repos/italiangrid/storm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/italiangrid/storm/merges","archive_url":"https://api.github.com/repos/italiangrid/storm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/italiangrid/storm/downloads","issues_url":"https://api.github.com/repos/italiangrid/storm/issues{/number}","pulls_url":"https://api.github.com/repos/italiangrid/storm/pulls{/number}","milestones_url":"https://api.github.com/repos/italiangrid/storm/milestones{/number}","notifications_url":"https://api.github.com/repos/italiangrid/storm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/italiangrid/storm/labels{/name}","releases_url":"https://api.github.com/repos/italiangrid/storm/releases{/id}","created_at":"2013-02-14T13:16:22Z","updated_at":"2015-03-16T11:33:08Z","pushed_at":"2015-04-02T07:58:19Z","git_url":"git://github.com/italiangrid/storm.git","ssh_url":"git@github.com:italiangrid/storm.git","clone_url":"https://github.com/italiangrid/storm.git","svn_url":"https://github.com/italiangrid/storm","homepage":"http://italiangrid.github.io/storm/","size":51092,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/italiangrid/storm/pulls/60"},"html":{"href":"https://github.com/italiangrid/storm/pull/60"},"issue":{"href":"https://api.github.com/repos/italiangrid/storm/issues/60"},"comments":{"href":"https://api.github.com/repos/italiangrid/storm/issues/60/comments"},"review_comments":{"href":"https://api.github.com/repos/italiangrid/storm/pulls/60/comments"},"review_comment":{"href":"https://api.github.com/repos/italiangrid/storm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/italiangrid/storm/pulls/60/commits"},"statuses":{"href":"https://api.github.com/repos/italiangrid/storm/statuses/cd2962b81e6f1d4a769f6b9bc887aeb3cc0e01ff"}}}}