{"action":"opened","number":3083,"pull_request":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3083","id":45798007,"html_url":"https://github.com/dolphin-emu/dolphin/pull/3083","diff_url":"https://github.com/dolphin-emu/dolphin/pull/3083.diff","patch_url":"https://github.com/dolphin-emu/dolphin/pull/3083.patch","issue_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3083","number":3083,"state":"open","locked":false,"title":"Use correct GetTicksPerSecond() value in IPC delays","user":{"login":"JosJuice","id":6716818,"avatar_url":"https://avatars.githubusercontent.com/u/6716818?v=3","gravatar_id":"","url":"https://api.github.com/users/JosJuice","html_url":"https://github.com/JosJuice","followers_url":"https://api.github.com/users/JosJuice/followers","following_url":"https://api.github.com/users/JosJuice/following{/other_user}","gists_url":"https://api.github.com/users/JosJuice/gists{/gist_id}","starred_url":"https://api.github.com/users/JosJuice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JosJuice/subscriptions","organizations_url":"https://api.github.com/users/JosJuice/orgs","repos_url":"https://api.github.com/users/JosJuice/repos","events_url":"https://api.github.com/users/JosJuice/events{/privacy}","received_events_url":"https://api.github.com/users/JosJuice/received_events","type":"User","site_admin":false},"body":"The constant IPC_DEFAULT_DELAY used a value from GetTicksPerSecond(), which in turn uses a value from CPU_CORE_CLOCK... but CPU_CORE_CLOCK isn't actually a constant! It's first initialized to 486 MHz and then changed to 729 MHz in SystemTimers::PreInit if emulating a Wii. This means that the IPC delays always used 486 MHz and thus were wrong. To fix this, the IPC reply constants are changed to functions.","created_at":"2015-09-23T16:03:44Z","updated_at":"2015-09-23T16:03:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3083/commits","review_comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3083/comments","review_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3083/comments","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/3fdae38e26c339c21de784f3155316b033060b3b","head":{"label":"JosJuice:ipc-ticks","ref":"ipc-ticks","sha":"3fdae38e26c339c21de784f3155316b033060b3b","user":{"login":"JosJuice","id":6716818,"avatar_url":"https://avatars.githubusercontent.com/u/6716818?v=3","gravatar_id":"","url":"https://api.github.com/users/JosJuice","html_url":"https://github.com/JosJuice","followers_url":"https://api.github.com/users/JosJuice/followers","following_url":"https://api.github.com/users/JosJuice/following{/other_user}","gists_url":"https://api.github.com/users/JosJuice/gists{/gist_id}","starred_url":"https://api.github.com/users/JosJuice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JosJuice/subscriptions","organizations_url":"https://api.github.com/users/JosJuice/orgs","repos_url":"https://api.github.com/users/JosJuice/repos","events_url":"https://api.github.com/users/JosJuice/events{/privacy}","received_events_url":"https://api.github.com/users/JosJuice/received_events","type":"User","site_admin":false},"repo":{"id":26057138,"name":"dolphin","full_name":"JosJuice/dolphin","owner":{"login":"JosJuice","id":6716818,"avatar_url":"https://avatars.githubusercontent.com/u/6716818?v=3","gravatar_id":"","url":"https://api.github.com/users/JosJuice","html_url":"https://github.com/JosJuice","followers_url":"https://api.github.com/users/JosJuice/followers","following_url":"https://api.github.com/users/JosJuice/following{/other_user}","gists_url":"https://api.github.com/users/JosJuice/gists{/gist_id}","starred_url":"https://api.github.com/users/JosJuice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JosJuice/subscriptions","organizations_url":"https://api.github.com/users/JosJuice/orgs","repos_url":"https://api.github.com/users/JosJuice/repos","events_url":"https://api.github.com/users/JosJuice/events{/privacy}","received_events_url":"https://api.github.com/users/JosJuice/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JosJuice/dolphin","description":"Dolphin is a GameCube/Wii emulator, allowing you to play games for these two platforms on PC, with improvements.","fork":true,"url":"https://api.github.com/repos/JosJuice/dolphin","forks_url":"https://api.github.com/repos/JosJuice/dolphin/forks","keys_url":"https://api.github.com/repos/JosJuice/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JosJuice/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JosJuice/dolphin/teams","hooks_url":"https://api.github.com/repos/JosJuice/dolphin/hooks","issue_events_url":"https://api.github.com/repos/JosJuice/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/JosJuice/dolphin/events","assignees_url":"https://api.github.com/repos/JosJuice/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/JosJuice/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/JosJuice/dolphin/tags","blobs_url":"https://api.github.com/repos/JosJuice/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JosJuice/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JosJuice/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/JosJuice/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JosJuice/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/JosJuice/dolphin/languages","stargazers_url":"https://api.github.com/repos/JosJuice/dolphin/stargazers","contributors_url":"https://api.github.com/repos/JosJuice/dolphin/contributors","subscribers_url":"https://api.github.com/repos/JosJuice/dolphin/subscribers","subscription_url":"https://api.github.com/repos/JosJuice/dolphin/subscription","commits_url":"https://api.github.com/repos/JosJuice/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/JosJuice/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/JosJuice/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/JosJuice/dolphin/issues/comments{/number}","contents_url":"https://api.github.com/repos/JosJuice/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/JosJuice/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JosJuice/dolphin/merges","archive_url":"https://api.github.com/repos/JosJuice/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JosJuice/dolphin/downloads","issues_url":"https://api.github.com/repos/JosJuice/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/JosJuice/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/JosJuice/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/JosJuice/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JosJuice/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/JosJuice/dolphin/releases{/id}","created_at":"2014-11-01T17:12:40Z","updated_at":"2015-05-08T08:26:00Z","pushed_at":"2015-09-23T16:02:30Z","git_url":"git://github.com/JosJuice/dolphin.git","ssh_url":"git@github.com:JosJuice/dolphin.git","clone_url":"https://github.com/JosJuice/dolphin.git","svn_url":"https://github.com/JosJuice/dolphin","homepage":null,"size":226048,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"dolphin-emu:master","ref":"master","sha":"213d11dc6224bf254cc40028a57963ce06d5e88e","user":{"login":"dolphin-emu","id":5050316,"avatar_url":"https://avatars.githubusercontent.com/u/5050316?v=3","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"repo":{"id":11577304,"name":"dolphin","full_name":"dolphin-emu/dolphin","owner":{"login":"dolphin-emu","id":5050316,"avatar_url":"https://avatars.githubusercontent.com/u/5050316?v=3","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dolphin-emu/dolphin","description":"Dolphin is a GameCube / Wii emulator, allowing you to play games for these two platforms on PC with improvements.","fork":false,"url":"https://api.github.com/repos/dolphin-emu/dolphin","forks_url":"https://api.github.com/repos/dolphin-emu/dolphin/forks","keys_url":"https://api.github.com/repos/dolphin-emu/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dolphin-emu/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dolphin-emu/dolphin/teams","hooks_url":"https://api.github.com/repos/dolphin-emu/dolphin/hooks","issue_events_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/dolphin-emu/dolphin/events","assignees_url":"https://api.github.com/repos/dolphin-emu/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/dolphin-emu/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/tags","blobs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/dolphin-emu/dolphin/languages","stargazers_url":"https://api.github.com/repos/dolphin-emu/dolphin/stargazers","contributors_url":"https://api.github.com/repos/dolphin-emu/dolphin/contributors","subscribers_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscribers","subscription_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscription","commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/comments{/number}","contents_url":"https://api.github.com/repos/dolphin-emu/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/dolphin-emu/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dolphin-emu/dolphin/merges","archive_url":"https://api.github.com/repos/dolphin-emu/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dolphin-emu/dolphin/downloads","issues_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/dolphin-emu/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/dolphin-emu/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dolphin-emu/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/dolphin-emu/dolphin/releases{/id}","created_at":"2013-07-22T09:07:57Z","updated_at":"2015-09-22T10:59:46Z","pushed_at":"2015-09-23T16:02:42Z","git_url":"git://github.com/dolphin-emu/dolphin.git","ssh_url":"git@github.com:dolphin-emu/dolphin.git","clone_url":"https://github.com/dolphin-emu/dolphin.git","svn_url":"https://github.com/dolphin-emu/dolphin","homepage":"https://dolphin-emu.org/","size":310532,"stargazers_count":1656,"watchers_count":1656,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":523,"mirror_url":null,"open_issues_count":84,"forks":523,"open_issues":84,"watchers":1656,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3083"},"html":{"href":"https://github.com/dolphin-emu/dolphin/pull/3083"},"issue":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3083"},"comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3083/comments"},"review_comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3083/comments"},"review_comment":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3083/commits"},"statuses":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/3fdae38e26c339c21de784f3155316b033060b3b"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":121,"deletions":123,"changed_files":16}}