{"action":"created","issue":{"url":"https://api.github.com/repos/SFML/SFML/issues/827","labels_url":"https://api.github.com/repos/SFML/SFML/issues/827/labels{/name}","comments_url":"https://api.github.com/repos/SFML/SFML/issues/827/comments","events_url":"https://api.github.com/repos/SFML/SFML/issues/827/events","html_url":"https://github.com/SFML/SFML/pull/827","id":61757325,"number":827,"title":"Added methods to set the cursor type/image","user":{"login":"binary1248","id":949359,"avatar_url":"https://avatars.githubusercontent.com/u/949359?v=3","gravatar_id":"","url":"https://api.github.com/users/binary1248","html_url":"https://github.com/binary1248","followers_url":"https://api.github.com/users/binary1248/followers","following_url":"https://api.github.com/users/binary1248/following{/other_user}","gists_url":"https://api.github.com/users/binary1248/gists{/gist_id}","starred_url":"https://api.github.com/users/binary1248/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/binary1248/subscriptions","organizations_url":"https://api.github.com/users/binary1248/orgs","repos_url":"https://api.github.com/users/binary1248/repos","events_url":"https://api.github.com/users/binary1248/events{/privacy}","received_events_url":"https://api.github.com/users/binary1248/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/SFML/SFML/labels/feature","name":"feature","color":"23BA35"},{"url":"https://api.github.com/repos/SFML/SFML/labels/m:sfml-window","name":"m:sfml-window","color":"cccccc"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/SFML/SFML/milestones/10","html_url":"https://github.com/SFML/SFML/milestones/2.4","labels_url":"https://api.github.com/repos/SFML/SFML/milestones/10/labels","id":1043773,"number":10,"title":"2.4","description":"","creator":{"login":"eXpl0it3r","id":920861,"avatar_url":"https://avatars.githubusercontent.com/u/920861?v=3","gravatar_id":"","url":"https://api.github.com/users/eXpl0it3r","html_url":"https://github.com/eXpl0it3r","followers_url":"https://api.github.com/users/eXpl0it3r/followers","following_url":"https://api.github.com/users/eXpl0it3r/following{/other_user}","gists_url":"https://api.github.com/users/eXpl0it3r/gists{/gist_id}","starred_url":"https://api.github.com/users/eXpl0it3r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eXpl0it3r/subscriptions","organizations_url":"https://api.github.com/users/eXpl0it3r/orgs","repos_url":"https://api.github.com/users/eXpl0it3r/repos","events_url":"https://api.github.com/users/eXpl0it3r/events{/privacy}","received_events_url":"https://api.github.com/users/eXpl0it3r/received_events","type":"User","site_admin":false},"open_issues":29,"closed_issues":6,"state":"open","created_at":"2015-03-29T21:47:10Z","updated_at":"2015-09-20T21:15:34Z","due_on":null,"closed_at":null},"comments":38,"created_at":"2015-03-15T05:52:10Z","updated_at":"2015-09-21T08:49:51Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/SFML/SFML/pulls/827","html_url":"https://github.com/SFML/SFML/pull/827","diff_url":"https://github.com/SFML/SFML/pull/827.diff","patch_url":"https://github.com/SFML/SFML/pull/827.patch"},"body":"Supersedes #784.\r\n\r\nThanks to @fundies for the initial draft implementation. I originally wanted to attribute the commit to him, but there were simply too many changes in the end.\r\n\r\nResource leaks should be gone now, and general code style is fixed up. Like #784, this is still missing the OS X implementation. Hopefully @mantognini or someone else can fill in the gaps [here](https://github.com/LaurentGomila/SFML/blob/e9123604924436e762351472c821309557e73fd0/src/SFML/Window/OSX/WindowImplCocoa.mm#L548) and [here](https://github.com/LaurentGomila/SFML/blob/e9123604924436e762351472c821309557e73fd0/src/SFML/Window/OSX/WindowImplCocoa.mm#L555). It can't be nearly as horrible as the Windows or Unix implementations. :stuck_out_tongue: [This](http://en.sfml-dev.org/forums/index.php?topic=8313.msg57036#msg57036) might help a bit.\r\n\r\nThis implements #269."},"comment":{"url":"https://api.github.com/repos/SFML/SFML/issues/comments/141913445","html_url":"https://github.com/SFML/SFML/pull/827#issuecomment-141913445","issue_url":"https://api.github.com/repos/SFML/SFML/issues/827","id":141913445,"user":{"login":"MarioLiebisch","id":1854245,"avatar_url":"https://avatars.githubusercontent.com/u/1854245?v=3","gravatar_id":"","url":"https://api.github.com/users/MarioLiebisch","html_url":"https://github.com/MarioLiebisch","followers_url":"https://api.github.com/users/MarioLiebisch/followers","following_url":"https://api.github.com/users/MarioLiebisch/following{/other_user}","gists_url":"https://api.github.com/users/MarioLiebisch/gists{/gist_id}","starred_url":"https://api.github.com/users/MarioLiebisch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarioLiebisch/subscriptions","organizations_url":"https://api.github.com/users/MarioLiebisch/orgs","repos_url":"https://api.github.com/users/MarioLiebisch/repos","events_url":"https://api.github.com/users/MarioLiebisch/events{/privacy}","received_events_url":"https://api.github.com/users/MarioLiebisch/received_events","type":"User","site_admin":false},"created_at":"2015-09-21T08:49:51Z","updated_at":"2015-09-21T08:49:51Z","body":"> If we don't have fire-and-forget semantics, users would have to keep their own container of default cursors -- which would however be more efficient.\r\n\r\nHow about having a hidden `std::map<sf::Cursor>` inside the window, which is only used to cache cursors, if the method with the `enum` param is used? This way we can essentially have the best from both worlds.\r\n\r\nAs for members, going to come up with something simple. I also don't think we need image manipulation directly inside this class."}}