{"action":"created","issue":{"url":"https://api.github.com/repos/bitcoin/bitcoin/issues/5405","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/5405/labels{/name}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/5405/comments","events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/5405/events","html_url":"https://github.com/bitcoin/bitcoin/issues/5405","id":50661736,"number":5405,"title":"Usage of CheckProofOfWork for block generation","user":{"login":"21E14","id":8286077,"avatar_url":"https://avatars.githubusercontent.com/u/8286077?v=3","gravatar_id":"","url":"https://api.github.com/users/21E14","html_url":"https://github.com/21E14","followers_url":"https://api.github.com/users/21E14/followers","following_url":"https://api.github.com/users/21E14/following{/other_user}","gists_url":"https://api.github.com/users/21E14/gists{/gist_id}","starred_url":"https://api.github.com/users/21E14/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/21E14/subscriptions","organizations_url":"https://api.github.com/users/21E14/orgs","repos_url":"https://api.github.com/users/21E14/repos","events_url":"https://api.github.com/users/21E14/events{/privacy}","received_events_url":"https://api.github.com/users/21E14/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/bitcoin/bitcoin/labels/Priority%20Low","name":"Priority Low","color":"ededed"},{"url":"https://api.github.com/repos/bitcoin/bitcoin/labels/Tests","name":"Tests","color":"d4c5f9"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2014-12-02T15:00:18Z","updated_at":"2015-02-02T01:12:37Z","closed_at":null,"body":"The recent (expansion of) usage of CheckProofOfWork (pow.cpp +78) for block generation (#5275, rpcmining.cpp +181) needs an adjustment to its error output/conditions. As it stands now, every occurrence of a nonce that results in an insufficient hash is LogPrint-ed: as \"CheckProofOfWork() : hash doesn't match nBits\", a valuable insight when validating proof of work, but not so much when generating it."},"comment":{"url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments/72395289","html_url":"https://github.com/bitcoin/bitcoin/issues/5405#issuecomment-72395289","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/5405","id":72395289,"user":{"login":"21E14","id":8286077,"avatar_url":"https://avatars.githubusercontent.com/u/8286077?v=3","gravatar_id":"","url":"https://api.github.com/users/21E14","html_url":"https://github.com/21E14","followers_url":"https://api.github.com/users/21E14/followers","following_url":"https://api.github.com/users/21E14/following{/other_user}","gists_url":"https://api.github.com/users/21E14/gists{/gist_id}","starred_url":"https://api.github.com/users/21E14/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/21E14/subscriptions","organizations_url":"https://api.github.com/users/21E14/orgs","repos_url":"https://api.github.com/users/21E14/repos","events_url":"https://api.github.com/users/21E14/events{/privacy}","received_events_url":"https://api.github.com/users/21E14/received_events","type":"User","site_admin":false},"created_at":"2015-02-02T01:12:37Z","updated_at":"2015-02-02T01:12:37Z","body":"Update: #4793 reduces the (error) probability, but not to 0."}}