{"action":"created","issue":{"url":"https://api.github.com/repos/wine-compholio/wine-staging/issues/72","labels_url":"https://api.github.com/repos/wine-compholio/wine-staging/issues/72/labels{/name}","comments_url":"https://api.github.com/repos/wine-compholio/wine-staging/issues/72/comments","events_url":"https://api.github.com/repos/wine-compholio/wine-staging/issues/72/events","html_url":"https://github.com/wine-compholio/wine-staging/issues/72","id":41883697,"number":72,"title":"quartz-MediaSeeking_Positions: Add tests to confirm that weird position calculations are correct.","user":{"login":"slackner","id":5781160,"avatar_url":"https://avatars.githubusercontent.com/u/5781160?v=3","gravatar_id":"","url":"https://api.github.com/users/slackner","html_url":"https://github.com/slackner","followers_url":"https://api.github.com/users/slackner/followers","following_url":"https://api.github.com/users/slackner/following{/other_user}","gists_url":"https://api.github.com/users/slackner/gists{/gist_id}","starred_url":"https://api.github.com/users/slackner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slackner/subscriptions","organizations_url":"https://api.github.com/users/slackner/orgs","repos_url":"https://api.github.com/users/slackner/repos","events_url":"https://api.github.com/users/slackner/events{/privacy}","received_events_url":"https://api.github.com/users/slackner/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/wine-compholio/wine-staging/labels/enhancement","name":"enhancement","color":"fef2c0"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2014-09-04T00:39:48Z","updated_at":"2015-09-01T02:35:07Z","closed_at":"2015-09-01T02:35:07Z","body":"This is no issue in the patch itself, but when looking at the weird code of MediaSeeking in `dlls/quartz/filtergraph.c`, I am pretty sure that some things must be wrong.\r\n\r\nOne example is the code for MediaSeeking_GetCurrentPosition, which was moved to MediaSeeking_GetPositions in patch 1:\r\n\r\n```\r\n    EnterCriticalSection(&This->cs);\r\n    if (This->state == State_Running && This->refClock && This->start_time >= 0)\r\n    {\r\n        IReferenceClock_GetTime(This->refClock, &time);\r\n        if (time)\r\n            time -= This->start_time;\r\n    }\r\n    if (This->pause_time > 0)\r\n        time += This->pause_time;\r\n    *pCurrent = time;\r\n    LeaveCriticalSection(&This->cs);\r\n```\r\n\r\nAt a different location in the source the pause_time is initialized with a full (absolute) timestamp, so `*pCurrent` will be some high random garbage value instead of the time since beginning of the media playback.\r\n\r\nIf I remember correctly @DarkPlayer even had a game that was stuck in an endless seeking loop, which was not resolved yet our patchset - could probably be related to the issue above, when the app tries to verify that seeking worked correctly."},"comment":{"url":"https://api.github.com/repos/wine-compholio/wine-staging/issues/comments/136557003","html_url":"https://github.com/wine-compholio/wine-staging/issues/72#issuecomment-136557003","issue_url":"https://api.github.com/repos/wine-compholio/wine-staging/issues/72","id":136557003,"user":{"login":"slackner","id":5781160,"avatar_url":"https://avatars.githubusercontent.com/u/5781160?v=3","gravatar_id":"","url":"https://api.github.com/users/slackner","html_url":"https://github.com/slackner","followers_url":"https://api.github.com/users/slackner/followers","following_url":"https://api.github.com/users/slackner/following{/other_user}","gists_url":"https://api.github.com/users/slackner/gists{/gist_id}","starred_url":"https://api.github.com/users/slackner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slackner/subscriptions","organizations_url":"https://api.github.com/users/slackner/orgs","repos_url":"https://api.github.com/users/slackner/repos","events_url":"https://api.github.com/users/slackner/events{/privacy}","received_events_url":"https://api.github.com/users/slackner/received_events","type":"User","site_admin":false},"created_at":"2015-09-01T02:35:07Z","updated_at":"2015-09-01T02:35:07Z","body":"Closing."}}