{"action":"created","comment":{"url":"https://api.github.com/repos/fog/fog-aliyun/pulls/comments/43636300","id":43636300,"diff_hunk":"@@ -4,82 +4,83 @@ module Fog\n   module Compute\n     class Aliyun\n       class SecurityGroup < Fog::Model\n-        # {\"SecurityGroup\"=>[{\"CreationTime\"=>\"2015-08-10T03:21:02Z\", \n-        #   \"SecurityGroupId\"=>\"sg-25mexinlu\", \"Description\"=>\"\", \"SecurityGroupName\"=>\"bosh\", \n-        #   \"VpcId\"=>\"vpc-25mj6mguq\"}}\n-\n-        identity  :id,                    :aliases =>\"SecurityGroupId\"\n-\n-        attribute :name,                  :aliases => \"SecurityGroupName\"\n-        attribute :description,           :aliases => \"Description\"\n-        attribute :created_at,            :aliases => \"CreationTime\"\n-        attribute :vpc_id,                :aliases => \"VpcId\"\n+        identity  :id,           :aliases =>\"SecurityGroupId\"\n+        attribute :name,         :aliases => \"SecurityGroupName\"\n+        attribute :description,  :aliases => \"Description\"\n+        attribute :created_at,   :aliases => \"CreationTime\"\n+        attribute :vpc_id,       :aliases => \"VpcId\"\n \n         def vpc\n-            requires :vpc_id\n-            $vpc=Fog::Compute::Aliyun::Vpcs.new(:service=>service).all('vpcId'=>vpc_id)[0]\n+          requires :vpc_id\n+          $vpc=Fog::Compute::Aliyun::Vpcs.new(:service=>service).all('vpcId'=>vpc_id)[0]","path":"lib/fog/aliyun/models/compute/security_group.rb","position":24,"original_position":24,"commit_id":"e83417c67a9e05cb9d73c0ad5d2559f5f924d8ca","original_commit_id":"e83417c67a9e05cb9d73c0ad5d2559f5f924d8ca","user":{"login":"plribeiro3000","id":672952,"avatar_url":"https://avatars.githubusercontent.com/u/672952?v=3","gravatar_id":"","url":"https://api.github.com/users/plribeiro3000","html_url":"https://github.com/plribeiro3000","followers_url":"https://api.github.com/users/plribeiro3000/followers","following_url":"https://api.github.com/users/plribeiro3000/following{/other_user}","gists_url":"https://api.github.com/users/plribeiro3000/gists{/gist_id}","starred_url":"https://api.github.com/users/plribeiro3000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plribeiro3000/subscriptions","organizations_url":"https://api.github.com/users/plribeiro3000/orgs","repos_url":"https://api.github.com/users/plribeiro3000/repos","events_url":"https://api.github.com/users/plribeiro3000/events{/privacy}","received_events_url":"https://api.github.com/users/plribeiro3000/received_events","type":"User","site_admin":false},"body":"Why are you defining a global variable here?\r\nDo you want to memoize the response? If so use `@vpc ||=` instead of `$vpc`.","created_at":"2015-11-02T15:00:44Z","updated_at":"2015-11-02T15:00:44Z","html_url":"https://github.com/fog/fog-aliyun/pull/6#discussion_r43636300","pull_request_url":"https://api.github.com/repos/fog/fog-aliyun/pulls/6","_links":{"self":{"href":"https://api.github.com/repos/fog/fog-aliyun/pulls/comments/43636300"},"html":{"href":"https://github.com/fog/fog-aliyun/pull/6#discussion_r43636300"},"pull_request":{"href":"https://api.github.com/repos/fog/fog-aliyun/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/fog/fog-aliyun/pulls/6","id":49392926,"html_url":"https://github.com/fog/fog-aliyun/pull/6","diff_url":"https://github.com/fog/fog-aliyun/pull/6.diff","patch_url":"https://github.com/fog/fog-aliyun/pull/6.patch","issue_url":"https://api.github.com/repos/fog/fog-aliyun/issues/6","number":6,"state":"open","locked":false,"title":"Done with squashing","user":{"login":"janehyt","id":9441908,"avatar_url":"https://avatars.githubusercontent.com/u/9441908?v=3","gravatar_id":"","url":"https://api.github.com/users/janehyt","html_url":"https://github.com/janehyt","followers_url":"https://api.github.com/users/janehyt/followers","following_url":"https://api.github.com/users/janehyt/following{/other_user}","gists_url":"https://api.github.com/users/janehyt/gists{/gist_id}","starred_url":"https://api.github.com/users/janehyt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janehyt/subscriptions","organizations_url":"https://api.github.com/users/janehyt/orgs","repos_url":"https://api.github.com/users/janehyt/repos","events_url":"https://api.github.com/users/janehyt/events{/privacy}","received_events_url":"https://api.github.com/users/janehyt/received_events","type":"User","site_admin":false},"body":"1. add some methods which related to authorize_security_group and revoke_security_group\r\n\r\n2. complete security_group_rule model\r\n\r\nSomething fogot to push last time..related ti security group egress rule.","created_at":"2015-11-02T03:57:16Z","updated_at":"2015-11-02T15:00:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5bf51b61e3620837d8d90ef9d11dd8daddd2bafb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/fog/fog-aliyun/pulls/6/commits","review_comments_url":"https://api.github.com/repos/fog/fog-aliyun/pulls/6/comments","review_comment_url":"https://api.github.com/repos/fog/fog-aliyun/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fog/fog-aliyun/issues/6/comments","statuses_url":"https://api.github.com/repos/fog/fog-aliyun/statuses/e83417c67a9e05cb9d73c0ad5d2559f5f924d8ca","head":{"label":"janehyt:develop","ref":"develop","sha":"e83417c67a9e05cb9d73c0ad5d2559f5f924d8ca","user":{"login":"janehyt","id":9441908,"avatar_url":"https://avatars.githubusercontent.com/u/9441908?v=3","gravatar_id":"","url":"https://api.github.com/users/janehyt","html_url":"https://github.com/janehyt","followers_url":"https://api.github.com/users/janehyt/followers","following_url":"https://api.github.com/users/janehyt/following{/other_user}","gists_url":"https://api.github.com/users/janehyt/gists{/gist_id}","starred_url":"https://api.github.com/users/janehyt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janehyt/subscriptions","organizations_url":"https://api.github.com/users/janehyt/orgs","repos_url":"https://api.github.com/users/janehyt/repos","events_url":"https://api.github.com/users/janehyt/events{/privacy}","received_events_url":"https://api.github.com/users/janehyt/received_events","type":"User","site_admin":false},"repo":{"id":44798906,"name":"fog-aliyun","full_name":"janehyt/fog-aliyun","owner":{"login":"janehyt","id":9441908,"avatar_url":"https://avatars.githubusercontent.com/u/9441908?v=3","gravatar_id":"","url":"https://api.github.com/users/janehyt","html_url":"https://github.com/janehyt","followers_url":"https://api.github.com/users/janehyt/followers","following_url":"https://api.github.com/users/janehyt/following{/other_user}","gists_url":"https://api.github.com/users/janehyt/gists{/gist_id}","starred_url":"https://api.github.com/users/janehyt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janehyt/subscriptions","organizations_url":"https://api.github.com/users/janehyt/orgs","repos_url":"https://api.github.com/users/janehyt/repos","events_url":"https://api.github.com/users/janehyt/events{/privacy}","received_events_url":"https://api.github.com/users/janehyt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/janehyt/fog-aliyun","description":"Fog provider for aliyun","fork":true,"url":"https://api.github.com/repos/janehyt/fog-aliyun","forks_url":"https://api.github.com/repos/janehyt/fog-aliyun/forks","keys_url":"https://api.github.com/repos/janehyt/fog-aliyun/keys{/key_id}","collaborators_url":"https://api.github.com/repos/janehyt/fog-aliyun/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/janehyt/fog-aliyun/teams","hooks_url":"https://api.github.com/repos/janehyt/fog-aliyun/hooks","issue_events_url":"https://api.github.com/repos/janehyt/fog-aliyun/issues/events{/number}","events_url":"https://api.github.com/repos/janehyt/fog-aliyun/events","assignees_url":"https://api.github.com/repos/janehyt/fog-aliyun/assignees{/user}","branches_url":"https://api.github.com/repos/janehyt/fog-aliyun/branches{/branch}","tags_url":"https://api.github.com/repos/janehyt/fog-aliyun/tags","blobs_url":"https://api.github.com/repos/janehyt/fog-aliyun/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/janehyt/fog-aliyun/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/janehyt/fog-aliyun/git/refs{/sha}","trees_url":"https://api.github.com/repos/janehyt/fog-aliyun/git/trees{/sha}","statuses_url":"https://api.github.com/repos/janehyt/fog-aliyun/statuses/{sha}","languages_url":"https://api.github.com/repos/janehyt/fog-aliyun/languages","stargazers_url":"https://api.github.com/repos/janehyt/fog-aliyun/stargazers","contributors_url":"https://api.github.com/repos/janehyt/fog-aliyun/contributors","subscribers_url":"https://api.github.com/repos/janehyt/fog-aliyun/subscribers","subscription_url":"https://api.github.com/repos/janehyt/fog-aliyun/subscription","commits_url":"https://api.github.com/repos/janehyt/fog-aliyun/commits{/sha}","git_commits_url":"https://api.github.com/repos/janehyt/fog-aliyun/git/commits{/sha}","comments_url":"https://api.github.com/repos/janehyt/fog-aliyun/comments{/number}","issue_comment_url":"https://api.github.com/repos/janehyt/fog-aliyun/issues/comments{/number}","contents_url":"https://api.github.com/repos/janehyt/fog-aliyun/contents/{+path}","compare_url":"https://api.github.com/repos/janehyt/fog-aliyun/compare/{base}...{head}","merges_url":"https://api.github.com/repos/janehyt/fog-aliyun/merges","archive_url":"https://api.github.com/repos/janehyt/fog-aliyun/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/janehyt/fog-aliyun/downloads","issues_url":"https://api.github.com/repos/janehyt/fog-aliyun/issues{/number}","pulls_url":"https://api.github.com/repos/janehyt/fog-aliyun/pulls{/number}","milestones_url":"https://api.github.com/repos/janehyt/fog-aliyun/milestones{/number}","notifications_url":"https://api.github.com/repos/janehyt/fog-aliyun/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/janehyt/fog-aliyun/labels{/name}","releases_url":"https://api.github.com/repos/janehyt/fog-aliyun/releases{/id}","created_at":"2015-10-23T07:54:10Z","updated_at":"2015-10-23T07:54:11Z","pushed_at":"2015-11-02T03:56:07Z","git_url":"git://github.com/janehyt/fog-aliyun.git","ssh_url":"git@github.com:janehyt/fog-aliyun.git","clone_url":"https://github.com/janehyt/fog-aliyun.git","svn_url":"https://github.com/janehyt/fog-aliyun","homepage":null,"size":214,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fog:master","ref":"master","sha":"9e73e3cdb9c00c953ffb7a2d033e4865b12757a2","user":{"login":"fog","id":991149,"avatar_url":"https://avatars.githubusercontent.com/u/991149?v=3","gravatar_id":"","url":"https://api.github.com/users/fog","html_url":"https://github.com/fog","followers_url":"https://api.github.com/users/fog/followers","following_url":"https://api.github.com/users/fog/following{/other_user}","gists_url":"https://api.github.com/users/fog/gists{/gist_id}","starred_url":"https://api.github.com/users/fog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fog/subscriptions","organizations_url":"https://api.github.com/users/fog/orgs","repos_url":"https://api.github.com/users/fog/repos","events_url":"https://api.github.com/users/fog/events{/privacy}","received_events_url":"https://api.github.com/users/fog/received_events","type":"Organization","site_admin":false},"repo":{"id":42915009,"name":"fog-aliyun","full_name":"fog/fog-aliyun","owner":{"login":"fog","id":991149,"avatar_url":"https://avatars.githubusercontent.com/u/991149?v=3","gravatar_id":"","url":"https://api.github.com/users/fog","html_url":"https://github.com/fog","followers_url":"https://api.github.com/users/fog/followers","following_url":"https://api.github.com/users/fog/following{/other_user}","gists_url":"https://api.github.com/users/fog/gists{/gist_id}","starred_url":"https://api.github.com/users/fog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fog/subscriptions","organizations_url":"https://api.github.com/users/fog/orgs","repos_url":"https://api.github.com/users/fog/repos","events_url":"https://api.github.com/users/fog/events{/privacy}","received_events_url":"https://api.github.com/users/fog/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fog/fog-aliyun","description":"Fog provider for aliyun","fork":false,"url":"https://api.github.com/repos/fog/fog-aliyun","forks_url":"https://api.github.com/repos/fog/fog-aliyun/forks","keys_url":"https://api.github.com/repos/fog/fog-aliyun/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fog/fog-aliyun/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fog/fog-aliyun/teams","hooks_url":"https://api.github.com/repos/fog/fog-aliyun/hooks","issue_events_url":"https://api.github.com/repos/fog/fog-aliyun/issues/events{/number}","events_url":"https://api.github.com/repos/fog/fog-aliyun/events","assignees_url":"https://api.github.com/repos/fog/fog-aliyun/assignees{/user}","branches_url":"https://api.github.com/repos/fog/fog-aliyun/branches{/branch}","tags_url":"https://api.github.com/repos/fog/fog-aliyun/tags","blobs_url":"https://api.github.com/repos/fog/fog-aliyun/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fog/fog-aliyun/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fog/fog-aliyun/git/refs{/sha}","trees_url":"https://api.github.com/repos/fog/fog-aliyun/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fog/fog-aliyun/statuses/{sha}","languages_url":"https://api.github.com/repos/fog/fog-aliyun/languages","stargazers_url":"https://api.github.com/repos/fog/fog-aliyun/stargazers","contributors_url":"https://api.github.com/repos/fog/fog-aliyun/contributors","subscribers_url":"https://api.github.com/repos/fog/fog-aliyun/subscribers","subscription_url":"https://api.github.com/repos/fog/fog-aliyun/subscription","commits_url":"https://api.github.com/repos/fog/fog-aliyun/commits{/sha}","git_commits_url":"https://api.github.com/repos/fog/fog-aliyun/git/commits{/sha}","comments_url":"https://api.github.com/repos/fog/fog-aliyun/comments{/number}","issue_comment_url":"https://api.github.com/repos/fog/fog-aliyun/issues/comments{/number}","contents_url":"https://api.github.com/repos/fog/fog-aliyun/contents/{+path}","compare_url":"https://api.github.com/repos/fog/fog-aliyun/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fog/fog-aliyun/merges","archive_url":"https://api.github.com/repos/fog/fog-aliyun/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fog/fog-aliyun/downloads","issues_url":"https://api.github.com/repos/fog/fog-aliyun/issues{/number}","pulls_url":"https://api.github.com/repos/fog/fog-aliyun/pulls{/number}","milestones_url":"https://api.github.com/repos/fog/fog-aliyun/milestones{/number}","notifications_url":"https://api.github.com/repos/fog/fog-aliyun/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fog/fog-aliyun/labels{/name}","releases_url":"https://api.github.com/repos/fog/fog-aliyun/releases{/id}","created_at":"2015-09-22T06:12:35Z","updated_at":"2015-10-15T07:08:02Z","pushed_at":"2015-11-02T03:57:16Z","git_url":"git://github.com/fog/fog-aliyun.git","ssh_url":"git@github.com:fog/fog-aliyun.git","clone_url":"https://github.com/fog/fog-aliyun.git","svn_url":"https://github.com/fog/fog-aliyun","homepage":null,"size":398,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fog/fog-aliyun/pulls/6"},"html":{"href":"https://github.com/fog/fog-aliyun/pull/6"},"issue":{"href":"https://api.github.com/repos/fog/fog-aliyun/issues/6"},"comments":{"href":"https://api.github.com/repos/fog/fog-aliyun/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/fog/fog-aliyun/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/fog/fog-aliyun/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fog/fog-aliyun/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/fog/fog-aliyun/statuses/e83417c67a9e05cb9d73c0ad5d2559f5f924d8ca"}}}}