{"action":"created","comment":{"url":"https://api.github.com/repos/aspnet/Security/pulls/comments/27661621","id":27661621,"diff_hunk":"@@ -178,33 +234,61 @@ protected override void ApplyResponseChallenge()\n \n             if (Options.ProtocolValidator.RequireNonce)\n             {\n-                openIdConnectMessage.Nonce = Options.ProtocolValidator.GenerateNonce();\n+                message.Nonce = Options.ProtocolValidator.GenerateNonce();\n                 if (Options.NonceCache != null)\n                 {\n-                    Options.NonceCache.AddNonce(openIdConnectMessage.Nonce);\n+                    if (!Options.NonceCache.TryAddNonce(message.Nonce))\n+                    {\n+                        string msg = string.Format(CultureInfo.CurrentCulture, Resources.OIDCH_0033_TryAddNonceFailed, message.Nonce);\n+                        if (logLevelError)","path":"src/Microsoft.AspNet.Authentication.OpenIdConnect/OpenidConnectAuthenticationHandler.cs","position":155,"original_position":155,"commit_id":"4ea3ebe53e189cdf0488b916e9f1250dc5cba545","original_commit_id":"4ea3ebe53e189cdf0488b916e9f1250dc5cba545","user":{"login":"brentschmaltz","id":3172421,"avatar_url":"https://avatars.githubusercontent.com/u/3172421?v=3","gravatar_id":"","url":"https://api.github.com/users/brentschmaltz","html_url":"https://github.com/brentschmaltz","followers_url":"https://api.github.com/users/brentschmaltz/followers","following_url":"https://api.github.com/users/brentschmaltz/following{/other_user}","gists_url":"https://api.github.com/users/brentschmaltz/gists{/gist_id}","starred_url":"https://api.github.com/users/brentschmaltz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brentschmaltz/subscriptions","organizations_url":"https://api.github.com/users/brentschmaltz/orgs","repos_url":"https://api.github.com/users/brentschmaltz/repos","events_url":"https://api.github.com/users/brentschmaltz/events{/privacy}","received_events_url":"https://api.github.com/users/brentschmaltz/received_events","type":"User","site_admin":false},"body":"We are going to throw anyway so any perf here is small, but I like to be consistent.","created_at":"2015-04-02T14:28:34Z","updated_at":"2015-04-02T14:28:34Z","html_url":"https://github.com/aspnet/Security/pull/202#discussion_r27661621","pull_request_url":"https://api.github.com/repos/aspnet/Security/pulls/202","_links":{"self":{"href":"https://api.github.com/repos/aspnet/Security/pulls/comments/27661621"},"html":{"href":"https://github.com/aspnet/Security/pull/202#discussion_r27661621"},"pull_request":{"href":"https://api.github.com/repos/aspnet/Security/pulls/202"}}},"pull_request":{"url":"https://api.github.com/repos/aspnet/Security/pulls/202","id":32345317,"html_url":"https://github.com/aspnet/Security/pull/202","diff_url":"https://github.com/aspnet/Security/pull/202.diff","patch_url":"https://github.com/aspnet/Security/pull/202.patch","issue_url":"https://api.github.com/repos/aspnet/Security/issues/202","number":202,"state":"open","locked":false,"title":"logging, added tests, fixed code only flow.","user":{"login":"brentschmaltz","id":3172421,"avatar_url":"https://avatars.githubusercontent.com/u/3172421?v=3","gravatar_id":"","url":"https://api.github.com/users/brentschmaltz","html_url":"https://github.com/brentschmaltz","followers_url":"https://api.github.com/users/brentschmaltz/followers","following_url":"https://api.github.com/users/brentschmaltz/following{/other_user}","gists_url":"https://api.github.com/users/brentschmaltz/gists{/gist_id}","starred_url":"https://api.github.com/users/brentschmaltz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brentschmaltz/subscriptions","organizations_url":"https://api.github.com/users/brentschmaltz/orgs","repos_url":"https://api.github.com/users/brentschmaltz/repos","events_url":"https://api.github.com/users/brentschmaltz/events{/privacy}","received_events_url":"https://api.github.com/users/brentschmaltz/received_events","type":"User","site_admin":false},"body":"still lots of additional testing to come.","created_at":"2015-03-31T17:26:28Z","updated_at":"2015-04-02T14:28:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b5696195e92032d8ac9f13458f37e77201dabf4b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/aspnet/Security/pulls/202/commits","review_comments_url":"https://api.github.com/repos/aspnet/Security/pulls/202/comments","review_comment_url":"https://api.github.com/repos/aspnet/Security/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aspnet/Security/issues/202/comments","statuses_url":"https://api.github.com/repos/aspnet/Security/statuses/4ea3ebe53e189cdf0488b916e9f1250dc5cba545","head":{"label":"brentschmaltz:dev","ref":"dev","sha":"4ea3ebe53e189cdf0488b916e9f1250dc5cba545","user":{"login":"brentschmaltz","id":3172421,"avatar_url":"https://avatars.githubusercontent.com/u/3172421?v=3","gravatar_id":"","url":"https://api.github.com/users/brentschmaltz","html_url":"https://github.com/brentschmaltz","followers_url":"https://api.github.com/users/brentschmaltz/followers","following_url":"https://api.github.com/users/brentschmaltz/following{/other_user}","gists_url":"https://api.github.com/users/brentschmaltz/gists{/gist_id}","starred_url":"https://api.github.com/users/brentschmaltz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brentschmaltz/subscriptions","organizations_url":"https://api.github.com/users/brentschmaltz/orgs","repos_url":"https://api.github.com/users/brentschmaltz/repos","events_url":"https://api.github.com/users/brentschmaltz/events{/privacy}","received_events_url":"https://api.github.com/users/brentschmaltz/received_events","type":"User","site_admin":false},"repo":{"id":28565810,"name":"Security","full_name":"brentschmaltz/Security","owner":{"login":"brentschmaltz","id":3172421,"avatar_url":"https://avatars.githubusercontent.com/u/3172421?v=3","gravatar_id":"","url":"https://api.github.com/users/brentschmaltz","html_url":"https://github.com/brentschmaltz","followers_url":"https://api.github.com/users/brentschmaltz/followers","following_url":"https://api.github.com/users/brentschmaltz/following{/other_user}","gists_url":"https://api.github.com/users/brentschmaltz/gists{/gist_id}","starred_url":"https://api.github.com/users/brentschmaltz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brentschmaltz/subscriptions","organizations_url":"https://api.github.com/users/brentschmaltz/orgs","repos_url":"https://api.github.com/users/brentschmaltz/repos","events_url":"https://api.github.com/users/brentschmaltz/events{/privacy}","received_events_url":"https://api.github.com/users/brentschmaltz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brentschmaltz/Security","description":"Middleware for security and authorization of web apps.","fork":true,"url":"https://api.github.com/repos/brentschmaltz/Security","forks_url":"https://api.github.com/repos/brentschmaltz/Security/forks","keys_url":"https://api.github.com/repos/brentschmaltz/Security/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brentschmaltz/Security/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brentschmaltz/Security/teams","hooks_url":"https://api.github.com/repos/brentschmaltz/Security/hooks","issue_events_url":"https://api.github.com/repos/brentschmaltz/Security/issues/events{/number}","events_url":"https://api.github.com/repos/brentschmaltz/Security/events","assignees_url":"https://api.github.com/repos/brentschmaltz/Security/assignees{/user}","branches_url":"https://api.github.com/repos/brentschmaltz/Security/branches{/branch}","tags_url":"https://api.github.com/repos/brentschmaltz/Security/tags","blobs_url":"https://api.github.com/repos/brentschmaltz/Security/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brentschmaltz/Security/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brentschmaltz/Security/git/refs{/sha}","trees_url":"https://api.github.com/repos/brentschmaltz/Security/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brentschmaltz/Security/statuses/{sha}","languages_url":"https://api.github.com/repos/brentschmaltz/Security/languages","stargazers_url":"https://api.github.com/repos/brentschmaltz/Security/stargazers","contributors_url":"https://api.github.com/repos/brentschmaltz/Security/contributors","subscribers_url":"https://api.github.com/repos/brentschmaltz/Security/subscribers","subscription_url":"https://api.github.com/repos/brentschmaltz/Security/subscription","commits_url":"https://api.github.com/repos/brentschmaltz/Security/commits{/sha}","git_commits_url":"https://api.github.com/repos/brentschmaltz/Security/git/commits{/sha}","comments_url":"https://api.github.com/repos/brentschmaltz/Security/comments{/number}","issue_comment_url":"https://api.github.com/repos/brentschmaltz/Security/issues/comments{/number}","contents_url":"https://api.github.com/repos/brentschmaltz/Security/contents/{+path}","compare_url":"https://api.github.com/repos/brentschmaltz/Security/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brentschmaltz/Security/merges","archive_url":"https://api.github.com/repos/brentschmaltz/Security/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brentschmaltz/Security/downloads","issues_url":"https://api.github.com/repos/brentschmaltz/Security/issues{/number}","pulls_url":"https://api.github.com/repos/brentschmaltz/Security/pulls{/number}","milestones_url":"https://api.github.com/repos/brentschmaltz/Security/milestones{/number}","notifications_url":"https://api.github.com/repos/brentschmaltz/Security/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brentschmaltz/Security/labels{/name}","releases_url":"https://api.github.com/repos/brentschmaltz/Security/releases{/id}","created_at":"2014-12-28T16:09:45Z","updated_at":"2015-03-31T17:23:49Z","pushed_at":"2015-03-31T17:23:49Z","git_url":"git://github.com/brentschmaltz/Security.git","ssh_url":"git@github.com:brentschmaltz/Security.git","clone_url":"https://github.com/brentschmaltz/Security.git","svn_url":"https://github.com/brentschmaltz/Security","homepage":"","size":1096,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"aspnet:dev","ref":"dev","sha":"0037618b56f743762f7e30747eeee21046bd4612","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":17723699,"name":"Security","full_name":"aspnet/Security","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/Security","description":"Middleware for security and authorization of web apps.","fork":false,"url":"https://api.github.com/repos/aspnet/Security","forks_url":"https://api.github.com/repos/aspnet/Security/forks","keys_url":"https://api.github.com/repos/aspnet/Security/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/Security/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/Security/teams","hooks_url":"https://api.github.com/repos/aspnet/Security/hooks","issue_events_url":"https://api.github.com/repos/aspnet/Security/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/Security/events","assignees_url":"https://api.github.com/repos/aspnet/Security/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/Security/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/Security/tags","blobs_url":"https://api.github.com/repos/aspnet/Security/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/Security/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/Security/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/Security/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/Security/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/Security/languages","stargazers_url":"https://api.github.com/repos/aspnet/Security/stargazers","contributors_url":"https://api.github.com/repos/aspnet/Security/contributors","subscribers_url":"https://api.github.com/repos/aspnet/Security/subscribers","subscription_url":"https://api.github.com/repos/aspnet/Security/subscription","commits_url":"https://api.github.com/repos/aspnet/Security/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/Security/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/Security/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/Security/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/Security/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/Security/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/Security/merges","archive_url":"https://api.github.com/repos/aspnet/Security/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/Security/downloads","issues_url":"https://api.github.com/repos/aspnet/Security/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/Security/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/Security/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/Security/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/Security/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/Security/releases{/id}","created_at":"2014-03-13T19:44:34Z","updated_at":"2015-04-02T00:55:24Z","pushed_at":"2015-04-02T00:35:50Z","git_url":"git://github.com/aspnet/Security.git","ssh_url":"git@github.com:aspnet/Security.git","clone_url":"https://github.com/aspnet/Security.git","svn_url":"https://github.com/aspnet/Security","homepage":"","size":3779,"stargazers_count":120,"watchers_count":120,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":46,"mirror_url":null,"open_issues_count":47,"forks":46,"open_issues":47,"watchers":120,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/aspnet/Security/pulls/202"},"html":{"href":"https://github.com/aspnet/Security/pull/202"},"issue":{"href":"https://api.github.com/repos/aspnet/Security/issues/202"},"comments":{"href":"https://api.github.com/repos/aspnet/Security/issues/202/comments"},"review_comments":{"href":"https://api.github.com/repos/aspnet/Security/pulls/202/comments"},"review_comment":{"href":"https://api.github.com/repos/aspnet/Security/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aspnet/Security/pulls/202/commits"},"statuses":{"href":"https://api.github.com/repos/aspnet/Security/statuses/4ea3ebe53e189cdf0488b916e9f1250dc5cba545"}}}}