{"action":"opened","number":272,"pull_request":{"url":"https://api.github.com/repos/lazojs/lazo/pulls/272","id":36884079,"html_url":"https://github.com/lazojs/lazo/pull/272","diff_url":"https://github.com/lazojs/lazo/pull/272.diff","patch_url":"https://github.com/lazojs/lazo/pull/272.patch","issue_url":"https://api.github.com/repos/lazojs/lazo/issues/272","number":272,"state":"open","locked":false,"title":"Refactor view.resolveChild","user":{"login":"adam-26","id":2652619,"avatar_url":"https://avatars.githubusercontent.com/u/2652619?v=3","gravatar_id":"","url":"https://api.github.com/users/adam-26","html_url":"https://github.com/adam-26","followers_url":"https://api.github.com/users/adam-26/followers","following_url":"https://api.github.com/users/adam-26/following{/other_user}","gists_url":"https://api.github.com/users/adam-26/gists{/gist_id}","starred_url":"https://api.github.com/users/adam-26/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adam-26/subscriptions","organizations_url":"https://api.github.com/users/adam-26/orgs","repos_url":"https://api.github.com/users/adam-26/repos","events_url":"https://api.github.com/users/adam-26/events{/privacy}","received_events_url":"https://api.github.com/users/adam-26/received_events","type":"User","site_admin":false},"body":"Firstly, this change allows parent views to override 'getChildren' when resolving a views child views.\r\nIt has been refactored so 'resolveChild' uses 'getChildren' to get the child views as opposed to accessing 'this.viewDefinitions' directly.\r\n\r\nSecondly (and you may not want to do this? But it's very easy to undo), when defining child views (which is undocumented) on a parent view, change to use 'views:{}' instead of 'viewDefinitions:{}'. I did this because it is inline with the widget naming conventions. To undo this, change the text on line 208 (https://github.com/lazojs/lazo/compare/v2...adam-26:v2-prChildViews?expand=1#diff-ba20ce2426b01f0538bb84f2e63d7fe1R208) from 'views', back to 'viewDefinitions'.\r\n","created_at":"2015-06-03T22:14:03Z","updated_at":"2015-06-03T22:14:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/lazojs/lazo/pulls/272/commits","review_comments_url":"https://api.github.com/repos/lazojs/lazo/pulls/272/comments","review_comment_url":"https://api.github.com/repos/lazojs/lazo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lazojs/lazo/issues/272/comments","statuses_url":"https://api.github.com/repos/lazojs/lazo/statuses/f27d2ca7be3516e9733534f0c4c7bb062cf1f70e","head":{"label":"adam-26:v2-prChildViews","ref":"v2-prChildViews","sha":"f27d2ca7be3516e9733534f0c4c7bb062cf1f70e","user":{"login":"adam-26","id":2652619,"avatar_url":"https://avatars.githubusercontent.com/u/2652619?v=3","gravatar_id":"","url":"https://api.github.com/users/adam-26","html_url":"https://github.com/adam-26","followers_url":"https://api.github.com/users/adam-26/followers","following_url":"https://api.github.com/users/adam-26/following{/other_user}","gists_url":"https://api.github.com/users/adam-26/gists{/gist_id}","starred_url":"https://api.github.com/users/adam-26/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adam-26/subscriptions","organizations_url":"https://api.github.com/users/adam-26/orgs","repos_url":"https://api.github.com/users/adam-26/repos","events_url":"https://api.github.com/users/adam-26/events{/privacy}","received_events_url":"https://api.github.com/users/adam-26/received_events","type":"User","site_admin":false},"repo":{"id":31203519,"name":"lazo","full_name":"adam-26/lazo","owner":{"login":"adam-26","id":2652619,"avatar_url":"https://avatars.githubusercontent.com/u/2652619?v=3","gravatar_id":"","url":"https://api.github.com/users/adam-26","html_url":"https://github.com/adam-26","followers_url":"https://api.github.com/users/adam-26/followers","following_url":"https://api.github.com/users/adam-26/following{/other_user}","gists_url":"https://api.github.com/users/adam-26/gists{/gist_id}","starred_url":"https://api.github.com/users/adam-26/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adam-26/subscriptions","organizations_url":"https://api.github.com/users/adam-26/orgs","repos_url":"https://api.github.com/users/adam-26/repos","events_url":"https://api.github.com/users/adam-26/events{/privacy}","received_events_url":"https://api.github.com/users/adam-26/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adam-26/lazo","description":"A client-server web framework built on Node.js that allows front-end developers to easily create a 100% SEO compliant, component MVC structured web application with an optimized first page load.","fork":true,"url":"https://api.github.com/repos/adam-26/lazo","forks_url":"https://api.github.com/repos/adam-26/lazo/forks","keys_url":"https://api.github.com/repos/adam-26/lazo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adam-26/lazo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adam-26/lazo/teams","hooks_url":"https://api.github.com/repos/adam-26/lazo/hooks","issue_events_url":"https://api.github.com/repos/adam-26/lazo/issues/events{/number}","events_url":"https://api.github.com/repos/adam-26/lazo/events","assignees_url":"https://api.github.com/repos/adam-26/lazo/assignees{/user}","branches_url":"https://api.github.com/repos/adam-26/lazo/branches{/branch}","tags_url":"https://api.github.com/repos/adam-26/lazo/tags","blobs_url":"https://api.github.com/repos/adam-26/lazo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adam-26/lazo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adam-26/lazo/git/refs{/sha}","trees_url":"https://api.github.com/repos/adam-26/lazo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adam-26/lazo/statuses/{sha}","languages_url":"https://api.github.com/repos/adam-26/lazo/languages","stargazers_url":"https://api.github.com/repos/adam-26/lazo/stargazers","contributors_url":"https://api.github.com/repos/adam-26/lazo/contributors","subscribers_url":"https://api.github.com/repos/adam-26/lazo/subscribers","subscription_url":"https://api.github.com/repos/adam-26/lazo/subscription","commits_url":"https://api.github.com/repos/adam-26/lazo/commits{/sha}","git_commits_url":"https://api.github.com/repos/adam-26/lazo/git/commits{/sha}","comments_url":"https://api.github.com/repos/adam-26/lazo/comments{/number}","issue_comment_url":"https://api.github.com/repos/adam-26/lazo/issues/comments{/number}","contents_url":"https://api.github.com/repos/adam-26/lazo/contents/{+path}","compare_url":"https://api.github.com/repos/adam-26/lazo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adam-26/lazo/merges","archive_url":"https://api.github.com/repos/adam-26/lazo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adam-26/lazo/downloads","issues_url":"https://api.github.com/repos/adam-26/lazo/issues{/number}","pulls_url":"https://api.github.com/repos/adam-26/lazo/pulls{/number}","milestones_url":"https://api.github.com/repos/adam-26/lazo/milestones{/number}","notifications_url":"https://api.github.com/repos/adam-26/lazo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adam-26/lazo/labels{/name}","releases_url":"https://api.github.com/repos/adam-26/lazo/releases{/id}","created_at":"2015-02-23T10:37:04Z","updated_at":"2015-02-23T10:37:04Z","pushed_at":"2015-06-03T22:05:52Z","git_url":"git://github.com/adam-26/lazo.git","ssh_url":"git@github.com:adam-26/lazo.git","clone_url":"https://github.com/adam-26/lazo.git","svn_url":"https://github.com/adam-26/lazo","homepage":"","size":3522,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"lazojs:v2","ref":"v2","sha":"ac7e9dfa866eeb21ccabc1826fd6bb4598dea1c2","user":{"login":"lazojs","id":10262672,"avatar_url":"https://avatars.githubusercontent.com/u/10262672?v=3","gravatar_id":"","url":"https://api.github.com/users/lazojs","html_url":"https://github.com/lazojs","followers_url":"https://api.github.com/users/lazojs/followers","following_url":"https://api.github.com/users/lazojs/following{/other_user}","gists_url":"https://api.github.com/users/lazojs/gists{/gist_id}","starred_url":"https://api.github.com/users/lazojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lazojs/subscriptions","organizations_url":"https://api.github.com/users/lazojs/orgs","repos_url":"https://api.github.com/users/lazojs/repos","events_url":"https://api.github.com/users/lazojs/events{/privacy}","received_events_url":"https://api.github.com/users/lazojs/received_events","type":"Organization","site_admin":false},"repo":{"id":12765913,"name":"lazo","full_name":"lazojs/lazo","owner":{"login":"lazojs","id":10262672,"avatar_url":"https://avatars.githubusercontent.com/u/10262672?v=3","gravatar_id":"","url":"https://api.github.com/users/lazojs","html_url":"https://github.com/lazojs","followers_url":"https://api.github.com/users/lazojs/followers","following_url":"https://api.github.com/users/lazojs/following{/other_user}","gists_url":"https://api.github.com/users/lazojs/gists{/gist_id}","starred_url":"https://api.github.com/users/lazojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lazojs/subscriptions","organizations_url":"https://api.github.com/users/lazojs/orgs","repos_url":"https://api.github.com/users/lazojs/repos","events_url":"https://api.github.com/users/lazojs/events{/privacy}","received_events_url":"https://api.github.com/users/lazojs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lazojs/lazo","description":"A client-server web framework built on Node.js that allows front-end developers to easily create a 100% SEO compliant, component MVC structured web application with an optimized first page load.","fork":false,"url":"https://api.github.com/repos/lazojs/lazo","forks_url":"https://api.github.com/repos/lazojs/lazo/forks","keys_url":"https://api.github.com/repos/lazojs/lazo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lazojs/lazo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lazojs/lazo/teams","hooks_url":"https://api.github.com/repos/lazojs/lazo/hooks","issue_events_url":"https://api.github.com/repos/lazojs/lazo/issues/events{/number}","events_url":"https://api.github.com/repos/lazojs/lazo/events","assignees_url":"https://api.github.com/repos/lazojs/lazo/assignees{/user}","branches_url":"https://api.github.com/repos/lazojs/lazo/branches{/branch}","tags_url":"https://api.github.com/repos/lazojs/lazo/tags","blobs_url":"https://api.github.com/repos/lazojs/lazo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lazojs/lazo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lazojs/lazo/git/refs{/sha}","trees_url":"https://api.github.com/repos/lazojs/lazo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lazojs/lazo/statuses/{sha}","languages_url":"https://api.github.com/repos/lazojs/lazo/languages","stargazers_url":"https://api.github.com/repos/lazojs/lazo/stargazers","contributors_url":"https://api.github.com/repos/lazojs/lazo/contributors","subscribers_url":"https://api.github.com/repos/lazojs/lazo/subscribers","subscription_url":"https://api.github.com/repos/lazojs/lazo/subscription","commits_url":"https://api.github.com/repos/lazojs/lazo/commits{/sha}","git_commits_url":"https://api.github.com/repos/lazojs/lazo/git/commits{/sha}","comments_url":"https://api.github.com/repos/lazojs/lazo/comments{/number}","issue_comment_url":"https://api.github.com/repos/lazojs/lazo/issues/comments{/number}","contents_url":"https://api.github.com/repos/lazojs/lazo/contents/{+path}","compare_url":"https://api.github.com/repos/lazojs/lazo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lazojs/lazo/merges","archive_url":"https://api.github.com/repos/lazojs/lazo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lazojs/lazo/downloads","issues_url":"https://api.github.com/repos/lazojs/lazo/issues{/number}","pulls_url":"https://api.github.com/repos/lazojs/lazo/pulls{/number}","milestones_url":"https://api.github.com/repos/lazojs/lazo/milestones{/number}","notifications_url":"https://api.github.com/repos/lazojs/lazo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lazojs/lazo/labels{/name}","releases_url":"https://api.github.com/repos/lazojs/lazo/releases{/id}","created_at":"2013-09-11T19:47:14Z","updated_at":"2015-05-27T10:36:45Z","pushed_at":"2015-06-01T23:10:46Z","git_url":"git://github.com/lazojs/lazo.git","ssh_url":"git@github.com:lazojs/lazo.git","clone_url":"https://github.com/lazojs/lazo.git","svn_url":"https://github.com/lazojs/lazo","homepage":"","size":5813,"stargazers_count":255,"watchers_count":255,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":34,"mirror_url":null,"open_issues_count":53,"forks":34,"open_issues":53,"watchers":255,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lazojs/lazo/pulls/272"},"html":{"href":"https://github.com/lazojs/lazo/pull/272"},"issue":{"href":"https://api.github.com/repos/lazojs/lazo/issues/272"},"comments":{"href":"https://api.github.com/repos/lazojs/lazo/issues/272/comments"},"review_comments":{"href":"https://api.github.com/repos/lazojs/lazo/pulls/272/comments"},"review_comment":{"href":"https://api.github.com/repos/lazojs/lazo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lazojs/lazo/pulls/272/commits"},"statuses":{"href":"https://api.github.com/repos/lazojs/lazo/statuses/f27d2ca7be3516e9733534f0c4c7bb062cf1f70e"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":24,"deletions":15,"changed_files":1}}