{"action":"closed","number":247,"pull_request":{"url":"https://api.github.com/repos/jbalsas/liferay-portal/pulls/247","id":49448964,"html_url":"https://github.com/jbalsas/liferay-portal/pull/247","diff_url":"https://github.com/jbalsas/liferay-portal/pull/247.diff","patch_url":"https://github.com/jbalsas/liferay-portal/pull/247.patch","issue_url":"https://api.github.com/repos/jbalsas/liferay-portal/issues/247","number":247,"state":"closed","locked":false,"title":"LPS-59249 - Form-groups shouldn't be nested within each other, remove uneeded form styles","user":{"login":"pat270","id":788266,"avatar_url":"https://avatars.githubusercontent.com/u/788266?v=3","gravatar_id":"","url":"https://api.github.com/users/pat270","html_url":"https://github.com/pat270","followers_url":"https://api.github.com/users/pat270/followers","following_url":"https://api.github.com/users/pat270/following{/other_user}","gists_url":"https://api.github.com/users/pat270/gists{/gist_id}","starred_url":"https://api.github.com/users/pat270/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pat270/subscriptions","organizations_url":"https://api.github.com/users/pat270/orgs","repos_url":"https://api.github.com/users/pat270/repos","events_url":"https://api.github.com/users/pat270/events{/privacy}","received_events_url":"https://api.github.com/users/pat270/received_events","type":"User","site_admin":false},"body":"https://github.com/liferay/liferay-portal/pull/806\r\n\r\nHey @jbalsas, It makes sense that we should add form-control to inputs inside a form element. The problem with editors is that they are more than just an input. Alloy Editor was written in such a way that it inherits the input style, other editors aren't designed that way e.g. ckeditor. I think we should only add form-control for alloy editor. See example below.\r\n\r\nform-control class with height: auto with ckeditor:\r\n\r\nCkeditor with Admin Theme based on Classic (doesn't look too bad)\r\n![alloy-editor](https://cloud.githubusercontent.com/assets/788266/10886526/3dc08ffa-8137-11e5-8f12-a9bbcec07269.png)\r\n\r\nCkeditor with Admin Theme based on Styled (looks pretty bad)\r\n![ckeditor](https://cloud.githubusercontent.com/assets/788266/10886534/48bab688-8137-11e5-87b1-1cecde8357bb.png)\r\n","created_at":"2015-11-02T16:00:28Z","updated_at":"2015-11-02T16:51:44Z","closed_at":"2015-11-02T16:51:44Z","merged_at":null,"merge_commit_sha":"37c4b4567414ea6ddf59e43f574bcc391999f336","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jbalsas/liferay-portal/pulls/247/commits","review_comments_url":"https://api.github.com/repos/jbalsas/liferay-portal/pulls/247/comments","review_comment_url":"https://api.github.com/repos/jbalsas/liferay-portal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jbalsas/liferay-portal/issues/247/comments","statuses_url":"https://api.github.com/repos/jbalsas/liferay-portal/statuses/0734a011bf06ea40c1cac01f7e90a7f9314fe5db","head":{"label":"pat270:LPS-59249","ref":"LPS-59249","sha":"0734a011bf06ea40c1cac01f7e90a7f9314fe5db","user":{"login":"pat270","id":788266,"avatar_url":"https://avatars.githubusercontent.com/u/788266?v=3","gravatar_id":"","url":"https://api.github.com/users/pat270","html_url":"https://github.com/pat270","followers_url":"https://api.github.com/users/pat270/followers","following_url":"https://api.github.com/users/pat270/following{/other_user}","gists_url":"https://api.github.com/users/pat270/gists{/gist_id}","starred_url":"https://api.github.com/users/pat270/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pat270/subscriptions","organizations_url":"https://api.github.com/users/pat270/orgs","repos_url":"https://api.github.com/users/pat270/repos","events_url":"https://api.github.com/users/pat270/events{/privacy}","received_events_url":"https://api.github.com/users/pat270/received_events","type":"User","site_admin":false},"repo":{"id":8297187,"name":"liferay-portal","full_name":"pat270/liferay-portal","owner":{"login":"pat270","id":788266,"avatar_url":"https://avatars.githubusercontent.com/u/788266?v=3","gravatar_id":"","url":"https://api.github.com/users/pat270","html_url":"https://github.com/pat270","followers_url":"https://api.github.com/users/pat270/followers","following_url":"https://api.github.com/users/pat270/following{/other_user}","gists_url":"https://api.github.com/users/pat270/gists{/gist_id}","starred_url":"https://api.github.com/users/pat270/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pat270/subscriptions","organizations_url":"https://api.github.com/users/pat270/orgs","repos_url":"https://api.github.com/users/pat270/repos","events_url":"https://api.github.com/users/pat270/events{/privacy}","received_events_url":"https://api.github.com/users/pat270/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pat270/liferay-portal","description":"","fork":true,"url":"https://api.github.com/repos/pat270/liferay-portal","forks_url":"https://api.github.com/repos/pat270/liferay-portal/forks","keys_url":"https://api.github.com/repos/pat270/liferay-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pat270/liferay-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pat270/liferay-portal/teams","hooks_url":"https://api.github.com/repos/pat270/liferay-portal/hooks","issue_events_url":"https://api.github.com/repos/pat270/liferay-portal/issues/events{/number}","events_url":"https://api.github.com/repos/pat270/liferay-portal/events","assignees_url":"https://api.github.com/repos/pat270/liferay-portal/assignees{/user}","branches_url":"https://api.github.com/repos/pat270/liferay-portal/branches{/branch}","tags_url":"https://api.github.com/repos/pat270/liferay-portal/tags","blobs_url":"https://api.github.com/repos/pat270/liferay-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pat270/liferay-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pat270/liferay-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/pat270/liferay-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pat270/liferay-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/pat270/liferay-portal/languages","stargazers_url":"https://api.github.com/repos/pat270/liferay-portal/stargazers","contributors_url":"https://api.github.com/repos/pat270/liferay-portal/contributors","subscribers_url":"https://api.github.com/repos/pat270/liferay-portal/subscribers","subscription_url":"https://api.github.com/repos/pat270/liferay-portal/subscription","commits_url":"https://api.github.com/repos/pat270/liferay-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/pat270/liferay-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/pat270/liferay-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/pat270/liferay-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/pat270/liferay-portal/contents/{+path}","compare_url":"https://api.github.com/repos/pat270/liferay-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pat270/liferay-portal/merges","archive_url":"https://api.github.com/repos/pat270/liferay-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pat270/liferay-portal/downloads","issues_url":"https://api.github.com/repos/pat270/liferay-portal/issues{/number}","pulls_url":"https://api.github.com/repos/pat270/liferay-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/pat270/liferay-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/pat270/liferay-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pat270/liferay-portal/labels{/name}","releases_url":"https://api.github.com/repos/pat270/liferay-portal/releases{/id}","created_at":"2013-02-19T19:08:25Z","updated_at":"2015-03-23T15:40:25Z","pushed_at":"2015-10-30T23:22:12Z","git_url":"git://github.com/pat270/liferay-portal.git","ssh_url":"git@github.com:pat270/liferay-portal.git","clone_url":"https://github.com/pat270/liferay-portal.git","svn_url":"https://github.com/pat270/liferay-portal","homepage":"http://liferay.com","size":5197408,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"jbalsas:master","ref":"master","sha":"ef91c4afac8160eebd094ca494e6672bc384c139","user":{"login":"jbalsas","id":905006,"avatar_url":"https://avatars.githubusercontent.com/u/905006?v=3","gravatar_id":"","url":"https://api.github.com/users/jbalsas","html_url":"https://github.com/jbalsas","followers_url":"https://api.github.com/users/jbalsas/followers","following_url":"https://api.github.com/users/jbalsas/following{/other_user}","gists_url":"https://api.github.com/users/jbalsas/gists{/gist_id}","starred_url":"https://api.github.com/users/jbalsas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbalsas/subscriptions","organizations_url":"https://api.github.com/users/jbalsas/orgs","repos_url":"https://api.github.com/users/jbalsas/repos","events_url":"https://api.github.com/users/jbalsas/events{/privacy}","received_events_url":"https://api.github.com/users/jbalsas/received_events","type":"User","site_admin":false},"repo":{"id":8551488,"name":"liferay-portal","full_name":"jbalsas/liferay-portal","owner":{"login":"jbalsas","id":905006,"avatar_url":"https://avatars.githubusercontent.com/u/905006?v=3","gravatar_id":"","url":"https://api.github.com/users/jbalsas","html_url":"https://github.com/jbalsas","followers_url":"https://api.github.com/users/jbalsas/followers","following_url":"https://api.github.com/users/jbalsas/following{/other_user}","gists_url":"https://api.github.com/users/jbalsas/gists{/gist_id}","starred_url":"https://api.github.com/users/jbalsas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbalsas/subscriptions","organizations_url":"https://api.github.com/users/jbalsas/orgs","repos_url":"https://api.github.com/users/jbalsas/repos","events_url":"https://api.github.com/users/jbalsas/events{/privacy}","received_events_url":"https://api.github.com/users/jbalsas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jbalsas/liferay-portal","description":"","fork":true,"url":"https://api.github.com/repos/jbalsas/liferay-portal","forks_url":"https://api.github.com/repos/jbalsas/liferay-portal/forks","keys_url":"https://api.github.com/repos/jbalsas/liferay-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jbalsas/liferay-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jbalsas/liferay-portal/teams","hooks_url":"https://api.github.com/repos/jbalsas/liferay-portal/hooks","issue_events_url":"https://api.github.com/repos/jbalsas/liferay-portal/issues/events{/number}","events_url":"https://api.github.com/repos/jbalsas/liferay-portal/events","assignees_url":"https://api.github.com/repos/jbalsas/liferay-portal/assignees{/user}","branches_url":"https://api.github.com/repos/jbalsas/liferay-portal/branches{/branch}","tags_url":"https://api.github.com/repos/jbalsas/liferay-portal/tags","blobs_url":"https://api.github.com/repos/jbalsas/liferay-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jbalsas/liferay-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jbalsas/liferay-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/jbalsas/liferay-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jbalsas/liferay-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/jbalsas/liferay-portal/languages","stargazers_url":"https://api.github.com/repos/jbalsas/liferay-portal/stargazers","contributors_url":"https://api.github.com/repos/jbalsas/liferay-portal/contributors","subscribers_url":"https://api.github.com/repos/jbalsas/liferay-portal/subscribers","subscription_url":"https://api.github.com/repos/jbalsas/liferay-portal/subscription","commits_url":"https://api.github.com/repos/jbalsas/liferay-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/jbalsas/liferay-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/jbalsas/liferay-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/jbalsas/liferay-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/jbalsas/liferay-portal/contents/{+path}","compare_url":"https://api.github.com/repos/jbalsas/liferay-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jbalsas/liferay-portal/merges","archive_url":"https://api.github.com/repos/jbalsas/liferay-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jbalsas/liferay-portal/downloads","issues_url":"https://api.github.com/repos/jbalsas/liferay-portal/issues{/number}","pulls_url":"https://api.github.com/repos/jbalsas/liferay-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/jbalsas/liferay-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/jbalsas/liferay-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jbalsas/liferay-portal/labels{/name}","releases_url":"https://api.github.com/repos/jbalsas/liferay-portal/releases{/id}","created_at":"2013-03-04T08:41:57Z","updated_at":"2015-05-08T06:17:23Z","pushed_at":"2015-11-02T16:00:29Z","git_url":"git://github.com/jbalsas/liferay-portal.git","ssh_url":"git@github.com:jbalsas/liferay-portal.git","clone_url":"https://github.com/jbalsas/liferay-portal.git","svn_url":"https://github.com/jbalsas/liferay-portal","homepage":"http://liferay.com","size":5191441,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jbalsas/liferay-portal/pulls/247"},"html":{"href":"https://github.com/jbalsas/liferay-portal/pull/247"},"issue":{"href":"https://api.github.com/repos/jbalsas/liferay-portal/issues/247"},"comments":{"href":"https://api.github.com/repos/jbalsas/liferay-portal/issues/247/comments"},"review_comments":{"href":"https://api.github.com/repos/jbalsas/liferay-portal/pulls/247/comments"},"review_comment":{"href":"https://api.github.com/repos/jbalsas/liferay-portal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jbalsas/liferay-portal/pulls/247/commits"},"statuses":{"href":"https://api.github.com/repos/jbalsas/liferay-portal/statuses/0734a011bf06ea40c1cac01f7e90a7f9314fe5db"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"commits":3,"additions":194,"deletions":230,"changed_files":25}}