{"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/25908123","id":25908123,"diff_hunk":"@@ -1,4 +1,12 @@\n-- if @settings[:quadicons][@layout == 'ems_infra' ? :ems : :ems_cloud]\n+- db = case @layout\n+- when \"ems_infra\"\n+  - :ems\n+- when \"ems_cloud\"\n+  - :ems_cloud\n+- else\n+  - :ems_container","path":"vmdb/app/views/layouts/quadicon/_ext_management_system.html.haml","position":8,"original_position":8,"commit_id":"ee90a32796f02d28fe30bdf0077b8029e8e531d8","original_commit_id":"ee90a32796f02d28fe30bdf0077b8029e8e531d8","user":{"login":"h-kataria","id":3450808,"avatar_url":"https://avatars.githubusercontent.com/u/3450808?v=3","gravatar_id":"","url":"https://api.github.com/users/h-kataria","html_url":"https://github.com/h-kataria","followers_url":"https://api.github.com/users/h-kataria/followers","following_url":"https://api.github.com/users/h-kataria/following{/other_user}","gists_url":"https://api.github.com/users/h-kataria/gists{/gist_id}","starred_url":"https://api.github.com/users/h-kataria/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h-kataria/subscriptions","organizations_url":"https://api.github.com/users/h-kataria/orgs","repos_url":"https://api.github.com/users/h-kataria/repos","events_url":"https://api.github.com/users/h-kataria/events{/privacy}","received_events_url":"https://api.github.com/users/h-kataria/received_events","type":"User","site_admin":false},"body":"@fryguy in HAML don't need end","created_at":"2015-03-05T22:25:53Z","updated_at":"2015-03-05T22:25:53Z","html_url":"https://github.com/ManageIQ/manageiq/pull/2025#discussion_r25908123","pull_request_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/2025","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/25908123"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/2025#discussion_r25908123"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/2025"}}},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/2025","id":30601351,"html_url":"https://github.com/ManageIQ/manageiq/pull/2025","diff_url":"https://github.com/ManageIQ/manageiq/pull/2025.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/2025.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/2025","number":2025,"state":"open","locked":false,"title":"Containers main-tab and sub-tabs UI skeleton.","user":{"login":"h-kataria","id":3450808,"avatar_url":"https://avatars.githubusercontent.com/u/3450808?v=3","gravatar_id":"","url":"https://api.github.com/users/h-kataria","html_url":"https://github.com/h-kataria","followers_url":"https://api.github.com/users/h-kataria/followers","following_url":"https://api.github.com/users/h-kataria/following{/other_user}","gists_url":"https://api.github.com/users/h-kataria/gists{/gist_id}","starred_url":"https://api.github.com/users/h-kataria/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h-kataria/subscriptions","organizations_url":"https://api.github.com/users/h-kataria/orgs","repos_url":"https://api.github.com/users/h-kataria/repos","events_url":"https://api.github.com/users/h-kataria/events{/privacy}","received_events_url":"https://api.github.com/users/h-kataria/received_events","type":"User","site_admin":false},"body":"- Basic screens skeleton for Containers main tab with 5 sub tabs(Providers, Nodes, Services, Container Groups, Containers) under that.\r\n- All the sub tabs have functional GTL view buttons\r\n- Download txt/csv/pdf buttons are available on all new list views.\r\n- All the CIs have basic toolbar buttons as well as functional advanced search is available for all 5 CIs.\r\n- There are settings in My Settings area to set default view type for each of these new CIs.\r\n- Containers Explorer has 2 basic accordions - 1: \"Relationships\" with a root node and containers under that 2: \"All Containers\" that display filters for Containers. For now one dummy filter has been added to populate the tree. Just like the other tabs list views, objects can be shown in grid, tile, or list views. Toolbar buttons can be customized based upon selection in tree. Standard History and Refresh buttons are available in Containers explorer.\r\n\r\nIssue #1806\r\n\r\n@dclarizio please review/test.\r\n\r\n@abonas @erinboyd please review, feel free to ping me if you have questions/issues. Some notes with location of files that can be changed to enhance these screens:\r\n- New toolbars can be added in product/toolbars. There is a method in app/helpers/application_helpers.rb that loads an appropriate toolbar for each screen.\r\n- New buttons and button groups can be added in existing toolbars, button id should match with a feature id in db/fixtures/miq_product_features.yml\r\n- OOTB roles and the features allowed to these roles are defined in db/fixtures/miq_user_roles.yml\r\n- All the trees in explorers are being built using TreeBuilder class in app/presnters (i.e. tree_builder_container.rb for Containers tree)\r\n- List views are generated from a YAML report that's located in product/views. That has all the columns to be displayed, and their corresponding headers.\r\n- Summary screens have Accordions/links on the left to various record related data, that is being rendered from app/views/layouts/listnav.\r\n- Summary screens are built using helpers, these files located in app/helpers\r\n- List views have OOTB search filters that can be defined in db/fixtures/miq_searches.yml\r\n- I have copied placeholder images for now in public/images/icons/new until appropriate images are ready for each new CI\r\n- app/helpers/application_helper.rb has methods that check RBAC access for each button and disables/hides/shows the buttons in toolbars based upon that.","created_at":"2015-03-05T22:15:36Z","updated_at":"2015-03-05T22:25:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"457d7bca9dc582047f9967c8c07b1982749bc10e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/2025/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/2025/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/2025/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/ee90a32796f02d28fe30bdf0077b8029e8e531d8","head":{"label":"h-kataria:containers_ui","ref":"containers_ui","sha":"ee90a32796f02d28fe30bdf0077b8029e8e531d8","user":{"login":"h-kataria","id":3450808,"avatar_url":"https://avatars.githubusercontent.com/u/3450808?v=3","gravatar_id":"","url":"https://api.github.com/users/h-kataria","html_url":"https://github.com/h-kataria","followers_url":"https://api.github.com/users/h-kataria/followers","following_url":"https://api.github.com/users/h-kataria/following{/other_user}","gists_url":"https://api.github.com/users/h-kataria/gists{/gist_id}","starred_url":"https://api.github.com/users/h-kataria/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h-kataria/subscriptions","organizations_url":"https://api.github.com/users/h-kataria/orgs","repos_url":"https://api.github.com/users/h-kataria/repos","events_url":"https://api.github.com/users/h-kataria/events{/privacy}","received_events_url":"https://api.github.com/users/h-kataria/received_events","type":"User","site_admin":false},"repo":{"id":20811753,"name":"manageiq","full_name":"h-kataria/manageiq","owner":{"login":"h-kataria","id":3450808,"avatar_url":"https://avatars.githubusercontent.com/u/3450808?v=3","gravatar_id":"","url":"https://api.github.com/users/h-kataria","html_url":"https://github.com/h-kataria","followers_url":"https://api.github.com/users/h-kataria/followers","following_url":"https://api.github.com/users/h-kataria/following{/other_user}","gists_url":"https://api.github.com/users/h-kataria/gists{/gist_id}","starred_url":"https://api.github.com/users/h-kataria/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h-kataria/subscriptions","organizations_url":"https://api.github.com/users/h-kataria/orgs","repos_url":"https://api.github.com/users/h-kataria/repos","events_url":"https://api.github.com/users/h-kataria/events{/privacy}","received_events_url":"https://api.github.com/users/h-kataria/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/h-kataria/manageiq","description":"ManageIQ Cloud Management Platform","fork":true,"url":"https://api.github.com/repos/h-kataria/manageiq","forks_url":"https://api.github.com/repos/h-kataria/manageiq/forks","keys_url":"https://api.github.com/repos/h-kataria/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/h-kataria/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/h-kataria/manageiq/teams","hooks_url":"https://api.github.com/repos/h-kataria/manageiq/hooks","issue_events_url":"https://api.github.com/repos/h-kataria/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/h-kataria/manageiq/events","assignees_url":"https://api.github.com/repos/h-kataria/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/h-kataria/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/h-kataria/manageiq/tags","blobs_url":"https://api.github.com/repos/h-kataria/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/h-kataria/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/h-kataria/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/h-kataria/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/h-kataria/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/h-kataria/manageiq/languages","stargazers_url":"https://api.github.com/repos/h-kataria/manageiq/stargazers","contributors_url":"https://api.github.com/repos/h-kataria/manageiq/contributors","subscribers_url":"https://api.github.com/repos/h-kataria/manageiq/subscribers","subscription_url":"https://api.github.com/repos/h-kataria/manageiq/subscription","commits_url":"https://api.github.com/repos/h-kataria/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/h-kataria/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/h-kataria/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/h-kataria/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/h-kataria/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/h-kataria/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/h-kataria/manageiq/merges","archive_url":"https://api.github.com/repos/h-kataria/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/h-kataria/manageiq/downloads","issues_url":"https://api.github.com/repos/h-kataria/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/h-kataria/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/h-kataria/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/h-kataria/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/h-kataria/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/h-kataria/manageiq/releases{/id}","created_at":"2014-06-13T17:15:09Z","updated_at":"2014-06-24T23:08:03Z","pushed_at":"2015-03-05T22:02:44Z","git_url":"git://github.com/h-kataria/manageiq.git","ssh_url":"git@github.com:h-kataria/manageiq.git","clone_url":"https://github.com/h-kataria/manageiq.git","svn_url":"https://github.com/h-kataria/manageiq","homepage":null,"size":65412,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"2ada52ba9b7412e23f707bb59c367aa9c8d6a8ae","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":20789757,"name":"manageiq","full_name":"ManageIQ/manageiq","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq","description":"ManageIQ Cloud Management Platform","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq","forks_url":"https://api.github.com/repos/ManageIQ/manageiq/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq/releases{/id}","created_at":"2014-06-13T02:31:26Z","updated_at":"2015-03-05T22:11:13Z","pushed_at":"2015-03-05T22:11:13Z","git_url":"git://github.com/ManageIQ/manageiq.git","ssh_url":"git@github.com:ManageIQ/manageiq.git","clone_url":"https://github.com/ManageIQ/manageiq.git","svn_url":"https://github.com/ManageIQ/manageiq","homepage":"manageiq.org","size":105167,"stargazers_count":94,"watchers_count":94,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":92,"mirror_url":null,"open_issues_count":295,"forks":92,"open_issues":295,"watchers":94,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/2025"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/2025"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/2025"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/2025/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/2025/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/2025/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq/statuses/ee90a32796f02d28fe30bdf0077b8029e8e531d8"}}}}