{"action":"created","comment":{"url":"https://api.github.com/repos/randoop/randoop/pulls/comments/45419450","id":45419450,"diff_hunk":"@@ -5,17 +5,27 @@\n import java.util.List;\n import java.util.Set;\n \n+import randoop.operation.MethodCall;\n+import randoop.sequence.ExecutableSequence;\n+import randoop.sequence.MutableSequence;\n+import randoop.sequence.MutableVariable;\n+import randoop.sequence.Statement;\n+import randoop.sequence.Variable;\n+\n public class FailureSet {\n   \n   private Set<Failure> failures = new LinkedHashSet<Failure>();\n   \n   public static class Failure {\n-    public final StatementKind st;\n+    \n+    public final Statement st;\n     public final Class<?> viocls;\n-    public Failure(StatementKind st, Class<?> viocls) {\n-      this.st = st;\n+    \n+    public Failure(Statement st2, Class<?> viocls) {","path":"src/randoop/FailureSet.java","position":23,"original_position":23,"commit_id":"8b17b3abb0c70f90a031c3688ede8daf8834c202","original_commit_id":"8b17b3abb0c70f90a031c3688ede8daf8834c202","user":{"login":"mernst","id":121025,"avatar_url":"https://avatars.githubusercontent.com/u/121025?v=3","gravatar_id":"","url":"https://api.github.com/users/mernst","html_url":"https://github.com/mernst","followers_url":"https://api.github.com/users/mernst/followers","following_url":"https://api.github.com/users/mernst/following{/other_user}","gists_url":"https://api.github.com/users/mernst/gists{/gist_id}","starred_url":"https://api.github.com/users/mernst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mernst/subscriptions","organizations_url":"https://api.github.com/users/mernst/orgs","repos_url":"https://api.github.com/users/mernst/repos","events_url":"https://api.github.com/users/mernst/events{/privacy}","received_events_url":"https://api.github.com/users/mernst/received_events","type":"User","site_admin":false},"body":"Please don't make this change.  It's much clearer to use the same variable name for the constructor formal parameter and the field name (and doing so is standard practice).","created_at":"2015-11-19T23:57:55Z","updated_at":"2015-11-19T23:57:55Z","html_url":"https://github.com/randoop/randoop/pull/62#discussion_r45419450","pull_request_url":"https://api.github.com/repos/randoop/randoop/pulls/62","_links":{"self":{"href":"https://api.github.com/repos/randoop/randoop/pulls/comments/45419450"},"html":{"href":"https://github.com/randoop/randoop/pull/62#discussion_r45419450"},"pull_request":{"href":"https://api.github.com/repos/randoop/randoop/pulls/62"}}},"pull_request":{"url":"https://api.github.com/repos/randoop/randoop/pulls/62","id":51297345,"html_url":"https://github.com/randoop/randoop/pull/62","diff_url":"https://github.com/randoop/randoop/pull/62.diff","patch_url":"https://github.com/randoop/randoop/pull/62.patch","issue_url":"https://api.github.com/repos/randoop/randoop/issues/62","number":62,"state":"open","locked":false,"title":"refactor","user":{"login":"bjkeller","id":5479869,"avatar_url":"https://avatars.githubusercontent.com/u/5479869?v=3","gravatar_id":"","url":"https://api.github.com/users/bjkeller","html_url":"https://github.com/bjkeller","followers_url":"https://api.github.com/users/bjkeller/followers","following_url":"https://api.github.com/users/bjkeller/following{/other_user}","gists_url":"https://api.github.com/users/bjkeller/gists{/gist_id}","starred_url":"https://api.github.com/users/bjkeller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjkeller/subscriptions","organizations_url":"https://api.github.com/users/bjkeller/orgs","repos_url":"https://api.github.com/users/bjkeller/repos","events_url":"https://api.github.com/users/bjkeller/events{/privacy}","received_events_url":"https://api.github.com/users/bjkeller/received_events","type":"User","site_admin":false},"body":"This is a refactoring branch consisting of essentially four kinds of changes:\r\n1. class name changes\r\n2. organization changes\r\n3. refactoring of Statement to reduce dependencies from usage of Operation (formerly StatementKind) hierarchy in Sequence-related code. \r\n4. partitioning of Reflection based on function (outlined in last commit). What remains is just type information and I expect will go away as I deal with generics. The major part of this set of changes is the introduction of ReflectionManager, which can be used to standardize how classes and class members are visited prior to test generation.\r\n\r\nChanges in the last two do affect behavior in terms of generated tests. The third allowing faux getter/setter objects to be treated as methods. And, the fourth affecting the order in which the Operation objects for class members are presented for testing.","created_at":"2015-11-19T23:27:42Z","updated_at":"2015-11-19T23:57:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"edb62265823cab3d44416bd4ad0614f7e08a9858","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/randoop/randoop/pulls/62/commits","review_comments_url":"https://api.github.com/repos/randoop/randoop/pulls/62/comments","review_comment_url":"https://api.github.com/repos/randoop/randoop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/randoop/randoop/issues/62/comments","statuses_url":"https://api.github.com/repos/randoop/randoop/statuses/8b17b3abb0c70f90a031c3688ede8daf8834c202","head":{"label":"randoop:statement-refactor","ref":"statement-refactor","sha":"8b17b3abb0c70f90a031c3688ede8daf8834c202","user":{"login":"randoop","id":15037885,"avatar_url":"https://avatars.githubusercontent.com/u/15037885?v=3","gravatar_id":"","url":"https://api.github.com/users/randoop","html_url":"https://github.com/randoop","followers_url":"https://api.github.com/users/randoop/followers","following_url":"https://api.github.com/users/randoop/following{/other_user}","gists_url":"https://api.github.com/users/randoop/gists{/gist_id}","starred_url":"https://api.github.com/users/randoop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/randoop/subscriptions","organizations_url":"https://api.github.com/users/randoop/orgs","repos_url":"https://api.github.com/users/randoop/repos","events_url":"https://api.github.com/users/randoop/events{/privacy}","received_events_url":"https://api.github.com/users/randoop/received_events","type":"Organization","site_admin":false},"repo":{"id":34923107,"name":"randoop","full_name":"randoop/randoop","owner":{"login":"randoop","id":15037885,"avatar_url":"https://avatars.githubusercontent.com/u/15037885?v=3","gravatar_id":"","url":"https://api.github.com/users/randoop","html_url":"https://github.com/randoop","followers_url":"https://api.github.com/users/randoop/followers","following_url":"https://api.github.com/users/randoop/following{/other_user}","gists_url":"https://api.github.com/users/randoop/gists{/gist_id}","starred_url":"https://api.github.com/users/randoop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/randoop/subscriptions","organizations_url":"https://api.github.com/users/randoop/orgs","repos_url":"https://api.github.com/users/randoop/repos","events_url":"https://api.github.com/users/randoop/events{/privacy}","received_events_url":"https://api.github.com/users/randoop/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/randoop/randoop","description":"Automatic test generation for Java","fork":false,"url":"https://api.github.com/repos/randoop/randoop","forks_url":"https://api.github.com/repos/randoop/randoop/forks","keys_url":"https://api.github.com/repos/randoop/randoop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/randoop/randoop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/randoop/randoop/teams","hooks_url":"https://api.github.com/repos/randoop/randoop/hooks","issue_events_url":"https://api.github.com/repos/randoop/randoop/issues/events{/number}","events_url":"https://api.github.com/repos/randoop/randoop/events","assignees_url":"https://api.github.com/repos/randoop/randoop/assignees{/user}","branches_url":"https://api.github.com/repos/randoop/randoop/branches{/branch}","tags_url":"https://api.github.com/repos/randoop/randoop/tags","blobs_url":"https://api.github.com/repos/randoop/randoop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/randoop/randoop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/randoop/randoop/git/refs{/sha}","trees_url":"https://api.github.com/repos/randoop/randoop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/randoop/randoop/statuses/{sha}","languages_url":"https://api.github.com/repos/randoop/randoop/languages","stargazers_url":"https://api.github.com/repos/randoop/randoop/stargazers","contributors_url":"https://api.github.com/repos/randoop/randoop/contributors","subscribers_url":"https://api.github.com/repos/randoop/randoop/subscribers","subscription_url":"https://api.github.com/repos/randoop/randoop/subscription","commits_url":"https://api.github.com/repos/randoop/randoop/commits{/sha}","git_commits_url":"https://api.github.com/repos/randoop/randoop/git/commits{/sha}","comments_url":"https://api.github.com/repos/randoop/randoop/comments{/number}","issue_comment_url":"https://api.github.com/repos/randoop/randoop/issues/comments{/number}","contents_url":"https://api.github.com/repos/randoop/randoop/contents/{+path}","compare_url":"https://api.github.com/repos/randoop/randoop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/randoop/randoop/merges","archive_url":"https://api.github.com/repos/randoop/randoop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/randoop/randoop/downloads","issues_url":"https://api.github.com/repos/randoop/randoop/issues{/number}","pulls_url":"https://api.github.com/repos/randoop/randoop/pulls{/number}","milestones_url":"https://api.github.com/repos/randoop/randoop/milestones{/number}","notifications_url":"https://api.github.com/repos/randoop/randoop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/randoop/randoop/labels{/name}","releases_url":"https://api.github.com/repos/randoop/randoop/releases{/id}","created_at":"2015-05-01T20:42:29Z","updated_at":"2015-11-14T09:43:44Z","pushed_at":"2015-11-19T23:39:06Z","git_url":"git://github.com/randoop/randoop.git","ssh_url":"git@github.com:randoop/randoop.git","clone_url":"https://github.com/randoop/randoop.git","svn_url":"https://github.com/randoop/randoop","homepage":"http://randoop.github.io/randoop/","size":349162,"stargazers_count":13,"watchers_count":13,"language":"Java","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":6,"mirror_url":null,"open_issues_count":6,"forks":6,"open_issues":6,"watchers":13,"default_branch":"master"}},"base":{"label":"randoop:master","ref":"master","sha":"200ce62357752a67ec0bdd883776d13d5d370175","user":{"login":"randoop","id":15037885,"avatar_url":"https://avatars.githubusercontent.com/u/15037885?v=3","gravatar_id":"","url":"https://api.github.com/users/randoop","html_url":"https://github.com/randoop","followers_url":"https://api.github.com/users/randoop/followers","following_url":"https://api.github.com/users/randoop/following{/other_user}","gists_url":"https://api.github.com/users/randoop/gists{/gist_id}","starred_url":"https://api.github.com/users/randoop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/randoop/subscriptions","organizations_url":"https://api.github.com/users/randoop/orgs","repos_url":"https://api.github.com/users/randoop/repos","events_url":"https://api.github.com/users/randoop/events{/privacy}","received_events_url":"https://api.github.com/users/randoop/received_events","type":"Organization","site_admin":false},"repo":{"id":34923107,"name":"randoop","full_name":"randoop/randoop","owner":{"login":"randoop","id":15037885,"avatar_url":"https://avatars.githubusercontent.com/u/15037885?v=3","gravatar_id":"","url":"https://api.github.com/users/randoop","html_url":"https://github.com/randoop","followers_url":"https://api.github.com/users/randoop/followers","following_url":"https://api.github.com/users/randoop/following{/other_user}","gists_url":"https://api.github.com/users/randoop/gists{/gist_id}","starred_url":"https://api.github.com/users/randoop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/randoop/subscriptions","organizations_url":"https://api.github.com/users/randoop/orgs","repos_url":"https://api.github.com/users/randoop/repos","events_url":"https://api.github.com/users/randoop/events{/privacy}","received_events_url":"https://api.github.com/users/randoop/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/randoop/randoop","description":"Automatic test generation for Java","fork":false,"url":"https://api.github.com/repos/randoop/randoop","forks_url":"https://api.github.com/repos/randoop/randoop/forks","keys_url":"https://api.github.com/repos/randoop/randoop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/randoop/randoop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/randoop/randoop/teams","hooks_url":"https://api.github.com/repos/randoop/randoop/hooks","issue_events_url":"https://api.github.com/repos/randoop/randoop/issues/events{/number}","events_url":"https://api.github.com/repos/randoop/randoop/events","assignees_url":"https://api.github.com/repos/randoop/randoop/assignees{/user}","branches_url":"https://api.github.com/repos/randoop/randoop/branches{/branch}","tags_url":"https://api.github.com/repos/randoop/randoop/tags","blobs_url":"https://api.github.com/repos/randoop/randoop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/randoop/randoop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/randoop/randoop/git/refs{/sha}","trees_url":"https://api.github.com/repos/randoop/randoop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/randoop/randoop/statuses/{sha}","languages_url":"https://api.github.com/repos/randoop/randoop/languages","stargazers_url":"https://api.github.com/repos/randoop/randoop/stargazers","contributors_url":"https://api.github.com/repos/randoop/randoop/contributors","subscribers_url":"https://api.github.com/repos/randoop/randoop/subscribers","subscription_url":"https://api.github.com/repos/randoop/randoop/subscription","commits_url":"https://api.github.com/repos/randoop/randoop/commits{/sha}","git_commits_url":"https://api.github.com/repos/randoop/randoop/git/commits{/sha}","comments_url":"https://api.github.com/repos/randoop/randoop/comments{/number}","issue_comment_url":"https://api.github.com/repos/randoop/randoop/issues/comments{/number}","contents_url":"https://api.github.com/repos/randoop/randoop/contents/{+path}","compare_url":"https://api.github.com/repos/randoop/randoop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/randoop/randoop/merges","archive_url":"https://api.github.com/repos/randoop/randoop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/randoop/randoop/downloads","issues_url":"https://api.github.com/repos/randoop/randoop/issues{/number}","pulls_url":"https://api.github.com/repos/randoop/randoop/pulls{/number}","milestones_url":"https://api.github.com/repos/randoop/randoop/milestones{/number}","notifications_url":"https://api.github.com/repos/randoop/randoop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/randoop/randoop/labels{/name}","releases_url":"https://api.github.com/repos/randoop/randoop/releases{/id}","created_at":"2015-05-01T20:42:29Z","updated_at":"2015-11-14T09:43:44Z","pushed_at":"2015-11-19T23:39:06Z","git_url":"git://github.com/randoop/randoop.git","ssh_url":"git@github.com:randoop/randoop.git","clone_url":"https://github.com/randoop/randoop.git","svn_url":"https://github.com/randoop/randoop","homepage":"http://randoop.github.io/randoop/","size":349162,"stargazers_count":13,"watchers_count":13,"language":"Java","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":6,"mirror_url":null,"open_issues_count":6,"forks":6,"open_issues":6,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/randoop/randoop/pulls/62"},"html":{"href":"https://github.com/randoop/randoop/pull/62"},"issue":{"href":"https://api.github.com/repos/randoop/randoop/issues/62"},"comments":{"href":"https://api.github.com/repos/randoop/randoop/issues/62/comments"},"review_comments":{"href":"https://api.github.com/repos/randoop/randoop/pulls/62/comments"},"review_comment":{"href":"https://api.github.com/repos/randoop/randoop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/randoop/randoop/pulls/62/commits"},"statuses":{"href":"https://api.github.com/repos/randoop/randoop/statuses/8b17b3abb0c70f90a031c3688ede8daf8834c202"}}}}