{"action":"created","comment":{"url":"https://api.github.com/repos/lucidsoftware/piezo/pulls/comments/37209476","id":37209476,"diff_hunk":"@@ -1,7 +0,0 @@\n-#!/bin/bash\n-\n-SOURCE_DIR=\"$( cd \"$( dirname \"${BASH_SOURCE[0]}\" )\" && pwd )\"\n-DEPS_DIR=\"$SOURCE_DIR/../../../target/staged\"\n-QUARTZ_PROPS_FILE=\"$SOURCE_DIR/quartz.properties\"\n-\n-java -Dorg.quartz.properties=$QUARTZ_PROPS_FILE -Dpidfile.path=/tmp/pid -Dnetworkaddress.cache.ttl=10 -Dnetworkaddress.cache.negative.ttl=10 -cp \"${DEPS_DIR}/*\" com.lucidchart.piezo.Worker","path":"worker/src/main/resources/run.sh","position":7,"original_position":7,"commit_id":"b48e346ae7b89ba62466af9dcc814e4fda591fdc","original_commit_id":"b48e346ae7b89ba62466af9dcc814e4fda591fdc","user":{"login":"pauldraper","id":1403271,"avatar_url":"https://avatars.githubusercontent.com/u/1403271?v=3","gravatar_id":"","url":"https://api.github.com/users/pauldraper","html_url":"https://github.com/pauldraper","followers_url":"https://api.github.com/users/pauldraper/followers","following_url":"https://api.github.com/users/pauldraper/following{/other_user}","gists_url":"https://api.github.com/users/pauldraper/gists{/gist_id}","starred_url":"https://api.github.com/users/pauldraper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pauldraper/subscriptions","organizations_url":"https://api.github.com/users/pauldraper/orgs","repos_url":"https://api.github.com/users/pauldraper/repos","events_url":"https://api.github.com/users/pauldraper/events{/privacy}","received_events_url":"https://api.github.com/users/pauldraper/received_events","type":"User","site_admin":false},"body":"Apache, Jenkins, Nginx, IDEA, etc.\r\n\r\nWriting your own init or run scripts is generally not the preferred way.\r\n\r\nThe common way is to have them work mostly \"out of the box\", with the ability to drop configuration in a separate file to override defaults.\r\n\r\nI added that in `https://github.com/pauldraper/piezo/blob/pauldraper-refactor-build/admin/templates/conf`, which is placed in `/etc/piezo-admin/conf`.","created_at":"2015-08-17T16:56:53Z","updated_at":"2015-08-17T16:56:53Z","html_url":"https://github.com/lucidsoftware/piezo/pull/32#discussion_r37209476","pull_request_url":"https://api.github.com/repos/lucidsoftware/piezo/pulls/32","_links":{"self":{"href":"https://api.github.com/repos/lucidsoftware/piezo/pulls/comments/37209476"},"html":{"href":"https://github.com/lucidsoftware/piezo/pull/32#discussion_r37209476"},"pull_request":{"href":"https://api.github.com/repos/lucidsoftware/piezo/pulls/32"}}},"pull_request":{"url":"https://api.github.com/repos/lucidsoftware/piezo/pulls/32","id":42535493,"html_url":"https://github.com/lucidsoftware/piezo/pull/32","diff_url":"https://github.com/lucidsoftware/piezo/pull/32.diff","patch_url":"https://github.com/lucidsoftware/piezo/pull/32.patch","issue_url":"https://api.github.com/repos/lucidsoftware/piezo/issues/32","number":32,"state":"open","locked":false,"title":"Build improvments","user":{"login":"pauldraper","id":1403271,"avatar_url":"https://avatars.githubusercontent.com/u/1403271?v=3","gravatar_id":"","url":"https://api.github.com/users/pauldraper","html_url":"https://github.com/pauldraper","followers_url":"https://api.github.com/users/pauldraper/followers","following_url":"https://api.github.com/users/pauldraper/following{/other_user}","gists_url":"https://api.github.com/users/pauldraper/gists{/gist_id}","starred_url":"https://api.github.com/users/pauldraper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pauldraper/subscriptions","organizations_url":"https://api.github.com/users/pauldraper/orgs","repos_url":"https://api.github.com/users/pauldraper/repos","events_url":"https://api.github.com/users/pauldraper/events{/privacy}","received_events_url":"https://api.github.com/users/pauldraper/received_events","type":"User","site_admin":false},"body":"#### Upgrade SBT to 0.13.9\r\n\r\nIncludes fix for https://github.com/sbt/sbt/issues/1828.\r\n\r\n#### Admin build\r\n\r\nUse sbt-native-packager to create Debian package that installs the admin as an upstart job.\r\n\r\n```sh\r\nsbt debian:packageBin\r\nsudo dpkg -i target/piezo-admin*.deb\r\n```\r\n\r\nIt can be configured in [/etc/piezo-admin/conf](admin/templates/conf).\r\n\r\n```sh\r\nJAVA_OPTS+=-Dconfig.file=/etc/piezo-admin/application-overrides.conf\r\nJAVA_OPTS+=-Dhttp.port=80\r\n```\r\n\r\n(The .deb can be deployed to Sonatype, just like the worker, but an apt repo requires Packages.gz, and that is harder to produce. So I didn't touch anything here.)\r\n\r\n#### Worker build\r\n\r\nI removed dependencies:\r\n\r\n * Dispatch and javax.transaction - not used\r\n * Logback - SLF4J is there to remove dependencies on specific logging frameworks from libraries\r\n * MySQL - The worker can work with any JDBC, not just MySQL.\r\n\r\nInstead, a full runnable example with these dependencies is provided by [worker-example](worker-example).","created_at":"2015-08-16T12:13:15Z","updated_at":"2015-08-17T16:56:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b5e36dad0bba418f41649ffdc4472516a2d4065d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/lucidsoftware/piezo/pulls/32/commits","review_comments_url":"https://api.github.com/repos/lucidsoftware/piezo/pulls/32/comments","review_comment_url":"https://api.github.com/repos/lucidsoftware/piezo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lucidsoftware/piezo/issues/32/comments","statuses_url":"https://api.github.com/repos/lucidsoftware/piezo/statuses/b48e346ae7b89ba62466af9dcc814e4fda591fdc","head":{"label":"pauldraper:pauldraper-refactor-build","ref":"pauldraper-refactor-build","sha":"b48e346ae7b89ba62466af9dcc814e4fda591fdc","user":{"login":"pauldraper","id":1403271,"avatar_url":"https://avatars.githubusercontent.com/u/1403271?v=3","gravatar_id":"","url":"https://api.github.com/users/pauldraper","html_url":"https://github.com/pauldraper","followers_url":"https://api.github.com/users/pauldraper/followers","following_url":"https://api.github.com/users/pauldraper/following{/other_user}","gists_url":"https://api.github.com/users/pauldraper/gists{/gist_id}","starred_url":"https://api.github.com/users/pauldraper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pauldraper/subscriptions","organizations_url":"https://api.github.com/users/pauldraper/orgs","repos_url":"https://api.github.com/users/pauldraper/repos","events_url":"https://api.github.com/users/pauldraper/events{/privacy}","received_events_url":"https://api.github.com/users/pauldraper/received_events","type":"User","site_admin":false},"repo":{"id":27737395,"name":"piezo","full_name":"pauldraper/piezo","owner":{"login":"pauldraper","id":1403271,"avatar_url":"https://avatars.githubusercontent.com/u/1403271?v=3","gravatar_id":"","url":"https://api.github.com/users/pauldraper","html_url":"https://github.com/pauldraper","followers_url":"https://api.github.com/users/pauldraper/followers","following_url":"https://api.github.com/users/pauldraper/following{/other_user}","gists_url":"https://api.github.com/users/pauldraper/gists{/gist_id}","starred_url":"https://api.github.com/users/pauldraper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pauldraper/subscriptions","organizations_url":"https://api.github.com/users/pauldraper/orgs","repos_url":"https://api.github.com/users/pauldraper/repos","events_url":"https://api.github.com/users/pauldraper/events{/privacy}","received_events_url":"https://api.github.com/users/pauldraper/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pauldraper/piezo","description":"Piezo is a set of tools for operating a quartz scheduling cluster.","fork":true,"url":"https://api.github.com/repos/pauldraper/piezo","forks_url":"https://api.github.com/repos/pauldraper/piezo/forks","keys_url":"https://api.github.com/repos/pauldraper/piezo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pauldraper/piezo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pauldraper/piezo/teams","hooks_url":"https://api.github.com/repos/pauldraper/piezo/hooks","issue_events_url":"https://api.github.com/repos/pauldraper/piezo/issues/events{/number}","events_url":"https://api.github.com/repos/pauldraper/piezo/events","assignees_url":"https://api.github.com/repos/pauldraper/piezo/assignees{/user}","branches_url":"https://api.github.com/repos/pauldraper/piezo/branches{/branch}","tags_url":"https://api.github.com/repos/pauldraper/piezo/tags","blobs_url":"https://api.github.com/repos/pauldraper/piezo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pauldraper/piezo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pauldraper/piezo/git/refs{/sha}","trees_url":"https://api.github.com/repos/pauldraper/piezo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pauldraper/piezo/statuses/{sha}","languages_url":"https://api.github.com/repos/pauldraper/piezo/languages","stargazers_url":"https://api.github.com/repos/pauldraper/piezo/stargazers","contributors_url":"https://api.github.com/repos/pauldraper/piezo/contributors","subscribers_url":"https://api.github.com/repos/pauldraper/piezo/subscribers","subscription_url":"https://api.github.com/repos/pauldraper/piezo/subscription","commits_url":"https://api.github.com/repos/pauldraper/piezo/commits{/sha}","git_commits_url":"https://api.github.com/repos/pauldraper/piezo/git/commits{/sha}","comments_url":"https://api.github.com/repos/pauldraper/piezo/comments{/number}","issue_comment_url":"https://api.github.com/repos/pauldraper/piezo/issues/comments{/number}","contents_url":"https://api.github.com/repos/pauldraper/piezo/contents/{+path}","compare_url":"https://api.github.com/repos/pauldraper/piezo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pauldraper/piezo/merges","archive_url":"https://api.github.com/repos/pauldraper/piezo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pauldraper/piezo/downloads","issues_url":"https://api.github.com/repos/pauldraper/piezo/issues{/number}","pulls_url":"https://api.github.com/repos/pauldraper/piezo/pulls{/number}","milestones_url":"https://api.github.com/repos/pauldraper/piezo/milestones{/number}","notifications_url":"https://api.github.com/repos/pauldraper/piezo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pauldraper/piezo/labels{/name}","releases_url":"https://api.github.com/repos/pauldraper/piezo/releases{/id}","created_at":"2014-12-08T22:02:10Z","updated_at":"2014-12-08T22:02:11Z","pushed_at":"2015-08-16T11:50:52Z","git_url":"git://github.com/pauldraper/piezo.git","ssh_url":"git@github.com:pauldraper/piezo.git","clone_url":"https://github.com/pauldraper/piezo.git","svn_url":"https://github.com/pauldraper/piezo","homepage":null,"size":1845,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"lucidsoftware:master","ref":"master","sha":"fd0ba5f9c32fa32819fabeb48a6021d768392828","user":{"login":"lucidsoftware","id":3140022,"avatar_url":"https://avatars.githubusercontent.com/u/3140022?v=3","gravatar_id":"","url":"https://api.github.com/users/lucidsoftware","html_url":"https://github.com/lucidsoftware","followers_url":"https://api.github.com/users/lucidsoftware/followers","following_url":"https://api.github.com/users/lucidsoftware/following{/other_user}","gists_url":"https://api.github.com/users/lucidsoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/lucidsoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucidsoftware/subscriptions","organizations_url":"https://api.github.com/users/lucidsoftware/orgs","repos_url":"https://api.github.com/users/lucidsoftware/repos","events_url":"https://api.github.com/users/lucidsoftware/events{/privacy}","received_events_url":"https://api.github.com/users/lucidsoftware/received_events","type":"Organization","site_admin":false},"repo":{"id":15057536,"name":"piezo","full_name":"lucidsoftware/piezo","owner":{"login":"lucidsoftware","id":3140022,"avatar_url":"https://avatars.githubusercontent.com/u/3140022?v=3","gravatar_id":"","url":"https://api.github.com/users/lucidsoftware","html_url":"https://github.com/lucidsoftware","followers_url":"https://api.github.com/users/lucidsoftware/followers","following_url":"https://api.github.com/users/lucidsoftware/following{/other_user}","gists_url":"https://api.github.com/users/lucidsoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/lucidsoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucidsoftware/subscriptions","organizations_url":"https://api.github.com/users/lucidsoftware/orgs","repos_url":"https://api.github.com/users/lucidsoftware/repos","events_url":"https://api.github.com/users/lucidsoftware/events{/privacy}","received_events_url":"https://api.github.com/users/lucidsoftware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lucidsoftware/piezo","description":"Piezo is a set of tools for operating a quartz scheduling cluster.","fork":false,"url":"https://api.github.com/repos/lucidsoftware/piezo","forks_url":"https://api.github.com/repos/lucidsoftware/piezo/forks","keys_url":"https://api.github.com/repos/lucidsoftware/piezo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lucidsoftware/piezo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lucidsoftware/piezo/teams","hooks_url":"https://api.github.com/repos/lucidsoftware/piezo/hooks","issue_events_url":"https://api.github.com/repos/lucidsoftware/piezo/issues/events{/number}","events_url":"https://api.github.com/repos/lucidsoftware/piezo/events","assignees_url":"https://api.github.com/repos/lucidsoftware/piezo/assignees{/user}","branches_url":"https://api.github.com/repos/lucidsoftware/piezo/branches{/branch}","tags_url":"https://api.github.com/repos/lucidsoftware/piezo/tags","blobs_url":"https://api.github.com/repos/lucidsoftware/piezo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lucidsoftware/piezo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lucidsoftware/piezo/git/refs{/sha}","trees_url":"https://api.github.com/repos/lucidsoftware/piezo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lucidsoftware/piezo/statuses/{sha}","languages_url":"https://api.github.com/repos/lucidsoftware/piezo/languages","stargazers_url":"https://api.github.com/repos/lucidsoftware/piezo/stargazers","contributors_url":"https://api.github.com/repos/lucidsoftware/piezo/contributors","subscribers_url":"https://api.github.com/repos/lucidsoftware/piezo/subscribers","subscription_url":"https://api.github.com/repos/lucidsoftware/piezo/subscription","commits_url":"https://api.github.com/repos/lucidsoftware/piezo/commits{/sha}","git_commits_url":"https://api.github.com/repos/lucidsoftware/piezo/git/commits{/sha}","comments_url":"https://api.github.com/repos/lucidsoftware/piezo/comments{/number}","issue_comment_url":"https://api.github.com/repos/lucidsoftware/piezo/issues/comments{/number}","contents_url":"https://api.github.com/repos/lucidsoftware/piezo/contents/{+path}","compare_url":"https://api.github.com/repos/lucidsoftware/piezo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lucidsoftware/piezo/merges","archive_url":"https://api.github.com/repos/lucidsoftware/piezo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lucidsoftware/piezo/downloads","issues_url":"https://api.github.com/repos/lucidsoftware/piezo/issues{/number}","pulls_url":"https://api.github.com/repos/lucidsoftware/piezo/pulls{/number}","milestones_url":"https://api.github.com/repos/lucidsoftware/piezo/milestones{/number}","notifications_url":"https://api.github.com/repos/lucidsoftware/piezo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lucidsoftware/piezo/labels{/name}","releases_url":"https://api.github.com/repos/lucidsoftware/piezo/releases{/id}","created_at":"2013-12-09T19:57:48Z","updated_at":"2015-07-02T20:37:23Z","pushed_at":"2015-08-16T12:13:15Z","git_url":"git://github.com/lucidsoftware/piezo.git","ssh_url":"git@github.com:lucidsoftware/piezo.git","clone_url":"https://github.com/lucidsoftware/piezo.git","svn_url":"https://github.com/lucidsoftware/piezo","homepage":null,"size":3384,"stargazers_count":9,"watchers_count":9,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":13,"forks":4,"open_issues":13,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lucidsoftware/piezo/pulls/32"},"html":{"href":"https://github.com/lucidsoftware/piezo/pull/32"},"issue":{"href":"https://api.github.com/repos/lucidsoftware/piezo/issues/32"},"comments":{"href":"https://api.github.com/repos/lucidsoftware/piezo/issues/32/comments"},"review_comments":{"href":"https://api.github.com/repos/lucidsoftware/piezo/pulls/32/comments"},"review_comment":{"href":"https://api.github.com/repos/lucidsoftware/piezo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lucidsoftware/piezo/pulls/32/commits"},"statuses":{"href":"https://api.github.com/repos/lucidsoftware/piezo/statuses/b48e346ae7b89ba62466af9dcc814e4fda591fdc"}}}}