{"action":"created","comment":{"url":"https://api.github.com/repos/civicrm/civicrm-core/pulls/comments/45018207","id":45018207,"diff_hunk":"@@ -19,7 +19,7 @@\n       if (_.isObject(entity)) {\n         // eval content is locally generated.\n         /*jshint -W061 */\n-        p = backend(eval('('+angular.toJson(entity)+')'), message);\n+        p = backend(eval('('+angular.toJson(entity)+')'), action);","path":"ang/crmUtil.js","position":5,"original_position":5,"commit_id":"232785ea946283c40bf0a076488ca8eb8b81b3fb","original_commit_id":"232785ea946283c40bf0a076488ca8eb8b81b3fb","user":{"login":"totten","id":1336047,"avatar_url":"https://avatars.githubusercontent.com/u/1336047?v=3","gravatar_id":"","url":"https://api.github.com/users/totten","html_url":"https://github.com/totten","followers_url":"https://api.github.com/users/totten/followers","following_url":"https://api.github.com/users/totten/following{/other_user}","gists_url":"https://api.github.com/users/totten/gists{/gist_id}","starred_url":"https://api.github.com/users/totten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/totten/subscriptions","organizations_url":"https://api.github.com/users/totten/orgs","repos_url":"https://api.github.com/users/totten/repos","events_url":"https://api.github.com/users/totten/events{/privacy}","received_events_url":"https://api.github.com/users/totten/received_events","type":"User","site_admin":false},"body":"For someone skimming the function signature, it probably isn't obvious how params change. Maybe include something in the docblock?","created_at":"2015-11-17T03:17:22Z","updated_at":"2015-11-17T03:17:22Z","html_url":"https://github.com/civicrm/civicrm-core/pull/7225#discussion_r45018207","pull_request_url":"https://api.github.com/repos/civicrm/civicrm-core/pulls/7225","_links":{"self":{"href":"https://api.github.com/repos/civicrm/civicrm-core/pulls/comments/45018207"},"html":{"href":"https://github.com/civicrm/civicrm-core/pull/7225#discussion_r45018207"},"pull_request":{"href":"https://api.github.com/repos/civicrm/civicrm-core/pulls/7225"}}},"pull_request":{"url":"https://api.github.com/repos/civicrm/civicrm-core/pulls/7225","id":50897040,"html_url":"https://github.com/civicrm/civicrm-core/pull/7225","diff_url":"https://github.com/civicrm/civicrm-core/pull/7225.diff","patch_url":"https://github.com/civicrm/civicrm-core/pull/7225.patch","issue_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/7225","number":7225,"state":"open","locked":false,"title":"System status check improvements","user":{"login":"colemanw","id":2874912,"avatar_url":"https://avatars.githubusercontent.com/u/2874912?v=3","gravatar_id":"","url":"https://api.github.com/users/colemanw","html_url":"https://github.com/colemanw","followers_url":"https://api.github.com/users/colemanw/followers","following_url":"https://api.github.com/users/colemanw/following{/other_user}","gists_url":"https://api.github.com/users/colemanw/gists{/gist_id}","starred_url":"https://api.github.com/users/colemanw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colemanw/subscriptions","organizations_url":"https://api.github.com/users/colemanw/orgs","repos_url":"https://api.github.com/users/colemanw/repos","events_url":"https://api.github.com/users/colemanw/events{/privacy}","received_events_url":"https://api.github.com/users/colemanw/received_events","type":"User","site_admin":false},"body":null,"created_at":"2015-11-17T02:34:45Z","updated_at":"2015-11-17T03:17:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"66c1ce0199b57aee42f294b30eee8a074f7c6ef2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/civicrm/civicrm-core/pulls/7225/commits","review_comments_url":"https://api.github.com/repos/civicrm/civicrm-core/pulls/7225/comments","review_comment_url":"https://api.github.com/repos/civicrm/civicrm-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/7225/comments","statuses_url":"https://api.github.com/repos/civicrm/civicrm-core/statuses/232785ea946283c40bf0a076488ca8eb8b81b3fb","head":{"label":"colemanw:check","ref":"check","sha":"232785ea946283c40bf0a076488ca8eb8b81b3fb","user":{"login":"colemanw","id":2874912,"avatar_url":"https://avatars.githubusercontent.com/u/2874912?v=3","gravatar_id":"","url":"https://api.github.com/users/colemanw","html_url":"https://github.com/colemanw","followers_url":"https://api.github.com/users/colemanw/followers","following_url":"https://api.github.com/users/colemanw/following{/other_user}","gists_url":"https://api.github.com/users/colemanw/gists{/gist_id}","starred_url":"https://api.github.com/users/colemanw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colemanw/subscriptions","organizations_url":"https://api.github.com/users/colemanw/orgs","repos_url":"https://api.github.com/users/colemanw/repos","events_url":"https://api.github.com/users/colemanw/events{/privacy}","received_events_url":"https://api.github.com/users/colemanw/received_events","type":"User","site_admin":false},"repo":{"id":8513618,"name":"civicrm-core","full_name":"colemanw/civicrm-core","owner":{"login":"colemanw","id":2874912,"avatar_url":"https://avatars.githubusercontent.com/u/2874912?v=3","gravatar_id":"","url":"https://api.github.com/users/colemanw","html_url":"https://github.com/colemanw","followers_url":"https://api.github.com/users/colemanw/followers","following_url":"https://api.github.com/users/colemanw/following{/other_user}","gists_url":"https://api.github.com/users/colemanw/gists{/gist_id}","starred_url":"https://api.github.com/users/colemanw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colemanw/subscriptions","organizations_url":"https://api.github.com/users/colemanw/orgs","repos_url":"https://api.github.com/users/colemanw/repos","events_url":"https://api.github.com/users/colemanw/events{/privacy}","received_events_url":"https://api.github.com/users/colemanw/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/colemanw/civicrm-core","description":"CiviCRM (Core Application and Framework)","fork":true,"url":"https://api.github.com/repos/colemanw/civicrm-core","forks_url":"https://api.github.com/repos/colemanw/civicrm-core/forks","keys_url":"https://api.github.com/repos/colemanw/civicrm-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/colemanw/civicrm-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/colemanw/civicrm-core/teams","hooks_url":"https://api.github.com/repos/colemanw/civicrm-core/hooks","issue_events_url":"https://api.github.com/repos/colemanw/civicrm-core/issues/events{/number}","events_url":"https://api.github.com/repos/colemanw/civicrm-core/events","assignees_url":"https://api.github.com/repos/colemanw/civicrm-core/assignees{/user}","branches_url":"https://api.github.com/repos/colemanw/civicrm-core/branches{/branch}","tags_url":"https://api.github.com/repos/colemanw/civicrm-core/tags","blobs_url":"https://api.github.com/repos/colemanw/civicrm-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/colemanw/civicrm-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/colemanw/civicrm-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/colemanw/civicrm-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/colemanw/civicrm-core/statuses/{sha}","languages_url":"https://api.github.com/repos/colemanw/civicrm-core/languages","stargazers_url":"https://api.github.com/repos/colemanw/civicrm-core/stargazers","contributors_url":"https://api.github.com/repos/colemanw/civicrm-core/contributors","subscribers_url":"https://api.github.com/repos/colemanw/civicrm-core/subscribers","subscription_url":"https://api.github.com/repos/colemanw/civicrm-core/subscription","commits_url":"https://api.github.com/repos/colemanw/civicrm-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/colemanw/civicrm-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/colemanw/civicrm-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/colemanw/civicrm-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/colemanw/civicrm-core/contents/{+path}","compare_url":"https://api.github.com/repos/colemanw/civicrm-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/colemanw/civicrm-core/merges","archive_url":"https://api.github.com/repos/colemanw/civicrm-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/colemanw/civicrm-core/downloads","issues_url":"https://api.github.com/repos/colemanw/civicrm-core/issues{/number}","pulls_url":"https://api.github.com/repos/colemanw/civicrm-core/pulls{/number}","milestones_url":"https://api.github.com/repos/colemanw/civicrm-core/milestones{/number}","notifications_url":"https://api.github.com/repos/colemanw/civicrm-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/colemanw/civicrm-core/labels{/name}","releases_url":"https://api.github.com/repos/colemanw/civicrm-core/releases{/id}","created_at":"2013-03-02T01:06:53Z","updated_at":"2015-03-27T01:09:41Z","pushed_at":"2015-11-17T02:56:07Z","git_url":"git://github.com/colemanw/civicrm-core.git","ssh_url":"git@github.com:colemanw/civicrm-core.git","clone_url":"https://github.com/colemanw/civicrm-core.git","svn_url":"https://github.com/colemanw/civicrm-core","homepage":null,"size":104352,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"civicrm:master","ref":"master","sha":"9698a1d049d563275bcae2d55ee6670763fc1815","user":{"login":"civicrm","id":136373,"avatar_url":"https://avatars.githubusercontent.com/u/136373?v=3","gravatar_id":"","url":"https://api.github.com/users/civicrm","html_url":"https://github.com/civicrm","followers_url":"https://api.github.com/users/civicrm/followers","following_url":"https://api.github.com/users/civicrm/following{/other_user}","gists_url":"https://api.github.com/users/civicrm/gists{/gist_id}","starred_url":"https://api.github.com/users/civicrm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/civicrm/subscriptions","organizations_url":"https://api.github.com/users/civicrm/orgs","repos_url":"https://api.github.com/users/civicrm/repos","events_url":"https://api.github.com/users/civicrm/events{/privacy}","received_events_url":"https://api.github.com/users/civicrm/received_events","type":"Organization","site_admin":false},"repo":{"id":8495499,"name":"civicrm-core","full_name":"civicrm/civicrm-core","owner":{"login":"civicrm","id":136373,"avatar_url":"https://avatars.githubusercontent.com/u/136373?v=3","gravatar_id":"","url":"https://api.github.com/users/civicrm","html_url":"https://github.com/civicrm","followers_url":"https://api.github.com/users/civicrm/followers","following_url":"https://api.github.com/users/civicrm/following{/other_user}","gists_url":"https://api.github.com/users/civicrm/gists{/gist_id}","starred_url":"https://api.github.com/users/civicrm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/civicrm/subscriptions","organizations_url":"https://api.github.com/users/civicrm/orgs","repos_url":"https://api.github.com/users/civicrm/repos","events_url":"https://api.github.com/users/civicrm/events{/privacy}","received_events_url":"https://api.github.com/users/civicrm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/civicrm/civicrm-core","description":"CiviCRM (Core Application and Framework)","fork":false,"url":"https://api.github.com/repos/civicrm/civicrm-core","forks_url":"https://api.github.com/repos/civicrm/civicrm-core/forks","keys_url":"https://api.github.com/repos/civicrm/civicrm-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/civicrm/civicrm-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/civicrm/civicrm-core/teams","hooks_url":"https://api.github.com/repos/civicrm/civicrm-core/hooks","issue_events_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/events{/number}","events_url":"https://api.github.com/repos/civicrm/civicrm-core/events","assignees_url":"https://api.github.com/repos/civicrm/civicrm-core/assignees{/user}","branches_url":"https://api.github.com/repos/civicrm/civicrm-core/branches{/branch}","tags_url":"https://api.github.com/repos/civicrm/civicrm-core/tags","blobs_url":"https://api.github.com/repos/civicrm/civicrm-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/civicrm/civicrm-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/civicrm/civicrm-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/civicrm/civicrm-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/civicrm/civicrm-core/statuses/{sha}","languages_url":"https://api.github.com/repos/civicrm/civicrm-core/languages","stargazers_url":"https://api.github.com/repos/civicrm/civicrm-core/stargazers","contributors_url":"https://api.github.com/repos/civicrm/civicrm-core/contributors","subscribers_url":"https://api.github.com/repos/civicrm/civicrm-core/subscribers","subscription_url":"https://api.github.com/repos/civicrm/civicrm-core/subscription","commits_url":"https://api.github.com/repos/civicrm/civicrm-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/civicrm/civicrm-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/civicrm/civicrm-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/civicrm/civicrm-core/contents/{+path}","compare_url":"https://api.github.com/repos/civicrm/civicrm-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/civicrm/civicrm-core/merges","archive_url":"https://api.github.com/repos/civicrm/civicrm-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/civicrm/civicrm-core/downloads","issues_url":"https://api.github.com/repos/civicrm/civicrm-core/issues{/number}","pulls_url":"https://api.github.com/repos/civicrm/civicrm-core/pulls{/number}","milestones_url":"https://api.github.com/repos/civicrm/civicrm-core/milestones{/number}","notifications_url":"https://api.github.com/repos/civicrm/civicrm-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/civicrm/civicrm-core/labels{/name}","releases_url":"https://api.github.com/repos/civicrm/civicrm-core/releases{/id}","created_at":"2013-03-01T06:11:56Z","updated_at":"2015-11-14T00:27:39Z","pushed_at":"2015-11-17T02:56:08Z","git_url":"git://github.com/civicrm/civicrm-core.git","ssh_url":"git@github.com:civicrm/civicrm-core.git","clone_url":"https://github.com/civicrm/civicrm-core.git","svn_url":"https://github.com/civicrm/civicrm-core","homepage":null,"size":120896,"stargazers_count":137,"watchers_count":137,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":349,"mirror_url":null,"open_issues_count":101,"forks":349,"open_issues":101,"watchers":137,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/civicrm/civicrm-core/pulls/7225"},"html":{"href":"https://github.com/civicrm/civicrm-core/pull/7225"},"issue":{"href":"https://api.github.com/repos/civicrm/civicrm-core/issues/7225"},"comments":{"href":"https://api.github.com/repos/civicrm/civicrm-core/issues/7225/comments"},"review_comments":{"href":"https://api.github.com/repos/civicrm/civicrm-core/pulls/7225/comments"},"review_comment":{"href":"https://api.github.com/repos/civicrm/civicrm-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/civicrm/civicrm-core/pulls/7225/commits"},"statuses":{"href":"https://api.github.com/repos/civicrm/civicrm-core/statuses/232785ea946283c40bf0a076488ca8eb8b81b3fb"}}}}