{"action":"created","issue":{"url":"https://api.github.com/repos/deis/deis/issues/4347","labels_url":"https://api.github.com/repos/deis/deis/issues/4347/labels{/name}","comments_url":"https://api.github.com/repos/deis/deis/issues/4347/comments","events_url":"https://api.github.com/repos/deis/deis/issues/4347/events","html_url":"https://github.com/deis/deis/pull/4347","id":103387439,"number":4347,"title":"[WIP] chore(logspout): upgrade logspout","user":{"login":"krancour","id":1821014,"avatar_url":"https://avatars.githubusercontent.com/u/1821014?v=3","gravatar_id":"","url":"https://api.github.com/users/krancour","html_url":"https://github.com/krancour","followers_url":"https://api.github.com/users/krancour/followers","following_url":"https://api.github.com/users/krancour/following{/other_user}","gists_url":"https://api.github.com/users/krancour/gists{/gist_id}","starred_url":"https://api.github.com/users/krancour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krancour/subscriptions","organizations_url":"https://api.github.com/users/krancour/orgs","repos_url":"https://api.github.com/users/krancour/repos","events_url":"https://api.github.com/users/krancour/events{/privacy}","received_events_url":"https://api.github.com/users/krancour/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/deis/deis/labels/in%20progress","name":"in progress","color":"ededed"},{"url":"https://api.github.com/repos/deis/deis/labels/logspout","name":"logspout","color":"f7c6c7"},{"url":"https://api.github.com/repos/deis/deis/labels/needs%20rebase","name":"needs rebase","color":"f7c6c7"},{"url":"https://api.github.com/repos/deis/deis/labels/needs%20tests","name":"needs tests","color":"006b75"}],"state":"closed","locked":false,"assignee":{"login":"krancour","id":1821014,"avatar_url":"https://avatars.githubusercontent.com/u/1821014?v=3","gravatar_id":"","url":"https://api.github.com/users/krancour","html_url":"https://github.com/krancour","followers_url":"https://api.github.com/users/krancour/followers","following_url":"https://api.github.com/users/krancour/following{/other_user}","gists_url":"https://api.github.com/users/krancour/gists{/gist_id}","starred_url":"https://api.github.com/users/krancour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krancour/subscriptions","organizations_url":"https://api.github.com/users/krancour/orgs","repos_url":"https://api.github.com/users/krancour/repos","events_url":"https://api.github.com/users/krancour/events{/privacy}","received_events_url":"https://api.github.com/users/krancour/received_events","type":"User","site_admin":false},"milestone":null,"comments":5,"created_at":"2015-08-26T23:37:16Z","updated_at":"2015-12-11T01:13:54Z","closed_at":"2015-12-11T01:13:54Z","pull_request":{"url":"https://api.github.com/repos/deis/deis/pulls/4347","html_url":"https://github.com/deis/deis/pull/4347","diff_url":"https://github.com/deis/deis/pull/4347.diff","patch_url":"https://github.com/deis/deis/pull/4347.patch"},"body":"Fixes #4292 #4293 \r\n\r\nThis WIP PR uses upstream logspout v3 (without forking it!) along with a deis adapter module.\r\n\r\nWhen merged, this addresses many recent, notable log issues related to discovery, deadlock, Kubernetes, and more.  Some (not all) of these issues have _also_ been fixed in our ancient fork of logspout, but the point is I have attempted to keep this PR in feature / fix parity with what currently exists.\r\n\r\nWhy is this WIP?\r\n\r\n* Release of logspout v3 is pending\r\n* The plugin still requires unit and functional tests\r\n\r\n~~Ideally, also, it would be good to find a way to keep the adapter code right here in the deis/deis project.  That, however, would require that we deviate from upstream logspout's own documentation on how to produce custom builds that include our own adapter.  This may be worthwhile to figure out since it will mean one less repository to manage, but my early attempts at doing this have resulted in built images that are (somehow) much, much larger than what their documented custom build process produces.  I do intend to solve that.~~"},"comment":{"url":"https://api.github.com/repos/deis/deis/issues/comments/163801627","html_url":"https://github.com/deis/deis/pull/4347#issuecomment-163801627","issue_url":"https://api.github.com/repos/deis/deis/issues/4347","id":163801627,"user":{"login":"krancour","id":1821014,"avatar_url":"https://avatars.githubusercontent.com/u/1821014?v=3","gravatar_id":"","url":"https://api.github.com/users/krancour","html_url":"https://github.com/krancour","followers_url":"https://api.github.com/users/krancour/followers","following_url":"https://api.github.com/users/krancour/following{/other_user}","gists_url":"https://api.github.com/users/krancour/gists{/gist_id}","starred_url":"https://api.github.com/users/krancour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krancour/subscriptions","organizations_url":"https://api.github.com/users/krancour/orgs","repos_url":"https://api.github.com/users/krancour/repos","events_url":"https://api.github.com/users/krancour/events{/privacy}","received_events_url":"https://api.github.com/users/krancour/received_events","type":"User","site_admin":false},"created_at":"2015-12-11T01:13:54Z","updated_at":"2015-12-11T01:13:54Z","body":"Unless other maintainers disagree, I don't see this getting done.  Logspout v3 is a blocker for this and has been a long time coming.  Meanwhile, Deis v2 won't use logspout at all.  I can't see this as being something that makes it into a v1.x LTS, not can I see it as being something that makes the leap to V2."}}