{"action":"created","issue":{"url":"https://api.github.com/repos/calagator/calagator/issues/314","labels_url":"https://api.github.com/repos/calagator/calagator/issues/314/labels{/name}","comments_url":"https://api.github.com/repos/calagator/calagator/issues/314/comments","events_url":"https://api.github.com/repos/calagator/calagator/issues/314/events","html_url":"https://github.com/calagator/calagator/pull/314","id":56971212,"number":314,"title":"Convert to Rails Engine","user":{"login":"botandrose","id":17391,"avatar_url":"https://avatars.githubusercontent.com/u/17391?v=3","gravatar_id":"","url":"https://api.github.com/users/botandrose","html_url":"https://github.com/botandrose","followers_url":"https://api.github.com/users/botandrose/followers","following_url":"https://api.github.com/users/botandrose/following{/other_user}","gists_url":"https://api.github.com/users/botandrose/gists{/gist_id}","starred_url":"https://api.github.com/users/botandrose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/botandrose/subscriptions","organizations_url":"https://api.github.com/users/botandrose/orgs","repos_url":"https://api.github.com/users/botandrose/repos","events_url":"https://api.github.com/users/botandrose/events{/privacy}","received_events_url":"https://api.github.com/users/botandrose/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":10,"created_at":"2015-02-08T22:33:20Z","updated_at":"2015-02-23T19:52:14Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/calagator/calagator/pulls/314","html_url":"https://github.com/calagator/calagator/pull/314","diff_url":"https://github.com/calagator/calagator/pull/314.diff","patch_url":"https://github.com/calagator/calagator/pull/314.patch"},"body":"As discussed in #277, this PR converts the repo to an engine, and works in conjunction with the new calagator/calagator.org repo.\r\n\r\nInteresting changes:\r\n1. Tests are now run in a dummy app at `spec/dummy`\r\n2. Models, Controllers, etc are now namespaced under the top-level `Calagator` module.\r\n3. Theming has been removed, because the enclosing app is now the \"theme,\" so to speak.\r\n4. The `SETTINGS` constant has been removed, in favor of `mattr`s set on the top-level `Calagator` module, configured in an initializer in the app. Thanks @jamesmkur!\r\n\r\nI'm not sure if its 100% ready to merge yet, but everything seems to work well, so I'll leave that judgement up to you guys. This branch is also threatening to become rather long-lived, which makes me nervous. :) Possible merge blockers that I'm aware of:\r\n\r\n1. Assets are not namespaced.\r\n2. Database tables are not namespaced.\r\n3. README needs to be updated.\r\n4. Default css and images?\r\n\r\nThese could be done in separate PRs after this is merged, though, to prevent `master` and `engine` branches from diverging too much.\r\n\r\nWhat do you folks think?"},"comment":{"url":"https://api.github.com/repos/calagator/calagator/issues/comments/75618092","html_url":"https://github.com/calagator/calagator/pull/314#issuecomment-75618092","issue_url":"https://api.github.com/repos/calagator/calagator/issues/314","id":75618092,"user":{"login":"botandrose","id":17391,"avatar_url":"https://avatars.githubusercontent.com/u/17391?v=3","gravatar_id":"","url":"https://api.github.com/users/botandrose","html_url":"https://github.com/botandrose","followers_url":"https://api.github.com/users/botandrose/followers","following_url":"https://api.github.com/users/botandrose/following{/other_user}","gists_url":"https://api.github.com/users/botandrose/gists{/gist_id}","starred_url":"https://api.github.com/users/botandrose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/botandrose/subscriptions","organizations_url":"https://api.github.com/users/botandrose/orgs","repos_url":"https://api.github.com/users/botandrose/repos","events_url":"https://api.github.com/users/botandrose/events{/privacy}","received_events_url":"https://api.github.com/users/botandrose/received_events","type":"User","site_admin":false},"created_at":"2015-02-23T19:52:14Z","updated_at":"2015-02-23T19:52:14Z","body":"Cool, I'll wait for your verdict on big merge vs break up, then I'll rebase. Sorry I missed the code sprint! Was looking forward to reviewing all this with you in person, but Real Life got in the way. :("}}