{"action":"created","issue":{"url":"https://api.github.com/repos/LMMS/lmms/issues/2064","labels_url":"https://api.github.com/repos/LMMS/lmms/issues/2064/labels{/name}","comments_url":"https://api.github.com/repos/LMMS/lmms/issues/2064/comments","events_url":"https://api.github.com/repos/LMMS/lmms/issues/2064/events","html_url":"https://github.com/LMMS/lmms/pull/2064","id":78772448,"number":2064,"title":"Move core and gui classes into a 'lmms' namespace","user":{"login":"Wallacoloo","id":1210751,"avatar_url":"https://avatars.githubusercontent.com/u/1210751?v=3","gravatar_id":"","url":"https://api.github.com/users/Wallacoloo","html_url":"https://github.com/Wallacoloo","followers_url":"https://api.github.com/users/Wallacoloo/followers","following_url":"https://api.github.com/users/Wallacoloo/following{/other_user}","gists_url":"https://api.github.com/users/Wallacoloo/gists{/gist_id}","starred_url":"https://api.github.com/users/Wallacoloo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wallacoloo/subscriptions","organizations_url":"https://api.github.com/users/Wallacoloo/orgs","repos_url":"https://api.github.com/users/Wallacoloo/repos","events_url":"https://api.github.com/users/Wallacoloo/events{/privacy}","received_events_url":"https://api.github.com/users/Wallacoloo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-05-21T01:22:15Z","updated_at":"2015-05-25T04:42:02Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/LMMS/lmms/pulls/2064","html_url":"https://github.com/LMMS/lmms/pull/2064","diff_url":"https://github.com/LMMS/lmms/pull/2064.diff","patch_url":"https://github.com/LMMS/lmms/pull/2064.patch"},"body":"This change places all classes necessary to build lmms (i.e. everything in the src directory) into a namespace named \"lmms\". Notably, plugins are not namespaced, which made sense to me because many plugins (e.g. zynaddsubfx) aren't specific to lmms.\r\n\r\nThe motivation for this change is to fix #2049, as well as #2053, #2035 and possibly some other bugs that arose due to having one of the plugin classes (zynaddsubfx's `Engine` class) sharing the same name, and therefore vtable, as an lmms class.\r\n\r\nIt's a pretty significant change, so I think it deserves some testing. **Note that this does break theme compatibility** (see #2049 for an explanation of why). If the default theme still appears broken for you, open `settings` and make sure lmms isn't accidentally using an outdated version of it (e.g. in my case, I have a stable build of lmms in /usr/local and I install dev builds to ~/dev/lmms, but the dev builds will default to using the theme in /usr/local/share unless I explicitly specify it)."},"comment":{"url":"https://api.github.com/repos/LMMS/lmms/issues/comments/105123053","html_url":"https://github.com/LMMS/lmms/pull/2064#issuecomment-105123053","issue_url":"https://api.github.com/repos/LMMS/lmms/issues/2064","id":105123053,"user":{"login":"eagles051387","id":359984,"avatar_url":"https://avatars.githubusercontent.com/u/359984?v=3","gravatar_id":"","url":"https://api.github.com/users/eagles051387","html_url":"https://github.com/eagles051387","followers_url":"https://api.github.com/users/eagles051387/followers","following_url":"https://api.github.com/users/eagles051387/following{/other_user}","gists_url":"https://api.github.com/users/eagles051387/gists{/gist_id}","starred_url":"https://api.github.com/users/eagles051387/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eagles051387/subscriptions","organizations_url":"https://api.github.com/users/eagles051387/orgs","repos_url":"https://api.github.com/users/eagles051387/repos","events_url":"https://api.github.com/users/eagles051387/events{/privacy}","received_events_url":"https://api.github.com/users/eagles051387/received_events","type":"User","site_admin":false},"created_at":"2015-05-25T04:42:02Z","updated_at":"2015-05-25T04:42:02Z","body":"I think there is a bit of a middle ground here. Why not do this on its own\nbranch instead of on the mainline development branch?\n\nOn Mon, May 25, 2015 at 6:32 AM, Colin Wallace <notifications@github.com>\nwrote:\n\n> Strictly from a design point of view, is it desirable to have LMMS's code\n> in its own namespace? Because if it is desirable, then I believe that it\n> should happen. I don't see much of a reason to hold off on an improvement\n> just because it'll take a lot of work, especially when a lot of that work\n> has already been done.\n>\n> Also, moving lmms into a namespace was already discussed 2 weeks ago\n> <https://github.com/LMMS/lmms/issues/2049#issuecomment-101642738> and\n> nobody raised any complaints about it. Tresf even specifically called out\n> to you @Lukas-W <https://github.com/Lukas-W>. I don't mean to antagonize,\n> but frankly, people had plenty of time to voice any concerns about this\n> beforehand and nobody did.\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/LMMS/lmms/pull/2064#issuecomment-105121992>.\n>\n\n\n\n-- \nJonathan Aquilina\n"}}