{"action":"created","issue":{"url":"https://api.github.com/repos/bitcoin/bitcoin/issues/6163","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/6163/labels{/name}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/6163/comments","events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/6163/events","html_url":"https://github.com/bitcoin/bitcoin/pull/6163","id":78285266,"number":6163,"title":"Chainparams: Explicit Consensus::Params arg for almost all remaining functions","user":{"login":"jtimon","id":1008458,"avatar_url":"https://avatars.githubusercontent.com/u/1008458?v=3","gravatar_id":"","url":"https://api.github.com/users/jtimon","html_url":"https://github.com/jtimon","followers_url":"https://api.github.com/users/jtimon/followers","following_url":"https://api.github.com/users/jtimon/following{/other_user}","gists_url":"https://api.github.com/users/jtimon/gists{/gist_id}","starred_url":"https://api.github.com/users/jtimon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtimon/subscriptions","organizations_url":"https://api.github.com/users/jtimon/orgs","repos_url":"https://api.github.com/users/jtimon/repos","events_url":"https://api.github.com/users/jtimon/events{/privacy}","received_events_url":"https://api.github.com/users/jtimon/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/bitcoin/bitcoin/labels/Refactoring","name":"Refactoring","color":"E6F6D6"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":12,"created_at":"2015-05-19T23:02:13Z","updated_at":"2015-10-20T17:42:06Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/6163","html_url":"https://github.com/bitcoin/bitcoin/pull/6163","diff_url":"https://github.com/bitcoin/bitcoin/pull/6163.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/6163.patch"},"body":"Explicitly pass Consensus::Params to functions:\r\n\r\n-CheckBlockIndex\r\n-DisconnectTip\r\n-GetTransaction\r\n-InvalidateBlock\r\n-ProcessGetData\r\n-ReadBlockFromDisk\r\n\r\nWithout counting the following consensus functions (which is done in #6591):\r\n\r\n-CheckBlockHeader\r\n-CheckBlock\r\n-ContextualCheckBlockHeader\r\n-ContextualCheckBlock\r\n\r\nThese are all the functions that use Consensus::Params but not CChainParams."},"comment":{"url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments/149643797","html_url":"https://github.com/bitcoin/bitcoin/pull/6163#issuecomment-149643797","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/6163","id":149643797,"user":{"login":"jtimon","id":1008458,"avatar_url":"https://avatars.githubusercontent.com/u/1008458?v=3","gravatar_id":"","url":"https://api.github.com/users/jtimon","html_url":"https://github.com/jtimon","followers_url":"https://api.github.com/users/jtimon/followers","following_url":"https://api.github.com/users/jtimon/following{/other_user}","gists_url":"https://api.github.com/users/jtimon/gists{/gist_id}","starred_url":"https://api.github.com/users/jtimon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtimon/subscriptions","organizations_url":"https://api.github.com/users/jtimon/orgs","repos_url":"https://api.github.com/users/jtimon/repos","events_url":"https://api.github.com/users/jtimon/events{/privacy}","received_events_url":"https://api.github.com/users/jtimon/received_events","type":"User","site_admin":false},"created_at":"2015-10-20T17:42:06Z","updated_at":"2015-10-20T17:42:06Z","body":"Needed rebase (4)."}}